Timeline
Aug 16, 2010:
- 11:48 PM Changeset in webkit [65486] by
-
- 4 edits in trunk
2010-08-17 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GStreamer] media/invalid-media-url-crash.html fails
https://bugs.webkit.org/show_bug.cgi?id=42960
Implemented two ResourceHandleClient callbacks that need to notify
downstream GStreamer elements of errors while accessing the
resource.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (StreamingClient::wasBlocked): (StreamingClient::cannotShowURL):
LayoutTests:
2010-08-17 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GStreamer] media/invalid-media-url-crash.html fails
https://bugs.webkit.org/show_bug.cgi?id=42960
- platform/gtk/Skipped: Unskip fixed test
- 9:27 PM Changeset in webkit [65485] by
-
- 2 edits in trunk/WebKit/chromium
2010-08-16 Kinuko Yasuda <kinuko@chromium.org>
Unreviewed; attempt to fix Chromium Windows build.
- public/WebFileUtilities.h:
- 9:07 PM Changeset in webkit [65484] by
-
- 3 edits in trunk/WebKit2
Allow some tests to pass in WebKitTestRunner before SharedMemory and
PluginInfoStore are implemented on Windows.
Reviewed by Sam Weinig.
- Platform/win/SharedMemoryWin.cpp:
Disable not implemented warnings.
- UIProcess/Plugins/win/PluginInfoStoreWin.cpp:
Ditto.
- 8:59 PM Changeset in webkit [65483] by
-
- 2 edits in trunk/LayoutTests
2010-08-16 Yuta Kitamura <yutak@chromium.org>
Unreviewed test expectation update.
Update Chromium test expectations.
https://bugs.webkit.org/show_bug.cgi?id=44090
- platform/chromium/test_expectations.txt:
- 8:53 PM Changeset in webkit [65482] by
-
- 5 edits1 add in trunk/WebKit/chromium
2010-08-16 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Jian Li.
[chromium] Prepare to rename WebFileSystem interface to WebFileUtilities
https://bugs.webkit.org/show_bug.cgi?id=44077
We are going to have an implementation for HTML5 FileSystem API and
it would probably be less confusing to use the name "WebFileSystem"
for an WebKit API for the HTML5 API.
This patch adds WebFileUtilities interface that is meant to replace
the existing WebFileSystem.
- WebKit.gyp:
- public/WebFileSystem.h:
- public/WebFileUtilities.h: Added.
- public/WebKitClient.h: (WebKit::WebKitClient::fileUtilities): Added.
- src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::fileExists): (WebCore::ChromiumBridge::deleteFile): (WebCore::ChromiumBridge::deleteEmptyDirectory): (WebCore::ChromiumBridge::getFileSize): (WebCore::ChromiumBridge::getFileModificationTime): (WebCore::ChromiumBridge::directoryName): (WebCore::ChromiumBridge::pathByAppendingComponent): (WebCore::ChromiumBridge::makeAllDirectories): (WebCore::ChromiumBridge::getAbsolutePath): (WebCore::ChromiumBridge::isDirectory): (WebCore::ChromiumBridge::filePathToURL): (WebCore::ChromiumBridge::openFile): (WebCore::ChromiumBridge::closeFile): (WebCore::ChromiumBridge::seekFile): (WebCore::ChromiumBridge::truncateFile): (WebCore::ChromiumBridge::readFromFile): (WebCore::ChromiumBridge::writeToFile):
- 8:42 PM Changeset in webkit [65481] by
-
- 2 edits in trunk/WebKit/win
2010-08-16 Kinuko Yasuda <kinuko@chromium.org>
Unreviewed; build fix attempt for Windows.
- DefaultDownloadDelegate.cpp:
- 8:39 PM Changeset in webkit [65480] by
-
- 3 edits in trunk/LayoutTests
Add some tests that fail in WebKitTestRunner to the Skipped lists.
Rubber-stamped by Sam Weinig.
- platform/mac-wk2/Skipped:
- platform/win-wk2/Skipped:
- 7:21 PM Changeset in webkit [65479] by
-
- 3 edits in trunk/JavaScriptCore
Add VectorTraits to String & DefaultHash traits to UString to unify behaviour.
Rubber stamped by Sam Weinig
- runtime/UString.h:
(JSC::UStringHash::hash):
(JSC::UStringHash::equal):
(WTF::):
- wtf/text/WTFString.h:
(WTF::):
- 7:13 PM Changeset in webkit [65478] by
-
- 15 edits in trunk
Remove unnecessary includes from UString.h, add new includes as necessary.
Rubber stamped by Sam Weinig
- profiler/CallIdentifier.h:
- profiler/ProfileNode.h:
- runtime/DateConversion.cpp:
- runtime/Identifier.h:
(JSC::IdentifierRepHash::hash):
- runtime/RegExpCache.h:
- runtime/RegExpKey.h:
- runtime/UString.cpp:
(JSC::UString::substr):
- runtime/UString.h:
- wtf/text/WTFString.h:
WebCore:
- dom/ScriptExecutionContext.h:
- loader/appcache/ApplicationCache.cpp:
WebKit2:
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- 6:54 PM Changeset in webkit [65477] by
-
- 2 edits in trunk/LayoutTests
2010-08-16 Ademar de Souza Reis Jr <Ademar Reis>
Reviewed by Ariya Hidayat.
[Qt] REGRESSION: editing/selection/shrink-selection-after-shift-pagedown.html fails after 56567
https://bugs.webkit.org/show_bug.cgi?id=36628
Just enabling the test, it's not failing anymore.
- platform/qt/Skipped:
- 6:19 PM Changeset in webkit [65476] by
-
- 2 edits in trunk/LayoutTests
2010-08-16 Ademar de Souza Reis Jr <Ademar Reis>
Reviewed by Ariya Hidayat.
[Qt] qt/Skipped needs cleanup on outdaded comments
https://bugs.webkit.org/show_bug.cgi?id=44066
Minor improvements/fixes to the list of Skipped Qt tests
- move bug reference to the right place (#35145)
- remove outdated bug reference (#32922)
- move inspector testcase to the right place
- add reference to bug closed on qt-4.7 (QTBUG-9618)
- platform/qt/Skipped: cleanups only, no logical changes
- 6:09 PM Changeset in webkit [65475] by
-
- 3 edits in trunk
2010-08-16 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Darin Adler.
CSS: Add fast-path for rgba() color parsing
https://bugs.webkit.org/show_bug.cgi?id=42965
Test: fast/canvas/rgba-parsing.html
- css/CSSParser.cpp: (WebCore::CSSParser::parseColor): Extended with support for rgba(). (WebCore::parseAlphaValue): Added, parses an alpha value using WTF::strtod() (if necessary) and clamps between 0 and 1. (WebCore::isTenthAlpha):
2010-08-16 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Darin Adler.
CSS: Add fast-path for rgba() color parsing
https://bugs.webkit.org/show_bug.cgi?id=42965
Add a test of rgba() color parsing.
- fast/canvas/rgba-parsing-expected.txt: Added.
- fast/canvas/rgba-parsing.html: Added.
- fast/canvas/script-tests/rgba-parsing.js: Added.
- 6:07 PM Changeset in webkit [65474] by
-
- 16 edits14 adds in trunk/WebCore
2010-08-16 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Dumitru Daniliuc.
Add idl and mock classes for FileSystem API's {File,Directory}Entry and related interfaces
https://bugs.webkit.org/show_bug.cgi?id=43993
Adding DirectoryEntry, DirectoryReader, EntriesCallback and FileEntry as defined in HTML5 FileSystem API.
http://dev.w3.org/2009/dap/file-system/file-dir-sys.html
Also adding Makefile entries for idl and mock classes added in changeset 64414 (except for Android platforms).
Tests will be added when we add underlying implementation.
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pri:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- storage/DOMFileSystem.cpp: (WebCore::DOMFileSystem::root):
- storage/DOMFileSystem.h:
- storage/DOMFileSystem.idl:
- storage/DirectoryEntry.cpp: Added.
- storage/DirectoryEntry.h: Added.
- storage/DirectoryEntry.idl: Added.
- storage/DirectoryReader.cpp: Added.
- storage/DirectoryReader.h: Added.
- storage/DirectoryReader.idl: Added.
- storage/EntriesCallback.h: Added.
- storage/EntriesCallback.idl: Added.
- storage/EntryArray.cpp: Added.
- storage/EntryArray.h: Added.
- storage/EntryArray.idl: Added.
- storage/Entry.cpp: (WebCore::Entry::Entry): (WebCore::Entry::getMetadata): (WebCore::Entry::moveTo): (WebCore::Entry::copyTo): (WebCore::Entry::remove): (WebCore::Entry::getParent):
- storage/Entry.h: (WebCore::Entry::isFile): (WebCore::Entry::isDirectory):
- storage/Entry.idl:
- storage/FileEntry.cpp: Added.
- storage/FileEntry.h: Added.
- storage/FileEntry.idl: Added.
- 5:46 PM Changeset in webkit [65473] by
-
- 3 edits in trunk/WebKitTools
Add WebKit2 Mac tester to buildbot.
Reviewed by Mark Rowe.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- 5:41 PM Changeset in webkit [65472] by
-
- 4 edits3 adds in trunk
2010-08-16 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] Path::closeSubpath() should only close the last subpath if it has >1 point
https://bugs.webkit.org/show_bug.cgi?id=44061
Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-closepath
Test: fast/canvas/canvas-closePath-single-point.html
- platform/graphics/Path.h: Add a Qt-only member to track the last subpath.
- platform/graphics/qt/PathQt.cpp: (WebCore::Path::closeSubpath): Only close the last subpath if it has more than 1 point. Otherwise behave as moveTo(first point in last subpath) (WebCore::Path::Path): (WebCore::Path::operator=): (WebCore::Path::moveTo): (WebCore::Path::transform):
2010-08-16 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] Path::closeSubpath() should only close the last subpath if it has >1 point
https://bugs.webkit.org/show_bug.cgi?id=44061
Add a test to verify behavior of closePath() when path has only 1 point.
- fast/canvas/canvas-closePath-single-point-expected.txt: Added.
- fast/canvas/canvas-closePath-single-point.html: Added.
- fast/canvas/script-tests/canvas-closePath-single-point.js: Added.
- 5:20 PM Changeset in webkit [65471] by
-
- 2 edits in trunk/WebKit/chromium
2010-08-16 Nate Chapin <Nate Chapin>
Unreviewed, build fix.
Don't include TilingDataTest.cpp, since it doesn't
compile on mac.
- WebKit.gyp:
- 4:57 PM Changeset in webkit [65470] by
-
- 3 edits in trunk
2010-08-16 Nate Chapin <Nate Chapin>
Unreviewed, Chromium expectations update.
Mark 3 tests failing on Chromium Win/Linux after r65449.
They appear to have same root cause as
bugs.webkit.org/show_bug.cgi?id=43912.
- platform/chromium/test_expectations.txt:
- 4:37 PM Changeset in webkit [65469] by
-
- 2 edits in trunk/WebCore
2010-08-16 Nate Chapin <Nate Chapin>
Unreviewed, Chromium mac build fix (with help from jamesr).
- platform/chromium/ScrollbarThemeChromiumMac.mm: (WebCore::ScrollbarThemeChromiumMac::paint):
- 4:31 PM Changeset in webkit [65468] by
-
- 58 edits in trunk
Bug 44080 - String find/reverseFind methods need tidying up
These methods have a couple of problems with their interface, and implementation.
Reviewed by Sam Weinig
These methods take and int index, and return an int - however this is problematic
since on 64-bit string indices may have a full 32-bit range. This spills out into
surrounding code, which unsafely casts string indices from unsigned to int. Code
checking the result of these methods check for a mix of "== -1", "< 0", and
"== notFound". Clean this up by changing these methods to take an unsigned
starting index, and return a size_t. with a failed match indicated by notFound.
reverseFind also has a special meaning for the starting index argument, in that a
negative index is interpreted as an offset back from the end of the string. Remove
this functionality, in the (1!) case where it is used we should just calculate the
offset by subtracting from the string's length.
The implementation has a few problems too. The code is not in webkit style, in
using assorted abbreviations in variable names, and implementations of similar
find methods with differing argument types were unnecessarily inconsistent. When
find is passed const char* data the string would be handled as latin1 (zero
extended to UTF-16) for all characters but the first; this is sign extended.
Case-insensitive find is broken for unicode strings; the hashing optimization is
not unicode safe, and could result in false negatives.
Unify UString find methods to match String.
- JavaScriptCore.exp:
- bytecode/CodeBlock.cpp:
(JSC::escapeQuotes):
- bytecompiler/NodesCodegen.cpp:
(JSC::substitute):
- runtime/JSString.cpp:
(JSC::JSString::replaceCharacter):
- runtime/RegExp.cpp:
(JSC::RegExp::RegExp):
- runtime/RegExpKey.h:
(JSC::RegExpKey::getFlagsValue):
- runtime/StringPrototype.cpp:
(JSC::substituteBackreferencesSlow):
(JSC::substituteBackreferences):
(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncIndexOf):
(JSC::stringProtoFuncLastIndexOf):
(JSC::stringProtoFuncSplit):
- runtime/UString.cpp:
- runtime/UString.h:
(JSC::UString::find):
(JSC::UString::reverseFind):
- wtf/text/AtomicString.h:
(WTF::AtomicString::find):
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::find):
(WTF::StringImpl::findCaseInsensitive):
(WTF::StringImpl::reverseFind):
(WTF::StringImpl::reverseFindCaseInsensitive):
(WTF::StringImpl::endsWith):
(WTF::StringImpl::replace):
- wtf/text/StringImpl.h:
(WTF::StringImpl::startsWith):
- wtf/text/WTFString.cpp:
(WTF::String::split):
- wtf/text/WTFString.h:
(WTF::String::find):
(WTF::String::reverseFind):
(WTF::String::findCaseInsensitive):
(WTF::String::reverseFindCaseInsensitive):
(WTF::String::contains):
(WTF::find):
(WTF::reverseFind):
WebCore:
- css/CSSSelector.cpp:
(WebCore::CSSSelector::RareData::parseNth):
- css/CSSStyleDeclaration.cpp:
(WebCore::CSSStyleDeclaration::setProperty):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
- dom/Document.cpp:
(WebCore::Document::getImageMap):
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::inputText):
- editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::input):
- editing/TextIterator.cpp:
(WebCore::TextIterator::handleTextBox):
- editing/TypingCommand.cpp:
(WebCore::TypingCommand::insertText):
- editing/markup.cpp:
(WebCore::fillContainerFromString):
(WebCore::createFragmentFromText):
- html/File.cpp:
(WebCore::File::Init):
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::setHost):
- html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::parseMappedAttribute):
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::isPlaceholderEmpty):
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parseMappedAttribute):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::performSearch):
- loader/CrossOriginPreflightResultCache.cpp:
(WebCore::parseAccessControlAllowList):
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::substituteMIMETypeFromPluginDatabase):
- loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::parseHeader):
(WebCore::parseHeaders):
- loader/icon/IconFetcher.cpp:
(WebCore::parseIconLink):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::parseModalDialogFeatures):
- page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::createFromDatabaseIdentifier):
- page/UserContentURLPattern.cpp:
(WebCore::UserContentURLPattern::parse):
- page/XSSAuditor.cpp:
(WebCore::XSSAuditor::findInRequest):
- platform/ContentType.cpp:
(WebCore::ContentType::parameter):
(WebCore::ContentType::type):
- platform/KURL.cpp:
(WebCore::KURL::lastPathComponent):
(WebCore::KURL::setProtocol):
(WebCore::decodeURLEscapeSequences):
(WebCore::substituteBackslashes):
(WebCore::mimeTypeFromDataURL):
- platform/Length.cpp:
(WebCore::newCoordsArray):
(WebCore::newLengthArray):
- platform/LinkHash.cpp:
(WebCore::findSlashDotDotSlash):
(WebCore::findSlashSlash):
(WebCore::findSlashDotSlash):
(WebCore::cleanPath):
- platform/MIMETypeRegistry.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForPath):
- platform/SchemeRegistry.cpp:
(WebCore::SchemeRegistry::shouldTreatURLAsLocal):
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::load):
- platform/mac/DragImageMac.mm:
(WebCore::createDragImageIconForCachedImage):
- platform/network/CredentialStorage.cpp:
(WebCore::protectionSpaceMapKeyFromURL):
(WebCore::findDefaultProtectionSpaceForURL):
- platform/network/HTTPParsers.cpp:
(WebCore::skipWhiteSpace):
(WebCore::skipToken):
(WebCore::parseHTTPRefresh):
(WebCore::filenameFromHTTPContentDisposition):
(WebCore::findCharsetInMediaType):
(WebCore::parseXSSProtectionHeader):
(WebCore::extractReasonPhraseFromHTTPStatusLine):
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::isAttachment):
(WebCore::parseCacheHeader):
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::updateWidget):
- storage/Entry.cpp:
(WebCore::Entry::Entry):
- svg/SVGFont.cpp:
(WebCore::isCompatibleGlyph):
- svg/SVGURIReference.cpp:
(WebCore::SVGURIReference::getTarget):
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::parseClockValue):
(WebCore::SVGSMILElement::parseCondition):
- xml/XPathFunctions.cpp:
(WebCore::XPath::FunSubstringBefore::evaluate):
(WebCore::XPath::FunSubstringAfter::evaluate):
(WebCore::XPath::FunTranslate::evaluate):
(WebCore::XPath::FunLang::evaluate):
- xml/XPathParser.cpp:
(WebCore::XPath::Parser::expandQName):
- 4:23 PM Changeset in webkit [65467] by
-
- 4 edits2 adds in trunk
2010-08-16 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
REGRESSION(r65208): editing/pasteboard/smart-paste-003.html and smart-paste-004.html crash on Windows Chromium
https://bugs.webkit.org/show_bug.cgi?id=44070
The crash was caused by start or end node being removed in pushDownInlineStyleAroundNode.
It made start and end orphaned, and caused s.node() to be detached from the document.
Fixed the crash by using nodes passed to pushDownInlineStyleAroundNode for start and end if the original
start and end are orphaned because pushDownInlineStyleAroundNode won't prune targetNode.
Test: editing/pasteboard/smart-paste-003-trailing-whitespace.html
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeInlineStyle):
2010-08-16 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
REGRESSION(r65208): editing/pasteboard/smart-paste-003.html and smart-paste-004.html crash on Windows Chromium
https://bugs.webkit.org/show_bug.cgi?id=44070
The bug only reproduced on Windows when trailing space is selected only on Windows.
Added a crash test to copy & paste a word with trailing space.
- editing/pasteboard/smart-paste-003-trailing-whitespace-expected.txt: Added.
- editing/pasteboard/smart-paste-003-trailing-whitespace.html: Added.
- platform/chromium/test_expectations.txt: editing/pasteboard/smart-paste-003.html and smart-paste-004.html should not crash.
- 4:06 PM Changeset in webkit [65466] by
-
- 2 edits in trunk/WebKit2
Fix windows build.
- Shared/win/CommandLineWin.cpp:
- 4:00 PM Changeset in webkit [65465] by
-
- 46 edits in trunk/WebKit2
Remove #includes of <WebCore/PlatformString.h> in favor of <wtf/text/WTFString.h>
Reviewed by Gavin Barraclough.
- Platform/Module.cpp:
- Platform/Module.h:
- Shared/CommandLine.h:
- Shared/WebCoreArgumentCoders.h:
- Shared/WebEvent.h:
- Shared/WebNavigationDataStore.h:
- Shared/WebPreferencesStore.h:
- Shared/WebString.h:
- Shared/WebURL.h:
- Shared/mac/CommandLineMac.cpp:
- Shared/qt/UpdateChunk.cpp:
- UIProcess/API/C/WKContext.cpp:
- UIProcess/API/C/cf/WKStringCF.cpp:
- UIProcess/API/C/cf/WKURLCF.cpp:
- UIProcess/API/cpp/qt/WKStringQt.cpp:
- UIProcess/API/cpp/qt/WKURLQt.cpp:
- UIProcess/API/mac/PageClientImpl.mm:
- UIProcess/API/qt/qgraphicswkview.cpp:
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
- UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
- UIProcess/Launcher/win/ProcessLauncherWin.cpp:
- UIProcess/WebBackForwardListItem.cpp:
- UIProcess/WebBackForwardListItem.h:
- UIProcess/WebContext.h:
- UIProcess/WebContextInjectedBundleClient.cpp:
- UIProcess/WebFrameProxy.cpp:
- UIProcess/WebFrameProxy.h:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPolicyClient.cpp:
- UIProcess/WebProcessProxy.cpp:
- UIProcess/WebUIClient.cpp:
- UIProcess/win/WebView.cpp:
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
- WebProcess/InjectedBundle/InjectedBundle.h:
- WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
- WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:
- WebProcess/Plugins/JSNPObject.cpp:
- WebProcess/Plugins/NPJSObject.cpp:
- WebProcess/Plugins/Netscape/NetscapePluginModule.cpp:
- WebProcess/Plugins/Netscape/NetscapePluginModule.h:
- WebProcess/WebCoreSupport/WebChromeClient.h:
- WebProcess/WebKitMain.cpp:
- WebProcess/win/WebProcessMainWin.cpp:
- 3:54 PM Changeset in webkit [65464] by
-
- 2 edits1 add in trunk/LayoutTests
2010-08-16 Nate Chapin <Nate Chapin>
Chromium win rebaseline + test expectations tweaks.
- platform/chromium-win/svg/custom/absolute-sized-content-with-resources-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 3:48 PM Changeset in webkit [65463] by
-
- 4 edits in trunk
fix build
- 3:35 PM Changeset in webkit [65462] by
-
- 1 edit in trunk/WebCore/platform/graphics/GraphicsContext3D.h
Fix Chromium/Qt bustage.
- 3:32 PM Changeset in webkit [65461] by
-
- 1 edit in trunk/WebKit/chromium/src/GraphicsContext3D.cpp
Fix Chromium Bustage.
- 3:30 PM Changeset in webkit [65460] by
-
- 2 edits in trunk
Fix Chromium Bustage.
- 3:22 PM Changeset in webkit [65459] by
-
- 2 edits in trunk/WebKit2
Null CFURLRef returned from provisionalURL after searching on zillow.com
<rdar://problem/8261812>
https://bugs.webkit.org/show_bug.cgi?id=44072
Reviewed by Gavin Barraclough.
Conversion from WKURLRef to CFRURLRef was breaking on URLs using characters
such as '{'.
- UIProcess/API/C/cf/WKURLCF.cpp:
(WKURLCopyCFURL): Use code similar to that found in KURLCFNet.cpp for conversion.
- 2:48 PM Changeset in webkit [65458] by
-
- 3 edits in trunk/WebCore/platform/graphics
Fix Qt bustage.
- 2:43 PM Changeset in webkit [65457] by
-
- 3 edits in trunk/WebKit2
Remove unnecessary copy constructor, assignment operator and swap function.
The defaults (for all except swap) should do just fine.
Reviewed by Gavin Barraclough.
- Shared/WebPreferencesStore.cpp:
- Shared/WebPreferencesStore.h:
- 2:37 PM Changeset in webkit [65456] by
-
- 1 edit in trunk/WebCore/platform/graphics/qt/ImageBufferQt.cpp
Fix Qt build bustage.
- 2:36 PM Changeset in webkit [65455] by
-
- 10 edits3 adds in trunk
2010-08-16 Vincent Scheib <scheib@chromium.org>
Reviewed by Dimitri Glazkov.
Canvas2D does not support images larger than system's GPU max texture size
https://bugs.webkit.org/show_bug.cgi?id=43864
A new class "TilingData" has been created that provides logic for
splitting a large image into a series of smaller tiles.
GLES2Texture and CLES2Canvas are modified to use the TilingData to
split images on texture upload and render one logical image as many smaller
images.
TilingData is tested via unit tests in WebKit/chromium/tests/TilingDataTest.cpp
- WebCore.gypi:
- platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::drawTexturedRect): (WebCore::GLES2Canvas::drawTexturedRectTile):
- platform/graphics/chromium/GLES2Canvas.h:
- platform/graphics/chromium/GLES2Texture.cpp: (WebCore::GLES2Texture::GLES2Texture): (WebCore::GLES2Texture::~GLES2Texture): (WebCore::GLES2Texture::create): (WebCore::copySubRect): (WebCore::GLES2Texture::load): (WebCore::GLES2Texture::bindTile):
- platform/graphics/chromium/GLES2Texture.h: (WebCore::GLES2Texture::tiles):
- platform/graphics/chromium/TilingData.cpp: Added. (WebCore::computeNumTiles): (WebCore::TilingData::TilingData): (WebCore::TilingData::tileXIndexFromSrcCoord): (WebCore::TilingData::tileYIndexFromSrcCoord): (WebCore::TilingData::tileBounds): (WebCore::TilingData::tileBoundsWithBorder): (WebCore::TilingData::tileBoundsNormalized): (WebCore::TilingData::tilePositionX): (WebCore::TilingData::tilePositionY): (WebCore::TilingData::tileSizeX): (WebCore::TilingData::tileSizeY): (WebCore::TilingData::overlappedTileIndices): (WebCore::TilingData::intersectDrawQuad):
- platform/graphics/chromium/TilingData.h: Added. (WebCore::TilingData::maxTextureSize): (WebCore::TilingData::totalSizeX): (WebCore::TilingData::totalSizeY): (WebCore::TilingData::numTiles): (WebCore::TilingData::numTilesX): (WebCore::TilingData::numTilesY): (WebCore::TilingData::tileIndex): (WebCore::TilingData::tileXIndex): (WebCore::TilingData::tileYIndex): (WebCore::TilingData::TilingData): (WebCore::TilingData::assertTile):
- platform/graphics/skia/ImageSkia.cpp: (WebCore::BitmapImage::draw):
- platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::uploadSoftwareToHardware):
2010-08-16 Vincent Scheib <scheib@chromium.org>
Reviewed by Dimitri Glazkov.
Canvas2D does not support images larger than system's GPU max texture size
https://bugs.webkit.org/show_bug.cgi?id=43864
Unit tests for TilingData class.
- WebKit.gyp:
- tests/TilingDataTest.cpp: Added. (WebCore::TEST):
- 2:34 PM Changeset in webkit [65454] by
-
- 1 edit in trunk/WebCore/platform/graphics/cairo/ImageCairo.cpp
Fix GTK build bustage.
- 2:31 PM Changeset in webkit [65453] by
-
- 1 edit in trunk/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp
Fix GTK build bustage.
- 2:28 PM Changeset in webkit [65452] by
-
- 1 edit in trunk/WebCore/platform/graphics/qt/ImageBufferQt.cpp
Fix Qt build bustage.
- 2:26 PM Changeset in webkit [65451] by
-
- 1 edit in trunk/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp
Fix GTK build bustage.
- 2:21 PM Changeset in webkit [65450] by
-
- 1 edit in trunk/WebCore/platform/graphics/GraphicsContext3D.h
Put ANGLE include inside PLATFORM(MAC) to fix Chrome and Qt builds
- 1:44 PM Changeset in webkit [65449] by
-
- 49 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=43507, stop ImageBuffer from copying its data when rendering after canvas changes happen.
Reviewed by Anders Carlsson.
This patch renames ImageBuffer::image() to ImageBuffer::copyImage(). The new method always returns a new copy that is a current
snapshot of the ImageBuffer.
To draw an ImageBuffer, you now use new GraphicsContext calls: drawImageBuffer. Platforms can then optimize these calls to draw
efficiently without having to copy the bits of the ImageBuffer into an Image.
- WebCore.xcodeproj/project.pbxproj:
- css/CSSCanvasValue.cpp:
(WebCore::CSSCanvasValue::image):
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::willDraw):
(WebCore::HTMLCanvasElement::reset):
(WebCore::HTMLCanvasElement::paint):
(WebCore::HTMLCanvasElement::setSurfaceSize):
(WebCore::HTMLCanvasElement::copiedImage):
(WebCore::HTMLCanvasElement::clearCopiedImage):
- html/HTMLCanvasElement.h:
- html/canvas/CanvasPattern.cpp:
(WebCore::CanvasPattern::CanvasPattern):
- html/canvas/CanvasPattern.h:
(WebCore::CanvasPattern::create):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::createPattern):
(WebCore::CanvasRenderingContext2D::drawTextInternal):
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
(WebCore::WebGLRenderingContext::reshape):
(WebCore::WebGLRenderingContext::texImage2D):
(WebCore::WebGLRenderingContext::texSubImage2D):
- html/canvas/WebGLRenderingContext.h:
(WebCore::WebGLRenderingContext::paintsIntoCanvasBuffer):
- platform/graphics/GeneratedImage.cpp:
(WebCore::GeneratedImage::drawPattern):
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawImageBuffer):
(WebCore::GraphicsContext::clipToImageBuffer):
- platform/graphics/GraphicsContext.h:
- platform/graphics/GraphicsContext3D.h:
(WebCore::GraphicsContext3D::paintsIntoCanvasBuffer):
- platform/graphics/Image.h:
- platform/graphics/ImageBuffer.h:
(WebCore::ImageBuffer::width):
(WebCore::ImageBuffer::height):
- platform/graphics/Pattern.cpp:
(WebCore::Pattern::Pattern):
- platform/graphics/Pattern.h:
(WebCore::Pattern::create):
- platform/graphics/cairo/GraphicsContextCairo.cpp:
- platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::drawsUsingCopy):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::clip):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):
- platform/graphics/cg/GraphicsContextCG.cpp:
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::drawsUsingCopy):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):
(WebCore::ImageBuffer::clip):
- platform/graphics/cg/ImageBufferData.h:
- platform/graphics/filters/FEColorMatrix.cpp:
(WebCore::FEColorMatrix::apply):
- platform/graphics/filters/FEComposite.cpp:
(WebCore::FEComposite::apply):
- platform/graphics/filters/SourceAlpha.cpp:
(WebCore::SourceAlpha::apply):
- platform/graphics/filters/SourceGraphic.cpp:
(WebCore::SourceGraphic::apply):
- platform/graphics/mac/GraphicsContext3DMac.mm:
- platform/graphics/qt/GraphicsContext3DQt.cpp:
- platform/graphics/qt/GraphicsContextQt.cpp:
- platform/graphics/qt/ImageBufferData.h:
- platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBufferData::ImageBufferData):
(WebCore::ImageBuffer::drawsUsingCopy):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):
(WebCore::ImageBuffer::clip):
- platform/graphics/skia/GraphicsContextSkia.cpp:
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::drawsUsingCopy):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::clip):
(WebCore::):
- platform/graphics/wx/GraphicsContextWx.cpp:
- platform/graphics/wx/ImageBufferWx.cpp:
(WebCore::ImageBuffer::drawsUsingCopy):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::clip):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::paint):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
- rendering/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::applyClippingToContext):
- rendering/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::postApplyResource):
- rendering/RenderSVGResourceGradient.cpp:
(WebCore::clipToTextMask):
- rendering/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::applyResource):
- rendering/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::buildPattern):
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintProgressBar):
- svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::build):
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::nativeImageForCurrentFrame):
- svg/graphics/SVGImage.h:
- svg/graphics/filters/SVGFEMerge.cpp:
(WebCore::FEMerge::apply):
- svg/graphics/filters/SVGFEOffset.cpp:
(WebCore::FEOffset::apply):
- svg/graphics/filters/SVGFETile.cpp:
(WebCore::FETile::apply):
- 1:19 PM Changeset in webkit [65448] by
-
- 2 edits in trunk/WebCore
Fixed a warning in ANGLEWebKitBridge.cpp
- 1:15 PM Changeset in webkit [65447] by
-
- 1 edit in trunk/WebKitTools/Scripts/build-webkit
Build ANGLE for all versions of Mac to fix Leopard build
- 12:30 PM BuildingQtOnWindows edited by
- python 2.6 -> python 2.x (diff)
- 12:18 PM Changeset in webkit [65446] by
-
- 19 edits2 adds in trunk
2010-08-16 Paul Sawaya <psawaya@apple.com>
Reviewed by Chris Marrin.
Added shader validation via ANGLE
https://bugs.webkit.org/show_bug.cgi?id=42405
- 12:12 PM Changeset in webkit [65445] by
-
- 13 edits1 move in trunk
[wx] Build fix, do not build WebCore as a convenience library as this leads to
errors in the Win build w/export symbols and causes problems with DOM bindings
debugging in gdb.
- 12:00 PM Changeset in webkit [65444] by
-
- 2 edits in trunk/LayoutTests
2010-08-16 Mihai Parparita <mihaip@chromium.org>
Reviewed by Nate Chapin.
Some http/tests/history tests now pass on Chromium after r65340
https://bugs.webkit.org/show_bug.cgi?id=44033
Remove expected failures.
- platform/chromium/test_expectations.txt:
- 11:24 AM Changeset in webkit [65443] by
-
- 2 edits2 adds in trunk/WebCore
2010-08-16 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Adam Roben.
Current implementation of WebCore post-build step on windows platform is error prone.
It would be better to extract the script into external file.
https://bugs.webkit.org/show_bug.cgi?id=44058
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcproj/copyForwardingHeaders.cmd: Added.
- WebCore.vcproj/copyInspectorFiles.cmd: Added.
- 11:09 AM Changeset in webkit [65442] by
-
- 2 edits in trunk/WebCore
[wx] Fix typo in previous build fix.
- 11:04 AM Changeset in webkit [65441] by
-
- 5 edits in trunk
2010-08-16 Alex Milowski <alex@milowski.com>
Reviewed by David Levin.
Added the configuration of the MathML related files.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
2010-08-16 Alex Milowski <alex@milowski.com>
Reviewed by David Levin.
Added the ENABLE_MATHML=1 to the feature_defines.
- features.gypi:
- 10:39 AM Changeset in webkit [65440] by
-
- 2 edits in trunk/WebCore
2010-08-16 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: fix Leopard Release inspector tests.
- inspector/front-end/inspector.js:
- 10:30 AM Changeset in webkit [65439] by
-
- 7 edits3 copies1 add in trunk
2010-08-16 Marcus Bulach <bulach@chromium.org>
Reviewed by Jeremy Orlow.
Implements IDBKeyPath extractor.
https://bugs.webkit.org/show_bug.cgi?id=43276
Unit-test IDBKeyPathExtractorTest.cpp.
LayoutTests will arrive as IndexedDB infrastructure is fleshed out.
- bindings/v8/IDBBindingUtilities.cpp: (WebCore::getValueFrom): (WebCore::createIDBKeyFromSerializedValueAndKeyPath):
- bindings/v8/IDBBindingUtilities.h:
2010-08-16 Marcus Bulach <bulach@chromium.org>
Reviewed by Jeremy Orlow.
Implements IDBKeyPath extractor.
https://bugs.webkit.org/show_bug.cgi?id=43276
Unit-test IDBKeyPathExtractorTest.cpp.
LayoutTests will arrive as IndexedDB infrastructure is fleshed out.
- WebKit.gyp:
- public/WebIDBKey.h:
- public/WebIDBKeyPath.h: Added. (WebKit::WebIDBKeyPath::WebIDBKeyPath): (WebKit::WebIDBKeyPath::~WebIDBKeyPath):
- public/WebPrivateOwnPtr.h: Added. (WebKit::WebPrivateOwnPtr::WebPrivateOwnPtr): (WebKit::WebPrivateOwnPtr::~WebPrivateOwnPtr): (WebKit::WebPrivateOwnPtr::reset): (WebKit::WebPrivateOwnPtr::get): (WebKit::WebPrivateOwnPtr::operator->):
- src/WebIDBKey.cpp: (WebKit::WebIDBKey::createFromValueAndKeyPath):
- src/WebIDBKeyPath.cpp: Added. (WebKit::WebIDBKeyPath::create): (WebKit::WebIDBKeyPath::WebIDBKeyPath): (WebKit::WebIDBKeyPath::parseError): (WebKit::WebIDBKeyPath::assign): (WebKit::WebIDBKeyPath::reset): (WebKit::WebIDBKeyPath::operator const WTF::Vector<WebCore::IDBKeyPathElement, 0>&):
- tests/IDBBindingUtilitiesTest.cpp: Added. (WebCore::LocalContext::LocalContext): (WebCore::LocalContext::~LocalContext): (WebCore::checkKeyFromValueAndKeyPathInternal): (WebCore::checkKeyPathNullValue): (WebCore::checkKeyPathStringValue): (WebCore::checkKeyPathNumberValue): (WebCore::TEST):
- 10:10 AM Changeset in webkit [65438] by
-
- 2 edits in trunk/WebCore
2010-08-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Kenneth Rohde Christiansen and Martin Robinson.
[GTK] GTK+ drawing idle starved
https://bugs.webkit.org/show_bug.cgi?id=43994
Tune down the priority of the shared timers to guarantee GTK+ has
an opportunity to redraw.
- platform/gtk/SharedTimerGtk.cpp: (WebCore::setSharedTimerFireTime):
- 9:44 AM Changeset in webkit [65437] by
-
- 8 edits in trunk
2010-08-16 Leandro Pereira <leandro@profusion.mobi>
[EFL] Build fix after r65366.
- CMakeLists.txt: Use if (VAR) instead of if (${VAR}) to check if they're empty.
- jsc/CMakeLists.txt: Ditto.
- wtf/CMakeLists.txt: Ditto.
2010-08-16 Leandro Pereira <leandro@profusion.mobi>
[EFL] Build fix after r65366.
- CMakeLists.txt: Use if (VAR) instead of if (${VAR}) to check if they're empty.
2010-08-16 Leandro Pereira <leandro@profusion.mobi>
[EFL] Build fix after r65366.
EFL port does not support automated tests yet.
- CMakeLists.txt: Use if (VAR) instead of if (${VAR}) to check if they're empty.
- 9:40 AM Changeset in webkit [65436] by
-
- 2 edits in trunk/LayoutTests
Unreviewed build fix.
Add fast/dom/Geolocation/disconnected-frame-permission-denied.html to failing tests for Chromium
https://bugs.webkit.org/show_bug.cgi?id=44059
- platform/chromium/test_expectations.txt:
- 9:35 AM Changeset in webkit [65435] by
-
- 2 edits in trunk/WebKitTools
Build fix.
- WebKitTestRunner/TestController.cpp:
(WTR::createOtherPage): Initialize the contentsSizeChanged member.
(WTR::TestController::initialize): Ditto.
- 9:33 AM Changeset in webkit [65434] by
-
- 6 edits1 delete in trunk
2010-08-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Make InjectedScript proto-based.
https://bugs.webkit.org/show_bug.cgi?id=44028
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor): (injectedScriptConstructor.):
2010-08-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Make InjectedScript proto-based.
https://bugs.webkit.org/show_bug.cgi?id=44028
Drive-by test fix.
- http/tests/inspector-enabled/console-log-before-frame-navigation.html:
- http/tests/inspector-enabled/resources/console-log-before-frame-navigation.js: Removed.
- http/tests/inspector-enabled/resources/console-log-frame-before-navigation.html:
- 9:31 AM Changeset in webkit [65433] by
-
- 2 edits in trunk/WebKit/wx
wxMSW build fix. Don't build the Python DOM bindings until we get the export issues
sorted out.
- 9:29 AM Changeset in webkit [65432] by
-
- 2 edits in trunk/WebCore
Fix warning in WebCore/plugins/win/PluginPackageWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=43920
Reviewed by Adam Roben.
- plugins/win/PluginPackageWin.cpp:
(WebCore::PluginPackage::fetchInfo):
- 9:19 AM Changeset in webkit [65431] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt] fast/dom/Geolocation/disconnected-frame-permission-denied.html fails
https://bugs.webkit.org/show_bug.cgi?id=44059
- platform/qt/Skipped: fast/dom/Geolocation/disconnected-frame-permission-denied.html skipped until fix.
- 9:15 AM Changeset in webkit [65430] by
-
- 2 edits in trunk/WebCore
2010-08-16 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Touch inspector file to force frontend deployment.
- inspector/InspectorController.cpp:
- 9:06 AM Changeset in webkit [65429] by
-
- 2 edits in trunk/WebCore
[wx] Build fix for non-Win ports on Windows.
- 8:16 AM Changeset in webkit [65428] by
-
- 5 edits in trunk
2010-08-16 Adam Langley <agl@chromium.org>
Reviewed by Tony Chang.
[chromium] Improve spacing support for complex text on Linux
Previously, our complex text support ignored word-spacing,
justification and letter-spacing. This fixes the first two issues and
allows us to render Scribd's HTML5 documents much better.
Test: fast/text/atsui-spacing-features.html
- platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::TextRunWalker): (WebCore::TextRunWalker::setWordSpacingAdjustment): (WebCore::TextRunWalker::setLetterSpacingAdjustment): (WebCore::TextRunWalker::setPadding): (WebCore::TextRunWalker::setGlyphXPositions): (WebCore::TextRunWalker::isCodepointSpace): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText):
- 8:14 AM Changeset in webkit [65427] by
-
- 5 edits in trunk/WebCore
Fix warnings: unknown conversion type character 'l' in format
https://bugs.webkit.org/show_bug.cgi?id=43359
Reviewed by Kenneth Rohde Christiansen.
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::performURLImport): Replace %zu with %lu, because Windows doesn't understand z modifier.
(WebCore::IconDatabase::pruneUnretainedIcons): Use %I64i intsead of %lli on Windows.
- platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
(WebCore::MediaPlayerPrivate::totalTimeChanged): Use %I64d intsead of %lld on Windows.
- platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::setMaximumSize): Use %I64i intsead of %lli on Windows.
- storage/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::setQuota): Use %I64u intsead of %llu on Windows.
- 8:02 AM Changeset in webkit [65426] by
-
- 2 edits in trunk/WebCore
Fix warnings: unknown conversion type character 'l' in format
https://bugs.webkit.org/show_bug.cgi?id=43359
Reviewed by Kenneth Rohde Christiansen.
- loader/FTPDirectoryParser.cpp: Use %I64u format specifier instead of %llu on Windows.
(WebCore::parseOneFTPLine):
- 7:32 AM Changeset in webkit [65425] by
-
- 6 edits2 adds in trunk
[Qt] Shadow blur for rectangle fill
https://bugs.webkit.org/show_bug.cgi?id=44025
Patch by Ariya Hidayat <ariya@sencha.com> on 2010-08-16
Reviewed by Kenneth Rohde Christiansen.
WebCore:
The blur implementation follows the approximation of Gaussian blur
with three successive box blurs, working on the alpha channel only.
(see http://www.w3.org/TR/SVG/filters.html#feGaussianBlur).
- WebCore.pro: Refer to ContexShadow.* files.
- platform/graphics/qt/ContextShadow.cpp: Added.
(WebCore::ContextShadow::ContextShadow):
(WebCore::ContextShadow::clear):
(WebCore::blurHorizontal): Box blurs in horizontal direction, working
on QImage (in-place).
(WebCore::shadowBlur): Main blur function which just calls the
above blurHorizontal function twice, once with transposed image
(equivalent as it would have done vertical box blurs).
(WebCore::ContextShadow::drawShadowRect):
- platform/graphics/qt/ContextShadow.h: Added.
(WebCore::ContextShadow::):
- platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContextPlatformPrivate::hasShadow):
(WebCore::GraphicsContext::restorePlatformState):
(WebCore::GraphicsContext::fillRect): Use ContextShadow for the shadow.
(WebCore::GraphicsContext::setPlatformShadow):
LayoutTests:
Update pixel test reference after the blur support.
- platform/qt/fast/box-shadow/basic-shadows-expected.checksum:
- platform/qt/fast/box-shadow/basic-shadows-expected.png:
- 7:09 AM Changeset in webkit [65424] by
-
- 2 edits in trunk/WebCore
2010-08-16 Andras Becsi <abecsi@webkit.org>
Rubber-stamped by Gustavo Noronha Silva.
[GTK] Build fix for MathML code generation.
No new tests needed.
- GNUmakefile.am:
- 6:58 AM Changeset in webkit [65423] by
-
- 2 edits in trunk/WebCore
2010-08-16 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r65414.
http://trac.webkit.org/changeset/65414
https://bugs.webkit.org/show_bug.cgi?id=44055
GTL & QT tests failing. (Requested by pfeldman on #webkit).
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor): (injectedScriptConstructor.):
- 6:39 AM Changeset in webkit [65422] by
-
- 12 edits in trunk
2010-08-16 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Kenneth Rohde Christiansen.
Handle content size change in WebKit2
Re-landing after fix.
- MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
- MiniBrowser/win/BrowserView.cpp: (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
2010-08-16 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Kenneth Rohde Christiansen.
Handle content size change in WebKit2
Re-landing after fix.
Based on the work of Antti Koivisto.
Send message to the UI client when the contents size has changed through the WebChromeClient
and propagate it to the WKPageUIClient.
- Shared/CoreIPCSupport/WebPageProxyMessageKinds.h: (WebPageProxyMessage::): Added ContentsSizeChanged message kind.
- UIProcess/API/C/WKPage.h: Added WKPageContentsSizeChangedCallback callback to the WKPageUIClient.
- UIProcess/API/qt/qwkpage.cpp: (QWKPage::QWKPage): Initialize the new callback to 0.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveMessage): Handle ContentsSizeChanged message. Calls contetsSizeChanged. (WebKit::WebPageProxy::contentsSizeChanged): Added. Propagate the event to the the UI client.
- UIProcess/WebPageProxy.h:
- UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::contentsSizeChanged): Added. Propagate the event forward to the WKPageUIClient.
- UIProcess/WebUIClient.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::contentsSizeChanged): Implemented.
- 6:28 AM Changeset in webkit [65421] by
-
- 12 edits in trunk
2010-08-16 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r65419.
http://trac.webkit.org/changeset/65419
https://bugs.webkit.org/show_bug.cgi?id=44053
Broke the Windows build (Requested by bbandix on #webkit).
- Shared/CoreIPCSupport/WebPageProxyMessageKinds.h: (WebPageProxyMessage::):
- UIProcess/API/C/WKPage.h:
- UIProcess/API/qt/qwkpage.cpp: (QWKPage::QWKPage):
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveMessage):
- UIProcess/WebPageProxy.h:
- UIProcess/WebUIClient.cpp:
- UIProcess/WebUIClient.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::contentsSizeChanged):
2010-08-16 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r65419.
http://trac.webkit.org/changeset/65419
https://bugs.webkit.org/show_bug.cgi?id=44053
Broke the Windows build (Requested by bbandix on #webkit).
- MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController awakeFromNib]):
- MiniBrowser/win/BrowserView.cpp: (BrowserView::create):
- 5:58 AM Changeset in webkit [65420] by
-
- 2 edits in trunk/WebCore
2010-08-16 Ariya Hidayat <ariya@sencha.com>
Reviewed by Antonio Gomes.
[Qt] Save and restore shadow state in GraphicsContextQt
https://bugs.webkit.org/show_bug.cgi?id=44031
This is needed after r65362.
Use a new class ContextShadowParameter to track and keep the shadow
state. We use this rather than using GraphicsContextState to allow
possible optimizations (right now only to determine the shadow type,
but in future it might cover things like cached scratch image,
persistent shader, etc).
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::ContextShadowParameter::): (WebCore::ContextShadowParameter::ContextShadowParameter): (WebCore::ContextShadowParameter::clear): (WebCore::GraphicsContextPlatformPrivate::hasShadow): (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::savePlatformState): (WebCore::GraphicsContext::restorePlatformState): (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::setPlatformShadow): (WebCore::GraphicsContext::clearPlatformShadow):
- 5:52 AM Changeset in webkit [65419] by
-
- 12 edits in trunk
2010-08-16 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Kenneth Rohde Christiansen.
Handle content size change in WebKit2
- MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
- MiniBrowser/win/BrowserView.cpp: (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
2010-08-16 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Kenneth Rohde Christiansen.
Handle content size change in WebKit2
Based on the work of Antti Koivisto.
Send message to the UI client when the contents size has changed through the WebChromeClient
and propagate it to the WKPageUIClient.
- Shared/CoreIPCSupport/WebPageProxyMessageKinds.h: (WebPageProxyMessage::): Added ContentsSizeChanged message kind.
- UIProcess/API/C/WKPage.h: Added WKPageContentsSizeChangedCallback callback to the WKPageUIClient.
- UIProcess/API/qt/qwkpage.cpp: (QWKPage::QWKPage): Initialize the new callback to 0.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveMessage): Handle ContentsSizeChanged message. Calls contetsSizeChanged. (WebKit::WebPageProxy::contentsSizeChanged): Added. Propagate the event to the the UI client.
- UIProcess/WebPageProxy.h:
- UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::contentsSizeChanged): Added. Propagate the event forward to the WKPageUIClient.
- UIProcess/WebUIClient.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::contentsSizeChanged): Implemented.
- 5:44 AM Changeset in webkit [65418] by
-
- 2 edits in trunk/WebKitTools
Add my new email address to committers.py.
- Scripts/webkitpy/common/config/committers.py:
- 5:43 AM Changeset in webkit [65417] by
-
- 4 edits3 adds in trunk
2010-07-28 Marcus Bulach <bulach@chromium.org>
Reviewed by Adam Barth.
Implement IDBKeyPath parser.
https://bugs.webkit.org/show_bug.cgi?id=42976
IDBKeyPath is an internal class, exposed only for unit tests for now.
It'll allow indexed database implementation to traverse a given key path and obtain the corresponding properties
from a SerializedScriptValue.
- WebCore.gypi:
- storage/IDBKeyPath.cpp: Added. (WebCore::IDBKeyPath::create): (WebCore::IDBKeyPath::IDBKeyPath): (WebCore::IDBKeyPath::~IDBKeyPath): (WebCore::IDBKeyPath::hasNext): (WebCore::IDBKeyPath::next): (WebCore::IDBKeyPath::identifier): (WebCore::IDBKeyPath::hasIndex): (WebCore::IDBKeyPath::indexValue): (WebCore::IDBKeyPath::parserError): (WebCore::IDBKeyPath::parse): (WebCore::IDBKeyPath::Lexer::lex): (WebCore::isSafeIdentifierStartCharacter): (WebCore::isSafeIdentifierCharacter): (WebCore::IDBKeyPath::Lexer::lexIdentifier): (WebCore::IDBKeyPath::Lexer::lexNumber):
- storage/IDBKeyPath.h: Added. (WebCore::IDBKeyPath::Token::Token): (WebCore::IDBKeyPath::): (WebCore::IDBKeyPath::Lexer::Lexer): (WebCore::IDBKeyPath::Lexer::next): (WebCore::IDBKeyPath::Lexer::currentToken):
2010-07-28 Marcus Bulach <bulach@chromium.org>
Reviewed by Adam Barth.
Implement IDBKeyPath parser.
https://bugs.webkit.org/show_bug.cgi?id=42976
IDBKeyPath is an internal class, exposed only for unit tests for now.
It'll allow indexed database implementation to traverse a given key path and obtain the corresponding properties
from a SerializedScriptValue.
- WebKit.gyp:
- tests/IDBKeyPathTest.cpp: Added. (WebCore::ExpectedToken::ExpectedToken): (WebCore::checkKeyPath): (WebCore::TEST):
- 5:30 AM Changeset in webkit [65416] by
-
- 5 edits7 adds in trunk
2010-08-13 Steve Block <steveblock@google.com>
Reviewed by Alexey Proskuryakov.
Geolocation requests in progress when the frame is disconnected should invoke the error callback
https://bugs.webkit.org/show_bug.cgi?id=43974
If requests are ongoing when the Frame is disconnected, we abort them with a fatal error.
To do this, when Geolocation::disconnectFrame() is called we call cancelAllRequests() to
set a fatal error on all ongoing requests. Once the requests have made their error
callbacks, they are deleted. Note that we check at callback time that the script
execution context for the callback is still valid, so it's safe to attempt these
callbacks even after the Geolocation object's Frame has gone.
This requires a change to allow multiple calls to GeoNotifier::setFatalError().
For repeated calls, we do not replace the existing error. This ensures that when
permission has been denied and the frame is then disconnected, the error callback
reports the permission error, as required by the spec.
Tests: fast/dom/Geolocation/disconnected-frame.html
fast/dom/Geolocation/disconnected-frame-permission-denied.html
- page/Geolocation.cpp: (WebCore::Geolocation::GeoNotifier::setFatalError): (WebCore::Geolocation::disconnectFrame): (WebCore::Geolocation::startRequest): (WebCore::Geolocation::cancelAllRequests):
- page/Geolocation.h:
2010-08-13 Steve Block <steveblock@google.com>
Reviewed by Alexey Proskuryakov.
Geolocation requests in progress when the frame is disconnected should invoke the error callback
https://bugs.webkit.org/show_bug.cgi?id=43974
Added new tests to GTK skipped list.
- fast/dom/Geolocation/disconnected-frame.html: Added.
- fast/dom/Geolocation/disconnected-frame-expected.txt: Added.
- fast/dom/Geolocation/script-tests/disconnected-frame.js: Added.
- fast/dom/Geolocation/resources/disconnected-frame-inner.html: Added.
- fast/dom/Geolocation/disconnected-frame-permission-denied.html: Added.
- fast/dom/Geolocation/disconnected-frame-permission-denied-expected.txt: Added.
- fast/dom/Geolocation/script-tests/disconnected-frame-permission-denied.js: Added.
- platform/gtk/Skipped:
- 5:23 AM Changeset in webkit [65415] by
-
- 5 edits in trunk
2010-08-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: upstream frontend-side WebSocket transport.
https://bugs.webkit.org/show_bug.cgi?id=43970
Chromium already has an alternate WebSocket-based communication channel with
the backend. Upstreaming it in this change. We will agree on the URI
of the remote service as the protocol matures.
- inspector/front-end/inspector.js: (.WebInspector.socket.onmessage): (.WebInspector.socket.onerror): (.WebInspector.socket.onopen): (WebInspector.loaded): (WebInspector.doLoadedDone): (WebInspector_syncDispatch):
2010-08-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: upstream frontend-side WebSocket transport.
https://bugs.webkit.org/show_bug.cgi?id=43970
Chromium already has an alternate WebSocket-based communication channel with
the backend. Upstreaming it in this change. We will agree on the URI
of the remote service as the protocol matures.
- src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend):
- src/js/DevTools.js: (WebInspector.loaded): (devtools.domContentLoaded):
- 5:19 AM Changeset in webkit [65414] by
-
- 2 edits in trunk/WebCore
2010-08-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Make InjectedScript proto-based.
https://bugs.webkit.org/show_bug.cgi?id=44028
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor): (injectedScriptConstructor.):
- inspector/front-end/inspector.js: (WebInspector.loaded):
- 5:16 AM Changeset in webkit [65413] by
-
- 3 edits in trunk/WebKit/chromium
2010-08-16 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove utility context related code from debugger agent
https://bugs.webkit.org/show_bug.cgi?id=44049
- src/DebuggerAgentManager.cpp: (WebKit::DebuggerAgentManager::onV8DebugMessage): (WebKit::DebuggerAgentManager::pauseScript):
- src/DebuggerAgentManager.h:
- 5:16 AM Changeset in webkit [65412] by
-
- 8 edits2 adds in trunk
2010-08-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: [REGRESSION] console's clear command does not work.
https://bugs.webkit.org/show_bug.cgi?id=44027
- inspector/console-clear.html:
- inspector/console-command-clear-expected.txt: Added.
- inspector/console-command-clear.html: Copied from LayoutTests/inspector/console-clear.html.
2010-08-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: [REGRESSION] console's clear command does not work.
https://bugs.webkit.org/show_bug.cgi?id=44027
Test: inspector/console-command-clear.html
- inspector/Inspector.idl:
- inspector/InspectorBackend.cpp:
- inspector/InspectorBackend.h:
- inspector/InspectorController.cpp: (WebCore::InspectorController::clearConsoleMessages):
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.requestClearMessages):
- inspector/front-end/inspector.js: (WebInspector.consoleMessagesCleared):
- 4:57 AM Changeset in webkit [65411] by
-
- 2 edits in trunk/WebKit/chromium
2010-08-16 Yuta Kitamura <yutak@chromium.org>
Reviewed by Shinichiro Hamaji.
Attempt to fix Chromium's test_shell_tests.
Port Chromium's WebEntities to HTMLEntityTable
https://bugs.webkit.org/show_bug.cgi?id=44036
- src/WebEntities.cpp: (WebKit::):
- 4:26 AM Changeset in webkit [65410] by
-
- 5 edits in trunk/WebCore
2010-08-16 Jeremy Orlow <jorlow@chromium.org>
Ugh, the #if ENABLE() was supposed to be added to Settings not GroupSettings.
- page/GroupSettings.cpp: (WebCore::GroupSettings::GroupSettings): (WebCore::GroupSettings::setLocalStorageQuotaBytes):
- page/GroupSettings.h:
- page/Settings.cpp: (WebCore::Settings::Settings):
- page/Settings.h:
- 4:09 AM Changeset in webkit [65409] by
-
- 2 edits in trunk/WebCore
2010-08-16 Jeremy Orlow <jorlow@chromium.org>
Last build fix?
- page/PageGroup.cpp: (WebCore::PageGroup::PageGroup):
- 3:53 AM Changeset in webkit [65408] by
-
- 3 edits in trunk/WebCore
2010-08-16 Jeremy Orlow <jorlow@chromium.org>
Ugh...another build fix.
- page/GroupSettings.cpp: (WebCore::GroupSettings::GroupSettings):
- page/GroupSettings.h:
- 3:40 AM Changeset in webkit [65407] by
-
- 2 edits in trunk/WebCore
2010-08-16 Jeremy Orlow <jorlow@chromium.org>
Build fix.
- GNUmakefile.am:
- 3:20 AM Changeset in webkit [65406] by
-
- 2 edits in trunk/WebCore
2010-08-16 Jeremy Orlow <jorlow@chromium.org>
Build fix.
- page/PageGroup.cpp: (WebCore::PageGroup::localStorage):
- 3:02 AM Changeset in webkit [65405] by
-
- 12 edits2 adds in trunk/WebCore
2010-08-13 Jeremy Orlow <jorlow@chromium.org>
Some settings are linked to the PageGroup not the Page. Create a new class for those.
https://bugs.webkit.org/show_bug.cgi?id=43794
Since persistient storage is shared between pages, there's no way to modify
some settings related to it on a per page basis. As such, it's not technically
correct for these settings to be on the Page's settings. Create a new class
called GroupSettings, move group-wide local storage setting there (the other we
can't), and add a new setting for IndexedDB's path (which is prompting this change).
No behavior has changed, so no tests.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- page/GroupSettings.cpp: Added. (WebCore::GroupSettings::GroupSettings): (WebCore::GroupSettings::setLocalStorageQuotaBytes): (WebCore::GroupSettings::setLocalStorageDatabasePath): (WebCore::GroupSettings::setIndexedDBDatabasePath):
- page/GroupSettings.h: Added. (WebCore::GroupSettings::create): (WebCore::GroupSettings::localStorageQuotaBytes): (WebCore::GroupSettings::localStorageDatabasePath): (WebCore::GroupSettings::indexedDBDatabasePath):
- page/PageGroup.cpp: (WebCore::PageGroup::PageGroup): (WebCore::PageGroup::localStorage):
- page/PageGroup.h: (WebCore::PageGroup::groupSettings):
- page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setSessionStorageQuota):
- page/Settings.h:
- 2:44 AM Changeset in webkit [65404] by
-
- 2 edits in trunk/LayoutTests
2010-08-16 MORITA Hajime <morrita@google.com>
Unreviewed; test expectations fix for Chromium.
- platform/chromium/test_expectations.txt:
- 2:21 AM Changeset in webkit [65403] by
-
- 3 edits in trunk/WebKit2
Unreviewed Qt WebKit2 build fix.
Patch by Balazs Kelemen <kb@inf.u-szeged.hu> on 2010-08-16
- UIProcess/qt/WebContextQt.cpp:
(WebKit::WebContext::platformSetUpWebProcess): Added empty stub implementation.
- WebKit2.pro: Enumerate new files, include WebKit.pri for correct define macro set.
- 2:09 AM Changeset in webkit [65402] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-08-16 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
document.write causes the links to appear twice (noscript content is not ignored)
https://bugs.webkit.org/show_bug.cgi?id=16230
Add a test for this case.
- fast/parser/document-write-noscript-expected.txt: Added.
- fast/parser/document-write-noscript.html: Added.
- 1:51 AM Changeset in webkit [65401] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-08-16 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
document.write() isn't processed immediately before DOM access
https://bugs.webkit.org/show_bug.cgi?id=36881
Test that document.write gets flushed before DOM access takes place.
- fast/tokenizer/document-write-racing-dom-access-expected.txt: Added.
- fast/tokenizer/document-write-racing-dom-access.html: Added.
- 1:45 AM Changeset in webkit [65400] by
-
- 15 edits12 adds in trunk/LayoutTests
2010-08-16 Yuta Kitamura <yutak@chromium.org>
Not reviewed. Chromium test expectations updates and rebaselines.
- platform/chromium-linux/fast/canvas/setWidthResetAfterForcedRender-expected.checksum: Added.
- platform/chromium-linux/fast/canvas/setWidthResetAfterForcedRender-expected.png: Added.
- platform/chromium-linux/fast/text/word-space-expected.checksum:
- platform/chromium-linux/fast/text/word-space-expected.png:
- platform/chromium-linux/tables/mozilla/other/wa_table_thtd_rowspan-expected.checksum:
- platform/chromium-linux/tables/mozilla/other/wa_table_thtd_rowspan-expected.png:
- platform/chromium-mac/fast/canvas/setWidthResetAfterForcedRender-expected.checksum: Added.
- platform/chromium-mac/fast/canvas/setWidthResetAfterForcedRender-expected.png: Added.
- platform/chromium-mac/fast/text/word-space-expected.checksum: Added.
- platform/chromium-mac/fast/text/word-space-expected.png: Added.
- platform/chromium-mac/tables/mozilla/other/wa_table_thtd_rowspan-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/other/wa_table_thtd_rowspan-expected.png: Added.
- platform/chromium-win/fast/canvas/setWidthResetAfterForcedRender-expected.checksum: Added.
- platform/chromium-win/fast/canvas/setWidthResetAfterForcedRender-expected.png: Added.
- platform/chromium-win/fast/canvas/setWidthResetAfterForcedRender-expected.txt: Added.
- platform/chromium-win/fast/text/word-space-expected.checksum:
- platform/chromium-win/fast/text/word-space-expected.png:
- platform/chromium-win/fast/text/word-space-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-32-t-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.txt:
- platform/chromium-win/tables/mozilla/other/wa_table_thtd_rowspan-expected.checksum:
- platform/chromium-win/tables/mozilla/other/wa_table_thtd_rowspan-expected.png:
- platform/chromium-win/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
- platform/chromium-win/tables/mozilla/other/wa_table_tr_align-expected.txt:
- platform/chromium/test_expectations.txt:
- 1:45 AM Changeset in webkit [65399] by
-
- 2 edits in trunk/WebKitTools
2010-08-16 Zoltan Horvath <zoltan@webkit.org>
Add my old e-mail addresses to committers.py.
- Scripts/webkitpy/common/config/committers.py:
- 1:22 AM Changeset in webkit [65398] by
-
- 2 edits in trunk/LayoutTests
2010-08-16 MORITA Hajime <morrita@google.com>
Unreviewd, added skip list entries.
This is follow up for r65395. QT port ignores tests under
editing/pasteboard.
- platform/qt/Skipped:
- 1:14 AM Changeset in webkit [65397] by
-
- 2 edits in trunk/LayoutTests
2010-08-16 MORITA Hajime <morrita@google.com>
Unreviewd, added skip list entries.
This is follow up for r65395. GTK port ignores tests under
editing/pasteboard.
- platform/gtk/Skipped:
- 1:04 AM Changeset in webkit [65396] by
-
- 3 edits2 adds in trunk
2010-08-16 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
HTML5 fragment parsing doesn't load iframes
https://bugs.webkit.org/show_bug.cgi?id=44038
Test that iframes created in detached documents actually get loaded
when they're adopted into attached documents (or, rather, when they're
inserted into the DOM).
- fast/frames/adopt-from-created-document-expected.txt: Added.
- fast/frames/adopt-from-created-document.html: Added.
2010-08-16 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
HTML5 fragment parsing doesn't load iframes
https://bugs.webkit.org/show_bug.cgi?id=44038
Previously, this code assumed that every source iframe was actually
attached to a render tree. It tried to "keep the iframe alive" as it
moved documents. However, if the iframe wasn't attached to begin with,
it was never "alive," so trying to keep a dead iframe alive lead to a
... zombie iframe.
Test: fast/frames/adopt-from-created-document.html
- dom/Document.cpp: (WebCore::Document::adoptNode):
- 12:30 AM Changeset in webkit [65395] by
-
- 8 edits6 adds in trunk
2010-08-13 MORITA Hajime <morrita@google.com>
Reviewed by Tony Chang.
https://bugs.webkit.org/show_bug.cgi?id=43778
Dropping should fire textInput event.
- editing/pasteboard/drop-text-events-expected.txt: Added.
- editing/pasteboard/drop-text-events-sideeffect-expected.txt: Added.
- editing/pasteboard/drop-text-events-sideeffect.html: Added.
- editing/pasteboard/drop-text-events.html: Added.
- editing/pasteboard/script-tests/drop-text-events-sideeffect.js: Added.
- editing/pasteboard/script-tests/drop-text-events.js: Added.
2010-08-13 MORITA Hajime <morrita@google.com>
Reviewed by Tony Chang.
https://bugs.webkit.org/show_bug.cgi?id=43778
Dropping should fire textInput event
This change:
- added TextEvent::m_isDrop to distinguish drop-initiated events.
- added to dispatch TextEvent from DragController before making a side effect and cancel the side effect if the event prevents default
Tests: editing/pasteboard/drop-text-events-sideeffect.html
editing/pasteboard/drop-text-events.html
- dom/TextEvent.cpp: (WebCore::TextEvent::createForDrop): Added. (WebCore::TextEvent::TextEvent):
- dom/TextEvent.h: (WebCore::TextEvent::isDrop): Added.
- editing/Editor.cpp: (WebCore::Editor::handleTextEvent): (WebCore::Editor::findEventTargetFrom): Extracted from findEventTargetFromSelection(). (WebCore::Editor::findEventTargetFromSelection):
- editing/Editor.h:
- page/DragController.cpp: (WebCore::DragController::dispatchTextInputEventFor): Added. (WebCore::DragController::concludeEditDrag): Added an event dispatch path.
- page/DragController.h:
Aug 15, 2010:
- 11:38 PM Changeset in webkit [65394] by
-
- 2 edits in trunk/WebCore
2010-08-15 Ariya Hidayat <ariya@sencha.com>
Unreviewed, rolling out r65393.
http://trac.webkit.org/changeset/65393
https://bugs.webkit.org/show_bug.cgi?id=44031
Breaks some canvas tests.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::): (WebCore::GraphicsContextPlatformPrivate::hasShadow): (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::savePlatformState): (WebCore::GraphicsContext::restorePlatformState): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::setPlatformShadow): (WebCore::GraphicsContext::clearPlatformShadow):
- 11:19 PM Changeset in webkit [65393] by
-
- 2 edits in trunk/WebCore
[Qt] Save and restore shadow state in GraphicsContextQt
https://bugs.webkit.org/show_bug.cgi?id=44031
Patch by Ariya Hidayat <ariya@sencha.com> on 2010-08-15
Reviewed by Antonio Gomes.
This is needed after r65362.
Use a new class ContextShadowParameter to track and keep the shadow
state. We use this rather than using GraphicsContextState to allow
possible optimizations (right now only to determine the shadow type,
but in future it might cover things like cached scratch image,
persistent shader, etc).
- platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::ContextShadowParameter::):
(WebCore::ContextShadowParameter::ContextShadowParameter):
(WebCore::ContextShadowParameter::clear):
(WebCore::GraphicsContextPlatformPrivate::hasShadow):
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
(WebCore::GraphicsContext::savePlatformState):
(WebCore::GraphicsContext::restorePlatformState):
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::strokeArc):
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::clearPlatformShadow):
- 10:27 PM Changeset in webkit [65392] by
-
- 5 edits in trunk
2010-08-15 Ariya Hidayat <ariya@sencha.com>
Reviewed by Antonio Gomes.
[Qt] Border should not cast shadows
https://bugs.webkit.org/show_bug.cgi?id=44015
Update pixel test reference.
- platform/qt/fast/box-shadow/basic-shadows-expected.checksum:
- platform/qt/fast/box-shadow/basic-shadows-expected.png:
2010-08-15 Ariya Hidayat <ariya@sencha.com>
Reviewed by Antonio Gomes.
[Qt] Border should not cast shadows
https://bugs.webkit.org/show_bug.cgi?id=44015
Shadows should be not casted except for brush fill (which is not what
drawLine and drawRect are supposed to do).
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawRect): Remove shadow painting, (WebCore::GraphicsContext::drawLine): ditto.
- 8:28 PM Changeset in webkit [65391] by
-
- 4 edits in trunk
2010-08-15 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Build error on r65378
https://bugs.webkit.org/show_bug.cgi?id=44019
Add GENERATE_JSON macro for HTMLEntityNames.json instead of HTMLEntityNames.gperf
- cmake/WebKitMacros.cmake:
2010-08-15 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Build error on r65378
https://bugs.webkit.org/show_bug.cgi?id=44019
Change build script for HTMLEntityNames.json instead of HTMLEntityNames.gperf
- CMakeLists.txt:
- 6:58 PM Changeset in webkit [65390] by
-
- 5 edits in trunk/WebKitTools
WebEditorClient::didBeginEditing is never called in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42939
Reviewed by Sam Weinig.
- WebKitTestRunner/PlatformWebView.h:
Declare focus().
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
Focus the PlatformWebView.
- WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::focus):
Stubbed.
- WebKitTestRunner/win/PlatformWebViewWin.cpp:
(WTR::PlatformWebView::focus):
Focus the view.
- 6:57 PM Changeset in webkit [65389] by
-
- 2 edits in trunk/WebKitTools
run-webkit-tests should not strip editing callbacks when using
WebKitTestRunner on Windows
https://bugs.webkit.org/show_bug.cgi?id=44000
Reviewed by Mark Rowe.
- Scripts/old-run-webkit-tests:
Leave $stripEditingCallbacks undefined until we look for command-line
arguments. If using WebKit2, set it to 0 if not explicity set on the
command line. Later, set it to isCygwin() to match old behavior if it is
not yet defined.
- 6:48 PM Changeset in webkit [65388] by
-
- 3 edits in trunk/WebKit/chromium
2010-08-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Port Chromium's WebEntities to HTMLEntityTable
https://bugs.webkit.org/show_bug.cgi?id=44036
This code is wrong and needs to be removed. However, at least after
this patch, it will compile.
- src/WebEntities.cpp: (WebKit::): (WebKit::WebEntities::WebEntities):
- src/WebEntities.h:
- 5:12 PM Changeset in webkit [65387] by
-
- 2 edits in trunk/WebCore
[wx] Build fix, add missing header.
- 5:05 PM Changeset in webkit [65386] by
-
- 2 edits in trunk/WebCore
[wx] Build fix, don't build PluginDataNone.cpp even on GTK as PluginDataWx.cpp compiles.
- 5:02 PM Changeset in webkit [65385] by
-
- 2 edits in trunk/JavaScriptCore
[wx] Build fix, don't build intermediate source in DerivedSources dir.
- 4:47 PM Changeset in webkit [65384] by
-
- 2 edits in trunk/WebKitTools
[wx] Build fix, remove define always set to the correct value by wtf/Platform.h.
- 1:15 PM Changeset in webkit [65383] by
-
- 7 edits2 adds in trunk/WebKit
2010-08-14 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Pavel Feldman.
Web Inspector: -attach and detach should work
https://bugs.webkit.org/show_bug.cgi?id=43924
- WebKit.xcodeproj/project.pbxproj: Added WebInspectorFrontend.{h,mm}.
2010-08-14 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Pavel Feldman.
Web Inspector: -attach and detach should work
https://bugs.webkit.org/show_bug.cgi?id=43924
For actions that relate only to the Web Inspector's Frontend
window (actions on the InspectorFrontendClient) the new Obj-C
wrapper class WebInspectorFrontend can be used. For now, this
is just attach and detach.
- WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::openInspectorFrontend): setup and attach the WebInspectorFrontend to the WebInspector.
- WebInspector/WebInspector.h:
- WebInspector/WebInspector.mm: (-dealloc): (-attach:): delegate to the frontend. (-detach:): delegate to the frontend. (-setFrontend:):
- WebInspector/WebInspectorFrontend.h: Added.
- WebInspector/WebInspectorFrontend.mm: Added. (-[WebInspectorFrontend initWithFrontendClient:]): (-[WebInspectorFrontend attach]): (-[WebInspectorFrontend detach]):
- WebInspector/WebInspectorPrivate.h:
- 12:43 PM Changeset in webkit [65382] by
-
- 4 edits4 adds in trunk
2010-08-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
document.write() doesn't flush plain text
https://bugs.webkit.org/show_bug.cgi?id=8961
Add test cases for flushing character tokens.
- fast/tokenizer/flush-characters-in-document-write-evil-expected.txt: Added.
- fast/tokenizer/flush-characters-in-document-write-evil.html: Added.
- fast/tokenizer/flush-characters-in-document-write-expected.txt: Added.
- fast/tokenizer/flush-characters-in-document-write.html: Added.
2010-08-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
document.write() doesn't flush plain text
https://bugs.webkit.org/show_bug.cgi?id=8961
Originally I thought we should buffer the character tokens until we've
reached the end of the input stream, but that's not how the spec
handles things (it emits the character tokens one-by-one).
Tests: fast/tokenizer/flush-characters-in-document-write-evil.html
fast/tokenizer/flush-characters-in-document-write.html
- html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::emitEndOfFile):
(WebCore::HTMLTokenizer::nextToken):
(WebCore::HTMLTokenizer::haveBufferedCharacterToken):
- Renamed this function now that it's simplier.
- html/HTMLTokenizer.h:
- 8:34 AM Changeset in webkit [65381] by
-
- 3 edits2 adds in trunk
2010-08-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Don't try to replace a non-existent document after executing JavaScript URLs
https://bugs.webkit.org/show_bug.cgi?id=44024
Test what happens if a JavaScript URL returns a value after deleting
the frame it was supposed to operate on.
- fast/frames/javascript-url-for-deleted-frame-expected.txt: Added.
- fast/frames/javascript-url-for-deleted-frame.html: Added.
2010-08-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Don't try to replace a non-existent document after executing JavaScript URLs
https://bugs.webkit.org/show_bug.cgi?id=44024
Synchronous JavaScript execution is evil. Previously, the frame was
deleted after executing the JavaScript URL, so we'd get confused when
we tried to replace its document.
Test: fast/frames/javascript-url-for-deleted-frame.html
- bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
- 7:10 AM Changeset in webkit [65380] by
-
- 2 edits in trunk/WebKit/efl
2010-08-15 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Enable localStorage of HTML5 for WebKit EFL
https://bugs.webkit.org/show_bug.cgi?id=44020
- ewk/ewk_view.cpp: (_ewk_view_priv_new):
- 12:24 AM Changeset in webkit [65379] by
-
- 5 edits in trunk/WebKit2
Revised build fix from r65363 based on suggestion from Darin Adler.
- UIProcess/API/C/WKArray.h: Include stddef.h.
- UIProcess/API/C/WKBase.h: Uninclude ctype.h.
- UIProcess/API/C/WKData.h: Include stddef.h.
- UIProcess/API/C/WKDictionary.h: Ditto.
Aug 14, 2010:
- 6:29 PM Changeset in webkit [65378] by
-
- 2 edits in trunk/LayoutTests
2010-08-14 Martin Robinson <mrobinson@igalia.com>
[GTK] Some test results are one pixel different between the x86_64 and i386 bots
https://bugs.webkit.org/show_bug.cgi?id=39022
- platform/gtk/Skipped: Skip MathML tests which show 32-bit/64-bit rounding differences.
- 5:52 PM Changeset in webkit [65377] by
-
- 2 edits in trunk/WebKitTools
2010-08-14 Martin Robinson <mrobinson@igalia.com>
Reviewed by Kenneth Rohde Christiansen.
[GTK] autogen.sh not executed if build-webkit options change
https://bugs.webkit.org/show_bug.cgi?id=42266
Rerun autogen.sh in situations where the arguments to build-webkit have
changed since the previous build. This will fix some issues on the bots
where the build does not notice changes to default build-webkit arguments.
- Scripts/webkitdirs.pm: Add special logic for detecting changes to build-webkit arguments.
- 4:34 PM Changeset in webkit [65376] by
-
- 2 edits in trunk/WebCore
2010-08-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r65374.
http://trac.webkit.org/changeset/65374
https://bugs.webkit.org/show_bug.cgi?id=44018
broke a myriad of svg tests (Requested by kling on #webkit).
- platform/graphics/qt/PathQt.cpp: (WebCore::Path::strokeBoundingRect):
- 4:29 PM Changeset in webkit [65375] by
-
- 3 edits in trunk/WebCore
2010-08-14 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
XSLTProcessor.transformToFragment should not pass contextElement to html/xml document parsers
https://bugs.webkit.org/show_bug.cgi?id=44017
This fixes two tests which otherwise would fail when the
HTML5 TreeBuilder is enabled for fragment parsing.
This revealed a bug in HTMLTreeBuilder() which I fixed as well.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
- xml/XSLTProcessor.cpp: (WebCore::createFragmentFromSource):
- 3:44 PM Changeset in webkit [65374] by
-
- 2 edits in trunk/WebCore
2010-08-14 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] Path: Fast approximation of stroke bounding rects
https://bugs.webkit.org/show_bug.cgi?id=44014
- platform/graphics/qt/PathQt.cpp: (WebCore::Path::strokeBoundingRect): Use QPainterPath::controlPointRect() to calculate a slightly larger bounding rect in a fraction of the time.
- 3:00 PM Changeset in webkit [65373] by
-
- 2 edits in trunk/WebKit/qt
2010-08-14 Adam Barth <abarth@webkit.org>
Propagate name change to Qt.
- Api/qwebelement.cpp: (QWebElement::appendInside): (QWebElement::prependInside): (QWebElement::prependOutside): (QWebElement::appendOutside): (QWebElement::encloseContentsWith): (QWebElement::encloseWith):
- 2:38 PM Changeset in webkit [65372] by
-
- 7 edits in trunk/WebCore
2010-08-14 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Move innerHTML off of Range::createContextualFragment
https://bugs.webkit.org/show_bug.cgi?id=44011
This makes all the editing tests stop failing under the
HTML5 TreeBuilder.
In a previous patch Adam disabled some of the (wrong) code
in createContextualFragment when in html5 treebuilder mode.
The problem is that the editing code depends on
createContextualFragment (as well as the Range DOM API),
so we have to leave this code in until we can figure
out if it's right or wrong behavior for the Range API.
This patch moves innerHTML/outerHTML off of using
createContextualFragment and instead calls
DocumentFragment::parseHTML directly (which is much simpler).
I expect Adam and I will end up turning on the HTML5 TreeBuilder
in the next couple days, and most of the if branches I added
here will go away for good.
I renamed Element::createContextualFragment to
deprecatedCreateContextualFragment, to indicate that it's a
dead API. The editing code should move off of it and consider
using DocumentFragment::parseHTML instead.
- dom/Element.cpp: (WebCore::Element::deprecatedCreateContextualFragment):
- dom/Element.h:
- dom/Range.cpp: (WebCore::Range::createContextualFragment):
- editing/markup.cpp: (WebCore::createFragmentFromMarkup):
- html/HTMLElement.cpp: (WebCore::useLegacyTreeBuilder): (WebCore::HTMLElement::deprecatedCreateContextualFragment): (WebCore::HTMLElement::setInnerHTML): (WebCore::HTMLElement::setOuterHTML):
- html/HTMLElement.h:
- 12:24 PM Changeset in webkit [65371] by
-
- 2 edits in trunk/WebCore
2010-08-14 Tasuku Suzuki <tasuku.suzuki@nokia.com>
Reviewed by Antonio Gomes.
[Qt] Fix compilation with QT_NO_LINEEDIT
https://bugs.webkit.org/show_bug.cgi?id=38324
- bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertValueToQVariant): (JSC::Bindings::convertQVariantToValue):
- 10:53 AM Changeset in webkit [65370] by
-
- 10 edits4 adds in trunk
2010-08-14 Rob Buis <rwlbuis@gmail.com>
Reviewed by Dirk Schulze.
IE SVG empty path test fails
https://bugs.webkit.org/show_bug.cgi?id=44008
Change createLine to allow creating zero-length lines. This makes it possible
to have markers and line-caps applied to zero-length lines.
Test: svg/custom/marker-empty-path.svg
- platform/graphics/Path.cpp: (WebCore::Path::createLine):
- 9:34 AM Changeset in webkit [65369] by
-
- 4 edits in trunk
2010-08-14 Patrick Gansterer <paroga@paroga.com>
Reviewed by Kenneth Rohde Christiansen.
[CMake] Add preprocessor detection for generator scripts
https://bugs.webkit.org/show_bug.cgi?id=43984
- cmake/OptionsCommon.cmake:
2010-08-14 Patrick Gansterer <paroga@paroga.com>
Reviewed by Kenneth Rohde Christiansen.
[CMake] Add preprocessor detection for generator scripts
https://bugs.webkit.org/show_bug.cgi?id=43984
- CMakeLists.txt:
- 8:53 AM Changeset in webkit [65368] by
-
- 2 edits in trunk/WebCore
2010-08-14 Patrick Gansterer <paroga@paroga.com>
Reviewed by Kenneth Rohde Christiansen.
[CMake] Move SQL files into a IF (ENABLE_DATABASE) section
https://bugs.webkit.org/show_bug.cgi?id=43979
- CMakeLists.txt:
- 8:36 AM Changeset in webkit [65367] by
-
- 2 edits5 adds in trunk
2010-08-14 Matthew Delaney <mdelaney@apple.com>
Reviewed by Kenneth Rohde Christiansen.
Canvas is not reset when setting canvas.width
https://bugs.webkit.org/show_bug.cgi?id=43341
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::reset): Moved the call to hasCreatedImageBuffer up *before* the call to setSurface since setSurface sets hasCreatedImageBuffer to false every time.
- 8:17 AM Changeset in webkit [65366] by
-
- 8 edits in trunk
2010-08-14 Patrick Gansterer <paroga@paroga.com>
Reviewed by Kenneth Rohde Christiansen.
[CMake] Set target properties only if available
https://bugs.webkit.org/show_bug.cgi?id=43978
- CMakeLists.txt:
- jsc/CMakeLists.txt:
- wtf/CMakeLists.txt:
2010-08-14 Patrick Gansterer <paroga@paroga.com>
Reviewed by Kenneth Rohde Christiansen.
[CMake] Set target properties only if available
https://bugs.webkit.org/show_bug.cgi?id=43978
- CMakeLists.txt:
2010-08-14 Patrick Gansterer <paroga@paroga.com>
Reviewed by Kenneth Rohde Christiansen.
[CMake] Set target properties only if available
https://bugs.webkit.org/show_bug.cgi?id=43978
- CMakeLists.txt:
- 8:00 AM Changeset in webkit [65365] by
-
- 2 edits in trunk
2010-08-14 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Rohde Christiansen.
Update .gitignore file for more files
https://bugs.webkit.org/show_bug.cgi?id=43991
- .gitignore:
- 7:11 AM Changeset in webkit [65364] by
-
- 2 edits in trunk/WebCore
2010-08-14 Dirk Schulze <krit@webkit.org>
Unreviewed sort of Xcode project file.
- WebCore.xcodeproj/project.pbxproj:
- 6:41 AM MathML 3 testsuite results edited by
- (diff)
- 6:06 AM MathML 3 testsuite results edited by
- (diff)
- 5:53 AM MathML 3 testsuite results edited by
- (diff)
- 5:51 AM MathML 3 testsuite results edited by
- (diff)
- 5:45 AM MathML 3 testsuite results edited by
- (diff)
- 5:39 AM MathML 3 testsuite results edited by
- (diff)
- 2:11 AM MathML 3 testsuite results edited by
- (diff)
- 1:39 AM Changeset in webkit [65363] by
-
- 2 edits in trunk/WebKit2
Clean build of WebKitTestRunner fails with “'size_t' has not been declared” in WKArray.h
https://bugs.webkit.org/show_bug.cgi?id=44005
Reviewed by Anders Carlsson in Sweden.
- UIProcess/API/C/WKBase.h: Include ctype.h.
- 1:22 AM Changeset in webkit [65362] by
-
- 2 edits in trunk/WebCore
2010-08-14 Ariya Hidayat <ariya@sencha.com>
Reviewed by Simon Hausmann and Kenneth Rohde Christiansen.
[Qt] Refactor shadow state handling in GraphicsContextQt
https://bugs.webkit.org/show_bug.cgi?id=44006
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::): Added shadow states as member variables. (WebCore::GraphicsContextPlatformPrivate::hasShadow): Convenient function to check whether there is shadow or not. (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::drawRect): Use shadow states instead of calling getShadow. (WebCore::GraphicsContext::drawLine): ditto. (WebCore::GraphicsContext::strokeArc): ditto. (WebCore::GraphicsContext::drawConvexPolygon): ditto. (WebCore::GraphicsContext::fillPath): ditto. (WebCore::GraphicsContext::strokePath): ditto. (WebCore::GraphicsContext::fillRect): Removes the use of helper function drawBorderlessRectShadow as the code already becomes a lot simpler. (WebCore::GraphicsContext::fillRoundedRect): Removes the use of helper
function drawFilledShadowPath as the code already becomes a lot simpler.
(WebCore::GraphicsContext::setPlatformShadow): Store shadow states
and find out the shadow type (complexity) for future use.
(WebCore::GraphicsContext::clearPlatformShadow): Reset shadow states.
- 1:04 AM Changeset in webkit [65361] by
-
- 3 edits in trunk/LayoutTests
2010-08-14 Ariya Hidayat <ariya@sencha.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Outdated pixel test reference for fast/box-shadow/transform-fringing.html
https://bugs.webkit.org/show_bug.cgi?id=44007
- platform/qt/fast/box-shadow/transform-fringing-expected.checksum:
- platform/qt/fast/box-shadow/transform-fringing-expected.png:
- 12:17 AM Changeset in webkit [65360] by
-
- 2 edits in trunk/WebKitTools
2010-08-14 Eric Seidel <eric@webkit.org>
Unreviewed. Another fix to support python 2.3.
Add support for MathML entities
https://bugs.webkit.org/show_bug.cgi?id=43949
- Scripts/webkitpy/thirdparty/simplejson/decoder.py:
- It looks like our simplejson is version 1.7.3 which should be python 2.3 compatible. But someone modified our copy slightly from the original source. I've removed the relative import in hopes this fixes the problem.
Aug 13, 2010:
- 11:44 PM Changeset in webkit [65359] by
-
- 2 edits in trunk/WebKitTools
2010-08-13 Eric Seidel <eric@webkit.org>
Unreviewed. Build fix only.
Add support for MathML entities
https://bugs.webkit.org/show_bug.cgi?id=43949
- Scripts/create-html-entity-table:
- Hack sys.path to avoid executing 2.5 dependent python on systems (like chromium-win and Tiger) which do not have 2.5 python.
- 11:26 PM Changeset in webkit [65358] by
-
- 7 edits in trunk
2010-08-13 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Rename some concepts in HTML entity search to be more self-documenting
https://bugs.webkit.org/show_bug.cgi?id=44004
Start and end are now first and last, which lets us use some better
names for the statics in HTMLEntityTable.
- html/HTMLEntityParser.cpp: (WebCore::consumeHTMLEntity):
- html/HTMLEntitySearch.cpp: (WebCore::HTMLEntitySearch::HTMLEntitySearch): (WebCore::HTMLEntitySearch::findFirst): (WebCore::HTMLEntitySearch::findLast): (WebCore::HTMLEntitySearch::advance):
- html/HTMLEntitySearch.h: (WebCore::HTMLEntitySearch::isEntityPrefix): (WebCore::HTMLEntitySearch::mostRecentMatch): (WebCore::HTMLEntitySearch::fail):
- html/HTMLEntityTable.h:
2010-08-13 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Rename some concepts in HTML entity search to be more self-documenting
https://bugs.webkit.org/show_bug.cgi?id=44004
Reflect name change in generator script.
- Scripts/create-html-entity-table:
- 11:03 PM Changeset in webkit [65357] by
-
- 4 edits in trunk/LayoutTests
2010-08-13 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Make it easier to run LayoutTests in Firefox
https://bugs.webkit.org/show_bug.cgi?id=44002
Firefox doesn't seem to have innerText. Instead, let's just use the
normal DOM operations.
- fast/parser/resources/p-in-scope.js:
- fast/table/incomplete-table-in-fragment-2.html:
- fast/table/incomplete-table-in-fragment-hang.html:
- 10:09 PM Changeset in webkit [65356] by
-
- 2 edits in trunk/JavaScriptCore
[wx] Build fix, add CString to the list of forwards.
- 10:05 PM Changeset in webkit [65355] by
-
- 8 edits in trunk/LayoutTests
2010-08-13 Adam Barth <abarth@webkit.org>
Update test expectations to account for the HTML5 entity parser. There
are two main differences:
1) The value of lang and rang have changed.
2) We now parse FOO<BAR as FOO<BAR.
- fast/parser/entities-in-html-expected.txt:
- fast/parser/entities-in-xhtml-expected.txt:
- http/tests/security/xssAuditor/link-onclick-entities-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-entities-expected.txt:
- This test expectation is wrong. It's on my list to redesign how the XSS auditor works now that we have better parsing tools. Rather than skip the test on all platforms, I'm updating the expectation.
- platform/mac/fast/text/word-space-expected.txt:
- platform/mac/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
- platform/mac/tables/mozilla/other/wa_table_tr_align-expected.txt:
- 9:57 PM Changeset in webkit [65354] by
-
- 2 edits in trunk/WebCore
2010-08-13 Adam Barth <abarth@webkit.org>
Fix ASSERT in XML entity parsing. You can't advance the entity search
if you've already discovered that your string is not an entity.
- html/HTMLEntityParser.cpp: (WebCore::decodeNamedEntity):
- 8:32 PM Changeset in webkit [65353] by
-
- 2 edits in trunk/WebCore
2010-08-13 Eric Seidel <eric@webkit.org>
Unreviewed. Attempt at fixing Chromium build.
Add support for MathML entities
https://bugs.webkit.org/show_bug.cgi?id=43949
- WebCore.gyp/WebCore.gyp:
- I have no clue if this is right or not.
- 8:28 PM Changeset in webkit [65352] by
-
- 2 edits in trunk/WebCore
2010-08-13 Eric Seidel <eric@webkit.org>
Unreviewed. Attempted build fix for Windows.
Add support for MathML entities
https://bugs.webkit.org/show_bug.cgi?id=43949
- DerivedSources.cpp:
- Add HTMLEntityTable.cpp
- 8:18 PM Changeset in webkit [65351] by
-
- 16 edits4 adds1 delete in trunk
2010-08-12 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add support for MathML entities
https://bugs.webkit.org/show_bug.cgi?id=43949
Test progression for proper entity support.
- html5lib/runner-expected-html5.txt:
- html5lib/runner-expected.txt:
2010-08-09 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add support for MathML entities
https://bugs.webkit.org/show_bug.cgi?id=43949
Implementing the HTML5 entity parsing algorithm require refactoring how
we search for entity names. Instead of using a perfect hash, we now
use a sorted list. As we advance through the input, we walk down a
binary search of the table looking for an entity.
Using this data structure lets us keep track of whether the current
string is a prefix of an existing entity, which we need for the
algorithm. In a future patch, I plan to add some indices to the
table, which should let us narrow down the range of interesting entries
more quickly.
The one nasty piece of the algorithm is if we walk too far down the
input and we need to back up to a previous match. In this patch, we
accomplish this by rewinding the input and consuming a known number of
characters to resync the source.
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLEntityParser.cpp: (WebCore::consumeHTMLEntity):
- html/HTMLEntitySearch.cpp: Added. (WebCore::): (WebCore::HTMLEntitySearch::HTMLEntitySearch): (WebCore::HTMLEntitySearch::compare): (WebCore::HTMLEntitySearch::findStart): (WebCore::HTMLEntitySearch::findEnd): (WebCore::HTMLEntitySearch::advance):
- html/HTMLEntitySearch.h: Added. (WebCore::HTMLEntitySearch::isEntityPrefix): (WebCore::HTMLEntitySearch::currentValue): (WebCore::HTMLEntitySearch::lastMatch): (WebCore::HTMLEntitySearch::): (WebCore::HTMLEntitySearch::fail):
- html/HTMLEntityTable.h: Added. (WebCore::HTMLEntityTableEntry::lastCharacter):
2010-08-12 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add support for MathML entities
https://bugs.webkit.org/show_bug.cgi?id=43949
A script for generating the C++ state data structure describing all the
entities from a JSON description.
- Scripts/create-html-entity-table: Added.
- 8:09 PM Changeset in webkit [65350] by
-
- 3 edits in trunk/WebCore
2010-08-13 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Eric Seidel.
Refactor HTMLScriptRunner to allow deferred scripts to share code
https://bugs.webkit.org/show_bug.cgi?id=43736
No new tests because no functional change
- html/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::sourceFromPendingScript): Make const to enforce the idea that it doesn't change m_parsingBlockingScript. (WebCore::HTMLScriptRunner::executeParsingBlockingScript): Rename to make it clear this deals with the parsing blocking script and refactor to use executePendingScriptAndDispatchEvent. (WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent): Factored out of executePendingScript, this can be used for executing any external script. (WebCore::HTMLScriptRunner::executeScript): This can be used for executing any inline or external script. ASSERTs moved to the two calling points. (WebCore::HTMLScriptRunner::executeParsingBlockingScripts): Moved method. (WebCore::HTMLScriptRunner::requestParsingBlockingScript): Factored out requestPendingScript. (WebCore::HTMLScriptRunner::requestPendingScript): Factored out from reqeustParsingBlockingScript. (WebCore::HTMLScriptRunner::runScript):
- html/HTMLScriptRunner.h:
- 7:23 PM Changeset in webkit [65349] by
-
- 3 edits in trunk/WebCore
Windows build fix.
- WebCore.xcodeproj/project.pbxproj:
- platform/win/SharedBufferWin.cpp:
- 7:16 PM Changeset in webkit [65348] by
-
- 3 edits in trunk/LayoutTests
2010-08-13 Mihai Parparita <mihaip@chromium.org>
Reviewed by Dimitri Glazkov.
Form state restore tests fail on GTK build with r65340
https://bugs.webkit.org/show_bug.cgi?id=43998
Move form submits (and rest of test) to run during onload, to make sure
that the submit generates a history entry.
- fast/forms/state-restore-to-non-autocomplete-form.html:
- fast/forms/state-restore-to-non-edited-controls.html:
- 6:53 PM Changeset in webkit [65347] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 6:37 PM Changeset in webkit [65346] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 6:34 PM Changeset in webkit [65345] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 6:28 PM Changeset in webkit [65344] by
-
- 30 edits in trunk
Switch String::/UString::ascii() to return a CString.
Rubber stamped by Sam Weinig.
- JavaScriptCore.exp:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
- bytecode/SamplingTool.cpp:
(JSC::SamplingTool::dump):
- interpreter/CallFrame.cpp:
(JSC::CallFrame::dumpCaller):
- jsc.cpp:
(runWithScripts):
(runInteractive):
- runtime/Identifier.h:
(JSC::Identifier::ascii):
- runtime/ScopeChain.cpp:
(JSC::ScopeChainNode::print):
- runtime/UString.cpp:
(JSC::UString::ascii):
(JSC::UString::latin1):
- runtime/UString.h:
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::asciiOLD):
- wtf/text/StringImpl.h:
- wtf/text/WTFString.cpp:
(WTF::String::ascii):
(WTF::String::latin1):
- wtf/text/WTFString.h:
WebCore:
- WebCore.xcodeproj/project.pbxproj:
- bridge/c/c_class.cpp:
(JSC::Bindings::CClass::methodsNamed):
(JSC::Bindings::CClass::fieldNamed):
- bridge/jni/jsc/JNIBridgeJSC.cpp:
(JavaField::valueFromInstance):
(JavaField::setValueToInstance):
- bridge/jni/jsc/JavaInstanceJSC.cpp:
(JavaInstance::invokeMethod):
- bridge/objc/objc_class.mm:
(JSC::Bindings::ObjcClass::methodsNamed):
(JSC::Bindings::ObjcClass::fieldNamed):
- bridge/objc/objc_instance.mm:
(ObjcInstance::setValueOfUndefinedField):
(ObjcInstance::getValueOfUndefinedField):
- loader/icon/IconRecord.cpp:
- platform/sql/SQLiteDatabase.cpp:
- platform/sql/SQLiteStatement.cpp:
- storage/SQLStatement.cpp:
WebKit:
- WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
- Plugins/Hosted/ProxyInstance.mm:
(WebKit::ProxyInstance::methodsNamed):
(WebKit::ProxyInstance::fieldNamed):
- 5:34 PM Changeset in webkit [65343] by
-
- 4 edits in trunk/WebKitTools
2010-08-13 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Rewrite new-run-webkit-test's wait_for_threads_to_finish loop to
check for exceptions on all threads, not just the first thread.
This change also changes the logging behavior for wedged threads
to only dump the stacks of threads that are actually wedged.
Refactor the thread classes in the dump_render_tree_thread module
to make the contract between TestRunner and TestShellThread clearer.
Added a bunch of unit tests.
https://bugs.webkit.org/show_bug.cgi?id=38561
- Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 4:59 PM Changeset in webkit [65342] by
-
- 2 edits in trunk/WebKit2
Fix build.
- WebKit2.xcodeproj/project.pbxproj: Make WKDictionary.h public.
- 4:44 PM Changeset in webkit [65341] by
-
- 9 edits in trunk/WebKit2
Pass values map to willSubmitForm in WebKit2 API
Part of <rdar://problem/8255932>
https://bugs.webkit.org/show_bug.cgi?id=43995
Reviewed by Brady Eidson.
- Platform/CoreIPC/ArgumentCoders.h:
(CoreIPC::):
Add overload for std::pair.
- Shared/ImmutableDictionary.h:
(WebKit::ImmutableDictionary::adopt):
Fix function signature by removing size parameter.
- UIProcess/API/C/WKPage.h:
Add dictionary parameter to callback.
- UIProcess/WebFormClient.cpp:
(WebKit::WebFormClient::willSubmitForm):
Create an ImmutableDictionary from the vector of string pairs.
- UIProcess/WebFormClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::willSubmitForm):
- UIProcess/WebPageProxy.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):
Plumb through the values vector.
- 4:35 PM Changeset in webkit [65340] by
-
- 65 edits1 copy9 adds4 deletes in trunk
2010-08-13 Mihai Parparita <mihaip@chromium.org>
Reviewed by Dimitri Glazkov.
Session history should skip over JS redirects
https://bugs.webkit.org/show_bug.cgi?id=42861
Lock the back/forward list for location changes and form submits that
happen before the onload event fires that are not the result of user
gestures.
http/tests/history tests now pass, their expectations were updated
accordingly. Other tests needed a setTimeout wrapper around location
changes and form submits during onload, otherwise they would not
generate history entries as expected anymore.
- fast/css/target-fragment-match.html:
- fast/dom/location-hash.html:
- fast/dom/Geolocation/resources/cached-page-1.html:
- fast/dom/Window/timer-resume-on-navigation-back.html:
- fast/events/pageshow-pagehide-on-back-cached-with-frames-expected.txt:
- fast/events/pageshow-pagehide-on-back-cached-with-frames.html:
- fast/forms/button-state-restore.html:
- fast/forms/state-restore-to-non-autocomplete-form.html:
- fast/forms/state-restore-to-non-edited-controls.html:
- fast/frames/resources/cached-page-1.html:
- fast/frames/resources/cached-page-2.html:
- fast/harness/resources/cached-page-1.html:
- fast/harness/resources/cached-page-with-data-urls.html:
- fast/history/gesture-before-onload-expected.txt: Added.
- fast/history/gesture-before-onload.html: Added.
- fast/history/history-length.html:
- fast/history/resources/gesture-before-onload-target.html: Added.
- fast/history/saves-state-after-fragment-nav.html:
- fast/loader/input-element-page-cache-crash.html:
- fast/loader/stateobjects/document-destroyed-navigate-back.html:
- fast/loader/stateobjects/pushstate-clears-forward-history.html:
- fast/loader/subframe-navigate-during-main-frame-load.html:
- http/tests/history/back-to-post.php:
- http/tests/history/redirect-js-document-location-before-load-expected.txt:
- http/tests/history/redirect-js-form-submit-before-load-expected.txt:
- http/tests/history/redirect-js-location-assign-before-load-expected.txt:
- http/tests/history/redirect-js-location-before-load-expected.txt:
- http/tests/history/redirect-js-location-href-before-load-expected.txt:
- http/tests/loading/307-after-303-after-post-expected.txt:
- http/tests/loading/redirect-methods-expected.txt:
- http/tests/navigation/resources/back-send-referrer-helper.php:
- http/tests/navigation/resources/document-location.js: (start):
- http/tests/navigation/resources/submit-to-fragment.pl:
- security/autocomplete-cleared-on-back.html:
- storage/hash-change-with-xhr.js: (updateDatabase): (invokeBack): (runTest): (runTestsInner):
2010-08-13 Mihai Parparita <mihaip@chromium.org>
Reviewed by Dimitri Glazkov.
Session history should skip over JS redirects
https://bugs.webkit.org/show_bug.cgi?id=42861
Lock the back/forward list for location changes and form submits that
happen before the onload event fires that are not the result of user
gestures.
Made form submission (at the ScheduledFormSubmission level) more similar
to ScheduledURLNavigation by having it call clientRedirected too, fixing
a long-standing FIXME.
Test: fast/history/gesture-before-onload-location-href.html,
fast/history/gesture-before-onload-form-submit.html and updated
expectations for http/tests/history tests that used to fail.
- loader/FormSubmission.cpp: (WebCore::FormSubmission::requestURL): (WebCore::FormSubmission::populateFrameLoadRequest):
- loader/FormSubmission.h:
- loader/RedirectScheduler.cpp: (WebCore::ScheduledFormSubmission::ScheduledFormSubmission): (WebCore::ScheduledFormSubmission::fire): (WebCore::ScheduledFormSubmission::didStartTimer): (WebCore::ScheduledFormSubmission::didStopTimer): (WebCore::RedirectScheduler::scheduleRedirect): (WebCore::RedirectScheduler::mustLockBackForwardList): (WebCore::RedirectScheduler::scheduleLocationChange): (WebCore::RedirectScheduler::scheduleFormSubmission):
- loader/RedirectScheduler.h:
- 2:33 PM Changeset in webkit [65339] by
-
- 8 edits4 adds in trunk/WebKit2
Add dictionary API type
https://bugs.webkit.org/show_bug.cgi?id=43990
Reviewed by Brady Eidson.
Add an immutable dictionary type (WKStringRef -> WKTypeRef).
- Shared/APIObject.h:
(WebKit::APIObject::):
Add new APIType.
- Shared/ImmutableDictionary.cpp: Added.
(WebKit::ImmutableDictionary::ImmutableDictionary):
(WebKit::ImmutableDictionary::~ImmutableDictionary):
- Shared/ImmutableDictionary.h: Added.
(WebKit::ImmutableDictionary::create):
(WebKit::ImmutableDictionary::adopt):
(WebKit::ImmutableDictionary::get):
(WebKit::ImmutableDictionary::size):
(WebKit::ImmutableDictionary::):
(WebKit::ImmutableDictionary::type):
Add basic implementation
- UIProcess/API/C/WKAPICast.h:
(WebKit::):
Add new mappings.
- UIProcess/API/C/WKBase.h:
Add new opaque type.
- UIProcess/API/C/WKDictionary.cpp: Added.
(WKDictionaryGetTypeID):
(WKDictionaryGetItemForKey):
(WKDictionaryGetSize):
(WKDictionaryRetain):
(WKDictionaryRelease):
- UIProcess/API/C/WKDictionary.h: Added.
Add API wrappings.
- UIProcess/API/C/WebKit2.h:
Add missing public headers.
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
- win/WebKit2Generated.make:
Add new files.
- 2:03 PM Changeset in webkit [65338] by
-
- 2 edits in trunk/LayoutTests
Add two more unsupported tests to the WebKit2 skipped list.
Rubber-stamped by Beth Dakin and Ban Bernstein.
- platform/mac-wk2/Skipped:
- 1:11 PM Changeset in webkit [65337] by
-
- 18 edits2 copies6 adds in trunk/WebKit2
Add form submission listener to WebKit2
Part of <rdar://problem/8255932>
https://bugs.webkit.org/show_bug.cgi?id=43947
Reviewed by Jon Honeycutt.
- Shared/APIObject.h:
Add TypeFormSubmissionListener APIType.
- Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:
Add WillSubmitForm message kind.
- UIProcess/API/C/WKAPICast.h:
Add new mappings for WKFormSubmissionListenerRef -> WebFormSubmissionListener
- UIProcess/API/C/WKBase.h:
Add OpaqueWKFormSubmissionListener and rename the other opaque types to match.
- UIProcess/API/C/WKFormSubmissionListener.cpp: Added.
(WKFormSubmissionListenerGetTypeID):
(WKFormSubmissionListenerContinue):
(WKFormSubmissionListenerRetain):
(WKFormSubmissionListenerRelease):
- UIProcess/API/C/WKFormSubmissionListener.h: Added.
Add C wrapper for WebFormSubmissionListener.
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageFormClient):
- UIProcess/API/C/WKPage.h:
Add WKPageFormClient with willSubmitForm callback. Additional callbacks will be added as
needed.
- UIProcess/API/C/WebKit2.h:
Add include for WKFormSubmissionListener.h
- UIProcess/WebFormClient.cpp: Added.
(WebKit::WebFormClient::WebFormClient):
(WebKit::WebFormClient::initialize):
(WebKit::WebFormClient::willSubmitForm):
- UIProcess/WebFormClient.h: Added.
Add client for form related delagations.
- UIProcess/WebFormSubmissionListenerProxy.cpp: Added.
(WebKit::WebFormSubmissionListenerProxy::WebFormSubmissionListenerProxy):
(WebKit::WebFormSubmissionListenerProxy::continueSubmission):
- UIProcess/WebFormSubmissionListenerProxy.h: Added.
(WebKit::WebFormSubmissionListenerProxy::create):
(WebKit::WebFormSubmissionListenerProxy::type):
- UIProcess/WebFrameListenerProxy.cpp: Copied from UIProcess/WebFramePolicyListenerProxy.cpp.
Add new type of listener for form submissions. It inherits from the new base class
for listeners, WebFrameListenerProxy.
(WebKit::WebFrameListenerProxy::WebFrameListenerProxy):
(WebKit::WebFrameListenerProxy::~WebFrameListenerProxy):
(WebKit::WebFrameListenerProxy::invalidate):
(WebKit::WebFrameListenerProxy::receivedPolicyDecision):
- UIProcess/WebFrameListenerProxy.h: Copied from UIProcess/WebFramePolicyListenerProxy.h.
Move logic that would have to be shared between WebFramePolicyListenerProxy and
WebFormSubmissionListenerProxy into shared base class.
- UIProcess/WebFramePolicyListenerProxy.cpp:
(WebKit::WebFramePolicyListenerProxy::WebFramePolicyListenerProxy):
- UIProcess/WebFramePolicyListenerProxy.h:
(WebKit::WebFramePolicyListenerProxy::create):
(WebKit::WebFramePolicyListenerProxy::type):
Move to inheriting from WebFrameListenerProxy.
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::disconnect):
(WebKit::WebFrameProxy::receivedPolicyDecision):
(WebKit::WebFrameProxy::setUpPolicyListenerProxy):
(WebKit::WebFrameProxy::setUpFormSubmissionListenerProxy):
- UIProcess/WebFrameProxy.h:
Change listener functions to act on WebFrameListenerProxys and add setUpFormSubmissionListenerProxy.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::initializeFormClient):
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::willSubmitForm):
- UIProcess/WebPageProxy.h:
Plumb through willSubmitForm call as we do with the other listeners.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):
Ditto.
- WebKit2.xcodeproj/project.pbxproj: Add new files.
- win/WebKit2.vcproj: Add new files.
- win/WebKit2Generated.make: Ditto.
- 12:09 PM Changeset in webkit [65336] by
-
- 2 edits in trunk/WebCore
2010-08-13 Leandro Pereira <leandro@profusion.mobi>
[EFL] Unreviewed build fix.
These changes were supposed to be landed on r65319, but due to some
svn-apply/commit-queue bug it wasn't fully applied. A bug was filed
by Patrick Gansterer (author of the changes in this commit):
https://bugs.webkit.org/show_bug.cgi?id=43981
- CMakeLists.txt: Update calls to GENERATE_GPERF and GENERATE_GRAMMAR macros.
- 11:49 AM Changeset in webkit [65335] by
-
- 6 edits2 adds in trunk
AX: isNativeCheckbox does not work as advertised
https://bugs.webkit.org/show_bug.cgi?id=43872
Re-adding this patch after it was erroneously rolled out.
WebCore:
Test: platform/mac/accessibility/native-vs-nonnative-checkboxes.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isInputImage):
(WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio):
- dom/InputElement.h:
- html/HTMLInputElement.h:
(WebCore::HTMLInputElement::isCheckbox):
LayoutTests:
- platform/mac/accessibility/native-vs-nonnative-checkboxes-expected.txt: Added.
- platform/mac/accessibility/native-vs-nonnative-checkboxes.html: Added.
- 11:05 AM Changeset in webkit [65334] by
-
- 2 edits in trunk/WebCore
2010-08-13 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r65331.
http://trac.webkit.org/changeset/65331
https://bugs.webkit.org/show_bug.cgi?id=43980
This patch breaks some shadow tests on Qt Linux release
(Requested by ariya on #webkit).
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::drawFilledShadowPath): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::drawBorderlessRectShadow): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::setPlatformShadow): (WebCore::GraphicsContext::clearPlatformShadow):
- 10:39 AM Changeset in webkit [65333] by
-
- 6 edits in trunk/WebCore
2010-08-13 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by David Levin.
Update run-bindings-tests expectations
https://bugs.webkit.org/show_bug.cgi?id=43944
The results have become out of sync after changeset 64552 and 65269.
Test: WebKitTools/Scripts/run-bindings-tests
- bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp: (webkit_dom_test_callback_callback_with_class1param): (webkit_dom_test_callback_callback_with_class2param): (webkit_dom_test_callback_callback_with_non_bool_return_type):
- bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_void_method_with_args): (webkit_dom_test_obj_int_method_with_args): (webkit_dom_test_obj_obj_method): (webkit_dom_test_obj_obj_method_with_args): (webkit_dom_test_obj_method_that_requires_all_args): (webkit_dom_test_obj_method_that_requires_all_args_and_throws): (webkit_dom_test_obj_serialized_value): (webkit_dom_test_obj_idb_key): (webkit_dom_test_obj_with_dynamic_frame_and_user_gesture): (webkit_dom_test_obj_with_dynamic_frame_and_user_gesture_asad): (webkit_dom_test_obj_with_script_state_obj): (webkit_dom_test_obj_with_script_state_obj_exception): (webkit_dom_test_obj_get_read_only_string_attr): (webkit_dom_test_obj_get_read_only_test_obj_attr): (webkit_dom_test_obj_get_string_attr): (webkit_dom_test_obj_set_string_attr): (webkit_dom_test_obj_get_test_obj_attr): (webkit_dom_test_obj_set_test_obj_attr): (webkit_dom_test_obj_get_xml_obj_attr): (webkit_dom_test_obj_set_xml_obj_attr): (webkit_dom_test_obj_get_reflected_string_attr): (webkit_dom_test_obj_set_reflected_string_attr): (webkit_dom_test_obj_get_reflected_url_attr): (webkit_dom_test_obj_set_reflected_url_attr): (webkit_dom_test_obj_get_reflected_non_empty_url_attr): (webkit_dom_test_obj_set_reflected_non_empty_url_attr): (webkit_dom_test_obj_get_reflected_custom_url_attr): (webkit_dom_test_obj_set_reflected_custom_url_attr): (webkit_dom_test_obj_get_reflected_custom_non_empty_url_attr): (webkit_dom_test_obj_set_reflected_custom_non_empty_url_attr): (webkit_dom_test_obj_get_string_attr_with_getter_exception): (webkit_dom_test_obj_set_string_attr_with_getter_exception): (webkit_dom_test_obj_get_string_attr_with_setter_exception): (webkit_dom_test_obj_set_string_attr_with_setter_exception): (webkit_dom_test_obj_get_script_string_attr): (webkit_dom_test_obj_get_hash): (webkit_dom_test_obj_class_init):
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::jsTestObjPrototypeFunctionOverloadedMethod):
- 10:35 AM Changeset in webkit [65332] by
-
- 3 edits in trunk
2010-08-13 Leandro Pereira <leandro@profusion.mobi>
[EFL] Unreviewed build fix.
- cmake/FindGthread.cmake: Fix warnings about obsolete PKGCONFIG macro.
- cmake/WebKitGenerators.cmake: FLEX_EXECUTABLE was defined already by the root CMakeLists.txt file, so remove relevant lines that depends on FIND_PACKAGE_HANDLE_STANDARD_ARGS macro, which isn't available anymore.
- 10:24 AM Changeset in webkit [65331] by
-
- 2 edits in trunk/WebCore
2010-08-13 Ariya Hidayat <ariya@sencha.com>
Reviewed by Simon Hausmann.
[Qt] Canvas and CSS: blur option in shadow not working
https://bugs.webkit.org/show_bug.cgi?id=34479
Patch 1: Refactor shadow states handling.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::): Added shadow states as member variables. (WebCore::GraphicsContextPlatformPrivate::hasShadow): Convenient function to check whether there is shadow or not. (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::drawRect): Use shadow states instead of calling getShadow. (WebCore::GraphicsContext::drawLine): ditto. (WebCore::GraphicsContext::strokeArc): ditto. (WebCore::GraphicsContext::drawConvexPolygon): ditto. (WebCore::GraphicsContext::fillPath): ditto. (WebCore::GraphicsContext::strokePath): ditto. (WebCore::GraphicsContext::fillRect): Removes the use of helper function drawBorderlessRectShadow as the code already becomes a lot simpler. (WebCore::GraphicsContext::fillRoundedRect): Removes the use of helper function drawFilledShadowPath as the code already becomes a lot simpler. (WebCore::GraphicsContext::setPlatformShadow): Store shadow states and find out the shadow type (complexity) for future use. (WebCore::GraphicsContext::clearPlatformShadow): Reset shadow states.
- 10:12 AM Changeset in webkit [65330] by
-
- 9 edits in trunk
2010-08-11 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
Regression in linking of programs
https://bugs.webkit.org/show_bug.cgi?id=43820
Shaders and programs shouldn't be deleted until their attachments are removed, therefore, we need to track the attach/detach/useProgram.
- html/canvas/WebGLObject.cpp: Track the object attachment count and whether it should really be deleted. (WebCore::WebGLObject::WebGLObject): (WebCore::WebGLObject::setObject): (WebCore::WebGLObject::deleteObject):
- html/canvas/WebGLObject.h: Track the object attachment count and whether it should really be deleted. (WebCore::WebGLObject::onAttached): (WebCore::WebGLObject::onDetached): (WebCore::WebGLObject::getAttachmentCount):
- html/canvas/WebGLProgram.cpp: Track the attached shaders. (WebCore::WebGLProgram::WebGLProgram): (WebCore::WebGLProgram::deleteObjectImpl): (WebCore::WebGLProgram::getAttachedShader): (WebCore::WebGLProgram::attachShader): (WebCore::WebGLProgram::detachShader):
- html/canvas/WebGLProgram.h: Track the attached shaders.
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::attachShader): Track the attachment of a shader to a program. (WebCore::WebGLRenderingContext::deleteProgram): Detach shaders. (WebCore::WebGLRenderingContext::detachShader): Track the attachment of a shader to a program. (WebCore::WebGLRenderingContext::validateWebGLObject): Also check if object == 0. (WebCore::WebGLRenderingContext::linkProgram): Using the cached attached shaders instead of query from driver. (WebCore::WebGLRenderingContext::useProgram): Track the attachment of a program to the current rendering pipeline.
2010-08-11 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
Regression in linking of programs
https://bugs.webkit.org/show_bug.cgi?id=43820
- fast/canvas/webgl/program-test-expected.txt: Fix the tests so a second shader of the same type attaching to a program will generate error; also, add tests for deleteShader/deleteProgram behavior.
- fast/canvas/webgl/program-test.html: Ditto.
- 10:02 AM Changeset in webkit [65329] by
-
- 4 edits5 adds in trunk
2010-08-13 Steve Block <steveblock@google.com>
Reviewed by Alexey Proskuryakov.
Geolocation activity started after frame has been disconnected can cause crash
https://bugs.webkit.org/show_bug.cgi?id=39879
New requests started after the Frame has been disconnected are ignored. We do
not invoke the error callback as this would allow buggy or malicious pages to
hose the CPU. Such a page could hold a reference to a Geolocation object from
a since closed Page and register new requests from the error callback to
create an infinite loop.
Tests: fast/dom/Geolocation/disconnected-frame-already.html
- page/Geolocation.cpp:
2010-08-13 Steve Block <steveblock@google.com>
Reviewed by Alexey Proskuryakov.
Geolocation activity started after frame has been disconnected can cause crash
https://bugs.webkit.org/show_bug.cgi?id=39879
Added new tests to GTK skipped list.
- fast/dom/Geolocation/disconnected-frame-already.html: Added.
- fast/dom/Geolocation/disconnected-frame-already-expected.txt: Added.
- fast/dom/Geolocation/script-tests/disconnected-frame-already.js: Added.
- fast/dom/Geolocation/resources/disconnected-frame-already-inner1.html: Added.
- fast/dom/Geolocation/resources/disconnected-frame-already-inner2.html: Added.
- platform/gtk/Skipped:
- 9:51 AM Changeset in webkit [65328] by
-
- 2 edits in trunk
2010-08-13 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
We have to add the ACLOCAL_FLAGS in the env to the autogen.sh
ACLOCAL_FLAGS variable in order to honor the value already
defined, jhbuild uses it to pass parameters.
- autogen.sh:
- 9:49 AM Changeset in webkit [65327] by
-
- 16 edits in trunk
2010-08-13 Satish Sampath <satish@chromium.org>
Reviewed by Jeremy Orlow.
Support for multiple speech enabled elements in same page.
https://bugs.webkit.org/show_bug.cgi?id=43922
- page/SpeechInput.cpp: Generates request ids as necessary when each speech enabled input element gets created/destroyed and multiplexes the listener callbacks to the appropriate input element based on the request id. (WebCore::SpeechInput::SpeechInput): (WebCore::SpeechInput::~SpeechInput): (WebCore::SpeechInput::registerListener): (WebCore::SpeechInput::unregisterListener): (WebCore::SpeechInput::didCompleteRecording): (WebCore::SpeechInput::didCompleteRecognition): (WebCore::SpeechInput::setRecognitionResult): (WebCore::SpeechInput::startRecognition): (WebCore::SpeechInput::stopRecording): (WebCore::SpeechInput::cancelRecognition):
- page/SpeechInput.h:
- page/SpeechInputClient.h: Now requires a one time set for the WebCore::SpeechInputListener and takes in a 'requestId' for all calls.
- page/SpeechInputListener.h: Now returns the above mentioned requestId in all the listener callbacks for identifying which input element the event goes to.
- platform/mock/SpeechInputClientMock.cpp: (WebCore::SpeechInputClientMock::SpeechInputClientMock): (WebCore::SpeechInputClientMock::setListener): (WebCore::SpeechInputClientMock::startRecognition): (WebCore::SpeechInputClientMock::stopRecording): (WebCore::SpeechInputClientMock::cancelRecognition): (WebCore::SpeechInputClientMock::timerFired):
- platform/mock/SpeechInputClientMock.h:
- rendering/TextControlInnerElements.cpp: (WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement): (WebCore::InputFieldSpeechButtonElement::~InputFieldSpeechButtonElement): (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::speechInput): (WebCore::InputFieldSpeechButtonElement::didCompleteRecording): (WebCore::InputFieldSpeechButtonElement::didCompleteRecognition): (WebCore::InputFieldSpeechButtonElement::setRecognitionResult):
- rendering/TextControlInnerElements.h:
2010-08-13 Satish Sampath <satish@chromium.org>
Reviewed by Jeremy Orlow.
Support for multiple speech enabled elements in same page.
https://bugs.webkit.org/show_bug.cgi?id=43922
- public/WebSpeechInputController.h: Bubbles up the requestId given by webcore to the embedder. (WebKit::WebSpeechInputController::startRecognition): (WebKit::WebSpeechInputController::cancelRecognition): (WebKit::WebSpeechInputController::stopRecording):
- public/WebSpeechInputListener.h: Passes down the requestId given by embedder to webcore. (WebKit::WebSpeechInputListener::didCompleteRecording): (WebKit::WebSpeechInputListener::setRecognitionResult): (WebKit::WebSpeechInputListener::didCompleteRecognition):
- src/SpeechInputClientImpl.cpp: (WebKit::SpeechInputClientImpl::setListener): (WebKit::SpeechInputClientImpl::startRecognition): (WebKit::SpeechInputClientImpl::stopRecording): (WebKit::SpeechInputClientImpl::cancelRecognition): (WebKit::SpeechInputClientImpl::didCompleteRecording): (WebKit::SpeechInputClientImpl::didCompleteRecognition): (WebKit::SpeechInputClientImpl::setRecognitionResult):
- src/SpeechInputClientImpl.h:
- src/WebSpeechInputControllerMockImpl.cpp: (WebKit::WebSpeechInputControllerMockImpl::WebSpeechInputControllerMockImpl): (WebKit::WebSpeechInputControllerMockImpl::~WebSpeechInputControllerMockImpl): (WebKit::WebSpeechInputControllerMockImpl::didCompleteRecording): (WebKit::WebSpeechInputControllerMockImpl::didCompleteRecognition): (WebKit::WebSpeechInputControllerMockImpl::setRecognitionResult): (WebKit::WebSpeechInputControllerMockImpl::startRecognition): (WebKit::WebSpeechInputControllerMockImpl::cancelRecognition): (WebKit::WebSpeechInputControllerMockImpl::stopRecording):
- src/WebSpeechInputControllerMockImpl.h:
- 9:27 AM Changeset in webkit [65326] by
-
- 3 edits in trunk/LayoutTests
2010-08-13 Ariya Hidayat <ariya@sencha.com>
Rubber-stamped by Simon Hausmann.
[Qt] Outdated pixel test reference for basic-shadows.html
https://bugs.webkit.org/show_bug.cgi?id=43952
- platform/qt/fast/box-shadow/basic-shadows-expected.checksum:
- platform/qt/fast/box-shadow/basic-shadows-expected.png:
- 9:22 AM Changeset in webkit [65325] by
-
- 2 edits5 adds in trunk/LayoutTests
2010-08-13 Steve Block <steveblock@google.com>
Reviewed by Alexey Proskuryakov.
Need a LayoutTest to check that pages using Geolocation are not put in the page cache
https://bugs.webkit.org/show_bug.cgi?id=43957
- fast/dom/Geolocation/no-page-cache-expected.txt: Added.
- fast/dom/Geolocation/no-page-cache.html: Added.
- fast/dom/Geolocation/resources/cached-page-1.html: Added.
- fast/dom/Geolocation/resources/cached-page-2.html: Added.
- fast/dom/Geolocation/script-tests/no-page-cache.js: Added. (reportPageOneOnload):
- platform/gtk/Skipped: Added new test to GTK skipped list
- 8:52 AM Changeset in webkit [65324] by
-
- 2 edits in trunk/WebCore
2010-08-13 Eric Carlson <eric.carlson@apple.com>
Reviewed by David Kilzer.
HTMLMediaElement::prepareForLoad should cancel current plug-in proxy media player
https://bugs.webkit.org/show_bug.cgi?id=43923
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::prepareForLoad): Tell mediaPlayer to cancel the current load if it already exists.
- 6:58 AM Changeset in webkit [65323] by
-
- 4 edits in trunk/WebCore
2010-08-12 Stephen White <senorblanco@chromium.org>
Reviewed by David Levin.
[CHROMIUM] Use the BGRA format for canvas 2D accel upload and readbacks.
https://bugs.webkit.org/show_bug.cgi?id=43804
Use the BGRA format from GraphicsContext3D, if supported. Also keep a
texture around for uploads, rather than re-creating it each time.
Covered by many layout tests (once we're running them).
- platform/graphics/chromium/GLES2Texture.cpp: (WebCore::convertFormat): Move convertFormat() ahead of texture creation, so we can check for BGRA support. (WebCore::GLES2Texture::create): Use convertFormat() to determine the correct format and types to use; use the returned format also for internalFormat, since GLES2 insists they match.
- platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::setGraphicsContext3D): Clear the upload texture when a new context is set. (WebCore::PlatformContextSkia::uploadSoftwareToHardware): Use m_uploadTexture instead of creating a new one each time. (WebCore::PlatformContextSkia::readbackHardwareToSoftware): When the context supports it, use the BGRA format for readbacks instead of swizzling.
- platform/graphics/skia/PlatformContextSkia.h: Add m_uploadTexture for consecutive uploads.
- 6:52 AM MathML Status edited by
- (diff)
- 6:48 AM Changeset in webkit [65322] by
-
- 2 edits in trunk
[Qt] Introduce Maemo6 for mobile features
https://bugs.webkit.org/show_bug.cgi?id=43969
Reviewed by Ariya Hidayat.
- WebKit.pri: Use maemo6 where we also use maemo5.
- 6:48 AM Changeset in webkit [65321] by
-
- 4 edits in trunk
[Qt] Clean up mobile feature useage
https://bugs.webkit.org/show_bug.cgi?id=43968
Reviewed by Ariya Hidayat.
.:
- WebKit.pri: Set feature defaults here for some Nokia specific mobile platforms
WebCore:
- WebCore.pro: Replaced use of Nokia specific platform scopes with concrete
feature names.
- 6:22 AM MathML Status edited by
- (diff)
- 6:22 AM Changeset in webkit [65320] by
-
- 20 edits in trunk/WebCore
2010-08-13 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: rename InspectorValue::push and set to
push{Value|Object|Array} and set{...}.
https://bugs.webkit.org/show_bug.cgi?id=43966
- bindings/js/ScriptProfile.cpp: (WebCore::buildInspectorObjectFor):
- bindings/js/ScriptValue.cpp: (WebCore::jsToInspectorValue):
- bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::stackTrace):
- bindings/v8/ScriptProfile.cpp: (WebCore::buildInspectorObjectFor):
- bindings/v8/ScriptValue.cpp: (WebCore::v8ToInspectorValue):
- inspector/CodeGeneratorInspector.pm:
- inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToFrontend):
- inspector/Inspector.idl:
- inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCache): (WebCore::InspectorApplicationCacheAgent::buildArrayForApplicationCacheResources):
- inspector/InspectorController.cpp: (WebCore::InspectorController::buildArrayForCookies): (WebCore::InspectorController::getDOMStorageEntries): (WebCore::InspectorController::getProfileHeaders): (WebCore::InspectorController::getProfile):
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getEventListenersForNode): (WebCore::InspectorDOMAgent::buildObjectForNode): (WebCore::InspectorDOMAgent::buildArrayForContainerChildren): (WebCore::InspectorDOMAgent::getStyles): (WebCore::InspectorDOMAgent::getAllStyles): (WebCore::InspectorDOMAgent::getRuleRanges): (WebCore::InspectorDOMAgent::buildObjectForAttributeStyles): (WebCore::InspectorDOMAgent::buildArrayForCSSRules): (WebCore::InspectorDOMAgent::buildArrayForPseudoElements): (WebCore::InspectorDOMAgent::buildObjectForStyle): (WebCore::InspectorDOMAgent::populateObjectWithStyleProperties): (WebCore::InspectorDOMAgent::buildArrayForDisabledStyleProperties): (WebCore::InspectorDOMAgent::buildObjectForStyleSheet): (WebCore::InspectorDOMAgent::buildObjectForRule):
- inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::saveBreakpoints):
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateScriptObject):
- inspector/InspectorStorageAgent.cpp: (WebCore::): (WebCore::InspectorStorageAgent::executeSQL):
- inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::pushGCEventRecords): (WebCore::InspectorTimelineAgent::didInstallTimer): (WebCore::InspectorTimelineAgent::didRemoveTimer): (WebCore::InspectorTimelineAgent::didScheduleResourceRequest): (WebCore::InspectorTimelineAgent::willSendResourceRequest): (WebCore::InspectorTimelineAgent::didFinishLoadingResource): (WebCore::InspectorTimelineAgent::didMarkTimeline): (WebCore::InspectorTimelineAgent::addRecordToTimeline): (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
- inspector/InspectorValues.cpp: (WebCore::): (WebCore::InspectorValue::asValue): (WebCore::InspectorValue::asObject): (WebCore::InspectorValue::asArray): (WebCore::InspectorObject::asObject): (WebCore::InspectorArray::asArray):
- inspector/InspectorValues.h: (WebCore::InspectorObject::setBool): (WebCore::InspectorObject::setNumber): (WebCore::InspectorObject::setString): (WebCore::InspectorObject::setValue): (WebCore::InspectorObject::setObject): (WebCore::InspectorObject::setArray): (WebCore::InspectorArray::pushValue): (WebCore::InspectorArray::pushObject): (WebCore::InspectorArray::pushArray):
- inspector/ScriptBreakpoint.cpp: (WebCore::ScriptBreakpoint::inspectorObjectFromSourceBreakpoints):
- inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createGenericRecord):
- 6:18 AM MathML Status edited by
- (diff)
- 6:16 AM Changeset in webkit [65319] by
-
- 3 edits in trunk
2010-08-13 Patrick Gansterer <paroga@paroga.com>
Reviewed by Nikolas Zimmermann.
[CMake] Cleanup generator code.
https://bugs.webkit.org/show_bug.cgi?id=39164
- cmake/WebKitGenerators.cmake:
- cmake/WebKitMacros.cmake:
- 6:03 AM QtWebKitContrib edited by
- (diff)
- 6:02 AM Changeset in webkit [65318] by
-
- 2 edits1 add in trunk/LayoutTests
2010-08-13 Nate Chapin <Nate Chapin>
Unreviewed, Chromium test_expectations.txt updates + a rebaseline
- platform/chromium-linux/svg/custom/absolute-sized-content-with-resources-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 5:54 AM Changeset in webkit [65317] by
-
- 5 edits2 deletes in trunk
2010-08-13 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r65204.
http://trac.webkit.org/changeset/65204
https://bugs.webkit.org/show_bug.cgi?id=43965
Caused a lot of test crashes in Chromium (Requested by yutak
on #webkit).
- platform/mac/accessibility/native-vs-nonnative-checkboxes-expected.txt: Removed.
- platform/mac/accessibility/native-vs-nonnative-checkboxes.html: Removed.
2010-08-13 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r65204.
http://trac.webkit.org/changeset/65204
https://bugs.webkit.org/show_bug.cgi?id=43965
Caused a lot of test crashes in Chromium (Requested by yutak
on #webkit).
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isInputImage): (WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio):
- dom/InputElement.h:
- html/HTMLInputElement.h:
- 5:29 AM Changeset in webkit [65316] by
-
- 8 edits in trunk/WebCore
2010-08-13 Anton Muhin <antonm@chromium.org>
Reviewed by Nate Chapin.
Reapplying http://trac.webkit.org/changeset/65284 after fixed include.
[v8] Create callbacks for named access of elements from document object on fly.
https://bugs.webkit.org/show_bug.cgi?id=43725
That should speed up access to methods on document as there is no need to
consult with interceptor before invoking the method.
This reapplies http://trac.webkit.org/changeset/60670 reverted with
http://trac.webkit.org/changeset/63845. The main difference is in treatment
of removed named elements: we don't remove an accessor any more, but leave it.
Therefore any accessor should be able to treat the case when there is no
expando property.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::namedItemAdded): (WebCore::ScriptController::namedItemRemoved):
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::checkDocumentWrapper): (WebCore::V8DOMWindowShell::updateDocumentWrapperCache): (WebCore::getter): (WebCore::V8DOMWindowShell::namedItemAdded): (WebCore::V8DOMWindowShell::namedItemRemoved):
- bindings/v8/V8DOMWindowShell.h:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::V8HTMLDocument::WrapInShadowObject): (WebCore::V8HTMLDocument::GetNamedProperty): (WebCore::V8HTMLDocument::allAccessorSetter): (WebCore::toV8):
- html/HTMLDocument.cpp: (WebCore::HTMLDocument::removeItemFromMap):
- 5:11 AM Changeset in webkit [65315] by
-
- 7 edits in trunk/LayoutTests
2010-08-13 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: DRT sometimes crashes on debugger tests
https://bugs.webkit.org/show_bug.cgi?id=43964
notifyDone() should be called only when debugger already resumed all active DOM objects,
otherwise we might accidentally call setTimeout in the inspected page and create
a new active DOM object while their set should remain unchanged when script execution
is paused.
- inspector/debugger-cyclic-ref.html:
- inspector/debugger-eval-while-paused.html:
- inspector/debugger-no-nested-pause.html:
- inspector/debugger-pause-in-eval-script.html:
- inspector/debugger-pause-on-debugger-statement.html:
- inspector/debugger-proto-property.html:
- 5:08 AM Changeset in webkit [65314] by
-
- 9 edits in trunk/WebCore
2010-08-13 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: remove openInInspectorWindow and evaluateAndStringify from InjectedScript.
https://bugs.webkit.org/show_bug.cgi?id=43854
- inspector/Inspector.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::openInInspectedWindow):
- inspector/InspectorController.h:
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage.callback): (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
- inspector/front-end/InjectedScriptAccess.js:
- inspector/front-end/InspectorBackendStub.js: (WebInspector.InspectorBackendStub):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.ondblclick):
- 5:01 AM Changeset in webkit [65313] by
-
- 3 edits in trunk/WebCore
2010-08-13 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
flaky websocket/tests/frame-length-overflow.html
https://bugs.webkit.org/show_bug.cgi?id=43902
Add m_shouldDiscardReceivedData flag to indicate it will no longer
receive data from network.
- websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): (WebCore::WebSocketChannel::didReceiveData): (WebCore::WebSocketChannel::didFail): (WebCore::WebSocketChannel::processBuffer):
- when frame length overflows, we couldn't process data any more. clear buffer and mark m_shouldDiscardReceivedData true to make sure it doesn't process the same buffer again.
- websockets/WebSocketChannel.h:
- 4:50 AM WinCE edited by
- (diff)
- 4:12 AM QtWebKitWeeklyBuilds edited by
- (diff)
- 4:12 AM MathML edited by
- (diff)
- 4:09 AM MathML Status edited by
- (diff)
- 3:42 AM MathML Status edited by
- (diff)
- 3:28 AM MathML Status edited by
- (diff)
- 3:26 AM MathML Status edited by
- (diff)
- 3:21 AM MathML Status edited by
- (diff)
- 3:15 AM Changeset in webkit [65312] by
-
- 16 edits2 adds in trunk/WebCore
2010-08-13 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Use SVGPathByteStream to animate SVGPath
https://bugs.webkit.org/show_bug.cgi?id=43929
Use SVGPathByteStream to perform animations of Paths. SVGPathBlender blends
the starting point to the end point according to the current progress value.
Cleanup SVGPathSegList, by removing the unnecessary legacy blending code.
No new tests because no functional changes.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- svg/SVGAllInOne.cpp:
- svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::SVGAnimateElement): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget):
- svg/SVGAnimateElement.h:
- svg/SVGPathBlender.cpp: Added. (WebCore::SVGPathBlender::SVGPathBlender): (WebCore::SVGPathBlender::~SVGPathBlender): (WebCore::SVGPathBlender::blendAnimatedFloat): (WebCore::SVGPathBlender::blendAnimatedFloatPoint): (WebCore::SVGPathBlender::blendMoveToSegment): (WebCore::SVGPathBlender::blendLineToSegment): (WebCore::SVGPathBlender::blendLineToHorizontalSegment): (WebCore::SVGPathBlender::blendLineToVerticalSegment): (WebCore::SVGPathBlender::blendCurveToCubicSegment): (WebCore::SVGPathBlender::blendCurveToCubicSmoothSegment): (WebCore::SVGPathBlender::blendCurveToQuadraticSegment): (WebCore::SVGPathBlender::blendCurveToQuadraticSmoothSegment): (WebCore::SVGPathBlender::blendArcToSegment): (WebCore::SVGPathBlender::blendAnimatedPath): (WebCore::SVGPathBlender::cleanup):
- svg/SVGPathBlender.h: Added.
- svg/SVGPathParserFactory.cpp: (WebCore::globalSVGPathBlender): (WebCore::SVGPathParserFactory::buildAnimatedSVGPathByteStream):
- svg/SVGPathParserFactory.h:
- svg/SVGPathSegList.cpp: (WebCore::SVGPathSegList::getPathSegAtLength):
- svg/SVGPathSegList.h: (WebCore::SVGPathSegList::create):
- svg/SVGPointList.cpp: (WebCore::adjustAnimatedValue):
- 3:14 AM Changeset in webkit [65311] by
-
- 12 edits in trunk/JavaScriptCore
Avoid increasing required alignment of target type warning on ARM
https://bugs.webkit.org/show_bug.cgi?id=38045
Reviewed by Gavin Barraclough.
The reinterpret_cast<Type1*>([pointer to Type2]) expressions - where
sizeof(Type1) > sizeof(Type2) - cause the following warning on ARM:
increases required alignment of target type warnings.
Casting the type of [pointer to Type2] object to void* bypasses the
warning.
- JavaScriptCore/assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::executableCopy):
- JavaScriptCore/assembler/AssemblerBuffer.h:
(JSC::AssemblerBuffer::putShortUnchecked):
(JSC::AssemblerBuffer::putIntUnchecked):
(JSC::AssemblerBuffer::putInt64Unchecked):
- JavaScriptCore/interpreter/RegisterFile.h:
(JSC::RegisterFile::RegisterFile):
(JSC::RegisterFile::grow):
- JavaScriptCore/jit/JITStubs.cpp:
- JavaScriptCore/pcre/pcre_compile.cpp:
(jsRegExpCompile):
- JavaScriptCore/runtime/JSArray.cpp:
(JSC::JSArray::putSlowCase):
(JSC::JSArray::increaseVectorLength):
(JSC::JSArray::increaseVectorPrefixLength):
(JSC::JSArray::shiftCount):
(JSC::JSArray::unshiftCount):
- JavaScriptCore/wtf/FastMalloc.cpp:
(WTF::PageHeapAllocator::New):
(WTF::TCMalloc_Central_FreeList::Populate):
- wtf/MD5.cpp:
(WTF::reverseBytes):
(WTF::MD5::addBytes):
(WTF::MD5::checksum):
- JavaScriptCore/wtf/StdLibExtras.h:
(isPointerTypeAlignmentOkay):
(reinterpret_cast_ptr):
- JavaScriptCore/wtf/Vector.h:
(WTF::VectorBuffer::inlineBuffer):
- JavaScriptCore/wtf/qt/StringQt.cpp:
(WTF::String::String):
- 3:14 AM MathML edited by
- (diff)
- 3:03 AM Changeset in webkit [65310] by
-
- 25 edits4 adds in trunk
2010-08-12 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Window size changes + resources on absolute sized content leads to pixelation
https://bugs.webkit.org/show_bug.cgi?id=43921
Avoid pixelation when using resources on absolute sized objects. Be sure to invalidate the used resources if window size changes.
Otherwhise masks etc. will be scaled up and pixelate. As nice side-effect, this fixes run-webkit-tests --singly svg/W3C-SVG-1.1, which
used to produce wrong results for the gradient tests, as the window size change from 800x600 for 480x360 (svg/W3C-SVG-1.1 specific DRT quirk)
didn't invalidate the resources.
Renamed invalidateClient -> removeClientFromCache and invalidateClients -> removeAllClientsFromCache.
Add a boolean "markForInvalidation" parameter, that controls wheter the clients should be marked for repaint/boundaries invalidation/layout
or wheter we only want to notify the parents that the resource changed, to avoid doing unncessary work in SVGRenderSupport::layoutChildren.
Test: svg/custom/absolute-sized-content-with-resources.xhtml
- rendering/RenderSVGGradientStop.cpp: (WebCore::RenderSVGGradientStop::styleDidChange): Don't do anything for StyleDifferenceEqual.
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::imageChanged):
- rendering/RenderSVGResource.cpp: (WebCore::RenderSVGResource::markForLayoutAndParentResourceInvalidation):
- rendering/RenderSVGResource.h:
- rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::removeAllClientsFromCache): (WebCore::RenderSVGResourceClipper::removeClientFromCache):
- rendering/RenderSVGResourceClipper.h:
- rendering/RenderSVGResourceContainer.cpp: (WebCore::RenderSVGResourceContainer::layout): (WebCore::RenderSVGResourceContainer::idChanged): (WebCore::RenderSVGResourceContainer::markAllClientsForInvalidation): (WebCore::RenderSVGResourceContainer::markClientForInvalidation):
- rendering/RenderSVGResourceContainer.h: (WebCore::RenderSVGResourceContainer::):
- rendering/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::removeAllClientsFromCache): (WebCore::RenderSVGResourceFilter::removeClientFromCache): (WebCore::RenderSVGResourceFilter::postApplyResource):
- rendering/RenderSVGResourceFilter.h:
- rendering/RenderSVGResourceGradient.cpp: (WebCore::RenderSVGResourceGradient::removeAllClientsFromCache): (WebCore::RenderSVGResourceGradient::removeClientFromCache): (WebCore::RenderSVGResourceGradient::applyResource):
- rendering/RenderSVGResourceGradient.h:
- rendering/RenderSVGResourceMarker.cpp: (WebCore::RenderSVGResourceMarker::layout): (WebCore::RenderSVGResourceMarker::removeAllClientsFromCache): (WebCore::RenderSVGResourceMarker::removeClientFromCache):
- rendering/RenderSVGResourceMarker.h:
- rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::removeAllClientsFromCache): (WebCore::RenderSVGResourceMasker::removeClientFromCache):
- rendering/RenderSVGResourceMasker.h:
- rendering/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::removeAllClientsFromCache): (WebCore::RenderSVGResourcePattern::removeClientFromCache): (WebCore::RenderSVGResourcePattern::applyResource):
- rendering/RenderSVGResourcePattern.h:
- rendering/RenderSVGResourceSolidColor.h: (WebCore::RenderSVGResourceSolidColor::removeAllClientsFromCache): (WebCore::RenderSVGResourceSolidColor::removeClientFromCache):
- rendering/SVGRenderSupport.cpp: (WebCore::invalidateResourcesOfChildren): Add new helper funtion recursively invalidating resources of a sub render tree. (WebCore::SVGRenderSupport::layoutChildren): Keep track of all objects that didn't need layout, as we still have to invalidate their resources, if window size changes.
- rendering/SVGResources.cpp: (WebCore::SVGResources::removeClientFromCache): (WebCore::SVGResources::resourceDestroyed):
- rendering/SVGResources.h:
- rendering/SVGResourcesCache.cpp: (WebCore::SVGResourcesCache::clientLayoutChanged):
2010-08-12 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Window size changes + resources on absolute sized content leads to pixelation
https://bugs.webkit.org/show_bug.cgi?id=43921
- platform/mac/svg/custom/absolute-sized-content-with-resources-expected.checksum: Added.
- platform/mac/svg/custom/absolute-sized-content-with-resources-expected.png: Added.
- platform/mac/svg/custom/absolute-sized-content-with-resources-expected.txt: Added.
- svg/custom/absolute-sized-content-with-resources.xhtml: Added.
- 2:55 AM Changeset in webkit [65309] by
-
- 2 edits5 moves3 adds in trunk/LayoutTests
2010-08-13 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Chromium DevTools: brush up test expectations.
https://bugs.webkit.org/show_bug.cgi?id=43959
- platform/chromium/inspector/console-dir-expected.txt: Added.
- platform/chromium/inspector/console-format-expected.txt: Added.
- platform/chromium/inspector/timeline-event-dispatch-expected.txt: Renamed from LayoutTests/platform/chromium-win/inspector/timeline-event-dispatch-expected.txt.
- platform/chromium/inspector/timeline-mark-timeline-expected.txt: Renamed from LayoutTests/platform/chromium-win/inspector/timeline-mark-timeline-expected.txt.
- platform/chromium/inspector/timeline-network-resource-expected.txt: Renamed from LayoutTests/platform/chromium-win/inspector/timeline-network-resource-expected.txt.
- platform/chromium/inspector/timeline-paint-expected.txt: Renamed from LayoutTests/platform/chromium-win/inspector/timeline-paint-expected.txt.
- platform/chromium/inspector/timeline-parse-html-expected.txt: Renamed from LayoutTests/platform/chromium-win/inspector/timeline-parse-html-expected.txt.
- platform/chromium/test_expectations.txt:
- 1:54 AM Changeset in webkit [65308] by
-
- 7 edits2 adds in trunk/WebKitTools
2010-08-13 Kenichi Ishibashi <bashi@google.com>
Reviewed by Shinichiro Hamaji.
Add test_expectations.txt syntax checker to check-webkit-style.
https://bugs.webkit.org/show_bug.cgi?id=43899
Just utilizing layout_tests/layout_package/test_expectations.py for checking
the syntax of test_expectations.txt.
This change also moves tab checking class from style/checkers/text.py to
style/checkers/common.py for sharing code.
- Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
- Scripts/webkitpy/style/checker.py:
- Scripts/webkitpy/style/checkers/common.py:
- Scripts/webkitpy/style/checkers/common_unittest.py:
- Scripts/webkitpy/style/checkers/test_expectations.py: Added.
- Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Added.
- Scripts/webkitpy/style/checkers/text.py:
- Scripts/webkitpy/style_references.py:
- 1:42 AM Changeset in webkit [65307] by
-
- 2 edits in trunk/WebCore
2010-08-13 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Chromium DevTools: [CRASH] Autocomplete on arrays causes crashes.
https://bugs.webkit.org/show_bug.cgi?id=43955
- bindings/v8/ScriptValue.cpp: (WebCore::v8ToInspectorValue):
- 1:38 AM Changeset in webkit [65306] by
-
- 2 edits in trunk
2010-08-13 Patrick Gansterer <paroga@paroga.com>
Reviewed by Nikolas Zimmermann.
[CMake] Add missing FIND_PACKAGE(Gperf)
https://bugs.webkit.org/show_bug.cgi?id=43937
- CMakeLists.txt:
- 12:35 AM Changeset in webkit [65305] by
-
- 41 edits in trunk
Unify UString::UTF8String() & String::utf8() methods,
remove UString::cost() & make atArrayIndex a free function.
Reviewed by Sam Weinig
- JavaScriptCore.exp:
- bytecode/CodeBlock.cpp:
(JSC::constantName):
(JSC::idName):
(JSC::CodeBlock::registerName):
(JSC::regexpName):
(JSC::printGlobalResolveInfo):
(JSC::printStructureStubInfo):
(JSC::CodeBlock::printStructure):
(JSC::CodeBlock::printStructures):
- jsc.cpp:
(functionPrint):
(functionDebug):
(runInteractive):
(fillBufferWithContentsOfFile):
- pcre/pcre_exec.cpp:
(Histogram::~Histogram):
- profiler/CallIdentifier.h:
(JSC::CallIdentifier::c_str):
- profiler/Profile.cpp:
(JSC::Profile::debugPrintDataSampleStyle):
- profiler/ProfileGenerator.cpp:
(JSC::ProfileGenerator::willExecute):
(JSC::ProfileGenerator::didExecute):
- profiler/ProfileNode.cpp:
(JSC::ProfileNode::debugPrintData):
(JSC::ProfileNode::debugPrintDataSampleStyle):
- runtime/Arguments.cpp:
(JSC::Arguments::getOwnPropertySlot):
(JSC::Arguments::getOwnPropertyDescriptor):
(JSC::Arguments::put):
(JSC::Arguments::deleteProperty):
- runtime/DateConversion.cpp:
(JSC::parseDate):
- runtime/Identifier.h:
(JSC::Identifier::toStrictUInt32):
- runtime/JSArray.cpp:
(JSC::JSArray::getOwnPropertySlot):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::put):
(JSC::JSArray::deleteProperty):
- runtime/JSArray.h:
(JSC::toArrayIndex):
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::encode):
(JSC::parseInt):
(JSC::globalFuncJSCPrint):
- runtime/JSString.h:
(JSC::RopeBuilder::JSString):
- runtime/UString.cpp:
(JSC::UString::toDouble):
(JSC::putUTF8Triple):
(JSC::UString::utf8):
- runtime/UString.h:
(JSC::UString::~UString):
(JSC::UString::isNull):
(JSC::UString::isEmpty):
(JSC::UString::impl):
- wtf/text/WTFString.cpp:
(WTF::String::utf8):
- wtf/text/WTFString.h:
(WTF::String::~String):
(WTF::String::swap):
(WTF::String::isNull):
(WTF::String::isEmpty):
(WTF::String::impl):
(WTF::String::length):
(WTF::String::String):
(WTF::String::isHashTableDeletedValue):
WebCore:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertyDescriptor):
- bridge/NP_jsobject.cpp:
(_NPN_Enumerate):
- bridge/c/c_utility.cpp:
(JSC::Bindings::convertValueToNPVariant):
- bridge/jni/JNIBridge.cpp:
(JavaParameter::JavaParameter):
(JavaMethod::JavaMethod):
(JavaMethod::signature):
(JavaMethod::methodID):
- bridge/jni/JNIBridge.h:
(JSC::Bindings::JavaString::utf8):
(JSC::Bindings::JavaParameter::type):
(JSC::Bindings::JavaMethod::returnType):
- bridge/jni/jni_jsobject.mm:
(JavaJSObject::call):
(JavaJSObject::eval):
(JavaJSObject::getMember):
(JavaJSObject::setMember):
(JavaJSObject::removeMember):
(JavaJSObject::convertJObjectToValue):
- bridge/jni/jsc/JNIBridgeJSC.cpp:
(JavaField::JavaField):
(JavaField::valueFromInstance):
(JavaField::setValueToInstance):
- bridge/jni/jsc/JNIBridgeJSC.h:
(JSC::Bindings::JavaField::type):
- bridge/jni/jsc/JavaInstanceJSC.cpp:
(JavaInstance::invokeMethod):
- bridge/jni/jsc/JavaStringJSC.h:
(JSC::Bindings::JavaStringImpl::utf8):
- bridge/runtime_array.cpp:
(JSC::RuntimeArray::getOwnPropertySlot):
(JSC::RuntimeArray::getOwnPropertyDescriptor):
(JSC::RuntimeArray::put):
WebKit/mac:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::enumerate):
WebKit/wx:
- WebFrame.cpp:
(wxWebFrame::RunScript):
WebKit2:
- WebProcess/Plugins/JSNPObject.cpp:
(WebKit::npIdentifierFromIdentifier):
- WebProcess/Plugins/NPJSObject.cpp:
(WebKit::NPJSObject::enumerate):
- WebProcess/Plugins/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant):
Aug 12, 2010:
- 11:58 PM Changeset in webkit [65304] by
-
- 10 edits in trunk
2010-08-12 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: allow interrupting long running JS to execute inspector command
https://bugs.webkit.org/show_bug.cgi?id=43900
- bindings/v8/ScriptDebugServer.cpp: (WebCore::): (WebCore::ScriptDebugServer::pause): (WebCore::ScriptDebugServer::interruptAndRun): (WebCore::ScriptDebugServer::runPendingTasks): (WebCore::ScriptDebugServer::handleV8DebugEvent):
- bindings/v8/ScriptDebugServer.h: (WebCore::ScriptDebugServer::Task::~Task):
2010-08-12 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: allow interrupting long running JS to execute inspector command
https://bugs.webkit.org/show_bug.cgi?id=43900
- public/WebDevToolsAgent.h: (WebKit::WebDevToolsAgent::MessageDescriptor::~MessageDescriptor):
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgent::interruptAndDispatch): (WebKit::WebDevToolsAgent::shouldInterruptForMessage): (WebKit::WebDevToolsAgent::processPendingMessages):
- src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl):
- src/WebDevToolsFrontendImpl.h:
- src/js/DevTools.js:
- 11:49 PM Changeset in webkit [65303] by
-
- 3 edits in trunk/JavaScriptCore
Refactoring the fpu code generator for the ARM port
https://bugs.webkit.org/show_bug.cgi?id=43842
Reviewed by Gavin Barraclough.
Support up to 32 double precision registers, and the
recent VFP instruction formats. This patch is mainly
a style change which keeps the current functionality.
- assembler/ARMAssembler.h:
(JSC::ARMRegisters::):
(JSC::ARMAssembler::):
(JSC::ARMAssembler::emitInst):
(JSC::ARMAssembler::emitDoublePrecisionInst):
(JSC::ARMAssembler::emitSinglePrecisionInst):
(JSC::ARMAssembler::vadd_f64_r):
(JSC::ARMAssembler::vdiv_f64_r):
(JSC::ARMAssembler::vsub_f64_r):
(JSC::ARMAssembler::vmul_f64_r):
(JSC::ARMAssembler::vcmp_f64_r):
(JSC::ARMAssembler::vsqrt_f64_r):
(JSC::ARMAssembler::vmov_vfp_r):
(JSC::ARMAssembler::vmov_arm_r):
(JSC::ARMAssembler::vcvt_f64_s32_r):
(JSC::ARMAssembler::vcvt_s32_f64_r):
(JSC::ARMAssembler::vmrs_apsr):
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::addDouble):
(JSC::MacroAssemblerARM::divDouble):
(JSC::MacroAssemblerARM::subDouble):
(JSC::MacroAssemblerARM::mulDouble):
(JSC::MacroAssemblerARM::sqrtDouble):
(JSC::MacroAssemblerARM::convertInt32ToDouble):
(JSC::MacroAssemblerARM::branchDouble):
(JSC::MacroAssemblerARM::branchConvertDoubleToInt32):
- 11:42 PM Changeset in webkit [65302] by
-
- 41 edits in trunk
2010-08-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r65295.
http://trac.webkit.org/changeset/65295
https://bugs.webkit.org/show_bug.cgi?id=43950
It broke 4 sputnik tests (Requested by Ossy on #webkit).
- JavaScriptCore.exp:
- bytecode/CodeBlock.cpp: (JSC::constantName): (JSC::idName): (JSC::CodeBlock::registerName): (JSC::regexpName): (JSC::printGlobalResolveInfo): (JSC::printStructureStubInfo): (JSC::CodeBlock::printStructure): (JSC::CodeBlock::printStructures):
- jsc.cpp: (functionPrint): (functionDebug): (runInteractive): (fillBufferWithContentsOfFile):
- pcre/pcre_exec.cpp: (Histogram::~Histogram):
- profiler/CallIdentifier.h: (JSC::CallIdentifier::c_str):
- profiler/Profile.cpp: (JSC::Profile::debugPrintDataSampleStyle):
- profiler/ProfileGenerator.cpp: (JSC::ProfileGenerator::willExecute): (JSC::ProfileGenerator::didExecute):
- profiler/ProfileNode.cpp: (JSC::ProfileNode::debugPrintData): (JSC::ProfileNode::debugPrintDataSampleStyle):
- runtime/Arguments.cpp: (JSC::Arguments::getOwnPropertySlot): (JSC::Arguments::getOwnPropertyDescriptor): (JSC::Arguments::put): (JSC::Arguments::deleteProperty):
- runtime/DateConversion.cpp: (JSC::parseDate):
- runtime/Identifier.h: (JSC::Identifier::Identifier): (JSC::Identifier::toArrayIndex):
- runtime/JSArray.cpp: (JSC::JSArray::getOwnPropertySlot): (JSC::JSArray::getOwnPropertyDescriptor): (JSC::JSArray::put): (JSC::JSArray::deleteProperty):
- runtime/JSArray.h:
- runtime/JSGlobalObjectFunctions.cpp: (JSC::encode): (JSC::parseInt): (JSC::globalFuncJSCPrint):
- runtime/JSString.h: (JSC::RopeBuilder::JSString):
- runtime/UString.cpp: (JSC::UString::toDouble): (JSC::UString::UTF8String):
- runtime/UString.h: (JSC::UString::isNull): (JSC::UString::isEmpty): (JSC::UString::impl): (JSC::UString::cost): (JSC::UString::~UString): (JSC::UString::toArrayIndex):
- wtf/text/WTFString.cpp: (WTF::String::utf8):
- wtf/text/WTFString.h: (WTF::String::String): (WTF::String::isHashTableDeletedValue): (WTF::String::length): (WTF::String::operator[]): (WTF::String::isNull): (WTF::String::isEmpty): (WTF::String::impl):
2010-08-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r65295.
http://trac.webkit.org/changeset/65295
https://bugs.webkit.org/show_bug.cgi?id=43950
It broke 4 sputnik tests (Requested by Ossy on #webkit).
- WebFrame.cpp: (wxWebFrame::RunScript):
2010-08-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r65295.
http://trac.webkit.org/changeset/65295
https://bugs.webkit.org/show_bug.cgi?id=43950
It broke 4 sputnik tests (Requested by Ossy on #webkit).
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::enumerate):
2010-08-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r65295.
http://trac.webkit.org/changeset/65295
https://bugs.webkit.org/show_bug.cgi?id=43950
It broke 4 sputnik tests (Requested by Ossy on #webkit).
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getOwnPropertySlot): (WebCore::JSDOMWindow::getOwnPropertyDescriptor):
- bridge/NP_jsobject.cpp: (_NPN_Enumerate):
- bridge/c/c_utility.cpp: (JSC::Bindings::convertValueToNPVariant):
- bridge/jni/JNIBridge.cpp: (JavaParameter::JavaParameter): (JavaMethod::JavaMethod): (JavaMethod::signature): (JavaMethod::methodID):
- bridge/jni/JNIBridge.h: (JSC::Bindings::JavaString::UTF8String): (JSC::Bindings::JavaParameter::type): (JSC::Bindings::JavaMethod::returnType):
- bridge/jni/jni_jsobject.mm: (JavaJSObject::call): (JavaJSObject::eval): (JavaJSObject::getMember): (JavaJSObject::setMember): (JavaJSObject::removeMember): (JavaJSObject::convertJObjectToValue):
- bridge/jni/jsc/JNIBridgeJSC.cpp: (JavaField::JavaField): (JavaField::valueFromInstance): (JavaField::setValueToInstance):
- bridge/jni/jsc/JNIBridgeJSC.h: (JSC::Bindings::JavaField::type):
- bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod):
- bridge/jni/jsc/JavaStringJSC.h: (JSC::Bindings::JavaStringImpl::UTF8String):
- bridge/runtime_array.cpp: (JSC::RuntimeArray::getOwnPropertySlot): (JSC::RuntimeArray::getOwnPropertyDescriptor): (JSC::RuntimeArray::put):
2010-08-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r65295.
http://trac.webkit.org/changeset/65295
https://bugs.webkit.org/show_bug.cgi?id=43950
It broke 4 sputnik tests (Requested by Ossy on #webkit).
- WebProcess/Plugins/JSNPObject.cpp: (WebKit::npIdentifierFromIdentifier):
- WebProcess/Plugins/NPJSObject.cpp: (WebKit::NPJSObject::enumerate):
- WebProcess/Plugins/NPRuntimeObjectMap.cpp: (WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant):
- 11:35 PM Changeset in webkit [65301] by
-
- 2 edits in trunk/WebCore
2010-08-12 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Fixed typo in inspector js.
Follow up to r65300.
- inspector/front-end/inspector.js: (WebInspector.log.isLogAvailable):
- 11:31 PM Changeset in webkit [65300] by
-
- 6 edits in trunk/WebCore
2010-08-12 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Make getPrototypes return objects, not names.
https://bugs.webkit.org/show_bug.cgi?id=43934
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor): (injectedScriptConstructor.):
- inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.callback):
- inspector/front-end/inspector.js: (WebInspector.log):
- 10:43 PM Changeset in webkit [65299] by
-
- 8 edits in trunk/WebCore
2010-08-12 James Robinson <jamesr@chromium.org>
Unreviewed, rolling out r65284 and r65288. Broke chromium compile.
https://bugs.webkit.org/show_bug.cgi?id=43725
http://trac.webkit.org/changeset/65284
http://trac.webkit.org/changeset/65288
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::namedItemAdded): (WebCore::ScriptController::namedItemRemoved):
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::updateDocumentWrapperCache):
- bindings/v8/V8DOMWindowShell.h:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::V8HTMLDocument::namedPropertyDeleter): (WebCore::V8HTMLDocument::namedPropertyGetter): (WebCore::V8HTMLDocument::indexedPropertyGetter): (WebCore::V8HTMLDocument::allAccessorSetter): (WebCore::toV8):
- html/HTMLDocument.cpp: (WebCore::HTMLDocument::removeItemFromMap):
- 9:33 PM Changeset in webkit [65298] by
-
- 2 edits in trunk/LayoutTests
Add more files to the WebKit2 skipped list.
Reviewed by Gavin Barraclough.
- platform/mac-wk2/Skipped:
- 9:27 PM Changeset in webkit [65297] by
-
- 2 edits in trunk/LayoutTests
2010-08-12 James Robinson <jamesr@chromium.org>
Unreviewed. Mark play-state.html and isindex-with-no-form.html as flaky because they are.
- platform/chromium/test_expectations.txt:
- 9:09 PM Changeset in webkit [65296] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 8:58 PM Changeset in webkit [65295] by
-
- 41 edits in trunk
Unify UString::UTF8String() & String::utf8() methods,
remove UString::cost() & make atArrayIndex a free function.
Reviewed by Sam Weinig
- JavaScriptCore.exp:
- bytecode/CodeBlock.cpp:
(JSC::constantName):
(JSC::idName):
(JSC::CodeBlock::registerName):
(JSC::regexpName):
(JSC::printGlobalResolveInfo):
(JSC::printStructureStubInfo):
(JSC::CodeBlock::printStructure):
(JSC::CodeBlock::printStructures):
- jsc.cpp:
(functionPrint):
(functionDebug):
(runInteractive):
(fillBufferWithContentsOfFile):
- pcre/pcre_exec.cpp:
(Histogram::~Histogram):
- profiler/CallIdentifier.h:
(JSC::CallIdentifier::c_str):
- profiler/Profile.cpp:
(JSC::Profile::debugPrintDataSampleStyle):
- profiler/ProfileGenerator.cpp:
(JSC::ProfileGenerator::willExecute):
(JSC::ProfileGenerator::didExecute):
- profiler/ProfileNode.cpp:
(JSC::ProfileNode::debugPrintData):
(JSC::ProfileNode::debugPrintDataSampleStyle):
- runtime/Arguments.cpp:
(JSC::Arguments::getOwnPropertySlot):
(JSC::Arguments::getOwnPropertyDescriptor):
(JSC::Arguments::put):
(JSC::Arguments::deleteProperty):
- runtime/DateConversion.cpp:
(JSC::parseDate):
- runtime/Identifier.h:
(JSC::Identifier::toStrictUInt32):
- runtime/JSArray.cpp:
(JSC::JSArray::getOwnPropertySlot):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::put):
(JSC::JSArray::deleteProperty):
- runtime/JSArray.h:
(JSC::toArrayIndex):
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::encode):
(JSC::parseInt):
(JSC::globalFuncJSCPrint):
- runtime/JSString.h:
(JSC::RopeBuilder::JSString):
- runtime/UString.cpp:
(JSC::UString::toDouble):
(JSC::putUTF8Triple):
(JSC::UString::utf8):
- runtime/UString.h:
(JSC::UString::~UString):
(JSC::UString::isNull):
(JSC::UString::isEmpty):
(JSC::UString::impl):
- wtf/text/WTFString.cpp:
(WTF::String::utf8):
- wtf/text/WTFString.h:
(WTF::String::~String):
(WTF::String::swap):
(WTF::String::isNull):
(WTF::String::isEmpty):
(WTF::String::impl):
(WTF::String::length):
(WTF::String::String):
(WTF::String::isHashTableDeletedValue):
WebCore:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertyDescriptor):
- bridge/NP_jsobject.cpp:
(_NPN_Enumerate):
- bridge/c/c_utility.cpp:
(JSC::Bindings::convertValueToNPVariant):
- bridge/jni/JNIBridge.cpp:
(JavaParameter::JavaParameter):
(JavaMethod::JavaMethod):
(JavaMethod::signature):
(JavaMethod::methodID):
- bridge/jni/JNIBridge.h:
(JSC::Bindings::JavaString::utf8):
(JSC::Bindings::JavaParameter::type):
(JSC::Bindings::JavaMethod::returnType):
- bridge/jni/jni_jsobject.mm:
(JavaJSObject::call):
(JavaJSObject::eval):
(JavaJSObject::getMember):
(JavaJSObject::setMember):
(JavaJSObject::removeMember):
(JavaJSObject::convertJObjectToValue):
- bridge/jni/jsc/JNIBridgeJSC.cpp:
(JavaField::JavaField):
(JavaField::valueFromInstance):
(JavaField::setValueToInstance):
- bridge/jni/jsc/JNIBridgeJSC.h:
(JSC::Bindings::JavaField::type):
- bridge/jni/jsc/JavaInstanceJSC.cpp:
(JavaInstance::invokeMethod):
- bridge/jni/jsc/JavaStringJSC.h:
(JSC::Bindings::JavaStringImpl::utf8):
- bridge/runtime_array.cpp:
(JSC::RuntimeArray::getOwnPropertySlot):
(JSC::RuntimeArray::getOwnPropertyDescriptor):
(JSC::RuntimeArray::put):
WebKit/mac:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::enumerate):
WebKit/wx:
- WebFrame.cpp:
(wxWebFrame::RunScript):
WebKit2:
- WebProcess/Plugins/JSNPObject.cpp:
(WebKit::npIdentifierFromIdentifier):
- WebProcess/Plugins/NPJSObject.cpp:
(WebKit::NPJSObject::enumerate):
- WebProcess/Plugins/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant):
- 8:47 PM Changeset in webkit [65294] by
-
- 3 edits in trunk/WebKitTools
WebKitTestRunner does not correctly resize WebView for W3C SVG tests
https://bugs.webkit.org/show_bug.cgi?id=43945
Reviewed by Sam Weinig.
- WebKitTestRunner/TestInvocation.cpp:
(WTR::sizeWebViewForCurrentTest):
Allow for a Windows-style path.
- WebKitTestRunner/win/PlatformWebViewWin.cpp:
(WTR::PlatformWebView::resizeTo):
Call SetWindowPos to resize the view window.
- 8:46 PM Changeset in webkit [65293] by
-
- 2 edits in trunk/WebKit2
WebKit2 needs to initialize SafariTheme
https://bugs.webkit.org/show_bug.cgi?id=43901
Reviewed by Sam Weinig.
- WebProcess/win/WebProcessMainWin.cpp:
(WebKit::initializeSafariTheme):
Copied from old WebKit.
(WebKit::WebProcessMain):
If we're using SafariTheme, initialize it.
- 8:21 PM Changeset in webkit [65292] by
-
- 4 edits in trunk/WebKit2
2010-08-12 Maciej Stachowiak <mjs@apple.com>
Reviewed by Sam Weinig.
WebKit2 crashes when WebFrame outlives WebPage
https://bugs.webkit.org/show_bug.cgi?id=43939
- WebProcess/WebCoreSupport/WebChromeClient.h: (WebKit::WebChromeClient::page): Add this method, to allow WebFrame to retrieve its WebPage following WebCore pointers.
- WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::WebFrame): Do not initialize m_page (it's gone). (WebKit::WebFrame::page): Don't use the data member, get it from WebCore. (WebKit::WebFrame::invalidate): Use method to get page() and null check. (WebKit::WebFrame::isMainFrame): ditto
- WebProcess/WebPage/WebFrame.h:
- 8:11 PM Changeset in webkit [65291] by
-
- 2 edits in trunk/LayoutTests
2010-08-12 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed, fixing the previous commit.
Added PASS CRASH expectation for editing/pasteboard/smart-paste-004.html.
- platform/chromium/test_expectations.txt:
- 8:05 PM Changeset in webkit [65290] by
-
- 2 edits in trunk/LayoutTests
2010-08-12 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed.
Added PASS CRASH expectation for editing/pasteboard/smart-paste-003.html and
editing/pasteboard/smart-paste-004.html reported by japhet.
- platform/chromium/test_expectations.txt:
- 7:29 PM Changeset in webkit [65289] by
-
- 4 edits in trunk/JavaScriptCore
Eeerk! - revert accidentally committed changes in UString!
- JavaScriptCore.exp:
- runtime/UString.cpp:
(JSC::UString::UString):
- runtime/UString.h:
- 7:29 PM Changeset in webkit [65288] by
-
- 2 edits in trunk/WebCore
Speculative build fix for chromium bindings (someone added the old include style!).
- bindings/v8/V8DOMWindowShell.h:
- 6:44 PM Changeset in webkit [65287] by
-
- 4 edits in trunk/WebCore
2010-08-12 MORITA Hajime <morrita@google.com>
Reviewed by Tony Chang.
[Refactoring] TextEvent class has to many flags
https://bugs.webkit.org/show_bug.cgi?id=43893
Turned TextEvent::m_isLineBreak, TextEvent::m_isBacktab, TextEvent::m_isPaste
into single TextEvent::m_inputType enumeration.
No functional change. No new tests.
- dom/TextEvent.cpp: (WebCore::TextEvent::selectInputType): (WebCore::TextEvent::create): (WebCore::TextEvent::createForPlainTextPaste): (WebCore::TextEvent::createForFragmentPaste): (WebCore::TextEvent::TextEvent):
- dom/TextEvent.h: (WebCore::TextEvent::): (WebCore::TextEvent::isLineBreak): (WebCore::TextEvent::isBackTab): (WebCore::TextEvent::isPaste):
- page/EventHandler.cpp: (WebCore::EventHandler::handleTextInputEvent):
- 6:05 PM Changeset in webkit [65286] by
-
- 9 edits in trunk/JavaScriptCore
Change UString constructors to match those in WTF::String.
This changes behaviour of UString((char*)0) to create null
strings, akin to UString() rather than UString::empty().
(This matches String). Remove unused constructors from
UString, and add null-terminated UTF-16 constructor, to
match String. Move String's constructor into the .cpp to
match UString.
Reviewed by Sam Weinig
- JavaScriptCore.exp:
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::calculatedFunctionName):
- runtime/RegExpKey.h:
(JSC::RegExpKey::RegExpKey):
- runtime/SmallStrings.cpp:
(JSC::SmallStrings::createSingleCharacterString):
- runtime/UString.cpp:
(JSC::UString::UString):
- runtime/UString.h:
(JSC::UString::UString):
(JSC::UString::swap):
(JSC::UString::adopt):
(JSC::UString::operator[]):
- wtf/text/WTFString.h:
(WTF::String::String):
(WTF::String::adopt):
(WTF::String::operator[]):
- 5:12 PM Changeset in webkit [65285] by
-
- 5 edits4 deletes in trunk/WebCore
2010-08-12 Kenneth Russell <kbr@google.com>
Reviewed by David Levin.
Delete obsolete CanvasNumberArray
https://bugs.webkit.org/show_bug.cgi?id=38619
Deleted unreferenced code. Built WebKit and Chromium to test.
- Android.derived.jscbindings.mk:
- Android.derived.v8bindings.mk:
- Android.jscbindings.mk:
- Android.mk:
- bindings/js/JSCanvasNumberArrayCustom.cpp: Removed.
- html/canvas/CanvasNumberArray.cpp: Removed.
- html/canvas/CanvasNumberArray.h: Removed.
- html/canvas/CanvasNumberArray.idl: Removed.
- 4:57 PM Changeset in webkit [65284] by
-
- 8 edits in trunk/WebCore
2010-08-12 Anton Muhin <antonm@chromium.org>
Reviewed by Nate Chapin.
[v8] Create callbacks for named access of elements from document object on fly.
https://bugs.webkit.org/show_bug.cgi?id=43725
That should speed up access to methods on document as there is no need to
consult with interceptor before invoking the method.
This reapplies http://trac.webkit.org/changeset/60670 reverted with
http://trac.webkit.org/changeset/63845. The main difference is in treatment
of removed named elements: we don't remove an accessor any more, but leave it.
Therefore any accessor should be able to treat the case when there is no
expando property.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::namedItemAdded): (WebCore::ScriptController::namedItemRemoved):
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::checkDocumentWrapper): (WebCore::V8DOMWindowShell::updateDocumentWrapperCache): (WebCore::getter): (WebCore::V8DOMWindowShell::namedItemAdded): (WebCore::V8DOMWindowShell::namedItemRemoved):
- bindings/v8/V8DOMWindowShell.h:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::V8HTMLDocument::WrapInShadowObject): (WebCore::V8HTMLDocument::GetNamedProperty): (WebCore::V8HTMLDocument::allAccessorSetter): (WebCore::toV8):
- html/HTMLDocument.cpp: (WebCore::HTMLDocument::removeItemFromMap):
- 4:30 PM Changeset in webkit [65283] by
-
- 1 edit27 adds in trunk/LayoutTests
2010-08-12 Tony Chang <tony@chromium.org>
Unreviewed, landing google-chrome linux 64 test results.
- platform/google-chrome-linux64/fast/borders/borderRadiusGroove01-expected.checksum: Added.
- platform/google-chrome-linux64/fast/borders/borderRadiusGroove01-expected.png: Added.
- platform/google-chrome-linux64/fast/borders/borderRadiusGroove02-expected.checksum: Added.
- platform/google-chrome-linux64/fast/borders/borderRadiusGroove02-expected.png: Added.
- platform/google-chrome-linux64/fast/borders/borderRadiusRidge01-expected.checksum: Added.
- platform/google-chrome-linux64/fast/borders/borderRadiusRidge01-expected.png: Added.
- platform/google-chrome-linux64/svg/W3C-SVG-1.1/paths-data-12-t-expected.checksum: Added.
- platform/google-chrome-linux64/svg/W3C-SVG-1.1/paths-data-12-t-expected.png: Added.
- platform/google-chrome-linux64/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt: Added.
- platform/google-chrome-linux64/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.checksum: Added.
- platform/google-chrome-linux64/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png: Added.
- platform/google-chrome-linux64/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.checksum: Added.
- platform/google-chrome-linux64/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png: Added.
- platform/google-chrome-linux64/svg/hixie/perf/001-expected.txt: Added.
- platform/google-chrome-linux64/svg/hixie/perf/002-expected.txt: Added.
- platform/google-chrome-linux64/svg/zoom/page/zoom-coords-viewattr-01-b-expected.checksum: Added.
- platform/google-chrome-linux64/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
- 4:26 PM Changeset in webkit [65282] by
-
- 2 edits in trunk
2010-08-12 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by David Levin.
Add more Chromium-related dependency directories to .gitignore.
https://bugs.webkit.org/show_bug.cgi?id=43940
- .gitignore: Added all existing that are created by update-webkit --chromium.
- 4:23 PM Changeset in webkit [65281] by
-
- 4 edits in trunk/WebCore
2010-08-12 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Adam Barth.
Ensure that parser doesn't attach children that have been removed by JavaScript event handlers.
https://bugs.webkit.org/show_bug.cgi?id=43813
This patch re-fixes bug 40742 in a way that keeps allowing HTMLLinkElement
to lazy-attach.
- html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::attach): Added parent check.
- html/HTMLLinkElement.cpp: Basically undoes changes introduced by r61424.
- html/HTMLLinkElement.h: Ditto.
- 4:18 PM Changeset in webkit [65280] by
-
- 4 edits in trunk
2010-08-12 Justin Schuh <jschuh@chromium.org>
Reviewed by Dumitru Daniliuc.
Clear PluginData's page pointer on page refresh
https://bugs.webkit.org/show_bug.cgi?id=43888
Test: plugins/access-after-page-destroyed.html
- page/Page.cpp: (WebCore::Page::refreshPlugins):
2010-08-12 Justin Schuh <jschuh@chromium.org>
Reviewed by Dumitru Daniliuc.
Clear PluginData's page pointer on page refresh
https://bugs.webkit.org/show_bug.cgi?id=43888
- plugins/access-after-page-destroyed.html:
- 4:14 PM Changeset in webkit [65279] by
-
- 5 edits in trunk
2010-08-12 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
getParameter(STENCIL_VALUE_MASK) (and others) returns the wrong value
https://bugs.webkit.org/show_bug.cgi?id=31842
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getUnsignedLongParameter): Casting from int to unsigned long correctly.
2010-08-12 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
getParameter(STENCIL_VALUE_MASK) (and others) returns the wrong value
https://bugs.webkit.org/show_bug.cgi?id=31842
- fast/canvas/webgl/gl-get-calls-expected.txt: Bring back the commented out STENCIL tests.
- fast/canvas/webgl/gl-get-calls.html: Ditto.
- 4:11 PM MathML 3 testsuite results edited by
- (diff)
- 4:06 PM Changeset in webkit [65278] by
-
- 2 edits in trunk/WebCore
2010-08-12 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: mimic FireBug's array detection.
https://bugs.webkit.org/show_bug.cgi?id=30974
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
- 3:59 PM Changeset in webkit [65277] by
-
- 5 edits in trunk
2010-08-12 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
regression in generateMipmap
https://bugs.webkit.org/show_bug.cgi?id=43873
- html/canvas/WebGLTexture.cpp: (WebCore::WebGLTexture::generateMipmapLevelInfo): should set m_needToUseBlackTexture to false if generateMipmapLevelInfo runs through successfully.
2010-08-12 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
regression in generateMipmap
https://bugs.webkit.org/show_bug.cgi?id=43873
- fast/canvas/webgl/texture-npot-expected.txt: Add more test cases on NPOT/POT texture behaviors.
- fast/canvas/webgl/texture-npot.html: Ditto.
- 3:57 PM Changeset in webkit [65276] by
-
- 3 edits1 add in trunk/WebCore
2010-08-12 Ariya Hidayat <ariya@sencha.com>
Reviewed by David Hyatt.
[Qt] Split TransparencyLayer into its own header file.
https://bugs.webkit.org/show_bug.cgi?id=43935
- WebCore.pro: Include TransparencyLayer.h.
- platform/graphics/qt/GraphicsContextQt.cpp:
- platform/graphics/qt/TransparencyLayer.h: Added. (WebCore::TransparencyLayer::TransparencyLayer): (WebCore::TransparencyLayer::operator=):
- 3:53 PM Changeset in webkit [65275] by
-
- 24 edits in trunk
2010-08-12 François Sausset <François Sausset>
Reviewed by Beth Dakin.
Update the tests to take into account padding changes for the mrow element.
https://bugs.webkit.org/show_bug.cgi?id=43908
- platform/mac/mathml/presentation/fractions-expected.checksum:
- platform/mac/mathml/presentation/fractions-expected.png:
- platform/mac/mathml/presentation/fractions-expected.txt:
- platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum:
- platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
- platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
- platform/mac/mathml/presentation/roots-expected.checksum:
- platform/mac/mathml/presentation/roots-expected.png:
- platform/mac/mathml/presentation/roots-expected.txt:
- platform/mac/mathml/presentation/row-alignment-expected.checksum:
- platform/mac/mathml/presentation/row-alignment-expected.png:
- platform/mac/mathml/presentation/row-alignment-expected.txt:
- platform/mac/mathml/presentation/row-expected.checksum:
- platform/mac/mathml/presentation/row-expected.png:
- platform/mac/mathml/presentation/row-expected.txt:
- platform/mac/mathml/presentation/subsup-expected.checksum:
- platform/mac/mathml/presentation/subsup-expected.png:
- platform/mac/mathml/presentation/subsup-expected.txt:
- platform/mac/mathml/presentation/underover-expected.checksum:
- platform/mac/mathml/presentation/underover-expected.png:
- platform/mac/mathml/presentation/underover-expected.txt:
2010-08-12 François Sausset <François Sausset>
Reviewed by Beth Dakin.
Horizontal padding should be 0 on mrow elements.
https://bugs.webkit.org/show_bug.cgi?id=43908
Updated tests in /mathml
- css/mathml.css: (mrow, mfenced): (mfenced):
- 3:42 PM Changeset in webkit [65274] by
-
- 2 edits in trunk/WebKitTools
Build break fix.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues): Removed usage
of a variable that doesn't exist in the class.
- 3:40 PM Changeset in webkit [65273] by
-
- 9 edits in trunk
2010-08-12 Aaron Boodman <aa@chromium.org>
Reviewed by David Hyatt.
Make the cascade level of "user" styles configurable
https://bugs.webkit.org/show_bug.cgi?id=43457
- WebCore.exp.in:
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector):
- dom/Document.cpp: (WebCore::Document::pageGroupUserSheets):
- page/PageGroup.cpp: (WebCore::PageGroup::addUserStyleSheetToWorld):
- page/PageGroup.h:
- page/UserStyleSheet.h: (WebCore::UserStyleSheet::): (WebCore::UserStyleSheet::UserStyleSheet): (WebCore::UserStyleSheet::level):
2010-08-12 Aaron Boodman <aa@chromium.org>
Reviewed by David Hyatt.
Make the cascade level of "user" styles configurable
https://bugs.webkit.org/show_bug.cgi?id=43457
- src/WebViewImpl.cpp: (WebKit::WebView::addUserStyleSheet):
- 3:32 PM Changeset in webkit [65272] by
-
- 2 edits in trunk/WebCore
Fix qt build break.
- html/ThreadableBlobRegistry.cpp:
(WebCore::postTaskToMainThread):
- 3:16 PM Changeset in webkit [65271] by
-
- 13 edits2 adds in trunk/WebCore
Add ThreadableBlobRegistry to support calling BlobRegistry methods in
main thread.
https://bugs.webkit.org/show_bug.cgi?id=43874
Reviewed by David Levin.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::addBlob):
(WebCore::ScriptExecutionContext::removeBlob):
(WebCore::ScriptExecutionContext::createPublicBlobURL):
(WebCore::ScriptExecutionContext::revokePublicBlobURL):
- dom/ScriptExecutionContext.h:
- html/Blob.cpp:
(WebCore::Blob::Blob):
(WebCore::Blob::~Blob):
(WebCore::Blob::contextDestroyed):
- html/Blob.h:
- html/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::registerBlobURL):
(WebCore::BlobRegistryImpl::unregisterBlobURL):
(WebCore::BlobRegistryImpl::getBlobDataFromURL):
- html/ThreadableBlobRegistry.cpp: Added.
- html/ThreadableBlobRegistry.h: Added.
- 3:03 PM Changeset in webkit [65270] by
-
- 14 edits2 copies1 add in trunk
WebKitTestRunner needs to run tests without using native controls
https://bugs.webkit.org/show_bug.cgi?id=43772
Reviewed by Sam Weinig.
WebKit2:
- Shared/CoreIPCSupport/WebProcessMessageKinds.h:
(WebProcessMessage::):
Add a new message.
- UIProcess/API/C/win/WKContextPrivateWin.h: Added.
Declare WKContextSetShouldPaintNativeControls().
- UIProcess/API/C/win/WKContextWin.cpp: Added.
(WKContextSetShouldPaintNativeControls):
Call the WebContext's setShouldPaintNativeControls().
- UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
Initialize m_shouldPaintNativeControls.
(WebKit::WebContext::ensureWebProcess):
If we created a web process, call platformSetUpWebProcess().
- UIProcess/WebContext.h:
Declare new functions and a member to store whether we should paint
native controls.
- UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformSetUpWebProcess):
Stubbed.
- UIProcess/win/WebContextWin.cpp:
(WebKit::WebContext::setShouldPaintNativeControls):
Set m_shouldPaintNativeControls. If we have a valid web process, send a
SetShouldPaintNativeControls message.
(WebKit::WebContext::platformSetUpWebProcess):
Send a SetShouldPaintNativeControls message.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveMessage):
If this is a SetShouldPaintNativeControls message, decode the argument,
and call Settings::setShouldPaintNativeControls().
- win/WebKit2.vcproj:
Add WKContextPrivateWin.h and WKContextWin.cpp to project.
- win/WebKit2Generated.make:
Copy WKContextPrivateWin.h.
WebKitTools:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
Call platformInitializeContext().
- WebKitTestRunner/TestController.h:
Declare platformInitializeContext().
- WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::TestController::platformInitializeContext):
Stubbed.
- WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::TestController::platformInitializeContext):
Call WKContextSetShouldPaintNativeControls() to disable native control
drawing.
- 2:55 PM Changeset in webkit [65269] by
-
- 2 edits in trunk/WebCore
2010-08-12 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by Darin Adler.
generate-bindings.pl should generate warning free code
https://bugs.webkit.org/show_bug.cgi?id=43353
bindings/scripts/CodeGeneratorJS.pm: Suggested parentheses added around && within - 2:49 PM Changeset in webkit [65268] by
-
- 2 edits in trunk/JavaScriptCore
- runtime/UString.h: Removed unneccessary #include.
Reviewed by NOBODY (build fix).
- 2:28 PM Changeset in webkit [65267] by
-
- 14 edits2 deletes in trunk/WebKitTools
WebKitTestRunner should be more aggressive about ensuring consistent state between tests
https://bugs.webkit.org/show_bug.cgi?id=43653
Reviewed by Alexey Proskuryakov.
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::InjectedBundle):
(WTR::InjectedBundle::didReceiveMessage):
(WTR::InjectedBundle::beginTesting):
(WTR::InjectedBundle::done):
- WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(WTR::InjectedBundle::isTestRunning):
(WTR::InjectedBundle::):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::stopLoading):
(WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
(WTR::InjectedBundlePage::dump):
(WTR::InjectedBundlePage::didFinishLoadForFrame):
(WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
(WTR::InjectedBundlePage::didReceiveTitleForFrame):
(WTR::InjectedBundlePage::didClearWindowForFrame):
(WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
(WTR::InjectedBundlePage::willAddMessageToConsole):
(WTR::InjectedBundlePage::willSetStatusbarText):
(WTR::InjectedBundlePage::willRunJavaScriptAlert):
(WTR::InjectedBundlePage::willRunJavaScriptConfirm):
(WTR::InjectedBundlePage::shouldBeginEditing):
(WTR::InjectedBundlePage::shouldEndEditing):
(WTR::InjectedBundlePage::shouldInsertNode):
(WTR::InjectedBundlePage::shouldInsertText):
(WTR::InjectedBundlePage::shouldDeleteRange):
(WTR::InjectedBundlePage::shouldChangeSelectedRange):
(WTR::InjectedBundlePage::shouldApplyStyle):
(WTR::InjectedBundlePage::didBeginEditing):
(WTR::InjectedBundlePage::didEndEditing):
(WTR::InjectedBundlePage::didChange):
(WTR::InjectedBundlePage::didChangeSelection):
Don't do any work if we are not currently running a test.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
- WebKitTestRunner/StringFunctions.h:
(WTR::toCF):
Add conversion function for WKURLRef -> CFURLRef
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestController::resetStateToConsistentValues):
(WTR::TestController::runTest):
(WTR::TestController::didFinishLoadForFrame):
- WebKitTestRunner/TestController.h:
(WTR::TestController::):
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::invoke):
- WebKitTestRunner/TestInvocation.h:
Move resetting code to TestController.
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::TestController::runUntil):
- WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
- WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::TestController::runUntil):
- WebKitTestRunner/win/TestInvocationWin.cpp: Removed.
- WebKitTestRunner/win/WebKitTestRunner.vcproj:
Move runUntil to TestController.
- 2:20 PM Changeset in webkit [65266] by
-
- 3 edits in trunk/JavaScriptCore
Revert changes to ALWAYS_INLINEness of a couple of functions in UString.
This appears to have degraded performance.
Reviewed by Sam Weinig
- runtime/UString.cpp:
(JSC::UString::ascii):
- runtime/UString.h:
(JSC::UString::length):
(JSC::UString::isEmpty):
(JSC::UString::~UString):
- 2:06 PM Changeset in webkit [65265] by
-
- 2 edits in trunk/WebCore
2010-08-11 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
merge MarkupAccumulator and MarkupAccumulatorWrapper
https://bugs.webkit.org/show_bug.cgi?id=43834
Removed MarkupAccumulator and added serializeNodesWithNamespaces to use MarkupAccumulatorWrapper
in both versions of createMarkup. Accumulation of nodes done manually in serializeNodes is
now done by MarkupAccumulatorWrapper as done in the original MarkupAccumulator.
No new tests added since this is a cleanup.
- editing/markup.cpp: (WebCore::MarkupAccumulatorWrapper::MarkupAccumulatorWrapper): Takes vector of nodes and set it to m_nodes. (WebCore::MarkupAccumulatorWrapper::insertOpenTag): Adds node to m_nodes. (WebCore::MarkupAccumulatorWrapper::wrapWithNode): Adds node to m_nodes. (WebCore::serializeNodes): Adding node to nodes is moved into MarkupAccumulatorWrapper. (WebCore::createMarkup): Instantiates MarkupAccumulatorWrapper. (WebCore::serializeNodesWithNamespaces): Renamed from MarkupAccumulator::appendMarkup.
- 1:28 PM Changeset in webkit [65264] by
-
- 2 edits in trunk/JavaScriptCore
2010-08-12 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by Antonio Gomes.
[Qt] Fix warnings: unknown conversion type character 'l' in format
https://bugs.webkit.org/show_bug.cgi?id=43359
Qt port doesn't call any printf in String::format(...), consequently
using attribute((format(printf,m,n))) is incorrect and causes
false positive warnings on Windows if you build with MinGW.
Qt port calls QString::vsprintf(...) , which is platform
independent, and handles %lli, %llu and %llx on all platforms.
(http://trac.webkit.org/changeset/35712)
- wtf/text/WTFString.h:
- 1:05 PM Changeset in webkit [65263] by
-
- 17 edits in trunk/LayoutTests
Rebaselining the test results for media controls on Mac to fix
a regression.
Submitted for Victoria Kirst (vrk@google.com).
Reviewed by David Levin.
- platform/chromium-mac/media/audio-controls-rendering-expected.checksum:
- platform/chromium-mac/media/audio-controls-rendering-expected.png:
- platform/chromium-mac/media/controls-after-reload-expected.checksum:
- platform/chromium-mac/media/controls-after-reload-expected.png:
- platform/chromium-mac/media/controls-strict-expected.checksum:
- platform/chromium-mac/media/controls-strict-expected.png:
- platform/chromium-mac/media/video-controls-rendering-expected.checksum:
- platform/chromium-mac/media/video-controls-rendering-expected.png:
- platform/chromium-mac/media/video-display-toggle-expected.checksum:
- platform/chromium-mac/media/video-display-toggle-expected.png:
- platform/chromium-mac/media/video-no-audio-expected.checksum:
- platform/chromium-mac/media/video-no-audio-expected.png:
- platform/chromium-mac/media/video-volume-slider-expected.checksum:
- platform/chromium-mac/media/video-volume-slider-expected.png:
- platform/chromium-mac/media/video-volume-slider-expected.txt:
- platform/chromium/test_expectations.txt:
- 12:43 PM BuildingQtOnLinux edited by
- install dependencies on fedora (diff)
- 12:16 PM Changeset in webkit [65262] by
-
- 53 edits4 adds2 deletes in trunk/WebKit/efl
2010-08-11 Rafael Antognolli <antognolli@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Adding new theme for widgets.
https://bugs.webkit.org/show_bug.cgi?id=43860
Original theme was there for a long time. This is a new
fresh one.
- DefaultTheme/default.edc:
- DefaultTheme/widget/button/button.edc:
- DefaultTheme/widget/button/img_button_focus.png:
- DefaultTheme/widget/button/img_button_hover.png:
- DefaultTheme/widget/button/img_button_normal.png:
- DefaultTheme/widget/button/img_button_press.png:
- DefaultTheme/widget/check/check.edc:
- DefaultTheme/widget/check/img_check_off.png:
- DefaultTheme/widget/check/img_check_off_focus.png:
- DefaultTheme/widget/check/img_check_off_hover.png:
- DefaultTheme/widget/check/img_check_on.png:
- DefaultTheme/widget/check/img_check_on_focus.png:
- DefaultTheme/widget/check/img_check_on_hover.png:
- DefaultTheme/widget/combo/combo.edc:
- DefaultTheme/widget/combo/combo_focus.png:
- DefaultTheme/widget/combo/combo_focus_button.png:
- DefaultTheme/widget/combo/combo_hover.png:
- DefaultTheme/widget/combo/combo_hover_button.png:
- DefaultTheme/widget/combo/combo_normal.png:
- DefaultTheme/widget/combo/combo_normal_button.png:
- DefaultTheme/widget/combo/combo_press.png:
- DefaultTheme/widget/combo/combo_press_button.png:
- DefaultTheme/widget/combo/icon.png:
- DefaultTheme/widget/entry/img_focused.png:
- DefaultTheme/widget/entry/img_hovered.png:
- DefaultTheme/widget/entry/img_normal.png:
- DefaultTheme/widget/file/file_focus.png:
- DefaultTheme/widget/file/file_hover.png:
- DefaultTheme/widget/file/file_normal.png:
- DefaultTheme/widget/file/file_press.png:
- DefaultTheme/widget/radio/img_radio_off.png:
- DefaultTheme/widget/radio/img_radio_off_focus.png:
- DefaultTheme/widget/radio/img_radio_off_hover.png:
- DefaultTheme/widget/radio/img_radio_on.png:
- DefaultTheme/widget/radio/img_radio_on_focus.png:
- DefaultTheme/widget/radio/img_radio_on_hover.png:
- DefaultTheme/widget/radio/radio.edc:
- DefaultTheme/widget/scrollbar/scrollbar.edc:
- DefaultTheme/widget/scrollbar/scrollbar_h.png:
- DefaultTheme/widget/scrollbar/scrollbar_hilight.png: Removed.
- DefaultTheme/widget/scrollbar/scrollbar_knob_h.png:
- DefaultTheme/widget/scrollbar/scrollbar_knob_v.png:
- DefaultTheme/widget/scrollbar/scrollbar_v.png:
- DefaultTheme/widget/search/cancel/cancel_normal_button2.png:
- DefaultTheme/widget/search/decoration/decoration_normal_button.png:
- DefaultTheme/widget/search/field/field_focused.png:
- DefaultTheme/widget/search/field/field_hovered.png:
- DefaultTheme/widget/search/field/field_normal.png:
- DefaultTheme/widget/slider/slider.edc:
- DefaultTheme/widget/slider/slider_fill_h.png: Added.
- DefaultTheme/widget/slider/slider_fill_v.png: Added.
- DefaultTheme/widget/slider/slider_h.png:
- DefaultTheme/widget/slider/slider_hilight.png: Removed.
- DefaultTheme/widget/slider/slider_knob_h.png:
- DefaultTheme/widget/slider/slider_knob_press_h.png: Added.
- DefaultTheme/widget/slider/slider_knob_press_v.png: Added.
- DefaultTheme/widget/slider/slider_knob_v.png:
- DefaultTheme/widget/slider/slider_v.png:
- 12:13 PM Changeset in webkit [65261] by
-
- 2 edits in trunk/WebCore
2010-08-12 Dirk Schulze <krit@webkit.org>
Unreviewed sort of XCode project file.
- WebCore.xcodeproj/project.pbxproj:
- 11:22 AM Changeset in webkit [65260] by
-
- 2 edits in trunk/JavaScriptCore
2010-08-12 Gabor Loki <loki@webkit.org>
Reviewed by Geoffrey Garen.
Fix the array subscript is above array bounds warning in ByteArray on ARM.
https://bugs.webkit.org/show_bug.cgi?id=43358
The warning is very similar to this one: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37861
- wtf/ByteArray.cpp: (WTF::ByteArray::create):
- 11:04 AM Changeset in webkit [65259] by
-
- 2 edits in trunk/LayoutTests
2010-08-12 Nate Chapin <Nate Chapin>
Unreviewed, Chromium expectations tweak.
Remove a duplicate linux debug expectation.
- platform/chromium/test_expectations.txt:
- 10:51 AM Changeset in webkit [65258] by
-
- 2 edits in trunk/WebCore
2010-08-12 Ben Murdoch <benm@google.com>
Reviewed by Pavel Feldman.
InspectorController.h missing InspectorObject forward declaration
https://bugs.webkit.org/show_bug.cgi?id=43913
Build fix so no new tests.
- inspector/InspectorController.h: Adds the necessary forward declaration.
- 10:47 AM Changeset in webkit [65257] by
-
- 1 edit1 add in trunk/WebKit/gtk
Add file I forgot to add in r65255.
- 10:39 AM Changeset in webkit [65256] by
-
- 2 edits in trunk/WebKitTools
2010-08-12 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Unreviewed.
Adding myself to the committers list.
- Scripts/webkitpy/common/config/committers.py:
- 10:33 AM Changeset in webkit [65255] by
-
- 10 edits in trunk
2010-08-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Use GSettings to save/restore Web Inspector settings
https://bugs.webkit.org/show_bug.cgi?id=43512
- GNUmakefile.am: GSettings rules.
- configure.ac: GSettings infrastructure, and check if we should use it by looking for an appropriate version of GIO.
2010-08-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Use GSettings to save/restore Web Inspector settings
https://bugs.webkit.org/show_bug.cgi?id=43512
- wtf/gobject/GRefPtr.cpp: Added support for GVariant, used by our GSettings support. (WTF::refGPtr): (WTF::derefGPtr):
- wtf/gobject/GRefPtr.h:
WebKit/gtk
2010-08-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Use GSettings to save/restore Web Inspector settings
https://bugs.webkit.org/show_bug.cgi?id=43512
Use GSettings to save/restore settings used by the Web Inspector.
A few helper functions were added to have settings that use
boolean values be actual booleans, and also to conform with the
GSettings naming requirements for keys.
- WebCoreSupport/InspectorClientGtk.cpp: (WebKit::toGSettingName): (WebKit::truthStringFromVariant): (WebKit::variantFromTruthString): (WebKit::InspectorClient::populateSetting): (WebKit::InspectorClient::storeSetting):
- org.webkit.gtk.gschema.xml: Added.
- webkit/webkitprivate.cpp: (inspectorGSettings): (webkit_init):
- webkit/webkitprivate.h:
- 10:32 AM Changeset in webkit [65254] by
-
- 2 edits1 copy1 delete in trunk/WebKitTools
2010-08-12 Hayato Ito <hayato@chromium.org>
Reviewed by Tony Chang.
Merge pretty printers for gdb.
https://bugs.webkit.org/show_bug.cgi?id=43850
We need to update webcore.py because basic string classes have moved to WTF from WebCore.
It is good timing to merge webcore.py and wtf.py and name it 'webkit.py'.
webcore.py is left for backward compatibility.
- gdb/webcore.py:
- gdb/webkit.py: Added.
- gdb/wtf.py: Removed.
- 10:16 AM Changeset in webkit [65253] by
-
- 4 edits in trunk
2010-08-12 Rafael Antognolli <antognolli@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Making CMake keep track of theme dependencies.
https://bugs.webkit.org/show_bug.cgi?id=43862
Removing unused macro GENERATE_EDJ.
- cmake/WebKitEfl.cmake:
2010-08-12 Rafael Antognolli <antognolli@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Making CMake keep track of theme dependencies.
https://bugs.webkit.org/show_bug.cgi?id=43862
Adding theme source files and images as dependencies of the theme.
- CMakeListsEfl.txt:
- 10:11 AM QtWebKitTriageRoster edited by
- (diff)
- 10:10 AM MathML Goals edited by
- (diff)
- 10:10 AM MathML Goals edited by
- (diff)
- 10:03 AM Changeset in webkit [65252] by
-
- 2 edits in trunk/LayoutTests
2010-08-12 Nate Chapin <Nate Chapin>
Unreviewed, Chromium expectations tweak.
Comment out svg/hittest/svg-rect-hit.html, as the test
was not landed with the relevant patch.
- platform/chromium/test_expectations.txt:
- 10:02 AM MathML edited by
- (diff)
- 10:00 AM MathML Status edited by
- (diff)
- 9:59 AM Changeset in webkit [65251] by
-
- 3 edits in trunk/WebKit/chromium
2010-08-12 John Gregg <johnnyg@google.com>
Reviewed by Kent Tamura.
[chromium] Add Notification::detachPresenter to the WebKit API.
https://bugs.webkit.org/show_bug.cgi?id=43659
- public/WebNotification.h:
- src/WebNotification.cpp: (WebKit::WebNotification::detachPresenter):
- 9:38 AM MathML edited by
- (diff)
- 9:35 AM MathML edited by
- (diff)
- 9:33 AM Changeset in webkit [65250] by
-
- 4 edits2 adds in trunk/WebKitTools
2010-08-11 Tony Chang <tony@chromium.org>
Reviewed by David Levin.
[chromium] add google-chrome layout test result directories
https://bugs.webkit.org/show_bug.cgi?id=43889
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
- Scripts/webkitpy/layout_tests/port/factory.py:
- Scripts/webkitpy/layout_tests/port/google_chrome.py: Added.
- Scripts/webkitpy/layout_tests/test_types/image_diff.py:
- 9:32 AM MathML Status created by
- 9:20 AM MathML edited by
- (diff)
- 9:19 AM MathML edited by
- (diff)
- 8:58 AM Changeset in webkit [65249] by
-
- 2 edits in trunk/WebCore
2010-08-12 Hui Huang <hui.2.huang@nokia.com>
Reviewed by Eric Seidel.
m_windowRect is not updated because parent of PluginView is not
set when updatePluginWidget is called. plugin gets wrong window
size on setwindow.
https://bugs.webkit.org/show_bug.cgi?id=43635
- plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginView::setParent):
- 8:37 AM Changeset in webkit [65248] by
-
- 27 edits1 add1 delete in trunk
2010-08-12 Pavel Feldman <pfeldman@chromium.org>
Not reviewed, re-apply r65241 and 65243.
Web Inspector: brush up object proxies, introduce remote object model.
https://bugs.webkit.org/show_bug.cgi?id=43847
- 8:26 AM Changeset in webkit [65247] by
-
- 8 edits in trunk
2010-08-11 Stephen White <senorblanco@chromium.org>
Reviewed by David Levin.
Add support for BGRA pixel format to GraphicsContext3D.
https://bugs.webkit.org/show_bug.cgi?id=43858
Although this has been standard in desktop GL since 1.2, it's an
extension in GL ES 2.0, so a query function is provided to check
for support. The DefaultImpl returns false, since it does not yet
implement the TexImage2D internalFormat quirks.
- public/WebGraphicsContext3D.h: (WebKit::WebGraphicsContext3D::supportsBGRA):
- src/GraphicsContext3D.cpp:
- src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::supportsBGRA):
- src/WebGraphicsContext3DDefaultImpl.h:
2010-08-11 Stephen White <senorblanco@chromium.org>
Reviewed by David Levin.
Add support for BGRA pixel format to GraphicsContext3D.
https://bugs.webkit.org/show_bug.cgi?id=43858
Although this has been standard in desktop GL since 1.2, it's an
extension in GL ES 2.0, so a query function is provided to check
for support. Since they differ on semantics (GL ES 2.0 requires
TexImage2D()'s format and internalFormat to match, while desktop GL
will not accept BGRA as an internalFormat), the stub implementation
returns false until these quirks have been implemented and tested on
each port.
- platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::supportsBGRA): Add implementation for non-chromium platforms which returns false.
- platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::): Add query function (supportsBGRA()) and the BGRA_EXT token.
- 8:11 AM Changeset in webkit [65246] by
-
- 3 edits in trunk
2010-08-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r65225.
http://trac.webkit.org/changeset/65225
https://bugs.webkit.org/show_bug.cgi?id=43918
Broke EFL port build (Requested by acidx on #webkit).
- cmake/WebKitGenerators.cmake:
- cmake/WebKitMacros.cmake:
- 8:04 AM Changeset in webkit [65245] by
-
- 26 edits1 add1 delete in trunk
2010-08-12 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Rolling out r65241 and 65243 for breaking inspector tests.
- 7:38 AM MathML 3 testsuite results edited by
- (diff)
- 7:20 AM MathML 3 testsuite results edited by
- (diff)
- 7:11 AM MathML 3 testsuite results edited by
- (diff)
- 7:01 AM MathML 3 testsuite results edited by
- (diff)
- 6:40 AM Changeset in webkit [65244] by
-
- 2 edits3 adds in trunk/LayoutTests
2010-08-12 Nate Chapin <Nate Chapin>
Update chromium's test_expectations.txt and provide new baselines for
http://trac.webkit.org/changeset/65229.
(Text-only baseline for win/linux because there are real regressions in the
image results. See https://bugs.webkit.org/show_bug.cgi?id=43912)
- platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.checksum: Added.
- platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
- platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 6:38 AM Changeset in webkit [65243] by
-
- 1 edit1 add in trunk/WebCore
2010-08-12 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Adding the file missing in r65241.
- inspector/front-end/RemoteObject.js: Added. (WebInspector.RemoteObjectId): (WebInspector.RemoteObject): (WebInspector.RemoteObject.fromPrimitiveValue): (WebInspector.RemoteObject.fromNode): (WebInspector.RemoteObject.fromPayload): (WebInspector.RemoteObject.type): (WebInspector.RemoteObject.prototype.get objectId): (WebInspector.RemoteObject.prototype.get type): (WebInspector.RemoteObject.prototype.get description): (WebInspector.RemoteObject.prototype.get hasChildren): (WebInspector.RemoteObject.prototype.isError): (WebInspector.RemoteObject.prototype.getPropertyValueDescriptions): (WebInspector.RemoteObject.prototype.getOwnProperties):
- 6:37 AM Changeset in webkit [65242] by
-
- 2 edits in trunk/JavaScriptCore
The scratch register should be saved in YARR with ARM JIT
https://bugs.webkit.org/show_bug.cgi?id=43910
Reviewed by Simon Hausmann.
Reported by Jocelyn Turcotte.
- yarr/RegexJIT.cpp:
(JSC::Yarr::RegexGenerator::generateEnter):
(JSC::Yarr::RegexGenerator::generateReturn):
- 6:31 AM Changeset in webkit [65241] by
-
- 26 edits1 delete in trunk
2010-08-12 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: brush up object proxies, introduce remote object model.
https://bugs.webkit.org/show_bug.cgi?id=43847
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/AuditRules.js: (WebInspector.AuditRules.CssInHeadRule.prototype.doRun): (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun):
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.doEvalInWindow): (WebInspector.ConsoleView.prototype._enterKeyPressed.printResult): (WebInspector.ConsoleView.prototype._enterKeyPressed): (WebInspector.ConsoleView.prototype._format): (WebInspector.ConsoleView.prototype._formatnode): (WebInspector.ConsoleView.prototype._formatarray): (WebInspector.ConsoleView.prototype._formatAsArrayEntry): (WebInspector.ConsoleMessage.prototype._format): (WebInspector.ConsoleCommandResult):
- inspector/front-end/DOMAgent.js: (WebInspector.DOMNode):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
- inspector/front-end/EventListenersSidebarPane.js:
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor): (injectedScriptConstructor.):
- inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertiesSection.prototype.update): (WebInspector.ObjectPropertiesSection.prototype.updateProperties): (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): (WebInspector.ObjectPropertyTreeElement.prototype.update): (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression):
- inspector/front-end/ObjectProxy.js: Removed.
- inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.callback):
- inspector/front-end/RemoteObject.js: Added. (WebInspector.RemoteObjectId): (WebInspector.RemoteObject): (WebInspector.RemoteObject.fromPrimitiveValue): (WebInspector.RemoteObject.fromErrorMessage): (WebInspector.RemoteObject.fromNode): (WebInspector.RemoteObject.fromPayload): (WebInspector.RemoteObject.type): (WebInspector.RemoteObject.prototype.get objectId): (WebInspector.RemoteObject.prototype.get type): (WebInspector.RemoteObject.prototype.get description): (WebInspector.RemoteObject.prototype.get hasChildren): (WebInspector.RemoteObject.prototype.isError): (WebInspector.RemoteObject.prototype.getPropertyValueDescriptions): (WebInspector.RemoteObject.prototype.getOwnProperties): (WebInspector.RemoteObject.prototype.getProperties.remoteObjectBinder): (WebInspector.RemoteObjectProperty):
- inspector/front-end/ScopeChainSidebarPane.js: (WebInspector.ScopeChainSidebarPane.prototype.update):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame.updatingCallbackWrapper): (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame): (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._showPopup.evaluateCallback): (WebInspector.SourceFrame.prototype._showPopup): (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):
- inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update): (WebInspector.WatchExpressionTreeElement.prototype.update):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector.log.logMessage): (WebInspector.log):
- inspector/front-end/utilities.js:
2010-08-12 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: brush up object proxies, introduce remote object model.
https://bugs.webkit.org/show_bug.cgi?id=43847
- inspector/console-dir-expected.txt:
- inspector/console-dir-global.html:
- inspector/console-dir.html:
- inspector/console-format-collections-expected.txt:
- inspector/console-format-expected.txt:
- 6:30 AM MathML 3 testsuite results edited by
- (diff)
- 6:27 AM Changeset in webkit [65240] by
-
- 2 edits in trunk/WebCore
2010-08-12 Ben Murdoch <benm@google.com>
Reviewed by Steve Block.
V8 code generator does not add V8BindingMacros.h include in all places it is needed
https://bugs.webkit.org/show_bug.cgi?id=43907
Adds the V8BindingMacros.h header before using the STRING_TO_V8PARAMETER_EXCEPTION_BLOCK
macro.
Build fix so no new tests.
- bindings/scripts/CodeGeneratorV8.pm: include the header at the right time.
- 6:23 AM MathML 3 testsuite results edited by
- (diff)
- 6:09 AM Changeset in webkit [65239] by
-
- 1 edit1 add in trunk/LayoutTests
2010-08-12 Philippe Normand <pnormand@igalia.com>
Unreviewed.
Media test baseline forgotten in r65224.
- platform/gtk/media/audio-no-installed-engines-expected.txt: Added.
- 6:04 AM MathML 3 testsuite results edited by
- (diff)
- 5:47 AM MathML 3 testsuite results edited by
- (diff)
- 5:37 AM MathML 3 testsuite results edited by
- (diff)
- 5:36 AM Changeset in webkit [65238] by
-
- 3 edits in trunk/WebKit/chromium
2010-08-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r65181.
http://trac.webkit.org/changeset/65181
https://bugs.webkit.org/show_bug.cgi?id=43909
It broke 35 layout tests fail on chromium-win (Requested by
hamaji on #webkit).
- public/WebFrameClient.h:
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::detachedFromParent3):
- 5:31 AM MathML 3 testsuite results edited by
- (diff)
- 5:04 AM Changeset in webkit [65237] by
-
- 2 edits in trunk/LayoutTests
2010-08-12 Shinichiro Hamaji <hamaji@chromium.org>
Update chromium's test_expectations.txt
- platform/chromium/test_expectations.txt: Two failing video related tests.
- 5:00 AM Changeset in webkit [65236] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt] animations/suspend-resume-animation.html fails
https://bugs.webkit.org/show_bug.cgi?id=43905
- platform/qt/Skipped: animations/suspend-resume-animation.html skipped until fix.
- 4:52 AM Changeset in webkit [65235] by
-
- 2 edits in trunk/LayoutTests
2010-08-12 Shinichiro Hamaji <hamaji@chromium.org>
Update chromium's test_expectations.txt
- platform/chromium/test_expectations.txt: animations/play-state is flaky on Mac
- 4:44 AM MathML 3 testsuite results edited by
- (diff)
- 4:37 AM MathML 3 testsuite results edited by
- (diff)
- 4:10 AM Changeset in webkit [65234] by
-
- 19 edits2 deletes in trunk
2010-08-12 Jeremy Orlow <jorlow@chromium.org>
Revert for now
https://bugs.webkit.org/show_bug.cgi?id=43794
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- page/GroupSettings.cpp: Removed.
- page/GroupSettings.h: Removed.
- page/PageGroup.cpp: (WebCore::PageGroup::PageGroup): (WebCore::PageGroup::localStorage):
- page/PageGroup.h:
- page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setLocalStorageQuota): (WebCore::Settings::setLocalStorageDatabasePath):
- page/Settings.h: (WebCore::Settings::localStorageQuota): (WebCore::Settings::localStorageDatabasePath):
2010-08-12 Jeremy Orlow <jorlow@chromium.org>
Revert for now
https://bugs.webkit.org/show_bug.cgi?id=43794
- WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): (-[WebView _preferencesChangedNotification:]):
2010-08-12 Jeremy Orlow <jorlow@chromium.org>
Revert for now
https://bugs.webkit.org/show_bug.cgi?id=43794
- Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):
2010-08-12 Jeremy Orlow <jorlow@chromium.org>
Revert for now
https://bugs.webkit.org/show_bug.cgi?id=43794
- WebView.cpp: (WebView::initWithFrame):
- 3:37 AM Changeset in webkit [65233] by
-
- 1 edit1 delete in trunk/LayoutTests
2010-08-12 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Delete a test that slipped in by accident.
- svg/zoom/page/zoom-mask.svg: Removed.
- 3:30 AM Changeset in webkit [65232] by
-
- 5 edits in trunk/WebCore
2010-08-12 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Follow up to Jeremys fix, just remove the context parameter, it's not needed anymore.
- rendering/RenderSVGResourceGradient.cpp: (WebCore::createMaskAndSwapContextForTextGradient):
- rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::applyResource):
- rendering/SVGImageBufferTools.cpp: (WebCore::SVGImageBufferTools::createImageBuffer):
- rendering/SVGImageBufferTools.h:
- 3:27 AM Changeset in webkit [65231] by
-
- 2 edits in trunk/WebCore
2010-08-12 Jeremy Orlow <jorlow@chromium.org>
Build fix.
- rendering/SVGImageBufferTools.cpp: (WebCore::SVGImageBufferTools::createImageBuffer):
- 3:21 AM Changeset in webkit [65230] by
-
- 2 edits in trunk/WebKit/win
2010-08-12 Jeremy Orlow <jorlow@chromium.org>
Build fix. Matches solutions in qt and mac ports for
https://bugs.webkit.org/show_bug.cgi?id=43794
- WebView.cpp: (WebView::initWithFrame):
- 3:11 AM Changeset in webkit [65229] by
-
- 18 edits7 adds in trunk
2010-08-12 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
SVG masking performance very slow
https://bugs.webkit.org/show_bug.cgi?id=43622
Create ImageBuffers only as large as the final rendered size on screen. Only gradient on text on CG handled this correctly so far.
Refactored the code into a new SVGImageBufferTools class, and use the code from RenderSVGResourceMasker -> makes the IE9 demo SVG dice usable.
Clippers, Patterns and Filters remain to be converted.
Test: svg/zoom/page/zoom-mask-with-percentages.svg
- Android.mk: Add SVGImageBufferTools.* to build.
- CMakeLists.txt: Ditto.
- GNUmakefile.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- rendering/RenderSVGAllInOne.cpp: Ditto.
- rendering/RenderSVGResourceGradient.cpp: Refactored CG gradient specific "create image buffer in absolute coordinates" code into SVGImageBufferTools class. (WebCore::createMaskAndSwapContextForTextGradient): (WebCore::clipToTextMask): (WebCore::RenderSVGResourceGradient::applyResource):
- rendering/RenderSVGResourceMasker.cpp: Use new SVGImageBufferTools class, to avoid pixelation when zooming and to create image buffers as big as the final rendered size on screen, not more. (WebCore::RenderSVGResourceMasker::invalidateClients): (WebCore::RenderSVGResourceMasker::applyResource): (WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage): (WebCore::RenderSVGResourceMasker::calculateMaskContentRepaintRect): (WebCore::RenderSVGResourceMasker::resourceBoundingBox):
- rendering/RenderSVGResourceMasker.h:
- rendering/SVGImageBufferTools.cpp: Added. (WebCore::SVGImageBufferTools::absoluteTransformFromContext): (WebCore::SVGImageBufferTools::createImageBuffer): (WebCore::SVGImageBufferTools::clipToImageBuffer):
- rendering/SVGImageBufferTools.h: Added. (WebCore::SVGImageBufferTools::SVGImageBufferTools): (WebCore::SVGImageBufferTools::~SVGImageBufferTools):
2010-08-12 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
SVG masking performance very slow
https://bugs.webkit.org/show_bug.cgi?id=43622
Update mask results, now that mask image buffers are as big as the finaled rendered size on screen.
Add new test covering zooming into masks, to show that it doesn't pixelate anymore.
- platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
- platform/mac/svg/batik/masking/maskRegions-expected.checksum:
- platform/mac/svg/batik/masking/maskRegions-expected.png:
- platform/mac/svg/custom/grayscale-gradient-mask-expected.checksum:
- platform/mac/svg/custom/grayscale-gradient-mask-expected.png:
- platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.checksum: Added.
- platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
- platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Added.
- svg/zoom/page/zoom-mask-with-percentages.svg: Added.
- 3:03 AM Changeset in webkit [65228] by
-
- 17 edits2 adds in trunk
2010-08-10 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Adam Barth.
Some settings are linked to the PageGroup not the Page. Create a new class for those.
https://bugs.webkit.org/show_bug.cgi?id=43794
Since persistient storage is shared between pages, there's no way to modify
some settings related to it on a per page basis. As such, it's not technically
correct for these settings to be on the Page's settings. Create a new class
called GroupSettings, move the 2 group-wide local storage settings there, and
add a new setting for IndexedDB's path (which is prompting this change).
No behavior has changed, so no tests.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- page/PageGroup.cpp: (WebCore::PageGroup::PageGroup): (WebCore::PageGroup::localStorage):
- page/PageGroup.h: (WebCore::PageGroup::groupSettings):
- page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setSessionStorageQuota):
- page/Settings.h:
2010-08-10 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Adam Barth.
Some settings are linked to the PageGroup not the Page. Create a new class for those.
https://bugs.webkit.org/show_bug.cgi?id=43794
Change WebView to use the new GroupSettings class rather than Settings for the
settings that moved. This is sub-optimal since the settings aren't really
per-view, but we can't really change the API at this point.
- WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): (-[WebView _preferencesChangedNotification:]):
2010-08-11 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Adam Barth.
Some settings are linked to the PageGroup not the Page. Create a new class for those.
https://bugs.webkit.org/show_bug.cgi?id=43794
Change WebSettings to use the new GroupSettings class rather than Settings for the
settings that moved. This is sub-optimal since the settings aren't really
per-view, but I don't see how we can change the API at this point.
- Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):
- 2:43 AM Changeset in webkit [65227] by
-
- 2 edits in trunk/WebCore
[Qt] Decode images directly to QPixmap
https://bugs.webkit.org/show_bug.cgi?id=40797
Patch by Benjamin Poulain <benjamin.poulain@nokia.com> on 2010-08-12
Reviewed by Simon Hausmann.
Use the new API of Qt 4.7 to decode data from the image
reader directly to QPixmap.
This allow us to use JDCT_IFAST when decoding jpeg images
to pixmap, and to decode animated GIF images, while still
using in-place conversion of color space.
- platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::setData):
(WebCore::ImageDecoderQt::internalHandleCurrentImage):
- 2:41 AM Changeset in webkit [65226] by
-
- 12 edits in trunk
2010-07-14 Marcus Bulach <bulach@chromium.org>
Reviewed by Darin Adler.
Removes DontCheckEnums from some IDLs and fixes the corresponding enums.
https://bugs.webkit.org/show_bug.cgi?id=42278
This is a follow-up to https://bugs.webkit.org/show_bug.cgi?id=42250: it fixes some IDL/.h and enables generating compile-time checks for enums.
- fast/events/init-events-expected.txt:
- fast/events/script-tests/init-events.js: (createEventHelper): splits event creation so that we can test without init. (testInitEvent): adds test for OverflowEvent creation.
2010-07-14 Marcus Bulach <bulach@chromium.org>
Reviewed by Darin Adler.
Removes DontCheckEnums from some IDLs and fixes the corresponding enums.
https://bugs.webkit.org/show_bug.cgi?id=42278
This is a follow-up to https://bugs.webkit.org/show_bug.cgi?id=42250: it fixes some IDL/.h and enables generating compile-time checks for enums.
Tests: idls should generate valid code.
- dom/Node.h: (WebCore::Node::):
- dom/Node.idl:
- dom/OverflowEvent.h: (WebCore::OverflowEvent::):
- dom/OverflowEvent.idl:
- html/FileReader.cpp: (WebCore::FileReader::readyState):
- html/FileReader.h: (WebCore::FileReader::):
- html/FileReader.idl:
- 1:50 AM Changeset in webkit [65225] by
-
- 3 edits in trunk
2010-08-12 Patrick Gansterer <paroga@paroga.com>
Reviewed by Nikolas Zimmermann.
[CMake] Cleanup generator code.
https://bugs.webkit.org/show_bug.cgi?id=39164
- cmake/WebKitGenerators.cmake:
- cmake/WebKitMacros.cmake:
- 1:24 AM Changeset in webkit [65224] by
-
- 2 edits8 adds in trunk/LayoutTests
2010-08-12 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GTK] new media tests baselines needed
https://bugs.webkit.org/show_bug.cgi?id=42444
Visually check those tests, they seemed fine to me so I added
their baselines.
- platform/gtk/Skipped:
- platform/gtk/media/audio-controls-rendering-expected.txt: Added.
- platform/gtk/media/video-display-toggle-expected.txt: Added.
- platform/gtk/media/video-empty-source-expected.txt: Added.
- platform/gtk/media/video-layer-crash-expected.txt: Added.
- platform/gtk/media/video-no-audio-expected.txt: Added.
- platform/gtk/media/video-transformed-expected.txt: Added.
- platform/gtk/media/video-zoom-controls-expected.txt: Added.
- platform/gtk/media/video-zoom-expected.txt: Added.
- 1:06 AM Changeset in webkit [65223] by
-
- 2 edits in trunk/WebCore
2010-08-12 Alejandro G. Castro <alex@igalia.com>
Reviewed by David Levin.
The #if clause enabling a feature should avoid the all includes of
the feature
https://bugs.webkit.org/show_bug.cgi?id=43866
Modified the position of the guard to avoid including all the
headers if the feature controlling the guard is not enabled.
- dom/make_names.pl:
- 12:18 AM Changeset in webkit [65222] by
-
- 8 edits in trunk
2010-08-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r65221.
http://trac.webkit.org/changeset/65221
https://bugs.webkit.org/show_bug.cgi?id=43896
Broke snow leopard build. (Requested by dave_levin on
#webkit).
- platform/graphics/GraphicsContext3D.cpp:
- platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::):
2010-08-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r65221.
http://trac.webkit.org/changeset/65221
https://bugs.webkit.org/show_bug.cgi?id=43896
Broke snow leopard build. (Requested by dave_levin on
#webkit).
- public/WebGraphicsContext3D.h:
- src/GraphicsContext3D.cpp:
- src/WebGraphicsContext3DDefaultImpl.cpp:
- src/WebGraphicsContext3DDefaultImpl.h:
- 12:00 AM Changeset in webkit [65221] by
-
- 8 edits in trunk
2010-08-11 Stephen White <senorblanco@chromium.org>
Reviewed by David Levin.
Add support for BGRA pixel format to GraphicsContext3D.
https://bugs.webkit.org/show_bug.cgi?id=43858
Although this has been standard in desktop GL since 1.2, it's an
extension in GL ES 2.0, so a query function is provided to check
for support. Since they differ on semantics (GL ES 2.0 requires
TexImage2D()'s format and internalFormat to match, while desktop GL
will not accept BGRA as an internalFormat), the stub implementation
returns false until these quirks have been implemented and tested on
each port.
- platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::supportsBGRA): Add implementation for non-chromium platforms which returns false.
- platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::): Add query function (supportsBGRA()) and the BGRA_EXT token.
2010-08-11 Stephen White <senorblanco@chromium.org>
Reviewed by David Levin.
Add support for BGRA pixel format to GraphicsContext3D.
https://bugs.webkit.org/show_bug.cgi?id=43858
Although this has been standard in desktop GL since 1.2, it's an
extension in GL ES 2.0, so a query function is provided to check
for support. The DefaultImpl returns false, since it does not yet
implement the TexImage2D internalFormat quirks.
- public/WebGraphicsContext3D.h: (WebKit::WebGraphicsContext3D::supportsBGRA):
- src/GraphicsContext3D.cpp:
- src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::supportsBGRA):
- src/WebGraphicsContext3DDefaultImpl.h:
