Timeline



Oct 11, 2010:

11:17 PM Changeset in webkit [69561] by hamaji@chromium.org
  • 5 edits in trunk/WebKit/win

2010-10-11 Shinichiro Hamaji <hamaji@chromium.org>

Attempt to fix windows build failure.

Remove WebIconFetcher from WebKit and IconFetcher from WebCore
https://bugs.webkit.org/show_bug.cgi?id=47523

  • Interfaces/IWebFramePrivate.idl: s/unused1/unused2/
  • Interfaces/WebKit.idl: Touched.
  • WebFrame.cpp: s/unused1/unused2/ (WebFrame::unused2):
  • WebFrame.h: s/unused1/unused2/
9:08 PM Changeset in webkit [69560] by dumi@chromium.org
  • 5 edits
    2 adds in trunk

2010-10-11 Eric Uhrhane <ericu@chromium.org>

Reviewed by Dumitru Daniliuc.

FileWriter should hold a reference to a Blob during write
https://bugs.webkit.org/show_bug.cgi?id=47318

Without this reference, the Blob might get garbage-collected from JS
before the write has completed, which would be quite unintuitive to the
user. I just grab a RefPtr to the Blob at write(), then clear it when
we're done.

  • fileapi/FileWriter.cpp: (WebCore::FileWriter::stop): (WebCore::FileWriter::write): (WebCore::FileWriter::didWrite): (WebCore::FileWriter::didFail):
  • fileapi/FileWriter.h:

2010-10-11 Eric Uhrhane <ericu@chromium.org>

Reviewed by Dumitru Daniliuc.

FileWriter should hold a reference to a Blob during write
https://bugs.webkit.org/show_bug.cgi?id=47318

Added the first FileWriter test to cover this.
Problem #1: it's not a deterministic problem; the test might or might
not catch the error, but at least it won't ever trigger a false
positive.
Problem #2: no platform fully implements FileWriter yet, so this test
must start out completely supressed. All non-chromium platforms
already skip all filesystem tests, so I'm only adding a suppression in
chromium.

  • fast/filesystem/file-writer-gc-blob-expected.txt: Added.
  • fast/filesystem/file-writer-gc-blob.html: Added.
  • platform/chromium/test_expectations.txt:
7:42 PM Changeset in webkit [69559] by beidson@apple.com
  • 5 edits in trunk/WebKit2

Address some of Darin's review feedback in https://bugs.webkit.org/show_bug.cgi?id=47354
that wasn't left till after my original commit.

Reviewed by Darin Adler of the past.

  • UIProcess/API/C/WKPage.cpp:

(WKPageCopySessionState): Nuke the temporary variable.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.h: Fix up function declarations.


  • UIProcess/cf/WebPageProxyCF.cpp:

(WebKit::WebPageProxy::sessionStateData): Use sizeof(UInt32) instead of 4.
(WebKit::WebPageProxy::restoreFromSessionStateData): Ditto.

7:41 PM Changeset in webkit [69558] by Martin Robinson
  • 8 edits in trunk/LayoutTests

2010-10-11 Martin Robinson <mrobinson@igalia.com>

Rebaseline some failing GTK+ tests.

  • platform/gtk/editing/selection/move-past-trailing-space-expected.txt:
  • platform/gtk/fast/css/shadow-multiple-expected.txt:
  • platform/gtk/fast/text/shadow-no-blur-expected.txt:
7:25 PM Changeset in webkit [69557] by kinuko@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-11 Kinuko Yasuda <kinuko@chromium.org>

Unreviewed, updating test_expectations.txt for passing tests.

  • platform/chromium/test_expectations.txt:
7:19 PM Changeset in webkit [69556] by beidson@apple.com
  • 2 edits in trunk/WebKit2

Build fix for Windows in https://bugs.webkit.org/show_bug.cgi?id=47354

Reviewed by BUILD FIX.

  • UIProcess/cf/WebPageProxyCF.cpp:

(WebKit::WebPageProxy::sessionStateData): Change to use CF APIs that exist on Windows.
(WebKit::WebPageProxy::restoreFromSessionStateData): Ditto.

7:18 PM Changeset in webkit [69555] by ajwong@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed. More expectation changes for green canary.

More expectations resulting from r69517.

  • platform/chromium/test_expectations.txt:
7:17 PM Changeset in webkit [69554] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2010-10-11 James Kozianski <koz@chromium.org>

Reviewed by Simon Fraser.

Remove superflous comments from a layout test.
https://bugs.webkit.org/show_bug.cgi?id=47521

  • fast/css-generated-content/malformed-url.html:
7:12 PM Changeset in webkit [69553] by msaboff@apple.com
  • 18 edits
    2 adds in trunk

2010-10-11 Michael Saboff <msaboff@apple.com>

Reviewed by Darin Adler.

Added and changed tests to verify that DOMWindow objects are
create with appropriate constructors and that those constructors
are not callable directly.
https://bugs.webkit.org/show_bug.cgi?id=47422

  • fast/dom/Window/window-constructor-expected.txt: Added.
  • fast/dom/Window/window-constructor.html: Added.
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/script-tests/constructors-cached.js:
  • fast/dom/wrapper-classes-expected.txt:
  • http/tests/security/cross-frame-access-get-expected.txt:
  • http/tests/security/cross-frame-access-get.html:
  • http/tests/security/cross-frame-access-put.html:
  • inspector/console-dir-global-expected.txt:
  • java/lc3/JSObject/ToJSObject-001-expected.txt:
  • java/lc3/JSObject/ToObject-001-expected.txt:

2010-10-11 Michael Saboff <msaboff@apple.com>

Reviewed by Darin Adler.

Changed DOMWindow to have a constructor. Updated the code generator
to add security checks to the constructors if CheckDomainSecurity is
set. Also changed the constructor generation code to use
globalObject->prototype() for DOMWindow object prototypes instead
of "self".
https://bugs.webkit.org/show_bug.cgi?id=47422

Test: fast/dom/Window/window-constructor.html

  • bindings/scripts/CodeGeneratorJS.pm:
  • page/DOMWindow.idl:
7:04 PM Changeset in webkit [69552] by tony@chromium.org
  • 2 edits in trunk/WebKitTools

2010-10-11 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

change the order of mrobinson's email addresses so bugs.webkit.org suggests the right one
https://bugs.webkit.org/show_bug.cgi?id=47513

bugs.webkit.org suggests mrobinson@igalia.com as an autocomplete,
which doesn't actually work.

  • Scripts/webkitpy/common/config/committers.py:
6:52 PM Changeset in webkit [69551] by commit-queue@webkit.org
  • 15 edits
    2 copies in trunk

2010-10-11 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Prepare Clipboard/DragData for transition to new drag-and-drop interface.
https://bugs.webkit.org/show_bug.cgi?id=44992

In order to allow a graceful transition, ChromiumDataObject has been
reimplemented as a wrapper around the three different types of data
objects that the Chrome port uses:

  1. ChromiumDataObjectLegacy -- this is the original ChromiumDataObject. All the data that ClipboardChromium/DragDataChromium can potentially use is copied over, regardless of whether or not it is needed.
  2. ReadableDataObject -- used for dragging in and pasting into WebKit. For efficiency, it caches an optimistic list of types it believes it can handle. When getData() is called, a browser IPC is called to retrieve the appropriate data.
  3. WritableDataObject -- similar to ChromiumDataObjectLegacy in that it buffers all data when dragging out of WebKit or copying/cutting. Unfortunately, there is a difference between dragging out and copying/cutting--on drag outs, the data is buffered and flushed out when startDrag() is called. For copy/cut, any calls to setData() result in a browser IPC right away, so calls to setData() in one copy/cut event are not atomic.

Copy and paste has been changed to use the new data objects. Dragging
out uses the legacy data object, and dragging in now has two potential
entry points--one using the legacy data object, and one using
ReadableDataObject. Once Chromium transitions to using the new drag-in
interface, the old interface will be removed.

This change is covered by existing tests.

  • WebCore.gypi:
  • editing/chromium/EditorChromium.cpp: (WebCore::Editor::newGeneralClipboard):
  • page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::createDraggingClipboard):
  • platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::ChromiumDataObject): (WebCore::ChromiumDataObject::create): (WebCore::ChromiumDataObject::createReadable): (WebCore::ChromiumDataObject::createWritable): (WebCore::ChromiumDataObject::clearData): (WebCore::ChromiumDataObject::clearAll): (WebCore::ChromiumDataObject::clearAllExceptFiles): (WebCore::ChromiumDataObject::hasData): (WebCore::ChromiumDataObject::types): (WebCore::ChromiumDataObject::getData): (WebCore::ChromiumDataObject::setData): (WebCore::ChromiumDataObject::urlTitle): (WebCore::ChromiumDataObject::setUrlTitle): (WebCore::ChromiumDataObject::htmlBaseUrl): (WebCore::ChromiumDataObject::setHtmlBaseUrl): (WebCore::ChromiumDataObject::containsFilenames): (WebCore::ChromiumDataObject::filenames): (WebCore::ChromiumDataObject::setFilenames): (WebCore::ChromiumDataObject::fileExtension): (WebCore::ChromiumDataObject::setFileExtension): (WebCore::ChromiumDataObject::fileContentFilename): (WebCore::ChromiumDataObject::setFileContentFilename): (WebCore::ChromiumDataObject::fileContent): (WebCore::ChromiumDataObject::setFileContent):
  • platform/chromium/ChromiumDataObject.h:
  • platform/chromium/ChromiumDataObjectLegacy.cpp: Copied from ChromiumDataObject.cpp (WebCore::ChromiumDataObjectLegacy::clearData): (WebCore::ChromiumDataObjectLegacy::clearAll): (WebCore::ChromiumDataObjectLegacy::clearAllExceptFiles): (WebCore::ChromiumDataObjectLegacy::hasData): (WebCore::ChromiumDataObjectLegacy::types): (WebCore::ChromiumDataObjectLegacy::getData): (WebCore::ChromiumDataObjectLegacy::setData): (WebCore::ChromiumDataObjectLegacy::ChromiumDataObjectLegacy):
  • platform/chromium/ChromiumDataObjectLegacy.h: Copied from ChromiumDataObject.h (WebCore::ChromiumDataObjectLegacy::create): (WebCore::ChromiumDataObjectLegacy::copy): (WebCore::ChromiumDataObjectLegacy::urlTitle): (WebCore::ChromiumDataObjectLegacy::setUrlTitle): (WebCore::ChromiumDataObjectLegacy::htmlBaseUrl): (WebCore::ChromiumDataObjectLegacy::setHtmlBaseUrl): (WebCore::ChromiumDataObjectLegacy::containsFilenames): (WebCore::ChromiumDataObjectLegacy::filenames): (WebCore::ChromiumDataObjectLegacy::setFilenames): (WebCore::ChromiumDataObjectLegacy::fileExtension): (WebCore::ChromiumDataObjectLegacy::setFileExtension): (WebCore::ChromiumDataObjectLegacy::fileContentFilename): (WebCore::ChromiumDataObjectLegacy::setFileContentFilename): (WebCore::ChromiumDataObjectLegacy::fileContent): (WebCore::ChromiumDataObjectLegacy::setFileContent):
  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::create):
  • platform/chromium/ClipboardChromium.h:
  • platform/chromium/ReadableDataObject.cpp: (WebCore::ReadableDataObject::getData):
  • platform/chromium/WritableDataObject.cpp: (WebCore::WritableDataObject::setData):

2010-10-11 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Prepare Clipboard/DragData for transition to new drag-and-drop interface.
https://bugs.webkit.org/show_bug.cgi?id=44992

Add a new entry point for drag in to allow a graceful transition
from the legacy drag and drop model, where all data is copied in at the
beginning of a drag, to a model where data is retrieved on demand via
IPCs. The rationale for this is when we begin supporting arbitrary MIME
types in dataTransfer, we don't want to be copying aribtrary amounts of
data over for each start drag IPC.

  • public/WebView.h:
  • src/WebDragData.cpp: (WebKit::WebDragData::initialize): Use the legacy data object. (WebKit::WebDragData::ensureMutable): Change the if to an ASSERT.
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::dragTargetDragEnterNew): New entry point.
  • src/WebViewImpl.h:
6:39 PM Changeset in webkit [69550] by commit-queue@webkit.org
  • 5 edits in trunk

2010-10-11 Prasad Tammana <prasadt@chromium.org>

Reviewed by Dmitry Titov.

Added support for showModalDialog on chromium port.

Implement showModalDialog for Layout tests for chromium port
https://bugs.webkit.org/show_bug.cgi?id=46759

  • platform/chromium/drt_expectations.txt: Removed show-modal-dialog tests.

2010-10-11 Prasad Tammana <prasadt@chromium.org>

Reviewed by Dmitry Titov.

Added support for showModalDialog on chromium port.

Implement showModalDialog for Layout tests for chromium port
https://bugs.webkit.org/show_bug.cgi?id=46759

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::closeWidgetSoon): Quit current message loop if in a modal loop. (WebViewHost::runModal): Start a nested message loop and remember that. (WebViewHost::WebViewHost): Initialize m_inModalLoop.
  • DumpRenderTree/chromium/WebViewHost.h: Add m_inModalLoop.
6:31 PM Changeset in webkit [69549] by andersca@apple.com
  • 19 edits
    8 deletes in trunk

Remove WebIconFetcher from WebKit and IconFetcher from WebCore
https://bugs.webkit.org/show_bug.cgi?id=47523

Reviewed by Darin Adler.

WebCore:

Remove all traces of the WebCore IconFetcher class. It's SPI that nobody uses.

  • GNUmakefile.am:
  • WebCore.exp.in:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/icon/IconFetcher.cpp: Removed.
  • loader/icon/IconFetcher.h: Removed.

WebKit:

Remove all traces of the WebKit WebIconFetcher class. It's SPI that nobody uses.

  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

Remove all traces of the WebKit WebIconFetcher class. It's SPI that nobody uses.

  • Misc/WebIconFetcher.h: Removed.
  • Misc/WebIconFetcher.mm: Removed.
  • Misc/WebIconFetcherInternal.h: Removed.
  • WebView/WebFrame.mm:
  • WebView/WebFramePrivate.h:

WebKit/win:

Remove all traces of the WebKit WebIconFetcher class. It's SPI that nobody uses.

  • Interfaces/IWebFramePrivate.idl:
  • Interfaces/IWebIconFetcher.idl: Removed.
  • Interfaces/WebKit.idl:
  • WebFrame.cpp:

(WebFrame::unused1):

  • WebFrame.h:
  • WebIconFetcher.cpp: Removed.
  • WebIconFetcher.h: Removed.
  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKit.vcproj:
6:21 PM Changeset in webkit [69548] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-10-11 Jia Pu <jpu@apple.com>

Reviewed by Adele Peterson.

Should commit pending autocorrection before next round of text checking.
https://bugs.webkit.org/show_bug.cgi?id=46986
<rdar://problem/8424535>

  1. Apply pending autocorrection before calling markAllMisspellingsAndBadGrammarInRanges().
  2. Remove unneccessary calls to dismissCorrectionPanel(), since the panel is dismissed when selection changes, which occurs after every typing command.
  • editing/Editor.cpp: (WebCore::Editor::markMisspellingsAfterTypingToPosition): Apply pending autocorrection. (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Store current correction replacement in m_correctionReplacementString. (WebCore::Editor::startCorrectionPanelTimer): Remove call to dismissCorrectionPanel().
  • editing/Editor.h: Add m_correctionReplacementString to store proposed autocorrection string.
6:05 PM Changeset in webkit [69547] by ajwong@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed. Build fix.

Marking linux expectations as failues missed during the SVG sweep.

  • platform/chromium/test_expectations.txt:
5:58 PM Changeset in webkit [69546] by oliver@apple.com
  • 2 edits in trunk/WebCore

2010-10-11 Oliver Hunt <oliver@apple.com>

Reviewed by Adam Barth.

Make fast/canvas/webgl/glsl-conformance pass again
https://bugs.webkit.org/show_bug.cgi?id=47525

Remove incorrect call to glGetShaderiv, so it is only
called in the case where we don't have our own simulated
log.

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::getShaderInfoLog):
5:53 PM Changeset in webkit [69545] by weinig@apple.com
  • 7 edits in trunk

WebCore: Add WebKit2 equivalents for setValueForUser and setAutoFilled
<rdar://problem/8475934>
https://bugs.webkit.org/show_bug.cgi?id=47524

Reviewed by Anders Carlsson.

  • WebCore.exp.in: Add needed export.

WebKit2: Add WebKit2 equivalents for setValueForUser and setAutofilled
<rdar://problem/8475934>
https://bugs.webkit.org/show_bug.cgi?id=47524

Reviewed by Anders Carlsson.

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:

(WKBundleNodeHandleSetHTMLInputElementValueForUser):
(WKBundleNodeHandleSetHTMLInputElementAutofilled):

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::setHTMLInputElementValueForUser):
(WebKit::InjectedBundleNodeHandle::setHTMLInputElementAutofilled):

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
5:34 PM Changeset in webkit [69544] by bweinstein@apple.com
  • 2 edits in trunk/WebKit2

Windows build fix. Add a needed include.

  • UIProcess/cf/WebPageProxyCF.cpp:
5:33 PM Changeset in webkit [69543] by ajwong@chromium.org
  • 993 edits
    524 adds
    1 delete in trunk/LayoutTests

[chromium] Unreviewed. Build Fix.

Submit 1506 new rebaselines due to changes for all elipse/circle
drawing code caused by r69517. Changelog compressed to list the
number of files changed per directory.

  • LayoutTests/platform/chromium-linux/fast/blockflow/: 2 changed.
  • LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1/: 96 changed.
  • LayoutTests/platform/chromium-linux/svg/batik/paints/: 4 changed.
  • LayoutTests/platform/chromium-linux/svg/batik/text/: 4 changed.
  • LayoutTests/platform/chromium-linux/svg/clip-path/: 34 changed.
  • LayoutTests/platform/chromium-linux/svg/css/: 6 changed.
  • LayoutTests/platform/chromium-linux/svg/custom/: 104 changed.
  • LayoutTests/platform/chromium-linux/svg/dynamic-updates/: 176 changed.
  • LayoutTests/platform/chromium-linux/svg/hixie/cascade/: 4 changed.
  • LayoutTests/platform/chromium-linux/svg/hixie/error/: 2 changed.
  • LayoutTests/platform/chromium-linux/svg/hixie/links/: 4 changed.
  • LayoutTests/platform/chromium-linux/svg/hixie/mixed/: 12 changed.
  • LayoutTests/platform/chromium-linux/svg/hixie/perf/: 2 changed.
  • LayoutTests/platform/chromium-linux/svg/hixie/rendering-model/: 4 changed.
  • LayoutTests/platform/chromium-linux/svg/hixie/shapes/path/: 2 changed.
  • LayoutTests/platform/chromium-linux/svg/hixie/transform/: 2 changed.
  • LayoutTests/platform/chromium-linux/svg/in-html/: 2 changed.
  • LayoutTests/platform/chromium-linux/svg/text/: 4 changed.
  • LayoutTests/platform/chromium-linux/svg/zoom/page/: 6 changed.
  • LayoutTests/platform/chromium-linux/svg/zoom/text/: 4 changed.
  • LayoutTests/platform/chromium-mac/fast/backgrounds/: 6 changed.
  • LayoutTests/platform/chromium-mac/fast/blockflow/: 2 changed.
  • LayoutTests/platform/chromium-mac/fast/images/: 2 changed.
  • LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/: 101 changed.
  • LayoutTests/platform/chromium-mac/svg/batik/masking/: 2 changed.
  • LayoutTests/platform/chromium-mac/svg/batik/paints/: 6 changed.
  • LayoutTests/platform/chromium-mac/svg/batik/text/: 4 changed.
  • LayoutTests/platform/chromium-mac/svg/carto.net/: 2 changed.
  • LayoutTests/platform/chromium-mac/svg/clip-path/: 50 changed.
  • LayoutTests/platform/chromium-mac/svg/css/: 6 changed.
  • LayoutTests/platform/chromium-mac/svg/custom/: 118 changed.
  • LayoutTests/platform/chromium-mac/svg/dynamic-updates/: 184 changed.
  • LayoutTests/platform/chromium-mac/svg/hixie/cascade/: 4 changed.
  • LayoutTests/platform/chromium-mac/svg/hixie/error/: 2 changed.
  • LayoutTests/platform/chromium-mac/svg/hixie/links/: 4 changed.
  • LayoutTests/platform/chromium-mac/svg/hixie/mixed/: 12 changed.
  • LayoutTests/platform/chromium-mac/svg/hixie/perf/: 2 changed.
  • LayoutTests/platform/chromium-mac/svg/hixie/rendering-model/: 4 changed.
  • LayoutTests/platform/chromium-mac/svg/hixie/shapes/path/: 2 changed.
  • LayoutTests/platform/chromium-mac/svg/hixie/transform/: 2 changed.
  • LayoutTests/platform/chromium-mac/svg/in-html/: 2 changed.
  • LayoutTests/platform/chromium-mac/svg/text/: 6 changed.
  • LayoutTests/platform/chromium-mac/svg/zoom/page/: 6 changed.
  • LayoutTests/platform/chromium-mac/svg/zoom/text/: 4 changed.
  • LayoutTests/platform/chromium-win-xp/fast/blockflow/: 1 changed.
  • LayoutTests/platform/chromium-win-xp/svg/batik/text/: 2 changed.
  • LayoutTests/platform/chromium-win-xp/svg/custom/: 1 changed.
  • LayoutTests/platform/chromium-win/fast/blockflow/: 2 changed.
  • LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/: 107 changed.
  • LayoutTests/platform/chromium-win/svg/batik/masking/: 1 changed.
  • LayoutTests/platform/chromium-win/svg/batik/paints/: 4 changed.
  • LayoutTests/platform/chromium-win/svg/batik/text/: 2 changed.
  • LayoutTests/platform/chromium-win/svg/clip-path/: 34 changed.
  • LayoutTests/platform/chromium-win/svg/css/: 6 changed.
  • LayoutTests/platform/chromium-win/svg/custom/: 114 changed.
  • LayoutTests/platform/chromium-win/svg/dynamic-updates/: 176 changed.
  • LayoutTests/platform/chromium-win/svg/hixie/cascade/: 4 changed.
  • LayoutTests/platform/chromium-win/svg/hixie/error/: 2 changed.
  • LayoutTests/platform/chromium-win/svg/hixie/links/: 4 changed.
  • LayoutTests/platform/chromium-win/svg/hixie/mixed/: 12 changed.
  • LayoutTests/platform/chromium-win/svg/hixie/perf/: 2 changed.
  • LayoutTests/platform/chromium-win/svg/hixie/rendering-model/: 4 changed.
  • LayoutTests/platform/chromium-win/svg/hixie/shapes/path/: 2 changed.
  • LayoutTests/platform/chromium-win/svg/hixie/transform/: 2 changed.
  • LayoutTests/platform/chromium-win/svg/in-html/: 2 changed.
  • LayoutTests/platform/chromium-win/svg/text/: 4 changed.
  • LayoutTests/platform/chromium-win/svg/zoom/page/: 7 changed.
  • LayoutTests/platform/chromium-win/svg/zoom/text/: 4 changed.
  • LayoutTests/platform/chromium/: 1 changed.
  • platform/chromium/test_expectations.txt:
5:28 PM Changeset in webkit [69542] by bweinstein@apple.com
  • 3 edits in trunk/WebKit2

Windows build fix. Wrap calls to CFSTR in parentheses.

  • UIProcess/cf/WebBackForwardListCF.cpp:
  • UIProcess/cf/WebPageProxyCF.cpp:
5:19 PM Changeset in webkit [69541] by jorlow@chromium.org
  • 6 edits
    1 add in trunk/WebKit/chromium

2010-10-11 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

[Chromium] Add plumbing for synchronous indexedDB exceptions
https://bugs.webkit.org/show_bug.cgi?id=47511

Add a WebExceptionCode file (already run by fishd) and add versions of
each applicable method that take such a parameter. A follow up patch
will be posted with the meat.

  • WebKit.gyp:
  • public/WebExceptionCode.h: Added.
  • public/WebIDBCursor.h: (WebKit::WebIDBCursor::update): (WebKit::WebIDBCursor::continueFunction): (WebKit::WebIDBCursor::remove):
  • public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::objectStore): (WebKit::WebIDBDatabase::createObjectStore): (WebKit::WebIDBDatabase::removeObjectStore): (WebKit::WebIDBDatabase::setVersion): (WebKit::WebIDBDatabase::transaction):
  • public/WebIDBIndex.h: (WebKit::WebIDBIndex::openObjectCursor): (WebKit::WebIDBIndex::openKeyCursor): (WebKit::WebIDBIndex::getObject): (WebKit::WebIDBIndex::getKey):
  • public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::get): (WebKit::WebIDBObjectStore::put): (WebKit::WebIDBObjectStore::remove): (WebKit::WebIDBObjectStore::createIndex): (WebKit::WebIDBObjectStore::index): (WebKit::WebIDBObjectStore::removeIndex): (WebKit::WebIDBObjectStore::openCursor):
5:16 PM Changeset in webkit [69540] by andreip@google.com
  • 32 edits in trunk

2010-10-11 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

The names of IndexedDB-specific attributes of DOMWindow should be prefixed with 'webkit'.
https://bugs.webkit.org/show_bug.cgi?id=47508

  • storage/indexeddb/basics-expected.txt:
  • storage/indexeddb/basics.html:
  • storage/indexeddb/constants-expected.txt:
  • storage/indexeddb/constants.html:
  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/database-basics.html:
  • storage/indexeddb/database-quota-expected.txt:
  • storage/indexeddb/database-quota.html:
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/index-cursor-expected.txt:
  • storage/indexeddb/index-cursor.html:
  • storage/indexeddb/keyrange-expected.txt:
  • storage/indexeddb/keyrange.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/objectstore-cursor-expected.txt:
  • storage/indexeddb/objectstore-cursor.html:
  • storage/indexeddb/objectstore-removeobjectstore-expected.txt:
  • storage/indexeddb/objectstore-removeobjectstore.html:
  • storage/indexeddb/open-cursor-expected.txt:
  • storage/indexeddb/open-cursor.html:
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-basics.html:

2010-10-11 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

The names of IndexedDB-specific attributes of DOMWindow should be prefixed with 'webkit'.
https://bugs.webkit.org/show_bug.cgi?id=47508

  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setWebkitIndexedDBEnabled): (WebCore::RuntimeEnabledFeatures::webkitIndexedDBEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBCursorEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBDatabaseEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBDatabaseErrorEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBDatabaseExceptionEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBErrorEventEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBEventEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBFactoryEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBIndexEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBKeyRangeEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBObjectStoreEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBRequestEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBSuccessEventEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBTransactionEnabled):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::webkitIndexedDB):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:

2010-10-11 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

The names of IndexedDB-specific attributes of DOMWindow should be prefixed with 'webkit'.
https://bugs.webkit.org/show_bug.cgi?id=47508

  • src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableIndexedDatabase): (WebKit::WebRuntimeFeatures::isIndexedDatabaseEnabled):
5:05 PM Changeset in webkit [69539] by weinig@apple.com
  • 11 edits
    1 add in trunk

Add ability to convert from a JSObjectRef back to a WKBundleNodeHandleRef
https://bugs.webkit.org/show_bug.cgi?id=47509

Reviewed by Anders Carlsson.

WebCore:

  • WebCore.exp.in: Export toNode.

WebKit2:

Add SPI to convert a JSObjectRef to a WKBundleNodeHandleRef.

  • DerivedSources.pro:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:

(WKBundleNodeHandleCreate):

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h: Added.
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::getOrCreate):

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:
5:01 PM Changeset in webkit [69538] by beidson@apple.com
  • 9 edits
    3 adds in trunk/WebKit2

<rdar://problem/8262202> and https://bugs.webkit.org/show_bug.cgi?id=47354
Need WKPage API for serializing and restoring a page's state

Reviewed by Darin Adler and Sam Weinig.

  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • WebKit2Prefix.h: Add DEFINE_STATIC_GETTER convenience.
  • UIProcess/API/C/WKPage.cpp:

(WKPageGetSessionHistoryURLValueType):
(WKPageCopySessionState): Change to use a filter function to allow the API client to decide what

types of things get serialized as session state. For now it only filters based on URL in
session history entries.

(WKPageRestoreFromSessionState):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebBackForwardList.h:

(WebKit::WebBackForwardList::restoredCurrentURL):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::sessionStateData): Leave stubs for non-CF platform builds.
(WebKit::WebPageProxy::restoreFromSessionStateData): Ditto.

  • UIProcess/WebPageProxy.h:
  • UIProcess/cf: Added.
  • UIProcess/cf/WebBackForwardListCF.cpp: Added.

(WebKit::WebBackForwardList::createCFDictionaryRepresentation): Store back/forward list info CF property list style.
(WebKit::WebBackForwardList::restoreFromCFDictionaryRepresentation): Restore from that data - but for now we don't

actually put the back/forward list back into place and instead only remember the current URL.

  • UIProcess/cf/WebPageProxyCF.cpp: Added.

(WebKit::WebPageProxy::sessionStateData): Create the sessions state date CF property list style, plus a version header.
(WebKit::WebPageProxy::restoreFromSessionStateData): Restore from that property list style session state data.

5:01 PM Changeset in webkit [69537] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-10-11 Tony Chang <tony@chromium.org>

Unreviewed, roll chromium DEPS to pick up Dave's fix for
scrollbar painting. This will be needed by an upcoming patch.

  • DEPS:
4:45 PM Changeset in webkit [69536] by abarth@webkit.org
  • 14 edits in trunk/LayoutTests

2010-10-11 Adam Barth <abarth@webkit.org>

Rebaseline SVG expectations.
Rubber-stamped by Mr. kling.

  • platform/mac/svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt:
  • platform/mac/svg/batik/masking/maskRegions-expected.txt:
  • platform/mac/svg/custom/gradient-stroke-width-expected.txt:
  • platform/mac/svg/custom/linking-a-03-b-preserveAspectRatio-expected.txt:
  • platform/mac/svg/custom/linking-a-03-b-transform-expected.txt:
  • platform/mac/svg/custom/linking-a-03-b-viewTarget-expected.txt:
  • platform/mac/svg/custom/linking-a-03-b-zoomAndPan-expected.txt:
  • platform/mac/svg/custom/stroked-pattern-expected.txt:
  • platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
4:30 PM Changeset in webkit [69535] by Patrick Gansterer
  • 2 edits in trunk/JavaScriptCore

2010-10-11 Patrick Gansterer <Patrick Gansterer>

Unreviewed.

Clang build fix after r69472.
https://bugs.webkit.org/show_bug.cgi?id=46523

  • wtf/text/StringHash.h:
3:42 PM Changeset in webkit [69534] by kinuko@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-11 Kinuko Yasuda <kinuko@chromium.org>

Unreviewed, updating test_expectations for a passing test.

  • platform/chromium/test_expectations.txt:
3:16 PM Changeset in webkit [69533] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Undo last minute change to 32bit build.

3:15 PM Changeset in webkit [69532] by Adam Roben
  • 3 edits in trunk/WebKit2

Implement SharedMemory on Windows

This makes visited links be colored correctly.

Fixes <http://webkit.org/b/47499> <rdar://problem/8422725>.

Reviewed by Anders Carlsson.

  • Platform/SharedMemory.h: Add Windows-specific members to

SharedMemory and SharedMemory::Handle.

  • Platform/win/SharedMemoryWin.cpp:

(WebKit::SharedMemory::Handle::Handle): Initialize our members.
(WebKit::SharedMemory::Handle::~Handle): Close our HANDLE if we have
one.
(WebKit::SharedMemory::Handle::encode): Encode our size, HANDLE, and
PID. Null out our HANDLE member, as it is now the receiving process's
responsibility to close the HANDLE.
(WebKit::SharedMemory::Handle::decode): Copy the handle from the
sending process into the receiving process and close the HANDLE the
sending process gave us.
(WebKit::SharedMemory::create): Map some memory and store it in a new
SharedMemory object.
(WebKit::accessRights): Helper function to convert a
SharedMemory::Protection to a file-mapping access right.
(WebKit::SharedMemory::create): Map the memory represented by the
Handle, and adopt the HANDLE from it.
(WebKit::SharedMemory::~SharedMemory): Clean up our memory mapping.
(WebKit::SharedMemory::createHandle): Give the Handle a copy of our
HANDLE with the specified protection.

3:14 PM Changeset in webkit [69531] by Adam Roben
  • 2 edits in trunk/WebKit2

Make it possible to restart a RunLoop::Timer on Windows

Fixes <http://webkit.org/b/47505> RunLoop::Timer only ever fires once
on Windows

Reviewed by Anders Carlsson.

  • Platform/win/RunLoopWin.cpp:

(RunLoop::TimerBase::timerFired): Remove non-repeating timers from the
set of active timers when they fire, just like we do when stopping
them manually.

3:12 PM Changeset in webkit [69530] by Martin Robinson
  • 8 edits in trunk

2010-10-11 Martin Robinson <mrobinson@igalia.com>

Reviewed by Tony Chang.

[GTK] editing/pasteboard/dataTransfer-setData-getData.html fails on GTK+
https://bugs.webkit.org/show_bug.cgi?id=47244

Unskip the freshly passing test and add a baseline which has a PASS for all
tests.

  • platform/gtk/Skipped: Unskip passing test.
  • platform/gtk/editing/pasteboard/dataTransfer-setData-getData-expected.txt:

2010-10-11 Martin Robinson <mrobinson@igalia.com>

Reviewed by Tony Chang.

[GTK] editing/pasteboard/dataTransfer-setData-getData.html fails on GTK+
https://bugs.webkit.org/show_bug.cgi?id=47244

Store the URI list as a String in DataObjectGtk, so that non-URI elements
are preserved when getData(...) is called. This necessitates some other
changes, including adding a m_filenames member to DataObjectGtk to store
filenames extracted during setURIList(...). The logic in getData(...) has
also changed to set success = true no matter what to match the spec. A
followup patch will remove this parameter completely for all platforms.

  • platform/gtk/ClipboardGtk.cpp: (WebCore::ClipboardGtk::getData): Always succeed to match the HTML5 spec and Firefox. Simply return the uriList string from the DataObject instead of reconstructing it from a vector of KURLs. (WebCore::ClipboardGtk::setData): The DataObject now accepts a string for the uriList parameter. (WebCore::ClipboardGtk::types): Predicate the "Files" member on DataObjectGtk::hasFilenames(). (WebCore::ClipboardGtk::files): Update to reflect the change from DataObjectGtk::files() to DataObjectGtk::filenames().
  • platform/gtk/DataObjectGtk.cpp: (WebCore::DataObjectGtk::setURIList): Expanded this setter to find the first valid URL to use as the m_url member and also extract a list of filenames from the URI list. (WebCore::DataObjectGtk::setURL): Updated to reflect changes to m_uriList. (WebCore::DataObjectGtk::clear): Updated to reflect changes to m_uriList and also leave a comment explaining why we do not clear filenames here.
  • platform/gtk/DataObjectGtk.h: (WebCore::DataObjectGtk::url): This implementation is now a simple getter. (WebCore::DataObjectGtk::uriList): Ditto. (WebCore::DataObjectGtk::filenames): Added. (WebCore::DataObjectGtk::hasURL): Now a simple check. (WebCore::DataObjectGtk::hasFilenames): Added. (WebCore::DataObjectGtk::clearURIList): Simple setter. (WebCore::DataObjectGtk::clearURL): Ditto.
  • platform/gtk/DragDataGtk.cpp: (WebCore::DragData::containsFiles): Updated to access DataObjectGtk::hasFilenames(). (WebCore::DragData::asFilenames): Updated to access DataObjectGtk::filenames().
  • platform/gtk/PasteboardHelper.cpp: (WebCore::PasteboardHelper::getClipboardContents): Use the uriList as a string now. (WebCore::PasteboardHelper::fillSelectionData): Ditto. (WebCore::PasteboardHelper::fillDataObjectFromDropData): Ditto.
3:10 PM Changeset in webkit [69529] by jamesr@google.com
  • 2 edits in trunk/WebCore

2010-10-11 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] DRT crash in fast/canvas tests w/accel 2D canvas due to NULL DrawingBuffer
https://bugs.webkit.org/show_bug.cgi?id=47241

Avoid initializing accelerated graphics objects on CanvasRenderingContext2D
if there is no drawingContext associated with the canvas.

Test: fast/canvas/access-zero-sized-canvas.html

fast/canvas/canvas-skia-excessive-size.html
fast/canvas/toDataURL-noData.html

with --accelerated-compositing and --accelerated-2d-canvas

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D): (WebCore::CanvasRenderingContext2D::reset):
2:56 PM Changeset in webkit [69528] by Martin Robinson
  • 9 edits
    6 adds in trunk

2010-10-11 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Cleanup font selection code for the Freetype backend
https://bugs.webkit.org/show_bug.cgi?id=47503

Unskip some tests that lacked baselines before (they used cursive and fantasy font
families) and regenerate some correct baselines for the synthetic oblique test.

  • platform/gtk/Skipped: Update the skipped list.
  • platform/gtk/fonts/cursive-expected.txt: Added.
  • platform/gtk/fonts/default-expected.txt: Added.
  • platform/gtk/fonts/fantasy-expected.txt: Added.
  • platform/gtk/fonts/fontconfig-synthetic-oblique-expected.checksum:
  • platform/gtk/fonts/fontconfig-synthetic-oblique-expected.png:
  • platform/gtk/fonts/monospace-expected.txt: Added.
  • platform/gtk/fonts/sans-serif-expected.txt: Added.
  • platform/gtk/fonts/serif-expected.txt: Added.

2010-10-11 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Cleanup font selection code for the Freetype backend
https://bugs.webkit.org/show_bug.cgi?id=47503

Do some miscellaneous cleanup work in the Freetype font font selection backend.

  • platform/graphics/cairo/FontCacheFreeType.cpp: (WebCore::getFamilyNameStringFromFontDescriptionAndFamily): Modified this method to return a WebCore String. (WebCore::FontCache::createFontPlatformData): Do a bit of cleanup in this method: properly handle cursive and fantasy as fallback-like fonts. Instead of using raw CStrings do string comparisons using WebCore Strings. Remove a large block comment that originated from a Apache-licensed file.

2010-10-11 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Cleanup font selection code for the Freetype backend
https://bugs.webkit.org/show_bug.cgi?id=47503

Update DRT to set values for the cursive and fantasy font families, so
that we can generate consistent results for tests that use these families.
Add some missing information to fonts.conf.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): Always set the fantasy and cursive font family names.
  • DumpRenderTree/gtk/fonts/fonts.conf: Add aliases for cursive and fantasy fonts to our default serif font. Eventually we may want to import or require some "real" fonts, but this should at least ensure consistent rendering during test runs. Also add aliases for some other commonly used fonts in tests (Arial and Lucida Grande). Finally, add a missing oblique specification for DejaVu Serif, which was resulting in some incorrect baselines for the synthetic oblique test.
2:32 PM Changeset in webkit [69527] by ajwong@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed. Temporary patch for SVG changes from r69517.

Update test expectations to fail all SVG tests with different output
after r69517's changes. Rebaselines coming later.

  • platform/chromium/test_expectations.txt:
2:20 PM Changeset in webkit [69526] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-10-11 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Buttons activated with the keyboard should be painted as clicked
https://bugs.webkit.org/show_bug.cgi?id=18364

When a button is pressed, force it into the hovered state as far as the
Mozilla theme drawing code is concerned. This bug also seems to be an
issue for Firefox. When we switch away from the Mozilla theme drawing
code this work-around should no longer be necessary.

No new tests. I was not able to generate a pixel test for this issue. It
seems that our DRT does not have the necessary infrastructure to generate a
pixel dump while a button is in the pressed state.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::paintRenderObject):
2:15 PM Changeset in webkit [69525] by bweinstein@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix for Windows. Add a necessary export from r69516.

2:08 PM Changeset in webkit [69524] by jberlin@webkit.org
  • 10 edits in trunk

Add Private API for creating a WebKit2 WebSerializedScriptValue from the internal
representation of a WebKit1 WebSerializedJSValue.
https://bugs.webkit.org/show_bug.cgi?id=47439

Reviewed by Darin Adler.

WebKit/mac:

  • WebView/WebSerializedJSValue.mm:

(-[WebSerializedJSValue internalRepresentation]):

  • WebView/WebSerializedJSValuePrivate.h:

WebKit/win:

  • Interfaces/IWebSerializedJSValuePrivate.idl:

Because it is taking a void parameter, getInternalRepresentation must be declared [local].

  • WebSerializedJSValue.cpp:

(WebSerializedJSValue::getInternalRepresentation):

  • WebSerializedJSValue.h:

WebKit2:

  • Shared/API/c/WKSerializedScriptValue.cpp:

(WKSerializedScriptValueCreateWithInternalRepresentation):
Use the existing WebSerializedScriptValue constructor that takes a pointer to the internal
representation (a WebCore::SerializedScriptValue).

  • Shared/API/c/WKSerializedScriptValuePrivate.h:
1:58 PM Changeset in webkit [69523] by jianli@chromium.org
  • 19 edits in trunk/WebCore

Unreviewed. Build fix.

  • bindings/js/JSArrayBufferCustom.cpp:
  • bindings/js/JSArrayBufferViewCustom.cpp:
  • bindings/js/JSFloat32ArrayCustom.cpp:
  • bindings/js/JSInt16ArrayCustom.cpp:
  • bindings/js/JSInt32ArrayCustom.cpp:
  • bindings/js/JSInt8ArrayCustom.cpp:
  • bindings/js/JSUint16ArrayCustom.cpp:
  • bindings/js/JSUint32ArrayCustom.cpp:
  • bindings/js/JSUint8ArrayCustom.cpp:
  • bindings/v8/custom/V8ArrayBufferCustom.cpp:
  • bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
  • bindings/v8/custom/V8Float32ArrayCustom.cpp:
  • bindings/v8/custom/V8Int16ArrayCustom.cpp:
  • bindings/v8/custom/V8Int32ArrayCustom.cpp:
  • bindings/v8/custom/V8Int8ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint16ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint32ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint8ArrayCustom.cpp:
1:28 PM Changeset in webkit [69522] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix interpreter build -- was broken by incorrect merge.

1:20 PM Changeset in webkit [69521] by bfulgham@webkit.org
  • 3 edits in trunk/WebCore

Unreviewed WinCairo build fixes.

  • platform/network/curl/ResourceResponse.h: Correct forward declaration

for CFURLResponseRef.

  • rendering/RenderMediaControls.h: Add ENABLE(VIDEO) guard to new

header file to avoid build failure on non-VIDEO builds.

1:16 PM Changeset in webkit [69520] by jianli@chromium.org
  • 19 edits in trunk/WebCore

Add File API feature guard to all typed array files
https://bugs.webkit.org/show_bug.cgi?id=47437

Reviewed by Adam Barth.

Since we're going to add ArrayBuffer support to FileReader and BlobBuilder,
we need to update all type array files to include File API feature guard
in addition to the existing 3D_CANVAS guard. When ArrayBuffer is used in
XMLHttpRequest, we will then remove all the guards. This is per the
discussion on webkit-dev mailing list:
https://lists.webkit.org/pipermail/webkit-dev/2010-October/014716.html

  • html/canvas/ArrayBuffer.cpp:
  • html/canvas/ArrayBuffer.idl:
  • html/canvas/ArrayBufferView.cpp:
  • html/canvas/ArrayBufferView.idl:
  • html/canvas/Float32Array.cpp:
  • html/canvas/Float32Array.idl:
  • html/canvas/Int16Array.cpp:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.cpp:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.cpp:
  • html/canvas/Int8Array.idl:
  • html/canvas/Uint16Array.cpp:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.cpp:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.cpp:
  • html/canvas/Uint8Array.idl:
12:50 PM Changeset in webkit [69519] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-10-11 Andreas Kling <kling@webkit.org>

Build fix (implicit float conversion in Path.cpp)

  • platform/graphics/Path.cpp:
12:45 PM Changeset in webkit [69518] by Girish Ramakrishnan
  • 3 edits in trunk/WebCore

[Qt] Refactor Plugin X Pixmap painting code to a separate function

Reviewed by Kenneth Rohde Christiansen.

The refactored function will be used for rendering by the Accelerated
Composition enabled graphics layer.

https://bugs.webkit.org/show_bug.cgi?id=35524

  • plugins/PluginView.h:
  • plugins/qt/PluginViewQt.cpp:

(WebCore::PluginView::paintUsingXPixmap):
(WebCore::PluginView::paint):

12:19 PM Changeset in webkit [69517] by andreas.kling@nokia.com
  • 35 edits in trunk/WebCore

2010-10-11 Andreas Kling <kling@webkit.org>

Reviewed by Dirk Schulze.

SVG: Remove "create" methods and use port-specific "add" counterparts
https://bugs.webkit.org/show_bug.cgi?id=46052

Circles and ellipses will be significantly faster on platforms that
implement Path::addEllipse() in a sane fashion.

Also, a lot of Path copying has been factored out by changing functions
that would return Paths to take Path& arguments instead (toPathData, toClipPath)

  • mathml/RenderMathMLRoot.cpp: (WebCore::RenderMathMLRoot::paint):
  • mathml/RenderMathMLSquareRoot.cpp: (WebCore::RenderMathMLSquareRoot::paint):
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::addRoundedRectClip): (WebCore::GraphicsContext::clipOutRoundedRect):
  • platform/graphics/Path.cpp: (WebCore::pathLengthApplierFunction): (WebCore::Path::addRoundedRect):
  • platform/graphics/Path.h:
  • platform/graphics/cairo/ContextShadowCairo.cpp: (WebCore::ContextShadow::drawRectShadowWithoutTiling): (WebCore::ContextShadow::drawRectShadow):
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawFocusRing): (WebCore::GraphicsContext::drawTiledShadow): (WebCore::GraphicsContext::fillRoundedRect):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRoundedRect):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillRoundedRect):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBorder): (WebCore::RenderBoxModelObject::paintBoxShadow):
  • rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::getReplacementTextGeometry):
  • rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::pathOnlyClipping):
  • rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::layout):
  • rendering/svg/RenderSVGTextPath.cpp: (WebCore::RenderSVGTextPath::layoutPath):
  • rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::paintDecorationWithStyle):
  • svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::animationPath):
  • svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::toPathData):
  • svg/SVGCircleElement.h:
  • svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::toPathData):
  • svg/SVGEllipseElement.h:
  • svg/SVGLineElement.cpp: (WebCore::SVGLineElement::toPathData):
  • svg/SVGLineElement.h:
  • svg/SVGPathElement.cpp: (WebCore::SVGPathElement::getTotalLength): (WebCore::SVGPathElement::getPointAtLength): (WebCore::SVGPathElement::toPathData):
  • svg/SVGPathElement.h:
  • svg/SVGPolygonElement.cpp: (WebCore::SVGPolygonElement::toPathData):
  • svg/SVGPolygonElement.h:
  • svg/SVGPolylineElement.cpp: (WebCore::SVGPolylineElement::toPathData):
  • svg/SVGPolylineElement.h:
  • svg/SVGRectElement.cpp: (WebCore::SVGRectElement::toPathData):
  • svg/SVGRectElement.h:
  • svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::toClipPath):
  • svg/SVGStyledTransformableElement.h: (WebCore::SVGStyledTransformableElement::toPathData):
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::toClipPath):
  • svg/SVGUseElement.h:
12:12 PM Changeset in webkit [69516] by oliver@apple.com
  • 60 edits
    5 adds in trunk

2010-10-01 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

[ES5] Implement strict mode
https://bugs.webkit.org/show_bug.cgi?id=10701

Initial strict mode implementation. This is the simplest
implementation that could possibly work and adds (hopefully)
all of the restrictions required by strict mode. There are
a number of inefficiencies, especially in the handling of
arguments and eval as smart implementations would make this
patch more complicated.

The SyntaxChecker AST builder has become somewhat more complex
as strict mode does require more parse tree information to
validate the syntax.

Summary of major changes to the parser:

  • We track when we enter strict mode (this may come as a surprise)
  • Strict mode actually requires a degree of AST knowledge to validate so the SyntaxChecker now produces values that can be used to distinguish "node" types.
  • We now track variables that are written to. We do this to statically identify writes to global properties that don't exist and abort at that point. This should actually make it possible to optimise some other cases in the future but for now it's purely for validity checking. Currently writes are only tracked in strict mode code.
  • Labels are now tracked as it is now a syntax error to jump to a label that does not exist (or to use break, continue, or return in a context where they would be invalid).

Runtime changes:

  • In order to get correct hanlding of the Arguments object all strict mode functions that reference arguments create and tearoff the arguments object on entry. This is not strictly necessary but was the least work necessary to get the correct behaviour.
  • PutPropertySlot now tracks whether it is being used for a strict mode write, and if so Object::put will throw when a write can't be completed.
  • StrictEvalActivation was added as an "activation" object for strict mode eval (so that strict eval does not introduce new variables into the containing scope).
  • CMakeLists.txt:
  • GNUmakefile.am:
  • JavaScriptCore.exp:
  • JavaScriptCore.pro:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): (JSC::CodeBlock::CodeBlock): (JSC::CodeBlock::reparseForExceptionInfoIfNecessary):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::isStrictMode):
  • bytecode/EvalCodeCache.h: (JSC::EvalCodeCache::get):
  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::createArgumentsIfNecessary): (JSC::BytecodeGenerator::emitReturn):
  • bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::isStrictMode): (JSC::BytecodeGenerator::makeFunction):
  • debugger/Debugger.cpp: (JSC::evaluateInGlobalCallFrame):
  • debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::evaluate):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::callEval): (JSC::Interpreter::unwindCallFrame): (JSC::Interpreter::execute): (JSC::Interpreter::privateExecute):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
  • jit/JIT.h:
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_get_pnames): (JSC::JIT::emit_op_convert_this_strict): (JSC::JIT::emitSlow_op_convert_this_strict):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_get_pnames):
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
  • jit/JITStubs.h:
  • parser/ASTBuilder.h: (JSC::ASTBuilder::createFunctionBody): (JSC::ASTBuilder::isResolve):
  • parser/JSParser.cpp: (JSC::JSParser::next): (JSC::JSParser::startLoop): (JSC::JSParser::endLoop): (JSC::JSParser::startSwitch): (JSC::JSParser::endSwitch): (JSC::JSParser::setStrictMode): (JSC::JSParser::strictMode): (JSC::JSParser::isValidStrictMode): (JSC::JSParser::declareParameter): (JSC::JSParser::breakIsValid): (JSC::JSParser::pushLabel): (JSC::JSParser::popLabel): (JSC::JSParser::hasLabel): (JSC::JSParser::DepthManager::DepthManager): (JSC::JSParser::DepthManager::~DepthManager): (JSC::JSParser::Scope::Scope): (JSC::JSParser::Scope::startSwitch): (JSC::JSParser::Scope::endSwitch): (JSC::JSParser::Scope::startLoop): (JSC::JSParser::Scope::endLoop): (JSC::JSParser::Scope::inLoop): (JSC::JSParser::Scope::breakIsValid): (JSC::JSParser::Scope::pushLabel): (JSC::JSParser::Scope::popLabel): (JSC::JSParser::Scope::hasLabel): (JSC::JSParser::Scope::isFunction): (JSC::JSParser::Scope::declareVariable): (JSC::JSParser::Scope::declareWrite): (JSC::JSParser::Scope::deleteProperty): (JSC::JSParser::Scope::declareParameter): (JSC::JSParser::Scope::setNeedsFullActivation): (JSC::JSParser::Scope::collectFreeVariables): (JSC::JSParser::Scope::getUncapturedWrittenVariables): (JSC::JSParser::Scope::getDeletedVariables): (JSC::JSParser::Scope::setStrictMode): (JSC::JSParser::Scope::strictMode): (JSC::JSParser::Scope::isValidStrictMode): (JSC::JSParser::pushScope): (JSC::JSParser::popScope): (JSC::JSParser::declareVariable): (JSC::JSParser::declareWrite): (JSC::JSParser::deleteProperty): (JSC::jsParse): (JSC::JSParser::JSParser): (JSC::JSParser::parseProgram): (JSC::JSParser::parseSourceElements): (JSC::JSParser::parseDoWhileStatement): (JSC::JSParser::parseWhileStatement): (JSC::JSParser::parseVarDeclarationList): (JSC::JSParser::parseConstDeclarationList): (JSC::JSParser::parseForStatement): (JSC::JSParser::parseBreakStatement): (JSC::JSParser::parseContinueStatement): (JSC::JSParser::parseReturnStatement): (JSC::JSParser::parseWithStatement): (JSC::JSParser::parseSwitchStatement): (JSC::JSParser::parseSwitchClauses): (JSC::JSParser::parseSwitchDefaultClause): (JSC::JSParser::parseTryStatement): (JSC::JSParser::parseBlockStatement): (JSC::JSParser::parseStatement): (JSC::JSParser::parseFormalParameters): (JSC::JSParser::parseFunctionBody): (JSC::JSParser::parseFunctionInfo): (JSC::JSParser::parseFunctionDeclaration): (JSC::JSParser::parseExpressionOrLabelStatement): (JSC::JSParser::parseIfStatement): (JSC::JSParser::parseExpression): (JSC::JSParser::parseAssignmentExpression): (JSC::JSParser::parseConditionalExpression): (JSC::JSParser::parseBinaryExpression): (JSC::JSParser::parseStrictObjectLiteral): (JSC::JSParser::parsePrimaryExpression): (JSC::JSParser::parseMemberExpression): (JSC::JSParser::parseUnaryExpression):
  • parser/JSParser.h:
  • parser/Lexer.cpp: (JSC::Lexer::parseString): (JSC::Lexer::lex):
  • parser/Lexer.h: (JSC::Lexer::isReparsing):
  • parser/Nodes.cpp: (JSC::ScopeNode::ScopeNode): (JSC::FunctionBodyNode::FunctionBodyNode): (JSC::FunctionBodyNode::create):
  • parser/Nodes.h: (JSC::ScopeNode::isStrictMode):
  • parser/Parser.cpp: (JSC::Parser::parse):
  • parser/Parser.h: (JSC::Parser::parse):
  • parser/SyntaxChecker.h: (JSC::SyntaxChecker::SyntaxChecker): (JSC::SyntaxChecker::makeFunctionCallNode): (JSC::SyntaxChecker::appendToComma): (JSC::SyntaxChecker::createCommaExpr): (JSC::SyntaxChecker::makeAssignNode): (JSC::SyntaxChecker::makePrefixNode): (JSC::SyntaxChecker::makePostfixNode): (JSC::SyntaxChecker::makeTypeOfNode): (JSC::SyntaxChecker::makeDeleteNode): (JSC::SyntaxChecker::makeNegateNode): (JSC::SyntaxChecker::makeBitwiseNotNode): (JSC::SyntaxChecker::createLogicalNot): (JSC::SyntaxChecker::createUnaryPlus): (JSC::SyntaxChecker::createVoid): (JSC::SyntaxChecker::thisExpr): (JSC::SyntaxChecker::createResolve): (JSC::SyntaxChecker::createObjectLiteral): (JSC::SyntaxChecker::createArray): (JSC::SyntaxChecker::createNumberExpr): (JSC::SyntaxChecker::createString): (JSC::SyntaxChecker::createBoolean): (JSC::SyntaxChecker::createNull): (JSC::SyntaxChecker::createBracketAccess): (JSC::SyntaxChecker::createDotAccess): (JSC::SyntaxChecker::createRegex): (JSC::SyntaxChecker::createNewExpr): (JSC::SyntaxChecker::createConditionalExpr): (JSC::SyntaxChecker::createAssignResolve): (JSC::SyntaxChecker::createFunctionExpr): (JSC::SyntaxChecker::createFunctionBody): (JSC::SyntaxChecker::appendBinaryExpressionInfo): (JSC::SyntaxChecker::operatorStackPop):
  • runtime/Arguments.cpp: (JSC::Arguments::createStrictModeCallerIfNecessary): (JSC::Arguments::createStrictModeCalleeIfNecessary): (JSC::Arguments::getOwnPropertySlot): (JSC::Arguments::getOwnPropertyDescriptor): (JSC::Arguments::put): (JSC::Arguments::deleteProperty):
  • runtime/Arguments.h: (JSC::Arguments::Arguments):
  • runtime/CommonIdentifiers.cpp: (JSC::CommonIdentifiers::CommonIdentifiers):
  • runtime/CommonIdentifiers.h:
  • runtime/Error.cpp: (JSC::StrictModeTypeErrorFunction::StrictModeTypeErrorFunction): (JSC::StrictModeTypeErrorFunction::constructThrowTypeError): (JSC::StrictModeTypeErrorFunction::getConstructData): (JSC::StrictModeTypeErrorFunction::callThrowTypeError): (JSC::StrictModeTypeErrorFunction::getCallData): (JSC::createTypeErrorFunction):
  • runtime/Error.h:
  • runtime/Executable.cpp: (JSC::EvalExecutable::EvalExecutable): (JSC::ProgramExecutable::ProgramExecutable): (JSC::FunctionExecutable::FunctionExecutable): (JSC::EvalExecutable::compileInternal): (JSC::ProgramExecutable::checkSyntax): (JSC::ProgramExecutable::compileInternal): (JSC::FunctionExecutable::compileForCallInternal): (JSC::FunctionExecutable::compileForConstructInternal): (JSC::FunctionExecutable::reparseExceptionInfo): (JSC::EvalExecutable::reparseExceptionInfo): (JSC::FunctionExecutable::fromGlobalCode): (JSC::ProgramExecutable::reparseExceptionInfo):
  • runtime/Executable.h: (JSC::ScriptExecutable::ScriptExecutable): (JSC::ScriptExecutable::isStrictMode): (JSC::EvalExecutable::create): (JSC::FunctionExecutable::create):
  • runtime/JSActivation.cpp: (JSC::JSActivation::toStrictThisObject):
  • runtime/JSActivation.h:
  • runtime/JSFunction.cpp: (JSC::createDescriptorForThrowingProperty): (JSC::JSFunction::getOwnPropertySlot): (JSC::JSFunction::getOwnPropertyDescriptor): (JSC::JSFunction::put):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
  • runtime/JSGlobalData.h:
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset):
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::internalFunctionStructure):
  • runtime/JSGlobalObjectFunctions.cpp: (JSC::globalFuncEval):
  • runtime/JSObject.cpp: (JSC::JSObject::put): (JSC::JSObject::toStrictThisObject): (JSC::throwTypeError):
  • runtime/JSObject.h: (JSC::JSObject::isStrictModeFunction): (JSC::JSObject::putDirectInternal): (JSC::JSObject::putDirect): (JSC::JSValue::putDirect): (JSC::JSValue::toStrictThisObject):
  • runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::toStrictThisObject):
  • runtime/JSStaticScopeObject.h:
  • runtime/JSValue.h:
  • runtime/JSZombie.h: (JSC::JSZombie::toStrictThisObject):
  • runtime/PutPropertySlot.h: (JSC::PutPropertySlot::PutPropertySlot): (JSC::PutPropertySlot::isStrictMode):
  • runtime/StrictEvalActivation.cpp: Added. (JSC::StrictEvalActivation::StrictEvalActivation): (JSC::StrictEvalActivation::deleteProperty): (JSC::StrictEvalActivation::toThisObject): (JSC::StrictEvalActivation::toStrictThisObject):
  • runtime/StrictEvalActivation.h: Added.

2010-10-01 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

[ES5] Implement strict mode
https://bugs.webkit.org/show_bug.cgi?id=10701

Tests for the many different behaviours we get in strict mode.

  • fast/js/basic-strict-mode-expected.txt: Added.
  • fast/js/basic-strict-mode.html: Added.
  • fast/js/script-tests/basic-strict-mode.js: Added. (testThis): (testGlobalAccess):

2010-10-01 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

[ES5] Implement strict mode
https://bugs.webkit.org/show_bug.cgi?id=10701

Test: fast/js/basic-strict-mode.html

Override toStrictThisObject on the domwindow so that
it correctly provides the shell object when used as this
in a strict mode function.

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::toStrictThisObject):
  • bindings/js/JSDOMWindowBase.h:
12:09 PM Changeset in webkit [69515] by tonikitoo@webkit.org
  • 3 edits
    3 deletes in trunk/LayoutTests

2010-10-10 Antonio Gomes <agomes@rim.com>

Reviewed by Andreas Kling.

Convert editing/selection/script-tests/click-in-padding-with-multiple-line-boxes.js to use LayoutTestController::setEditingBehavior
https://bugs.webkit.org/show_bug.cgi?id=47472

Patch converts the editing/selection/click-in-padding-with-multiple-line-boxes.js to make use of the
LayoutTestController::setEditingBehavior machinery. That way, all platform specific editing behavior
code paths can be test in the same execution, and we make it possible to share the same
expected result file through all ports.

  • editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt: Modified with resutls for all editing behaviors, i.e. mac and win.
  • editing/selection/script-tests/click-in-padding-with-multiple-line-boxes.js: ():
  • platform/mac/editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt: Removed.
  • platform/qt/editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt: Removed.
  • platform/win/editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt: Removed.
12:03 PM Changeset in webkit [69514] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-10-11 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Eric Carlson.

CRASH at WebCore::HTMLSourceElement::scheduleErrorEvent
https://bugs.webkit.org/show_bug.cgi?id=46777

Another case that could lead to an improper set of states between
m_currentNode and m_loadingState. Also added an ASSERT and early
return to prevent crashes if this case can still happen in other ways.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::prepareForLoad):
12:00 PM Changeset in webkit [69513] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2010-10-11 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed build fix.

Fixed design-mode-spellcheck-off.html so that it passes on platforms that do not support textInputController.

  • editing/spelling/design-mode-spellcheck-off.html:
11:38 AM Changeset in webkit [69512] by crogers@google.com
  • 43 edits
    2 adds in branches/audio/WebCore

audio branch: lots of cleanup for landing into trunk

  • HRTFPanner and EqualPowerPanner last cleanup before landing
  • HighPass2Filter and LowPass2Filter last cleanup before landing
  • AudioBasicProcessorNode, AudioPannerNode, BiquadDSPKernel, BiquadProcess, last cleanup before landing
  • lots of cleanup and thread safety work for AudioNodeInput and AudioNodeOutput
  • add AudioUtilities
  • general cleanup: AudioResampler, AudioBufferSourceNode, AudioGainNode, RealtimeAnalyser, RealtimeAnalyserNode
11:32 AM Changeset in webkit [69511] by mthole@apple.com
  • 9 edits in trunk

Rename WKCertificateInfoGetPeerCertificates() to WKCertificateInfoGetCertificateChain()
https://bugs.webkit.org/show_bug.cgi?id=47495

Reviewed by Darin Adler.

WebKit2:

  • Shared/API/c/mac/WKCertificateInfoMac.h:

Renamed WKCertificateInfoGetPeerCertificates() to WKCertificateInfoGetCertificateChain()

  • Shared/API/c/mac/WKCertificateInfoMac.mm:

(WKCertificateInfoGetCertificateChain): Updated for name change.

  • Shared/mac/PlatformCertificateInfo.h:

(WebKit::PlatformCertificateInfo::certificateChain): Renamed from peerCertificates()

  • Shared/mac/PlatformCertificateInfo.mm:

(WebKit::PlatformCertificateInfo::PlatformCertificateInfo): Updated for name change.
(WebKit::PlatformCertificateInfo::encode): Ditto.
(WebKit::PlatformCertificateInfo::decode): Ditto.
(WebKit::PlatformCertificateInfo::dump): Ditto.

WebKitLibraries:

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
11:29 AM Changeset in webkit [69510] by kbalazs@webkit.org
  • 2 edits in trunk/WebKit2

2010-10-11 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Issue a warning when an InjectedBundle can't be loaded.
https://bugs.webkit.org/show_bug.cgi?id=47497

The original author of the patch is Jocelyn Turcotte <jocelyn.turcotte@nokia.com>.

  • WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp: (WebKit::InjectedBundle::load):
11:12 AM Changeset in webkit [69509] by rniwa@webkit.org
  • 20 edits
    2 adds in trunk

2010-10-11 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

spellcheck="false" not respected in designMode
https://bugs.webkit.org/show_bug.cgi?id=39978

The bug was caused by WebKit's setting focus to html element rather than body element in design mode.
Because we disable spell-check only if ancestor nodes of the focused element had spellcheck=false,
this caused us to ignore body element's spellcheck attribute.

Fixed the bug by overriding supportsFocus in HTMLBodyElement to make body element focusable
when the parent node of body elements (namely html element) is editable.

Test: editing/spelling/design-mode-spellcheck-off.html

  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::supportsFocus): Added.
  • html/HTMLBodyElement.h:

2010-10-11 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

spellcheck="false" not respected in designMode
https://bugs.webkit.org/show_bug.cgi?id=39978

Added a test to ensure Webkit respects spellcheck=off on body element.
Rebaselined are due to our setting the focus to body element rather than html element in design mode.

  • editing/spelling/design-mode-spellcheck-off-expected.txt: Added.
  • editing/spelling/design-mode-spellcheck-off.html: Added.
  • editing/inserting/space-after-removeformat-expected.txt: Editing delegates change due to focus moving to body.
  • platform/chromium-win/editing/inserting/editable-html-element-expected.txt: Ditto.
  • platform/chromium-win/editing/selection/editable-html-element-expected.txt: Ditto.
  • platform/chromium-win/editing/selection/editable-links-expected.txt: Ditto.
  • platform/chromium-win/editing/selection/focus_editable_html-expected.txt: Ditto.
  • platform/chromium-win/editing/style/designmode-expected.txt: Ditto.
  • platform/mac/editing/inserting/editable-html-element-expected.txt: Ditto.
  • platform/mac/editing/selection/designmode-no-caret-expected.txt: Ditto.
  • platform/mac/editing/selection/editable-html-element-expected.txt: Ditto.
  • platform/mac/editing/selection/editable-links-expected.txt: Ditto.
  • platform/mac/editing/selection/focus_editable_html-expected.txt: Ditto.
  • platform/mac/editing/style/designmode-expected.txt: Ditto.
  • platform/qt/editing/inserting/editable-html-element-expected.txt: Ditto.
  • platform/qt/editing/selection/editable-html-element-expected.txt: Ditto.
  • platform/qt/editing/selection/focus_editable_html-expected.txt: Ditto.
  • platform/qt/editing/style/designmode-expected.txt: Ditto.
11:12 AM Changeset in webkit [69508] by weinig@apple.com
  • 11 edits in trunk/WebKit2

Rename transformToDeviceSpace to convertToDeviceSpace and
transformToUserSpace to convertToUserSpace at Simon's request.

Reviewed by Simon Fraser.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::convertToDeviceSpace):
(WebKit::PageClientImpl::convertToUserSpace):

  • UIProcess/API/mac/WKView.mm:

(-[WKView _convertToDeviceSpace:]):
(-[WKView _convertToUserSpace:]):

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::convertToDeviceSpace):
(QWKPagePrivate::convertToUserSpace):

  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setWindowFrame):
(WebKit::WebPageProxy::getWindowFrame):

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::convertToDeviceSpace):
(WebKit::WebView::convertToUserSpace):

  • UIProcess/win/WebView.h:
10:54 AM Changeset in webkit [69507] by oliver@apple.com
  • 2 edits in trunk/WebCore

Build fix -- I thought i had killed the prior commit in time to allow me to add this

10:44 AM Changeset in webkit [69506] by oliver@apple.com
  • 2 edits in trunk/WebCore

2010-10-11 Oliver Hunt <oliver@apple.com>

Reviewed by Andreas Kling.

Incorrect handling of 0 length logs in GraphicsContext3DOpenGL.cpp
https://bugs.webkit.org/show_bug.cgi?id=47494

Working on another patch I found that there was some screwy behaviour
when dealing with logs from GL. GL_INFO_LOG_LENGTH is defined as being
zero if there is no log message, but we did not check for that case and
simply perfomed a zero sized alloc and passed the resultant buffer to
glGetShaderInfoLog, etc. glGetShaderInfoLog would then write a null
terminator to the buffer, thus causing an overflow. This is obviously
not a problem in practice as allocations are at least 4 bytes long in
all common allocators, but it is still a bug.

I also removed some unnecessary null checks following calls to fastMalloc.

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::getProgramInfoLog): (WebCore::GraphicsContext3D::getShaderInfoLog):
10:27 AM Changeset in webkit [69505] by Nikolas Zimmermann
  • 13 edits in trunk/WebCore

2010-10-11 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Andreas Kling.

Kill Path::debugString()
https://bugs.webkit.org/show_bug.cgi?id=47493

Remove the obsolete Path::debugString() method. DRT now dumps paths in a platform independant way.

  • platform/graphics/Path.h:
  • platform/graphics/cairo/PathCairo.cpp:
  • platform/graphics/cg/PathCG.cpp:
  • platform/graphics/haiku/PathHaiku.cpp:
  • platform/graphics/openvg/PathOpenVG.cpp:
  • platform/graphics/qt/PathQt.cpp:
  • platform/graphics/skia/PathSkia.cpp:
  • platform/graphics/wince/PathWinCE.cpp:
  • platform/graphics/wince/PlatformPathWinCE.cpp:
  • platform/graphics/wince/PlatformPathWinCE.h:
  • platform/graphics/wx/PathWx.cpp:
  • svg/SVGGlyphElement.h: (WebCore::SVGGlyphIdentifier::operator==):
10:13 AM Changeset in webkit [69504] by weinig@apple.com
  • 3 edits in trunk/WebKit2

Try to fix the Mac release build.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _transformToDeviceSpace:]):
(-[WKView _transformToUserSpace:]):

  • UIProcess/API/mac/WKViewInternal.h:
10:07 AM Changeset in webkit [69503] by kbalazs@webkit.org
  • 2 edits in trunk/WebKit2

2010-10-11 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

WebProcess ASSERTs with a null application cache dir creation parameter
https://bugs.webkit.org/show_bug.cgi?id=47489

  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeWebProcess):
9:38 AM Changeset in webkit [69502] by kenneth@webkit.org
  • 2 edits in trunk/WebKit2

Unlink the files used for I/O mapped memory as soon as they are
created.

Reviewed by Andreas Kling.

  • Shared/qt/UpdateChunk.cpp:

(WebKit::mapMemory):
(WebKit::mapFile):

9:24 AM Changeset in webkit [69501] by inferno@chromium.org
  • 3 edits
    2 copies in branches/chromium/517

Merge 68819

BUG=56206
Review URL: http://codereview.chromium.org/3674004

9:21 AM Changeset in webkit [69500] by inferno@chromium.org
  • 1 edit
    4 copies in branches/chromium/517

Merge 69476

BUG=57200
Review URL: http://codereview.chromium.org/3662002

9:19 AM Changeset in webkit [69499] by inferno@chromium.org
  • 7 edits
    2 copies in branches/chromium/517

Merge 69043

BUG=55346
Review URL: http://codereview.chromium.org/3691003

9:14 AM Changeset in webkit [69498] by inferno@chromium.org
  • 2 edits
    2 copies in branches/chromium/517

Merge 69345

BUG=58008
Review URL: http://codereview.chromium.org/3692003

9:08 AM Changeset in webkit [69497] by kenneth@webkit.org
  • 2 edits in trunk/WebKit2

Build fix when using MeeGo Touch

Rubberstamped by Andreas Kling.

  • WebProcess/qt/WebProcessMainQt.cpp:
8:55 AM Changeset in webkit [69496] by kenneth@webkit.org
  • 2 edits in trunk/WebKit2

Use raster for the QtWebProcess.

Reviewed by Andreas Kling.

  • WebProcess/qt/WebProcessMainQt.cpp:

(WebKit::WebProcessMainQt):

8:24 AM Changeset in webkit [69495] by Martin Robinson
  • 3 edits
    2 adds in trunk

2010-10-11 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Search field icons should be centered vertically in the field
https://bugs.webkit.org/show_bug.cgi?id=47441

Add a pixel dump result which tests the fix.

  • platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.checksum: Added.
  • platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.png: Added.

2010-10-11 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Search field icons should be centered vertically in the field
https://bugs.webkit.org/show_bug.cgi?id=47441

Center search field icons vertically in the search field.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::centerRectVerticallyInParentInputElement): Added this helper. (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration): Center the search field icon by adjusting its drawing rect relative to the containing search field. (WebCore::RenderThemeGtk::paintSearchFieldCancelButton): Ditto.
8:18 AM Changeset in webkit [69494] by podivilov@chromium.org
  • 2 edits in trunk/WebCore

2010-10-11 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: fix event listener breakpoints sidebar pane style
https://bugs.webkit.org/show_bug.cgi?id=47487

  • inspector/front-end/inspector.css: (.section .properties, .event-bar .event-properties): (.section.expanded .properties, .event-bar.expanded .event-properties): (.properties-tree): (.properties-tree li): (.properties-tree li.parent): (.properties-tree li.parent::before): (.properties-tree li.parent.expanded::before): (.properties-tree li .info): (.properties-tree ol, .stack-trace ol, ol.stack-trace): (.properties-tree ol.expanded, .stack-trace ol, ol.stack-trace): (ol.stack-trace): (.event-listener-breakpoints .event-category): (.event-listener-breakpoints.properties-tree .children li): (.event-listener-breakpoints .checkbox-elem): (.breakpoint-list .breakpoint-hit):
8:07 AM Changeset in webkit [69493] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-10-11 Andreas Kling <kling@webkit.org>

Reviewed by Tor Arne Vestbø.

[Qt] Avoid QPainterPath::operator=(QPainterPath()) when possible

Same concept as <http://trac.webkit.org/changeset/69462>, do nothing
when clearing an already empty QPainterPath. Avoids one delete+new.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::clearCurrentPath): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::beginPath):
8:02 AM Changeset in webkit [69492] by kov@webkit.org
  • 3 edits in trunk/WebCore

2010-10-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Remove unnecessary GTK+ and Pango includes.

  • platform/gtk/FileChooserGtk.cpp:
  • platform/gtk/Language.cpp:
7:43 AM Changeset in webkit [69491] by kenneth@webkit.org
  • 2 edits in trunk/WebKit2

Unreviewed win build fix.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
7:12 AM Changeset in webkit [69490] by kenneth@webkit.org
  • 15 edits in trunk/WebKit2

Adding Qt WebKit2 API for dealing with viewport meta info
https://bugs.webkit.org/show_bug.cgi?id=47202

Reviewed by Sam Weinig.

Add new API for setting scale and layout viewport given the data
provided by the viewport meta tag.

Any Qt view components who wants to support this, will need to
compute the viewport attributes before first load using
viewportAttributesForSize(..), and then again everytime
the viewport attributes gets invalidates (loading a new page,
navigating page cache) or every time on of the browser
attributes change, such as when the device is rotates (which
changes the actual visible viewport). A signal
viewportChangeRequested() is provided for the former.

  • Shared/WebCoreArgumentCoders.h:
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setViewportArguments):

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::setViewportArguments):
(QWKPage::ViewportAttributes::ViewportAttributes):
(QWKPage::ViewportAttributes::~ViewportAttributes):
(QWKPage::ViewportAttributes::operator=):
(QWKPage::viewportAttributesForSize):

  • UIProcess/API/qt/qwkpage.h:
  • UIProcess/API/qt/qwkpage_p.h:

(QtViewportAttributesPrivate::QtViewportAttributesPrivate):

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didChangeViewportData):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/win/WebView.cpp:

(WebKit::WebView::setViewportArguments):

  • UIProcess/win/WebView.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::dispatchViewportDataDidChange):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
6:56 AM WebKit Team edited by tonikitoo@webkit.org
(diff)
6:41 AM Changeset in webkit [69489] by tonikitoo@webkit.org
  • 3 edits
    3 deletes in trunk/LayoutTests

2010-10-10 Antonio Gomes <agomes@rim.com>

Reviewed by Andreas Kling.

Convert editing/selection/script-tests/click-in-margins-inside-editable-div.js to use LayoutTestController::setEditingBeh avior
https://bugs.webkit.org/show_bug.cgi?id=47471

Patch converts the editing/selection/click-in-margins-inside-editable-div to make use of the
LayoutTestController::setEditingBehavior machinery. That way, all platform specific editing behavior
code paths can be test in the same execution, and we make it possible to share the same
expected result file through all ports.

  • editing/selection/click-in-margins-inside-editable-div-expected.txt:
  • editing/selection/script-tests/click-in-margins-inside-editable-div.js: ():
  • platform/mac/editing/selection/click-in-margins-inside-editable-div-expected.txt: Removed.
  • platform/qt/editing/selection/click-in-margins-inside-editable-div-expected.txt: Removed.
  • platform/win/editing/selection/click-in-margins-inside-editable-div-expected.txt: Removed.
6:19 AM Changeset in webkit [69488] by Csaba Osztrogonác
  • 2 edits in trunk/WebKit2

2010-10-11 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Andreas Kling.

[Qt] WebKit2 build scripts are buggy
https://bugs.webkit.org/show_bug.cgi?id=47377

Generated sources must depends on WebKit2/Scripts/webkit2/messages.py too.

  • DerivedSources.pro: Missing dependencies added.
5:36 AM Changeset in webkit [69487] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-11 Alexander Pavlov <apavlov@chromium.org>

[Chromium] Unreviewed, build fix.

Disable fast/filesystem/op-remove.html for chromium-win.

  • platform/chromium/test_expectations.txt:
4:59 AM Changeset in webkit [69486] by apavlov@chromium.org
  • 5 edits in trunk/LayoutTests

2010-10-11 Alexander Pavlov <apavlov@chromium.org>

[Chromium] Unreviewed, build fix.

Rebaseline svg/W3C-SVG-1.1-SE/filters-image-03-f for chromium-linux and chromium-mac.

  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
4:21 AM Changeset in webkit [69485] by kinuko@chromium.org
  • 31 edits in trunk

2010-10-11 Kinuko Yasuda <kinuko@google.com>

Reviewed by David Levin.

Support DirectoryEntry.removeRecursively for FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=47400

  • src/AsyncFileSystemChromium.cpp: (WebCore::AsyncFileSystemChromium::removeRecursively): Added.
  • src/AsyncFileSystemChromium.h:
  • src/WorkerAsyncFileSystemChromium.cpp: (WebCore::WorkerAsyncFileSystemChromium::removeRecursively): Added.
  • src/WorkerAsyncFileSystemChromium.h:
  • src/WorkerFileSystemCallbacksBridge.cpp: (WebKit::WorkerFileSystemCallbacksBridge::postRemoveRecursivelyToMainThread): Added. (WebKit::WorkerFileSystemCallbacksBridge::removeRecursivelyOnMainThread): Added.
  • src/WorkerFileSystemCallbacksBridge.h:

2010-10-11 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by David Levin.

Support DirectoryEntry.removeRecursively for FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=47400

Also disallows remove/removeRecursively on the root directory.

Test: fast/filesystem/op-remove.html

  • fileapi/DOMFileSystemBase.cpp: (WebCore::DOMFileSystemBase::removeRecursively): Added.
  • fileapi/DOMFileSystemBase.h:
  • fileapi/DirectoryEntry.cpp: (WebCore::DirectoryEntry::removeRecursively): Added.
  • fileapi/DirectoryEntry.h:
  • fileapi/DirectoryEntry.idl:
  • fileapi/DirectoryEntrySync.cpp: (WebCore::DirectoryEntrySync::removeRecursively): Added.
  • fileapi/DirectoryEntrySync.h:
  • fileapi/DirectoryEntrySync.idl:
  • platform/AsyncFileSystem.h:

2010-10-11 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by David Levin.

Support DirectoryEntry.removeRecursively for FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=47400

  • fast/filesystem/resources/async-operations.js:
  • fast/filesystem/resources/fs-test-util.js: (removeAllInDirectory): renamed from removeRecursively and changed the implemntation to use DirectoryEntry.removeRecursively.
  • fast/filesystem/resources/fs-worker-common.js: (removeAllInDirectorySync): ditto.
  • fast/filesystem/resources/op-remove.js: Added removeRecursively test.
  • fast/filesystem/resources/op-tests-helper.js: (runOperationTest.OperationTestHelper.this.removeRecursively): Added.
  • fast/filesystem/resources/sync-operations.js:
  • fast/filesystem/script-tests/file-from-file-entry.js:
  • fast/filesystem/script-tests/read-directory.js:
4:03 AM Changeset in webkit [69484] by apavlov@chromium.org
  • 4 edits in trunk/LayoutTests

2010-10-11 Alexander Pavlov <apavlov@chromium.org>

[Chromium] Unreviewed, build fix.

Rebaseline svg/W3C-SVG-1.1-SE/filters-image-03-f for chromium-linux.
Fix bad expectation.

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/chromium/test_expectations.txt:
3:38 AM Changeset in webkit [69483] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-11 Alexander Pavlov <apavlov@chromium.org>

[Chromium] Unreviewed, build fix.

Update more test expectations.

  • platform/chromium/test_expectations.txt:
2:56 AM Changeset in webkit [69482] by krit@webkit.org
  • 6 edits in trunk

2010-10-11 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG feImage take preserveAspectRatio into account for absolute paint rect
https://bugs.webkit.org/show_bug.cgi?id=47464

Determine the smallest effect region for SVGFEImage by taking preserveAspectRatio into account.

  • svg/graphics/filters/SVGFEImage.cpp: (WebCore::FEImage::determineAbsolutePaintRect): (WebCore::FEImage::apply):
  • svg/graphics/filters/SVGFEImage.h:

2010-10-11 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG feImage take preserveAspectRatio into account for absolute paint rect
https://bugs.webkit.org/show_bug.cgi?id=47464

Needs a new baseline for svg/W3C-SVG-1.1-SE/filters-image-03-f.

  • platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
2:19 AM Changeset in webkit [69481] by apavlov@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

2010-10-11 Alexander Pavlov <apavlov@chromium.org>

[Chromium] Unreviewed, build fix.

Rebaseline overhanging-floats-removed for chromium-win and chromium-linux platforms.

  • platform/chromium-linux/fast/flexbox/overhanging-floats-removed-expected.checksum: Added.
  • platform/chromium-linux/fast/flexbox/overhanging-floats-removed-expected.png: Added.
  • platform/chromium-win/fast/flexbox/overhanging-floats-removed-expected.checksum: Added.
  • platform/chromium-win/fast/flexbox/overhanging-floats-removed-expected.png: Added.
1:26 AM QtWebKitContrib edited by jocelyn.turcotte@nokia.com
Remove running the tests from the steps. (diff)
1:22 AM Changeset in webkit [69480] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-10-11 Adam Barth <abarth@webkit.org>

Unreviewed.

Fix sheriffbot not to crash when there are failing tests. It turns out
Python sets don't support the + operator. We need to use union
instead. There's a more elegant way to do this in Python 2.6, but we
need this code to work in 2.5.

  • Scripts/webkitpy/common/net/failuremap.py:
  • Scripts/webkitpy/common/net/failuremap_unittest.py:
12:17 AM Changeset in webkit [69479] by inferno@chromium.org
  • 1 edit
    2 adds
    1 delete in trunk/LayoutTests

2010-10-11 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Commit r69478 put the expected file in wrong platform. Correcting that.

  • platform/gtk/fast/flexbox: Added.
  • platform/gtk/fast/flexbox/overhanging-floats-removed-expected.txt: Added.
  • platform/qt/fast/flexbox/overhanging-floats-removed-expected.txt: Removed.

Oct 10, 2010:

11:58 PM Changeset in webkit [69478] by inferno@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2010-10-10 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Rebaseline overhanging-floats-removed test for GTK platform.

  • platform/qt/fast/flexbox/overhanging-floats-removed-expected.txt: Added.
11:34 PM Changeset in webkit [69477] by mitz@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Added Radar ULR

11:29 PM Changeset in webkit [69476] by inferno@chromium.org
  • 3 edits
    4 adds in trunk

2010-10-10 Abhishek Arya <inferno@chromium.org>

Reviewed by Dan Bernstein.

Overhanging floats are not added to flexible boxes since they behave like
block formatting contexts. This causes the intruding floats added in siblings
to not get cleared. Enforce the float release by checking if the parent is a
flexible box and if yes, use that as the outermost block.


https://bugs.webkit.org/show_bug.cgi?id=47104

Test: fast/flexbox/overhanging-floats-removed.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):

2010-10-10 Abhishek Arya <inferno@chromium.org>

Reviewed by Dan Bernstein.

Tests that intruding floats get properly cleared in flexible box layout.
https://bugs.webkit.org/show_bug.cgi?id=47104

  • fast/flexbox/overhanging-floats-removed-expected.checksum: Added.
  • fast/flexbox/overhanging-floats-removed-expected.png: Added.
  • fast/flexbox/overhanging-floats-removed-expected.txt: Added.
  • fast/flexbox/overhanging-floats-removed.html: Added.
3:57 PM Changeset in webkit [69475] by Patrick Gansterer
  • 2 edits in trunk/JavaScriptCore

2010-10-10 Patrick Gansterer <Patrick Gansterer>

Unreviewed.

Windows build fix after r69472.

  • wtf/text/StringHash.h: (WTF::CaseFoldingHash::hash):
3:18 PM Changeset in webkit [69474] by Chris Fleizach
  • 3 edits
    2 adds in trunk

2010-10-10 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

AX: if aria-live is on a <span> or ignored element, live regions don't work
https://bugs.webkit.org/show_bug.cgi?id=47443

  • platform/mac/accessibility/live-region-on-span-expected.txt: Added.
  • platform/mac/accessibility/live-region-on-span.html: Added.

2010-10-10 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

AX: if aria-live is on a <span> or ignored element, live regions don't work
https://bugs.webkit.org/show_bug.cgi?id=47443

If an element has aria attributes, but has no other native role associated with it,
accessibility should fallback to exposing that element as an AXGroup.

Test: platform/mac/accessibility/live-region-on-span.html

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
2:05 PM Changeset in webkit [69473] by robert@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-10 Robert Hogan <robert@webkit.org>

Unreviewed, fix failing test from r69468.

[Qt] Put all DRT-created pages in a page group

Fix on r69468.

Because we don't delete closed pages immediately in DRT we need
to remove them from the page group explicitly instead.

Fixes failure of fast/events/popup-blocked-from-fake-user-gesture.html

https://bugs.webkit.org/show_bug.cgi?id=47469

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::windowCloseRequested):
1:19 PM Changeset in webkit [69472] by Patrick Gansterer
  • 2 edits in trunk/JavaScriptCore

2010-10-10 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Use WTF::StringHasher in WTF::CaseFoldingHash
https://bugs.webkit.org/show_bug.cgi?id=46523

  • wtf/text/StringHash.h: (WTF::CaseFoldingHash::foldCase): (WTF::CaseFoldingHash::hash):
1:00 PM Changeset in webkit [69471] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-10 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Adam Barth.

commit-queue: Add EFL-EWS status bubble to Bugzilla, now that the
EFL-EWS bot is up and running.
https://bugs.webkit.org/show_bug.cgi?id=47277

  • QueueStatusServer/handlers/statusbubble.py:
12:48 PM Changeset in webkit [69470] by commit-queue@webkit.org
  • 5 edits in trunk

2010-10-10 Daniel Cheng <dcheng@chromium.org>

Reviewed by Adam Barth.

[chromium] Clipboard no longer accepts 'text' as a synonym for 'text/plain'
https://bugs.webkit.org/show_bug.cgi?id=47419

This was a regression introduced in r68807. Updated the layout test to
check for this case.

  • editing/pasteboard/dataTransfer-setData-getData-expected.txt:
  • editing/pasteboard/script-tests/dataTransfer-setData-getData.js: (runTest):

2010-10-10 Daniel Cheng <dcheng@chromium.org>

Reviewed by Adam Barth.

[chromium] Clipboard no longer accepts 'text' as a synonym for 'text/plain'
https://bugs.webkit.org/show_bug.cgi?id=47419

This was a regression introduced in r68807. mimeTypeText had the incorrect
value.

Test: editing/pasteboard/dataTransfer-setData-getData.html

  • platform/chromium/ClipboardMimeTypes.cpp:
12:46 PM Changeset in webkit [69469] by mihaip@chromium.org
  • 3 edits
    1 add in trunk/LayoutTests

2010-10-10 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

<a ping> tests are slow
https://bugs.webkit.org/show_bug.cgi?id=47431

The ping tests showed up as being flaky in Adam Barth's email; this
might just be due to them being on the slow side due to the 1 second
refresh in check-ping.php. We can instead switch to using file_exists
in a loop if we invalidate the file status cache. Running the three
ping tests with --iterations=10 now takes 4 seconds instead of 23.

This surfaces a race condition in image-load-in-unload-handler.html
(we don't start sending data till we get the ping, but unload handlers
(where the ping is sent) aren't run till we start getting data). Fixed
by adding a dummy page in between.

  • http/tests/navigation/resources/check-ping.php:
  • http/tests/navigation/image-load-in-unload-handler.html:
  • http/tests/navigation/resources/ping-redirect.html: Added.
10:44 AM Changeset in webkit [69468] by robert@webkit.org
  • 4 edits in trunk

2010-10-10 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Put all DRT-created pages in a page group

Unskip:

http/tests/security/frameNavigation/not-opener.html
http/tests/navigation/target-frame-from-window.html

https://bugs.webkit.org/show_bug.cgi?id=47469

  • platform/qt/Skipped:

2010-10-10 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Put all DRT-created pages in a page group

https://bugs.webkit.org/show_bug.cgi?id=47469

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::createWindow):
7:23 AM Changeset in webkit [69467] by tonikitoo@webkit.org
  • 5 edits in trunk

This reverts commit http://trac.webkit.org/changeset/69465

Debug statments that should not be committed.

7:14 AM Changeset in webkit [69466] by tonikitoo@webkit.org
  • 2 edits
    1 add
    2 deletes in trunk/LayoutTests

2010-10-10 Antonio Gomes <agomes@rim.com>

Reviewed by Andreas Kling.

editing/selection/extend-after-mouse-selection.html should useLayoutTestController::setEditingBehavior
https://bugs.webkit.org/show_bug.cgi?id=47468

Changed editing/selection/extend-after-mouse-selection.html to use the LayoutTestController::setEditingBehavior
machinary. It makes it possible to remove platform dependent test results by testing through all
platform-specific codepath's we have.

  • editing/selection/extend-after-mouse-selection.html:
  • platform/editing/selection/extend-after-mouse-selection-expected.txt: Added.
  • platform/mac/editing/selection/extend-after-mouse-selection-expected.txt: Removed.
  • platform/win/editing/selection/extend-after-mouse-selection-expected.txt: Removed.
7:14 AM Changeset in webkit [69465] by tonikitoo@webkit.org
  • 5 edits in trunk

tmp

Oct 9, 2010:

9:17 PM Changeset in webkit [69464] by abarth@webkit.org
  • 2 edits in trunk/BugsSite

2010-10-09 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Exception in committers-autocomplete in Firefox
https://bugs.webkit.org/show_bug.cgi?id=47456

Remove dependency on a WebKit-only quirk. IMHO, this quirk is bad for
the long-term health of the web, but that's a discussion for another
patch.

  • committers-autocomplete.js:
7:15 PM Changeset in webkit [69463] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-09 Eric Uhrhane <ericu@chromium.org>

Reviewed by Andreas Kling.

FileWriter sends write event instead of progress event
https://bugs.webkit.org/show_bug.cgi?id=47454

No new tests; FileWriter tests will be added shortly, but currently
there's no implementation capable of running them.

  • fileapi/FileWriter.cpp: (WebCore::FileWriter::didWrite):
4:56 PM Changeset in webkit [69462] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-10-09 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fast-path in Path::clear() for already empty paths
https://bugs.webkit.org/show_bug.cgi?id=47460

The only way to clear a QPainterPath is to assign QPainterPath() to it.
Avoid creating a temporary object etc if the path is already empty.

  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::clear):
4:18 PM Changeset in webkit [69461] by weinig@apple.com
  • 8 edits
    1 add in trunk

WKFrameGetFrameLoadState() returns kWKFrameLoadStateCommitted after the load has been stopped
<rdar://problem/8173667>
https://bugs.webkit.org/show_bug.cgi?id=47461

Reviewed by Dan Bernstein.

WebKit2:

API Test: WebKit2/FailedLoad

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didFailProvisionalLoad):
(WebKit::WebFrameProxy::didFailLoad):

  • UIProcess/WebFrameProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didFailProvisionalLoadForFrame):
(WebKit::WebPageProxy::didFailLoadForFrame):
Set the frame load state to LoadStateFinished for both didFailProvisionalLoadForFrame
and didFailLoadForFrame.

WebKitTools:

  • TestWebKitAPI/PlatformUtilities.h:
  • TestWebKitAPI/Test.h:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp: Added.

(TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/mac/PlatformUtilitiesMac.mm:

(TestWebKitAPI::Util::URLForNonExistentResource):
Adds a test for the frame load state after a failed provisional load. I wanted to test
the frame load state after a committed load failed, but I don't believe that is possible
to do without hooking up the http server to serve a long loading page.

2:58 PM Changeset in webkit [69460] by weinig@apple.com
  • 12 edits in trunk

Add WebKit2 version of runBeforeUnloadConfirmPanelWithMessage
<rdar://problem/8447690>
https://bugs.webkit.org/show_bug.cgi?id=47459

Reviewed by Dan Bernstein.

WebKit2:

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/qt/qwkpage.cpp:

(QWKPage::QWKPage):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setWindowFrame):
(WebKit::WebPageProxy::getWindowFrame):
(WebKit::WebPageProxy::canRunBeforeUnloadConfirmPanel):
(WebKit::WebPageProxy::runBeforeUnloadConfirmPanel):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::canRunBeforeUnloadConfirmPanel):
(WebKit::WebUIClient::runBeforeUnloadConfirmPanel):

  • UIProcess/WebUIClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::canRunBeforeUnloadConfirmPanel):
(WebKit::WebChromeClient::runBeforeUnloadConfirmPanel):
Pipe calls through to the UIProcess.

WebKitTools:

  • MiniBrowser/mac/BrowserWindowController.m:

(runBeforeUnloadConfirmPanel):
(-[BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/TestController.cpp:

(WTR::createOtherPage):
(WTR::TestController::initialize):

2:30 PM Changeset in webkit [69459] by commit-queue@webkit.org
  • 8 edits in trunk/WebKit/chromium

2010-10-09 Varun Jain <varunjain@chromium.org>

Reviewed by Darin Fisher.

Adding one method to the WebView interface: method to inform the
renderer to scroll the currently focused element into view, for
instance, when it is hidden due to window resizing.
Also adding methods to WebNode and WebElement to expose more
features of the underlying WebCore::Node.
https://bugs.webkit.org/show_bug.cgi?id=46296

  • public/WebElement.h:
  • public/WebNode.h:
  • public/WebView.h:
  • src/WebElement.h: (WebKit::WebElement::isTextFormControlElement):
  • src/WebNode.cpp: (WebKit::WebNode::isContentEditable):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::scrollFocusedNodeIntoView):
  • src/WebViewImpl.h:
1:59 PM Changeset in webkit [69458] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-10-09 Pratik Solanki <psolanki@apple.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=47445
Remove unused function WTFThreadData::initializeIdentifierTable()

  • wtf/WTFThreadData.h:
1:32 PM Changeset in webkit [69457] by weinig@apple.com
  • 31 edits
    1 add in trunk

Need implementation of ChromeClient windowRect related functions.
<rdar://problem/8469476>
https://bugs.webkit.org/show_bug.cgi?id=47386

Reviewed by Dan Bernstein.

WebKit2:

  • Shared/API/c/WKGeometry.h: Added.

Adds WKPoint, WKSize and WKRect structs.

  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toImpl):
(WebKit::toAPI):
Add conversion functions for WKRect.

  • Shared/WebCoreArgumentCoders.h:

Add encoding for FloatPoint, FloatSize and FloatRect.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::transformToDeviceSpace):
(WebKit::PageClientImpl::transformToUserSpace):

  • UIProcess/API/mac/WKView.mm:

(-[WKView _transformToDeviceSpace:]):
(-[WKView _transformToUserSpace:]):

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::transformToDeviceSpace):
(QWKPagePrivate::transformToUserSpace):
(QWKPage::QWKPage):

  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setWindowFrame):
(WebKit::WebPageProxy::getWindowFrame):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::setWindowFrame):
(WebKit::WebUIClient::windowFrame):

  • UIProcess/WebUIClient.h:
  • UIProcess/win/WebView.cpp:

(WebKit::WebView::setEditCommandState):
(WebKit::WebView::transformToDeviceSpace):
(WebKit::WebView::transformToUserSpace):

  • UIProcess/win/WebView.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::setWindowFrame):
(WebKit::WebChromeClient::windowFrame):
Pipe calls through to the UIProcess, and give ports a chance to transform
the rect (via the PageClient) before it is passed on.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:

Add new files.

WebKitTools:

  • MiniBrowser/mac/BrowserWindowController.m:

(getWindowFrame):
(setWindowFrame):
(-[BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/PlatformWebView.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::windowFrame):
(WTR::PlatformWebView::setWindowFrame):

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::windowFrame):
(WTR::PlatformWebView::setWindowFrame):

  • WebKitTestRunner/win/PlatformWebViewWin.cpp:

(WTR::PlatformWebView::windowFrame):
(WTR::PlatformWebView::setWindowFrame):

1:26 PM Changeset in webkit [69456] by rniwa@webkit.org
  • 10 edits in trunk/LayoutTests

2010-10-09 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed build fix.

Reverted changes to platform/*/editing that were accidently committed in r69453.

  • platform/chromium-win/editing/inserting/editable-html-element-expected.txt:
  • platform/chromium-win/editing/selection/editable-html-element-expected.txt:
  • platform/chromium-win/editing/selection/editable-links-expected.txt:
  • platform/chromium-win/editing/selection/focus_editable_html-expected.txt:
  • platform/chromium-win/editing/style/designmode-expected.txt:
  • platform/qt/editing/inserting/editable-html-element-expected.txt:
  • platform/qt/editing/selection/editable-html-element-expected.txt:
  • platform/qt/editing/selection/focus_editable_html-expected.txt:
  • platform/qt/editing/style/designmode-expected.txt:
1:21 PM Changeset in webkit [69455] by abarth@webkit.org
  • 1 edit
    12 adds in trunk/LayoutTests

2010-10-09 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

CSS: style attributes on closing tags gets applied to element
https://bugs.webkit.org/show_bug.cgi?id=14423

We fixed these bugs with the HTML5 parser. Go us.

  • fast/parser/stray-end-tags-with-attributes-001-expected.txt: Added.
  • fast/parser/stray-end-tags-with-attributes-001-quirks-expected.txt: Added.
  • fast/parser/stray-end-tags-with-attributes-001-quirks.html: Added.
  • fast/parser/stray-end-tags-with-attributes-001.html: Added.
  • fast/parser/stray-end-tags-with-attributes-002-alt-expected.txt: Added.
  • fast/parser/stray-end-tags-with-attributes-002-alt-quirks-expected.txt: Added.
  • fast/parser/stray-end-tags-with-attributes-002-alt-quirks.html: Added.
  • fast/parser/stray-end-tags-with-attributes-002-alt.html: Added.
  • fast/parser/stray-end-tags-with-attributes-002-expected.txt: Added.
  • fast/parser/stray-end-tags-with-attributes-002-quirk-expected.txt: Added.
  • fast/parser/stray-end-tags-with-attributes-002-quirk.html: Added.
  • fast/parser/stray-end-tags-with-attributes-002.html: Added.
12:57 PM Changeset in webkit [69454] by rniwa@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Unreviewed. Removed WebCore::ApplyStyleCommand::printStyle from WebCore/ChangeLog.

12:49 PM Changeset in webkit [69453] by rniwa@webkit.org
  • 13 edits
    2 adds in trunk

2010-10-08 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Redo in ReplaceNodeWithSpanCommand is broken
https://bugs.webkit.org/show_bug.cgi?id=47428

The bug was caused by ReplaceNodeWithSpanCommand's inheriting from CompositeEditCommand,
and ReplaceNodeWithSpanCommand's not implementing doReapply. Because ReplaceNodeWithSpanCommand's doApply
directly modifies DOM and does not use simple edit commands while CompositeEditCommand's doReapply
only calls reapply of compositing simple edit commands, ReplaceNodeWithSpanCommand's doReapply was no-op.

Fixed the bug by changing the base class of ReplaceNodeWithSpanCommand to SimpleEditCommand.
This allows ReplaceNodeWithSpanCommand's doReapply to call its doApply, which already supports redo operation.

Test: editing/undo/replace-by-span-then-remove.html

  • editing/ApplyStyleCommand.h: (WebCore::ApplyStyleCommand::printStyle):
  • editing/ReplaceNodeWithSpanCommand.cpp: (WebCore::ReplaceNodeWithSpanCommand::ReplaceNodeWithSpanCommand):
  • editing/ReplaceNodeWithSpanCommand.h:

2010-10-08 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Redo in ReplaceNodeWithSpanCommand is broken
https://bugs.webkit.org/show_bug.cgi?id=47428

Added a test to ensure replacing a node with span can be redone,
and doing so does not disrupt subsequent redo's.

  • editing/undo/replace-by-span-then-remove-expected.txt: Added.
  • editing/undo/replace-by-span-then-remove.html: Added.
11:36 AM Changeset in webkit [69452] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk

2010-10-09 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement subregion rendering in WebView when using gtk3
https://bugs.webkit.org/show_bug.cgi?id=47411

  • GNUmakefile.am:
  • platform/graphics/FloatRect.h:
  • platform/graphics/cairo/FloatRectCairo.cpp: Added. (WebCore::FloatRect::FloatRect): (WebCore::FloatRect::operator cairo_rectangle_t):
11:25 AM Changeset in webkit [69451] by robert@webkit.org
  • 1 edit
    8 adds in trunk/LayoutTests

2010-10-09 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix url conversion in QWebHistory

Add results for:

http/tests/navigation/error404-basic.html
http/tests/navigation/error404-goback.html
http/tests/navigation/error404-subframeload.html
http/tests/navigation/javascriptlink-frames.html
http/tests/navigation/postredirect-basic.html
http/tests/navigation/postredirect-frames.html
http/tests/navigation/postredirect-goback1.html

https://bugs.webkit.org/show_bug.cgi?id=47048

  • platform/qt/http/tests/navigation/error404-basic-expected.txt: Added.
  • platform/qt/http/tests/navigation/error404-goback-expected.txt: Added.
  • platform/qt/http/tests/navigation/error404-subframeload-expected.txt: Added.
  • platform/qt/http/tests/navigation/javascriptlink-frames-expected.txt: Added.
  • platform/qt/http/tests/navigation/postredirect-basic-expected.txt: Added.
  • platform/qt/http/tests/navigation/postredirect-frames-expected.txt: Added.
  • platform/qt/http/tests/navigation/postredirect-goback1-expected.txt: Added.
11:11 AM Changeset in webkit [69450] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-09 Kwang Yul Seo <skyul@company100.net>

Reviewed by Andreas Kling.

Add ENABLE(ACCELERATED_2D_CANVAS) guard for m_uploadTexture
https://bugs.webkit.org/show_bug.cgi?id=47114

PlatformContextSkia's m_uploadTexture is used only in code guarded with ENABLE(ACCELERATED_2D_CANVAS).

  • platform/graphics/skia/PlatformContextSkia.h:
8:32 AM Changeset in webkit [69449] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2010-10-09 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Use WTF::StringHasher for hashing MappedAttributeKey
https://bugs.webkit.org/show_bug.cgi?id=46516

  • dom/StyledElement.cpp: (WebCore::MappedAttributeHash::hash):
8:24 AM Changeset in webkit [69448] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-10-09 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Non-rectangular buttons have a square background behind them
https://bugs.webkit.org/show_bug.cgi?id=23569

Remove some code which was clearing pieces of the GdkDrawable if it was
currently mapped to a window. In our case it is unnecessary, because the
platform-independent parts of the render have already cleared this section
if it is needed.

Mozilla must not trip this code path, which means they are probably rendering
most often to a non-mapped GdkPixmap.

No new tests as some themed rendering is covered by existing tests that
render buttons. This particular bug is very hard to test as it only appears
with certain GTK+ themes and we currently have no mechanism to test different
themes in DRT.

  • platform/gtk/gtk2drawing.c: (moz_gtk_button_paint): Remove unnecessary code.
8:17 AM Changeset in webkit [69447] by Martin Robinson
  • 3 edits
    2 adds in trunk

2010-10-09 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Slider padding translate into a larger track rect
https://bugs.webkit.org/show_bug.cgi?id=47435

Added a pixel test result for this issue.

  • platform/gtk/fast/forms/slider-padding-expected.checksum: Added.
  • platform/gtk/fast/forms/slider-padding-expected.png: Added.

2010-10-09 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Slider padding translate into a larger track rect
https://bugs.webkit.org/show_bug.cgi?id=47435

Instead of painting the track rectangle for ranges onto the entire RenderBox
rectangle, simply paint it on the content rectangle. This prevents misrendering
sliders with padding.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::paintSliderTrack): Paint onto the absoluteContentRect of the slider instead of the entire area (which includes padding).
6:49 AM Changeset in webkit [69446] by tkent@chromium.org
  • 3 edits in trunk/WebCore

Unreviewed, trivial regression fix for r69445.

RangeInputType::supportsRequired() should return false.
https://bugs.webkit.org/show_bug.cgi?id=47405

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::supportsRequired):

  • html/RangeInputType.h:
6:27 AM Changeset in webkit [69445] by tkent@chromium.org
  • 36 edits in trunk/WebCore

Refactor HTMLInputElement: Move typeMismatch(), valueMissing(),
isRequiredFormControl(), and recalcWillValidate()
https://bugs.webkit.org/show_bug.cgi?id=47405

Reviewed by Dimitri Glazkov.

Also make checkedRadioButtons() an inline member function of
HTMLInputElement in order that RadioInputType can use it.

  • html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::typeMismatchFor):
(WebCore::BaseDateAndTimeInputType::typeMismatch):

  • html/BaseDateAndTimeInputType.h:
  • html/ButtonInputType.cpp:

(WebCore::ButtonInputType::supportsValidation):

  • html/ButtonInputType.h:
  • html/CheckboxInputType.cpp:

(WebCore::CheckboxInputType::valueMissing):

  • html/CheckboxInputType.h:
  • html/ColorInputType.cpp:

(WebCore::isValidColorString):
(WebCore::ColorInputType::typeMismatchFor):
(WebCore::ColorInputType::typeMismatch):
(WebCore::ColorInputType::supportsRequired):

  • html/ColorInputType.h:
  • html/EmailInputType.cpp:

(WebCore::isValidEmailAddress):
(WebCore::EmailInputType::typeMismatchFor):
(WebCore::EmailInputType::typeMismatch):

  • html/EmailInputType.h:
  • html/FileInputType.cpp:

(WebCore::FileInputType::valueMissing):

  • html/FileInputType.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateCheckedRadioButtons):
(WebCore::HTMLInputElement::isValidValue):
(WebCore::HTMLInputElement::typeMismatch):
(WebCore::HTMLInputElement::valueMissing):
(WebCore::HTMLInputElement::isKeyboardFocusable):
(WebCore::HTMLInputElement::updateType):
(WebCore::HTMLInputElement::parseMappedAttribute):
(WebCore::HTMLInputElement::setChecked):
(WebCore::HTMLInputElement::preDispatchEventHandler):
(WebCore::HTMLInputElement::isRequiredFormControl):
(WebCore::HTMLInputElement::recalcWillValidate):

  • html/HTMLInputElement.h:

(WebCore::HTMLInputElement::checkedRadioButtons):

  • html/HiddenInputType.cpp:

(WebCore::HiddenInputType::supportsValidation):

  • html/HiddenInputType.h:
  • html/ImageInputType.cpp:

(WebCore::ImageInputType::supportsValidation):

  • html/ImageInputType.h:
  • html/InputType.cpp:

(WebCore::InputType::supportsValidation):
(WebCore::InputType::typeMismatchFor):
(WebCore::InputType::typeMismatch):
(WebCore::InputType::supportsRequired):
(WebCore::InputType::valueMissing):

  • html/InputType.h:
  • html/IsIndexInputType.cpp:

(WebCore::IsIndexInputType::supportsRequired):

  • html/IsIndexInputType.h:
  • html/NumberInputType.cpp:

(WebCore::NumberInputType::typeMismatchFor):
(WebCore::NumberInputType::typeMismatch):

  • html/NumberInputType.h:
  • html/RadioInputType.cpp:

(WebCore::RadioInputType::valueMissing):

  • html/RadioInputType.h:
  • html/ResetInputType.cpp:

(WebCore::ResetInputType::supportsValidation):

  • html/ResetInputType.h:
  • html/SubmitInputType.cpp:

(WebCore::SubmitInputType::supportsValidation):

  • html/SubmitInputType.h:
  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::valueMissing):

  • html/TextFieldInputType.h:
  • html/URLInputType.cpp:

(WebCore::URLInputType::typeMismatchFor):
(WebCore::URLInputType::typeMismatch):

  • html/URLInputType.h:
  • html/ValidityState.cpp:

(WebCore::ValidityState::typeMismatch):

3:28 AM Changeset in webkit [69444] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-10-09 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Removed unused callback in webkitwebview
https://bugs.webkit.org/show_bug.cgi?id=47092

In webkit_web_view_forward_context_menu_event() a callback is
connected for the destroy signal of the popup menu, however we
reuse the same menu always, holding a ref to it, so it's not
destroyed when withdrawn by the user.

  • webkit/webkitwebview.cpp: (webkit_web_view_forward_context_menu_event):
1:39 AM Changeset in webkit [69443] by Csaba Osztrogonác
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed fix after r69413.

[Qt] Add platform specific expected result, because this test passes.
Compared to Mac png files and Mac expected files.

  • platform/qt/svg/custom/gradient-with-1d-boundingbox-expected.txt: Added.
12:11 AM Changeset in webkit [69442] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-09 Pratik Solanki <psolanki@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=47450
Crash in WebCore::SocketStreamHandle::chooseProxyFromArray because proxyArray passed is nil
<rdar://problem/8244376>

  • platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::chooseProxyFromArray): If proxyArray is NULL, return early to avoid crash.

Oct 8, 2010:

10:33 PM Changeset in webkit [69441] by Joseph Pecoraro
  • 1 edit
    1 move in trunk/LayoutTests

2010-10-08 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Dan Bernstein.

Web Inspector: test that uncaught exceptions have stack trace when inspector is open
https://bugs.webkit.org/show_bug.cgi?id=47250

Check in default expected results for the test added in r69190:
inspector/console-uncaught-exception.html

  • inspector/console-uncaught-exception-expected.txt: Renamed from LayoutTests/platform/gtk/inspector/console-uncaught-exception-expected.txt.
7:30 PM Changeset in webkit [69440] by crogers@google.com
  • 1 edit
    2 adds in trunk/WebCore

2010-10-08 Chris Rogers <crogers@google.com>

Reviewed by James Robinson.

Add HRTFPanner files
https://bugs.webkit.org/show_bug.cgi?id=46299

No new tests since audio API is not yet implemented.

  • platform/audio/HRTFPanner.cpp: Added. (WebCore::HRTFPanner::HRTFPanner): (WebCore::HRTFPanner::~HRTFPanner): (WebCore::HRTFPanner::fftSizeForSampleRate): (WebCore::HRTFPanner::reset): (WebCore::wrapDistance): (WebCore::HRTFPanner::calculateDesiredAzimuthIndexAndBlend): (WebCore::HRTFPanner::pan):
  • platform/audio/HRTFPanner.h: Added. (WebCore::HRTFPanner::fftSize): (WebCore::HRTFPanner::sampleRate):
7:21 PM Changeset in webkit [69439] by Martin Robinson
  • 2 edits
    1 add in trunk/LayoutTests

2010-10-08 Martin Robinson <mrobinson@igalia.com>

Skip more tests which show differences between i386 and x86_64. Also
add a platform-specific baseline for one test.

  • platform/gtk/Skipped:
  • platform/gtk/svg/custom/gradient-with-1d-boundingbox-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/custom/gradient-with-1d-boundingbox-expected.txt.
7:07 PM Changeset in webkit [69438] by ajwong@chromium.org
  • 49 edits
    80 adds
    3 deletes in trunk/LayoutTests

[chromium] Unreviewed. Build fix.

New baselines for bunches of SVG tests. Text formatting changed
in the render tree dump output for precision of width/height
arguments.

Added new baselines for some new tests.

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-30-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png:
  • platform/chromium-linux/svg/carto.net/selectionlist-expected.checksum:
  • platform/chromium-linux/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-linux/svg/css/composite-shadow-example-expected.checksum: Added.
  • platform/chromium-linux/svg/css/composite-shadow-example-expected.png: Added.
  • platform/chromium-linux/svg/css/composite-shadow-with-opacity-expected.checksum: Added.
  • platform/chromium-linux/svg/css/composite-shadow-with-opacity-expected.png: Added.
  • platform/chromium-linux/svg/custom/dominant-baseline-hanging-expected.checksum:
  • platform/chromium-linux/svg/custom/dominant-baseline-hanging-expected.png:
  • platform/chromium-linux/svg/custom/gradient-with-1d-boundingbox-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/gradient-with-1d-boundingbox-expected.png: Added.
  • platform/chromium-linux/svg/custom/image-small-width-height-expected.checksum:
  • platform/chromium-linux/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-linux/svg/custom/invalid-fill-expected.checksum:
  • platform/chromium-linux/svg/custom/invalid-fill-expected.png:
  • platform/chromium-linux/svg/custom/invalid-fill-hex-expected.checksum:
  • platform/chromium-linux/svg/custom/invalid-fill-hex-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png: Added.
  • platform/chromium-mac/fast/css-generated-content/malformed-url-expected.txt: Added.
  • platform/chromium-mac/fast/repaint/moving-shadow-on-container-expected.checksum:
  • platform/chromium-mac/fast/repaint/moving-shadow-on-container-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt: Removed.
  • platform/chromium-mac/svg/css/composite-shadow-example-expected.checksum: Added.
  • platform/chromium-mac/svg/css/composite-shadow-example-expected.png: Added.
  • platform/chromium-mac/svg/css/composite-shadow-with-opacity-expected.checksum: Added.
  • platform/chromium-mac/svg/css/composite-shadow-with-opacity-expected.png: Added.
  • platform/chromium-mac/svg/custom/clip-path-referencing-use2-expected.txt:
  • platform/chromium-mac/svg/custom/dominant-baseline-hanging-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/dominant-baseline-hanging-expected.png: Removed.
  • platform/chromium-mac/svg/custom/missing-xlink-expected.txt:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.txt: Added.
  • platform/chromium-win/fast/css-generated-content/malformed-url-expected.txt: Added.
  • platform/chromium-win/fast/repaint/repaint-svg-after-style-change-expected.txt: Copied from LayoutTests/platform/qt/fast/repaint/repaint-svg-after-style-change-expected.txt.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-30-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt:
  • platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
  • platform/chromium-win/svg/batik/text/textLength-expected.txt:
  • platform/chromium-win/svg/carto.net/button-expected.txt:
  • platform/chromium-win/svg/carto.net/colourpicker-expected.txt:
  • platform/chromium-win/svg/carto.net/combobox-expected.txt:
  • platform/chromium-win/svg/carto.net/selectionlist-expected.checksum:
  • platform/chromium-win/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-win/svg/css/composite-shadow-example-expected.checksum: Added.
  • platform/chromium-win/svg/css/composite-shadow-example-expected.png: Added.
  • platform/chromium-win/svg/css/composite-shadow-with-opacity-expected.checksum: Added.
  • platform/chromium-win/svg/css/composite-shadow-with-opacity-expected.png: Added.
  • platform/chromium-win/svg/custom/clip-path-referencing-use2-expected.txt:
  • platform/chromium-win/svg/custom/dominant-baseline-hanging-expected.checksum:
  • platform/chromium-win/svg/custom/dominant-baseline-hanging-expected.png:
  • platform/chromium-win/svg/custom/dominant-baseline-hanging-expected.txt:
  • platform/chromium-win/svg/custom/gradient-with-1d-boundingbox-expected.checksum: Added.
  • platform/chromium-win/svg/custom/gradient-with-1d-boundingbox-expected.png: Added.
  • platform/chromium-win/svg/custom/gradient-with-1d-boundingbox-expected.txt: Added.
  • platform/chromium-win/svg/custom/image-small-width-height-expected.checksum:
  • platform/chromium-win/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-win/svg/custom/invalid-fill-expected.checksum:
  • platform/chromium-win/svg/custom/invalid-fill-expected.png:
  • platform/chromium-win/svg/custom/invalid-fill-expected.txt:
  • platform/chromium-win/svg/custom/invalid-fill-hex-expected.checksum:
  • platform/chromium-win/svg/custom/invalid-fill-hex-expected.png:
  • platform/chromium-win/svg/custom/invalid-fill-hex-expected.txt:
  • platform/chromium-win/svg/custom/path-bad-data-expected.txt:
  • platform/chromium-win/svg/custom/use-property-changes-through-svg-dom-expected.txt:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.txt: Added.
  • platform/chromium-win/svg/hixie/error/012-expected.txt:
  • platform/chromium-win/svg/transforms/animated-path-inside-transformed-html-expected.txt:
  • platform/chromium/test_expectations.txt:
7:00 PM Changeset in webkit [69437] by commit-queue@webkit.org
  • 95 edits in trunk/WebCore

2010-10-08 James Robinson <jamesr@chromium.org>

Reviewed by Adam Barth.

Avoid inlining large and/or virtual functions in widely included header files
https://bugs.webkit.org/show_bug.cgi?id=47230

Functions with very large bodies should not be included in widely included header files.
This results in the function's code ending up included in hundreds of object files that
the linker has to discard, at a cost of linker memory use, link time, and disk space. This
is a particular problem in the Chromium windows build where MSVC often exhausts its 32-bit
virtual address space and completely fails to link.

This patch moves function definitions from the .h to the corresponding .cpp when the function
is large and not a candidate for inlining either because it is virtual or because its size is
above any reasonable compiler's threshhold for inlining. The most common case by far in this
patch is changing a class' implicitly defined destructor to an explicitly declared d'tor in
the header and an explicitly defined d'tor in the .cpp. This is important since many of our
container and utility classes (especially Vector, String, and HashSet) have quite large
destructors.

This patch removes 22.4MB of object file size in a debug 64 bit compile.

  • css/CSSBorderImageValue.cpp: (WebCore::CSSBorderImageValue::~CSSBorderImageValue):
  • css/CSSBorderImageValue.h:
  • css/CSSFontFaceSrcValue.cpp: (WebCore::CSSFontFaceSrcValue::~CSSFontFaceSrcValue):
  • css/CSSFontFaceSrcValue.h:
  • css/CSSFunctionValue.h:
  • dom/BeforeTextInsertedEvent.cpp: (WebCore::BeforeTextInsertedEvent::~BeforeTextInsertedEvent):
  • dom/BeforeTextInsertedEvent.h:
  • dom/BeforeUnloadEvent.cpp: (WebCore::BeforeUnloadEvent::~BeforeUnloadEvent):
  • dom/BeforeUnloadEvent.h:
  • dom/ClassNodeList.h:
  • dom/ClipboardEvent.cpp: (WebCore::ClipboardEvent::~ClipboardEvent):
  • dom/ClipboardEvent.h:
  • dom/CustomEvent.cpp: (WebCore::CustomEvent::~CustomEvent):
  • dom/CustomEvent.h:
  • dom/Element.cpp:
  • dom/Element.h:
  • dom/EventTarget.cpp: (WebCore::EventTargetData::EventTargetData):
  • dom/EventTarget.h:
  • dom/InputElement.cpp: (WebCore::InputElementData::~InputElementData):
  • dom/InputElement.h:
  • dom/MutationEvent.cpp: (WebCore::MutationEvent::~MutationEvent):
  • dom/MutationEvent.h:
  • dom/Node.cpp: (WebCore::Node::refEventTarget): (WebCore::Node::derefEventTarget):
  • dom/Node.h:
  • dom/OptionElement.cpp: (WebCore::OptionElementData::~OptionElementData):
  • dom/OptionElement.h:
  • dom/PopStateEvent.cpp: (WebCore::PopStateEvent::~PopStateEvent):
  • dom/PopStateEvent.h:
  • dom/QualifiedName.cpp: (WebCore::QualifiedName::~QualifiedName):
  • dom/QualifiedName.h:
  • dom/SelectElement.cpp: (WebCore::SelectElementData::~SelectElementData):
  • dom/SelectElement.h:
  • dom/StaticHashSetNodeList.cpp: (WebCore::StaticHashSetNodeList::StaticHashSetNodeList): (WebCore::StaticHashSetNodeList::~StaticHashSetNodeList):
  • dom/StaticHashSetNodeList.h:
  • dom/StyleElement.cpp: (WebCore::StyleElement::~StyleElement):
  • dom/StyleElement.h:
  • dom/TouchEvent.cpp: (WebCore::TouchEvent::TouchEvent): (WebCore::TouchEvent::~TouchEvent):
  • dom/TouchEvent.h:
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::~CompositeEditCommand):
  • editing/CompositeEditCommand.h:
  • editing/TextIterator.cpp: (WebCore::BitStack::~BitStack): (WebCore::TextIterator::~TextIterator): (WebCore::WordAwareIterator::~WordAwareIterator):
  • editing/TextIterator.h:
  • inspector/InspectorValues.cpp: (WebCore::InspectorObject::~InspectorObject): (WebCore::InspectorObject::InspectorObject): (WebCore::InspectorArray::~InspectorArray): (WebCore::InspectorArray::InspectorArray):
  • inspector/InspectorValues.h:
  • loader/CachedResource.cpp: (WebCore::CachedResource::registerHandle): (WebCore::CachedResource::unregisterHandle):
  • loader/CachedResource.h:
  • platform/network/HTTPHeaderMap.cpp: (WebCore::HTTPHeaderMap::HTTPHeaderMap): (WebCore::HTTPHeaderMap::~HTTPHeaderMap): (WebCore::HTTPHeaderMap::get): (WebCore::HTTPHeaderMap::add):
  • platform/network/HTTPHeaderMap.h:
  • rendering/RenderApplet.cpp: (WebCore::RenderApplet::~RenderApplet):
  • rendering/RenderApplet.h:
  • rendering/RenderButton.cpp: (WebCore::RenderButton::~RenderButton):
  • rendering/RenderButton.h:
  • rendering/RenderCounter.cpp: (WebCore::RenderCounter::~RenderCounter):
  • rendering/RenderCounter.h:
  • rendering/RenderFieldset.h:
  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::~RenderForeignObject):
  • rendering/RenderForeignObject.h:
  • rendering/RenderFrame.h:
  • rendering/RenderFrameBase.h:
  • rendering/RenderHTMLCanvas.h:
  • rendering/RenderIFrame.h:
  • rendering/RenderInline.h:
  • rendering/RenderListItem.h:
  • rendering/RenderMarquee.cpp: (WebCore::RenderMarquee::~RenderMarquee):
  • rendering/RenderMarquee.h:
  • rendering/RenderPath.cpp: (WebCore::RenderPath::~RenderPath):
  • rendering/RenderPath.h:
  • rendering/RenderSVGBlock.h:
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::~RenderSVGContainer):
  • rendering/RenderSVGContainer.h:
  • rendering/RenderSVGHiddenContainer.h:
  • rendering/RenderSVGInline.h:
  • rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::~RenderSVGInlineText):
  • rendering/RenderSVGInlineText.h:
  • rendering/RenderSVGModelObject.h:
  • rendering/RenderSVGResourceFilterPrimitive.h:
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::~RenderSVGRoot):
  • rendering/RenderSVGRoot.h:
  • rendering/RenderSVGTSpan.h:
  • rendering/RenderSVGText.h:
  • rendering/RenderSVGTextPath.h:
  • rendering/RenderSVGTransformableContainer.h:
  • rendering/RenderSVGViewportContainer.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::~RenderTable):
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.h:
  • rendering/RenderTableCol.h:
  • rendering/RenderTableRow.h:
  • rendering/RenderTextFragment.cpp: (WebCore::RenderTextFragment::~RenderTextFragment):
  • rendering/RenderTextFragment.h:
  • rendering/RenderWordBreak.h:
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::~SVGStyledElement):
  • svg/SVGStyledElement.h:
  • svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::~SVGStyledTransformableElement):
  • svg/SVGStyledTransformableElement.h:
  • xml/XPathParser.cpp: (WebCore::XPath::Parser::~Parser):
  • xml/XPathParser.h:
6:58 PM Changeset in webkit [69436] by Martin Robinson
  • 7 edits in trunk

2010-10-08 Martin Robinson <mrobinson@igalia.com>

Reviewed by Daniel Bates.

[GTK] Fails /LayoutTests/fast/css/button-height.html
https://bugs.webkit.org/show_bug.cgi?id=33936

Unskip a test that is now passing and update baselines for
other tests.

  • platform/gtk/Skipped: Update skipped list.
  • platform/gtk/fast/forms/box-shadow-override-expected.txt:
  • platform/gtk/fast/forms/button-style-color-expected.txt:
  • platform/gtk/fast/forms/input-button-sizes-expected.txt:

2010-10-08 Martin Robinson <mrobinson@igalia.com>

Reviewed by Daniel Bates.

[GTK] Fails /LayoutTests/fast/css/button-height.html
https://bugs.webkit.org/show_bug.cgi?id=33936

GTK buttons honor height property set via CSS. The code for the method
adjustButtonStyle originates from the original GTK+ theme drawing code
and is clearly just a copy-paste from the Safari theme drawing code. The
Safari theme drawing code does quite a bit of work to ensure that button
fonts are consistent with the system theme, which is not something the GTK+
port does.

This change brings the method more in line with the Chromium port, which
allows CSS to style buttons, only overriding the line-height property,
which is required for layout tests to pass.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::adjustButtonStyle): No longer override most CSS properties for button styling.
6:35 PM Changeset in webkit [69435] by andreip@google.com
  • 2 edits in trunk/WebKit/chromium

2010-10-08 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

[Chromium] IDBFactory::open only works in single process mode.
https://bugs.webkit.org/show_bug.cgi?id=47444

  • public/WebIDBFactory.h: (WebKit::WebIDBFactory::open):
5:18 PM Changeset in webkit [69434] by abarth@webkit.org
  • 2 edits in trunk/BugsSite

2010-10-08 Adam Barth <abarth@webkit.org>

Reviewed by Oliver Hunt.

Bugmail for new attachments should link to the reviewtool
https://bugs.webkit.org/show_bug.cgi?id=47440

As requested by olliej himself. This patch was constructed by pure
reason. I have no way to actually run this code.

  • Bugzilla/BugMail.pm:
5:11 PM Changeset in webkit [69433] by ajwong@chromium.org
  • 2 edits in trunk/LayoutTests

[Unrevied] Chromium build fix.

Marking more tests as failing.

  • platform/chromium/test_expectations.txt:
5:01 PM Changeset in webkit [69432] by mihaip@chromium.org
  • 4 edits
    3 adds in trunk

2010-10-08 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

popstate events are lost when network connection is in progress
https://bugs.webkit.org/show_bug.cgi?id=42940

Add test case where we have an image request that never finishes while
using pushState and history.back().

  • http/tests/history/popstate-fires-with-pending-requests-expected.txt: Added.
  • http/tests/history/popstate-fires-with-pending-requests.html: Added.
  • http/tests/history/resources/slow-image.php: Added.

2010-10-08 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

popstate events are lost when network connection is in progress
https://bugs.webkit.org/show_bug.cgi?id=42940

Instead of checking FrameLoader::isComplete() (which isn't true if the
document's resource loader has requests outstanding), check that the
document's readyState is complete, as the spec says.

Test: http/tests/history/popstate-fires-with-pending-requests.html

  • dom/Document.cpp: (WebCore::Document::statePopped):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::didBeginDocument): Added call to set readyState to Loading earlier. Otherwise, readyState's initial value is Complete, and we only set it to Loading in Document::implicitOpen (which is called after FrameLoader::didBeginDocument by DocumentWriter::begin), so we could end up in Document::statePopped and have the readyState be Complete, even if we hadn't even begin loading the document.
4:13 PM Changeset in webkit [69431] by commit-queue@webkit.org
  • 5 edits in trunk/WebCore

2010-10-08 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Update ReadableDataObject/WritableDataObject interface for ChromiumDataObject change
https://bugs.webkit.org/show_bug.cgi?id=47394

Minor cleanup--these classes have suffered from bit rot since they aren't
actively used at the moment. The three main changes are to:
1) Condense getURL, setURL, getHTML, setHTML, urlTitle, htmlBaseUrl,

setUrlTitle, and sethtmlBaseUrl into setters/getters for just the URL
title and HTML base URL.

2) Use Clipboard::ClipboardType instead of a bool.
3) Remove the use of virtuals, as they are no longer needed..

  • platform/chromium/ReadableDataObject.cpp: (WebCore::clipboardBuffer): (WebCore::ReadableDataObject::create): (WebCore::ReadableDataObject::ReadableDataObject): (WebCore::ReadableDataObject::getData): (WebCore::ReadableDataObject::urlTitle): renamed from getURL (WebCore::ReadableDataObject::htmlBaseUrl): renamed from getHTML (WebCore::ReadableDataObject::containsFilenames): (WebCore::ReadableDataObject::filenames): (WebCore::ReadableDataObject::ensureTypeCacheInitialized):
  • platform/chromium/ReadableDataObject.h:
  • platform/chromium/WritableDataObject.cpp: (WebCore::WritableDataObject::create): (WebCore::WritableDataObject::WritableDataObject): (WebCore::WritableDataObject::setData):
  • platform/chromium/WritableDataObject.h: (WebCore::WritableDataObject::setUrlTitle): renamed from setURL (WebCore::WritableDataObject::setHtmlBaseUrl): renamed from setHTML (WebCore::WritableDataObject::dataMap): (WebCore::WritableDataObject::urlTitle): (WebCore::WritableDataObject::htmlBaseURL): (WebCore::WritableDataObject::fileExtension): (WebCore::WritableDataObject::fileContentFilename): (WebCore::WritableDataObject::fileContent): (WebCore::WritableDataObject::setFileExtension): (WebCore::WritableDataObject::setFileContentFilename): (WebCore::WritableDataObject::setFileContent):
4:12 PM Changeset in webkit [69430] by inferno@chromium.org
  • 4 edits
    2 deletes in trunk

2010-10-08 Abhishek Arya <inferno@chromium.org>

Unreviewed, rolling out r69360.
http://trac.webkit.org/changeset/69360
https://bugs.webkit.org/show_bug.cgi?id=46921

Test still crashing on chromium test_shell

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::renderFallbackContent):

2010-10-08 Abhishek Arya <inferno@chromium.org>

Unreviewed, rolling out r69360.
http://trac.webkit.org/changeset/69360
https://bugs.webkit.org/show_bug.cgi?id=46921

Testcase still crashing on chromium test_shell

  • fast/html/object-image-nested-fallback-expected.txt: Removed.
  • fast/html/object-image-nested-fallback.html: Removed.
4:10 PM Changeset in webkit [69429] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-08 Adam Barth <abarth@webkit.org>

Unreviewed (Eric is on vacation in this change is trivial).

Add a "clean" command to webkit-patch to clean the working directory
https://bugs.webkit.org/show_bug.cgi?id=47436

This command is useful when using SVN because "svn revert" leaves
unversioned files behind.

  • Scripts/webkitpy/tool/commands/download.py:
3:53 PM Changeset in webkit [69428] by ajwong@chromium.org
  • 2 edits in trunk/LayoutTests

[Unreviewed] Chromium build fix.

Still trying to get it all green after the big rebaseline.

  • platform/chromium/test_expectations.txt:
3:32 PM Changeset in webkit [69427] by commit-queue@webkit.org
  • 3 edits
    8 deletes in trunk

2010-10-08 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r68574.
http://trac.webkit.org/changeset/68574
https://bugs.webkit.org/show_bug.cgi?id=47433

[chromium] Breaks partial repaint of images while scrolling
(Requested by jamesr on #webkit).

  • platform/chromium-linux/svg/custom/image-rescale-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/image-rescale-expected.png: Removed.
  • platform/chromium-linux/svg/custom/image-rescale-expected.txt: Removed.
  • platform/mac/svg/custom/image-rescale-expected.checksum: Removed.
  • platform/mac/svg/custom/image-rescale-expected.png: Removed.
  • platform/mac/svg/custom/image-rescale-expected.txt: Removed.
  • svg/custom/image-rescale.svg: Removed.
  • svg/custom/resources/image-rescale.jpg: Removed.

2010-10-08 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r68574.
http://trac.webkit.org/changeset/68574
https://bugs.webkit.org/show_bug.cgi?id=47433

[chromium] Breaks partial repaint of images while scrolling
(Requested by jamesr on #webkit).

  • platform/graphics/skia/ImageSkia.cpp: (WebCore::computeResamplingMode): (WebCore::drawResampledBitmap):
3:23 PM Changeset in webkit [69426] by aestes@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix the ChangeLog entry of a previous commit that blamed the wrong SVN revision for a regression.

3:19 PM Changeset in webkit [69425] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-10-08 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Dynamically added elements should take priority in getElementById
https://bugs.webkit.org/show_bug.cgi?id=9354

Our behavior now appears to match Firefox. This test just documents
our behavior.

  • fast/dom/multiple-ids-expected.txt: Added.
  • fast/dom/multiple-ids.html: Added.
3:14 PM Changeset in webkit [69424] by mrowe@apple.com
  • 3 edits
    2 adds in tags/Safari-534.9.1

Merge r69423.

2:57 PM Changeset in webkit [69423] by aestes@apple.com
  • 3 edits
    2 adds in trunk

2010-10-08 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

REGRESSION (r66599): Crash when using CSS content and -webkit-mask-box-image properties containing cached images.
https://bugs.webkit.org/show_bug.cgi?id=47430

Test: fast/replaced/css-content-and-webkit-mask-box-image-crash.html

  • rendering/RenderImage.cpp: (WebCore::RenderImage::imageChanged): imageChanged() can be called prior to m_imageResource being set. The appropriate thing to do in this case is to return early. (WebCore::RenderImage::notifyFinished): Ditto.

2010-10-08 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

REGRESSION (r66599): Crash when using CSS content and -webkit-mask-box-image properties containing cached images.
https://bugs.webkit.org/show_bug.cgi?id=47430

  • fast/replaced/css-content-and-webkit-mask-box-image-crash-expected.txt: Added.
  • fast/replaced/css-content-and-webkit-mask-box-image-crash.html: Added.
2:32 PM Changeset in webkit [69422] by msaboff@apple.com
  • 5 edits in trunk

2010-10-08 Michael Saboff <msaboff@apple.com>

Reviewed by Darin Adler.

Added check to start of subexpression being positive before using
subexpression in replacement.
https://bugs.webkit.org/show_bug.cgi?id=47324

  • runtime/StringPrototype.cpp: (JSC::substituteBackreferencesSlow):

2010-10-08 Michael Saboff <msaboff@apple.com>

Reviewed by Darin Adler.

Added test case to verify subexpression that didn't match is not
included in replacement.
https://bugs.webkit.org/show_bug.cgi?id=47324

  • fast/js/script-tests/string-replace-3.js:
  • fast/js/string-replace-3-expected.txt:
2:28 PM Changeset in webkit [69421] by andreip@google.com
  • 17 edits
    2 adds in trunk

2010-10-08 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

IndexedDB does not have a quota mechanism.
https://bugs.webkit.org/show_bug.cgi?id=47389

  • storage/indexeddb/database-quota-expected.txt: Added.
  • storage/indexeddb/database-quota.html: Added.

2010-10-08 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

IndexedDB does not have a quota mechanism.
https://bugs.webkit.org/show_bug.cgi?id=47389

Test: storage/indexeddb/database-quota.html

Add a simple mechanism for enforcing a maximum size
for each origin using IndexedDB. Note that this depends
on having one SQLite database file per origin, which is
addressed in a separate patch.

  • page/GroupSettings.cpp: (WebCore::GroupSettings::GroupSettings): (WebCore::GroupSettings::setIndexedDBQuotaBytes):
  • page/GroupSettings.h: (WebCore::GroupSettings::indexedDBQuotaBytes):
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::createObjectStore): (WebCore::IDBDatabaseBackendImpl::createObjectStoreInternal): (WebCore::IDBDatabaseBackendImpl::removeObjectStore): (WebCore::IDBDatabaseBackendImpl::setVersionInternal):
  • storage/IDBFactory.cpp: (WebCore::IDBFactory::open):
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::openSQLiteDatabase): (WebCore::IDBFactoryBackendImpl::open):
  • storage/IDBFactoryBackendImpl.h:
  • storage/IDBFactoryBackendInterface.h:
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::putObjectStoreData): (WebCore::putIndexData): (WebCore::IDBObjectStoreBackendImpl::put): (WebCore::IDBObjectStoreBackendImpl::putInternal): (WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
  • storage/IDBObjectStoreBackendImpl.h:

2010-10-08 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

IndexedDB does not have a quota mechanism.
https://bugs.webkit.org/show_bug.cgi?id=47389

  • public/WebIDBFactory.h: (WebKit::WebIDBFactory::open):
  • src/IDBFactoryBackendProxy.cpp: (WebCore::IDBFactoryBackendProxy::open):
  • src/IDBFactoryBackendProxy.h:
  • src/WebIDBFactoryImpl.cpp: (WebKit::WebIDBFactoryImpl::open):
  • src/WebIDBFactoryImpl.h:
2:17 PM Changeset in webkit [69420] by commit-queue@webkit.org
  • 7 edits
    3 adds in trunk

2010-10-08 Gavin Peters <gavinp@chromium.org>

Reviewed by Adam Barth.

Output X-Purpose header for prefetch requests
https://bugs.webkit.org/show_bug.cgi?id=46529

  • http/tests/misc/prefetch-purpose-expected.txt: Added.
  • http/tests/misc/prefetch-purpose.html: Added.
  • http/tests/misc/resources/prefetch-purpose.php: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2010-10-08 Gavin Peters <gavinp@chromium.org>

Reviewed by Adam Barth.

Output X-Purpose header for prefetch requests
https://bugs.webkit.org/show_bug.cgi?id=46529

Test: http/tests/misc/prefetch-purpose.html

  • loader/loader.cpp: (WebCore::Loader::Host::servePendingRequests):
2:04 PM Changeset in webkit [69419] by ajwong@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed. Build fix.

Trying to bring the bots green after r69386.

  • platform/chromium/test_expectations.txt:
1:21 PM Changeset in webkit [69418] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2010-10-08 James Kozianski <koz@chromium.org>

Reviewed by Simon Fraser.

Crash on reload when CSS property 'content' has malformed URL.
https://bugs.webkit.org/show_bug.cgi?id=47322

Tests that we don't crash when navigating away from a page with a
malformed URL as the value of a "content" CSS property.

  • fast/css-generated-content/malformed-url-expected.txt: Added.
  • fast/css-generated-content/malformed-url.html: Added.
  • fast/css-generated-content/resources/pass.html: Added.

2010-10-08 James Kozianski <koz@chromium.org>

Reviewed by Simon Fraser.

Crash on reload when CSS property 'content' has malformed URL.
https://bugs.webkit.org/show_bug.cgi?id=47322

Make CSSStyleSelector handle the case where a cached image can't be
produced due to a malformed URL.

Test: fast/css-generated-content/malformed-url.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::loadPendingImages):
1:09 PM Changeset in webkit [69417] by ajwong@chromium.org
  • 588 edits
    1 copy
    1 move
    15 adds
    339 deletes in trunk/LayoutTests

[chromium] Unreviewed. Text expectation changes caused by r69386.

944 text expectations need to be rebaselined because r69386 changed
the output formatting for the render tree dump.

This CL does not update any image files since those should not have
been affected. The Changelog filelist has been shortened to only give
the name of directory with changes along with a count of the number of
files changes because listing every file is too long to be useful.

  • LayoutTests/platform/chromium-linux/fast/repaint/: 2 changed.
  • LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1/: 246 changed.
  • LayoutTests/platform/chromium-linux/svg/batik/paints/: 2 changed.
  • LayoutTests/platform/chromium-linux/svg/batik/text/: 16 changed.
  • LayoutTests/platform/chromium-linux/svg/carto.net/: 3 changed.
  • LayoutTests/platform/chromium-linux/svg/clip-path/: 4 changed.
  • LayoutTests/platform/chromium-linux/svg/css/: 5 changed.
  • LayoutTests/platform/chromium-linux/svg/custom/: 39 changed.
  • LayoutTests/platform/chromium-linux/svg/hixie/error/: 1 changed.
  • LayoutTests/platform/chromium-linux/svg/hixie/perf/: 7 changed.
  • LayoutTests/platform/chromium-linux/svg/hixie/viewbox/preserveAspectRatio/: 2 changed.
  • LayoutTests/platform/chromium-linux/svg/text/: 53 changed.
  • LayoutTests/platform/chromium-linux/svg/transforms/: 2 changed.
  • LayoutTests/platform/chromium-linux/svg/zoom/page/: 1 changed.
  • LayoutTests/platform/chromium-linux/svg/zoom/text/: 1 changed.
  • LayoutTests/platform/chromium-mac/fast/repaint/: 2 changed.
  • LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/: 2 changed.
  • LayoutTests/platform/chromium-mac/svg/css/: 3 changed.
  • LayoutTests/platform/chromium-mac/svg/custom/: 2 changed.
  • LayoutTests/platform/chromium-win-xp/svg/custom/: 1 changed.
  • LayoutTests/platform/chromium-win-xp/svg/text/: 1 changed.
  • LayoutTests/platform/chromium-win/fast/repaint/: 2 changed.
  • LayoutTests/platform/chromium-win/http/tests/misc/: 1 changed.
  • LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/: 262 changed.
  • LayoutTests/platform/chromium-win/svg/batik/filters/: 2 changed.
  • LayoutTests/platform/chromium-win/svg/batik/masking/: 1 changed.
  • LayoutTests/platform/chromium-win/svg/batik/paints/: 4 changed.
  • LayoutTests/platform/chromium-win/svg/batik/text/: 16 changed.
  • LayoutTests/platform/chromium-win/svg/carto.net/: 5 changed.
  • LayoutTests/platform/chromium-win/svg/clip-path/: 4 changed.
  • LayoutTests/platform/chromium-win/svg/css/: 7 changed.
  • LayoutTests/platform/chromium-win/svg/custom/: 135 changed.
  • LayoutTests/platform/chromium-win/svg/filters/: 3 changed.
  • LayoutTests/platform/chromium-win/svg/foreignObject/: 3 changed.
  • LayoutTests/platform/chromium-win/svg/hixie/data-types/: 1 changed.
  • LayoutTests/platform/chromium-win/svg/hixie/error/: 4 changed.
  • LayoutTests/platform/chromium-win/svg/hixie/links/: 1 changed.
  • LayoutTests/platform/chromium-win/svg/hixie/mixed/: 8 changed.
  • LayoutTests/platform/chromium-win/svg/hixie/perf/: 7 changed.
  • LayoutTests/platform/chromium-win/svg/hixie/rendering-model/: 2 changed.
  • LayoutTests/platform/chromium-win/svg/hixie/shapes/path/: 1 changed.
  • LayoutTests/platform/chromium-win/svg/hixie/viewbox/: 2 changed.
  • LayoutTests/platform/chromium-win/svg/hixie/viewbox/preserveAspectRatio/: 2 changed.
  • LayoutTests/platform/chromium-win/svg/in-html/: 1 changed.
  • LayoutTests/platform/chromium-win/svg/overflow/: 5 changed.
  • LayoutTests/platform/chromium-win/svg/text/: 54 changed.
  • LayoutTests/platform/chromium-win/svg/transforms/: 2 changed.
  • LayoutTests/platform/chromium-win/svg/zoom/page/: 7 changed.
  • LayoutTests/platform/chromium-win/svg/zoom/text/: 6 changed.
  • LayoutTests/platform/chromium-win/transforms/: 1 changed.
12:40 PM Changeset in webkit [69416] by krit@webkit.org
  • 11 edits
    4 adds in trunk

2010-10-08 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG feImage needs absolute subregion for preserveAspectRatio
https://bugs.webkit.org/show_bug.cgi?id=47409

PreserverAspectRatio needs the subregion in absolute coordinates to determine
the destination position and size of the input image. The maxEffectRect() already
stores the absolute subregion, but clipped to the filter region.

Test: svg/W3C-SVG-1.1se/filters-image-03-f.svg

  • platform/graphics/filters/FETile.cpp: (WebCore::FETile::apply):
  • platform/graphics/filters/FilterEffect.h: Added enum to differentate sourece inputs, feTile and feImage. (WebCore::FilterEffect::filterEffectType):
  • platform/graphics/filters/SourceAlpha.h: Make use of the new enum in FilterEffect (WebCore::SourceAlpha::filterEffectType):
  • platform/graphics/filters/SourceGraphic.h: Ditto. (WebCore::SourceGraphic::filterEffectType):
  • svg/graphics/filters/SVGFEImage.cpp: Take the absolute subregion to determine the destination rect for input image. (WebCore::FEImage::apply):
  • svg/graphics/filters/SVGFEImage.h: Ditto. (WebCore::FEImage::setAbsoluteSubregion): (WebCore::FEImage::filterEffectType):
  • svg/graphics/filters/SVGFilter.cpp: Give over subregion in absolute coordinates to feImage. Just feImage makes use of it. (WebCore::SVGFilter::determineFilterPrimitiveSubregion):

2010-10-08 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG feImage needs absolute subregion for preserveAspectRatio
https://bugs.webkit.org/show_bug.cgi?id=47409

Adapted test form the new SVG 1.1 se test suite to check the correct behavior of feImage.
The subregion in absolute coordinates is a FloatRect instead of an IntRect. This
sharpens the result of svg/webarchive/svg-feimage-subresources.

  • platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
  • platform/mac/svg/webarchive/svg-feimage-subresources-expected.checksum:
  • platform/mac/svg/webarchive/svg-feimage-subresources-expected.png:
  • svg/W3C-SVG-1.1-SE/filters-image-03-f.svg: Added.
12:39 PM Changeset in webkit [69415] by jberlin@webkit.org
  • 15 edits
    3 adds in trunk

Add Private API for creating a WebKit1 WebSerializedJSValue from the internal
representation of a WebKit2 WebSerializedScriptValue.
https://bugs.webkit.org/show_bug.cgi?id=47390

Reviewed by Sam Weinig.

WebKit:

  • WebKit.xcodeproj/project.pbxproj:

Add WebSerializedJSValuePrivate.h.

WebKit/mac:

  • WebView/WebSerializedJSValue.mm:

(-[WebSerializedJSValue initWithInternalRepresentation:]):
Set the WebSerializedJSValuePrivate's WebCore::SerializedScriptValue to be the passed in
internal representation.

  • WebView/WebSerializedJSValuePrivate.h: Added.

WebKit/win:

  • Interfaces/WebKit.idl:

Generate IWebSerializedJSValuePrivate.

  • Interfaces/IWebSerializedJSValuePrivate.idl: Added.

Because it is taking a void* parameter, setInternalRepresentation must be declared [local].

  • WebKit.vcproj/Interfaces.vcproj:

Add IWebSerializedJSValue.idl and IWebSerializedJSValuePrivate.idl.

  • WebSerializedJSValue.cpp:

(WebSerializedJSValue::QueryInterface):
Since there are now two interfaces that inherit from IUnknown, do not try to cast to
IUnknown* anymore. Cast to IWebSerializedJSValue* instead.
(WebSerializedJSValue::setInternalRepresentation):
Only set the internal representation if it hasn't already been set.

  • WebSerializedJSValue.h:

WebKit2:

  • Shared/API/c/WKSerializedScriptValue.cpp:

(WKSerializedScriptValueGetInternalRepresentation):

  • Shared/API/c/WKSerializedScriptValuePrivate.h: Added.
  • Shared/WebSerializedScriptValue.h:

(WebKit::WebSerializedScriptValue::internalRepresentation):
Return the WebCore::SerializedScriptValue as a void* so that it can be passed through the
API.

  • WebKit2.xcodeproj/project.pbxproj:

Add WKSerializedScriptValuePrivate.h.

  • win/WebKit2.vcproj:

Ditto, also some sorting.

  • win/WebKit2Generated.make:

Copy over WKSerializedScriptValuePrivate.h.

12:38 PM Changeset in webkit [69414] by cevans@google.com
  • 4 edits in trunk/JavaScriptCore

2010-10-08 Chris Evans <cevans@google.com>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=47393

Use unsigned consistently to check for max StringImpl length.
Add a few integer overflow checks.
Uses the existing paradigm of CRASH() when we can't reasonably handle a crazily large request.

  • wtf/text/WTFString.cpp:
  • wtf/text/StringImpl.h:
  • wtf/text/StringImpl.cpp: Better use of size_t vs. unsigned; check for integer overflows.
11:33 AM Changeset in webkit [69413] by Nikolas Zimmermann
  • 39 edits
    14 adds in trunk

2010-10-08 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

gradient stroke on lines does not work
https://bugs.webkit.org/show_bug.cgi?id=40985

Correct handling of invalid fill/stroke paint servers / colors according to SVG 1.1 2nd Edition.
Perfectly matches Opera, and now lets us pass three of the new tests.

Fix incorrect svg/custom/invalid-fill* tests:
-> If there's an invalid fill URI, but no fallback specified, it is as if fill="black" was specified. (invalid-fill.svg)
-> If there's an invalid fill color, but no fallback specified, it is as if fill="none" was specified. (invalid-fill-hex.svg)

Needed to refactor some of the gradient/pattern code to properly handle fallback paint servers.
As side effect, we're allowing gradients with gradientUnits="userSpaceOnUse" to apply on 1d objects (lines) again, per SVG 1.1 2nd edition.

Tests: svg/W3C-SVG-1.1-SE/pservers-pattern-03-f.svg

svg/W3C-SVG-1.1-SE/pservers-grad-17-b.svg
svg/W3C-SVG-1.1-SE/pservers-grad-20-b.svg

  • rendering/RenderSVGResource.cpp: Rewrite fill/stroke paint resource requests, share all code between the similar functions. (WebCore::requestPaintingResource): (WebCore::RenderSVGResource::fillPaintingResource): (WebCore::RenderSVGResource::strokePaintingResource):
  • rendering/RenderSVGResource.h:
  • rendering/RenderSVGResourceGradient.cpp: Split collecting gradient properties from building the gradient. We don't need to build it, if it's not applyable (eg. on 1d lines). (WebCore::RenderSVGResourceGradient::RenderSVGResourceGradient): (WebCore::RenderSVGResourceGradient::removeAllClientsFromCache): (WebCore::clipToTextMask): (WebCore::RenderSVGResourceGradient::applyResource):
  • rendering/RenderSVGResourceGradient.h: Stop storing boundingBoxMode & gradientTransform in each GradientData object, it's enough to just store it in the gradient resource, once.
  • rendering/RenderSVGResourceLinearGradient.cpp: (WebCore::RenderSVGResourceLinearGradient::collectGradientAttributes): Splitted from buildGradient. (WebCore::RenderSVGResourceLinearGradient::buildGradient):
  • rendering/RenderSVGResourceLinearGradient.h: (WebCore::RenderSVGResourceLinearGradient::boundingBoxMode): Return bounding box mode information, from m_attributes instead of storing in gradientData. (WebCore::RenderSVGResourceLinearGradient::calculateGradientTransform): Ditto.
  • rendering/RenderSVGResourcePattern.cpp: Split collecting pattern properties from building the pattern. We don't need to build it, if it's not applyable (eg. on 1d lines). (WebCore::RenderSVGResourcePattern::RenderSVGResourcePattern): (WebCore::RenderSVGResourcePattern::removeAllClientsFromCache): (WebCore::RenderSVGResourcePattern::applyResource): (WebCore::RenderSVGResourcePattern::buildTileImageTransform):
  • rendering/RenderSVGResourcePattern.h:
  • rendering/RenderSVGResourceRadialGradient.cpp: (WebCore::RenderSVGResourceRadialGradient::collectGradientAttributes): (WebCore::RenderSVGResourceRadialGradient::buildGradient):
  • rendering/RenderSVGResourceRadialGradient.h: (WebCore::RenderSVGResourceRadialGradient::boundingBoxMode): (WebCore::RenderSVGResourceRadialGradient::calculateGradientTransform):
  • rendering/SVGRenderTreeAsText.cpp: Adapt to change, that fill/strokePaintingResource now take a Color& fallbackColor parameter. (WebCore::writeStyle): (WebCore::writeSVGResourceContainer):
  • rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::fillContains): Ditto. (WebCore::RenderSVGPath::strokeContains): Ditto. (WebCore::RenderSVGPath::fillAndStrokePath): Properly handle fallback color, if an existing (!) paint server failed to apply.
  • rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::acquirePaintingResource): Ditto.
  • svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::collectGradientAttributes): Pass LinearGradientAttributes by reference, instead of returning a copy.
  • svg/SVGLinearGradientElement.h: Rename collectGradientProperties to collectGradientAttributes.
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::collectPatternAttributes): Pass PatternAttributes by reference, instead of returning.
  • svg/SVGPatternElement.h: Rename collectPatternProperties to collectPatternAttributes.
  • svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::collectGradientAttributes): Pass RadialGradientAttributes by reference, instead of returning a copy.
  • svg/SVGRadialGradientElement.h: Rename collectGradientProperties to collectGradientAttributes.

2010-10-08 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

gradient stroke on lines does not work
https://bugs.webkit.org/show_bug.cgi?id=40985

  • platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png:
  • platform/mac-leopard/svg/custom/dominant-baseline-hanging-expected.checksum:
  • platform/mac-leopard/svg/custom/dominant-baseline-hanging-expected.png:
  • platform/mac-leopard/svg/custom/invalid-fill-expected.checksum:
  • platform/mac-leopard/svg/custom/invalid-fill-expected.png:
  • platform/mac-leopard/svg/custom/invalid-fill-hex-expected.checksum:
  • platform/mac-leopard/svg/custom/invalid-fill-hex-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt:
  • platform/mac/svg/custom/dominant-baseline-hanging-expected.txt:
  • platform/mac/svg/custom/gradient-with-1d-boundingbox-expected.checksum:
  • platform/mac/svg/custom/gradient-with-1d-boundingbox-expected.png:
  • platform/mac/svg/custom/invalid-fill-expected.txt:
  • platform/mac/svg/custom/invalid-fill-hex-expected.txt:
  • svg/W3C-SVG-1.1-SE: Added.
  • svg/W3C-SVG-1.1-SE/pservers-grad-17-b.svg: Added.
  • svg/W3C-SVG-1.1-SE/pservers-grad-20-b.svg: Added.
  • svg/W3C-SVG-1.1-SE/pservers-pattern-03-f.svg: Added.
  • svg/custom/gradient-with-1d-boundingbox-expected.txt:
  • svg/custom/gradient-with-1d-boundingbox.svg: Add new test covering gradientUnits="userSpaceOnUse" on 1d lines, which is explicitely allowed.
  • svg/custom/invalid-fill-hex.svg: Fix invalid test, fill="none", is the default if the given fill color is invalid, according to SVG 1.1 2nd Edition.
  • svg/custom/invalid-fill.svg: Update test comments, that we match Opera in both tests, and the new SVG 1.1 2nd Edition specification.
11:27 AM Changeset in webkit [69412] by zmo@google.com
  • 3 edits in trunk/LayoutTests

2010-10-08 Zhenyao Mo <zmo@google.com>

Unreviewed, update WebGL test expectations.

  • platform/chromium/drt_expectations.txt:
  • platform/chromium/test_expectations.txt:
10:23 AM Changeset in webkit [69411] by benjamin.poulain@nokia.com
  • 2 edits in trunk/WebCore

2010-10-08 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] Slider widgets looks bad on Mac
https://bugs.webkit.org/show_bug.cgi?id=47421

This patch change the rendering of the slider to only have the
subcontrols that would be defined by default on a QSlider.

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::paintSliderTrack):
10:08 AM Changeset in webkit [69410] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-10-08 Renata Hodovan <reni@inf.u-szeged.hu>

Reviewed by Nikolas Zimmermann.

SVG Text assertion on SVGInlineTextBox.
https://bugs.webkit.org/show_bug.cgi?id=41467

Example: <text><tspan>S</tspan><tspan>O</tspan></text> The old SVG text engine fired an assertion,
when the glyph 'O' isn't present in the <font>, but only if a <missing-glyph> element is included
in the SVG <font>. <tspan>SO</tspan> didn't trigger that assertion. Adding a new layout test, to
make sure we never see the assertion again.

  • svg/text/text-assert-expected.txt: Added.
  • svg/text/text-assert.svg: Added.
9:52 AM Changeset in webkit [69409] by commit-queue@webkit.org
  • 4 edits
    30 adds in trunk

2010-10-08 Renata Hodovan <reni@inf.u-szeged.hu>

Reviewed by Andreas Kling.

SVGFEColorMatrixElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=47342

Adding layout tests for feColorMatrix dynamic changes.

  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png: Added.
  • svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr.html: Added.
  • svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr.html: Added.
  • svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr.html: Added.
  • svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop.html: Added.
  • svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop.html: Added.
  • svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop.html: Added.
  • svg/dynamic-updates/script-tests/SVGFEColorMatrixElement-dom-in-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEColorMatrixElement-dom-type-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEColorMatrixElement-dom-values-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEColorMatrixElement-svgdom-in-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEColorMatrixElement-svgdom-type-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEColorMatrixElement-svgdom-values-prop.js: Added. (SVGNumberListToString): (executeTest):

2010-10-08 Renata Hodovan <reni@inf.u-szeged.hu>

Reviewed by Andreas Kling.

SVGFEColorMatrixElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=47342

The dynamic changes are captured by the svgAttributeChange function, and invalidate the filter primitive if necessary.

Tests: svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr.html

svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr.html
svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr.html
svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop.html
svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop.html
svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop.html

  • svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::svgAttributeChanged):
  • svg/SVGFEColorMatrixElement.h:
9:51 AM Changeset in webkit [69408] by abecsi@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-08 Andras Becsi <abecsi@webkit.org>

Unreviewed build fix.

[Qt] Add missing limits.h include since the Qt version currently
ran on the bot does need that.

  • WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
9:45 AM Changeset in webkit [69407] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-08 Alexander Pavlov <apavlov@chromium.org>

Unreviewed, updating test expectations.

Chromium Win crashes on fast/html/object-image-nested-fallback.html

  • platform/chromium/test_expectations.txt:
9:39 AM Changeset in webkit [69406] by podivilov@chromium.org
  • 14 edits in trunk/WebCore

2010-10-08 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: save InspectorController in instrumentation cookie
https://bugs.webkit.org/show_bug.cgi?id=47406

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluate): (WebCore::V8Proxy::callFunction):
  • dom/Document.cpp: (WebCore::Document::recalcStyle):
  • dom/Node.cpp: (WebCore::Node::dispatchGenericEvent):
  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::pumpTokenizer):
  • inspector/InspectorInstrumentation.cpp:
  • inspector/InspectorInstrumentation.h:
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didReceiveResponse): (WebCore::ResourceLoader::didReceiveData):
  • page/DOMTimer.cpp: (WebCore::DOMTimer::fired):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchEvent):
  • page/FrameView.cpp: (WebCore::FrameView::layout): (WebCore::FrameView::paintContents):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintContents):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::callReadyStateChangeListener):
9:16 AM Changeset in webkit [69405] by kbalazs@webkit.org
  • 5 edits in trunk

2010-10-08 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Turn on building WTR
https://bugs.webkit.org/show_bug.cgi?id=47349

  • DerivedSources.pro:
  • WebKit.pro:

2010-10-08 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Turn on building WTR
https://bugs.webkit.org/show_bug.cgi?id=47349

  • Scripts/webkitdirs.pm:
9:03 AM Changeset in webkit [69404] by Adam Roben
  • 3 edits
    3 adds in trunk/WebCore

Windows Release build fix for 32-bit systems

WebCore had once again grown too large for the linker's virtual
address space on 32-bit systems. I combined WebCore/rendering,
WebCore/rendering/style, and WebCore/dom into new *AllInOne.cpp files,
and added a few more files to RenderSVGAllInOne.cpp.

Fixes <http://webkit.org/b/47417> <rdar://problem/8529362>

  • WebCore.vcproj/WebCore.vcproj: Added new *AllInOne.cpp files and

excluded the individual files they contain from the build.

  • rendering/RenderSVGAllInOne.cpp: Added a few more files to this.
  • dom/DOMAllInOne.cpp: Added.
  • rendering/RenderingAllInOne.cpp: Added.
  • rendering/style/StyleAllInOne.cpp: Added.
9:02 AM Changeset in webkit [69403] by Martin Robinson
  • 3 edits in trunk/WebKit/gtk

2010-10-08 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Remove duplicate code in WebKit/gtk/WebCoreSupport/DragClientGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=47367

Remove as much duplicate code as possible from DragClientGtk. Most of this code
is GTK2/GTK3 independent, so only the bits that aren't should be protected by
#ifdefs.

  • WebCoreSupport/DragClientGtk.cpp: (WebKit::dragIconWindowDrawEventCallback): Modified the name of this callback so that it is shared between build types. (WebKit::DragClient::DragClient): Updated the signal connectors to reflect the change above. (WebKit::DragClient::~DragClient): The build types share the callback name, so remove the #ifdef here. (WebKit::DragClient::drawDragIconWindow): Changed the name of this method and make it independent of the build type.
  • WebCoreSupport/DragClientGtk.h: Update method declaration and remove #ifdefs.
9:01 AM Changeset in webkit [69402] by Girish Ramakrishnan
  • 2 edits in trunk/WebCore

2010-10-08 Girish Ramakrishnan <Girish Ramakrishnan>

Reviewed by Andreas Kling.

[Qt] Use constBegin and constEnd when using const iterators

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::~GraphicsLayerQtImpl): (WebCore::GraphicsLayerQtImpl::updateTransform): (WebCore::GraphicsLayerQtImpl::flushChanges):
8:26 AM Changeset in webkit [69401] by kbalazs@webkit.org
  • 3 edits in trunk/WebKitTools

2010-10-08 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Andreas Kling.

[Qt] TestController needs its platform dependent methods
https://bugs.webkit.org/show_bug.cgi?id=47413

  • WebKitTestRunner/qt/TestControllerQt.cpp: (WTR::TestController::initializeInjectedBundlePath): If the WTR_INJECTEDBUNDLE_PATH environmental variable is set then use that otherwise use the path where the bundle lives in a normal trunk build. (WTR::TestController::initializeTestPluginDirectory): Set the bundle's value. It is not used currently. (WTR::TestController::platformInitializeContext):
  • WebKitTestRunner/qt/WebKitTestRunner.pro:
8:19 AM Changeset in webkit [69400] by pfeldman@chromium.org
  • 6 edits in trunk/WebCore

2010-10-07 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: add resource viewer to the network panel.
https://bugs.webkit.org/show_bug.cgi?id=47346

  • inspector/front-end/DataGrid.js: (WebInspector.DataGrid): (WebInspector.DataGrid.prototype.autoSizeColumns): (WebInspector.DataGrid.prototype.updateWidths): (WebInspector.DataGrid.prototype.columnWidthsMap): (WebInspector.DataGrid.prototype.applyColumnWidthsMap): (WebInspector.DataGrid.prototype.isColumnVisible): (WebInspector.DataGrid.prototype.showColumn): (WebInspector.DataGrid.prototype.hideColumn): (WebInspector.DataGrid.prototype._positionResizers): (WebInspector.DataGrid.prototype._resizerDragging):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel): (WebInspector.NetworkPanel.prototype.updateSidebarWidth): (WebInspector.NetworkPanel.prototype.updateMainViewWidth): (WebInspector.NetworkPanel.prototype.handleShortcut): (WebInspector.NetworkPanel.prototype._createTable): (WebInspector.NetworkPanel.prototype._sortItems): (WebInspector.NetworkPanel.prototype._sortByTimeline): (WebInspector.NetworkPanel.prototype._createSummaryBar): (WebInspector.NetworkPanel.prototype._updateDividersIfNeeded): (WebInspector.NetworkPanel.prototype.hide): (WebInspector.NetworkPanel.prototype.get searchableViews): (WebInspector.NetworkPanel.prototype.refresh): (WebInspector.NetworkPanel.prototype.reset): (WebInspector.NetworkPanel.prototype.refreshResource): (WebInspector.NetworkPanel.prototype.canShowSourceLine): (WebInspector.NetworkPanel.prototype.showSourceLine): (WebInspector.NetworkPanel.prototype._showResource): (WebInspector.NetworkPanel.prototype._closeVisibleResource): (WebInspector.NetworkPanel.prototype._resourceViewForResource): (WebInspector.NetworkPanel.prototype._resourceViewTypeMatchesResource): (WebInspector.NetworkPanel.prototype._toggleGridMode): (WebInspector.NetworkPanel.prototype._toggleViewingResourceMode): (WebInspector.NetworkDataGridNode): (WebInspector.NetworkDataGridNode.prototype.select): (WebInspector.NetworkDataGridNode.prototype._createTimelineCell):
  • inspector/front-end/networkPanel.css: (#network-container): (#network-views): (.network.panel .data-grid.full-grid-mode .viewer-column): (.network.panel .data-grid.brief-grid-mode .time-column): (.network.panel.viewing-resource .network-timeline-grid): (.network.panel .data-grid.viewing-resource-mode .timeline-column): (.network.panel .network-sidebar): (.network.panel:not(.viewing-resource) .sidebar-resizer-vertical): (.network.panel.viewing-resource .data-grid-resizer): (.network.panel .scope-bar): (.network.panel .resource-view.headers-visible .resource-view-content): (.network.panel:not(.viewing-resource) .data-grid tr.selected):
7:47 AM QtWebKitRelease21 edited by Ademar Reis
(diff)
7:46 AM QtWebKitJournal edited by Ademar Reis
(diff)
7:36 AM Changeset in webkit [69399] by andreas.kling@nokia.com
  • 3 edits in trunk/WebCore

2010-10-08 Andreas Kling <kling@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGTextLayoutAttributesBuilder: "XValue" and "YValue" clash with X11 macros
https://bugs.webkit.org/show_bug.cgi?id=47180

Rename *Value to *ValueAttribute

  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp: (WebCore::SVGTextLayoutAttributesBuilder::nextLayoutValue): (WebCore::SVGTextLayoutAttributesBuilder::assignLayoutAttributesForCharacter):
  • rendering/svg/SVGTextLayoutAttributesBuilder.h:
7:31 AM Changeset in webkit [69398] by abecsi@webkit.org
  • 4 edits in trunk/WebKit2

2010-10-08 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Andreas Kling.

[Qt] Fix WKStringQt.h and WKURLQt.h API problems.
https://bugs.webkit.org/show_bug.cgi?id=47412

  • UIProcess/API/cpp/qt/WKStringQt.h: Remove the extern "C"
  • UIProcess/API/cpp/qt/WKURLQt.h: Remove the extern "C"
  • UIProcess/API/qt/qgraphicswkview.h: Fix the forwarded declaration
7:00 AM Changeset in webkit [69397] by abecsi@webkit.org
  • 4 edits in trunk

2010-10-08 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Don't use -whole-archive to link-in libWebKit2.a except for libQtWebKit.so
https://bugs.webkit.org/show_bug.cgi?id=47347

  • WebCore.pro:

2010-10-08 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Don't use -whole-archive to link-in libWebKit2.a except for libQtWebKit.so
https://bugs.webkit.org/show_bug.cgi?id=47347

  • WebKit2.pri:
6:58 AM Changeset in webkit [69396] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-10-08 Hui Huang <hui.2.huang@nokia.com>

Reviewed by Simon Hausmann.

ifdef out code that rewrites Flash Plug-in wmode for Symbian build
https://bugs.webkit.org/show_bug.cgi?id=43484

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin):
6:56 AM Changeset in webkit [69395] by abecsi@webkit.org
  • 3 edits in trunk/WebKitTools

2010-10-08 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

WTR: Prevent sending the Done message twice on test timeout.
https://bugs.webkit.org/show_bug.cgi?id=47410

When InjectedBundle::done() calls stopLoading, this may trigger
InjectedBundlePage::didFailLoadWithErrorForFrame which calls
InjectedBundle::done() itself later in the stack.
This would output the timeout failure message twice and confuse
the run-webkit-tests script.

This patch adds a third state, Stopping, which prevents WebCore
errors to trigger done() when testing is over.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::done):
  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:
6:24 AM Changeset in webkit [69394] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/WebCore

2010-10-08 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Implement IntRectEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=47403

Implement IntRect for Efl Port using Eina_Rectangle.

  • platform/graphics/IntRect.h:
  • platform/graphics/efl/IntRectEfl.cpp: (WebCore::IntRect::IntRect): (WebCore::IntRect::operator Eina_Rectangle):
5:58 AM Changeset in webkit [69393] by Nikolas Zimmermann
  • 1 edit
    2 adds in trunk/LayoutTests

2010-10-08 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Forgot to actually land two new win results.

  • platform/win/fast/repaint/moving-shadow-on-container-expected.txt: Added.
  • platform/win/fast/repaint/moving-shadow-on-path-expected.txt: Added.
5:29 AM Changeset in webkit [69392] by abecsi@webkit.org
  • 1 edit
    1 add in trunk/WebKitTools

2010-10-08 Andras Becsi <abecsi@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Add an activateFonts() implementation similar to DRT's initializeFonts().
Original code by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=47402

  • WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: Added. (WTR::activateFonts):
4:42 AM Changeset in webkit [69391] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit2

2010-10-08 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>

Reviewed by Andreas Kling.

Notify WebPage when QGraphicsWKView gains focus. Set both
active flag and focused flag, similar to QWebPage behavior.

[Qt] WebKit2 should support focusing
https://bugs.webkit.org/show_bug.cgi?id=47168

  • UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKView::focusInEvent): Added. (QGraphicsWKView::focusOutEvent): Added.
  • UIProcess/API/qt/qgraphicswkview.h: Added declarations.
4:21 AM Changeset in webkit [69390] by Nikolas Zimmermann
  • 17 edits
    5 adds
    2 deletes in trunk/LayoutTests

2010-10-08 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Rebaseline win results.

  • platform/win/fast/repaint/moving-shadow-on-container-expected.txt: Added.
  • platform/win/fast/repaint/moving-shadow-on-path-expected.txt: Added.
  • platform/win/svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt:
  • platform/win/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
  • platform/win/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt: Added.
  • platform/win/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
  • platform/win/svg/css: Added.
  • platform/win/svg/css/composite-shadow-example-expected.txt: Added.
  • platform/win/svg/css/composite-shadow-with-opacity-expected.txt: Added.
  • platform/win/svg/css/stars-with-shadow-expected.txt: Added.
  • platform/win/svg/custom/broken-internal-references-expected.txt:
  • platform/win/svg/custom/image-with-transform-clip-filter-expected.txt:
  • platform/win/svg/custom/junk-data-expected.txt:
  • platform/win/svg/custom/massive-coordinates-expected.txt:
  • platform/win/svg/custom/missing-xlink-expected.txt: Removed.
  • platform/win/svg/custom/mouse-move-on-svg-container-expected.txt:
  • platform/win/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
  • platform/win/svg/custom/mouse-move-on-svg-root-expected.txt:
  • platform/win/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
  • platform/win/svg/custom/relative-sized-inner-svg-expected.txt:
  • platform/win/svg/custom/relative-sized-use-on-symbol-expected.txt:
  • platform/win/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
  • platform/win/svg/custom/use-css-events-expected.txt:
  • platform/win/svg/filters/feColorMatrix-values-expected.txt:
  • platform/win/svg/hixie/mixed: Removed.
4:09 AM Changeset in webkit [69389] by Nikolas Zimmermann
  • 7 edits in trunk/LayoutTests

2010-10-08 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Complete Snow Leopard rebaselining.

  • platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
  • platform/mac/svg/custom/junk-data-expected.txt:
  • platform/mac/svg/custom/missing-xlink-expected.txt:
  • platform/mac/svg/custom/path-bad-data-expected.txt:
  • platform/mac/svg/hixie/error/012-expected.txt:
  • platform/mac/svg/text/text-intro-05-t-expected.txt:
3:39 AM Changeset in webkit [69388] by krit@webkit.org
  • 267 edits in trunk/LayoutTests

2010-10-08 Dirk Schulze <krit@webkit.org>

Unreviewed update of Gtk an Qt baseline after commit 69386.

  • platform/gtk/fast/repaint/moving-shadow-on-container-expected.txt:
  • platform/gtk/fast/repaint/moving-shadow-on-path-expected.txt:
  • platform/gtk/http/tests/misc/slow-loading-image-in-pattern-expected.txt:
  • platform/gtk/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
  • platform/gtk/svg/batik/text/textDecoration-expected.txt:
  • platform/gtk/svg/css/arrow-with-shadow-expected.txt:
  • platform/gtk/svg/css/composite-shadow-example-expected.txt:
  • platform/gtk/svg/css/composite-shadow-text-expected.txt:
  • platform/gtk/svg/css/composite-shadow-with-opacity-expected.txt:
  • platform/gtk/svg/css/group-with-shadow-expected.txt:
  • platform/gtk/svg/css/mask-with-shadow-expected.txt:
  • platform/gtk/svg/css/path-with-shadow-expected.txt:
  • platform/gtk/svg/css/shadow-and-opacity-expected.txt:
  • platform/gtk/svg/css/shadow-changes-expected.txt:
  • platform/gtk/svg/css/shadow-with-large-radius-expected.txt:
  • platform/gtk/svg/css/shadow-with-negative-offset-expected.txt:
  • platform/gtk/svg/css/stars-with-shadow-expected.txt:
  • platform/gtk/svg/custom/broken-internal-references-expected.txt:
  • platform/gtk/svg/custom/clip-path-id-changes-expected.txt:
  • platform/gtk/svg/custom/clone-element-with-animated-svg-properties-expected.txt:
  • platform/gtk/svg/custom/convolution-crash-expected.txt:
  • platform/gtk/svg/custom/empty-mask-expected.txt:
  • platform/gtk/svg/custom/fill-opacity-hsl-expected.txt:
  • platform/gtk/svg/custom/fill-opacity-rgba-expected.txt:
  • platform/gtk/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt:
  • platform/gtk/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt:
  • platform/gtk/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt:
  • platform/gtk/svg/custom/js-repaint-rect-on-path-with-stroke-expected.txt:
  • platform/gtk/svg/custom/js-update-stop-linked-gradient-expected.txt:
  • platform/gtk/svg/custom/marker-empty-path-expected.txt:
  • platform/gtk/svg/custom/marker-opacity-expected.txt:
  • platform/gtk/svg/custom/marker-referencePoint-expected.txt:
  • platform/gtk/svg/custom/mask-invalidation-expected.txt:
  • platform/gtk/svg/custom/massive-coordinates-expected.txt:
  • platform/gtk/svg/custom/mouse-move-on-svg-container-expected.txt:
  • platform/gtk/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
  • platform/gtk/svg/custom/mouse-move-on-svg-root-expected.txt:
  • platform/gtk/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
  • platform/gtk/svg/custom/non-scaling-stroke-markers-expected.txt:
  • platform/gtk/svg/custom/path-zero-strokewidth-expected.txt:
  • platform/gtk/svg/custom/pattern-incorrect-tiling-expected.txt:
  • platform/gtk/svg/custom/pattern-no-pixelation-expected.txt:
  • platform/gtk/svg/custom/pattern-size-bigger-than-target-size-expected.txt:
  • platform/gtk/svg/custom/pattern-skew-transformed-expected.txt:
  • platform/gtk/svg/custom/recursive-gradient-expected.txt:
  • platform/gtk/svg/custom/recursive-pattern-expected.txt:
  • platform/gtk/svg/custom/relative-sized-content-expected.txt:
  • platform/gtk/svg/custom/relative-sized-content-with-resources-expected.txt:
  • platform/gtk/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
  • platform/gtk/svg/custom/relative-sized-inner-svg-expected.txt:
  • platform/gtk/svg/custom/relative-sized-shadow-tree-content-expected.txt:
  • platform/gtk/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
  • platform/gtk/svg/custom/repaint-moving-svg-and-div-expected.txt:
  • platform/gtk/svg/custom/repaint-stroke-width-changes-expected.txt:
  • platform/gtk/svg/custom/stroke-width-large-expected.txt:
  • platform/gtk/svg/custom/svg-curve-with-relative-cordinates-expected.txt:
  • platform/gtk/svg/custom/text-x-dy-lists-expected.txt:
  • platform/gtk/svg/custom/text-zoom-expected.txt:
  • platform/gtk/svg/custom/use-property-synchronization-crash-expected.txt:
  • platform/gtk/svg/filters/feLighting-crash-expected.txt:
  • platform/gtk/svg/filters/filter-width-update-expected.txt:
  • platform/gtk/svg/filters/filterRes1-expected.txt:
  • platform/gtk/svg/filters/filterRes2-expected.txt:
  • platform/gtk/svg/filters/filterRes3-expected.txt:
  • platform/gtk/svg/foreignObject/svg-document-as-direct-child-expected.txt:
  • platform/gtk/svg/foreignObject/svg-document-in-html-document-expected.txt:
  • platform/gtk/svg/foreignObject/text-tref-02-b-expected.txt:
  • platform/gtk/svg/hixie/text/001-expected.txt:
  • platform/gtk/svg/in-html/circle-expected.txt:
  • platform/gtk/svg/overflow/overflow-on-inner-svg-element-defaults-expected.txt:
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.txt:
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.txt:
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.txt:
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.txt:
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.txt:
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt:
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.txt:
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.txt:
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.txt:
  • platform/gtk/svg/repaint/filter-repaint-expected.txt:
  • platform/gtk/svg/text/foreignObject-text-clipping-bug-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-3-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-4-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-stretch-1-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-stretch-2-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-stretch-3-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-stretch-4-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
  • platform/gtk/svg/text/select-x-list-1-expected.txt:
  • platform/gtk/svg/text/select-x-list-2-expected.txt:
  • platform/gtk/svg/text/select-x-list-3-expected.txt:
  • platform/gtk/svg/text/select-x-list-4-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-1-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-2-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-3-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-4-expected.txt:
  • platform/gtk/svg/text/text-hkern-expected.txt:
  • platform/gtk/svg/text/text-vkern-expected.txt:
  • platform/gtk/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.txt:
  • platform/gtk/svg/zoom/page/absolute-sized-document-scrollbars-expected.txt:
  • platform/gtk/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-svg-float-border-padding-expected.txt:
  • platform/gtk/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.txt:
  • platform/gtk/svg/zoom/text/absolute-sized-document-scrollbars-expected.txt:
  • platform/gtk/svg/zoom/text/relative-sized-document-scrollbars-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-foreignObject-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-svg-float-border-padding-expected.txt:
  • platform/gtk/transforms/svg-vs-css-expected.txt:
  • platform/qt/fast/repaint/moving-shadow-on-container-expected.txt:
  • platform/qt/fast/repaint/moving-shadow-on-path-expected.txt:
  • platform/qt/fast/repaint/repaint-svg-after-style-change-expected.txt:
  • platform/qt/fast/repaint/svg-layout-root-style-attr-update-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
  • platform/qt/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
  • platform/qt/svg/batik/text/textDecoration-expected.txt:
  • platform/qt/svg/css/arrow-with-shadow-expected.txt:
  • platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt:
  • platform/qt/svg/css/clippath-with-shadow-expected.txt:
  • platform/qt/svg/css/composite-shadow-text-expected.txt:
  • platform/qt/svg/css/mask-with-shadow-expected.txt:
  • platform/qt/svg/css/path-with-shadow-expected.txt:
  • platform/qt/svg/css/shadow-and-opacity-expected.txt:
  • platform/qt/svg/css/shadow-with-large-radius-expected.txt:
  • platform/qt/svg/css/shadow-with-negative-offset-expected.txt:
  • platform/qt/svg/css/stars-with-shadow-expected.txt:
  • platform/qt/svg/custom/absolute-sized-content-with-resources-expected.txt:
  • platform/qt/svg/custom/animation-currentColor-expected.txt:
  • platform/qt/svg/custom/broken-internal-references-expected.txt:
  • platform/qt/svg/custom/clip-path-id-changes-expected.txt:
  • platform/qt/svg/custom/clone-element-with-animated-svg-properties-expected.txt:
  • platform/qt/svg/custom/convolution-crash-expected.txt:
  • platform/qt/svg/custom/empty-mask-expected.txt:
  • platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt:
  • platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt:
  • platform/qt/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt:
  • platform/qt/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt:
  • platform/qt/svg/custom/js-repaint-rect-on-path-with-stroke-expected.txt:
  • platform/qt/svg/custom/js-update-stop-linked-gradient-expected.txt:
  • platform/qt/svg/custom/marker-child-changes-css-expected.txt:
  • platform/qt/svg/custom/marker-empty-path-expected.txt:
  • platform/qt/svg/custom/marker-opacity-expected.txt:
  • platform/qt/svg/custom/marker-referencePoint-expected.txt:
  • platform/qt/svg/custom/marker-strokeWidth-changes-expected.txt:
  • platform/qt/svg/custom/mask-invalidation-expected.txt:
  • platform/qt/svg/custom/mask-on-multiple-objects-expected.txt:
  • platform/qt/svg/custom/mask-with-default-value-expected.txt:
  • platform/qt/svg/custom/massive-coordinates-expected.txt:
  • platform/qt/svg/custom/mouse-move-on-svg-container-expected.txt:
  • platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
  • platform/qt/svg/custom/mouse-move-on-svg-root-expected.txt:
  • platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
  • platform/qt/svg/custom/non-scaling-stroke-expected.txt:
  • platform/qt/svg/custom/non-scaling-stroke-markers-expected.txt:
  • platform/qt/svg/custom/pattern-excessive-malloc-expected.txt:
  • platform/qt/svg/custom/pattern-incorrect-tiling-expected.txt:
  • platform/qt/svg/custom/pattern-no-pixelation-expected.txt:
  • platform/qt/svg/custom/pattern-size-bigger-than-target-size-expected.txt:
  • platform/qt/svg/custom/pattern-skew-transformed-expected.txt:
  • platform/qt/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.txt:
  • platform/qt/svg/custom/recursive-gradient-expected.txt:
  • platform/qt/svg/custom/recursive-mask-expected.txt:
  • platform/qt/svg/custom/recursive-pattern-expected.txt:
  • platform/qt/svg/custom/relative-sized-content-expected.txt:
  • platform/qt/svg/custom/relative-sized-content-with-resources-expected.txt:
  • platform/qt/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
  • platform/qt/svg/custom/relative-sized-inner-svg-expected.txt:
  • platform/qt/svg/custom/relative-sized-shadow-tree-content-expected.txt:
  • platform/qt/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
  • platform/qt/svg/custom/relative-sized-use-on-symbol-expected.txt:
  • platform/qt/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
  • platform/qt/svg/custom/repaint-moving-svg-and-div-expected.txt:
  • platform/qt/svg/custom/repaint-stroke-width-changes-expected.txt:
  • platform/qt/svg/custom/resource-invalidate-on-target-update-expected.txt:
  • platform/qt/svg/custom/stroke-width-large-expected.txt:
  • platform/qt/svg/custom/text-zoom-expected.txt:
  • platform/qt/svg/custom/transformedMaskFails-expected.txt:
  • platform/qt/svg/custom/use-on-clip-path-with-transformation-expected.txt:
  • platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • platform/qt/svg/custom/use-property-synchronization-crash-expected.txt:
  • platform/qt/svg/filters/feColorMatrix-values-expected.txt:
  • platform/qt/svg/filters/feComposite-expected.txt:
  • platform/qt/svg/filters/feGaussianBlur-expected.txt:
  • platform/qt/svg/filters/feLighting-crash-expected.txt:
  • platform/qt/svg/filters/feMerge-expected.txt:
  • platform/qt/svg/filters/feMerge-wrong-input-expected.txt:
  • platform/qt/svg/filters/feOffset-expected.txt:
  • platform/qt/svg/filters/feTile-expected.txt:
  • platform/qt/svg/filters/filter-clip-expected.txt:
  • platform/qt/svg/filters/filter-width-update-expected.txt:
  • platform/qt/svg/filters/shadow-on-filter-expected.txt:
  • platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt:
  • platform/qt/svg/filters/subRegion-one-effect-expected.txt:
  • platform/qt/svg/filters/subRegion-two-effects-expected.txt:
  • platform/qt/svg/foreignObject/svg-document-as-direct-child-expected.txt:
  • platform/qt/svg/foreignObject/svg-document-in-html-document-expected.txt:
  • platform/qt/svg/foreignObject/text-tref-02-b-expected.txt:
  • platform/qt/svg/hixie/text/001-expected.txt:
  • platform/qt/svg/in-html/circle-expected.txt:
  • platform/qt/svg/overflow/overflow-on-inner-svg-element-defaults-expected.txt:
  • platform/qt/svg/overflow/overflow-on-inner-svg-element-expected.txt:
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.txt:
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.txt:
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.txt:
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.txt:
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.txt:
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt:
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.txt:
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.txt:
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.txt:
  • platform/qt/svg/text/foreignObject-text-clipping-bug-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-3-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-4-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-stretch-1-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-stretch-2-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-stretch-3-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-stretch-4-expected.txt:
  • platform/qt/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
  • platform/qt/svg/text/select-x-list-1-expected.txt:
  • platform/qt/svg/text/select-x-list-2-expected.txt:
  • platform/qt/svg/text/select-x-list-3-expected.txt:
  • platform/qt/svg/text/select-x-list-4-expected.txt:
  • platform/qt/svg/text/select-x-list-with-tspans-1-expected.txt:
  • platform/qt/svg/text/select-x-list-with-tspans-2-expected.txt:
  • platform/qt/svg/text/select-x-list-with-tspans-3-expected.txt:
  • platform/qt/svg/text/select-x-list-with-tspans-4-expected.txt:
  • platform/qt/svg/text/text-hkern-expected.txt:
  • platform/qt/svg/text/text-vkern-expected.txt:
  • platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
  • platform/qt/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.txt:
  • platform/qt/svg/zoom/page/absolute-sized-document-scrollbars-expected.txt:
  • platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
  • platform/qt/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/qt/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/qt/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
  • platform/qt/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
  • platform/qt/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt:
  • platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-float-border-padding-expected.txt:
  • platform/qt/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.txt:
  • platform/qt/svg/zoom/text/absolute-sized-document-scrollbars-expected.txt:
  • platform/qt/svg/zoom/text/relative-sized-document-scrollbars-expected.txt:
  • platform/qt/svg/zoom/text/zoom-foreignObject-expected.txt:
  • platform/qt/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
  • platform/qt/svg/zoom/text/zoom-hixie-mixed-009-expected.txt:
  • platform/qt/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
  • platform/qt/svg/zoom/text/zoom-svg-float-border-padding-expected.txt:
3:25 AM Changeset in webkit [69387] by Nikolas Zimmermann
  • 7 edits in trunk/LayoutTests

2010-10-08 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.


Update some results we missed in the last commit.

  • fast/repaint/repaint-svg-after-style-change-expected.txt:
  • fast/repaint/svg-layout-root-style-attr-update-expected.txt:
  • platform/mac/fast/repaint/moving-shadow-on-container-expected.txt:
  • platform/mac/fast/repaint/moving-shadow-on-path-expected.txt:
  • platform/mac/http/tests/misc/slow-loading-image-in-pattern-expected.txt:
  • platform/mac/transforms/svg-vs-css-expected.txt:
2:49 AM Changeset in webkit [69386] by andreas.kling@nokia.com
  • 827 edits in trunk

2010-10-08 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Nikolas Zimmermann.

SVG: Make RenderPath DRT output platform-independent
https://bugs.webkit.org/show_bug.cgi?id=46051

Move away from using the port-specific Path::debugString() to dump
RenderPath objects. This shrinks the DRT output delta between platforms
and makes it more readable as we now dump only the relevant,
element-specific properties of each object.

  • rendering/SVGRenderTreeAsText.cpp: (WebCore::operator<<): Generate DRT output for RenderPaths in a platform-independent manner, dumping the relevant element properties.

2010-10-08 Andreas Kling <kling@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG: Make RenderPath DRT output platform-independent
https://bugs.webkit.org/show_bug.cgi?id=46051

  • platform/mac-leopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
  • platform/mac-leopard/svg/custom/junk-data-expected.txt:
  • platform/mac-leopard/svg/custom/missing-xlink-expected.txt:
  • platform/mac-leopard/svg/custom/path-bad-data-expected.txt:
  • platform/mac-leopard/svg/hixie/error/012-expected.txt:
  • platform/mac-leopard/svg/text/text-intro-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-12-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-25-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-32-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-34-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-37-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-44-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-52-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-60-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-62-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-81-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-84-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-85-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/color-prof-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/color-prop-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/color-prop-02-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/color-prop-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-coord-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-coord-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-units-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-units-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-units-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/interact-events-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/interact-order-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/interact-order-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/interact-order-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/linking-a-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/linking-a-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/linking-a-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/linking-a-04-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/linking-a-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/linking-a-07-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/linking-uri-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-path-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-path-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-path-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-path-05-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/painting-fill-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/painting-fill-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/painting-fill-04-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/painting-fill-05-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/painting-stroke-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/painting-stroke-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/painting-stroke-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/painting-stroke-07-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-04-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-07-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-08-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-09-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-10-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-13-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-14-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-15-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-elems-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-elems-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-elems-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/script-handle-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/script-handle-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/script-handle-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/script-handle-04-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/shapes-line-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-cond-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-cond-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-cond-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-defs-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-dom-06-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-04-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-group-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-group-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-image-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-image-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-image-04-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-image-05-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-image-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-image-07-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-image-08-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-image-09-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-image-10-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-use-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/styling-css-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/styling-css-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/styling-css-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/styling-css-04-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/styling-css-05-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/styling-css-06-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-align-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-align-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-align-04-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-deco-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-07-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-08-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-tref-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-ws-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-ws-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt:
  • platform/mac/svg/batik/filters/feTile-expected.txt:
  • platform/mac/svg/batik/filters/filterRegions-expected.txt:
  • platform/mac/svg/batik/masking/maskRegions-expected.txt:
  • platform/mac/svg/batik/paints/gradientLimit-expected.txt:
  • platform/mac/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
  • platform/mac/svg/batik/paints/patternRegionA-expected.txt:
  • platform/mac/svg/batik/paints/patternRegions-expected.txt:
  • platform/mac/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
  • platform/mac/svg/batik/text/longTextOnPath-expected.txt:
  • platform/mac/svg/batik/text/smallFonts-expected.txt:
  • platform/mac/svg/batik/text/textAnchor-expected.txt:
  • platform/mac/svg/batik/text/textAnchor2-expected.txt:
  • platform/mac/svg/batik/text/textAnchor3-expected.txt:
  • platform/mac/svg/batik/text/textDecoration-expected.txt:
  • platform/mac/svg/batik/text/textEffect2-expected.txt:
  • platform/mac/svg/batik/text/textFeatures-expected.txt:
  • platform/mac/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
  • platform/mac/svg/batik/text/textLength-expected.txt:
  • platform/mac/svg/batik/text/textOnPath-expected.txt:
  • platform/mac/svg/batik/text/textOnPath2-expected.txt:
  • platform/mac/svg/batik/text/textOnPath3-expected.txt:
  • platform/mac/svg/batik/text/textOnPathSpaces-expected.txt:
  • platform/mac/svg/batik/text/textProperties-expected.txt:
  • platform/mac/svg/batik/text/textProperties2-expected.txt:
  • platform/mac/svg/batik/text/verticalText-expected.txt:
  • platform/mac/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/mac/svg/carto.net/button-expected.txt:
  • platform/mac/svg/carto.net/colourpicker-expected.txt:
  • platform/mac/svg/carto.net/combobox-expected.txt:
  • platform/mac/svg/carto.net/scrollbar-expected.txt:
  • platform/mac/svg/carto.net/selectionlist-expected.txt:
  • platform/mac/svg/carto.net/slider-expected.txt:
  • platform/mac/svg/carto.net/tabgroup-expected.txt:
  • platform/mac/svg/carto.net/textbox-expected.txt:
  • platform/mac/svg/carto.net/window-expected.txt:
  • platform/mac/svg/clip-path/clip-in-mask-expected.txt:
  • platform/mac/svg/clip-path/clip-in-mask-objectBoundingBox-expected.txt:
  • platform/mac/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.txt:
  • platform/mac/svg/clip-path/clip-path-child-clipped-expected.txt:
  • platform/mac/svg/clip-path/clip-path-childs-clipped-expected.txt:
  • platform/mac/svg/clip-path/clip-path-clipped-evenodd-twice-expected.txt:
  • platform/mac/svg/clip-path/clip-path-clipped-expected.txt:
  • platform/mac/svg/clip-path/clip-path-clipped-no-content-expected.txt:
  • platform/mac/svg/clip-path/clip-path-clipped-nonzero-expected.txt:
  • platform/mac/svg/clip-path/clip-path-evenodd-expected.txt:
  • platform/mac/svg/clip-path/clip-path-evenodd-nonzero-expected.txt:
  • platform/mac/svg/clip-path/clip-path-nonzero-evenodd-expected.txt:
  • platform/mac/svg/clip-path/clip-path-nonzero-expected.txt:
  • platform/mac/svg/clip-path/clip-path-objectBoundingBox-expected.txt:
  • platform/mac/svg/clip-path/clip-path-on-clipped-use-expected.txt:
  • platform/mac/svg/clip-path/clip-path-on-g-and-child-expected.txt:
  • platform/mac/svg/clip-path/clip-path-on-g-expected.txt:
  • platform/mac/svg/clip-path/clip-path-on-svg-and-child-expected.txt:
  • platform/mac/svg/clip-path/clip-path-on-svg-expected.txt:
  • platform/mac/svg/clip-path/clip-path-pixelation-expected.txt:
  • platform/mac/svg/clip-path/clip-path-recursive-call-by-child-expected.txt:
  • platform/mac/svg/clip-path/clip-path-recursive-call-expected.txt:
  • platform/mac/svg/clip-path/clip-path-text-and-shape-expected.txt:
  • platform/mac/svg/clip-path/clip-path-text-and-stroke-expected.txt:
  • platform/mac/svg/clip-path/clip-path-text-expected.txt:
  • platform/mac/svg/clip-path/clip-path-use-as-child-expected.txt:
  • platform/mac/svg/clip-path/clip-path-use-as-child2-expected.txt:
  • platform/mac/svg/clip-path/clip-path-use-as-child3-expected.txt:
  • platform/mac/svg/clip-path/clip-path-use-as-child4-expected.txt:
  • platform/mac/svg/clip-path/clip-path-use-as-child5-expected.txt:
  • platform/mac/svg/clip-path/clip-path-userSpaceOnUse-expected.txt:
  • platform/mac/svg/clip-path/clip-path-with-container-expected.txt:
  • platform/mac/svg/clip-path/clip-path-with-different-unittypes-expected.txt:
  • platform/mac/svg/clip-path/clip-path-with-different-unittypes2-expected.txt:
  • platform/mac/svg/clip-path/clip-path-with-invisibile-child-expected.txt:
  • platform/mac/svg/clip-path/clip-path-with-text-clipped-expected.txt:
  • platform/mac/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt:
  • platform/mac/svg/clip-path/deep-nested-clip-in-mask-expected.txt:
  • platform/mac/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt:
  • platform/mac/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.txt:
  • platform/mac/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.txt:
  • platform/mac/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.txt:
  • platform/mac/svg/css/arrow-with-shadow-expected.txt:
  • platform/mac/svg/css/circle-in-mask-with-shadow-expected.txt:
  • platform/mac/svg/css/clippath-with-shadow-expected.txt:
  • platform/mac/svg/css/composite-shadow-example-expected.txt:
  • platform/mac/svg/css/composite-shadow-text-expected.txt:
  • platform/mac/svg/css/composite-shadow-with-opacity-expected.txt:
  • platform/mac/svg/css/css-box-min-width-expected.txt:
  • platform/mac/svg/css/group-with-shadow-expected.txt:
  • platform/mac/svg/css/mask-with-shadow-expected.txt:
  • platform/mac/svg/css/path-with-shadow-expected.txt:
  • platform/mac/svg/css/shadow-and-opacity-expected.txt:
  • platform/mac/svg/css/shadow-changes-expected.txt:
  • platform/mac/svg/css/shadow-with-large-radius-expected.txt:
  • platform/mac/svg/css/shadow-with-negative-offset-expected.txt:
  • platform/mac/svg/css/stars-with-shadow-expected.txt:
  • platform/mac/svg/custom/SVGNumber-interface-expected.txt:
  • platform/mac/svg/custom/SVGPoint-interface-expected.txt:
  • platform/mac/svg/custom/SVGRect-interface-expected.txt:
  • platform/mac/svg/custom/absolute-sized-content-with-resources-expected.txt:
  • platform/mac/svg/custom/absolute-sized-svg-in-xhtml-expected.txt:
  • platform/mac/svg/custom/alignment-baseline-modes-expected.txt:
  • platform/mac/svg/custom/altglyph-expected.txt:
  • platform/mac/svg/custom/animate-path-discrete-expected.txt:
  • platform/mac/svg/custom/animate-path-morphing-expected.txt:
  • platform/mac/svg/custom/attribute-namespace-check-expected.txt:
  • platform/mac/svg/custom/broken-internal-references-expected.txt:
  • platform/mac/svg/custom/circle-move-invalidation-expected.txt:
  • platform/mac/svg/custom/circular-marker-reference-1-expected.txt:
  • platform/mac/svg/custom/circular-marker-reference-2-expected.txt:
  • platform/mac/svg/custom/circular-marker-reference-3-expected.txt:
  • platform/mac/svg/custom/circular-marker-reference-4-expected.txt:
  • platform/mac/svg/custom/class-baseValue-expected.txt:
  • platform/mac/svg/custom/class-selector-expected.txt:
  • platform/mac/svg/custom/clip-path-child-changes-expected.txt:
  • platform/mac/svg/custom/clip-path-href-changes-expected.txt:
  • platform/mac/svg/custom/clip-path-id-changes-expected.txt:
  • platform/mac/svg/custom/clip-path-referencing-use-expected.txt:
  • platform/mac/svg/custom/clip-path-referencing-use2-expected.txt:
  • platform/mac/svg/custom/clip-path-units-changes-expected.txt:
  • platform/mac/svg/custom/clip-path-with-transform-expected.txt:
  • platform/mac/svg/custom/clone-element-with-animated-svg-properties-expected.txt:
  • platform/mac/svg/custom/conditional-processing-outside-switch-expected.txt:
  • platform/mac/svg/custom/container-opacity-clip-viewBox-expected.txt:
  • platform/mac/svg/custom/control-points-for-S-and-T-expected.txt:
  • platform/mac/svg/custom/convolution-crash-expected.txt:
  • platform/mac/svg/custom/coords-relative-units-transforms-expected.txt:
  • platform/mac/svg/custom/create-metadata-element-expected.txt:
  • platform/mac/svg/custom/createelement-expected.txt:
  • platform/mac/svg/custom/css-pixels-dpi-expected.txt:
  • platform/mac/svg/custom/dasharrayOrigin-expected.txt:
  • platform/mac/svg/custom/deep-dynamic-updates-expected.txt:
  • platform/mac/svg/custom/display-none-expected.txt:
  • platform/mac/svg/custom/dominant-baseline-hanging-expected.txt:
  • platform/mac/svg/custom/dominant-baseline-modes-expected.txt:
  • platform/mac/svg/custom/dynamic-empty-path-expected.txt:
  • platform/mac/svg/custom/dynamic-svg-document-creation-expected.txt:
  • platform/mac/svg/custom/dynamic-viewBox-expected.txt:
  • platform/mac/svg/custom/empty-clip-path-expected.txt:
  • platform/mac/svg/custom/empty-mask-expected.txt:
  • platform/mac/svg/custom/empty-merge-expected.txt:
  • platform/mac/svg/custom/evt-onload-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Discrete-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Gamma-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Linear-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Table-expected.txt:
  • platform/mac/svg/custom/feDisplacementMap-01-expected.txt:
  • platform/mac/svg/custom/fill-SVGPaint-interface-expected.txt:
  • platform/mac/svg/custom/fill-fallback-expected.txt:
  • platform/mac/svg/custom/fill-opacity-hsl-expected.txt:
  • platform/mac/svg/custom/fill-opacity-rgba-expected.txt:
  • platform/mac/svg/custom/fill-update-expected.txt:
  • platform/mac/svg/custom/focus-ring-expected.txt:
  • platform/mac/svg/custom/foreign-object-skew-expected.txt:
  • platform/mac/svg/custom/foreignObject-crash-on-hover-expected.txt:
  • platform/mac/svg/custom/fractional-rects-expected.txt:
  • platform/mac/svg/custom/getPresentationAttribute-expected.txt:
  • platform/mac/svg/custom/getTransformToElement-expected.txt:
  • platform/mac/svg/custom/getscreenctm-in-mixed-content-expected.txt:
  • platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt:
  • platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt:
  • platform/mac/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt:
  • platform/mac/svg/custom/getsvgdocument-expected.txt:
  • platform/mac/svg/custom/glyph-selection-lang-attribute-expected.txt:
  • platform/mac/svg/custom/gradient-add-stops-expected.txt:
  • platform/mac/svg/custom/gradient-attr-update-expected.txt:
  • platform/mac/svg/custom/gradient-cycle-detection-expected.txt:
  • platform/mac/svg/custom/gradient-deep-referencing-expected.txt:
  • platform/mac/svg/custom/gradient-rotated-bbox-expected.txt:
  • platform/mac/svg/custom/gradient-stop-corner-cases-expected.txt:
  • platform/mac/svg/custom/gradient-stop-style-change-expected.txt:
  • platform/mac/svg/custom/gradient-stroke-width-expected.txt:
  • platform/mac/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt:
  • platform/mac/svg/custom/grayscale-gradient-mask-expected.txt:
  • platform/mac/svg/custom/group-opacity-expected.txt:
  • platform/mac/svg/custom/hit-test-unclosed-subpaths-expected.txt:
  • platform/mac/svg/custom/hit-test-with-br-expected.txt:
  • platform/mac/svg/custom/hover-default-fill-expected.txt:
  • platform/mac/svg/custom/image-parent-translation-expected.txt:
  • platform/mac/svg/custom/image-small-width-height-expected.txt:
  • platform/mac/svg/custom/image-with-aspect-ratio-stretch-expected.txt:
  • platform/mac/svg/custom/image-with-transform-clip-filter-expected.txt:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/mac/svg/custom/inner-percent-expected.txt:
  • platform/mac/svg/custom/inner-svg-hit-test-expected.txt:
  • platform/mac/svg/custom/invalid-css-expected.txt:
  • platform/mac/svg/custom/invalid-fill-expected.txt:
  • platform/mac/svg/custom/invalid-fill-hex-expected.txt:
  • platform/mac/svg/custom/invalid-lengthlist-expected.txt:
  • platform/mac/svg/custom/invalid-transforms-expected.txt:
  • platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
  • platform/mac/svg/custom/js-late-clipPath-creation-expected.txt:
  • platform/mac/svg/custom/js-late-marker-and-object-creation-expected.txt:
  • platform/mac/svg/custom/js-late-marker-creation-expected.txt:
  • platform/mac/svg/custom/js-late-mask-and-object-creation-expected.txt:
  • platform/mac/svg/custom/js-late-mask-creation-expected.txt:
  • platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.txt:
  • platform/mac/svg/custom/js-late-pattern-creation-expected.txt:
  • platform/mac/svg/custom/js-repaint-rect-on-path-with-stroke-expected.txt:
  • platform/mac/svg/custom/js-update-bounce-expected.txt:
  • platform/mac/svg/custom/js-update-container-expected.txt:
  • platform/mac/svg/custom/js-update-container2-expected.txt:
  • platform/mac/svg/custom/js-update-gradient-expected.txt:
  • platform/mac/svg/custom/js-update-path-changes-expected.txt:
  • platform/mac/svg/custom/js-update-path-removal-expected.txt:
  • platform/mac/svg/custom/js-update-pattern-child-expected.txt:
  • platform/mac/svg/custom/js-update-pattern-expected.txt:
  • platform/mac/svg/custom/js-update-polygon-changes-expected.txt:
  • platform/mac/svg/custom/js-update-polygon-removal-expected.txt:
  • platform/mac/svg/custom/js-update-stop-expected.txt:
  • platform/mac/svg/custom/js-update-stop-linked-gradient-expected.txt:
  • platform/mac/svg/custom/js-update-style-expected.txt:
  • platform/mac/svg/custom/js-update-transform-addition-expected.txt:
  • platform/mac/svg/custom/js-update-transform-changes-expected.txt:
  • platform/mac/svg/custom/large-bounding-box-percents-expected.txt:
  • platform/mac/svg/custom/linking-a-03-b-all-expected.txt:
  • platform/mac/svg/custom/linking-a-03-b-preserveAspectRatio-expected.txt:
  • platform/mac/svg/custom/linking-a-03-b-transform-expected.txt:
  • platform/mac/svg/custom/linking-a-03-b-viewBox-expected.txt:
  • platform/mac/svg/custom/linking-a-03-b-viewBox-transform-expected.txt:
  • platform/mac/svg/custom/linking-a-03-b-viewTarget-expected.txt:
  • platform/mac/svg/custom/linking-a-03-b-zoomAndPan-expected.txt:
  • platform/mac/svg/custom/marker-changes-expected.txt:
  • platform/mac/svg/custom/marker-child-changes-css-expected.txt:
  • platform/mac/svg/custom/marker-child-changes-expected.txt:
  • platform/mac/svg/custom/marker-default-width-height-expected.txt:
  • platform/mac/svg/custom/marker-empty-path-expected.txt:
  • platform/mac/svg/custom/marker-opacity-expected.txt:
  • platform/mac/svg/custom/marker-overflow-clip-expected.txt:
  • platform/mac/svg/custom/marker-referencePoint-expected.txt:
  • platform/mac/svg/custom/marker-strokeWidth-changes-expected.txt:
  • platform/mac/svg/custom/marker-viewBox-changes-expected.txt:
  • platform/mac/svg/custom/mask-changes-expected.txt:
  • platform/mac/svg/custom/mask-child-changes-expected.txt:
  • platform/mac/svg/custom/mask-colorspace-expected.txt:
  • platform/mac/svg/custom/mask-excessive-malloc-expected.txt:
  • platform/mac/svg/custom/mask-inside-defs-expected.txt:
  • platform/mac/svg/custom/mask-invalidation-expected.txt:
  • platform/mac/svg/custom/mask-on-multiple-objects-expected.txt:
  • platform/mac/svg/custom/mask-with-all-units-expected.txt:
  • platform/mac/svg/custom/mask-with-default-value-expected.txt:
  • platform/mac/svg/custom/massive-coordinates-expected.txt:
  • platform/mac/svg/custom/mouse-move-on-svg-container-expected.txt:
  • platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
  • platform/mac/svg/custom/mouse-move-on-svg-root-expected.txt:
  • platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
  • platform/mac/svg/custom/no-inherited-dashed-stroke-expected.txt:
  • platform/mac/svg/custom/non-circular-marker-reference-expected.txt:
  • platform/mac/svg/custom/non-opaque-filters-expected.txt:
  • platform/mac/svg/custom/non-scaling-stroke-expected.txt:
  • platform/mac/svg/custom/non-scaling-stroke-markers-expected.txt:
  • platform/mac/svg/custom/path-textPath-simulation-expected.txt:
  • platform/mac/svg/custom/path-update-expected.txt:
  • platform/mac/svg/custom/path-zero-strokewidth-expected.txt:
  • platform/mac/svg/custom/pattern-cycle-detection-expected.txt:
  • platform/mac/svg/custom/pattern-deep-referencing-expected.txt:
  • platform/mac/svg/custom/pattern-excessive-malloc-expected.txt:
  • platform/mac/svg/custom/pattern-in-defs-expected.txt:
  • platform/mac/svg/custom/pattern-incorrect-tiling-expected.txt:
  • platform/mac/svg/custom/pattern-no-pixelation-expected.txt:
  • platform/mac/svg/custom/pattern-rotate-expected.txt:
  • platform/mac/svg/custom/pattern-size-bigger-than-target-size-expected.txt:
  • platform/mac/svg/custom/pattern-skew-transformed-expected.txt:
  • platform/mac/svg/custom/pattern-with-transformation-expected.txt:
  • platform/mac/svg/custom/pattern-y-offset-expected.txt:
  • platform/mac/svg/custom/percentage-of-html-parent-expected.txt:
  • platform/mac/svg/custom/percentage-rect-expected.txt:
  • platform/mac/svg/custom/percentage-rect2-expected.txt:
  • platform/mac/svg/custom/pointer-events-path-expected.txt:
  • platform/mac/svg/custom/poly-identify-expected.txt:
  • platform/mac/svg/custom/polyline-hittest-expected.txt:
  • platform/mac/svg/custom/polyline-invalid-points-expected.txt:
  • platform/mac/svg/custom/polyline-setattribute-points-null-expected.txt:
  • platform/mac/svg/custom/preserve-aspect-ratio-syntax-expected.txt:
  • platform/mac/svg/custom/prevent-default-expected.txt:
  • platform/mac/svg/custom/recursive-clippath-expected.txt:
  • platform/mac/svg/custom/recursive-filter-expected.txt:
  • platform/mac/svg/custom/recursive-gradient-expected.txt:
  • platform/mac/svg/custom/recursive-mask-expected.txt:
  • platform/mac/svg/custom/recursive-pattern-expected.txt:
  • platform/mac/svg/custom/relative-sized-content-expected.txt:
  • platform/mac/svg/custom/relative-sized-content-with-resources-expected.txt:
  • platform/mac/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
  • platform/mac/svg/custom/relative-sized-inner-svg-expected.txt:
  • platform/mac/svg/custom/relative-sized-shadow-tree-content-expected.txt:
  • platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
  • platform/mac/svg/custom/relative-sized-use-on-symbol-expected.txt:
  • platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
  • platform/mac/svg/custom/repaint-moving-svg-and-div-expected.txt:
  • platform/mac/svg/custom/repaint-on-image-bounds-change-expected.txt:
  • platform/mac/svg/custom/repaint-stroke-width-changes-expected.txt:
  • platform/mac/svg/custom/resource-client-removal-expected.txt:
  • platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt:
  • platform/mac/svg/custom/rgbcolor-syntax-expected.txt:
  • platform/mac/svg/custom/root-container-opacity-clip-viewBox-expected.txt:
  • platform/mac/svg/custom/rootelement-expected.txt:
  • platform/mac/svg/custom/rootmost-svg-xy-attrs-expected.txt:
  • platform/mac/svg/custom/rounded-rects-expected.txt:
  • platform/mac/svg/custom/scroll-hit-test-expected.txt:
  • platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
  • platform/mac/svg/custom/second-inline-text-expected.txt:
  • platform/mac/svg/custom/shape-rendering-expected.txt:
  • platform/mac/svg/custom/shapes-supporting-markers-expected.txt:
  • platform/mac/svg/custom/sheet-title-expected.txt:
  • platform/mac/svg/custom/simpleCDF-expected.txt:
  • platform/mac/svg/custom/stroke-fallback-expected.txt:
  • platform/mac/svg/custom/stroke-width-large-expected.txt:
  • platform/mac/svg/custom/stroked-pattern-expected.txt:
  • platform/mac/svg/custom/struct-use-09-b-expected.txt:
  • platform/mac/svg/custom/style-attribute-font-size-expected.txt:
  • platform/mac/svg/custom/svg-absolute-children-expected.txt:
  • platform/mac/svg/custom/svg-curve-with-relative-cordinates-expected.txt:
  • platform/mac/svg/custom/svg-float-border-padding-expected.txt:
  • platform/mac/svg/custom/svg-overflow-types-expected.txt:
  • platform/mac/svg/custom/svgpolyparser-extra-space-expected.txt:
  • platform/mac/svg/custom/text-clip-expected.txt:
  • platform/mac/svg/custom/text-dom-01-f-expected.txt:
  • platform/mac/svg/custom/text-gradient-no-content-expected.txt:
  • platform/mac/svg/custom/text-linking-expected.txt:
  • platform/mac/svg/custom/text-x-dy-lists-expected.txt:
  • platform/mac/svg/custom/transform-ignore-after-invalid-expected.txt:
  • platform/mac/svg/custom/transform-invalid-expected.txt:
  • platform/mac/svg/custom/transform-removeAttributeNS-expected.txt:
  • platform/mac/svg/custom/transform-scale-parse-expected.txt:
  • platform/mac/svg/custom/transform-with-ending-space-expected.txt:
  • platform/mac/svg/custom/use-clipped-hit-expected.txt:
  • platform/mac/svg/custom/use-css-events-expected.txt:
  • platform/mac/svg/custom/use-css-no-effect-on-shadow-tree-expected.txt:
  • platform/mac/svg/custom/use-detach-expected.txt:
  • platform/mac/svg/custom/use-dynamic-append-expected.txt:
  • platform/mac/svg/custom/use-event-handler-on-referenced-element-expected.txt:
  • platform/mac/svg/custom/use-event-handler-on-use-element-expected.txt:
  • platform/mac/svg/custom/use-events-crash-expected.txt:
  • platform/mac/svg/custom/use-forward-refs-expected.txt:
  • platform/mac/svg/custom/use-instanceRoot-modifications-expected.txt:
  • platform/mac/svg/custom/use-modify-container-in-target-expected.txt:
  • platform/mac/svg/custom/use-modify-target-container-expected.txt:
  • platform/mac/svg/custom/use-modify-target-symbol-expected.txt:
  • platform/mac/svg/custom/use-nested-transform-expected.txt:
  • platform/mac/svg/custom/use-on-clip-path-with-transformation-expected.txt:
  • platform/mac/svg/custom/use-on-g-containing-symbol-expected.txt:
  • platform/mac/svg/custom/use-on-g-containing-use-expected.txt:
  • platform/mac/svg/custom/use-on-g-expected.txt:
  • platform/mac/svg/custom/use-on-rect-expected.txt:
  • platform/mac/svg/custom/use-on-symbol-expected.txt:
  • platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • platform/mac/svg/custom/use-on-use-expected.txt:
  • platform/mac/svg/custom/use-property-changes-through-dom-expected.txt:
  • platform/mac/svg/custom/use-property-changes-through-svg-dom-expected.txt:
  • platform/mac/svg/custom/use-property-synchronization-crash-expected.txt:
  • platform/mac/svg/custom/use-recursion-1-expected.txt:
  • platform/mac/svg/custom/use-recursion-3-expected.txt:
  • platform/mac/svg/custom/use-recursion-4-expected.txt:
  • platform/mac/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
  • platform/mac/svg/custom/use-symbol-overflow-expected.txt:
  • platform/mac/svg/custom/use-transform-expected.txt:
  • platform/mac/svg/custom/viewBox-hit-expected.txt:
  • platform/mac/svg/custom/viewbox-syntax-expected.txt:
  • platform/mac/svg/custom/viewport-clip-expected.txt:
  • platform/mac/svg/custom/viewport-em-expected.txt:
  • platform/mac/svg/custom/viewport-no-width-height-expected.txt:
  • platform/mac/svg/custom/viewport-update-expected.txt:
  • platform/mac/svg/custom/viewport-update2-expected.txt:
  • platform/mac/svg/custom/visibility-override-clip-expected.txt:
  • platform/mac/svg/custom/visibility-override-expected.txt:
  • platform/mac/svg/custom/visibility-override-filter-expected.txt:
  • platform/mac/svg/custom/visibility-override-mask-expected.txt:
  • platform/mac/svg/custom/width-full-percentage-expected.txt:
  • platform/mac/svg/custom/xml-stylesheet-expected.txt:
  • platform/mac/svg/filters/big-sized-filter-2-expected.txt:
  • platform/mac/svg/filters/big-sized-filter-expected.txt:
  • platform/mac/svg/filters/feColorMatrix-values-expected.txt:
  • platform/mac/svg/filters/feComposite-expected.txt:
  • platform/mac/svg/filters/feGaussianBlur-expected.txt:
  • platform/mac/svg/filters/feLighting-crash-expected.txt:
  • platform/mac/svg/filters/feMerge-expected.txt:
  • platform/mac/svg/filters/feMerge-wrong-input-expected.txt:
  • platform/mac/svg/filters/feOffset-expected.txt:
  • platform/mac/svg/filters/feTile-expected.txt:
  • platform/mac/svg/filters/filter-clip-expected.txt:
  • platform/mac/svg/filters/filter-width-update-expected.txt:
  • platform/mac/svg/filters/filterRes-expected.txt:
  • platform/mac/svg/filters/filterRes1-expected.txt:
  • platform/mac/svg/filters/filterRes2-expected.txt:
  • platform/mac/svg/filters/filterRes3-expected.txt:
  • platform/mac/svg/filters/parent-children-with-same-filter-expected.txt:
  • platform/mac/svg/filters/shadow-on-filter-expected.txt:
  • platform/mac/svg/filters/shadow-on-rect-with-filter-expected.txt:
  • platform/mac/svg/filters/subRegion-one-effect-expected.txt:
  • platform/mac/svg/filters/subRegion-two-effects-expected.txt:
  • platform/mac/svg/foreignObject/svg-document-as-direct-child-expected.txt:
  • platform/mac/svg/foreignObject/svg-document-in-html-document-expected.txt:
  • platform/mac/svg/foreignObject/text-tref-02-b-expected.txt:
  • platform/mac/svg/hixie/cascade/001-broken-expected.txt:
  • platform/mac/svg/hixie/cascade/002-expected.txt:
  • platform/mac/svg/hixie/data-types/001-expected.txt:
  • platform/mac/svg/hixie/data-types/002-expected.txt:
  • platform/mac/svg/hixie/dynamic/003-expected.txt:
  • platform/mac/svg/hixie/dynamic/004-expected.txt:
  • platform/mac/svg/hixie/dynamic/005-expected.txt:
  • platform/mac/svg/hixie/dynamic/006-expected.txt:
  • platform/mac/svg/hixie/error/001-expected.txt:
  • platform/mac/svg/hixie/error/003-expected.txt:
  • platform/mac/svg/hixie/error/007-expected.txt:
  • platform/mac/svg/hixie/error/008-expected.txt:
  • platform/mac/svg/hixie/error/009-expected.txt:
  • platform/mac/svg/hixie/error/010-expected.txt:
  • platform/mac/svg/hixie/error/011-expected.txt:
  • platform/mac/svg/hixie/error/014-expected.txt:
  • platform/mac/svg/hixie/error/014-test-expected.txt:
  • platform/mac/svg/hixie/error/015-expected.txt:
  • platform/mac/svg/hixie/error/016-expected.txt:
  • platform/mac/svg/hixie/error/017-expected.txt:
  • platform/mac/svg/hixie/links/001-expected.txt:
  • platform/mac/svg/hixie/links/003-broken-expected.txt:
  • platform/mac/svg/hixie/mixed/003-expected.txt:
  • platform/mac/svg/hixie/mixed/004-expected.txt:
  • platform/mac/svg/hixie/mixed/005-expected.txt:
  • platform/mac/svg/hixie/mixed/006-expected.txt:
  • platform/mac/svg/hixie/mixed/008-expected.txt:
  • platform/mac/svg/hixie/mixed/009-expected.txt:
  • platform/mac/svg/hixie/mixed/010-expected.txt:
  • platform/mac/svg/hixie/mixed/011-expected.txt:
  • platform/mac/svg/hixie/painting/001-expected.txt:
  • platform/mac/svg/hixie/perf/001-expected.txt:
  • platform/mac/svg/hixie/perf/002-expected.txt:
  • platform/mac/svg/hixie/perf/003-expected.txt:
  • platform/mac/svg/hixie/perf/004-expected.txt:
  • platform/mac/svg/hixie/perf/005-expected.txt:
  • platform/mac/svg/hixie/perf/006-expected.txt:
  • platform/mac/svg/hixie/perf/007-expected.txt:
  • platform/mac/svg/hixie/processing-model/005-expected.txt:
  • platform/mac/svg/hixie/rendering-model/001-expected.txt:
  • platform/mac/svg/hixie/rendering-model/002-expected.txt:
  • platform/mac/svg/hixie/rendering-model/003-expected.txt:
  • platform/mac/svg/hixie/rendering-model/003a-expected.txt:
  • platform/mac/svg/hixie/rendering-model/004-expected.txt:
  • platform/mac/svg/hixie/shapes/path/001-expected.txt:
  • platform/mac/svg/hixie/text/001-expected.txt:
  • platform/mac/svg/hixie/transform/001-expected.txt:
  • platform/mac/svg/hixie/use/001-expected.txt:
  • platform/mac/svg/hixie/use/002-expected.txt:
  • platform/mac/svg/hixie/use/002-test-expected.txt:
  • platform/mac/svg/hixie/viewbox/001-expected.txt:
  • platform/mac/svg/hixie/viewbox/002-expected.txt:
  • platform/mac/svg/hixie/viewbox/003-expected.txt:
  • platform/mac/svg/hixie/viewbox/004-expected.txt:
  • platform/mac/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
  • platform/mac/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt:
  • platform/mac/svg/in-html/circle-expected.txt:
  • platform/mac/svg/overflow/overflow-on-inner-svg-element-defaults-expected.txt:
  • platform/mac/svg/overflow/overflow-on-inner-svg-element-expected.txt:
  • platform/mac/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.txt:
  • platform/mac/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.txt:
  • platform/mac/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.txt:
  • platform/mac/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.txt:
  • platform/mac/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.txt:
  • platform/mac/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt:
  • platform/mac/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.txt:
  • platform/mac/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.txt:
  • platform/mac/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.txt:
  • platform/mac/svg/repaint/filter-repaint-expected.txt:
  • platform/mac/svg/text/foreignObject-text-clipping-bug-expected.txt:
  • platform/mac/svg/text/kerning-expected.txt:
  • platform/mac/svg/text/multichar-glyph-expected.txt:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-3-expected.txt:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-4-expected.txt:
  • platform/mac/svg/text/select-textLength-spacing-stretch-1-expected.txt:
  • platform/mac/svg/text/select-textLength-spacing-stretch-2-expected.txt:
  • platform/mac/svg/text/select-textLength-spacing-stretch-3-expected.txt:
  • platform/mac/svg/text/select-textLength-spacing-stretch-4-expected.txt:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
  • platform/mac/svg/text/select-x-list-1-expected.txt:
  • platform/mac/svg/text/select-x-list-2-expected.txt:
  • platform/mac/svg/text/select-x-list-3-expected.txt:
  • platform/mac/svg/text/select-x-list-4-expected.txt:
  • platform/mac/svg/text/select-x-list-with-tspans-1-expected.txt:
  • platform/mac/svg/text/select-x-list-with-tspans-2-expected.txt:
  • platform/mac/svg/text/select-x-list-with-tspans-3-expected.txt:
  • platform/mac/svg/text/select-x-list-with-tspans-4-expected.txt:
  • platform/mac/svg/text/text-align-01-b-expected.txt:
  • platform/mac/svg/text/text-align-02-b-expected.txt:
  • platform/mac/svg/text/text-align-03-b-expected.txt:
  • platform/mac/svg/text/text-align-04-b-expected.txt:
  • platform/mac/svg/text/text-align-05-b-expected.txt:
  • platform/mac/svg/text/text-align-06-b-expected.txt:
  • platform/mac/svg/text/text-altglyph-01-b-expected.txt:
  • platform/mac/svg/text/text-deco-01-b-expected.txt:
  • platform/mac/svg/text/text-fonts-01-t-expected.txt:
  • platform/mac/svg/text/text-fonts-02-t-expected.txt:
  • platform/mac/svg/text/text-hkern-expected.txt:
  • platform/mac/svg/text/text-path-01-b-expected.txt:
  • platform/mac/svg/text/text-spacing-01-b-expected.txt:
  • platform/mac/svg/text/text-text-01-b-expected.txt:
  • platform/mac/svg/text/text-text-03-b-expected.txt:
  • platform/mac/svg/text/text-text-04-t-expected.txt:
  • platform/mac/svg/text/text-text-05-t-expected.txt:
  • platform/mac/svg/text/text-text-06-t-expected.txt:
  • platform/mac/svg/text/text-text-07-t-expected.txt:
  • platform/mac/svg/text/text-text-08-b-expected.txt:
  • platform/mac/svg/text/text-tref-01-b-expected.txt:
  • platform/mac/svg/text/text-tselect-01-b-expected.txt:
  • platform/mac/svg/text/text-tselect-02-f-expected.txt:
  • platform/mac/svg/text/text-tspan-01-b-expected.txt:
  • platform/mac/svg/text/text-vkern-expected.txt:
  • platform/mac/svg/text/text-ws-01-t-expected.txt:
  • platform/mac/svg/text/text-ws-02-t-expected.txt:
  • platform/mac/svg/text/textPathBoundsBug-expected.txt:
  • platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.txt:
  • platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
  • platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
  • platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.txt:
  • platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.txt:
  • platform/mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.txt:
  • platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
  • platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
  • platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt:
  • platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
  • platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.txt:
  • platform/mac/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.txt:
  • platform/mac/svg/zoom/text/absolute-sized-document-scrollbars-expected.txt:
  • platform/mac/svg/zoom/text/relative-sized-document-scrollbars-expected.txt:
  • platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:
  • platform/mac/svg/zoom/text/zoom-foreignObject-expected.txt:
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-009-expected.txt:
  • platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
  • platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.txt:
  • svg/custom/animation-currentColor-expected.txt:
  • svg/custom/gradient-with-1d-boundingbox-expected.txt:
  • svg/custom/radial-gradient-with-outstanding-focalPoint-expected.txt:
  • svg/custom/text-dom-removal-expected.txt:
  • svg/custom/text-zoom-expected.txt:
  • svg/custom/transformedMaskFails-expected.txt:
  • svg/custom/use-clipped-transform-expected.txt:
  • svg/custom/use-elementInstance-event-target-expected.txt:
  • svg/custom/use-elementInstance-methods-expected.txt:
  • svg/custom/use-setAttribute-crash-expected.txt:
  • svg/dom/SVGRectElement/rect-modify-rx-expected.txt:
2:29 AM Changeset in webkit [69385] by abecsi@webkit.org
  • 4 edits
    2 adds in trunk

2010-10-08 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Add new platform and initial Skipped list for the Qt port of WebKit2.
The list was copied from mac-wk2/Skipped and the Mac specific tests were removed.
https://bugs.webkit.org/show_bug.cgi?id=47401

  • platform/qt-wk2/Skipped: Added.

2010-10-08 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Add support for Qt's WebKitTestRunner to old-run-webkit-tests.
https://bugs.webkit.org/show_bug.cgi?id=47401

  • Scripts/build-webkittestrunner:
  • Scripts/old-run-webkit-tests:
2:22 AM Changeset in webkit [69384] by kbalazs@webkit.org
  • 6 edits in trunk/WebKitTools

WTR first compile: fix compile issues. https://bugs.webkit.org/show_bug.cgi?id=47343

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2010-10-07
Reviewed by Kenneth Rohde Christiansen.

  • WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  • WebKitTestRunner/TestController.cpp:
  • WebKitTestRunner/TestInvocation.cpp:
2:07 AM Changeset in webkit [69383] by kinuko@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-08 Kinuko Yasuda <kinuko@chromium.org>

Unreviewed, updating test expectations.

  • platform/chromium/test_expectations.txt:
1:38 AM Changeset in webkit [69382] by kinuko@chromium.org
  • 5 edits in trunk

2010-10-08 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by David Levin.

Fix FileSystem path validation order to normalize '..' and '.' before restriction checks
https://bugs.webkit.org/show_bug.cgi?id=47309

Test: fast/filesystem/op-get-entry.html

  • fileapi/DOMFileSystemBase.cpp: (WebCore::DOMFileSystemBase::getFile): Fixed the path validation order. (WebCore::DOMFileSystemBase::getDirectory): Fixed the path validation order.

2010-10-08 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by David Levin.

Fix FileSystem path validation order to normalize '..' and '.' before restriction checks
https://bugs.webkit.org/show_bug.cgi?id=47309

  • fast/filesystem/op-get-entry-expected.txt: Updated.
  • fast/filesystem/resources/op-get-entry.js: Updated.
12:53 AM Changeset in webkit [69381] by commit-queue@webkit.org
  • 5 edits
    1 copy in trunk/WebCore

2010-10-08 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Port GTK+ theming code to GTK+ 3.x APIs
https://bugs.webkit.org/show_bug.cgi?id=47398

Create a new gtk3drawing file for the widget drawing primitives in
WebKit, using the GTK+ 3.x APIs. It's very similar to the GTK+ 2.x
code at the moment, but we'll evolve it incrementally from here.

  • GNUmakefile.am:
  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::partsForDrawable): (WebCore::RenderThemeGtk::paintMozillaGtkWidget):
  • platform/gtk/gtk2drawing.c: (TSOffsetStyleGCArray): (TSOffsetStyleGCs): (moz_gtk_button_paint): (moz_gtk_scrollbar_thumb_paint): (moz_gtk_entry_paint): (moz_gtk_combo_box_paint): (moz_gtk_get_widget_border):
  • platform/gtk/gtk3drawing.c: Added.
  • platform/gtk/gtkdrawing.h:

Oct 7, 2010:

11:36 PM Changeset in webkit [69380] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-07 Daniel Cheng <dcheng@chromium.org>

Reviewed by Kent Tamura.

[chromium] Fix indentation in ChromiumDataObject.h
https://bugs.webkit.org/show_bug.cgi?id=47396

Just a cleanup patch to make followup diffs smaller.

  • platform/chromium/ChromiumDataObject.h: (WebCore::ChromiumDataObject::create): (WebCore::ChromiumDataObject::copy): (WebCore::ChromiumDataObject::urlTitle): (WebCore::ChromiumDataObject::setUrlTitle): (WebCore::ChromiumDataObject::htmlBaseUrl): (WebCore::ChromiumDataObject::setHtmlBaseUrl): (WebCore::ChromiumDataObject::containsFilenames): (WebCore::ChromiumDataObject::filenames): (WebCore::ChromiumDataObject::setFilenames): (WebCore::ChromiumDataObject::fileExtension): (WebCore::ChromiumDataObject::setFileExtension): (WebCore::ChromiumDataObject::fileContentFilename): (WebCore::ChromiumDataObject::setFileContentFilename): (WebCore::ChromiumDataObject::fileContent): (WebCore::ChromiumDataObject::setFileContent):
11:08 PM Changeset in webkit [69379] by Martin Robinson
  • 3 edits in trunk/LayoutTests

2010-10-07 Martin Robinson <mrobinson@igalia.com>

Rebaseline failing GTK+ tests.

  • platform/gtk/fonts/fontconfig-synthetic-bold-expected.txt:
  • platform/gtk/fonts/fontconfig-synthetic-oblique-expected.txt:
10:47 PM Changeset in webkit [69378] by tkent@chromium.org
  • 23 edits in trunk/WebCore

2010-10-07 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Refactor HTMLInputElement: Move valueAsDate and valueAsNumber implementations
https://bugs.webkit.org/show_bug.cgi?id=47327

Move the content of HTMLInputElement::valueAsDate(), setValueAsDate(),
valueAsNumber(), and setValueAsNumber() to InputType, and move
serialize() and serializeForDateTimeTypes() too

  • html/BaseDateAndTimeInputType.cpp: (WebCore::BaseDateAndTimeInputType::valueAsDate): (WebCore::BaseDateAndTimeInputType::setValueAsDate): (WebCore::BaseDateAndTimeInputType::valueAsNumber): (WebCore::BaseDateAndTimeInputType::setValueAsNumber): (WebCore::BaseDateAndTimeInputType::serialize):
  • html/BaseDateAndTimeInputType.h:
  • html/DateInputType.cpp: (WebCore::DateInputType::setMillisecondToDateComponents):
  • html/DateInputType.h:
  • html/DateTimeInputType.cpp: (WebCore::DateTimeInputType::setMillisecondToDateComponents):
  • html/DateTimeInputType.h:
  • html/DateTimeLocalInputType.cpp: (WebCore::DateTimeLocalInputType::valueAsDate): (WebCore::DateTimeLocalInputType::setValueAsDate): (WebCore::DateTimeLocalInputType::setMillisecondToDateComponents):
  • html/DateTimeLocalInputType.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueAsDate): (WebCore::HTMLInputElement::setValueAsDate): (WebCore::HTMLInputElement::valueAsNumber): (WebCore::HTMLInputElement::setValueAsNumber): (WebCore::HTMLInputElement::stepUpFromRenderer):
  • html/HTMLInputElement.h:
  • html/InputType.cpp: (WebCore::InputType::valueAsDate): (WebCore::InputType::setValueAsDate): (WebCore::InputType::valueAsNumber): (WebCore::InputType::setValueAsNumber): (WebCore::InputType::serialize):
  • html/InputType.h:
  • html/MonthInputType.cpp: (WebCore::MonthInputType::valueAsDate): (WebCore::MonthInputType::setValueAsDate): (WebCore::MonthInputType::setMillisecondToDateComponents):
  • html/MonthInputType.h:
  • html/NumberInputType.cpp: (WebCore::NumberInputType::valueAsNumber): (WebCore::NumberInputType::setValueAsNumber): (WebCore::NumberInputType::serialize):
  • html/NumberInputType.h:
  • html/RangeInputType.cpp: (WebCore::RangeInputType::valueAsNumber): (WebCore::RangeInputType::setValueAsNumber): (WebCore::RangeInputType::serialize):
  • html/RangeInputType.h:
  • html/TimeInputType.cpp: (WebCore::TimeInputType::setMillisecondToDateComponents):
  • html/TimeInputType.h:
  • html/WeekInputType.cpp: (WebCore::WeekInputType::setMillisecondToDateComponents):
  • html/WeekInputType.h:
10:36 PM Changeset in webkit [69377] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-07 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/drt_expectations.txt: Add recent failures.
9:43 PM Changeset in webkit [69376] by commit-queue@webkit.org
  • 4 edits in trunk/WebKit/efl

2010-10-07 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Implement pageRect() function
https://bugs.webkit.org/show_bug.cgi?id=47395

Implement pageRect() in ChromeClientEfl using frameRect().

  • CMakeListsEfl.txt:
  • WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::pageRect):
  • ewk/ewk_private.h:
  • ewk/ewk_view.cpp: (ewk_view_page_rect_get): Added.
9:43 PM Changeset in webkit [69375] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-10-07 Zhenyao Mo <zmo@google.com>

Unreviewerd, update DRT WebGL test expectations.

  • platform/chromium/drt_expectations.txt
9:31 PM Changeset in webkit [69374] by noam.rosenthal@nokia.com
  • 1 edit
    6 adds in trunk/WebCore

2010-10-07 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Texmap] [Qt] Texture mapper initial implementation
Texture Mapper is an implementation of accelerated compositing that doesn't require a
platform specific scenegraph library like CA or QGraphicsView. The idea is that with
time this would replace GraphicsLayerQt, and could serve as an implementation for other
platforms that don't have a scenegraph library. The first stage of this is to add all the code to trunk,
and enable it in Qt with an opt-in build flag so that it can be easily tested. Once it reaches
an adequate level of stability, we can enable it by default and eventually have it replace GraphicsLayerQt.

This change includes only the common new files and the Qt backend; Still to come: the GL backend and integration layer.

  • platform/graphics/qt/TextureMapperQt.cpp: Added.
  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp: Added.
  • platform/graphics/texmap/GraphicsLayerTextureMapper.h: Added.
  • platform/graphics/texmap/TextureMapper.h: Added.
  • platform/graphics/texmap/TextureMapperPlatformLayer.h: Added.
8:53 PM Changeset in webkit [69373] by tonikitoo@webkit.org
  • 12 edits in trunk

[Mac] [DRT] implement setSpatialNavigationEnabled
https://bugs.webkit.org/show_bug.cgi?id=47291

Patch by Antonio Gomes <agomes@rim.com> on 2010-10-07
Reviewed by Simon Fraser.

WebCore:

Added Settings::setSpatialNavigationEnabled symbols to WebKit.exp.in
so it can be used from WebKit/mac.

  • WebCore.exp.in:

WebKit/mac:

Added the needed bits to make it possible to enabled spatial navigation
for the Mac port. For now it is being only used by DRT.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences isSpatialNavigationEnabled]):
(-[WebPreferences setSpatialNavigationEnabled:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChangedNotification:]):

WebKitTools:

Implemented LayoutTestController::setSpatialNavigationEnabled for Mac's DRT
so it can track regression on the existing implementation and future improvements
we are making.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::setSpatialNavigationEnabled):

LayoutTests:

Unskiping all spatial-navigation tests in fast/events/spatial-navigation but two
(snav-iframe-with-offscreen-focusable-element.html and snav-unit-overflow-and-scroll-in-direction.html).
These will be fixed on their own bugs.

  • platform/mac/Skipped:
8:16 PM Changeset in webkit [69372] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-10-07 David Goodwin <david_goodwin@apple.com>

Reviewed by Oliver Hunt.

ARM JIT generates undefined operations due to partially uninitialized ShiftTypeAndAmount
https://bugs.webkit.org/show_bug.cgi?id=47356

  • assembler/ARMv7Assembler.h:
7:31 PM Changeset in webkit [69371] by zmo@google.com
  • 2 edits in trunk/WebKit/chromium

2010-10-07 Zhenyao Mo <zmo@google.com>

Unreviewed, roll chromium to r61902.

  • DEPS
7:03 PM Changeset in webkit [69370] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-07 Eric Uhrhane <ericu@chromium.org>

Reviewed by Jian Li

[V8] Add FileWriter to active DOM map
https://bugs.webkit.org/show_bug.cgi?id=47380

It's an ActiveDOMObject; it needs to be in the map.

  • bindings/scripts/CodeGeneratorV8.pm:
6:51 PM Changeset in webkit [69369] by thakis@chromium.org
  • 3 edits in trunk/WebCore

2010-10-07 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Make sure to update the current graphics context when calling out to AppKit.
https://bugs.webkit.org/show_bug.cgi?id=47387

This ports r57741 to ThemeChromiumMac. It also reverts r66975, which is
now no longer necessary.

Should be covered by existing tests. The checkbox at
http://webkit.org/blog-files/3d-transforms/morphing-cubes.html should
now show up correctly.

  • platform/chromium/ThemeChromiumMac.mm: (WebCore::paintCheckbox): (WebCore::paintRadio): Create current context.
  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::updateContents): Remove LocalCurrentContext, it's now no longer necessary.
6:44 PM Changeset in webkit [69368] by inferno@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-07 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Skipping failing test on qt because of incorrect behavior.
https://bugs.webkit.org/show_bug.cgi?id=47388

  • platform/qt/Skipped:
6:18 PM Changeset in webkit [69367] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-10-07 Martin Robinson <mrobinson@igalia.com>

Very small reorganization of the GTK+ skipped list.

  • platform/gtk/Skipped: Moved to the formdata skipped line to the beginDragWithFiles section.
6:00 PM Changeset in webkit [69366] by Martin Robinson
  • 2 edits
    21 moves in trunk/LayoutTests

2010-10-07 Martin Robinson <mrobinson@igalia.com>

Move GTK+ specific baselines to the platform-specific directories. In my
last commit I mistakenly added these to the platform-independent locations.
Also fix another baseline which seems to differ on the bots because they
have a different version of DejaVu Serif than my machine.

  • platform/gtk/fast/blockflow/block-level-images-expected.txt: Renamed from LayoutTests/fast/blockflow/block-level-images-expected.txt.
  • platform/gtk/fast/blockflow/fieldsets-expected.txt: Renamed from LayoutTests/fast/blockflow/fieldsets-expected.txt.
  • platform/gtk/fast/blockflow/floats-in-block-layout-expected.txt: Renamed from LayoutTests/fast/blockflow/floats-in-block-layout-expected.txt.
  • platform/gtk/fast/blockflow/inline-direction-positioning-expected.txt: Renamed from LayoutTests/fast/blockflow/inline-direction-positioning-expected.txt.
  • platform/gtk/fast/blockflow/margin-collapse-expected.txt: Renamed from LayoutTests/fast/blockflow/margin-collapse-expected.txt.
  • platform/gtk/fast/blockflow/root-lr-basic-expected.txt: Renamed from LayoutTests/fast/blockflow/root-lr-basic-expected.txt.
  • platform/gtk/fast/blockflow/self-collapsing-block-expected.txt: Renamed from LayoutTests/fast/blockflow/self-collapsing-block-expected.txt.
  • platform/gtk/fast/css/first-letter-punctuation-expected.txt: Renamed from LayoutTests/fast/css/first-letter-punctuation-expected.txt.
  • platform/gtk/fast/css/font-face-opentype-expected.txt: Renamed from LayoutTests/fast/css/font-face-opentype-expected.txt.
  • platform/gtk/fast/css/rtl-to-viewport-expected.txt: Renamed from LayoutTests/fast/css/rtl-to-viewport-expected.txt.
  • platform/gtk/fast/css/transformed-mask-expected.txt: Renamed from LayoutTests/fast/css/transformed-mask-expected.txt.
  • platform/gtk/fast/fonts/fontconfig-synthetic-bold-exepcted.txt: Updated baseline.
  • platform/gtk/fast/forms/input-button-sizes-expected.txt: Renamed from LayoutTests/fast/forms/input-button-sizes-expected.txt.
  • platform/gtk/fast/forms/input-placeholder-focus-twice-expected.txt: Renamed from LayoutTests/fast/forms/input-placeholder-focus-twice-expected.txt.
  • platform/gtk/inspector/console-uncaught-exception-expected.txt: Renamed from LayoutTests/inspector/console-uncaught-exception-expected.txt.
  • platform/gtk/svg/custom/image-rescale-expected.txt: Renamed from LayoutTests/svg/custom/image-rescale-expected.txt.
  • platform/gtk/svg/custom/text-rotation-expected.txt: Renamed from LayoutTests/svg/custom/text-rotation-expected.txt.
  • platform/gtk/svg/custom/text-x-dy-lists-expected.txt: Renamed from LayoutTests/svg/custom/text-x-dy-lists-expected.txt.
  • platform/gtk/svg/custom/use-invalid-style-expected.txt: Renamed from LayoutTests/svg/custom/use-invalid-style-expected.txt.
  • platform/gtk/svg/filters/filterRes1-expected.txt: Renamed from LayoutTests/svg/filters/filterRes1-expected.txt.
  • platform/gtk/svg/filters/filterRes2-expected.txt: Renamed from LayoutTests/svg/filters/filterRes2-expected.txt.
  • platform/gtk/svg/filters/filterRes3-expected.txt: Renamed from LayoutTests/svg/filters/filterRes3-expected.txt.
5:54 PM Changeset in webkit [69365] by zmo@google.com
  • 2 edits in trunk/WebKit/chromium

2010-10-07 Zhenyao Mo <zmo@google.com>

Reviewed by Tony Chang.

Copy mesa lib into DumpRenderTree bundle in Mac
https://bugs.webkit.org/show_bug.cgi?id=47385

  • WebKit.gyp:
5:49 PM Changeset in webkit [69364] by jianli@chromium.org
  • 5 edits in trunk/LayoutTests

Unreviewed. Skip the new test in those unsupported platforms.

  • platform/gtk/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
5:48 PM Changeset in webkit [69363] by dpranke@chromium.org
  • 3 edits
    2 adds in trunk/WebKitTools

2010-10-07 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

rebaseline-chromium-webkit-tests relied on the filename_to_uri()
hook in the Port infrastructure to generate URIs for the files
in its summary HTML report; however, that method is supposed to only
be used for test files (and should really be renamed), so this would
crash.

This change adds a new "path" module to the system package with a
routine called abspath_to_uri() that handles converting paths to
file: URIs independently of anything in the layout_tests package,
and changes the code to use this. At some point in the near future
the layout_tests/port/* code should use this as well.

This change also deletes a bunch of unused code and fixes some
comments in rebaseline_chromium_webkit_tests.py.

https://bugs.webkit.org/show_bug.cgi?id=47319

  • Scripts/webkitpy/common/system/path.py: Added.
  • Scripts/webkitpy/common/system/path_unittest.py: Added.
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
5:47 PM Changeset in webkit [69362] by inferno@chromium.org
  • 1 edit in trunk/LayoutTests/ChangeLog

2010-10-07 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Tests for crash when multiple objects tags with bad image content are nested as fallback content.
https://bugs.webkit.org/show_bug.cgi?id=46921

  • fast/html/object-image-nested-fallback-expected.txt: Added.
  • fast/html/object-image-nested-fallback.html: Added.
5:41 PM Changeset in webkit [69361] by jer.noble@apple.com
  • 3 edits in trunk/WebKit/mac

Fix the Leopard 64-bit build.

  • Configurations/WebKit.xcconfig: Add CoreServices.framework/Frameworks to the

framework search path.

  • WebView/WebVideoFullscreenController.mm: Explicitly import <OSStatus/Power.h>.
5:35 PM Changeset in webkit [69360] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2010-10-07 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Postpone clearing the imageLoader when rendering certain fallback content for objects until after the attach().
https://bugs.webkit.org/show_bug.cgi?id=46921

Test: fast/html/object-image-nested-fallback.html

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::renderFallbackContent):

2010-10-07 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Tests for crash when multiple objects tags with bad image content are nested as fallback content.
https://bugs.webkit.org/show_bug.cgi?id=46921

  • accessibility/plugin.html:
  • fast/html/object-image-nested-fallback-expected.txt: Added.
  • fast/html/object-image-nested-fallback.html: Added.
5:31 PM Changeset in webkit [69359] by Martin Robinson
  • 1 edit
    60 adds in trunk/LayoutTests

2010-10-07 Martin Robinson <mrobinson@igalia.com>

Add some GTK+ specific baselines.

  • fast/blockflow/block-level-images-expected.txt: Copied from LayoutTests/platform/mac/fast/blockflow/block-level-images-expected.txt.
  • fast/blockflow/fieldsets-expected.txt: Added.
  • fast/blockflow/floats-in-block-layout-expected.txt: Copied from LayoutTests/platform/mac/fast/blockflow/floats-in-block-layout-expected.txt.
  • fast/blockflow/inline-direction-positioning-expected.txt: Copied from LayoutTests/platform/mac/fast/blockflow/inline-direction-positioning-expected.txt.
  • fast/blockflow/margin-collapse-expected.txt: Copied from LayoutTests/platform/mac/fast/blockflow/margin-collapse-expected.txt.
  • fast/blockflow/root-lr-basic-expected.txt: Copied from LayoutTests/platform/mac/fast/blockflow/root-lr-basic-expected.txt.
  • fast/blockflow/self-collapsing-block-expected.txt: Copied from LayoutTests/platform/mac/fast/blockflow/self-collapsing-block-expected.txt.
  • fast/css/first-letter-punctuation-expected.txt: Added.
  • fast/css/font-face-opentype-expected.txt: Added.
  • fast/css/rtl-to-viewport-expected.txt: Added.
  • fast/css/transformed-mask-expected.txt: Added.
  • fast/forms/input-button-sizes-expected.txt: Added.
  • fast/forms/input-placeholder-focus-twice-expected.txt: Added.
  • inspector/console-uncaught-exception-expected.txt: Added.
  • platform/gtk/fast/blockflow/block-level-images-expected.checksum: Added.
  • platform/gtk/fast/blockflow/block-level-images-expected.png: Added.
  • platform/gtk/fast/blockflow/fieldsets-expected.checksum: Added.
  • platform/gtk/fast/blockflow/fieldsets-expected.png: Added.
  • platform/gtk/fast/blockflow/floats-in-block-layout-expected.checksum: Copied from LayoutTests/platform/mac/fast/blockflow/floats-in-block-layout-expected.checksum.
  • platform/gtk/fast/blockflow/floats-in-block-layout-expected.png: Added.
  • platform/gtk/fast/blockflow/inline-direction-positioning-expected.checksum: Copied from LayoutTests/platform/mac/fast/blockflow/inline-direction-positioning-expected.checksum.
  • platform/gtk/fast/blockflow/inline-direction-positioning-expected.png: Added.
  • platform/gtk/fast/blockflow/margin-collapse-expected.checksum: Copied from LayoutTests/platform/mac/fast/blockflow/margin-collapse-expected.checksum.
  • platform/gtk/fast/blockflow/margin-collapse-expected.png: Added.
  • platform/gtk/fast/blockflow/root-lr-basic-expected.checksum: Copied from LayoutTests/platform/mac/fast/blockflow/root-lr-basic-expected.checksum.
  • platform/gtk/fast/blockflow/root-lr-basic-expected.png: Added.
  • platform/gtk/fast/blockflow/self-collapsing-block-expected.checksum: Copied from LayoutTests/platform/mac/fast/blockflow/self-collapsing-block-expected.checksum.
  • platform/gtk/fast/blockflow/self-collapsing-block-expected.png: Added.
  • platform/gtk/fast/css/first-letter-punctuation-expected.checksum: Added.
  • platform/gtk/fast/css/first-letter-punctuation-expected.png: Added.
  • platform/gtk/fast/css/font-face-opentype-expected.checksum: Added.
  • platform/gtk/fast/css/font-face-opentype-expected.png: Added.
  • platform/gtk/fast/css/rtl-to-viewport-expected.checksum: Added.
  • platform/gtk/fast/css/rtl-to-viewport-expected.png: Added.
  • platform/gtk/fast/css/transformed-mask-expected.checksum: Added.
  • platform/gtk/fast/css/transformed-mask-expected.png: Added.
  • platform/gtk/fast/forms/input-button-sizes-expected.checksum: Added.
  • platform/gtk/fast/forms/input-button-sizes-expected.png: Added.
  • platform/gtk/fast/forms/input-placeholder-focus-twice-expected.checksum: Added.
  • platform/gtk/fast/forms/input-placeholder-focus-twice-expected.png: Added.
  • platform/gtk/svg/custom/image-rescale-expected.checksum: Copied from LayoutTests/platform/chromium-linux/svg/custom/image-rescale-expected.checksum.
  • platform/gtk/svg/custom/image-rescale-expected.png: Added.
  • platform/gtk/svg/custom/text-rotation-expected.checksum: Added.
  • platform/gtk/svg/custom/text-rotation-expected.png: Added.
  • platform/gtk/svg/custom/text-x-dy-lists-expected.checksum: Added.
  • platform/gtk/svg/custom/text-x-dy-lists-expected.png: Added.
  • platform/gtk/svg/filters/filterRes1-expected.checksum: Copied from LayoutTests/platform/chromium-win/svg/filters/filterRes1-expected.checksum.
  • platform/gtk/svg/filters/filterRes1-expected.png: Added.
  • platform/gtk/svg/filters/filterRes2-expected.checksum: Added.
  • platform/gtk/svg/filters/filterRes2-expected.png: Added.
  • platform/gtk/svg/filters/filterRes3-expected.checksum: Copied from LayoutTests/platform/chromium-win/svg/filters/filterRes3-expected.checksum.
  • platform/gtk/svg/filters/filterRes3-expected.png: Added.
  • svg/custom/image-rescale-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/custom/image-rescale-expected.txt.
  • svg/custom/text-rotation-expected.txt: Added.
  • svg/custom/text-x-dy-lists-expected.txt: Added.
  • svg/custom/use-invalid-style-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/use-invalid-style-expected.txt.
  • svg/filters/filterRes1-expected.txt: Copied from LayoutTests/platform/mac/svg/filters/filterRes1-expected.txt.
  • svg/filters/filterRes2-expected.txt: Copied from LayoutTests/platform/mac/svg/filters/filterRes2-expected.txt.
  • svg/filters/filterRes3-expected.txt: Copied from LayoutTests/platform/mac/svg/filters/filterRes3-expected.txt.
5:28 PM Changeset in webkit [69358] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-07 Rafael Antognolli <antognolli@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Fix shared timers on EFL port - make them thread safe.
https://bugs.webkit.org/show_bug.cgi?id=47383

Using ecore_timer_add to create a timer from a thread that is
not the main thread isn't safe. Now we add a pipe that is used
to request a timer to be added in the main thread.

In order to reduce some delay on timers that are added with a
very small interval, the timer callback is called immediately
if the interval is smaller than the mainloop frame time.

No new features, so no tests added.

  • platform/efl/SharedTimerEfl.cpp: (WebCore::setSharedTimerFiredFunction): (WebCore::timerEvent): (WebCore::processTimers): (WebCore::pipeHandlerCb): (WebCore::stopSharedTimer): (WebCore::addNewTimer): (WebCore::setSharedTimerFireTime):
5:16 PM Changeset in webkit [69357] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2010-10-07 James Kozianski <koz@chromium.org>

Reviewed by Adam Barth.

getPropertyValue('border') is incorrect after border-top-width is set
https://bugs.webkit.org/show_bug.cgi?id=45949

CSSMutableStyleDeclaration::getCommonValue() was ignoring values from
properties that were implicitly set, which led to erroneous results
from getPropertyValue().

  • fast/dom/css-shorthand-common-value-expected.txt: Added.
  • fast/dom/css-shorthand-common-value.html: Added.

2010-10-07 James Kozianski <koz@chromium.org>

Reviewed by Adam Barth.

getPropertyValue('border') is incorrect after border-top-width is set
https://bugs.webkit.org/show_bug.cgi?id=45949

Test: fast/dom/css-shorthand-common-value.html

CSSMutableStyleDeclaration::getCommonValue() was ignoring values from
properties that were implicitly set, which led to erroneous results
from getPropertyValue().

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getCommonValue):
5:07 PM Changeset in webkit [69356] by mrowe@apple.com
  • 3 edits in trunk/WebKit2

<rdar://problem/8349882> Many WebProcess sandbox violations during basic browsing operations.

Patch by Ivan Krstić <ike@apple.com> on 2010-10-07
Reviewed by Mark Rowe.

  • WebProcess/com.apple.WebProcess.sb:
  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain):

4:57 PM Changeset in webkit [69355] by Martin Robinson
  • 4 edits in trunk

2010-10-07 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] The FreeType backend does not respect the FC_EMBOLDEN property
https://bugs.webkit.org/show_bug.cgi?id=46216

Fix a baseline that was merged improperly.

  • platform/gtk/fonts/fontconfig-synthetic-bold-expected.txt: Fix baseline.

2010-10-07 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] The FreeType backend does not respect the FC_EMBOLDEN property
https://bugs.webkit.org/show_bug.cgi?id=46216

Fix my latest commit, as it contained some bad changes from a merge gone wrong.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (initializeFonts): Also initialize the DevaVu Sans font.
4:55 PM Changeset in webkit [69354] by rniwa@webkit.org
  • 9 edits
    4 adds in trunk

2010-10-07 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

REGRESSION: Indenting pre duplicates content
https://bugs.webkit.org/show_bug.cgi?id=47233

The bug was caused by our not splitting text nodes properly.

In new approach, we split text nodes in each iteration. Added rangeForParagraphSplitingTextNodesIfNeeded
to split text nodes at the start and at the end of paragraph, which also adjusts start and end positions
for moveParagraphWithClones. Added endOfNextParagrahSplittingTextNodesIfNeeded to adjust endOfNextParagraph,
start, and end to work-around moveParagraphWithClones's removing a line feed.

Tests: editing/execCommand/indent-pre-list.html

editing/execCommand/indent-pre-paragraphs.html

  • editing/ApplyBlockElementCommand.cpp: (WebCore::ApplyBlockElementCommand::formatSelection): See above. (WebCore::isNewLineAtPosition): (WebCore::renderStyleOfEnclosingTextNode): Added. (WebCore::ApplyBlockElementCommand::rangeForParagraphSplittingTextNodesIfNeeded): Added. (WebCore::ApplyBlockElementCommand::endOfNextParagrahSplittingTextNodesIfNeeded): Added.
  • editing/ApplyBlockElementCommand.h:
  • editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::formatRange): Takes two Positions instead of one VisiblePosition.
  • editing/FormatBlockCommand.h:
  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::tryIndentingAsListItem): Ditto. (WebCore::IndentOutdentCommand::indentIntoBlockquote): Ditto. (WebCore::IndentOutdentCommand::formatRange): Ditto.
  • editing/IndentOutdentCommand.h:

2010-10-07 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

REGRESSION: Indenting pre duplicates content
https://bugs.webkit.org/show_bug.cgi?id=47233

Added tests to ensure WebKit indents texts inside pre correctly.

  • editing/execCommand/indent-pre-expected.txt: This test passes if WebKit does not crash.
  • editing/execCommand/indent-pre-list-expected.txt: Added.
  • editing/execCommand/indent-pre-list.html: Added.
  • editing/execCommand/indent-pre-paragraphs-expected.txt: Added.
  • editing/execCommand/indent-pre-paragraphs.html: Added.
4:45 PM Changeset in webkit [69353] by ajwong@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed. Build fix.

Reflecting move of autocorrection tests made in r69351.

  • platform/chromium/test_expectations.txt:
4:38 PM Changeset in webkit [69352] by ajwong@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed. Build fix.

The breakage of r69334 fast/css/transformed-mask.svg

  • platform/chromium/test_expectations.txt:
4:32 PM Changeset in webkit [69351] by bweinstein@apple.com
  • 5 edits
    4 adds
    4 deletes in trunk/LayoutTests

Autocorrection panel regression tests fail on Windows
https://bugs.webkit.org/show_bug.cgi?id=47341
<rdar://problem/8523631>

Patch by Jia Pu <jpu@apple.com> on 2010-10-07
Reviewed by Adele Peterson.

Move Mac specific tests to platform/mac directory.

  • editing/spelling/autocorrection-delete.html: Removed.
  • editing/spelling/autocorrection-removing-underline-after-paste.html: Removed.
  • editing/spelling/autocorrection-removing-underline.html: Removed.
  • editing/spelling/autocorrection-simple.html: Removed.
  • platform/mac-leopard/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-tiger/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/mac/editing/spelling/autocorrection-delete.html: Added.
  • platform/mac/editing/spelling/autocorrection-removing-underline-after-paste.html: Added.
  • platform/mac/editing/spelling/autocorrection-removing-underline.html: Added.
  • platform/mac/editing/spelling/autocorrection-simple.html: Added.
4:31 PM Changeset in webkit [69350] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] http/tests/local/formdata/send-form-data-constructed-from-form.html
introduced in r69349, but eventSender.beginDragWithFiles is unimplemented.

  • platform/qt/Skipped: http/tests/local/formdata/send-form-data-constructed-from-form.html added.
3:57 PM Changeset in webkit [69349] by jianli@chromium.org
  • 7 edits
    3 adds in trunk

Support generating a FormData object based on the data in an existing <form>.
https://bugs.webkit.org/show_bug.cgi?id=45929

Reviewed by Adam Barth.

WebCore:

Test: http/tests/local/formdata/send-form-data-constructed-from-form.html

  • bindings/js/JSDOMFormDataCustom.cpp:

(WebCore::toHTMLFormElement):
(WebCore::JSDOMFormDataConstructor::constructJSDOMFormData):

  • bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::constructorCallback):

  • html/DOMFormData.cpp:

(WebCore::DOMFormData::DOMFormData):

  • html/DOMFormData.h:

(WebCore::DOMFormData::create):

  • html/DOMFormData.idl:

LayoutTests:

Add a new test to test this functionality.

  • http/tests/local/formdata/resources/test.txt: Copied from LayoutTests/fast/files/resources/UTF8.txt.
  • http/tests/local/formdata/send-form-data-constructed-from-form-expected.txt: Added.
  • http/tests/local/formdata/send-form-data-constructed-from-form.html: Added.
3:51 PM Changeset in webkit [69348] by beidson@apple.com
  • 3 edits in trunk/WebKit2

Build fix.

GCC continued to mask the fact that I still hadn't declared the correct symbol.

  • Platform/Logging.cpp:

(initializeLogChannel):

  • Platform/Logging.h:
3:36 PM Changeset in webkit [69347] by bweinstein@apple.com
  • 2 edits in trunk/WebKit2

Build Fix. Fix the vcproj to make it valid and openable by Visual Studio.

  • win/WebKit2.vcproj:
3:04 PM Changeset in webkit [69346] by commit-queue@webkit.org
  • 7 edits in trunk

2010-10-07 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Minor naming cleanup in WebDragData, part 2
https://bugs.webkit.org/show_bug.cgi?id=47227

Chromium no longer uses the deprecated methods, so delete them.

  • DEPS:
  • public/WebDragData.h:
  • src/WebDragData.cpp:

2010-10-07 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Minor naming cleanup in WebDragData, part 2
https://bugs.webkit.org/show_bug.cgi?id=47227

Update DRT to use the renamed methods.

  • DumpRenderTree/chromium/EventSender.cpp: (EventSender::beginDragWithFiles):
  • DumpRenderTree/chromium/WebViewHost.cpp: (addDRTFakeFileToDataObject):
3:00 PM Changeset in webkit [69345] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

2010-10-07 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Set the m_selectedChildren flag on the root inline box if one of the leaf
inline box from the bidi runs walk has a selection state. Remove the flag
setting logic from addToLine, since line boxes created in createLinesBoxes
should not be propagating selection state to root inline box.
https://bugs.webkit.org/show_bug.cgi?id=47201

Test: editing/selection/root-inlinebox-selected-children-crash.html

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::addToLine):
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::constructLine):

2010-10-07 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Tests that we don't crash while setting selected children on the root inline box.
https://bugs.webkit.org/show_bug.cgi?id=47201

  • editing/selection/root-inlinebox-selected-children-crash-expected.txt: Added.
  • editing/selection/root-inlinebox-selected-children-crash.html: Added.
2:51 PM Changeset in webkit [69344] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-07 Benjamin Otte <otte@gnome.org>

Reviewed by Martin Robinson.

[GTK] Code cleanup in PluginViewGtk.cpp for transparent plugins
https://bugs.webkit.org/show_bug.cgi?id=47361

Reduce some code in PluginViewGtk.cpp by doing things with Cairo instead
of directly with X11. This should work fine with GDK double-buffering, but
if we ever disable it, we'll need to verify that this is still functioning
properly.

  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::paint): Do a bit of code cleanup.
2:49 PM Changeset in webkit [69343] by andersca@apple.com
  • 17 edits
    3 copies
    2 adds in trunk

Add a WKPageFindClient, hook up WKPageCountStringMatches
https://bugs.webkit.org/show_bug.cgi?id=47373

Reviewed by Sam Weinig.

WebCore:

Export find related symbols needed by WebKit2.

  • WebCore.exp.in:

WebKit2:

  • Shared/APIClient.h: Added.

Add an APIClient class template which can be used to reduce duplicated
code in the client wrappers.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageFindClient):
Initialize the page find client.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebFindClient.cpp: Added.

(WebKit::WebFindClient::didCountStringMatches):
Call the WKPageFindClient function.

  • UIProcess/WebFindClient.h: Added.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeFindClient):
Initialize the WebFindClient.

(WebKit::WebPageProxy::findString):
Send a FindString message.

(WebKit::WebPageProxy::hideFindUI):
Send a HideFindUI message.

(WebKit::WebPageProxy::countStringMatches):
Send a CountStringMatches message.

(WebKit::WebPageProxy::didCountStringMatches):
Call the find client.

  • UIProcess/WebPageProxy.messages.in:

Add new message.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::findString):
(WebKit::WebPage::hideFindUI):
Add stubs.

(WebKit::WebPage::countStringMatches):
Figure out the number of matches and send them back in the DidCountStringMatches msessage.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

Add new messages.

  • win/WebKit2.vcproj:

Add new files.

WebKitTools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

Remove hard coded paths.

  • TestWebKitAPI/Tests/WTF/VectorBasic.cpp:

(TestWebKitAPI::TEST):
Fix expected result.

  • TestWebKitAPI/Tests/WebKit2/Find.cpp: Added.

(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::didCountStringMatches):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/find.html: Added.

Add test for WKPageCountStringMatches.

2:21 PM Changeset in webkit [69342] by ajwong@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed. Build fix.

r69334 broke Chromium rendering of fast/css/transformed-mask.svg.

  • platform/chromium/test_expectations.txt:
2:16 PM Changeset in webkit [69341] by hyatt@apple.com
  • 7 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=47370

Reviewed by Sam Weinig.

Make line box placement in the inline direction writing-mode-aware. Lines now set their y-position instead of x-position
when vertical.

Refactored shadow overflow to give text-shadow the same helpers in RenderStyle that box-shadow has so that the shadow-walking loop in
placeBoxesInInlineDirection can be replaced with the helper.

Overflow had to be patched to be writing-mode-aware so that the correct physical directions would be set for vertical line
boxes.

Vertical lines are still not testable until they can be placed in the block direction. Then the render tree dumps
become meaningful (even if the pixel results look horrible).

  • rendering/InlineBox.h:

(WebCore::InlineBox::logicalRight):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesInInlineDirection):

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::logicalLeftLayoutOverflow):
(WebCore::InlineFlowBox::logicalRightLayoutOverflow):
(WebCore::InlineFlowBox::logicalLeftVisualOverflow):
(WebCore::InlineFlowBox::logicalRightVisualOverflow):
(WebCore::InlineFlowBox::setInlineDirectionOverflowPositions):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::getShadowExtent):
(WebCore::RenderStyle::getShadowHorizontalExtent):
(WebCore::RenderStyle::getShadowVerticalExtent):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::getTextShadowExtent):
(WebCore::InheritedFlags::getTextShadowHorizontalExtent):
(WebCore::InheritedFlags::getTextShadowVerticalExtent):
(WebCore::InheritedFlags::getTextShadowInlineDirectionExtent):
(WebCore::InheritedFlags::getBoxShadowExtent):
(WebCore::InheritedFlags::getBoxShadowHorizontalExtent):
(WebCore::InheritedFlags::getBoxShadowVerticalExtent):
(WebCore::InheritedFlags::getBoxShadowInlineDirectionExtent):
(WebCore::InheritedFlags::getShadowInlineDirectionExtent):

2:16 PM Changeset in webkit [69340] by kinuko@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

2010-10-07 Kinuko Yasuda <kinuko@chromium.org>

Unreviewed, updating test expectations for chromium.

  • platform/chromium-win/fast/filesystem: Removed.
  • platform/chromium-win/fast/filesystem/async-operations-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
2:10 PM Changeset in webkit [69339] by kinuko@chromium.org
  • 1 edit
    25 adds in trunk/LayoutTests

2010-10-07 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by David Levin.

Add layout tests for FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=44920

Added tests for major Entry operations: copyTo, moveTo, getFile,
getDirectory, remove, createReader.readEntries, getParent.

  • fast/filesystem/op-copy-expected.txt: Added.
  • fast/filesystem/op-copy.html: Added.
  • fast/filesystem/op-get-entry-expected.txt: Added.
  • fast/filesystem/op-get-entry.html: Added.
  • fast/filesystem/op-get-parent-expected.txt: Added.
  • fast/filesystem/op-get-parent.html: Added.
  • fast/filesystem/op-move-expected.txt: Added.
  • fast/filesystem/op-move.html: Added.
  • fast/filesystem/op-read-directory-expected.txt: Added.
  • fast/filesystem/op-read-directory.html: Added.
  • fast/filesystem/op-remove-expected.txt: Added.
  • fast/filesystem/op-remove.html: Added.
  • fast/filesystem/op-restricted-chars-expected.txt: Added.
  • fast/filesystem/op-restricted-chars.html: Added.
  • fast/filesystem/op-restricted-names-expected.txt: Added.
  • fast/filesystem/op-restricted-names.html: Added.
  • fast/filesystem/resources/fs-test-util.js:
  • fast/filesystem/resources/op-copy.js: Added.
  • fast/filesystem/resources/op-get-entry.js: Added.
  • fast/filesystem/resources/op-get-parent.js: Added.
  • fast/filesystem/resources/op-move.js: Added.
  • fast/filesystem/resources/op-read-directory.js: Added.
  • fast/filesystem/resources/op-remove.js: Added.
  • fast/filesystem/resources/op-restricted-chars.js: Added.
  • fast/filesystem/resources/op-restricted-names.js: Added.
  • fast/filesystem/resources/op-tests-helper.js: Added.
2:06 PM Changeset in webkit [69338] by Simon Fraser
  • 2 edits in trunk/WebCore

2010-10-07 Simon Fraser <Simon Fraser>

Reviewed by Beth Dakin.

Use isIdentityOrTranslationOrFlipped() in scrollbar code
https://bugs.webkit.org/show_bug.cgi?id=47378

Replace old code that looked at values in the CGAffineTransform
with nicely named method that does the same test.

  • platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::paint):
2:03 PM Changeset in webkit [69337] by ajwong@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

[Chromium] Unreviewed. Build fix. New baseline.

  • platform/chromium-linux/fast/filesystem/async-operations-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
1:59 PM Changeset in webkit [69336] by mitz@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/8142645> REGRESSION (r47440): Printing Mail messages with large fonts does not fill page
https://bugs.webkit.org/show_bug.cgi?id=47374

Reviewed by Simon Fraser.

In the legacy (paint-time pagination) printing model, when there are overlapping lines,
adjustPageHeightDeprecated() was not idempotent, since the truncation point imposed by line n,
namely the top of line n, was above the bottom of line n-1, so in the next round, line n-1
moved the truncation point up again.

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::paint): Consider the top of the next line when deciding if the
current line extends below the truncation point.

1:51 PM Changeset in webkit [69335] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Update unit tests results.

  • Scripts/webkit2/messages_unittest.py:
1:48 PM Changeset in webkit [69334] by Simon Fraser
  • 3 edits
    4 adds in trunk

2010-10-07 Simon Fraser <Simon Fraser>

Reviewed by Beth Dakin.

Edge fringe artifact with transformed, masked elements (including reflections)
https://bugs.webkit.org/show_bug.cgi?id=19179

When drawing the mask images, use a transparency layer if the CTM
has a rotation, scale or skew in it to avoid antialiasing issues at
the edges.

Test: fast/css/transformed-mask.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintMask): Don't bother painting the mask if painting is disabled, which also avoids an assertion in getCTM(). (WebCore::RenderBox::paintMaskImages):
12:59 PM Changeset in webkit [69333] by beidson@apple.com
  • 2 edits in trunk/WebKit2
  • Platform/Logging.cpp:

(initializeLogChannel): GCC optimized out the only caller of this function. Windows doesn't, and is breaking.

Reviewed by BUILD FIX for non-gcc builds.

12:46 PM Changeset in webkit [69332] by ajwong@chromium.org
  • 3 edits
    5 adds in trunk/LayoutTests

[Chromium] Unreviewed. New baselines, and expectations updates.

Changing fast/frames/cached-frame-counter.html to SKIP for DEBUG
platforms since it always times out.

Upstreamed expectation:

http/tests/misc/last-modified-parsing.html

Removed expecations for these as they pass consistently:

svg/batik/text/textProperties.svg
fast/dom/Window/window-screen-properties.html
fast/media/color-does-not-include-alpha.html
fast/events/mouse-focus-imagemap.html
fast/dom/object-embed-plugin-scripting.html
fast/images/imagemap-case.html

Marked as flaky:

svg/hixie/perf/001.xml
svg/hixie/perf/002.xml
svg/W3C-SVG-1.1/animate-elem-03-t.svg

New test missing baseline:

platform/gtk/fonts/fontconfig-synthetic-bold.html

  • platform/chromium-mac/fast/images/imagemap-case-expected.checksum: Added.
  • platform/chromium-mac/fast/images/imagemap-case-expected.png: Added.
  • platform/chromium-win/fast/filesystem/async-operations-expected.txt: Added.
  • platform/chromium-win/media/audio-delete-while-slider-thumb-clicked-expected.txt: Added.
  • platform/chromium-win/svg/custom/struct-use-09-b-expected.png:
  • platform/chromium/test_expectations.txt:
12:41 PM Changeset in webkit [69331] by commit-queue@webkit.org
  • 4 edits in trunk/WebKit/qt

2010-10-07 Andreas Kling <kling@webkit.org>

Reviewed by Simon Hausmann.

[Qt] API: ViewportConfiguration => ViewportArguments
https://bugs.webkit.org/show_bug.cgi?id=47325

  • Api/qwebpage.cpp: (QWebPage::ViewportAttributes::ViewportAttributes): (QWebPage::ViewportAttributes::~ViewportAttributes): (QWebPage::ViewportAttributes::operator=): (QWebPage::viewportAttributesForSize):
  • Api/qwebpage.h:
  • Api/qwebpage_p.h: (QtViewportAttributesPrivate::QtViewportAttributesPrivate):
12:35 PM Changeset in webkit [69330] by Darin Adler
  • 2 edits in trunk/WebKit2

Fix include mistake that makes build fail with non-Objective-C.

  • Shared/API/c/mac/WKCertificateInfoMac.h: Include CoreFoundation.h,

not Foundation.h.

12:32 PM Changeset in webkit [69329] by andersca@apple.com
  • 27 edits
    1 copy
    1 add in trunk/WebKit2

Generate the messages sent to the WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=47239

Patch by Sam Weinig <sam@webkit.org> on 2010-10-07
Reviewed by Anders Carlsson.

  • DerivedSources.make:
  • DerivedSources.pro:
  • Platform/CoreIPC/Arguments.h:
  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::handleMessage):

  • Scripts/webkit2/messages.py:
  • Shared/CoreIPCSupport/WebPageProxyMessageKinds.h: Removed.
  • Shared/StringPairVector.h: Added.
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::registerEditCommand):

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::registerEditCommand):

  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebEditCommandProxy.cpp:

(WebKit::WebEditCommandProxy::unapply):
(WebKit::WebEditCommandProxy::reapply):

  • UIProcess/WebFormClient.cpp:

(WebKit::WebFormClient::willSubmitForm):

  • UIProcess/WebFormClient.h:
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in: Added.
  • UIProcess/win/WebView.cpp:

(WebKit::WebView::registerEditCommand):

  • UIProcess/win/WebView.h:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::registerCommandForUndo):
(WebKit::WebEditorClient::clearUndoRedoOperations):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebPage/WebBackForwardListProxy.cpp:
  • WebProcess/WebPage/WebPage.cpp:
  • win/WebKit2.vcproj:
12:29 PM Changeset in webkit [69328] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-07 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Map non-alphabet key code to Unicode value
https://bugs.webkit.org/show_bug.cgi?id=46002

Non-alphabet key codes are not equal to the unicode values. Add conversion.

  • platform/brew/PlatformKeyboardEventBrew.cpp: (WebCore::singleCharacterString):
12:06 PM Changeset in webkit [69327] by beidson@apple.com
  • 2 edits in trunk/WebKit2

Forgot this to keep the build working.

Reviewed by BUILD FIX.

  • WebKit2Prefix.h:
11:39 AM Changeset in webkit [69326] by Martin Robinson
  • 5 edits
    2 adds in trunk

2010-09-21 Martin Robinson <mrobinson@igalia.com>

Reviewed by Chris Fleizach.

[GTK] The FreeType backend does not respect the FC_EMBOLDEN property
https://bugs.webkit.org/show_bug.cgi?id=46216

Added tests for this issue.

  • platform/gtk/fonts/fontconfig-synthetic-bold-expected.txt: Added.
  • platform/gtk/fonts/fontconfig-synthetic-bold.html: Added.

2010-10-05 Martin Robinson <mrobinson@igalia.com>

Reviewed by Chris Fleizach.

[GTK] The FreeType backend does not respect the FC_EMBOLDEN property
https://bugs.webkit.org/show_bug.cgi?id=46216

Look for the FC_EMBOLDEN property of the FcPattern when constructing
FontPlatformData and use it to enable synthetic bold fonts when necessary.

Test: platform/gtk/fonts/fontconfig-synthetic-bold.html

  • platform/graphics/cairo/FontPlatformDataFreeType.cpp: (WebCore::FontPlatformData::FontPlatformData): Properly handle the FC_EMBOLDEN property.

2010-09-21 Martin Robinson <mrobinson@igalia.com>

Reviewed by Chris Fleizach.

[GTK] The FreeType backend does not respect the FC_EMBOLDEN property
https://bugs.webkit.org/show_bug.cgi?id=46216

  • DumpRenderTree/gtk/fonts/fonts.conf: Add a setting which enables FC_EMBOLDEN for DejaVu Serif when there is no bold version available. This is necessary to properly test the property in layout tests.
11:19 AM Changeset in webkit [69325] by andersca@apple.com
  • 6 edits
    1 add in trunk/WebKit2

Start stubbing out the find API
https://bugs.webkit.org/show_bug.cgi?id=47366
<rdar://problem/8524998>

Reviewed by John Sullivan.

  • Shared/FindOptions.h: Added.
  • UIProcess/API/C/WKAPICast.h:

(WebKit::toFindDirection):
(WebKit::toFindOptions):

  • UIProcess/API/C/WKPage.cpp:

(WKPageFindString):
(WKPageHideFindUI):
(WKPageCountStringMatches):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::findString):
(WebKit::WebPageProxy::hideFindUI):
(WebKit::WebPageProxy::countStringMatches):

  • UIProcess/WebPageProxy.h:
11:09 AM Changeset in webkit [69324] by kbalazs@webkit.org
  • 7 edits
    3 adds
    1 delete in trunk

[Qt] Build files for the WTR's InjectedBundle

11:00 AM Changeset in webkit [69323] by beidson@apple.com
  • 4 edits
    2 adds in trunk/WebKit2

Part of https://bugs.webkit.org/show_bug.cgi?id=47354 - Add WebCore/WebKit1 style logging channel mechanism0 to WebKit2,
including the first channel to be used for SessionState work.

Reviewed by Sam Weinig.

  • Platform/Logging.cpp: Added.

(initializeLogChannelsIfNecessary):

  • Platform/Logging.h: Added.
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
10:56 AM Changeset in webkit [69322] by kbalazs@webkit.org
  • 6 edits
    1 add in trunk

2010-10-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r69315.
http://trac.webkit.org/changeset/69315
https://bugs.webkit.org/show_bug.cgi?id=47363

Forgot to add the new files (Requested by kbalazs on #webkit).

  • DerivedSources.pro:

2010-10-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r69315.
http://trac.webkit.org/changeset/69315
https://bugs.webkit.org/show_bug.cgi?id=47363

Forgot to add the new files (Requested by kbalazs on #webkit).

  • Scripts/webkitdirs.pm:
  • WebKitTestRunner/qt/DerivedSources.pro: Added.

2010-10-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r69315.
http://trac.webkit.org/changeset/69315
https://bugs.webkit.org/show_bug.cgi?id=47363

Forgot to add the new files (Requested by kbalazs on #webkit).

  • WebKit2.pro:
10:56 AM Changeset in webkit [69321] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-07 James Simonsen <simonjam@chromium.org>

Reviewed by Pavel Feldman.

[Web Timing] Use platform definition of responseEnd
https://bugs.webkit.org/show_bug.cgi?id=46306

No new tests. Used existing webtiming test.

  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didFinishLoading):
10:46 AM Changeset in webkit [69320] by Martin Robinson
  • 4 edits
    4 adds in trunk

2010-10-05 Martin Robinson <mrobinson@igalia.com>

Reviewed by Chris Fleizach.

[Gtk] CSS font-style: italic behavior
https://bugs.webkit.org/show_bug.cgi?id=33299

Added a test to test the FontConfig synthetic oblique behavior.

  • platform/gtk/fonts/fontconfig-synthetic-oblique-expected.checksum: Added.
  • platform/gtk/fonts/fontconfig-synthetic-oblique-expected.png: Added.
  • platform/gtk/fonts/fontconfig-synthetic-oblique-expected.txt: Added.
  • platform/gtk/fonts/fontconfig-synthetic-oblique.html: Added.

2010-10-05 Martin Robinson <mrobinson@igalia.com>

Reviewed by Chris Fleizach.

[Gtk] CSS font-style: italic behavior
https://bugs.webkit.org/show_bug.cgi?id=33299

Properly interpret the FC_MATRIX property from a FontConfig pattern.
FontConfig will use this property when returning fonts which have a
synthetic oblique variant configured in the fonts.conf configuration
file.

Test: platform/gtk/fonts/fontconfig-synthetic-oblique.html

  • platform/graphics/cairo/FontPlatformDataFreeType.cpp: (WebCore::FontPlatformData::FontPlatformData): Added a constructor that takes an existing FontPlatformData and a font size. (WebCore::FontPlatformData::initializeWithFontFace): Added this helper intialization method that properly handles the FC_MATRIX property from the FcPattern.
  • platform/graphics/cairo/FontPlatformDataFreeType.h: Added a declaration to the new constructor and the initializeWithFontFace.
  • platform/graphics/cairo/SimpleFontDataCairo.cpp: (WebCore::SimpleFontData::smallCapsFontData): Use the new FontPlatformData constructor.
10:40 AM Changeset in webkit [69319] by hyatt@apple.com
  • 5 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=47357

Reviewed by Dan Bernstein.

Make findNextLineBreak and some of the helper functions it also calls writing-mode-aware.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::computeLogicalBoxHeights):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::positionNewFloatOnLine):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::getBorderPaddingMargin):
(WebCore::inlineLogicalWidth):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::inlineFlowRequiresLineBox):
(WebCore::RenderBlock::skipLeadingWhitespace):
(WebCore::RenderBlock::fitBelowFloats):
(WebCore::RenderBlock::findNextLineBreak):

  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::hasInlineDirectionBordersPaddingOrMargin):
(WebCore::RenderBoxModelObject::hasInlineDirectionBordersOrPadding):

10:39 AM Changeset in webkit [69318] by jer.noble@apple.com
  • 3 edits in trunk/WebKit/mac

2010-10-06 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Screensaver starts while watching fullscreen playback.
https://bugs.webkit.org/show_bug.cgi?id=47299
<rdar://problem/8478956>

To disable the Screen Saver, we need to periodically call UpdateSystemActivity().

  • WebView/WebVideoFullscreenController.h: Added _tickleTimer.
  • WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController dealloc]): Invalidate _tickleTimer. (-[WebVideoFullscreenController _enableTickleTimer]): Create _tickleTimer. (-[WebVideoFullscreenController _disableTickleTimer]): Invalidate _tickleTimer. (-[WebVideoFullscreenController _tickleTimerFired]): Call UpdateSystemActivity(). (-[WebVideoFullscreenController updatePowerAssertions]): Call _enableTickleTimer

or _disableTickleTimer.

10:32 AM Changeset in webkit [69317] by weinig@apple.com
  • 14 edits
    1 add in trunk/WebKitTools

Change API tester to ask the executable for the list of all
tests instead of relying on the directory structure.
https://bugs.webkit.org/show_bug.cgi?id=47359

Reviewed by Anders Carlsson.

  • Scripts/run-test-webkit-api: Added.
  • Scripts/webkitdirs.pm:

Add additional script to just launch the api tester with the correct settings.

  • Scripts/run-api-tests:

Change to use the new --dump-tests options to build the list of tests and change
output to reflect a (suite, testcase) tuple for each test. Also adds some color.

  • TestWebKitAPI/Test.h:

(TestWebKitAPI::Test::Register::Register):

  • TestWebKitAPI/Tests/WTF/VectorBasic.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/WKString.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:

(TestWebKitAPI::TEST):
Give each test a suite name in addition to the test name.

  • TestWebKitAPI/TestsController.cpp:

(TestWebKitAPI::TestsController::dumpTestNames):
(TestWebKitAPI::TestsController::runTestNamed):

  • TestWebKitAPI/TestsController.h:
  • TestWebKitAPI/mac/main.mm:

(main):
Add option to print all registered tests.

10:26 AM Changeset in webkit [69316] by commit-queue@webkit.org
  • 7 edits in trunk

2010-10-07 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Fixing viewport meta tag user-scalable handling
https://bugs.webkit.org/show_bug.cgi?id=47330

user-scalable attribute was not considered in viewport meta tag handling.

  • dom/ViewportArguments.cpp: (WebCore::findConfigurationForViewportData):
  • dom/ViewportArguments.h:

2010-10-07 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Fixing viewport meta tag user-scalable handling
https://bugs.webkit.org/show_bug.cgi?id=47330

user-scalable attribute was not considered in viewport meta tag handling.

  • Api/qwebpage.cpp: (QWebPage::viewportConfigurationForSize):

2010-10-07 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Fixing viewport meta tag user-scalable handling
https://bugs.webkit.org/show_bug.cgi?id=47330

user-scalable attribute was not considered in viewport meta tag handling.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::viewportConfigurationForSize):
10:12 AM Changeset in webkit [69315] by kbalazs@webkit.org
  • 6 edits
    1 delete in trunk

[Qt] Build files for the WTR's InjectedBundle

9:58 AM Changeset in webkit [69314] by ajwong@chromium.org
  • 14 edits
    5 adds in trunk/LayoutTests

Unreviewed. Chromium build fix.

Add new baselines for svg/hixie/perf/001.xml and
svg/hixie/perf/002.xml. After r69305, which removed the rendering
timestamp from the image, these tests are now more deterministic.

  • platform/chromium-linux/svg/hixie/perf/001-expected.checksum:
  • platform/chromium-linux/svg/hixie/perf/001-expected.png:
  • platform/chromium-linux/svg/hixie/perf/001-expected.txt:
  • platform/chromium-linux/svg/hixie/perf/002-expected.checksum:
  • platform/chromium-linux/svg/hixie/perf/002-expected.png:
  • platform/chromium-linux/svg/hixie/perf/002-expected.txt:
  • platform/chromium-mac/svg/hixie/perf/001-expected.checksum: Added.
  • platform/chromium-mac/svg/hixie/perf/001-expected.png: Added.
  • platform/chromium-mac/svg/hixie/perf/002-expected.checksum: Added.
  • platform/chromium-mac/svg/hixie/perf/002-expected.png: Added.
  • platform/chromium-win/svg/hixie/perf/001-expected.checksum:
  • platform/chromium-win/svg/hixie/perf/001-expected.png:
  • platform/chromium-win/svg/hixie/perf/001-expected.txt:
  • platform/chromium-win/svg/hixie/perf/002-expected.checksum:
  • platform/chromium-win/svg/hixie/perf/002-expected.png:
  • platform/chromium-win/svg/hixie/perf/002-expected.txt:
  • platform/chromium/test_expectations.txt:
9:23 AM Changeset in webkit [69313] by diegohcg@webkit.org
  • 5 edits
    1 copy
    1 add in trunk

[Qt] Hook up accelerometer data via Qt DeviceMotion
https://bugs.webkit.org/show_bug.cgi?id=47105

Reviewed by Andreas Kling.

Get accelerometer necessary data via Qt mobility library using a
provider class. Enable, also the RotationRate using the current device
orientation provider.

WebCore:

  • WebCore.pro:

WebKit/qt:

  • WebCoreSupport/DeviceMotionClientQt.cpp:

(WebCore::DeviceMotionClientQt::DeviceMotionClientQt):
(WebCore::DeviceMotionClientQt::~DeviceMotionClientQt):
(WebCore::DeviceMotionClientQt::startUpdating):
(WebCore::DeviceMotionClientQt::stopUpdating):
(WebCore::DeviceMotionClientQt::currentDeviceMotion):
(WebCore::DeviceMotionClientQt::changeDeviceMotion):

  • WebCoreSupport/DeviceMotionClientQt.h:
  • WebCoreSupport/DeviceMotionProviderQt.cpp: Added.

(WebCore::DeviceMotionProviderQt::DeviceMotionProviderQt):
(WebCore::DeviceMotionProviderQt::~DeviceMotionProviderQt):
(WebCore::DeviceMotionProviderQt::start):
(WebCore::DeviceMotionProviderQt::stop):
(WebCore::DeviceMotionProviderQt::filter):

  • WebCoreSupport/DeviceMotionProviderQt.h: Added.

(WebCore::DeviceMotionProviderQt::currentDeviceMotion):

9:05 AM QtWebKitWeeklyBuilds edited by Csaba Osztrogonác
typo fix (diff)
8:37 AM Changeset in webkit [69312] by commit-queue@webkit.org
  • 8 edits in trunk

2010-10-07 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Some viewport meta tag api refactoring
https://bugs.webkit.org/show_bug.cgi?id=47334

WebCore::findConfigurationForViewportData renamed to computeViewportAttributes.
WebCore::ViewportAttributes::layoutViewport renamed to layoutSize.

  • dom/ViewportArguments.cpp: (WebCore::computeViewportAttributes):
  • dom/ViewportArguments.h:

2010-10-07 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Some viewport meta tag api refactoring
https://bugs.webkit.org/show_bug.cgi?id=47334

WebCore::findConfigurationForViewportData renamed to computeViewportAttributes.
WebCore::ViewportAttributes::layoutViewport renamed to layoutSize.

  • Api/qwebpage.cpp: (QWebPage::viewportConfigurationForSize):
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::viewportAsText):

2010-10-07 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Some viewport meta tag api refactoring
https://bugs.webkit.org/show_bug.cgi?id=47334

WebCore::findConfigurationForViewportData renamed to computeViewportAttributes.
WebCore::ViewportAttributes::layoutViewport renamed to layoutSize.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::viewportConfigurationForSize):
8:08 AM Changeset in webkit [69311] by commit-queue@webkit.org
  • 4 edits
    2 copies in trunk/WebKit/chromium

2010-10-07 Dave Moore <davemoore@chromium.org>

Reviewed by Kent Tamura.

Add WebThemeEngine api for chromium/linux
https://bugs.webkit.org/show_bug.cgi?id=47278
Create new linux specific version of WinThemeEngine.h and move
existing windows specific one to win directory. Keep old top
level file until chromium is updated to use the new ones.

  • WebKit.gyp:
  • public/WebThemeEngine.h:
  • src/ChromiumBridge.cpp:
8:04 AM Changeset in webkit [69310] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

[Qt] Update .def file for Symbian
https://bugs.webkit.org/show_bug.cgi?id=47336
Fix and re-freeze symbols for symbian - viewportConfigurationForSize
API changed, allowGeolocationRequest removed from API, several
DumpRenderTree support calls added.

Patch by Keith Kyzivat <keith.kyzivat@nokia.com> on 2010-10-07
Reviewed by Simon Hausmann.

  • symbian/eabi/QtWebKitu.def:
7:56 AM Changeset in webkit [69309] by jberlin@webkit.org
  • 5 edits in trunk/WebKit2

Bundle should expose a reportException method.
https://bugs.webkit.org/show_bug.cgi?id=46769

Reviewed by John Sullivan.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleReportException):

  • WebProcess/InjectedBundle/API/c/WKBundle.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::reportException):
Mimic the behavior of WebView::reportException.

  • WebProcess/InjectedBundle/InjectedBundle.h:
7:56 AM Changeset in webkit [69308] by kbalazs@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-07 Balazs Kelemen <kbalazs@webkit.org>

Unreviewed. Do a renaming that was recommended by the reviewer
(Kenneth) but I forgot to do before landing (http://trac.webkit.org/changeset/69253)

  • WebKitTestRunner/qt/TestControllerQt.cpp: (WTR::RunUntilConditionLoop::start): (WTR::RunUntilConditionLoop::RunUntilConditionLoop): (WTR::TestController::runUntil):
7:44 AM Changeset in webkit [69307] by kbalazs@webkit.org
  • 2 edits
    2 adds in trunk/WebKitTools

2010-10-07 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Watchdog timer implementation for WTR
https://bugs.webkit.org/show_bug.cgi?id=47337

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h: Factor out the definition of the timer type to a typedef.
  • WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: Added. Timer implementation with QTimer and a helper QObject class. (WTR::WatchdogTimerHelper::instance): (WTR::WatchdogTimerHelper::timerFired): (WTR::WatchdogTimerHelper::WatchdogTimerHelper): (WTR::LayoutTestController::platformInitialize): (WTR::LayoutTestController::invalidateWaitToDumpWatchdogTimer): (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
7:36 AM Changeset in webkit [69306] by kbalazs@webkit.org
  • 2 edits in trunk

2010-10-07 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Turn on building WTR
https://bugs.webkit.org/show_bug.cgi?id=47349

  • WebKit.pro:
6:20 AM Changeset in webkit [69305] by Nikolas Zimmermann
  • 31 edits
    24 adds in trunk/LayoutTests

2010-10-07 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Reenable several skipped SVG tests on leopard & snow leopard
https://bugs.webkit.org/show_bug.cgi?id=47340

Following tests can be unskipped, as they work as expected.

On SnowLeopard:
svg/batik/paints/patternRegionA.svg
svg/custom/path-bad-data.svg
svg/custom/pattern-deep-referencing.svg
svg/hixie/perf/007.xml
svg/transforms/text-with-pattern-inside-transformed-html.xhtml
svg/transforms/text-with-pattern-with-svg-transform.svg

On Leopard:
svg/filters/filter-empty-g.svg

On both:
svg/W3C-SVG-1.1/animate-elem-82-t.svg
svg/W3C-SVG-1.1/coords-trans-01-b.svg
svg/css/glyph-orientation-rounding-test.xhtml (not 100% sure about this one, I don't see any rounding problems, we may have to disable it again, if the problem shows up on the bots)
svg/custom/tiling-regular-hexagonal-crash.svg (test needs some fixes though to make sense)
svg/hixie/perf/001.xml (test needs a fix, so it doesn't dump the elapsed time)
svg/hixie/perf/002.xml (ditto)
svg/batik/text/smallFonts.svg (still not correct, but doesn't crash or hang)

  • platform/mac-leopard/Skipped:
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-82-t-expected.checksum: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1/coords-trans-01-b-expected.checksum: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1/coords-trans-01-b-expected.png: Added.
  • platform/mac-leopard/svg/batik/text/smallFonts-expected.checksum: Added.
  • platform/mac-leopard/svg/batik/text/smallFonts-expected.png: Added.
  • platform/mac-leopard/svg/custom/path-bad-data-expected.checksum: Added.
  • platform/mac-leopard/svg/custom/path-bad-data-expected.png: Added.
  • platform/mac-leopard/svg/custom/path-bad-data-expected.txt: Added.
  • platform/mac-leopard/svg/custom/pattern-deep-referencing-expected.checksum: Added.
  • platform/mac-leopard/svg/custom/pattern-deep-referencing-expected.png: Added.
  • platform/mac-leopard/svg/hixie/perf: Added.
  • platform/mac-leopard/svg/hixie/perf/001-expected.checksum: Added.
  • platform/mac-leopard/svg/hixie/perf/001-expected.png: Added.
  • platform/mac-leopard/svg/hixie/perf/002-expected.checksum: Added.
  • platform/mac-leopard/svg/hixie/perf/002-expected.png: Added.
  • platform/mac-leopard/svg/hixie/perf/007-expected.checksum: Added.
  • platform/mac-leopard/svg/hixie/perf/007-expected.png: Added.
  • platform/mac-leopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.checksum: Added.
  • platform/mac-leopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Added.
  • platform/mac-leopard/svg/transforms/text-with-pattern-with-svg-transform-expected.checksum: Added.
  • platform/mac-leopard/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
  • platform/mac-snowleopard/Skipped:
  • platform/mac/Skipped:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-82-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-trans-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/coords-trans-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
  • platform/mac/svg/batik/text/smallFonts-expected.checksum: Added.
  • platform/mac/svg/batik/text/smallFonts-expected.png: Added.
  • platform/mac/svg/batik/text/smallFonts-expected.txt:
  • platform/mac/svg/custom/path-bad-data-expected.checksum:
  • platform/mac/svg/custom/path-bad-data-expected.png:
  • platform/mac/svg/custom/path-bad-data-expected.txt:
  • platform/mac/svg/custom/pattern-deep-referencing-expected.checksum:
  • platform/mac/svg/custom/pattern-deep-referencing-expected.png:
  • platform/mac/svg/hixie/perf/001-expected.checksum:
  • platform/mac/svg/hixie/perf/001-expected.png:
  • platform/mac/svg/hixie/perf/001-expected.txt:
  • platform/mac/svg/hixie/perf/002-expected.checksum:
  • platform/mac/svg/hixie/perf/002-expected.png:
  • platform/mac/svg/hixie/perf/002-expected.txt:
  • platform/mac/svg/hixie/perf/007-expected.checksum:
  • platform/mac/svg/hixie/perf/007-expected.png:
  • platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.checksum:
  • platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.checksum:
  • platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • svg/custom/tiling-regular-hexagonal-crash.svg: Make the test actually show up the pattern.
  • svg/hixie/perf/001.xml: Don't dump elapsed times, otherwhise results will be inconsistent. Add DRT waitUntilDone/notifyDone logic.
  • svg/hixie/perf/002.xml: Ditto.
6:11 AM Changeset in webkit [69304] by luiz@webkit.org
  • 3 edits
    2 adds in trunk/WebKit2

2010-10-07 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Adam Roben.

[Qt] Webkit2 MacOS build fix
https://bugs.webkit.org/show_bug.cgi?id=47167

There were two problems when building Qt WebKit2 in Mac. The first was that
ld does not support flag -whole-archive and it needed to be replaced by flag -all_load.
The second problem was that APPLE is been used to identify safari builds and, when
building Qt in MacOS, Qt was ending up using the wrong typedef. The solution was to use
a Qt specific WKNativeEvent.h that only has the proper Qt typedef instead of the original one.

  • UIProcess/API/C/qt/WKNativeEvent.h: Added.
  • WebKit2.pri:
  • WebKit2.pro:
6:01 AM Changeset in webkit [69303] by kbalazs@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-07 Balazs Kelemen <kbalazs@webkit.org>

Unreviewed buildfix for 69297 again

  • WebKitTestRunner/TestController.cpp: (WTR::blankURL):
5:57 AM Changeset in webkit [69302] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Use draw instead of expose_event in WebView when building with gtk3
https://bugs.webkit.org/show_bug.cgi?id=47338

  • webkit/webkitwebview.cpp: (webkit_web_view_expose_event): (webkit_web_view_draw): (webkit_web_view_class_init):
5:44 AM Changeset in webkit [69301] by commit-queue@webkit.org
  • 5 edits in trunk

2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Don't use GtkObject
https://bugs.webkit.org/show_bug.cgi?id=47090

GtkObject has been removed in gtk3.

  • plugins/gtk/gtk2xtbin.c: (gtk_xtbin_class_init): (gtk_xtbin_dispose):

2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Don't use GtkObject
https://bugs.webkit.org/show_bug.cgi?id=47090

GtkObject has been removed in gtk3.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::generateEditorCommands):
  • WebCoreSupport/FullscreenVideoController.cpp: (FullscreenVideoController::createHud):
5:42 AM Changeset in webkit [69300] by podivilov@chromium.org
  • 9 edits in trunk/WebCore

2010-10-07 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: highlight XHR breakpoint when hit.
https://bugs.webkit.org/show_bug.cgi?id=47253

  • inspector/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::setNativeBreakpoint): (WebCore::InspectorController::removeNativeBreakpoint): (WebCore::InspectorController::findEventListenerBreakpoint): (WebCore::InspectorController::findXHRBreakpoint):
  • inspector/InspectorController.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::instrumentWillDispatchEventImpl): (WebCore::InspectorInstrumentation::instrumentWillSendXMLHttpRequestImpl):
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.createEventListenerBreakpoint): (WebInspector.BreakpointManager.prototype.createXHRBreakpoint): (WebInspector.BreakpointManager.prototype._xhrBreakpointRemoved): (WebInspector.BreakpointManager.prototype._removeNativeBreakpoint): (WebInspector.BreakpointManager.prototype._setNativeBreakpointEnabled): (WebInspector.BreakpointManager.prototype._setNativeBreakpointOnBackend.didSetNativeBreakpoint): (WebInspector.BreakpointManager.prototype._setNativeBreakpointOnBackend): (WebInspector.BreakpointManager.prototype._removeNativeBreakpointFromBackend): (WebInspector.BreakpointManager.prototype.debuggerPaused): (WebInspector.BreakpointManager.prototype.debuggerResumed): (WebInspector.NativeBreakpoint): (WebInspector.NativeBreakpoint.prototype.get enabled): (WebInspector.NativeBreakpoint.prototype.set enabled): (WebInspector.NativeBreakpoint.prototype.remove):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointItem): (WebInspector.BreakpointItem.prototype._breakpointClicked): (WebInspector.BreakpointItem.prototype._hitStateChanged):
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.updateStatus):
  • inspector/front-end/inspector.css: (.breakpoint-list .breakpoint-hit):
  • inspector/front-end/inspector.js: (WebInspector.pausedScript): (WebInspector.resumedScript):
5:34 AM Changeset in webkit [69299] by kbalazs@webkit.org
  • 2 edits in trunk/WebKitTools

Unreviewed build fix for r69297

5:31 AM Changeset in webkit [69298] by commit-queue@webkit.org
  • 2 edits in trunk

2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fix the build for GTK+ 3
https://bugs.webkit.org/show_bug.cgi?id=47249

Bump required gtk+-3 version to 2.91.0

  • configure.ac:
5:30 AM QtWebKitDocContrib edited by Ademar Reis
(diff)
5:23 AM Changeset in webkit [69297] by kbalazs@webkit.org
  • 6 edits in trunk

2010-10-07 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

WebKitTestRunner should be portable
https://bugs.webkit.org/show_bug.cgi?id=45393

Use only the WebKit API for working with urls.

  • WebKitTestRunner/StringFunctions.h: (WTR::createWKURL):
  • WebKitTestRunner/TestController.cpp: (WTR::blankURL): (WTR::TestController::resetStateToConsistentValues): (WTR::TestController::didFinishLoadForFrame):

2010-10-07 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

WebKitTestRunner should be portable
https://bugs.webkit.org/show_bug.cgi?id=45393

Introducing additional URL API.

  • Shared/API/c/WKURL.cpp: (WKURLCreateWithUTF8CString): (WKURLIsEqual):
  • Shared/API/c/WKURL.h:
5:20 AM Changeset in webkit [69296] by commit-queue@webkit.org
  • 5 edits in trunk

2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fix the build for GTK+ 3
https://bugs.webkit.org/show_bug.cgi?id=47249

Use GdkVisual instead of GdkColormap. GdkColormap has been removed
in gtk3.

  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::platformStart):
  • plugins/gtk/gtk2xtbin.c: (gtk_xtbin_new):

2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fix the build for GTK+ 3
https://bugs.webkit.org/show_bug.cgi?id=47249

Use GdkVisual instead of GdkColormap. GdkColormap has been removed
in gtk3

  • webkit/webkitwebview.cpp: (webkit_web_view_realize):
5:03 AM Changeset in webkit [69295] by caseq@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-10-07 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Chromium multi-dll build broken due to WebResourceRawHeaders methods lacking WEBKIT_API decl spec
https://bugs.webkit.org/show_bug.cgi?id=47329

  • public/WebResourceRawHeaders.h: (WebKit::WebResourceRawHeaders::WebResourceRawHeaders): (WebKit::WebResourceRawHeaders::~WebResourceRawHeaders): (WebKit::WebResourceRawHeaders::operator =):
  • src/WebResourceRawHeaders.cpp: (WebKit::WebResourceRawHeaders::initialize): (WebKit::WebResourceRawHeaders::reset): (WebKit::WebResourceRawHeaders::assign):
4:58 AM Changeset in webkit [69294] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Use gtk_widget_draw() instead of gtk_widget_get_snapshot() in PixelDumpSupportGtk when building with gtk3
https://bugs.webkit.org/show_bug.cgi?id=47332

  • DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: (createBitmapContextFromWebView):
4:46 AM Changeset in webkit [69293] by commit-queue@webkit.org
  • 7 edits in trunk

2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fix the build for GTK+ 3
https://bugs.webkit.org/show_bug.cgi?id=47249

Do not use GdkDrawable deprecated API. Some methods of GdkDrawable
are deprecated in gtk2 and have been removed in gtk3. Equivalent
API has been added to GdkWindow.

  • platform/gtk/GtkVersioning.c: (getDefaultGDKPointerDevice):
  • platform/gtk/GtkVersioning.h:
  • platform/gtk/PlatformScreenGtk.cpp: (WebCore::getVisual): (WebCore::screenAvailableRect):

2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fix the build for GTK+ 3
https://bugs.webkit.org/show_bug.cgi?id=47249

Do not use GdkDrawable deprecated API. Some methods of GdkDrawable
are deprecated in gtk2 and have been removed in gtk3. Equivalent
API has been added to GdkWindow.

  • tests/testcopyandpaste.c: (runPasteTestCallback):
  • webkit/webkitwebview.cpp: (webkit_web_view_button_press_event):
4:42 AM Changeset in webkit [69292] by Nikolas Zimmermann
  • 155 edits
    157 adds in trunk/LayoutTests

2010-10-07 Nikolas Zimmermann <nzimmermann@rim.com>

Rubber stamped by Dirk Schulze.

Finalize SVG pixel test baseline updates. We should have a clean baseline now for Leopard & Snow Leopard, that passes with --tolerance 0 (at least on my 10.5 & 10.6 systems).

  • platform/mac-leopard/svg/batik/masking: Added.
  • platform/mac-leopard/svg/batik/masking/maskRegions-expected.checksum: Added.

...

4:38 AM Changeset in webkit [69291] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Disconnect signals before destroying MediaPlayerPrivateQt

Reviewed by Andreas Kling.

https://bugs.webkit.org/show_bug.cgi?id=47073

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp:
4:34 AM Changeset in webkit [69290] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/gtk

2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Use draw signal instead of expose_event in DragClientGtk when building with gtk3
https://bugs.webkit.org/show_bug.cgi?id=47326

  • WebCoreSupport/DragClientGtk.cpp: (WebKit::dragIconWindowDrawCallback): (WebKit::DragClient::DragClient): (WebKit::DragClient::~DragClient): (WebKit::DragClient::startDrag): (WebKit::DragClient::dragIconWindowDraw):
  • WebCoreSupport/DragClientGtk.h:
4:17 AM Changeset in webkit [69289] by Simon Hausmann
  • 2 edits in trunk

[Qt] Re-enable the web inspector for maemo6 builds

Rubber-stamped by Tor Arne Vestbø.

Yeah, it's strange :), but they really want it.

  • WebKit.pri:
4:14 AM Changeset in webkit [69288] by Nikolas Zimmermann
  • 1 edit
    302 deletes in trunk/LayoutTests

2010-10-07 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Deduplicate some resuts of my last baseline recreations.

  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt: Removed.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt: Removed.

...

4:09 AM Changeset in webkit [69287] by apavlov@chromium.org
  • 3 edits in trunk/WebCore

2010-10-07 Alexander Pavlov <apavlov@chromium.org>

Unreviewed, release build fix.

  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheetForInlineStyle::setStyleText):
  • inspector/InspectorStyleSheet.h: (WebCore::InspectorStyleSheetForInlineStyle::styleForId): (WebCore::InspectorStyleSheetForInlineStyle::ruleSourceDataFor):
3:37 AM Changeset in webkit [69286] by podivilov@chromium.org
  • 3 edits in trunk/WebCore

2010-10-07 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, build fix.

Build fix for r69283.

  • dom/Document.cpp: (WebCore::Document::inspectorController):
  • dom/Document.h:
2:55 AM Changeset in webkit [69285] by commit-queue@webkit.org
  • 4 edits in trunk

2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fix the build for GTK+ 3
https://bugs.webkit.org/show_bug.cgi?id=47249

Don't use gtk_size_request_get_size(). It has been removed,
gtk_widget_get_preferred_size() should be used instead

  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenuGtk::show):

2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fix the build for GTK+ 3
https://bugs.webkit.org/show_bug.cgi?id=47249

Don't use gtk_size_request_get_size(). It has been removed,
gtk_widget_get_preferred_size() should be used instead

  • webkit/webkitwebview.cpp: (PopupMenuPositionFunc):
2:53 AM Changeset in webkit [69284] by apavlov@chromium.org
  • 9 edits
    6 adds in trunk/WebCore

2010-10-06 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Implement handling of CSS operations in InspectorCSSAgent.
Property toggling not implemented yet. The code is not going live.
https://bugs.webkit.org/show_bug.cgi?id=45825

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorCSSAgent.cpp: Added. (WebCore::InspectorCSSAgent::buildObjectForStyle): (WebCore::InspectorCSSAgent::parentStyleSheet): (WebCore::InspectorCSSAgent::asCSSStyleRule): (WebCore::InspectorCSSAgent::InspectorCSSAgent): (WebCore::InspectorCSSAgent::~InspectorCSSAgent): (WebCore::InspectorCSSAgent::reset): (WebCore::InspectorCSSAgent::getMatchedRulesForNode2): (WebCore::InspectorCSSAgent::getMatchedPseudoRulesForNode2): (WebCore::InspectorCSSAgent::getAttributeStylesForNode2): (WebCore::InspectorCSSAgent::getInlineStyleForNode2): (WebCore::InspectorCSSAgent::getComputedStyleForNode2): (WebCore::InspectorCSSAgent::getInheritedStylesForNode2): (WebCore::InspectorCSSAgent::getAllStyles2): (WebCore::InspectorCSSAgent::getStyleSheet2): (WebCore::InspectorCSSAgent::setStyleSheetText2): (WebCore::InspectorCSSAgent::setStyleText2): (WebCore::InspectorCSSAgent::toggleProperty2): (WebCore::InspectorCSSAgent::setRuleSelector2): (WebCore::InspectorCSSAgent::addRule2): (WebCore::InspectorCSSAgent::getSupportedCSSProperties): (WebCore::InspectorCSSAgent::inlineStyleElement): (WebCore::InspectorCSSAgent::populateObjectWithStyleProperties): (WebCore::InspectorCSSAgent::shorthandValue): (WebCore::InspectorCSSAgent::shorthandPriority): (WebCore::InspectorCSSAgent::longhandProperties): (WebCore::InspectorCSSAgent::asInspectorStyleSheet): (WebCore::InspectorCSSAgent::elementForId): (WebCore::InspectorCSSAgent::bindStyleSheet): (WebCore::InspectorCSSAgent::viaInspectorStyleSheet): (WebCore::InspectorCSSAgent::styleSheetForId): (WebCore::InspectorCSSAgent::detectOrigin): (WebCore::InspectorCSSAgent::buildArrayForRuleList): (WebCore::InspectorCSSAgent::buildObjectForAttributeStyles): (WebCore::InspectorCSSAgent::didRemoveDocument): (WebCore::InspectorCSSAgent::didRemoveDOMNode):
  • inspector/InspectorCSSAgent.h: Added. (WebCore::InspectorCSSAgent::create):
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::setDOMListener): (WebCore::InspectorDOMAgent::unbind): (WebCore::InspectorDOMAgent::didRemoveDOMNode): (WebCore::InspectorDOMAgent::getSupportedCSSProperties):
  • inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::DOMListener::~DOMListener): (WebCore::InspectorDOMAgent::documents):
  • inspector/InspectorStyleSheet.cpp: Added. (ParsedStyleSheet::cssStyleSheet): (ParsedStyleSheet::text): (ParsedStyleSheet::hasText): (ParsedStyleSheet::sourceData): (ParsedStyleSheet::hasSourceData): (ParsedStyleSheet::ParsedStyleSheet): (ParsedStyleSheet::setText): (ParsedStyleSheet::setSourceData): (ParsedStyleSheet::ruleSourceDataAt): (WebCore::InspectorStyleSheet::InspectorStyleSheet): (WebCore::InspectorStyleSheet::~InspectorStyleSheet): (WebCore::InspectorStyleSheet::setText): (WebCore::InspectorStyleSheet::setRuleSelector): (WebCore::InspectorStyleSheet::addRule): (WebCore::InspectorStyleSheet::ruleForId): (WebCore::InspectorStyleSheet::buildObjectForStyleSheet): (WebCore::InspectorStyleSheet::buildObjectForRule): (WebCore::InspectorStyleSheet::buildObjectForStyle): (WebCore::InspectorStyleSheet::styleForId): (WebCore::InspectorStyleSheet::setStyleText): (WebCore::InspectorStyleSheet::ownerDocument): (WebCore::InspectorStyleSheet::ruleSourceDataFor): (WebCore::InspectorStyleSheet::ruleIndexByStyle): (WebCore::InspectorStyleSheet::ensureParsedDataReady): (WebCore::InspectorStyleSheet::text): (WebCore::InspectorStyleSheet::ensureText): (WebCore::InspectorStyleSheet::ensureSourceData): (WebCore::InspectorStyleSheet::innerSetStyleSheetText): (WebCore::InspectorStyleSheet::innerSetStyleText): (WebCore::InspectorStyleSheet::styleSheetTextWithChangedStyle): (WebCore::InspectorStyleSheet::findPageRuleWithStyle): (WebCore::InspectorStyleSheet::fullRuleId): (WebCore::InspectorStyleSheet::revalidateStyle): (WebCore::InspectorStyleSheet::styleSheetText): (WebCore::InspectorStyleSheet::resourceStyleSheetText): (WebCore::InspectorStyleSheet::inlineStyleSheetText): (WebCore::InspectorStyleSheet::buildArrayForRuleList): (WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle): (WebCore::InspectorStyleSheetForInlineStyle::setStyleText): (WebCore::InspectorStyleSheetForInlineStyle::ownerDocument): (WebCore::InspectorStyleSheetForInlineStyle::ensureParsedDataReady): (WebCore::InspectorStyleSheetForInlineStyle::inlineStyle): (WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
  • inspector/InspectorStyleSheet.h: Added. (WebCore::InspectorStyleSheet::create): (WebCore::InspectorStyleSheet::id): (WebCore::InspectorStyleSheet::pageStyleSheet): (WebCore::InspectorStyleSheet::canBind): (WebCore::InspectorStyleSheet::fullRuleOrStyleId): (WebCore::InspectorStyleSheet::ruleOrStyleId): (WebCore::InspectorStyleSheet::fullStyleId): (WebCore::InspectorStyleSheetForInlineStyle::create): (WebCore::InspectorStyleSheetForInlineStyle::styleForId): (WebCore::InspectorStyleSheetForInlineStyle::ruleSourceDataFor): (WebCore::InspectorStyleSheetForInlineStyle::ruleIndexByStyle):
  • inspector/InspectorUtilities.cpp: Added. (WebCore::InspectorUtilities::resourceContentForURL):
  • inspector/InspectorUtilities.h: Added.
2:43 AM Changeset in webkit [69283] by podivilov@chromium.org
  • 27 edits in trunk/WebCore

2010-10-05 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: extract Inspector Instrumentation API as a class
https://bugs.webkit.org/show_bug.cgi?id=47173

  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::send):
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld):
  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluate): (WebCore::V8Proxy::callFunction):
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::V8XMLHttpRequest::sendCallback):
  • dom/Document.cpp: (WebCore::Document::recalcStyle):
  • dom/Document.h:
  • dom/Node.cpp: (WebCore::Node::dispatchGenericEvent):
  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::pumpTokenizer):
  • html/parser/HTMLDocumentParser.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::hasFrontend): (WebCore::InspectorInstrumentation::retrieveTimelineAgent):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::hasFrontends): (WebCore::InspectorInstrumentation::inspectorControllerForContext): (WebCore::InspectorInstrumentation::inspectorControllerForDocument): (WebCore::InspectorInstrumentation::inspectorControllerForFrame): (WebCore::InspectorInstrumentation::inspectorControllerForPage):
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::~InspectorTimelineAgent):
  • inspector/InspectorTimelineAgent.h:
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didReceiveResponse): (WebCore::ResourceLoader::didReceiveData):
  • loader/loader.cpp: (WebCore::Loader::load):
  • page/DOMTimer.cpp: (WebCore::DOMTimer::install): (WebCore::DOMTimer::removeById): (WebCore::DOMTimer::fired):
  • page/DOMTimer.h:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchEvent):
  • page/DOMWindow.h:
  • page/FrameView.cpp: (WebCore::FrameView::layout): (WebCore::FrameView::paintContents):
  • page/FrameView.h:
  • page/Page.cpp:
  • page/Page.h:
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintContents):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::callReadyStateChangeListener):
2:11 AM Changeset in webkit [69282] by Simon Hausmann
  • 2 edits in trunk/WebCore

Windowless flash plugin is not rendered in Symbian
https://bugs.webkit.org/show_bug.cgi?id=47172

Patch by Zraly Mike <mike.zraly@nokia.com> on 2010-10-07
Reviewed by Andreas Kling.

  • plugins/symbian/PluginViewSymbian.cpp:

(WebCore::PluginView::platformStart):
Add call to updatePluginWidget() following changes to
platform widget. This is needed to set PluginView's
m_windowRect and m_clipRect members properly after
the proxy widget and its container get created.

2:05 AM Changeset in webkit [69281] by andreas.kling@nokia.com
  • 1855 edits in trunk/LayoutTests

2010-10-06 Andreas Kling <andreas.kling@nokia.com>

Unreviewed, s/RenderPath/RenderSVGPath/
Changeset 2 of 2

1:35 AM Changeset in webkit [69280] by andreas.kling@nokia.com
  • 1132 edits in trunk/LayoutTests

2010-10-06 Andreas Kling <andreas.kling@nokia.com>

Unreviewed, s/RenderPath/RenderSVGPath/
Changeset 1 of 2, since the SVN server keeps 500'ing on me during commit.

12:33 AM Changeset in webkit [69279] by andreas.kling@nokia.com
  • 28 edits
    2 moves in trunk/WebCore

2010-10-07 Andreas Kling <kling@webkit.org>

Reviewed by Nikolas Zimmermann.

Rename (and move) RenderPath to svg/RenderSVGPath
https://bugs.webkit.org/show_bug.cgi?id=47053

Also renamed RenderObject::isRenderPath() to isSVGPath()

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderObject.h: (WebCore::RenderObject::isSVGPath):
  • rendering/RenderPath.cpp: Removed.
  • rendering/RenderPath.h: Removed.
  • rendering/RenderSVGHiddenContainer.cpp:
  • rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage): (WebCore::RenderSVGResourceClipper::calculateClipContentRepaintRect): (WebCore::RenderSVGResourceClipper::hitTestClipContent):
  • rendering/RenderSVGResourceContainer.cpp: (WebCore::RenderSVGResourceContainer::transformOnNonScalingStroke):
  • rendering/RenderSVGResourceSolidColor.cpp: (WebCore::RenderSVGResourceSolidColor::postApplyResource):
  • rendering/RenderTreeAsText.cpp: (WebCore::write):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::layoutChildren):
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeStyle): (WebCore::operator<<): (WebCore::write):
  • rendering/SVGRenderTreeAsText.h:
  • rendering/style/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::diff):
  • rendering/svg/RenderSVGPath.cpp: Copied from WebCore/rendering/RenderPath.cpp. (WebCore::RenderSVGPath::RenderSVGPath): (WebCore::RenderSVGPath::fillContains): (WebCore::RenderSVGPath::strokeContains): (WebCore::RenderSVGPath::layout): (WebCore::RenderSVGPath::fillAndStrokePath): (WebCore::RenderSVGPath::paint): (WebCore::RenderSVGPath::addFocusRingRects): (WebCore::RenderSVGPath::nodeAtFloatPoint): (WebCore::RenderSVGPath::calculateMarkerBoundsIfNeeded): (WebCore::RenderSVGPath::updateCachedBoundaries):
  • rendering/svg/RenderSVGPath.h: Copied from WebCore/rendering/RenderPath.h. (WebCore::RenderSVGPath::isSVGPath): (WebCore::RenderSVGPath::renderName): (WebCore::toRenderSVGPath):
  • svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::svgAttributeChanged):
  • svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::svgAttributeChanged):
  • svg/SVGGradientElement.cpp:
  • svg/SVGLineElement.cpp: (WebCore::SVGLineElement::svgAttributeChanged):
  • svg/SVGPathElement.cpp: (WebCore::SVGPathElement::svgAttributeChanged):
  • svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::svgAttributeChanged):
  • svg/SVGRectElement.cpp: (WebCore::SVGRectElement::svgAttributeChanged):
  • svg/SVGStyledLocatableElement.cpp:
  • svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::createRenderer):
Note: See TracTimeline for information about the timeline view.