Timeline



Jan 11, 2011:

11:57 PM Changeset in webkit [75588] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-01-11 Maciej Stachowiak <mjs@apple.com>

Reviewed by David Levin.

Fix typo in WebKit2 skipped list which was causing a test to not get skipped
https://bugs.webkit.org/show_bug.cgi?id=52277

  • platform/mac-wk2/Skipped:
11:41 PM Changeset in webkit [75587] by mjs@apple.com
  • 2 edits in trunk/Tools

2011-01-11 Maciej Stachowiak <mjs@apple.com>

Reviewed by Eric Seidel.

Close additional pages opened during a test once the test completes.
https://bugs.webkit.org/show_bug.cgi?id=52276

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::done):
10:53 PM Changeset in webkit [75586] by levin@chromium.org
  • 3 edits in trunk/Tools

2011-01-11 David Levin <levin@chromium.org>

Reviewed by Eric Seidel.

Errors should be separated from the command line in bot messages.
https://bugs.webkit.org/show_bug.cgi?id=52275

  • Scripts/webkitpy/common/system/executive.py: (ScriptError.message_with_output): Added a newline to separate the command line from the errors.
  • Scripts/webkitpy/common/system/executive_unittest.py: (ScriptErrorTest.test_message_with_output): Added tests for the various code paths in message_with_output.
9:25 PM Changeset in webkit [75585] by Simon Fraser
  • 3 edits
    2 adds in trunk

2011-01-11 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Webkit crashes when a gradient is applied using the first-line pseudo element
https://bugs.webkit.org/show_bug.cgi?id=52225

When a pseudostyle references images, we fail to register/unregister
the relevant RenderObjects as clients of the image in the style.
For gradients, this caused a crash.

This patch fixes the crash by returning a null gradient image in this
situation.

Test: fast/gradients/gradient-on-pseudoelement-crash.html

  • css/CSSGradientValue.cpp: (WebCore::CSSGradientValue::image):
7:35 PM Changeset in webkit [75584] by jschuh@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-11 Justin Schuh <jschuh@chromium.org>

Unreviewed chromium expectations update.

Windows exclusion for no-mime-with-valid-extension.html (from r75567)

  • platform/chromium/test_expectations.txt:
7:20 PM Changeset in webkit [75583] by eric@webkit.org
  • 5 edits in trunk/Tools

2011-01-11 Eric Seidel <eric@webkit.org>

Unreviewed.

commit-queue should know how to upload archived results (for test flakes or general failures)
https://bugs.webkit.org/show_bug.cgi?id=52048

The zips are mostly empty due to forgetting -r.
Expected diffs were not being pulled from the archive due
to the archive having longer paths than I realized.

  • Scripts/webkitpy/common/system/workspace.py:
  • Scripts/webkitpy/common/system/workspace_unittest.py:
  • Scripts/webkitpy/tool/bot/flakytestreporter.py:
  • Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
6:38 PM Changeset in webkit [75582] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-11 Dirk Pranke <dpranke@chromium.org>

Unreviewed, fix typo in expectations file.

  • platform/chromium-gpu/test_expectations.txt:
6:16 PM Changeset in webkit [75581] by thakis@chromium.org
  • 1 edit
    2 deletes in trunk/LayoutTests

2011-01-11 Nico Weber <thakis@chromium.org>

Unreviewed, test expectations.

Remove now-unnecessary xp-specific baseline.
https://bugs.webkit.org/show_bug.cgi?id=52105

  • platform/chromium-win-xp/fast/gradients/radial-centered-expected.checksum: Removed.
  • platform/chromium-win-xp/fast/gradients/radial-centered-expected.png: Removed.
5:57 PM Changeset in webkit [75580] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

2011-01-11 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

REGRESSION (r71562): servePendingRequests() no longer called when
resources are done loading.
https://bugs.webkit.org/show_bug.cgi?id=52264
<rdar://problem/8767429>


In r71562, servePendingRequests() is no longer called in Loader's
didFinishLoading(), didFail() and didReceiveResponse() methods. Since
r71562 was intended only as a refactoring, these calls should be
restored. At least one WebKit-based Mac OS X application relies on this
for correct behavior.

  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::loadDone): Call resourceLoadScheduler()->servePendingRequests().
5:36 PM Changeset in webkit [75579] by enne@google.com
  • 2 edits in trunk/LayoutTests

2011-01-11 Adrienne Walker <enne@google.com>

Unreviewed, test expectations update.

Revert expect change for Snow Leopard in r75570.

  • platform/mac-snowleopard/Skipped:
5:28 PM Changeset in webkit [75578] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-11 Mihai Parparita <mihaip@chromium.org>

Unreviewed; chromium test expectations update.

Remove failing expectations for tests that pass after r75569.

  • platform/chromium/test_expectations.txt:
5:26 PM Changeset in webkit [75577] by Patrick Gansterer
  • 8 edits in trunk/Source/WebCore

2011-01-11 Patrick Gansterer <Patrick Gansterer>

Reviewed by Eric Seidel.

Add Document::setContent()
https://bugs.webkit.org/show_bug.cgi?id=52085

Add a method to Document to set the whole content at once.
This removes the hack of the insert method in the xml parser
and is a predecessor to feed the xml parser with raw data.

  • dom/Document.cpp: (WebCore::Document::setContent):
  • dom/Document.h:
  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::insert): Added ASSERT_NOT_REACHED().
  • loader/cache/CachedFont.cpp: (WebCore::CachedFont::ensureSVGFontData): Use setContent.
  • xml/DOMParser.cpp: (WebCore::DOMParser::parseFromString): Ditto.
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseXML): Ditto.
  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource): Ditto.
5:15 PM Changeset in webkit [75576] by dpranke@chromium.org
  • 13 edits in trunk/Tools

2011-01-11 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

The current modifier parsing code in test_expectations is
fragile and hard-coded, so it's not easy to understand the logic
or easily add new types of modifiers (like GPU vs. CPU testing
for graphics tests, or 32-bit vs. 64-bit differences).

This is the first of two patches that will add in more generic
support and then eliminate the GPU-specific test expectations
files for Chromium.

This patch adds two standalone objects for handling modifiers. The
rules for interpreting modifiers, precedence, and conflicts are
given in the docstring to the ModifierMatcher class, which
returns ModifierMatchResult objects.

This patch also adds routines to the Port interface and a
default set of values in the base object, in order to obtain the
values needed on a given test run. These values are then passed
to the expectation parser. This also allows us to clean up the
logic used to lint all of the different configurations in a
single test_expectations.txt file.

The next patch will merge in the separate GPU expectations file.

https://bugs.webkit.org/show_bug.cgi?id=51222

  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4:56 PM Changeset in webkit [75575] by mjs@apple.com
  • 5 edits in trunk/Tools

2011-01-11 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adam Barth.

Make webkit-patch support subdirectories for SVN checkouts
https://bugs.webkit.org/show_bug.cgi?id=52261

  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/style_references.py:
  • Scripts/webkitpy/tool/main.py:
  • Scripts/webkitpy/tool/steps/preparechangelog.py:
4:56 PM Changeset in webkit [75574] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2011-01-11 James Robinson <jamesr@chromium.org>

Update test to use layoutTestController.waitUntilDone()/notifyDone() since it relies on the scroll event which is now async.

  • fast/repaint/resources/fixed-move-after-keyboard-scroll-iframe.html:
4:53 PM Changeset in webkit [75573] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix.

  • platform/graphics/cairo/PathCairo.cpp:

(WebCore::Path::addArc): Switch to MathExtra's piFloat define,
rather than M_PI which is not always available.

4:52 PM Changeset in webkit [75572] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-11 Mihai Parparita <mihaip@chromium.org>

Unreviewed; chromium test expectations update.

Remove failing expectations for tests that pass after r75552.

  • platform/chromium/test_expectations.txt:
4:43 PM Changeset in webkit [75571] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-01-11 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

fix difflink centering to be vertical, not horizontal
https://bugs.webkit.org/show_bug.cgi?id=52263

  • PrettyPatch/PrettyPatch.rb:
  • code-review.js:
4:39 PM Changeset in webkit [75570] by enne@google.com
  • 6 edits
    3 adds
    2 deletes in trunk/LayoutTests

2011-01-11 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

Sync WebGL texImage2D video test from Khronos and re-enable it.
https://bugs.webkit.org/show_bug.cgi?id=44459

  • fast/canvas/webgl/resources/quadrants.mp4: Removed.
  • fast/canvas/webgl/resources/quadrants.ogv: Removed.
  • fast/canvas/webgl/resources/red-green.mp4: Added.
  • fast/canvas/webgl/resources/red-green.theora.ogv: Added.
  • fast/canvas/webgl/resources/red-green.webmvp8.webm: Added.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-expected.txt:
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html:
  • platform/chromium-gpu/test_expectations.txt:
  • platform/chromium/test_expectations.txt:
  • platform/mac-snowleopard/Skipped:
4:36 PM Changeset in webkit [75569] by mihaip@chromium.org
  • 8 edits
    38 adds
    2 deletes in trunk/LayoutTests

2011-01-11 Mihai Parparita <mihaip@chromium.org>

Unreviewed, new chromium-mac baselines.

Rebaseline after the scrollbar change (these tests still need
chromium-mac baselines since they have controls or images that render
slightly differently from the Mac port).

  • platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.checksum:
  • platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/chromium-mac/fast/block/margin-collapse/103-expected.checksum: Added.
  • platform/chromium-mac/fast/block/margin-collapse/103-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.checksum:
  • platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.png:
  • platform/chromium-mac/fast/events/pointer-events-2-expected.checksum:
  • platform/chromium-mac/fast/events/pointer-events-2-expected.png:
  • platform/chromium-mac/fast/images/gif-large-checkerboard-expected.checksum: Removed.
  • platform/chromium-mac/fast/images/gif-large-checkerboard-expected.png: Removed.
  • platform/chromium-mac/fast/replaced/width100percent-image-expected.checksum: Added.
  • platform/chromium-mac/fast/replaced/width100percent-image-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png: Added.
  • platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.checksum: Added.
  • platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug101674-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug101674-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug29314-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug29314-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug5797-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug5797-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug625-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug625-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/core/bloomberg-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/core/bloomberg-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/core/row_span-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/core/row_span-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/other/cell_widths-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/other/cell_widths-expected.png: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/other/test4-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/other/test4-expected.png: Added.
  • platform/chromium/test_expectations.txt:
4:33 PM Changeset in webkit [75568] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit2

2011-01-11 Jeff Miller <jeffm@apple.com>

Reviewed by John Sullivan.

WebKit2: "Webpages not responding" dialog appears when <select> popup menu is showing
https://bugs.webkit.org/show_bug.cgi?id=52242

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::showPopupMenu): On Windows, stop the responsiveness timer before calling showPopupMenu().
4:33 PM Changeset in webkit [75567] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-01-11 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>

Reviewed by Adam Barth.

Use plug-in DB for extensions to MIME type convertion

Plugins extension to MIME type conversion was not used in the
frameLoader. This was causing some fallback to be use which as the side
effect of loosing all the <OBJECT> parameters or <EMBED> attributes.
This patch ensure that we try to convert the extension to MIME type
using the plugin database beofre using this fallback.

Attribute lost with Flash plugin without mime type set
https://bugs.webkit.org/show_bug.cgi?id=50657

  • plugins/no-mime-with-valid-extension.html: Added.
  • plugins/no-mime-with-valid-extension-expected.txt: Added.

2011-01-11 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>

Reviewed by Adam Barth.

Use plug-in DB for extensions to MIME type convertion

Plugins extension to MIME type conversion was not used in the
frameLoader. This was causing some fallback to be use which as the side
effect of loosing all the <OBJECT> parameters or <EMBED> attributes.
This patch ensure that we try to convert the extension to MIME type
using the plugin database beofre using this fallback.

Attribute lost with Flash plugin without mime type set
https://bugs.webkit.org/show_bug.cgi?id=50657

Test: plugins/no-mime-with-valid-extension.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::defaultObjectContentType): Use PluginDatabase for MIME
4:17 PM Changeset in webkit [75566] by mjs@apple.com
  • 2 edits in trunk/WebKit2

2011-01-11 Maciej Stachowiak <mjs@apple.com>

Reviewed by Anders Carlsson.

UIProcess kills the WebProcess sometimes when detached frames exist
https://bugs.webkit.org/show_bug.cgi?id=52227

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didSaveFrameToPageCache): Don't consider the message invalid if it came in for a detached frame.
3:56 PM Changeset in webkit [75565] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-01-11 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

remember diffstate for review tool
https://bugs.webkit.org/show_bug.cgi?id=52253

If you use the global sidebyside/unified links, store the diff type
in localstorage. Then, onload, use that diff type. That way, people
who prefer one diff type or the other can always get that by default.

  • code-review.js:
3:44 PM Changeset in webkit [75564] by jschuh@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-11 Justin Schuh <jschuh@chromium.org>

Unreviewed, test expectations update.

Flaky expectations for textOnPath.svg.

  • platform/chromium/test_expectations.txt:
3:41 PM Changeset in webkit [75563] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Build fix.

  • WebKit2.xcodeproj/project.pbxproj:
3:40 PM Changeset in webkit [75562] by andersca@apple.com
  • 2 edits
    2 adds in trunk/WebKit2

2011-01-11 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add a Region class which represents a graphical region
https://bugs.webkit.org/show_bug.cgi?id=52255

  • Platform/Region.cpp: Added. (WebKit::Region::Region): (WebKit::Region::rects): (WebKit::Region::Shape::Shape): (WebKit::Region::Shape::appendSpan): (WebKit::Region::Shape::canCoalesce): (WebKit::Region::Shape::appendSpans): (WebKit::Region::Shape::appendSegment): (WebKit::Region::Shape::spans_begin): (WebKit::Region::Shape::spans_end): (WebKit::Region::Shape::segments_begin): (WebKit::Region::Shape::segments_end): (WebKit::Region::Shape::dump): (WebKit::Region::Shape::bounds): (WebKit::Region::Shape::move): (WebKit::Region::Shape::swap): (WebKit::Region::Shape::shapeOperation): (WebKit::Region::Shape::UnionOperation::trySimpleOperation): (WebKit::Region::Shape::unionShapes): (WebKit::Region::Shape::IntersectOperation::trySimpleOperation): (WebKit::Region::Shape::intersectShapes): (WebKit::Region::Shape::SubtractOperation::trySimpleOperation): (WebKit::Region::Shape::subtractShapes): (WebKit::Region::dump): (WebKit::Region::intersect): (WebKit::Region::unite): (WebKit::Region::subtract): (WebKit::Region::move):
  • Platform/Region.h: Added. (WebKit::Region::bounds): (WebKit::Region::isEmpty): (WebKit::Region::Span::Span): (WebKit::Region::Shape::isEmpty):
  • WebKit2.xcodeproj/project.pbxproj:
3:35 PM Changeset in webkit [75561] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2011-01-11 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

[chromium] copy test netscape plugin into TestNetscapePlugin
https://bugs.webkit.org/show_bug.cgi?id=52232

  • WebKit.gyp: Make a copy of the TestNetscapePlugIn in

TestNetscapePlugIn and WebKitTestNetscapePlugIn

3:19 PM Changeset in webkit [75560] by simonjam@chromium.org
  • 16 edits in trunk

2011-01-11 James Simonsen <simonjam@chromium.org>

Reviewed by Eric Seidel.

[Web Timing] Rename sslHandshakeStart to secureConnectionStart
https://bugs.webkit.org/show_bug.cgi?id=52239

  • fast/dom/Window/window-properties-performance-expected.txt:
  • fast/dom/script-tests/webtiming.js: (checkTimingBeforeLoad): (checkTimingWhileDeferred): (checkWebTimingOnDOMContentLoaded): (checkWebTimingWhileAsync): (checkWebTimingOnLoad): (checkWebTimingAfterLoad):
  • fast/dom/webtiming-document-open-expected.txt:
  • fast/dom/webtiming-expected.txt:
  • fast/dom/webtiming-navigate-within-document-expected.txt:
  • http/tests/misc/resources/webtiming-cross-origin-and-back2.html:
  • http/tests/misc/resources/webtiming-cross-origin-redirect.html:
  • http/tests/misc/resources/webtiming-no-origin.html:
  • http/tests/misc/resources/webtiming-ssl.html:
  • http/tests/misc/webtiming-origins-expected.txt:
  • http/tests/misc/webtiming-ssl-expected.txt:

2011-01-11 James Simonsen <simonjam@chromium.org>

Reviewed by Eric Seidel.

[Web Timing] Rename sslHandshakeStart to secureConnectionStart
https://bugs.webkit.org/show_bug.cgi?id=52239

  • page/PerformanceTiming.cpp: (WebCore::PerformanceTiming::secureConnectionStart):
  • page/PerformanceTiming.h:
  • page/PerformanceTiming.idl:
3:16 PM Changeset in webkit [75559] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-01-11 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

allow sidebysideifying individual files in the code review tool
https://bugs.webkit.org/show_bug.cgi?id=52226

  • code-review.js:
2:58 PM Changeset in webkit [75558] by andersca@apple.com
  • 9 edits
    1 add in trunk/WebKit2

2011-01-11 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Add DidSetSize message
https://bugs.webkit.org/show_bug.cgi?id=52254

  • DerivedSources.make: Add DrawingAReaProxy.messages.in.
  • Platform/CoreIPC/MessageID.h: Add DrawingAreaProxy message class.
  • UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::didSetSize): Add CoreIPC message handler function.
  • UIProcess/DrawingAreaProxy.messages.in: Added.
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::didSetSize): Add stub.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveMessage): Handle DrawingAreaProxy messages.
  • WebKit2.xcodeproj/project.pbxproj: Add new files.
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setSize): Send a DidSetSize message for now.
2:53 PM Changeset in webkit [75557] by abarth@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-01-11 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Introduce the notion of a "display-isolated" URL scheme for use by
Chrome-internal URLs
https://bugs.webkit.org/show_bug.cgi?id=50182

This patch actually makes the display-isolated schemes display
isolated. The behavior should be the same as the previous iteration of
this patch, but re-organized a bit because reading the access white
list is expensive.

  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::isAccessToURLWhiteListed): (WebCore::SecurityOrigin::canDisplay):
  • page/SecurityOrigin.h:
  • platform/SchemeRegistry.cpp:
  • platform/SchemeRegistry.h:
2:52 PM Changeset in webkit [75556] by inferno@chromium.org
  • 3 edits
    2 adds in branches/chromium/597

2011-01-11 Merge 75548 - BUGCR69275 - Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

RefPtr the FrameView to prevent scrollbar from getting deleted inside
its scroll event.
https://bugs.webkit.org/show_bug.cgi?id=52238

Test: scrollbars/scrollable-iframe-remove-crash.html

  • page/DOMWindow.cpp: (WebCore::DOMWindow::scrollTo):

2011-01-11 Merge 75548 - Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Tests that we do not crash when we remove scrollable iframe when executing
inside its scroll event.
https://bugs.webkit.org/show_bug.cgi?id=52238

  • scrollbars/scrollable-iframe-remove-crash-expected.txt: Added.
  • scrollbars/scrollable-iframe-remove-crash.html: Added.
2:47 PM Changeset in webkit [75555] by mihaip@chromium.org
  • 17 edits
    4 adds in trunk

2011-01-11 Mihai Parparita <mihaip@chromium.org>

Reviewed by Darin Fisher.

Scroll event should be fired asynchronously
https://bugs.webkit.org/show_bug.cgi?id=45631

Update existing tests that assumed that scroll events fired
synchronously.

  • editing/input/page-up-down-scrolls-expected.txt:
  • editing/input/page-up-down-scrolls.html:
  • fast/events/fire-scroll-event-element-expected.txt: Copied from LayoutTests/fast/events/fire-scroll-event-expected.txt.
  • fast/events/fire-scroll-event-element.html: Added. Does the same

tests as fire-scroll-event.html, but on an individual element instead
of the whole document.

  • fast/events/fire-scroll-event-expected.txt:
  • fast/events/fire-scroll-event.html: Now explicitly tests for

synchronous behavior when scrolling the document, and that we don't
fire the event more than once.

  • fast/events/remove-child-onscroll.html:
  • fast/events/scroll-during-zoom-change.html:
  • fast/events/scroll-event-does-not-bubble.html:
  • fast/events/scroll-event-phase-expected.txt: Added.
  • fast/events/scroll-event-phase.html: Added. Checks that we can listen

for scroll events in both the capture and bubble phase.

  • fast/layers/removed-by-scroll-handler.html:
  • fast/overflow/onscroll-layer-self-destruct.html:
  • fast/repaint/repaint-during-scroll.html:

2011-01-11 Mihai Parparita <mihaip@chromium.org>

Reviewed by Darin Fisher.

Scroll event should be fired asynchronously
https://bugs.webkit.org/show_bug.cgi?id=45631

Tests: fast/events/fire-scroll-event.html

fast/events/fire-scroll-event-element.html
fast/events/scroll-event-phase.html

Makes scroll events fire asynchronously to be in compliance with the
CSSOM View Module and consistent with Gecko, Opera and (to some degree)
IE.

Implemented via the EventQueue class added by r74062 (EventQueue now
has a convenience enqueueScrollEvent method).

  • dom/EventQueue.cpp: (WebCore::EventQueue::enqueueScrollEvent): (WebCore::EventQueue::pendingEventTimerFired):
  • dom/EventQueue.h:
  • page/EventHandler.cpp: (WebCore::EventHandler::sendScrollEvent):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::valueChanged):
2:42 PM Changeset in webkit [75554] by inferno@chromium.org
  • 3 edits
    2 adds in branches/chromium/597

2011-01-11 Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

RefPtr text node in setOuterText since calling appendData
on a text node can fire away dom event listener which might
remove the text node from underneath.
https://bugs.webkit.org/show_bug.cgi?id=52163

Test: fast/dom/text-node-append-data-remove-crash.html

  • html/HTMLElement.cpp: (WebCore::HTMLElement::setOuterText):

2011-01-11 Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Tests that calling append data on a text node which removes its
sibling text node does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=52163

  • fast/dom/text-node-append-data-remove-crash-expected.txt: Added.
  • fast/dom/text-node-append-data-remove-crash.html: Added.
2:16 PM Changeset in webkit [75553] by kbr@google.com
  • 5 edits
    3 deletes in trunk/WebKit/chromium

2011-01-11 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

[chromium] Move WebGraphicsContext3DDefaultImpl to Chromium repository
https://bugs.webkit.org/show_bug.cgi?id=52235

Deleted WebGraphicsContext3DDefaultImpl, which has been moved to
the Chromium repository under WebGraphicsContext3DInProcessImpl.
Removed WebGraphicsContext3D::createDefault(). Rolled forward
Chromium version to pick up needed changes.

Tested with build-webkit --chromium --debug and a run of the WebGL
layout tests in DRT.

  • DEPS:
  • WebKit.gyp:
  • public/WebGraphicsContext3D.h:
  • src/GraphicsContext3DChromium.cpp:
  • src/WebGraphicsContext3D.cpp: Removed.
  • src/WebGraphicsContext3DDefaultImpl.cpp: Removed.
  • src/WebGraphicsContext3DDefaultImpl.h: Removed.
2:03 PM Changeset in webkit [75552] by mihaip@chromium.org
  • 10 edits
    7 adds in trunk/LayoutTests

2011-01-11 Mihai Parparita <mihaip@chromium.org>

Unreviewed; new and updated mac-leopard baselines.

Update stale or missing Leopard baselines (tests currently pass on Snow
Leopard).

  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/editing/deleting/delete-line-end-ws-001-expected.checksum:
  • platform/mac-leopard/editing/deleting/delete-line-end-ws-001-expected.png:
  • platform/mac-leopard/editing/deleting/delete-line-end-ws-002-expected.checksum:
  • platform/mac-leopard/editing/deleting/delete-line-end-ws-002-expected.png:
  • platform/mac-leopard/fast/block/basic/016-expected.checksum: Added.
  • platform/mac-leopard/fast/block/basic/016-expected.png: Added.
  • platform/mac-leopard/fast/block/basic/truncation-rtl-expected.checksum: Added.
  • platform/mac-leopard/fast/block/basic/truncation-rtl-expected.png: Added.
  • platform/mac-leopard/fast/blockflow/fieldsets-expected.checksum: Added.
  • platform/mac-leopard/fast/blockflow/fieldsets-expected.png: Added.
  • platform/mac-leopard/fast/borders/border-image-scale-transform-expected.checksum:
  • platform/mac-leopard/fast/borders/border-image-scale-transform-expected.png:
  • platform/mac-leopard/tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum:
  • platform/mac-leopard/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
2:03 PM Changeset in webkit [75551] by weinig@apple.com
  • 5 edits in trunk/WebKit2

Fix spelling mistake. Sharable -> Shareable.

Reviewed by Anders Carlsson.

  • Shared/API/c/WKImage.h:
  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toImageOptions):

  • Shared/ImageOptions.h:
  • Shared/WebImage.cpp:

(WebKit::WebImage::create):

1:53 PM Changeset in webkit [75550] by andersca@apple.com
  • 10 edits
    1 add in trunk/WebKit2

2011-01-11 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add SetSize message
https://bugs.webkit.org/show_bug.cgi?id=52247

  • DerivedSources.make: Add DrawingArea.messages.in
  • Platform/CoreIPC/MessageID.h: Add DrawingArea message class.
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::sizeDidChange): Call sendSetSize.

(WebKit::DrawingAreaProxyImpl::sendSetSize):
Send a SetSize message.

  • UIProcess/DrawingAreaProxyImpl.h: Add setSize override.
  • WebKit2.xcodeproj/project.pbxproj: Add new files.
  • WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::setSize): Add setSize member function.
  • WebProcess/WebPage/DrawingArea.messages.in: Added.
  • WebProcess/WebPage/DrawingAreaImpl.cpp:
  • WebProcess/WebPage/DrawingAreaImpl.h: Add setSize.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::didReceiveMessage): Handle drawing area messages.
1:33 PM Changeset in webkit [75549] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-01-11 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE build fix for r75523.

  • platform/wince/DragDataWinCE.cpp: Added missing include.
1:28 PM Changeset in webkit [75548] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-01-11 Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

RefPtr the FrameView to prevent scrollbar from getting deleted inside
its scroll event.
https://bugs.webkit.org/show_bug.cgi?id=52238

Test: scrollbars/scrollable-iframe-remove-crash.html

  • page/DOMWindow.cpp: (WebCore::DOMWindow::scrollTo):

2011-01-11 Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Tests that we do not crash when we remove scrollable iframe when executing
inside its scroll event.
https://bugs.webkit.org/show_bug.cgi?id=52238

  • scrollbars/scrollable-iframe-remove-crash-expected.txt: Added.
  • scrollbars/scrollable-iframe-remove-crash.html: Added.
1:24 PM Changeset in webkit [75547] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Replace ASSERTs with FIXMEs.

Reviewed by Sam Weinig.

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::sizeDidChange):
(WebKit::DrawingAreaProxyImpl::setPageIsVisible):

1:20 PM Changeset in webkit [75546] by andersca@apple.com
  • 4 edits
    2 adds in trunk/WebKit2

2011-01-11 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add DrawingAreaImpl skeleton class
https://bugs.webkit.org/show_bug.cgi?id=52246

  • UIProcess/API/mac/WKView.mm: (useNewDrawingArea): New function which controls which drawing area to use, through an environment variable.

(-[WKView drawRect:]):
Bail if we're using the new drawing area (for now).

(-[WKView WebKit::]):
Create a DrawingAreaProxyImpl when asked to.

  • WebKit2.xcodeproj/project.pbxproj: Add new files.
  • WebProcess/WebPage/DrawingArea.cpp: (WebKit::DrawingArea::create): Create a DrawingAreaImpl when asked to.
  • WebProcess/WebPage/DrawingAreaImpl.cpp: Added.
  • WebProcess/WebPage/DrawingAreaImpl.h: Added. Add DrawingAreaImpl class.
1:17 PM Changeset in webkit [75545] by Martin Robinson
  • 1 edit
    3 deletes in trunk/LayoutTests

2011-01-11 Martin Robinson <mrobinson@igalia.com>

Remove some GTK+-specific baselines. GTK+ now enough feature parity with the Mac
port to make these platform-specific results unnecessary.

  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt: Removed.
  • platform/gtk/fast/js/global-constructors-expected.txt: Removed.
1:08 PM Changeset in webkit [75544] by thakis@chromium.org
  • 3 edits in trunk/LayoutTests

2011-01-11 Nico Weber <thakis@chromium.org>

Unreviewed, test expectations.

Another new baselines due to updated skia
https://bugs.webkit.org/show_bug.cgi?id=52105

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:
1:05 PM Changeset in webkit [75543] by Dimitri Glazkov
  • 16 edits
    2 adds in trunk

2011-01-08 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by David Hyatt.

Make pseudo-style resolution less hard-coded when used to select a shadow node
https://bugs.webkit.org/show_bug.cgi?id=46595

New test that comprehensively travels the code paths affected by the change.

  • fast/css/unknown-pseudo-element-matching-expected.txt: Added.
  • fast/css/unknown-pseudo-element-matching.html: Added.

2011-01-08 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by David Hyatt.

Make pseudo-style resolution less hard-coded when used to select a shadow node
https://bugs.webkit.org/show_bug.cgi?id=46595

Essentially implements the plumbing for the XBL2 pseudo attribute:
http://dev.w3.org/2006/xbl2/#the-pseudo-attribute

Test: fast/css/unknown-pseudo-element-matching.html

  • css/CSSGrammar.y: Changed to handle specifier_list structure with the

CSSParser::updateSpecifierWithElementName helper, added logic to
keep unknown pseudo-element selectors at the top of the selector chain,
so that we can easily check for them and grab them, and also because
they would either not match anything or act as a descendant selector
(descendant into a shadow DOM subtree that is), not a specifier.

  • css/CSSParser.cpp: (WebCore::CSSParser::updateSpecifiersWithElementName): Generalized/combined

the logic adding element name to selectors and added the special case
to handle unknown pseudo-element selectors.

  • css/CSSParser.h: Added def.
  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): Removed any mention of PseudoSliderThumb/SLIDER_THUMB. (WebCore::nameToPseudoTypeMap): Ditto. (WebCore::CSSSelector::extractPseudoType): Ditto.
  • css/CSSSelector.h: Added a new ShadowDescendant relation type,

removed PseudoSliderThumb def.

(WebCore::CSSSelector::isUnknownPseudoElement): Added a helper method.

  • css/CSSSelectorList.cpp: (WebCore::SelectorHasUnknownPseudoElementFunctor::operator()): Added a functor

to check for an unknown pseudo-element in the list.

(WebCore::CSSSelectorList::hasUnknownPseudoElements): Added.

  • css/CSSSelectorList.h: Added a def.
  • css/CSSStyleSelector.cpp: (WebCore::CSSRuleSet::getPseudoRules): Added accessor to pseudo-element hash. (WebCore::CSSStyleSelector::matchRules): Added matching pseudo elements. (WebCore::CSSStyleSelector::SelectorChecker::checkSelector): Added handling

of ShadowDescendant relation.

(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Enabled handling

of unknown pseudo-element selectors.

(WebCore::CSSRuleSet::addRule): Added populating unknown pseudo-element hash.

  • css/html.css: (input[type="range"]::-webkit-slider-thumb): Added previously-hard-coded

display:block.

  • dom/Element.h: (WebCore::Element::shadowPseudoId): Added new virtual method to allow

elements to provide the value of pseudo-element selector they would match.

  • dom/Node.cpp: (WebCore::Node::querySelector): Added checking for unknown pseudo-element selectors,

so that we can throw a SYNTAX_ERR if found.

(WebCore::Node::querySelectorAll): Ditto.

  • html/shadow/SliderThumbElement.h: (WebCore::SliderThumbElement::shadowPseudoId): Added to return "-webkit-slider-thumb";
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::createThumbStyle): Changed to use the new styleForElement logic.
  • rendering/style/RenderStyleConstants.h: Removed SLIDER_THUMB.
1:03 PM Changeset in webkit [75542] by dino@apple.com
  • 5 edits in trunk

2011-01-11 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=52233

WebKitCSSMatrix constructor should accept 'none'
as a valid string parameter.

  • css/WebKitCSSMatrix.cpp: (WebCore::WebKitCSSMatrix::setMatrixValue):

2011-01-11 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=52233

Update WebKitCSSMatrix test to cover a constructor
that accepts 'none' as input.

  • transforms/cssmatrix-2d-interface-expected.txt:
  • transforms/cssmatrix-2d-interface.xhtml:
1:00 PM Changeset in webkit [75541] by Dimitri Glazkov
  • 4 edits
    2 deletes in branches/chromium/597

Merged r75536.

12:56 PM Changeset in webkit [75540] by andersca@apple.com
  • 5 edits
    2 adds in trunk/WebKit2

2011-01-11 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add Mac-only DrawingAreaProxyImpl class skeleton
https://bugs.webkit.org/show_bug.cgi?id=52243

This is the proxy side of a new drawing area implementation. This is Mac only for now
while the design is being fleshed out.

  • Shared/DrawingAreaInfo.h:
  • UIProcess/API/mac/WKView.mm: (-[WKView _switchToDrawingAreaTypeIfNecessary:DrawingAreaInfo::]):
  • UIProcess/DrawingAreaProxyImpl.cpp: Added. (WebKit::DrawingAreaProxyImpl::create): (WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl): (WebKit::DrawingAreaProxyImpl::~DrawingAreaProxyImpl): (WebKit::DrawingAreaProxyImpl::didReceiveMessage): (WebKit::DrawingAreaProxyImpl::didReceiveSyncMessage): (WebKit::DrawingAreaProxyImpl::paint): (WebKit::DrawingAreaProxyImpl::sizeDidChange): (WebKit::DrawingAreaProxyImpl::setPageIsVisible): (WebKit::DrawingAreaProxyImpl::attachCompositingContext): (WebKit::DrawingAreaProxyImpl::detachCompositingContext):
  • UIProcess/DrawingAreaProxyImpl.h: Added.
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/DrawingArea.cpp: (WebKit::DrawingArea::create):
12:56 PM Changeset in webkit [75539] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-01-11 Ojan Vafai <ojan@chromium.org>

Reviewed by Mihai Parparita.

fix exception when adding a comment to a side-by-side diff
https://bugs.webkit.org/show_bug.cgi?id=52240

prev() and next() won't get the previous and next lines in
side-by-side mode. Instead do a query to find them.

  • code-review.js:
12:54 PM Changeset in webkit [75538] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-01-11 Ojan Vafai <ojan@chromium.org>

Reviewed by Mihai Parparita.

maintain word diffs when converting to side-by-side and back
https://bugs.webkit.org/show_bug.cgi?id=52244

Using textContent would lose the spans use to make the word-diff highlighting.
Just move the span element itself.

  • code-review.js:
12:47 PM Changeset in webkit [75537] by jamesr@google.com
  • 11 edits in trunk/Source/WebCore

2011-01-11 James Robinson <jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

Set all RenderBlocks as replaced when an inline display type is specified
https://bugs.webkit.org/show_bug.cgi?id=50858

When a RenderBlock is created for an element with a specified display:inline style,
it should always be treated as inline-block. This situations often comes up for form
controls. Previously, RenderBlock::styleWillChange set the replaced flag for display
values of inline-block, inline-table, and inline-table and a number of subclasses of
RenderBlock set the replaced flag in styleDidChange for a display:inline. However
sometimes new subclasses would miss this step leading to bugs (such as with RenderDetails).
This patch sets the replaced flag for all inline display types in RenderBlock::styleWillChange.

Code cleanup only, no change in behavior so no new tests.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::styleWillChange):
  • rendering/RenderButton.cpp: (WebCore::RenderButton::styleDidChange):
  • rendering/RenderFieldset.cpp:
  • rendering/RenderFieldset.h:
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::styleDidChange):
  • rendering/RenderListBox.cpp:
  • rendering/RenderListBox.h:
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::styleDidChange):
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::styleDidChange):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::styleDidChange):
12:44 PM Changeset in webkit [75536] by Dimitri Glazkov
  • 5 edits
    2 deletes in trunk

2011-01-11 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

REGRESSION(r71934) Can't type in search edit field on skin-one.com
https://bugs.webkit.org/show_bug.cgi?id=52195

Restored original (pre-71934) check in the test to ensure that
selectstart does not propagate outside of the shadow DOM.

Consolidated shadow-boundary-crossing-2.html into shadow-boundary-crossing.html.

  • fast/events/shadow-boundary-crossing-2-expected.txt: Renamed to

shadow-boundary-crossing-expected.txt.

  • fast/events/shadow-boundary-crossing-2.html: Renamed to

shadow-boundary-crossing.html.

  • fast/events/shadow-boundary-crossing-expected.txt: Removed.
  • fast/events/shadow-boundary-crossing.html: Removed after folding the

test into the new shadow-boundary-crossing.html.

2011-01-11 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

REGRESSION(r71934) Can't type in search edit field on skin-one.com
https://bugs.webkit.org/show_bug.cgi?id=52195

Restored the original behavior, where the selectstart event is not
dispatched when selection changes inside of the shadow DOM.

  • dom/Node.cpp: (WebCore::determineDispatchBehavior): Moved EventDispatchBehavior-determining

logic into a helper function, also added a check to keep selectstart

events inside of the shadow DOM.

(WebCore::Node::dispatchGenericEvent): Changed to use the helper function.

12:39 PM Changeset in webkit [75535] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-11 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>

Reviewed by Eric Seidel.

[Qt] Provide plugin coordinates to windowless plugins on Symbian.
https://bugs.webkit.org/show_bug.cgi?id=52213

  • plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginView::setNPWindowIfNeeded):
12:34 PM Changeset in webkit [75534] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-01-11 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectation update.

  • platform/mac-snowleopard/Skipped:
12:33 PM Changeset in webkit [75533] by Laszlo Gombos
  • 2 edits in trunk

2011-01-11 Laszlo Gombos <Laszlo Gombos>

Reviewed by Csaba Osztrogonác.

[Qt] Add QT_NO_CONCURRENT to the qt_minimal configuration
https://bugs.webkit.org/show_bug.cgi?id=52223

Add QT_NO_CONCURRENT to the qt_minimal configuration to make sure
that QtWebKit builds with QT_NO_CONCURRENT defined.

  • WebKit.pri:
12:28 PM Changeset in webkit [75532] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix Windows build.

  • WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:

(WebKit::WebPopupMenu::setUpPlatformData):

12:24 PM Changeset in webkit [75531] by msaboff@apple.com
  • 3 edits
    3 adds in trunk

2011-01-11 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

Missing call to popTempSortVector() for exception case in JSArray::sort.
https://bugs.webkit.org/show_bug.cgi?id=50718

Fix to patch of 50718 that added pushTempSortVector() and
popTempSortVector() to JSArray::sort() to mark elements during sort.
Need to add popTempSortVector() for the return case if toString()
had an exception.

  • runtime/JSArray.cpp: (JSC::JSArray::sort): Added popTempSortVector()

2011-01-11 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

Missing call to popTempSortVector() for exception case in JSArray::sort.
https://bugs.webkit.org/show_bug.cgi?id=50718

New test to validate balanced calls to pushTempSortVector() and
popTempSortVector().

  • fast/js/array-sort-exception-expected.txt: Added.
  • fast/js/array-sort-exception.html: Added.
  • fast/js/script-tests/array-sort-exception.js: Added. (do_gc): (Item): (toString_throw): (test):
12:22 PM Changeset in webkit [75530] by zmo@google.com
  • 3 edits in trunk/LayoutTests

2011-01-11 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations update.

  • platform/chromium-gpu/test_expectations.txt:
  • platform/chromium/test_expectations.txt:
12:21 PM Changeset in webkit [75529] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-01-11 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

fix layout error with comments in code review tool
https://bugs.webkit.org/show_bug.cgi?id=52230

  • PrettyPatch/PrettyPatch.rb:
12:20 PM Changeset in webkit [75528] by andersca@apple.com
  • 7 edits in trunk/WebKit2

2011-01-11 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Rename ShareableBitmap::createSharable to createShareable
https://bugs.webkit.org/show_bug.cgi?id=52234

  • Shared/ShareableBitmap.cpp: (WebKit::ShareableBitmap::createShareable):
  • Shared/ShareableBitmap.h:
  • Shared/WebImage.cpp: (WebKit::WebImage::create):
  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::geometryDidChange):
  • WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp: (WebKit::WebPopupMenu::setUpPlatformData):
  • WebProcess/WebPage/FindController.cpp: (WebKit::FindController::updateFindIndicator):
12:13 PM Changeset in webkit [75527] by andersca@apple.com
  • 21 edits
    5 moves in trunk/WebKit2

2011-01-11 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Rename BackingStore to ShareableBitmap
https://bugs.webkit.org/show_bug.cgi?id=52228

  • GNUmakefile.am:
  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::geometryDidChange):
  • PluginProcess/PluginControllerProxy.h:
  • Shared/API/c/cg/WKImageCG.cpp: (WKImageCreateCGImage):
  • Shared/BackingStore.cpp: Removed.
  • Shared/BackingStore.h: Removed.
  • Shared/PlatformPopupMenuData.cpp: (WebKit::PlatformPopupMenuData::decode):
  • Shared/PlatformPopupMenuData.h:
  • Shared/ShareableBitmap.cpp: Copied from WebKit2/Shared/BackingStore.cpp. (WebKit::ShareableBitmap::create): (WebKit::ShareableBitmap::createSharable): (WebKit::ShareableBitmap::createHandle): (WebKit::ShareableBitmap::ShareableBitmap): (WebKit::ShareableBitmap::~ShareableBitmap): (WebKit::ShareableBitmap::resize): (WebKit::ShareableBitmap::data):
  • Shared/ShareableBitmap.h: Copied from WebKit2/Shared/BackingStore.h.
  • Shared/UserMessageCoders.h: (WebKit::UserMessageEncoder::baseEncode): (WebKit::UserMessageDecoder::baseDecode):
  • Shared/WebImage.cpp: (WebKit::WebImage::create): (WebKit::WebImage::WebImage): (WebKit::WebImage::~WebImage): (WebKit::WebImage::size):
  • Shared/WebImage.h: (WebKit::WebImage::bitmap):
  • Shared/cairo/BackingStoreCairo.cpp: (WebKit::ShareableBitmap::createGraphicsContext): (WebKit::ShareableBitmap::paint):
  • Shared/cg/BackingStoreCG.cpp: Removed.
  • Shared/cg/ShareableBitmapCG.cpp: Copied from WebKit2/Shared/cg/BackingStoreCG.cpp. (WebKit::ShareableBitmap::createGraphicsContext): (WebKit::ShareableBitmap::paint):
  • Shared/gtk/BackingStoreGtk.cpp: Removed.
  • Shared/gtk/ShareableBitmapGtk.cpp: Copied from WebKit2/Shared/gtk/BackingStoreGtk.cpp. (WebKit::ShareableBitmap::createGraphicsContext): (WebKit::ShareableBitmap::paint):
  • Shared/qt/BackingStoreQt.cpp: Removed.
  • Shared/qt/ShareableBitmapQt.cpp: Copied from WebKit2/Shared/qt/BackingStoreQt.cpp. (WebKit::ShareableBitmap::createGraphicsContext): (WebKit::ShareableBitmap::paint):
  • UIProcess/FindIndicator.cpp: (WebKit::FindIndicator::create): (WebKit::FindIndicator::FindIndicator):
  • UIProcess/FindIndicator.h: (WebKit::FindIndicator::contentImage):
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::geometryDidChange):
  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/WebPage/FindController.cpp: (WebKit::FindController::updateFindIndicator):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::snapshotInViewCoordinates): (WebKit::WebPage::snapshotInDocumentCoordinates):
  • win/WebKit2.vcproj:
12:12 PM Changeset in webkit [75526] by thakis@chromium.org
  • 3 edits in trunk/LayoutTests

2011-01-11 Nico Weber <thakis@chromium.org>

Unreviewed, test expectations.

Another baseline for the recent skia roll.
https://bugs.webkit.org/show_bug.cgi?id=52105

  • platform/chromium-linux/svg/custom/focus-ring-expected.checksum:
  • platform/chromium-linux/svg/custom/focus-ring-expected.png:
12:05 PM Changeset in webkit [75525] by sullivan@apple.com
  • 2 edits in trunk/WebKit2

[WKView setFrameSize:] derefs _page->drawingArea() without null check
<https://bugs.webkit.org/show_bug.cgi?id=52231>

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView setFrameSize:]):
Null check drawingArea(). This is OK because if it doesn't exist then it will be
created later with the correct initial size.

11:49 AM Changeset in webkit [75524] by zmo@google.com
  • 8 edits in trunk

2011-01-10 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Need to consider UNPACK_ALIGNMENT in GraphicsContext3D::texImage2DResourceSafe
https://bugs.webkit.org/show_bug.cgi?id=52068

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::copyTexImage2D): Use computeImageSizeInBytes. (WebCore::WebGLRenderingContext::copyTexSubImage2D): Ditto. (WebCore::WebGLRenderingContext::readPixels): Ditto, and fix a bug on generating the wrong error. (WebCore::WebGLRenderingContext::texImage2DBase): Ditto. (WebCore::WebGLRenderingContext::validateTexFuncData): Use computeImageSizeInBytes.
  • platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::texImage2DResourceSafe): Add a new parameter alignment. (WebCore::GraphicsContext3D::computeFormatAndTypeParameters): Add more supported format/type. (WebCore::GraphicsContext3D::computeImageSizeInBytes): Added.
  • platform/graphics/GraphicsContext3D.h:

2011-01-10 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Need to consider UNPACK_ALIGNMENT in GraphicsContext3D::texImage2DResourceSafe
https://bugs.webkit.org/show_bug.cgi?id=52068

  • fast/canvas/webgl/read-pixels-test-expected.txt:
  • fast/canvas/webgl/read-pixels-test.html: Sync with khronos.
  • fast/canvas/webgl/resources/webgl-test.js: Add finishTest().
11:47 AM Changeset in webkit [75523] by enrica@apple.com
  • 39 edits
    2 deletes in trunk

Source/WebCore: Paste and drag and drop use different code paths to interact with the pasteboard.
https://bugs.webkit.org/show_bug.cgi?id=52093
The change consists in a refactoring of the code to have only one class that
deals with the pasteboard on Mac.

Reviewed by Alexey Proskuryakov.

No new tests. A test is already available for this
(editing/pasteboard/drag-image-to-contenteditable-in-iframe.html) but had incorrect results.

  • WebCore.exp.in:
  • loader/EmptyClients.h: Added two Mac only methods to call into WebKit to use functionality

that is in NSURLExtras.
(WebCore::EmptyEditorClient::canonicalizeURL):
(WebCore::EmptyEditorClient::canonicalizeURLString):

  • page/DragController.cpp:

The following methods have been changed to pass a pointer to the Frame object
to the DragData class.
(WebCore::documentFragmentFromDragData):
(WebCore::DragController::performDrag):
(WebCore::DragController::dispatchTextInputEventFor):
(WebCore::DragController::concludeEditDrag):

  • page/EditorClient.h: Added two Mac only methods to call into WebKit to use functionality

that is in NSURLExtras.
The following files have been modified to pass the Frame object to the DragData method calls.

  • page/chromium/DragControllerChromium.cpp:

(WebCore::DragController::dragOperation):

  • page/gtk/DragControllerGtk.cpp:

(WebCore::DragController::dragOperation):

  • page/mac/DragControllerMac.mm:

(WebCore::DragController::dragOperation):

  • page/qt/DragControllerQt.cpp:

(WebCore::DragController::dragOperation):

  • page/win/DragControllerWin.cpp:

(WebCore::DragController::dragOperation):

  • platform/DragData.h: Removed Mac specific constructor and reference to PasteboardHelper class.
  • platform/Pasteboard.h: Added public constructor to create a Pasteboard object from an NSPasteboard.

The following files were all modified to match the new parameters of the methods listed.

  • platform/android/DragDataAndroid.cpp:

(WebCore::DragData::asPlainText):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):

  • platform/chromium/DragDataChromium.cpp:

(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asPlainText):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::asFragment):

  • platform/gtk/DragDataGtk.cpp:

(WebCore::DragData::asPlainText):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):

  • platform/haiku/DragDataHaiku.cpp:

(WebCore::DragData::asPlainText):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):

  • platform/mac/DragDataMac.mm:

(WebCore::DragData::DragData):
(WebCore::DragData::asPlainText):
(WebCore::insertablePasteboardTypes):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::getBestURL):
(WebCore::Pasteboard::asURL):

  • platform/qt/DragDataQt.cpp:

(WebCore::DragData::asPlainText):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):

  • platform/win/DragDataWin.cpp:

(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asPlainText):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::asFragment):

  • platform/wince/DragDataWinCE.cpp:

(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asPlainText):
(WebCore::DragData::asFragment):

  • platform/wx/DragDataWx.cpp:

(WebCore::DragData::asPlainText):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):

WebKit: Paste and drag and drop use different code paths to interact with the pasteboard.
https://bugs.webkit.org/show_bug.cgi?id=52093
The change consists in a refactoring of the code to have only one class that
deals with the pasteboard on Mac.

Reviewed by Alexey Proskuryakov.

  • WebKit.xcodeproj/project.pbxproj: Removed WebPasteboardHelper.mm and WebPasteboardHelper.h.

WebKit/mac: Paste and drag and drop use different code paths to interact with the pasteboard.
https://bugs.webkit.org/show_bug.cgi?id=52093
The change consists in a refactoring of the code to have only one class that
deals with the pasteboard on Mac.

Reviewed by Alexey Proskuryakov.

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: Added two methods to provide to WebCore functionality

exposed by NSURLExtras.
(WebEditorClient::canonicalizeURL):
(WebEditorClient::canonicalizeURLString):

  • WebCoreSupport/WebPasteboardHelper.h: Removed.
  • WebCoreSupport/WebPasteboardHelper.mm: Removed.
  • WebView/WebHTMLView.mm: Removed comment.
  • WebView/WebView.mm: The following methods have been changed to use the new DragData

constructor that doesn't use the WebPasteboardHelper reference.
(-[WebView draggingEntered:]):
(-[WebView draggingUpdated:]):
(-[WebView draggingExited:]):
(-[WebView performDragOperation:]):

WebKit2: Paste and drag and drop use different code paths to interact with the pasteboard.
https://bugs.webkit.org/show_bug.cgi?id=52093
The change consists in a refactoring of the code to have only one class that
deals with the pasteboard on Mac.

Reviewed by Alexey Proskuryakov.

  • WebProcess/WebCoreSupport/WebEditorClient.h:
  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: Added two methods to provide to WebCore functionality

exposed by NSURLExtras.
(WebKit::WebEditorClient::canonicalizeURL):
(WebKit::WebEditorClient::canonicalizeURLString):

LayoutTests: Paste and drag and drop use different code paths to interact with the pasteboard.
https://bugs.webkit.org/show_bug.cgi?id=52093

Reviewed by Alexey Proskuryakov.

New test results added to match the correct behavior.

  • platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.checksum:
  • platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png:
  • platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
11:40 AM Changeset in webkit [75522] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-11 Mihai Parparita <mihaip@chromium.org>

Unreviewed; chromium test expectations update.

Remove failing expectations for tests that pass after r75515.

  • platform/chromium/test_expectations.txt:
11:40 AM Changeset in webkit [75521] by jberlin@webkit.org
  • 2 edits in trunk/WebKit2

Fix crash on launch on Windows.

Reviewed by Anders Carlsson and Sam Weinig.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::onSizeEvent):
The drawing area is no longer initialized before the WebView is created and the first
onSize is receieved.

11:28 AM Changeset in webkit [75520] by eric@webkit.org
  • 4 edits in trunk/Tools

2011-01-11 Eric Seidel <eric@webkit.org>

Unreviewed.

commit-queue should know how to upload archived results (for test flakes or general failures)
https://bugs.webkit.org/show_bug.cgi?id=52048

I changed the API for archive_last_layout_test_results w/o updating the implementation. Oops.
This fixes an exception seen on the commit-queue when attempting to report flaky tests.

  • Scripts/webkitpy/common/system/workspace.py:
  • Scripts/webkitpy/common/system/workspace_unittest.py:
  • Scripts/webkitpy/tool/commands/queues.py:
11:24 AM Changeset in webkit [75519] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-01-11 Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

RefPtr text node in setOuterText since calling appendData
on a text node can fire away dom event listener which might
remove the text node from underneath.
https://bugs.webkit.org/show_bug.cgi?id=52163

Test: fast/dom/text-node-append-data-remove-crash.html

  • html/HTMLElement.cpp: (WebCore::HTMLElement::setOuterText):

2011-01-11 Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Tests that calling append data on a text node which removes its
sibling text node does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=52163

  • fast/dom/text-node-append-data-remove-crash-expected.txt: Added.
  • fast/dom/text-node-append-data-remove-crash.html: Added.
10:50 AM Changeset in webkit [75518] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-11 Stephen White <senorblanco@chromium.org>

Unreviewed; chromium-gpu test expectations update.

Remove now-passing tests from text_expectations.txt.

  • platform/chromium-gpu/test_expectations.txt:
10:49 AM Changeset in webkit [75517] by xan@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-11 Xan Lopez <xlopez@igalia.com>

Reviewed by Darin Adler.

Microoptimization in ~JSString
https://bugs.webkit.org/show_bug.cgi?id=52222

The case where m_fibers is 0 seems to be the most common one
(almost 1/2 of the time, followed at some distance by m_fibers = 1
in 1/4 of the cases in a typical SunSpider execution). We can save
one comparison in this common case by doing a bit of refactoring
in the JSString destructor; overall a 0.3% progression, but only
the string tests show improvement.

  • runtime/JSString.h: (JSC::RopeBuilder::~JSString):
10:49 AM Changeset in webkit [75516] by andersca@apple.com
  • 5 edits in trunk/WebKit2

2011-01-11 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Automatically reinitialize the web page on relaunch
https://bugs.webkit.org/show_bug.cgi?id=52224
<rdar://problem/8765695>

  • UIProcess/API/mac/WKView.mm: (-[WKView _didRelaunchProcess]): Remove call to reinitializeWebPage.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::relaunch): Call initializeWebPage().

(WebKit::WebPageProxy::initializeWebPage):
Assert that the web page is valid here.

  • UIProcess/WebPageProxy.h: Remove reinitializeWebPage.
  • UIProcess/win/WebView.cpp: (WebKit::WebView::didRelaunchProcess): Remove call to reinitializeWebPage.
10:46 AM Changeset in webkit [75515] by mihaip@chromium.org
  • 6 edits
    10 adds in trunk/LayoutTests

2011-01-11 Mihai Parparita <mihaip@chromium.org>

Unreviewed; new and updated mac-leopard baselines.

Update stale or missing Leopard baselines (tests currently pass on Snow
Leopard).

  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/fast/block/basic/fieldset-stretch-to-legend-expected.checksum:
  • platform/mac-leopard/fast/block/basic/fieldset-stretch-to-legend-expected.png:
  • platform/mac-leopard/fast/dom/focus-contenteditable-expected.checksum: Added.
  • platform/mac-leopard/fast/dom/focus-contenteditable-expected.png: Added.
  • platform/mac-leopard/fast/forms/fieldset-align-expected.checksum: Added.
  • platform/mac-leopard/fast/forms/fieldset-align-expected.png: Added.
  • platform/mac-leopard/fast/multicol/columns-shorthand-parsing-expected.checksum: Added.
  • platform/mac-leopard/fast/multicol/columns-shorthand-parsing-expected.png: Added.
  • platform/mac-leopard/fast/text/capitalize-boundaries-expected.checksum: Added.
  • platform/mac-leopard/fast/text/capitalize-boundaries-expected.png: Added.
  • platform/mac-leopard/fast/text/softHyphen-expected.checksum: Added.
  • platform/mac-leopard/fast/text/softHyphen-expected.png: Added.
  • platform/mac-leopard/tables/mozilla/other/wa_table_tr_align-expected.checksum:
  • platform/mac-leopard/tables/mozilla/other/wa_table_tr_align-expected.png:
10:39 AM Changeset in webkit [75514] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-01-10 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

convert back to unified from sidebyside diff
https://bugs.webkit.org/show_bug.cgi?id=52180

Remove url fragment stuff. Having it be per-filediff is too complicated.

  • PrettyPatch/PrettyPatch.rb:
  • code-review.js:
10:37 AM Changeset in webkit [75513] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-01-11 Martin Robinson <mrobinson@igalia.com>

Unskipping fast/multicol/span/double-merge-anonymous-block-crash.html. We
have been unsuccessful reproducing the crash locally or on the bots.

  • platform/gtk/Skipped: Unskipping test.
10:36 AM Changeset in webkit [75512] by andersca@apple.com
  • 4 edits in trunk/WebKit2

2011-01-10 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Pass the view size to the DrawingAreaProxy constructor
https://bugs.webkit.org/show_bug.cgi?id=52189

  • UIProcess/DrawingAreaProxy.cpp: (WebKit::DrawingAreaProxy::DrawingAreaProxy):
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::viewSize):
  • UIProcess/WebPageProxy.h:
10:29 AM Changeset in webkit [75511] by mihaip@chromium.org
  • 2 edits in trunk

2011-01-11 Mihai Parparita <mihaip@chromium.org>

Unreviewed. Update .gitignore with new Chromium dependency.

ui/ was added with http://crrev.com/70743, we picked that up with a
Chromium roll in r75311.

Also alphabetizes the dependency list.

  • .gitignore:
10:27 AM Changeset in webkit [75510] by msaboff@apple.com
  • 4 edits
    6 adds in trunk

2011-01-10 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

ASSERTION Failure in JSC::binaryChop
https://bugs.webkit.org/show_bug.cgi?id=25614

Changed JITStubs::cti_register_file_check() to use the current stack's
return PC to find the bytecode for handling the exception in the prior
frame. Also added the appropriate arrity check routine call to the
JIT to bytecode vector (m_callReturnIndexVector) in the CodeBlock.

  • jit/JIT.cpp: (JSC::JIT::privateCompile): Changed the arrity check call location so that it gets added to the m_calls list so that it's included in CodeBlock::m_callReturnIndexVector.
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION): Use the current call frame's return PC.

2011-01-11 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

ASSERTION Failure in JSC::binaryChop
https://bugs.webkit.org/show_bug.cgi?id=25614

Added new test to check for proper handling of stack overflow
exceptions and arrity exceptions while close to the top of the stack.

  • fast/js/script-tests/stack-overflow-arrity-catch.js: Added. (fWithTwoArgs): (test):
  • fast/js/script-tests/stack-overflow-catch.js: Added. (test):
  • fast/js/stack-overflow-arrity-catch-expected.txt: Added.
  • fast/js/stack-overflow-arrity-catch.html: Added.
  • fast/js/stack-overflow-catch-expected.txt: Added.
  • fast/js/stack-overflow-catch.html: Added.
10:05 AM Changeset in webkit [75509] by senorblanco@chromium.org
  • 14 edits in trunk/LayoutTests

2011-01-11 Stephen White <senorblanco@chromium.org>

Unreviewed; new chromium GPU test baselines.

These tests required rebaselining after the skia roll in
http://src.chromium.org/viewvc/chrome?view=rev&revision=70835.

  • platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.checksum:
  • platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/fillrect_gradient-expected.checksum:
  • platform/chromium-gpu-linux/fast/canvas/fillrect_gradient-expected.png:
  • platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.checksum:
  • platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.txt:
  • platform/chromium-gpu-win/fast/canvas/fillrect_gradient-expected.checksum:
  • platform/chromium-gpu-win/fast/canvas/fillrect_gradient-expected.png:
  • platform/chromium-gpu-win/fast/canvas/fillrect_gradient-expected.txt:
  • platform/chromium-gpu-win/fast/canvas/gradient-add-second-start-end-stop-expected.checksum:
  • platform/chromium-gpu-win/fast/canvas/gradient-add-second-start-end-stop-expected.png:
  • platform/chromium-gpu-win/fast/canvas/gradient-add-second-start-end-stop-expected.txt:
9:56 AM Changeset in webkit [75508] by weinig@apple.com
  • 27 edits
    8 adds in trunk

Tools: Roll r75474 back in.

WebKit2: Roll r75460 back in with build fix.

9:32 AM Changeset in webkit [75507] by Carlos Garcia Campos
  • 4 edits
    22 adds in trunk

2011-01-11 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add support for <meter> element
https://bugs.webkit.org/show_bug.cgi?id=48713

  • platform/gtk/Skipped:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.checksum: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.png: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.checksum: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Added.

2011-01-11 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add support for <meter> element
https://bugs.webkit.org/show_bug.cgi?id=48713

  • GNUmakefile.am: Enable meter element.
9:22 AM Changeset in webkit [75506] by kbalazs@webkit.org
  • 13 edits in trunk/WebKit2

2011-01-11 Anders Carlsson <andersca@apple.com>

Reviewed by Andreas Kling.

Work towards having the WebPageProxy decide when to create the DrawingAreaProxy
https://bugs.webkit.org/show_bug.cgi?id=52184

Qt part made my Balazs Kelemen.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::createDrawingAreaProxy): Call -[WKView _createDrawingAreaProxy].

(WebKit::PageClientImpl::setViewNeedsDisplay):
Call setNeedsDisplayInRect on the WKView.

  • UIProcess/API/mac/WKView.mm: (-[WKView initWithFrame:contextRef:pageGroupRef:]): No need to set the drawing area proxy anymore.

(-[WKView _createDrawingAreaProxy]):
Create a chunked update drawing area proxy for now.

  • UIProcess/API/qt/qgraphicswkview.cpp: Added a QGraphicsItem* member that is initialized in init to the accociated view. Implement the new functions. This is a temporary solution, in the long term the view and the page should be decoupled. (QGraphicsWKView::QGraphicsWKView):
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::QWKPagePrivate): (QWKPagePrivate::init): (QWKPagePrivate::createDrawingAreaProxy): (QWKPagePrivate::setViewNeedsDisplay):
  • UIProcess/API/qt/qwkpage.h:
  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h: Add new pure virtual member functions.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::initializeWebPage): (WebKit::WebPageProxy::reinitializeWebPage): Set the new drawing area proxy.
  • UIProcess/win/WebView.cpp: (WebKit::WebView::WebView): No need to set the drawing area proxy anymore.

(WebKit::WebView::createDrawingAreaProxy):
Create a chunked update drawing area proxy for now.

(WebKit::WebView::setViewNeedsDisplay):
Invalidate the window.

8:49 AM Changeset in webkit [75505] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Unreviewed buildfix.

[Qt][V8] Add missing include for debug build.

  • loader/cache/CachedResourceLoader.cpp:
8:37 AM Changeset in webkit [75504] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-11 Stephen White <senorblanco@chromium.org>

Unreviewed; yet another gpu test_expectations update.

All glory to the hypnotoad.

  • platform/chromium-gpu/test_expectations.txt:
8:33 AM Changeset in webkit [75503] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-11 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: redirects are lost from the network panel upon navigation.
https://bugs.webkit.org/show_bug.cgi?id=52210

  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager.prototype.didCommitLoadForFrame):
8:19 AM Changeset in webkit [75502] by jocelyn.turcotte@nokia.com
  • 7 edits in trunk

2011-01-11 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove uses of QFuture since it isn't supported on all platforms.
https://bugs.webkit.org/show_bug.cgi?id=51204

  • platform/network/qt/QtNAMThreadSafeProxy.cpp: (WebCore::QtNAMThreadSafeProxy::QtNAMThreadSafeProxy): (WebCore::QtNAMThreadSafeProxy::localCookiesForUrl): (WebCore::QtNAMThreadSafeProxy::localWillLoadFromCache):
  • platform/network/qt/QtNAMThreadSafeProxy.h: (WebCore::QtNAMThreadSafeProxy::cookiesForUrl): (WebCore::QtNAMThreadSafeProxy::willLoadFromCache):

2011-01-11 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove uses of QFuture since it isn't supported on all platforms.
https://bugs.webkit.org/show_bug.cgi?id=51204

  • QtTestBrowser/webpage.h: (QtNAMThread::QtNAMThread): (QtNAMThread::networkAccessManager): (QtNAMThread::run):

2011-01-11 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove uses of QFuture since it isn't supported on all platforms.
https://bugs.webkit.org/show_bug.cgi?id=51204

  • tests/qwebpage/tst_qwebpage.cpp: (QtNAMThread::QtNAMThread): (QtNAMThread::networkAccessManager): (QtNAMThread::run):
7:21 AM WebKit Team edited by pvarga@webkit.org
(diff)
7:09 AM Changeset in webkit [75501] by pvarga@webkit.org
  • 2 edits in trunk/Tools

2011-01-11 Peter Varga <pvarga@webkit.org>

Unreviewed.

Add myself to committers' list.

  • Scripts/webkitpy/common/config/committers.py:
6:37 AM Changeset in webkit [75500] by podivilov@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-01-11 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: recreate script view after live edit.
https://bugs.webkit.org/show_bug.cgi?id=51751

  • inspector/front-end/Script.js: (WebInspector.Script.prototype.set source):
  • inspector/front-end/ScriptView.js: (WebInspector.ScriptView):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.editScriptSource.mycallback): (WebInspector.ScriptsPanel.prototype.editScriptSource): (WebInspector.ScriptsPanel.prototype.viewRecreated):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._doEditLine):
6:33 AM Changeset in webkit [75499] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-11 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: frameDetachedFromParent notification handler is missing in NetworkManager.
https://bugs.webkit.org/show_bug.cgi?id=52205

  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager.prototype.frameDetachedFromParent):
6:11 AM Changeset in webkit [75498] by apavlov@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-01-11 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: "Audit present state" always disabled
https://bugs.webkit.org/show_bug.cgi?id=52199

Removed all traces of resource tracking checks, as we have it no more.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/AuditLauncherView.js: (WebInspector.AuditLauncherView.prototype._createLauncherUI):
  • inspector/front-end/AuditsPanel.js:
6:09 AM Changeset in webkit [75497] by podivilov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-01-11 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move delayed search implementation to SourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=51753

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._createViewerIfNeeded): (WebInspector.SourceFrame.prototype.findSearchMatches): (WebInspector.SourceFrame.prototype.cancelFindSearchMatches):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.hide): (WebInspector.SourceView.prototype.searchCanceled): (WebInspector.SourceView.prototype.performSearch.didFindSearchMatches): (WebInspector.SourceView.prototype.performSearch):
6:07 AM Changeset in webkit [75496] by jorlow@chromium.org
  • 3 edits
    2 deletes in trunk/LayoutTests

2011-01-11 Jeremy Orlow <jorlow@chromium.org>

[Chromium] Fix bad baselines
https://bugs.webkit.org/show_bug.cgi?id=52207

It looks like https://bugs.webkit.org/show_bug.cgi?id=51865 didn't quite
get the baselines right. Ran the rebaseline tool to get these.

  • platform/chromium-linux/svg/custom/fill-SVGPaint-interface-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/getPresentationAttribute-expected.txt: Removed.
  • platform/chromium-win/svg/custom/fill-SVGPaint-interface-expected.txt:
  • platform/chromium-win/svg/custom/getPresentationAttribute-expected.txt:
6:07 AM Changeset in webkit [75495] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-01-11 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: innerFirstChild has a side effect which should be called explicitly.

If a node is a frame's owner then innerFirstChild method
subscribes DOMAgent instance to the frame's doc's events.
I think this should be done explicitly when we meet with
the node for the first time. As I understand it happens
in buildArrayForContainerChildren method.

https://bugs.webkit.org/show_bug.cgi?id=52204

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::startListeningFrameDoc): (WebCore::InspectorDOMAgent::buildArrayForContainerChildren): (WebCore::InspectorDOMAgent::innerFirstChild):
  • inspector/InspectorDOMAgent.h:
5:48 AM Changeset in webkit [75494] by Adam Roben
  • 1 edit
    2 deletes in trunk/Source/WebCore

Delete WKCACFLayer.{cpp,h}

These have been unused since r75262

  • platform/graphics/win/WKCACFLayer.cpp: Removed.
  • platform/graphics/win/WKCACFLayer.h: Removed.
5:40 AM Changeset in webkit [75493] by Adam Roben
  • 3 edits in trunk/LayoutTests

Update test results after r75408

  • platform/mac-leopard/fast/js/large-expressions-expected.txt:
  • platform/win/fast/js/large-expressions-expected.txt:
5:26 AM Changeset in webkit [75492] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] DRT sideeffect revealed by r63657 and r75305
https://bugs.webkit.org/show_bug.cgi?id=42578

After r75305 24 tests fail. Add them to the Skipped list temporarily to make buildbot happy.

  • platform/qt/Skipped:
5:19 AM Changeset in webkit [75491] by Adam Roben
  • 2 edits in trunk/WebKit2

Fix a typo in a comment

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
5:18 AM Changeset in webkit [75490] by mrowe@apple.com
  • 3 edits in trunk/Source/WebCore

Roll out r75487 since it broke the 32-bit build.

5:17 AM Changeset in webkit [75489] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-11 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [regression] Cookies view does not allow columns resize.
https://bugs.webkit.org/show_bug.cgi?id=51877

  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype._updateWithCookies):
4:46 AM Changeset in webkit [75488] by commit-queue@webkit.org
  • 4 edits in trunk

2011-01-11 Noel Gordon <noel.gordon@gmail.com>

Reviewed by James Robinson.

[chromium] canvas.toDataURL("image/jpeg") should composite onto black.
https://bugs.webkit.org/show_bug.cgi?id=51237

canvas/philip/tests/toDataURL.jpeg.alpha.html only fails on chromium-mac
now, tracked by bug http://webkit.org/b/40147.

  • platform/chromium/test_expectations.txt: win & linux pass.

2011-01-11 Noel Gordon <noel.gordon@gmail.com>

Reviewed by James Robinson.

[chromium] canvas.toDataURL("image/jpeg") should composite onto black.
https://bugs.webkit.org/show_bug.cgi?id=51237

The Canvas specification requires that the canvas image is composited using
the Porter-Duff operator source-over onto a black background; the resultant
image should be JPEG encoded and returned as a dataURL. To composite image
A and background B, for any Porter-Duff operator, produce pixels I with

I = c(A)F(A) + c(B)F(B)

where, F(X) is the fraction [0.0-1.0] contributed to the composite by image
X, and c(X) are the premultiplied RGB color components of image X. Note by
definition, c(B) = 0 since the background is black, so I = c(A)F(A). Since
F(A) = 1 in Porter-Duff operator source-over, the composited pixels satisfy
I = c(A). Hence, to conform to the Canvas spec, pass the premultiplied RGB
color components of the canvas image to the JPEG encoder.

Covered by canvas/philip/tests/toDataURL.jpeg.alpha.html

  • platform/image-encoders/skia/JPEGImageEncoder.cpp: (WebCore::preMultipliedBGRAtoRGB): Use Porter-Duff source-over black.
4:44 AM Changeset in webkit [75487] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-01-11 François Sausset <François Sausset>

Reviewed by Eric Seidel.

Code cleaning in rendering/mathml/RenderMathMLFraction.cpp
https://bugs.webkit.org/show_bug.cgi?id=52201

Replace unneeded doubles by floats and remove unneeded casts.

  • rendering/mathml/RenderMathMLFraction.cpp: (WebCore::RenderMathMLFraction::paint):
  • rendering/mathml/RenderMathMLFraction.h:
4:31 AM Changeset in webkit [75486] by pfeldman@chromium.org
  • 8 edits in trunk

2011-01-11 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chromium DevTools: get rid of APU-related code in WebKit/chromium.
https://bugs.webkit.org/show_bug.cgi?id=52152

  • inspector/InspectorController.cpp: (WebCore::InspectorController::restoreInspectorStateFromCookie): (WebCore::InspectorController::setInjectedScriptSource):
  • inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState):
  • inspector/InspectorState.h:
  • inspector/front-end/inspector.js:

2011-01-11 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chromium DevTools: get rid of APU-related code in WebKit/chromium.
https://bugs.webkit.org/show_bug.cgi?id=52152

  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::WebDevToolsAgentImpl): (WebKit::WebDevToolsAgentImpl::detach): (WebKit::WebDevToolsAgentImpl::frontendLoaded): (WebKit::WebDevToolsAgentImpl::setRuntimeProperty): (WebKit::WebDevToolsAgentImpl::sendMessageToFrontend):
  • src/WebDevToolsAgentImpl.h:
3:44 AM Changeset in webkit [75485] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-01-11 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION] Load timing is requested
for all resources (not only for the main one).
https://bugs.webkit.org/show_bug.cgi?id=51749

  • inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest):
  • loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
3:38 AM Changeset in webkit [75484] by antonm@chromium.org
  • 1 edit
    2 deletes in trunk/LayoutTests

Unreviewed Chromium test expectations update.

Remove now unnecessary Chromium overrides.

  • platform/chromium-mac/fast/regex/malformed-escapes-expected.txt: Removed.
  • platform/chromium-win/fast/regex/malformed-escapes-expected.txt: Removed.
3:36 AM Changeset in webkit [75483] by pfeldman@chromium.org
  • 1 edit in branches/chromium/597/WebCore/inspector/front-end/StylesSidebarPane.js

Merge 74710 - 2010-12-28 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: REGRESSION: Clicking image resource in style sidebar doesn't actually go to resource anymore
https://bugs.webkit.org/show_bug.cgi?id=51663

  • inspector/elements-tests2.js: (initialize_ElementTest.InspectorTest.dumpSelectedElementStyles): Drive-by: remove bad test exit code.
  • inspector/resources/styles-url-linkify-iframe.html: Added.
  • inspector/resources/styles-url-linkify.css: Added. (#local):
  • inspector/styles-url-linkify-expected.txt: Added.
  • inspector/styles-url-linkify.html: Added.

2010-12-28 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: REGRESSION: Clicking image resource in style sidebar doesn't actually go to resource anymore
https://bugs.webkit.org/show_bug.cgi?id=51663

The base URI is now computed correctly for links from CSS property uri(...) values. Additionally,
optional quotes/apostrophes and spaces are now allowed inside uri(...).

Test: inspector/styles-url-linkify.html

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL): (WebInspector.StylePropertyTreeElement.prototype.updateTitle):

TBR=apavlov@chromium.org
BUG=68159
Review URL: http://codereview.chromium.org/6115007

3:26 AM Changeset in webkit [75482] by commit-queue@webkit.org
  • 6 edits
    8 adds in trunk/LayoutTests

2011-01-11 Shane Stephens <shanestephens@google.com>

Reviewed by Eric Seidel.

[Chromium] Tests marked as WONTFIX SKIP but bug causing test failure fixed.
https://bugs.webkit.org/show_bug.cgi?id=51865

  • platform/chromium-linux/svg/custom/fill-SVGPaint-interface-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/fill-SVGPaint-interface-expected.png: Added.
  • platform/chromium-linux/svg/custom/fill-SVGPaint-interface-expected.txt: Added.
  • platform/chromium-linux/svg/custom/getPresentationAttribute-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/getPresentationAttribute-expected.png: Added.
  • platform/chromium-linux/svg/custom/getPresentationAttribute-expected.txt: Added.
  • platform/chromium-win/svg/custom/fill-SVGPaint-interface-expected.checksum:
  • platform/chromium-win/svg/custom/fill-SVGPaint-interface-expected.png:
  • platform/chromium-win/svg/custom/fill-SVGPaint-interface-expected.txt: Added.
  • platform/chromium-win/svg/custom/getPresentationAttribute-expected.checksum:
  • platform/chromium-win/svg/custom/getPresentationAttribute-expected.png:
  • platform/chromium-win/svg/custom/getPresentationAttribute-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
3:18 AM Changeset in webkit [75481] by Carlos Garcia Campos
  • 10 edits in trunk

2011-01-11 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] GRefPtr should not be used with Gtk widgets
https://bugs.webkit.org/show_bug.cgi?id=51241

GRefPtr breaks the widget life-cycle, the main problem is
that GRefPtr calls g_object_unref() when it's destroyed,
which is undesirable for widgets. In gtk+ widgets are created with
a floating reference and when added to a container, the container
takes the ownership of the widget consuming the floating
reference. So you don't usually need to call g_object_ref/unref on
widgets (only for some operations like reparent a widget) and
toplevel widgets are destroyed with gtk_widget_destroy().

  • platform/ContextMenuItem.h:
  • platform/gtk/ContextMenuGtk.cpp: (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::~ContextMenu): (WebCore::ContextMenu::setPlatformDescription):
  • platform/gtk/ContextMenuItemGtk.cpp: (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::releasePlatformDescription): (WebCore::ContextMenuItem::type): (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::setAction): (WebCore::ContextMenuItem::title): (WebCore::ContextMenuItem::setTitle): (WebCore::ContextMenuItem::platformSubMenu): (WebCore::ContextMenuItem::setSubMenu): (WebCore::ContextMenuItem::setChecked): (WebCore::ContextMenuItem::setEnabled):

2011-01-11 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] GRefPtr should not be used with Gtk widgets
https://bugs.webkit.org/show_bug.cgi?id=51241

GRefPtr breaks the widget life-cycle, the main problem is
that GRefPtr calls g_object_unref() when it's destroyed,
which is undesirable for widgets. In gtk+ widgets are created with
a floating reference and when added to a container, the container
takes the ownership of the widget consuming the floating
reference. So you don't usually need to call g_object_ref/unref on
widgets (only for some operations like reparent a widget) and
toplevel widgets are destroyed with gtk_widget_destroy().

  • WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::DragClient): (WebKit::DragClient::~DragClient): (WebKit::DragClient::startDrag):
  • WebCoreSupport/DragClientGtk.h:
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::postCommitFrameViewSetup):
  • webkit/webkitwebview.cpp: (webkit_web_view_dispose):
  • webkit/webkitwebviewprivate.h:
2:36 AM Changeset in webkit [75480] by eric@webkit.org
  • 10 edits
    2 adds in trunk/Tools

2011-01-11 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

commit-queue should know how to upload archived results (for test flakes or general failures)
https://bugs.webkit.org/show_bug.cgi?id=52048

Now the queue will always upload results. Either the entire zip, or just
the diffs.txt in the case of text failures.

This should make understanding flakes much easier, and paves the way
for having the EWS run layout tests (and upload failures).

In order to upload .zip files I had to teach bugzilla.py to autodetect
mime types from the filename. Since mimetypes.py doesn't include a mapping
for .patch files, I have it add one before calling guess_type.

We may find that always uploading the whole zip instead of just the -diffs.txt
file is preferable, but for now I'm keeping the old behavior because it makes
quickly understanding text failures easy.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  • Scripts/webkitpy/common/system/workspace.py: Added.
  • Scripts/webkitpy/common/system/workspace_unittest.py: Added.
  • Scripts/webkitpy/tool/bot/commitqueuetask.py:
  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  • Scripts/webkitpy/tool/bot/flakytestreporter.py:
  • Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
2:08 AM Changeset in webkit [75479] by benjamin.poulain@nokia.com
  • 2 edits in trunk/WebKit/qt

2011-01-11 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix tst_QWebPage::geolocationRequestJS()
https://bugs.webkit.org/show_bug.cgi?id=46814

Skip the test when WebKit is compiled without geolocation.

  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::geolocationRequestJS):

Jan 10, 2011:

10:12 PM Changeset in webkit [75478] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-10 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium test expectations update.

Reorganized scrollbar-related failures.

  • platform/chromium/test_expectations.txt:
10:07 PM Changeset in webkit [75477] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-10 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium test expectations update.

Remove entries for tests that now pass.

A bunch of tests with scrollbars started to pass after unncessary
Chromium baselines with removed with r75463, r75446 and
r75440.

ietestcenter/Javascript/15.4.4.14-9-b-i-6.html and ietestcenter/
Javascript/15.4.4.15-8-b-i-6.html started to pass after
http://crrev.com/70894, which rolled V8 to 3.0.7, which fixed
http://code.google.com/p/v8/issues/detail?id=1015.

fast/text/font-size-zero.html appears to always pass.

  • platform/chromium/test_expectations.txt:
9:45 PM Changeset in webkit [75476] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-10 Stephen White <senorblanco@chromium.org>

Unreviewed; chromium-gpu test_expectations updates.

Mark 3 tests as failing after skia roll (chromium r75408).

  • platform/chromium-gpu/test_expectations.txt:
8:50 PM Changeset in webkit [75475] by Csaba Osztrogonác
  • 4 edits in trunk/Tools

Unreviewed, rolling out r75464.
http://trac.webkit.org/changeset/75464
https://bugs.webkit.org/show_bug.cgi?id=52193

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-01-10
Followup rollout for 75474 (Requested by Ossy on #webkit).

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):

  • MiniBrowser/win/BrowserView.cpp:

(BrowserView::create):

  • WebKitTestRunner/TestController.cpp:

(WTR::createOtherPage):
(WTR::TestController::initialize):

8:40 PM Changeset in webkit [75474] by Csaba Osztrogonác
  • 23 edits
    8 deletes in trunk/WebKit2

Unreviewed, rolling out r75460.
http://trac.webkit.org/changeset/75460
https://bugs.webkit.org/show_bug.cgi?id=52191

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-01-10
It broke Qt-WK2 build (Requested by Ossy on #webkit).

  • Shared/API/c/WKBase.h:
  • Shared/APIObject.h:
  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKGeolocationPermissionRequest.cpp: Removed.
  • UIProcess/API/C/WKGeolocationPermissionRequest.h: Removed.
  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/C/WebKit2.h:
  • UIProcess/API/qt/qwkpage.cpp:

(QWKPage::QWKPage):

  • UIProcess/GeolocationPermissionRequestManagerProxy.cpp: Removed.
  • UIProcess/GeolocationPermissionRequestManagerProxy.h: Removed.
  • UIProcess/GeolocationPermissionRequestProxy.cpp: Removed.
  • UIProcess/GeolocationPermissionRequestProxy.h: Removed.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::processDidCrash):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebUIClient.cpp:
  • UIProcess/WebUIClient.h:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp: Removed.
  • WebProcess/Geolocation/GeolocationPermissionRequestManager.h: Removed.
  • WebProcess/Geolocation/WebGeolocationManager.cpp:
  • WebProcess/Geolocation/WebGeolocationManager.h:
  • WebProcess/WebCoreSupport/WebGeolocationClient.cpp:

(WebKit::WebGeolocationClient::requestPermission):
(WebKit::WebGeolocationClient::cancelPermissionRequest):

  • WebProcess/WebCoreSupport/WebGeolocationClient.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:
8:29 PM Changeset in webkit [75473] by Csaba Osztrogonác
  • 11 edits in trunk/WebKit2

Unreviewed, rolling out r75459
http://trac.webkit.org/changeset/75459

Work towards having the WebPageProxy decide when to create the DrawingAreaProxy
https://bugs.webkit.org/show_bug.cgi?id=52184

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:
  • UIProcess/API/mac/WKView.mm:
  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/API/qt/qwkpage.cpp:
  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::reinitializeWebPage):

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::WebView):

  • UIProcess/win/WebView.h:
8:14 PM Changeset in webkit [75472] by Beth Dakin
  • 3 edits
    2 adds in trunk

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=51119, transformed
elements not responding properly to :hover after r73385.
Just use the entire document area as the hit test area,
since there appears to be a rounding bug/issues with relying
on float math when mapping the hit test area into
transformed coordinates.

Patch by David Hyatt <hyatt@apple.com> on 2010-10-10
Reviewed by Simon Fraser.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTest):

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=51119

Patch by David Hyatt <hyatt@apple.com> on 2011-01-10
Reviewed by Simon Fraser.

  • fast/transforms/transform-hit-test-flipped-expected.txt: Added.
  • fast/transforms/transform-hit-test-flipped.html: Added.
8:05 PM Changeset in webkit [75471] by jschuh@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-10 Justin Schuh <jschuh@chromium.org>

Unreviewed Chromium test expectations update.

Fix path for: fast/js/kde/parse.html

  • platform/chromium/test_expectations.txt:
7:48 PM Changeset in webkit [75470] by jschuh@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-10 Justin Schuh <jschuh@chromium.org>

Unreviewed Chromium test expectations update.

Mark 3 tests as failing on chromium after r75408.

  • platform/chromium/test_expectations.txt:
7:29 PM Changeset in webkit [75469] by senorblanco@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-01-10 Stephen White <senorblanco@chromium.org>

Reviewed by James Robinson.

Fix canvas->canvas draws on the GPU path.
https://bugs.webkit.org/show_bug.cgi?id=52141


Two problems: according to the canvas spec, both source and
destination rects can have negative width or height, but this shouldn't
cause the image to be flipped. So we need to normalize the rects (in
the software path, this is done by BitmapImage*::draw). Secondly, in
the FBO->FBO path, the image needs to be flipped vertically, since it
is drawn upside down. We were doing this by flipping the destination
rect, but this doesn't work if the source rect is not the entire image,
since we extract the wrong part of the image. Fixed by flipping the
source rect instead (and flipping it within the image buffer's height,
not the source rect's height).

Covered by fast/canvas/drawImage-with-negative-source-destination.html.

  • platform/graphics/skia/BitmapImageSingleFrameSkia.h: Put normalizeRect() in global scope.
  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::draw): Fix as above: normalize both source and dest rects, and flip the source rect instead of the dest rect.
  • platform/graphics/skia/ImageSkia.cpp: (WebCore::normalizeRect): Put normalizeRect() in global scope.
6:57 PM Changeset in webkit [75468] by andersca@apple.com
  • 6 edits in trunk/WebKit2

2011-01-10 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Remove size parameter to WebPageProxy::initializeWebPage
https://bugs.webkit.org/show_bug.cgi?id=52188

  • UIProcess/API/mac/WKView.mm: (-[WKView initWithFrame:contextRef:pageGroupRef:]):
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::init):
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::initializeWebPage):
  • UIProcess/WebPageProxy.h:
  • UIProcess/win/WebView.cpp: (WebKit::WebView::WebView):
6:50 PM Changeset in webkit [75467] by Laszlo Gombos
  • 20 edits in trunk

2011-01-10 Laszlo Gombos <Laszlo Gombos>

Reviewed by Csaba Osztrogonác.

[Qt] Baseline qt_minimal configuration
https://bugs.webkit.org/show_bug.cgi?id=51313

  • WebKit.pri: List the supported QT_NO_FEATURE flags under qt_minimal configuration.

2011-01-10 Laszlo Gombos <Laszlo Gombos>

Reviewed by Csaba Osztrogonác.

[Qt] Baseline qt_minimal configuration
https://bugs.webkit.org/show_bug.cgi?id=51313

No new tests as there is no new functionality.

  • platform/graphics/qt/GraphicsLayerQt.cpp: Fix the location of the QT_NO_ANIMATION guard.
  • platform/qt/WheelEventQt.cpp: (WebCore::PlatformWheelEvent::applyDelta): Fix the location of the QT_NO_WHEELEVENT guard.

2011-01-10 Laszlo Gombos <Laszlo Gombos>

Reviewed by Csaba Osztrogonác.

[Qt] Baseline qt_minimal configuration
https://bugs.webkit.org/show_bug.cgi?id=51313

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add QT_NO_UNDOSTACK guard.
  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER guards. (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard. (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard. (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard. (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
  • QtTestBrowser/launcherwindow.h:
  • QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
  • QtTestBrowser/locationedit.h: Ditto.
  • QtTestBrowser/mainwindow.cpp: (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and QT_NO_UNDOSTACK guards. (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard. (MainWindow::changeLocation): Ditto. (MainWindow::openFile): Add QT_NO_FILEDIALOG guard. (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
  • QtTestBrowser/webpage.cpp: (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard. (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
  • QtTestBrowser/webview.cpp: (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard. (WebViewGraphicsBased::animatedYFlip): Ditto.

2011-01-10 Laszlo Gombos <Laszlo Gombos>

Reviewed by Csaba Osztrogonác.

[Qt] Baseline qt_minimal configuration
https://bugs.webkit.org/show_bug.cgi?id=51313

  • WebCoreSupport/PopupMenuQt.cpp: (WebCore::PopupMenuQt::show): Add QT_NO_COMBOBOX guard.
  • WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopup::populate): Add QT_NO_TOOLTIP guard.
  • tests/qwebframe/tst_qwebframe.cpp: Add QT_NO_COMBOBOX guard.
  • tests/qwebpage/tst_qwebpage.cpp: (PluginPage::createPlugin): Add QT_NO_INPUTDIALOG guard.
6:50 PM Changeset in webkit [75466] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Didn't mean to land this.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeWebPage):

  • UIProcess/WebPageProxy.h:
6:49 PM Changeset in webkit [75465] by andersca@apple.com
  • 4 edits in trunk/WebKit2

2011-01-10 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

WebPageProxy::creationParameters no longer needs to take a size
https://bugs.webkit.org/show_bug.cgi?id=52187

WebPageProxy::creationParameters can just ask the page client for the view size now.

  • UIProcess/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::createInspectorPage):
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::initializeWebPage): (WebKit::WebPageProxy::reinitializeWebPage): (WebKit::WebPageProxy::createNewPage): (WebKit::WebPageProxy::creationParameters):
  • UIProcess/WebPageProxy.h:
6:48 PM Changeset in webkit [75464] by weinig@apple.com
  • 4 edits in trunk/Tools

Fix build.

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):

  • MiniBrowser/win/BrowserView.cpp:

(BrowserView::create):

  • WebKitTestRunner/TestController.cpp:

(WTR::createOtherPage):
(WTR::TestController::initialize):

6:46 PM Changeset in webkit [75463] by mihaip@chromium.org
  • 7 edits
    2 adds
    6 deletes in trunk/LayoutTests

2011-01-10 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium test expectations update.

Remove chromium-mac baselines for css1/ and css2.1/ tests that had them
because of scrollbars. Update stale mac-leopard baselines.

  • platform/chromium-mac/css1/box_properties/clear-expected.checksum: Removed.
  • platform/chromium-mac/css1/box_properties/clear-expected.png: Removed.
  • platform/chromium-mac/css1/text_properties/text_transform-expected.checksum: Removed.
  • platform/chromium-mac/css1/text_properties/text_transform-expected.png: Removed.
  • platform/chromium-mac/css1/text_properties/vertical_align-expected.checksum: Removed.
  • platform/chromium-mac/css1/text_properties/vertical_align-expected.png: Removed.
  • platform/mac-leopard/css1/box_properties/clear_float-expected.checksum:
  • platform/mac-leopard/css1/box_properties/clear_float-expected.png:
  • platform/mac-leopard/css1/box_properties/float_elements_in_series-expected.checksum:
  • platform/mac-leopard/css1/box_properties/float_elements_in_series-expected.png:
  • platform/mac-leopard/css1/box_properties/float_on_text_elements-expected.checksum:
  • platform/mac-leopard/css1/box_properties/float_on_text_elements-expected.png:
  • platform/mac-leopard/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum: Added.
  • platform/mac-leopard/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Added.
6:39 PM Changeset in webkit [75462] by andersca@apple.com
  • 5 edits in trunk/WebKit2

2011-01-10 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Pass information about the view in the WebPageCreationParameters
https://bugs.webkit.org/show_bug.cgi?id=52186

  • Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode): (WebKit::WebPageCreationParameters::decode): Encode and decode the state flags.
  • Shared/WebPageCreationParameters.h: Add new state flags.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::creationParameters): Initialize the state flags.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): Update the page state from the state flags.
6:26 PM Changeset in webkit [75461] by commit-queue@webkit.org
  • 3 edits
    6 adds in trunk

2011-01-10 Joe Mason <jmason@rim.com>

Reviewed by Alexey Proskuryakov.

WebSockets: unbounded buffer growth when server sends bad data
https://bugs.webkit.org/show_bug.cgi?id=51253

Tests that a websocket handshake should fail after 1024 bytes without a
newline, or if it contains a null byte before the first newline.

  • http/tests/websocket/tests/handshake-fail-by-maxlength-expected.txt: Added.
  • http/tests/websocket/tests/handshake-fail-by-maxlength.html: Added.
  • http/tests/websocket/tests/handshake-fail-by-maxlength_wsh.py: Added.
  • http/tests/websocket/tests/handshake-fail-by-prepended-null-expected.txt: Added.
  • http/tests/websocket/tests/handshake-fail-by-prepended-null.html: Added.
  • http/tests/websocket/tests/handshake-fail-by-prepended-null_wsh.py: Added.

2011-01-10 Joe Mason <jmason@rim.com>

Reviewed by Alexey Proskuryakov.

WebSockets: unbounded buffer growth when server sends bad data
https://bugs.webkit.org/show_bug.cgi?id=51253

Fail a websocket handshake after 1024 bytes without a newline, or if it
contains a null byte before the first newline.

Tests: http/tests/websocket/tests/handshake-fail-by-maxlength.html

http/tests/websocket/tests/handshake-fail-by-prepended-null.html

  • websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::readStatusLine):
6:13 PM Changeset in webkit [75460] by weinig@apple.com
  • 23 edits
    8 adds in trunk/WebKit2

Make Geolocation features work in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=52078

Reviewed by Anders Carlsson.

Step 2 - Add support for requesting and granting permission for geolocation.

  • Shared/API/c/WKBase.h:
  • Shared/APIObject.h:
  • UIProcess/API/C/WebKit2.h:
  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKGeolocationPermissionRequest.cpp: Added.
  • UIProcess/API/C/WKGeolocationPermissionRequest.h: Added.

Add new API type, WKGeolocationPermissionRequestRef.

  • UIProcess/API/C/WKPage.h:

Add new UIClient function for requesting permission.

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPage::QWKPage):
Stub out the UIClient.

  • UIProcess/GeolocationPermissionRequestManagerProxy.cpp: Added.
  • UIProcess/GeolocationPermissionRequestManagerProxy.h: Added.
  • UIProcess/GeolocationPermissionRequestProxy.cpp: Added.
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebUIClient.cpp:
  • UIProcess/WebUIClient.h:
  • WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp: Added.
  • WebProcess/Geolocation/GeolocationPermissionRequestManager.h: Added.
  • WebProcess/Geolocation/WebGeolocationManager.cpp:
  • WebProcess/Geolocation/WebGeolocationManager.h:
  • WebProcess/WebCoreSupport/WebGeolocationClient.cpp:
  • WebProcess/WebCoreSupport/WebGeolocationClient.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::didReceiveGeolocationPermissionDecision):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::geolocationPermissionRequestManager):

  • WebProcess/WebPage/WebPage.messages.in:

Track the permission request through both sides of the process divide.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:

Add new files.

6:12 PM Changeset in webkit [75459] by andersca@apple.com
  • 11 edits in trunk/WebKit2

2011-01-10 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Work towards having the WebPageProxy decide when to create the DrawingAreaProxy
https://bugs.webkit.org/show_bug.cgi?id=52184

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::createDrawingAreaProxy): Call -[WKView _createDrawingAreaProxy].

(WebKit::PageClientImpl::setViewNeedsDisplay):
Call setNeedsDisplayInRect on the WKView.

  • UIProcess/API/mac/WKView.mm: (-[WKView initWithFrame:contextRef:pageGroupRef:]): No need to set the drawing area proxy anymore.

(-[WKView _createDrawingAreaProxy]):
Create a chunked update drawing area proxy for now.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::createDrawingAreaProxy): (QWKPagePrivate::setViewNeedsDisplay): Add stubs.


  • UIProcess/PageClient.h: Add new pure virtual member functions.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::initializeWebPage): (WebKit::WebPageProxy::reinitializeWebPage): Set the new drawing area proxy.
  • UIProcess/win/WebView.cpp: (WebKit::WebView::WebView): No need to set the drawing area proxy anymore.

(WebKit::WebView::createDrawingAreaProxy):
Create a chunked update drawing area proxy for now.

(WebKit::WebView::setViewNeedsDisplay):
Invalidate the window.

6:09 PM Changeset in webkit [75458] by Martin Robinson
  • 1 copy in releases/WebKitGTK/webkit-1.3.10

Branching for WebKitGTK+ release

5:33 PM Changeset in webkit [75457] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix Windows build again.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::isViewWindowActive):

5:06 PM Changeset in webkit [75456] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix Windows build.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::onShowWindowEvent):

5:02 PM Changeset in webkit [75455] by abarth@webkit.org
  • 9 edits in trunk

2011-01-10 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Introduce the notion of a "display-isolated" URL scheme for use by
Chrome-internal URLs
https://bugs.webkit.org/show_bug.cgi?id=50182

This patch adds a Chromium API for registering schemes as
display-isolated. In a subsequent patch, I'll change the "chrome"
scheme in Chrome to be display isolated instead of local. That will
prevent file URLs from linking to chrome URLs.

  • public/WebSecurityPolicy.h:
  • src/WebSecurityPolicy.cpp: (WebKit::WebSecurityPolicy::registerURLSchemeAsDisplayIsolated):

2011-01-10 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Introduce the notion of a "display-isolated" URL scheme for use by
Chrome-internal URLs
https://bugs.webkit.org/show_bug.cgi?id=50182

Update to new function name.

  • Api/qwebsecurityorigin.cpp: (QWebSecurityOrigin::localSchemes):

2011-01-10 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Introduce the notion of a "display-isolated" URL scheme for use by
Chrome-internal URLs
https://bugs.webkit.org/show_bug.cgi?id=50182

This patch adds the basic plumbing for display-isolated URL schemes.
Originally, this patch also had the functional change, but I've split
that off into a separate patch because the original patch caused a
performance regression.

  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canDisplay):
  • platform/SchemeRegistry.cpp: (WebCore::displayIsolatedURLSchemes): (WebCore::SchemeRegistry::registerURLSchemeAsLocal): (WebCore::SchemeRegistry::removeURLSchemeRegisteredAsLocal): (WebCore::SchemeRegistry::localSchemes): (WebCore::SchemeRegistry::deprecatedShouldTreatURLAsLocal): (WebCore::SchemeRegistry::shouldTreatURLSchemeAsLocal): (WebCore::SchemeRegistry::registerURLSchemeAsDisplayIsolated): (WebCore::SchemeRegistry::shouldTreatURLSchemeAsDisplayIsolated):
  • platform/SchemeRegistry.h:
4:51 PM Changeset in webkit [75454] by dbates@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-01-10 Daniel Bates <dbates@rim.com>

Reviewed by Martin Robinson.

Remove extraneous COMPILER(GCC) condition when checking GCC_VERSION_AT_LEAST()
https://bugs.webkit.org/show_bug.cgi?id=52178

It is sufficient to test GCC_VERSION_AT_LEAST() instead of both COMPILER(GCC) and
GCC_VERSION_AT_LEAST(). Notice GCC_VERSION_AT_LEAST() is defined to be 0 when we
are not compiling with GCC.

Fixes style issues at the callsites (i.e. replace comma with comma-space in
macro function argument list). Also, makes a spelling correction in a comment.

  • jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush):
  • wtf/Platform.h:
4:47 PM Changeset in webkit [75453] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix: removed some uses of nextNumber that I missed last time.

  • runtime/Heap.cpp:

(JSC::Heap::reset):
(JSC::Heap::collectAllGarbage):

4:45 PM Changeset in webkit [75452] by andersca@apple.com
  • 17 edits in trunk/WebKit2

2011-01-10 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Use a pull model for view state changes
https://bugs.webkit.org/show_bug.cgi?id=52175

Instead of having the WKView call setFocused, setActive etc on the WebPageProxy, the
WKView now simply informs the WebPageProxy what has changed, using the WebPageProxy::viewStateDidChange
function. The WebPageProxy can then fetch the relevant information using newly added PageClient functions.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::viewSize): (WebKit::PageClientImpl::isViewWindowActive): (WebKit::PageClientImpl::isViewFocused): (WebKit::PageClientImpl::isViewVisible): (WebKit::PageClientImpl::isViewInWindow):
  • UIProcess/API/mac/WKView.mm: (-[WKView initWithFrame:contextRef:pageGroupRef:]): (-[WKView becomeFirstResponder]): (-[WKView resignFirstResponder]): (-[WKView viewDidMoveToWindow]): (-[WKView _windowDidBecomeKey:]): (-[WKView _windowDidResignKey:]): (-[WKView viewDidHide]): (-[WKView viewDidUnhide]): (-[WKView _isFocused]): (-[WKView _didRelaunchProcess]):
  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKView::focusInEvent): (QGraphicsWKView::focusOutEvent):
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::QWKPagePrivate): (QWKPagePrivate::viewSize): (QWKPagePrivate::isViewWindowActive): (QWKPagePrivate::isViewFocused): (QWKPagePrivate::isViewVisible): (QWKPagePrivate::isViewInWindow):
  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebContext.cpp: (WebKit::WebContext::createWebPage):
  • UIProcess/WebContext.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::create): (WebKit::WebPageProxy::WebPageProxy): (WebKit::WebPageProxy::viewStateDidChange):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::createWebPage):
  • UIProcess/WebProcessProxy.h:
  • UIProcess/win/WebView.cpp: (WebKit::WebView::WebView): (WebKit::WebView::onSetFocusEvent): (WebKit::WebView::onKillFocusEvent): (WebKit::WebView::onShowWindowEvent): (WebKit::WebView::updateActiveState): (WebKit::WebView::viewSize): (WebKit::WebView::isViewWindowActive): (WebKit::WebView::isViewFocused): (WebKit::WebView::isViewVisible): (WebKit::WebView::isViewInWindow): (WebKit::WebView::didRelaunchProcess): (WebKit::WebView::setIsInWindow):
  • UIProcess/win/WebView.h:
4:41 PM Changeset in webkit [75451] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-10 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed dead number allocation code.
https://bugs.webkit.org/show_bug.cgi?id=52177

  • runtime/Heap.h:
4:29 PM Changeset in webkit [75450] by jer.noble@apple.com
  • 7 edits in trunk

2011-01-10 Jer Noble <jer.noble@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=52095
REGRESSION (r75277): 2 test cases (<1%) had incorrect layout

Fixes tests:

fullscreen/full-screen-remove-ancestor.html
fullscreen/full-screen-remove.html

Revert change made in r75326, now that the underlying issue has been fixed.

  • fullscreen/full-screen-remove-ancestor-expected.txt:
  • fullscreen/full-screen-remove-expected.txt:

2011-01-10 Jer Noble <jer.noble@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=52095
REGRESSION (r75277): 2 test cases (<1%) had incorrect layout

Fixes tests:

fullscreen/full-screen-remove-ancestor.html
fullscreen/full-screen-remove.html

Previously, the above tests were failing because DRT dumped the contents of their
<script> tags, though all the explicit tests were passing. This was caused by
the document's render tree being left in an inconsistent state when a full screen
element's ancestor was removed from the DOM.

In nodeWillBeRemoved(), match the code in webkitDidExitFullScreen().
Don't detach the documentElement, but rather simply call recalcStyle(Force).

  • dom/Document.cpp: (WebCore::Document::nodeWillBeRemoved):
  • rendering/RenderFullScreen.cpp: (RenderFullScreen::setAnimating): #if ENABLED -> # if USE
  • rendering/RenderFullScreen.h: (WebCore::RenderFullScreen::RenderFullScreen): RenderFullScreen should be an anonymous renderer.
4:29 PM Changeset in webkit [75449] by Martin Robinson
  • 2 edits in trunk/WebKit/gtk

2011-01-10 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

Update the NEWS file in preparation for the 1.3.10 release.

  • NEWS: Update the NEWS.
4:27 PM Changeset in webkit [75448] by jam@chromium.org
  • 12 edits in trunk

2011-01-10 John Abd-El-Malek <jam@chromium.org>

Reviewed by James Robinson.

[chromium] Call WebAutoFillClient instead of WebViewClient for autofill related callbacks
https://bugs.webkit.org/show_bug.cgi?id=52169

  • public/WebView.h:
  • public/WebViewClient.h: (WebKit::WebViewClient::didUpdateInspectorSetting):
  • src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::valueChanged): (WebKit::AutoFillPopupMenuClient::selectionChanged): (WebKit::AutoFillPopupMenuClient::selectionCleared): (WebKit::AutoFillPopupMenuClient::popupDidHide):
  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::textFieldDidBeginEditing): (WebKit::EditorClientImpl::textFieldDidEndEditing): (WebKit::EditorClientImpl::textDidChangeInTextField): (WebKit::EditorClientImpl::doAutofill): (WebKit::EditorClientImpl::onAutocompleteSuggestionAccepted): (WebKit::EditorClientImpl::doTextFieldCommandFromEvent):
  • src/WebViewImpl.cpp: (WebKit::WebView::create): (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::autocompleteHandleKeyEvent):
  • src/WebViewImpl.h: (WebKit::WebViewImpl::autoFillClient):
  • src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::initializeLoader):
4:17 PM Changeset in webkit [75447] by dbates@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-01-10 Daniel Bates <dbates@rim.com>

Reviewed by Darin Adler.

Use builtin_expect when compiling using RVCT in GNU mode
https://bugs.webkit.org/show_bug.cgi?id=51866

We should only use builtin_expect if we are compiling with GCC or RVCT 3 or higher in GNU mode
as pointed out by Siddharth Mathur per <http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0202h/Cjabddedbde.html>.

  • wtf/AlwaysInline.h:
  • wtf/Platform.h: Removed define WTF_COMPILER_RVCT4_OR_GREATER. Instead added macro function RVCT_VERSION_AT_LEAST so that we can test for an arbitrary minimum RVCT version.
4:16 PM Changeset in webkit [75446] by mihaip@chromium.org
  • 3 edits
    30 deletes in trunk/LayoutTests

2011-01-10 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium test expectations update.

Remove chromium-mac baselines for svg/ tests that had them because of
scrollbars.

Also updates Snow Leopard (mac) baselines for svg/dom/
SVGLengthList-basics.xhtml after r72518.

  • platform/chromium-mac/svg/dom/SVGLengthList-basics-expected.checksum: Removed.
  • platform/chromium-mac/svg/dom/SVGLengthList-basics-expected.png: Removed.
  • platform/chromium-mac/svg/dom/SVGTransformList-basics-expected.checksum: Removed.
  • platform/chromium-mac/svg/dom/SVGTransformList-basics-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.checksum: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.checksum: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.checksum: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.checksum: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.checksum: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.checksum: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.checksum: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.checksum: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png: Removed.
  • platform/chromium-mac/svg/hixie/links/003-broken-expected.checksum: Removed.
  • platform/chromium-mac/svg/hixie/links/003-broken-expected.png: Removed.
  • platform/chromium-mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.checksum: Removed.
  • platform/chromium-mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Removed.
  • platform/chromium-mac/svg/zoom/page/zoom-foreignObject-expected.checksum: Removed.
  • platform/chromium-mac/svg/zoom/page/zoom-foreignObject-expected.png: Removed.
  • platform/chromium-mac/svg/zoom/page/zoom-hixie-mixed-008-expected.checksum: Removed.
  • platform/chromium-mac/svg/zoom/page/zoom-hixie-mixed-008-expected.png: Removed.
  • platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.checksum: Removed.
  • platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.png: Removed.
  • platform/mac/svg/dom/SVGLengthList-basics-expected.checksum:
  • platform/mac/svg/dom/SVGLengthList-basics-expected.png:
4:05 PM Changeset in webkit [75445] by ggaren@apple.com
  • 2 edits in trunk/WebKit/win

Try to fix Windows build.

  • WebJavaScriptCollector.cpp: Updated for rename to Heap.*. (Didn't catch

this one before because it was miscapitalized.)

3:52 PM Changeset in webkit [75444] by Martin Robinson
  • 6 edits in trunk

2011-01-10 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Remove use of deprecated GTK+ methods before the 1.3.10 release
https://bugs.webkit.org/show_bug.cgi?id=52173

No new tests. This is only a build fix.

  • platform/gtk/GRefPtrGtk.cpp: Guard the GdkCursor specialization against GTK+ 3.x. In GTK+ 3.x, GdkCursor is just a GObject.
  • platform/gtk/GRefPtrGtk.h: Ditto.

2011-01-10 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Remove use of deprecated GTK+ methods before the 1.3.10 release
https://bugs.webkit.org/show_bug.cgi?id=52173

  • WebCoreSupport/FullscreenVideoController.cpp: (FullscreenVideoController::enterFullscreen): Use a GRefPtr here to avoid having to call either g_object_unref or gdk_cursor_unref.
  • webkit/webkitwebview.cpp: Guard use of deprecated methods. (webkit_web_view_realize): Ditto. (webkit_web_view_drag_end): Ditto.
3:43 PM Changeset in webkit [75443] by ggaren@apple.com
  • 32 edits
    3 moves in trunk/Source

Moved Collector.* => Heap.*, since the file contains a class named "Heap".

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

  • API/JSCallbackObject.cpp:
  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.pro:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • interpreter/Interpreter.cpp:
  • interpreter/RegisterFile.h:
  • jit/JITStubs.cpp:
  • runtime/Collector.cpp: Removed.
  • runtime/Collector.h: Removed.
  • runtime/CollectorHeapIterator.h:
  • runtime/GCActivityCallbackCF.cpp:
  • runtime/Heap.cpp: Copied from JavaScriptCore/runtime/Collector.cpp.
  • runtime/Heap.h: Copied from JavaScriptCore/runtime/Collector.h.
  • runtime/InitializeThreading.cpp:
  • runtime/JSCell.h:
  • runtime/JSGlobalData.cpp:
  • runtime/JSGlobalData.h:
  • runtime/JSLock.cpp:
  • runtime/JSNumberCell.h:
  • runtime/MachineStackMarker.cpp:
  • runtime/MemoryStatistics.h:
  • runtime/Protect.h:
  • runtime/UString.cpp:
  • runtime/WeakGCMap.h:
  • runtime/WeakGCPtr.h:

Source/JavaScriptGlue:

  • JSUtils.h:

Source/WebCore:

  • ForwardingHeaders/runtime/Collector.h: Removed.
  • ForwardingHeaders/runtime/Heap.h: Copied from WebCore/ForwardingHeaders/runtime/Collector.h.
  • WebCore.vcproj/WebCore.vcproj:
  • bindings/js/GCController.cpp:
  • bindings/js/ScriptGCEvent.cpp:
3:30 PM Changeset in webkit [75442] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Layout test fast/frames/iframe-reparenting-plugins.html is failing on windows
https://bugs.webkit.org/show_bug.cgi?id=52062

Patch by Jenn Braithwaite <jennb@chromium.org> on 2011-01-10
Reviewed by Dmitry Titov.

  • platform/chromium/test_expectations.txt:

Skip the failing test. Same reason other tests using WebKit Test PlugIn fails.

3:14 PM Changeset in webkit [75441] by Martin Robinson
  • 4 edits in trunk/LayoutTests

2011-01-10 Martin Robinson <mrobinson@igalia.com>

Rebaseline some test results after r75389.

  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
3:04 PM Changeset in webkit [75440] by mihaip@chromium.org
  • 12 edits
    2 adds
    7 deletes in trunk/LayoutTests

2011-01-10 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium test expectations update.

More scrollbar change rebaselines.

  • platform/chromium-mac/fast/selectors/166-expected.checksum: Removed.
  • platform/chromium-mac/fast/selectors/166-expected.png: Removed.
  • platform/chromium-mac/fast/table/border-collapsing/004-vertical-expected.checksum: Removed.
  • platform/chromium-mac/fast/table/border-collapsing/004-vertical-expected.png: Removed.
  • platform/chromium-mac/fast/table/height-percent-test-vertical-expected.checksum: Removed.
  • platform/chromium-mac/fast/table/height-percent-test-vertical-expected.png: Removed.
  • platform/chromium-mac/svg/css/composite-shadow-example-expected.checksum:
  • platform/chromium-mac/svg/css/composite-shadow-example-expected.png:
  • platform/chromium-mac/svg/css/composite-shadow-with-opacity-expected.checksum:
  • platform/chromium-mac/svg/css/composite-shadow-with-opacity-expected.png:
  • platform/chromium-mac/svg/css/stars-with-shadow-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.checksum:
  • platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/fast/table/border-collapsing/004-vertical-expected.checksum: Added.
  • platform/mac-leopard/fast/table/border-collapsing/004-vertical-expected.png: Added.
  • platform/mac/fast/table/border-collapsing/004-vertical-expected.checksum:
  • platform/mac/fast/table/border-collapsing/004-vertical-expected.png:
  • platform/mac/fast/table/height-percent-test-vertical-expected.checksum:
  • platform/mac/fast/table/height-percent-test-vertical-expected.png:
2:47 PM Changeset in webkit [75439] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-10 Leonid Ebril <leonid.ebril@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

https://bugs.webkit.org/show_bug.cgi?id=51879

Set the PluginQuirkDontSetNullWindowHandleOnDestroy for Adobe Lite
plugin if Flash 10 or newer (for Symbian platform), setting a nulled
window handler on destroy crashes WebKit.

  • plugins/symbian/PluginPackageSymbian.cpp: (WebCore::PluginPackage::fetchInfo): (WebCore::PluginPackage::determineQuirks):
2:37 PM Changeset in webkit [75438] by eric@webkit.org
  • 3 edits in trunk/Tools

2011-01-10 Eric Seidel <eric@webkit.org>

Reviewed by Ojan Vafai.

style-queue messages are way too long for big patches
https://bugs.webkit.org/show_bug.cgi?id=52161

We definitely could build much fancier list-to-string-with-limit functions
but this should be sufficient for our needs at the moment.

  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/common/system/executive_unittest.py:
2:04 PM Changeset in webkit [75437] by Martin Robinson
  • 8 edits
    1 move
    2 deletes in trunk/Source/WebCore

2011-01-10 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Remove unecessary RenderThemeGtk and WidgetRenderingContext code
https://bugs.webkit.org/show_bug.cgi?id=52170

Remove unnecessary code from RenderThemeGtk3 and RenderThemeGtk now that the
GtkStyleContext port is complete. Also remove WidgetRenderingContextGtk3 and
move WidgetRenderingRenderingContextGtk2 to WidgetRenderingContext and make it
GTK+ 2.x only. Some methods have been moved to RenderThemeGtk2 since they are
GTK+ 2.x only now.

No new tests. This should not change functionality.

  • GNUmakefile.am: Remove WidgetRenderingContextGtk3 and gtk3drawing.c
  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::RenderThemeGtk): (WebCore::gtkIconState): Made this method static. It isn't used outside RenderThemeGtk. (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration): Updated to refelct gtkIconState change. (WebCore::RenderThemeGtk::paintSearchFieldCancelButton): Ditto. (WebCore::RenderThemeGtk::paintMediaButton): Ditto
  • platform/gtk/RenderThemeGtk.h: Move a few methods which are now GTK+ 2.x only.
  • platform/gtk/RenderThemeGtk2.cpp: (WebCore::RenderThemeGtk::platformInit): Added this platform initialization method that is only used for GTK+ 2.x at the moment. (WebCore::RenderThemeGtk::~RenderThemeGtk): Added. (WebCore::getGtkStateType): Made this method static. (WebCore::RenderThemeGtk::getIndicatorMetrics): Moved this here from RenderThemeGtk. (WebCore::setToggleSize): Updated to reflect changes to getGtkStateType. (WebCore::RenderThemeGtk::paintButton): Ditto. (WebCore::RenderThemeGtk::paintSliderTrack): Ditto. (WebCore::RenderThemeGtk::paintSliderThumb): Ditto.
  • platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::gtkScrollbarStyle): Moved to the top of the file. (WebCore::RenderThemeGtk::platformInit): Added. (WebCore::RenderThemeGtk::~RenderThemeGtk): Added. (WebCore::RenderThemeGtk::initMediaColors): Changed to use the GtkStyleContext API to fetch these colors. This was the last dependency on the old API.
  • platform/gtk/WidgetRenderingContext.cpp: Renamed from Source/WebCore/platform/gtk/WidgetRenderingContextGtk2.cpp.
  • platform/gtk/WidgetRenderingContext.h: Made GTK+ 2.x only.
  • platform/gtk/WidgetRenderingContextGtk3.cpp: Removed.
  • platform/gtk/gtk3drawing.c: Removed.
  • platform/gtk/gtkdrawing.h: Made GTK+ 2.x only.
2:03 PM Changeset in webkit [75436] by inferno@chromium.org
  • 1 edit in branches/chromium/597/WebCore/dom/Range.cpp

Merge 75002 - Merge 73818 Build Fix

BUG=65942
Review URL: http://codereview.chromium.org/6085014

2:02 PM Changeset in webkit [75435] by Adam Roben
  • 2 edits in trunk/WebKit2

Don't pass a reference type to va_start

C++ says this results in undefined behavior:

The restrictions that ISO C places on the second parameter to the
va_start() macro in header <stdarg.h> are different in this
International Standard. The parameter parmN is the identifier of
the rightmost parameter in the variable parameter list of the
function definition (the one just before the ...).221) If the
parameter parmN is declared with a function, array, or reference
type, or with a type that is not compatible with the type that
results when passing an argument for which there is no parameter,
the behavior is undefined.

Fixes <http://webkit.org/b/52168> Title of standalone image document
includes bogus image dimensions

Rubber-stamped by Eric Seidel.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::formatLocalizedString): Don't use a reference type for
|format|.

2:01 PM Changeset in webkit [75434] by inferno@chromium.org
  • 1 edit in branches/chromium/597/WebCore/dom/Range.cpp

Merge 73818

BUG=65942
Review URL: http://codereview.chromium.org/6217002

2:00 PM Changeset in webkit [75433] by tony@chromium.org
  • 5 edits
    2 adds in trunk

2011-01-10 Tony Chang <tony@chromium.org>

Unreviewed, rolling out r75398, r75407,
http://trac.webkit.org/changeset/75398
https://bugs.webkit.org/show_bug.cgi?id=52008

Some layout tests are crashing on Chromium Win.

  • platform/chromium-win/fast/backgrounds/animated-gif-as-background-expected.checksum: Added.
  • platform/chromium-win/fast/backgrounds/animated-gif-as-background-expected.png: Added.
  • platform/chromium/test_expectations.txt:

2011-01-10 Tony Chang <tony@chromium.org>

Unreviewed, rolling out r75398.
http://trac.webkit.org/changeset/75398
https://bugs.webkit.org/show_bug.cgi?id=52008

Some layout tests are crashing on Chromium Win.

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::updatePaintRect):
  • DumpRenderTree/chromium/WebViewHost.h:
2:00 PM Changeset in webkit [75432] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/597

Merge 73799

BUG=65942
Review URL: http://codereview.chromium.org/6129003

1:57 PM Changeset in webkit [75431] by mihaip@chromium.org
  • 14 edits
    4 adds in trunk/LayoutTests

2011-01-10 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium test expectations update.

Rebaseline six tests in fast/repaint for chromium-mac. Even after the
scrollbar switch they need Chromium-specific results since repaint
regions are different from the mac port's.

Adds both Leopard (chromium-mac-leopard) and Snow Leopard (chromium-mac)
baselines.

  • platform/chromium-mac-leopard/fast/repaint/fixed-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/repaint/fixed-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/fixed-move-after-keyboard-scroll-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/repaint/fixed-move-after-keyboard-scroll-expected.png: Added.
  • platform/chromium-mac/fast/repaint/fixed-expected.checksum:
  • platform/chromium-mac/fast/repaint/fixed-expected.png:
  • platform/chromium-mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.checksum:
  • platform/chromium-mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.png:
  • platform/chromium-mac/fast/repaint/fixed-tranformed-expected.checksum:
  • platform/chromium-mac/fast/repaint/fixed-tranformed-expected.png:
  • platform/chromium-mac/fast/repaint/moving-shadow-on-container-expected.checksum:
  • platform/chromium-mac/fast/repaint/moving-shadow-on-container-expected.png:
  • platform/chromium-mac/fast/repaint/moving-shadow-on-path-expected.checksum:
  • platform/chromium-mac/fast/repaint/moving-shadow-on-path-expected.png:
  • platform/chromium-mac/fast/repaint/repaint-during-scroll-expected.checksum:
  • platform/chromium-mac/fast/repaint/repaint-during-scroll-expected.png:
  • platform/chromium/test_expectations.txt:
1:56 PM Changeset in webkit [75430] by inferno@chromium.org
  • 4 edits
    2 copies in branches/chromium/597

Merge 75014 - Merge 74636

BUG=67363
Review URL: http://codereview.chromium.org/6186003

1:54 PM Changeset in webkit [75429] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/597

Merge 74979 - Merge 73801

BUG=66473
Review URL: http://codereview.chromium.org/6180005

1:23 PM Changeset in webkit [75428] by inferno@chromium.org
  • 2 edits
    4 copies in branches/chromium/597

Merge 75193 - Merge 75168

BUG=68558
Review URL: http://codereview.chromium.org/6139003

1:21 PM Changeset in webkit [75427] by xan@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Gavin Barraclough.

Remove unused isString() case in JSString::toPrimitiveString()
https://bugs.webkit.org/show_bug.cgi?id=52167

We never call toPrimitiveString() with strings, so remove the
check and add an ASSERT ensuring this never happens. 0.7% overall
progression in sunspider, since one of the call sites is very hot.

  • runtime/JSString.h: (JSC::JSValue::toPrimitiveString):
1:21 PM Changeset in webkit [75426] by inferno@chromium.org
  • 3 edits
    2 copies in branches/chromium/597

Merge 75008 - Merge 74574

BUG=66748
Review URL: http://codereview.chromium.org/6206004

1:19 PM Changeset in webkit [75425] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/597

Merge 75028 - Merge 74779

BUG=68178
Review URL: http://codereview.chromium.org/6157003

1:17 PM Changeset in webkit [75424] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/597

Merge 74984 - Merge 74787

BUG=68181
Review URL: http://codereview.chromium.org/6222002

1:15 PM Changeset in webkit [75423] by inferno@chromium.org
  • 3 edits
    16 copies
    2 deletes in branches/chromium/597

Merge 74987 - Merge 74954

BUG=66760
Review URL: http://codereview.chromium.org/6200003

1:11 PM Changeset in webkit [75422] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/597

Merge 74986 - Merge 74364

BUG=66760

1:08 PM Changeset in webkit [75421] by barraclough@apple.com
  • 11 edits
    7 adds
    7 deletes in trunk/Source/JavaScriptCore

Rename the existing YARR files and classes
https://bugs.webkit.org/show_bug.cgi?id=51872

Patch by Peter Varga <pvarga@inf.u-szeged.hu> on 2011-01-10
Reviewed by Gavin Barraclough.

Replace the "Regex" prefix with "Yarr" in the name of YARR files and classes.

(JSC::RegExp::compile):
(JSC::RegExp::match):
(JSC::RegExp::printTraceData):

  • yarr/YarrInterpreter.cpp: Renamed from Source/JavaScriptCore/yarr/RegexInterpreter.cpp.

(JSC::Yarr::Interpreter::appendParenthesesDisjunctionContext):
(JSC::Yarr::Interpreter::popParenthesesDisjunctionContext):
(JSC::Yarr::Interpreter::DisjunctionContext::DisjunctionContext):
(JSC::Yarr::Interpreter::DisjunctionContext::operator new):
(JSC::Yarr::Interpreter::allocDisjunctionContext):
(JSC::Yarr::Interpreter::freeDisjunctionContext):
(JSC::Yarr::Interpreter::ParenthesesDisjunctionContext::ParenthesesDisjunctionContext):
(JSC::Yarr::Interpreter::ParenthesesDisjunctionContext::operator new):
(JSC::Yarr::Interpreter::ParenthesesDisjunctionContext::restoreOutput):
(JSC::Yarr::Interpreter::ParenthesesDisjunctionContext::getDisjunctionContext):
(JSC::Yarr::Interpreter::allocParenthesesDisjunctionContext):
(JSC::Yarr::Interpreter::freeParenthesesDisjunctionContext):
(JSC::Yarr::Interpreter::InputStream::InputStream):
(JSC::Yarr::Interpreter::InputStream::next):
(JSC::Yarr::Interpreter::InputStream::rewind):
(JSC::Yarr::Interpreter::InputStream::read):
(JSC::Yarr::Interpreter::InputStream::readPair):
(JSC::Yarr::Interpreter::InputStream::readChecked):
(JSC::Yarr::Interpreter::InputStream::reread):
(JSC::Yarr::Interpreter::InputStream::prev):
(JSC::Yarr::Interpreter::InputStream::getPos):
(JSC::Yarr::Interpreter::InputStream::setPos):
(JSC::Yarr::Interpreter::InputStream::atStart):
(JSC::Yarr::Interpreter::InputStream::atEnd):
(JSC::Yarr::Interpreter::InputStream::checkInput):
(JSC::Yarr::Interpreter::InputStream::uncheckInput):
(JSC::Yarr::Interpreter::InputStream::isNotAvailableInput):
(JSC::Yarr::Interpreter::testCharacterClass):
(JSC::Yarr::Interpreter::checkCharacter):
(JSC::Yarr::Interpreter::checkCasedCharacter):
(JSC::Yarr::Interpreter::checkCharacterClass):
(JSC::Yarr::Interpreter::tryConsumeBackReference):
(JSC::Yarr::Interpreter::matchAssertionBOL):
(JSC::Yarr::Interpreter::matchAssertionEOL):
(JSC::Yarr::Interpreter::matchAssertionWordBoundary):
(JSC::Yarr::Interpreter::backtrackPatternCharacter):
(JSC::Yarr::Interpreter::backtrackPatternCasedCharacter):
(JSC::Yarr::Interpreter::matchCharacterClass):
(JSC::Yarr::Interpreter::backtrackCharacterClass):
(JSC::Yarr::Interpreter::matchBackReference):
(JSC::Yarr::Interpreter::backtrackBackReference):
(JSC::Yarr::Interpreter::recordParenthesesMatch):
(JSC::Yarr::Interpreter::resetMatches):
(JSC::Yarr::Interpreter::parenthesesDoBacktrack):
(JSC::Yarr::Interpreter::matchParenthesesOnceBegin):
(JSC::Yarr::Interpreter::matchParenthesesOnceEnd):
(JSC::Yarr::Interpreter::backtrackParenthesesOnceBegin):
(JSC::Yarr::Interpreter::backtrackParenthesesOnceEnd):
(JSC::Yarr::Interpreter::matchParenthesesTerminalBegin):
(JSC::Yarr::Interpreter::matchParenthesesTerminalEnd):
(JSC::Yarr::Interpreter::backtrackParenthesesTerminalBegin):
(JSC::Yarr::Interpreter::backtrackParenthesesTerminalEnd):
(JSC::Yarr::Interpreter::matchParentheticalAssertionBegin):
(JSC::Yarr::Interpreter::matchParentheticalAssertionEnd):
(JSC::Yarr::Interpreter::backtrackParentheticalAssertionBegin):
(JSC::Yarr::Interpreter::backtrackParentheticalAssertionEnd):
(JSC::Yarr::Interpreter::matchParentheses):
(JSC::Yarr::Interpreter::backtrackParentheses):
(JSC::Yarr::Interpreter::lookupForBeginChars):
(JSC::Yarr::Interpreter::matchDisjunction):
(JSC::Yarr::Interpreter::matchNonZeroDisjunction):
(JSC::Yarr::Interpreter::interpret):
(JSC::Yarr::Interpreter::Interpreter):
(JSC::Yarr::ByteCompiler::ParenthesesStackEntry::ParenthesesStackEntry):
(JSC::Yarr::ByteCompiler::ByteCompiler):
(JSC::Yarr::ByteCompiler::compile):
(JSC::Yarr::ByteCompiler::checkInput):
(JSC::Yarr::ByteCompiler::assertionBOL):
(JSC::Yarr::ByteCompiler::assertionEOL):
(JSC::Yarr::ByteCompiler::assertionWordBoundary):
(JSC::Yarr::ByteCompiler::atomPatternCharacter):
(JSC::Yarr::ByteCompiler::atomCharacterClass):
(JSC::Yarr::ByteCompiler::atomBackReference):
(JSC::Yarr::ByteCompiler::atomParenthesesOnceBegin):
(JSC::Yarr::ByteCompiler::atomParenthesesTerminalBegin):
(JSC::Yarr::ByteCompiler::atomParenthesesSubpatternBegin):
(JSC::Yarr::ByteCompiler::atomParentheticalAssertionBegin):
(JSC::Yarr::ByteCompiler::atomParentheticalAssertionEnd):
(JSC::Yarr::ByteCompiler::popParenthesesStack):
(JSC::Yarr::ByteCompiler::dumpDisjunction):
(JSC::Yarr::ByteCompiler::closeAlternative):
(JSC::Yarr::ByteCompiler::closeBodyAlternative):
(JSC::Yarr::ByteCompiler::atomParenthesesSubpatternEnd):
(JSC::Yarr::ByteCompiler::atomParenthesesOnceEnd):
(JSC::Yarr::ByteCompiler::atomParenthesesTerminalEnd):
(JSC::Yarr::ByteCompiler::regexBegin):
(JSC::Yarr::ByteCompiler::regexEnd):
(JSC::Yarr::ByteCompiler::alternativeBodyDisjunction):
(JSC::Yarr::ByteCompiler::alternativeDisjunction):
(JSC::Yarr::ByteCompiler::emitDisjunction):
(JSC::Yarr::byteCompile):
(JSC::Yarr::interpret):

  • yarr/YarrInterpreter.h: Renamed from Source/JavaScriptCore/yarr/RegexInterpreter.h.

(JSC::Yarr::ByteTerm::ByteTerm):
(JSC::Yarr::ByteTerm::BOL):
(JSC::Yarr::ByteTerm::CheckInput):
(JSC::Yarr::ByteTerm::EOL):
(JSC::Yarr::ByteTerm::WordBoundary):
(JSC::Yarr::ByteTerm::BackReference):
(JSC::Yarr::ByteTerm::BodyAlternativeBegin):
(JSC::Yarr::ByteTerm::BodyAlternativeDisjunction):
(JSC::Yarr::ByteTerm::BodyAlternativeEnd):
(JSC::Yarr::ByteTerm::AlternativeBegin):
(JSC::Yarr::ByteTerm::AlternativeDisjunction):
(JSC::Yarr::ByteTerm::AlternativeEnd):
(JSC::Yarr::ByteTerm::SubpatternBegin):
(JSC::Yarr::ByteTerm::SubpatternEnd):
(JSC::Yarr::ByteTerm::invert):
(JSC::Yarr::ByteTerm::capture):
(JSC::Yarr::ByteDisjunction::ByteDisjunction):
(JSC::Yarr::BytecodePattern::BytecodePattern):
(JSC::Yarr::BytecodePattern::~BytecodePattern):

  • yarr/YarrJIT.cpp: Renamed from Source/JavaScriptCore/yarr/RegexJIT.cpp.

(JSC::Yarr::YarrGenerator::optimizeAlternative):
(JSC::Yarr::YarrGenerator::matchCharacterClassRange):
(JSC::Yarr::YarrGenerator::matchCharacterClass):
(JSC::Yarr::YarrGenerator::jumpIfNoAvailableInput):
(JSC::Yarr::YarrGenerator::jumpIfAvailableInput):
(JSC::Yarr::YarrGenerator::checkInput):
(JSC::Yarr::YarrGenerator::atEndOfInput):
(JSC::Yarr::YarrGenerator::notAtEndOfInput):
(JSC::Yarr::YarrGenerator::jumpIfCharEquals):
(JSC::Yarr::YarrGenerator::jumpIfCharNotEquals):
(JSC::Yarr::YarrGenerator::readCharacter):
(JSC::Yarr::YarrGenerator::storeToFrame):
(JSC::Yarr::YarrGenerator::storeToFrameWithPatch):
(JSC::Yarr::YarrGenerator::loadFromFrame):
(JSC::Yarr::YarrGenerator::loadFromFrameAndJump):
(JSC::Yarr::YarrGenerator::IndirectJumpEntry::IndirectJumpEntry):
(JSC::Yarr::YarrGenerator::IndirectJumpEntry::addJump):
(JSC::Yarr::YarrGenerator::AlternativeBacktrackRecord::AlternativeBacktrackRecord):
(JSC::Yarr::YarrGenerator::GenerationState::GenerationState):
(JSC::Yarr::YarrGenerator::GenerationState::addIndirectJumpEntry):
(JSC::Yarr::YarrGenerator::GenerationState::emitIndirectJumpTable):
(JSC::Yarr::YarrGenerator::GenerationState::incrementParenNestingLevel):
(JSC::Yarr::YarrGenerator::GenerationState::decrementParenNestingLevel):
(JSC::Yarr::YarrGenerator::GenerationState::addParenthesesTail):
(JSC::Yarr::YarrGenerator::GenerationState::emitParenthesesTail):
(JSC::Yarr::YarrGenerator::GenerationState::addJumpToNextInteration):
(JSC::Yarr::YarrGenerator::GenerationState::addJumpsToNextInteration):
(JSC::Yarr::YarrGenerator::GenerationState::addDataLabelToNextIteration):
(JSC::Yarr::YarrGenerator::GenerationState::linkToNextIteration):
(JSC::Yarr::YarrGenerator::BacktrackDestination::BacktrackDestination):
(JSC::Yarr::YarrGenerator::BacktrackDestination::clear):
(JSC::Yarr::YarrGenerator::BacktrackDestination::clearDataLabel):
(JSC::Yarr::YarrGenerator::BacktrackDestination::hasDestination):
(JSC::Yarr::YarrGenerator::BacktrackDestination::isStackOffset):
(JSC::Yarr::YarrGenerator::BacktrackDestination::isLabel):
(JSC::Yarr::YarrGenerator::BacktrackDestination::isJumpList):
(JSC::Yarr::YarrGenerator::BacktrackDestination::hasDataLabel):
(JSC::Yarr::YarrGenerator::BacktrackDestination::copyTarget):
(JSC::Yarr::YarrGenerator::BacktrackDestination::copyTo):
(JSC::Yarr::YarrGenerator::BacktrackDestination::addBacktrackJump):
(JSC::Yarr::YarrGenerator::BacktrackDestination::setStackOffset):
(JSC::Yarr::YarrGenerator::BacktrackDestination::setLabel):
(JSC::Yarr::YarrGenerator::BacktrackDestination::setNextBacktrackLabel):
(JSC::Yarr::YarrGenerator::BacktrackDestination::copyBacktrackToLabel):
(JSC::Yarr::YarrGenerator::BacktrackDestination::setBacktrackToLabel):
(JSC::Yarr::YarrGenerator::BacktrackDestination::setBacktrackJumpList):
(JSC::Yarr::YarrGenerator::BacktrackDestination::setBacktrackSourceLabel):
(JSC::Yarr::YarrGenerator::BacktrackDestination::setDataLabel):
(JSC::Yarr::YarrGenerator::BacktrackDestination::setSubDataLabelPtr):
(JSC::Yarr::YarrGenerator::BacktrackDestination::linkToNextBacktrack):
(JSC::Yarr::YarrGenerator::BacktrackDestination::getStackOffset):
(JSC::Yarr::YarrGenerator::BacktrackDestination::getLabel):
(JSC::Yarr::YarrGenerator::BacktrackDestination::getBacktrackJumps):
(JSC::Yarr::YarrGenerator::BacktrackDestination::getDataLabel):
(JSC::Yarr::YarrGenerator::BacktrackDestination::jumpToBacktrack):
(JSC::Yarr::YarrGenerator::BacktrackDestination::linkDataLabelToHereIfExists):
(JSC::Yarr::YarrGenerator::BacktrackDestination::plantJumpToBacktrackIfExists):
(JSC::Yarr::YarrGenerator::BacktrackDestination::linkAlternativeBacktracks):
(JSC::Yarr::YarrGenerator::BacktrackDestination::linkAlternativeBacktracksTo):
(JSC::Yarr::YarrGenerator::TermGenerationState::TermGenerationState):
(JSC::Yarr::YarrGenerator::TermGenerationState::resetAlternative):
(JSC::Yarr::YarrGenerator::TermGenerationState::alternativeValid):
(JSC::Yarr::YarrGenerator::TermGenerationState::nextAlternative):
(JSC::Yarr::YarrGenerator::TermGenerationState::alternative):
(JSC::Yarr::YarrGenerator::TermGenerationState::isLastAlternative):
(JSC::Yarr::YarrGenerator::TermGenerationState::resetTerm):
(JSC::Yarr::YarrGenerator::TermGenerationState::termValid):
(JSC::Yarr::YarrGenerator::TermGenerationState::nextTerm):
(JSC::Yarr::YarrGenerator::TermGenerationState::term):
(JSC::Yarr::YarrGenerator::TermGenerationState::isLastTerm):
(JSC::Yarr::YarrGenerator::TermGenerationState::getSubParenNum):
(JSC::Yarr::YarrGenerator::TermGenerationState::isMainDisjunction):
(JSC::Yarr::YarrGenerator::TermGenerationState::setParenthesesTail):
(JSC::Yarr::YarrGenerator::TermGenerationState::getParenthesesTail):
(JSC::Yarr::YarrGenerator::TermGenerationState::lookaheadTerm):
(JSC::Yarr::YarrGenerator::TermGenerationState::isSinglePatternCharacterLookaheadTerm):
(JSC::Yarr::YarrGenerator::TermGenerationState::inputOffset):
(JSC::Yarr::YarrGenerator::TermGenerationState::clearBacktrack):
(JSC::Yarr::YarrGenerator::TermGenerationState::jumpToBacktrack):
(JSC::Yarr::YarrGenerator::TermGenerationState::plantJumpToBacktrackIfExists):
(JSC::Yarr::YarrGenerator::TermGenerationState::linkDataLabelToBacktrackIfExists):
(JSC::Yarr::YarrGenerator::TermGenerationState::addBacktrackJump):
(JSC::Yarr::YarrGenerator::TermGenerationState::setBacktrackDataLabel):
(JSC::Yarr::YarrGenerator::TermGenerationState::setBackTrackStackOffset):
(JSC::Yarr::YarrGenerator::TermGenerationState::setBacktrackLabel):
(JSC::Yarr::YarrGenerator::TermGenerationState::linkAlternativeBacktracks):
(JSC::Yarr::YarrGenerator::TermGenerationState::linkAlternativeBacktracksTo):
(JSC::Yarr::YarrGenerator::TermGenerationState::setBacktrackLink):
(JSC::Yarr::YarrGenerator::TermGenerationState::chainBacktracks):
(JSC::Yarr::YarrGenerator::TermGenerationState::chainBacktrackJumps):
(JSC::Yarr::YarrGenerator::TermGenerationState::getBacktrackDestination):
(JSC::Yarr::YarrGenerator::TermGenerationState::propagateBacktrackingFrom):
(JSC::Yarr::YarrGenerator::ParenthesesTail::ParenthesesTail):
(JSC::Yarr::YarrGenerator::ParenthesesTail::processBacktracks):
(JSC::Yarr::YarrGenerator::ParenthesesTail::setNextIteration):
(JSC::Yarr::YarrGenerator::ParenthesesTail::addAfterParenJump):
(JSC::Yarr::YarrGenerator::ParenthesesTail::generateCode):
(JSC::Yarr::YarrGenerator::generateAssertionBOL):
(JSC::Yarr::YarrGenerator::generateAssertionEOL):
(JSC::Yarr::YarrGenerator::matchAssertionWordchar):
(JSC::Yarr::YarrGenerator::generateAssertionWordBoundary):
(JSC::Yarr::YarrGenerator::generatePatternCharacterSingle):
(JSC::Yarr::YarrGenerator::generatePatternCharacterPair):
(JSC::Yarr::YarrGenerator::generatePatternCharacterFixed):
(JSC::Yarr::YarrGenerator::generatePatternCharacterGreedy):
(JSC::Yarr::YarrGenerator::generatePatternCharacterNonGreedy):
(JSC::Yarr::YarrGenerator::generateCharacterClassSingle):
(JSC::Yarr::YarrGenerator::generateCharacterClassFixed):
(JSC::Yarr::YarrGenerator::generateCharacterClassGreedy):
(JSC::Yarr::YarrGenerator::generateCharacterClassNonGreedy):
(JSC::Yarr::YarrGenerator::generateParenthesesDisjunction):
(JSC::Yarr::YarrGenerator::generateParenthesesSingle):
(JSC::Yarr::YarrGenerator::generateParenthesesGreedyNoBacktrack):
(JSC::Yarr::YarrGenerator::generateParentheticalAssertion):
(JSC::Yarr::YarrGenerator::generateTerm):
(JSC::Yarr::YarrGenerator::generateDisjunction):
(JSC::Yarr::YarrGenerator::generateEnter):
(JSC::Yarr::YarrGenerator::generateReturn):
(JSC::Yarr::YarrGenerator::YarrGenerator):
(JSC::Yarr::YarrGenerator::generate):
(JSC::Yarr::YarrGenerator::compile):
(JSC::Yarr::jitCompile):

  • yarr/YarrJIT.h: Renamed from Source/JavaScriptCore/yarr/RegexJIT.h.

(JSC::Yarr::YarrCodeBlock::YarrCodeBlock):
(JSC::Yarr::YarrCodeBlock::~YarrCodeBlock):
(JSC::Yarr::YarrCodeBlock::setFallBack):
(JSC::Yarr::YarrCodeBlock::isFallBack):
(JSC::Yarr::YarrCodeBlock::set):
(JSC::Yarr::YarrCodeBlock::execute):
(JSC::Yarr::YarrCodeBlock::getAddr):
(JSC::Yarr::execute):

  • yarr/YarrParser.h: Renamed from Source/JavaScriptCore/yarr/RegexParser.h.

(JSC::Yarr::Parser::CharacterClassParserDelegate::CharacterClassParserDelegate):
(JSC::Yarr::Parser::CharacterClassParserDelegate::begin):
(JSC::Yarr::Parser::CharacterClassParserDelegate::atomPatternCharacter):
(JSC::Yarr::Parser::CharacterClassParserDelegate::atomBuiltInCharacterClass):
(JSC::Yarr::Parser::CharacterClassParserDelegate::end):
(JSC::Yarr::Parser::CharacterClassParserDelegate::assertionWordBoundary):
(JSC::Yarr::Parser::CharacterClassParserDelegate::atomBackReference):
(JSC::Yarr::Parser::Parser):
(JSC::Yarr::Parser::parseEscape):
(JSC::Yarr::Parser::parseAtomEscape):
(JSC::Yarr::Parser::parseCharacterClassEscape):
(JSC::Yarr::Parser::parseCharacterClass):
(JSC::Yarr::Parser::parseParenthesesBegin):
(JSC::Yarr::Parser::parseParenthesesEnd):
(JSC::Yarr::Parser::parseQuantifier):
(JSC::Yarr::Parser::parseTokens):
(JSC::Yarr::Parser::parse):
(JSC::Yarr::Parser::saveState):
(JSC::Yarr::Parser::restoreState):
(JSC::Yarr::Parser::atEndOfPattern):
(JSC::Yarr::Parser::peek):
(JSC::Yarr::Parser::peekIsDigit):
(JSC::Yarr::Parser::peekDigit):
(JSC::Yarr::Parser::consume):
(JSC::Yarr::Parser::consumeDigit):
(JSC::Yarr::Parser::consumeNumber):
(JSC::Yarr::Parser::consumeOctal):
(JSC::Yarr::Parser::tryConsume):
(JSC::Yarr::Parser::tryConsumeHex):
(JSC::Yarr::parse):

  • yarr/YarrPattern.cpp: Renamed from Source/JavaScriptCore/yarr/RegexPattern.cpp.

(JSC::Yarr::CharacterClassConstructor::CharacterClassConstructor):
(JSC::Yarr::CharacterClassConstructor::reset):
(JSC::Yarr::CharacterClassConstructor::append):
(JSC::Yarr::CharacterClassConstructor::putChar):
(JSC::Yarr::CharacterClassConstructor::isUnicodeUpper):
(JSC::Yarr::CharacterClassConstructor::isUnicodeLower):
(JSC::Yarr::CharacterClassConstructor::putRange):
(JSC::Yarr::CharacterClassConstructor::charClass):
(JSC::Yarr::CharacterClassConstructor::addSorted):
(JSC::Yarr::CharacterClassConstructor::addSortedRange):
(JSC::Yarr::BeginCharHelper::BeginCharHelper):
(JSC::Yarr::BeginCharHelper::addBeginChar):
(JSC::Yarr::BeginCharHelper::merge):
(JSC::Yarr::BeginCharHelper::addCharacter):
(JSC::Yarr::BeginCharHelper::linkHotTerms):
(JSC::Yarr::YarrPatternConstructor::YarrPatternConstructor):
(JSC::Yarr::YarrPatternConstructor::~YarrPatternConstructor):
(JSC::Yarr::YarrPatternConstructor::reset):
(JSC::Yarr::YarrPatternConstructor::assertionBOL):
(JSC::Yarr::YarrPatternConstructor::assertionEOL):
(JSC::Yarr::YarrPatternConstructor::assertionWordBoundary):
(JSC::Yarr::YarrPatternConstructor::atomPatternCharacter):
(JSC::Yarr::YarrPatternConstructor::atomBuiltInCharacterClass):
(JSC::Yarr::YarrPatternConstructor::atomCharacterClassBegin):
(JSC::Yarr::YarrPatternConstructor::atomCharacterClassAtom):
(JSC::Yarr::YarrPatternConstructor::atomCharacterClassRange):
(JSC::Yarr::YarrPatternConstructor::atomCharacterClassBuiltIn):
(JSC::Yarr::YarrPatternConstructor::atomCharacterClassEnd):
(JSC::Yarr::YarrPatternConstructor::atomParenthesesSubpatternBegin):
(JSC::Yarr::YarrPatternConstructor::atomParentheticalAssertionBegin):
(JSC::Yarr::YarrPatternConstructor::atomParenthesesEnd):
(JSC::Yarr::YarrPatternConstructor::atomBackReference):
(JSC::Yarr::YarrPatternConstructor::copyDisjunction):
(JSC::Yarr::YarrPatternConstructor::copyTerm):
(JSC::Yarr::YarrPatternConstructor::quantifyAtom):
(JSC::Yarr::YarrPatternConstructor::disjunction):
(JSC::Yarr::YarrPatternConstructor::regexBegin):
(JSC::Yarr::YarrPatternConstructor::regexEnd):
(JSC::Yarr::YarrPatternConstructor::regexError):
(JSC::Yarr::YarrPatternConstructor::setupAlternativeOffsets):
(JSC::Yarr::YarrPatternConstructor::setupDisjunctionOffsets):
(JSC::Yarr::YarrPatternConstructor::setupOffsets):
(JSC::Yarr::YarrPatternConstructor::checkForTerminalParentheses):
(JSC::Yarr::YarrPatternConstructor::optimizeBOL):
(JSC::Yarr::YarrPatternConstructor::addBeginTerm):
(JSC::Yarr::YarrPatternConstructor::setupDisjunctionBeginTerms):
(JSC::Yarr::YarrPatternConstructor::setupAlternativeBeginTerms):
(JSC::Yarr::YarrPatternConstructor::setupBeginChars):
(JSC::Yarr::compile):
(JSC::Yarr::YarrPattern::YarrPattern):

  • yarr/YarrPattern.h: Renamed from Source/JavaScriptCore/yarr/RegexPattern.h.

(JSC::Yarr::CharacterRange::CharacterRange):
(JSC::Yarr::CharacterClassTable::create):
(JSC::Yarr::CharacterClassTable::CharacterClassTable):
(JSC::Yarr::CharacterClass::CharacterClass):
(JSC::Yarr::PatternTerm::PatternTerm):
(JSC::Yarr::PatternTerm::ForwardReference):
(JSC::Yarr::PatternTerm::BOL):
(JSC::Yarr::PatternTerm::EOL):
(JSC::Yarr::PatternTerm::WordBoundary):
(JSC::Yarr::PatternTerm::invert):
(JSC::Yarr::PatternTerm::capture):
(JSC::Yarr::PatternTerm::quantify):
(JSC::Yarr::PatternAlternative::PatternAlternative):
(JSC::Yarr::PatternAlternative::lastTerm):
(JSC::Yarr::PatternAlternative::removeLastTerm):
(JSC::Yarr::PatternAlternative::setOnceThrough):
(JSC::Yarr::PatternAlternative::onceThrough):
(JSC::Yarr::PatternDisjunction::PatternDisjunction):
(JSC::Yarr::PatternDisjunction::~PatternDisjunction):
(JSC::Yarr::PatternDisjunction::addNewAlternative):
(JSC::Yarr::TermChain::TermChain):
(JSC::Yarr::BeginChar::BeginChar):
(JSC::Yarr::YarrPattern::~YarrPattern):
(JSC::Yarr::YarrPattern::reset):
(JSC::Yarr::YarrPattern::containsIllegalBackReference):
(JSC::Yarr::YarrPattern::newlineCharacterClass):
(JSC::Yarr::YarrPattern::digitsCharacterClass):
(JSC::Yarr::YarrPattern::spacesCharacterClass):
(JSC::Yarr::YarrPattern::wordcharCharacterClass):
(JSC::Yarr::YarrPattern::nondigitsCharacterClass):
(JSC::Yarr::YarrPattern::nonspacesCharacterClass):
(JSC::Yarr::YarrPattern::nonwordcharCharacterClass):

1:07 PM Changeset in webkit [75420] by inferno@chromium.org
  • 1 edit in branches/chromium/597/WebCore/svg/SVGLength.cpp

Merge 75026 - Merge 74788

BUG=68062
Review URL: http://codereview.chromium.org/6117004

1:03 PM Changeset in webkit [75419] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/597

Merge 75090 - Merge 75082

BUG=68439
Review URL: http://codereview.chromium.org/6192002

1:01 PM Changeset in webkit [75418] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-01-10 Maciej Stachowiak <mjs@apple.com>

Reviewed by Anders Carlsson.

Skip layout tests in WebKit2 that fail for an obvious (missing DRT API) reason
https://bugs.webkit.org/show_bug.cgi?id=52166

  • platform/mac-wk2/Skipped:
1:01 PM Changeset in webkit [75417] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/597

Merge 74982 - Merge 74781

BUG=66986
Review URL: http://codereview.chromium.org/6094016

12:59 PM Changeset in webkit [75416] by inferno@chromium.org
  • 3 edits
    2 copies in branches/chromium/597

Merge 75007 - Merge 73927

BUG=66560
Review URL: http://codereview.chromium.org/6150004

12:55 PM Changeset in webkit [75415] by inferno@chromium.org
  • 1 edit
    4 copies in branches/chromium/597

Merge 74981 - Merge 74743

BUG=65796
Review URL: http://codereview.chromium.org/6097012

12:45 PM Changeset in webkit [75414] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix.

  • parser/SyntaxChecker.h:
12:39 PM Changeset in webkit [75413] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-10 Dave Tapuska <dtapuska@rim.com>

Reviewed by Gavin Barraclough.

Add CTI ASM versions for RVCT ARM THUMB2 mode.

https://bugs.webkit.org/show_bug.cgi?id=52154

  • jit/JITStubs.cpp: (JSC::ctiTrampoline): (JSC::ctiVMThrowTrampoline): (JSC::ctiOpThrowNotCaught):
12:35 PM Changeset in webkit [75412] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Qt build fix.

12:30 PM Changeset in webkit [75411] by benjamin.poulain@nokia.com
  • 4 edits in trunk

2011-01-10 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Navigator.cookiesEnabled return true for Qt even if there is no cookie jar
https://bugs.webkit.org/show_bug.cgi?id=52081

Test for the availability of cookie jar to return if cookies are enabled or not.

  • platform/qt/CookieJarQt.cpp: (WebCore::cookiesEnabled):

2011-01-10 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Navigator.cookiesEnabled return true for Qt even if there is no cookie jar
https://bugs.webkit.org/show_bug.cgi?id=52081

Add an autotest for checking the result of Navigator.cookiesEnabled depending
on the status of the cookie jar.

  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::navigatorCookieEnabled):
12:29 PM Changeset in webkit [75410] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-01-10 W. James MacLean <wjmaclean@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Enable reuse of RenderSurface for drawing.
https://bugs.webkit.org/show_bug.cgi?id=51928

Modifies RenderSurfaceChromium::prepareContentsTexture to avoid trying to 'reserve' a texture
that is already reserved, should an attempt be made to re-select a previously drawn render surface
in order to continue drawing to it. This use case appears when compositing into an offscreen texture.

Covered by existing test (compositing/geometry/fixed-position.html) when offscreen compositing enabled.

  • platform/graphics/chromium/LayerTexture.h: (WebCore::LayerTexture::isReserved):
  • platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::prepareContentsTexture):
  • platform/graphics/chromium/TextureManager.cpp: (WebCore::TextureManager::isProtected):
  • platform/graphics/chromium/TextureManager.h:
12:22 PM Changeset in webkit [75409] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

2011-01-10 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Port combo box painting to GtkStyleContext
https://bugs.webkit.org/show_bug.cgi?id=51828

Use GtkStyleContext API to paint combo boxes when building with
GTK+ 3.x. Method paintButton() has been factored out and the new
static method renderButton() is used by both paintButton() and
paintMenuList().

No new tests. This should not change functionality.

  • platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::adjustRepaintRect): (WebCore::renderButton): (WebCore::RenderThemeGtk::paintButton): (WebCore::getComboBoxMetrics): (WebCore::RenderThemeGtk::popupInternalPaddingLeft): (WebCore::RenderThemeGtk::popupInternalPaddingRight): (WebCore::RenderThemeGtk::popupInternalPaddingTop): (WebCore::RenderThemeGtk::popupInternalPaddingBottom): (WebCore::RenderThemeGtk::paintMenuList):
12:20 PM QtWebKitRelease22 edited by Ademar Reis
(diff)
12:20 PM Changeset in webkit [75408] by barraclough@apple.com
  • 91 edits
    2 adds in trunk

Bug 52079 - Syntax errors should be early errors.

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

From chapter 16 the spec:

An implementation must report most errors at the time the relevant ECMAScript language construct is
evaluated. An early error is an error that can be detected and reported prior to the evaluation of
any construct in the Program containing the error. An implementation must report early errors in a
Program prior to the first evaluation of that Program. Early errors in eval code are reported at
the time eval is called but prior to evaluation of any construct within the eval code. All errors
that are not early errors are runtime errors.

An implementation must treat any instance of the following kinds of errors as an early error:

  • Any syntax error."

Added new files.

  • bytecode/CodeBlock.cpp:

Removed op_throw_syntax_error.

  • bytecode/Opcode.h:

Removed op_throw_syntax_error.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate):

If m_expressionTooDeep then throw a runtime error.

(JSC::BytecodeGenerator::BytecodeGenerator):

Initialize m_expressionTooDeep.

(JSC::BytecodeGenerator::emitThrowExpressionTooDeepException):

Sets m_expressionTooDeep.

  • bytecompiler/BytecodeGenerator.h:

Added m_expressionTooDeep, removed emitThrowSyntaxError.

  • bytecompiler/NodesCodegen.cpp:

(JSC::RegExpNode::emitBytecode):
(JSC::ContinueNode::emitBytecode):
(JSC::BreakNode::emitBytecode):
(JSC::ReturnNode::emitBytecode):
(JSC::LabelNode::emitBytecode):

Conditions that threw syntax error are now handled during parsing;
during bytecompilation these are now just ASSERTs.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

  • jit/JIT.h:
  • jit/JITOpcodes.cpp:
  • jit/JITOpcodes32_64.cpp:
  • jit/JITStubs.cpp:
  • jit/JITStubs.h:

Removed op_throw_syntax_error.

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createRegExp):

Renamed; added syntax check.

  • parser/JSParser.cpp:

(JSC::JSParser::breakIsValid):
(JSC::JSParser::hasLabel):
(JSC::JSParser::Scope::Scope):
(JSC::JSParser::Scope::setIsFunction):
(JSC::JSParser::Scope::isFunctionBoundary):
(JSC::JSParser::ScopeRef::hasContainingScope):
(JSC::JSParser::ScopeRef::containingScope):
(JSC::JSParser::AutoPopScopeRef::AutoPopScopeRef):
(JSC::JSParser::AutoPopScopeRef::~AutoPopScopeRef):
(JSC::JSParser::AutoPopScopeRef::setPopped):
(JSC::JSParser::popScopeInternal):
(JSC::JSParser::popScope):
(JSC::jsParse):
(JSC::JSParser::JSParser):
(JSC::JSParser::parseProgram):
(JSC::JSParser::parseBreakStatement):
(JSC::JSParser::parseContinueStatement):
(JSC::JSParser::parseReturnStatement):
(JSC::JSParser::parseTryStatement):
(JSC::JSParser::parseFunctionInfo):
(JSC::JSParser::parseExpressionOrLabelStatement):
(JSC::JSParser::parsePrimaryExpression):

  • parser/JSParser.h:
  • parser/Nodes.h:
  • parser/Parser.cpp:

(JSC::Parser::parse):

  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createRegExp):

Renamed; added syntax check.

  • runtime/ExceptionHelpers.cpp:

(JSC::createOutOfMemoryError):
(JSC::throwOutOfMemoryError):

  • runtime/ExceptionHelpers.h:

Broke out createOutOfMemoryError.

  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

Add check for exception after bytecode generation.

  • runtime/RegExpConstructor.cpp:

(JSC::constructRegExp):

  • runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncCompile):

RegExp error prefixes not included in error string.

  • yarr/RegexParser.h:

(JSC::Yarr::Parser::parse):

Removed regexBegin/regexEnd/regexError.

  • yarr/RegexPattern.cpp:

(JSC::Yarr::RegexPatternConstructor::regexBegin):

Removed regexEnd/regexError.

(JSC::Yarr::compileRegex):

Add call to regexBegin (no longer called from the parser).

  • yarr/YarrSyntaxChecker.cpp: Added.

(JSC::Yarr::SyntaxChecker::assertionBOL):
(JSC::Yarr::SyntaxChecker::assertionEOL):
(JSC::Yarr::SyntaxChecker::assertionWordBoundary):
(JSC::Yarr::SyntaxChecker::atomPatternCharacter):
(JSC::Yarr::SyntaxChecker::atomBuiltInCharacterClass):
(JSC::Yarr::SyntaxChecker::atomCharacterClassBegin):
(JSC::Yarr::SyntaxChecker::atomCharacterClassAtom):
(JSC::Yarr::SyntaxChecker::atomCharacterClassRange):
(JSC::Yarr::SyntaxChecker::atomCharacterClassBuiltIn):
(JSC::Yarr::SyntaxChecker::atomCharacterClassEnd):
(JSC::Yarr::SyntaxChecker::atomParenthesesSubpatternBegin):
(JSC::Yarr::SyntaxChecker::atomParentheticalAssertionBegin):
(JSC::Yarr::SyntaxChecker::atomParenthesesEnd):
(JSC::Yarr::SyntaxChecker::atomBackReference):
(JSC::Yarr::SyntaxChecker::quantifyAtom):
(JSC::Yarr::SyntaxChecker::disjunction):
(JSC::Yarr::checkSyntax):

  • yarr/YarrSyntaxChecker.h: Added.

Check RegExp syntax.

LayoutTests:

Fix syntax errors in layout tests, and update expected results.

  • editing/selection/select-crash-001.html:
  • editing/selection/select-crash-002.html:
  • fast/canvas/webgl/renderbuffer-initialization.html:
  • fast/forms/25153.html:
  • fast/forms/textfield-drag-into-disabled.html:
  • fast/js/exception-codegen-crash-expected.txt:
  • fast/js/exception-codegen-crash.html:
  • fast/js/kde/parse-expected.txt:
  • fast/js/kde/script-tests/parse.js:
  • fast/js/large-expressions-expected.txt:
  • fast/js/named-function-expression-expected.txt:
  • fast/js/parser-syntax-check-expected.txt:
  • fast/js/script-tests/large-expressions.js:
  • fast/js/script-tests/named-function-expression.js:
  • fast/js/script-tests/parser-syntax-check.js:
  • fast/js/sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A11.1_T3-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A11_T3-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A12.1_T3-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A12_T3-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A1_T1-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A1_T2-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A1_T3-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A1_T4-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A5_T1-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A5_T2-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A5_T3-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A6-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A8_T1-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A8_T2-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A1_T1-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A1_T2-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A1_T3-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A1_T4-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A5_T1-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A5_T2-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A5_T3-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A6-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A8_T1-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A8_T2-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T1-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T10-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T2-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T3-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T4-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T5-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T6-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T7-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T8-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T9-expected.txt:
  • http/tests/security/isolatedWorld/events.html:
  • http/tests/security/isolatedWorld/userGestureEvents.html:
  • svg/custom/resources/use-instanceRoot-event-listeners.js:
  • svg/custom/rgbcolor-syntax.svg:
  • svg/custom/use-instanceRoot-modifications.svg:
  • svg/custom/use-property-changes-through-svg-dom.svg:
  • webarchive/adopt-attribute-styled-body-webarchive-expected.webarchive:
  • webarchive/resources/adopt-attribute-styled-body-iframe.html:
12:14 PM Changeset in webkit [75407] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-10 Tony Chang <tony@chromium.org>

Unreviewed, remove duplicate test expectation for gif-loop-count.

  • platform/chromium/test_expectations.txt:
12:14 PM Changeset in webkit [75406] by Adam Roben
  • 2 edits in trunk/Tools

Roll out r75392

It isn't needed now that r75289 has been rolled out.

  • Scripts/run-javascriptcore-tests:
12:13 PM Changeset in webkit [75405] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Roll out r75289

It was causing assertion failures. See <http://webkit.org/b/52156>.

  • wtf/StackBounds.cpp:

(WTF::StackBounds::initialize):

12:07 PM Changeset in webkit [75404] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit2

2011-01-10 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Eric Seidel.

Support for ARM's RVCT(ARMCC) compiler in import/export directives
https://bugs.webkit.org/show_bug.cgi?id=52146

  • Shared/API/c/WKBase.h:
12:05 PM Changeset in webkit [75403] by gyuyoung.kim@samsung.com
  • 2 edits in trunk

2011-01-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Eric Seidel.

[EFL] Enable JIT for WebKit EFL
https://bugs.webkit.org/show_bug.cgi?id=52140

Enable JIT option for WebKit EFL. Enabled JIT's JS performance is
3 ~ 6 times faster than before.

  • Source/cmake/OptionsEfl.cmake:
12:04 PM Changeset in webkit [75402] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed rolling out r75371, because it didn't fix Qt buildbot.

  • platform/qt/Skipped:
12:00 PM Changeset in webkit [75401] by mjs@apple.com
  • 2 edits in trunk/Tools

2011-01-10 Maciej Stachowiak <mjs@apple.com>

Reviewed by Anders Carlsson.

WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
https://bugs.webkit.org/show_bug.cgi?id=52160

  • WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout. Anything that can make runUntil() conditions turn true will happen on a run loop cycle anyway.
11:58 AM Changeset in webkit [75400] by evan@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-10 Evan Martin <evan@chromium.org>

Reviewed by Tony Chang.

[chromium] simplify complex glyph positioning code
https://bugs.webkit.org/show_bug.cgi?id=52159

Before, we had roughly same code duplicated for RTL and LTR.
Now, use the same code for both directions by being careful about
flipping signs where appropriate.

  • platform/graphics/chromium/ComplexTextControllerLinux.cpp: (WebCore::ComplexTextController::shapeGlyphs): (WebCore::ComplexTextController::setGlyphXPositions):
11:31 AM Changeset in webkit [75399] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Fix the build.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

11:31 AM Changeset in webkit [75398] by tony@chromium.org
  • 5 edits
    2 deletes in trunk

2011-01-10 Tony Chang <tony@chromium.org>

Reviewed by Mihai Parparita.

[chromium] fix for animated gif layout tests
https://bugs.webkit.org/show_bug.cgi?id=52008

Remove incorrect baselines.

  • platform/chromium-win/fast/backgrounds/animated-gif-as-background-expected.checksum: Removed.
  • platform/chromium-win/fast/backgrounds/animated-gif-as-background-expected.png: Removed.
  • platform/chromium/test_expectations.txt:

2011-01-10 Tony Chang <tony@chromium.org>

Reviewed by Mihai Parparita.

[chromium] fix for animated gif layout tests
https://bugs.webkit.org/show_bug.cgi?id=52008

  • DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect

to trigger gif animations.

(WebViewHostPaintTask::WebViewHostPaintTask):
(WebViewHostPaintTask::runIfValid):
(WebViewHost::updatePaintRect):

  • DumpRenderTree/chromium/WebViewHost.h: (WebViewHost::taskList):
11:29 AM Changeset in webkit [75397] by alex
  • 7 edits in trunk

2011-01-10 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fix gtk2 compilation for master
https://bugs.webkit.org/show_bug.cgi?id=51885

  • platform/gtk/GtkVersioning.h: Replaced the 2.24.0 check with 2.23.0 to avoid using the old symbols in the 2.23 releases. Added support for gdk_pixmap_get_size before the 2.23.4.
  • platform/gtk/WidgetRenderingContextGtk2.cpp: (WebCore::WidgetRenderingContext::WidgetRenderingContext): Replaced the old gdk_drawable_get_size with gdk_pixmap_get_size.

2011-01-10 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fix gtk2 compilation for master
https://bugs.webkit.org/show_bug.cgi?id=51885

  • DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: (createBitmapContextFromWebView): Replaced the old gdk_drawable_get_size with gdk_pixmap_get_size.

2011-01-10 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fix gtk2 compilation for master
https://bugs.webkit.org/show_bug.cgi?id=51885

  • webkit/webkitsoupauthdialog.c: (show_auth_dialog): Removed the call to gtk_dialog_set_has_separator API to remove a warning.
11:22 AM Changeset in webkit [75396] by Patrick Gansterer
  • 2 edits in trunk/Tools

2011-01-10 Patrick Gansterer <Patrick Gansterer>

Reviewed by Laszlo Gombos.

[WINCE] Reenable NPAPI after r75203
https://bugs.webkit.org/show_bug.cgi?id=52109

Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
it with !isEfl(), because EFL port does not support NPAPI (yet).

  • Scripts/build-webkit:
11:20 AM Changeset in webkit [75395] by weinig@apple.com
  • 22 edits
    17 adds in trunk/WebKit2

Make Geolocation features work in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=52078

Reviewed by Anders Carlsson.

Step 1 - Add enough support to get position data from a provider.
This does not include permission support.

  • Platform/CoreIPC/HandleMessage.h:

Add #include of Arguments.h for CoreIPC::In and Out definitions.

  • Platform/CoreIPC/MessageID.h:

Add new message types.

  • Shared/API/c/WKBase.h:
  • Shared/APIObject.h:

Add new API types.

  • Shared/WebGeolocationPosition.cpp: Added.
  • Shared/WebGeolocationPosition.h: Added.

Internal position representation.

  • UIProcess/API/C/WKAPICast.h:

Add casts for new API types.

  • UIProcess/API/C/WKContext.cpp:
  • UIProcess/API/C/WKContext.h:
  • UIProcess/API/C/WKGeolocationManager.cpp: Added.
  • UIProcess/API/C/WKGeolocationManager.h: Added.
  • UIProcess/API/C/WKGeolocationPosition.cpp: Added.
  • UIProcess/API/C/WKGeolocationPosition.h: Added.
  • UIProcess/API/C/WebKit2.h:

Add API to provide and control geolocation data.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::processDidClose):
(WebKit::WebContext::didReceiveMessage):

  • UIProcess/WebContext.h:

(WebKit::WebContext::geolocationManagerProxy):

  • UIProcess/WebGeolocationManagerProxy.cpp: Added.

(WebKit::WebGeolocationManagerProxy::create):
(WebKit::WebGeolocationManagerProxy::WebGeolocationManagerProxy):
(WebKit::WebGeolocationManagerProxy::~WebGeolocationManagerProxy):
(WebKit::WebGeolocationManagerProxy::invalidate):
(WebKit::WebGeolocationManagerProxy::initializeProvider):
(WebKit::WebGeolocationManagerProxy::providerDidChangePosition):
(WebKit::WebGeolocationManagerProxy::providerDidFailToDeterminePosition):
(WebKit::WebGeolocationManagerProxy::didReceiveMessage):
(WebKit::WebGeolocationManagerProxy::startUpdating):
(WebKit::WebGeolocationManagerProxy::stopUpdating):

  • UIProcess/WebGeolocationManagerProxy.h: Added.

(WebKit::WebGeolocationManagerProxy::clearContext):
(WebKit::WebGeolocationManagerProxy::type):

  • UIProcess/WebGeolocationManagerProxy.messages.in: Added.
  • UIProcess/WebGeolocationProvider.cpp: Added.

(WebKit::WebGeolocationProvider::startUpdating):
(WebKit::WebGeolocationProvider::stopUpdating):

  • UIProcess/WebGeolocationProvider.h: Added.
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveMessage):

  • WebProcess/Geolocation: Added.
  • WebProcess/Geolocation/WebGeolocationManager.cpp: Added.

(WebKit::WebGeolocationManager::WebGeolocationManager):
(WebKit::WebGeolocationManager::~WebGeolocationManager):
(WebKit::WebGeolocationManager::didReceiveMessage):
(WebKit::WebGeolocationManager::registerWebPage):
(WebKit::WebGeolocationManager::unregisterWebPage):
(WebKit::WebGeolocationManager::didChangePosition):
(WebKit::WebGeolocationManager::didFailToDeterminePosition):

  • WebProcess/Geolocation/WebGeolocationManager.h: Added.
  • WebProcess/Geolocation/WebGeolocationManager.messages.in: Added.
  • WebProcess/WebCoreSupport/WebGeolocationClient.cpp: Added.

(WebKit::WebGeolocationClient::geolocationDestroyed):
(WebKit::WebGeolocationClient::startUpdating):
(WebKit::WebGeolocationClient::stopUpdating):
(WebKit::WebGeolocationClient::setEnableHighAccuracy):
(WebKit::WebGeolocationClient::lastPosition):
(WebKit::WebGeolocationClient::requestPermission):
(WebKit::WebGeolocationClient::cancelPermissionRequest):

  • WebProcess/WebCoreSupport/WebGeolocationClient.h: Added.

(WebKit::WebGeolocationClient::WebGeolocationClient):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::didReceiveMessage):

  • WebProcess/WebProcess.h:

(WebKit::WebProcess::geolocationManager):
Pipe geolocation positions/errors from the UIProcess to the WebProcess.

  • DerivedSources.make:
  • DerivedSources.pro:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Common.vsprops:
    • win/WebKit2Generated.make:

Add new files.

11:17 AM Changeset in webkit [75394] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-10 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; build fix for r75385.

  • rendering/mathml/RenderMathMLFraction.cpp: (WebCore::RenderMathMLFraction::paint):
11:15 AM Changeset in webkit [75393] by jorlow@chromium.org
  • 5 edits
    3 deletes in trunk

2011-01-10 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r75341.
http://trac.webkit.org/changeset/75341
https://bugs.webkit.org/show_bug.cgi?id=52157

Regressions on several pixel tests (Requested by jorlow on
#webkit).

  • fast/canvas/canvas-fillPath-gradient-shadow-expected.txt: Removed.
  • fast/canvas/canvas-fillPath-gradient-shadow.html: Removed.
  • fast/canvas/script-tests/canvas-fillPath-gradient-shadow.js: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/qt/Skipped:

2011-01-10 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r75341.
http://trac.webkit.org/changeset/75341
https://bugs.webkit.org/show_bug.cgi?id=52157

Regressions on several pixel tests (Requested by jorlow on
#webkit).

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillPath):
11:10 AM Changeset in webkit [75392] by Adam Roben
  • 2 edits in trunk/Tools

Skip some asserting JS tests

See <http://webkit.org/b/52156>.

  • Scripts/run-javascriptcore-tests:
11:10 AM Changeset in webkit [75391] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

2011-01-10 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Port check and radio button painting to GtkStyleContext
https://bugs.webkit.org/show_bug.cgi?id=51815

Use GtkStyleContext API to paint check and radio buttons when
building with GTK+ 3.x.

No new tests. This should not change functionality.

  • platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::adjustRepaintRect): (WebCore::setToggleSize): (WebCore::paintToggle): (WebCore::RenderThemeGtk::setCheckboxSize): (WebCore::RenderThemeGtk::paintCheckbox): (WebCore::RenderThemeGtk::setRadioSize): (WebCore::RenderThemeGtk::paintRadio):
10:53 AM Changeset in webkit [75390] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] fast/text/emphasis-avoid-ruby.html fails, because FontQt doesn’t implement
Font::emphasisMark{Ascent,Descent,Height} nor emphasis mark drawing.

https://bugs.webkit.org/show_bug.cgi?id=52155

  • platform/qt/Skipped: Add fast/text/emphasis-avoid-ruby.html until fix.
10:52 AM Changeset in webkit [75389] by Martin Robinson
  • 2 edits in trunk/Tools

2011-01-10 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] build-webkit disable Blob support via arguments passed to automake
https://bugs.webkit.org/show_bug.cgi?id=52097

  • Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via build-webkit.
10:45 AM Changeset in webkit [75388] by mihaip@chromium.org
  • 6 edits
    2 copies
    2 adds in trunk/LayoutTests

2011-01-10 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium test expectations update.

Rebaseline two tests in fast/forms for chromium-mac. Even after the
scrollbar switch they need Chromium-specific results since search and
file upload control rendering is different from the mac port's.

Adds both Leopard (chromium-mac-leopard) and Snow Leopard (chromium-mac)
baselines.

  • platform/chromium-mac-leopard/fast/forms/file-input-direction-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/file-input-direction-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/file-input-direction-expected.png.
  • platform/chromium-mac-leopard/fast/forms/search-transformed-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/search-transformed-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/search-transformed-expected.png.
  • platform/chromium-mac/fast/forms/file-input-direction-expected.checksum:
  • platform/chromium-mac/fast/forms/file-input-direction-expected.png:
  • platform/chromium-mac/fast/forms/search-transformed-expected.checksum:
  • platform/chromium-mac/fast/forms/search-transformed-expected.png:
  • platform/chromium/test_expectations.txt:
10:42 AM Changeset in webkit [75387] by Csaba Osztrogonác
  • 1 edit
    1 copy in trunk/LayoutTests

Unreviewed. Add Qt specific expected file.

  • platform/qt/http/tests/navigation/forward-and-cancel-expected.txt: Copied from LayoutTests/http/tests/navigation/forward-and-cancel-expected.txt.
10:35 AM Changeset in webkit [75386] by Martin Robinson
  • 2 edits in trunk

2011-01-10 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha.

Bump the WebKitGTK+ versions in preparation for development release.

  • configure.ac: Bump the library, libtool and user agent version.
10:34 AM Changeset in webkit [75385] by commit-queue@webkit.org
  • 8 edits in trunk

2011-01-10 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Updated tests and results to take into account new default fraction bar thickness.
https://bugs.webkit.org/show_bug.cgi?id=50018

  • mathml/presentation/fractions.xhtml:
  • platform/mac/mathml/presentation/fractions-expected.checksum:
  • platform/mac/mathml/presentation/fractions-expected.png:
  • platform/mac/mathml/presentation/fractions-expected.txt:

2011-01-10 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

MathML: vertical alignment & bar thickness adjustments of fractions.
https://bugs.webkit.org/show_bug.cgi?id=50018

The fraction bar thickness default value should follow the w3c MathML 3 recommendation:
http://www.w3.org/TR/MathML3/chapter3.html#presm.mfrac
The vertical alignment of the fraction bar should be more accurate, specially with operators (+,=,...).

Test: mathml/presentation/fractions.xhtml

  • rendering/mathml/RenderMathMLFraction.cpp: (WebCore::RenderMathMLFraction::RenderMathMLFraction): (WebCore::RenderMathMLFraction::updateFromElement): (WebCore::RenderMathMLFraction::layout): (WebCore::RenderMathMLFraction::paint): (WebCore::RenderMathMLFraction::baselinePosition):
  • rendering/mathml/RenderMathMLFraction.h:
10:32 AM Changeset in webkit [75384] by Antti Koivisto
  • 3 edits
    3 adds in trunk

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=52044
REGRESSION(r74807): No-store is ignored within a document

Reviewed by Alexey Proskuryakov.

Don't use cached resources with Cache-control: no-store (unless cache policy is CachePolicyHistoryBuffer).
This matches a behavior that got lost in r74807.

Test: http/tests/misc/script-no-store.html
(by Alexey Proskuryakov)

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::determineRevalidationPolicy):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=52044
REGRESSION(r74807): No-store is ignored within a document

Reviewed by Alexey Proskuryakov.

  • http/tests/misc/script-no-store-expected.txt: Added.
  • http/tests/misc/script-no-store.html: Added.
  • http/tests/misc/resources/random-no-store.php: Added.
10:14 AM Changeset in webkit [75383] by Patrick Gansterer
  • 3 edits
    1 add in trunk/Source/WebCore

2011-01-10 Patrick Gansterer <Patrick Gansterer>

Reviewed by Laszlo Gombos.

[WIN] Add ProxyServerWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=52031

Add stub implementation to fix ENABLE_NETSCAPE_PLUGIN_API on WinCE.

  • CMakeLists.txt:
  • CMakeListsWinCE.txt:
  • platform/network/win/ProxyServerWin.cpp: Added. (WebCore::proxyServersForURL):
10:09 AM Changeset in webkit [75382] by Martin Robinson
  • 2 edits in trunk/WebKit2

2011-01-10 Martin Robinson <mrobinson@igalia.com>

GTK+ build fix. Continue to fix 'make dist.'

  • GNUmakefile.am: Remove more non-existent files from the WebKit2 build.
9:56 AM Changeset in webkit [75381] by alex
  • 4 edits in trunk

2011-01-10 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[cairo] Rendering a lot of arcs on top of each other causes time
outs in some tests
https://bugs.webkit.org/show_bug.cgi?id=50869

We avoid the situation where we have to render the same arc
multiple times over itself. Now it renders just one oval and
moves to the end angle.

  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::addArc):

2011-01-10 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[cairo] Rendering a lot of arcs on top of each other causes time
outs in some tests
https://bugs.webkit.org/show_bug.cgi?id=50869

Unskip canvas-largedraws.html after improving the performance for
big angles.

  • platform/gtk/Skipped:
9:15 AM Changeset in webkit [75380] by alex
  • 2 edits in trunk/WebKit2

2011-01-10 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Remove webkit2 files that are still not added to the
repository from the makefile
https://bugs.webkit.org/show_bug.cgi?id=52145

This change is required for the release, we can add the lines
again to the makefiles with the patches adding the files.

  • GNUmakefile.am:
9:04 AM Changeset in webkit [75379] by Adam Roben
  • 2 edits in trunk/Tools

Use the same name and description for TestNetscapePlugin on Windows and Mac

Fixes <http://webkit.org/b/52151>
fast/frames/iframe-reparenting-plugins.html fails on Windows

Reviewed by Steve Falkenburg.

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied

the name and description from Mac's Info.plist.

9:00 AM Changeset in webkit [75378] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

2011-01-10 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Port text input control painting to GtkStyleContext
https://bugs.webkit.org/show_bug.cgi?id=51870

Use GtkStyleContext API to paint text input controls when building
with GTK+ 3.x.

No new tests. This should not change functionality.

  • platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::adjustRepaintRect): (WebCore::RenderThemeGtk::paintTextField):
8:41 AM Changeset in webkit [75377] by tonyg@chromium.org
  • 60 edits in trunk

2011-01-09 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Alexey Proskuryakov.

Forward declare some headers where possible
https://bugs.webkit.org/show_bug.cgi?id=52133

No new tests because no new functionality.

  • css/CSSValue.h:
  • dom/BeforeLoadEvent.h:
  • dom/Event.cpp:
  • dom/Event.h:
  • dom/StyledElement.cpp:
  • dom/StyledElement.h:
  • loader/DocumentLoader.h:
  • loader/FrameLoader.h:
  • page/Frame.h:
  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/filters/FEBlend.cpp:
  • platform/graphics/filters/FEColorMatrix.cpp:
  • platform/graphics/filters/FEComponentTransfer.cpp:
  • platform/graphics/filters/FEComposite.cpp:
  • platform/graphics/filters/FEConvolveMatrix.cpp:
  • platform/graphics/filters/FEDiffuseLighting.cpp:
  • platform/graphics/filters/FEDisplacementMap.cpp:
  • platform/graphics/filters/FEFlood.cpp:
  • platform/graphics/filters/FEGaussianBlur.cpp:
  • platform/graphics/filters/FEMerge.cpp:
  • platform/graphics/filters/FEMorphology.cpp:
  • platform/graphics/filters/FEOffset.cpp:
  • platform/graphics/filters/FESpecularLighting.cpp:
  • platform/graphics/filters/FETile.cpp:
  • platform/graphics/filters/FETurbulence.cpp:
  • platform/graphics/filters/FilterEffect.cpp:
  • platform/graphics/filters/FilterEffect.h:
  • platform/graphics/filters/SourceAlpha.cpp:
  • platform/graphics/filters/SourceGraphic.cpp:
  • svg/SVGElement.cpp:
  • svg/SVGElement.h:
  • svg/SVGFEBlendElement.cpp:
  • svg/SVGFEColorMatrixElement.cpp:
  • svg/SVGFEComponentTransferElement.cpp:
  • svg/SVGFECompositeElement.cpp:
  • svg/SVGFEConvolveMatrixElement.cpp:
  • svg/SVGFEConvolveMatrixElement.h:
  • svg/SVGFEDiffuseLightingElement.cpp:
  • svg/SVGFEDisplacementMapElement.cpp:
  • svg/SVGFEGaussianBlurElement.cpp:
  • svg/SVGFEImageElement.h:
  • svg/SVGFEMergeElement.cpp:
  • svg/SVGFEMorphologyElement.cpp:
  • svg/SVGFEOffsetElement.cpp:
  • svg/SVGFESpecularLightingElement.cpp:
  • svg/SVGFETileElement.cpp:
  • svg/SVGFETurbulenceElement.h:
  • svg/SVGFilterPrimitiveStandardAttributes.cpp:
  • svg/SVGFilterPrimitiveStandardAttributes.h:
  • svg/SVGTextContentElement.cpp:
  • svg/graphics/filters/SVGFEImage.cpp:
  • svg/graphics/filters/SVGFEImage.h:

2011-01-09 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Alexey Proskuryakov.

Forward declare some headers where possible
https://bugs.webkit.org/show_bug.cgi?id=52133

  • WebView/WebFrame.mm:
8:05 AM Changeset in webkit [75376] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Windows build fix after r75313

  • WebCore.vcproj/build-generated-files.sh: Updated for the change in

this script's path.

7:50 AM Changeset in webkit [75375] by Adam Roben
  • 2 edits in trunk/LayoutTests

Add some new tests to the Windows Skipped file

The tests are failing due to unimplemented DRT features which are
already covered by bugs.

  • platform/win/Skipped:
7:30 AM Changeset in webkit [75374] by Laszlo Gombos
  • 3 edits in trunk/Tools

2011-01-10 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

[Qt][WK2] Guard gcc-specific syntax

Non-gcc based compliers choke on the "-include"
syntax for preinclude, place guard around it.

  • WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
  • WebKitTestRunner/qt/WebKitTestRunner.pro:
7:25 AM Changeset in webkit [75373] by andreas.kling@nokia.com
  • 7 edits in trunk

2011-01-10 Andreas Kling <kling@webkit.org>

Reviewed by Simon Hausmann.

[Qt] [WK2] MiniBrowser does not load pages opened in new windows
https://bugs.webkit.org/show_bug.cgi?id=52111

When getting a createNewPage() callback from QWKPage, create the
new page with the same QWKContext as the page that is passed to
the callback.

  • MiniBrowser/qt/BrowserView.h:
  • MiniBrowser/qt/BrowserWindow.cpp: (newPageFunction): (BrowserWindow::BrowserWindow):
  • MiniBrowser/qt/BrowserWindow.h:

2011-01-10 Andreas Kling <kling@webkit.org>

Reviewed by Simon Hausmann.

[Qt] [WK2] MiniBrowser does not load pages opened in new windows
https://bugs.webkit.org/show_bug.cgi?id=52111

  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::context): Implement this method.
6:50 AM Changeset in webkit [75372] by andreas.kling@nokia.com
  • 2 edits in trunk/Tools

2011-01-10 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] MiniBrowser: Remove superfluous createNewPage() callback

BrowserView set its own useless createNewPage() callback on QWKPage.
This was immediately overridden by BrowserWindow anyway, so remove
the BrowserView one.

  • MiniBrowser/qt/BrowserView.cpp: (BrowserView::BrowserView):
6:49 AM Changeset in webkit [75371] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] DRT sideeffect revealed by r63657
https://bugs.webkit.org/show_bug.cgi?id=42578

Add new tests introduced in r75305 to the skipped list temporarily to make buildbot happy.

  • platform/qt/Skipped:
6:39 AM Changeset in webkit [75370] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-10 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: make properties on Array's prototype non-enumerable.
https://bugs.webkit.org/show_bug.cgi?id=51776

  • inspector/front-end/utilities.js: ():
5:50 AM Changeset in webkit [75369] by yael.aharon@nokia.com
  • 3 edits
    2 adds in trunk

Specificity of negated selectors apparently miscalculated
https://bugs.webkit.org/show_bug.cgi?id=41206

Reviewed by Simon Fraser.

Source/WebCore:

Give negated selectors the specificity of the selector they are negating.
This is the same as the behavior of other browsers.

Test: fast/css/pseudo-not.html

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::specificityForOneSelector):

LayoutTests:

  • fast/css/pseudo-not-expected.txt: Added.
  • fast/css/pseudo-not.html: Added.
5:30 AM Changeset in webkit [75368] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Windows build fix after r75353

  • WebCore.vcproj/WebCoreCommon.vsprops: Added rendering/mathml to the

include path.

3:41 AM Changeset in webkit [75367] by jorlow@chromium.org
  • 15 edits
    8 deletes in trunk

2011-01-10 John Knottenbelt <jknotten@chromium.org>

Reviewed by Jeremy Orlow.

[Chromium] Remove non-client-based Geolocation code
https://bugs.webkit.org/show_bug.cgi?id=50921

Code clean up, covered by existing tests.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/GeolocationServiceChromium.cpp: Removed.
  • platform/chromium/GeolocationServiceChromium.h: Removed.

2011-01-10 John Knottenbelt <jknotten@chromium.org>

Reviewed by Jeremy Orlow.

[Chromium] Remove non-client-based Geolocation code
https://bugs.webkit.org/show_bug.cgi?id=50921

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setGeolocationPermission): (LayoutTestController::setMockGeolocationPosition): (LayoutTestController::setMockGeolocationError):
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::geolocationClientMock): (WebViewHost::reset):
  • DumpRenderTree/chromium/WebViewHost.h:

2011-01-10 John Knottenbelt <jknotten@chromium.org>

Reviewed by Jeremy Orlow.

[Chromium] Remove non-client-based Geolocation code
https://bugs.webkit.org/show_bug.cgi?id=50921

  • WebKit.gyp:
  • public/WebGeolocationService.h: Removed.
  • public/WebGeolocationServiceBridge.h: Removed.
  • public/WebGeolocationServiceMock.h: Removed.
  • src/AssertMatchingEnums.cpp:
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::requestGeolocationPermissionForFrame): (WebKit::ChromeClientImpl::cancelGeolocationPermissionRequestForFrame):
  • src/ChromiumBridge.cpp:
  • src/WebGeolocationServiceBridgeImpl.cpp: Removed.
  • src/WebGeolocationServiceBridgeImpl.h: Removed.
  • src/WebGeolocationServiceMock.cpp: Removed.
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl):
  • src/WebViewImpl.h:
3:21 AM Changeset in webkit [75366] by eric@webkit.org
  • 5 edits in trunk/Tools

2011-01-10 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Commit bot tried to land r? cq+ patch
https://bugs.webkit.org/show_bug.cgi?id=36638

It should now be possible to post a patch with r? and cq+ and the
commit-queue will correctly wait for the r+ before attempting to land the patch.
(This was a feature requested by several users.)

One caveat: We don't actually reject r-, cq+ patches from the queue
(we just ignore them), but I think that's OK for now.

I also noticed that setting r- once a commit-queue node had grabbed
a patch would not properly cancel the landing. That's fixed and
tested in this patch.

  • Scripts/webkitpy/tool/bot/commitqueuetask.py:
  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  • Scripts/webkitpy/tool/bot/feeders.py:
  • Scripts/webkitpy/tool/bot/feeders_unittest.py:
2:44 AM Changeset in webkit [75365] by loislo@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-01-10 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: protocol related change. Rename stepIntoStatement, stepOutOfFunction, stepOverStatement.
stepIntoStatement => stepInto
stepOutOfFunction => stepOut
stepOverStatement => stepOver

https://bugs.webkit.org/show_bug.cgi?id=52142

  • inspector/Inspector.idl:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::stepOver): (WebCore::InspectorDebuggerAgent::stepInto): (WebCore::InspectorDebuggerAgent::stepOut):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._stepOverClicked): (WebInspector.ScriptsPanel.prototype._stepIntoClicked): (WebInspector.ScriptsPanel.prototype._stepOutClicked):
1:09 AM Changeset in webkit [75364] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebCore

2011-01-10 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Port progressbar painting to GtkStyleContext
https://bugs.webkit.org/show_bug.cgi?id=52054

Use GtkStyleContext API to paint progressbars when building with
GTK+ 3.x. Also add support for indeterminate progressbars.

No new tests. This should not change functionality.

  • platform/gtk/RenderThemeGtk.cpp:
  • platform/gtk/RenderThemeGtk2.cpp: (WebCore::RenderThemeGtk::animationRepeatIntervalForProgressBar): (WebCore::RenderThemeGtk::animationDurationForProgressBar):
  • platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::animationRepeatIntervalForProgressBar): (WebCore::RenderThemeGtk::animationDurationForProgressBar): (WebCore::RenderThemeGtk::paintProgressBar):
12:35 AM Changeset in webkit [75363] by andreas.kling@nokia.com
  • 10 edits
    3 deletes in trunk/Source/WebCore

2011-01-10 Andreas Kling <kling@webkit.org>

Reviewed by Darin Adler.

Remove unused class "Pen" in WebCore/platform/graphics
https://bugs.webkit.org/show_bug.cgi?id=49955

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/Pen.cpp: Removed.
  • platform/graphics/Pen.h: Removed.
  • platform/graphics/haiku/GraphicsContextHaiku.cpp:
  • platform/graphics/wx/GraphicsContextWx.cpp:
  • platform/graphics/wx/PenWx.cpp: Removed.
12:27 AM Changeset in webkit [75362] by Martin Robinson
  • 6 edits in trunk

2011-01-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Create intermediate libWebCore library
https://bugs.webkit.org/show_bug.cgi?id=52116

  • GNUmakefile.am: add XP_UNIX to the global CPP flags, since it's used by both libWebCore and libwebkitgtk now.

2011-01-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Create intermediate libWebCore library
https://bugs.webkit.org/show_bug.cgi?id=52116

Create intermediate libWebCore.la to avoid overflowing the linker
in the final link stage.

  • GNUmakefile.am: define the new library.

2011-01-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Create intermediate libWebCore library
https://bugs.webkit.org/show_bug.cgi?id=52116

  • GNUmakefile.am: add libWebCore.la to LIBADD and remove webcore sources from the libwebkit library SOURCES.

Jan 9, 2011:

11:15 PM Changeset in webkit [75361] by jnd@chromium.org
  • 2 edits in trunk/WebKit/chromium

2011-01-09 Johnny Ding <jnd@chromium.org>

Unreviewed, fix Chromium windows compilation error according to James Robinson's report.

https://bugs.webkit.org/show_bug.cgi?id=41441
Fix Chromium window compilation error.

  • public/WebViewClient.h: (WebKit::WebViewClient::createView):
9:46 PM Changeset in webkit [75360] by justin.garcia@apple.com
  • 3 edits in trunk/LayoutTests

Unreviewed. Adding svg/text/caret-in-svg-text.xhtml to Skipped list for gtk, where there
is no TextInputController, and qt, where firstRectForCharacterRange is unimplemented.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
6:38 PM Changeset in webkit [75359] by commit-queue@webkit.org
  • 4 edits in trunk

2011-01-09 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r75337.
http://trac.webkit.org/changeset/75337
https://bugs.webkit.org/show_bug.cgi?id=52137

It made fast/dom/navigator-detached-no-crash.html crash
(Requested by Ossy on #webkit).

  • platform/qt/CookieJarQt.cpp: (WebCore::cookiesEnabled):

2011-01-09 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r75337.
http://trac.webkit.org/changeset/75337
https://bugs.webkit.org/show_bug.cgi?id=52137

It made fast/dom/navigator-detached-no-crash.html crash
(Requested by Ossy on #webkit).

  • tests/qwebpage/tst_qwebpage.cpp:
4:47 PM Changeset in webkit [75358] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the build.

  • WebCore.xcodeproj/project.pbxproj: Copy SVGResourcesCache.h in to PrivateHeaders

once more.

3:34 PM Changeset in webkit [75357] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/8765555> WebKit2: Search field focus ring is missing

Reviewed by Sam Weinig.

Provide a focus ring visible rect to AppKit.

  • platform/mac/ThemeMac.mm:

(-[WebCoreFlippedView _focusRingVisibleRect]):
(-[WebCoreFlippedView _focusRingClipAncestor]):

11:37 AM Changeset in webkit [75356] by mitz@apple.com
  • 1 edit in trunk/WebKit2/ChangeLog

Added Radar URL

11:36 AM Changeset in webkit [75355] by mitz@apple.com
  • 4 edits in trunk/WebKit2

Assertion failure in KURL::KURL when calling WKURLRequestCreateWithWKURL with a non-parsed URL
https://bugs.webkit.org/show_bug.cgi?id=52132

Reviewed by Simon Fraser.

  • Shared/API/c/WKURLRequest.cpp:

(WKURLRequestCreateWithWKURL): Parse the URL.

  • Shared/WebString.h: Fixed a comment.
  • Shared/WebURL.h: Ditto.
11:24 AM Changeset in webkit [75354] by Simon Fraser
  • 3 edits in trunk/LayoutTests

2011-01-09 Simon Fraser <Simon Fraser>

Fix test after r75352.

Per HTML5, the disabled IDL attribute for style elements is not reflected
in the content attribute.

  • fast/dom/boolean-attribute-reflection-expected.txt:
  • fast/dom/script-tests/boolean-attribute-reflection.js:
11:13 AM Changeset in webkit [75353] by krit@webkit.org
  • 7 edits
    20 moves
    1 add in trunk/Source/WebCore

2011-01-09 Dirk Schulze <krit@webkit.org>

Reviewed by Rob Buis.

Move MathML renderer to rendering/mathml
https://bugs.webkit.org/show_bug.cgi?id=52131

Move all renderer of MathML to WebCore/rendering/mathml

No change of functionality, no new tests added.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • mathml/RenderMathMLBlock.cpp: Removed.
  • mathml/RenderMathMLBlock.h: Removed.
  • mathml/RenderMathMLFenced.cpp: Removed.
  • mathml/RenderMathMLFenced.h: Removed.
  • mathml/RenderMathMLFraction.cpp: Removed.
  • mathml/RenderMathMLFraction.h: Removed.
  • mathml/RenderMathMLMath.cpp: Removed.
  • mathml/RenderMathMLMath.h: Removed.
  • mathml/RenderMathMLOperator.cpp: Removed.
  • mathml/RenderMathMLOperator.h: Removed.
  • mathml/RenderMathMLRoot.cpp: Removed.
  • mathml/RenderMathMLRoot.h: Removed.
  • mathml/RenderMathMLRow.cpp: Removed.
  • mathml/RenderMathMLRow.h: Removed.
  • mathml/RenderMathMLSquareRoot.cpp: Removed.
  • mathml/RenderMathMLSquareRoot.h: Removed.
  • mathml/RenderMathMLSubSup.cpp: Removed.
  • mathml/RenderMathMLSubSup.h: Removed.
  • mathml/RenderMathMLUnderOver.cpp: Removed.
  • mathml/RenderMathMLUnderOver.h: Removed.
  • rendering/mathml: Added.
  • rendering/mathml/RenderMathMLBlock.cpp: Copied from Source/WebCore/mathml/RenderMathMLBlock.cpp.
  • rendering/mathml/RenderMathMLBlock.h: Copied from Source/WebCore/mathml/RenderMathMLBlock.h.
  • rendering/mathml/RenderMathMLFenced.cpp: Copied from Source/WebCore/mathml/RenderMathMLFenced.cpp.
  • rendering/mathml/RenderMathMLFenced.h: Copied from Source/WebCore/mathml/RenderMathMLFenced.h.
  • rendering/mathml/RenderMathMLFraction.cpp: Copied from Source/WebCore/mathml/RenderMathMLFraction.cpp.
  • rendering/mathml/RenderMathMLFraction.h: Copied from Source/WebCore/mathml/RenderMathMLFraction.h.
  • rendering/mathml/RenderMathMLMath.cpp: Copied from Source/WebCore/mathml/RenderMathMLMath.cpp.
  • rendering/mathml/RenderMathMLMath.h: Copied from Source/WebCore/mathml/RenderMathMLMath.h.
  • rendering/mathml/RenderMathMLOperator.cpp: Copied from Source/WebCore/mathml/RenderMathMLOperator.cpp.
  • rendering/mathml/RenderMathMLOperator.h: Copied from Source/WebCore/mathml/RenderMathMLOperator.h.
  • rendering/mathml/RenderMathMLRoot.cpp: Copied from Source/WebCore/mathml/RenderMathMLRoot.cpp.
  • rendering/mathml/RenderMathMLRoot.h: Copied from Source/WebCore/mathml/RenderMathMLRoot.h.
  • rendering/mathml/RenderMathMLRow.cpp: Copied from Source/WebCore/mathml/RenderMathMLRow.cpp.
  • rendering/mathml/RenderMathMLRow.h: Copied from Source/WebCore/mathml/RenderMathMLRow.h.
  • rendering/mathml/RenderMathMLSquareRoot.cpp: Copied from Source/WebCore/mathml/RenderMathMLSquareRoot.cpp.
  • rendering/mathml/RenderMathMLSquareRoot.h: Copied from Source/WebCore/mathml/RenderMathMLSquareRoot.h.
  • rendering/mathml/RenderMathMLSubSup.cpp: Copied from Source/WebCore/mathml/RenderMathMLSubSup.cpp.
  • rendering/mathml/RenderMathMLSubSup.h: Copied from Source/WebCore/mathml/RenderMathMLSubSup.h.
  • rendering/mathml/RenderMathMLUnderOver.cpp: Copied from Source/WebCore/mathml/RenderMathMLUnderOver.cpp.
  • rendering/mathml/RenderMathMLUnderOver.h: Copied from Source/WebCore/mathml/RenderMathMLUnderOver.h.
9:13 AM Changeset in webkit [75352] by Simon Fraser
  • 6 edits
    3 adds in trunk

2011-01-08 Simon Fraser <Simon Fraser>

Reviewed by Alexey Proskuryakov.

HTMLStyleElement.disabled doesn't work (affects jQuery)
https://bugs.webkit.org/show_bug.cgi?id=25287

Fix the disabled property of a HTMLStyleElement to reflect,
and set the disabled state of its style sheet, as required
by DOM1 etc.

Based on initial patch by Tarun Nainani.

Test: fast/html/disable-style-element.html

  • dom/StyleElement.h: (WebCore::StyleElement::sheet): Make const.
  • html/HTMLStyleElement.h:
  • html/HTMLStyleElement.idl:
  • html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::disabled): (WebCore::HTMLStyleElement::setDisabled): Getter and setter for disabled call through to the sheet (if any).
9:05 AM Changeset in webkit [75351] by krit@webkit.org
  • 104 edits
    2 moves in trunk

2011-01-09 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Rename RenderForeignObject to RenderSVGForeignObject
https://bugs.webkit.org/show_bug.cgi?id=52129

Rename RenderForeignObject to RenderSVGForeignObject to match the naming schema in render/svg.

No change of functionality, no new tests.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderingAllInOne.cpp:
  • rendering/svg/RenderForeignObject.cpp: Removed.
  • rendering/svg/RenderForeignObject.h: Removed.
  • rendering/svg/RenderSVGAllInOne.cpp:
  • rendering/svg/RenderSVGBlock.cpp: (WebCore::RenderSVGBlock::updateBoxModelInfoFromStyle):
  • rendering/svg/RenderSVGForeignObject.cpp: Copied from Source/WebCore/rendering/svg/RenderForeignObject.cpp. (WebCore::RenderSVGForeignObject::RenderSVGForeignObject): (WebCore::RenderSVGForeignObject::~RenderSVGForeignObject): (WebCore::RenderSVGForeignObject::paint): (WebCore::RenderSVGForeignObject::clippedOverflowRectForRepaint): (WebCore::RenderSVGForeignObject::computeRectForRepaint): (WebCore::RenderSVGForeignObject::localToParentTransform): (WebCore::RenderSVGForeignObject::computeLogicalWidth): (WebCore::RenderSVGForeignObject::computeLogicalHeight): (WebCore::RenderSVGForeignObject::layout): (WebCore::RenderSVGForeignObject::nodeAtFloatPoint): (WebCore::RenderSVGForeignObject::nodeAtPoint): (WebCore::RenderSVGForeignObject::mapLocalToContainer):
  • rendering/svg/RenderSVGForeignObject.h: Copied from Source/WebCore/rendering/svg/RenderForeignObject.h. (WebCore::RenderSVGForeignObject::renderName):
  • svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::createRenderer):

2011-01-09 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Rename RenderForeignObject to RenderSVGForeignObject
https://bugs.webkit.org/show_bug.cgi?id=52129

Renamed RenderForeignObject to RenderSVGForeignObject

  • platform/chromium-linux/svg/custom/dominant-baseline-hanging-expected.txt:
  • platform/chromium-win/svg/custom/baseval-animval-equality-expected.txt:
  • platform/chromium-win/svg/custom/dominant-baseline-hanging-expected.txt:
  • platform/chromium-win/svg/custom/dynamic-svg-document-creation-expected.txt:
  • platform/chromium-win/svg/custom/foreign-object-skew-expected.txt:
  • platform/chromium-win/svg/custom/foreignObject-crash-on-hover-expected.txt:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-1-expected.txt:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-2-expected.txt:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-3-expected.txt:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-4-expected.txt:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
  • platform/chromium-win/svg/custom/use-on-non-svg-namespaced-element-expected.txt:
  • platform/chromium-win/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.txt:
  • platform/chromium-win/svg/foreignObject/svg-document-as-direct-child-expected.txt:
  • platform/chromium-win/svg/foreignObject/svg-document-in-html-document-expected.txt:
  • platform/chromium-win/svg/foreignObject/text-tref-02-b-expected.txt:
  • platform/chromium-win/svg/hixie/mixed/006-expected.txt:
  • platform/chromium-win/svg/hixie/mixed/007-expected.txt:
  • platform/chromium-win/svg/hixie/mixed/008-expected.txt:
  • platform/chromium-win/svg/hixie/mixed/009-expected.txt:
  • platform/chromium-win/svg/hixie/mixed/011-expected.txt:
  • platform/chromium-win/svg/text/foreignObject-repaint-expected.txt:
  • platform/chromium-win/svg/text/foreignObject-text-clipping-bug-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
  • platform/chromium-win/svg/zoom/text/zoom-foreignObject-expected.txt:
  • platform/chromium-win/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
  • platform/chromium-win/svg/zoom/text/zoom-hixie-mixed-009-expected.txt:
  • platform/gtk/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.txt:
  • platform/gtk/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.txt:
  • platform/gtk/svg/foreignObject/svg-document-as-direct-child-expected.txt:
  • platform/gtk/svg/foreignObject/svg-document-in-html-document-expected.txt:
  • platform/gtk/svg/foreignObject/text-tref-02-b-expected.txt:
  • platform/gtk/svg/overflow/overflow-on-foreignObject-expected.txt:
  • platform/gtk/svg/text/foreignObject-repaint-expected.txt:
  • platform/gtk/svg/text/foreignObject-text-clipping-bug-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-foreignObject-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
  • platform/mac-leopard/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
  • platform/mac-leopard/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
  • platform/mac/svg/custom/baseval-animval-equality-expected.txt:
  • platform/mac/svg/custom/dominant-baseline-hanging-expected.txt:
  • platform/mac/svg/custom/dynamic-svg-document-creation-expected.txt:
  • platform/mac/svg/custom/fill-SVGPaint-interface-expected.txt:
  • platform/mac/svg/custom/foreign-object-skew-expected.txt:
  • platform/mac/svg/custom/foreignObject-crash-on-hover-expected.txt:
  • platform/mac/svg/custom/getPresentationAttribute-expected.txt:
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-1-expected.txt:
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-2-expected.txt:
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-3-expected.txt:
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-4-expected.txt:
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
  • platform/mac/svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt:
  • platform/mac/svg/custom/use-on-non-svg-namespaced-element-expected.txt:
  • platform/mac/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.txt:
  • platform/mac/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.txt:
  • platform/mac/svg/foreignObject/svg-document-as-direct-child-expected.txt:
  • platform/mac/svg/foreignObject/svg-document-in-html-document-expected.txt:
  • platform/mac/svg/foreignObject/text-tref-02-b-expected.txt:
  • platform/mac/svg/hixie/mixed/006-expected.txt:
  • platform/mac/svg/hixie/mixed/007-expected.txt:
  • platform/mac/svg/hixie/mixed/008-expected.txt:
  • platform/mac/svg/hixie/mixed/009-expected.txt:
  • platform/mac/svg/hixie/mixed/011-expected.txt:
  • platform/mac/svg/overflow/overflow-on-foreignObject-expected.txt:
  • platform/mac/svg/text/foreignObject-repaint-expected.txt:
  • platform/mac/svg/text/foreignObject-text-clipping-bug-expected.txt:
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
  • platform/mac/svg/zoom/text/zoom-foreignObject-expected.txt:
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-009-expected.txt:
  • platform/qt/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.txt:
  • platform/qt/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.txt:
  • platform/qt/svg/foreignObject/svg-document-as-direct-child-expected.txt:
  • platform/qt/svg/foreignObject/svg-document-in-html-document-expected.txt:
  • platform/qt/svg/foreignObject/text-tref-02-b-expected.txt:
  • platform/qt/svg/overflow/overflow-on-foreignObject-expected.txt:
  • platform/qt/svg/text/foreignObject-text-clipping-bug-expected.txt:
  • platform/qt/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/qt/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
  • platform/qt/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
  • platform/qt/svg/zoom/text/zoom-foreignObject-expected.txt:
  • platform/qt/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
  • platform/qt/svg/zoom/text/zoom-hixie-mixed-009-expected.txt:
4:35 AM Changeset in webkit [75350] by krit@webkit.org
  • 8 edits
    64 moves in trunk/Source/WebCore

2011-01-09 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Move all SVG renderer to WebCore/rendering/svg
https://bugs.webkit.org/show_bug.cgi?id=52087

No change of functionality. Just moved all SVG renderer to WebCore/rendering/svg.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vjproj/project.vjproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderForeignObject.cpp: Removed.
  • rendering/RenderForeignObject.h: Removed.
  • rendering/RenderSVGAllInOne.cpp: Removed.
  • rendering/RenderSVGBlock.cpp: Removed.
  • rendering/RenderSVGBlock.h: Removed.
  • rendering/RenderSVGContainer.cpp: Removed.
  • rendering/RenderSVGContainer.h: Removed.
  • rendering/RenderSVGGradientStop.cpp: Removed.
  • rendering/RenderSVGGradientStop.h: Removed.
  • rendering/RenderSVGHiddenContainer.cpp: Removed.
  • rendering/RenderSVGHiddenContainer.h: Removed.
  • rendering/RenderSVGImage.cpp: Removed.
  • rendering/RenderSVGImage.h: Removed.
  • rendering/RenderSVGModelObject.cpp: Removed.
  • rendering/RenderSVGModelObject.h: Removed.
  • rendering/RenderSVGResource.cpp: Removed.
  • rendering/RenderSVGResource.h: Removed.
  • rendering/RenderSVGResourceClipper.cpp: Removed.
  • rendering/RenderSVGResourceClipper.h: Removed.
  • rendering/RenderSVGResourceContainer.cpp: Removed.
  • rendering/RenderSVGResourceContainer.h: Removed.
  • rendering/RenderSVGResourceFilter.cpp: Removed.
  • rendering/RenderSVGResourceFilter.h: Removed.
  • rendering/RenderSVGResourceFilterPrimitive.cpp: Removed.
  • rendering/RenderSVGResourceFilterPrimitive.h: Removed.
  • rendering/RenderSVGResourceGradient.cpp: Removed.
  • rendering/RenderSVGResourceGradient.h: Removed.
  • rendering/RenderSVGResourceLinearGradient.cpp: Removed.
  • rendering/RenderSVGResourceLinearGradient.h: Removed.
  • rendering/RenderSVGResourceMarker.cpp: Removed.
  • rendering/RenderSVGResourceMarker.h: Removed.
  • rendering/RenderSVGResourceMasker.cpp: Removed.
  • rendering/RenderSVGResourceMasker.h: Removed.
  • rendering/RenderSVGResourcePattern.cpp: Removed.
  • rendering/RenderSVGResourcePattern.h: Removed.
  • rendering/RenderSVGResourceRadialGradient.cpp: Removed.
  • rendering/RenderSVGResourceRadialGradient.h: Removed.
  • rendering/RenderSVGResourceSolidColor.cpp: Removed.
  • rendering/RenderSVGResourceSolidColor.h: Removed.
  • rendering/RenderSVGRoot.cpp: Removed.
  • rendering/RenderSVGRoot.h: Removed.
  • rendering/RenderSVGShadowTreeRootContainer.cpp: Removed.
  • rendering/RenderSVGShadowTreeRootContainer.h: Removed.
  • rendering/RenderSVGTransformableContainer.cpp: Removed.
  • rendering/RenderSVGTransformableContainer.h: Removed.
  • rendering/RenderSVGViewportContainer.cpp: Removed.
  • rendering/RenderSVGViewportContainer.h: Removed.
  • rendering/SVGImageBufferTools.cpp: Removed.
  • rendering/SVGImageBufferTools.h: Removed.
  • rendering/SVGMarkerData.h: Removed.
  • rendering/SVGMarkerLayoutInfo.cpp: Removed.
  • rendering/SVGMarkerLayoutInfo.h: Removed.
  • rendering/SVGRenderSupport.cpp: Removed.
  • rendering/SVGRenderSupport.h: Removed.
  • rendering/SVGRenderTreeAsText.cpp: Removed.
  • rendering/SVGRenderTreeAsText.h: Removed.
  • rendering/SVGResources.cpp: Removed.
  • rendering/SVGResources.h: Removed.
  • rendering/SVGResourcesCache.cpp: Removed.
  • rendering/SVGResourcesCache.h: Removed.
  • rendering/SVGResourcesCycleSolver.cpp: Removed.
  • rendering/SVGResourcesCycleSolver.h: Removed.
  • rendering/SVGShadowTreeElements.cpp: Removed.
  • rendering/SVGShadowTreeElements.h: Removed.
  • rendering/svg/RenderForeignObject.cpp: Copied from Source/WebCore/rendering/RenderForeignObject.cpp.
  • rendering/svg/RenderForeignObject.h: Copied from Source/WebCore/rendering/RenderForeignObject.h.
  • rendering/svg/RenderSVGAllInOne.cpp: Copied from Source/WebCore/rendering/RenderSVGAllInOne.cpp.
  • rendering/svg/RenderSVGBlock.cpp: Copied from Source/WebCore/rendering/RenderSVGBlock.cpp.
  • rendering/svg/RenderSVGBlock.h: Copied from Source/WebCore/rendering/RenderSVGBlock.h.
  • rendering/svg/RenderSVGContainer.cpp: Copied from Source/WebCore/rendering/RenderSVGContainer.cpp.
  • rendering/svg/RenderSVGContainer.h: Copied from Source/WebCore/rendering/RenderSVGContainer.h.
  • rendering/svg/RenderSVGGradientStop.cpp: Copied from Source/WebCore/rendering/RenderSVGGradientStop.cpp.
  • rendering/svg/RenderSVGGradientStop.h: Copied from Source/WebCore/rendering/RenderSVGGradientStop.h.
  • rendering/svg/RenderSVGHiddenContainer.cpp: Copied from Source/WebCore/rendering/RenderSVGHiddenContainer.cpp.
  • rendering/svg/RenderSVGHiddenContainer.h: Copied from Source/WebCore/rendering/RenderSVGHiddenContainer.h.
  • rendering/svg/RenderSVGImage.cpp: Copied from Source/WebCore/rendering/RenderSVGImage.cpp.
  • rendering/svg/RenderSVGImage.h: Copied from Source/WebCore/rendering/RenderSVGImage.h.
  • rendering/svg/RenderSVGModelObject.cpp: Copied from Source/WebCore/rendering/RenderSVGModelObject.cpp.
  • rendering/svg/RenderSVGModelObject.h: Copied from Source/WebCore/rendering/RenderSVGModelObject.h.
  • rendering/svg/RenderSVGResource.cpp: Copied from Source/WebCore/rendering/RenderSVGResource.cpp.
  • rendering/svg/RenderSVGResource.h: Copied from Source/WebCore/rendering/RenderSVGResource.h.
  • rendering/svg/RenderSVGResourceClipper.cpp: Copied from Source/WebCore/rendering/RenderSVGResourceClipper.cpp.
  • rendering/svg/RenderSVGResourceClipper.h: Copied from Source/WebCore/rendering/RenderSVGResourceClipper.h.
  • rendering/svg/RenderSVGResourceContainer.cpp: Copied from Source/WebCore/rendering/RenderSVGResourceContainer.cpp.
  • rendering/svg/RenderSVGResourceContainer.h: Copied from Source/WebCore/rendering/RenderSVGResourceContainer.h.
  • rendering/svg/RenderSVGResourceFilter.cpp: Copied from Source/WebCore/rendering/RenderSVGResourceFilter.cpp.
  • rendering/svg/RenderSVGResourceFilter.h: Copied from Source/WebCore/rendering/RenderSVGResourceFilter.h.
  • rendering/svg/RenderSVGResourceFilterPrimitive.cpp: Copied from Source/WebCore/rendering/RenderSVGResourceFilterPrimitive.cpp.
  • rendering/svg/RenderSVGResourceFilterPrimitive.h: Copied from Source/WebCore/rendering/RenderSVGResourceFilterPrimitive.h.
  • rendering/svg/RenderSVGResourceGradient.cpp: Copied from Source/WebCore/rendering/RenderSVGResourceGradient.cpp.
  • rendering/svg/RenderSVGResourceGradient.h: Copied from Source/WebCore/rendering/RenderSVGResourceGradient.h.
  • rendering/svg/RenderSVGResourceLinearGradient.cpp: Copied from Source/WebCore/rendering/RenderSVGResourceLinearGradient.cpp.
  • rendering/svg/RenderSVGResourceLinearGradient.h: Copied from Source/WebCore/rendering/RenderSVGResourceLinearGradient.h.
  • rendering/svg/RenderSVGResourceMarker.cpp: Copied from Source/WebCore/rendering/RenderSVGResourceMarker.cpp.
  • rendering/svg/RenderSVGResourceMarker.h: Copied from Source/WebCore/rendering/RenderSVGResourceMarker.h.
  • rendering/svg/RenderSVGResourceMasker.cpp: Copied from Source/WebCore/rendering/RenderSVGResourceMasker.cpp.
  • rendering/svg/RenderSVGResourceMasker.h: Copied from Source/WebCore/rendering/RenderSVGResourceMasker.h.
  • rendering/svg/RenderSVGResourcePattern.cpp: Copied from Source/WebCore/rendering/RenderSVGResourcePattern.cpp.
  • rendering/svg/RenderSVGResourcePattern.h: Copied from Source/WebCore/rendering/RenderSVGResourcePattern.h.
  • rendering/svg/RenderSVGResourceRadialGradient.cpp: Copied from Source/WebCore/rendering/RenderSVGResourceRadialGradient.cpp.
  • rendering/svg/RenderSVGResourceRadialGradient.h: Copied from Source/WebCore/rendering/RenderSVGResourceRadialGradient.h.
  • rendering/svg/RenderSVGResourceSolidColor.cpp: Copied from Source/WebCore/rendering/RenderSVGResourceSolidColor.cpp.
  • rendering/svg/RenderSVGResourceSolidColor.h: Copied from Source/WebCore/rendering/RenderSVGResourceSolidColor.h.
  • rendering/svg/RenderSVGRoot.cpp: Copied from Source/WebCore/rendering/RenderSVGRoot.cpp.
  • rendering/svg/RenderSVGRoot.h: Copied from Source/WebCore/rendering/RenderSVGRoot.h.
  • rendering/svg/RenderSVGShadowTreeRootContainer.cpp: Copied from Source/WebCore/rendering/RenderSVGShadowTreeRootContainer.cpp.
  • rendering/svg/RenderSVGShadowTreeRootContainer.h: Copied from Source/WebCore/rendering/RenderSVGShadowTreeRootContainer.h.
  • rendering/svg/RenderSVGTransformableContainer.cpp: Copied from Source/WebCore/rendering/RenderSVGTransformableContainer.cpp.
  • rendering/svg/RenderSVGTransformableContainer.h: Copied from Source/WebCore/rendering/RenderSVGTransformableContainer.h.
  • rendering/svg/RenderSVGViewportContainer.cpp: Copied from Source/WebCore/rendering/RenderSVGViewportContainer.cpp.
  • rendering/svg/RenderSVGViewportContainer.h: Copied from Source/WebCore/rendering/RenderSVGViewportContainer.h.
  • rendering/svg/SVGImageBufferTools.cpp: Copied from Source/WebCore/rendering/SVGImageBufferTools.cpp.
  • rendering/svg/SVGImageBufferTools.h: Copied from Source/WebCore/rendering/SVGImageBufferTools.h.
  • rendering/svg/SVGMarkerData.h: Copied from Source/WebCore/rendering/SVGMarkerData.h.
  • rendering/svg/SVGMarkerLayoutInfo.cpp: Copied from Source/WebCore/rendering/SVGMarkerLayoutInfo.cpp.
  • rendering/svg/SVGMarkerLayoutInfo.h: Copied from Source/WebCore/rendering/SVGMarkerLayoutInfo.h.
  • rendering/svg/SVGRenderSupport.cpp: Copied from Source/WebCore/rendering/SVGRenderSupport.cpp.
  • rendering/svg/SVGRenderSupport.h: Copied from Source/WebCore/rendering/SVGRenderSupport.h.
  • rendering/svg/SVGRenderTreeAsText.cpp: Copied from Source/WebCore/rendering/SVGRenderTreeAsText.cpp.
  • rendering/svg/SVGRenderTreeAsText.h: Copied from Source/WebCore/rendering/SVGRenderTreeAsText.h.
  • rendering/svg/SVGResources.cpp: Copied from Source/WebCore/rendering/SVGResources.cpp.
  • rendering/svg/SVGResources.h: Copied from Source/WebCore/rendering/SVGResources.h.
  • rendering/svg/SVGResourcesCache.cpp: Copied from Source/WebCore/rendering/SVGResourcesCache.cpp.
  • rendering/svg/SVGResourcesCache.h: Copied from Source/WebCore/rendering/SVGResourcesCache.h.
  • rendering/svg/SVGResourcesCycleSolver.cpp: Copied from Source/WebCore/rendering/SVGResourcesCycleSolver.cpp.
  • rendering/svg/SVGResourcesCycleSolver.h: Copied from Source/WebCore/rendering/SVGResourcesCycleSolver.h.
  • rendering/svg/SVGShadowTreeElements.cpp: Copied from Source/WebCore/rendering/SVGShadowTreeElements.cpp.
  • rendering/svg/SVGShadowTreeElements.h: Copied from Source/WebCore/rendering/SVGShadowTreeElements.h.
3:22 AM Changeset in webkit [75349] by commit-queue@webkit.org
  • 21 edits in trunk

2011-01-09 Xianzhu Wang <phnixwxz@gmail.com>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=41441
createWindow method should only do window-creating without URL navigation.
Let client APIs know which URL a new window will start with

  • loader/FrameLoader.cpp: (WebCore::createWindow):
  • page/ContextMenuController.cpp: (WebCore::openNewWindow):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::createWindow):

2011-01-09 Xianzhu Wang <phnixwxz@gmail.com>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=41441
createWindow method should only do window-creating without URL navigation.
Pass URL request to createView.

  • public/WebViewClient.h: (WebKit::WebViewClient::createView):
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::createWindow):

2011-01-09 Xianzhu Wang <phnixwxz@gmail.com>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=41441
createWindow method should only do window-creating without URL navigation

  • WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::createWindow):

2011-01-09 Xianzhu Wang <phnixwxz@gmail.com>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=41441
createWindow method should only do window-creating without URL navigation

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::createWindow):

2011-01-09 Xianzhu Wang <phnixwxz@gmail.com>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=41441
createWindow method should only do window-creating without URL navigation

  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::createWindow):

2011-01-09 Xianzhu Wang <phnixwxz@gmail.com>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=41441
createWindow method should only do window-creating without URL navigation

  • Api/qwebpage.cpp: (openNewWindow):
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::createWindow):

2011-01-09 Xianzhu Wang <phnixwxz@gmail.com>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=41441
createWindow method should only do window-creating without URL navigation

  • WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::createWindow):

2011-01-09 Xianzhu Wang <phnixwxz@gmail.com>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=41441
createWindow method should only do window-creating without URL navigation

  • WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::createWindow):
2:44 AM Changeset in webkit [75348] by krit@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-09 Dirk Schulze <krit@webkit.org>

Unreviewed sort of Xcode project file.

  • WebCore.xcodeproj/project.pbxproj:
12:57 AM Changeset in webkit [75347] by commit-queue@webkit.org
  • 4 edits
    8 adds in trunk

2011-01-09 Amruth Raj <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com>

Reviewed by Martin Robinson.

Changes to add Process Launcher and Thread Launcher implementation to the WebKit2 GTK port.
https://bugs.webkit.org/show_bug.cgi?id=48511

  • platform/FileSystem.h:
  • platform/gtk/FileSystemGtk.cpp: Implement function to get a binary's path (WebCore::applicationDirectoryPath):

2011-01-09 Amruth Raj <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com>

Reviewed by Martin Robinson.

Changes to add Process Launcher and Thread Launcher implementation to the WebKit2 GTK port.
The main() implementation for WebKitWebProcess binary to launch Web process from UI process.
https://bugs.webkit.org/show_bug.cgi?id=48511

  • UIProcess/Launcher/gtk: Added.
  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp: Added. GTK (UNIX_X11 specific) implementation (WebKit::ProcessLauncher::launchProcess): (WebKit::ProcessLauncher::terminateProcess): (WebKit::ProcessLauncher::platformInvalidate):
  • UIProcess/Launcher/gtk/ThreadLauncherGtk.cpp: Added. Stubbed implementation for GTK port. Yet to implement. (WebKit::ThreadLauncher::createWebThread):
  • WebProcess/gtk: Added.
  • WebProcess/gtk/WebProcessGtk.cpp: Added. The stubbed implementations of virtual functions of WebProcess.h for GTK port. (WebKit::WebProcess::platformSetCacheModel): (WebKit::WebProcess::platformClearResourceCaches): (WebKit::WebProcess::platformInitializeWebProcess): (WebKit::WebProcess::platformShutdown):
  • WebProcess/gtk/WebProcessMainGtk.cpp: Added. The WebProcessMain call which initiates the Web Process for GTK port. (WebKit::WebProcessMainGtk):
  • WebProcess/gtk/WebProcessMainGtk.h: Added. The WebProcessMain declaration for Web Process for GTK port.
  • gtk/MainGtk.cpp: Added. The main function implementation for binary WebKitWebProcess. (main):

Jan 8, 2011:

11:32 PM Changeset in webkit [75346] by Martin Robinson
  • 4 edits in trunk

2011-01-08 Martin Robinson <mrobinson@igalia.com>

GTK+ Build fix. Add missing headers to the source list, fixing make dist.

No new tests. This is only a build change.

  • GNUmakefile.am: Add missing headers to the source list.

2011-01-08 Martin Robinson <mrobinson@igalia.com>

GTK+ build fix. Adding missing headers to the source list, fixing make dist.

  • GNUmakefile.am: Fix make dist.
10:50 PM Changeset in webkit [75345] by Martin Robinson
  • 11 edits in trunk

2011-01-08 Amruth Raj <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com>

Reviewed by Martin Robinson.

[GTK] WebKit2 GNUmakefile is out of date from trunk
https://bugs.webkit.org/show_bug.cgi?id=51883

Added stubs for WebKit2 compilation.

  • platform/gtk/ContextMenuGtk.cpp: (WebCore::contextMenuItemVector):
  • platform/gtk/ContextMenuItemGtk.cpp: (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::checked): (WebCore::ContextMenuItem::enabled):
  • platform/network/soup/AuthenticationChallenge.h: (WebCore::AuthenticationChallenge::authenticationClient):

2011-01-07 Amruth Raj <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com>

Reviewed by Martin Robinson.

[GTK] WebKit2 GNUmakefile is out of date from trunk
https://bugs.webkit.org/show_bug.cgi?id=51883

  • GNUmakefile.am: Updated sources list as per latest revision
  • Platform/gtk/RunLoopGtk.cpp: (RunLoop::TimerBase::start):
  • Platform/gtk/WorkQueueGtk.cpp: (WorkQueue::scheduleWorkAfterDelay):
  • Shared/gtk/BackingStoreGtk.cpp: (WebKit::BackingStore::paint):
  • WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp: (WebKit::InjectedBundle::load):
  • WebProcess/Plugins/Netscape/gtk/NetscapePluginGtk.cpp: (WebKit::NetscapePlugin::platformInvalidate):
10:07 PM Changeset in webkit [75344] by mitz@apple.com
  • 10 edits in trunk/WebKit2

<rdar://problem/8812759> In WebKit2, PDF view settings (mode and scale) do not stick
https://bugs.webkit.org/show_bug.cgi?id=52118

Reviewed by Sam Weinig.

  • Shared/WebPreferencesStore.cpp:

(WebKit::WebPreferencesStore::encode): Encode the double values map.
(WebKit::WebPreferencesStore::decode): Decode the double values map.
(WebKit::defaultValueForKey): Added double instance.
(WebKit::WebPreferencesStore::setDoubleValueForKey): Added.
(WebKit::WebPreferencesStore::getDoubleValueForKey): Added.

  • Shared/WebPreferencesStore.h: Added PDFScaleFactor and PDFDisplayMode preferences.
  • UIProcess/API/mac/PDFViewController.mm:

(-[WKPDFView initWithFrame:PDFViewController:WebKit::]): Initialize the _pdfViewController ivar.
(-[WKPDFView invalidate]): Changed 'nil' to '0' in assignment to a non-Objective-C pointer.
(-[WKPDFView setDocument:]): Added.
(-[WKPDFView _applyPDFPreferences]): Added.
(-[WKPDFView _updatePreferences:]): Added.
(-[WKPDFView _updatePreferencesSoon]): Added.
(-[WKPDFView _scaleOrDisplayModeOrPageChanged:]): Added.
(-[WKPDFView viewDidMoveToWindow]): Added. Starts observing the PDF view for changes to scale
and display mode.
(-[WKPDFView viewWillMoveToWindow:]): Added. Stops observing for changes.
(WebKit::PDFViewController::setPDFDocumentData): Changed to call throguh -[WKPDFView setDocument:].

  • UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::updateDoubleValueForKey): Added.

  • UIProcess/WebPreferences.h:
  • UIProcess/cf/WebPreferencesCF.cpp:

(WebKit::WebPreferences::platformUpdateDoubleValueForKey): Added empty implementation.

  • UIProcess/gtk/WebPreferencesGtk.cpp:

(WebKit::WebPreferences::platformUpdateDoubleValueForKey): Added stub.

  • UIProcess/mac/WebPreferencesMac.mm:

(WebKit::setDoubleValueIfInUserDefaults): Added.
(WebKit::WebPreferences::platformUpdateDoubleValueForKey): Added.

  • UIProcess/qt/WebPreferencesQt.cpp:

(WebKit::WebPreferences::platformUpdateDoubleValueForKey): Added.

9:04 PM CSS21Results edited by Simon Fraser
(diff)
8:58 PM CSS21Results edited by Simon Fraser
(diff)
8:31 PM CSS21Results edited by Simon Fraser
(diff)
7:27 PM CSS21Results edited by Simon Fraser
(diff)
7:10 PM Changeset in webkit [75343] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-08 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Unify string table adding in AtomicString
https://bugs.webkit.org/show_bug.cgi?id=51927

Move code for adding a string into a separate function.
This removes multiple occurrence of the same logic.

  • wtf/text/AtomicString.cpp: (WTF::addToStringTable): Added. (WTF::AtomicString::add): Use addToStringTable(). (WTF::AtomicString::fromUTF8): Ditto.
7:04 PM Changeset in webkit [75342] by ggaren@apple.com
  • 12 edits
    2 copies in trunk/Source/JavaScriptCore

2011-01-07 Geoffrey Garen <ggaren@apple.com>

Reviewed by Gavin Barraclough.

Split machine stack marking functions into their own class (MachineStackMarker)
https://bugs.webkit.org/show_bug.cgi?id=52088

  • API/APIShims.h: (JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock): Moved registerThread() call behind an #ifdef because we shouldn't be registering threads at all if we don't support usage on multiple threads.
  • runtime/Collector.cpp: (JSC::Heap::Heap): (JSC::Heap::destroy): (JSC::Heap::markRoots):
  • runtime/Collector.h: (JSC::Heap::machineStackMarker): Moved code to machineStackMarker.
  • runtime/JSGlobalData.h: (JSC::JSGlobalData::makeUsableFromMultipleThreads): Removed an unnecessary level of indirection, to make Heap less of a God class.
  • runtime/MachineStackMarker.h: Copied from Source/JavaScriptCore/runtime/Collector.h.
  • runtime/MachineStackMarker.cpp: Copied from Source/JavaScriptCore/runtime/Collector.cpp. (JSC::MachineStackMarker::MachineStackMarker): (JSC::MachineStackMarker::~MachineStackMarker): (JSC::MachineStackMarker::makeUsableFromMultipleThreads): (JSC::MachineStackMarker::registerThread): (JSC::MachineStackMarker::unregisterThread): (JSC::MachineStackMarker::markCurrentThreadConservativelyInternal): (JSC::MachineStackMarker::markCurrentThreadConservatively): (JSC::MachineStackMarker::markOtherThreadConservatively): (JSC::MachineStackMarker::markMachineStackConservatively): Moved code from Heap.
6:35 PM Changeset in webkit [75341] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

2011-01-08 Helder Correia <helder@sencha.com>

Reviewed by Simon Fraser.

Shadow is not drawn when filling a path with a gradient
https://bugs.webkit.org/show_bug.cgi?id=51982

This happens in CG and is related to bug 51869, this time to be fixed
in GraphicsContext::fillPath(const Path& path). We need to draw the
gradient clipped to the path on a CGLayer first, and then draw the
layer on the GraphicsContext.

  • fast/canvas/canvas-fillPath-gradient-shadow-expected.txt: Added.
  • fast/canvas/canvas-fillPath-gradient-shadow.html: Added.
  • fast/canvas/script-tests/canvas-fillPath-gradient-shadow.js: Added.
  • platform/chromium/test_expectations.txt: Skipping new test since it fails.
  • platform/qt/Skipped: Ditto.

2011-01-08 Helder Correia <helder@sencha.com>

Reviewed by Simon Fraser.

Shadow is not drawn when filling a path with a gradient
https://bugs.webkit.org/show_bug.cgi?id=51982

This happens in CG and is related to bug 51869, this time to be fixed
in GraphicsContext::fillPath(const Path& path). We need to draw the
gradient clipped to the path on a CGLayer first, and then draw the
layer on the GraphicsContext.

Test: fast/canvas/canvas-fillPath-gradient-shadow.html

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillPath):
6:29 PM Changeset in webkit [75340] by benjamin.poulain@nokia.com
  • 3 edits in trunk/Tools

2011-01-08 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
https://bugs.webkit.org/show_bug.cgi?id=51934

When accessing the network from the destructor of QWebPage, the network access manager
was already deleted because the object WebPage was already destructed.

This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
The object is now destructed in the destructor of QObject.

  • QtTestBrowser/webpage.cpp: (WebPage::WebPage): (WebPage::setQnamThreaded):
  • QtTestBrowser/webpage.h: (QtNAMThread::QtNAMThread):
6:13 PM Changeset in webkit [75339] by benjamin.poulain@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-01-08 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] PasteboardQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=39771

Update the code to follow the coding style.

  • platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::writePlainText): (WebCore::Pasteboard::writeURL):
5:31 PM Changeset in webkit [75338] by tonyg@chromium.org
  • 3 edits
    4 adds in trunk

2011-01-08 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

HTML5 Conformance Test failure: approved/xhtml5/html_style_in_comment.xhtml
https://bugs.webkit.org/show_bug.cgi?id=48593

  • fast/parser/html-html-comment-in-style-block-expected.txt: Added.
  • fast/parser/html-html-comment-in-style-block.html: Added.
  • fast/parser/xhtml-html-comment-in-style-block-expected.txt: Added.
  • fast/parser/xhtml-html-comment-in-style-block.xhtml: Added.

2011-01-08 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

HTML5 Conformance Test failure: approved/xhtml5/html_style_in_comment.xhtml
https://bugs.webkit.org/show_bug.cgi?id=48593

XHTML <style> blocks, unlike HTML <style> blocks, should respect HTML
comments.

Test: fast/parser/xhtml-html-comment-in-style-block.xhtml

  • dom/StyleElement.cpp: (WebCore::isValidStyleChild): Remove the COMMENT_NODE check as the HTML parser doesn't add COMMENT_NODEs as children of style blocks. (WebCore::StyleElement::process): Factored out a condition that must remain in sync.
5:30 PM Changeset in webkit [75337] by benjamin.poulain@nokia.com
  • 4 edits in trunk

2011-01-08 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Navigator.cookiesEnabled return true for Qt even if there is no cookie jar
https://bugs.webkit.org/show_bug.cgi?id=52081

Test for the availability of cookie jar to return if cookies are enabled or not. The network access
manager always exist, not the cookie jar.

  • platform/qt/CookieJarQt.cpp: (WebCore::cookiesEnabled):

2011-01-08 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Navigator.cookiesEnabled return true for Qt even if there is no cookie jar
https://bugs.webkit.org/show_bug.cgi?id=52081

Add an autotest for checking the result of Navigator.cookiesEnabled depending
on the status of the cookie jar.

  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::navigatorCookieEnabled):
5:27 PM Changeset in webkit [75336] by commit-queue@webkit.org
  • 5 edits
    4 adds in trunk

2011-01-08 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Canceled frame loads can corrupt back forward list
https://bugs.webkit.org/show_bug.cgi?id=50254

http/tests/navigation/forward-and-cancel.html aborts a slowly loading
subframe in a frame tree and ensures the history items are updated properly.

  • LayoutTests/http/tests/navigation/forward-and-cancel-expected.txt: Added.
  • LayoutTests/http/tests/navigation/forward-and-cancel.html: Added.
  • LayoutTests/http/tests/navigation/resources/forward-and-cancel-frames.html: Added.
  • LayoutTests/http/tests/navigation/resources/forward-and-cancel-frames-container.html: Added.

2011-01-08 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Canceled frame loads can corrupt back forward list
https://bugs.webkit.org/show_bug.cgi?id=50254

Avoids changing m_currentItem until the navigation commits.
Also resets top-level history items if a subframe navigation is canceled.

  • WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
  • WebCore/loader/HistoryController.cpp:
  • WebCore/loader/HistoryController.h:
5:08 PM Changeset in webkit [75335] by chang.shu@nokia.com
  • 8 edits in trunk

2011-01-08 Chang Shu <chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Support createTouchList with Touch list for test automation.
https://bugs.webkit.org/show_bug.cgi?id=51196

Added test cases that take Touch objects when creating TouchList.

  • fast/events/touch/document-create-touch-list-expected.txt:
  • fast/events/touch/script-tests/document-create-touch-list.js:

2011-01-08 Chang Shu <chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Support createTouchList with Touch list for test automation.
Implemented JS/V8 custom functions for createTouchList.
https://bugs.webkit.org/show_bug.cgi?id=51196

  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::createTouchList):
  • bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::V8Document::createTouchListCallback):
  • dom/Document.idl:
  • dom/TouchEvent.cpp: (WebCore::TouchEvent::initTouchEvent):
4:47 PM Changeset in webkit [75334] by benjamin.poulain@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-01-08 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] CookieJarQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=39778

Improve the coding style of CookieJarQt.cpp.

  • platform/qt/CookieJarQt.cpp: (WebCore::networkAccessManager): (WebCore::cookiesEnabled):
4:24 PM Changeset in webkit [75333] by Patrick Gansterer
  • 2 edits in trunk

2011-01-08 Patrick Gansterer <Patrick Gansterer>

Unreviewed wx build fix for r75313.

  • wscript: Added missing brace.
3:56 PM Changeset in webkit [75332] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-01-08 Eric Seidel <eric@webkit.org>

Reviewed by Ojan Vafai.

test_failures.py should not mention TestShell (long live DumpRenderTree!)
https://bugs.webkit.org/show_bug.cgi?id=52067

I ran test-webkitpy, but didn't bother adding a unit test for this string change.
https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.

  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3:47 PM Changeset in webkit [75331] by mitz@apple.com
  • 15 edits in trunk/WebKit2

In WebKit2, page zooming does not work with PDF
https://bugs.webkit.org/show_bug.cgi?id=52113

Reviewed by Maciej Stachowiak.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSupportsTextZoom): Added. Returns whether the page currently supports text-only zoom.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/mac/PDFViewController.h: Made pdfDocumentClass() private and declared new

member functions.

  • UIProcess/API/mac/PDFViewController.mm:

(WebKit::PDFViewController::zoomFactor): Added.
(WebKit::PDFViewController::setZoomFactor): Added.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::customRepresentationZoomFactor): Added. Calls through to the WKView.
(WebKit::PageClientImpl::setCustomRepresentationZoomFactor): Ditto.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _customRepresentationZoomFactor]): Added. Calls through to the PDFViewController.
(-[WKView _setCustomRepresentationZoomFactor:]): Ditto.

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/API/qt/qwkpage_p.h:

(QWKPagePrivate::customRepresentationZoomFactor): Added.
(QWKPagePrivate::setCustomRepresentationZoomFactor): Added.

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy): Coding style fix.
(WebKit::WebPageProxy::supportsTextZoom): Added. Returns false if the main frame has a custom
representation or is a standalone image, true otherwise.
(WebKit::WebPageProxy::setTextZoomFactor): Bail out if the main frame has a custom representation.
(WebKit::WebPageProxy::pageZoomFactor): If the main frame has a custom representation, get the
zoom factor from the page client.
(WebKit::WebPageProxy::setPageZoomFactor): If the main frame has a custom representation, have
the client set the zoom factor.
(WebKit::WebPageProxy::setPageAndTextZoomFactors): Ditto.

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::textZoomFactor): Changed to return 1 if the main frame has a custom
representation.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::customRepresentationZoomFactor): Added.
(WebKit::WebView::setCustomRepresentationZoomFactor): Added.

  • UIProcess/win/WebView.h:
3:21 PM Changeset in webkit [75330] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Fix QTMovieWin.vcproj to account for moving WebCore to Source\WebCore
https://bugs.webkit.org/show_bug.cgi?id=52114

Patch by Jeff Miller <jeffm@apple.com> on 2011-01-08
Rubber-stamped by Dan Bernstein.

  • WebCore.vcproj/QTMovieWin.vcproj:

Add an extra .. to some InheritedPropertySheets entries since WebCore is now one level deeper.

2:55 PM Changeset in webkit [75329] by chang.shu@nokia.com
  • 1 edit
    31 adds in trunk/LayoutTests

2011-01-08 Chang Shu <chang.shu@nokia.com>

Reviewed by Ryosuke Niwa.

Added test contents for contentEditable DOM attribute.
https://bugs.webkit.org/show_bug.cgi?id=51957

  • editing/editability: Added.
  • editing/editability/attr-empty-string-expected.txt: Added.
  • editing/editability/attr-empty-string.html: Added.
  • editing/editability/attr-false-string-expected.txt: Added.
  • editing/editability/attr-false-string.html: Added.
  • editing/editability/attr-invalid-string-expected.txt: Added.
  • editing/editability/attr-invalid-string.html: Added.
  • editing/editability/attr-missing-ancestor-false-expected.txt: Added.
  • editing/editability/attr-missing-ancestor-false.html: Added.
  • editing/editability/attr-missing-ancestor-true-expected.txt: Added.
  • editing/editability/attr-missing-ancestor-true.html: Added.
  • editing/editability/attr-missing-parent-ancestor-missing-expected.txt: Added.
  • editing/editability/attr-missing-parent-ancestor-missing.html: Added.
  • editing/editability/attr-missing-parent-false-expected.txt: Added.
  • editing/editability/attr-missing-parent-false.html: Added.
  • editing/editability/attr-missing-parent-true-expected.txt: Added.
  • editing/editability/attr-missing-parent-true.html: Added.
  • editing/editability/attr-true-string-expected.txt: Added.
  • editing/editability/attr-true-string.html: Added.
  • editing/editability/set-false-expected.txt: Added.
  • editing/editability/set-false.html: Added.
  • editing/editability/set-inherit-parent-false-expected.txt: Added.
  • editing/editability/set-inherit-parent-false.html: Added.
  • editing/editability/set-inherit-parent-true-expected.txt: Added.
  • editing/editability/set-inherit-parent-true.html: Added.
  • editing/editability/set-invalid-value-expected.txt: Added.
  • editing/editability/set-invalid-value.html: Added.
  • editing/editability/set-true-expected.txt: Added.
  • editing/editability/set-true.html: Added.
  • editing/editability/set-value-caseinsensitive-expected.txt: Added.
  • editing/editability/set-value-caseinsensitive.html: Added.
2:34 PM Changeset in webkit [75328] by eric@webkit.org
  • 3 edits in trunk/Tools

2011-01-08 Eric Seidel <eric@webkit.org>

Reviewed by Mihai Parparita.

commit-queue hangs when the ChangeLog diff is bad
https://bugs.webkit.org/show_bug.cgi?id=52072

  • Scripts/webkitpy/tool/steps/validatechangelogs.py:
  • Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
2:19 PM Changeset in webkit [75327] by mitz@apple.com
  • 3 edits in trunk/WebKit2

Add WKBundleFrameGetVisibleContentBounds().
https://bugs.webkit.org/show_bug.cgi?id=52089

Patch by Jeff Miller <jeffm@apple.com> on 2011-01-08
Reviewed by Jon Honeycutt.

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameGetVisibleContentBounds):

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h:

Added WKBundleFrameGetVisibleContentBounds().

2:17 PM Changeset in webkit [75326] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2011-01-08 Eric Seidel <eric@webkit.org>

Unreviewed.

Implement WebKit Full Screen support
https://bugs.webkit.org/show_bug.cgi?id=49481

Check in failing results for these tests to allow the bots to roll green.

  • fullscreen/full-screen-remove-ancestor-expected.txt:
  • fullscreen/full-screen-remove-expected.txt:
1:05 PM Changeset in webkit [75325] by krit@webkit.org
  • 22 edits in trunk/Source/WebCore

2011-01-08 Dirk Schulze <krit@webkit.org>

Reviewed by Mihai Parparita.

SVG rendering clean up according to the webkit style rules 2
https://bugs.webkit.org/show_bug.cgi?id=52112

Modified the style of the license of all files in WebCore/rendering/svg to match the style
in WebCore/svg. Cleaned up the code according to the webkit style rules.

No change of functionality. No test added.

  • rendering/svg/RenderSVGInline.cpp:
  • rendering/svg/RenderSVGInline.h:
  • rendering/svg/RenderSVGInlineText.cpp:
  • rendering/svg/RenderSVGInlineText.h:
  • rendering/svg/RenderSVGPath.cpp:
  • rendering/svg/RenderSVGPath.h:
  • rendering/svg/RenderSVGTSpan.cpp:
  • rendering/svg/RenderSVGTSpan.h:
  • rendering/svg/RenderSVGText.cpp:
  • rendering/svg/RenderSVGText.h:
  • rendering/svg/RenderSVGTextPath.cpp:
  • rendering/svg/RenderSVGTextPath.h:
  • rendering/svg/SVGInlineFlowBox.cpp:
  • rendering/svg/SVGInlineFlowBox.h:
  • rendering/svg/SVGInlineTextBox.cpp:
  • rendering/svg/SVGInlineTextBox.h:
  • rendering/svg/SVGRootInlineBox.cpp:
  • rendering/svg/SVGRootInlineBox.h:
  • rendering/svg/SVGTextLayoutEngineBaseline.cpp: Brace was misplaced accoring to check-webkit-style. (WebCore::SVGTextLayoutEngineBaseline::calculateGlyphOrientationAngle):
  • rendering/svg/SVGTextQuery.cpp:
  • rendering/svg/SVGTextQuery.h:
12:54 PM Changeset in webkit [75324] by krit@webkit.org
  • 63 edits in trunk/Source/WebCore

2011-01-08 Dirk Schulze <krit@webkit.org>

Reviewed by Mihai Parparita.

SVG rendering clean up according to the webkit style rules
https://bugs.webkit.org/show_bug.cgi?id=52107

Cleanup of the SVG rendering code according to the webbkit style rules.
Changed style of licensing texts to match the style in WebCore/svg, no change
of the licensing text itself.

  • rendering/RenderForeignObject.cpp:
  • rendering/RenderForeignObject.h:
  • rendering/RenderSVGBlock.cpp:
  • rendering/RenderSVGBlock.h:
  • rendering/RenderSVGContainer.cpp:
  • rendering/RenderSVGContainer.h:
  • rendering/RenderSVGGradientStop.cpp:
  • rendering/RenderSVGGradientStop.h:
  • rendering/RenderSVGHiddenContainer.cpp:
  • rendering/RenderSVGHiddenContainer.h: (WebCore::RenderSVGHiddenContainer::renderName): (WebCore::RenderSVGHiddenContainer::isSVGHiddenContainer): (WebCore::RenderSVGHiddenContainer::requiresLayer): (WebCore::RenderSVGHiddenContainer::clippedOverflowRectForRepaint):
  • rendering/RenderSVGImage.cpp:
  • rendering/RenderSVGImage.h:
  • rendering/RenderSVGModelObject.h:
  • rendering/RenderSVGResource.cpp:
  • rendering/RenderSVGResource.h:
  • rendering/RenderSVGResourceClipper.cpp:
  • rendering/RenderSVGResourceClipper.h:
  • rendering/RenderSVGResourceContainer.cpp:
  • rendering/RenderSVGResourceContainer.h:
  • rendering/RenderSVGResourceFilter.cpp:
  • rendering/RenderSVGResourceFilter.h:
  • rendering/RenderSVGResourceFilterPrimitive.cpp:
  • rendering/RenderSVGResourceFilterPrimitive.h:
  • rendering/RenderSVGResourceGradient.cpp:
  • rendering/RenderSVGResourceGradient.h:
  • rendering/RenderSVGResourceLinearGradient.cpp:
  • rendering/RenderSVGResourceLinearGradient.h:
  • rendering/RenderSVGResourceMarker.cpp:
  • rendering/RenderSVGResourceMarker.h:
  • rendering/RenderSVGResourceMasker.cpp:
  • rendering/RenderSVGResourceMasker.h:
  • rendering/RenderSVGResourcePattern.cpp:
  • rendering/RenderSVGResourcePattern.h:
  • rendering/RenderSVGResourceRadialGradient.cpp:
  • rendering/RenderSVGResourceRadialGradient.h:
  • rendering/RenderSVGResourceSolidColor.cpp:
  • rendering/RenderSVGResourceSolidColor.h:
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::nodeAtPoint):
  • rendering/RenderSVGRoot.h:
  • rendering/RenderSVGShadowTreeRootContainer.cpp:
  • rendering/RenderSVGShadowTreeRootContainer.h:
  • rendering/RenderSVGTransformableContainer.cpp: (WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
  • rendering/RenderSVGTransformableContainer.h: (WebCore::RenderSVGTransformableContainer::localToParentTransform): (WebCore::RenderSVGTransformableContainer::setNeedsTransformUpdate): (WebCore::RenderSVGTransformableContainer::localTransform):
  • rendering/RenderSVGViewportContainer.cpp:
  • rendering/RenderSVGViewportContainer.h:
  • rendering/SVGImageBufferTools.cpp:
  • rendering/SVGImageBufferTools.h:
  • rendering/SVGMarkerData.h:
  • rendering/SVGMarkerLayoutInfo.cpp:
  • rendering/SVGMarkerLayoutInfo.h:
  • rendering/SVGRenderSupport.cpp:
  • rendering/SVGRenderSupport.h:
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::operator<<):
  • rendering/SVGRenderTreeAsText.h:
  • rendering/SVGResources.cpp:
  • rendering/SVGResources.h:
  • rendering/SVGResourcesCache.cpp:
  • rendering/SVGResourcesCache.h:
  • rendering/SVGResourcesCycleSolver.cpp:
  • rendering/SVGResourcesCycleSolver.h:
  • rendering/SVGShadowTreeElements.cpp:
  • rendering/SVGShadowTreeElements.h:
11:11 AM Changeset in webkit [75323] by kbalazs@webkit.org
  • 2 edits in trunk/WebKit2

[Qt][WK2] QWKView does not propagate show and hide events to the drawing area
https://bugs.webkit.org/show_bug.cgi?id=52108

Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/API/qt/qgraphicswkview.cpp:

(QGraphicsWKView::event): Call setPageIsVisible on the drawing area
if the event is Show or Hide.

9:58 AM Changeset in webkit [75322] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-08 Mihai Parparita <mihaip@chromium.org>

Unreviewed; chromium test expectations update.

Remove failing expectations for tests that started to pass after
rebaselining in r75309.

  • platform/chromium/test_expectations.txt:
8:49 AM Changeset in webkit [75321] by tonikitoo@webkit.org
  • 1 edit
    5 adds in trunk/LayoutTests

2011-01-07 Antonio Gomes <agomes@rim.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Spatial Navigation: adding a test for when scrollbars are turned off via WebKit API
https://bugs.webkit.org/show_bug.cgi?id=51396

Add a layout test to ensure that page is scrollable when spatial
navgation is enabled even when scrollbars were disabled via WebKit
API (e.g. QWebFrame::setScrollBarPolicy).

Test is Qt-only for now since Qt's DRT is the only one that supports
LayoutTestController::setScrollbarPolicy.

In real world QtWebKit apps, scrollbars are disabled usually prior to
any page load. To emulate that on a layout test, it was added two html
files: one that set scrollbars off and queues the load of the real
test, and other that does the real testing.

  • platform/qt/fast/spatial-navigation/resources/ensure-scrolls-with-scrollbars-disabled-by-webkit.html: Added.
  • platform/qt/fast/spatial-navigation/snav-ensure-scrolls-with-scrollbars-disabled-by-webkit-expected.txt: Added.
  • platform/qt/fast/spatial-navigation/snav-ensure-scrolls-with-scrollbars-disabled-by-webkit.html: Added.
6:39 AM Changeset in webkit [75320] by Laszlo Gombos
  • 2 edits in trunk/WebKit2

2011-01-08 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt][Symbian] Make sure WebKit headers are included before platform headers on Symbian
https://bugs.webkit.org/show_bug.cgi?id=31273

On Symbian PREPEND_INCLUDEPATH is the best way to make sure that WebKit headers
are included before platform headers. On all other platforms continue to use
INCLUDEPATH (as before).

  • WebKit2.pro:
3:25 AM Changeset in webkit [75319] by Csaba Osztrogonác
  • 2 edits in trunk/WebKit2

[Qt][WK2] Unreviewed buildfix after r75313.

  • Scripts/generate-forwarding-headers.pl:
2:54 AM Changeset in webkit [75318] by abarth@webkit.org
  • 2 edits in trunk/WebKit2

2011-01-08 Adam Barth <abarth@webkit.org>

Moving WebCore changes the layout of the Qt build directory as well,
which means we need to change where we look for these generated files.

  • DerivedSources.pro:
2:32 AM Changeset in webkit [75317] by abarth@webkit.org
  • 2 edits in trunk/WebKit/chromium

2011-01-08 Adam Barth <abarth@webkit.org>

Update Chromium DEPS to pickup new GYP files.

  • DEPS:
2:10 AM Changeset in webkit [75316] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Try to fix the Leopard build.

  • WebView/WebFullScreenController.mm:
1:39 AM Changeset in webkit [75315] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-01-08 Adam Barth <abarth@webkit.org>

Teach svn-apply how to re-write WebCore to Source/WebCore.

  • Scripts/VCSUtils.pm:
1:36 AM Changeset in webkit [75314] by abarth@webkit.org
  • 1 move in trunk/Source/WebCore

Move WebCore into Source

1:35 AM Changeset in webkit [75313] by abarth@webkit.org
  • 65 edits in trunk

2011-01-07 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Move WebCore to Source
https://bugs.webkit.org/show_bug.cgi?id=52050

Remove reference to old directory.

  • PrettyPatch/PrettyPatch.rb:

2011-01-07 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Move WebCore to Source
https://bugs.webkit.org/show_bug.cgi?id=52050

Update references to WebCore.

  • WebKit.grd:
  • WebKit.gyp:

2011-01-07 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Move WebCore to Source
https://bugs.webkit.org/show_bug.cgi?id=52050

Update documentation to reference new location of WebCore.

  • docs/qtwebkit.qdoc:

2011-01-07 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Move WebCore to Source
https://bugs.webkit.org/show_bug.cgi?id=52050

  • GNUmakefile.am:

2011-01-07 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Move WebCore to Source
https://bugs.webkit.org/show_bug.cgi?id=52050

  • WebKit.vcproj/WebKit.sln:

2011-01-07 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Move WebCore to Source
https://bugs.webkit.org/show_bug.cgi?id=52050

  • bindings/python/wscript:
  • wscript:

2011-01-07 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Move WebCore to Source
https://bugs.webkit.org/show_bug.cgi?id=52050

Update project files to understand WebCore's new location. I suspect
there will be some follow-up patches after we land this patch.

  • Android.derived.jscbindings.mk:
  • Android.jscbindings.mk:
  • Android.v8bindings.mk:
  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/WebCoreGeneratedCairo.vsprops:
  • WebCore.vcproj/WebCoreGeneratedCommon.vsprops:

2011-01-07 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Move WebCore to Source
https://bugs.webkit.org/show_bug.cgi?id=52050

Update build files and metadata to point to WebCore's new location.

  • .gitattributes:
  • .gitignore:
  • Android.mk:
  • CMakeLists.txt:
  • DerivedSources.pro:
  • GNUmakefile.am:
  • Makefile:
  • Source/autotools/webkit.m4:
  • Source/cmake/OptionsEfl.cmake:
  • WebKit.pri:
  • WebKit.pro:
  • configure.ac:
  • wscript:

2011-01-07 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Move WebCore to Source
https://bugs.webkit.org/show_bug.cgi?id=52050

Update the tools to understand WebCore's new location.

  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • DumpRenderTree/wscript:
  • GNUmakefile.am:
  • Scripts/build-webkit:
  • Scripts/do-file-rename:
  • Scripts/do-webcore-rename:
  • Scripts/generate-qt-inspector-resource:
  • Scripts/prepare-ChangeLog:
  • Scripts/run-bindings-tests:
  • Scripts/update-iexploder-cssproperties:
  • Scripts/update-sources-list.py:
  • Scripts/update-webkit-localizable-strings:
  • Scripts/webkitdirs.pm:
  • Scripts/webkitpy/common/config/build.py:
  • Scripts/webkitpy/common/config/build_unittest.py:
  • Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
  • Scripts/webkitpy/style/checker.py:
  • Scripts/webkitpy/style/checker_unittest.py:
  • WebKitTestRunner/DerivedSources.pro:
  • WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
  • iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
  • wx/browser/wscript:
  • wx/build/settings.py:

2011-01-07 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Move WebCore to Source
https://bugs.webkit.org/show_bug.cgi?id=52050

  • WebKit2.pro:
1:18 AM Changeset in webkit [75312] by thakis@chromium.org
  • 4 edits in trunk/LayoutTests

2011-01-07 Nico Weber <thakis@chromium.org>

Unreviewed, test expectations.

Another baseline.
https://bugs.webkit.org/show_bug.cgi?id=52105

  • platform/chromium-linux/fast/gradients/css3-repeating-linear-gradients-expected.checksum:
  • platform/chromium-linux/fast/gradients/css3-repeating-linear-gradients-expected.png
12:44 AM Changeset in webkit [75311] by thakis@chromium.org
  • 738 edits
    4 adds in trunk

2011-01-07 Nico Weber <thakis@chromium.org>

Unreviewed, test expectations.

Many new baselines due to updated skia.
https://bugs.webkit.org/show_bug.cgi?id=52105

  • platform/chromium-linux/editing/pasteboard/4641033-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/4641033-expected.png:
  • platform/chromium-linux/editing/pasteboard/4944770-1-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/4944770-1-expected.png:
  • platform/chromium-linux/editing/pasteboard/4944770-2-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/4944770-2-expected.png:
  • platform/chromium-linux/editing/selection/3690703-2-expected.checksum:
  • platform/chromium-linux/editing/selection/3690703-2-expected.png:
  • platform/chromium-linux/editing/selection/3690703-expected.checksum:
  • platform/chromium-linux/editing/selection/3690703-expected.png:
  • platform/chromium-linux/editing/selection/3690719-expected.checksum:
  • platform/chromium-linux/editing/selection/3690719-expected.png:
  • platform/chromium-linux/editing/selection/4397952-expected.checksum:
  • platform/chromium-linux/editing/selection/4397952-expected.png:
  • platform/chromium-linux/editing/selection/5240265-expected.checksum:
  • platform/chromium-linux/editing/selection/5240265-expected.png:
  • platform/chromium-linux/editing/selection/caret-before-select-expected.checksum:
  • platform/chromium-linux/editing/selection/caret-before-select-expected.png:
  • platform/chromium-linux/editing/selection/replaced-boundaries-3-expected.checksum:
  • platform/chromium-linux/editing/selection/replaced-boundaries-3-expected.png:
  • platform/chromium-linux/editing/selection/select-box-expected.checksum:
  • platform/chromium-linux/editing/selection/select-box-expected.png:
  • platform/chromium-linux/editing/selection/select-element-paragraph-boundary-expected.checksum:
  • platform/chromium-linux/editing/selection/select-element-paragraph-boundary-expected.png:
  • platform/chromium-linux/editing/selection/transformed-selection-rects-expected.checksum:
  • platform/chromium-linux/editing/selection/transformed-selection-rects-expected.png:
  • platform/chromium-linux/fast/backgrounds/body-generated-image-propagated-to-root-expected.checksum:
  • platform/chromium-linux/fast/backgrounds/body-generated-image-propagated-to-root-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.checksum:
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-linux/fast/backgrounds/svg-as-background-2-expected.checksum: Added.
  • platform/chromium-linux/fast/backgrounds/svg-as-background-2-expected.png: Added.
  • platform/chromium-linux/fast/backgrounds/svg-as-background-5-expected.checksum:
  • platform/chromium-linux/fast/backgrounds/svg-as-background-5-expected.png:
  • platform/chromium-linux/fast/block/float/float-avoidance-expected.checksum:
  • platform/chromium-linux/fast/block/float/float-avoidance-expected.png:
  • platform/chromium-linux/fast/block/margin-collapse/103-expected.checksum:
  • platform/chromium-linux/fast/block/margin-collapse/103-expected.png:
  • platform/chromium-linux/fast/block/positioning/inline-block-relposition-expected.checksum:
  • platform/chromium-linux/fast/block/positioning/inline-block-relposition-expected.png:
  • platform/chromium-linux/fast/canvas/canvas-text-alignment-expected.checksum:
  • platform/chromium-linux/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-linux/fast/canvas/fillrect_gradient-expected.checksum:
  • platform/chromium-linux/fast/canvas/fillrect_gradient-expected.png:
  • platform/chromium-linux/fast/css/continuationCrash-expected.checksum:
  • platform/chromium-linux/fast/css/continuationCrash-expected.png:
  • platform/chromium-linux/fast/css/margin-top-bottom-dynamic-expected.checksum:
  • platform/chromium-linux/fast/css/margin-top-bottom-dynamic-expected.png:
  • platform/chromium-linux/fast/css/rtl-ordering-expected.checksum:
  • platform/chromium-linux/fast/css/rtl-ordering-expected.png:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-expected.checksum:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/chromium-linux/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.checksum:
  • platform/chromium-linux/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
  • platform/chromium-linux/fast/dom/HTMLTextAreaElement/reset-textarea-expected.checksum:
  • platform/chromium-linux/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
  • platform/chromium-linux/fast/forms/003-expected.checksum:
  • platform/chromium-linux/fast/forms/003-expected.png:
  • platform/chromium-linux/fast/forms/004-expected.checksum:
  • platform/chromium-linux/fast/forms/004-expected.png:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label01-expected.checksum:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label01-expected.png:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label02-expected.checksum:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label02-expected.png:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label03-expected.checksum:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label03-expected.png:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label04-expected.checksum:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label04-expected.png:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label06-expected.checksum:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label06-expected.png:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label07-expected.checksum:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label07-expected.png:
  • platform/chromium-linux/fast/forms/basic-buttons-expected.checksum:
  • platform/chromium-linux/fast/forms/basic-buttons-expected.png:
  • platform/chromium-linux/fast/forms/basic-selects-expected.checksum:
  • platform/chromium-linux/fast/forms/basic-selects-expected.png:
  • platform/chromium-linux/fast/forms/blankbuttons-expected.checksum:
  • platform/chromium-linux/fast/forms/blankbuttons-expected.png:
  • platform/chromium-linux/fast/forms/box-shadow-override-expected.checksum:
  • platform/chromium-linux/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-linux/fast/forms/button-align-expected.checksum:
  • platform/chromium-linux/fast/forms/button-align-expected.png:
  • platform/chromium-linux/fast/forms/button-cannot-be-nested-expected.checksum:
  • platform/chromium-linux/fast/forms/button-cannot-be-nested-expected.png:
  • platform/chromium-linux/fast/forms/button-generated-content-expected.checksum:
  • platform/chromium-linux/fast/forms/button-generated-content-expected.png:
  • platform/chromium-linux/fast/forms/button-inner-block-reuse-expected.checksum:
  • platform/chromium-linux/fast/forms/button-inner-block-reuse-expected.png:
  • platform/chromium-linux/fast/forms/button-positioned-expected.checksum:
  • platform/chromium-linux/fast/forms/button-positioned-expected.png:
  • platform/chromium-linux/fast/forms/button-sizes-expected.checksum:
  • platform/chromium-linux/fast/forms/button-sizes-expected.png:
  • platform/chromium-linux/fast/forms/button-style-color-expected.checksum:
  • platform/chromium-linux/fast/forms/button-style-color-expected.png:
  • platform/chromium-linux/fast/forms/button-table-styles-expected.checksum:
  • platform/chromium-linux/fast/forms/button-table-styles-expected.png:
  • platform/chromium-linux/fast/forms/button-text-transform-expected.checksum:
  • platform/chromium-linux/fast/forms/button-text-transform-expected.png:
  • platform/chromium-linux/fast/forms/button-white-space-expected.checksum:
  • platform/chromium-linux/fast/forms/button-white-space-expected.png:
  • platform/chromium-linux/fast/forms/control-clip-overflow-expected.checksum:
  • platform/chromium-linux/fast/forms/control-clip-overflow-expected.png:
  • platform/chromium-linux/fast/forms/control-restrict-line-height-expected.checksum:
  • platform/chromium-linux/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-linux/fast/forms/disabled-select-change-index-expected.checksum:
  • platform/chromium-linux/fast/forms/disabled-select-change-index-expected.png:
  • platform/chromium-linux/fast/forms/file-input-direction-expected.checksum:
  • platform/chromium-linux/fast/forms/file-input-direction-expected.png:
  • platform/chromium-linux/fast/forms/file-input-disabled-expected.checksum:
  • platform/chromium-linux/fast/forms/file-input-disabled-expected.png:
  • platform/chromium-linux/fast/forms/form-element-geometry-expected.checksum:
  • platform/chromium-linux/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-linux/fast/forms/formmove3-expected.checksum:
  • platform/chromium-linux/fast/forms/formmove3-expected.png:
  • platform/chromium-linux/fast/forms/input-appearance-height-expected.checksum:
  • platform/chromium-linux/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-linux/fast/forms/input-button-sizes-expected.checksum:
  • platform/chromium-linux/fast/forms/input-button-sizes-expected.png:
  • platform/chromium-linux/fast/forms/input-file-re-render-expected.checksum:
  • platform/chromium-linux/fast/forms/input-file-re-render-expected.png:
  • platform/chromium-linux/fast/forms/input-value-expected.checksum:
  • platform/chromium-linux/fast/forms/input-value-expected.png:
  • platform/chromium-linux/fast/forms/menulist-deselect-update-expected.checksum:
  • platform/chromium-linux/fast/forms/menulist-deselect-update-expected.png:
  • platform/chromium-linux/fast/forms/menulist-no-overflow-expected.checksum:
  • platform/chromium-linux/fast/forms/menulist-no-overflow-expected.png:
  • platform/chromium-linux/fast/forms/menulist-restrict-line-height-expected.checksum:
  • platform/chromium-linux/fast/forms/menulist-restrict-line-height-expected.png:
  • platform/chromium-linux/fast/forms/menulist-separator-painting-expected.checksum:
  • platform/chromium-linux/fast/forms/menulist-separator-painting-expected.png:
  • platform/chromium-linux/fast/forms/menulist-style-color-expected.checksum:
  • platform/chromium-linux/fast/forms/menulist-style-color-expected.png:
  • platform/chromium-linux/fast/forms/menulist-width-change-expected.checksum:
  • platform/chromium-linux/fast/forms/menulist-width-change-expected.png:
  • platform/chromium-linux/fast/forms/option-script-expected.checksum:
  • platform/chromium-linux/fast/forms/option-script-expected.png:
  • platform/chromium-linux/fast/forms/option-strip-whitespace-expected.checksum:
  • platform/chromium-linux/fast/forms/option-strip-whitespace-expected.png:
  • platform/chromium-linux/fast/forms/option-text-clip-expected.checksum:
  • platform/chromium-linux/fast/forms/option-text-clip-expected.png:
  • platform/chromium-linux/fast/forms/placeholder-position-expected.checksum:
  • platform/chromium-linux/fast/forms/placeholder-position-expected.png:
  • platform/chromium-linux/fast/forms/select-align-expected.checksum:
  • platform/chromium-linux/fast/forms/select-align-expected.png:
  • platform/chromium-linux/fast/forms/select-baseline-expected.checksum:
  • platform/chromium-linux/fast/forms/select-baseline-expected.png:
  • platform/chromium-linux/fast/forms/select-change-listbox-to-popup-expected.checksum:
  • platform/chromium-linux/fast/forms/select-change-listbox-to-popup-expected.png:
  • platform/chromium-linux/fast/forms/select-disabled-appearance-expected.checksum:
  • platform/chromium-linux/fast/forms/select-disabled-appearance-expected.png:
  • platform/chromium-linux/fast/forms/select-selected-expected.checksum:
  • platform/chromium-linux/fast/forms/select-selected-expected.png:
  • platform/chromium-linux/fast/forms/select-size-expected.checksum:
  • platform/chromium-linux/fast/forms/select-size-expected.png:
  • platform/chromium-linux/fast/forms/stuff-on-my-optgroup-expected.checksum:
  • platform/chromium-linux/fast/forms/stuff-on-my-optgroup-expected.png:
  • platform/chromium-linux/fast/forms/targeted-frame-submission-expected.checksum:
  • platform/chromium-linux/fast/forms/targeted-frame-submission-expected.png:
  • platform/chromium-linux/fast/gradients/background-clipped-expected.checksum:
  • platform/chromium-linux/fast/gradients/background-clipped-expected.png:
  • platform/chromium-linux/fast/gradients/border-image-gradient-sides-and-corners-expected.checksum: Added.
  • platform/chromium-linux/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Added.
  • platform/chromium-linux/fast/gradients/crash-on-zero-radius-expected.checksum:
  • platform/chromium-linux/fast/gradients/crash-on-zero-radius-expected.png:
  • platform/chromium-linux/fast/gradients/generated-gradients-expected.checksum:
  • platform/chromium-linux/fast/gradients/generated-gradients-expected.png:
  • platform/chromium-linux/fast/gradients/gradient-after-transparent-border-expected.checksum:
  • platform/chromium-linux/fast/gradients/gradient-after-transparent-border-expected.png:
  • platform/chromium-linux/fast/gradients/list-item-gradient-expected.checksum:
  • platform/chromium-linux/fast/gradients/list-item-gradient-expected.png:
  • platform/chromium-linux/fast/gradients/radial-centered-expected.checksum:
  • platform/chromium-linux/fast/gradients/radial-centered-expected.png:
  • platform/chromium-linux/fast/gradients/simple-gradients-expected.checksum:
  • platform/chromium-linux/fast/gradients/simple-gradients-expected.png:
  • platform/chromium-linux/fast/images/animated-svg-as-image-expected.checksum:
  • platform/chromium-linux/fast/images/animated-svg-as-image-expected.png:
  • platform/chromium-linux/fast/invalid/014-expected.checksum:
  • platform/chromium-linux/fast/invalid/014-expected.png:
  • platform/chromium-linux/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.checksum:
  • platform/chromium-linux/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
  • platform/chromium-linux/fast/parser/document-write-option-expected.checksum:
  • platform/chromium-linux/fast/parser/document-write-option-expected.png:
  • platform/chromium-linux/fast/repaint/control-clip-expected.checksum:
  • platform/chromium-linux/fast/repaint/control-clip-expected.png:
  • platform/chromium-linux/fast/repaint/reflection-repaint-test-expected.checksum:
  • platform/chromium-linux/fast/repaint/reflection-repaint-test-expected.png:
  • platform/chromium-linux/fast/repaint/transform-layout-repaint-expected.checksum:
  • platform/chromium-linux/fast/repaint/transform-layout-repaint-expected.png:
  • platform/chromium-linux/fast/replaced/replaced-breaking-expected.checksum:
  • platform/chromium-linux/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-linux/fast/replaced/replaced-breaking-mixture-expected.checksum:
  • platform/chromium-linux/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/chromium-linux/fast/replaced/three-selects-break-expected.checksum:
  • platform/chromium-linux/fast/replaced/three-selects-break-expected.png:
  • platform/chromium-linux/fast/replaced/width100percent-button-expected.checksum:
  • platform/chromium-linux/fast/replaced/width100percent-button-expected.png:
  • platform/chromium-linux/fast/selectors/064-expected.checksum:
  • platform/chromium-linux/fast/selectors/064-expected.png:
  • platform/chromium-linux/fast/table/append-cells2-expected.checksum:
  • platform/chromium-linux/fast/table/append-cells2-expected.png:
  • platform/chromium-linux/fast/table/remove-td-display-none-expected.checksum:
  • platform/chromium-linux/fast/table/remove-td-display-none-expected.png:
  • platform/chromium-linux/fast/text/international/bidi-menulist-expected.checksum:
  • platform/chromium-linux/fast/text/international/bidi-menulist-expected.png:
  • platform/chromium-linux/fast/text/international/hindi-spacing-expected.checksum:
  • platform/chromium-linux/fast/text/international/hindi-spacing-expected.png:
  • platform/chromium-linux/fast/text/textIteratorNilRenderer-expected.checksum:
  • platform/chromium-linux/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-linux/fast/transforms/shadows-expected.checksum:
  • platform/chromium-linux/fast/transforms/shadows-expected.png:
  • platform/chromium-linux/fast/transforms/transform-on-inline-expected.checksum:
  • platform/chromium-linux/fast/transforms/transform-on-inline-expected.png:
  • platform/chromium-linux/fast/transforms/transform-table-row-expected.checksum:
  • platform/chromium-linux/fast/transforms/transform-table-row-expected.png:
  • platform/chromium-linux/fast/transforms/transformed-caret-expected.checksum:
  • platform/chromium-linux/fast/transforms/transformed-caret-expected.png:
  • platform/chromium-linux/fast/transforms/transformed-document-element-expected.checksum:
  • platform/chromium-linux/fast/transforms/transformed-document-element-expected.png:
  • platform/chromium-linux/media/audio-controls-rendering-expected.checksum:
  • platform/chromium-linux/media/audio-controls-rendering-expected.png:
  • platform/chromium-linux/media/controls-after-reload-expected.checksum:
  • platform/chromium-linux/media/controls-after-reload-expected.png:
  • platform/chromium-linux/media/controls-strict-expected.checksum:
  • platform/chromium-linux/media/controls-strict-expected.png:
  • platform/chromium-linux/media/controls-styling-expected.checksum:
  • platform/chromium-linux/media/controls-styling-expected.png:
  • platform/chromium-linux/media/controls-without-preload-expected.checksum:
  • platform/chromium-linux/media/controls-without-preload-expected.png:
  • platform/chromium-linux/media/video-controls-rendering-expected.checksum:
  • platform/chromium-linux/media/video-controls-rendering-expected.png:
  • platform/chromium-linux/media/video-no-audio-expected.checksum:
  • platform/chromium-linux/media/video-no-audio-expected.png:
  • platform/chromium-linux/media/video-volume-slider-expected.checksum:
  • platform/chromium-linux/media/video-volume-slider-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/color-prop-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/color-prop-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-units-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-mask-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-render-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-render-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-path-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-path-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-07-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-07-t-expected.png:
  • platform/chromium-linux/svg/batik/filters/feTile-expected.checksum:
  • platform/chromium-linux/svg/batik/filters/feTile-expected.png:
  • platform/chromium-linux/svg/batik/paints/patternRegions-expected.checksum:
  • platform/chromium-linux/svg/batik/paints/patternRegions-expected.png:
  • platform/chromium-linux/svg/batik/paints/patternRegions-positioned-objects-expected.checksum:
  • platform/chromium-linux/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/chromium-linux/svg/batik/text/textEffect-expected.checksum:
  • platform/chromium-linux/svg/batik/text/textEffect-expected.png:
  • platform/chromium-linux/svg/batik/text/textEffect2-expected.checksum:
  • platform/chromium-linux/svg/batik/text/textEffect2-expected.png:
  • platform/chromium-linux/svg/batik/text/textEffect3-expected.checksum:
  • platform/chromium-linux/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-linux/svg/batik/text/textGlyphOrientationHorizontal-expected.checksum:
  • platform/chromium-linux/svg/batik/text/textGlyphOrientationHorizontal-expected.png:
  • platform/chromium-linux/svg/batik/text/textLayout2-expected.checksum:
  • platform/chromium-linux/svg/batik/text/textLayout2-expected.png:
  • platform/chromium-linux/svg/batik/text/textOnPath-expected.checksum:
  • platform/chromium-linux/svg/batik/text/textOnPath-expected.png:
  • platform/chromium-linux/svg/batik/text/textOnPath2-expected.checksum:
  • platform/chromium-linux/svg/batik/text/textOnPath2-expected.png:
  • platform/chromium-linux/svg/batik/text/textOnPath3-expected.checksum:
  • platform/chromium-linux/svg/batik/text/textOnPath3-expected.png:
  • platform/chromium-linux/svg/batik/text/textOnPathSpaces-expected.checksum:
  • platform/chromium-linux/svg/batik/text/textOnPathSpaces-expected.png:
  • platform/chromium-linux/svg/batik/text/textProperties-expected.checksum:
  • platform/chromium-linux/svg/batik/text/textProperties-expected.png:
  • platform/chromium-linux/svg/batik/text/verticalTextOnPath-expected.checksum:
  • platform/chromium-linux/svg/batik/text/verticalTextOnPath-expected.png:
  • platform/chromium-linux/svg/css/circle-in-mask-with-shadow-expected.checksum:
  • platform/chromium-linux/svg/css/circle-in-mask-with-shadow-expected.png:
  • platform/chromium-linux/svg/css/composite-shadow-text-expected.checksum:
  • platform/chromium-linux/svg/css/composite-shadow-text-expected.png:
  • platform/chromium-linux/svg/css/group-with-shadow-expected.checksum:
  • platform/chromium-linux/svg/css/group-with-shadow-expected.png:
  • platform/chromium-linux/svg/css/mask-with-shadow-expected.checksum:
  • platform/chromium-linux/svg/css/mask-with-shadow-expected.png:
  • platform/chromium-linux/svg/custom/dominant-baseline-hanging-expected.checksum:
  • platform/chromium-linux/svg/custom/dominant-baseline-hanging-expected.png:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Discrete-expected.checksum:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Gamma-expected.checksum:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Linear-expected.checksum:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Table-expected.checksum:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/chromium-linux/svg/custom/gradient-cycle-detection-expected.checksum:
  • platform/chromium-linux/svg/custom/gradient-cycle-detection-expected.png:
  • platform/chromium-linux/svg/custom/gradient-deep-referencing-expected.checksum:
  • platform/chromium-linux/svg/custom/gradient-deep-referencing-expected.png:
  • platform/chromium-linux/svg/custom/gradient-rotated-bbox-expected.checksum:
  • platform/chromium-linux/svg/custom/gradient-rotated-bbox-expected.png:
  • platform/chromium-linux/svg/custom/gradient-stroke-width-expected.checksum:
  • platform/chromium-linux/svg/custom/gradient-stroke-width-expected.png:
  • platform/chromium-linux/svg/custom/gradient-with-1d-boundingbox-expected.checksum:
  • platform/chromium-linux/svg/custom/gradient-with-1d-boundingbox-expected.png:
  • platform/chromium-linux/svg/custom/inline-svg-in-xhtml-expected.checksum:
  • platform/chromium-linux/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-linux/svg/custom/js-late-gradient-and-object-creation-expected.checksum:
  • platform/chromium-linux/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/chromium-linux/svg/custom/js-late-gradient-creation-expected.checksum:
  • platform/chromium-linux/svg/custom/js-late-gradient-creation-expected.png:
  • platform/chromium-linux/svg/custom/js-late-pattern-and-object-creation-expected.checksum:
  • platform/chromium-linux/svg/custom/js-late-pattern-and-object-creation-expected.png:
  • platform/chromium-linux/svg/custom/linking-a-03-b-transform-expected.checksum:
  • platform/chromium-linux/svg/custom/linking-a-03-b-transform-expected.png:
  • platform/chromium-linux/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.checksum:
  • platform/chromium-linux/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png:
  • platform/chromium-linux/svg/custom/recursive-gradient-expected.checksum:
  • platform/chromium-linux/svg/custom/recursive-gradient-expected.png:
  • platform/chromium-linux/svg/custom/relative-sized-content-with-resources-expected.checksum:
  • platform/chromium-linux/svg/custom/relative-sized-content-with-resources-expected.png:
  • platform/chromium-linux/svg/custom/stroke-width-large-expected.checksum:
  • platform/chromium-linux/svg/custom/stroke-width-large-expected.png:
  • platform/chromium-linux/svg/custom/stroked-pattern-expected.checksum:
  • platform/chromium-linux/svg/custom/stroked-pattern-expected.png:
  • platform/chromium-linux/svg/custom/text-linking-expected.checksum:
  • platform/chromium-linux/svg/custom/text-linking-expected.png:
  • platform/chromium-linux/svg/custom/text-rotation-expected.checksum:
  • platform/chromium-linux/svg/custom/text-rotation-expected.png:
  • platform/chromium-linux/svg/custom/use-detach-expected.checksum:
  • platform/chromium-linux/svg/custom/use-detach-expected.png:
  • platform/chromium-linux/svg/custom/use-on-disallowed-foreign-object-1-expected.checksum:
  • platform/chromium-linux/svg/custom/use-on-disallowed-foreign-object-1-expected.png:
  • platform/chromium-linux/svg/custom/use-on-disallowed-foreign-object-2-expected.checksum:
  • platform/chromium-linux/svg/custom/use-on-disallowed-foreign-object-2-expected.png:
  • platform/chromium-linux/svg/custom/use-on-disallowed-foreign-object-4-expected.checksum:
  • platform/chromium-linux/svg/custom/use-on-disallowed-foreign-object-4-expected.png:
  • platform/chromium-linux/svg/custom/use-on-disallowed-foreign-object-5-expected.checksum:
  • platform/chromium-linux/svg/custom/use-on-disallowed-foreign-object-5-expected.png:
  • platform/chromium-linux/svg/custom/use-on-disallowed-foreign-object-6-expected.checksum:
  • platform/chromium-linux/svg/custom/use-on-disallowed-foreign-object-6-expected.png:
  • platform/chromium-linux/svg/custom/use-on-non-svg-namespaced-element-expected.checksum:
  • platform/chromium-linux/svg/custom/use-on-non-svg-namespaced-element-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.png:
  • platform/chromium-linux/svg/text/selection-background-color-expected.checksum:
  • platform/chromium-linux/svg/text/selection-background-color-expected.png:
  • platform/chromium-linux/svg/text/selection-styles-expected.checksum:
  • platform/chromium-linux/svg/text/selection-styles-expected.png:
  • platform/chromium-linux/svg/text/text-deco-01-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-deco-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-path-01-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-path-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-text-07-t-expected.checksum:
  • platform/chromium-linux/svg/text/text-text-07-t-expected.png:
  • platform/chromium-linux/svg/text/text-text-08-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-text-08-b-expected.png:
  • platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.checksum:
  • platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.checksum:
  • platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-foreignObject-expected.checksum:
  • platform/chromium-linux/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-mask-with-percentages-expected.checksum:
  • platform/chromium-linux/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-linux/svg/zoom/text/zoom-foreignObject-expected.checksum:
  • platform/chromium-linux/svg/zoom/text/zoom-foreignObject-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug138725-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug138725-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug18359-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug26178-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug26178-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug28928-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug29326-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug29326-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug33855-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug33855-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug39209-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug39209-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4382-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug4382-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4429-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug4429-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug44505-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug44505-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug46368-1-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug46368-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug51037-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug51727-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug51727-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug52505-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug52505-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug52506-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug52506-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug60749-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug60749-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug68912-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug68912-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug7342-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug92647-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug92647-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.png:
  • platform/chromium-linux/tables/mozilla/collapsing_borders/bug41262-4-expected.checksum:
  • platform/chromium-linux/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/chromium-linux/tables/mozilla/core/margins-expected.checksum:
  • platform/chromium-linux/tables/mozilla/core/margins-expected.png:
  • platform/chromium-linux/tables/mozilla/dom/tableDom-expected.checksum:
  • platform/chromium-linux/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-linux/tables/mozilla/other/move_row-expected.checksum:
  • platform/chromium-linux/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1725-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug58402-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
  • platform/chromium-linux/transforms/2d/hindi-rotated-expected.checksum:
  • platform/chromium-linux/transforms/2d/hindi-rotated-expected.png:
  • platform/chromium-linux/transforms/2d/zoom-menulist-expected.checksum:
  • platform/chromium-linux/transforms/2d/zoom-menulist-expected.png:
  • platform/chromium-win/fast/backgrounds/body-generated-image-propagated-to-root-expected.checksum:
  • platform/chromium-win/fast/backgrounds/body-generated-image-propagated-to-root-expected.png:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-win/fast/backgrounds/svg-as-background-2-expected.checksum:
  • platform/chromium-win/fast/backgrounds/svg-as-background-2-expected.png:
  • platform/chromium-win/fast/canvas/canvas-text-alignment-expected.checksum:
  • platform/chromium-win/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-win/fast/canvas/fillrect_gradient-expected.checksum:
  • platform/chromium-win/fast/canvas/fillrect_gradient-expected.png:
  • platform/chromium-win/fast/canvas/gradient-add-second-start-end-stop-expected.checksum:
  • platform/chromium-win/fast/canvas/gradient-add-second-start-end-stop-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.checksum:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.checksum:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/chromium-win/fast/gradients/background-clipped-expected.checksum:
  • platform/chromium-win/fast/gradients/background-clipped-expected.png:
  • platform/chromium-win/fast/gradients/border-image-gradient-expected.checksum:
  • platform/chromium-win/fast/gradients/border-image-gradient-expected.png:
  • platform/chromium-win/fast/gradients/border-image-gradient-sides-and-corners-expected.checksum:
  • platform/chromium-win/fast/gradients/border-image-gradient-sides-and-corners-expected.png:
  • platform/chromium-win/fast/gradients/crash-on-zero-radius-expected.checksum:
  • platform/chromium-win/fast/gradients/crash-on-zero-radius-expected.png:
  • platform/chromium-win/fast/gradients/css3-repeating-linear-gradients-expected.checksum:
  • platform/chromium-win/fast/gradients/css3-repeating-linear-gradients-expected.png:
  • platform/chromium-win/fast/gradients/generated-gradients-expected.checksum:
  • platform/chromium-win/fast/gradients/generated-gradients-expected.png:
  • platform/chromium-win/fast/gradients/gradient-after-transparent-border-expected.checksum:
  • platform/chromium-win/fast/gradients/gradient-after-transparent-border-expected.png:
  • platform/chromium-win/fast/gradients/list-item-gradient-expected.checksum:
  • platform/chromium-win/fast/gradients/list-item-gradient-expected.png:
  • platform/chromium-win/fast/gradients/radial-centered-expected.checksum:
  • platform/chromium-win/fast/gradients/radial-centered-expected.png:
  • platform/chromium-win/fast/gradients/simple-gradients-expected.checksum:
  • platform/chromium-win/fast/gradients/simple-gradients-expected.png:
  • platform/chromium-win/fast/reflections/reflection-masks-expected.checksum:
  • platform/chromium-win/fast/reflections/reflection-masks-expected.png:
  • platform/chromium-win/fast/repaint/background-generated-expected.checksum:
  • platform/chromium-win/fast/repaint/background-generated-expected.png:
  • platform/chromium-win/media/audio-controls-rendering-expected.checksum:
  • platform/chromium-win/media/audio-controls-rendering-expected.png:
  • platform/chromium-win/media/controls-after-reload-expected.checksum:
  • platform/chromium-win/media/controls-after-reload-expected.png:
  • platform/chromium-win/media/controls-strict-expected.checksum:
  • platform/chromium-win/media/controls-strict-expected.png:
  • platform/chromium-win/media/controls-styling-expected.checksum:
  • platform/chromium-win/media/controls-styling-expected.png:
  • platform/chromium-win/media/controls-without-preload-expected.checksum:
  • platform/chromium-win/media/controls-without-preload-expected.png:
  • platform/chromium-win/media/video-controls-rendering-expected.checksum:
  • platform/chromium-win/media/video-controls-rendering-expected.png:
  • platform/chromium-win/media/video-no-audio-expected.checksum:
  • platform/chromium-win/media/video-no-audio-expected.png:
  • platform/chromium-win/media/video-volume-slider-expected.checksum:
  • platform/chromium-win/media/video-volume-slider-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/color-prop-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/color-prop-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-units-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-render-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-render-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.png:
  • platform/chromium-win/svg/batik/filters/feTile-expected.checksum:
  • platform/chromium-win/svg/batik/filters/feTile-expected.png:
  • platform/chromium-win/svg/batik/paints/patternRegions-expected.checksum:
  • platform/chromium-win/svg/batik/paints/patternRegions-expected.png:
  • platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.checksum:
  • platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/chromium-win/svg/batik/text/textEffect-expected.checksum:
  • platform/chromium-win/svg/batik/text/textEffect-expected.png:
  • platform/chromium-win/svg/batik/text/textEffect2-expected.checksum:
  • platform/chromium-win/svg/batik/text/textEffect2-expected.png:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.checksum:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-win/svg/batik/text/textProperties-expected.checksum:
  • platform/chromium-win/svg/batik/text/textProperties-expected.png:
  • platform/chromium-win/svg/carto.net/colourpicker-expected.checksum:
  • platform/chromium-win/svg/carto.net/colourpicker-expected.png:
  • platform/chromium-win/svg/css/circle-in-mask-with-shadow-expected.checksum:
  • platform/chromium-win/svg/css/circle-in-mask-with-shadow-expected.png:
  • platform/chromium-win/svg/css/composite-shadow-text-expected.checksum:
  • platform/chromium-win/svg/css/composite-shadow-text-expected.png:
  • platform/chromium-win/svg/css/mask-with-shadow-expected.checksum:
  • platform/chromium-win/svg/css/mask-with-shadow-expected.png:
  • platform/chromium-win/svg/custom/dominant-baseline-hanging-expected.checksum:
  • platform/chromium-win/svg/custom/dominant-baseline-hanging-expected.png:
  • platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.checksum:
  • platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.checksum:
  • platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.checksum:
  • platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.checksum:
  • platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/chromium-win/svg/custom/gradient-cycle-detection-expected.checksum:
  • platform/chromium-win/svg/custom/gradient-cycle-detection-expected.png:
  • platform/chromium-win/svg/custom/gradient-deep-referencing-expected.checksum:
  • platform/chromium-win/svg/custom/gradient-deep-referencing-expected.png:
  • platform/chromium-win/svg/custom/gradient-rotated-bbox-expected.checksum:
  • platform/chromium-win/svg/custom/gradient-rotated-bbox-expected.png:
  • platform/chromium-win/svg/custom/gradient-stop-corner-cases-expected.checksum:
  • platform/chromium-win/svg/custom/gradient-stop-corner-cases-expected.png:
  • platform/chromium-win/svg/custom/gradient-stroke-width-expected.checksum:
  • platform/chromium-win/svg/custom/gradient-stroke-width-expected.png:
  • platform/chromium-win/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.checksum:
  • platform/chromium-win/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.png:
  • platform/chromium-win/svg/custom/gradient-with-1d-boundingbox-expected.checksum:
  • platform/chromium-win/svg/custom/gradient-with-1d-boundingbox-expected.png:
  • platform/chromium-win/svg/custom/group-opacity-expected.checksum:
  • platform/chromium-win/svg/custom/group-opacity-expected.png:
  • platform/chromium-win/svg/custom/inline-svg-in-xhtml-expected.checksum:
  • platform/chromium-win/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-win/svg/custom/js-late-gradient-and-object-creation-expected.checksum:
  • platform/chromium-win/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/chromium-win/svg/custom/js-late-gradient-creation-expected.checksum:
  • platform/chromium-win/svg/custom/js-late-gradient-creation-expected.png:
  • platform/chromium-win/svg/custom/js-update-gradient-expected.checksum:
  • platform/chromium-win/svg/custom/js-update-gradient-expected.png:
  • platform/chromium-win/svg/custom/js-update-stop-expected.checksum:
  • platform/chromium-win/svg/custom/js-update-stop-expected.png:
  • platform/chromium-win/svg/custom/large-bounding-box-percents-expected.checksum:
  • platform/chromium-win/svg/custom/large-bounding-box-percents-expected.png:
  • platform/chromium-win/svg/custom/non-scaling-stroke-expected.checksum:
  • platform/chromium-win/svg/custom/non-scaling-stroke-expected.png:
  • platform/chromium-win/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.checksum:
  • platform/chromium-win/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png:
  • platform/chromium-win/svg/custom/recursive-gradient-expected.checksum:
  • platform/chromium-win/svg/custom/recursive-gradient-expected.png:
  • platform/chromium-win/svg/custom/relative-sized-content-with-resources-expected.checksum:
  • platform/chromium-win/svg/custom/relative-sized-content-with-resources-expected.png:
  • platform/chromium-win/svg/custom/stroked-pattern-expected.checksum:
  • platform/chromium-win/svg/custom/stroked-pattern-expected.png:
  • platform/chromium-win/svg/custom/text-rotated-gradient-expected.checksum:
  • platform/chromium-win/svg/custom/text-rotated-gradient-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.png:
  • platform/chromium-win/svg/filters/big-sized-filter-expected.checksum:
  • platform/chromium-win/svg/filters/big-sized-filter-expected.png:
  • platform/chromium-win/svg/filters/feTile-expected.checksum:
  • platform/chromium-win/svg/filters/feTile-expected.png:
  • platform/chromium-win/svg/text/selection-background-color-expected.checksum:
  • platform/chromium-win/svg/text/selection-background-color-expected.png:
  • platform/chromium-win/svg/text/selection-styles-expected.checksum:
  • platform/chromium-win/svg/text/selection-styles-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.checksum:
  • platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.png:

Jan 7, 2011:

11:37 PM Changeset in webkit [75310] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-07 Adam Barth <abarth@webkit.org>

Record expectation for test.

  • platform/chromium/test_expectations.txt:
8:38 PM Changeset in webkit [75309] by mihaip@chromium.org
  • 37 edits in trunk/LayoutTests

2011-01-07 Mihai Parparita <mihaip@chromium.org>

Unreviewed, test expectation update.

Update mac-leopard baselines for tests that currently have up to date
Snow Leopard baselines in platform/mac.

  • platform/mac-leopard/fast/css/text-overflow-ellipsis-strict-expected.checksum:
  • platform/mac-leopard/fast/css/text-overflow-ellipsis-strict-expected.png:
  • platform/mac-leopard/fast/invalid/residual-style-expected.checksum:
  • platform/mac-leopard/fast/invalid/residual-style-expected.png:
  • platform/mac-leopard/fast/multicol/span/span-as-immediate-child-generated-content-expected.checksum:
  • platform/mac-leopard/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/mac-leopard/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum:
  • platform/mac-leopard/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/mac-leopard/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.checksum:
  • platform/mac-leopard/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
  • platform/mac-leopard/fast/multicol/span/span-as-immediate-columns-child-removal-expected.checksum:
  • platform/mac-leopard/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
  • platform/mac-leopard/fast/table/027-vertical-expected.checksum:
  • platform/mac-leopard/fast/table/027-vertical-expected.png:
  • platform/mac-leopard/fast/table/028-vertical-expected.checksum:
  • platform/mac-leopard/fast/table/028-vertical-expected.png:
  • platform/mac-leopard/fast/table/038-vertical-expected.checksum:
  • platform/mac-leopard/fast/table/038-vertical-expected.png:
  • platform/mac-leopard/fast/table/040-vertical-expected.checksum:
  • platform/mac-leopard/fast/table/040-vertical-expected.png:
  • platform/mac-leopard/fast/table/border-collapsing/002-vertical-expected.checksum:
  • platform/mac-leopard/fast/table/border-collapsing/002-vertical-expected.png:
  • platform/mac-leopard/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.checksum:
  • platform/mac-leopard/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.png:
  • platform/mac-leopard/fast/table/table-display-types-vertical-expected.checksum:
  • platform/mac-leopard/fast/table/table-display-types-vertical-expected.png:
  • platform/mac-leopard/fast/text/backslash-to-yen-sign-euc-expected.checksum:
  • platform/mac-leopard/fast/text/backslash-to-yen-sign-euc-expected.png:
  • platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.checksum:
  • platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.png:
  • platform/mac-leopard/svg/custom/junk-data-expected.checksum:
  • platform/mac-leopard/svg/custom/junk-data-expected.png:
  • platform/mac-leopard/svg/custom/missing-xlink-expected.checksum:
  • platform/mac-leopard/svg/custom/missing-xlink-expected.png:
  • platform/mac-leopard/tables/mozilla/other/wa_table_thtd_rowspan-expected.checksum:
  • platform/mac-leopard/tables/mozilla/other/wa_table_thtd_rowspan-expected.png:
6:59 PM Changeset in webkit [75308] by justin.garcia@apple.com
  • 3 edits
    2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=51851
Implement RenderSVGInlineText::localCaretRect()

Reviewed by Dan Bernstein.

WebCore:

  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::localCaretRect): Implemented.

LayoutTests:

  • svg/text/caret-in-svg-text-expected.txt: Added.
  • svg/text/caret-in-svg-text.xhtml: Added.
6:42 PM Changeset in webkit [75307] by rniwa@webkit.org
  • 2 edits in trunk/WebCore

2011-01-07 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; Added the missing null pointer check for r75293.

  • dom/Document.cpp: (WebCore::Document::adoptNode):
6:24 PM Changeset in webkit [75306] by Stephanie Lewis
  • 14 edits
    3 adds in trunk

WebCore: <rdar://problem/8649617> Migrate memory tracking from Safari to WebKit
https://bugs.webkit.org/show_bug.cgi?id=50799 Add Memory Sampler to WebKit

Reviewed by Geoff Garen.

Add a sampler for printing off process memory statistics.
Export file mode.

  • WebCore.exp.in:

WebKit2: <rdar://problem/8649617> Migrate memory tracking from Safari to WebKit
https://bugs.webkit.org/show_bug.cgi?id=50799 Add Memory Sampler to WebKit

Reviewed by Geoff Garen.

Add a sampler for printing off process memory statistics.
This tool can track:

WebCore

  • FastMalloc allocations bytes (in use or committed)

JavaScriptCore

  • Garbage collector heap bytes (in use or committed)
  • Stack bytes (committed only!)
  • JIT Code bytes (committed only!)

Malloc zones

  • In use bytes for the following zones:
    • Default zone (in use or committed)
    • DispCon zone (in use or committed)
    • Purgable zone (in use or committed)

Task Info

  • Resident size memory (RSIZE)


Data collected is dumped to a temporary file.


Create a sandbox for a temporary file.

  • Shared/SandboxExtension.h:

(WebKit::SandboxExtension::createHandleForTemporaryFile):

  • Shared/mac/SandboxExtensionMac.mm:

(WebKit::SandboxExtension::createHandleForTemporaryFile):

Memory Sampler files

  • Shared/WebMemorySampler.cpp: Added.

(WebKit::WebMemorySampler::shared):
(WebKit::WebMemorySampler::WebMemorySampler):
(WebKit::WebMemorySampler::start):
(WebKit::WebMemorySampler::initializeTimers):
(WebKit::WebMemorySampler::stop):
(WebKit::WebMemorySampler::isRunning):
(WebKit::WebMemorySampler::initializeTempLogFile):
(WebKit::WebMemorySampler::initializeSandboxedLogFile):
(WebKit::WebMemorySampler::writeHeaders):
(WebKit::WebMemorySampler::sampleTimerFired):
(WebKit::WebMemorySampler::stopTimerFired):
(WebKit::WebMemorySampler::appendCurrentMemoryUsageToFile):

  • Shared/WebMemorySampler.h: Added.
  • Shared/mac/WebMemorySampler.mac.mm: Added.

(WebKit::WebMemorySampler::sampleSystemMalloc):
(WebKit::WebMemorySampler::sampleProcessCommittedBytes):
(WebKit::WebMemorySampler::processName):
(WebKit::WebMemorySampler::sampleWebKit):

API to start and stop UIProcess and WebProcess sampling.

  • UIProcess/API/C/WKContext.cpp:

(WKContextStartMemorySampler):
(WKContextStopMemorySampler):

  • UIProcess/API/C/WKContext.h:


Send messages to WebProcess to start and stop memory sampling.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::processDidFinishLaunching):
(WebKit::WebContext::startMemorySampler):
(WebKit::WebContext::stopMemorySampler):

  • UIProcess/WebContext.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::startMemorySampler):
(WebKit::WebProcess::stopMemorySampler):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
6:15 PM Changeset in webkit [75305] by rniwa@webkit.org
  • 7 edits
    22 adds in trunk

2011-01-06 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Adam Barth.

onbeforeunload is broken for framesets
https://bugs.webkit.org/show_bug.cgi?id=19418

Added beforeunload event support for sub frames. WebKit's implementation tries to match
that of Internet Explorer as much as possible. beforeunload event is fired for each and
every descendent of a frame that is about to navigate.

When a value other than null is returned by a beforeunload handler, a confirmation dialog
is shown for each handler (calls chrome's runBeforeUnloadConfirmPanel) just like it is done
for main frames.

In addition, navigation is forbidden while beforeunload handlers are being called.
Setting values to location.href, location.reload, and other means of navigations are thus
ignored while beforeunload event handler is being ran, matching Internet Explorer's behavior.

Because navigation needs to prevented globally, NavigationDisablerForBeforeUnload is added to
NavigationScheduler.h, which is instantiated as a RAII object in FrameLoader::shouldClose.

Tests: fast/events/before-unload-adopt-subframe-to-outside.html

fast/events/before-unload-adopt-within-subframes.html
fast/events/before-unload-forbidden-navigation.html
fast/events/before-unload-in-multiple-subframes.html
fast/events/before-unload-in-subframe.html
fast/events/before-unload-javascript-navigation.html
fast/events/before-unload-remove-and-add-subframe.html
fact/events/before-unload-remove-itself.html
fast/events/before-unload-with-subframes.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::shouldClose): Calls fireBeforeUnloadEvent on m_frame and m_frame's descendents. Returns true only if every call to fireBeforeUnloadEvent returned true. (WebCore::FrameLoader::fireBeforeUnloadEvent): Fires a beforeunload event and calls chrome's runBeforeUnloadConfirmPanel as needed. (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Calls shouldClose for all frames.
  • loader/FrameLoader.h:
  • loader/NavigationScheduler.cpp: (WebCore::NavigationScheduler::shouldScheduleNavigation): Checks the nullity of Page and calls NavigationDisablerForBeforeUnload::isNavigationAllowed when url is not javascript scheme. (WebCore::NavigationScheduler::scheduleRedirect): Calls shouldScheduleNavigation. (WebCore::NavigationScheduler::scheduleLocationChange): Ditto. (WebCore::NavigationScheduler::scheduleRefresh): Ditto. (WebCore::NavigationScheduler::scheduleHistoryNavigation): Ditto.
  • loader/NavigationScheduler.h: (WebCore::NavigationDisablerForBeforeUnload::NavigationDisablerForBeforeUnload): Disables navigation. (WebCore::NavigationDisablerForBeforeUnload::~NavigationDisablerForBeforeUnload): Enables navigation when called on the last instance of NavigationDisablerForBeforeUnload. (WebCore::NavigationDisablerForBeforeUnload::isNavigationAllowed): Returns true if there are no instance of NavigationDisablerForBeforeUnload left on the stack.

2011-01-06 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Adam Barth.

onbeforeunload is broken for framesets
https://bugs.webkit.org/show_bug.cgi?id=19418

Added tests to ensure WebKit fires beforeunload events for subframes,
and disallows navigation except that of javascript scheme while beforeunload event
handlers are being called.

Also added a test to ensure WebKit fires beforeunload event for subframes exactly
once even if a subframe was moved around within a beforeunload event handler.

A test that ensures beforeunload event is not fired for an iframe if the iframe
was added or removed within a beforeunload event handler is also added.

Furthermore, a test to ensure WebKit does not fire a beforeunload event to an iframe
that has been adopted by a document outside of the unloading document is added.

  • fast/events/before-unload-adopt-subframe-to-outside-expected.txt: Added.
  • fast/events/before-unload-adopt-subframe-to-outside.html: Added.
  • fast/events/before-unload-adopt-within-subframes-expected.txt: Added.
  • fast/events/before-unload-adopt-within-subframes.html: Added.
  • fast/events/before-unload-forbidden-navigation-expected.txt: Added.
  • fast/events/before-unload-forbidden-navigation.html: Added.
  • fast/events/before-unload-in-multiple-subframes-expected.txt: Added.
  • fast/events/before-unload-in-multiple-subframes.html: Added.
  • fast/events/before-unload-in-subframe-expected.txt: Added.
  • fast/events/before-unload-in-subframe.html: Added.
  • fast/events/before-unload-javascript-navigation-expected.txt: Added.
  • fast/events/before-unload-javascript-navigation.html: Added.
  • fast/events/before-unload-remove-and-add-subframe-expected.txt: Added.
  • fast/events/before-unload-remove-and-add-subframe.html: Added.
  • fact/events/before-unload-remove-itself-expected.txt: Added.
  • fact/events/before-unload-remove-itself.html: Added.
  • fast/events/before-unload-with-subframes-expected.txt: Added.
  • fast/events/before-unload-with-subframes.html: Added.
  • fast/events/resources/before-unload-in-subframe-child.html: Added.
  • fast/events/resources/before-unload-in-subframe-destination.html: Added.
  • fast/events/resources/before-unload-in-subframe-fail.html: Added.
  • fast/events/resources/before-unload-with-subframes-parent.html: Added.
5:58 PM Changeset in webkit [75304] by mrowe@apple.com
  • 3 edits
    3 adds in tags/Safari-534.15.3

Merge r74427.

5:58 PM Changeset in webkit [75303] by mrowe@apple.com
  • 7 edits in tags/Safari-534.15.3

Merge r74453.

5:58 PM Changeset in webkit [75302] by mrowe@apple.com
  • 4 edits in tags/Safari-534.15.3

Merge r74375.

5:51 PM Changeset in webkit [75301] by mrowe@apple.com
  • 5 edits in tags/Safari-534.15.3

Versioning.

5:45 PM Changeset in webkit [75300] by mrowe@apple.com
  • 1 copy in tags/Safari-534.15.3

New tag.

5:45 PM Changeset in webkit [75299] by mrowe@apple.com
  • 1 delete in tags/Safari-534.15.1

Remove bogus tag.

5:38 PM Changeset in webkit [75298] by Martin Robinson
  • 3 edits in trunk/LayoutTests

2011-01-07 Martin Robinson <mrobinson@igalia.com>

Reviewed by Mihai Parparita.

fast/dom/Window/window-postmessage-clone-frames.html has some timing issues
https://bugs.webkit.org/show_bug.cgi?id=52032

Fix the timing issue in fast/dom/Window/window-postmessage-clone-frames.html
and move the output console div beyond the file input control, so that output
text does not push it outside the viewport.

  • fast/dom/Window/window-postmessage-clone-frames-expected.txt: Updated results to reflect div movement.
  • fast/dom/Window/window-postmessage-clone-frames.html: Fix the timing and layout issues with this test.
5:34 PM Changeset in webkit [75297] by mrowe@apple.com
  • 1 copy in tags/Safari-534.15.1

New tag.

5:20 PM Changeset in webkit [75296] by Martin Robinson
  • 3 edits in trunk/WebCore

2011-01-07 Martin Robinson <mrobinson@igalia.com>

Build fix for GTK+.

  • GNUmakefile.am: Add RenderFullScreen.cpp to the sources list.
  • rendering/RenderFullScreen.cpp: (RenderFullScreen::setAnimating): Guard the call to contentChanged with ENABLED(ACCELERATED_COMPOSITING).
5:15 PM Changeset in webkit [75295] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-01-06 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

side-by-side diffs in the code review tool
https://bugs.webkit.org/show_bug.cgi?id=52019

Support for conversion from the formatted diff to a side-by-side diff.
Maintains comments and new comments can be added.

The main architectural change is that Line elements are no longer necessarily
siblings. Each physical line is now in a LineContainer and LineContainers are
siblings. Each Line corresponds to a Line in the unified diff and has an id (e.g. line12).
A Line can be a LineContainer or a child of a LineContainer.

In this way, converting to side-by-side and, in the future, back to unified is non-lossy.

  • PrettyPatch/PrettyPatch.rb:
  • code-review.js:
4:53 PM Changeset in webkit [75294] by rniwa@webkit.org
  • 2 edits in trunk/WebCore

2011-01-07 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; speculative fix for Windows debug build.

  • bindings/js/JSBindingsAllInOne.cpp:
4:49 PM Changeset in webkit [75293] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

2011-01-07 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Ojan Vafai.

Adopting an iframe to a child frame results in stack overflow
https://bugs.webkit.org/show_bug.cgi?id=52018

Throws an exception when a document adopts an iframe that is an ancestor
of the document in the frame hierarchy. New behavior matches that of Firefox.

Test: fast/html/adopt-parent-frame.html

  • dom/Document.cpp: (WebCore::Document::adoptNode):

2011-01-07 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Ojan Vafai.

Adopting an iframe to a child frame results in stack overflow
https://bugs.webkit.org/show_bug.cgi?id=52018

Added a test to ensure calling adoptNode with an iframe throws an exception
if the adoptee is an ancestor of the document adopting the node in the frame hierarchy.

  • fast/html/adopt-parent-frame-expected.txt: Added.
  • fast/html/adopt-parent-frame.html: Added.
4:38 PM Changeset in webkit [75292] by mihaip@chromium.org
  • 8 edits in trunk

2011-01-07 Mihai Parparita <mihaip@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Scrollbar code cleanup
https://bugs.webkit.org/show_bug.cgi?id=52073

Scrollbar code cleanup:

  • Remove ScrollbarThemeMac.{mm|h} from the mac sources list, we use ScrollbarThemeChromiumMac.{mm|h}
  • Remove USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define now that switch to WebThemeEngine is permanent
  • Fix typo in Linux scrollbar enum name

No new tests (compiles).

  • WebCore.gypi:
  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
  • platform/chromium/ScrollbarThemeChromiumMac.mm: (WebCore::scrollbarStateToThemeState): (WebCore::ScrollbarThemeChromiumMac::paint):

2011-01-07 Mihai Parparita <mihaip@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Scrollbar code cleanup
https://bugs.webkit.org/show_bug.cgi?id=52073

Scrollbar code cleanup:

  • Fix typo in Linux scrollbar enum name
  • public/linux/WebThemeEngine.h:
  • src/ChromiumBridge.cpp: (WebCore::WebThemePart): (WebCore::GetWebThemeExtraParams):
4:21 PM Changeset in webkit [75291] by mjs@apple.com
  • 4 edits in trunk/Tools

2011-01-07 Maciej Stachowiak <mjs@apple.com>

Reviewed by Sam Weinig.

Make WebKitTestRunner rest between loads more robust to avoid test crashes
https://bugs.webkit.org/show_bug.cgi?id=52086

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::didReceiveMessage):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::notifyDone):
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): (WTR::TestController::run):
4:21 PM Changeset in webkit [75290] by jer.noble@apple.com
  • 2 edits in trunk/WebCore

GTK Linux build fix: isDocumentRunningFullScreenAnimation should
be protected both by ENABLE(FULLSCREEN_API) && USE(ACCELERATED_COMPOSITING)

  • page/FrameView.cpp:
3:59 PM Changeset in webkit [75289] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Bug 26276 - Need a mechanism to determine stack extent on WINDOWS, SOLARIS, OPENBSD, SYMBIAN, HAIKU, WINCE platforms

Reviewed by Geoff Garen.

Fix for win32. The base of the stack is stored in the "deallocation stack" field of the
Thread Information Block - see: http://en.wikipedia.org/wiki/Win32_Thread_Information_Block
for more information!

  • wtf/StackBounds.cpp:

(WTF::StackBounds::initialize):

3:57 PM Changeset in webkit [75288] by jer.noble@apple.com
  • 2 edits in trunk/WebKit/mac

Yet another Leopard build fix: NSRect and CGRect are not inter-
changable in 32-bit.

  • WebView/WebFullScreenController.mm:

(-[WebFullScreenController exitFullscreen]):

3:48 PM Changeset in webkit [75287] by commit-queue@webkit.org
  • 10 edits in trunk/WebCore

2011-01-07 Rafael Weinstein <rafaelw@chromium.org>

Reviewed by Eric Seidel.

Cleanup: Fold shadowParentNode into shadowHost
https://bugs.webkit.org/show_bug.cgi?id=51059

Replaces all uses of shadowParentNode.

No new tests because no behavior has changed.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::initForStyleResolve):
  • dom/Node.cpp: (WebCore::Node::shadowHost): (WebCore::Node::shadowAncestorNode): (WebCore::eventTargetRespectingSVGTargetRules): (WebCore::Node::getEventAncestors):
  • dom/Node.h:
  • editing/Editor.cpp: (WebCore::Editor::findString):
  • page/DragController.cpp: (WebCore::asFileInput):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): (WebCore::instanceAssociatedWithShadowTreeElement): (WebCore::EventHandler::dispatchMouseEvent):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::hasLineIfEmpty):
  • rendering/RenderSVGShadowTreeRootContainer.cpp: (WebCore::RenderSVGShadowTreeRootContainer::updateFromElement):
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::title):
3:39 PM Changeset in webkit [75286] by Martin Robinson
  • 1 edit
    3 adds in trunk/LayoutTests

2011-01-07 Martin Robinson <mrobinson@igalia.com>

Add a platform-specific baseline for GTK+ after r75257.

  • platform/gtk/fast/text/emphasis-avoid-ruby-expected.checksum: Added.
  • platform/gtk/fast/text/emphasis-avoid-ruby-expected.png: Added.
  • platform/gtk/fast/text/emphasis-avoid-ruby-expected.txt: Added.
3:39 PM Changeset in webkit [75285] by jer.noble@apple.com
  • 2 edits in trunk/WebKit/mac

Fix the Leopard build: Replace CoreAnimation SL-only functions
with Leopard equivalents.

  • WebView/WebFullScreenController.mm:

(+[CATransaction setDisableActions:]):
(+[CATransaction setAnimationDuration:]):
(-[WebFullScreenController _animationDuration]):
(-[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:]):

3:35 PM Changeset in webkit [75284] by cmarrin@apple.com
  • 2 edits in trunk/WebCore

2011-01-07 Chris Marrin <cmarrin@apple.com>

Unreviewed.

I mistakenly included a Windows only file in a
cross platform file.

  • platform/graphics/ca/GraphicsLayerCA.cpp:
3:27 PM Changeset in webkit [75283] by cmarrin@apple.com
  • 2 edits in trunk/WebCore

2011-01-07 Chris Marrin <cmarrin@apple.com>

Unreviewed.

Get rid of include of <QuartzCore/QuartzCore.h>

  • platform/graphics/ca/GraphicsLayerCA.cpp:
3:18 PM Changeset in webkit [75282] by jer.noble@apple.com
  • 2 edits in trunk/WebCore

Further build fixes. Add a ENABLE(FULLSCREEN_API) guard around
the implementation of requiresCompositingfForFullScreen.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForFullScreen):

3:09 PM Changeset in webkit [75281] by jer.noble@apple.com
  • 2 edits in trunk/WebCore

No review, build fix only. Removed parameter who was causing
a warning in Release builds.

  • dom/Document.cpp:

(WebCore::Document::webkitDidExitFullScreenForElement):

3:07 PM Changeset in webkit [75280] by cmarrin@apple.com
  • 5 edits in trunk

2011-01-07 Chris Marrin <cmarrin@apple.com>

Unreviewed.

Use new wkCACFLayerGetContextUserData function

  • platform/graphics/ca/win/PlatformCALayerWin.cpp:

2011-01-07 Chris Marrin <cmarrin@apple.com>

Unreviewed.

Minor change to check for null context

  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
2:58 PM Changeset in webkit [75279] by jberlin@webkit.org
  • 5 edits in trunk/WebKit2

WebKit2: Need WKBundleFrameCopyProvisionalURL
https://bugs.webkit.org/show_bug.cgi?id=52083

Reviewed by Dan Bernstein.

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameCopyProvisionalURL):

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::provisionalURL):
Grab the URL from the provisional document loader.

  • WebProcess/WebPage/WebFrame.h:
2:51 PM Changeset in webkit [75278] by jamesr@google.com
  • 2 edits in trunk/WebCore

2011-01-07 James Robinson <jamesr@chromium.org>

Fix compile bustage due to bad merge in 75276.

  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::beginAnimationUpdateTime):
2:45 PM Changeset in webkit [75277] by jer.noble@apple.com
  • 36 edits
    4 adds in trunk

WebCore: Implement WebKit Full Screen support.
https://bugs.webkit.org/show_bug.cgi?id=49481
rdar://problem/8247444

Patch by Jer Noble <jer@kokode.apple.com> on 2010-12-17
Reviewed by Simon Fraser.

Mark for export all those WebCore functions needed by WebFullscreenController.

  • WebCore.exp.in:

WebCore: Implement WebKit Full Screen support.
https://bugs.webkit.org/show_bug.cgi?id=49481
rdar://problem/8247444

Patch by Jer Noble <jer@kokode.apple.com> on 2010-12-17
Reviewed by Simon Fraser.

screenRect is useful for more than just HTMLMediaElements. Promote it into
Element.

  • dom/Element.cpp: Moved into Element from HTMLMediaElement.
  • dom/Element.h: Ditto.
  • dom/Node.cpp:
  • html/HTMLMediaElement.cpp: Moved screenRect into Element.
  • html/HTMLMediaElement.h: Ditto.
  • WebCore.exp.in: Modify the exports list to reflect the new symbol name.

WebCore: Implement WebKit Full Screen support.
https://bugs.webkit.org/show_bug.cgi?id=49481
rdar://problem/8247444

Patch by Jer Noble <jer@kokode.apple.com> on 2010-12-17
Reviewed by Simon Fraser.

The RenderFullScreen is intended to be used by clients of that API to allow a DOM subtree to
be rendered outside its original Frame. Because of this, there are a few areas of the
rendering code which need to be special cased: RenderFullScreen layers should not be clipped
to the viewport, as they will almost always be rendering outside the viewport area;
RenderFullScreen graphics layers should not be reparented by the RenderLayerCompositor, as
the client will likely want to reparent the platformLayer into their own fullscreen platform
window; the FrameView must update the RenderFullScreen graphics layer tree separately from
the root layer, as the two trees are disconnected.

  • page/FrameView.cpp:

(WebCore::FrameView::updateCompositingLayers): Special treatment for fullscreen renderer.
(WebCore::FrameView::syncCompositingStateRecursive): Ditto.
(WebCore::FrameView::paintContents): Ditto.

  • rendering/RenderLayer.h: Add a new ContentChangeType enum entry for FullScreen.
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::contentChanged): Add support for above.

  • rendering/RenderLayerBacking.cpp:

(WebCore::layerOrAncestorIsFullScreen): New function.
(WebCore::RenderLayerBacking::updateCompositedBounds): Do not clip if the layerOrAncestorIsFullScreen.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Special treatment for fullscreen renderer.
(WebCore::RenderLayerCompositor::requiresCompositingLayer): Ditto.
(WebCore::RenderLayerCompositor::requiresCompositingForFullScreen): Ditto.

  • rendering/RenderLayerCompositor.h:

WebCore: Implement WebKit Full Screen support.
https://bugs.webkit.org/show_bug.cgi?id=49481
rdar://problem/8247444

Patch by Jer Noble <jer@kokode.apple.com> on 2010-12-17
Reviewed by Simon Fraser.

Implemented non-accelerated fullscreen support. The Document will now vend a RenderFullScreen object for clients to
use to relocate the fullscreen element subtree.

  • css/CSSStyleSelector.cpp:

(WebCore::loadFullScreenRulesIfNeeded): Change webkitFullScreen -> webkitIsFullScreen.
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Ditto.

  • dom/Document.cpp:

(WebCore::Document::Document): Initialize m_fullScreenRenderer.
(WebCore::Document::detach): Call setFullScreenRenderer(0).
(WebCore::Document::nodeWillBeRemoved): Replicate the logic in webkitWillEnterFullScreenForElement.
(WebCore::Document::webkitWillEnterFullScreenForElement): Detach the fullscreen element to cause

a new RenderFullScreen renderer to be created with the new fullscreen element.

(WebCore::Document::webkitDidEnterFullScreenForElement): Notify clients of a fullscreen change

here, rather in "willEnter", to avoid reentrancy problems when clients remove nodes in response
to webkitfullscreenchange events.

(WebCore::Document::webkitWillExitFullScreenForElement): Recalculate the fullscreen element's style.
(WebCore::Document::webkitDidExitFullScreenForElement): Ditto.
(WebCore::Document::setFullScreenRenderer): Accessor for m_fullScreenRenderer.
(WebCore::Document::setFullScreenRendererSize): Set the style on the m_fullScreenRenderer with a new

size; this keeps clients from having to access the renderer's style directly.

(WebCore::Document::setFullScreenRendererBackgroundColor): Ditto.

  • dom/Document.h:

(WebCore::Document::webkitIsFullScreen): Change webkitFullScreen -> webkitIsFullScreen.
(WebCore::Document::fullScreenRenderer): Accessor.

  • dom/Document.idl:
  • dom/Node.cpp:

(WebCore::Node::createRendererIfNeeded): If the document is in fullscreen mode, create a RenderFullScreen

object to insert between the fullscreen element and its parent.

  • page/ChromeClient.h:

(WebCore::ChromeClient::fullScreenRendererChanged): Added.

  • rendering/MediaControlElements.cpp:

(WebCore::MediaControlFullscreenButtonElement::defaultEventHandler): Change webkitFullScreen -> webkitIsFullScreen.

WebCore: Implement WebKit Full Screen support.
https://bugs.webkit.org/show_bug.cgi?id=49481
rdar://problem/8247444

Patch by Jer Noble <jer@kokode.apple.com> on 2010-12-17
Reviewed by Simon Fraser.

This patch introduces a new RenderObject type: RenderFullScreen. The RenderFullScreen renderer
will be used to implement new FullScreen APIs. Because the RenderFullScreen object will be the
parent of the current fullscreen element, the style rules for fullscreen objects must change to
match.

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderFullScreen.cpp: Added.

(RenderFullScreen::setAnimating): Sets the m_isAnimating flag.
(RenderFullScreen::createFullScreenStyle): Returns a new RenderStyle containing the default stye

for RenderFullScreen objects.

  • rendering/RenderFullScreen.h: Added.

(WebCore::RenderFullScreen::isRenderFullScreen): Added. Overrides the RenderObject version.

  • rendering/RenderObject.h:

(WebCore::RenderObject::isRenderFullScreen): Added. Used for type-checking RenderFullScreen objects.

  • css/fullscreen.css: Modified the contained fullscreen styles.

WebKit/mac: Implement WebKit Full Screen support.
https://bugs.webkit.org/show_bug.cgi?id=49481
rdar://problem/8247444

Patch by Jer Noble <jer@kokode.apple.com> on 2011-01-05
Reviewed by Simon Fraser.

Support the new fullscreen Chrome client requests. WebView will pass
through these requests to a WebFullscreenController.

  • WebCoreSupport/WebChromeClient.h: Add fullScreenRendererChanged().
  • WebView/WebView.mm:

(-[WebView _supportsFullScreenForElement:WebCore::]): Check to see if the fullscreen pref has been enabled.
(-[WebView _enterFullScreenForElement:WebCore::]): Create a WebFullScreenController.
(-[WebView _exitFullScreenForElement:WebCore::]): Request that the WebFullScreenController exit fullscreen.
(-[WebView _fullScreenRendererChanged:WebCore::]): Notify the WebFullScreenController that its renderer has changed.

  • WebView/WebViewData.h: Add ivar newFullscreenController.

Patch by Jer Noble <jer@kokode.apple.com> on 2011-01-05
Reviewed by Simon Fraser.

This patch implements the FullScreen APIs using the new RenderFullScreen renderer and the new
Document client APIs. The RenderFullScreen renderer's CALayer is hosted in a new, fullscreen
window, and a custom CAAnimation animates that layer between the initial screen rect of the
full screen element, to its final value. WebFullscreenController will swap the WebView out of
its original window, and into the fullscreen window. The controller will replace the WebView
with a placeholder view, so that if the placeholder moves or resized while the WebView is
absent, the WebView will move back to the correct location when exiting fullscreen.

  • WebView/WebFullscreenController.h: Added.
  • WebView/WebFullscreenController.mm: Added.

(-[WebFullscreenController windowDidExitFullscreen:]): Close the fullscreen window.
(-[WebFullscreenController windowDidEnterFullscreen:]): Swap the webView back into the fullscreen window.
(-[WebFullscreenController animationDidStop:finished:]): Call windowDid{Exit|Enter}FullScreen as appropriate.
(-[WebFullscreenController applicationDidResignActive:]):
(-[WebFullscreenController applicationDidChangeScreenParameters:]): Resize the fullscreen window to match

the new screen parameters.

(-[WebFullscreenController enterFullscreen:]): Set up the animation that will take the fullscreen element

from its original screen rect into fullscreen.

(-[WebFullscreenController exitFullscreen]): Swap the webView back into its original window.

Set up the animation that will take the fullscreen element back into its original screen
rect.

(-[WebFullscreenController _updatePowerAssertions]): Now checks _isAnyMoviePlaying to determine

whether to disable screensaver and sleep.

(-[WebFullscreenController _isAnyMoviePlaying]): Walks through the sub-tree starting at the fullscreen element

looking for HTMLVideoElements; returns whether any are found to be playing.

(-[WebFullscreenController _animationDuration]): Returns the current animation duration, affected by control

and shift keys.

(-[WebFullscreenWindow canBecomeKeyWindow]): Allow the window to become key.
(-[WebFullscreenWindow keyDown:]): Handle the 'Esc' key.
(-[WebFullscreenWindow cancelOperation:]): Request to exit fullscreen.
(-[WebFullscreenWindow rendererLayer]): Convenience accessor.
(-[WebFullscreenWindow setRendererLayer:]): Ditto.
(-[WebFullscreenWindow backgroundLayer]): Ditto.
(-[WebFullscreenWindow animationView]): Ditto.
(MediaEventListener::MediaEventListener): Implements the EventListener protocol.
(MediaEventListener::handleEvent): Tells its delegate to _updatePowerAssertions.

LayoutTests: Implement WebKit Full Screen support.
https://bugs.webkit.org/show_bug.cgi?id=49481
rdar://problem/8247444

Patch by Jer Noble <jer@kokode.apple.com> on 2011-01-05
Reviewed by Simon Fraser.

Update the tests with new API names and spec values.

  • fullscreen/full-screen-api-expected.txt:
  • fullscreen/full-screen-api.html:
  • fullscreen/full-screen-css.html:
  • fullscreen/full-screen-request-expected.txt:
  • fullscreen/full-screen-request.html:
2:32 PM Changeset in webkit [75276] by jamesr@google.com
  • 40 edits
    5 deletes in trunk

2011-01-07 James Robinson <jamesr@chromium.org>

Revert "Implement mozilla's animationTime property"
https://bugs.webkit.org/show_bug.cgi?id=51952

This approach isn't quite right.

  • animations/animation-time-expected.txt: Removed.
  • animations/animation-time.html: Removed.
  • animations/script-tests/animation-time.js: Removed.
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:

2011-01-07 James Robinson <jamesr@chromium.org>

Revert "Implement mozilla's animationTime property"
https://bugs.webkit.org/show_bug.cgi?id=51952

This approach isn't quite right.

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::paintInvalidatedRegion):

2011-01-07 James Robinson <jamesr@chromium.org>

Revert "Implement mozilla's animationTime property"
https://bugs.webkit.org/show_bug.cgi?id=51952

This approach isn't quite right.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/DOMWindow.cpp:
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • page/Frame.cpp:
  • page/Frame.h:
  • page/Page.cpp: (WebCore::Page::Page):
  • page/Page.h:
  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::beginAnimationUpdateTime):
  • page/animation/AnimationTimeController.cpp: Removed.
  • page/animation/AnimationTimeController.h: Removed.

2011-01-07 James Robinson <jamesr@chromium.org>

Revert "Implement mozilla's animationTime property"
https://bugs.webkit.org/show_bug.cgi?id=51952

This approach isn't quite right.

  • public/WebWidget.h:
  • src/WebPopupMenuImpl.cpp:
  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp:
  • src/WebViewImpl.h:

2011-01-07 James Robinson <jamesr@chromium.org>

Revert "Implement mozilla's animationTime property"
https://bugs.webkit.org/show_bug.cgi?id=51952

This approach isn't quite right.

  • WebView/WebHTMLView.mm: (-[WebHTMLView drawRect:]):
  • WebView/WebView.mm: (layerSyncRunLoopObserverCallBack):

2011-01-07 James Robinson <jamesr@chromium.org>

Revert "Implement mozilla's animationTime property"
https://bugs.webkit.org/show_bug.cgi?id=51952

This approach isn't quite right.

  • WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp: (WebKit::ChunkedUpdateDrawingArea::display): (WebKit::ChunkedUpdateDrawingArea::setSize):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::drawRect):
  • WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm: (WebKit::LayerBackedDrawingArea::syncCompositingLayers):
2:19 PM Changeset in webkit [75275] by cmarrin@apple.com
  • 4 edits in trunk/WebKitLibraries

2011-01-07 Chris Marrin <cmarrin@apple.com>

Unreviewed.

Added one more API to WKSI to get the user data
out of the CACFContext.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
2:13 PM Changeset in webkit [75274] by senorblanco@chromium.org
  • 3 edits in trunk/LayoutTests

2011-01-07 Stephen White <senorblanco@chromium.org>

Unreviewed; test expectations update.

  • platform/chromium-gpu/test_expectations.txt: Removed some no-longer-failing tests; moved some lines around to match the CPU results.
  • platform/chromium/test_expectations.txt: Bug assignment and cleanup.
2:06 PM Changeset in webkit [75273] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2011-01-07 Jan Erik Hanssen <jhanssen@sencha.com>

Reviewed by Andreas Kling.

[Qt] Black text on black buttons using a dark theme
https://bugs.webkit.org/show_bug.cgi?id=35024

Implement RenderThemeQt::systemColor to apply the correct colors from the current Qt style.

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::systemColor):
  • platform/qt/RenderThemeQt.h:
1:53 PM Changeset in webkit [75272] by commit-queue@webkit.org
  • 1 edit
    10 adds in trunk/WebKit2

2011-01-07 Amruth Raj <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com>

Reviewed by Martin Robinson.

[GTK] WebKit2 GNUmakefile is out of date from trunk
Adding new stub files for compiling on latest revision
https://bugs.webkit.org/show_bug.cgi?id=51883

  • UIProcess/gtk: Added.
  • UIProcess/gtk/TextCheckerGtk.cpp: Added. (WebKit::TextChecker::state): (WebKit::TextChecker::isContinuousSpellCheckingAllowed): (WebKit::TextChecker::setContinuousSpellCheckingEnabled): (WebKit::TextChecker::setGrammarCheckingEnabled): (WebKit::TextChecker::uniqueSpellDocumentTag): (WebKit::TextChecker::closeSpellDocumentWithTag): (WebKit::TextChecker::checkTextOfParagraph): (WebKit::TextChecker::updateSpellingUIWithMisspelledWord): (WebKit::TextChecker::getGuessesForWord): (WebKit::TextChecker::learnWord): (WebKit::TextChecker::ignoreWord):
  • UIProcess/gtk/WebInspectorGtk.cpp: Added. (WebKit::WebInspectorProxy::platformCreateInspectorPage): (WebKit::WebInspectorProxy::platformOpen): (WebKit::WebInspectorProxy::platformClose): (WebKit::WebInspectorProxy::inspectorPageURL):
  • UIProcess/gtk/WebPageProxyGtk.cpp: Added. (WebKit::WebPageProxy::standardUserAgent):
  • UIProcess/gtk/WebPreferencesGtk.cpp: Added. (WebKit::WebPreferences::platformInitializeStore): (WebKit::WebPreferences::platformUpdateStringValueForKey): (WebKit::WebPreferences::platformUpdateBoolValueForKey): (WebKit::WebPreferences::platformUpdateUInt32ValueForKey):
  • WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp: Added. (WebKit::WebContextMenuClient::lookUpInDictionary): (WebKit::WebContextMenuClient::isSpeaking): (WebKit::WebContextMenuClient::speak): (WebKit::WebContextMenuClient::stopSpeaking):
  • WebProcess/WebCoreSupport/gtk/WebDatabaseManagerGtk.cpp: Added. (WebKit::WebDatabaseManager::databaseDirectory):
  • WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp: Added. (WebKit::WebPopupMenu::setUpPlatformData):
  • WebProcess/WebPage/gtk: Added.
  • WebProcess/WebPage/gtk/WebInspectorGtk.cpp: Added. (WebKit::WebInspector::localizedStringsURL):
1:41 PM Changeset in webkit [75271] by enne@google.com
  • 14 edits
    3 copies
    4 adds in trunk

2011-01-05 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

Add tests for WebGL's lost context events.
https://bugs.webkit.org/show_bug.cgi?id=51492

  • fast/canvas/webgl/context-lost-expected.txt: Added.
  • fast/canvas/webgl/context-lost-restored-expected.txt: Added.
  • fast/canvas/webgl/context-lost-restored.html: Added.
  • fast/canvas/webgl/context-lost.html: Added.

2011-01-05 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

Add WEBKIT_lose_context WebGL extension.
https://bugs.webkit.org/show_bug.cgi?id=51492

Tests: fast/canvas/webgl/context-lost-restored.html

fast/canvas/webgl/context-lost.html

  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::toJS): (WebCore::JSWebGLRenderingContext::getSupportedExtensions):
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::toV8Object): (WebCore::V8WebGLRenderingContext::getSupportedExtensionsCallback):
  • html/canvas/WebGLExtension.h:
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::WebGLRenderingContextRestoreTimer::fired): (WebCore::WebGLRenderingContext::getExtension): (WebCore::WebGLRenderingContext::getSupportedExtensions): (WebCore::WebGLRenderingContext::forceLostContext): (WebCore::WebGLRenderingContext::onLostContext): (WebCore::WebGLRenderingContext::getNumberOfExtensions): (WebCore::WebGLRenderingContext::getExtensionNumber):
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebKitLoseContext.cpp: Copied from WebCore/html/canvas/WebGLExtension.h. (WebCore::WebKitLoseContext::WebKitLoseContext): (WebCore::WebKitLoseContext::~WebKitLoseContext): (WebCore::WebKitLoseContext::getName): (WebCore::WebKitLoseContext::create): (WebCore::WebKitLoseContext::loseContext):
  • html/canvas/WebKitLoseContext.h: Copied from WebCore/html/canvas/WebGLExtension.h.
  • html/canvas/WebKitLoseContext.idl: Copied from WebCore/html/canvas/WebGLExtension.h.
1:28 PM Changeset in webkit [75270] by cmarrin@apple.com
  • 2 edits in trunk/WebCore

2011-01-07 Chris Marrin <cmarrin@apple.com>

Unreviewed.

Build fix for Chromium. Missing include.

  • page/animation/AnimationBase.cpp:
1:21 PM Changeset in webkit [75269] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Update react-to-vsprops-changes.py after r74855

1:20 PM Changeset in webkit [75268] by Adam Roben
  • 2 edits in trunk/WebKit2

Don't ever call ::SetCursor(0)

Doing so makes the cursor disappear from the screen.

Fixes <http://webkit.org/b/52024> Mouse cursor flashes when moving it
around a WKView before the web process has finished launching

Reviewed by Jon Honeycutt.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::onSetCursor): If we don't have a cursor to set, just
let Windows do its default thing (which is to set the cursor to the
window class's cursor, which in our case is the arrow cursor).
(WebKit::WebView::cursorToShow): Just return 0 when the page has
crashed so that we'll show the default cursor (which is the arrow
cursor). This change has no visible effect, but seems slightly better
conceptually.
(WebKit::WebView::updateNativeCursor): Don't do anything if we don't
have a cursor to set.

1:19 PM Changeset in webkit [75267] by Adam Roben
  • 13 edits in trunk/WebKit2

Fill the WKView with white when the web process hasn't drawn anything yet

Fixes <http://webkit.org/b/52023> WKView accumulates pixel garbage
before web process has had a chance to draw anything (if Aero is
disabled)

Reviewed by Jon Honeycutt.

  • UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:

(WebKit::ChunkedUpdateDrawingAreaProxy::paint):

  • UIProcess/ChunkedUpdateDrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/LayerBackedDrawingAreaProxy.cpp:

(WebKit::LayerBackedDrawingAreaProxy::paint):

  • UIProcess/LayerBackedDrawingAreaProxy.h:
  • UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::paint):

  • UIProcess/TiledDrawingAreaProxy.h:
  • UIProcess/mac/ChunkedUpdateDrawingAreaProxyMac.mm:

(WebKit::ChunkedUpdateDrawingAreaProxy::platformPaint):

  • UIProcess/qt/ChunkedUpdateDrawingAreaProxyQt.cpp:

(WebKit::ChunkedUpdateDrawingAreaProxy::platformPaint):

  • UIProcess/win/ChunkedUpdateDrawingAreaProxyWin.cpp:

(WebKit::ChunkedUpdateDrawingAreaProxy::platformPaint):

  • UIProcess/win/LayerBackedDrawingAreaProxyWin.cpp:

(WebKit::LayerBackedDrawingAreaProxy::paint):
Changed these functions to return a boolean indicating whether we
actually painted anything.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::onPaintEvent): Fill with white (and don't call
didDraw) when the DrawingAreaProxy isn't able to paint.

1:08 PM Changeset in webkit [75266] by cmarrin@apple.com
  • 2 edits in trunk/WebCore

2011-01-07 Chris Marrin <cmarrin@apple.com>

Unreviewed.

Build fix.

  • platform/graphics/ca/win/PlatformCALayerWin.cpp:
1:04 PM Changeset in webkit [75265] by barraclough@apple.com
  • 10 edits in trunk

Source/JavaScriptCore: [GTK] Port scrollbar painting to GtkStyleContext
https://bugs.webkit.org/show_bug.cgi?id=52051

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2011-01-07
Reviewed by Martin Robinson.

  • wtf/gobject/GTypedefs.h: Add GtkStyleContext forward

declaration.

WebCore: Bug 52035 - Unregistering DOMWrapperWorlds is unsafe

Reviewed by Geoff Garen.

The method DOMWrapperWorld::unregisterWorld() effectively calls the DOMWrapperWorld's
destructor early, in order to release wrappers once we know we no longer intend to use them.
Whilst it is okay to have a method to throw away wrappers (assuming we know we're willing to
lose any state stored on them) it is not okay to deregister the world from the JSGlobalData.
A sequence of events that triggers the bug would look like this:

(1) Create a DOMWrapperWorld.
(2) Register a timer in the world.
(3) Call unregisterWorld() on the world.
(4) Timer goes off, code is executed in the world, creates a Node not attached to a Document.
(5) We attempt to lookup a wrapper map for the world on the JSGlobalData, but because we've

called forgetWorld() none exists.

(6) Attempt to add a wrapper to a NULL map.

Fix the problem by not removing the JSGlobalData's wrapper map until the world really goes away.

  • WebCore.exp.in:
  • bindings/js/DOMWrapperWorld.cpp:

(WebCore::DOMWrapperWorld::DOMWrapperWorld):
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
(WebCore::DOMWrapperWorld::clearWrappers):

  • bindings/js/DOMWrapperWorld.h:

WebKit/mac: Bug 52035 - Unregistering DOMWrapperWorlds is unsafe

Reviewed by Geoff Garen.

The method DOMWrapperWorld::unregisterWorld() effectively calls the DOMWrapperWorld's
destructor early, in order to release wrappers once we know we no longer intend to use them.
Whilst it is okay to have a method to throw away wrappers (assuming we know we're willing to
lose any state stored on them) it is not okay to deregister the world from the JSGlobalData.
A sequence of events that triggers the bug would look like this:

(1) Create a DOMWrapperWorld.
(2) Register a timer in the world.
(3) Call unregisterWorld() on the world.
(4) Timer goes off, code is executed in the world, creates a Node not attached to a Document.
(5) We attempt to lookup a wrapper map for the world on the JSGlobalData, but because we've

called forgetWorld() none exists.

(6) Attempt to add a wrapper to a NULL map.

Fix the problem by not removing the JSGlobalData's wrapper map until the world really goes away.

  • WebView/WebScriptWorld.mm:

(-[WebScriptWorld unregisterWorld]):

WebKit/win: Bug 52035 - Unregistering DOMWrapperWorlds is unsafe

Reviewed by Geoff Garen.

The method DOMWrapperWorld::unregisterWorld() effectively calls the DOMWrapperWorld's
destructor early, in order to release wrappers once we know we no longer intend to use them.
Whilst it is okay to have a method to throw away wrappers (assuming we know we're willing to
lose any state stored on them) it is not okay to deregister the world from the JSGlobalData.
A sequence of events that triggers the bug would look like this:

(1) Create a DOMWrapperWorld.
(2) Register a timer in the world.
(3) Call unregisterWorld() on the world.
(4) Timer goes off, code is executed in the world, creates a Node not attached to a Document.
(5) We attempt to lookup a wrapper map for the world on the JSGlobalData, but because we've

called forgetWorld() none exists.

(6) Attempt to add a wrapper to a NULL map.

Fix the problem by not removing the JSGlobalData's wrapper map until the world really goes away.

  • WebScriptWorld.cpp:

(WebScriptWorld::unregisterWorld):

12:44 PM Changeset in webkit [75264] by cmarrin@apple.com
  • 4 edits in trunk/WebKitLibraries

2011-01-07 Chris Marrin <cmarrin@apple.com>

Unreviewed.

Adding updated WKSI files missed in http://trac.webkit.org/changeset/75262

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
12:43 PM Changeset in webkit [75263] by senorblanco@chromium.org
  • 3 edits
    2 adds in trunk/LayoutTests

2011-01-07 Stephen White <senorblanco@chromium.org>

Unreviewed; new test baselines and updated chromium expectations.

  • platform/chromium-gpu/test_expectations.txt:
  • platform/chromium-linux/fast/gradients/css3-repeating-linear-gradients-expected.checksum: Added.
  • platform/chromium-linux/fast/gradients/css3-repeating-linear-gradients-expected.png: Added.
  • platform/chromium/test_expectations.txt:
12:00 PM Changeset in webkit [75262] by cmarrin@apple.com
  • 39 edits
    1 copy
    5 adds in trunk

2011-01-07 Chris Marrin <cmarrin@apple.com>

Rubber-stamped by Simon Fraser.

Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
https://bugs.webkit.org/show_bug.cgi?id=49388

Final step in unifying GraphicsLayer logic across Win and Mac. This
implements the Windows side classes for PlatformCALayer and supporting
classes. Also changed MediaPlayer to use new PlatformCALayerClient
so it can use PlatformCALayer directly rather than a dummy GraphicsLayer.
WKCACFLayerRenderer now does the task of notifying animations of their
start time. Also commented out an assert in AnimationBase because
AnimationController's frame time is not in sync with the new
AnimationTimeController. I've opened a new bug for that issue:

https://bugs.webkit.org/show_bug.cgi?id=52037


This also includes the Mac side changes backed out in
http://trac.webkit.org/changeset/75227.

11:58 AM BuildBot edited by Dimitri Glazkov
(diff)
11:46 AM Changeset in webkit [75261] by Nate Chapin
  • 5 edits
    2 adds in trunk

2011-01-07 Nate Chapin <Nate Chapin>

Reviewed by Darin Fisher.

Let PingLoader send cookies if FrameLoaderClient permits it.
https://bugs.webkit.org/show_bug.cgi?id=51898

Test: http/tests/navigation/ping-cookie.html

  • loader/PingLoader.cpp: (WebCore::PingLoader::PingLoader): Set m_shouldUseCredentialStorage

at load start time, since we won't be able to call
FrameLoaderClient::shouldUseCredentialStorage() later.

  • loader/PingLoader.h: (WebCore::PingLoader::shouldUseCredentialStorage):
11:41 AM Changeset in webkit [75260] by xan@webkit.org
  • 4 edits in trunk

2011-01-07 Xan Lopez <xlopez@igalia.com>

Unreviewed, rolling out r75256.
http://trac.webkit.org/changeset/75256
https://bugs.webkit.org/show_bug.cgi?id=50869

Broke GTK+ canvas tests

  • platform/gtk/Skipped:

2011-01-07 Xan Lopez <xlopez@igalia.com>

Unreviewed, rolling out r75256.
http://trac.webkit.org/changeset/75256
https://bugs.webkit.org/show_bug.cgi?id=50869

Broke GTK+ canvas tests

  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::addArc):
11:32 AM Changeset in webkit [75259] by Carlos Garcia Campos
  • 9 edits in trunk

2011-01-07 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Port scrollbar painting to GtkStyleContext
https://bugs.webkit.org/show_bug.cgi?id=52051

  • wtf/gobject/GTypedefs.h: Add GtkStyleContext forward declaration.

2011-01-07 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Port scrollbar painting to GtkStyleContext
https://bugs.webkit.org/show_bug.cgi?id=52051

Use GtkStyleContext API to paint scrollbars when building with
GTK+ 3.x.

No new tests. This should not change functionality.

  • platform/gtk/RenderThemeGtk.h:
  • platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::gtkScrollbarStyle):
  • platform/gtk/ScrollbarThemeGtk.cpp:
  • platform/gtk/ScrollbarThemeGtk.h:
  • platform/gtk/ScrollbarThemeGtk2.cpp: (WebCore::gtkStyleSetCallback): (WebCore::ScrollbarThemeGtk::ScrollbarThemeGtk):
  • platform/gtk/ScrollbarThemeGtk3.cpp: (WebCore::gtkStyleChangedCallback): (WebCore::ScrollbarThemeGtk::ScrollbarThemeGtk): (WebCore::ScrollbarThemeGtk::updateThemeProperties): (WebCore::ScrollbarThemeGtk::paintTrackBackground): (WebCore::ScrollbarThemeGtk::paintScrollbarBackground): (WebCore::ScrollbarThemeGtk::paintThumb): (WebCore::ScrollbarThemeGtk::paintButton):
11:31 AM Changeset in webkit [75258] by jberlin@webkit.org
  • 2 edits
    4 deletes in trunk/LayoutTests

Unreviewed, rolling out r75205.
http://trac.webkit.org/changeset/75205
https://bugs.webkit.org/show_bug.cgi?id=52026
https://bugs.webkit.org/show_bug.cgi?id=52028
https://bugs.webkit.org/show_bug.cgi?id=52029

The Windows 7 Release Test Bots are fixed.

  • platform/win/animations: Removed.
  • platform/win/animations/animation-time-expected.txt: Removed.
  • platform/win/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Removed.
  • platform/win/fast/css/css3-nth-tokens-script-expected.txt: Removed.
  • platform/win/fast/css/css3-nth-tokens-style-expected.txt: Removed.
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
11:27 AM Changeset in webkit [75257] by mitz@apple.com
  • 5 edits
    4 adds in trunk

<rdar://problem/8783318> Text emphasis marks should not appear over characters that have ruby annotations
https://bugs.webkit.org/show_bug.cgi?id=51267

Reviewed by Darin Adler.

WebCore:

Test: fast/text/emphasis-avoid-ruby.html

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesInBlockDirection): Use getEmphasisMarkPosition() to check if
there are text emphasis marks.
(WebCore::InlineFlowBox::addTextBoxVisualOverflow): Ditto.
(WebCore::InlineFlowBox::computeOverAnnotationAdjustment): Ditto.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::getEmphasisMarkPosition): Added. Returns true and sets the emphasis mark
position if the text is style with emphasis marks and there isn’t a ruby annotation that should
suppress them. Otherwise returns false.
(WebCore::InlineTextBox::paint): Use getEmphasisMarkPosition() to check if emphasis marks should
be painted.

  • rendering/InlineTextBox.h:

LayoutTests:

  • fast/text/emphasis-avoid-ruby-expected.checksum: Added.
  • fast/text/emphasis-avoid-ruby-expected.png: Added.
  • fast/text/emphasis-avoid-ruby-expected.txt: Added.
  • fast/text/emphasis-avoid-ruby.html: Added.
11:08 AM BuildBot edited by Dimitri Glazkov
(diff)
11:05 AM Changeset in webkit [75256] by alex
  • 4 edits in trunk

2011-01-07 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[cairo] Rendering a lot of arcs on top of each other causes time
outs in some tests
https://bugs.webkit.org/show_bug.cgi?id=50869

We avoid the situation where we have to render the same arc
multiple times over itself. Now it renders just one oval and
moves to the end angle.

  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::addArc):

2011-01-07 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[cairo] Rendering a lot of arcs on top of each other causes time
outs in some tests
https://bugs.webkit.org/show_bug.cgi?id=50869

Unskip canvas-largedraws.html after improving the performance for
big angles.

  • platform/gtk/Skipped:
10:58 AM Changeset in webkit [75255] by Carlos Garcia Campos
  • 2 edits in trunk/WebCore

2011-01-07 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Port buttons painting to GtkStyleContext
https://bugs.webkit.org/show_bug.cgi?id=51812

Use GtkStyleContext API to paint buttons when building with GTK+
3.x.

No new tests. This should not change functionality.

  • platform/gtk/RenderThemeGtk3.cpp: (WebCore::adjustRectForFocus): (WebCore::RenderThemeGtk::adjustRepaintRect): (WebCore::RenderThemeGtk::paintButton):
10:52 AM Changeset in webkit [75254] by zmo@google.com
  • 2 edits in trunk/WebCore

2011-01-07 Zhenyao Mo <zmo@google.com>

Unreviewed, build fix.

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::copyTexSubImage2D):
10:43 AM Changeset in webkit [75253] by jberlin@webkit.org
  • 5 edits in trunk/WebKit2

WebKit2: Need WKBundlePagePrivate equivalent of WebKit1's WebViewPrivate's setDefersCallbacks
https://bugs.webkit.org/show_bug.cgi?id=52038

Reviewed by Jon Honeycutt.

The implementation of WebKit1's WebViewPrivate's setDefersCallbacks on both Windows and Mac
calls WebCore::Page::setDefersLoading.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageSetDefersLoading):

  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setDefersLoading):

  • WebProcess/WebPage/WebPage.h:
10:35 AM BuildBot edited by Dimitri Glazkov
(diff)
10:32 AM BuildBot edited by Dimitri Glazkov
(diff)
10:31 AM BuildBot edited by Dimitri Glazkov
(diff)
10:26 AM BuildBot edited by Dimitri Glazkov
(diff)
10:23 AM BuildBot edited by Dimitri Glazkov
(diff)
10:19 AM Changeset in webkit [75252] by zmo@google.com
  • 8 edits in trunk

2011-01-06 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

copyTexSubImage2D shouldn't have undefined pixels
https://bugs.webkit.org/show_bug.cgi?id=51559

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::copyTexImage2D): Refactor to share some code with copyTexSubImage2D through helper function clip2D. (WebCore::WebGLRenderingContext::copyTexSubImage2D): Initialize undefined pixels to 0. (WebCore::WebGLRenderingContext::validateTexFuncLevel): Seperate the validation of level from validateTexFuncParameters. (WebCore::WebGLRenderingContext::validateTexFuncParameters): Ditto.
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLTexture.cpp: (WebCore::WebGLTexture::getType): Expose the type of a texture.
  • html/canvas/WebGLTexture.h:

2011-01-06 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

copyTexSubImage2D shouldn't have undefined pixels
https://bugs.webkit.org/show_bug.cgi?id=51559

  • fast/canvas/webgl/uninitialized-test-expected.txt:
  • fast/canvas/webgl/uninitialized-test.html: Add test cases for copyTexSubImage2D.
10:16 AM BuildBot edited by Dimitri Glazkov
(diff)
9:51 AM Changeset in webkit [75251] by zmo@google.com
  • 2 edits in trunk/WebCore

2011-01-07 Takashi Toyoshima <toyoshim@google.com>

Reviewed by Kenneth Russell.

cleanupAfterGraphicsCall() is never called in
WebGLRenderingContext::checkFramebufferStatus()
https://bugs.webkit.org/show_bug.cgi?id=51668

No new tests. This is a trivial bug.

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::checkFramebufferStatus):
9:34 AM Changeset in webkit [75250] by mario@webkit.org
  • 6 edits in trunk

2011-01-07 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Chris Fleizach.

GTK: AX: atk tests need to be updated after recent changes
https://bugs.webkit.org/show_bug.cgi?id=51932

Make sure we can always get the right accesssible parent for an
AtkObject when traversing the hierarchy bottom up.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (isRootObject): New function to check whether an AccessibilityObject is the root one or not, according to the latest changes in the hierarchy. (atkParentOfRootObject): Gets the appropriate AtkObject from GTK's GAIL as the parent of the root AtkObject from WebCore. (webkit_accessible_get_parent): Use atkParentOfRootObject. (webkit_accessible_get_index_in_parent): Ditto. (atkRole): Expose AccessibilityObjects with ScrollAreaRole as AtkObject's of role ATK_ROLE_SCROLLED_PANE.

2011-01-07 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Chris Fleizach.

GTK: AX: atk tests need to be updated after recent changes
https://bugs.webkit.org/show_bug.cgi?id=51932

Fix gtk_widget_get_accessible() in WebKitWebView to keep returning
the AtkObject of role ATK_ROLE_DOCUMENT_FRAME.

With the change to support WK2 accessibility, the root object of
the AX hierarchy is different from what GTK expects as the current
hirarchy right now includes a new accessible object as the parent
of the accessible web area (AXScrollView).

  • webkit/webkitwebview.cpp: (webkit_web_view_get_accessible): Return the first child of the wrapper associated to the root accessible object in the document, to keep everything in the GTK port working as it used to be.

Re-enable skipped ATK unit tests now they are passing again.

  • tests/testatk.c: (main): Re-enable skipped tests.
  • tests/testatkroles.c: (main): Ditto.
9:32 AM Changeset in webkit [75249] by zmo@google.com
  • 4 edits in trunk/WebCore

2011-01-07 Zhenyao Mo <zmo@google.com>

Unreviewed, Mac 32-bit build fix.
Use float instead of double in GL function arguments to avoid implicit type down casting.

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::blendColor): (WebCore::WebGLRenderingContext::clearColor): (WebCore::WebGLRenderingContext::clearDepth): (WebCore::WebGLRenderingContext::depthRange): (WebCore::WebGLRenderingContext::lineWidth): (WebCore::WebGLRenderingContext::polygonOffset): (WebCore::WebGLRenderingContext::sampleCoverage):
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLRenderingContext.idl:
9:26 AM Changeset in webkit [75248] by sfalken@apple.com
  • 11 edits in trunk

Set svn:ignore on Visual Studio .user files inside directories that can contain them.

9:07 AM Changeset in webkit [75247] by dbates@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-01-07 Daniel Bates <dbates@rim.com>

Reviewed by Martin Robinson.

Enable PCRE computed gotos when compiling with RCVT 4.0 or greater in GNU mode
https://bugs.webkit.org/show_bug.cgi?id=52034

Derived from a patch by Eli Fidler.

RVCT 4 or greater in GNU mode supports the computed goto GNU language extension
as per <http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/ch03s07s12.html>.

  • pcre/pcre_exec.cpp: Modified to check for feature, HAVE(COMPUTED_GOTO), instead of hardcoding the GCC compiler.
  • wtf/Platform.h: Define WTF_COMPILER_RVCT4_OR_GREATER if ARMCC_VERSION >= 400000.
8:56 AM Changeset in webkit [75246] by beidson@apple.com
  • 7 edits in trunk/WebKit2

<rdar://problem/8261624> and https://bugs.webkit.org/show_bug.cgi?id=47355
Change WebKit2 session restoring to restore the full back/forward list.

Reviewed by Darin Adler.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::registerNewWebBackForwardListItem): Let the UIProcess register its own

WebBackForwardListItems in its ID map upon creation.

  • UIProcess/WebProcessProxy.h:
  • UIProcess/cf/WebPageProxyCF.cpp:

(WebKit::WebPageProxy::restoreFromSessionStateData): Register each new list entry in the

UIProcess ID map.

  • WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::WebBackForwardListProxy::addItemFromUIProcess): Add this method to register UIProcess

created items without doing any of the other work normally associated with adding a new back/forward item
(such as notifying the UIProcess).

  • WebProcess/WebPage/WebBackForwardListProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::restoreSession): Map all of the back/forward list entries from the UIProcess then

cause a load of the current entry.

8:44 AM Changeset in webkit [75245] by senorblanco@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

2011-01-07 Stephen White <senorblanco@chromium.org>

Unreviewed; new test results and expectations updates.

Created new results for tests which do not fail on chrome win (failing
Safari results were recently checked in). Also assigned bugs to many
of my recent test_expectations updates.

  • platform/chromium-win/animations/animation-time-expected.txt: Added.
  • platform/chromium-win/fast/css/css3-nth-tokens-script-expected.txt: Added.
  • platform/chromium-win/fast/css/css3-nth-tokens-style-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
8:02 AM Changeset in webkit [75244] by Adam Roben
  • 2 edits in trunk/Tools

Build master fix

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunWebKitTests.start): Don't try to concatenate a list and a string.

7:55 AM Changeset in webkit [75243] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-07 Stephen White <senorblanco@chromium.org>

Unreviewed; chromium test expectations update.

  • platform/chromium/test_expectations.txt: A few tests that were flaky before are failing more frequently now.
5:59 AM Changeset in webkit [75242] by andreas.kling@nokia.com
  • 6 edits in trunk/WebKit/qt

2011-01-07 Andreas Kling <kling@webkit.org>

Reviewed by Adam Barth.

[Qt] Add selectedHtml function to QWebView
https://bugs.webkit.org/show_bug.cgi?id=35028

Add QWebView::selectedHtml() and QWebPage::selectedHtml()
which return the current selection range's HTML representation.

  • Api/qwebpage.cpp: (QWebPage::selectedHtml):
  • Api/qwebpage.h:
  • Api/qwebview.cpp: (QWebView::selectedText): (QWebView::selectedHtml):
  • Api/qwebview.h:
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::cursorMovements): (tst_QWebPage::textSelection): (tst_QWebPage::crashTests_LazyInitializationOfMainFrame): (tst_QWebPage::findText):
5:58 AM Changeset in webkit [75241] by Carlos Garcia Campos
  • 5 edits in trunk/WebCore

2011-01-07 Carlos Garcia Campos <cgarcia@igalia.com> and Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Port slider painting to GtkStyleContext
https://bugs.webkit.org/show_bug.cgi?id=51874

Use GtkStyleContext API to paint sliders when building with GTK+
3.x. Also move the code to adjust media slider to its own method
in RenderThemeGtk.cpp since it's common to both gtk 2 and 3.

No new tests. This should not change functionality.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::adjustMediaSliderThumbSize):
  • platform/gtk/RenderThemeGtk.h:
  • platform/gtk/RenderThemeGtk2.cpp: (WebCore::RenderThemeGtk::adjustSliderThumbSize):
  • platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::paintSliderTrack): (WebCore::RenderThemeGtk::paintSliderThumb): (WebCore::RenderThemeGtk::adjustSliderThumbSize):
5:07 AM Changeset in webkit [75240] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-01-07 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Csaba Osztrogonác.

run-qtwebkit-tests should be able to kill a testsuite.

Add new option in the script that can setup a timeout for a test.
If the test execution takes more then specified time then the test
would be terminated.

[Qt] run-qtwebkit-tests needs timeout
https://bugs.webkit.org/show_bug.cgi?id=51894

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
  • Scripts/run-qtwebkit-tests:
4:31 AM Changeset in webkit [75239] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Unreviewed fix after r75233.

Based on idea from Eric Seidel.

Add remote zip file handling to webkitpy.
https://bugs.webkit.org/show_bug.cgi?id=50901

  • Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
3:26 AM Changeset in webkit [75238] by benjamin.poulain@nokia.com
  • 2 edits in trunk/WebCore

2011-01-07 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] [WK2] QtWebKit does not build in debug, FileReader.cpp does not compile
https://bugs.webkit.org/show_bug.cgi?id=51992

Add the missing header. CString is used in debug by the calls to LOG().

  • fileapi/FileReader.cpp:
2:25 AM Changeset in webkit [75237] by alex
  • 3 edits
    4 adds in trunk

2011-01-07 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

Cairo's ContextShadow may mis-render some box shadows
https://bugs.webkit.org/show_bug.cgi?id=51374

The space required for the internal shadow of the corners was not
correctly considered.

  • platform/graphics/cairo/ContextShadowCairo.cpp: (WebCore::ContextShadow::drawRectShadow):

2011-01-07 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

Cairo's ContextShadow may mis-render some box shadows
https://bugs.webkit.org/show_bug.cgi?id=51374

Added new test to check rectangular tiled shadows.

  • platform/gtk/fast/css/rect-shadow-tiled-expected.checksum: Added.
  • platform/gtk/fast/css/rect-shadow-tiled-expected.png: Added.
  • platform/gtk/fast/css/rect-shadow-tiled-expected.txt: Added.
  • platform/gtk/fast/css/rect-shadow-tiled.html: Added.
1:49 AM Changeset in webkit [75236] by kinuko@chromium.org
  • 3 edits in trunk/LayoutTests

2011-01-07 Kinuko Yasuda <kinuko@chromium.org>

Unreviewed; an attempt to fix chromium bot failures by removing failing test line (they must be failing due to modificationTime accuracy error).

  • fast/filesystem/op-get-metadata-expected.txt:
  • fast/filesystem/resources/op-tests-helper.js: (runOperationTest.OperationTestHelper.this.testMetadataSuccessCallback):
1:46 AM Changeset in webkit [75235] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-01-07 Shane Stephens <shanestephens@google.com>

Reviewed by Eric Seidel.

svn-apply: should support git binary delta diffs
https://bugs.webkit.org/show_bug.cgi?id=38864

  • Scripts/VCSUtils.pm:
  • Scripts/svn-apply:
Note: See TracTimeline for information about the timeline view.