Timeline



Feb 5, 2011:

10:05 PM Changeset in webkit [77762] by mrowe@apple.com
  • 5 edits in branches/safari-533.20-branch

Versioning.

10:05 PM Changeset in webkit [77761] by mrowe@apple.com
  • 1 copy in tags/Safari-533.20.25

New tag.

10:00 PM Changeset in webkit [77760] by mrowe@apple.com
  • 1 edit in branches/safari-533.20-branch/WebKit/win/WebCoreSupport/WebContextMenuClient.cpp

Build fix.

9:24 PM Changeset in webkit [77759] by mjs@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-05 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

REGRESSION: New drawing area is causing some WebProcess crashes in layout tests
https://bugs.webkit.org/show_bug.cgi?id=53865
<rdar://problem/8963148>


  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode): Handle the case where this is called repeatedly without exiting accelerated composting mode first. (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): Handle the case of being called more than once.
9:05 PM Changeset in webkit [77758] by Dimitri Glazkov
  • 1 edit
    2 adds in trunk/LayoutTests

2011-02-05 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Add baselines for the test added in r77690.

  • platform/chromium-mac/media/video-frame-accurate-seek-expected.checksum: Added.
  • platform/chromium-mac/media/video-frame-accurate-seek-expected.png: Added.
6:58 PM Changeset in webkit [77757] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-02-05 Dimitri Glazkov <Dimitri Glazkov>

Remove passing canvas tests from expectations.

  • platform/chromium/test_expectations.txt: Removed passing tests.
6:44 PM Changeset in webkit [77756] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-02-05 Dimitri Glazkov <Dimitri Glazkov>

Remove passing tests whose results match mac/ and mac-leopard.

  • platform/chromium/test_expectations.txt: Removed passing tests.
6:07 PM Changeset in webkit [77755] by abarth@webkit.org
  • 8 edits in trunk/Source/WebCore

2011-02-05 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove unused parameter related to XSSAuditor
https://bugs.webkit.org/show_bug.cgi?id=53862

  • WebCore.exp.in:
  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeScript): (WebCore::ScriptController::executeIfJavaScriptURL):
  • bindings/ScriptControllerBase.h:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld): (WebCore::ScriptController::evaluate): (WebCore::ScriptController::executeScriptInWorld):
  • bindings/js/ScriptController.h:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate):
  • bindings/v8/ScriptController.h:
4:54 PM Changeset in webkit [77754] by Dimitri Glazkov
  • 1 edit
    125 deletes in trunk/LayoutTests

2011-02-05 Dimitri Glazkov <Dimitri Glazkov>

Remove results for failing SVG tests. I will add the new ones after the
bots tell me which ones aren't matching mac/ or mac-leopard/.

3:02 PM Changeset in webkit [77753] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-05 Adam Barth <abarth@webkit.org>

Fix Qt build.

  • WebCore.pro:
2:55 PM Changeset in webkit [77752] by abarth@webkit.org
  • 20 edits
    2 deletes in trunk/Source/WebCore

2011-02-05 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Delete XSSAuditor
https://bugs.webkit.org/show_bug.cgi?id=53859

The job of the XSSAuditor is now done by the XSSFilter. In the future,
we might rename XSSFilter to XSSAuditor.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
  • bindings/ScriptControllerBase.h:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::evaluateInWorld):
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::evaluate):
  • bindings/v8/ScriptController.h:
  • bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
  • dom/Document.cpp: (WebCore::Document::implicitOpen): (WebCore::Document::processBaseElement):
  • dom/ScriptableDocumentParser.cpp: (WebCore::ScriptableDocumentParser::ScriptableDocumentParser):
  • dom/ScriptableDocumentParser.h:
  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::shouldLoadExternalScriptFromSrc):
  • loader/SubframeLoader.cpp: (WebCore::SubframeLoader::requestObject): (WebCore::SubframeLoader::loadMediaPlayerProxyPlugin):
  • page/XSSAuditor.cpp: Removed.
  • page/XSSAuditor.h: Removed.
2:28 PM Changeset in webkit [77751] by andersca@apple.com
  • 18 edits in trunk/Source

2011-02-05 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Need a way to resize and scroll the page at the same time
https://bugs.webkit.org/show_bug.cgi?id=53814
<rdar://problem/8498008>

Export a function needed by WebKit2.

  • WebCore.exp.in:

2011-02-05 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Need a way to resize and scroll the page at the same time
https://bugs.webkit.org/show_bug.cgi?id=53814
<rdar://problem/8498008>

Add -[WKView setFrame:andScrollBy:].

  • UIProcess/API/mac/WKView.h:
  • UIProcess/API/mac/WKView.mm: (-[WKView setFrame:andScrollBy:]): Stash away the scroll offset and call setFrame:.

(-[WKView _switchToDrawingAreaTypeIfNecessary:DrawingAreaInfo::]):
(-[WKView _setDrawingAreaSize:]):

  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::setViewportSize): DrawingAreaProxy::setSize now takes a scroll offset.
  • UIProcess/DrawingAreaProxy.cpp: (WebKit::DrawingAreaProxy::setSize): This now takes a scroll offset and stores it in m_scrollOffset.
  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::sendSetSize): Send along the scroll offset and set it back to zero.
  • UIProcess/LayerBackedDrawingAreaProxy.cpp: (WebKit::LayerBackedDrawingAreaProxy::didSetSize):
  • UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::TiledDrawingAreaProxy::didSetSize):
  • UIProcess/win/WebView.cpp: (WebKit::WebView::onSizeEvent): (WebKit::WebView::switchToDrawingAreaTypeIfNecessary): DrawingAreaProxy::setSize now takes a scroll offset.


  • WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::setSize): Add a scrollOffset parameter.
  • WebProcess/WebPage/DrawingArea.messages.in: Add a scroll offset parameter to the SetSize message.
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setSize): Call WebPage::scrollMainFrameIfNotAtMaxScrollPosition.
  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::scrollMainFrameIfNotAtMaxScrollPosition): Compute a scroll offset and call setScrollPosition on the main frame view.
12:34 PM Changeset in webkit [77750] by Patrick Gansterer
  • 6 edits in trunk/Source/WebCore

2011-02-05 Patrick Gansterer <Patrick Gansterer>

Reviewed by Alexey Proskuryakov.

Use Document::encoding() instead of DocumentWriter::encoding()
https://bugs.webkit.org/show_bug.cgi?id=53398

This change makes the code more readable, when a subresource
inherits the character encoding of the document.

  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
  • dom/ScriptElement.cpp: (WebCore::ScriptElement::scriptCharset):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::requestPreload):
  • platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::encodingFromAcceptCharset):
12:30 PM Changeset in webkit [77749] by Patrick Gansterer
  • 7 edits
    1 add in trunk/LayoutTests

2011-02-05 Patrick Gansterer <Patrick Gansterer>

Reviewed by Alexey Proskuryakov.

Add addition test for inherited encoding
https://bugs.webkit.org/show_bug.cgi?id=53398

Check if the right encoding is used, after document.charset was set.

  • fast/dom/Document/document-charset.html: Added doctype to make it pass in IE9 out of the box.
  • fast/encoding/css-charset-default-expected.txt:
  • fast/encoding/css-charset-default.xhtml:
  • fast/encoding/external-script-charset-expected.txt:
  • fast/encoding/external-script-charset-koi-8.js: Added.
  • fast/encoding/external-script-charset.js:
  • fast/encoding/external-script-charset.xhtml:
12:21 PM Changeset in webkit [77748] by abarth@webkit.org
  • 6 edits
    1 add in trunk/Source/WebCore

2011-02-05 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Introduce URLString to represent a canonicalized URL represented by a string
https://bugs.webkit.org/show_bug.cgi?id=53847

Instead of using String all over the codebase to represent a URL,
instead we should have a type to represent a canonicalized URL in the
form of a string. This patch introduces that type.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/KURL.cpp: (WebCore::KURL::KURL):
  • platform/KURL.h: (WebCore::KURL::urlString):
10:26 AM Changeset in webkit [77747] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-05 Martin Robinson <mrobinson@igalia.com>

JSC::Bindings m_rootObject->isValid() assert fails when running layout tests
https://bugs.webkit.org/show_bug.cgi?id=53716

  • platform/gtk/Skipped: Skip a test hitting this assertion.
9:55 AM Changeset in webkit [77746] by robert@webkit.org
  • 4 edits in trunk

2011-02-05 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Style widgets not rendering
https://bugs.webkit.org/show_bug.cgi?id=53849

  • platform/qt/Skipped: Unskip plugins/application-plugins-plugins-disabled.html

2011-02-05 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Style widgets not rendering
https://bugs.webkit.org/show_bug.cgi?id=53849

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::hasValidClassId): x-qt-styled-widget is a valid class id too
9:19 AM Changeset in webkit [77745] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-02-05 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77720.
http://trac.webkit.org/changeset/77720
https://bugs.webkit.org/show_bug.cgi?id=53854

"Broke nrwt on Chromium win." (Requested by dglazkov|away on
#webkit).

  • Scripts/webkitpy/common/system/executive.py:
5:00 AM Changeset in webkit [77744] by Nikolas Zimmermann
  • 168 edits in trunk/LayoutTests

2011-02-04 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

small text which is scaled to be large renders pixelated
https://bugs.webkit.org/show_bug.cgi?id=12448

Update Snow Leopard SVG pixel test baseline after r77485.

  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png:

...

4:48 AM Changeset in webkit [77743] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2011-02-05 Eric Seidel <eric@webkit.org>

Unreviewed.

Safari should lowercase schemes in cannonicalized urls to match every other browser
https://bugs.webkit.org/show_bug.cgi?id=53848

Checkin results I forgot to update in my previous commit. All progressions.

  • fast/dom/anchor-origin-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
3:52 AM Changeset in webkit [77742] by jochen@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-02-05 Jochen Eisinger <jochen@chromium.org>

Reviewed by Adam Barth.

Add ContentSecurityPolicy object to Document and pass the X-WebKit-CSP header from the MainResourceLoader.
https://bugs.webkit.org/show_bug.cgi?id=53685

  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.h: (WebCore::Document::contentSecurityPolicy):
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didReceiveResponse):
  • page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::didReceiveHeader):
  • page/ContentSecurityPolicy.h:
3:43 AM Changeset in webkit [77741] by eric@webkit.org
  • 8 edits in trunk

2011-02-05 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Safari should lowercase schemes in cannonicalized urls to match every other browser
https://bugs.webkit.org/show_bug.cgi?id=53848

Update our results now that we pass more tests.

  • fast/url/file-expected.txt:
  • fast/url/file-http-base-expected.txt:
  • fast/url/path-url-expected.txt:
  • fast/url/relative-expected.txt:
  • fast/url/scheme-expected.txt:

2011-02-05 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Safari should lowercase schemes in cannonicalized urls to match every other browser
https://bugs.webkit.org/show_bug.cgi?id=53848

We're clearly the odd man out here. See results from every browser at:
https://github.com/abarth/url-spec/blob/master/tests/gurl-results/by-browser.txt

  • platform/KURL.cpp: (WebCore::KURL::parse):
    • Just lowercase the scheme when copying.
3:23 AM Changeset in webkit [77740] by Antti Koivisto
  • 4 edits in trunk/Source/WebCore

Optimize matching of descendant selectors
https://bugs.webkit.org/show_bug.cgi?id=49876
<rdar://problem/8772822>

Reviewed by Dave Hyatt.

During style recalculation, maintain a filter of tags, ids and classes seen in ancestor elements.
Use the filter to quickly reject descendant and child selectors when doing style matching.

This speeds up style recalculations 3-6x on many major web sites.

  • css/CSSStyleSelector.cpp:

(WebCore::RuleData::RuleData):
(WebCore::RuleData::descendantSelectorIdentifierHashes):
(WebCore::collectElementIdentifiers):
(WebCore::CSSStyleSelector::pushParent):
(WebCore::CSSStyleSelector::popParent):
(WebCore::CSSStyleSelector::fastRejectSelector):
(WebCore::CSSStyleSelector::matchRulesForList):
(WebCore::RuleData::collectDescendantSelectorIdentifierHashes):

  • css/CSSStyleSelector.h:

(WebCore::CSSStyleSelector::ParentStackFrame::ParentStackFrame):

  • dom/Element.cpp:

(WebCore::StyleSelectorParentPusher::StyleSelectorParentPusher):
(WebCore::StyleSelectorParentPusher::push):
(WebCore::StyleSelectorParentPusher::~StyleSelectorParentPusher):
(WebCore::Element::attach):
(WebCore::Element::recalcStyle):

3:12 AM Changeset in webkit [77739] by eric@webkit.org
  • 1 edit
    3 adds in trunk/PerformanceTests

2011-02-05 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add performance tests for URL parsing
https://bugs.webkit.org/show_bug.cgi?id=53845

The final-url-en URL corpus is from:
http://corpus.leeds.ac.uk/internet.html

There are also other language corpuses which we may want to use in the future.

The usage instructions were as follows:
"URL lists and other resources: you can freely use them in your research
provided that you supply a link to this website: http://corpus.leeds.ac.uk/."
Done.

  • Parser/simple-url.html: Added. On my machine: Firefox: 255ms TOT WebKit: 378ms Chrome: 286ms Opera: 2830ms (no, that is not a typo)
  • Parser/url-parser.html: Added. Firefox: 381ms TOT WebKit: 216ms Chrome: 131ms Opera: 1383ms (again, not a typo)
  • Parser/resources/final-url-en: Added.
2:37 AM Changeset in webkit [77738] by Nate Chapin
  • 5 edits in trunk/Source/WebCore

2011-02-05 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Refactor: NotificationCenter shouldn't hold its own copy of the ScriptExecutionContext*
when it inherits one from ActiveDOMObject.
https://bugs.webkit.org/show_bug.cgi?id=53815

  • bindings/js/JSDesktopNotificationsCustom.cpp: (WebCore::JSNotificationCenter::requestPermission):
  • bindings/v8/custom/V8NotificationCenterCustom.cpp: (WebCore::V8NotificationCenter::requestPermissionCallback):
  • notifications/NotificationCenter.cpp: (WebCore::NotificationCenter::NotificationCenter): (WebCore::NotificationCenter::checkPermission): (WebCore::NotificationCenter::requestPermission): (WebCore::NotificationCenter::disconnectFrame):
  • notifications/NotificationCenter.h: (WebCore::NotificationCenter::createHTMLNotification): (WebCore::NotificationCenter::createNotification):
12:02 AM Changeset in webkit [77737] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

2011-02-05 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77725.
http://trac.webkit.org/changeset/77725
https://bugs.webkit.org/show_bug.cgi?id=53844

It broke Qt minimal build (Requested by Ossy_ on #webkit).

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome):
  • QtTestBrowser/launcherwindow.h: (WindowOptions::WindowOptions):
  • QtTestBrowser/main.cpp: (LauncherApplication::handleUserOptions):

Feb 4, 2011:

11:38 PM Changeset in webkit [77736] by mihaip@chromium.org
  • 6 edits
    2 copies in branches/chromium/648

Merge 77705 - 2011-02-04 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Crash in WebCore::HistoryController::itemsAreClones
https://bugs.webkit.org/show_bug.cgi?id=52819

Tests that navigating back and forward between hash items works.

  • fast/history/history-back-forward-within-subframe-hash.html: Added.
  • fast/history/history-back-forward-within-subframe-hash-expected.txt: Added.

2011-02-04 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Crash in WebCore::HistoryController::itemsAreClones
https://bugs.webkit.org/show_bug.cgi?id=52819

Avoids deleting the current HistoryItem while it is still in use.
Ensures that provisional items are committed for same document navigations.
Ensures that error pages are committed on back/forward navigations.
Also removes unneeded sanity checks used for diagnosing the problem.

  • loader/HistoryController.cpp:
  • loader/HistoryController.h:

2011-02-04 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Crash in WebCore::HistoryController::itemsAreClones
https://bugs.webkit.org/show_bug.cgi?id=52819

Removes unneeded sanity checks used for diagnosing a memory error.

  • src/WebFrameImpl.cpp:

BUG=70315
TBR=creis@webkit.org
Review URL: http://codereview.chromium.org/6250180

11:35 PM Changeset in webkit [77735] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

2011-02-04 Jer Noble <jer.noble@apple.com>

Adding test to Qt Skipped list.

[Qt] media/video-frame-accurate-seek.html fails
https://bugs.webkit.org/show_bug.cgi?id=53843

  • platform/qt/Skipped:
10:25 PM Changeset in webkit [77734] by joone.hur@collabora.co.uk
  • 2 edits in trunk/Source/WebKit/gtk

2011-02-04 Joone Hur <joone.hur@collabora.co.uk>

Unreviewed, Fix compilation warning.

Constructor initialization list should follow the declaration order.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::FrameLoaderClient): m_hasRepresentation is moved to the last position in the initialization list.
10:24 PM Changeset in webkit [77733] by mrowe@apple.com
  • 20 edits in tags/Safari-534.18

Revert r77588 to work around <rdar://problem/8963096>.

10:03 PM Changeset in webkit [77732] by mrowe@apple.com
  • 5 edits in trunk/Source

Versioning.

10:01 PM Changeset in webkit [77731] by mrowe@apple.com
  • 1 copy in tags/Safari-534.18

New tag.

9:17 PM Changeset in webkit [77730] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2011-02-04 Adam Barth <abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Crash in WebCore::TextEncoding::decode below XSSFilter::init
https://bugs.webkit.org/show_bug.cgi?id=53837

Test that we can successfully execute a JavaScript URL when it isn't
blocked by the filter.

  • http/tests/security/xssAuditor/non-block-javascript-url-frame-expected.txt: Added.
  • http/tests/security/xssAuditor/non-block-javascript-url-frame.html: Added.

2011-02-04 Adam Barth <abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Crash in WebCore::TextEncoding::decode below XSSFilter::init
https://bugs.webkit.org/show_bug.cgi?id=53837

Add missing null check.

Test: http/tests/security/xssAuditor/non-block-javascript-url-frame.html

  • html/parser/XSSFilter.cpp: (WebCore::XSSFilter::init):
8:56 PM Changeset in webkit [77729] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

2011-02-04 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Crashes in ShadowBlur via WebKit2 FindController
https://bugs.webkit.org/show_bug.cgi?id=53830

Fix a crash cause by re-entering ShadowBlur, and add assertions to
detect when it happens.

The re-entrancy occurred when drawRectShadowWithTiling() filled
the interior of the shadow with fillRect() on the context
which still had the shadow state set. This would make another ShadowBlur
on the stack and call into the code again, potentially blowing away
the image buffer.

Fix by turning off shadows in the destination context while we're
drawing the tiled shadow. The non-tiled code path already did this.

Not testable because CSS shadows clip out the inside of the rect
being shadowed, and SVG uses fillPath, even for rects.

  • platform/graphics/ShadowBlur.cpp: (WebCore::ScratchBuffer::ScratchBuffer): (WebCore::ScratchBuffer::getScratchBuffer): (WebCore::ScratchBuffer::scheduleScratchBufferPurge): (WebCore::ShadowBlur::ShadowBlur): (WebCore::ShadowBlur::drawRectShadowWithTiling):
8:54 PM Changeset in webkit [77728] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-02-04 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adam Barth.

Skip a new test that uses EventSender
https://bugs.webkit.org/show_bug.cgi?id=53841

  • platform/mac-wk2/Skipped:
8:17 PM Changeset in webkit [77727] by commit-queue@webkit.org
  • 4 edits in trunk

2011-02-04 Martin Robinson <mrobinson@igalia.com>

Reviewed by Adam Barth.

[GTK] plugins/plugin-document-back-forward.html fails
https://bugs.webkit.org/show_bug.cgi?id=53833

  • platform/gtk/Skipped: Unskip test which is now passing.

2011-02-04 Martin Robinson <mrobinson@igalia.com>

Reviewed by Adam Barth.

[GTK] plugins/plugin-document-back-forward.html fails
https://bugs.webkit.org/show_bug.cgi?id=53833

Add the new "alert on load" functionality for the Unix version of the
test plugin. This functionality was originally introduced in r77706.

  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance): Add new plugin fuctionality.
7:37 PM Changeset in webkit [77726] by mrobinson@webkit.org
  • 17 edits in trunk

2011-02-04 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

Update expected results reflecting the change to search icon rendering.

  • platform/gtk/fast/css/input-search-padding-expected.checksum:
  • platform/gtk/fast/css/input-search-padding-expected.png:
  • platform/gtk/fast/css/input-search-padding-expected.txt:
  • platform/gtk/fast/forms/search-styled-expected.checksum:
  • platform/gtk/fast/forms/search-styled-expected.png:
  • platform/gtk/fast/forms/search-styled-expected.txt:
  • platform/gtk/fast/forms/search-vertical-alignment-expected.checksum:
  • platform/gtk/fast/forms/search-vertical-alignment-expected.png:
  • platform/gtk/fast/forms/search-zoomed-expected.checksum:
  • platform/gtk/fast/forms/search-zoomed-expected.png:
  • platform/gtk/fast/forms/search-zoomed-expected.txt:
  • platform/gtk/fast/forms/searchfield-heights-expected.checksum:
  • platform/gtk/fast/forms/searchfield-heights-expected.png:
  • platform/gtk/fast/forms/searchfield-heights-expected.txt:

2011-02-04 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Don't use a fixed size for search field icons
https://bugs.webkit.org/show_bug.cgi?id=50624

Use the parent input content box to make sure the icon fits in the
search field, scaling it down when needed.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::paintGdkPixbuf): (WebCore::getIconSizeForPixelSize): (WebCore::adjustSearchFieldIconStyle): (WebCore::RenderThemeGtk::adjustSearchFieldResultsDecorationStyle): (WebCore::centerRectVerticallyInParentInputElement): (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration): (WebCore::RenderThemeGtk::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeGtk::paintSearchFieldCancelButton): (WebCore::RenderThemeGtk::paintCapsLockIndicator): (WebCore::RenderThemeGtk::paintMediaButton):
7:11 PM Changeset in webkit [77725] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

2011-02-04 Kundu Suchismita <suchi.kundu@nokia.com>

Reviewed by Andreas Kling.

Local Storage settings can be enable/disable from "Develop" menu
https://bugs.webkit.org/show_bug.cgi?id=52296

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome): (LauncherWindow::toggleLocalStorage): (LauncherWindow::toggleOfflineStorageDatabase): (LauncherWindow::toggleOfflineWebApplicationCache): (LauncherWindow::setOfflineStorageDefaultQuota):
  • QtTestBrowser/launcherwindow.h: (WindowOptions::WindowOptions):
  • QtTestBrowser/main.cpp: (LauncherApplication::handleUserOptions):
7:05 PM Changeset in webkit [77724] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

2011-02-04 Hironori Bono <hbono@chromium.org>

Reviewed by Adam Barth.

[chromium] JPEG corruption
https://bugs.webkit.org/show_bug.cgi?id=53250

This change adds a new script test that we can render a CMYK JPEG with a
color profile correctly, i.e. we can render it without color corruption.

  • fast/images/cmyk-jpeg-with-color-profile-expected.txt: Added.
  • fast/images/cmyk-jpeg-with-color-profile.html: Added.
  • fast/images/resources/cmyk-jpeg.jpg: Added.
  • fast/images/script-tests/cmyk-jpeg-with-color-profile.js: Added. (image.onload):

2011-02-04 Hironori Bono <hbono@chromium.org>

Reviewed by Adam Barth.

[chromium] JPEG corruption
https://bugs.webkit.org/show_bug.cgi?id=53250

Same as gray-scale JPEGs, we convert the colors of CMYK JPEGs with color
profiles from CMYK to RGB twice and it causes color corruption. This
change suppresses the color profiles for CMYK JPEGs same as gray-scale
ones.

Test: fast/images/cmyk-jpeg-with-color-profile.html

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::decode):
6:57 PM Changeset in webkit [77723] by mrobinson@webkit.org
  • 254 edits
    15 adds in trunk/LayoutTests

2011-02-04 Martin Robinson <mrobinson@igalia.com>

Update pixel results for the fast/forms directory in preparation for landing
fixes to input type=search icon sizing. Also add some missing results. These
results are out of date because of changes to font hinting some time ago.

  • platform/gtk/fast/forms/
  • platform/gtk/fast/forms/input-placeholder-visibility-1-expected.checksum: Added.
  • platform/gtk/fast/forms/input-placeholder-visibility-1-expected.png: Added.
  • platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt: Added.
  • platform/gtk/fast/forms/input-placeholder-visibility-2-expected.checksum: Added.
  • platform/gtk/fast/forms/input-placeholder-visibility-2-expected.png: Added.
  • platform/gtk/fast/forms/input-placeholder-visibility-2-expected.txt: Added.
  • platform/gtk/fast/forms/input-placeholder-visibility-3-expected.checksum: Added.
  • platform/gtk/fast/forms/input-placeholder-visibility-3-expected.png: Added.
  • platform/gtk/fast/forms/input-placeholder-visibility-3-expected.txt: Added.
  • platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.checksum: Added.
  • platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
  • platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.txt: Added.
  • platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.checksum: Added.
  • platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
  • platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.txt: Added.
6:55 PM Changeset in webkit [77722] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-04 Adam Barth <abarth@webkit.org>

[Windows 7 Release Tests] plugins/plugin-document-back-forward.html failing since introduction in r77706
https://bugs.webkit.org/show_bug.cgi?id=53831

Stop dumping the child frames because that's not needed for this test
and cause extra output on Windows.

  • plugins/plugin-document-back-forward.html:
6:50 PM Changeset in webkit [77721] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-04 Adam Barth <abarth@webkit.org>

[GTK] plugins/plugin-document-back-forward.html fails
https://bugs.webkit.org/show_bug.cgi?id=53833

Add plugins/plugin-document-back-forward.html to skipped list while we
investigate the issue.

  • platform/gtk/Skipped:
6:39 PM Changeset in webkit [77720] by tony@chromium.org
  • 2 edits in trunk/Tools

2011-02-04 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

get test-webkitpy running on win32 python
https://bugs.webkit.org/show_bug.cgi?id=53822

The test harness crashes with a WindowsError because it can't find
'svn' when using subprocess.Popen. This gets us past the error
so we can see the failing tests on the Chromium Win Release Tests
bot.

  • Scripts/webkitpy/common/system/executive.py:
6:37 PM Changeset in webkit [77719] by mdelaney@apple.com
  • 1 edit
    51 moves
    3 adds in trunk/LayoutTests

2011-02-04 Matthew Delaney <mdelaney@apple.com>

Reviewed by Dan Bernstein.

Move canvas layout test expectations into more appropriate locations
https://bugs.webkit.org/show_bug.cgi?id=53145

  • platform/mac-snowleopard/canvas/philip/tests/2d.drawImage.broken-expected.txt: Removed.
  • ...
  • platform/mac-snowleopard/canvas/philip/tests/type.prototype-expected.txt: Removed.
  • platform/mac/canvas: Added.
  • platform/mac/canvas/philip: Added.
  • platform/mac/canvas/philip/tests: Added.
  • platform/mac/canvas/philip/tests/2d.drawImage.broken-expected.txt: Copied from platform/mac-snowleopard/canvas/philip/tests/2d.drawImage.broken-expected.txt.
  • ...
  • platform/mac/canvas/philip/tests/type.prototype-expected.txt: Copied from platform/mac-snowleopard/canvas/philip/tests/type.prototype-expected.txt.
6:30 PM Changeset in webkit [77718] by jberlin@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

[Windows 7 Release Tests] plugins/plugin-document-back-forward.html failing since
introduction in r77706.
https://bugs.webkit.org/show_bug.cgi?id=53831

Unreviewed. Add expected (failing?) results to get the Windows 7 Release Test bots green.

  • platform/win/plugins/plugin-document-back-forward-expected.txt: Added.
6:26 PM Changeset in webkit [77717] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-04 Martin Robinson <mrobinson@igalia.com>

Unskip some tests which should now be passing.

  • platform/gtk/Skipped: Unskip tests.
6:19 PM Changeset in webkit [77716] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-04 Xiyuan Xia <xiyuan@chromium.org>

Reviewed by Tony Chang.

[Chromium] Option text in select popup does not align with menulist button text
https://bugs.webkit.org/show_bug.cgi?id=53632

This makes clientPaddingLeft and clientPaddingRight return
the additional m_innerBlock's padding so that the popup item text
aligns with the menulist button text.

  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::clientPaddingLeft): (WebCore::RenderMenuList::clientPaddingRight):
6:18 PM Changeset in webkit [77715] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

REGRESSION: Horizontal scrollbar thumbs leave artifacts over page content when scrolling vertically
<rdar://problem/8962457>

Reviewed by Sam Weinig and Beth Dakin.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::scrollContents):
Subtract scrollbars from the scroll view rect if overlay scrollers are enabled.

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::setScrollOffsetFromAnimation):
Make sure to invalidate both scrollbars if overlay scrollers are enabled.

6:11 PM Changeset in webkit [77714] by mrobinson@webkit.org
  • 4 edits in trunk

2011-02-04 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] WebKitWebFrame can return a stale frame name when calling webkit_web_frame_get_name
https://bugs.webkit.org/show_bug.cgi?id=53797

  • platform/gtk/Skipped: Unskip a test which is now passing.

2011-02-04 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] WebKitWebFrame can return a stale frame name when calling webkit_web_frame_get_name
https://bugs.webkit.org/show_bug.cgi?id=53797

When the frame name changes between different calls to webkit_web_frame_get_name
on the same frame, return the new frame name instead of the one valid during the
previous call.

  • webkit/webkitwebframe.cpp: (webkit_web_frame_init): Initialize the frame name to 0. (webkit_web_frame_get_name): Check the current frame name first before returning the cached value.
6:04 PM Changeset in webkit [77713] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebKit2

WebKit2: Crash when InjectedBundlePageLoaderClient::willSendRequestForFrame returns a null WKURLRequestRef
https://bugs.webkit.org/show_bug.cgi?id=53829

Reviewed by Maciej Stachowiak.

Store the result of m_client.willSendRequestForFrame in a RefPtr, and null check it before
calling resourceRequest() on it.

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::willSendRequestForFrame):

5:58 PM Changeset in webkit [77712] by mrobinson@webkit.org
  • 7 edits
    1 add in trunk/LayoutTests

2011-02-04 Martin Robinson <mrobinson@igalia.com>

Rebaseline a few tests after r77665 and add a GTK-specific baseline
after r77690.

  • platform/gtk/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
  • platform/gtk/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt:
  • platform/gtk/fast/blockflow/japanese-ruby-vertical-lr-expected.txt:
  • platform/gtk/fast/blockflow/japanese-ruby-vertical-rl-expected.txt:
  • platform/gtk/fast/ruby/nested-ruby-expected.txt:
  • platform/gtk/fast/text/emphasis-avoid-ruby-expected.txt:
  • platform/gtk/media/video-frame-accurate-seek-expected.txt: Added.
5:45 PM Changeset in webkit [77711] by jberlin@webkit.org
  • 16 edits in trunk/LayoutTests

[Windows 7 Release Tests] 5 ruby tests failing on Windows after r77665
https://bugs.webkit.org/show_bug.cgi?id=53820

Unreviewed. Landing expected results that are probably correct (given that the change in
77665 was to make the default ruby text size smaller by default).

  • platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
  • platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
  • platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
  • platform/win/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum:
  • platform/win/fast/blockflow/japanese-ruby-horizontal-bt-expected.png:
  • platform/win/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt:
  • platform/win/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
  • platform/win/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
  • platform/win/fast/blockflow/japanese-ruby-vertical-lr-expected.txt:
  • platform/win/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
  • platform/win/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
  • platform/win/fast/blockflow/japanese-ruby-vertical-rl-expected.txt:
  • platform/win/fast/ruby/nested-ruby-expected.checksum:
  • platform/win/fast/ruby/nested-ruby-expected.png:
  • platform/win/fast/ruby/nested-ruby-expected.txt:
5:41 PM Changeset in webkit [77710] by mrobinson@webkit.org
  • 8 edits in trunk

2011-02-04 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] fast/events/pagehide-timeout.html fails
https://bugs.webkit.org/show_bug.cgi?id=53771

  • platform/gtk/Skipped: Unskip a test which is now passing.

2011-02-04 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] fast/events/pagehide-timeout.html fails
https://bugs.webkit.org/show_bug.cgi?id=53771

Add the document browser cache model. This model is optimized for viewing
a series of local files, while the document viewer is optimized for only
viewing one local file. Improve the documentation on the mapping of these
enum values to actual cache settings.

  • webkit/webkitglobals.cpp: (webkit_set_cache_model): Add support for the document browser cache model and improve comments in this section better explaining where the magic numbers come from.
  • webkit/webkitglobals.h: Added an enum value for the document browser cache model.

2011-02-04 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] fast/events/pagehide-timeout.html fails
https://bugs.webkit.org/show_bug.cgi?id=53771

Add knowledge of the document browser cache model the DRT. When resetting
WebKit settings to consistent values between tests, default to the document
browser cache model.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): Reset the cache model to the document browser cache model between tests.
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setCacheModel): An int value of 2 here corresponds to the document browser cache model.
5:33 PM Changeset in webkit [77709] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix build.

  • WebProcess/mac/WebProcessMac.mm:
5:32 PM Changeset in webkit [77708] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-04 Anders Carlsson <andersca@apple.com>

Reviewed by Mark Rowe.

Link opened in background tab fails to paint when activated if it completes loading before tab is selected
https://bugs.webkit.org/show_bug.cgi?id=53827
<rdar://problem/8962355>

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::resumePainting): Invalidate the entire page.
5:23 PM Changeset in webkit [77707] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix <rdar://problem/8961227> WebKit2 does not work with symlinked home directories.

Reviewed by Sam Weinig.

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::platformSetCacheModel):
Don't adopt an autoreleased pointer, this would lead to a crash.

(WebKit::appendSandboxParameterPath):
(WebKit::appendSandboxParameterConfPath):
(WebKit::initializeSandbox):
Clean up the sandbox parameter code and make sure that realpath is called for all parameters.

4:50 PM Changeset in webkit [77706] by abarth@webkit.org
  • 7 edits
    2 adds in trunk

2011-02-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

PluginDocuments don't create widgets for plugins on back/forward
https://bugs.webkit.org/show_bug.cgi?id=53474

Test that plugin loads when in a plugin document on back-forward.

  • plugins/plugin-document-back-forward-expected.txt: Added.
  • plugins/plugin-document-back-forward.html: Added.

2011-02-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

PluginDocuments don't create widgets for plugins on back/forward
https://bugs.webkit.org/show_bug.cgi?id=53474

Long ago, PluginDocument always caused the HTMLEmbedElement to create
its widget synchronously during a post-layout task. Recently, however,
some changes to the HistroyController caused layout on back/forward to
become slightly more complicated (and added an extra level of recursion
to layout). This extra level of recursion triggered the "I've recursed
too many times" condition in the post-layout task queue, causing the
FrameView to run the remainder of the tasks asynchronously.
Unfortunately, that broke PluginDocument because it needs its the
HTMLEmbedElement's updateWidget task to run synchronously.

This patch adds a mechanism for "kicking off" the pending post-layout
tasks synchronously (instead of waiting for the timer to fire).
PluginDocument then uses that facility to ensure that the
HTMLEmbedElement's updateWidget task happens.

Test: plugins/plugin-document-back-forward.html

  • html/PluginDocument.cpp: (WebCore::PluginDocumentParser::appendBytes):
  • page/FrameView.cpp: (WebCore::FrameView::flushAnyPendingPostLayoutTasks):
  • page/FrameView.h:

2011-02-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

PluginDocuments don't create widgets for plugins on back/forward
https://bugs.webkit.org/show_bug.cgi?id=53474

Teach the test plugin how to call alert on load.

  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_New):
4:48 PM Changeset in webkit [77705] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

2011-02-04 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Crash in WebCore::HistoryController::itemsAreClones
https://bugs.webkit.org/show_bug.cgi?id=52819

Tests that navigating back and forward between hash items works.

  • fast/history/history-back-forward-within-subframe-hash.html: Added.
  • fast/history/history-back-forward-within-subframe-hash-expected.txt: Added.

2011-02-04 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Crash in WebCore::HistoryController::itemsAreClones
https://bugs.webkit.org/show_bug.cgi?id=52819

Avoids deleting the current HistoryItem while it is still in use.
Ensures that provisional items are committed for same document navigations.
Ensures that error pages are committed on back/forward navigations.
Also removes unneeded sanity checks used for diagnosing the problem.

  • loader/HistoryController.cpp:
  • loader/HistoryController.h:

2011-02-04 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Crash in WebCore::HistoryController::itemsAreClones
https://bugs.webkit.org/show_bug.cgi?id=52819

Removes unneeded sanity checks used for diagnosing a memory error.

  • src/WebFrameImpl.cpp:
4:38 PM Changeset in webkit [77704] by Dimitri Glazkov
  • 2 edits
    3 adds in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Add expectations for the test, added in r77690.

  • platform/chromium-win/media/video-frame-accurate-seek-expected.checksum: Added.
  • platform/chromium-win/media/video-frame-accurate-seek-expected.png: Added.
  • platform/chromium-win/media/video-frame-accurate-seek-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
4:30 PM Changeset in webkit [77703] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Sandbox violations when visiting a site using HTTP authentication
<rdar://problem/8951079>

Reviewed by Mark Rowe.

  • WebProcess/com.apple.WebProcess.sb:
4:28 PM Changeset in webkit [77702] by carol.szabo@nokia.com
  • 6 edits
    2 adds in trunk

2011-02-04 Carol Szabo <carol.szabo@nokia.com>

Reviewed by David Hyatt.

Code Changes.

CSS 2.1 failure: content-*
https://bugs.webkit.org/show_bug.cgi?id=52126

  • fast/css/counters/content-021-expected.txt: Added.
  • fast/css/counters/content-021.html: Added. This is a copy of the test with the same name from the official css test suite, adapted for DumpRenderTree.

2011-02-04 Carol Szabo <carol.szabo@nokia.com>

Reviewed by David Hyatt.

Code Changes.

CSS 2.1 failure: content-*
https://bugs.webkit.org/show_bug.cgi?id=52126

Test: fast/css/counters/content-021.html

  • rendering/CounterNode.cpp: (showCounterTree): Made parameter const because it is supposed to be so.
  • rendering/RenderCounter.cpp: (WebCore::previousInPreOrder): (WebCore::previousSiblingOrParent): (WebCore::parentElement): (WebCore::areRenderersElementsSiblings): (WebCore::nextInPreOrder): Added these local helper functions to help navigate the DOM tree enriched with :before and :after pseudo elements. (WebCore::planCounter): Fixed bug that would create a repeat counter for second and subsequent renderers associated with the same DOM element. (WebCore::findPlaceForCounter): (WebCore::makeCounterNode): Changed to use the new tree navigation functions described above instead of the Renderer Tree navigation functions. (WebCore::RenderCounter::rendererSubtreeAttached): (WebCore::RenderCounter::rendererStyleChanged): Optimized to not bother about counters until the renderers are finally attached. (showRendererTree): (showNodeTree): Debug helper functions used to debug Counter bugs.
4:28 PM Changeset in webkit [77701] by ap@apple.com
  • 5 edits in trunk/Source/WebKit2

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=53823
Print layout sometimes seen on screen

<rdar://problem/8948742> REGRESSION (WebKit2) - When I print a page, I visually see it re-layout
<rdar://problem/8899389> REGRESSION(WebKit2): Wrong content can appear when print dialog is up

  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::setAutodisplay): Removed a branch that didn't do anything useful.
  • UIProcess/API/mac/WKPrintingView.h:
  • UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView _suspendAutodisplay]): (-[WKPrintingView _delayedResumeAutodisplayTimerFired]): (-[WKPrintingView _delayedResumeAutodisplay]): (-[WKPrintingView knowsPageRange:]): (-[WKPrintingView beginDocument]): (-[WKPrintingView endDocument]): When page setup changes, or when going from print preview to actual printing, AppKit calls -endDocument just to begin it again. Delay resuming autodisplay until the next run loop iteration.
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::invalidateContentsAndWindow): (WebKit::WebChromeClient::invalidateContentsForSlowScroll): Tightened it up from other side - we should never send pixels to UI process while in printing mode. This is not 100% reliable, because relayout doesn't happen immediately, and we can still have print layout in screen mode - but it helps.
4:26 PM Changeset in webkit [77700] by Dimitri Glazkov
  • 1 edit
    6 deletes in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Removed Chromium-specific baselines that are no longer necessary.

  • platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Removed.
  • platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Removed.
  • platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png: Removed.
4:20 PM Changeset in webkit [77699] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

2011-02-04 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Rolled back in r77612 with ASSERT/crash fixed.
https://bugs.webkit.org/show_bug.cgi?id=53759


Don't shrink the heap to 0 unconditionally. Instead, shrink to 1 if
necessary. For now, the heap assumes that it always has at least one
block live.

  • runtime/Heap.cpp: (JSC::Heap::Heap): (JSC::Heap::reset):
  • runtime/Heap.h:
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::allocate): (JSC::MarkedSpace::shrinkBlocks): (JSC::MarkedSpace::sweep): (JSC::MarkedSpace::reset):
  • runtime/MarkedSpace.h: (JSC::MarkedSpace::highWaterMark): (JSC::MarkedSpace::setHighWaterMark):
4:18 PM Changeset in webkit [77698] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Typo fix.

  • html/parser/XSSFilter.cpp:

(WebCore::HTMLNames::containsJavaScriptURL):

4:17 PM Changeset in webkit [77697] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Make an infinite loop introduced in r77454 finite.

Reviewed by Anders Carlsson.

  • html/parser/XSSFilter.cpp:

(WebCore::HTMLNames::containsJavaScriptURL):

4:16 PM Changeset in webkit [77696] by Dimitri Glazkov
  • 5 edits in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

Update Leopard pixel results for fast/box-shadow.

  • platform/mac-leopard/fast/box-shadow/basic-shadows-expected.checksum:
  • platform/mac-leopard/fast/box-shadow/basic-shadows-expected.png:
  • platform/mac-leopard/fast/box-shadow/inset-expected.checksum:
  • platform/mac-leopard/fast/box-shadow/inset-expected.png:
4:11 PM Changeset in webkit [77695] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix for <rdar://problem/8961580>.
Work around for <rdar://problem/8957845>.

Reviewed by Mark Rowe.

  • WebProcess/com.apple.WebProcess.sb:
4:11 PM Changeset in webkit [77694] by Darin Adler
  • 9 edits in trunk/Source/WebKit2

2011-02-04 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

WebKit2 doesn't hide mouse pointer on keypress
https://bugs.webkit.org/show_bug.cgi?id=53821
rdar://problem/8630895

  • UIProcess/PageClient.h: Renamed didNotHandleKeyEvent to doneWithKeyEvent and added a bool wasEventHandled argument.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveEvent): Changed code to call doneWithKeyEvent and call even if event was handled.
  • UIProcess/API/mac/PageClientImpl.h: Updated for above change.
  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::doneWithKeyEvent): Ditto. But also call [NSCursor setHiddenUntilMouseMoves:YES] when a key down event was handled. This matches what -[WebHTMLView keyDown:] does.
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::doneWithKeyEvent): Ditto.
  • UIProcess/API/qt/qwkpage_p.h: Ditto.
  • UIProcess/win/WebView.cpp: (WebKit::WebView::doneWithKeyEvent): Ditto.
  • UIProcess/win/WebView.h: Ditto.
3:49 PM Changeset in webkit [77693] by mrowe@apple.com
  • 5 edits in branches/safari-533.20-branch

Versioning.

3:49 PM Changeset in webkit [77692] by mrowe@apple.com
  • 1 copy in tags/Safari-533.20.24

New tag.

3:49 PM Changeset in webkit [77691] by mrowe@apple.com
  • 2 edits in branches/safari-533.20-branch/WebKit/win

Build fix.

3:48 PM Changeset in webkit [77690] by jer.noble@apple.com
  • 5 edits
    6 adds in trunk

2011-02-04 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

Frame accurate seeking isn't always accurate
https://bugs.webkit.org/show_bug.cgi?id=52697

New pixel test that seeks to specific currentTimes and records the rendered frame.

  • media/content/test-25fps.mp4: Added.
  • media/content/test-25fps.ogv: Added.
  • media/video-frame-accurate-seek-expected.txt: Added.
  • media/video-frame-accurate-seek.html: Added.
  • platform/mac/media/video-frame-accurate-seek-expected.checksum: Added.
  • platform/mac/media/video-frame-accurate-seek-expected.png: Added.

2011-02-04 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

Frame accurate seeking isn't always accurate
https://bugs.webkit.org/show_bug.cgi?id=52697

Test: media/video-frame-accurate-seek.html

Make seeking slightly more accurate by rounding instead of truncating
when converting from seconds-in-float to time/timeScale.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::createQTTime):
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::mediaTimeForTimeValue):
  • platform/graphics/win/QTMovie.cpp: (QTMovie::setCurrentTime):
3:45 PM Changeset in webkit [77689] by jorlow@chromium.org
  • 15 edits
    2 adds in trunk

2011-02-04 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Second IndexedDB events overhaul patch
https://bugs.webkit.org/show_bug.cgi?id=53813

  • storage/indexeddb/request-event-propagation-expected.txt: Added.
  • storage/indexeddb/request-event-propagation.html: Added.

2011-02-04 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Second IndexedDB events overhaul patch
https://bugs.webkit.org/show_bug.cgi?id=53813

If an IDBRequest has a IDBTransaction, it should propogate
events through it. In order to do this, IDBRequest needs to
hold a transaction frontend object rather than a backend one.

Test: storage/indexeddb/request-event-propagation.html

  • storage/IDBCursor.cpp: (WebCore::IDBCursor::IDBCursor):
  • storage/IDBCursor.h: (WebCore::IDBCursor::create):
  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::setSetVersionTransaction): (WebCore::IDBDatabase::createObjectStore): (WebCore::IDBDatabase::deleteObjectStore):
  • storage/IDBDatabase.h:
  • storage/IDBIndex.cpp: (WebCore::IDBIndex::IDBIndex): (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::openKeyCursor): (WebCore::IDBIndex::get): (WebCore::IDBIndex::getKey):
  • storage/IDBIndex.h: (WebCore::IDBIndex::create):
  • storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::IDBObjectStore): (WebCore::IDBObjectStore::get): (WebCore::IDBObjectStore::add): (WebCore::IDBObjectStore::put): (WebCore::IDBObjectStore::deleteFunction): (WebCore::IDBObjectStore::createIndex): (WebCore::IDBObjectStore::deleteIndex): (WebCore::IDBObjectStore::openCursor):
  • storage/IDBObjectStore.h: (WebCore::IDBObjectStore::create):
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::create): (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::resetReadyState): (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::dispatchEvent):
  • storage/IDBRequest.h:
  • storage/IDBTransaction.cpp: (WebCore::IDBTransaction::IDBTransaction): (WebCore::IDBTransaction::objectStore): (WebCore::IDBTransaction::contextDestroyed): (WebCore::IDBTransaction::enqueueEvent):
  • storage/IDBTransaction.h:
  • storage/IDBTransaction.idl:
3:43 PM Changeset in webkit [77688] by jorlow@chromium.org
  • 29 edits
    1 copy
    1 add in trunk

2011-02-04 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

First step towards event propogation within IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=53795

This is the first step towards implementing
http://www.w3.org/Bugs/Public/show_bug.cgi?id=11348
within IndexedDB. I've created a method that knows how
to capture and bubble (based on Node's dispatchGenericEvent).
I've then changed IDBRequest to use it.

The only functional change is that preventDefault now must
be called in error events to prevent the transaction from
being aborted. The tests reflect this change and there's one
specific test to look at this behavior.

  • storage/indexeddb/cursor-index-delete-expected.txt:
  • storage/indexeddb/cursor-index-delete.html:
  • storage/indexeddb/database-quota-expected.txt:
  • storage/indexeddb/database-quota.html:
  • storage/indexeddb/duplicates-expected.txt:
  • storage/indexeddb/duplicates.html:
  • storage/indexeddb/error-causes-abort-by-default-expected.txt: Copied from LayoutTests/storage/indexeddb/cursor-index-delete-expected.txt.
  • storage/indexeddb/error-causes-abort-by-default.html: Added.
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/objectstore-autoincrement-expected.txt:
  • storage/indexeddb/objectstore-autoincrement.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:

2011-02-04 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

First step towards event propogation within IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=53795

This is the first step towards implementing
http://www.w3.org/Bugs/Public/show_bug.cgi?id=11348
within IndexedDB. I've created a method that knows how
to capture and bubble (based on Node's dispatchGenericEvent).
I've then changed IDBRequest to use it.

The only functional change is that preventDefault now must
be called in error events to prevent the transaction from
being aborted. The tests reflect this change and there's one
specific test to look at this behavior.

Test: storage/indexeddb/error-causes-abort-by-default.html

  • storage/IDBAbortEvent.cpp: (WebCore::IDBAbortEvent::create): (WebCore::IDBAbortEvent::IDBAbortEvent):
  • storage/IDBAbortEvent.h:
  • storage/IDBCompleteEvent.cpp: (WebCore::IDBCompleteEvent::create): (WebCore::IDBCompleteEvent::IDBCompleteEvent):
  • storage/IDBCompleteEvent.h:
  • storage/IDBErrorEvent.cpp: (WebCore::IDBErrorEvent::IDBErrorEvent):
  • storage/IDBEvent.cpp: (WebCore::IDBEvent::IDBEvent): (WebCore::IDBEvent::dispatch):
  • storage/IDBEvent.h:
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::dispatchEvent):
  • storage/IDBRequest.h:
  • storage/IDBSuccessEvent.cpp: (WebCore::IDBSuccessEvent::IDBSuccessEvent):
  • storage/IDBTransaction.cpp: (WebCore::IDBTransaction::onAbort): (WebCore::IDBTransaction::onComplete):
  • storage/IDBTransaction.h: (WebCore::IDBTransaction::backend):
  • storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::taskTimerFired):
3:36 PM Changeset in webkit [77687] by dcheng@chromium.org
  • 13 edits in trunk/Source

2011-02-04 Daniel Cheng <dcheng@chromium.org>

Reviewed by Dmitry Titov.

Clone WebClipboard to be frame-specific.
https://bugs.webkit.org/show_bug.cgi?id=53727

For drop operations, Chrome currently snapshots the data and copies it
into the renderer process. As we add more supported drag data types, the
copy will become increasingly expensive. Instead, we'd like to snapshot
data in the browser to reduce the amount of data copied and to support
Blob in DataTransferItem. In order to allow this, we associated
WebClipboard with a frame so it can correctly route its IPCs to the
corresponding Chromium host.

No new tests because no new functionality.

  • platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::createReadable):
  • platform/chromium/ChromiumDataObject.h:
  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::create):
  • platform/chromium/PlatformBridge.h:
  • platform/chromium/ReadableDataObject.cpp: (WebCore::ReadableDataObject::create): (WebCore::ReadableDataObject::ReadableDataObject): (WebCore::ReadableDataObject::getData): (WebCore::ReadableDataObject::urlTitle): (WebCore::ReadableDataObject::htmlBaseUrl): (WebCore::ReadableDataObject::filenames): (WebCore::ReadableDataObject::ensureTypeCacheInitialized):
  • platform/chromium/ReadableDataObject.h:

2011-02-04 Daniel Cheng <dcheng@chromium.org>

Reviewed by Dmitry Titov.

Clone WebClipboard to be frame-specific.
https://bugs.webkit.org/show_bug.cgi?id=53727

For drop operations, Chrome currently snapshots the data and copies it
into the renderer process. As we add more supported drag data types, the
copy will become increasingly expensive. Instead, we'd like to snapshot
data in the browser to reduce the amount of data copied and to support
Blob in DataTransferItem. In order to allow this, we associated
WebClipboard with a frame so it can correctly route its IPCs to the
corresponding Chromium host.

  • public/WebFrameClient.h: (WebKit::WebFrameClient::clipboard):
  • src/PlatformBridge.cpp: (WebCore::getClipboard): (WebCore::PlatformBridge::clipboardReadAvailableTypes): (WebCore::PlatformBridge::clipboardReadData): (WebCore::PlatformBridge::clipboardReadFilenames):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::fromFrame):
  • src/WebFrameImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::dragTargetDragEnterNew):
3:34 PM Changeset in webkit [77686] by Dimitri Glazkov
  • 1 edit
    6 deletes in trunk/LayoutTests

[Chromium] Remove Chromium-specific baselines that we no longer need.

  • platform/chromium-mac-leopard/fast/ruby/nested-ruby-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/ruby/nested-ruby-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/ruby/ruby-beforeafter-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/ruby/ruby-beforeafter-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/ruby/ruby-run-break-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/ruby/ruby-run-break-expected.png: Removed.
3:33 PM Changeset in webkit [77685] by jorlow@chromium.org
  • 29 edits
    2 deletes in trunk

2011-02-04 Jeremy Orlow <jorlow@chromium.org>

Revert https://bugs.webkit.org/show_bug.cgi?id=53795

  • storage/indexeddb/cursor-index-delete-expected.txt:
  • storage/indexeddb/cursor-index-delete.html:
  • storage/indexeddb/cursor-update-expected.txt:
  • storage/indexeddb/cursor-update.html:
  • storage/indexeddb/database-quota-expected.txt:
  • storage/indexeddb/database-quota.html:
  • storage/indexeddb/duplicates-expected.txt:
  • storage/indexeddb/duplicates.html:
  • storage/indexeddb/error-causes-abort-by-default-expected.txt: Removed.
  • storage/indexeddb/error-causes-abort-by-default.html: Removed.
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/objectstore-autoincrement-expected.txt:
  • storage/indexeddb/objectstore-autoincrement.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:

2011-02-04 Jeremy Orlow <jorlow@chromium.org>

Revert https://bugs.webkit.org/show_bug.cgi?id=53795

  • storage/IDBAbortEvent.cpp: (WebCore::IDBAbortEvent::create): (WebCore::IDBAbortEvent::IDBAbortEvent):
  • storage/IDBAbortEvent.h:
  • storage/IDBCompleteEvent.cpp: (WebCore::IDBCompleteEvent::create): (WebCore::IDBCompleteEvent::IDBCompleteEvent):
  • storage/IDBCompleteEvent.h:
  • storage/IDBErrorEvent.cpp: (WebCore::IDBErrorEvent::IDBErrorEvent):
  • storage/IDBEvent.cpp: (WebCore::IDBEvent::IDBEvent):
  • storage/IDBEvent.h:
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::dispatchEvent):
  • storage/IDBRequest.h:
  • storage/IDBSuccessEvent.cpp: (WebCore::IDBSuccessEvent::IDBSuccessEvent):
  • storage/IDBTransaction.cpp: (WebCore::IDBTransaction::onAbort): (WebCore::IDBTransaction::onComplete):
  • storage/IDBTransaction.h:
  • storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::taskTimerFired):
3:19 PM Changeset in webkit [77684] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Marked test, added in r77680 as failing due to lighttpd.

  • platform/chromium/test_expectations.txt: Marked.
3:08 PM Changeset in webkit [77683] by Dimitri Glazkov
  • 8 edits
    6 deletes in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

Update Leopard baselines for fast/blockflow, this time correctly.

  • platform/mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
  • platform/mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
  • platform/mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.txt: Removed.
  • platform/mac-leopard/fast/blockflow/fieldsets-expected.png:
  • platform/mac-leopard/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum: Removed.
  • platform/mac-leopard/fast/blockflow/japanese-ruby-horizontal-bt-expected.png: Removed.
  • platform/mac-leopard/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt: Removed.
  • platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
  • platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
  • platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.txt: Removed.
  • platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
  • platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
  • platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.txt: Removed.
2:54 PM Changeset in webkit [77682] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-04 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

Merge in some GPU expectations that got dropped in r77666, get lint to pass.

  • platform/chromium/test_expectations.txt:
2:49 PM Changeset in webkit [77681] by Dimitri Glazkov
  • 33 edits
    4 adds in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

Add Leopard-specific pixel results for fast/ruby.

  • platform/mac-leopard/fast/ruby/nested-ruby-expected.checksum: Added.
  • platform/mac-leopard/fast/ruby/nested-ruby-expected.png: Added.
  • platform/mac-leopard/fast/ruby/ruby-beforeafter-expected.checksum: Added.
  • platform/mac-leopard/fast/ruby/ruby-beforeafter-expected.png: Added.
  • platform/mac-leopard/fast/ruby/ruby-empty-rt-expected.checksum:
  • platform/mac-leopard/fast/ruby/ruby-empty-rt-expected.png:
  • platform/mac-leopard/fast/ruby/ruby-length-expected.checksum:
  • platform/mac-leopard/fast/ruby/ruby-length-expected.png:
  • platform/mac-leopard/fast/ruby/ruby-run-break-expected.checksum:
  • platform/mac-leopard/fast/ruby/ruby-run-break-expected.png:
  • platform/mac-leopard/fast/ruby/ruby-runs-expected.checksum:
  • platform/mac-leopard/fast/ruby/ruby-runs-expected.png:
  • platform/mac-leopard/fast/ruby/ruby-runs-spans-expected.checksum:
  • platform/mac-leopard/fast/ruby/ruby-runs-spans-expected.png:
  • platform/mac-leopard/fast/ruby/ruby-simple-expected.checksum:
  • platform/mac-leopard/fast/ruby/ruby-simple-expected.png:
  • platform/mac-leopard/fast/ruby/ruby-simple-rp-expected.checksum:
  • platform/mac-leopard/fast/ruby/ruby-simple-rp-expected.png:
  • platform/mac-leopard/fast/ruby/ruby-trailing-expected.checksum:
  • platform/mac-leopard/fast/ruby/ruby-trailing-expected.png:
  • platform/mac-leopard/fast/ruby/rubyDOM-insert-rt-expected.checksum:
  • platform/mac-leopard/fast/ruby/rubyDOM-insert-rt-expected.png:
  • platform/mac-leopard/fast/ruby/rubyDOM-insert-text1-expected.checksum:
  • platform/mac-leopard/fast/ruby/rubyDOM-insert-text1-expected.png:
  • platform/mac-leopard/fast/ruby/rubyDOM-insert-text2-expected.checksum:
  • platform/mac-leopard/fast/ruby/rubyDOM-insert-text2-expected.png:
  • platform/mac-leopard/fast/ruby/rubyDOM-insert-text3-expected.checksum:
  • platform/mac-leopard/fast/ruby/rubyDOM-insert-text3-expected.png:
  • platform/mac-leopard/fast/ruby/rubyDOM-remove-rt1-expected.checksum:
  • platform/mac-leopard/fast/ruby/rubyDOM-remove-rt1-expected.png:
  • platform/mac-leopard/fast/ruby/rubyDOM-remove-rt2-expected.checksum:
  • platform/mac-leopard/fast/ruby/rubyDOM-remove-rt2-expected.png:
  • platform/mac-leopard/fast/ruby/rubyDOM-remove-text1-expected.checksum:
  • platform/mac-leopard/fast/ruby/rubyDOM-remove-text1-expected.png:
  • platform/mac-leopard/fast/ruby/rubyDOM-remove-text2-expected.checksum:
  • platform/mac-leopard/fast/ruby/rubyDOM-remove-text2-expected.png:
2:41 PM Changeset in webkit [77680] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2011-02-04 Martin Galpin <martin@66laps.com>

Reviewed by David Levin.

CORS origin header not set on GET when a preflight request is required.
https://bugs.webkit.org/show_bug.cgi?id=50773

  • http/tests/xmlhttprequest/cross-origin-preflight-get-expected.txt: Added.
  • http/tests/xmlhttprequest/cross-origin-preflight-get.html: Added.
  • http/tests/xmlhttprequest/resources/cross-origin-preflight-get.php: Added.

2011-02-04 Martin Galpin <martin@66laps.com>

Reviewed by David Levin.

CORS origin header not set on GET when a preflight request is required.
https://bugs.webkit.org/show_bug.cgi?id=50773

Test: http/tests/xmlhttprequest/cross-origin-preflight-get.html

  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::preflightSuccess): Explicitly set the request origin after a preflight request succeeds.
2:38 PM Changeset in webkit [77679] by jorlow@chromium.org
  • 29 edits
    1 copy
    1 add in trunk

2011-02-04 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

First step towards event propogation within IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=53795

This is the first step towards implementing
http://www.w3.org/Bugs/Public/show_bug.cgi?id=11348
within IndexedDB. I've created a method that knows how
to capture and bubble (based on Node's dispatchGenericEvent).
I've then changed IDBRequest to use it.

The only functional change is that preventDefault now must
be called in error events to prevent the transaction from
being aborted. The tests reflect this change and there's one
specific test to look at this behavior.

  • storage/indexeddb/cursor-index-delete-expected.txt:
  • storage/indexeddb/cursor-index-delete.html:
  • storage/indexeddb/database-quota-expected.txt:
  • storage/indexeddb/database-quota.html:
  • storage/indexeddb/duplicates-expected.txt:
  • storage/indexeddb/duplicates.html:
  • storage/indexeddb/error-causes-abort-by-default-expected.txt: Copied from LayoutTests/storage/indexeddb/cursor-index-delete-expected.txt.
  • storage/indexeddb/error-causes-abort-by-default.html: Added.
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/objectstore-autoincrement-expected.txt:
  • storage/indexeddb/objectstore-autoincrement.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:

2011-02-04 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

First step towards event propogation within IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=53795

This is the first step towards implementing
http://www.w3.org/Bugs/Public/show_bug.cgi?id=11348
within IndexedDB. I've created a method that knows how
to capture and bubble (based on Node's dispatchGenericEvent).
I've then changed IDBRequest to use it.

The only functional change is that preventDefault now must
be called in error events to prevent the transaction from
being aborted. The tests reflect this change and there's one
specific test to look at this behavior.

Test: storage/indexeddb/error-causes-abort-by-default.html

  • storage/IDBAbortEvent.cpp: (WebCore::IDBAbortEvent::create): (WebCore::IDBAbortEvent::IDBAbortEvent):
  • storage/IDBAbortEvent.h:
  • storage/IDBCompleteEvent.cpp: (WebCore::IDBCompleteEvent::create): (WebCore::IDBCompleteEvent::IDBCompleteEvent):
  • storage/IDBCompleteEvent.h:
  • storage/IDBErrorEvent.cpp: (WebCore::IDBErrorEvent::IDBErrorEvent):
  • storage/IDBEvent.cpp: (WebCore::IDBEvent::IDBEvent): (WebCore::IDBEvent::dispatch):
  • storage/IDBEvent.h:
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::dispatchEvent):
  • storage/IDBRequest.h:
  • storage/IDBSuccessEvent.cpp: (WebCore::IDBSuccessEvent::IDBSuccessEvent):
  • storage/IDBTransaction.cpp: (WebCore::IDBTransaction::onAbort): (WebCore::IDBTransaction::onComplete):
  • storage/IDBTransaction.h: (WebCore::IDBTransaction::backend):
  • storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::taskTimerFired):
2:37 PM Changeset in webkit [77678] by sfalken@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-02-04 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

WebKit2 clients fail to launch on Windows if client exe is in a different directory from WebKit
https://bugs.webkit.org/show_bug.cgi?id=53810
<rdar://problem/8946085>


If WebKit2WebProcess.exe is in a different directory from the client process, and that
client process uses CreateProcess to launch WebKit2WebProcess, the DLL search path may
end up excluding the directory containing WebKit. To address this, we use SetDllDirectory
to explicitly include the WebKit directory in the DLL search path.

  • win/MainWin.cpp: (wWinMain): Use SetDllDirectory and LoadLibrary to load WebKit.dll from WebKit2WebProcess.exe
  • win/WebKit2WebProcessCommon.vsprops: Don't link directly to WebKit. Link against shlwapi.
2:31 PM Changeset in webkit [77677] by sfalken@apple.com
  • 2 edits in trunk/WebKitLibraries

2011-02-04 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Bump Windows minimum system requirement to XPSP2
https://bugs.webkit.org/show_bug.cgi?id=53807

  • win/tools/vsprops/common.vsprops:
2:29 PM Changeset in webkit [77676] by Dimitri Glazkov
  • 104 edits in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Updated Win and Linux baselines after r77665.

2:08 PM Changeset in webkit [77675] by xji@chromium.org
  • 7 edits in trunk/LayoutTests

2011-02-04 Xiaomei Ji <xji@chromium.org>

Unreviewed.

Rebaseline chromium after r77654.
text-align attribute in <select> is ignored both in button text and drop-down
items.

  • platform/chromium-linux/fast/text/international/bidi-menulist-expected.checksum:
  • platform/chromium-linux/fast/text/international/bidi-menulist-expected.png:
  • platform/chromium-linux/fast/text/international/bidi-menulist-expected.txt:
  • platform/chromium-win/fast/text/international/bidi-menulist-expected.checksum:
  • platform/chromium-win/fast/text/international/bidi-menulist-expected.png:
  • platform/chromium-win/fast/text/international/bidi-menulist-expected.txt:
2:05 PM Changeset in webkit [77674] by Dimitri Glazkov
  • 1 edit
    34 adds in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

Add Leopard-specific pixel results for fast/blockflow.

  • platform/mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Added.
  • platform/mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.png: Added.
  • platform/mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.txt: Added.
  • platform/mac-leopard/fast/blockflow/block-level-images-expected.checksum: Added.
  • platform/mac-leopard/fast/blockflow/block-level-images-expected.png: Added.
  • platform/mac-leopard/fast/blockflow/border-vertical-lr-expected.checksum: Added.
  • platform/mac-leopard/fast/blockflow/border-vertical-lr-expected.png: Added.
  • platform/mac-leopard/fast/blockflow/english-bt-text-expected.checksum: Added.
  • platform/mac-leopard/fast/blockflow/english-bt-text-expected.png: Added.
  • platform/mac-leopard/fast/blockflow/english-lr-text-expected.checksum: Added.
  • platform/mac-leopard/fast/blockflow/english-lr-text-expected.png: Added.
  • platform/mac-leopard/fast/blockflow/japanese-lr-selection-expected.checksum: Added.
  • platform/mac-leopard/fast/blockflow/japanese-lr-selection-expected.png: Added.
  • platform/mac-leopard/fast/blockflow/japanese-lr-text-expected.checksum: Added.
  • platform/mac-leopard/fast/blockflow/japanese-lr-text-expected.png: Added.
  • platform/mac-leopard/fast/blockflow/japanese-rl-selection-expected.checksum: Added.
  • platform/mac-leopard/fast/blockflow/japanese-rl-selection-expected.png: Added.
  • platform/mac-leopard/fast/blockflow/japanese-rl-text-expected.checksum: Added.
  • platform/mac-leopard/fast/blockflow/japanese-rl-text-expected.png: Added.
  • platform/mac-leopard/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum: Added.
  • platform/mac-leopard/fast/blockflow/japanese-ruby-horizontal-bt-expected.png: Added.
  • platform/mac-leopard/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt: Added.
  • platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Added.
  • platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
  • platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.txt: Added.
  • platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Added.
  • platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
  • platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.txt: Added.
  • platform/mac-leopard/fast/blockflow/vertical-align-table-baseline-expected.checksum: Added.
  • platform/mac-leopard/fast/blockflow/vertical-align-table-baseline-expected.png: Added.
  • platform/mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.checksum: Added.
  • platform/mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
  • platform/mac-leopard/fast/blockflow/vertical-font-fallback-expected.checksum: Added.
  • platform/mac-leopard/fast/blockflow/vertical-font-fallback-expected.png: Added.
1:53 PM Changeset in webkit [77673] by Dimitri Glazkov
  • 2 edits
    6 deletes in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

Remove platform-specific baselines, since we match platform/mac here.

  • platform/chromium-mac/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Removed.
  • platform/chromium-mac/fast/blockflow/box-shadow-horizontal-bt-expected.png: Removed.
  • platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Removed.
  • platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.png: Removed.
  • platform/chromium-mac/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Removed.
  • platform/chromium-mac/fast/blockflow/box-shadow-vertical-rl-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
1:50 PM Changeset in webkit [77672] by Adam Roben
  • 7 edits
    2 adds in trunk

Add a test case for encode/decode of FormData/FormDataElement

If the fix made in r77401 is broken, this new test will crash.

Fixes <http://webkit.org/b/53616> <rdar://problem/8949883>.

Reviewed by Sam Weinig.

Tools:

  • TestWebKitAPI/Test.h: Moved the bulk of TEST_ASSERT into a new _TEST_ASSERT_HELPER macro.

Added a new TEST_ASSERT_RETURN macro that can be used in functions with a return value.

  • TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: Added.

(TestWebKitAPI::didFinishLoadForFrame): Record that the load is finished.
(TestWebKitAPI::setPageLoaderClient): Hook up the loader client.
(TestWebKitAPI::createSessionStateContainingFormData): Load simple-form.html, submit the
form, an return the session state data.
(TestWebKitAPI::TEST): Create some session state that contains form data from one WKPage,
and restore it into another WKPage.

  • TestWebKitAPI/Tests/WebKit2/simple-form.html: Added.
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
  • TestWebKitAPI/win/copy-resources.cmd:

Added new files.

Source/WebKit2:

Allow passing a null filter callback to WKPageCopySessionState

  • UIProcess/cf/WebBackForwardListCF.cpp:

(WebKit::WebBackForwardList::createCFDictionaryRepresentation): Check if the filter is null
before calling it.

1:50 PM Changeset in webkit [77671] by Adam Roben
  • 4 edits
    2 adds in trunk/Tools

Move code to run JavaScript tests into its own files

This will allow other tests to use this mechanism.

Fixes <http://webkit.org/b/53806> SpacebarScrolling should share its JavaScript-fu with the
world

Reviewed by Sam Weinig.

  • TestWebKitAPI/JavaScriptTest.cpp: Added.
  • TestWebKitAPI/JavaScriptTest.h: Added.

Moved code here...

  • TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: ...from here.
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:

Added the new files.

1:48 PM Changeset in webkit [77670] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Update mac expectations.

  • platform/chromium/test_expectations.txt: Updated.
1:43 PM Changeset in webkit [77669] by Dimitri Glazkov
  • 4 edits in trunk

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Csaba Osztrogonác.

[Qt]REGRESSION(r76951): media/controls-without-preload.html fails
https://bugs.webkit.org/show_bug.cgi?id=53674

  • platform/qt/Skipped:

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Csaba Osztrogonác.

[Qt]REGRESSION(r76951): media/controls-without-preload.html fails
https://bugs.webkit.org/show_bug.cgi?id=53674

  • css/mediaControlsQt.css:
1:27 PM Changeset in webkit [77668] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-04 Mihai Parparita <mihaip@chromium.org>

Unreviewed GTK expectations update.

Unskip fast/history/timed-refresh-in-cached-frame.html, it should pass
with http://trac.webkit.org/changeset/77559.

  • platform/gtk/Skipped:
1:25 PM Changeset in webkit [77667] by bweinstein@apple.com
  • 8 edits in trunk/Source/WebKit2

WebKit2: DidInitiateLoadForResource needs to know if the resource is being loaded by a committed or provisional frame
https://bugs.webkit.org/show_bug.cgi?id=53794

Reviewed by John Sullivan.

When we navigate from one page to another, there can be multiple subresource requests between when
the new page has started its provisional load and when it has committed the load.

There can be:

  • The main resource load of the provisional page
  • Synchronous XHR from the unload event of the loaded page.


WebKit clients need to be able to differentiate between these loads.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didInitiateLoadForResource): Pass whether or not the page is provisionally loading

to the client.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in: Add a new parameter to DidInitiateLoadForResource.
  • UIProcess/WebResourceLoadClient.cpp:

(WebKit::WebResourceLoadClient::didInitiateLoadForResource): a new parameter to didInitiateLoadForResource.

  • UIProcess/WebResourceLoadClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::assignIdentifierToInitialRequest): Pass whether or not the page is currently

in a provisional load (checked by seeing if the DocumentLoader matches the FrameLoader's provisionalDocumentLoader)
to the UI Process.

1:21 PM Changeset in webkit [77666] by dpranke@chromium.org
  • 7 edits
    1 delete in trunk

2011-02-04 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

merge test expectations for chromium, chromium-gpu. From
now on, we will track GPU-specific expectations with the
"GPU" modifier in the main file, rather than in a separate
file (and non-GPU-specific expectations with the "CPU"
modifier.

https://bugs.webkit.org/show_bug.cgi?id=53562

  • platform/chromium-gpu/test_expectations.txt: Removed.
  • platform/chromium/test_expectations.txt:

2011-02-04 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

merge test expectations for chromium, chromium-gpu. The
chromium-gpu port will no longer maintain its own
test expectations file.

Also add in a graphics_type() call on the port object to
determine what graphics type to use in the test configuration,
and log the configuration as a config setting.

https://bugs.webkit.org/show_bug.cgi?id=53562

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1:18 PM Changeset in webkit [77665] by mitz@apple.com
  • 78 edits in trunk

<rdar://problem/8902704> Make ruby text size 50% by default
https://bugs.webkit.org/show_bug.cgi?id=53723

Reviewed by Darin Adler and Dave Hyatt.

Source/WebCore:

  • css/html.css:

(ruby > rt): Changed the font-size from 60% to 50%.

LayoutTests:

  • fast/text/emphasis-avoid-ruby-expected.checksum:
  • fast/text/emphasis-avoid-ruby-expected.png:
  • fast/text/emphasis-avoid-ruby-expected.txt:
  • platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
  • platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
  • platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
  • platform/mac/fast/blockflow/box-shadow-horizontal-bt-expected.checksum:
  • platform/mac/fast/blockflow/box-shadow-horizontal-bt-expected.png:
  • platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum:
  • platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.png:
  • platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.checksum:
  • platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.png:
  • platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum:
  • platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.png:
  • platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt:
  • platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
  • platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
  • platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
  • platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
  • platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.txt:
  • platform/mac/fast/ruby/nested-ruby-expected.checksum:
  • platform/mac/fast/ruby/nested-ruby-expected.png:
  • platform/mac/fast/ruby/nested-ruby-expected.txt:
  • platform/mac/fast/ruby/ruby-beforeafter-expected.checksum:
  • platform/mac/fast/ruby/ruby-beforeafter-expected.png:
  • platform/mac/fast/ruby/ruby-beforeafter-expected.txt:
  • platform/mac/fast/ruby/ruby-empty-rt-expected.checksum:
  • platform/mac/fast/ruby/ruby-empty-rt-expected.png:
  • platform/mac/fast/ruby/ruby-empty-rt-expected.txt:
  • platform/mac/fast/ruby/ruby-length-expected.checksum:
  • platform/mac/fast/ruby/ruby-length-expected.png:
  • platform/mac/fast/ruby/ruby-length-expected.txt:
  • platform/mac/fast/ruby/ruby-run-break-expected.checksum:
  • platform/mac/fast/ruby/ruby-run-break-expected.png:
  • platform/mac/fast/ruby/ruby-run-break-expected.txt:
  • platform/mac/fast/ruby/ruby-runs-expected.checksum:
  • platform/mac/fast/ruby/ruby-runs-expected.png:
  • platform/mac/fast/ruby/ruby-runs-expected.txt:
  • platform/mac/fast/ruby/ruby-runs-spans-expected.checksum:
  • platform/mac/fast/ruby/ruby-runs-spans-expected.png:
  • platform/mac/fast/ruby/ruby-runs-spans-expected.txt:
  • platform/mac/fast/ruby/ruby-simple-expected.checksum:
  • platform/mac/fast/ruby/ruby-simple-expected.png:
  • platform/mac/fast/ruby/ruby-simple-expected.txt:
  • platform/mac/fast/ruby/ruby-simple-rp-expected.checksum:
  • platform/mac/fast/ruby/ruby-simple-rp-expected.png:
  • platform/mac/fast/ruby/ruby-simple-rp-expected.txt:
  • platform/mac/fast/ruby/ruby-trailing-expected.checksum:
  • platform/mac/fast/ruby/ruby-trailing-expected.png:
  • platform/mac/fast/ruby/ruby-trailing-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-insert-rt-expected.checksum:
  • platform/mac/fast/ruby/rubyDOM-insert-rt-expected.png:
  • platform/mac/fast/ruby/rubyDOM-insert-rt-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-insert-text1-expected.checksum:
  • platform/mac/fast/ruby/rubyDOM-insert-text1-expected.png:
  • platform/mac/fast/ruby/rubyDOM-insert-text1-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-insert-text2-expected.checksum:
  • platform/mac/fast/ruby/rubyDOM-insert-text2-expected.png:
  • platform/mac/fast/ruby/rubyDOM-insert-text2-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-insert-text3-expected.checksum:
  • platform/mac/fast/ruby/rubyDOM-insert-text3-expected.png:
  • platform/mac/fast/ruby/rubyDOM-insert-text3-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.checksum:
  • platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.png:
  • platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.checksum:
  • platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.png:
  • platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-remove-text1-expected.checksum:
  • platform/mac/fast/ruby/rubyDOM-remove-text1-expected.png:
  • platform/mac/fast/ruby/rubyDOM-remove-text1-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-remove-text2-expected.checksum:
  • platform/mac/fast/ruby/rubyDOM-remove-text2-expected.png:
  • platform/mac/fast/ruby/rubyDOM-remove-text2-expected.txt:
1:16 PM Changeset in webkit [77664] by Antti Koivisto
  • 3 edits
    4 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=53610
Regression: adjacent sibling selector not working as expected
<rdar://problem/8960033>

Reviewed by Dimitri Glazkov.

Source/WebCore:

https://bugs.webkit.org/show_bug.cgi?id=53574
REGRESSION (r76012): :last-child:after not working as expected
<rdar://problem/8948643>

Test for additional conditions in parent style that prevent sharing.

Tests: fast/selectors/style-sharing-adjacent-selector.html

fast/selectors/style-sharing-last-child.html

  • css/CSSStyleSelector.cpp:

(WebCore::parentStylePreventsSharing):
(WebCore::CSSStyleSelector::locateSharedStyle):

LayoutTests:

https://bugs.webkit.org/show_bug.cgi?id=53574
REGRESSION (r76012): :last-child:after not working as expected
<rdar://problem/8948643>

  • fast/selectors/style-sharing-adjacent-selector-expected.txt: Added.
  • fast/selectors/style-sharing-adjacent-selector.html: Added.
  • fast/selectors/style-sharing-last-child-expected.txt: Added.
  • fast/selectors/style-sharing-last-child.html: Added.
1:11 PM Changeset in webkit [77663] by dpranke@chromium.org
  • 2 edits
    1 add in trunk/Source/WebCore

2011-02-04 Mark Mentovai <mark@chromium.org>

Reviewed by Dimitri Glazkov.


Chromium GYP build fix.


When various settings were moved to webcore_prerequisites in r66364,
things that should have been direct_dependent_settings were not marked
as such. GYP 'defines', for example, make no sense on a 'none'-type
target such as webcore_prerequisites. It appears that it was intended
for these settings to be pushed to direct dependents, which would make
direct_dependent_settings correct.


Losing the ChromiumWebCoreObjC defines on the Mac, for example, caused
http://crbug.com/71537, which at best causes Mac console log spew, and
at worst may result in Chromium's copy of WebCore using system
definitions of certain Objective-C classes at runtime, or vice-versa.


The build now includes a postbuild step to prevent
http://crbug.com/71537 from regressing again. The build will fail upon
regression.


https://bugs.webkit.org/show_bug.cgi?id=53630


  • WebCore.gyp/WebCore.gyp: Move things in webcore_prerequisites into direct_dependent_settings as needed, add the check_objc_rename postbuild step.
  • WebCore.gyp/mac/check_objc_rename.sh: Added.


1:09 PM Changeset in webkit [77662] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

BUILD FIX: REALLY remove the last vestiges of JSVALUE32!

<rdar://problem/8957409> Remove last vestiges of JSVALUE32
<http://webkit.org/b/53779>

  • DerivedSources.make: Removed dependency on

JavaScriptCore.JSVALUE32.exp.

1:04 PM Changeset in webkit [77661] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-04 Anders Carlsson <andersca@apple.com>

Reviewed by Mark Rowe.

Mac WebKit2 should use the new drawing area
https://bugs.webkit.org/show_bug.cgi?id=53802
<rdar://problem/7881419>
<rdar://problem/7881447>
<rdar://problem/8252632>
<rdar://problem/8479422>
<rdar://problem/8633813>
<rdar://problem/8734512>
<rdar://problem/8787660>

  • UIProcess/API/mac/WKView.mm: (useNewDrawingArea): Return true. Eventually this function should be removed, but let's keep it for now so we can go back to the old drawing area if necessary.
12:49 PM Changeset in webkit [77660] by robert@webkit.org
  • 8 edits
    2 adds in trunk

2011-02-04 Robert Hogan <robert@webkit.org>

Reviewed by Darin Fisher.

Move chromium iframe shim code to cross-platform file.
https://bugs.webkit.org/show_bug.cgi?id=52594

  • platform/qt/Skipped: Unskip plugins/iframe-shims.html

2011-02-04 Robert Hogan <robert@webkit.org>

Reviewed by Darin Fisher.

Move chromium iframe shim code to cross-platform file
https://bugs.webkit.org/show_bug.cgi?id=52594

Move Chromium code for identifying and cutting out
iframe shims from plugins to cross-platform utility file
IFrameShimSupport.cpp.
Amend PluginViewQt to use this code to handle shims correctly.

  • WebCore.gypi: Add Chromium support for IFrameShimSupport.cpp
  • WebCore.pro: Add Qt support for IFrameShimSupport.cpp
  • plugins/IFrameShimSupport.cpp: Added. (WebCore::getObjectStack): (WebCore::iframeIsAbovePlugin): (WebCore::getPluginOcclusions):
  • plugins/IFframeShimSupport.h: Added.
  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::setNPWindowIfNeeded):

2011-02-04 Robert Hogan <robert@webkit.org>

Reviewed by Darin Fisher.

Move chromium iframe shim code to cross-platform file
https://bugs.webkit.org/show_bug.cgi?id=52594

  • src/WebPluginContainerImpl.cpp: Move code to WebCore/plugin/IFrameShimSupport.cpp
12:47 PM Changeset in webkit [77659] by mjs@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-04 Maciej Stachowiak <mjs@apple.com>

Reviewed by Anders Carlsson.

WebKit2: Crash in WebPageProxy::setPendingAPIRequestURL after web process crashed
https://bugs.webkit.org/show_bug.cgi?id=53799
<rdar://problem/8943956>

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::reload):
12:45 PM Changeset in webkit [77658] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-04 Anders Carlsson <andersca@apple.com>

Reviewed by Maciej Stachowiak.

Fix a shared memory leak
https://bugs.webkit.org/show_bug.cgi?id=53800

Move the send right representing the shared memory.

  • Platform/mac/SharedMemoryMac.cpp: (WebKit::SharedMemory::Handle::encode):
12:38 PM Changeset in webkit [77657] by beidson@apple.com
  • 7 edits
    2 adds in trunk

<rdar://problem/8636239> and https://bugs.webkit.org/show_bug.cgi?id=53785
WebKit2: Pages with dynamically inserted iframes can add extraneous back/forward items.

Reviewed by Anders Carlsson.

Source/WebKit2:

WebCore doesn't gracefully handle the case where the decidePolicyForNavigationAction callback
does not occur synchronously. Let's make it synchronous.

Change WebPageProxy to handle this message reply synchronously:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in: Make the navigation policy action message be synchronous.
  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::callMemberFunction): Add a 6-argument varient

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Send the message synchronously.

LayoutTests:

  • fast/loader/dynamic-iframe-extra-back-forward-item-expected.txt: Added.
  • fast/loader/dynamic-iframe-extra-back-forward-item.html: Added.
12:35 PM Changeset in webkit [77656] by sfalken@apple.com
  • 2 edits in trunk/Source/WebKit2

Windows build fix.
Correct prebuild build-stopping rule to allow project only rebuilds.

  • win/WebKit2WebProcessPreBuild.cmd:
12:33 PM Changeset in webkit [77655] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebKit2

Assertion failure in WebInspectorProxy::platformClose closing main window when inspecting a popup
window, or when running regression tests.
https://bugs.webkit.org/show_bug.cgi?id=53798
<rdar://problem/8814364>

Reviewed by Adam Roben.

Only assert about the state of m_inspectorWindow and m_inspectorView if the inspector is visible.
Also, only call ::DestroyWindow if the HWND is non-null, just to be safe.

  • UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::platformClose):

12:30 PM Changeset in webkit [77654] by xji@chromium.org
  • 6 edits in trunk/Source

2011-02-04 Xiaomei Ji <xji@chromium.org>

Reviewed by David Levin.

Implement "<option> should implement the dir attribute" for chromium port after r76983.
https://bugs.webkit.org/show_bug.cgi?id=50969

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::selectItemAlignmentFollowsMenuWritingDirection): Override as true.
  • src/WebViewImpl.cpp: Remove directionality hint from autofill drop-down setting.

2011-02-04 Xiaomei Ji <xji@chromium.org>

Reviewed by David Levin.

Implement "<option> should implement the dir attribute" for chromium port after r76983.
https://bugs.webkit.org/show_bug.cgi?id=50969

Use manual test Source/WebCore/manual-tests/pop-up-alignment-and-direction.html
added in r76983.

  • platform/chromium/PopupMenuChromium.cpp: Remove directionality hint from <select> drop-down setting. (WebCore::PopupListBox::paintRow): Use <option>'s directionality to paint items in drop-down and pass-in bidi override flag when creating text run.
  • platform/chromium/PopupMenuChromium.h: Remove directionalityHint from PopupContainerSettings.
12:23 PM Changeset in webkit [77653] by Dimitri Glazkov
  • 1 edit
    10 adds in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

Add platform/mac-leopard baselines for tests added in r77639. The text rendering is
different enough for them to be different from mac-snowleopard.

  • platform/mac-leopard/fast/forms/input-placeholder-visibility-1-expected.checksum: Added.
  • platform/mac-leopard/fast/forms/input-placeholder-visibility-1-expected.png: Added.
  • platform/mac-leopard/fast/forms/input-placeholder-visibility-2-expected.checksum: Added.
  • platform/mac-leopard/fast/forms/input-placeholder-visibility-2-expected.png: Added.
  • platform/mac-leopard/fast/forms/input-placeholder-visibility-3-expected.checksum: Added.
  • platform/mac-leopard/fast/forms/input-placeholder-visibility-3-expected.png: Added.
  • platform/mac-leopard/fast/forms/textarea-placeholder-visibility-1-expected.checksum: Added.
  • platform/mac-leopard/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
  • platform/mac-leopard/fast/forms/textarea-placeholder-visibility-2-expected.checksum: Added.
  • platform/mac-leopard/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
12:10 PM Changeset in webkit [77652] by jorlow@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-04 Jeremy Orlow <jorlow@chromium.org>

Build fix from merge mistake.

  • storage/IDBTransaction.cpp: (WebCore::IDBTransaction::ensureEventTargetData):
11:57 AM Changeset in webkit [77651] by leviw@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-04 Levi Weintraub <leviw@chromium.org>

Reviewed by Darin Adler.

Remove unneeded function declarations in comments in EditorClient.h
https://bugs.webkit.org/show_bug.cgi?id=53745

Removing unused commented out function declarations. No tests since this is just cleanup.

  • page/EditorClient.h:
11:50 AM Changeset in webkit [77650] by jorlow@chromium.org
  • 8 edits in trunk/Source/WebCore

2011-02-03 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Refactor IDBRequest and IDBTransaction a bit
https://bugs.webkit.org/show_bug.cgi?id=53565

There were a lot of subtle issues with the way IDBTransaction
and IDBRequest used to be written. This cleans a lot of them up
and largely simplifies the logic. Using EventQueue rather than
timers is one example of the simplification.

  • bindings/scripts/CodeGeneratorV8.pm:
  • dom/EventQueue.cpp: (WebCore::EventQueue::enqueueEvent): (WebCore::EventQueue::dispatchEvent):
  • storage/IDBCursor.cpp: (WebCore::IDBCursor::continueFunction):
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::create): (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::resetReadyState): (WebCore::IDBRequest::onError): (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::dispatchEvent): (WebCore::IDBRequest::enqueueEvent): (WebCore::IDBRequest::eventTargetData): (WebCore::IDBRequest::ensureEventTargetData):
  • storage/IDBRequest.h: (WebCore::IDBRequest::dispatchEvent):
  • storage/IDBTransaction.cpp: (WebCore::IDBTransaction::create): (WebCore::IDBTransaction::IDBTransaction): (WebCore::IDBTransaction::objectStore): (WebCore::IDBTransaction::abort): (WebCore::IDBTransaction::onAbort): (WebCore::IDBTransaction::onComplete): (WebCore::IDBTransaction::onTimeout): (WebCore::IDBTransaction::canSuspend): (WebCore::IDBTransaction::stop): (WebCore::IDBTransaction::enqueueEvent): (WebCore::IDBTransaction::eventTargetData): (WebCore::IDBTransaction::ensureEventTargetData):
  • storage/IDBTransaction.h:
11:38 AM Changeset in webkit [77649] by Dimitri Glazkov
  • 1 edit
    7 adds in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Add baselines for tests, added in r77644.

  • platform/chromium-linux/fast/repaint/slider-thumb-drag-release-expected.checksum: Added.
  • platform/chromium-linux/fast/repaint/slider-thumb-drag-release-expected.png: Added.
  • platform/chromium-mac/fast/repaint/slider-thumb-drag-release-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/slider-thumb-drag-release-expected.png: Added.
  • platform/chromium-win/fast/repaint/slider-thumb-drag-release-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/slider-thumb-drag-release-expected.png: Added.
  • platform/chromium-win/fast/repaint/slider-thumb-drag-release-expected.txt: Added.
11:31 AM Changeset in webkit [77648] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Temporarily add tests added in r77639 as failing, because
we can't see the baselines for these tests (they are in platform/mac-snowleopard).

  • platform/chromium/test_expectations.txt: Added.
11:22 AM Changeset in webkit [77647] by jorlow@chromium.org
  • 27 edits
    2 deletes in trunk

2011-02-01 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Remove the timeout event from IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=53521

  • storage/indexeddb/tutorial.html:

2011-02-01 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Remove the timeout event from IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=53521

Remove timeout and ontimeout from IDBTransaction per the spec.

  • WebCore.gypi:
  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::transaction):
  • storage/IDBDatabase.h: (WebCore::IDBDatabase::transaction):
  • storage/IDBDatabase.idl:
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::setVersion): (WebCore::IDBDatabaseBackendImpl::transaction):
  • storage/IDBDatabaseBackendImpl.h:
  • storage/IDBDatabaseBackendInterface.h:
  • storage/IDBTimeoutEvent.cpp: Removed.
  • storage/IDBTimeoutEvent.h: Removed.
  • storage/IDBTransaction.cpp: (WebCore::IDBTransaction::IDBTransaction): (WebCore::IDBTransaction::onAbort): (WebCore::IDBTransaction::onComplete):
  • storage/IDBTransaction.h:
  • storage/IDBTransaction.idl:
  • storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::create): (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
  • storage/IDBTransactionBackendImpl.h:
  • storage/IDBTransactionCallbacks.h:

2011-02-01 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Remove the timeout event from IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=53521

  • public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::transaction):
  • public/WebIDBTransactionCallbacks.h:
  • src/IDBDatabaseProxy.cpp: (WebCore::IDBDatabaseProxy::transaction):
  • src/IDBDatabaseProxy.h:
  • src/IDBTransactionCallbacksProxy.cpp:
  • src/IDBTransactionCallbacksProxy.h:
  • src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::transaction):
  • src/WebIDBDatabaseImpl.h:
  • src/WebIDBTransactionCallbacksImpl.cpp:
  • src/WebIDBTransactionCallbacksImpl.h:
11:16 AM Changeset in webkit [77646] by Dimitri Glazkov
  • 2 edits
    25 adds in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Add baselines for tests, added in r77639.

  • platform/chromium-linux/fast/forms/input-placeholder-visibility-1-expected.checksum: Added.
  • platform/chromium-linux/fast/forms/input-placeholder-visibility-1-expected.png: Added.
  • platform/chromium-linux/fast/forms/input-placeholder-visibility-2-expected.checksum: Added.
  • platform/chromium-linux/fast/forms/input-placeholder-visibility-2-expected.png: Added.
  • platform/chromium-linux/fast/forms/input-placeholder-visibility-3-expected.checksum: Added.
  • platform/chromium-linux/fast/forms/input-placeholder-visibility-3-expected.png: Added.
  • platform/chromium-linux/fast/forms/textarea-placeholder-visibility-1-expected.checksum: Added.
  • platform/chromium-linux/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
  • platform/chromium-linux/fast/forms/textarea-placeholder-visibility-2-expected.checksum: Added.
  • platform/chromium-linux/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
  • platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.checksum: Added.
  • platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.png: Added.
  • platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt: Added.
  • platform/chromium-win/fast/forms/input-placeholder-visibility-2-expected.checksum: Added.
  • platform/chromium-win/fast/forms/input-placeholder-visibility-2-expected.png: Added.
  • platform/chromium-win/fast/forms/input-placeholder-visibility-2-expected.txt: Added.
  • platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.checksum: Added.
  • platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.png: Added.
  • platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt: Added.
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.checksum: Added.
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.txt: Added.
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.checksum: Added.
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
10:47 AM Changeset in webkit [77645] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

AX: Can't set accessibility overridden attributes on web objects
https://bugs.webkit.org/show_bug.cgi?id=53725

Reviewed by Darin Adler.

accessibilitySetOverriddenValue does not work on AX objects from WebCore because
the right method needed to be overridden (accessibilitySupportsOverriddenAttributes).
Unfortunately, there's no way to test this from DRT, since AppKit returns the overridden
attribute only when an AX client asks for it through the AX frameworks.

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilitySupportsOverriddenAttributes]):

10:42 AM Changeset in webkit [77644] by Dimitri Glazkov
  • 3 edits
    4 adds in trunk

2011-02-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

REGRESSION(r76147): Slider thumb is not repainted when let go outside of the slider track.
https://bugs.webkit.org/show_bug.cgi?id=53691

  • fast/repaint/slider-thumb-drag-release.html: Added.
  • platform/mac/fast/repaint/slider-thumb-drag-release-expected.checksum: Added.
  • platform/mac/fast/repaint/slider-thumb-drag-release-expected.png: Added.
  • platform/mac/fast/repaint/slider-thumb-drag-release-expected.txt: Added.

2011-02-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

REGRESSION(r76147): Slider thumb is not repainted when let go outside of the slider track.
https://bugs.webkit.org/show_bug.cgi?id=53691

Test: fast/repaint/slider-thumb-drag-release.html

  • html/shadow/SliderThumbElement.cpp: (WebCore::SliderThumbElement::stopDragging): Added dirtying the layout bit to ensure

that the thumb is repainted.

10:32 AM Changeset in webkit [77643] by mnaganov@chromium.org
  • 7 edits
    2 adds in trunk/Source/WebCore

2011-02-04 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Add "show more" data grid node and waiting message UI components.
https://bugs.webkit.org/show_bug.cgi?id=53763

  • "show more" data grid node is used for on-demand population of data grid contents (similar to DOM tree capability for limiting displayed nodes count);
  • waiting message is used for informing user about long lasting operations (with a possibility to cancel them).
  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/PleaseWaitMessage.js: Added. (WebInspector.PleaseWaitMessage):
  • inspector/front-end/ShowMoreDataGridNode.js: Added. (WebInspector.ShowMoreDataGridNode):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css: (.data-grid button): (.please-wait-msg):
  • inspector/front-end/inspector.html:
10:32 AM Changeset in webkit [77642] by Dimitri Glazkov
  • 16 edits in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

Update mac baselines. They pixel-rotted.

  • platform/mac-leopard/fast/backgrounds/background-clip-text-expected.png:
  • platform/mac-leopard/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.png:
  • platform/mac-leopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.checksum:
  • platform/mac-leopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/mac-leopard/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/mac-leopard/fast/backgrounds/size/backgroundSize22-expected.checksum:
  • platform/mac-leopard/fast/backgrounds/size/backgroundSize22-expected.png:
  • platform/mac/fast/backgrounds/animated-svg-as-background-expected.checksum:
  • platform/mac/fast/backgrounds/animated-svg-as-background-expected.png:
  • platform/mac/fast/backgrounds/animated-svg-as-mask-expected.checksum:
  • platform/mac/fast/backgrounds/animated-svg-as-mask-expected.png:
  • platform/mac/fast/backgrounds/size/contain-and-cover-expected.checksum:
  • platform/mac/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/mac/fast/backgrounds/svg-as-background-4-expected.checksum:
  • platform/mac/fast/backgrounds/svg-as-background-4-expected.png:
10:27 AM Changeset in webkit [77641] by mnaganov@chromium.org
  • 2 edits in trunk/Tools

2011-02-04 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: fix processing Unicode literals from .js sources in check-inspector-strings.
https://bugs.webkit.org/show_bug.cgi?id=53781

  • Scripts/check-inspector-strings:
10:25 AM Changeset in webkit [77640] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-04 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Go out of accelerated compositing mode when the drawing area is destroyed
https://bugs.webkit.org/show_bug.cgi?id=53788

This fixes a crash in the UI process if a web process crashes while in accelerated compositing mode.

  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::~DrawingAreaProxyImpl):
10:18 AM Changeset in webkit [77639] by adele@apple.com
  • 6 edits
    36 adds
    4 deletes in trunk

Fix for https://bugs.webkit.org/show_bug.cgi?id=53740
<rdar://problem/8503629> Allow platforms to specify if the placeholder should be visible when text controls are focused

Reviewed by Dan Bernstein.

Tests:
fast/forms/textarea-placeholder-visibility-1.html
fast/forms/textarea-placeholder-visibility-2.html
fast/forms/input-placeholder-visibility-1.html
fast/forms/input-placeholder-visibility-2.html
fast/forms/input-placeholder-visibility-3.html

  • html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible):

Add a check for shouldShowPlaceholderWhenFocused.

  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::updateValue):

Whenever the value is updated, we should also update placeholder visibility.

  • rendering/RenderTheme.h: (WebCore::RenderTheme::shouldShowPlaceholderWhenFocused):

Make the default the same as the existing behavior.

  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::shouldShowPlaceholderWhenFocused):

Show placeholder when appropriate.

10:13 AM Changeset in webkit [77638] by ddkilzer@apple.com
  • 4 edits
    1 delete in trunk/Source/JavaScriptCore

<rdar://problem/8957409> Remove last vestiges of JSVALUE32
<http://webkit.org/b/53779>

Reviewed by Darin Adler.

Support for JSVALUE32 was originaly removed in r70111.

  • Configurations/JavaScriptCore.xcconfig: Changed armv6 to use

JavaScriptCore.JSVALUE32_64.exp and ppc64 to use
JavaScriptCore.JSVALUE64.exp to match Platform.h.

  • DerivedSources.make: Removed rule for

JavaScriptCore.JSVALUE32.exp.

to JavaScriptCore.JSVALUE32only.exp.

10:02 AM Changeset in webkit [77637] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Tweak expectations for passing tests.

  • platform/chromium/test_expectations.txt: More tweakage.
10:01 AM Changeset in webkit [77636] by Adam Roben
  • 2 edits in trunk/Tools

Include the crashing function in the link to a crash log on Mac

Fixes <http://webkit.org/b/53780> Crash log links in results.html should include the
function that crashed on Mac

Reviewed by David Kilzer.

  • Scripts/old-run-webkit-tests:

(crashLocation): Moved all the Windows code inside an if instead of using an early return,
but didn't otherwise change it. Added an if for Mac that parses the crashing function out of
the crash log.

9:31 AM Changeset in webkit [77635] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Use static_cast and other style cleanup in YarrInterpreter.cpp
<http://webkit.org/b/53772>

Reviewed by John Sullivan.

  • yarr/YarrInterpreter.cpp:

(JSC::Yarr::Interpreter::InputStream::readChecked): Use
static_cast.
(JSC::Yarr::Interpreter::InputStream::checkInput): Remove
unnecessary else block.
(JSC::Yarr::Interpreter::matchAssertionEOL): Ditto.
(JSC::Yarr::Interpreter::backtrackBackReference): Ditto.
(JSC::Yarr::ByteCompiler::emitDisjunction): Use static_cast.

9:20 AM Changeset in webkit [77634] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Remove more passing tests.

  • platform/chromium/test_expectations.txt: Even more passages removed.
9:07 AM Changeset in webkit [77633] by Adam Roben
  • 2 edits in trunk/Tools

Link to Mac crash logs from results.html

Fixes <http://webkit.org/b/14861> run-webkit-tests should link to Mac crash logs in
results.html

Reviewed by David Kilzer.

  • Scripts/old-run-webkit-tests:

(captureSavedCrashLog): Added a case for Apple's Mac port. We get the crash log out of
~/Library/Logs/CrashReporter, and wait for ReportCrash to exit before trying to get the log.

9:05 AM Changeset in webkit [77632] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Removed passing tests.

  • platform/chromium/test_expectations.txt: Passages removed.
8:38 AM Changeset in webkit [77631] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-04 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: evaluate on hover does not work on a breakpoint.
https://bugs.webkit.org/show_bug.cgi?id=53768

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._mouseHover):
8:28 AM Changeset in webkit [77630] by loislo@chromium.org
  • 23 edits
    2 adds
    4 deletes in trunk/Source

2011-02-04 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77625 and r77626.
http://trac.webkit.org/changeset/77625
http://trac.webkit.org/changeset/77626
https://bugs.webkit.org/show_bug.cgi?id=53765

It broke Windows builds (Requested by Ossy_ on #webkit).

  • Android.jscbindings.mk:
  • CMakeLists.txt:
  • ForwardingHeaders/pcre/pcre.h: Added.
  • ForwardingHeaders/yarr/Yarr.h: Removed.
  • ForwardingHeaders/yarr/YarrInterpreter.h: Removed.
  • ForwardingHeaders/yarr/YarrPattern.h: Removed.
  • WebCore.gyp/WebCore.gyp:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/copyForwardingHeaders.cmd:
  • platform/text/RegularExpression.cpp: (WebCore::RegularExpression::Private::regexp): (WebCore::RegularExpression::Private::compile): (WebCore::RegularExpression::Private::Private): (WebCore::RegularExpression::Private::create): (WebCore::RegularExpression::Private::~Private): (WebCore::RegularExpression::match):

2011-02-04 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77625 and r77626.
http://trac.webkit.org/changeset/77625
http://trac.webkit.org/changeset/77626
https://bugs.webkit.org/show_bug.cgi?id=53765

It broke Windows builds (Requested by Ossy_ on #webkit).

8:24 AM Changeset in webkit [77629] by mnaganov@chromium.org
  • 1 edit in branches/chromium/648/Source/WebCore/inspector/front-end/NetworkPanel.js

Merge 77623 - 2011-02-04 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Network panel filtering is broken.
https://bugs.webkit.org/show_bug.cgi?id=53764

  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._sortItems): (WebInspector.NetworkPanel.prototype._sortByTimeline): (WebInspector.NetworkPanel.prototype._filter): (WebInspector.NetworkPanel.prototype._updateOffscreenRows): (WebInspector.NetworkDataGridNode.prototype.isFilteredOut): (WebInspector.NetworkDataGridNode.prototype.get selectable): (WebInspector.NetworkTotalGridNode.prototype.isFilteredOut): (WebInspector.NetworkTotalGridNode.prototype.get selectable):

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/6286112

7:51 AM Changeset in webkit [77628] by jberlin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix. Unreviewed.

7:21 AM Changeset in webkit [77627] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[Windows 7 Release Tests] transitions/transition-end-event-multiple-04.html flakey
https://bugs.webkit.org/show_bug.cgi?id=53332

Unreviewed, attempt to get the Windows 7 Release bots uniformly green.

  • platform/win/Skipped:
6:54 AM Changeset in webkit [77626] by pvarga@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-04 Peter Varga <pvarga@webkit.org>

Rubber-stamped by Csaba Osztrogonác.

Replace PCRE with Yarr in WebCore
https://bugs.webkit.org/show_bug.cgi?id=53496

Speculative windows build fix.

No new tests needed.

  • platform/text/RegularExpression.cpp:
6:29 AM Changeset in webkit [77625] by pvarga@webkit.org
  • 23 edits
    5 adds
    1 delete in trunk/Source

2011-02-04 Peter Varga <pvarga@webkit.org>

Reviewed by Gavin Barraclough.

Replace PCRE with Yarr in WebCore
https://bugs.webkit.org/show_bug.cgi?id=53496

2011-02-04 Peter Varga <pvarga@webkit.org>

Reviewed by Gavin Barraclough.

Replace PCRE with Yarr in WebCore
https://bugs.webkit.org/show_bug.cgi?id=53496

No new tests needed.

  • Android.jscbindings.mk:
  • CMakeLists.txt:
  • ForwardingHeaders/pcre/pcre.h: Removed.
  • ForwardingHeaders/yarr/Yarr.h: Added.
  • ForwardingHeaders/yarr/YarrInterpreter.h: Added.
  • ForwardingHeaders/yarr/YarrPattern.h: Added.
  • WebCore.gyp/WebCore.gyp:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/copyForwardingHeaders.cmd:
  • platform/text/RegularExpression.cpp: (WebCore::RegularExpression::Private::create): (WebCore::RegularExpression::Private::Private): (WebCore::RegularExpression::Private::compile): (WebCore::RegularExpression::match):
6:27 AM Changeset in webkit [77624] by loislo@chromium.org
  • 1 edit
    8 adds in trunk/LayoutTests

2011-02-04 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed.

Rebaseline. The problem was introduced at r77601.

  • platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png: Added.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Added.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png: Added.
  • platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png: Added.
6:22 AM Changeset in webkit [77623] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-04 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Network panel filtering is broken.
https://bugs.webkit.org/show_bug.cgi?id=53764

  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._sortItems): (WebInspector.NetworkPanel.prototype._sortByTimeline): (WebInspector.NetworkPanel.prototype._filter): (WebInspector.NetworkPanel.prototype._updateOffscreenRows): (WebInspector.NetworkDataGridNode.prototype.isFilteredOut): (WebInspector.NetworkDataGridNode.prototype.get selectable): (WebInspector.NetworkTotalGridNode.prototype.isFilteredOut): (WebInspector.NetworkTotalGridNode.prototype.get selectable):
5:47 AM Changeset in webkit [77622] by loislo@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

2011-02-04 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed.

Rebaseline image for fast/box-shadow/shadow-tiling-artifact.html
The problem was introduced at r77601.

  • platform/chromium-linux/fast/box-shadow/shadow-tiling-artifact-expected.checksum: Added.
  • platform/chromium-linux/fast/box-shadow/shadow-tiling-artifact-expected.png: Added.
  • platform/chromium-win/fast/box-shadow/shadow-tiling-artifact-expected.checksum: Added.
  • platform/chromium-win/fast/box-shadow/shadow-tiling-artifact-expected.png: Added.
5:32 AM Changeset in webkit [77621] by sergio@webkit.org
  • 1 edit
    10 adds in trunk/LayoutTests

2011-02-04 Sergio Villar Senin <svillar@igalia.com>

Unreviewed.

New test expectations.

  • platform/gtk/fast/box-shadow/shadow-tiling-artifact-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLInputElement/input-slider-update-expected.txt: Added.
  • platform/gtk/svg/text/font-size-below-point-five-2-expected.txt: Added.
  • platform/gtk/svg/text/font-size-below-point-five-expected.txt: Added.
  • platform/gtk/svg/text/scaled-font-expected.txt: Added.
  • platform/gtk/svg/text/small-fonts-2-expected.txt: Added.
  • platform/gtk/svg/text/small-fonts-3-expected.txt: Added.
  • platform/gtk/svg/text/small-fonts-expected.txt: Added.
  • platform/gtk/svg/text/small-fonts-in-html5-expected.txt: Added.
5:25 AM Changeset in webkit [77620] by caseq@chromium.org
  • 8 edits in trunk

2011-02-04 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: support overriding user agent strings
https://bugs.webkit.org/show_bug.cgi?id=51485

Test: http/tests/inspector/extensions-useragent.html

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::setUserAgentOverride): (WebCore::InspectorController::userAgentOverride):
  • inspector/InspectorController.h:
  • inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.InspectedWindow.prototype.reload):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onReload):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::userAgent): (WebCore::FrameLoader::applyUserAgent):

2011-02-04 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: support overriding user agent strings
https://bugs.webkit.org/show_bug.cgi?id=51485

  • http/tests/inspector/extensions-useragent-expected.txt: Added.
  • http/tests/inspector/extensions-useragent.html: Added.
5:03 AM Changeset in webkit [77619] by loislo@chromium.org
  • 5 edits in trunk/Source/JavaScriptCore

2011-02-04 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed rollout two patches r77614 and r77612.

REGRESSION: Snow Leopard Intell Release anumber of failing tests.

  • runtime/Heap.cpp: (JSC::Heap::Heap): (JSC::Heap::reset):
  • runtime/Heap.h:
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::allocate): (JSC::MarkedSpace::sweep): (JSC::MarkedSpace::reset):
  • runtime/MarkedSpace.h:
4:40 AM Changeset in webkit [77618] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-04 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: scripts panel displays wrong file name after reload.
https://bugs.webkit.org/show_bug.cgi?id=53761

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished):
3:34 AM Changeset in webkit [77617] by yurys@chromium.org
  • 27 edits in trunk/Source

2011-02-03 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove settings related methods from InspectorClient
https://bugs.webkit.org/show_bug.cgi?id=53686

  • WebCore.exp.in:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/InspectorClient.h:
  • inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal): (WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight): (WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight):
  • inspector/InspectorFrontendClientLocal.h: ports that provide in-process implementation of the inspector front-end can provide platform-specific settings accessor. (WebCore::InspectorFrontendClientLocal::Settings::Settings): (WebCore::InspectorFrontendClientLocal::Settings::~Settings): (WebCore::InspectorFrontendClientLocal::Settings::inspectorAttachedHeight): (WebCore::InspectorFrontendClientLocal::Settings::storeInspectorAttachedHeight):
  • loader/EmptyClients.h:

2011-02-03 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove settings related methods from InspectorClient
https://bugs.webkit.org/show_bug.cgi?id=53686

  • WebCoreSupport/WebInspectorClientCF.cpp: (populateSetting): (storeSetting): (WebInspectorClient::createFrontendSettings):

2011-02-03 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove settings related methods from InspectorClient
https://bugs.webkit.org/show_bug.cgi?id=53686

  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorFrontendClient::InspectorFrontendClient):
  • WebCoreSupport/InspectorClientGtk.h:

2011-02-03 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove settings related methods from InspectorClient
https://bugs.webkit.org/show_bug.cgi?id=53686

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::openInspectorFrontend): (WebInspectorFrontendClient::WebInspectorFrontendClient):

2011-02-03 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove settings related methods from InspectorClient
https://bugs.webkit.org/show_bug.cgi?id=53686

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorFrontendClientQt::InspectorFrontendClientQt):
  • WebCoreSupport/InspectorClientQt.h:

2011-02-03 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove settings related methods from InspectorClient
https://bugs.webkit.org/show_bug.cgi?id=53686

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::openInspectorFrontend): (WebInspectorFrontendClient::WebInspectorFrontendClient):
  • WebCoreSupport/WebInspectorClient.h:

2011-02-03 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove settings related methods from InspectorClient
https://bugs.webkit.org/show_bug.cgi?id=53686

  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp: (WebKit::WebInspectorFrontendClient::WebInspectorFrontendClient):
2:32 AM Changeset in webkit [77616] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-04 Sergio Villar Senin <svillar@igalia.com>

Unreviewed.

Skipping fast/events/pagehide-timeout.html that is failing on GTK
bots. See https://bugs.webkit.org/show_bug.cgi?id=53733

  • platform/gtk/Skipped: skip fast/events/pagehide-timeout.html
12:49 AM Changeset in webkit [77615] by loislo@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-04 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed.

Roll chromium to 73764.

  • DEPS:
12:12 AM Changeset in webkit [77614] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Try to fix 32bit build.

  • runtime/Heap.cpp:

(JSC::Heap::reset): Use an explicit cast to avoid shortening warnings,
since 1.5 is double (64bit), and the result is size_t (32bit).

Feb 3, 2011:

11:50 PM Changeset in webkit [77613] by antonm@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-02-03 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

[v8] frame several more JS code invocations into v8::TryCatch
https://bugs.webkit.org/show_bug.cgi?id=53594

This patch is preemptive and adjusts v8 bindings code to forthcoming small change
in v8::ThrowException---currently sometimes exceptions thrown by this method
do not reach surrounding v8::TryCatch handler (see
http://code.google.com/p/v8/issues/detail?id=1072 and
http://codereview.chromium.org/6397011/). Therefore the goal of this patch
is to make forthcoming v8 roll as smooth as possible (alas, we'll still need
one rebaseline as of now.)

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::runScript): Do not rely on empty handle as a signal of exception, wrap into v8::TryCatch instead
  • bindings/v8/V8WindowErrorHandler.cpp: (WebCore::V8WindowErrorHandler::callListenerFunction): Ditto
11:41 PM Changeset in webkit [77612] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

2011-02-03 Geoffrey Garen <ggaren@apple.com>

Reviewed by Cameron Zwarich.

Changed MarkedSpace to delegate grow/shrink decisions to Heap
https://bugs.webkit.org/show_bug.cgi?id=53759


SunSpider reports no change.


  • runtime/Heap.cpp: (JSC::Heap::Heap): (JSC::Heap::reset):
  • runtime/Heap.h: Reorganized a few data members for better cache locality. Added a grow policy.


  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::allocate): (JSC::MarkedSpace::sweep): (JSC::MarkedSpace::reset): Don't shrink automatically. Instead, wait for the heap to make an explicit sweep call.
  • runtime/MarkedSpace.h: (JSC::MarkedSpace::highWaterMark): (JSC::MarkedSpace::setHighWaterMark): Use a watermark to determine how many bytes to allocate before failing and giving the heap an opportunity to collect garbage. This also means that we allocate blocks on demand, instead of ahead of time.
11:27 PM Changeset in webkit [77611] by mjs@apple.com
  • 11 edits in trunk

2011-02-03 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
https://bugs.webkit.org/show_bug.cgi?id=52897
<rdar://problem/8898294>

  • WebCore.exp.in: Add export now needed by WebKit2

2011-02-03 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
https://bugs.webkit.org/show_bug.cgi?id=52897
<rdar://problem/8898294>

  • Shared/API/c/WKSharedAPICast.h: (WebKit::toAPI):
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp: (WebKit::InjectedBundlePageLoaderClient::willSendRequestForFrame):
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchWillSendRequest):

2011-02-03 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
https://bugs.webkit.org/show_bug.cgi?id=52897
<rdar://problem/8898294>

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage): (WTR::InjectedBundlePage::willSendRequestForFrame):
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
11:00 PM Changeset in webkit [77610] by ike@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-02-03 Ivan Krstić <ike@apple.com>

Reviewed by Maciej Stachowiak.

Make WebProcess pass explicit homedir parameter to the sandbox
<rdar://problem/8405760>
<https://webkit.org/b/53558>

  • WebProcess/com.apple.WebProcess.sb:
  • WebProcess/mac/WebProcessMac.mm: (WebKit::initializeSandbox):
10:54 PM Changeset in webkit [77609] by ike@apple.com
  • 2 edits in trunk/Tools

2011-02-03 Ivan Krstić <ike@apple.com>

Unreviewed.

Adding myself to committers.py.

  • Scripts/webkitpy/common/config/committers.py:
10:46 PM Changeset in webkit [77608] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-03 Victoria Kirst <vrk@google.com>

Reviewed by James Robinson.

Replaces float literals with uniform values in shader code
so that buggy drivers unable to parse float values in different
locales will not produce a pink video.

[chromium] Fix pink video bug with gpu-acceleration enabled
https://bugs.webkit.org/show_bug.cgi?id=53568

  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::SharedValues::SharedValues): (WebCore::VideoLayerChromium::drawYUV):
  • platform/graphics/chromium/VideoLayerChromium.h: (WebCore::VideoLayerChromium::SharedValues::signAdjLocation):
10:31 PM Changeset in webkit [77607] by levin@chromium.org
  • 26 edits
    2 adds in trunk

Add navigator.registerProtocolHandler behind a flag.
https://bugs.webkit.org/show_bug.cgi?id=52609

Patch by James Kozianski <koz@chromium.org> on 2011-02-03
Reviewed by Dimitri Glazkov.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

This method is described in the HTML5 specification here,
http://dev.w3.org/html5/spec/Overview.html#dom-navigator-registerprotocolhandler

This change is largely cribbed from B. Green's 29651 patches. It is
behind a flag so as not to break JS feature detection.

New layout test fast/dom/registerProtocolHandler.html.

  • Configurations/FeatureDefines.xcconfig:
  • loader/EmptyClients.h:

(WebCore::EmptyChromeClient::registerProtocolHandler):

  • page/Chrome.cpp:

(WebCore::Chrome::registerProtocolHandler):

  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/Navigator.cpp:

(WebCore::verifyCustomHandlerURL):
(WebCore::verifyProtocolHandlerScheme):
(WebCore::Navigator::registerProtocolHandler):

  • page/Navigator.h:
  • page/Navigator.idl:

Source/WebKit/chromium:

  • features.gypi:
  • public/WebViewClient.h:
  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::registerProtocolHandler):

  • src/ChromeClientImpl.h:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/build-webkit:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

  • fast/dom/register-protocol-handler-expected.txt: Added.
  • fast/dom/register-protocol-handler.html: Added.
10:26 PM Changeset in webkit [77606] by hayato@chromium.org
  • 7 edits in trunk/Tools

2011-02-03 Hayato Ito <hayato@chromium.org>

Reviewed by Eric Seidel.

[NRWT] Remove TestArgs class, which is wrongly used.

https://bugs.webkit.org/show_bug.cgi?id=53063

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
9:45 PM Changeset in webkit [77605] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-02-03 Andrew Wason <rectalogic@rectalogic.com>

Reviewed by Kenneth Russell.

Change ENABLE_3D_CANVAS to ENABLE_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=53714

  • Scripts/build-webkit: change --3d-canvas build option to set ENABLE_WEBGL
9:38 PM Changeset in webkit [77604] by commit-queue@webkit.org
  • 6 edits in trunk/Source

2011-02-03 Brian Ryner <bryner@chromium.org>

Reviewed by Darin Fisher.

Add a field to the ResourceResponse for tracking the socket address
of the host that the resource was fetched from. Patch was originally
by Paul Marks.
https://bugs.webkit.org/show_bug.cgi?id=53699

  • platform/network/chromium/ResourceResponse.cpp: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
  • platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::socketAddress): (WebCore::ResourceResponse::setSocketAddress):

2011-02-03 Brian Ryner <bryner@chromium.org>

Reviewed by Darin Fisher.

Add a field to the ResourceResponse for tracking the socket address
of the host that the resource was fetched from. Patch was originally
by Paul Marks.
https://bugs.webkit.org/show_bug.cgi?id=53699

  • public/WebURLResponse.h:
  • src/WebURLResponse.cpp: (WebKit::WebURLResponse::socketAddress): (WebKit::WebURLResponse::setSocketAddress):
9:36 PM Changeset in webkit [77603] by hayato@chromium.org
  • 11 edits
    1 add
    1 delete in trunk/Tools

2011-02-03 Hayato Ito <hayato@chromium.org>

Reviewed by Tony Chang.

[NRWT] Introduces Input/Output class used by base.Driver into port/base.py and
move _run_single_test() and _process_output() functions from
dump_render_tree_thread.py to a single_test_runner.py as an individual module.

This is clean up and acts as a preparation for elimination of test_types/*
classes. These classes will move to the single_test_runner module introduced
in this patch.

https://bugs.webkit.org/show_bug.cgi?id=53004

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Added.
  • Scripts/webkitpy/layout_tests/layout_package/test_input.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_output.py: Removed.
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/dryrun.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
9:30 PM Changeset in webkit [77602] by agl@chromium.org
  • 34 edits in trunk

2011-02-03 Adam Langley <agl@chromium.org>

Reviewed by Adam Barth.

Plumb mixed script URL to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=52384

Regressions covered by http/tests/security/mixedContent/*

  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::didRunInsecureContent):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkIfRunInsecureContent):
  • loader/FrameLoaderClient.h:

2011-02-03 Adam Langley <agl@chromium.org>

Reviewed by Adam Barth.

Plumb mixed script URL to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=52384

Regressions covered by http/tests/security/mixedContent/*

  • public/WebFrameClient.h: (WebKit::WebFrameClient::didRunInsecureContent):
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::didRunInsecureContent):
  • src/FrameLoaderClientImpl.h:

2011-02-03 Adam Langley <agl@chromium.org>

Reviewed by Adam Barth.

Plumb mixed script URL to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=52384

Regressions covered by http/tests/security/mixedContent/*

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::didRunInsecureContent):
  • WebCoreSupport/FrameLoaderClientEfl.h:

2011-02-03 Adam Langley <agl@chromium.org>

Reviewed by Adam Barth.

Plumb mixed script URL to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=52384

Regressions covered by http/tests/security/mixedContent/*

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::didRunInsecureContent):
  • WebCoreSupport/FrameLoaderClientGtk.h:

2011-02-03 Adam Langley <agl@chromium.org>

Reviewed by Adam Barth.

Plumb mixed script URL to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=52384

Regressions covered by http/tests/security/mixedContent/*

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::didRunInsecureContent):

2011-02-03 Adam Langley <agl@chromium.org>

Reviewed by Adam Barth.

Plumb mixed script URL to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=52384

Regressions covered by http/tests/security/mixedContent/*

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::didRunInsecureContent):
  • WebCoreSupport/FrameLoaderClientQt.h:

2011-02-03 Adam Langley <agl@chromium.org>

Reviewed by Adam Barth.

Plumb mixed script URL to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=52384

Regressions covered by http/tests/security/mixedContent/*

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::didRunInsecureContent):
  • WebCoreSupport/WebFrameLoaderClient.h:

2011-02-03 Adam Langley <agl@chromium.org>

Reviewed by Adam Barth.

Plumb mixed script URL to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=52384

Regressions covered by http/tests/security/mixedContent/*

  • WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::didRunInsecureContent):
  • WebCoreSupport/FrameLoaderClientWinCE.h:

2011-02-03 Adam Langley <agl@chromium.org>

Reviewed by Adam Barth.

Plumb mixed script URL to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=52384

Regressions covered by http/tests/security/mixedContent/*

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::didRunInsecureContent):
  • WebKitSupport/FrameLoaderClientWx.h:

2011-02-03 Adam Langley <agl@chromium.org>

Reviewed by Adam Barth.

Plumb mixed script URL to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=52384

Regressions covered by http/tests/security/mixedContent/*

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::didRunInsecureContent):
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
9:28 PM Changeset in webkit [77601] by Simon Fraser
  • 3 edits
    4 adds in trunk

2011-02-03 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

REGRESSION: Artifacts on box-shadow corners in some cases
https://bugs.webkit.org/show_bug.cgi?id=53731

Fix overdrawing artifacts in ShadowBlur's tiling code path,
which show up in shadows using a color with alpha.

Test: fast/box-shadow/shadow-tiling-artifact.html

  • platform/graphics/ShadowBlur.cpp: (WebCore::ShadowBlur::drawRectShadowWithTiling): Ensure that the inner rect that gets filled does not overlap with any of the eight tiled areas by having the corner and side dimensions be the same for contiguous areas.
9:26 PM Changeset in webkit [77600] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-03 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

XSS Auditor is spinning inside decodeURLEscapeSequences() if there are
percent signs in large posted data
https://bugs.webkit.org/show_bug.cgi?id=53405

If the input string contains many non-% characters followed by a %
character that is not a valid URL escape sequence, then the old
algorithm would only advance the initial search by one character
(instead of jumping to just after the % character). That would cause
the algorithm to take N2 time (in the number of characters before the
first % character). This patch just advances the search past the first
% character so we can start looking for next % character sooner.

  • platform/KURL.cpp: (WebCore::decodeURLEscapeSequences):
9:20 PM Changeset in webkit [77599] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-02-03 Victoria Kirst <vrk@google.com>

Reviewed by James Robinson.

[chromium] Fix redundant video frame paint on CSS LayerChromium for <video>
https://bugs.webkit.org/show_bug.cgi?id=52868

  • src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::paint): (WebKit::WebMediaPlayerClientImpl::paintCurrentFrameInContext): (WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
  • src/WebMediaPlayerClientImpl.h:
9:08 PM Changeset in webkit [77598] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-03 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: click on a breakpoint highlights wrong line in source frame.
https://bugs.webkit.org/show_bug.cgi?id=53692

  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._setupBreakpointElement):
9:04 PM Changeset in webkit [77597] by antonm@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-02-03 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

[v8] Bail out if to string conversion returned empty handle
https://bugs.webkit.org/show_bug.cgi?id=53687

This a temporary measure: actually one probably should never get empty handle
if there was no exception. The root cause is under investigation.
The bailout though allows Chromium not to crash---attempt to convert an empty
v8 hande into WebCore string crashes with invalid memory access.

See http://code.google.com/p/chromium/issues/detail?id=71544

There is no known reduction expressible as a layout test so far. The crash found with automated testing tools.

  • bindings/v8/V8Binding.cpp: (WebCore::v8NonStringValueToWebCoreString): Bail out on empty handle
  • bindings/v8/V8Binding.h: (WebCore::V8ParameterBase::prepareBase): Ditto
9:03 PM Changeset in webkit [77596] by joone.hur@collabora.co.uk
  • 3 edits in trunk/Source/WebKit/gtk

2011-02-03 Joone Hur <joone.hur@collabora.co.uk>

Reviewed by Martin Robinson.

[Gtk] No need to set text encoding in the provisional phase
https://bugs.webkit.org/show_bug.cgi?id=53487

According to changeset 67253, setEncoding could be called multiple times from
committedLoad, finishedLoading, dispatchDidFailLoading, and setMainDocumentError
in FrameLoaderClient. To fix this, the relevant code was removed from
FrameLoaderClient and moved to DocumentLoader::commitData. However, that
code was not removed from FrameLoaderClient::finishedLoading in WebKitGtk+.

Due to this reason, after loading a html document, other ports initialize the
text encoding from FrameLoaderClient::finishedLoading, but WebKitGtk+ sets
the same encoding again, even tries to set encoding in the provisional phase.
This causes unnecessary encoding setting.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::FrameLoaderClient): Set m_hasRepresentation to false. (WebKit::FrameLoaderClient::makeRepresentation): Set m_hasRepresentation to true. (WebKit::FrameLoaderClient::revertToProvisionalState): Set m_hasRepresentation to true. (WebKit::FrameLoaderClient::finishedLoading): Skip the encoding setting when m_hasRepresentation is false.
  • WebCoreSupport/FrameLoaderClientGtk.h: Added m_hasRepresentation.
8:53 PM Changeset in webkit [77595] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-02-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

Delete a line that was accidentally missed in r77586; without it
there is still a race between the two threads.

https://bugs.webkit.org/show_bug.cgi?id=51572

  • Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
8:32 PM Changeset in webkit [77594] by levin@chromium.org
  • 3 edits in trunk/LayoutTests

worker-importScriptsOnError needs to allow for the console error to
flush out before calling notifyDone.

Reviewed by Adam Barth.

  • http/tests/workers/worker-importScriptsOnError-expected.txt:
  • http/tests/workers/worker-importScriptsOnError.html:
8:24 PM Changeset in webkit [77593] by abarth@webkit.org
  • 1 edit
    3 adds in trunk/PerformanceTests

2011-02-03 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

Add another XSSFilter PerformanceTest
https://bugs.webkit.org/show_bug.cgi?id=53750

This PerformanceTest tests the case that was slow in
https://bugs.webkit.org/show_bug.cgi?id=49845

  • XSSFilter/large-post-many-inline-scripts-and-events.html: Added.
  • XSSFilter/resources: Added.
  • XSSFilter/resources/target-for-large-post-many-inline-scripts-and-events.html: Added.
8:07 PM Changeset in webkit [77592] by dpranke@chromium.org
  • 2 edits
    1 add in trunk/Tools

2011-02-03 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

nrwt: handle "broken pipe" notifications from DRT more cleanly.

https://bugs.webkit.org/show_bug.cgi?id=52927

  • Scripts/webkitpy/layout_tests/port/server_process.py:
  • Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
8:05 PM Changeset in webkit [77591] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-03 Adam Barth <abarth@webkit.org>

Attempt to fix Chromium build.

  • html/parser/XSSFilter.cpp:
8:02 PM Changeset in webkit [77590] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/PerformanceTests

2011-02-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add PerformanceTest for XSSFilter
https://bugs.webkit.org/show_bug.cgi?id=53741

This performance tests covers the case of a large POST data and many
small event handlers.

  • XSSFilter: Added.
  • XSSFilter/large-post-many-events.html: Added.
7:59 PM Changeset in webkit [77589] by dpranke@chromium.org
  • 2 edits
    1 delete in trunk/Source/WebCore

2011-02-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, rolling out r77562.
http://trac.webkit.org/changeset/77562
https://bugs.webkit.org/show_bug.cgi?id=53630

broke chromium mac build

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/mac/check_objc_rename.sh: Removed.
7:56 PM Changeset in webkit [77588] by abarth@webkit.org
  • 22 edits in trunk

2011-02-03 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

XSS Auditor severely affects loading performance after submitting a large form
https://bugs.webkit.org/show_bug.cgi?id=49845

The XSSFilter catches some more cases and has different console
messages than the XSSAuditor. We might want to improve these messages
in the future.

  • http/tests/security/xssAuditor/base-href-control-char-expected.txt:
  • http/tests/security/xssAuditor/base-href-expected.txt:
  • http/tests/security/xssAuditor/base-href-null-char-expected.txt:
  • http/tests/security/xssAuditor/base-href-scheme-relative-expected.txt:
  • http/tests/security/xssAuditor/dom-write-innerHTML-expected.txt:
  • http/tests/security/xssAuditor/embed-tag-control-char-expected.txt:
  • http/tests/security/xssAuditor/embed-tag-expected.txt:
  • http/tests/security/xssAuditor/embed-tag-javascript-url-expected.txt:
  • http/tests/security/xssAuditor/embed-tag-null-char-expected.txt:
  • http/tests/security/xssAuditor/full-block-base-href-expected.txt:
  • http/tests/security/xssAuditor/full-block-object-tag-expected.txt:
  • http/tests/security/xssAuditor/link-onclick-entities-expected.txt:
  • http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt:
  • http/tests/security/xssAuditor/object-embed-tag-expected.txt:
  • http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
  • http/tests/security/xssAuditor/object-tag-expected.txt:
  • http/tests/security/xssAuditor/object-tag-javascript-url-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-entities-expected.txt:

2011-02-03 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

XSS Auditor severely affects loading performance after submitting a large form
https://bugs.webkit.org/show_bug.cgi?id=49845

Switch over from the XSSAuditor to the XSSFilter, improving performance
on this example.

  • html/parser/XSSFilter.cpp: (WebCore::XSSFilter::filterToken):
  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::isEnabled):
7:30 PM Changeset in webkit [77587] by dpranke@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, rolling out r77567.
http://trac.webkit.org/changeset/77567
https://bugs.webkit.org/show_bug.cgi?id=53468

broke chromium linux svg, canvas tests, possibly win also?

  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
7:12 PM Changeset in webkit [77586] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-02-03 Dirk Pranke <dpranke@chromium.org>

Reviewed by Kenneth Russell.

Update, resubmit change to bug 51572. I think the race that was
fixed in r76703 caused the hang that caused us to roll this
patch out before, so I'd like to try again.

https://bugs.webkit.org/show_bug.cgi?id=51572

  • Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
  • Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
6:59 PM Changeset in webkit [77585] by jhoneycutt@apple.com
  • 8 edits
    1 copy
    1 add in trunk/Source/WebKit2

Download bundles should be moved to their final destination when they
finish.

https://bugs.webkit.org/show_bug.cgi?id=53668

Reviewed by Adam Roben.

  • WebProcess/Downloads/Download.cpp:

(WebKit::Download::Download):
Initialize m_allowOverwrite.
(WebKit::Download::retrieveDestinationWithSuggestedFilename):
Return the result of requesting the destination filename from the UI
process.
(WebKit::Download::decideDestinationWithSuggestedFilename):
Call retrieveDestinationWithSuggestedFilename().
(WebKit::Download::didFinish):
Call platformDidFinish().

  • WebProcess/Downloads/Download.h:

Declare retrieveDestinationWithSuggestedFilename() and
platformDidFinish(). Add a member variable to store whether the UI
process would like us to overwrite existing files.

  • WebProcess/Downloads/cf/DownloadCFNet.cpp:

(WebKit::willResumeWithResponseCallback):
Remove some trailing whitespace.

  • WebProcess/Downloads/curl/DownloadCurl.cpp:

(WebKit::Download::platformDidFinish):
Stubbed.

  • WebProcess/Downloads/mac/DownloadMac.mm:

(WebKit::Download::platformDidFinish):
Stubbed.

  • WebProcess/Downloads/qt/DownloadQt.cpp:

(WebKit::Download::platformDidFinish):
Stubbed.

  • WebProcess/Downloads/cf/win/DownloadCFNetWin.cpp:

(WebKit::Download::didDecideDestination):
Store whether the UI process would like us to overwrite existing files.
(WebKit::Download::platformDidFinish):
Try to move the bundle to the final destination. If that fails, ask the
UI process for a new destination. If we receive one, try again to move
the bundle. Call didCreateDestination() to report the updated path of
file whether it's the bundle that we failed to move, or the new final
destination.

This is similar to what is done by WebKit 1's CFNetwork port.

  • win/WebKit2.vcproj:

Add DownloadWin.cpp.

6:57 PM Changeset in webkit [77584] by jhoneycutt@apple.com
  • 2 edits in trunk/Source/WebKit2

Small clean-up in DownloadCFNet.cpp.

Rubber-stamped by Mark Rowe.

  • WebProcess/Downloads/cf/DownloadCFNet.cpp:

(WebKit::Download::didDecideDestination):
Moved out of the section labeled "CFURLDownload callbacks" and up near
the other member functions.

6:56 PM Changeset in webkit [77583] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-02-03 Maciej Stachowiak <mjs@apple.com>

Reviewed by Daniel Bates.

Skip a test for WebKit2 that uses missing DRT API
https://bugs.webkit.org/show_bug.cgi?id=53748

  • platform/mac-wk2/Skipped:
5:58 PM Changeset in webkit [77582] by mrowe@apple.com
  • 5 edits in branches/safari-533.20-branch

Versioning.

5:58 PM Changeset in webkit [77581] by mrowe@apple.com
  • 1 copy in tags/Safari-533.20.23

New tag.

5:58 PM Changeset in webkit [77580] by mrowe@apple.com
  • 2 edits in branches/safari-533.20-branch/WebCore

Build fix.

  • plugins/PluginView.cpp:

(WebCore::PluginView::start):
(WebCore::PluginView::getURLNotify):
(WebCore::PluginView::getURL):
(WebCore::PluginView::handlePost):

5:56 PM Changeset in webkit [77579] by inferno@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-02-03 Abhishek Arya <inferno@chromium.org>

Unreviewed, simple qt test baseline.

  • platform/qt/fast/overflow/overflow-height-float-not-removed-crash-expected.txt: Added.
5:45 PM Changeset in webkit [77578] by morrita@google.com
  • 13 edits
    1 add in trunk

2011-02-02 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

Refactoring: <progress> should not use ShadowElement
https://bugs.webkit.org/show_bug.cgi?id=53583

Updated to catch the change on -webkit-progress-bar-value interpretation.

  • fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html:

2011-02-02 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

Refactoring: <progress> should not use ShadowElement
https://bugs.webkit.org/show_bug.cgi?id=53583

  • Introduced RenderIndicatorPart and RenderProgressBarValuePart to be responsible for bar-part layout, which adopted layout logic from ShadowBlockElement.
  • ProgressBarValueElement is no longer a subclass of ShadowBlockElement.
  • Remove dependency from RenderProgress to HTMLProgressElement and ShadowBlockElement.
  • The shadow tree is no longer removed on detach(). It becomes persistent. This is now possible because the ShadowBlockElement dependency is gone.
  • ::-webkit-appearance for -webkit-progress-bar-value is no longer referred. That didn't make sense.
  • html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::createShadowSubtreeIfNeeded):
  • html/HTMLProgressElement.h:
  • html/shadow/ProgressBarValueElement.h: Added. (WebCore::ProgressBarValueElement::ProgressBarValueElement): (WebCore::ProgressBarValueElement::shadowPseudoId): (WebCore::ProgressBarValueElement::createRenderer): (WebCore::ProgressBarValueElement::create):
  • rendering/RenderIndicator.cpp: (WebCore::RenderIndicatorPart::RenderIndicatorPart): (WebCore::RenderIndicatorPart::~RenderIndicatorPart): (WebCore::RenderIndicatorPart::layout): (WebCore::RenderIndicatorPart::styleDidChange):
  • rendering/RenderIndicator.h: Added RenderIndicatorPart class (WebCore::RenderIndicatorPart::originalVisibility): (WebCore::RenderIndicatorPart::requiresForcedStyleRecalcPropagation): (WebCore::RenderIndicatorPart::canHaveChildren):
  • rendering/RenderProgress.cpp: (WebCore::RenderProgressBarValuePart::preferredFrameRect): (WebCore::RenderProgressBarValuePart::shouldBeHidden): (WebCore::RenderProgress::updateFromElement): (WebCore::RenderProgress::layoutParts): (WebCore::RenderProgress::shouldHaveParts):
  • rendering/RenderProgress.h: (WebCore::RenderProgressBarValuePart::RenderProgressBarValuePart):
5:40 PM Changeset in webkit [77577] by mitz@apple.com
  • 33 edits
    1 add in trunk

Reversion should not be marked as misspelled.
https://bugs.webkit.org/show_bug.cgi?id=53255

Source/WebCore:

Patch by Jia Pu <jpu@apple.com> on 2011-02-03
This patch includes fix for reported bug, and also some housekeeping changes.

To implement desired behavior, we need:

  1. Add a new marker type, SpellCheckingExemption, since now we distingusish between text that shouldn't be spellchecked and text shouldn't be autocorrected.
  2. Make sure that there is no pending correction panel when we enter markAllMisspellingsAndBadGrammarInRanges(). Otherwise the spell checking code in that function may interfere with autocorrection. This is achieved by explicitly applying pending correction when user types space, line break or paragraph break.

Housekeeping code changes include:

  1. Change manual-tests that were broken by relocated WebCore directory.
  2. Use TextIterator in various DocumentMarkerController functions instead of using Node::traverseNextNode() directly.
  3. Allow passing multiple marker types into DocumentMarkerController::removeMarkers() and DocumentMarkerController::hasMarkers() to improve clarity and efficiency.
  4. Fixes of minor bugs that were exposed previously.
  • WebCore.exp.in: Change signature of DocumentMarkerController::removeMarkers().
  • dom/DocumentMarker.h: Added new marker type SpellCheckingExemption.
  • dom/DocumentMarkerController.cpp:

(WebCore::DocumentMarkerController::removeMarkers): Use TextIterator to scan the range to be

consistent with addMarker() function. Allow passing in multiple marker types in one call.
Added a boolean argument to specify the behavior when removing markers that partially
overlap the specified range.

(WebCore::DocumentMarkerController::removeMarkersFromMarkerMapVectorPair): Allow passing in

multiple marker types in one call.

(WebCore::DocumentMarkerController::hasMarkers): Use TextIterator to scan the range to be

consistent with addMarker() function. Allow passing in multiple marker types in one call.

  • dom/DocumentMarkerController.h: Allow passing in multiple marker types to removeMarkers()

and hasMarkers(). Added a boolean argument to removeMarkers() to specify the behavior when
removing markers that partially overlap the specified range.

  • editing/Editor.cpp:

(WebCore::markerTypesForAutocorrection): Add SpellCheckingExemption marker when apply correction.
(WebCore::markerTypesForReplacement): Ditto.
(WebCore::Editor::respondToChangedSelection): Reordered call to dismissCorrectionPanel() and

setSelection() to make sure there is no pending correction when entering
markAllMisspellingsAndBadGrammarInRanges().

(WebCore::Editor::appliedEditing): Only remove CorrectionIndicator markers when the command

is a top level command to improve efficiency.

(WebCore::Editor::insertTextWithoutSendingTextEvent): Added code to applying pending correction.
(WebCore::Editor::insertLineBreak): Ditto.
(WebCore::Editor::insertParagraphSeparator): Ditto.
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Don't mark mispelling if the

text carries SpellCheckingExemption marker.

(WebCore::Editor::correctionPanelTimerFired): Reset correction panel if the returned suggestion

from spellchecker is an empty string.

(WebCore::Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited):

Use new DocumentMarkerController::removeMarkers() to replace custom implemenation to improve
efficiency and readability.

(WebCore::Editor::applyCorrectionPanelInfo): Remove the code that set caret position after

applying correction, since it's unnecessary. Also, store pre-correction string together with
the marker for reversion panel to use.

(WebCore::Editor::applyAutocorrectionBeforeTypingIfAppropriate): Apply pending correction.
(WebCore::Editor::changeSelectionAfterCommand): Moved marker removal code to Editor::appliedEditing()

where we have access to EditCommand object.

  • editing/Editor.h: Added new function applyAutocorrectionAfterTypingIfAppropriate().
  • manual-tests/autocorrection/autocorrection-cancelled-by-ESC.html: Change manual-tests that

were broken by relocated WebCore directory.

  • manual-tests/autocorrection/autocorrection-cancelled-by-typing-1.html: Ditto.
  • manual-tests/autocorrection/autocorrection-contraction.html: Ditto.
  • manual-tests/autocorrection/continue-typing-to-dismiss-reversion.html: Ditto.
  • manual-tests/autocorrection/delete-to-dismiss-reversion.html: Ditto.
  • manual-tests/autocorrection/delete-to-end-of-word-to-show-reversion.html: Ditto.
  • manual-tests/autocorrection/dismiss-multiple-guesses.html: Ditto.
  • manual-tests/autocorrection/move-to-end-of-word-to-show-reversion.html: Ditto.
  • manual-tests/autocorrection/select-from-multiple-guesses.html: Ditto.
  • manual-tests/autocorrection/spell-checking-after-reversion.html: Added.
  • manual-tests/autocorrection/type-whitespace-to-dismiss-reversion.html: Change manual-tests that

were broken by relocated WebCore directory.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDocumentMarkers): Code clean-up to be more concise.

LayoutTests:

Patch by Jia Pu <jpu@apple.com> on 2011-02-03
Rebaselined tests broken by https://bugs.webkit.org/show_bug.cgi?id=51389

  • platform/mac/editing/spelling/autocorrection-contraction-expected.png:
  • platform/mac/editing/spelling/autocorrection-contraction-expected.txt:
  • platform/mac/editing/spelling/autocorrection-delete-expected.png:
  • platform/mac/editing/spelling/autocorrection-delete-expected.txt:
  • platform/mac/editing/spelling/autocorrection-removing-underline-after-paste-expected.png:
  • platform/mac/editing/spelling/autocorrection-removing-underline-after-paste-expected.txt:
  • platform/mac/editing/spelling/autocorrection-removing-underline-expected.png:
  • platform/mac/editing/spelling/autocorrection-removing-underline-expected.txt:
  • platform/mac/editing/spelling/autocorrection-simple-expected.checksum:
  • platform/mac/editing/spelling/autocorrection-simple-expected.png:
  • platform/mac/editing/spelling/autocorrection-simple-expected.txt:
  • platform/mac/editing/spelling/autocorrection-simple.html:
  • platform/mac/editing/spelling/delete-autocorrected-word-1-expected.png:
  • platform/mac/editing/spelling/delete-autocorrected-word-1-expected.txt:
5:35 PM Changeset in webkit [77576] by mihaip@chromium.org
  • 7 edits
    2 copies in branches/chromium/648

Merge 77355 - 2011-02-01 Mihai Parparita <mihaip@chromium.org>

Reviewed by James Robinson.

Async event handlers should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53202

Add tests for a scroll event triggered right before a modal dialog is
shown.

  • fast/events/scroll-event-during-modal-dialog-expected.txt: Added.
  • fast/events/scroll-event-during-modal-dialog.html: Added.

2011-02-01 Mihai Parparita <mihaip@chromium.org>

Reviewed by James Robinson.

Async event handlers should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53202

Asychronous events that use EventQueue would currently fire while a
modal dialog (e.g. window.alert()) was up. Change EventQueue to use a
SuspendableTimer (which automatically gets suspended while dialogs are
up and in other cases where JS execution is not allowed).

Test: fast/events/scroll-event-during-modal-dialog.html

  • dom/Document.cpp: (WebCore::Document::Document):
  • dom/EventQueue.cpp: (WebCore::EventQueueTimer::EventQueueTimer): (WebCore::EventQueueTimer::fired): (WebCore::EventQueue::EventQueue): (WebCore::EventQueue::enqueueEvent): (WebCore::EventQueue::pendingEventTimerFired):
  • dom/EventQueue.h: (WebCore::EventQueue::create):
  • page/SuspendableTimer.cpp: (WebCore::SuspendableTimer::SuspendableTimer): (WebCore::SuspendableTimer::suspend): (WebCore::SuspendableTimer::resume):
  • page/SuspendableTimer.h:

BUG=71888
TBR=jamesr@chromium.org
Review URL: http://codereview.chromium.org/6349095

5:29 PM Changeset in webkit [77575] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-02-03 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Paint non-composited contents in a layer
https://bugs.webkit.org/show_bug.cgi?id=53742

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setNeedsDisplay): Call LayerTreeHost::setNonCompositedContentsNeedDisplayInRect.

(WebKit::DrawingAreaImpl::scroll):
Call LayerTreeHost::scrollNonCompositedContents.

(WebKit::DrawingAreaImpl::setSize):
Call LayerTreeHost::sizeDidChange.

  • WebProcess/WebPage/LayerTreeHost.h: Add new pure virtual member functions.
  • WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::LayerTreeHostMac): Create the non-composited content layer.

(WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplayInRect):
Call setNeedsDisplay on the GraphicsLayer.

(WebKit::LayerTreeHostMac::scrollNonCompositedContents):
Just call setNonCompositedContentsNeedDisplayInRect.

(WebKit::LayerTreeHostMac::sizeDidChange):
Resize the layers and flush any changes.


(WebKit::LayerTreeHostMac::paintContents):
Call WebPage::drawRect.

(WebKit::LayerTreeHostMac::flushPendingLayerChangesRunLoopObserverCallback):
Lay out the web page.

(WebKit::LayerTreeHostMac::flushPendingLayerChanges):
Call syncCompositingStateForThisLayerOnly on the non-composited content layer.

5:26 PM Changeset in webkit [77574] by dcheng@chromium.org
  • 2 edits in trunk/Tools

Unreviewed.

Adding myself to committers.py.

  • Scripts/webkitpy/common/config/committers.py:
5:25 PM Changeset in webkit [77573] by inferno@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-03 Abhishek Arya <inferno@chromium.org>

Unreviewed, qt build fix.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::removeFloatingObject):
5:19 PM Changeset in webkit [77572] by jorlow@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-02-03 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Don't clear the callbacks ref in the proxy layer for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=53535

Clearing the callbacks doesn't actually solve any problems and makes
this code behave subtly differently than how it would in Safari and
other single process environments. Let's remove the difference.

  • src/IDBCallbacksProxy.cpp: (WebCore::IDBCallbacksProxy::onError): (WebCore::IDBCallbacksProxy::onSuccess):
  • src/IDBTransactionCallbacksProxy.cpp: (WebCore::IDBTransactionCallbacksProxy::onAbort): (WebCore::IDBTransactionCallbacksProxy::onComplete): (WebCore::IDBTransactionCallbacksProxy::onTimeout):
5:17 PM Changeset in webkit [77571] by Adam Roben
  • 2 edits in trunk/Tools

Include the crashing function in the link to a crash log

Fixes <http://webkit.org/b/53739> Crash log links in results.html should include the
function that crashed

Reviewed by David Kilzer.

  • Scripts/old-run-webkit-tests:

(crashLocation): Added. Returns the location of the crash.
(linksForErrorTest): Include the crash location in the link text for the crash log, if one
could be determined.

5:05 PM Changeset in webkit [77570] by mrowe@apple.com
  • 5 edits in trunk/Source

Versioning.

5:04 PM Changeset in webkit [77569] by mrowe@apple.com
  • 1 copy in tags/Safari-534.17

New tag.

4:53 PM Changeset in webkit [77568] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-02-03 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

When in accelerated compositing mode, wait for DidSetSize messages
https://bugs.webkit.org/show_bug.cgi?id=53736

Normally we wait for DidSetSize messages from ::paint, but that's never called in
accelerated compositing mode so we just do it right after sending the SetSize message.

  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::paint): Call waitForAndDispatchDidSetSize.

(WebKit::DrawingAreaProxyImpl::sendSetSize):
Call waitForAndDispatchDidSetSize when in accelerated compositing mode.

(WebKit::DrawingAreaProxyImpl::waitForAndDispatchDidSetSize):
New utility function which waits for and dispatches a DidSetSize message.

  • UIProcess/DrawingAreaProxyImpl.h:
4:52 PM Changeset in webkit [77567] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-03 Brian Salomon <bsalomon@google.com>

Reviewed by James Robinson.

NHandle non-raster backed images in getUnmultipliedImageData()
https://bugs.webkit.org/show_bug.cgi?id=53468

No new tests. Existing canvas tests sufficient
LayoutTests/canvas/philip/...

  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
4:51 PM Changeset in webkit [77566] by hans@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-03 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

Chromium: Remove deprecated WebIDBObjectStore::put() function
https://bugs.webkit.org/show_bug.cgi?id=53669

Remove deprecated put() function. Chromium side code now overrides
the new version.

  • public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::put):
4:51 PM Changeset in webkit [77565] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-02-03 Abhishek Arya <inferno@chromium.org>

Reviewed by James Robinson.

Tests that we do not crash when overflowing the height of a root
inline box.
https://bugs.webkit.org/show_bug.cgi?id=53729

  • fast/overflow/overflow-height-float-not-removed-crash-expected.txt: Added.
  • fast/overflow/overflow-height-float-not-removed-crash.html: Added.

2011-02-03 Abhishek Arya <inferno@chromium.org>

Reviewed by James Robinson.

Enforce more limits on root inline boxes height calculations.
https://bugs.webkit.org/show_bug.cgi?id=53729

Test: fast/overflow/overflow-height-float-not-removed-crash.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::removeFloatingObject): prevent logicalBottom to become negative when logicalTop is INT_MAX. (WebCore::RenderBlock::markLinesDirtyInBlockRange): when logicalBottom is INT_MAX, we should dirty everything. So, we bail out to make afterLowest equal to the lastRootBox() or lowestDirstLine.
4:49 PM Changeset in webkit [77564] by abarth@webkit.org
  • 1 move
    1 delete in trunk/PerformanceTests

Merge PerformanceTests/Parser/ChangeLog and
PerformanceTests/PageLoad/ChangeLog into PerformanceTests/ChangeLog.

Rubber-stamped by Eric Seidel.

It's silly to have ChangeLogs for each of these directories separately.
I've left SunSpider with its own ChangeLog because it's more of an
independent entity.

  • ChangeLog: Added.
4:48 PM Changeset in webkit [77563] by levin@chromium.org
  • 9 edits
    4 adds in trunk

Worker.importScript() should clean errors for cross origin imports.
https://bugs.webkit.org/show_bug.cgi?id=52871

Reviewed by Adam Barth and Oliver Hunt.

Source/WebCore:

Test: http/tests/workers/worker-importScriptsOnError.html

  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::evaluate): Use sanitizeScriptError
to determine when to create a clean exception.

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::evaluate): Ditto.

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::sanitizeScriptError): Figure out
if the error needs to be cleaned up.
(WebCore::ScriptExecutionContext::dispatchErrorEvent): Extracted
sanitizeScriptError for use by other places.

  • dom/ScriptExecutionContext.h:
  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::importScripts): Use the reponse url when
telling the evaluate where the script came fro.

  • workers/WorkerScriptLoader.cpp:

(WebCore::WorkerScriptLoader::responseURL): Expose the url that
the script was loaded from (which may be different from url() due
to redirects).
(WebCore::WorkerScriptLoader::didReceiveResponse): Capture the reponse url.

  • workers/WorkerScriptLoader.h:

LayoutTests:

  • http/tests/workers/resources/worker-importScripts-error.js: Added.
  • http/tests/workers/resources/worker-importScripts-throw.js: Added.
  • http/tests/workers/worker-importScriptsOnError.html: Added.
4:46 PM Changeset in webkit [77562] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Source/WebCore

2011-02-03 Mark Mentovai <mark@chromium.org>

Reviewed by Dimitri Glazkov.

Chromium GYP build fix.

When various settings were moved to webcore_prerequisites in r66364,
things that should have been direct_dependent_settings were not marked
as such. GYP 'defines', for example, make no sense on a 'none'-type
target such as webcore_prerequisites. It appears that it was intended
for these settings to be pushed to direct dependents, which would make
direct_dependent_settings correct.

Losing the ChromiumWebCoreObjC defines on the Mac, for example, caused
http://crbug.com/71537, which at best causes Mac console log spew, and
at worst may result in Chromium's copy of WebCore using system
definitions of certain Objective-C classes at runtime, or vice-versa.

The build now includes a postbuild step to prevent
http://crbug.com/71537 from regressing again. The build will fail upon
regression.

https://bugs.webkit.org/show_bug.cgi?id=53630

  • WebCore.gyp/WebCore.gyp: Move things in webcore_prerequisites into direct_dependent_settings as needed, add the check_objc_rename postbuild step.
  • WebCore.gyp/mac/check_objc_rename.sh: Added.
4:42 PM Changeset in webkit [77561] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

2011-02-03 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Pass along an UpdateInfo object to the ExitAcceleratedCompositingMode message
https://bugs.webkit.org/show_bug.cgi?id=53734

  • UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::exitAcceleratedCompositingMode): Add an UpdateInfo parameter.
  • UIProcess/DrawingAreaProxy.messages.in: Add an UpdateInfo parameter to the ExitAcceleratedCompositingMode message.
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode): Incorporate the passed in update.
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): Create a new UpdateInfo object, paint into it and pass it along as a parameter to the ExitAcceleratedCompositingMode message.
4:41 PM Changeset in webkit [77560] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Make XSSFilter go fast by adding a SuffixTree
https://bugs.webkit.org/show_bug.cgi?id=53665

The SuffixTree lets us quickly reject snippets if the POST data is
large (because we can avoid a linear scan over the POST data).

  • html/parser/XSSFilter.cpp: (WebCore::XSSFilter::init): (WebCore::XSSFilter::isContainedInRequest):
  • html/parser/XSSFilter.h:
4:40 PM Changeset in webkit [77559] by mihaip@chromium.org
  • 4 edits
    3 adds in trunk

2011-02-03 Mihai Parparita <mihaip@chromium.org>

Reviewed by Alexey Proskuryakov.

REGRESSION (r77355): Page cache layout tests crash
https://bugs.webkit.org/show_bug.cgi?id=53648

Add test that calls setTimeout during a pagehide event handler (the
timeout should not fire while the document is in the page cache).

Skipped for Chromium since it doesn't use the page cache.

  • fast/events/pagehide-timeout-expected.txt: Added.
  • fast/events/pagehide-timeout.html: Added.
  • fast/events/resources/pagehide-timeout-go-back.html: Added.
  • platform/chromium/test_expectations.txt:

2011-02-03 Mihai Parparita <mihaip@chromium.org>

Reviewed by Alexey Proskuryakov.

REGRESSION (r77355): Page cache layout tests crash
https://bugs.webkit.org/show_bug.cgi?id=53648

Test: fast/events/pagehide-timeout.html

Suspend active DOM objects after all pagehide event handlers have run,
otherwise it's possible for them to create more objects that weren't
getting suspended.

  • history/CachedFrame.cpp: (WebCore::CachedFrame::CachedFrame):
4:37 PM Changeset in webkit [77558] by jorlow@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-02-03 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

SerializedScriptValue should not require v8 to create undefined and null values
https://bugs.webkit.org/show_bug.cgi?id=53730

Instead of creating a v8 type and passing that into the constructor, just use
the writer class directly. While I was at it, I cleaned up the code a bit too
by getting rid of the WireData/StringValue enum as I found that personally
confusing.

This is necessary because these methods are called by IndexedDB in the browser
process where v8 is not spun up.

No functionality changed and not possible to test.

  • bindings/v8/SerializedScriptValue.cpp: (WebCore::SerializedScriptValue::createFromWire): (WebCore::SerializedScriptValue::create): (WebCore::SerializedScriptValue::nullValue): (WebCore::SerializedScriptValue::undefinedValue): (WebCore::SerializedScriptValue::release): (WebCore::SerializedScriptValue::SerializedScriptValue):
  • bindings/v8/SerializedScriptValue.h:
4:27 PM Changeset in webkit [77557] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-03 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Not all blocks are freed when the heap is freed (counting is hard!)
https://bugs.webkit.org/show_bug.cgi?id=53732

  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::destroy): Freeing a block compacts the list, so just keep freeing block 0 until there are no blocks left.
4:18 PM Changeset in webkit [77556] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-02-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

Actually make the changes suggested by Mihai in his review
of bug 53720 :(

https://bugs.webkit.org/show_bug.cgi?id=53720

  • Scripts/webkitpy/layout_tests/port/test_files.py:
  • Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
4:17 PM Changeset in webkit [77555] by Beth Dakin
  • 9 edits in trunk/Source

Fix for <rdar://problem/8944544> Ability to animate track
for WKPainter scrollers

Reviewed by Sam Weinig.

Source/WebCore:

Two new WebKitSystemInterface functions.

  • WebCore.exp.in:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Use Scrollbar::convertFromContainingView() to return the right point.

  • platform/mac/ScrollAnimatorMac.mm:

(-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):

ScrollKnobAnimation is now ScrollbarPartAnimation. It can
now be used to animate the knob or the track.
(-[ScrollbarPartAnimation initWithScrollbarPainter:part:WebCore::scrollAnimator:WebCore::animateAlphaTo:duration:]):
(-[ScrollbarPartAnimation setCurrentProgress:]):
(-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):

Scrollbars need invalodating after the overlay state changes.
(-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]):

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

4:16 PM Changeset in webkit [77554] by Dimitri Glazkov
  • 1 edit
    4 adds in trunk/LayoutTests

2011-02-03 Dimitri Glazkov <Dimitri Glazkov>

Added SL-specific result for the test and put back the original result that
I've neglected to do in r77539.

  • platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Added.
  • platform/mac/svg/text/font-size-below-point-five-expected.txt: Added.
4:16 PM Changeset in webkit [77553] by mrowe@apple.com
  • 5 edits in branches/safari-533.20-branch

Versioning.

4:15 PM Changeset in webkit [77552] by mrowe@apple.com
  • 1 copy in tags/Safari-533.20.22

New tag.

4:15 PM Changeset in webkit [77551] by dpranke@chromium.org
  • 4 edits in trunk/Tools

2011-02-03 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

new-run-webkit-tests: Fix bug introduced in r77434 that was
causing us to run the canvas GPU tests on the Mac GPU port. This
bug revealed that we were not setting the port.name() field
properly in many cases, so I've cleaned up all of that code, and
removed a few comments about "version-specific" GPU ports that
don't exist and just confused things.

Testing also revealed that port.abspath_for_test() wasn't
normalizing paths on Windows properly, so I fixed that as well.

https://bugs.webkit.org/show_bug.cgi?id=53719

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
4:13 PM Changeset in webkit [77550] by dpranke@chromium.org
  • 4 edits in trunk/Tools

2011-02-03 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

new-run-webkit-tests: fix normalization of paths on windows when gathering files

r77434 introduced a bug that was causing the test expectations
for the GPU ports to not be treated properly. It turns out that
when we gathered the list of test files on Windows, we would
return paths of the form "c:\LayoutTests/fast/canvas", and the
mixture of backslashes and forward slashes was confusing things.

This patch normalizes all of the filenames returned from
test_files.find(), and adds better tests for this (fixing a
couple of other bugs found in the meantime).

https://bugs.webkit.org/show_bug.cgi?id=53720

  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/test_files.py:
  • Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
4:11 PM Changeset in webkit [77549] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Scroll thumb jumps to top when resizing horizontally.

Reviewed by Beth Dakin.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars): Add call to update
the scrollbar's offset in the case where we may have created
a new scrollbar but have not changed the current position.

4:07 PM Changeset in webkit [77548] by jschuh@chromium.org
  • 3 edits
    2 adds in trunk

2011-02-03 Justin Schuh <jschuh@chromium.org>

Reviewed by Dirk Schulze.

startAnimations should use a local, RefCounted Vector.
https://bugs.webkit.org/show_bug.cgi?id=53458

Test: svg/custom/use-animation-in-fill.html

  • svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::startAnimations):

2011-02-03 Justin Schuh <jschuh@chromium.org>

Reviewed by Dirk Schulze.

startAnimations should use a local, RefCounted Vector.
https://bugs.webkit.org/show_bug.cgi?id=53458

  • svg/custom/use-animation-in-fill-expected.txt: Added.
  • svg/custom/use-animation-in-fill.html: Added.
3:54 PM Changeset in webkit [77547] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

small text which is scaled to be large renders pixelated
https://bugs.webkit.org/show_bug.cgi?id=12448

  • platform/qt/Skipped: Add failing tests until fix.
    • css3/zoom-coords.xhtml
    • svg/zoom/page/zoom-zoom-coords.xhtml
3:38 PM Changeset in webkit [77546] by andersca@apple.com
  • 8 edits in trunk/Source/WebKit2

2011-02-03 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Change DidSetSize to take a LayerTreeContext parameter
https://bugs.webkit.org/show_bug.cgi?id=53724

Since SetSize can cause layout to happen, we need to pass along a layer tree context to
the DidSetSize message so the UI process can enter/exit accelerated compositing mode appropriately.


  • Shared/LayerTreeContext.h:
  • Shared/mac/LayerTreeContextMac.mm: Add equality operators to LayerTreeContext.
  • UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::didSetSize): This now takes a LayerTreeContext parameter.


  • UIProcess/DrawingAreaProxy.messages.in: Add LayerTreeContext parameter.
  • UIProcess/DrawingAreaProxyImpl.cpp: Get rid of m_isInAcceleratedCompositingMode and use the current layer context instead.

(WebKit::DrawingAreaProxyImpl::paint):
Bail if the call to DidSetSize ended up entering accelerated compositing mode.

(WebKit::DrawingAreaProxyImpl::didSetSize):
If the new layer tree context is different, enter/exit accelerated compositing mode accordingly.

(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
Update the layer tree context.

  • UIProcess/DrawingAreaProxyImpl.h: (WebKit::DrawingAreaProxyImpl::isInAcceleratedCompositingMode): Add simple getter.
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setSize): Pass along the layer tree context.
3:34 PM Changeset in webkit [77545] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-03 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

XSSFilter shouldn't bother to analyze pages without "injection"
characters in the request
https://bugs.webkit.org/show_bug.cgi?id=53664

If the request lacks these "injection" characters, then it's unlikely
that there's a reflective XSS attack happening. This hueristic lets us
avoid analyzing the vast majority of responses for XSS. Of course, the
hueristic isn't perfect. Because of this huerstic, we miss out on
injections into unquoted attributes. However, it's a trade-off that's
worked well in the XSSAuditor.

  • html/parser/XSSFilter.cpp: (WebCore::HTMLNames::isRequiredForInjection): (WebCore::XSSFilter::XSSFilter): (WebCore::XSSFilter::init): (WebCore::XSSFilter::filterToken): (WebCore::XSSFilter::isContainedInRequest):
  • html/parser/XSSFilter.h:
3:34 PM Changeset in webkit [77544] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-02-03 Dimitri Glazkov <Dimitri Glazkov>

Add a failure until I investigate its cause.

  • platform/chromium/test_expectations.txt: Added.
3:28 PM Changeset in webkit [77543] by mrowe@apple.com
  • 21 edits in branches/safari-533.20-branch

Merge r73444.

3:28 PM Changeset in webkit [77542] by mrowe@apple.com
  • 7 edits in branches/safari-533.20-branch/WebCore

Merge r59596.

3:27 PM Changeset in webkit [77541] by mrowe@apple.com
  • 5 edits in branches/safari-533.20-branch

Versioning.

3:26 PM Changeset in webkit [77540] by Dimitri Glazkov
  • 11 edits in trunk/LayoutTests

2011-02-03 Dimitri Glazkov <Dimitri Glazkov>

Updated platform/mac-leopard baselines for fast/backgrounds after r77485.

3:16 PM Changeset in webkit [77539] by Dimitri Glazkov
  • 1 edit
    1 move in trunk/LayoutTests

2011-02-03 Dimitri Glazkov <Dimitri Glazkov>

Move Leopard result to the right spot, put back the original result.

  • platform/mac-leopard/svg/text/font-size-below-point-five-expected.txt:

Renamed from LayoutTests/platform/mac/svg/text/font-size-below-point-five-expected.txt.

3:09 PM Changeset in webkit [77538] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip an SVG test that fails depending on what other tests came before it

Running any other SVG test before this one causes it to fail. If we were to check in new
failing results, it might start passing again if some more tests are added before it that
make it the first test that is run for a particular invocation of DumpRenderTree. So the
safest thing to do for now is to skip it. <http://webkit.org/b/35700> tracks this failure.

  • platform/win/Skipped: Added svg/W3C-SVG-1.1-SE/types-dom-01-b.svg.
2:54 PM Changeset in webkit [77537] by Adam Roben
  • 2 edits in trunk/Tools

Add links to Windows crash logs in results.html

Fixes <http://webkit.org/b/53718> run-webkit-tests should link to Windows crash logs in
results.html

Reviewed by David Kilzer.

  • Scripts/old-run-webkit-tests:

(top level): Added $crashLogTag and $windowsCrashLogFilePrefix (which came from
createDebuggerCommandFile).
(testCrashedOrTimedOut): If the test crashed, capture any saved crash log after the dump
tool has exited.
(captureSavedCrashLog): Added. Finds the crash log for the test that just crashed and moves
it into the test results directory tree. Only implemented for Cygwin currently.
(findNewestFileMatchingGlob): Added. Does what it says.
(htmlForResultsSection): Only link to files that exist.
(linksForErrorTest): Add a link to the crash log.
(deleteExpectedAndActualResults): Delete any old crash log for this test.
(createDebuggerCommandFile): Use the new $windowsCrashLogFilePrefix constant instead of
hardcoding it here.

2:51 PM Changeset in webkit [77536] by Dimitri Glazkov
  • 622 edits in trunk/LayoutTests

2011-02-03 Dimitri Glazkov <Dimitri Glazkov>

Updated platform/mac and platform/mac-leopard baselines for svg/ after r77485.

2:36 PM Changeset in webkit [77535] by mrobinson@webkit.org
  • 2 edits in trunk

2011-02-03 Martin Robinson <mrobinson@igalia.com>

Fix GTK+ WebGL build after r76600.

  • configure.ac: Make sure to respect configure.ac conventions consistently when it comes to capitalization. Remove an old reference to enable_3d_canvas.
2:27 PM Changeset in webkit [77534] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

Get rid of LayerTreeContext::seed on Mac.
Add sequence checks to enterAcceleratedCompositingMode and exitAcceleratedCompositingMode and
have them call newly added overloads that don't have the checks.

Reviewed by Dan Bernstein.

  • Shared/LayerTreeContext.h:
  • Shared/mac/LayerTreeContextMac.mm:

(WebKit::LayerTreeContext::LayerTreeContext):
(WebKit::LayerTreeContext::encode):
(WebKit::LayerTreeContext::decode):

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):

  • UIProcess/DrawingAreaProxyImpl.h:
  • WebProcess/WebPage/mac/LayerTreeHostMac.mm:

(WebKit::LayerTreeHostMac::LayerTreeHostMac):

2:19 PM Changeset in webkit [77533] by andersca@apple.com
  • 10 edits in trunk/Source/WebKit2

2011-02-03 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Get rid of timestamps in UpdateInfo
https://bugs.webkit.org/show_bug.cgi?id=53713

Add a 64-bit sequence number to all DrawingAreaProxy messages, and use it to
check whether Update messages should be handled or not.

  • Shared/UpdateInfo.cpp: (WebKit::UpdateInfo::encode): (WebKit::UpdateInfo::decode):
  • Shared/UpdateInfo.h: (WebKit::UpdateInfo::UpdateInfo):
  • UIProcess/BackingStore.cpp: (WebKit::BackingStore::BackingStore): (WebKit::BackingStore::incorporateUpdate):
  • UIProcess/BackingStore.h:
  • UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::update): (WebKit::DrawingAreaProxy::didSetSize): (WebKit::DrawingAreaProxy::enterAcceleratedCompositingMode): (WebKit::DrawingAreaProxy::exitAcceleratedCompositingMode):
  • UIProcess/DrawingAreaProxy.messages.in:
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl): (WebKit::DrawingAreaProxyImpl::update): (WebKit::DrawingAreaProxyImpl::didSetSize): (WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode): (WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
  • UIProcess/DrawingAreaProxyImpl.h:
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::generateSequenceNumber): (WebKit::DrawingAreaImpl::setSize): (WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode): (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): (WebKit::DrawingAreaImpl::display):
1:51 PM Changeset in webkit [77532] by vangelis@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-03 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Fixing a compositor crash occurring on layers
without an associated RenderSurface.
https://bugs.webkit.org/show_bug.cgi?id=53679
Regression was introduced by in r77425

Test: http://webkit.org/blog/386/3d-transforms/ doesn't crash
anymore.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayer):
1:44 PM Changeset in webkit [77531] by Dimitri Glazkov
  • 6 edits in trunk/LayoutTests

2011-02-03 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Updated baselines that are specific to Leopard.

  • platform/chromium-mac-leopard/svg/custom/linking-a-03-b-preserveAspectRatio-expected.txt:
  • platform/chromium-mac-leopard/svg/custom/linking-a-03-b-viewTarget-expected.txt:
  • platform/chromium-mac-leopard/svg/custom/linking-a-03-b-zoomAndPan-expected.txt:
  • platform/chromium-mac-leopard/svg/custom/stroked-pattern-expected.png:
  • platform/chromium-mac-leopard/svg/custom/stroked-pattern-expected.txt:
1:19 PM Changeset in webkit [77530] by mitz@apple.com
  • 5 edits in trunk

<rdar://problem/8948788> Text emphasis marks have wrong orientation for vertical text
https://bugs.webkit.org/show_bug.cgi?id=53709

Reviewed by Anders Carlsson.

Source/WebCore:

Covered by rendering of fast/text/emphasis-vertical.html

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::scaledFontData): Give the scaled font the same orientation this font
has.

LayoutTests:

  • platform/mac/fast/text/emphasis-vertical-expected.checksum:
  • platform/mac/fast/text/emphasis-vertical-expected.png:
1:12 PM ApplicationsGtk edited by grant_gayed@ca.ibm.com
add SWT to the Widget Toolkits section (diff)
12:50 PM Changeset in webkit [77529] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

2011-02-03 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Don't send enter/exit accelerated compositing mode messages when handling setSize
https://bugs.webkit.org/show_bug.cgi?id=53706

Don't send EnterAcceleratedCompositingMode/ExitAcceleratedCompositing mode when
the mode changes happen as a result of relayout in setSize, since an updated state
is going to be sent back in the DidSetSize message.


  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::didSetSize): Add an assert.
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::DrawingAreaImpl): Initialize m_inSetSize.

(WebKit::DrawingAreaImpl::setRootCompositingLayer):
Factor out code into enterAcceleratedCompositingMode and exitAcceleratedCompositingMode.

(WebKit::DrawingAreaImpl::setSize):
Set m_inSetSize to true while handling setSize.

(WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
Take over the message sending responsibility from LayerTreeHostMac, and don't send messages
if we're currently handling a SetSize message.

  • WebProcess/WebPage/DrawingAreaImpl.h: Add m_inSetSize.
  • WebProcess/WebPage/LayerTreeHost.h: Add layerTreeHost getter.
  • WebProcess/WebPage/mac/LayerTreeHostMac.h:
  • WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::LayerTreeHostMac): Don't send EnterAcceleratedCompositingMode messages.

(WebKit::LayerTreeHostMac::layerTreeContext):
Add getter for the current layer tree context.

(WebKit::LayerTreeHostMac::invalidate):
Don't send ExitAcceleratedCompositingMode messages.

12:42 PM Changeset in webkit [77528] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-03 Martin Robinson <mrobinson@igalia.com>

Fix one GTK+ skipped list entry that referred to the wrong test file.

  • platform/gtk/Skipped: Fix skipped list entry.
12:33 PM Changeset in webkit [77527] by Dimitri Glazkov
  • 1 edit
    1 delete in trunk/LayoutTests

2011-02-03 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Removed the checksum that is out of place.

  • platform/chromium-win-xp/svg/text/text-fonts-01-t-expected.checksum: Removed.
12:30 PM Changeset in webkit [77526] by Dimitri Glazkov
  • 2 edits
    2 adds
    1 delete in trunk/LayoutTests

2011-02-03 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Updated SVG baselines after r77485 for Mac and added expectations
of failure while waiting for platform/mac pixel results to land.

  • platform/chromium-mac/svg/custom/linking-a-03-b-transform-expected.txt: Removed.
  • platform/chromium-mac/svg/custom/stroked-pattern-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/stroked-pattern-expected.png: Added.
  • platform/chromium/test_expectations.txt: Added fails.
12:29 PM Changeset in webkit [77525] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Try to fix the Mac build.

  • JavaScriptCore.xcodeproj/project.pbxproj: The new MarkedBlock.h header

needs to be private, not project, so other projects can include headers
that depend on it.

11:52 AM Changeset in webkit [77524] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-02-03 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Make the layer tree host keep track of the layer tree context
https://bugs.webkit.org/show_bug.cgi?id=53698

Add a LayerTreeContext member variable to the LayerTreeHost object,
and also add a seed count to the LayerTreeContext so we can keep track of
how layer tree contexts relate to each other.

  • Shared/LayerTreeContext.h:
  • Shared/mac/LayerTreeContextMac.mm: (WebKit::LayerTreeContext::LayerTreeContext): (WebKit::LayerTreeContext::makeWithSeed): (WebKit::LayerTreeContext::encode): (WebKit::LayerTreeContext::decode):
  • WebProcess/WebPage/mac/LayerTreeHostMac.h: Add the layer tree context as a member variable.
  • WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::LayerTreeHostMac): Initialize the layer tree context.
11:48 AM Changeset in webkit [77523] by Adam Roben
  • 17 edits
    2 adds in trunk/LayoutTests

Check in the results I really meant to commit in r77507

A flub on the command-line meant that many of the results added in r77507 were identical to
the Mac results, rather than matching what happens on Windows.

  • platform/win/svg/W3C-SVG-1.1/text-align-06-b-expected.checksum:
  • platform/win/svg/W3C-SVG-1.1/text-align-06-b-expected.png:
  • platform/win/svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
  • platform/win/svg/batik/masking/maskRegions-expected.checksum: Added.
  • platform/win/svg/batik/masking/maskRegions-expected.png: Added.
  • platform/win/svg/batik/masking/maskRegions-expected.txt:
  • platform/win/svg/batik/text/textGlyphOrientationHorizontal-expected.checksum:
  • platform/win/svg/batik/text/textGlyphOrientationHorizontal-expected.png:
  • platform/win/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
  • platform/win/svg/carto.net/scrollbar-expected.checksum:
  • platform/win/svg/carto.net/scrollbar-expected.png:
  • platform/win/svg/carto.net/scrollbar-expected.txt:
  • platform/win/svg/text/font-size-below-point-five-expected.checksum:
  • platform/win/svg/text/font-size-below-point-five-expected.png:
  • platform/win/svg/text/font-size-below-point-five-expected.txt:
  • platform/win/svg/text/text-align-06-b-expected.checksum:
  • platform/win/svg/text/text-align-06-b-expected.png:
  • platform/win/svg/text/text-align-06-b-expected.txt:
11:48 AM QtWebKitDocContrib edited by Ademar Reis
(diff)
11:44 AM Changeset in webkit [77522] by Dimitri Glazkov
  • 1 edit
    2 adds in trunk/LayoutTests

2011-02-03 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Two more updated SVG baselines after r77485 for Linux.

  • platform/chromium-linux/svg/batik/text/verticalText-expected.txt: Added.
  • platform/chromium-linux/svg/custom/js-late-pattern-and-object-creation-expected.txt: Added.
11:31 AM Changeset in webkit [77521] by leviw@chromium.org
  • 3 edits
    2 adds in trunk

2011-02-02 Levi Weintraub <leviw@chromium.org>

Reviewed by Ryosuke Niwa.

Moving cursor down in table cycles at the end of a row
https://bugs.webkit.org/show_bug.cgi?id=50012


Tests downward caret-navigation for tables at the end of a document.

  • editing/selection/move-by-line-cycles-in-table-expected.txt: Added.
  • editing/selection/move-by-line-cycles-in-table.html: Added.

2011-02-02 Levi Weintraub <leviw@chromium.org>

Reviewed by Ryosuke Niwa.

Moving cursor down in table cycles at the end of a row
https://bugs.webkit.org/show_bug.cgi?id=50012

Avoids a caret cycling issue with certain content (e.g. tables) found at the very
end of a document due to a bug in nextLeafWithSameEditability.

Test: editing/selection/move-by-line-cycles-in-table.html

  • editing/visible_units.cpp: (WebCore::nextLeafWithSameEditability): Properly avoid descending back into the original leaf node.
11:28 AM Changeset in webkit [77520] by Dimitri Glazkov
  • 3 edits in trunk/LayoutTests

2011-02-03 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] One more update SVG baselines after r77485 for Linux.

11:23 AM Changeset in webkit [77519] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-02-03 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Start using MarkedBlock instead of CollectorBlock
https://bugs.webkit.org/show_bug.cgi?id=53693


SunSpider reports no change.


  • runtime/MarkedBlock.h: (JSC::MarkedBlock::blockFor): (JSC::MarkedBlock::setMarked): (JSC::MarkedBlock::isCellAligned): (JSC::MarkedBlock::isPossibleCell): Updated for const-ness.
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::allocateBlock): (JSC::MarkedSpace::containsSlowCase): (JSC::MarkedSpace::clearMarkBits): Updated for const-ness.
  • runtime/MarkedSpace.h: (JSC::CollectorHeap::collectorBlock): (JSC::MarkedSpace::heap): (JSC::MarkedSpace::isMarked): (JSC::MarkedSpace::testAndSetMarked): (JSC::MarkedSpace::setMarked): (JSC::MarkedSpace::contains): Switched from CollectorBlock to MarkedBlock, and deleted dead CollectorBlock-related code.
11:23 AM Changeset in webkit [77518] by Dimitri Glazkov
  • 9 edits
    4 moves
    8 deletes in trunk/LayoutTests

2011-02-03 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Moved XP/Vista-specific baselines to their proper places.

  • platform/chromium-win-vista/svg/text/text-fonts-01-t-expected.checksum:
  • platform/chromium-win-vista/svg/text/text-fonts-01-t-expected.png:
  • platform/chromium-win-xp/svg/batik/text/verticalText-expected.checksum:
  • platform/chromium-win-xp/svg/batik/text/verticalText-expected.png:
  • platform/chromium-win-xp/svg/custom/js-late-pattern-and-object-creation-expected.checksum:
  • platform/chromium-win-xp/svg/custom/js-late-pattern-and-object-creation-expected.png:
  • platform/chromium-win-xp/svg/text/text-intro-05-t-expected.checksum:
  • platform/chromium-win-xp/svg/text/text-intro-05-t-expected.png:
  • platform/chromium-win/svg/batik/text/verticalText-expected.checksum: Removed.
  • platform/chromium-win/svg/batik/text/verticalText-expected.png: Removed.
  • platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.png: Removed.
  • platform/chromium-win/svg/text/text-fonts-01-t-expected.checksum: Removed.
  • platform/chromium-win/svg/text/text-fonts-01-t-expected.png: Removed.
  • platform/chromium-win/svg/text/text-intro-05-t-expected.checksum: Removed.
  • platform/chromium-win/svg/text/text-intro-05-t-expected.png: Removed.
11:05 AM Changeset in webkit [77517] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-02-03 Dimitri Glazkov <Dimitri Glazkov>

Update expectations after r77495.

  • fast/dom/Window/window-properties-expected.txt: Updated.
10:50 AM Changeset in webkit [77516] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-02-03 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Explicitly mark platform/chromium-linux as failing for other platforms.

  • platform/chromium/test_expectations.txt: Added expectation of failure.
10:46 AM Changeset in webkit [77515] by Adam Roben
  • 2 edits in trunk/Tools

Tell the debugger the path to the WebKit source tree when saving a crash log

This allows the debugger to include the crashing line of code in the log.

Fixes <http://webkit.org/b/53678> Crash logs from buildslaves don't show the crashing line
of code

Reviewed by Sam Weinig.

  • Scripts/old-run-webkit-tests:

(createDebuggerCommandFile): Added. Saves commands that we'd like the debugger to run to a
file and returns the path to that file. The commands we pass came from
setUpWindowsCrashLogSaving, but I've added a .srcpath command to tell the debugger where the
WebKit source code lives.
(setUpWindowsCrashLogSaving): Instead of specifying the commands directly on the command
line using -c, save them to a file and specify the path to that file using -cf. This works
around what is presumably a bug in Windows's command line parsing, where having multiple
quoted paths in the debugger commands causes the post-mortem debugger not to be invoked at
all. Also pulled the options we pass to the debugger out into a list that is then join()ed
together to make them easier to modify in the future.

10:41 AM Changeset in webkit [77514] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-02-03 Dimitri Glazkov <Dimitri Glazkov>

Update expectations after r77495.

  • fast/dom/Window/window-properties-performance-expected.txt: Updated.
10:33 AM Changeset in webkit [77513] by Dimitri Glazkov
  • 1 edit
    1 move
    5 adds in trunk/LayoutTests

2011-02-03 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Add expectations for r77500.

  • platform/chromium-mac/fast/dom/HTMLInputElement/input-slider-update-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/HTMLInputElement/input-slider-update-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLInputElement/input-slider-update-expected.checksum: Added.
  • platform/chromium-win/fast/dom/HTMLInputElement/input-slider-update-expected.png: Added.
10:28 AM Changeset in webkit [77512] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix Qt build.

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPage::QWKPage):

10:20 AM Changeset in webkit [77511] by Dimitri Glazkov
  • 338 edits
    1 copy
    26 adds
    45 deletes in trunk/LayoutTests

2011-02-03 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Update SVG baselines after r77485 for Linux.

10:19 AM Changeset in webkit [77510] by podivilov@chromium.org
  • 7 edits
    1 delete in trunk/Source/WebCore

2011-02-03 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove dead code related to changes panel.
https://bugs.webkit.org/show_bug.cgi?id=53688

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/ChangesView.js: Removed.
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css: (#error-warning-count): (#error-warning-count:hover): (#error-count + #warning-count):
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:
10:13 AM Changeset in webkit [77509] by weinig@apple.com
  • 21 edits in trunk

Add notification of the end of a rubber band.
<rdar://problem/8940648>

Reviewed by Anders Carlsson.

Source/WebCore:

  • WebCore.exp.in:

Add additional exprots.

  • page/ChromeClient.h:

(WebCore::ChromeClient::didCompleteRubberBandForMainFrame):

  • page/FrameView.cpp:

(WebCore::FrameView::didCompleteRubberBand):

  • page/FrameView.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::didCompleteRubberBand):

  • platform/ScrollView.h:

Add hook.

  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::inLiveResize):
(WebCore::ScrollableArea::maximumScrollPosition):
(WebCore::ScrollableArea::visibleWidth):
(WebCore::ScrollableArea::overhangAmount):
(WebCore::ScrollableArea::didCompleteRubberBand):
Reorganize and de-virtualize live resize notifications.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
Call the new hook when the rubberband ends.

Source/WebKit2:

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::drawHeader):
(WebKit::WebPageProxy::drawFooter):
(WebKit::WebPageProxy::didCompleteRubberBandForMainFrame):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::didCompleteRubberBandForMainFrame):

  • UIProcess/WebUIClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::didCompleteRubberBandForMainFrame):

  • WebProcess/WebCoreSupport/WebChromeClient.h:

Pipe the notification up to the WKUIClient.

Tools:

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):
Stub out the new WKUIClient function.

10:07 AM Changeset in webkit [77508] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip fast/canvas/set-colors.html on Windows

It currently fails on some bots but not others. <http://webkit.org/b/53677> tracks the
investigation.

  • platform/win/Skipped:
10:02 AM Changeset in webkit [77507] by Adam Roben
  • 3 edits
    22 adds in trunk/LayoutTests

Update Windows results after r77485

Windows used to match Mac on these tests, but now it doesn't. Presumably this is because
r77485 increased the precision of ascent/descent calculations, making differences in
Windows/Mac font metrics matter more.

One test (svg/W3C-SVG-1.1-SE/types-dom-01-b.svg) is still failing, but it passes when run on
its own, so warrants more investigation.

  • platform/win/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.checksum: Added.
  • platform/win/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png: Added.
  • platform/win/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt:
  • platform/win/svg/W3C-SVG-1.1/text-align-06-b-expected.checksum: Added.
  • platform/win/svg/W3C-SVG-1.1/text-align-06-b-expected.png: Added.
  • platform/win/svg/W3C-SVG-1.1/text-align-06-b-expected.txt: Added.
  • platform/win/svg/batik/text/textGlyphOrientationHorizontal-expected.checksum: Added.
  • platform/win/svg/batik/text/textGlyphOrientationHorizontal-expected.png: Added.
  • platform/win/svg/batik/text/textGlyphOrientationHorizontal-expected.txt: Added.
  • platform/win/svg/carto.net/scrollbar-expected.checksum: Added.
  • platform/win/svg/carto.net/scrollbar-expected.png: Added.
  • platform/win/svg/carto.net/scrollbar-expected.txt: Added.
  • platform/win/svg/text/font-size-below-point-five-expected.checksum: Added.
  • platform/win/svg/text/font-size-below-point-five-expected.png: Added.
  • platform/win/svg/text/font-size-below-point-five-expected.txt: Added.
  • platform/win/svg/text/text-align-06-b-expected.checksum: Added.
  • platform/win/svg/text/text-align-06-b-expected.png: Added.
  • platform/win/svg/text/text-align-06-b-expected.txt: Added.
  • platform/win/svg/zoom/page/zoom-mask-with-percentages-expected.checksum: Added.
  • platform/win/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
  • platform/win/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
10:00 AM Changeset in webkit [77506] by Nikolas Zimmermann
  • 70 edits in trunk/LayoutTests

2011-02-03 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

small text which is scaled to be large renders pixelated
https://bugs.webkit.org/show_bug.cgi?id=12448

First chunk, updating mac SVG pixel test baseline after r77485.

  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:

...

9:54 AM Changeset in webkit [77505] by Csaba Osztrogonác
  • 2 edits
    1 copy in trunk/LayoutTests

Unreviewed. Update Qt specific expected results after r77495.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-performance-expected.txt: Copied from LayoutTests/fast/dom/Window/window-properties-performance-expected.txt.
9:49 AM Changeset in webkit [77504] by evan@chromium.org
  • 5 edits
    4 adds in trunk

2011-02-02 Evan Martin <evan@chromium.org>

Reviewed by Tony Chang.

[chromium] complex joining characters positioned in wrong place
https://bugs.webkit.org/show_bug.cgi?id=53637

Add a test that includes some characters that exhibited the problem.
Unfortunately it's purely a rendering issue, so it is a pixel test.

  • platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.checksum: Added.
  • platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.png: Added.
  • platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.txt: Added.
  • platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html: Added.

2011-02-02 Evan Martin <evan@chromium.org>

Reviewed by Tony Chang.

[chromium] complex joining characters positioned in wrong place
https://bugs.webkit.org/show_bug.cgi?id=53637

Provide the correct font metrics to Harfbuzz related to the font design space.
There are used in some fonts for GPOS positioning.

Test: platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html

  • platform/graphics/chromium/ComplexTextControllerLinux.cpp: (WebCore::ComplexTextController::setupFontForScriptRun): (WebCore::ComplexTextController::allocHarfbuzzFont):
  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::emSizeInFontUnits): (WebCore::FontPlatformData::operator=):
  • platform/graphics/chromium/FontPlatformDataLinux.h: (WebCore::FontPlatformData::FontPlatformData):
9:43 AM Changeset in webkit [77503] by mnaganov@chromium.org
  • 2 edits in branches/chromium/648/Source/WebCore/inspector/front-end

Merge 77480 - 2011-02-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: resources panel doesn't show frames after reload.
https://bugs.webkit.org/show_bug.cgi?id=53430

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.show): (WebInspector.ResourcesPanel.prototype.loadEventFired): (WebInspector.ResourcesPanel.prototype._initDefaultSelection): (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype.clear):
  • inspector/front-end/inspector.js: (WebInspector.loadEventFired):

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/6368081

9:42 AM Changeset in webkit [77502] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-03 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; remove the line I intended to remove.

  • platform/chromium/test_expectations.txt:
9:36 AM Changeset in webkit [77501] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-03 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectation update for
http://src.chromium.org/viewvc/chrome?view=rev&revision=73469

  • platform/chromium/test_expectations.txt:
9:28 AM Changeset in webkit [77500] by Dimitri Glazkov
  • 7 edits
    4 adds in trunk

2011-02-02 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

REGRESSION(r76147): Slider thumb position is not updated when value attribute is changed.
https://bugs.webkit.org/show_bug.cgi?id=53634

  • fast/dom/HTMLInputElement/input-slider-update.html: Added.
  • platform/mac/fast/dom/HTMLInputElement/input-slider-update-expected.checksum: Added.
  • platform/mac/fast/dom/HTMLInputElement/input-slider-update-expected.png: Added.
  • platform/mac/fast/dom/HTMLInputElement/input-slider-update-expected.txt: Added.

2011-02-02 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

REGRESSION(r76147): Slider thumb position is not updated when value attribute is changed.
https://bugs.webkit.org/show_bug.cgi?id=53634

Test: fast/dom/HTMLInputElement/input-slider-update.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValue): Added a call to InputType::valueChanged.
  • html/InputType.cpp: (WebCore::InputType::valueChanged): Added empty implementation.
  • html/InputType.h: Added def.
  • html/RangeInputType.cpp: (WebCore::RangeInputType::valueChanged): Added implementation that dirties layout

bit on the thumb.

  • html/RangeInputType.h: Added def.
9:22 AM Changeset in webkit [77499] by Dimitri Glazkov
  • 762 edits
    1 copy
    25 adds
    5 deletes in trunk/LayoutTests

2011-02-03 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Update SVG baselines after r77485 for Windows.

9:15 AM Changeset in webkit [77498] by podivilov@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-02-02 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: do not share source frames between resources panel and scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=53584

Currently, we show error messages only for resources. This change will allow showing error
messages in source frame even when resource is not available (eval scripts, inlined scripts).

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.addMessage): (WebInspector.ConsoleView.prototype.clearMessages):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.recreateResourceView):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.FrameResourceTreeElement.prototype._setBubbleText):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._scriptSourceChanged): (WebInspector.ScriptsPanel.prototype.addConsoleMessage): (WebInspector.ScriptsPanel.prototype.clearConsoleMessages): (WebInspector.ScriptsPanel.prototype.reset): (WebInspector.ScriptsPanel.prototype._sourceFrameForScriptOrResource): (WebInspector.ScriptsPanel.prototype._sourceFrameForResource): (WebInspector.ScriptsPanel.prototype._sourceFrameForScript):
9:13 AM Changeset in webkit [77497] by Csaba Osztrogonác
  • 93 edits
    4 adds in trunk/LayoutTests

Unreviewed, rebaseline Qt svg tests after r77485.

  • platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum:
  • platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.checksum:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.checksum:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.checksum:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.checksum:
  • platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
  • platform/qt/svg/custom/stroke-width-large-expected.checksum:
  • platform/qt/svg/custom/stroke-width-large-expected.png:
  • platform/qt/svg/custom/stroke-width-large-expected.txt:
  • platform/qt/svg/custom/text-rotated-gradient-expected.checksum:
  • platform/qt/svg/custom/text-rotated-gradient-expected.png:
  • platform/qt/svg/custom/text-rotated-gradient-expected.txt:
  • platform/qt/svg/foreignObject/text-tref-02-b-expected.checksum:
  • platform/qt/svg/foreignObject/text-tref-02-b-expected.png:
  • platform/qt/svg/foreignObject/text-tref-02-b-expected.txt:
  • platform/qt/svg/text/lengthAdjust-text-metrics-expected.checksum: Added.
  • platform/qt/svg/text/lengthAdjust-text-metrics-expected.png: Added.
  • platform/qt/svg/text/lengthAdjust-text-metrics-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-1-expected.checksum:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-1-expected.png:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-2-expected.checksum:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-2-expected.png:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-3-expected.checksum:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-3-expected.png:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-3-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-4-expected.checksum:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-4-expected.png:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-4-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-stretch-1-expected.checksum:
  • platform/qt/svg/text/select-textLength-spacing-stretch-1-expected.png:
  • platform/qt/svg/text/select-textLength-spacing-stretch-1-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-stretch-2-expected.checksum:
  • platform/qt/svg/text/select-textLength-spacing-stretch-2-expected.png:
  • platform/qt/svg/text/select-textLength-spacing-stretch-2-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-stretch-3-expected.checksum:
  • platform/qt/svg/text/select-textLength-spacing-stretch-3-expected.png:
  • platform/qt/svg/text/select-textLength-spacing-stretch-3-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-stretch-4-expected.checksum:
  • platform/qt/svg/text/select-textLength-spacing-stretch-4-expected.png:
  • platform/qt/svg/text/select-textLength-spacing-stretch-4-expected.txt:
  • platform/qt/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.checksum:
  • platform/qt/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.png:
  • platform/qt/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
  • platform/qt/svg/text/select-x-list-1-expected.checksum:
  • platform/qt/svg/text/select-x-list-1-expected.png:
  • platform/qt/svg/text/select-x-list-1-expected.txt:
  • platform/qt/svg/text/select-x-list-2-expected.checksum:
  • platform/qt/svg/text/select-x-list-2-expected.png:
  • platform/qt/svg/text/select-x-list-2-expected.txt:
  • platform/qt/svg/text/select-x-list-3-expected.checksum:
  • platform/qt/svg/text/select-x-list-3-expected.png:
  • platform/qt/svg/text/select-x-list-3-expected.txt:
  • platform/qt/svg/text/select-x-list-4-expected.checksum:
  • platform/qt/svg/text/select-x-list-4-expected.png:
  • platform/qt/svg/text/select-x-list-4-expected.txt:
  • platform/qt/svg/text/select-x-list-with-tspans-1-expected.checksum:
  • platform/qt/svg/text/select-x-list-with-tspans-1-expected.png:
  • platform/qt/svg/text/select-x-list-with-tspans-1-expected.txt:
  • platform/qt/svg/text/select-x-list-with-tspans-2-expected.checksum:
  • platform/qt/svg/text/select-x-list-with-tspans-2-expected.png:
  • platform/qt/svg/text/select-x-list-with-tspans-2-expected.txt:
  • platform/qt/svg/text/select-x-list-with-tspans-3-expected.checksum:
  • platform/qt/svg/text/select-x-list-with-tspans-3-expected.png:
  • platform/qt/svg/text/select-x-list-with-tspans-3-expected.txt:
  • platform/qt/svg/text/select-x-list-with-tspans-4-expected.checksum:
  • platform/qt/svg/text/select-x-list-with-tspans-4-expected.png:
  • platform/qt/svg/text/select-x-list-with-tspans-4-expected.txt:
  • platform/qt/svg/text/selection-doubleclick-expected.checksum:
  • platform/qt/svg/text/selection-doubleclick-expected.png:
  • platform/qt/svg/text/selection-doubleclick-expected.txt:
  • platform/qt/svg/text/selection-tripleclick-expected.checksum:
  • platform/qt/svg/text/selection-tripleclick-expected.png:
  • platform/qt/svg/text/selection-tripleclick-expected.txt:
  • platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.checksum:
  • platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.png:
  • platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
  • platform/qt/svg/zoom/page/zoom-coords-viewattr-01-b-expected.checksum: Added.
  • platform/qt/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.checksum:
  • platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
8:58 AM Changeset in webkit [77496] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

2011-02-03 Simon Fraser <Simon Fraser>

Fix 32-bit builds.

  • platform/graphics/ShadowBlur.cpp: (WebCore::ShadowBlur::blurLayerImage):
8:32 AM Changeset in webkit [77495] by mnaganov@chromium.org
  • 17 edits
    1 copy in trunk/Source/WebCore

2011-02-03 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Add reporting of JS heap size limit to 'console.memory'.
https://bugs.webkit.org/show_bug.cgi?id=53592

In JSC there is no limit, thus 'undefined' value is returned.
For V8, the limit reported by the VM is returned.

  • Android.jscbindings.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSMemoryInfoCustom.cpp: Added.
  • bindings/js/ScriptGCEvent.cpp: (WebCore::ScriptGCEvent::getHeapSize):
  • bindings/js/ScriptGCEvent.h:
  • bindings/v8/ScriptGCEvent.cpp: (WebCore::ScriptGCEvent::getHeapSize):
  • bindings/v8/ScriptGCEvent.h:
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::setHeapSizeStatistic):
  • page/MemoryInfo.cpp: (WebCore::MemoryInfo::MemoryInfo):
  • page/MemoryInfo.h: (WebCore::MemoryInfo::jsHeapSizeLimit):
  • page/MemoryInfo.idl:
8:29 AM Changeset in webkit [77494] by Philippe Normand
  • 4 edits in trunk

2011-01-27 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] LayoutTests/media/audio-mpeg4-supported.html fails
https://bugs.webkit.org/show_bug.cgi?id=53125

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::mimeTypeCache): Add audio/x-m4a mimetype in the cache.

LayoutTests:

2011-01-27 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] LayoutTests/media/audio-mpeg4-supported.html fails
https://bugs.webkit.org/show_bug.cgi?id=53125

  • platform/gtk/Skipped: Unskip fixed test.
8:19 AM Changeset in webkit [77493] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-02-03 Philippe Normand <pnormand@igalia.com>

Unreviewed, skipping 2 more websocket tests on GTK, see bug 53683.

  • platform/gtk/Skipped: skip http/tests/websocket/tests/simple.html and http/tests/websocket/tests/cross-origin.html
8:10 AM Changeset in webkit [77492] by Simon Fraser
  • 39 edits in trunk

2011-02-03 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

ShadowBlur radius for CSS shadows is slightly too big
https://bugs.webkit.org/show_bug.cgi?id=53660

If we follow SVG gaussian blur for CSS shadows, we can end up rendering
shadows that extend further than the CSS "blur radius", which results
in the shadows being truncated.

Fix with a small fudge factor to reduce the kernel diameter slightly
for CSS shadows.

Also more closely follow the algorithm described in the SVG spec
for computing the kernel size for different diameters, and clean up
some variable naming relating to the shadow bounds.

  • platform/graphics/ShadowBlur.cpp: (WebCore::ShadowBlur::blurLayerImage): (WebCore::ShadowBlur::drawRectShadowWithTiling):
8:02 AM Changeset in webkit [77491] by Patrick Gansterer
  • 5 edits in trunk/Source/JavaScriptCore

2011-02-03 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Avoid strlen() in AtomicString::fromUTF8
https://bugs.webkit.org/show_bug.cgi?id=50516

Add an overload to calculateStringHashFromUTF8 to get
strlen() of the input data with only one call.

This change shows about 3% performance win on the xml-parser benchmark.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • wtf/text/AtomicString.cpp: (WTF::AtomicString::fromUTF8):
  • wtf/unicode/UTF8.cpp: (WTF::Unicode::calculateStringHashAndLengthFromUTF8Internal): (WTF::Unicode::calculateStringHashFromUTF8): (WTF::Unicode::calculateStringHashAndLengthFromUTF8):
  • wtf/unicode/UTF8.h:
7:51 AM Changeset in webkit [77490] by Philippe Normand
  • 43 edits in trunk/LayoutTests

2011-02-03 Philippe Normand <pnormand@igalia.com>

Unreviewed, rebaseline GTK svg tests after r77485.

  • platform/gtk/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
  • platform/gtk/svg/css/composite-shadow-text-expected.txt:
  • platform/gtk/svg/css/group-with-shadow-expected.txt:
  • platform/gtk/svg/css/shadow-changes-expected.txt:
  • platform/gtk/svg/css/text-gradient-shadow-expected.txt:
  • platform/gtk/svg/custom/stroke-width-large-expected.txt:
  • platform/gtk/svg/custom/text-rotated-gradient-expected.txt:
  • platform/gtk/svg/custom/text-rotation-expected.txt:
  • platform/gtk/svg/foreignObject/text-tref-02-b-expected.txt:
  • platform/gtk/svg/hixie/text/001-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-3-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-4-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-stretch-1-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-stretch-2-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-stretch-3-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-stretch-4-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
  • platform/gtk/svg/text/select-x-list-1-expected.txt:
  • platform/gtk/svg/text/select-x-list-2-expected.txt:
  • platform/gtk/svg/text/select-x-list-3-expected.txt:
  • platform/gtk/svg/text/select-x-list-4-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-1-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-2-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-3-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-4-expected.txt:
  • platform/gtk/svg/text/selection-doubleclick-expected.txt:
  • platform/gtk/svg/text/selection-tripleclick-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:
7:24 AM Changeset in webkit [77489] by podivilov@chromium.org
  • 27 edits in trunk

2011-02-01 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: introduce new api for managing JavaScript breakpoints.
https://bugs.webkit.org/show_bug.cgi?id=53235

  • inspector/report-protocol-errors.html:

2011-02-01 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: introduce new api for managing JavaScript breakpoints.
https://bugs.webkit.org/show_bug.cgi?id=53235

Single protocol breakpoint (e.g. set by url) is mapped on zero or more VM breakpoints (set by sourceID).
removeJavaScriptBreakpoint(breakpointId) removes breakpoint and all linked VM breakpoints.
Since UI uses VM breakpoint location rather then protocol breakpoint location, all resolved breakpoints locations are passed to frontend.

SourceFrame is now aware of whether breakpoint is resolved or not and may display it accordingly.
JavaScriptBreakpointsSidebarPane filters out breakpoints set on nonexistent scripts to avoid UI cluttering.

  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setBreakpoint): (WebCore::ScriptDebugServer::removeBreakpoint):
  • bindings/js/ScriptDebugServer.h:
  • bindings/v8/DebuggerScript.js: ():
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setBreakpoint):
  • bindings/v8/ScriptDebugServer.h:
  • inspector/Inspector.idl:
  • inspector/InspectorAgent.cpp: clear breakpoints from inspector state when new frontend is created (WebCore::InspectorAgent::restoreInspectorStateFromCookie): (WebCore::InspectorAgent::populateScriptObjects): (WebCore::InspectorAgent::restoreDebugger): (WebCore::InspectorAgent::showAndEnableDebugger): (WebCore::InspectorAgent::enableDebugger):
  • inspector/InspectorAgent.h:
  • inspector/InspectorDebuggerAgent.cpp: manage relations between protocol breakpoints and VM breakpoints (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::inspectedURLChanged): (WebCore::InspectorDebuggerAgent::setJavaScriptBreakpoint): (WebCore::InspectorDebuggerAgent::setJavaScriptBreakpointBySourceId): (WebCore::InspectorDebuggerAgent::removeJavaScriptBreakpoint): (WebCore::InspectorDebuggerAgent::continueToLocation): (WebCore::InspectorDebuggerAgent::resolveBreakpoint): (WebCore::InspectorDebuggerAgent::getScriptSource): (WebCore::InspectorDebuggerAgent::didParseSource): (WebCore::InspectorDebuggerAgent::didPause):
  • inspector/InspectorDebuggerAgent.h: (WebCore::InspectorDebuggerAgent::Script::Script):
  • inspector/InspectorValues.cpp: (WebCore::InspectorValue::asNumber): (WebCore::InspectorBasicValue::asNumber): (WebCore::InspectorObject::remove):
  • inspector/InspectorValues.h: (WebCore::InspectorObject::getNumber): (WebCore::InspectorObject::find):
  • inspector/ScriptBreakpoint.h: (WebCore::ScriptBreakpoint::ScriptBreakpoint):
  • inspector/front-end/Breakpoint.js: (WebInspector.Breakpoint): (WebInspector.Breakpoint.prototype.addLocation):
  • inspector/front-end/BreakpointManager.js: remove all stuff related to JavaScript breakpoints from here (WebInspector.BreakpointManager): (WebInspector.BreakpointManager.prototype._projectChanged): (WebInspector.BreakpointManager.prototype._saveBreakpoints): (WebInspector.BreakpointManager.prototype._validateBreakpoints):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.JavaScriptBreakpointsSidebarPane): filter breakpoints set on nonexistent scripts to avoid ui cluttering
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel): pull all JavaScript from localStorage and push them to fronted when debugger is enabled, save resolved breakpoints data
  • inspector/front-end/Script.js: (WebInspector.Script.prototype.sourceLine):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._toggleDebugging):
  • inspector/front-end/Settings.js: (WebInspector.Settings):
  • inspector/front-end/SourceFrame.js: handle resolved and unresolved breakpoints differently
  • inspector/front-end/inspector.js:

2011-02-01 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: introduce new api for managing JavaScript breakpoints.
https://bugs.webkit.org/show_bug.cgi?id=53235

  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgent::shouldInterruptForMessage):
7:22 AM Changeset in webkit [77488] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-02-03 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip flaky websocket tests on GTK
https://bugs.webkit.org/show_bug.cgi?id=53683

  • platform/gtk/Skipped:
7:15 AM Changeset in webkit [77487] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-03 Alexander Pavlov <apavlov@chromium.org>

Unreviewed, fix build after r77478.

  • inspector/styles-source-lines-inline.html: Roll back inadvertent function rename.
6:57 AM Changeset in webkit [77486] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-02-03 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip flaky test
fast/frames/sandboxed-iframe-scripting.html on GTK
https://bugs.webkit.org/show_bug.cgi?id=53680

  • platform/gtk/Skipped:
6:46 AM Changeset in webkit [77485] by Nikolas Zimmermann
  • 366 edits
    181 adds in trunk

2011-02-03 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

small text which is scaled to be large renders pixelated
https://bugs.webkit.org/show_bug.cgi?id=12448

SVG <text> with font-size smaller or equal to 1 does not paint correctly
https://bugs.webkit.org/show_bug.cgi?id=14242

misplaced text in SVG
https://bugs.webkit.org/show_bug.cgi?id=17053

Don't render very small (but zoomed) text inside SVG
https://bugs.webkit.org/show_bug.cgi?id=19393

Tiny fonts scaled up end up too large in Safari
https://bugs.webkit.org/show_bug.cgi?id=20192

Stretched SVG Text has awful glyph spacing
https://bugs.webkit.org/show_bug.cgi?id=21774

REGRESSION (r72141?): svg/batik/text/smallFonts.svg failing on Leopard
https://bugs.webkit.org/show_bug.cgi?id=49846

[Gtk] Text height in zoomed SVG is 1px too high
https://bugs.webkit.org/show_bug.cgi?id=50313

SVG text smaller than 0.5px not displayed properly
https://bugs.webkit.org/show_bug.cgi?id=50528

When rendering text, we're selecting a font with a size, as specified in the markup.
This can lead to problems, if the context, where the text is rendered upon, is scaled. If a parent
element of the <text> defines a transform=".." or the outermost <svg> containing a viewBox the
problem becomes apparent.

Consider following two snippets, which should render exactly the same:
<svg viewBox="0 0 100 100"><text x="25" y="50" font-size="25">test</text></svg>
<svg viewBox="0 0 1 1"><text x="0.25" y="0.5" font-size="0.25">test</text></svg>

When selecting a font size below 0.5, FontCacheMac would request a font with size 0,
which AppKit turns into 12. This lead to huge text rendering, instead of small text on Mac.
Other platforms have different problems (Qt simply scales the font, leading to pixelation etc.)

To fix this in a cross-platform fashion, we now always compute the final font size on screen,
remove any scaling from the context, draw the text using the scaled font size, then reapply
the context scale. This makes the example snippets above render exactly the same and fixes
numerous of bugs, present since years. As we're now heavily using floating-point font sizes
internally, depending on the scale of the document, it's very important to use the new
floating-point text metrics information (floatAscent/floatDescent/floatHeight) everywhere in SVG.

Fixes existing tests: css3/zoom-coords.xhtml (cross-platform inconsistencies should be gone, mac now reports floatHeight values for SVG text height)

svg/hixie/text/003.html (no more pixelation)
svg/batik/text/smallFonts.svg (small fonts aren't rendered huge anymore on mac)
svg/hixie/viewbox/preserveAspectRatio/001.xml (bug 21774, no more awful spacing)
svg/zoom/page/zoom-zoom-coords.xhtml (cross-platform inconsistencies should be gone, inspired by bug 50313)

Tests: svg/text/font-size-below-point-five-2.svg (reduction from bug 50528)

svg/text/font-size-below-point-five.svg (reduction from bug 50528)
svg/text/scaled-font.svg (reduction from bug 12448)
svg/text/small-fonts-2.svg (reduction from bug 14242)
svg/text/small-fonts-3.svg (reduction from bug 17053)
svg/text/small-fonts-in-html5.html (reduction from bug 19393)
svg/text/small-fonts.svg (reduction from bug 20192))

  • rendering/svg/RenderSVGInlineText.cpp: Cache 'float scalingFactor' & 'Font scaledFont', whenever the on-screen representation changes.
  • rendering/svg/RenderSVGInlineText.h:
  • rendering/svg/RenderSVGText.cpp: Update scalingFactor/scaledFont, if necessary.
  • rendering/svg/SVGInlineTextBox.cpp: Switch to new font rendering strategy. Always use scaledFont, and remove any context scale before drawing.
  • rendering/svg/SVGInlineTextBox.h:
  • rendering/svg/SVGTextLayoutEngineBaseline.cpp: Use floating-point metrics everywhere.
  • rendering/svg/SVGTextMetrics.cpp: Ditto.
  • rendering/svg/SVGTextMetrics.h: Ditto.
  • rendering/svg/SVGTextQuery.cpp: Ditto.
  • svg/SVGFont.cpp: Adjust stroke thickness, when drawing SVGFonts into a normalized context (no more scale).
  • svg/SVGTextContentElement.cpp: Make <text> elements always dependant on window size changes in combination with viewBox set.
  • svg/SVGTextPositioningElement.cpp: Remove now unnecessary code to determine wheter relative lengths are used as text attributes.
  • svg/SVGTextPositioningElement.h:

2011-02-03 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

small text which is scaled to be large renders pixelated
https://bugs.webkit.org/show_bug.cgi?id=12448

Update SVG test results after fixing small font size support. Land new mac/mac-leopard baseline, as text looks slightly different
in each testcase, as the font-size used for on-screen rendering has changed, this results in hinting differences, inter-glyph
space changes, etc. This commit only includes the textual result changes, the pixel test baseline will land in chunks in follow-up commits.

To those who have to rebaseline their platforms: Some of the svg/text pixel test results may look questionable on first sight,

  • svg/text/select-* tests: These tests render a certain string 'Foobar' and query the metrics using SVG Text DOM API (getExtentOfChar(firstChar) and getExtentOfChar(lastChar)). A red rectangle is drawn, to represent the size of the string, which gives precise results using floating-point accurancy. Using eventSender, a selection is simulated, by clicking the first char, holding down, and moving towards the last character. The blue selection rect which is drawn, should in theory be equal to the red rectangle. In practice it is not, as the selection rect is aligned to integer boundaries (see floor calls in Font::selectionRect...). Since we switched to use floating-point precision metrics, the actual drawn selection may exceed the red rectangle up to 1px.
  • svg/text/selection-(doubleclick|tripleclick).svg: These tests use DRTs dumpSelectionRect() which draws a red rectangle, highlighting the SelectionController::bounds() obtained through RenderView. In theory this red rectangle, should be equal to the drawn blue selection rect. Again it isn't, as the bounds() methods uses selectionRectForRepaint() of RenderText, which returns an enclosingIntRect of the actual selection. The drawn selection starts at y=0.93 in the first testcase, the selectionRectForRepaint() call returns an IntRect, which starts at y=0. That explains why the red rectangle starts slightly higher as it should be. Again this is no problem, the repaint rect may be 1px larger, if it would be smaller, we had a problem. The only way to fix this, would be to pass around FloatRect as repaint rects, but that's not worth it.
  • css3/zoom-coords.* / svg/zoom/page/zoom-zoom-coords*: These tests have different expectations now, as we're using the floatAscent/floatDesent/floatHeight FontMetrics methods instead of the integer variants ascent/descent/height - hopefully we'll see consistent results across platforms for these tests now, if not please comment in the bug report.
  • css3/zoom-coords-expected.txt:
  • css3/zoom-coords.xhtml:
  • platform/mac-leopard/Skipped:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.checksum: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.checksum: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt: Added.

...

6:38 AM Changeset in webkit [77484] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-03 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed.

BUGCR71783 : scrollbars/custom-scrollbar-with-incomplete-style.html = IMAGE
It is failing since r77459 by Sam Weinig.

  • platform/chromium/test_expectations.txt:
6:22 AM Changeset in webkit [77483] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip a new showModalDialog test on Windows

showModalDialog support is now covered by <http://webkit.org/b/53675>.

I also sorted some sputnik tests that fail when showModalDialog is unsupported, and filed a
new bug (<http://webkit.org/b/53676>) about those failures, since it seems like those tests
should pass even when showModalDialog is unsupported.

  • platform/win/Skipped:
6:22 AM Changeset in webkit [77482] by Adam Roben
  • 1 edit
    1 add in trunk/LayoutTests

Check in expected failure results for an RTL <select> test

The failure is covered by <http://webkit.org/b/53443>.

  • platform/win/fast/text/international/bidi-menulist-expected.txt: Added.
6:21 AM Changeset in webkit [77481] by Adam Roben
  • 1 edit
    3 adds in trunk/LayoutTests

Add Windows results for test added in r77153

  • platform/win/fast/text/international/text-combine-image-test-expected.checksum: Added.
  • platform/win/fast/text/international/text-combine-image-test-expected.png: Added.
  • platform/win/fast/text/international/text-combine-image-test-expected.txt: Added.
5:45 AM Changeset in webkit [77480] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-02-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: resources panel doesn't show frames after reload.
https://bugs.webkit.org/show_bug.cgi?id=53430

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.show): (WebInspector.ResourcesPanel.prototype.loadEventFired): (WebInspector.ResourcesPanel.prototype._initDefaultSelection): (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype.clear):
  • inspector/front-end/inspector.js: (WebInspector.loadEventFired):
5:43 AM Changeset in webkit [77479] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt]REGRESSION(r76951): media/controls-without-preload.html fails
https://bugs.webkit.org/show_bug.cgi?id=53674

  • platform/qt/Skipped: media/controls-without-preload.html added until fix.
5:06 AM WebKit Team edited by rgabor@webkit.org
(diff)
5:04 AM Changeset in webkit [77478] by apavlov@chromium.org
  • 12 edits in trunk

2011-02-01 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Remove the *2 suffix from the CSS style-related protocol methods
https://bugs.webkit.org/show_bug.cgi?id=53492

WebCore:

  • inspector/Inspector.idl:
  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getStylesForNode): (WebCore::InspectorCSSAgent::getInlineStyleForNode): (WebCore::InspectorCSSAgent::getComputedStyleForNode): (WebCore::InspectorCSSAgent::getAllStyles): (WebCore::InspectorCSSAgent::getStyleSheet): (WebCore::InspectorCSSAgent::getStyleSheetText): (WebCore::InspectorCSSAgent::setStyleSheetText): (WebCore::InspectorCSSAgent::setPropertyText): (WebCore::InspectorCSSAgent::toggleProperty): (WebCore::InspectorCSSAgent::setRuleSelector): (WebCore::InspectorCSSAgent::addRule):
  • inspector/InspectorCSSAgent.h:
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype.getStylesAsync): (WebInspector.CSSStyleModel.prototype.getComputedStyleAsync): (WebInspector.CSSStyleModel.prototype.getInlineStyleAsync): (WebInspector.CSSStyleModel.prototype.setRuleSelector): (WebInspector.CSSStyleModel.prototype.addRule): (WebInspector.CSSStyleModel.prototype._styleSheetChanged): (WebInspector.CSSStyleModel.prototype._onRevert): (WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt): (WebInspector.CSSProperty.prototype.setText): (WebInspector.CSSProperty.prototype.setDisabled): (WebInspector.CSSStyleSheet.createForId): (WebInspector.CSSStyleSheet.prototype.setText):

LayoutTests:

  • inspector/styles-iframe.html:
  • inspector/styles-new-API.html:
  • inspector/styles-source-lines-inline.html:
  • inspector/styles-source-lines.html:
  • inspector/styles-source-offsets.html:
4:52 AM Changeset in webkit [77477] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-02-03 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip flaky test
fast/files/workers/worker-read-blob-async.html on GTK
https://bugs.webkit.org/show_bug.cgi?id=53673

  • platform/gtk/Skipped:
4:36 AM Changeset in webkit [77476] by rgabor@webkit.org
  • 2 edits in trunk/Tools

Unreviewed.

Adding myself to committers.py.

  • Scripts/webkitpy/common/config/committers.py:
4:33 AM Changeset in webkit [77475] by Csaba Osztrogonác
  • 1 edit
    2 copies
    4 adds in trunk/LayoutTests

Unreviewed.

[Qt] fast/dynamic/unicode-bidi.html fails
https://bugs.webkit.org/show_bug.cgi?id=53456

Add Qt specific expected files.

  • platform/qt/fast/dynamic/unicode-bidi-expected.checksum: Added.
  • platform/qt/fast/dynamic/unicode-bidi-expected.png: Added.
  • platform/qt/fast/dynamic/unicode-bidi-expected.txt: Copied from LayoutTests/fast/dynamic/unicode-bidi-expected.txt.
  • platform/qt/fast/text/bidi-embedding-pop-and-push-same-2-expected.checksum: Added.
  • platform/qt/fast/text/bidi-embedding-pop-and-push-same-2-expected.png: Added.
  • platform/qt/fast/text/bidi-embedding-pop-and-push-same-2-expected.txt: Copied from LayoutTests/fast/text/bidi-embedding-pop-and-push-same-2-expected.txt.
4:04 AM Changeset in webkit [77474] by Philippe Normand
  • 1 edit
    2 adds in trunk/LayoutTests

2011-02-03 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK baselines for 2 new tests added in r77267 and r77153.

  • platform/gtk/fast/dom/34176-expected.txt: Added.
  • platform/gtk/fast/text/international/text-combine-image-test-expected.txt: Added.
3:09 AM Changeset in webkit [77473] by kbalazs@webkit.org
  • 2 edits in trunk/Tools

2011-02-03 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt][WK2] MiniBrowser's window size should be 800x600
https://bugs.webkit.org/show_bug.cgi?id=53670

Make layout test failure debugging easier.

  • MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::BrowserWindow):
1:41 AM Changeset in webkit [77472] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-02-03 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip failing test
fast/history/timed-refresh-in-cached-frame.html on GTK
https://bugs.webkit.org/show_bug.cgi?id=53667

  • platform/gtk/Skipped:
1:37 AM Changeset in webkit [77471] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-02-03 Maciej Stachowiak <mjs@apple.com>

Reviewed by Ryosuke Niwa.

Skip some tests that fail in WebKit2 due to missing DRT functionality
https://bugs.webkit.org/show_bug.cgi?id=53666

  • platform/mac-wk2/Skipped:
12:59 AM Changeset in webkit [77470] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2011-02-03 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

Teach XSSFilter about data URLs
https://bugs.webkit.org/show_bug.cgi?id=53662

Tests that the XSS filter doesn't block script in data URLs.

  • http/tests/security/xssAuditor/data-urls-work-expected.txt: Added.
  • http/tests/security/xssAuditor/data-urls-work.html: Added.

2011-02-03 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

Teach XSSFilter about data URLs
https://bugs.webkit.org/show_bug.cgi?id=53662

The XSS filter doesn't really make sense for data URLs because
everything in a "response" from a data URL was part of the request.

Test: http/tests/security/xssAuditor/data-urls-work.html

  • html/parser/XSSFilter.cpp: (WebCore::XSSFilter::init): (WebCore::XSSFilter::filterToken):
12:11 AM Changeset in webkit [77469] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

2011-02-03 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77449.
http://trac.webkit.org/changeset/77449
https://bugs.webkit.org/show_bug.cgi?id=53663

causes many WebKit2 tests to crash (Requested by othermaciej
on #webkit).

  • Shared/API/c/WKSharedAPICast.h: (WebKit::toAPI): (WebKit::toCopiedAPI): (WebKit::toURLRef): (WebKit::toCopiedURLAPI):
  • Shared/WebString.h: (WebKit::WebString::isNull): (WebKit::WebString::WebString):

Feb 2, 2011:

10:21 PM Changeset in webkit [77468] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-02-02 Chris Evans <cevans@chromium.org>

Reviewed by Darin Fisher.

window.find() can fail when switching case sensitivity
https://bugs.webkit.org/show_bug.cgi?id=53654

The test coverage for this area is very poor, so I took the liberty
of adding a more general test than is needed.

  • fast/text/find-window.html: Added.
  • fast/text/find-window-expected.txt: Added.

2011-02-02 Chris Evans <cevans@chromium.org>

Reviewed by Darin Fisher.

window.find() can fail when switching case sensitivity
https://bugs.webkit.org/show_bug.cgi?id=53654

Reset the pattern to a safe one when done, to avoid usearch_reset()
indirectly touching the old, stale text pointer.

Test: fast/text/find-window.html

  • editing/TextIterator.cpp: (WebCore::SearchBuffer::~SearchBuffer): leave a safe pattern buffer when done.
9:45 PM Changeset in webkit [77467] by abarth@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-02-02 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

Teach XSSFilter that <param> elements can contain URLs
https://bugs.webkit.org/show_bug.cgi?id=53652

When loading plugins for the <object> tag, we're "smart" enough to
reach into the <param> elements and pull out the URL in some cases.
This patch teaches the XSSFilter how to block injections into those
sorts of param elements.

Fixes:

http/tests/security/xssAuditor/object-*

  • html/HTMLParamElement.cpp: (WebCore::HTMLParamElement::isURLParameter): (WebCore::HTMLParamElement::isURLAttribute): (WebCore::HTMLParamElement::addSubresourceAttributeURLs):
  • html/HTMLParamElement.h:
    • Add a helper function so that HTMLParamElement can share the ground truth for these names with the XSSFilter.
  • html/parser/XSSFilter.cpp: (WebCore::XSSFilter::filterTokenInitial): (WebCore::XSSFilter::filterParamToken):
  • html/parser/XSSFilter.h:
9:41 PM Changeset in webkit [77466] by weinig@apple.com
  • 6 edits in trunk/Source/WebKit2

Fix license block issues pointed out by Daniel Bates.

  • Shared/API/c/WKGraphicsContext.cpp:
  • Shared/API/c/WKGraphicsContext.h:
  • Shared/API/c/cg/WKGraphicsContextCG.cpp:
  • Shared/API/c/cg/WKGraphicsContextCG.h:
  • Shared/WebGraphicsContext.cpp:
9:17 PM Changeset in webkit [77465] by mrobinson@webkit.org
  • 3 edits
    1 delete in trunk/LayoutTests

2011-02-02 Martin Robinson <mrobinson@igalia.com>

Rebaseline two tests after import of editing test results for GTK+.
Also remove a platform-specific baseline for a test which is now passing.

  • platform/gtk/editing/pasteboard/emacs-ctrl-a-k-y-expected.txt:
  • platform/gtk/editing/selection/find-yensign-and-backslash-expected.txt: Removed.
  • platform/gtk/fast/dom/52776-expected.txt:
8:40 PM Changeset in webkit [77464] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

2011-02-02 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by David Levin.

GCC compiler on ARM issues bogus warnings and fails to compile.
https://bugs.webkit.org/show_bug.cgi?id=53620

Despite warnings explicitly being disallowed (-Wno-uninitialized),
gcc (Ubuntu 4.4.3-4ubuntu5) 4.4.3 throws up the warnings like:

"error: 'colorTransparent.unstatic.4909' may be used uninitialized in this function"

The fix is to add an extra condition, which somehow pacifies the compiler.

  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::createColor): Added workaround conditions.
8:35 PM Changeset in webkit [77463] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-02 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

Teach XSSFilter about X-XSS-Protection
https://bugs.webkit.org/show_bug.cgi?id=53640

This patch causes us to pass:

http/tests/security/xssAuditor/full-block-*
http/tests/security/xssAuditor/no-protection-script-tag.html

  • html/parser/XSSFilter.cpp: (WebCore::XSSFilter::XSSFilter): (WebCore::XSSFilter::init): (WebCore::XSSFilter::filterToken):
  • html/parser/XSSFilter.h:
8:23 PM Changeset in webkit [77462] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-02 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

When XSSFilter blocks JavaScript URLs, use a safe JavaScript URL
instead of the empty string
https://bugs.webkit.org/show_bug.cgi?id=53643

In a URL context, the empty string completes to the URL of the current
page, which causes these tests to go into an infinite loop. Instead,
we should use a "safe" JavaScript URL that does nothing.

Fixes:

http/tests/security/xssAuditor/javascript-link*

  • html/parser/XSSFilter.cpp: (WebCore::XSSFilter::eraseDangerousAttributesIfInjected):
8:13 PM Changeset in webkit [77461] by mitz@apple.com
  • 3 edits
    4 adds in trunk

<rdar://problem/8380506> REGRESSION (r61921): RTL text in <b> tag doesn't display in WebKit under certain conditions
https://bugs.webkit.org/show_bug.cgi?id=44942

Reviewed by Sam Weinig.

Source/WebCore:

Test: fast/text/bidi-embedding-pop-and-push-same-2.html

  • platform/text/BidiResolver.h:

(WebCore::::commitExplicitEmbedding): Changed to return a boolean indicating whether there was
a change to embedding levels.
(WebCore::::createBidiRunsForLine): If embedding levels did not change as a result of committing
the explicit embedding sequence, then runs were not added, and we should continue normally.

LayoutTests:

  • fast/text/bidi-embedding-pop-and-push-same-2-expected.checksum: Added.
  • fast/text/bidi-embedding-pop-and-push-same-2-expected.png: Added.
  • fast/text/bidi-embedding-pop-and-push-same-2-expected.txt: Added.
  • fast/text/bidi-embedding-pop-and-push-same-2.html: Added.
7:46 PM Changeset in webkit [77460] by weinig@apple.com
  • 5 edits in trunk/Source/WebKit2

Add WKBundleFrameGetVisibleContentBoundsExcludingScrollbars API for WebKit2.

Reviewed by Dan Bernstein.

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameGetContentBounds):
(WKBundleFrameGetVisibleContentBounds):
(WKBundleFrameGetVisibleContentBoundsExcludingScrollbars):
(WKBundleFrameGetScrollOffset):

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::contentBounds):
(WebKit::WebFrame::visibleContentBounds):
(WebKit::WebFrame::visibleContentBoundsExcludingScrollbars):
(WebKit::WebFrame::scrollOffset):

  • WebProcess/WebPage/WebFrame.h:

Move implementation of frame geometry to the implementation file
instead of keeping it in the API file.

7:45 PM Changeset in webkit [77459] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix miscalculation of the overhang area used for painting. We were
not correctly accounting for scrollbars resulting in an non-negative
overhang even when we weren't over the edge.

Reviewed by Dan Bernstein.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::calculateOverhangAreasForPainting):

7:01 PM Changeset in webkit [77458] by kbr@google.com
  • 3 edits in trunk/LayoutTests

2011-02-02 Kenneth Russell <kbr@google.com>

Reviewed by Mihai Parparita.

gl-teximage.html failing on some WebKit bots
https://bugs.webkit.org/show_bug.cgi?id=53633

  • fast/canvas/webgl/gl-teximage.html:
    • Synced with upstream test; detect when running in DRT and avoid printing the specific pixel value when the test will pass.
  • fast/canvas/webgl/resources/red-indexed.png:
    • Stripped gamma and other colorspace information.
6:39 PM Changeset in webkit [77457] by aestes@apple.com
  • 2 edits in trunk/Tools

'update-webkit' should handle OpenSource and Internal using different
VCSs.

Reviewed by Mark Rowe.

  • Scripts/update-webkit: Re-check the VCS type when updating Apple's

Internal directory.

6:24 PM Changeset in webkit [77456] by jorlow@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-02-02 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

IDBTransaction and IDBRequest can be deleted while ScriptExecutionContext is iterating....which is bad
https://bugs.webkit.org/show_bug.cgi?id=52722

The solution is to change ScriptExecutionContext's destructor to iterate over
the list in a way that handles the mutations. This new method is destructive,
but that's OK since the object is going away. I've also added a several asserts.

There should be no behavior change.

  • dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::ScriptExecutionContext): (WebCore::ScriptExecutionContext::~ScriptExecutionContext): (WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects): (WebCore::ScriptExecutionContext::suspendActiveDOMObjects): (WebCore::ScriptExecutionContext::resumeActiveDOMObjects): (WebCore::ScriptExecutionContext::stopActiveDOMObjects): (WebCore::ScriptExecutionContext::createdActiveDOMObject): (WebCore::ScriptExecutionContext::destroyedActiveDOMObject):
  • dom/ScriptExecutionContext.h:
  • storage/IDBTransaction.cpp: (WebCore::IDBTransaction::contextDestroyed):
  • storage/IDBTransaction.h:
6:11 PM Changeset in webkit [77455] by mrowe@apple.com
  • 3 edits in trunk/Source/WebCore

Build fix.

  • WebCore.exp.in: Remove some bogus symbols from the .exp.in file.
  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::unregisterScrollbar): Look the object
up in the HashMap rather than relying on a local variable that doesn't
exist.

6:04 PM Changeset in webkit [77454] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-02 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

Teach XSSFilter about JavaScript URLs
https://bugs.webkit.org/show_bug.cgi?id=53635

This patch teaches the XSSFilter to check for JavaScript URLs in
attribute values. If this approach has too many false positives, we
can restrict which attribute names we examine.

Fixes these tests:

http/tests/security/xssAuditor/anchor-url-dom-write-location-javascript-URL.html
http/tests/security/xssAuditor/dom-write-location-javascript-URL.html
http/tests/security/xssAuditor/iframe-javascript-url*

  • html/parser/XSSFilter.cpp: (WebCore::HTMLNames::containsJavaScriptURL): (WebCore::XSSFilter::filterTokenInitial): (WebCore::XSSFilter::eraseDangerousAttributesIfInjected):
  • html/parser/XSSFilter.h:
6:00 PM Changeset in webkit [77453] by mrobinson@webkit.org
  • 2 edits
    277 adds in trunk/LayoutTests

2011-02-02 Martin Robinson <mrobinson@igalia.com>

Unskip the last batch of editing tests needing GTK+ results.

  • platform/gtk/Skipped: Unskip last batch of tests.
5:58 PM Changeset in webkit [77452] by Stephanie Lewis
  • 2 edits in trunk/Source/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=53361
<rdar://problem/8921729> REGRESSION: Membuster accumulates 1GB+ memory due to autorelease
pools not being drained.
Call into AppKit to add observers that push and pop autorelease pools on entry
and exit from the CFRunLoop. This will prevent memory from accumulating.

Reviewed by Geoff Garen.

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain):

5:55 PM Changeset in webkit [77451] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):

5:54 PM Changeset in webkit [77450] by mrobinson@webkit.org
  • 2 edits
    290 adds in trunk/LayoutTests

2011-02-02 Martin Robinson <mrobinson@igalia.com>

Add one more set of missing editing layout test results for GTK.

  • platform/gtk/Skipped: Unskip more editing tests.
5:51 PM Changeset in webkit [77449] by Darin Adler
  • 3 edits in trunk/Source/WebKit2

Make null WTF::String objects turn into 0 pointers for WKStringRef and WKURLRef.
rdar://problem/8948688

Reviewed by Sam Weinig.

  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toAPI): Return 0 if the passed in string is 0.
(WebKit::toCopiedAPI): Ditto.
(WebKit::toURLRef): Ditto. Old code was trying to do this but was missing a return.
(WebKit::toCopiedURLAPI): Ditto. Old code was trying to do this but had incorrect
nll check.

  • Shared/WebString.h: Removed isNull function. It can never return true.

Removed constructor code that turns the null string into the empty string.
Instead assert that the passed in string is not null.

5:48 PM Changeset in webkit [77448] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix.

5:36 PM Changeset in webkit [77447] by mrowe@apple.com
  • 4 edits in trunk/Source

<rdar://problem/8928367> Crash when loading canvas pages inside HTMLCanvasElement::createImageBuffer().

Reviewed by Beth Dakin.

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Add some missing initializers.

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Add some missing initializers.

5:36 PM Changeset in webkit [77446] by mrowe@apple.com
  • 3 edits in trunk/Source/WebCore

<rdar://problem/8952012> Crash on launch inside scrollbar code.

Reviewed by Beth Dakin.

We need to ensure that we remove ourselves as the delegates of objects when we're going
away as failing to do this can lead to crashes if the lifetime of the other objects
is longer than ours.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):

  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::unregisterScrollbar):

5:36 PM Changeset in webkit [77445] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

oops, build fix!

  • wtf/Assertions.cpp:
5:35 PM Changeset in webkit [77444] by mrobinson@webkit.org
  • 2 edits
    288 adds in trunk/LayoutTests

2011-02-02 Martin Robinson <mrobinson@igalia.com>

Continue importing new editing layout test results for GTK.

  • platform/gtk/Skipped: Unskip more editing tests.
5:31 PM Changeset in webkit [77443] by barraclough@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Bug 53650 - Add a BACKTRACE macro to Assertions.h

Reviewed by Sam Weinig.

Add a BACKTRACE macro to Assertions.h, which will print a backtrace on
debug Mac builds, make CRASH (and thus ASSERT) automatically call this.

5:29 PM Changeset in webkit [77442] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

Build fix.

  • WebCore.exp.in:
5:22 PM Changeset in webkit [77441] by alex
  • 1 copy in releases/WebKitGTK/webkit-1.3.11

Add 1.3.11 WebKitGTK+ release

5:20 PM Changeset in webkit [77440] by mrobinson@webkit.org
  • 2 edits
    283 adds in trunk/LayoutTests

2011-02-02 Martin Robinson <mrobinson@igalia.com>

Begin importing missing editing directory test results.

  • platform/gtk/Skipped: Unskip tests with results and classify failures.
5:17 PM Changeset in webkit [77439] by msaboff@apple.com
  • 5 edits in trunk

2011-02-02 Michael Saboff <msaboff@apple.com>

Reviewed by Gavin Barraclough.

Improper backtrack of nested non-capturing greedy paren to prior paren
https://bugs.webkit.org/show_bug.cgi?id=53261

A paren that follows a non-capturing greedy paren nested within a
non-capturing fixed paren was back tracking to the last paren
processed instead of the immediately prior paren.
Refactored default backtracking of parens to prior paren to work for
both nested (within) and immediately prior (after) parens.

  • yarr/YarrJIT.cpp: (JSC::Yarr::YarrGenerator::GenerationState::addParenthesesTail): (JSC::Yarr::YarrGenerator::TermGenerationState::TermGenerationState): (JSC::Yarr::YarrGenerator::TermGenerationState::setJumpListToPriorParen): (JSC::Yarr::YarrGenerator::TermGenerationState::getJumpListToPriorParen): (JSC::Yarr::YarrGenerator::ParenthesesTail::ParenthesesTail): (JSC::Yarr::YarrGenerator::ParenthesesTail::generateCode): (JSC::Yarr::YarrGenerator::generateParenthesesDisjunction): (JSC::Yarr::YarrGenerator::generateParenthesesSingle): (JSC::Yarr::YarrGenerator::generateDisjunction):

2011-02-02 Michael Saboff <msaboff@apple.com>

Reviewed by Gavin Barraclough.

Improper backtrack of nested non-capturing greedy paren to prior paren
https://bugs.webkit.org/show_bug.cgi?id=53261

New tests to validate change.

  • fast/regex/parentheses-expected.txt:
  • fast/regex/script-tests/parentheses.js:
5:14 PM Changeset in webkit [77438] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-02-02 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE build fix for r77397.

  • page/wince/FrameWinCE.cpp: (WebCore::computePageRectsForFrame):
5:04 PM Changeset in webkit [77437] by Patrick Gansterer
  • 6 edits in trunk/Source

2011-02-02 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE build fix for r77398.

  • platform/graphics/wince/PlatformPathWinCE.cpp: (WebCore::containsPoint): (WebCore::inflateRectToContainPoint): (WebCore::PlatformPath::addRect):
  • platform/graphics/wince/SharedBitmap.cpp: (WebCore::SharedBitmap::drawPattern):
  • rendering/RenderThemeWinCE.cpp: (WebCore::RenderThemeWinCE::paintMenuListButton): (WebCore::RenderThemeWinCE::paintSearchFieldCancelButton): (WebCore::RenderThemeWinCE::paintSliderTrack): (WebCore::RenderThemeWinCE::paintMediaMuteButton): (WebCore::RenderThemeWinCE::paintMediaPlayButton): (WebCore::RenderThemeWinCE::paintMediaSeekBackButton): (WebCore::RenderThemeWinCE::paintMediaSeekForwardButton):

2011-02-02 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE build fix for r77398.

  • WebView.cpp: (WebView::paint):
4:55 PM Changeset in webkit [77436] by eric@webkit.org
  • 2 edits in trunk/PerformanceTests/Parser

2011-02-02 Eric Seidel <eric@webkit.org>

Unreviewed. Just fixing an exception seen in Firefox.

HTML5 TreeBuilder regressed a Peacekeeper DOM test by 40%
https://bugs.webkit.org/show_bug.cgi?id=48719

Make the benchmarks work in Firefox/Opera.

  • resources/runner.js: (log):
4:55 PM Changeset in webkit [77435] by evan@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-02 Evan Martin <evan@chromium.org>

Unreviewed, DEPS change.

  • DEPS: update to pick up newer Skia.
4:52 PM Changeset in webkit [77434] by dpranke@chromium.org
  • 6 edits in trunk

2011-02-02 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

new-run-webkit-tests: hardcode the directories to scan for tests
for GPU bots instead of SKIPping them. See bug 53562 for some
context, but we will now hard-code the list of directories to
use by default instead of skipping over directories in the
expectations file. We do this so that we will be able to merge
the expectations files without getting conflicting SKIP
directives. Note that this change will reduce the # of tests
being run on the Mac GPU bots, because we're accidentally
including some today.

https://bugs.webkit.org/show_bug.cgi?id=53631

  • platform/chromium-gpu/test_expectations.txt:

2011-02-02 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

new-run-webkit-tests: hardcode the directories to scan for tests
for GPU bots instead of SKIPping them. See bug 53562 for some
context, but we will now hard-code the list of directories to
use by default instead of skipping over directories in the
expectations file. We do this so that we will be able to merge
the expectations files without getting conflicting SKIP
directives. Note that this change will reduce the # of tests
being run on the Mac GPU bots, because we're accidentally
including some today.

https://bugs.webkit.org/show_bug.cgi?id=53631

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
4:52 PM Changeset in webkit [77433] by jianli@chromium.org
  • 5 edits in trunk

[V8] Accessing DataView with index of -1 returns 0, doesn't throw
https://bugs.webkit.org/show_bug.cgi?id=53559

Reviewed by Kenneth Russell.

Source/WebCore:

Added test cases to cover this in fast/canvas/webgl/data-view-test.html.

  • html/canvas/DataView.h:

(WebCore::DataView::beyondRange):

LayoutTests:

  • fast/canvas/webgl/data-view-test-expected.txt:
  • fast/canvas/webgl/data-view-test.html:
4:44 PM Changeset in webkit [77432] by weinig@apple.com
  • 23 edits
    6 adds in trunk

Add ChromeClient function to paint custom overhang areas.
https://bugs.webkit.org/show_bug.cgi?id=53639

Reviewed by Beth Dakin.

Source/WebCore:

  • page/Chrome.cpp:

(WebCore::ChromeClient::paintCustomOverhangArea):

  • page/ChromeClient.h:

Add ChromeClient function.

  • page/FrameView.cpp:

(WebCore::FrameView::paintOverhangAreas):

  • page/FrameView.h:

Call out the the ChromeClient, call ScrollView base implementation
if the ChromeClient returns false.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::paintOverhangAreas):

  • platform/ScrollView.h:

Add dirty rect for use when painting overhang areas.

Source/WebKit2:

  • Shared/API/c/WKBase.h:
  • Shared/API/c/WKGraphicsContext.cpp: Added.

(WKGraphicsContextGetTypeID):

  • Shared/API/c/WKGraphicsContext.h: Added.
  • Shared/API/c/WKSharedAPICast.h:
  • Shared/API/c/cg/WKGraphicsContextCG.cpp: Added.

(WKGraphicsContextGetCGContext):

  • Shared/API/c/cg/WKGraphicsContextCG.h: Added.
  • Shared/APIObject.h:
  • Shared/WebGraphicsContext.cpp: Added.

(WebKit::WebGraphicsContext::WebGraphicsContext):

  • Shared/WebGraphicsContext.h: Added.

(WebKit::WebGraphicsContext::create):
(WebKit::WebGraphicsContext::platformContext):
(WebKit::WebGraphicsContext::type):
Add WebGraphicsContext API type.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::pageDidScroll):
(WebKit::InjectedBundlePageUIClient::shouldPaintCustomOverhangArea):
(WebKit::InjectedBundlePageUIClient::paintCustomOverhangArea):

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::paintCustomOverhangArea):

  • WebProcess/WebCoreSupport/WebChromeClient.h:

Pipe paintCustomOverhangArea to the InjectedBundlePageUIClient.

  • UIProcess/API/C/WebKit2.h:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:

Add new files.

Tools:

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):
Stub out new callback.

4:33 PM Changeset in webkit [77431] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-02-02 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: support chromium code paths in mock_drt

https://bugs.webkit.org/show_bug.cgi?id=53471

  • Scripts/webkitpy/layout_tests/port/mock_drt.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
4:16 PM Changeset in webkit [77430] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Work towards making the layer tree host be in charge of all painting
https://bugs.webkit.org/show_bug.cgi?id=53636

Make sure that DrawingAreaImpl::display is never called when in accelerated compositing mode,
since the layer tree host is supposed to handle all drawing in that case.

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::scroll): (WebKit::DrawingAreaImpl::setRootCompositingLayer): (WebKit::DrawingAreaImpl::setSize): (WebKit::DrawingAreaImpl::didUpdate):
3:58 PM Changeset in webkit [77429] by pkasting@chromium.org
  • 7 edits in trunk/Source/WebCore

Not reviewed, build fix.

Fix compile after r77427.
https://bugs.webkit.org/show_bug.cgi?id=53455

  • platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoderQt::internalHandleCurrentImage):

  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageFrame::operator=):

  • platform/image-decoders/bmp/BMPImageReader.cpp:

(WebCore::BMPImageReader::decodeBMP):

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::JPEGImageDecoder::outputScanlines):

  • platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageDecoder::rowAvailable):

  • platform/image-decoders/webp/WEBPImageDecoder.cpp:

(WebCore::WEBPImageDecoder::decode):

3:39 PM Changeset in webkit [77428] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix the 32-bit build.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::computeFakeWindowBoundsRect):

3:34 PM Changeset in webkit [77427] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebCore

2011-02-02 Peter Kasting <pkasting@google.com>

Reviewed by David Levin.

Clean up ImageDecoder's comments (remove/trim/clarify).
https://bugs.webkit.org/show_bug.cgi?id=53455

This also renames or eliminates a couple of functions for clarity, and
switches a couple erroneous strncmp() calls to memcmp().

  • platform/image-decoders/ImageDecoder.cpp: (WebCore::ImageDecoder::create): (WebCore::ImageFrame::clearPixelData): (WebCore::ImageFrame::zeroFillPixelData): (WebCore::ImageFrame::setSize):
  • platform/image-decoders/ImageDecoder.h: (WebCore::ImageFrame::originalFrameRect): (WebCore::ImageFrame::setOriginalFrameRect): (WebCore::ImageDecoder::ImageDecoder): (WebCore::ImageDecoder::~ImageDecoder): (WebCore::ImageDecoder::isSizeAvailable): (WebCore::ImageDecoder::size): (WebCore::ImageDecoder::setIgnoreGammaAndColorProfile): (WebCore::ImageDecoder::clearFrameBufferCache): (WebCore::ImageDecoder::isOverSize):
  • platform/image-decoders/bmp/BMPImageReader.cpp: (WebCore::BMPImageReader::processNonRLEData):
  • platform/image-decoders/cg/ImageDecoderCG.cpp: (WebCore::ImageFrame::setSize):
  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::clearFrameBufferCache): (WebCore::GIFImageDecoder::frameComplete): (WebCore::GIFImageDecoder::initFrameBuffer):
  • platform/image-decoders/jpeg/JPEGImageDecoder.h:
  • platform/image-decoders/qt/ImageFrameQt.cpp: (WebCore::ImageFrame::operator=): (WebCore::ImageFrame::clearPixelData): (WebCore::ImageFrame::zeroFillPixelData): (WebCore::ImageFrame::setSize):
  • platform/image-decoders/skia/ImageDecoderSkia.cpp: (WebCore::ImageFrame::operator=): (WebCore::ImageFrame::clearPixelData): (WebCore::ImageFrame::zeroFillPixelData): (WebCore::ImageFrame::setSize):
  • platform/image-decoders/webp/WEBPImageDecoder.h:
3:32 PM Changeset in webkit [77426] by eric@webkit.org
  • 1 edit
    1 add in trunk/PerformanceTests/Parser

2011-01-27 Eric Seidel <eric@webkit.org>

Reviewed by Darin Adler.

HTML5 TreeBuilder regressed a Peacekeeper DOM test by 40%
https://bugs.webkit.org/show_bug.cgi?id=48719

It's unclear exactly what the Peacekeeper benchmark is testing,
because I haven't found a way to run it myself.

However, I constructed a benchmark which shows at least one possible slow point.
The HTML5 spec talks about creating a new document for every time we use
the fragment parsing algorithm. Document() it turns out, it a huge bloated
mess, and the constructor and destructor do a huge amount of work.

  • benchmarks/parser/tiny-innerHTML.html: Added.
3:08 PM Changeset in webkit [77425] by vangelis@chromium.org
  • 8 edits in trunk/Source/WebCore

2011-02-02 Vangelis Kokkevis <vangelis@chromium.org>

[chromium] Adding support for reflections to the accelerated
compositing path.
https://bugs.webkit.org/show_bug.cgi?id=53179

All layout tests in compositing/reflections generate correct
results with the exception of:

  1. nested-reflection-anchor-point.html : There appears to be some issue with the layer transform math that I haven't been able to track down yet.
  2. reflection-opacity.html : The current implementation applies opacity before doing the reflection which makes this test produce incorrect results. This will affect reflected layers with opacity that overlap their original layer. FIXME comment added in the code.

Tests: Covered by existing layout tests in compositing/reflections.

Please see above for exceptions.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::setReplicatedByLayer): (WebCore::GraphicsLayerChromium::updateAnchorPoint):
  • platform/graphics/chromium/GraphicsLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::LayerChromium):
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::setReplicaLayer): (WebCore::LayerChromium::replicaLayer):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updateLayersRecursive): (WebCore::LayerRendererChromium::drawLayer):
  • platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::drawableContentRect): (WebCore::RenderSurfaceChromium::drawSurface): (WebCore::RenderSurfaceChromium::draw):
  • platform/graphics/chromium/RenderSurfaceChromium.h: (WebCore::RenderSurfaceChromium::drawTransform):
2:45 PM Changeset in webkit [77424] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-02 Xiyuan Xia <xiyuan@chromium.org>

Reviewed by Tony Chang.

[Chromium] Select popup with padding has white strip on right
https://bugs.webkit.org/show_bug.cgi?id=53602

No new tests as this change restores old behavior.

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::layout):
2:45 PM Changeset in webkit [77423] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Make sure that we don't try to call display() when in accelerated compositing mode
https://bugs.webkit.org/show_bug.cgi?id=53629

Reviewed by Sam Weinig.

When in accelerated compositing mode, the layer tree host should handle all painting, so make sure that display() is never called.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::setNeedsDisplay):
(WebKit::DrawingAreaImpl::setRootCompositingLayer):
(WebKit::DrawingAreaImpl::display):

2:43 PM Changeset in webkit [77422] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

Fix for <rdar://problem/8950343> CrashTracer: [USER]
1 crash in WebProcess at com.apple.WebCore:
WebCore::ScrollbarThemeMac::unregisterScrollbar + 22

Reviewed by Mark Rowe.

It is possible for a Scrollbar's ScrollableArea to be null,
so we must null check.

  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::unregisterScrollbar):

2:39 PM Changeset in webkit [77421] by zmo@google.com
  • 5 edits in trunk

2011-02-02 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

bufferData and bufferSubData should generate INVALID_VALUE with negative input
https://bugs.webkit.org/show_bug.cgi?id=53626

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::bufferData): (WebCore::WebGLRenderingContext::bufferSubData):

2011-02-02 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

bufferData and bufferSubData should generate INVALID_VALUE with negative input
https://bugs.webkit.org/show_bug.cgi?id=53626

  • fast/canvas/webgl/buffer-data-array-buffer-expected.txt:
  • fast/canvas/webgl/buffer-data-array-buffer.html:
2:34 PM Changeset in webkit [77420] by Adam Roben
  • 4 edits in trunk/Source

Add DerivedSources.make to some Visual Studio projects

https://bugs.webkit.org/show_bug.cgi?id=53607

Patch by Jeff Miller <jeffm@apple.com> on 2011-02-02
Reviewed by Darin Adler and Steve Falkenburg.

Source/JavaScriptCore:

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Add DerivedSources.make.

Source/WebCore:

  • WebCore.vcproj/WebCoreGenerated.vcproj: Add DerivedSources.make.
2:33 PM Changeset in webkit [77419] by Adam Roben
  • 4 edits in trunk/Source/WebKit2

Assert WebBackForwardList's current index is valid to help catch errors

Hopefully this will help catch a crash I saw once but haven't yet been able to reproduce.

Fixes <http://webkit.org/b/53622>.

Reviewed by Brady Eidson.

  • UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::WebBackForwardList):
(WebKit::WebBackForwardList::addItem):
(WebKit::WebBackForwardList::goToItem):
(WebKit::WebBackForwardList::currentItem):
(WebKit::WebBackForwardList::backItem):
(WebKit::WebBackForwardList::forwardItem):
(WebKit::WebBackForwardList::itemAtIndex):
(WebKit::WebBackForwardList::backListCount):
(WebKit::WebBackForwardList::forwardListCount):
(WebKit::WebBackForwardList::backListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::forwardListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::clear):

  • UIProcess/cf/WebBackForwardListCF.cpp:

(WebKit::WebBackForwardList::createCFDictionaryRepresentation):
(WebKit::WebBackForwardList::restoreFromCFDictionaryRepresentation):
Assert that m_current is valid.

  • UIProcess/WebBackForwardList.h: Moved the NoCurrentItemIndex to a static data member so

that it can be used from WebBackForwardListCF.cpp.

2:25 PM Changeset in webkit [77418] by inferno@chromium.org
  • 6 edits
    2 adds in trunk

2011-02-02 Cris Neckar <cdn@chromium.org>

Reviewed by James Robinson.

Tests for crash when a domwindow is removed within a device orientation event.
https://bugs.webkit.org/show_bug.cgi?id=53623

  • fast/events/device-orientation-crash-expected.txt: Added.
  • fast/events/device-orientation-crash.html: Added.

2011-02-02 Cris Neckar <cdn@chromium.org>

Reviewed by James Robinson.

Refcount domwindows when dispatching device orientation events.
https://bugs.webkit.org/show_bug.cgi?id=53623

Test: fast/events/device-orientation-crash.html

  • dom/DeviceMotionController.cpp: (WebCore::DeviceMotionController::timerFired): (WebCore::DeviceMotionController::didChangeDeviceMotion):
  • dom/DeviceMotionController.h:
  • dom/DeviceOrientationController.cpp: (WebCore::DeviceOrientationController::timerFired): (WebCore::DeviceOrientationController::didChangeDeviceOrientation):
  • dom/DeviceOrientationController.h:
2:13 PM Changeset in webkit [77417] by zmo@google.com
  • 7 edits in trunk

2011-02-02 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

A deleted object should never been bound again
https://bugs.webkit.org/show_bug.cgi?id=53604

  • fast/canvas/webgl/object-deletion-behaviour-expected.txt:
  • fast/canvas/webgl/object-deletion-behaviour.html: Add test cases for object binding and deletion.

2011-02-02 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

A deleted object should never been bound again
https://bugs.webkit.org/show_bug.cgi?id=53604

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::checkObjectToBeBound): Helper function to bind* and useProgram. (WebCore::WebGLRenderingContext::bindBuffer): Use checkObjectToBeBound. (WebCore::WebGLRenderingContext::bindFramebuffer): Ditto. (WebCore::WebGLRenderingContext::bindRenderbuffer): Ditto. (WebCore::WebGLRenderingContext::bindTexture): Ditto, also check the target matching. (WebCore::WebGLRenderingContext::deleteObject): Helper funtion to delete*. (WebCore::WebGLRenderingContext::deleteBuffer): Use deleteObject. (WebCore::WebGLRenderingContext::deleteFramebuffer): Ditto. (WebCore::WebGLRenderingContext::deleteProgram): Ditto. (WebCore::WebGLRenderingContext::deleteRenderbuffer): Ditto. (WebCore::WebGLRenderingContext::deleteShader): Ditto. (WebCore::WebGLRenderingContext::deleteTexture): Ditto. (WebCore::WebGLRenderingContext::useProgram): Use checkObjectToBeBound.
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLTexture.h: (WebCore::WebGLTexture::getTarget): Accessor to cached target.
2:06 PM Changeset in webkit [77416] by alex
  • 2 edits in trunk/Source/WebCore

2011-02-02 Alejandro G. Castro <alex@igalia.com>

Unreviewed Efl buildfix after r77399.

  • CMakeListsEfl.txt:
1:59 PM Changeset in webkit [77415] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-02-02 Adam Klein <adamk@chromium.org>

Reviewed by Tony Chang.

Update new-run-webkit-tests --chromium to put output under Source/...
https://bugs.webkit.org/show_bug.cgi?id=53612

  • BuildSlaveSupport/test-result-archive:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
1:49 PM Changeset in webkit [77414] by alex
  • 4 edits in trunk

2011-02-02 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

Update the NEWS file in preparation for the 1.3.11 release.

  • NEWS: Update the NEWS.

2011-02-02 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

Bump the WebKitGTK+ versions in preparation for development release.

  • configure.ac: Bump the library, libtool and user agent version.
1:49 PM Changeset in webkit [77413] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

The drawing area proxy should keep track of the accelerated compositing state
https://bugs.webkit.org/show_bug.cgi?id=53624

  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl): Initialize m_isInAcceleratedCompositingMode to false.

(WebKit::DrawingAreaProxyImpl::paint):
Don't try to paint if we're in accelerated compositing mode.

(WebKit::DrawingAreaProxyImpl::didSetSize):
Bail if we're in accelerated compositing mode.

(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
Set m_isInAcceleratedCompositingMode to true, null out the backing store.

(WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
Set m_isInAcceleratedCompositingMode back to false.

(WebKit::DrawingAreaProxyImpl::incorporateUpdate):
Assert that we're not in accelerated compositing mode.

  • UIProcess/DrawingAreaProxyImpl.h:
1:37 PM Changeset in webkit [77412] by kbr@google.com
  • 31 edits in trunk

2011-02-02 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

Rename Typed Array subset to subarray
https://bugs.webkit.org/show_bug.cgi?id=53618

  • fast/canvas/webgl/array-setters.html:
  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:
  • fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt:
  • fast/canvas/webgl/draw-elements-out-of-bounds.html:
  • fast/canvas/webgl/webgl-array-invalid-ranges-expected.txt:
  • fast/canvas/webgl/webgl-array-invalid-ranges.html:

2011-02-02 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

Rename Typed Array subset to subarray
https://bugs.webkit.org/show_bug.cgi?id=53618

  • html/canvas/Float32Array.cpp: (WebCore::Float32Array::subarray):
  • html/canvas/Float32Array.h:
  • html/canvas/Float32Array.idl:
  • html/canvas/Int16Array.cpp: (WebCore::Int16Array::subarray):
  • html/canvas/Int16Array.h:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.cpp: (WebCore::Int32Array::subarray):
  • html/canvas/Int32Array.h:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.cpp: (WebCore::Int8Array::subarray):
  • html/canvas/Int8Array.h:
  • html/canvas/Int8Array.idl:
  • html/canvas/TypedArrayBase.h: (WebCore::TypedArrayBase::subarrayImpl):
  • html/canvas/Uint16Array.cpp: (WebCore::Uint16Array::subarray):
  • html/canvas/Uint16Array.h:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.cpp: (WebCore::Uint32Array::subarray):
  • html/canvas/Uint32Array.h:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.cpp: (WebCore::Uint8Array::subarray):
  • html/canvas/Uint8Array.h:
  • html/canvas/Uint8Array.idl:
1:30 PM Changeset in webkit [77411] by abarth@webkit.org
  • 8 edits
    2 adds in trunk/Source/WebCore

2011-02-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add an empty file for Content Security Policy
https://bugs.webkit.org/show_bug.cgi?id=53573

Posting this as a separate patch because editing the build files is so
painful.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
1:23 PM Changeset in webkit [77410] by tony@chromium.org
  • 8 edits in trunk/Tools

2011-01-28 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

[chromium] remove --use-test-shell from NRWT
https://bugs.webkit.org/show_bug.cgi?id=53346

I've already started removing some of the bindings like eventSender so
this already doesn't work isn't useful. Also updated some comments to
refer to DRT instead of test_shell.

  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1:19 PM Changeset in webkit [77409] by timothy@apple.com
  • 2 edits in trunk/Source/WebKit2

Give the Web Process access to the Safari RSS preferences.

<rdar://problem/8916870> Sandbox violation related to RSS during initial
page load with WebKit2 (prevents RSS from working)

Reviewed by Darin Adler.

  • WebProcess/com.apple.WebProcess.sb:
1:19 PM Changeset in webkit [77408] by mrobinson@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-02 Dan Winship <danw@gnome.org>

Reviewed by Martin Robinson.

[GTK] remove old data: URI handler, fix the SoupRequest-based one
to pass tests
https://bugs.webkit.org/show_bug.cgi?id=50885

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::sendRequestCallback): Do content-type sniffing here for non-HTTP requests. (WebCore::startHTTPRequest): Rename to match WebKit style. (WebCore::ResourceHandle::start): Pass everything except HTTP to startNonHTTPRequest, letting the SoupRequester decide whether it's supported or not. (WebCore::startNonHTTPRequest): Remove some old pre-SoupRequester code that was a no-op for file: URIs, but would break some data: URIs.
1:18 PM Changeset in webkit [77407] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

2011-02-02 Dimitri Glazkov <Dimitri Glazkov>

Update even more references to right() and bottom() in Chromium. Sheesh.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::getFramebufferPixels): Replaced bottom/right with maxY/maxX.
1:12 PM Changeset in webkit [77406] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-02 Dimitri Glazkov <Dimitri Glazkov>

Update more references to right() and bottom() in Chromium.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::doPixelReadbackToCanvas): Replaced bottom/right with maxY/maxX.
1:03 PM Changeset in webkit [77405] by alex
  • 2 edits in trunk/Source/WebCore

2011-02-02 Alejandro G. Castro <alex@igalia.com>

Unreviewed Gtk3 buildfix after r77286.

https://bugs.webkit.org/show_bug.cgi?id=53520
Remove the physical terminology from IntRect and FloatRect.

  • platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::paintMenuList):
1:01 PM Changeset in webkit [77404] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix build.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::pinnedInDirection):

12:59 PM Changeset in webkit [77403] by hyatt@apple.com
  • 3 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=53619

Reviewed by Dan Bernstein.

Floats should not use physical terminology for their rects. Replace left/top with x/y and right/bottom
with maxX/maxY. This matches IntRect.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::flipFloatForWritingMode):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::adjustForBorderFit):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::FloatingObject::x):
(WebCore::RenderBlock::FloatingObject::maxX):
(WebCore::RenderBlock::FloatingObject::y):
(WebCore::RenderBlock::FloatingObject::maxY):
(WebCore::RenderBlock::FloatingObject::setX):
(WebCore::RenderBlock::FloatingObject::setY):
(WebCore::RenderBlock::logicalTopForFloat):
(WebCore::RenderBlock::logicalBottomForFloat):
(WebCore::RenderBlock::logicalLeftForFloat):
(WebCore::RenderBlock::logicalRightForFloat):
(WebCore::RenderBlock::setLogicalTopForFloat):
(WebCore::RenderBlock::setLogicalLeftForFloat):
(WebCore::RenderBlock::xPositionForFloatIncludingMargin):
(WebCore::RenderBlock::yPositionForFloatIncludingMargin):

12:54 PM Changeset in webkit [77402] by Dimitri Glazkov
  • 5 edits in trunk/Source

2011-02-02 Dimitri Glazkov <Dimitri Glazkov>

Update more references to right() and bottom() in Chromium Win.

  • platform/graphics/chromium/TransparencyWin.cpp: (WebCore::TransparencyWin::compositeOpaqueComposite): Replaced bottom/right with maxY/maxX. (WebCore::TransparencyWin::compositeTextComposite): Ditto.
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::paintMenuList): Ditto.

2011-02-02 Dimitri Glazkov <Dimitri Glazkov>

Update more references to right() and bottom() in Chromium Win.

  • tests/TransparencyWinTest.cpp: (WebCore::TEST): Replaced bottom/right with maxY/maxX.
12:33 PM Changeset in webkit [77401] by Adam Roben
  • 3 edits in trunk/Source/WebCore

Encode/decode FormData and FormDataElement objects consistently

Fixes <http://webkit.org/b/53615> <rdar://problem/8943346> WebKit2: Restoring session state
that contains form data fails (asserts in Debug build)

To prevent this from interfering with WebKit2 testing, it's useful to get this into a build
now, even though we don't have an automated test for it yet. Writing a test is covered by
<http://webkit.org/b/53616>.

Reviewed by Darin Adler.

  • history/HistoryItem.cpp: Bump the encoding version, since this patch changes how we encode

FormData objects.

  • platform/network/FormData.cpp:

(WebCore::decode): Decode the type from the Decoder, rather than getting it from the
default-constructed FormDataElement. Failing to do this meant that all future uses of the
Decoder would be reading from an unexpected part of the buffer (i.e., the next decode would
start by reading the uint32_t that we forgot to decode here, and so on). We already had code
to correctly set the FormDataElement's type based on this decoded type later in the
function.
(WebCore::FormData::encodeForBackForward): Encode m_identifier as an int64_t, since that
matches its type and how we decode it.

12:25 PM Changeset in webkit [77400] by kbr@google.com
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-02 Matthew Vosburgh <maf@chromium.org>

Reviewed by Kenneth Russell.

Some favicons not correctly decoded by Chromium/Mac
https://bugs.webkit.org/show_bug.cgi?id=53448

  • src/WebImageCG.cpp: (WebKit::WebImage::fromData):
12:24 PM Changeset in webkit [77399] by mrobinson@webkit.org
  • 6 edits
    17 deletes in trunk/Source

2011-02-02 Dan Winship <danw@gnome.org>

Reviewed by Martin Robinson.

[GTK] drop soup cache stuff, which has been moved to libsoup
https://bugs.webkit.org/show_bug.cgi?id=50747

Use libsoup-based cache/requester API and remove the WebCore version
of this functionality. This has been pushed upstream fully.

No new tests because this should not change functionality.

  • GNUmakefile.am: Update for removed files.
  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal): Update type names, drop m_requester.
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ensureSessionIsInitialized): Add a SoupRequester to the session. (WebCore::parseDataUrl): (WebCore::startHttp): Get the requester from the session rather than using m_requester. (WebCore::sendRequestCallback): (WebCore::ResourceHandle::platformSetDefersLoading): (WebCore::readCallback): (WebCore::startGio): Update type names.
  • platform/network/soup/cache/soup-directory-input-stream.c: Removed.
  • platform/network/soup/cache/soup-directory-input-stream.h: Removed.
  • platform/network/soup/cache/soup-http-input-stream.c: Removed.
  • platform/network/soup/cache/soup-http-input-stream.h: Removed.
  • platform/network/soup/cache/soup-request-data.c: Removed.
  • platform/network/soup/cache/soup-request-data.h: Removed.
  • platform/network/soup/cache/soup-request-file.c: Removed.
  • platform/network/soup/cache/soup-request-file.h: Removed.
  • platform/network/soup/cache/soup-request-http.c: Removed.
  • platform/network/soup/cache/soup-request-http.h: Removed.
  • platform/network/soup/cache/soup-request.c: Removed.
  • platform/network/soup/cache/soup-request.h: Removed.
  • platform/network/soup/cache/soup-requester.c: Removed.
  • platform/network/soup/cache/soup-requester.h: Removed.
  • platform/network/soup/cache/webkit/soup-cache-private.h: Removed.
  • platform/network/soup/cache/webkit/soup-cache.c: Removed.
  • platform/network/soup/cache/webkit/soup-cache.h: Removed.

2011-02-02 Dan Winship <danw@gnome.org>

Reviewed by Martin Robinson.

[GTK] drop soup cache stuff, which has been moved to libsoup
https://bugs.webkit.org/show_bug.cgi?id=50747

  • GNUmakefile.am: Remove old cache files.
12:20 PM Changeset in webkit [77398] by hyatt@apple.com
  • 4 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=53520

Reviewed by Darin Adler.

Remove physical accessors from IntRect and FloatRect.

  • page/FrameView.cpp:

(WebCore::FrameView::adjustPageHeightDeprecated):

  • platform/graphics/FloatRect.h:
  • platform/graphics/IntRect.h:
12:19 PM Changeset in webkit [77397] by hyatt@apple.com
  • 15 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=53614

Reviewed by Dan Bernstein.

Remove physical terminology from overflow. Replace with minX/maxX/minY/maxY.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::addBoxShadowVisualOverflow):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::minYLayoutOverflow):
(WebCore::InlineFlowBox::maxYLayoutOverflow):
(WebCore::InlineFlowBox::minXLayoutOverflow):
(WebCore::InlineFlowBox::maxXLayoutOverflow):
(WebCore::InlineFlowBox::logicalLeftLayoutOverflow):
(WebCore::InlineFlowBox::logicalRightLayoutOverflow):
(WebCore::InlineFlowBox::logicalTopLayoutOverflow):
(WebCore::InlineFlowBox::logicalBottomLayoutOverflow):
(WebCore::InlineFlowBox::minYVisualOverflow):
(WebCore::InlineFlowBox::maxYVisualOverflow):
(WebCore::InlineFlowBox::minXVisualOverflow):
(WebCore::InlineFlowBox::maxXVisualOverflow):
(WebCore::InlineFlowBox::logicalLeftVisualOverflow):
(WebCore::InlineFlowBox::logicalRightVisualOverflow):
(WebCore::InlineFlowBox::logicalminYVisualOverflow):
(WebCore::InlineFlowBox::logicalmaxYVisualOverflow):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustLinePositionForPagination):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::beforeSideVisualOverflowForLine):
(WebCore::RenderBlock::afterSideVisualOverflowForLine):
(WebCore::RenderBlock::beforeSideLayoutOverflowForLine):
(WebCore::RenderBlock::afterSideLayoutOverflowForLine):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::scrollWidth):
(WebCore::RenderBox::scrollHeight):

  • rendering/RenderBox.h:

(WebCore::RenderBox::minYLayoutOverflow):
(WebCore::RenderBox::maxYLayoutOverflow):
(WebCore::RenderBox::minXLayoutOverflow):
(WebCore::RenderBox::maxXLayoutOverflow):
(WebCore::RenderBox::logicalLeftLayoutOverflow):
(WebCore::RenderBox::logicalRightLayoutOverflow):
(WebCore::RenderBox::minYVisualOverflow):
(WebCore::RenderBox::maxYVisualOverflow):
(WebCore::RenderBox::minXVisualOverflow):
(WebCore::RenderBox::maxXVisualOverflow):
(WebCore::RenderBox::logicalLeftVisualOverflow):
(WebCore::RenderBox::logicalRightVisualOverflow):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::linesVisualOverflowBoundingBox):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::ensureRootPlatformLayer):

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::anyLineIntersectsRect):
(WebCore::RenderLineBoxList::lineIntersectsDirtyRect):
(WebCore::RenderLineBoxList::paint):
(WebCore::RenderLineBoxList::hitTest):

  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::computePosition):

  • rendering/RenderOverflow.h:

(WebCore::RenderOverflow::RenderOverflow):
(WebCore::RenderOverflow::minYLayoutOverflow):
(WebCore::RenderOverflow::maxYLayoutOverflow):
(WebCore::RenderOverflow::minXLayoutOverflow):
(WebCore::RenderOverflow::maxXLayoutOverflow):
(WebCore::RenderOverflow::minYVisualOverflow):
(WebCore::RenderOverflow::maxYVisualOverflow):
(WebCore::RenderOverflow::minXVisualOverflow):
(WebCore::RenderOverflow::maxXVisualOverflow):
(WebCore::RenderOverflow::setminYVisualOverflow):
(WebCore::RenderOverflow::visualOverflowRect):
(WebCore::RenderOverflow::move):
(WebCore::RenderOverflow::addVisualOverflow):
(WebCore::RenderOverflow::setVisualOverflow):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::shouldPaint):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):
(WebCore::RenderTable::paint):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::clippedOverflowRectForRepaint):

  • rendering/RenderTreeAsText.cpp:

(WebCore::writeLayers):

  • rendering/RenderView.cpp:

(WebCore::RenderView::docTop):

12:07 PM Changeset in webkit [77396] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-02-02 Dimitri Glazkov <Dimitri Glazkov>

Added GPU fails from bots.

  • platform/chromium-gpu/test_expectations.txt: Added.
11:58 AM Changeset in webkit [77395] by Dimitri Glazkov
  • 3 edits in trunk/Source/WebKit/chromium

2011-02-02 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Dave Hyatt.

Remove remaining references to right() and bottom() from Chromium build.
https://bugs.webkit.org/show_bug.cgi?id=53613

  • src/DragScrollTimer.cpp: (WebKit::distanceToRect): Replaced right/bottom with maxX/maxY.
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::doPixelReadbackToCanvas): Ditto.
11:56 AM Changeset in webkit [77394] by dbates@webkit.org
  • 26 edits in trunk

2011-02-02 Steve Lacey <sjl@chromium.org>

Reviewed by Eric Carlson.

Implement basic media statistics on media elements.
https://bugs.webkit.org/show_bug.cgi?id=53322

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

2011-02-02 Steve Lacey <sjl@chromium.org>

Reviewed by Eric Carlson.

Implement basic media statistics on media elements.
https://bugs.webkit.org/show_bug.cgi?id=53322

  • configure.ac:

2011-02-02 Steve Lacey <sjl@chromium.org>

Reviewed by Eric Carlson.

Implement basic media statistics on media elements.
https://bugs.webkit.org/show_bug.cgi?id=53322

  • Scripts/build-webkit:

2011-02-02 Steve Lacey <sjl@chromium.org>

Reviewed by Eric Carlson.

Implement basic media statistics on media elements.
https://bugs.webkit.org/show_bug.cgi?id=53322

  • Configurations/FeatureDefines.xcconfig:

2011-02-02 Steve Lacey <sjl@chromium.org>

Reviewed by Eric Carlson.

Implement basic media statistics on media elements.
https://bugs.webkit.org/show_bug.cgi?id=53322

  • Configurations/FeatureDefines.xcconfig:

2011-02-02 Steve Lacey <sjl@chromium.org>

Reviewed by Eric Carlson.

Implement basic media statistics on media elements.
https://bugs.webkit.org/show_bug.cgi?id=53322

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • features.pri:
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::webkitAudioBytesDecoded): (WebCore::HTMLMediaElement::webkitVideoBytesDecoded):
  • html/HTMLMediaElement.h:
  • html/HTMLMediaElement.idl:
  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::webkitDecodedFrames): (WebCore::HTMLVideoElement::webkitDroppedFrames):
  • html/HTMLVideoElement.h:
  • html/HTMLVideoElement.idl:
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::decodedFrames): (WebCore::MediaPlayer::droppedFrames): (WebCore::MediaPlayer::audioBytesDecoded): (WebCore::MediaPlayer::videoBytesDecoded):
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::decodedFrames): (WebCore::MediaPlayerPrivateInterface::droppedFrames): (WebCore::MediaPlayerPrivateInterface::audioBytesDecoded): (WebCore::MediaPlayerPrivateInterface::videoBytesDecoded):

2011-02-02 Steve Lacey <sjl@chromium.org>

Reviewed by Eric Carlson.

Implement basic media statistics on media elements.
https://bugs.webkit.org/show_bug.cgi?id=53322

  • Configurations/FeatureDefines.xcconfig:
11:40 AM Changeset in webkit [77393] by luiz@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-02 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by David Hyatt.

More conversion from right()/bottom() to maxX()/maxY().

  • page/qt/FrameQt.cpp: (WebCore::Frame::dragImageForSelection):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::roundToDevicePixels):
11:34 AM Changeset in webkit [77392] by kevino@webkit.org
  • 21 edits in trunk

[wx] Build fixes for wxWebKit.

11:21 AM Changeset in webkit [77391] by ggaren@apple.com
  • 15 edits
    1 copy
    1 add in trunk/Source/JavaScriptCore

2011-02-01 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

A little more Heap refactoring
https://bugs.webkit.org/show_bug.cgi?id=53577


SunSpider reports no change.


Split out MarkedBlock into its own file / class.


Did the following renames:

isCellMarked => isMarked
checkMarkCell => testAndSetMarked
markCell => setMarked
cellOffset => cellNumber
collectorBlock => blockFor

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.pro:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/Heap.cpp: (JSC::WeakGCHandlePool::update):
  • runtime/Heap.h: (JSC::Heap::isMarked): (JSC::Heap::testAndSetMarked): (JSC::Heap::setMarked):
  • runtime/JSArray.h: (JSC::MarkStack::markChildren): (JSC::MarkStack::drain):
  • runtime/JSCell.h: (JSC::JSCell::MarkStack::internalAppend):
  • runtime/MarkedBlock.cpp: Added.
  • runtime/MarkedBlock.h: Added. (JSC::MarkedBlock::blockFor): (JSC::MarkedBlock::cellNumber): (JSC::MarkedBlock::isMarked): (JSC::MarkedBlock::testAndSetMarked): (JSC::MarkedBlock::setMarked): (JSC::MarkedBlock::isCellAligned): (JSC::MarkedBlock::isPossibleCell):
  • runtime/MarkedSpace.h: (JSC::MarkedSpace::isMarked): (JSC::MarkedSpace::testAndSetMarked): (JSC::MarkedSpace::setMarked):
  • runtime/SmallStrings.cpp: (JSC::isMarked):
  • runtime/WeakGCMap.h: (JSC::WeakGCMap::isValid): (JSC::::get): (JSC::::take): (JSC::::set):
11:13 AM Changeset in webkit [77390] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

More right()/bottom() to maxX()/maxY() conversion.

Reviewed by Darin Adler.

  • page/chromium/FrameChromium.cpp:

(WebCore::Frame::nodeImage):
(WebCore::Frame::dragImageForSelection):

11:00 AM Changeset in webkit [77389] by weinig@apple.com
  • 4 edits in trunk/Source

Fix windows clean build.

../JavaScriptCore:

  • DerivedSources.make:

../WebCore:

  • DerivedSources.make:
10:56 AM Changeset in webkit [77388] by mrobinson@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

2011-02-02 Martin Robinson <mrobinson@igalia.com>

Unskip a test that just needs platform-specific results. Re-classify
two other failures with more pertinent information.

  • platform/gtk/Skipped: Organize the skipped list a bit. Unskip a test. Remove obsolete comments.
  • platform/gtk/editing/inserting/5994480-2-expected.txt: Added.
10:55 AM Changeset in webkit [77387] by mnaganov@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-02-02 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Landing detailed heap snapshots, part 2.

https://bugs.webkit.org/show_bug.cgi?id=53606

Display progress while taking a snapshot, and hints while loading
and parsing. This is needed because taking detailed heap snapshots
takes time.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/DetailedHeapshotView.js: (WebInspector.DetailedHeapshotProfileType.prototype.buttonClicked):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._reset): (WebInspector.ProfilesPanel.prototype._addProfileHeader): (WebInspector.ProfilesPanel.prototype.getProfiles): (WebInspector.ProfilesPanel.prototype.loadHeapSnapshot): (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.doParse): (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot): (WebInspector.ProfilesPanel.prototype.takeHeapSnapshot): (WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):
  • inspector/front-end/SidebarTreeElement.js: (WebInspector.SidebarTreeElement.prototype.refreshTitles):
10:51 AM Changeset in webkit [77386] by ap@apple.com
  • 7 edits in trunk/Source/WebKit2

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=53561
<rdar://problem/8900228> Stepping through print previews in WebKit2 mode steps in and out of
printing mode a lot

Disable NSView autodisplay, so that -[WKView drawRect:] isn't called (other than when
resizing the window), so that we don't have to switch modes all the time.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::setAutodisplay):
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setAutodisplay):
  • UIProcess/WebPageProxy.h: Pipe the call from WKPrintingView down to WKView.
  • UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView beginDocument]): Added. We don't want to autodisplay WKView while printing, because layout is changed to print at the time, and drawing to screen requires relayout.


(-[WKPrintingView endDocument]): When not printing, turn autodisplay back on. Also, call
-[super endDocument] for unknown but definitive good (oops!).

10:35 AM Changeset in webkit [77385] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

More conversion from right()/bottom() to maxX()/maxY().

Reviewed by Darin Adler.

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::calculatePositionAndSize):
(WebCore::PopupMenuWin::paint):

10:32 AM Changeset in webkit [77384] by hyatt@apple.com
  • 20 edits in trunk/Source/WebCore

Removal of right()/bottom(). Replace with maxX() and maxY(). Still converting. Haven't removed yet.

Reviewed by Darin Adler.

  • platform/chromium/PopupMenuChromium.cpp:

(WebCore::PopupContainer::layoutAndCalculateWidgetRect):
(WebCore::PopupListBox::scrollToRevealRow):
(WebCore::PopupListBox::layout):

  • platform/graphics/FloatRect.h:
  • platform/graphics/IntRect.h:
  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::getImageData):
(WebCore::putImageData):

  • platform/graphics/chromium/GLES2Canvas.cpp:

(WebCore::GLES2Canvas::drawTexturedRect):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::verticalScrollbarRect):
(WebCore::LayerRendererChromium::horizontalScrollbarRect):
(WebCore::LayerRendererChromium::setScissorToRect):
(WebCore::LayerRendererChromium::setDrawViewportRect):

  • platform/graphics/chromium/LayerTilerChromium.cpp:

(WebCore::LayerTilerChromium::contentRectToTileIndices):
(WebCore::LayerTilerChromium::growLayerToContain):

  • platform/graphics/gpu/TilingData.cpp:

(WebCore::TilingData::tileBoundsWithBorder):
(WebCore::TilingData::overlappedTileIndices):

  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::getImageData):
(WebCore::putImageData):

  • platform/graphics/skia/FloatRectSkia.cpp:

(WebCore::FloatRect::operator SkRect):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::getImageData):
(WebCore::putImageData):

  • platform/graphics/skia/IntRectSkia.cpp:

(WebCore::IntRect::operator SkIRect):
(WebCore::IntRect::operator SkRect):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::beginLayerClippedToImage):

  • platform/graphics/win/GraphicsContextWin.cpp:

(WebCore::GraphicsContextPlatformPrivate::clip):

  • platform/graphics/win/IntRectWin.cpp:

(WebCore::IntRect::operator RECT):

  • platform/graphics/win/UniscribeController.cpp:

(WebCore::UniscribeController::shapeAndPlaceItem):

  • platform/graphics/wince/GraphicsContextWinCE.cpp:

(WebCore::roundRect):
(WebCore::mapRect):
(WebCore::TransparentLayerDC::TransparentLayerDC):
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::strokeArc):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::strokeRect):

  • platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::initFrameBuffer):

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::calculatePositionAndSize):
(WebCore::PopupMenuWin::paint):

  • plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::invalidateRect):

  • rendering/RenderThemeSafari.cpp:

(WebCore::RenderThemeSafari::paintMenuListButtonGradients):
(WebCore::RenderThemeSafari::paintMenuListButton):
(WebCore::RenderThemeSafari::paintSliderTrack):

  • rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::paintInnerSpinButton):
(WebCore::RenderThemeWin::paintMenuListButton):

10:30 AM Changeset in webkit [77383] by darin@chromium.org
  • 6 edits
    2 adds in trunk/Source/WebKit/chromium

2011-02-01 Darin Fisher <darin@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Avoid #ifdefs in code that constructs a GraphicsContext by
adding a helper class.
https://bugs.webkit.org/show_bug.cgi?id=53575

  • WebKit.gyp:
  • src/WebFontImpl.cpp: (WebKit::WebFontImpl::drawText):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::printPage): (WebKit::WebFrameImpl::paint):
  • src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::paint):
  • src/WebScrollbarImpl.cpp: (WebKit::WebScrollbarImpl::paint):
  • src/painting: Added.
  • src/painting/GraphicsContextBuilder.h: Added. (WebKit::GraphicsContextBuilder::GraphicsContextBuilder): (WebKit::GraphicsContextBuilder::context):
10:30 AM Changeset in webkit [77382] by hyatt@apple.com
  • 8 edits in trunk/Source/WebKit

Removal of right()/bottom(), converting to maxX()/maxY().

Reviewed by Darin Adler.

../WebKit/gtk:

  • webkit/webkitwebview.cpp:

(webkit_web_view_popup_menu_handler):

../WebKit/win:

  • DOMHTMLClasses.cpp:

(DOMHTMLInputElement::rectOnScreen):

  • WebCoreSupport/EmbeddedWidget.cpp:

(EmbeddedWidget::frameRectsChanged):

  • WebFrame.cpp:

(WebFrame::computePageRects):

  • WebScrollBar.cpp:

(WebScrollBar::frameRect):

  • WebView.cpp:

(WebView::addToDirtyRegion):
(WebView::visibleContentRect):
(WebView::prepareCandidateWindow):

10:29 AM Changeset in webkit [77381] by hyatt@apple.com
  • 4 edits in trunk/Source/WebKit2

Conversion of right()/bottom() to maxX()/maxY() as part of the removal of those accessors.

Reviewed by Darin Adler.

  • UIProcess/win/WebPopupMenuProxyWin.cpp:

(WebKit::WebPopupMenuProxyWin::calculatePositionAndSize):

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::prepareCandidateWindow):

  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::NetscapePlugin::platformGeometryDidChange):

10:06 AM Changeset in webkit [77380] by alex
  • 2 edits in trunk/Source/WebKit/gtk/po

2011-02-02 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] po files path update after the code moved to Source
https://bugs.webkit.org/show_bug.cgi?id=53599

  • POTFILES: Add Source to the path of the files.
10:05 AM Changeset in webkit [77379] by caseq@chromium.org
  • 2 edits
    3 adds in trunk

2011-02-01 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add test for OPTIONS requests caused by CORS preflight checking to appear in Network panel
https://bugs.webkit.org/show_bug.cgi?id=53501

  • http/tests/inspector/network-preflight-options-expected.txt: Added.
  • http/tests/inspector/network-preflight-options.html: Added.
  • http/tests/inspector/resources/cors-target.php: Added.
9:59 AM Changeset in webkit [77378] by Darin Adler
  • 2 edits in trunk/Source/WebKit2

2011-02-01 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

Overflow in WebKit2 argument decoder buffer checking
https://bugs.webkit.org/show_bug.cgi?id=53536

  • Platform/CoreIPC/ArgumentDecoder.cpp: (CoreIPC::roundUpToAlignment): Tweak code a bit for clarity and to replace C casts with C++ casts. (CoreIPC::ArgumentDecoder::alignBufferPosition): Rearrange buffer calculation so we don't do any math with the passed-in size, because that could overflow. (CoreIPC::ArgumentDecoder::bufferIsLargeEnoughToContain): Ditto.
9:00 AM Changeset in webkit [77377] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-02 Martin Robinson <mrobinson@igalia.com>

Skip another test that uses modal dialogs.

  • platform/gtk/Skipped: Skip modal dialog test and update bug in the skipped list.
7:00 AM Changeset in webkit [77376] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

Use Vector instead of a linked list for rules in CSSStyleSelector
https://bugs.webkit.org/show_bug.cgi?id=53581

Reviewed by Maciej Stachowiak.

  • eliminate CSSRuleDataList, replace with Vector<RuleData>
  • rename CSSRuleData -> RuleData and CSSRuleSet -> RuleSet (these are selector internal classes, CSS prefix is better reserved for public ones).
  • constify a bit
  • shrink the vectors to fit after collecting the rules
  • css/CSSStyleSelector.cpp:

(WebCore::RuleData::RuleData):
(WebCore::RuleData::position):
(WebCore::RuleData::rule):
(WebCore::RuleData::selector):
(WebCore::RuleSet::disableAutoShrinkToFit):
(WebCore::RuleSet::getIDRules):
(WebCore::RuleSet::getClassRules):
(WebCore::RuleSet::getTagRules):
(WebCore::RuleSet::getPseudoRules):
(WebCore::RuleSet::getUniversalRules):
(WebCore::RuleSet::getPageRules):
(WebCore::collectSiblingRulesInDefaultStyle):
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::loadFullDefaultStyle):
(WebCore::loadSimpleDefaultStyle):
(WebCore::loadViewSourceStyle):
(WebCore::CSSStyleSelector::matchRules):
(WebCore::CSSStyleSelector::matchRulesForList):
(WebCore::operator >):
(WebCore::operator <=):
(WebCore::CSSStyleSelector::sortMatchedRules):
(WebCore::CSSStyleSelector::matchUARules):
(WebCore::RuleSet::RuleSet):
(WebCore::RuleSet::~RuleSet):
(WebCore::RuleSet::addToRuleSet):
(WebCore::RuleSet::addRule):
(WebCore::RuleSet::addPageRule):
(WebCore::RuleSet::addRulesFromSheet):
(WebCore::RuleSet::addStyleRule):
(WebCore::collectIdsAndSiblingRulesFromList):
(WebCore::RuleSet::collectIdsAndSiblingRules):
(WebCore::shrinkMapVectorsToFit):
(WebCore::RuleSet::shrinkToFit):
(WebCore::CSSStyleSelector::matchPageRules):
(WebCore::CSSStyleSelector::matchPageRulesForList):

  • css/CSSStyleSelector.h:

(WebCore::CSSStyleSelector::addMatchedRule):

6:08 AM Changeset in webkit [77375] by podivilov@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-02-02 Andrey Adaikin <aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: Use DIVs instead of TABLE in TextViewer
https://bugs.webkit.org/show_bug.cgi?id=53299

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._createTextViewer): (WebInspector.SourceFrame.prototype._mouseDown):
  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer): (WebInspector.TextViewer.prototype.set mimeType): (WebInspector.TextViewer.prototype.revealLine): (WebInspector.TextViewer.prototype.addDecoration): (WebInspector.TextViewer.prototype.removeDecoration): (WebInspector.TextViewer.prototype.markAndRevealRange): (WebInspector.TextViewer.prototype.highlightLine): (WebInspector.TextViewer.prototype.clearLineHighlight): (WebInspector.TextViewer.prototype.freeCachedElements): (WebInspector.TextViewer.prototype._handleKeyDown): (WebInspector.TextViewer.prototype.editLine.finishEditing): (WebInspector.TextViewer.prototype.editLine): (WebInspector.TextViewer.prototype.beginUpdates): (WebInspector.TextViewer.prototype.endUpdates): (WebInspector.TextViewer.prototype.resize): (WebInspector.TextViewer.prototype._textChanged): (WebInspector.TextViewer.prototype._updatePanelOffsets): (WebInspector.TextViewer.prototype._syncScroll): (WebInspector.TextViewer.prototype._syncDecorationsForLine): (WebInspector.TextEditorChunkedPanel): (WebInspector.TextEditorChunkedPanel.prototype.set syncScrollListener): (WebInspector.TextEditorChunkedPanel.prototype.get textModel): (WebInspector.TextEditorChunkedPanel.prototype.addDecoration): (WebInspector.TextEditorChunkedPanel.prototype.removeDecoration): (WebInspector.TextEditorChunkedPanel.prototype.revealLine): (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk): (WebInspector.TextEditorChunkedPanel.prototype.textChanged): (WebInspector.TextEditorChunkedPanel.prototype.beginUpdates): (WebInspector.TextEditorChunkedPanel.prototype.endUpdates): (WebInspector.TextEditorChunkedPanel.prototype.resize): (WebInspector.TextEditorChunkedPanel.prototype._scroll): (WebInspector.TextEditorChunkedPanel.prototype._scheduleRepaintAll): (WebInspector.TextEditorChunkedPanel.prototype._buildChunks): (WebInspector.TextEditorChunkedPanel.prototype._repaintAll): (WebInspector.TextEditorChunkedPanel.prototype._chunkNumberForLine): (WebInspector.TextEditorChunkedPanel.prototype._chunkForLine): (WebInspector.TextEditorGutterPanel): (WebInspector.TextEditorGutterPanel.prototype.freeCachedElements): (WebInspector.TextEditorGutterPanel.prototype._createNewChunk): (WebInspector.TextEditorGutterPanel.prototype._expandChunks): (WebInspector.TextEditorGutterChunk): (WebInspector.TextEditorGutterChunk.prototype.get expanded): (WebInspector.TextEditorGutterChunk.prototype.set expanded): (WebInspector.TextEditorGutterChunk.prototype.get height): (WebInspector.TextEditorGutterChunk.prototype._createRow): (WebInspector.TextEditorMainPanel): (WebInspector.TextEditorMainPanel.prototype.set syncDecorationsForLine): (WebInspector.TextEditorMainPanel.prototype.set mimeType): (WebInspector.TextEditorMainPanel.prototype.markAndRevealRange): (WebInspector.TextEditorMainPanel.prototype.highlightLine): (WebInspector.TextEditorMainPanel.prototype.clearLineHighlight): (WebInspector.TextEditorMainPanel.prototype.freeCachedElements): (WebInspector.TextEditorMainPanel.prototype._buildChunks): (WebInspector.TextEditorMainPanel.prototype._createNewChunk): (WebInspector.TextEditorMainPanel.prototype._expandChunks): (WebInspector.TextEditorMainPanel.prototype._highlightDataReady): (WebInspector.TextEditorMainPanel.prototype._paintLines): (WebInspector.TextEditorMainPanel.prototype._paintLine): (WebInspector.TextEditorMainPanel.prototype._releaseLinesHighlight): (WebInspector.TextEditorMainPanel.prototype._getSelection): (WebInspector.TextEditorMainPanel.prototype._restoreSelection): (WebInspector.TextEditorMainPanel.prototype._selectionToPosition): (WebInspector.TextEditorMainPanel.prototype._positionToSelection): (WebInspector.TextEditorMainPanel.prototype._appendTextNode): (WebInspector.TextEditorMainPanel.prototype._handleDomUpdates): (WebInspector.TextEditorMainChunk): (WebInspector.TextEditorMainChunk.prototype.addDecoration): (WebInspector.TextEditorMainChunk.prototype.set expanded): (WebInspector.TextEditorMainChunk.prototype.get height): (WebInspector.TextEditorMainChunk.prototype.getExpandedLineRow): (WebInspector.TextEditorMainChunk.prototype._createRow): (WebInspector):
  • inspector/front-end/textViewer.css: (.text-editor-lines): (.text-editor-contents): (.text-editor-editable): (.webkit-line-decorations): (.webkit-line-number): (.webkit-execution-line.webkit-line-content): (.diff-container .webkit-added-line.webkit-line-content): (.diff-container .webkit-removed-line.webkit-line-content): (.diff-container .webkit-changed-line.webkit-line-content): (.webkit-highlighted-line.webkit-line-content):
6:07 AM Changeset in webkit [77374] by ager@chromium.org
  • 10 edits in branches/chromium/648/LayoutTests/platform

Merge 77135 - 2011-01-31 Mads Ager <ager@chromium.org>

Reviewed by Pavel Feldman.

[V8] Update V8 specific layout test expectations
https://bugs.webkit.org/show_bug.cgi?id=53423

Error formatting has changed in V8. Updating chromium specific
layout test expectations accordingly.

  • platform/chromium-mac/fast/js/array-every-expected.txt:
  • platform/chromium-mac/fast/js/instance-of-immediates-expected.txt:
  • platform/chromium-mac/fast/js/property-getters-and-setters-expected.txt:
  • platform/chromium-mac/storage/transaction-error-callback-expected.txt:
  • platform/chromium-mac/svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:
  • platform/chromium-win/fast/js/array-every-expected.txt:
  • platform/chromium-win/fast/js/instance-of-immediates-expected.txt:
  • platform/chromium-win/fast/js/property-getters-and-setters-expected.txt:
  • platform/chromium-win/storage/transaction-error-callback-expected.txt:
  • platform/chromium-win/svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:

TBR=ager@chromium.org
Review URL: http://codereview.chromium.org/6349048

5:55 AM Changeset in webkit [77373] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-02 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Removed some custom Chromium test expectations.

  • platform/chromium/test_expectations.txt:
3:57 AM Changeset in webkit [77372] by mnaganov@chromium.org
  • 1 edit in branches/chromium/648/Source/WebCore/inspector/InspectorProfilerAgent.cpp

Merge 77254 - 2011-02-01 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Fix profiles reset to avoid clearing heap profiles in Chromium.

https://bugs.webkit.org/show_bug.cgi?id=53500

  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::resetFrontendProfiles):

TBR=mnaganov@chromium.org
Review URL: http://codereview.chromium.org/6246044

2:10 AM Changeset in webkit [77371] by hans@chromium.org
  • 15 edits
    2 adds in trunk

2011-02-02 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Implement support for cursor updates
https://bugs.webkit.org/show_bug.cgi?id=53421

Layout test for cursor updates.

  • storage/indexeddb/cursor-update-expected.txt: Added.
  • storage/indexeddb/cursor-update.html: Added.

2011-02-02 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Implement support for cursor updates
https://bugs.webkit.org/show_bug.cgi?id=53421

Implement support for cursor updates using the same pattern as cursor
deletes: forward the calls to the IDBObjectStoreBackend::put().
The put() function's signature needs to be changed to allow for a
"cursor update mode". This makes the signature more clear anyway,
since it replaces the boolean parameter.

Test: storage/indexeddb/cursor-update.html

  • storage/IDBCursor.idl:
  • storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::key): (WebCore::IDBCursorBackendImpl::update):
  • storage/IDBCursorBackendImpl.h:
  • storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::add): (WebCore::IDBObjectStore::put):
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::put): (WebCore::IDBObjectStoreBackendImpl::putInternal):
  • storage/IDBObjectStoreBackendImpl.h:
  • storage/IDBObjectStoreBackendInterface.h:

2011-02-02 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Implement support for cursor updates
https://bugs.webkit.org/show_bug.cgi?id=53421

Mirror the update to the IDBObjectStoreInterface::put() signature in
the WebKit layer wrappers.

  • public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::put):
  • src/IDBObjectStoreProxy.cpp: (WebCore::IDBObjectStoreProxy::put):
  • src/IDBObjectStoreProxy.h:
  • src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::put):
  • src/WebIDBObjectStoreImpl.h:
12:50 AM Changeset in webkit [77370] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-02 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Kent Tamura.

Fix popup menu RTL bug introduced by Changeset 75982.
https://bugs.webkit.org/show_bug.cgi?id=53567

PopupMenuChromium::layout() calculates X position according to RTL or not. So Change the X position calculation in layoutAndCalculateWidgetRect().

No new tests. However we can check manually with select_dropdown_box_alignment.html, autofill_alignment.html, select_alignment.html, select_dropdown_box_alignment.html, autofill-popup-width-and-item-direction.html

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::layoutAndCalculateWidgetRect): Fix calculation of x position, because layout() considers RTL. And change the parameter from both X and Y positions to only Y position. (WebCore::PopupContainer::showPopup): Change the passing parameter. (WebCore::PopupContainer::refresh): Change the passing parameter.
  • platform/chromium/PopupMenuChromium.h: Change the parameter declaration.
12:49 AM Changeset in webkit [77369] by alex
  • 4 edits in trunk/Source

2011-02-02 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fix dist compilation
https://bugs.webkit.org/show_bug.cgi?id=53579

  • GNUmakefile.am: Added WriteBarrier.h to the sources, it was added in r77151

2011-02-02 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fix dist compilation
https://bugs.webkit.org/show_bug.cgi?id=53579

  • GNUmakefile.am: Added FontWidthVariant.h to the sources, it was added in r77153.
12:24 AM Changeset in webkit [77368] by commit-queue@webkit.org
  • 14 edits in trunk/Source/WebCore

2011-02-02 Dai Mikurube <dmikurube@google.com>

Reviewed by David Levin.

Make mime type lookup in File::create(path) thread-safe
https://bugs.webkit.org/show_bug.cgi?id=47700

This patch introduces a new function MIMETypeRegistry::getMIMETypeForExtensionThreadSafe().
The function is to be called as a thread-safe version of getMIMETypeForExtension() when
both FILE_SYSTEM and WORKERS are enabled.

No tests for this patch. This patch itself doesn't change the behaviors.
For Chromium, it runs in the same way with getMIMETypeForExtensionThreadSafe().
For the other platforms, it causes compilation error in case of enabled FILE_SYSTEM and WORKERS.
The compilation error would be a signal to implement getMIMETypeForExtensionThreadSafe() in these
platforms. Currently it doesn't happen since FILE_SYSTEM is not available in the other platforms.

  • platform/MIMETypeRegistry.cpp: Defined generic getMIMETypeForExtension() calling getMIMETypeForExtensionThreadSafe() for enabled FILE_SYSTEM and WORKERS. (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
  • platform/MIMETypeRegistry.h: Declared getMIMETypeForExtensionThreadSafe() which should be implemented for each platform.
  • platform/android/TemporaryLinkStubs.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
  • platform/brew/MIMETypeRegistryBrew.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
  • platform/chromium/MIMETypeRegistryChromium.cpp: Defined getMIMETypeForExtensionThreadSafe() for the case when FILE_SYSTEM and WORKERS are enabled. (WebCore::MIMETypeRegistry::getMIMETypeForExtensionThreadSafe):
  • platform/efl/MIMETypeRegistryEfl.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
  • platform/gtk/MIMETypeRegistryGtk.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
  • platform/haiku/MIMETypeRegistryHaiku.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
  • platform/mac/MIMETypeRegistryMac.mm: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
  • platform/qt/MIMETypeRegistryQt.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
  • platform/win/MIMETypeRegistryWin.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
  • platform/wince/MIMETypeRegistryWinCE.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
  • platform/wx/MimeTypeRegistryWx.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
12:13 AM Changeset in webkit [77367] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-02 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

[Chromium] Propagate the accurate gesture status when calling into FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=53571

  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::loadFrameRequest): FrameLoader might decide the target is a new window, so make such the UserGestureIndicator is fully accurate before calling into it.
12:00 AM Changeset in webkit [77366] by abarth@webkit.org
  • 10 edits in trunk/Source/WebCore

2011-02-01 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Improve readability of updateWidget by converting bool parameter to an enum
https://bugs.webkit.org/show_bug.cgi?id=53576

As requested on webkit-dev.

  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::updateWidget):
  • html/HTMLEmbedElement.h:
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::updateWidget):
  • html/HTMLMediaElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::updateWidget):
  • html/HTMLObjectElement.h:
  • html/HTMLPlugInImageElement.cpp: (WebCore::HTMLPlugInImageElement::updateWidgetIfNecessary):
  • html/HTMLPlugInImageElement.h:
  • page/FrameView.cpp: (WebCore::FrameView::updateWidget):

Feb 1, 2011:

11:06 PM Changeset in webkit [77365] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebKit2

Unreviewed.

Fix Qt build after r77339.

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::enterAcceleratedCompositingMode):
(QWKPagePrivate::exitAcceleratedCompositingMode):

  • UIProcess/API/qt/qwkpage_p.h:
11:02 PM Changeset in webkit [77364] by commit-queue@webkit.org
  • 4 edits in trunk

2011-02-01 James Robinson <jamesr@chromium.org>

Reviewed by Adam Barth.

[v8] Increase V8 native->js recursion limit to match document.write() recursion limit
https://bugs.webkit.org/show_bug.cgi?id=53566

Unskip test that we now pass.

  • platform/chromium/test_expectations.txt:

2011-02-01 James Robinson <jamesr@chromium.org>

Reviewed by Adam Barth.

[v8] Increase V8 native->js recursion limit to match document.write() recursion limit
https://bugs.webkit.org/show_bug.cgi?id=53566

A recursion limit of 22 is necessary to pass fast/dom/Document/document-write-recursion.html.
Other than being large enough for this one test case, this limit is arbitrary.

  • bindings/v8/V8Proxy.h:
10:00 PM Changeset in webkit [77363] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-02-01 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

make draft comments focusable
https://bugs.webkit.org/show_bug.cgi?id=53554

Makes frozen draft comments focusable. The ones that are currently being edited are not.
I'm on the fence whether they should be, but this seems good enough for now.

  • code-review.js:
9:17 PM Changeset in webkit [77362] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-02-01 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

avoid jitter when loading the comments to a patch
https://bugs.webkit.org/show_bug.cgi?id=53570

  • code-review.js:
9:13 PM Changeset in webkit [77361] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-01 Adam Barth <abarth@webkit.org>

Reviewed by Andreas Kling.

Remove useless comment
https://bugs.webkit.org/show_bug.cgi?id=53549

The reason for this parameter is captured in
plugins/netscape-plugin-setwindow-size.html, which is a better place to
capture it than in this comment (which otherwise just re-iterates the
name of the parameter).

  • html/HTMLPlugInImageElement.cpp: (WebCore::HTMLPlugInImageElement::updateWidgetIfNecessary):
9:05 PM Changeset in webkit [77360] by ggaren@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

2011-02-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77297.
http://trac.webkit.org/changeset/77297
https://bugs.webkit.org/show_bug.cgi?id=53538

caused leopard crashes (Requested by paroga on #webkit).

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • wtf/text/AtomicString.cpp: (WTF::AtomicString::fromUTF8):
  • wtf/unicode/UTF8.cpp: (WTF::Unicode::calculateStringHashFromUTF8):
  • wtf/unicode/UTF8.h:
7:42 PM Changeset in webkit [77359] by mrowe@apple.com
  • 1 copy in tags/Safari-533.20.21

New tag.

7:28 PM EFLWebKit edited by gyuyoung.kim@samsung.com
Root CMakeLists.txt was moved to Source directory. (diff)
7:02 PM Changeset in webkit [77358] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-01 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

fast/css/box-shadow.html was removed in r77101 but there was
still a reference to it in the expectations file.

  • platform/chromium/test_expectations.txt:
6:57 PM Changeset in webkit [77357] by simonjam@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-02-01 James Simonsen <simonjam@chromium.org>

Reviewed by Tony Gentilcore.

[WebTiming] Remove asserts that verify timestamp order
https://bugs.webkit.org/show_bug.cgi?id=53548

Covered by existing tests.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): Remove assert.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchTimedEvent): Ditto.
6:50 PM Changeset in webkit [77356] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

2011-02-01 Dimitri Glazkov <Dimitri Glazkov>

Add the 'default_targets' enclosure to the flags.

  • WebCore.gyp/WebCore.gyp: Did it.
6:39 PM Changeset in webkit [77355] by mihaip@chromium.org
  • 7 edits
    2 adds in trunk

2011-02-01 Mihai Parparita <mihaip@chromium.org>

Reviewed by James Robinson.

Async event handlers should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53202

Add tests for a scroll event triggered right before a modal dialog is
shown.

  • fast/events/scroll-event-during-modal-dialog-expected.txt: Added.
  • fast/events/scroll-event-during-modal-dialog.html: Added.

2011-02-01 Mihai Parparita <mihaip@chromium.org>

Reviewed by James Robinson.

Async event handlers should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53202

Asychronous events that use EventQueue would currently fire while a
modal dialog (e.g. window.alert()) was up. Change EventQueue to use a
SuspendableTimer (which automatically gets suspended while dialogs are
up and in other cases where JS execution is not allowed).

Test: fast/events/scroll-event-during-modal-dialog.html

  • dom/Document.cpp: (WebCore::Document::Document):
  • dom/EventQueue.cpp: (WebCore::EventQueueTimer::EventQueueTimer): (WebCore::EventQueueTimer::fired): (WebCore::EventQueue::EventQueue): (WebCore::EventQueue::enqueueEvent): (WebCore::EventQueue::pendingEventTimerFired):
  • dom/EventQueue.h: (WebCore::EventQueue::create):
  • page/SuspendableTimer.cpp: (WebCore::SuspendableTimer::SuspendableTimer): (WebCore::SuspendableTimer::suspend): (WebCore::SuspendableTimer::resume):
  • page/SuspendableTimer.h:
6:35 PM Changeset in webkit [77354] by jschuh@chromium.org
  • 1 edit in branches/chromium/597/WebCore/bindings/v8/V8NPUtils.cpp

Merge 76264
BUG=69970

6:32 PM Changeset in webkit [77353] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-02-01 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

new-run-webkit-tests: stop skipping so many tests

r77163 introduced a regression where we weren't resetting test
expectations properly and were skipping too many tests as a
result. This patch fixes that and adds a test for it.

https://bugs.webkit.org/show_bug.cgi?id=53551

  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
6:23 PM Changeset in webkit [77352] by jschuh@chromium.org
  • 2 edits in branches/chromium/597/WebCore/rendering

Merge 75810
BUG=69556

6:18 PM Changeset in webkit [77351] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-02-01 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

Change wrong PLATFORM(WIN) to USE(WININET)
https://bugs.webkit.org/show_bug.cgi?id=53547

  • platform/network/ResourceHandle.h:
6:05 PM Changeset in webkit [77350] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

32-bit build fix.

  • platform/mac/ScrollAnimatorMac.mm:

(-[ScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]):

6:04 PM Changeset in webkit [77349] by mrowe@apple.com
  • 7 edits in branches/safari-533.20-branch

Build fix.

6:04 PM Changeset in webkit [77348] by jschuh@chromium.org
  • 4 edits in branches/chromium/597/WebCore

Merge 76990
BUG=68120

5:53 PM Changeset in webkit [77347] by tkent@chromium.org
  • 4 edits in trunk

2011-02-01 Kent Tamura <tkent@chromium.org>

Reviewed by Tony Chang.

[Chromium] Roll Chromium revision for the WebKitWeightWatcher change
https://bugs.webkit.org/show_bug.cgi?id=53563

  • platform/chromium/test_expectations.txt: fast/css/font-weight-1.html is expected to fail.

2011-02-01 Kent Tamura <tkent@chromium.org>

Reviewed by Tony Chang.

[Chromium] Roll Chromium revision for the WebKitWeightWatcher change
https://bugs.webkit.org/show_bug.cgi?id=53563

  • DEPS: Roll to crrev.com/73378 to have the WebKitWeightWatcher change of webkit_support.
5:49 PM Changeset in webkit [77346] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-02-01 Dimitri Glazkov <Dimitri Glazkov>

Marking test, added in r77333 as skipped, because it is
reaching V8 recursion limits faster than those on Document.

  • platform/chromium/test_expectations.txt: See above.
5:45 PM Changeset in webkit [77345] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-02-01 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Attach the layer tree in the UI process
https://bugs.webkit.org/show_bug.cgi?id=53560

  • UIProcess/API/mac/WKView.mm: (-[WKView _enterAcceleratedCompositingMode:]): Make a render layer and add it as a sublayer of our root layer.
  • WebProcess/WebPage/mac/LayerTreeHostMac.h: Make LayerTreeHostMac a GraphicsLayerClient.
  • WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::LayerTreeHostMac): Create a root layer, add the layer subtree as a child of the root layer.

(WebKit::LayerTreeHostMac::~LayerTreeHostMac):
Assert that m_rootLayer is null.

(WebKit::LayerTreeHostMac::invalidate):
Null out m_rootLayer.

(WebKit::LayerTreeHostMac::notifyAnimationStarted):
(WebKit::LayerTreeHostMac::notifySyncRequired):
(WebKit::LayerTreeHostMac::paintContents):
Add stubs.

(WebKit::LayerTreeHostMac::showDebugBorders):
(WebKit::LayerTreeHostMac::showRepaintCounter):
Return the correct settings.

(WebKit::LayerTreeHostMac::flushPendingLayerChanges):
Flush the root layer changes.

5:41 PM Changeset in webkit [77344] by jschuh@chromium.org
  • 1 edit in branches/chromium/597/WebCore/rendering/RenderBox.cpp

Merge 75823
BUG=67968

5:31 PM Changeset in webkit [77343] by mrobinson@webkit.org
  • 4 edits in trunk

2011-01-25 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Two tests crash after r76555
https://bugs.webkit.org/show_bug.cgi?id=53057

  • platform/gtk/Skipped: Unskip tests which are no longer crashing.

2011-01-25 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Two tests crash after r76555
https://bugs.webkit.org/show_bug.cgi?id=53057

Instead of creating synchronous ResourceHandles manually, use the ::create factory.
This ensures that ::start() is not called when there is a scheduled failure and also
reduces code duplication.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::loadResourceSynchronously): Use the ::create factory method.
5:25 PM Changeset in webkit [77342] by jschuh@chromium.org
  • 1 edit in branches/chromium/597/WebCore/page/animation/AnimationController.cpp

Merge 76708
BUG=67234

5:16 PM Changeset in webkit [77341] by dpranke@chromium.org
  • 3 edits
    1 add in trunk/Tools

2011-02-01 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: add first stub of test_runner2. This
will add support for the 'inline', 'threads', and 'processes'
flags to --worker-model, but for now the implementatios just
fall back on the old ones.

https://bugs.webkit.org/show_bug.cgi?id=53157

  • Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
5:12 PM Changeset in webkit [77340] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-01 Ojan Vafai <ojan@chromium.org>

Reviewed by Mihai Parparita.

[codereviewtool] extra space at the beginning of lines in side-by-side view
https://bugs.webkit.org/show_bug.cgi?id=53550

The newline between the spans turns into user-visible space in side-by-side mode.

  • PrettyPatch/PrettyPatch.rb:
5:11 PM Changeset in webkit [77339] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Fix Windows build.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::enterAcceleratedCompositingMode):
(WebKit::WebView::exitAcceleratedCompositingMode):

  • UIProcess/win/WebView.h:
5:09 PM Changeset in webkit [77338] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-01 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Add a layer backed NSView for accelerated content
https://bugs.webkit.org/show_bug.cgi?id=53555

Rename the current _layerHostingView to _oldLayerHostingView and
add a new _layerHostingView to be used with the new drawing area.

  • UIProcess/API/mac/WKView.mm: (-[WKView hitTest:]): (-[WKView _startAcceleratedCompositing:]): (-[WKView _stopAcceleratedCompositing]): (-[WKView _enterAcceleratedCompositingMode:]): (-[WKView _exitAcceleratedCompositingMode]):
5:04 PM Changeset in webkit [77337] by mrobinson@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] GObject DOM bindings do no support the CallWith attribute
https://bugs.webkit.org/show_bug.cgi?id=53331

Disable building GObject DOM bindings for IndexedDB because we do not support
the CallWith attribute at this time.

  • bindings/gobject/GNUmakefile.am: Disable building bindings for the IndexedDB API.
5:01 PM Changeset in webkit [77336] by Darin Adler
  • 3 edits in trunk/Source/WebCore

2011-02-01 Darin Adler <Darin Adler>

Reviewed by Brady Eidson.

Fix a couple loose ends from the back/forward tree encode/decode work
https://bugs.webkit.org/show_bug.cgi?id=53537

  • history/HistoryItem.cpp: (WebCore::HistoryItem::encodeBackForwardTreeNode): Remove extra copy of original URL string; no need to encode it twice. (WebCore::HistoryItem::decodeBackForwardTree): Ditto.
  • history/HistoryItem.h: Removed declaration for function that is no longer defined nor used.
4:55 PM Changeset in webkit [77335] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-01 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] disable arm uninitialized variable warnings
https://bugs.webkit.org/show_bug.cgi?id=53553

We just got another error:
third_party/WebKit/Source/WebCore/css/CSSPrimitiveValue.cpp:123:error:
'colorTransparent.unstatic.4879' may be used uninitialized in this
function

  • WebCore.gyp/WebCore.gyp:
4:48 PM Changeset in webkit [77334] by andersca@apple.com
  • 9 edits in trunk/Source/WebKit2

2011-02-01 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Pass enter/exit accelerated compositing mode to the WKView
https://bugs.webkit.org/show_bug.cgi?id=53552

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::enterAcceleratedCompositingMode): (WebKit::PageClientImpl::exitAcceleratedCompositingMode):
  • UIProcess/API/mac/WKView.mm: (-[WKView _enterAcceleratedCompositingMode:]): (-[WKView _exitAcceleratedCompositingMode]):
  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode): (WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::enterAcceleratedCompositingMode): (WebKit::WebPageProxy::exitAcceleratedCompositingMode):
  • UIProcess/WebPageProxy.h:
4:22 PM Changeset in webkit [77333] by commit-queue@webkit.org
  • 4 edits
    6 adds in trunk

2011-02-01 chris reiss <christopher.reiss@nokia.com>

Reviewed by Adam Barth.

Self-replicating code makes Safari hang and eventually crash
https://bugs.webkit.org/show_bug.cgi?id=15123

  • fast/dom/Document/document-close-iframe-load-expected.txt: Added.
  • fast/dom/Document/document-close-iframe-load.html: Added.
  • fast/dom/Document/document-close-nested-iframe-load-expected.txt: Added.
  • fast/dom/Document/document-close-nested-iframe-load.html: Added.
  • fast/dom/Document/document-write-recursion-expected.txt: Added.
  • fast/dom/Document/document-write-recursion.html: Added.

2011-02-01 chris reiss <christopher.reiss@nokia.com>

Reviewed by Adam Barth.

Self-replicating code makes Safari hang and eventually crash
https://bugs.webkit.org/show_bug.cgi?id=15123

Here we are replicating the Firefox safeguard against
recursive document.write( ) 's.

See https://bug197052.bugzilla.mozilla.org/attachment.cgi?id=293907 in bug
https://bugzilla.mozilla.org/show_bug.cgi?id=197052 . Firefox does two things -

a) imposes a recursion limit of 20 on document.write( ) and
b) once that limit is passed, panics all the way the call stack (rather than just returning one level.)

To see why this is necessary, consider the script :

<script>

var t = document.body.innerHTML;
document.write(t);

</script>

This will create a tree both broad and deep as the script keeps appending itself to the text. If
we just return one level after the recursion limit is reached, we still allow millions of copies to
duplicate (and execute).

The recursion is fortunately depth-first, so as soon as we cross this limit, we panic up the callstack
to prevent this situation. (IE apparently does the same thing, with a lower recursion limit.)

Test: fast/dom/Document/document-write-recursion.html
Test: fast/dom/Document/document-close-iframe-load.html
Test: fast/dom/Document/document-close-nested-iframe-load.html

  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::write):
  • dom/Document.h:
4:12 PM Changeset in webkit [77332] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-02-01 Dimitri Glazkov <Dimitri Glazkov>

Updated text expectations to avoid conflict.

  • platform/chromium/test_expectations.txt: Tweaked.
4:05 PM Changeset in webkit [77331] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-01 Ojan Vafai <ojan@chromium.org>

Increment version number to cache-bust code-review.js.

  • PrettyPatch/PrettyPatch.rb:
4:00 PM Changeset in webkit [77330] by ojan@chromium.org
  • 2 edits
    1 add in trunk/Websites/bugs.webkit.org

2011-01-31 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

Store draft comments in localStorage
https://bugs.webkit.org/show_bug.cgi?id=52866

  • code-review.js:
  • code-review-test.html
3:52 PM Changeset in webkit [77329] by jnd@chromium.org
  • 3 edits
    2 adds in trunk

2011-02-01 Johnny Ding <jnd@chromium.org>

Reviewed by Darin Adler.

Don't set user gesture in HTMLAnchorElement's click handler because the click handler can be triggered by untrusted event.
https://bugs.webkit.org/show_bug.cgi?id=53424

  • fast/events/popup-blocked-from-untrusted-click-event-on-anchor-expected.txt: Added.
  • fast/events/popup-blocked-from-untrusted-click-event-on-anchor.html: Added.

2011-02-01 Johnny Ding <jnd@chromium.org>

Reviewed by Darin Adler.

Don't set user gesture in HTMLAnchorElement's click handler because the click handler can be triggered by untrusted event.
https://bugs.webkit.org/show_bug.cgi?id=53424

Test: fast/events/popup-blocked-from-untrusted-click-event-on-anchor.html

  • html/HTMLAnchorElement.cpp: (WebCore::handleLinkClick):
3:50 PM Changeset in webkit [77328] by Csaba Osztrogonác
  • 6 edits in trunk/Source

Unreviewed Qt buildfix after r77286.

https://bugs.webkit.org/show_bug.cgi?id=53520
Remove the physical terminology from IntRect and FloatRect.

Source/WebCore:

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::createTiles):

Source/WebKit/qt:

  • WebCoreSupport/PopupMenuQt.cpp:

(WebCore::PopupMenuQt::show):

Source/WebKit2:

  • UIProcess/qt/ChunkedUpdateDrawingAreaProxyQt.cpp:

(WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore):

3:46 PM Changeset in webkit [77327] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-01 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
3:41 PM Changeset in webkit [77326] by mrowe@apple.com
  • 2 edits in branches/safari-533.20-branch/WebCore

Merge r71769.

3:41 PM Changeset in webkit [77325] by mrowe@apple.com
  • 17 edits
    8 adds
    4 deletes in branches/safari-533.20-branch

Merge r71767.

3:32 PM Changeset in webkit [77324] by Patrick Gansterer
  • 5 edits in trunk/Source/JavaScriptCore

2011-02-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77297.
http://trac.webkit.org/changeset/77297
https://bugs.webkit.org/show_bug.cgi?id=53538

caused leopard crashes (Requested by paroga on #webkit).

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • wtf/text/AtomicString.cpp: (WTF::AtomicString::fromUTF8):
  • wtf/unicode/UTF8.cpp: (WTF::Unicode::calculateStringHashFromUTF8):
  • wtf/unicode/UTF8.h:
3:26 PM Changeset in webkit [77323] by Dimitri Glazkov
  • 10 edits in trunk/LayoutTests

2011-02-01 Dimitri Glazkov <Dimitri Glazkov>

Updated baselines after switching input-derived parts of HTMLMediaElement
to use shadow DOM.
https://bugs.webkit.org/show_bug.cgi?id=53314

  • platform/chromium-linux/media/video-zoom-controls-expected.checksum: Updated.
  • platform/chromium-linux/media/video-zoom-controls-expected.png: Updated.
  • platform/chromium-mac/media/video-zoom-controls-expected.checksum: Updated.
  • platform/chromium-mac/media/video-zoom-controls-expected.png: Updated.
  • platform/chromium-mac/media/video-zoom-controls-expected.txt: Updated.
  • platform/chromium-win/media/video-zoom-controls-expected.checksum: Updated.
  • platform/chromium-win/media/video-zoom-controls-expected.png: Updated.
  • platform/chromium-win/media/video-zoom-controls-expected.txt: Updated.
  • platform/chromium/test_expectations.txt: Expectation of failure removed.
3:20 PM Changeset in webkit [77322] by weinig@apple.com
  • 7 edits in trunk/Source

Fix Mac production builds.

../JavaScriptCore:

../WebCore:

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollbarThemeMac.h:
3:05 PM Changeset in webkit [77321] by inferno@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

2011-02-01 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Test not crashing on chromium, was crashing earlier because of
some build issues. Also, rebaselining chromium mac since it matches
rest of chromium and is not same as mac leopard.
https://bugs.webkit.org/show_bug.cgi?id=53516

  • platform/chromium-mac/fast/css/stylesheet-candidate-nodes-crash-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
3:04 PM Changeset in webkit [77320] by darin@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-02-01 Darin Fisher <darin@chromium.org>

Reviewed by David Levin.

[chromium] Remove unnecessary WebCore
prefixing in a few places and fix-up some indentation. https://bugs.webkit.org/show_bug.cgi?id=53523
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::attach): (WebKit::WebDevToolsAgentImpl::inspectNode): (WebKit::WebDevToolsAgentImpl::inspectorController): (WebKit::WebDevToolsAgentImpl::mainFrame): (WebKit::WebDevToolsAgentImpl::identifierForInitialRequest): (WebKit::WebDevToolsAgentImpl::sendMessageToFrontend): (WebKit::WebDevToolsAgentImpl::updateInspectorStateCookie): (WebKit::WebDevToolsAgent::interruptAndDispatch): (WebKit::WebDevToolsAgent::processPendingMessages):
  • src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::resize):
  • src/WebScrollbarImpl.cpp: (WebKit::WebScrollbarImpl::setLocation): (WebKit::WebScrollbarImpl::setValue): (WebKit::WebScrollbarImpl::onMouseWheel): (WebKit::WebScrollbarImpl::onKeyDown): (WebKit::WebScrollbarImpl::scrollPosition): (WebKit::WebScrollbarImpl::setScrollOffset): (WebKit::WebScrollbarImpl::invalidateScrollbarRect): (WebKit::WebScrollbarImpl::getTickmarks):
3:02 PM Changeset in webkit [77319] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r73620.

2:59 PM Changeset in webkit [77318] by mrowe@apple.com
  • 5 edits
    2 adds in branches/safari-533.20-branch

Merge r73559.

2:56 PM Changeset in webkit [77317] by hyatt@apple.com
  • 1 edit in trunk/Source/WebKit2/UIProcess/qt/TiledDrawingAreaTileQt.cpp

Fix Qt bustage.

2:52 PM Changeset in webkit [77316] by hyatt@apple.com
  • 1 edit in trunk/Source/WebKit/qt/Api/qwebframe.cpp

Fix Qt bustage.

2:51 PM Changeset in webkit [77315] by andersca@apple.com
  • 8 edits
    2 adds in trunk/Source/WebKit2

2011-02-01 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Send messages when entering/exiting accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=53534

  • Shared/LayerTreeContext.h: Added.
  • Shared/mac/LayerTreeContextMac.mm: Added. Add new LayerTreeContext which holds all information needed to enter accelerated compositing mode.
  • UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::enterAcceleratedCompositingMode): (WebKit::DrawingAreaProxy::exitAcceleratedCompositingMode): Add empty stubs.
  • UIProcess/DrawingAreaProxy.messages.in: Add new messgaes.
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode): (WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
  • UIProcess/DrawingAreaProxyImpl.h: Add empty stubs.
  • WebKit2.xcodeproj/project.pbxproj: Add new files.
  • WebProcess/WebPage/mac/LayerTreeHostMac.h:
  • WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::LayerTreeHostMac): (WebKit::LayerTreeHostMac::invalidate): Send messages.
2:49 PM Changeset in webkit [77314] by mrowe@apple.com
  • 6 edits
    2 adds in branches/safari-533.20-branch

Merge r71431.

2:49 PM Changeset in webkit [77313] by Darin Adler
  • 6 edits
    2 adds in trunk

2011-02-01 Darin Adler <Darin Adler>

Reviewed by Chris Fleizach.

REGRESSION: Removing focus from area element causes unwanted scrolling
https://bugs.webkit.org/show_bug.cgi?id=50169

Test: fast/images/imagemap-scroll.html

  • html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::setFocus): Added override. Calls the new RenderImage::areaElementFocusChanged function. (WebCore::HTMLAreaElement::updateFocusAppearance): Removed the code here that calls setNeedsLayout on the image's renderer. This was an attempt to cause repaint of the renderer, but this function does not need to do that. Also changed this to use the imageElement function to avoid repeating code.
  • html/HTMLAreaElement.h: Updated for above changes.
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint): Updated for name change. (WebCore::RenderImage::paintAreaElementFocusRing): Renamed this from paintFocusRing, because it only paints area focus rings, and should not be confused with paintFocusRing functions in other classes. Also removed the unused style argument. Removed the code that used an HTMLCollection to see if the focused area element is for this image and instead just call imageElement on the area element. (WebCore::RenderImage::areaElementFocusChanged): Added. Calls repaint.
  • rendering/RenderImage.h: Added a public areaElementFocusChanged function for HTMLAreaElement to call. Made the paintFocusRing function private, renamed it to paintAreaElementFocusRing, and removed its unused style argument.

2011-02-01 Darin Adler <Darin Adler>

Reviewed by Chris Fleizach.

REGRESSION: Removing focus from area element causes unwanted scrolling
https://bugs.webkit.org/show_bug.cgi?id=50169

  • fast/images/imagemap-scroll-expected.txt: Added.
  • fast/images/imagemap-scroll.html: Added.
2:48 PM Changeset in webkit [77312] by hyatt@apple.com
  • 1 edit in trunk/Source/WebCore/platform/graphics/TiledBackingStore.cpp

Fix Qt bustage.

2:42 PM Changeset in webkit [77311] by zmo@google.com
  • 5 edits
    2 adds in trunk

2011-02-01 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

getUniform should support SAMPLER_2D or SAMPLER_CUBE
https://bugs.webkit.org/show_bug.cgi?id=52190

  • fast/canvas/webgl/gl-object-get-calls-expected.txt:
  • fast/canvas/webgl/gl-object-get-calls.html: Test getUniform with sampler2D and samplerCube uniforms.
  • fast/canvas/webgl/resources/noopUniformShader.vert: Added.
  • fast/canvas/webgl/resources/samplerUniformShader.frag: Added.

2011-02-01 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE build fix for r77286.

  • platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::TransparentLayerDC::TransparentLayerDC):
2:42 PM Changeset in webkit [77310] by mrowe@apple.com
  • 7 edits
    2 adds in branches/safari-533.20-branch

Merge r70792.

2:39 PM Changeset in webkit [77309] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-02-01 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE build fix for r77286.

  • platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::TransparentLayerDC::TransparentLayerDC):
2:37 PM Changeset in webkit [77308] by Chris Fleizach
  • 6 edits
    2 adds in trunk

AX: AXPosition of AXScrollArea is wrong
https://bugs.webkit.org/show_bug.cgi?id=53511

Reviewed by Darin Adler.

Source/WebCore:

AccessibilityScrollView needed to return a valid documentFrameView() object.
At the same time, the code from document() should be consolidated in
AccessibilityObject, so all objects can use it.

Test: platform/mac/accessibility/webkit-scrollarea-position.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::document):

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::accessibilityHitTest):
(WebCore::AccessibilityScrollView::documentFrameView):

  • accessibility/AccessibilityScrollView.h:

LayoutTests:

  • platform/mac/accessibility/webkit-scrollarea-position-expected.txt: Added.
  • platform/mac/accessibility/webkit-scrollarea-position.html: Added.
2:33 PM Changeset in webkit [77307] by mrowe@apple.com
  • 7 edits
    2 adds in branches/safari-533.20-branch

Merge r69033.

2:30 PM Changeset in webkit [77306] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Reviewed by Dan Bernstein and Darin Adler.

<rdar://problem/8830594> Printed page is sometimes shifted down, making footer invisible

  • UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView locationOfPrintRect:]): Instead of letting AppKit compute content position on page, make the view provide it. We can do this because WK(Printing)Views are always printed on their own, not as part of other views.
2:29 PM Changeset in webkit [77305] by zmo@google.com
  • 2 edits in trunk/Source/WebCore

2011-02-01 Zhenyao Mo <zmo@google.com>

Reviewed by Darin Adler.

Fix the incorrect usage of RetainPtr cases in GraphicsContext3DCG.cpp
https://bugs.webkit.org/show_bug.cgi?id=53531

With this fix, running WebGL conformance tests should no longer crash randomly.

  • platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::GraphicsContext3D::getImageData):
2:23 PM Changeset in webkit [77304] by mrowe@apple.com
  • 15 edits
    5 adds in branches/safari-533.20-branch

Merge r70335.

2:21 PM Changeset in webkit [77303] by mrowe@apple.com
  • 8 edits
    2 adds in branches/safari-533.20-branch

Merge r68541.

2:14 PM Changeset in webkit [77302] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

2011-02-01 Dimitri Glazkov <Dimitri Glazkov>

One more Chromium build fix after r77286.

  • platform/chromium/ScrollbarThemeChromiumMac.mm: (WebCore::ScrollbarThemeChromiumMac::paint): Changed to not use topLeft().
2:12 PM Changeset in webkit [77301] by weinig@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Try to fix the windows build.

  • DerivedSources.make:
2:11 PM Changeset in webkit [77300] by hyatt@apple.com
  • 1 edit in trunk/Source/WebKit2/UIProcess/TiledDrawingAreaProxy.cpp

Fix Qt bustage.

2:07 PM Changeset in webkit [77299] by mrowe@apple.com
  • 14 edits
    1 add in branches/safari-533.20-branch

Merge r74524.

2:04 PM Changeset in webkit [77298] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the build for Beth.

  • platform/mac/ScrollAnimatorMac.mm:

(-[ScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]):

2:03 PM Changeset in webkit [77297] by Patrick Gansterer
  • 5 edits in trunk/Source/JavaScriptCore

2011-02-01 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Avoid strlen() in AtomicString::fromUTF8
https://bugs.webkit.org/show_bug.cgi?id=50516

Add an overload to calculateStringHashFromUTF8 to get
strlen() of the input data with only one call.

This change shows about 3% performance win on the xml-parser benchmark.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • wtf/text/AtomicString.cpp: (WTF::AtomicString::fromUTF8):
  • wtf/unicode/UTF8.cpp: (WTF::Unicode::calculateStringHashAndLengthFromUTF8Internal): (WTF::Unicode::calculateStringHashFromUTF8): (WTF::Unicode::calculateStringHashAndLengthFromUTF8):
  • wtf/unicode/UTF8.h:
2:02 PM Changeset in webkit [77296] by mrowe@apple.com
  • 2 edits
    2 copies in branches/safari-533.20-branch/LayoutTests

Merge r66796.

2:02 PM Changeset in webkit [77295] by mrowe@apple.com
  • 4 edits
    2 adds in branches/safari-533.20-branch

Merge r66795.

2:02 PM Changeset in webkit [77294] by mrowe@apple.com
  • 15 edits in branches/safari-533.20-branch/WebCore

Merge r66115.

1:57 PM Changeset in webkit [77293] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

2011-02-01 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Make LayerTreeHost ref counted
https://bugs.webkit.org/show_bug.cgi?id=53530

LayerTreeHostMac will soon be able to trigger layout, which could cause
the page to leave accelerated compositing mode and free the LayerTreeHostMac object.

Making LayerTreeHost ref counted will let LayerTreeHostMac protect itself while triggering layout.

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setRootCompositingLayer):
  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/LayerTreeHost.cpp: (WebKit::LayerTreeHost::create):
  • WebProcess/WebPage/LayerTreeHost.h:
  • WebProcess/WebPage/mac/LayerTreeHostMac.h:
  • WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::create): (WebKit::LayerTreeHostMac::LayerTreeHostMac): (WebKit::LayerTreeHostMac::~LayerTreeHostMac): (WebKit::LayerTreeHostMac::invalidate):
1:56 PM Changeset in webkit [77292] by hyatt@apple.com
  • 1 edit in trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp

Fix chromium bustage.

1:51 PM Changeset in webkit [77291] by hyatt@apple.com
  • 1 edit in trunk/Source/WebCore/platform/qt/RenderThemeQt.cpp

Fix Qt build bustage.

1:50 PM Changeset in webkit [77290] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r75882.

1:50 PM Changeset in webkit [77289] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r73799, r73805 and r73818.

1:47 PM Changeset in webkit [77288] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-02-01 Dimitri Glazkov <Dimitri Glazkov>

Added yet another expectations of flakiness.
https://bugs.webkit.org/show_bug.cgi?id=53527

  • platform/chromium/test_expectations.txt: Flakiness abound.
1:45 PM Changeset in webkit [77287] by weinig@apple.com
  • 13 edits in trunk/Source

Part 2 for <rdar://problem/8492788>
Adopt WKScrollbarPainterController

Reviewed by Beth Dakin.

Use header detection to define scrollbar painting controller #define.

Source/JavaScriptCore:

Source/WebCore:

  • WebCore.exp.in:
  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollbarThemeMac.h:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

1:39 PM Changeset in webkit [77286] by hyatt@apple.com
  • 67 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=53520

Reviewed by Oliver Hunt.

Remove the physical terminology from IntRect and FloatRect.

Now that we have flipped RenderBlocks for vertical-rl and horizontal-bt writing modes,
we need to update our terminology to be more accurate.

I'm borrowing a page from AppKit here (which also supports flipped NSViews) and
renaming right() and bottom() to maxX() and maxY(). These terms remain accurate
even for flipped rectangles.

../WebCore:

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::boundsForVisiblePositionRange):

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper position]):

  • dom/ClientRect.h:

(WebCore::ClientRect::right):
(WebCore::ClientRect::bottom):

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::convertLogicalToDevice):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::normalizeRect):

  • inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::drawElementTitle):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::adjustWindowRect):

  • page/DragController.cpp:

(WebCore::dragLocForSelectionDrag):

  • page/EventHandler.cpp:

(WebCore::EventHandler::sendContextMenuEventForKey):

  • page/PrintContext.cpp:

(WebCore::PrintContext::computePageRectsWithPageSizeInternal):
(WebCore::PrintContext::pageNumberForElement):

  • page/SpatialNavigation.cpp:

(WebCore::end):
(WebCore::areRectsFullyAligned):
(WebCore::areRectsMoreThanFullScreenApart):
(WebCore::below):
(WebCore::rightOf):
(WebCore::isRectInDirection):
(WebCore::entryAndExitPointsForDirection):
(WebCore::virtualRectForDirection):

  • page/WindowFeatures.cpp:

(WebCore::WindowFeatures::WindowFeatures):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::setFrameRect):

  • platform/ScrollbarThemeComposite.cpp:

(WebCore::ScrollbarThemeComposite::splitTrack):

  • platform/chromium/ScrollbarThemeChromium.cpp:

(WebCore::ScrollbarThemeChromium::paintTickmarks):

  • platform/graphics/FloatQuad.h:

(WebCore::FloatQuad::FloatQuad):

  • platform/graphics/FloatRect.cpp:

(WebCore::FloatRect::intersects):
(WebCore::FloatRect::contains):
(WebCore::FloatRect::intersect):
(WebCore::FloatRect::unite):
(WebCore::enclosingIntRect):

  • platform/graphics/FloatRect.h:

(WebCore::FloatRect::maxX):
(WebCore::FloatRect::maxY):
(WebCore::FloatRect::contains):

  • platform/graphics/IntRect.cpp:

(WebCore::IntRect::intersects):
(WebCore::IntRect::contains):
(WebCore::IntRect::intersect):
(WebCore::IntRect::unite):

  • platform/graphics/IntRect.h:

(WebCore::IntRect::maxX):
(WebCore::IntRect::maxY):
(WebCore::IntRect::shiftXEdgeTo):
(WebCore::IntRect::shiftMaxXEdgeTo):
(WebCore::IntRect::shiftYEdgeTo):
(WebCore::IntRect::shiftMaxYEdgeTo):
(WebCore::IntRect::contains):

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::advance):

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::fillRect):

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::getImageData):
(WebCore::putImageData):

  • platform/graphics/cg/ImageCG.cpp:

(WebCore::BitmapImage::draw):

  • platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::copyImageBytes):

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformBoundsForGlyph):

  • platform/graphics/transforms/AffineTransform.cpp:

(WebCore::AffineTransform::mapRect):

  • platform/graphics/win/FontCGWin.cpp:

(WebCore::drawGDIGlyphs):

  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:

(WebCore::MediaPlayerPrivate::paint):

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore::centerRectVerticallyInParentInputElement):

  • platform/mac/WidgetMac.mm:

(WebCore::Widget::paint):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::addBoxShadowVisualOverflow):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::selectionRect):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::positionForOffset):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addOverflowFromChildren):
(WebCore::RenderBlock::paintChildren):
(WebCore::RenderBlock::paintEllipsisBoxes):
(WebCore::RenderBlock::inlineSelectionGaps):
(WebCore::RenderBlock::adjustPointToColumnContents):
(WebCore::RenderBlock::flipForWritingModeIncludingColumns):
(WebCore::RenderBlock::adjustForColumns):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::FloatingObject::right):
(WebCore::RenderBlock::FloatingObject::bottom):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::reflectedRect):
(WebCore::RenderBox::localCaretRect):
(WebCore::RenderBox::addShadowOverflow):
(WebCore::RenderBox::addLayoutOverflow):
(WebCore::RenderBox::visualOverflowRectForPropagation):
(WebCore::RenderBox::layoutOverflowRectForPropagation):
(WebCore::RenderBox::flipForWritingMode):

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::paintColumnBorder):
(WebCore::RenderFrameSet::paintRowBorder):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::paintOutlineForLine):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::getRectToExpose):
(WebCore::cornerRect):
(WebCore::RenderLayer::positionOverflowControls):
(WebCore::RenderLayer::overflowBottom):
(WebCore::RenderLayer::overflowRight):
(WebCore::RenderLayer::paintResizer):

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::rangeIntersectsRect):
(WebCore::RenderLineBoxList::paint):

  • rendering/RenderListItem.cpp:

(WebCore::RenderListItem::positionListMarker):

  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::paint):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::repaintAfterLayoutIfNeeded):

  • rendering/RenderOverflow.h:

(WebCore::RenderOverflow::RenderOverflow):
(WebCore::RenderOverflow::addLayoutOverflow):
(WebCore::RenderOverflow::addVisualOverflow):
(WebCore::RenderOverflow::setLayoutOverflow):
(WebCore::RenderOverflow::setVisualOverflow):
(WebCore::RenderOverflow::resetLayoutOverflow):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::shouldPaint):

  • rendering/RenderScrollbarTheme.cpp:

(WebCore::RenderScrollbarTheme::constrainTrackRectToTrackPieces):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::paint):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paint):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::paintObject):

  • rendering/RenderText.cpp:

(WebCore::RenderText::absoluteQuads):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::forwardEvent):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMenuListButtonGradients):
(WebCore::RenderThemeMac::paintMenuListButton):
(WebCore::RenderThemeMac::paintSliderTrack):

  • rendering/RenderView.cpp:

(WebCore::RenderView::computeRectForRepaint):
(WebCore::RenderView::docBottom):
(WebCore::RenderView::docRight):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::paddedLayoutOverflowRect):

  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::localCaretRect):

../WebKit/mac:

  • WebView/WebHTMLView.mm:

(setNeedsDisplayInRect):

../WebKit2:

  • Platform/Region.cpp:

(WebKit::Region::Shape::Shape):

  • UIProcess/API/mac/WKPrintingView.mm:

(pageDidComputePageRects):

  • UIProcess/FindIndicator.cpp:

(WebKit::FindIndicator::draw):

  • UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::invalidate):
(WebKit::TiledDrawingAreaProxy::paint):
(WebKit::TiledDrawingAreaProxy::createTiles):

  • UIProcess/mac/ChunkedUpdateDrawingAreaProxyMac.mm:

(WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore):

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::callSetWindow):

1:38 PM Changeset in webkit [77285] by inferno@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-02-01 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Rebaseline my test for QT, Leopard from r77262 due
to minor comment error differences.

  • platform/mac-leopard/fast/css/stylesheet-candidate-nodes-crash-expected.txt: Added.
  • platform/qt/fast/css/stylesheet-candidate-nodes-crash-expected.txt: Added.
1:36 PM Changeset in webkit [77284] by mrowe@apple.com
  • 16 edits
    2 adds in branches/safari-533.20-branch

Merge r72230.

1:36 PM Changeset in webkit [77283] by mrowe@apple.com
  • 3 edits in branches/safari-533.20-branch/WebCore

Merge r69125.

1:34 PM Changeset in webkit [77282] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-02-01 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Move flushPendingLayerChanges to LayerTreeHostMac
https://bugs.webkit.org/show_bug.cgi?id=53525

In preparation for adding more Mac specific code to flushPendingLayerChanges.

  • WebProcess/WebPage/LayerTreeHost.cpp:
  • WebProcess/WebPage/LayerTreeHost.h:
  • WebProcess/WebPage/mac/LayerTreeHostMac.h:
  • WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::flushPendingLayerChanges):
1:28 PM Changeset in webkit [77281] by xji@chromium.org
  • 1 edit
    8 adds in trunk/LayoutTests

2011-02-01 Xiaomei Ji <xji@chromium.org>

Unreviewed.

Rebaseline after r77267.

  • platform/chromium-linux/fast/dom/34176-expected.checksum: Added.
  • platform/chromium-linux/fast/dom/34176-expected.png: Added.
  • platform/chromium-mac/fast/dom/34176-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/34176-expected.png: Added.
  • platform/chromium-win/fast/dom/34176-expected.checksum: Added.
  • platform/chromium-win/fast/dom/34176-expected.png: Added.
  • platform/chromium-win/fast/dom/34176-expected.txt: Added.
  • platform/win/fast/dom/34176-expected.txt: Added.
1:26 PM Changeset in webkit [77280] by mrowe@apple.com
  • 5 edits
    7 adds in branches/safari-533.20-branch

Merge r74854.

1:15 PM Changeset in webkit [77279] by mihaip@chromium.org
  • 2 edits in trunk/Tools

2011-02-01 Mihai Parparita <mihaip@chromium.org>

Reviewed by James Robinson.

[Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
https://bugs.webkit.org/show_bug.cgi?id=53522

  • Scripts/run-chromium-webkit-unit-tests:
12:50 PM Changeset in webkit [77278] by xji@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-01 Xiaomei Ji <xji@chromium.org>

Unreviewed.

  • fast/dom/34176.html: Removed properties svn:executable and svn:mime-type.
12:44 PM Changeset in webkit [77277] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-01 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

REGRESSION(77082): GC-related crashes seen: on WebKit2 bot; on GTK 32bit
bot; loading trac pages; typing in search field
https://bugs.webkit.org/show_bug.cgi?id=53519


The crashes were all caused by failure to run an object's destructor.

  • runtime/CollectorHeapIterator.h: (JSC::ObjectIterator::ObjectIterator): Don't skip forward upon construction. The iterator class used to do that when it was designed for prior-to-beginning initialization. I forgot to remove this line of code when I changed the iterator to normal initialization.


Skipping forward upon construction was causing the heap to skip running
the destructor for the very first object in a block when destroying the
block. This usually did not crash, since block destruction is rare and
most objects have pretty trivial destructors. However, in the rare case
when the heap would destroy a block whose first object was a global
object or a DOM node, BOOM.

12:39 PM Changeset in webkit [77276] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-02-01 Dimitri Glazkov <Dimitri Glazkov>

Remove expectations of failure for passing tests.

  • platform/chromium/test_expectations.txt: Fewer fails.
12:35 PM Changeset in webkit [77275] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-02-01 Adam Barth <abarth@webkit.org>

Reviewed by Mihai Parparita.

Using Control-C to cancel webkit-patch or other python tools causes
unpleasant traceback console spew
https://bugs.webkit.org/show_bug.cgi?id=53462

Catch the exception and don't print the stack trace.

  • Scripts/webkit-patch:
12:35 PM Changeset in webkit [77274] by Beth Dakin
  • 27 edits in trunk/Source

Fix for <rdar://problem/8492788> Adopt WKScrollbarPainterController

Reviewed by Sam Weinig.

Source/WebCore:

Lots of new WebCoreSystemInterface functions to export.

  • WebCore.exp.in:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Let the scrollAnimator know when the mouse has
moved anywhere inside the page, and when the mouse
has moved in or out of the window.

  • page/EventHandler.cpp:

(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::updateMouseEventTargetNode):

Let the scrollAnimator know when the window has become
active or inactive.

  • page/FocusController.cpp:

(WebCore::FocusController::setActive):

Let the scrollAnimator know when all of these things
are happening.

  • page/FrameView.cpp:

(WebCore::FrameView::setContentsSize):
(WebCore::FrameView::didMoveOnscreen):
(WebCore::FrameView::willMoveOffscreen):
(WebCore::FrameView::currentMousePosition):
(WebCore::FrameView::contentsResized):

New functions called through WebKit2 that allow the
scrollAnimator to know when a live resize starts and ends.
(WebCore::FrameView::willStartLiveResize):
(WebCore::FrameView::willEndLiveResize):

  • page/FrameView.h:


New functions on ScrollAnimator that pass information
to the WKPainterController when we're using one.

  • platform/ScrollAnimator.h:

(WebCore::ScrollAnimator::scrollableArea):
(WebCore::ScrollAnimator::contentAreaWillPaint):
(WebCore::ScrollAnimator::mouseEnteredContentArea):
(WebCore::ScrollAnimator::mouseExitedContentArea):
(WebCore::ScrollAnimator::mouseMovedInContentArea):
(WebCore::ScrollAnimator::willStartLiveResize):
(WebCore::ScrollAnimator::contentsResized):
(WebCore::ScrollAnimator::willEndLiveResize):
(WebCore::ScrollAnimator::contentAreaDidShow):
(WebCore::ScrollAnimator::contentAreaDidHide):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::scrollbarPainterDelegate):
(WebCore::ScrollAnimatorMac::setPainterForPainterController):
(WebCore::ScrollAnimatorMac::removePainterFromPainterController):
(WebCore::ScrollAnimatorMac::notityPositionChanged):
(WebCore::ScrollAnimatorMac::contentAreaWillPaint):
(WebCore::ScrollAnimatorMac::mouseEnteredContentArea):
(WebCore::ScrollAnimatorMac::mouseExitedContentArea):
(WebCore::ScrollAnimatorMac::mouseMovedInContentArea):
(WebCore::ScrollAnimatorMac::willStartLiveResize):
(WebCore::ScrollAnimatorMac::contentsResized):
(WebCore::ScrollAnimatorMac::willEndLiveResize):
(WebCore::ScrollAnimatorMac::contentAreaDidShow):
(WebCore::ScrollAnimatorMac::contentAreaDidHide):

Let the scrollAnimator know when this is happening.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::paint):

New function lets the scrollAnimator get the current
mouse position.

  • platform/ScrollView.h:

(WebCore::ScrollView::currentMousePosition):

New function that returns the scrollAnimator when needed.

  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::scrollAnimator):

Keep track of if we're in a live resize using a new memeber
variable.

  • platform/mac/ScrollAnimatorMac.h:

(WebCore::ScrollAnimatorMac::inLiveResize):

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::view):

New delegates for the WKPainter and WKPainterController
(-[ScrollbarPainterControllerDelegate initWithScrollAnimator:WebCore::]):
(-[ScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate mouseLocationInContentAreaForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):
(-[ScrollbarPainterControllerDelegate scrollerImpPair:setContentAreaNeedsDisplayInRect:]):
(-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):
(-[ScrollKnobAnimation initWithScrollbarPainter:forScrollAnimator:WebCore::animateKnobAlphaTo:duration:]):
(-[ScrollKnobAnimation setCurrentProgress:]):
(-[ScrollbarPainterDelegate initWithScrollAnimator:WebCore::]):
(-[ScrollbarPainterDelegate convertRectToBacking:]):
(-[ScrollbarPainterDelegate convertRectFromBacking:]):
(-[ScrollbarPainterDelegate layer]):
(-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]):

Get the WKScrollbarPainterRefs to synch up with the
WKScrollbarPainterControllerRefs when appropriate

  • platform/mac/ScrollbarThemeMac.h:
  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::unregisterScrollbar):
(WebCore::ScrollbarThemeMac::setNewPainterForScrollbar):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbars):

Implement ScrollableArea's virtual function contentsSize() for access
through the scrollAnimator.

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::contentsSize):

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

Implement NSView's viewWillStartLiveResize and
viewDidEndLiveResize and propagate the messages down
to WebCore.

  • UIProcess/API/mac/WKView.mm:

(-[WKView viewWillStartLiveResize]):
(-[WKView viewDidEndLiveResize]):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::viewWillStartLiveResize):
(WebKit::WebPageProxy::viewWillEndLiveResize):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::viewWillStartLiveResize):
(WebKit::WebPage::viewWillEndLiveResize):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

A bunch of new WebKitSystemInterface functions.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

12:28 PM Changeset in webkit [77273] by carol.szabo@nokia.com
  • 3 edits
    2 adds in trunk

2011-02-01 Carol Szabo <carol.szabo@nokia.com>

Reviewed by David Hyatt.

layoutTestController.counterValueForElementById does not return the correct value
https://bugs.webkit.org/show_bug.cgi?id=53037

  • fast/css/counters/deep-before-expected.txt: Added.
  • fast/css/counters/deep-before.html: Added. This tests whether DumpRenderTree properly retrieves counters and whether counters are properly set when the before pseudo element's renderer is not a direct child of the generating element's renderer.

2011-02-01 Carol Szabo <carol.szabo@nokia.com>

Reviewed by David Hyatt.

layoutTestController.counterValueForElementById does not return the correct value
https://bugs.webkit.org/show_bug.cgi?id=53037

Test: fast/css/counters/deep-before.html

  • rendering/RenderTreeAsText.cpp: (WebCore::counterValueForElement): Modified to use the newly available RenderObject::beforePseudoElement() and RenderObject::afterPseudoElement() instead of the old imperfect algorithm to find the before and after pseudo elements.
12:27 PM Changeset in webkit [77272] by antonm@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-01 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

Allow access for security origin same as this.
https://bugs.webkit.org/show_bug.cgi?id=53440

Hard to test as newly added path currently is never hit.

  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canAccess): allow access if this == other
12:25 PM Changeset in webkit [77271] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-02-01 Dimitri Glazkov <Dimitri Glazkov>

Added more flakiness expectations from bots.

  • platform/chromium/test_expectations.txt: Another one bites or doesn't bite the dust.
12:21 PM Changeset in webkit [77270] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r73801.

12:17 PM Changeset in webkit [77269] by oliver@apple.com
  • 31 edits in trunk/Source

2011-01-31 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Update JSObject storage for new marking API
https://bugs.webkit.org/show_bug.cgi?id=53467

JSObject no longer uses EncodedJSValue for its property storage.
This produces a stream of mechanical changes to PropertySlot and
anonymous storage APIs.

  • JavaScriptCore.exp:
  • runtime/ArrayPrototype.cpp: (JSC::ArrayPrototype::ArrayPrototype):
  • runtime/BooleanConstructor.cpp: (JSC::constructBoolean): (JSC::constructBooleanFromImmediateBoolean):
  • runtime/BooleanObject.cpp: (JSC::BooleanObject::BooleanObject):
  • runtime/BooleanObject.h:
  • runtime/BooleanPrototype.cpp: (JSC::BooleanPrototype::BooleanPrototype):
  • runtime/DateInstance.cpp: (JSC::DateInstance::DateInstance):
  • runtime/DatePrototype.cpp: (JSC::DatePrototype::DatePrototype):
  • runtime/JSActivation.cpp: (JSC::JSActivation::getOwnPropertySlot):
  • runtime/JSArray.cpp: (JSC::JSArray::getOwnPropertySlot):
  • runtime/JSFunction.cpp: (JSC::JSFunction::getOwnPropertySlot):
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObject):
  • runtime/JSObject.cpp: (JSC::JSObject::fillGetterPropertySlot):
  • runtime/JSObject.h: (JSC::JSObject::getDirectLocation): (JSC::JSObject::offsetForLocation): (JSC::JSObject::putAnonymousValue): (JSC::JSObject::clearAnonymousValue): (JSC::JSObject::getAnonymousValue): (JSC::JSObject::putThisToAnonymousValue): (JSC::JSObject::locationForOffset): (JSC::JSObject::inlineGetOwnPropertySlot):
  • runtime/JSObjectWithGlobalObject.cpp: (JSC::JSObjectWithGlobalObject::JSObjectWithGlobalObject):
  • runtime/JSWrapperObject.h: (JSC::JSWrapperObject::JSWrapperObject): (JSC::JSWrapperObject::setInternalValue):
  • runtime/Lookup.cpp: (JSC::setUpStaticFunctionSlot):
  • runtime/NumberConstructor.cpp: (JSC::constructWithNumberConstructor):
  • runtime/NumberObject.cpp: (JSC::NumberObject::NumberObject): (JSC::constructNumber):
  • runtime/NumberObject.h:
  • runtime/NumberPrototype.cpp: (JSC::NumberPrototype::NumberPrototype):
  • runtime/PropertySlot.h: (JSC::PropertySlot::getValue): (JSC::PropertySlot::setValue): (JSC::PropertySlot::setRegisterSlot):
  • runtime/StringObject.cpp: (JSC::StringObject::StringObject):
  • runtime/StringPrototype.cpp: (JSC::StringPrototype::StringPrototype):
  • runtime/WriteBarrier.h: (JSC::WriteBarrierBase::setWithoutWriteBarrier):

2011-01-31 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Update JSObject storage for new marking API
https://bugs.webkit.org/show_bug.cgi?id=53467

Update WebCore to handle new anonymous slot behaviour.

  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::setWindow):
  • bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::initScript):
  • bindings/scripts/CodeGeneratorJS.pm:
12:05 PM Changeset in webkit [77268] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-02-01 Dimitri Glazkov <Dimitri Glazkov>

https://bugs.webkit.org/show_bug.cgi?id=53516
Test introduced in r77262 is crashing.

  • platform/chromium/test_expectations.txt: Added expectation to crash

while the fix is worked on.

12:02 PM Changeset in webkit [77267] by xji@chromium.org
  • 3 edits
    4 adds in trunk

2011-02-01 Xiaomei Ji <xji@chromium.org>

Reviewed by David Hyatt.

Fix a text rendering problem when enclosing block is RTL and text runs
are in different directionality.
https://bugs.webkit.org/show_bug.cgi?id=34176

The problem happens in the following example scenario (ABC represents
Hebrew characters):
<div dir=rtl>this is a <span><span>test <span>ABC</span></span></span></div>

The line consists of 3 text runs -- TextRun1 TextRun2 TextRun3. In which
TextRun1 and TextRun2's bidi level are 2, and TextRun3's bidi level is 1.
TextRun2 and TextRun3's least common ancestor is not a sibling of TextRun1.

The visual bidi run order of the text runs is TextRun3 TextRun1 TextRun2.

Inside RenderBlock::constructLine(), when RenderBlock::createLineBoxes()
creates InlineFlowBox for TextRun2, it should check an InlineFlowBox for
the run's render object's ancestor (not only its parent) has already
been constructed or has something following it on the line, in which
case, create a new box for TextRun2 instead of sharing the same box with
TextRun3.

In other words, the following 2 div should render the same results
(ABC represents Hebrew characters).
<div dir=rtl>this is a <span><span>test <span>ABC</span></span></span></div>
<div dir=rtl>this is a <span>Test <span>ABC</span></span></div>

Test: fast/dom/34176.html

  • rendering/RenderBlockLineLayout.cpp: (WebCore::parentIsConstructedOrHaveNext): (WebCore::RenderBlock::createLineBoxes):

2011-02-01 Xiaomei Ji <xji@chromium.org>

Reviewed by David Hyatt.

Fix a text rendering problem when enclosing block is RTL and text runs
are in different directionality.
https://bugs.webkit.org/show_bug.cgi?id=34176

The problem happens in the following example scenario (ABC represents
Hebrew characters):
<div dir=rtl>this is a <span><span>test <span>ABC</span></span></span></div>

The line consists of 3 text runs -- TextRun1 TextRun2 TextRun3. In which
TextRun1 and TextRun2's bidi level are 2, and TextRun3's bidi level is 1.
TextRun2 and TextRun3's least common ancestor is not a sibling of TextRun1.

The visual bidi run order of the text runs is TextRun3 TextRun1 TextRun2.

Inside RenderBlock::constructLine(), when RenderBlock::createLineBoxes()
creates InlineFlowBox for TextRun2, it should check an InlineFlowBox for
the run's render object's ancestor (not only its parent) has already
been constructed or has something following it on the line, in which
case, create a new box for TextRun2 instead of sharing the same box with
TextRun3.

In other words, the following 2 div should render the same results
(ABC represents Hebrew characters).
<div dir=rtl>this is a <span><span>test <span>ABC</span></span></span></div>
<div dir=rtl>this is a <span>Test <span>ABC</span></span></div>

  • fast/dom/34176.html: Added.
  • platform/mac/fast/dom/34176-expected.checksum: Added.
  • platform/mac/fast/dom/34176-expected.png: Added.
  • platform/mac/fast/dom/34176-expected.txt: Added.
11:39 AM Changeset in webkit [77266] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/platform/mac/printing/setPrinting-expected.txt

Update printing layout test for the ceiling->floor change.

11:37 AM Changeset in webkit [77265] by pkasting@chromium.org
  • 5 edits in branches/chromium/648

Merge 76557 - 2011-01-24 Peter Kasting <pkasting@google.com>

Reviewed by Darin Adler.

Roll back r67261 ("Don't fire onclick on middle clicks") due to
regressions.
https://bugs.webkit.org/show_bug.cgi?id=46733

  • fast/events/mouse-click-events-expected.txt:
  • fast/events/script-tests/mouse-click-events.js:

2011-01-24 Peter Kasting <pkasting@google.com>

Reviewed by Darin Adler.

Roll back r67261 ("Don't fire onclick on middle clicks") due to
regressions.
https://bugs.webkit.org/show_bug.cgi?id=46733

  • html/HTMLAnchorElement.cpp: (WebCore::isLinkClick):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::preDispatchEventHandler): (WebCore::HTMLInputElement::postDispatchEventHandler): (WebCore::HTMLInputElement::defaultEventHandler):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseDoubleClickEvent): (WebCore::EventHandler::handleMouseReleaseEvent):

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/6250083

11:22 AM Changeset in webkit [77264] by dbates@webkit.org
  • 2 edits in trunk/Tools

2011-02-01 Scott Cameron <sccameron@rim.com>

Reviewed by Daniel Bates.

Use Windows format for MinGW HTTPD path.
https://bugs.webkit.org/show_bug.cgi?id=53503

  • Scripts/webkitperl/httpd.pm:
    • Use single-quotes around MySys value for $httpdPath in getHTTPDPath() so that we don't have to escape the space characters in the path. Also, changed path to Windows-style path and removed FIXME comment.
11:21 AM Changeset in webkit [77263] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-01 Mihai Parparita <mihaip@chromium.org>

Unreviewed. Include actual values in fast/canvas/webgl/gl-teximage.html
(removed by r77129) in the case of failure.

  • fast/canvas/webgl/gl-teximage.html:
11:16 AM Changeset in webkit [77262] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-01-31 Abhishek Arya <inferno@chromium.org>

Reviewed by Dan Bernstein.

Tests that a removed svg style element is not accessed again in document's
style recalc code and does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=53441

  • fast/css/stylesheet-candidate-nodes-crash-expected.txt: Added.
  • fast/css/stylesheet-candidate-nodes-crash.xhtml: Added.

2011-02-01 Abhishek Arya <inferno@chromium.org>

Reviewed by Dan Bernstein.

Do not add a node in the document's stylesheet candidate node list if the
node is already removed from document.
https://bugs.webkit.org/show_bug.cgi?id=53441

Test: fast/css/stylesheet-candidate-nodes-crash.xhtml

  • dom/Document.cpp: (WebCore::Document::addStyleSheetCandidateNode):
11:09 AM Changeset in webkit [77261] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-02-01 Dimitri Glazkov <Dimitri Glazkov>

More flakiness updates.

  • platform/chromium/test_expectations.txt: Moar flakiness recorded.
10:50 AM Changeset in webkit [77260] by dbates@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-01 Daniel Bates <dbates@rim.com>

Reviewed by Antonio Gomes.

Modify RandomNumberSeed.h to use USE(MERSENNE_TWISTER_19937)
https://bugs.webkit.org/show_bug.cgi?id=53506

Currently, use of the Mersenne Twister pseudorandom number generator
is hardcoded to the Windows CE port. With the passing of bug #53253,
we can generalize support for this PRNG to all ports that use srand(3)
and rand(3), including Windows CE.

  • wtf/RandomNumberSeed.h: (WTF::initializeRandomNumberGenerator):
10:49 AM Changeset in webkit [77259] by hyatt@apple.com
  • 1 edit in trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp

Land Webpage.cpp for previous patch. Change was lost after conflict resolution from a merge.

10:46 AM Changeset in webkit [77258] by hyatt@apple.com
  • 1 edit in trunk/Source/WebKit2/Platform/CoreIPC/Connection.cpp

Back out accidental commit of Connection.cpp

10:44 AM Changeset in webkit [77257] by hyatt@apple.com
  • 17 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=46422, make printing and pagination work
with vertical text.

Reviewed by Darin Adler.

../WebCore:

Change printing functions to check writing-mode and properly swap width and height
as needed.

Fix the setScrollOrigin function so that the origin doesn't cause
scroll spasming during printing (this is only partially successful, but it's better
than it was).

Rewrite computePageRects to handle both RTL documents properly as well as vertical
text documents properly.

  • WebCore.exp.in:
  • page/FrameView.cpp:

(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::forceLayoutForPagination):

  • page/PrintContext.cpp:

(WebCore::PrintContext::computePageRects):
(WebCore::PrintContext::computePageRectsWithPageSizeInternal):
(WebCore::PrintContext::computeAutomaticScaleFactor):
(WebCore::PrintContext::spoolPage):
(WebCore::PrintContext::spoolRect):

  • page/PrintContext.h:
  • page/mac/WebCoreFrameView.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

  • platform/ScrollView.h:
  • platform/mac/ScrollViewMac.mm:

(WebCore::ScrollView::platformSetScrollOrigin):

  • rendering/RenderView.cpp:

(WebCore::RenderView::layout):

../WebKit/mac:

Change printing functions to check writing-mode and properly swap width and height
as needed.

  • WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView setScrollOrigin:updatePositionAtAll:immediately:]):

  • WebView/WebFrame.mm:

(-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]):

  • WebView/WebFrameInternal.h:
  • WebView/WebHTMLView.mm:

(-[WebHTMLView _web_setPrintingModeRecursive]):
(-[WebHTMLView _web_clearPrintingModeRecursive]):
(-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]):
(-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]):
(-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]):
(-[WebHTMLView _endPrintMode]):
(-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]):
(-[WebHTMLView _endScreenPaginationMode]):
(-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):
(-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:maximumPageLogicalWidth:adjustViewSize:paginateScreenContent:]):
(-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
(-[WebHTMLView _scaleFactorForPrintOperation:]):
(-[WebHTMLView setPageWidthForPrinting:]):
(-[WebHTMLView knowsPageRange:]):

../WebKit2:

Change printing functions to check writing-mode and properly swap width and height
as needed.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::computePagesForPrinting):

10:29 AM Changeset in webkit [77256] by mihaip@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-01 Mihai Parparita <mihaip@chromium.org>

Unreviewed roll of Chromium deps to r73306. This picks up a fix to get
the WebKit root dir correctly after the move to Source/. This allows
tests like http/tests/security/frame-loading-via-document-write.html
(which use LayoutTestController.pathToLocalResource) to pass with the
Chromium DRT.

  • DEPS:
9:57 AM Changeset in webkit [77255] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-02-01 Dimitri Glazkov <Dimitri Glazkov>

Updated flaky test expectations according to build bot results.

  • platform/chromium/test_expectations.txt: Flakiness recorded.
9:22 AM Changeset in webkit [77254] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-01 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Fix profiles reset to avoid clearing heap profiles in Chromium.

https://bugs.webkit.org/show_bug.cgi?id=53500

  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::resetFrontendProfiles):
9:09 AM Changeset in webkit [77253] by kbalazs@webkit.org
  • 6 edits in trunk/Tools

2011-02-01 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] Add a way to use shared process model in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=53090

  • MiniBrowser/qt/BrowserView.cpp: (BrowserView::BrowserView): Removed the m_context member. From now the context is guaranteed to be non-null and we don't need to store that in the object.
  • MiniBrowser/qt/BrowserView.h:
  • MiniBrowser/qt/BrowserWindow.cpp: Added static bool to determine that new windows need to be created with their own context or not. Use the same context and web process by default to be inilne with the other ports. (BrowserWindow::BrowserWindow): (BrowserWindow::newWindow):
  • MiniBrowser/qt/BrowserWindow.h:
  • MiniBrowser/qt/main.cpp: (main): Added command line switch to be able to use the non-shared process model. Simplify the handling of the command line switches a little bit.
8:59 AM Changeset in webkit [77252] by mnaganov@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-02-01 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Landing detailed heap snapshots, part 1.

https://bugs.webkit.org/show_bug.cgi?id=53173

Adding code for accessing heap snapshot data and
performing graph calculations.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshotArraySlice): Helper class to avoid array contents copying. (WebInspector.HeapSnapshotEdge): Wrapper for accessing graph edge properties. (WebInspector.HeapSnapshotEdgeIterator): (WebInspector.HeapSnapshotNode): Wrapper for accessing graph node properties. (WebInspector.HeapSnapshotNodeIterator): (WebInspector.HeapSnapshot): Wrapper for the heap snapshot. (WebInspector.HeapSnapshotFilteredOrderedIterator): (WebInspector.HeapSnapshotEdgesProvider): (WebInspector.HeapSnapshotNodesProvider): (WebInspector.HeapSnapshotPathFinder):
  • inspector/front-end/HeapSnapshotView.js: (WebInspector.HeapSnapshotView.prototype._convertSnapshot):
7:46 AM Changeset in webkit [77251] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Fix linker warnings in Release_LTCG builds

  • WebCore.vcproj/WebCore.vcproj: Exclude EventNames.cpp and EventTarget.cpp from all

configurations, since they get pulled in via DOMAllInOne.cpp.

6:57 AM Changeset in webkit [77250] by zoltan@webkit.org
  • 3 edits in trunk/Tools

[Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=53491

Reviewed by Andreas Kling.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::toggleFullScreenMode):

  • MiniBrowser/qt/BrowserWindow.h:
6:53 AM Changeset in webkit [77249] by apavlov@chromium.org
  • 6 edits in trunk/Source

2011-02-01 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] Wrongly labelled context-menu item for links in Web Inspector's side-pane
https://bugs.webkit.org/show_bug.cgi?id=53482

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.populateHrefContextMenu):
  • inspector/front-end/inspector.js: (WebInspector.resourceForURL): (WebInspector.openLinkExternallyLabel):

2011-02-01 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] Wrongly labelled context-menu item for links in Web Inspector's side-pane
https://bugs.webkit.org/show_bug.cgi?id=53482

  • src/js/DevTools.js: (WebInspector.openLinkExternallyLabel): Override to customize a context menu item label
6:40 AM Changeset in webkit [77248] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-01 Dave Tapuska <dtapuska@rim.com>

Reviewed by Gavin Barraclough.

MacroAssemblerARM would generate code that did 32bit loads
on addresses that were not aligned. More specifically it would
generate a ldr r8,[r1, #7] which isn't valid on ARMv5 and lower.
The intended instruction really is ldrb r8,[r1, #7]; ensure we
call load8 instead of load32.

https://bugs.webkit.org/show_bug.cgi?id=46095

  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::set32Test32): (JSC::MacroAssemblerARM::set32Test8):
6:38 AM Changeset in webkit [77247] by Csaba Osztrogonác
  • 1 edit
    1 copy in trunk/LayoutTests

Unreviewed.

fast/loader/onload-policy-ignore-for-frame.html fails on Qt bot
https://bugs.webkit.org/show_bug.cgi?id=53490

Add Qt specific expected result.

  • platform/qt/fast/loader/onload-policy-ignore-for-frame-expected.txt: Copied from LayoutTests/fast/loader/onload-policy-ignore-for-frame-expected.txt.
6:35 AM Changeset in webkit [77246] by antonm@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-01 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

Propagate parent document security origin to newly create Document XML response
https://bugs.webkit.org/show_bug.cgi?id=53444

Covered by the existing tests.

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseXML):
5:32 AM Changeset in webkit [77245] by zoltan@webkit.org
  • 3 edits in trunk/Tools

[Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=53489

Reviewed by Andreas Kling.

Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
to Settings menu.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::toggleFrameFlattening):
(BrowserWindow::toggleDisableJavaScript):
(BrowserWindow::toggleAutoLoadImages):

  • MiniBrowser/qt/BrowserWindow.h:
5:07 AM Changeset in webkit [77244] by mnaganov@chromium.org
  • 3 edits in branches/chromium/648/Source/WebCore/inspector/front-end

Merge 77127 - 2011-01-30 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: speed up network panel rendering.
https://bugs.webkit.org/show_bug.cgi?id=53397

  • inspector/front-end/DataGrid.js: (WebInspector.DataGrid.prototype.get scrollContainer):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.elementsToRestoreScrollPositionsFor): (WebInspector.NetworkPanel.prototype._positionSummaryBar): (WebInspector.NetworkPanel.prototype._createTable): (WebInspector.NetworkPanel.prototype._exportResource): (WebInspector.NetworkPanel.prototype._onScroll):
  • inspector/front-end/networkPanel.css: (.network-sidebar .data-grid.small tr.offscreen): (.network-sidebar .data-grid tr.offscreen): (.network-sidebar .data-grid tr.offscreen td):

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/6409044

4:42 AM Changeset in webkit [77243] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Source/WebKit/efl

2011-02-01 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Add an API to get proxy address.
https://bugs.webkit.org/show_bug.cgi?id=52990

Gets the proxy URI from network backend. This API returns a proxy URI
which is set up by ewk_settings_proxy_uri_set(). But, it only implements
this API for libsoup backend.

  • ewk/ewk_settings.cpp: (ewk_settings_proxy_uri_get):
  • ewk/ewk_settings.h:
4:42 AM Changeset in webkit [77242] by darin@chromium.org
  • 9 edits in trunk/Source

2011-02-01 Darin Fisher <darin@chromium.org>

Reviewed by Eric Seidel.

Fix some Visual Studio compiler warnings.
https://bugs.webkit.org/show_bug.cgi?id=53476

  • wtf/MathExtras.h: (clampToInteger): (clampToPositiveInteger):
  • wtf/ThreadingWin.cpp: (WTF::absoluteTimeToWaitTimeoutInterval):

2011-02-01 Darin Fisher <darin@chromium.org>

Reviewed by Eric Seidel.

Fix some Visual Studio compiler warnings.
https://bugs.webkit.org/show_bug.cgi?id=53476

  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::forms):
  • src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::repaint):
  • src/WebScrollbarImpl.cpp: (WebKit::WebScrollbarImpl::setValue):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::doPixelReadbackToCanvas): (WebKit::WebViewImpl::setZoomLevel): (WebKit::WebViewImplScrollbarPaintInterface::paint):
4:16 AM Changeset in webkit [77241] by yurys@chromium.org
  • 5 edits
    2 deletes in trunk

2011-02-01 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Rollout r77230 which caused many layout tests
crashes on Chromium Debug bots.

Async event handlers should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53202

  • dom/Document.cpp: (WebCore::Document::Document):
  • dom/EventQueue.cpp: (WebCore::EventQueue::EventQueue): (WebCore::EventQueue::enqueueEvent): (WebCore::EventQueue::pendingEventTimerFired):
  • dom/EventQueue.h:

2011-02-01 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Rollout r77230 which caused many layout tests
crashes on Chromium Debug bots.

Async event handlers should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53202

  • fast/events/scroll-event-during-modal-dialog-expected.txt: Removed.
  • fast/events/scroll-event-during-modal-dialog.html: Removed.
2:48 AM Changeset in webkit [77240] by zherczeg@webkit.org
  • 15 edits in trunk/Source/WebCore

LightElement changes does not require relayout.
https://bugs.webkit.org/show_bug.cgi?id=53232

Reviewed by Dirk Schulze.

When an attribute of a LightElement changes, it
send an update message to the lighting filters
to update its corresponding LightSource objects,
and repaint the filters.

Duplicated 'id' attributes removed from svg-filter-animation.svg.

Existing dynamic-update tests covers this feature.

5x speedup on manual-tests/svg-filter-animation.svg

  • manual-tests/svg-filter-animation.svg:
  • platform/graphics/filters/DistantLightSource.h:
  • platform/graphics/filters/FEDiffuseLighting.cpp:

(WebCore::FEDiffuseLighting::setLightingColor):
(WebCore::FEDiffuseLighting::setSurfaceScale):
(WebCore::FEDiffuseLighting::setDiffuseConstant):
(WebCore::FEDiffuseLighting::setKernelUnitLengthX):
(WebCore::FEDiffuseLighting::setKernelUnitLengthY):

  • platform/graphics/filters/FEDiffuseLighting.h:
  • platform/graphics/filters/LightSource.cpp:

(WebCore::PointLightSource::setX):
(WebCore::PointLightSource::setY):
(WebCore::PointLightSource::setZ):
(WebCore::SpotLightSource::setX):
(WebCore::SpotLightSource::setY):
(WebCore::SpotLightSource::setZ):
(WebCore::SpotLightSource::setPointsAtX):
(WebCore::SpotLightSource::setPointsAtY):
(WebCore::SpotLightSource::setPointsAtZ):
(WebCore::SpotLightSource::setSpecularExponent):
(WebCore::SpotLightSource::setLimitingConeAngle):
(WebCore::DistantLightSource::setAzimuth):
(WebCore::DistantLightSource::setElevation):
(WebCore::LightSource::setAzimuth):
(WebCore::LightSource::setElevation):
(WebCore::LightSource::setX):
(WebCore::LightSource::setY):
(WebCore::LightSource::setZ):
(WebCore::LightSource::setPointsAtX):
(WebCore::LightSource::setPointsAtY):
(WebCore::LightSource::setPointsAtZ):
(WebCore::LightSource::setSpecularExponent):
(WebCore::LightSource::setLimitingConeAngle):

  • platform/graphics/filters/LightSource.h:
  • platform/graphics/filters/PointLightSource.h:
  • platform/graphics/filters/SpotLightSource.h:
  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::primitiveAttributeChanged):

  • svg/SVGFEDiffuseLightingElement.cpp:

(WebCore::SVGFEDiffuseLightingElement::setFilterEffectAttribute):
(WebCore::SVGFEDiffuseLightingElement::lightElementAttributeChanged):
(WebCore::SVGFEDiffuseLightingElement::build):
(WebCore::SVGFEDiffuseLightingElement::findLightElement):
(WebCore::SVGFEDiffuseLightingElement::findLight):

  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFELightElement.cpp:

(WebCore::SVGFELightElement::svgAttributeChanged):

  • svg/SVGFilterPrimitiveStandardAttributes.cpp:

(WebCore::SVGFilterPrimitiveStandardAttributes::setFilterEffectAttribute):

  • svg/SVGFilterPrimitiveStandardAttributes.h:
2:41 AM Changeset in webkit [77239] by rolandsteiner@chromium.org
  • 11 edits
    2 adds in trunk/Source/WebCore

2011-02-01 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 53289 - DOM: Move DocumentOrderedMap from Document into separate files
https://bugs.webkit.org/show_bug.cgi?id=53289

Moving the nested class DocumentOrderedMap from Document into separate files,
updating code where necessary.

No new tests. (refactoring)

  • Android.mk:
  • CMakeLists.txt:
  • GNUMakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp: (WebCore::Document::getElementById): (WebCore::Document::getImageMap):
  • dom/Document.h:
  • dom/DocumentOrderedMap.cpp: Added. (WebCore::keyMatchesId): (WebCore::keyMatchesMapName): (WebCore::keyMatchesLowercasedMapName): (WebCore::DocumentOrderedMap::clear): (WebCore::DocumentOrderedMap::add): (WebCore::DocumentOrderedMap::remove): (WebCore::DocumentOrderedMap::get): (WebCore::DocumentOrderedMap::getElementById): (WebCore::DocumentOrderedMap::getElementByMapName): (WebCore::DocumentOrderedMap::getElementByLowercasedMapName):
  • dom/DocumentOrderedMap.h: Added. (WebCore::DocumentOrderedMap::contains): (WebCore::DocumentOrderedMap::containsMultiple):
  • dom/DOMAllInOne.cpp:
2:32 AM Changeset in webkit [77238] by commit-queue@webkit.org
  • 1 edit in trunk/ChangeLog

2010-01-28 Commit Queue <commit-queue@webkit.org>

Unreviewed. Test commit for commit-queue@webkit.org.

2:27 AM Changeset in webkit [77237] by commit-queue@webkit.org
  • 1 edit in trunk/ChangeLog

2010-01-28 Commit Queue <commit-queue@webkit.org>

Unreviewed. Test commit for commit-queue@webkit.org.

2:18 AM Changeset in webkit [77236] by hans@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-01 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

Chromium: remove WebIDBCallbacks::onSucces()
https://bugs.webkit.org/show_bug.cgi?id=53415

Remove un-used function.

  • public/WebIDBCallbacks.h:
1:58 AM Changeset in webkit [77235] by mario@webkit.org
  • 4 edits in trunk/Source

2011-02-01 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[Gtk] atk_text_set_caret_offset fails for list items
https://bugs.webkit.org/show_bug.cgi?id=53388

Allow using text ranges across list items.

  • accessibility/gtk/AccessibilityObjectAtk.cpp: (WebCore::AccessibilityObject::allowsTextRanges): Add list items to the list of accessibility objects supporting text ranges.

2011-02-01 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[Gtk] atk_text_set_caret_offset fails for list items
https://bugs.webkit.org/show_bug.cgi?id=53388

Update unit test to check the fix for this bug.

  • tests/testatk.c: (testWebkitAtkCaretOffsets): Ensure setting the caret in a list item through the AtkText interface is possible.
1:54 AM Changeset in webkit [77234] by mario@webkit.org
  • 4 edits in trunk/Source

2011-02-01 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] character range extents is off when the end of a wrapped line is included
https://bugs.webkit.org/show_bug.cgi?id=53323

Fixed wrong calculation getting the range extents.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_get_range_extents): Removed '+1' since the requested interval shouldn't include the last character.

2011-02-01 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] character range extents is off when the end of a wrapped line is included
https://bugs.webkit.org/show_bug.cgi?id=53323

Update unit test to check the fix for this bug.

  • tests/testatk.c: (testWebkitAtkGetExtents): Check that the extent for a full line are the same height than for a partial section of the same line.
1:49 AM Changeset in webkit [77233] by mario@webkit.org
  • 4 edits in trunk/Source

2011-02-01 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Caret Offset is one off at the end of wrapped lines
https://bugs.webkit.org/show_bug.cgi?id=53300

Consider linebreaks as special cases.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (objectAndOffsetUnignored): In order to avoid getting wrong values when around linebreaks, we need to workaround this by explicitly avoiding those '\n' text nodes from affecting the result of calling to TextIterator:rangeLength().

2011-02-01 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Caret Offset is one off at the end of wrapped lines
https://bugs.webkit.org/show_bug.cgi?id=53300

Update unit test to check the fix for this bug.

  • tests/testatk.c: (testWebkitAtkCaretOffsetsAndExtranousWhiteSpaces): Set and get the caret offset at the edge of the line.
1:37 AM Changeset in webkit [77232] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-01 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Fix Chromium Debug compilation broken by r77228.

[Chromium] Autofill should work with HTML5 form elements
https://bugs.webkit.org/show_bug.cgi?id=51809

  • src/WebInputElement.cpp: (WebKit::toWebInputElement):
1:32 AM Changeset in webkit [77231] by rolandsteiner@chromium.org
  • 11 edits
    2 deletes in trunk/Source/WebCore

2011-02-01 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed, rolling out r77229.
http://trac.webkit.org/changeset/77229
https://bugs.webkit.org/show_bug.cgi?id=53289

revert mysterious build breakage

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/Document.cpp: (WebCore::Document::DocumentOrderedMap::clear): (WebCore::Document::DocumentOrderedMap::add): (WebCore::Document::DocumentOrderedMap::remove): (WebCore::Document::DocumentOrderedMap::get): (WebCore::keyMatchesId): (WebCore::Document::getElementById): (WebCore::keyMatchesMapName): (WebCore::keyMatchesLowercasedMapName): (WebCore::Document::getImageMap):
  • dom/Document.h: (WebCore::Document::DocumentOrderedMap::contains): (WebCore::Document::DocumentOrderedMap::containsMultiple):
  • dom/DocumentOrderedMap.cpp: Removed.
  • dom/DocumentOrderedMap.h: Removed.
1:20 AM Changeset in webkit [77230] by mihaip@chromium.org
  • 5 edits
    2 adds in trunk

2011-02-01 Mihai Parparita <mihaip@chromium.org>

Reviewed by James Robinson.

Async event handlers should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53202

Add tests for a scroll event triggered right before a modal dialog is
shown.

  • fast/events/scroll-event-during-modal-dialog-expected.txt: Added.
  • fast/events/scroll-event-during-modal-dialog.html: Added.

2011-02-01 Mihai Parparita <mihaip@chromium.org>

Reviewed by James Robinson.

Async event handlers should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53202

Asychronous events that use EventQueue would currently fire while a
modal dialog (e.g. window.alert()) was up. Change EventQueue to use a
SuspendableTimer (which automatically gets suspended while dialogs are
up and in other cases where JS execution is not allowed).

Test: fast/events/scroll-event-during-modal-dialog.html

  • dom/Document.cpp: (WebCore::Document::Document):
  • dom/EventQueue.cpp: (WebCore::EventQueueTimer::EventQueueTimer): (WebCore::EventQueueTimer::fired): (WebCore::EventQueue::EventQueue): (WebCore::EventQueue::enqueueEvent): (WebCore::EventQueue::pendingEventTimerFired):
  • dom/EventQueue.h: (WebCore::EventQueue::create):
1:11 AM Changeset in webkit [77229] by rolandsteiner@chromium.org
  • 11 edits
    2 adds in trunk/Source/WebCore

2011-01-28 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by NOBODY (OOPS!).

Bug 53289 - DOM: Move DocumentOrderedMap from Document into separate files
https://bugs.webkit.org/show_bug.cgi?id=53289

Moving the nested class DocumentOrderedMap from Document into separate files,
updating code where necessary.

No new tests. (refactoring)

  • Android.mk:
  • CMakeLists.txt:
  • GNUMakefile.am
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp: (WebCore::Document::getElementById): (WebCore::Document::getImageMap):
  • dom/Document.h:
  • dom/DocumentOrderedMap.cpp: Added. (WebCore::keyMatchesId): (WebCore::keyMatchesMapName): (WebCore::keyMatchesLowercasedMapName): (WebCore::DocumentOrderedMap::clear): (WebCore::DocumentOrderedMap::add): (WebCore::DocumentOrderedMap::remove): (WebCore::DocumentOrderedMap::get): (WebCore::DocumentOrderedMap::getElementById): (WebCore::DocumentOrderedMap::getElementByMapName): (WebCore::DocumentOrderedMap::getElementByLowercasedMapName):
  • dom/DocumentOrderedMap.h: Added. (WebCore::DocumentOrderedMap::contains): (WebCore::DocumentOrderedMap::containsMultiple):
  • dom/DOMAllInOne.cpp:
12:54 AM Changeset in webkit [77228] by commit-queue@webkit.org
  • 9 edits in trunk/Source

2011-02-01 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Darin Fisher.

[Chromium] Autofill should work with HTML5 form elements
https://bugs.webkit.org/show_bug.cgi?id=51809
http://crbug.com/65654

No new tests, because this fix is for Chromium project and hard to test only in WebKit project.

  • html/InputType.h: Insert comment for canSetSuggestedValue().
  • html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::canSetSuggestedValue): Implemented to return always true for that all text filed inputs can be completed.
  • html/TextFieldInputType.h: Declare canSetSuggestedValue().
  • html/TextInputType.cpp: Delete canSetSuggestedValue() not to return true anymore.
  • html/TextInputType.h: Delete canSetSuggestedValue() not to return true anymore.

2011-02-01 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Darin Fisher.

[Chromium] Autofill should work with HTML5 form elements
https://bugs.webkit.org/show_bug.cgi?id=51809
http://crbug.com/65654

No new tests, because this fix is for Chromium project and hard to test only in WebKit project.

  • public/WebInputElement.h: Added toWebInputElement() declarations and implemented const version of toWebInputElement().
  • src/WebInputElement.cpp: (WebKit::WebInputElement::toWebInputElement): Implemented a convert function to cast no-const WebElement* to no-const WebInputElement*. Because Chrome needs safe cast for autofill completion.
12:32 AM Changeset in webkit [77227] by mrowe@apple.com
  • 5 edits in branches/safari-533.20-branch

Merge r74788.

12:32 AM Changeset in webkit [77226] by mrowe@apple.com
  • 3 edits
    3 adds in branches/safari-533.20-branch

Merge r68307.

12:22 AM Changeset in webkit [77225] by mrowe@apple.com
  • 6 edits
    4 adds in branches/safari-533.20-branch

Merge r72040 and r72135.

12:05 AM Changeset in webkit [77224] by tkent@chromium.org
  • 5 edits in trunk

REGRESSION (r65062): Safari loops forever under WebCore::plainTextToMallocAllocatedBuffer()
https://bugs.webkit.org/show_bug.cgi?id=53272

Reviewed by Dan Bernstein.

Source/WebCore:

  • editing/TextIterator.cpp:

(WebCore::TextIterator::handleTextBox): Pass the appropriate renderer to emitText().

LayoutTests:

  • fast/dom/inner-text-first-letter.html:
    • Add a new test case reproducing the bug.
    • Remove unnecessary text output.
  • fast/dom/inner-text-first-letter-expected.txt:
Note: See TracTimeline for information about the timeline view.