Timeline



Feb 16, 2011:

11:17 PM Changeset in webkit [78795] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-02-16 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Intermittent crashes beneath MarkStack::drain
​https://bugs.webkit.org/show_bug.cgi?id=54614
<rdar://problem/8971070>

The crashes were caused by a GC happening after the global object's
property table had grown (due to compilation), but before the properties
had been fully initialized by program execution.

  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): Explicitly resize the global object's register storage immediately, without waiting for program execution to do it for us. This ensures that the global object's count of global variables is consistent with the size of its global variable storage at all times, and it ensures that all global variables are properly initialized from the get-go.
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::resizeRegisters):
  • runtime/JSGlobalObject.h: Added a helper function for growing the global object's register storage, and initializing new registers.
11:09 PM Changeset in webkit [78794] by loislo@chromium.org
  • 3 edits in trunk/LayoutTests

2011-02-16 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed.

Web Inspector: chromium: update test expectation.

  • platform/chromium/inspector/timeline/timeline-parse-html-expected.txt:
  • platform/chromium/test_expectations.txt:
10:53 PM Changeset in webkit [78793] by loislo@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

2011-02-16 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed.

Web Inspector: remove custom test expectations for chromium.

  • platform/chromium/http/tests/inspector/console-resource-errors-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
10:30 PM Changeset in webkit [78792] by mrowe@apple.com
  • 5 edits in branches/safari-534.20-branch/Source

Versioning.

10:28 PM Changeset in webkit [78791] by mrowe@apple.com
  • 1 copy in tags/Safari-534.20.2

New tag.

10:25 PM Changeset in webkit [78790] by commit-queue@webkit.org
  • 6 edits in trunk/Source

2011-02-16 Brian Ryner <​bryner@chromium.org>

Reviewed by Darin Fisher.

Split the socket address field into separate IP address and port fields.
This will make the field less error-prone to parse, for example when
dealing with IPv6 literals.
​https://bugs.webkit.org/show_bug.cgi?id=54607

No new tests required.

  • platform/network/chromium/ResourceResponse.cpp: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
  • platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::remoteIPAddress): (WebCore::ResourceResponse::setRemoteIPAddress): (WebCore::ResourceResponse::remotePort): (WebCore::ResourceResponse::setRemotePort):

2011-02-16 Brian Ryner <​bryner@chromium.org>

Reviewed by Darin Fisher.

Split the socket address field into separate IP address and port fields.
This will make the field less error-prone to parse, for example when
dealing with IPv6 literals.
​https://bugs.webkit.org/show_bug.cgi?id=54607

  • public/WebURLResponse.h:
  • src/WebURLResponse.cpp: (WebKit::WebURLResponse::remoteIPAddress): (WebKit::WebURLResponse::setRemoteIPAddress): (WebKit::WebURLResponse::remotePort): (WebKit::WebURLResponse::setRemotePort):
8:56 PM Changeset in webkit [78789] by commit-queue@webkit.org
  • 17 edits
    2 adds in trunk

2011-02-16 Dominic Mazzoni <​dmazzoni@google.com>

Reviewed by Chris Fleizach.

Add new test for canvas fallback content and update existing text for new canvas role.
​https://bugs.webkit.org/show_bug.cgi?id=50126

  • accessibility/canvas-fallback-content-expected.txt: Added.
  • accessibility/canvas-fallback-content.html: Added.
  • accessibility/canvas.html:

2011-02-16 Dominic Mazzoni <​dmazzoni@google.com>

Reviewed by Chris Fleizach.

Add support for canvas fallback content.
​https://bugs.webkit.org/show_bug.cgi?id=50126

Test: accessibility/canvas-fallback-content.html

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::determineAccessibilityRole): (WebCore::AccessibilityRenderObject::canHaveChildren):
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (atkRole):
  • accessibility/mac/AccessibilityObjectWrapper.mm:
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::isFocusable):
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::recursiveSetNoNeedsLayout): (WebCore::RenderHTMLCanvas::layout): (WebCore::RenderHTMLCanvas::nodeAtPoint):
  • rendering/RenderHTMLCanvas.h: (WebCore::RenderHTMLCanvas::children): (WebCore::RenderHTMLCanvas::canHaveChildren): (WebCore::RenderHTMLCanvas::virtualChildren):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaint):
  • rendering/RenderTreeAsText.cpp: (WebCore::write):

2011-02-16 Dominic Mazzoni <​dmazzoni@google.com>

Reviewed by Chris Fleizach.

Add new role for canvas elements.

​https://bugs.webkit.org/show_bug.cgi?id=50126

  • public/WebAccessibilityRole.h:
  • src/AssertMatchingEnums.cpp:

2011-02-16 Dominic Mazzoni <​dmazzoni@google.com>

Reviewed by Chris Fleizach.

Add new role for canvas elements.

​https://bugs.webkit.org/show_bug.cgi?id=50126

Test: accessibility/canvas-fallback-content.html

  • AccessibleBase.cpp: (MSAARole):
8:54 PM Changeset in webkit [78788] by Simon Fraser
  • 16 edits in trunk/Source

2011-02-16 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Simon Fraser.

Allow acceleratesDrawing for WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=54511

Plumb through preference for accelerated drawing.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences acceleratedDrawingEnabled]): (-[WebPreferences setAcceleratedDrawingEnabled:]):
  • WebView/WebPreferencesPrivate.h:

2011-02-16 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Simon Fraser.

Allow acceleratesDrawing for WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=54511

Plumb through preference for accelerated drawing.

When accelerated drawing is enabled, set a flag on new GraphicsLayers.

Not testable via Layout Tests

  • WebCore.exp.in:
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setAcceleratedDrawingEnabled):
  • page/Settings.h: (WebCore::Settings::acceleratedDrawingEnabled):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateBacking):

2011-02-16 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Simon Fraser.

Allow acceleratesDrawing for WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=54511

Plumb through preference for accelerated drawing.

If accelerated drawing is enabled, keep the DrawingAreaImpl in
accelerated compositing mode.

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetAcceleratedDrawingEnabled): (WKPreferencesGetAcceleratedDrawingEnabled):
  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::DrawingAreaImpl): (WebKit::DrawingAreaImpl::setRootCompositingLayer): (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences):
8:44 PM Changeset in webkit [78787] by commit-queue@webkit.org
  • 7 edits in trunk/Source

2011-02-16 Victoria Kirst <​vrk@google.com>

Reviewed by Kenneth Russell.

[chromium] Fix green pixels at edge of certain GPU-accelerated videos
​https://bugs.webkit.org/show_bug.cgi?id=54559

Adds logic to properly resize the range of YUV textures to only
select legitimate values.

  • platform/graphics/chromium/VideoFrameChromium.h:
  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::SharedValues::SharedValues): (WebCore::VideoLayerChromium::allocateTexturesIfNeeded): (WebCore::VideoLayerChromium::drawYUV):
  • platform/graphics/chromium/VideoLayerChromium.h: (WebCore::VideoLayerChromium::SharedValues::yWidthScaleFactorLocation): (WebCore::VideoLayerChromium::SharedValues::uvWidthScaleFactorLocation):

2011-02-16 Victoria Kirst <​vrk@google.com>

Reviewed by Kenneth Russell.

[chromium] Fix green pixels at edge of certain GPU-accelerated videos
​https://bugs.webkit.org/show_bug.cgi?id=54559

  • src/VideoFrameChromiumImpl.cpp: (WebKit::VideoFrameChromiumImpl::width): (WebKit::VideoFrameChromiumImpl::height): (WebKit::VideoFrameChromiumImpl::requiredTextureSize): (WebKit::VideoFrameChromiumImpl::hasPaddingBytes):
  • src/VideoFrameChromiumImpl.h:
8:39 PM Changeset in webkit [78786] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

2011-02-16 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Unreviewed build fix.

[EFL] Build break on r78634
​https://bugs.webkit.org/show_bug.cgi?id=54602

Build error because of r78634.

  • CMakeListsEfl.txt:
8:28 PM Changeset in webkit [78785] by yael.aharon@nokia.com
  • 2 edits in trunk/Source/WebKit2

2011-02-16 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Andreas Kling.

[Qt] White screen is displayed when tiled backing store is enabled in MiniBrowser.
​https://bugs.webkit.org/show_bug.cgi?id=54583

Make sure to invalidate all the tiles, including the last one.

  • UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::TiledDrawingAreaProxy::invalidate):
8:27 PM Changeset in webkit [78784] by yael.aharon@nokia.com
  • 3 edits in trunk/Tools

2011-02-16 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Andreas Kling.

[Qt] Enable tiled backing store by default in MiniBrowser.
​https://bugs.webkit.org/show_bug.cgi?id=54581

Instead of a flag to turn it on, a new flag is defined to turn
tiled backing store off.

  • MiniBrowser/qt/MiniBrowserApplication.cpp: (MiniBrowserApplication::handleUserOptions):
  • MiniBrowser/qt/MiniBrowserApplication.h: (WindowOptions::WindowOptions):
8:27 PM Changeset in webkit [78783] by yael.aharon@nokia.com
  • 2 edits in trunk/Source/WebKit2

2011-02-16 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Andreas Kling.

[Qt] Tiles are not created for webkit2 after r77286.
​https://bugs.webkit.org/show_bug.cgi?id=54577

When using the default tile size of 1024x1024, only one tile is created.
Make sure to create this tile by undoing what seems to be a typo in r77286.

  • UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::TiledDrawingAreaProxy::paint): (WebKit::TiledDrawingAreaProxy::createTiles):
8:11 PM Changeset in webkit [78782] by commit-queue@webkit.org
  • 17 edits in trunk/Source/WebCore

2011-02-16 Bill Budge <​bbudge@chromium.org>

Reviewed by David Levin.

Need didReceiveCachedMetadata, and finishTime for didFinishLoading exposed in ThreadableLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=54313

No tests needed, exposes no new functionality

  • fileapi/FileReaderLoader.cpp: (WebCore::FileReaderLoader::didFinishLoading):
  • fileapi/FileReaderLoader.h:
  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::setDefersLoading): (WebCore::DocumentThreadableLoader::didReceiveCachedMetadata): (WebCore::DocumentThreadableLoader::didFinishLoading): (WebCore::DocumentThreadableLoader::loadRequest):
  • loader/DocumentThreadableLoader.h:
  • loader/ThreadableLoaderClient.h: (WebCore::ThreadableLoaderClient::didReceiveData): (WebCore::ThreadableLoaderClient::didReceiveCachedMetadata): (WebCore::ThreadableLoaderClient::didFinishLoading):
  • loader/ThreadableLoaderClientWrapper.h: (WebCore::ThreadableLoaderClientWrapper::didReceiveData): (WebCore::ThreadableLoaderClientWrapper::didReceiveCachedMetadata): (WebCore::ThreadableLoaderClientWrapper::didFinishLoading):
  • loader/WorkerThreadableLoader.cpp: (WebCore::workerContextDidReceiveCachedMetadata): (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveCachedMetadata): (WebCore::workerContextDidFinishLoading): (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
  • loader/WorkerThreadableLoader.h:
  • notifications/Notification.cpp: (WebCore::Notification::didFinishLoading):
  • notifications/Notification.h:
  • page/EventSource.cpp: (WebCore::EventSource::didFinishLoading):
  • page/EventSource.h:
  • workers/WorkerScriptLoader.cpp: (WebCore::WorkerScriptLoader::didFinishLoading):
  • workers/WorkerScriptLoader.h:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading):
  • xml/XMLHttpRequest.h:
8:03 PM Changeset in webkit [78781] by jorlow@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-16 Jeremy Orlow <​jorlow@chromium.org>

Fix uninitialized memory error.

  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::close):
8:00 PM Changeset in webkit [78780] by abarth@webkit.org
  • 5 edits in trunk

2011-02-16 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Fix xssAuditor/form-action.html
​https://bugs.webkit.org/show_bug.cgi?id=54590

Update expected results to show that we pass.

  • http/tests/security/xssAuditor/form-action-expected.txt:

2011-02-16 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Fix xssAuditor/form-action.html
​https://bugs.webkit.org/show_bug.cgi?id=54590

We should block form actions. Although this technically can't be used
to run script, it's a pretty easy vector for stealing passwords.

  • html/parser/XSSFilter.cpp: (WebCore::XSSFilter::filterTokenInitial): (WebCore::XSSFilter::filterFormToken):
  • html/parser/XSSFilter.h:
7:48 PM Changeset in webkit [78779] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-02-16 Eric Seidel <​eric@webkit.org>

Reviewed by Mihai Parparita.

flaky test archive uploads are always 22 bytes long
​https://bugs.webkit.org/show_bug.cgi?id=54593

Speculative fix for the 22-bytes bug.

  • Scripts/webkitpy/tool/bot/flakytestreporter.py:
7:41 PM Changeset in webkit [78778] by mihaip@chromium.org
  • 143 edits
    2 moves in trunk

2011-02-16 Anna Cavender <​annacc@chromium.org>

Reviewed by Mihai Parparita.

http/tests/media should be served over HTTP (not from local file)
​https://bugs.webkit.org/show_bug.cgi?id=54028

Removed special ​file:// treatment of http/tests/media
Moved media-file.js and video-tests.js to http/tests/media so local server can access them.
Update tests to point to new location of javascript libraries.

  • http/tests/media/media-file.js: Renamed from LayoutTests/media/media-file.js.
  • http/tests/media/pdf-served-as-pdf.html:
  • http/tests/media/reload-after-dialog.html:
  • http/tests/media/remove-while-loading.html:
  • http/tests/media/text-served-as-text.html:
  • http/tests/media/video-buffered.html:
  • http/tests/media/video-cancel-load.html:
  • http/tests/media/video-cookie.html:
  • http/tests/media/video-error-abort.html:
  • http/tests/media/video-load-twice.html:
  • http/tests/media/video-play-stall-seek.html:
  • http/tests/media/video-play-stall.html:
  • http/tests/media/video-play-suspend.html:
  • http/tests/media/video-referer.html:
  • http/tests/media/video-seekable-stall.html:
  • http/tests/media/video-served-as-text.html:
  • http/tests/media/video-test.js: Renamed from LayoutTests/media/video-test.js.
  • media/adopt-node-crash.html:
  • media/audio-constructor-preload.html:
  • media/audio-constructor-src.html:
  • media/audio-constructor.html:
  • media/audio-controls-rendering.html:
  • media/audio-data-url.html:
  • media/audio-delete-while-slider-thumb-clicked.html:
  • media/audio-delete-while-step-button-clicked.html:
  • media/audio-mpeg-supported.html:
  • media/audio-mpeg4-supported.html:
  • media/audio-play-event.html:
  • media/before-load-member-access.html:
  • media/broken-video.html:
  • media/constructors.html:
  • media/context-menu-actions.html:
  • media/controls-after-reload.html:
  • media/controls-css-overload.html:
  • media/controls-drag-timebar.html:
  • media/controls-right-click-on-timebar.html:
  • media/controls-strict.html:
  • media/controls-styling.html:
  • media/controls-without-preload.html:
  • media/event-attributes.html:
  • media/invalid-media-url-crash.html:
  • media/media-can-play-mpeg-audio.html:
  • media/media-can-play-mpeg4-video.html:
  • media/media-can-play-octet-stream.html:
  • media/media-can-play-ogg.html:
  • media/media-can-play-wav-audio.html:
  • media/media-captions.html:
  • media/media-constants.html:
  • media/media-fullscreen-inline.html:
  • media/media-fullscreen-not-in-document.html:
  • media/media-load-event.html:
  • media/media-startTime.html:
  • media/remove-from-document-no-load.html:
  • media/remove-from-document.html:
  • media/restore-from-page-cache.html:
  • media/unsupported-rtsp.html:
  • media/unsupported-tracks.html:
  • media/video-append-source.html:
  • media/video-aspect-ratio.html:
  • media/video-autoplay.html:
  • media/video-buffered.html:
  • media/video-can-play-type.html:
  • media/video-canvas-alpha.html:
  • media/video-canvas-source.html:
  • media/video-canvas.html-disabled:
  • media/video-click-dblckick-standalone.html:
  • media/video-controls-rendering.html:
  • media/video-controls-transformed.html:
  • media/video-controls-visible-audio-only.html:
  • media/video-controls-zoomed.html:
  • media/video-controls.html:
  • media/video-currentTime-delay.html:
  • media/video-currentTime-set.html:
  • media/video-currentTime-set2.html:
  • media/video-currentTime.html:
  • media/video-delay-load-event.html:
  • media/video-display-aspect-ratio.html:
  • media/video-display-none-crash.html:
  • media/video-display-toggle.html:
  • media/video-does-not-loop.html:
  • media/video-dom-autoplay.html:
  • media/video-dom-preload.html:
  • media/video-dom-src.html:
  • media/video-duration-known-after-eos.html:
  • media/video-error-does-not-exist.html:
  • media/video-frame-accurate-seek.html:
  • media/video-layer-crash.html:
  • media/video-load-networkState.html:
  • media/video-load-readyState.html:
  • media/video-loop.html:
  • media/video-muted.html:
  • media/video-no-audio.html:
  • media/video-no-autoplay.html:
  • media/video-pause-empty-events.html:
  • media/video-pause-immediately.html:
  • media/video-play-empty-events.html:
  • media/video-play-pause-events.html:
  • media/video-play-pause-exception.html:
  • media/video-played-collapse.html:
  • media/video-played-ranges-1.html:
  • media/video-played-reset.html:
  • media/video-poster-delayed.html:
  • media/video-poster-scale.html:
  • media/video-poster.html:
  • media/video-preload.html:
  • media/video-replaces-poster.html:
  • media/video-reverse-play-duration.html:
  • media/video-seek-by-small-increment.html:
  • media/video-seek-no-src-exception.html:
  • media/video-seek-past-end-paused.html:
  • media/video-seek-past-end-playing.html:
  • media/video-seekable.html:
  • media/video-seeking.html:
  • media/video-size-intrinsic-scale.html:
  • media/video-size.html:
  • media/video-source-error-no-candidate.html:
  • media/video-source-error.html:
  • media/video-source-inserted.html:
  • media/video-source-media.html:
  • media/video-source-moved.html:
  • media/video-source-none-supported.html:
  • media/video-source-removed.html:
  • media/video-source-type-params.html:
  • media/video-source-type.html:
  • media/video-source.html:
  • media/video-src-change.html:
  • media/video-src-invalid-remove.html:
  • media/video-src-none.html:
  • media/video-src-plus-source.html:
  • media/video-src-remove.html:
  • media/video-src-set.html:
  • media/video-src-source.html:
  • media/video-src.html:
  • media/video-timeupdate-during-playback.html:
  • media/video-timeupdate-reverse-play.html:
  • media/video-transformed.html:
  • media/video-volume-slider.html:
  • media/video-volume.html:
  • media/video-width-height.html:
  • media/video-zoom-controls.html:
  • media/video-zoom.html:

2011-02-16 Anna Cavender <​annacc@chromium.org>

Reviewed by Mihai Parparita.

http/tests/media should be served over HTTP (not from local file)
​https://bugs.webkit.org/show_bug.cgi?id=54028

Removed special ​file:// treatment of http/tests/media

  • Scripts/old-run-webkit-tests:
  • Scripts/webkitpy/layout_tests/port/base.py:
7:39 PM Changeset in webkit [78777] by mihaip@chromium.org
  • 3 edits in trunk/Tools

2011-02-16 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Ojan Vafai.

ChangeLog.parse_latest_entry_from_file does not handle rolled over ChangeLogs
​https://bugs.webkit.org/show_bug.cgi?id=54609

r78737 rolled over ChangeLogs, and webkit-patch complains when landing
patches such as this one that are the first to add an entry to the
ChangeLog (since they don't see a second date line to know where the
entry ends).

  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
7:05 PM Changeset in webkit [78776] by abarth@webkit.org
  • 2 edits
    25 adds in trunk/LayoutTests

2011-02-16 Adam Barth <​abarth@webkit.org>

Reviewed by Daniel Bates.

Import XSSAuditor tests from David Ross
​https://bugs.webkit.org/show_bug.cgi?id=54576

Many of these tests pass, but some of them fail as well. I'll fix the
failing tests in followup patches.

  • http/tests/security/xssAuditor/cookie-injection-expected.txt: Added.
  • http/tests/security/xssAuditor/cookie-injection.html: Added.
    • We're fine here.
  • http/tests/security/xssAuditor/form-action-expected.txt: Added.
  • http/tests/security/xssAuditor/form-action.html: Added.
    • We need to filter form actions. Previously, we considered this issue out of scope, but we should be able to handle it.
  • http/tests/security/xssAuditor/iframe-injection-expected.txt: Added.
  • http/tests/security/xssAuditor/iframe-injection.html: Added.
    • We need to filter iframe src attributes. Previously, we considered this issue out of scope, but we should be able to handle it.
  • http/tests/security/xssAuditor/iframe-javascript-url-more-encoding-expected.txt: Added.
  • http/tests/security/xssAuditor/iframe-javascript-url-more-encoding.html: Added.
    • We're fine here.
  • http/tests/security/xssAuditor/javascript-link-one-plus-one-expected.txt: Added.
  • http/tests/security/xssAuditor/javascript-link-one-plus-one.html: Added.
    • We're fine here.
  • http/tests/security/xssAuditor/open-attribute-body-expected.txt: Added.
  • http/tests/security/xssAuditor/open-attribute-body.html: Added.
  • http/tests/security/xssAuditor/open-event-handler-iframe-expected.txt: Added.
  • http/tests/security/xssAuditor/open-event-handler-iframe.html: Added.
  • http/tests/security/xssAuditor/open-iframe-src-expected.txt: Added.
  • http/tests/security/xssAuditor/open-iframe-src.html: Added.
  • http/tests/security/xssAuditor/open-script-src-expected.txt: Added.
  • http/tests/security/xssAuditor/open-script-src.html: Added.
    • These are all the same class of issue. Now that we've re-designed the filter, we should be able to address this issue.
  • http/tests/security/xssAuditor/resources/echo-inspan.pl: Added.
  • http/tests/security/xssAuditor/resources/echo-intertag.pl:
    • Tests infrastructure improvements.
  • http/tests/security/xssAuditor/script-tag-with-fancy-unicode-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-fancy-unicode.html: Added.
    • I'm not sure what's going on here. Requires futher investigation.
  • http/tests/security/xssAuditor/script-tag-with-invalid-url-encoding-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-invalid-url-encoding.html: Added.
    • We're fine here.
  • http/tests/security/xssAuditor/script-tag-with-source-data-url-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-source-data-url.html: Added.
    • We're fine here.
7:02 PM Changeset in webkit [78775] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-02-16 Abhishek Arya <​inferno@chromium.org>

Reviewed by James Robinson.

Remove the early bail added in r75823 since we can run into anonymous
blocks when traversing the parents chain for clearing floats.
​https://bugs.webkit.org/show_bug.cgi?id=54601

removeFloatingOrPositionedChildFromBlockLists tries to find the topmost
parent containing "this" block and then tries to remove it from its floats
list and mark all descendants blocks for layout. I added a bailout condition
in r75823 because we thought that if one of the parent render block does not
contain "this" float, then it is safe to assume that none of the grand parents
will have it. This is a wrong assumption since anonymous blocks do not have
float objects and we need to go higher in the chain to find the top most parent
containing this float. Instead of breaking out of the loop, it is ok to keep
traversing the chain till we find that parent. Otherwise, we will leave deleted
floats in the grand parents floats list.

Test: fast/block/float/floats-not-cleared-from-grand-parents.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):

2011-02-16 Abhishek Arya <​inferno@chromium.org>

Reviewed by James Robinson.

Tests that we do not crash when floats are not cleared in cases where parents
chain has anonymous blocks.
​https://bugs.webkit.org/show_bug.cgi?id=54601

  • fast/block/float/floats-not-cleared-from-grand-parents-expected.txt: Added.
  • fast/block/float/floats-not-cleared-from-grand-parents.html: Added.
6:54 PM Changeset in webkit [78774] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2011-02-16 James Robinson <​jamesr@chromium.org>

Fix typo in chromium test_expectations - there is no WINDOWS (just WIN)

  • platform/chromium/test_expectations.txt:
6:52 PM Changeset in webkit [78773] by andreas.kling@nokia.com
  • 10 edits in trunk

2011-02-16 Andreas Kling <​kling@webkit.org>

Reviewed by Ryosuke Niwa.

Editing styles should not emit #RRGGBBAA colors
​https://bugs.webkit.org/show_bug.cgi?id=54540

  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::extractTextStyles): Use Color::serialized() instead of Color::nameForRenderTreeAsText().

2011-02-16 Andreas Kling <​kling@webkit.org>

Reviewed by Ryosuke Niwa.

Editing styles should not emit #RRGGBBAA colors
​https://bugs.webkit.org/show_bug.cgi?id=54540

Added a test to editing/style/inline-style-container.html
that would cause invalid #RRGGBBAA output with the previous code.

  • editing/execCommand/delete-image-in-anchor-expected.txt:
  • editing/execCommand/script-tests/toggle-unlink.js:
  • editing/execCommand/toggle-unlink-expected.txt:
  • editing/style/fore-color-by-name-expected.txt:
  • editing/style/inline-style-container-expected.txt:
  • editing/style/script-tests/inline-style-container.js:
  • editing/style/style-text-node-without-editable-parent-expected.txt:
6:51 PM Changeset in webkit [78772] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-02-16 Martin Robinson <​mrobinson@igalia.com>

Update the GTK+ skipped list. Skip some SVG tests that now expose rounding
errors. Unskip a test which should have been unskipped by r78614. Skip
Acid2 tests, as they are currently failing on GTK+.

  • platform/gtk/Skipped: Update the skipped list.
6:44 PM Changeset in webkit [78771] by jamesr@google.com
  • 11 edits
    1 add in trunk/LayoutTests

2011-02-16 James Robinson <​jamesr@chromium.org>

Update chromium baselines for 78751.

  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-path-05-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-path-05-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-path-05-f-expected.txt: Added.
  • platform/chromium-linux/svg/clip-path/clip-path-clipped-evenodd-twice-expected.checksum:
  • platform/chromium-linux/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-path-05-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-path-05-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-path-05-f-expected.txt:
  • platform/chromium-win/svg/clip-path/clip-path-clipped-evenodd-twice-expected.checksum:
  • platform/chromium-win/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png:
  • platform/chromium/test_expectations.txt:
6:44 PM Changeset in webkit [78770] by mrowe@apple.com
  • 2 edits in branches/safari-534.20-branch/Source/WebCore

Merge r78687.

6:39 PM Changeset in webkit [78769] by mrowe@apple.com
  • 16 edits in branches/safari-534.20-branch/Source/WebKit2

Merge r78676.

6:39 PM Changeset in webkit [78768] by mrowe@apple.com
  • 11 edits in branches/safari-534.20-branch/Source/WebKit2

Merge r78663.

6:38 PM Changeset in webkit [78767] by mrowe@apple.com
  • 14 edits
    1 copy
    1 add in branches/safari-534.20-branch/Source/WebKit2

Merge r78647.

6:38 PM Changeset in webkit [78766] by mrowe@apple.com
  • 2 edits in branches/safari-534.20-branch/Source/WebKit2

Merge r78638.

6:38 PM Changeset in webkit [78765] by mrowe@apple.com
  • 9 edits
    2 adds in branches/safari-534.20-branch/Source/WebKit2

Merge r78633.

6:37 PM Changeset in webkit [78764] by mrowe@apple.com
  • 3 edits in branches/safari-534.20-branch/Source/WebKit2

Merge r78611.

6:37 PM Changeset in webkit [78763] by mrowe@apple.com
  • 4 edits in branches/safari-534.20-branch/Source/WebCore

Merge r78604.

6:37 PM Changeset in webkit [78762] by mrowe@apple.com
  • 2 edits in branches/safari-534.20-branch/Source/WebKit2

Merge r78730.

6:32 PM Changeset in webkit [78761] by rniwa@webkit.org
  • 9 edits in trunk/Source/WebCore

2011-02-16 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Kent Tamura.

Improve showTree of Range, Position, and VisiblePosition
​https://bugs.webkit.org/show_bug.cgi?id=54536

Enhanced showTree of Range, Position, and VisiblePosition.

  • dom/Position.cpp: (WebCore::Position::showAnchorTypeAndOffset): Added; dumps "legacy" if the position is a legacy position and also dumps anchor type. (WebCore::Position::showTreeForThis): Calls showAnchorTypeAndOffset.
  • dom/Position.h:
  • dom/Range.cpp: (showTree): No longer calls deprecatedEditingOffset.
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::debugPosition): No longer included in release build. Calls Position::showAnchorTypeAndOffset instead of manually calling deprecatedEditingOffset.
  • editing/VisiblePosition.h:
  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::debugPosition): Ditto. (WebCore::VisibleSelection::showTreeForThis): Ditto.
  • editing/VisibleSelection.h:
  • page/EventHandler.cpp:
6:32 PM Changeset in webkit [78760] by pkasting@chromium.org
  • 2 edits
    2 deletes in trunk/LayoutTests

Unreviewed, Chromium expectations update.

Removed duplicate expected results, update some test expectations.

  • platform/chromium-mac/svg/clip-path/clip-path-clipped-evenodd-twice-expected.checksum: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
6:28 PM Changeset in webkit [78759] by jorlow@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-16 David Grogan <​dgrogan@chromium.org>

Reviewed by Jeremy Orlow.

fix compile error introduced in 78752
​https://bugs.webkit.org/show_bug.cgi?id=54604

  • storage/IDBRequest.h:
6:20 PM Changeset in webkit [78758] by jorlow@chromium.org
  • 11 edits in trunk/Source

2011-02-16 Jeremy Orlow <​jorlow@chromium.org>

Back out IndexedDB change thats no longer necessary
​https://bugs.webkit.org/show_bug.cgi?id=54603

Backing out 78645 as it turns out that it's not necessary.

  • storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::open):
  • storage/IDBFactoryBackendImpl.h:
  • storage/IDBFactoryBackendInterface.h:

2011-02-16 Jeremy Orlow <​jorlow@chromium.org>

Back out IndexedDB change thats no longer necessary
​https://bugs.webkit.org/show_bug.cgi?id=54603

Backing out 78645 as it turns out that it's not necessary.

  • public/WebIDBFactory.h: (WebKit::WebIDBFactory::open):
  • src/AssertMatchingEnums.cpp:
  • src/IDBFactoryBackendProxy.cpp:
  • src/IDBFactoryBackendProxy.h:
  • src/WebIDBFactoryImpl.cpp: (WebKit::WebIDBFactoryImpl::open):
  • src/WebIDBFactoryImpl.h:
5:39 PM Changeset in webkit [78757] by mrowe@apple.com
  • 3 edits in branches/safari-534.20-branch/Source/WebCore

Merge r78616.

5:26 PM Changeset in webkit [78756] by kbr@google.com
  • 2 edits in trunk/LayoutTests

2011-02-16 Kenneth Russell <​kbr@google.com>

Unreviewed. Skip recently added tests for adjusting minimum timer
interval per page due to absence of
LayoutTestController.setMinimumTimerInterval.

  • platform/mac-wk2/Skipped:
5:20 PM Changeset in webkit [78755] by Martin Robinson
  • 2 edits
    228 adds in trunk/LayoutTests

2011-02-16 Martin Robinson <​mrobinson@igalia.com>

Add the next set of GTK+ baselines for the Mozilla tables test suite.

  • platform/gtk/Skipped: Unskip tests which now have results.
5:10 PM Changeset in webkit [78754] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-16 Brian Salomon <​bsalomon@google.com>

Reviewed by James Robinson.

Skia's gpu backed just needs the correct context bound before drawing. It will bind the correct FBO itself and doing so externally confuses it unless resetContext is called.

No new tests required.

  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::syncSoftwareCanvas):
5:08 PM Changeset in webkit [78753] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-16 Mike Reed <​reed@google.com>

Reviewed by Kenneth Russell.

Use non-asserting pack function for decoding images, since webgl may want
a non-premultiplied version of the image.
​https://bugs.webkit.org/show_bug.cgi?id=54023

No new tests.
fast/canvas/webgl/gl-teximage.html
fast/canvas/webgl/tex-image-with-format-and-type.html
fast/canvas/webgl/texture-transparent-pixels-initialized.html

  • platform/image-decoders/ImageDecoder.h: (WebCore::ImageFrame::setRGBA):
4:55 PM Changeset in webkit [78752] by jorlow@chromium.org
  • 26 edits
    5 copies
    5 adds in trunk

2011-02-16 David Grogan <​dgrogan@chromium.org>

Reviewed by Jeremy Orlow.

indexeddb: make setVersion fire blocked event if other connections are open
​https://bugs.webkit.org/show_bug.cgi?id=53728

Tests: storage/indexeddb/set_version_blocked.html

storage/indexeddb/set_version_queue.html

  • WebCore.gypi:
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • bindings/v8/custom/V8EventCustom.cpp: (WebCore::toV8):
  • dom/Event.cpp: (WebCore::Event::isIDBVersionChangeEvent):
  • dom/Event.h:
  • dom/EventNames.h:
  • dom/EventTarget.cpp: (WebCore::EventTarget::toIDBVersionChangeRequest):
  • dom/EventTarget.h:
  • storage/IDBCallbacks.h:
  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::setVersion): (WebCore::IDBDatabase::close):
  • storage/IDBDatabase.h:
  • storage/IDBDatabase.idl:
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::create): (WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::version): (WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::callbacks): (WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::PendingSetVersionCall): (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl): (WebCore::IDBDatabaseBackendImpl::setVersion): (WebCore::IDBDatabaseBackendImpl::open): (WebCore::IDBDatabaseBackendImpl::close):
  • storage/IDBDatabaseBackendImpl.h:
  • storage/IDBDatabaseBackendInterface.h:
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::open):
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::onBlocked): (WebCore::IDBRequest::dispatchEvent): (WebCore::IDBRequest::source):
  • storage/IDBRequest.h:
  • storage/IDBVersionChangeEvent.cpp: Copied from Source/WebKit/chromium/src/WebIDBCallbacksImpl.h. (WebCore::IDBVersionChangeEvent::create): (WebCore::IDBVersionChangeEvent::IDBVersionChangeEvent): (WebCore::IDBVersionChangeEvent::~IDBVersionChangeEvent): (WebCore::IDBVersionChangeEvent::version):
  • storage/IDBVersionChangeEvent.h: Copied from Source/WebKit/chromium/src/WebIDBCallbacksImpl.h. (WebCore::IDBVersionChangeEvent::isIDBVersionChangeEvent):
  • storage/IDBVersionChangeEvent.idl: Added.
  • storage/IDBVersionChangeRequest.cpp: Copied from Source/WebKit/chromium/src/WebIDBCallbacksImpl.h. (WebCore::IDBVersionChangeRequest::create): (WebCore::IDBVersionChangeRequest::IDBVersionChangeRequest): (WebCore::IDBVersionChangeRequest::~IDBVersionChangeRequest): (WebCore::IDBVersionChangeRequest::onBlocked):
  • storage/IDBVersionChangeRequest.h: Copied from Source/WebKit/chromium/src/WebIDBCallbacksImpl.h.
  • storage/IDBVersionChangeRequest.idl: Copied from Source/WebKit/chromium/src/WebIDBCallbacksImpl.h.
4:50 PM Changeset in webkit [78751] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-16 Robin Cao <​robin.cao@torchmobile.com.cn>

Reviewed by James Robinson.

PlatformContextSkia::applyAntiAliasedClipPaths does not work for paths which have evenOdd property
​https://bugs.webkit.org/show_bug.cgi?id=54336

We need to take fill type of paths into account when drawing them.

No new tests, covered by svg/W3C-SVG-1.1/masking-path-05-f.svg.

  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::applyAntiAliasedClipPaths):
4:50 PM Changeset in webkit [78750] by Martin Robinson
  • 2 edits
    225 adds in trunk/LayoutTests

2011-02-16 Martin Robinson <​mrobinson@igalia.com>

Add the next set of GTK+ Mozilla test suite results.

  • platform/gtk/Skipped: Unskip tests that now have results.
4:50 PM Changeset in webkit [78749] by joone.hur@collabora.co.uk
  • 4 edits in trunk/Source/WebKit/gtk

2011-02-16 Joone Hur <​joone.hur@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] Match more various WebKit API enum values with WebCore enum values
​https://bugs.webkit.org/show_bug.cgi?id=54352

AssertMatchingEnums.cpp was added to assert that various WebKit API enum values
continue matching WebCore defined enum values in the following changeset.
​http://trac.webkit.org/changeset/77868
However, there are already enum values that have been asserted in other files,
so these assert macros defined need to be moved to AssertMatchingEnum.cpp.

  • WebCoreSupport/AssertMatchingEnums.cpp: Add more enum values to be asserted.
  • webkit/webkitwebnavigationaction.cpp: (webkit_web_navigation_action_class_init): Move the assert macros of WEBKIT_WEB_NAVIGATION_REASON_* to AssertMatchingEnums.cpp.
  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): Move the assert macros of WEBKIT_EDITING_BEHAVIOR_* to AssertMatchingEnums.cpp.
4:35 PM Changeset in webkit [78748] by Martin Robinson
  • 2 edits
    225 adds in trunk/LayoutTests

2011-02-16 Martin Robinson <​mrobinson@igalia.com>

Add another group of GTK+ Mozilla test results.

  • platform/gtk/Skipped: Unskip tests which now have results.
4:31 PM Changeset in webkit [78747] by eric@webkit.org
  • 3 edits
    3 adds in trunk

2011-02-16 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION (r61234): washingtonpost.com top bar looks wrong, doesn't animate
​https://bugs.webkit.org/show_bug.cgi?id=53717

  • http/tests/local/absolute-url-strip-whitespace-expected.txt: Added.
  • http/tests/local/absolute-url-strip-whitespace.html: Added.
  • http/tests/resources/absolute-url-strip-whitespace.js: Added.

2011-02-16 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION (r61234): washingtonpost.com top bar looks wrong, doesn't animate
​https://bugs.webkit.org/show_bug.cgi?id=53717

Test: http/tests/local/absolute-url-strip-whitespace.html

This was theoretically tested already in fast/url, however the
tests were disabled due to lack of any clean way to test absolute
url parsing in JavaScript. I added a test which mimics the sites
behavior using our local http server. There seems to be no other
way to test this at the moment.

  • platform/KURL.cpp: (WebCore::shouldTrimFromURL):
    • Any char 0-20 should be removed (matches google-url and other browsers).

(WebCore::KURL::init):

4:24 PM Changeset in webkit [78746] by Martin Robinson
  • 2 edits
    150 adds in trunk/LayoutTests

2011-02-16 Martin Robinson <​mrobinson@igalia.com>

Add another batch of GTK+ Mozilla test suite results.

  • platform/gtk/Skipped: Unskip tests which now have results.
4:05 PM Changeset in webkit [78745] by Martin Robinson
  • 2 edits
    150 adds in trunk/LayoutTests

2011-02-16 Martin Robinson <​mrobinson@igalia.com>

Add another group of GTK+ Mozilla test suite baselines.

  • platform/gtk/Skipped: Unskip tests that now have baselines.
4:00 PM Changeset in webkit [78744] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-02-16 Abhishek Arya <​inferno@chromium.org>

Reviewed by James Robinson.

Tests that we do not crash when finding the text fragment for a first letter.
​https://bugs.webkit.org/show_bug.cgi?id=54568

  • fast/css/first-letter-text-fragment-crash-expected.txt: Added.
  • fast/css/first-letter-text-fragment-crash.html: Added.

2011-02-16 Abhishek Arya <​inferno@chromium.org>

Reviewed by James Robinson.

Traverse the next sibling tree to find the text fragment for a first letter.
​https://bugs.webkit.org/show_bug.cgi?id=54568

We cannot assume that the next sibling to the first letter will a text fragment
since there can be intermediatary Apple-style-span inline elements wrapping the
text fragment. So, we traverse the next sibling tree to find it.
Test: fast/css/first-letter-text-fragment-crash.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter):
3:57 PM Changeset in webkit [78743] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

2011-02-16 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] r78718 introduced some assertion failures in some HTTP tests
​https://bugs.webkit.org/show_bug.cgi?id=54592

No new tests. This fix is covered by tests that are currently failing.

  • platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::updateFromSoupMessage): Instead of setting the existing headers and then selectively removing ones that do not exist in the updated soup message, just remove all headers from the map first.
3:54 PM Changeset in webkit [78742] by Martin Robinson
  • 2 edits
    150 adds in trunk/LayoutTests

2011-02-16 Martin Robinson <​mrobinson@igalia.com>

Add the next batch of GTK+ Mozilla test results.

  • platform/gtk/Skipped: Unskip tests which now have results.
3:37 PM Changeset in webkit [78741] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-02-16 Martin Robinson <​mrobinson@igalia.com>

Rebaseline media/controls-without-preload.html after r78695.

  • media/controls-without-preload-expected.txt: Rebaselined.
3:17 PM Changeset in webkit [78740] by pkasting@chromium.org
  • 2 edits
    8 adds in trunk/LayoutTests

Unreviewed, Chromium expectations update.

​https://bugs.webkit.org/show_bug.cgi?id=54579
Add expectations for where V8 passes tests JSC doesn't, or merely has
different errors; mark other failing tests with a V8 tracking bug.

  • platform/chromium/fast/js/mozilla: Added.
  • platform/chromium/fast/js/mozilla/strict: Added.
  • platform/chromium/fast/js/mozilla/strict/11.1.5-expected.txt: Added.
  • platform/chromium/fast/js/mozilla/strict/12.14.1-expected.txt: Added.
  • platform/chromium/fast/js/mozilla/strict/13.1-expected.txt: Added.
  • platform/chromium/fast/js/mozilla/strict/15.3.4.5-expected.txt: Added.
  • platform/chromium/fast/js/mozilla/strict/15.3.5.2-expected.txt: Added.
  • platform/chromium/fast/js/mozilla/strict/regress-532254-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
3:08 PM Changeset in webkit [78739] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-16 Mihai Parparita <​mihaip@chromium.org>

Unreviewed chromium-gpu expectations update. Add more tests that fail
because of bug 54409.

  • platform/chromium/test_expectations.txt:
2:46 PM Changeset in webkit [78738] by jianli@chromium.org
  • 5 edits in trunk

[V8] DataView constructor can be applied as a regular method
​https://bugs.webkit.org/show_bug.cgi?id=54563

Reviewed by Kenneth Russell.

Source/WebCore:

Tested by adding a new test case to fast/canvas/webgl/data-view-test.html.

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::constructorCallback):

LayoutTests:

Added a new test case.

  • fast/canvas/webgl/data-view-test-expected.txt:
  • fast/canvas/webgl/data-view-test.html:
2:30 PM Changeset in webkit [78737] by mrowe@apple.com
  • 7 edits
    7 copies in trunk

Roll over some ChangeLogs.

2:25 PM Changeset in webkit [78736] by Martin Robinson
  • 2 edits
    152 adds in trunk/LayoutTests

2011-02-16 Martin Robinson <​mrobinson@igalia.com>

Begin adding GTK+ baselines for Mozilla test suites.

  • platform/gtk/Skipped: Unskip tests which now have results.
2:21 PM Changeset in webkit [78735] by jamesr@google.com
  • 3 edits in branches/chromium/648/Source/WebCore/dom

Fix compile on Chromium 648 branch

1:52 PM Changeset in webkit [78734] by pkasting@chromium.org
  • 2 edits
    2 deletes in trunk/LayoutTests

Unreviewed, Chromium test expectations update.

Remove a mac-leopard expectation since the Chromium Mac 10.5 bots at
least seem to be generating results that match the platform/mac images.

  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/fast/forms/select-empty-option-height-expected.checksum: Removed.
  • platform/mac-leopard/fast/forms/select-empty-option-height-expected.png: Removed.
1:48 PM Changeset in webkit [78733] by jamesr@google.com
  • 9 edits
    4 copies in branches/chromium/648

Merge 78648 - 2011-02-15 James Robinson <​jamesr@chromium.org>

Reviewed by Alexey Proskuryakov.

requestAnimationFrame callbacks should not fire within a modal dialog
​https://bugs.webkit.org/show_bug.cgi?id=53188

Tests that requestAnimationFrame callbacks are suspended while a modal
dialog is showing.

  • fast/animation/request-animation-frame-during-modal-expected.txt: Added.
  • fast/animation/request-animation-frame-during-modal.html: Added.

2011-02-15 James Robinson <​jamesr@chromium.org>

Reviewed by Alexey Proskuryakov.

requestAnimationFrame callbacks should not fire within a modal dialog
​https://bugs.webkit.org/show_bug.cgi?id=53188

requestAnimationFrame callbacks shouldn't fire while a modal dialog is up (like a window.alert()).
This matches Firefox and other async APIs. This patch moves the callback servicing into its own
controller class which receives notifications on suspend/resume.

Test: fast/animation/request-animation-frame-during-modal.html

  • WebCore.gypi:
  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setJavaScriptPaused):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::suspendScriptedAnimationControllerCallbacks): (WebCore::Document::resumeScriptedAnimationControllerCallbacks): (WebCore::Document::webkitRequestAnimationFrame): (WebCore::Document::webkitCancelRequestAnimationFrame): (WebCore::Document::serviceScriptedAnimations):
  • dom/Document.h:
  • dom/ScriptExecutionContext.h: (WebCore::ScriptExecutionContext::suspendScriptedAnimationControllerCallbacks): (WebCore::ScriptExecutionContext::resumeScriptedAnimationControllerCallbacks):
  • dom/ScriptedAnimationController.cpp: Added. (WebCore::ScriptedAnimationController::ScriptedAnimationController): (WebCore::ScriptedAnimationController::suspend): (WebCore::ScriptedAnimationController::resume): (WebCore::ScriptedAnimationController::registerCallback): (WebCore::ScriptedAnimationController::cancelCallback): (WebCore::ScriptedAnimationController::serviceScriptedAnimations):
  • dom/ScriptedAnimationController.h: Added. (WebCore::ScriptedAnimationController::create):
  • history/CachedFrame.cpp: (WebCore::CachedFrameBase::restore): (WebCore::CachedFrame::CachedFrame):
  • page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):

TBR=​jamesr@google.com
Review URL: ​http://codereview.chromium.org/6537003

1:35 PM Changeset in webkit [78732] by barraclough@apple.com
  • 55 edits in trunk/Source

Bug 54524 - Allow JSObject to fully utilize cell's capacity for inline storage.

Reviewed by Geoff Garen.

Currently JSObject is both directly instantiated for regular JS objects, and
derived to implement subtypes. A consequence of this is that we need to ensure
that sufficient space from the cell is left unused and available for any data
members that will be introduced by subclasses of JSObject. By restructuring
the internal storage array out of JSObject we can increase the size in the
internal storage for regular objects.

Add classes JSFinalObject and JSNonFinalObject. JSNonFinalObject retains as
much additional capacity as is currently available to allow for data members
in subclasses. JSFinalObject utilizes all available space for internal storage,
and only allows construction through JSFinalObject::create().

Source/JavaScriptCore:

The additional storage made available in the JSObject means that we need no
longer rely on a union of the internal storage with a pointer to storage that
is only valid for external storage. This means we can go back to always having
a valid pointer to property storage, regardless of whether this is internal or
external. This simplifies some cases of access to the array from C code, and
significantly simplifies JIT access, since repatching no longer needs to be
able to change between a load of the storage pointer / a LEA of the internal
storage.

  • API/JSObjectRef.cpp:

(JSObjectMake):

  • assembler/ARMAssembler.h:
  • assembler/ARMv7Assembler.h:
  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::repatchPointer):

  • assembler/MIPSAssembler.h:
  • assembler/MacroAssemblerARM.h:
  • assembler/MacroAssemblerARMv7.h:
  • assembler/MacroAssemblerMIPS.h:
  • assembler/MacroAssemblerX86.h:
  • assembler/MacroAssemblerX86_64.h:
  • assembler/RepatchBuffer.h:
  • assembler/X86Assembler.h:
  • debugger/DebuggerActivation.cpp:

(JSC::DebuggerActivation::DebuggerActivation):

  • debugger/DebuggerActivation.h:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JIT.h:
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_resolve_global):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_resolve_global):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::emit_op_get_by_pname):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::patchGetByIdSelf):
(JSC::JIT::patchPutByIdReplace):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::patchGetByIdSelf):
(JSC::JIT::patchPutByIdReplace):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
(JSC::JIT::emit_op_get_by_pname):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Arguments.h:

(JSC::Arguments::Arguments):

  • runtime/ErrorInstance.cpp:

(JSC::ErrorInstance::ErrorInstance):

  • runtime/ErrorInstance.h:
  • runtime/ExceptionHelpers.cpp:

(JSC::InterruptedExecutionError::InterruptedExecutionError):
(JSC::TerminatedExecutionError::TerminatedExecutionError):

  • runtime/JSArray.cpp:

(JSC::JSArray::JSArray):

  • runtime/JSArray.h:
  • runtime/JSByteArray.cpp:

(JSC::JSByteArray::JSByteArray):

  • runtime/JSByteArray.h:

(JSC::JSByteArray::JSByteArray):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::getOwnPropertySlot):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalObject.h:

(JSC::constructEmptyObject):

  • runtime/JSNotAnObject.h:

(JSC::JSNotAnObject::JSNotAnObject):

  • runtime/JSObject.cpp:

(JSC::JSObject::createInheritorID):
(JSC::JSObject::allocatePropertyStorage):

  • runtime/JSObject.h:

(JSC::JSObject::propertyStorage):
(JSC::JSNonFinalObject::JSNonFinalObject):
(JSC::JSNonFinalObject::createStructure):
(JSC::JSFinalObject::create):
(JSC::JSFinalObject::createStructure):
(JSC::JSFinalObject::JSFinalObject):
(JSC::JSObject::offsetOfInlineStorage):
(JSC::constructEmptyObject):
(JSC::createEmptyObjectStructure):
(JSC::JSObject::JSObject):
(JSC::JSObject::~JSObject):
(JSC::Structure::isUsingInlineStorage):

  • runtime/JSObjectWithGlobalObject.cpp:

(JSC::JSObjectWithGlobalObject::JSObjectWithGlobalObject):

  • runtime/JSObjectWithGlobalObject.h:

(JSC::JSObjectWithGlobalObject::JSObjectWithGlobalObject):

  • runtime/JSTypeInfo.h:

(JSC::TypeInfo::TypeInfo):
(JSC::TypeInfo::isVanilla):

  • runtime/JSVariableObject.h:

(JSC::JSVariableObject::JSVariableObject):

  • runtime/JSWrapperObject.h:

(JSC::JSWrapperObject::JSWrapperObject):

  • runtime/ObjectConstructor.cpp:

(JSC::constructObject):

  • runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::ObjectPrototype):

  • runtime/ObjectPrototype.h:
  • runtime/StrictEvalActivation.cpp:

(JSC::StrictEvalActivation::StrictEvalActivation):

  • runtime/StrictEvalActivation.h:
  • runtime/Structure.cpp:

(JSC::Structure::Structure):
(JSC::Structure::growPropertyStorageCapacity):

Source/JavaScriptGlue:

  • UserObjectImp.cpp:
  • UserObjectImp.h:

Update JSObject -> JSNonFinalObject.

Source/WebCore:

  • bindings/js/JSDOMWindowShell.h:

Update JSObject -> JSNonFinalObject.

1:26 PM Changeset in webkit [78731] by oliver@apple.com
  • 1 edit
    196 adds in trunk/LayoutTests

2011-02-16 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Import some mozilla js strict mode regression tests
​https://bugs.webkit.org/show_bug.cgi?id=54579

Add a bunch of the mozilla strict mode tests, the majority of the tests pass.
Those that fail fall into two categories

  • Tests for features we haven't implemented
  • Tests that test behaviour of arrays and arguments with non-writable properties
  • fast/js/mozilla/eval/exhaustive-fun-normalcaller-direct-normalcode-expected.txt: Added.
  • fast/js/mozilla/eval/exhaustive-fun-normalcaller-direct-normalcode.html: Added.
  • fast/js/mozilla/eval/exhaustive-fun-normalcaller-direct-strictcode-expected.txt: Added.
  • fast/js/mozilla/eval/exhaustive-fun-normalcaller-direct-strictcode.html: Added.
  • fast/js/mozilla/eval/exhaustive-fun-normalcaller-indirect-normalcode-expected.txt: Added.
  • fast/js/mozilla/eval/exhaustive-fun-normalcaller-indirect-normalcode.html: Added.
  • fast/js/mozilla/eval/exhaustive-fun-normalcaller-indirect-strictcode-expected.txt: Added.
  • fast/js/mozilla/eval/exhaustive-fun-normalcaller-indirect-strictcode.html: Added.
  • fast/js/mozilla/eval/exhaustive-fun-strictcaller-direct-normalcode-expected.txt: Added.
  • fast/js/mozilla/eval/exhaustive-fun-strictcaller-direct-normalcode.html: Added.
  • fast/js/mozilla/eval/exhaustive-fun-strictcaller-direct-strictcode-expected.txt: Added.
  • fast/js/mozilla/eval/exhaustive-fun-strictcaller-direct-strictcode.html: Added.
  • fast/js/mozilla/eval/exhaustive-fun-strictcaller-indirect-normalcode-expected.txt: Added.
  • fast/js/mozilla/eval/exhaustive-fun-strictcaller-indirect-normalcode.html: Added.
  • fast/js/mozilla/eval/exhaustive-fun-strictcaller-indirect-strictcode-expected.txt: Added.
  • fast/js/mozilla/eval/exhaustive-fun-strictcaller-indirect-strictcode.html: Added.
  • fast/js/mozilla/eval/exhaustive-global-normalcaller-direct-normalcode-expected.txt: Added.
  • fast/js/mozilla/eval/exhaustive-global-normalcaller-direct-normalcode.html: Added.
  • fast/js/mozilla/eval/exhaustive-global-normalcaller-direct-strictcode-expected.txt: Added.
  • fast/js/mozilla/eval/exhaustive-global-normalcaller-direct-strictcode.html: Added.
  • fast/js/mozilla/eval/exhaustive-global-normalcaller-indirect-normalcode-expected.txt: Added.
  • fast/js/mozilla/eval/exhaustive-global-normalcaller-indirect-normalcode.html: Added.
  • fast/js/mozilla/eval/exhaustive-global-normalcaller-indirect-strictcode-expected.txt: Added.
  • fast/js/mozilla/eval/exhaustive-global-normalcaller-indirect-strictcode.html: Added.
  • fast/js/mozilla/eval/exhaustive-global-strictcaller-direct-normalcode-expected.txt: Added.
  • fast/js/mozilla/eval/exhaustive-global-strictcaller-direct-normalcode.html: Added.
  • fast/js/mozilla/eval/exhaustive-global-strictcaller-direct-strictcode-expected.txt: Added.
  • fast/js/mozilla/eval/exhaustive-global-strictcaller-direct-strictcode.html: Added.
  • fast/js/mozilla/eval/exhaustive-global-strictcaller-indirect-normalcode-expected.txt: Added.
  • fast/js/mozilla/eval/exhaustive-global-strictcaller-indirect-normalcode.html: Added.
  • fast/js/mozilla/eval/exhaustive-global-strictcaller-indirect-strictcode-expected.txt: Added.
  • fast/js/mozilla/eval/exhaustive-global-strictcaller-indirect-strictcode.html: Added.
  • fast/js/mozilla/eval/script-tests/TEMPLATE.html: Added.
  • fast/js/mozilla/eval/script-tests/exhaustive-fun-normalcaller-direct-normalcode.js: Added.
  • fast/js/mozilla/eval/script-tests/exhaustive-fun-normalcaller-direct-strictcode.js: Added.
  • fast/js/mozilla/eval/script-tests/exhaustive-fun-normalcaller-indirect-normalcode.js: Added.
  • fast/js/mozilla/eval/script-tests/exhaustive-fun-normalcaller-indirect-strictcode.js: Added.
  • fast/js/mozilla/eval/script-tests/exhaustive-fun-strictcaller-direct-normalcode.js: Added.
  • fast/js/mozilla/eval/script-tests/exhaustive-fun-strictcaller-direct-strictcode.js: Added.
  • fast/js/mozilla/eval/script-tests/exhaustive-fun-strictcaller-indirect-normalcode.js: Added.
  • fast/js/mozilla/eval/script-tests/exhaustive-fun-strictcaller-indirect-strictcode.js: Added.
  • fast/js/mozilla/eval/script-tests/exhaustive-global-normalcaller-direct-normalcode.js: Added.
  • fast/js/mozilla/eval/script-tests/exhaustive-global-normalcaller-direct-strictcode.js: Added.
  • fast/js/mozilla/eval/script-tests/exhaustive-global-normalcaller-indirect-normalcode.js: Added.
  • fast/js/mozilla/eval/script-tests/exhaustive-global-normalcaller-indirect-strictcode.js: Added.
  • fast/js/mozilla/eval/script-tests/exhaustive-global-strictcaller-direct-normalcode.js: Added.
  • fast/js/mozilla/eval/script-tests/exhaustive-global-strictcaller-direct-strictcode.js: Added.
  • fast/js/mozilla/eval/script-tests/exhaustive-global-strictcaller-indirect-normalcode.js: Added.
  • fast/js/mozilla/eval/script-tests/exhaustive-global-strictcaller-indirect-strictcode.js: Added.
  • fast/js/mozilla/eval/script-tests/undeclared-name-in-nested-strict-eval.js: Added.
  • fast/js/mozilla/eval/undeclared-name-in-nested-strict-eval-expected.txt: Added.
  • fast/js/mozilla/eval/undeclared-name-in-nested-strict-eval.html: Added.
  • fast/js/mozilla/resources/js-test-post-async.js: Added.
  • fast/js/mozilla/resources/js-test-post-function.js: Added.
  • fast/js/mozilla/resources/js-test-post-n.js: Added.
  • fast/js/mozilla/resources/js-test-post.js: Added.
  • fast/js/mozilla/resources/js-test-pre.js: Added.
  • fast/js/mozilla/resources/js-test-style.css: Added.
  • fast/js/mozilla/resources/mozilla-es5-shell.js: Added.
  • fast/js/mozilla/resources/mozilla-shell.js: Added.
  • fast/js/mozilla/strict/10.4.2-expected.txt: Added.
  • fast/js/mozilla/strict/10.4.2.html: Added.
  • fast/js/mozilla/strict/10.4.3-expected.txt: Added.
  • fast/js/mozilla/strict/10.4.3.html: Added.
  • fast/js/mozilla/strict/10.6-expected.txt: Added.
  • fast/js/mozilla/strict/10.6.html: Added.
  • fast/js/mozilla/strict/11.1.5-expected.txt: Added.
  • fast/js/mozilla/strict/11.1.5.html: Added.
  • fast/js/mozilla/strict/11.13.1-expected.txt: Added.
  • fast/js/mozilla/strict/11.13.1.html: Added.
  • fast/js/mozilla/strict/11.13.2-expected.txt: Added.
  • fast/js/mozilla/strict/11.13.2.html: Added.
  • fast/js/mozilla/strict/11.3.1-expected.txt: Added.
  • fast/js/mozilla/strict/11.3.1.html: Added.
  • fast/js/mozilla/strict/11.3.2-expected.txt: Added.
  • fast/js/mozilla/strict/11.3.2.html: Added.
  • fast/js/mozilla/strict/11.4.1-expected.txt: Added.
  • fast/js/mozilla/strict/11.4.1.html: Added.
  • fast/js/mozilla/strict/11.4.4-expected.txt: Added.
  • fast/js/mozilla/strict/11.4.4.html: Added.
  • fast/js/mozilla/strict/11.4.5-expected.txt: Added.
  • fast/js/mozilla/strict/11.4.5.html: Added.
  • fast/js/mozilla/strict/12.10.1-expected.txt: Added.
  • fast/js/mozilla/strict/12.10.1.html: Added.
  • fast/js/mozilla/strict/12.14.1-expected.txt: Added.
  • fast/js/mozilla/strict/12.14.1.html: Added.
  • fast/js/mozilla/strict/12.2.1-expected.txt: Added.
  • fast/js/mozilla/strict/12.2.1.html: Added.
  • fast/js/mozilla/strict/13.1-expected.txt: Added.
  • fast/js/mozilla/strict/13.1.html: Added.
  • fast/js/mozilla/strict/15.10.7-expected.txt: Added.
  • fast/js/mozilla/strict/15.10.7.html: Added.
  • fast/js/mozilla/strict/15.3.4.5-expected.txt: Added.
  • fast/js/mozilla/strict/15.3.4.5.html: Added.
  • fast/js/mozilla/strict/15.3.5.1-expected.txt: Added.
  • fast/js/mozilla/strict/15.3.5.1.html: Added.
  • fast/js/mozilla/strict/15.3.5.2-expected.txt: Added.
  • fast/js/mozilla/strict/15.3.5.2.html: Added.
  • fast/js/mozilla/strict/15.4.4.12-expected.txt: Added.
  • fast/js/mozilla/strict/15.4.4.12.html: Added.
  • fast/js/mozilla/strict/15.4.4.13-expected.txt: Added.
  • fast/js/mozilla/strict/15.4.4.13.html: Added.
  • fast/js/mozilla/strict/15.4.4.6-expected.txt: Added.
  • fast/js/mozilla/strict/15.4.4.6.html: Added.
  • fast/js/mozilla/strict/15.4.4.8-expected.txt: Added.
  • fast/js/mozilla/strict/15.4.4.8.html: Added.
  • fast/js/mozilla/strict/15.4.4.9-expected.txt: Added.
  • fast/js/mozilla/strict/15.4.4.9.html: Added.
  • fast/js/mozilla/strict/15.4.5.1-expected.txt: Added.
  • fast/js/mozilla/strict/15.4.5.1.html: Added.
  • fast/js/mozilla/strict/15.5.5.1-expected.txt: Added.
  • fast/js/mozilla/strict/15.5.5.1.html: Added.
  • fast/js/mozilla/strict/15.5.5.2-expected.txt: Added.
  • fast/js/mozilla/strict/15.5.5.2.html: Added.
  • fast/js/mozilla/strict/8.12.5-expected.txt: Added.
  • fast/js/mozilla/strict/8.12.5.html: Added.
  • fast/js/mozilla/strict/8.12.7-expected.txt: Added.
  • fast/js/mozilla/strict/8.12.7.html: Added.
  • fast/js/mozilla/strict/8.7.2-expected.txt: Added.
  • fast/js/mozilla/strict/8.7.2.html: Added.
  • fast/js/mozilla/strict/B.1.1-expected.txt: Added.
  • fast/js/mozilla/strict/B.1.1.html: Added.
  • fast/js/mozilla/strict/B.1.2-expected.txt: Added.
  • fast/js/mozilla/strict/B.1.2.html: Added.
  • fast/js/mozilla/strict/assign-to-callee-name-expected.txt: Added.
  • fast/js/mozilla/strict/assign-to-callee-name.html: Added.
  • fast/js/mozilla/strict/directive-prologue-01-expected.txt: Added.
  • fast/js/mozilla/strict/directive-prologue-01.html: Added.
  • fast/js/mozilla/strict/eval-variable-environment-expected.txt: Added.
  • fast/js/mozilla/strict/eval-variable-environment.html: Added.
  • fast/js/mozilla/strict/function-name-arity-expected.txt: Added.
  • fast/js/mozilla/strict/function-name-arity.html: Added.
  • fast/js/mozilla/strict/primitive-this-no-writeback-expected.txt: Added.
  • fast/js/mozilla/strict/primitive-this-no-writeback.html: Added.
  • fast/js/mozilla/strict/regress-532041-expected.txt: Added.
  • fast/js/mozilla/strict/regress-532041.html: Added.
  • fast/js/mozilla/strict/regress-532254-expected.txt: Added.
  • fast/js/mozilla/strict/regress-532254.html: Added.
  • fast/js/mozilla/strict/regress-599159-expected.txt: Added.
  • fast/js/mozilla/strict/regress-599159.html: Added.
  • fast/js/mozilla/strict/script-tests/10.4.2.js: Added.
  • fast/js/mozilla/strict/script-tests/10.4.3.js: Added.
  • fast/js/mozilla/strict/script-tests/10.6.js: Added.
  • fast/js/mozilla/strict/script-tests/11.1.5.js: Added.
  • fast/js/mozilla/strict/script-tests/11.13.1.js: Added.
  • fast/js/mozilla/strict/script-tests/11.13.2.js: Added.
  • fast/js/mozilla/strict/script-tests/11.3.1.js: Added.
  • fast/js/mozilla/strict/script-tests/11.3.2.js: Added.
  • fast/js/mozilla/strict/script-tests/11.4.1.js: Added.
  • fast/js/mozilla/strict/script-tests/11.4.4.js: Added.
  • fast/js/mozilla/strict/script-tests/11.4.5.js: Added.
  • fast/js/mozilla/strict/script-tests/12.10.1.js: Added.
  • fast/js/mozilla/strict/script-tests/12.14.1.js: Added.
  • fast/js/mozilla/strict/script-tests/12.2.1.js: Added.
  • fast/js/mozilla/strict/script-tests/13.1.js: Added.
  • fast/js/mozilla/strict/script-tests/15.10.7.js: Added.
  • fast/js/mozilla/strict/script-tests/15.3.4.5.js: Added.
  • fast/js/mozilla/strict/script-tests/15.3.5.1.js: Added.
  • fast/js/mozilla/strict/script-tests/15.3.5.2.js: Added.
  • fast/js/mozilla/strict/script-tests/15.4.4.12.js: Added.
  • fast/js/mozilla/strict/script-tests/15.4.4.13.js: Added.
  • fast/js/mozilla/strict/script-tests/15.4.4.6.js: Added.
  • fast/js/mozilla/strict/script-tests/15.4.4.8.js: Added.
  • fast/js/mozilla/strict/script-tests/15.4.4.9.js: Added.
  • fast/js/mozilla/strict/script-tests/15.4.5.1.js: Added.
  • fast/js/mozilla/strict/script-tests/15.5.5.1.js: Added.
  • fast/js/mozilla/strict/script-tests/15.5.5.2.js: Added.
  • fast/js/mozilla/strict/script-tests/8.12.5.js: Added.
  • fast/js/mozilla/strict/script-tests/8.12.7.js: Added.
  • fast/js/mozilla/strict/script-tests/8.7.2.js: Added.
  • fast/js/mozilla/strict/script-tests/B.1.1.js: Added.
  • fast/js/mozilla/strict/script-tests/B.1.2.js: Added.
  • fast/js/mozilla/strict/script-tests/TEMPLATE.html: Added.
  • fast/js/mozilla/strict/script-tests/assign-to-callee-name.js: Added.
  • fast/js/mozilla/strict/script-tests/directive-prologue-01.js: Added.
  • fast/js/mozilla/strict/script-tests/eval-variable-environment.js: Added.
  • fast/js/mozilla/strict/script-tests/function-name-arity.js: Added.
  • fast/js/mozilla/strict/script-tests/primitive-this-no-writeback.js: Added.
  • fast/js/mozilla/strict/script-tests/regress-532041.js: Added.
  • fast/js/mozilla/strict/script-tests/regress-532254.js: Added.
  • fast/js/mozilla/strict/script-tests/regress-599159.js: Added.
  • fast/js/mozilla/strict/script-tests/strict-this-is-not-truthy.js: Added.
  • fast/js/mozilla/strict/script-tests/this-for-function-expression-recursion.js: Added.
  • fast/js/mozilla/strict/script-tests/unbrand-this.js: Added.
  • fast/js/mozilla/strict/strict-this-is-not-truthy-expected.txt: Added.
  • fast/js/mozilla/strict/strict-this-is-not-truthy.html: Added.
  • fast/js/mozilla/strict/this-for-function-expression-recursion-expected.txt: Added.
  • fast/js/mozilla/strict/this-for-function-expression-recursion.html: Added.
  • fast/js/mozilla/strict/unbrand-this-expected.txt: Added.
  • fast/js/mozilla/strict/unbrand-this.html: Added.
1:02 PM BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
(diff)
1:01 PM BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
(diff)
1:00 PM BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
(diff)
12:58 PM BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
added compiler support libraries step (diff)
12:50 PM Changeset in webkit [78730] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-16 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam Roben.

Always disable the responsiveness timer when showing a popup menu
​https://bugs.webkit.org/show_bug.cgi?id=54578
<rdar://problem/9009170>

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::showPopupMenu):
12:38 PM Changeset in webkit [78729] by andersca@apple.com
  • 9 edits
    2 adds in trunk

2011-02-16 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam Roben.

Assertion failure in DrawingAreaImpl::display when calling WKPageForceRepaint on a page that uses accelerated compositing
​https://bugs.webkit.org/show_bug.cgi?id=54575
<rdar://problem/8979594>

Add test.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp: Added. (TestWebKitAPI::didForceRepaint): (TestWebKitAPI::didFinishLoadForFrame): (TestWebKitAPI::TEST):
  • TestWebKitAPI/Tests/WebKit2/simple-accelerated-compositing.html: Added.
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
  • TestWebKitAPI/win/copy-resources.cmd:

2011-02-16 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam Roben.

Assertion failure in DrawingAreaImpl::display when calling WKPageForceRepaint on a page that uses accelerated compositing
​https://bugs.webkit.org/show_bug.cgi?id=54575
<rdar://problem/8979594>

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::forceRepaint): If there is a layer tree host, ask it to force a repaint instead.
  • WebProcess/WebPage/LayerTreeHost.h:
  • WebProcess/WebPage/mac/LayerTreeHostMac.h:
  • WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::forceRepaint): Flush any layer changes, then flush and synchronize the current CA transaction.
12:01 PM Changeset in webkit [78728] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-02-16 Carol Szabo <​carol.szabo@nokia.com>

Reviewed by David Hyatt.

REGRESSION: Use after free in WebCore::RenderCounter::destroyCounterNode
​https://bugs.webkit.org/show_bug.cgi?id=54478

Test: fast/css/counters/render-tree-reorg-crash.html

  • rendering/RenderCounter.cpp: (WebCore::findPlaceForCounter): Fixed typo. The code was still walking sometimes the renderer tree instead of the element tree as intended.

2011-02-16 Carol Szabo <​carol.szabo@nokia.com>

Reviewed by David Hyatt.

REGRESSION: Use after free in WebCore::RenderCounter::destroyCounterNode
​https://bugs.webkit.org/show_bug.cgi?id=54478

Added this test, to evidence a bug not previously caught by the
Layout tests.

  • fast/css/counters/render-tree-reorg-crash-expected.txt: Added.
  • fast/css/counters/render-tree-reorg-crash.html: Added.
11:31 AM Changeset in webkit [78727] by oliver@apple.com
  • 7 edits in trunk

2011-02-16 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoff Garen.

Incorrect handling of global writes in dynamic contexts
​https://bugs.webkit.org/show_bug.cgi?id=49383

Add a few tests to ensure that global writes are actually
allowed inside dynamic scopes.

  • fast/js/basic-strict-mode-expected.txt:
  • fast/js/script-tests/basic-strict-mode.js:

2011-02-16 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoff Garen.

Incorrect handling of global writes in dynamic contexts
​https://bugs.webkit.org/show_bug.cgi?id=49383

  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): Can't use the existing callframe to return an uncaught exception as by definition that callframe has already been torn down.
  • parser/ASTBuilder.h: (JSC::ASTBuilder::ASTBuilder): (JSC::ASTBuilder::varDeclarations): (JSC::ASTBuilder::funcDeclarations): (JSC::ASTBuilder::features): (JSC::ASTBuilder::numConstants): (JSC::ASTBuilder::createFuncDeclStatement): (JSC::ASTBuilder::addVar): (JSC::ASTBuilder::incConstants): (JSC::ASTBuilder::usesThis): (JSC::ASTBuilder::usesCatch): (JSC::ASTBuilder::usesClosures): (JSC::ASTBuilder::usesArguments): (JSC::ASTBuilder::usesAssignment): (JSC::ASTBuilder::usesWith): (JSC::ASTBuilder::usesEval): Don't need a vector of scopes in the ASTBuilder
  • runtime/Operations.h: (JSC::resolveBase): In strict mode the optimisation that we use to skip a lookup on the global object is incorrect and lead to us always disallowing global writes when we needed to do a dynamic slot lookup. Now the strict mode path actually checks for the property.
11:13 AM Changeset in webkit [78726] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Reviewed by Anders Carlsson.

​https://bugs.webkit.org/show_bug.cgi?id=54572
REGRESSION (WebKit2): Print Backgrounds checkbox has no effect for DOM initiated printing

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::preferencesDidChange): Preferences need to be propagated to Web process during synchronous printing.
10:48 AM Changeset in webkit [78725] by mnaganov@chromium.org
  • 4 adds in trunk/LayoutTests/platform/chromium-linux/svg

2011-02-16 Mikhail Naganov <​mnaganov@chromium.org>

[Chromium] Unreviewed rebaseline of SVG tests expectations for Linux after r78720.

LayoutTests/platform/chromium-linux/svg/custom/circular-marker-reference-2-expected.txt
LayoutTests/platform/chromium-linux/svg/custom/non-circular-marker-reference-expected.txt
LayoutTests/platform/chromium-linux/svg/custom/non-scaling-stroke-markers-expected.txt
LayoutTests/platform/chromium-linux/svg/hixie/links/001-expected.txt

10:41 AM Changeset in webkit [78724] by pkasting@chromium.org
  • 3 edits
    4 copies in branches/chromium/597

Merge 77724 - 2011-02-04 Hironori Bono <​hbono@chromium.org>

Reviewed by Adam Barth.

[chromium] JPEG corruption
​https://bugs.webkit.org/show_bug.cgi?id=53250

This change adds a new script test that we can render a CMYK JPEG with a
color profile correctly, i.e. we can render it without color corruption.

  • fast/images/cmyk-jpeg-with-color-profile-expected.txt: Added.
  • fast/images/cmyk-jpeg-with-color-profile.html: Added.
  • fast/images/resources/cmyk-jpeg.jpg: Added.
  • fast/images/script-tests/cmyk-jpeg-with-color-profile.js: Added. (image.onload):

2011-02-04 Hironori Bono <​hbono@chromium.org>

Reviewed by Adam Barth.

[chromium] JPEG corruption
​https://bugs.webkit.org/show_bug.cgi?id=53250

Same as gray-scale JPEGs, we convert the colors of CMYK JPEGs with color
profiles from CMYK to RGB twice and it causes color corruption. This
change suppresses the color profiles for CMYK JPEGs same as gray-scale
ones.

Test: fast/images/cmyk-jpeg-with-color-profile.html

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::decode):

TBR=​commit-queue@webkit.org
Review URL: ​http://codereview.chromium.org/6529057

10:33 AM Changeset in webkit [78723] by mnaganov@chromium.org
  • 1 edit
    14 adds in trunk/LayoutTests/platform

2011-02-16 Mikhail Naganov <​mnaganov@chromium.org>

[Chromium] Unreviewed rebaseline of SVG tests expectations for Mac.

10:20 AM Changeset in webkit [78722] by Nikolas Zimmermann
  • 21 edits in trunk/LayoutTests

2011-02-16 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

Pixel tests differences on 10.6.6 32bit vs. 64bit
​https://bugs.webkit.org/show_bug.cgi?id=54474

Update gtk baseline using the 64bit debug bot - maybe we have another rounding problem on gtk. Let's see.

  • platform/gtk/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt:
  • platform/gtk/svg/custom/circular-marker-reference-1-expected.txt:
  • platform/gtk/svg/custom/circular-marker-reference-3-expected.txt:
  • platform/gtk/svg/custom/circular-marker-reference-4-expected.txt:
  • platform/gtk/svg/custom/non-scaling-stroke-markers-expected.txt:
  • platform/gtk/svg/custom/resource-invalidate-on-target-update-expected.txt:
  • platform/gtk/svg/custom/stroked-pattern-expected.txt:
  • platform/gtk/svg/custom/text-rotated-gradient-expected.txt:
  • platform/gtk/svg/custom/use-css-events-expected.txt:
  • platform/gtk/svg/custom/use-detach-expected.txt:
  • platform/gtk/svg/filters/filterRes-expected.txt:
  • platform/gtk/svg/hixie/links/001-expected.txt:
  • platform/gtk/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
  • platform/gtk/svg/text/small-fonts-2-expected.txt:
  • platform/gtk/svg/text/text-align-04-b-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:
10:13 AM Changeset in webkit [78721] by hans@chromium.org
  • 18 edits in trunk

2011-02-16 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Inject auto increment keys via key path on insertion
​https://bugs.webkit.org/show_bug.cgi?id=54457

Prepare to test injection of auto increment key. Keep it commented out
until implemented Chromium-side.

  • storage/indexeddb/objectstore-autoincrement-expected.txt:
  • storage/indexeddb/objectstore-autoincrement.html:

2011-02-16 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Inject auto increment keys via key path on insertion
​https://bugs.webkit.org/show_bug.cgi?id=54457

Inject auto increment keys via key path for object stores using key
path and auto increment.

  • bindings/v8/IDBBindingUtilities.cpp: (WebCore::LocalContext::getNthValueOnKeyPath): (WebCore::createIDBKeyFromSerializedValueAndKeyPath): (WebCore::injectIDBKeyIntoSerializedValue):
  • bindings/v8/IDBBindingUtilities.h:
  • platform/chromium/PlatformBridge.h:
  • storage/IDBKeyPathBackendImpl.cpp: (IDBKeyPathBackendImpl::injectIDBKeyIntoSerializedValue):
  • storage/IDBKeyPathBackendImpl.h:
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::injectKeyIntoKeyPath): (WebCore::IDBObjectStoreBackendImpl::selectKeyForPut): (WebCore::IDBObjectStoreBackendImpl::putInternal):
  • storage/IDBObjectStoreBackendImpl.h:
  • storage/chromium/IDBKeyPathBackendImpl.cpp: (WebCore::IDBKeyPathBackendImpl::injectIDBKeyIntoSerializedValue):

2011-02-16 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Inject auto increment keys via key path on insertion
​https://bugs.webkit.org/show_bug.cgi?id=54457

Support for injecting keys into objects via key path.

  • public/WebIDBKey.h:
  • public/WebKitClient.h: (WebKit::WebKitClient::injectIDBKeyIntoSerializedValue):
  • src/PlatformBridge.cpp: (WebCore::PlatformBridge::injectIDBKeyIntoSerializedValue):
  • src/WebIDBKey.cpp: (WebKit::WebIDBKey::injectIDBKeyIntoSerializedValue):
  • tests/IDBBindingUtilitiesTest.cpp: (WebCore::injectKey): (WebCore::checkInjection): (WebCore::checkInjectionFails): (WebCore::TEST):
9:59 AM Changeset in webkit [78720] by Nikolas Zimmermann
  • 12 edits
    12 adds in trunk/LayoutTests

2011-02-16 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

Pixel tests differences on 10.6.6 32bit vs. 64bit
​https://bugs.webkit.org/show_bug.cgi?id=54474

Update mac-leopard/win baselines. I rebaselined the wrong platforms in my last commit.

  • platform/mac-leopard/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
  • platform/mac-leopard/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt:
  • platform/mac-leopard/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt:
  • platform/mac-leopard/svg/custom/circular-marker-reference-2-expected.txt:
  • platform/mac-leopard/svg/custom/non-circular-marker-reference-expected.txt:
  • platform/mac-leopard/svg/custom/non-scaling-stroke-markers-expected.txt:
  • platform/mac-leopard/svg/custom/stroked-pattern-expected.txt:
  • platform/mac-leopard/svg/custom/text-rotated-gradient-expected.txt:
  • platform/mac-leopard/svg/custom/use-detach-expected.txt:
  • platform/mac-leopard/svg/hixie/links/001-expected.txt:
  • platform/mac-leopard/svg/text/small-fonts-2-expected.txt:
  • platform/win/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt: Added.
  • platform/win/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt: Added.
  • platform/win/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt: Added.
  • platform/win/svg/custom/circular-marker-reference-2-expected.txt: Added.
  • platform/win/svg/custom/non-circular-marker-reference-expected.txt: Added.
  • platform/win/svg/custom/non-scaling-stroke-markers-expected.txt: Added.
  • platform/win/svg/custom/stroked-pattern-expected.txt: Added.
  • platform/win/svg/custom/text-rotated-gradient-expected.txt: Added.
  • platform/win/svg/custom/use-detach-expected.txt: Added.
  • platform/win/svg/hixie/links: Added.
  • platform/win/svg/hixie/links/001-expected.txt: Added.
  • platform/win/svg/text/small-fonts-2-expected.txt: Added.
9:48 AM Changeset in webkit [78719] by mnaganov@chromium.org
  • 9 adds in trunk/LayoutTests/platform/chromium-win-xp/svg

2011-02-16 Mikhail Naganov <​mnaganov@chromium.org>

[Chromium] Unreviewed rebaseline of SVG tests expectations for Windows.

9:47 AM Changeset in webkit [78718] by sergio@webkit.org
  • 6 edits in trunk

2011-02-16 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

[Gtk] Add support for layoutTestController.setWillSendRequestClearHeader
​https://bugs.webkit.org/show_bug.cgi?id=54537

Unskipped http/tests/security/no-referrer.html.

  • platform/gtk/Skipped:

2011-02-16 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

[Gtk] Add support for layoutTestController.setWillSendRequestClearHeader
​https://bugs.webkit.org/show_bug.cgi?id=54537

Headers removed from the SoupMessage should be also removed from
the ResourceRequest when updating the latter from the former.

  • platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::updateFromSoupMessage):

2011-02-16 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

[Gtk] Add support for layoutTestController.setWillSendRequestClearHeader
​https://bugs.webkit.org/show_bug.cgi?id=54537

Added handler for resource-request-starting emitted in
FrameLoader's willSendRequest(). The current implementation
removes the headers set in setWillSendRequestClearHeader.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (willSendRequestCallback): (createWebView):
9:17 AM Changeset in webkit [78717] by loislo@chromium.org
  • 50 edits in trunk

2011-02-16 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: split all the functions of Inspector backend API by domain.
​https://bugs.webkit.org/show_bug.cgi?id=54558

We have a number of functions from different domains in single instance of InspectorBackend.
It'd be better to split the functions by their domains.
As example 'evaluate' will be moved from InspectorBackend to RuntimeAgent container.

  • http/tests/inspector/console-xhr-logging.html:
  • http/tests/inspector/extensions-test.js: (initialize_ExtensionsTest.InspectorTest.runExtensionTests):
  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.completeTest): (initialize_InspectorTest.InspectorTest.evaluateInPage): (initialize_InspectorTest.InspectorTest.reloadPage):
  • inspector/console/console-dir-global.html:
  • inspector/debugger/debugger-autocontinue-on-syntax-error.html:
  • inspector/debugger/debugger-pause-on-exception.html:
  • inspector/elements/elements-panel-search.html:
  • inspector/report-API-errors-expected.txt:
  • inspector/report-API-errors.html:
  • inspector/report-protocol-errors.html:
  • inspector/styles/styles-new-API.html:
  • inspector/styles/styles-source-offsets.html:
  • inspector/timeline/timeline-network-resource.html:
  • inspector/timeline/timeline-script-tag-1.html:
  • inspector/timeline/timeline-script-tag-2.html:
  • inspector/timeline/timeline-test.js: (initialize_Timeline.InspectorTest.performActionsAndPrint.step2):
  • inspector/timeline/timeline-trivial.html:

2011-02-16 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: split all the functions of Inspector backend API by domain.
​https://bugs.webkit.org/show_bug.cgi?id=54558

We have a number of functions from different domains in single instance of InspectorBackend.
It'd be better to split the functions by their domains.
As example 'evaluate' will be moved from InspectorBackend to RuntimeAgent container.

  • inspector/CodeGeneratorInspector.pm:
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.evaluateInTargetWindow): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
  • inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel.prototype._reloadResources):
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype._projectChanged): (WebInspector.BreakpointManager.prototype.restoreDOMBreakpoints): (WebInspector.BreakpointManager.prototype._saveBreakpoints): (WebInspector.DOMBreakpoint.prototype._enable): (WebInspector.DOMBreakpoint.prototype._disable): (WebInspector.EventListenerBreakpoint.prototype._enable): (WebInspector.EventListenerBreakpoint.prototype._disable): (WebInspector.XHRBreakpoint.prototype._enable): (WebInspector.XHRBreakpoint.prototype._disable):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype.getStylesAsync): (WebInspector.CSSStyleModel.prototype.getComputedStyleAsync): (WebInspector.CSSStyleModel.prototype.getInlineStyleAsync): (WebInspector.CSSStyleModel.prototype.setRuleSelector.callback): (WebInspector.CSSStyleModel.prototype.setRuleSelector): (WebInspector.CSSStyleModel.prototype.addRule.callback): (WebInspector.CSSStyleModel.prototype.addRule): (WebInspector.CSSStyleModel.prototype._styleSheetChanged): (WebInspector.CSSStyleModel.prototype._onRevert): (WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt): (WebInspector.CSSProperty.prototype.setText): (WebInspector.CSSProperty.prototype.setDisabled): (WebInspector.CSSStyleSheet.createForId): (WebInspector.CSSStyleSheet.prototype.setText):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.requestClearMessages): (WebInspector.ConsoleView.prototype.completions): (WebInspector.ConsoleView.prototype._handleContextMenuEvent.itemAction): (WebInspector.ConsoleView.prototype._handleContextMenuEvent): (WebInspector.ConsoleView.prototype.evalInInspectedWindow):
  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype._deleteCookie):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype.getChildNodesAsync): (WebInspector.DOMAgent.prototype.setAttributeAsync): (WebInspector.DOMAgent.prototype.removeAttributeAsync): (WebInspector.DOMAgent.prototype.setTextNodeValueAsync): (WebInspector.ApplicationCacheDispatcher.getApplicationCachesAsync): (WebInspector.Cookies.getCookiesAsync): (WebInspector.EventListeners.getEventListenersForNodeAsync):
  • inspector/front-end/DOMStorage.js: (WebInspector.DOMStorage.prototype.getEntries): (WebInspector.DOMStorage.prototype.setItem): (WebInspector.DOMStorage.prototype.removeItem):
  • inspector/front-end/Database.js: (WebInspector.Database.prototype.getTableNames): (WebInspector.Database.prototype.executeSql):
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.enableDebugger): (WebInspector.DebuggerModel.prototype.disableDebugger): (WebInspector.DebuggerModel.prototype.continueToLocation): (WebInspector.DebuggerModel.prototype.setBreakpoint): (WebInspector.DebuggerModel.prototype.setBreakpointBySourceId): (WebInspector.DebuggerModel.prototype.removeBreakpoint): (WebInspector.DebuggerModel.prototype.editScriptSource):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype.setDocument): (WebInspector.ElementsPanel.prototype.searchCanceled): (WebInspector.ElementsPanel.prototype.performSearch): (WebInspector.ElementsPanel.prototype.handleCopyEvent): (WebInspector.ElementsPanel.prototype.setSearchingForNode):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._createTooltipForNode): (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted): ():
  • inspector/front-end/ExtensionPanel.js: (WebInspector.ExtensionWatchSidebarPane.prototype.setExpression):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onAddRequestHeaders): (WebInspector.ExtensionServer.prototype._onReload): (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
  • inspector/front-end/HeapSnapshotView.js: (WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager): (WebInspector.NetworkManager.prototype.reset): (WebInspector.NetworkManager.prototype.requestContent):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkDataGridNode.prototype._openInNewTab):
  • inspector/front-end/ProfileView.js: (WebInspector.CPUProfileView): (WebInspector.CPUProfileType.prototype.buttonClicked):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._clearProfiles): (WebInspector.ProfilesPanel.prototype._removeProfileHeader): (WebInspector.ProfilesPanel.prototype.loadHeapSnapshot): (WebInspector.ProfilesPanel.prototype._toggleProfiling): (WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
  • inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update):
  • inspector/front-end/RemoteObject.js: (WebInspector.RemoteObject.resolveNode): (WebInspector.RemoteObject.prototype.getProperties): (WebInspector.RemoteObject.prototype.setPropertyValue): (WebInspector.RemoteObject.prototype.pushNodeToFrontend):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.FrameTreeElement.prototype.onselect): (WebInspector.FrameTreeElement.prototype.set hovered): (WebInspector.FrameResourceTreeElement.prototype.ondblclick):
  • inspector/front-end/Script.js: (WebInspector.Script.prototype.requestSource):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame): (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions): (WebInspector.ScriptsPanel.prototype._togglePause): (WebInspector.ScriptsPanel.prototype._stepOverClicked): (WebInspector.ScriptsPanel.prototype._stepIntoClicked): (WebInspector.ScriptsPanel.prototype._stepOutClicked): (WebInspector.ScriptsPanel.prototype.toggleBreakpointsClicked):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._hidePopup):
  • inspector/front-end/TestController.js: (WebInspector.TestController.prototype.notifyDone):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):
  • inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update):
  • inspector/front-end/WorkersSidebarPane.js: (WebInspector.WorkersSidebarPane.prototype.setInstrumentation):
  • inspector/front-end/inspector.js: (WebInspector.highlightDOMNode): (WebInspector.doLoadedDone): (WebInspector.openResource): (WebInspector.documentKeyDown):
9:14 AM Changeset in webkit [78716] by Nikolas Zimmermann
  • 10 edits
    13 adds in trunk/LayoutTests

2011-02-16 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

Pixel tests differences on 10.6.6 32bit vs. 64bit
​https://bugs.webkit.org/show_bug.cgi?id=54474

Update gtk/win/mac-leopard baselines.

  • platform/gtk/svg/custom/resource-invalidate-on-target-update-expected.txt:
  • platform/gtk/svg/custom/use-css-events-expected.txt:
  • platform/gtk/svg/filters/filterRes-expected.txt:
  • platform/gtk/svg/text/text-align-04-b-expected.txt:
  • platform/mac-leopard/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt: Added.
  • platform/mac-leopard/svg/batik/masking/maskRegions-expected.txt:
  • platform/mac-leopard/svg/custom/circular-marker-reference-2-expected.txt: Added.
  • platform/mac-leopard/svg/custom/non-circular-marker-reference-expected.txt: Added.
  • platform/mac-leopard/svg/custom/non-scaling-stroke-markers-expected.txt: Added.
  • platform/mac-leopard/svg/custom/stroked-pattern-expected.txt: Added.
  • platform/mac-leopard/svg/custom/text-rotated-gradient-expected.txt: Added.
  • platform/mac-leopard/svg/custom/use-detach-expected.txt: Added.
  • platform/mac-leopard/svg/hixie/links/001-expected.txt: Added.
  • platform/mac-leopard/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
  • platform/mac-leopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/mac-leopard/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
  • platform/mac-leopard/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/win/svg/batik/masking/maskRegions-expected.txt:
  • platform/win/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
9:12 AM Changeset in webkit [78715] by mario@webkit.org
  • 5 edits
    2 adds in trunk

2011-02-16 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] events missing when a document is (re)loaded
​https://bugs.webkit.org/show_bug.cgi?id=25831

Added new layout test to check the right signals are emitted.

  • platform/gtk/accessibility/document-reload-events-expected.txt: Added.
  • platform/gtk/accessibility/document-reload-events.html: Added.

2011-02-16 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] events missing when a document is (re)loaded
​https://bugs.webkit.org/show_bug.cgi?id=25831

Make sure webArea returns a proper name and that a signal
'state-change::defunct' is emitted when detaching the wrapper.

Test: platform/gtk/accessibility/document-reload-events.html

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_name): Returns the current document's title as fallback mechanism for webArea objects. (webkit_accessible_detach): Emit 'state-change::defunct' function as soon as the wrapper is detached from the related core object.

2011-02-16 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] events missing when a document is (re)loaded
​https://bugs.webkit.org/show_bug.cgi?id=25831

Emit the right signals when reloading a document.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::notifyAccessibilityStatus): New function, to make sure the signals involved in reloading a document are properly emitted. (WebKit::notifyStatus): Also notify accessibility if enabled.
8:58 AM Changeset in webkit [78714] by Nikolas Zimmermann
  • 143 edits in trunk/LayoutTests

2011-02-16 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Pixel tests differences on 10.6.6 32bit vs. 64bit
​https://bugs.webkit.org/show_bug.cgi?id=54474

Update SnowLeopard SVG pixel test baseline, generated on a 32bit machine, where it passes with tolerance 0.
This is the fifth and last chunk.

It should pass on modern 64bit machines as well, using tolerance 0.01.

  • platform/mac/svg/filters/feOffset-expected.checksum:
  • platform/mac/svg/filters/feOffset-expected.png:
  • platform/mac/svg/filters/filter-clip-expected.checksum:
  • platform/mac/svg/filters/filter-clip-expected.png:
  • platform/mac/svg/filters/filterRes-expected.checksum:
  • platform/mac/svg/filters/filterRes-expected.png:
  • platform/mac/svg/hixie/cascade/002-expected.checksum:
  • platform/mac/svg/hixie/cascade/002-expected.png:
  • platform/mac/svg/hixie/error/017-expected.checksum:
  • platform/mac/svg/hixie/error/017-expected.png:
  • platform/mac/svg/hixie/links/003-broken-expected.checksum:
  • platform/mac/svg/hixie/links/003-broken-expected.png:
  • platform/mac/svg/hixie/mixed/003-expected.checksum:
  • platform/mac/svg/hixie/mixed/003-expected.png:
  • platform/mac/svg/hixie/mixed/004-expected.checksum:
  • platform/mac/svg/hixie/mixed/004-expected.png:
  • platform/mac/svg/hixie/mixed/005-expected.checksum:
  • platform/mac/svg/hixie/mixed/005-expected.png:
  • platform/mac/svg/hixie/mixed/006-expected.checksum:
  • platform/mac/svg/hixie/mixed/006-expected.png:
  • platform/mac/svg/hixie/mixed/008-expected.checksum:
  • platform/mac/svg/hixie/mixed/008-expected.png:
  • platform/mac/svg/hixie/mixed/011-expected.checksum:
  • platform/mac/svg/hixie/mixed/011-expected.png:
  • platform/mac/svg/hixie/perf/001-expected.checksum:
  • platform/mac/svg/hixie/perf/001-expected.png:
  • platform/mac/svg/hixie/perf/002-expected.checksum:
  • platform/mac/svg/hixie/perf/002-expected.png:
  • platform/mac/svg/hixie/perf/007-expected.checksum:
  • platform/mac/svg/hixie/perf/007-expected.png:
  • platform/mac/svg/hixie/transform/001-expected.checksum:
  • platform/mac/svg/hixie/transform/001-expected.png:
  • platform/mac/svg/hixie/viewbox/preserveAspectRatio/001-expected.checksum:
  • platform/mac/svg/hixie/viewbox/preserveAspectRatio/001-expected.png:
  • platform/mac/svg/text/font-size-below-point-five-2-expected.checksum:
  • platform/mac/svg/text/font-size-below-point-five-2-expected.png:
  • platform/mac/svg/text/scaled-font-expected.checksum:
  • platform/mac/svg/text/scaled-font-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-1-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-1-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-2-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-2-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-3-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-3-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-4-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-4-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-stretch-1-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacing-stretch-1-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-stretch-2-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacing-stretch-2-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-stretch-3-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacing-stretch-3-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-stretch-4-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacing-stretch-4-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.png:
  • platform/mac/svg/text/select-x-list-3-expected.checksum:
  • platform/mac/svg/text/select-x-list-3-expected.png:
  • platform/mac/svg/text/selection-background-color-expected.checksum:
  • platform/mac/svg/text/selection-background-color-expected.png:
  • platform/mac/svg/text/selection-styles-expected.checksum:
  • platform/mac/svg/text/selection-styles-expected.png:
  • platform/mac/svg/text/small-fonts-2-expected.checksum:
  • platform/mac/svg/text/small-fonts-2-expected.png:
  • platform/mac/svg/text/small-fonts-3-expected.checksum:
  • platform/mac/svg/text/small-fonts-3-expected.png:
  • platform/mac/svg/text/small-fonts-expected.checksum:
  • platform/mac/svg/text/small-fonts-expected.png:
  • platform/mac/svg/text/small-fonts-in-html5-expected.checksum:
  • platform/mac/svg/text/small-fonts-in-html5-expected.png:
  • platform/mac/svg/text/text-align-01-b-expected.checksum:
  • platform/mac/svg/text/text-align-01-b-expected.png:
  • platform/mac/svg/text/text-align-02-b-expected.checksum:
  • platform/mac/svg/text/text-align-02-b-expected.png:
  • platform/mac/svg/text/text-align-03-b-expected.checksum:
  • platform/mac/svg/text/text-align-03-b-expected.png:
  • platform/mac/svg/text/text-align-04-b-expected.checksum:
  • platform/mac/svg/text/text-align-04-b-expected.png:
  • platform/mac/svg/text/text-align-05-b-expected.checksum:
  • platform/mac/svg/text/text-align-05-b-expected.png:
  • platform/mac/svg/text/text-align-06-b-expected.checksum:
  • platform/mac/svg/text/text-align-06-b-expected.png:
  • platform/mac/svg/text/text-altglyph-01-b-expected.checksum:
  • platform/mac/svg/text/text-altglyph-01-b-expected.png:
  • platform/mac/svg/text/text-deco-01-b-expected.checksum:
  • platform/mac/svg/text/text-deco-01-b-expected.png:
  • platform/mac/svg/text/text-fonts-01-t-expected.checksum:
  • platform/mac/svg/text/text-fonts-01-t-expected.png:
  • platform/mac/svg/text/text-fonts-02-t-expected.checksum:
  • platform/mac/svg/text/text-fonts-02-t-expected.png:
  • platform/mac/svg/text/text-intro-05-t-expected.checksum:
  • platform/mac/svg/text/text-intro-05-t-expected.png:
  • platform/mac/svg/text/text-path-01-b-expected.checksum:
  • platform/mac/svg/text/text-path-01-b-expected.png:
  • platform/mac/svg/text/text-text-01-b-expected.checksum:
  • platform/mac/svg/text/text-text-01-b-expected.png:
  • platform/mac/svg/text/text-text-03-b-expected.checksum:
  • platform/mac/svg/text/text-text-03-b-expected.png:
  • platform/mac/svg/text/text-text-04-t-expected.checksum:
  • platform/mac/svg/text/text-text-04-t-expected.png:
  • platform/mac/svg/text/text-text-05-t-expected.checksum:
  • platform/mac/svg/text/text-text-05-t-expected.png:
  • platform/mac/svg/text/text-text-06-t-expected.checksum:
  • platform/mac/svg/text/text-text-06-t-expected.png:
  • platform/mac/svg/text/text-text-07-t-expected.checksum:
  • platform/mac/svg/text/text-text-07-t-expected.png:
  • platform/mac/svg/text/text-text-08-b-expected.checksum:
  • platform/mac/svg/text/text-text-08-b-expected.png:
  • platform/mac/svg/text/text-tselect-01-b-expected.checksum:
  • platform/mac/svg/text/text-tselect-01-b-expected.png:
  • platform/mac/svg/text/text-tselect-02-f-expected.checksum:
  • platform/mac/svg/text/text-tselect-02-f-expected.png:
  • platform/mac/svg/text/text-tspan-01-b-expected.checksum:
  • platform/mac/svg/text/text-tspan-01-b-expected.png:
  • platform/mac/svg/text/text-ws-01-t-expected.checksum:
  • platform/mac/svg/text/text-ws-01-t-expected.png:
  • platform/mac/svg/text/text-ws-02-t-expected.checksum:
  • platform/mac/svg/text/text-ws-02-t-expected.png:
  • platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.checksum:
  • platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.checksum:
  • platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.png:
  • platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.checksum:
  • platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.checksum:
  • platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/mac/svg/webarchive/svg-feimage-subresources-expected.checksum:
  • platform/mac/svg/webarchive/svg-feimage-subresources-expected.png:
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.checksum:
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.checksum:
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
  • platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.checksum:
  • platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.checksum:
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.png:
8:58 AM Changeset in webkit [78713] by Nikolas Zimmermann
  • 1 edit in trunk/Source/WebCore/ChangeLog

Oops forgot to land the ChangeLog for r78704.

8:43 AM Changeset in webkit [78712] by mnaganov@chromium.org
  • 29 edits
    74 adds in trunk/LayoutTests/platform

2011-02-16 Mikhail Naganov <​mnaganov@chromium.org>

[Chromium] Unreviewed rebaseline of SVG tests expectations.

8:41 AM Changeset in webkit [78711] by Nikolas Zimmermann
  • 137 edits in trunk/LayoutTests

2011-02-16 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Pixel tests differences on 10.6.6 32bit vs. 64bit
​https://bugs.webkit.org/show_bug.cgi?id=54474

Update SnowLeopard SVG pixel test baseline, generated on a 32bit machine, where it passes with tolerance 0.
This is the fourth chunk.

It should pass on modern 64bit machines as well, using tolerance 0.01.

  • platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-cx-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-cx-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-cy-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-cy-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-cx-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-cx-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-cy-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-cy-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.png:
8:37 AM Changeset in webkit [78710] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Merge branch 'bug/54552' into staging

8:32 AM Changeset in webkit [78709] by Csaba Osztrogonác
  • 6 edits in trunk/LayoutTests

Unreviewed.

Update Qt specific expected files.

  • platform/qt/svg/custom/non-scaling-stroke-markers-expected.checksum:
  • platform/qt/svg/custom/non-scaling-stroke-markers-expected.png:
  • platform/qt/svg/custom/non-scaling-stroke-markers-expected.txt:
  • platform/qt/svg/custom/text-rotated-gradient-expected.txt:
  • platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
7:48 AM Changeset in webkit [78708] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt] Qt build system can't handle removing headers from tree
​https://bugs.webkit.org/show_bug.cgi?id=54466

Reviewed by Andreas Kling.

  • Scripts/build-webkit: Remove Qt makefiles from productDir before build.
7:26 AM Changeset in webkit [78707] by Nikolas Zimmermann
  • 139 edits in trunk/LayoutTests

2011-02-16 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Pixel tests differences on 10.6.6 32bit vs. 64bit
​https://bugs.webkit.org/show_bug.cgi?id=54474

Update SnowLeopard SVG pixel test baseline, generated on a 32bit machine, where it passes with tolerance 0.
This is the third chunk.

It should pass on modern 64bit machines as well, using tolerance 0.01.

  • platform/mac/svg/clip-path/clip-in-mask-expected.checksum:
  • platform/mac/svg/clip-path/clip-in-mask-expected.png:
  • platform/mac/svg/clip-path/clip-path-child-clipped-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-child-clipped-expected.png:
  • platform/mac/svg/clip-path/clip-path-childs-clipped-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-childs-clipped-expected.png:
  • platform/mac/svg/clip-path/clip-path-clipped-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-clipped-expected.png:
  • platform/mac/svg/clip-path/clip-path-clipped-nonzero-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-clipped-nonzero-expected.png:
  • platform/mac/svg/clip-path/clip-path-on-clipped-use-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-on-clipped-use-expected.png:
  • platform/mac/svg/clip-path/clip-path-on-g-and-child-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-on-g-and-child-expected.png:
  • platform/mac/svg/clip-path/clip-path-on-g-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-on-g-expected.png:
  • platform/mac/svg/clip-path/clip-path-on-svg-and-child-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-on-svg-and-child-expected.png:
  • platform/mac/svg/clip-path/clip-path-on-svg-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-on-svg-expected.png:
  • platform/mac/svg/clip-path/clip-path-use-as-child-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-use-as-child-expected.png:
  • platform/mac/svg/clip-path/clip-path-use-as-child2-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-use-as-child2-expected.png:
  • platform/mac/svg/clip-path/clip-path-use-as-child3-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-use-as-child3-expected.png:
  • platform/mac/svg/clip-path/clip-path-use-as-child4-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-use-as-child4-expected.png:
  • platform/mac/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.checksum:
  • platform/mac/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png:
  • platform/mac/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.checksum:
  • platform/mac/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png:
  • platform/mac/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.checksum:
  • platform/mac/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png:
  • platform/mac/svg/custom/absolute-sized-content-with-resources-expected.checksum:
  • platform/mac/svg/custom/absolute-sized-content-with-resources-expected.png:
  • platform/mac/svg/custom/animate-path-discrete-expected.checksum:
  • platform/mac/svg/custom/animate-path-discrete-expected.png:
  • platform/mac/svg/custom/convolution-crash-expected.checksum:
  • platform/mac/svg/custom/convolution-crash-expected.png:
  • platform/mac/svg/custom/createImageElement2-expected.checksum:
  • platform/mac/svg/custom/createImageElement2-expected.png:
  • platform/mac/svg/custom/dynamic-svg-document-creation-expected.checksum:
  • platform/mac/svg/custom/dynamic-svg-document-creation-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Discrete-expected.checksum:
  • platform/mac/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Gamma-expected.checksum:
  • platform/mac/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Linear-expected.checksum:
  • platform/mac/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Table-expected.checksum:
  • platform/mac/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/mac/svg/custom/focus-ring-expected.checksum:
  • platform/mac/svg/custom/focus-ring-expected.png:
  • platform/mac/svg/custom/foreign-object-skew-expected.checksum:
  • platform/mac/svg/custom/foreign-object-skew-expected.png:
  • platform/mac/svg/custom/glyph-transformation-with-hkern-expected.checksum:
  • platform/mac/svg/custom/glyph-transformation-with-hkern-expected.png:
  • platform/mac/svg/custom/gradient-rotated-bbox-expected.checksum:
  • platform/mac/svg/custom/gradient-rotated-bbox-expected.png:
  • platform/mac/svg/custom/gradient-stroke-width-expected.checksum:
  • platform/mac/svg/custom/gradient-stroke-width-expected.png:
  • platform/mac/svg/custom/grayscale-gradient-mask-expected.checksum:
  • platform/mac/svg/custom/grayscale-gradient-mask-expected.png:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.checksum:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/mac/svg/custom/invalid-css-expected.checksum:
  • platform/mac/svg/custom/invalid-css-expected.png:
  • platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.checksum:
  • platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.png:
  • platform/mac/svg/custom/js-late-clipPath-creation-expected.checksum:
  • platform/mac/svg/custom/js-late-clipPath-creation-expected.png:
  • platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.checksum:
  • platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/mac/svg/custom/js-late-gradient-creation-expected.checksum:
  • platform/mac/svg/custom/js-late-gradient-creation-expected.png:
  • platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.checksum:
  • platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.png:
  • platform/mac/svg/custom/linking-a-03-b-all-expected.checksum:
  • platform/mac/svg/custom/linking-a-03-b-all-expected.png:
  • platform/mac/svg/custom/linking-a-03-b-transform-expected.checksum:
  • platform/mac/svg/custom/linking-a-03-b-transform-expected.png:
  • platform/mac/svg/custom/linking-a-03-b-viewBox-transform-expected.checksum:
  • platform/mac/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/mac/svg/custom/marker-default-width-height-expected.checksum:
  • platform/mac/svg/custom/marker-default-width-height-expected.png:
  • platform/mac/svg/custom/marker-opacity-expected.checksum:
  • platform/mac/svg/custom/marker-opacity-expected.png:
  • platform/mac/svg/custom/mouse-move-on-svg-root-expected.checksum:
  • platform/mac/svg/custom/mouse-move-on-svg-root-expected.png:
  • platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
  • platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
  • platform/mac/svg/custom/non-scaling-stroke-expected.checksum:
  • platform/mac/svg/custom/non-scaling-stroke-expected.png:
  • platform/mac/svg/custom/pattern-skew-transformed-expected.checksum:
  • platform/mac/svg/custom/pattern-skew-transformed-expected.png:
  • platform/mac/svg/custom/pattern-with-transformation-expected.checksum:
  • platform/mac/svg/custom/pattern-with-transformation-expected.png:
  • platform/mac/svg/custom/pointer-events-image-expected.checksum:
  • platform/mac/svg/custom/pointer-events-image-expected.png:
  • platform/mac/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.checksum:
  • platform/mac/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png:
  • platform/mac/svg/custom/relative-sized-content-with-resources-expected.checksum:
  • platform/mac/svg/custom/relative-sized-content-with-resources-expected.png:
  • platform/mac/svg/custom/relative-sized-inner-svg-expected.checksum:
  • platform/mac/svg/custom/relative-sized-inner-svg-expected.png:
  • platform/mac/svg/custom/relative-sized-use-on-symbol-expected.checksum:
  • platform/mac/svg/custom/relative-sized-use-on-symbol-expected.png:
  • platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.checksum:
  • platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png:
  • platform/mac/svg/custom/resource-invalidate-on-target-update-expected.checksum:
  • platform/mac/svg/custom/resource-invalidate-on-target-update-expected.png:
  • platform/mac/svg/custom/shapes-supporting-markers-expected.checksum:
  • platform/mac/svg/custom/shapes-supporting-markers-expected.png:
  • platform/mac/svg/custom/stroked-pattern-expected.checksum:
  • platform/mac/svg/custom/stroked-pattern-expected.png:
  • platform/mac/svg/custom/struct-use-09-b-expected.checksum:
  • platform/mac/svg/custom/struct-use-09-b-expected.png:
  • platform/mac/svg/custom/svg-curve-with-relative-cordinates-expected.checksum:
  • platform/mac/svg/custom/svg-curve-with-relative-cordinates-expected.png:
  • platform/mac/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/mac/svg/custom/svg-fonts-in-html-expected.png:
  • platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.checksum:
  • platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.png:
  • platform/mac/svg/custom/text-rotated-gradient-expected.checksum:
  • platform/mac/svg/custom/text-rotated-gradient-expected.png:
  • platform/mac/svg/custom/tref-update-expected.checksum:
  • platform/mac/svg/custom/tref-update-expected.png:
  • platform/mac/svg/custom/use-css-events-expected.checksum:
  • platform/mac/svg/custom/use-css-events-expected.png:
  • platform/mac/svg/custom/use-detach-expected.checksum:
  • platform/mac/svg/custom/use-detach-expected.png:
  • platform/mac/svg/custom/use-on-clip-path-with-transformation-expected.checksum:
  • platform/mac/svg/custom/use-on-clip-path-with-transformation-expected.png:
  • platform/mac/svg/custom/use-referencing-nonexisting-symbol-expected.checksum:
  • platform/mac/svg/custom/use-referencing-nonexisting-symbol-expected.png:
  • platform/mac/svg/custom/width-full-percentage-expected.checksum:
  • platform/mac/svg/custom/width-full-percentage-expected.png:
7:23 AM Changeset in webkit [78706] by Nikolas Zimmermann
  • 47 edits in trunk/LayoutTests

2011-02-16 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Pixel tests differences on 10.6.6 32bit vs. 64bit
​https://bugs.webkit.org/show_bug.cgi?id=54474

Update SnowLeopard SVG pixel test baseline, generated on a 32bit machine, where it passes with tolerance 0.
This is the second chunk.

It should pass on modern 64bit machines as well, using tolerance 0.01.

  • platform/mac/svg/batik/masking/maskRegions-expected.checksum:
  • platform/mac/svg/batik/masking/maskRegions-expected.png:
  • platform/mac/svg/batik/text/smallFonts-expected.checksum:
  • platform/mac/svg/batik/text/smallFonts-expected.png:
  • platform/mac/svg/batik/text/textAnchor-expected.checksum:
  • platform/mac/svg/batik/text/textAnchor-expected.png:
  • platform/mac/svg/batik/text/textEffect-expected.checksum:
  • platform/mac/svg/batik/text/textEffect-expected.png:
  • platform/mac/svg/batik/text/textEffect3-expected.checksum:
  • platform/mac/svg/batik/text/textEffect3-expected.png:
  • platform/mac/svg/batik/text/textFeatures-expected.checksum:
  • platform/mac/svg/batik/text/textFeatures-expected.png:
  • platform/mac/svg/batik/text/textOnPath2-expected.checksum:
  • platform/mac/svg/batik/text/textOnPath2-expected.png:
  • platform/mac/svg/batik/text/textOnPath3-expected.checksum:
  • platform/mac/svg/batik/text/textOnPath3-expected.png:
  • platform/mac/svg/batik/text/verticalTextOnPath-expected.checksum:
  • platform/mac/svg/batik/text/verticalTextOnPath-expected.png:
  • platform/mac/svg/carto.net/button-expected.checksum:
  • platform/mac/svg/carto.net/button-expected.png:
  • platform/mac/svg/carto.net/colourpicker-expected.checksum:
  • platform/mac/svg/carto.net/colourpicker-expected.png:
  • platform/mac/svg/carto.net/combobox-expected.checksum:
  • platform/mac/svg/carto.net/combobox-expected.png:
  • platform/mac/svg/carto.net/scrollbar-expected.checksum:
  • platform/mac/svg/carto.net/scrollbar-expected.png:
  • platform/mac/svg/carto.net/selectionlist-expected.checksum:
  • platform/mac/svg/carto.net/selectionlist-expected.png:
  • platform/mac/svg/carto.net/slider-expected.checksum:
  • platform/mac/svg/carto.net/slider-expected.png:
  • platform/mac/svg/carto.net/textbox-expected.checksum:
  • platform/mac/svg/carto.net/textbox-expected.png:
  • platform/mac/svg/carto.net/window-expected.checksum:
  • platform/mac/svg/carto.net/window-expected.png:
  • platform/mac/svg/css/composite-shadow-example-expected.checksum:
  • platform/mac/svg/css/composite-shadow-example-expected.png:
  • platform/mac/svg/css/composite-shadow-text-expected.checksum:
  • platform/mac/svg/css/composite-shadow-text-expected.png:
  • platform/mac/svg/css/composite-shadow-with-opacity-expected.checksum:
  • platform/mac/svg/css/composite-shadow-with-opacity-expected.png:
  • platform/mac/svg/css/group-with-shadow-expected.checksum:
  • platform/mac/svg/css/group-with-shadow-expected.png:
  • platform/mac/svg/dom/SVGTransformList-basics-expected.checksum:
  • platform/mac/svg/dom/SVGTransformList-basics-expected.png:
  • svg/batik/masking/maskRegions.svg:
  • svg/zoom/page/zoom-mask-with-percentages.svg:
7:18 AM Changeset in webkit [78705] by mnaganov@chromium.org
  • 5 edits in trunk/Source/WebKit/chromium

2011-02-16 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r78678.
​http://trac.webkit.org/changeset/78678
​https://bugs.webkit.org/show_bug.cgi?id=54554

Breaks NaCl tests in Chromium (Requested by mnaganov on
#webkit).

  • src/WebURLRequest.cpp: (WebKit::WebURLRequestPrivateImpl::WebURLRequestPrivateImpl): (WebKit::WebURLRequest::downloadToFile): (WebKit::WebURLRequest::setDownloadToFile):
  • src/WebURLRequestPrivate.h: (WebKit::WebURLRequestPrivate::WebURLRequestPrivate):
  • src/WebURLResponse.cpp: (WebKit::WebURLResponsePrivateImpl::WebURLResponsePrivateImpl): (WebKit::WebURLResponse::downloadFilePath): (WebKit::WebURLResponse::setDownloadFilePath):
  • src/WebURLResponsePrivate.h:
7:11 AM Changeset in webkit [78704] by Nikolas Zimmermann
  • 128 edits in trunk

2011-02-15 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Pixel tests differences on 10.6.6 32bit vs. 64bit
​https://bugs.webkit.org/show_bug.cgi?id=54474

When generating a SVG pixel test baseline with a vanilla 10.6.6 installation on a 32bit machine (Core Duo MBP)
and comparing the run with a software-identical 64bit machine (Core 2 Duo MBP), there are about 250 differences.

These fall in two categories:
a) 1px differences in text AA, or when drawing circles (all _below_ a tolerance of 0.01). Only visible in the subtracted difference image.

The reason is probably CGFloat being typedefed to double on 64bit machines, and float on 32bit machines.
AffineTransform stores doubles, so on 32bit machines we loose precision from AffineTransform -> CGAffineTransform.

b) Failures >0.1% (text origin/scale is slightly different, user-visible).

Caused by several sources of numerical instabilities within the SVG rendering code.

-> SVGPreserveAspectRatio::getCTM() computes an AffineTransform using doubles as input parameters, but floats are passed (like everywhere else in SVG).

This method is used to compute the viewBox AffineTransform, that affects the rendering of every content in the document. RenderSVGRoot concats
this transformation matrix to the GraphicsContext CTM, resulting in a source of numerical imprecision.

-> SVGInlineTextBox::paintTextWithShadows() calculates a scaling factor for text, to scale up the specified font size, to the actual on-screen size.

SVGInlineTextBox uses the scaled Font object, to draw in an unscaled context, that gets scaled up again afterwards.
context->scale(1 / scalingFactor); scaledFont.drawText(); context->scale(scalingFactor);

To remove the scale from the current GraphicsContext CTM, "context->scale(FloatSize(1 / scalingFactor, ...)" is used. As AffineTransform stores
doubles internally, it's likely that "context->scale(FloatSize(1 / ctm.a(), .." doesn't give you a matrix with a=1, but something close to 1.
Using "context->concatCTM(AffineTransform().scale(1 / ctm.a(), ..." could be used as workaround, to preserve double precision.
Fixing that brings us down to just a few pixel tests that differ between 32 & 64bit. There is still numerical imprecision, as floating-point
number representations aren't always precise. Unfortunately CoreGraphics doesn't provide a public way to just set a CTM, it only allows to concat them.
Fortunately CGContextSetCTM() is available, as private method, that allows me to switch the context CTM to any arbitary CGAffineTransform.

-> Add GraphicsContext::setCTM(const AffineTransform&) and implement it for all platforms (each explicitely exposes a 'setCTM' concept, except CG)

Use CGContextSetCTM() for CG, which appears to be present since at least 10.4, Cairo is using it for the same purpose since some years!

-> Instead of scaling the GraphicsContext before drawing text, grab the current CTM using context->getCTM(), scale it by '1 / scalingFactor'

normalize the transform (look for values close to 0/1 using float precision, and round!), and assign it using context->setCTM(normalizedTransform).
After drawing, just switch back to the preserved original CTM, both operations need GraphicsContext::setCTM.
This fixes all pixel test differences between 32/64 bit machines that fall into category b).
The use of GraphicsContext::setCTM() allows to switch between arbitary context transformations _without_ inducing accumulated rounding imprecision.

These combined patches fix the pixel test baseline changes.

Updated existing Snow Leopard pixel test baseline with a 32bit machine, passes here with tolerance 0.
The 64bit machine passes the baseline with tolerance 0.01.

  • platform/graphics/GraphicsContext.h: Add setCTM(const AffineTransform&) method.
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::setCTM): Implement setCTM.
  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: (WebCore::GraphicsContextPlatformPrivate::setCTM): Ditto.
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setCTM): Ditto.
  • platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: (WebCore::GraphicsContextPlatformPrivate::setCTM): Ditto.
  • platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::setCTM): Ditto.
  • platform/graphics/chromium/GLES2Canvas.h:
  • platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::setCTM): Ditto.
  • platform/graphics/openvg/GraphicsContextOpenVG.cpp: (WebCore::GraphicsContext::setCTM): Ditto.
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::setCTM): Ditto.
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setCTM): Ditto.
  • platform/graphics/win/GraphicsContextWin.cpp: (WebCore::GraphicsContextPlatformPrivate::setCTM): Ditto.
  • platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::GraphicsContextPlatformPrivate::concatCTM): (WebCore::GraphicsContextPlatformPrivate::setCTM): Ditto. (WebCore::GraphicsContext::setCTM):
  • platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::setCTM): Ditto.
  • rendering/svg/SVGInlineTextBox.cpp: Use setCTM() to switch to a scale-free AffineTransform, and also to switch back to the original CTM after rendering text. (WebCore::normalizeTransform): (WebCore::SVGInlineTextBox::paintDecorationWithStyle): (WebCore::SVGInlineTextBox::paintTextWithShadows):
  • svg/SVGPreserveAspectRatio.cpp: s/double/float/. (WebCore::SVGPreserveAspectRatio::getCTM):
  • svg/SVGPreserveAspectRatio.h:
  • svg/SVGSVGElement.cpp: Simplify viewport() code, avoid using doubles. (WebCore::SVGSVGElement::viewport):

2011-02-16 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Pixel tests differences on 10.6.6 32bit vs. 64bit
​https://bugs.webkit.org/show_bug.cgi?id=54474

Update SnowLeopard SVG pixel test baseline, generated on a 32bit machine, where it passes with tolerance 0.
This is the first chunk of several commits, as one commit is too huge for SVN.

It should pass on modern 64bit machines as well, using tolerance 0.01.

  • platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-08-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-26-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-26-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-30-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-33-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-34-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-34-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-44-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-44-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-82-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-84-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-84-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/interact-order-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/interact-order-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/interact-order-02-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/interact-order-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/linking-a-05-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/linking-a-05-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/metadata-example-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-02-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-02-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-04-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-04-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-05-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-05-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-06-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-06-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-07-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-07-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-08-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-08-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-15-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-15-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-02-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-02-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-image-02-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-path-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/text-path-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-text-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/text-text-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png:
  • platform/mac/svg/batik/masking/maskRegions-expected.txt:
  • platform/mac/svg/custom/circular-marker-reference-1-expected.txt:
  • platform/mac/svg/custom/circular-marker-reference-2-expected.txt:
  • platform/mac/svg/custom/circular-marker-reference-3-expected.txt:
  • platform/mac/svg/custom/circular-marker-reference-4-expected.txt:
  • platform/mac/svg/custom/non-circular-marker-reference-expected.txt:
  • platform/mac/svg/custom/non-scaling-stroke-markers-expected.txt:
  • platform/mac/svg/custom/stroked-pattern-expected.txt:
  • platform/mac/svg/custom/text-rotated-gradient-expected.txt:
  • platform/mac/svg/custom/use-detach-expected.txt:
  • platform/mac/svg/hixie/links/001-expected.txt:
  • platform/mac/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
  • platform/mac/svg/text/small-fonts-2-expected.txt:
  • platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
7:01 AM Changeset in webkit [78703] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-02-16 Andreas Kling <​kling@webkit.org>

Reviewed by Dirk Schulze.

SVGAnimateElement incorrectly uses Color::nameForRenderTreeAsText()
​https://bugs.webkit.org/show_bug.cgi?id=54547

  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::applyResultsToTarget):
6:18 AM Changeset in webkit [78702] by mnaganov@chromium.org
  • 2 adds in trunk/LayoutTests/platform/chromium-win-xp/media

2011-02-16 Mikhail Naganov <​mnaganov@chromium.org>

[Chromium] Unreviewed rebaseline of media video-controls-rendering for Windows.

5:52 AM Changeset in webkit [78701] by Philippe Normand
  • 3 edits in trunk/LayoutTests

2011-02-16 Philippe Normand <​pnormand@igalia.com>

Reviewed by Adam Roben.

media/audio-delete-while-slider-thumb-clicked.html failing on Windows since r78562
​https://bugs.webkit.org/show_bug.cgi?id=54502

  • media/audio-delete-while-slider-thumb-clicked.html: Avoid deleting the element twice.
  • platform/win/Skipped: unskip the test.
5:48 AM Changeset in webkit [78700] by mnaganov@chromium.org
  • 7 edits
    1 add in trunk/Source/WebCore

2011-02-14 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Landing detailed heap snapshots, part 3.
​https://bugs.webkit.org/show_bug.cgi?id=54385

Provide node classes for data grid views:

  • summary -- list of objects by constuctor;
  • diff -- summaries btw two snapshots;
  • explorer -- explore heap graph;
  • dominators tree;
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/DetailedHeapshotGridNodes.js: Added.
  • inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshotFilteredOrderedIterator): (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.incInstancesCount): (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.get instancesCount): (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.next): (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.resetInstancesCount): (WebInspector.HeapSnapshotEdgesProvider): (WebInspector.HeapSnapshotNodesProvider):
  • inspector/front-end/PleaseWaitMessage.js: (WebInspector.PleaseWaitMessage.prototype.get instance):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
5:22 AM Changeset in webkit [78699] by loislo@chromium.org
  • 4 edits in trunk

2011-02-16 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: chromium: DRT is crashing on the tests in inspector-enabled folder.
​https://bugs.webkit.org/show_bug.cgi?id=54548

Bug in chromium DRT implementation was fixed.
The tests were enabled.

  • platform/chromium/test_expectations.txt:

2011-02-16 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: chromium: DRT is crashing on the tests in inspector-enabled folder.
​https://bugs.webkit.org/show_bug.cgi?id=54548

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::runFileTest):
5:08 AM Changeset in webkit [78698] by mnaganov@chromium.org
  • 2 edits
    5 adds in trunk/LayoutTests/platform

2011-02-16 Mikhail Naganov <​mnaganov@chromium.org>

[Chromium] Unreviewed rebaseline of 2 more media tests.

5:02 AM Changeset in webkit [78697] by mnaganov@chromium.org
  • 19 edits
    13 adds in trunk/LayoutTests/platform

2011-02-16 Mikhail Naganov <​mnaganov@chromium.org>

[Chromium] Unreviewed rebaseline of media tests.

4:54 AM Changeset in webkit [78696] by Philippe Normand
  • 3 edits in trunk/LayoutTests

2011-02-16 Philippe Normand <​pnormand@igalia.com>

Unreviewed, qt and mac rebaseline of test after r78690.

  • media/controls-without-preload-expected.txt:
  • platform/qt/media/controls-without-preload-expected.txt:
3:58 AM Changeset in webkit [78695] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-02-16 Philippe Normand <​pnormand@igalia.com>

Unreviewed, rebaseline test after r78690.

  • media/controls-without-preload-expected.txt:
3:51 AM Changeset in webkit [78694] by mnaganov@chromium.org
  • 16 edits
    2 deletes in trunk

2011-02-16 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r78655.
​http://trac.webkit.org/changeset/78655
​https://bugs.webkit.org/show_bug.cgi?id=54543

Causes too many test failures in chromium (Requested by
mnaganov on #webkit).

  • storage/indexeddb/exception-in-event-aborts-expected.txt: Removed.
  • storage/indexeddb/exception-in-event-aborts.html: Removed.
  • storage/indexeddb/queued-commands-expected.txt:
  • storage/indexeddb/queued-commands.html:
  • storage/indexeddb/request-event-propagation-expected.txt:
  • storage/indexeddb/request-event-propagation.html:
  • storage/indexeddb/resources/shared.js: (unexpectedErrorCallback):
  • storage/indexeddb/transaction-event-propagation-expected.txt:
  • storage/indexeddb/transaction-event-propagation.html:
3:41 AM Changeset in webkit [78693] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-02-16 Philippe Normand <​pnormand@igalia.com>

Unreviewed rebaseline GTK media test result.

  • platform/gtk/media/video-controls-rendering-expected.txt:
3:21 AM Changeset in webkit [78692] by loislo@chromium.org
  • 8 edits in trunk/Source/WebCore

2011-02-16 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move Database and DOMStorage related things from InspectorAgent to the corresponding agents.

​https://bugs.webkit.org/show_bug.cgi?id=54455

Some set of instrumentation calls should work even if we have no InspectorFrontend instance and corresponding agents.
At the moment we are using InspectorAgent instance for such calls.

  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::createFrontendLifetimeAgents): (WebCore::InspectorAgent::pushDataCollectedOffline): (WebCore::InspectorAgent::didCommitLoad):
  • inspector/InspectorAgent.h: (WebCore::InspectorOfflineResourcesBase::~InspectorOfflineResourcesBase): (WebCore::InspectorOfflineResourcesBase::InspectorOfflineResourcesBase): (WebCore::InspectorAgent::databaseAgentResources): (WebCore::InspectorAgent::domStorageAgentResources):
  • inspector/InspectorDOMStorageAgent.cpp: (WebCore::InspectorDOMStorageAgent::Resources::clear): (WebCore::InspectorDOMStorageAgent::Resources::pushDataCollectedOffline): (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent): (WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent): (WebCore::InspectorDOMStorageAgent::createOfflineStorage): (WebCore::InspectorDOMStorageAgent::selectDOMStorage): (WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId): (WebCore::InspectorDOMStorageAgent::didUseDOMStorage):
  • inspector/InspectorDOMStorageAgent.h: (WebCore::InspectorDOMStorageAgent::create):
  • inspector/InspectorDatabaseAgent.cpp: (WebCore::InspectorDatabaseAgent::Resources::clear): (WebCore::InspectorDatabaseAgent::Resources::pushDataCollectedOffline): (WebCore::InspectorDatabaseAgent::didOpenDatabase): (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent): (WebCore::InspectorDatabaseAgent::createOfflineStorage): (WebCore::InspectorDatabaseAgent::databaseForId): (WebCore::InspectorDatabaseAgent::selectDatabase):
  • inspector/InspectorDatabaseAgent.h: (WebCore::InspectorDatabaseAgent::create):
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didOpenDatabaseImpl): (WebCore::InspectorInstrumentation::didUseDOMStorageImpl):
3:20 AM Changeset in webkit [78691] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-02-16 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r77898.
​http://trac.webkit.org/changeset/77898
​https://bugs.webkit.org/show_bug.cgi?id=54541

Leopard Debug hasn't compiled for a long time (Requested by
abarth on #webkit).

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3:13 AM Changeset in webkit [78690] by Philippe Normand
  • 5 edits in trunk/LayoutTests

2011-02-15 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] media/controls-without-preload.html is flacky on 32-bits Debug
​https://bugs.webkit.org/show_bug.cgi?id=50518

Refactored 2 media tests to avoid use of setTimeout and possible
flakyness.

  • media/controls-without-preload.html:
  • media/video-display-toggle.html:
  • platform/gtk/Skipped:
  • platform/gtk/media/controls-without-preload-expected.txt:
3:10 AM Changeset in webkit [78689] by Philippe Normand
  • 6 edits in trunk/LayoutTests

2011-02-15 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

[GStreamer] wrong media duration report in media/controls-after-reload.html
​https://bugs.webkit.org/show_bug.cgi?id=51602

Refactored some media tests to be less flaky-prone.

  • media/controls-after-reload.html: Trigger playback just before rendering the controls.
  • media/video-paint-test.js: Ditto. (init.document.addEventListener.): (init):
  • media/video-volume-slider.html: Trigger DRT dump after volume was updated.
  • platform/gtk/Skipped: Unskip fixed tests.
  • platform/gtk/media/video-controls-rendering-expected.txt:
2:47 AM Changeset in webkit [78688] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-02-16 Aparna Nandyal <​aparna.nand@wipro.com>

Reviewed by Andreas Kling.

[Qt] QWebFrame: When a relative url is loaded then it will make it absolute internally, however this strips out any query/fragments
​https://bugs.webkit.org/show_bug.cgi?id=29424

ensureAbsoluteUrl function was stripping the query and the
fragment part of the url. Corrected this.

  • Api/qwebframe.cpp: (ensureAbsoluteUrl):

Feb 15, 2011:

11:31 PM Changeset in webkit [78687] by sullivan@apple.com
  • 2 edits in trunk/Source/WebCore

Dan Bernstein came up with this fix while we debugged it. I just typed.

Reviewed by Antti Koivisto.

​https://bugs.webkit.org/show_bug.cgi?id=54532
On platforms without platformWidgets, going Back to a scrolled page
draws at the top-left before drawing at the restored scroll position

<rdar://problem/8998838>

  • page/FrameView.cpp:

(WebCore::FrameView::performPostLayoutTasks):
Don't send the didFirstLayout and didFirstVisuallyNonEmptyLayout callbacks
for nested layouts. Doing so was causing ScrollView::setScrollPosition()
to short-circuit.

11:27 PM Changeset in webkit [78686] by Csaba Osztrogonác
  • 4 edits in trunk/Source

Unreviewed.

[Qt][V8] Buildfix. Add missing USE(JSC) guard.

Source/WebCore:

  • plugins/qt/PluginViewQt.cpp:

Source/WebKit/qt:

  • Api/qwebelement.cpp:
10:48 PM Changeset in webkit [78685] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-02-15 Xianzhu Wang <​wangxianzhu@google.com>

Reviewed by Kent Tamura.

Fixed a small bug about --no-timeout option.
​https://bugs.webkit.org/show_bug.cgi?id=52873

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (main):
10:41 PM Changeset in webkit [78684] by mrowe@apple.com
  • 5 edits in branches/safari-534.20-branch/Source

Versioning.

10:39 PM Changeset in webkit [78683] by mrowe@apple.com
  • 1 copy in tags/Safari-534.20.1

New tag.

9:33 PM Changeset in webkit [78682] by tkent@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-02-15 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

Chromium-Mac-Leopard baseline files for r78677.

  • platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-layer-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-layer-expected.png: Added.
9:08 PM Changeset in webkit [78681] by tkent@chromium.org
  • 1 edit
    6 adds in trunk/LayoutTests

2011-02-15 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

Chromium baseline files for a new test of r78677.

  • platform/chromium-linux/fast/forms/input-appearance-spinbutton-layer-expected.checksum: Added.
  • platform/chromium-linux/fast/forms/input-appearance-spinbutton-layer-expected.png: Added.
  • platform/chromium-linux/fast/forms/input-appearance-spinbutton-layer-expected.txt: Added.
  • platform/chromium-win-xp/fast/forms/input-appearance-spinbutton-layer-expected.checksum: Added.
  • platform/chromium-win-xp/fast/forms/input-appearance-spinbutton-layer-expected.png: Added.
  • platform/chromium-win-xp/fast/forms/input-appearance-spinbutton-layer-expected.txt: Added.
9:07 PM Changeset in webkit [78680] by commit-queue@webkit.org
  • 3 edits
    5 adds in trunk

2011-02-15 Ami Fischman <​fischman@chromium.org>

Reviewed by David Levin.

Remove the artificial -32px shift for media controls in mediaDocuments
so that they overlap the canvas as they do in non-mediaDocuments.
This also fixes test_shell failing to update the media slider (see
linked crbug below).

​https://bugs.webkit.org/show_bug.cgi?id=27798
​http://crbug.com/72623

Test: media/video-controls-in-media-document.html
Added a render test that asserts that the controls show up in the
expected spot (0,208) instead of below the canvas (0,240).

  • css/mediaControlsChromium.css:
9:05 PM Changeset in webkit [78679] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-15 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

Extract a function to process ancestor and their sibling nodes from processContents
​https://bugs.webkit.org/show_bug.cgi?id=54425

Extracted processAncestorsAndTheirSiblings.

  • dom/Range.cpp: (WebCore::Range::processContents): Calls processContents. (WebCore::Range::processAncestorsAndTheirSiblings): Extracted from processContents.
  • dom/Range.h:
8:51 PM Changeset in webkit [78678] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

2011-02-15 Bill Budge <​bbudge@chromium.org>

Reviewed by David Levin.

WebURLRequest, WebURLResponse properties should be passed to WebCore Layer
​https://bugs.webkit.org/show_bug.cgi?id=54489

No tests needed, exposes no new functionality

  • src/WebURLRequest.cpp: (WebKit::WebURLRequestPrivateImpl::WebURLRequestPrivateImpl): (WebKit::WebURLRequest::downloadToFile): (WebKit::WebURLRequest::setDownloadToFile):
  • src/WebURLRequestPrivate.h: (WebKit::WebURLRequestPrivate::WebURLRequestPrivate):
  • src/WebURLResponse.cpp: (WebKit::WebURLResponsePrivateImpl::WebURLResponsePrivateImpl): (WebKit::WebURLResponse::downloadFilePath): (WebKit::WebURLResponse::setDownloadFilePath):
  • src/WebURLResponsePrivate.h:
8:14 PM Changeset in webkit [78677] by tkent@chromium.org
  • 5 edits
    4 adds in trunk

[Chromium] Rendering error of spin buttons on layers
​https://bugs.webkit.org/show_bug.cgi?id=54427

Reviewed by Darin Fisher.

Source/WebCore:

Test: fast/forms/input-appearance-spinbutton-layer.html

  • rendering/RenderThemeChromiumWin.cpp: Add checks for multiple ThemePainter instances.

(WebCore::RenderThemeChromiumWin::paintInnerSpinButton):

Avoid to create multiple ThemePainter instances.

LayoutTests:

  • fast/forms/input-appearance-spinbutton-layer.html: Added.
  • platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.checksum: Added.
  • platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.png: Added.
  • platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.txt: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
8:11 PM Changeset in webkit [78676] by andersca@apple.com
  • 16 edits in trunk/Source/WebKit2

2011-02-15 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

WebPluginSiteDataManager should work with plug-in process
​https://bugs.webkit.org/show_bug.cgi?id=54523
<rdar://problem/8689312>

  • PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::removeWebProcessConnection): Call startShutdownTimerIfNecessary().

(WebKit::PluginProcess::getSitesWithData):
Ask the plug-in module for the sites with data and send them back
in a PluginProcessProxy::DidGetSitesWithData message.

(WebKit::PluginProcess::clearSiteData):
Clear site data and send back a DidClearSiteData message.

(WebKit::PluginProcess::startShutdownTimerIfNecessary):
Factor code out from removeWebProcessConnection.

  • PluginProcess/PluginProcess.messages.in: Add new messages.
  • UIProcess/Plugins/PluginInfoStore.cpp: (WebKit::PluginInfoStore::plugins): New function for getting all plug-ins.
  • UIProcess/Plugins/PluginProcessManager.cpp: (WebKit::PluginProcessManager::getPluginProcessConnection): Call getOrCreatePluginProcess.

(WebKit::PluginProcessManager::getSitesWithData):
Get a plug-in process proxy and call getSitesWithData.

(WebKit::PluginProcessManager::clearSiteData):
Get a plug-in process proxy and call clearSiteData.

(WebKit::PluginProcessManager::getOrCreatePluginProcess):
Factor code to create a plug-in process out into a separate function.

  • UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::getSitesWithData): (WebKit::PluginProcessProxy::clearSiteData): Update the pending reply struct. If the process is still launching, enqueue the request. Otherwise, just send the message.

(WebKit::PluginProcessProxy::pluginProcessCrashedOrFailedToLaunch):
Make sure that pending replies are sent out.

(WebKit::PluginProcessProxy::didFinishLaunching):
Send our pending requests.

(WebKit::PluginProcessProxy::didGetSitesWithData):
(WebKit::PluginProcessProxy::didClearSiteData):
Call down to the plug-in site data manager.

  • UIProcess/Plugins/PluginProcessProxy.messages.in: Add DidGetSitesWithData and DidClearSiteData messages.
  • UIProcess/Plugins/WebPluginSiteDataManager.cpp: (WebKit::WebPluginSiteDataManager::GetSitesWithDataState::GetSitesWithDataState): Initialize the state.

(WebKit::WebPluginSiteDataManager::GetSitesWithDataState::getSitesWithDataForNextPlugin):
If the plug-in queue is empty, call didGetSitesWithDataForAllPlugins. Otherwise, ask
the plug-in process manager to get sites for the next plug-in.

(WebKit::WebPluginSiteDataManager::GetSitesWithDataState::didGetSitesWithDataForSinglePlugin):
Update the sites set and get sites for the next plug-in.

(WebKit::WebPluginSiteDataManager::ClearSiteDataState::ClearSiteDataState):
Initialize the state.

(WebKit::WebPluginSiteDataManager::ClearSiteDataState::clearSiteDataForNextPlugin):
If the plug-in queue is empty, call didClearSiteDataForAllPlugins. Otherwise, ask
the plug-in process manager to get sites for the next plug-in.


(WebKit::WebPluginSiteDataManager::ClearSiteDataState::didClearSiteDataForSinglePlugin):
Update the sites set and ask the next plug-in to clear site data.

(WebKit::WebPluginSiteDataManager::~WebPluginSiteDataManager):
Assert that all maps are empty.

(WebKit::WebPluginSiteDataManager::invalidate):
Delete and clear the pending state maps.

(WebKit::WebPluginSiteDataManager::getSitesWithData):
In the ENABLE(PLUGIN_PROCESS) case, allocate a new GetSitesWithDataState object and
tell it to get sites for the next plug-in. Otherwise, make sure that the web process
is alive before sending a GetSitesWithPluginData message.


(WebKit::WebPluginSiteDataManager::clearSiteData):
In the ENABLE(PLUGIN_PROCESS) case, allocate a new ClearSiteDataState object and
tell it to get sites for the next plug-in. Otherwise, make sure that the web process
is alive before sending a ClearPluginSiteData message.


(WebKit::WebPluginSiteDataManager::didGetSitesWithDataForSinglePlugin):
Call down to the GetSitesWithDataState object.

(WebKit::WebPluginSiteDataManager::didGetSitesWithDataForAllPlugins):
Free the GetSitesWithDataState object and invoke the callback.

(WebKit::WebPluginSiteDataManager::didClearSiteDataForSinglePlugin):
Call down to the GetSitesWithDataState object.


(WebKit::WebPluginSiteDataManager::didClearSiteDataForAllPlugins):
Free the GetSitesWithDataState object and invoke the callback.

  • UIProcess/WebContext.cpp: (WebKit::WebContext::processDidClose): Don't invalidate the plug-in site data manager if we're using a plug-in process.
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::getSitesWithPluginData): (WebKit::WebProcess::clearPluginSiteData): Call shutdownIfPossible().
7:41 PM Changeset in webkit [78675] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-02-15 Martin Robinson <​mrobinson@igalia.com>

Skip all Hixie SVG performance tests on GTK+. They seem
to be timing out on the GTK+ debug bots.

  • platform/gtk/Skipped: Skip Hixie SVG performance tests.
7:16 PM Changeset in webkit [78674] by ddkilzer@apple.com
  • 5 edits in trunk/Source/WebKit/mac

2011-02-15 David Kilzer <​ddkilzer@apple.com>

<​http://webkit.org/b/54505> Move -[WebDynamicScrollBarsView inProgrammaticScroll] to WebDynamicScrollBarsViewInternal.h

Reviewed by Darin Adler.

  • WebView/WebDynamicScrollBarsView.h: (-[WebDynamicScrollBarsView inProgrammaticScroll]): Removed declaration.
  • WebView/WebDynamicScrollBarsView.mm: (-[WebDynamicScrollBarsView inProgrammaticScroll]): Moved implementation into correct category.
  • WebView/WebDynamicScrollBarsViewInternal.h: (-[WebDynamicScrollBarsView inProgrammaticScroll]): Added declaration.
  • WebView/WebHTMLView.mm: Included WebDynamicScrollBarsViewInternal.h instead of WebDynamicScrollBarsView.h.
7:08 PM Changeset in webkit [78673] by jhoneycutt@apple.com
  • 2 edits in trunk/Source/WebKit2

Copy over new WebKit 2 header.

Rubber-stamped by Alice Liu.

  • win/WebKit2Generated.make:
7:03 PM Changeset in webkit [78672] by sfalken@apple.com
  • 2 edits in trunk/LayoutTests

Skipped crashing test on Windows.
Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=54519

  • platform/win/Skipped: Skip fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer.html
6:12 PM Changeset in webkit [78671] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

2011-02-15 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Fix race condition in JavaScriptAudioNode
​https://bugs.webkit.org/show_bug.cgi?id=54518

No new tests since audio API is not yet implemented.

  • webaudio/JavaScriptAudioNode.cpp: (WebCore::JavaScriptAudioNode::process):
6:06 PM Changeset in webkit [78670] by mrowe@apple.com
  • 2 edits in branches/safari-534.20-branch/Source/WebKit2

Merge r78578.

6:06 PM Changeset in webkit [78669] by mrowe@apple.com
  • 2 edits in branches/safari-534.20-branch/Source/WebKit2

Merge r78609.

6:06 PM Changeset in webkit [78668] by mrowe@apple.com
  • 3 edits in branches/safari-534.20-branch/Source/WebKit2

Merge r78600.

6:02 PM Changeset in webkit [78667] by abarth@webkit.org
  • 1 edit
    4 copies in branches/chromium/648

Merge 77724 - 2011-02-04 Hironori Bono <​hbono@chromium.org>

Reviewed by Adam Barth.

[chromium] JPEG corruption
​https://bugs.webkit.org/show_bug.cgi?id=53250

This change adds a new script test that we can render a CMYK JPEG with a
color profile correctly, i.e. we can render it without color corruption.

  • fast/images/cmyk-jpeg-with-color-profile-expected.txt: Added.
  • fast/images/cmyk-jpeg-with-color-profile.html: Added.
  • fast/images/resources/cmyk-jpeg.jpg: Added.
  • fast/images/script-tests/cmyk-jpeg-with-color-profile.js: Added. (image.onload):

2011-02-04 Hironori Bono <​hbono@chromium.org>

Reviewed by Adam Barth.

[chromium] JPEG corruption
​https://bugs.webkit.org/show_bug.cgi?id=53250

Same as gray-scale JPEGs, we convert the colors of CMYK JPEGs with color
profiles from CMYK to RGB twice and it causes color corruption. This
change suppresses the color profiles for CMYK JPEGs same as gray-scale
ones.

Test: fast/images/cmyk-jpeg-with-color-profile.html

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::decode):

TBR=​commit-queue@webkit.org

6:01 PM Changeset in webkit [78666] by mrowe@apple.com
  • 3 edits in branches/safari-534.20-branch/Source/WebKit2

Merge r78513.

5:57 PM Changeset in webkit [78665] by mrowe@apple.com
  • 2 edits in branches/safari-534.20-branch/Source/WebKit2

Merge r78523.

5:56 PM Changeset in webkit [78664] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, Chromium test expectations update.

Remove line with dupe expectations.

  • platform/chromium/test_expectations.txt:
5:55 PM Changeset in webkit [78663] by andersca@apple.com
  • 11 edits in trunk/Source/WebKit2

2011-02-15 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

Implement WKPluginSiteDataManagerClearSiteData
​https://bugs.webkit.org/show_bug.cgi?id=54512
<rdar://problem/8689312>

  • UIProcess/API/C/WKPluginSiteDataManager.cpp: (WKPluginSiteDataManagerGetTypeID): Implement this.

(toNPClearSiteDataFlags):
Convert WKClearSiteDataFlags to NPP_ClearSiteData flags.


(WKPluginSiteDataManagerClearSiteData):
(WKPluginSiteDataManagerClearAllSiteData):
Call through to WebPluginSiteDataManager::clearSiteData.

  • UIProcess/API/C/WKPluginSiteDataManager.h: Change the clear functions to take a completion callback.
  • UIProcess/Plugins/WebPluginSiteDataManager.cpp: (WebKit::WebPluginSiteDataManager::clearSiteData): Ask the plug-in info store for all plug-in paths and send a ClearPluginSiteData message to the web process.


(WebKit::WebPluginSiteDataManager::didClearSiteData):
call the callback.

  • UIProcess/WebContext.cpp: (WebKit::WebContext::didClearPluginSiteData): Call through to the plug-in site data manager.
  • UIProcess/WebContext.messages.in: Add ClearPluginSiteData message.
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::clearPluginSiteData): Iterate over all the plug-in paths, creating plug-in modules and calling clearSiteData for each one.
  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in: Add DidClearPluginSiteData message.
5:53 PM Changeset in webkit [78662] by mrowe@apple.com
  • 2 edits in branches/safari-534.20-branch/Source/WebCore

Merge r78517.

5:50 PM Changeset in webkit [78661] by mrowe@apple.com
  • 4 edits in branches/safari-534.20-branch/Source/WebCore

Merge r78630.

5:46 PM Changeset in webkit [78660] by mrowe@apple.com
  • 8 edits in branches/safari-534.20-branch/Source/WebCore

Merge r78612.

5:44 PM Changeset in webkit [78659] by mrowe@apple.com
  • 3 edits in branches/safari-534.20-branch/Source/WebKit2

Merge r78589.

5:42 PM Changeset in webkit [78658] by mrowe@apple.com
  • 13 edits in branches/safari-534.20-branch

Merge r78588.

5:37 PM Changeset in webkit [78657] by mihaip@chromium.org
  • 3 edits in trunk/LayoutTests

2011-02-15 Mihai Parparita <​mihaip@chromium.org>

Unreviewed chromium-gpu-linux rebaseline of
compositing/geometry/vertical-scroll-composited.html.

  • platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.checksum:
  • platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.png:
5:36 PM Changeset in webkit [78656] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, Chromium test expectations update.

  • platform/chromium/test_expectations.txt:
5:24 PM Changeset in webkit [78655] by jorlow@chromium.org
  • 16 edits
    2 adds in trunk

2011-02-10 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

Throwing in an IndexedDB error or success event should lead to the transaction aborting
​https://bugs.webkit.org/show_bug.cgi?id=54249

  • storage/indexeddb/exception-in-event-aborts-expected.txt: Added.
  • storage/indexeddb/exception-in-event-aborts.html: Added.

tests new feature

  • storage/indexeddb/queued-commands-expected.txt:
  • storage/indexeddb/queued-commands.html:

cleaned up (while debuggign something else)

  • storage/indexeddb/request-event-propagation-expected.txt:
  • storage/indexeddb/request-event-propagation.html:

a few additional tests + cleanup

  • storage/indexeddb/transaction-event-propagation-expected.txt:
  • storage/indexeddb/transaction-event-propagation.html:

a few additional tests + cleanup

2011-02-10 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

Throwing in an IndexedDB error or success event should lead to the transaction aborting
​https://bugs.webkit.org/show_bug.cgi?id=54249

When an exception is thrown but not handled within an IDBRequests success/error event,
we should abort the transaction.

Test: storage/indexeddb/exception-in-event-aborts.html

  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent):
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS):
  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::invokeEventHandler):
  • dom/EventTarget.cpp: (WebCore::EventTarget::uncaughtExceptionInEventHandler):
  • dom/EventTarget.h:
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::uncaughtExceptionInEventHandler):
  • storage/IDBRequest.h:
5:22 PM Changeset in webkit [78654] by jhoneycutt@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix for
​https://bugs.webkit.org/show_bug.cgi?id=54415

Remove deleted files.

5:19 PM Changeset in webkit [78653] by mrowe@apple.com
  • 5 edits in branches/safari-534.20-branch/Source

Versioning.

5:15 PM Changeset in webkit [78652] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

2011-02-15 Ian Henderson <​ianh@apple.com>

Reviewed by Darin Adler.

To determine image properties, CG allocates memory which isn't included in CachedImage's decoded size
​https://bugs.webkit.org/show_bug.cgi?id=53281

When determining properties of an image (such as its size), CG ends up
decoding part of the image. This patch adds accounting for this extra
decoded size so a cache prune can clean up the allocations.

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::destroyMetadataAndNotify): Clearing the source destroys the extra decoded data. Report this change in decoded size to the image observer. (WebCore::BitmapImage::cacheFrame): The first decoded frame subsumes the data decoded when determining image properties, so we subtract it out here. (WebCore::BitmapImage::didDecodeProperties): Reports the extra decoded size to the image's observer. (WebCore::BitmapImage::size): (WebCore::BitmapImage::currentFrameSize): (WebCore::BitmapImage::getHotSpot): (WebCore::BitmapImage::frameCount): (WebCore::BitmapImage::isSizeAvailable): (WebCore::BitmapImage::repetitionCount):
  • platform/graphics/BitmapImage.h:
  • platform/graphics/ImageSource.cpp: (WebCore::ImageSource::bytesDecodedToDetermineProperties): The default value is 0 to match the current behavior on other platforms.
  • platform/graphics/ImageSource.h:
  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::bytesDecodedToDetermineProperties): Add a constant value for bytesDecodedToDetermineProperties(), measured by tracing malloc/calloc calls while asking an image source for its properties.
5:11 PM Changeset in webkit [78651] by sfalken@apple.com
  • 1 edit
    5 adds in trunk/LayoutTests

Windows-specific results for tests added in r78396.
​https://bugs.webkit.org/show_bug.cgi?id=54506

  • platform/win/fast/inline: Added.
  • platform/win/fast/inline/inline-box-background-expected.txt: Added.
  • platform/win/fast/inline/inline-box-background-long-image-expected.txt: Added.
  • platform/win/fast/inline/inline-box-background-repeat-x-expected.txt: Added.
  • platform/win/fast/inline/inline-box-background-repeat-y-expected.txt: Added.
5:05 PM Changeset in webkit [78650] by mrowe@apple.com
  • 1 copy in branches/safari-534.20-branch

New branch.

4:58 PM Changeset in webkit [78649] by mihaip@chromium.org
  • 2 edits
    77 adds in trunk/LayoutTests

2011-02-15 Mihai Parparita <​mihaip@chromium.org>

Unreviewed chromium-gpu rebaseline. Rebaseline tests that were unskipped
after r78619 as well as some lingering Mac rebaselines.

  • platform/chromium-gpu-linux/compositing/color-matching/image-color-matching-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/color-matching/image-color-matching-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/color-matching/image-color-matching-expected.txt: Added.
  • platform/chromium-gpu-linux/compositing/geometry/abs-position-inside-opacity-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/geometry/abs-position-inside-opacity-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/geometry/abs-position-inside-opacity-expected.txt: Added.
  • platform/chromium-gpu-linux/compositing/masks/direct-image-mask-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/masks/direct-image-mask-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/masks/direct-image-mask-expected.txt: Added.
  • platform/chromium-gpu-linux/compositing/overflow/ancestor-overflow-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/overflow/ancestor-overflow-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/overflow/ancestor-overflow-expected.txt: Added.
  • platform/chromium-gpu-linux/compositing/repaint/composited-document-element-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/repaint/composited-document-element-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/repaint/composited-document-element-expected.txt: Added.
  • platform/chromium-gpu-linux/compositing/shadows/shadow-drawing-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/shadows/shadow-drawing-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/shadows/shadow-drawing-expected.txt: Added.
  • platform/chromium-gpu-mac/compositing/color-matching/image-color-matching-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/color-matching/image-color-matching-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/geometry/abs-position-inside-opacity-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/geometry/abs-position-inside-opacity-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/masks/direct-image-mask-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/masks/direct-image-mask-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/overflow/overflow-scroll-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/overflow/overflow-scroll-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/repaint/composited-document-element-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/repaint/composited-document-element-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/repaint/opacity-between-absolute2-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/repaint/opacity-between-absolute2-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/shadows/shadow-drawing-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/shadows/shadow-drawing-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/text-on-large-layer-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/text-on-large-layer-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/tiling/constrained-layer-size-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/tiling/constrained-layer-size-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/transitions/scale-transition-no-start-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/transitions/scale-transition-no-start-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/z-order/negative-z-index-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/z-order/negative-z-index-expected.png: Added.
  • platform/chromium-gpu-win/compositing/color-matching/image-color-matching-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/color-matching/image-color-matching-expected.png: Added.
  • platform/chromium-gpu-win/compositing/color-matching/image-color-matching-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/geometry/abs-position-inside-opacity-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/geometry/abs-position-inside-opacity-expected.png: Added.
  • platform/chromium-gpu-win/compositing/geometry/abs-position-inside-opacity-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/masks/direct-image-mask-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/masks/direct-image-mask-expected.png: Added.
  • platform/chromium-gpu-win/compositing/masks/direct-image-mask-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/overflow/ancestor-overflow-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/overflow/ancestor-overflow-expected.png: Added.
  • platform/chromium-gpu-win/compositing/overflow/ancestor-overflow-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/repaint/composited-document-element-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/repaint/composited-document-element-expected.png: Added.
  • platform/chromium-gpu-win/compositing/repaint/composited-document-element-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/shadows/shadow-drawing-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/shadows/shadow-drawing-expected.png: Added.
  • platform/chromium-gpu-win/compositing/shadows/shadow-drawing-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/tiling/constrained-layer-size-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/tiling/constrained-layer-size-expected.png: Added.
  • platform/chromium-gpu-win/compositing/z-order/negative-z-index-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/z-order/negative-z-index-expected.png: Added.
  • platform/chromium/test_expectations.txt:
4:53 PM Changeset in webkit [78648] by jamesr@google.com
  • 9 edits
    4 adds in trunk

2011-02-15 James Robinson <​jamesr@chromium.org>

Reviewed by Alexey Proskuryakov.

requestAnimationFrame callbacks should not fire within a modal dialog
​https://bugs.webkit.org/show_bug.cgi?id=53188

Tests that requestAnimationFrame callbacks are suspended while a modal
dialog is showing.

  • fast/animation/request-animation-frame-during-modal-expected.txt: Added.
  • fast/animation/request-animation-frame-during-modal.html: Added.

2011-02-15 James Robinson <​jamesr@chromium.org>

Reviewed by Alexey Proskuryakov.

requestAnimationFrame callbacks should not fire within a modal dialog
​https://bugs.webkit.org/show_bug.cgi?id=53188

requestAnimationFrame callbacks shouldn't fire while a modal dialog is up (like a window.alert()).
This matches Firefox and other async APIs. This patch moves the callback servicing into its own
controller class which receives notifications on suspend/resume.

Test: fast/animation/request-animation-frame-during-modal.html

  • WebCore.gypi:
  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setJavaScriptPaused):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::suspendScriptedAnimationControllerCallbacks): (WebCore::Document::resumeScriptedAnimationControllerCallbacks): (WebCore::Document::webkitRequestAnimationFrame): (WebCore::Document::webkitCancelRequestAnimationFrame): (WebCore::Document::serviceScriptedAnimations):
  • dom/Document.h:
  • dom/ScriptExecutionContext.h: (WebCore::ScriptExecutionContext::suspendScriptedAnimationControllerCallbacks): (WebCore::ScriptExecutionContext::resumeScriptedAnimationControllerCallbacks):
  • dom/ScriptedAnimationController.cpp: Added. (WebCore::ScriptedAnimationController::ScriptedAnimationController): (WebCore::ScriptedAnimationController::suspend): (WebCore::ScriptedAnimationController::resume): (WebCore::ScriptedAnimationController::registerCallback): (WebCore::ScriptedAnimationController::cancelCallback): (WebCore::ScriptedAnimationController::serviceScriptedAnimations):
  • dom/ScriptedAnimationController.h: Added. (WebCore::ScriptedAnimationController::create):
  • history/CachedFrame.cpp: (WebCore::CachedFrameBase::restore): (WebCore::CachedFrame::CachedFrame):
  • page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
4:49 PM Changeset in webkit [78647] by andersca@apple.com
  • 14 edits
    2 adds in trunk/Source/WebKit2

2011-02-15 Anders Carlsson <​andersca@apple.com>

Reviewed by Jon Honeycutt.

Implement WKPluginSiteDataManagerGetSitesWithData
​https://bugs.webkit.org/show_bug.cgi?id=54510
<rdar://problem/8689312>

  • UIProcess/API/C/WKContext.cpp: (WKContextGetPluginSiteDataManager): Call WebContext::pluginSiteDataManager.


  • UIProcess/API/C/WKPluginSiteDataManager.cpp: (WKPluginSiteDataManagerGetSitesWithData): Call WebPluginSiteDataManager::getSitesWithData.
  • UIProcess/Plugins/PluginInfoStore.cpp: (WebKit::PluginInfoStore::getPluginPaths):
  • UIProcess/Plugins/PluginInfoStore.h: Populate the paths argument with the paths of all plug-ins.


  • UIProcess/Plugins/WebPluginSiteDataManager.cpp: Added. (WebKit::WebPluginSiteDataManager::invalidate): Invalidate the callbacks map.

(WebKit::WebPluginSiteDataManager::getSitesWithData):
Ask the plug-in info store for all plug-in paths and send a
GetSitesWithPluginData message to the web process.

(WebKit::WebPluginSiteDataManager::didGetSitesWithPluginData):
Call the callback.

  • UIProcess/Plugins/WebPluginSiteDataManager.h: Added. (WebKit::WebPluginSiteDataManager::clearContext): Clear the context.
  • UIProcess/WebContext.cpp: (WebKit::WebContext::WebContext): Initialize m_pluginSiteDataManager.

(WebKit::WebContext::~WebContext):
Invalidate the plug-in site data manager and clear its context.

(WebKit::WebContext::processDidClose):
Invalidate the plug-in site data manager.


(WebKit::WebContext::didGetSitesWithPluginData):
Call through to the plug-in site data manager.

  • UIProcess/WebContext.h:
  • UIProcess/WebContext.messages.in: Add GetSitesWithPluginData message.
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj: Add new files.
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::getSitesWithPluginData): Iterate over all plug-in paths and get the sites from all plug-ins.
  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in: Add DidGetSitesWithPluginData.
4:43 PM Changeset in webkit [78646] by kalman@chromium.org
  • 5 edits
    2 deletes in trunk/LayoutTests

2011-02-15 Benjamin Kalman <​kalman@chromium.org>

Reviewed by Darin Adler.

Clean up results for editing/selection/extend-selection-home-end layout test
​https://bugs.webkit.org/show_bug.cgi?id=54508

Line up results in columns, remove unused pixel test results from qt.

  • editing/selection/extend-selection-home-end-expected.txt:
  • editing/selection/extend-selection-home-end.html:
  • platform/mac/editing/selection/extend-selection-home-end-expected.txt:
  • platform/qt/editing/selection/extend-selection-home-end-expected.checksum: Removed.
  • platform/qt/editing/selection/extend-selection-home-end-expected.png: Removed.
  • platform/win/editing/selection/extend-selection-home-end-expected.txt:
4:38 PM Changeset in webkit [78645] by jorlow@chromium.org
  • 11 edits in trunk/Source

2011-02-14 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Fisher.

Add initial support for per-origin quotas to IndexedDB
​https://bugs.webkit.org/show_bug.cgi?id=54421

Add support for non-persistent per-origin quotas. If one is
specified, it overrides the default.

No tests as this is only exposed via the Chromium webkit API.

  • storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::open): (WebCore::IDBFactoryBackendImpl::setQuota):
  • storage/IDBFactoryBackendImpl.h:
  • storage/IDBFactoryBackendInterface.h:

2011-02-14 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Fisher.

Add initial support for per-origin quotas to IndexedDB
​https://bugs.webkit.org/show_bug.cgi?id=54421

  • public/WebIDBFactory.h: (WebKit::WebIDBFactory::setQuota):
  • src/AssertMatchingEnums.cpp:
  • src/IDBFactoryBackendProxy.cpp: (WebCore::IDBFactoryBackendProxy::setQuota):
  • src/IDBFactoryBackendProxy.h:
  • src/WebIDBFactoryImpl.cpp: (WebKit::WebIDBFactoryImpl::setQuota):
  • src/WebIDBFactoryImpl.h:
4:36 PM Changeset in webkit [78644] by abarth@webkit.org
  • 3 edits
    3 adds in trunk

2011-02-15 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

XSLT with output method HTML and images crashes in debug mode
​https://bugs.webkit.org/show_bug.cgi?id=54462

​http://trac.webkit.org/changeset/75577 created Document::setContent but
didn't notice that the code paths combined into Document::setContent
were subtly different. In particular, some of the code paths called
parser->finish() whereas other did not.

The difference is that an explicit call to parser->finish() is required
in the case where there is no frame because explicitClose doesn't call
endIfNotLoadingMainResource if there is no frame. This patch moves
that logic inside explicitClose, which is more natural.

This patch also removes removeAllChildren, which has not effect in this
situation and should never have been added in the first place.

Test: fast/parser/xslt-with-html.xml

  • dom/Document.cpp: (WebCore::Document::setContent): (WebCore::Document::explicitClose):

2011-02-15 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

XSLT with output method HTML and images crashes in debug mode
​https://bugs.webkit.org/show_bug.cgi?id=54462

Test that we don't try to prepare to stop twice when pasing HTML
generated from an XSLT.

  • fast/parser/resources/xslt-with-html.xsl: Added.
  • fast/parser/xslt-with-html-expected.txt: Added.
  • fast/parser/xslt-with-html.xml: Added.
4:36 PM Changeset in webkit [78643] by kbr@google.com
  • 2 edits in trunk/Source/WebKit/win

2011-02-15 Kenneth Russell <​kbr@google.com>

Unreviewed. Remove whitespace-only change from
​http://trac.webkit.org/changeset/78620 (​https://bugs.webkit.org/show_bug.cgi?id=54312)
now that the patch has passed the Windows build bots.

  • Interfaces/WebKit.idl:
4:32 PM Changeset in webkit [78642] by Martin Robinson
  • 6 edits in trunk/LayoutTests

2011-02-15 Martin Robinson <​mrobinson@igalia.com>

Rebaseline some GTK+ tests which have different results on the bots.
Skip a test which appears to be timing out intermittently.

  • platform/gtk/Skipped: Skip a test which has been timing out.
  • platform/gtk/svg/custom/use-nested-transform-expected.txt:
  • platform/gtk/svg/hixie/perf/001-expected.txt:
  • platform/gtk/svg/hixie/perf/002-expected.txt:
  • platform/gtk/svg/hixie/perf/007-expected.txt:
4:23 PM Changeset in webkit [78641] by Darin Adler
  • 27 edits in trunk/LayoutTests

Autocorrection should respect undo.
​https://bugs.webkit.org/show_bug.cgi?id=52221
<rdar://problem/8663399>

Patch by Jia Pu <​jpu@apple.com> on 2011-02-15
Reviewed by Darin Adler.

Rebaselined tests affected by code change.

  • platform/mac/editing/spelling/autocorrection-contraction-expected.txt:
  • platform/mac/editing/spelling/autocorrection-delete-expected.txt:
  • platform/mac/editing/spelling/autocorrection-removing-underline-after-paste-expected.txt:
  • platform/mac/editing/spelling/autocorrection-removing-underline-expected.txt:
  • platform/mac/editing/spelling/autocorrection-simple-expected.txt:
  • platform/mac/editing/spelling/delete-autocorrected-word-1-expected.txt:
4:18 PM Changeset in webkit [78640] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix Qt build.

  • WebKit2.pro:
4:11 PM Changeset in webkit [78639] by oliver@apple.com
  • 2 edits in trunk/Source/WebCore

2011-02-15 Oliver Hunt <​oliver@apple.com>

Fix EFL build for
​https://bugs.webkit.org/show_bug.cgi?id=54415

  • CMakeLists.txt:
4:10 PM Changeset in webkit [78638] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix Windows build.

  • win/WebKit2.vcproj:
4:04 PM Changeset in webkit [78637] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-15 Oliver Hunt <​oliver@apple.com>

Fix EFL build for
​https://bugs.webkit.org/show_bug.cgi?id=54415

  • CMakeLists.txt:
3:59 PM Changeset in webkit [78636] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

<​http://webkit.org/b/54487> Minor header clean up in RenderLayerBacking.cpp

Reviewed by Darin Adler.

  • rendering/RenderLayerBacking.cpp: Remove unused

WebGLRenderingContext.h header, and move GraphicsContext3D.h

into a #if ENABLE(WEBGL)
ENABLE(ACCELERATED_2D_CANVAS)/#endif

block.

3:55 PM Changeset in webkit [78635] by pkasting@chromium.org
  • 2 edits
    2 deletes in trunk/LayoutTests

Unreviewed, Chromium test expectations update.

​https://bugs.webkit.org/show_bug.cgi?id=40147
​https://bugs.webkit.org/show_bug.cgi?id=48029
​https://bugs.webkit.org/show_bug.cgi?id=53740
​https://bugs.webkit.org/show_bug.cgi?id=54387
​https://bugs.webkit.org/show_bug.cgi?id=54418
​https://bugs.webkit.org/show_bug.cgi?id=54499
Remove a couple erroneously-added baselines, unmark some now-passing
tests, bug numbers, etc.

  • platform/chromium-linux/http/tests/xmlhttprequest: Removed.
  • platform/chromium-linux/http/tests/xmlhttprequest/cache-override-expected.txt: Removed.
  • platform/chromium-win/fast/gradients/css3-repeating-end-fill-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
3:54 PM Changeset in webkit [78634] by oliver@apple.com
  • 89 edits
    15 adds
    2 deletes in trunk/Source

2011-02-14 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough and Geoff Garen.

Refactor handles and weak pointers to become nicer and more automatic
​https://bugs.webkit.org/show_bug.cgi?id=54415

Move to a true handle based mechanism for GC value protection. This
also allows us to switch to a more sensible behaviour for weak pointers
in which weak pointers are automatically updated.

This allows us to remove the old (and convoluted) that required all
objects that may be held by a weak reference to be aware of the reference
and manually clear them in their destructors.

This also adds a few new data types to JSC that we use to efficiently
allocate and return the underlying handle storage.

This patch is largely renaming and removing now unnecessary destructors
from objects.

New Global handle type used to keep gc objects live, even if they're not
marked.

(JSC::Global::Global):
(JSC::Global::~Global):
(JSC::Global::set):

We can only assign directly to a global from another global.
In all other cases we need the JSGlobalData to be provided
explicitly so we use a set function.

(JSC::Global::operator=):
(JSC::Global::clear):
(JSC::Global::isHashTableDeletedValue):
(JSC::Global::internalSet):

  • collector/handles/Handle.h: Added.

Root "Handle" type used for immutable handles and to provide the basic
APIs needed for pointer-like behaviour.

(JSC::HandleBase::operator!):
(JSC::HandleBase::operator UnspecifiedBoolType*):
(JSC::HandleBase::isEmpty):
(JSC::HandleBase::HandleBase):
(JSC::HandleBase::slot):
(JSC::HandleBase::invalidate):
(JSC::HandleBase::setSlot):
(JSC::HandleTypes::getFromSlot):
(JSC::HandleTypes::toJSValue):
(JSC::HandleTypes::validateUpcast):
(JSC::HandleConverter::operator->):
(JSC::HandleConverter::operator*):
(JSC::Handle::Handle):
(JSC::Handle::get):
(JSC::Handle::wrapSlot):
(JSC::operator==):
(JSC::operator!=):

  • collector/handles/HandleHeap.cpp: Added.

New heap for global handles.

(JSC::HandleHeap::HandleHeap):
(JSC::HandleHeap::grow):
(JSC::HandleHeap::markStrongHandles):
(JSC::HandleHeap::updateAfterMark):
(JSC::HandleHeap::clearWeakPointers):
(JSC::HandleHeap::writeBarrier):

  • collector/handles/HandleHeap.h: Added. (JSC::HandleHeap::heapFor): (JSC::HandleHeap::toHandle): (JSC::HandleHeap::toNode): (JSC::HandleHeap::allocate): (JSC::HandleHeap::deallocate): (JSC::HandleHeap::makeWeak):

Convert a hard handle into weak handle that does not
protect the object it points to.

(JSC::HandleHeap::makeSelfDestroying):

Converts a handle to a weak handle that will be returned
to the free list when the referenced object dies.

(JSC::HandleHeap::Node::Node):
(JSC::HandleHeap::Node::slot):
(JSC::HandleHeap::Node::handleHeap):
(JSC::HandleHeap::Node::setFinalizer):
(JSC::HandleHeap::Node::makeWeak):
(JSC::HandleHeap::Node::isWeak):
(JSC::HandleHeap::Node::makeSelfDestroying):
(JSC::HandleHeap::Node::isSelfDestroying):
(JSC::HandleHeap::Node::finalizer):
(JSC::HandleHeap::Node::setPrev):
(JSC::HandleHeap::Node::prev):
(JSC::HandleHeap::Node::setNext):
(JSC::HandleHeap::Node::next):

  • interpreter/Interpreter.cpp: (JSC::Interpreter::Interpreter):
  • interpreter/Interpreter.h:
  • interpreter/RegisterFile.cpp: (JSC::RegisterFile::globalObjectCollected):
  • interpreter/RegisterFile.h: (JSC::RegisterFile::RegisterFile):
  • runtime/GCHandle.cpp: Removed.
  • runtime/GCHandle.h: Removed.
  • runtime/Heap.cpp: (JSC::Heap::Heap): (JSC::Heap::destroy): (JSC::Heap::markRoots):
  • runtime/Heap.h: (JSC::Heap::allocateGlobalHandle): (JSC::Heap::reportExtraMemoryCost):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
  • runtime/JSGlobalData.h: (JSC::JSGlobalData::allocateGlobalHandle):
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::~JSGlobalObject):
  • runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::create): (JSC::JSPropertyNameIterator::~JSPropertyNameIterator):
  • runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::createStructure): (JSC::Structure::setEnumerationCache): (JSC::Structure::clearEnumerationCache):
  • runtime/Protect.h:
  • runtime/Structure.cpp: (JSC::Structure::~Structure):
  • runtime/Structure.h:
  • runtime/WeakGCPtr.h: (JSC::WeakGCPtrBase::get): (JSC::WeakGCPtrBase::clear): (JSC::WeakGCPtrBase::operator!): (JSC::WeakGCPtrBase::operator UnspecifiedBoolType*): (JSC::WeakGCPtrBase::~WeakGCPtrBase): (JSC::WeakGCPtrBase::WeakGCPtrBase): (JSC::WeakGCPtrBase::internalSet): (JSC::LazyWeakGCPtr::LazyWeakGCPtr): (JSC::LazyWeakGCPtr::set): (JSC::WeakGCPtr::WeakGCPtr): (JSC::WeakGCPtr::operator=):
  • runtime/WriteBarrier.h:
  • wtf/BlockStack.h: Added. (WTF::::BlockStack): (WTF::::~BlockStack): (WTF::::blocks): (WTF::::grow): (WTF::::shrink):
  • wtf/SentinelLinkedList.h: Added. (WTF::::SentinelLinkedList): (WTF::::begin): (WTF::::end): (WTF::::push): (WTF::::remove):
  • wtf/SinglyLinkedList.h: Added. (WTF::::SinglyLinkedList): (WTF::::isEmpty): (WTF::::push): (WTF::::pop):

2011-02-14 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough and Geoff Garen.

Refactor handles and weak pointers to become nicer and more automatic
​https://bugs.webkit.org/show_bug.cgi?id=54415

Update to use new Global<> type

  • JSRun.cpp: (JSRun::JSRun): (JSRun::GlobalObject):
  • JSRun.h:
  • JSValueWrapper.cpp: (JSValueWrapper::JSValueWrapper):
  • JSValueWrapper.h:

2011-02-14 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough and Geoff Garen.

Refactor handles and weak pointers to become nicer and more automatic
​https://bugs.webkit.org/show_bug.cgi?id=54415

Update WebCore to use the new Global<> type rather than ProtectedJSValue
and gc[Un]Protect. Also update to use new WeakGCPtr APIs, and remove now
unnecessary destructors.

  • ForwardingHeaders/collector/handles/Global.h: Added.
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/copyForwardingHeaders.cmd:
  • bindings/js/JSCallbackData.h: (WebCore::JSCallbackData::JSCallbackData):
  • bindings/js/JSCustomVoidCallback.h:
  • bindings/js/JSDOMBinding.cpp: (WebCore::forgetDOMNode): (WebCore::cacheDOMNodeWrapper):
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::setWindow):
  • bindings/js/JSDataGridDataSource.h:
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::JSEventListener):
  • bindings/js/JSEventListener.h: (WebCore::JSEventListener::setWrapper):
  • bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::initializeJSFunction):
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::ScheduledAction): (WebCore::ScheduledAction::executeFunctionInContext):
  • bindings/js/ScheduledAction.h: (WebCore::ScheduledAction::ScheduledAction):
  • bindings/js/ScriptCachedFrameData.cpp: (WebCore::ScriptCachedFrameData::ScriptCachedFrameData): (WebCore::ScriptCachedFrameData::restore):
  • bindings/js/ScriptCachedFrameData.h:
  • bindings/js/ScriptCallStackFactory.cpp: (WebCore::createScriptArguments):
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::createWindowShell): (WebCore::ScriptController::evaluateInWorld): (WebCore::ScriptController::clearWindowShell): (WebCore::ScriptController::attachDebugger):
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::call): (WebCore::ScriptCallback::call):
  • bindings/js/ScriptObject.cpp: (WebCore::ScriptObject::ScriptObject):
  • bindings/js/ScriptObject.h:
  • bindings/js/ScriptState.cpp: (WebCore::ScriptStateProtectedPtr::ScriptStateProtectedPtr): (WebCore::ScriptStateProtectedPtr::get):
  • bindings/js/ScriptState.h:
  • bindings/js/ScriptValue.cpp: (WebCore::ScriptValue::isFunction): (WebCore::ScriptValue::deserialize):
  • bindings/js/ScriptValue.h: (WebCore::ScriptValue::ScriptValue): (WebCore::ScriptValue::hasNoValue):
  • bindings/js/ScriptWrappable.h: (WebCore::ScriptWrappable::ScriptWrappable): (WebCore::ScriptWrappable::setWrapper):
  • bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::WorkerScriptController): (WebCore::WorkerScriptController::~WorkerScriptController): (WebCore::WorkerScriptController::initScript): (WebCore::WorkerScriptController::evaluate):
  • bindings/js/WorkerScriptController.h: (WebCore::WorkerScriptController::workerContextWrapper):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/NP_jsobject.cpp: (_NPN_InvokeDefault): (_NPN_Invoke): (_NPN_Evaluate): (_NPN_Construct):
  • bridge/jsc/BridgeJSC.cpp: (JSC::Bindings::Instance::Instance): (JSC::Bindings::Instance::~Instance): (JSC::Bindings::Instance::willDestroyRuntimeObject): (JSC::Bindings::Instance::willInvalidateRuntimeObject):
  • bridge/jsc/BridgeJSC.h:
  • bridge/runtime_object.cpp: (JSC::Bindings::RuntimeObject::invalidate):
  • bridge/runtime_root.cpp: (JSC::Bindings::RootObject::RootObject): (JSC::Bindings::RootObject::invalidate): (JSC::Bindings::RootObject::globalObject): (JSC::Bindings::RootObject::updateGlobalObject):
  • bridge/runtime_root.h:
  • dom/EventListener.h:
  • dom/EventTarget.h: (WebCore::EventTarget::markJSEventListeners):
  • xml/XMLHttpRequest.cpp:

Qt bindings courtesy of Csaba Osztrogonác

  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeConnectionMethod::call): (JSC::Bindings::QtConnectionObject::QtConnectionObject): (JSC::Bindings::QtConnectionObject::execute): (JSC::Bindings::QtConnectionObject::match):
  • bridge/qt/qt_runtime.h:

2011-02-14 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough and Geoff Garen.

Refactor handles and weak pointers to become nicer and more automatic
​https://bugs.webkit.org/show_bug.cgi?id=54415

Update to use Global<> instead of ProtectedPtr, and refactored slightly
to get global data to places it's needed for when we're assigning to
Global<>s

  • ForwardingHeaders/collector/handles/Global.h: Added.
  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get): (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject): (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget): (WebKit::NetscapePluginInstanceProxy::getWindowNPObject): (WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject): (WebKit::NetscapePluginInstanceProxy::evaluate): (WebKit::NetscapePluginInstanceProxy::invoke): (WebKit::NetscapePluginInstanceProxy::invokeDefault): (WebKit::NetscapePluginInstanceProxy::construct): (WebKit::NetscapePluginInstanceProxy::addValueToArray):
  • WebView/WebScriptDebugger.h:
  • WebView/WebScriptDebugger.mm: (WebScriptDebugger::WebScriptDebugger):

2011-02-14 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough and Geoff Garen.

Refactor handles and weak pointers to become nicer and more automatic
​https://bugs.webkit.org/show_bug.cgi?id=54415

Update code to new Global<> API, and refactor to get global data to
necessary points.

  • WebProcess/Plugins/Netscape/NPJSObject.cpp: (WebKit::NPJSObject::create): (WebKit::NPJSObject::NPJSObject): (WebKit::NPJSObject::initialize): (WebKit::NPJSObject::invokeDefault): (WebKit::NPJSObject::construct): (WebKit::NPJSObject::invoke):
  • WebProcess/Plugins/Netscape/NPJSObject.h:
  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp: (WebKit::NPRuntimeObjectMap::getOrCreateNPObject): (WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant): (WebKit::NPRuntimeObjectMap::evaluate):
  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::windowScriptNPObject): (WebKit::PluginView::pluginElementNPObject):
3:51 PM Changeset in webkit [78633] by andersca@apple.com
  • 9 edits
    2 adds in trunk/Source/WebKit2

2011-02-15 Anders Carlsson <​andersca@apple.com>

Reviewed by Jon Honeycutt.

Add stubbed out WKPluginSiteDataManagerRef API
​https://bugs.webkit.org/show_bug.cgi?id=54504

  • Shared/API/c/WKBase.h:
  • Shared/APIObject.h:
  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKContext.cpp: (WKContextGetPluginSiteDataManager):
  • UIProcess/API/C/WKContext.h:
  • UIProcess/API/C/WKPluginSiteDataManager.cpp: Added. (WKPluginSiteDataManagerGetTypeID): (WKPluginSiteDataManagerGetSitesWithData): (WKPluginSiteDataManagerClearSiteData): (WKPluginSiteDataManagerClearAllSiteData):
  • UIProcess/API/C/WKPluginSiteDataManager.h: Added.
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
3:44 PM Changeset in webkit [78632] by Darin Adler
  • 26 edits
    5 adds in trunk/Source

2011-02-15 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

Autocorrection should respect undo.
​https://bugs.webkit.org/show_bug.cgi?id=52221
<rdar://problem/8663399>

Please see WebCore/ChangeLog for detailed description.

  • WebCoreSupport/WebEditorClient.cpp: (WebFrameImpl::replaceSelection): Adopted new signature of ReplaceSelectionCommand::create().

2011-02-15 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

Autocorrection should respect undo.
​https://bugs.webkit.org/show_bug.cgi?id=52221
<rdar://problem/8663399>

Please see WebCore/ChangeLog for detailed description.

  • WebCoreSupport/WebEditorClient.h: Updated for the new function declared in EditorClient.
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::recordAutocorrectionResponse): Ditto.
  • WebView/WebFrame.mm: (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):

Adopted new signature of ReplaceSelectionCommand::create().

2011-02-15 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

Autocorrection should respect undo.
​https://bugs.webkit.org/show_bug.cgi?id=52221
<rdar://problem/8663399>

Manual test: manual-tests/autocorrection/undo-autocorrection.html

When user undoes an autocorrection, we need to do four things:

  1. Revert the change in text that has been made by correction.
  2. Revert the selection to pre-correction state so that user can immediately continue typing.
  3. Add appropriate markers to reverted text so that it won't be corrected again and/or shown as misspelled.
  4. If applicable, notify spell checking service to record this reversion.

To achieve these, this patch introduces following changes:

  1. Created SpellingCorrectionCommand so that correction can be undone in similar way as any other editing command. SpellingCorrectionCommand is a composition of SetSelectionCommand, SpellingCorrectionRecordUndoCommand and ReplaceSelectionCommand.
  2. Created SetSelectionCommand so that undo command can restore selection state.
  3. Added member function recordAutocorrectionResponse() to editor client.

To improve readability, this patch also consolidates various boolean arguments in SelectionController::setSelection()
and ReplaceSelectionCommand::ReplaceSelectionCommand(). These boolean arguments have been
replaced by enum variable.

  • WebCore.exp.in: Updated for changes in Editor and ReplaceSelectionCommand.
  • WebCore.xcodeproj/project.pbxproj: Updated for new source files.
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Adopted new signature of ReplaceSelectionCommand::create().
  • editing/Editor.cpp: (WebCore::Editor::replaceSelectionWithFragment): Ditto. (WebCore::Editor::unappliedEditing): Cleaned up trailing whitespace. (WebCore::Editor::reappliedEditing): Ditto. (WebCore::Editor::selectComposition): Adopted new signature of SelectionController::setSelection(). (WebCore::Editor::confirmComposition): Ditto. (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Rearranged code to reduce the

level of deeply nested if statement. Adopted SpellingCorrectionCommand.

(WebCore::Editor::applyCorrectionPanelInfo): Adopted SpellingCorrectionCommand.
(WebCore::Editor::unappliedSpellCorrection): Function for adding markers to reverted text and

for notifiying editor client about undone correction.

(WebCore::Editor::changeSelectionAfterCommand): Adopted new signature of SelectionController::setSelection().
(WebCore::Editor::respondToChangedSelection): Use SelectionController::SetSelectionOptions

instead of boolean variables.

  • editing/Editor.h: Added Editor::unappliedSpellCorrection().
  • editing/EditorCommand.cpp: (WebCore::executeInsertFragment): Adopted new signature of ReplaceSelectionCommand::create().
  • editing/MoveSelectionCommand.cpp: (WebCore::MoveSelectionCommand::doApply): Ditto.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): Replaced all boolean arguments

with an enum value.

  • editing/ReplaceSelectionCommand.h: (WebCore::ReplaceSelectionCommand::create): Ditto.
  • editing/SelectionController.cpp: Adopted new signature of SelectionController::setSelection(). (WebCore::SelectionController::moveTo): (WebCore::SelectionController::setSelection): (WebCore::SelectionController::respondToNodeModification): (WebCore::SelectionController::setBase): (WebCore::SelectionController::setExtent): (WebCore::SelectionController::setSelectedRange):
  • editing/SelectionController.h: (WebCore::SelectionController::setSelection): Replaced all boolean arguments with an enum value.
  • editing/SetSelectionCommand.cpp: Added. (WebCore::SetSelectionCommand::SetSelectionCommand): (WebCore::SetSelectionCommand::doApply): (WebCore::SetSelectionCommand::doUnapply):
  • editing/SetSelectionCommand.h: Added. (WebCore::SetSelectionCommand::create):
  • editing/mac/SpellingCorrectionCommand.cpp: Added. (WebCore::SpellingCorrectionRecordUndoCommand::create): (WebCore::SpellingCorrectionRecordUndoCommand::SpellingCorrectionRecordUndoCommand): (WebCore::SpellingCorrectionRecordUndoCommand::doApply): (WebCore::SpellingCorrectionRecordUndoCommand::doUnapply): (WebCore::SpellingCorrectionCommand::SpellingCorrectionCommand): (WebCore::SpellingCorrectionCommand::doApply):
  • editing/mac/SpellingCorrectionCommand.h: Added. (WebCore::SpellingCorrectionCommand::create):
  • loader/EmptyClients.h: Updated for the new function declared in EditorClient. (WebCore::EmptyEditorClient::recordAutocorrectionResponse):
  • manual-tests/autocorrection/undo-autocorrection.html: Added.
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Adopted new signature of ReplaceSelectionCommand::create().
  • page/DragController.cpp: (WebCore::DragController::concludeEditDrag): Ditto.
  • page/EditorClient.h: Added EditorClient::recordAutocorrectionResponse().

2011-02-15 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

Autocorrection should respect undo.
​https://bugs.webkit.org/show_bug.cgi?id=52221
<rdar://problem/8663399>

Please see WebCore/ChangeLog for detailed description.

  • WebProcess/WebCoreSupport/WebEditorClient.h: Updated for the new function declared in EditorClient.
  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: (WebKit::WebEditorClient::recordAutocorrectionResponse): Ditto.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::replaceSelectionWithText): Adopted new signature of ReplaceSelectionCommand::create().
3:41 PM Changeset in webkit [78631] by sfalken@apple.com
  • 2 edits in trunk/LayoutTests

Add media/audio-delete-while-slider-thumb-clicked.html to Windows skipped list.
Failing since r78562.

  • platform/win/Skipped:
3:39 PM Changeset in webkit [78630] by Beth Dakin
  • 4 edits in trunk/Source/WebCore

Speculative fix for <rdar://problem/8998498> CrashTracer: [USER]
8 crashes in WebProcess calling setOverlayScrollerState:forceImmediately:

Reviewed by Darin Adler.

My best guess is that this is crashing because
willRemoveVerticalScrollbar()/Horizontal was not being called
properly from the RenderLayer destructor.

Call willRemoveVerticalScrollbar()/Horizontal from destroyScrollbar()
so that all current and future scrollbar-destroyers will properly
call this function. And only do it for native scrollers.
(WebCore::RenderLayer::destroyScrollbar):
(WebCore::RenderListBox::destroyScrollbar):

For consistency's sake, I also moved didAddVerticalScrollbar()
/Horizontal to createScrollbar(). Again, only call for native
scrollers.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::createScrollbar):
(WebCore::RenderListBox::createScrollbar):

These functions no longer call didAdd/willRemove.
(WebCore::RenderLayer::setHasHorizontalScrollbar):
(WebCore::RenderLayer::setHasVerticalScrollbar):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::setHasVerticalScrollbar):

Remove unnecessary ScrollableArea::-prefix

  • platform/ScrollView.cpp:

(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):

3:38 PM Changeset in webkit [78629] by senorblanco@chromium.org
  • 6 edits in trunk/LayoutTests

2011-02-15 Stephen White <​senorblanco@chromium.org>

Unreviewed; new baselines for canvas GPU tests.

Rebaseline for slight pixel differences on windows.

  • platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.checksum:
  • platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-gpu-win/fast/canvas/image-object-in-canvas-expected.checksum:
  • platform/chromium-gpu-win/fast/canvas/image-object-in-canvas-expected.png:
  • platform/chromium/test_expectations.txt:
3:31 PM Changeset in webkit [78628] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-15 Mihai Parparita <​mihaip@chromium.org>

Unreviewed chromium-gpu expectations update. Update expectations after
tests that were unskipped by r78619 started to be run again. Most of
them don't time out anymore, instead they have image and/or text diffs.

Also remove flaky expectations for fast/canvas/shadow-offset-*.html,
since they pass consistently now that the bug on the Chromium/V8 side
(​http://crbug.com/67732) has been fixed.

  • platform/chromium/test_expectations.txt:
3:25 PM Changeset in webkit [78627] by ddkilzer@apple.com
  • 4 edits in trunk/Source/WebKit/mac

<​http://webkit.org/b/54485> Fix spelling of -inProgramaticScroll

Reviewed by Darin Adler.

  • WebView/WebDynamicScrollBarsView.h:
  • WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView inProgrammaticScroll]): Renamed from
-inProgramaticScroll.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _frameOrBoundsChanged]): Corrected method name.

3:20 PM Changeset in webkit [78626] by Joseph Pecoraro
  • 3 edits in trunk/Source/WebCore

2011-02-15 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by David Kilzer.

Cleanup Some Potential ENABLE(INSPECTOR) Related Building Issues
​https://bugs.webkit.org/show_bug.cgi?id=54048

  • WebCore.exp.in: moved inspector only export into ENABLE(INSPECTOR) block.
  • bindings/js/ScriptHeapSnapshot.h: include no longer needed.
3:17 PM Changeset in webkit [78625] by senorblanco@chromium.org
  • 6 edits in trunk

2011-02-15 Stephen White <​senorblanco@chromium.org>

Reviewed by James Robinson.


[chromium] clearRect() is incorrect in accelerated 2D canvas.
​https://bugs.webkit.org/show_bug.cgi?id=54497

When doing GPU-Canvas2D clearRect() using the fast path (glClear()),
we were not correctly converting from canvas to screen coordinates.
Fixed by inverting the rectangle in Y, and changing
SharedGraphicsContext3D::scissor to take glScissor-like parameters.

Covered by fast/canvas/canvas-strokeRect.html.

  • platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::clearRect): Flip the Y coord of the rectangle passed to scissor().
  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::scissor):
  • platform/graphics/gpu/SharedGraphicsContext3D.h: Give scissor() the same param types as GraphicsContext3D::scissor().

2011-02-15 Stephen White <​senorblanco@chromium.org>

Reviewed by James Robinson.

[chromium] Mark fast/canvas/canvas-strokeRect.html as passing on the GPU path.
​https://bugs.webkit.org/show_bug.cgi?id=54497

  • platform/chromium/test_expectations.txt:
3:16 PM Changeset in webkit [78624] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebKit2

WebKit2: Use the Database directory location specified in NSUserDefaults.
​https://bugs.webkit.org/show_bug.cgi?id=54496

Reviewed by Darin Adler.

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformDefaultDatabaseDirectory):
Use the same logic as WebKit1's WebDatabaseManager::databasesDirectoryPath.

3:01 PM Changeset in webkit [78623] by Simon Fraser
  • 3 edits in trunk/Source/WebKit2

2011-02-15 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson, Darin Adler.

Layers stick around in DrawingAreaImpl until we switch out of compositing
​https://bugs.webkit.org/show_bug.cgi?id=54498

When leaving compositing mode soon, remove all the child layers
of the nonCompositedContent layer right away, so they don't stick
around.

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setRootCompositingLayer):
  • WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::setRootCompositingLayer):
3:01 PM Changeset in webkit [78622] by psolanki@apple.com
  • 4 edits in trunk/Source

2011-02-15 Pratik Solanki <​psolanki@apple.com>

Move WTF_USE_CFNETWORK to Platform.h
​https://bugs.webkit.org/show_bug.cgi?id=54168

Reviewed by Darin Adler.

  • wtf/Platform.h: Define WTF_USE_CFNETWORK for Windows builds.

2011-02-15 Pratik Solanki <​psolanki@apple.com>

Move WTF_USE_CFNETWORK to Platform.h
​https://bugs.webkit.org/show_bug.cgi?id=54168

Reviewed by Darin Adler.

  • config.h: Remove WTF_USE_CFNETWORK.
2:55 PM Changeset in webkit [78621] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-15 Mihai Parparita <​mihaip@chromium.org>

Unreviewed chromium-gpu expectations update.
compositing/reflections/animation-inside-reflection.html and
compositing/reflections/nested-reflection-animated.html are flaky on
Linux too.

  • platform/chromium/test_expectations.txt:
2:53 PM Changeset in webkit [78620] by kbr@google.com
  • 50 edits
    8 adds in trunk

2011-02-15 Kenneth Russell <​kbr@google.com>

Reviewed by Darin Fisher.

Allow controlling minimum DOMTimer interval on a per-page basis
​https://bugs.webkit.org/show_bug.cgi?id=54312

Implemented new method setMinimumTimerInterval in
LayoutTestController for all ports.

  • DumpRenderTree/LayoutTestController.cpp: (setMinimumTimerIntervalCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setMinimumTimerInterval):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::reset):
  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setMinimumTimerInterval):
  • DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setMinimumTimerInterval):
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::resetSettings):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setMinimumTimerInterval):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setMinimumTimerInterval):

2011-02-15 Kenneth Russell <​kbr@google.com>

Reviewed by Darin Fisher.

Allow controlling minimum DOMTimer interval on a per-page basis
​https://bugs.webkit.org/show_bug.cgi?id=54312

  • fast/dom/timer-increase-min-interval-and-reset-part-1-expected.txt: Added.
  • fast/dom/timer-increase-min-interval-and-reset-part-1.html: Added.
  • fast/dom/timer-increase-min-interval-and-reset-part-2-expected.txt: Added.
  • fast/dom/timer-increase-min-interval-and-reset-part-2.html: Added.
    • Chained tests (the assumption is that the run-webkit-tests harness will run them sequentially, which is a reasonably good assumption) which verify that the minimum timer interval is reset between tests.
  • fast/dom/timer-increase-min-interval-expected.txt: Added.
  • fast/dom/timer-increase-min-interval.html: Added.
    • Verifies that increasing the minimum timer interval causes fast timers to run slowly.
  • fast/dom/timer-increase-then-decrease-min-interval-expected.txt: Added.
  • fast/dom/timer-increase-then-decrease-min-interval.html: Added.
    • Verifies that decreasing the minimum timer interval causes previously slowed-down timers to be reevaluated immediately.

2011-02-15 Kenneth Russell <​kbr@google.com>

Reviewed by Darin Fisher.

Allow controlling minimum DOMTimer interval on a per-page basis
​https://bugs.webkit.org/show_bug.cgi?id=54312

  • public/WebSettings.h:
    • Added setMinimumTimerInterval.
  • src/WebKit.cpp: (WebKit::initialize):
    • Added FIXME to remove setting of page's default timer interval.
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setMinimumTimerInterval):
    • Implemented new method on WebSettings.
  • src/WebSettingsImpl.h:

2011-02-15 Kenneth Russell <​kbr@google.com>

Reviewed by Darin Fisher.

Allow controlling minimum DOMTimer interval on a per-page basis
​https://bugs.webkit.org/show_bug.cgi?id=54312

Added needed methods to implement LayoutTestController's new
setMinimumTimerInterval method.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::defaultMinimumTimerInterval): (DumpRenderTreeSupportQt::setMinimumTimerInterval):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-02-15 Kenneth Russell <​kbr@google.com>

Reviewed by Darin Fisher.

Allow controlling minimum DOMTimer interval on a per-page basis
​https://bugs.webkit.org/show_bug.cgi?id=54312

Added needed methods to implement LayoutTestController's new
setMinimumTimerInterval method.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::defaultMinimumTimerInterval): (DumpRenderTreeSupportGtk::setMinimumTimerInterval):
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

2011-02-15 Kenneth Russell <​kbr@google.com>

Reviewed by Darin Fisher.

Allow controlling minimum DOMTimer interval on a per-page basis
​https://bugs.webkit.org/show_bug.cgi?id=54312

Added needed methods to implement LayoutTestController's new
setMinimumTimerInterval method. Includes whitespace-only change to
WebKit.idl to trigger proper rebuild on bots; will be removed in
subsequent checkin.

  • Interfaces/IWebViewPrivate.idl:
  • Interfaces/WebKit.idl:
  • WebView.cpp: (WebView::initWithFrame): (WebView::defaultMinimumTimerInterval): (WebView::setMinimumTimerInterval):
  • WebView.h:

2011-02-15 Kenneth Russell <​kbr@google.com>

Reviewed by Darin Fisher.

Allow controlling minimum DOMTimer interval on a per-page basis
​https://bugs.webkit.org/show_bug.cgi?id=54312

Added needed methods to implement LayoutTestController's new
setMinimumTimerInterval method.

  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): (+[WebView _defaultMinimumTimerInterval]): (-[WebView _setMinimumTimerInterval:]):
  • WebView/WebViewPrivate.h:

2011-02-15 Kenneth Russell <​kbr@google.com>

Reviewed by Darin Fisher.

Allow controlling minimum DOMTimer interval on a per-page basis
​https://bugs.webkit.org/show_bug.cgi?id=54312

Renamed DOMTimer::minTimerInterval and setMinTimerInterval to
defaultMinTimerInterval and setDefaultMinTimerInterval, made them
private and exposed them via Settings::defaultMinDOMTimerInterval
and setDefaultMinDOMTimerInterval. Added new
Settings::setMinDOMTimerInterval and minDOMTimerInterval.

The storage for the minimum timer interval currently lives in the
Page, though this could be moved to the Settings object if
desired. The accessor methods on the Page are private and exposed
to Settings by making Settings a friend, so the abstraction
barrier is clear at the API level.

Adjusting the interval both upward and downward may cause the fire
times of the active timers on the page to be adjusted, if they
would be affected by the clamping value. This is needed to reduce
latency when bringing a tab to the foreground, in particular if
the minimum timer interval was decreased from a very high value to
a very low value.

A new method, setMinimumTimerInterval, has been added to
LayoutTestController, implemented in all ports of DumpRenderTree,
and used in new layout tests.

Ideally changing the page's minimum timer interval would affect
dedicated workers, but this is too much to do in an initial patch,
so a FIXME has been added.

Tested with:

  • The new layout tests on the WebKit Mac and Chromium (Mac, Linux) DRT ports.
  • Hooked up the new API in Chromium and ran some simple manual tests.

Tests: fast/dom/timer-increase-min-interval-and-reset-part-1.html

fast/dom/timer-increase-min-interval-and-reset-part-2.html
fast/dom/timer-increase-min-interval.html
fast/dom/timer-increase-then-decrease-min-interval.html

  • WebCore.exp.in:
  • dom/Document.cpp: (WebCore::Document::minimumTimerInterval):
  • dom/Document.h:
  • dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::adjustMinimumTimerInterval): (WebCore::ScriptExecutionContext::minimumTimerInterval):
  • dom/ScriptExecutionContext.h:
  • page/DOMTimer.cpp: (WebCore::DOMTimer::DOMTimer): (WebCore::DOMTimer::fired): (WebCore::DOMTimer::adjustMinimumTimerInterval): (WebCore::DOMTimer::intervalClampedToMinimum):
  • page/DOMTimer.h: (WebCore::DOMTimer::defaultMinTimerInterval): (WebCore::DOMTimer::setDefaultMinTimerInterval):
  • page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::setMinimumTimerInterval): (WebCore::Page::minimumTimerInterval):
  • page/Page.h:
  • page/Settings.cpp: (WebCore::Settings::setDefaultMinDOMTimerInterval): (WebCore::Settings::defaultMinDOMTimerInterval): (WebCore::Settings::setMinDOMTimerInterval): (WebCore::Settings::minDOMTimerInterval):
  • page/Settings.h:
  • platform/Timer.h: (WebCore::TimerBase::augmentFireInterval): (WebCore::TimerBase::augmentRepeatInterval):

2011-02-15 Kenneth Russell <​kbr@google.com>

Reviewed by Darin Fisher.

Allow controlling minimum DOMTimer interval on a per-page basis
​https://bugs.webkit.org/show_bug.cgi?id=54312

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage):
2:49 PM Changeset in webkit [78619] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-15 Mihai Parparita <​mihaip@chromium.org>

Unreviewed chromium-gpu baseline update. Unskip some tests that fail;
we want to keep running them in case they regress in unexpected ways
(e.g. they start to crash).

  • platform/chromium/test_expectations.txt:
2:46 PM Changeset in webkit [78618] by Simon Fraser
  • 7 edits in trunk/Source/WebCore

2011-02-15 Simon Fraser <Simon Fraser>

Reviewed by Beth Dakin.

Fix scrollbar rendering crash when rendered into a layer
​https://bugs.webkit.org/show_bug.cgi?id=54494

Remove code added in r78394 which was intended to find out whether
a scrollbar was being rendered into a compositing layer. r78612
obviated the need for this code.

  • page/FrameView.h:
  • platform/ScrollableArea.h:
  • rendering/RenderLayer.cpp:
  • rendering/RenderLayer.h:
  • rendering/RenderListBox.cpp:
  • rendering/RenderListBox.h:
2:37 PM Changeset in webkit [78617] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

2011-02-15 Simon Fraser <Simon Fraser>

Let Xcode have its way with the project.

  • WebCore.xcodeproj/project.pbxproj:
2:37 PM Changeset in webkit [78616] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

2011-02-15 Simon Fraser <Simon Fraser>

Fix Mac builds that don't use rubber-band scrolling
by moving m_drawingIntoLayer out of the #ifdef.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm: (WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
2:30 PM Changeset in webkit [78615] by tonyg@chromium.org
  • 5 edits in branches/chromium/648/Source/WebCore

Merge 78548 - 2011-02-15 Gavin Peters <​gavinp@chromium.org>

Reviewed by Antti Koivisto.

SharedBuffer::buffer() does not do what you think.
​https://bugs.webkit.org/show_bug.cgi?id=54420

No new tests.

  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::resourceContentBase64):
  • platform/SharedBuffer.h:
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::decode): (WebCore::JPEGImageDecoder::decode):
  • platform/image-decoders/webp/WEBPImageDecoder.cpp: (WebCore::WEBPImageDecoder::decode):

TBR=​commit-queue@webkit.org
Review URL: ​http://codereview.chromium.org/6526023

2:16 PM Changeset in webkit [78614] by Martin Robinson
  • 50 edits in trunk

2011-02-15 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Freetype] Better map CSS font weight to Fontconfig font weight
​https://bugs.webkit.org/show_bug.cgi?id=54323

Update the results of this test, which is now passing. Also update results for
all other tests which have different results now.

  • platform/gtk/fast/css/font-weight-1-expected.checksum:
  • platform/gtk/fast/css/font-weight-1-expected.png:
  • platform/gtk/fast/css/font-weight-1-expected.txt:

2011-02-15 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Freetype] Better map CSS font weight to Fontconfig font weight
​https://bugs.webkit.org/show_bug.cgi?id=54323

  • platform/graphics/freetype/FontCacheFreeType.cpp: (WebCore::fontWeightToFontconfigWeight): Added this helper to map between CSS and Fontconfig font weights. (WebCore::FontCache::createFontPlatformData): Use the new helper instead of just deciding between bold and regular.

2011-02-15 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Freetype] Better map CSS font weight to Fontconfig font weight
​https://bugs.webkit.org/show_bug.cgi?id=54323

Add the WeightWatcher fonts to the list of sourced fonts when intializing
DRT. This will allow us to pass tests that use WeightWatcher.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (initializeFonts): Source the WebkitWeightWatcher fonts.
2:12 PM Changeset in webkit [78613] by mihaip@chromium.org
  • 18 edits
    54 adds in trunk/LayoutTests

2011-02-15 Mihai Parparita <​mihaip@chromium.org>

Unreviewed chromium-gpu-linux rebaseline. Check in correct expectations
which should allow us to remove the PASS FAIL line for compositing/ for
this platform.

  • platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.checksum:
  • platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
  • platform/chromium-gpu-linux/compositing/generated-content-expected.checksum:
  • platform/chromium-gpu-linux/compositing/generated-content-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/composited-html-size-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/geometry/composited-html-size-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/geometry/fixed-position-expected.checksum:
  • platform/chromium-gpu-linux/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.checksum:
  • platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/layer-due-to-layer-children-deep-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/geometry/layer-due-to-layer-children-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.checksum:
  • platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/overflow/fixed-position-ancestor-clip-expected.checksum:
  • platform/chromium-gpu-linux/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-gpu-linux/compositing/reflections/animation-inside-reflection-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/reflections/animation-inside-reflection-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/reflections/compositing-change-inside-reflection-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/reflections/compositing-change-inside-reflection-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/reflections/deeply-nested-reflections-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/reflections/deeply-nested-reflections-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/reflections/masked-reflection-on-composited-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/reflections/masked-reflection-on-composited-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-animated-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-animated-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-mask-change-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-mask-change-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-on-overflow-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-on-overflow-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-opacity-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-opacity-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-size-change-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-size-change-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transformed-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transformed-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transformed2-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transformed2-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transition-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transition-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/reflections/reflection-in-composited-expected.checksum:
  • platform/chromium-gpu-linux/compositing/reflections/reflection-in-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/reflections/reflection-on-composited-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/reflections/reflection-on-composited-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/reflections/reflection-ordering-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/reflections/reflection-ordering-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/reflections/reflection-positioning-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/reflections/reflection-positioning-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/reflections/reflection-positioning2-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/reflections/reflection-positioning2-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/reflections/simple-composited-reflections-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/reflections/simple-composited-reflections-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/reflections/transform-inside-reflection-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/reflections/transform-inside-reflection-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/sibling-positioning-expected.checksum:
  • platform/chromium-gpu-linux/compositing/sibling-positioning-expected.png:
  • platform/chromium-gpu-linux/compositing/transitions/scale-transition-no-start-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/transitions/scale-transition-no-start-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/webgl/webgl-reflection-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/webgl/webgl-reflection-expected.png: Added.
  • platform/chromium/test_expectations.txt:
2:00 PM Changeset in webkit [78612] by Simon Fraser
  • 8 edits in trunk/Source/WebCore

2011-02-15 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

Fix scrollbar rendering crash when rendered into a layer
​https://bugs.webkit.org/show_bug.cgi?id=54494

The scroller delegate was failing to return a layer in a case
where the scroller was still rendering into a GraphicsLayer, because
even though WebCore had switched out of compositing mode, the
DrawingAreaImpl was still rendering into its nonCompositedContent
layer. This happens when the m_exitCompositingTimer timer hasn't fired
yet.

The fix is to track whether we're drawing into a layer via the
GraphicsContext, rather than asking about compositing layers.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setIsCALayerContext): (WebCore::GraphicsContext::isCALayerContext): Getter and setter for the bit that says if we're rendering into a CALayer.
  • platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): Store a bool for whether this context targets a layer.
  • platform/graphics/mac/WebLayer.mm: (drawLayerContents): Call setIsCALayerContext(true).
  • platform/mac/ScrollAnimatorMac.h: (WebCore::ScrollAnimatorMac::setIsDrawingIntoLayer): (WebCore::ScrollAnimatorMac::isDrawingIntoLayer): New methods to get and set a flag that says when we're drawing into a layer, so that the delegate can get at this state.
  • platform/mac/ScrollAnimatorMac.mm: (-[ScrollbarPainterDelegate layer]): Use isDrawingIntoLayer() (WebCore::ScrollAnimatorMac::ScrollAnimatorMac): Init the flag.
  • platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::unregisterScrollbar): Whitespace. (WebCore::ScrollbarThemeMac::paint): Push the "isDrawingIntoLayer" state down onto ScrollAnimatorMac, getting it from the GraphicsContext.
1:35 PM Changeset in webkit [78611] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-02-15 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Add sitesWithData and clearSiteData to NetscapePluginModule
​https://bugs.webkit.org/show_bug.cgi?id=54492

  • Shared/Plugins/Netscape/NetscapePluginModule.cpp: (WebKit::NetscapePluginModule::NetscapePluginModule): (WebKit::NetscapePluginModule::pluginCreated): (WebKit::NetscapePluginModule::pluginDestroyed): (WebKit::NetscapePluginModule::sitesWithData): (WebKit::NetscapePluginModule::clearSiteData): (WebKit::NetscapePluginModule::tryGetSitesWithData): (WebKit::NetscapePluginModule::tryClearSiteData): (WebKit::NetscapePluginModule::incrementLoadCount): (WebKit::NetscapePluginModule::decrementLoadCount):
  • Shared/Plugins/Netscape/NetscapePluginModule.h:
1:33 PM Changeset in webkit [78610] by tony@chromium.org
  • 185 edits
    1 delete in trunk/LayoutTests

2011-02-15 Tony Chang <​tony@chromium.org>

Rebaseline chromium-linux tests with menulists (select drop downs).
We now match Windows w.r.t. sizes, the only difference is the
background color of the menulist (in themeChromiumLinux.css).

  • platform/chromium-linux/editing/pasteboard/4641033-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/4641033-expected.png:
  • platform/chromium-linux/editing/pasteboard/4641033-expected.txt:
  • platform/chromium-linux/editing/pasteboard/4944770-1-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/4944770-1-expected.png:
  • platform/chromium-linux/editing/pasteboard/4944770-1-expected.txt:
  • platform/chromium-linux/editing/pasteboard/4944770-2-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/4944770-2-expected.png:
  • platform/chromium-linux/editing/pasteboard/4944770-2-expected.txt:
  • platform/chromium-linux/editing/selection/caret-before-select-expected.checksum:
  • platform/chromium-linux/editing/selection/caret-before-select-expected.png:
  • platform/chromium-linux/editing/selection/caret-before-select-expected.txt:
  • platform/chromium-linux/editing/selection/replaced-boundaries-3-expected.checksum:
  • platform/chromium-linux/editing/selection/replaced-boundaries-3-expected.png:
  • platform/chromium-linux/editing/selection/replaced-boundaries-3-expected.txt:
  • platform/chromium-linux/editing/selection/select-box-expected.checksum:
  • platform/chromium-linux/editing/selection/select-box-expected.png:
  • platform/chromium-linux/editing/selection/select-box-expected.txt:
  • platform/chromium-linux/editing/selection/select-element-paragraph-boundary-expected.checksum:
  • platform/chromium-linux/editing/selection/select-element-paragraph-boundary-expected.png:
  • platform/chromium-linux/editing/selection/select-element-paragraph-boundary-expected.txt:
  • platform/chromium-linux/fast/block/float/float-avoidance-expected.checksum:
  • platform/chromium-linux/fast/block/float/float-avoidance-expected.png:
  • platform/chromium-linux/fast/block/float/float-avoidance-expected.txt:
  • platform/chromium-linux/fast/block/margin-collapse/103-expected.checksum:
  • platform/chromium-linux/fast/block/margin-collapse/103-expected.png:
  • platform/chromium-linux/fast/block/margin-collapse/103-expected.txt:
  • platform/chromium-linux/fast/forms/003-expected.checksum:
  • platform/chromium-linux/fast/forms/003-expected.png:
  • platform/chromium-linux/fast/forms/003-expected.txt:
  • platform/chromium-linux/fast/forms/004-expected.checksum:
  • platform/chromium-linux/fast/forms/004-expected.png:
  • platform/chromium-linux/fast/forms/004-expected.txt:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label01-expected.checksum:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label01-expected.png:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label01-expected.txt:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label02-expected.checksum:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label02-expected.png:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label02-expected.txt:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label03-expected.checksum:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label03-expected.png:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label03-expected.txt:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label04-expected.checksum:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label04-expected.png:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label04-expected.txt:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label06-expected.checksum:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label06-expected.png:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label06-expected.txt:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label07-expected.checksum:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label07-expected.png:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label07-expected.txt:
  • platform/chromium-linux/fast/forms/basic-selects-expected.checksum:
  • platform/chromium-linux/fast/forms/basic-selects-expected.png:
  • platform/chromium-linux/fast/forms/basic-selects-expected.txt:
  • platform/chromium-linux/fast/forms/control-clip-overflow-expected.checksum:
  • platform/chromium-linux/fast/forms/control-clip-overflow-expected.png:
  • platform/chromium-linux/fast/forms/control-clip-overflow-expected.txt:
  • platform/chromium-linux/fast/forms/control-restrict-line-height-expected.checksum:
  • platform/chromium-linux/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-linux/fast/forms/control-restrict-line-height-expected.txt:
  • platform/chromium-linux/fast/forms/disabled-select-change-index-expected.checksum:
  • platform/chromium-linux/fast/forms/disabled-select-change-index-expected.png:
  • platform/chromium-linux/fast/forms/disabled-select-change-index-expected.txt:
  • platform/chromium-linux/fast/forms/menulist-clip-expected.checksum:
  • platform/chromium-linux/fast/forms/menulist-clip-expected.png:
  • platform/chromium-linux/fast/forms/menulist-clip-expected.txt:
  • platform/chromium-linux/fast/forms/menulist-deselect-update-expected.checksum:
  • platform/chromium-linux/fast/forms/menulist-deselect-update-expected.png:
  • platform/chromium-linux/fast/forms/menulist-deselect-update-expected.txt:
  • platform/chromium-linux/fast/forms/menulist-narrow-width-expected.checksum:
  • platform/chromium-linux/fast/forms/menulist-narrow-width-expected.png:
  • platform/chromium-linux/fast/forms/menulist-narrow-width-expected.txt:
  • platform/chromium-linux/fast/forms/menulist-no-overflow-expected.checksum:
  • platform/chromium-linux/fast/forms/menulist-no-overflow-expected.png:
  • platform/chromium-linux/fast/forms/menulist-no-overflow-expected.txt:
  • platform/chromium-linux/fast/forms/menulist-option-wrap-expected.checksum:
  • platform/chromium-linux/fast/forms/menulist-option-wrap-expected.png:
  • platform/chromium-linux/fast/forms/menulist-option-wrap-expected.txt:
  • platform/chromium-linux/fast/forms/menulist-restrict-line-height-expected.checksum:
  • platform/chromium-linux/fast/forms/menulist-restrict-line-height-expected.png:
  • platform/chromium-linux/fast/forms/menulist-restrict-line-height-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/menulist-separator-painting-expected.checksum:
  • platform/chromium-linux/fast/forms/menulist-separator-painting-expected.png:
  • platform/chromium-linux/fast/forms/menulist-separator-painting-expected.txt:
  • platform/chromium-linux/fast/forms/menulist-style-color-expected.checksum:
  • platform/chromium-linux/fast/forms/menulist-style-color-expected.png:
  • platform/chromium-linux/fast/forms/menulist-style-color-expected.txt:
  • platform/chromium-linux/fast/forms/menulist-width-change-expected.checksum:
  • platform/chromium-linux/fast/forms/menulist-width-change-expected.png:
  • platform/chromium-linux/fast/forms/menulist-width-change-expected.txt:
  • platform/chromium-linux/fast/forms/option-script-expected.checksum:
  • platform/chromium-linux/fast/forms/option-script-expected.png:
  • platform/chromium-linux/fast/forms/option-script-expected.txt:
  • platform/chromium-linux/fast/forms/option-strip-whitespace-expected.checksum:
  • platform/chromium-linux/fast/forms/option-strip-whitespace-expected.png:
  • platform/chromium-linux/fast/forms/option-strip-whitespace-expected.txt:
  • platform/chromium-linux/fast/forms/option-text-clip-expected.checksum:
  • platform/chromium-linux/fast/forms/option-text-clip-expected.png:
  • platform/chromium-linux/fast/forms/option-text-clip-expected.txt:
  • platform/chromium-linux/fast/forms/select-align-expected.checksum:
  • platform/chromium-linux/fast/forms/select-align-expected.png:
  • platform/chromium-linux/fast/forms/select-align-expected.txt:
  • platform/chromium-linux/fast/forms/select-baseline-expected.checksum:
  • platform/chromium-linux/fast/forms/select-baseline-expected.png:
  • platform/chromium-linux/fast/forms/select-baseline-expected.txt:
  • platform/chromium-linux/fast/forms/select-dirty-parent-pref-widths-expected.checksum:
  • platform/chromium-linux/fast/forms/select-dirty-parent-pref-widths-expected.png:
  • platform/chromium-linux/fast/forms/select-dirty-parent-pref-widths-expected.txt:
  • platform/chromium-linux/fast/forms/select-disabled-appearance-expected.checksum:
  • platform/chromium-linux/fast/forms/select-disabled-appearance-expected.png:
  • platform/chromium-linux/fast/forms/select-disabled-appearance-expected.txt:
  • platform/chromium-linux/fast/forms/select-empty-option-height-expected.checksum:
  • platform/chromium-linux/fast/forms/select-empty-option-height-expected.png:
  • platform/chromium-linux/fast/forms/select-empty-option-height-expected.txt:
  • platform/chromium-linux/fast/forms/select-selected-expected.checksum:
  • platform/chromium-linux/fast/forms/select-selected-expected.png:
  • platform/chromium-linux/fast/forms/select-selected-expected.txt:
  • platform/chromium-linux/fast/forms/stuff-on-my-optgroup-expected.checksum:
  • platform/chromium-linux/fast/forms/stuff-on-my-optgroup-expected.png:
  • platform/chromium-linux/fast/forms/stuff-on-my-optgroup-expected.txt:
  • platform/chromium-linux/fast/html/keygen-expected.checksum:
  • platform/chromium-linux/fast/html/keygen-expected.png:
  • platform/chromium-linux/fast/html/keygen-expected.txt:
  • platform/chromium-linux/fast/invalid/014-expected.checksum:
  • platform/chromium-linux/fast/invalid/014-expected.png:
  • platform/chromium-linux/fast/invalid/014-expected.txt:
  • platform/chromium-linux/fast/invalid/residual-style-expected.checksum:
  • platform/chromium-linux/fast/invalid/residual-style-expected.png:
  • platform/chromium-linux/fast/invalid/residual-style-expected.txt:
  • platform/chromium-linux/fast/parser/document-write-option-expected.checksum:
  • platform/chromium-linux/fast/parser/document-write-option-expected.png:
  • platform/chromium-linux/fast/parser/document-write-option-expected.txt:
  • platform/chromium-linux/fast/repaint/control-clip-expected.checksum:
  • platform/chromium-linux/fast/repaint/control-clip-expected.png:
  • platform/chromium-linux/fast/repaint/control-clip-expected.txt:
  • platform/chromium-linux/fast/replaced/replaced-breaking-expected.checksum:
  • platform/chromium-linux/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-linux/fast/replaced/replaced-breaking-expected.txt:
  • platform/chromium-linux/fast/replaced/replaced-breaking-mixture-expected.checksum:
  • platform/chromium-linux/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/chromium-linux/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/chromium-linux/fast/replaced/three-selects-break-expected.checksum:
  • platform/chromium-linux/fast/replaced/three-selects-break-expected.png:
  • platform/chromium-linux/fast/replaced/three-selects-break-expected.txt:
  • platform/chromium-linux/fast/text/international/bidi-menulist-expected.checksum:
  • platform/chromium-linux/fast/text/international/bidi-menulist-expected.png:
  • platform/chromium-linux/fast/text/international/bidi-menulist-expected.txt:
  • platform/chromium-linux/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum:
  • platform/chromium-linux/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png:
  • platform/chromium-linux/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug18359-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug29326-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug29326-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug29326-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug33855-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug33855-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug4382-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug4382-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/chromium-linux/tables/mozilla/core/margins-expected.checksum:
  • platform/chromium-linux/tables/mozilla/core/margins-expected.png:
  • platform/chromium-linux/tables/mozilla/core/margins-expected.txt:
  • platform/chromium-linux/tables/mozilla/dom/tableDom-expected.checksum:
  • platform/chromium-linux/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-linux/tables/mozilla/dom/tableDom-expected.txt:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/chromium-linux/transforms/2d/zoom-menulist-expected.checksum:
  • platform/chromium-linux/transforms/2d/zoom-menulist-expected.png:
  • platform/chromium-linux/transforms/2d/zoom-menulist-expected.txt:
  • platform/chromium/test_expectations.txt:
1:30 PM Changeset in webkit [78609] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix windows build.

  • Shared/win/WebCoreArgumentCodersWin.cpp:

(CoreIPC::encodeResourceRequest):

1:22 PM Changeset in webkit [78608] by Martin Robinson
  • 3 edits in trunk/LayoutTests

2011-02-15 Martin Robinson <​mrobinson@igalia.com>

Reversing an expectations update, that I mistakenly uploaded in r78595.

  • platform/gtk/Skipped: Skip this test, as the results are incorrect on GTK+.
  • svg/text/lengthAdjust-text-metrics-expected.txt: Restore expectations for this test.
1:21 PM Changeset in webkit [78607] by sfalken@apple.com
  • 2 edits in trunk/LayoutTests

Skip failing tests being tracked by ​https://bugs.webkit.org/show_bug.cgi?id=54490

  • platform/win/Skipped:
1:09 PM Changeset in webkit [78606] by jochen@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-15 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Jeremy Orlow.

[chromium] add WebIDBFactory::deleteDatabase method
​https://bugs.webkit.org/show_bug.cgi?id=54447

  • public/WebIDBFactory.h: (WebKit::WebIDBFactory::open): (WebKit::WebIDBFactory::deleteDatabase):
1:03 PM Changeset in webkit [78605] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

2011-02-15 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.

Moved MarkedBlock data members to the head of the block
​https://bugs.webkit.org/show_bug.cgi?id=54482


This allows for a variable-sized tail, to accommodate oversized blocks.

SunSpider reports no change.


  • runtime/JSCell.h: (JSC::JSCell::MarkedBlock::allocate):
  • runtime/MarkedBlock.cpp: (JSC::MarkedBlock::destroy): (JSC::MarkedBlock::MarkedBlock): (JSC::MarkedBlock::sweep):
  • runtime/MarkedBlock.h: Added missing element to the CELLS_PER_BLOCK calculation. This kind of error is why we want to migrate to the system described below.

(JSC::roundUpToMultipleOf):
(JSC::MarkedBlock::firstCell):
(JSC::MarkedBlock::cells):
(JSC::MarkedBlock::cellNumber): Use subtraction instead of masking to
calculate cell number. The mask is no longer correct because the first
cell is not at the head of the block.

(JSC::MarkedBlock::forEach): Replaced m_cells data member with a cells()
accessor. We want to use sizeof(MarkedBlock) to calculate the size of the
block header, so we can't have an explicit data member to represent the block tail.


Also replaced iteration from zero with iteration from startCell(), since
the first N cells are now occupied by the header.

  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::MarkedSpace): (JSC::MarkedSpace::reset): Replaced iteration from zero as above.
12:50 PM Changeset in webkit [78604] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

2011-02-15 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

Add NPP_GetSitesWithData and NPP_URLRedirectNotify to the NPAPI headers
​https://bugs.webkit.org/show_bug.cgi?id=54481

We should really sync all headers with the NPAPI repository, but doing that
lead to build errors so I just added what was needed.

  • bridge/npapi.h: Add new functions.
  • bridge/nptypes.h: Sync with the official NPAPI repository, adding 64-bit integer types and removing a duplicate license header.
  • plugins/npfunctions.h: Add new functions.
12:37 PM Changeset in webkit [78603] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=54480
<rdar://problem/8975229> REGRESSION (WebKit2): A web page remains unresponsive for a long
time after printing

Nothing was painted until moving the mouse over browser chrome, deactivating the window,
or taking some other drastic measure like that.

  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::setAutodisplay): Call -[NSView displayIfNeeded] after enabling autodisplay. For some reason, this makes WebCore push updates again.
12:29 PM Changeset in webkit [78602] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=54486
Crashes under CachedResourceLoader::revalidateResource

Reviewed by Darin Adler.

CachedResourceLoader might get deleted from under one of its methods.
Try to catch a more informative crash stack.

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::~CachedResourceLoader):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::setAutoLoadImages):
(WebCore::CachedResourceLoader::load):
(WebCore::CachedResourceLoader::loadDone):
(WebCore::CachedResourceLoader::preload):
(WebCore::CachedResourceLoader::requestPreload):

  • loader/cache/CachedResourceLoader.h:
12:12 PM Changeset in webkit [78601] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-02-15 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

Make new-run-webkit-tests --processes work under Windows' weird
multiprocessing model. This requires us to be running a Python
file that can be imported as a module, so I've modified the
new-run-webkit-tests script to spawn a subprocess runing
webkitpy.layout_tests.run_webkit_tests.py. I've also modified
the manager_worker_broker tests because you can't pickle a
nested class. This requires us to use globals to pass queues
back and forth for testing, but the alternative is to pass extra
arguments to start_worker() and that feels like a bad tradeoff
just for testing.

​https://bugs.webkit.org/show_bug.cgi?id=54431

  • Scripts/new-run-webkit-tests:
  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
12:10 PM Changeset in webkit [78600] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-02-15 Sam Weinig <​sam@webkit.org>

Reviewed by Darin Adler.

Crash loading fast/loader/empty-embed-src-attribute.html
<rdar://problem/9005541>
​https://bugs.webkit.org/show_bug.cgi?id=54483

Add the ability to encode/decode and empty ResourceRequest.

  • Shared/mac/WebCoreArgumentCodersMac.mm: (CoreIPC::encodeResourceRequest): (CoreIPC::decodeResourceRequest): (CoreIPC::decodeResourceResponse): Add missing false check for the decode step.
  • Shared/win/WebCoreArgumentCodersWin.cpp: (CoreIPC::encodeResourceRequest): (CoreIPC::decodeResourceRequest): (CoreIPC::decodeResourceResponse): Add missing false check for the decode step.
12:02 PM Changeset in webkit [78599] by senorblanco@chromium.org
  • 7 edits in trunk/LayoutTests

2011-02-15 Stephen White <​senorblanco@chromium.org>

Unreviewed; new Chromium/Linux test baselines.

canvas-composite.html rebaselined due to new GPU-based path drawing code.
canvas-text-alignment and image-object-in-canvas rebaselined due to slight pixel differences near the scrollbar.

  • platform/chromium-gpu-linux/fast/canvas/canvas-composite-expected.checksum:
  • platform/chromium-gpu-linux/fast/canvas/canvas-composite-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.checksum:
  • platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.checksum:
  • platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png:
11:58 AM Changeset in webkit [78598] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-15 Tony Chang <​tony@chromium.org>

Unreviewed, update the version of Chromium in webkit.

  • DEPS:
11:52 AM Changeset in webkit [78597] by crogers@google.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-15 Chris Rogers <​crogers@google.com>

Reviewed by Alexey Proskuryakov.

Fix Mutex::tryLock() on Windows to work properly with PlatformCondition::timedWait()
​https://bugs.webkit.org/show_bug.cgi?id=54408

  • wtf/ThreadingWin.cpp: (WTF::PlatformCondition::timedWait):
11:47 AM Changeset in webkit [78596] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-02-15 Andreas Kling <​kling@webkit.org>

Reviewed by Darin Adler.

Optimize Color::serialized()
​https://bugs.webkit.org/show_bug.cgi?id=54452

Apply the optimizations from CSSPrimitiveValue::cssText() [CSS_RGBCOLOR]
to Color::serialized() - build the serialized color strings manually
instead of using String::format().

  • platform/graphics/Color.cpp: (WebCore::appendHexNumber): (WebCore::Color::serialized):
11:26 AM Changeset in webkit [78595] by Martin Robinson
  • 3 edits
    233 adds in trunk/LayoutTests

2011-02-15 Martin Robinson <​mrobinson@igalia.com>

Import the last set of GTK+ baselines for SVG tests.

  • platform/gtk/Skipped: Unskip tests which now have results. Classify failures.
11:17 AM Changeset in webkit [78594] by Martin Robinson
  • 3 edits
    161 adds in trunk/LayoutTests

2011-02-15 Martin Robinson <​mrobinson@igalia.com>

Add the next batch of GTK+ SVG results.

  • platform/gtk/Skipped: Unskip tests which now have results.
11:17 AM Changeset in webkit [78593] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebKit2

2011-02-15 Andreas Kling <​kling@webkit.org>

Unreviewed Qt build fix after r78588.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::QWKPage): Add WKPageLoaderClient::shouldGoToHistoryItem.
11:10 AM Changeset in webkit [78592] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-15 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r78579.
​http://trac.webkit.org/changeset/78579
​https://bugs.webkit.org/show_bug.cgi?id=54479

Undo wrong rebaseline for Gtk results (Requested by msanchez
on #webkit).

  • platform/gtk/fast/block/float/marquee-shrink-to-avoid-floats-expected.txt:
11:10 AM Changeset in webkit [78591] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-15 Jarred Nicholls <​jarred@sencha.com>

Reviewed by Alexey Proskuryakov.

XMLHttpRequest::abort() doesn't clear response data
​https://bugs.webkit.org/show_bug.cgi?id=54118

Properly clear all buffer data on abort, so no memory hangs around unnecessarily.

No new tests because there is no observable effect except for less memory used.

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::abort):
11:01 AM Changeset in webkit [78590] by andreas.kling@nokia.com
  • 11 edits in trunk/Source/WebCore

2011-02-15 Andreas Kling <​kling@webkit.org>

Reviewed by Darin Adler.

Rename Color::name() to Color::nameForRenderTreeAsText()
​https://bugs.webkit.org/show_bug.cgi?id=54464

Color::name() returns the color as either #RRGGBB or #RRGGBBAA.
Since the latter is not a valid CSS color, it can't be re-parsed
by WebKit, and should only be used in DRT dumps.

  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::extractTextStyles):
  • page/DragController.cpp: (WebCore::DragController::concludeEditDrag):
  • platform/graphics/Color.cpp: (WebCore::Color::nameForRenderTreeAsText):
  • platform/graphics/Color.h:
  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::dumpProperties):
  • platform/graphics/filters/FEFlood.cpp: (WebCore::FEFlood::externalRepresentation):
  • rendering/RenderTreeAsText.cpp: (WebCore::RenderTreeAsText::writeRenderObject):
  • rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::operator<<): (WebCore::writeRenderSVGTextBox):
  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::applyResultsToTarget):
  • svg/SVGColor.cpp: (WebCore::SVGColor::cssText):
10:57 AM Changeset in webkit [78589] by enrica@apple.com
  • 3 edits in trunk/Source/WebKit2

Stop using deprecated API to flip the dragImage.
<rdar://problem/8930897>
​https://bugs.webkit.org/show_bug.cgi?id=54477

Reviewed by Darin Adler.

NSImage setFlipped is a deprecated API. We replace it with
drawInRect:fromRect:operation:fraction:respectFlipped:hints.

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setDragImage): Removed call to setFlipped.

  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::WebDragClient::startDrag): The image is now drawn with
drawInRect:fromRect:operation:fraction:respectFlipped:hints.

10:46 AM Changeset in webkit [78588] by beidson@apple.com
  • 13 edits in trunk

<rdar://problem/9002047> and ​https://bugs.webkit.org/show_bug.cgi?id=54426
WebFrameLoaderClient::shouldGoToHistoryItem needs implementation

Reviewed by Darin Adler.

Source/WebKit2:

Expose HistoryItem -> ItemID mapping for the message:

  • WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::WebBackForwardListProxy::idForItem):

  • WebProcess/WebPage/WebBackForwardListProxy.h:

Sync message to the UIProcess for the answer:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::shouldGoToHistoryItem):

Call out to the WebLoaderClient for the answer:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::shouldGoToBackForwardListItem):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:

Call out to the client application for the answer:

  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::shouldGoToBackForwardListItem):

  • UIProcess/WebLoaderClient.h:

Add API for the client application to listen for this:

  • UIProcess/API/C/WKPage.h:

Tools:

Add dummy implementations to keep our tools building.

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

10:43 AM Changeset in webkit [78587] by Martin Robinson
  • 2 edits
    154 adds in trunk/LayoutTests

2011-02-15 Martin Robinson <​mrobinson@igalia.com>

Import the next batch of GTK+ SVG test results and correct an incorrect
line in the skipped list.

  • platform/gtk/Skipped: Unskip tests which now have results.
10:38 AM Changeset in webkit [78586] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

2011-02-15 Mikhail Naganov <​mnaganov@chromium.org>

[Chromium] Unreviewed test expectations update.
SKIP two more Inspector tests, from r78581 (by pfeldman's request).

10:25 AM Changeset in webkit [78585] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-15 Andras Becsi <​abecsi@webkit.org>

Rubber-stamped by Andreas Kling.

[Qt] Typo fix.

No new tests needed.

  • WebCore.pro: add missing ASCII to header name.
10:22 AM Changeset in webkit [78584] by pfeldman@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

2011-02-15 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: expectations update for r78548 and r78576.

  • platform/mac-leopard/inspector/extensions/extensions-resources-expected.txt: Removed.
  • platform/qt/Skipped:
10:18 AM Changeset in webkit [78583] by Martin Robinson
  • 2 edits
    150 adds in trunk/LayoutTests

2011-02-15 Martin Robinson <​mrobinson@igalia.com>

Continue importing GTK+ SVG test results.

  • platform/gtk/Skipped: Unskip tests which now have results.
10:14 AM Changeset in webkit [78582] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

2011-02-15 Mikhail Naganov <​mnaganov@chromium.org>

[Chromium] Unreviewed test expectations update.
SKIP two Inspector tests (by pfeldman's request).

10:07 AM Changeset in webkit [78581] by pfeldman@chromium.org
  • 4 edits
    5 adds in trunk

2011-02-15 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: test whether inspector gets populated with databases and storages upon opening.
​https://bugs.webkit.org/show_bug.cgi?id=54469

  • http/tests/inspector-enabled/database-open-expected.txt: Added.
  • http/tests/inspector-enabled/database-open.html: Added.
  • http/tests/inspector-enabled/dom-storage-open-expected.txt: Added.
  • http/tests/inspector-enabled/dom-storage-open.html: Added.

2011-02-15 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: test whether inspector gets populated with databases and storages upon opening.
​https://bugs.webkit.org/show_bug.cgi?id=54469

Tests: http/tests/inspector-enabled/database-open.html

http/tests/inspector-enabled/dom-storage-open.html

  • inspector/front-end/DOMStorage.js:
  • inspector/front-end/Database.js: (WebInspector.DatabaseDispatcher.prototype.addDatabase):
9:58 AM Changeset in webkit [78580] by andreas.kling@nokia.com
  • 8 edits
    1 add in trunk/Source/WebCore

2011-02-15 Andreas Kling <​kling@webkit.org>

Reviewed by Darin Adler.

Share the helper functions used by Latin-1 and UTF-8 text codecs
​https://bugs.webkit.org/show_bug.cgi?id=54446

Move MachineWord, UCharByteFiller and the other helper functions
into TextCodecASCIIFastPath.h where they can be used by both
TextCodecUTF8 and TextCodecLatin1.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/text/TextCodecASCIIFastPath.h: Added. (WebCore::isAllASCII): (WebCore::copyASCIIMachineWord): (WebCore::isAlignedToMachineWord): (WebCore::alignToMachineWord):
  • platform/text/TextCodecLatin1.cpp: (WebCore::TextCodecLatin1::decode):
  • platform/text/TextCodecUTF8.cpp: (WebCore::TextCodecUTF8::decode):
9:52 AM Changeset in webkit [78579] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-15 Mario Sanchez Prada <​msanchez@igalia.com>

Unreviewed, rebaseline of Gtk result.

  • platform/gtk/fast/block/float/marquee-shrink-to-avoid-floats-expected.txt:
9:49 AM Changeset in webkit [78578] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix Anders typo. false -> 0.

Reviewed by Anders Carlsson.

  • Platform/mac/SharedMemoryMac.cpp:

(WebKit::SharedMemory::create):

9:45 AM Changeset in webkit [78577] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed text expectations fix

9:41 AM Changeset in webkit [78576] by pfeldman@chromium.org
  • 12 edits
    11 adds in trunk/LayoutTests

2011-02-15 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: implement DOM agent tests.
​https://bugs.webkit.org/show_bug.cgi?id=54459

  • http/tests/inspector/elements-test.js: (initialize_ElementTest.InspectorTest.expandedNodeWithId.callback): (initialize_ElementTest.InspectorTest.expandedNodeWithId): (initialize_ElementTest.InspectorTest.dumpElementsTree): (initialize_ElementTest.InspectorTest.dumpElementsTree.print): (initialize_ElementTest.InspectorTest.expandElementsTree): (initialize_ElementTest.InspectorTest.expandElementsTree.mycallback): (initialize_ElementTest.InspectorTest.dumpDOMAgentTree): (initialize_ElementTest):
  • http/tests/inspector/extensions-resources-redirect-expected.txt:
  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.addResult.clearResults): (initialize_InspectorTest.InspectorTest.runTestSuite.runner): (initialize_InspectorTest.InspectorTest.runTestSuite): (output): (clearOutput):
  • inspector/debugger/dom-breakpoints.html:
  • inspector/elements/elements-panel-limited-children-expected.txt:
  • inspector/elements/elements-panel-rewrite-href.html:
  • inspector/elements/elements-panel-structure-expected.txt:
  • inspector/elements/elements-panel-structure.html:
  • inspector/elements/elements-panel-xhtml-structure-expected.txt:
  • inspector/elements/elements-panel-xhtml-structure.xhtml:
  • inspector/elements/insert-node-collapsed-expected.txt: Added.
  • inspector/elements/insert-node-collapsed.html: Added.
  • inspector/elements/insert-node-expected.txt: Added.
  • inspector/elements/insert-node.html: Added.
  • inspector/elements/modify-chardata-expected.txt: Added.
  • inspector/elements/modify-chardata.html: Added.
  • inspector/elements/mutate-unknown-node-expected.txt: Added.
  • inspector/elements/mutate-unknown-node.html: Added.
  • inspector/elements/remove-node-expected.txt: Added.
  • inspector/elements/remove-node.html: Added.
  • inspector/elements/set-attribute.html: Added.
  • inspector/extensions/extensions-expected.txt:
9:36 AM Changeset in webkit [78575] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-15 Leo Yang <​leo.yang@torchmobile.com.cn>

Reviewed by Kent Tamura.

Code style issue in WebCore/dom/InputElement.cpp
​https://bugs.webkit.org/show_bug.cgi?id=54428

Remove 2 extra spaces in InputElement.cpp line 221.

Code style fix, No new tests.

  • dom/InputElement.cpp: (WebCore::InputElement::handleBeforeTextInsertedEvent):
9:30 AM Changeset in webkit [78574] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

2011-02-15 Mikhail Naganov <​mnaganov@chromium.org>

[Chromium] Unreviewed test expectations update.
Mark svg/custom/use-css-no-effect-on-shadow-tree.svg as passing.
Mark media/audio-delete-while-slider-thumb-clicked.html as timing out.
​https://bugs.webkit.org/show_bug.cgi?id=54472

9:29 AM Changeset in webkit [78573] by xan@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-15 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

Remove some dead code in ARMv7
​https://bugs.webkit.org/show_bug.cgi?id=54461

  • assembler/ARMv7Assembler.h: remove dead code.
9:28 AM Changeset in webkit [78572] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-15 Mario Sanchez Prada <​msanchez@igalia.com>

Unreviewed, test crashing because of failing ASSERT on GTK 64-bit debug bot.

[GTK] svg/text/select-textLength-spacing-squeeze-1.svg crashes due to ASSERT failing
​https://bugs.webkit.org/show_bug.cgi?id=54470

  • platform/gtk/Skipped: Skipped test.
8:59 AM Changeset in webkit [78571] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

2011-02-15 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

[GStreamer] Video player sets system volume to 100%
​https://bugs.webkit.org/show_bug.cgi?id=54140

Don't explicitely set volume at startup and use the
GstStreamVolume interface with cubic volume scale when
updating/retrieving the volume value. This gives a much better
user-experience.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
8:48 AM Changeset in webkit [78570] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-15 Zan Dobersek <​zandobersek@gmail.com>

Reviewed by Andreas Kling.

[Gtk] Cleanup in the canvas tests
​https://bugs.webkit.org/show_bug.cgi?id=54458

Unskip canvas tests that already pass.

  • platform/gtk/Skipped:
8:47 AM Changeset in webkit [78569] by abarth@webkit.org
  • 7 edits
    2 adds in trunk

2011-02-15 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Sketch script-src for Content Security Policy
​https://bugs.webkit.org/show_bug.cgi?id=54381

  • http/tests/security/contentSecurityPolicy/script-loads-with-img-src-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/script-loads-with-img-src.html: Added.
    • Test that we don't block scripts when the policy is just img-src.
  • http/tests/security/contentSecurityPolicy/script-src-in-iframe.html:
  • http/tests/security/contentSecurityPolicy/script-src-none.html:
  • http/tests/security/contentSecurityPolicy/script-src-redirect.html:
    • Turns out we need to escape the ; character in order for it to be echoed back correctly in the header.

2011-02-15 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Sketch script-src for Content Security Policy
​https://bugs.webkit.org/show_bug.cgi?id=54381

This patch provides a sketch of the script-src directive. We still do
not parse the value of the directive, and the wiring into the rest of
WebCore is incorrect, but those are things we can fix in future
patches. For the momemnt, this patch lets us test what we're doing.

Test: http/tests/security/contentSecurityPolicy/script-loads-with-img-src.html

  • page/ContentSecurityPolicy.cpp: (WebCore::CSPDirective::CSPDirective): (WebCore::CSPDirective::allows): (WebCore::ContentSecurityPolicy::didReceiveHeader): (WebCore::ContentSecurityPolicy::canLoadExternalScriptFromSrc): (WebCore::ContentSecurityPolicy::parse): (WebCore::ContentSecurityPolicy::emitDirective):
  • page/ContentSecurityPolicy.h:
8:45 AM Changeset in webkit [78568] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

svg/custom/use-css-no-effect-on-shadow-tree.svg produces empty image on Chromium Linux after r58556
​https://bugs.webkit.org/show_bug.cgi?id=54460

Reviewed by Andreas Kling.

Don't use fast path for SVG. There are some additional rules for shadow trees that are not
implemented on fast path.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::checkSelector):

8:41 AM Changeset in webkit [78567] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-15 Mario Sanchez Prada <​msanchez@igalia.com>

Unreviewed, skipping flaky test on GTK 64-bit debug bot.

editing/selection/end-of-document.html is failing in the GTK 64-bit debug bot
​https://bugs.webkit.org/show_bug.cgi?id=53995

  • platform/gtk/Skipped: Skipped flaky test.
8:15 AM Changeset in webkit [78566] by abecsi@webkit.org
  • 6 edits
    1 copy in trunk/Source

2011-02-15 Andras Becsi <​abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Redesign the build system
​https://bugs.webkit.org/show_bug.cgi?id=51339

Part 1.

Introduce CodeGenerators.pri and add common includepaths to WebCore.pri,
thus unnecessary duplications can be removed from project files.

No new tests needed.

  • CodeGenerators.pri: Copied from Source/WebCore/WebCore.pri. Don't add non-source generated files to SOURCES.
  • DerivedSources.pro: Change WebCore.pri to CodeGenerators.pri.
  • WebCore.pri: Move code generation rules to CodeGenerators.pri.
  • WebCore.pro: Move common options to WebCore.pri.

2011-02-15 Andras Becsi <​abecsi@webkit.org>

Reviewed by NOBODY Csaba Osztrogonác.

[Qt] Redesign the build system
​https://bugs.webkit.org/show_bug.cgi?id=51339

Part 1.

Introduce CodeGenerators.pri and add common includepaths to WebCore.pri,
thus unnecessary duplications can be removed from project files.

  • WebKit2.pro: Simplify and deduplicate includepaths.
8:14 AM Changeset in webkit [78565] by kalman@chromium.org
  • 6 edits in trunk/LayoutTests

2011-02-15 Benjamin Kalman <​kalman@chromium.org>

Reviewed by Ryosuke Niwa.

Refactor the extend-selection tests to be clearer what they're doing
​https://bugs.webkit.org/show_bug.cgi?id=54429

This is essentially a cleanup to extend-selection.js and propagation of those changes to the affected tests.

  • editing/selection/extend-selection-character.html:
  • editing/selection/extend-selection-enclosing-block.html:
  • editing/selection/extend-selection-home-end.html:
  • editing/selection/extend-selection-word.html:
  • editing/selection/resources/extend-selection.js: (getSerializedSelection): (extendSelectionWithinBlock): (extendSelectionToEnd): (fold): (logMismatchingPositions): (extendAndLogSelection): (extendAndLogSelectionWithinBlock): (extendAndLogSelectionToEnd): (runSelectionTestsWithGranularity): (getTestNodeContainer): (createNode): (createCharAndWordNodes): (createEnclosingBlockNodes): (createHomeEndNodes): (createAllNodes): (.window.onload):
8:11 AM Changeset in webkit [78564] by mihaip@chromium.org
  • 2 edits
    2 copies in branches/chromium/648/Source/WebCore

Merge 78561 - 2011-02-15 Charlie Reis <​creis@chromium.org>

Reviewed by Mihai Parparita.

Crash in WebCore::FrameLoader::continueLoadAfterNavigationPolicy
​https://bugs.webkit.org/show_bug.cgi?id=54219

Ensures we do not start a new navigation while we are in the process of
stopping a navigation. Also adds a manual test, since the crash can
only be reproduced using the back button and not history.back().

  • loader/FrameLoader.cpp:
  • manual-tests/navigation-during-onload-triggered-by-back.html: Added.
  • manual-tests/resources/navigation-during-onload-container.html: Added.

BUG=72458
TBR=​commit-queue@webkit.org
Review URL: ​http://codereview.chromium.org/6524014

7:58 AM Changeset in webkit [78563] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

2011-02-15 Mikhail Naganov <​mnaganov@chromium.org>

[Chromium] Unreviewed test expectations update.
Mark svg/custom/use-css-no-effect-on-shadow-tree.svg as failing.
​https://bugs.webkit.org/show_bug.cgi?id=54460

7:56 AM Changeset in webkit [78562] by Philippe Normand
  • 4 edits in trunk/LayoutTests

2011-02-15 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Carlson.

[GTK] media/audio-delete-while-slider-thumb-clicked.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=53247

Refactored the test to use the seeking event instead of timeupdate
and avoid flakyness.

  • media/audio-delete-while-slider-thumb-clicked-expected.txt:
  • media/audio-delete-while-slider-thumb-clicked.html:
  • platform/gtk/Skipped:
7:55 AM Changeset in webkit [78561] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Source/WebCore

2011-02-15 Charlie Reis <​creis@chromium.org>

Reviewed by Mihai Parparita.

Crash in WebCore::FrameLoader::continueLoadAfterNavigationPolicy
​https://bugs.webkit.org/show_bug.cgi?id=54219

Ensures we do not start a new navigation while we are in the process of
stopping a navigation. Also adds a manual test, since the crash can
only be reproduced using the back button and not history.back().

  • loader/FrameLoader.cpp:
  • manual-tests/navigation-during-onload-triggered-by-back.html: Added.
  • manual-tests/resources/navigation-during-onload-container.html: Added.
7:48 AM Changeset in webkit [78560] by krit@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-15 Dirk Schulze <​krit@webkit.org>

Unreviewed rebaseline.

SVG animation doesn't support attribute value 'inherit'
​https://bugs.webkit.org/show_bug.cgi?id=54410

Rebaseline of Gtk result.

  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
7:47 AM Changeset in webkit [78559] by jeffm@apple.com
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Unreviewed. Add myself to the list of committers.

7:28 AM Changeset in webkit [78558] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebCore

2011-02-15 Bill Budge <​bbudge@chromium.org>

Reviewed by David Levin.

SubresourceLoader should expose finish time
​https://bugs.webkit.org/show_bug.cgi?id=54287

No tests needed, exposes no new functionality

  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::didFinishLoading):
  • loader/DocumentThreadableLoader.h:
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didFinishLoading):
  • loader/SubresourceLoaderClient.h: (WebCore::SubresourceLoaderClient::didFinishLoading):
  • loader/cache/CachedResourceRequest.cpp: (WebCore::CachedResourceRequest::didFinishLoading):
  • loader/cache/CachedResourceRequest.h:
  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::didFinishLoading):
  • loader/icon/IconLoader.h:
7:23 AM Changeset in webkit [78557] by mnaganov@chromium.org
  • 2 adds in trunk/LayoutTests/platform/chromium-linux/http/tests/xmlhttprequest

2011-02-15 Mikhail Naganov <​mnaganov@chromium.org>

[Chromium] Unreviewed test expectations update.
Update test results for xmlhttprequest/cache-override.html after r78541.

7:13 AM Changeset in webkit [78556] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Enable fast path selector checking for child and subselector combinators
​https://bugs.webkit.org/show_bug.cgi?id=54360

Reviewed by Darin Adler.

  • css/CSSStyleSelector.cpp:

(WebCore::isFastCheckableSelector):
(WebCore::fastCheckSingleSelector):
(WebCore::checkClassValue):
(WebCore::checkIdValue):
(WebCore::checkTagValue):
(WebCore::CSSStyleSelector::SelectorChecker::fastCheckSelector):

7:06 AM Changeset in webkit [78555] by mnaganov@chromium.org
  • 4 edits
    4 adds in trunk/LayoutTests/platform

2011-02-15 Mikhail Naganov <​mnaganov@chromium.org>

[Chromium] Unreviewed test expectations update.
Add test results for animate-elem-31-t.svg after r78543, r78552.

6:50 AM Changeset in webkit [78554] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-15 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: console auto-scroll is broken when there are both scrollers.
​https://bugs.webkit.org/show_bug.cgi?id=54273

  • inspector/front-end/utilities.js: (Element.prototype.isScrolledToBottom): use clientHeight instead of offsetHeight to determine whether the element is scrolled to the bottom.
6:39 AM Changeset in webkit [78553] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-14 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: highlighter works incorrect at build.chromium.org WebKit cells
​https://bugs.webkit.org/show_bug.cgi?id=53910

Use enclosingBoundingBox for the absolute margin quad as the reference box for a tooltip.

  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::drawNodeHighlight):
6:03 AM Changeset in webkit [78552] by krit@webkit.org
  • 7 edits in trunk

2011-02-15 Dirk Schulze <​krit@webkit.org>

Rubber-stamped by Nikolas Zimmermann.

SVG animation doesn't support attribute value 'inherit'
​https://bugs.webkit.org/show_bug.cgi?id=54410

Accidently replaced start value RegularPropertyValue for m_fromPropertyValueType
and m_toPropertyValueType by CurrentColorValue before landing. Check for property
value type 'inherit' on color validation was missing.

  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues):

2011-02-15 Dirk Schulze <​krit@webkit.org>

Rubber-stamped by Nikolas Zimmermann.

SVG animation doesn't support attribute value 'inherit'
​https://bugs.webkit.org/show_bug.cgi?id=54410

We have support for 'inherit' in SVG animations now. This means the cyan circles
are invisible at the beginning.
The test itself is still broken, since calcMode gets handled incorrectly.

  • platform/mac-wk2/Skipped:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
5:35 AM Changeset in webkit [78551] by christian@webkit.org
  • 33 edits in trunk/Source/WebKit/gtk

Source/WebKit/gtk: * webkit/webkitwebsettings.cpp: Correct a typo, it is

acces*s*ibility with two s.

Rubber-stamped by Gustavo Noronha Silva.

Source/WebKit/gtk/po: * *.po: Correct a typo in acces*s*ibility.

Rubber-stamped by Gustavo Noronha Silva.

5:31 AM Changeset in webkit [78550] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Windows build fix after r78533

  • WebCore.vcproj/WebCore.vcproj: Fix bad XML syntax.
5:23 AM Changeset in webkit [78549] by christian@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk/po

Unreviewed translation file.

Brazilian Portuguese Translation Update
​https://bugs.webkit.org/show_bug.cgi?id=42833

  • pt_BR.po: Updated.
5:09 AM Changeset in webkit [78548] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-02-15 Gavin Peters <​gavinp@chromium.org>

Reviewed by Antti Koivisto.

SharedBuffer::buffer() does not do what you think.
​https://bugs.webkit.org/show_bug.cgi?id=54420

No new tests.

  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::resourceContentBase64):
  • platform/SharedBuffer.h:
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::decode): (WebCore::JPEGImageDecoder::decode):
  • platform/image-decoders/webp/WEBPImageDecoder.cpp: (WebCore::WEBPImageDecoder::decode):
3:44 AM Changeset in webkit [78547] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-15 Mario Sanchez Prada <​msanchez@igalia.com>

Unreviewed, unskip passing test after r78541.

r78499 causes assertion failure in http/tests/xmlhttprequest/cache-override.html
​https://bugs.webkit.org/show_bug.cgi?id=54418

  • platform/gtk/Skipped: Unskip passing test.
3:33 AM Changeset in webkit [78546] by mario@webkit.org
  • 1 edit
    12 adds in trunk/LayoutTests

2011-02-15 Mario Sanchez Prada <​msanchez@igalia.com>

Unreviewed, GTK baselines for 4 new tests added in r78396.

  • platform/gtk/fast/inline/inline-box-background-expected.checksum: Added.
  • platform/gtk/fast/inline/inline-box-background-expected.png: Added.
  • platform/gtk/fast/inline/inline-box-background-expected.txt: Added.
  • platform/gtk/fast/inline/inline-box-background-long-image-expected.checksum: Added.
  • platform/gtk/fast/inline/inline-box-background-long-image-expected.png: Added.
  • platform/gtk/fast/inline/inline-box-background-long-image-expected.txt: Added.
  • platform/gtk/fast/inline/inline-box-background-repeat-x-expected.checksum: Added.
  • platform/gtk/fast/inline/inline-box-background-repeat-x-expected.png: Added.
  • platform/gtk/fast/inline/inline-box-background-repeat-x-expected.txt: Added.
  • platform/gtk/fast/inline/inline-box-background-repeat-y-expected.checksum: Added.
  • platform/gtk/fast/inline/inline-box-background-repeat-y-expected.png: Added.
  • platform/gtk/fast/inline/inline-box-background-repeat-y-expected.txt: Added.
3:27 AM Changeset in webkit [78545] by levin@chromium.org
  • 3 edits in trunk/Tools

2011-02-15 David Levin <​levin@chromium.org>

Reviewed by Shinichiro Hamaji.

check-webkit-style should do some detection for valid uses of WEBKIT_API (in chromium public api).
​https://bugs.webkit.org/show_bug.cgi?id=52271

  • Scripts/webkitpy/style/checkers/cpp.py: Added the check for WEBKIT_API usage.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
3:26 AM Changeset in webkit [78544] by pfeldman@chromium.org
  • 1 edit
    1 move
    1 add in trunk/LayoutTests

2011-02-15 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: update inspector expectation path for mac-leopard.

  • platform/mac-leopard/inspector/extensions/extensions-resources-expected.txt: Renamed from LayoutTests/platform/mac-leopard/inspector/extensions-resources-expected.txt.
3:16 AM Changeset in webkit [78543] by krit@webkit.org
  • 9 edits
    6 adds in trunk

2011-02-15 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG animation doesn't support attribute value 'inherit'
​https://bugs.webkit.org/show_bug.cgi?id=54410

Check support for 'inherit' and 'currentColor' on SVG animations.

  • svg/animations/animate-currentColor-expected.txt: Added.
  • svg/animations/animate-currentColor.html: Added.
  • svg/animations/animate-inherit-css-property-expected.txt: Added.
  • svg/animations/animate-inherit-css-property.html: Added.
  • svg/animations/script-tests/animate-currentColor.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/animate-inherit-css-property.js: Added. (sample1): (sample2): (sample3): (executeTest):

2011-02-15 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG animation doesn't support attribute value 'inherit'
​https://bugs.webkit.org/show_bug.cgi?id=54410

SVG animation does not support 'inherit' as value for CSS property animations. With the patch, SVG determines
if the attribute of the target element is an animatable CSS Property and computes the style during the
animation.

This fixes the following tests on the W3C test suite:

  • animate-elem-84-t.svg
  • animate-elem-85-t.svg

Tests: svg/animations/animate-currentColor.html

svg/animations/animate-inherit-css-property.html

  • svg/SVGAnimateElement.cpp: (WebCore::adjustForCurrentColor): (WebCore::adjustForInheritance): (WebCore::SVGAnimateElement::calculateAnimatedValue): When a property value is 'inherit' or 'currentColor' during the animation, get the computed style of the property since the values could be animated themselves. (WebCore::inheritsFromProperty): (WebCore::attributeValueIsCurrentColor): (WebCore::SVGAnimateElement::calculateFromAndToValues): Check if 'from', 'by' or 'to' value has the string 'inherit' or 'currentColor' and if the attribute supports one of these values. (WebCore::SVGAnimateElement::calculateFromAndByValues): Ditto.
  • svg/SVGAnimateElement.h:
  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::isTargetAttributeCSSProperty): Check if target element is stylable and the attribute is an animatable CSS property by using the CSS property map in SVGStyledElement. (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue): s/target/targetElement/ for consistency.
  • svg/SVGAnimationElement.h:
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::isAnimatableCSSProperty): Checks if the CSS property is animatable.
  • svg/SVGStyledElement.h:
  • svg/animation/SMILTimeContainer.cpp: Use the new function isTargetAttributeCSSProperty to determine if the target element is stylable and the attribute is an animatable CSS property. (WebCore::SMILTimeContainer::baseValueFor):
3:06 AM Changeset in webkit [78542] by pfeldman@chromium.org
  • 2 edits in branches/chromium/597/WebCore/inspector/front-end

Reverting poor merge of ​http://trac.webkit.org/changeset/74261 that landed in M9 as ​http://trac.webkit.org/changeset/74265.
It resulted in the regression: Chrome 9 dev tools no longer lists resources pulled via XHR.

This has been approved by Anthony.
BUG=72834

Review URL: ​http://codereview.chromium.org/6528009

3:03 AM Changeset in webkit [78541] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

r78499 causes assertion failure in http/tests/xmlhttprequest/cache-override.html
​https://bugs.webkit.org/show_bug.cgi?id=54418

Reviewed by Andreas Kling.

Check for zero buffer length.

  • platform/text/TextCodecUTF8.cpp:

(WebCore::TextCodecUTF8::decode):