Timeline



Mar 13, 2011:

11:24 PM Changeset in webkit [81003] by beidson@apple.com
  • 3 edits in trunk/Source/WebCore

Fixed lock-taking order to prevent deadlock, added lock for m_client,
removed premature return in syncImportOriginIdentifiers when tracker
db does not exist because that prevented syncFileSystemAndTrackerDatabase()
from running until next LocalStorage db creation, cleaned up
StorageTracker::scheduleTask() code for readability.

Patch by Anton D'Auria <adauria@apple.com> on 2011-03-13
Reviewed by Brady Eidson and David Levin, landed by Brady Eidson.

https://bugs.webkit.org/show_bug.cgi?id=56285

  • storage/StorageTracker.cpp:

(WebCore::StorageTracker::trackerDatabasePath):
(WebCore::StorageTracker::syncImportOriginIdentifiers): If tracker db isn't
optionally opened (as in the case when it doesn't exist on disk), don't
exit early and call syncFileSystemAndTrackerDatabase(), which will create
a tracker db if localstorage db files are found on disk by calling setOriginDetails.
(WebCore::StorageTracker::syncFileSystemAndTrackerDatabase):
(WebCore::StorageTracker::setOriginDetails):
(WebCore::StorageTracker::scheduleTask): readability changes.
(WebCore::StorageTracker::syncSetOriginDetails):
(WebCore::StorageTracker::syncDeleteAllOrigins):
(WebCore::StorageTracker::syncDeleteOrigin):
(WebCore::StorageTracker::cancelDeletingOrigin): order lock-taking consistently to avoid deadlock.
(WebCore::StorageTracker::setClient):

  • storage/StorageTracker.h:
11:20 PM Changeset in webkit [81002] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Reviewed and landed by Brady Eidson.

Patch by Anton D'Auria <adauria@apple.com> on 2011-03-13
Invalid assertion in StorageTracker - PageGroup::numberOfPageGroups() == 1
https://bugs.webkit.org/show_bug.cgi?id=56240

This assertion is invalid until LocalStorage is either global or is isolated by PageGroup.

  • storage/StorageTracker.cpp:

(WebCore::StorageTracker::origins):
(WebCore::StorageTracker::deleteAllOrigins):
(WebCore::StorageTracker::deleteOrigin):

11:02 PM Changeset in webkit [81001] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

Make adjustMIMETypeIfNecessary use CFNetwork directly
https://bugs.webkit.org/show_bug.cgi?id=55912

Reviewed by Dan Bernstein.

Follow up fix for Layout Test failure. Fix typo - it should be text/plain, not test/plain.

  • platform/network/mac/WebCoreURLResponse.mm:

(WebCore::adjustMIMETypeIfNecessary):

10:47 PM Changeset in webkit [81000] by beidson@apple.com
  • 16 edits in trunk/Source/WebKit2

<rdar://problem/9127270> and https://bugs.webkit.org/show_bug.cgi?id=56282

Reviewed by Sam Weinig.

Pass the path along with creation parameters:

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

Add SPI to set the path:

  • UIProcess/API/C/WKContext.cpp:

(WKContextSetLocalStorageDirectory):

  • UIProcess/API/C/WKContextPrivate.h:

Pass the path along in the process creation parameters:

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureWebProcess):
(WebKit::WebContext::localStorageDirectory):

  • UIProcess/WebContext.h:

(WebKit::WebContext::setLocalStorageDirectory):

  • UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::platformDefaultLocalStorageDirectory):

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformDefaultLocalStorageDirectory):

  • UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::platformDefaultLocalStorageDirectory):

  • UIProcess/win/WebContextWin.cpp:

(WebKit::WebContext::platformDefaultLocalStorageDirectory):

Include the path with settings updates, because WebCore needs it set on the Settings object:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

  • WebProcess/WebProcess.h:

(WebKit::WebProcess::localStorageDirectory):

Sandboxing stuff:

  • WebProcess/com.apple.WebProcess.sb:
  • WebProcess/mac/WebProcessMac.mm:

(WebKit::initializeSandbox):

10:35 PM Changeset in webkit [80999] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-03-12 Jer Noble <jer.noble@apple.com>

Reviewed by Mark Rowe.

WebKit2: Build WKFullScreenWindowController cleanly in 32-bit.
https://bugs.webkit.org/show_bug.cgi?id=56260

Include <Carbon/Carbon.h> instead of <HIToolbox/MacApplication.h>.

  • UIProcess/mac/WKFullScreenWindowController.mm:
10:23 PM Changeset in webkit [80998] by levin@chromium.org
  • 2 edits in trunk/Source/WebCore

Improve my hasitly added build fix and added a bug https://bugs.webkit.org/show_bug.cgi?id=56288
above addressing this FIXME.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

10:23 PM Changeset in webkit [80997] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Clean up overlapping test_expectation which I mistakenly added in my haste.

  • platform/chromium/test_expectations.txt:
10:10 PM Changeset in webkit [80996] by mitz@apple.com
  • 13 edits in trunk

Include hyphenation information in text representation of render tree
https://bugs.webkit.org/show_bug.cgi?id=56287

Reviewed by Sam Weinig.

Source/WebCore:

(WebCore::writeTextRun): If the text box is hyphenated, output the hyphenation
string.

LayoutTests:

  • fast/text/soft-hyphen-4-expected.txt:
  • platform/mac-snowleopard/fast/text/hyphenate-limit-before-after-expected.txt:
  • platform/mac-snowleopard/fast/text/hyphenate-locale-expected.txt:
  • platform/mac/fast/text/basic/014-expected.txt:
  • platform/mac/fast/text/capitalize-boundaries-expected.txt:
  • platform/mac/fast/text/hyphenate-character-expected.txt:
  • platform/mac/fast/text/hyphenate-first-word-expected.txt:
  • platform/mac/fast/text/hyphens-expected.txt:
  • platform/mac/fast/text/midword-break-after-breakable-char-expected.txt:
  • platform/mac/fast/text/soft-hyphen-2-expected.txt:
9:56 PM Changeset in webkit [80995] by ggaren@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

A few Heap-related renames (sans file moves, which should come next)
https://bugs.webkit.org/show_bug.cgi?id=56283

Reviewed by Sam Weinig.

ConservativeSet => ConservativeRoots. "Set" was misleading, since items
are not uniqued. Also, "Roots" is more specific about what's in the set.

MachineStackMarker => MachineThreads. "Threads" is more descriptive of
the fact that this class maintains a set of all threads using JSC.
"Stack" was misleading, since this class traverses stacks and registers.
"Mark" was misleading, since this class doesn't mark anything anymore.

registerThread => addCurrentThread. "Current" is more specific.
unregisterThread => removeCurrentThread. "Current" is more specific.

"currentThreadRegistrar" => threadSpecific. The only point of this data
structure is to register a thread-specific destructor with a pointer to
this.

"mark...Conservatively" => "gather". "Mark" is not true, since these
functions don't mark anything. "Conservatively" is redundant, since they
take "ConservativeRoots" as an argument.

  • API/APIShims.h:

(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):

(JSC::ConservativeRoots::grow):
(JSC::ConservativeRoots::add):

  • runtime/ConservativeSet.h:

(JSC::ConservativeRoots::ConservativeRoots):
(JSC::ConservativeRoots::~ConservativeRoots):
(JSC::ConservativeRoots::size):
(JSC::ConservativeRoots::roots):

  • runtime/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::markRoots):

  • runtime/Heap.h:

(JSC::Heap::machineThreads):

  • runtime/JSGlobalData.h:

(JSC::JSGlobalData::makeUsableFromMultipleThreads):

  • runtime/MachineStackMarker.cpp:

(JSC::MachineThreads::MachineThreads):
(JSC::MachineThreads::~MachineThreads):
(JSC::MachineThreads::makeUsableFromMultipleThreads):
(JSC::MachineThreads::addCurrentThread):
(JSC::MachineThreads::removeThread):
(JSC::MachineThreads::removeCurrentThread):
(JSC::MachineThreads::gatherFromCurrentThreadInternal):
(JSC::MachineThreads::gatherFromCurrentThread):
(JSC::MachineThreads::gatherFromOtherThread):
(JSC::MachineThreads::gatherConservativeRoots):

  • runtime/MachineStackMarker.h:
  • runtime/MarkStack.h:

(JSC::MarkStack::append):

9:53 PM Changeset in webkit [80994] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

BUILD FIX for armv7 after r80969

Bug 56270 - The JIT 'friend's many classes in JSC; start unwinding this.
<https://bugs.webkit.org/show_bug.cgi?id=56270>

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::load32): Made void* address argument
const.
(JSC::MacroAssemblerARMv7::store32): Ditto.

9:37 PM Changeset in webkit [80993] by levin@chromium.org
  • 4 edits in trunk

Build fix adding remaining enum values to switch statement.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

Add more crashing tests to an existing bug about the same issue
for Chromium Linux Debug. :(

  • platform/chromium/test_expectations.txt:
9:02 PM Changeset in webkit [80992] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Add some test failures that I need to investigate further.
Clean up a duplicate test expectation (default-timing-function.html ).
Add a missing test expection for linux debug which was there for linux release (border-image-vertical-lr.html).

  • platform/chromium/test_expectations.txt:
9:02 PM Changeset in webkit [80991] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Add more crashing tests to an existing bug about the same issue
for Chromium Linux Debug.

  • platform/chromium/test_expectations.txt:
8:02 PM Changeset in webkit [80990] by mrowe@apple.com
  • 5 edits in trunk/Source

Versioning.

8:01 PM Changeset in webkit [80989] by mrowe@apple.com
  • 1 copy in tags/Safari-534.24

New tag.

7:36 PM Changeset in webkit [80988] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Updated expected results after r80982.

  • platform/mac-snowleopard/fast/text/hyphenate-limit-before-after-expected.txt:
6:35 PM Changeset in webkit [80987] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Not reviewed.

Try to fix the Mac build.

ConervativeSet.h, since it's now visible when compiling other projects.

6:27 PM Changeset in webkit [80986] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix windows build.

  • platform/network/cf/ResourceErrorCF.cpp:

(WebCore::ResourceError::ResourceError):
Add missing constructor.

6:16 PM Changeset in webkit [80985] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

2011-03-13 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed another case of DeprecatedPtr (ConservativeSet)
https://bugs.webkit.org/show_bug.cgi?id=56281


The ConservativeSet is an internal data structure used during marking,
so direct pointers are fine.

  • runtime/ConservativeSet.cpp: (JSC::ConservativeSet::grow):
  • runtime/ConservativeSet.h: Added some accessors, for use by MarkStack::append. (JSC::ConservativeSet::~ConservativeSet): Fixed a typo where we calculated the size of the set based on sizeof(DeprecatedPtr<T>*) instead of sizeof(DeprecatedPtr<T>). I'm not sure if this had real-world implications or not. (JSC::ConservativeSet::size): (JSC::ConservativeSet::set): Use direct pointers, as stated above.
  • runtime/Heap.cpp: (JSC::Heap::markRoots):
  • runtime/MarkStack.h: (JSC::MarkStack::append): Created a special case of append for ConservativeSet. I didn't want to add back a generic "append JSCell*" function, since other class might start using that wrong. (In the end, this function might go away, since the Heap will want to do something slightly more interesting with the conservative set, but this is OK for now.)
6:09 PM Changeset in webkit [80984] by mitz@apple.com
  • 3 edits
    4 adds in trunk

Source/WebCore: REGRESSION: Soft hyphen is not always rendered
https://bugs.webkit.org/show_bug.cgi?id=56017

Patch by David Sosby <dsosby@rim.com> on 2011-03-13
Reviewed by Dan Bernstein.

The check to flag a text block as hyphenated was only
occurring at break points in the line. If no break points
were found after the soft hyphen then the line would not
be flagged hyphenated. Adding a check for soft hyphen at
the end of the text run resolves the issue.

Test: fast/text/soft-hyphen-4.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::findNextLineBreak):

LayoutTests: Reviewed and tweaked by Dan Bernstein.

Patch by David Sosby <dsosby@rim.com> on 2011-03-13
REGRESSION: Soft hyphen is not always rendered
https://bugs.webkit.org/show_bug.cgi?id=56017

Adding new test that verifies soft hyphen is rendered
when it is the last breakable point in a line.

  • fast/text/soft-hyphen-4-expected.checksum: Added.
  • fast/text/soft-hyphen-4-expected.png: Added.
  • fast/text/soft-hyphen-4-expected.txt: Added.
  • fast/text/soft-hyphen-4.html: Added.
5:58 PM Changeset in webkit [80983] by levin@chromium.org
  • 2 edits
    4 adds in trunk/LayoutTests

Update some baselines due to r80868.
Also, add MAC to a failure line where I should have put it previously.

  • platform/chromium-mac/fast/backgrounds/animated-svg-as-background-expected.checksum: Added.
  • platform/chromium-mac/fast/backgrounds/animated-svg-as-background-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/animated-svg-as-mask-expected.checksum: Added.
  • platform/chromium-mac/fast/backgrounds/animated-svg-as-mask-expected.png: Added.
  • platform/chromium/test_expectations.txt:
5:54 PM Changeset in webkit [80982] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r80438): fast/text/hyphenate-character failing in pixel mode
https://bugs.webkit.org/show_bug.cgi?id=56280

Reviewed by Mark Rowe.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::tryHyphenating): Avoid subtracting 1 from an unsigned 0.

5:34 PM Changeset in webkit [80981] by weinig@apple.com
  • 9 edits
    2 adds in trunk/Source

Add ability to create a WKErrorRef
<rdar://problem/9115768>
https://bugs.webkit.org/show_bug.cgi?id=56279

Reviewed by Anders Carlsson.

Source/WebCore:

  • WebCore.exp.in:

Add new exports.

  • platform/network/cf/ResourceError.h:
  • platform/network/cf/ResourceErrorCF.cpp:

(WebCore::ResourceError::platformCompare):
(WebCore::ResourceError::cfError):
(WebCore::ResourceError::operator CFErrorRef):
(WebCore::ResourceError::ResourceError):
(WebCore::ResourceError::cfStreamError):
(WebCore::ResourceError::operator CFStreamError):

  • platform/network/mac/ResourceErrorMac.mm:

(WebCore::ResourceError::ResourceError):
(WebCore::ResourceError::platformCompare):
(WebCore::ResourceError::nsError):
(WebCore::ResourceError::operator NSError *):
(WebCore::ResourceError::cfError):
(WebCore::ResourceError::operator CFErrorRef):
Clean up ResourceError a bit and add ability to create a ResourceError from a CFErrorRef
regardless of whether CFNetwork is being used.

Source/WebKit2:

  • Shared/API/c/cf/WKErrorCF.cpp: Added.

(WKErrorCreateWithCFError):
(WKErrorCopyCFError):

  • Shared/API/c/cf/WKErrorCF.h: Added.

Add new API to create a WKErrorRef from a CFErrorRef
and vice-versa.

  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:

Add new files.

5:34 PM Changeset in webkit [80980] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-13 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed another case of DeprecatedPtr (PutPropertySlot)
https://bugs.webkit.org/show_bug.cgi?id=56278

  • runtime/PutPropertySlot.h: (JSC::PutPropertySlot::setExistingProperty): (JSC::PutPropertySlot::setNewProperty): (JSC::PutPropertySlot::base): Direct pointer is fine for PutPropertySlot, since it's a stack-allocated temporary.
5:31 PM Changeset in webkit [80979] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Add one more failure which is related to change in this range:

http://trac.webkit.org/log/?verbose=on&rev=80866&stop_rev=80860

that I haven't been able to narrow down yet.

  • platform/chromium/test_expectations.txt:
5:31 PM Changeset in webkit [80978] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Add more crashing tests to an existing bug about the same issue
for Chromium Linux Debug.

  • platform/chromium/test_expectations.txt:
5:15 PM Changeset in webkit [80977] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-03-13 Joe Wild <joseph.wild@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QtLauncher does not load the same set of fonts as the DRT
https://bugs.webkit.org/show_bug.cgi?id=34959

This patch adds the option "-use-test-fonts" to the QtTestBrowser.
When this option is used the webkit fonts are loaded the same
as they are in DumpRenderTree. This option can be used on
QtTestBrowser and run-launcher. It can only be used
on Linux systems with FcInit and is configured as such.

  • QtTestBrowser/launcherwindow.h: (WindowOptions::WindowOptions):
  • QtTestBrowser/main.cpp: (initWebKitTestFonts): (launcherMain): (LauncherApplication::handleUserOptions):
5:14 PM Changeset in webkit [80976] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-13 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed one case of DeprecatedPtr (ScopeChainIterator)
https://bugs.webkit.org/show_bug.cgi?id=56277

  • runtime/ScopeChain.h: Direct pointer is fine for ScopeChainIterator, since it's a stack-allocated temporary.
5:10 PM Changeset in webkit [80975] by psolanki@apple.com
  • 15 edits in trunk

Make adjustMIMETypeIfNecessary use CFNetwork directly
https://bugs.webkit.org/show_bug.cgi?id=55912

Reviewed by Brady Eidson.

Source/WebCore:

Convert category method [NSURLResponse adjustMIMETypeIfNecessary] to C function
WebCore::adjustMIMETypeIfNecessary() that takes a CFURLResponseRef and is functionally
identical.

Testing is covered by existing LayoutTests.

  • WebCore.exp.in:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
  • platform/network/mac/ResourceHandleMac.mm:

(-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):

  • platform/network/mac/WebCoreURLResponse.h:
  • platform/network/mac/WebCoreURLResponse.mm:

(WebCore::createBinaryExtensionsSet):
(WebCore::createExtensionToMIMETypeMap):
(WebCore::mimeTypeFromUTITree):
(WebCore::adjustMIMETypeIfNecessary):

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Support for new WKSI functions.

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Support for new WKSI functions.

WebKitLibraries:

Add new WKSI functions needed to implement adjustMIMETypeIfNecessary.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
3:41 PM Changeset in webkit [80974] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Fix the expectation to refer to transitions/default-timing-function.html
instead of bug1318. My change log description also made the same mistake.

  • platform/chromium/test_expectations.txt:
3:37 PM Changeset in webkit [80973] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Sort some test expectations into a better place. Move a linux debug
crash to be near the other instances of it.

Remove fast/text/font-size-zero.html as it appears to be passing consistently.

Add the expectation for bug1318.html due to r80806 changing its output in a way
that looks less optimal than it did before.

  • platform/chromium/test_expectations.txt:
3:11 PM Changeset in webkit [80972] by barraclough@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Bug 56273 - Add three operand forms to MacroAssember operations.

Reviewed by Sam Weinig.

Adding for X86(_64) for now, should be rolled out to other backends as necessary.
These may allow more efficient code generation in some cases, avoiding the need
for unnecessary register-register move instructions.

  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::Jump::link):
(JSC::AbstractMacroAssembler::Jump::linkTo):

  • marked these methods const.

(JSC::AbstractMacroAssembler::Jump::isSet):

  • add a method to check whether a Jump object has been set to reference an instruction, or is in a null, unset state.
  • assembler/MacroAssemblerCodeRef.h:

(JSC::FunctionPtr::FunctionPtr):

  • add non-explicit constructor, for FunctionPtr's to C/C++ functions.
  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::and32):
(JSC::MacroAssemblerX86Common::lshift32):
(JSC::MacroAssemblerX86Common::or32):
(JSC::MacroAssemblerX86Common::rshift32):
(JSC::MacroAssemblerX86Common::urshift32):
(JSC::MacroAssemblerX86Common::xor32):
(JSC::MacroAssemblerX86Common::moveDouble):
(JSC::MacroAssemblerX86Common::addDouble):
(JSC::MacroAssemblerX86Common::divDouble):
(JSC::MacroAssemblerX86Common::subDouble):
(JSC::MacroAssemblerX86Common::mulDouble):
(JSC::MacroAssemblerX86Common::branchTruncateDoubleToInt32):
(JSC::MacroAssemblerX86Common::branchTest32):
(JSC::MacroAssemblerX86Common::branchTest8):
(JSC::MacroAssemblerX86Common::branchAdd32):
(JSC::MacroAssemblerX86Common::branchMul32):
(JSC::MacroAssemblerX86Common::branchSub32):

  • add three operand forms of these instructions.
  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::addDouble):
(JSC::MacroAssemblerX86_64::convertInt32ToDouble):
(JSC::MacroAssemblerX86_64::loadPtr):
(JSC::MacroAssemblerX86_64::branchTestPtr):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::JmpSrc::isSet):

  • add a method to check whether a JmpSrc object has been set to reference an instruction, or is in a null, unset state.

(JSC::X86Assembler::movsd_rr):

  • added FP register-register move.

(JSC::X86Assembler::linkJump):

  • Add an assert to check jumps aren't linked more than once.
  • jit/JITInlineMethods.h:

(JSC::JIT::emitLoadInt32ToDouble):

  • load integers to the FPU via regsiters on x86-64.
3:05 PM Changeset in webkit [80971] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Add some more crashing tests to an existing bug about the same issue
for Chromium Linux Debug.

  • platform/chromium/test_expectations.txt:
2:26 PM Changeset in webkit [80970] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

ARM build fix.

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::load32):

2:16 PM Changeset in webkit [80969] by barraclough@apple.com
  • 21 edits in trunk/Source/JavaScriptCore

Bug 56270 - The JIT 'friend's many classes in JSC; start unwinding this.

Reviewed by Sam Weinig.

The JIT need to 'friend' other classes in order to be able to calculate offsets
of various properties, or the absolute addresses of members within specific objects,
in order to JIT generate code that will access members within the class when run.

Instead of using friends in these cases, switch to providing specific accessor
methods to provide this information. In the case of offsets, these can be static
functions, and in the case of pointers to members within a specific object these can
be const methods returning pointers to const values, to prevent clients from
modifying values otherwise encapsulated within classes.

  • bytecode/SamplingTool.h:
  • interpreter/Register.h:
  • interpreter/RegisterFile.h:
  • runtime/JSArray.h:
  • runtime/JSCell.h:
  • runtime/JSTypeInfo.h:
  • runtime/JSVariableObject.h:
  • runtime/Structure.h:
  • wtf/RefCounted.h:
    • Change these classes to no longer friend the JIT, add accessors for member offsets.
  • jit/JIT.cpp:
  • jit/JITCall32_64.cpp:
  • jit/JITInlineMethods.h:
  • jit/JITOpcodes.cpp:
  • jit/JITOpcodes32_64.cpp:
  • jit/JITPropertyAccess.cpp:
  • jit/JITPropertyAccess32_64.cpp:
    • Change the JIT to use class accessors, rather than taking object ofsets directly.
  • assembler/AbstractMacroAssembler.h:
  • assembler/MacroAssemblerX86_64.h:
  • assembler/X86Assembler.h:
    • Since the accessors for objects members return const pointers to retain encapsulation, methods generating code with absolute addresses must be able to handle const pointers (the JIT doesn't write to these values, do dies treat the pointer to value as const from within the C++ code of the JIT, if not at runtime!).
1:30 PM Changeset in webkit [80968] by mitz@apple.com
  • 4 edits in trunk/Source/WebKit2

WebPageProxy cleanup
https://bugs.webkit.org/show_bug.cgi?id=56267

Reviewed by Darin Adler.

  • UIProcess/WebPageProxy.cpp: Moved all Mac-only function implementations from

here to WebPageProxyMac.mm.

  • UIProcess/WebPageProxy.h: Cleaned up #includes.
  • UIProcess/mac/WebPageProxyMac.mm: Moved all Mac-only function implementations

here.
(WebKit::WebPageProxy::updateWindowIsVisible):
(WebKit::WebPageProxy::windowAndViewFramesChanged):
(WebKit::WebPageProxy::getMarkedRange):
(WebKit::WebPageProxy::characterIndexForPoint):
(WebKit::WebPageProxy::firstRectForCharacterRange):
(WebKit::WebPageProxy::writeSelectionToPasteboard):
(WebKit::WebPageProxy::setDragImage):
(WebKit::WebPageProxy::performDictionaryLookupAtLocation):
(WebKit::WebPageProxy::interpretKeyEvent):
(WebKit::WebPageProxy::sendComplexTextInputToPlugin):
(WebKit::WebPageProxy::uppercaseWord):
(WebKit::WebPageProxy::lowercaseWord):
(WebKit::WebPageProxy::capitalizeWord):
(WebKit::WebPageProxy::setSmartInsertDeleteEnabled):
(WebKit::WebPageProxy::didPerformDictionaryLookup):
(WebKit::WebPageProxy::registerWebProcessAccessibilityToken):
(WebKit::WebPageProxy::registerUIProcessAccessibilityTokens):
(WebKit::WebPageProxy::setComplexTextInputEnabled):

1:28 PM Changeset in webkit [80967] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/8949683> WebKit2: Drag image is offset when the page is scrolled down
https://bugs.webkit.org/show_bug.cgi?id=56265

Reviewed by Darin Adler.

  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::WebDragClient::startDrag): Send the location in view coordinates rather than
document coordinates.

1:24 PM Changeset in webkit [80966] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix a crash when dragging.

Reviewed by Mark Rowe.

  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::convertImageToBitmap): Retain the saved context.

12:46 PM Changeset in webkit [80965] by jeremy@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-13 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Dimitri Glazkov.

Update comment in CSSValueKeywords.in
https://bugs.webkit.org/show_bug.cgi?id=56266

The enums the comment refers to were moved from RenderStyle.h to RenderStyleConstants.h
in r36579 but it appears that the comment in CSSValueKeywords.in wasn't updated.

No tests - just updating a comment.

  • css/CSSValueKeywords.in:
12:07 PM Changeset in webkit [80964] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-13 Anton D'Auria <adauria@apple.com>

Reviewed by Alice Liu.

StorageTracker constructor shouldn't have initialization code and isMainThread() assertion
https://bugs.webkit.org/show_bug.cgi?id=56259

Move all StorageTracker initialization to
StorageTracker::initializeTracker. This also removes the
requirement that the StorageTracker constructor isn't run
on the main thread.

  • storage/StorageTracker.cpp: (WebCore::StorageTracker::initializeTracker): (WebCore::StorageTracker::tracker): (WebCore::StorageTracker::StorageTracker):
11:47 AM Changeset in webkit [80963] by rwlbuis@webkit.org
  • 3 edits
    2 adds in trunk

2011-03-13 Rob Buis <rwlbuis@gmail.com>

Reviewed by Dave Hyatt.

REGRESSION (r61383): Navigation menu laid out incorrectly on aboardtheworld.com
https://bugs.webkit.org/show_bug.cgi?id=53470

Prefer !important over normal properties when dealing with duplicate properties in style rules.

Test: fast/css/duplicate-property-in-rule-important.html

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
11:42 AM Changeset in webkit [80962] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Add expectation (and bug) for test that has failed with an image
mismatch ever since it was added in r80867.

  • platform/chromium/test_expectations.txt:
11:09 AM Changeset in webkit [80961] by levin@chromium.org
  • 5 edits
    11 adds in trunk/LayoutTests

Update test expections due to the OSX specific ex size change done in r80755.

  • platform/chromium-mac/fast/lists/008-expected.checksum: Added.
  • platform/chromium-mac/fast/lists/008-expected.png: Added.
  • platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.checksum: Added.
  • platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.png: Added.
  • platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.checksum: Added.
  • platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.png: Added.
  • platform/chromium-mac/fast/replaced/width100percent-radio-expected.checksum: Added.
  • platform/chromium-mac/fast/replaced/width100percent-radio-expected.png: Added.
  • platform/chromium-mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.checksum: Added.
  • platform/chromium-mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png:
10:04 AM Changeset in webkit [80960] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Fix test expectations due to bad update:

r80820 which limited to win/mac when it still regularly fails on Linux
and it made the test fail with the expectation IMAGE instead of IMAGE+TEXT
as well as occaisionally pass.

  • platform/chromium/test_expectations.txt:
3:07 AM Changeset in webkit [80959] by levin@chromium.org
  • 2 edits
    21 adds in trunk/LayoutTests

Added the following expectations:

fast/backgrounds/background-position-parsing.html new test in r80868
fast/css-generated-content/table-row-before-after.html new test in r80871
fast/table/dynamic-descendant-percentage-height.html new test in r80878

Updated test_expectation to cover a failure due to a missing layout test feature
and added an appropriate bug.

  • platform/chromium-linux/fast/backgrounds/background-position-parsing-expected.checksum: Added.
  • platform/chromium-linux/fast/backgrounds/background-position-parsing-expected.png: Added.
  • platform/chromium-linux/fast/css-generated-content/table-row-before-after-expected.checksum: Added.
  • platform/chromium-linux/fast/css-generated-content/table-row-before-after-expected.png: Added.
  • platform/chromium-linux/fast/table/dynamic-descendant-percentage-height-expected.checksum: Added.
  • platform/chromium-linux/fast/table/dynamic-descendant-percentage-height-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.checksum: Added.
  • platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.png: Added.
  • platform/chromium-mac/fast/css-generated-content/table-row-before-after-expected.checksum: Added.
  • platform/chromium-mac/fast/css-generated-content/table-row-before-after-expected.png: Added.
  • platform/chromium-mac/fast/table/dynamic-descendant-percentage-height-expected.checksum: Added.
  • platform/chromium-mac/fast/table/dynamic-descendant-percentage-height-expected.png: Added.
  • platform/chromium-win/fast/backgrounds/background-position-parsing-expected.checksum: Added.
  • platform/chromium-win/fast/backgrounds/background-position-parsing-expected.png: Added.
  • platform/chromium-win/fast/backgrounds/background-position-parsing-expected.txt: Added.
  • platform/chromium-win/fast/css-generated-content/table-row-before-after-expected.checksum: Added.
  • platform/chromium-win/fast/css-generated-content/table-row-before-after-expected.png: Added.
  • platform/chromium-win/fast/css-generated-content/table-row-before-after-expected.txt: Added.
  • platform/chromium-win/fast/table/dynamic-descendant-percentage-height-expected.checksum: Added.
  • platform/chromium-win/fast/table/dynamic-descendant-percentage-height-expected.png: Added.
  • platform/chromium-win/fast/table/dynamic-descendant-percentage-height-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
1:30 AM Changeset in webkit [80958] by levin@chromium.org
  • 12 edits
    40 adds in trunk/LayoutTests

Update test results due to r80755. All of these tests started failing
on that check in and were given new baselines in that check in.

  • platform/chromium-mac/css1/text_properties/text_indent-expected.checksum: Added.
  • platform/chromium-mac/css1/text_properties/text_indent-expected.png: Added.
  • platform/chromium-mac/css1/units/length_units-expected.checksum: Added.
  • platform/chromium-mac/css1/units/length_units-expected.png: Added.
  • platform/chromium-mac/css2.1/t040302-c61-ex-len-00-b-a-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t040302-c61-ex-len-00-b-a-expected.png: Added.
  • platform/chromium-mac/css2.1/t040302-c61-rel-len-00-b-ag-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t040302-c61-rel-len-00-b-ag-expected.png: Added.
  • platform/chromium-mac/css2.1/t1008-c44-ln-box-02-d-ag-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1008-c44-ln-box-02-d-ag-expected.png: Added.
  • platform/chromium-mac/css2.1/t100801-c544-valgn-01-d-ag-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t100801-c544-valgn-01-d-ag-expected.png: Added.
  • platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.checksum:
  • platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.png: Added.
  • platform/chromium-mac/css2.1/t100801-c548-ln-ht-02-b-ag-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t100801-c548-ln-ht-02-b-ag-expected.png: Added.
  • platform/chromium-mac/css2.1/t1507-c526-font-sz-02-b-a-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1507-c526-font-sz-02-b-a-expected.png: Added.
  • platform/chromium-mac/css2.1/t1601-c547-indent-00-b-a-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1601-c547-indent-00-b-a-expected.png: Added.
  • platform/chromium-mac/css2.1/t1604-c541-word-sp-00-b-a-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Added.
  • platform/chromium-mac/css2.1/t1604-c542-letter-sp-00-b-a-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1604-c542-letter-sp-00-b-a-expected.png: Added.
  • platform/chromium-mac/editing/selection/caret-ltr-2-expected.checksum:
  • platform/chromium-mac/editing/selection/caret-ltr-2-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-2-left-expected.checksum:
  • platform/chromium-mac/editing/selection/caret-ltr-2-left-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-expected.checksum:
  • platform/chromium-mac/editing/selection/caret-ltr-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-right-expected.checksum:
  • platform/chromium-mac/editing/selection/caret-ltr-right-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-2-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-2-expected.png: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.png: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-expected.png: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-right-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-right-expected.png: Added.
  • platform/chromium-mac/fast/block/margin-collapse/103-expected.checksum:
  • platform/chromium-mac/fast/block/margin-collapse/103-expected.png:
  • platform/chromium-mac/fast/css/ex-after-font-variant-expected.checksum: Added.
  • platform/chromium-mac/fast/css/ex-after-font-variant-expected.png: Added.
  • platform/chromium-mac/fast/css/non-standard-checkbox-size-expected.checksum: Added.
  • platform/chromium-mac/fast/css/non-standard-checkbox-size-expected.png: Added.
  • platform/chromium-mac/fast/forms/minWidthPercent-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/minWidthPercent-expected.png: Added.
  • platform/chromium-mac/fast/overflow/overflow-rtl-expected.checksum: Added.
  • platform/chromium-mac/fast/overflow/overflow-rtl-expected.png: Added.

Mar 12, 2011:

11:34 PM Changeset in webkit [80957] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-03-12 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80895.
http://trac.webkit.org/changeset/80895
https://bugs.webkit.org/show_bug.cgi?id=56261

Causing crashes in several tests including
t1202-counters-16-c.html (see
http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80956%20(15528)/results.html)
(Requested by dave_levin on #webkit).

  • rendering/CounterNode.cpp: (WebCore::CounterNode::CounterNode): (WebCore::CounterNode::create): (WebCore::CounterNode::resetRenderer): (WebCore::CounterNode::resetRenderers): (WebCore::CounterNode::recount): (WebCore::CounterNode::insertAfter): (WebCore::CounterNode::removeChild): (WebCore::showTreeAndMark):
  • rendering/CounterNode.h: (WebCore::CounterNode::renderer):
  • rendering/RenderCounter.cpp: (WebCore::findPlaceForCounter): (WebCore::RenderCounter::~RenderCounter): (WebCore::RenderCounter::originalText): (WebCore::RenderCounter::invalidate): (WebCore::destroyCounterNodeWithoutMapRemoval): (WebCore::RenderCounter::destroyCounterNodes): (WebCore::RenderCounter::destroyCounterNode): (WebCore::updateCounters): (showCounterRendererTree):
  • rendering/RenderCounter.h:
  • rendering/RenderObjectChildList.cpp: (WebCore::invalidateCountersInContainer): (WebCore::RenderObjectChildList::invalidateCounters):
  • rendering/RenderObjectChildList.h:
8:19 PM Changeset in webkit [80956] by levin@chromium.org
  • 1 edit
    7 adds in trunk/LayoutTests

Add results for newly added test in r80883.
The differences appear to be very small in keep with the typical
font drawing differences.

  • platform/chromium-linux/fast/multicol/scrolling-overflow-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/scrolling-overflow-expected.png: Added.
  • platform/chromium-mac/fast/multicol/scrolling-overflow-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/scrolling-overflow-expected.png: Added.
  • platform/chromium-win/fast/multicol/scrolling-overflow-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/scrolling-overflow-expected.png: Added.
  • platform/chromium-win/fast/multicol/scrolling-overflow-expected.txt: Added.
8:05 PM Changeset in webkit [80955] by Darin Adler
  • 2 edits in trunk/Source/WebKit2
  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::WebDragClient::startDrag): Fixed typo in a comment.

8:03 PM Changeset in webkit [80954] by levin@chromium.org
  • 1 edit
    1 move in trunk/LayoutTests

r80743 updated the main baseline due to a jsc change.
chromium isn't affected by the change.

  • platform/chromium/fast/js/regexp-caching-expected.txt: Added.

chromium already had a specific baseline for this but it was in chromium-win,
so I moved this result to the more general chromium direction.

  • platform/chromium-win/fast/js/regexp-caching-expected.txt: Removed.
7:46 PM Changeset in webkit [80953] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Remove bad test_expectation updates.

I fixed both of these already:

http://trac.webkit.org/changeset/80911
http://trac.webkit.org/changeset/80904

so it is unclear why they were added.

  • platform/chromium/test_expectations.txt:
7:46 PM Changeset in webkit [80952] by Darin Adler
  • 2 edits in trunk/Source/WebCore

2011-03-12 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

REGRESSION (r76474): IntegerArray hash hashes only 1/4 of the array
https://bugs.webkit.org/show_bug.cgi?id=56258

No tests because the wrong hashing is mostly harmless. The only symptom
we have seen is an occasional assertion in debug builds about the size
not being a multiple of two. But a worse hash is worse for performance too.

  • platform/cf/BinaryPropertyList.cpp: (WebCore::IntegerArrayHash::hash): Pass in the size in bytes rather than the number of array entries.
7:36 PM Changeset in webkit [80951] by cwzwarich@webkit.org
  • 2 edits in trunk/Source/WebCore

Not reviewed.

Fix the build with newer GCCs and remove some extra whitespae.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::uint8_t):

7:24 PM Changeset in webkit [80950] by cwzwarich@webkit.org
  • 2 edits in trunk/Source/WebCore

Rubber-stamped by Oliver Hunt.

Removed unused ARMv5 code. The ARMv5 case now falls under the general
unaligned accessed case.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneDeserializer::readLittleEndian):
(WebCore::CloneDeserializer::readString):

7:18 PM Changeset in webkit [80949] by cwzwarich@webkit.org
  • 2 edits in trunk/Source/WebCore

Reviewed by Oliver Hunt.

WebCore fails to build with Clang on ARM
https://bugs.webkit.org/show_bug.cgi?id=56257

Add an explicit instantiation of writeLittleEndian for uint8_t and move it to
namespace scope, since explicit specializations are not allowed at class scope.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::writeLittleEndian):

7:11 PM Changeset in webkit [80948] by Darin Adler
  • 7 edits in trunk/Source

2011-03-11 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Dragging image to desktop gives webloc instead of image file in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=56193

  • WebCore.exp.in: Added some additional exports. Re-sorted.

2011-03-11 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Dragging image to desktop gives webloc instead of image file in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=56193

  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm: (WebKit::convertImageToBitmap): Added. Factored out from startDrag to make the startDrag code clearer. (WebKit::WebDragClient::startDrag): Streamlined code a bit. (WebKit::cachedImage): Added. Helper for function below. (WebKit::arrayForURLsWithTitles): Added. Helper for function below. (WebKit::WebDragClient::declareAndWriteDragImage): Added code to handle file promises and removed a log of uneeded code. (-[WKPasteboardFilePromiseOwner copyDropDirectory]): Added. (promisedDataClient): Added. (-[WKPasteboardOwner clearImage]): Added. (-[WKPasteboardOwner initWithImage:]): Added. (-[WKPasteboardOwner dealloc]): Added. (-[WKPasteboardOwner finalize]): Added. (-[WKPasteboardOwner pasteboard:provideDataForType:]): Added. (-[WKPasteboardOwner pasteboardChangedOwner:]): Added. (matchesExtensionOrEquivalent): Added. (-[WKPasteboardOwner namesOfPromisedFilesDroppedAtDestination:]): Added. Much of the new code above came from the WebKit1 drag code.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::dragEnded): Added call to Mac-only platformDragEnded.
  • WebProcess/WebPage/WebPage.h: Added Mac-only platformDragEnded and m_dragSource.
  • WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::setDragSource): Added. (WebKit::WebPage::platformDragEnded): Added.
2:32 PM Changeset in webkit [80947] by mitz@apple.com
  • 2 edits in trunk/Tools

<rdar://problem/8995822> Build DumpRenderTree perl support only for the architectures
DumpRenderTree is being built for.

Reviewed by Mark Rowe.

  • DumpRenderTree/mac/PerlSupport/Makefile:
2:15 PM Changeset in webkit [80946] by mrowe@apple.com
  • 7 edits in trunk/Source

Fix the 32-bit build.

Source/WebKit/mac:

  • Carbon/CarbonWindowAdapter.mm:

(-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]): Use a more appropriate format specifier.
(-[CarbonWindowAdapter _carbonWindowClass]): Ditto.

Source/WebKit2:

This involves hacking around some HIToolbox headers that do things of dubious correctness,
and fixing the usual CGRect vs NSRect issues.

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController enterFullScreen:]): NSRect is not CGRect.

  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:

(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.

1:42 PM Changeset in webkit [80945] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2
  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::url):
Get the URL from the loader, not from the document.

Reviewed by Sam Weinig.

(WebKit::WebFrame::suggestedFilenameForResourceWithURL):
Return the correct suggested filename for the main resource.

(WebKit::WebFrame::mimeTypeForResourceWithURL):
Return the correct mime type for the main resource.

1:30 PM Changeset in webkit [80944] by mitz@apple.com
  • 2 edits in trunk/Tools

Suggested by Mark Rowe.

  • DumpRenderTree/mac/Configurations/Base.xcconfig: Leave C++ exceptions enabled

as they were before r80915.

12:43 PM Changeset in webkit [80943] by andersca@apple.com
  • 12 edits in trunk

2011-03-12 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Should be able to download a PDF to the Downloads folder
https://bugs.webkit.org/show_bug.cgi?id=56256

  • UIProcess/API/C/WKPage.h: Add WKPageSaveDataToFileInDownloadsFolderCallback to the UI client.
  • UIProcess/API/mac/PDFViewController.h:
  • UIProcess/API/mac/PDFViewController.mm: (-[WKPDFView _applyPDFPreferences]): (-[WKPDFView _updatePreferences:]): Use new PDFViewController::page getter.

(-[WKPDFView PDFViewSavePDFToDownloadFolder:]):
Call PDFViewController::savePDFToDownloadsFolder.

(WebKit::releaseCFData):
(WebKit::PDFViewController::savePDFToDownloadsFolder):
Create a WebData that wraps the CFData, then pass it along to
WebPageProxy::saveDataToFileInDownloadsFolder.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::saveDataToFileInDownloadsFolder): Call WebUIClient::saveDataToFileInDownloadsFolder.

(WebKit::WebUIClient::saveDataToFileInDownloadsFolder):

  • UIProcess/WebUIClient.h: Call the UI client callback function.

2011-03-12 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Should be able to download a PDF to the Downloads folder
https://bugs.webkit.org/show_bug.cgi?id=56256

  • MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController awakeFromNib]):
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::initialize): Update for API changes.
11:34 AM Changeset in webkit [80942] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-12 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

WebData should be able to wrap already existing data
https://bugs.webkit.org/show_bug.cgi?id=56254

  • Shared/WebData.h: (WebKit::WebData::createWithoutCopying): (WebKit::WebData::create): (WebKit::WebData::~WebData): (WebKit::WebData::bytes): (WebKit::WebData::size): (WebKit::WebData::WebData): (WebKit::WebData::fastFreeBytes):
10:14 AM Changeset in webkit [80941] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-12 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

WebKit2: Initialize the WebFullScreenManagerProxy with a WKView
https://bugs.webkit.org/show_bug.cgi?id=56250

  • UIProcess/API/mac/WKView.mm: (-[WKView initWithFrame:contextRef:pageGroupRef:]): Call fullScreenManager()->setView(self).
8:44 AM Changeset in webkit [80940] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-12 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed. Update chromium expectations.

  • platform/chromium/test_expectations.txt:
8:07 AM Changeset in webkit [80939] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-12 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed. Update chromium test expectations.

  • platform/chromium/test_expectations.txt:
7:54 AM Changeset in webkit [80938] by loislo@chromium.org
  • 33 edits in trunk/Source

2011-03-12 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80919.
http://trac.webkit.org/changeset/80919
https://bugs.webkit.org/show_bug.cgi?id=56251

all windows bots failed to compile this change (Requested by
loislo on #webkit).

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/StructureStubInfo.cpp:
  • interpreter/Register.h: (JSC::Register::withInt): (JSC::Register::withCallee): (JSC::Register::operator=): (JSC::Register::i): (JSC::Register::activation): (JSC::Register::function): (JSC::Register::propertyNameIterator): (JSC::Register::scopeChain):
  • jit/JIT.h:
  • jit/JITCall.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCallVarargs): (JSC::JIT::compileOpCall):
  • jit/JITCall32_64.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCallVarargs): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
  • jit/JITInlineMethods.h: (JSC::JIT::emitPutToCallFrameHeader):
  • jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTINativeCall): (JSC::JIT::emit_op_get_pnames): (JSC::JIT::emit_op_next_pname): (JSC::JIT::emit_op_load_varargs): (JSC::JIT::emitSlow_op_load_varargs):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::privateCompileCTINativeCall): (JSC::JIT::emit_op_get_pnames): (JSC::JIT::emit_op_next_pname):
  • jit/JSInterfaceJIT.h: (JSC::JSInterfaceJIT::payloadFor):
  • jit/SpecializedThunkJIT.h: (JSC::SpecializedThunkJIT::returnJSValue): (JSC::SpecializedThunkJIT::returnDouble): (JSC::SpecializedThunkJIT::returnInt32): (JSC::SpecializedThunkJIT::returnJSCell):
  • runtime/ArgList.cpp:
  • runtime/DateConversion.cpp:
  • runtime/GCActivityCallbackCF.cpp:
  • runtime/Identifier.cpp:
  • runtime/JSActivation.h: (JSC::asActivation):
  • runtime/JSLock.cpp:
  • runtime/JSNumberCell.cpp:
  • runtime/JSObject.h:
  • runtime/JSPropertyNameIterator.h:
  • runtime/JSValue.h:
  • runtime/JSZombie.cpp:
  • runtime/MarkedBlock.cpp:
  • runtime/MarkedSpace.cpp:
  • runtime/PropertyNameArray.cpp:
  • runtime/ScopeChain.h: (JSC::ExecState::globalThisValue):
  • wtf/DateMath.cpp:

2011-03-12 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80919.
http://trac.webkit.org/changeset/80919
https://bugs.webkit.org/show_bug.cgi?id=56251

all windows bots failed to compile this change (Requested by
loislo on #webkit).

  • bridge/c/c_class.cpp:
  • bridge/c/c_runtime.cpp:
  • bridge/jni/JavaMethod.cpp:
  • plugins/PluginViewNone.cpp:
7:47 AM Changeset in webkit [80937] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-03-12 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE build fix for r80900.

  • CMakeListsWinCE.txt: Removed IconDatabaseNone.cpp.
7:38 AM Changeset in webkit [80936] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-12 Andras Becsi <abecsi@webkit.org>

Unreviewed typo fix.

No new tests needed.

  • WebCore.pro: Fix typo in header name.
6:44 AM Changeset in webkit [80935] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-12 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed. Update chromium test expectations.

  • platform/chromium/test_expectations.txt:
4:55 AM Fingerprinting edited by robert@roberthogan.net
(diff)
4:00 AM Changeset in webkit [80934] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-12 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: Inspect Element action regression fix.

3:53 AM Changeset in webkit [80933] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-12 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed. One line fix for inspector/dom-breakpoints.html

  • inspector/front-end/BreakpointManager.js: (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement.decorateNode):
3:26 AM Changeset in webkit [80932] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-12 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed build fix.

Almost all inspector tests are crashing after r80928.

  • inspector/front-end/inspector.js:
1:10 AM Changeset in webkit [80931] by pfeldman@chromium.org
  • 27 edits in trunk

2011-03-11 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: follow up to error reporting, fixing multiple regressions.
https://bugs.webkit.org/show_bug.cgi?id=56243

  • inspector/elements/elements-panel-search.html:

2011-03-11 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: follow up to error reporting, fixing multiple regressions.
https://bugs.webkit.org/show_bug.cgi?id=56243

  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::setPropertyValue):
  • inspector/InjectedScript.h:
  • inspector/Inspector.idl:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getChildNodes): (WebCore::InspectorDOMAgent::getOuterHTML): (WebCore::InspectorDOMAgent::getEventListenersForNode):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::setPropertyValue):
  • inspector/InspectorRuntimeAgent.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype.setNodeName): (WebInspector.DOMNode.prototype.setNodeValue): (WebInspector.DOMNode.prototype.getChildNodes): (WebInspector.DOMNode.prototype.getOuterHTML): (WebInspector.DOMNode.prototype.setOuterHTML): (WebInspector.DOMNode.prototype.removeNode): (WebInspector.DOMNode.prototype.copyNode): (WebInspector.DOMAgent.prototype.pushNodeToFrontend): (WebInspector.DOMAgent.prototype.pushNodeByPathToFrontend): (WebInspector.EventListeners.getEventListenersForNode):
  • inspector/front-end/DOMStorage.js: (WebInspector.DOMStorage.prototype.getEntries): (WebInspector.DOMStorage.prototype.setItem): (WebInspector.DOMStorage.prototype.removeItem):
  • inspector/front-end/DOMStorageItemsView.js: (WebInspector.DOMStorageItemsView.prototype.update): (WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip): (WebInspector.ElementsTreeElement.prototype.updateChildren): ():
  • inspector/front-end/EventListenersSidebarPane.js: (WebInspector.EventListenersSidebarPane.prototype.update.callback): (WebInspector.EventListenersSidebarPane.prototype.update):
  • inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression.callback): (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression):
  • inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.nodeResolved):
  • inspector/front-end/RemoteObject.js: (WebInspector.RemoteObject.prototype.setPropertyValue): (WebInspector.RemoteObject.prototype.evaluate):
  • inspector/front-end/inspector.js:
12:24 AM Changeset in webkit [80930] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix.

Fix GTK+ builds by wrapping sections of full screen code in USE(ACCELERATED_COMPOSITING)
checks.

  • dom/Document.cpp:

(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidEnterFullScreenForElement):
(WebCore::Document::webkitWillExitFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):

12:07 AM Changeset in webkit [80929] by commit-queue@webkit.org
  • 5 edits in trunk/Source

2011-03-12 Ryuan Choi <ryuan.choi@samsung.com>

Unreviewed build fix.

[EFL] Fix build break because of several reason.
https://bugs.webkit.org/show_bug.cgi?id=56244

  • CMakeLists.txt: Add missing files.
  • platform/posix/FileSystemPOSIX.cpp: Add PLATFORM(EFL).

2011-03-12 Ryuan Choi <ryuan.choi@samsung.com>

Unreviewed build fix.

[EFL] Fix build break because of several reason.
https://bugs.webkit.org/show_bug.cgi?id=56244

  • ewk/ewk_settings.cpp: (ewk_settings_icon_database_path_set):

Mar 11, 2011:

11:21 PM Changeset in webkit [80928] by yurys@chromium.org
  • 12 edits in trunk/Source

2011-03-11 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move profiler related methods from inspector agent to profiler agent
https://bugs.webkit.org/show_bug.cgi?id=56204

  • inspector/Inspector.idl:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::restoreInspectorStateFromCookie): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::populateScriptObjects): (WebCore::InspectorAgent::showProfilesPanel):
  • inspector/InspectorAgent.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::profilerEnabled): (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::stopUserInitiatedProfiling): (WebCore::InspectorController::isRecordingUserInitiatedProfile):
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::profilerEnabledImpl):
  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::create): (WebCore::InspectorProfilerAgent::InspectorProfilerAgent): (WebCore::InspectorProfilerAgent::enable): (WebCore::InspectorProfilerAgent::disable): (WebCore::InspectorProfilerAgent::setFrontend): (WebCore::InspectorProfilerAgent::clearFrontend): (WebCore::InspectorProfilerAgent::restore): (WebCore::InspectorProfilerAgent::restoreEnablement): (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling): (WebCore::InspectorProfilerAgent::stopUserInitiatedProfiling):
  • inspector/InspectorProfilerAgent.h: (WebCore::InspectorProfilerAgent::start): (WebCore::InspectorProfilerAgent::stop):
  • inspector/front-end/ProfileView.js: (WebInspector.CPUProfileType.prototype.buttonClicked):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel): (WebInspector.ProfilesPanel.prototype._registerProfileType): (WebInspector.ProfilesPanel.prototype._toggleProfiling):
  • inspector/front-end/inspector.js: (WebInspector._createPanels):
9:38 PM Changeset in webkit [80927] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

2011-03-11 Anton D'Auria <adauria@apple.com>

Reviewed by Brady Eidson.

Adding StorageTracker tests to skip lists of platforms that don't support it.
https://bugs.webkit.org/show_bug.cgi?id=51878

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
9:28 PM Changeset in webkit [80926] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

2011-03-11 Jer Noble <jer.noble@apple.com>

Reviewed by Anders Carlsson.

WebCore::Document should notify ChromeClient when the full screen renderer's backing changes.
https://bugs.webkit.org/show_bug.cgi?id=56226

  • dom/Document.cpp: (WebCore::Document::webkitWillEnterFullScreenForElement): Call setRootFullScreenLayer(). (WebCore::Document::webkitDidEnterFullScreenForElement): Ditto. (WebCore::Document::webkitWillExitFullScreenForElement): Ditto. (WebCore::Document::webkitDidExitFullScreenForElement): Ditto. (WebCore::Document::setFullScreenRendererSize): Layout after setting the renderer's size.
9:16 PM Changeset in webkit [80925] by jer.noble@apple.com
  • 4 edits
    3 adds in trunk/Source/WebKit2

2011-03-11 Jer Noble <jer.noble@apple.com>

Reviewed by Anders Carlsson.

Add full screen animation code to WebFullScreenManager.
https://bugs.webkit.org/show_bug.cgi?id=56220

  • WebProcess/FullScreen/WebFullScreenManager.cpp: . (WebKit::WebFullScreenManager::~WebFullScreenManager): Added. (WebKit::WebFullScreenManager::exitFullScreenForElement): Remove ASSERTs. (WebKit::WebFullScreenManager::willEnterFullScreen): Set the full screen renderer's background color. (WebKit::WebFullScreenManager::didEnterFullScreen): Ditto. (WebKit::WebFullScreenManager::willExitFullScreen): Ditto. (WebKit::WebFullScreenManager::didExitFullScreen): Ditto.
  • WebProcess/FullScreen/WebFullScreenManager.h: Make a few functions pure virtual to be implemented in a

concrete subclass.

  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.h: Added.
  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: Added. (-[WebFullScreenManagerAnimationListener initWithManager:WebKit::began:finished:]): Listener for CAAnimations. (-[WebFullScreenManagerAnimationListener animationDidStart:]): Added. (-[WebFullScreenManagerAnimationListener animationDidStop:finished:]): Added. (-[WebFullScreenManagerAnimationListener invalidate]): Added. (WebKit::WebFullScreenManager::create): Now creates a WebFullScreenManagerMac. (WebKit::WebFullScreenManagerMac::create): Added. (WebKit::WebFullScreenManagerMac::WebFullScreenManagerMac): Added. (WebKit::WebFullScreenManagerMac::~WebFullScreenManagerMac): Added. (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): Set up the remote layer host. (WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation): Create a CATransform3D

which will animate the full screen renderer from its initial position to its final one.

(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.

8:52 PM Changeset in webkit [80924] by jer.noble@apple.com
  • 5 edits
    1 add in trunk/Source/WebKit2

2011-03-11 Jer Noble <jer.noble@apple.com>

Reviewed by Anders Carlsson.

Add full screen animation code to WebFullScreenManager.
https://bugs.webkit.org/show_bug.cgi?id=56220

  • WebProcess/FullScreen/WebFullScreenManager.cpp: . (WebKit::WebFullScreenManager::~WebFullScreenManager): Added. (WebKit::WebFullScreenManager::exitFullScreenForElement): Remove ASSERTs. (WebKit::WebFullScreenManager::willEnterFullScreen): Set the full screen renderer's background color. (WebKit::WebFullScreenManager::didEnterFullScreen): Ditto. (WebKit::WebFullScreenManager::willExitFullScreen): Ditto. (WebKit::WebFullScreenManager::didExitFullScreen): Ditto.
  • WebProcess/FullScreen/WebFullScreenManager.h: Make a few functions pure virtual to be implemented in a

concrete subclass.

  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.h: Added.
  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: Added. (-[WebFullScreenManagerAnimationListener initWithManager:WebKit::began:finished:]): Listener for CAAnimations. (-[WebFullScreenManagerAnimationListener animationDidStart:]): Added. (-[WebFullScreenManagerAnimationListener animationDidStop:finished:]): Added. (-[WebFullScreenManagerAnimationListener invalidate]): Added. (WebKit::WebFullScreenManager::create): Now creates a WebFullScreenManagerMac. (WebKit::WebFullScreenManagerMac::create): Added. (WebKit::WebFullScreenManagerMac::WebFullScreenManagerMac): Added. (WebKit::WebFullScreenManagerMac::~WebFullScreenManagerMac): Added. (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): Set up the remote layer host. (WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation): Create a CATransform3D

which will animate the full screen renderer from its initial position to its final one.

(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.

8:19 PM Changeset in webkit [80923] by jer.noble@apple.com
  • 4 edits
    1 copy
    1 add in trunk/Source

2011-03-11 Jer Noble <jer.noble@apple.com>

Reviewed by Anders Carlsson.

Add full screen animation code to WebFullScreenManager.
https://bugs.webkit.org/show_bug.cgi?id=56220

  • WebProcess/FullScreen/WebFullScreenManager.cpp: . (WebKit::WebFullScreenManager::~WebFullScreenManager): Added. (WebKit::WebFullScreenManager::exitFullScreenForElement): Remove ASSERTs. (WebKit::WebFullScreenManager::willEnterFullScreen): Set the full screen renderer's background color. (WebKit::WebFullScreenManager::didEnterFullScreen): Ditto. (WebKit::WebFullScreenManager::willExitFullScreen): Ditto. (WebKit::WebFullScreenManager::didExitFullScreen): Ditto.
  • WebProcess/FullScreen/WebFullScreenManager.h: Make a few functions pure virtual to be implemented in a

concrete subclass.

  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.h: Added.
  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: Added. (-[WebFullScreenManagerAnimationListener initWithManager:WebKit::began:finished:]): Listener for CAAnimations. (-[WebFullScreenManagerAnimationListener animationDidStart:]): Added. (-[WebFullScreenManagerAnimationListener animationDidStop:finished:]): Added. (-[WebFullScreenManagerAnimationListener invalidate]): Added. (WebKit::WebFullScreenManager::create): Now creates a WebFullScreenManagerMac. (WebKit::WebFullScreenManagerMac::create): Added. (WebKit::WebFullScreenManagerMac::WebFullScreenManagerMac): Added. (WebKit::WebFullScreenManagerMac::~WebFullScreenManagerMac): Added. (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): Set up the remote layer host. (WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation): Create a CATransform3D

which will animate the full screen renderer from its initial position to its final one.

(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.

8:01 PM Changeset in webkit [80922] by jer.noble@apple.com
  • 13 edits in trunk/Source

2011-03-11 Jer Noble <jer.noble@apple.com>

Reviewed by Anders Carlsson.

WebCore::Document should notify ChromeClient when the full screen renderer's backing changes.
https://bugs.webkit.org/show_bug.cgi?id=56226

  • dom/Document.cpp: (WebCore::Document::webkitWillEnterFullScreenForElement): Call setRootFullScreenLayer(). (WebCore::Document::webkitDidEnterFullScreenForElement): Ditto. (WebCore::Document::webkitWillExitFullScreenForElement): Ditto. (WebCore::Document::webkitDidExitFullScreenForElement): Ditto. (WebCore::Document::setFullScreenRendererSize): Layout after setting the renderer's size.

2011-03-11 Jer Noble <jer.noble@apple.com>

Reviewed by Anders Carlsson.

Add full screen animation code to WebFullScreenManager.
https://bugs.webkit.org/show_bug.cgi?id=56220

  • WebProcess/FullScreen/WebFullScreenManager.cpp: . (WebKit::WebFullScreenManager::~WebFullScreenManager): Added. (WebKit::WebFullScreenManager::exitFullScreenForElement): Remove ASSERTs. (WebKit::WebFullScreenManager::willEnterFullScreen): Set the full screen renderer's background color. (WebKit::WebFullScreenManager::didEnterFullScreen): Ditto. (WebKit::WebFullScreenManager::willExitFullScreen): Ditto. (WebKit::WebFullScreenManager::didExitFullScreen): Ditto.
  • WebProcess/FullScreen/WebFullScreenManager.h: Make a few functions pure virtual to be implemented in a

concrete subclass.

  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.h: Added.
  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: Added. (-[WebFullScreenManagerAnimationListener initWithManager:WebKit::began:finished:]): Listener for CAAnimations. (-[WebFullScreenManagerAnimationListener animationDidStart:]): Added. (-[WebFullScreenManagerAnimationListener animationDidStop:finished:]): Added. (-[WebFullScreenManagerAnimationListener invalidate]): Added. (WebKit::WebFullScreenManager::create): Now creates a WebFullScreenManagerMac. (WebKit::WebFullScreenManagerMac::create): Added. (WebKit::WebFullScreenManagerMac::WebFullScreenManagerMac): Added. (WebKit::WebFullScreenManagerMac::~WebFullScreenManagerMac): Added. (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): Set up the remote layer host. (WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation): Create a CATransform3D

which will animate the full screen renderer from its initial position to its final one.

(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.

7:35 PM Changeset in webkit [80921] by alice.liu@apple.com
  • 2 edits in trunk/Source/WebKit2

Support encoding /decoding WebData in usermessages
https://bugs.webkit.org/show_bug.cgi?id=56158

Reviewed by Sam Weinig.

Added encoding/decoding for APIObject::TypeData

  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):

7:32 PM Changeset in webkit [80920] by alice.liu@apple.com
  • 5 edits in trunk/Source/WebKit2

Add api for "remove" to WKMutableDictionary
https://bugs.webkit.org/show_bug.cgi?id=56157

Reviewed by Sam Weinig.

  • Shared/API/c/WKMutableDictionary.cpp:

(WKDictionaryRemoveItem): Added; call remove on MutableDictionary impl.

  • Shared/API/c/WKMutableDictionary.h:
  • Shared/MutableDictionary.cpp:

(WebKit::MutableDictionary::remove): Added; call remove on the underlying hashmap.

  • Shared/MutableDictionary.h:
7:12 PM Changeset in webkit [80919] by oliver@apple.com
  • 33 edits in trunk/Source

2011-03-11 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Ensure all values are correctly tagged in the registerfile
https://bugs.webkit.org/show_bug.cgi?id=56214

This patch makes sure that all JSCell pointers written to
the registerfile are correctly tagged as JSCells, and replaces
raw int usage with the immediate representation.

For performance, register pressure, and general saneness reasons
I've added abstractions for reading and writing the tag
and payload of integer registers directly for the JSVALUE64
encoding.

  • interpreter/Register.h: (JSC::Register::withInt): (JSC::Register::withCallee): (JSC::Register::operator=): (JSC::Register::i): (JSC::Register::activation): (JSC::Register::function): (JSC::Register::propertyNameIterator): (JSC::Register::scopeChain):
  • jit/JIT.h:
  • jit/JITCall.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCallVarargs): (JSC::JIT::compileOpCall):
  • jit/JITCall32_64.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCallVarargs): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
  • jit/JITInlineMethods.h: (JSC::JIT::emitPutToCallFrameHeader): (JSC::JIT::emitPutCellToCallFrameHeader): (JSC::JIT::emitPutIntToCallFrameHeader):
  • jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTINativeCall): (JSC::JIT::emit_op_get_pnames): (JSC::JIT::emit_op_next_pname): (JSC::JIT::emit_op_load_varargs): (JSC::JIT::emitSlow_op_load_varargs):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::privateCompileCTINativeCall): (JSC::JIT::emit_op_get_pnames): (JSC::JIT::emit_op_next_pname):
  • jit/JSInterfaceJIT.h: (JSC::JSInterfaceJIT::intPayloadFor): (JSC::JSInterfaceJIT::intTagFor):
  • jit/SpecializedThunkJIT.h: (JSC::SpecializedThunkJIT::returnJSValue): (JSC::SpecializedThunkJIT::returnDouble): (JSC::SpecializedThunkJIT::returnInt32): (JSC::SpecializedThunkJIT::returnJSCell):

2011-03-11 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Ensure all values are correctly tagged in the registerfile
https://bugs.webkit.org/show_bug.cgi?id=56214

Make sure everything builds still.

  • bridge/c/c_class.cpp:
  • bridge/c/c_runtime.cpp:
  • bridge/jni/JavaMethod.cpp:
  • plugins/PluginViewNone.cpp:
6:38 PM Changeset in webkit [80918] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the 32-bit build.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):

6:24 PM Changeset in webkit [80917] by rniwa@webkit.org
  • 10 edits
    2 deletes in trunk/Source/WebKit2

2011-03-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80899 and r80912.
http://trac.webkit.org/changeset/80899
http://trac.webkit.org/changeset/80912
https://bugs.webkit.org/show_bug.cgi?id=56236

Caused animation tests to crash on Snow Leopard WebKit2
(Requested by rniwa on #webkit).

  • Shared/ShareableBitmap.cpp: (WebKit::ShareableBitmap::create): (WebKit::ShareableBitmap::createShareable): (WebKit::ShareableBitmap::resize):
  • Shared/ShareableBitmap.h: (WebKit::ShareableBitmap::numBytesForSize): (WebKit::ShareableBitmap::sizeInBytes):
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::update):
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::didUpdate):
  • WebProcess/WebPage/DrawingArea.messages.in:
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::~DrawingAreaImpl): (WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState): (WebKit::DrawingAreaImpl::didUpdate): (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): (WebKit::DrawingAreaImpl::display):
  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/SharedMemoryCache.cpp: Removed.
  • WebProcess/WebPage/SharedMemoryCache.h: Removed.
  • win/WebKit2.vcproj:
6:13 PM Changeset in webkit [80916] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/9124537> Crashes during layout tests due to overrelease of AVFoundation objects.

Rubber-stamped by Eric Carlsson.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createContextVideoRenderer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setAsset):

6:13 PM Changeset in webkit [80915] by mrowe@apple.com
  • 10 edits in trunk

Adopt the LLVM Compiler for debug builds.

Rubber-stamped by Adam Roben and Sam Weinig.

5:53 PM Rebaseline edited by mihaip@chromium.org
(diff)
5:49 PM Changeset in webkit [80914] by levin@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Rollout the chromium deps roll as it adds a dependency on a header
that the bots building for WebKit don't seem to have.

Specifically gfx\gl\gl_context_egl.cc depends on d3dcompiler.h

  • DEPS:
5:46 PM Changeset in webkit [80913] by cmarrin@apple.com
  • 2 edits in trunk/Source/WebCore

2011-03-11 Chris Marrin <cmarrin@apple.com>

Unreviewed.

Fixes an error with the checkin for https://bugs.webkit.org/show_bug.cgi?id=52468

  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
5:45 PM Changeset in webkit [80912] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebKit2

Windows build fix. Add SharedMemoryCache to the vcproj.

  • win/WebKit2.vcproj:
5:41 PM Changeset in webkit [80911] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Fix prototype-inheritance-expected result due to two changes:

http://src.chromium.org/viewvc/chrome?view=rev&revision=77888 removed "google"
http://trac.webkit.org/changeset/80846 added WebKitAnimation/WebKitAnimationList

  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
5:35 PM Changeset in webkit [80910] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Attempted Qt build fix for https://bugs.webkit.org/show_bug.cgi?id=56216

  • loader/icon/IconDatabase.h: Make this guy public.
5:23 PM Changeset in webkit [80909] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Attempted Qt build fix for https://bugs.webkit.org/show_bug.cgi?id=56216

  • loader/icon/IconDatabase.h:

(WebCore::IconDatabase::delayDatabaseCleanup): Maybe Qt has Icon Database disabled, so we need to define this here?

5:21 PM Changeset in webkit [80908] by beidson@apple.com
  • 3 edits in trunk/Source/WebKit/win

More Windows build fix for https://bugs.webkit.org/show_bug.cgi?id=56216

  • WebCoreStatistics.cpp:
  • WebIconDatabase.cpp:
5:07 PM Changeset in webkit [80907] by dcheng@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-11 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Correct return type of WebClipboard::readImage.
https://bugs.webkit.org/show_bug.cgi?id=56234

Update the return type to reflect that we are returning a blob of PNG
data, not a bitmap.

  • public/WebClipboard.h: (WebKit::WebClipboard::readImage):
5:05 PM Changeset in webkit [80906] by Dimitri Glazkov
  • 4 edits in trunk/Source/JavaScriptCore

2011-03-11 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

Introduce project_dir variable and make paths a whole lot saner. Ok, a little bit saner.
https://bugs.webkit.org/show_bug.cgi?id=56231

  • JavaScriptCore.gypi: Added project_dir variable.
  • gyp/JavaScriptCore.gyp: Changed to use project_dir, rather than DEPTH/JavaScriptCore.
  • gyp/generate-dtrace-header.sh: Changed to use project_dir.
4:45 PM Changeset in webkit [80905] by beidson@apple.com
  • 6 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=56216
Fix the Qt build following the same pattern of the patch.

../WebCore:

  • loader/icon/IconDatabase.h:
  • loader/icon/IconDatabaseBase.cpp:

(WebCore::IconDatabaseBase::databasePath): Added to the virtual base.

  • loader/icon/IconDatabaseBase.h:

(WebCore::IconDatabaseBase::isOpen): Ditto.

../WebKit/qt:

Reviewed by attempt at build fix!

  • Api/qwebsettings.cpp:

(QWebSettings::setIconDatabasePath): Call the static method via IconDatabase:: and not via iconDatabase()

4:39 PM Changeset in webkit [80904] by levin@chromium.org
  • 7 edits in trunk

Source/WebKit/chromium: Update chromium deps to pick up the skia roll.

  • DEPS:

LayoutTests: Update some baselines due to Skia update in Chromium.
Filed http://crbug.com/75820 about the odd look of the results (but
the odd look previously existed).

  • platform/chromium-linux/svg/css/composite-shadow-text-expected.checksum:
  • platform/chromium-linux/svg/css/composite-shadow-text-expected.png:
  • platform/chromium-win/svg/css/composite-shadow-text-expected.checksum:
  • platform/chromium-win/svg/css/composite-shadow-text-expected.png:
4:34 PM Changeset in webkit [80903] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-11 Ben Taylor <bentaylor.solx86@gmail.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=56198
Fix conditional which had an int for one case and a pointer for another.

No new tests. Fix compilation on Solaris 10 with SunStudio 12 C++

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
4:29 PM Changeset in webkit [80902] by beidson@apple.com
  • 3 edits in trunk/Source/WebCore

Windows build fix.

  • history/HistoryItem.cpp:
  • loader/icon/IconDatabaseBase.cpp:
4:25 PM Changeset in webkit [80901] by ap@apple.com
  • 9 edits in trunk/Source/WebKit2

2011-03-11 Alexey Proskuryakov <ap@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=56222
A window remains frozen if web process crashes during printing

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setComplexTextInputEnabled):
  • UIProcess/WebPageProxy.h: Moved setAutodisplay code into WKPrintingView.
  • UIProcess/API/mac/WKPrintingView.h:
  • UIProcess/API/mac/WKView.mm: (-[WKView printOperationWithPrintInfo:forFrame:]): Keep a reference to the actual WKView, so that we can manipulate how it displays, even if page goes away.
  • UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView initWithFrameProxy:WebKit::view:]): (-[WKPrintingView _setAutodisplay:]): (-[WKPrintingView _suspendAutodisplay]): (-[WKPrintingView _delayedResumeAutodisplayTimerFired]): Move setAutodisplay here.
4:17 PM Changeset in webkit [80900] by beidson@apple.com
  • 13 edits
    2 adds
    1 delete in trunk/Source

<rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56216
Rework disabled IconDatabase builds while allowing for a pluggable icon database implementation.

../WebCore:

Reviewed by Sam Weinig.

Project file stuff:

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCore.vcproj/WebCore.vcproj:
  • loader/icon/IconDatabase.cpp:
  • loader/icon/IconDatabase.h: Inherit from IconDatabaseBase.
  • loader/icon/IconDatabaseBase.cpp: Added.

(WebCore::IconDatabaseBase::iconURLForPageURL):
(WebCore::iconDatabase):
(WebCore::setGlobalIconDatabase):

  • loader/icon/IconDatabaseBase.h: Added.

(WebCore::IconDatabaseBase::IconDatabaseBase):
(WebCore::IconDatabaseBase::~IconDatabaseBase):
(WebCore::IconDatabaseBase::setEnabled):
(WebCore::IconDatabaseBase::isEnabled):
(WebCore::IconDatabaseBase::defaultIcon):
(WebCore::IconDatabaseBase::retainIconForPageURL):
(WebCore::IconDatabaseBase::releaseIconForPageURL):
(WebCore::IconDatabaseBase::iconForPageURL):
(WebCore::IconDatabaseBase::setIconURLForPageURL):
(WebCore::IconDatabaseBase::setIconDataForIconURL):
(WebCore::IconDatabaseBase::iconDataKnownForIconURL):
(WebCore::IconDatabaseBase::loadDecisionForIconURL):
(WebCore::IconDatabaseBase::pageURLMappingCount):
(WebCore::IconDatabaseBase::retainedPageURLCount):
(WebCore::IconDatabaseBase::iconRecordCount):
(WebCore::IconDatabaseBase::iconRecordCountWithData):
(WebCore::IconDatabaseBase::importIconURLForPageURL):
(WebCore::IconDatabaseBase::importIconDataForIconURL):
(WebCore::IconDatabaseBase::shouldStopThreadActivity):
(WebCore::IconDatabaseBase::open):
(WebCore::IconDatabaseBase::close):
(WebCore::IconDatabaseBase::removeAllIcons):
(WebCore::IconDatabaseBase::setPrivateBrowsingEnabled):
(WebCore::IconDatabaseBase::setClient):

  • loader/icon/IconDatabaseNone.cpp: Removed.

../WebKit/mac:

Reviewed by Anders Carlsson

  • Misc/WebIconDatabase.mm:

(+[WebIconDatabase _checkIntegrityBeforeOpening]): Call these static methods on IconDatabase::, not iconDatabase().
(-[WebIconDatabase _startUpIconDatabase]): Ditto.
(importToWebCoreFormat):

4:12 PM Changeset in webkit [80899] by andersca@apple.com
  • 9 edits
    2 adds in trunk/Source/WebKit2

2011-03-11 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add a shared memory cache to the web process
https://bugs.webkit.org/show_bug.cgi?id=56232

Add a very simple shared memory cache to the web process, so that we don't have to allocate and
free memory over and over when painting.

  • Shared/ShareableBitmap.cpp: (WebKit::ShareableBitmap::create): (WebKit::ShareableBitmap::createShareable): (WebKit::ShareableBitmap::resize):
  • Shared/ShareableBitmap.h: (WebKit::ShareableBitmap::numBytesNeededForBitmapSize): (WebKit::ShareableBitmap::sizeInBytes): Rename numBytesForSize to numBytesNeededForBitmapSize.
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::update): Always send back a DidUpdate message, even if we didn't use the update info. This is needed so that the web process knows when the UI process is done with the shared memory inside the update info struct.
  • WebKit2.xcodeproj/project.pbxproj: Add new files.
  • WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::didUpdate):
  • WebProcess/WebPage/DrawingArea.messages.in: DidUpdate now takes a boolean.
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::sharedMemoryCache): Add shared memory cache.

(WebKit::DrawingAreaImpl::~DrawingAreaImpl):
Return the shared memory to the cache.

(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState):
display now takes an extra boolean.

(WebKit::DrawingAreaImpl::didUpdate):
Return the shared memory to the cache.

(WebKit::DrawingAreaImpl::display):
If useSharedMemoryCache is true, get shared memory from the cache.

  • WebProcess/WebPage/SharedMemoryCache.cpp: Added. (WebKit::SharedMemoryCache::acquireSharedMemory): If the memory we currently hold on to is big enough, return it.

(WebKit::SharedMemoryCache::releaseSharedMemory):
If we're already holding on to shared memory, evict it if the returned
shared memory object is bigger than the one we currently hold.

(WebKit::SharedMemoryCache::clearCacheTimerFired):
Null out the shared memory object.

4:07 PM Changeset in webkit [80898] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Attempt at a build-fix for https://bugs.webkit.org/show_bug.cgi?id=51878

  • page/PageGroup.h: Declare this method, even if the definition will end up being empty.
3:57 PM Changeset in webkit [80897] by Michael Nordman
  • 2 edits in trunk/Source/WebCore

2011-03-11 Michael Nordman <Michael Nordman>

Reviewed by Dmitry Titov.

Adding the '~' to the dtor (duh).

No new tests.

  • storage/SQLCallbackWrapper.h: (WebCore::SQLCallbackWrapper::~SQLCallbackWrapper):
3:44 PM Changeset in webkit [80896] by ericu@chromium.org
  • 4 edits
    1 copy
    12 adds in trunk/LayoutTests

2010-3-11 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Add tests for FileWriter
https://bugs.webkit.org/show_bug.cgi?id=44363

Fix small bugs in the utility functions and add setFileContents().

  • fast/filesystem/resources/file-writer-utils.js:

Port the GC Blob test over to the new FileWriter utilities.

  • fast/filesystem/file-writer-gc-blob-expected.txt:
  • fast/filesystem/file-writer-gc-blob.html:
  • fast/filesystem/resources/file-writer-gc-blob.js: Copied from LayoutTests/fast/filesystem/file-writer-gc-blob.html.

Add tests for progress events and overlapping writes [via seek].

  • fast/filesystem/file-writer-events-expected.txt: Added.
  • fast/filesystem/file-writer-events.html: Added.
  • fast/filesystem/resources/file-writer-events.js: Added.
  • fast/filesystem/file-writer-write-overlapped-expected.txt: Added.
  • fast/filesystem/file-writer-write-overlapped.html: Added.
  • fast/filesystem/resources/file-writer-write-overlapped.js: Added.

Worker versions of the above tests.

  • fast/filesystem/workers/file-writer-events-expected.txt: Added.
  • fast/filesystem/workers/file-writer-events.html: Added.
  • fast/filesystem/workers/file-writer-gc-blob-expected.html: Added.
  • fast/filesystem/workers/file-writer-gc-blob.html: Added.
  • fast/filesystem/workers/file-writer-write-overlapped-expected.html: Added.
  • fast/filesystem/workers/file-writer-write-overlapped.html: Added.
3:41 PM Changeset in webkit [80895] by carol.szabo@nokia.com
  • 7 edits in trunk/Source/WebCore

2011-03-11 Carol Szabo <carol.szabo@nokia.com>

Reviewed by David Hyatt.

Introduced double linkage between a CounterNode and its display renderer.

use of freed pointer in WebCore::RenderCounter::originalText()
https://bugs.webkit.org/show_bug.cgi?id=56065

No new tests. This bug could only be reproduced manually by
refreshing the page during load at a critical point.
See bug attachment for testing.

  • rendering/CounterNode.cpp: Introduced new member "m_owner" to store the renderer that has the style directives that produce the CounterNode. Repurposed m_renderer to reffer to the RenderCounter that shows the CounterNode. (WebCore::CounterNode::CounterNode): Updated member initialization. (WebCore::CounterNode::create): (WebCore::CounterNode::resetRenderer): (WebCore::CounterNode::resetRenderers): (WebCore::CounterNode::recount): (WebCore::CounterNode::removeChild): (WebCore::CounterNode::insertAfter): No functional changes. (WebCore::showTreeAndMark): Added flushing to ensure that the output is complete.
  • rendering/CounterNode.h: (WebCore::CounterNode::owner): Renamed from renderer() (WebCore::CounterNode::renderer): (WebCore::CounterNode::setRenderer): Added new accessors for the display renderer.
  • rendering/RenderCounter.cpp: (WebCore::findPlaceForCounter): Fixed comments. No functional changes. (WebCore::RenderCounter::~RenderCounter): Made sure that the CounterNode that this renderers displays is detached from this. (WebCore::RenderCounter::originalText): (WebCore::RenderCounter::invalidate): Added code to update m_renderer on the displayed CounterNode. (WebCore::destroyCounterNodeWithoutMapRemoval): (WebCore::RenderCounter::destroyCounterNodes): (WebCore::RenderCounter::destroyCounterNode): (WebCore::updateCounters): No change, just kept code in line with the changes above. (showCounterRendererTree): Added fflush to ensure complete display.
  • rendering/RenderCounter.h:
  • rendering/RenderObjectChildList.cpp:
  • rendering/RenderObjectChildList.h: Removed unneeded invalidateCounters related functions.
3:39 PM Changeset in webkit [80894] by enne@google.com
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-11 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

Add missing unit tests to TilingData.
https://bugs.webkit.org/show_bug.cgi?id=54143

  • tests/TilingDataTest.cpp: (WebCore::TEST):
3:34 PM Changeset in webkit [80893] by Dimitri Glazkov
  • 9 edits
    2 adds in trunk/Source/WebCore

2011-03-11 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Introduce lookup-table based approach for applying CSS properties.
The aim is to be a starting point for refactoring
CSSStyleSelector::applyProperty() into more readable, maintainable code.
https://bugs.webkit.org/show_bug.cgi?id=54707

No new behavior / covered by existing tests.

  • css/CSSStyleApplyProperty.cpp: Added. (WebCore::ApplyPropertyNull): Class that provides empty implementations of inherit, initial, value. (WebCore::ApplyPropertyDefault::ApplyPropertyDefault): Class that calls the appropriate RenderStyle setters directly. (WebCore::ApplyPropertyColorBase::ApplyPropertyColorBase): Class for handling CSSProperty*Color. (WebCore::ApplyPropertyColor::ApplyPropertyColor): Class for handling CSSPropertyColor. (WebCore::CSSStyleApplyProperty::sharedCSSStyleApplyProperty): Singleton initializer. (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Constructor that bulds up the map from property id to apply-er objects.
  • css/CSSStyleApplyProperty.h: Added. (WebCore::CSSStyleApplyProperty::inherit): Handle the inherit case for a given property. (WebCore::CSSStyleApplyProperty::initial): Handle the initial case for a given property. (WebCore::CSSStyleApplyProperty::value): Apply a value to a given property. (WebCore::CSSStyleApplyProperty::implements): Returns true if the provided property id is implemented. (WebCore::CSSStyleApplyProperty::index): Private function to determine the index of a property the property map. (WebCore::CSSStyleApplyProperty::valid): Function to determine that a given property id is valid. (WebCore::CSSStyleApplyProperty::setPropertyValue): (WebCore::CSSStyleApplyProperty::propertyValue):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): Get reference to the CSSStyleApplyProperty singleton. (WebCore::CSSStyleSelector::applyProperty): Now calls into CSSStyleApplyProperty for implemented property ids. Deleted color-related methods from the property id switch.
  • css/CSSStyleSelector.h: (WebCore::CSSStyleSelector::style): Made public to allow access from CSSStyleApplyProperty. (WebCore::CSSStyleSelector::parentStyle): Made public to allow access from CSSStyleApplyProperty.
  • rendering/style/RenderStyle.h: Made CSSStyleApplyProperty a friend class. Necessary because it needs to access the private getters and setters on this clsass.
3:24 PM Changeset in webkit [80892] by beidson@apple.com
  • 46 edits
    21 adds in trunk

Reviewed and landed by Brady Eidson.

Source/WebCore:

Patch by Anton D'Auria <adauria@apple.com> on 2011-03-11
Add WebKit1 API to view and delete local storage
https://bugs.webkit.org/show_bug.cgi?id=51878

Created StorageTracker as a central point for tracking and deleting LocalStorage per origin.
StorageTracker maintains its own database of origin identifiers and backing db paths,
and this allows it to contain more relational data in the future, like variable quotas per origin.

On initialization, StorageTracker syncs its database with LocalStorage files on disk. It adds
an origin entry when StorageAreaSync performs a first sync for an origin.

All StorageTracker file operations are performed on one background thread with a task queue.

Tests: storage/domstorage/localstorage/storagetracker/storage-tracker-1-prepare.html

storage/domstorage/localstorage/storagetracker/storage-tracker-2-create.html
storage/domstorage/localstorage/storagetracker/storage-tracker-3-delete-all.html
storage/domstorage/localstorage/storagetracker/storage-tracker-4-create.html
storage/domstorage/localstorage/storagetracker/storage-tracker-5-delete-one.html

  • GNUmakefile.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/PageGroup.cpp:

(WebCore::PageGroup::clearLocalStorageForAllOrigins):
(WebCore::PageGroup::clearLocalStorageForOrigin):
(WebCore::PageGroup::syncLocalStorage):
(WebCore::PageGroup::numberOfPageGroups):

  • page/PageGroup.h:
  • platform/chromium/FileSystemChromium.cpp:

(WebCore::listDirectory):

  • platform/posix/FileSystemPOSIX.cpp:

(WebCore::listDirectory):

  • storage/LocalStorageTask.cpp:

(WebCore::LocalStorageTask::LocalStorageTask):
(WebCore::LocalStorageTask::performTask):

  • storage/LocalStorageTask.h:

(WebCore::LocalStorageTask::createOriginIdentifiersImport):
(WebCore::LocalStorageTask::createSetOriginDetails):
(WebCore::LocalStorageTask::createDeleteOrigin):
(WebCore::LocalStorageTask::createDeleteAllOrigins):

  • storage/StorageAreaImpl.cpp:

(WebCore::StorageAreaImpl::clearForOriginDeletion):
(WebCore::StorageAreaImpl::sync):

  • storage/StorageAreaImpl.h:
  • storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::scheduleCloseDatabase):
(WebCore::StorageAreaSync::openDatabase):
(WebCore::StorageAreaSync::sync):
(WebCore::StorageAreaSync::deleteEmptyDatabase):
(WebCore::StorageAreaSync::scheduleSync):

  • storage/StorageAreaSync.h:
  • storage/StorageNamespace.h:
  • storage/StorageNamespaceImpl.cpp:

(WebCore::StorageNamespaceImpl::clearOriginForDeletion):
(WebCore::StorageNamespaceImpl::clearAllOriginsForDeletion):
(WebCore::StorageNamespaceImpl::sync):

  • storage/StorageNamespaceImpl.h:
  • storage/StorageTracker.cpp: Added.

(WebCore::StorageTracker::initializeTracker):
(WebCore::StorageTracker::tracker):
(WebCore::StorageTracker::StorageTracker):
(WebCore::StorageTracker::setStorageDirectoryPath):
(WebCore::StorageTracker::trackerDatabasePath):
(WebCore::StorageTracker::openTrackerDatabase):
(WebCore::StorageTracker::importOriginIdentifiers):
(WebCore::StorageTracker::syncImportOriginIdentifiers):
(WebCore::StorageTracker::syncFileSystemAndTrackerDatabase):
(WebCore::StorageTracker::setOriginDetails):
(WebCore::StorageTracker::scheduleTask):
(WebCore::StorageTracker::syncSetOriginDetails):
(WebCore::StorageTracker::origins):
(WebCore::StorageTracker::deleteAllOrigins):
(WebCore::StorageTracker::syncDeleteAllOrigins):
(WebCore::StorageTracker::deleteOrigin):
(WebCore::StorageTracker::syncDeleteOrigin):
(WebCore::StorageTracker::willDeleteAllOrigins):
(WebCore::StorageTracker::willDeleteOrigin):
(WebCore::StorageTracker::canDeleteOrigin):
(WebCore::StorageTracker::cancelDeletingOrigin):
(WebCore::StorageTracker::setClient):
(WebCore::StorageTracker::syncLocalStorage):

  • storage/StorageTracker.h: Added.
  • storage/StorageTrackerClient.h: Added.

(WebCore::StorageTrackerClient::~StorageTrackerClient):

Source/WebKit:

Patch by Anton D'Auria <adauria@apple.com> on 2011-03-11
Add WebKit1 API to view and delete local storage
https://bugs.webkit.org/show_bug.cgi?id=51878

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/chromium:

Patch by Anton D'Auria <adauria@apple.com> on 2011-03-11
Add WebKit1 API to view and delete local storage
https://bugs.webkit.org/show_bug.cgi?id=51878

  • src/StorageNamespaceProxy.cpp:

(WebCore::StorageNamespaceProxy::clearOriginForDeletion):
(WebCore::StorageNamespaceProxy::clearAllOriginsForDeletion):
(WebCore::StorageNamespaceProxy::sync):

  • src/StorageNamespaceProxy.h:

Source/WebKit/mac:

Patch by Anton D'Auria <adauria@apple.com> on 2011-03-11
https://bugs.webkit.org/show_bug.cgi?id=51878
Add WebKit1 API to view and delete local storage

  • Storage/WebStorageManager.mm: Added.

(+[WebStorageManager sharedWebStorageManager]):
(-[WebStorageManager origins]):
(-[WebStorageManager deleteAllOrigins]):
(-[WebStorageManager deleteOrigin:]):
(-[WebStorageManager syncLocalStorage]):
(-[WebStorageManager syncFileSystemAndTrackerDatabase]):
(storageDirectoryPath):
(WebKitInitializeStorageIfNecessary):

  • Storage/WebStorageManagerInternal.h: Added.
  • Storage/WebStorageManagerPrivate.h: Added.
  • Storage/WebStorageTrackerClient.h: Added.
  • Storage/WebStorageTrackerClient.mm: Added.

(WebStorageTrackerClient::sharedWebStorageTrackerClient):
(WebStorageTrackerClient::WebStorageTrackerClient):
(WebStorageTrackerClient::~WebStorageTrackerClient):
(WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread):
(WebStorageTrackerClient::dispatchDidModifyOrigin):

  • WebCoreSupport/WebSecurityOrigin.mm:

(-[WebSecurityOrigin protocol]):
(-[WebSecurityOrigin host]):
(-[WebSecurityOrigin databaseIdentifier]):
(-[WebSecurityOrigin domain]):
(-[WebSecurityOrigin _initWithWebCoreSecurityOrigin:]):

  • WebCoreSupport/WebSecurityOriginPrivate.h:
  • WebKit.exp:
  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):

Tools:

Patch by Anton D'Auria <adauria@apple.com> on 2011-03-11
https://bugs.webkit.org/show_bug.cgi?id=51878
Add WebKit1 API to view and delete local storage

Added tests that write to LocalStorage, delete one origin, get list of origins with local storage, delete all origins.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/LayoutTestController.cpp:

(syncLocalStorageCallback):
(observeStorageTrackerNotificationsCallback):
(deleteAllLocalStorageCallback):
(deleteLocalStorageForOriginCallback):
(originsWithLocalStorageCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/StorageTrackerDelegate.h: Added.
  • DumpRenderTree/StorageTrackerDelegate.mm: Added.

(-[StorageTrackerDelegate init]):
(-[StorageTrackerDelegate logNotifications:controller:]):
(-[StorageTrackerDelegate originModified:]):
(-[StorageTrackerDelegate dealloc]):
(-[StorageTrackerDelegate setControllerToNotifyDone:]):

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::deleteAllLocalStorage):
(LayoutTestController::originsWithLocalStorage):
(LayoutTestController::deleteLocalStorageForOrigin):
(observeStorageTrackerNotifications):
(syncLocalStorage):

  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::originsWithLocalStorage):
(LayoutTestController::deleteAllLocalStorage):
(LayoutTestController::deleteLocalStorageForOrigin):
(LayoutTestController::observeStorageTrackerNotifications):
(LayoutTestController::syncLocalStorage):

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):
(allocateGlobalControllers):
(releaseGlobalControllers):

  • DumpRenderTree/mac/DumpRenderTreeMac.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::syncLocalStorage):
(LayoutTestController::observeStorageTrackerNotifications):
(LayoutTestController::deleteAllLocalStorage):
(LayoutTestController::originsWithLocalStorage):
(LayoutTestController::deleteLocalStorageForOrigin):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::originsWithLocalStorage):
(LayoutTestController::deleteAllLocalStorage):
(LayoutTestController::deleteLocalStorageForOrigin):
(LayoutTestController::observeStorageTrackerNotifications):
(LayoutTestController::syncLocalStorage):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::clearAllApplicationCaches):
(LayoutTestController::syncLocalStorage):
(LayoutTestController::observeStorageTrackerNotifications):
(LayoutTestController::clearAllDatabases):
(LayoutTestController::deleteAllLocalStorage):
(LayoutTestController::originsWithLocalStorage):
(LayoutTestController::deleteLocalStorageForOrigin):

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::syncLocalStorage):
(LayoutTestController::observeStorageTrackerNotifications):
(LayoutTestController::clearAllDatabases):
(LayoutTestController::deleteAllLocalStorage):
(LayoutTestController::originsWithLocalStorage):
(LayoutTestController::deleteLocalStorageForOrigin):

LayoutTests:

Patch by Anton D'Auria <adauria@apple.com> on 2011-03-11
Add WebKit1 API to view and delete local storage
https://bugs.webkit.org/show_bug.cgi?id=51878

  • platform/chromium/test_expectations.txt:
  • storage/domstorage/localstorage/storagetracker: Added.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-1-prepare-expected.txt: Added.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-1-prepare.html: Added.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-2-create-expected.txt: Added.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-2-create.html: Added.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-3-delete-all-expected.txt: Added.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-3-delete-all.html: Added.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-4-create-expected.txt: Added.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-4-create.html: Added.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-5-delete-one-expected.txt: Added.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-5-delete-one.html: Added.
3:19 PM Changeset in webkit [80891] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

http/tests/websocket/tests/url-with-credential.html sometimes crashes beneath SocketStreamHandle::readStreamCallback on Windows
https://bugs.webkit.org/show_bug.cgi?id=56185

url-parsing.html appears to be causing the crashes in later tests.
Skipping the url-parsing.html test and unskipping the url-with-credential.html test.

Unreviewed.

  • platform/win/Skipped:
3:15 PM Changeset in webkit [80890] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-03-11 Dominic Mazzoni <dmazzoni@google.com>

Reviewed by Dimitri Glazkov.

Add an accessibilityIsIgnored method to WebAccessibilityObject.
https://bugs.webkit.org/show_bug.cgi?id=50969

  • public/WebAccessibilityObject.h:
  • src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::accessibilityIsIgnored):
2:55 PM Changeset in webkit [80889] by rniwa@webkit.org
  • 5 edits
    12 deletes in trunk/LayoutTests

2011-03-11 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

drag-text-delay.html should be a dump as text test
https://bugs.webkit.org/show_bug.cgi?id=56223

Converted the test to a dump as text. Also reorganized the test code and added more descriptions.

  • editing/selection/drag-text-delay-expected.txt:
  • editing/selection/drag-text-delay.html:
  • platform/chromium-linux/editing/selection/drag-text-delay-expected.checksum: Removed.
  • platform/chromium-linux/editing/selection/drag-text-delay-expected.png: Removed.
  • platform/chromium-win/editing/selection/drag-text-delay-expected.checksum: Removed.
  • platform/chromium-win/editing/selection/drag-text-delay-expected.png: Removed.
  • platform/chromium-win/editing/selection/drag-text-delay-expected.txt: Removed.
  • platform/gtk/editing/selection/drag-text-delay-expected.checksum: Removed.
  • platform/gtk/editing/selection/drag-text-delay-expected.png: Removed.
  • platform/gtk/editing/selection/drag-text-delay-expected.txt: Removed.
  • platform/mac/editing/selection/drag-text-delay-expected.checksum: Removed.
  • platform/mac/editing/selection/drag-text-delay-expected.png: Removed.
  • platform/mac/editing/selection/drag-text-delay-expected.txt:
  • platform/win/editing/selection/drag-text-delay-expected.checksum: Removed.
  • platform/win/editing/selection/drag-text-delay-expected.png: Removed.
  • platform/win/editing/selection/drag-text-delay-expected.txt:
2:53 PM Changeset in webkit [80888] by steveblock@google.com
  • 2 edits in trunk/Source/WebCore

2011-03-11 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

JavaMethod does not correctly check for a null jstring for the method name
https://bugs.webkit.org/show_bug.cgi?id=56187

No new tests, simple typo fix.

  • bridge/jni/JavaMethod.cpp: (JavaMethod::JavaMethod):
2:50 PM Changeset in webkit [80887] by enne@google.com
  • 2 edits in trunk/Source/WebCore

2011-03-11 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Compositor uses too much texture memory for scrollbars
https://bugs.webkit.org/show_bug.cgi?id=56212

Compositor invalidations can be off the page (and very large), but
scrollbars only need to care about the invalidation that's visible.
The large invalidation was causing the tiler layer size to grow
needlessly larger than the scrollbar.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::invalidateRootLayerRect):
2:44 PM Changeset in webkit [80886] by mihaip@chromium.org
  • 8 edits
    1 add
    1 delete in trunk/LayoutTests

2011-03-11 Mihai Parparita <mihaip@chromium.org>

Chromium Mac expectations update. Rebaseline some more tests after
r80582.

  • fast/repaint/text-emphasis-h-expected.checksum:
  • fast/repaint/text-emphasis-h-expected.png:
  • platform/chromium-mac/fast/repaint/text-emphasis-h-expected.txt: Removed.
  • platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.checksum:
  • platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.png:
  • platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.checksum:
  • platform/mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.png:
2:20 PM Changeset in webkit [80885] by mihaip@chromium.org
  • 31 edits
    4 deletes in trunk/LayoutTests

2011-03-11 Mihai Parparita <mihaip@chromium.org>

Chromium Mac expectations update. Rebaseline some tests after r80582
(those that already had chromium-mac-leopard baselines).

  • platform/chromium-mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/border-vertical-lr-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/border-vertical-lr-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-lr-selection-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/blockflow/japanese-lr-selection-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/blockflow/japanese-lr-text-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-lr-text-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-rl-selection-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-rl-selection-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-rl-text-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-rl-text-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/vertical-align-table-baseline-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/vertical-align-table-baseline-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/vertical-font-fallback-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/vertical-font-fallback-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-clear-expected.checksum:
  • platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-clear-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-expected.checksum:
  • platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum:
  • platform/chromium-mac-leopard/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.txt:
  • platform/chromium-mac/fast/blockflow/japanese-lr-selection-expected.checksum: Removed.
  • platform/chromium-mac/fast/blockflow/japanese-lr-selection-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/fast/blockflow/japanese-lr-selection-expected.checksum:
  • platform/mac-leopard/fast/blockflow/japanese-lr-selection-expected.png:
2:10 PM Changeset in webkit [80884] by jberlin@webkit.org
  • 5 edits
    1 add in trunk

Crash calling WebContext::clearResourceCaches(InMemoryResourceCachesOnly) before the Web
Process has finished launching.
https://bugs.webkit.org/show_bug.cgi?id=56208

Reviewed by Adam Roben.

Source/WebKit2:

Only send the message if the Web Process is valid.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::clearResourceCaches):

Tools:

  • TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Added.

(TestWebKitAPI::TEST):
Test that calling WKContextClearResourceCaches works with both options when called before
the Web Process is valid.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

Add the new test.

  • TestWebKitAPI/win/TestWebKitAPI.vcproj:

Ditto.

2:08 PM Changeset in webkit [80883] by hyatt@apple.com
  • 3 edits
    4 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=52987

Reviewed by Simon Fraser.

REGRESSION: Overflowing columns not repainted correctly

Make sure to add in column overflow as visual overflow as well. It was only propagating layout overflow, which is obviously not
sufficient, since blocks paint their own columns.

Added fast/multicol/scrolling-overflow.html

Source/WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addOverflowFromChildren):

LayoutTests:

  • fast/multicol/scrolling-overflow.html: Added.
  • platform/mac/fast/multicol/scrolling-overflow-expected.checksum: Added.
  • platform/mac/fast/multicol/scrolling-overflow-expected.png: Added.
  • platform/mac/fast/multicol/scrolling-overflow-expected.txt: Added.
1:59 PM Changeset in webkit [80882] by Dimitri Glazkov
  • 4 edits in trunk/Source/JavaScriptCore

2011-03-11 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

Start using derived sources correctly and link minidom with JavaScriptCore gyp project.
https://bugs.webkit.org/show_bug.cgi?id=56217

  • gyp/JavaScriptCore.gyp: Added derived source files and passing of shared directory

to the scripts.

  • gyp/generate-derived-sources.sh: Changed to use passed directory.
  • gyp/generate-dtrace-header.sh: Ditto.
1:34 PM Changeset in webkit [80881] by mihaip@chromium.org
  • 6 edits in trunk/LayoutTests

2011-03-11 Mihai Parparita <mihaip@chromium.org>

Mac and Chromium expectations update. Remove failing expectations for
tests that no longer fail. Rebaseline fast/overflow/
overflow-rtl-vertical.html and fast/lists/008-vertical.html after
r80755.

  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/lists/008-vertical-expected.checksum:
  • platform/mac/fast/lists/008-vertical-expected.png:
  • platform/mac/fast/overflow/overflow-rtl-vertical-expected.checksum:
  • platform/mac/fast/overflow/overflow-rtl-vertical-expected.png:
1:25 PM Changeset in webkit [80880] by mdelaney@apple.com
  • 2 edits in trunk/Source/WebCore

2011-03-11 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Set canvasUsesAcceleratedDrawing setting to be off(false) by default
https://bugs.webkit.org/show_bug.cgi?id=56215

No new tests. Does not affect behavior. Just keeping the setting off by default.

  • page/Settings.cpp: (WebCore::Settings::Settings):
1:22 PM Changeset in webkit [80879] by mihaip@chromium.org
  • 2 edits
    4 moves in trunk/LayoutTests

2011-03-11 Mihai Parparita <mihaip@chromium.org>

Update Chromium expectations. Remove some commented out lines and
promote some expectatiosn from chromium-mac to mac-leopard, so that
those tests pass on chromium Snow Leopard (and mac Leopard).

  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/fast/block/basic/percent-height-inside-anonymous-block-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/block/basic/percent-height-inside-anonymous-block-expected.checksum.
  • platform/mac-leopard/fast/block/basic/percent-height-inside-anonymous-block-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/block/basic/percent-height-inside-anonymous-block-expected.png.
  • platform/mac-leopard/fast/block/positioning/static-distance-with-positioned-ancestor-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/block/positioning/static-distance-with-positioned-ancestor-expected.checksum.
  • platform/mac-leopard/fast/block/positioning/static-distance-with-positioned-ancestor-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/block/positioning/static-distance-with-positioned-ancestor-expected.png.
1:21 PM Changeset in webkit [80878] by aestes@apple.com
  • 5 edits
    4 adds in trunk

2011-03-11 Andy Estes <aestes@apple.com>

Reviewed by David Hyatt.

Table cells with dynamically added percentage height descendants do not
grow in size if the table has already been laid out.
https://bugs.webkit.org/show_bug.cgi?id=56174


Table cells ignore their specified size and collapse to fit their
children. When a descendent with percentage height is present before
the table is first laid out, the descendent is sized based on the
specified size of the table cell. However, when the child isn't present
when the table is first laid out, the table cell ignores its specified
size and collapses down to 0. Then, when the child div is added in a
separate run loop iteration, it is sized to be 100% of the collapsed
cell height instead of 100% of the cell's specified height. We should
not get different layouts depending on the timing of tree construction.


Fix this by clearing intrinsic padding before calculating the table
cell's override height when we detect a child that should flex the
table cell.

Test: fast/table/dynamic-descendant-percentage-height.html

  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::setOverrideSizeFromRowHeight): clear intrinsic padding before setting the override size.
  • rendering/RenderTableCell.h:
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layoutRows): Call setOverrideSizeFromRowHeight() instead of setOverrideSize().

2011-03-11 Andy Estes <aestes@apple.com>

Reviewed by David Hyatt.

Table cells with dynamically added percentage height descendants do not
grow in size if the table has already been laid out.
https://bugs.webkit.org/show_bug.cgi?id=56174

  • fast/table/dynamic-descendant-percentage-height.html: Added.
  • platform/mac/fast/table/dynamic-descendant-percentage-height-expected.checksum: Added.
  • platform/mac/fast/table/dynamic-descendant-percentage-height-expected.png: Added.
  • platform/mac/fast/table/dynamic-descendant-percentage-height-expected.txt: Added.
1:15 PM Changeset in webkit [80877] by hyatt@apple.com
  • 1 edit in trunk/Source/WebCore/css/CSSParser.cpp

Fix Windows build bustage.

1:09 PM Changeset in webkit [80876] by Michael Nordman
  • 10 edits
    1 add in trunk/Source/WebCore

2011-03-11 Michael Nordman <Michael Nordman>

Reviewed by David Levin.

Add SQLCallbackWrapper
Instead of directly holding RefPtrs to the Callback objects in SQLStatement and SQLTransaction, hold a wrapper objects
which holds those references whose dtors will schedule the release of those references on the ScriptExecution thread.
https://bugs.webkit.org/show_bug.cgi?id=55919

No new tests, existing tests apply.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • storage/SQLCallbackWrapper.h: Added. (WebCore::SQLCallbackWrapper::SQLCallbackWrapper): (WebCore::SQLCallbackWrapper::clear): (WebCore::SQLCallbackWrapper::unwrap): (WebCore::SQLCallbackWrapper::hasCallback): (WebCore::SQLCallbackWrapper::safeRelease):
  • storage/SQLStatement.cpp: (WebCore::SQLStatement::create): (WebCore::SQLStatement::SQLStatement): (WebCore::SQLStatement::performCallback):
  • storage/SQLStatement.h: (WebCore::SQLStatement::hasStatementCallback): (WebCore::SQLStatement::hasStatementErrorCallback):
  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::SQLTransaction): (WebCore::SQLTransaction::executeSQL): (WebCore::SQLTransaction::checkAndHandleClosedOrInterruptedDatabase): (WebCore::SQLTransaction::deliverTransactionCallback): (WebCore::SQLTransaction::deliverStatementCallback): (WebCore::SQLTransaction::postflightAndCommit): (WebCore::SQLTransaction::deliverSuccessCallback): (WebCore::SQLTransaction::handleTransactionError): (WebCore::SQLTransaction::deliverTransactionErrorCallback):
  • storage/SQLTransaction.h:
12:52 PM Changeset in webkit [80875] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-03-11 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Don't paint more than 60 times per second
https://bugs.webkit.org/show_bug.cgi?id=56206
<rdar://problem/9085989>

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::DrawingAreaImpl): Initialize m_lastDisplayTime to 0. Change the display timer to call displayTimerFired.

(WebKit::DrawingAreaImpl::didUpdate):
Call displayTimerFired instead of display.

(WebKit::DrawingAreaImpl::displayTimerFired):
If we're asked to paint again less than 1/60th of a second after we've already painted,
defer painting.

(WebKit::DrawingAreaImpl::display):
Update m_lastDisplayTime.

12:48 PM Changeset in webkit [80874] by eric.carlson@apple.com
  • 7 edits
    5 adds in trunk/Source

2011-03-11 Eric Carlson <eric.carlson@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/8955589> Adopt AVFoundation media back end on Lion.

No new tests, existing media tests cover this.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/MediaPlayer.cpp: (WebCore::installedMediaEngines): Register MediaPlayerPrivateAVFoundationObjC. (WebCore::bestMediaEngineForTypeAndCodecs): Kill some whitespace. (WebCore::MediaPlayer::loadWithNextMediaEngine): Ditto. (WebCore::MediaPlayer::inMediaDocument): Ditto.
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/avfoundation: Added.
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: Added.
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h: Added.
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h: Added.
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: Added.

2011-03-11 Eric Carlson <eric.carlson@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/8955589> Adopt AVFoundation media back end on Lion.

No new tests, existing media tests cover this.

  • JavaScriptCore.exp: Export cancelCallOnMainThread
  • wtf/Platform.h: Define WTF_USE_AVFOUNDATION.
12:27 PM Changeset in webkit [80873] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

2011-03-11 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=56205
m_restrictions needs to allow multiple values (a bitfield)

HTMLMediaElement::m_restrictions needs to hold multiple values, so
change BehaviorRestrictions to an unsigned typedef and rename the
existing enum BehaviorRestrictionFlags.

  • html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::setBehaviorRestrictions):
12:23 PM Changeset in webkit [80872] by Dimitri Glazkov
  • 12 edits in trunk/LayoutTests

2011-03-11 Dimitri Glazkov <Dimitri Glazkov>

[GTK] Update expectations after r80857.
https://bugs.webkit.org/show_bug.cgi?id=55972

  • platform/gtk/media/audio-controls-rendering-expected.txt:
  • platform/gtk/media/audio-repaint-expected.txt:
  • platform/gtk/media/controls-strict-expected.txt:
  • platform/gtk/media/controls-styling-expected.txt:
  • platform/gtk/media/controls-without-preload-expected.txt:
  • platform/gtk/media/media-document-audio-repaint-expected.txt:
  • platform/gtk/media/video-controls-rendering-expected.txt:
  • platform/gtk/media/video-empty-source-expected.txt:
  • platform/gtk/media/video-no-audio-expected.txt:
  • platform/gtk/media/video-volume-slider-expected.txt:
  • platform/gtk/media/video-zoom-controls-expected.txt:
12:13 PM Changeset in webkit [80871] by hyatt@apple.com
  • 4 edits
    4 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=47206

Reviewed by Dan Bernstein.

Table rows don't support ::before/::after. Add support to RenderTableRow::styleDidChange so that ::before/::after content gets
properly constructed.

Added fast/css-generated-content/table-row-before-after.html

Source/WebCore:

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::styleDidChange):

  • rendering/RenderTableRow.h:

LayoutTests:

  • fast/css-generated-content/table-row-before-after.html: Added.
  • platform/mac/fast/css-generated-content/table-row-before-after-expected.checksum: Added.
  • platform/mac/fast/css-generated-content/table-row-before-after-expected.png: Added.
  • platform/mac/fast/css-generated-content/table-row-before-after-expected.txt: Added.
12:00 PM Changeset in webkit [80870] by jamesr@google.com
  • 2 edits in branches/chromium/696/Source/WebCore

Merge 80869 - 2011-03-11 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Avoid updating a composited layer&apos;s contents if the layer has nonpositive dimensions
https://bugs.webkit.org/show_bug.cgi?id=56209

This matches the behavior prior to r80482. No test since the only changes in
behavior are avoiding work on invisible layers, which is unobservable,
and fixing a crash due to bug 56153.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updateContentsRecursive):

TBR=jamesr@google.com
BUG=75563

11:59 AM Changeset in webkit [80869] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

2011-03-11 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Avoid updating a composited layer&apos;s contents if the layer has nonpositive dimensions
https://bugs.webkit.org/show_bug.cgi?id=56209

This matches the behavior prior to r80482. No test since the only changes in
behavior are avoiding work on invisible layers, which is unobservable,
and fixing a crash due to bug 56153.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updateContentsRecursive):
11:56 AM Changeset in webkit [80868] by hyatt@apple.com
  • 31 edits
    6 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=47159

Reviewed by Simon Fraser.

CSS2.1 failures in background position parsing.

Rewrite background position component parsing to match the spec. Our old parsing would allow "100% left" to be valid
when it should not have. Rename parseFillPositionXY to parseFillPositionComponent and pass in enough information for
it to understand what the first component was.

For individual property parsing using background-position-x/y, I added new functions that just handle that without
worrying about the other component.

In order to pass the CSS2.1 test, I also had to fix multiple background parsing. The number of layers in multiple
backgrounds is determined solely by the background-image property and not by any of the other properties. cullEmptyLayers
has been changed to always consider a layer empty if it has no image set, even if other properties are set.

A number of layout tests had to be patched as they were invalid. A couple of them relied on incorrect background-position
parsing (e.g., "50 left") and another relied on incorrect multiple background parsing. It's not clear if the computed style
should actually include the additional values when no image is set though, so that should perhaps be the subject of a
follow-up bug.

Added fast/backgrounds/background-position-parsing.html

Source/WebCore:

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFillPositionX):
(WebCore::CSSParser::parseFillPositionY):
(WebCore::CSSParser::parseFillPositionComponent):
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::parseTransformOrigin):
(WebCore::CSSParser::parsePerspectiveOrigin):

  • css/CSSParser.h:
  • rendering/style/FillLayer.cpp:

(WebCore::FillLayer::fillUnsetProperties):
(WebCore::FillLayer::cullEmptyLayers):

LayoutTests:

  • fast/backgrounds/background-position-1.html:
  • fast/backgrounds/background-position-parsing.html: Added.
  • fast/backgrounds/multiple-backgrounds-computed-style-expected.txt:
  • fast/backgrounds/repeat/parsing-background-repeat-expected.txt:
  • fast/backgrounds/repeat/script-tests/parsing-background-repeat.js:
  • fast/backgrounds/resources/diamond.png: Added.
  • fast/backgrounds/resources/ring.png: Added.
  • fast/backgrounds/script-tests/multiple-backgrounds-computed-style.js:
  • platform/mac/fast/backgrounds/animated-svg-as-background-expected.checksum:
  • platform/mac/fast/backgrounds/animated-svg-as-background-expected.png:
  • platform/mac/fast/backgrounds/animated-svg-as-mask-expected.checksum:
  • platform/mac/fast/backgrounds/animated-svg-as-mask-expected.png:
  • platform/mac/fast/backgrounds/background-position-parsing-expected.checksum: Added.
  • platform/mac/fast/backgrounds/background-position-parsing-expected.png: Added.
  • platform/mac/fast/backgrounds/background-position-parsing-expected.txt: Added.
  • platform/mac/fast/backgrounds/bgCompositeCopy-expected.png:
  • platform/mac/fast/backgrounds/repeat/noRepeatCorrectClip-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize01-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize03-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize05-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize06-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize07-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize08-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize09-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize10-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize11-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize12-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize22-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize22-expected.png:
  • platform/mac/fast/backgrounds/size/contain-and-cover-expected.checksum:
  • platform/mac/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/mac/fast/backgrounds/svg-as-background-4-expected.png:
11:50 AM Changeset in webkit [80867] by vangelis@chromium.org
  • 4 edits
    4 adds in trunk

2011-03-11 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by James Robinson.

[chromium] Adding a test for rotated large layers.
https://bugs.webkit.org/show_bug.cgi?id=55984

  • platform/chromium/compositing/huge-layer-rotated-expected.checksum: Added.
  • platform/chromium/compositing/huge-layer-rotated-expected.png: Added.
  • platform/chromium/compositing/huge-layer-rotated-expected.txt: Added.
  • platform/chromium/compositing/huge-layer-rotated.html: Added.

2011-03-11 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by James Robinson.

[chromium] Allow large layers with non-identity transforms to be drawn
as long as their visible portion is smaller than the largest supported
texture size. This code will soon be replaced by tiled layers.
https://bugs.webkit.org/show_bug.cgi?id=55984

Test: platform/chromium/compositing/huge-layer-rotated.html

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::updateContentsIfDirty): (WebCore::ContentLayerChromium::draw):
  • platform/graphics/chromium/ContentLayerChromium.h:
11:18 AM Changeset in webkit [80866] by cmarrin@apple.com
  • 2 edits in trunk/Source/WebCore

2011-03-09 Chris Marrin <cmarrin@apple.com>

Reviewed by Adam Roben.

REGRESSION (5.0.3-ToT): Scrolling text doesn&apos;t scroll in Star Wars intro animation
https://bugs.webkit.org/show_bug.cgi?id=52468

Added WIN32 to the ifdef controlling whether animations are applied in normal or
reverse order. On Mac, animations used to be applied in reverse, but
<rdar://problem/7095638> fixed this in the release after Snow Leopard.
But that patch has not be applied to the Safari Windows SDK yet. For now
I've made Windows use the reverse order logig. <rdar://problem/9112233> is
tracking the inclusion of the patch on Windows.

  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
11:11 AM Changeset in webkit [80865] by Dimitri Glazkov
  • 3 edits
    1 add in trunk/Source/JavaScriptCore

2011-03-11 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

Tweak dylib paths and add dtrace header generation action to JavaScriptCore gyp project.
https://bugs.webkit.org/show_bug.cgi?id=56207

  • JavaScriptCore.gypi: Added Tracing.d to the sources.
  • gyp/generate-dtrace-header.sh: Added.
  • gyp/JavaScriptCore.gyp: Updated dylib paths (now the project can see them),

and added DTrace header generating step.

10:58 AM Changeset in webkit [80864] by Adam Roben
  • 4 edits
    3 copies
    1 add
    1 delete in trunk/Tools

Make it possible to view all leaks from a build at once in Leaks Viewer

You can now give Leaks Viewer the URL of a build results page (e.g.,
<http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80847%20(15493)/>), and it
will load all the leaks files from that build.

Fixes <http://webkit.org/b/56030> Leaks Viewer: Would like to be able to look at all leaks
files from a particular build at once, rather than one at a time

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksLoader.js: Added.

(LeaksLoader): Initialize our properties.
(LeaksLoader.prototype.start): If the URL ends in .txt, assume it's a single leaks file and
load it. Otherwise assume it's a build results page URL and start fetching the leaks files
from that page.
(LeaksLoader.prototype._loadLeaksFiles): Tell our client how many leaks files we're loading
so it can provide feedback. Then load each one and pass it to the client.
(LeaksLoader.prototype._loadLeaksFromResultsPage): Load the HTML of the results page, parse
it into a DOM, pull out all the links to leaks files, and load each one.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js: Added.

(LeaksParser): Initialize our worker.
(LeaksParser.prototype.addLeaksFile): Tell the worker about the leaks file's contents.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js: Added.

This code mostly came from Worker.js.
(LeaksParserWorker): Initialize our profile.
(LeaksParserWorker.prototype.addLeaksFile): Parse the leaks file and incorporate it into our
profile.
(LeaksParserWorker.prototype._parseLeaks):
(LeaksParserWorker.prototype._createNode):
(LeaksParserWorker.prototype._incorporateLeaks):
Moved these functions here from LeaksViewer. _incorporateLeaks is essentially just a renamed
version of createProfile which adds to this.profile instead of making a new profile each
time.
(onmessage): Parse the file and send back the new profile.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:

(#loading-indicator):
(#spinner):
(#loading-indicator-label):
Tweaked styles to accomodate a longer label.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:

(LeaksViewer.loaded): Set up a loader and parser.

(LeaksViewer.get filesLeftToParse):
(LeaksViewer.set filesLeftToParse):
Added these simple accessors.

(LeaksViewer._didCountLeaksFiles): Callback from LeaksLoader. Stores the count.
(LeaksViewer._didLoadLeaksFile): Callback from LeaksLoader. Passes the file contents off to
the parser.
(LeaksViewer._didParseLeaksFile): Callback from LeaksParser. If all files have been parsed,
tell the ProfilerAgent and mark that we're done loading. (Code came from the old
_loadLeaksFromURL function).
(LeaksViewer._loadLeaksFromURL): Now just calls through to the loader.
(LeaksViewer._loadingIndicatorText): Added. Returns the text that should show up in the
loading indicator, including the number of files being loaded.
(LeaksViewer._loadingStatusChanged): Update the loading indicator's label, too.
(LeaksViewer._updateLoadingIndicatorLabel): Added. Just updates the label!
(LeaksViewer._updateTitle): Moved code to compute the "Loading" text to
_loadingIndicatorText.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js: Added.

(getResource): Moved here from LeaksViewer.js.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Subsumed by

LeaksParserWorker.js.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added new JS

files, added a #loading-indicator-label element, and tweaked the prompt wording.

10:57 AM Changeset in webkit [80863] by Adam Roben
  • 3 edits in trunk/Tools

Don't trigger a build when build.webkit.org's HTML files are modified

Fixes <http://webkit.org/b/56190> Windows bots shouldn't have built r80848/r80851, but did

Reviewed by Dan Bernstein.

  • Scripts/webkitpy/common/config/build.py:

(_should_file_trigger_build): Added build.webkit.org's public_html directory to the list of
directories that shouldn't trigger builds. Re-sorted the list.

  • Scripts/webkitpy/common/config/build_unittest.py:

(ShouldBuildTest): Added a test to cover the above change.

10:47 AM Changeset in webkit [80862] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-11 Avi Drissman <avi@google.com>

Reviewed by Tony Chang.

Fix missing initialization of new member variables.
https://bugs.webkit.org/show_bug.cgi?id=50969

  • public/WebMenuItemInfo.h: (WebKit::WebMenuItemInfo::WebMenuItemInfo):
10:29 AM Changeset in webkit [80861] by tonyg@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-03-11 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Let the parser yield for layout before running scripts
https://bugs.webkit.org/show_bug.cgi?id=54355

Prior to this patch, the parser would yield to perform a layout/paint before running a
script only if the script or a stylesheet blocking the script is not loaded yet. Since we
don't preload scan into the body while parsing the head, typically we'll block on a script
early in the body that causes us to yield to do the first paint within a reasonable time.

However, I'm planning to change the PreloadScanner to scan into the body from the head.
That significantly improves overall load time, but would hurt first paint time because
fewer scripts would be blocked during parsing and thus wouldn't yield.

This change causes us to yield before running scripts if we haven't painted yet (regardless
of whether or not the script is loaded). In addition to allowing the above mentioned
PreloadScanner change to be implemented without regressing first paint time, this also
improves first paint time by itself.

I tested Alexa's top 45 websites using Web Page Replay to control the content and simulate
bandwidth. This patch improved average first paint time by 1% over an unlimited connection,
6% over a 1Mbps connection and 11% over a 5Mbps connection. There was no statistically
signifcant change in page load time.

Within the pages tested, 33 had no statistically significant change in time to first paint,
12 improved, and none regressed. Of the improved, some of the standouts from the 1Mbps set
are: 20% on youtube, 37% on wiki, 27% on ebay, 13% on cnn, 16% on espn, 74% on sohu.

  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::canTakeNextToken): This is the new yield point. (WebCore::HTMLDocumentParser::pumpTokenizer): Remove ASSERT that we are not paused. isPaused means that we are waiting for a script. Bug 54574 changed pumpTokenizer() so that it does the right thing whether we are just before a token or waiting for a script. Now that we may yield before a token or before a script, this may be called while paused.
  • html/parser/HTMLParserScheduler.cpp: (WebCore::HTMLParserScheduler::checkForYieldBeforeScript): Added.
  • page/FrameView.h: (WebCore::FrameView::hasEverPainted): Added.
10:24 AM Changeset in webkit [80860] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-03-11 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Ariya Hidayat.

[Qt] Entering fullscreen and leaving it may hide the cursor of the application.
https://bugs.webkit.org/show_bug.cgi?id=56181

We need to stop the auto hide cursor timer when closing the widget otherwise the timer
might get fired and therefore hide the cursor even when the fullscreen widget is closed.

  • WebCoreSupport/FullScreenVideoWidget.cpp: (WebCore::FullScreenVideoWidget::closeEvent):
10:12 AM Changeset in webkit [80859] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

2011-03-11 Dimitri Glazkov <Dimitri Glazkov>

Fix crashes in dom/html/level2/html/HTMLInputElement*.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): Added a null-check for e,

because e can certainly be a null.

9:59 AM Changeset in webkit [80858] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

2011-03-09 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by David Hyatt.

Choke text-decoration when entering shadow DOM subtree.
https://bugs.webkit.org/show_bug.cgi?id=56044

No new tests, because the functionality can't be tested yet.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): Added a check for shadow DOM root.
9:55 AM Changeset in webkit [80857] by Dimitri Glazkov
  • 13 edits in trunk

2011-03-08 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Carlson.

Convert MediaControlTimeDisplayElement to use standard layout with a custom renderer.
https://bugs.webkit.org/show_bug.cgi?id=55972

Update test results, because they are now laying out timeline consistently.

  • media/audio-repaint-expected.txt: Updated.
  • platform/mac/media/audio-controls-rendering-expected.checksum: Ditto.
  • platform/mac/media/audio-controls-rendering-expected.png: Ditto.
  • platform/mac/media/audio-controls-rendering-expected.txt: Ditto.
  • platform/mac/media/audio-repaint-expected.checksum: Ditto.
  • platform/mac/media/audio-repaint-expected.png: Ditto.

2011-03-08 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Carlson.

Convert MediaControlTimeDisplayElement to use standard layout with a custom renderer.
https://bugs.webkit.org/show_bug.cgi?id=55972

Instead of poking at the time display elements all the way from RenderMedia,
let the standard layout cycle take care of things. Move the logic of calculating
when to collapse the time display elements into a custom renderer, since
this is not something that can be accomplished with CSS.

Also, the logic of keeping the timeline slider at least 100px needed refreshing,
since it didn't actually keep it at 100px.

  • html/shadow/MediaControls.cpp: Moved the logic of determining visibility

of time display elements to RenderMediaControlTimeDisplay, eliminating
updateTimeDisplayVisibility method.

  • html/shadow/MediaControls.h: Removed decl.
  • rendering/MediaControlElements.cpp: (WebCore::RenderMediaControlTimeDisplay::RenderMediaControlTimeDisplay):

Added new renderer class.

(WebCore::RenderMediaControlTimeDisplay::layout): Simplified (and corrected)

size-sensing logic, still using hard-coded values.

(WebCore::MediaControlTimeDisplayElement::MediaControlTimeDisplayElement):

Removed m_isVisible member, which is no longer necessary.

(WebCore::MediaControlTimeDisplayElement::createRenderer): Added to

return the new renderer.

  • rendering/MediaControlElements.h: Adjusted decls.
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::layout): Remove the now-unnecessary poking at

media controls in layout.

9:28 AM Changeset in webkit [80856] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/gtk

2011-03-11 Marco Peereboom <marco@peereboom.us>

Reviewed by Gustavo Noronha Silva.

Provide a knob to enable/disable DNS prefetching.
DNS prefetching is enabled by default.
https://bugs.webkit.org/show_bug.cgi?id=55973

  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
  • webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):
9:19 AM Changeset in webkit [80855] by Dimitri Glazkov
  • 5 edits in trunk/Source/WebCore

2011-03-09 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Carlson.

Start focusing updates to media controls, away from always updating everything.
https://bugs.webkit.org/show_bug.cgi?id=56038

For now, the new methods just call generic MediaControls::update.

Covered by existing tests.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::attributeChanged): Changed to use MediaControls::reset. (WebCore::HTMLMediaElement::setMuted): Changed to use MediaControls::changedMute. (WebCore::HTMLMediaElement::updateVolume): Changed to use MediaControls::changedVolume. (WebCore::HTMLMediaElement::defaultEventHandler): Changed to use the new mediaControls

accessor.

(WebCore::HTMLMediaElement::setClosedCaptionsVisible): Changed to use

MediaControls::changedClosedCaptionsVisibility.

(WebCore::HTMLMediaElement::mediaControls): Added.
(WebCore::HTMLMediaElement::hasMediaControls): Added.

  • html/HTMLMediaElement.h: Added decls.
  • html/shadow/MediaControls.cpp: (WebCore::MediaControls::reset): Added. (WebCore::MediaControls::changedMute): Added. (WebCore::MediaControls::changedVolume): Added. (WebCore::MediaControls::changedClosedCaptionsVisibility): Added.
  • html/shadow/MediaControls.h: Added decls.
9:09 AM Changeset in webkit [80854] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-11 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Martin Robinson.

[GStreamer] When seeking webKitWebSrcStop release the frame but should not.
https://bugs.webkit.org/show_bug.cgi?id=55703

When calling webKitWebSrcStop in case of a seeking, the frame should not
be reset (the source hasn't change). The frame may be used to get the network
context. Some network stack (like Qt) are relaying on the network context
to work.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (webKitWebSrcStop):
7:08 AM Changeset in webkit [80853] by dino@apple.com
  • 3 edits in trunk/Source/WebCore

2011-03-11 Dean Jackson <dino@apple.com>

Unreviewed.

Build fixes for GTK and Leopard.

  • bindings/gobject/GNUmakefile.am:
  • add missing WebKitAnimation* generated bindings
  • page/WebKitAnimation.idl:
  • use double in place of float (the core values are double anyway)
7:05 AM Changeset in webkit [80852] by Adam Roben
  • 5 edits in trunk/LayoutTests

Update Windows results after r80846

  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:
6:56 AM Changeset in webkit [80851] by Adam Roben
  • 2 edits in trunk/Tools

Roll out r80848

It was accidentally committed.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:

(LeaksViewer._loadLeaksFromURL):

6:51 AM Changeset in webkit [80850] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip a crashing test on Windows

The crash is tracked by <http://webkit.org/b/56185>.

  • platform/win/Skipped: Added http/tests/websocket/tests/url-with-credential.html. Grouped

possibly-related websocket crashes.

6:51 AM Changeset in webkit [80849] by Adam Roben
  • 1 edit
    1 move in trunk/LayoutTests

Disable fast/text/large-text-composed-char-dos.html

It is failing on multiple bots. The failure is tracked by <http://webkit.org/b/56140>.

  • fast/text/large-text-composed-char-dos.html-disabled: Renamed from LayoutTests/fast/text/large-text-composed-char-dos.html.
6:49 AM Changeset in webkit [80848] by Adam Roben
  • 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js

Work on fetching all leaks for a build

6:19 AM Changeset in webkit [80847] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

2011-03-11 Dean Jackson <dino@apple.com>

Unreviewed build fix for QT.

  • WebCore.pro:
6:05 AM Changeset in webkit [80846] by dino@apple.com
  • 32 edits
    11 adds in trunk

2011-03-11 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser and Chris Marrin.

https://bugs.webkit.org/show_bug.cgi?id=54151
Implement an API to play/pause/scrub animations

This is Part 1. Adds the new WebKitAnimation and WebKitAnimationList
APIs, exposed via Element.getWebKitAnimations(). This first pass
is a read-only API - a subsequent commit will add the ability
to scrub animations.

Test: animations/animation-api-1.html

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • Android.mk:
  • Android.v8bindings.mk:
  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • All build settings updated for new files
  • bindings/js/JSBindingsAllInOne.cpp:
  • Include new custom files
  • bindings/js/JSWebKitAnimationCustom.cpp: Added. (WebCore::JSWebKitAnimation::iterationCount):
  • Custom property getter so that we can return INFINITY
  • bindings/js/JSWebKitAnimationListCustom.cpp: Added. (WebCore::JSWebKitAnimationList::markChildren):
  • Make sure WebKitAnimations are marked
  • bindings/v8/custom/V8WebKitAnimationCustom.cpp: Added. (WebCore::V8WebkitAnimation::iterationCountAccessorGetter):
  • Custom property getter so that we can return INFINITY
  • dom/Element.cpp: (WebCore::Element::webkitGetAnimations):
  • dom/Element.h:
  • dom/Element.idl:
  • New API entry point
  • page/DOMWindow.idl:
  • Constructor definitions for WebKitAnimation and WebKitAnimationList
  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::~AnimationBase):
  • Since AnimationBase can now live longer (if a WebKitAnimation is held in Javascript) we need to guard for the renderer having disappeared. (WebCore::AnimationBase::setElapsedTime): (WebCore::AnimationBase::play): (WebCore::AnimationBase::pause):
  • Stub implementations at present
  • page/animation/AnimationBase.h: (WebCore::AnimationBase::animation):
  • Expose the Animation properties
  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::animationsForRenderer): (WebCore::AnimationController::animationsForRenderer):
  • Builds the list of WebKitAnimations
  • page/animation/AnimationController.h:
  • page/animation/AnimationControllerPrivate.h:
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateKeyframeAnimations):
  • Make sure we clear the renderer if we are removing the animation (WebCore::CompositeAnimation::animations):
  • page/animation/CompositeAnimation.h:
  • page/animation/WebKitAnimation.cpp: Added. (WebCore::WebKitAnimation::WebKitAnimation): (WebCore::WebKitAnimation::name): (WebCore::WebKitAnimation::duration): (WebCore::WebKitAnimation::elapsedTime): (WebCore::WebKitAnimation::setElapsedTime): (WebCore::WebKitAnimation::delay): (WebCore::WebKitAnimation::iterationCount): (WebCore::WebKitAnimation::paused): (WebCore::WebKitAnimation::ended): (WebCore::WebKitAnimation::direction): (WebCore::WebKitAnimation::fillMode): (WebCore::WebKitAnimation::pause): (WebCore::WebKitAnimation::play):
  • The implementation of the new API. All the read-only parts are done, but elapsedTime, play() and pause() are stubs.
  • page/animation/WebKitAnimation.h: Added. (WebCore::WebKitAnimation::create): (WebCore::WebKitAnimation::~WebKitAnimation):
  • page/animation/WebKitAnimation.idl: Added.
  • page/animation/WebKitAnimationList.cpp: Added.
  • page/animation/WebKitAnimationList.h: Added.
  • page/animation/WebKitAnimationList.idl: Added.
  • Copies NodeList implementation

2011-03-11 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser and Chris Marrin.

https://bugs.webkit.org/show_bug.cgi?id=54151
Implement an API to play/pause/scrub animations

This is Part 1. Adds the new WebKitAnimation and WebKitAnimationList
APIs, exposed via Element.getWebKitAnimations(). This first pass
is read-only. One new layout test that examines animation
properties. Update existing layout tests for the new interfaces
on Window.

  • animations/animation-api-1-expected.txt: Added.
  • animations/animation-api-1.html: Added.
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
5:38 AM Changeset in webkit [80845] by loislo@chromium.org
  • 34 edits in trunk

2011-03-11 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: introduce error argument for all the callbacks on frontend.
https://bugs.webkit.org/show_bug.cgi?id=56100

  • inspector/CodeGeneratorInspector.pm:
  • inspector/front-end: number of files

2011-03-11 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: introduce error argument for all the callbacks on frontend.
https://bugs.webkit.org/show_bug.cgi?id=56100

  • http/tests/inspector/extensions-test.js: (initialize_ExtensionsTest.InspectorTest.runExtensionTests):
  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.evaluateInPage.mycallback): (initialize_InspectorTest.InspectorTest.evaluateInPage):
  • inspector/console/console-dir-global.html:
  • inspector/elements/dom-agent-query-selector.html:
  • inspector/protocol/console-agent-expected.txt:
  • inspector/protocol/console-agent.html:
  • inspector/protocol/runtime-agent-expected.txt:
  • inspector/protocol/runtime-agent.html:
  • inspector/report-protocol-errors-expected.txt:
  • inspector/report-protocol-errors.html:
  • inspector/styles/styles-new-API.html:
  • inspector/styles/styles-source-offsets.html:
  • inspector/timeline/timeline-test.js: (initialize_Timeline.InspectorTest.stopTimeline):
5:26 AM Changeset in webkit [80844] by yurys@chromium.org
  • 34 edits
    2 copies
    2 adds in trunk

2011-03-11 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: split InjectedScriptHost into InjectedScriptManager and InjectedScriptHost
https://bugs.webkit.org/show_bug.cgi?id=56173

  • inspector/protocol/console-agent-expected.txt:
  • inspector/protocol/console-agent.html:

2011-03-11 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: split InjectedScriptHost into InjectedScriptManager and InjectedScriptHost
https://bugs.webkit.org/show_bug.cgi?id=56173

Moved all injected script managing logic into InjectedScriptManager which is owned by InspectorController.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSInjectedScriptHostCustom.cpp:
  • bindings/js/JSInjectedScriptManager.cpp: Added. (WebCore::InjectedScriptManager::createInjectedScript): (WebCore::InjectedScriptManager::discardInjectedScript): (WebCore::InjectedScriptManager::injectedScriptFor): (WebCore::InjectedScriptManager::canAccessInspectedWindow):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  • bindings/v8/custom/V8InjectedScriptManager.cpp: Copied from Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp. (WebCore::WeakReferenceCallback): (WebCore::createInjectedScriptHostV8Wrapper): (WebCore::InjectedScriptManager::createInjectedScript): (WebCore::InjectedScriptManager::discardInjectedScript): (WebCore::InjectedScriptManager::injectedScriptFor): (WebCore::InjectedScriptManager::canAccessInspectedWindow):
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToFrontend):
  • inspector/ConsoleMessage.h:
  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::canAccessInspectedWindow):
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::create): (WebCore::InjectedScriptHost::InjectedScriptHost): (WebCore::InjectedScriptHost::~InjectedScriptHost): (WebCore::InjectedScriptHost::disconnect): (WebCore::InjectedScriptHost::inspectImpl): (WebCore::InjectedScriptHost::clearConsoleMessages): (WebCore::InjectedScriptHost::databaseIdImpl): (WebCore::InjectedScriptHost::storageIdImpl):
  • inspector/InjectedScriptHost.h: (WebCore::InjectedScriptHost::init): (WebCore::InjectedScriptHost::setFrontend): (WebCore::InjectedScriptHost::clearFrontend):
  • inspector/InjectedScriptManager.cpp: Added. (WebCore::InjectedScriptManager::create): (WebCore::InjectedScriptManager::InjectedScriptManager): (WebCore::InjectedScriptManager::~InjectedScriptManager): (WebCore::InjectedScriptManager::disconnect): (WebCore::InjectedScriptManager::injectedScriptHost): (WebCore::InjectedScriptManager::injectedScriptForId): (WebCore::InjectedScriptManager::injectedScriptForObjectId): (WebCore::InjectedScriptManager::discardInjectedScripts): (WebCore::InjectedScriptManager::releaseObjectGroup): (WebCore::InjectedScriptManager::injectedScriptSource): (WebCore::InjectedScriptManager::injectScript):
  • inspector/InjectedScriptManager.h: Copied from Source/WebCore/inspector/InjectedScriptHost.h.
  • inspector/Inspector.idl:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::inspectedPageDestroyed): (WebCore::InspectorAgent::focusNode): (WebCore::InspectorAgent::didClearWindowObjectInWorld): (WebCore::InspectorAgent::createFrontendLifetimeAgents): (WebCore::InspectorAgent::didCommitLoad): (WebCore::InspectorAgent::domContentLoadedEventFired):
  • inspector/InspectorAgent.h:
  • inspector/InspectorBrowserDebuggerAgent.cpp:
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::InspectorConsoleAgent): (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent): (WebCore::InspectorConsoleAgent::clearConsoleMessages): (WebCore::InspectorConsoleAgent::addInspectedNode): (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled): (WebCore::InspectorConsoleAgent::addConsoleMessage):
  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::discardBindings): (WebCore::InspectorDOMAgent::pushNodeToFrontend): (WebCore::InspectorDOMAgent::resolveNode):
  • inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::create):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::create): (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame): (WebCore::InspectorDebuggerAgent::currentCallFrames):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::create): (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent): (WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent): (WebCore::InspectorRuntimeAgent::evaluate): (WebCore::InspectorRuntimeAgent::evaluateOn): (WebCore::InspectorRuntimeAgent::getProperties): (WebCore::InspectorRuntimeAgent::setPropertyValue): (WebCore::InspectorRuntimeAgent::releaseObject): (WebCore::InspectorRuntimeAgent::releaseObjectGroup):
  • inspector/InspectorRuntimeAgent.h:
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel):
4:50 AM Changeset in webkit [80843] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-11 Sergio Villar Senin <svillar@igalia.com>

[GTK] JSC crashes in 32bit Release bots after r80743
https://bugs.webkit.org/show_bug.cgi?id=56180

Skipping a couple of tests until the original issue is fixed.

  • platform/gtk/Skipped:
4:10 AM Changeset in webkit [80842] by antonm@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-11 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

[v8] Change the way group id for CSS objects is calculated
https://bugs.webkit.org/show_bug.cgi?id=56117

Do not treat CSSStyleDeclarations under not CSSRule as belonging to the same object group
as they should not be reachable in JavaScript.

Covered by existing layout tests. Fact of absence of retention is not trivial to prove.

  • bindings/v8/V8GCController.cpp: (WebCore::calculateGroupId): (WebCore::DOMObjectGrouperVisitor::visitDOMWrapper):
3:56 AM Changeset in webkit [80841] by sergio@webkit.org
  • 1 edit
    15 adds in trunk/LayoutTests

2011-03-11 Sergio Villar Senin <svillar@igalia.com>

Added new GTK+ test expectations.

  • platform/gtk/fast/backgrounds/positioned-root-expected.checksum: Added.
  • platform/gtk/fast/backgrounds/positioned-root-expected.png: Added.
  • platform/gtk/fast/backgrounds/positioned-root-expected.txt: Added.
  • platform/gtk/fast/backgrounds/table-root-expected.checksum: Added.
  • platform/gtk/fast/backgrounds/table-root-expected.png: Added.
  • platform/gtk/fast/backgrounds/table-root-expected.txt: Added.
  • platform/gtk/fast/block/basic/percent-height-inside-anonymous-block-expected.checksum: Added.
  • platform/gtk/fast/block/basic/percent-height-inside-anonymous-block-expected.png: Added.
  • platform/gtk/fast/block/basic/percent-height-inside-anonymous-block-expected.txt: Added.
  • platform/gtk/fast/block/positioning/static-distance-with-positioned-ancestor-expected.checksum: Added.
  • platform/gtk/fast/block/positioning/static-distance-with-positioned-ancestor-expected.png: Added.
  • platform/gtk/fast/block/positioning/static-distance-with-positioned-ancestor-expected.txt: Added.
  • platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.checksum: Added.
  • platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.png: Added.
  • platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.txt: Added.
3:23 AM Changeset in webkit [80840] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-11 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: hover over elements in Elements panel does not highlight nodes
https://bugs.webkit.org/show_bug.cgi?id=56121

In DOM trees with a comment and/or doctype preceding the HTML tag, the tree container right boundary
is 16px apart from the OL right boundary, and we miss the relevant LI by 4px. The fix is to compensate
for these 16px when computing the test point coordinates.

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype._treeElementFromEvent):
2:53 AM Changeset in webkit [80839] by yurys@chromium.org
  • 33 edits
    4 deletes in trunk

2011-03-11 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Roll out r80837.

2:47 AM Changeset in webkit [80838] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-11 Andrey Kosyakov <caseq@chromium.org>

Unreviewied trivial fix. Leave default state of setMonitoringXHREnabled intact so it doesn't affect other tests.

  • inspector/report-API-errors.html:
2:37 AM Changeset in webkit [80837] by yurys@chromium.org
  • 33 edits
    2 copies
    2 adds in trunk

2011-03-11 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: split InjectedScriptHost into InjectedScriptManager and InjectedScriptHost
https://bugs.webkit.org/show_bug.cgi?id=56173

  • inspector/protocol/console-agent-expected.txt:
  • inspector/protocol/console-agent.html:

2011-03-11 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: split InjectedScriptHost into InjectedScriptManager and InjectedScriptHost
https://bugs.webkit.org/show_bug.cgi?id=56173

Moved all injected script managing logic into InjectedScriptManager which is owned by InspectorController.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSInjectedScriptHostCustom.cpp:
  • bindings/js/JSInjectedScriptManager.cpp: Added. (WebCore::InjectedScriptManager::createInjectedScript): (WebCore::InjectedScriptManager::discardInjectedScript): (WebCore::InjectedScriptManager::injectedScriptFor): (WebCore::InjectedScriptManager::canAccessInspectedWindow):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  • bindings/v8/custom/V8InjectedScriptManager.cpp: Copied from Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp. (WebCore::WeakReferenceCallback): (WebCore::createInjectedScriptHostV8Wrapper): (WebCore::InjectedScriptManager::createInjectedScript): (WebCore::InjectedScriptManager::discardInjectedScript): (WebCore::InjectedScriptManager::injectedScriptFor): (WebCore::InjectedScriptManager::canAccessInspectedWindow):
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToFrontend):
  • inspector/ConsoleMessage.h:
  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::canAccessInspectedWindow):
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::create): (WebCore::InjectedScriptHost::InjectedScriptHost): (WebCore::InjectedScriptHost::~InjectedScriptHost): (WebCore::InjectedScriptHost::disconnect): (WebCore::InjectedScriptHost::inspectImpl): (WebCore::InjectedScriptHost::clearConsoleMessages): (WebCore::InjectedScriptHost::databaseIdImpl): (WebCore::InjectedScriptHost::storageIdImpl):
  • inspector/InjectedScriptHost.h: (WebCore::InjectedScriptHost::init): (WebCore::InjectedScriptHost::setFrontend): (WebCore::InjectedScriptHost::clearFrontend):
  • inspector/InjectedScriptManager.cpp: Added. (WebCore::InjectedScriptManager::create): (WebCore::InjectedScriptManager::InjectedScriptManager): (WebCore::InjectedScriptManager::~InjectedScriptManager): (WebCore::InjectedScriptManager::disconnect): (WebCore::InjectedScriptManager::injectedScriptHost): (WebCore::InjectedScriptManager::injectedScriptForId): (WebCore::InjectedScriptManager::injectedScriptForObjectId): (WebCore::InjectedScriptManager::discardInjectedScripts): (WebCore::InjectedScriptManager::releaseObjectGroup): (WebCore::InjectedScriptManager::injectedScriptSource): (WebCore::InjectedScriptManager::injectScript):
  • inspector/InjectedScriptManager.h: Copied from Source/WebCore/inspector/InjectedScriptHost.h.
  • inspector/Inspector.idl:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::inspectedPageDestroyed): (WebCore::InspectorAgent::focusNode): (WebCore::InspectorAgent::didClearWindowObjectInWorld): (WebCore::InspectorAgent::createFrontendLifetimeAgents): (WebCore::InspectorAgent::didCommitLoad): (WebCore::InspectorAgent::domContentLoadedEventFired):
  • inspector/InspectorAgent.h:
  • inspector/InspectorBrowserDebuggerAgent.cpp:
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::InspectorConsoleAgent): (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent): (WebCore::InspectorConsoleAgent::clearConsoleMessages): (WebCore::InspectorConsoleAgent::addInspectedNode): (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled): (WebCore::InspectorConsoleAgent::addConsoleMessage):
  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::discardBindings): (WebCore::InspectorDOMAgent::pushNodeToFrontend): (WebCore::InspectorDOMAgent::resolveNode):
  • inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::create):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::create): (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame): (WebCore::InspectorDebuggerAgent::currentCallFrames):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::create): (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent): (WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent): (WebCore::InspectorRuntimeAgent::evaluate): (WebCore::InspectorRuntimeAgent::evaluateOn): (WebCore::InspectorRuntimeAgent::getProperties): (WebCore::InspectorRuntimeAgent::setPropertyValue): (WebCore::InspectorRuntimeAgent::releaseObject): (WebCore::InspectorRuntimeAgent::releaseObjectGroup):
  • inspector/InspectorRuntimeAgent.h:
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel):
2:26 AM Changeset in webkit [80836] by Philippe Normand
  • 2 edits in trunk/Source/WebKit/gtk

2011-03-08 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] close-web-view emitted on disposed WebView
https://bugs.webkit.org/show_bug.cgi?id=55932

  • WebCoreSupport/ChromeClientGtk.cpp: (ChromeClient::chromeDestroyed): Remove the closeSoonTimer glib source before destruction of the ChromeClient.
2:26 AM Changeset in webkit [80835] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-11 Sergio Villar Senin <svillar@igalia.com>

Unreviewed.

Skipping two test cases that are failing on GTK debug bots.

  • platform/gtk/Skipped:
2:04 AM Changeset in webkit [80834] by hans@chromium.org
  • 5 edits
    1 move
    1 add in trunk/Source/WebCore

2011-03-09 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Make IDBBackingStore abstract
https://bugs.webkit.org/show_bug.cgi?id=56013

Make IDBBackingStore abstract to allow for multiple implementations.
Move the SQLite implementation to IDBSQLiteBackingStore.

No new tests: refactoring only.

  • WebCore.gypi:
  • storage/IDBBackingStore.h: (WebCore::IDBBackingStore::~IDBBackingStore):
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::open):
  • storage/IDBSQLiteBackingStore.cpp: (WebCore::IDBSQLiteBackingStore::IDBSQLiteBackingStore): (WebCore::IDBSQLiteBackingStore::~IDBSQLiteBackingStore): (WebCore::runCommands): (WebCore::createTables): (WebCore::createMetaDataTable): (WebCore::getDatabaseSchemaVersion): (WebCore::migrateDatabase): (WebCore::IDBSQLiteBackingStore::open): (WebCore::IDBSQLiteBackingStore::extractIDBDatabaseMetaData): (WebCore::IDBSQLiteBackingStore::setIDBDatabaseMetaData): (WebCore::IDBSQLiteBackingStore::getObjectStores): (WebCore::IDBSQLiteBackingStore::createObjectStore): (WebCore::doDelete): (WebCore::IDBSQLiteBackingStore::deleteObjectStore): (WebCore::whereSyntaxForKey): (WebCore::bindKeyToQuery): (WebCore::lowerCursorWhereFragment): (WebCore::upperCursorWhereFragment): (WebCore::IDBSQLiteBackingStore::getObjectStoreRecord): (WebCore::bindKeyToQueryWithNulls): (WebCore::IDBSQLiteBackingStore::putObjectStoreRecord): (WebCore::IDBSQLiteBackingStore::clearObjectStore): (WebCore::IDBSQLiteBackingStore::deleteObjectStoreRecord): (WebCore::IDBSQLiteBackingStore::nextAutoIncrementNumber): (WebCore::IDBSQLiteBackingStore::keyExistsInObjectStore): (WebCore::IDBSQLiteBackingStore::forEachObjectStoreRecord): (WebCore::IDBSQLiteBackingStore::getIndexes): (WebCore::IDBSQLiteBackingStore::createIndex): (WebCore::IDBSQLiteBackingStore::deleteIndex): (WebCore::IDBSQLiteBackingStore::putIndexDataForRecord): (WebCore::IDBSQLiteBackingStore::deleteIndexDataForRecord): (WebCore::IDBSQLiteBackingStore::getObjectViaIndex): (WebCore::keyFromQuery): (WebCore::IDBSQLiteBackingStore::getPrimaryKeyViaIndex): (WebCore::IDBSQLiteBackingStore::keyExistsInIndex): (WebCore::IDBSQLiteBackingStore::openObjectStoreCursor): (WebCore::IDBSQLiteBackingStore::openIndexKeyCursor): (WebCore::IDBSQLiteBackingStore::openIndexCursor): (WebCore::IDBSQLiteBackingStore::createTransaction):
  • storage/IDBSQLiteBackingStore.h: Added.
1:44 AM Changeset in webkit [80833] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Source/WebCore

2011-03-11 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed build error fix.

[EFL] Fix build break when SHARED_CORE is ON
https://bugs.webkit.org/show_bug.cgi?id=56155

  • platform/efl/ContextMenuEfl.cpp: (WebCore::ContextMenu::ContextMenu):
  • platform/efl/ContextMenuItemEfl.cpp: (WebCore::ContextMenuItem::nativeMenuItem): (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::~ContextMenuItem):
1:28 AM Changeset in webkit [80832] by caseq@chromium.org
  • 9 edits
    1 add in trunk

2011-03-11 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: resource load cancellation is reported to console as an error
https://bugs.webkit.org/show_bug.cgi?id=55764

  • mark interruptionForPolicyChangeError as cancellation
  • do not log resource cancelation as an error
  • always push resource to front-end before console message, so front-end can use resource info while formatting message.
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::didFailLoading):
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl): (WebCore::InspectorInstrumentation::didFailLoadingImpl):
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::stopLoadingForPolicyChange):

2011-03-11 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: resource load cancellation is reported to console as an error
https://bugs.webkit.org/show_bug.cgi?id=55764

  • http/tests/inspector/console-resource-errors-expected.txt:
  • http/tests/inspector/console-resource-errors.html: Added test for lack of console messages during policy change (at download)
  • http/tests/inspector/console-xhr-logging-expected.txt:
  • http/tests/inspector/console-xhr-logging.html: Added test for reporting of cross-origin XHR errors.
  • http/tests/inspector/resources/empty.zip: Added.
1:02 AM Changeset in webkit [80831] by apavlov@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-03-10 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Get rid of has/add/removeStyleClass() methods on Element.prototype - Step 1
https://bugs.webkit.org/show_bug.cgi?id=56096

No new tests, as this is a refactoring.

  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.EventListenerBreakpointsSidebarPane):
  • inspector/front-end/DetailedHeapshotView.js:
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.BaseStorageTreeElement): (WebInspector.BaseStorageTreeElement.prototype.onattach): (WebInspector.StorageCategoryTreeElement): (WebInspector.FrameTreeElement): (WebInspector.FrameResourceTreeElement): (WebInspector.DatabaseTreeElement): (WebInspector.DatabaseTableTreeElement): (WebInspector.DOMStorageTreeElement): (WebInspector.CookieTreeElement): (WebInspector.ApplicationCacheTreeElement): (WebInspector.ResourceRevisionTreeElement):
  • inspector/front-end/utilities.js: (Element.prototype.removeStyleClass): (Element.prototype.addStyleClass): (Element.prototype.hasStyleClass):
12:20 AM Changeset in webkit [80830] by tony@chromium.org
  • 2 edits in trunk/Tools

2011-03-11 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

kill hung lighttpd processes on the chromium win bot
https://bugs.webkit.org/show_bug.cgi?id=56152

Sometimes this process doesn't exit and it holds on to
a log file that we can't delete or copy, causing the tests
to go red.

  • BuildSlaveSupport/win/kill-old-processes:
12:17 AM Changeset in webkit [80829] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/9120161> WKPageRestoreFromSessionState does not set the pending API request URL.

Reviewed by Alice Liu.

  • UIProcess/cf/WebPageProxyCF.cpp:

(WebKit::WebPageProxy::restoreFromSessionStateData): If we're navigating to a back/forward item
as part of the restoration, call setPendingAPIRequestURL. When there's a provisional URL this will
be done by our call to loadURL elsewhere in the function.

12:11 AM Changeset in webkit [80828] by commit-queue@webkit.org
  • 5 edits in trunk

2011-03-11 Ilya Sherman <isherman@chromium.org>

Reviewed by Kent Tamura.

[Chromium] missing HTMLInputElement::setValueForUser() to tests
https://bugs.webkit.org/show_bug.cgi?id=55854

  • platform/chromium/test_expectations.txt: Removed onchange-setvalueforuser.html

2011-03-11 Ilya Sherman <isherman@chromium.org>

Reviewed by Kent Tamura.

[Chromium] missing HTMLInputElement::setValueForUser() to tests
https://bugs.webkit.org/show_bug.cgi?id=55854

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setValueForUser): Added.
  • DumpRenderTree/chromium/LayoutTestController.h:
12:10 AM Changeset in webkit [80827] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-11 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip
tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody.html
on GTK again after being unskipped by accident in r80738.

  • platform/gtk/Skipped:
12:06 AM Changeset in webkit [80826] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-11 Brian Salomon <bsalomon@google.com>

Reviewed by Kenneth Russell.

Adds GrContext flush call to PlatformContextSkia destructor.

Calls GrContext flush with int parameter instead of bool due to skia
revision.

No new tests needed.

  • platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::publishToPlatformLayer):
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::~PlatformContextSkia): (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):

Mar 10, 2011:

11:54 PM Changeset in webkit [80825] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-10 Alexey Proskuryakov <ap@apple.com>

Reviewed by Jon Honeycutt.

WebKit2 UI process crashes if web process crashes while computing page rects for printing
https://bugs.webkit.org/show_bug.cgi?id=56160
<rdar://problem/9027410>

  • UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView _suspendAutodisplay]): Added a null check for page, matching one that we have when resuming autodisplay. (-[WKPrintingView _delayedResumeAutodisplayTimerFired]): Added a FIXME. (pageDidComputePageRects): Sanitize results coming from the web process (and avoid crashing when there is a communication error, so results are all null). (-[WKPrintingView knowsPageRange:]): If there is no page any more, we can't tell how many pages it had. (-[WKPrintingView rectForPage:]): Handle the case where we are neither calculating pages nor knowing them, as it happens when the web process crashes.
11:45 PM Changeset in webkit [80824] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-10 Chris Guillory <chris.guillory@google.com>

Reviewed by James Robinson.

Fix for Coverity discovered NO_EFFECT (self-assign) defect.
https://bugs.webkit.org/show_bug.cgi?id=54143

  • platform/graphics/gpu/TilingData.cpp: (WebCore::TilingData::setMaxTextureSize):
11:38 PM Changeset in webkit [80823] by eae@chromium.org
  • 4 edits
    2 adds in trunk

2011-03-10 Emil A Eklund <eae@chromium.org>

Reviewed by Alexey Proskuryakov.

The web colours palevioletred and mediumpurple are incorrect
https://bugs.webkit.org/show_bug.cgi?id=46658

Added test for named colors.

  • fast/css/named-colors-expected.txt: Added.
  • fast/css/named-colors.html: Added.

2011-03-10 Emil A Eklund <eae@chromium.org>

Reviewed by Alexey Proskuryakov.

The web colours palevioletred and mediumpurple are incorrect
https://bugs.webkit.org/show_bug.cgi?id=46658

Changed value for the palevioletred and mediumpurple colors to match
the css3 specification.

Test: fast/css/named-colors.html

  • inspector/front-end/Color.js:
  • platform/ColorData.gperf:
11:27 PM Changeset in webkit [80822] by rolandsteiner@chromium.org
  • 2 edits
    14 adds
    2 deletes in trunk/LayoutTests

2011-03-10 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed: update Chromium test expectations.

  • platform/chromium-linux/fast/block/basic/percent-height-inside-anonymous-block-expected.checksum: Added.
  • platform/chromium-linux/fast/block/basic/percent-height-inside-anonymous-block-expected.png: Added.
  • platform/chromium-linux/fast/block/positioning/static-distance-with-positioned-ancestor-expected.checksum: Added.
  • platform/chromium-linux/fast/block/positioning/static-distance-with-positioned-ancestor-expected.png: Added.
  • platform/chromium-mac/fast/block/basic/percent-height-inside-anonymous-block-expected.checksum: Added.
  • platform/chromium-mac/fast/block/basic/percent-height-inside-anonymous-block-expected.png: Added.
  • platform/chromium-mac/fast/block/positioning/static-distance-with-positioned-ancestor-expected.checksum: Added.
  • platform/chromium-mac/fast/block/positioning/static-distance-with-positioned-ancestor-expected.png: Added.
  • platform/chromium-mac/fast/js/kde/function_length-expected.txt: Removed.
  • platform/chromium-win/fast/block/basic/percent-height-inside-anonymous-block-expected.checksum: Added.
  • platform/chromium-win/fast/block/basic/percent-height-inside-anonymous-block-expected.png: Added.
  • platform/chromium-win/fast/block/basic/percent-height-inside-anonymous-block-expected.txt: Added.
  • platform/chromium-win/fast/block/positioning/static-distance-with-positioned-ancestor-expected.checksum: Added.
  • platform/chromium-win/fast/block/positioning/static-distance-with-positioned-ancestor-expected.png: Added.
  • platform/chromium-win/fast/block/positioning/static-distance-with-positioned-ancestor-expected.txt: Added.
  • platform/chromium-win/fast/js/kde/function_length-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
11:24 PM Changeset in webkit [80821] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-03-10 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

document.compatMode is incorrect for javascript: protocol URLs in IFRAMEs
https://bugs.webkit.org/show_bug.cgi?id=27845

This bug was randomly fixed by the HTML5 parser.

  • fast/parser/javascript-url-compat-mode-expected.txt: Added.
  • fast/parser/javascript-url-compat-mode.html: Added.
11:13 PM Changeset in webkit [80820] by commit-queue@webkit.org
  • 5 edits in trunk/LayoutTests

2011-03-10 Ami Fischman <fischman@google.com>

Reviewed by David Levin.

video-controls-in-media-document.html used to silently rely on
timeupdate firing immediately upon playback start, and before any
frames changed. This was (unsurprisingly, in retrospect)
super-brittle. This change instead uses an explicit seek to put
the video in a predictable state. The expected.png change is only to
change the "pause" button to "play" (which is part of what's
required to have the video be in a predictable state for the pixel
diff). An equivalent rebaselining needs to happen for chromium
mac & win.

  • media/video-controls-in-media-document.html:
  • platform/chromium/media/video-controls-in-media-document-expected.checksum:
  • platform/chromium/media/video-controls-in-media-document-expected.png:
  • platform/chromium/test_expectations.txt:
11:09 PM Changeset in webkit [80819] by rolandsteiner@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-10 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed: tweak Chromium test_expectations.txt

  • platform/chromium/test_expectations.txt:
11:02 PM Changeset in webkit [80818] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-03-10 David Boddie <david.boddie@nokia.com>

Reviewed by Andreas Kling.

Fixed a qdoc warning and terminology (WebKit instead of Webkit).
https://bugs.webkit.org/show_bug.cgi?id=55756

  • Api/qwebhistoryinterface.cpp:
10:45 PM Changeset in webkit [80817] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-03-10 Peter Kasting <pkasting@google.com>

Reviewed by Dimitri Glazkov.

Clean up some gross code in TestShellWin.cpp. No functional change.
https://bugs.webkit.org/show_bug.cgi?id=56048

  • DumpRenderTree/chromium/TestShellWin.cpp: (checkLayoutTestSystemDependencies):
10:34 PM Changeset in webkit [80816] by Laszlo Gombos
  • 2 edits in trunk/Tools

2011-03-10 Keith Kyzivat <keith.kyzivat@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Buildfix for platforms where X11 is not available (e.g. Symbian)

  • WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: (WTR::activateFonts): Guard X11-specific code with Q_WS_X11.
9:49 PM Changeset in webkit [80815] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

2011-03-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed build fix.

[WML] Fix build error
https://bugs.webkit.org/show_bug.cgi?id=56078

  • wml/WMLInputElement.cpp: (WebCore::WMLInputElement::defaultEventHandler):
9:36 PM Changeset in webkit [80814] by jeremy@chromium.org
  • 8 edits
    4 adds in trunk

2011-03-10 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Darin Adler.

Fix navigation menus on a bunch of sites in WebKit.
https://bugs.webkit.org/show_bug.cgi?id=52535

Add test to make sure that offsetLeft matches FF/IE for a relatively
positioned TD and IFRAME elements.
Testcase is a reduction from doula.co.il.

  • fast/block/positioning/offsetLeft-relative-iframe-expected.txt: Added.
  • fast/block/positioning/offsetLeft-relative-iframe.html: Added.
  • fast/block/positioning/offsetLeft-relative-td-expected.txt: Added.
  • fast/block/positioning/offsetLeft-relative-td.html: Added.

2011-03-10 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Darin Adler.

Fix navigation menus on a bunch of sites in WebKit.
https://bugs.webkit.org/show_bug.cgi?id=52535

WebKit doesn't support position:relative for several table elements and
overwrites the style internally when position:relative is encountered.
Unfortunately position:relative affects the choice of nodes returned by
offsetParent.

This CL adds a bit to RenderStyle to track whether position:relative was
overwritten. The value is then consulted in offsetParent which makes us
match FF/IE.

Tests: fast/block/positioning/offsetLeft-relative-iframe.html

fast/block/positioning/offsetLeft-relative-td.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::isOriginallyRelPositioned): (WebCore::RenderObject::offsetParent):
  • rendering/RenderObject.h:
  • rendering/style/RenderStyle.h: Add a bit to track the original value of position:relative. (WebCore::InheritedFlags::positionWasRelative): (WebCore::InheritedFlags::setPositionWasRelative):
  • rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==):
  • rendering/style/StyleRareNonInheritedData.h:
9:23 PM Changeset in webkit [80813] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Tools

2011-03-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Make single backing store the default for EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=55753

Set single backing store the default for EWebLauncher.

  • EWebLauncher/main.c: (main):
9:07 PM Changeset in webkit [80812] by abarth@webkit.org
  • 4 edits
    3 adds in trunk

2011-03-10 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

REGRESSION (r66428/r71892): Crash after assertion failure (!m_reachedTerminalState) in ResourceLoader::didCancel()
https://bugs.webkit.org/show_bug.cgi?id=51357

Test that we don't crash when calling close immedately after print.

  • printing/print-close-crash-expected.txt: Added.
  • printing/print-close-crash.html: Added.

2011-03-10 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

REGRESSION (r66428/r71892): Crash after assertion failure (!m_reachedTerminalState) in ResourceLoader::didCancel()
https://bugs.webkit.org/show_bug.cgi?id=51357

Previously, we would try to print from a callstack that didn't want a
nested event loop, leading to re-entrancy problems. In this patch, we
complete the print call asynchronously, giving us a clean stack on
which to run the nested event loop.

Test: printing/print-close-crash.html

  • page/DOMWindow.cpp: (WebCore::DOMWindow::DOMWindow): (WebCore::DOMWindow::print): (WebCore::DOMWindow::printTimerFired):
  • page/DOMWindow.h:
8:46 PM Changeset in webkit [80811] by rolandsteiner@chromium.org
  • 18 edits in trunk/Source

2011-03-11 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Ryosuke Niwa.

Bug 55570 - Remove dependency of dom/InputElement.cpp on html/ and wml/
https://bugs.webkit.org/show_bug.cgi?id=55570

Add a virtual function toInputElement() to Node that has a default
implementation of returning 0.
For HTMLInputElement and WMLInputElement (which derive from InputElement)
override this to return the object.
Change all calling sites of the old toInputElement to use the new member
function. This also allows us to save some casts.

No new tests. (refactoring)

  • WebCore.exp.in:
  • accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::textMarkerDataForVisiblePosition):
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isPasswordField): (WebCore::AccessibilityRenderObject::isIndeterminate): (WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio): (WebCore::AccessibilityRenderObject::isChecked):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement): (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
  • dom/CheckedRadioButtons.cpp: (WebCore::CheckedRadioButtons::removeButton):
  • dom/InputElement.cpp:
  • dom/InputElement.h:
  • dom/Node.cpp: (WebCore::Node::toInputElement):
  • dom/Node.h:
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::toInputElement):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::inputElement):
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::isChecked): (WebCore::RenderTheme::isIndeterminate):
  • wml/WMLInputElement.h: (WebCore::WMLInputElement::toInputElement):

2011-03-11 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Ryosuke Niwa.

Bug 55570 - Remove dependency of dom/InputElement.cpp on html/ and wml/
https://bugs.webkit.org/show_bug.cgi?id=55570

Add a virtual function toInputElement() to Node that has a default
implementation of returning 0.
For HTMLInputElement and WMLInputElement (which derive from InputElement)
override this to return the object.
Change all calling sites of the old toInputElement to use the new member
function. This also allows us to save some casts.

No new tests (refactoring).

  • src/WebInputElement.cpp: (WebKit::toWebInputElement):

2011-03-11 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Ryosuke Niwa.

Bug 55570 - Remove dependency of dom/InputElement.cpp on html/ and wml/
https://bugs.webkit.org/show_bug.cgi?id=55570

Add a virtual function toInputElement() to Node that has a default
implementation of returning 0.
For HTMLInputElement and WMLInputElement (which derive from InputElement)
override this to return the object.
Change all calling sites of the old toInputElement to use the new member
function. This also allows us to save some casts.

No new tests (refactoring).

  • src/WebInputElement.cpp: (WebKit::toWebInputElement):
  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::setValueForUser):
8:44 PM Changeset in webkit [80810] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-10 Takayoshi Kochi <kochi@chromium.org>

Reviewed by Tony Chang.

Remove default parameter declaration for familiForChars(), which is no longer necessary.

  • public/gtk/WebFontInfo.h:
8:31 PM Changeset in webkit [80809] by gyuyoung.kim@samsung.com
  • 4 edits
    1 add in trunk/Source/WebCore

2011-03-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] New mediaControl css file for EFL
https://bugs.webkit.org/show_bug.cgi?id=55460

Add new mediaControl css file for html5 video UI.

  • CMakeLists.txt:
  • CMakeListsEfl.txt:
  • css/mediaControlsEfl.css: Added. (audio): (audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel): (video:-webkit-full-page-media::-webkit-media-controls-panel): (audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button): (audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button): (audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container): (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display): (audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display): (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline): (audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container): (audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider): (audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button): (audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button): (audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button): (audio::-webkit-media-controls-rewind-button, video::-webkit-media-controls-rewind-button): (audio::-webkit-media-controls-return-to-realtime-button, video::-webkit-media-controls-return-to-realtime-button): (audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button): (audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):
  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::extraMediaControlsStyleSheet):
8:22 PM Changeset in webkit [80808] by eae@chromium.org
  • 3 edits
    2 adds in trunk

2011-03-10 Emil A Eklund <eae@chromium.org>

Reviewed by Dimitri Glazkov.

style.display affecting the initial selectedIndex value of a <select> when it's multiple attribute is set programatically
https://bugs.webkit.org/show_bug.cgi?id=53860

Add tests for selectedIndex when changing the multiple property on a select element.

  • fast/dom/HTMLSelectElement/change-multiple-preserve-selection-expected.txt: Added.
  • fast/dom/HTMLSelectElement/change-multiple-preserve-selection.html: Added.

2011-03-10 Emil A Eklund <eae@chromium.org>

Reviewed by Dimitri Glazkov.

style.display affecting the initial selectedIndex value of a <select> when its multiple attribute is set programatically
https://bugs.webkit.org/show_bug.cgi?id=53860

Preserve selection when changing between multi-select and single-select
for <select> boxes even if it has not yet been rendered.

Test: fast/dom/HTMLSelectElement/change-multiple-preserve-selection.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setMultiple):
8:16 PM Changeset in webkit [80807] by ojan@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-10 Ojan Vafai <ojan@chromium.org>

Reviewed by Tony Chang.

update comment to reference new DOM Core spec
https://bugs.webkit.org/show_bug.cgi?id=56079

I'm excising all instances of WRONG_DOCUMENT_ERR from WebKit.
This is the only one that's actually specified to fire
in the latest DOM Core spec.

  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument):
8:09 PM Changeset in webkit [80806] by commit-queue@webkit.org
  • 8 edits in trunk

2011-03-10 Rik Cabanier <cabanier@gmail.com>

Reviewed by Tony Gentilcore.

Fix that allows fixed length values to be floating point
https://bugs.webkit.org/show_bug.cgi?id=52699

Transitions now return matrices in floating point. 2 of the transition tests were failing
because they expected integer values.

  • transitions/matched-transform-functions.html:
  • transitions/retargetted-transition.html:

2011-03-10 Rik Cabanier <cabanier@gmail.com>

Reviewed by Tony Gentilcore.

Fix that allows fixed length values to be floating point
https://bugs.webkit.org/show_bug.cgi?id=52699

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSStyleSelector.cpp: (WebCore::convertToLength): (WebCore::convertToIntLength): (WebCore::convertToFloatLength): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::createTransformOperations):
  • platform/Length.h: (WebCore::Length::Length): (WebCore::Length::operator==): (WebCore::Length::operator!=): (WebCore::Length::rawValue): (WebCore::Length::type): (WebCore::Length::quirk): (WebCore::Length::setValue): (WebCore::Length::calcFloatValue): (WebCore::Length::isZero): (WebCore::Length::blend): (WebCore::Length::getIntValue): (WebCore::Length::getFloatValue):
  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
  • rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray):
7:52 PM Changeset in webkit [80805] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-10 Ryosuke Niwa <rniwa@webkit.org>

Added 3 http tests to Windows port's skipped list.
Tracked by https://bugs.webkit.org/show_bug.cgi?id=56167

  • platform/win/Skipped:
7:03 PM Changeset in webkit [80804] by rniwa@webkit.org
  • 13 edits in trunk/Source/WebCore

2011-03-10 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80800.
http://trac.webkit.org/changeset/80800
https://bugs.webkit.org/show_bug.cgi?id=56163

Caused hundreds of tests to crash on Windows 7 (Requested by
rniwa on #webkit).

  • page/EventHandler.cpp: (WebCore::EventHandler::mouseMoved): (WebCore::EventHandler::updateMouseEventTargetNode):
  • page/FocusController.cpp: (WebCore::FocusController::setActive):
  • page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::~FrameView):
  • page/FrameView.h:
  • page/Page.cpp:
  • page/Page.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::wheelEvent):
  • platform/ScrollView.h:
  • rendering/RenderDataGrid.cpp: (WebCore::RenderDataGrid::RenderDataGrid): (WebCore::RenderDataGrid::~RenderDataGrid):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::~RenderLayer):
  • rendering/RenderLayer.h:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::RenderListBox): (WebCore::RenderListBox::~RenderListBox):
6:17 PM Changeset in webkit [80803] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-03-10 Alice Boxhall <aboxhall@chromium.org>

Reviewed by Dimitri Glazkov.

NULL pointer crash when using :empty and :first-line pseudoclass selectors together
https://bugs.webkit.org/show_bug.cgi?id=53316

  • fast/css/empty-first-line-crash-expected.txt: Added.
  • fast/css/empty-first-line-crash.html: Added.

2011-03-10 Alice Boxhall <aboxhall@chromium.org>

Reviewed by Dimitri Glazkov.

NULL pointer crash when using :empty and :first-line pseudoclass selectors together
https://bugs.webkit.org/show_bug.cgi?id=53316

:empty is calculated for each element during parsing, but then not
recalculated after any child elements are attached. Force style
re-calculation on elements which have :empty in their style when
their children are changed.

Test: fast/css/empty-first-line-crash.html

  • dom/Element.cpp: (WebCore::checkForEmptyStyleChange): Pull out empty style checking logic from checkForSiblingStyleChanges(). (WebCore::checkForSiblingStyleChanges): Use new checkForEmptyStyleChanges() method. (WebCore::Element::childrenChanged): Call checkForEmptyStyleChanges() when called with changedByParser = true.
6:13 PM Changeset in webkit [80802] by eae@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-10 Emil A Eklund <eae@chromium.org>

Unreviewed build fix.

Fix Leopard Release build broken by r80797.

  • html/CollectionCache.h:
5:58 PM Changeset in webkit [80801] by mrowe@apple.com
  • 3 edits in trunk/Source/WebKit2

Part of <rdar://problem/8728860> WebKit2 needs to be made localizable

Rubber-stamped by Sam Weinig.

The presence of CFBundleDevelopmentRegion in the application's Info.plist prevents
the default localization that we set during launch from being respected.

  • PluginProcess/Info.plist: Remove CFBundleDevelopmentRegion.
  • WebProcess/Info.plist: Ditto.
5:53 PM Changeset in webkit [80800] by Beth Dakin
  • 13 edits in trunk/Source/WebCore

Fix for <rdar://problem/8944558> Overlay scrollers in overflow areas need to
send notifications appropriate times (showing up, resizing)
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=56067

Reviewed by Darin Adler.

The general strategy here is to add a HashSet of ScrollableAreas to the page that
can be accessed when necessary to send notifications to all ScrollableAreas.

Find layers for relevant node and if the layers are in the Page's ScrollableArea
set, then send the relevant notification.

  • page/EventHandler.cpp:

(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::updateMouseEventTargetNode):

When the page is set active or not active, iterate through the Page's
ScrollableAreas to send hide/show notifications.

  • page/FocusController.cpp:

(WebCore::FocusController::setActive):

When a FrameView is created, add it to the ScrollableArea set. When it's
destroyed, remove it.

  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::~FrameView):

Iterate through the Page's ScrollableAreas to send the paint notification.
(WebCore::FrameView::notifyPageThatContentAreaWillPaint):

  • page/FrameView.h:

Add the new ScrollableArea set.

  • page/Page.cpp:

(WebCore::Page::addScrollableArea):
(WebCore::Page::removeScrollableArea):
(WebCore::Page::pageContainsScrollableArea):

  • page/Page.h:

(WebCore::Page::scrollableAreaSet):

notifyPageThatContentAreaWillPaint() is a dummy function implemented in FrameView.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::notifyPageThatContentAreaWillPaint):

Call notifyPageThatContentAreaWillPaint() instead of calling
contentAreaWillPaint() just for the ScrollView.
(WebCore::ScrollView::paint):

  • platform/ScrollView.h:

Add/remove ScrollableAreas to the set.

  • rendering/RenderDataGrid.cpp:

(WebCore::RenderDataGrid::RenderDataGrid):
(WebCore::RenderDataGrid::~RenderDataGrid):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::RenderListBox):
(WebCore::RenderListBox::~RenderListBox):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::~RenderLayer):

Should have implemented this ScrollableArea-interface function a while ago.
(WebCore::RenderLayer::currentMousePosition):

  • rendering/RenderLayer.h:
5:50 PM Changeset in webkit [80799] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-10 Martin Robinson <mrobinson@igalia.com>

Rebaseline a test which differs on the bots from my local machine.

  • platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Update results.
5:48 PM Changeset in webkit [80798] by commit-queue@webkit.org
  • 6 edits in trunk

2011-03-10 takano takumi <takano@apple.com>

Reviewed by David Hyatt.

Crash in RenderCombineText::combineText when running fast/text/international/text-combine-parser-test.html on Windows with full page heap enabled
https://bugs.webkit.org/show_bug.cgi?id=55069

  • platform/win/Skipped: Removed text-combine-parser-test.html

2011-03-10 takano takumi <takano@apple.com>

Reviewed by David Hyatt.

Crash in RenderCombineText::combineText when running fast/text/international/text-combine-parser-test.html on Windows with full page heap enabled
https://bugs.webkit.org/show_bug.cgi?id=55069

No new tests. If the test above runs without crash, the fix should be okay.

  • dom/Node.cpp: (WebCore::Node::diff):
  • Changed to return Detach when textCombine style was changed.
  • rendering/RenderCombineText.cpp: (WebCore::RenderCombineText::styleDidChange): (WebCore::RenderCombineText::setTextInternal): (WebCore::RenderCombineText::width): (WebCore::RenderCombineText::adjustTextOrigin): (WebCore::RenderCombineText::charactersToRender): (WebCore::RenderCombineText::combineText):
  • Added assertions to ensure the passed object is RenderCombineText.
  • rendering/RenderCombineText.h: (WebCore::RenderCombineText::isCombineText):
  • Added to distinguish plain RenderText and RenderCombineText. (WebCore::toRenderCombineText):
  • Added assertions to ensure the passed object is RenderCombineText.
  • rendering/RenderObject.h: (WebCore::RenderObject::isCombineText):
  • Added to distinguish plain RenderText and RenderCombineText.
5:46 PM Changeset in webkit [80797] by eae@chromium.org
  • 8 edits
    6 adds in trunk

2011-03-10 Emil A Eklund <eae@chromium.org>

Reviewed by Darin Adler.

Collection cache not reset when moving base node between documents
https://bugs.webkit.org/show_bug.cgi?id=55446

Add tests for accessing elements moved across documents using namedItem.

  • fast/dom/HTMLFormElement/invalid-form-field-expected.txt: Added.
  • fast/dom/HTMLFormElement/invalid-form-field.html: Added.
  • fast/dom/HTMLFormElement/move-option-between-documents-expected.txt: Added.
  • fast/dom/HTMLFormElement/move-option-between-documents.html: Added.
  • fast/dom/collection-nameditem-move-between-documents-expected.txt: Added.
  • fast/dom/collection-nameditem-move-between-documents.html: Added.

2011-03-10 Emil A Eklund <eae@chromium.org>

Reviewed by Darin Adler.

Collection cache not reset when moving base node between documents
https://bugs.webkit.org/show_bug.cgi?id=55446

Fix bug where HTMLCollection::resetCollectionInfo does not reset the
cache when the base node is moved to a different document by making sure
that the DOMVersion is updated and that it's unique across documents.

Tests: fast/dom/HTMLFormElement/invalid-form-field.html

fast/dom/HTMLFormElement/move-option-between-documents.html
fast/dom/collection-nameditem-move-between-documents.html

  • dom/Document.cpp: (WebCore::Document::Document):
  • dom/Document.h: (WebCore::Document::incDOMTreeVersion): (WebCore::Document::domTreeVersion):
  • dom/Node.cpp: (WebCore::Node::setDocumentRecursively):
  • html/FormAssociatedElement.cpp: (WebCore::FormAssociatedElement::resetFormOwner):
  • html/HTMLCollection.cpp: (WebCore::HTMLCollection::resetCollectionInfo):
  • xml/XPathResult.h:
5:13 PM Changeset in webkit [80796] by commit-queue@webkit.org
  • 2 edits in trunk

2011-03-10 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Text layout is broken on Symbian
https://bugs.webkit.org/show_bug.cgi?id=56046

Change integers included into bitfields to be signed by default on RVCT
compiler as a lot of other compilers do (gcc, msvc, winsc).
There are a lot of places in webkit where integers included in bitfield
are assumed to be signed.

  • Source/WebKit.pri:
4:56 PM Changeset in webkit [80795] by commit-queue@webkit.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-03-10 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Adam Roben.

Formatted Diff for attachment 23920 is mangled
https://bugs.webkit.org/show_bug.cgi?id=21222

The mangled diff files mentioned in the bug were using Mac line
ending and this was causing problems for String#each_line. Now we
normalize the line endings in patch data before processing it.

  • PrettyPatch/PrettyPatch.rb:
4:56 PM Changeset in webkit [80794] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Source/WebCore

2011-03-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed build fix.

[EFL] Fix build break when CROSS_PLATFORM_CONTEXT_MENUS is disabled.
https://bugs.webkit.org/show_bug.cgi?id=56005

There are build breaks when CROSS_PLATFORM_CONTEXT_MENUS is disabled.

  • platform/efl/ContextMenuEfl.cpp: (WebCore::ContextMenu::ContextMenu):
  • platform/efl/ContextMenuItemEfl.cpp:
4:52 PM Changeset in webkit [80793] by rniwa@webkit.org
  • 6 edits in trunk/Source/WebCore

2011-03-10 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

startOfBlock and endOfBlock may return a position inside hr
https://bugs.webkit.org/show_bug.cgi?id=56025

Replaced calls to enclosingBlockFlowElement in startOfBlock and endOfBlock by
calls to enclosingBlock. Added EditingBoundaryCrossingRule to the argument lists
of startOfBlock, endOfBlock, and enclosingBlock. Also replaced the last boolean
argument variable of enclosingNodeOfType by EditingBoundaryCrossingRule.

Also replaced calls to enclosingBlockFlowElement in inSameBlock by calls to
enclosingBlock to be consitent with startOfBlock and endOfBlock.

This patch also replaced calls to deprecatedNode in startOfBlock, endOfBlock,
and inSameBlock by calls to containerNode because the enclosing block of a position
should never be before or after the position.

No tests are added because this change only affects WebCore internally.

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData): Calls enclosingNodeOfType. Pass CanCrossEditingBoundary instead of false.
  • editing/htmlediting.cpp: (WebCore::unsplittableElementForPosition): Ditto. (WebCore::enclosingBlock): Takes EditingBoundaryCrossingRule and passes it to enclosingNodeOfType. (WebCore::enclosingNodeOfType): Takes EditingBoundaryCrossingRule instead of boolean. Fixed a bug that it stops walking the tree when it reached the root editable node even when the editing boundary crossing rule is CanCrossEditingBoundary.
  • editing/htmlediting.h: Prototype changes.
  • editing/visible_units.cpp: (WebCore::startOfBlock): Calls enclosingBlock instead of enclosingBlockFlowElement. Also added an early exit when there's no enclosing block. (WebCore::endOfBlock): Ditto. The early exist in this case prevents crash in lastPositionInNode. (WebCore::inSameBlock): Calls enclosingBlock instead of enclosingBlockFlowElement. (WebCore::isStartOfBlock): Calls startOfBlock with CanCrossEditingBoundary because we don't care where the start of block is when we're comparing against the given position. (WebCore::isEndOfBlock): Ditto.
  • editing/visible_units.h:
4:49 PM Changeset in webkit [80792] by mrobinson@webkit.org
  • 3 edits in trunk/Source/WebKit2

2011-03-10 Martin Robinson <mrobinson@igalia.com>

Build for WebKit2 GTK+ after r80714.

  • GNUmakefile.am: Update source list.
  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: (WebKit::x11Display): Add missing semicolon.
4:48 PM Changeset in webkit [80791] by ap@apple.com
  • 3 edits
    2 adds in trunk

2011-03-10 Alexey Proskuryakov <ap@apple.com>

Reviewed by Dan Bernstein.

Backspace deletes all non-BMP symbols at once, and then some
https://bugs.webkit.org/show_bug.cgi?id=55971
<rdar://problem/8725312>

  • platform/mac/editing/input/insert-delete-smp-symbol-expected.txt: Added.
  • platform/mac/editing/input/insert-delete-smp-symbol.html: Added.

2011-03-10 Alexey Proskuryakov <ap@apple.com>

Reviewed by Dan Bernstein.

Backspace deletes all non-BMP symbols at once, and then some
https://bugs.webkit.org/show_bug.cgi?id=55971
<rdar://problem/8725312>

Test: platform/mac/editing/input/insert-delete-smp-symbol.html

  • rendering/RenderText.cpp: (WebCore::isMark): This matches what Core Foundation does for all characters that I tested. (WebCore::RenderText::previousOffsetForBackwardDeletion): Changed to use isMark().
4:41 PM Changeset in webkit [80790] by inferno@chromium.org
  • 1 edit in branches/chromium/696/Source/WebCore/dom/StyleElement.cpp

Merge 80787

BUG=75712

4:40 PM Changeset in webkit [80789] by Chris Fleizach
  • 7 edits in trunk/Source/WebKit2

REGRESSION (WebKit2): VoiceOver focus no longer follows keyboard focus
https://bugs.webkit.org/show_bug.cgi?id=55959

Reviewed by Darin Adler.

NSApplication has to return the focused element within the app in order
for NSAccessibilityHandleFocusChanged() to work. The default implementation
relies on keyWindow. Consequently, in WK2, the WebProcess must override that method
to return the appropriate focused element within the WebProcess, since
there is no keyWindow.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/mac/AccessibilityWebPageObject.mm:

(-[AccessibilityWebPageObject accessibilityFocusedUIElement]):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::focusedWebPage):

  • WebProcess/WebProcess.h:
  • WebProcess/mac/NSApplicationOverride.mm: Added.

(-[NSApplication accessibilityFocusedUIElement]):

4:40 PM Changeset in webkit [80788] by inferno@chromium.org
  • 1 edit in branches/chromium/648/Source/WebCore/dom/StyleElement.cpp

Merge 80787

BUG=75712
Review URL: http://codereview.chromium.org/6670019

4:36 PM Changeset in webkit [80787] by inferno@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-10 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Error in StyleElement::process with large nodesets
https://bugs.webkit.org/show_bug.cgi?id=56150

Test: none due to excessive runtime and CRASH() vs. real crash.

  • dom/StyleElement.cpp: (WebCore::StyleElement::process): Handle large node sets better.
4:34 PM Changeset in webkit [80786] by hyatt@apple.com
  • 3 edits
    4 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=47151

Reviewed by Simon Fraser.

Percentage heights should skip anonymous containing blocks when computing the used value.

Added fast/block/basic/percentage-height-inside-anonymous-block.html

Source/WebCore:

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePercentageLogicalHeight):

LayoutTests:

  • fast/block/basic/percent-height-inside-anonymous-block.html: Added.
  • platform/mac/fast/block/basic/percent-height-inside-anonymous-block-expected.checksum: Added.
  • platform/mac/fast/block/basic/percent-height-inside-anonymous-block-expected.png: Added.
  • platform/mac/fast/block/basic/percent-height-inside-anonymous-block-expected.txt: Added.
4:32 PM Changeset in webkit [80785] by commit-queue@webkit.org
  • 7 edits in trunk/Source

2011-03-10 Nat Duca <nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Make updateAndDrawLayers argumentless.
https://bugs.webkit.org/show_bug.cgi?id=55985

Made the TilePainters and viewport parameters for
LayerRendererChromium member variables instead of arguments on
updateAndDrawLayers. In a future change, this will allows us to
draw the layer tree without the WebView's assistance.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::verticalScrollbarRect): (WebCore::LayerRendererChromium::horizontalScrollbarRect): (WebCore::LayerRendererChromium::invalidateRootLayerRect): (WebCore::LayerRendererChromium::updateRootLayerContents): (WebCore::LayerRendererChromium::updateRootLayerScrollbars): (WebCore::LayerRendererChromium::drawRootLayer): (WebCore::LayerRendererChromium::setViewport): (WebCore::LayerRendererChromium::updateAndDrawLayers): (WebCore::LayerRendererChromium::updateLayers): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::setRootLayer): (WebCore::LayerRendererChromium::getFramebufferPixels): (WebCore::LayerRendererChromium::cleanupSharedObjects):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::viewportSize):
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::draw):

2011-03-10 Nat Duca <nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Make updateAndDrawLayers argumentless.
https://bugs.webkit.org/show_bug.cgi?id=55985

Made the TilePainters and viewport parameters for
LayerRendererChromium member variables instead of arguments on
updateAndDrawLayers. In a future change, this will allows us to
draw the layer tree without the WebView's assistance.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::resize): (WebKit::WebViewImpl::paint): (WebKit::WebViewImpl::scrollRootLayerRect): (WebKit::WebViewImpl::invalidateRootLayerRect): (WebKit::WebViewImplContentPainter::create): (WebKit::WebViewImplContentPainter::paint): (WebKit::WebViewImplContentPainter::WebViewImplContentPainter): (WebKit::WebViewImplScrollbarPainter::create): (WebKit::WebViewImplScrollbarPainter::paint): (WebKit::WebViewImplScrollbarPainter::WebViewImplScrollbarPainter): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::doComposite): (WebKit::WebViewImpl::reallocateRenderer): (WebKit::WebViewImpl::updateLayerRendererViewport):
  • src/WebViewImpl.h:
4:17 PM Changeset in webkit [80784] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

2011-03-10 Oleg Romashin <romaxa@gmail.com>

Reviewed by Andreas Kling.

Make Qt port compiling with ENABLE_PLUGIN_PROCESS=1, part3
Solving conflict of Qt and Xlib includes

  • Shared/Plugins/NPIdentifierData.cpp:
  • Shared/Plugins/NPIdentifierData.h:
  • Shared/Plugins/NPObjectProxy.cpp:
  • Shared/Plugins/NPVariantData.h:
4:12 PM Changeset in webkit [80783] by mrobinson@webkit.org
  • 5 edits
    3 adds in trunk

2011-01-25 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Implement spin buttons for GTK+ 2.x
https://bugs.webkit.org/show_bug.cgi?id=53098

Unskip tests which are now passing with the spin button implementation.
Add results for one test.

  • platform/gtk/Skipped: Unskip passing tests.
  • platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.checksum: Added.
  • platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Added.
  • platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt: Added.

2011-01-25 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Implement spin buttons for GTK+ 2.x
https://bugs.webkit.org/show_bug.cgi?id=53098

Implement spin buttons for GTK+ 2.x. This allows proper render and functioning
for input type=number. The implementation is based on the one in gtkspinbutton.c
from the GTK+ sources.

  • platform/gtk/RenderThemeGtk.h: Added new members and getters.
  • platform/gtk/RenderThemeGtk2.cpp: (WebCore::RenderThemeGtk::platformInit): Initialize spin button widget. (WebCore::RenderThemeGtk::adjustRepaintRect): We need to draw outside the spin button area to have proper rendering. There doesn't seem to be any other clean way of having spin buttons that are the size of the text input frame. (WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle): Added implementation. (WebCore::RenderThemeGtk::paintInnerSpinButton): Ditto. (WebCore::RenderThemeGtk::gtkSpinButton): Added.
4:05 PM Changeset in webkit [80782] by commit-queue@webkit.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-03-10 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Adam Roben.

PrettyPatch displays last two lines of a git-format-patch diff strangely
https://bugs.webkit.org/show_bug.cgi?id=29317

If the diff section has full range information, we parse only enough to cover the
range. This avoids incorrectly showing trailing lines (like git signature) as part
of the patch.

  • PrettyPatch/PrettyPatch.rb:
4:05 PM Changeset in webkit [80781] by andreas.kling@nokia.com
  • 5 edits in trunk/Source/WebKit/qt

2011-03-10 Andreas Kling <kling@webkit.org>

Unreviewed build fix after r80774.

QML property versioning is introduced in Qt 4.7.3, not 4.7.2.
See also: http://bugreports.qt.nokia.com/browse/QTBUG-13451

  • declarative/plugin.cpp: (WebKitQmlPlugin::registerTypes):
  • declarative/qdeclarativewebview.cpp:
  • declarative/qdeclarativewebview_p.h:
  • tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
3:50 PM Changeset in webkit [80780] by leviw@chromium.org
  • 8 edits
    2 adds in trunk

2011-03-10 Levi Weintraub <leviw@chromium.org>

Reviewed by Ryosuke Niwa.

InsertUnorderedList over a non-editable region and multiple lines enters an infinite loop
https://bugs.webkit.org/show_bug.cgi?id=53409

Avoiding crashes and infinite loops when listifying content with mixed-editability

  • editing/execCommand/insert-list-with-noneditable-content-expected.txt: Added.
  • editing/execCommand/insert-list-with-noneditable-content.html: Added.

2011-03-10 Levi Weintraub <leviw@chromium.org>

Reviewed by Ryosuke Niwa.

InsertUnorderedList over a non-editable region and multiple lines enters an infinite loop
https://bugs.webkit.org/show_bug.cgi?id=53409

Fixing broken handling of mixed-editability content for InsertListCommand. Previously, if the selection
spanned non-contenteditable regions, it would get stuck endlessly iterating the same region as the algorithm
didn't skip the editable boundary.

Test: editing/execCommand/insert-list-with-noneditable-content.html

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::cleanupAfterDeletion): Changed signature to take the destination position for the active editing command. Without this, there are cases when the destination happens to be a placeholder, and we remove it. (WebCore::CompositeEditCommand::moveParagraphs):
  • editing/CompositeEditCommand.h:
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply): Added logic to the paragraph iteration loop to handle pockets of non-editable content in an editable context. Previously, this could cause an infinite loop.
  • editing/visible_units.cpp: (WebCore::startOfParagraph): Added a mode of operation where we'll jump across non-editable content in the same paragraph to reach the actual editable paragraph start. (WebCore::endOfParagraph): Ditto. (WebCore::startOfNextParagraph): Now uses the aforementioned non-editable content skipping mode of endOfParagraph.
3:49 PM Changeset in webkit [80779] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

2011-03-10 Berend-Jan Wever <skylined@chromium.org>

Reviewed by Darin Adler.

Calling focus() on an area element not in a document should not cause a NULL ptr crash
https://bugs.webkit.org/show_bug.cgi?id=54877

  • fast/dom/HTMLAreaElement: Added.
  • fast/dom/HTMLAreaElement/area-islink-focus-null-ptr-crash-expected.txt: Added.
  • fast/dom/HTMLAreaElement/area-islink-focus-null-ptr-crash.html: Added.

2011-03-10 Berend-Jan Wever <skylined@chromium.org>

Reviewed by Darin Adler.

Calling focus() on an area element not in a document should not cause a NULL ptr crash
https://bugs.webkit.org/show_bug.cgi?id=54877

Test: fast/dom/HTMLAreaElement/area-islink-focus-null-ptr-crash.html

  • dom/Element.cpp: (WebCore::Element::focus): Check element is in the document before allowing focus
  • html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::imageElement): Check element has a parent before checking if its parent is a map
3:49 PM Changeset in webkit [80778] by rniwa@webkit.org
  • 5 edits in trunk/LayoutTests

2011-03-10 Ryosuke Niwa <rniwa@webkit.org>

Windows rebaselines for r80755.

  • platform/win/editing/selection/caret-ltr-right-expected.txt:
  • platform/win/editing/selection/caret-rtl-2-left-expected.txt:
  • platform/win/editing/selection/caret-rtl-right-expected.txt:
  • platform/win/fast/forms/file-input-disabled-expected.txt:
3:46 PM Changeset in webkit [80777] by tony@chromium.org
  • 3 edits
    2 adds in trunk

2011-03-10 Xiyuan Xia <xiyuan@chromium.org>

Reviewed by Tony Chang.

[Chromium] Fix default single selection select's popup background on chromium/linux
https://bugs.webkit.org/show_bug.cgi?id=56023

  • fast/html/select-dropdown-consistent-background-color-expected.txt: Added.
  • fast/html/select-dropdown-consistent-background-color.html: Added.

2011-03-10 Xiyuan Xia <xiyuan@chromium.org>

Reviewed by Tony Chang.

[Chromium] Fix default single selection select's popup background on chromium/linux
https://bugs.webkit.org/show_bug.cgi?id=56023

Test: fast/html/select-dropdown-consistent-background-color.html

  • css/themeChromiumLinux.css:
3:43 PM Changeset in webkit [80776] by commit-queue@webkit.org
  • 4 edits in trunk

2011-03-10 Kris Jordan <krisjordan@gmail.com>

Reviewed by Alexey Proskuryakov.

Testing the improved Accept header as per bug 27267.
https://bugs.webkit.org/show_bug.cgi?id=27267

  • http/tests/misc/xhtml-expected.txt: Tests against improved Accept header.

2011-03-10 Kris Jordan <krisjordan@gmail.com>

Reviewed by Alexey Proskuryakov.

Improve default Accept header to give preference to HTML over XML.
https://bugs.webkit.org/show_bug.cgi?id=27267

  • loader/FrameLoader.cpp:Changed default accept header to match FireFox' as per bug 27267.
3:41 PM Changeset in webkit [80775] by mrobinson@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-03-10 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] [Webkit2] There are no scrollbars visible in the MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=56125

No new tests. This functionality will be tested once we have TestRunner
implementation for WebKit2 with pixel dumping support.

  • GNUmakefile.am: Add a new define with tracks whether or not we are using our specialized GTK+ ScrollView.
  • platform/ScrollView.cpp: Only use the GTK+-specific ScrollView if we are compiling WebKit1. (WebCore::ScrollView::wheelEvent):
  • platform/gtk/ScrollViewGtk.cpp: Ditto.
3:36 PM Changeset in webkit [80774] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk/Source/WebKit/qt

2011-03-10 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] QtDeclarative Webview element has a fixed white background
https://bugs.webkit.org/show_bug.cgi?id=40918

Implement a way to change the background color of the WebView QML element.
This feature is activated for QtWebKit 1.1 version of the plugin.

  • declarative/plugin.cpp: (WebKitQmlPlugin::registerTypes):
  • declarative/qdeclarativewebview.cpp: (QDeclarativeWebView::backgroundColor): (QDeclarativeWebView::setBackgroundColor):
  • declarative/qdeclarativewebview_p.h:
  • tests/qdeclarativewebview/resources/webviewbackgroundcolor.qml: Added.
  • tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: (tst_QDeclarativeWebView::backgroundColor):
  • tests/qdeclarativewebview/tst_qdeclarativewebview.qrc:
3:32 PM Changeset in webkit [80773] by tkent@chromium.org
  • 8 edits
    2 adds in trunk

2011-03-10 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Assertion fails by validating a form twice very quickly
https://bugs.webkit.org/show_bug.cgi?id=56069

  • fast/forms/interactive-validation-assertion-by-validate-twice-expected.txt: Added.
  • fast/forms/interactive-validation-assertion-by-validate-twice.html: Added.
  • fast/forms/interactive-validation-attach-assertion.html: Remove unnecessary offsetLeft trick.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-03-10 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Assertion fails by validating a form twice very quickly
https://bugs.webkit.org/show_bug.cgi?id=56069

If the interactive validation is invoked when a form control is in
needsLayout() state, an assertion in isFocusable() fails. To avoid it,
Add a call to updateLayoutIgnorePendingStylesheets() before isFocusable().

Test: fast/forms/interactive-validation-assertion-by-validate-twice.html

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::validateInteractively): Calls updateLayoutIgnorePendingStylesheets().
3:29 PM Changeset in webkit [80772] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-10 Martin Robinson <mrobinson@igalia.com>

Unskipping some crashers on GTK+. These no longer crash locally and we'd
like to figure out if they still crash on the bots. Move one flaky test
to the appropriate section.

  • platform/gtk/Skipped: Unskip tests passing locally.
3:23 PM Changeset in webkit [80771] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/efl

2011-03-10 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Limit touch events when only page required touch events.
https://bugs.webkit.org/show_bug.cgi?id=54857

Block touch events when ChromeClient::needTouchEvents got false.

  • WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::needTouchEvents):
  • WebCoreSupport/ChromeClientEfl.h:
  • ewk/ewk_frame.cpp: (ewk_frame_feed_touch_event):
  • ewk/ewk_private.h:
  • ewk/ewk_view.cpp: (ewk_view_need_touch_events_set): (ewk_view_need_touch_events_get):
3:11 PM Changeset in webkit [80770] by hyatt@apple.com
  • 3 edits
    4 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=47143

Reviewed by Beth Dakin.

Static distance computation is wrong when an ancestor is also positioned. We need to go up the container()
chain (after initially starting with the parent()) when doing this computation, so that we properly skip
intermediate boxes between two positioned blocks.

Added fast/block/positioning/static-distance-with-positioned-ancestor.html.

Source/WebCore:

  • rendering/RenderBox.cpp:

(WebCore::computeInlineStaticDistance):
(WebCore::computeBlockStaticDistance):

LayoutTests:

  • fast/block/positioning/static-distance-with-positioned-ancestor.html: Added.
  • platform/mac/fast/block/positioning/static-distance-with-positioned-ancestor-expected.checksum: Added.
  • platform/mac/fast/block/positioning/static-distance-with-positioned-ancestor-expected.png: Added.
  • platform/mac/fast/block/positioning/static-distance-with-positioned-ancestor-expected.txt: Added.
3:10 PM Changeset in webkit [80769] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-03-10 Stanislav Paltis <Stanislav.Paltis@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] MemoryCache deadDecodedDataDeletionInterval is not exposed for client's usage
https://bugs.webkit.org/show_bug.cgi?id=55945

Added handling of dynamic/runtime property _q_deadDecodedDataDeletionInterval to
set interval used to trigger when decoded data in dead list of object cache will
be purged from object cache.

  • Api/qwebpage.cpp: (QWebPagePrivate::dynamicPropertyChangeEvent):
2:54 PM Changeset in webkit [80768] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/qt

2011-03-10 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Antonio Gomes.

Simplify how QWebFrame::requestedUrl() is obtained
https://bugs.webkit.org/show_bug.cgi?id=55842

When a load starts, store the requested URL until we know that it'll be
available for us in the document loader -- after load finished.

The existing auto tests cover the three different code paths in
requestedUrl() and the new code passes the autotests. In each of those
cases, we looked for the information in a different place, but in all
of them, dispatchDidStartProvisionalLoad was called.

This simplification will be useful to fix bug 32723. The way requestedUrl()
is implementent, we can't use it as a fallback for url() when the setUrl()
was called with an invalid URL.

  • Api/qwebframe.cpp: (QWebFrame::requestedUrl):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad): (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad):
  • WebCoreSupport/FrameLoaderClientQt.h: (WebCore::FrameLoaderClientQt::lastRequestedUrl):
2:47 PM Changeset in webkit [80767] by enne@google.com
  • 3 edits in trunk/Source/WebCore

2011-03-10 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

[chromium] Make tiled compositor data structure more efficient.
https://bugs.webkit.org/show_bug.cgi?id=54133

Previously, the compositor had a sparse 2D array of tiles for the
whole page, most of which were null. The tiles were implicitly
located based on their position in the array. This was inefficient
when the page grew (e.g. infinite scrolling) and caused some bugs
(e.g. width * height > MAX_INT). This change modifies tiles to have
explicit positions so they can be stored in a hash map.

Tests: LayoutTests/compositing/

  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::reset): (WebCore::LayerTilerChromium::createTile): (WebCore::LayerTilerChromium::invalidateTiles): (WebCore::LayerTilerChromium::contentRectToTileIndices): (WebCore::LayerTilerChromium::tileAt): (WebCore::LayerTilerChromium::tileContentRect): (WebCore::LayerTilerChromium::tileLayerRect): (WebCore::LayerTilerChromium::invalidateRect): (WebCore::LayerTilerChromium::invalidateEntireLayer): (WebCore::LayerTilerChromium::update): (WebCore::LayerTilerChromium::updateFromPixels): (WebCore::LayerTilerChromium::draw): (WebCore::LayerTilerChromium::growLayerToContain):
  • platform/graphics/chromium/LayerTilerChromium.h: (WebCore::LayerTilerChromium::Tile::Tile): (WebCore::LayerTilerChromium::Tile::i): (WebCore::LayerTilerChromium::Tile::j): (WebCore::LayerTilerChromium::Tile::moveTo): (WebCore::LayerTilerChromium::TileMapKeyTraits::emptyValue): (WebCore::LayerTilerChromium::TileMapKeyTraits::constructDeletedValue): (WebCore::LayerTilerChromium::TileMapKeyTraits::isDeletedValue):
2:39 PM Changeset in webkit [80766] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-10 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed build fix for r80752; Negated the boolean logic.

  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::next): (WebCore::VisiblePosition::previous):
2:28 PM Changeset in webkit [80765] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2
  • Fix plugins in release and production builds.

Reviewed by Mark Rowe.

  • WebKit2.xcodeproj/project.pbxproj:

Make sure to base the PluginProcess target on the correct xcconfig file
in all configurations.

2:24 PM Changeset in webkit [80764] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

Make the same change to xheight on Windows for CG.

Reviewed by Adam Roben.

  • platform/graphics/win/SimpleFontDataCGWin.cpp:

(WebCore::SimpleFontData::platformInit):

2:17 PM Changeset in webkit [80763] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/mac

<rdar://problem/9117047>
Don't paint more than 60 times per second even when scrolling

Reviewed by Sam Weinig.

  • WebView/WebClipView.mm:

(-[WebClipView _immediateScrollToPoint:]):

2:16 PM Changeset in webkit [80762] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-10 Tony Chang <tony@chromium.org>

Unreviewed, roll chromium version to r77259 to pick up
webfontinfo api change.

  • DEPS:
2:13 PM Changeset in webkit [80761] by hyatt@apple.com
  • 6 edits
    8 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=47147

Reviewed by Simon Fraser.

Fix for repaint issues when the root element is a table and needs to paint a background that
covers the entire canvas. Remove paintRootBoxDecorations and replace with paintRootBoxFillLayers,
so that it can be called only for fill layer painting. Make tables and normal boxes both
call this new method. Fix the dirty check at the start of RenderTable paint to not happen if
the table is the root of the document (this same check exists in RenderBlock painting already).

Source/WebCore:

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintRootBoxFillLayers):
(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::paintBoxDecorationsWithSize):

  • rendering/RenderBox.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::calculateCompositedBounds):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::paint):
(WebCore::RenderTable::paintBoxDecorations):

LayoutTests:

  • fast/backgrounds/positioned-root.html: Added.
  • fast/backgrounds/table-root.html: Added.
  • platform/mac/fast/backgrounds/positioned-root-expected.checksum: Added.
  • platform/mac/fast/backgrounds/positioned-root-expected.png: Added.
  • platform/mac/fast/backgrounds/positioned-root-expected.txt: Added.
  • platform/mac/fast/backgrounds/table-root-expected.checksum: Added.
  • platform/mac/fast/backgrounds/table-root-expected.png: Added.
  • platform/mac/fast/backgrounds/table-root-expected.txt: Added.
2:06 PM Changeset in webkit [80760] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-10 Mihai Parparita <mihaip@chromium.org>

Update chromium Snow Leopard expectations.

  • platform/chromium/test_expectations.txt:
2:00 PM Changeset in webkit [80759] by tonyg@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-03-10 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80749.
http://trac.webkit.org/changeset/80749
https://bugs.webkit.org/show_bug.cgi?id=56143

"Caused at least 3 media tests to be flaky" (Requested by
tonyg-cr on #webkit).

  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::canTakeNextToken): (WebCore::HTMLDocumentParser::pumpTokenizer):
  • html/parser/HTMLParserScheduler.cpp:
  • html/parser/HTMLParserScheduler.h: (WebCore::HTMLParserScheduler::checkForYieldBeforeToken):
  • page/FrameView.h:
1:44 PM Changeset in webkit [80758] by alex
  • 2 edits in trunk

2011-03-10 Alejandro G. Castro <alex@igalia.com>

Unreviewed, fixed Efl compilation after r80744.

  • Source/cmake/OptionsEfl.cmake:
1:43 PM Changeset in webkit [80757] by weinig@apple.com
  • 6 edits in trunk/Source/WebCore

Regression: Content not drawn when scrolling horizontally in an RTL page
https://bugs.webkit.org/show_bug.cgi?id=55077

Reviewed by David Hyatt.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::overhangAmount):
(WebCore::ScrollView::calculateOverhangAreasForPainting):
Take the scroll origin into account when calculating overhang.

  • platform/ScrollView.h:
  • rendering/RenderLayer.h:
  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::scrollOrigin):
Move identical scroll origin member from ScrollView and RenderLayer
to shared base ScrollableArea. This is also needed so that the animator
can access it.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::pinnedInDirection):
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
Account for a scroll origin when doing calculating scroll offsets.

1:41 PM Changeset in webkit [80756] by mdelaney@apple.com
  • 15 edits in trunk/Source

2011-03-09 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Plumb through settings for accelerated drawing for canvas
https://bugs.webkit.org/show_bug.cgi?id=56039

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:
  • WebView/WebPreferencesPrivate.h:

2011-03-09 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Plumb through settings for accelerated drawing for canvas
https://bugs.webkit.org/show_bug.cgi?id=56039

No new tests. Doesn't affect behavior, just adding a switch to toggle canvas backends.

  • WebCore.exp.in:
  • html/HTMLCanvasElement.cpp:
  • html/canvas/CanvasRenderingContext2D.cpp:
  • page/Settings.cpp:
  • page/Settings.h:

2011-03-09 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Plumb through settings for accelerated drawing for canvas
https://bugs.webkit.org/show_bug.cgi?id=56039

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp:
  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:
1:27 PM Changeset in webkit [80755] by hyatt@apple.com
  • 71 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=47157

Reviewed by Simon Fraser.

CSS2.1 test suite failures because the ex unit is broken with the Ahem font.

Remove the code that tries to also include the maxX of the glyph bounds for the
'x' glyph, since it just causes the x-height to be way too large in cases where the 'x' glyph extends
below the baseline.

Remove the Apple Symbol hack for ex units, since the person who added that was confused by another
issue, namely that CGFontGetXHeight wasn't being properly multiplied by the pointSize. That's why
the value was too small. Patched the code to just multiply by pointSize and took out the hack.

Fix causes many tests in the css2.1 directory to progress, so no new tests required. Many other
layout tests change because the xHeight for Lucida Grande gets smaller by a little bit, and radio
buttons use ex horizontal margins by default.

Source/WebCore:

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformInit):

LayoutTests:

  • platform/mac/accessibility/radio-button-group-members-expected.txt:
  • platform/mac/css1/box_properties/acid_test-expected.txt:
  • platform/mac/css1/font_properties/font_size-expected.txt:
  • platform/mac/css1/text_properties/line_height-expected.txt:
  • platform/mac/css1/text_properties/text_indent-expected.txt:
  • platform/mac/css1/units/length_units-expected.txt:
  • platform/mac/css2.1/t040302-c61-ex-len-00-b-a-expected.txt:
  • platform/mac/css2.1/t040302-c61-rel-len-00-b-ag-expected.txt:
  • platform/mac/css2.1/t09-c5526c-display-00-e-expected.txt:
  • platform/mac/css2.1/t1008-c44-ln-box-02-d-ag-expected.txt:
  • platform/mac/css2.1/t100801-c544-valgn-01-d-ag-expected.txt:
  • platform/mac/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
  • platform/mac/css2.1/t100801-c548-ln-ht-02-b-ag-expected.txt:
  • platform/mac/css2.1/t1507-c526-font-sz-02-b-a-expected.txt:
  • platform/mac/css2.1/t1601-c547-indent-00-b-a-expected.txt:
  • platform/mac/css2.1/t1604-c541-word-sp-00-b-a-expected.txt:
  • platform/mac/css2.1/t1604-c542-letter-sp-00-b-a-expected.txt:
  • platform/mac/editing/selection/caret-ltr-2-expected.txt:
  • platform/mac/editing/selection/caret-ltr-2-left-expected.txt:
  • platform/mac/editing/selection/caret-ltr-expected.txt:
  • platform/mac/editing/selection/caret-ltr-right-expected.txt:
  • platform/mac/editing/selection/caret-rtl-2-expected.txt:
  • platform/mac/editing/selection/caret-rtl-2-left-expected.txt:
  • platform/mac/editing/selection/caret-rtl-expected.txt:
  • platform/mac/editing/selection/caret-rtl-right-expected.txt:
  • platform/mac/fast/block/basic/011-expected.txt:
  • platform/mac/fast/block/margin-collapse/103-expected.txt:
  • platform/mac/fast/css/ex-after-font-variant-expected.txt:
  • platform/mac/fast/css/non-standard-checkbox-size-expected.txt:
  • platform/mac/fast/forms/001-expected.txt:
  • platform/mac/fast/forms/basic-inputs-expected.txt:
  • platform/mac/fast/forms/box-shadow-override-expected.txt:
  • platform/mac/fast/forms/checkbox-radio-onchange-expected.txt:
  • platform/mac/fast/forms/file-input-disabled-expected.txt:
  • platform/mac/fast/forms/form-element-geometry-expected.txt:
  • platform/mac/fast/forms/formmove-expected.txt:
  • platform/mac/fast/forms/formmove2-expected.txt:
  • platform/mac/fast/forms/indeterminate-expected.txt:
  • platform/mac/fast/forms/input-appearance-height-expected.txt:
  • platform/mac/fast/forms/input-value-expected.txt:
  • platform/mac/fast/forms/minWidthPercent-expected.txt:
  • platform/mac/fast/forms/radio-attr-order-expected.txt:
  • platform/mac/fast/forms/radio-nested-labels-expected.txt:
  • platform/mac/fast/forms/radio_checked-expected.txt:
  • platform/mac/fast/forms/radio_checked_dynamic-expected.txt:
  • platform/mac/fast/inline/positionedLifetime-expected.txt:
  • platform/mac/fast/lists/008-expected.txt:
  • platform/mac/fast/lists/008-vertical-expected.txt:
  • platform/mac/fast/media/mq-relative-constraints-08-expected.txt:
  • platform/mac/fast/overflow/overflow-rtl-expected.txt:
  • platform/mac/fast/overflow/overflow-rtl-vertical-expected.txt:
  • platform/mac/fast/parser/bad-xml-slash-expected.txt:
  • platform/mac/fast/replaced/replaced-breaking-expected.txt:
  • platform/mac/fast/replaced/width100percent-checkbox-expected.txt:
  • platform/mac/fast/replaced/width100percent-radio-expected.txt:
  • platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/mac/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
  • platform/mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
  • platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/mac/svg/custom/alignment-baseline-modes-expected.txt:
  • platform/mac/svg/custom/dominant-baseline-modes-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/core/captions1-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/core/captions2-expected.txt:
  • svg/custom/invalid-text-content-expected.png:
  • svg/custom/text-zoom-expected.png:
  • svg/custom/use-clipped-transform-expected.png:
1:17 PM Changeset in webkit [80754] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip a test that sometimes times out in Windows Debug builds

<http://webkit.org/b/56080> tracks the failure.

  • platform/win-xp/Skipped: Added jquery/effects.html. (Ideally we'd only skip this in Debug

builds regardless of whether it's XP or Vista or 7, but doing that requires fixing
<http://webkit.org/b/55254>.)

1:17 PM Changeset in webkit [80753] by jberlin@webkit.org
  • 15 edits
    1 add in trunk/Source/WebKit2

WebKit2: Need a way to clear only the in-memory resource caches
https://bugs.webkit.org/show_bug.cgi?id=56022

Reviewed by Oliver Hunt and Brian Weinstein.

Add a parameter to WKContextClearResourceCaches to specify whether to clear all the caches
or just the memory caches.

  • Shared/ResourceCachesToClear.h: Added.
  • UIProcess/API/C/WKAPICast.h:

(WebKit::toResourceCachesToClear):

  • UIProcess/API/C/WKContext.cpp:

(WKContextClearResourceCaches):
Add the new parameter.

  • UIProcess/API/C/WKContext.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::clearResourceCaches):
Ditto.

  • UIProcess/WebContext.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::clearResourceCaches):
Pass the new parameter through to the platform-specific functions.

  • WebProcess/WebProcess.h:

Add the new parameter and give it a default of AllResourceCaches.

  • WebProcess/WebProcess.messages.in:

Ditto.

  • WebProcess/gtk/WebProcessGtk.cpp:

(WebKit::WebProcess::platformClearResourceCaches):
Ditto.

  • WebProcess/qt/WebProcessQt.cpp:

(WebKit::WebProcess::platformClearResourceCaches):
Ditto.

  • WebProcess/win/WebProcessWin.cpp:

(WebKit::WebProcess::platformClearResourceCaches):
When told to clear only the in-memory caches, return early so as not to clear the CFNetwork
disk cache.

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::platformClearResourceCaches):
Ditto.

  • WebKit2.xcodeproj/project.pbxproj:

Add ResourceCachesToClear.h

  • win/WebKit2.vcproj:

Ditto.

1:15 PM Changeset in webkit [80752] by rniwa@webkit.org
  • 18 edits in trunk/Source

2011-03-10 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

VisiblePosition's next and previous should take an enum instead of a boolean
https://bugs.webkit.org/show_bug.cgi?id=56135

SelectionController::isAll now takes EditingBoundaryCrossingRule instead of
StayInEditableContent.

  • WebView/WebView.mm: (-[WebView _selectionIsAll]):

2011-03-10 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

VisiblePosition's next and previous should take an enum instead of a boolean
https://bugs.webkit.org/show_bug.cgi?id=56135

Changed the argument type of VisiblePosition::next and VisiblePosition::previous
from bool to EditingBoundaryCrossingRule. Also got rid of StayInEditableContent enum
in VisibleSelection and replaced it by EditingBoundaryCrossingRule because the enum
was only used in VisiblePosition::isAll and subsequently in SelectionController::isAll
to call VisiblePosition::next and VisiblePosition::previous.

  • WebCore.exp.in:
  • dom/Position.cpp: (WebCore::Position::trailingWhitespacePosition):
  • editing/ApplyBlockElementCommand.cpp: (WebCore::ApplyBlockElementCommand::doApply):
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply): (WebCore::InsertListCommand::listifyParagraph):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::shouldMergeStart): (WebCore::ReplaceSelectionCommand::shouldMergeEnd): (WebCore::ReplaceSelectionCommand::doApply):
  • editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingRight): (WebCore::SelectionController::modifyExtendingForward): (WebCore::SelectionController::modifyMovingForward): (WebCore::SelectionController::modifyExtendingLeft): (WebCore::SelectionController::modifyExtendingBackward): (WebCore::SelectionController::modifyMovingBackward):
  • editing/SelectionController.h: (WebCore::SelectionController::isAll):
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed):
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::next): (WebCore::VisiblePosition::previous):
  • editing/VisiblePosition.h:
  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::isAll): (WebCore::VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGranularity):
  • editing/VisibleSelection.h:
  • editing/htmlediting.cpp: (WebCore::selectionForParagraphIteration):
  • editing/visible_units.cpp: (WebCore::startOfNextParagraph):
1:12 PM Changeset in webkit [80751] by oliver@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

2011-03-10 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Fix allocation of native function with a cached thunk
https://bugs.webkit.org/show_bug.cgi?id=56127

Fix this race condition found while fixing zombies.

  • collector/handles/HandleHeap.cpp: (JSC::HandleHeap::clearWeakPointers):
  • runtime/Heap.cpp: (JSC::Heap::reset):
  • runtime/JSFunction.cpp: (JSC::JSFunction::JSFunction): (JSC::JSFunction::markChildren):
  • runtime/JSValue.h: (JSC::JSValue::decode):
  • runtime/JSZombie.cpp: (JSC::JSZombie::leakedZombieStructure):
  • runtime/JSZombie.h: (JSC::JSZombie::createStructure):
  • runtime/MarkedBlock.cpp:
1:08 PM Changeset in webkit [80750] by mihaip@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-03-10 Mihai Parparita <mihaip@chromium.org>

Reviewed by Tony Gentilcore.

Remove CRASH() calls added to track down bug 53045
https://bugs.webkit.org/show_bug.cgi?id=56137

Remove CRASH() calls added by r76575 and re-label ones added by r80155
and r80269 as being associated with bug 56124 (which may still be
happening).

  • css/CSSImageValue.cpp: (WebCore::CSSImageValue::cachedImage):
  • css/CSSSelector.h:
  • css/CSSSelectorList.cpp: (WebCore::CSSSelectorList::deleteSelectors):
  • loader/cache/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::~CachedResource):
  • loader/cache/CachedResource.h:
12:57 PM Changeset in webkit [80749] by tonyg@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-03-10 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Let the parser yield for layout before running scripts
https://bugs.webkit.org/show_bug.cgi?id=54355

Prior to this patch, the parser would yield to perform a layout/paint before running a
script only if the script or a stylesheet blocking the script is not loaded yet. Since we
don't preload scan into the body while parsing the head, typically we'll block on a script
early in the body that causes us to yield to do the first paint within a reasonable time.

However, I'm planning to change the PreloadScanner to scan into the body from the head.
That significantly improves overall load time, but would hurt first paint time because
fewer scripts would be blocked during parsing and thus wouldn't yield.

This change causes us to yield before running scripts if we haven't painted yet (regardless
of whether or not the script is loaded). In addition to allowing the above mentioned
PreloadScanner change to be implemented without regressing first paint time, this also
improves first paint time by itself.

I tested Alexa's top 45 websites using Web Page Replay to control the content and simulate
bandwidth. This patch improved average first paint time by 1% over an unlimited connection,
6% over a 1Mbps connection and 11% over a 5Mbps connection. There was no statistically
signifcant change in page load time.

Within the pages tested, 33 had no statistically significant change in time to first paint,
12 improved, and none regressed. Of the improved, some of the standouts from the 1Mbps set
are: 20% on youtube, 37% on wiki, 27% on ebay, 13% on cnn, 16% on espn, 74% on sohu.

  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::canTakeNextToken): This is the new yield point. (WebCore::HTMLDocumentParser::pumpTokenizer): Remove ASSERT that we are not paused. isPaused means that we are waiting for a script. Bug 54574 changed pumpTokenizer() so that it does the right thing whether we are just before a token or waiting for a script. Now that we may yield before a token or before a script, this may be called while paused.
  • html/parser/HTMLParserScheduler.cpp: (WebCore::HTMLParserScheduler::checkForYieldBeforeScript): Added.
  • page/FrameView.h: (WebCore::FrameView::hasEverPainted): Added.
12:53 PM Changeset in webkit [80748] by Adam Roben
  • 2 edits in trunk/Tools

Ignore errors from files being held open when creating a test result archive

Fixes <http://webkit.org/b/55581> Test results don't get uploaded if test-result-archive
fails to delete the results directory

Reviewed by Mark Rowe.

  • BuildSlaveSupport/test-result-archive:

(archiveTestResults): Ignore errno 2 when deleting the results directory, since it can be
thrown when a process is holding a file open.

12:41 PM Changeset in webkit [80747] by mrobinson@webkit.org
  • 2 edits in trunk

2011-03-10 Martin Robinson <mrobinson@igalia.com>

Fixed the help message for WebGL support on GTK+ to reflect the fact that
it's turned off by default and is experimental.

  • configure.ac: Fix WebGL help message.
12:40 PM Changeset in webkit [80746] by luiz@webkit.org
  • 5 edits in trunk

[Qt] fast/workers/stress-js-execution.html is crashing on Qt bot (intermittently)
https://bugs.webkit.org/show_bug.cgi?id=33008

Reviewed by Andreas Kling.

Source/JavaScriptCore:

Defining WTF_USE_PTHREAD_BASED_QT=1 for platforms where QThread uses pthread internally.
Symbian is excluded because pthread_kill does not work on it. Mac is excluded because
it has its own ways to do JSC threading.

Defining WTF_USE_PTHREADS inside MachineStackMarker.cpp if USE(PTHREAD_BASED_QT) is true.

  • runtime/MachineStackMarker.cpp:
  • wtf/Platform.h:

LayoutTests:

Removing several tests from the Qt skip list. Those tests were flaky because of race conditions
related to web workers.

  • platform/qt/Skipped:
12:39 PM Changeset in webkit [80745] by jeffm@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-10 Jeff Miller <jeffm@apple.com>

Reviewed by Adam Roben.

WKViewRegisterEditCommandCallback should use WKViewUndoType
https://bugs.webkit.org/show_bug.cgi?id=56120

  • UIProcess/API/C/win/WKView.h: Change undoOrRedo parameter in WKViewRegisterEditCommandCallback to be WKViewUndoType.
12:32 PM Changeset in webkit [80744] by alex
  • 7 edits in trunk/Source/WebCore

2011-03-10 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

Some Gtk code uses defined(USE_FREETYPE) instead of just USE(FREETYPE)
https://bugs.webkit.org/show_bug.cgi?id=55996

Use the macre USE instead of defined fro WTF_USE_FREETYPE and
WTF_USE_PANGO.

  • GNUmakefile.am:
  • platform/graphics/cairo/OwnPtrCairo.cpp:
  • platform/graphics/cairo/OwnPtrCairo.h:
  • platform/graphics/cairo/RefPtrCairo.cpp:
  • platform/graphics/cairo/RefPtrCairo.h:
  • platform/graphics/gtk/FontGtk.cpp: (WebCore::setPangoAttributes): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText):
12:31 PM Changeset in webkit [80743] by barraclough@apple.com
  • 18 edits in trunk

Bug 56077 - ES5 conformance issues with RegExp.prototype

Reviewed by Oliver Hunt.

There are three issues causing test failures in sputnik.

(1) lastIndex should be converted at the point it is used, not the point it is set (this is visible if valueOf is overridden).
(2) The 'length' property of the test/exec functions should be 1.
(3) If no input is specified, the input to test()/exec() is "undefined" (i.e. ToString(undefined)) - not RegExp.input.

Source/JavaScriptCore:

  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::markChildren):

  • Added to mark lastIndex

(JSC::regExpObjectLastIndex):
(JSC::setRegExpObjectLastIndex):

  • lastIndex is now stored as a JSValue.

(JSC::RegExpObject::match):

  • Use accessor methods to get/set lastIndex, add fast case for isUInt32 (don't convert to double).
  • runtime/RegExpObject.h:

(JSC::RegExpObject::setLastIndex):
(JSC::RegExpObject::setLastIndex):

  • Set lastIndex, either from a size_t or a JSValue.

(JSC::RegExpObject::getLastIndex):

  • Get lastIndex.

(JSC::RegExpObject::RegExpObjectData::RegExpObjectData):

  • Initialize as a JSValue.
  • runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::RegExpPrototype):

  • Add test/exec properties with length 1.
  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):

  • Do not read RegExp.input if none is provided.
  • tests/mozilla/js1_2/regexp/RegExp_input.js:
  • tests/mozilla/js1_2/regexp/RegExp_input_as_array.js:
    • Update these tests (they relied on non-ES5 behaviour).

LayoutTests:

  • fast/js/kde/function_length-expected.txt:
  • fast/js/kde/script-tests/function_length.js:
    • 'length' of RexExp.test/RexExp.exec is 1
  • fast/js/regexp-caching-expected.txt:
  • fast/js/regexp-test-null-string-expected.txt:
  • fast/js/regexp-test-null-string.html:
    • test() is equivalent to test("undefined")
  • sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.6/15.10.6.2_RegExp.prototype.exec/S15.10.6.2_A11-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.6/15.10.6.2_RegExp.prototype.exec/S15.10.6.2_A1_T16-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.6/15.10.6.2_RegExp.prototype.exec/S15.10.6.2_A4_T11-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.6/15.10.6.3_RegExp.prototype.test/S15.10.6.3_A11-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.6/15.10.6.3_RegExp.prototype.test/S15.10.6.3_A1_T16-expected.txt:
    • These tests now pass!
12:25 PM Changeset in webkit [80742] by ggaren@apple.com
  • 30 edits in trunk/Source

2011-03-10 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Rolled back in 80277 and 80280 with event handler layout test failures fixed.
https://bugs.webkit.org/show_bug.cgi?id=55653

The failures were caused by a last minute typo: assigning to currentEvent
instead of m_currentEvent.

  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecompiler/BytecodeGenerator.cpp:
  • jit/JITOpcodes.cpp:
  • jit/JITOpcodes32_64.cpp:
  • runtime/Arguments.h:
  • runtime/JSActivation.cpp:
  • runtime/JSActivation.h:
  • runtime/JSCell.h:
  • runtime/JSGlobalObject.cpp:
  • runtime/JSGlobalObject.h:
  • runtime/JSObject.cpp:
  • runtime/JSStaticScopeObject.cpp:
  • runtime/JSStaticScopeObject.h:
  • runtime/JSVariableObject.h:
  • runtime/MarkedSpace.cpp:
  • runtime/MarkedSpace.h:

2011-03-10 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Rolled back in 80277 and 80280 with event handler layout test failures fixed.
https://bugs.webkit.org/show_bug.cgi?id=55653

The failures were caused by a last minute typo: assigning to currentEvent
instead of m_currentEvent.

  • JSRun.cpp:
  • JSRun.h:

2011-03-10 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Rolled back in 80277 and 80280 with event handler layout test failures fixed.
https://bugs.webkit.org/show_bug.cgi?id=55653

The failures were caused by a last minute typo: assigning to currentEvent
instead of m_currentEvent.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMGlobalObject.cpp:
  • bindings/js/JSDOMGlobalObject.h:
  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowCustom.h:
  • bindings/js/JSWorkerContextBase.cpp:
12:22 PM Changeset in webkit [80741] by Adam Roben
  • 2 edits in trunk/Websites/bugs.webkit.org

Don't search for intra-line diffs in really long lines

Doing so can lead to hangs (or at least really slow execution).

Fixes <http://webkit.org/b/56109> run-webkit-tests sometimes times out on Windows XP Debug
(Tests) after fast/text/large-text-composed-char-dos.html fails (due to PrettyPatch
hanging?)

Reviewed by David Kilzer.

  • PrettyPatch/PrettyPatch.rb:

(PrettyPatch.MAXIMUM_INTRALINE_DIFF_LINE_LENGTH): Added this new constant.
(PrettyPatch.DiffSection.initialize): Don't bother looking for intra-line diffs in lines
longer than the maximum length.

12:15 PM Changeset in webkit [80740] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=56129, vertical text broken on Lion and Leopard.

Reviewed by Dan Bernstein.

Add Snow Leopard ifdefs for the scaling by point size and then the division by unitsPerEm to the
translationsTransform applied to the results from CTFontGetVerticalTranslationsForGlyphs, since
this is done already on Lion and Leopard.

  • platform/graphics/mac/FontMac.mm:

(WebCore::showGlyphsWithAdvances):

11:33 AM Changeset in webkit [80739] by mihaip@chromium.org
  • 31 edits
    4 deletes in trunk

2011-03-10 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80701.
http://trac.webkit.org/changeset/80701
https://bugs.webkit.org/show_bug.cgi?id=56126

fast/dom/Geolocation/window-close-crash.html fails on Snow
Leopard release builds (Requested by mihaip on #webkit).

  • fast/dom/Geolocation/page-reload-cancel-permission-requests-expected.txt: Removed.
  • fast/dom/Geolocation/page-reload-cancel-permission-requests.html: Removed.
  • fast/dom/Geolocation/resources/page-reload-cancel-permission-requests-inner.html: Removed.
  • fast/dom/Geolocation/script-tests/page-reload-cancel-permission-requests.js: Removed.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt-wk2/Skipped:

2011-03-10 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80701.
http://trac.webkit.org/changeset/80701
https://bugs.webkit.org/show_bug.cgi?id=56126

fast/dom/Geolocation/window-close-crash.html fails on Snow
Leopard release builds (Requested by mihaip on #webkit).

  • page/DOMWindow.cpp:
  • page/DOMWindow.h:
  • page/Frame.cpp: (WebCore::Frame::pageDestroyed): (WebCore::Frame::transferChildFrameToNewDocument):
  • page/Geolocation.cpp: (WebCore::Geolocation::~Geolocation): (WebCore::Geolocation::disconnectFrame): (WebCore::Geolocation::lastPosition): (WebCore::Geolocation::requestPermission): (WebCore::Geolocation::startUpdating): (WebCore::Geolocation::stopUpdating):
  • page/Geolocation.h:
  • page/GeolocationController.cpp: (WebCore::GeolocationController::~GeolocationController):
  • page/Navigator.cpp:
  • page/Navigator.h:
  • platform/mock/GeolocationClientMock.cpp:
  • platform/mock/GeolocationClientMock.h:

2011-03-10 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80701.
http://trac.webkit.org/changeset/80701
https://bugs.webkit.org/show_bug.cgi?id=56126

fast/dom/Geolocation/window-close-crash.html fails on Snow
Leopard release builds (Requested by mihaip on #webkit).

  • public/WebGeolocationClientMock.h:
  • src/WebGeolocationClientMock.cpp:

2011-03-10 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80701.
http://trac.webkit.org/changeset/80701
https://bugs.webkit.org/show_bug.cgi?id=56126

fast/dom/Geolocation/window-close-crash.html fails on Snow
Leopard release builds (Requested by mihaip on #webkit).

  • DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:
  • DumpRenderTree/mac/UIDelegate.h:
  • DumpRenderTree/mac/UIDelegate.mm:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp:
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:
11:27 AM Changeset in webkit [80738] by oliver@apple.com
  • 10 edits in trunk

2011-03-10 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

jquery/manipulation.html fails after r80598
https://bugs.webkit.org/show_bug.cgi?id=56019

Removed jQuery tests from skiplists

  • platform/gtk/Skipped:
  • platform/qt/Skipped:

2011-03-09 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

jquery/manipulation.html fails after r80598
https://bugs.webkit.org/show_bug.cgi?id=56019

When linking a call, codeblock now takes ownership of the linked function
This removes the need for unlinking, and thus the incorrectness that was
showing up in these tests.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::~CodeBlock): (JSC::CodeBlock::markAggregate):
  • bytecode/CodeBlock.h: (JSC::CallLinkInfo::CallLinkInfo): (JSC::CallLinkInfo::setUnlinked): (JSC::CodeBlock::addCaller):
  • jit/JIT.cpp: (JSC::JIT::privateCompile): (JSC::JIT::linkCall): (JSC::JIT::linkConstruct):
  • jit/JIT.h:
  • runtime/Executable.cpp:
  • runtime/Executable.h:
11:22 AM Changeset in webkit [80737] by rniwa@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2011-03-10 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Ojan Vafai.

Unable to paste in input[type="text"] with last-child selector
https://bugs.webkit.org/show_bug.cgi?id=50736

Added regressions tests since this bug no longer reproduces on TOT WebKit.

  • editing/input/div-first-child-rule-input-expected.txt: Added.
  • editing/input/div-first-child-rule-input.html: Added.
  • editing/input/div-first-child-rule-textarea-expected.txt: Added.
  • editing/input/div-first-child-rule-textarea.html: Added.
10:44 AM Changeset in webkit [80736] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-10 Martin Robinson <mrobinson@igalia.com>

[GTK] plugins/return-negative-one-from-write.html crashes
https://bugs.webkit.org/show_bug.cgi?id=41903

  • platform/gtk/Skipped: Unskipping test which appears to be passing locally.
10:20 AM Changeset in webkit [80735] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-10 Adam Barth <abarth@webkit.org>

Update test expectation after my partial revert of r80670.

  • platform/mac/accessibility/aria-expanded-notifications-expected.txt:
10:14 AM Changeset in webkit [80734] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

2011-03-10 Pratik Solanki <psolanki@apple.com>

Reviewed by Alexey Proskuryakov.

ASSERT_NOT_REACHED triggered in WebCore::mapHTTPPipeliningPriorityToResourceLoadPriority
https://bugs.webkit.org/show_bug.cgi?id=56075

Map priority value 3, which means no priority, to ResourceLoadPriorityUnresolved.

  • platform/network/cf/ResourceRequestCFNet.h: (WebCore::mapHTTPPipeliningPriorityToResourceLoadPriority): (WebCore::mapResourceLoadPriorityToHTTPPipeliningPriority):
9:52 AM Changeset in webkit [80733] by andreip@google.com
  • 2 edits in trunk/LayoutTests

2011-03-10 Andrei Popescu <andreip@google.com>

Unreviewed, build fix.

[Chromium] fast/canvas/webgl/uninitialized-test.html times out on all platforms.
https://bugs.webkit.org/show_bug.cgi?id=56113

It seems this was introduced in http://src.chromium.org/viewvc/chrome?view=rev&revision=77637
Updating test expectations for now.

  • platform/chromium/test_expectations.txt:
9:18 AM Changeset in webkit [80732] by mihaip@chromium.org
  • 2 edits in branches/chromium/696/Source/WebCore

Merge 80686 - 2011-03-09 Mihai Parparita <mihaip@chromium.org>

Reviewed by Tony Gentilcore.

REGRESSION (r74807): memory corruption after CachedResourceLoader refactoring
https://bugs.webkit.org/show_bug.cgi?id=53045

Copy the URL out of the CachedResource that is being revalidated, so
that we can still use it (in m_validatedURLs) after removing the
resource from the memory cache, which may delete it.

No new tests, since I was not able to trigger this locally (in a layout
test or otherwise).

  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::revalidateResource):

TBR=mihaip@chromium.org
BUG=68516

9:06 AM Changeset in webkit [80731] by andreip@google.com
  • 2 edits in trunk/LayoutTests

2011-03-10 Andrei Popescu <andreip@google.com>

Unreviewed, build fix.

[Chromium] svg/W3C-SVG-1.1/text-text-03-b.svg is sometimes crashing on Linux
https://bugs.webkit.org/show_bug.cgi?id=56110

  • platform/chromium/test_expectations.txt:
9:05 AM Changeset in webkit [80730] by Adam Roben
  • 1 edit
    1 add in trunk/LayoutTests

Add Windows expected failure results for fast/forms/onchange-setvalueforuser.html

The failure is tracked by <http://webkit.org/b/55834>.

  • platform/win/fast/forms/onchange-setvalueforuser-expected.txt: Added.
9:03 AM Changeset in webkit [80729] by Adam Roben
  • 1 edit
    4 adds in trunk/LayoutTests

Add Windows expected failure results for fast/lists/003-vertical.html

The Windows results match the pre-r80648 Mac results. The failure is tracked by
<http://webkit.org/b/56101>.

  • platform/win/fast/lists/003-vertical-expected.checksum: Added.
  • platform/win/fast/lists/003-vertical-expected.png: Added.
  • platform/win/fast/lists/003-vertical-expected.txt: Added.
8:46 AM Changeset in webkit [80728] by podivilov@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-03-10 Andrey Adaikin <aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: [Text editor] Substitute live-edit mode activation by double-click
https://bugs.webkit.org/show_bug.cgi?id=56084

Also fixed a regression: console was not opening/closing on ESC key press because tabIndex="0" attribute was preserved for a readOnly viewer.

8:43 AM Changeset in webkit [80727] by andreip@google.com
  • 2 edits in trunk/LayoutTests

2011-03-10 Andrei Popescu <andreip@google.com>

Unreviewed, build fix.

[Chromium] fast/text/international/vertical-text-glyph-test.html fails on OSX 10.6
https://bugs.webkit.org/show_bug.cgi?id=56108

Update Chromium test expectations.

  • platform/chromium/test_expectations.txt:
8:42 AM Changeset in webkit [80726] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip another spinbutton test on Windows

The missing functionality is tracked by <http://webkit.org/b/38381>.

  • platform/win/Skipped: Added fast/forms/input-appearance-spinbutton-visibility.html
8:40 AM Changeset in webkit [80725] by Adam Roben
  • 1 edit
    1 add in trunk/LayoutTests

Add Windows expected failure results for fast/text/hyphenate-limit-before-after.html

The failure is tracked by <http://webkit.org/b/56102>.

  • platform/win/fast/text/hyphenate-limit-before-after-expected.txt: Added. Copied this from

mac-snowleopard.

8:38 AM Changeset in webkit [80724] by Adam Roben
  • 1 edit
    3 adds in trunk/LayoutTests

Add Windows expected failure results for fast/blockflow/text-orientation-basic.html

The failure is tracked by <http://webkit.org/b/56101>.

  • platform/win/fast/blockflow/text-orientation-basic-expected.checksum: Added.
  • platform/win/fast/blockflow/text-orientation-basic-expected.png: Added.
  • platform/win/fast/blockflow/text-orientation-basic-expected.txt: Added.
8:36 AM Changeset in webkit [80723] by pfeldman@chromium.org
  • 13 edits
    1 add in trunk/Source/WebCore

2011-03-10 Greg Simon <gregsimon@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Need new graphic icon for garbage collect button.
https://bugs.webkit.org/show_bug.cgi?id=55794

No new tests: gc tests are flaky due to non-determinisic
behavior of collection APIs (more notes in bug)

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • bindings/js/ScriptProfiler.cpp: (WebCore::ScriptProfiler::collectGarbage):
  • bindings/js/ScriptProfiler.h:
  • bindings/v8/ScriptProfiler.cpp: (WebCore::ScriptProfiler::collectGarbage):
  • bindings/v8/ScriptProfiler.h:
  • inspector/Inspector.idl:
  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::collectGarbage):
  • inspector/InspectorProfilerAgent.h:
  • inspector/front-end/Images/garbageCollectButtonGlyph.png: Added.
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype.get statusBarItems): (WebInspector.TimelinePanel.prototype._createStatusbarButtons): (WebInspector.TimelinePanel.prototype._garbageCollectButtonClicked):
  • inspector/front-end/inspector.css: (.garbage-collect-status-bar-item .glyph):
8:32 AM Changeset in webkit [80722] by andreip@google.com
  • 2 edits in trunk/LayoutTests

2011-03-10 Andrei Popescu <andreip@google.com>

Unreviewed, build fix.

[Chromium] fast/text/justify-ideograph-vertical.html fails on OSX 10.5
https://bugs.webkit.org/show_bug.cgi?id=56106

Update Chromium test expectations.

  • platform/chromium/test_expectations.txt:
8:14 AM Changeset in webkit [80721] by caseq@chromium.org
  • 6 edits in trunk/Source

2011-03-10 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: better names for HAR export commands
https://bugs.webkit.org/show_bug.cgi?id=56097

Rename Export to HAR to Copy entry/network log as HAR
Expose Copy as HAR unconditionally, remove related settings entry.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._contextMenu):
  • inspector/front-end/Settings.js:

2011-03-10 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: better names for HAR export commands
https://bugs.webkit.org/show_bug.cgi?id=56097

  • src/js/DevTools.js: removed override for resourceExportEnabled
7:57 AM Changeset in webkit [80720] by Laszlo Gombos
  • 2 edits in trunk/Source/WebCore

2011-03-10 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String
https://bugs.webkit.org/show_bug.cgi?id=48636

Fix a typo in features.pri that turns on this feature on mobile
devices by default.

  • features.pri:
7:38 AM Changeset in webkit [80719] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-10 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Invalid expected parameter list in CSSAgent.setSelectorText() callback (CSSStyleModel.js)
https://bugs.webkit.org/show_bug.cgi?id=56092

  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype.setRuleSelector):
7:17 AM Changeset in webkit [80718] by pfeldman@chromium.org
  • 7 edits
    1 delete in trunk

2011-03-10 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: rolling out r80478 and its follow ups for breaking
inspector and engadget.com.
https://bugs.webkit.org/show_bug.cgi?id=49401

  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::performTask): (WebCore::Document::postTask):
  • dom/Document.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::setDefersLoading):
  • manual-tests/database-callback-deferred.html: Removed.
  • page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):

2011-03-10 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: rolling out r80478 and its follow ups for breaking
inspector and engadget.com.
https://bugs.webkit.org/show_bug.cgi?id=49401

  • platform/gtk/Skipped:
7:11 AM Changeset in webkit [80717] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-10 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip 1 more svg test failing by one pixel in 32-bits
Debug, see bug 39022.

  • platform/gtk/Skipped:
6:52 AM Changeset in webkit [80716] by kov@webkit.org
  • 21 edits in trunk/Source

2011-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Kenneth Rohde Christiansen.

Tiled backing store's delegated scroll request uses incorrect convention
https://bugs.webkit.org/show_bug.cgi?id=56011

Use a point instead of delta, when relaying the scroll request from
ScrollView::setScrollPosition.

  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::delegatedScrollRequested):
  • page/Chrome.cpp: (WebCore::Chrome::delegatedScrollRequested):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/HostWindow.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::setScrollPosition):

2011-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Kenneth Rohde Christiansen.

Tiled backing store's delegated scroll request uses incorrect convention
https://bugs.webkit.org/show_bug.cgi?id=56011

Adapt internal API to match the change from delta to point on the
WebCore side, and convert the point to a delta for the public API.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::delegatedScrollRequested):
  • WebCoreSupport/ChromeClientQt.h:

2011-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Kenneth Rohde Christiansen.

Tiled backing store's delegated scroll request uses incorrect convention
https://bugs.webkit.org/show_bug.cgi?id=56011

Adapt all of the internal API to match the delta to point
conversion at the WebCore side.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::pageDidRequestScroll):
  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::pageDidRequestScroll):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::delegatedScrollRequested):
  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::pageDidRequestScroll):
  • WebProcess/WebPage/WebPage.h:
6:51 AM Changeset in webkit [80715] by Philippe Normand
  • 5 edits in trunk/Source/WebKit/gtk

2011-03-10 Philippe Normand <pnormand@igalia.com>

Reviewed by Xan Lopez.

[GTK] unittests/testapplicationcache crashes
https://bugs.webkit.org/show_bug.cgi?id=56083

Removed the webkit_application_cache_get_database_directory_path
API as the underlying ApplicationCacheStorage doesn't allow
setting the cache path multiple times.

  • tests/testapplicationcache.c: (main):
  • webkit/webkitapplicationcache.cpp: (webkit_application_cache_get_database_directory_path):
  • webkit/webkitapplicationcache.h:
  • webkit/webkitglobals.cpp: (webkitInit):
6:34 AM Changeset in webkit [80714] by kbalazs@webkit.org
  • 6 edits
    2 adds
    2 deletes in trunk/Source/WebKit2

2011-03-10 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Andreas Kling.

[WK2] Make non-transparent windowless plugins paint on X11
https://bugs.webkit.org/show_bug.cgi?id=55660

Implement painting for non-transparent windowless X11 plugins.
The essence of the logic has been adapted from WebCore.
The implementation is stubbed for GTK and working only on Qt
but it should be really easy to finish it for GTK.

  • WebKit2.pro:
  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_GetValue): Handle X11 specific values that are necessary.
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::NetscapePlugin): Initialize the X11 specific members that has been added. (WebKit::NetscapePlugin::callSetWindow): Always set the x and y coordinates of the NP_Window to 0 on X11 since we are using a backings store as the painting area for the plugin.
  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/gtk/NetscapePluginGtk.cpp: Removed in favour of a common implementation for X11.
  • WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp: Ditto.
  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: Added. (WebKit::getPluginDisplay):

Platform specific static getters.
(WebKit::x11Display):
(WebKit::displayDepth):
(WebKit::rootWindowID):
(WebKit::x11Screen):

(WebKit::NetscapePlugin::platformPostInitialize): Set up the visual
settings and the colormap for the plugin.
(WebKit::NetscapePlugin::platformDestroy):
(WebKit::NetscapePlugin::platformInvalidate): Remained stub.
(WebKit::NetscapePlugin::platformGeometryDidChange): Create a new
pixmap that fits the geometry.
(WebKit::NetscapePlugin::platformPaint): Propagate a paint event
to the plugin, sync with it if necessary and draw the pixmap to
the screen.
(WebKit::toNP): Remained stub.
(WebKit::NetscapePlugin::platformHandleMouseEvent): Remained stub.
(WebKit::NetscapePlugin::platformHandleWheelEvent): Remained stub.
(WebKit::NetscapePlugin::platformSetFocus): Remained stub.
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent): Remained stub.
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent): Remained stub.
(WebKit::NetscapePlugin::platformHandleKeyboardEvent): Remained stub.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::createPlugin): Hack. Inject wmode=opaque key-value pair to the plugin parameters to force Flash to act in non-transparent windowless mode. Qt also doing this in WebCore.
6:26 AM Changeset in webkit [80713] by pfeldman@chromium.org
  • 17 edits in trunk

2011-03-10 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: brush up DOM agent API.
https://bugs.webkit.org/show_bug.cgi?id=56093

  • http/tests/inspector/elements-test.js: (initialize_ElementTest.InspectorTest.nodeWithId.processChildren): (initialize_ElementTest.InspectorTest.nodeWithId.documentRequested): (initialize_ElementTest.InspectorTest.nodeWithId): (initialize_ElementTest.InspectorTest.dumpDOMAgentTree.dump): (initialize_ElementTest.InspectorTest.dumpDOMAgentTree): (initialize_ElementTest):
  • inspector/elements/elements-panel-rewrite-href.html:
  • inspector/elements/elements-panel-search.html:
  • inspector/elements/elements-panel-selection-on-refresh.html:
  • inspector/elements/mutate-unknown-node.html:

2011-03-10 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: brush up DOM agent API.
https://bugs.webkit.org/show_bug.cgi?id=56093

  • inspector/Inspector.idl:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::childNodes): (WebCore::InspectorDOMAgent::setNodeName): (WebCore::InspectorDOMAgent::outerHTML): (WebCore::InspectorDOMAgent::setNodeValue):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode): (WebInspector.DOMNode.prototype.hasAttributes): (WebInspector.DOMNode.prototype.nodeType): (WebInspector.DOMNode.prototype.nodeName): (WebInspector.DOMNode.prototype.setNodeName): (WebInspector.DOMNode.prototype.localName): (WebInspector.DOMNode.prototype.nodeValue): (WebInspector.DOMNode.prototype.setNodeValue): (WebInspector.DOMNode.prototype.setAttribute): (WebInspector.DOMNode.prototype.attributes): (WebInspector.DOMNode.prototype.removeAttribute): (WebInspector.DOMNode.prototype.childNodes.mycallback): (WebInspector.DOMNode.prototype.childNodes): (WebInspector.DOMNode.prototype.outerHTML): (WebInspector.DOMNode.prototype.setOuterHTML): (WebInspector.DOMNode.prototype.removeNode): (WebInspector.DOMNode.prototype.copyNode): (WebInspector.DOMNode.prototype.path): (WebInspector.DOMNode.prototype._setAttributesPayload): (WebInspector.DOMNode.prototype._addAttribute): (WebInspector.DOMAgent.prototype._characterDataModified):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.updateBreadcrumb): (WebInspector.ElementsPanel.prototype.decorateNodeLabel): (WebInspector.ElementsPanel.prototype.handleCopyEvent):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.findTreeElement): (WebInspector.ElementsTreeElement): (WebInspector.ElementsTreeElement.prototype.updateChildren): (WebInspector.ElementsTreeElement.prototype._updateChildren): (WebInspector.ElementsTreeElement.prototype._startEditingTarget): (WebInspector.ElementsTreeElement.prototype._startEditing): (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted): (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.moveToNextAttributeIfNeeded): (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted): (WebInspector.ElementsTreeElement.prototype._textNodeEditingCommitted): (WebInspector.ElementsTreeElement.prototype._attributeHTML): ():
  • inspector/front-end/EventListenersSidebarPane.js: ():
  • inspector/front-end/MetricsSidebarPane.js:
  • inspector/front-end/StylesSidebarPane.js:
  • inspector/front-end/utilities.js:
6:09 AM Changeset in webkit [80712] by Philippe Normand
  • 2 edits in trunk/Tools

2011-03-10 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] run-gtk-tests doesn't fail if a test crashes
https://bugs.webkit.org/show_bug.cgi?id=56089

  • Scripts/run-gtk-tests: gtester -k exits with a 0 exit status even if a test crashes. So run the tests individually and if a test fails remember its exit code so run-gtk-test fails too, if required.
5:44 AM Changeset in webkit [80711] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-10 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip 2 more flacky tests on GTK 32-bits Release.

  • platform/gtk/Skipped:
5:28 AM Changeset in webkit [80710] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-09 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [STYLES] Editing a property value adds a word for any property value that uses a paren
https://bugs.webkit.org/show_bug.cgi?id=56002

  • inspector/front-end/StylesSidebarPane.js: Introduce an additional check.
5:05 AM Changeset in webkit [80709] by podivilov@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-03-09 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: use DebuggerPresentation instead of DebuggerModel in source frame delegate.
https://bugs.webkit.org/show_bug.cgi?id=56034

  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.continueToLine): (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint): (WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint): (WebInspector.DebuggerPresentationModel.prototype.findBreakpoint): (WebInspector.DebuggerPresentationModel.prototype._sourceLocationToActualLocation):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._createSourceFrame): (WebInspector.SourceFrameDelegateForScriptsPanel): (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setBreakpoint): (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.updateBreakpoint): (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.removeBreakpoint): (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.findBreakpoint): (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.continueToLine):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition.didEditBreakpointCondition): (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition): (WebInspector.SourceFrame.prototype._contextMenu.else.setBreakpointEnabled): (WebInspector.SourceFrame.prototype._contextMenu): (WebInspector.SourceFrame.prototype._mouseDown): (WebInspector.SourceFrameDelegate.prototype.removeBreakpoint): (WebInspector.SourceFrameDelegate.prototype.updateBreakpoint):
4:42 AM Changeset in webkit [80708] by apavlov@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-03-09 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: elements dom tree - word wrap toggle
https://bugs.webkit.org/show_bug.cgi?id=44311

A "Word Wrap" option is now shown in a context menu for the entire DOM tree content area
and persisted into application settings.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype._contextMenuEventFired): (WebInspector.ElementsPanel.prototype._contextMenuEventFired.toggleWordWrap):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline): (WebInspector.ElementsTreeOutline.prototype._treeElementFromEvent): (WebInspector.ElementsTreeOutline.prototype.populateContextMenu): (WebInspector.ElementsTreeElement.prototype.onreveal):
  • inspector/front-end/Settings.js: (WebInspector.Settings):
  • inspector/front-end/inspector.css: (#elements-content.nowrap): (#elements-content > ol):
4:28 AM Changeset in webkit [80707] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-10 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip 1 more svg test failing by one pixel in 32-bits
Debug, see bug 39022.

  • platform/gtk/Skipped:
4:26 AM Changeset in webkit [80706] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-10 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip 2 more svg tests failing by one pixel in 32-bits
Release, see bug 39022.

  • platform/gtk/Skipped:
4:21 AM Changeset in webkit [80705] by podivilov@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-03-09 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: re-implement breakpoints sidebar pane based on debugger presentation model.
https://bugs.webkit.org/show_bug.cgi?id=55823

  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.JavaScriptBreakpointsSidebarPane): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.addBreakpoint.didLoadSnippet): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.addBreakpoint): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.removeBreakpoint): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.highlightBreakpoint): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.clearBreakpointHighlight): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._createBreakpointItemId): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointClicked): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointCheckboxClicked): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._contextMenu): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.reset):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel): (WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource): (WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource): (WebInspector.DebuggerPresentationModel.prototype._revealHiddenBreakpoints): (WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId): (WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled): (WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded): (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame): (WebInspector.DebuggerPresentationModel.prototype._actualLocationToSourceLocation): (WebInspector.DebuggerPresentationModel.prototype.reset):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._breakpointAdded): (WebInspector.ScriptsPanel.prototype._breakpointRemoved): (WebInspector.ScriptsPanel.prototype._debuggerPaused): (WebInspector.ScriptsPanel.prototype.reset): (WebInspector.ScriptsPanel.prototype._clearInterface):
4:11 AM Changeset in webkit [80704] by podivilov@chromium.org
  • 9 edits in trunk

2011-03-10 Andrey Adaikin <aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: Highlighter refactoring
https://bugs.webkit.org/show_bug.cgi?id=56015

  • inspector/editor/highlighter-basics-expected.txt:
  • inspector/editor/highlighter-basics.html:
  • inspector/editor/highlighter-long-line.html:
  • inspector/editor/highlighter-paste-in-comment-expected.txt:
  • inspector/editor/highlighter-paste-in-comment.html:

2011-03-10 Andrey Adaikin <aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: Highlighter refactoring
https://bugs.webkit.org/show_bug.cgi?id=56015

  • inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter): (WebInspector.TextEditorHighlighter.prototype.set mimeType): (WebInspector.TextEditorHighlighter.prototype.highlight): (WebInspector.TextEditorHighlighter.prototype.updateHighlight): (WebInspector.TextEditorHighlighter.prototype._highlightInChunks): (WebInspector.TextEditorHighlighter.prototype._highlightLines): (WebInspector.TextEditorHighlighter.prototype._selectHighlightState): (WebInspector.TextEditorHighlighter.prototype._clearHighlightState):
  • inspector/front-end/TextViewer.js: (WebInspector.TextEditorMainPanel.prototype._buildChunks): (WebInspector.TextEditorMainPanel.prototype._updateHighlightsForRange):
3:28 AM Changeset in webkit [80703] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-10 John Knottenbelt <jknotten@chromium.org>

Reviewed by Andreas Kling.

[Qt] Skip fast/dom/Geolocation/page-reload-cancel-permission-requests.html pending implementation of LayoutTestController::numberOfPendingGeolocationPermissionRequests
https://bugs.webkit.org/show_bug.cgi?id=56087

  • platform/qt/Skipped:
3:24 AM Changeset in webkit [80702] by podivilov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-05 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move breakpoint column adjustment to debugger model.
https://bugs.webkit.org/show_bug.cgi?id=55821

Test: inspector/debugger/debug-inlined-scripts.html

  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.setBreakpoint.didSetBreakpoint): (WebInspector.DebuggerModel.prototype.setBreakpoint):
  • inspector/front-end/SourceFrameContent.js: (WebInspector.SourceFrameContent.prototype.sourceFrameLineNumberToActualLocation):
2:15 AM Changeset in webkit [80701] by jknotten@chromium.org
  • 31 edits
    4 adds in trunk

2011-02-16 John Knottenbelt <jknotten@chromium.org>

Reviewed by Dmitry Titov.

Detach Geolocation from Frame when Page destroyed.
https://bugs.webkit.org/show_bug.cgi?id=52877

Ensure that all geolocation permission requests are cancelled
when the page is detached from its frame.

  • fast/dom/Geolocation/page-reload-cancel-permission-requests-expected.txt: Added.
  • fast/dom/Geolocation/page-reload-cancel-permission-requests.html: Added.
  • fast/dom/Geolocation/resources/page-reload-cancel-permission-requests-inner.html: Added.
  • fast/dom/Geolocation/script-tests/page-reload-cancel-permission-requests.js: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt-wk2/Skipped:

2011-01-21 John Knottenbelt <jknotten@chromium.org>

Reviewed by Dmitry Titov.

Detach Geolocation from Frame when Page destroyed.
https://bugs.webkit.org/show_bug.cgi?id=52877

On Page destruction, any outstanding Geolocation permission
requests should be cancelled, because the Geolocation can only
access the client indirectly via m_frame->page().

Page destruction is signalled by a call to the
Frame::pageDestroyed() method. This explictly calls
DOMWindow::resetGeolocation which ultimately calls Geolocation::reset.

Geolocation::reset() detaches from the GeolocationController,
cancels requests, watches and single shots, and sets the
permission state back to Unknown.

Frame::pageDestroyed() is also called by FrameLoader even though
the page is not destroyed. We should still cancel permission
requests, because the GeolocationClient will become inaccessible
to the Geolocation object after this call.

Frame::transferChildFrameToNewDocument also indirectly calls
Geolocation::reset when the frame is reparented between
pages. Ideally we would like the Geolocation's activities to
continue after reparenting, see bug
https://bugs.webkit.org/show_bug.cgi?id=55577

Since GeolocationController is owned by Page, and all Geolocation
objects will now unsubscribe from the GeolocationController on
pageDetached(), we no longer need to call stopUpdating() from the
GeolocationController's destructor. Instead we can simply assert
that there should be no no observers. See related bug
https://bugs.webkit.org/show_bug.cgi?id=52216 .

Introduced new method 'numberOfPendingPermissionRequests' on
GeolocationClientMock to count the number of outstanding pending
permission requests. This provides a reusable implementation for
client-based implementations of the LayoutTestController's
numberOfPendingGeolocationPermissionRequests method.

Test: fast/dom/Geolocation/page-reload-cancel-permission-requests.html

  • page/DOMWindow.cpp: (WebCore::DOMWindow::resetGeolocation):
  • page/DOMWindow.h:
  • page/Frame.cpp: (WebCore::Frame::pageDestroyed): (WebCore::Frame::transferChildFrameToNewDocument):
  • page/Geolocation.cpp: (WebCore::Geolocation::~Geolocation): (WebCore::Geolocation::page): (WebCore::Geolocation::reset): (WebCore::Geolocation::disconnectFrame): (WebCore::Geolocation::lastPosition): (WebCore::Geolocation::requestPermission): (WebCore::Geolocation::startUpdating): (WebCore::Geolocation::stopUpdating):
  • page/Geolocation.h:
  • page/GeolocationController.cpp: (WebCore::GeolocationController::~GeolocationController):
  • page/Navigator.cpp: (WebCore::Navigator::resetGeolocation):
  • page/Navigator.h:
  • platform/mock/GeolocationClientMock.cpp: (WebCore::GeolocationClientMock::numberOfPendingPermissionRequests):
  • platform/mock/GeolocationClientMock.h:

2011-01-26 John Knottenbelt <jknotten@chromium.org>

Reviewed by Dmitry Titov.

Detach Geolocation from Frame when Page destroyed.
https://bugs.webkit.org/show_bug.cgi?id=52877

Add accessors to the WebGeolocationClientMock to allow the number of
pending geolocation permission requests to be queried.

  • public/WebGeolocationClientMock.h:
  • src/WebGeolocationClientMock.cpp: (WebKit::WebGeolocationClientMock::numberOfPendingPermissionRequests):

2011-01-26 John Knottenbelt <jknotten@chromium.org>

Reviewed by Dmitry Titov.

Detach Geolocation from Frame when Page destroyed.
https://bugs.webkit.org/show_bug.cgi?id=52877

Extend the layout test controller to expose the number of pending
geolocation requests, so that we can test that the requests have
been cancelled on page close.

  • DumpRenderTree/LayoutTestController.cpp: (numberOfPendingGeolocationPermissionRequestsCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  • DumpRenderTree/mac/UIDelegate.h:
  • DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1:57 AM Changeset in webkit [80700] by Csaba Osztrogonác
  • 1 edit
    12 adds in trunk/LayoutTests

Unreviewed.

Add Qt specific expected files for tests introduced in r80622 and r80682.

  • platform/qt/fast/dom/scroll-reveal-left-overflow-expected.checksum: Added.
  • platform/qt/fast/dom/scroll-reveal-left-overflow-expected.png: Added.
  • platform/qt/fast/dom/scroll-reveal-left-overflow-expected.txt: Added.
  • platform/qt/fast/dom/scroll-reveal-top-overflow-expected.checksum: Added.
  • platform/qt/fast/dom/scroll-reveal-top-overflow-expected.png: Added.
  • platform/qt/fast/dom/scroll-reveal-top-overflow-expected.txt: Added.
  • platform/qt/fast/dynamic/dirty-float-in-clean-line-expected.checksum: Added.
  • platform/qt/fast/dynamic/dirty-float-in-clean-line-expected.png: Added.
  • platform/qt/fast/dynamic/dirty-float-in-clean-line-expected.txt: Added.
  • platform/qt/fast/dynamic/float-at-line-break-expected.checksum: Added.
  • platform/qt/fast/dynamic/float-at-line-break-expected.png: Added.
  • platform/qt/fast/dynamic/float-at-line-break-expected.txt: Added.
1:33 AM Changeset in webkit [80699] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-10 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip fast/js/large-expressions.html on GTK.

  • platform/gtk/Skipped:
1:23 AM Changeset in webkit [80698] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-10 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip jquery/effects.html on GTK.

  • platform/gtk/Skipped:
1:11 AM Changeset in webkit [80697] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-10 Adam Barth <abarth@webkit.org>

Partial revert of http://trac.webkit.org/changeset/80670. This test
has been failing sporatically since it was changed in that revision.

  • platform/mac/accessibility/aria-expanded-notifications.html:
12:33 AM Changeset in webkit [80696] by ojan@chromium.org
  • 10 edits
    2 adds in trunk

2011-03-10 Ojan Vafai <ojan@chromium.org>

Reviewed by Darin Adler.

Able to move nodes across documents
https://bugs.webkit.org/show_bug.cgi?id=19524

Makes cross-document appendChild, insertBefore, Range.insertNode and Range.surroundContents work.
This matches Gecko and the new Dom Core spec. There are a number of Range methods where we don't
match Gecko or the spec that will need to be updated in a following patch.

  • dom/html/level1/core/hc_elementwrongdocumenterr-expected.txt:
  • dom/html/level1/core/hc_namednodemapwrongdocumenterr-expected.txt:
  • dom/xhtml/level1/core/hc_elementwrongdocumenterr-expected.txt:
  • dom/xhtml/level1/core/hc_namednodemapwrongdocumenterr-expected.txt:
  • fast/dom/move-nodes-across-documents-expected.txt: Added.
  • fast/dom/move-nodes-across-documents.html: Added.

2011-03-10 Ojan Vafai <ojan@chromium.org>

Reviewed by Darin Adler.

Able to move nodes across documents
https://bugs.webkit.org/show_bug.cgi?id=19524

Makes cross-document appendChild, insertBefore, Range.insertNode and Range.surroundContents work.
This matches Gecko and the new Dom Core spec. There are a number of Range methods where we don't
match Gecko or the spec that will need to be updated in a following patch.

Test: fast/dom/move-nodes-across-documents.html

  • dom/Element.cpp: (WebCore::Element::removeAttributeNode):
  • dom/NamedNodeMap.cpp: (WebCore::NamedNodeMap::setNamedItem):
  • dom/Node.cpp: (WebCore::Node::setDocumentRecursively): (WebCore::checkAcceptChild): (WebCore::Node::checkReplaceChild):
  • dom/Range.cpp: (WebCore::Range::insertNode): (WebCore::Range::surroundContents):
12:19 AM Companies and Organizations that have contributed to WebKit edited by gyuyoung.kim@samsung.com
(diff)

Mar 9, 2011:

11:31 PM Changeset in webkit [80695] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

Not reviewed.

Reverting crash catching code, the bug being hunted was fixed by
http://trac.webkit.org/changeset/80686

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::~CachedResourceLoader):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::setAutoLoadImages):
(WebCore::CachedResourceLoader::load):
(WebCore::CachedResourceLoader::loadDone):
(WebCore::CachedResourceLoader::preload):
(WebCore::CachedResourceLoader::requestPreload):

  • loader/cache/CachedResourceLoader.h:
10:54 PM Changeset in webkit [80694] by pkasting@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, build fix.

  • StringsNotToBeLocalized.txt: Add function names I forgot.
  • platform/win/SystemInfo.cpp: #if out some uncalled functions on WinCE, since they don't compile anyway. Use ZeroMemory() instead of "= {0}" since Qt is stupid and (sometimes?!) warns about it.

(WebCore::windowsVersion):
(WebCore::processorArchitecture):

10:31 PM Changeset in webkit [80693] by pkasting@chromium.org
  • 3 edits in trunk/Source/WebCore

Add UA string tags for Windows 64.
https://bugs.webkit.org/show_bug.cgi?id=55226

Reviewed by Ryosuke Niwa.

  • StringsNotToBeLocalized.txt:
  • platform/win/SystemInfo.cpp:

(WebCore::osVersionForUAString):
(WebCore::isWOW64):
(WebCore::processorArchitecture):
(WebCore::architectureTokenForUAString):
(WebCore::windowsVersionForUAString):

10:15 PM Changeset in webkit [80692] by rolandsteiner@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-09 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed: tweaking of Chromium test_expectations.txt

  • platform/chromium/test_expectations.txt:
9:38 PM Changeset in webkit [80691] by dbates@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-09 Daniel Bates <dbates@rim.com>

Attempt to fix the WinCE build after changeset 80684 <http://trac.webkit.org/changeset/80684>
(Bug #56041<https://bugs.webkit.org/show_bug.cgi?id=56041>).

  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): Substitute variable callFrame for exec in call to createSyntaxError().
8:50 PM Changeset in webkit [80690] by pkasting@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, attempted build fix.

  • WebCore.pri: Try to update include path for Qt Windows build.
8:24 PM Changeset in webkit [80689] by pkasting@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, build fix.

  • platform/win/SystemInfo.cpp:

(WebCore::windowsVersionForUAString): Fix const conversion warning on Qt.

8:19 PM Changeset in webkit [80688] by pkasting@chromium.org
  • 20 edits in trunk/Source

Unify Windows version checks.
https://bugs.webkit.org/show_bug.cgi?id=55979

Reviewed by Mihai Parparita.

Source/WebCore:

  • GNUmakefile.am: Fix spaces -> tabs.
  • StringsNotToBeLocalized.txt:
  • WebCore.pro: Add SystemInfo.* to Qt build.
  • platform/chromium/ScrollbarThemeChromiumWin.cpp:

(WebCore::ScrollbarThemeChromiumWin::invalidateOnMouseEnterExit):
(WebCore::ScrollbarThemeChromiumWin::getThemeState):
(WebCore::ScrollbarThemeChromiumWin::getThemeArrowState):

  • platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:

(WebCore::fillBMPGlyphs):

  • platform/win/CursorWin.cpp:

(WebCore::createSharedCursor):

  • platform/win/ScrollbarThemeWin.cpp:

(WebCore::ScrollbarThemeWin::ScrollbarThemeWin):

  • platform/win/SystemInfo.cpp: Add full-fledged version check and UA string helper function.

(WebCore::windowsVersion):
(WebCore::windowsVersionForUAString):

  • platform/win/SystemInfo.h: Add full-fledged version check and UA string helper function.
  • rendering/RenderThemeChromiumWin.cpp:

(WebCore::getNonClientMetrics):

  • rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::getThemeData):
(WebCore::RenderThemeWin::paintMenuList):
(WebCore::RenderThemeWin::paintMenuListButton):

Source/WebKit/gtk:

  • webkit/webkitwebsettings.cpp:

(webkitOSVersion):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPage::userAgentForUrl):

Source/WebKit/win:

  • WebView.cpp:

(WebView::standardUserAgentWithApplicationName):
(webKitVersionString):

Source/WebKit2:

  • UIProcess/win/WebPageProxyWin.cpp:

(WebKit::WebPageProxy::standardUserAgent):

7:59 PM Writing Reftests edited by hayato@chromium.org
(diff)
7:30 PM Changeset in webkit [80687] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-09 Mihai Parparita <mihaip@chromium.org>

JSC now implements Object.freeze/seal (as of r80378) and correct
expectations have been checked in, therefore we now pass more
ietestcenter tests.

  • platform/chromium/test_expectations.txt:
6:55 PM Changeset in webkit [80686] by mihaip@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-09 Mihai Parparita <mihaip@chromium.org>

Reviewed by Tony Gentilcore.

REGRESSION (r74807): memory corruption after CachedResourceLoader refactoring
https://bugs.webkit.org/show_bug.cgi?id=53045

Copy the URL out of the CachedResource that is being revalidated, so
that we can still use it (in m_validatedURLs) after removing the
resource from the memory cache, which may delete it.

No new tests, since I was not able to trigger this locally (in a layout
test or otherwise).

  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::revalidateResource):
6:23 PM Changeset in webkit [80685] by Chris Fleizach
  • 3 edits
    2 adds in trunk

VO reporting incorrect list count for http://www.macworld.com/news.html
https://bugs.webkit.org/show_bug.cgi?id=56064

Reviewed by Beth Dakin.

Source/WebCore:

<li> tags should not be ignored, because they provide valuable information
to screen readers.

Test: platform/mac/accessibility/list-items-ignored.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):

LayoutTests:

  • platform/mac/accessibility/list-items-ignored-expected.txt: Added.
  • platform/mac/accessibility/list-items-ignored.html: Added.
6:22 PM Changeset in webkit [80684] by barraclough@apple.com
  • 13 edits in trunk

Bug 56041 - RexExp constructor should only accept flags "gim"
Fix for issues introduced in r80667.

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Invalid flags to a RegExp literal are a late syntax error!

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::addRegExp):

  • Pass a PassRefPtr<RegExp>
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::addRegExp):
(JSC::BytecodeGenerator::emitNewRegExp):

  • bytecompiler/BytecodeGenerator.h:
    • Pass a PassRefPtr<RegExp>
  • bytecompiler/NodesCodegen.cpp:

(JSC::RegExpNode::emitBytecode):

  • Should not be ASSERTing that the flags are valid - this is a late(er) error.
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • Need to check for error from RegExp constructor.
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • Need to check for error from RegExp constructor.
  • runtime/RegExp.h:

(JSC::RegExp::isValid):

  • Make isValid check that the regexp was created with valid flags.
  • runtime/RegExpKey.h:
    • Since we'll not create RegExp objects with invalid flags, separate out the deleted value.

LayoutTests:

  • fast/regex/script-tests/parentheses.js:
  • fast/regex/script-tests/pcre-test-1.js:
    • Providing invalid flags to RegExp literals is an error in ES5.
6:21 PM Changeset in webkit [80683] by adele@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix for https://bugs.webkit.org/show_bug.cgi?id=56068
<rdar://problem/9058245> WebKit2: Can't uncheck 'Spelling and Grammar' contextual items

Reviewed by Anders Carlsson.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::contextMenuItemSelected):

Add cases for ContextMenuItemTagCorrectSpellingAutomatically, ContextMenuItemTagCheckSpellingWhileTyping,
and ContextMenuItemTagCheckGrammarWithSpelling

5:56 PM Changeset in webkit [80682] by mitz@apple.com
  • 4 edits
    12 adds in trunk

Source/WebCore: <rdar://problem/8733254> Float disappears after incremental layout
Fixed the original bug and a copule more issues noticed while doing so.

Reviewed by Dave Hyatt.

Tests: fast/dynamic/dirty-float-in-clean-line.html

fast/dynamic/float-at-line-break.html
fast/dynamic/float-from-empty-line.html

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren): If findNextLineBreak() returned an empty line,
update the line break info of the last line with the new line break position. This is tested
by float-from-empty-line.html.
(WebCore::RenderBlock::checkFloatsInCleanLine): Factored out code from determineStartPosition()
into this new function.
(WebCore::RenderBlock::determineStartPosition): Call checkFloatsInCleanLine().
(WebCore::RenderBlock::determineEndPosition): When iterating over lines, check clean lines with
floats, as they may yet become dirty because of the floats. This is tested by
dirty-float-in-clean-line.html.
(WebCore::RenderBlock::findNextLineBreak): If a float fits on the line, and the current line
break is at the float, advance it to after the float. Otherwise, if the line gets dirty and the
next one does not, the float will not make it into any line. This is tested by
float-at-line-break.html.

LayoutTests: <rdar://problem/8733254> Float disappears after incremental layout

Reviewed by Dave Hyatt.

  • fast/dynamic/dirty-float-in-clean-line-expected.checksum: Added.
  • fast/dynamic/dirty-float-in-clean-line-expected.png: Added.
  • fast/dynamic/dirty-float-in-clean-line-expected.txt: Added.
  • fast/dynamic/dirty-float-in-clean-line.html: Added.
  • fast/dynamic/float-at-line-break-expected.checksum: Added.
  • fast/dynamic/float-at-line-break-expected.png: Added.
  • fast/dynamic/float-at-line-break-expected.txt: Added.
  • fast/dynamic/float-at-line-break.html: Added.
  • fast/dynamic/float-from-empty-line-expected.checksum: Added.
  • fast/dynamic/float-from-empty-line-expected.png: Added.
  • fast/dynamic/float-from-empty-line-expected.txt: Added.
  • fast/dynamic/float-from-empty-line.html: Added.
5:50 PM Changeset in webkit [80681] by tonyg@chromium.org
  • 1 edit
    2 deletes in branches/chromium/696/LayoutTests

Revert 80406 - 2011-03-04 James Simonsen <simonjam@chromium.org>

Reviewed by Adam Barth.

Test that scripts with unknown types aren't loaded.
https://bugs.webkit.org/show_bug.cgi?id=51760

  • fast/dom/HTMLScriptElement/dont-load-unknown-type-expected.txt: Added.
  • fast/dom/HTMLScriptElement/dont-load-unknown-type.html: Added.

TBR=simonjam@chromium.org

5:49 PM Changeset in webkit [80680] by tonyg@chromium.org
  • 13 edits in branches/chromium/696

Revert 79114 - 2011-02-19 James Simonsen <simonjam@chromium.org>

Reviewed by Adam Barth.

Make ScriptElement match the HTML5 spec
https://bugs.webkit.org/show_bug.cgi?id=54676

This implements the "prepare a script" section of the HTML5 spec in ScriptElement::prepareScript().
http://www.whatwg.org/specs/web-apps/current-work/multipage/scripting-1.html#prepare-a-script

There are a couple of things missing from the spec that would be new functionality. These will be added later.

  • Support for async=false
  • Empty src attribute should dispatch an error.

There are a couple of slight behavioral changes to match the spec.

  • An XHTML script that is loaded then copied will not fire load on the copy.
  • If onbeforeload moves the script to a different document, then it will not try to execute again because wasAlreadyStarted is true.

The parsers were updated to use the new API, but not rewritten to look like the spec. That will be done separately.

  • fast/dom/HTMLScriptElement/move-in-beforeload.html: Original author says test was only meant to check for crashes. Beforeload is not specified by HTML5. Test was modified to assume moved script wouldn't execute because wasAlreadyStarted is set.
  • fast/dom/script-clone-rerun-src.xhtml: According to HTML5 spec, load should only fire after a script executes. Test was modified to match that. The old broken behavior was that load fired on the cloned element, even though it didn't execute.

2011-02-19 James Simonsen <simonjam@chromium.org>

Reviewed by Adam Barth.

Make ScriptElement match the HTML5 spec
https://bugs.webkit.org/show_bug.cgi?id=54676

This implements the "prepare a script" section of the HTML5 spec in ScriptElement::prepareScript().
http://www.whatwg.org/specs/web-apps/current-work/multipage/scripting-1.html#prepare-a-script

There are a couple of things missing from the spec that would be new functionality. These will be added later.

  • Support for async=false
  • Empty src attribute should dispatch an error.

There are a couple of slight behavioral changes to match the spec.

  • An XHTML script that is loaded then copied will not fire load on the copy.
  • If onbeforeload moves the script to a different document, then it will not try to execute again because wasAlreadyStarted is true.

The parsers were updated to use the new API, but not rewritten to look like the spec. That will be done separately.

Test: All existing tests.

  • dom/ScriptElement.cpp: Rewritten to match HTML5 spec. (WebCore::ScriptElement::ScriptElement): (WebCore::ScriptElement::insertedIntoDocument): Logic moved to prepareScript. (WebCore::ScriptElement::childrenChanged): Logic moved to prepareScript. (WebCore::ScriptElement::handleSourceAttribute): Logic moved to prepareScript. (WebCore::isLegacySupportedJavaScriptLanguage): Added to support old script types in layout tests. (WebCore::ScriptElement::isScriptTypeSupported): Derived from old shouldExecuteAsJavaScript(). (WebCore::ScriptElement::prepareScript): START HERE. Main change. Should read exactly like HTML5's "prepare a script." Legacy type support needed for layout tests using XML parser. (WebCore::ScriptElement::requestScript): Most logic moved to prepareScript. Check security settings here. (WebCore::ScriptElement::executeScript): Combined evaluateScript() and executeScript() from old code. Logic moved to prepareScript. (WebCore::ScriptElement::stopLoadRequest): Ignore parser executed scripts. (WebCore::ScriptElement::execute): Renamed executeScript. (WebCore::ScriptElement::notifyFinished): We should only listen for non-parser executed scripts. (WebCore::ScriptElement::ignoresLoadRequest): New variable names. (WebCore::ScriptElement::childrenAreCommentsOrEmptyText): Added for HTML5 compliance. (WebCore::ScriptElement::scriptCharset): Use HTML5 variables.
  • dom/ScriptElement.h: (WebCore::ScriptElement::willBeParserExecuted): Added. (WebCore::ScriptElement::readyToBeParserExecuted): Added. (WebCore::ScriptElement::willExecuteWhenDocumentFinishedParsing): Added. (WebCore::ScriptElement::cachedScript): prepareScript() is the only place that should load scripts. This accessor lets the parsers listen for when loads finish. (WebCore::ScriptElement::isParserInserted): Added.
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::endElementNs): Should behave the same. Offloads much of its work to prepareScript().
  • dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::parseEndElement): Identical to libxml2 changes.
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::insertedIntoDocument): No longer needs url. (WebCore::HTMLScriptElement::hasSourceAttribute): Added.
  • html/HTMLScriptElement.h:
  • html/parser/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::requestPendingScript): Requesting scripts offloaded to ScriptElement. (WebCore::HTMLScriptRunner::runScript): Should behave the same. Offloads much of its work to prepareScript().
  • svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::svgAttributeChanged): New ScriptElement function names. (WebCore::SVGScriptElement::insertedIntoDocument): No longer needs url. (WebCore::SVGScriptElement::finishParsingChildren): ScriptElement::finishParsingChildren is gone. (WebCore::SVGScriptElement::hasSourceAttribute): Added. (WebCore::SVGScriptElement::dispatchLoadEvent): New ScriptElement function names.
  • svg/SVGScriptElement.h:

TBR=simonjam@chromium.org

5:46 PM Changeset in webkit [80679] by rniwa@webkit.org
  • 2 edits
    1 add in trunk/Source/WebCore

2011-03-09 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

selectionStart reports wrong caret position when the last characters are newlines
https://bugs.webkit.org/show_bug.cgi?id=56061

The bug was caused by SelectionController::setSelection's not calling
notifyRendererOfSelectionChange when old selection was equal to new selection.

Because InsertLineBreakCommand inserts a text node with a single LF before the caret,
this condition holds after the command is executed. However, the values of
selectionStart and selectionEnd still need to be updated in this case because
the offsets counted from the beginning of textarea have been increased by 1.

  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): Call notifyRendererOfSelectionChange when m_selection = s.
  • manual-tests/selection-start-after-inserting-line-break-in-textarea.html: Added.
5:21 PM Changeset in webkit [80678] by mrobinson@webkit.org
  • 1 edit
    9 adds in trunk/LayoutTests

2011-03-09 Martin Robinson <mrobinson@igalia.com>

Add some new GTK+ test results.

  • platform/gtk/fast/blockflow/text-orientation-basic-expected.checksum: Added.
  • platform/gtk/fast/blockflow/text-orientation-basic-expected.png: Added.
  • platform/gtk/fast/blockflow/text-orientation-basic-expected.txt: Added.
  • platform/gtk/fast/dom/scroll-reveal-left-overflow-expected.checksum: Added.
  • platform/gtk/fast/dom/scroll-reveal-left-overflow-expected.png: Added.
  • platform/gtk/fast/dom/scroll-reveal-left-overflow-expected.txt: Added.
  • platform/gtk/fast/dom/scroll-reveal-top-overflow-expected.checksum: Added.
  • platform/gtk/fast/dom/scroll-reveal-top-overflow-expected.png: Added.
  • platform/gtk/fast/dom/scroll-reveal-top-overflow-expected.txt: Added.
4:49 PM Changeset in webkit [80677] by tony@chromium.org
  • 2 edits
    14 adds in trunk/LayoutTests

2011-03-09 Tony Chang <tony@chromium.org>

Unreviewed, third and final set of baselines for chromium linux lucid x86_64.
These are small rounding differences.
https://bugs.webkit.org/show_bug.cgi?id=55527

  • platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/paths-data-03-f-expected.checksum: Added.
  • platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/paths-data-03-f-expected.png: Added.
  • platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt: Added.
  • platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/paths-data-12-t-expected.checksum: Added.
  • platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/paths-data-12-t-expected.png: Added.
  • platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt: Added.
  • platform/chromium-linux-x86_64/svg/hixie/perf/001-expected.checksum: Added.
  • platform/chromium-linux-x86_64/svg/hixie/perf/001-expected.png: Added.
  • platform/chromium-linux-x86_64/svg/hixie/perf/001-expected.txt: Added.
  • platform/chromium-linux-x86_64/svg/hixie/perf/002-expected.checksum: Added.
  • platform/chromium-linux-x86_64/svg/hixie/perf/002-expected.png: Added.
  • platform/chromium-linux-x86_64/svg/hixie/perf/002-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
4:43 PM Changeset in webkit [80676] by tony@chromium.org
  • 2 edits
    66 adds in trunk/LayoutTests

2011-03-09 Tony Chang <tony@chromium.org>

Unreviewed, land a second set of baselines for chromium linux lucid x86_64.
These are differences due to a newer freetype and a few rounding
differences in gradients.
https://bugs.webkit.org/show_bug.cgi?id=55527

  • platform/chromium-linux-x86_64/fast/borders/borderRadiusGroove01-expected.checksum: Added.
  • platform/chromium-linux-x86_64/fast/borders/borderRadiusGroove01-expected.png: Added.
  • platform/chromium-linux-x86_64/fast/borders/borderRadiusGroove02-expected.checksum: Added.
  • platform/chromium-linux-x86_64/fast/borders/borderRadiusGroove02-expected.png: Added.
  • platform/chromium-linux-x86_64/fast/borders/borderRadiusRidge01-expected.checksum: Added.
  • platform/chromium-linux-x86_64/fast/borders/borderRadiusRidge01-expected.png: Added.
  • platform/chromium-linux-x86_64/fast/images/animated-svg-as-image-expected.checksum: Added.
  • platform/chromium-linux-x86_64/fast/images/animated-svg-as-image-expected.png: Added.
  • platform/chromium-linux-x86_64/fast/text/international/bidi-mirror-he-ar-expected.checksum: Added.
  • platform/chromium-linux-x86_64/fast/text/international/bidi-mirror-he-ar-expected.png: Added.
  • platform/chromium-linux-x86_64/fast/text/international/danda-space-expected.checksum: Added.
  • platform/chromium-linux-x86_64/fast/text/international/danda-space-expected.png: Added.
  • platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.checksum: Added.
  • platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.png: Added.
  • platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.checksum: Added.
  • platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png: Added.
  • platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/struct-frag-02-t-expected.checksum: Added.
  • platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/struct-frag-02-t-expected.png: Added.
  • platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/text-text-01-b-expected.checksum: Added.
  • platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/text-text-01-b-expected.png: Added.
  • platform/chromium-linux-x86_64/svg/batik/text/textFeatures-expected.checksum: Added.
  • platform/chromium-linux-x86_64/svg/batik/text/textFeatures-expected.png: Added.
  • platform/chromium-linux-x86_64/svg/batik/text/textLayout-expected.checksum: Added.
  • platform/chromium-linux-x86_64/svg/batik/text/textLayout-expected.png: Added.
  • platform/chromium-linux-x86_64/svg/custom/js-late-clipPath-and-object-creation-expected.checksum: Added.
  • platform/chromium-linux-x86_64/svg/custom/js-late-clipPath-and-object-creation-expected.png: Added.
  • platform/chromium-linux-x86_64/svg/custom/js-late-clipPath-creation-expected.checksum: Added.
  • platform/chromium-linux-x86_64/svg/custom/js-late-clipPath-creation-expected.png: Added.
  • platform/chromium-linux-x86_64/svg/custom/js-late-gradient-creation-expected.checksum: Added.
  • platform/chromium-linux-x86_64/svg/custom/js-late-gradient-creation-expected.png: Added.
  • platform/chromium-linux-x86_64/svg/custom/js-late-pattern-creation-expected.checksum: Added.
  • platform/chromium-linux-x86_64/svg/custom/js-late-pattern-creation-expected.png: Added.
  • platform/chromium-linux-x86_64/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.checksum: Added.
  • platform/chromium-linux-x86_64/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png: Added.
  • platform/chromium-linux-x86_64/svg/custom/svg-curve-with-relative-cordinates-expected.checksum: Added.
  • platform/chromium-linux-x86_64/svg/custom/svg-curve-with-relative-cordinates-expected.png: Added.
  • platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.checksum: Added.
  • platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.png: Added.
  • platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.checksum: Added.
  • platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.png: Added.
  • platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.checksum: Added.
  • platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.png: Added.
  • platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.checksum: Added.
  • platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.png: Added.
  • platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.checksum: Added.
  • platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.png: Added.
  • platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.checksum: Added.
  • platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.png: Added.
  • platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.checksum: Added.
  • platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.png: Added.
  • platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.checksum: Added.
  • platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.png: Added.
  • platform/chromium-linux-x86_64/svg/text/text-text-01-b-expected.checksum: Added.
  • platform/chromium-linux-x86_64/svg/text/text-text-01-b-expected.png: Added.
  • platform/chromium-linux-x86_64/transforms/2d/transform-borderbox-expected.checksum: Added.
  • platform/chromium-linux-x86_64/transforms/2d/transform-borderbox-expected.png: Added.
  • platform/chromium/test_expectations.txt:
4:39 PM Changeset in webkit [80675] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Reviewed by Dan Bernstein.

Frequent crashes when printing in WebPageProxy::setAutodisplay
https://bugs.webkit.org/show_bug.cgi?id=56057
<rdar://problem/9053290>

  • UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView _delayedResumeAutodisplayTimerFired]): Null check the page, there is no reason for it to still exist.
4:29 PM Changeset in webkit [80674] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix part 2.

4:29 PM Changeset in webkit [80673] by tony@chromium.org
  • 2 edits
    12 adds in trunk/LayoutTests

2011-03-09 Tony Chang <tony@chromium.org>

Unreviewed, first set of baselines for chromium linux lucid x86_64.
These are just small rounding differences.
https://bugs.webkit.org/show_bug.cgi?id=55527

  • platform/chromium-linux-x86_64/fast/repaint/moving-shadow-on-container-expected.txt: Added.
  • platform/chromium-linux-x86_64/fast/repaint/moving-shadow-on-path-expected.txt: Added.
  • platform/chromium-linux-x86_64/svg/css/composite-shadow-example-expected.txt: Added.
  • platform/chromium-linux-x86_64/svg/css/composite-shadow-with-opacity-expected.txt: Added.
  • platform/chromium-linux-x86_64/svg/css/stars-with-shadow-expected.txt: Added.
  • platform/chromium-linux-x86_64/svg/custom/use-on-symbol-inside-pattern-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
4:18 PM Changeset in webkit [80672] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-03-09 Andy Estes <aestes@apple.com>

Reviewed by Adam Barth.

Bad cast in HTMLTreeBuilder::processStartTag
https://bugs.webkit.org/show_bug.cgi?id=55955

  • fast/parser/self-closing-foreign-content-expected.txt: Added.
  • fast/parser/self-closing-foreign-content.html: Added.

2011-03-09 Andy Estes <aestes@apple.com>

Reviewed by Adam Barth.

Bad cast in HTMLTreeBuilder::processStartTag
https://bugs.webkit.org/show_bug.cgi?id=55955

Test: fast/parser/self-closing-foreign-content.html

When the parser encounters an svg or mathml root element, it places the
insertion mode into InForeignContentMode. However, if the root element
is self-closing (e.g. <svg />) then the element is never placed on the
open elements stack. This leaves the parser in an inconsistent state
where it is in InForeignContentMode but no foreign content is in the
open element stack.

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInBody): If a self-closing foreign element is inserted into the tree, do not set the insertion mode to InForeignContentMode.
4:17 PM Changeset in webkit [80671] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix part 1.

4:16 PM Changeset in webkit [80670] by tonyg@chromium.org
  • 4 edits in trunk/LayoutTests

2011-03-09 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Mihai Parparita.

Fix some potentially flaky tests
https://bugs.webkit.org/show_bug.cgi?id=56049

These tests were not resilient to parser yields for reasons explained below.

  • media/video-src-plus-source.html: loadstart or loadmetadata could have fired before the waitForEvent() calls. So define them prior to the <video> element.
  • platform/mac/accessibility/aria-expanded-notifications.html: The aria events could have fired before successfullyParsed was set, so run the test in the onload handler.
  • plugins/npruntime/npruntime.html: The plugin could have been loaded before successfullyParsed was set, so set it before including the plugin.
4:15 PM Changeset in webkit [80669] by barraclough@apple.com
  • 2 edits in trunk/Source/WebCore

Qt build fix.

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertQVariantToValue):

4:03 PM Changeset in webkit [80668] by aestes@apple.com
  • 3 edits
    2 adds in trunk

2011-03-09 Andy Estes <aestes@apple.com>

Reviewed by Adam Barth.

REGRESSION (r80320): Assertion failure when processing mis-nested foreign content.
https://bugs.webkit.org/show_bug.cgi?id=55982

  • fast/parser/fragment-foreign-content-misnested-expected.txt: Added.
  • fast/parser/fragment-foreign-content-misnested.html: Added.

2011-03-09 Andy Estes <aestes@apple.com>

Reviewed by Adam Barth.

REGRESSION (r80320): Assertion failure when processing mis-nested foreign content.
https://bugs.webkit.org/show_bug.cgi?id=55982

Test: fast/parser/fragment-foreign-content-misnested.html


It is a parse error to encounter certain start tags while the parser's
insertion mode is InForeignContentMode (e.g. <br>). In these cases, we
are to pop open elements off the HTMLElementStack until a foreign
content scope marker is encountered. Before the change in r80320 to not
insert a fake HTML element during fragment parsing, said fake HTML
element counted as a foreign content scope marker.


With r80320, no fake HTML element is inserted and the stack is popped
until empty in cases where no other element claims to be a foreign
content scope marker. Fix this by treating the DocumentFragment as a
foreign content scope marker.

  • html/parser/HTMLElementStack.cpp: (WebCore::HTMLNames::isForeignContentScopeMarker): Take a ContainerNode* instead of a Element*. (WebCore::HTMLElementStack::popUntilForeignContentScopeMarker): Pass topNode() to isForeignContentScopeMarker() instead of top().
3:04 PM Changeset in webkit [80667] by barraclough@apple.com
  • 23 edits in trunk

Bug 56041 - RexExp constructor should only accept flags "gim"
We also should be passing the flags around as a bitfield rather than a string,
and should not have redundant, incompatible code for converting the string to a bitfield!

Reviewed by Darin Adler.

Source/JavaScriptCore:

(JSC::RegExpNode::emitBytecode):

  • Need to parse flags string to enum.
  • runtime/RegExp.cpp:

(JSC::regExpFlags):
(JSC::RegExp::RegExp):
(JSC::RegExp::create):

  • Add method to parse flags string to enum, change constructor/create args to take enum.
  • runtime/RegExp.h:

(JSC::RegExp::global):
(JSC::RegExp::ignoreCase):
(JSC::RegExp::multiline):

  • Change to use new enum values.
  • runtime/RegExpCache.cpp:

(JSC::RegExpCache::lookupOrCreate):
(JSC::RegExpCache::create):

  • runtime/RegExpCache.h:
    • Changed to use regExpFlags enum instead of int/const UString&.
  • runtime/RegExpConstructor.cpp:

(JSC::constructRegExp):

  • Add use new enum parsing, check for error.
  • runtime/RegExpKey.h:

(JSC::RegExpKey::RegExpKey):

  • runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::RegExpPrototype):

  • Pass NoFlags value instead of empty string.

(JSC::regExpProtoFuncCompile):

  • Add use new enum parsing, check for error.
  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):

  • Pass NoFlags value instead of empty string.

Source/WebCore:

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneDeserializer::readTerminal):

  • Need to parse flags string back to enum.

LayoutTests:

  • sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A5_T1-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A5_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A5_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A5_T4-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A5_T5-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A5_T6-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A5_T7-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A5_T8-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A5_T9-expected.txt:
    • Check in passing results!
2:46 PM Changeset in webkit [80666] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-09 Martin Robinson <mrobinson@igalia.com>

jquery/manipulation.html fails after r80598
https://bugs.webkit.org/show_bug.cgi?id=56019

Skip jquery test failing on the GTK+ debug bots. Move another
failing test to the appropriate section.

  • platform/gtk/Skipped: Update skipped list.
2:27 PM Changeset in webkit [80665] by jamesr@google.com
  • 3 edits
    4 adds in trunk

2011-03-09 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium]: Regression - Explicitly copy compositing properties from LayerChromium to CCLayerImpl
https://bugs.webkit.org/show_bug.cgi?id=56021

Adds a test for basic functionality of the backface-visibility
property.

  • compositing/backface-visibility-expected.checksum: Added.
  • compositing/backface-visibility-expected.png: Added.
  • compositing/backface-visibility-expected.txt: Added.
  • compositing/backface-visibility.html: Added.

2011-03-09 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium]: Regression - Explicitly copy compositing properties from LayerChromium to CCLayerImpl
https://bugs.webkit.org/show_bug.cgi?id=56021

Initializes the m_doubleSided flag of LayerChromiums to the default
value of true so the back sides of layers without
backface-visibility:hidden are rendered.

Test: compositing/backface-visibility.html

  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::LayerChromium):
2:22 PM Changeset in webkit [80664] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/platform/mac/fast/lists/008-vertical-expected.txt

Restore lists layout test to its pre-text-orientation patch results now that ex units are fixed for vertical text.

2:21 PM Changeset in webkit [80663] by andreip@google.com
  • 2 edits in trunk/LayoutTests

2011-03-09 Andrei Popescu <andreip@google.com>

Unreviewed, build fix.

[Chromium] test_expectations.txt needs updating to expect crashes in tests
that trigger the assertion in FontCache::releaseFontData.
https://bugs.webkit.org/show_bug.cgi?id=56051

We have started seeing an assertion failure in FontCache.cpp:310 after r80582.
It is unclear whether r80582 caused the assertion or whether the problem was
already present at r80582 just made it manifest itself more often. Update the
test_expectations.txt file while we're investigating.

  • platform/chromium/test_expectations.txt:
2:20 PM Changeset in webkit [80662] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/9110316> REGRESSION: 'ex' unit broken for vertical text

Reviewed by Dan Bernstein.

Fall back to the verticalRightOrientation data when obtaining the x-height for vertically oriented
text. That way we use the same metrics as for horizontal.

This fixes regressions in fast/lists and fast/overflow vertical text tests.

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformBoundsForGlyph):

2:07 PM Changeset in webkit [80661] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed build correction.

  • UIProcess/DrawingAreaProxy.messages.in: Exclude the other method using LayerTreeContext for non-accelerated composition case.
1:47 PM Changeset in webkit [80660] by xji@chromium.org
  • 2 edits
    14 adds in trunk/LayoutTests

2011-03-09 Xiaomei Ji <xji@chromium.org>

Unreviewed.

Rebaseline after r80622.

  • platform/chromium-linux/fast/dom/scroll-reveal-left-overflow-expected.checksum: Added.
  • platform/chromium-linux/fast/dom/scroll-reveal-left-overflow-expected.png: Added.
  • platform/chromium-linux/fast/dom/scroll-reveal-top-overflow-expected.checksum: Added.
  • platform/chromium-linux/fast/dom/scroll-reveal-top-overflow-expected.png: Added.
  • platform/chromium-mac/fast/dom/scroll-reveal-left-overflow-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/scroll-reveal-left-overflow-expected.png: Added.
  • platform/chromium-mac/fast/dom/scroll-reveal-left-overflow-expected.txt: Added.
  • platform/chromium-mac/fast/dom/scroll-reveal-top-overflow-expected.txt: Added.
  • platform/chromium-win/fast/dom/scroll-reveal-left-overflow-expected.checksum: Added.
  • platform/chromium-win/fast/dom/scroll-reveal-left-overflow-expected.png: Added.
  • platform/chromium-win/fast/dom/scroll-reveal-left-overflow-expected.txt: Added.
  • platform/chromium-win/fast/dom/scroll-reveal-top-overflow-expected.checksum: Added.
  • platform/chromium-win/fast/dom/scroll-reveal-top-overflow-expected.png: Added.
  • platform/chromium-win/fast/dom/scroll-reveal-top-overflow-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
1:18 PM Changeset in webkit [80659] by inferno@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-09 Abhishek Arya <inferno@chromium.org>

Unreviewed. Rebaselining after text orientation change in r80582.

  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
12:25 PM Changeset in webkit [80658] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

2011-03-09 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

REGRESSION: crash in nextLinePosition when extending selection forward by line in an empty document
https://bugs.webkit.org/show_bug.cgi?id=56004

Added a regression test.

  • editing/selection/extend-by-line-in-empty-document-expected.txt: Added.
  • editing/selection/extend-by-line-in-empty-document.html: Added.

2011-03-09 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

REGRESSION: crash in nextLinePosition when extending selection forward by line in an empty document
https://bugs.webkit.org/show_bug.cgi?id=56004

The crash was caused by the false assumption that rootEditableElement() or documentElement()
always return non-null pointer. Fixed the bug by adding an early exit.

Test: editing/selection/extend-by-line-in-empty-document.html

  • editing/visible_units.cpp: (WebCore::previousLinePosition): (WebCore::nextLinePosition):
11:49 AM Changeset in webkit [80657] by Adam Roben
  • 2 edits in trunk/Tools

Hide Leaks Viewer's URL prompt by default

We will show it as needed. I think I left it visible by default by accident after doing some
testing.

Fixes <http://webkit.org/b/56031> Leaks Viewer: URL prompt overlay shouldn't appear when a
URL is passed as a query parameter, but does

Reviewed by Simon Fraser.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
11:42 AM Changeset in webkit [80656] by Adam Roben
  • 3 edits in trunk/Tools

Don't use Element.classList or box-shadow in Leaks Viewer

They aren't supported by Safari 5. Luckily we have substitutes for them!

Fixes <http://webkit.org/b/56035> Leaks viewer doesn't work in Safari 5

Reviewed by Simon Fraser.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:

(#url-prompt): Use -webkit-box-shadow instead of box-shadow.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:

(LeaksViewer.urlPromptButtonClicked):
(LeaksViewer._displayURLPrompt):
(LeaksViewer._setLoadingIndicatorHidden):
Use add/removeStyleClass (from utilities.js) instead of Element.classList.

11:21 AM Changeset in webkit [80655] by podivilov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-09 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: it should be possible to copy stack trace from call stack sidebar pane.
https://bugs.webkit.org/show_bug.cgi?id=56024

  • English.lproj/localizedStrings.js:
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane): (WebInspector.CallStackSidebarPane.prototype.update): (WebInspector.CallStackSidebarPane.prototype._contextMenu):
11:17 AM Changeset in webkit [80654] by hyatt@apple.com
  • 5 edits in trunk/Source/WebCore

Patch FontPlatformDataLinux to properly initialize and copy orientation/text-orientation in all
places. Make sure text-orientation is specified in the lookups/creation in FontCustomPlatformData
and FontCache.

Reviewed by Darin Adler.

  • platform/graphics/chromium/FontPlatformDataLinux.cpp:

(WebCore::FontPlatformData::FontPlatformData):

  • platform/graphics/chromium/FontPlatformDataLinux.h:

(WebCore::FontPlatformData::FontPlatformData):

11:14 AM Changeset in webkit [80653] by steveblock@google.com
  • 4 edits in trunk/Source/WebCore

2011-03-09 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

JavaNPObject should not use JNI directly
https://bugs.webkit.org/show_bug.cgi?id=56009

We move the JNI code to access a Java object's fields into
a new JavaInstance::getField() method.

No new tests, refactoring only.

  • bridge/jni/v8/JavaInstanceV8.cpp: (JavaInstance::getField):
  • bridge/jni/v8/JavaInstanceV8.h:
  • bridge/jni/v8/JavaNPObjectV8.cpp: (JSC::Bindings::JavaNPObjectGetProperty):
10:55 AM Changeset in webkit [80652] by Adam Roben
  • 2 edits in trunk/Tools

Add a link to the Leaks Viewer tool on the build.webkit.org homepage

Rubber-stamped by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/templates/root.html:
10:50 AM Changeset in webkit [80651] by Adam Roben
  • 1 edit
    6 adds in trunk/Tools

Add a Leaks Viewer tool to build.webkit.org

This tool parses leaks from the files generated by the leaks bot and displays them in a
view similar to the Web Inspector's Profiles pane (in fact, it uses the Web Inspector's
code).

The URL of the leaks file can be entered in a prompt when the tools is first shown, or can
be passed to the tool via the "url" query parameter.

Only one leaks file can be viewed at a time for now. Only the number of leaks, as opposed to
the number of leaked bytes, is shown. And this tool has made apparent some bugs in the Web
Inspector's Heavy profile view. But it's still pretty useful as-is.

Fixes <http://webkit.org/b/56028> Would like a Shark-like tool for viewing leaks from leak bots

Reviewed by Darin Adler.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css: Added.

(#url-prompt-container): This is the dark overlay that is shown behind the URL prompt.
(#url-prompt): This is the prompt itself.

(#loading-indicator):
(#loading-indicator > img):
These show a spinner in the bottom-right when we're loading a leaks file.

(.percent-time-status-bar-item): Hide the Percent button since we never want to show leaks
as percentages.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js: Added.

(LeaksViewer.loaded): Initialize ourselves and start loading the leaks file (or prompt for a
URL if one wasn't given to us as a query parameter).

(LeaksViewer.get loading):
(LeaksViewer.set loading):
(LeaksViewer.get url):
(LeaksViewer.set url):
Pretty simple accessors.

(LeaksViewer.urlPromptButtonClicked): Start loading the URL from the prompt and hide the
prompt.
(LeaksViewer._displayURLPrompt): Show the prompt and focus the URL input.
(LeaksViewer._loadLeaksFromURL): Start fetching the leaks file. When we've retrieved the
file, hand it off to a Web Worker that will parse it into a fake "profile", then hand off
the profile to the Web Inspector code once it's been created.
(LeaksViewer._loadingStatusChanged): Update our loading indicator and title.
(LeaksViewer._setLoadingIndicatorHidden): Simply hide or show the indicator.
(LeaksViewer._updateTitle): Set our title based on our URL and loading status.
(getResource): Helper function to fetch a resource via XHR and pass it to a callback.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js: Added.

(WebInspector.UIString): Just a simple implementation since this tool isn't localized.
(ProfilerAgent.getProfile): Store the callback.
(ProfilerAgent.profileReady): Call the callback.
(monkeyPatchInspectorObjects): Fix up WebInspector.ProfileDataGridNode to show the self leak
count and total leak counts as real values, not percentages or milliseconds.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Added.

(onmessage): Create a profile based on the leaks file and pass it back to our caller.
(parseLeaks): Extract call stacks out of a leaks file.
(createNode): Helper function to create a new empty profile node.
(createProfile): Take the leak stacks and turn them into a fake "profile" for consumption by
WebInspector.ProfileView.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added.
10:24 AM Changeset in webkit [80650] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Update expected results of svg/css/getComputedStyle-basic after r80582.

  • svg/css/getComputedStyle-basic-expected.txt:
10:21 AM Changeset in webkit [80649] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-09 Mihai Parparita <mihaip@chromium.org>

Update chromium-gpu expectations.

  • platform/chromium/test_expectations.txt:
10:19 AM Changeset in webkit [80648] by hyatt@apple.com
  • 2 edits in trunk/LayoutTests/platform/mac/fast/lists

Update lists vertical tests after text-orientation landing.

10:17 AM Changeset in webkit [80647] by steveblock@google.com
  • 4 edits in trunk/Source/WebCore

2011-03-09 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

NPAPI - jvalue conversion should not be in JavaInstance
https://bugs.webkit.org/show_bug.cgi?id=55967

No new tests, refactoring only.

  • bridge/jni/v8/JavaInstanceV8.cpp: (JavaInstance::invokeMethod):
  • bridge/jni/v8/JavaInstanceV8.h:
  • bridge/jni/v8/JavaNPObjectV8.cpp: (JSC::Bindings::JavaNPObjectInvoke):
10:06 AM Changeset in webkit [80646] by weinig@apple.com
  • 3 edits
    2 copies in trunk/Source/WebKit2

Change plugins to use their own executable on Mac OS X
https://bugs.webkit.org/show_bug.cgi?id=55991

Reviewed by Anders Carlsson.

  • Configurations/PluginProcess.xcconfig: Copied from Source/WebKit2/Configurations/WebProcess.xcconfig.
  • PluginProcess/Info.plist: Copied from Source/WebKit2/WebProcess/Info.plist.

Add files necessary for adding PluginProcess.app.

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess):
Launch the PluginProcess.app when launching a plugin process.

  • WebKit2.xcodeproj/project.pbxproj:

Add new executable and new files, removes some unneeded copying
and duplicate compiling of files.

  • WebProcess/Info.plist:

Sorted.

10:03 AM Changeset in webkit [80645] by bweinstein@apple.com
  • 3 edits in trunk/LayoutTests

Update expected results of computed-style and computed-style-without-renderer after
r80582.

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
9:47 AM Changeset in webkit [80644] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

jquery/manipulation.html fails after r80598
https://bugs.webkit.org/show_bug.cgi?id=56019

  • platform/qt/Skipped:Add jquery tests to make buildbots happier.
8:41 AM Changeset in webkit [80643] by jberlin@webkit.org
  • 16 edits in trunk

Use the Cookie Storage from the Private Browsing Storage Session directly
https://bugs.webkit.org/show_bug.cgi?id=55986

Reviewed by Adam Roben.

Source/WebCore:

  • WebCore.exp.in:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
  • platform/network/mac/CookieStorageMac.mm:

(WebCore::setCookieStoragePrivateBrowsingEnabled):
Just copy the cookie storage from the private browsing storage session.

  • platform/network/cf/CookieStorageCFNet.cpp:

(WebCore::setCookieStoragePrivateBrowsingEnabled):
Ditto.

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

WebKitLibraries:

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
8:15 AM Changeset in webkit [80642] by mitz@apple.com
  • 2 edits in trunk/Tools

Combine multiple --ignore-tests values
https://bugs.webkit.org/show_bug.cgi?id=56016

Reviewed by Adam Roben.

  • Scripts/old-run-webkit-tests:
6:49 AM Changeset in webkit [80641] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-09 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Fixed a crash in InspectorInstrumentation::didReceiveResponse() when loader is null (broken in r80639)

  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
6:02 AM Changeset in webkit [80640] by yurys@chromium.org
  • 7 edits in trunk

2011-03-09 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: pass explicit agent references to InspectorBackendDispatcher
https://bugs.webkit.org/show_bug.cgi?id=55820

  • http/tests/inspector-enabled/open-close-open-expected.txt:
  • http/tests/inspector-enabled/open-close-open.html:
  • http/tests/inspector/inspector-test.js: ():

2011-03-09 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: pass explicit agent references to InspectorBackendDispatcher
https://bugs.webkit.org/show_bug.cgi?id=55820

  • inspector/CodeGeneratorInspector.pm:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::dispatchMessageFromFrontend):
5:40 AM Changeset in webkit [80639] by caseq@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-09 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: resource errors are not reported before front-end is opened
https://bugs.webkit.org/show_bug.cgi?id=55939

  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::didReceiveResourceResponse): (WebCore::InspectorInstrumentation::didFailLoading):
5:34 AM Changeset in webkit [80638] by alex
  • 2 edits
    2 adds in trunk/Source/WebKit2

2011-03-09 Alejandro G. Castro <alex@igalia.com>

Fix compilation after r80596, add soup Download stubs.

  • GNUmakefile.am:
  • WebProcess/Downloads/soup/DownloadSoup.cpp: Added. (WebKit::Download::start): (WebKit::Download::startWithHandle): (WebKit::Download::cancel): (WebKit::Download::platformInvalidate): (WebKit::Download::didDecideDestination): (WebKit::Download::platformDidFinish):
5:32 AM Changeset in webkit [80637] by alex
  • 2 edits in trunk/Source/WebKit2

2011-03-09 Alejandro G. Castro <alex@igalia.com>

Fix GTK+ compilation after r80619. Add WebFullScreenManager.

  • GNUmakefile.am:
5:05 AM Changeset in webkit [80636] by rolandsteiner@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-09 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed: assign bug entries to Chromium test expectations.

  • platform/chromium/test_expectations.txt:
4:05 AM Changeset in webkit [80635] by hans@chromium.org
  • 12 edits in trunk/Source

2011-03-08 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Add BackingStoreType parameter to IDBFactoryBackendInterface::open
https://bugs.webkit.org/show_bug.cgi?id=55948

Add a parameter that allows for selection of alternative backing store
implementations.

No new tests: no new functionality.

  • storage/IDBFactory.cpp: (WebCore::IDBFactory::open):
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::open):
  • storage/IDBFactoryBackendImpl.h:
  • storage/IDBFactoryBackendInterface.h:

2011-03-08 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Add BackingStoreType parameter to IDBFactoryBackendInterface::open
https://bugs.webkit.org/show_bug.cgi?id=55948

Add a parameter that allows for selection of alternative backing store
implementations.

  • public/WebIDBFactory.h: (WebKit::WebIDBFactory::open):
  • src/AssertMatchingEnums.cpp:
  • src/IDBFactoryBackendProxy.cpp: (WebCore::IDBFactoryBackendProxy::open):
  • src/IDBFactoryBackendProxy.h:
  • src/WebIDBFactoryImpl.cpp: (WebKit::WebIDBFactoryImpl::open):
  • src/WebIDBFactoryImpl.h:
3:52 AM Changeset in webkit [80634] by Carlos Garcia Campos
  • 2 edits in trunk/LayoutTests

2011-03-09 Carlos Garcia Campos <cgarcia@igalia.com>

Unreviewed. Move fast/canvas/rgba-parsing.html to the group of
tests failing due to rounding color problems in cairo/pixman.

  • platform/gtk/Skipped:
3:09 AM Changeset in webkit [80633] by steveblock@google.com
  • 5 edits in trunk/Source/WebCore

2011-03-08 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Factor out JNI method call to be used by both JSC and V8
https://bugs.webkit.org/show_bug.cgi?id=55966

No new tests, refactoring only.

  • bridge/jni/JNIUtility.cpp: (JSC::Bindings::callJNIMethod):
  • bridge/jni/JNIUtility.h:
  • bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod):
  • bridge/jni/v8/JavaInstanceV8.cpp: (JavaInstance::invokeMethod):
3:01 AM Changeset in webkit [80632] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-09 Andrey Adaikin <aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: [Text editor] Regression in handling DOMNodeInserted/DOMNodeRemoved events
https://bugs.webkit.org/show_bug.cgi?id=55818

  • inspector/front-end/TextViewer.js: (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
2:53 AM Changeset in webkit [80631] by rolandsteiner@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

2011-03-09 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed: more vertical text fallout for the chromium test expectations.
Also, a rebaseline.

  • platform/chromium-mac/fast/lists/003-vertical-expected.checksum: Added.
  • platform/chromium-mac/fast/lists/003-vertical-expected.png: Added.
  • platform/chromium-mac/fast/lists/003-vertical-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
2:00 AM Changeset in webkit [80630] by loislo@chromium.org
  • 5 edits in trunk

2011-03-09 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Web Inspector: we don't need to transfer objectId and hasChildren for primitive values.
https://bugs.webkit.org/show_bug.cgi?id=55998

  • inspector/protocol/console-agent-expected.txt:
  • inspector/protocol/runtime-agent-expected.txt:

2011-03-09 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Web Inspector: we don't need to transfer objectId and hasChildren for primitive values.
https://bugs.webkit.org/show_bug.cgi?id=55998

  • inspector/InjectedScriptSource.js:
1:57 AM Changeset in webkit [80629] by pfeldman@chromium.org
  • 14 edits in trunk

2011-03-09 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: watch expressions should show string values in quotes.
https://bugs.webkit.org/show_bug.cgi?id=55846

  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest):
  • inspector/console/console-dir-expected.txt:
  • inspector/console/console-dir.html:
  • inspector/debugger/debugger-expand-scope-expected.txt:
  • inspector/debugger/debugger-expand-scope.html:
  • platform/chromium/inspector/console/console-dir-expected.txt:
  • platform/chromium/inspector/debugger/debugger-expand-scope-expected.txt:

2011-03-09 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: watch expressions should show string values in quotes.
https://bugs.webkit.org/show_bug.cgi?id=55846

  • inspector/InjectedScriptSource.js:
  • inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype.update):
  • inspector/front-end/RemoteObject.js: (WebInspector.LocalJSONObject.prototype.get description):
  • inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update):
  • inspector/front-end/inspector.css: (.console-formatted-string, .console-formatted-regexp):
1:53 AM Changeset in webkit [80628] by pfeldman@chromium.org
  • 6 edits in trunk

2011-03-09 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: "length" getter is invoked upon console object formatting.
https://bugs.webkit.org/show_bug.cgi?id=55220

  • inspector/console/console-format-expected.txt:
  • inspector/console/console-format.html:
  • platform/chromium/inspector/console/console-format-expected.txt:

2011-03-09 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: "length" getter is invoked upon console object formatting.
https://bugs.webkit.org/show_bug.cgi?id=55220

  • inspector/InjectedScriptSource.js:
1:25 AM Changeset in webkit [80627] by rolandsteiner@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-09 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed: yet more tweaking of the chromium test expectations.

  • platform/chromium/test_expectations.txt:
1:07 AM Changeset in webkit [80626] by rolandsteiner@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-09 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed: fix chromium test expectations file.

  • platform/chromium/test_expectations.txt:
12:46 AM Changeset in webkit [80625] by rolandsteiner@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-09 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed: update chromium test expectations

  • platform/chromium/test_expectations.txt:
Note: See TracTimeline for information about the timeline view.