Timeline



Oct 30, 2011:

7:50 PM Changeset in webkit [98835] by yutak@chromium.org
  • 5 edits in trunk/LayoutTests

WebSocket: iframe in reload-crash.html reloads forever
​https://bugs.webkit.org/show_bug.cgi?id=71098

Reviewed by Kent Tamura.

iframe in this test should not get reloaded more than once.

  • http/tests/websocket/tests/hixie76/reload-crash.html:

Provide the value of reloadCount to the script in iframe.

  • http/tests/websocket/tests/hixie76/resources/reload-crash-iframe.html:

Call location.reload() only if reloadCount is zero.

  • http/tests/websocket/tests/hybi/reload-crash.html:
  • http/tests/websocket/tests/hybi/resources/reload-crash-iframe.html:
6:50 PM Changeset in webkit [98834] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JSParser::parsePrimaryExpression should have an overflow check
​https://bugs.webkit.org/show_bug.cgi?id=71197

Reviewed by Geoff Garen.

  • parser/JSParser.cpp:

(JSC::JSParser::parsePrimaryExpression):

6:43 PM Changeset in webkit [98833] by commit-queue@webkit.org
  • 13 edits in trunk/Tools

Unreviewed, rolling out r98819, r98823, r98825, and r98830.
​http://trac.webkit.org/changeset/98819
​http://trac.webkit.org/changeset/98823
​http://trac.webkit.org/changeset/98825
​http://trac.webkit.org/changeset/98830
​https://bugs.webkit.org/show_bug.cgi?id=71199

Broke Chromium Windows bot (Requested by rniwa on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-30

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  • Scripts/webkitpy/layout_tests/port/efl.py:
  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
5:21 PM Changeset in webkit [98832] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG ValueAdd(string, int) should not fail speculation
​https://bugs.webkit.org/show_bug.cgi?id=71195

Reviewed by Geoff Garen.

1% speed-up on V8.

  • dfg/DFGNode.h:

(JSC::DFG::Node::shouldNotSpeculateInteger):
(JSC::DFG::Node::shouldSpeculateInteger):

3:47 PM Changeset in webkit [98831] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

The DFG inliner should not flush the callee
​https://bugs.webkit.org/show_bug.cgi?id=71191

Reviewed by Oliver Hunt.

0.6% speed-up on V8.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitAggregate):

  • bytecode/CodeOrigin.h:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::flush):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

  • dfg/DFGJITCompiler32_64.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

  • interpreter/CallFrame.cpp:

(JSC::CallFrame::trueCallerFrameSlow):

3:42 PM Changeset in webkit [98830] by eric@webkit.org
  • 2 edits in trunk/Tools

new-run-webkit-tests is locale dependent
​https://bugs.webkit.org/show_bug.cgi?id=68691

Unreviewed.

This is a temporary hack until someone from the cr-win port
can take a look and determine which environment variable
lighttpd is missing.

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
3:06 PM Changeset in webkit [98829] by rik@webkit.org
  • 2 edits in trunk/Websites/planet.webkit.org

Add Peter Beverloo's feed to Planet WebKit
​https://bugs.webkit.org/show_bug.cgi?id=70316

Reviewed by Andreas Kling.

  • config.ini:
12:34 PM Changeset in webkit [98828] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Remove crash expectations from tests that have not been crashing on Chromium.

  • platform/chromium/test_expectations.txt:
9:29 AM Changeset in webkit [98827] by Martin Robinson
  • 11 edits in trunk/Source

[GTK] Switch to a backing store approach for painting WebKitWebView
​https://bugs.webkit.org/show_bug.cgi?id=70213

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

No new tests. The changes to WebCore should not change
behavior. The changes in WebKit are covered by existing
tests.

  • platform/cairo/WidgetBackingStore.h:

(WebCore::WidgetBackingStore::size): Added this getter for the size.

  • platform/cairo/WidgetBackingStoreCairo.cpp:

(WebCore::WidgetBackingStore::WidgetBackingStore): Initialize size.

  • platform/graphics/cairo/CairoUtilities.cpp:

(WebCore::copyRectFromCairoSurfaceToContext): Added this new helper.
(WebCore::copyRectFromOneSurfaceToAnother): Use the new helper.

  • platform/graphics/cairo/CairoUtilities.h:
  • platform/gtk/GtkWidgetBackingStoreX11.cpp:

(WebCore::WidgetBackingStore::WidgetBackingStore): Initialize the size.

Source/WebKit/gtk:

Paint the WebView into a backing store. This prevents expose events from
triggering a layout, making scrolling and resizing much smoother.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::ChromeClient): Initialize new members.
(WebKit::repaintEverythingSoonTimeout): Added this helper which repaints
the WebView more quickly during resize events.
(WebKit::clipOutOldWidgetArea): Clips out the old widget area, so that we
can clear out invalid pixels when growing the widget into a pre-existing
backing store.
(WebKit::clearEverywhereInBackingStore): Clear out the entire backing store.
(WebKit::ChromeClient::widgetSizeChanged): Handle widget size changes by
intelligently resizing or reusing the existing backing store.
(WebKit::coalesceRectsIfPossible): Moved this method from webkitwebview.cpp.
(WebKit::paintWebView): Moved this method from webkitwebview.cpp.
(WebKit::ChromeClient::performAllPendingScrolls): If there are any pending
scrolling operations, perform them by scrolling the backing store.
(WebKit::ChromeClient::paint): Added this timer callback, which paints the
WebView after a short timeout.
(WebKit::ChromeClient::invalidateWindow): No need to do anything here any longer.
(WebKit::ChromeClient::invalidateContentsAndWindow): Now unite the rect with
the existing dirty region and queue the paint timeout.
(WebKit::ChromeClient::scroll): Now just queue a scroll event in the repaint timeout.
Intelligently calculate the area to move and the dirty area using code derived
from WebKit2.

  • WebCoreSupport/ChromeClientGtk.h: Added new method definitions and also use

the WebCore namespace to avoid lots of uses of "WebCore::".

  • webkit/webkitwebview.cpp:

(webkit_web_view_draw): Now just blit the backing store into the widget.
(webkit_web_view_expose): Ditto.
(webkit_web_view_size_allocate): Let the ChromeClient know the widget size changed.
(webkit_web_view_init): Turn off GDK double buffering as we have our own double
buffer.

  • webkit/webkitwebviewprivate.h: Add the backing store member.
9:03 AM Changeset in webkit [98826] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r98803.
​http://trac.webkit.org/changeset/98803
​https://bugs.webkit.org/show_bug.cgi?id=71186

Causing test and assertion failures on some platforms
(Requested by anttik on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-30

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyMatchedDeclarations):

12:57 AM Changeset in webkit [98825] by eric@webkit.org
  • 7 edits in trunk/Tools

new-run-webkit-tests is locale dependent
​https://bugs.webkit.org/show_bug.cgi?id=68691

Unreviewed. I would have preferred to have this reviewed,
but relevant reviewers are asleep and bots are broken.

This was a regression from moving to a clean environment.
ChromiumWin (and possibly other ports), need the "PATH"
environment copied over. This wasn't caught in my testing
because although we had unittests to cover this, they
weren't being run on anything but windows. The vast majority
of this change is just fixing the unittests to use our
modern MockFileSystem/MockUser/MockExecutive so they can
be run on any system (and removing the platform checks from
the unittests so they are run everywhere).

The actual fix is the single line "PATH" string added to base.py.
The rest of this change is just fixing the Chromium port unittests
to run on all systems (including changing the Chromium port to
use FileSystem.path_to_module instead of file).

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:

Oct 29, 2011:

10:36 PM Changeset in webkit [98824] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix.

  • platform/graphics/mac/WebLayer.mm:

(drawLayerContents):

8:06 PM Changeset in webkit [98823] by eric@webkit.org
  • 3 edits in trunk/Tools

new-run-webkit-tests is locale dependent
​https://bugs.webkit.org/show_bug.cgi?id=68691

Unreviewed.

Fix the Qt port and unittest the function so we don't break it again.

  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:
5:45 PM Changeset in webkit [98822] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix.

  • editing/Editor.cpp:

(WebCore::Editor::markMisspellingsAfterTypingToWord):

4:27 PM Changeset in webkit [98821] by dcheng@chromium.org
  • 16 edits
    7 moves in trunk/Source/WebCore

Rename DataTransferItems to DataTransferItemList
​https://bugs.webkit.org/show_bug.cgi?id=71151

Per feedback that Items and Item are hard to distinguish between, the HTML5 spec renamed
DataTransferItems to DataTransferItemList:
​http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#the-datatransferitemlist-interface

Reviewed by Tony Chang.

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Clipboard.h:
  • dom/Clipboard.idl:
  • dom/DataTransferItemList.cpp: Renamed from Source/WebCore/dom/DataTransferItems.cpp.

(WebCore::DataTransferItemList::DataTransferItemList):
(WebCore::DataTransferItemList::length):
(WebCore::DataTransferItemList::item):
(WebCore::DataTransferItemList::deleteItem):
(WebCore::DataTransferItemList::clear):
(WebCore::DataTransferItemList::add):

  • dom/DataTransferItemList.h: Renamed from Source/WebCore/dom/DataTransferItems.h.

(WebCore::DataTransferItemList::~DataTransferItemList):

  • dom/DataTransferItemList.idl: Renamed from Source/WebCore/dom/DataTransferItems.idl.
  • platform/chromium/ClipboardChromium.cpp:

(WebCore::ClipboardChromium::items):

  • platform/chromium/ClipboardChromium.h:
  • platform/chromium/DataTransferItemListChromium.cpp: Renamed from Source/WebCore/platform/chromium/DataTransferItemsChromium.cpp.

(WebCore::DataTransferItemListChromium::create):
(WebCore::DataTransferItemListChromium::DataTransferItemListChromium):
(WebCore::DataTransferItemListChromium::addPasteboardItem):

  • platform/chromium/DataTransferItemListChromium.h: Renamed from Source/WebCore/platform/chromium/DataTransferItemsChromium.h.
  • platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::items):

  • platform/qt/ClipboardQt.h:
  • platform/qt/DataTransferItemListQt.cpp: Renamed from Source/WebCore/platform/qt/DataTransferItemsQt.cpp.

(WebCore::DataTransferItemListQt::create):
(WebCore::DataTransferItemListQt::DataTransferItemListQt):
(WebCore::DataTransferItemListQt::addPasteboardItem):

  • platform/qt/DataTransferItemListQt.h: Renamed from Source/WebCore/platform/qt/DataTransferItemsQt.h.
3:55 PM Changeset in webkit [98820] by annacc@chromium.org
  • 3 edits in trunk/LayoutTests

Add track-text-track-destructor-crash.html to Skipped files for mac and win
​https://bugs.webkit.org/show_bug.cgi?id=71182

Reviewed by Ryosuke Niwa.

  • platform/mac/Skipped:
  • platform/win/Skipped:
3:06 PM Changeset in webkit [98819] by eric@webkit.org
  • 7 edits in trunk/Tools

new-run-webkit-tests is locale dependent
​https://bugs.webkit.org/show_bug.cgi?id=68691

Reviewed by Adam Barth.

Make NRWT use a clean environment just like ORWT did.
I've manually validated that NRWT now copies over
the same environment variables that ORWT did.
This new code is exercised by existing setup_environ_for_server tests.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/efl.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
3:04 PM Changeset in webkit [98818] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

Mac rebaseline after r98813.

  • platform/mac/css2.1/20110323/block-non-replaced-width-008-expected.txt:
  • platform/mac/fast/replaced/width100percent-searchfield-expected.txt:
2:34 PM Changeset in webkit [98817] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add flaky test expectation to fast/forms/input-step-as-double.html on Chromium.
The failure is tracked by the bug 71181.

  • platform/chromium/test_expectations.txt:
2:20 PM Changeset in webkit [98816] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

GTK+ and Qt rebaselines after r98794.

  • platform/gtk/editing/pasteboard/5134759-expected.txt:
  • platform/qt/editing/pasteboard/5134759-expected.txt:
1:35 PM Changeset in webkit [98815] by robert@webkit.org
  • 2 edits
    2 moves
    1 add in trunk/LayoutTests

Second attempt to add results for tests introduced in ​http://trac.webkit.org/changeset/98812

  • platform/chromium-linux/css2.1/20110323/block-non-replaced-width-008-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-008-expected.txt:
  • platform/chromium/css2.1/20110323/block-non-replaced-width-008-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/css2.1/20110323/block-non-replaced-width-008-expected.png.
  • platform/chromium/css2.1/20110323/block-non-replaced-width-008-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/css2.1/20110323/block-non-replaced-width-008-expected.txt.
1:14 PM Changeset in webkit [98814] by robert@webkit.org
  • 5 edits in trunk/LayoutTests

Qt and Gtk Results for tests updated by ​http://trac.webkit.org/changeset/98812

Unreviewed, platform-specific results.

  • platform/gtk/css2.1/20110323/block-non-replaced-width-008-expected.txt:
  • platform/gtk/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-width-008-expected.txt:
  • platform/qt/fast/replaced/width100percent-searchfield-expected.txt:
1:06 PM Changeset in webkit [98813] by robert@webkit.org
  • 1 edit
    1 move
    7 adds in trunk/LayoutTests

Add results for tests introduced in ​http://trac.webkit.org/changeset/98812.

Unreviewed, platform-specific results.

  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/block-non-replaced-width-008-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/block-non-replaced-width-008-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/fast/replaced/width100percent-searchfield-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-searchfield-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/replaced/width100percent-searchfield-expected.png.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-008-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-008-expected.txt: Added.
12:15 PM Changeset in webkit [98812] by robert@webkit.org
  • 7 edits in trunk

CSS 2.1 failure: block-non-replaced-width-008.htm
​https://bugs.webkit.org/show_bug.cgi?id=69278

Reviewed by Simon Fraser.

Source/WebCore:

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalWidthUsing):

Include the margins in the calculation of logical width even when the containing block's
width is zero. This is required by section '10.3.3 Block-level, non-replaced elements in
normal flow' in the CSS 2.1 spec. Tested by block-non-replaced-width-008.htm in the CSS
test suite.

LayoutTests:

  • platform/chromium-win/fast/replaced/width100percent-searchfield-expected.txt: The pixel result is preserved, but the width of the containing block in the render tree now accurately reflects the rendered size of the cells.
  • platform/chromium/test_expectations.txt:
  • platform/mac/css2.1/20110323/block-non-replaced-width-008-expected.png:
  • platform/mac/css2.1/20110323/block-non-replaced-width-008-expected.txt:
11:58 AM Changeset in webkit [98811] by abarth@webkit.org
  • 1 edit
    20 adds
    5 deletes in trunk/LayoutTests

Add results for tests introduced in ​http://trac.webkit.org/changeset/98805.

  • platform/chromium-cg-mac-leopard/css2.1/20110323/dynamic-top-change-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/dynamic-top-change-002-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/dynamic-top-change-003-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/dynamic-top-change-004-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-001-expected.txt: Removed.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-002-expected.txt: Removed.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-003-expected.txt: Removed.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-004-expected.txt: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/dynamic-top-change-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/dynamic-top-change-002-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/dynamic-top-change-003-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/dynamic-top-change-004-expected.png: Added.
  • platform/chromium-win-vista/css2.1: Removed.
  • platform/chromium-win/css2.1/20110323/dynamic-top-change-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/dynamic-top-change-001-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/dynamic-top-change-002-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/dynamic-top-change-002-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/dynamic-top-change-003-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/dynamic-top-change-003-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/dynamic-top-change-004-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/dynamic-top-change-004-expected.txt: Added.
  • platform/chromium/css2.1/20110323/dynamic-top-change-001-expected.png: Added.
  • platform/chromium/css2.1/20110323/dynamic-top-change-002-expected.png: Added.
  • platform/chromium/css2.1/20110323/dynamic-top-change-003-expected.png: Added.
  • platform/chromium/css2.1/20110323/dynamic-top-change-004-expected.png: Added.
11:29 AM Changeset in webkit [98810] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Update results after ​http://trac.webkit.org/changeset/98794 to remove
0x0 DIV from the render tree.

  • platform/chromium-win/editing/pasteboard/5134759-expected.txt:
11:26 AM Changeset in webkit [98809] by abarth@webkit.org
  • 1 edit
    1 add
    1 delete in trunk/LayoutTests

Update line number in baseline.

  • platform/chromium-linux-x86/fast/dom: Removed.
  • platform/chromium/fast/dom/nested-script-exceptions-expected.txt: Added.
10:28 AM Changeset in webkit [98808] by robert@webkit.org
  • 1 edit
    12 adds in trunk/LayoutTests

Platform-specific results for r98805

Unreviewed, add new results.

  • platform/gtk/css2.1/20110323/dynamic-top-change-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/dynamic-top-change-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/dynamic-top-change-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/dynamic-top-change-004-expected.txt: Added.
  • platform/mac/css2.1/20110323/dynamic-top-change-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/dynamic-top-change-002-expected.txt: Added.
  • platform/mac/css2.1/20110323/dynamic-top-change-003-expected.txt: Added.
  • platform/mac/css2.1/20110323/dynamic-top-change-004-expected.txt: Added.
  • platform/qt/css2.1/20110323/dynamic-top-change-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/dynamic-top-change-002-expected.txt: Added.
  • platform/qt/css2.1/20110323/dynamic-top-change-003-expected.txt: Added.
  • platform/qt/css2.1/20110323/dynamic-top-change-004-expected.txt: Added.
9:52 AM Changeset in webkit [98807] by annacc@chromium.org
  • 4 edits
    2 adds in trunk

Make sure TextTracks are destructed if HTMLMediaElement goes away.
​https://bugs.webkit.org/show_bug.cgi?id=71148

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/track-text-track-destructor-crash.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement):

Destroy the client (this) on TextTracks.

(WebCore::HTMLMediaElement::loadTextTracks):

Move TextTrack creation to loadNextTextTrack.

(WebCore::HTMLMediaElement::loadNextTextTrack):

Keep track of new TextTrack in a list.

(WebCore::HTMLMediaElement::addTrack):

Keep track of new TextTrack in a list.

  • html/HTMLMediaElement.h:

Add m_textTracks and loadNextTextTrack().

LayoutTests:

  • media/track/track-text-track-destructor-crash-expected.txt: Added.
  • media/track/track-text-track-destructor-crash.html: Added.
9:18 AM Changeset in webkit [98806] by jochen@chromium.org
  • 23 edits
    4 adds in trunk

Implement IDBFactory.deleteDatabase
​https://bugs.webkit.org/show_bug.cgi?id=62622

Reviewed by Tony Chang.

Source/WebCore:

Tests: storage/indexeddb/factory-deletedatabase-interactions.html

storage/indexeddb/factory-deletedatabase.html

  • storage/IDBBackingStore.h:
  • storage/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::PendingDeleteCall::create):
(WebCore::IDBDatabaseBackendImpl::PendingDeleteCall::callbacks):
(WebCore::IDBDatabaseBackendImpl::PendingDeleteCall::PendingDeleteCall):
(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::openInternal):
(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::openConnection):
(WebCore::IDBDatabaseBackendImpl::deleteDatabase):

  • storage/IDBDatabaseBackendImpl.h:
  • storage/IDBFactory.cpp:

(WebCore::IDBFactory::deleteDatabase):

  • storage/IDBFactory.h:
  • storage/IDBFactory.idl:
  • storage/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::deleteDatabase):

  • storage/IDBFactoryBackendImpl.h:
  • storage/IDBFactoryBackendInterface.h:
  • storage/IDBLevelDBBackingStore.cpp:

(WebCore::deleteRange):
(WebCore::IDBLevelDBBackingStore::deleteDatabase):

  • storage/IDBLevelDBBackingStore.h:
  • storage/IDBRequest.cpp:

(WebCore::IDBRequest::dispatchEvent):

Source/WebKit/chromium:

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::deleteDatabase):

  • src/IDBFactoryBackendProxy.h:
  • src/WebIDBFactoryImpl.cpp:

(WebKit::WebIDBFactoryImpl::getDatabaseNames):
(WebKit::WebIDBFactoryImpl::open):
(WebKit::WebIDBFactoryImpl::deleteDatabase):

  • src/WebIDBFactoryImpl.h:

LayoutTests:

  • storage/indexeddb/factory-basics-expected.txt: Updated.
  • storage/indexeddb/factory-basics.html: Updated.
  • storage/indexeddb/factory-deletedatabase-expected.txt: Added.
  • storage/indexeddb/factory-deletedatabase-interactions-expected.txt: Added.
  • storage/indexeddb/factory-deletedatabase-interactions.html: Added.
  • storage/indexeddb/factory-deletedatabase.html: Added.
  • storage/indexeddb/open-close-version-expected.txt: Updated.
  • storage/indexeddb/open-close-version.html: Updated.
7:52 AM Changeset in webkit [98805] by robert@webkit.org
  • 7 edits
    12 adds in trunk

CSS 2.1 failure: dynamic-top-change-001 to 004 fail
​https://bugs.webkit.org/show_bug.cgi?id=68149

Reviewed by David Hyatt.

Source/WebCore:

In these tests a child inherits its top value from its parent and the parent's top value
is later updated by an onload event. The updated value is expected to cascade to the child.

The tests were failing because updating the value did not cascade immediately to the child inheriting it, though
it could be forced eventually with a full recalculation of the RenderStyle by changing the zoom factor
or opening the inspector.

The fix is to let the parent RenderStyle know that a child inherits a property explicitly and
recalculate children's style if the parent ever changes. This only happens if the property is inherited
explicitly, it does not apply to cases where the property is inherited by default.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • dom/Node.cpp:

(WebCore::Node::diff):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::setHasExplicitlyInheritedProperties):
(WebCore::InheritedFlags::hasExplicitlyInheritedProperties):

LayoutTests:

  • css2.1/20110323/dynamic-top-change-001.htm: Added.
  • css2.1/20110323/dynamic-top-change-002.htm: Added.
  • css2.1/20110323/dynamic-top-change-003.htm: Added.
  • css2.1/20110323/dynamic-top-change-004.htm: Added.
  • fast/table/border-collapsing/cached-change-tbody-border-color-expected.png: See ​https://bugs.webkit.org/show_bug.cgi?id=68149#c15
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-001-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-002-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-002-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-003-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-003-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-004-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-004-expected.txt: Added.
7:45 AM Changeset in webkit [98804] by kbalazs@webkit.org
  • 2 edits in trunk/Tools

new-run-webkit-tests: MASTER BUG: Switch all webkit.org bots over
​https://bugs.webkit.org/show_bug.cgi?id=34984

Patch by Eric Seidel <​eric@webkit.org> on 2011-10-29
Reviewed by Adam Barth.

Move run-webkit-tests from using a white-list of supported NRWT ports
to a blacklist of ports requiring ORWT.

I've also added the ability to opt-in to parallel testing on a per-port basis.

With these changes I'm going to officially declare this bug dead and
work on remaining polish issues and individual developer complaints.

  • Scripts/run-webkit-tests:

(useNewRunWebKitTests):
(platformIsReadyForParallelTesting):

2:36 AM Changeset in webkit [98803] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Tighten font change conditions in matched declaration cache
​https://bugs.webkit.org/show_bug.cgi?id=71026

Reviewed by Darin Adler.

We currently test if font description has changed to see if all properties need to be applied. However
only a few size related metrics can actually affect other properties. We can just test those, making
the cache somewhat more effective while also making the equality test faster.

  • css/CSSStyleSelector.cpp:

(WebCore::fontDifferenceAffectsNonInherited):
(WebCore::CSSStyleSelector::applyMatchedDeclarations):

Test for text computedSize, xHeight and orientation only. Other text properties don't affect computed
values of non-text CSS properties.

2:10 AM Changeset in webkit [98802] by abarth@webkit.org
  • 6 edits in trunk/Source/WebCore

DOMURL should keep its own state rather than storing it on ScriptExecutionContext
​https://bugs.webkit.org/show_bug.cgi?id=71169

Reviewed by Eric Seidel.

This patch untwists this code. I think this code was originally
twisted because these APIs moved onto DOMURL after they were first
implemented.

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::~ScriptExecutionContext):

  • dom/ScriptExecutionContext.h:
  • fileapi/FileWriter.h:
  • html/DOMURL.cpp:

(WebCore::DOMURL::contextDestroyed):
(WebCore::DOMURL::createObjectURL):
(WebCore::DOMURL::revokeObjectURL):

  • html/DOMURL.h:
1:21 AM Changeset in webkit [98801] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r98780.
​http://trac.webkit.org/changeset/98780
​https://bugs.webkit.org/show_bug.cgi?id=71173

Broke Qt bots (Requested by rniwa on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-29

  • Scripts/run-webkit-tests:

(useNewRunWebKitTests):

12:58 AM Changeset in webkit [98800] by Antti Koivisto
  • 1 edit
    2 adds in trunk/LayoutTests

REGRESSION(r98542): tables/mozilla_expected_failures/bugs/bug14007-2.html
​https://bugs.webkit.org/show_bug.cgi?id=71032

Reviewed by Ryosuke Niwa.

In an effort to gain Hyatt points, add a less obscure test for this case.

  • fast/css/inherited-properties-explicit-expected.txt: Added.
  • fast/css/inherited-properties-explicit.html: Added.
12:19 AM Changeset in webkit [98799] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Unreviewed, rolling out r98795.
​http://trac.webkit.org/changeset/98795
​https://bugs.webkit.org/show_bug.cgi?id=71171

Causes worker tests to crash (Requested by abarth on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-29

  • dom/ActiveDOMObject.cpp:

(WebCore::ContextDestructionObserver::contextDestroyed):

  • dom/MessagePort.cpp:

(WebCore::MessagePort::MessagePort):
(WebCore::MessagePort::contextDestroyed):

  • dom/MessagePort.h:
  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::closeMessagePorts):

12:04 AM Changeset in webkit [98798] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

Mac rebaseline after r98617.

  • platform/mac/canvas/philip/tests/2d.imageData.put.wrongtype-expected.txt:
  • platform/mac/canvas/philip/tests/2d.missingargs-expected.txt:

Oct 28, 2011:

11:41 PM Changeset in webkit [98797] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Rebaseline after r98775.

  • fast/css/getComputedStyle/computed-style-cross-fade-expected.txt:
11:31 PM Changeset in webkit [98796] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Potential crash in ReplaceNodeWithSpanCommand
​https://bugs.webkit.org/show_bug.cgi?id=71145

Reviewed by Ojan Vafai.

Fix a potential crash without tests because we don't have a reduction.

  • editing/ReplaceNodeWithSpanCommand.cpp:

(WebCore::swapInNodePreservingAttributesAndChildren):

10:51 PM Changeset in webkit [98795] by abarth@webkit.org
  • 5 edits in trunk/Source/WebCore

MessagePort should be a ContextDestructionObserver
​https://bugs.webkit.org/show_bug.cgi?id=71167

Reviewed by Eric Seidel.

I couldn't quite get rid of all the uses of the
ScriptExecutionContext::m_messagePorts in this patch. I hope to get
rid of them in the future as the "extra data" design for
ScriptExecutionContext emerges.

  • dom/ActiveDOMObject.cpp:

(WebCore::ContextDestructionObserver::contextDestroyed):

  • dom/MessagePort.cpp:

(WebCore::MessagePort::MessagePort):
(WebCore::MessagePort::contextDestroyed):

  • dom/MessagePort.h:
  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::closeMessagePorts):

10:27 PM Changeset in webkit [98794] by rniwa@webkit.org
  • 10 edits
    2 adds in trunk

The copy and paste result in nested scrollbars on ​http://dojotoolkit.org/widgets
​https://bugs.webkit.org/show_bug.cgi?id=70799

Reviewed by Enrica Casucci.

Source/WebCore:

The bug was caused by WebKit's treating a fully selected root with background property as a special common ancestor.
A variant of this bug was caused by treating any element with text-decoration property as a presentational element.

Fixed the above two bugs by not serializing the said nodes. The effective background color was already serialized
by wrappingStyleForSerialization, there was nothing to be done besides stop including it in highestAncestorToWrapMarkup.

For text-decoration property, added the logic to compute the effective value in EditingStyle::init. Also treat it
as a non-inheritable editing property so that the rest of EditingStyle just works.

Test: editing/pasteboard/avoid-copying-body-with-background.html

  • editing/EditingStyle.cpp: Added CSSPropertyTextDecoration to the list of editing properties.

(WebCore::copyEditingProperties):
(WebCore::EditingStyle::init): Compute the effective text decoration when propertiesToInclude is
EditingPropertiesInEffect.
(WebCore::EditingStyle::prepareToApplyAt):
(WebCore::EditingStyle::mergeInlineStyleOfElement):
(WebCore::EditingStyle::wrappingStyleForSerialization):
(WebCore::EditingStyle::removeStyleFromRulesAndContext):

  • editing/EditingStyle.h: Renamed EditingInheritablePropertiesAndBackgroundColorInEffect to

EditingPropertiesInEffect.

  • editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag): Removed an assertion that's no longer valid.
(WebCore::isElementPresentational): Don't consider an element with text-decoration as a presentational element.
(WebCore::highestAncestorToWrapMarkup): Don't consider fully selected root as a special common ancestor ever.
Background color is computed property when we compute the wrapping style.
(WebCore::createMarkup):

LayoutTests:

Added a test to copy contents inside a body with background and text-decoration properties.

WebKit should not copy body element.

  • editing/deleting/delete-line-break-before-underlined-content-expected.txt: an erroneous inline div

is replaced by a span.

  • editing/deleting/deleting-line-break-preserves-underline-color-expected.txt: two style spans are

merged into one.

  • editing/pasteboard/19644-2-expected.txt: div is replaced by span. This is okay because it's the only

content in the body. Even though we now only put the gray background under text as inline style as
opposed to apply at the block level, that's what execCommand('BackColor'...) does and what user expects.

  • editing/pasteboard/avoid-copying-body-with-background-expected.txt: Added.
  • editing/pasteboard/avoid-copying-body-with-background.html: Added.
  • editing/pasteboard/preserve-underline-color-expected.txt:
  • platform/mac/editing/pasteboard/5134759-expected.txt:
6:56 PM Changeset in webkit [98793] by abarth@webkit.org
  • 9 edits
    2 moves in trunk

Rename ExceptionCodeDescription.in to DOMExceptions.in
​https://bugs.webkit.org/show_bug.cgi?id=71157

Reviewed by Eric Seidel.

.:

  • Source/cmake/WebKitMacros.cmake:

Source/WebCore:

This file is now used for more than just the descriptions of the exceptions.

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/action_makenames.py:
  • dom/DOMExceptions.in: Copied from Source/WebCore/dom/ExceptionCodeDescription.in.
  • dom/ExceptionCodeDescription.in: Removed.
  • dom/make_dom_exceptions.pl: Copied from Source/WebCore/dom/make_exception_code_description.pl.
  • dom/make_exception_code_description.pl: Removed.
6:47 PM Changeset in webkit [98792] by crogers@google.com
  • 3 edits in trunk/Source/WebCore

SincResampler must be able to resample progressively
​https://bugs.webkit.org/show_bug.cgi?id=71131

Reviewed by Kenneth Russell.

No new tests. There is not yet an implementation using progressive resampling to test.

  • platform/audio/SincResampler.cpp:

(WebCore::SincResampler::SincResampler):
(WebCore::SincResampler::consumeSource):
(WebCore::SincResampler::process):

  • platform/audio/SincResampler.h:
6:31 PM Changeset in webkit [98791] by adamk@chromium.org
  • 7 edits in trunk

[MutationObservers] Support attributeOldValue for attribute mutations
​https://bugs.webkit.org/show_bug.cgi?id=70861

Reviewed by Ryosuke Niwa.

Source/WebCore:

Respect 'attributeOldValue' when passed to WebKitMutationObserver.observe().

If multiple observers have different attributeOldValue settings in
their registrations, two different MutationRecords are created (one is
a wrapper around the other).

If a single observer has multiple registrations that apply to a single
mutation, and those registrations have different values for
attributeOldValue, the observer is passed the oldValue.

  • dom/Element.cpp:

(WebCore::hasOldValue):
(WebCore::enqueueAttributesMutationRecord):
(WebCore::Element::setAttribute):

  • dom/MutationRecord.cpp:

(WebCore::MutationRecord::createAttributes):
(WebCore::MutationRecord::createWithNullOldValue):

  • dom/MutationRecord.h:

(WebCore::MutationRecord::oldValue):

LayoutTests:

Added test cases for attributeOldValue to existing tests.

  • fast/mutation/observe-attributes-expected.txt:
  • fast/mutation/observe-attributes.html:
6:14 PM Changeset in webkit [98790] by abarth@webkit.org
  • 8 edits
    1 delete in trunk/Source/WebCore

Delete ExceptionCode.cpp, which is empty
​https://bugs.webkit.org/show_bug.cgi?id=71159

Reviewed by Eric Seidel.

This file has been stripped down to nothing and can be removed.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/ExceptionCode.cpp: Removed.
5:51 PM Changeset in webkit [98789] by commit-queue@webkit.org
  • 6 edits
    3 deletes in trunk

Unreviewed, rolling out r98776.
​http://trac.webkit.org/changeset/98776
​https://bugs.webkit.org/show_bug.cgi?id=71164

caused lots of test crashes (Requested by smfr on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-28

Source/WebCore:

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateVisibilityStatus):
(WebCore::RenderLayer::dirtyZOrderLists):

  • rendering/RenderLayer.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::enableCompositingMode):

LayoutTests:

  • animations/resources/animation-test-helpers.js:

(checkExpectedValue):

  • compositing/visibility/animation-visibility-expected.png: Removed.
  • compositing/visibility/animation-visibility-expected.txt: Removed.
  • compositing/visibility/animation-visibility.html: Removed.
5:32 PM Changeset in webkit [98788] by sullivan@apple.com
  • 2 edits in trunk/Source/WebCore

Improvement to the fix for:
​https://bugs.webkit.org/show_bug.cgi?id=71142
Whether backspace goes Back should be configurable

Reviewed by Dan Bernstein.

  • page/EventHandler.cpp:

(WebCore::EventHandler::defaultBackspaceEventHandler):
Do the frame->settings() check after the !page check, since
a null page means null settings.

5:30 PM Changeset in webkit [98787] by abarth@webkit.org
  • 6 edits in trunk/Source/WebCore

Make DOMURL a ContextDestructionObserver
​https://bugs.webkit.org/show_bug.cgi?id=71162

Reviewed by Eric Seidel.

This removes a bunch of hand-rolled ifdefed code.

  • dom/ActiveDOMObject.h:
    • One-argument constructors should be explicit.
  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::~ScriptExecutionContext):

  • dom/ScriptExecutionContext.h:
  • html/DOMURL.cpp:

(WebCore::DOMURL::DOMURL):
(WebCore::DOMURL::~DOMURL):

  • html/DOMURL.h:
5:10 PM Changeset in webkit [98786] by dino@apple.com
  • 1 edit
    1 delete in trunk/Websites/webkit.org

Remove this horribly outdated file. It was showing up in
Google searches and shouldn't be used as official
documentation.

Rubber-stamped by Simon Fraser.

  • specs/MediaQueriesExtensions.html: Removed.
5:03 PM Changeset in webkit [98785] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

webkit.py gdb visualizer is broken after change to StringImpl
​https://bugs.webkit.org/show_bug.cgi?id=71154

Patch by Rafael Weinstein <​rafaelw@chromium.org> on 2011-10-28
Reviewed by Tony Chang.

r98624 changed StringImpl m_data to m_data32. This changes updates
webkit.py to match.

  • gdb/webkit.py:
4:57 PM Changeset in webkit [98784] by abarth@webkit.org
  • 5 edits in trunk/Source/WebCore

Factor ContextDestructionObserver out of ActiveDOMObject
​https://bugs.webkit.org/show_bug.cgi?id=71153

Reviewed by Sam Weinig.

This patch paves the way to make more objects observe the destruction
of ScriptExecutioContext without needing to add ifdefs to
ScriptExecutionContext.h/cpp. (As an example, see DOMURL.)

  • dom/ActiveDOMObject.cpp:

(WebCore::ContextDestructionObserver::ContextDestructionObserver):
(WebCore::ContextDestructionObserver::~ContextDestructionObserver):
(WebCore::ContextDestructionObserver::contextDestroyed):
(WebCore::ActiveDOMObject::ActiveDOMObject):
(WebCore::ActiveDOMObject::~ActiveDOMObject):

  • dom/ActiveDOMObject.h:

(WebCore::ContextDestructionObserver::scriptExecutionContext):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::didCreateActiveDOMObject):
(WebCore::ScriptExecutionContext::willDestroyActiveDOMObject):
(WebCore::didCreateDestructionObserver):
(WebCore::willDestroyDestructionObserver):

  • dom/ScriptExecutionContext.h:
4:51 PM Changeset in webkit [98783] by Joseph Pecoraro
  • 2 edits in trunk/Tools

<​http://webkit.org/b/71144> Fix typo in check-for-inappropriate-objc-class-names

Reviewed by Dan Bernstein.

  • Scripts/check-for-inappropriate-objc-class-names:
4:44 PM Changeset in webkit [98782] by commit-queue@webkit.org
  • 10 edits
    3 adds in trunk

Add support for sending scroll-update events from EventSender.
​https://bugs.webkit.org/show_bug.cgi?id=66272

Patch by Sadrul Habib Chowdhury <​sadrul@chromium.org> on 2011-10-28
Reviewed by Adam Barth.

Source/WebKit/chromium:

  • public/WebInputEvent.h:

(WebKit::WebGestureEvent::WebGestureEvent):

  • src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleInputEvent):

Tools:

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::EventSender):
(EventSender::reset):
(EventSender::gestureScrollUpdate):
(EventSender::gestureEvent):

  • DumpRenderTree/chromium/EventSender.h:

LayoutTests:

  • fast/events/touch/gesture/gesture-scroll-expected.txt: Added.
  • fast/events/touch/gesture/gesture-scroll.html: Added.
  • platform/chromium/fast/events/touch/gesture/gesture-scroll-expected.txt: Added.
  • platform/qt/Skipped:
4:35 PM Changeset in webkit [98781] by jeffm@apple.com
  • 2 edits in trunk/Source/WebKit2

More work on WebKit2 should respect WebKitOmitPDFSupport preference on the Mac
​https://bugs.webkit.org/show_bug.cgi?id=71156

Don't include PDF and PostScript types in the set of MIME types with custom representations
when initializing the web process if WebKitOmitPDFSupport is set.

I believe the previous patch r98513 was actually sufficient to prevent PDFs from being
shown inline when this preference was set, but to be complete we should exclude the MIME
types here as well.

Reviewed by Alexey Proskuryakov.

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess):

4:31 PM Changeset in webkit [98780] by eric@webkit.org
  • 2 edits in trunk/Tools

new-run-webkit-tests: MASTER BUG: Switch all webkit.org bots over
​https://bugs.webkit.org/show_bug.cgi?id=34984

Reviewed by Adam Barth.

Move run-webkit-tests from using a white-list of supported NRWT ports
to a blacklist of ports requiring ORWT.

I've also added the ability to opt-in to parallel testing on a per-port basis.

With these changes I'm going to officially declare this bug dead and
work on remaining polish issues and individual developer complaints.

  • Scripts/run-webkit-tests:

(useNewRunWebKitTests):
(platformIsReadyForParallelTesting):

4:31 PM Changeset in webkit [98779] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

One more unreviewed build fix due to r98775.

No new tests.

  • WebCore.vcproj/WebCore.vcproj:
4:30 PM Changeset in webkit [98778] by jamesr@google.com
  • 11 edits in trunk/Source

[chromium] Track wheel event handler registration and pass to input filter
​https://bugs.webkit.org/show_bug.cgi?id=71078

Reviewed by Kenneth Russell.

Source/WebCore:

This propagates mouse wheel registration notifications to the compositor input filter. If there are any handlers
registered, which includes JS handlers and scrollable areas other than the main view, the input filter will pass
mouse wheel events to the widget. Otherwise when threaded compositing is enabled the input filter translates
wheel events into root layer scrolling.

Only changes behavior with an off-by-default flag enabled, so no tests.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::setHaveWheelEventHandlers):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::haveWheelEventHandlers):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore::CCLayerTreeHostImpl::setHaveWheelEventHandlers):

  • platform/graphics/chromium/cc/CCScrollController.h:

Source/WebKit/chromium:

Pushes mouse wheel event handler notifications to CCLayerTreeHost when compositing.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::numWheelEventHandlersChanged):

  • src/WebCompositorImpl.cpp:

(WebKit::WebCompositorImpl::handleInputEvent):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::numberOfWheelEventHandlersChanged):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • src/WebViewImpl.h:
4:27 PM Changeset in webkit [98777] by timothy_horton@apple.com
  • 5 edits in trunk/Source/WebCore

Unreviewed build fix due to r98775.

No new tests.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
4:18 PM Changeset in webkit [98776] by Simon Fraser
  • 6 edits
    3 adds in trunk

If visibility changes while an accelerated animation is running, element jumps around
​https://bugs.webkit.org/show_bug.cgi?id=29984

Source/WebCore:

Reviewed by Chris Marrin.

Compositing now affects whether RenderLayers for visibility:hidden elements
are included in z-order lists. So we have to dirty those lists when we enter
compopsiting mode.

Test: compositing/visibility/animation-visibility.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateVisibilityStatus): Removed trailing whitespace.
(WebCore::RenderLayer::dirtyZOrderLists): Call dirtyZOrderListsInternal(), which doesn't have
to ping the compositor.
(WebCore::RenderLayer::dirtyZOrderListsInternal):
(WebCore::RenderLayer::dirtyZOrderListsIncludingDescendants): Recursively dirty z-order
lists.

  • rendering/RenderLayer.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::enableCompositingMode): When going into compositing mode,
dirty all z-order lists.

LayoutTests:

Reviewed by Chris Marrin.

Add testcase for visibility changing in the middle of an accelerated animation.

  • animations/resources/animation-test-helpers.js: Add some constants for readability.

(checkExpectedValue): Add support for testing 'visibility'.

  • compositing/visibility/animation-visibility-expected.png: Added.
  • compositing/visibility/animation-visibility-expected.txt: Added.
  • compositing/visibility/animation-visibility.html: Added.
4:08 PM Changeset in webkit [98775] by timothy_horton@apple.com
  • 5 edits
    4 adds in trunk

Implement CSS3 Images cross-fade() image function
​https://bugs.webkit.org/show_bug.cgi?id=52162
<rdar://problem/10209254>

Reviewed by Simon Fraser.

Parse -webkit-cross-fade according to the CSS3 Images Values specification.

Also, adjust other CSS parsing functions to support nested functions, by using a specific CSS value list
instead of the global one. This allows - for example - cross-fade to pass each of its arguments back into
parseFillImage and to successfully parse image functions in this fashion.

Test: fast/css/getComputedStyle/computed-style-cross-fade.html

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSCrossfadeValue.cpp: Added.

(WebCore::CSSCrossfadeValue::~CSSCrossfadeValue):
(WebCore::CSSCrossfadeValue::cssText):
(WebCore::CSSCrossfadeValue::fixedSize):
(WebCore::CSSCrossfadeValue::image):

  • css/CSSCrossfadeValue.h: Added.

(WebCore::CSSCrossfadeValue::create):
(WebCore::CSSCrossfadeValue::isFixedSize):
(WebCore::CSSCrossfadeValue::setFromImage):
(WebCore::CSSCrossfadeValue::setToImage):
(WebCore::CSSCrossfadeValue::setPercentage):
(WebCore::CSSCrossfadeValue::CSSCrossfadeValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseFillImage):
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseDeprecatedGradient):
(WebCore::CSSParser::parseLinearGradient):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::isGeneratedImageValue):
(WebCore::CSSParser::parseGeneratedImage):
(WebCore::CSSParser::parseCrossfade):
(WebCore::CSSParser::parseCanvas):

  • css/CSSParser.h:

Add tests to ensure that -webkit-cross-fade is parsed correctly.

  • fast/css/getComputedStyle/computed-style-cross-fade-expected.txt: Added.
  • fast/css/getComputedStyle/computed-style-cross-fade.html: Added.
4:06 PM Changeset in webkit [98774] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Attempted build fix after r98765.

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformWidthForGlyph):

3:55 PM Changeset in webkit [98773] by cmarrin@apple.com
  • 10 edits in trunk

CSS grammar doesn't support functions with no parameters
​https://bugs.webkit.org/show_bug.cgi?id=69110

Reviewed by Dean Jackson.

Source/WebCore:

Add rule to grammar to accept functions with 0 args and return
this case with a CSSParserValueList with 0 values. Also fixed
filter creation function to properly handle filters with 0
arguments.

  • css/CSSGrammar.y:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::createFilterOperations):

LayoutTests:

Updated tests to include tests for allowing 0 argument functions and for
disallowing functions with trailing commas (to pickup a couple of theses
cases not in the current tests). Also fixed one typo.

  • css3/filters/filter-property-computed-style-expected.txt:
  • css3/filters/filter-property-parsing-expected.txt:
  • css3/filters/filter-property-parsing-invalid-expected.txt:
  • css3/filters/script-tests/filter-property-computed-style.js:
  • css3/filters/script-tests/filter-property-parsing-invalid.js:
  • css3/filters/script-tests/filter-property-parsing.js:

(testFilterRule):

3:35 PM Changeset in webkit [98772] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp

Fixing fast/flexbox/flex-hang. Had used an int instead of a LayoutUnit.

3:34 PM Changeset in webkit [98771] by johnnyg@google.com
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r98757.
​http://trac.webkit.org/changeset/98757
​https://bugs.webkit.org/show_bug.cgi?id=71150

crashes webkit_unit_tests on chromium windows (Requested by
johnny_g on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-28

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsAndVisibilityInternal):

3:21 PM Changeset in webkit [98770] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Rubber-stamped by Eric Seidel.

Fix namespace indent in ScriptExecutionContext.h.

  • dom/ScriptExecutionContext.h:

(WebCore::ScriptExecutionContext::isDocument):
(WebCore::ScriptExecutionContext::isWorkerContext):
(WebCore::ScriptExecutionContext::setHasOpenDatabases):
(WebCore::ScriptExecutionContext::hasOpenDatabases):
(WebCore::ScriptExecutionContext::url):
(WebCore::ScriptExecutionContext::completeURL):
(WebCore::ScriptExecutionContext::securityOrigin):
(WebCore::ScriptExecutionContext::contentSecurityPolicy):
(WebCore::ScriptExecutionContext::activeDOMObjects):
(WebCore::ScriptExecutionContext::suspendScriptedAnimationControllerCallbacks):
(WebCore::ScriptExecutionContext::resumeScriptedAnimationControllerCallbacks):
(WebCore::ScriptExecutionContext::messagePorts):
(WebCore::ScriptExecutionContext::domUrls):
(WebCore::ScriptExecutionContext::ref):
(WebCore::ScriptExecutionContext::deref):
(WebCore::ScriptExecutionContext::Task::Task):
(WebCore::ScriptExecutionContext::Task::isCleanupTask):

3:07 PM Changeset in webkit [98769] by sullivan@apple.com
  • 15 edits in trunk/Source

Source/WebCore: WebCore part of:
​https://bugs.webkit.org/show_bug.cgi?id=71142
Whether backspace goes Back should be configurable

Reviewed by Sam Weinig.

  • page/EventHandler.cpp:

(WebCore::EventHandler::defaultBackspaceEventHandler):
Bail out if backspace navigation is not enabled.

  • page/Settings.cpp:

(WebCore::Settings::Settings):
Initialize m_backspaceKeyNavigationEnabled to true to match current behavior.

  • page/Settings.h:

Declared m_backspaceKeyNavigationEnabled.
(WebCore::Settings::setBackspaceKeyNavigationEnabled):
New function, simple setter.
(WebCore::Settings::backspaceKeyNavigationEnabled):
New function, simple getter.

Source/WebKit/mac: WebKit part of:
​https://bugs.webkit.org/show_bug.cgi?id=71142
Whether backspace goes Back should be configurable

Reviewed by Sam Weinig.

  • WebView/WebFrameView.mm:

(-[WebFrameView keyDown:]):
Honor the new preference.

  • WebView/WebPreferenceKeysPrivate.h:

Added #define for WebKitBackspaceKeyNavigationEnabledKey

  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
Initialize new pref to YES, to match current behavior.
(-[WebPreferences setBackspaceKeyNavigationEnabled:]):
New method, standard prefs setter.
(-[WebPreferences backspaceKeyNavigationEnabled]):
New method, standard prefs getter.

  • WebView/WebPreferencesPrivate.h:

Declared new methods.

  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):
Updates WebCore settings from WebKit prefs.

Source/WebKit2: WebKit2 part of:
​https://bugs.webkit.org/show_bug.cgi?id=71142
Whether backspace goes Back should be configurable

Reviewed by Sam Weinig.

  • Shared/WebPreferencesStore.h:

Declared backspaceKeyNavigationEnabled property using macro. This initializes
it to true, to match current behavior.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetBackspaceKeyNavigationEnabled):
New function, pass value to impl.
(WKPreferencesGetBackspaceKeyNavigationEnabled):
New function, returns result from impl.

  • UIProcess/API/C/WKPreferences.h:

Declared API functions for new preference.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
Updates WebCore settings from WebKit2 prefs.

2:55 PM Changeset in webkit [98768] by johnnyg@google.com
  • 5 edits
    5 adds
    9 deletes in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/dom: Removed.
  • platform/chromium-cg-mac/fast/dom/nested-script-exceptions-expected.txt: Removed.
  • platform/chromium-cg-mac/svg/hixie/perf: Removed.
  • platform/chromium-cg-mac/svg/hixie/perf/001-expected.png: Removed.
  • platform/chromium-gpu-mac/compositing/visibility: Added.
  • platform/chromium-gpu-mac/compositing/visibility/visibility-image-layers-expected.png: Added.
  • platform/chromium-gpu-win/compositing/visibility: Added.
  • platform/chromium-gpu-win/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/visibility/visibility-image-layers-expected.png: Added.
  • platform/chromium-linux-x86/svg/hixie/perf/001-expected.png:
  • platform/chromium-linux/svg/hixie/perf/001-expected.png:
  • platform/chromium-mac-snowleopard/fast/dom: Removed.
  • platform/chromium-mac/fast/dom/nested-script-exceptions-expected.txt: Removed.
  • platform/chromium-mac/svg/hixie/perf/001-expected.png: Removed.
  • platform/chromium-mac/svg/hixie/perf/001-expected.txt: Removed.
  • platform/chromium-win-xp/svg/batik/text/textOnPath-expected.png: Removed.
  • platform/chromium-win/fast/dom/nested-script-exceptions-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
2:55 PM Changeset in webkit [98767] by eae@chromium.org
  • 13 edits in trunk/Source/WebCore

Overridden clippedOverflowRectForRepaint() still uses IntRects
​https://bugs.webkit.org/show_bug.cgi?id=71046

Reviewed by Simon Fraser.

Change all virtual clippedOverflowRectForRepaint functions to use the
same signature.

No new tests.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::rectWithOutlineForRepaint):
(WebCore::RenderObject::clippedOverflowRectForRepaint):

  • rendering/RenderObject.h:
  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::clippedOverflowRectForRepaint):

  • rendering/RenderReplaced.h:
  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::clippedOverflowRectForRepaint):

  • rendering/RenderTableCell.h:
  • rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::clippedOverflowRectForRepaint):

  • rendering/RenderTableCol.h:
  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::clippedOverflowRectForRepaint):

  • rendering/RenderTableRow.h:
  • rendering/RenderText.cpp:

(WebCore::RenderText::clippedOverflowRectForRepaint):

  • rendering/RenderText.h:
2:46 PM Changeset in webkit [98766] by adamk@chromium.org
  • 3 edits in trunk/Source/WebCore

Remove unused parsers for 'exception' and 'alias' IDL keywords
​https://bugs.webkit.org/show_bug.cgi?id=71140

Reviewed by Adam Barth.

  • bindings/scripts/IDLParser.pm:

(ParseInterface):
(DetermineParseMode):
(ProcessSection):

  • bindings/scripts/IDLStructure.pm:
2:41 PM Changeset in webkit [98765] by mitz@apple.com
  • 4 edits in trunk

<rdar://problem/10288006> Emoji characters are too close to each other in small font size

Reviewed by Sam Weinig.

Source/WebCore:

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformWidthForGlyph): If the font is a color bitmap font, use
-[NSFont advancementForGlyph:] instead of wkGetGlyphTransformedAdvances().

LayoutTests:

  • platform/mac/fast/css/font-family-pictograph-expected.txt:
2:30 PM Changeset in webkit [98764] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unused default constructor
​https://bugs.webkit.org/show_bug.cgi?id=71136

Reviewed by Eric Seidel.

No one is calling this constructor anymore now that we've fixed the
callers.

  • dom/make_exception_code_description.pl:

(generateHeader):

2:28 PM Changeset in webkit [98763] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Crash when splitting inline flows with generated floats
​https://bugs.webkit.org/show_bug.cgi?id=70458

Patch by Ken Buchanan <​kenrb@chromium.org> on 2011-10-28
Reviewed by David Hyatt.

Source/WebCore:

When lineBoxes on a RenderBlock are being deleted, we now check the floating object list to
ensure references to them are being cleared.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::deleteLineBoxTree): Remove references to lineBox when deleting them

LayoutTests:

Added test for crash condition when splitting inline flows on an object with generated floats.

  • fast/css-generated-content/inline-splitting-with-after-float-crash.html: Added
  • fast/css-generated-content/inline-splitting-with-after-float-crash-expected.txt: Added
2:26 PM Changeset in webkit [98762] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Remove Leopard-only code from GraphicsLayerCA
​https://bugs.webkit.org/show_bug.cgi?id=71141

Reviewed by Chris Marrin.

Remove !HAVE_MODERN_QUARTZCORE code, which was only
used on Leopard. updateContentsTransform() became a no-op,
so could be removed.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::getValueFunctionNameForTransformOperation):
(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::addAnimation):
(WebCore::GraphicsLayerCA::updateGeometry):
(WebCore::GraphicsLayerCA::setTransformAnimationEndpoints):
(WebCore::GraphicsLayerCA::setTransformAnimationKeyframes):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
(WebCore::GraphicsLayerCA::defaultContentsOrientation):
(WebCore::GraphicsLayerCA::updateOpacityOnLayer):

  • platform/graphics/ca/GraphicsLayerCA.h:
2:17 PM Changeset in webkit [98761] by Lucas Forschler
  • 1 copy in tags/Safari-534.52.6

New tag.

2:10 PM Writing Layout Tests for DumpRenderTree edited by jchaffraix@webkit.org
Added one more adjective to the list of good properties for a test (diff)
2:00 PM Changeset in webkit [98760] by Lucas Forschler
  • 2 edits in branches/safari-534.52-branch/Source/WebCore

Rollout 98610.

1:51 PM Changeset in webkit [98759] by timothy@apple.com
  • 12 edits in trunk/Source/WebKit2

Support using a different front-end for the Web Inspector in WebKit2.

rdar://problem/10318665
​https://webkit.org/b/71089

Reviewed by Sam Weinig.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode): Added webInspectorBasePath and webInspectorLocalizedStringsPath.
(WebKit::WebProcessCreationParameters::decode): Ditto.

  • Shared/WebProcessCreationParameters.h:
  • UIProcess/API/C/WKContext.cpp:

(WKContextSetOverrideWebInspectorBaseDirectory): Added. Calls through to WebContext.
(WKContextSetOverrideWebInspectorPagePath): Ditto.
(WKContextSetOverrideWebInspectorLocalizedStringsPath): Ditto.

  • UIProcess/API/C/WKContextPrivate.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureWebProcess): Set webInspectorBasePath and webInspectorLocalizedStringsPath.

  • UIProcess/WebContext.h:

(WebKit::WebContext::overrideWebInspectorBaseDirectory): Added.
(WebKit::WebContext::setOverrideWebInspectorBaseDirectory): Added.
(WebKit::WebContext::overrideWebInspectorPagePath): Added.
(WebKit::WebContext::setOverrideWebInspectorPagePath): Added.
(WebKit::WebContext::setOverrideWebInspectorLocalizedStringsPath): Added.

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::inspectorPageURL): Use WebContext::overrideWebInspectorPagePath if set.
(WebKit::WebInspectorProxy::inspectorBaseURL): Use WebContext::overrideWebInspectorBaseDirectory if set.

  • WebProcess/WebPage/WebInspector.h:
  • WebProcess/WebPage/mac/WebInspectorMac.mm:

(WebKit::globalInspectorLocalizedStringsURL): Added. Static storage for the setting.
(WebKit::WebInspector::setLocalizedStringsPath): Added. Set globalInspectorLocalizedStringsURL.
(WebKit::WebInspector::localizedStringsURL): Return globalInspectorLocalizedStringsURL.

  • WebProcess/com.apple.WebProcess.sb: Added read-only subpath for WEBKIT_WEB_INSPECTOR_DIR.
  • WebProcess/mac/WebProcessMac.mm:

(WebKit::appendReadonlySandboxDirectory): Check path for empty to prevent an exception when
calling through to fileSystemRepresentation.
(WebKit::initializeSandbox): Added WEBKIT_WEB_INSPECTOR_DIR parameter.
(WebKit::WebProcess::platformInitializeWebProcess): Call WebInspector::setLocalizedStringsPath.

1:46 PM Changeset in webkit [98758] by eric@webkit.org
  • 3 edits in trunk/Tools

NRWT crashes when parsing leaks output due to UTF-8 decoding error
​https://bugs.webkit.org/show_bug.cgi?id=71112

Reviewed by Adam Barth.

Use read_binary_file instead of read_text_file and add a test
case with some non-utf8 data to make sure we don't break this in the future.

  • Scripts/webkitpy/layout_tests/port/leakdetector.py:
  • Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
1:44 PM Changeset in webkit [98757] by enne@google.com
  • 4 edits in trunk/Source/WebCore

[chromium] Implicitly skip render surfaces that won't be drawn
​https://bugs.webkit.org/show_bug.cgi?id=71038

Rather than having redundant checks in three places for how to walk
through a render surface list, instead don't add render surfaces that
don't need to get rendered to the render surface list.

Reviewed by James Robinson.

Covered by existing layout tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsAndVisibilityInternal):

1:27 PM Changeset in webkit [98756] by ap@apple.com
  • 3 edits in trunk/Source/WebKit2

Clean up BuiltInPDFView a little
​https://bugs.webkit.org/show_bug.cgi?id=71133

Reviewed by Daniel Bates.

  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp: (WebKit::BuiltInPDFView::createScrollbar):

Removed an incorrect FIXME. Custom scrollbars specified in a document don't apply
to subframes, and thus shouldn't apply to PDFs.

  • WebProcess/Plugins/PDF/BuiltInPDFView.h: (WebKit::BuiltInPDFView::zoomAnimatorTransformChanged):

Moved to a correct location. This is not a Plugin method, but a ScrollView one.

1:20 PM Changeset in webkit [98755] by abarth@webkit.org
  • 15 edits in trunk/Source/WebCore

Autogenerate Exception-downcast code in bindings
​https://bugs.webkit.org/show_bug.cgi?id=71108

Reviewed by Eric Seidel.

This patch uses the same generated code style as we're using for Events
to generate the downcasts for the Exception types in the bindings.
This cause me to refactor more code from make_event_factory.pl into
InFilesCompiler.pm.

After this patch, some of these files and scripts are misnamed. I'll
rename them in a followup patch.

  • DerivedSources.make:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMBinding.cpp:

(WebCore::setDOMException):

  • bindings/objc/ExceptionHandlers.mm:

(WebCore::raiseDOMException):

  • bindings/scripts/InFilesCompiler.pm:

(initializeFromCommandLine):
(compile):
(interfaceForItem):
(toMacroStyle):
(generateInterfacesHeader):
(generateHeadersHeader):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::setDOMException):

  • dom/ExceptionCodeDescription.in:
  • dom/make_event_factory.pl:

(generateCode):
(generateImplementation):

  • dom/make_exception_code_description.pl:

(defaultItemFactory):
(generateCode):

1:10 PM Changeset in webkit [98754] by leviw@chromium.org
  • 3 edits in branches/subpixellayout/Source/WebCore

Build fixes for Chromium-Mac.

12:58 PM Changeset in webkit [98753] by levin@chromium.org
  • 4 edits in trunk/Tools

watchlist should not CC the bug reporter
​https://bugs.webkit.org/show_bug.cgi?id=71079

Reviewed by Adam Barth.

Tested by test_apply_watch_list_local (webkitpy.tool.steps.applywatchlist_unittest.ApplyWatchListTest)
which remains upchanged and thus verifies that the reporter doesn't get added to the cc line.

  • Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Add the new email in the output.
  • Scripts/webkitpy/tool/mocktool.py: Change the reporter and make them one of the people to cc.
  • Scripts/webkitpy/tool/steps/applywatchlist.py: Remove the reporter from the cc list.
12:42 PM Changeset in webkit [98752] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Fix builds which have ACCELERATED_COMPOSITING disabled.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateZOrderLists):

12:36 PM Changeset in webkit [98751] by johnnyg@google.com
  • 16 edits
    11 adds
    13 deletes in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium-cg-mac-leopard/fast/css/child-style-can-override-visited-style-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fullscreen/parent-flow-inline-with-block-child-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/fullscreen/full-screen-render-inline-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/svg/hixie: Added.
  • platform/chromium-cg-mac-snowleopard/svg/hixie/perf: Added.
  • platform/chromium-cg-mac-snowleopard/svg/hixie/perf/002-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-cg-mac/svg/hixie/perf/002-expected.png: Removed.
  • platform/chromium-linux-x86/svg/hixie/perf/002-expected.png:
  • platform/chromium-linux/svg/hixie/perf/002-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
  • platform/chromium-mac-snowleopard/fast/backgrounds/background-leakage-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/background-leakage-transforms-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDashed06-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/emphasis-overlap-expected.png:
  • platform/chromium-mac-snowleopard/fullscreen/full-screen-render-inline-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fullscreen/parent-flow-inline-with-block-child-expected.png: Removed.
  • platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textOnPath-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/perf: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-mac/svg/batik/text/textOnPath-expected.png: Removed.
  • platform/chromium-mac/svg/hixie/perf/002-expected.png: Removed.
  • platform/chromium-mac/svg/hixie/perf/002-expected.txt: Removed.
  • platform/chromium-win-vista/svg/batik/text: Removed.
  • platform/chromium-win-xp/svg/batik/text/textOnPath-expected.png: Added.
  • platform/chromium-win/svg/batik/text/textOnPath-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
  • platform/chromium/fast/js/array-prototype-properties-expected.txt: Replaced.
  • platform/chromium/fast/js/exception-sequencing-binops2-expected.txt: Removed.
  • platform/chromium/fast/js/kde/RegExp-expected.txt: Removed.
  • platform/chromium/fast/js/regexp-caching-expected.txt: Removed.
  • platform/chromium/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
12:29 PM Changeset in webkit [98750] by arv@chromium.org
  • 4 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from inspector IDLs
​https://bugs.webkit.org/show_bug.cgi?id=65748

Reviewed by Adam Barth.

Covered by existing tests.

  • inspector/InjectedScriptHost.idl:
  • inspector/InspectorFrontendHost.idl:
  • inspector/JavaScriptCallFrame.idl:
12:22 PM Changeset in webkit [98749] by commit-queue@webkit.org
  • 6 edits
    4 adds in trunk

IndexedDB: Database metadata changes should be tied to transaction
​https://bugs.webkit.org/show_bug.cgi?id=70974

Patch by Joshua Bell <​jsbell@chromium.org> on 2011-10-28
Reviewed by Tony Chang.

Source/WebCore:

Database metadata (that is, the version string) was rolled back
on abort by an abort task. If the abort task didn't run e.g.
due to a crash, the metadata would not be reverted. All of the
other store/index/data changes were written into the transaction
itself, so the metadata now is too. Refactored the metadata
get/create/update methods for clarity as well.

Note that the new tests don't actually verify that the code handles
this case; that will need to be done with persistence tests
that span multiple runs of the browser and induce crashes.
The new tests do verify that these changes don't cause regressions
not caught by other tests.

Tests: storage/indexeddb/open-during-transaction.html

storage/indexeddb/version-change-abort.html

  • storage/IDBBackingStore.h:
  • storage/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::setVersionInternal):

  • storage/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::getIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::createIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::updateIDBDatabaseMetaData):

  • storage/IDBLevelDBBackingStore.h:

LayoutTests:

  • storage/indexeddb/open-during-transaction-expected.txt: Added.
  • storage/indexeddb/open-during-transaction.html: Added.
  • storage/indexeddb/version-change-abort-expected.txt: Added.
  • storage/indexeddb/version-change-abort.html: Added.
12:15 PM Changeset in webkit [98748] by macpherson@chromium.org
  • 8 edits in trunk/Source/WebCore

Use enum instead of bool to represent -webkit-column-span property.
​https://bugs.webkit.org/show_bug.cgi?id=70867

Reviewed by Darin Adler.

Covered by existing tests.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator ColumnSpan):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::createAnonymousColumnSpanBlock):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::propagateStyleToAnonymousChildren):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::columnSpan):
(WebCore::InheritedFlags::setColumnSpan):
(WebCore::InheritedFlags::initialColumnSpan):

  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleMultiColData.h:
12:08 PM Changeset in webkit [98747] by mhahnenberg@apple.com
  • 18 edits in trunk/Source

De-virtualize isGlobalObject, isVariableObject, isActivationObject, and isErrorInstance in JSObject
​https://bugs.webkit.org/show_bug.cgi?id=70968

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • API/JSCallbackObject.cpp: Added two specializations for createStructure that use different JSTypes in their

TypeInfo. Had to also create a specialization for JSNonFinalObject, even JSGlobalObject was the only that
needed it because Windows wouldn't build without it.
(JSC::::createStructure):

  • API/JSCallbackObject.h:
  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/ErrorInstance.h: Removed virtual function and changed JSType provided to TypeInfo in createStructure.

(JSC::ErrorInstance::createStructure):

  • runtime/ErrorPrototype.h: Ditto

(JSC::ErrorPrototype::createStructure):

  • runtime/JSActivation.h: Ditto

(JSC::JSActivation::createStructure):

  • runtime/JSGlobalObject.h: Ditto

(JSC::JSGlobalObject::createStructure):

  • runtime/JSObject.h: De-virtualized functions. They now check the JSType of the object for the corresponding type.

(JSC::JSObject::isGlobalObject):
(JSC::JSObject::isVariableObject):
(JSC::JSObject::isActivationObject):
(JSC::JSObject::isErrorInstance):

  • runtime/JSType.h: Added new types for GlobalObject, VariableObject, ActivationObject, and ErrorInstance.
  • runtime/JSVariableObject.cpp: Removed virtual function.
  • runtime/JSVariableObject.h: Changed JSType provided to TypeInfo in createStructure.

(JSC::JSVariableObject::createStructure):

Source/WebCore:

No new tests.

  • bindings/js/JSDOMGlobalObject.h: Changed JSType provided to TypeInfo in createStructure since this

class inherits from JSGlobalObject.
(WebCore::JSDOMGlobalObject::createStructure):

  • bindings/js/JSDOMWindowBase.h: Ditto

(WebCore::JSDOMWindowBase::createStructure):

  • bindings/js/JSWorkerContextBase.h: Ditto

(WebCore::JSWorkerContextBase::createStructure):

  • bindings/scripts/CodeGeneratorJS.pm: Added extra check to make sure subclasses of JSGlobalObject,

namely JSDOMWindow and JSWorkerContext, get their special JSType in their createStructure function.
(GenerateHeader):

11:57 AM Changeset in webkit [98746] by Simon Fraser
  • 1 edit
    4 adds in trunk/LayoutTests

Added some missing results for compositing visibilty tests.

  • platform/mac/compositing/visibility/visibility-composited-expected.txt: Added.
  • platform/mac/compositing/visibility/visibility-composited-transforms-expected.txt: Added.
  • platform/mac/compositing/visibility/visibility-image-layers-expected.txt: Added.
11:43 AM Changeset in webkit [98745] by commit-queue@webkit.org
  • 7 edits
    6 deletes in trunk

Unreviewed, rolling out r98736.
​http://trac.webkit.org/changeset/98736
​https://bugs.webkit.org/show_bug.cgi?id=71125

This patch broke perf/array-binary-search.html test (Requested
by annacc on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-28

Source/WebCore:

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadTextTracks):
(WebCore::HTMLMediaElement::addTrack):

  • html/HTMLMediaElement.h:
  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::insertedIntoTree):
(WebCore::HTMLTrackElement::willRemove):

  • html/HTMLTrackElement.h:
  • html/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::cueLoadingCompleted):

LayoutTests:

  • media/track/track-load-error-readyState-expected.txt: Removed.
  • media/track/track-load-error-readyState.html: Removed.
  • media/track/track-load-from-element-readyState-expected.txt: Removed.
  • media/track/track-load-from-element-readyState.html: Removed.
  • media/track/track-load-from-src-readyState-expected.txt: Removed.
  • media/track/track-load-from-src-readyState.html: Removed.
11:40 AM Changeset in webkit [98744] by zherczeg@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Testing allowed identifier chars which are greater than 126
​https://bugs.webkit.org/show_bug.cgi?id=71097

Reviewed by Darin Adler.

  • fast/css/parsing-css-nonascii-expected.txt: Added.
  • fast/css/parsing-css-nonascii.html: Added.
11:29 AM Changeset in webkit [98743] by inferno@chromium.org
  • 6 edits
    3 copies in branches/chromium/874/LayoutTests/fast/table

Merge 98411 - Made Table tests for Bug 70678 Platform Independent
BUG=101540
Review URL: ​http://codereview.chromium.org/8416045

11:28 AM Changeset in webkit [98742] by eae@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebKit2/WebProcess/Plugins/PluginView.cpp

Fix PluginView rect calculation

11:28 AM Changeset in webkit [98741] by inferno@chromium.org
  • 6 edits
    3 copies in branches/chromium/912/LayoutTests/fast/table

Merge 98411 - Made Table tests for Bug 70678 Platform Independent
BUG=101540
Review URL: ​http://codereview.chromium.org/8343064

11:25 AM Changeset in webkit [98740] by inferno@chromium.org
  • 3 edits
    6 copies in branches/chromium/912

Merge 98372 - Crash in WebCore::RenderTableSection::addChild due to assert failure
BUG=101540
Review URL: ​http://codereview.chromium.org/8417039

11:23 AM Changeset in webkit [98739] by inferno@chromium.org
  • 3 edits
    6 copies in branches/chromium/874

Merge 98372 - Crash in WebCore::RenderTableSection::addChild due to assert failure
BUG=101540
Review URL: ​http://codereview.chromium.org/8343063

11:06 AM WinCE edited by patricke@bsquare.com
(diff)
11:04 AM Changeset in webkit [98738] by jchaffraix@webkit.org
  • 3 edits in trunk/Source/WebCore

RenderTableSection::recalcCells should not free its grid
​https://bugs.webkit.org/show_bug.cgi?id=71056

Reviewed by Darin Adler.

Refactoring only, no change in behavior.

r98614 had the bad side effect of clearing the row vector (m_grid) on
the RenderTableSection when doing a recalcCells. This change removes the
unneeded free and inline the |row| field into the RowStruct as it made
no sense to have it as a pointer.

  • rendering/RenderTableSection.cpp:

(WebCore::setRowLogicalHeightToRowStyleLogicalHeightIfNotRelative):
(WebCore::RenderTableSection::addChild):
(WebCore::RenderTableSection::setCellLogicalWidths):
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::firstLineBoxBaseline):
(WebCore::RenderTableSection::appendColumn):
(WebCore::RenderTableSection::splitColumn):
Mechanical changes now that |row| is a member of RowStruct.

(WebCore::RenderTableSection::~RenderTableSection): Clear our row vector.

(WebCore::RenderTableSection::ensureRows):
(WebCore::RenderTableSection::recalcCells):
Those 2 functions were refactored to use fillRowsWithDefaultStartingAtPosition.

(WebCore::RenderTableSection::fillRowsWithDefaultStartingAtPosition):
Factored the code to fill the RowStruct structure with default values.

  • rendering/RenderTableSection.h:

(WebCore::RenderTableSection::cellAt):
(WebCore::RenderTableSection::primaryCellAt):
More mechanical change after the |row| field change.

11:00 AM Changeset in webkit [98737] by rniwa@webkit.org
  • 6 edits in trunk/LayoutTests

Unskip tables/mozilla_expected_failures/bugs/bug14007-2.html
since the test was rebaselined in r98691.

Also enable platform/mac/editing/deleting/backward-delete.html on Chromium Mac
and skip it again on Chromium Windows and Linux.

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
10:54 AM Changeset in webkit [98736] by annacc@chromium.org
  • 7 edits
    6 adds in trunk

Implement load notification and events for <track>.
​https://bugs.webkit.org/show_bug.cgi?id=71054

Reviewed by Eric Carlson.

Source/WebCore:

Tests: media/track/track-load-error-readyState.html

media/track/track-load-from-element-readyState.html
media/track/track-load-from-src-readyState.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadTextTracks):
(WebCore::HTMLMediaElement::loadNextTextTrack):
(WebCore::HTMLMediaElement::trackWasAdded):
(WebCore::HTMLMediaElement::trackWillBeRemoved):
(WebCore::HTMLMediaElement::trackSourceChanged):

  • html/HTMLMediaElement.h:
  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::insertedIntoTree):
(WebCore::HTMLTrackElement::willRemove):
(WebCore::HTMLTrackElement::parseMappedAttribute):
(WebCore::HTMLTrackElement::attributeChanged):

  • html/HTMLTrackElement.h:
  • html/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::cueLoadingCompleted):

LayoutTests:

  • media/track/track-load-error-readyState-expected.txt: Added.
  • media/track/track-load-error-readyState.html: Added.
  • media/track/track-load-from-element-readyState-expected.txt: Added.
  • media/track/track-load-from-element-readyState.html: Added.
  • media/track/track-load-from-src-readyState-expected.txt: Added.
  • media/track/track-load-from-src-readyState.html: Added.
10:46 AM Changeset in webkit [98735] by Simon Fraser
  • 10 edits
    8 adds in trunk

Source/WebCore: The HTML5 video element in Safari does not respect "visibility:hidden" CSS property
​https://bugs.webkit.org/show_bug.cgi?id=38829

Reviewed by James Robinson.

Make compositing and CSS visibility play nicely together.

The main issue was that an old optimization (see bug 4377) caused
visibility:hidden layers to not appear in the z-order lists, but those
layers could still become composited, but would remain detached. In addition,
composited layers which were visibility:hidden would become visible sometimes.

With this fix, the z-order lists always contain all layers when the page
is in compositing mode. GraphicsLayer is changed to ensure that visibility:hidden
layers show no content, and visible descendants of hidden layers work correctly.

Tests: compositing/visibility/visibility-composited-transforms.html

compositing/visibility/visibility-composited.html
compositing/visibility/visibility-image-layers-dynamic.html
compositing/visibility/visibility-image-layers.html

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::GraphicsLayer): Init m_contentsVisible to true.
(WebCore::GraphicsLayer::dumpProperties): Dump m_contentsVisible if not true.

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::contentsAreVisible): Getter for m_contentsVisible.
(WebCore::GraphicsLayer::setContentsVisible): Setter for m_contentsVisible.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setContentsVisible): Override setContentsVisible.
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): Handle ContentsVisibilityChanged
flag
(WebCore::GraphicsLayerCA::updateSublayerList): Only parent the m_contentsLayer if the layer
has visible contents.
(WebCore::GraphicsLayerCA::updateContentsVisibility): For bits painted into the layer itself,
we hide it by clearing the backing store.

  • platform/graphics/ca/GraphicsLayerCA.h: Removed obsolete comment on the DrawsContentChanged flag,

added ContentsVisibilityChanged flag.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateZOrderLists): If we're in compositing mode, include all layers
in the z-order lists.
(WebCore::RenderLayer::collectLayers): New param to specify whether we need to collect all layers.

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::hasVisibleDescendant): Add comment about the need for an assertion in hasVisibleContent()
, and assertion in hasVisibleDescendant().

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Call setContentsVisible() on the GraphicsLayer.
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer): We can use simple container layers in cases
where visibility:hidden causes layer content to not be drawn.
(WebCore::RenderLayerBacking::hasVisibleNonCompositingDescendants): Renamed from hasNonCompositingDescendants()
because it now also looks at visibility to decide when things are visible.

  • rendering/RenderLayerBacking.h: hasNonCompositingDescendants() renamed to hasVisibleNonCompositingDescendants().

LayoutTests: The HTML5 video element in Safari does not respect "visibility:hidden" CSS property
​https://bugs.webkit.org/show_bug.cgi?id=38829

Test various configurations of compositing layers and visibility.

Reviewed by James Robinson.

  • compositing/visibility/visibility-composited-expected.png: Added.
  • compositing/visibility/visibility-composited-transforms-expected.png: Added.
  • compositing/visibility/visibility-composited-transforms.html: Added.
  • compositing/visibility/visibility-composited.html: Added.
  • compositing/visibility/visibility-image-layers-dynamic-expected.txt: Added.
  • compositing/visibility/visibility-image-layers-dynamic.html: Added.
  • compositing/visibility/visibility-image-layers-expected.png: Added.
  • compositing/visibility/visibility-image-layers.html: Added.
10:42 AM Changeset in webkit [98734] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/WebCore.gyp/WebCore.gyp

Adding Mac fixed classes to chromium gypi.

10:35 AM Changeset in webkit [98733] by arv@chromium.org
  • 190 edits
    1 delete in trunk/LayoutTests

JS Test Harness: Remove js-test-post-function.js
​https://bugs.webkit.org/show_bug.cgi?id=70959

Reviewed by Ojan Vafai.

This moves isSuccessfullyParsed to js-test-pre.js and removes js-test-post-function.js and all references to it.

  • fast/js/resources/js-test-post-function.js: Removed.
  • fast/js/resources/js-test-pre.js:

(isSuccessfullyParsed): Moved here from js-test-post-function.js

9:58 AM Changeset in webkit [98732] by Nate Chapin
  • 2 edits
    1 move
    1 add
    1 delete in trunk/LayoutTests

empty-urls.html needs to stop being flaky.
Because it was in http/tests/loading, it output
frame load callbacks, and it was unpredictable whether
the callback for onload or for the load completing would
be called first. Ergo, move the test to http/tests/misc,
and remove the logic which failed to enforce a frame load
callback ordering.
​https://bugs.webkit.org/show_bug.cgi?id=67359

Reviewed by Adam Barth.

  • http/tests/loading/empty-urls-expected.txt: Removed.
  • http/tests/loading/empty-urls.html: Removed.
  • http/tests/misc/empty-urls-expected.txt: Copied from LayoutTests/http/tests/loading/empty-urls-expected.txt.
  • http/tests/misc/empty-urls.html: Copied from LayoutTests/http/tests/loading/empty-urls.html.
  • platform/chromium/test_expectations.txt:
9:50 AM WebKitGTK/1.6.x edited by plaes@plaes.org
Added .xz tarball creation patch (diff)
9:47 AM Changeset in webkit [98731] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

[GTK] Build fixes for glib 2.31 (current master)
​https://bugs.webkit.org/show_bug.cgi?id=70679

Reviewed by Martin Robinson.

g_cond_new and g_mutex_new have been replaced by _init
functions. Same for _free, replaced by _clear.

  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(webkit_video_sink_init):
(webkit_video_sink_dispose):

9:29 AM Changeset in webkit [98730] by jochen@chromium.org
  • 34 edits in trunk/Source

Rename a number of methods mentioning JavaScript to just Script instead
​https://bugs.webkit.org/show_bug.cgi?id=71105

Reviewed by Adam Barth.

Source/WebCore:

  • WebCore.exp.in:
  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::canExecuteScripts):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::handleOutOfMemory):

  • loader/FrameLoaderClient.h:

(WebCore::FrameLoaderClient::allowScript):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::canRequest):

  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setScriptEnabled):

  • page/Settings.h:

(WebCore::Settings::isScriptEnabled):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::dataChanged):

Source/WebKit/chromium:

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::allowScript):

  • src/FrameLoaderClientImpl.h:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::collectGarbage):

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setJavaScriptEnabled):

Source/WebKit/efl:

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchDidClearWindowObjectInWorld):

  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):
(ewk_view_setting_enable_scripts_set):

Source/WebKit/gtk:

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDidClearWindowObjectInWorld):

  • webkit/webkitwebview.cpp:

(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit/qt:

  • Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):

Source/WebKit/win:

  • WebFrame.cpp:

(WebFrame::dispatchDidClearWindowObjectInWorld):

  • WebView.cpp:

(WebView::notifyPreferencesChanged):

Source/WebKit/wince:

  • WebView.cpp:

(WebView::WebView):

Source/WebKit/wx:

  • WebSettings.cpp:

(wxWebSettings::SetJavaScriptEnabled):
(wxWebSettings::IsJavaScriptEnabled):

  • WebView.cpp:

(wxWebView::Create):

Source/WebKit2:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

9:22 AM Changeset in webkit [98729] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:

Remove fast/replaced/table-percent-height.html that has been passing for at least
a week. Also tighten some tests that have not been passing (but occasionally timing
out) on the flakyness dashboard for some time.

8:22 AM BuildingQt5OnHarmattan edited by Simon Hausmann
(diff)
8:17 AM BuildingQt5OnHarmattan edited by Simon Hausmann
(diff)
7:57 AM Changeset in webkit [98728] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, skiped failing test inspector/debugger/selected-call-frame-after-formatting-source.html.

  • platform/mac/Skipped:
7:52 AM Changeset in webkit [98727] by zoltan@webkit.org
  • 2 edits in trunk/Tools

Add watchlist for QtWebKit2 API and for WK2's Qt specific files.
​https://bugs.webkit.org/show_bug.cgi?id=71116

Reviewed by David Levin.

  • Scripts/webkitpy/common/config/watchlist:
7:42 AM Changeset in webkit [98726] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-5.0/Skipped:
  • platform/qt-wk2/Skipped:
6:59 AM Changeset in webkit [98725] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening.

REGRESSION: 5 editing tests fail
​https://bugs.webkit.org/show_bug.cgi?id=71117

  • platform/qt-wk2/Skipped: Skip failing tests.
6:27 AM Changeset in webkit [98724] by pfeldman@chromium.org
  • 7 edits
    2 adds in trunk

Reset line numbers for scripts generated with document.write.
​https://bugs.webkit.org/show_bug.cgi?id=71099

Reviewed by Yury Semikhatsky.

Source/JavaScriptCore:

  • wtf/text/TextPosition.h:

(WTF::OrdinalNumber::OrdinalNumber):

Source/WebCore:

Test: http/tests/inspector-enabled/document-write.html

  • dom/Document.h:

(WebCore::Document::isInDocumentWrite):

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::prepareScript):

LayoutTests:

  • http/tests/inspector-enabled/document-write-expected.txt: Added.
  • http/tests/inspector-enabled/document-write.html: Added.
  • platform/chromium-win/fast/dom/nested-script-exceptions-expected.txt:
6:10 AM Changeset in webkit [98723] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2011-10-28 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Unsupress css3/font-feature-settings-rendering.html as it should
pass on Linux after r98716.

  • platform/chromium/test_expectations.txt:
6:06 AM Changeset in webkit [98722] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

[Qt] Adapt to QSG* to QQuick* API change in qtdeclarative
​https://bugs.webkit.org/show_bug.cgi?id=70494

One more buildfix. (unreviewed)

  • UIProcess/API/qt/qtouchwebpage.cpp:

(computeEffectiveOpacity):
(QTouchWebPage::itemChange):

6:06 AM Changeset in webkit [98721] by Csaba Osztrogonác
  • 26 edits in trunk

[Qt] Adapt to QSG* to QQuick* API change in qtdeclarative
​https://bugs.webkit.org/show_bug.cgi?id=70494

Patch by Simon Hausmann <​simon.hausmann@nokia.com> on 2011-10-28
Reviewed by Kenneth Christiansen.

Use QQuick* instead of QSG* as well as QStandardPaths
instead of QDesktopLocation.

Source/WebKit/qt:

  • Api/qwebsettings.cpp:

(QWebSettings::enablePersistentStorage):

Source/WebKit2:

  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebView::QDesktopWebView):
(QDesktopWebView::geometryChanged):
(QDesktopWebView::event):
(QDesktopWebViewPrivate::engine):

  • UIProcess/API/qt/qdesktopwebview.h:
  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPage::QTouchWebPage):
(QTouchWebPage::event):
(QTouchWebPage::geometryChanged):

  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebView::QTouchWebView):
(QTouchWebView::geometryChanged):
(QTouchWebView::touchEvent):

  • UIProcess/API/qt/qtouchwebview.h:
  • UIProcess/API/qt/tests/testwindow.h:

(TestWindow::TestWindow):
(TestWindow::resizeEvent):

  • UIProcess/qt/QtDesktopWebPageProxy.cpp:

(QtDesktopWebPageProxy::createPopupMenuProxy):

  • UIProcess/qt/QtSGUpdateQueue.cpp:

(WebKit::QtSGUpdateQueue::QtSGUpdateQueue):

  • UIProcess/qt/QtSGUpdateQueue.h:
  • UIProcess/qt/QtTouchViewInterface.cpp:

(WebKit::QtTouchViewInterface::engine):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::contentRectInViewportCoordinates):
(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):

  • UIProcess/qt/QtViewportInteractionEngine.h:
  • UIProcess/qt/WebContextQt.cpp:

(WebKit::defaultDataLocation):

  • UIProcess/qt/WebPopupMenuProxyQtDesktop.cpp:

(WebKit::WebPopupMenuProxyQtDesktop::WebPopupMenuProxyQtDesktop):

  • UIProcess/qt/WebPopupMenuProxyQtDesktop.h:

(WebKit::WebPopupMenuProxyQtDesktop::create):

Tools:

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):

  • MiniBrowser/qt/BrowserWindow.h:
  • QtTestBrowser/cookiejar.cpp:

(TestBrowserCookieJar::TestBrowserCookieJar):

  • QtTestBrowser/launcherwindow.cpp:

(LauncherWindow::setDiskCache):

  • WebKitTestRunner/PlatformWebView.h:
  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::WrapperWindow::WrapperWindow):
(WTR::WrapperWindow::handleStatusChanged):

5:37 AM Changeset in webkit [98720] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Mac build fix after r98711

  • WebCore.xcodeproj/project.pbxproj: Mark ExceptionCodeDescription.h private so WebKit can

find it.

5:28 AM Changeset in webkit [98719] by jocelyn.turcotte@nokia.com
  • 3 edits in trunk/Tools

[Qt] Fix the Ctrl behavior for touch mocking in MiniBrowser.
​https://bugs.webkit.org/show_bug.cgi?id=71106

Reviewed by Simon Hausmann.

Holding Ctrl allows multiple touch points to be held on the screen using
mouse buttons. It would previously only prevent TouchReleased to be sent
and would require another MouseButtonRelease to be sent without holding Ctrl.

This patch makes sure that all held touch points are released when Ctrl
is released if MouseButtonRelease was received.
It also removes the touch QEvent::Type logic since it's currently handled
by QtGui by observing the modified touch points.

  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::notify):
(MiniBrowserApplication::sendTouchEvent):

  • MiniBrowser/qt/MiniBrowserApplication.h:
5:20 AM Changeset in webkit [98718] by kenneth@webkit.org
  • 4 edits in trunk/Tools

[Qt] MiniBrowser needs a -window-size option
​https://bugs.webkit.org/show_bug.cgi?id=70999

Reviewed by Simon Hausmann.

Add an -window-size option useful for testing the viewport handling.
Also clean up the option handling.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):

  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::handleUserOptions):

  • MiniBrowser/qt/MiniBrowserApplication.h:

(WindowOptions::WindowOptions):
(WindowOptions::setRequestedWindowSize):
(WindowOptions::requestedWindowSize):

  • MiniBrowser/qt/utils.cpp:

(takeOptionValue):

  • MiniBrowser/qt/utils.h:
5:18 AM Changeset in webkit [98717] by kenneth@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Make the kinetic engine use the same curve and constants as on the N9
​https://bugs.webkit.org/show_bug.cgi?id=71102

Reviewed by Simon Hausmann.

Now that we are using the QScroller for kinetic scrolling and page
interaction, we need to make sure it uses the same curve (exponential)
and the same values as the MeeGo Touch physics engine used on the N9.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::reset):

4:47 AM Changeset in webkit [98716] by Antti Koivisto
  • 3 edits
    2 adds in trunk

[Chromium] css3/font-feature-settings-rendering.html has incorrect image result after r98542
​https://bugs.webkit.org/show_bug.cgi?id=71019

Source/WebCore:

Reviewed by Andreas Kling.

These properties need to be marked inherited too.

Note that the new test case doesn't fail even without the patch. If I understand correctly
the image test in the title is pretty much the only way to see this. However the
new test improves code coverage and protects against future regressions.

Test: fast/css/inherited-properties-rare-text.html

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

LayoutTests:

Reviewed by Andreas Kling.

  • fast/css/inherited-properties-rare-text-expected.txt: Added.
  • fast/css/inherited-properties-rare-text.html: Added.
2:52 AM Changeset in webkit [98715] by abarth@webkit.org
  • 12 edits in trunk/Source

Remove getExceptionCodeDescription()
​https://bugs.webkit.org/show_bug.cgi?id=71103

Reviewed by Eric Seidel.

Source/WebCore:

This function serves no purpose.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::setDOMException):

  • bindings/objc/ExceptionHandlers.mm:

(WebCore::raiseDOMException):

  • bindings/scripts/CodeGeneratorGObject.pm:

():

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_method_that_requires_all_args_and_throws):
(webkit_dom_test_obj_method_with_exception):
(webkit_dom_test_obj_with_script_state_void_exception):
(webkit_dom_test_obj_with_script_state_obj_exception):
(webkit_dom_test_obj_get_attr_with_getter_exception):
(webkit_dom_test_obj_set_attr_with_getter_exception):
(webkit_dom_test_obj_set_attr_with_setter_exception):
(webkit_dom_test_obj_set_string_attr_with_getter_exception):
(webkit_dom_test_obj_set_string_attr_with_setter_exception):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::setDOMException):

  • dom/ExceptionCode.cpp:
  • dom/ExceptionCode.h:

Source/WebKit/chromium:

Migrate to new API.

  • src/StorageInfoChromium.cpp:
  • src/WebStorageQuotaCallbacksImpl.cpp:

(WebKit::WebStorageQuotaCallbacksImpl::didFail):

2:43 AM Changeset in webkit [98714] by apavlov@chromium.org
  • 7 edits in trunk

Web Inspector: CSS background-image applied inline shows a warning, but still works.
​https://bugs.webkit.org/show_bug.cgi?id=70325

Reviewed by Antti Koivisto.

Source/WebCore:

This change eliminates the "non-parsed property" warning displayed next to any
"background-image" property of an element's inline style.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseDeclaration):

  • css/CSSParser.h:
  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):

LayoutTests:

  • inspector/styles/styles-new-API-expected.txt:
  • inspector/styles/styles-new-API.html:
2:36 AM Changeset in webkit [98713] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

Attempt to fixenate Qt.

  • CodeGenerators.pri:
  • dom/make_event_factory.pl:

(toMacroStyle):

2:27 AM Changeset in webkit [98712] by hans@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

IndexedDB: Clean-up unused functions in WebIDBFactory
​https://bugs.webkit.org/show_bug.cgi?id=71011

Reviewed by Tony Chang.

This is a clean-up after r97453. Since Chromium was updated,
these functions are no longer used.

  • public/WebIDBFactory.h:

(WebKit::WebIDBFactory::getDatabaseNames):
(WebKit::WebIDBFactory::open):

2:11 AM Changeset in webkit [98711] by abarth@webkit.org
  • 18 edits
    2 adds in trunk

ExceptionCode.cpp shouldn't need to know about every feature that throws exceptions
​https://bugs.webkit.org/show_bug.cgi?id=70890

Reviewed by Eric Seidel.

.:

Add a code generation step.

  • Source/cmake/WebKitMacros.cmake:

Source/WebCore:

Generate the feature-specific parts of ExceptionCode.cpp from a ".in"
file. This is an incremental step towards inlining
getExceptionCodeDescription into its callers and replacing the switch
statements at those locations with autogenerated code.

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.make:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/action_makenames.py:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMBinding.cpp:

(WebCore::setDOMException):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::setDOMException):

  • dom/DOMCoreException.cpp:

(WebCore::DOMCoreException::initializeDescription):

  • dom/ExceptionCode.cpp:

(WebCore::getExceptionCodeDescription):

  • dom/ExceptionCode.h:
  • dom/ExceptionCodeDescription.in: Added.
  • dom/make_exception_code_description.pl: Added.

(defaultItemFactory):
(generateCode):
(generateHeader):
(generateImplementation):

2:09 AM Changeset in webkit [98710] by yurys@chromium.org
  • 5 edits
    2 adds in trunk

Web Inspector: CallStackSidebarPane should remove discarded Placards from RawSourceCode listeners list
​https://bugs.webkit.org/show_bug.cgi?id=70996

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/callstack-placards-discarded.html

  • inspector/front-end/CallStackSidebarPane.js:

(WebInspector.CallStackSidebarPane.prototype.update):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.createPlacard):
(WebInspector.DebuggerPresentationModel.CallFramePlacard):
(WebInspector.DebuggerPresentationModel.CallFramePlacard.prototype.discard):
(WebInspector.DebuggerPresentationModel.CallFramePlacard.prototype._update):

  • inspector/front-end/Placard.js:

(WebInspector.Placard.prototype.toggleSelected):
(WebInspector.Placard.prototype.discard):

LayoutTests:

  • inspector/debugger/callstack-placards-discarded-expected.txt: Added.
  • inspector/debugger/callstack-placards-discarded.html: Added.
1:48 AM Changeset in webkit [98709] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-28

  • DEPS:
1:31 AM BuildingQt5OnHarmattan edited by Simon Hausmann
(diff)
1:16 AM Changeset in webkit [98708] by jochen@chromium.org
  • 13 edits
    3 adds in trunk

Add allowScriptFromSource callback to FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=71013

Reviewed by Darin Fisher.

Source/WebCore:

Test: platform/chromium/permissionclient/script-permissions.html

  • loader/FrameLoaderClient.h:

(WebCore::FrameLoaderClient::allowScriptFromSource):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::canRequest):

Source/WebKit/chromium:

  • public/WebPermissionClient.h:

(WebKit::WebPermissionClient::allowScriptFromSource):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::allowScriptFromSource):

  • src/FrameLoaderClientImpl.h:

Tools:

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::setScriptsAllowed):

  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/WebPermissions.cpp:

(WebPermissions::allowScriptFromSource):
(WebPermissions::setScriptsAllowed):
(WebPermissions::reset):

  • DumpRenderTree/chromium/WebPermissions.h:

LayoutTests:

  • platform/chromium/permissionclient/resources/script.js: Added.
  • platform/chromium/permissionclient/script-permissions-expected.txt: Added.
  • platform/chromium/permissionclient/script-permissions.html: Added.
1:12 AM Changeset in webkit [98707] by Carlos Garcia Campos
  • 12 edits in trunk/Source/WebKit2

[GTK] Add webkit_web_view_get_uri() to WebKit2 GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=70814

Reviewed by Gustavo Noronha Silva.

  • UIProcess/API/gtk/WebKitWebLoaderClient.cpp:

(didStartProvisionalLoadForFrame): Update WebView URI to make sure
it's updated to provisional URL.
(didReceiveServerRedirectForProvisionalLoadForFrame): Update
WebView URI if there's a server redirection.
(didCommitLoadForFrame): Update WebView URI to make sure it
contains the final one.
(didSameDocumentNavigationForFrame): Update WebView URI when a
navigation action within the same document is performed.
(webkitWebLoaderClientAttachLoaderClientToPage): Add
implementation for didSameDocumentNavigationForFrame callback.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_class_init): Add URI property.
(webkitWebViewUpdateURI): Check whether current active URI has
changed to updated it and emit ::notify signal if it changes.
(webkit_web_view_load_uri): Call webkitWebViewUpdateURI() to make
sure the active URI is updated when load operation is started.
(webkit_web_view_load_alternate_html): Ditto.
(webkit_web_view_reload): Ditto.
(webkit_web_view_reload_bypass_cache): Ditto.
(webkit_web_view_go_back): Ditto.
(webkit_web_view_go_forward): Ditto.
(webkit_web_view_get_uri): Ditto.
(webkit_web_view_go_to_back_forward_list_item): Ditto.

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/WebKitWebViewPrivate.h: Add

webkitWebViewUpdateURI().

  • UIProcess/API/gtk/tests/LoadTrackingTest.cpp:

(provisionalLoadStartedCallback): Check provisional URL is the
requested URI.
(provisionalLoadReceivedServerRedirectCallback): Check provisional
URL after server redirection is the expected redirected URI.
(provisionalLoadFailedCallback): Check active URI.
(loadCommittedCallback): Ditto.
(loadFinishedCallback): Ditto.
(loadFailedCallback): Ditto
(LoadTrackingTest::LoadTrackingTest): Check active URI is NULL
before any loading operation has started.

  • UIProcess/API/gtk/tests/LoadTrackingTest.h:

(LoadTrackingTest::setRedirectURI): Set the redirect URI to check
it after a server redirection.

  • UIProcess/API/gtk/tests/TestBackForwardList.cpp:

(testBackForwardListNavigation): Use WebViewTest methods for
navigation actions instead of using WebKitWebView API directly.
(testBackForwardListLimitAndCache): Ditto.

  • UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp:

(testLoadingStatus): Ditto.
(testLoadingError): Ditto.
(testLoadAlternateContent): Ditto.
(testLoadCancelled): Ditto.
(testWebViewReload): Ditto.
(testLoadProgress): Ditto.
(testWebViewActiveURI): Add a test to check that notify signal is
emitted when active URI changes and it's correctly updated when
loader client signals are emitted.
(beforeAll): Add active-uri test.

  • UIProcess/API/gtk/tests/WebViewTest.cpp: Add custom load methods

wrapping the WebKitWebView ones, to initialize the active URI to
the requested one, so that it can be checked by the loader client
test.
(WebViewTest::loadURI):
(WebViewTest::loadAlternateHTML):
(WebViewTest::goBack):
(WebViewTest::goForward):
(WebViewTest::goToBackForwardListItem):

  • UIProcess/API/gtk/tests/WebViewTest.h:
12:59 AM Changeset in webkit [98706] by Simon Hausmann
  • 14 edits in trunk/Source/WebKit2

[Qt][WK2] Synchronize tiling with accelerated compositing
​https://bugs.webkit.org/show_bug.cgi?id=69151

Patch by No'am Rosenthal <​noam.rosenthal@nokia.com> on 2011-10-21
Reviewed by Simon Hausmann.

Make QTouchWebView always render with accelerated compositing.
At first, the web content would only render after the rest of the scene has rendered. In a
future patch we'll enable rendering the web content via an FBO, which would cover all other
cases as well.

Right now this only works for QTouchWebView, and thus accelerated compositing is disabled
for desktop web-views. This required adding some settings enablers in Q
WebPreferencesPrivate. Those are not exposed to the public API, as they are an implementation
detail.

  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPage::QTouchWebPage):
(QTouchWebPage::initSceneGraphConnections):
(QTouchWebPagePrivate::QTouchWebPagePrivate):
(QTouchWebPagePrivate::setPage):
(computeEffectiveOpacity):
(QTouchWebPagePrivate::paintToCurrentGLContext):
(QTouchWebPagePrivate::_q_onAfterSceneRender):
(QTouchWebPagePrivate::_q_onSceneGraphInitialized):
(QTouchWebPage::itemChange):

  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/qtouchwebpage_p.h:
  • UIProcess/API/qt/qwebpreferences.cpp:

(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferencesPrivate::get):

  • UIProcess/API/qt/qwebpreferences_p.h:
  • UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::renderNextFrame):

  • UIProcess/qt/QtDesktopWebPageProxy.cpp:

(QtDesktopWebPageProxy::QtDesktopWebPageProxy):

  • UIProcess/qt/QtTouchViewInterface.cpp:

(WebKit::QtTouchViewInterface::setViewNeedsDisplay):

  • UIProcess/qt/QtTouchWebPageProxy.cpp:

(QtTouchWebPageProxy::QtTouchWebPageProxy):
(QtTouchWebPageProxy::createDrawingAreaProxy):
(QtTouchWebPageProxy::renderToCurrentGLContext):
(QtTouchWebPageProxy::setVisibleContentRectAndScale):
(QtTouchWebPageProxy::setVisibleContentRectTrajectoryVector):
(QtTouchWebPageProxy::renderNextFrame):

  • UIProcess/qt/QtTouchWebPageProxy.h:
  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHost::supportsAcceleratedCompositing):

  • WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::WebPage::platformInitialize):

  • WebProcess/qt/WebProcessMainQt.cpp:

(WebKit::WebProcessMainQt):

12:39 AM Changeset in webkit [98705] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update Chromium test expectation.

  • platform/chromium/test_expectations.txt:

Mark http/tests/websocket/tests/hybi/reserved-bits.html as flaky.

12:20 AM Changeset in webkit [98704] by abarth@webkit.org
  • 7 edits
    1 add in trunk/Source

Refactor make_event_factory.pl to use InFilesCompiler.pm
​https://bugs.webkit.org/show_bug.cgi?id=71094

Reviewed by Eric Seidel.

This refactoring helps share code with
make_exception_code_descriptions.pl, which is coming in a future patch.
I have a dream of refactoring make_names.pl to use this module as well.

  • CodeGenerators.pri:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gyp/scripts/action_makenames.py:
  • bindings/scripts/InFilesCompiler.pm: Added.

(itemHandler):
(parameterHandler):
(new):
(compile):
(license):

  • dom/make_event_factory.pl:

(defaultItemFactory):
(interfaceForEvent):
(generateCode):
(printFactoryFile):
(printMacroFile):
(printHeadersFile):

12:19 AM Changeset in webkit [98703] by apavlov@chromium.org
  • 2 edits in branches/chromium/912/Source/WebCore/inspector/front-end

Merge 98489 - Web Inspector: Need workaround for the red crossed circle in the status bar not bringing up the console when clicked
​https://bugs.webkit.org/show_bug.cgi?id=70928

Reviewed by Pavel Feldman.

  • inspector/front-end/inspector.css:

(#error-count-img):
(#error-count + #warning-count-img):
(#warning-count-img):

  • inspector/front-end/inspector.js:

(WebInspector._updateErrorAndWarningCounts):

TBR=​apavlov@chromium.org
Review URL: ​http://codereview.chromium.org/8343053

12:18 AM Changeset in webkit [98702] by Alexandru Chiculita
  • 2 edits in trunk/Tools

Added myself as a committer.

  • Scripts/webkitpy/common/config/committers.py:
12:01 AM Changeset in webkit [98701] by abarth@webkit.org
  • 3 edits in trunk/Tools

Remove WinCairo from the set of core builders. WinCairo rarely builds
and is never green.

Rubber-stamped by Eric Seidel.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

Oct 27, 2011:

11:50 PM Changeset in webkit [98700] by nduca@chromium.org
  • 5 edits
    8 adds in trunk/Source

[chromium] Implement frame rate control portions of CCScheduler
​https://bugs.webkit.org/show_bug.cgi?id=70713

Reviewed by James Robinson.

Source/WebCore:

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp: Added.

(WebCore::CCDelayBasedTimeSource::setActive):
(WebCore::CCDelayBasedTimeSource::postTickTask):
(WebCore::CCDelayBasedTimeSource::onTick):

  • platform/graphics/chromium/cc/CCDelayBasedTimeSource.h: Added.

(WebCore::CCDelayBasedTimeSource::CCDelayBasedTimeSource):
(WebCore::CCDelayBasedTimeSource::~CCDelayBasedTimeSource):
(WebCore::CCDelayBasedTimeSource::setClient):
(WebCore::CCDelayBasedTimeSource::monotonicallyIncreasingTime):

  • platform/graphics/chromium/cc/CCFrameRateController.cpp: Added.

(WebCore::CCFrameRateControllerTimeSourceAdapter::create):
(WebCore::CCFrameRateControllerTimeSourceAdapter::~CCFrameRateControllerTimeSourceAdapter):
(WebCore::CCFrameRateControllerTimeSourceAdapter::onTimerTick):
(WebCore::CCFrameRateControllerTimeSourceAdapter::CCFrameRateControllerTimeSourceAdapter):
(WebCore::CCFrameRateController::CCFrameRateController):
(WebCore::CCFrameRateController::~CCFrameRateController):
(WebCore::CCFrameRateController::onTimerTick):
(WebCore::CCFrameRateController::didBeginFrame):
(WebCore::CCFrameRateController::didFinishFrame):
(WebCore::CCFrameRateController::didAbortAllPendingFrames):

  • platform/graphics/chromium/cc/CCFrameRateController.h: Added.

(WebCore::CCFrameRateControllerClient::~CCFrameRateControllerClient):
(WebCore::CCFrameRateController::setClient):
(WebCore::CCFrameRateController::setActive):

  • platform/graphics/chromium/cc/CCTimeSource.h: Added.

(WebCore::CCTimeSourceClient::~CCTimeSourceClient):
(WebCore::CCTimeSource::~CCTimeSource):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCDelayBasedTimeSourceTest.cpp: Added.

(WebKitTests::TEST):

  • tests/CCFrameRateControllerTest.cpp: Added.

(WebKitTests::FakeCCFrameRateControllerClient::FakeCCFrameRateControllerClient):
(WebKitTests::FakeCCFrameRateControllerClient::reset):
(WebKitTests::FakeCCFrameRateControllerClient::frameBegun):
(WebKitTests::FakeCCFrameRateControllerClient::beginFrame):
(WebKitTests::TEST):

  • tests/CCLayerTreeHostTest.cpp:
  • tests/CCSchedulerTestCommon.h: Added.

(WebKitTests::FakeCCTimeSourceClient::FakeCCTimeSourceClient):
(WebKitTests::FakeCCTimeSourceClient::reset):
(WebKitTests::FakeCCTimeSourceClient::tickCalled):
(WebKitTests::FakeCCTimeSourceClient::onTimerTick):
(WebKitTests::FakeCCThread::FakeCCThread):
(WebKitTests::FakeCCThread::reset):
(WebKitTests::FakeCCThread::hasPendingTask):
(WebKitTests::FakeCCThread::runPendingTask):
(WebKitTests::FakeCCThread::pendingDelay):
(WebKitTests::FakeCCThread::postTask):
(WebKitTests::FakeCCThread::postDelayedTask):
(WebKitTests::FakeCCThread::threadID):
(WebKitTests::FakeCCDelayBasedTimeSource::FakeCCDelayBasedTimeSource):
(WebKitTests::FakeCCDelayBasedTimeSource::setMonotonicallyIncreasingTime):
(WebKitTests::FakeCCDelayBasedTimeSource::monotonicallyIncreasingTime):

11:44 PM Changeset in webkit [98699] by commit-queue@webkit.org
  • 2 edits in trunk

[GTK] Create .xz tarballs during distcheck
​https://bugs.webkit.org/show_bug.cgi?id=71001

Patch by Priit Laes <​plaes@plaes.org> on 2011-10-27
Reviewed by Martin Robinson.

  • configure.ac: Switched tarballs to use .xz compression.
11:26 PM Changeset in webkit [98698] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Unskip platform/mac/editing/deleting/backward-delete.html on Chromium because it passes on my Mac.

  • platform/chromium/test_expectations.txt:
11:18 PM Changeset in webkit [98697] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Group editing test expectations for Chromium in one place.

  • platform/chromium/test_expectations.txt:
11:06 PM Changeset in webkit [98696] by rniwa@webkit.org
  • 19 edits
    19 adds in trunk/LayoutTests

Chromium Mac rebaselines.

  • platform/chromium-cg-mac-leopard/editing/deleting/table-cells-expected.png:
  • platform/chromium-cg-mac-leopard/editing/execCommand/create-list-with-hr-expected.png:
  • platform/chromium-cg-mac-leopard/editing/execCommand/find-after-replace-expected.png:
  • platform/chromium-cg-mac-leopard/editing/execCommand/paste-1-expected.png:
  • platform/chromium-cg-mac-leopard/editing/execCommand/paste-2-expected.png:
  • platform/chromium-cg-mac-leopard/editing/inserting/4278698-expected.png:
  • platform/chromium-cg-mac-leopard/editing/inserting/paragraph-separator-in-table-2-expected.png:
  • platform/chromium-cg-mac-leopard/editing/pasteboard/3976872-expected.png:
  • platform/chromium-cg-mac-leopard/editing/pasteboard/4076267-2-expected.png:
  • platform/chromium-cg-mac-leopard/editing/pasteboard/4076267-3-expected.png:
  • platform/chromium-cg-mac-leopard/editing/pasteboard/4076267-expected.png:
  • platform/chromium-cg-mac-leopard/editing/pasteboard/4944770-1-expected.png:
  • platform/chromium-cg-mac-leopard/editing/pasteboard/undoable-fragment-removes-expected.png:
  • platform/chromium-cg-mac-leopard/editing/selection/select-all-iframe-expected.png:
  • platform/chromium-cg-mac-leopard/editing/undo/4063751-expected.png:
  • platform/chromium-cg-mac-leopard/editing/unsupported-content/table-type-after-expected.png:
  • platform/chromium-cg-mac-leopard/editing/unsupported-content/table-type-before-expected.png:
  • platform/chromium-cg-mac-leopard/fast/dom/blur-contenteditable-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/deleting/table-cells-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/execCommand/create-list-with-hr-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/execCommand/find-after-replace-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/execCommand/paste-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/execCommand/paste-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/4278698-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/inserting/paragraph-separator-in-table-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/3976872-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/4076267-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/4076267-3-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/4076267-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/undoable-fragment-removes-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/selection/select-all-iframe-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/undo: Added.
  • platform/chromium-cg-mac-snowleopard/editing/undo/4063751-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/unsupported-content: Added.
  • platform/chromium-cg-mac-snowleopard/editing/unsupported-content/table-type-after-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/editing/unsupported-content/table-type-before-expected.png: Added.
  • platform/chromium/test_expectations.txt:
10:52 PM Changeset in webkit [98695] by haraken@chromium.org
  • 12 edits in trunk/Source/WebCore

Deprecate [V8ConstructorSetsActiveDOMWrapper] IDL
​https://bugs.webkit.org/show_bug.cgi?id=71088

Reviewed by Adam Barth.

I introduced [V8ConstructorSetsActiveDOMWrapper] IDL in bug 66536,
but I found that it has the same meaning as [ActiveDOMObject] IDL.
This patch removes [V8ConstructorSetsActiveDOMWrapper] IDL.

No change in behavior.

Tests: fast/dom/global-constructors.html

fast/eventsource/eventsource-constructor.html
fast/eventsource/eventsource-attribute-listeners.html
fast/files/blob-slice-test.html
fast/files/file-reader-abort.html
ui_tests:WorkerTest.FLAKY_SharedWorkerFastConstructor
ui_tests:WorkerTest.FLAKY_SharedWorkerFastName
ui_tests:WorkerTest.FLAKY_WorkerConstructor
ui_tests:WorkerTest.FLAKY_WorkerEventListener

  • bindings/scripts/CodeGeneratorV8.pm: Replaced "V8ConstructorSetsActiveDOMWrapper" with "ActiveDOMObject".

(GenerateConstructorCallback):

  • bindings/scripts/test/TestInterface.idl: Ditto.
  • bindings/scripts/test/JS/JSTestInterface.cpp: Updated a test result.

(WebCore::isObservable):
(WebCore::JSTestInterfaceOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestInterfaceOwner::finalize):

  • bindings/scripts/test/JS/JSTestInterface.h: Ditto.

(WebCore::wrapperOwner):
(WebCore::wrapperContext):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h: Ditto.
  • bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestObj.h: Ditto.
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h: Ditto.
  • bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.

(WebCore::V8TestInterface::toActiveDOMObject):
(WebCore::V8TestInterface::wrapSlow):

  • bindings/scripts/test/V8/V8TestInterface.h: Ditto.

(WebCore::V8TestInterface::existingWrapper):

  • fileapi/FileReader.idl: Removed [V8ConstructorSetsActiveDOMWrapper] IDL.
  • mediastream/PeerConnection.idl: Ditto.
  • page/EventSource.idl: Ditto.
  • workers/SharedWorker.idl: Ditto.
  • workers/Worker.idl: Ditto.
10:39 PM Changeset in webkit [98694] by yutak@chromium.org
  • 3 edits in trunk/Source/WebCore

Race condition in SocketStreamHandleCFNet when PAC script is used
​https://bugs.webkit.org/show_bug.cgi?id=70894

Reviewed by Alexey Proskuryakov.

Pass callback functions that call ref() or deref() as retain/release member
of CFStreamClientContext.

No new tests, as it is not possible to write a test with PAC script enabled.

  • platform/network/cf/SocketStreamHandle.h:
  • platform/network/cf/SocketStreamHandleCFNet.cpp:

(WebCore::SocketStreamHandle::scheduleStreams):
(WebCore::SocketStreamHandle::retainSocketStreamHandle):
(WebCore::SocketStreamHandle::releaseSocketStreamHandle):
(WebCore::SocketStreamHandle::pacExecutionCallbackMainThread):
This callback may be called after platformClose() is already called. We should
not create new streams in this case.
(WebCore::SocketStreamHandle::executePACFileURL):
(WebCore::SocketStreamHandle::readStreamCallback):
This manual ref/deref can be safely removed as m_readStream holds the reference.
(WebCore::SocketStreamHandle::writeStreamCallback):
Ditto.

10:39 PM Changeset in webkit [98693] by yutak@chromium.org
  • 2 edits in trunk/Tools

WebSocket: Connecting to localhost:8880 takes one second on Windows
​https://bugs.webkit.org/show_bug.cgi?id=64788

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/servers/websocket_server.py:

Bind to "localhost" instead of "127.0.0.1" to let pywebsocket listen on both
IPv4 and IPv6 addresses. This should prevent the test reserved-opcodes.html
from timing out on Windows, because this test tries to open a lot of
connections to localhost and each attempt takes one second to fall back from
IPv6 to IPv4 on Windows (I have no idea why Windows works like this, though).

10:37 PM Changeset in webkit [98692] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Reland patch ensure font load before calling Skia during printing
​https://bugs.webkit.org/show_bug.cgi?id=70390

Patch by Arthur Hsu <​arthurhsu@chromium.org> on 2011-10-27
Reviewed by James Robinson.

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::Font::drawGlyphs):

  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::paintSkiaText):

10:22 PM Changeset in webkit [98691] by msaboff@apple.com
  • 5 edits in trunk/LayoutTests

Test Failure in fast/dom/prototype-inheritance-2.html after r98495
​https://bugs.webkit.org/show_bug.cgi?id=71058

Rebaselined these results due to hash order changes in r98495.

Reviewed by Darin Adler.

  • fast/dom/prototype-inheritance-2-expected.txt:
  • platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
10:11 PM Changeset in webkit [98690] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Attempt to fix the Qt build.

  • WebCore.pro:
10:10 PM Changeset in webkit [98689] by rniwa@webkit.org
  • 1 edit
    4 deletes in trunk/LayoutTests

Remove erroneous expected results after r98685.

  • platform/chromium-linux/editing/selection/click-before-and-after-table-expected.png: Removed.
  • platform/chromium-win/editing/selection/click-before-and-after-table-expected.png: Removed.
  • platform/chromium-win/editing/selection/click-before-and-after-table-expected.txt: Removed.
  • platform/qt/editing/selection/click-before-and-after-table-expected.png: Removed.
9:58 PM Changeset in webkit [98688] by rniwa@webkit.org
  • 4 edits in trunk/Source/WebCore

binding test rebaseline after r98679.

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::constructJSTestInterface):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::setJSTestObjStringAttr):
(WebCore::setJSTestObjStringAttrWithGetterException):
(WebCore::setJSTestObjStringAttrWithSetterException):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionSerializedValue):
(WebCore::jsTestObjPrototypeFunctionIdbKey):
(WebCore::jsTestObjPrototypeFunctionOptionsObject):
(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod6):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod7):
(WebCore::jsTestObjPrototypeFunctionClassMethodWithOptional):

9:55 PM Changeset in webkit [98687] by abarth@webkit.org
  • 7 edits in trunk/Tools

Dis-integrate run-bindings-tests with webkitpy
​https://bugs.webkit.org/show_bug.cgi?id=71092

Reviewed by Ryosuke Niwa.

These tests aren't really adding any value.

  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/runtests.py:
  • Scripts/webkitpy/tool/steps/runtests_unittest.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
9:44 PM Changeset in webkit [98686] by abarth@webkit.org
  • 21 edits
    10 adds in trunk/Source/WebCore

Move type-specific exception descriptions into the implementation files for each type
​https://bugs.webkit.org/show_bug.cgi?id=71081

Reviewed by Eric Seidel.

There's no reason to centralize this information. It belongs with each
exception type. This patch is in preparation for autogenerating the central file.

  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMCoreException.cpp: Added.

(WebCore::DOMCoreException::initializeDescription):

  • dom/DOMCoreException.h:
  • dom/EventException.cpp: Copied from Source/WebCore/xml/XMLHttpRequestException.h.

(WebCore::EventException::initializeDescription):

  • dom/EventException.h:
  • dom/ExceptionBase.h:

(WebCore::ExceptionBase::code):
(WebCore::ExceptionBase::name):
(WebCore::ExceptionBase::message):
(WebCore::ExceptionBase::description):

  • dom/ExceptionCode.cpp:

(WebCore::getExceptionCodeDescription):

  • dom/RangeException.cpp: Copied from Source/WebCore/xml/XPathException.h.

(WebCore::RangeException::initializeDescription):

  • dom/RangeException.h:
  • fileapi/FileException.cpp: Added.

(WebCore::FileException::initializeDescription):

  • fileapi/FileException.h:
  • fileapi/OperationNotAllowedException.cpp: Copied from Source/WebCore/xml/XMLHttpRequestException.h.

(WebCore::OperationNotAllowedException::initializeDescription):

  • fileapi/OperationNotAllowedException.h:
  • storage/IDBDatabaseException.cpp: Added.

(WebCore::IDBDatabaseException::initializeDescription):

  • storage/IDBDatabaseException.h:
  • storage/SQLException.cpp: Added.

(WebCore::SQLException::initializeDescription):

  • storage/SQLException.h:
  • svg/SVGException.cpp: Copied from Source/WebCore/dom/EventException.h.

(WebCore::SVGException::initializeDescription):

  • svg/SVGException.h:
  • xml/XMLHttpRequestException.cpp: Copied from Source/WebCore/xml/XMLHttpRequestException.h.

(WebCore::XMLHttpRequestException::initializeDescription):

  • xml/XMLHttpRequestException.h:
  • xml/XPathException.cpp: Copied from Source/WebCore/xml/XPathException.h.

(WebCore::XPathException::initializeDescription):

  • xml/XPathException.h:
9:24 PM Changeset in webkit [98685] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

Fix click-before-and-after-table.html for Chromium
​https://bugs.webkit.org/show_bug.cgi?id=70869

Reviewed by Tony Chang.

Fixed the test by wrapping tests in a function to avoid shadowing "top" variable.

  • editing/selection/click-before-and-after-table.html:
  • platform/chromium/test_expectations.txt:
8:50 PM Changeset in webkit [98684] by Martin Robinson
  • 2 edits in trunk/Source/WebKit2

Fix the GTK+ build after r98664.

  • WebProcess/Plugins/Plugin.h: Add an IntSize forward declaration.
8:50 PM Changeset in webkit [98683] by johnnyg@google.com
  • 2 edits in trunk/LayoutTests

Update chromium test expectations.

  • platform/chromium/test_expectations.txt:
8:47 PM Changeset in webkit [98682] by eric@webkit.org
  • 2 edits in trunk/Tools

REGRESSION (r98639): NRWT crashes when parsing leaks output
​https://bugs.webkit.org/show_bug.cgi?id=71087

Unreviewed. Sadly we have no good way to test logging.

  • Scripts/webkitpy/layout_tests/port/leakdetector.py:
7:54 PM Changeset in webkit [98681] by dbates@webkit.org
  • 4 edits in trunk

CMake: Add support to optionally install the built JavaScript shell
​https://bugs.webkit.org/show_bug.cgi?id=71062

Reviewed by Antonio Gomes.

.:

Adds a CMake option, called SHOULD_INSTALL_JS_SHELL, that when
defined will generate an installation rule to install the built
JavaScript shell into /bin (with respect to the prefix path).

By default, we don't define this option and hence don't generate
an installation rule for the JavaScript shell.

  • Source/CMakeLists.txt:

Source/JavaScriptCore:

Generate an installation rule for installing the JavaScript shell in
/bin (with respect to the prefix path) when SHOULD_INSTALL_JS_SHELL
is defined.

  • shell/CMakeLists.txt:
7:47 PM Changeset in webkit [98680] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Fix variable renaming issue inside ewk_view.cpp
​https://bugs.webkit.org/show_bug.cgi?id=71020

Unreviewed build fix.

Patch by Gustavo Lima Chaves <​glima@profusion.mobi> on 2011-10-27

  • ewk/ewk_view.cpp:

(ewk_view_js_object_add):

7:43 PM Changeset in webkit [98679] by haraken@chromium.org
  • 13 edits
    1 delete in trunk/Source

Generate WebKitCSSMatrix constructor for JSC by [Constructor] IDL
​https://bugs.webkit.org/show_bug.cgi?id=70215

Reviewed by Adam Barth.

Source/JavaScriptCore:

Added a method that judges if a given JSValue is empty.

Tests: transforms/svg-vs-css.xhtml

transforms/cssmatrix-2d-interface.xhtml
transforms/cssmatrix-3d-interface.xhtml

  • runtime/JSValue.h:
  • runtime/JSValueInlineMethods.h:

(JSC::JSValue::isEmpty):

Source/WebCore:

This patch implements [Optional=CallWithNullValue] IDL for JSC.
While a parameter specified as [Optional=CallWithDefaultValue] is
handled as a string "undefined", a parameter specified as
[Optional=CallWithNullValue] is handled as a null string.
(Note: not a string "null", but a null string).

c.f. [Optional=CallWithNullValue] is implemented in V8 in bug 67458.

Tests: fast/dom/global-constructors.html

transforms/svg-vs-css.xhtml
transforms/cssmatrix-2d-interface.xhtml
transforms/cssmatrix-3d-interface.xhtml

  • GNUmakefile.list.am: Removed JSWebKitCSSMatrixCustom.cpp.
  • UseJSC.cmake: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSBindingsAllInOne.cpp: Ditto.
  • bindings/js/JSDOMBinding.h: MAYBE_MISSING_PARAMETER(exec, index, policy) returns the index-th parameter, if the parameter exists. It returns an undefined value, if the index-th parameter is missing and the policy is MissingIsUndefined. It returns an empty value, otherwise (i.e. if the index-th parameter is missing and the policy is MissingIsEmpty).
  • bindings/js/JSWebKitCSSMatrixCustom.cpp: Removed.
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheck): Supported [Optional=CallWithNullValue].
(GenerateConstructorDefinition): Supported [Optional=CallWithNullValue].

  • css/WebKitCSSMatrix.idl: Removed [JSCustomConstructor].
7:30 PM Changeset in webkit [98678] by johnnyg@google.com
  • 2 edits
    8 adds
    2 deletes in trunk/LayoutTests

Add more test expectations and chromium results.

  • platform/chromium-cg-mac-leopard/fast/backgrounds/size/contain-and-cover-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/css/getComputedStyle: Removed.
  • platform/chromium-cg-mac-leopard/fast/multicol/block-axis-horizontal-bt-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/multicol/block-axis-horizontal-tb-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/css/child-style-can-override-visited-style-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/child-style-can-override-visited-style-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/child-style-can-override-visited-style-expected.txt: Added.
  • platform/chromium-linux/fast/css/child-style-can-override-visited-style-expected.png: Added.
  • platform/chromium-linux/fast/css/child-style-can-override-visited-style-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/child-style-can-override-visited-style-expected.png: Added.
  • platform/chromium-win/fast/css/child-style-can-override-visited-style-expected.png: Added.
  • platform/chromium-win/fast/css/child-style-can-override-visited-style-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
6:40 PM Changeset in webkit [98677] by Martin Robinson
  • 17 edits in trunk/Source/WebKit/gtk

[GTK] Remove most of the documentation errors from WebKit1
​https://bugs.webkit.org/show_bug.cgi?id=70670

Reviewed by Gustavo Noronha Silva.

Fix most of the documentation errors for WebKit and make many
missing symbols show up in the documentation.

  • webkit/webkitglobals.h: Doc fixes.
  • webkit/webkitspellchecker.h: Ditto.
  • webkit/webkitspellcheckerenchant.cpp: Ditto.
  • webkit/webkitwebbackforwardlist.h: Ditto.
  • webkit/webkitwebdatasource.cpp: Ditto.
  • webkit/webkitwebframe.cpp: Ditto.
  • webkit/webkitwebinspector.cpp: Ditto.
  • webkit/webkitwebinspector.h: Ditto.
  • webkit/webkitwebplugin.h: Ditto.
  • webkit/webkitwebplugindatabase.cpp: Ditto.
  • webkit/webkitwebplugindatabase.h: Ditto.
  • webkit/webkitwebsettings.h: Ditto.
  • webkit/webkitwebview.cpp: Ditto.

(webkit_web_view_class_init): Ditto.

  • webkit/webkitwebview.h: Ditto.
6:28 PM Changeset in webkit [98676] by jchaffraix@webkit.org
  • 10 edits in trunk/Source/WebCore

RenderTableCell m_row and m_column should not be signed values
​https://bugs.webkit.org/show_bug.cgi?id=70369

Reviewed by Darin Adler.

No new tests, refactoring only.

The gist of the change is to update row / column handling in the table's
rendering code to use unsigned values. Not all the code is switched over
to unsigned but this is a good start.

Using unsigned makes a lot more sense that allowing some negative indexes
to creep in the algorithms. Also it enables us to "free" the unused signed
bit on the 2 RenderTableCell fields that can be used to pack 2 bits in a
follow-up patch.

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::cellForColumnAndRow):
Removed 2 casts to int as the left side now computes to an unsigned too.
Added some ASSERT to make sure we don't get negative values (colSpan / rowSpan
are always >= 1 by definition but better to be safe).

  • accessibility/AccessibilityTableColumn.cpp:

(WebCore::AccessibilityTableColumn::headerObjectForSection):

  • accessibility/AccessibilityTableColumn.h:

Switched m_columnIndex to unsigned to remove any signed / unsigned comparisons.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::splitColumn):
(WebCore::RenderTable::calcBorderEnd):
(WebCore::RenderTable::cellAbove):
(WebCore::RenderTable::cellBelow):
(WebCore::RenderTable::cellBefore):
(WebCore::RenderTable::cellAfter):
Mostly mechanical changes to avoid signed / unsigned comparisons or casts.

  • rendering/RenderTable.h:

(WebCore::RenderTable::numEffCols):
(WebCore::RenderTable::colToEffCol):
Updated a couple of functions to use an unsigned.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::RenderTableCell):

  • rendering/RenderTableCell.h:

(WebCore::RenderTableCell::col):
(WebCore::RenderTableCell::setCol):
(WebCore::RenderTableCell::row):
(WebCore::RenderTableCell::setRow):
Updated after switching the fields to unsigned. Also added 2 constants
to cover the not-initialized-yet value for row and column indexes.
Note: we don't enforce that you can't reach those indexes but neither
did the previous code!

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::RenderTableSection):
(WebCore::RenderTableSection::addChild):
(WebCore::RenderTableSection::ensureRows):
(WebCore::RenderTableSection::setCellLogicalWidths):
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::calcOuterBorderStart):
(WebCore::RenderTableSection::calcOuterBorderEnd):
(WebCore::RenderTableSection::recalcCells):
(WebCore::RenderTableSection::clearGrid):
(WebCore::RenderTableSection::numColumns):
(WebCore::RenderTableSection::appendColumn):
(WebCore::RenderTableSection::splitColumn):
Lots of mechanical: signed -> unsigned changes. However we had
to change the logic a bit as it assumed that m_cRow started at
-1 and increased from there. The new meaning of m_cRow is the
number of rows seen and m_cRow - 1 is where to insert your new
cells.

(WebCore::RenderTableSection::addCell):
Checked the callers and all increase m_cRow before calling the function.
Added an ASSERT to catch up wrong usage in the future.

  • rendering/RenderTableSection.h:

(WebCore::RenderTableSection::numRows): Switched to unsigned.

6:11 PM Changeset in webkit [98675] by mitz@apple.com
  • 3 edits
    2 adds in trunk

Assertion failure (m_text) in RenderText::RenderText() at icanhascheezburger.com
​https://bugs.webkit.org/show_bug.cgi?id=71085

Reviewed by Jon Honeycutt.

Source/WebCore:

Test: fast/css-generated-content/attr-missing.html

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty): If the element does not have the attribute specified
in the attr() function in the content property, set the content to the empty string, per
<​http://www.w3.org/TR/CSS21/generate.html#content>.

LayoutTests:

  • fast/css-generated-content/attr-missing-expected.txt: Added.
  • fast/css-generated-content/attr-missing.html: Added.
6:09 PM Changeset in webkit [98674] by msaboff@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

ENH: Add 8 bit string support to JSC JIT
​https://bugs.webkit.org/show_bug.cgi?id=71073

Changed the JIT String character access generation to create code
to check the character size and load8() or load16() as approriate.

Reviewed by Gavin Barraclough.

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::load8):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::movzbl_mr):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetCharCodeAt):
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitLoadCharacterString):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::stringGetByValStubGenerator):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::stringGetByValStubGenerator):

  • jit/JSInterfaceJIT.h:

(JSC::ThunkHelpers::stringImplFlagsOffset):
(JSC::ThunkHelpers::stringImpl8BitFlag):

  • jit/ThunkGenerators.cpp:

(JSC::stringCharLoad):

6:01 PM Changeset in webkit [98673] by mikelawther@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

Test that :visited style can be overridden by child element style
Added as requested on ​https://bugs.webkit.org/show_bug.cgi?id=70470

​https://bugs.webkit.org/show_bug.cgi?id=70568

Reviewed by Antti Koivisto.

  • fast/css/child-style-can-override-visited-style-expected.txt: Added.
  • fast/css/child-style-can-override-visited-style.html: Added.
5:57 PM Changeset in webkit [98672] by vangelis@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

Expose Settings::setAcceleratedCompositingForFixedPositionEnabled to WebSettingsImpl.
​https://bugs.webkit.org/show_bug.cgi?id=71077

Reviewed by James Robinson.

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setAcceleratedCompositingForFixedPositionEnabled):

  • src/WebSettingsImpl.h:
5:50 PM Changeset in webkit [98671] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Failure to build when QT_NO_CURSOR defined
​https://bugs.webkit.org/show_bug.cgi?id=71060

Patch by Helder Correia <​helder.correia@palm.com> on 2011-10-27
Reviewed by Noam Rosenthal.

PlatformVideoWindowQt needs to wrap some code around #ifndef
QT_NO_CURSOR in order to build QtWebKit when QT_NO_CURSOR is defined.

Build fix, no new tests.

  • platform/graphics/gstreamer/PlatformVideoWindowQt.cpp:

(FullScreenVideoWindow::FullScreenVideoWindow):
(FullScreenVideoWindow::closeEvent):
(FullScreenVideoWindow::hideCursor):
(FullScreenVideoWindow::showCursor):

5:44 PM Changeset in webkit [98670] by tony@chromium.org
  • 3 edits
    4 adds in trunk/LayoutTests

add snow leopard results for flexbox repaint tests
​https://bugs.webkit.org/show_bug.cgi?id=71069

Reviewed by Ojan Vafai.

  • css3/flexbox/repaint-rtl-column.html:
  • css3/flexbox/repaint.html:
  • platform/mac-snowleopard/css3/flexbox/repaint-expected.png: Added.
  • platform/mac-snowleopard/css3/flexbox/repaint-rtl-column-expected.png: Added.
5:42 PM Writing Layout Tests for DumpRenderTree edited by arv@chromium.org
Remove part about needing #console and #description (diff)
5:40 PM Changeset in webkit [98669] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/chromium

[chromium] Remove some APIs which are not used anymore.
​https://bugs.webkit.org/show_bug.cgi?id=71068

Patch by Peng Huang <​penghuang@chromium.org> on 2011-10-27
Reviewed by Darin Fisher.

  • public/WebWidget.h:
  • src/WebPopupMenuImpl.cpp:
  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp:
  • src/WebViewImpl.h:
5:39 PM Changeset in webkit [98668] by johnnyg@google.com
  • 3 edits in trunk/LayoutTests

Unreviewed, more gardening.

  • platform/chromium-cg-mac-leopard/fast/writing-mode/fallback-orientation-expected.png:
  • platform/chromium/test_expectations.txt:
5:37 PM Changeset in webkit [98667] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk/Source

[chromium] Track when CCLayerImpl properties have changed.
​https://bugs.webkit.org/show_bug.cgi?id=70442

Patch by Shawn Singh <​shawnsingh@chromium.org> on 2011-10-27
Reviewed by James Robinson.

Source/WebCore:

To determine a good scissor rect, we must determine what
will change on the screen on the next redraw. This patch
tracks the necessary information on CCLayerImpl and marks
a flag indicating whether this layer will "damage" the screen.
The other portion of "change", the updateRect, was already
landed in ​https://bugs.webkit.org/show_bug.cgi?id=69441.

New unit test added to CCLayerImplTest to test this patch.

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::scrollBy):
(WebCore::CCLayerImpl::noteLayerPropertyChangedForSubtree):
(WebCore::CCLayerImpl::noteLayerPropertyChangedForDescendants):
(WebCore::CCLayerImpl::setBounds):
(WebCore::CCLayerImpl::setMaskLayer):
(WebCore::CCLayerImpl::setReplicaLayer):
(WebCore::CCLayerImpl::setDrawsContent):
(WebCore::CCLayerImpl::setAnchorPoint):
(WebCore::CCLayerImpl::setAnchorPointZ):
(WebCore::CCLayerImpl::setMasksToBounds):
(WebCore::CCLayerImpl::setOpaque):
(WebCore::CCLayerImpl::setOpacity):
(WebCore::CCLayerImpl::setPosition):
(WebCore::CCLayerImpl::setPreserves3D):
(WebCore::CCLayerImpl::setSublayerTransform):
(WebCore::CCLayerImpl::setTransform):
(WebCore::CCLayerImpl::setDebugBorderColor):
(WebCore::CCLayerImpl::setDebugBorderWidth):
(WebCore::CCLayerImpl::setContentBounds):
(WebCore::CCLayerImpl::setScrollPosition):
(WebCore::CCLayerImpl::setScrollDelta):
(WebCore::CCLayerImpl::setDoubleSided):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::layerPropertyChanged):
(WebCore::CCLayerImpl::resetLayerPropertyChanged):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCLayerImplTest.cpp: Added.

(WebCore::TEST):

5:31 PM Writing Layout Tests for DumpRenderTree edited by jchaffraix@webkit.org
how to write good test case (edit 4), clean up grammar errors and gardening (diff)
5:29 PM Changeset in webkit [98666] by levin@chromium.org
  • 3 edits in trunk/Tools

Test expectation errors should include the file name and platform in both the log and exception info.
​https://bugs.webkit.org/show_bug.cgi?id=71067

Reviewed by Ojan Vafai.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:
  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
5:21 PM Changeset in webkit [98665] by eric@webkit.org
  • 3 edits in trunk/Tools

new-run-webkit-tests doesn't understand --qt or --gtk
​https://bugs.webkit.org/show_bug.cgi?id=63970

Reviewed by Ojan Vafai.

Add support for --qt and --gtk to NRWT.
I also removed some incorrect comments in the option parsing
code (options which we already implement, but said we didn't)
as well as moved --platform parsing out of the "results_options"
section into the top configuration section.

Now run-webkit-tests no longer needs NRWT-specific code for passing
--platform=qt, etc.

  • Scripts/run-webkit-tests:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
5:18 PM Changeset in webkit [98664] by andersca@apple.com
  • 11 edits in trunk/Source

Add a Plugin::geometryDidChange that will work with transforms
​https://bugs.webkit.org/show_bug.cgi?id=71072

Reviewed by Simon Fraser.

Source/WebCore:

Export symbols needed by WebKit2.

  • WebCore.exp.in:

Source/WebKit2:

Add a new Plugin::geometryDidChange pure virtual member function, that takes
the size of the plug-in, the clip rect (in plug-in coordinates), and a matrix that makes
it possible to convert between root view coordinates and plug-in coordinates.

PluginView only calls this new geometryDidChange member function if
Plugin::wantsWindowRelativeCoordinates returns false, which is only true for BuiltInPDFView right now.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::geometryDidChange):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

Add stub.

  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp:

(WebKit::BuiltInPDFView::updateScrollbars):
(WebKit::BuiltInPDFView::pdfDocumentDidLoad):
(WebKit::BuiltInPDFView::paintContent):
(WebKit::BuiltInPDFView::deprecatedGeometryDidChange):
(WebKit::BuiltInPDFView::geometryDidChange):
(WebKit::BuiltInPDFView::setScrollOffset):
(WebKit::BuiltInPDFView::maximumScrollPosition):
(WebKit::BuiltInPDFView::visibleHeight):
(WebKit::BuiltInPDFView::visibleWidth):

  • WebProcess/Plugins/PDF/BuiltInPDFView.h:

There's no need to keep track of the plug-in rect anymore.

  • WebProcess/Plugins/Plugin.h:

Add and document geometryDidChange.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::geometryDidChange):

  • WebProcess/Plugins/PluginProxy.h:

Add stub.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::viewGeometryDidChange):
Call geometryDidChange.

5:12 PM Writing Layout Tests for DumpRenderTree edited by jchaffraix@webkit.org
how to write good test case (edit 3), how to tweak pixel / text dumping (diff)
5:06 PM Writing Layout Tests for DumpRenderTree edited by jchaffraix@webkit.org
How to write good test case (edit 2), pixel tests (diff)
5:01 PM Changeset in webkit [98663] by johnnyg@google.com
  • 5 edits
    4 adds
    4 deletes in trunk/LayoutTests

Unreviewed, gardening chromium.

  • platform/chromium-cg-mac-snowleopard/fullscreen/full-screen-render-inline-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/table: Added.
  • platform/chromium-mac-snowleopard/fast/table/border-collapsing: Added.
  • platform/chromium-mac-snowleopard/fullscreen/full-screen-render-inline-expected.png: Added.
  • platform/chromium-win-vista/fast/css/getComputedStyle: Removed.
  • platform/chromium-win-vista/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
  • platform/chromium-win-xp/fast/css/getComputedStyle: Removed.
  • platform/chromium-win-xp/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium/fast/css/getComputedStyle: Removed.
  • platform/chromium/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
  • platform/chromium/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
  • platform/chromium/svg/css: Removed.
  • platform/chromium/svg/css/getComputedStyle-basic-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
5:00 PM Changeset in webkit [98662] by eae@chromium.org
  • 2679 edits
    3588 copies
    14 deletes in branches/subpixellayout

Merging trunk changes up until 98654 into subpixel branch.

4:58 PM Changeset in webkit [98661] by abarth@webkit.org
  • 6 edits in trunk/Source/WebCore

Exception subtypes have incorrect namespace indentation
​https://bugs.webkit.org/show_bug.cgi?id=71075

Reviewed by Eric Seidel.

This patch is in preparation for editing these headers. We decided to
not indent namespaces in headers and update the headers as we edited
them.

  • dom/DOMCoreException.h:

(WebCore::DOMCoreException::create):
(WebCore::DOMCoreException::DOMCoreException):

  • dom/EventException.h:

(WebCore::EventException::create):
(WebCore::EventException::EventException):

  • dom/RangeException.h:

(WebCore::RangeException::create):
(WebCore::RangeException::RangeException):

  • xml/XMLHttpRequestException.h:

(WebCore::XMLHttpRequestException::create):
(WebCore::XMLHttpRequestException::XMLHttpRequestException):

  • xml/XPathException.h:

(WebCore::XPathException::create):
(WebCore::XPathException::XPathException):

4:55 PM Changeset in webkit [98660] by kbr@google.com
  • 6 edits
    4 adds in trunk

Implement new restrictions on uniform and attribute location lengths
​https://bugs.webkit.org/show_bug.cgi?id=70981

Reviewed by Chris Marrin.

Source/WebCore:

Tests: fast/canvas/webgl/attrib-location-length-limits.html

fast/canvas/webgl/uniform-location-length-limits.html

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::bindAttribLocation):
(WebCore::WebGLRenderingContext::getAttribLocation):
(WebCore::WebGLRenderingContext::getUniformLocation):
(WebCore::WebGLRenderingContext::validateLocationLength):

  • html/canvas/WebGLRenderingContext.h:

LayoutTests:

  • fast/canvas/webgl/attrib-location-length-limits-expected.txt: Added.
  • fast/canvas/webgl/attrib-location-length-limits.html: Added (imported from WebGL conformance suite).
  • fast/canvas/webgl/resources/webgl-test-utils.js:

(WebGLTestUtils):
(WebGLTestUtils.): Updated to latest version in WebGL conformance suite.

  • fast/canvas/webgl/uniform-location-length-limits-expected.txt: Added.
  • fast/canvas/webgl/uniform-location-length-limits.html: Added (imported from WebGL conformance suite).
  • platform/mac/Skipped: Temporarily skip new tests on Mac until WebKit's copy of ANGLE is upgraded.
4:49 PM Writing Layout Tests for DumpRenderTree edited by jchaffraix@webkit.org
How to write good test case (edit 1), mostly text cases and 'do you … (diff)
4:38 PM Changeset in webkit [98659] by commit-queue@webkit.org
  • 13 edits in trunk

[MutationObservers] Implement subtree observation of transiently disconnected nodes
​https://bugs.webkit.org/show_bug.cgi?id=70788

Patch by Rafael Weinstein <​rafaelw@chromium.org> on 2011-10-27
Reviewed by Ryosuke Niwa.

Source/WebCore:

This patch adds support for observing all descendant nodes reachable from a subtree
observation until delivery of mutations -- even if they become detached. We do this by
introducing a "transient registration" which can exist for a short time along side
normal registrations on Node. Transient registrations have a reference to the node
which "owns" the subtree observation registration (the "registrationNode"). Transient
registrations are cleared immediately before mutations are delivered to an observer,
or when the observer re-observes at the registrationNode, in-effect resetting the
observation.

New tests added to fast/mutation/observe-subtree.html.

  • dom/CharacterData.cpp:

(WebCore::CharacterData::dispatchModifiedEvent):

  • dom/ChildListMutationScope.cpp:

(WebCore::MutationAccumulationRouter::ChildListMutationAccumulator::ChildListMutationAccumulator):
(WebCore::MutationAccumulationRouter::ChildListMutationAccumulator::enqueueMutationRecord):
(WebCore::MutationAccumulationRouter::MutationAccumulationRouter::incrementScopingLevel):

  • dom/ContainerNode.cpp:

(WebCore::dispatchChildRemovalEvents):

  • dom/Element.cpp:

(WebCore::enqueueAttributesMutationRecord):

  • dom/Node.cpp:

(WebCore::addMatchingObservers):
(WebCore::Node::getRegisteredMutationObserversOfType):
(WebCore::Node::registerMutationObserver):
(WebCore::Node::unregisterMutationObserver):
(WebCore::Node::notifySubtreeObserversOfDisconnection):

  • dom/Node.h:
  • dom/NodeRareData.h:

(WebCore::MutationObserverEntry::MutationObserverEntry):
(WebCore::MutationObserverEntry::operator==):

  • dom/WebKitMutationObserver.cpp:

(WebCore::WebKitMutationObserver::observe):
(WebCore::unregisterTransientEntries):
(WebCore::WebKitMutationObserver::disconnect):
(WebCore::WebKitMutationObserver::observedNodeDestructed):
(WebCore::WebKitMutationObserver::observedSubtreeWillDisconnect):
(WebCore::WebKitMutationObserver::clearTransientEntries):
(WebCore::WebKitMutationObserver::deliver):

  • dom/WebKitMutationObserver.h:

LayoutTests:

Added tests which assert that nodes can be detached from a subtree where observation is registered
and still be observed -- until the end of the current "microtask".

  • fast/mutation/observe-subtree-expected.txt:
  • fast/mutation/observe-subtree.html:
4:35 PM Changeset in webkit [98658] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

If the bytecode generator emits code after the return in the first basic block,
DFG's inliner crashes
​https://bugs.webkit.org/show_bug.cgi?id=71071

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

Removed some cruft dealing with parsing failures due to unsupported functionality
(that's never reached anymore due to it being caught in DFGCapabilities). This
allowed me to repurpose the bool return from parseBlock() to mean: true if we
should continue to parse, or false if we've already parsed all live code.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):

LayoutTests:

Reviewed by Gavin Barraclough.

  • fast/js/dfg-inline-early-return-expected.txt: Added.
  • fast/js/dfg-inline-early-return.html: Added.
  • fast/js/script-tests/dfg-inline-early-return.js: Added.

(foo):
(bar):

4:24 PM Changeset in webkit [98657] by psolanki@apple.com
  • 3 edits in trunk/Source/WebCore

Ask CG to not parse image metadata
​https://bugs.webkit.org/show_bug.cgi?id=71029

Reviewed by Simon Fraser.

We don't need CG to parse the image metadata since WebCore never uses it. Passing this
option shaves off time spent under CGImageSourceCopyPropertiesAtIndex. Under Instruments I
saw the time drop from ~75ms to ~25ms when loading ​http://boston.com/bigpicture and the
first link on that page.

No new tests because no change in functionality.

  • platform/graphics/ImageSource.h:
  • platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::imageSourceOptions):
(WebCore::ImageSource::isSizeAvailable):
(WebCore::ImageSource::frameSizeAtIndex):
(WebCore::ImageSource::getHotSpot):
(WebCore::ImageSource::repetitionCount):
(WebCore::ImageSource::createFrameAtIndex):
(WebCore::ImageSource::frameDurationAtIndex):

4:21 PM Writing Layout Tests for DumpRenderTree edited by jchaffraix@webkit.org
Splitting the existing content in a better structure, added some … (diff)
4:15 PM Changeset in webkit [98656] by dgrogan@chromium.org
  • 19 edits
    2 copies
    1 move
    1 add in trunk/Source/WebCore

Move eventqueue from Document to ScriptExecutionContext so that it can be accessed from workers
​https://bugs.webkit.org/show_bug.cgi?id=57789

Extract interface from EventQueue and create two new subclasses:
DocumentEventQueue and WorkerEventQueue. DocumentEventQueue is the
old EventQueue implementation that uses DOMTimer(0) to post async
events. WorkerEventQueue posts events to its thread's message loop.

Reviewed by David Levin.

No new tests - IndexedDB will use this but isn't ready yet. I don't
know of any other API available in workers that I can test this with.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/Document.cpp:

(WebCore::Document::Document):

  • dom/Document.h:

(WebCore::Document::eventQueue):

  • dom/DocumentEventQueue.cpp: Renamed from Source/WebCore/dom/EventQueue.cpp.

(WebCore::shouldDispatchScrollEventSynchronously):
(WebCore::DocumentEventQueueTimer::DocumentEventQueueTimer):
(WebCore::DocumentEventQueueTimer::fired):
(WebCore::DocumentEventQueue::create):
(WebCore::DocumentEventQueue::DocumentEventQueue):
(WebCore::DocumentEventQueue::~DocumentEventQueue):
(WebCore::DocumentEventQueue::enqueueEvent):
(WebCore::DocumentEventQueue::enqueueOrDispatchScrollEvent):
(WebCore::DocumentEventQueue::cancelEvent):
(WebCore::DocumentEventQueue::close):
(WebCore::DocumentEventQueue::pendingEventTimerFired):
(WebCore::DocumentEventQueue::dispatchEvent):

  • dom/DocumentEventQueue.h: Copied from Source/WebCore/dom/EventQueue.h.
  • dom/EventQueue.h:
  • dom/ScriptExecutionContext.h:
  • page/EventHandler.cpp: Change EventQueue to DocumentEventQueue.

(WebCore::EventHandler::sendScrollEvent): Change EventQueue to DocumentEventQueue.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollTo): Change EventQueue to DocumentEventQueue.

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::scrollTo): Change EventQueue to DocumentEventQueue.

  • storage/IDBDatabase.cpp:
  • storage/IDBRequest.cpp:
  • storage/IDBTransaction.cpp:
  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::eventQueue):

  • workers/WorkerContext.h:
  • workers/WorkerEventQueue.cpp: Added.

(WebCore::WorkerEventQueue::create):
(WebCore::WorkerEventQueue::WorkerEventQueue):
(WebCore::WorkerEventQueue::~WorkerEventQueue):
(WebCore::WorkerEventQueue::EventDispatcherTask::create):
(WebCore::WorkerEventQueue::EventDispatcherTask::dispatchEvent):
(WebCore::WorkerEventQueue::EventDispatcherTask::performTask):
(WebCore::WorkerEventQueue::EventDispatcherTask::cancel):
(WebCore::WorkerEventQueue::EventDispatcherTask::EventDispatcherTask):
(WebCore::WorkerEventQueue::removeEvent):
(WebCore::WorkerEventQueue::enqueueEvent):
(WebCore::WorkerEventQueue::cancelEvent):
(WebCore::WorkerEventQueue::close):

  • workers/WorkerEventQueue.h: Copied from Source/WebCore/dom/EventQueue.h.
4:14 PM Changeset in webkit [98655] by johnnyg@google.com
  • 2 edits
    53 adds
    44 deletes in trunk/LayoutTests

Unreviewed, new chromium expectations for shading/anti-aliasing changes.

  • fast/borders/borderRadiusDashed06-expected.txt: Added.
  • platform/chromium-cg-mac-leopard/fast/table/028-vertical-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fullscreen/parent-flow-inline-with-block-child-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/backgrounds/background-leakage-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/backgrounds/size: Added.
  • platform/chromium-cg-mac-snowleopard/fast/backgrounds/size/contain-and-cover-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDashed06-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/css/shadow-multiple-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/menulist-clip-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/menulist-option-wrap-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/menulist-restrict-line-height-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/menulist-separator-painting-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/menulist-style-color-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/select-baseline-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/select-empty-option-height-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/media/audio-repaint-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/media/video-zoom-controls-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/clip-path: Added.
  • platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-childs-clipped-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/custom: Added.
  • platform/chromium-cg-mac-snowleopard/svg/custom/focus-ring-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/filters: Added.
  • platform/chromium-cg-mac-snowleopard/svg/filters/filter-clip-expected.png: Added.
  • platform/chromium-cg-mac/fast/backgrounds/background-leakage-expected.png: Removed.
  • platform/chromium-cg-mac/fast/backgrounds/size/contain-and-cover-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDashed06-expected.png: Removed.
  • platform/chromium-cg-mac/fast/css/shadow-multiple-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/menulist-clip-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/menulist-option-wrap-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/menulist-restrict-line-height-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/menulist-separator-painting-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/menulist-style-color-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/select-baseline-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/select-empty-option-height-expected.png: Removed.
  • platform/chromium-cg-mac/media/audio-repaint-expected.png: Removed.
  • platform/chromium-cg-mac/media/video-zoom-controls-expected.png: Removed.
  • platform/chromium-cg-mac/media/video-zoom-controls-expected.txt: Removed.
  • platform/chromium-cg-mac/svg/clip-path/clip-path-childs-clipped-expected.png: Removed.
  • platform/chromium-cg-mac/svg/custom/focus-ring-expected.png: Removed.
  • platform/chromium-cg-mac/svg/filters/filter-clip-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/backgrounds/background-leakage-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/background-leakage-transforms-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDashed06-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/box-shadow: Added.
  • platform/chromium-mac-snowleopard/fast/box-shadow/box-shadow-clipped-slices-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/shadow-multiple-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-clip-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-narrow-width-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-option-wrap-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-restrict-line-height-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-separator-painting-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-style-color-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/select-baseline-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/select-empty-option-height-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text: Added.
  • platform/chromium-mac-snowleopard/fast/text/emphasis-overlap-expected.png: Added.
  • platform/chromium-mac-snowleopard/fullscreen/parent-flow-inline-with-block-child-expected.png: Added.
  • platform/chromium-mac-snowleopard/media/audio-repaint-expected.png: Added.
  • platform/chromium-mac-snowleopard/media/video-zoom-controls-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/masking-path-02-b-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-childs-clipped-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom: Added.
  • platform/chromium-mac-snowleopard/svg/custom/focus-ring-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/filter-clip-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/background-leakage-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDashed06-expected.png: Removed.
  • platform/chromium-mac/fast/box-shadow/box-shadow-clipped-slices-expected.png: Removed.
  • platform/chromium-mac/fast/css/shadow-multiple-expected.png: Removed.
  • platform/chromium-mac/fast/forms/menulist-clip-expected.png: Removed.
  • platform/chromium-mac/fast/forms/menulist-narrow-width-expected.png: Removed.
  • platform/chromium-mac/fast/forms/menulist-option-wrap-expected.png: Removed.
  • platform/chromium-mac/fast/forms/menulist-restrict-line-height-expected.png: Removed.
  • platform/chromium-mac/fast/forms/menulist-separator-painting-expected.png: Removed.
  • platform/chromium-mac/fast/forms/menulist-style-color-expected.png: Removed.
  • platform/chromium-mac/fast/forms/select-baseline-expected.png: Removed.
  • platform/chromium-mac/fast/forms/select-empty-option-height-expected.png: Removed.
  • platform/chromium-mac/fast/text/emphasis-overlap-expected.png: Removed.
  • platform/chromium-mac/media/audio-repaint-expected.png: Removed.
  • platform/chromium-mac/media/video-zoom-controls-expected.png: Removed.
  • platform/chromium-mac/media/video-zoom-controls-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/masking-path-02-b-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-childs-clipped-expected.png: Removed.
  • platform/chromium-mac/svg/custom/focus-ring-expected.png: Removed.
  • platform/chromium-mac/svg/filters/filter-clip-expected.png: Removed.
  • platform/chromium-win-xp/media: Added.
  • platform/chromium-win-xp/media/video-zoom-controls-expected.png: Added.
  • platform/chromium-win-xp/media/video-zoom-controls-expected.txt: Added.
  • platform/chromium/media/video-zoom-controls-expected.txt: Added.
  • platform/gtk/fast/borders/borderRadiusDashed06-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-childs-clipped-expected.txt: Removed.
  • platform/mac/fast/borders/borderRadiusDashed06-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-childs-clipped-expected.txt: Removed.
  • platform/qt/fast/borders/borderRadiusDashed06-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-path-childs-clipped-expected.txt: Removed.
  • platform/win-xp/media/audio-repaint-expected.txt: Removed.
  • svg/clip-path/clip-path-childs-clipped-expected.txt: Added.
4:06 PM Changeset in webkit [98654] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[GStreamer] Prevent memory leak when fullscreening a video
​https://bugs.webkit.org/show_bug.cgi?id=71043

Patch by Jonathon Jongsma <​jonathon.jongsma@collabora.co.uk> on 2011-10-27
Reviewed by Gustavo Noronha Silva.

  • platform/graphics/gstreamer/GStreamerGWorld.cpp:

(WebCore::GStreamerGWorld::GStreamerGWorld):
(WebCore::GStreamerGWorld::enterFullscreen):
(WebCore::GStreamerGWorld::exitFullscreen):

  • platform/graphics/gstreamer/GStreamerGWorld.h:
4:03 PM Changeset in webkit [98653] by leviw@chromium.org
  • 3 edits in branches/subpixellayout/Source/WebCore

Fixing the Mac build by rolling out Region changes. Only RenderRegion needed the previous fix.

3:51 PM Changeset in webkit [98652] by commit-queue@webkit.org
  • 8 edits in trunk/Source

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2011-10-27
Reviewed by David Kilzer.

Make FeatureDefines Identical Across OS X Projects
​https://bugs.webkit.org/show_bug.cgi?id=71051

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
3:38 PM Changeset in webkit [98651] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Web Inspector: HTTP headers merged incorrect in Chrome
​https://bugs.webkit.org/show_bug.cgi?id=69674

Reviewed by Pavel Feldman.

  • src/WebHTTPLoadInfo.cpp:

(WebKit::addHeader):

3:34 PM Changeset in webkit [98650] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Correctly Guard Exported REQUEST_ANIMATION_FRAME Symbols
​https://bugs.webkit.org/show_bug.cgi?id=71047

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2011-10-27
Reviewed by David Kilzer.

  • WebCore.exp.in:
3:28 PM Changeset in webkit [98649] by eae@chromium.org
  • 6 edits in branches/subpixellayout/Source

Qt/chromium linux fixes and cleanup

3:25 PM Changeset in webkit [98648] by leviw@chromium.org
  • 4 edits in branches/subpixellayout/Source/WebCore

Fixing region's usage of integers and INT_MAX with LayoutUnit-friendly versions

3:19 PM Changeset in webkit [98647] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Crash in JSC::Structure::materializePropertyMap when viewing Garden-O-Matic
​https://bugs.webkit.org/show_bug.cgi?id=71045

Reviewed by Geoff Garen.

Make sure that if a structure is pinned, it also has a property map.

  • runtime/Structure.cpp:

(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::getterSetterTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::removePropertyWithoutTransition):
(JSC::Structure::pin):
(JSC::Structure::copyPropertyTableForPinning):

  • runtime/Structure.h:

(JSC::Structure::materializePropertyMapIfNecessaryForPinning):

3:07 PM Changeset in webkit [98646] by andersca@apple.com
  • 10 edits in trunk/Source/WebKit2

Rename Plugin::geometryDidChange to Plugin::deprecatedGeometryDidChange
​https://bugs.webkit.org/show_bug.cgi?id=71065

Reviewed by Simon Fraser.

In preparation for adding a version of geometryDidChange that doesn't take window coordinates.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::geometryDidChange):

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::deprecatedGeometryDidChange):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp:

(WebKit::BuiltInPDFView::deprecatedGeometryDidChange):

  • WebProcess/Plugins/PDF/BuiltInPDFView.h:
  • WebProcess/Plugins/Plugin.h:
  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::deprecatedGeometryDidChange):

  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::viewGeometryDidChange):

3:05 PM Changeset in webkit [98645] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r98626.
​http://trac.webkit.org/changeset/98626
​https://bugs.webkit.org/show_bug.cgi?id=71066

Does not compile on cr-win (Requested by jamesr_ on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-27

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::Font::drawGlyphs):

  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::paintSkiaText):

2:56 PM Changeset in webkit [98644] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix a compiler warning caught by gcc 4.6.1. Need to return something.

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::nextAction):

2:54 PM Changeset in webkit [98643] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

32bit build failure after r98624
​https://bugs.webkit.org/show_bug.cgi?id=71064

Disambiguated operator overload with unsigned index (0u).

Reviewed by Sam Weinig.

  • runtime/UString.h:

(JSC::operator==):

2:48 PM Changeset in webkit [98642] by annacc@chromium.org
  • 9 edits in trunk/LayoutTests

Individually Skip track-related LayoutTests rather than block-Skipping them.
​https://bugs.webkit.org/show_bug.cgi?id=71037

Reviewed by Adam Barth.

  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
2:43 PM Changeset in webkit [98641] by leviw@chromium.org
  • 2 edits in branches/subpixellayout/Source/WebCore/platform

Painting Mac scrollbars on integer bounds.

2:42 PM Changeset in webkit [98640] by vsevik@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Advanced search style fixes.
​https://bugs.webkit.org/show_bug.cgi?id=71036

Reviewed by Pavel Feldman.

  • inspector/front-end/AdvancedSearchController.js:

(WebInspector.SearchView):

  • inspector/front-end/Images/statusbarButtonGlyphs.png:
  • inspector/front-end/inspector.css:

(.search-view .search-panel):
(.search-view .search-panel input[type="search"].search-config-search):
(.search-view .search-panel input[type="checkbox"].search-config-checkbox):
(body:not(.platform-mac) .search-view .search-panel input[type="checkbox"].search-config-checkbox):
(body.platform-mac .search-view .search-panel input[type="checkbox"].search-config-checkbox):
(#drawer-status-bar .search-status-bar-progress):
(body:not(.platform-mac) #drawer-status-bar .search-status-bar-progress):
(body.platform-mac #drawer-status-bar .search-status-bar-progress):

2:29 PM Changeset in webkit [98639] by eric@webkit.org
  • 5 edits in trunk/Tools

REGRESSION (NRWT): build.webkit.org doesn't show the total number of leaks found during a test run on the Leaks bot
​https://bugs.webkit.org/show_bug.cgi?id=66227

Reviewed by Adam Roben.

I believe this should fix the bug.

  • Scripts/run-webkit-tests: make NRWT default for --leaks
  • Scripts/webkitpy/layout_tests/port/leakdetector.py:

(LeakDetector._parse_leaks_output): removed the (unneeded) process_pid argument, and made the regexp use named groups (even though we don't ever grab them by name)
(LeakDetector.count_total_bytes_and_unique_leaks): renamed from parse_leak_files
(LeakDetector.count_total_leaks): new file (the guts of this change) which is used to re-parse the leaks output during the summarize leaks phase.

  • Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:

Changes to reflect the rename of count_total_bytes_and_unique_leaks and a new test for count_total_leaks.

  • Scripts/webkitpy/layout_tests/port/mac.py:

Use count_total_leaks to spit out the total leak count like ORWT did, and remove the FIXME on the subject.

2:21 PM Changeset in webkit [98638] by hyatt@apple.com
  • 13 edits
    5 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=71061

[CSS Line Grid] Add support for parsing the line-grid property.

Source/WebCore:

New tests in fast/line-grid.

Reviewed by Dan Bernstein.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::lineGrid):
(WebCore::InheritedFlags::setLineGrid):
(WebCore::InheritedFlags::initialLineGrid):

  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h:

LayoutTests:

Reviewed by Dan Bernstein.

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/line-grid: Added.
  • fast/line-grid/line-grid-parsing-expected.txt: Added.
  • fast/line-grid/line-grid-parsing.html: Added.
  • fast/line-grid/script-tests: Added.
  • fast/line-grid/script-tests/line-grid-parsing.js: Added.
2:09 PM Changeset in webkit [98637] by fsamuel@chromium.org
  • 3 edits
    4 adds in trunk

iframes seem to occasionally doubly scale or scale incorrectly when pageScaleFactor != 1.0
​https://bugs.webkit.org/show_bug.cgi?id=70552

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/frames/iframe-double-scale-contents.html

The iframe's document style was using the page's scale factor, rather than the frame's (1.0).
If the page scale factor was set after layout was complete, then this would have no impact because the iframe's document style and layout is not recomputed,
but if the page scale factor is set prior to creating and laying out the iframe, the iframe's content would be doubly scaled.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForDocument):

LayoutTests:

  • fast/frames/iframe-double-scale-contents-expected.png: Added.
  • fast/frames/iframe-double-scale-contents-expected.txt: Added.
  • fast/frames/iframe-double-scale-contents.html: Added.
  • fast/frames/resources/iframe-content-scaling-bug-iframe.html: Added.
2:04 PM Changeset in webkit [98636] by reed@google.com
  • 2 edits in trunk/LayoutTests

test_rebaseline_expectations failing
​https://bugs.webkit.org/show_bug.cgi?id=71033

Reviewed by Adam Barth.

Resolve overlaps

  • platform/chromium/test_expectations.txt:
1:55 PM Changeset in webkit [98635] by mitz@apple.com
  • 4 edits in trunk/LayoutTests

Updated expected results after r98608.

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
1:53 PM Changeset in webkit [98634] by commit-queue@webkit.org
  • 15 edits
    12 adds in trunk

[Chromium] Need setPrinting
​https://bugs.webkit.org/show_bug.cgi?id=46152

Patch by Stephen Chenney <​schenney@chromium.org> on 2011-10-27
Reviewed by Hajime Morita.

Source/WebKit/chromium:

  • public/WebFrame.h: Added pure virtual prototype for printPagesWithBoundaries. Added enum

and changed parameters for renderTreeAsText.

  • src/WebFrameImpl.cpp:

(WebKit::ChromePrintContext::spoolAllPagesWithBoundaries): Added this method, based on
the static in PrintContext. This uses Chromium specific page spooling and transforms.
(WebKit::WebFrameImpl::renderTreeAsText): Updated to allow text dump in printed format.
(WebKit::WebFrameImpl::printPagesWithBoundaries): Added method for testing printing page
breaks.

  • src/WebFrameImpl.h: Added prototype.

Tools:

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController): Added logic for handling setPrinting.
(LayoutTestController::reset): Clearing flags for setPrinting.
(LayoutTestController::setPrinting): Set flags for setPrinting.

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController::setIsPrinting): Added the setPrinting methods and flags.
(LayoutTestController::isPrinting): Method to return the setPrinting status.

  • DumpRenderTree/chromium/TestShell.cpp:

(dumpFramesAsPrintedText): A method for creating a text dump in printed layout.
(TestShell::dump): Modified to dump setPrinting-specific output.

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::paintPagesWithBoundaries): Handling for pixel tests when setPrinting is
active.

  • DumpRenderTree/chromium/WebViewHost.h: Prototype for paintPagesWithBoundaries.

LayoutTests:

  • platform/chromium/test_expectations.txt: Removing setPrinting tests from the expected failures.
  • platform/chromium-linux/printing/setPrinting-expected.png: Added.
  • platform/chromium-linux/printing/setPrinting-expected.txt: Added.
  • platform/chromium-linux/printing/single-line-must-not-be-split-into-two-pages-expected.png: Added.
  • platform/chromium-linux/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Added.
  • platform/chromium-mac/printing/setPrinting-expected.png: Added.
  • platform/chromium-mac/printing/setPrinting-expected.txt: Added.
  • platform/chromium-mac/printing/single-line-must-not-be-split-into-two-pages-expected.png: Added.
  • platform/chromium-mac/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Added.
  • platform/chromium-win/printing/setPrinting-expected.png: Added.
  • platform/chromium-win/printing/setPrinting-expected.txt: Added.
  • platform/chromium-win/printing/single-line-must-not-be-split-into-two-pages-expected.png: Added.
  • platform/chromium-win/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Added.
  • platform/mac/printing/setPrinting-expected.png: Rebaselined for the change to the test html.
  • platform/mac/printing/setPrinting-expected.txt: Rebaselined for the change to the test html.
  • printing/setPrinting.html: Modified the test to make the box have a colored border instead of the solid background, as the solid background does not print on chromium.
1:52 PM Changeset in webkit [98633] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

1:43 PM Changeset in webkit [98632] by leandro@webkit.org
  • 1 edit
    181 adds in trunk/LayoutTests

[EFL] Unreviewed. Add pixel test baselines for animations,
compositing, dom, editing, fonts, mathml, media, printing,
transforms and transitions.

  • platform/efl/animations: [...]
  • platform/efl/compositing: [...]
  • platform/efl/dom: [...]
  • platform/efl/editing: [...]
  • platform/efl/fonts: [...]
  • platform/efl/mathml: [...]
  • platform/efl/media: [...]
  • platform/efl/printing: [...]
  • platform/efl/transforms: [...]
  • platform/efl/transitions: [...]
1:42 PM Changeset in webkit [98631] by nduca@chromium.org
  • 4 edits in trunk/Source

Unreviewed, fix CCSchedulerStateMachine build errors.

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:
  • platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
1:41 PM Changeset in webkit [98630] by jamesr@google.com
  • 8 edits
    1 add in trunk/Source

Fix teardown in Web*LayerImpl, and add tests for Web*Layer
​https://bugs.webkit.org/show_bug.cgi?id=70431

Patch by Antoine Labour <​piman@chromium.org> on 2011-10-27
Reviewed by James Robinson.

  • src/WebContentLayerImpl.cpp:

(WebKit::WebContentLayerImpl::~WebContentLayerImpl):

  • src/WebExternalTextureLayerImpl.cpp:

(WebKit::WebExternalTextureLayerImpl::~WebExternalTextureLayerImpl):

  • src/WebLayerImpl.cpp:

(WebKit::WebLayerImpl::~WebLayerImpl):

1:40 PM Changeset in webkit [98629] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Fix building on GNU/kFreeBSD
​https://bugs.webkit.org/show_bug.cgi?id=71005

Patch by Gustavo Noronha Silva <Gustavo Noronha Silva> on 2011-10-27
Reviewed by Darin Adler.

  • config.h:
  • wtf/Platform.h:
1:30 PM Changeset in webkit [98628] by tony@chromium.org
  • 3 edits
    4 adds in trunk

fix sizing of auto sized flexbox
​https://bugs.webkit.org/show_bug.cgi?id=70839

Reviewed by David Hyatt.

Source/WebCore:

Correctly set the height of the flexbox when we have a column flow
and the height is auto.

Tests: css3/flexbox/columns-auto-size.html

css3/flexbox/flex-flow-margins-auto-size.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock): Always computeLogicalHeight() after we're done placing children.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection): Set the height as we place children.

LayoutTests:

  • css3/flexbox/columns-auto-size-expected.txt: Added.
  • css3/flexbox/columns-auto-size.html: Added.
  • css3/flexbox/flex-flow-margins-auto-size-expected.txt: Added.
  • css3/flexbox/flex-flow-margins-auto-size.html: Added.

A bunch of these cases fail, but that's because of bug 70769.

1:28 PM Changeset in webkit [98627] by vangelis@chromium.org
  • 9 edits
    2 adds in trunk

Source/WebCore: Add support for creating compositing layers for fixed position elements.
​https://bugs.webkit.org/show_bug.cgi?id=69796

position:fixed elements will get a compositing layer if:

  1. Settings:acceleratedCompositingForFixedPositionEnabled() returns true,
  2. The element has its own stacking context (e.g. has a z-index), and
  3. The element's container is the RenderView (e.g. not a descendant of a transformed element)

Reviewed by Simon Fraser.

Test: compositing/geometry/fixed-position-composited-switch.html

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setAcceleratedCompositingForFixedPositionEnabled):
(WebCore::Settings::acceleratedCompositingForFixedPositionEnabled):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::requiresCompositingLayer):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):

  • rendering/RenderLayerCompositor.h:
  • testing/Internals.cpp:

(WebCore::Internals::setEnableCompositingForFixedPosition):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests: Adding tests for fixed positioned elements getting their own composited layer.
​https://bugs.webkit.org/show_bug.cgi?id=69796

Reviewed by Simon Fraser.

  • compositing/geometry/fixed-position-composited-switch-expected.txt: Added.
  • compositing/geometry/fixed-position-composited-switch.html: Added.
1:20 PM Changeset in webkit [98626] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=70390
Ensure font load for Skia backend during printing.

Patch by Arthur Hsu <​arthurhsu@chromium.org> on 2011-10-27
Reviewed by James Robinson.

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::Font::drawGlyphs):

  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::paintSkiaText):

1:19 PM Changeset in webkit [98625] by Lucas Forschler
  • 5 edits in branches/safari-534.52-branch/Source

Versioning.

1:16 PM Changeset in webkit [98624] by msaboff@apple.com
  • 29 edits in trunk/Source

Investigate storing strings in 8-bit buffers when possible
​https://bugs.webkit.org/show_bug.cgi?id=66161

Source/JavaScriptCore:

Investigate storing strings in 8-bit buffers when possible
​https://bugs.webkit.org/show_bug.cgi?id=66161

Added support for 8 bit string data in StringImpl. Changed
(UChar*) m_data to m_data16. Added char* m_data8 as a union
with m_data16. Added UChar* m_copyData16 to the other union
to store a 16 bit copy of an 8 bit string when needed.
Added characters8() and characters16() accessor methods
that assume the caller has checked the underlying string type
via the new is8Bit() method. The characters() method will
return a UChar* of the string, materializing a 16 bit copy if the
string is an 8 bit string. Added two flags, one for 8 bit buffer
and a second for a 16 bit copy for an 8 bit string.

Fixed method name typo (StringHasher::defaultCoverter()).

Over time the goal is to eliminate calls to characters() and
us the character8() and characters16() accessors.

This patch does not include changes that actually create 8 bit
strings. This is the first of at least 8 patches. Subsequent
patches will be submitted for JIT changes, making the JSC lexer,
parser and literal parser, JavaScript string changes and
then changes in webcore to take advantage of the 8 bit strings.

This change is performance neutral for SunSpider and V8 when
run from the command line with "jsc".

Reviewed by Geoffrey Garen.

(JSC::Interpreter::callEval):

  • parser/SourceProvider.h:

(JSC::UStringSourceProvider::data):
(JSC::UStringSourceProvider::UStringSourceProvider):

  • runtime/Identifier.cpp:

(JSC::IdentifierCStringTranslator::hash):
(JSC::IdentifierCStringTranslator::equal):
(JSC::IdentifierCStringTranslator::translate):
(JSC::Identifier::add):
(JSC::Identifier::toUInt32):

  • runtime/Identifier.h:

(JSC::Identifier::equal):
(JSC::operator==):
(JSC::operator!=):

  • runtime/JSString.cpp:

(JSC::JSString::resolveRope):
(JSC::JSString::resolveRopeSlowCase):

  • runtime/RegExp.cpp:

(JSC::RegExp::match):

  • runtime/StringPrototype.cpp:

(JSC::jsSpliceSubstringsWithSeparators):

  • runtime/UString.cpp:

(JSC::UString::UString):
(JSC::equalSlowCase):
(JSC::UString::utf8):

  • runtime/UString.h:

(JSC::UString::characters):
(JSC::UString::characters8):
(JSC::UString::characters16):
(JSC::UString::is8Bit):
(JSC::UString::operator[]):
(JSC::UString::find):
(JSC::operator==):

  • wtf/StringHasher.h:

(WTF::StringHasher::computeHash):
(WTF::StringHasher::defaultConverter):

  • wtf/text/AtomicString.cpp:

(WTF::CStringTranslator::hash):
(WTF::CStringTranslator::equal):
(WTF::CStringTranslator::translate):
(WTF::AtomicString::add):

  • wtf/text/AtomicString.h:

(WTF::AtomicString::AtomicString):
(WTF::AtomicString::contains):
(WTF::AtomicString::find):
(WTF::AtomicString::add):
(WTF::operator==):
(WTF::operator!=):
(WTF::equalIgnoringCase):

  • wtf/text/StringConcatenate.h:
  • wtf/text/StringHash.h:

(WTF::StringHash::equal):
(WTF::CaseFoldingHash::hash):

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::~StringImpl):
(WTF::StringImpl::createUninitialized):
(WTF::StringImpl::create):
(WTF::StringImpl::getData16SlowCase):
(WTF::StringImpl::containsOnlyWhitespace):
(WTF::StringImpl::substring):
(WTF::StringImpl::characterStartingAt):
(WTF::StringImpl::lower):
(WTF::StringImpl::upper):
(WTF::StringImpl::fill):
(WTF::StringImpl::foldCase):
(WTF::StringImpl::stripMatchedCharacters):
(WTF::StringImpl::removeCharacters):
(WTF::StringImpl::simplifyMatchedCharactersToSpace):
(WTF::StringImpl::toIntStrict):
(WTF::StringImpl::toUIntStrict):
(WTF::StringImpl::toInt64Strict):
(WTF::StringImpl::toUInt64Strict):
(WTF::StringImpl::toIntPtrStrict):
(WTF::StringImpl::toInt):
(WTF::StringImpl::toUInt):
(WTF::StringImpl::toInt64):
(WTF::StringImpl::toUInt64):
(WTF::StringImpl::toIntPtr):
(WTF::StringImpl::toDouble):
(WTF::StringImpl::toFloat):
(WTF::equal):
(WTF::equalIgnoringCase):
(WTF::StringImpl::find):
(WTF::StringImpl::findIgnoringCase):
(WTF::StringImpl::reverseFind):
(WTF::StringImpl::replace):
(WTF::StringImpl::defaultWritingDirection):
(WTF::StringImpl::adopt):
(WTF::StringImpl::createWithTerminatingNullCharacter):

  • wtf/text/StringImpl.h:

(WTF::StringImpl::StringImpl):
(WTF::StringImpl::create):
(WTF::StringImpl::create8):
(WTF::StringImpl::tryCreateUninitialized):
(WTF::StringImpl::flagsOffset):
(WTF::StringImpl::flagIs8Bit):
(WTF::StringImpl::dataOffset):
(WTF::StringImpl::is8Bit):
(WTF::StringImpl::characters8):
(WTF::StringImpl::characters16):
(WTF::StringImpl::characters):
(WTF::StringImpl::has16BitShadow):
(WTF::StringImpl::setHash):
(WTF::StringImpl::hash):
(WTF::StringImpl::copyChars):
(WTF::StringImpl::operator[]):
(WTF::StringImpl::find):
(WTF::StringImpl::findIgnoringCase):
(WTF::equal):
(WTF::equalIgnoringCase):
(WTF::StringImpl::isolatedCopy):

  • wtf/text/WTFString.cpp:

(WTF::String::String):
(WTF::String::append):
(WTF::String::format):
(WTF::String::fromUTF8):
(WTF::String::fromUTF8WithLatin1Fallback):

  • wtf/text/WTFString.h:

(WTF::String::find):
(WTF::String::findIgnoringCase):
(WTF::String::contains):
(WTF::String::append):
(WTF::String::fromUTF8):
(WTF::String::fromUTF8WithLatin1Fallback):
(WTF::operator==):
(WTF::operator!=):
(WTF::equalIgnoringCase):

  • wtf/unicode/Unicode.h:
  • yarr/YarrJIT.cpp:

(JSC::Yarr::execute):

  • yarr/YarrJIT.h:

(JSC::Yarr::YarrCodeBlock::execute):

  • yarr/YarrParser.h:

(JSC::Yarr::Parser::Parser):

Source/WebCore:

Changes to support 8 bit StringImpl changes.

Reviewed by Geoffrey Garen.

No new tests, refactored StringImpl for 8 bit strings.

  • platform/text/cf/StringImplCF.cpp:

(WTF::StringImpl::createCFString):

Source/WebKit2:

Added export of StringImpl::getData16SlowCase for linking tests.

Reviewed by Geoffrey Garen.

  • win/WebKit2.def:
1:08 PM Changeset in webkit [98623] by johnnyg@google.com
  • 1 edit
    21 adds
    1 delete in trunk/LayoutTests

Unreviewed, more chromium baselines for new multicol tests.

  • platform/chromium-cg-mac-snowleopard/fast/multicol/block-axis-horizontal-bt-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/multicol/block-axis-horizontal-tb-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/multicol/block-axis-vertical-lr-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/multicol/block-axis-vertical-rl-expected.png: Added.
  • platform/chromium-linux-x86/fast/multicol: Removed.
  • platform/chromium-linux/fast/multicol/block-axis-horizontal-bt-expected.png: Added.
  • platform/chromium-linux/fast/multicol/block-axis-horizontal-tb-expected.png: Added.
  • platform/chromium-linux/fast/multicol/block-axis-vertical-lr-expected.png: Added.
  • platform/chromium-linux/fast/multicol/block-axis-vertical-rl-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/block-axis-horizontal-bt-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/block-axis-horizontal-tb-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/block-axis-vertical-lr-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/block-axis-vertical-rl-expected.png: Added.
  • platform/chromium-win/fast/multicol/block-axis-horizontal-bt-expected.png: Added.
  • platform/chromium-win/fast/multicol/block-axis-horizontal-bt-expected.txt: Added.
  • platform/chromium-win/fast/multicol/block-axis-horizontal-tb-expected.png: Added.
  • platform/chromium-win/fast/multicol/block-axis-horizontal-tb-expected.txt: Added.
  • platform/chromium-win/fast/multicol/block-axis-vertical-lr-expected.png: Added.
  • platform/chromium-win/fast/multicol/block-axis-vertical-lr-expected.txt: Added.
  • platform/chromium-win/fast/multicol/block-axis-vertical-rl-expected.png: Added.
  • platform/chromium-win/fast/multicol/block-axis-vertical-rl-expected.txt: Added.
1:01 PM Changeset in webkit [98622] by weinig@apple.com
  • 5 edits in trunk

Add allowsPlugIns property to WKBrowsingContextGroup
​https://bugs.webkit.org/show_bug.cgi?id=70987

Reviewed by Anders Carlsson.

Source/WebKit2:

Test: WKBrowsingContextGroupTest.GetSetPluginsEnabled

  • UIProcess/API/mac/WKBrowsingContextGroup.h:
  • UIProcess/API/mac/WKBrowsingContextGroup.mm:

(-[WKBrowsingContextGroup allowsJavaScript]):
(-[WKBrowsingContextGroup setAllowsJavaScript:]):
Rename to allowsJavaScript/setAllowsJavaScript.

(-[WKBrowsingContextGroup allowsPlugIns]):
(-[WKBrowsingContextGroup setAllowsPlugIns:]):
Add allowsPlugIns/setAllowsPlugIns.

Tools:

  • TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:

Add basic test for WKBrowsingContextGroup.allowsPlugIns.

1:01 PM Changeset in webkit [98621] by Lucas Forschler
  • 1 copy in tags/Safari-534.52.5

New tag.

12:57 PM Changeset in webkit [98620] by johnnyg@google.com
  • 4 edits
    8 adds in trunk/LayoutTests

Unreviewed, rebaselines after multi-col changes.

  • platform/chromium-win-vista/fast/css/getComputedStyle: Added.
  • platform/chromium-win-vista/fast/css/getComputedStyle/computed-style-expected.txt: Added.
  • platform/chromium-win-xp/fast/css/getComputedStyle: Added.
  • platform/chromium-win-xp/fast/css/getComputedStyle/computed-style-expected.txt: Added.
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium/fast/css/getComputedStyle/computed-style-expected.txt: Added.
  • platform/chromium/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Added.
  • platform/chromium/svg/css: Added.
  • platform/chromium/svg/css/getComputedStyle-basic-expected.txt: Added.
12:52 PM Changeset in webkit [98619] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Failure to build when QT_NO_MENU defined
​https://bugs.webkit.org/show_bug.cgi?id=70970

Patch by Helder Correia <​helder.correia@palm.com> on 2011-10-27
Reviewed by Andreas Kling.

iterateContextMenu() must be wrapped around #ifndef QT_NO_MENU.

Build fix, no new tests.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
12:33 PM Changeset in webkit [98618] by nduca@chromium.org
  • 4 edits
    3 adds in trunk/Source

[chromium] Encapsulate state machine parts of scheduling in CCSchedulerStateMachine
​https://bugs.webkit.org/show_bug.cgi?id=70714

Source/WebCore:

Reland of ill-fated r98612.

Reviewed by James Robinson.

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp: Added.

(WebCore::CCSchedulerStateMachine::nextAction):
(WebCore::CCSchedulerStateMachine::updateState):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.h: Added.

(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::operator=):
(WebCore::CCSchedulerStateMachine::commitPending):
(WebCore::CCSchedulerStateMachine::setNeedsRedraw):
(WebCore::CCSchedulerStateMachine::setNeedsCommit):
(WebCore::CCSchedulerStateMachine::beginFrameComplete):
(WebCore::CCSchedulerStateMachine::updateResourcesComplete):

Source/WebKit/chromium:

Reviewed by James Robinson.

  • WebKit.gypi:
  • tests/CCSchedulerStateMachineTest.cpp: Added.

(WebCore::StateMachine::setCommitState):
(WebCore::StateMachine::commitState):
(WebCore::StateMachine::setNeedsCommit):
(WebCore::StateMachine::needsCommit):
(WebCore::StateMachine::setNeedsRedraw):
(WebCore::StateMachine::needsRedraw):
(WebCore::StateMachine::setUpdatedThisFrame):
(WebCore::StateMachine::updatedThisFrame):
(WebCore::TEST):

12:22 PM Changeset in webkit [98617] by podivilov@chromium.org
  • 12 edits in trunk

Get rid of optional parameters in the middle in IDLs.
​https://bugs.webkit.org/show_bug.cgi?id=70816

Reviewed by Adam Barth.

Optional parameters in the middle are prohibited by WebIDL spec.

Source/WebCore:

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateArgumentsCountCheck):
(GenerateImplementation):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):

  • html/canvas/CanvasRenderingContext2D.idl:
  • page/DOMWindow.idl:

LayoutTests:

  • fast/canvas/canvas-putImageData-expected.txt: expectation was wrong, context.putImageData({}, 0, 0) should throw Type Error.
  • fast/canvas/canvas-putImageData.js:
12:16 PM Changeset in webkit [98616] by johnnyg@google.com
  • 2 edits in trunk/LayoutTests

unreviewed, test expectations

  • platform/chromium/test_expectations.txt:
12:15 PM Changeset in webkit [98615] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

REGRESSION(r98542): tables/mozilla_expected_failures/bugs/bug14007-2.html
​https://bugs.webkit.org/show_bug.cgi?id=71032

Reviewed by Dave Hyatt.

If we apply an explicitly inherited property, we need to apply any further
non-inherited properties as the property might get overridden again.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForKeyframe):
(WebCore::CSSStyleSelector::styleForPage):
(WebCore::CSSStyleSelector::applyDeclaration):
(WebCore::CSSStyleSelector::applyDeclarations):

  • css/CSSStyleSelector.h:
12:12 PM Changeset in webkit [98614] by jchaffraix@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove RenderTableSection::m_gridRows
​https://bugs.webkit.org/show_bug.cgi?id=70570

Reviewed by Darin Adler.

No new test, refactoring only.

Just nuke the old field that was duplicating
m_grid.size().

  • rendering/RenderTableSection.h:

(WebCore::RenderTableSection::numRows):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::RenderTableSection):
(WebCore::RenderTableSection::ensureRows):
(WebCore::RenderTableSection::setCellLogicalWidths):
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::calcOuterBorderBefore):
(WebCore::RenderTableSection::calcOuterBorderAfter):
(WebCore::RenderTableSection::calcOuterBorderStart):
(WebCore::RenderTableSection::calcOuterBorderEnd):
(WebCore::RenderTableSection::firstLineBoxBaseline):
(WebCore::RenderTableSection::paint):
(WebCore::RenderTableSection::paintObject):
(WebCore::RenderTableSection::clearGrid):
(WebCore::RenderTableSection::numColumns):
(WebCore::RenderTableSection::appendColumn):
(WebCore::RenderTableSection::splitColumn):
s/m_gridRows/m_grid.size()/.
Also updated the code as m_grid.size() is unsigned.

(WebCore::RenderTableSection::recalcCells):
The old code would keep the grid's memory but we have to clear it to properly
count the elements. To avoid lots of small reallocations, we reallocate the
buffer at the old capacity upfront.

11:45 AM Changeset in webkit [98613] by nduca@chromium.org
  • 4 edits
    3 deletes in trunk/Source

Unreviewed, rolling out r98612.
​http://trac.webkit.org/changeset/98612
​https://bugs.webkit.org/show_bug.cgi?id=70714

Broke build

Source/WebCore:

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp: Removed.
  • platform/graphics/chromium/cc/CCSchedulerStateMachine.h: Removed.

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCSchedulerStateMachineTest.cpp: Removed.
11:29 AM Changeset in webkit [98612] by nduca@chromium.org
  • 4 edits
    3 adds in trunk/Source

[chromium] Encapsulate state machine parts of scheduling in CCSchedulerStateMachine
​https://bugs.webkit.org/show_bug.cgi?id=70714

Reviewed by James Robinson.

Source/WebCore:

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp: Added.

(WebCore::CCSchedulerStateMachine::nextAction):
(WebCore::CCSchedulerStateMachine::updateState):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.h: Added.

(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::operator=):
(WebCore::CCSchedulerStateMachine::commitPending):
(WebCore::CCSchedulerStateMachine::setNeedsRedraw):
(WebCore::CCSchedulerStateMachine::setNeedsCommit):
(WebCore::CCSchedulerStateMachine::beginFrameComplete):
(WebCore::CCSchedulerStateMachine::updateResourcesComplete):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCSchedulerStateMachineTest.cpp: Added.

(WebCore::StateMachine::setCommitState):
(WebCore::StateMachine::commitState):
(WebCore::StateMachine::setNeedsCommit):
(WebCore::StateMachine::needsCommit):
(WebCore::StateMachine::setNeedsRedraw):
(WebCore::StateMachine::needsRedraw):
(WebCore::StateMachine::setUpdatedThisFrame):
(WebCore::StateMachine::updatedThisFrame):
(WebCore::TEST):

11:27 AM Changeset in webkit [98611] by Lucas Forschler
  • 1 copy in tags/Safari-535.7

New tag.

11:13 AM Changeset in webkit [98610] by Lucas Forschler
  • 2 edits in branches/safari-534.52-branch/Source/WebCore

Merged r98530.

11:11 AM Changeset in webkit [98609] by Lucas Forschler
  • 2 edits in branches/safari-534.52-branch/Source/WebKit2

Merged r98526.

10:59 AM Changeset in webkit [98608] by mitz@apple.com
  • 15 edits
    15 adds in trunk

<rdar://problem/10262205> Allow column progression to be independent of writing mode
​https://bugs.webkit.org/show_bug.cgi?id=71028

Reviewed by Darin Adler.

Source/WebCore:

Tests: fast/multicol/block-axis-horizontal-bt.html

fast/multicol/block-axis-horizontal-tb.html
fast/multicol/block-axis-vertical-lr.html
fast/multicol/block-axis-vertical-rl.html
fast/multicol/flipped-blocks-hit-test.html

Allow “columns” to be stacked along the block axis rather than the inline axis. This can facilitate
paginated interfaces. A column-axis property is added in order to enable this mode.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Handle the column-axis property.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Ditto.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Map ColumnAxis values to identifiers.
(WebCore::CSSPrimitiveValue::operator ColumnAxis): Map identifiers to ColumnAxis values.

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty): Updated to return false for the column-axis property.

  • css/CSSPropertyNames.in: Added -webkit-column-axis.
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty): Handle column-axis.

  • rendering/ColumnInfo.h:

(WebCore::ColumnInfo::ColumnInfo): Added m_progressionAxis to the initialization list.
(WebCore::ColumnInfo::progressionAxis): Added this getter.
(WebCore::ColumnInfo::setProgressionAxis): Added this setter.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addOverflowFromChildren): Simplified, and thus also made this function work
with block-axis column progression.
(WebCore::RenderBlock::paintColumnRules): Added code to paint rules between columns with block-axis
progression.
(WebCore::RenderBlock::paintColumnContents): Adjusted the painting offset for the block-axis
column progression case.
(WebCore::RenderBlock::nodeAtPoint): Fixed hit-testing in flipped-blocks writing modes. This is
covered by flipped-blocks-hit-test.html.
(WebCore::RenderBlock::hitTestColumns): Adjusted the offset for the block-axis column progression
case.
(WebCore::RenderBlock::calcColumnWidth): Set the column width to the content logical width in
the block-axis column progression case. The column-width and column-count properties are ignored.
(WebCore::RenderBlock::setDesiredColumnCountAndWidth): Set the column progression axis based on
the style.
(WebCore::RenderBlock::columnCount): Broke up an assertion into two.
(WebCore::RenderBlock::columnRectAt): Updated for block-axis column progression.
(WebCore::RenderBlock::adjustPointToColumnContents): Ditto.
(WebCore::RenderBlock::adjustRectForColumns): Ditto.
(WebCore::RenderBlock::adjustForColumns): Ditto.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintChildLayerIntoColumns): Adjusted the offser for the block-axis column
progression case.
(WebCore::RenderLayer::hitTestChildLayerColumns): Ditto.

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::columnAxis): Added this getter.
(WebCore::InheritedFlags::hasInlineColumnAxis): Added. Checks the column axis against the writing
mode.
(WebCore::InheritedFlags::specifiesColumns): Changed to return true if the specified column axis
is the block axis.
(WebCore::InheritedFlags::setColumnAxis): Added this setter.
(WebCore::InheritedFlags::initialColumnAxis): Added. Returns AutoColumnAxis.

  • rendering/style/RenderStyleConstants.h: Added a ColumnAxis enum.
  • rendering/style/StyleMultiColData.cpp:

(WebCore::StyleMultiColData::StyleMultiColData): Added m_axis to the initialization list.
(WebCore::StyleMultiColData::operator==): Compare m_axis.

  • rendering/style/StyleMultiColData.h: Added m_axis member variable.

LayoutTests:

  • fast/multicol/block-axis-horizontal-bt.html: Added.
  • fast/multicol/block-axis-horizontal-tb.html: Added.
  • fast/multicol/block-axis-vertical-lr.html: Added.
  • fast/multicol/block-axis-vertical-rl.html: Added.
  • fast/multicol/flipped-blocks-hit-test-expected.txt: Added.
  • fast/multicol/flipped-blocks-hit-test.html: Added.
  • fast/multicol/resources/block-axis.css: Added.
  • platform/mac/fast/multicol/block-axis-horizontal-bt-expected.png: Added.
  • platform/mac/fast/multicol/block-axis-horizontal-bt-expected.txt: Added.
  • platform/mac/fast/multicol/block-axis-horizontal-tb-expected.png: Added.
  • platform/mac/fast/multicol/block-axis-horizontal-tb-expected.txt: Added.
  • platform/mac/fast/multicol/block-axis-vertical-lr-expected.png: Added.
  • platform/mac/fast/multicol/block-axis-vertical-lr-expected.txt: Added.
  • platform/mac/fast/multicol/block-axis-vertical-rl-expected.png: Added.
  • platform/mac/fast/multicol/block-axis-vertical-rl-expected.txt: Added.
10:58 AM Changeset in webkit [98607] by johnnyg@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, adding additional expected failures.

  • platform/chromium/test_expectations.txt:
10:55 AM Changeset in webkit [98606] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fixing windows build

Unreviewed build fix

10:54 AM Changeset in webkit [98605] by Lucas Forschler
  • 12 edits in branches/safari-534.52-branch/Source

Merged r98503.

10:52 AM Changeset in webkit [98604] by Lucas Forschler
  • 4 edits in branches/safari-534.52-branch/Source/WebCore

Merge 98304.

10:46 AM Changeset in webkit [98603] by eae@chromium.org
  • 52 edits in branches/subpixellayout/Source

Mac/chromium and plugin fixes

10:42 AM Changeset in webkit [98602] by johnnyg@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, fixing duplicate entries in test expectations.

  • platform/chromium/test_expectations.txt:
10:38 AM Changeset in webkit [98601] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Add ability to check for presence of static members at compile time
​https://bugs.webkit.org/show_bug.cgi?id=70986

Reviewed by Geoffrey Garen.

Added new CREATE_MEMBER_CHECKER macro to instantiate the template and the
HAS_MEMBER_NAMED macro to use that template to check if the specified class
does indeed have a method with that name. This mechanism is not currently
used anywhere, but will be in the future when adding virtual methods from
JSObject to the MethodTable.

  • runtime/ClassInfo.h:
10:33 AM Changeset in webkit [98600] by mihnea@adobe.com
  • 8 edits
    3 adds in trunk

[CSSRegions]Flag regions with custom styling
​https://bugs.webkit.org/show_bug.cgi?id=70733

Reviewed by David Hyatt.

Region elements that have custom region styling are now marked accordingly.

Source/WebCore:

Test: fast/regions/render-region-custom-style-mark.html

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::checkRegionStyle):

  • css/CSSStyleSelector.h:
  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::styleDidChange):

  • rendering/RenderRegion.h:

(WebCore::RenderRegion::hasCustomRegionStyle):
(WebCore::RenderRegion::setHasCustomRegionStyle):

  • rendering/RenderTreeAsText.cpp:

(WebCore::writeRenderFlowThreads):

LayoutTests:

  • fast/regions/render-region-custom-style-mark.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac-snowleopard/fast/regions/render-region-custom-style-mark-expected.txt: Added.
10:27 AM Changeset in webkit [98599] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[Cairo] Implement ShareableBitmap::paint() when scaleFactor=1
​https://bugs.webkit.org/show_bug.cgi?id=71027

Reviewed by Martin Robinson.

Fixes windowless plugins in GTK+ port.

  • Shared/cairo/ShareableBitmapCairo.cpp:

(WebKit::ShareableBitmap::paint): When scaleFactor is 1, simply
call the paint method that doesn't receive a scaleFactor.

10:24 AM Changeset in webkit [98598] by commit-queue@webkit.org
  • 11 edits
    2 deletes in trunk

Unreviewed, rolling out r98556.
​http://trac.webkit.org/changeset/98556
​https://bugs.webkit.org/show_bug.cgi?id=71031

The test added by the patch doesn't pass on Snow Leopard
(Requested by rniwa on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-27

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

  • editing/TextCheckingHelper.cpp:

(WebCore::checkTextOfParagraph):

  • testing/Internals.cpp:
  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

  • editing/spelling/spelling-unified-emulation-expected.txt: Removed.
  • editing/spelling/spelling-unified-emulation.html: Removed.
10:22 AM Changeset in webkit [98597] by rniwa@webkit.org
  • 6 edits in trunk/LayoutTests

Temporarily skip tables/mozilla_expected_failures/bugs/bug14007-2.html on all platforms
since r98542 regressed it. The failure is tracked by the bug 71032.

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
10:19 AM Changeset in webkit [98596] by reed@google.com
  • 5 edits in trunk

[skia] replace offscreen technique with native support for antialiased clipping
​https://bugs.webkit.org/show_bug.cgi?id=70748

Reviewed by Stephen White.

~100 layout tests need to be rebaselined, as the native aa-clipping differs sometimes in the low
bits of the result. Other than that, the results should be the same, except that now the drawing
can go directly to the canvas, rather than being direct offscreen and then have that result
"clipped" during the restore. This has the effect of allowing LCD text to be drawing inside a
antialiased clip area.

Source/WebCore:

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::State::State):
(WebCore::PlatformContextSkia::State::cloneInheritedProperties):
(WebCore::PlatformContextSkia::clipPathAntiAliased):
(WebCore::PlatformContextSkia::restore):

  • platform/graphics/skia/PlatformContextSkia.h:

LayoutTests:

  • platform/chromium/test_expectations.txt:
10:17 AM Changeset in webkit [98595] by leandro@webkit.org
  • 1 edit
    951 adds in trunk/LayoutTests

[EFL] Unreviewed. Add pixel baselines for table tests.

  • platform/efl/tables: [...]
10:04 AM Changeset in webkit [98594] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

use main/cross instead of logical width/height when talking about flow direction
​https://bugs.webkit.org/show_bug.cgi?id=70977

Reviewed by Ojan Vafai.

Flexbox code uses logical in function names to refer to the flow
direction. This is confusing because writing mode also uses logical,
but this is a diffent usage. To avoid confusion, be explicit about
main vs cross axis. Extent is used instead of width/height.

No new tests, just a refactoring.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::mainAxisLengthForChild):
(WebCore::RenderFlexibleBox::crossAxisLength):
(WebCore::RenderFlexibleBox::setCrossExtent):
(WebCore::RenderFlexibleBox::crossExtentForChild):
(WebCore::RenderFlexibleBox::mainExtentForChild):
(WebCore::RenderFlexibleBox::crossAxisExtent):
(WebCore::RenderFlexibleBox::mainAxisExtent):
(WebCore::RenderFlexibleBox::crossAxisContentExtent):
(WebCore::RenderFlexibleBox::mainAxisContentExtent):
(WebCore::RenderFlexibleBox::crossAxisBorderAndPaddingExtent):
(WebCore::RenderFlexibleBox::crossAxisMarginExtentForChild):
(WebCore::RenderFlexibleBox::flowAwareLocationForChild):
(WebCore::RenderFlexibleBox::setFlowAwareLocationForChild):
(WebCore::RenderFlexibleBox::mainAxisBorderAndPaddingExtentForChild):
(WebCore::RenderFlexibleBox::mainAxisScrollbarExtentForChild):
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForFlexItem):
(WebCore::RenderFlexibleBox::layoutInlineDirection):
(WebCore::RenderFlexibleBox::positiveFlexForChild): Since flex only

matters in the main axis, there's no reason to deambiguate it here.

(WebCore::RenderFlexibleBox::negativeFlexForChild): Ditto.
(WebCore::RenderFlexibleBox::availableAlignmentSpaceForChild): Alignment is always

in the cross axis direction, so don't include that in the method name.

(WebCore::RenderFlexibleBox::marginBoxAscent):
(WebCore::RenderFlexibleBox::computePreferredMainAxisExtent):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithmInlineDirection):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
(WebCore::RenderFlexibleBox::adjustAlignmentForChild): Alignment is always

in the cross axis direction, so don't include that in the method name.

(WebCore::RenderFlexibleBox::alignChildrenBlockDirection):

  • rendering/RenderFlexibleBox.h:
10:01 AM Changeset in webkit [98593] by mhahnenberg@apple.com
  • 27 edits in trunk/Source

De-virtualize JSCell::toThisObject
​https://bugs.webkit.org/show_bug.cgi?id=70958

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Converted all instances of toThisObject to static functions,
added toThisObject to the MethodTable, and replaced all call sites
with a corresponding lookup in the MethodTable.

  • API/JSContextRef.cpp:
  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/ClassInfo.h:
  • runtime/JSActivation.cpp:

(JSC::JSActivation::toThisObject):

  • runtime/JSActivation.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::toThisObject):

  • runtime/JSCell.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::put):
(JSC::JSObject::toThisObject):

  • runtime/JSObject.h:

(JSC::JSValue::toThisObject):

  • runtime/JSStaticScopeObject.cpp:

(JSC::JSStaticScopeObject::toThisObject):

  • runtime/JSStaticScopeObject.h:
  • runtime/JSString.cpp:

(JSC::JSString::toThisObject):

  • runtime/JSString.h:
  • runtime/StrictEvalActivation.cpp:

(JSC::StrictEvalActivation::toThisObject):

  • runtime/StrictEvalActivation.h:

Source/WebCore:

No new tests.

Converted all instances of toThisObject to static functions,
added toThisObject to the MethodTable, and replaced all call sites
with a corresponding lookup in the MethodTable.

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::toThisObject):

  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSErrorHandler.cpp:

(WebCore::JSErrorHandler::handleEvent):

  • bridge/NP_jsobject.cpp:

(_NPN_Invoke):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeConnectionMethod::call):

Source/WebKit/mac:

Converted all instances of toThisObject to static functions,
added toThisObject to the MethodTable, and replaced all call sites
with a corresponding lookup in the MethodTable.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::invoke):
(WebKit::NetscapePluginInstanceProxy::invokeDefault):

Source/WebKit2:

Converted all instances of toThisObject to static functions,
added toThisObject to the MethodTable, and replaced all call sites
with a corresponding lookup in the MethodTable.

  • WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::invoke):

9:41 AM Changeset in webkit [98592] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Windows build fix after r98512

  • html/HTMLMediaElement.cpp: Moved a Web Audio-related #include inside an appropriate ENABLE

guard.

9:36 AM Changeset in webkit [98591] by Lucas Forschler
  • 2 edits in branches/safari-534.52-branch/Source/WebKit2

Merge 98394.

9:32 AM Changeset in webkit [98590] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Regenerate WebCore's Localizable.strings file

All I did was run update-webkit-localizable-strings. A few localizer comments changed, and
some strings (which must have been hand-added) got moved to a different part of the file.

  • English.lproj/Localizable.strings:
9:26 AM Changeset in webkit [98589] by Lucas Forschler
  • 10 edits in branches/safari-534.52-branch/Source/WebKit2

Merge 98369.

9:24 AM Changeset in webkit [98588] by Adam Roben
  • 7 edits
    3 adds in trunk

Add WKBundlePageGetBackingScaleFactor

Fixes <​http://webkit.org/b/71025> <rdar://problem/10355037> REGRESSION (r97191): Clients
can't reliably determine the scale factor of snapshots returned via
WKBundlePageCreateSnapshot* API

Reviewed by Sam Weinig.

Source/WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageGetBackingScaleFactor):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:

Added. Calls through to WebPage::deviceScaleFactor.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::deviceScaleFactor):

  • WebProcess/WebPage/WebPage.h:

Added. Calls through to Page::deviceScaleFactor.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
  • TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm: Added.

(TestWebKitAPI::didReceiveMessageFromInjectedBundle): Record the passed-back scale factor.
(TestWebKitAPI::setInjectedBundleClient): Hook up our didReceiveMessage callback.
(TestWebKitAPI::createWindow): Conjure up a window.
(TestWebKitAPI::TEST): Ask the injected bundle code to call the new
WKBundlePageGetBackingScaleFactor API when the WKView is in windows with various scale
factors and when using a custom scale factor, and check that we get those same scale factors
back.

  • TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm: Added.

(TestWebKitAPI::GetBackingScaleFactorTest::GetBackingScaleFactorTest): Just initialize our
members.
(TestWebKitAPI::GetBackingScaleFactorTest::didCreatePage): Store the page for later.
(TestWebKitAPI::GetBackingScaleFactorTest::didReceiveMessage): Get the backing scale factor
from the page using the new API and send it back.

9:18 AM Changeset in webkit [98587] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline.

  • platform/gtk/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
9:16 AM Changeset in webkit [98586] by kerz@chromium.org
  • 2 edits in branches/chromium/912/Source/WebCore

Merge 98112 - Fix Windows build.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::hasAnyAdditionalCompositedLayers):

TBR=Simon Fraser
Review URL: ​http://codereview.chromium.org/8399043

9:15 AM Changeset in webkit [98585] by kerz@chromium.org
  • 5 edits in branches/chromium/912

Merge 98060 - Hidden composited iframes cause infinite loop
​https://bugs.webkit.org/show_bug.cgi?id=52655

Source/WebCore:

Reviewed by Darin Adler.

visibility:hidden is problematic for compositing, because it causes
RenderLayers to be removed from the z-order layer tree. This confuses
RenderLayerCompositor in several ways; it never sees these layers
when traversing the tree as it computes compositing requirements, or
rebuilds the layer tree.

This is a particular problem with composited iframes. When an iframe
becomes composited, scheduleSetNeedsStyleRecalc() is called on that
iframe's ownerElement in the parent document. If this happens inside
Document::updateStyleForAllDocuments(), we get into an infinite loop
because notifyIFramesOfCompositingChange() queues up style update as we
bounce in and out of compositing mode, so documentsThatNeedStyleRecalc
never empties out.

This is an initial, conservative fix that doesn't attempt to fix all
the issues with visibility. It changes RenderLayerCompositor to count
the number of compositing RenderLayers, and to not leave compositing
mode if there are any (even if they are hidden, so not hit while
traversing the z-order tree). This avoids the infinite loop.

Test: compositing/visibility/hidden-iframe.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::ensureBacking):
(WebCore::RenderLayer::clearBacking):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::hasAnyAdditionalCompositedLayers):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):

  • rendering/RenderLayerCompositor.h:

(WebCore::RenderLayerCompositor::layerBecameComposited):
(WebCore::RenderLayerCompositor::layerBecameNonComposited):

LayoutTests:

Reviewed by Darin Adler.

Test with a visibility:hidden iframe, whose subframe becomes composited.

  • compositing/visibility/hidden-iframe-expected.txt: Added.
  • compositing/visibility/hidden-iframe.html: Added.

TBR=Simon Fraser
Review URL: ​http://codereview.chromium.org/8399041

9:00 AM Changeset in webkit [98584] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skipping 2 new failing tests in GTK.

  • platform/gtk/Skipped: Skip

fast/canvas/canvas-composite-image.html and editing/spelling/spelling-unified-emulation.html.

8:47 AM Changeset in webkit [98583] by vsevik@chromium.org
  • 2 edits
    3 copies in branches/chromium/912

Merge 98454 - Web Inspector: Debugger fails when there is an invalid watch expression.
​https://bugs.webkit.org/show_bug.cgi?id=70718

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/watch-expressions-panel-switch.html

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):

LayoutTests:

  • inspector/debugger/error-in-watch-expressions.html:
  • inspector/debugger/watch-expressions-panel-switch-expected.txt: Added.
  • inspector/debugger/watch-expressions-panel-switch.html: Added.
  • platform/chromium/inspector/debugger/watch-expressions-panel-switch-expected.txt: Added.

BUG=101496
TBR=​vsevik@chromium.org
Review URL: ​http://codereview.chromium.org/8401034

8:43 AM Changeset in webkit [98582] by Lucas Forschler
  • 3 edits in branches/safari-534.52-branch/Source/WebKit/mac

Merge 95534.

8:41 AM Changeset in webkit [98581] by yurys@chromium.org
  • 5 edits
    8 adds
    1 delete in trunk/LayoutTests

2011-10-27 Yury Semikhatsky <​yurys@chromium.org>

Rebaseline tables/mozilla_expected_failures/bugs/bug14007-2.html after r98542.

  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png: Added.
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png: Removed.
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
  • platform/chromium/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt: Added.
8:24 AM Changeset in webkit [98580] by commit-queue@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

Microdata: Add test cases for itemscope attribute.
​https://bugs.webkit.org/show_bug.cgi?id=71014

Patch by Arko Saha <​arko@motorola.com> on 2011-10-27
Reviewed by Ryosuke Niwa.

  • fast/dom/MicroData/itemscope-attribute-test-expected.txt: Added.
  • fast/dom/MicroData/itemscope-attribute-test.html: Added.
  • fast/dom/MicroData/itemscope-must-be-read-write-expected.txt: Added.
  • fast/dom/MicroData/itemscope-must-be-read-write.html: Added.
8:19 AM Changeset in webkit [98579] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[Qt][WK2]Add setViewportSize API to WebKit2.
​https://bugs.webkit.org/show_bug.cgi?id=71006

Patch by Zalan Bujtas <​zbujtas@gmail.com> on 2011-10-27
Reviewed by Kenneth Rohde Christiansen.

Fixed layout rendering needs the viewport size information on the WebProcess
side to be able to do viewport attribute calculations.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setViewportSize):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::viewportSize):

  • WebProcess/WebPage/WebPage.messages.in:
8:14 AM Changeset in webkit [98578] by dcheng@chromium.org
  • 3 edits in trunk/Source/WebCore

Clean up MicroDataItemValue to use const String& instead of String
​https://bugs.webkit.org/show_bug.cgi?id=70978

Reviewed by Tony Chang.

  • html/MicroDataItemValue.cpp:

(WebCore::MicroDataItemValue::MicroDataItemValue):

  • html/MicroDataItemValue.h:
8:12 AM Changeset in webkit [98577] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2011-10-27 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
8:09 AM Changeset in webkit [98576] by kbalazs@webkit.org
  • 2 edits in trunk/Tools

MiniBrowser crashes when started with 0 arguments

Rubber-stamped by Simon Hausmann.

  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::handleUserOptions):
Fix typo error.

8:06 AM Changeset in webkit [98575] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WebSocket] update pywebsocket to 0.7.
​https://bugs.webkit.org/show_bug.cgi?id=70992

Patch by Takashi Toyoshima <​toyoshim@chromium.org> on 2011-10-27
Reviewed by Kent Tamura.

pywebsocket 0.7 fixed the bug on dual stack support on OS X.

  • Scripts/webkitpy/thirdparty/init.py:
8:05 AM Changeset in webkit [98574] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix a small bug in callOperation after r98431
​https://bugs.webkit.org/show_bug.cgi?id=70984

Patch by Yuqiang Xian <​yuqiang.xian@intel.com> on 2011-10-27
Reviewed by Geoffrey Garen.

TrustedImmPtr is not expecting "int" type parameters.

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::callOperation):

8:03 AM Changeset in webkit [98573] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Use StringHasher to generate the matched declaration cache hash
​https://bugs.webkit.org/show_bug.cgi?id=71012

Reviewed by Kenneth Rohde Christiansen and Andreas Kling.

It is faster and better than the current custom function.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::computeDeclarationHash):

7:51 AM Changeset in webkit [98572] by haraken@chromium.org
  • 7 edits in trunk/Source/WebCore

Refactor OptionsObject.cpp
​https://bugs.webkit.org/show_bug.cgi?id=70572

Reviewed by Adam Barth.

For example, OptionsObject::getKeyBool() is an alias of
OptionsObject::getKeyValue(const String& key, bool& value).
We should remove OptionsObject::getKeyXXXX() (XXXX is some specific type)
and unify them into OptionsObject::get(const String& key, XXXX& value).
c.f. Corresponding JSC methods are unified into
JSDictionary::convertValue(JSC::ExecState*, JSC::JSValue, XXXX&).

The result of git diff is weird, but this patch is making just the following changes:

  • Replaced getKeyBool(), getKeyInt32(), getKeyDouble() and getKeyString() with get().
  • Renamed getKeyStringWithUndefinedOrNullCheck() to getWithUndefinedOrNullCheck().
  • Removed getKeyDOMStringList() and getKeyKeyRange(), since these are not used.
  • Move definitions of get() from .h to .cpp.

No new tests. No change in behavior.

  • bindings/v8/OptionsObject.cpp:

(WebCore::OptionsObject::get): Renamed from getKeyValue().
(WebCore::OptionsObject::getKey): No change to this method. git diff seems to misunderstand as if it is modified.
(WebCore::OptionsObject::getKeyDOMStringList): Removed, since no one is using it.
(WebCore::OptionsObject::getKeyKeyRange): Ditto.
(WebCore::OptionsObject::getWithUndefinedOrNullCheck): No change to this method. git diff seems to misunderstand as if it is modified.

  • bindings/v8/OptionsObject.h: Moved definitions of get() to OptionsObject.cpp
  • bindings/v8/custom/V8EventConstructors.cpp:
  • bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:

(WebCore::V8WebKitMutationObserver::observeCallback): Replaced getKeyXXXX() to get();

  • storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::createObjectStore): Ditto.

  • storage/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::createIndex): Ditto.

7:51 AM Changeset in webkit [98571] by Lucas Forschler
  • 2 edits in branches/safari-534.52-branch/Source/JavaScriptCore

Merge fix for ​https://bugs.webkit.org/show_bug.cgi?id=70976

7:36 AM Changeset in webkit [98570] by alexis.menard@openbossa.org
  • 5 edits in trunk/Source/WebKit2

[Qt][WK2] Move the C API callback setup out of QtWebPageProxy
​https://bugs.webkit.org/show_bug.cgi?id=70965

Reviewed by Andreas Kling.

Move out the setup of C API callback into ClientImpl file
so that QtWebPageProxy will be less polluted.

  • UIProcess/qt/ClientImpl.cpp:

(qt_wk_didStartProvisionalLoadForFrame):
(qt_wk_didFailProvisionalLoadWithErrorForFrame):
(qt_wk_didCommitLoadForFrame):
(qt_wk_didFinishLoadForFrame):
(qt_wk_didFailLoadWithErrorForFrame):
(qt_wk_didSameDocumentNavigationForFrame):
(qt_wk_didReceiveTitleForFrame):
(qt_wk_didStartProgress):
(qt_wk_didChangeProgress):
(qt_wk_didFinishProgress):
(qt_wk_runJavaScriptAlert):
(qt_wk_runJavaScriptConfirm):
(qt_wk_runJavaScriptPrompt):
(qt_wk_setStatusText):
(qt_wk_runOpenPanel):
(qt_wk_mouseDidMoveOverElement):
(qt_wk_decidePolicyForNavigationAction):
(qt_wk_decidePolicyForResponse):
(setupPageLoaderClient):
(setupPageUiClient):
(setupPagePolicyClient):

  • UIProcess/qt/ClientImpl.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::init):

  • UIProcess/qt/QtWebPageProxy.h:

(QtWebPageProxy::viewInterface):

7:33 AM Changeset in webkit [98569] by reed@google.com
  • 2 edits in trunk/LayoutTests

need to rebaseline after skia 2527 lands, fixing an off-by-1 bug in blending (with alpha==0)
​https://bugs.webkit.org/show_bug.cgi?id=70963

Reviewed by James Robinson.

  • platform/chromium/test_expectations.txt:
7:26 AM Changeset in webkit [98568] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

StyleSheet.parentStyleSheet does not work.
​https://bugs.webkit.org/show_bug.cgi?id=70956

Patch by Andreas Kling <​kling@webkit.org> on 2011-10-27
Reviewed by Antti Koivisto.

Source/WebCore:

Since StyleSheet is only ever parented by a CSSRule, we need
to go through that rule when resolving the StyleSheet's parent.

Test: fast/css/stylesheet-parentStyleSheet.html

  • css/StyleSheet.cpp:

(WebCore::StyleSheet::parentStyleSheet):

LayoutTests:

  • fast/css/stylesheet-parentStyleSheet-expected.txt: Added.
  • fast/css/stylesheet-parentStyleSheet.html: Added.
7:23 AM Changeset in webkit [98567] by commit-queue@webkit.org
  • 7 edits in trunk/Source

Disable blending when drawing opaque layers
​https://bugs.webkit.org/show_bug.cgi?id=70085

Patch by Antoine Labour <​piman@chromium.org> on 2011-10-27
Reviewed by James Robinson.

Covered by compositing/ tests, as well as a new unit test:
CCLayerTreeHostImplTest.blendingOffWhenDrawingOpaqueLayers

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayer):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::setOpaque):
(WebCore::CCLayerImpl::opaque):

7:03 AM Changeset in webkit [98566] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Chromium ui_tests WorkerTest.WorkerMessagePort[GC] were broken by ​https://bugs.webkit.org/attachment.cgi?id=112342
​https://bugs.webkit.org/show_bug.cgi?id=70953

Patch by Dave Michael <​dmichael@chromium.org> on 2011-10-27
Reviewed by David Levin.

  • src/PlatformMessagePortChannel.cpp:

(WebCore::PlatformMessagePortChannel::hasPendingActivity):

7:00 AM Changeset in webkit [98565] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2011-10-27 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
6:35 AM Changeset in webkit [98564] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

make lion observe MAC lines in test_expectations.txt
​https://bugs.webkit.org/show_bug.cgi?id=70941

Patch by Elliot Poger <​epoger@google.com> on 2011-10-27
Reviewed by Ojan Vafai.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
6:35 AM Changeset in webkit [98563] by commit-queue@webkit.org
  • 59 edits in trunk

IndexedDB: Passing empty array to IDBDatabase.transaction should raise exception
​https://bugs.webkit.org/show_bug.cgi?id=70251

Patch by Joshua Bell <​jsbell@chromium.org> on 2011-10-27
Reviewed by Adam Barth.

Source/WebCore:

IDBDatabase.transaction() supported being called with an empty array to
lock all object stores. Support for this was rejected from inclusion in
the IDB spec due to performance concerns. This patch removes that
functionality.

A special case in the spec (passing a string instead of an array) worked
in WebKit accidentally, by resolving the string to an empty array. This
needed explicit support. Support for DOMString[] is added to the binding
code generators (reliant on DOMStringList) to ensure JS arrays are not
coerced to DOMStrings. This matches the proposed IDL.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateParametersCheckExpression):
(GetNativeType):
(JSValueToNative):
(IsArrayType):

  • bindings/scripts/IDLStructure.pm:
  • storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::transaction):

  • storage/IDBDatabase.h:

(WebCore::IDBDatabase::transaction):

  • storage/IDBDatabase.idl:
  • storage/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
(WebCore::IDBTransactionBackendImpl::objectStore):

LayoutTests:

Many tests relied on the non-specified behavior of passing an empty
array into IDBDatabase.transaction() to include all object stores in
scopes. Worse, non-arrays would be treated as empty arrays, and hence
"just worked".

  • storage/indexeddb/create-and-remove-object-store-expected.txt:
  • storage/indexeddb/create-and-remove-object-store.html:
  • storage/indexeddb/create-object-store-options-expected.txt:
  • storage/indexeddb/create-object-store-options.html:
  • storage/indexeddb/cursor-inconsistency-expected.txt:
  • storage/indexeddb/cursor-inconsistency.html:
  • storage/indexeddb/cursor-skip-deleted-expected.txt:
  • storage/indexeddb/cursor-skip-deleted.html:
  • storage/indexeddb/cursor-update-expected.txt:
  • storage/indexeddb/cursor-update.html:
  • storage/indexeddb/data-corruption-expected.txt:
  • storage/indexeddb/data-corruption.html:
  • storage/indexeddb/database-quota.html:
  • storage/indexeddb/error-causes-abort-by-default-expected.txt:
  • storage/indexeddb/error-causes-abort-by-default.html:
  • storage/indexeddb/exception-in-event-aborts-expected.txt:
  • storage/indexeddb/exception-in-event-aborts.html:
  • storage/indexeddb/index-unique-expected.txt:
  • storage/indexeddb/index-unique.html:
  • storage/indexeddb/mutating-cursor-expected.txt:
  • storage/indexeddb/mutating-cursor.html:
  • storage/indexeddb/objectstore-autoincrement-expected.txt:
  • storage/indexeddb/objectstore-autoincrement.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/objectstore-clear-expected.txt:
  • storage/indexeddb/objectstore-clear.html:
  • storage/indexeddb/objectstore-removeobjectstore-expected.txt:
  • storage/indexeddb/objectstore-removeobjectstore.html:
  • storage/indexeddb/request-event-propagation-expected.txt:
  • storage/indexeddb/request-event-propagation.html:
  • storage/indexeddb/transaction-abort-expected.txt:
  • storage/indexeddb/transaction-abort-with-js-recursion-expected.txt:
  • storage/indexeddb/transaction-abort-with-js-recursion.html:
  • storage/indexeddb/transaction-abort.html:
  • storage/indexeddb/transaction-after-close-expected.txt:
  • storage/indexeddb/transaction-after-close.html:
  • storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
  • storage/indexeddb/transaction-and-objectstore-calls.html:
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-basics.html:
  • storage/indexeddb/transaction-crash-on-abort-expected.txt:
  • storage/indexeddb/transaction-crash-on-abort.html:
  • storage/indexeddb/transaction-event-propagation-expected.txt:
  • storage/indexeddb/transaction-event-propagation.html:
  • storage/indexeddb/transaction-read-only-expected.txt:
  • storage/indexeddb/transaction-read-only.html:
  • storage/indexeddb/transaction-storeNames-required-expected.txt:
  • storage/indexeddb/tutorial.html:
6:31 AM Changeset in webkit [98562] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Enable MEDIA_SOURCE feature for Chromium
​https://bugs.webkit.org/show_bug.cgi?id=70745

Patch by Aaron Colwell <​acolwell@chromium.org> on 2011-10-27
Reviewed by David Levin.

  • features.gypi:
6:22 AM Changeset in webkit [98561] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Crash due to nested first-letter selectors
​https://bugs.webkit.org/show_bug.cgi?id=70457

Source/WebCore:

Now only the lowest-level first-letter pseudostyle will be applied to
a given piece of text. Previously the last renderer to have layout
done would have its pseudostyle applied, no matter where it was in the
tree.

Patch by Ken Buchanan <​kenrb@chromium.org> on 2011-10-27
Reviewed by David Hyatt.

  • renderer/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetter): Use the pseudostyle from
the lowest level node to have one

LayoutTests:

Adding layout test for nested first-letter pseudostyles causing a crash.

Patch by Ken Buchanan <​kenrb@chromium.org> on 2011-10-27
Reviewed by David Hyatt.

  • fast/css/nested-first-letter-with-float-crash.html: Added
  • fast/css/nested-first-letter-with-float-crash-expected.txt: Added
6:19 AM Changeset in webkit [98560] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Remove QAction from MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=70525

This fixes the commonview tests that were failing
after r98447.
WebViewAbstraction must forward actions to both
the TouchWebView and the DesktopWebView.

Patch by Zeno Albisser <​zeno.albisser@nokia.com> on 2011-10-27
Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:

(WebViewAbstraction::goBack):
(WebViewAbstraction::goForward):
(WebViewAbstraction::stop):
(WebViewAbstraction::reload):

6:08 AM BuildingQt5OnHarmattan edited by abecsi@webkit.org
(diff)
6:07 AM Changeset in webkit [98559] by jknotten@chromium.org
  • 4 edits in trunk/Tools

[Chromium] Allow DRT to be built without notifications enabled.
​https://bugs.webkit.org/show_bug.cgi?id=70919

Reviewed by Tony Gentilcore.

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::grantDesktopNotificationPermission):
(LayoutTestController::simulateDesktopNotificationClick):

  • DumpRenderTree/chromium/NotificationPresenter.cpp:
  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):
(TestShell::resetTestController):

6:05 AM Changeset in webkit [98558] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2]Content size changed event does not require viewport attribute calculation.
​https://bugs.webkit.org/show_bug.cgi?id=70920

Patch by Zalan Bujtas <​zbujtas@gmail.com> on 2011-10-27
Reviewed by Kenneth Rohde Christiansen.

Remove unnecessary recalculation of viewport attributes.

  • UIProcess/qt/QtTouchViewInterface.cpp:

(WebKit::QtTouchViewInterface::contentSizeChanged):

6:02 AM Changeset in webkit [98557] by abecsi@webkit.org
  • 3 edits in trunk/Source/WebCore

Fix the build if NO_LISTBOX_RENDERING is enabled
​https://bugs.webkit.org/show_bug.cgi?id=71009

Reviewed by Kenneth Rohde Christiansen.

If NO_LISTBOX_RENDERING is enabled RenderMenuList::listBoxSelectItem uses the
HTMLSelectElement::listBoxSelectItem function which was accidentally removed in r97533.
Reintroduce HTMLSelectElement::listBoxSelectItem with a NO_LISTBOX_RENDERING guard to unbreak this setup.

This is covered by:
Source/WebCore/manual-tests/no-listbox-rendering.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::listBoxSelectItem): Reintroduce.

  • html/HTMLSelectElement.h:
5:52 AM Changeset in webkit [98556] by commit-queue@webkit.org
  • 11 edits
    2 adds in trunk

Implement legacy text check emulation in unified text check interface.
​https://bugs.webkit.org/show_bug.cgi?id=70299

Patch by Shinya Kawanaka <​shinyak@google.com> on 2011-10-27
Reviewed by Hajime Morita.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

When UNIFIED_TEXT_CHECKING is off, WebCore::checkTextOfParagraph() emulates
TextCheckerClient::checkTextOfParagraph() using checkSpellingOfString and checkGrammarOfString.

This emulation can be used by setting the flag on.
This can be done by WebCore::Internals::setUnifiedTextCheckingEnabled.

Test: editing/spelling/spelling-unified-emulation.html

  • editing/TextCheckingHelper.cpp:

(WebCore::findBadGrammars): Added.
(WebCore::findMisspellings): Added.
(WebCore::checkTextOfParagraph):

Emulates TextCheckerClients::checkTextOfParagraph if UNIFIED_TEXT_CHECKING is off.

  • testing/Internals.cpp:

(WebCore::Internals::setUnifiedTextCheckingEnabled): flag setter.
(WebCore::Internals::unifiedTextCheckingEnabled): flag getter.

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

Added tests for the case unified text checker is used when WebCore::checkTextOfParagraph() is not supported.

  • editing/spelling/spelling-unified-emulation-expected.txt: Added.
  • editing/spelling/spelling-unified-emulation.html: Added.
5:37 AM Changeset in webkit [98555] by Philippe Normand
  • 1 edit
    2 deletes in trunk/Source/WebCore

Unreviewed, remove those un-needed files committed by error in
r98554.

  • platform/audio/gstreamer/#AudioFileReaderGStreamer.h#: Removed.
  • platform/audio/gstreamer/.#AudioFileReaderGStreamer.h: Removed.
5:31 AM Changeset in webkit [98554] by Philippe Normand
  • 9 edits
    8 adds in trunk

[GStreamer] WebAudio AudioFileReader implementation
​https://bugs.webkit.org/show_bug.cgi?id=69834

.:

Patch by Philippe Normand <​pnormand@igalia.com> and Zan Dobersek <​zandobersek@gmail.com> on 2011-10-27
Reviewed by Martin Robinson.

  • configure.ac: Check for libfftw and gstreamer-audio if WebAudio

build is enabled.

Source/WebCore:

Patch by Philippe Normand <​pnormand@igalia.com> and Zan Dobersek <​zandobersek@gmail.com> on 2011-10-27
Reviewed by Martin Robinson.

Basic FileReader implementation, supporting one or 2 audio
channels. An empty AudioDestination is also provided, its complete
implementation is handled in bug 69835.

  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • platform/audio/gstreamer/AudioDestinationGStreamer.cpp: Added.

(WebCore::AudioDestination::create):
(WebCore::AudioDestination::hardwareSampleRate):
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
(WebCore::AudioDestinationGStreamer::~AudioDestinationGStreamer):
(WebCore::AudioDestinationGStreamer::start):
(WebCore::AudioDestinationGStreamer::stop):

  • platform/audio/gstreamer/AudioDestinationGStreamer.h: Added.

(WebCore::AudioDestinationGStreamer::isPlaying):
(WebCore::AudioDestinationGStreamer::sampleRate):
(WebCore::AudioDestinationGStreamer::sourceProvider):

  • platform/audio/gstreamer/AudioFileReaderGStreamer.cpp: Added.

(WebCore::getGStreamerAudioCaps):
(WebCore::getFloatFromByteReader):
(WebCore::copyGstreamerBuffersToAudioChannel):
(WebCore::onAppsinkNewBufferCallback):
(WebCore::messageCallback):
(WebCore::onGStreamerDeinterleavePadAddedCallback):
(WebCore::onGStreamerDeinterleaveReadyCallback):
(WebCore::onGStreamerDecodebinPadAddedCallback):
(WebCore::AudioFileReader::AudioFileReader):
(WebCore::AudioFileReader::~AudioFileReader):
(WebCore::AudioFileReader::handleBuffer):
(WebCore::AudioFileReader::handleMessage):
(WebCore::AudioFileReader::handleNewDeinterleavePad):
(WebCore::AudioFileReader::deinterleavePadsConfigured):
(WebCore::AudioFileReader::plugDeinterleave):
(WebCore::AudioFileReader::createBus):
(WebCore::createBusFromAudioFile):
(WebCore::createBusFromInMemoryAudioFile):

  • platform/audio/gtk/AudioBusGtk.cpp: Added.

(WebCore::AudioBus::loadPlatformResource):

Source/WebKit/gtk:

Reviewed by Martin Robinson.

  • GNUmakefile.am: Link against libfftw.

Source/WebKit2:

Reviewed by Martin Robinson.

  • GNUmakefile.am: Link against libfftw.
5:23 AM Changeset in webkit [98553] by Philippe Normand
  • 3 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r98507.

  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
5:19 AM Changeset in webkit [98552] by Philippe Normand
  • 9 edits in trunk/Source/WebCore

Unreviewed, rebaseline of the bindings tests after r98501 which
removed getOwnPropertySlotVirtual.

  • bindings/scripts/test/JS/JSTestInterface.cpp:
  • bindings/scripts/test/JS/JSTestInterface.h:
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
4:51 AM Changeset in webkit [98551] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

http/tests/inspector/search/search-in-resources.html fails on all platforms
​https://bugs.webkit.org/show_bug.cgi?id=70993

Reviewed by Pavel Feldman.

  • http/tests/inspector/search/search-test.js:

(initialize_SearchTest.InspectorTest.dumpSearchResults):

4:50 AM Changeset in webkit [98550] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

WebInspector: View throughs the exception when a child view are removed by removeChildren call.
​https://bugs.webkit.org/show_bug.cgi?id=71002

Another followup fix after r98225.

Reviewed by Pavel Feldman.

  • inspector/front-end/DatabaseTableView.js:

(WebInspector.DatabaseTableView.prototype._queryFinished):
(WebInspector.DatabaseTableView.prototype._queryError):

4:49 AM Changeset in webkit [98549] by vsevik@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: Execution line in selected call frame should keep showing after toggling format source.
​https://bugs.webkit.org/show_bug.cgi?id=70906

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/debugger/selected-call-frame-after-formatting-source.html

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):

LayoutTests:

  • inspector/debugger/selected-call-frame-after-formatting-source-expected.txt: Added.
  • inspector/debugger/selected-call-frame-after-formatting-source.html: Added.
4:47 AM Changeset in webkit [98548] by steveblock@google.com
  • 4 edits in trunk/Source/WebCore

Numerous debug build fixes

Unreviewed build fix.

No new tests, buuld fix only.

  • loader/icon/IconDatabase.cpp: urlForLogging() is used by both LOG() and LOG_ERROR()
  • storage/AbstractDatabase.h: databaseDebugName() is used by both LOG() and LOG_ERROR()
  • storage/DatabaseTask.cpp: m_complete is only available when !LOG_DISABLED
4:43 AM Changeset in webkit [98547] by jocelyn.turcotte@nokia.com
  • 4 edits in trunk/Tools

[Qt] Improve command line arguments handling for MiniBrowser.
​https://bugs.webkit.org/show_bug.cgi?id=70616

Reviewed by Kenneth Rohde Christiansen.

  • Use two dashes for word arguments.
  • Return with an error when an unsupported argument is given.
  • Allow the URL to be placed before option arguments.
  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(printHelp):
(MiniBrowserApplication::handleUserOptions):

  • MiniBrowser/qt/utils.cpp:

(takeOptionFlag):
(takeOptionValue):

  • MiniBrowser/qt/utils.h:
4:36 AM Changeset in webkit [98546] by vsevik@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Refactor ScriptsPanel so that ConsoleView does not depend on it.
​https://bugs.webkit.org/show_bug.cgi?id=70899

Moved methods used in console view to DebuggerPresentationModel.
Changed debuggerPaused handler logic so that selectedCallFrame is never null when debugger is paused.

Reviewed by Pavel Feldman.

  • inspector/front-end/ConsoleView.js:
  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype.getSelectedCallFrameVariables.propertiesCollected):
(WebInspector.DebuggerPresentationModel.prototype.getSelectedCallFrameVariables):
(WebInspector.DebuggerPresentationModel.prototype._dispatchExecutionLineChanged):
(WebInspector.DebuggerPresentationModel.prototype.get executionLineLocation):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._consoleCommandEvaluatedInSelectedCallFrame):
(WebInspector.ScriptsPanel.prototype._executionLineChanged):
(WebInspector.ScriptsPanel.prototype._updateExecutionLine):
(WebInspector.ScriptsPanel.prototype._callFrameSelected):
(WebInspector.ScriptsPanel.prototype._updateCallFrame):

4:30 AM Changeset in webkit [98545] by vsevik@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Add support for advanced search in content scripts.
​https://bugs.webkit.org/show_bug.cgi?id=70923

Reviewed by Yury Semikhatsky.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ScriptsSearchScope.js:
  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):

4:30 AM Changeset in webkit [98544] by Csaba Osztrogonác
  • 3 edits in trunk/Tools

[Qt] NRWT doesn't work on qt-mac platform
​https://bugs.webkit.org/show_bug.cgi?id=64445

Reviewed by Adam Barth.

  • Scripts/run-webkit-tests: Switch qt-mac platform to NRWT.

(useNewRunWebKitTests):

  • Scripts/webkitpy/layout_tests/port/qt.py: Fix library path on Mac.
2:55 AM Changeset in webkit [98543] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed one line fix for DOMStorageItemsView.
It have to use this.detachChildViews instead of this.element.removeChildren after r98225.

  • inspector/front-end/DOMStorageItemsView.js:

(WebInspector.DOMStorageItemsView.prototype.update):

2:39 AM Changeset in webkit [98542] by Antti Koivisto
  • 9 edits in trunk/Source/WebCore

Matched declaration cache
​https://bugs.webkit.org/show_bug.cgi?id=70931

Reviewed by Darin Adler.

Sets of style declarations are applied repeatedly for different elements when calculating the document style.
The same set of applied declarations results in the same non-inherited style, independent of the element and
its context. We can use this to build a cache to speed up style applying and to share more style data for
reduced memory usage.

The patch reduces RenderStyle memory use ~40% and total memory use by ~7% over HTML5 spec load.
It is also ~10% progression in PerformanceTests/Parser/html5-full-render.html.

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSProperty.h:

(WebCore::CSSProperty::CSSProperty):
(WebCore::CSSProperty::isInherited):

We need to know which properties are inherited, something we didn't have available so far.


  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::matchAllRules):

A set of declarations is only cacheable if it contains no element specific style. This way we
don't need to worry about cache invalidation. The whole style selector is reconstructed if the
stylesheets change, invalidating the cache too.


(WebCore::CSSStyleSelector::styleForElement):

Trigger image loads bit earlier so cached style will have them too.


(WebCore::CSSStyleSelector::applyDeclaration):
(WebCore::CSSStyleSelector::applyDeclarations):

Allow skipping over non-inherited properties.


(WebCore::CSSStyleSelector::computeDeclarationHash):

Hash function for declartion cache lookups.


(WebCore::operator==):
(WebCore::operator!=):
(WebCore::CSSStyleSelector::findFromMatchedDeclarationCache):

Lookup from cache.


(WebCore::CSSStyleSelector::addToMatchedDeclarationCache):

Add to cache.


(WebCore::CSSStyleSelector::applyMatchedDeclarations):

If cached style is found, copy the non-inherited properties from the cache and apply the inherited properties (if any) only.


Font and zoom changes force full applying as they can affect values of other properties (this can be relaxed later).


  • css/CSSStyleSelector.h:

(WebCore::CSSStyleSelector::MatchResult::MatchResult):

Cacheability bit.


  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::copyNonInheritedFrom):

  • rendering/style/RenderStyle.h:
  • rendering/style/SVGRenderStyle.cpp:

(WebCore::SVGRenderStyle::copyNonInheritedFrom):

  • rendering/style/SVGRenderStyle.h:


Functions for assembling RenderStyle from non-inherited parts of the cached style.

2:38 AM BuildingQt5OnHarmattan edited by zeno.albisser@nokia.com
(diff)
2:37 AM Changeset in webkit [98541] by caseq@chromium.org
  • 4 edits
    2 adds in trunk

Web Inspector: [Extensions API] add ignoreCache flag to options of inspectedWindow.reload()
​https://bugs.webkit.org/show_bug.cgi?id=70926

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/extensions-ignore-cache.html

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onReload):

  • inspector/front-end/externs.js:

():

LayoutTests:

  • http/tests/inspector/extensions-ignore-cache-expected.txt: Added.
  • http/tests/inspector/extensions-ignore-cache.html: Added.
2:33 AM Changeset in webkit [98540] by rgabor@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, fix typo in skiplist.

  • platform/qt/Skipped:
2:29 AM BuildingQt5OnHarmattan edited by zeno.albisser@nokia.com
(diff)
1:54 AM Changeset in webkit [98539] by rgabor@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Add bugzilla link to skipped test.

  • platform/qt/Skipped:
12:53 AM Changeset in webkit [98538] by yurys@chromium.org
  • 4 edits in trunk/LayoutTests

inspector/storage-panel-dom-storage.html has results platform dependant?
​https://bugs.webkit.org/show_bug.cgi?id=70985

The items set in DOM storage is unsorted and as result the test is platform dependant.
We will sort it before the dumping.

Patch by Ilya Tikhonovsky <​loislo@chromium.org> on 2011-10-27
Reviewed by Yury Semikhatsky.

  • inspector/storage-panel-dom-storage-expected.txt:
  • inspector/storage-panel-dom-storage.html:
  • platform/chromium/test_expectations.txt:

Oct 26, 2011:

11:50 PM Changeset in webkit [98537] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2011-10-26 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
11:37 PM Changeset in webkit [98536] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2011-10-26 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Update Chromium test_expectations.

inspector/storage-panel-dom-storage.html has results platform dependant?
​https://bugs.webkit.org/show_bug.cgi?id=70985

  • platform/chromium/test_expectations.txt:
11:27 PM Changeset in webkit [98535] by yurys@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

2011-10-26 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Update test expecatations for search-in-resources.html

http/tests/inspector/search/search-in-resources.html fails on all platforms
​https://bugs.webkit.org/show_bug.cgi?id=70993

  • http/tests/inspector/search/search-in-resources-expected.txt:
  • platform/chromium-linux/http/tests/inspector/search/search-in-resources-expected.txt: Removed.
10:16 PM Changeset in webkit [98534] by rniwa@webkit.org
  • 2 edits
    8 adds in trunk/LayoutTests

Chromium Windows and Linux rebaselines.

  • platform/chromium-linux/http/tests/security/dataTransfer-set-data-file-url-expected.png: Added.
  • platform/chromium-linux/platform/mac/editing: Added.
  • platform/chromium-linux/platform/mac/editing/pasteboard: Added.
  • platform/chromium-linux/platform/mac/editing/pasteboard/dataTransfer-set-data-file-url-expected.png: Added.
  • platform/chromium-win/http/tests/security/dataTransfer-set-data-file-url-expected.png: Added.
  • platform/chromium-win/http/tests/security/dataTransfer-set-data-file-url-expected.txt: Added.
  • platform/chromium-win/platform/mac/editing/pasteboard/dataTransfer-set-data-file-url-expected.png: Added.
  • platform/chromium-win/platform/mac/editing/pasteboard/dataTransfer-set-data-file-url-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
9:56 PM Changeset in webkit [98533] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Console message in copy-standalone-image-crash.html bleeds into the result of copy-standalone-image.html
​https://bugs.webkit.org/show_bug.cgi?id=70957

Reviewed by Ojan Vafai.

The bug was caused by the delayed hideDiv call in a mousedown event listener.
Fixed the bug by not attaching this event listener inside DRT or TestRunner.

  • editing/pasteboard/copy-standalone-image-crash.html:
6:51 PM Changeset in webkit [98532] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

Massive gardening.

  • platform/chromium/test_expectations.txt: Lots of tests were regularly failing

or timing out but were not marked. Added them as they were consistently flaky.

6:12 PM Changeset in webkit [98531] by jchaffraix@webkit.org
  • 2 edits
    3 adds in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium-linux/http/tests/inspector: Added.
  • platform/chromium-linux/http/tests/inspector/search: Added.
  • platform/chromium-linux/http/tests/inspector/search/search-in-resources-expected.txt: Added.

Rebaselined (looks like the urls are sorted differently on Linux).

  • platform/chromium/test_expectations.txt: Marked inspector/storage-panel-dom-storage.html

as TEXT as it started failing on the bots.

5:43 PM Changeset in webkit [98530] by sfalken@apple.com
  • 2 edits in trunk/Source/WebCore

ResourceError doesn't support custom domains on Windows
​https://bugs.webkit.org/show_bug.cgi?id=70983
<rdar://problem/10352145>

Reviewed by Oliver Hunt.

  • platform/network/cf/ResourceErrorCF.cpp:

(WebCore::ResourceError::platformLazyInit): Add fallback case for unknown error types.

5:29 PM Changeset in webkit [98529] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Fix a slider thumb rendering regression in Chromium on OS X in r98520.

Reviewed by Anders Carlsson.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSliderThumb): Reverted the changes to the Chromium code path.

5:26 PM Changeset in webkit [98528] by leviw@chromium.org
  • 5 edits in branches/subpixellayout/Source/WebCore

Fixing FixedPoint's flooredIntSize, adding an adjustedBorderBoxRectForCellRounding method to get Table border painting correct, and fixing float and linebox layout since my last checkin.

5:21 PM Changeset in webkit [98527] by jchaffraix@webkit.org
  • 5 edits in trunk

Unreviewed, rolling out r98486.
​http://trac.webkit.org/changeset/98486
​https://bugs.webkit.org/show_bug.cgi?id=70748

Broke Chromium's test_expectation.txt

Source/WebCore:

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::State::State):
(WebCore::PlatformContextSkia::State::cloneInheritedProperties):
(WebCore::PlatformContextSkia::clipPathAntiAliased):
(WebCore::PlatformContextSkia::restore):
(WebCore::PlatformContextSkia::applyAntiAliasedClipPaths):

  • platform/graphics/skia/PlatformContextSkia.h:

LayoutTests:

  • platform/chromium/test_expectations.txt:
5:20 PM Changeset in webkit [98526] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r98153): Safari crashes if WebProcess crashed during printing
​https://bugs.webkit.org/show_bug.cgi?id=70982

Reviewed by Dan Bernstein.

  • UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView _delayedResumeAutodisplayTimerFired]): Null check page, it may be invalid already.
5:19 PM Changeset in webkit [98525] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Restore structure-clearing behaviour of allocateCell<>
​https://bugs.webkit.org/show_bug.cgi?id=70976

Reviewed by Geoffrey Garen.

This restores the logic that allows the markstack to filter
live objects that have not yet been initialised.

  • runtime/JSCell.h:

(JSC::JSCell::clearStructure):

Validation-safe method to clear a cell's structure.

(JSC::allocateCell):

Call the above method.

  • runtime/Structure.h:

(JSC::MarkStack::internalAppend):

Don't visit cells that haven't been initialised.

3:42 PM Changeset in webkit [98524] by jchaffraix@webkit.org
  • 1 edit
    1 move in trunk/LayoutTests

Unreviewed trivial renaming.

  • fast/js/dfg-intrinsic-osr-exit-expected.html: Removed.
  • fast/js/dfg-intrinsic-osr-exit-expected.txt: Copied from LayoutTests/fast/js/dfg-intrinsic-osr-exit-expected.html.
3:26 PM Changeset in webkit [98523] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:

storage/domstorage/events/basic-setattribute.html is a flaky crasher.

3:12 PM Changeset in webkit [98522] by jamesr@google.com
  • 2 edits in branches/chromium/874/Source/WebCore

Merge 98112 - Fix Windows build.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::hasAnyAdditionalCompositedLayers):

TBR=​jamesr@chromium.org
Review URL: ​http://codereview.chromium.org/8363033

3:11 PM Changeset in webkit [98521] by jamesr@google.com
  • 5 edits in branches/chromium/874

Merge 98060 - Hidden composited iframes cause infinite loop
​https://bugs.webkit.org/show_bug.cgi?id=52655

Source/WebCore:

Reviewed by Darin Adler.

visibility:hidden is problematic for compositing, because it causes
RenderLayers to be removed from the z-order layer tree. This confuses
RenderLayerCompositor in several ways; it never sees these layers
when traversing the tree as it computes compositing requirements, or
rebuilds the layer tree.

This is a particular problem with composited iframes. When an iframe
becomes composited, scheduleSetNeedsStyleRecalc() is called on that
iframe's ownerElement in the parent document. If this happens inside
Document::updateStyleForAllDocuments(), we get into an infinite loop
because notifyIFramesOfCompositingChange() queues up style update as we
bounce in and out of compositing mode, so documentsThatNeedStyleRecalc
never empties out.

This is an initial, conservative fix that doesn't attempt to fix all
the issues with visibility. It changes RenderLayerCompositor to count
the number of compositing RenderLayers, and to not leave compositing
mode if there are any (even if they are hidden, so not hit while
traversing the z-order tree). This avoids the infinite loop.

Test: compositing/visibility/hidden-iframe.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::ensureBacking):
(WebCore::RenderLayer::clearBacking):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::hasAnyAdditionalCompositedLayers):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):

  • rendering/RenderLayerCompositor.h:

(WebCore::RenderLayerCompositor::layerBecameComposited):
(WebCore::RenderLayerCompositor::layerBecameNonComposited):

LayoutTests:

Reviewed by Darin Adler.

Test with a visibility:hidden iframe, whose subframe becomes composited.

  • compositing/visibility/hidden-iframe-expected.txt: Added.
  • compositing/visibility/hidden-iframe.html: Added.

TBR=Simon Fraser
Review URL: ​http://codereview.chromium.org/8403008

2:41 PM Changeset in webkit [98520] by mitz@apple.com
  • 3 edits in trunk/Source/WebCore

<rdar://problem/10350775> REGRESSION (r97032): Slider thumb is not drawn
​https://bugs.webkit.org/show_bug.cgi?id=70891

Reviewed by Anders Carlsson.

  • platform/mac/ThemeMac.mm:

(WebCore::ThemeMac::ensuredView): Set the WebCoreFlippedView’s size, because NSSliderCell
always shrinks the slider thumb to fit in the control view’s bounds.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSliderThumb): Removed workaround code no longer needed after
r97032.

2:33 PM Changeset in webkit [98519] by Lucas Forschler
  • 5 edits in branches/safari-534.52-branch/Source

Versioning.

2:32 PM Changeset in webkit [98518] by caryclark@google.com
  • 5 edits
    676 adds in trunk/LayoutTests

Unreviewed gardening: sixth chunk of baselines for Chromium-Skia
on Leopard.

[Omitting 674 of 680 files for brevity.]

  • platform/chromium-mac-leopard/svg/as-background-image: Added.
  • platform/chromium-mac-leopard/svg/as-background-image/svg-as-background-1-expected.png: Added.
  • platform/chromium-mac-leopard/svg/as-background-image/svg-as-background-5-expected.png: Added.

...

  • platform/chromium-mac-leopard/tables/mozilla/core/margins-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_col_valign_baseline-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
2:13 PM Changeset in webkit [98517] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

REGRESSION (r97030): Cannot log in to progressive.com
​https://bugs.webkit.org/show_bug.cgi?id=70094

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleCall):

LayoutTests:

  • fast/js/dfg-intrinsic-osr-exit-expected.html: Added.
  • fast/js/dfg-intrinsic-osr-exit.html: Added.
  • fast/js/script-tests/dfg-intrinsic-osr-exit.js: Added.

(foo):

2:09 PM Changeset in webkit [98516] by Lucas Forschler
  • 1 copy in tags/Safari-534.52.4

New tag.

1:43 PM Changeset in webkit [98515] by leandro@webkit.org
  • 1 edit
    772 adds in trunk/LayoutTests

[EFL] Unreviewed. Add pixel baselines for CSS3 tests.

  • platform/efl/css3: [...]
1:20 PM Changeset in webkit [98514] by crogers@google.com
  • 6 edits
    1 copy in trunk/Source/WebKit/chromium

Add chromium bridging for AudioSourceProviderClient and setFormat() method so we can know audio stream format
​https://bugs.webkit.org/show_bug.cgi?id=70650

Reviewed by Darin Fisher.

  • WebKit.gyp:
  • public/WebAudioSourceProvider.h:

(WebKit::WebAudioSourceProvider::setClient):

  • public/WebAudioSourceProviderClient.h: Copied from Source/WebKit/chromium/public/WebAudioSourceProvider.h.

(WebKit::WebAudioSourceProviderClient::~WebAudioSourceProviderClient):

  • public/WebMediaPlayer.h:
  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::loadInternal):
(WebKit::WebMediaPlayerClientImpl::audioSourceProvider):
(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::wrap):
(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::setClient):
(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::provideInput):
(WebKit::WebMediaPlayerClientImpl::AudioClientImpl::setFormat):

  • src/WebMediaPlayerClientImpl.h:

(WebKit::WebMediaPlayerClientImpl::AudioClientImpl::AudioClientImpl):
(WebKit::WebMediaPlayerClientImpl::AudioClientImpl::~AudioClientImpl):
(WebKit::WebMediaPlayerClientImpl::AudioClientImpl::wrap):

1:19 PM Changeset in webkit [98513] by jeffm@apple.com
  • 5 edits in trunk/Source/WebKit2

WebKit2 should respect secret WebKitOmitPDFSupport preference on the Mac
​https://bugs.webkit.org/show_bug.cgi?id=70943

If WebKitOmitPDFSupport pref is set, disable both the new "plug-in" for subframes and the PDFKit-based support for the main frame only.

Reviewed by Alexey Proskuryakov.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::getPlugins): Don't register built-in PDF plugin if WebKitOmitPDFSupport pref is set.

  • UIProcess/WebContext.h: Added omitPDFSupport().


  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::canShowMIMEType): Don't show PDFs if WebKitOmitPDFSupport is set.

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::omitPDFSupport): Added.

12:57 PM Changeset in webkit [98512] by crogers@google.com
  • 7 edits
    1 copy in trunk/Source/WebCore

Add AudioSourceProviderClient and setFormat() method so we can know audio stream format
​https://bugs.webkit.org/show_bug.cgi?id=70155

Reviewed by Eric Carlson.

No new tests. There isn't yet an implementation to test.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::createMediaPlayer):
(WebCore::HTMLMediaElement::setAudioSourceNode):
Let MediaPlayer know about the MediaElementAudioSourceNode so it can callback with audio stream format information.

  • platform/audio/AudioSourceProvider.h:

(WebCore::AudioSourceProvider::setClient):
Add abstract setClient() method so a client may know about stream format information when it becomes available.

  • platform/audio/AudioSourceProviderClient.h: Copied from Source/WebCore/webaudio/MediaElementAudioSourceNode.h.

(WebCore::AudioSourceProviderClient::~AudioSourceProviderClient):
Add abstract class AudioSourceProviderClient which implements setFormat() to receive audio stream format information.

  • webaudio/MediaElementAudioSourceNode.cpp:

(WebCore::MediaElementAudioSourceNode::setFormat):
Concrete implementation of setFormat() so MediaElementAudioSourceNode can create necessary audio converters.

  • webaudio/MediaElementAudioSourceNode.h:

Make MediaElementAudioSourceNode implement AudioSourceProviderClient so it can get audio stream format information
when its setFormat() method is called.

12:55 PM Changeset in webkit [98511] by leandro@webkit.org
  • 1 edit
    708 adds in trunk/LayoutTests

[EFL] Unreviewed. Add pixel baselines for CSS2.1 tests.

  • platform/efl/css2.1: [...]
12:06 PM Changeset in webkit [98510] by rniwa@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

Chromium Mac rebaseline.

  • platform/chromium-mac-leopard/editing/pasteboard/copy-standalone-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/copy-standalone-image-expected.png:
12:01 PM Changeset in webkit [98509] by weinig@apple.com
  • 5 edits
    1 add in trunk

Add initial setting to WKBrowsingContextGroup
​https://bugs.webkit.org/show_bug.cgi?id=70942

Reviewed by Anders Carlsson.

Source/WebKit2:

Test: WKBrowsingContextGroupTest.

  • UIProcess/API/mac/WKBrowsingContextGroup.h:
  • UIProcess/API/mac/WKBrowsingContextGroup.mm:

(-[WKBrowsingContextGroup isJavaScriptEnabled]):
(-[WKBrowsingContextGroup setJavaScriptEnabled:]):
Add setting to enabled/disable javascript. By default it is enabled.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm: Added.

Add basic test that setting the javaScriptEnabled setting takes. It is not
possible to test its effect quite yet.

11:58 AM Changeset in webkit [98508] by jchaffraix@webkit.org
  • 49 edits
    2 adds
    94 deletes in trunk

Unreviewed, rolling out r98483.
​http://trac.webkit.org/changeset/98483
​https://bugs.webkit.org/show_bug.cgi?id=47156

Change is causing some crashes and ASSERTs.

Source/WebCore:

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::lookupImageForSize):
(WebCore::CachedImage::lookupImageForRenderer):
(WebCore::CachedImage::lookupOrCreateImageForRenderer):
(WebCore::CachedImage::setContainerSizeForRenderer):
(WebCore::CachedImage::imageSizeForRenderer):
(WebCore::CachedImage::computeIntrinsicDimensions):
(WebCore::CachedImage::createImage):

  • loader/cache/CachedImage.h:
  • page/ChromeClient.h:
  • rendering/ImageBySizeCache.cpp:

(WebCore::ImageBySizeCache::addClient):
(WebCore::ImageBySizeCache::removeClient):
(WebCore::ImageBySizeCache::imageForSize):
(WebCore::ImageBySizeCache::sizeForClient):

  • rendering/ImageBySizeCache.h:
  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateFillTileSize):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
(WebCore::RenderBoxModelObject::paintNinePieceImage):

  • rendering/RenderBoxModelObject.h:
  • rendering/RenderImage.cpp:

(WebCore::RenderImage::RenderImage):
(WebCore::RenderImage::imageDimensionsChanged):
(WebCore::RenderImage::isLogicalWidthSpecified):
(WebCore::RenderImage::isLogicalHeightSpecified):
(WebCore::RenderImage::computeReplacedLogicalWidth):
(WebCore::RenderImage::computeReplacedLogicalHeight):
(WebCore::RenderImage::calcAspectRatioLogicalWidth):
(WebCore::RenderImage::calcAspectRatioLogicalHeight):

  • rendering/RenderImage.h:
  • rendering/RenderImageResource.cpp:

(WebCore::RenderImageResource::setContainerSizeForRenderer):

  • rendering/RenderImageResourceStyleImage.cpp:
  • rendering/RenderImageResourceStyleImage.h:

(WebCore::RenderImageResourceStyleImage::image):
(WebCore::RenderImageResourceStyleImage::setContainerSizeForRenderer):

  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::computePreferredLogicalWidths):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeIntrinsicLogicalWidth):
(WebCore::RenderReplaced::computeIntrinsicLogicalHeight):
(WebCore::RenderReplaced::computeReplacedLogicalWidth):

  • rendering/style/StyleCachedImage.cpp:

(WebCore::StyleCachedImage::computeIntrinsicDimensions):
(WebCore::StyleCachedImage::setContainerSizeForRenderer):
(WebCore::StyleCachedImage::addClient):
(WebCore::StyleCachedImage::removeClient):

  • rendering/style/StyleCachedImage.h:
  • rendering/style/StyleGeneratedImage.h:

(WebCore::StyleGeneratedImage::setContainerSizeForRenderer):

  • rendering/style/StyleImage.h:
  • rendering/style/StylePendingImage.h:

(WebCore::StylePendingImage::setContainerSizeForRenderer):

  • rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::layout):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::computeIntrinsicWidth):
(WebCore::RenderSVGRoot::computeIntrinsicHeight):
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):
(WebCore::RenderSVGRoot::layout):
(WebCore::RenderSVGRoot::paint):
(WebCore::RenderSVGRoot::calcViewport):
(WebCore::RenderSVGRoot::computeRectForRepaint):

  • rendering/svg/RenderSVGRoot.h:
  • svg/SVGLength.cpp:

(WebCore::SVGLength::determineViewport):

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::SVGSVGElement):
(WebCore::SVGSVGElement::relativeWidthValue):
(WebCore::SVGSVGElement::relativeHeightValue):
(WebCore::SVGSVGElement::currentViewBoxRect):

  • svg/SVGSVGElement.h:

(WebCore::SVGSVGElement::setContainerSize):
(WebCore::SVGSVGElement::containerSize):
(WebCore::SVGSVGElement::hasSetContainerSize):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::setContainerSize):
(WebCore::SVGImage::usesContainerSize):
(WebCore::SVGImage::size):
(WebCore::SVGImage::hasRelativeWidth):
(WebCore::SVGImage::hasRelativeHeight):
(WebCore::SVGImage::draw):
(WebCore::SVGImage::computeIntrinsicDimensions):
(WebCore::SVGImage::dataChanged):

  • svg/graphics/SVGImage.h:

LayoutTests:

  • css2.1/20110323/background-intrinsic-001.htm: Removed.
  • css2.1/20110323/background-intrinsic-002.htm: Removed.
  • css2.1/20110323/background-intrinsic-003.htm: Removed.
  • css2.1/20110323/background-intrinsic-004.htm: Removed.
  • css2.1/20110323/background-intrinsic-005.htm: Removed.
  • css2.1/20110323/background-intrinsic-006.htm: Removed.
  • css2.1/20110323/background-intrinsic-007.htm: Removed.
  • css2.1/20110323/background-intrinsic-008.htm: Removed.
  • css2.1/20110323/background-intrinsic-009.htm: Removed.
  • css2.1/20110323/resources/green-intrinsic-height-ratio.svg: Removed.
  • css2.1/20110323/resources/green-intrinsic-height.svg: Removed.
  • css2.1/20110323/resources/green-intrinsic-none.svg: Removed.
  • css2.1/20110323/resources/green-intrinsic-ratio-landscape.svg: Removed.
  • css2.1/20110323/resources/green-intrinsic-ratio-portrait.svg: Removed.
  • css2.1/20110323/resources/green-intrinsic-width-height.svg: Removed.
  • css2.1/20110323/resources/green-intrinsic-width-pc-height-pc.svg: Removed.
  • css2.1/20110323/resources/green-intrinsic-width-ratio.svg: Removed.
  • css2.1/20110323/resources/green-intrinsic-width.svg: Removed.
  • css2.1/20110323/resources/red-intrinsic-height-ratio.svg: Removed.
  • css2.1/20110323/resources/red-intrinsic-height.svg: Removed.
  • css2.1/20110323/resources/red-intrinsic-none.svg: Removed.
  • css2.1/20110323/resources/red-intrinsic-ratio-landscape.svg: Removed.
  • css2.1/20110323/resources/red-intrinsic-ratio-portrait.svg: Removed.
  • css2.1/20110323/resources/red-intrinsic-width-height.svg: Removed.
  • css2.1/20110323/resources/red-intrinsic-width-pc-height-pc.svg: Removed.
  • css2.1/20110323/resources/red-intrinsic-width-ratio.svg: Removed.
  • css2.1/20110323/resources/red-intrinsic-width.svg: Removed.
  • fast/backgrounds/size/contain-and-cover-zoomed.html: Removed.
  • fast/images/percent-height-image-expected.txt:
  • fast/images/percent-height-image.html:
  • platform/mac-snowleopard/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Added.
  • platform/mac-snowleopard/svg/zoom/page/zoom-foreignObject-expected.png: Added.
  • platform/mac/css1/text_properties/vertical_align-expected.txt:
  • platform/mac/css2.1/20110323/background-intrinsic-001-expected.png: Removed.
  • platform/mac/css2.1/20110323/background-intrinsic-001-expected.txt: Removed.
  • platform/mac/css2.1/20110323/background-intrinsic-002-expected.png: Removed.
  • platform/mac/css2.1/20110323/background-intrinsic-002-expected.txt: Removed.
  • platform/mac/css2.1/20110323/background-intrinsic-003-expected.png: Removed.
  • platform/mac/css2.1/20110323/background-intrinsic-003-expected.txt: Removed.
  • platform/mac/css2.1/20110323/background-intrinsic-004-expected.png: Removed.
  • platform/mac/css2.1/20110323/background-intrinsic-004-expected.txt: Removed.
  • platform/mac/css2.1/20110323/background-intrinsic-005-expected.png: Removed.
  • platform/mac/css2.1/20110323/background-intrinsic-005-expected.txt: Removed.
  • platform/mac/css2.1/20110323/background-intrinsic-006-expected.png: Removed.
  • platform/mac/css2.1/20110323/background-intrinsic-006-expected.txt: Removed.
  • platform/mac/css2.1/20110323/background-intrinsic-007-expected.png: Removed.
  • platform/mac/css2.1/20110323/background-intrinsic-007-expected.txt: Removed.
  • platform/mac/css2.1/20110323/background-intrinsic-008-expected.png: Removed.
  • platform/mac/css2.1/20110323/background-intrinsic-008-expected.txt: Removed.
  • platform/mac/css2.1/20110323/background-intrinsic-009-expected.png: Removed.
  • platform/mac/css2.1/20110323/background-intrinsic-009-expected.txt: Removed.
  • platform/mac/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Removed.
  • platform/mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Removed.
  • platform/mac/fast/block/float/015-expected.png:
  • platform/mac/fast/block/float/015-expected.txt:
  • platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt:
  • platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.txt:
  • platform/mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Removed.
  • platform/mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt: Removed.
  • platform/mac/svg/as-background-image/background-image-tiled-expected.png: Removed.
  • platform/mac/svg/as-background-image/background-image-tiled-expected.txt: Removed.
  • platform/mac/svg/as-background-image/same-image-two-instances-background-image-expected.png: Removed.
  • platform/mac/svg/as-background-image/same-image-two-instances-background-image-expected.txt: Removed.
  • platform/mac/svg/as-background-image/svg-as-background-4-expected.png:
  • platform/mac/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/mac/svg/as-image/animated-svg-as-image-expected.png:
  • platform/mac/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Removed.
  • platform/mac/svg/as-image/img-preserveAspectRatio-support-1-expected.txt: Removed.
  • platform/mac/svg/as-image/same-image-two-instances-expected.png: Removed.
  • platform/mac/svg/as-image/same-image-two-instances-expected.txt: Removed.
  • platform/mac/svg/as-image/svg-as-relative-image-expected.png:
  • platform/mac/svg/as-image/svg-as-relative-image-with-explicit-size-expected.png: Removed.
  • platform/mac/svg/as-image/svg-as-relative-image-with-explicit-size-expected.txt: Removed.
  • platform/mac/svg/as-image/svg-image-change-content-size-expected.png: Removed.
  • platform/mac/svg/as-image/svg-image-change-content-size-expected.txt: Removed.
  • platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png:
  • platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
  • platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.png: Removed.
  • platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.txt: Removed.
  • platform/mac/svg/zoom/page/zoom-background-images-expected.png: Removed.
  • platform/mac/svg/zoom/page/zoom-background-images-expected.txt: Removed.
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Removed.
  • platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Removed.
  • platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Removed.
  • platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Removed.
  • platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Removed.
  • platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Removed.
  • svg/as-background-image/background-image-preserveaspectRatio-support.html: Removed.
  • svg/as-background-image/background-image-tiled.html: Removed.
  • svg/as-background-image/resources/construction-tape.svg: Removed.
  • svg/as-background-image/resources/hearts.svg:
  • svg/as-background-image/same-image-two-instances-background-image.html: Removed.
  • svg/as-image/img-preserveAspectRatio-support-1.html: Removed.
  • svg/as-image/resources/circle-default-meet.svg: Removed.
  • svg/as-image/resources/circle-default-none.svg: Removed.
  • svg/as-image/resources/circle-default-slice.svg: Removed.
  • svg/as-image/resources/circle-nosize.svg: Removed.
  • svg/as-image/resources/circle-viewbox-default.svg: Removed.
  • svg/as-image/resources/circle-viewbox-meet.svg: Removed.
  • svg/as-image/resources/circle-viewbox-none.svg: Removed.
  • svg/as-image/resources/circle-viewbox-slice.svg: Removed.
  • svg/as-image/resources/green-relative-size-rect.svg:
  • svg/as-image/same-image-two-instances.html: Removed.
  • svg/as-image/svg-as-relative-image-with-explicit-size.html: Removed.
  • svg/as-image/svg-image-change-content-size.xhtml: Removed.
  • svg/zoom/page/resources/relative-sized-background-with-viewBox.svg: Removed.
  • svg/zoom/page/zoom-background-image-tiled.html: Removed.
  • svg/zoom/page/zoom-background-images.html: Removed.
  • svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html: Removed.
  • svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox.html: Removed.
  • svg/zoom/page/zoom-svg-as-background-with-relative-size.html: Removed.
11:51 AM Changeset in webkit [98507] by eric.carlson@apple.com
  • 5 edits in trunk

Constructors for all TextTrack interfaces should be available on DOMWindow
​https://bugs.webkit.org/show_bug.cgi?id=70734

Source/WebCore:

Reviewed by Sam Weinig.

window-properties-expected.txt and global-constructors-expected.txt updated for this change.

  • page/DOMWindow.idl: Add HTMLTrackElement, TextTrack, and TextTrackCueList.

LayoutTests:

Reviewed by Sam Weinig.

  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
11:41 AM Changeset in webkit [98506] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r93108): Shadow DOM media controls created for plug-in backed media elements.
​https://bugs.webkit.org/show_bug.cgi?id=70872

Reviewed by Eric Carlson.

r93108 added a call to HTMLMediaElement::configureMediaControls() in
HTMLMediaElement::prepareForLoad(), which creates shadow DOM media
controls and is only appropriate to call when media elements are not
backed by plug-in proxies.

Resolve this by refactoring configureMediaControls() to do the right
thing for the plug-in proxy case by calling MediaPlayer::setControls().

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::attributeChanged): Call
configureMediaControls() directly and remove the preprocessor
conditional.
(WebCore::HTMLMediaElement::configureMediaControls): Call
MediaPlayer::setControls() if PLUGIN_PROXY_FOR_VIDEO is enabled.

11:36 AM Changeset in webkit [98505] by jonlee@apple.com
  • 4 edits
    2 adds in trunk

selectedIndex gets set from -1 to 0 when modifying options
​https://bugs.webkit.org/show_bug.cgi?id=70547
<rdar://problem/8388856>

Reviewed by Darin Adler.

Source/WebCore:

Changing the text causes a recalculation of the list items, which in the menu list case
forces the first element to be selected. We check the value of the selected option prior,
and restore it if it differs.

Test: fast/dom/HTMLSelectElement/selected-index-preserved-when-option-text-changes.html

  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::setText):

  • html/HTMLSelectElement.h: promote usesMenuList() from private to public for use by HTMLOptionElement

LayoutTests:

The added tests set the selected index to either -1 or 1 (a legitimate value), and then change
the text, value, and label of the option. In all cases, the selected index should remain unchanged.

  • fast/dom/HTMLSelectElement/selected-index-preserved-when-option-text-changes-expected.txt: Added.
  • fast/dom/HTMLSelectElement/selected-index-preserved-when-option-text-changes.html: Added.
11:29 AM Changeset in webkit [98504] by zherczeg@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add new CSS escape sequence parsing tests
​https://bugs.webkit.org/show_bug.cgi?id=70909

Reviewed by Darin Adler.

Test escape various sequences terminated by \n \f \r and \r\n.

  • fast/css/parsing-css-escapes-expected.txt: Added.
  • fast/css/parsing-css-escapes.html: Added.
11:11 AM Changeset in webkit [98503] by ap@apple.com
  • 12 edits in trunk/Source

Embedded PDFs should be known to DocumentLoader
​https://bugs.webkit.org/show_bug.cgi?id=70864

Reviewed by Darin Adler.

  • WebProcess/Plugins/Plugin.h: Plugin stream load notifications now contain a suggested file name, in case the plug-in wants to save the file properly.
  • WebProcess/Plugins/PDF/BuiltInPDFView.h:
  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp: (WebKit::BuiltInPDFView::addArchiveResource): Add the PDF as resource in DocumentLoader. (WebKit::BuiltInPDFView::pdfDocumentDidLoad): Call addArchiveResource. (WebKit::BuiltInPDFView::initialize): We need to remember source URL to create a resource for that. The URL needs to match one in HitTestResult, so we can't use response URL. (WebKit::BuiltInPDFView::streamDidReceiveResponse): Remember suggested file name, so that we could put it in archive resource later. (WebKit::BuiltInPDFView::manualStreamDidReceiveResponse): Ditto.
  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::streamDidReceiveResponse): (WebKit::PluginControllerProxy::manualStreamDidReceiveResponse): Pass an empty string for suggested file name. No plug-in that runs in a separate process cares about it, so it's not sent to the plugin process.
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::streamDidReceiveResponse): (WebKit::NetscapePlugin::manualStreamDidReceiveResponse):
  • WebProcess/Plugins/Netscape/NetscapePlugin.h: Updated for new signatures.
  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::streamDidReceiveResponse): (WebKit::PluginProxy::manualStreamDidReceiveResponse):
  • WebProcess/Plugins/PluginProxy.h: Updated for new signatures.
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::Stream::didReceiveResponse): (WebKit::PluginView::manualLoadDidReceiveResponse): Pass suggested file name to plug-in, in case the plug-in wants to save the file properly.
10:56 AM Changeset in webkit [98502] by rniwa@webkit.org
  • 2 edits
    18 adds in trunk/LayoutTests

Chromium Mac editing test rebaseline.

  • platform/chromium-cg-mac-leopard/platform/mac/editing: Added.
  • platform/chromium-cg-mac-leopard/platform/mac/editing/pasteboard: Added.
  • platform/chromium-cg-mac-leopard/platform/mac/editing/pasteboard/dataTransfer-set-data-file-url-expected.png: Added.
  • platform/chromium-mac-leopard/http/tests/security: Added.
  • platform/chromium-mac-leopard/http/tests/security/dataTransfer-set-data-file-url-expected.png: Added.
  • platform/chromium-mac-leopard/platform/mac: Added.
  • platform/chromium-mac-leopard/platform/mac/editing: Added.
  • platform/chromium-mac-leopard/platform/mac/editing/pasteboard: Added.
  • platform/chromium-mac-leopard/platform/mac/editing/pasteboard/dataTransfer-set-data-file-url-expected.png: Added.
  • platform/chromium-mac-snowleopard/http: Added.
  • platform/chromium-mac-snowleopard/http/tests: Added.
  • platform/chromium-mac-snowleopard/http/tests/security: Added.
  • platform/chromium-mac-snowleopard/http/tests/security/dataTransfer-set-data-file-url-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform: Added.
  • platform/chromium-mac-snowleopard/platform/mac: Added.
  • platform/chromium-mac-snowleopard/platform/mac/editing: Added.
  • platform/chromium-mac-snowleopard/platform/mac/editing/pasteboard: Added.
  • platform/chromium-mac-snowleopard/platform/mac/editing/pasteboard/dataTransfer-set-data-file-url-expected.png: Added.
  • platform/chromium/test_expectations.txt:
10:55 AM Changeset in webkit [98501] by mhahnenberg@apple.com
  • 89 edits in trunk/Source

Remove getOwnPropertySlotVirtual
​https://bugs.webkit.org/show_bug.cgi?id=70741

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Removed all declarations and definitions of getOwnPropertySlotVirtual.
Also replaced all call sites to getOwnPropertyVirtualVirtual with a
corresponding lookup in the MethodTable.

  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:

(JSC::::getOwnPropertyDescriptor):

(JSC::DebuggerActivation::getOwnPropertySlot):

  • debugger/DebuggerActivation.h:
  • runtime/Arguments.cpp:
  • runtime/Arguments.h:
  • runtime/ArrayConstructor.cpp:
  • runtime/ArrayConstructor.h:
  • runtime/ArrayPrototype.cpp:
  • runtime/ArrayPrototype.h:
  • runtime/BooleanPrototype.cpp:
  • runtime/BooleanPrototype.h:
  • runtime/DateConstructor.cpp:
  • runtime/DateConstructor.h:
  • runtime/DatePrototype.cpp:
  • runtime/DatePrototype.h:

(JSC::DatePrototype::create):

  • runtime/ErrorPrototype.cpp:
  • runtime/ErrorPrototype.h:
  • runtime/JSActivation.cpp:
  • runtime/JSActivation.h:
  • runtime/JSArray.cpp:

(JSC::JSArray::getOwnPropertySlotByIndex):

  • runtime/JSArray.h:
  • runtime/JSByteArray.cpp:
  • runtime/JSByteArray.h:
  • runtime/JSCell.cpp:
  • runtime/JSCell.h:
  • runtime/JSFunction.cpp:

(JSC::JSFunction::getOwnPropertyDescriptor):
(JSC::JSFunction::getOwnPropertyNames):
(JSC::JSFunction::put):

  • runtime/JSFunction.h:
  • runtime/JSGlobalObject.cpp:
  • runtime/JSGlobalObject.h:
  • runtime/JSNotAnObject.cpp:
  • runtime/JSNotAnObject.h:
  • runtime/JSONObject.cpp:

(JSC::Stringifier::Holder::appendNextProperty):
(JSC::Walker::walk):

  • runtime/JSONObject.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::getOwnPropertySlotByIndex):
(JSC::JSObject::hasOwnProperty):

  • runtime/JSObject.h:

(JSC::JSCell::fastGetOwnPropertySlot):
(JSC::JSObject::getPropertySlot):
(JSC::JSValue::get):

  • runtime/JSStaticScopeObject.cpp:
  • runtime/JSStaticScopeObject.h:
  • runtime/JSString.cpp:

(JSC::JSString::getOwnPropertySlot):

  • runtime/JSString.h:
  • runtime/MathObject.cpp:
  • runtime/MathObject.h:

(JSC::MathObject::create):

  • runtime/NumberConstructor.cpp:
  • runtime/NumberConstructor.h:
  • runtime/NumberPrototype.cpp:
  • runtime/NumberPrototype.h:
  • runtime/ObjectConstructor.cpp:
  • runtime/ObjectConstructor.h:
  • runtime/ObjectPrototype.cpp:
  • runtime/ObjectPrototype.h:
  • runtime/RegExpConstructor.cpp:
  • runtime/RegExpConstructor.h:
  • runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::createStructure):

  • runtime/RegExpObject.cpp:
  • runtime/RegExpObject.h:
  • runtime/RegExpPrototype.cpp:
  • runtime/RegExpPrototype.h:
  • runtime/StringConstructor.cpp:
  • runtime/StringConstructor.h:
  • runtime/StringObject.cpp:
  • runtime/StringObject.h:
  • runtime/StringPrototype.cpp:
  • runtime/StringPrototype.h:

Source/JavaScriptGlue:

Removed all declarations and definitions of getOwnPropertySlotVirtual.
Also replaced all call sites to getOwnPropertyVirtualVirtual with a
corresponding lookup in the MethodTable.

  • UserObjectImp.cpp:
  • UserObjectImp.h:

Source/WebCore:

No new tests.

Removed all declarations and definitions of getOwnPropertySlotVirtual.
Also replaced all call sites to getOwnPropertyVirtualVirtual with a
corresponding lookup in the MethodTable.

  • WebCore.exp.in:
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::DialogHandler::returnValue):

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::getOwnPropertySlot):

  • bindings/js/JSDOMWindowShell.h:
  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::getSparseIndex):
(WebCore::CloneSerializer::getProperty):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorDeclaration):
(GenerateConstructorDefinition):

  • bridge/objc/objc_runtime.h:
  • bridge/objc/objc_runtime.mm:
  • bridge/qt/qt_runtime.cpp:
  • bridge/qt/qt_runtime.h:
  • bridge/runtime_array.cpp:
  • bridge/runtime_array.h:
  • bridge/runtime_method.cpp:
  • bridge/runtime_method.h:
  • bridge/runtime_object.cpp:
  • bridge/runtime_object.h:

Source/WebKit2:

Removed all declarations and definitions of getOwnPropertySlotVirtual.
Also replaced all call sites to getOwnPropertyVirtualVirtual with a
corresponding lookup in the MethodTable.

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:
  • WebProcess/Plugins/Netscape/JSNPObject.h:
10:54 AM Changeset in webkit [98500] by alex
  • 4 edits in trunk

2011-10-26 Alejandro G. Castro <​alex@igalia.com>

[GTK] Update NEWS and configure.ac for 1.7.1 release
​https://bugs.webkit.org/show_bug.cgi?id=70932

Reviewed by Martin Robinson.

  • configure.ac: Bumped version number.

2011-10-26 Carlos Garcia Campos <​cgarcia@igalia.com>

[GTK] Update NEWS and configure.ac for 1.7.1 release
​https://bugs.webkit.org/show_bug.cgi?id=70932

Reviewed by Martin Robinson.

  • NEWS: Added release notes.
10:53 AM Changeset in webkit [98499] by ojan@chromium.org
  • 3 edits in trunk/LayoutTests

Fix typo. The expected results don't change.

  • fast/writing-mode/borders.html:
  • fast/writing-mode/margins.html:
10:45 AM Changeset in webkit [98498] by alex
  • 10 edits in trunk

2011-10-26 Alejandro G. Castro <​alex@igalia.com>

[GTK] [WK2] Add WebKit2 distcheck support
​https://bugs.webkit.org/show_bug.cgi?id=70933

Reviewed by Martin Robinson.

  • GNUmakefile.am: Added WebKit2 compilation to the distcheck.
  • configure.ac: Removed WebKit2 doc generation for the moment.

2011-10-26 Alejandro G. Castro <​alex@igalia.com>

[GTK] [WK2] Add WebKit2 distcheck support
​https://bugs.webkit.org/show_bug.cgi?id=70933

Reviewed by Martin Robinson.

  • GNUmakefile.list.am: Add MemoryStatistics.h to the sources list.

2011-10-26 Alejandro G. Castro <​alex@igalia.com>

[GTK] [WK2] Add WebKit2 distcheck support
​https://bugs.webkit.org/show_bug.cgi?id=70933

Reviewed by Martin Robinson.

  • GNUmakefile.am: Add a bunch of missing files from API and sources, also include more files in the EXTRA_DIST.
  • UIProcess/API/gtk/docs/GNUmakefile.am: Add the version.xml to the cleaning section.

2011-10-26 Alejandro G. Castro <​alex@igalia.com>

[GTK] [WK2] Add WebKit2 distcheck support
​https://bugs.webkit.org/show_bug.cgi?id=70933

Reviewed by Martin Robinson.

  • WebKitTestRunner/GNUmakefile.am: Add missing files to the sources and EXTRA_DIST.
10:40 AM Changeset in webkit [98497] by alex
  • 5 edits in trunk/Source/WebKit2

2011-10-26 Carlos Garcia Campos <​cgarcia@igalia.com>

[GTK] Fix gtk-doc warnings and style issues in WebKit2 GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=70930

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitBackForwardListItem.cpp:
  • UIProcess/API/gtk/WebKitSettings.cpp: (webkit_settings_class_init):
  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
10:35 AM Changeset in webkit [98496] by alex
  • 4 edits in trunk/Source

2011-10-26 Alejandro G. Castro <​alex@igalia.com>

[GTK] Fix distcheck compilation
​https://bugs.webkit.org/show_bug.cgi?id=70921

Add EventTargetFactory.in to the dist files, required after
r98388.

Reviewed by Martin Robinson.

  • GNUmakefile.am:

2011-10-26 Alejandro G. Castro <​alex@igalia.com>

[GTK] Fix distcheck compilation
​https://bugs.webkit.org/show_bug.cgi?id=70921

Add new files required by doc compilation to the clean process.

Reviewed by Martin Robinson.

  • docs/GNUmakefile.am:
10:12 AM Changeset in webkit [98495] by msaboff@apple.com
  • 6 edits in trunk/Source

Increase StringImpl Flag Bits for 8 bit Strings
​https://bugs.webkit.org/show_bug.cgi?id=70937

Increased the number of bits used for flags in StringImpl
from 6 to 8 bits. This frees up 2 flag bits that will be
used for 8-bit string support. Updated hash methods accordingly.
Changed hash value masking from the low bits to the high
bits.

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • create_hash_table:
  • wtf/StringHasher.h:

(WTF::StringHasher::hash):

  • wtf/text/StringImpl.h:

Source/WebCore:

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHashValue):

10:06 AM Changeset in webkit [98494] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Use the right contents scale factor for non-Mac plug-ins
​https://bugs.webkit.org/show_bug.cgi?id=70939

Reviewed by Adam Roben.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::paint):
(WebKit::PluginProxy::geometryDidChange):
(WebKit::PluginProxy::update):

10:05 AM Changeset in webkit [98493] by Dimitri Glazkov
  • 7 edits
    2 deletes in branches/chromium/912

Merge 98492 - REGRESSION (r94887): Scrolling the HTML spec is more jerky now than it was (regression)
​https://bugs.webkit.org/show_bug.cgi?id=70857

Source/WebCore:

Revert r94887, because it regressed performance.

Rubber-stamped by Antti Koivisto.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::parentStylePreventsSharing):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkSelector):

  • dom/Element.cpp:

(WebCore::Element::recalcStyle):
(WebCore::checkForSiblingStyleChanges):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::childrenAffectedByDirectAdjacentRules):
(WebCore::InheritedFlags::setChildrenAffectedByDirectAdjacentRules):

LayoutTests:

Rubber-stamped by Antti Koivisto.

  • fast/css/adjacent-sibling-selector-expected.txt: Removed.
  • fast/css/adjacent-sibling-selector.html: Removed.

TBR=Dimitri Glazkov
Review URL: ​http://codereview.chromium.org/8390051

9:58 AM Changeset in webkit [98492] by Dimitri Glazkov
  • 7 edits
    2 deletes in trunk

REGRESSION (r94887): Scrolling the HTML spec is more jerky now than it was (regression)
​https://bugs.webkit.org/show_bug.cgi?id=70857

Source/WebCore:

Revert r94887, because it regressed performance.

Rubber-stamped by Antti Koivisto.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::parentStylePreventsSharing):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkSelector):

  • dom/Element.cpp:

(WebCore::Element::recalcStyle):
(WebCore::checkForSiblingStyleChanges):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::childrenAffectedByDirectAdjacentRules):
(WebCore::InheritedFlags::setChildrenAffectedByDirectAdjacentRules):

LayoutTests:

Rubber-stamped by Antti Koivisto.

  • fast/css/adjacent-sibling-selector-expected.txt: Removed.
  • fast/css/adjacent-sibling-selector.html: Removed.
9:30 AM Changeset in webkit [98491] by mitz@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Build fix.

Reverted r98488, which caused the scripts’ status messages to be included in the generated
files.

  • create_hash_table:
  • create_jit_stubs:
9:27 AM Changeset in webkit [98490] by kbalazs@webkit.org
  • 3 edits in trunk/LayoutTests

inspector/cookie-parser.html is a flaky crash
​https://bugs.webkit.org/show_bug.cgi?id=62662

Unreviewed Qt-Debug gardening.

Add CRASH+PASS expectation instead of the skipping madness
because the first inspector test is always a flaky crash,
no matter which one is that.

  • platform/qt/Skipped:
  • platform/qt/test_expectations.txt:
9:20 AM Changeset in webkit [98489] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Need workaround for the red crossed circle in the status bar not bringing up the console when clicked
​https://bugs.webkit.org/show_bug.cgi?id=70928

Reviewed by Pavel Feldman.

  • inspector/front-end/inspector.css:

(#error-count-img):
(#error-count + #warning-count-img):
(#warning-count-img):

  • inspector/front-end/inspector.js:

(WebInspector._updateErrorAndWarningCounts):

9:05 AM Changeset in webkit [98488] by vestbo@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Don't print regular output to STDERR when generating hashtables and JIT stubs

Reviewed by Simon Hausmann.

9:02 AM Changeset in webkit [98487] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening.

[Qt][WK2] fast/transforms/scrollIntoView-transformed.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=70935

[Qt][WK2] Metric mismatches (fast/text/justify-padding-distribution.html and svg/as-object/svg-embedded-in-html-in-iframe.html)
​https://bugs.webkit.org/show_bug.cgi?id=70915
The test became flaky after added platform result.

Skip flaky tests.

  • platform/qt-wk2/Skipped:
8:48 AM Changeset in webkit [98486] by reed@google.com
  • 5 edits in trunk

[skia] replace offscreen technique with native support for antialiased clipping
​https://bugs.webkit.org/show_bug.cgi?id=70748

Reviewed by Stephen White.

~100 layout tests need to be rebaselined, as the native aa-clipping differs sometimes in the low
bits of the result. Other than that, the results should be the same, except that now the drawing
can go directly to the canvas, rather than being direct offscreen and then have that result
"clipped" during the restore. This has the effect of allowing LCD text to be drawing inside a
antialiased clip area.

Source/WebCore:

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::State::State):
(WebCore::PlatformContextSkia::State::cloneInheritedProperties):
(WebCore::PlatformContextSkia::clipPathAntiAliased):
(WebCore::PlatformContextSkia::restore):

LayoutTests:

  • platform/chromium/test_expectations.txt:
8:43 AM Changeset in webkit [98485] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

[GTK] Add missing symbols to WebKit2 gtk-doc files
​https://bugs.webkit.org/show_bug.cgi?id=70927

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add sections for

WebKitBackForwardList, WebKitBackForwardListItem and WebKitSettings.

  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add missing symbols.
  • UIProcess/API/gtk/docs/webkit2gtk.types: Add missing types.
8:40 AM Changeset in webkit [98484] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

[GTK] Inconsistent name of WebKitSettings macros
​https://bugs.webkit.org/show_bug.cgi?id=70924

Reviewed by Martin Robinson.

Rename WEBKIT_TYPE_WEB_SETTINGS as WEBKIT_TYPE_SETTINGS and
WEBKIT_IS_WEB_SETTINGS as WEBKIT_IS_SETTINGS.

  • UIProcess/API/gtk/WebKitSettings.cpp:

(webkit_settings_init):
(webkit_settings_new):
(webkit_settings_get_enable_javascript):
(webkit_settings_set_enable_javascript):
(webkit_settings_get_auto_load_images):
(webkit_settings_set_auto_load_images):
(webkit_settings_get_load_icons_ignoring_image_load_setting):
(webkit_settings_set_load_icons_ignoring_image_load_setting):
(webkit_settings_get_enable_offline_web_application_cache):
(webkit_settings_set_enable_offline_web_application_cache):
(webkit_settings_get_enable_html5_local_storage):
(webkit_settings_set_enable_html5_local_storage):
(webkit_settings_get_enable_html5_database):
(webkit_settings_set_enable_html5_database):
(webkit_settings_get_enable_xss_auditor):
(webkit_settings_set_enable_xss_auditor):
(webkit_settings_get_enable_frame_flattening):
(webkit_settings_set_enable_frame_flattening):
(webkit_settings_get_enable_plugins):
(webkit_settings_set_enable_plugins):
(webkit_settings_get_enable_java):
(webkit_settings_set_enable_java):
(webkit_settings_get_javascript_can_open_windows_automatically):
(webkit_settings_set_javascript_can_open_windows_automatically):
(webkit_settings_get_enable_hyperlink_auditing):
(webkit_settings_set_enable_hyperlink_auditing):

  • UIProcess/API/gtk/WebKitSettings.h:
8:27 AM Changeset in webkit [98483] by Nikolas Zimmermann
  • 49 edits
    94 adds
    2 deletes in trunk

2011-10-26 Nikolas Zimmermann <​nzimmermann@rim.com>

CSS 2.1 failure: background-intrinsic-*
​https://bugs.webkit.org/show_bug.cgi?id=47156

Reviewed by Antti Koivisto.

Add all *intrinsic* tests from the CSS 2.1 Testsuite - we pass all of them now.
All tests regarding SVG are now imported in LayoutTests, none are failing anymore.

Add several new testcases covering the SVG Image size negotiation logic, as defined in CSS 2.1.

  • css2.1/20110323/background-intrinsic-001.htm: Added.
  • css2.1/20110323/background-intrinsic-002.htm: Added.
  • css2.1/20110323/background-intrinsic-003.htm: Added.
  • css2.1/20110323/background-intrinsic-004.htm: Added.
  • css2.1/20110323/background-intrinsic-005.htm: Added.
  • css2.1/20110323/background-intrinsic-006.htm: Added.
  • css2.1/20110323/background-intrinsic-007.htm: Added.
  • css2.1/20110323/background-intrinsic-008.htm: Added.
  • css2.1/20110323/background-intrinsic-009.htm: Added.
  • css2.1/20110323/resources/green-intrinsic-height-ratio.svg: Added.
  • css2.1/20110323/resources/green-intrinsic-height.svg: Added.
  • css2.1/20110323/resources/green-intrinsic-none.svg: Added.
  • css2.1/20110323/resources/green-intrinsic-ratio-landscape.svg: Added.
  • css2.1/20110323/resources/green-intrinsic-ratio-portrait.svg: Added.
  • css2.1/20110323/resources/green-intrinsic-width-height.svg: Added.
  • css2.1/20110323/resources/green-intrinsic-width-pc-height-pc.svg: Added.
  • css2.1/20110323/resources/green-intrinsic-width-ratio.svg: Added.
  • css2.1/20110323/resources/green-intrinsic-width.svg: Added.
  • css2.1/20110323/resources/red-intrinsic-height-ratio.svg: Added.
  • css2.1/20110323/resources/red-intrinsic-height.svg: Added.
  • css2.1/20110323/resources/red-intrinsic-none.svg: Added.
  • css2.1/20110323/resources/red-intrinsic-ratio-landscape.svg: Added.
  • css2.1/20110323/resources/red-intrinsic-ratio-portrait.svg: Added.
  • css2.1/20110323/resources/red-intrinsic-width-height.svg: Added.
  • css2.1/20110323/resources/red-intrinsic-width-pc-height-pc.svg: Added.
  • css2.1/20110323/resources/red-intrinsic-width-ratio.svg: Added.
  • css2.1/20110323/resources/red-intrinsic-width.svg: Added.
  • fast/backgrounds/size/contain-and-cover-zoomed.html: Added.
  • fast/images/percent-height-image-expected.txt: Update results, testcase is fixed now.
  • fast/images/percent-height-image.html: Make test async, to make it work cross-browser. With this patch we now pass this testcase.
  • platform/mac-snowleopard/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Removed.
  • platform/mac-snowleopard/svg/zoom/page/zoom-foreignObject-expected.png: Removed.
  • platform/mac/css1/text_properties/vertical_align-expected.txt: Update for rounding differences.
  • platform/mac/css2.1/20110323/background-intrinsic-001-expected.png: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-002-expected.png: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-002-expected.txt: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-003-expected.png: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-003-expected.txt: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-004-expected.png: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-004-expected.txt: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-005-expected.png: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-005-expected.txt: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-006-expected.png: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-006-expected.txt: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-007-expected.png: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-007-expected.txt: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-008-expected.png: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-008-expected.txt: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-009-expected.png: Added.
  • platform/mac/css2.1/20110323/background-intrinsic-009-expected.txt: Added.
  • platform/mac/fast/backgrounds/size/contain-and-cover-expected.png: Updated for rounding differences.
  • platform/mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
  • platform/mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
  • platform/mac/fast/block/float/015-expected.png: Slight changes, due 49x50 -> 50x50 size change.
  • platform/mac/fast/block/float/015-expected.txt: Ditto.
  • platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Slight changes due to rounding.
  • platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Ditto.
  • platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.png: Ditto.
  • platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.txt: Ditto.
  • platform/mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Added.
  • platform/mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt: Added.
  • platform/mac/svg/as-background-image/background-image-tiled-expected.png: Added.
  • platform/mac/svg/as-background-image/background-image-tiled-expected.txt: Added.
  • platform/mac/svg/as-background-image/same-image-two-instances-background-image-expected.png: Added.
  • platform/mac/svg/as-background-image/same-image-two-instances-background-image-expected.txt: Added.
  • platform/mac/svg/as-background-image/svg-as-background-4-expected.png: Adapt to preserveAspectRatio changes in hearts.svg.
  • platform/mac/svg/as-border-image/svg-as-border-image-expected.png: This needed a rebaseline, it was forgotten before.
  • platform/mac/svg/as-image/animated-svg-as-image-expected.png: Progression, now both images share the same size & ratio, as desired.
  • platform/mac/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/mac/svg/as-image/img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/mac/svg/as-image/same-image-two-instances-expected.png: Added.
  • platform/mac/svg/as-image/same-image-two-instances-expected.txt: Added.
  • platform/mac/svg/as-image/svg-as-relative-image-expected.png: Adapt to green-relative-size-rect.svg - a circle got added to make it easier to compare.
  • platform/mac/svg/as-image/svg-as-relative-image-with-explicit-size-expected.png: Added.
  • platform/mac/svg/as-image/svg-as-relative-image-with-explicit-size-expected.txt: Added.
  • platform/mac/svg/as-image/svg-image-change-content-size-expected.png: Added.
  • platform/mac/svg/as-image/svg-image-change-content-size-expected.txt: Added.
  • platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Updated, scrollbars are gone - now matching Opera/FF.
  • platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Ditto.
  • platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-background-images-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-background-images-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.png: Updated, scrollbars are gone - now matching Opera/FF.
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt: Ditto.
  • platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Added.
  • svg/as-background-image/background-image-preserveaspectRatio-support.html: Added.
  • svg/as-background-image/background-image-tiled.html: Added.
  • svg/as-background-image/resources/construction-tape.svg: Added.
  • svg/as-background-image/resources/hearts.svg: Fix testcase, by adding pAR="none", which is now respected. Now the image looks as desired across Opera/FF and us.
  • svg/as-background-image/same-image-two-instances-background-image.html: Added.
  • svg/as-image/img-preserveAspectRatio-support-1.html: Added.
  • svg/as-image/resources/circle-default-meet.svg: Added.
  • svg/as-image/resources/circle-default-none.svg: Added.
  • svg/as-image/resources/circle-default-slice.svg: Added.
  • svg/as-image/resources/circle-nosize.svg: Added.
  • svg/as-image/resources/circle-viewbox-default.svg: Added.
  • svg/as-image/resources/circle-viewbox-meet.svg: Added.
  • svg/as-image/resources/circle-viewbox-none.svg: Added.
  • svg/as-image/resources/circle-viewbox-slice.svg: Added.
  • svg/as-image/resources/green-relative-size-rect.svg: Use relative units everywhere as intended. Add circle to make it easy to spot ratio changes.
  • svg/as-image/same-image-two-instances.html: Added.
  • svg/as-image/svg-as-relative-image-with-explicit-size.html: Added.
  • svg/as-image/svg-image-change-content-size.xhtml: Added.
  • svg/zoom/page/resources/relative-sized-background-with-viewBox.svg: Added.
  • svg/zoom/page/zoom-background-image-tiled.html: Added.
  • svg/zoom/page/zoom-background-images.html: Added.
  • svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html: Added.
  • svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox.html: Added.
  • svg/zoom/page/zoom-svg-as-background-with-relative-size.html: Added.

2011-10-26 Nikolas Zimmermann <​nzimmermann@rim.com>

CSS 2.1 failure: background-intrinsic-*
​https://bugs.webkit.org/show_bug.cgi?id=47156

SVGs do not work as tiled background images
​https://bugs.webkit.org/show_bug.cgi?id=16281

Apply preserveAspectRatio and synthesize viewboxes in <img>
​https://bugs.webkit.org/show_bug.cgi?id=34521

SVG background doesn't resize properly when dimensions are changed
​https://bugs.webkit.org/show_bug.cgi?id=42944

Images with percent height inside a floated div should use intrinsic height.
​https://bugs.webkit.org/show_bug.cgi?id=45439

SVG image in HTML changes size as the window is resized
​https://bugs.webkit.org/show_bug.cgi?id=52045

Reviewed by Antti Koivisto.

Implement intrinsic sizing support for SVGImage (svg embedded through <html:img>/<svg:image>/background-image/border-image/...).
This is demanded by CSS 2.1, and covered by new layout tests in LayoutTests/css2.1 and several new custom testcases.

Tests: css2.1/20110323/background-intrinsic-001.htm

css2.1/20110323/background-intrinsic-002.htm
css2.1/20110323/background-intrinsic-003.htm
css2.1/20110323/background-intrinsic-004.htm
css2.1/20110323/background-intrinsic-005.htm
css2.1/20110323/background-intrinsic-006.htm
css2.1/20110323/background-intrinsic-007.htm
css2.1/20110323/background-intrinsic-008.htm
css2.1/20110323/background-intrinsic-009.htm
svg/as-background-image/background-image-preserveaspectRatio-support.html (adapted from testcase from bug 34521)
svg/as-background-image/background-image-tiled.html (reduction from bug 16281)
svg/as-background-image/same-image-two-instances-background-image.html
svg/as-image/img-preserveAspectRatio-support-1.html (reduction from bug 34521)
svg/as-image/same-image-two-instances.html
svg/as-image/svg-as-relative-image-with-explicit-size.html
svg/as-image/svg-image-change-content-size.xhtml (reduction from bug 42944)
svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html

  • loader/cache/CachedImage.cpp: Enable SVGImage <-> IntSize cache. (WebCore::CachedImage::lookupImageForSize): Use recently introduced ImageBySizeCache, to lookup an image for a certain size. (WebCore::CachedImage::lookupImageForRenderer): Lookup image by renderer, which first looks up a size for a renderer, then uses lookupImageForSize(). (WebCore::createSVGImage): Refactored from createImage(), contains the SVGImage creation part only. (WebCore::CachedImage::lookupOrCreateImageForRenderer): Use recently introduced ImageBySizeCache, to dynamically create copies of m_image if needed. (WebCore::CachedImage::setContainerSizeForRenderer): For SVGImages, pass on container size handling to ImageBySizeCache. (WebCore::CachedImage::imageSizeForRenderer): Figure out the image size, respecting per-renderer overrides, for a certain renderer. (WebCore::CachedImage::computeIntrinsicDimensions): Remove unnecessary RenderObject parameter. (WebCore::CachedImage::addClientForRenderer): Special variant of addClient(), overriding the existing in CachedResource. (WebCore::CachedImage::removeClientForRenderer): Special variant of removeClient(), that also clears the image in the ImageBySizeCache. (WebCore::CachedImage::createImage): Refactor SVGImage creation into createSVGImage() free function, to be useable from lookupOrCreateImageForRenderer().
  • loader/cache/CachedImage.h: Expose removeClientForRenderer().
  • page/ChromeClient.h: (WebCore::ChromeClient::isSVGImageChromeClient): Used to identify whether a RenderSVGRoot is embedded through a SVGImage. Returns false, by default.
  • rendering/ImageBySizeCache.cpp: (WebCore::ImageBySizeCache::addClient): Assert the passed renderer is valid. (WebCore::ImageBySizeCache::removeClient): Ditto. Allow removeClient() to be called w/o prio addClient() usage. (WebCore::ImageBySizeCache::setClient): New helper function, that combines the usage of addClient/removeClient, for the use in CachedImage. (WebCore::ImageBySizeCache::imageForSize): Respect empty sizes, just return 0, instead of asserting. (WebCore::ImageBySizeCache::imageForRenderer): Added a helper that retrieves an image for a renderer, by lookup up its size and using imageForSize().
  • rendering/ImageBySizeCache.h: Expose setClient() & imageForRenderer().
  • rendering/RenderBoxModelObject.cpp: Implement CSS 2.1 intrinsic size negotiation for images. (WebCore::resolveWidthForRatio): New inline helper function used bz calculateImageIntrinsicDimensions. (WebCore::resolveHeightForRatio): Ditto. (WebCore::resolveAgainstIntrinsicWidthOrHeightAndRatio): Ditto. (WebCore::resolveAgainstIntrinsicRatio): Ditto. (WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions): New helper function, containing the main algorithm, which is a pure transcription of the spec. (WebCore::RenderBoxModelObject::calculateFillTileSize): Use new calculateImageIntrinsicDimensions() helper to figure out the intrinsic size. (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): Propagate calculateFillTileSize() result to the image resource, via setContainerSizeForRenderer(). (WebCore::RenderBoxModelObject::paintNinePieceImage): Use new calculateImageIntrinsicDimensions() helper to figure out the intrinsic size.
  • rendering/RenderBoxModelObject.h: Clarify some variable names, added calculateImageIntrinsicDimensions().
  • rendering/RenderImage.cpp: (WebCore::RenderImage::RenderImage): Use IntSize(), instead of IntSize(0, 0). (WebCore::RenderImage::updateIntrinsicSizeIfNeeded): Refactored from imageDimensionsChanged(). (WebCore::RenderImage::imageDimensionsChanged): Use updateIntrinsicSizeIfNeeded(). (WebCore::RenderImage::computeReplacedLogicalWidth): Use RenderReplaced::computeReplacedLogicalWidth() exclusively. For this to work, the intrinsic size must be correct. (WebCore::RenderImage::computeIntrinsicRatioInformation): Default implementation for non-SVGImages. (WebCore::RenderImage::needsPreferredWidthsRecalculation): Return true, just like RenderPart, if embeddedContentBox is not null. (WebCore::RenderImage::embeddedContentBox): Returns the RenderSVGRoot* renderer of the embedded SVG, if possible.
  • rendering/RenderImage.h: Remove isLogicalWidth/HeightSpecified() / computeReplacedLogicalHeight() / calcAspectRatioLogicalWidth/Height().
  • rendering/RenderImageResource.cpp: (WebCore::RenderImageResource::setContainerSizeForRenderer): Pass around new "float containerZoomFactor" parameter.
  • rendering/RenderImageResourceStyleImage.cpp: (WebCore::RenderImageResourceStyleImage::image): embeddedContentBox() is now calling image() earlier than before. We now have to handle the case that the image is pending. (WebCore::RenderImageResourceStyleImage::setContainerSizeForRenderer): Pass zoom factor.
  • rendering/RenderImageResourceStyleImage.h:
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::computePreferredLogicalWidths): Pass effective zoom to setContainerSizeForRenderer().
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::computeIntrinsicLogicalWidth): Generalized this code, as RenderImage is using it as well now. Marginal changes needed. (WebCore::RenderReplaced::computeIntrinsicLogicalHeight): Ditto. (WebCore::RenderReplaced::computeReplacedLogicalWidth): Ditto.
  • rendering/style/StyleCachedImage.cpp: (WebCore::StyleCachedImage::computeIntrinsicDimensions): Stop passing m_renderer to CachedImage, it's no longer needed. (WebCore::StyleCachedImage::setContainerSizeForRenderer): Add "float containerZoomFactor" parameter. (WebCore::StyleCachedImage::addClient): Forward to new addClientForRenderer(). (WebCore::StyleCachedImage::removeClient): Call new removeClientForRenderer() instead of removeClient(), so the ImageBySizeCache is also updated.
  • rendering/style/StyleCachedImage.h: Add "float containerZoomFactor" parameter to setContainerSizeForRenderer.
  • rendering/style/StyleGeneratedImage.h: (WebCore::StyleGeneratedImage::setContainerSizeForRenderer): Ditto.
  • rendering/style/StyleImage.h: Ditto.
  • rendering/style/StylePendingImage.h: (WebCore::StylePendingImage::setContainerSizeForRenderer): Ditto.
  • rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::layout): Always supply a container size when embedding SVGs in <svg:image>.
  • rendering/svg/RenderSVGRoot.cpp: Move "override container size" from SVGSVGElement into RenderSVGRoot, where it belongs. (WebCore::RenderSVGRoot::isEmbeddedThroughImageElement): Add helper method to determine whether we're loaded through SVGImage. (WebCore::RenderSVGRoot::computeReplacedLogicalWidth): If we have a valid container size, it has precendence (only supplied via external SVGImages). (WebCore::RenderSVGRoot::computeReplacedLogicalHeight): Ditto. (WebCore::RenderSVGRoot::layout): Remove calcViewport() usage, no need to track/override the viewport size anymore, all done in coputeReplacedLogical* now. (WebCore::RenderSVGRoot::paint): Use borderBoxRect() which now always matches the previously computed m_viewportSize. (WebCore::RenderSVGRoot::computeRectForRepaint): Ditto.
  • rendering/svg/RenderSVGRoot.h: Move "override container size" from SVGSVGElement into RenderSVGRoot, where it belongs. (WebCore::RenderSVGRoot::containerSize): (WebCore::RenderSVGRoot::setContainerSize):
  • svg/SVGLength.cpp: (WebCore::SVGLength::determineViewport): Resolve lengths against override container size in documents embedded through SVGImage.
  • svg/SVGSVGElement.cpp: Remove "override container size" handling from SVGSVGElement. (WebCore::SVGSVGElement::SVGSVGElement): Ditto. (WebCore::SVGSVGElement::currentViewBoxRect): Always synthesize a viewBox, if we're embedded through SVGImage, as demanded by SVG 1.1 2nd Edition.
  • svg/SVGSVGElement.h:
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImageChromeClient::setObserver): Helper function. (WebCore::SVGImageChromeClient::isSVGImageChromeClient): Return true, used to identify whether RenderSVGRoot is embedded through SVGImage. (WebCore::SVGImage::setContainerZoom): Forwarded to Page::setPageZoomFactor. (WebCore::SVGImage::setContainerSize): Assert that container size is not empty. We should never receive an empty container size. (WebCore::SVGImage::usesContainerSize): Adapt to override container size changes, it now lives in RenderSVGRoot instead of SVGSVGElement. (WebCore::SVGImage::size): New algorithm to figure out the size of an embedded SVG, as demanded by the CSS/SVG specs. (WebCore::SVGImage::draw): Stop calling layout() while painting! (WebCore::SVGImage::embeddedContentBox): Add helper which returns the RenderSVGRoot of the document. (WebCore::SVGImage::computeIntrinsicDimensions): Implement intrinsic ratio calculation. (WebCore::SVGImage::dataChanged): Force calling FrameView::setCanHaveScrollbars(false), as SVG images now always synthesize a viewBox, and thus never receive scrollbars.
  • svg/graphics/SVGImage.h:
7:59 AM Changeset in webkit [98482] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2011-10-26 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Mark compositing/video/video-poster.html as timing out on Mac10.6 CPU-CG.

  • platform/chromium/test_expectations.txt:
7:56 AM Changeset in webkit [98481] by kenneth@webkit.org
  • 8 edits in trunk/Source/WebCore

Properly suspend/resume Geolocation/DeviceMotion/DeviceOrientation objects
​https://bugs.webkit.org/show_bug.cgi?id=70328

Reviewed by Simon Hausmann.

Also remove checks for m_client in DeviceMotionController as it can never be null.

No new tests, as the suspend/resume functionality is not fully working yet.

  • dom/DeviceMotionController.cpp:

(WebCore::DeviceMotionController::timerFired):
(WebCore::DeviceMotionController::addListener):
(WebCore::DeviceMotionController::removeListener):
(WebCore::DeviceMotionController::removeAllListeners):
(WebCore::DeviceMotionController::suspend):
(WebCore::DeviceMotionController::resume):

  • dom/DeviceMotionController.h:
  • dom/DeviceOrientationController.cpp:

(WebCore::DeviceOrientationController::suspend):
(WebCore::DeviceOrientationController::resume):

  • dom/DeviceOrientationController.h:
  • dom/Document.cpp:

(WebCore::Document::suspendActiveDOMObjects):
(WebCore::Document::resumeActiveDOMObjects):
(WebCore::Document::stopActiveDOMObjects):

  • dom/Document.h:
  • dom/ScriptExecutionContext.h:
  • page/GeolocationController.cpp:

(WebCore::GeolocationController::GeolocationController):
(WebCore::GeolocationController::removeObserver):
(WebCore::GeolocationController::suspend):
(WebCore::GeolocationController::resume):

  • page/GeolocationController.h:
7:54 AM Changeset in webkit [98480] by kbalazs@webkit.org
  • 2 edits
    3 adds in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening.

[Qt][WK2] fast/css/font-face-descending-unicode-range.html fails
​https://bugs.webkit.org/show_bug.cgi?id=70922
Skipped

[Qt][WK2] Metric mismatches (fast/text/justify-padding-distribution.html and svg/as-object/svg-embedded-in-html-in-iframe.html)
​https://bugs.webkit.org/show_bug.cgi?id=70915
The svg test has correct pixel results so it's ok to add platform results.

  • platform/qt-wk2/Skipped:
  • platform/qt-wk2/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
7:50 AM Changeset in webkit [98479] by Lucas Forschler
  • 5 edits in branches/safari-534.52-branch/Source/WebKit2

Merged r93720.

7:44 AM Changeset in webkit [98478] by Lucas Forschler
  • 2 edits in branches/safari-534.52-branch/Source/WebCore

Merge 98178.

7:44 AM Changeset in webkit [98477] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2011-10-26 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Revert change to test_expectations.txt due to test failures.

  • platform/chromium/test_expectations.txt:
7:32 AM Changeset in webkit [98476] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-10-26 Pavel Feldman <​pfeldman@google.com>

Not reviewed: follow up to 98236 - moved inspector settings initialization earlier to unbreak settings panel.

  • inspector/front-end/TextEditorModel.js: (WebInspector.TextEditorModel):
6:56 AM Changeset in webkit [98475] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2011-10-26 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Mark compositing/video/video-poster.html as timing out on Mac10.6 GPU.

  • platform/chromium/test_expectations.txt:
6:50 AM Changeset in webkit [98474] by abecsi@webkit.org
  • 5 edits in trunk/Source/WebKit2

[Qt][WK2] Rename clean-up of QtPinchGestureRecognizer and QtViewportInteractionEngine
​https://bugs.webkit.org/show_bug.cgi?id=70903

Reviewed by Kenneth Rohde Christiansen.

Rename computeTouchCenter to computePinchCenter,
and use the plural form of coordinate where appropriate.

  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::_q_viewportUpdated):

  • UIProcess/qt/QtPinchGestureRecognizer.cpp:

(WebKit::computePinchCenter):
(WebKit::QtPinchGestureRecognizer::recognize):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::contentRectInViewportCoordinates):
(WebKit::QtViewportInteractionEngine::event):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
(WebKit::QtViewportInteractionEngine::pinchGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::scaleContent):

  • UIProcess/qt/QtViewportInteractionEngine.h:
6:34 AM Changeset in webkit [98473] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed Qt-WK2 gardening.

[Qt][WK2] Crash with http/tests/websocket/tests/hixie76/long-invalid-header.html
​https://bugs.webkit.org/show_bug.cgi?id=70917

[Qt][WK2] fast/events/drag-selects-image.html fails
​https://bugs.webkit.org/show_bug.cgi?id=70907

[Qt][WK2] Metric mismatches (fast/text/justify-padding-distribution.html and svg/as-object/svg-embedded-in-html-in-iframe.html)
​https://bugs.webkit.org/show_bug.cgi?id=70915

  • platform/qt-wk2/Skipped:
6:32 AM Changeset in webkit [98472] by Simon Hausmann
  • 40 edits in trunk/Source

Name viewport change event consistently.
​https://bugs.webkit.org/show_bug.cgi?id=70901

Patch by Zalan Bujtas <​zbujtas@gmail.com> on 2011-10-26
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Use ViewportPropertiesDidChange term consistently throughout WebKit.

No tests needed as the change is only method renaming.

  • page/Chrome.cpp:

(WebCore::Chrome::dispatchViewportPropertiesDidChange):

  • page/Chrome.h:
  • page/ChromeClient.h:

(WebCore::ChromeClient::dispatchViewportPropertiesDidChange):

  • page/Page.cpp:

(WebCore::Page::updateViewportArguments):

Source/WebKit/efl:

Use ViewportPropertiesDidChange term consistently throughout WebKit.

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::dispatchViewportPropertiesDidChange):

  • WebCoreSupport/ChromeClientEfl.h:

Source/WebKit/gtk:

Use ViewportPropertiesDidChange term consistently throughout WebKit.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::dispatchViewportPropertiesDidChange):

  • WebCoreSupport/ChromeClientGtk.h:

Source/WebKit/qt:

Use ViewportPropertiesDidChange term consistently throughout WebKit.

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::dispatchViewportPropertiesDidChange):

  • WebCoreSupport/ChromeClientQt.h:

Source/WebKit2:

Use ViewportPropertiesDidChange term consistently throughout WebKit.

  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::didChangeViewportProperties):

  • UIProcess/API/efl/PageClientImpl.h:
  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::didChangeViewportProperties):

  • UIProcess/API/gtk/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::didChangeViewportProperties):

  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::didChangeViewportProperties):

  • UIProcess/API/qt/qdesktopwebview_p.h:
  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::didChangeViewportProperties):

  • UIProcess/API/qt/qtouchwebview_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didChangeViewportProperties):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/qt/QtDesktopWebPageProxy.cpp:

(QtDesktopWebPageProxy::didChangeViewportProperties):

  • UIProcess/qt/QtDesktopWebPageProxy.h:
  • UIProcess/qt/QtTouchViewInterface.cpp:

(WebKit::QtTouchViewInterface::didChangeViewportProperties):

  • UIProcess/qt/QtTouchViewInterface.h:
  • UIProcess/qt/QtViewInterface.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::didChangeViewportProperties):

  • UIProcess/qt/QtWebPageProxy.h:
  • UIProcess/win/WebView.cpp:

(WebKit::WebView::didChangeViewportProperties):

  • UIProcess/win/WebView.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::dispatchViewportPropertiesDidChange):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
6:24 AM Changeset in webkit [98471] by senorblanco@chromium.org
  • 12 edits
    2 adds in trunk/Source

[chromium] Canvas2D should rate-limit drawing to prevent swamping the GPU process.
​https://bugs.webkit.org/show_bug.cgi?id=70367

Source/WebCore:

Reviewed by James Robinson.

Sadly, we don't have infrastructure to test this kind of GPU swamping
yet.

  • WebCore.gypi:

Add RateLimiter.* to the Chromium build.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::contentChanged):
When the layer is notified that the contents have changed, ping the
rate limiter.

  • platform/graphics/chromium/Canvas2DLayerChromium.h:
  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setContentsNeedsDisplay):
Call (new) virtual contentChanged() on a layer when its contents have
been changed (e.g., by a drawing call).

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::contentChanged):
New virtual contentChanged().

  • platform/graphics/chromium/RateLimiter.cpp: Added.

(WebCore::RateLimiter::create):
Rate limiter factory function.
(WebCore::RateLimiter::RateLimiter):
(WebCore::RateLimiter::start):
Public API to start rate limiting a context.
(WebCore::RateLimiter::stop):
Public API to stop rate limiting a context.
(WebCore::RateLimiter::rateLimitContext):
Internal timer callback when a context should be rate limited.

  • platform/graphics/chromium/RateLimiter.h: Added.
  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::WebGLLayerChromium):
Remove rate limiting timer and extension check (moved to RateLimiter).
(WebCore::WebGLLayerChromium::contentChanged):
The function formerly known as setTextureUpdated(), now renamed to
match the base class virtual contentChanged(). Call rate limiter in
CCLayerTreeHost (local implementation removed).
(WebCore::WebGLLayerChromium::setContext):
When the context is changed, stop the pending rate limiter on the old
context. Remove extension check (moved to RateLimiter).

  • platform/graphics/chromium/WebGLLayerChromium.h:

Remove rate limiting timer and extension check (moved to RateLimiter).

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::startRateLimiter):
Public API for starting per-context rate limiter.
(WebCore::CCLayerTreeHost::stopRateLimiter):
Public API for stopping per-context rate limiter.

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

Implementation of per-GraphicsContext3D RateLimiter.

Source/WebKit/chromium:

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DPrivate::markContextChanged):
Remove the call to setTextureChanged (it will be handled internally
by the compositor in setContextNeedsDisplay() instead). This decouples
GraphicsContext3D from WebGLLayerChromium a bit.

6:17 AM Changeset in webkit [98470] by Lucas Forschler
  • 3 edits in branches/safari-534.52-branch/Source/WebCore

Merge 98171.

6:10 AM Changeset in webkit [98469] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-10-26 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: fixing inspector extensions tests.

  • inspector/front-end/ConsoleMessage.js: (WebInspector.ConsoleMessageImpl):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onAddConsoleMessage):
6:03 AM Changeset in webkit [98468] by Lucas Forschler
  • 2 edits in branches/safari-534.52-branch/Source/WebKit2

Merged r98153.

6:01 AM Changeset in webkit [98467] by Lucas Forschler
  • 7 edits in branches/safari-534.52-branch/Source/WebKit2

Merged r98113.

5:58 AM Changeset in webkit [98466] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

Skip failing tests temporarily because of missing Qt Mobility on the buildbot.

  • platform/qt-arm/Skipped:
5:39 AM Changeset in webkit [98465] by Carlos Garcia Campos
  • 4 edits in trunk/Source

[GTK] Remove g_thread_init() calls from gtk-doc scanner too
​https://bugs.webkit.org/show_bug.cgi?id=70908

Reviewed by Gustavo Noronha Silva.

Source/WebKit/gtk:

  • docs/GNUmakefile.am:

Source/WebKit2:

  • UIProcess/API/gtk/docs/GNUmakefile.am:
5:33 AM Changeset in webkit [98464] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2011-10-26 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed, gardening. Mark editing/selection/designmode-no-caret.html as failing in debug mode.

  • platform/chromium/test_expectations.txt:
5:11 AM Changeset in webkit [98463] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] inspector/extensions/extensions-console.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=70905

Unreviewed gardening. Skip failing test.

  • platform/qt/Skipped:
4:44 AM Changeset in webkit [98462] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebCore

ParallelJobs path of FEConvolveMatrix is erroneous
​https://bugs.webkit.org/show_bug.cgi?id=70409

Reviewed by Zoltan Herczeg.

Covered by existing tests.

  • platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::fastSetInteriorPixels):
Reject the silly idea that bytes per pixel ratio is 3 in preserveAlphaValues mode.
The bug was hidden so far because that computation has no effect when we are going
with the full inferior area in one round (in that case clipBottom and yEnd are equals
and the value of the expression is always 0). With ParallelJobs we process sub-areas
on each thread which has triggered the issue.

3:46 AM WebKitGTK/1.6.x edited by kov@webkit.org
(diff)
2:59 AM Changeset in webkit [98461] by Simon Hausmann
  • 4 edits in trunk/Tools

[Qt][WK2] Fix failing assertion on startup of MiniBrowser -touch.

Reviewed by Tor Arne Vestbø.

We're using QScroller since r98460, which requires QWidget/QApplication. So
use QApplication and QtWidgets for the time being.

  • MiniBrowser/qt/MiniBrowser.pro:
  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::MiniBrowserApplication):
(MiniBrowserApplication::notify):

  • MiniBrowser/qt/MiniBrowserApplication.h:
2:49 AM Changeset in webkit [98460] by abecsi@webkit.org
  • 7 edits in trunk/Source/WebKit2

[Qt][WK2] Add the animations on the ViewportInteractionEngine
​https://bugs.webkit.org/show_bug.cgi?id=66664

Reviewed by Kenneth Rohde Christiansen.

Introduce a QScroller based panning and a QVariantAnimation based scale animation.
QScroller also handles flick gestures and animates overshoot.
If a pinch gesture ends, the scale animation will scale and reposition the content
such that it is within valid boundaries. The content is by default animated such
that the content position as seen in the center of the visible viewport stays
in the center, unless the content would be out of valid bounds.
The patch also simplifies the ViewportUpdateGuard by using reference counting
instead of a boolean for defering update requests.

  • UIProcess/qt/QtPanGestureRecognizer.cpp:

(WebKit::QtPanGestureRecognizer::recognize):

  • UIProcess/qt/QtPanGestureRecognizer.h:
  • UIProcess/qt/QtPinchGestureRecognizer.cpp:

(WebKit::QtPinchGestureRecognizer::recognize):

  • UIProcess/qt/QtTouchWebPageProxy.cpp:

(QtTouchWebPageProxy::doneWithTouchEvent):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::bindToScaleLimits):
(WebKit::ViewportUpdateGuard::ViewportUpdateGuard):
(WebKit::ViewportUpdateGuard::~ViewportUpdateGuard):
(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::innerBoundedScale):
(WebKit::QtViewportInteractionEngine::outerBoundedScale):
(WebKit::QtViewportInteractionEngine::updateVisibleRect):
(WebKit::QtViewportInteractionEngine::scaleAnimationStateChanged):
(WebKit::QtViewportInteractionEngine::event):
(WebKit::QtViewportInteractionEngine::stopAnimations):
(WebKit::QtViewportInteractionEngine::calculateBoundariesForScale):
(WebKit::QtViewportInteractionEngine::animateContentIntoBoundariesIfNeeded):
(WebKit::QtViewportInteractionEngine::reset):
(WebKit::QtViewportInteractionEngine::setConstraints):
(WebKit::QtViewportInteractionEngine::panGestureStarted):
(WebKit::QtViewportInteractionEngine::panGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::panGestureCancelled):
(WebKit::QtViewportInteractionEngine::panGestureEnded):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
(WebKit::QtViewportInteractionEngine::pinchGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::pinchGestureEnded):
(WebKit::QtViewportInteractionEngine::contentViewportChanged):

  • UIProcess/qt/QtViewportInteractionEngine.h:

(WebKit::QtViewportInteractionEngine::scroller):
(WebKit::QtViewportInteractionEngine::ScaleAnimation::ScaleAnimation):
(WebKit::QtViewportInteractionEngine::ScaleAnimation::updateCurrentValue):

2:41 AM Changeset in webkit [98459] by rgabor@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed skip. fast/canvas/canvas-composite-image.html failing on Qt

  • platform/qt/Skipped:
2:38 AM Changeset in webkit [98458] by yurys@chromium.org
  • 8 edits
    1 delete in trunk/Source

Unreviewed, rolling out r98393.
​http://trac.webkit.org/changeset/98393
​https://bugs.webkit.org/show_bug.cgi?id=70892

"Compilation is broken on Chromium Webkit Mac Builder (dbg) "
(Requested by yurys on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-26

Source/WebCore:

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::setMasksToBounds):
(WebCore::LayerChromium::setMaskLayer):

Source/WebKit/chromium:

  • WebKit.gypi:
  • src/WebContentLayerImpl.cpp:

(WebKit::WebContentLayerImpl::~WebContentLayerImpl):
(WebKit::WebContentLayerImpl::setDrawsContent):

  • src/WebExternalTextureLayerImpl.cpp:

(WebKit::WebExternalTextureLayerImpl::~WebExternalTextureLayerImpl):

  • src/WebLayerImpl.cpp:

(WebKit::WebLayerImpl::~WebLayerImpl):

  • tests/LayerChromiumTest.cpp:
  • tests/WebLayerTest.cpp: Removed.
2:33 AM Changeset in webkit [98457] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

Fix editing/selection/caret-mode-paragraph-keys-navigation.html for Mac
​https://bugs.webkit.org/show_bug.cgi?id=70880

Reviewed by Eric Seidel.

Use option key (instead of control key) to move between word boundaries on Mac.

  • editing/selection/caret-mode-paragraph-keys-navigation.html:
  • platform/chromium/test_expectations.txt:
2:25 AM Changeset in webkit [98456] by pfeldman@chromium.org
  • 10 edits in trunk

Web Inspector: order console message parameters for better optional parameters handling.
​https://bugs.webkit.org/show_bug.cgi?id=70809

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/Inspector.json:
  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl):
(WebInspector.ConsoleMessageImpl.prototype._formatMessage):

  • inspector/front-end/ConsoleModel.js:

(WebInspector.ConsoleModel.prototype._messageRepeatCountUpdated):
(WebInspector.ConsoleMessage.create):
(WebInspector.ConsoleDispatcher.prototype.messageAdded):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleCommandResult):
(WebInspector.ConsoleMessage.create):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onAddConsoleMessage):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):

  • inspector/front-end/inspector.js:

(WebInspector.log.logMessage):
(WebInspector.log):

LayoutTests:

  • inspector/console/console-preserve-log.html:
2:14 AM Changeset in webkit [98455] by rniwa@webkit.org
  • 1 edit
    1 add
    2 deletes in trunk/LayoutTests

Fix rebaseline done in r98439.

  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/copy-standalone-image-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/pasteboard/copy-standalone-image-expected.txt: Removed.
  • platform/chromium/editing/pasteboard/copy-standalone-image-expected.txt: Added.
2:07 AM Changeset in webkit [98454] by vsevik@chromium.org
  • 4 edits
    3 adds in trunk

Web Inspector: Debugger fails when there is an invalid watch expression.
​https://bugs.webkit.org/show_bug.cgi?id=70718

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/watch-expressions-panel-switch.html

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):

LayoutTests:

  • inspector/debugger/error-in-watch-expressions.html:
  • inspector/debugger/watch-expressions-panel-switch-expected.txt: Added.
  • inspector/debugger/watch-expressions-panel-switch.html: Added.
  • platform/chromium/inspector/debugger/watch-expressions-panel-switch-expected.txt: Added.
1:52 AM Changeset in webkit [98453] by fsamuel@chromium.org
  • 2 edits in trunk/Source/WebCore

Page Scale Factor broken when navigating history on pages with child frames
​https://bugs.webkit.org/show_bug.cgi?id=70459

Reviewed by Darin Fisher.

With frameScaleFactor now always returning 1.0 for subframes and pageScaleFactor for the mainFrame,
and there being only a single pageScaleFactor, history for scaling is broken. Scaling history is
saved on a per frame basis but restored, overriding the per-page pageScaleFactor multiple times.
As a result, sometimes pages that have subframes end up getting a scale factor of 1.0 instead
of the correct scale factor that was assigned to the main frame.

No new tests because I don't know how to test this.

  • loader/HistoryController.cpp:

(WebCore::HistoryController::restoreScrollPositionAndViewState):

1:52 AM Changeset in webkit [98452] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Filed more bugs.

  • platform/chromium/test_expectations.txt:
1:45 AM Changeset in webkit [98451] by rniwa@webkit.org
  • 3 edits
    2 adds
    1 delete in trunk/LayoutTests

More Chromium test expectation updates. Filed a bunch of bugs to track real failures
and removed erroneous failing test expectations.

  • platform/chromium-cg-mac-leopard/editing/deleting/merge-whitespace-pre-expected.png:
  • platform/chromium-mac-leopard/editing/deleting/merge-whitespace-pre-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/merge-whitespace-pre-expected.png: Added.
  • platform/chromium-mac/editing/deleting/merge-whitespace-pre-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
1:29 AM Changeset in webkit [98450] by Simon Hausmann
  • 10 edits
    9 adds in trunk

[Qt][WK2] Rewrite MiniBrowser in QML
​https://bugs.webkit.org/show_bug.cgi?id=70315

Add the first QML based implementation of MiniBrowser.

Patch by Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>,

Zeno Albisser <​zeno.albisser@nokia.com>

Source/WebKit2:

Patch by Zeno Albisser <​zeno.albisser@nokia.com> on 2011-10-26
Reviewed by Tor Arne Vestbø.

  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebView::mousePressEvent):

2011-10-20 Zeno Albisser <​zeno.albisser@nokia.com>

[Qt][WK2] Disable Context Menus until we have a proper QML implementation
​https://bugs.webkit.org/show_bug.cgi?id=70537

This is just a temporary fix to avoid crashes in QtGui based
MiniBrowser that does not link to QtWidgets.

Patch by Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>,

Zeno Albisser <​zeno.albisser@nokia.com>

Reviewed by Simon Hausmann.

  • UIProcess/qt/WebContextMenuProxyQt.cpp:

(WebKit::WebContextMenuProxyQt::showContextMenu):
(WebKit::WebContextMenuProxyQt::createContextMenu):

Tools:

Patch by Zeno Albisser <​zeno.albisser@nokia.com> on 2011-10-25
Reviewed by Tor Arne Vestbø.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::webView):
(BrowserWindow::load):
(BrowserWindow::keyPressEvent):
(BrowserWindow::~BrowserWindow):

  • MiniBrowser/qt/BrowserWindow.h:
  • MiniBrowser/qt/MiniBrowser.pro:
  • MiniBrowser/qt/MiniBrowser.qrc:
  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::MiniBrowserApplication):
(MiniBrowserApplication::handleUserOptions):

  • MiniBrowser/qt/MiniBrowserApplication.h:

(WindowOptions::WindowOptions):

  • MiniBrowser/qt/UrlLoader.cpp:

(UrlLoader::UrlLoader):

  • MiniBrowser/qt/icons/next.png: Added.
  • MiniBrowser/qt/icons/previous.png: Added.
  • MiniBrowser/qt/icons/refresh.png: Added.
  • MiniBrowser/qt/icons/stop.png: Added.
  • MiniBrowser/qt/main.cpp:

(main):

  • MiniBrowser/qt/qml/BrowserWindow.qml: Added.
1:29 AM Changeset in webkit [98449] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit2

2011-10-20 Zeno Albisser <​zeno.albisser@nokia.com>

[Qt][WK2] Disable Context Menus until we have a proper QML implementation
​https://bugs.webkit.org/show_bug.cgi?id=70537

This is just a temporary fix to avoid crashes in QtGui based
MiniBrowser that does not link to QtWidgets.

Patch by Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>,

Zeno Albisser <​zeno.albisser@nokia.com>

Reviewed by Simon Hausmann.

  • UIProcess/qt/WebContextMenuProxyQt.cpp:

(WebKit::WebContextMenuProxyQt::showContextMenu):
(WebKit::WebContextMenuProxyQt::createContextMenu):

1:29 AM Changeset in webkit [98448] by Simon Hausmann
  • 8 edits
    2 deletes in trunk/Tools

[Qt][WK2] Remove QtWidgets dependency in MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=70529

Remove obsolete code for a new QML based implementation
of MiniBrowser.
Change BrowserWindow to derive from QSGView instead of
QMainWindow. QSGView is used as a top level window that
provides the container for placing QML content.
Make MiniBrowserApplication derive from QGuiApplication
instead of QApplication.

Patch by Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>,

Zeno Albisser <​zeno.albisser@nokia.com>

Patch by Zeno Albisser <​zeno.albisser@nokia.com> on 2011-10-25
Reviewed by Simon Hausmann.

  • MiniBrowser/qt/BrowserView.cpp: Removed.
  • MiniBrowser/qt/BrowserView.h: Removed.
  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::load):
(BrowserWindow::screenshot):
(BrowserWindow::loadURLListFromFile):
(BrowserWindow::updateUserAgentList):
(BrowserWindow::~BrowserWindow):

  • MiniBrowser/qt/BrowserWindow.h:
  • MiniBrowser/qt/MiniBrowser.pro:
  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::MiniBrowserApplication):
(MiniBrowserApplication::notify):

  • MiniBrowser/qt/MiniBrowserApplication.h:
  • MiniBrowser/qt/UrlLoader.cpp:

(UrlLoader::UrlLoader):

  • MiniBrowser/qt/main.cpp:
1:28 AM Changeset in webkit [98447] by Simon Hausmann
  • 19 edits
    1 delete in trunk

[Qt][WK2] Remove QAction from MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=70525

In order to rewrite MiniBrowser in QML we need a suitable
mechanism for triggering navigation actions.
Due to the QtWidgets dependency of QAction the current
solution is not suitable anymore. Therefore we introduce
invokable methods and export properties in QWebNavigationController.

Patch by Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>,

Zeno Albisser <​zeno.albisser@nokia.com>

Patch by Zeno Albisser <​zeno.albisser@nokia.com> on 2011-10-25
Reviewed by Simon Hausmann.

Source/WebKit2:

  • UIProcess/API/qt/WKView.h:
  • UIProcess/API/qt/qdesktopwebview.h:
  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/qwebkittypes.h: Removed.
  • UIProcess/API/qt/qwebnavigationcontroller.cpp:

(QWebNavigationController::QWebNavigationController):
(QWebNavigationController::canGoBack):
(QWebNavigationController::canGoForward):
(QWebNavigationController::canStop):
(QWebNavigationController::canReload):
(QWebNavigationController::goBack):
(QWebNavigationController::goForward):
(QWebNavigationController::stop):
(QWebNavigationController::reload):

  • UIProcess/API/qt/qwebnavigationcontroller.h:
  • UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp:

(tst_CommonViewTests::backAndForward):
(tst_CommonViewTests::reload):
(tst_CommonViewTests::stop):

  • UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:

(WebViewAbstraction::goBack):
(WebViewAbstraction::goForward):
(WebViewAbstraction::stop):
(WebViewAbstraction::reload):

  • UIProcess/API/qt/tests/commonviewtests/webviewabstraction.h:
  • UIProcess/API/qt/tests/qdesktopwebview/tst_qdesktopwebview.cpp:

(tst_QDesktopWebView::navigationStatusAtStartup):
(LoadStartedCatcher::onLoadStarted):
(tst_QDesktopWebView::stopEnabledAfterLoadStarted):

  • UIProcess/API/qt/tests/qtouchwebview/tst_qtouchwebview.cpp:

(tst_QTouchWebView::navigationStatusAtStartup):

  • UIProcess/qt/ClientImpl.cpp:

(dispatchLoadSucceeded):
(dispatchLoadFailed):
(qt_wk_didStartProvisionalLoadForFrame):
(qt_wk_didCommitLoadForFrame):
(qt_wk_didSameDocumentNavigationForFrame):

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::canGoBack):
(QtWebPageProxy::goBack):
(QtWebPageProxy::canGoForward):
(QtWebPageProxy::goForward):
(QtWebPageProxy::canStop):
(QtWebPageProxy::stop):
(QtWebPageProxy::canReload):
(QtWebPageProxy::reload):
(QtWebPageProxy::navigationStateChanged):
(QtWebPageProxy::didRelaunchProcess):
(QtWebPageProxy::processDidCrash):

  • UIProcess/qt/QtWebPageProxy.h:
  • WebKit2API.pri:

Tools:

  • MiniBrowser/qt/BrowserView.cpp:
  • MiniBrowser/qt/BrowserView.h:
  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):

1:27 AM Changeset in webkit [98446] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Private function _ewk_view_viewport_attributes_compute takes an internal data of ewk_view.
​https://bugs.webkit.org/show_bug.cgi?id=66366

Patch by Grzegorz Czajkowski <​g.czajkowski@samsung.com> on 2011-10-26
Reviewed by Ryosuke Niwa.

Passes to _ewk_view_viewport_attributes_compute an internal data of ewk_view instead of the view object.
Adds to ewk_view_viewport_attributes_get NULL checks to avoid unexpected results since this is API.

  • ewk/ewk_view.cpp:

(_ewk_view_viewport_attributes_compute):
(ewk_view_viewport_attributes_get):

1:24 AM Changeset in webkit [98445] by yurys@chromium.org
  • 15 edits in trunk/Source

Unreviewed, rolling out r98429.
​http://trac.webkit.org/changeset/98429
​https://bugs.webkit.org/show_bug.cgi?id=70881

"webkit_gpu_tests fail in Chromium" (Requested by yurys on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-26

Source/WebCore:

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::layerRendererContext):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::enabled):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::context):
(WebCore::CCLayerTreeHost::setNeedsAnimate):
(WebCore::CCLayerTreeHost::setNeedsCommitThenRedraw):
(WebCore::CCLayerTreeHost::setNeedsRedraw):
(WebCore::CCLayerTreeHost::composite):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::setThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

  • public/WebLayerTreeView.h:
  • src/WebCompositorImpl.cpp:

(WebKit::WebCompositor::setThread):

  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCSettings):
(WebKit::WebLayerTreeView::composite):

  • src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::createLayerTreeHostContext3D):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::runTest):

1:13 AM Changeset in webkit [98444] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Tools

[EFL] Unregister viewport,changed signal in EWebLauncher.
​https://bugs.webkit.org/show_bug.cgi?id=70478

Reviewed by Eric Seidel.

'viewport,changed' signal was registered by EWebLauncher in order to test viewport meta tag.
However, it sets wrong layout to some web sites which have viewport meta tag. Because, host pc
doesn't support proper DPI value though viewport is using DPI value to compute layout values.
This signal is for mobile device.

  • EWebLauncher/main.c:

(browserCreate):

1:07 AM Changeset in webkit [98443] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Cleanup Chromium test expectation. These tests were erroneously marked as timing out intermittently
even though the Chromium issue 66085 was fixed a long time ago.

Remove failing expectations from these tests except http/tests/xmlhttprequest/xmlhttprequest-test-send-flag.html
which is still timing out intermittently on Chromium Linux. Filed the bug 70878 to track the failure.

  • platform/chromium/test_expectations.txt:
12:57 AM Changeset in webkit [98442] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Remove temporary hack needed to ease Chromium/WebKit commit.
​https://bugs.webkit.org/show_bug.cgi?id=70791

Patch by Polina Sokolova <​polina@chromium.org> on 2011-10-26
Reviewed by Darin Fisher.

  • public/WebDocument.h:
12:57 AM Changeset in webkit [98441] by rniwa@webkit.org
  • 3 edits
    3 adds
    2 deletes in trunk/LayoutTests

Chromium editing test rebaselines and editing test expectations updates.

  • platform/chromium-linux/editing/selection/5354455-2-expected.png:
  • platform/chromium-mac-leopard/editing/inserting/12882-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/12882-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/5354455-2-expected.png: Added.
  • platform/chromium-mac/editing/inserting/12882-expected.png: Removed.
  • platform/chromium-mac/editing/selection/5354455-2-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
12:52 AM Changeset in webkit [98440] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Canvas drawImage with SourceIn, DestinationIn, SourceOut, DestinationAtop and Copy have errors
​https://bugs.webkit.org/show_bug.cgi?id=66920

Patch by Ben Wells <​benwells@chromium.org> on 2011-10-26
Reviewed by James Robinson.

Source/WebCore:

Test: fast/canvas/canvas-composite-image.html

Use the same method as fills to handle composited drawImage calls that will affect the whole
canvas. To do this code used when doing fills has been factored into seperate functions and
used by drawImage. Some functions used to do these types of operations have also been renamed.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::isFullCanvasCompositeMode):
(WebCore::CanvasRenderingContext2D::fill):
(WebCore::CanvasRenderingContext2D::fillRect):
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::calculateCompositingBufferRect):
(WebCore::CanvasRenderingContext2D::createCompositingBuffer):
(WebCore::CanvasRenderingContext2D::compositeBuffer):
(WebCore::CanvasRenderingContext2D::fullCanvasCompositedDrawImage):
(WebCore::CanvasRenderingContext2D::fullCanvasCompositedFill):

  • html/canvas/CanvasRenderingContext2D.h:

LayoutTests:

  • fast/canvas/canvas-composite-image-expected.txt: Added.
  • fast/canvas/canvas-composite-image.html: Added.
12:36 AM Changeset in webkit [98439] by rniwa@webkit.org
  • 1 edit
    3 adds
    3 deletes in trunk/LayoutTests

Chromium Mac rebaseline, trusting the baseline optimizer.

  • platform/chromium-cg-mac-snowleopard/editing/pasteboard/copy-standalone-image-expected.txt: Added.
  • platform/chromium-cg-mac/editing/pasteboard/copy-standalone-image-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/pasteboard/copy-standalone-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/copy-standalone-image-expected.txt: Added.
  • platform/chromium-mac/editing/pasteboard/copy-standalone-image-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/copy-standalone-image-expected.txt: Removed.
12:07 AM Changeset in webkit [98438] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit2

Another GTK build fix attempt after r98413 and r98416.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::paint):
(WebKit::PluginProxy::geometryDidChange):
(WebKit::PluginProxy::update):

Note: See TracTimeline for information about the timeline view.