Context Navigation

← Previous Period
Next Period →

Timeline

Nov 14, 2011:

11:10 PM Changeset in webkit [100245] by pkasting@chromium.org

1 edit
7 moves in trunk/LayoutTests

r100237 moved some pixel baselines into platform/chromium without also
moving the text baselines. As a result all the Chromium Mac "not 10.6
CG" bots were still failing due to MISSING expectations.

Unreviewed, gardening.

platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Removed.
platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-001-expected.txt: Removed.
platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-002-expected.txt: Removed.
platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Removed.
platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-margins-001-expected.txt: Removed.
platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-001-expected.txt: Removed.
platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-002-expected.txt: Removed.
platform/chromium/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Copied from platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-spacing-applies-to-015-expected.txt.
platform/chromium/css2.1/20110323/table-caption-001-expected.txt: Copied from platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-001-expected.txt.
platform/chromium/css2.1/20110323/table-caption-002-expected.txt: Copied from platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-002-expected.txt.
platform/chromium/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Copied from platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt.
platform/chromium/css2.1/20110323/table-caption-margins-001-expected.txt: Copied from platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-margins-001-expected.txt.
platform/chromium/css2.1/20110323/table-caption-optional-001-expected.txt: Copied from platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-001-expected.txt.
platform/chromium/css2.1/20110323/table-caption-optional-002-expected.txt: Copied from platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-002-expected.txt.

11:04 PM Changeset in webkit [100244] by fpizlo@apple.com

12 edits
4 deletes in trunk/Source/JavaScriptCore

DFG::SpeculativeJIT and DFG::JITCodeGenerator should be combined
https://bugs.webkit.org/show_bug.cgi?id=72348

Reviewed by Gavin Barraclough.

Moved all of JITCodeGenerator into SpeculativeJIT.

CMakeLists.txt:
GNUmakefile.list.am:
JavaScriptCore.xcodeproj/project.pbxproj:
Target.pri:
dfg/DFGJITCodeGenerator.cpp: Removed.
dfg/DFGJITCodeGenerator.h: Removed.
dfg/DFGJITCodeGenerator32_64.cpp: Removed.
dfg/DFGJITCodeGenerator64.cpp: Removed.
dfg/DFGJITCompiler.cpp:
dfg/DFGRepatch.cpp:

(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryCachePutByID):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::clearGenerationInfo):
(JSC::DFG::SpeculativeJIT::fillStorage):
(JSC::DFG::SpeculativeJIT::useChildren):
(JSC::DFG::SpeculativeJIT::isStrictInt32):
(JSC::DFG::SpeculativeJIT::isKnownInteger):
(JSC::DFG::SpeculativeJIT::isKnownNumeric):
(JSC::DFG::SpeculativeJIT::isKnownCell):
(JSC::DFG::SpeculativeJIT::isKnownNotCell):
(JSC::DFG::SpeculativeJIT::isKnownNotInteger):
(JSC::DFG::SpeculativeJIT::isKnownNotNumber):
(JSC::DFG::SpeculativeJIT::isKnownBoolean):
(JSC::DFG::SpeculativeJIT::writeBarrier):
(JSC::DFG::SpeculativeJIT::markCellCard):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativeStrictEq):
(JSC::DFG::dataFormatString):
(JSC::DFG::SpeculativeJIT::dump):
(JSC::DFG::SpeculativeJIT::checkConsistency):
(JSC::DFG::GPRTemporary::GPRTemporary):
(JSC::DFG::GPRTemporary::adopt):
(JSC::DFG::FPRTemporary::FPRTemporary):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::at):
(JSC::DFG::SpeculativeJIT::lock):
(JSC::DFG::SpeculativeJIT::unlock):
(JSC::DFG::SpeculativeJIT::canReuse):
(JSC::DFG::SpeculativeJIT::reuse):
(JSC::DFG::SpeculativeJIT::allocate):
(JSC::DFG::SpeculativeJIT::tryAllocate):
(JSC::DFG::SpeculativeJIT::fprAllocate):
(JSC::DFG::SpeculativeJIT::isFilled):
(JSC::DFG::SpeculativeJIT::isFilledDouble):
(JSC::DFG::SpeculativeJIT::use):
(JSC::DFG::SpeculativeJIT::selectScratchGPR):
(JSC::DFG::SpeculativeJIT::silentSpillGPR):
(JSC::DFG::SpeculativeJIT::silentSpillFPR):
(JSC::DFG::SpeculativeJIT::silentFillGPR):
(JSC::DFG::SpeculativeJIT::silentFillFPR):
(JSC::DFG::SpeculativeJIT::silentSpillAllRegisters):
(JSC::DFG::SpeculativeJIT::silentFillAllRegisters):
(JSC::DFG::SpeculativeJIT::boxDouble):
(JSC::DFG::SpeculativeJIT::unboxDouble):
(JSC::DFG::SpeculativeJIT::spill):
(JSC::DFG::SpeculativeJIT::isConstant):
(JSC::DFG::SpeculativeJIT::isJSConstant):
(JSC::DFG::SpeculativeJIT::isInt32Constant):
(JSC::DFG::SpeculativeJIT::isDoubleConstant):
(JSC::DFG::SpeculativeJIT::isNumberConstant):
(JSC::DFG::SpeculativeJIT::isBooleanConstant):
(JSC::DFG::SpeculativeJIT::isFunctionConstant):
(JSC::DFG::SpeculativeJIT::valueOfInt32Constant):
(JSC::DFG::SpeculativeJIT::valueOfNumberConstant):
(JSC::DFG::SpeculativeJIT::addressOfDoubleConstant):
(JSC::DFG::SpeculativeJIT::valueOfJSConstant):
(JSC::DFG::SpeculativeJIT::valueOfBooleanConstant):
(JSC::DFG::SpeculativeJIT::valueOfFunctionConstant):
(JSC::DFG::SpeculativeJIT::isNullConstant):
(JSC::DFG::SpeculativeJIT::identifier):
(JSC::DFG::SpeculativeJIT::flushRegisters):
(JSC::DFG::SpeculativeJIT::isFlushed):
(JSC::DFG::SpeculativeJIT::valueOfJSConstantAsImmPtr):
(JSC::DFG::SpeculativeJIT::bitOp):
(JSC::DFG::SpeculativeJIT::shiftOp):
(JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):
(JSC::DFG::SpeculativeJIT::addressOfCallData):
(JSC::DFG::SpeculativeJIT::tagOfCallData):
(JSC::DFG::SpeculativeJIT::payloadOfCallData):
(JSC::DFG::SpeculativeJIT::integerResult):
(JSC::DFG::SpeculativeJIT::noResult):
(JSC::DFG::SpeculativeJIT::cellResult):
(JSC::DFG::SpeculativeJIT::booleanResult):
(JSC::DFG::SpeculativeJIT::jsValueResult):
(JSC::DFG::SpeculativeJIT::storageResult):
(JSC::DFG::SpeculativeJIT::doubleResult):
(JSC::DFG::SpeculativeJIT::initConstantInfo):
(JSC::DFG::SpeculativeJIT::resetCallArguments):
(JSC::DFG::SpeculativeJIT::addCallArgument):
(JSC::DFG::SpeculativeJIT::setupArguments):
(JSC::DFG::SpeculativeJIT::setupArgumentsExecState):
(JSC::DFG::SpeculativeJIT::setupArgumentsWithExecState):
(JSC::DFG::SpeculativeJIT::setupTwoStubArgs):
(JSC::DFG::SpeculativeJIT::setupStubArguments):
(JSC::DFG::SpeculativeJIT::callOperation):
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheck):
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheckSetResult):
(JSC::DFG::SpeculativeJIT::setupResults):
(JSC::DFG::SpeculativeJIT::appendCallSetResult):
(JSC::DFG::SpeculativeJIT::addBranch):
(JSC::DFG::SpeculativeJIT::linkBranches):
(JSC::DFG::SpeculativeJIT::block):
(JSC::DFG::SpeculativeJIT::checkConsistency):
(JSC::DFG::SpeculativeJIT::BranchRecord::BranchRecord):
(JSC::DFG::IntegerOperand::IntegerOperand):
(JSC::DFG::IntegerOperand::~IntegerOperand):
(JSC::DFG::IntegerOperand::index):
(JSC::DFG::IntegerOperand::format):
(JSC::DFG::IntegerOperand::gpr):
(JSC::DFG::IntegerOperand::use):
(JSC::DFG::DoubleOperand::DoubleOperand):
(JSC::DFG::DoubleOperand::~DoubleOperand):
(JSC::DFG::DoubleOperand::index):
(JSC::DFG::DoubleOperand::fpr):
(JSC::DFG::DoubleOperand::use):
(JSC::DFG::JSValueOperand::JSValueOperand):
(JSC::DFG::JSValueOperand::~JSValueOperand):
(JSC::DFG::JSValueOperand::index):
(JSC::DFG::JSValueOperand::gpr):
(JSC::DFG::JSValueOperand::jsValueRegs):
(JSC::DFG::JSValueOperand::isDouble):
(JSC::DFG::JSValueOperand::fill):
(JSC::DFG::JSValueOperand::tagGPR):
(JSC::DFG::JSValueOperand::payloadGPR):
(JSC::DFG::JSValueOperand::fpr):
(JSC::DFG::JSValueOperand::use):
(JSC::DFG::StorageOperand::StorageOperand):
(JSC::DFG::StorageOperand::~StorageOperand):
(JSC::DFG::StorageOperand::index):
(JSC::DFG::StorageOperand::gpr):
(JSC::DFG::StorageOperand::use):
(JSC::DFG::GPRTemporary::~GPRTemporary):
(JSC::DFG::GPRTemporary::gpr):
(JSC::DFG::FPRTemporary::~FPRTemporary):
(JSC::DFG::FPRTemporary::fpr):
(JSC::DFG::FPRTemporary::FPRTemporary):
(JSC::DFG::GPRResult::GPRResult):
(JSC::DFG::GPRResult2::GPRResult2):
(JSC::DFG::FPRResult::FPRResult):
(JSC::DFG::FPRResult::lockedResult):
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::fillDouble):
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::nonSpeculativeUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeKnownConstantArithOp):
(JSC::DFG::SpeculativeJIT::nonSpeculativeBasicArithOp):
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::cachedGetMethod):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitCall):

dfg/DFGSpeculativeJIT64.cpp:

runtime/JSFunction.h:

11:01 PM Changeset in webkit [100243] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Fix the change log entry for r59190.

ChangeLog-2010-05-24:

10:58 PM Changeset in webkit [100242] by fpizlo@apple.com

5 edits in trunk/Source/JavaScriptCore

Weak reference harvesters should run to fixpoint
https://bugs.webkit.org/show_bug.cgi?id=72346

Reviewed by Oliver Hunt.

heap/Heap.cpp:

(JSC::Heap::markRoots):

heap/ListableHandler.h:

(JSC::ListableHandler::next):
(JSC::ListableHandler::List::head):
(JSC::ListableHandler::List::removeNext):
(JSC::ListableHandler::List::removeAll):

heap/MarkStack.cpp:

(JSC::MarkStackThreadSharedData::reset):
(JSC::SlotVisitor::harvestWeakReferences):

heap/MarkStack.h:

(JSC::MarkStack::isEmpty):

10:43 PM Changeset in webkit [100241] by dbates@webkit.org

3 edits in trunk/Tools

build-webkit: Accept --cmakearg to pass additional arguments to CMake.
https://bugs.webkit.org/show_bug.cgi?id=72156

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-14
Reviewed by Daniel Bates.

Similar to --makearg and --qmakearg, --cmakearg lets one pass
additional arguments to CMake (eg. --cmakearg="-DFOO=bar").

Scripts/build-webkit:
Scripts/webkitdirs.pm:

(generateBuildSystemFromCMakeProject):

10:29 PM Changeset in webkit [100240] by pkasting@chromium.org

2 edits
1 delete in trunk/LayoutTests

r100196 needed to also rebaseline Windows, not just Linux.

Unreviewed, gardening.

platform/chromium-linux/fast/repaint/scale-page-shrink-expected.txt: Removed.
platform/chromium-win/fast/repaint/scale-page-shrink-expected.png:

10:14 PM Changeset in webkit [100239] by dslomov@google.com

4 edits
2 adds in trunk

Source/WebCore: [V8][Chromium]Serialize dense arrays densly
https://bugs.webkit.org/show_bug.cgi?id=72198
This patch ensures that:

Dense arrays are serialized densly, and not as name-value pairs
Sparse arrays are allocated as sparse on deserialization.

The criteria to choose whether to serialize densly or sparsely is the size
of a resulting serialized stream.

Reviewed by David Levin.

Test: fast/dom/Window/window-postmessage-arrays.html

bindings/v8/SerializedScriptValue.cpp:

(WebCore::V8ObjectMap::Writer::writeDenseArray):
(WebCore::V8ObjectMap::Writer::writeGenerateFreshSparseArray):
(WebCore::V8ObjectMap::Writer::writeGenerateFreshDenseArray):
(WebCore::V8ObjectMap::Serializer::writeDenseArray):
(WebCore::V8ObjectMap::Serializer::AbstractObjectState::execDepth):
(WebCore::V8ObjectMap::Serializer::AbstractObjectState::serializeProperties):
(WebCore::V8ObjectMap::Serializer::ObjectState::advance):
(WebCore::V8ObjectMap::Serializer::DenseArrayState::DenseArrayState):
(WebCore::V8ObjectMap::Serializer::DenseArrayState::advance):
(WebCore::V8ObjectMap::Serializer::DenseArrayState::objectDone):
(WebCore::V8ObjectMap::Serializer::SparseArrayState::SparseArrayState):
(WebCore::V8ObjectMap::Serializer::SparseArrayState::advance):
(WebCore::V8ObjectMap::Serializer::serializeDensely):
(WebCore::V8ObjectMap::Serializer::startArrayState):
(WebCore::V8ObjectMap::Serializer::startObjectState):
(WebCore::V8ObjectMap::Serializer::doSerialize):
(WebCore::V8ObjectMap::Reader::read):
(WebCore::V8ObjectMap::Deserializer::newSparseArray):
(WebCore::V8ObjectMap::Deserializer::completeSparseArray):
(WebCore::V8ObjectMap::Deserializer::completeDenseArray):

LayoutTests: [V8][Chromium]Serialize dense arrays densly.
https://bugs.webkit.org/show_bug.cgi?id=72198

Reviewed by David Levin.

fast/dom/Window/script-tests/postmessage-clone.js:
fast/dom/Window/window-postmessage-arrays-expected.txt: Added.
fast/dom/Window/window-postmessage-arrays.html: Added.

10:07 PM Changeset in webkit [100238] by pkasting@chromium.org

1 edit
1 add
1 delete in trunk/LayoutTests

[chromium] More rebaselines for r100177 after r100193 did not fully
green the Chromium Mac bots.

Unreviewed, gardening.

platform/chromium-cg-mac-snowleopard/fast/table/prepend-in-anonymous-table-expected.txt: Removed.
platform/chromium/fast/table/prepend-in-anonymous-table-expected.txt: Added.

9:39 PM Changeset in webkit [100237] by pkasting@chromium.org

11 edits
24 adds
8 deletes in trunk/LayoutTests

[chromium] More rebaselines for r100177 after r100193 did not fully
green the Chromium Mac bots.

Unreviewed, gardening.

platform/chromium-cg-mac-leopard/css2.1/20110323/border-spacing-applies-to-015-expected.png: Added.
platform/chromium-cg-mac-leopard/css2.1/20110323/table-caption-001-expected.png: Added.
platform/chromium-cg-mac-leopard/css2.1/20110323/table-caption-002-expected.png: Added.
platform/chromium-cg-mac-leopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Added.
platform/chromium-cg-mac-leopard/css2.1/20110323/table-caption-margins-001-expected.png: Added.
platform/chromium-cg-mac-leopard/css2.1/20110323/table-caption-optional-001-expected.png: Added.
platform/chromium-cg-mac-leopard/css2.1/20110323/table-caption-optional-002-expected.png: Added.
platform/chromium-cg-mac-leopard/fast/table/dynamic-caption-add-before-child-expected.png:
platform/chromium-cg-mac-leopard/fast/table/multiple-captions-display-expected.png:
platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/other/test4-expected.png:
platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-001-expected.png: Removed.
platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Removed.
platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-margins-001-expected.png: Removed.
platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-001-expected.png: Removed.
platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-002-expected.png: Removed.
platform/chromium-cg-mac-snowleopard/fast/table/dynamic-caption-add-before-child-expected.txt: Removed.
platform/chromium-cg-mac-snowleopard/fast/table/multiple-captions-display-expected.txt: Removed.
platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.txt: Removed.
platform/chromium-mac-leopard/css2.1/20110323/border-spacing-applies-to-015-expected.png: Added.
platform/chromium-mac-leopard/css2.1/20110323/table-caption-001-expected.png: Added.
platform/chromium-mac-leopard/css2.1/20110323/table-caption-002-expected.png: Added.
platform/chromium-mac-leopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Added.
platform/chromium-mac-leopard/css2.1/20110323/table-caption-margins-001-expected.png: Added.
platform/chromium-mac-leopard/css2.1/20110323/table-caption-optional-001-expected.png: Added.
platform/chromium-mac-leopard/css2.1/20110323/table-caption-optional-002-expected.png: Added.
platform/chromium-mac-leopard/fast/table/dynamic-caption-add-before-child-expected.png:
platform/chromium-mac-leopard/fast/table/multiple-captions-display-expected.png:
platform/chromium-mac-leopard/tables/mozilla_expected_failures/other/test4-expected.png:
platform/chromium-mac-snowleopard/css2.1/20110323/border-spacing-applies-to-015-expected.png: Added.
platform/chromium-mac-snowleopard/css2.1/20110323/table-caption-002-expected.png: Added.
platform/chromium-mac-snowleopard/fast/table/dynamic-caption-add-before-child-expected.png:
platform/chromium-mac-snowleopard/fast/table/multiple-captions-display-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.png:
platform/chromium/css2.1/20110323/table-caption-001-expected.png: Added.
platform/chromium/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Added.
platform/chromium/css2.1/20110323/table-caption-margins-001-expected.png: Added.
platform/chromium/css2.1/20110323/table-caption-optional-001-expected.png: Added.
platform/chromium/css2.1/20110323/table-caption-optional-002-expected.png: Added.
platform/chromium/fast/table/dynamic-caption-add-before-child-expected.txt: Added.
platform/chromium/fast/table/multiple-captions-display-expected.txt: Added.
platform/chromium/tables/mozilla_expected_failures/other/test4-expected.txt: Added.
platform/chromium/test_expectations.txt:

8:27 PM Changeset in webkit [100236] by pkasting@chromium.org

1 edit
2 adds in trunk/LayoutTests

Rebaseline svg/foreignObject/multiple-foreign-objects.html on Snow
Leopard and earlier.

Unreviewed, gardening.

platform/mac-snowleopard/svg/foreignObject: Added.
platform/mac-snowleopard/svg/foreignObject/multiple-foreign-objects-expected.txt: Added.

8:08 PM Changeset in webkit [100235] by commit-queue@webkit.org

11 edits
10 deletes in trunk

[chromium] Fix scaleDelta zoom-out visibility rect bug
https://bugs.webkit.org/show_bug.cgi?id=72208

Since the scroll is no longer applied at the top layer of the layer
tree, the scaleDelta transformation needs to be moved down to the
same level.

Also fix zoomAnimator to be applied the same way. I removed zoom
animator layout tests, as they aren't testing the actual impl-side
codepath, and are hard to continue supporting -- we should cover zoom
features with unit tests in the future.

Patch by Alexandre Elias <aelias@google.com> on 2011-11-14
Reviewed by James Robinson.

No new tests (planning to add later: https://bugs.webkit.org/show_bug.cgi?id=71529)

platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::scaleDelta):

platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayersInternal):

platform/graphics/chromium/LayerRendererChromium.h:
platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::setScaleDelta):

platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::scaleDelta):

platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsAndVisibilityInternal):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::setScaleDelta):
(WebCore::CCLayerTreeHostImpl::setZoomAnimatorTransform):

7:14 PM Changeset in webkit [100234] by jchaffraix@webkit.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Fix the build after moving some arrays to WTF
https://bugs.webkit.org/show_bug.cgi?id=72345

Reviewed by Dirk Pranke.

public/WebArrayBufferView.h: s/WebCore/WTF/g.

7:08 PM Changeset in webkit [100233] by rniwa@webkit.org

3 edits in trunk/Tools

Improve ChangeLogEntry's reviewer parsing algorithm part 2
https://bugs.webkit.org/show_bug.cgi?id=72340

Reviewed by Eric Seidel.

This patch improves the recognition of NOBODY, wrestler names, and parenthesized clauses,
and prepares ChangeLogEntry to support edit-distance-based reviewer-name recognition.

Scripts/webkitpy/common/checkout/changelog.py:
Scripts/webkitpy/common/checkout/changelog_unittest.py:

6:46 PM Changeset in webkit [100232] by Chris Fleizach

2 edits in trunk/Source/WebCore

WebProcess crashes when trying to display your "uploaded videos" page on Facebook
https://bugs.webkit.org/show_bug.cgi?id=72334

Reviewed by Beth Dakin.

Protect against documents without frames.

accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper remoteAccessibilityParentObject]):

6:33 PM Changeset in webkit [100231] by eric@webkit.org

3 edits in trunk/Tools

check-webkit-style broken by r99773: "Could not determine the port"
https://bugs.webkit.org/show_bug.cgi?id=72275

Reviewed by Adam Barth.

The TestExpectationsChecker was using a generic try/except block
which caught all exceptions, so we didn't notice that failing
to pass a Host to PortFactory was causing an exception in port instantiation.
I've factored out the "lookup the port" logic into a separate function
which I've now unittested. This should fix the bug and prevent
others like it from occuring the the future.

Scripts/webkitpy/style/checkers/test_expectations.py:
Scripts/webkitpy/style/checkers/test_expectations_unittest.py:

6:18 PM Changeset in webkit [100230] by oliver@apple.com

2 edits in trunk/Source/WebCore

More V8 build fixes.

6:06 PM Changeset in webkit [100229] by oliver@apple.com

3 edits in trunk/Source/WebCore

Fix V8 build again.

5:58 PM Changeset in webkit [100228] by oliver@apple.com

3 edits in trunk/Source/WebCore

Fix V8 build

5:52 PM Changeset in webkit [100227] by oliver@apple.com

46 edits
4 copies
9 adds in trunk/Source

Start migrating typed array impl types to WTF
https://bugs.webkit.org/show_bug.cgi?id=72336

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Add typed array impls to WTF forwarding header.

wtf/Forward.h:

Source/WebCore:

Move typed arrays from WebCore namespace to WTF, and
start reducing dependencies on WebCore types.

bindings/js/JSArrayBufferViewHelper.h:

(WebCore::setWebGLArrayHelper):

bindings/scripts/CodeGeneratorJS.pm:

(IsTypedArrayType):
(AddClassForwardIfNeeded):
(GenerateImplementation):

bindings/scripts/CodeGeneratorV8.pm:

(IsTypedArrayType):

bindings/scripts/test/CPP/WebDOMFloat64Array.cpp: Added.

(WebDOMFloat64Array::WebDOMFloat64Array):
(WebDOMFloat64Array::impl):
(toWebCore):
(toWebKit):

bindings/scripts/test/CPP/WebDOMFloat64Array.h: Added.

(WebDOMFloat64Array::~WebDOMFloat64Array):

bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp: Added.

(WebKit::kit):
(WebKit::core):
(webkit_dom_float64array_finalize):
(webkit_dom_float64array_set_property):
(webkit_dom_float64array_get_property):
(webkit_dom_float64array_constructed):
(webkit_dom_float64array_class_init):
(webkit_dom_float64array_init):
(WebKit::wrapFloat64Array):

bindings/scripts/test/GObject/WebKitDOMFloat64Array.h: Added.
bindings/scripts/test/GObject/WebKitDOMFloat64ArrayPrivate.h: Added.
bindings/scripts/test/JS/JSFloat64Array.cpp: Added.

(WebCore::JSFloat64ArrayConstructor::JSFloat64ArrayConstructor):
(WebCore::JSFloat64ArrayConstructor::finishCreation):
(WebCore::JSFloat64ArrayConstructor::getOwnPropertySlot):
(WebCore::JSFloat64ArrayConstructor::getOwnPropertyDescriptor):
(WebCore::JSFloat64ArrayConstructor::getConstructData):
(WebCore::getJSFloat64ArrayPrototypeTable):
(WebCore::JSFloat64ArrayPrototype::self):
(WebCore::getJSFloat64ArrayTable):
(WebCore::JSFloat64Array::JSFloat64Array):
(WebCore::JSFloat64Array::finishCreation):
(WebCore::JSFloat64Array::createPrototype):
(WebCore::JSFloat64Array::getOwnPropertySlot):
(WebCore::JSFloat64Array::getOwnPropertyDescriptor):
(WebCore::JSFloat64Array::getOwnPropertySlotByIndex):
(WebCore::jsFloat64ArrayConstructor):
(WebCore::JSFloat64Array::put):
(WebCore::JSFloat64Array::putByIndex):
(WebCore::JSFloat64Array::getOwnPropertyNames):
(WebCore::JSFloat64Array::getConstructor):
(WebCore::JSFloat64Array::getByIndex):
(WebCore::toFloat64Array):
(WTF::Float64Array::neuterBinding):

bindings/scripts/test/JS/JSFloat64Array.h: Added.

(WebCore::JSFloat64Array::create):
(WebCore::JSFloat64Array::createStructure):
(WebCore::JSFloat64Array::impl):
(WebCore::JSFloat64ArrayPrototype::create):
(WebCore::JSFloat64ArrayPrototype::createStructure):
(WebCore::JSFloat64ArrayPrototype::JSFloat64ArrayPrototype):
(WebCore::JSFloat64ArrayConstructor::create):
(WebCore::JSFloat64ArrayConstructor::createStructure):

bindings/scripts/test/ObjC/DOMFloat64Array.h: Copied from Source/WebCore/html/canvas/Int16Array.cpp.
bindings/scripts/test/ObjC/DOMFloat64Array.mm: Copied from Source/WebCore/html/canvas/Float32Array.cpp.

(core):
(kit):

bindings/scripts/test/ObjC/DOMFloat64ArrayInternal.h: Copied from Source/WebCore/html/canvas/Int16Array.cpp.
bindings/scripts/test/TestTypedArray.idl: Copied from Source/WebCore/html/canvas/Float64Array.cpp.
bindings/scripts/test/V8/V8Float64Array.cpp: Added.

(WebCore::Float64ArrayInternal::V8_USE):
(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetRawTemplate):
(WebCore::V8Float64Array::GetTemplate):
(WebCore::V8Float64Array::HasInstance):
(WebCore::V8Float64Array::wrapSlow):
(WTF::Float64Array::neuterBinding):
(WebCore::V8Float64Array::derefObject):

bindings/scripts/test/V8/V8Float64Array.h: Added.

(WebCore::V8Float64Array::toNative):
(WebCore::V8Float64Array::existingWrapper):
(WebCore::V8Float64Array::wrap):
(WebCore::toV8):

fileapi/FileReader.h:
fileapi/FileReaderLoader.h:
fileapi/FileReaderSync.h:
fileapi/WebKitBlobBuilder.h:
html/HTMLMediaElement.h:
html/canvas/ArrayBuffer.cpp:
html/canvas/ArrayBuffer.h:
html/canvas/ArrayBufferView.cpp:

(WTF::ArrayBufferView::setImpl):
(WTF::ArrayBufferView::setRangeImpl):
(WTF::ArrayBufferView::zeroRangeImpl):
(WTF::ArrayBufferView::neuter):

html/canvas/ArrayBufferView.h:
html/canvas/Float32Array.cpp:
html/canvas/Float32Array.h:

(WTF::Float32Array::set):

html/canvas/Float64Array.cpp:
html/canvas/Float64Array.h:

(WTF::Float64Array::set):

html/canvas/Int16Array.cpp:
html/canvas/Int16Array.h:

(WTF::Int16Array::set):

html/canvas/Int32Array.cpp:
html/canvas/Int32Array.h:

(WTF::Int32Array::set):

html/canvas/Int8Array.cpp:
html/canvas/Int8Array.h:

(WTF::Int8Array::set):

html/canvas/IntegralTypedArrayBase.h:
html/canvas/TypedArrayBase.h:

(WTF::TypedArrayBase::set):
(WTF::TypedArrayBase::setRange):
(WTF::TypedArrayBase::zeroRange):

html/canvas/Uint16Array.cpp:
html/canvas/Uint16Array.h:

(WTF::Uint16Array::set):

html/canvas/Uint32Array.cpp:
html/canvas/Uint32Array.h:

(WTF::Uint32Array::set):

html/canvas/Uint8Array.cpp:
html/canvas/Uint8Array.h:

(WTF::Uint8Array::set):

html/canvas/WebGLBuffer.h:
page/Crypto.h:
webaudio/AsyncAudioDecoder.h:
webaudio/AudioBuffer.cpp:

(WebCore::AudioBuffer::AudioBuffer):
(WebCore::AudioBuffer::zero):

webaudio/AudioContext.h:
webaudio/JavaScriptAudioNode.h:
webaudio/RealtimeAnalyser.h:
webaudio/RealtimeAnalyserNode.h:
webaudio/WaveShaperNode.h:
websockets/ThreadableWebSocketChannel.h:
websockets/WebSocket.h:
websockets/WebSocketChannel.h:
xml/XMLHttpRequest.h:

5:48 PM Changeset in webkit [100226] by jchaffraix@webkit.org

13 edits in trunk

Add --css-grid-layout to build-webkit and the build systems
https://bugs.webkit.org/show_bug.cgi?id=72320

Reviewed by Ojan Vafai.

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

Tools:

Scripts/build-webkit:

Added the option.

WebKitLibraries:

win/tools/vsprops/FeatureDefines.vsprops:
win/tools/vsprops/FeatureDefinesCairo.vsprops:

5:43 PM Changeset in webkit [100225] by commit-queue@webkit.org

17 edits in trunk/Source/WebCore

Remove unnecessary #include SVGResourcesCache.h in SVGDocumentExtensions.h; use forward declaration
https://bugs.webkit.org/show_bug.cgi?id=72335

Patch by Daniel Bates <dbates@rim.com> on 2011-11-14
Reviewed by Eric Seidel.

It's sufficient to forward declare SVGResourcesCache in SVGDocumentExtensions.h and #include SVGResourcesCache.h
in SVGDocumentExtensions.cpp. This will reduce the number of files we need to re-compile after the file
SVGResourcesCache.h has been modified. Currently we #include SVGResourcesCache.h in SVGDocumentExtensions.h.

rendering/svg/RenderSVGBlock.cpp: Include SVGResourcesCache.h.
rendering/svg/RenderSVGContainer.cpp: Ditto.
rendering/svg/RenderSVGForeignObject.cpp: Ditto.
rendering/svg/RenderSVGImage.cpp: Ditto.
rendering/svg/RenderSVGInline.cpp: Ditto.
rendering/svg/RenderSVGModelObject.cpp: Ditto.
rendering/svg/RenderSVGPath.cpp: Ditto.
rendering/svg/RenderSVGResource.cpp: Ditto.
rendering/svg/RenderSVGResourceClipper.cpp: Ditto.
rendering/svg/RenderSVGResourceContainer.cpp: Ditto.
rendering/svg/RenderSVGRoot.cpp: Ditto.
rendering/svg/RenderSVGText.cpp: Ditto.
rendering/svg/SVGInlineTextBox.cpp: Ditto.
rendering/svg/SVGRenderSupport.cpp: Ditto.
svg/SVGDocumentExtensions.cpp: Ditto.
svg/SVGDocumentExtensions.h: Forward declare SVGResourcesCache.

5:39 PM Changeset in webkit [100224] by ggaren@apple.com

5 edits in trunk/Source/JavaScriptCore

A little bit of arguments / activation cleanup
https://bugs.webkit.org/show_bug.cgi?id=72339

Reviewed by Gavin Barraclough.

Renamed copyRegisters => tearOff to match bytecode and other terminology.

Renamed setActivation => didTearOffActivation to indicate that this is a
notification the object may choose to ignore. Moved "Should I ignore?"
code into the arguments object to avoid duplication elsewhere.

interpreter/Interpreter.cpp:

(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::privateExecute):
(JSC::Interpreter::retrieveArguments):

jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

runtime/Arguments.h:

(JSC::Arguments::createAndTearOff):
(JSC::Arguments::didTearOffActivation):
(JSC::Arguments::finishCreationButDontTearOff):
(JSC::Arguments::finishCreation):
(JSC::Arguments::finishCreationAndTearOff):
(JSC::Arguments::tearOff):

runtime/JSActivation.h:

(JSC::JSActivation::tearOff): Moved Activation's code into its own header
because that's where it belongs.

5:32 PM Changeset in webkit [100223] by barraclough@apple.com

2 edits
1 add in trunk/Source/JavaScriptCore

Should sign the jsc binary
https://bugs.webkit.org/show_bug.cgi?id=72332

Reviewed by David Kilzer.

Configurations/JSC.xcconfig:
entitlements.plist: Added.

5:23 PM Changeset in webkit [100222] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[MutationObservers] Add histogram collection for usage of DOM Mutation Events
https://bugs.webkit.org/show_bug.cgi?id=72316

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-11-14
Reviewed by Ryosuke Niwa.

This patch adds six calls in ~Document() which simply pipe-out to the embedder
the (already-collected) bits of whether varous DOM Mutation Events were registered
on the document.

No tests needed. No functional changes.

dom/Document.cpp:

(WebCore::histogramMutationEventUsage):
(WebCore::Document::~Document):

5:22 PM Changeset in webkit [100221] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

DFG's inline references to objects should be tracked
https://bugs.webkit.org/show_bug.cgi?id=72313

Reviewed by Gavin Barraclough.

Added a pinCell() method in the parser that currently creates a
dummy constant in CodeBlock. Added calls to pinCell() wherever the
DFG would inline a constant reference that the original code would
not have referred to.

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getCellConstantIndex):
(JSC::DFG::ByteCodeParser::pinCell):
(JSC::DFG::ByteCodeParser::cellConstant):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):

5:13 PM Changeset in webkit [100220] by noel.gordon@gmail.com

1 edit
5 adds in trunk/LayoutTests

Test JPEG image decoding RGB pixel endianess
https://bugs.webkit.org/show_bug.cgi?id=72234

Reviewed by Kent Tamura.

JPEG image RGB pixels should render without color corruption and in strict
order, regardless of the underlying machine pixel buffer endianess.

fast/images/resources/rgb-jpeg-blue.jpg: Added.
fast/images/resources/rgb-jpeg-green.jpg: Added.
fast/images/resources/rgb-jpeg-red.jpg: Added.
fast/images/rgb-jpeg-endian-pixels-expected.txt: Added.
fast/images/rgb-jpeg-endian-pixels.html: Added.

5:04 PM Changeset in webkit [100219] by fpizlo@apple.com

3 edits in trunk/Source/JavaScriptCore

DFG put_by_id transition optimizations test the wrong structures
https://bugs.webkit.org/show_bug.cgi?id=72324

Reviewed by Gavin Barraclough.

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::structureChainIsStillValid):
(JSC::DFG::ByteCodeParser::parseBlock):

jit/JITPropertyAccess.cpp:

(JSC::JIT::privateCompilePutByIdTransition):

4:57 PM Changeset in webkit [100218] by gavinp@chromium.org

1 edit in branches/chromium/912/Source/WebCore/loader/cache/CachedResourceRequest.cpp

MERGE 71122 and 72068 simultaniously.

71122:

properly end requests when a bad status code return happens

https://bugs.webkit.org/show_bug.cgi?id=71122

Calling error without ending the request set up the CachedResourceRequest so that it could
actually send out two notifyFinished() events. This probably was the root cause of
lots of crashing instability; I know from crbug.com/75604 that this bug was causing lots
of crashes in ScriptRunner/ScriptElement for instance.

The fix is easy: just properly end the request instead of just calling error, and we won't
re-notify.

Reviewed by Nate Chapin.

No new tests, as the problem wasn't very amenable to layout tests.

There is a chromium test going through code review at http://codereview.chromium.org/8404001/

loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::didReceiveData):

72068:

Protect Document during error responses

https://bugs.webkit.org/show_bug.cgi?id=72068

Add a Document protector to the error response code handler, just
as exists for other ends of requests.

Reviewed by Nate Chapin.

Source/WebCore:

Test: http/tests/misc/xslt-bad-import.html

loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::didReceiveData):

4:51 PM Changeset in webkit [100217] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/chromium

Expose compositeAndReadback in WebLayerTreeView
https://bugs.webkit.org/show_bug.cgi?id=72188

Patch by Ian Vollick <vollick@chromium.org> on 2011-11-14
Reviewed by Darin Fisher.

public/WebLayerTreeView.h:
src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::compositeAndReadback):

4:47 PM Changeset in webkit [100216] by commit-queue@webkit.org

3 edits in trunk/Tools

Unreviewed, rolling out r100192.
http://trac.webkit.org/changeset/100192
https://bugs.webkit.org/show_bug.cgi?id=72328

Caused infinite tests to fail (Requested by abarth on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-14

Scripts/webkitpy/layout_tests/port/base.py:
Scripts/webkitpy/layout_tests/port/base_unittest.py:

4:39 PM Changeset in webkit [100215] by eae@chromium.org

4 edits in branches/subpixellayout/Source/WebCore/rendering

Remove FixedRect stream operator and move FloatRect version back to svg/

4:34 PM Changeset in webkit [100214] by Simon Fraser

2 edits in trunk/Source/WebCore

div with webkit-transform + webkit-box-reflect disappears when switching tabs
https://bugs.webkit.org/show_bug.cgi?id=53355

Reviewed by Dean Jackson.

Tickle Core Animation into updating the layer's content property when
switching back to a tab which has composited reflections. This hack is
needed becuase reflections involve sharing layer contents between layers.

platform/graphics/mac/WebLayer.mm:

(-[WebLayer actionForKey:]):

4:24 PM Changeset in webkit [100213] by abarth@webkit.org

19 edits in trunk

Unique origins shouldn't remember their scheme, host, or port
https://bugs.webkit.org/show_bug.cgi?id=72308

Reviewed by Eric Seidel.

Source/WebCore:

This patch contains the bulk (all?) of the behavior differences in this
patch series. Unique origins shouldn't remember their schemes. Doing
so causes some privileges (e.g., local access) to leak into unique
origins.

page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::SecurityOrigin):

Explicitly clear out the protocol, host, and port for unique origins. A future patch will refactor all this code to be more elegant.

platform/SchemeRegistry.cpp:

(WebCore::schemesWithUniqueOrigins):

Merge "about" and "javascript" in with the general case now that we don't have a separate notion of an empty origin.

LayoutTests:

fast/filesystem/async-operations-expected.txt:
fast/filesystem/not-enough-arguments-expected.txt:
fast/filesystem/read-directory-expected.txt:
fast/filesystem/simple-persistent-expected.txt:
fast/filesystem/simple-readonly-expected.txt:
fast/filesystem/simple-temporary-expected.txt:
- Update test results to show that we no longer leak the scheme in storage identifiers.
fast/frames/resources/sandboxed-iframe-storage-disallowed.html:
- Inline script because the sandbox iframe isn't allowed to load local resources.
fast/frames/sandboxed-iframe-attribute-parsing.html:
fast/frames/sandboxed-iframe-forms-dynamic.html:
fast/frames/sandboxed-iframe-forms.html:
fast/frames/sandboxed-iframe-navigation-top-by-constant-name.html:
fast/frames/sandboxed-iframe-navigation-top-by-constant-name2.html:
fast/frames/sandboxed-iframe-navigation-top-by-name.html:
fast/frames/sandboxed-iframe-navigation-top.html:
media/video-controls-no-scripting.html:
- Previously sandboxed local iframes still got universal access when we're running with universal access for file URLs! Now that they correctly get unique origins, we need to update these tests to allow-same-origin access in order for them to function properly.

4:21 PM Changeset in webkit [100212] by mrowe@apple.com

3 edits
5 adds in trunk/Websites/webkit.org

Upgrade WordPress's Akismet plug-in to the latest version.

blog/wp-content/plugins/akismet:

4:20 PM Changeset in webkit [100211] by jchaffraix@webkit.org

1 edit
3 adds in trunk/LayoutTests

Test getting / setting display: -webkit-flexbox and -webkit-flexbox-inline
https://bugs.webkit.org/show_bug.cgi?id=72318

Reviewed by Tony Chang.

Test that covers the change for bug 72296 and also increase our flexbox coverage.

css3/flexbox/display-flexbox-set-get-expected.txt: Added.
css3/flexbox/display-flexbox-set-get.html: Added.
css3/flexbox/resources/display-flexbox-set-get.js: Added.

4:18 PM Changeset in webkit [100210] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/chromium

Add buffering to handle mismatch between hardware buffer size and webaudio render size
https://bugs.webkit.org/show_bug.cgi?id=71949

Patch by Raymond Toy <Raymond Toy> on 2011-11-14
Reviewed by Kenneth Russell.

src/AudioDestinationChromium.cpp:

(WebCore::AudioDestinationChromium::AudioDestinationChromium):
Create the FIFO for buffering.
(WebCore::AudioDestinationChromium::render): Get rid of
m_renderCountPerCallback and let the FIFO consume function produce
the appropriate nubmer of calls to the webaudio producer. Also
remove the rounding of the callback size so we use whatever the
hardware returns. Removed maximumCallbackBufferSize and use
fifoSize to set the FIFO size.
(WebCore::AudioDestinationChromium::FIFO::FIFO):
(WebCore::AudioDestinationChromium::FIFO::consume):
(WebCore::AudioDestinationChromium::FIFO::findWrapLengths):
(WebCore::AudioDestinationChromium::FIFO::fillBuffer):
Implementation of new FIFO class.

src/AudioDestinationChromium.h:

(WebCore::AudioDestinationChromium::FIFO::updateIndex):
Define new FIFO class.

4:16 PM Changeset in webkit [100209] by mrowe@apple.com

2 edits in trunk/Websites/webkit.org

Update one file that was missed.

blog/wp-settings.php:

4:16 PM Changeset in webkit [100208] by msaboff@apple.com

3 edits in trunk/Source/JavaScriptCore

Further changes and cleanup to JSString.h and cpp.

Reviewed by Darin Adler.

runtime/JSString.cpp:

(JSC::JSString::resolveRope): Change PassRefPtr to RefPtr. Eliminated exec in slow case calls.
(JSC::JSString::resolveRopeSlowCase8): Darin and I agreed that this should have 8 in name.
(JSC::JSString::resolveRopeSlowCase): Removed exec parameter.

runtime/JSString.h:

4:12 PM Changeset in webkit [100207] by mrowe@apple.com

397 edits
21 copies
7 moves
230 adds
106 deletes in trunk/Websites/webkit.org

Upgrade WordPress to v3.2.1.

blog:

4:05 PM Changeset in webkit [100206] by leviw@chromium.org

1 edit in branches/subpixellayout/Source/WebCore/rendering/AutoTableLayout.cpp

Correcting usage of intMaxForLength in AutoTableLayout.

4:04 PM Changeset in webkit [100205] by abarth@webkit.org

15 edits
1 copy
1 add in trunk/Source/JavaScriptCore

DateMath.cpp should not depend on JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=71747

Reviewed by Darin Adler.

This patch moves the JSC-specific parts of DateMath into JSDateMath in
JavaScriptCore. There shouldn't be any behavior change.

CMakeLists.txt:
GNUmakefile.list.am:
JavaScriptCore.gypi:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
Target.pri:
runtime/DateConstructor.cpp:
runtime/DateConversion.cpp:
runtime/DateInstance.cpp:
runtime/DateInstanceCache.h:
runtime/DatePrototype.cpp:
runtime/InitializeThreading.cpp:
runtime/JSDateMath.cpp: Copied from Source/JavaScriptCore/wtf/DateMath.cpp.

(JSC::timeToMS):
(JSC::msToSeconds):

runtime/JSDateMath.h: Copied from Source/JavaScriptCore/wtf/DateMath.h.
wtf/DateMath.cpp:

(WTF::isLeapYear):
(WTF::msToDays):
(WTF::msToMinutes):
(WTF::msToHours):
(WTF::parseDateFromNullTerminatedCharacters):
(WTF::makeRFC2822DateString):

wtf/DateMath.h:

4:01 PM Changeset in webkit [100204] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/efl

[EFL] Update ewk_frame_script_execute to return the result for JavaScript
https://bugs.webkit.org/show_bug.cgi?id=65972

Patch by Jongseok Yang <js45.yang@samsung.com> on 2011-11-14
Reviewed by Antonio Gomes.

It executes the javascript and converts the result to a string using toString.
And it returns the memory-allocated pointer for the value.

ewk/ewk_frame.cpp:

(ewk_frame_script_execute):

ewk/ewk_frame.h:

4:00 PM Changeset in webkit [100203] by abarth@webkit.org

4 edits
3 adds in trunk

Source/WebCore: Don't special-case "data" URLs in drag-and-drop logic
https://bugs.webkit.org/show_bug.cgi?id=72322

Reviewed by Eric Seidel.

See the bug for more details.

Test: editing/pasteboard/drag-drop-to-data-url.html

page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::canReceiveDragData):

LayoutTests: Cross-origin drag-and-drop prevention ineffective
https://bugs.webkit.org/show_bug.cgi?id=72322

Reviewed by Eric Seidel.

Split drag-drop-dead-frame.html into two tests: one that tests for the
previous crash and one that tests out data URL drag-and-drop behavior.

editing/pasteboard/drag-drop-dead-frame.html:
editing/pasteboard/drag-drop-to-data-url-expected.txt: Added.
editing/pasteboard/drag-drop-to-data-url.html: Added.

3:51 PM Changeset in webkit [100202] by msaboff@apple.com

3 edits in trunk/Source/JavaScriptCore

Towards 8 bit strings - Add 8 bit handling to JSString Ropes
https://bugs.webkit.org/show_bug.cgi?id=72317

Added bit to track that a rope is made up of all 8 bit fibers.
Created an 8 bit path (fast and slow cases) to handle 8 bit
only ropes.

Reviewed by Oliver Hunt.

runtime/JSString.cpp:

(JSC::JSString::resolveRope):
(JSC::JSString::resolveRopeSlowCase8):
(JSC::JSString::resolveRopeSlowCase16):

runtime/JSString.h:

(JSC::RopeBuilder::finishCreation):
(JSC::RopeBuilder::is8Bit):
(JSC::jsSubstring8):

3:33 PM Changeset in webkit [100201] by eae@chromium.org

4 edits in branches/subpixellayout/Source/WebCore

Round width and height when computing the scroll size (as opposed to flooring).

3:16 PM Changeset in webkit [100200] by ggaren@apple.com

4 edits in trunk/Source/JavaScriptCore

A little bit of function call cleanup
https://bugs.webkit.org/show_bug.cgi?id=72314

Reviewed by Oliver Hunt.

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCall): Renamed callFrame to registerOffset
because this value doesn't give you the offset of the callee's call frame.

(JSC::BytecodeGenerator::emitReturn): Tightened to use equality instead
of greater-than. Removed comment since its reasoning was wrong.

(JSC::BytecodeGenerator::emitConstruct): Updated for rename mentioned above.

(JSC::BytecodeGenerator::isArgumentNumber): Provided a more precise way
to ask this question, giving the bytecode generator more freedom to change
internal implementation details.

bytecompiler/BytecodeGenerator.h: Reduced default vector capacity because

16 was overkill.
(JSC::CallArguments::registerOffset): Updated for rename mentioned above.

bytecompiler/NodesCodegen.cpp:

(JSC::CallArguments::CallArguments):
(JSC::CallArguments::newArgument): Factored out argument allocation into
a helper function, so I can change it later.

(JSC::CallFunctionCallDotNode::emitBytecode):
(JSC::FunctionBodyNode::emitBytecode): Use helper function mentioned above.

3:10 PM Changeset in webkit [100199] by enne@google.com

12 edits in trunk/Source

[chromium] Pipe compositor commit/swap up to WebWidgetClient
https://bugs.webkit.org/show_bug.cgi?id=72041

Reviewed by Darin Fisher.

Source/WebCore:

platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeHost::didCommitAndDrawFrame):
(WebCore::CCLayerTreeHost::didCompleteSwapBuffers):

platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::doComposite):

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::onSwapBuffersCompleteOnImplThread):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwap):
(WebCore::CCThreadProxy::didCommitAndDrawFrame):
(WebCore::CCThreadProxy::didCompleteSwapBuffers):

platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

public/WebWidgetClient.h:

(WebKit::WebWidgetClient::didCommitAndDrawCompositorFrame):
(WebKit::WebWidgetClient::didCompleteSwapBuffers):

src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::didCommitAndDrawFrame):
(WebKit::WebLayerTreeViewImpl::didCompleteSwapBuffers):

src/WebLayerTreeViewImpl.h:
src/WebViewImpl.cpp:

(WebKit::WebViewImpl::didCommitAndDrawFrame):
(WebKit::WebViewImpl::didCompleteSwapBuffers):

src/WebViewImpl.h:
tests/CCLayerTreeHostTest.cpp:

(WTF::MockLayerTreeHostClient::didCommitAndDrawFrame):
(WTF::MockLayerTreeHostClient::didCompleteSwapBuffers):

2:51 PM Changeset in webkit [100198] by tony@chromium.org

45 edits in trunk

Remove the CSS3_FLEXBOX compile time flag and enable on all ports
https://bugs.webkit.org/show_bug.cgi?id=72196

Reviewed by Ojan Vafai.

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Configurations/FeatureDefines.xcconfig:
css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

css/CSSFlexValue.cpp:
css/CSSFlexValue.h:
css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFlex):

css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

css/CSSPropertyNames.in:
css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyLength::applyValue):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

css/CSSValue.cpp:

(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):

css/CSSValue.h:
css/CSSValueKeywords.in:
rendering/RenderFlexibleBox.cpp:
rendering/RenderFlexibleBox.h:
rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):

rendering/RenderObject.h:

(WebCore::RenderObject::isFlexibleBoxIncludingDeprecated):

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::diff):

rendering/style/RenderStyle.h:
rendering/style/RenderStyleConstants.h:
rendering/style/StyleFlexibleBoxData.cpp:
rendering/style/StyleFlexibleBoxData.h:
rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

rendering/style/StyleRareNonInheritedData.h:

Source/WebKit/chromium:

features.gypi:

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

Tools:

Scripts/build-webkit:

WebKitLibraries:

win/tools/vsprops/FeatureDefines.vsprops:
win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

fast/css/getComputedStyle/computed-style-expected.txt:
fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
svg/css/getComputedStyle-basic-expected.txt:

2:47 PM Changeset in webkit [100197] by mrowe@apple.com

3 edits
2 copies in trunk/Source/JavaScriptCore

<rdar://problem/10424154> testRegExp should not be installed as part of JavaScriptCore

testRegExp and testapi.js were being installed in the JavaScriptCore framework.
As test-only tools they shouldn't be installed there by default, only when
FORCE_TOOL_INSTALL is set to YES.

This patch incorprorates a few related changes:
1) Make the jsc and testRegExp targets be configured via .xcconfig files.
2) Sets up testRegExp so that SKIP_INSTALL is YES by default, and only NO when

FORCE_TOOL_INSTALL is YES.

3) Switches the testapi target to using a script build phase to install testapi.js

so that the installation will be skipped when SKIP_INSTALL is YES. I'm not sure
why this isn't the built-in behavior when a Copy Files build phase has "Copy only
when installing" checked, but it doesn't seem to be.

4) Other random cleanup such as removing a bogus group that refers to files that do

not exist, moving testRegExp.cpp in to the tests group, etc.

Reviewed by Geoff Garen.

Configurations/JSC.xcconfig: Added.
Configurations/TestRegExp.xcconfig: Added.
JavaScriptCore.xcodeproj/project.pbxproj:

2:47 PM Changeset in webkit [100196] by fsamuel@chromium.org

6 edits
1 copy
2 adds in trunk

[Chromium] setPageScaleFactor and associated methods should take scaling limits into account
https://bugs.webkit.org/show_bug.cgi?id=72176

Source/WebKit/chromium:

Reviewed by Darin Fisher.

A couple of changes:

setPageScaleFactorLimits now affects the behavior of other scaling methods including setPageScaleFactor.
setPageScaleFactorPreservingScrollOffset introduced that scales the scroll offset along with the page, preserving the scroll position within the page bounds.

public/WebView.h:
src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::computePageScaleFactorWithinLimits):
(WebKit::WebViewImpl::clampOffsetAtScale):
(WebKit::WebViewImpl::setPageScaleFactorPreservingScrollOffset):
(WebKit::WebViewImpl::setPageScaleFactor):
(WebKit::WebViewImpl::setPageScaleFactorLimits):
(WebKit::WebViewImpl::applyScrollAndScale):

src/WebViewImpl.h:

LayoutTests:

Reviewed by Darin Fisher.

Rebaselined some tests that broke because we now clamp pageScaleFactor to 0.25 (these test at 0.2).

Since this is a Chromium only change, the new baselines are only for Chromium.

platform/chromium-linux/fast/repaint/scale-page-shrink-expected.png:
platform/chromium-linux/fast/repaint/scale-page-shrink-expected.txt: Added.
platform/chromium/fast/repaint/background-scaling-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/repaint/scale-page-shrink-expected.png.
platform/chromium/fast/repaint/background-scaling-expected.txt: Added.

2:42 PM Changeset in webkit [100195] by msaboff@apple.com

4 edits in trunk/Source/JavaScriptCore

Towards 8 bit strings - Add 8 bit paths to StringImpl methods
https://bugs.webkit.org/show_bug.cgi?id=72290

Added 8 bit patchs to StringImpl to number and find methods.

Reviewed by Oliver Hunt.

wtf/text/StringImpl.cpp:

(WTF::StringImpl::toIntStrict):
(WTF::StringImpl::toUIntStrict):
(WTF::StringImpl::toInt64Strict):
(WTF::StringImpl::toUInt64Strict):
(WTF::StringImpl::toIntPtrStrict):
(WTF::StringImpl::toInt):
(WTF::StringImpl::toUInt):
(WTF::StringImpl::toInt64):
(WTF::StringImpl::toUInt64):
(WTF::StringImpl::toIntPtr):
(WTF::StringImpl::toDouble):
(WTF::StringImpl::toFloat):
(WTF::StringImpl::find):
(WTF::StringImpl::reverseFind):

wtf/text/WTFString.cpp:

(WTF::toIntegralType):
(WTF::lengthOfCharactersAsInteger):
(WTF::charactersToIntStrict):
(WTF::charactersToUIntStrict):
(WTF::charactersToInt64Strict):
(WTF::charactersToUInt64Strict):
(WTF::charactersToIntPtrStrict):
(WTF::charactersToInt):
(WTF::charactersToUInt):
(WTF::charactersToInt64):
(WTF::charactersToUInt64):
(WTF::charactersToIntPtr):
(WTF::toDoubleType):
(WTF::charactersToDouble):
(WTF::charactersToFloat):

wtf/text/WTFString.h:

(WTF::find):
(WTF::reverseFind):

2:39 PM Changeset in webkit [100194] by scheib@chromium.org

11 edits in trunk/Source

Mouse Lock: Renaming to 'Pointer Lock': Runtime Enable Flags
https://bugs.webkit.org/show_bug.cgi?id=72303

Reviewed by Darin Fisher.

Source/WebCore:

bindings/generic/RuntimeEnabledFeatures.cpp:
bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitPointerLockEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitPointerLockEnabled):
(WebCore::RuntimeEnabledFeatures::webkitPointerEnabled):

page/Settings.cpp:

(WebCore::Settings::Settings):

page/Settings.h:

(WebCore::Settings::setPointerLockEnabled):
(WebCore::Settings::PointerLockEnabled):

Source/WebKit/chromium:

public/WebRuntimeFeatures.h:
public/WebSettings.h:
src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enablePointerLock):
(WebKit::WebRuntimeFeatures::isPointerLockEnabled):

src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setPointerLockEnabled):

src/WebSettingsImpl.h:

2:32 PM Changeset in webkit [100193] by robert@webkit.org

12 edits
13 copies
11 moves
31 adds
1 delete in trunk/LayoutTests

Platform-specific results for r100177

Unreviewed gardening.

platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-spacing-applies-to-015-expected.png: Added.
platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Added.
platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-001-expected.png: Added.
platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-001-expected.txt.
platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-002-expected.png: Added.
platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-002-expected.txt: Added.
platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Added.
platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Added.
platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-margins-001-expected.png: Added.
platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-margins-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-margins-001-expected.txt.
platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-001-expected.png: Added.
platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-001-expected.txt.
platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-002-expected.png: Added.
platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-002-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-002-expected.txt.
platform/chromium-cg-mac-snowleopard/fast/table/dynamic-caption-add-before-child-expected.png: Added.
platform/chromium-cg-mac-snowleopard/fast/table/dynamic-caption-add-before-child-expected.txt: Added.
platform/chromium-cg-mac-snowleopard/fast/table/multiple-captions-display-expected.png: Added.
platform/chromium-cg-mac-snowleopard/fast/table/multiple-captions-display-expected.txt: Added.
platform/chromium-cg-mac-snowleopard/fast/table/prepend-in-anonymous-table-expected.txt: Copied from LayoutTests/platform/gtk/fast/table/prepend-in-anonymous-table-expected.txt.
platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.png: Added.
platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.txt: Added.
platform/chromium-cg-mac/tables/mozilla_expected_failures/other/test4-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/table/dynamic-caption-add-before-child-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/table/dynamic-caption-add-before-child-expected.png.
platform/chromium-mac-snowleopard/fast/table/multiple-captions-display-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/table/multiple-captions-display-expected.png.
platform/chromium-mac-snowleopard/fast/table/prepend-in-anonymous-table-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/table/prepend-in-anonymous-table-expected.png.
platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla_expected_failures/other/test4-expected.png.
platform/chromium-win/css2.1/20110323/border-spacing-applies-to-015-expected.png: Added.
platform/chromium-win/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/border-spacing-applies-to-015-expected.txt.
platform/chromium-win/css2.1/20110323/table-caption-001-expected.png: Added.
platform/chromium-win/css2.1/20110323/table-caption-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-001-expected.txt.
platform/chromium-win/css2.1/20110323/table-caption-002-expected.png: Added.
platform/chromium-win/css2.1/20110323/table-caption-002-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-002-expected.txt.
platform/chromium-win/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Added.
platform/chromium-win/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt.
platform/chromium-win/css2.1/20110323/table-caption-margins-001-expected.png: Added.
platform/chromium-win/css2.1/20110323/table-caption-margins-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-margins-001-expected.txt.
platform/chromium-win/css2.1/20110323/table-caption-optional-001-expected.png: Added.
platform/chromium-win/css2.1/20110323/table-caption-optional-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-001-expected.txt.
platform/chromium-win/css2.1/20110323/table-caption-optional-002-expected.png: Added.
platform/chromium-win/css2.1/20110323/table-caption-optional-002-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-002-expected.txt.
platform/chromium-win/fast/table/dynamic-caption-add-before-child-expected.png:
platform/chromium-win/fast/table/multiple-captions-display-expected.png:
platform/chromium-win/tables/mozilla_expected_failures/other/test4-expected.png:
platform/gtk/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Added.
platform/gtk/css2.1/20110323/table-caption-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-001-expected.txt.
platform/gtk/css2.1/20110323/table-caption-002-expected.txt: Added.
platform/gtk/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Added.
platform/gtk/css2.1/20110323/table-caption-margins-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-margins-001-expected.txt.
platform/gtk/css2.1/20110323/table-caption-optional-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-001-expected.txt.
platform/gtk/css2.1/20110323/table-caption-optional-002-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-002-expected.txt.
platform/gtk/fast/table/dynamic-caption-add-before-child-expected.txt:
platform/gtk/fast/table/multiple-captions-display-expected.txt:
platform/gtk/fast/table/prepend-in-anonymous-table-expected.txt:
platform/gtk/tables/mozilla_expected_failures/other/test4-expected.txt:
platform/qt/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Added.
platform/qt/css2.1/20110323/table-caption-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-001-expected.txt.
platform/qt/css2.1/20110323/table-caption-002-expected.txt: Added.
platform/qt/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Added.
platform/qt/css2.1/20110323/table-caption-margins-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-margins-001-expected.txt.
platform/qt/css2.1/20110323/table-caption-optional-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-001-expected.txt.
platform/qt/css2.1/20110323/table-caption-optional-002-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-002-expected.txt.
platform/qt/fast/table/dynamic-caption-add-before-child-expected.txt:
platform/qt/fast/table/multiple-captions-display-expected.txt:
platform/qt/fast/table/prepend-in-anonymous-table-expected.txt:
platform/qt/tables/mozilla_expected_failures/other/test4-expected.txt:

2:29 PM Changeset in webkit [100192] by commit-queue@webkit.org

3 edits in trunk/Tools

new-run-webkit-tests should not be locale dependent https://bugs.webkit.org/show_bug.cgi?id=68691
Override LOCALE to en_US.

Patch by John Yani <vanuan@gmail.com> on 2011-11-14
Reviewed by Eric Seidel.

Scripts/webkitpy/layout_tests/port/base.py:

2:25 PM Changeset in webkit [100191] by commit-queue@webkit.org

20 edits
3 deletes in trunk/Source

Unreviewed, rolling out r100176.
http://trac.webkit.org/changeset/100176
https://bugs.webkit.org/show_bug.cgi?id=72309

it broke the Mac builds (missing symbols) in a non-obvious way
(Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-14

Source/WebCore:

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS):

bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):

html/canvas/WebGLExperimentalCompressedTextures.cpp: Removed.
html/canvas/WebGLExperimentalCompressedTextures.h: Removed.
html/canvas/WebGLExperimentalCompressedTextures.idl: Removed.
html/canvas/WebGLExtension.h:
html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::getSupportedExtensions):

html/canvas/WebGLRenderingContext.h:
platform/graphics/Extensions3D.h:
platform/graphics/GraphicsContext3D.h:
platform/graphics/efl/GraphicsContext3DEfl.cpp:
platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
platform/graphics/qt/GraphicsContext3DQt.cpp:

Source/WebKit/chromium:

public/WebGraphicsContext3D.h:
src/GraphicsContext3DChromium.cpp:
src/GraphicsContext3DPrivate.h:
tests/MockWebGraphicsContext3D.h:

2:22 PM Changeset in webkit [100190] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

Intermittent asserts in TextureMapperGL::bindSurface on MiniBrowser startup
https://bugs.webkit.org/show_bug.cgi?id=72299

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-11-14
Reviewed by Noam Rosenthal.

Added check that clipping rect is valid.
Clear GL error that might remain from QT GL operations.
Added GL error assert for scissor test operations.

UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPagePrivate::paintToCurrentGLContext):

2:19 PM Changeset in webkit [100189] by leviw@chromium.org

2 edits in branches/subpixellayout/Source/WebCore

Reverting lengths to being stored as pixel values for the specified zoom level and adopting an enclosingIntRect model for reporting sizes in RenderTreeAsText. This vastly lowers the number of failing layout tests on our branch.

1:56 PM Changeset in webkit [100188] by eae@chromium.org

1569 edits
513 copies
162 deletes in branches/subpixellayout

Merging trunk changes up until 100042 into subpixel branch.

1:55 PM Changeset in webkit [100187] by tony@chromium.org

2 edits in trunk/Source/WebCore

remove -wap-marquee css propery value
https://bugs.webkit.org/show_bug.cgi?id=72296

Reviewed by Adam Barth.

This css value is no longer used.

css/CSSValueKeywords.in:

1:49 PM Changeset in webkit [100186] by arv@chromium.org

2 edits in trunk/LayoutTests

JS Test Harness: Remove one more reference to non existing js-test-post-function.js
https://bugs.webkit.org/show_bug.cgi?id=72307

Reviewed by Ojan Vafai.

storage/indexeddb/mozilla/delete-result.html:

1:48 PM Changeset in webkit [100185] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Only send progress notifications for the main frame
https://bugs.webkit.org/show_bug.cgi?id=72302

Reviewed by Sam Weinig.

Since it's impossible in the API to tell which frame the progress notifications are for, just send them to the main frame for now.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::postProgressStartedNotification):
(WebKit::WebFrameLoaderClient::postProgressEstimateChangedNotification):
(WebKit::WebFrameLoaderClient::postProgressFinishedNotification):

1:45 PM Changeset in webkit [100184] by jchaffraix@webkit.org

2 edits in trunk/Tools

[Chromium] build-webkit silently drops the features flags
https://bugs.webkit.org/show_bug.cgi?id=72293

Reviewed by Tony Chang.

Chromium still ignores @features but now we give a warning!

Scripts/build-webkit: Check if one of the features is different

from the default and print a warning in this case.

1:21 PM Changeset in webkit [100183] by jchaffraix@webkit.org

4 edits
6 adds in trunk

Crash in RenderTableSection::splitColumn
https://bugs.webkit.org/show_bug.cgi?id=70171

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/table/crash-splitColumn-2.html

fast/table/crash-splitColumn-3.html
fast/table/crash-splitColumn.html

The old code would not take into account the fact that each RenderTableSection
can set its m_needsCellRecalc flag independently of the rest.

This means that you cannot assume that you can always split or append columns to
all the sections. Our approach is to skip sections needing cell recalc in several
parts of the code as they will be properly reset to the table's representations
during a cell recalc.

rendering/RenderTable.cpp:

(WebCore::RenderTable::splitColumn):
(WebCore::RenderTable::appendColumn):
Skip sections needing cell recalc as they will be properly updated later.

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::addCell):
Ignore a section needing cell recalc as addCell will be called after sync'ing
the internal column representation in recalcCells.

(WebCore::RenderTableSection::recalcCells):
Clear the flag at the beginning of the function to activate the previous functions.
Added a comment as to why this is fine.

(WebCore::RenderTableSection::appendColumn):
Added an ASSERT. If we need cell recalc, we should NEVER update m_grid outside
of recalcCells().

LayoutTests:

Added a couple of tests where different sections get their
m_needsCellRecalc set independently.

fast/table/crash-splitColumn-2-expected.txt: Added.
fast/table/crash-splitColumn-2.html: Added.
fast/table/crash-splitColumn-3-expected.txt: Added.
fast/table/crash-splitColumn-3.html: Added.
fast/table/crash-splitColumn-expected.txt: Added.
fast/table/crash-splitColumn.html: Added.

12:58 PM Changeset in webkit [100182] by abarth@webkit.org

6 edits in trunk/Source

Remove the concept of an empty SecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=72287

Reviewed by Eric Seidel.

Source/WebCore:

This concept is fragile and doesn't exist in the specs. Previous
patches have removed most of the code relying upon this function. This
patch removes a couple stragglers.

page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessage):

This check should really be about unique origins because it doesn't make sense to target postMessages at unique origins, as explained in the comment.

page/SecurityOrigin.cpp:
page/SecurityOrigin.h:

Source/WebKit/chromium:

I'll rename the API in a subsequent patch.

src/WebSecurityOrigin.cpp:

(WebKit::WebSecurityOrigin::isEmpty):

12:56 PM Changeset in webkit [100181] by abarth@webkit.org

2 edits in trunk/Source/WebCore

SecurityContext::isSecureTransitionTo should not refer to empty security origins
https://bugs.webkit.org/show_bug.cgi?id=72277

Reviewed by Eric Seidel.

Now that we're tracking the "failed to initialized SecurityOrigin"
state explicitly, we should use that to determine whether we can make a
secure transition.

dom/SecurityContext.cpp:

(WebCore::SecurityContext::isSecureTransitionTo):

12:50 PM Changeset in webkit [100180] by scheib@chromium.org

19 edits in trunk/Source

Mouse Lock: Renaming to 'Pointer Lock': ENABLE Flags
https://bugs.webkit.org/show_bug.cgi?id=72286

Reviewed by Adam Barth.

Source/JavaScriptCore:

wtf/Platform.h:

Source/WebCore:

bindings/generic/RuntimeEnabledFeatures.cpp:
bindings/generic/RuntimeEnabledFeatures.h:
dom/MouseEvent.idl:
dom/MouseRelatedEvent.h:
page/MouseLockable.cpp:
page/MouseLockable.h:
page/MouseLockable.idl:
page/Navigator.cpp:
page/Navigator.h:
page/Navigator.idl:
page/Settings.cpp:

(WebCore::Settings::Settings):

page/Settings.h:

Source/WebKit/chromium:

features.gypi:
src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableMouseLockAPI):
(WebKit::WebRuntimeFeatures::isMouseLockAPIEnabled):

src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setMouseLockEnabled):

12:48 PM Changeset in webkit [100179] by jer.noble@apple.com

2 edits in trunk/LayoutTests

Unreviewed; skipping newly failing tests which need rebaselining.

Added skipped tests; tracked by https://bugs.webkit.org/show_bug.cgi?id=72297.

platform/gtk/Skipped:

12:46 PM Changeset in webkit [100178] by annacc@chromium.org

6 edits
2 deletes in trunk/Source/WebCore

Remove TextTrackCueIndex and TextTrackCueSet. No longer needed.
https://bugs.webkit.org/show_bug.cgi?id=72216

Reviewed by Sam Weinig.

No new tests. No new functionality.

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.xcodeproj/project.pbxproj:
html/TextTrackCueIndex.cpp: Removed.
html/TextTrackCueIndex.h: Removed.

12:41 PM Changeset in webkit [100177] by robert@webkit.org

15 edits
21 adds in trunk

CSS 2.1 failure: border-spacing-applies-to-015.htm
https://bugs.webkit.org/show_bug.cgi?id=69773

Reviewed by David Hyatt.

Source/WebCore:

The CSS test suite expects UAs to allow multiple captions per table.
Replace m_caption with a Vector called m_captions.

rendering/RenderTable.cpp:

(WebCore::RenderTable::RenderTable):
(WebCore::RenderTable::addChild):
(WebCore::RenderTable::removeChild):
(WebCore::RenderTable::adjustLogicalHeightForCaption):
(WebCore::RenderTable::layout):
(WebCore::RenderTable::addOverflowFromChildren):
(WebCore::RenderTable::paintObject):
(WebCore::RenderTable::subtractCaptionRect):
(WebCore::RenderTable::computePreferredLogicalWidths):
(WebCore::RenderTable::nextColElement):
(WebCore::RenderTable::colElement):
(WebCore::RenderTable::recalcCaption):
(WebCore::RenderTable::recalcSections):
(WebCore::RenderTable::overflowClipRect):
(WebCore::RenderTable::nodeAtPoint):

rendering/RenderTable.h:

LayoutTests:

css2.1/20110323/border-spacing-applies-to-015.htm: Added. Now passes!
css2.1/20110323/table-caption-001.htm: Added. Passed anyway.
css2.1/20110323/table-caption-002.htm: Added. Now passes!
css2.1/20110323/table-caption-horizontal-alignment-001.htm: Added. Passed anyway.
css2.1/20110323/table-caption-margins-001.htm: Added. Passed anyway.
css2.1/20110323/table-caption-optional-001.htm: Added. Passed anyway.
css2.1/20110323/table-caption-optional-002.htm: Added. Passed anyway.
fast/table/dynamic-caption-add-before-child.xhtml: Extra captions now appear in result

so remove their FAIL notices.

fast/table/multiple-captions-crash-expected.txt: Result reflects extra captions.
fast/table/multiple-captions-crash2-expected.txt: Result reflects extra captions.
fast/table/multiple-captions-display.xhtml: Extra captions now appear in result

so remove their FAIL notices.

platform/chromium-linux/css2.1/20110323/border-spacing-applies-to-015-expected.png: Added.
platform/chromium-linux/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Added.
platform/chromium-linux/css2.1/20110323/table-caption-001-expected.png: Added.
platform/chromium-linux/css2.1/20110323/table-caption-001-expected.txt: Added.
platform/chromium-linux/css2.1/20110323/table-caption-002-expected.png: Added.
platform/chromium-linux/css2.1/20110323/table-caption-002-expected.txt: Added.
platform/chromium-linux/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Added.
platform/chromium-linux/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Added.
platform/chromium-linux/css2.1/20110323/table-caption-margins-001-expected.png: Added.
platform/chromium-linux/css2.1/20110323/table-caption-margins-001-expected.txt: Added.
platform/chromium-linux/css2.1/20110323/table-caption-optional-001-expected.png: Added.
platform/chromium-linux/css2.1/20110323/table-caption-optional-001-expected.txt: Added.
platform/chromium-linux/css2.1/20110323/table-caption-optional-002-expected.png: Added.
platform/chromium-linux/css2.1/20110323/table-caption-optional-002-expected.txt: Added.
platform/chromium-linux/fast/table/dynamic-caption-add-before-child-expected.png: Result reflects extra captions.
platform/chromium-linux/fast/table/multiple-captions-display-expected.png: Result reflects extra captions.
platform/chromium-linux/tables/mozilla_expected_failures/other/test4-expected.png: Result reflects extra caption.
platform/chromium-win/fast/table/dynamic-caption-add-before-child-expected.txt: Result reflects extra captions.
platform/chromium-win/fast/table/multiple-captions-display-expected.txt: Result reflects extra captions.
platform/chromium-win/fast/table/prepend-in-anonymous-table-expected.txt: Result reflects extra caption.
platform/chromium-win/tables/mozilla_expected_failures/other/test4-expected.txt: Result reflects extra caption.

12:24 PM Changeset in webkit [100176] by commit-queue@webkit.org

20 edits
1 copy
2 adds in trunk/Source

Implement WEBGL_EXPERIMENTAL_compressed_textures WebGL extension
https://bugs.webkit.org/show_bug.cgi?id=72086

Patch by Gregg Tavares <gman@google.com> on 2011-11-14
Reviewed by Kenneth Russell.

Source/WebCore:

No new tests. Will write final test once on hardware.

CMakeLists.txt:
GNUmakefile.list.am:
WebCore.gypi:
WebCore.pro:
bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS):

bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):

html/canvas/WebGLExperimentalCompressedTextures.cpp: Added.

(WebCore::WebGLExperimentalCompressedTextures::WebGLExperimentalCompressedTextures):
(WebCore::WebGLExperimentalCompressedTextures::~WebGLExperimentalCompressedTextures):
(WebCore::WebGLExperimentalCompressedTextures::getName):
(WebCore::WebGLExperimentalCompressedTextures::create):
(WebCore::WebGLExperimentalCompressedTextures::supported):
(WebCore::WebGLExperimentalCompressedTextures::validateCompressedTexFormat):
(WebCore::WebGLExperimentalCompressedTextures::validateCompressedTexFuncData):
(WebCore::WebGLExperimentalCompressedTextures::validateCompressedTexSubDimensions):
(WebCore::WebGLExperimentalCompressedTextures::compressedTexImage2D):
(WebCore::WebGLExperimentalCompressedTextures::compressedTexSubImage2D):
(WebCore::WebGLExperimentalCompressedTextures::getCompressedTextureFormats):

html/canvas/WebGLExperimentalCompressedTextures.h: Added.
html/canvas/WebGLExperimentalCompressedTextures.idl: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
html/canvas/WebGLExtension.h:
html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::getSupportedExtensions):

html/canvas/WebGLRenderingContext.h:
platform/graphics/Extensions3D.h:
platform/graphics/GraphicsContext3D.h:
platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::compressedTexImage2D):
(WebCore::GraphicsContext3D::compressedTexSubImage2D):

platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::compressedTexImage2D):
(WebCore::GraphicsContext3D::compressedTexSubImage2D):

platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::compressedTexImage2D):
(WebCore::GraphicsContext3D::compressedTexSubImage2D):

Source/WebKit/chromium:

public/WebGraphicsContext3D.h:
src/GraphicsContext3DChromium.cpp:
src/GraphicsContext3DPrivate.h:
tests/MockWebGraphicsContext3D.h:

(WebKit::MockWebGraphicsContext3D::compressedTexImage2D):
(WebKit::MockWebGraphicsContext3D::compressedTexSubImage2D):

12:23 PM Changeset in webkit [100175] by barraclough@apple.com

3 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=72280

Rubber stamped by Geoff Garen.

Fix 32-bit Lion.

JavaScriptCore.xcodeproj/project.pbxproj:
wtf/OSAllocatorPosix.cpp:

(WTF::OSAllocator::reserveAndCommit):

12:08 PM Changeset in webkit [100174] by ddkilzer@apple.com

2 edits
4 adds in trunk/Tools

run-leaks does not work on Lion?
<http://webkit.org/b/71059>
<rdar://problem/10428527>

Reviewed by Adam Roben.

The output of leaks(1) changed again in Lion to move the
"leaks Report Version: 2.0" line from the first line of the
output to just above the "Process " lines that run-leaks is
interested in parsing. This required using a more generic
algorithm to find the start of the "Process " lines.

Scripts/run-leaks:

(parseLeaksOutput): Make the code to skip headers more generic.

Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Added.
Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Added.
Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Added.

12:04 PM Changeset in webkit [100173] by commit-queue@webkit.org

5 edits in trunk/Source/WebKit/chromium

[chromium] MediaStream API: Adding a sources() method to WebMediaStreamDescriptor
https://bugs.webkit.org/show_bug.cgi?id=72116

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-11-14
Reviewed by Darin Fisher.

public/WebMediaStreamDescriptor.h:
public/WebMediaStreamSource.h:
src/WebMediaStreamDescriptor.cpp:

(WebKit::WebMediaStreamDescriptor::sources):

src/WebMediaStreamSource.cpp:

(WebKit::WebMediaStreamSource::operator=):

11:46 AM Changeset in webkit [100172] by Michael Nordman

32 edits in trunk

Source/WebCore: Return more complete error and exception messages when a
WebSQLDatabase function fails. Produce console logging
for openDatabase() errors and vacuum errors. Add a lastErrorMessage
accessor to the DatabaseSync interface.
https://bugs.webkit.org/show_bug.cgi?id=71575

Reviewed by David Levin.

Yes, see LayoutTests/ChangeLog in this patch.

platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::SQLiteDatabase):
(WebCore::SQLiteDatabase::open):
(WebCore::SQLiteDatabase::close):
(WebCore::SQLiteDatabase::lastError):
(WebCore::SQLiteDatabase::lastErrorMsg):
(WebCore::SQLiteDatabase:: runVacuumCommand):
(WebCore::SQLiteDatabase:: runIncrementalVacuumCommand):
Reflect errors in the open() method in lastError() and lastErrorMsg().
Return an error codes for runVacuumCommand() and runIncrementalVacuumCommand().

platform/sql/SQLiteDatabase.h:
storage/AbstractDatabase.cpp:

(WebCore::formatErrorMessage):
(WebCore::AbstractDatabase::performOpenAndVerify):
(WebCore::AbstractDatabase::logErrorMessage):
During openAndVerify, produce formatted error messages that include what was being done, the sqlite error code,
and the sqlite error message. Add a helper to log message to the console.

storage/AbstractDatabase.h:
storage/ChangeVersionWrapper.cpp:

(WebCore::ChangeVersionWrapper::performPreflight):
(WebCore::ChangeVersionWrapper::performPostflight):

storage/Database.cpp:

(WebCore::Database::openDatabase):
(WebCore::Database::openAndVerifyVersion):
(WebCore::Database::performOpenAndVerify):

storage/Database.h:
storage/DatabaseSync.cpp:

(WebCore::DatabaseSync::openDatabaseSync):
(WebCore::DatabaseSync::changeVersion):
(WebCore::DatabaseSync::runTransaction):

storage/DatabaseSync.h:

(WebCore::DatabaseSync::lastErrorMessage):
(WebCore::DatabaseSync::setLastErrorMessage):

storage/DatabaseSync.idl:

Add a lastErrorMessage attribute so javascript callers can
retrieve more detailed information about what went wrong.

storage/DatabaseTask.cpp:

(WebCore::Database::DatabaseOpenTask::DatabaseOpenTask):
(WebCore::Database::DatabaseOpenTask::doPerformTask):

storage/DatabaseTask.h:

(WebCore::Database::DatabaseOpenTask::create):
Return an errorMessage in addition to the exception code.

storage/SQLError.h:

(WebCore::SQLError::create):
Add helpers to produced formatted error messages.

storage/SQLStatement.cpp:

(WebCore::SQLStatement::execute):

storage/SQLStatementSync.cpp:

(WebCore::SQLStatementSync::execute):

storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::openTransactionAndPreflight):
(WebCore::SQLTransaction::postflightAndCommit):

storage/SQLTransactionSync.cpp:

(WebCore::SQLTransactionSync::executeSQL):
(WebCore::SQLTransactionSync::begin):
(WebCore::SQLTransactionSync::execute):
(WebCore::SQLTransactionSync::commit):

LayoutTests: Update layout tests for new websql error messages and console logging.
https://bugs.webkit.org/show_bug.cgi?id=71575

Reviewed by David Levin.

fast/workers/storage/change-version-handle-reuse-worker-expected.txt:
fast/workers/storage/executesql-accepts-only-one-statement-sync.html:
fast/workers/storage/executesql-accepts-only-one-statement-sync-expected.txt:
fast/workers/storage/open-database-creation-callback-sync-expected.txt:
fast/workers/storage/open-database-set-empty-version-sync-expected.txt:
fast/workers/storage/test-authorizer-expected.txt:
fast/workers/storage/transaction-in-transaction-sync.html:
fast/workers/storage/transaction-in-transaction-sync-expected.txt:
storage/change-version-handle-reuse-expected.txt:
storage/open-database-creation-callback-expected.txt:
storage/open-database-set-empty-version-expected.txt:
storage/private-browsing-noread-nowrite-expected.txt:
storage/test-authorizer-expected.txt:

11:44 AM Changeset in webkit [100171] by ggaren@apple.com

4 edits in trunk/Source/JavaScriptCore

32-bit Build fix: declare virtual register indices to be int rather than
unsigned, since they can be positive or negative.

For better clarity, explicitly use ReturnPC instead of -1 as the "invalid"
state, since we'll never load and operate on the ReturnPC as a JS value.

jit/JIT.cpp:

(JSC::JIT::JIT):

jit/JIT.h:
jit/JITInlineMethods.h:

(JSC::JIT::emitLoadTag):
(JSC::JIT::emitLoadPayload):
(JSC::JIT::emitLoad):
(JSC::JIT::emitLoad2):
(JSC::JIT::emitLoadDouble):
(JSC::JIT::emitLoadInt32ToDouble):
(JSC::JIT::emitStore):
(JSC::JIT::emitStoreInt32):
(JSC::JIT::emitStoreAndMapInt32):
(JSC::JIT::emitStoreCell):
(JSC::JIT::emitStoreBool):
(JSC::JIT::emitStoreDouble):
(JSC::JIT::map):
(JSC::JIT::unmap):
(JSC::JIT::isMapped):
(JSC::JIT::getMappedPayload):
(JSC::JIT::getMappedTag):
(JSC::JIT::emitJumpSlowCaseIfNotJSCell):

11:39 AM Changeset in webkit [100170] by abarth@webkit.org

1 edit in trunk/Source/WebCore/dom/Document.cpp

Fix typo.

11:33 AM Changeset in webkit [100169] by abarth@webkit.org

2 edits in trunk/Source/WebCore

SecurityOrigin inheritance should depend on document URL, not on "emptiness" of the SecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=72283

Reviewed by Sam Weinig.

This change aligns our implementation more closely with the spec. I
don't think this change has an observable effects, but it moves us
closer to removing the concept of an empty security origin.

dom/Document.cpp:

(WebCore::shouldInheritSecurityOriginFromOwner):
(WebCore::Document::initSecurityContext):

11:26 AM Changeset in webkit [100168] by msaboff@apple.com

2 edits in trunk/Source/JavaScriptCore

Remove unused m_data member from UStringSourceProvider
https://bugs.webkit.org/show_bug.cgi?id=72289

Removed unused m_data member from UStringSourceProvider.

Reviewed by Oliver Hunt.

parser/SourceProvider.h:

(JSC::UStringSourceProvider::UStringSourceProvider):

11:25 AM Changeset in webkit [100167] by msaboff@apple.com

2 edits in trunk/Source/JavaScriptCore

Towards 8 Bit Strings: Templatize YARR Parser
https://bugs.webkit.org/show_bug.cgi?id=72288

Changed Yarr::Parser to be a template based on character type.

Reviewed by Oliver Hunt.

yarr/YarrParser.h:

(JSC::Yarr::Parser::Parser):
(JSC::Yarr::parse):

11:23 AM Changeset in webkit [100166] by ggaren@apple.com

2 edits in trunk/Source/JavaScriptCore

32-bit build fix: Removed unused declaration.

dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::emitCall):

11:21 AM Changeset in webkit [100165] by ggaren@apple.com

31 edits in trunk/Source/JavaScriptCore

Standardized the JS calling convention
https://bugs.webkit.org/show_bug.cgi?id=72221

Reviewed by Oliver Hunt.

This patch standardizes the calling convention so that the caller always
sets up the callee's CallFrame. Adjustments for call type, callee type,
argument count, etc. now always take place after that initial setup.

This is a step toward reversing the argument order, but also has these
immediate benefits (measured on x64):

(1) 1% benchmark speedup across the board.

(2) 50% code size reduction in baseline JIT function calls.

(3) 1.5x speedup for single-dispatch .apply forwarding.

(4) 1.1x speedup for multi-dispatch .apply forwarding.

This change affected the baseline JIT most, since the baseline JIT had
lots of ad hoc calling conventions for different caller / callee types.

assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::branchPtr):
(JSC::MacroAssemblerX86_64::branchAddPtr): Optimize compare to 0 into
a test, like other assemblers do. (I added some compares to 0, and didn't
want them to be slow.)

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump): Merged op_load_varargs into op_call_varargs so
op_call_varargs could share code generation with other forms of op_call.
This is also a small optimization, since op_*varargs no longer have to
pass arguments to each other through the register file.

(JSC::CallLinkInfo::unlink):

bytecode/CodeBlock.h: Added a new call type: CallVarargs. This allows

us to link functions called through .apply syntax. We need to distinguish
CallVarargs from Call because CallVarargs changes its argument count
on each inovcation, so we must always link to the argument count checking
version of the callee.

bytecode/Opcode.h:
bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCallVarargs):

bytecompiler/BytecodeGenerator.h: Merged op_load_varargs into op_call_varargs.

bytecompiler/NodesCodegen.cpp:

(JSC::ApplyFunctionCallDotNode::emitBytecode): Ditto. Also, simplified
some of this bytecode generation to remove redundant copies.

dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::emitCall):

dfg/DFGJITCodeGenerator64.cpp:

(JSC::DFG::JITCodeGenerator::emitCall): Added a new call type: CallVarargs.
DFG doesn't support this type, but its code needs to change slightly
to accomodate a 3-state variable.

Stopped passing the argument count in regT1 because this is non-standard.
(The argument count goes in the CallFrame. This trades speed on the slow
path for speed and code size on the fast path, and simplicity on all paths.
A good trade, in my opinion.)

dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction): Tweaked code to make CallFrame
setup more obvious when single-stepping. Also, updated for argument count
not being in regT1.

dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::addJSCall):
(JSC::DFG::JITCompiler::JSCallRecord::JSCallRecord): Added a new call
type: CallVarargs.

dfg/DFGOperations.cpp: Do finish CallFrame setup in one place before

doing anything else. Don't check for stack overflow because we have no callee
registers, and our caller has already checked for its own registers.

dfg/DFGRepatch.cpp:

(JSC::DFG::dfgLinkFor): We can link to our callee even if our argument
count doesn't match -- we just need to link to the argument count checking
version.

interpreter/CallFrameClosure.h:

(JSC::CallFrameClosure::setArgument): BUG FIX: When supplying too many
arguments from C++, we need to supply a full copy of the arguments prior
to the subset copy that matches our callee's argument count. (That is what
the standard calling convention would have produced in JS.) I would have
split this into its own patch, but I couldn't find a way to get the JIT
to fail a regression test in this area without my patch applied.

interpreter/Interpreter.cpp: Let the true code bomb begin!

(JSC::eval): Fixed up this helper function to operate on eval()'s CallFrame,
and not eval()'s caller frame. We no longer leave the CallFrame pointing
to eval()'s caller during a call to eval(), since that is not standard.

(JSC::loadVarargs): Factored out a shared helper function for use by JIT
and interpreter because half the code means one quarter the bugs -- in my
programming, at least.

(JSC::Interpreter::execute): Removed a now-unused way to invoke eval.

(JSC::Interpreter::privateExecute): Removed an invalid ASSERT following
putDirect, because it got in the way of my testing. (When putting a
function, the cached base of a PutPropertySlot can be 0 to signify "do
not optimize".)

op_call_eval: Updated for new, standard eval calling convention.

op_load_varargs: Merged op_load_varargs into op_call_varargs.

op_call_varags: Updated for new, standard eval calling convention. Don't
check for stack overflow because the loadVarargs helper function already
checked.

interpreter/Interpreter.h:

(JSC::Interpreter::execute): Headers are fun and educational!

interpreter/RegisterFile.cpp:

(JSC::RegisterFile::growSlowCase):

interpreter/RegisterFile.h:

(JSC::RegisterFile::grow): Factored out the slow case into a slow
case because it was cramping the style of my fast case.

jit/JIT.cpp:

(JSC::JIT::privateCompile): Moved initialization of
RegisterFile::CodeBlock to make it more obvious when debugging. Removed
assumption that argument count is in regT1, as above. Removed call to
restoreArgumentReference() because the JITStubCall abstraction does this for us.

(JSC::JIT::linkFor): Link even if we miss on argument count, as above.

jit/JIT.h:
jit/JITCall32_64.cpp:

(JSC::JIT::emitSlow_op_call):
(JSC::JIT::emitSlow_op_call_eval):
(JSC::JIT::emitSlow_op_call_varargs):
(JSC::JIT::emitSlow_op_construct):
(JSC::JIT::emit_op_call_eval):
(JSC::JIT::emit_op_call_varargs): Share all function call code generation.
Don't count call_eval when accounting for linkable function calls because
eval doesn't link. (Its fast path is to perform the eval.)

(JSC::JIT::compileLoadVarargs): Ported this inline copying optimization
to our new calling convention. The key to this optimization is the
observation that, in a function that declares no arguments, if any
arguments are passed, they all end up right behind 'this'.

(JSC::JIT::compileCallEval):
(JSC::JIT::compileCallEvalSlowCase): Factored out eval for a little clarity.

(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase): If you are still with me, dear reader,
this is the whole point of my patch. The caller now unconditionally moves
the CallFrame forward and fills in the data it knows before taking any
branches to deal with weird caller/callee pairs.

This also means that there is almost no slow path for calls -- it all
gets folded into the shared virtual call stub. The only things remaining
in the slow path are the rare case counter and a call to the stub.

jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall): Updated for values being in
different registers or in memory, based on our new standard calling
convention.

Added a shared path for calling out to CTI helper functions for non-JS
calls.

jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_method_check): method_check emits its own code and
the following get_by_id's code, so it needs to add both when informing
result chaining of its result. This is important because the standard
calling convention can now take advantage of this chaining.

jit/JITCall.cpp:

(JSC::JIT::compileLoadVarargs):
(JSC::JIT::compileCallEval):
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):

jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::emit_op_call_eval):
(JSC::JIT::emit_op_call_varargs):
(JSC::JIT::emitSlow_op_call):
(JSC::JIT::emitSlow_op_call_eval):
(JSC::JIT::emitSlow_op_call_varargs):
(JSC::JIT::emitSlow_op_construct): Observe, as I write all of my code a
second time, now with 64 bits.

jit/JITStubs.cpp:

(JSC::throwExceptionFromOpCall):
(JSC::jitCompileFor):
(JSC::arityCheckFor):
(JSC::lazyLinkFor): A lot of mechanical changes here for one purpose:
Exceptions thrown in the middle of a function call now use a shared helper
function (throwExceptionFromOpCall). This function understands that the
CallFrame currently points to the callEE, and the exception must be
thrown by the callER. (The old calling convention would often still have
the CallFrame pointing at the callER at the point of an exception. That
is not the way of our new, standard calling convention.)

(JSC::op_call_eval): Finish standard CallFrame setup before calling
our eval helper function, which now depends on that setup.

runtime/Arguments.h:

(JSC::Arguments::length): Renamed numProvidedArguments() to length()
because that's what other objects call it, and the difference made our
new loadVarargs helper function hard to read.

runtime/Executable.cpp:

(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal): Interpreter build
fixes.

runtime/FunctionPrototype.cpp:

(JSC::functionProtoFuncApply): Honor Arguments::MaxArguments even when
the .apply call_varargs optimization fails. (This bug appears on layout
tests when you disable the optimization.)

11:14 AM Changeset in webkit [100164] by arv@chromium.org

16 edits
6 deletes in trunk

Remove getParameter from HTMLAnchorElement and Location
https://bugs.webkit.org/show_bug.cgi?id=71966

Reviewed by Adam Barth.

Source/WebCore:

html/HTMLAnchorElement.cpp: Removed getParameter.
html/HTMLAnchorElement.h: Ditto.
html/HTMLAnchorElement.idl: Ditto.
page/Location.cpp: Ditto.
page/Location.h: Ditto.
page/Location.idl: Ditto.

LayoutTests:

fast/dom/HTMLAnchorElement/get-parameter-expected.txt: Removed.
fast/dom/HTMLAnchorElement/get-parameter.html: Removed.
fast/dom/Window/window-appendages-cleared-expected.txt:
fast/dom/Window/window-properties-expected.txt:
fast/dom/anchor-getParameter-expected.txt: Removed.
fast/dom/anchor-getParameter.html: Removed.
http/tests/misc/location-getParameter-expected.txt: Removed.
http/tests/misc/location-getParameter.html: Removed.
platform/gtk/fast/dom/Window/window-properties-expected.txt:
platform/mac/fast/dom/Window/window-properties-expected.txt:
platform/qt-5.0/Skipped:
platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
platform/qt/fast/dom/Window/window-properties-expected.txt:
platform/win/fast/dom/Window/window-properties-expected.txt:

11:11 AM Changeset in webkit [100163] by arv@chromium.org

22 edits
2 adds in trunk

Remove RequiresAllArguments
https://bugs.webkit.org/show_bug.cgi?id=71503

Reviewed by Adam Barth.

Source/WebCore:

This removes RequiresAllArguments from the idl files as well as from the code generators.
For window.move/resize/scroll we now match IE and treat missing arguments as 0.
For Clipboard we now match Gecko and IE and throw an exception when setData is called with too few arguments.

Test: fast/events/drag-and-drop-set-drag-data-arguments.html

bindings/js/JSSVGLengthCustom.cpp:

(WebCore::JSSVGLength::convertToSpecifiedUnits):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateArgumentsCountCheck): Remove RequiresAllArguments.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateArgumentsCountCheck): Ditto.

bindings/scripts/test/CPP/WebDOMTestObj.cpp:
bindings/scripts/test/CPP/WebDOMTestObj.h:
bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
bindings/scripts/test/GObject/WebKitDOMTestObj.h:
bindings/scripts/test/JS/JSTestObj.cpp:
bindings/scripts/test/JS/JSTestObj.h:
bindings/scripts/test/ObjC/DOMTestObj.h:
bindings/scripts/test/ObjC/DOMTestObj.mm:
bindings/scripts/test/TestObj.idl:
bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::ConfigureV8TestObjTemplate):

dom/Clipboard.idl: Remove [RequireAllArguments] from setData which actually means we now require all arguments and throw instead of silently fail.
page/DOMWindow.idl: Treat missing arguments as 0 which makes us match IE.
websockets/WebSocket.idl: Comment changes only.

LayoutTests:

fast/dom/Window/window-resize-and-move-arguments-expected.txt:
fast/dom/Window/window-resize-and-move-arguments.html: Treat missing arguments as 0.
fast/dom/Window/window-scroll-arguments-expected.txt:
fast/dom/Window/window-scroll-arguments.html: Ditto.
fast/events/drag-and-drop-set-drag-data-arguments-expected.txt: Added.
fast/events/drag-and-drop-set-drag-data-arguments.html: Added. This tests that we get an exception when called with too few arguments.

10:06 AM Changeset in webkit [100162] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/chromium

[chromium] MediaStream API: Allow for null WebPeerConnectionHandler
https://bugs.webkit.org/show_bug.cgi?id=72114

Fixing crash if WebKitPlatformSupport returns a null WebPeerConnectionHandler
to PeerConnectionHandlerInternal.

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-11-14
Reviewed by Adam Barth.

bridge/PeerConnectionHandlerInternal.cpp:

(WebCore::PeerConnectionHandlerInternal::PeerConnectionHandlerInternal):
(WebCore::PeerConnectionHandlerInternal::produceInitialOffer):
(WebCore::PeerConnectionHandlerInternal::handleInitialOffer):
(WebCore::PeerConnectionHandlerInternal::processSDP):
(WebCore::PeerConnectionHandlerInternal::processPendingStreams):
(WebCore::PeerConnectionHandlerInternal::sendDataStreamMessage):
(WebCore::PeerConnectionHandlerInternal::stop):
(WebCore::PeerConnectionHandlerInternal::didCompleteICEProcessing):
(WebCore::PeerConnectionHandlerInternal::didGenerateSDP):
(WebCore::PeerConnectionHandlerInternal::didReceiveDataStreamMessage):
(WebCore::PeerConnectionHandlerInternal::didAddRemoteStream):
(WebCore::PeerConnectionHandlerInternal::didRemoveRemoteStream):

public/WebKitPlatformSupport.h:

9:59 AM Changeset in webkit [100161] by Lucas Forschler

1 copy in tags/Safari-534.52.11

New tag.

9:56 AM Changeset in webkit [100160] by commit-queue@webkit.org

2 edits in trunk/Tools

Missing include in Tools/DumpRenderTree/chromium/AccessibilityUIElement.h:
https://bugs.webkit.org/show_bug.cgi?id=72088

Patch by Lei Zhang <thestig@chromium.org> on 2011-11-14
Reviewed by Tony Chang.

DumpRenderTree/chromium/AccessibilityUIElement.h:

9:55 AM Changeset in webkit [100159] by jer.noble@apple.com

32 edits
3 copies
7 adds in trunk

Implement MediaController.
https://bugs.webkit.org/show_bug.cgi?id=71408

Reviewed by Eric Carlson.

Source/JavaScriptCore:

Change the definition of WTF_USE_COREAUDIO to exclude Windows completely, as
CoreAudioClock.h is not available there.

wtf/Platform.h:

Source/WebCore:

Tests: media/media-controller-playback.html

media/media-controller.html

Adds support for the MediaController DOM object, and the mediagroup and mediacontroller
HTMLMediaElement attributes.

MediaController is an DOM object which synchronizes playback of multiple HTMLMediaElements. It can
either be created by a page script and assigned to a HTMLMediaElement using the controller property,
or all HTMLMediaElements with identical mediagroup attributes will have a MediaController assigned
automatically.

Add an abstract interface implemented by both MediaController and HTMLMediaElement.

html/MediaControllerInterface.h: Added.

(WebCore::MediaControllerInterface::~MediaControllerInterface):

Add the MediaController object and IDL.

html/MediaController.cpp: Added.

(mediaGroupToMediaControllerMap):
(MediaController::mediaControllerForMediaGroup):
(MediaController::create):
(MediaController::MediaController):
(MediaController::~MediaController):
(MediaController::addMediaElement):
(MediaController::removeMediaElement):
(MediaController::containsMediaElement):
(MediaController::buffered):
(MediaController::seekable):
(MediaController::played):
(MediaController::duration):
(MediaController::currentTime):
(MediaController::setCurrentTime):
(MediaController::play):
(MediaController::pause):
(MediaController::setDefaultPlaybackRate):
(MediaController::setPlaybackRate):
(MediaController::setVolume):
(MediaController::setMuted):
(MediaController::reportControllerState):
(MediaController::updateReadyState):
(MediaController::updatePlaybackState):
(MediaController::updateMediaElements):
(MediaController::scheduleEvent):
(MediaController::asyncEventTimerFired):
(MediaController::scriptExecutionContext):
(MediaController::hasAudio):
(MediaController::hasVideo):
(MediaController::hasClosedCaptions):
(MediaController::setClosedCaptionsVisible):
(MediaController::supportsScanning):
(MediaController::beginScrubbing):
(MediaController::endScrubbing):
(MediaController::canPlay):
(MediaController::isLiveStream):
(MediaController::hasSource):
(MediaController::returnToRealtime):
(MediaController::isBlocked):
(MediaController::hasEnded):

html/MediaController.h: Added.

(WebCore::MediaController::mediaGroup):
(WebCore::MediaController::paused):
(WebCore::MediaController::defaultPlaybackRate):
(WebCore::MediaController::playbackRate):
(WebCore::MediaController::volume):
(WebCore::MediaController::muted):
(WebCore::MediaController::readyState):
(WebCore::MediaController::playbackState):
(WebCore::MediaController::supportsFullscreen):
(WebCore::MediaController::isFullscreen):
(WebCore::MediaController::enterFullscreen):
(WebCore::MediaController::closedCaptionsVisible):
(WebCore::MediaController::refEventTarget):
(WebCore::MediaController::derefEventTarget):
(WebCore::MediaController::toMediaController):
(WebCore::MediaController::eventTargetData):
(WebCore::MediaController::ensureEventTargetData):

html/MediaController.idl: Added.

Add convenience functions to TimeRanges which can calculate intersections and
unions between TimeRanges objects.

html/TimeRanges.cpp:

(TimeRanges::copy):
(TimeRanges::invert):
(TimeRanges::intersectWith):
(TimeRanges::unionWith):

html/TimeRanges.h:

Add MediaControllerConstructor to the Window object.

page/DOMWindow.idl:

Add the two new attribute names, mediagroup and controller.

html/HTMLAttributeNames.in:

Add support for the new attributes, and add overridden behavior when a media element
has a current media controller:

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::parseMappedAttribute):
(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::setCurrentTime):
(WebCore::HTMLMediaElement::setPlaybackRate):
(WebCore::HTMLMediaElement::playInternal):
(WebCore::HTMLMediaElement::togglePlayState):
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::seekable):
(WebCore::HTMLMediaElement::potentiallyPlaying):
(WebCore::HTMLMediaElement::endedPlayback):
(WebCore::HTMLMediaElement::updateVolume):
(WebCore::HTMLMediaElement::updatePlayState):
(WebCore::HTMLMediaElement::userCancelledLoad):
(WebCore::HTMLMediaElement::mediaGroup):
(WebCore::HTMLMediaElement::setMediaGroup):
(WebCore::HTMLMediaElement::controller):
(WebCore::HTMLMediaElement::setController):
(WebCore::HTMLMediaElement::updateMediaController):
(WebCore::HTMLMediaElement::isBlockedOnMediaController):

html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::hasSource):
(WebCore::HTMLMediaElement::isLiveStream):

html/HTMLMediaElement.idl:
bindings/js/JSHTMLMediaElementCustom.cpp: Added.

(WebCore::JSHTMLMediaElement::setMediaController):

Add convenience functions to store a mapping of media-elements-per-document to allow
a quick lookup of media elements with the same media group within a given document:

html/HTMLMediaElement.cpp:

(WebCore::documentToElementSetMap):
(WebCore::addElementToDocumentMap):
(WebCore::removeElementFromDocumentMap):

Add a function "seekable" which returns a TimeRanges containing the seekable time ranges
in a media element. By default this is a single range of [0, maxTimeSeekable].

platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::seekable):

platform/graphics/MediaPlayer.h:
platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::seekable):

Support functions to cast between MediaController and EventTarget.

bindings/js/JSEventTarget.cpp:

(WebCore::toJS):

dom/EventTarget.cpp:

(WebCore::EventTarget::toMediaController):

dom/EventTarget.h:

Fixed an infinite-recursion bug due to a collision between WTF::currentTime and
ClockGeneric::currentTime:

platform/ClockGeneric.cpp:

(ClockGeneric::ClockGeneric):
(ClockGeneric::setCurrentTime):
(ClockGeneric::currentTime):
(ClockGeneric::setPlayRate):
(ClockGeneric::start):
(ClockGeneric::stop):
(ClockGeneric::now):

platform/ClockGeneric.h:

Boilerplate to support creating the derived sources for MediaController and adding new sources
to the project:

CMakeLists.txt:
DerivedSources.cpp:
DerivedSources.make:
GNUmakefile.list.am:
WebCore.gypi:
WebCore.xcodeproj/project.pbxproj:

LayoutTests:

media/media-controller-expected.txt: Added.
media/media-controller-playback-expected.txt: Added.
media/media-controller-playback.html: Added.
media/media-controller.html: Added.
platform/mac/fast/dom/Window/window-properties-expected.txt:
platform/mac/fast/js/global-constructors-expected.txt:

9:44 AM Changeset in webkit [100158] by scherkus@chromium.org

4 edits in trunk

[Chromium] Skip media layout tests on chromium-gpu-cg-mac-leopard platform
https://bugs.webkit.org/show_bug.cgi?id=72147

Reviewed by Adam Barth.

Tools:

Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

LayoutTests:

platform/chromium/test_expectations.txt:

9:31 AM Changeset in webkit [100157] by commit-queue@webkit.org

6 edits
3 adds in trunk

Multiple foreign objects not rendered
https://bugs.webkit.org/show_bug.cgi?id=72151

Patch by Florin Malita <fmalita@google.com> on 2011-11-14
Reviewed by Adam Barth.

Source/WebCore:

SVG end tags need to be case-adjusted (just like their start counterparts).

Test: svg/foreignObject/multiple-foreign-objects.html

html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processEndTag):

LayoutTests:

html5lib/runner-expected.txt: Rebaselined.
platform/chromium/html5lib/runner-expected.txt: Rebaselined.
svg/custom/use-multiple-on-nested-disallowed-font-expected.txt: Rebaselined.
svg/foreignObject/multiple-foreign-objects-expected.png: Added.
svg/foreignObject/multiple-foreign-objects-expected.txt: Added.
svg/foreignObject/multiple-foreign-objects.html: Added.

9:29 AM Changeset in webkit [100156] by tonyg@chromium.org

2 edits in trunk/LayoutTests

Flaky Test: http/tests/inspector/resource-tree/resource-tree-frame-add.html
https://bugs.webkit.org/show_bug.cgi?id=59771

platform/chromium/test_expectations.txt: Expect test to flakily timeout.

9:16 AM Changeset in webkit [100155] by alexis.menard@openbossa.org

2 edits
10 moves
2 adds
7 deletes in trunk/Source/WebKit2

[Qt][WK2] Cleanup QML tests.
https://bugs.webkit.org/show_bug.cgi?id=72259

Reviewed by Simon Hausmann.

Cleanup QML tests. This patch removes the duplicates after the merge of both views.
I also isolated the desktop specific bits into its own directory.

UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_download.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_download.qml.
UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_linkHovered.qml.
UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_messaging.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_messaging.qml.
UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationPolicyForUrl.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_navigationPolicyForUrl.qml.
UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgressSignal.qml: Removed.
UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadZeroSizeView.qml: Removed.
UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_properties.qml: Removed.
UIProcess/API/qt/tests/qmltests/TouchWebView/tst_load.qml: Removed.
UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadFail.qml: Removed.
UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadNegativeSizeView.qml: Removed.
UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgress.qml: Removed.
UIProcess/API/qt/tests/qmltests/WebView/tst_loadFail.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadFail.qml.
UIProcess/API/qt/tests/qmltests/WebView/tst_loadProgress.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgress.qml.
UIProcess/API/qt/tests/qmltests/WebView/tst_loadProgressSignal.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgressSignal.qml.
UIProcess/API/qt/tests/qmltests/WebView/tst_loadZeroSizeView.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadZeroSizeView.qml.
UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_preferences.qml.
UIProcess/API/qt/tests/qmltests/WebView/tst_properties.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/TouchWebView/tst_properties.qml.
UIProcess/API/qt/tests/qmltests/qmltests.pro:

9:10 AM Changeset in webkit [100154] by Lucas Forschler

2 edits in branches/safari-534.52-branch/Source/WebCore

Merge r100022.

9:05 AM Changeset in webkit [100153] by mario@webkit.org

7 edits in trunk/Source

Add support for the caretBrowsingEnabled preference in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=72266

Reviewed by Chris Fleizach.

Source/WebCore:

WebCore.exp.in: Exported settings for setCaretBrowsingEnabled.

Source/WebKit2:

Shared/WebPreferencesStore.h: Add caretBrowsingEnabled getter

and setter macro.

UIProcess/API/C/WKPreferences.h:
UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetCaretBrowsingEnabled): Added.
(WKPreferencesGetCaretBrowsingEnabled): Added.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Update the
caretBrowsingEnabledKey preference.

9:01 AM Changeset in webkit [100152] by Patrick Gansterer

2 edits in trunk/Source/JavaScriptCore

[WIN] Remove dependency on pthread from FastMalloc
https://bugs.webkit.org/show_bug.cgi?id=72098

Reviewed by Adam Roben.

All pthread calls are already ported to native Windows calls.
Use the native version for all OS(WINDOWS) to remove the
runtime dependency on the pthread dll.

wtf/FastMalloc.cpp:

8:59 AM Changeset in webkit [100151] by tonyg@chromium.org

2 edits in trunk/LayoutTests

Tests occasionally report missing expectations
https://bugs.webkit.org/show_bug.cgi?id=72039

platform/chromium/test_expectations.txt: Expect test to flakily report missing expectations.

8:56 AM Changeset in webkit [100150] by Lucas Forschler

5 edits in branches/safari-534.52-branch/Source

Versioning.

8:52 AM Changeset in webkit [100149] by tonyg@chromium.org

2 edits in trunk/LayoutTests

media/track/track-webvtt-tc004-magic-header.html flakily times out
https://bugs.webkit.org/show_bug.cgi?id=72279

platform/chromium/test_expectations.txt: Expect test to flakily timeout.

8:45 AM Changeset in webkit [100148] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Remove expected crashes for skia-gpu canvas from test expectations
https://bugs.webkit.org/show_bug.cgi?id=72183

Patch by Brian Salomon <bsalomon@google.com> on 2011-11-14
Reviewed by Stephen White.

platform/chromium/test_expectations.txt:

8:41 AM Changeset in webkit [100147] by tonyg@chromium.org

2 edits in trunk/LayoutTests

Tests occasionally report missing expectations
https://bugs.webkit.org/show_bug.cgi?id=72039

platform/chromium/test_expectations.txt: Expect test to flakily report missing expectations.

8:30 AM Changeset in webkit [100146] by fsamuel@chromium.org

10 edits in trunk/Source

[chromium] Plumb through partial swap
https://bugs.webkit.org/show_bug.cgi?id=72028

Patch by Jonathan Backer <backer@chromium.org> on 2011-11-14
Reviewed by Kenneth Russell.

Source/WebCore:

platform/graphics/chromium/Extensions3DChromium.h:
platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):

platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::LayerRendererCapabilities::LayerRendererCapabilities):

Source/WebKit/chromium:

public/WebGraphicsContext3D.h:
src/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::postSubBufferCHROMIUM):

src/GraphicsContext3DChromium.cpp:
src/GraphicsContext3DPrivate.h:
tests/MockWebGraphicsContext3D.h:

(WebKit::MockWebGraphicsContext3D::postSubBufferCHROMIUM):

8:29 AM Changeset in webkit [100145] by caseq@chromium.org

16 edits
1 delete in trunk

Web Inspector: expose iframe window to the onShown event handler of panels & sidebars
https://bugs.webkit.org/show_bug.cgi?id=72268

Reviewed by Pavel Feldman.

Source/WebCore:

replace IFrameView with ExtensionView;
inherit both ExtensionPanel and ExtensionSidebarPane from ExtensionView in the API;
move Panel.{onShow|onHide} to ExtensionView, effectively disabling show/hide notifications for non-extension panels and enabling it for sidebar panes;
expose iframe's window object in the onShow event handler.

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/compile-front-end.sh:
inspector/front-end/ExtensionAPI.js:

(injectedExtensionAPI.ExtensionViewImpl.dispatchShowEvent):
(injectedExtensionAPI):
(injectedExtensionAPI.PanelWithSidebarImpl):
(injectedExtensionAPI.ExtensionPanelImpl):
(injectedExtensionAPI.ExtensionSidebarPaneImpl):

inspector/front-end/ExtensionPanel.js:

(WebInspector.ExtensionView):
(WebInspector.ExtensionView.prototype.wasShown):
(WebInspector.ExtensionView.prototype.willHide):
(WebInspector.ExtensionView.prototype._onLoad):
(WebInspector.ExtensionPanel):
(WebInspector.ExtensionSidebarPane.prototype.setPage):

inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype.notifyViewShown):
(WebInspector.ExtensionServer.prototype.notifyViewHidden):
(WebInspector.ExtensionServer.prototype._onCreatePanel):

inspector/front-end/IFrameView.js: Removed.
inspector/front-end/Panel.js:

(WebInspector.Panel.prototype.wasShown):
(WebInspector.Panel.prototype.willHide):

inspector/front-end/WebKit.qrc:
inspector/front-end/inspector.html:

LayoutTests:

inspector/extensions/extensions-api-expected.txt:
inspector/extensions/extensions-events-expected.txt:
inspector/extensions/extensions-events.html:
inspector/extensions/extensions-expected.txt:
platform/chromium/inspector/extensions/extensions-api-expected.txt:

8:22 AM Changeset in webkit [100144] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Unreviewed evening gardening. Try to make the bot green.

platform/qt/Skipped: Skip failing tets
- fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size.html because of missing D&D support
- fast/events/drag-text-with-clear.html because of missing D&D support
- http/tests/misc/xslt-bad-import.html because of https://bugs.webkit.org/show_bug.cgi?id=72252
- inspector/timeline and inspector/user-metrics.html because of https://bugs.webkit.org/show_bug.cgi?id=72274
- svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html because of https://bugs.webkit.org/show_bug.cgi?id=52810

7:56 AM Changeset in webkit [100143] by yurys@chromium.org

6 edits in trunk/Source/WebCore

Web Inspector: add 'Show function definition' context menu item for function values
https://bugs.webkit.org/show_bug.cgi?id=72265

Allow navigating to JavaScript function definition using context menu.

Reviewed by Pavel Feldman.

English.lproj/localizedStrings.js:
inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.rawLocationToUILocation):

inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.prototype.update):
(WebInspector.ObjectPropertyTreeElement.prototype._functionContextMenuEventFired):
(WebInspector.ObjectPropertyTreeElement.prototype._functionContextMenuEventFired.revealFunction):

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.showFunctionDefinition):

inspector/front-end/inspector.js:

(WebInspector.showPanelForAnchorNavigation):

7:44 AM Changeset in webkit [100142] by dmazzoni@google.com

2 edits in trunk/LayoutTests

Unreviewed: update platform/gtk/Skipped because a newly-added
failing test is due to general accessibility testing issues
on GTK, not due to this particular test.
https://bugs.webkit.org/show_bug.cgi?id=72249

7:33 AM Changeset in webkit [100141] by tonyg@chromium.org

2 edits in trunk/LayoutTests

[chromium] security/crypto-random-values-types.html is flaky on win
https://bugs.webkit.org/show_bug.cgi?id=72272

platform/chromium/test_expectations.txt: Mark test as flaky.

7:17 AM Changeset in webkit [100140] by tonyg@chromium.org

2 edits in trunk/LayoutTests

[chromium] Crash in webkit::npapi::PluginInstance::NPP_SetWindow
https://bugs.webkit.org/show_bug.cgi?id=72271

platform/chromium/test_expectations.txt: Expect test to crash sometimes.

6:58 AM UsingGitWithWebKit edited by Adam Roben

Added some tips for breaking up large patches (diff)

6:53 AM Changeset in webkit [100139] by tonyg@chromium.org

2 edits in trunk/LayoutTests

media/track/track-cues-cuechange.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=72269

platform/chromium/test_expectations.txt: Mark test as flaky.

6:29 AM Changeset in webkit [100138] by vsevik@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, unskipping passing test.

platform/chromium/test_expectations.txt:

6:14 AM Changeset in webkit [100137] by pfeldman@chromium.org

5 edits
2 adds in trunk

Web Inspector: console's protocol payload does not have url and line properties.
https://bugs.webkit.org/show_bug.cgi?id=72256

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/console/console-url-and-line.html

inspector/ConsoleMessage.cpp:

(WebCore::ConsoleMessage::ConsoleMessage):

inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl):

LayoutTests:

inspector/console/console-url-and-line-expected.txt: Added.
inspector/console/console-url-and-line.html: Added.
inspector/protocol/console-agent-expected.txt:

6:06 AM Changeset in webkit [100136] by tonyg@chromium.org

2 edits in trunk/LayoutTests

[chromium] Two inspector tests timeout on mac
https://bugs.webkit.org/show_bug.cgi?id=72264

platform/chromium/test_expectations.txt: Expect appcache-iframe-manifests and script-formatter to timeout on mac.

6:03 AM Changeset in webkit [100135] by pfeldman@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: [regression r99960] null callback access.
https://bugs.webkit.org/show_bug.cgi?id=72263

Reviewed by Yury Semikhatsky.

inspector/CodeGeneratorInspector.py:

5:19 AM Changeset in webkit [100134] by vestbo@webkit.org

3 edits in trunk/Source/WebCore

[Qt] Unbreak the build on Mac OS X

QMacStyle is guarded by Q_WS_MAC, which is not the case for QPA. Until
that's been fixed in Qt we have to use the same guards in WebKit, not
Q_OS_MAC.

5:19 AM Changeset in webkit [100133] by vestbo@webkit.org

4 edits
1 move
1 add in trunk

[Qt] Move the QtWebKit module file to match the layout of Qt's mkspecs

Reviewed by Simon Hausmann.

5:06 AM Changeset in webkit [100132] by Simon Hausmann

2 edits in trunk/Tools

[Qt] Disable plugins on X11 for WK2

Reviewed by Kenneth Rohde Christiansen.

Currently plugins are in-process and they crash in the likely case of
a plugin installation that uses Qt 4, which beautifully clashes with the
Qt 5 based QtWebProcess.

qmake/mkspecs/features/features.prf:

5:01 AM Changeset in webkit [100131] by Simon Hausmann

4 edits in trunk/Source

[Qt] Replace use of QApplication with QGuiApplication.

Reviewed by Tor Arne Vestbø.

Source/JavaScriptCore:

wtf/qt/compat/qguiapplication.h:

(QGuiApplication::styleHints): Introduce styleHints wrapper hack.

Source/WebCore:

Replace use of QApplication by QGuiApplication where applicable.

platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::RenderThemeQt):
(WebCore::RenderThemeQt::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeQt::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeQt::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeQt::platformInactiveSelectionForegroundColor):
(WebCore::RenderThemeQt::platformFocusRingColor):
(WebCore::RenderThemeQt::systemColor):
(WebCore::RenderThemeQt::minimumMenuListSize):
(WebCore::RenderThemeQt::getMediaControlForegroundColor):
(WebCore::RenderThemeQt::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeQt::caretBlinkInterval):

4:58 AM Changeset in webkit [100130] by vestbo@webkit.org

4 edits
2 adds in trunk/Tools

[Qt] Add support for config tests for Qt 5

This allows us to build and run configure-tests at build
time to determine if a given platform feature is available.

Reviewed by Simon Hausmann.

4:46 AM Changeset in webkit [100129] by caio.oliveira@openbossa.org

3 edits in trunk/Source/WebKit2

[Qt] Remove reference to QWebNavigationController
https://bugs.webkit.org/show_bug.cgi?id=72257

Reviewed by Simon Hausmann.

QWebNavigationController was removed in r99946, this is just a leftover.

UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):

UIProcess/API/qt/qquickwebview_p.h:

4:44 AM Changeset in webkit [100128] by tonyg@chromium.org

2 edits in trunk/LayoutTests

Tests occasionally report missing expectations
https://bugs.webkit.org/show_bug.cgi?id=72039

platform/chromium/test_expectations.txt: Expect form-associated-element-crash3 to flakily go MISSING.

4:41 AM Changeset in webkit [100127] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Fix incorrect usage of ASSERT in CCLayerTreeHostTest
https://bugs.webkit.org/show_bug.cgi?id=72026

ASSERT is stripped out in release builds so it shouldn't be used
in unit tests, except when calling debug-only functions like
isMainThread().

Replacing with ASSERT_TRUE (or EXPECT_TRUE in constructors, where
we can't return a value).

Patch by Iain Merrick <husky@google.com> on 2011-11-14
Reviewed by Tony Gentilcore.

tests/CCLayerTreeHostTest.cpp:

(WTF::MockLayerTreeHost::MockLayerTreeHost):
(WTF::CCLayerTreeHostTest::onEndTest):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsCommit):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsRedraw):
(WTF::CCLayerTreeHostTest::runTest):
(WTF::CCLayerTreeHostTest::doBeginTest):

4:20 AM Changeset in webkit [100126] by commit-queue@webkit.org

1 edit
1 add in trunk/Source/WebCore

[CMAKE] Add the UseV8.cmake to WebCore.
https://bugs.webkit.org/show_bug.cgi?id=72000

Patch by Jaehoon Jeong <jh4u.jeong@samsung.com> on 2011-11-14
Reviewed by Daniel Bates.

Add the UseV8.cmake to WebCore to build bindings of V8 and
generate JavaScript codes given IDL input.

UseV8.cmake: Added.

3:55 AM Changeset in webkit [100125] by kenneth@webkit.org

6 edits in trunk/Source/WebKit2

[Qt] the QQuickWebView should support double-tap to zoom
https://bugs.webkit.org/show_bug.cgi?id=72030

Reviewed by Andreas Kling.

UIProcess/qt/QtViewInterface.cpp:
UIProcess/qt/QtViewInterface.h:
UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::animateItemRectVisible):
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):

UIProcess/qt/QtViewportInteractionEngine.h:
UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::didFindZoomableArea):

3:52 AM Changeset in webkit [100124] by vsevik@chromium.org

4 edits in trunk/LayoutTests

http/tests/inspector/resource-tree/appcache-iframe-manifests.html failing on some chromium bots after r99988
https://bugs.webkit.org/show_bug.cgi?id=72177

Reviewed by Tony Gentilcore.

Added waitForFrameManifestURLAndStatus() call for the second frame
with manifestId=1, fixed sort functions in appcache-test.js

http/tests/inspector/resource-tree/appcache-iframe-manifests.html:
http/tests/inspector/resource-tree/appcache-test.js:

(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel.compareFunc):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheStatusesRecords.compareFunc):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheStatusesRecords):
(initialize_ApplicationCacheTest):

platform/chromium/test_expectations.txt:

3:49 AM Changeset in webkit [100123] by Simon Hausmann

14 edits
4 adds
2 deletes in trunk

[Qt] Remove the QStyle dependency in Qt's mobile theme https://bugs.webkit.org/show_bug.cgi?id=67773

This refactoring splits up RenderThemeQt with two
subclasses, a QStyle-backed one, and a Mobile version
that uses the old mobile theme for now.

QStyle availability is detected at compile time, and
its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
environment variable.

Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2011-11-11
Reviewed by Simon Hausmann.

Source/WebCore:

Covered by the existing tests.

Target.pri:
platform/qt/QtMobileWebStyle.cpp: Removed. The relevant logic

now lives within RenderThemeQtMobile.

platform/qt/QtMobileWebStyle.h: Removed. Ditto.
platform/qt/RenderThemeQStyle.cpp: Added.

(WebCore::initStyleOption):
(WebCore::RenderThemeQStyle::getStylePainter):
(WebCore::StylePainterQStyle::StylePainterQStyle):
(WebCore::StylePainterQStyle::init):
(WebCore::RenderThemeQStyle::create):
(WebCore::RenderThemeQStyle::RenderThemeQStyle):
(WebCore::RenderThemeQStyle::~RenderThemeQStyle):
(WebCore::RenderThemeQStyle::fallbackStyle):
(WebCore::RenderThemeQStyle::qStyle):
(WebCore::RenderThemeQStyle::findFrameLineWidth):
(WebCore::RenderThemeQStyle::inflateButtonRect):
(WebCore::RenderThemeQStyle::computeSizeBasedOnStyle):
(WebCore::RenderThemeQStyle::adjustButtonStyle):
(WebCore::RenderThemeQStyle::setButtonPadding):
(WebCore::RenderThemeQStyle::paintButton):
(WebCore::RenderThemeQStyle::adjustTextFieldStyle):
(WebCore::RenderThemeQStyle::paintTextField):
(WebCore::RenderThemeQStyle::adjustTextAreaStyle):
(WebCore::RenderThemeQStyle::paintTextArea):
(WebCore::RenderThemeQStyle::setPopupPadding):
(WebCore::RenderThemeQStyle::paintMenuList):
(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
(WebCore::RenderThemeQStyle::paintMenuListButton):
(WebCore::RenderThemeQStyle::animationDurationForProgressBar):
(WebCore::RenderThemeQStyle::paintProgressBar):
(WebCore::RenderThemeQStyle::paintSliderTrack):
(WebCore::RenderThemeQStyle::adjustSliderTrackStyle):
(WebCore::RenderThemeQStyle::paintSliderThumb):
(WebCore::RenderThemeQStyle::adjustSliderThumbStyle):
(WebCore::RenderThemeQStyle::paintSearchField):
(WebCore::RenderThemeQStyle::adjustSearchFieldStyle):
(WebCore::RenderThemeQStyle::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldDecoration):
(WebCore::RenderThemeQStyle::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeQStyle::paintInnerSpinButton):
(WebCore::RenderThemeQStyle::initializeCommonQStyleOptions):
(WebCore::RenderThemeQStyle::adjustSliderThumbSize):

platform/qt/RenderThemeQStyle.h: Added.

(WebCore::StylePainterQStyle::isValid):
(WebCore::StylePainterQStyle::drawPrimitive):
(WebCore::StylePainterQStyle::drawControl):
(WebCore::StylePainterQStyle::drawComplexControl):

platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::RenderThemeQt):
(WebCore::RenderThemeQt::isControlStyled):
(WebCore::RenderThemeQt::inflateButtonRect):
(WebCore::RenderThemeQt::adjustRepaintRect):
(WebCore::RenderThemeQt::minimumMenuListSize):
(WebCore::RenderThemeQt::adjustTextFieldStyle):
(WebCore::RenderThemeQt::adjustMenuListStyle):
(WebCore::RenderThemeQt::adjustMenuListButtonStyle):
(WebCore::RenderThemeQt::adjustProgressBarStyle):
(WebCore::RenderThemeQt::paintSearchFieldCancelButton):
(WebCore::RenderThemeQt::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQt::paintMediaFullscreenButton):
(WebCore::RenderThemeQt::paintMediaMuteButton):
(WebCore::RenderThemeQt::paintMediaPlayButton):
(WebCore::RenderThemeQt::paintMediaCurrentTime):
(WebCore::RenderThemeQt::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeQt::paintMediaVolumeSliderThumb):
(WebCore::RenderThemeQt::paintMediaSliderTrack):
(WebCore::RenderThemeQt::paintMediaSliderThumb):
(WebCore::RenderThemeQt::adjustSliderThumbSize):
(WebCore::RenderThemeQt::caretBlinkInterval):
(WebCore::RenderThemeQt::fileListNameForWidth):
(WebCore::StylePainter::StylePainter):
(WebCore::StylePainter::init):
(WebCore::StylePainter::~StylePainter):

platform/qt/RenderThemeQt.h:

(WebCore::RenderThemeQt::useMobileTheme):
(WebCore::StylePainter::isValid):

platform/qt/RenderThemeQtMobile.cpp: Added.

(WebCore::drawRectangularControlBackground):
(WebCore::RenderThemeQtMobile::getStylePainter):
(WebCore::StylePainterMobile::StylePainterMobile):
(WebCore::StylePainterMobile::drawChecker):
(WebCore::StylePainterMobile::findChecker):
(WebCore::StylePainterMobile::drawRadio):
(WebCore::StylePainterMobile::findRadio):
(WebCore::StylePainterMobile::drawMultipleComboButton):
(WebCore::StylePainterMobile::drawSimpleComboButton):
(WebCore::StylePainterMobile::getButtonImageSize):
(WebCore::StylePainterMobile::findComboButton):
(WebCore::StylePainterMobile::drawLineEdit):
(WebCore::StylePainterMobile::drawCheckBox):
(WebCore::StylePainterMobile::drawRadioButton):
(WebCore::StylePainterMobile::drawPushButton):
(WebCore::StylePainterMobile::drawComboBox):
(WebCore::RenderThemeQtMobile::create):
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeQtMobile::RenderThemeQtMobile):
(WebCore::RenderThemeQtMobile::~RenderThemeQtMobile):
(WebCore::RenderThemeQtMobile::isControlStyled):
(WebCore::RenderThemeQtMobile::popupInternalPaddingBottom):
(WebCore::RenderThemeQtMobile::computeSizeBasedOnStyle):
(WebCore::RenderThemeQtMobile::adjustButtonStyle):
(WebCore::RenderThemeQtMobile::setButtonPadding):
(WebCore::RenderThemeQtMobile::paintButton):
(WebCore::RenderThemeQtMobile::adjustTextFieldStyle):
(WebCore::RenderThemeQtMobile::paintTextField):
(WebCore::RenderThemeQtMobile::adjustMenuListStyle):
(WebCore::RenderThemeQtMobile::setPopupPadding):
(WebCore::RenderThemeQtMobile::paintMenuList):
(WebCore::RenderThemeQtMobile::paintMenuListButton):
(WebCore::RenderThemeQtMobile::animationDurationForProgressBar):
(WebCore::RenderThemeQtMobile::paintProgressBar):
(WebCore::RenderThemeQtMobile::paintSliderTrack):
(WebCore::RenderThemeQtMobile::paintSliderThumb):
(WebCore::RenderThemeQtMobile::checkMultiple):
(WebCore::RenderThemeQtMobile::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQtMobile::adjustSliderThumbSize):

platform/qt/RenderThemeQtMobile.h: Added.
platform/qt/ScrollbarThemeQt.cpp:

(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::ScrollbarThemeQt::paint):
(WebCore::ScrollbarThemeQt::scrollbarThickness):
(WebCore::ScrollbarThemeQt::paintScrollCorner):

Source/WebKit/qt:

Api/qwebpage.cpp:

(QWebPage::swallowContextMenuEvent):

tests/tests.pri:

Tools:

WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:

(WTR::activateFonts):

qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,

based on availability of QtWidgets.

qmake/mkspecs/features/webcore.prf: cleanup.

3:49 AM Changeset in webkit [100122] by apavlov@chromium.org

2 edits in trunk/Source/WebKit/chromium

[chromium] r99963 causes inspector/debugger/script-formatter.html to fail text diff
https://bugs.webkit.org/show_bug.cgi?id=72204

The concatenate_script_formatter_worker_js action (along with concatenate_heap_snapshot_worker_js)
did not depend on their 'input_file' files and, hence, did not get invoked on their input_file changes.

Reviewed by Yury Semikhatsky.

WebKit.gyp:

3:24 AM Changeset in webkit [100121] by ryuan.choi@samsung.com

2 edits in trunk/Source/WebKit/gtk

[GTK] Possible crash when destroying after called widgetSizeChanged.
https://bugs.webkit.org/show_bug.cgi?id=72237

Reviewed by Martin Robinson.

Crash can occur when ChromeclientGtk is removed before calling repaintEverythingSoonTimeout
registered by widgetSizeChanged.
This patch remove the m_repaintSoonSourceId glib source before destruction
of the ChromeClientGtk to prevent the above crash.

WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::chromeDestroyed):

3:15 AM Changeset in webkit [100120] by tonyg@chromium.org

2 edits in trunk/LayoutTests

ASSERTION FAILED: fontCache()->generation() == m_generation (running new-run-webkit-tests)
https://bugs.webkit.org/show_bug.cgi?id=59552

platform/chromium/test_expectations.txt: Expect cross-frame-access-custom.html to CRASH or PASS.

2:53 AM Changeset in webkit [100119] by tonyg@chromium.org

2 edits in trunk/Tools

Unreviewed, rolling out r100116.
http://trac.webkit.org/changeset/100116

r100104 was rolled out, so no longer needed

Scripts/run-bindings-tests:

2:48 AM Changeset in webkit [100118] by tonyg@chromium.org

18 edits in trunk/Tools

Unreviewed, rolling out r100104.
http://trac.webkit.org/changeset/100104
https://bugs.webkit.org/show_bug.cgi?id=72247

broke windows builds

Scripts/check-webkit-style:
Scripts/webkitpy/common/checkout/checkout_unittest.py:
Scripts/webkitpy/common/checkout/deps.py:
Scripts/webkitpy/common/checkout/scm/init.py:
Scripts/webkitpy/common/checkout/scm/detection.py:
Scripts/webkitpy/common/checkout/scm/git.py:
Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
Scripts/webkitpy/common/checkout/scm/svn.py:
Scripts/webkitpy/common/host.py:
Scripts/webkitpy/common/host_mock.py:
Scripts/webkitpy/layout_tests/controllers/manager.py:
Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
Scripts/webkitpy/layout_tests/port/base.py:
Scripts/webkitpy/layout_tests/port/mock_drt.py:
Scripts/webkitpy/layout_tests/run_webkit_tests.py:
Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
Scripts/webkitpy/tool/servers/rebaselineserver.py:

2:26 AM Changeset in webkit [100117] by abarth@webkit.org

4 edits in trunk/Source/WebCore

SecurityContext should track whether the SecurityOrigin has been initialized
https://bugs.webkit.org/show_bug.cgi?id=72250

Reviewed by Eric Seidel.

This patch is another step towards https://bugs.webkit.org/show_bug.cgi?id=71745.

One of the things we use "empty" SecurityOrigins for is detecting
whether a Document's SecurityOrigin has been initialized. In this
patch, we track that state directly on SecurityContext (which is a base
class of Document), moving us closer to removing the concept of an
empty SecurityOrigin.

dom/Document.cpp:

(WebCore::Document::initSecurityContext):

dom/SecurityContext.cpp:

(WebCore::SecurityContext::SecurityContext):
(WebCore::SecurityContext::setSecurityOrigin):

dom/SecurityContext.h:

(WebCore::SecurityContext::didFailToInitializeSecurityOrigin):
(WebCore::SecurityContext::haveInitializedSecurityOrigin):

2:00 AM Changeset in webkit [100116] by Philippe Normand

2 edits in trunk/Tools

Unreviewed, build fix after r100104. run-binding-tests broke.

Scripts/run-bindings-tests: Explicitely use scm.detection.

1:50 AM Changeset in webkit [100115] by Carlos Garcia Campos

4 edits in trunk/Source

Unreviewed. Fix make distcheck build.

Source/JavaScriptCore:

GNUmakefile.list.am: Add missing files.

Source/WebCore:

GNUmakefile.list.am: Add missing files.

1:40 AM Changeset in webkit [100114] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Web Inspector: Give HTML ContextMenu a more Native look
https://bugs.webkit.org/show_bug.cgi?id=72207

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2011-11-14
Reviewed by Pavel Feldman.

inspector/front-end/SoftContextMenu.js:

(.WebInspector.SoftContextMenu.prototype._createMenuItem):
Give the checkmark a class name so that it can be styled more
with CSS instead of with JavaScript.

inspector/front-end/inspector.css:

(.soft-context-menu): tweak the border and shadow.
(.soft-context-menu-item): tweak the font size and positioning.
(.soft-context-menu-separator): tweak the whitespace.
(.soft-context-menu-item-mouse-over): solid blue for non-mac platforms.
(body.platform-mac .soft-context-menu-item-mouse-over): gradient for mac platforms.
(.soft-context-menu-item-checkmark): gray color normally.
(.soft-context-menu-item-mouse-over .soft-context-menu-item-checkmark): white on hover.

1:27 AM Changeset in webkit [100113] by yurys@chromium.org

16 edits
3 adds in trunk

Web Inspector: function remote objetct should provide access to function position in the script
https://bugs.webkit.org/show_bug.cgi?id=71808

Source/JavaScriptCore:

Exposed accessor for function source code.

Reviewed by Pavel Feldman.

JavaScriptCore.exp:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
runtime/JSFunction.cpp:

(JSC::JSFunction::sourceCode):

runtime/JSFunction.h:

Source/WebCore:

Added Debugger.getFunctionLocation command for resolving function location including
start line, column and script id.

Reviewed by Pavel Feldman.

Test: inspector/debugger/function-location.html

bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::functionLocation):

bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::functionLocationCallback):

inspector/InjectedScript.cpp:

(WebCore::InjectedScript::getFunctionLocation):

inspector/InjectedScript.h:
inspector/InjectedScriptHost.idl:
inspector/InjectedScriptSource.js:

(.):

inspector/Inspector.json:
inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::getFunctionLocation):

inspector/InspectorDebuggerAgent.h:

LayoutTests:

Added test for Debugger.getFunctionLocation command.

Reviewed by Pavel Feldman.

inspector/debugger/function-location-expected.txt: Added.
inspector/debugger/function-location.html: Added.
platform/chromium/inspector/debugger/function-location-expected.txt: Added.

1:25 AM Changeset in webkit [100112] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r100050
https://bugs.webkit.org/show_bug.cgi?id=72251

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-11-14

platform/qt/Skipped: editing/spelling/spelling-unified-emulation.html

1:18 AM Changeset in webkit [100111] by commit-queue@webkit.org

3 edits
2 adds in trunk

Cannot select multiple options by mouse dragging in <select multiple="multiple" size="7"> list
https://bugs.webkit.org/show_bug.cgi?id=70496

Patch by Rakesh KN <rakesh.kn@motorola.com> on 2011-11-14
Reviewed by Kent Tamura.

Source/WebCore:

Select Multiple options in a select element with a mouse drag when no. of options
are less than the no. specified in size attribute.
Other browsers(IE, Opera, Firefox) support this feature

Test: fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size.html

html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
Handled mouse move event with Left button pressed. We select the options under mouse
when mouse drag happens and the select element cannot autoscroll.

LayoutTests:

Select Multiple options in a select element with a mouse drag when no. of options
are less than the no. specified in size attribute.
Other browsers(IE, Opera, Firefox) support this feature.

fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size-expected.txt: Added.
fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size.html: Added.

1:16 AM Changeset in webkit [100110] by yurys@chromium.org

6 edits
3 adds in trunk

Web Inspector: [chromium] list dedicated workers in case inspector opened post-worker creation.
https://bugs.webkit.org/show_bug.cgi?id=72020

Source/WebCore:

Collect information about dedicated workers even when inspector is closed. This
way we can list all dedicated workers if the front-end opens later.

Reviewed by Pavel Feldman.

Test: http/tests/inspector-enabled/dedicated-workers-list.html

inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didStartWorkerContext):

inspector/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::~InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::setFrontend):
(WebCore::InspectorWorkerAgent::restore):
(WebCore::InspectorWorkerAgent::clearFrontend):
(WebCore::InspectorWorkerAgent::setWorkerInspectionEnabled):
(WebCore::InspectorWorkerAgent::didStartWorkerContext):
(WebCore::InspectorWorkerAgent::workerContextTerminated):
(WebCore::InspectorWorkerAgent::createWorkerFrontendChannelsForExistingWorkers):
(WebCore::InspectorWorkerAgent::destroyWorkerFrontendChannels):
(WebCore::InspectorWorkerAgent::createWorkerFrontendChannel):

inspector/InspectorWorkerAgent.h:

LayoutTests:

Reviewed by Pavel Feldman.

http/tests/inspector-enabled/dedicated-workers-list-expected.txt: Added.
http/tests/inspector-enabled/dedicated-workers-list.html: Added.
http/tests/inspector-enabled/resources/dedicated-worker.js: Added.

(doWork):

1:14 AM Changeset in webkit [100109] by commit-queue@webkit.org

5 edits in trunk/Source

Build breaks with --no-javascript-debugger --no-inspector
https://bugs.webkit.org/show_bug.cgi?id=72228

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2011-11-14
Reviewed by Simon Hausmann.

Source/WebCore:

workers/WorkerMessagingProxy.cpp:

(WebCore::PostMessageToPageInspectorTask::performTask):
(WebCore::WorkerMessagingProxy::connectToInspector):

workers/WorkerThread.cpp:

(WebCore::WorkerThread::workerThread):

Source/WebKit2:

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):

12:27 AM Changeset in webkit [100108] by haraken@chromium.org

16 edits
1 delete in trunk/Source/WebCore

Remove all custom constructors of Events in V8
https://bugs.webkit.org/show_bug.cgi?id=72074

Reviewed by Adam Barth.

V8 has [ConstructorTemplate=Event] IDL, which generates
Event constructors. This patch removes all the custom constructors
in V8EventConstructors.cpp and generates them using
[ConstructorTemplate=Event] IDL.

Tests: fast/events/constructors/before-load-event-constructor.html

fast/events/constructors/close-event-constructor.html
fast/events/constructors/custom-event-constructor.html
fast/events/constructors/error-event-constructor.html
fast/events/constructors/event-constructors.html
fast/events/constructors/hash-change-event-constructor.html
fast/events/constructors/message-event-constructor.html
fast/events/constructors/overflow-event-constructor.html
fast/events/constructors/page-transition-event-constructor.html
fast/events/constructors/pop-state-event-constructor.html
fast/events/constructors/progress-event-constructor.html
fast/events/constructors/track-event-constructor.html
fast/events/constructors/webkit-animation-event-constructor.html
fast/events/constructors/webkit-transition-event-constructor.html

Target.pri: Removed V8EventConstructors.cpp.
WebCore.gypi: Ditto.
bindings/v8/custom/V8EventConstructors.cpp: Removed.
dom/BeforeLoadEvent.idl: Replaced [V8CustomConstructor] with [V8ConstructorTemplate=Event]. Added [InitializedByConstructor] IDL to attributes that can be initialized by the generated constructor.
dom/CustomEvent.idl: Ditto.
dom/ErrorEvent.idl: Ditto.
dom/HashChangeEvent.idl: Ditto.
dom/MessageEvent.idl: Ditto.
dom/OverflowEvent.idl: Ditto.
dom/PageTransitionEvent.idl: Ditto.
dom/PopStateEvent.idl: Ditto.
dom/ProgressEvent.idl: Ditto.
dom/WebKitAnimationEvent.idl: Ditto.
dom/WebKitTransitionEvent.idl: Ditto.
html/track/TrackEvent.idl: Ditto.
websockets/CloseEvent.idl: Ditto.

12:23 AM BuildingQtOnLinux edited by Csaba Osztrogonác

(diff)

12:20 AM Changeset in webkit [100107] by Philippe Normand

1 edit
2 adds in trunk/LayoutTests

Unreviewed, GTK baselines for 2 new svg tests.

platform/gtk/svg/repaint/filter-child-repaint-expected.txt: Added.
platform/gtk/svg/zoom/page/zoom-svg-as-object-expected.txt: Added.

12:16 AM Changeset in webkit [100106] by Patrick Gansterer

2 edits in trunk/Source/WebCore

[WX] Make FontPlatformData::m_size private
https://bugs.webkit.org/show_bug.cgi?id=72214

Reviewed by Andreas Kling.

Also change the order of member variables to match
the order in the constructor to fix many warnings.

platform/graphics/wx/FontPlatformData.h:

12:15 AM Changeset in webkit [100105] by Philippe Normand

2 edits in trunk/LayoutTests

Unreviewed, skip 2 tests failing on GTK and 2 flaky crashers.

platform/gtk/Skipped:

12:07 AM Changeset in webkit [100104] by eric@webkit.org

18 edits in trunk/Tools

Add SCMDetector object to make scm detection mockable
https://bugs.webkit.org/show_bug.cgi?id=72247

Reviewed by Adam Barth.

I think SCM detection may eventually be rolled into Checkout,
but this patch at least makes it possible to mock code-paths
which rely on scm detection.
In the process of replacing callers of these free-functions
I found that one of the functions was no longer used,
and that one of the callers could instead just use the SCM
object it already had access to through port.host.scm().
I also discovered that I was not calling Host._initialize_scm()
and thus host.scm() was always returning None!

Scripts/check-webkit-style:
Scripts/webkitpy/common/checkout/checkout_unittest.py:
Scripts/webkitpy/common/checkout/deps.py:
Scripts/webkitpy/common/checkout/scm/init.py:
Scripts/webkitpy/common/checkout/scm/detection.py:
Scripts/webkitpy/common/checkout/scm/git.py:
Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
Scripts/webkitpy/common/checkout/scm/svn.py:
Scripts/webkitpy/common/host.py:
Scripts/webkitpy/common/host_mock.py:
Scripts/webkitpy/layout_tests/controllers/manager.py:
Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
Scripts/webkitpy/layout_tests/port/base.py:
Scripts/webkitpy/layout_tests/port/mock_drt.py:
Scripts/webkitpy/layout_tests/run_webkit_tests.py:
Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
Scripts/webkitpy/tool/servers/rebaselineserver.py:

Nov 13, 2011:

11:57 PM Changeset in webkit [100103] by Csaba Osztrogonác

1 edit
9 adds in trunk/LayoutTests

[Qt] Unreviewed gardening after r100036.

platform/qt/svg/foreignObject/clip-expected.png: Added.
platform/qt/svg/foreignObject/clip-expected.txt: Added.
platform/qt/svg/foreignObject/filter-expected.png: Added.
platform/qt/svg/foreignObject/filter-expected.txt: Added.
platform/qt/svg/foreignObject/mask-expected.png: Added.
platform/qt/svg/foreignObject/mask-expected.txt: Added.
platform/qt/svg/repaint/filter-child-repaint-expected.png: Added.
platform/qt/svg/repaint/filter-child-repaint-expected.txt: Added.

11:57 PM Changeset in webkit [100102] by abarth@webkit.org

2 edits in trunk/Source/WebCore

Document::initSecurityOrigin should return earlier more often
https://bugs.webkit.org/show_bug.cgi?id=72244

Reviewed by Eric Seidel.

This minor tweak was suggested by Darin to make the subsequent patches
easier to read.

dom/Document.cpp:

(WebCore::Document::initSecurityContext):

11:53 PM Changeset in webkit [100101] by abarth@webkit.org

2 edits in trunk/Source/WebCore

SecurityPolicy should refer to isUnique rather than isEmpty
https://bugs.webkit.org/show_bug.cgi?id=72242

Reviewed by Eric Seidel.

It doesn't make sense to tweak the security policy for unique origins
because they're different every time. Previously, this code checked
for empty origins, which are technically a subset of unique origins. I
don't think it's possible to call this code in a way that can detect
the difference, but we're eventually going to remove the isEmpty
function.

page/SecurityPolicy.cpp:

(WebCore::SecurityPolicy::addOriginAccessWhitelistEntry):
(WebCore::SecurityPolicy::removeOriginAccessWhitelistEntry):

11:50 PM Changeset in webkit [100100] by abarth@webkit.org

7 edits in trunk/Source/WebCore

Move isSecureTransitionTo from SecurityOrigin to SecurityContext
https://bugs.webkit.org/show_bug.cgi?id=72241

Reviewed by Eric Seidel.

This patch is a step towards breaking the patch for
https://bugs.webkit.org/show_bug.cgi?id=71745 up into tiny,
digestible pieces.

dom/SecurityContext.cpp:

(WebCore::SecurityContext::isSecureTransitionTo):

dom/SecurityContext.h:
loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::begin):

loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopLoading):

page/SecurityOrigin.cpp:
page/SecurityOrigin.h:

9:14 PM Changeset in webkit [100099] by nduca@chromium.org

5 edits in trunk/Source

[chromium] LayerRendererChromium::initialize should fail when GaphicsContext3D::makeCurrent fails
https://bugs.webkit.org/show_bug.cgi?id=72102

Reviewed by James Robinson.

Source/WebCore:

platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::releaseRenderSurfaceTextures):
(WebCore::LayerRendererChromium::makeContextCurrent):

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::initializeLayerRendererOnImplThread):

Source/WebKit/chromium:

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

7:06 PM Changeset in webkit [100098] by tkent@chromium.org

3 edits in trunk/Source/WebKit/chromium

[Chromium] Remove WebFileChooserParams::acceptTypes
https://bugs.webkit.org/show_bug.cgi?id=71998

Reviewed by Darin Fisher.

public/WebFileChooserParams.h: Remove acceptTypes.
src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::runOpenPanel): Remove acceptTypes generatio code.

4:02 PM Changeset in webkit [100097] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/efl

[EFL] Improve the documentation of ewk_view_setting_local_storage_*.
https://bugs.webkit.org/show_bug.cgi?id=72135

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-13
Reviewed by Kenneth Rohde Christiansen.

Add some "see also" pointers, mention the default paths used for local
storage and document how things will not be persisted to disk if a
storage path is not set.

ewk/ewk_view.h:

3:03 PM Changeset in webkit [100096] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/efl

[EFL] Simplify eina_stringshare usage in ewk_settings.
https://bugs.webkit.org/show_bug.cgi?id=72127

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-13
Reviewed by Kenneth Rohde Christiansen.

Actually use the eina_stringshare functions in a sane way.

ewk/ewk_settings.cpp:

(ewk_settings_web_database_path_set): Just use
eina_stringshare_replace instead of doing needless checks and using
eina_stringshare_add.
(ewk_settings_cache_directory_path_set): Ditto.
(ewk_settings_icon_database_path_set): Ditto and always call
eina_stringshare_del, as passing NULL to it is just a NOP.

2:44 PM Changeset in webkit [100095] by yuqiang.xian@intel.com

2 edits in trunk/Source/JavaScriptCore

Fix silent spilling/filling GPRs in DFG 32_64
https://bugs.webkit.org/show_bug.cgi?id=72201

Reviewed by Gavin Barraclough.

Current silentSpillGPR/silentFillGPR may not work as expected for some
cases in 32_64. If there's a JSValue which was retained by two GPRs,
we may end up failing to spill/fill some GPRs or redundantly
spilling/filling some GPRs. For example, if we tend to exclude "eax"
from spilling while a JSValue is retained by both "eax" and "edx",
then "edx" won't be spilled as well (wrong). And if another JSValue is
retained by "ecx" and "ebx", both "ecx" and "ebx" will be spilled
twice. The similar problem applies to silentFillGPR.
The fix is to make silentSpillGPR/silentFillGPR more straightforward,
i.e., spilling/filling based on the GPR instead of the virtual
register. FPR spilling/filling is also modified accordingly to make it
consistent with GPR spilling/filling.

dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::silentSpillGPR):
(JSC::DFG::JITCodeGenerator::silentSpillFPR):
(JSC::DFG::JITCodeGenerator::silentFillGPR):
(JSC::DFG::JITCodeGenerator::silentFillFPR):
(JSC::DFG::JITCodeGenerator::silentSpillAllRegisters):
(JSC::DFG::JITCodeGenerator::silentFillAllRegisters):

1:30 PM Changeset in webkit [100094] by gavinp@chromium.org

2 edits in trunk/Tools

command line control of webcore log channels in chromium DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=72126

The option --webcore-log-channels=<foo>,<bar>,<quux> is the same as
what chromium takes.

Reviewed by Kent Tamura.

DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

1:05 PM Changeset in webkit [100093] by scheib@chromium.org

3 edits in trunk/Source/WebCore

Mouse Lock: MouseEvent IDL
https://bugs.webkit.org/show_bug.cgi?id=72158

Reviewed by Dimitri Glazkov.

Tests for movementX/Y pending mock mouse lock test infrastructure.

dom/MouseEvent.idl:
dom/MouseRelatedEvent.h:

(WebCore::MouseRelatedEvent::movementX):
(WebCore::MouseRelatedEvent::movementY):

9:43 AM Changeset in webkit [100092] by jchaffraix@webkit.org

3 edits
2 adds in trunk

REGRESSION(99849): NULL-deref in updateLastMediaLine when parsing some media-queries
https://bugs.webkit.org/show_bug.cgi?id=72222

Reviewed by Pavel Feldman.

Source/WebCore:

Test: fast/media/update-media-query-css-parser.html

css/CSSGrammar.y: Added a proper NULL-check.

LayoutTests:

fast/media/update-media-query-css-parser-expected.txt: Added.
fast/media/update-media-query-css-parser.html: Added.

7:26 AM Changeset in webkit [100091] by scheib@chromium.org

6 edits
3 adds in trunk/Source/WebCore

Mouse Lock Navigator IDL
https://bugs.webkit.org/show_bug.cgi?id=72150

Reviewed by Dimitri Glazkov.

Tests require mocking (similar to geolocation) that will be built after this.

WebCore.gypi:
bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitPointerEnabled):

page/MouseLockable.cpp: Added.

(WebCore::MouseLockable::MouseLockable):
(WebCore::MouseLockable::~MouseLockable):
(WebCore::MouseLockable::webkitLock):
(WebCore::MouseLockable::webkitUnlock):
(WebCore::MouseLockable::webkitIsLocked):

page/MouseLockable.h: Added.

(WebCore::MouseLockable::create):

page/MouseLockable.idl: Added.
page/Navigator.cpp:

(WebCore::Navigator::webkitPointer):

page/Navigator.h:
page/Navigator.idl:

6:53 AM Changeset in webkit [100090] by andreas.kling@nokia.com

7 edits in trunk/Source/WebCore

Only HTMLAllCollection needs stateful named item traversal.
<http://webkit.org/b/71987>

Reviewed by Antti Koivisto.

After the ability to call collections (excluding document.all) was removed
in <http://webkit.org/b/67579>, chunks of code remained in HTMLCollection
and HTMLFormCollection that was only used for this purpose.

Restrict the nextNamedItem() mechanism to HTMLAllCollection, since it's no
longer used by any of the other collections.

html/HTMLCollection.h:

Moved nextNamedItem() to HTMLAllCollection (and made it non-virtual.)
Promoted itemAfter() and checkForNameMatch() to protected methods so
they can be called from HTMLAllCollection.

html/HTMLAllCollection.h:
html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::HTMLAllCollection):
(WebCore::HTMLAllCollection::nextNamedItem):

html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::namedItem):

html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::namedItem):

html/HTMLFormCollection.h:

1:28 AM Changeset in webkit [100089] by mrowe@apple.com

2 edits in trunk/Source/WebKit2

Fix the 32-bit build.

WebProcess/mac/WebProcessMac.mm:

(WebKit::initializeSandbox): Use a format specifier and cast that works on more architectures.

12:09 AM Changeset in webkit [100088] by caio.oliveira@openbossa.org

2 edits in trunk/Source/WebCore

Update binding generator tests to use jsCast
https://bugs.webkit.org/show_bug.cgi?id=72224

Reviewed by Geoffrey Garen.

Update the expected results for JS generator after r100006 added jsCast.

bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructor::getOwnPropertySlot):
(WebCore::JSTestEventConstructor::getOwnPropertyDescriptor):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed