Timeline



Nov 27, 2011:

11:51 PM Changeset in webkit [101227] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-11-27 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Revert r101226.

  • DEPS:
11:28 PM Changeset in webkit [101226] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-11-27 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium revision.

  • DEPS:
11:08 PM Changeset in webkit [101225] by macpherson@chromium.org
  • 5 edits in trunk/Source/WebCore

Implement vertical-align property in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=72926

Reviewed by Andreas Kling.

Part of the ongoing refactoring of CSSStyleSelector::applyProperty.

Covered by several tests under fast/css.

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::isPercent):

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyVerticalAlign::createHandler):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::setVerticalAlignLength):
Calling setVerticalAlignLength now automatically sets verticalAlign to LENGTH.

11:06 PM WebKit Team edited by mihnea@adobe.com
(diff)
10:59 PM Changeset in webkit [101224] by abarth@webkit.org
  • 25 edits
    23 copies
    9 moves
    27 adds in trunk/Source/WebKit/chromium

[Chromium] Move the next traunch of headers into public/platform
https://bugs.webkit.org/show_bug.cgi?id=73073

Reviewed by Darin Fisher.

These headers are all the forward-declared classes in
WebKitPlatformSupport (and their dependencies) that wrap concepts in
WebCore/platform.

There are a number of forward-declared classes in WebKitPlatformSupport
that coorespond to WebCore concepts outside of WebCore/platform. I've
marked these with FIXME comments. We'll need to study them in more
detail to see whether they should move into WebCore/platform or whether
we need to move them out of WebKitPlaformSupport.h. (One possible
resolution might be to introducing a WebKitClientSupport.h to hold
statics for client concepts).

  • public/WebBlobRegistry.h: Replaced.
  • public/WebCanvas.h: Replaced.
  • public/WebClipboard.h: Replaced.
  • public/WebColor.h: Replaced.
  • public/WebColorName.h: Replaced.
  • public/WebCommonWorkerClient.h:
  • public/WebCompositionUnderline.h:
  • public/WebContentLayerClient.h:
  • public/WebContextMenuData.h:
  • public/WebCookieJar.h: Replaced.
  • public/WebCursorInfo.h:
  • public/WebDragData.h: Replaced.
  • public/WebFileSystem.h: Replaced.
  • public/WebFloatQuad.h:
  • public/WebFont.h:
  • public/WebFrame.h:
  • public/WebFrameClient.h:
  • public/WebGeolocationController.h:
  • public/WebGeolocationPermissionRequestManager.h:
  • public/WebGraphicsContext3D.h: Replaced.
  • public/WebHTTPBody.h:
  • public/WebImage.h: Replaced.
  • public/WebImageDecoder.h:
  • public/WebLayer.h:
  • public/WebMediaPlayer.h:
  • public/WebMediaStreamDescriptor.h: Replaced.
  • public/WebMediaStreamSource.h:
  • public/WebMimeRegistry.h: Replaced.
  • public/WebNonCopyable.h: Replaced.
  • public/WebPeerConnectionHandler.h: Replaced.
  • public/WebPeerConnectionHandlerClient.h: Replaced.
  • public/WebPlugin.h:
  • public/WebPoint.h: Replaced.
  • public/WebRect.h: Replaced.
  • public/WebRegularExpression.h:
  • public/WebScreenInfo.h:
  • public/WebScrollbar.h:
  • public/WebSize.h: Replaced.
  • public/WebSocketStreamError.h: Replaced.
  • public/WebSocketStreamHandle.h: Replaced.
  • public/WebSocketStreamHandleClient.h: Replaced.
  • public/WebThread.h: Replaced.
  • public/WebTouchPoint.h:
  • public/WebURLLoader.h: Replaced.
  • public/WebWidget.h:
  • public/WebWidgetClient.h:
  • public/android/WebSandboxSupport.h: Removed.
  • public/android/WebThemeEngine.h: Removed.
  • public/linux/WebFontFamily.h: Removed.
  • public/linux/WebSandboxSupport.h: Removed.
  • public/linux/WebThemeEngine.h: Removed.
  • public/mac/WebSandboxSupport.h: Removed.
  • public/mac/WebThemeEngine.h: Removed.
  • public/platform/WebBlobRegistry.h: Copied from Source/WebKit/chromium/public/WebBlobRegistry.h.
  • public/platform/WebCanvas.h: Copied from Source/WebKit/chromium/public/WebCanvas.h.
  • public/platform/WebClipboard.h: Copied from Source/WebKit/chromium/public/WebClipboard.h.
  • public/platform/WebColor.h: Copied from Source/WebKit/chromium/public/WebColor.h.
  • public/platform/WebColorName.h: Copied from Source/WebKit/chromium/public/WebColorName.h.
  • public/platform/WebCookieJar.h: Copied from Source/WebKit/chromium/public/WebCookieJar.h.
  • public/platform/WebDragData.h: Copied from Source/WebKit/chromium/public/WebDragData.h.
  • public/platform/WebFileSystem.h: Copied from Source/WebKit/chromium/public/WebFileSystem.h.
  • public/platform/WebGraphicsContext3D.h: Copied from Source/WebKit/chromium/public/WebGraphicsContext3D.h.
  • public/platform/WebImage.h: Copied from Source/WebKit/chromium/public/WebImage.h.
  • public/platform/WebKitPlatformSupport.h:
  • public/platform/WebMediaStreamDescriptor.h: Copied from Source/WebKit/chromium/public/WebMediaStreamDescriptor.h.
  • public/platform/WebMimeRegistry.h: Copied from Source/WebKit/chromium/public/WebMimeRegistry.h.
  • public/platform/WebNonCopyable.h: Copied from Source/WebKit/chromium/public/WebNonCopyable.h.
  • public/platform/WebPeerConnectionHandler.h: Copied from Source/WebKit/chromium/public/WebPeerConnectionHandler.h.
  • public/platform/WebPeerConnectionHandlerClient.h: Copied from Source/WebKit/chromium/public/WebPeerConnectionHandlerClient.h.
  • public/platform/WebPoint.h: Copied from Source/WebKit/chromium/public/WebPoint.h.
  • public/platform/WebRect.h: Copied from Source/WebKit/chromium/public/WebRect.h.
  • public/platform/WebSize.h: Copied from Source/WebKit/chromium/public/WebSize.h.
  • public/platform/WebSocketStreamError.h: Copied from Source/WebKit/chromium/public/WebSocketStreamError.h.
  • public/platform/WebSocketStreamHandle.h: Copied from Source/WebKit/chromium/public/WebSocketStreamHandle.h.
  • public/platform/WebSocketStreamHandleClient.h: Copied from Source/WebKit/chromium/public/WebSocketStreamHandleClient.h.
  • public/platform/WebThread.h: Copied from Source/WebKit/chromium/public/WebThread.h.
  • public/platform/WebURLLoader.h: Copied from Source/WebKit/chromium/public/WebURLLoader.h.
  • public/platform/android: Added.
  • public/platform/android/WebSandboxSupport.h: Copied from Source/WebKit/chromium/public/android/WebSandboxSupport.h.
  • public/platform/android/WebThemeEngine.h: Copied from Source/WebKit/chromium/public/android/WebThemeEngine.h.
  • public/platform/linux: Added.
  • public/platform/linux/WebFontFamily.h: Copied from Source/WebKit/chromium/public/linux/WebFontFamily.h.
  • public/platform/linux/WebSandboxSupport.h: Copied from Source/WebKit/chromium/public/linux/WebSandboxSupport.h.
  • public/platform/linux/WebThemeEngine.h: Copied from Source/WebKit/chromium/public/linux/WebThemeEngine.h.

(WebKit::WebThemeEngine::paint):

  • public/platform/mac: Added.
  • public/platform/mac/WebSandboxSupport.h: Copied from Source/WebKit/chromium/public/mac/WebSandboxSupport.h.
  • public/platform/mac/WebThemeEngine.h: Copied from Source/WebKit/chromium/public/mac/WebThemeEngine.h.

(WebKit::WebThemeEngine::paintScrollbarThumb):

  • public/platform/win: Added.
  • public/platform/win/WebSandboxSupport.h: Copied from Source/WebKit/chromium/public/win/WebSandboxSupport.h.
  • public/platform/win/WebThemeEngine.h: Copied from Source/WebKit/chromium/public/win/WebThemeEngine.h.
  • public/win/WebSandboxSupport.h: Removed.
  • public/win/WebThemeEngine.h: Removed.
10:41 PM Changeset in webkit [101223] by hayato@chromium.org
  • 71 edits in trunk/LayoutTests

Chromium rebaselines for r101202.
Unreviewed, rebaselined results.

  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-style-088-expected.png:
  • platform/chromium-mac-leopard/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-05-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-06-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-07-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-08-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-15-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-16-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-17-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-18-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-25-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-26-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-27-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-28-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-35-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-36-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-37-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-38-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-45-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-46-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-47-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-48-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-51-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-52-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-53-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-54-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-55-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-56-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-57-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-58-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-59-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-61-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-62-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-63-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-64-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-65-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-66-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-67-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-68-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-69-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-71-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-72-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-73-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-74-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-75-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-76-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-77-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-78-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-79-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-81-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-82-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-83-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-84-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-85-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-86-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-87-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-88-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-89-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-95-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-96-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-97-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-98-d-expected.png:
  • platform/chromium-mac-leopard/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/table-cell-collapsed-border-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/table_rules_all-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/table_rules_none-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png:
10:26 PM Changeset in webkit [101222] by commit-queue@webkit.org
  • 12 edits in trunk/Source/WebKit/chromium

[chromium] MediaStream API: Updating the licences to the correct one.
https://bugs.webkit.org/show_bug.cgi?id=73129

Replacing the incorrect ones I have submitted with the correct ones.

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-11-27
Reviewed by Darin Fisher.

  • bridge/PeerConnectionHandler.cpp:
  • bridge/PeerConnectionHandlerInternal.cpp:
  • bridge/PeerConnectionHandlerInternal.h:
  • public/WebMediaStreamDescriptor.h:
  • public/WebMediaStreamRegistry.h:
  • public/WebMediaStreamSource.h:
  • public/WebPeerConnectionHandler.h:
  • public/WebPeerConnectionHandlerClient.h:
  • src/WebMediaStreamDescriptor.cpp:
  • src/WebMediaStreamRegistry.cpp:
  • src/WebMediaStreamSource.cpp:
10:19 PM Changeset in webkit [101221] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Implement CSSPropertyTextAlign in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=73102

Reviewed by Andreas Kling.

Covered by fast/css/text-align*.html

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyTextAlign::applyValue):
(WebCore::ApplyPropertyTextAlign::createHandler):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

9:46 PM Changeset in webkit [101220] by hayato@chromium.org
  • 1 edit
    86 adds in trunk/LayoutTests

Chromium rebaselines for r101202.

Unreviewed, rebaselined results.

  • platform/chromium-linux/css2.1/20110323/border-conflict-element-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-001a-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-001b-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-001c-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-001d-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-003-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-004-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-005-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-006-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-007-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-008-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-009-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-010-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-011-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-012-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-013-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-014-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-015-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-016-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-017-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-018-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-019-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-020-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-021-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-022-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-023-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-024-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-025-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-026-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-027-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-028-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-029-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-030-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-031-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-032-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-033-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-034-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-035-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-036-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-037-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-038-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-039-expected.png: Added.
  • platform/chromium-linux/fast/css/border-conflict-element-002-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-001a-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-001b-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-001c-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-001d-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-003-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-004-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-005-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-006-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-007-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-008-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-009-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-010-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-011-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-012-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-013-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-014-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-015-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-016-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-017-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-018-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-019-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-020-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-021-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-022-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-023-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-024-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-025-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-026-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-027-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-028-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-029-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-030-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-031-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-032-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-033-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-034-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-035-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-036-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-037-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-038-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-039-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/border-conflict-element-002-expected.png: Added.
9:15 PM Changeset in webkit [101219] by tkent@chromium.org
  • 4 edits in trunk/LayoutTests

[Qt][Mac-WebKit2] file-input-reset.html is failing because of no
eventSender.beginDragWithFiles().
https://bugs.webkit.org/show_bug.cgi?id=72429
https://bugs.webkit.org/show_bug.cgi?id=72571

  • platform/mac/Skipped: Move file-input-reset.html to wk/Skipped.
  • platform/qt/Skipped: Move some entries to the section for beginDragWithFiles().
  • platform/wk2/Skipped: Move file-input-reset.html from mac/Skipped.
7:50 PM Changeset in webkit [101218] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebCore

CSSStyleRule: Pack m_sourceLine with CSSRule bits.
<http://webkit.org/b/73168>

Reviewed by Antti Koivisto.

Make CSSStyleRule::m_sourceLine a 27-bit integer and pack it with the rest
of the members in CSSRule. This shrinks CSSStyleRule by one CPU word
and reduces memory consumption by 81 kB on the GMail inbox (on 64-bit.)

  • css/CSSRule.h:

(WebCore::CSSRule::CSSRule):

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::CSSStyleRule):

  • css/CSSStyleRule.h:
6:11 PM Changeset in webkit [101217] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG should not emit GetMethod node
https://bugs.webkit.org/show_bug.cgi?id=73175

Reviewed by Gavin Barraclough.

Replaces all instances of the GetMethod node with GetById. This appears to
be a slight win on V8. This patch leaves GetMethod support in the code-base,
making this decision easy to reverse, for now.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

4:12 PM Changeset in webkit [101216] by zeno.albisser@nokia.com
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] MiniBrowser stops displaying content after surfing a few pages.
https://bugs.webkit.org/show_bug.cgi?id=73172

Properly initialize WebLayerTreeInfo structures.

Reviewed by Andreas Kling.

  • Shared/WebLayerTreeInfo.h:

(WebKit::WebLayerUpdateInfo::WebLayerUpdateInfo):
(WebKit::WebLayerAnimation::WebLayerAnimation):
(WebKit::WebLayerInfo::WebLayerInfo):
(WebKit::WebLayerTreeInfo::WebLayerTreeInfo):

3:47 PM Changeset in webkit [101215] by mrowe@apple.com
  • 10 edits in trunk/Source

<http://webkit.org/b/72665> Switch to a more modern approach to retrieving the OS marketing version

Reviewed by Dan Bernstein.

Source/WebCore:

  • WebCore.exp.in: Expose the necessary symbol.
  • platform/mac/WebCoreSystemInterface.h: Ditto.
  • platform/mac/WebCoreSystemInterface.mm: Ditto.

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Set up wkGetMacOSXVersionString.

  • WebView/WebView.mm:

(createMacOSXVersionString): Use WKGetMacOSXVersionString.

Source/WebKit2:

  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::macOSXVersionString): Use WKGetMacOSXVersionString.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Set up wkGetMacOSXVersionString.

3:44 PM Changeset in webkit [101214] by Martin Robinson
  • 1 edit
    1 delete in trunk/LayoutTests

Remove a test baseline that does not differ on GTK+ now that
WebGL is active by default.

  • platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt: Removed.
3:25 PM Changeset in webkit [101213] by annacc@chromium.org
  • 19 edits in trunk

Move readyState from TextTrack to HTMLTrackElement
https://bugs.webkit.org/show_bug.cgi?id=72553

Source/WebCore:

Fix for r101057 after it was rolled out in r101088

Reviewed by Eric Carlson.

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::HTMLTrackElement):

Set initial readyState to NONE.

(WebCore::HTMLTrackElement::didCompleteLoad):

Set readyState based on load completed status.

(WebCore::HTMLTrackElement::setReadyState):

This replaces textTrackReadyStateChanged() because only LoadableTextTrack
needs to notify HTMLTrackElement of readyState changes (i.e.
textTrackReadyStateChanged() is no longer required of TextTrackClient).

  • html/HTMLTrackElement.h:

ReadyState enum and m_readyState member variable moved from TextTrack.

(WebCore::HTMLTrackElement::readyState):

New: readyState() getter.

  • html/HTMLTrackElement.idl:

Add readyState attribute and associated constants.

  • html/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::loadTimerFired): Set readyState on HTMLTrackElement.
(WebCore::LoadableTextTrack::cueLoadingStarted): Ditto.
(WebCore::LoadableTextTrack::cueLoadingCompleted): Move code to set readyState

to HTMLTrackElement (it can set it based on loading status).

  • html/TextTrack.cpp: Remove readyState from TextTrack.

(WebCore::TextTrack::TextTrack): Ditto.

  • html/TextTrack.h: Ditto.
  • html/TextTrack.idl: Ditto.

LayoutTests:

Fix for r101057 after it was rolled out in r101088

Reviewed by Eric Carlson.

  • media/track/track-add-track-expected.txt:
  • media/track/track-add-track.html:
  • media/track/track-constants-expected.txt:
  • media/track/track-constants.html:
  • media/track/track-load-error-readyState-expected.txt:
  • media/track/track-load-error-readyState.html:
  • media/track/track-load-from-element-readyState-expected.txt:
  • media/track/track-load-from-element-readyState.html:
  • media/track/track-load-from-src-readyState-expected.txt:
  • media/track/track-load-from-src-readyState.html:
3:05 PM Changeset in webkit [101212] by benjamin@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

The test compositing/layer-creation/spanOverlapsCanvas.html fails on Lion
https://bugs.webkit.org/show_bug.cgi?id=73159

Reviewed by Julien Chaffraix.

The test started failing after the expected file was removed in r101203. Add the file
but specifically for Snow Leopard.

  • platform/mac-snowleopard/compositing: Added.
  • platform/mac-snowleopard/compositing/layer-creation: Added.
  • platform/mac-snowleopard/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Added.
1:45 PM Changeset in webkit [101211] by robert@webkit.org
  • 135 edits
    8 copies
    35 moves
    261 adds
    37 deletes in trunk/LayoutTests

Chromium rebaselines for r101202

Unreviewed, rebaselined results.

  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-001a-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-001b-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-001c-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-001d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-003-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-004-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-005-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-006-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-007-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-008-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-009-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-010-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-011-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-012-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-013-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-014-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-015-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-016-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-017-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-018-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-019-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-020-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-021-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-022-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-023-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-024-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-025-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-026-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-027-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-028-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-029-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-030-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-031-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-032-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-033-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-034-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-035-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-036-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-037-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-038-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-039-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-style-088-expected.png:
  • platform/chromium-cg-mac-leopard/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-05-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-06-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-07-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-08-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-15-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-16-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-17-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-18-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-25-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-26-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-27-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-28-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-35-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-36-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-37-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-38-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-45-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-46-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-47-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-48-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-51-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-52-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-53-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-54-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-55-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-56-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-57-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-58-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-59-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-61-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-62-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-63-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-64-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-65-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-66-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-67-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-68-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-69-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-71-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-72-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-73-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-74-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-75-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-76-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-77-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-78-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-79-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-81-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-82-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-83-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-84-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-85-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-86-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-87-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-88-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-89-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-95-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-96-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-97-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-98-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-cg-mac-leopard/fast/css/border-conflict-element-002-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/repaint/table-cell-collapsed-border-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/table_rules_all-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/table_rules_none-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-conflict-element-001d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-conflict-style-088-expected.png:
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-06-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-16-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-26-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-35-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-36-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-37-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-38-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-45-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-46-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-47-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-48-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-53-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-54-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-56-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-61-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-62-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-63-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-64-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-65-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-66-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-67-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-68-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-69-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-73-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-74-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-76-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-83-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-84-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-86-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-96-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/border-antialiasing-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/repaint/table-cell-collapsed-border-expected.png:
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/collapsing_borders/bug41262-4-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/table_rules_all-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/table_rules_none-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/border-conflict-element-001d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/20110323/border-conflict-style-088-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-06-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-16-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-26-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-35-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-36-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-37-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-38-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-45-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-46-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-47-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-48-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-53-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-54-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-56-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-61-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-62-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-63-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-64-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-65-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-66-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-67-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-68-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-69-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-73-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-74-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-76-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-83-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-84-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-86-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-96-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-antialiasing-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/table-cell-collapsed-border-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/collapsing_borders/bug41262-4-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/table_rules_all-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/table_rules_none-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png: Added.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-06-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-16-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-26-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-35-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-36-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-37-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-38-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-45-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-46-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-47-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-48-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-53-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-54-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-56-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-61-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-62-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-63-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-64-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-65-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-66-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-67-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-68-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-69-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-73-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-74-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-76-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-83-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-84-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-86-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-96-d-expected.png: Removed.
  • platform/chromium-mac/fast/borders/border-antialiasing-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-4-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/marvin/table_rules_all-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/marvin/table_rules_none-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-001-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-001-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-001a-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-001a-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-001a-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-001b-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-001b-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-001b-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-001c-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-001c-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-001c-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-001d-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-001d-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-001d-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-003-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-003-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-003-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-004-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-004-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-004-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-005-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-005-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-005-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-006-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-006-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-006-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-007-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-007-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-007-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-008-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-008-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-008-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-009-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-009-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-009-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-010-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-010-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-010-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-011-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-011-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-011-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-012-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-012-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-012-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-013-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-013-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-013-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-014-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-014-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-014-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-015-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-015-expected.txt: Copied from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-015-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-016-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-016-expected.txt: Copied from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-016-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-017-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-017-expected.txt: Copied from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-017-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-018-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-018-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-018-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-019-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-019-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-019-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-020-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-020-expected.txt: Copied from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-020-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-021-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-021-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-021-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-022-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-022-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-022-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-023-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-023-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-023-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-024-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-024-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-024-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-025-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-025-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-025-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-026-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-026-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-026-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-027-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-027-expected.txt: Copied from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-027-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-028-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-028-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-028-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-029-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-029-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-029-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-030-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-030-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-030-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-031-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-031-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-031-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-032-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-032-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-032-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-033-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-033-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-033-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-034-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-034-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-034-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-035-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-035-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-035-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-036-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-036-expected.txt: Copied from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-036-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-037-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-037-expected.txt: Copied from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-037-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-038-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-038-expected.txt: Copied from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-038-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-039-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-039-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-039-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/chromium-win/css2.1/20110323/border-conflict-style-088-expected.png:
  • platform/chromium-win/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-05-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-06-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-07-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-08-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-15-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-16-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-17-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-18-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-25-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-26-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-27-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-28-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-35-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-36-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-37-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-38-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-45-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-46-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-47-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-48-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-51-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-52-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-53-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-54-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-55-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-56-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-57-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-58-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-59-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-61-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-62-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-63-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-64-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-65-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-66-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-67-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-68-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-69-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-71-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-72-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-73-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-74-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-75-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-76-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-77-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-78-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-79-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-81-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-82-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-83-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-84-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-85-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-86-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-87-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-88-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-89-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-95-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-96-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-97-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-98-d-expected.png:
  • platform/chromium-win/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-win/fast/css/border-conflict-element-002-expected.png: Added.
  • platform/chromium-win/fast/css/border-conflict-element-002-expected.txt: Renamed from LayoutTests/platform/chromium/fast/css/border-conflict-element-002-expected.txt.
  • platform/chromium-win/fast/repaint/table-cell-collapsed-border-expected.png:
  • platform/chromium-win/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/table_rules_all-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/table_rules_none-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-001-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-001a-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-001b-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-001c-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-001d-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-003-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-004-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-005-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-006-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-007-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-008-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-009-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-010-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-011-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-012-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-013-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-014-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-015-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-015-expected.txt:
  • platform/chromium/css2.1/20110323/border-conflict-element-016-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-016-expected.txt:
  • platform/chromium/css2.1/20110323/border-conflict-element-017-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-017-expected.txt:
  • platform/chromium/css2.1/20110323/border-conflict-element-018-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-019-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-020-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-020-expected.txt:
  • platform/chromium/css2.1/20110323/border-conflict-element-021-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-022-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-023-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-024-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-025-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-026-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-027-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-027-expected.txt:
  • platform/chromium/css2.1/20110323/border-conflict-element-028-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-029-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-030-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-031-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-032-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-033-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-034-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-035-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-036-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-036-expected.txt:
  • platform/chromium/css2.1/20110323/border-conflict-element-037-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-037-expected.txt:
  • platform/chromium/css2.1/20110323/border-conflict-element-038-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-038-expected.txt:
  • platform/chromium/css2.1/20110323/border-conflict-element-039-expected.png:
  • platform/chromium/css2.1/t170602-bdr-conflct-w-05-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-07-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-08-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-15-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-17-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-18-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-25-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-27-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-28-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-51-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-52-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-55-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-57-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-58-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-59-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-71-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-72-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-75-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-77-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-78-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-79-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-81-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-82-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-85-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-87-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-88-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-89-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-95-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-97-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-98-d-expected.png: Added.
  • platform/chromium/fast/css/border-conflict-element-002-expected.png:
1:13 PM Changeset in webkit [101210] by annacc@chromium.org
  • 2 edits in trunk/Source/WebCore

Don't allow attribute changes on <track> if feature is not enabled.
https://bugs.webkit.org/show_bug.cgi?id=73046

Reviewed by Eric Carlson.

No new tests. This fixes a problem when --enable-video-track is not used,
but the tests use this flag.

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::attributeChanged):

12:52 PM Changeset in webkit [101209] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed weekend gardening after r101183.

  • platform/qt/fast/dom/constructed-objects-prototypes-expected.txt: Updated.
12:34 PM Changeset in webkit [101208] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

CSSMutableStyleDeclaration: setCssText() mostly duplicates parseDeclaration().
<http://webkit.org/b/73171>

Patch by Andreas Kling <kling@webkit.org> on 2011-11-27
Reviewed by Antti Koivisto.

Let setCssText() call parseDeclaration() instead of duplicating the functionality.

  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::setCssText):

12:29 PM Changeset in webkit [101207] by robert@webkit.org
  • 1 edit
    106 adds in trunk/LayoutTests

Mac, Qt and Gtk results for r101202

Unreviewed, new results.

  • platform/gtk/css2.1/20110323/border-conflict-element-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-001a-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-001b-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-001c-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-001d-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-004-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-005-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-006-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-007-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-008-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-009-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-010-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-011-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-012-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-013-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-014-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-018-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-019-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-021-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-023-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-024-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-025-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-026-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-027-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-028-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-029-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-030-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-031-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-032-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-033-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-034-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-035-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-039-expected.txt: Added.
  • platform/gtk/fast/css/border-conflict-element-002-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-001a-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-001b-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-001c-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-001d-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-003-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-004-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-005-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-006-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-007-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-008-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-009-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-010-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-011-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-012-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-013-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-014-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-018-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-019-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-021-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-022-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-023-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-024-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-025-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-026-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-028-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-029-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-030-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-031-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-032-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-033-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-034-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-035-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-039-expected.txt: Added.
  • platform/mac/fast/css/border-conflict-element-002-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-001a-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-001b-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-001c-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-001d-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-003-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-004-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-005-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-006-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-007-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-008-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-009-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-010-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-011-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-012-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-013-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-014-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-015-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-018-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-020-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-021-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-023-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-024-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-025-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-026-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-027-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-028-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-029-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-030-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-031-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-032-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-033-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-034-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-035-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-036-expected.txt: Added.
  • platform/qt/fast/css/border-conflict-element-002-expected.txt: Added.
12:20 PM Changeset in webkit [101206] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

CSS/XSLStyleSheet: checkLoaded() needn't be virtual.
<http://webkit.org/b/73169>

Patch by Andreas Kling <kling@webkit.org> on 2011-11-27
Reviewed by Antti Koivisto.

Devirtualize checkLoaded() in CSSStyleSheet and XSLStyleSheet as they
are not overriding anything, nor are they ever overridden.

  • css/CSSStyleSheet.h:
  • xml/XSLStyleSheet.h:
12:02 PM Changeset in webkit [101205] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Add assertions that CSSMappedAttributeDeclarations aren't using strict parsing.
<http://webkit.org/b/73167>

Patch by Andreas Kling <kling@webkit.org> on 2011-11-27
Reviewed by Antti Koivisto.

  • dom/StyledElement.cpp:

(WebCore::StyledElement::createMappedDecl):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::additionalAttributeStyleDecls):
(WebCore::HTMLTableElement::addSharedCellBordersDecl):
(WebCore::HTMLTableElement::addSharedCellPaddingDecl):
(WebCore::HTMLTableElement::addSharedGroupDecls):

11:48 AM Changeset in webkit [101204] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

CSSStyleSheet: Removed unused create() overload.
<http://webkit.org/b/73170>

Patch by Andreas Kling <kling@webkit.org> on 2011-11-27
Reviewed by Antonio Gomes.

Nobody was using CSSStyleSheet::create(ownerNode, originalURL, finalURL)
so remove it.

  • css/CSSStyleSheet.h:

(WebCore::CSSStyleSheet::create):

11:05 AM Changeset in webkit [101203] by benjamin@webkit.org
  • 1 edit
    2 deletes in trunk/LayoutTests

The test compositing/layer-creation/spanOverlapsCanvas.html fails on Lion
https://bugs.webkit.org/show_bug.cgi?id=73159

Reviewed by Andreas Kling.

The empty file spanOverlapsCanvas-expected.txt was created in the Chromium rebaseline r100557.

On Lion, the test spanOverlapsCanvas.html generates the expected test result, this patch removes
the empty file.

The empty directories compositing/layer-creation for Snow Leopard and Lion are also removed.

  • platform/mac-lion/compositing: Removed.
  • platform/mac-lion/compositing/layer-creation: Removed.
  • platform/mac-lion/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Removed.
  • platform/mac-snowleopard/compositing: Removed.
  • platform/mac-snowleopard/compositing/layer-creation: Removed.
10:32 AM Changeset in webkit [101202] by robert@webkit.org
  • 74 edits
    137 adds in trunk

CSS 2.1 failure: border-conflict-element-*
https://bugs.webkit.org/show_bug.cgi?id=71244

Source/WebCore:

Reviewed by Julien Chaffraix.

From http://www.w3.org/TR/CSS21/tables.html#border-conflict-resolution :

"When two adjacent cells have the same border-width and the same border-style in a
'border-collapse: collapse' table, then the color of the border from the leftmost cell wins
(if the table's 'direction' is 'ltr'; right, if it is 'rtl') and the color of the border
from the topmost cell wins."

So WebCore::compareBorders needs to account for the position of the cell when
deciding which border wins the comparison. This will ensure that the winning border is
sorted to the appropriate position in the sorted list of borders for painting.

When conflicting collapsed borders are in the same cell, the following order of
precedence is used (where 4 has highest precedence):

3

| |

4 | | 1

|_|

2

This fixes the following failing tests from the border-conflict-element-* set
in the CSS 2.1 test suite:

border-conflict-element-001d.htm
border-conflict-element-0037.htm

One test in the suite is known to be wrong, so a corrected version has been landed outside the
css2.1 folder:

border-conflict-element-002.htm

This change entails rebaselining quite a few tests, see the LayoutTests ChangeLog for a full
explanation of the rebaselines.

  • rendering/RenderTableCell.cpp:

(WebCore::compareBorders): Compare the cells' position from the left (in 'ltr') and right (in 'rtl')

of the table and the cells' position from the top of the table when nothing
else in the style, width, or grouping of the borders determines precedence.
If the conflicting borders are in the same cell, apply the same logic to the position of the borders.

(WebCore::RenderTableCell::collapsedStartBorder): Pass the cell's position and its table's direction to CollapsedBorderValue
(WebCore::RenderTableCell::collapsedEndBorder): ditto
(WebCore::RenderTableCell::collapsedBeforeBorder): ditto
(WebCore::RenderTableCell::collapsedAfterBorder): ditto

  • rendering/style/CollapsedBorderValue.h:

(WebCore::CollapsedBorderValue::CollapsedBorderValue): Learn the position of the border's cell and the direction of its table
(WebCore::CollapsedBorderValue::columnOffset): the cell's offset from the top of the table
(WebCore::CollapsedBorderValue::rowOffset): the cell's offset from the start of the table
(WebCore::CollapsedBorderValue::edge): which edge of the cell the border is on
(WebCore::CollapsedBorderValue::operator==): cells with the same position in the table are equal

LayoutTests:

Add all the passing border-conflict-element* tests from the CSS 2.1 test suite.

Add a corrected version of the CSS suite test border-conflict-element-002.htm, which can sit here until

the corrected version is landed upstream. See http://lists.w3.org/Archives/Public/public-css-testsuite/2011Nov/0002.html

Rebaseline all t170602-bdr-conflct-w-* tests. The rendering of the collapsed borders in these

tests now obeys the order of precedence for the position of the cell and the precendece of the position
of the borders within the same cell.

Rebaseline tables/mozilla/collapsing_borders/bug41262-4.html: ditto

tables/mozilla/marvin/table_rules_all.html : ditto
tables/mozilla/marvin/table_rules_none.html : ditto
tables/mozilla_expected_failures/marvin/table_rules_cols.html : ditto
tables/mozilla_expected_failures/marvin/table_rules_rows.html : ditto

Rebaseline two border-conflict-style-* tests: ditto

Rebaseline fast/borders/border-antialiasing.html, the result is too small to confirm the difference but

presume it is one of the above.

Reviewed by Julien Chaffraix.

  • css2.1/20110323/border-conflict-element-001.htm: Added.
  • css2.1/20110323/border-conflict-element-001a.htm: Added.
  • css2.1/20110323/border-conflict-element-001b.htm: Added.
  • css2.1/20110323/border-conflict-element-001c.htm: Added.
  • css2.1/20110323/border-conflict-element-001d.htm: Added.
  • css2.1/20110323/border-conflict-element-003.htm: Added.
  • css2.1/20110323/border-conflict-element-004.htm: Added.
  • css2.1/20110323/border-conflict-element-005.htm: Added.
  • css2.1/20110323/border-conflict-element-006.htm: Added.
  • css2.1/20110323/border-conflict-element-007.htm: Added.
  • css2.1/20110323/border-conflict-element-008.htm: Added.
  • css2.1/20110323/border-conflict-element-009.htm: Added.
  • css2.1/20110323/border-conflict-element-010.htm: Added.
  • css2.1/20110323/border-conflict-element-011.htm: Added.
  • css2.1/20110323/border-conflict-element-012.htm: Added.
  • css2.1/20110323/border-conflict-element-013.htm: Added.
  • css2.1/20110323/border-conflict-element-014.htm: Added.
  • css2.1/20110323/border-conflict-element-015.htm: Added.
  • css2.1/20110323/border-conflict-element-016.htm: Added.
  • css2.1/20110323/border-conflict-element-017.htm: Added.
  • css2.1/20110323/border-conflict-element-018.htm: Added.
  • css2.1/20110323/border-conflict-element-019.htm: Added.
  • css2.1/20110323/border-conflict-element-020.htm: Added.
  • css2.1/20110323/border-conflict-element-021.htm: Added.
  • css2.1/20110323/border-conflict-element-022.htm: Added.
  • css2.1/20110323/border-conflict-element-023.htm: Added.
  • css2.1/20110323/border-conflict-element-024.htm: Added.
  • css2.1/20110323/border-conflict-element-025.htm: Added.
  • css2.1/20110323/border-conflict-element-026.htm: Added.
  • css2.1/20110323/border-conflict-element-027.htm: Added.
  • css2.1/20110323/border-conflict-element-028.htm: Added.
  • css2.1/20110323/border-conflict-element-029.htm: Added.
  • css2.1/20110323/border-conflict-element-030.htm: Added.
  • css2.1/20110323/border-conflict-element-031.htm: Added.
  • css2.1/20110323/border-conflict-element-032.htm: Added.
  • css2.1/20110323/border-conflict-element-033.htm: Added.
  • css2.1/20110323/border-conflict-element-034.htm: Added.
  • css2.1/20110323/border-conflict-element-035.htm: Added.
  • css2.1/20110323/border-conflict-element-036.htm: Added.
  • css2.1/20110323/border-conflict-element-037.htm: Added.
  • css2.1/20110323/border-conflict-element-038.htm: Added.
  • css2.1/20110323/border-conflict-element-039.htm: Added.
  • css2.1/20110323/support/swatch-blue.png: Added.
  • css2.1/20110323/support/swatch-green.png: Added.
  • css2.1/20110323/support/swatch-lime.png: Added.
  • css2.1/20110323/support/swatch-orange.png: Added.
  • css2.1/20110323/support/swatch-red.png: Added.
  • css2.1/20110323/support/swatch-teal.png: Added.
  • css2.1/20110323/support/swatch-white.png: Added.
  • css2.1/20110323/support/swatch-yellow.png: Added.
  • fast/css/border-conflict-element-002.htm: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/chromium-linux/css2.1/20110323/border-conflict-style-088-expected.png:
  • platform/chromium-linux/css2.1/20110323/floating-replaced-height-008-expected.png: Addition of support/swatch-white.png rebaselines result.
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-05-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-06-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-07-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-08-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-15-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-16-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-17-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-18-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-25-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-26-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-27-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-28-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-35-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-36-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-37-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-38-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-45-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-46-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-47-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-48-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-51-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-52-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-53-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-54-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-55-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-56-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-57-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-58-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-59-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-61-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-62-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-63-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-64-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-65-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-66-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-67-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-68-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-69-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-71-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-72-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-73-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-74-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-75-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-76-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-77-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-78-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-79-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-81-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-82-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-83-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-84-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-85-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-86-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-87-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-88-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-89-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-95-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-96-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-97-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-98-d-expected.png:
  • platform/chromium-linux/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-linux/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/table_rules_all-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/table_rules_none-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-001-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-001-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-001a-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-001a-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-001b-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-001b-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-001c-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-001c-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-001d-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-001d-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-003-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-003-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-004-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-004-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-005-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-005-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-006-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-006-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-007-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-007-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-008-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-008-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-009-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-009-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-010-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-010-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-011-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-011-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-012-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-012-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-013-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-013-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-014-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-014-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-015-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-015-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-016-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-016-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-017-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-017-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-018-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-018-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-019-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-019-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-020-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-020-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-021-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-021-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-022-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-022-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-023-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-023-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-024-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-024-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-025-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-025-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-026-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-026-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-027-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-027-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-028-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-028-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-029-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-029-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-030-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-030-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-031-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-031-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-032-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-032-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-033-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-033-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-034-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-034-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-035-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-035-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-036-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-036-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-037-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-037-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-038-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-038-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-039-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-039-expected.txt: Added.
  • platform/chromium/fast/css/border-conflict-element-002-expected.png: Added.
  • platform/chromium/fast/css/border-conflict-element-002-expected.txt: Added.
7:54 AM Changeset in webkit [101201] by pfeldman@chromium.org
  • 42 edits in trunk/Source

Web Inspector: remove disconnectFromBackend from the protocol.
https://bugs.webkit.org/show_bug.cgi?id=73127

Source/WebCore:

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::inspectedPageDestroyed):

  • inspector/InspectorClient.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::close):

  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendHost.cpp:
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/InspectorFrontendHostStub.js:
  • inspector/front-end/inspector.js:

(WebInspector.disconnectFromWorker):

  • loader/EmptyClients.h:

(WebCore::EmptyInspectorClient::closeInspectorFrontend):

Source/WebKit/chromium:

We should instead use InspectorClient::closeInspectorFrontend that would
be closing the front-end window.

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • src/InspectorClientImpl.cpp:

(WebKit::InspectorClientImpl::closeInspectorFrontend):

  • src/InspectorClientImpl.h:
  • src/InspectorFrontendClientImpl.cpp:
  • src/InspectorFrontendClientImpl.h:
  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::closeInspectorFrontend):
(WebKit::WebDevToolsAgent::disconnectEventAsText):

  • src/WebDevToolsAgentImpl.h:

Source/WebKit/gtk:

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • WebCoreSupport/InspectorClientGtk.cpp:

(WebKit::InspectorClient::inspectorDestroyed):
(WebKit::InspectorClient::closeInspectorFrontend):

  • WebCoreSupport/InspectorClientGtk.h:

Source/WebKit/mac:

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorClient::inspectorDestroyed):
(WebInspectorClient::closeInspectorFrontend):

Source/WebKit/qt:

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • WebCoreSupport/InspectorClientQt.cpp:

(WebCore::InspectorClientQt::inspectorDestroyed):
(WebCore::InspectorClientQt::closeInspectorFrontend):
(WebCore::InspectorFrontendClientQt::inspectorClientDestroyed):

  • WebCoreSupport/InspectorClientQt.h:

Source/WebKit/win:

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorClient::inspectorDestroyed):
(WebInspectorClient::closeInspectorFrontend):

  • WebCoreSupport/WebInspectorClient.h:

Source/WebKit2:

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::inspectorDestroyed):

  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
5:30 AM Changeset in webkit [101200] by commit-queue@webkit.org
  • 3 edits
    1 delete in trunk/LayoutTests

REGRESSION(r97881): It broke fast/dom/error-to-string-stack-overflow.html
https://bugs.webkit.org/show_bug.cgi?id=70476

Patch by Lauro Neto <lauro.neto@openbossa.org> on 2011-11-27
Reviewed by Andreas Kling.

Removing obsolete qt-specific expected file as the base one is enough.

  • platform/qt-wk2/Skipped:
  • platform/qt/Skipped:
  • platform/qt/fast/dom/error-to-string-stack-overflow-expected.txt: Removed.

Nov 26, 2011:

7:05 PM Changeset in webkit [101199] by kevino@webkit.org
  • 4 edits in trunk

[wx] Unreviewed build fixes for Windows.

5:26 PM Changeset in webkit [101198] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Needs WTF_INLINE and JS_INLINE
https://bugs.webkit.org/show_bug.cgi?id=72853

Patch by Hajime Morrita <morrita@chromium.org> on 2011-11-26
Reviewed by Kevin Ollivier.

Added WTF_HIDDEN, WTF_INLINE and JS_INLINE which
indirect attribute((visibility("hidden"))

  • config.h:
  • wtf/ExportMacros.h:
11:31 AM Changeset in webkit [101197] by alex
  • 2 edits in trunk/Source/WebCore

2011-11-26 Alejandro G. Castro <alex@igalia.com>

Fix compilation after r101157.

Reviewed by Martin Robinson.

  • bindings/scripts/preprocessor.pm: (applyPreprocessor): In case we have a string with double-quotations (") we replace it with the empty string.
10:00 AM Changeset in webkit [101196] by igor.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebCore

[TexMapper][WK2][Qt] Simple opacity animations are not working
https://bugs.webkit.org/show_bug.cgi?id=73157

LayerTreeHostQt needs to know what nodes in the TextureMapper are visible, to associate
a tile to it. It is done using TextureMapperNode::collectVisibleContentsRects.

However TextureMapperNode::collectVisibleContentsRects has an optimization to check if
the current tile has opacity greater than 0.01, otherwise it will not create a tile for
the current node.

For opacity animations from 0 to 1, it is a problem because the tile is never created
and the animation never happens.

This patch fixes opacity animations.

Reviewed by Noam Rosenthal.

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::countDescendantsWithContent):
(WebCore::TextureMapperNode::collectVisibleContentsRects):

8:09 AM Changeset in webkit [101195] by caio.oliveira@openbossa.org
  • 5 edits in trunk/Source/WebKit2

[Qt] [WK2] QtDownloadManager doesn't need to be RefCounted
https://bugs.webkit.org/show_bug.cgi?id=73151

Reviewed by Kenneth Rohde Christiansen.

QtDownloadManager is owned by QtWebContext, and doesn't need to be a RefCounted
class. This commit also makes the callback handlers private -- following the similar
approach we take in other clients of the C API.

  • UIProcess/qt/QtDownloadManager.cpp:

(WebKit::QtDownloadManager::QtDownloadManager):
(WebKit::QtDownloadManager::addDownload):
(WebKit::toQtDownloadManager):
(WebKit::QtDownloadManager::didReceiveResponse):
(WebKit::QtDownloadManager::didCreateDestination):
(WebKit::QtDownloadManager::didFinishDownload): remove unused failingUrl local variable.
(WebKit::QtDownloadManager::didFailDownload):
(WebKit::QtDownloadManager::didReceiveDataForDownload):

  • UIProcess/qt/QtDownloadManager.h:
  • UIProcess/qt/QtWebContext.cpp:

(WebKit::QtWebContext::initialize):

  • UIProcess/qt/QtWebContext.h:
7:51 AM Changeset in webkit [101194] by commit-queue@webkit.org
  • 45 edits in trunk/Source

Unreviewed, rolling out r101193.
http://trac.webkit.org/changeset/101193
https://bugs.webkit.org/show_bug.cgi?id=73158

Breaks Windows and Qt minimal. (Requested by pfeldman on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-26

Source/WebCore:

  • inspector/Inspector.json:
  • inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::inspectedPageDestroyed):

  • inspector/InspectorClient.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::close):

  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::disconnectFromBackend):

  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.disconnectFromBackend):

  • inspector/front-end/inspector.js:

(WebInspector.disconnectFromBackend):

  • loader/EmptyClients.h:

Source/WebKit/chromium:

  • src/InspectorClientImpl.cpp:
  • src/InspectorClientImpl.h:
  • src/InspectorFrontendClientImpl.cpp:

(WebKit::InspectorFrontendClientImpl::disconnectFromBackend):

  • src/InspectorFrontendClientImpl.h:
  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgent::disconnectEventAsText):

  • src/WebDevToolsAgentImpl.h:

Source/WebKit/efl:

  • WebCoreSupport/InspectorClientEfl.cpp:
  • WebCoreSupport/InspectorClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/InspectorClientGtk.cpp:

(WebKit::InspectorClient::inspectorDestroyed):
(WebKit::InspectorFrontendClient::disconnectFromBackend):

  • WebCoreSupport/InspectorClientGtk.h:

Source/WebKit/mac:

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorClient::inspectorDestroyed):

Source/WebKit/qt:

  • WebCoreSupport/InspectorClientQt.cpp:

(WebCore::InspectorClientQt::inspectorDestroyed):
(WebCore::InspectorFrontendClientQt::disconnectFromBackend):
(WebCore::InspectorFrontendClientQt::inspectorClientDestroyed):

  • WebCoreSupport/InspectorClientQt.h:

Source/WebKit/win:

  • WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorClient::inspectorDestroyed):
(WebInspectorFrontendClient::disconnectFromBackend):

  • WebCoreSupport/WebInspectorClient.h:

Source/WebKit/wince:

  • WebCoreSupport/InspectorClientWinCE.cpp:
  • WebCoreSupport/InspectorClientWinCE.h:

Source/WebKit/wx:

  • WebKitSupport/InspectorClientWx.cpp:
  • WebKitSupport/InspectorClientWx.h:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::inspectorDestroyed):

  • WebProcess/WebCoreSupport/WebInspectorClient.h:
  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:

(WebKit::WebInspectorFrontendClient::disconnectFromBackend):

  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
7:30 AM Changeset in webkit [101193] by pfeldman@chromium.org
  • 42 edits in trunk/Source

Web Inspector: remove disconnectFromBackend from the protocol.
https://bugs.webkit.org/show_bug.cgi?id=73127

Source/WebCore:

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::inspectedPageDestroyed):

  • inspector/InspectorClient.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::close):

  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendHost.cpp:
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/InspectorFrontendHostStub.js:
  • inspector/front-end/inspector.js:

(WebInspector.disconnectFromWorker):

  • loader/EmptyClients.h:

(WebCore::EmptyInspectorClient::closeInspectorFrontend):

Source/WebKit/chromium:

We should instead use InspectorClient::closeInspectorFrontend that would
be closing the front-end window.

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • src/InspectorClientImpl.cpp:

(WebKit::InspectorClientImpl::closeInspectorFrontend):

  • src/InspectorClientImpl.h:
  • src/InspectorFrontendClientImpl.cpp:
  • src/InspectorFrontendClientImpl.h:
  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::closeInspectorFrontend):
(WebKit::WebDevToolsAgent::disconnectEventAsText):

  • src/WebDevToolsAgentImpl.h:

Source/WebKit/gtk:

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • WebCoreSupport/InspectorClientGtk.cpp:

(WebKit::InspectorClient::inspectorDestroyed):
(WebKit::InspectorClient::closeInspectorFrontend):

  • WebCoreSupport/InspectorClientGtk.h:

Source/WebKit/mac:

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorClient::inspectorDestroyed):
(WebInspectorClient::closeInspectorFrontend):

Source/WebKit/qt:

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • WebCoreSupport/InspectorClientQt.cpp:

(WebCore::InspectorClientQt::inspectorDestroyed):
(WebCore::InspectorClientQt::closeInspectorFrontend):
(WebCore::InspectorFrontendClientQt::inspectorClientDestroyed):

  • WebCoreSupport/InspectorClientQt.h:

Source/WebKit/win:

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorClient::inspectorDestroyed):
(WebInspectorClient::closeInspectorFrontend):

  • WebCoreSupport/WebInspectorClient.h:

Source/WebKit2:

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::inspectorDestroyed):

  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
4:48 AM Changeset in webkit [101192] by timothy@apple.com
  • 2 edits in trunk/Source/WebCore

Fix a bug in TreeOutline which would cause parent elements to show up as expanded and empty
when removed and added back to the tree.

https://bugs.webkit.org/show_bug.cgi?id=73155

Reviewed by Pavel Feldman.

  • inspector/front-end/treeoutline.js:

(TreeElement.prototype.collapse): Set _treeElementsExpandedState to false instead of true.
Only TreeElement.prototype.expand should set it to true, which it does.

2:47 AM Changeset in webkit [101191] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

[CMake] Clean up Web Inspector target in Source/WebKit/blackberry/CMakeListsBlackBerry.txt
https://bugs.webkit.org/show_bug.cgi?id=72784

Patch by Jonathan Dong <Jonathan Dong> on 2011-11-26
Reviewed by Nikolas Zimmermann.

Abstracted the JavaScript file names from inspector/front-end/inspector.html
to keep them in-sync with the changes of inspector.html.

  • blackberry/CMakeListsBlackBerry.txt:
2:16 AM Changeset in webkit [101190] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[GTK] Fix some warnings in WebCore GTK+
https://bugs.webkit.org/show_bug.cgi?id=73137

Patch by Martin Robinson <mrobinson@igalia.com> on 2011-11-26
Reviewed by Philippe Normand.

No new tests. This patch just fixes compilation warnings.

  • platform/gtk/CursorGtk.cpp:

(WebCore::createNamedCursor): Remove unused variable.

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore::RenderThemeGtk::paintSliderTrack): ASSERT_UNUSED instead of ASSERT.

  • platform/gtk/SharedTimerGtk.cpp: Ditto.

(WebCore::stopSharedTimer):

12:59 AM Changeset in webkit [101189] by Martin Robinson
  • 2 edits in trunk/Tools

Try to fix the build after r101174.

  • gtk/generate-gtkdoc: Properly handle empty PKG_CONFIG_PATHs.

Nov 25, 2011:

11:17 PM Changeset in webkit [101188] by caio.oliveira@openbossa.org
  • 5 edits
    2 adds
    2 deletes in trunk/Source/WebKit2

[Qt] [WK2] Remove WebContext related code from QtWebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=73150

Reviewed by Kenneth Rohde Christiansen.

Creates a QtWebContext class that abstracts away from QtWebPageProxy the
handling of creating / maintaining the default WebContext, as well as the
code for the WKContextRef clients.

Another motivation for having this entity is to have a proper place to add
objects are bound to the context, like the QtDownloadManager.

  • Target.pri:
  • UIProcess/qt/ClientImpl.cpp: Removed.
  • UIProcess/qt/ClientImpl.h: Removed.
  • UIProcess/qt/QtDownloadManager.cpp:
  • UIProcess/qt/QtWebContext.cpp: Added.

(WebKit::QtWebContext::QtWebContext):
(WebKit::QtWebContext::~QtWebContext):
(WebKit::QtWebContext::create):
(WebKit::QtWebContext::defaultContext):
(WebKit::QtWebContext::createWebPage):
(WebKit::QtWebContext::setNavigatorQtObjectEnabled):
(WebKit::QtWebContext::postMessageToNavigatorQtObject):
(WebKit::QtWebContext::initialize):
(WebKit::QtWebContext::initializeContextInjectedBundleClient):
(WebKit::toQtWebContext):
(WebKit::QtWebContext::didReceiveMessageFromInjectedBundle):

  • UIProcess/qt/QtWebContext.h: Added.

(WebKit::QtWebContext::downloadManager):

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::~QtWebPageProxy):
(QtWebPageProxy::setNavigatorQtObjectEnabled):
(QtWebPageProxy::postMessageToNavigatorQtObject):
(QtWebPageProxy::handleDownloadRequest):

  • UIProcess/qt/QtWebPageProxy.h:
10:15 PM Changeset in webkit [101187] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

String.prototype.toLower should be optimized for 8 bit strings
https://bugs.webkit.org/show_bug.cgi?id=73154

Changed stringProtoFuncToLowerCase to use StringImpl::lower() which has
been optimized for 8 bit strings.

This is worth ~7% to sunspider string.tagcloud.

Reviewed by Filip Pizlo.

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncToLowerCase):

10:01 PM Changeset in webkit [101186] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Array.toString always uses StringImpl::characters()
https://bugs.webkit.org/show_bug.cgi?id=72969

If all component strings are 8 bit, create an 8 bit result string for toString().

This appears to be performance neutral to sunspider and v8.

Reviewed by Filip Pizlo.

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):

8:28 PM Changeset in webkit [101185] by eric.carlson@apple.com
  • 11 edits
    2 adds
    2 deletes in trunk

Implement addCue and removeCue in TextTrack
https://bugs.webkit.org/show_bug.cgi?id=72554

Reviewed by Darin Adler.

Source/WebCore:

Test: media/track/track-add-remove-cue.html

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::ensureTrack): Go ahead and allocate a Track even if the feature

is disabled, it just won't load anything.

(WebCore::HTMLTrackElement::scheduleLoad): Early return if the featue is disabled.
(WebCore::HTMLTrackElement::canLoadUrl): Ditto.

  • html/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::newCuesAvailable): Add new cues one at a time because

cues->add(Vector<TextTrackCue*>&) is gone.

  • html/TextTrack.cpp:

(WebCore::TextTrack::addCue): Implement.
(WebCore::TextTrack::removeCue): Ditto.

  • html/TextTrack.h:

(WebCore::TextTrackCue::TextTrackCue): Initialize every member variable.
(WebCore::TextTrackCue::track): m_track is now a RefPtr.
(WebCore::TextTrackCue::setTrack): Ditto.

  • html/TextTrackCue.h:
  • html/TextTrackCueList.cpp:

(WebCore::TextTrackCueList::add): Don't ignore out of order cues, the spec text is not

a conformance requirement. Return bool to indicate success or failure.

(WebCore::TextTrackCueList::remove): Return bool to indicate success or failure.

  • html/TextTrackCueList.h:
  • loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::notifyFinished): Don't change m_state once it is set to Failed.

LayoutTests:

  • media/track/track-add-remove-cue-expected.txt: Added.
  • media/track/track-add-remove-cue.html: Added.
  • media/track/track-webvtt-tc012-out-of-order-expected.txt: Removed.
  • media/track/track-webvtt-tc012-out-of-order.html: Removed.
4:34 PM Changeset in webkit [101184] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

Refactoring CodeGenerator*.pm for bug 72138
https://bugs.webkit.org/show_bug.cgi?id=73115

Reviewed by Adam Barth.

Tests: bindings/scripts/test/TestObj.idl

  • bindings/scripts/CodeGeneratorGObject.pm: Added "1;" at the end since this perl script is loaded as a package.
  • bindings/scripts/CodeGeneratorV8.pm: Ditto. Removed unnecessary variable names from method declarations in order to supress style check errors when a new run-bindings-tests IDL is added.

(GenerateHeaderCustomCall):

  • bindings/scripts/test/V8/V8TestObj.h: Updated a run-bindings-tests result.
3:34 PM Changeset in webkit [101183] by haraken@chromium.org
  • 6 edits
    2 adds in trunk

Implement the WebGLContextEvent constructor
https://bugs.webkit.org/show_bug.cgi?id=72856

Reviewed by Adam Barth.

Source/WebCore:

This patch makes WebGLContextEvent constructable.
The spec: http://www.khronos.org/registry/webgl/specs/latest/#5.14

Test: fast/events/constructors/webgl-context-event-constructor.html

  • html/canvas/WebGLContextEvent.cpp: Added an implementation of the WebGLContextEvent constructor.

(WebCore::WebGLContextEventInit::WebGLContextEventInit):
(WebCore::WebGLContextEvent::WebGLContextEvent):

  • html/canvas/WebGLContextEvent.h: Added a definition of WebGLContextEventInit.

(WebCore::WebGLContextEvent::create):

  • html/canvas/WebGLContextEvent.idl: Added [ConstructorTemplate=Event] IDL.

LayoutTests:

webgl-context-event-constructor.html checks the behavior of the WebGLContextEvent constructor.

  • fast/dom/constructed-objects-prototypes-expected.txt: Added window.WebGLContextEvent.
  • fast/events/constructors/webgl-context-event-constructor-expected.txt: Added.
  • fast/events/constructors/webgl-context-event-constructor.html: Added.
2:59 PM Changeset in webkit [101182] by rniwa@webkit.org
  • 1 edit
    9 adds in trunk/LayoutTests

Add missing results for Mac after r100949 and r100036.
svg/repaint/filter-child-repaint.svg is failing. The failure is tracked by the bug 73146.

  • platform/mac/css2.1/20110323/empty-inline-001-expected.png: Added.
  • platform/mac/css2.1/20110323/empty-inline-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/empty-inline-002-expected.png: Added.
  • platform/mac/css2.1/20110323/empty-inline-002-expected.txt: Added.
  • platform/mac/css2.1/20110323/empty-inline-003-expected.png: Added.
  • platform/mac/css2.1/20110323/empty-inline-003-expected.txt: Added.
  • platform/mac/media/controls-without-preload-expected.png: Added.
  • platform/mac/svg/repaint/filter-child-repaint-expected.png: Added.
  • platform/mac/svg/repaint/filter-child-repaint-expected.txt: Added.
1:52 PM Changeset in webkit [101181] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[Chromium] The DrawingBuffer::bind method was incorrectly resetting the
GL viewport parameters. This was unnecessary, and resulted in the corruption
of the WebGL context's state.
https://bugs.webkit.org/show_bug.cgi?id=73091

Patch by Jeff Timanus <twiz@chromium.org> on 2011-11-25
Reviewed by Stephen White.

Tests: fast/canvas/webgl/webgl-viewport-parameters-preserved.html

Source/WebCore:

  • platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore::DrawingBuffer::bind):

LayoutTests:

  • fast/canvas/webgl/webgl-viewport-parameters-preserved-expected.txt: Added.
  • fast/canvas/webgl/webgl-viewport-parameters-preserved.html: Added.
12:21 PM Changeset in webkit [101180] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Crash in BidiRunList<Run>::replaceRunWithRuns with an empty bdi element
https://bugs.webkit.org/show_bug.cgi?id=73116

Reviewed by Eric Seidel.

Source/WebCore:

The assertion failure was caused because isolatedResolver is initialized with
null start object due to the isolated run being empty.

Fixed the failure by skipping empty isolated runs.

Test: fast/text/empty-bdi-crash.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::constructBidiRuns):

LayoutTests:

Added a regression test.

  • fast/text/empty-bdi-crash-expected.txt: Added.
  • fast/text/empty-bdi-crash.html: Added.
11:57 AM Changeset in webkit [101179] by jesus@webkit.org
  • 11 edits in trunk/Source/WebKit2

[Qt][WK2] Refactor GestureRecognizers to use QtWebPageEventHandler
https://bugs.webkit.org/show_bug.cgi?id=73096

Reviewed by Kenneth Rohde Christiansen.

Move all the interaction engine usage to QtWebPageEventHandler,
making all GestureRecognizers (Tap, Pinch and Pan) use it directly.

  • UIProcess/qt/QtGestureRecognizer.cpp:

(WebKit::QtGestureRecognizer::QtGestureRecognizer):

  • UIProcess/qt/QtGestureRecognizer.h:
  • UIProcess/qt/QtPanGestureRecognizer.cpp:

(WebKit::QtPanGestureRecognizer::QtPanGestureRecognizer):
(WebKit::QtPanGestureRecognizer::recognize):

  • UIProcess/qt/QtPanGestureRecognizer.h:
  • UIProcess/qt/QtPinchGestureRecognizer.cpp:

(WebKit::QtPinchGestureRecognizer::QtPinchGestureRecognizer):
(WebKit::QtPinchGestureRecognizer::recognize):

  • UIProcess/qt/QtPinchGestureRecognizer.h:
  • UIProcess/qt/QtTapGestureRecognizer.cpp:

(WebKit::QtTapGestureRecognizer::QtTapGestureRecognizer):
(WebKit::QtTapGestureRecognizer::recognize):
(WebKit::QtTapGestureRecognizer::tapTimeout):

  • UIProcess/qt/QtTapGestureRecognizer.h:
  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::QtWebPageEventHandler):
(QtWebPageEventHandler::setViewportInteractionEngine):

  • UIProcess/qt/QtWebPageEventHandler.h:

(QtWebPageEventHandler::interactionEngine):

11:26 AM Changeset in webkit [101178] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Remove unneeded declaration from QQuickWebPagePrivate
https://bugs.webkit.org/show_bug.cgi?id=73141

Reviewed by Antonio Gomes.

Left-over from r101165.

  • UIProcess/API/qt/qquickwebpage_p_p.h:
10:08 AM Changeset in webkit [101177] by Antti Koivisto
  • 10 edits in trunk/Source/WebCore

StyleGeneratedImage should ref CSSImageGeneratorValue
https://bugs.webkit.org/show_bug.cgi?id=73074

Reviewed by Andreas Kling and Nikolas Zimmermann.

RenderStyle owns a bunch of StyleImage objects. However StyleGeneratedImage does not ref the
CSSImageGeneratorValue it holds so we currently rely on the stylesheet to keep the CSSImageGeneratorValues
alive as long as RenderStyle stays alive. While this works (RenderStyles are thrown away if stylesheets
change) it is not particularly robust or nice.

  • Use RefPtr<CSSImageGeneratorValue> in StyleGeneratedImage
  • Remove the RefPtr<StyleGeneratedImage> from CSSImageGeneratorValue. There is no good reason to cache StyleGeneratedImage as it is a small and uncommon object. With that the whole back-reference becomes unnecessary.
  • Switch more places to use (Pass)RefPtr<StyleImage> for consistency.
  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::CSSImageGeneratorValue):

  • css/CSSImageGeneratorValue.h:
  • css/CSSStyleApplyProperty.cpp:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::styleImage):
(WebCore::CSSStyleSelector::cachedOrPendingFromValue):
(WebCore::CSSStyleSelector::generatedOrPendingFromValue):
(WebCore::CSSStyleSelector::loadPendingImage):
(WebCore::CSSStyleSelector::loadPendingImages):

  • css/CSSStyleSelector.h:
  • rendering/style/FillLayer.h:

(WebCore::FillLayer::setImage):

  • rendering/style/NinePieceImage.h:

(WebCore::NinePieceImage::NinePieceImage):

  • rendering/style/StyleGeneratedImage.cpp:

(WebCore::StyleGeneratedImage::StyleGeneratedImage):
(WebCore::StyleGeneratedImage::cssValue):
(WebCore::StyleGeneratedImage::imageSize):
(WebCore::StyleGeneratedImage::addClient):
(WebCore::StyleGeneratedImage::removeClient):
(WebCore::StyleGeneratedImage::image):

  • rendering/style/StyleGeneratedImage.h:

(WebCore::StyleGeneratedImage::create):
(WebCore::StyleGeneratedImage::data):

9:47 AM Changeset in webkit [101176] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Web Inspector: assertion failure in InspectorController::restoreInspectorStateFromCookie
https://bugs.webkit.org/show_bug.cgi?id=73136

Don't call connectFrontend twice on reattach.

Reviewed by Pavel Feldman.

  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::reattach):

8:46 AM Changeset in webkit [101175] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

Remove redundant setStrictParsing(false) calls on CSSMappedAttributeDeclarations.
<http://webkit.org/b/73134>

Reviewed by Antti Koivisto.

CSSMappedAttributeDeclarations always use non-strict parsing since they use
the argument-less CSSMutableStyleDeclaration constructor.

  • dom/StyledElement.cpp:

(WebCore::StyledElement::createMappedDecl):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::additionalAttributeStyleDecls):
(WebCore::HTMLTableElement::addSharedCellBordersDecl):
(WebCore::HTMLTableElement::addSharedCellPaddingDecl):
(WebCore::HTMLTableElement::addSharedGroupDecls):

8:19 AM Changeset in webkit [101174] by Martin Robinson
  • 10 edits
    1 move
    3 adds
    4 deletes in trunk

[GTK] Integrate build-gtkdoc into build-webkit and make
https://bugs.webkit.org/show_bug.cgi?id=72626

Reviewed by Philippe Normand.

.:

  • GNUmakefile.am: Remove references to old gtkdoc files. Update

the dist-hook to include copying documentation into the distribution.
This also means that the build will fail if documentation hasn't been
generated before 'make dist.'

  • configure.ac: Ditto.

Source/WebKit/gtk:

  • docs/GNUmakefile.am: Removed.
  • docs/version.xml.in: Removed.

Source/WebKit2:

  • GNUmakefile.am: Removed references to build-gtkdoc and gtkdoc.py.
  • UIProcess/API/gtk/docs/build-gtkdoc: Removed.

Tools:

  • GNUmakefile.am: Added support for new scripts and "make docs".
  • Scripts/webkitdirs.pm: Call generate-gtkdoc when building.

(buildAutotoolsProject):

  • gtk/generate-gtkdoc: Added.
  • gtk/gtkdoc.py: Renamed from Source/WebKit2/UIProcess/API/gtk/docs/gtkdoc.py.
7:14 AM Changeset in webkit [101173] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2011-11-25 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Mark inspector/elements/remove-node.html test as crashing sometimes on Linux.

  • platform/chromium/test_expectations.txt:
7:00 AM QtWebKitBuildBots edited by Csaba Osztrogonác
Update Qt5 on the bots (diff)
6:58 AM BuildingQt5OnHarmattan edited by Csaba Osztrogonác
Update Qt5 revision (diff)
6:44 AM Changeset in webkit [101172] by andreas.kling@nokia.com
  • 16 edits
    1 add in trunk/Source/WebCore

Factor element pointer out of CSSMutableStyleDeclaration.
<http://webkit.org/b/73121>

Reviewed by Antti Koivisto.

Move the StyledElement pointer out of CSSMutableStyleDeclaration and into a subclass
for the cases where it's needed. This reduces the size of vanilla style declarations
by one CPU word (4 or 8 bytes, depending on architecture.)

  • css/CSSMutableStyleDeclaration.h:

(WebCore::CSSElementStyleDeclaration::element):
(WebCore::CSSElementStyleDeclaration::setElement):
(WebCore::CSSElementStyleDeclaration::CSSElementStyleDeclaration):
(WebCore::CSSElementStyleDeclaration::~CSSElementStyleDeclaration):

Added CSSElementStyleDeclaration, a common parent class for inline styles
and mapped attributes. It extends CSSMutableStyleDeclaration by adding a backpointer
to the StyledElement that owns it.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSInlineStyleDeclaration.h: Added.

(WebCore::CSSInlineStyleDeclaration::~CSSInlineStyleDeclaration):
(WebCore::CSSInlineStyleDeclaration::create):
(WebCore::CSSInlineStyleDeclaration::CSSInlineStyleDeclaration):

Added CSSInlineStyleDeclaration.

  • bindings/js/JSDOMBinding.h:

(WebCore::root):

  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::setSelectorText):

Only follow the associated element on CSSElementStyleDeclarations.

  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
(WebCore::CSSMutableStyleDeclaration::operator=):

Remove comment about m_element since the field was moved to a subclass.

  • css/CSSStyleDeclaration.cpp:

(WebCore::CSSStyleDeclaration::CSSStyleDeclaration):

  • css/CSSStyleDeclaration.h:

(WebCore::CSSStyleDeclaration::isElementStyleDeclaration):
(WebCore::CSSStyleDeclaration::isInlineStyleDeclaration):

We no longer need to track whether a style declaration is mutable or not,
so the constructors are slightly simplified.
Added two bits (isElementStyleDeclaration and isInlineStyleDeclaration) for
runtime type checking. These are protected and set by the CSSElementStyleDeclaration
constructor.

  • dom/CSSMappedAttributeDeclaration.h:

(WebCore::CSSMappedAttributeDeclaration::create):
(WebCore::CSSMappedAttributeDeclaration::CSSMappedAttributeDeclaration):

Remove pointless CSSRule* argument to constructor since we always passed 0.

  • dom/StyledElement.h:

(WebCore::StyledElement::inlineStyleDecl):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::createInlineStyleDecl):
(WebCore::StyledElement::getInlineStyleDecl):
(WebCore::StyledElement::addSubresourceAttributeURLs):

Make the inline style on StyledElement a CSSInlineStyleDeclaration.

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::inlineStyleElement):

Slightly simplified by having CSSInlineStyleDeclaration.

6:35 AM Changeset in webkit [101171] by alexis.menard@openbossa.org
  • 3 edits in trunk/Source/WebKit/qt

[Qt][WK2] QWebDownloadItem should be registered in the experimental plugin.
https://bugs.webkit.org/show_bug.cgi?id=73132

Reviewed by Simon Hausmann.

Make sure QWebDownloadItem is registered in the right plugin.

  • declarative/experimental/plugin.cpp:
  • declarative/plugin.cpp:

(WebKitQmlPlugin::registerTypes):

6:32 AM Changeset in webkit [101170] by pfeldman@chromium.org
  • 7 edits in trunk

Web Inspector: unflake timeline-network tests
https://bugs.webkit.org/show_bug.cgi?id=73123

Source/WebCore:

We should capture stack only when it makes sense. Otherwise loading from cache
results in different data sets (stacks) than regular load.

Reviewed by Yury Semikhatsky.

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::willCallFunction):
(WebCore::InspectorTimelineAgent::willDispatchEvent):
(WebCore::InspectorTimelineAgent::willLayout):
(WebCore::InspectorTimelineAgent::willRecalculateStyle):
(WebCore::InspectorTimelineAgent::willPaint):
(WebCore::InspectorTimelineAgent::willWriteHTML):
(WebCore::InspectorTimelineAgent::didInstallTimer):
(WebCore::InspectorTimelineAgent::didRemoveTimer):
(WebCore::InspectorTimelineAgent::willFireTimer):
(WebCore::InspectorTimelineAgent::willChangeXHRReadyState):
(WebCore::InspectorTimelineAgent::willLoadXHR):
(WebCore::InspectorTimelineAgent::willEvaluateScript):
(WebCore::InspectorTimelineAgent::didScheduleResourceRequest):
(WebCore::InspectorTimelineAgent::willReceiveResourceData):
(WebCore::InspectorTimelineAgent::willReceiveResourceResponse):
(WebCore::InspectorTimelineAgent::didFinishLoadingResource):
(WebCore::InspectorTimelineAgent::didTimeStamp):
(WebCore::InspectorTimelineAgent::didMarkDOMContentEvent):
(WebCore::InspectorTimelineAgent::didMarkLoadEvent):
(WebCore::InspectorTimelineAgent::didRegisterAnimationFrameCallback):
(WebCore::InspectorTimelineAgent::didCancelAnimationFrameCallback):
(WebCore::InspectorTimelineAgent::willFireAnimationFrameEvent):
(WebCore::InspectorTimelineAgent::appendRecord):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):

  • inspector/InspectorTimelineAgent.h:
  • inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createGenericRecord):

LayoutTests:

Reviewed by Yury Semikhatsky.

  • platform/chromium/inspector/timeline/timeline-animation-frame-expected.txt:
  • platform/chromium/inspector/timeline/timeline-event-dispatch-expected.txt:
6:19 AM Changeset in webkit [101169] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt] Add support for using OWRT with Qt5
https://bugs.webkit.org/show_bug.cgi?id=72947

Add qt-5.0 platform and don't pass -graphicssystem to QtTestBrowser if using Qt5.

Patch by Ádám Kallai <Kallai.Adam@stud.u-szeged.hu> on 2011-11-25
Reviewed by Csaba Osztrogonác.

  • Scripts/old-run-webkit-tests:
6:17 AM Changeset in webkit [101168] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-11-25 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Chromium build fix.

  • public/WebDevToolsFrontendClient.h: (WebKit::WebDevToolsFrontendClient::sendFrontendLoaded): dowsntream implementation with OVERRIDE modifier fails to compile without this stub.
5:56 AM WebKit Team edited by Alexandru Chiculita
(diff)
5:53 AM Changeset in webkit [101167] by kenneth@webkit.org
  • 2 edits in trunk/Source/WebKit2

Clean up code in WK2/ChromeClientClient related to viewport handling
https://bugs.webkit.org/show_bug.cgi?id=73128

Reviewed by Simon Hausmann.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::contentsSizeChanged):

Make sure that we only call resizeToContentsIfNeeded when we are
using the tiled backing store and fixed layout as well.

Guard the scrollbar code so that it is only called when scroll
delegation is not used. Do similarily for the frameset code,
which makes no sense with frame flattening.

(WebKit::WebChromeClient::dispatchViewportPropertiesDidChange):

This method is only called for the main frame, so the main frame
check has been removed.

5:39 AM Changeset in webkit [101166] by yurys@chromium.org
  • 12 edits in trunk

[Chromium] Web Inspector: get rid of WebDevToolsFrontendClient::sendFrontendLoaded method
https://bugs.webkit.org/show_bug.cgi?id=73126

Source/WebCore:

Notify embedder that front-end is loadded only when all dispatchers, panels and models
have been created so that it could dispatch messages synchronously in the loaded handler.

Reviewed by Pavel Feldman.

  • inspector/front-end/inspector.js:

Source/WebKit/chromium:

No need to have a separate client call for this. The front-end can store messages
which arrive before front-end loaded and dispatch them later. This happens in layout
tests only by the way as all other messages should be initiated by the front-end code.

Reviewed by Pavel Feldman.

  • public/WebDevToolsFrontendClient.h:
  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::attach):
(WebKit::WebDevToolsAgentImpl::frontendLoaded):

  • src/WebDevToolsFrontendImpl.cpp:

(WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl):
(WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend):
(WebKit::WebDevToolsFrontendImpl::frontendLoaded):
(WebKit::WebDevToolsFrontendImpl::doDispatchOnInspectorFrontend):

  • src/WebDevToolsFrontendImpl.h:

Tools:

No need to have a separate client call for this. The front-end can store messages
which arrive before front-end loaded and dispatch them later. This happens in layout
tests only by the way as all other messages should be initiated by the front-end code.

Reviewed by Pavel Feldman.

  • DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
  • DumpRenderTree/chromium/DRTDevToolsAgent.h:
  • DumpRenderTree/chromium/DRTDevToolsClient.cpp:
  • DumpRenderTree/chromium/DRTDevToolsClient.h:
4:54 AM Changeset in webkit [101165] by Simon Hausmann
  • 3 edits in trunk/Source/WebKit2

[Qt] Eliminate warnings about the deprecated QQuickCanvas::sceneGraphEngine() function.

Reviewed by Andreas Kling.

We use the function in question to find out if we can connect to the scene graph's
afterRendering signal. The signal has been moved into QQuickCanvas right away, so
we can connect to it as soon as we have a canvas.

  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPagePrivate::initializeSceneGraphConnections):

  • UIProcess/API/qt/qquickwebpage_p.h:
4:48 AM Changeset in webkit [101164] by jesus@webkit.org
  • 9 edits
    2 adds in trunk/Source/WebKit2

[Qt][WK2] Move event handling out of QtWebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=73089

Reviewed by Kenneth Rohde Christiansen.

Move all logic related to event handling, gestures and the
interaction engine out of QtWebPageProxy, creating a separate
class called QtWebPageEventHandler. This handler will be created
by the QQuickWebViewPrivate and will be registered into QtWebPageProxy.
QQuickWebPage will now call handleEvent through this entity.

  • Target.pri:
  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPage::event):

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::initializeDesktop):
(QQuickWebViewPrivate::initializeTouch):

  • UIProcess/API/qt/qquickwebview_p_p.h:
  • UIProcess/qt/QtTapGestureRecognizer.cpp:

(WebKit::QtTapGestureRecognizer::QtTapGestureRecognizer):
(WebKit::QtTapGestureRecognizer::recognize):
(WebKit::QtTapGestureRecognizer::tapTimeout):

  • UIProcess/qt/QtTapGestureRecognizer.h:
  • UIProcess/qt/QtWebPageEventHandler.cpp: Added.

(QtWebPageEventHandler::dragOperationToDropAction):
(QtWebPageEventHandler::dragOperationToDropActions):
(QtWebPageEventHandler::dropActionToDragOperation):
(QtWebPageEventHandler::QtWebPageEventHandler):
(QtWebPageEventHandler::~QtWebPageEventHandler):
(QtWebPageEventHandler::handleEvent):
(QtWebPageEventHandler::handleMouseMoveEvent):
(QtWebPageEventHandler::handleMousePressEvent):
(QtWebPageEventHandler::handleMouseReleaseEvent):
(QtWebPageEventHandler::handleMouseDoubleClickEvent):
(QtWebPageEventHandler::handleWheelEvent):
(QtWebPageEventHandler::handleHoverLeaveEvent):
(QtWebPageEventHandler::handleHoverMoveEvent):
(QtWebPageEventHandler::handleDragEnterEvent):
(QtWebPageEventHandler::handleDragLeaveEvent):
(QtWebPageEventHandler::handleDragMoveEvent):
(QtWebPageEventHandler::handleDropEvent):
(QtWebPageEventHandler::handleSingleTapEvent):
(QtWebPageEventHandler::handleDoubleTapEvent):
(QtWebPageEventHandler::timerEvent):
(QtWebPageEventHandler::handleKeyPressEvent):
(QtWebPageEventHandler::handleKeyReleaseEvent):
(QtWebPageEventHandler::handleFocusInEvent):
(QtWebPageEventHandler::handleFocusOutEvent):
(QtWebPageEventHandler::setViewportInteractionEngine):
(QtWebPageEventHandler::touchEvent):
(QtWebPageEventHandler::resetGestureRecognizers):
(QtWebPageEventHandler::doneWithTouchEvent):
(QtWebPageEventHandler::didFindZoomableArea):

  • UIProcess/qt/QtWebPageEventHandler.h: Added.
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::init):
(QtWebPageProxy::didFindZoomableArea):
(QtWebPageProxy::processDidCrash):
(QtWebPageProxy::startDrag):
(QtWebPageProxy::doneWithTouchEvent):

  • UIProcess/qt/QtWebPageProxy.h:

(QtWebPageProxy::eventHandler):

4:12 AM Changeset in webkit [101163] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: don't send Console.messagesCleared on front-end connection if console agent is not enabled
https://bugs.webkit.org/show_bug.cgi?id=73122

Console agent should stay silent if it is not enabled.

Reviewed by Pavel Feldman.

  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::clearMessages):
(WebCore::InspectorConsoleAgent::addConsoleMessage):

3:39 AM Changeset in webkit [101162] by Simon Hausmann
  • 9 edits
    1 add in trunk/Source/WebKit2

[Qt] Cleanup in QML tests.

Reviewed by Tor Arne Vestbø.

Use a simple QML component for the "DesktopWebView" instead of a new QML type.
This will allow the use of the experimental extension in the future.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewExperimental::useTraditionalDesktopBehaviour):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/DesktopWebView.qml: Added.
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_messaging.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml:
  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
  • UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp:

(main):

2:57 AM Changeset in webkit [101161] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Source/WebCore

Upstream the QNX/RIM specific HistoryItemViewState
https://bugs.webkit.org/show_bug.cgi?id=73114

Patch by Wei Charles <charles.wei@torchmobile.com.cn> on 2011-11-25
Reviewed by Daniel Bates.

This patch is to upstream RIM/QNX specific HistoryItemViewState extension
to store some extra view state.

No new tests. It's not built yet.

  • history/blackberry: Added.
  • history/blackberry/HistoryItemViewState.h: Added.

(WebCore::HistoryItemViewState::HistoryItemViewState):

2:33 AM Changeset in webkit [101160] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Split scripts panel top status bar into debug toolbar and editor toolbar.
https://bugs.webkit.org/show_bug.cgi?id=73087

Reviewed by Pavel Feldman.

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._reset):
(WebInspector.ScriptsPanel.prototype._createEditorToolbar):
(WebInspector.ScriptsPanel.prototype._createDebugToolbar):
(WebInspector.ScriptsPanel.prototype._createButtonAndRegisterShortcuts):

  • inspector/front-end/scriptsPanel.css:

(#scripts-debug-toolbar):
(#scripts-editor-toolbar):
(#scripts-debug-sidebar-resizer-widget):
(.script-view):

2:06 AM Changeset in webkit [101159] by leo.yang@torchmobile.com.cn
  • 1 edit
    3 adds in trunk/Source/WebCore

Upstream BlackBerry porting of platform/text
https://bugs.webkit.org/show_bug.cgi?id=73117

Reviewed by Daniel Bates.

Initial upstream, can't be built yet, no test cases.

  • platform/text/blackberry/StringBlackBerry.cpp: Added.

(WTF::String::String):
(WTF::String::operator WebString):

  • platform/text/blackberry/TextBreakIteratorInternalICUBlackBerry.cpp: Added.

(WebCore::currentSearchLocaleID):
(WebCore::currentTextBreakLocaleID):

1:41 AM Changeset in webkit [101158] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

Web Inspector: resource-tree-errors-reload.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=66217

Reviewed by Yury Semikhatsky.

  • platform/chromium/test_expectations.txt:
1:31 AM Changeset in webkit [101157] by haraken@chromium.org
  • 3 edits
    1 delete in trunk/Source/WebCore

Remove WebCore.gyp/scripts/rule_binding.py
https://bugs.webkit.org/show_bug.cgi?id=73109

Reviewed by Adam Barth.

rule_binding.py is used by WebCore.gyp only. rule_binding.py is just a wrapper
of generate-bindings.pl and thus we can remove it.

No new tests. No change in behavior.

  • WebCore.gyp/WebCore.gyp: Replaces rule_binding.py with generate-bindings.pl.
  • WebCore.gyp/scripts/rule_binding.py: Removed.
  • bindings/scripts/preprocessor.pm: When '"ENABLE_SOMETHING=1" "ENABLE_OTHERS=0"' is passed as a define macro, the string is passed to our perl scripts without the double-quotations (") omitted. We need to omit the double quatations here.

(applyPreprocessor):

1:29 AM Changeset in webkit [101156] by yurys@chromium.org
  • 15 edits
    4 deletes in trunk

[Chromium] Web Inspector: remove legacy debugger support
https://bugs.webkit.org/show_bug.cgi?id=73081

Removed classed providing access to V8 debugging protocol. Clients should
use Web Inspector protocol instead.

Reviewed by Pavel Feldman.

Source/WebCore:

  • bindings/v8/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::PageScriptDebugServer):
(WebCore::PageScriptDebugServer::addListener):

  • bindings/v8/PageScriptDebugServer.h:

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebDevToolsAgent.h:
  • public/WebDevToolsAgentClient.h:
  • src/DebuggerAgentImpl.cpp: Removed.
  • src/DebuggerAgentImpl.h: Removed.
  • src/DebuggerAgentManager.cpp: Removed.
  • src/DebuggerAgentManager.h: Removed.
  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::WebDevToolsAgentImpl):
(WebKit::WebDevToolsAgentImpl::~WebDevToolsAgentImpl):
(WebKit::WebDevToolsAgentImpl::attach):
(WebKit::WebDevToolsAgentImpl::detach):
(WebKit::WebDevToolsAgentImpl::didNavigate):
(WebKit::WebDevToolsAgentImpl::didClearWindowObject):

  • src/WebDevToolsAgentImpl.h:
1:25 AM Changeset in webkit [101155] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-11-25 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium deps revision to 111575

  • DEPS:
1:23 AM Changeset in webkit [101154] by pfeldman@chromium.org
  • 26 edits in trunk

Web Inspector: refactor resource tree model and introduce explicit class for ResourceTreeFrame.
https://bugs.webkit.org/show_bug.cgi?id=73078

Otherwise we are managing frames and their resources using too many maps.

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/Inspector.json:
  • inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::restore):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::didReceiveResponse):

  • inspector/front-end/ApplicationCacheModel.js:

(WebInspector.ApplicationCacheModel.prototype._frameNavigated):
(WebInspector.ApplicationCacheModel.prototype._frameDetached):

  • inspector/front-end/JavaScriptContextManager.js:

(WebInspector.JavaScriptContextManager.prototype._frameAdded):
(WebInspector.JavaScriptContextManager.prototype._frameNavigated):
(WebInspector.FrameEvaluationContext.prototype.get displayName):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
(WebInspector.NetworkDispatcher.prototype.responseReceived):
(WebInspector.NetworkDispatcher.prototype.loadingFinished):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._mainFrameNavigated):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel):
(WebInspector.ResourceTreeModel.prototype._fetchResourceTree):
(WebInspector.ResourceTreeModel.prototype._processCachedResources):
(WebInspector.ResourceTreeModel.prototype._addFrame):
(WebInspector.ResourceTreeModel.prototype._frameNavigated):
(WebInspector.ResourceTreeModel.prototype._frontendReused):
(WebInspector.ResourceTreeModel.prototype._frameDetached):
(WebInspector.ResourceTreeModel.prototype._onResourceUpdated):
(WebInspector.ResourceTreeModel.prototype._onResourceUpdateDropped):
(WebInspector.ResourceTreeModel.prototype.frameForId):
(WebInspector.ResourceTreeModel.prototype.forAllResources):
(WebInspector.ResourceTreeModel.prototype.resourceForURL):
(WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
(WebInspector.ResourceTreeModel.prototype._createResourceFromFramePayload):
(WebInspector.ResourceTreeModel.prototype._createResource):
(WebInspector.ResourceTreeFrame):
(WebInspector.ResourceTreeFrame.prototype.get id):
(WebInspector.ResourceTreeFrame.prototype.get name):
(WebInspector.ResourceTreeFrame.prototype.get url):
(WebInspector.ResourceTreeFrame.prototype.get loaderId):
(WebInspector.ResourceTreeFrame.prototype.get parentFrame):
(WebInspector.ResourceTreeFrame.prototype.get childFrames):
(WebInspector.ResourceTreeFrame.prototype.isMainFrame):
(WebInspector.ResourceTreeFrame.prototype.navigate):
(WebInspector.ResourceTreeFrame.prototype.get mainResource):
(WebInspector.ResourceTreeFrame.prototype.addChildFrame):
(WebInspector.ResourceTreeFrame.prototype.removeChildFrame):
(WebInspector.ResourceTreeFrame.prototype._addResource):
(WebInspector.ResourceTreeFrame.prototype.resources):
(WebInspector.ResourceTreeFrame.prototype.resourceForURL.filter):
(WebInspector.ResourceTreeFrame.prototype.resourceForURL):
(WebInspector.ResourceTreeFrame.prototype._callForFrameResources):
(WebInspector.PageDispatcher.prototype.frameNavigated):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype.wasShown):
(WebInspector.ResourcesPanel.prototype._initialize):
(WebInspector.ResourcesPanel.prototype._resetWithFrames):
(WebInspector.ResourcesPanel.prototype._reset):
(WebInspector.ResourcesPanel.prototype._populateResourceTree.populateFrame):
(WebInspector.ResourcesPanel.prototype._populateResourceTree):
(WebInspector.ResourcesPanel.prototype._frameAdded):
(WebInspector.ResourcesPanel.prototype._frameDetached):
(WebInspector.ResourcesPanel.prototype._frameNavigated):
(WebInspector.ResourcesPanel.prototype._cachedResourcesLoaded):

  • inspector/front-end/ScriptFormatter.js:

(WebInspector.ScriptFormatter.prototype.formatContent):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):

LayoutTests:

  • http/tests/inspector/inspector-test.js:
  • http/tests/inspector/resource-tree/resource-tree-document-url.html:
  • http/tests/inspector/resource-tree/resource-tree-errors-reload.html:
  • http/tests/inspector/resource-tree/resource-tree-frame-add.html:
  • http/tests/inspector/resource-tree/resource-tree-mimetype.html:
  • http/tests/inspector/resource-tree/resource-tree-test.js:

(initialize_ResourceTreeTest.InspectorTest.dumpResourcesURLMap.collect):

  • http/tests/inspector/resources-test.js:

(initialize_ResourceTest.InspectorTest.runAfterCachedResourcesProcessed):
(initialize_ResourceTest.InspectorTest.runAfterResourcesAreFinished.checkResources.visit):
(initialize_ResourceTest.InspectorTest.runAfterResourcesAreFinished.checkResources):
(initialize_ResourceTest.InspectorTest.runAfterResourcesAreFinished):
(initialize_ResourceTest.InspectorTest.showResource.showResourceCallback.visit):
(initialize_ResourceTest.InspectorTest.showResource):
(initialize_ResourceTest):

  • inspector/debugger/source-frame.html:
  • inspector/styles/css-live-edit.html:
  • inspector/styles/styles-history.html:
  • platform/qt/Skipped:

Nov 24, 2011:

11:10 PM Changeset in webkit [101153] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Initialize global variables during IDLParser object creation
https://bugs.webkit.org/show_bug.cgi?id=73108

Reviewed by Adam Barth.

Currently, IDLParser.pm initializes global variables in a global scope,
which means that the global variables are initialized just once at the beginning.
On the other hand, implementing [Supplemental] IDL (bug 72138) requires a change
on generate-bindings.pl that initializes the global variables whenever a new IDLParser
object is created. Thus, this patch initializes the global variables during
the IDLParser object creation.

No new tests. No change in behavior.

  • bindings/scripts/IDLParser.pm:

(InitializeGlobalData):
(new):

10:55 PM Changeset in webkit [101152] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

UString methods are not character size aware
https://bugs.webkit.org/show_bug.cgi?id=72975

Changed the UString number constructors to build 8 bit strings.
Modified the other methods to check string bitness and process
with 8 bits wherre appropriate.

  • runtime/UString.cpp:

(JSC::UString::number):
(JSC::operator==):
(JSC::operator<):
(JSC::UString::ascii):

10:47 PM Changeset in webkit [101151] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JavaScript string to number conversion functions use characters()
https://bugs.webkit.org/show_bug.cgi?id=72974

Change the various JS to number routines to process strings
using characters8() or characters16() as appropriate.
Implemented using static template methods.

Reviewed by Filip Pizlo.

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::isInfinity):
(JSC::jsHexIntegerLiteral):
(JSC::jsStrDecimalLiteral):
(JSC::toDouble):
(JSC::jsToNumber):

10:44 PM Changeset in webkit [101150] by haraken@chromium.org
  • 2 edits in trunk/Tools

Replace subprocess.call() with subprocess.Popen()
https://bugs.webkit.org/show_bug.cgi?id=73105

Reviewed by Adam Barth.

Currently, the stdout and stderr of the child processes of run-bindings-tests
are mixed (or even gone away) with the stdout and stderr of run-bindings-tests itself.
This is the problem of subprocess.call(), which does not synchronize the stdout and stderr
between a parent process and a child process. This patch replaces subprocess.call() with
subprocess.Popen() and synchronizes the stdout and stderr between them.
This patch also makes output messages of run-bindings-tests more readable.

With this patch, the output messages of run-bindings-tests look like as follows:

PASS: (CPP) WebDOMTestObj.h
PASS: (CPP) WebDOMTestObj.cpp
FAIL: (CPP) WebDOMTestInterface.h
--- Source/WebCore/bindings/scripts/test/CPP/WebDOMTestInterface.h 2011-11-25 13:34:09.313516268 +0900
+++ /tmp/tmpDAV87G/WebDOMTestInterface.h 2011-11-25 13:44:42.712946812 +0900
@@ -23,7 +23,7 @@

#ifndef WebDOMTestInterface_h
#define WebDOMTestInterface_h

-#if ENABLE(Condition1) +#if ENABLE(Condition1)
ENABLE(Condition2)
ENABLE(Condition3)

#include <WebDOMObject.h>
#include <WebDOMString.h>
@@ -53,5 +53,5 @@
WebDOMTestInterface toWebKit(WebCore::TestInterface*);

#endif

-#endif ENABLE(Condition1) +#endif ENABLE(Condition1)
ENABLE(Condition2)
ENABLE(Condition3)

PASS: (CPP) WebDOMFloat64Array.cpp
PASS: (CPP) WebDOMFloat64Array.h

Some tests FAIL! (To update the reference files, execute "run-bindings-tests --reset-results")

  • Scripts/run-bindings-tests:

(generate_from_idl):
(detect_changes):
(run_tests):
(main):

10:36 PM Changeset in webkit [101149] by haraken@chromium.org
  • 2 edits in trunk/Tools

Fix the current working directory of run-bindings-tests
https://bugs.webkit.org/show_bug.cgi?id=73106

Reviewed by Adam Barth.

Currently, run-bindings-tests outputs the following error
(although it outputs "all tests passed!" in the end):

Testing the ObjC generator on TestObj.idl
gcc: WebCore/bindings/objc/PublicDOMInterfaces.h: No such file or directory
gcc: warning: '-x objective-c' after last input file has no effect
gcc: no input files

This is because CodeGeneratorObjC.pm assumes that the current working directory
is WebKit/Source/, but run-bindings-tests sets the current working directory to WebKit/.
Thus, this patch changes it to WebKit/Source/.

  • Scripts/run-bindings-tests:

(generate_from_idl):
(main):

10:35 PM Changeset in webkit [101148] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Empty JSStrings are created as 16 bit
https://bugs.webkit.org/show_bug.cgi?id=72968

Clear m_is8Bit flag for empty strings.

Reviewed by Filip Pizlo.

  • runtime/JSString.h:

(JSC::RopeBuilder::finishCreation):

10:23 PM Changeset in webkit [101147] by msaboff@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Tune JSStringBuilder for 8 bit Strings
https://bugs.webkit.org/show_bug.cgi?id=72683

Changed JSStringBuilder to use 8 bit buffers until 16 bit data is added.
When 16 bit data is to be added, the 8 bit buffer is converted to 16 bit
and building continues with a 16 bit buffer.

Reviewed by Filip Pizlo.

  • runtime/JSStringBuilder.h:

(JSC::JSStringBuilder::JSStringBuilder):
(JSC::JSStringBuilder::append):
(JSC::JSStringBuilder::upConvert):
(JSC::JSStringBuilder::build):

  • runtime/UString.h:

(JSC::UString::adopt):

  • wtf/text/StringImpl.h:

(WTF::StringImpl::adopt):

3:23 PM Changeset in webkit [101146] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

[CMake] Build fix for NOT ENABLE_WEB_SOCKETS.

  • CMakeLists.txt: Move CloseEvent.idl to the unconditional files.
3:16 PM Changeset in webkit [101145] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Build fix for C++ bindings.

  • bindings/cpp/WebDOMEventTarget.cpp: Added #if ENABLE() guards.
12:03 PM Changeset in webkit [101144] by commit-queue@webkit.org
  • 23 edits
    23 adds in trunk

Microdata: Support for properties attribute.
https://bugs.webkit.org/show_bug.cgi?id=71050

Patch by Arko Saha <arko@motorola.com> on 2011-11-24
Reviewed by Adam Barth.

Source/WebCore:

The properties attribute returns an HTMLPropertiesCollection object with all the element's
properties. Otherwise, an empty HTMLPropertiesCollection object.

Tests: fast/dom/MicroData/itemref-refers-first-element-with-given-id.html

fast/dom/MicroData/names-property-must-be-correct.html
fast/dom/MicroData/names-property-test.html
fast/dom/MicroData/properties-collection-add-remove-itemref.html
fast/dom/MicroData/properties-collection-add-remove-property.html
fast/dom/MicroData/properties-collection-behavior-add-remove-itemscope-attr.html
fast/dom/MicroData/properties-collection-must-be-correct.html
fast/dom/MicroData/properties-collection-must-ignore-properties-of-nested-items.html
fast/dom/MicroData/properties-collection-must-see-the-properties-added-in-itemref.html
fast/dom/MicroData/properties-collection-test.html

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/gobject/GNUmakefile.am:
  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::toJS):

  • dom/MicroDataItemList.cpp:
  • dom/Node.cpp:

(WebCore::Node::itemProp):
(WebCore::Node::setItemProp):
(WebCore::Node::itemRef):
(WebCore::Node::setItemRef):
(WebCore::Node::itemType):
(WebCore::Node::setItemType):
(WebCore::Node::properties):

  • dom/Node.h:
  • dom/NodeRareData.h:

(WebCore::NodeRareData::itemProp):
(WebCore::NodeRareData::setItemProp):
(WebCore::NodeRareData::itemRef):
(WebCore::NodeRareData::setItemRef):
(WebCore::NodeRareData::itemType):
(WebCore::NodeRareData::setItemType):
(WebCore::NodeRareData::properties):

  • html/CollectionType.h:
  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::itemAfter):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::setItemValueText):

  • html/HTMLElement.h:
  • html/HTMLElement.idl:
  • html/HTMLPropertiesCollection.cpp: Added.

(WebCore::compareTreeOrder):
(WebCore::HTMLPropertiesCollection::create):
(WebCore::HTMLPropertiesCollection::HTMLPropertiesCollection):
(WebCore::HTMLPropertiesCollection::~HTMLPropertiesCollection):
(WebCore::HTMLPropertiesCollection::findPropetiesOfAnItem): Finds the properties of an item.
(WebCore::HTMLPropertiesCollection::length): Returns the number of elements in the properties collection.
(WebCore::HTMLPropertiesCollection::item): Returns the element with index 'index' from the collection. The items are sorted in tree order.
(WebCore::HTMLPropertiesCollection::names): Returns a DOMStringList with the property names of the elements in the collection with the order preserved but with duplicates removed.

  • html/HTMLPropertiesCollection.h: Added.
  • html/HTMLPropertiesCollection.idl: Added.
  • page/DOMWindow.idl:

LayoutTests:

Added test for html properties collections.

  • fast/dom/MicroData/itemref-refers-first-element-with-given-id-expected.txt: Added.
  • fast/dom/MicroData/itemref-refers-first-element-with-given-id.html: Added.
  • fast/dom/MicroData/names-property-must-be-correct-expected.txt: Added.
  • fast/dom/MicroData/names-property-must-be-correct.html: Added.
  • fast/dom/MicroData/names-property-test-expected.txt: Added.
  • fast/dom/MicroData/names-property-test.html: Added.
  • fast/dom/MicroData/properties-collection-add-remove-itemref-expected.txt: Added.
  • fast/dom/MicroData/properties-collection-add-remove-itemref.html: Added.
  • fast/dom/MicroData/properties-collection-add-remove-property-expected.txt: Added.
  • fast/dom/MicroData/properties-collection-add-remove-property.html: Added.
  • fast/dom/MicroData/properties-collection-behavior-add-remove-itemscope-attr-expected.txt: Added.
  • fast/dom/MicroData/properties-collection-behavior-add-remove-itemscope-attr.html: Added.
  • fast/dom/MicroData/properties-collection-must-be-correct-expected.txt: Added.
  • fast/dom/MicroData/properties-collection-must-be-correct.html: Added.
  • fast/dom/MicroData/properties-collection-must-ignore-properties-of-nested-items-expected.txt: Added.
  • fast/dom/MicroData/properties-collection-must-ignore-properties-of-nested-items.html: Added.
  • fast/dom/MicroData/properties-collection-must-see-the-properties-added-in-itemref-expected.txt: Added.
  • fast/dom/MicroData/properties-collection-must-see-the-properties-added-in-itemref.html: Added.
  • fast/dom/MicroData/properties-collection-test-expected.txt: Added.
  • fast/dom/MicroData/properties-collection-test.html: Added.
10:25 AM Changeset in webkit [101143] by fsamuel@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Removed obsolete touchui flag
https://bugs.webkit.org/show_bug.cgi?id=73067

Reviewed by Tony Chang.

  • features.gypi:
10:10 AM Changeset in webkit [101142] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

IndexedDB: Indexes should be secondarily sorted on primary key
https://bugs.webkit.org/show_bug.cgi?id=72567

Patch by Joshua Bell <jsbell@chromium.org> on 2011-11-24
Reviewed by Tony Chang.

Source/WebCore:

Implemented by adding the primary key (i.e. unique key in the
object store) to the IndexDataKey (i.e. the composite key used
in the index. Previously, non-unique entries in the index were
stored with a unique (and hidden) sequenceNumber, so ordering was
not predictable by scripts (or per spec). The sequenceNumber
is now deprecated but still present in the LevelDB backing store
to avoid having to do a data migration.

Test: storage/indexeddb/cursor-primary-key-order.html

  • storage/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):

  • storage/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::compare):
(WebCore::IDBLevelDBCoding::IndexDataKey::decode):
(WebCore::IDBLevelDBCoding::IndexDataKey::encode):
(WebCore::IDBLevelDBCoding::IndexDataKey::compare):
(WebCore::IDBLevelDBCoding::IndexDataKey::primaryKey):

  • storage/IDBLevelDBCoding.h:

Source/WebKit/chromium:

Updates the IndexDataKey unit tests to include primary keys. The
deprecated sequenceNumber element of IndexDataKey is still tested,
although no longer used by callers.

  • tests/IDBLevelDBCodingTest.cpp:

(IDBLevelDBCoding::TEST):

LayoutTests:

  • storage/indexeddb/cursor-primary-key-order-expected.txt: Added.
  • storage/indexeddb/cursor-primary-key-order.html: Added.
8:51 AM Changeset in webkit [101141] by zeno.albisser@nokia.com
  • 15 edits in trunk/Source

[Qt]WK2][Mac] Use Mac port's IPC implementation instead of Unix sockets
https://bugs.webkit.org/show_bug.cgi?id=72495

Source/JavaScriptCore:

Update defines to not use Unix Domain Sockets for platform Qt on Mac.
This enables Qt to reuse existing code for mach ports and Grand
Central Dispatch based IPC.

Reviewed by Simon Hausmann.

  • wtf/Platform.h:

Source/WebKit2:

Make Qt using mach ports and Grand Central Dispatch for IPC
when building on Mac.

Reviewed by Simon Hausmann.

  • Platform/CoreIPC/Attachment.cpp:
  • Platform/CoreIPC/Attachment.h:
  • Platform/CoreIPC/Connection.h:
  • Platform/CoreIPC/CoreIPCMessageKinds.h:
  • Platform/SharedMemory.h:
  • Platform/WorkQueue.h:
  • Platform/mac/MachUtilities.cpp:
  • Platform/mac/WorkQueueMac.cpp:
  • Target.pri:
  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:

(WebKit::ProcessLauncher::launchProcess):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didFinishLaunching):

  • WebProcess/qt/WebProcessMainQt.cpp:

(WebKit::WebProcessMainQt):

8:36 AM Changeset in webkit [101140] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: WebInspector.inspectedPageDomain is not calculated for about:blank
https://bugs.webkit.org/show_bug.cgi?id=73082

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-24
Reviewed by Timothy Hatcher.

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype._processCachedResources):
(WebInspector.ResourceTreeModel.prototype._frameNavigated):
(WebInspector.ResourceTreeModel.prototype._addFramesRecursively):

  • inspector/front-end/inspector.js:

(WebInspector.networkResourceById):
(WebInspector.get inspectedPageDomain):

8:02 AM WebKitGTK/AddingNewWebKit2API edited by Carlos Garcia Campos
Remove point about gobject properties (diff)
7:12 AM Changeset in webkit [101139] by caseq@chromium.org
  • 9 edits in trunk/Source/WebCore

Web Inspector: provide context menu items to open resources using extensions
https://bugs.webkit.org/show_bug.cgi?id=73076

Reviewed by Yury Semikhatsky.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onSetOpenResourceHandler):
(WebInspector.ExtensionServer.prototype._handleOpenURL):

  • inspector/front-end/HandlerRegistry.js:

(get WebInspector.HandlerRegistry.prototype.set dispatch):
(get WebInspector.HandlerRegistry.prototype.dispatchToHandler):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.populateTextAreaContextMenu):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):

  • inspector/front-end/externs.js:

(WebInspector.populateResourceContextMenu):

  • inspector/front-end/inspector.js:

(WebInspector.populateResourceContextMenu):
(WebInspector._showAnchorLocation):

6:57 AM Changeset in webkit [101138] by Philippe Normand
  • 6 edits
    2 adds in trunk/Source/WebCore

[GStreamer] WebAudio AudioDestination
https://bugs.webkit.org/show_bug.cgi?id=69835

Reviewed by Martin Robinson.

New GStreamer source element pulling data from the AudioBus and
outputing audio interleaved GstBuffers suitable for playback.

  • GNUmakefile.list.am: Added the new GStreamer WebAudio element

source files to the build.

  • platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(WebCore::onGStreamerWavparsePadAddedCallback): Function called
when the playback pipeline successfully parsed the audio source
into a WAV stream.
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
Configure the initial playback pipeline up to the WAV parser. The
audio sink is added only after the WAV parser was configured.
(WebCore::AudioDestinationGStreamer::~AudioDestinationGStreamer):
Reset the playback pipeline and delete it.
(WebCore::AudioDestinationGStreamer::finishBuildingPipelineAfterWavParserPadReady):
Method to add the audio sink to the pipeline and link it to the
WAV parser.
(WebCore::AudioDestinationGStreamer::start): Set pipeline to
PLAYING, at the first run it will trigger the WAV parser and hence
the audio-sink plugging.
(WebCore::AudioDestinationGStreamer::stop): Pause the pipeline.

  • platform/audio/gstreamer/AudioDestinationGStreamer.h:
  • platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp: Added.

(getGStreamerMonoAudioCaps): Utility function to generate
GStreamer caps representing a single audio channel for a given
sample rate.
(webKitWebAudioGStreamerChannelPosition): Utility function to
convert AudioBus channel representations to GStreamer positional
audio channel values.
(webkit_web_audio_src_class_init): GObject configuration of the
GStreamer source element.
(webkit_web_audio_src_init): Initialization of the private data of
the element.
(webKitWebAudioSourceConstructed): Configure the GstBin elements
depending on the AudioBus layout.
(webKitWebAudioSourceFinalize): Clean up the GstBin and free private
data of the element.
(webKitWebAudioSourceSetProperty): GObject property setter.
(webKitWebAudioSourceGetProperty): GObject property getter.
(webKitWebAudioSourceLoop): GstTask used to pull data from the
AudioBus and push it as GstBuffers to the src pad of the element.
(webKitWebAudioSourceChangeState): Start or stop the above GstTask
depending on the asked state transition.

  • platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.h: Added.
  • platform/graphics/gstreamer/GRefPtrGStreamer.cpp: GstTask support in GRefPtr.

(WTF::adoptGRef):
(WTF::GstTask):

  • platform/graphics/gstreamer/GRefPtrGStreamer.h:
5:45 AM Changeset in webkit [101137] by jknotten@chromium.org
  • 1 edit in branches/chromium/912/LayoutTests/platform/chromium/test_expectations.txt

Fix test expectations.

http://codereview.chromium.org/8682014/

5:45 AM Changeset in webkit [101136] by Simon Hausmann
  • 4 edits in trunk/Source/WebKit2

[Qt][WK2] Stop leaking memory in string QWK2 API's
https://bugs.webkit.org/show_bug.cgi?id=72558

Patch by Oleg Romashin <romaxa@gmail.com> on 2011-11-17
Reviewed by Simon Hausmann.

WKRef API pointers don't adopt the implementation pointers by default and the implementation pointers
stay alive after destroying the API pointers.
This patch adopts the implementation pointers correctly by using adoptWK that returns a WKRetainPtr
that will be around temporarily and correctly release the object.

  • UIProcess/qt/QtWebPageUIClient.cpp:

(QtWebPageUIClient::mouseDidMoveOverElement):

  • UIProcess/qt/QtDownloadManager.cpp:

(WebKit::qt_wk_didFailDownload):

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::load):
(QtWebPageProxy::url):
(QtWebPageProxy::title):

5:35 AM Changeset in webkit [101135] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Add implementation considering ewk_tiled_backing_store's visible status.
https://bugs.webkit.org/show_bug.cgi?id=71791

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-11-24
Reviewed by Gustavo Noronha Silva.

In order to prevent rendering and pre-rendering while backing store is hidden,
its visibility is checked and pre-rendering is handled whenever backing store is shown or hidden.

  • ewk/ewk_tiled_backing_store.cpp:

(_ewk_tiled_backing_store_item_process_idler_start):
(_ewk_tiled_backing_store_item_fill):
(_ewk_tiled_backing_store_smart_show):
(_ewk_tiled_backing_store_smart_hide):
(ewk_tiled_backing_store_add):

5:27 AM Changeset in webkit [101134] by Simon Hausmann
  • 2 edits in trunk/Source/JavaScriptCore

[Qt] REGRESSION(r101131): WTF::scheduleDispatchFunctionsOnMainThread() doesn't work reliably

Reviewed by Andreas Kling.

We must make sure that the MainThreadInvoker object lives in the gui thread. There are a few
ways of doing that and this fix seems like the least intrusive one by simply pushing the
invoker to the gui thread if it's not there already.

  • wtf/qt/MainThreadQt.cpp:

(WTF::scheduleDispatchFunctionsOnMainThread):

5:07 AM Changeset in webkit [101133] by vestbo@webkit.org
  • 13 edits in trunk

[Qt] Get rid of the buildDirForSource() function in the build system

At some point the plan was to allow for running qmake on sub-trees
of the sources, into the top level build directory, but this is no
longer possible, so no reason to keep the convenience function around.

Reviewed by Simon Hausmann.

5:03 AM Changeset in webkit [101132] by Patrick Gansterer
  • 4 edits in trunk/Source

[CMake] Add missing source files
https://bugs.webkit.org/show_bug.cgi?id=73052

Reviewed by Andreas Kling.

Source/WebCore:

  • CMakeLists.txt:

Source/WebKit2:

Add more generic files to the sources list and remove the EFL specific stuff.

  • CMakeLists.txt:
3:37 AM Changeset in webkit [101131] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

[Qt] Use QEvent for dispatchFunctionsFromMainThread()
https://bugs.webkit.org/show_bug.cgi?id=72704

Reviewed by Simon Hausmann.

Replace QMetaObject::invokeMethod with QCoreApplication::postEvent.
This is the same as what invokeMethod does internally, but reduces
the dependency on some internal QThread stuff.

  • wtf/qt/MainThreadQt.cpp:

(WTF::MainThreadInvoker::MainThreadInvoker):
(WTF::MainThreadInvoker::event):
(WTF::scheduleDispatchFunctionsOnMainThread):

1:47 AM Changeset in webkit [101130] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

Fix ASSERTs added in r101082.

Rubber-Stamped by Martin Robinson.

  • platform/graphics/gstreamer/GRefPtrGStreamer.cpp:

(WTF::adoptGRef): Check for valid pointer before
GST_OBJECT_IS_FLOATING().

1:37 AM Changeset in webkit [101129] by apavlov@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: shift focus to the source view when a resource is selected in the Scripts panel
https://bugs.webkit.org/show_bug.cgi?id=69738

Reviewed by Timothy Hatcher.

The source viewer is focused whenever a file name option is clicked, and is NOT focused when the script list
is traversed with the Up/Down keys.

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._filesSelectChanged):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.focus):

  • inspector/front-end/TextViewer.js:

(WebInspector.TextViewer.prototype.focus):

1:10 AM Changeset in webkit [101128] by podivilov@chromium.org
  • 11 edits
    5 adds in trunk

Web Inspector: add integration test for compiler source maps.
https://bugs.webkit.org/show_bug.cgi?id=72730

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/compiler-source-mapping-debug.html

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype._bindScriptToRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype.setCompilerSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype.get executionLineLocation):
(WebInspector.DebuggerPresentationModel.DefaultLinkifierFormatter.prototype.formatRawSourceCodeAnchor):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor):

LayoutTests:

  • http/tests/inspector/compiler-source-mapping-debug-expected.txt: Added.
  • http/tests/inspector/compiler-source-mapping-debug.html: Added.
  • http/tests/inspector/resources/source-map.json:
  • http/tests/inspector/resources/source1.js:
  • http/tests/inspector/resources/source2.js:

(ClickHandler.prototype.handle):

12:38 AM Changeset in webkit [101127] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2011-11-24 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update test expectations.

  • platform/chromium/test_expectations.txt: Now that V8 bug 1821 is fixed the test should not crash.
12:17 AM EFLWebKit edited by gyuyoung.kim@samsung.com
(diff)
12:14 AM EFLWebKit edited by gyuyoung.kim@samsung.com
(diff)
12:11 AM Changeset in webkit [101126] by pfeldman@chromium.org
  • 22 edits in trunk

Web Inspector: get rid of the WebInspector.mainResource, use WebInspector.inspectedPageURL instead.
https://bugs.webkit.org/show_bug.cgi?id=73024

Source/WebCore:

We use it for the URL mostly, no need to create artificial resource for that upon
attaching to the existing page.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/AuditsPanel.js:
  • inspector/front-end/HAREntry.js:

(WebInspector.HARLog.prototype._buildPages):
(WebInspector.HARLog.prototype._pageEventTime):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._updateSummaryBar):
(WebInspector.NetworkLogView.prototype._exportAll):

  • inspector/front-end/Resource.js:

(WebInspector.Resource.prototype.set url):
(WebInspector.Resource.prototype.get displayName):
(WebInspector.Resource.prototype.get displayDomain):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype._processCachedResources):
(WebInspector.ResourceTreeModel.prototype._dispatchInspectedURLChanged):
(WebInspector.ResourceTreeModel.prototype._frameNavigated):
(WebInspector.ResourceTreeModel.prototype._addFramesRecursively):

  • inspector/front-end/ResourceUtils.js:

(WebInspector.displayNameForURL):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype._initDefaultSelection):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._addRecordToTimeline):

  • inspector/front-end/utilities.js:

(String.prototype.asParsedURL):

LayoutTests:

Reviewed by Yury Semikhatsky.

  • inspector/debugger/debugger-breakpoints-not-activated-on-reload.html:
  • inspector/debugger/debugger-scripts.html:
  • inspector/debugger/linkifier.html:
  • inspector/debugger/selected-call-frame-after-formatting-source.html:
  • inspector/debugger/watch-expressions-panel-switch.html:
  • inspector/extensions/extensions-events.html:
  • inspector/performance/resources/first-open-resources.html:
  • inspector/performance/resources/performance-test.js:

(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype._dump):
(initialize_TimeTracker.InspectorTest.runPerformanceTest):

  • inspector/performance/resources/show-panel.html:
  • inspector/styles/styles-history.html:
12:01 AM Changeset in webkit [101125] by yurys@chromium.org
  • 14 edits in trunk/Source/WebCore

Web Inspector: exceptions in shared workers should be logged to web inspector console
https://bugs.webkit.org/show_bug.cgi?id=73022

According to section "4.7 Runtime script errors" of Web Workers spec "For shared
workers, if the error is still not handled afterwards, or if the error occurred
while handling a previous script error, the error may be reported to the user."

This change adds uncaugh exceptions to the shared worker web inspector console.

Reviewed by Pavel Feldman.

  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::restore):

  • inspector/InspectorConsoleInstrumentation.h:

(WebCore::InspectorInstrumentation::addMessageToConsole):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::restore):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::instrumentingAgentsForWorkerContext):

  • inspector/InspectorInstrumentation.h:
  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::connectFrontend):
(WebCore::WorkerInspectorController::disconnectFrontend):
(WebCore::WorkerInspectorController::restoreInspectorStateFromCookie):

  • inspector/WorkerInspectorController.h:
  • inspector/front-end/WorkerManager.js:

(WebInspector.WorkerManager.showWorkerTerminatedScreen):

  • inspector/front-end/inspector.js:
  • workers/SharedWorkerContext.cpp:

(WebCore::SharedWorkerContext::logExceptionToConsole):

  • workers/SharedWorkerContext.h:
  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::addMessage): console messages are now added to
the worker console agent.
(WebCore::WorkerContext::addMessageToWorkerConsole):

  • workers/WorkerContext.h:

Nov 23, 2011:

11:47 PM Changeset in webkit [101124] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
https://bugs.webkit.org/show_bug.cgi?id=52810

Unreviewed gardening.

  • platform/qt/Skipped: Skip svg/dom/css-transforms.xhtml introduced in r101062, because 0.0 != -0.0.
11:46 PM Changeset in webkit [101123] by commit-queue@webkit.org
  • 4 edits
    2 copies in trunk/Source/WebKit/chromium

Add simple implementation for web intents chromium API data classes.
https://bugs.webkit.org/show_bug.cgi?id=73036

Patch by Greg Billock <gbillock@google.com> on 2011-11-23
Reviewed by Darin Fisher.

  • WebKit.gyp:
  • public/WebIntent.h:
  • public/WebIntentServiceInfo.h:
  • src/WebIntent.cpp: Copied from Source/WebKit/chromium/public/WebIntent.h.

(WebKit::WebIntent::WebIntent):
(WebKit::WebIntent::action):
(WebKit::WebIntent::setAction):
(WebKit::WebIntent::type):
(WebKit::WebIntent::setType):
(WebKit::WebIntent::data):
(WebKit::WebIntent::setData):
(WebKit::WebIntent::identifier):
(WebKit::WebIntent::setIdentifier):

  • src/WebIntentServiceInfo.cpp: Copied from Source/WebKit/chromium/public/WebIntentServiceInfo.h.

(WebKit::WebIntentServiceInfo::WebIntentServiceInfo):
(WebKit::WebIntentServiceInfo::url):
(WebKit::WebIntentServiceInfo::setURL):
(WebKit::WebIntentServiceInfo::title):
(WebKit::WebIntentServiceInfo::setTitle):
(WebKit::WebIntentServiceInfo::action):
(WebKit::WebIntentServiceInfo::setAction):
(WebKit::WebIntentServiceInfo::type):
(WebKit::WebIntentServiceInfo::setType):
(WebKit::WebIntentServiceInfo::disposition):
(WebKit::WebIntentServiceInfo::setDisposition):

11:13 PM Changeset in webkit [101122] by abarth@webkit.org
  • 168 edits
    15 copies
    16 adds in trunk/Source/WebKit/chromium

[Chromium] Move WebKitPlatformSupport.h and dependencies to new public/platform directory
https://bugs.webkit.org/show_bug.cgi?id=73066

Reviewed by Darin Fisher.

This patch creates a new subdirectory in the Chromium WebKit API to
house "platform" header files. As with the other Platform directories
in WebKit, the platform directory cannot depend on headers outside of
platform, but headers outside of platform can depend on platform.

This patch moves WebKitPlatformSupport and its dependencies into this
new directory and creates forwarding headers to easy migration for
embedders of this API. Over time, we will migrate more headers into
this folder, as appropriate.

  • public/WebAccessibilityObject.h:
  • public/WebAccessibilityRole.h:
  • public/WebAnimationController.h:
  • public/WebApplicationCacheHost.h:
  • public/WebApplicationCacheHostClient.h:
  • public/WebArrayBufferView.h:
  • public/WebAttribute.h:
  • public/WebAudioBus.h: Replaced.
  • public/WebAudioDevice.h: Replaced.
  • public/WebAudioSourceProvider.h:
  • public/WebBindings.h:
  • public/WebBlob.h:
  • public/WebBlobData.h:
  • public/WebBlobRegistry.h:
  • public/WebCString.h: Replaced.
  • public/WebCache.h:
  • public/WebCanvas.h:
  • public/WebClipboard.h:
  • public/WebColor.h:
  • public/WebCommon.h: Replaced.
  • public/WebCommonWorkerClient.h:
  • public/WebCompositor.h:
  • public/WebConsoleMessage.h:
  • public/WebContentLayer.h:
  • public/WebContextMenuData.h:
  • public/WebCookie.h:
  • public/WebCrossOriginPreflightResultCache.h:
  • public/WebDOMEvent.h:
  • public/WebDOMEventListener.h:
  • public/WebDOMStringList.h:
  • public/WebData.h: Replaced.
  • public/WebDataSource.h:
  • public/WebDatabase.h:
  • public/WebDevToolsAgent.h:
  • public/WebDevToolsAgentClient.h:
  • public/WebDevToolsFrontend.h:
  • public/WebDeviceOrientationClientMock.h:
  • public/WebDeviceOrientationController.h:
  • public/WebDocument.h:
  • public/WebDragData.h:
  • public/WebExternalPopupMenuClient.h:
  • public/WebExternalTextureLayer.h:
  • public/WebFileChooserParams.h:
  • public/WebFileInfo.h:
  • public/WebFileSystem.h:
  • public/WebFileSystemCallbacks.h:
  • public/WebFileSystemEntry.h:
  • public/WebFileUtilities.h:
  • public/WebFileWriter.h:
  • public/WebFileWriterClient.h:
  • public/WebFindOptions.h:
  • public/WebFloatPoint.h:
  • public/WebFloatQuad.h:
  • public/WebFloatRect.h:
  • public/WebFont.h:
  • public/WebFontCache.h:
  • public/WebFontDescription.h:
  • public/WebFormControlElement.h:
  • public/WebFormElement.h:
  • public/WebFrame.h:
  • public/WebFrameClient.h:
  • public/WebGamepad.h: Replaced.
  • public/WebGamepads.h: Replaced.
  • public/WebGeolocationClientMock.h:
  • public/WebGeolocationController.h:
  • public/WebGeolocationError.h:
  • public/WebGeolocationPermissionRequest.h:
  • public/WebGeolocationPermissionRequestManager.h:
  • public/WebGeolocationPosition.h:
  • public/WebGlyphCache.h:
  • public/WebGraphicsContext3D.h:
  • public/WebHTTPBody.h:
  • public/WebHTTPLoadInfo.h:
  • public/WebHistoryItem.h:
  • public/WebIDBCallbacks.h:
  • public/WebIDBCursor.h:
  • public/WebIDBDatabase.h:
  • public/WebIDBDatabaseCallbacks.h:
  • public/WebIDBDatabaseError.h:
  • public/WebIDBFactory.h:
  • public/WebIDBIndex.h:
  • public/WebIDBKey.h:
  • public/WebIDBKeyPath.h:
  • public/WebIDBKeyRange.h:
  • public/WebIDBObjectStore.h:
  • public/WebIDBTransaction.h:
  • public/WebIDBTransactionCallbacks.h:
  • public/WebIconURL.h:
  • public/WebImage.h:
  • public/WebInputEvent.h:
  • public/WebKit.h:
  • public/WebKitPlatformSupport.h: Replaced.
  • public/WebLayer.h:
  • public/WebLayerTreeView.h:
  • public/WebLocalizedString.h: Replaced.
  • public/WebMediaPlayer.h:
  • public/WebMediaStreamDescriptor.h:
  • public/WebMediaStreamRegistry.h:
  • public/WebMediaStreamSource.h:
  • public/WebMenuItemInfo.h:
  • public/WebMessagePortChannel.h:
  • public/WebMimeRegistry.h:
  • public/WebNamedNodeMap.h:
  • public/WebNetworkStateNotifier.h:
  • public/WebNode.h:
  • public/WebNodeCollection.h:
  • public/WebNodeList.h:
  • public/WebNotification.h:
  • public/WebNotificationPresenter.h:
  • public/WebOptionElement.h:
  • public/WebPageSerializer.h:
  • public/WebPasswordFormData.h:
  • public/WebPeerConnectionHandler.h:
  • public/WebPerformance.h:
  • public/WebPlugin.h:
  • public/WebPluginParams.h:
  • public/WebPoint.h:
  • public/WebPopupMenu.h:
  • public/WebPopupMenuInfo.h:
  • public/WebPrivateOwnPtr.h: Replaced.
  • public/WebPrivatePtr.h: Replaced.
  • public/WebRange.h:
  • public/WebRect.h:
  • public/WebRegularExpression.h:
  • public/WebRuntimeFeatures.h:
  • public/WebScriptController.h:
  • public/WebScriptSource.h:
  • public/WebScrollbar.h:
  • public/WebSearchableFormData.h:
  • public/WebSecurityOrigin.h:
  • public/WebSecurityPolicy.h:
  • public/WebSelectElement.h:
  • public/WebSerializedScriptValue.h: Replaced.
  • public/WebSettings.h:
  • public/WebSharedWorker.h:
  • public/WebSharedWorkerRepository.h:
  • public/WebSize.h:
  • public/WebSocket.h:
  • public/WebSocketClient.h:
  • public/WebSocketStreamError.h:
  • public/WebSocketStreamHandle.h:
  • public/WebSocketStreamHandleClient.h:
  • public/WebSpeechInputController.h:
  • public/WebSpeechInputResult.h:
  • public/WebSpellCheckClient.h:
  • public/WebStorageArea.h:
  • public/WebStorageEventDispatcher.h:
  • public/WebStorageNamespace.h:
  • public/WebString.h: Replaced.
  • public/WebTestingSupport.h:
  • public/WebTextCheckingCompletion.h:
  • public/WebTextCheckingResult.h:
  • public/WebTextRun.h:
  • public/WebThread.h:
  • public/WebThreadSafeData.h:
  • public/WebTouchPoint.h:
  • public/WebURL.h: Replaced.
  • public/WebURLError.h:
  • public/WebURLLoadTiming.h:
  • public/WebURLLoader.h:
  • public/WebURLRequest.h:
  • public/WebURLResponse.h:
  • public/WebUserMediaRequest.h:
  • public/WebVector.h: Replaced.
  • public/WebView.h:
  • public/WebViewClient.h:
  • public/WebWidget.h:
  • public/WebWidgetClient.h:
  • public/WebWindowFeatures.h:
  • public/android/WebInputEventFactory.h:
  • public/gtk/WebInputEventFactory.h:
  • public/linux/WebFontFamily.h:
  • public/linux/WebFontInfo.h:
  • public/linux/WebFontRenderStyle.h:
  • public/linux/WebFontRendering.h:
  • public/linux/WebRenderTheme.h:
  • public/linux/WebSandboxSupport.h:
  • public/mac/WebInputEventFactory.h:
  • public/mac/WebScreenInfoFactory.h:
  • public/platform: Added.
  • public/platform/WebAudioBus.h: Copied from Source/WebKit/chromium/public/WebAudioBus.h.
  • public/platform/WebAudioDevice.h: Copied from Source/WebKit/chromium/public/WebAudioDevice.h.
  • public/platform/WebCString.h: Copied from Source/WebKit/chromium/public/WebCString.h.
  • public/platform/WebCommon.h: Copied from Source/WebKit/chromium/public/WebCommon.h.
  • public/platform/WebData.h: Copied from Source/WebKit/chromium/public/WebData.h.
  • public/platform/WebGamepad.h: Copied from Source/WebKit/chromium/public/WebGamepad.h.
  • public/platform/WebGamepads.h: Copied from Source/WebKit/chromium/public/WebGamepads.h.
  • public/platform/WebKitPlatformSupport.h: Copied from Source/WebKit/chromium/public/WebKitPlatformSupport.h.
  • public/platform/WebLocalizedString.h: Copied from Source/WebKit/chromium/public/WebLocalizedString.h.
  • public/platform/WebPrivateOwnPtr.h: Copied from Source/WebKit/chromium/public/WebPrivateOwnPtr.h.
  • public/platform/WebPrivatePtr.h: Copied from Source/WebKit/chromium/public/WebPrivatePtr.h.
  • public/platform/WebSerializedScriptValue.h: Copied from Source/WebKit/chromium/public/WebSerializedScriptValue.h.
  • public/platform/WebString.h: Copied from Source/WebKit/chromium/public/WebString.h.
  • public/platform/WebURL.h: Copied from Source/WebKit/chromium/public/WebURL.h.
  • public/platform/WebVector.h: Copied from Source/WebKit/chromium/public/WebVector.h.
  • public/win/WebInputEventFactory.h:
  • public/win/WebScreenInfoFactory.h:
  • public/x11/WebScreenInfoFactory.h:
11:03 PM Changeset in webkit [101121] by abarth@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Remove unused WebSecurityOrigin::isEmpty from WebKit API
https://bugs.webkit.org/show_bug.cgi?id=73065

Reviewed by Eric Seidel.

This API no longer has any callers.

  • public/WebSecurityOrigin.h:
  • src/WebSecurityOrigin.cpp:

(WebKit::WebSecurityOrigin::isUnique):

10:06 PM Changeset in webkit [101120] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

[Chromium] Prevent DrawingBuffer instances from corrupting the active
texture state of the WebGL contexts. The DrawingBuffer now tracks the
state of texture unit 0, and the active texture unit, so that state can
be restored.
https://bugs.webkit.org/show_bug.cgi?id=73033

Patch by Jeff Timanus <twiz@chromium.org> on 2011-11-23
Reviewed by Kenneth Russell.

Test: fast/canvas/webgl/webgl-texture-binding-preserved.html

Source/WebCore:

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::activeTexture):
(WebCore::WebGLRenderingContext::bindTexture):

  • platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::publishToPlatformLayer):

  • platform/graphics/gpu/DrawingBuffer.h:

(WebCore::DrawingBuffer::setTexture2DBinding):
(WebCore::DrawingBuffer::setActiveTextureUnit):

  • platform/graphics/gpu/mac/DrawingBufferMac.mm:

(WebCore::DrawingBuffer::DrawingBuffer):

  • platform/graphics/gpu/qt/DrawingBufferQt.cpp:

(WebCore::DrawingBuffer::DrawingBuffer):

  • platform/graphics/gtk/DrawingBufferGtk.cpp:

(WebCore::DrawingBuffer::DrawingBuffer):

LayoutTests:

  • fast/canvas/webgl/webgl-texture-binding-preserved-expected.txt: Added.
  • fast/canvas/webgl/webgl-texture-binding-preserved.html: Added.
10:03 PM Changeset in webkit [101119] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

CSSValue: reorder ClassType enum to allow faster comparisons, add COMPILE_ASSERT on class size.
https://bugs.webkit.org/show_bug.cgi?id=72924

Reviewed by Andreas Kling.

Note that the change from unsigned to unsigned char is to improve bit packing when using MSVC.

Covered by existing CSS tests.

  • css/CSSValue.h:

(WebCore::CSSValue::isPrimitiveValue):
(WebCore::CSSValue::isValueList):
(WebCore::CSSValue::isImageGeneratorValue):
(WebCore::CSSValue::isTimingFunctionValue):
(WebCore::CSSValue::CSSValue):

9:14 PM Changeset in webkit [101118] by dslomov@google.com
  • 19 edits
    1 delete in trunk

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=73054
[V8][Chromium] Add list of transferred ArrayBuffers to SerializedScriptValue::create.

Reviewed by David Levin.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateParametersCheck):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::serializedValueCallback):

  • bindings/v8/OptionsObject.cpp:
  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::create):

  • bindings/v8/SerializedScriptValue.h:
  • bindings/v8/V8Utilities.cpp:

(WebCore::extractTransferables):
(WebCore::getMessagePortArray):

  • bindings/v8/V8Utilities.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::handlePostMessageCallback):

  • bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:

(WebCore::handlePostMessageCallback):

  • bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):

  • bindings/v8/custom/V8MessageEventCustom.cpp:
  • bindings/v8/custom/V8MessagePortCustom.cpp:

(WebCore::handlePostMessageCallback):

  • bindings/v8/custom/V8MessagePortCustom.h: Removed.
  • bindings/v8/custom/V8WorkerCustom.cpp:

(WebCore::handlePostMessageCallback):

Source/WebKit/chromium: https://bugs.webkit.org/show_bug.cgi?id=73054
[V8][Chromium] Add list of transferred ArrayBuffers to SerializedScriptValue::create.

Reviewed by David Levin.

  • src/WebSerializedScriptValue.cpp:

(WebKit::WebSerializedScriptValue::serialize):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=73054
[V8][Chromium] Add list of transferred ArrayBuffers to SerializedScriptValue::create.
Tests rebaselined to reflect new error message.

Reviewed by David Levin.

  • platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt:
  • platform/chromium/fast/events/constructors/message-event-constructor-expected.txt:
7:24 PM Changeset in webkit [101117] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Cleanup #if usage in V8GCController
https://bugs.webkit.org/show_bug.cgi?id=73060

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-11-23
Reviewed by Ojan Vafai.

No tests needed. Just code cleanup

  • bindings/v8/V8GCController.cpp:

(WebCore::V8GCController::checkMemoryUsage):

6:45 PM Changeset in webkit [101116] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

Change CSSMutableStyleDeclaration::m_node to m_element (along with getter/setter)
https://bugs.webkit.org/show_bug.cgi?id=73050

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-11-23
Reviewed by Ojan Vafai.

No tests needed. This is just a refactor.

  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
(WebCore::CSSMutableStyleDeclaration::operator=):
(WebCore::CSSMutableStyleDeclaration::isInlineStyleDeclaration):
(WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):

  • css/CSSMutableStyleDeclaration.h:

(WebCore::CSSMutableStyleDeclaration::setElement):
(WebCore::CSSMutableStyleDeclaration::element):

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::setSelectorText):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::createInlineStyleDecl):
(WebCore::StyledElement::destroyInlineStyleDecl):
(WebCore::StyledElement::attributeChanged):
(WebCore::StyledElement::createMappedDecl):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::additionalAttributeStyleDecls):
(WebCore::HTMLTableElement::addSharedCellBordersDecl):
(WebCore::HTMLTableElement::addSharedCellPaddingDecl):
(WebCore::HTMLTableElement::addSharedGroupDecls):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::inlineStyleElement):

6:31 PM Changeset in webkit [101115] by commit-queue@webkit.org
  • 12 edits in trunk/Source

Teach VideoLayerChromium how to render native texture (to support HW video decode).
https://bugs.webkit.org/show_bug.cgi?id=73043

Patch by Ami Fischman <fischman@chromium.org> on 2011-11-23
Reviewed by Kenneth Russell.

Source/WebCore:

No new tests. (depends on chromium support landing, and supporting HW being available)

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):
(WebCore::LayerRendererChromium::videoLayerNativeTextureProgram):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/VideoFrameChromium.h:
  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::VideoLayerChromium):
(WebCore::VideoLayerChromium::updateCompositorResources):
(WebCore::VideoLayerChromium::pushPropertiesTo):
(WebCore::VideoLayerChromium::determineTextureFormat):

  • platform/graphics/chromium/VideoLayerChromium.h:
  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::setNativeTexture):
(WebCore::CCVideoLayerImpl::draw):
(WebCore::CCVideoLayerImpl::drawNativeTexture):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:

Source/WebKit/chromium:

  • public/WebVideoFrame.h:
  • src/VideoFrameChromiumImpl.cpp:

(WebKit::VideoFrameChromiumImpl::textureId):

  • src/VideoFrameChromiumImpl.h:
6:29 PM Changeset in webkit [101114] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

IndexedDB: Remove stylesheet links from layout tests
https://bugs.webkit.org/show_bug.cgi?id=73053

Remove links to js-test-style.css that slipped in.

Patch by Joshua Bell <jsbell@chromium.org> on 2011-11-23
Reviewed by Ojan Vafai.

  • storage/indexeddb/cursor-key-order.html:
  • storage/indexeddb/key-type-array.html:
  • storage/indexeddb/mozilla/delete-result.html:
5:21 PM Changeset in webkit [101113] by abarth@webkit.org
  • 9 edits
    2 deletes in trunk/Tools

Unreviewed, rolling out r101107.
http://trac.webkit.org/changeset/101107
https://bugs.webkit.org/show_bug.cgi?id=73062

Breaks the commit-queue (Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-23

  • Scripts/webkitpy/common/host.py:

(Host._engage_awesome_windows_hacks):

  • Scripts/webkitpy/common/host_mock.py:

(MockHost.init):

  • Scripts/webkitpy/common/system/environment.py: Removed.
  • Scripts/webkitpy/common/system/environment_unittest.py: Removed.
  • Scripts/webkitpy/common/system/executive.py:

(Executive._run_command_with_teed_output):
(Executive.run_and_throw_if_fail):

  • Scripts/webkitpy/common/system/executive_mock.py:

(MockExecutive.run_and_throw_if_fail):
(MockExecutive.run_command):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._driver_build_script_name):
(WebKitPort._run_script):
(WebKitPort._build_driver):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(test_build_driver):

  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/steps/build.py:

(Build.build):

5:15 PM Changeset in webkit [101112] by ojan@chromium.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r101110.
http://trac.webkit.org/changeset/101110
https://bugs.webkit.org/show_bug.cgi?id=73057

The bots have now cycled and this patch is no longer needed.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._upload_json_files):

4:25 PM Changeset in webkit [101111] by scheib@chromium.org
  • 11 edits in trunk/Source

Pointer Lock: Plumb movement coordinates from PlatformMouseEvent to MouseEvents.
https://bugs.webkit.org/show_bug.cgi?id=73031

Reviewed by Dimitri Glazkov.

Source/WebCore:

No tests for now, but this patch gets us closer to being able to write layout tests for pointer lock.

  • dom/MouseEvent.cpp:

(WebCore::MouseEvent::create):
(WebCore::MouseEvent::MouseEvent):
(WebCore::SimulatedMouseEvent::SimulatedMouseEvent):

  • dom/MouseEvent.h:

(WebCore::MouseEvent::create):

  • dom/MouseRelatedEvent.cpp:

(WebCore::MouseRelatedEvent::MouseRelatedEvent):

  • dom/MouseRelatedEvent.h:
  • dom/TouchEvent.cpp:

(WebCore::TouchEvent::TouchEvent):

  • dom/WheelEvent.cpp:

(WebCore::WheelEvent::WheelEvent):

  • page/EventHandler.cpp:

(WebCore::EventHandler::dispatchDragEvent):

  • platform/PlatformMouseEvent.h:

(WebCore::PlatformMouseEvent::movementX):
(WebCore::PlatformMouseEvent::movementY):

Source/WebKit/chromium:

  • src/WebInputEventConversion.cpp:

(WebKit::PlatformMouseEventBuilder::PlatformMouseEventBuilder):

4:16 PM Changeset in webkit [101110] by ojan@chromium.org
  • 2 edits in trunk/Tools

Temporarily save the incremental results json in order to identify bug
https://bugs.webkit.org/show_bug.cgi?id=73057

Reviewed by Dean Jackson.

The test results server needed to be rolled back from tip of tree
due to a JSON merging bug. It's hard to identify what the bug is without
the raw data.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._upload_json_files):

4:04 PM Changeset in webkit [101109] by ojan@chromium.org
  • 3 edits in trunk/Tools

Merging two version 4 results hits an error in the test results server
https://bugs.webkit.org/show_bug.cgi?id=73042

Reviewed by Adam Barth.

The old code assumed that if the aggregate results value was not a leaf
value that the incremental results would exist, which is just totally
wrong. Added a test for that case as well.

  • TestResultServer/model/jsonresults.py:

(JsonResults._merge_tests):

  • TestResultServer/model/jsonresults_unittest.py:

(JsonResultsTest.test_merge_build_directory_hierarchy_old_version):
(JsonResultsTest.test_merge_build_directory_hierarchy):

3:34 PM Changeset in webkit [101108] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove one static initializer (for kTickTime)
https://bugs.webkit.org/show_bug.cgi?id=73049

Reviewed by Adam Barth.

  • platform/ScrollAnimatorNone.cpp:
3:23 PM Changeset in webkit [101107] by eric@webkit.org
  • 9 edits
    2 copies in trunk/Tools

Add Environment object to Host and fix the GCC smartquotes trouble seen on the commit-queue
https://bugs.webkit.org/show_bug.cgi?id=71983

Reviewed by Adam Barth.

We'll add more code to Environment overtime,
allowing us to mock out more of our direct interactions with os.environ.

This patch also makes run_command print the passed in environment.

  • Scripts/webkitpy/common/host_mock.py:
  • Scripts/webkitpy/common/system/environment.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
  • Scripts/webkitpy/common/system/environment_mock.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
  • Scripts/webkitpy/common/system/environment_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/common/system/executive_mock.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/steps/build.py:
3:11 PM Changeset in webkit [101106] by adamk@chromium.org
  • 2 edits
    8 moves
    37 adds
    12 deletes in trunk/LayoutTests

More Chromium rebaselines for r101062. Unreviewed gardening.

  • platform/chromium-cg-mac-leopard/svg/custom/pointer-events-image-css-transform-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/custom/pointer-events-text-css-transform-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/dom/css-transforms-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-css-transform-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-css-transform-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/custom/pointer-events-image-css-transform-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/transforms/svg-css-transforms-clip-path-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/transforms/svg-css-transforms-expected.png: Added.
  • platform/chromium-linux/svg/clip-path/clip-path-css-transform-1-expected.png: Added.
  • platform/chromium-linux/svg/clip-path/clip-path-css-transform-2-expected.png: Added.
  • platform/chromium-linux/svg/custom/pointer-events-image-css-transform-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/pointer-events-text-css-transform-expected.txt: Removed.
  • platform/chromium-linux/svg/dom/css-transforms-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png: Added.
  • platform/chromium-linux/svg/transforms/svg-css-transforms-clip-path-expected.txt: Removed.
  • platform/chromium-linux/svg/transforms/svg-css-transforms-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/custom/pointer-events-image-css-transform-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/pointer-events-text-css-transform-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dom/css-transforms-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-css-transform-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-css-transform-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-css-transform-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/pointer-events-text-css-transform-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dom/css-transforms-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/transforms/svg-css-transforms-clip-path-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/transforms/svg-css-transforms-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/pointer-events-image-css-transform-expected.txt: Removed.
  • platform/chromium-win-vista/svg/custom/pointer-events-text-css-transform-expected.txt: Removed.
  • platform/chromium-win-vista/svg/transforms/svg-css-transforms-clip-path-expected.txt: Removed.
  • platform/chromium-win-vista/svg/transforms/svg-css-transforms-expected.txt: Removed.
  • platform/chromium-win-xp/svg/custom/pointer-events-image-css-transform-expected.txt: Removed.
  • platform/chromium-win-xp/svg/custom/pointer-events-text-css-transform-expected.txt: Removed.
  • platform/chromium-win-xp/svg/transforms/svg-css-transforms-clip-path-expected.txt: Removed.
  • platform/chromium-win-xp/svg/transforms/svg-css-transforms-expected.txt: Removed.
  • platform/chromium-win/svg/clip-path/clip-path-css-transform-1-expected.png: Added.
  • platform/chromium-win/svg/clip-path/clip-path-css-transform-2-expected.png: Added.
  • platform/chromium-win/svg/custom/pointer-events-image-css-transform-expected.png: Renamed from LayoutTests/platform/chromium-win-vista/svg/custom/pointer-events-image-css-transform-expected.png.
  • platform/chromium-win/svg/custom/pointer-events-image-css-transform-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/svg/custom/pointer-events-image-css-transform-expected.txt.
  • platform/chromium-win/svg/custom/pointer-events-text-css-transform-expected.png: Renamed from LayoutTests/platform/chromium-win-vista/svg/custom/pointer-events-text-css-transform-expected.png.
  • platform/chromium-win/svg/custom/pointer-events-text-css-transform-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/svg/custom/pointer-events-text-css-transform-expected.txt.
  • platform/chromium-win/svg/dom/css-transforms-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png: Added.
  • platform/chromium-win/svg/transforms/svg-css-transforms-clip-path-expected.png: Renamed from LayoutTests/platform/chromium-win-vista/svg/transforms/svg-css-transforms-clip-path-expected.png.
  • platform/chromium-win/svg/transforms/svg-css-transforms-clip-path-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/svg/transforms/svg-css-transforms-clip-path-expected.txt.
  • platform/chromium-win/svg/transforms/svg-css-transforms-expected.png: Renamed from LayoutTests/platform/chromium-win-vista/svg/transforms/svg-css-transforms-expected.png.
  • platform/chromium-win/svg/transforms/svg-css-transforms-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/svg/transforms/svg-css-transforms-expected.txt.
  • platform/chromium/test_expectations.txt:
3:04 PM Changeset in webkit [101105] by reed@google.com
  • 2 edits in trunk/LayoutTests

[skia] need to rebaseline after SK_ENABLE_FAST_SHADERMASK is enabled in skia/skia.gyp
https://bugs.webkit.org/show_bug.cgi?id=73044

unreviewed, expectations update

  • platform/chromium/test_expectations.txt:
2:48 PM Changeset in webkit [101104] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[chromium] Drop root layer tiles on platforms that cache the front buffer
https://bugs.webkit.org/show_bug.cgi?id=72956

Patch by Jonathan Backer <backer@chromium.org> on 2011-11-23
Reviewed by Kenneth Russell.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):
(WebCore::LayerRendererCapabilities::LayerRendererCapabilities):

2:03 PM Changeset in webkit [101103] by jesus@webkit.org
  • 4 edits
    1 move
    1 delete in trunk/Source/WebKit2

[Qt][WK2] Move QQuickWebView::downloadRequested signal into experimental
https://bugs.webkit.org/show_bug.cgi?id=72914

Reviewed by Andreas Kling.

Make the signal downloadRequested an experimental API from QQuickWebView
and modify the qml test to use a WebView instead of a DesktopWebView.

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_download.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_download.qml.
  • UIProcess/API/qt/tests/qmltests/common/download.html: Removed.
  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::didReceiveDownloadResponse):

2:03 PM Changeset in webkit [101102] by arv@chromium.org
  • 12 edits in trunk/Source/WebCore

Binding CodeGenerators don't support Conditional= on constants
https://bugs.webkit.org/show_bug.cgi?id=67666

Reviewed by Adam Barth.

Adds support for [Conditional=LABEL] to const IDL fields.

  • bindings/scripts/CodeGenerator.pm:

(GenerateConditionalStringFromAttributeValue): Moved out of CodeGenerator{CPP,JS,V8}.pm.
(GenerateCompileTimeCheckForEnumsIfNeeded): Wrap in conditional #if.

  • bindings/scripts/CodeGeneratorCPP.pm:

(GenerateConditionalString):
(GenerateHeader): Ditto.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateConditionalString):
(GenerateHeader): Ditto.
(GenerateImplementation): Ditto.
(GenerateHashTable):
(WriteData):

  • bindings/scripts/CodeGeneratorObjC.pm:

(GenerateHeader): Ditto.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateConditionalString): Ditto.
(GenerateImplementation):
(WriteData):

  • bindings/scripts/test/CPP/WebDOMTestObj.h: Generated code now wraps conditional const in #if.
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjCONDITIONAL_CONST): Ditto

  • bindings/scripts/test/JS/JSTestObj.h: Ditto
  • bindings/scripts/test/ObjC/DOMTestObj.h: Ditto
  • bindings/scripts/test/TestObj.idl: Added a conditional const.
  • bindings/scripts/test/V8/V8TestObj.cpp: Generated code now wraps conditional const in #if.
1:40 PM Changeset in webkit [101101] by commit-queue@webkit.org
  • 8 edits in trunk

[MutationObservers] Modifications to the style property don't dispatch "attributes" Mutation Records
https://bugs.webkit.org/show_bug.cgi?id=70137

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-11-23
Reviewed by Ryosuke Niwa.

Source/WebCore:

This patch adds a private AttributesMutationScope mechanism to CSSMutableStyleDeclaration (which uses
the RAII pattern similar to the public ChildListMutationScope). This manages the (sometimes conditional)
pre-change serialization of the style attribute (if an observer has requested oldValue), creation of
the mutation record, and dispatch if the declaration was actual affected.

  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::removeProperty):
(WebCore::CSSMutableStyleDeclaration::setProperty):
(WebCore::CSSMutableStyleDeclaration::setPropertyInternal):
(WebCore::CSSMutableStyleDeclaration::parseDeclaration):
(WebCore::CSSMutableStyleDeclaration::addParsedProperties):
(WebCore::CSSMutableStyleDeclaration::addParsedProperty):
(WebCore::CSSMutableStyleDeclaration::setCssText):
(WebCore::CSSMutableStyleDeclaration::merge):
(WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):

  • dom/Element.cpp:

(WebCore::Element::setAttribute):

LayoutTests:

Added tests asserting that changes to the style property are observable and work correctly if oldValue is requested.

  • fast/mutation/observe-attributes-expected.txt:
  • fast/mutation/observe-attributes.html:
12:18 PM Changeset in webkit [101100] by staikos@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Remove BlackBerry OS support from RandomNumberSeed, making QNX=UNIX.
https://bugs.webkit.org/show_bug.cgi?id=73028

Reviewed by Daniel Bates.

  • wtf/RandomNumberSeed.h:

(WTF::initializeRandomNumberGenerator):

11:58 AM Changeset in webkit [101099] by dslomov@google.com
  • 3 edits in trunk/Source/WebCore

Unreviewed, rebaseline binding tests after http://trac.webkit.org/changeset/101064.

  • bindings/scripts/test/JS/JSFloat64Array.cpp:

(WebCore::toFloat64Array):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::V8Float64Array::wrapSlow):

11:40 AM Changeset in webkit [101098] by adamk@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

Rebaseline Chromium after r101056. Unreviewed gardening.

  • platform/chromium-linux/svg/dom/length-list-parser-expected.txt: Removed.
11:33 AM Changeset in webkit [101097] by eae@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/css/CSSPrimitiveValue.cpp

Initialize Lengths from float css values as opposed to the rounded int values.

11:30 AM Changeset in webkit [101096] by adamk@chromium.org
  • 1 edit
    26 adds in trunk/LayoutTests

Chromium rebaselines after r101062. Unreviewed gardening.

  • platform/chromium-linux-x86/svg/custom/pointer-events-image-css-transform-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/pointer-events-text-css-transform-expected.txt: Added.
  • platform/chromium-linux-x86/svg/transforms/svg-css-transforms-clip-path-expected.txt: Added.
  • platform/chromium-linux-x86/svg/transforms/svg-css-transforms-expected.txt: Added.
  • platform/chromium-linux/svg/custom/pointer-events-image-css-transform-expected.png: Added.
  • platform/chromium-linux/svg/custom/pointer-events-image-css-transform-expected.txt: Added.
  • platform/chromium-linux/svg/custom/pointer-events-text-css-transform-expected.png: Added.
  • platform/chromium-linux/svg/custom/pointer-events-text-css-transform-expected.txt: Added.
  • platform/chromium-linux/svg/transforms/svg-css-transforms-clip-path-expected.png: Added.
  • platform/chromium-linux/svg/transforms/svg-css-transforms-clip-path-expected.txt: Added.
  • platform/chromium-linux/svg/transforms/svg-css-transforms-expected.png: Added.
  • platform/chromium-linux/svg/transforms/svg-css-transforms-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/pointer-events-image-css-transform-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/pointer-events-image-css-transform-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/pointer-events-text-css-transform-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/pointer-events-text-css-transform-expected.txt: Added.
  • platform/chromium-win-vista/svg/transforms/svg-css-transforms-clip-path-expected.png: Added.
  • platform/chromium-win-vista/svg/transforms/svg-css-transforms-clip-path-expected.txt: Added.
  • platform/chromium-win-vista/svg/transforms/svg-css-transforms-expected.png: Added.
  • platform/chromium-win-vista/svg/transforms/svg-css-transforms-expected.txt: Added.
  • platform/chromium-win-xp/svg/custom/pointer-events-image-css-transform-expected.txt: Added.
  • platform/chromium-win-xp/svg/custom/pointer-events-text-css-transform-expected.txt: Added.
  • platform/chromium-win-xp/svg/transforms/svg-css-transforms-clip-path-expected.txt: Added.
  • platform/chromium-win-xp/svg/transforms/svg-css-transforms-expected.txt: Added.
11:18 AM Changeset in webkit [101095] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Last rebaseline (really this time) for video-zoom-controls.html.

Unreviewed gardening.

  • platform/chromium-gpu-cg-mac/media/video-zoom-controls-expected.png: Copied by hand from bot's zip file.
11:04 AM Changeset in webkit [101094] by commit-queue@webkit.org
  • 11 edits
    2 deletes in trunk

Unreviewed, rolling out r101069.
http://trac.webkit.org/changeset/101069
https://bugs.webkit.org/show_bug.cgi?id=73032

New test always times out (Requested by aklein on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-23

Source/WebCore:

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype._bindScriptToRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype.get executionLineLocation):
(WebInspector.DebuggerPresentationModel.DefaultLinkifierFormatter.prototype.formatRawSourceCodeAnchor):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor):

LayoutTests:

  • http/tests/inspector/compiler-source-mapping-debug-expected.txt: Removed.
  • http/tests/inspector/compiler-source-mapping-debug.html: Removed.
  • http/tests/inspector/resources/source-map.json:
  • http/tests/inspector/resources/source1.js:

(window.onload):

  • http/tests/inspector/resources/source2.js:

(ClickHandler.prototype.handle):

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
10:51 AM Changeset in webkit [101093] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Crash in webkit::npapi::PluginInstance::NPP_SetWindow
https://bugs.webkit.org/show_bug.cgi?id=72271

Unreviewed gardening.

  • platform/chromium/test_expectations.txt: Mark fast/dom/node-iterator-reference-node-moved-crash.html as flaky
10:41 AM Changeset in webkit [101092] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Layout Test http/tests/loading/307-after-303-after-post.html is flaky on cr-mac
https://bugs.webkit.org/show_bug.cgi?id=73030

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
10:33 AM Changeset in webkit [101091] by Antti Koivisto
  • 3 edits
    2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=72354
Image pointer in FillLayer not cleared correctly

Reviewed by Dan Bernstein.

Source/WebCore:

Test: fast/css/fill-layer-crash.html

We should clear the image pointer too, not just the m_imageSet bit.

  • rendering/style/FillLayer.h:

(WebCore::FillLayer::clearImage):

LayoutTests:

  • fast/css/fill-layer-crash-expected.txt: Added.
  • fast/css/fill-layer-crash.html: Added.
10:29 AM Changeset in webkit [101090] by reed@google.com
  • 2 edits in trunk/LayoutTests

[skia] need rebaselining after skia rev. 2735 lands
https://bugs.webkit.org/show_bug.cgi?id=73023

unreviewed, expectations update

  • platform/chromium/test_expectations.txt:
10:19 AM Changeset in webkit [101089] by vestbo@webkit.org
  • 6 edits
    1 move in trunk

[Qt] Re-generate QtWebKit API forwarding headers when API changes

The forwarding headers are generated by syncqt, and syncqt is run by qmake,
so we need sync.profile to live in the same directory as the project file
that will be touched when adding/removing API (api.pri in our case).

Since the WebKit2 APIs live in a separate static library, we have to
add the project file for WebKit2 as a dependency of the api.pri file
as well, so that any changes to the WebKit2 API will still trigger a
run of qmake (and then syncqt).

Lastly, we use the new QMAKE_SYNCQT_OUTDIR variable in Qt 5 to ensure
that the forwarding headers are still generated in the root build dir,
not in the Source dir along with the internal forwarding headers.

Reviewed by Andreas Kling.

10:12 AM Changeset in webkit [101088] by commit-queue@webkit.org
  • 19 edits in trunk

Unreviewed, rolling out r101057.
http://trac.webkit.org/changeset/101057
https://bugs.webkit.org/show_bug.cgi?id=73027

Broke Chromium Windows build (Requested by aklein on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-23

Source/WebCore:

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::HTMLTrackElement):
(WebCore::HTMLTrackElement::didCompleteLoad):
(WebCore::HTMLTrackElement::textTrackReadyStateChanged):

  • html/HTMLTrackElement.h:
  • html/HTMLTrackElement.idl:
  • html/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::loadTimerFired):
(WebCore::LoadableTextTrack::cueLoadingStarted):
(WebCore::LoadableTextTrack::cueLoadingCompleted):

  • html/TextTrack.cpp:

(WebCore::TextTrack::TextTrack):
(WebCore::TextTrack::setReadyState):

  • html/TextTrack.h:

(WebCore::TextTrack::readyState):

  • html/TextTrack.idl:

LayoutTests:

  • media/track/track-add-track-expected.txt:
  • media/track/track-add-track.html:
  • media/track/track-constants-expected.txt:
  • media/track/track-constants.html:
  • media/track/track-load-error-readyState-expected.txt:
  • media/track/track-load-error-readyState.html:
  • media/track/track-load-from-element-readyState-expected.txt:
  • media/track/track-load-from-element-readyState.html:
  • media/track/track-load-from-src-readyState-expected.txt:
  • media/track/track-load-from-src-readyState.html:
9:49 AM Changeset in webkit [101087] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] MediaStream API: Missing WEBKIT_EXPORT in WebMediaStreamRegistry
https://bugs.webkit.org/show_bug.cgi?id=73010

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-11-23
Reviewed by Darin Fisher.

  • public/WebMediaStreamRegistry.h:
8:52 AM Changeset in webkit [101086] by caio.oliveira@openbossa.org
  • 7 edits
    1 move in trunk/Source/WebKit2

[Qt] [WK2] Expose onNavigationRequested signal instead of expecting a slot be defined from QML
https://bugs.webkit.org/show_bug.cgi?id=72976

Reviewed by Tor Arne Vestbø.

Expecting slots/methods to be implemented in QML isn't very idiomatic in
comparison with the alternative of having a signal. So we now use a signal
for handling navigation requests, and expose a 'request' object with relevant
metadata. There's also a settable property 'action' used to indicate whether
the navigation should be ignored or trigger a download.

The pattern signal with an object parameter that can keep the reply is common in QML,
and used for example for mouse signals.

  • UIProcess/API/qt/qquickwebview.cpp:
  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationPolicyForUrl.qml.
  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
  • UIProcess/qt/QtWebPagePolicyClient.cpp:

(NavigationRequest::NavigationRequest):
(NavigationRequest::url):
(NavigationRequest::button):
(NavigationRequest::modifiers):
(NavigationRequest::action):
(NavigationRequest::setAction):
(QtWebPagePolicyClient::decidePolicyForNavigationAction):

  • UIProcess/qt/QtWebPagePolicyClient.h:
8:04 AM Changeset in webkit [101085] by yurys@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-11-23 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Build fix. Added missing ENABLE(WORKERS) guards.

  • inspector/WorkerConsoleAgent.cpp:
  • inspector/WorkerConsoleAgent.h:
  • inspector/WorkerRuntimeAgent.cpp:
  • inspector/WorkerRuntimeAgent.h:
7:53 AM Changeset in webkit [101084] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skip another svg test on GTK showing signed zero issues.

  • platform/gtk/Skipped: Skip svg/dom/css-transforms.xhtml.
7:36 AM Changeset in webkit [101083] by Philippe Normand
  • 4 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r101060.

  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
7:33 AM Changeset in webkit [101082] by Philippe Normand
  • 3 edits in trunk/Source/WebCore

[GStreamer] improper usage of gst_object_ref_sink
https://bugs.webkit.org/show_bug.cgi?id=73014

Reviewed by Martin Robinson.

No new tests. Existing tests cover this already.

  • platform/graphics/gstreamer/GRefPtrGStreamer.cpp:

(WTF::adoptGRef): Ensure this is called with non-floating GstObjects.
(WTF::GstElement): Replace gst_object_ref_sink with
gst_object_ref+gst_object_sink like advised in the GstObject documentation.
(WTF::GstPad): Ditto.

  • platform/graphics/gstreamer/GRefPtrGStreamer.h:
7:28 AM Changeset in webkit [101081] by yurys@chromium.org
  • 18 edits
    8 copies in trunk/Source/WebCore

Web Inspector: split console agent into worker and page console agents
https://bugs.webkit.org/show_bug.cgi?id=73019

InspectorConsoleAgent now has two descendants: WorkerConsoleAgent and PageConsoleAgent
which encapsulate functionality specific for the type of inspected instance.

Reviewed by Pavel Feldman.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::clearMessages):
(WebCore::InspectorConsoleAgent::addMessageToConsole):
(WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest):
(WebCore::InspectorConsoleAgent::didReceiveResponse):
(WebCore::InspectorConsoleAgent::didFailLoading):
(WebCore::InspectorConsoleAgent::addConsoleMessage):

  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorStyleTextEditor.cpp:
  • inspector/InspectorStyleTextEditor.h:
  • inspector/PageConsoleAgent.cpp: Copied from Source/WebCore/inspector/PageDebuggerAgent.cpp.

(WebCore::PageConsoleAgent::PageConsoleAgent):
(WebCore::PageConsoleAgent::~PageConsoleAgent):
(WebCore::PageConsoleAgent::clearMessages):
(WebCore::PageConsoleAgent::addInspectedNode):
(WebCore::PageConsoleAgent::developerExtrasEnabled):

  • inspector/PageConsoleAgent.h: Copied from Source/WebCore/inspector/PageDebuggerAgent.h.
  • inspector/PageDebuggerAgent.cpp:
  • inspector/PageDebuggerAgent.h:
  • inspector/PageRuntimeAgent.cpp: Copied from Source/WebCore/inspector/PageDebuggerAgent.h.

(WebCore::PageRuntimeAgent::PageRuntimeAgent): PageRuntimeAgent was moved into its own file.
(WebCore::PageRuntimeAgent::~PageRuntimeAgent):
(WebCore::PageRuntimeAgent::scriptStateForFrameId):
(WebCore::PageRuntimeAgent::getDefaultInspectedState):

  • inspector/PageRuntimeAgent.h: Copied from Source/WebCore/inspector/PageDebuggerAgent.h.
  • inspector/WorkerConsoleAgent.cpp: Copied from Source/WebCore/inspector/PageDebuggerAgent.h.

(WebCore::WorkerConsoleAgent::WorkerConsoleAgent):
(WebCore::WorkerConsoleAgent::~WorkerConsoleAgent):
(WebCore::WorkerConsoleAgent::addInspectedNode):
(WebCore::WorkerConsoleAgent::developerExtrasEnabled):

  • inspector/WorkerConsoleAgent.h: Copied from Source/WebCore/inspector/PageDebuggerAgent.h.
  • inspector/WorkerDebuggerAgent.cpp:
  • inspector/WorkerDebuggerAgent.h:
  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):

  • inspector/WorkerInspectorController.h:
  • inspector/WorkerRuntimeAgent.cpp: Copied from Source/WebCore/inspector/PageDebuggerAgent.h.

(WebCore::WorkerRuntimeAgent::WorkerRuntimeAgent): WorkerRuntimeAgent was moved into its own file.
(WebCore::WorkerRuntimeAgent::~WorkerRuntimeAgent):
(WebCore::WorkerRuntimeAgent::scriptStateForFrameId):
(WebCore::WorkerRuntimeAgent::getDefaultInspectedState):

  • inspector/WorkerRuntimeAgent.h: Copied from Source/WebCore/inspector/PageDebuggerAgent.h.
6:34 AM Changeset in webkit [101080] by apavlov@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: warning icon for unrecognized style rule should have tooltip
https://bugs.webkit.org/show_bug.cgi?id=50638

Reviewed by Yury Semikhatsky.

  • English.lproj/localizedStrings.js: Add new tooltip strings.
  • inspector/front-end/CSSCompletions.js:

(WebInspector.CSSCompletions.prototype.keySet): Added.

  • inspector/front-end/StylesSidebarPane.js: Create a separate IMG element for an exclamation mark.
  • inspector/front-end/elementsPanel.css:

(.styles-section .properties li.not-parsed-ok img.exclamation-mark):

6:25 AM Changeset in webkit [101079] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] Add zlib depend when freetype is used.
https://bugs.webkit.org/show_bug.cgi?id=66365

Unreviewed build fix.

When freetype is enabled, uncompress() function is used by
WOFFFileFormat.cpp. Since zlib is not required by freetype, we need to
add libz as dependency for fix linking issue.

.:

Patch by Halton Huo <halton.huo@intel.com> on 2011-11-23

  • Source/cmake/OptionsEfl.cmake: search for ZLIB

Source/WebCore:

No new test because this change is only to fix linking issue.

Patch by Halton Huo <halton.huo@intel.com> on 2011-11-23

  • PlatformEfl.cmake: add ZLIB as dependency when using freetype
6:23 AM Changeset in webkit [101078] by mihnea@adobe.com
  • 10 edits
    3 adds in trunk

CSS Exclusions: parse the shorthand "wrap" property
https://bugs.webkit.org/show_bug.cgi?id=71905

Reviewed by Dean Jackson.

Source/WebCore:

Test: fast/exclusions/wrap-parsing.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::getPropertyValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyLonghand.cpp:

(WebCore::initShorthandMap):

  • css/CSSPropertyNames.in:
  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

LayoutTests:

  • fast/exclusions/script-tests/wrap-parsing.js: Added.
  • fast/exclusions/wrap-parsing-expected.txt: Added.
  • fast/exclusions/wrap-parsing.html: Added.
6:14 AM Changeset in webkit [101077] by Alexandru Chiculita
  • 4 edits
    3 adds in trunk

[CSS Filters] WebKit crashes when changing the filter
https://bugs.webkit.org/show_bug.cgi?id=72723

Reviewed by Simon Fraser.

Source/WebCore:

There are three things fixed with this patch:

  1. The list of effects wasn't cleared when the FilterOperations were changed.
  2. The sourceImage was going to be 0, because the m_sourceGraphicBuffer.release()

was also clearing the reference to m_sourceGraphicBuffer. Next time the build() method
was called m_graphicsBufferAttached was set to false, but the m_sourceGraphicBuffer was
not regenerated, because the size was not invalidated.

  1. maxEffectRects were not updated when a new list of effects was built.

Test: css3/filters/crash-filter-change.html

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::build):
(WebCore::FilterEffectRenderer::prepare):

  • rendering/FilterEffectRenderer.h:

(WebCore::FilterEffectRenderer::setSourceImageRect):

LayoutTests:

  • css3/filters/crash-filter-change-expected.png: Added.
  • css3/filters/crash-filter-change-expected.txt: Added.
  • css3/filters/crash-filter-change.html: Added.
6:12 AM Changeset in webkit [101076] by jnd@chromium.org
  • 4 edits in trunk

Set right default value to baseURL in LayoutTestController::queueLoadHTMLString.
https://bugs.webkit.org/show_bug.cgi?id=72950

Reviewed by Tony Chang.

Tools:

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::queueLoadHTMLString):

LayoutTests:

  • platform/chromium/test_expectations.txt:
6:09 AM Changeset in webkit [101075] by caryclark@google.com
  • 2 edits
    2 deletes in trunk/LayoutTests

Unreviewed rebaselining: update incorrectly generated baseline images
that masked http://crbug.com/105025 ('Regression: WebGL content flipped
with use_skia enabled on mac.')

Marking these tests as expected to fail until we fix the underlying bug.

  • platform/chromium-mac/fast/canvas/webgl/css-webkit-canvas-expected.png: Removed.
  • platform/chromium-mac/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
5:58 AM Changeset in webkit [101074] by abarth@webkit.org
  • 4 edits in trunk/Tools

garden-o-matic should display a message if it can't find results to display
https://bugs.webkit.org/show_bug.cgi?id=72991

Reviewed by Dimitri Glazkov.

Not all failures (e.g., TIMEOUT) have results that we can display.
This patch adds a short message so that the user can see that we're
done trying to load the results.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
5:45 AM Changeset in webkit [101073] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Skia] fix duplicate symbol ZN7WebCore11BitmapImage16initPlatformDataEv error
https://bugs.webkit.org/show_bug.cgi?id=72954

Patch by Elliot Poger <epoger@google.com> on 2011-11-23
Reviewed by Adam Barth.

  • WebCore.gyp/WebCore.gyp:
5:38 AM Changeset in webkit [101072] by abarth@webkit.org
  • 5 edits in trunk/Tools

garden-o-matic should explain more clearly what the builder lists at the top of the page mean
https://bugs.webkit.org/show_bug.cgi?id=72992

Reviewed by Dimitri Glazkov.

This patch also prepares us to list other sorts of failures, like
performance and unit test.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
5:20 AM Changeset in webkit [101071] by caio.oliveira@openbossa.org
  • 9 edits
    1 move
    1 add in trunk/Source/WebKit2

[Qt] [WK2] Move PagePolicyClient related code to QtWebPagePolicyClient
https://bugs.webkit.org/show_bug.cgi?id=72959

Reviewed by Andreas Kling.

Split PagePolicyClient related code from QtWebPageProxy/ClientImpl. The new
QtWebPagePolicyClient registers itself with WKPageRef and it's owned by the
QQuickWebViewPrivate. This is a move to clean up QtWebPageProxy object.

QtPolicyInterface abstraction was not helping us as much as the separation of
the client code will. It was more useful when we had multiple WebViews.

  • Target.pri:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(toPolicyAction):
(QQuickWebViewPrivate::navigationPolicyForURL):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:
  • UIProcess/qt/ClientImpl.cpp:
  • UIProcess/qt/ClientImpl.h:
  • UIProcess/qt/QtWebPagePolicyClient.cpp: Added.

(QtWebPagePolicyClient::QtWebPagePolicyClient):
(QtWebPagePolicyClient::decidePolicyForNavigationAction):
(toQtWebPagePolicyClient):
(toQtMouseButton):
(toQtKeyboardModifiers):
(QtWebPagePolicyClient::decidePolicyForResponse):

  • UIProcess/qt/QtWebPagePolicyClient.h: Renamed from Source/WebKit2/UIProcess/qt/QtPolicyInterface.h.
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::init):

  • UIProcess/qt/QtWebPageProxy.h:
5:15 AM Changeset in webkit [101070] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Add new Chromium tests to the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=72997

Patch by Ryan Sleevi <rsleevi@chromium.org> on 2011-11-23
Reviewed by Ojan Vafai.

  • TestResultServer/static-dashboards/dashboard_base.js:

():

5:10 AM Changeset in webkit [101069] by podivilov@chromium.org
  • 11 edits
    2 adds in trunk

Web Inspector: add integration test for compiler source maps.
https://bugs.webkit.org/show_bug.cgi?id=72730

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/compiler-source-mapping-debug.html

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype._bindScriptToRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype.setCompilerSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype.get executionLineLocation):
(WebInspector.DebuggerPresentationModel.DefaultLinkifierFormatter.prototype.formatRawSourceCodeAnchor):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor):

LayoutTests:

  • http/tests/inspector/compiler-source-mapping-debug-expected.txt: Added.
  • http/tests/inspector/compiler-source-mapping-debug.html: Added.
  • http/tests/inspector/resources/source-map.json:
  • http/tests/inspector/resources/source1.js:
  • http/tests/inspector/resources/source2.js:

(ClickHandler.prototype.handle):

5:03 AM Changeset in webkit [101068] by abarth@webkit.org
  • 3 edits in trunk/Tools

garden-o-matic should support AUDIO failures
https://bugs.webkit.org/show_bug.cgi?id=69477

Reviewed by Dimitri Glazkov.

This is a first iteration at supporting AUDIO failures in
garden-o-matic. We'll probably need to iterate a bit when we have a
real audio failure in the tree to play with. For example, we'll
probably want to add and <audio> element to the "Examine" view to hear
the differences, but that all can be done in a subsequent patch.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
4:48 AM Changeset in webkit [101067] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

Build fix for GTK+.

  • platform/graphics/gtk/DrawingBufferGtk.cpp:

(WebCore::DrawingBuffer::DrawingBuffer): Update signature and ASSERT
for the GTK+ port.

4:19 AM Changeset in webkit [101066] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Remove notifyChange from the public interface of CSSMutableStyleDeclaration
https://bugs.webkit.org/show_bug.cgi?id=72660

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-11-23
Reviewed by Ojan Vafai.

No tests needed. This is only a refactor.

  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
(WebCore::CSSMutableStyleDeclaration::addParsedProperty):

  • css/CSSMutableStyleDeclaration.h:

(WebCore::CSSMutableStyleDeclaration::setProperty):
(WebCore::CSSMutableStyleDeclaration::removeProperty):
(WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):

  • css/CSSStyleSelector.cpp:

(WebCore::leftToRightDeclaration):
(WebCore::rightToLeftDeclaration):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::setContentEditable):

4:16 AM Changeset in webkit [101065] by commit-queue@webkit.org
  • 13 edits
    6 adds in trunk

Adding gamepad support
https://bugs.webkit.org/show_bug.cgi?id=69451

Source/WebCore:

Patch by Scott Graham <scottmg@chromium.org> on 2011-11-23
Reviewed by Darin Fisher.

Plumb gamepad data access through platform.

Test: gamepad/gamepad-polling-access.html

  • WebCore.gypi:
  • page/Navigator.cpp:

(WebCore::Navigator::webkitGamepads):

  • page/Navigator.h:
  • platform/Gamepads.h: Added.
  • platform/chromium/GamepadsChromium.cpp: Added.

(WebCore::sampleGamepads):

  • platform/chromium/PlatformSupport.h:

Source/WebKit/chromium:

Add implementation of sampleGamepads in Chromium platform. Retrieves
gamepad data from Chromium port and converts to DOM format, i.e.
GamepadList.

Patch by Scott Graham <scottmg@chromium.org> on 2011-11-23
Reviewed by Darin Fisher.

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::sampleGamepads):

Tools:

Patch by Scott Graham <scottmg@chromium.org> on 2011-11-23
Reviewed by Darin Fisher.

Add a 'gamepadController' to Chromium DRT. Allows for setting of mock
gamepad data that will be retrieved when JS code pulls via API access.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/GamepadController.cpp: Added.

(GamepadController::GamepadController):
(GamepadController::bindToJavascript):
(GamepadController::reset):
(GamepadController::connect):
(GamepadController::disconnect):
(GamepadController::setId):
(GamepadController::setButtonCount):
(GamepadController::setButtonData):
(GamepadController::setAxisCount):
(GamepadController::setAxisData):
(GamepadController::fallbackCallback):

  • DumpRenderTree/chromium/GamepadController.h: Added.
  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):
(TestShell::resetTestController):
(TestShell::bindJSObjectsToWindow):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell::gamepadController):

LayoutTests:

Patch by Scott Graham <scottmg@chromium.org> on 2011-11-23
Reviewed by Darin Fisher.

  • fast/dom/script-tests/prototype-inheritance.js: Exclude

gamepadController from enumeration.

  • gamepad/gamepad-polling-access-expected.txt: Added.
  • gamepad/gamepad-polling-access.html: Added.
4:06 AM Changeset in webkit [101064] by dslomov@google.com
  • 19 edits in trunk/Source

Source/WebCore: Get rid of WebCore dependencies from TypedArray implementation types
https://bugs.webkit.org/show_bug.cgi?id=72783

Reviewed by David Levin.

Remove WebCore specific logic for neutering Typed Array implementations.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:
  • html/canvas/ArrayBuffer.cpp:

(WTF::ArrayBuffer::transfer):

  • html/canvas/ArrayBuffer.h:
  • html/canvas/ArrayBufferView.cpp:

(WTF::ArrayBufferView::neuter):

  • html/canvas/ArrayBufferView.h:
  • html/canvas/DataView.cpp:

(WebCore::DataView::neuter):

  • html/canvas/DataView.h:
  • html/canvas/Float32Array.h:
  • html/canvas/Float64Array.h:
  • html/canvas/Int16Array.h:
  • html/canvas/Int32Array.h:
  • html/canvas/Int8Array.h:
  • html/canvas/Uint16Array.h:
  • html/canvas/Uint32Array.h:
  • html/canvas/Uint8Array.h:

Source/WebKit/chromium: Get rid of WebCore dependencies from TypedArray implementation types
https://bugs.webkit.org/show_bug.cgi?id=72783
Reviewed by David Levin.

  • src/WebArrayBufferView.cpp: WebCore replaced with WTF
3:55 AM Changeset in webkit [101063] by Nikolas Zimmermann
  • 1 edit
    1 delete in trunk/LayoutTests

2011-11-23 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Rebaseline win results after r101052.

Win/Mac share the same results now, I suspect the same will hold true for gtk/qt/cr.

  • platform/win/svg/dom: Removed.
  • platform/win/svg/dom/length-list-parser-expected.txt: Removed.
3:34 AM Changeset in webkit [101062] by commit-queue@webkit.org
  • 6 edits
    38 adds in trunk

First step towards http://webkit.org/b/70025

Allow -webkit-transform to be have effect to SVG elements.
Currently, the CSS transform takes precedence over the SVG transform attribute

Allow SVG elements to be transformed using webkit-transform
https://bugs.webkit.org/show_bug.cgi?id=71309

Patch by Raul Hudea <rhudea@adobe.com> on 2011-11-23
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Tests: svg/clip-path/clip-path-css-transform-1.svg

svg/clip-path/clip-path-css-transform-2.svg
svg/custom/clip-path-with-css-transform-1.svg
svg/custom/clip-path-with-css-transform-2.svg
svg/custom/pointer-events-image-css-transform.svg
svg/custom/pointer-events-text-css-transform.svg
svg/dom/css-transforms.xhtml
svg/dynamic-updates/SVG-dynamic-css-transform.html
svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting.html
svg/transforms/svg-css-transforms-clip-path.xhtml
svg/transforms/svg-css-transforms.xhtml

  • manual-tests/svg-animation-css-transform.html: Added.
  • manual-tests/svg-css-animate-compound.html: Added.
  • manual-tests/svg-css-transition-compound.html: Added.
  • rendering/svg/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::styleWillChange):

Set the updateTransform flag on SVG elements whenever a CSS transform is present on the style

  • svg/SVGStyledTransformableElement.cpp:

(WebCore::SVGStyledTransformableElement::animatedLocalTransform):

Use the RenderStyle's transform (if it exists) over the SVG's transform

  • svg/SVGTextElement.cpp:

(WebCore::SVGTextElement::animatedLocalTransform):

Use the RenderStyle's transform (if it exists) over the SVG's transform

LayoutTests:

  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/clip-path/clip-path-css-transform-1-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-css-transform-1-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-css-transform-2-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-css-transform-2-expected.txt: Added.
  • platform/mac/svg/custom/clip-path-with-css-transform-1-expected.png: Added.
  • platform/mac/svg/custom/clip-path-with-css-transform-1-expected.txt: Added.
  • platform/mac/svg/custom/clip-path-with-css-transform-2-expected.png: Added.
  • platform/mac/svg/custom/clip-path-with-css-transform-2-expected.txt: Added.
  • platform/mac/svg/custom/pointer-events-image-css-transform-expected.png: Added.
  • platform/mac/svg/custom/pointer-events-image-css-transform-expected.txt: Added.
  • platform/mac/svg/custom/pointer-events-text-css-transform-expected.png: Added.
  • platform/mac/svg/custom/pointer-events-text-css-transform-expected.txt: Added.
  • platform/mac/svg/dom/css-transforms-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png: Added.
  • platform/mac/svg/transforms/svg-css-transforms-clip-path-expected.png: Added.
  • platform/mac/svg/transforms/svg-css-transforms-clip-path-expected.txt: Added.
  • platform/mac/svg/transforms/svg-css-transforms-expected.png: Added.
  • platform/mac/svg/transforms/svg-css-transforms-expected.txt: Added.
  • svg/clip-path/clip-path-css-transform-1.svg: Added.
  • svg/clip-path/clip-path-css-transform-2.svg: Added.
  • svg/custom/clip-path-with-css-transform-1.svg: Added.
  • svg/custom/clip-path-with-css-transform-2.svg: Added.
  • svg/custom/pointer-events-image-css-transform.svg: Added.
  • svg/custom/pointer-events-text-css-transform.svg: Added.
  • svg/dom/css-transforms-expected.txt: Added.
  • svg/dom/css-transforms.xhtml: Added.
  • svg/dynamic-updates/SVG-dynamic-css-transform-expected.txt: Added.
  • svg/dynamic-updates/SVG-dynamic-css-transform.html: Added.
  • svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.txt: Added.
  • svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting.html: Added.
  • svg/dynamic-updates/script-tests/SVGClipPathElement-css-transform-influences-hitTesting.js: Added.

(executeBackgroundTest):
(executeTest):

  • svg/transforms/svg-css-transforms-clip-path.xhtml: Added.
  • svg/transforms/svg-css-transforms.xhtml: Added.
2:46 AM Changeset in webkit [101061] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

[MutationObservers] Cleanup duplicated code in Element & CharacterData
https://bugs.webkit.org/show_bug.cgi?id=72986

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-11-23
Reviewed by Ojan Vafai.

This patch creates a MutationObserverInterestGroup which represents the set
of MutationObservers which should receive all mutations of a given type generated
from a specific node.

No tests needed. This patch is only a refactor.

  • dom/CharacterData.cpp:

(WebCore::CharacterData::dispatchModifiedEvent):

  • dom/ChildListMutationScope.cpp:

(WebCore::MutationAccumulationRouter::ChildListMutationAccumulator::ChildListMutationAccumulator):
(WebCore::MutationAccumulationRouter::ChildListMutationAccumulator::enqueueMutationRecord):
(WebCore::MutationAccumulationRouter::MutationAccumulationRouter::incrementScopingLevel):

  • dom/Element.cpp:

(WebCore::enqueueAttributesMutationRecord):

  • dom/WebKitMutationObserver.cpp:

(WebCore::MutationObserverInterestGroup::createForChildListMutation):
(WebCore::MutationObserverInterestGroup::createForCharacterDataMutation):
(WebCore::MutationObserverInterestGroup::createForAttributesMutation):
(WebCore::MutationObserverInterestGroup::MutationObserverInterestGroup):
(WebCore::MutationObserverInterestGroup::isOldValueRequested):
(WebCore::MutationObserverInterestGroup::enqueueMutationRecord):

  • dom/WebKitMutationObserver.h:

(WebCore::MutationObserverInterestGroup::isEmpty):
(WebCore::MutationObserverInterestGroup::hasOldValue):

2:35 AM Changeset in webkit [101060] by Martin Robinson
  • 5 edits in trunk

[GTK] Enable WebGL by default
https://bugs.webkit.org/show_bug.cgi?id=69706

Reviewed by Xan Lopez.

.:

  • configure.ac: Enable WebGL by default if the build target is X11.

LayoutTests:

  • platform/gtk/Skipped: Skip all WebGL tests until we can ensure they

run properly on the bots.

  • platform/platform/gtk-wk2/Skipped: Ditto.
2:10 AM Changeset in webkit [101059] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[chromium] HDC leak in Uniscribe Helper
https://bugs.webkit.org/show_bug.cgi?id=68598

Patch by Marc-Andre Decoste <mad@chromium.org> on 2011-11-23
Reviewed by Darin Fisher.

For some reason the Script functions on Windows sometimes return
E_PENDING even with a non-NULL DC, so we must handle that case.
Also, we should not use the screen DC to select font since this
refreshes the whole desktop, so I added a cached compatible DC.

Note that this doesn't reproduce with WebKit alone, it only reproduces
within Chrome, so we can't write a WebKit test for it. A chromium
browser test will be added once this change gets rolled in the
chromium DEPS file.

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::shape):
(WebCore::UniscribeHelper::EnsureCachedDCCreated):
(WebCore::UniscribeHelper::fillShapes):

  • platform/graphics/chromium/UniscribeHelper.h:
2:02 AM Changeset in webkit [101058] by commit-queue@webkit.org
  • 5 edits
    5 adds in trunk/Source/WebKit/chromium

[chromium] MediaStream API: Adding embedding code for GetUserMedia
https://bugs.webkit.org/show_bug.cgi?id=71678

This patch includes a fix for https://bugs.webkit.org/show_bug.cgi?id=72925.

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-11-23
Reviewed by Darin Fisher.

  • WebKit.gyp:
  • public/WebUserMediaClient.h: Added.

(WebKit::WebUserMediaClient::~WebUserMediaClient):

  • public/WebUserMediaRequest.h: Added.

(WebKit::WebUserMediaRequest::WebUserMediaRequest):
(WebKit::WebUserMediaRequest::~WebUserMediaRequest):
(WebKit::WebUserMediaRequest::operator=):
(WebKit::WebUserMediaRequest::isNull):
(WebKit::operator==):

  • public/WebViewClient.h:

(WebKit::WebViewClient::userMediaClient):

  • src/UserMediaClientImpl.cpp: Added.

(WebKit::UserMediaClientImpl::UserMediaClientImpl):
(WebKit::UserMediaClientImpl::pageDestroyed):
(WebKit::UserMediaClientImpl::requestUserMedia):
(WebKit::UserMediaClientImpl::cancelUserMediaRequest):

  • src/UserMediaClientImpl.h: Added.
  • src/WebUserMediaRequest.cpp: Added.

(WebKit::WebUserMediaRequest::WebUserMediaRequest):
(WebKit::WebUserMediaRequest::reset):
(WebKit::WebUserMediaRequest::audio):
(WebKit::WebUserMediaRequest::video):
(WebKit::WebUserMediaRequest::cameraPreferenceUser):
(WebKit::WebUserMediaRequest::cameraPreferenceEnvironment):
(WebKit::WebUserMediaRequest::securityOrigin):
(WebKit::WebUserMediaRequest::requestSucceeded):
(WebKit::WebUserMediaRequest::requestFailed):
(WebKit::WebUserMediaRequest::equals):
(WebKit::WebUserMediaRequest::assign):
(WebKit::WebUserMediaRequest::operator UserMediaRequest*):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

  • src/WebViewImpl.h:
1:25 AM Changeset in webkit [101057] by annacc@chromium.org
  • 19 edits in trunk

Move readyState from TextTrack to HTMLTrackElement
https://bugs.webkit.org/show_bug.cgi?id=72553

Reviewed by Eric Carlson.

Source/WebCore:

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::HTMLTrackElement):

Set initial readyState to NONE.

(WebCore::HTMLTrackElement::didCompleteLoad):

Set readyState based on load completed status.

(WebCore::HTMLTrackElement::setReadyState):

This replaces textTrackReadyStateChanged() because only LoadableTextTrack
needs to notify HTMLTrackElement of readyState changes (i.e.
textTrackReadyStateChanged() is no longer required of TextTrackClient).

  • html/HTMLTrackElement.h:

ReadyState enum and m_readyState member variable moved from TextTrack.

(WebCore::HTMLTrackElement::readyState):

New: readyState() getter.

  • html/HTMLTrackElement.idl:

Add readyState attribute and associated constants.

  • html/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::loadTimerFired): Set readyState on HTMLTrackElement.
(WebCore::LoadableTextTrack::cueLoadingStarted): Ditto.
(WebCore::LoadableTextTrack::cueLoadingCompleted): Move code to set readyState

to HTMLTrackElement (it can set it based on loading status).

  • html/TextTrack.cpp: Remove readyState from TextTrack.

(WebCore::TextTrack::TextTrack): Ditto.

  • html/TextTrack.h: Ditto.
  • html/TextTrack.idl: Ditto.

LayoutTests:

  • media/track/track-add-track-expected.txt:
  • media/track/track-add-track.html:
  • media/track/track-constants-expected.txt:
  • media/track/track-constants.html:
  • media/track/track-load-error-readyState-expected.txt:
  • media/track/track-load-error-readyState.html:
  • media/track/track-load-from-element-readyState-expected.txt:
  • media/track/track-load-from-element-readyState.html:
  • media/track/track-load-from-src-readyState-expected.txt:
  • media/track/track-load-from-src-readyState.html:
1:22 AM Changeset in webkit [101056] by Nikolas Zimmermann
  • 11 edits in trunk

Add flags/precision arguments to String::number(double) to allow fine-grained control over the result string
https://bugs.webkit.org/show_bug.cgi?id=72793

Reviewed by Zoltan Herczeg.

Source/JavaScriptCore:

This new code will be used in follow-up patches to replace the String::format("%.2f") usage in
platform/text/TextStream.cpp, and String::format("%.6lg") usage in svg/SVGPathStringBuilder.cpp.

The String::number(double) currently calls String::format("%.6lg") in trunk. In order to replace
this by a variant that properly rounds to six significant figures, JSC code could be refactored.
JSCs Number.toPrecision/toFixed uses wtf/dtoa/double-conversion which provides all features we need,
except truncating trailing zeros, needed to mimic the "g" format, which is either f or e but with
trailing zeros removed, producing shorter results. Changed the default signature to:

"static String number(double, unsigned = ShouldRoundSignificantFigures | ShouldTruncateTrailingZeros, unsigned precision = 6);".

In WebCore we can now replace String::format() calls like this:
String::format("%.2f", f) -> String::number(f, ShouldRoundDecimalPlaces, 2)
String::format("%.6lg", f) -> String::number(f)

The default parameters for precison & flags exactly match the format of the string produced now, except that the result
is rounded according to the rounding mode / formatting mode and precision. This paves the way towards reliable results
in the d="" attribute dumps of SVG paths across platforms. The dtoa rounding code enforces a unique zero, resolving
all 0.0 vs. -0.0 issues currently seen on Windows, and some Gtk/Qt bots.

This patch needs a rebaseline of svg/dom/length-list-parser.html as we don't perfecly mimic the String::format() "lg" mode
result for exponentials, we used to return eg. "e-7" and now return "e-07" - the trailing zero truncation hasn't been
implemented for exponentials, as this really affects only this test and thus wasn't worth the trouble - in contrary the
trailing zero truncation is needed for thousands of other results in "f" notation, and thus needed to match the DRT results.

Here's a performance comparision using a JSC release build and some arbitary numbers:
Converting 123.456 using old approach took 95.527100ms. avg 0.000955ms/call.
Converting 123.456 using new approach took 28.126953ms. avg 0.000281ms/call.

Converting 123 using old approach took 85.411133ms. avg 0.000854ms/call.
Converting 123 using new approach took 24.190186ms. avg 0.000242ms/call.

Converting 0.1 using old approach took 92.622803ms. avg 0.000926ms/call.
Converting 0.1 using new approach took 23.317871ms. avg 0.000233ms/call.

Converting 1/i using old approach took 106.893066ms. avg 0.001069ms/call.
Converting 1/i using new approach took 27.164062ms. avg 0.000272ms/call.

For all numbers I've tested in RoundingSignificantFigures mode and 6 digit precision the speedup was at least 250%.

  • JavaScriptCore.exp: Change String::number(double) signature.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Ditto.
  • runtime/NumberPrototype.cpp:

(JSC::numberProtoFuncToFixed): Refactor this into numberToFixedPrecisionString(), move to wtf/dtoa.cpp.
(JSC::numberProtoFuncToPrecision): Ditto, refactor this into numberToFixedWidthString.

  • wtf/dtoa.cpp: Moved fixedWidth/Precision helpers into dtoa, extend numberToFixedPrecisionString(). Add a mode which allows to truncate trailing zeros/decimal point.

to make it possible to use them to generate strings that match the output from String::format("%6.lg"), while using our dtoas rounding facilities.

  • wtf/dtoa.h:
  • wtf/dtoa/utils.h: Expose new helper method, which allows us to truncate the result, before generating the output const char*.

(WTF::double_conversion::StringBuilder::SetPosition):

  • wtf/text/WTFString.cpp:

(WTF::String::number): Remove String::format("%6.lg") usage! Switch to rounding to six significant figures, while matching the output of String::format.

  • wtf/text/WTFString.h:

LayoutTests:

Rebaseline one test result, after the String::number(double) changes. Trailing zeros are no longer removed
in the exponential form of the string: e-07 is reported instead of e-7 now. It was decided to leave it as-is
and not introduce trailing zero removal for the exponential formatting, as it only affects this test.

I'll rebaseline other platforms once results are available.

  • svg/dom/length-list-parser-expected.txt:
1:20 AM Changeset in webkit [101055] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Expose showFPSCounter and showPlatformLayerTree in WebLayerTreeView::Settings
https://bugs.webkit.org/show_bug.cgi?id=72973

Patch by Antoine Labour <piman@chromium.org> on 2011-11-23
Reviewed by Darin Fisher.

  • public/WebLayerTreeView.h:

(WebKit::WebLayerTreeView::Settings::Settings):

  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCSettings):

1:10 AM Changeset in webkit [101054] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

WTF::String has extra WTF_EXPORT_PRIVATE
https://bugs.webkit.org/show_bug.cgi?id=72858

Patch by Hajime Morrita <morrita@chromium.org> on 2011-11-23
Reviewed by Kevin Ollivier.

  • wtf/text/WTFString.h:

(WTF::String::String):

1:09 AM Changeset in webkit [101053] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skip failing accessibility test on GTK.

  • platform/gtk/Skipped: Skip accessibility/multiselect-list-reports-active-option.html
1:08 AM Changeset in webkit [101052] by Patrick Gansterer
  • 15 edits
    1 copy
    2 moves
    1 add in trunk

[CMake] Move the top-level logic to the top-level directory.
https://bugs.webkit.org/show_bug.cgi?id=72685

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-23
Reviewed by Brent Fulgham.

.:

Move most of the top-level code in Source/CMakeLists.txt to
CMakeLists.txt. This allows us to replace some INCLUDE() hacks with
proper ADD_SUBDIRECTORY() calls, and actually moves non-Source related
to a non-Source directory.

  • CMakeLists.txt: Copied from Source/CMakeLists.txt.

Source/JavaScriptCore:

  • CMakeLists.txt: Point to the right Source/ directory.
  • wtf/CMakeLists.txt: Ditto.

Source/WebCore:

No new tests, this is a buildsystem changes.

  • CMakeLists.txt: Adjust the Source/ directory.
  • PlatformBlackBerry.cmake: Ditto.

Source/WebKit:

  • blackberry/CMakeListsBlackBerry.txt: Adjust the Source/ directory.

Source/WebKit2:

  • CMakeLists.txt: Adjust Source/ directory.

Tools:

  • CMakeLists.txt: Added.
  • DumpRenderTree/efl/CMakeLists.txt: Keep building into Programs/.
  • EWebLauncher/CMakeLists.txt: Renamed from Tools/CMakeListsEfl.txt.
  • Scripts/webkitdirs.pm:

(generateBuildSystemFromCMakeProject):

  • WinCELauncher/CMakeLists.txt: Renamed from Tools/CMakeListsWinCE.txt.
1:00 AM Changeset in webkit [101051] by Philippe Normand
  • 1 edit
    3 adds in trunk/LayoutTests

Unreviewed, GTK baselines for 3 new tests.

  • platform/gtk/animations/additive-transform-animations-expected.txt: Added.
  • platform/gtk/css3/images/cross-fade-overflow-position-expected.txt: Added.
  • platform/gtk/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Added.
12:55 AM Changeset in webkit [101050] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skip failing editing/spelling/spellcheck-async.html
test on GTK.

  • platform/gtk/Skipped:
12:48 AM Changeset in webkit [101049] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

Documentation fix for load-committed in webkitwebframe
https://bugs.webkit.org/show_bug.cgi?id=72927

Patch by Kaustubh Atrawalkar <Kaustubh Atrawalkar> on 2011-11-23
Reviewed by Martin Robinson.

  • webkit/webkitwebframe.cpp:

(webkit_web_frame_class_init):

12:42 AM Changeset in webkit [101048] by mihnea@adobe.com
  • 12 edits
    3 copies
    3 moves in trunk

CSS Exclusions: update the name of the shape CSS properties
https://bugs.webkit.org/show_bug.cgi?id=71898
Instead of a single wrap-shape property, we have wrap-shape-inside and wrap-shape-outside.

Reviewed by Dean Jackson.

Source/WebCore:

Tests: fast/exclusions/parsing-wrap-shape-inside.html

fast/exclusions/parsing-wrap-shape-outside.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseWrapShape):

  • css/CSSParser.h:
  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::setWrapShapeInside):
(WebCore::InheritedFlags::wrapShapeInside):
(WebCore::InheritedFlags::setWrapShapeOutside):
(WebCore::InheritedFlags::wrapShapeOutside):
(WebCore::InheritedFlags::initialWrapShapeInside):
(WebCore::InheritedFlags::initialWrapShapeOutside):

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

  • fast/exclusions/parsing-wrap-shape-inside-expected.txt: Copied from LayoutTests/fast/exclusions/parsing-wrap-shape-expected.txt.
  • fast/exclusions/parsing-wrap-shape-inside.html: Copied from LayoutTests/fast/exclusions/parsing-wrap-shape.html.
  • fast/exclusions/parsing-wrap-shape-outside-expected.txt: Renamed from LayoutTests/fast/exclusions/parsing-wrap-shape-expected.txt.
  • fast/exclusions/parsing-wrap-shape-outside.html: Renamed from LayoutTests/fast/exclusions/parsing-wrap-shape.html.
  • fast/exclusions/script-tests/parsing-wrap-shape-inside.js: Copied from LayoutTests/fast/exclusions/script-tests/parsing-wrap-shape.js.
  • fast/exclusions/script-tests/parsing-wrap-shape-outside.js: Renamed from LayoutTests/fast/exclusions/script-tests/parsing-wrap-shape.js.
12:29 AM Changeset in webkit [101047] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Extensions API] avoid exception in initExtensions() if elements panel is not present
https://bugs.webkit.org/show_bug.cgi?id=73007

Reviewed by Yury Semikhatsky.

  • inspector/front-end/ExtensionServer.js:
12:26 AM Changeset in webkit [101046] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Use new name for pixel config field of GrTextureDesc
https://bugs.webkit.org/show_bug.cgi?id=72543

Patch by Brian Salomon <bsalomon@google.com> on 2011-11-23
Reviewed by Stephen White.

Tested by every canvas2d layout test.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::createAcceleratedCanvas):

12:21 AM Changeset in webkit [101045] by eae@chromium.org
  • 7 edits in trunk/Source/WebCore

Change remaining scrollTop/Left/Width/Height methods back to int
https://bugs.webkit.org/show_bug.cgi?id=72771

Reviewed by Eric Seidel.

Change remaining scrollTop/Left/Width/Height, setScrollLeft/Top and
verticalScrollbarWidth, horizontalScrollbarHeight methods back to int as
scrolling will remain int based to line up with device pixels.

No new tests.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::scrollWidth):
(WebCore::RenderBox::scrollHeight):
(WebCore::RenderBox::scrollLeft):
(WebCore::RenderBox::scrollTop):
(WebCore::RenderBox::setScrollLeft):
(WebCore::RenderBox::setScrollTop):
(WebCore::RenderBox::verticalScrollbarWidth):
(WebCore::RenderBox::horizontalScrollbarHeight):

  • rendering/RenderBox.h:

(WebCore::RenderBox::scrollbarLogicalHeight):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::verticalScrollbarWidth):
(WebCore::RenderListBox::scrollHeight):
(WebCore::RenderListBox::scrollLeft):
(WebCore::RenderListBox::setScrollLeft):
(WebCore::RenderListBox::scrollTop):
(WebCore::RenderListBox::setScrollTop):

  • rendering/RenderListBox.h:
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::scrollWidth):
(WebCore::RenderTextControlSingleLine::scrollHeight):
(WebCore::RenderTextControlSingleLine::scrollLeft):
(WebCore::RenderTextControlSingleLine::scrollTop):
(WebCore::RenderTextControlSingleLine::setScrollLeft):
(WebCore::RenderTextControlSingleLine::setScrollTop):

  • rendering/RenderTextControlSingleLine.h:
Note: See TracTimeline for information about the timeline view.