Timeline


and

12/05/11:

23:51 Changeset [102103] by ossy@webkit.org

[Qt] Unreviewed gardening.

New test introduced in r102048 fails on Qt-WK1
https://bugs.webkit.org/show_bug.cgi?id=73366

  • platform/qt-wk1/Skipped: Skip fast/events/dont-loose-last-event.html
23:49 Changeset [102102] by commit-queue@webkit.org

[MutationObservers] Enable in Chromium trunk
https://bugs.webkit.org/show_bug.cgi?id=73851

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-12-05
Reviewed by Ojan Vafai.

  • features.gypi:
23:45 Changeset [102101] by jamesr@google.com

chromium build fix

  • src/WebLayerTreeView.cpp:
23:37 Changeset [102100] by commit-queue@webkit.org

[MutationObservers] Support 'attributes' mutation records for element.removeAttribute
https://bugs.webkit.org/show_bug.cgi?id=73880

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-12-05
Reviewed by Ojan Vafai.

Source/WebCore:

  • dom/Element.cpp:

(WebCore::enqueueAttributesMutationRecord):
(WebCore::Element::removeAttribute):

LayoutTests:

  • fast/mutation/observe-attributes-expected.txt:
  • fast/mutation/observe-attributes.html:
23:24 Changeset [102099] by jamesr@google.com

Rollout http://trac.webkit.org/changeset/102019, dependent has not
landed in chromium

  • WebKit.gyp:
  • public/WebContentLayer.h: Added.
  • public/WebExternalTextureLayer.h: Added.
  • public/WebLayer.h: Added.
  • public/WebLayerClient.h: Added.
  • public/WebLayerTreeView.h: Added.
  • public/WebLayerTreeViewClient.h: Added.
  • src/WebLayerTreeView.cpp:
  • src/WebLayerTreeViewImpl.cpp:
22:56 Changeset [102098] by commit-queue@webkit.org

Set opaque flag for WebGLLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=73876

Patch by Dana Jansens <danakj@chromium.org> on 2011-12-05
Reviewed by James Robinson.

Source/WebCore:

New unit test in tests/WebGLLayerChromiumTest.cpp

  • platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBuffer::platformLayer):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/WebGLLayerChromiumTest.cpp: Added.

(WebKit::CompositorMockWebGraphicsContext3D::create):
(WebKit::CompositorMockWebGraphicsContext3D::makeContextCurrent):
(WebKit::CompositorMockWebGraphicsContext3D::createProgram):
(WebKit::CompositorMockWebGraphicsContext3D::createShader):
(WebKit::CompositorMockWebGraphicsContext3D::getShaderiv):
(WebKit::CompositorMockWebGraphicsContext3D::getProgramiv):
(WebKit::CompositorMockWebGraphicsContext3D::getContextAttributes):
(WebKit::CompositorMockWebGraphicsContext3D::CompositorMockWebGraphicsContext3D):
(WebKit::createGraphicsContext):
(WebKit::TEST):

22:31 Changeset [102097] by benjamin@webkit.org

Upstream the Cursor implementation of iOS
https://bugs.webkit.org/show_bug.cgi?id=73724

Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-12-05
Reviewed by David Kilzer.

iOS does not need to support the Cursor of WebKit. For compatibility, Cursor
is implemented as an empty class on the platform.

  • Configurations/WebCore.xcconfig:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/Cursor.h:

(WebCore::Cursor::Cursor):

  • platform/ios/CursorIOS.cpp: Added.

(WebCore::cursor):
(WebCore::pointerCursor):
(WebCore::crossCursor):
(WebCore::handCursor):
(WebCore::moveCursor):
(WebCore::iBeamCursor):
(WebCore::waitCursor):
(WebCore::helpCursor):
(WebCore::eastResizeCursor):
(WebCore::northResizeCursor):
(WebCore::northEastResizeCursor):
(WebCore::northWestResizeCursor):
(WebCore::southResizeCursor):
(WebCore::southEastResizeCursor):
(WebCore::southWestResizeCursor):
(WebCore::westResizeCursor):
(WebCore::northSouthResizeCursor):
(WebCore::eastWestResizeCursor):
(WebCore::northEastSouthWestResizeCursor):
(WebCore::northWestSouthEastResizeCursor):
(WebCore::columnResizeCursor):
(WebCore::rowResizeCursor):
(WebCore::middlePanningCursor):
(WebCore::eastPanningCursor):
(WebCore::northPanningCursor):
(WebCore::northEastPanningCursor):
(WebCore::northWestPanningCursor):
(WebCore::southPanningCursor):
(WebCore::southEastPanningCursor):
(WebCore::southWestPanningCursor):
(WebCore::westPanningCursor):
(WebCore::verticalTextCursor):
(WebCore::cellCursor):
(WebCore::contextMenuCursor):
(WebCore::noDropCursor):
(WebCore::notAllowedCursor):
(WebCore::progressCursor):
(WebCore::aliasCursor):
(WebCore::zoomInCursor):
(WebCore::zoomOutCursor):
(WebCore::copyCursor):
(WebCore::noneCursor):
(WebCore::grabCursor):
(WebCore::grabbingCursor):
(WebCore::determineHotSpot):

22:20 Changeset [102096] by noel.gordon@gmail.com

[GTK] GIF image test crashes on 32- and 64-bit Release
https://bugs.webkit.org/show_bug.cgi?id=73812

Reviewed by Adam Barth.

Call resize() on the image pixel backing store after allocation to see if
that stops the GIF image decoder animation tests crashes on GTK.

No new tests, covered by exiting tests ...

fast/backgrounds/animated-gif-as-background.html
fast/images/dont-crash-with-null-gif-frames.html
fast/images/gif-loop-count.html

  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageFrame::setSize):

22:13 Changeset [102095] by arv@chromium.org

Could save a lot of memory in CharacterData by not always storing a String
https://bugs.webkit.org/show_bug.cgi?id=72404

Reviewed by Ojan Vafai.

When a Text node is created by the parser we check if the string is all whitespace
and if so we put it in the AtomicString table so that all future identical whitespace
strings can share the StringImpl.

No new tests. Covered by existing tests.

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLNames::isAllWhitespace):
(WebCore::HTMLConstructionSite::insertTextNode):

If we do not know whether the string is all whitespace this now checks the string
If the string is all whitespace we create an AtomicString for it.

  • html/parser/HTMLConstructionSite.h:
  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::skipLeadingNonWhitespace): We never cared about the return value here.
(WebCore::HTMLTreeBuilder::processCharacterBuffer): Pass WhitespaceMode in the case we know whether the string is all whitespace or not.
(WebCore::HTMLTreeBuilder::defaultForInTableText): Ditto.

22:10 Changeset [102094] by benjamin@webkit.org

Update KURL's copy copyASCII to avoid String::characters()
https://bugs.webkit.org/show_bug.cgi?id=73794

Reviewed by Andreas Kling.

When the String is already on 8 bits, we can simply copy the
data. In the 16 bits case, everything remains the same.

  • platform/KURL.cpp:

(WebCore::copyASCII):
(WebCore::appendASCII):
(WebCore::KURL::init):
(WebCore::KURL::parse):
(WebCore::KURL::copyToBuffer):

21:55 Changeset [102093] by commit-queue@webkit.org

[Qt] MiniBrowser should default to touch behavior
https://bugs.webkit.org/show_bug.cgi?id=73863

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2011-12-05
Reviewed by Chang Shu.

MiniBrowser currently defaults to the traditional desktop behaviour
instead of touch behaviour which is prefered.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):

  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(printHelp):
(MiniBrowserApplication::handleUserOptions):

  • MiniBrowser/qt/MiniBrowserApplication.h:

(WindowOptions::WindowOptions):
(WindowOptions::setUseTraditionalDesktopBehavior):
(WindowOptions::useTraditionalDesktopBehavior):

21:30 Changeset [102092] by commit-queue@webkit.org

https://bugs.webkit.org/show_bug.cgi?id=73683
Implement KeyframeValueList::operator=() and KeyframeValueList::swap().

Patch by Yong Li <yoli@rim.com> on 2011-12-05
Reviewed by Darin Adler.

No new tests as no functional change.

  • platform/graphics/GraphicsLayer.h:

(WebCore::KeyframeValueList::operator=): Added
(WebCore::KeyframeValueList::swap): Added

21:05 Changeset [102091] by enne@google.com

[chromium] setNeedsCommit on non-composited host layers should trigger commit
https://bugs.webkit.org/show_bug.cgi?id=73711

Reviewed by James Robinson.

Source/WebCore:

Pipe non-composited content host syncs to setNeedsCommit.

Since now the NonCompositedContentHost generates setNeedsCommit, don't
call it unnecessarily, e.g. calling setBackgroundColor to the same
color each frame should not retrigger more commits.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setAnchorPoint):
(WebCore::GraphicsLayerChromium::setTransform):
(WebCore::GraphicsLayerChromium::setChildrenTransform):
(WebCore::GraphicsLayerChromium::setMasksToBounds):
(WebCore::GraphicsLayerChromium::setBackgroundColor):
(WebCore::GraphicsLayerChromium::clearBackgroundColor):
(WebCore::GraphicsLayerChromium::setContentsOpaque):
(WebCore::GraphicsLayerChromium::setBackfaceVisibility):
(WebCore::GraphicsLayerChromium::setOpacity):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setNeedsCommit):
(WebCore::LayerChromium::setAnchorPoint):
(WebCore::LayerChromium::setAnchorPointZ):
(WebCore::LayerChromium::setBackgroundColor):
(WebCore::LayerChromium::setMasksToBounds):
(WebCore::LayerChromium::setMaskLayer):
(WebCore::LayerChromium::setOpacity):
(WebCore::LayerChromium::setOpaque):
(WebCore::LayerChromium::setPosition):
(WebCore::LayerChromium::setSublayerTransform):
(WebCore::LayerChromium::setTransform):
(WebCore::LayerChromium::setScrollPosition):
(WebCore::LayerChromium::setScrollable):
(WebCore::LayerChromium::setDoubleSided):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::setReplicaLayer):

  • platform/graphics/chromium/NonCompositedContentHost.cpp:

(WebCore::NonCompositedContentHost::notifySyncRequired):

  • platform/graphics/chromium/NonCompositedContentHost.h:

Source/WebKit/chromium:

Add some tests to make sure that modifying the noncomposited content
host triggers commits.

Properties that trigger setNeedsCommit should only do so when the
property changes. Additionally, make more property changes properly
trigger commits.

  • tests/LayerChromiumTest.cpp:
20:59 Changeset [102090] by tony@chromium.org

small refactor of RenderFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=73854

Reviewed by Darin Adler.

No new tests, just a refactor.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::isLeftToRightFlow): Inline isReverseFlow since it's only used in one place.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Rename startEdge
to mainAxisOffset. Rename logicalTop to crossAxisOffset. Get rid of
logicalLeft local variable since it's confusing. Move shouldFlipMainAxis
out of the for loop to avoid computing it each iteration.

  • rendering/RenderFlexibleBox.h:
20:46 Changeset [102089] by commit-queue@webkit.org

Heap-buffer-overflow in WebCore::HTMLTreeBuilder::processEndTag
https://bugs.webkit.org/show_bug.cgi?id=73765

Patch by Florin Malita <fmalita@google.com> on 2011-12-05
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/parser/foreign-content-crash.html

Use m_tree.currentNode() instead of m_tree.currentElement() as the top node is not always an Element.

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processEndTag):

LayoutTests:

  • fast/parser/foreign-content-crash-expected.txt: Added.
  • fast/parser/foreign-content-crash.html: Added.
20:16 Changeset [102088] by senorblanco@chromium.org

Allow the ImageBuffers used by SVG filters to be accelerated
https://bugs.webkit.org/show_bug.cgi?id=73842

Reviewed by Kenneth Russell.

Source/WebCore:

Regressions covered by existing SVG tests; new functionality to be
tested by the API exposed on Internals.

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setAcceleratedFiltersEnabled):
(WebCore::Settings::acceleratedFiltersEnabled):

  • platform/graphics/filters/FETile.cpp:

(WebCore::FETile::platformApplySoftware):

  • platform/graphics/filters/Filter.h:

(WebCore::Filter::Filter):
(WebCore::Filter::renderingMode):
(WebCore::Filter::setRenderingMode):

  • platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::asImageBuffer):
(WebCore::FilterEffect::createImageBufferResult):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::platformTransformColorSpace):

  • rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::applyClippingToContext):

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::applyResource):

  • rendering/svg/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::applyResource):

  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::createTileImage):

  • rendering/svg/SVGImageBufferTools.cpp:

(WebCore::SVGImageBufferTools::createImageBuffer):

  • rendering/svg/SVGImageBufferTools.h:
  • testing/Internals.cpp:

(WebCore::Internals::setAcceleratedFiltersEnabled):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit/chromium:

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setAcceleratedFiltersEnabled):

  • src/WebSettingsImpl.h:
20:07 Changeset [102087] by igor.oliveira@openbossa.org

[Qt][WK2] Frame is not being showed in the screen when frameLoadCompleted is called
https://bugs.webkit.org/show_bug.cgi?id=73850

WebKit2 has a mechanism to prevent the composited layer tree of the outgoing page
from being torn down or updated until the incoming page has layout. However, for simple
pages, when the frame is loaded the page is not rendered in the screen.

This patch fixes this bug calling LayerTreeHostQt::scheduleLayerFlush when m_layerFlushSchedulingEnabled
is true.

Reviewed by Noam Rosenthal.

  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::setLayerFlushSchedulingEnabled):

19:48 Changeset [102086] by benjamin@webkit.org

Upstream htmlSelectMultipleItems needed for <select multiple> by iOS
https://bugs.webkit.org/show_bug.cgi?id=73734

Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-12-05
Reviewed by David Kilzer.

  • platform/DefaultLocalizationStrategy.cpp:

(WebCore::DefaultLocalizationStrategy::htmlSelectMultipleItems):

  • platform/DefaultLocalizationStrategy.h:
18:55 Changeset [102085] by darin@apple.com

Use HashMap<OwnPtr> in CrossOriginPreflightResultCache
https://bugs.webkit.org/show_bug.cgi?id=73785

Reviewed by Andreas Kling.

  • loader/CrossOriginPreflightResultCache.cpp:

(WebCore::CrossOriginPreflightResultCache::appendEntry): Changed code to use set
instead of add, since it wants to replace existing entries. Also removed leakPtr
and removed the FIXME that documented the memory leak now fixed here.
(WebCore::CrossOriginPreflightResultCache::canSkipPreflight): Removed unneeded
std:: prefix here and also unneeded explicit delete call.
(WebCore::CrossOriginPreflightResultCache::empty): Removed unneeded deleteAllValues
call here.

  • loader/CrossOriginPreflightResultCache.h: Make mapped value of the

CrossOriginPreflightResultHashMap be OwnPtr instead of raw pointer.

18:17 Changeset [102084] by andersca@apple.com

Add HashMap::keys() and HashMap::values() for easy iteration of hash map keys and values in C++11.

Reviewed by Darin Adler.

  • wtf/HashMap.h:
18:07 Changeset [102083] by kubo@profusion.mobi

webkit.py: Really fix the printing of StringImpl now that 8-bit strings are present.
https://bugs.webkit.org/show_bug.cgi?id=73878

Reviewed by Tony Chang.

r98624 turned StringImpl::m_data into StringImpl::{m_data8,m_data16}.
r98785 made webkit.py always use m_data16, which does not work when
the string is an 8-bit string (such as KURL::string()).

I was not able to directly call StringImpl::is8Bit() in the Python
code, so I just reproduced the implementation there.

  • gdb/webkit.py:

(WTFStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
(WTFStringPrinter.to_string):
(JSCUStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
(JSCUStringPrinter.to_string):

18:06 Changeset [102082] by msaboff@apple.com

Create StringImpl::empty() as an 8 bit string
https://bugs.webkit.org/show_bug.cgi?id=73871

Reviewed by Oliver Hunt.

  • wtf/text/StringStatics.cpp:

(WTF::StringImpl::empty): Changed to be an 8 bit string.

18:04 Changeset [102081] by darin@apple.com

Some small improvements to ContainerNode.h
https://bugs.webkit.org/show_bug.cgi?id=73786

Reviewed by Alexey Proskuryakov.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::suspendPostAttachCallbacks): Added a FIXME comment about the
peculiar behavior of this function. Somehow the post-attach suspend state is both
global and specific to a certain Page object. That can't be right. If it was truly
global then this would be a static member function. If it was truly per-page, then
the related functions could not be static.

  • dom/ContainerNode.h: Removed some unneeded argument names. Moved the hasChildNodes

function up with the other basic getters. Put the other getters, childNodeCount and
childNode, right after the basic getters. Used ASSERT_NO_EXCEPTION in all the basic
mutation functions so they can be used in a cleaner fashion in C++ code where we have
some reason to know an exception won't occur. Grouped all the overrides of functions
from Node into a single paragraph and used the OVERRIDE macro on all of them. Made the
queuePostAttachCallback and postAttachCallbacksAreSuspended functions protected.

  • dom/Element.h: Moved the include of ExceptionCodePlaceholder.h into ContainerNode.h.
  • dom/Node.cpp:

(WebCore::Node::lazyAttach): Use hasChildNodes instead of firstChild for clarity.
(WebCore::Node::isDescendantOf): Ditto.

17:51 Changeset [102080] by benjamin@webkit.org

Get rid of KURL::KURL(ParsedURLStringTag, const char*);
https://bugs.webkit.org/show_bug.cgi?id=73792

Reviewed by Andreas Kling.

In all cases where the constructor is used, the constructor
taking a String is as effective because the string is valid and converted
to String for m_string.

This patch remove the constructor KURL::KURL(ParsedURLStringTag, const char*)
and change the call sites that were using that constructor to build
empty URLs.

  • dom/Document.cpp:

(WebCore::Document::initSecurityContext):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::init):

  • loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::create):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::createWindow):

  • platform/KURL.cpp:
  • platform/KURL.h:
  • platform/KURLGoogle.cpp:
17:41 Changeset [102079] by timothy_horton@apple.com

Unreviewed extremely minor SVG filter pixel rebaselines for Lion.

Mostly text antialiasing differences, all only noticeable at tolerances very near 0.

  • platform/mac-snowleopard/svg/filters/feComposite-expected.png: Copied from LayoutTests/platform/mac/svg/filters/feComposite-expected.png.
  • platform/mac-snowleopard/svg/filters/feLighting-crash-expected.png: Copied from LayoutTests/platform/mac/svg/filters/feLighting-crash-expected.png.
  • platform/mac-snowleopard/svg/filters/feOffset-expected.png: Copied from LayoutTests/platform/mac/svg/filters/feOffset-expected.png.
  • platform/mac-snowleopard/svg/filters/filter-on-tspan-expected.png: Copied from LayoutTests/platform/mac/svg/filters/filter-on-tspan-expected.png.
  • platform/mac-snowleopard/svg/filters/filter-width-update-expected.png: Copied from LayoutTests/platform/mac/svg/filters/filter-width-update-expected.png.
  • platform/mac-snowleopard/svg/filters/sourceAlpha-expected.png: Copied from LayoutTests/platform/mac/svg/filters/sourceAlpha-expected.png.
  • platform/mac-snowleopard/svg/filters/subRegion-one-effect-expected.png: Copied from LayoutTests/platform/mac/svg/filters/subRegion-one-effect-expected.png.
  • platform/mac-snowleopard/svg/filters/subRegion-two-effects-expected.png: Copied from LayoutTests/platform/mac/svg/filters/subRegion-two-effects-expected.png.
  • platform/mac/svg/filters/feComposite-expected.png:
  • platform/mac/svg/filters/feLighting-crash-expected.png:
  • platform/mac/svg/filters/feOffset-expected.png:
  • platform/mac/svg/filters/filter-on-tspan-expected.png:
  • platform/mac/svg/filters/filter-width-update-expected.png:
  • platform/mac/svg/filters/sourceAlpha-expected.png:
  • platform/mac/svg/filters/subRegion-one-effect-expected.png:
  • platform/mac/svg/filters/subRegion-two-effects-expected.png:
17:35 Changeset [102078] by abarth@webkit.org

[Chromium] Chromium fails to compile due to missing WebContentLayerClient.h
https://bugs.webkit.org/show_bug.cgi?id=73881

This patch adds a forwarding header to fix the downstream Windows build:
http://build.chromium.org/p/chromium.webkit/builders/Win%20Builder/builds/12955/steps/compile/logs/stdio

  • public/WebContentLayerClient.h: Added.
17:35 Changeset [102077] by lforschler@apple.com

Versioning.

17:34 Changeset [102076] by lforschler@apple.com

New tag.

17:30 Changeset [102075] by timothy_horton@apple.com

Unreviewed feGaussianBlur rebaseline for Mac after r101638.

  • platform/mac/svg/filters/feGaussianBlur-expected.png:
17:29 Changeset [102074] by abarth@webkit.org

Add a shim to fix the downstream Chromium compile. The real fix should
be made downstream via http://codereview.chromium.org/8801036/, but the
Chromium tree is closed at the moment.

  • public/WebRect.h: Added.
17:10 Changeset [102073] by benjamin@webkit.org

Remove methods declared but never implemented with GOOGLEURL
https://bugs.webkit.org/show_bug.cgi?id=73795

Reviewed by Adam Barth.

  • platform/KURL.h:
17:08 Changeset [102072] by eric@webkit.org

Up the "expected ram for each DRT instance" to 400MB instead of 300MB
in hopes of making the Snow Leopard bot stop timing out.

Unreviewed.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.default_child_processes):

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_default_child_processes):

17:03 Changeset [102071] by darin@apple.com

Change CSSFontSelector to use HashMap<OwnPtr>
https://bugs.webkit.org/show_bug.cgi?id=73781

Reviewed by Dan Bernstein.

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::~CSSFontSelector): Removed calls to deleteAllValues.
(WebCore::CSSFontSelector::addFontFaceRule): Updated to use OwnPtr instead of raw
pointer for the entry in m_fontFaces and m_locallyInstalledFontFaces.
(WebCore::CSSFontSelector::getFontData): Updated to use OwnPtr instead of raw
pointer for the entry in m_fonts. Also removed an unneeded std:: prefix.

  • css/CSSFontSelector.h: Made m_fontFaces, m_locallyInstalledFontFaces, and m_fonts

be HashMap<OwnPtr>.

16:43 Changeset [102070] by lforschler@apple.com

Merged r95053.

16:40 Changeset [102069] by lforschler@apple.com

Merged r95051.

16:37 Changeset [102068] by lforschler@apple.com

Merged r95048.

16:33 Changeset [102067] by adamk@chromium.org

V8RecursionScope should call didLeaveScriptContext when recursionLevel reaches zero
https://bugs.webkit.org/show_bug.cgi?id=73867

Reviewed by Adam Barth.

Moved V8RecursionScope into its own file, and moved
V8Proxy::didLeaveScriptContext into that file, along with a static
recursionLevel accessor, hiding the V8BindingPerIsolateData methods
from V8Proxy.

This will make it easy and less error-prone to use V8RecursionScope
properly. I plan to make use of it in V8LazyEventListener to fix
https://bugs.webkit.org/show_bug.cgi?id=73492.

No new tests, refactoring only.

  • Target.pri:
  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/v8/V8Binding.h:

(WebCore::V8BindingPerIsolateData::incrementRecursionLevel): return the new recursion level.
(WebCore::V8BindingPerIsolateData::decrementRecursionLevel): return the new recursion level.

  • bindings/v8/V8Proxy.cpp: remove didLeaveScriptContext.

(WebCore::V8Proxy::runScript): remove explicit call to didLeaveScriptContext.
(WebCore::V8Proxy::instrumentedCallFunction): remove explicit call to didLeaveScriptContext.

  • bindings/v8/V8Proxy.h: remove didLeaveScriptContext.
  • bindings/v8/V8RecursionScope.cpp: Added.

(WebCore::V8RecursionScope::didLeaveScriptContext): copied from V8Proxy.cpp.

  • bindings/v8/V8RecursionScope.h: Added.

(WebCore::V8RecursionScope::V8RecursionScope):
(WebCore::V8RecursionScope::~V8RecursionScope):
(WebCore::V8RecursionScope::recursionLevel):

16:32 Changeset [102066] by lforschler@apple.com

Merged r94980.

16:17 Changeset [102065] by darin@apple.com

Convert JSClassRef to use HashMap<OwnPtr>
https://bugs.webkit.org/show_bug.cgi?id=73780

Reviewed by Andreas Kling.

  • API/JSCallbackObjectFunctions.h:

(JSC::JSCallbackObject::getOwnPropertyNames): Use get() on the hash map
entries because the hash map now has an OwnPtr instead of a raw pointer.

  • API/JSClassRef.cpp:

(OpaqueJSClass::OpaqueJSClass): No need to initialize m_staticValues and
m_staticFunctions since they are now OwnPtr. Use adoptPtr when allocating.
Removed the code that gets and deletes existing entries, and just use set,
which now handles deletion automatically due to it being OwnPtr.
(OpaqueJSClass::~OpaqueJSClass): Replaced code to do all the deletion
with assertion-only NDEBUG-only code.
(OpaqueJSClassContextData::OpaqueJSClassContextData): Use adoptPtr when
allocating. Use OwnPtr when adding. Removed unneeded code to set
staticValues and staticFunctions to 0. Removed unneeded destructor.
(OpaqueJSClass::staticValues): Added get call. Also removed unneeded local.
(OpaqueJSClass::staticFunctions): Ditto.
(OpaqueJSClass::prototype): Added use of adoptPtr.

  • API/JSClassRef.h: Made the static values and static functions tables

use OwnPtr for the entries. Also used OwnPtr for the pointers to the
tables themselves. Also removed ~OpaqueJSClassContextData(), letting
the compiler generate it.

16:17 Changeset [102064] by benjamin@webkit.org

Build fix for SecurityOrigin.cpp when neither BLOB nor FILE_SYSTEM are defined

Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-12-05
Reviewed by David Kilzer.

When neither BLOB nor FILE_SYSTEM are defined, the parameter is unused.

  • page/SecurityOrigin.cpp:

(WebCore::shouldUseInnerURL):

16:15 Changeset [102063] by darin@apple.com

Change RuleSet to use HashMap<OwnPtr>
https://bugs.webkit.org/show_bug.cgi?id=73783

Reviewed by Andreas Kling.

  • css/CSSStyleSelector.cpp: Make RuleSet::AtomRuleMap use OwnPtr for the mapped values.

(WebCore::RuleSet::addToRuleSet): Use add instead of get/set to set up a new entry in the
map or find the old entry in the map.

16:10 Changeset [102062] by mario@webkit.org

[GTK] Move emissions of AtkDocument signals down to WebCore
https://bugs.webkit.org/show_bug.cgi?id=73750

Reviewed by Chris Fleizach.

Source/WebCore:

Implement the needed infrastructure to allow notifying
accessibility, in a cross-platform way, when a event related to
the load of a document happens. Added a generic method, which will
be called from the FrameLoader, and platform specific versions of
it so every port has a chance to decide what to do with those
notifications.

This patch doesn't include a new test because the one testing this
functionality is the GTK-specific unit test added along with patch
for bug 73746: testWebkitAtkDocumentLoadingEvents.

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::frameLoadingEventNotification): New, called
from the FrameLoader to notify accessibility when an event happens.
(WebCore::AXObjectCache::frameLoadingEventPlatformNotification): New,
platform specific function to let ports decide what to do.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::frameLoadingEventNotification): New.

  • accessibility/chromium/AXObjectCacheChromium.cpp:

(WebCore::AXObjectCache::frameLoadingEventPlatformNotification): Dummy
implementation of the platform specific function for chromium.

  • accessibility/gtk/AXObjectCacheAtk.cpp:

(WebCore::AXObjectCache::frameLoadingEventPlatformNotification):

  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::frameLoadingEventPlatformNotification): Dummy
implementation of the platform specific function for the Mac.

  • accessibility/win/AXObjectCacheWin.cpp:

(WebCore::AXObjectCache::frameLoadingEventPlatformNotification): Dummy
implementation of the platform specific function for Windows.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::prepareForLoadStart): Notify accessibility
by calling the new frameLoadingEventNotification() function.
(WebCore::FrameLoader::checkLoadCompleteForThisFrame): Ditto.

Source/WebKit/gtk:

Removed code for emission of AtkDocument signals.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::notifyStatus): Removed no longer used code.

16:06 Changeset [102061] by oliver@apple.com

Land uncommitted bit of float array support
https://bugs.webkit.org/show_bug.cgi?id=73873

Reviewed by Filip Pizlo.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):

15:57 Changeset [102060] by rniwa@webkit.org

REGRESSION(r101949): css3/bdi-element.html fails on Lion
https://bugs.webkit.org/show_bug.cgi?id=73859

Reviewed by Dan Bernstein.

The failure was caused by span that contains the text inside bdi in the reference file
was using display: inline-block. Because the width of an inline-block is always rounded up
like any other inline element, it causes the text in the reference file to be one pixel
longer than the one in the test file in certain cases.

Fixed the bug by using unicode-bidi: override instead of display: inline-block in
the reference file.

  • css3/bdi-element-expected.html:
15:56 Changeset [102059] by benjamin@webkit.org

Update String::containsOnlyASCII() to handle 8 bits strings
https://bugs.webkit.org/show_bug.cgi?id=73799

Reviewed by Darin Adler.

Source/JavaScriptCore:

Implement String::containsOnlyASCII() so that it does not
call String::characters().

  • wtf/text/WTFString.h:

(WTF::String::containsOnlyASCII):

Source/WebCore:

When possible, change the call sites from charactersAreAllASCII()
to the optimized version String::containsOnlyASCII().

  • platform/KURL.cpp:

(WebCore::KURL::init):

  • platform/cf/BinaryPropertyList.cpp:

(WebCore::BinaryPropertyListPlan::writeStringObject):

  • platform/graphics/chromium/FontCacheChromiumWin.cpp:

(WebCore::FontCodepage::if):

15:54 Changeset [102058] by abarth@webkit.org

Mark this test as flaky.
See https://bugs.webkit.org/show_bug.cgi?id=73872

  • platform/chromium/test_expectations.txt:
15:50 Changeset [102057] by fpizlo@apple.com

Unreviewed build fix for non-DFG platforms.

  • dfg/DFGRepatch.h:
15:48 Changeset [102056] by eric@webkit.org

NRWT creates too many workers on RAM-limited machines
https://bugs.webkit.org/show_bug.cgi?id=73847

Reviewed by Dirk Pranke.

Make NRWT restrict its number of workers when there isn't enough
RAM to support them.
Also re-enable parallel testing on the Mac bots which were
failing due to not enough ram.

  • Scripts/run-webkit-tests:

(platformIsReadyForParallelTesting):

  • Scripts/webkitpy/common/host.py:

(Host.init):

  • Scripts/webkitpy/common/system/executive_mock.py:

(MockExecutive.cpu_count):

  • Scripts/webkitpy/common/system/platforminfo.py:

(PlatformInfo.init):
(PlatformInfo.display_name):

  • Scripts/webkitpy/common/system/platforminfo_mock.py:

(MockPlatformInfo.display_name):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.default_child_processes):

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_default_child_processes):
(PortTest.test_pretty_patch_os_error):

15:43 Changeset [102055] by vangelis@chromium.org

Source/WebCore: [chromium] Use ANGLE's texture_usage and texture_storage extensions when allocating compositor textures
https://bugs.webkit.org/show_bug.cgi?id=73621

When the extensions are available, compositor textures are allocated via
glTexStorage2DEXT instead of glTexImage2D to eliminate creation of unnecessary
mip levels on the service side. In addition, the GL_FRAMEBUFFER_ATTACHMENT_ANGLE
is specified for all textures used by RenderSurfaces to eliminate the need for
a system memory bitmap allocation.

Reviewed by Kenneth Russell.

  • platform/graphics/chromium/Extensions3DChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::initializeSharedObjects):

  • platform/graphics/chromium/TrackingTextureAllocator.cpp:

(WebCore::TrackingTextureAllocator::TrackingTextureAllocator):
(WebCore::textureToStorageFormat):
(WebCore::isTextureFormatSupportedForStorage):
(WebCore::TrackingTextureAllocator::createTexture):

  • platform/graphics/chromium/TrackingTextureAllocator.h:

(WebCore::TrackingTextureAllocator::setTextureUsageHint):
(WebCore::TrackingTextureAllocator::setUseTextureStorageExt):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::LayerRendererCapabilities::LayerRendererCapabilities):

Source/WebKit/chromium: Use ANGLE's texture_usage and texture_storage extensions when allocating compositor textures.
https://bugs.webkit.org/show_bug.cgi?id=73621

Add the necessary entry points and enums to GraphicsContext3D.

Reviewed by Kenneth Russell.

  • public/platform/WebGraphicsContext3D.h:
  • src/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::texStorage2DEXT):

  • src/GraphicsContext3DChromium.cpp:
  • src/GraphicsContext3DPrivate.h:
  • tests/MockWebGraphicsContext3D.h:

(WebKit::MockWebGraphicsContext3D::texStorage2DEXT):

15:39 Changeset [102054] by lforschler@apple.com

Merge 94912.

15:34 Changeset [102053] by cfleizach@apple.com

AX: WK2: AX hierarchy is not restored after web process crash
https://bugs.webkit.org/show_bug.cgi?id=73870

The accessibility tokens that need to be sent between UI and Web process
were not being sent by the UI process -> the web process when the web
process crashed.

Reviewed by Darin Adler.

  • UIProcess/API/mac/WKView.mm:

(-[WKView viewDidMoveToWindow]):
(-[WKView _accessibilityRegisterUIProcessTokens]):
(-[WKView _didRelaunchProcess]):

15:02 Changeset [102052] by jchaffraix@webkit.org

TD width in precentage doesn't work.
https://bugs.webkit.org/show_bug.cgi?id=34758

Unreviewed rebaselining on Chromium after r102040.

  • platform/chromium-cg-mac/tables/mozilla/bugs/bug14929-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/table/027-vertical-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2947-expected.png: Added.
  • platform/chromium-mac/fast/table/027-vertical-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug14929-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug2947-expected.png: Removed.
  • platform/chromium-win/fast/table/027-expected.png:
  • platform/chromium-win/fast/table/027-vertical-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug14929-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2947-expected.png:
  • platform/chromium/tables/mozilla/bugs/bug14929-expected.png: Added.
  • platform/chromium/test_expectations.txt:
14:58 TestExpectations edited by jchaffraix@webkit.org
rebaseline-chromium-webkit-tests is deprecated, replace it by webkit-patch … (diff)
14:44 Changeset [102051] by cfleizach@apple.com

AX: aria-hidden doesn't work on iframe elements
https://bugs.webkit.org/show_bug.cgi?id=73857

Reviewed by Darin Adler.

Source/WebCore:

Test: platform/mac/accessibility/iframe-aria-hidden.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::addAttachmentChildren):
(WebCore::AccessibilityRenderObject::addChildren):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::accessibilityIsIgnored):
(WebCore::AccessibilityScrollView::addChildren):

  • accessibility/AccessibilityScrollView.h:

LayoutTests:

  • platform/mac/accessibility/iframe-aria-hidden-expected.txt: Added.
  • platform/mac/accessibility/iframe-aria-hidden.html: Added.
14:43 Changeset [102050] by abarth@webkit.org

Another attempted build fix.

  • src/linux/WebFontInfo.cpp:
14:41 Changeset [102049] by cfleizach@apple.com

AX: web search mechanism does not work with frames
https://bugs.webkit.org/show_bug.cgi?id=73836

Reviewed by Beth Dakin.

Source/WebCore:

This allows searching for, and within, frames for elements using the accessibility
search mechanism.

Test: platform/mac/accessibility/search-with-frames.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::isAccessibilityObjectSearchMatch):
(WebCore::appendAccessibilityObject):
(WebCore::appendChildrenToArray):

LayoutTests:

  • platform/mac/accessibility/search-with-frames-expected.txt: Added.
  • platform/mac/accessibility/search-with-frames.html: Added.
14:33 Changeset [102048] by commit-queue@webkit.org

Last mouse event could be lost if a JS call to eventSender.leapForward is made
https://bugs.webkit.org/show_bug.cgi?id=73366

Patch by Hugo Parente Lima <hugo.lima@openbossa.org> on 2011-12-05
Reviewed by Kenneth Rohde Christiansen.

Tools:

Empty the entire event queue when requested besides using
sendEvent instead of postEvent to make sure all events were
delivered.

  • WebKitTestRunner/qt/EventSenderProxyQt.cpp:

(WTR::EventSenderProxy::EventSenderProxy):
(WTR::EventSenderProxy::sendOrQueueEvent):
(WTR::EventSenderProxy::replaySavedEvents):

LayoutTests:

Add test to check if the test driver doesn't eat mouse events when
a JS call to eventSender.leapForward was made. This bug happened at
least on Qt version of WebKitTestRunner.

  • fast/events/dont-loose-last-event-expected.txt: Added.
  • fast/events/dont-loose-last-event.html: Added.
14:27 Changeset [102047] by abarth@webkit.org

Fix Linux build.

  • public/linux/WebFontInfo.h:
14:16 Changeset [102046] by ap@apple.com

REGRESSION: Full keyboard access doesn't work if enabled before Safari started
https://bugs.webkit.org/show_bug.cgi?id=73864

Reviewed by Darin Adler.

  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeWebProcess): Actually use the parameter passed at process creation.
14:13 Changeset [102045] by andersca@apple.com

Make LayerFlushSchedulerClient::flushLayers indicate whether the flush was successful or not
https://bugs.webkit.org/show_bug.cgi?id=73862

Reviewed by Andy Estes.

Source/WebCore:

Change LayerFlushSchedulerClient::flushLayers to return a boolean. If it returns true, the flush was
successful and the run loop observer will be invalidated.

  • platform/graphics/ca/LayerFlushScheduler.h:
  • platform/graphics/ca/LayerFlushSchedulerClient.h:
  • platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp:

(WebCore::LayerFlushScheduler::runLoopObserverCallback):

Source/WebKit/mac:

Remove the call to LayerFlushScheduler::invalidate and return true instead. Return false for the cases
where we don't want the layer flush scheduler to be invalidated.

  • WebView/WebView.mm:

(LayerFlushController::flushLayers):

  • WebView/WebViewData.h:

Source/WebKit2:

Change LayerTreeHostCAMac::flushLayers to always return true and remove the call to LayerFlushScheduler::invalidate.

  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h:
  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:

(WebKit::LayerTreeHostCAMac::flushLayers):
(WebKit::LayerTreeHostCAMac::didPerformScheduledLayerFlush):

14:07 Changeset [102044] by abarth@webkit.org

[Chromium] Remove no-longer-used forwarding headers in the WebKit API
https://bugs.webkit.org/show_bug.cgi?id=73845

Reviewed by Darin Fisher.

Source/WebKit/chromium:

Delete unused forwarding headers and update includes to the new header
locations.

  • WebKit.gyp:
  • bridge/PeerConnectionHandlerInternal.cpp:
  • bridge/PeerConnectionHandlerInternal.h:
  • public/WebArrayBuffer.h:
  • public/WebArrayBufferView.h: Removed.
  • public/WebAudioBus.h: Removed.
  • public/WebAudioDevice.h: Removed.
  • public/WebBlobData.h: Removed.
  • public/WebBlobRegistry.h: Removed.
  • public/WebCString.h: Removed.
  • public/WebCanvas.h: Removed.
  • public/WebClipboard.h: Removed.
  • public/WebColor.h: Removed.
  • public/WebColorName.h: Removed.
  • public/WebCommon.h: Removed.
  • public/WebCompositorInputHandler.h:
  • public/WebCookie.h: Removed.
  • public/WebCookieJar.h: Removed.
  • public/WebData.h: Removed.
  • public/WebDragData.h: Removed.
  • public/WebFileSystem.h: Removed.
  • public/WebFloatPoint.h: Removed.
  • public/WebFloatQuad.h: Removed.
  • public/WebFloatRect.h: Removed.
  • public/WebGamepad.h: Removed.
  • public/WebGamepads.h: Removed.
  • public/WebGraphicsContext3D.h: Removed.
  • public/WebHTTPBody.h: Removed.
  • public/WebHTTPHeaderVisitor.h: Removed.
  • public/WebHTTPLoadInfo.h: Removed.
  • public/WebIDBCallbacks.h:
  • public/WebImage.h: Removed.
  • public/WebIntent.h:
  • public/WebIntentServiceInfo.h:
  • public/WebKitPlatformSupport.h: Removed.
  • public/WebLocalizedString.h: Removed.
  • public/WebMediaStreamDescriptor.h: Removed.
  • public/WebMimeRegistry.h: Removed.
  • public/WebNonCopyable.h: Removed.
  • public/WebPageOverlay.h:
  • public/WebPeerConnectionHandler.h: Removed.
  • public/WebPeerConnectionHandlerClient.h: Removed.
  • public/WebPoint.h: Removed.
  • public/WebPrivateOwnPtr.h: Removed.
  • public/WebPrivatePtr.h: Removed.
  • public/WebRect.h: Removed.
  • public/WebSerializedScriptValue.h: Removed.
  • public/WebSize.h: Removed.
  • public/WebSocketStreamError.h: Removed.
  • public/WebSocketStreamHandle.h: Removed.
  • public/WebSocketStreamHandleClient.h: Removed.
  • public/WebString.h: Removed.
  • public/WebThread.h: Removed.
  • public/WebThreadSafeData.h: Removed.
  • public/WebURL.h: Removed.
  • public/WebURLError.h: Removed.
  • public/WebURLLoadTiming.h: Removed.
  • public/WebURLLoader.h: Removed.
  • public/WebURLLoaderClient.h: Removed.
  • public/WebURLRequest.h: Removed.
  • public/WebURLResponse.h: Removed.
  • public/WebVector.h: Removed.
  • public/WebWorkerRunLoop.h:
  • public/android/WebThemeEngine.h: Removed.
  • public/linux/WebFontFamily.h: Removed.
  • public/linux/WebThemeEngine.h: Removed.
  • public/mac/WebThemeEngine.h: Removed.
  • public/win/WebThemeEngine.h: Removed.
  • src/ApplicationCacheHost.cpp:
  • src/ApplicationCacheHostInternal.h:
  • src/AssertMatchingEnums.cpp:
  • src/AssociatedURLLoader.cpp:
  • src/AssociatedURLLoader.h:
  • src/AsyncFileSystemChromium.cpp:
  • src/AsyncFileWriterChromium.cpp:
  • src/AudioDestinationChromium.cpp:
  • src/AudioDestinationChromium.h:
  • src/AutofillPopupMenuClient.cpp:
  • src/BlobRegistryProxy.cpp:
  • src/CCThreadImpl.cpp:
  • src/ChromeClientImpl.cpp:
  • src/ChromiumCurrentTime.cpp:
  • src/ChromiumOSRandomSource.cpp:
  • src/ChromiumThreading.cpp:
  • src/CompositionUnderlineBuilder.h:
  • src/CompositionUnderlineVectorBuilder.h:
  • src/ContextMenuClientImpl.cpp:
  • src/DragClientImpl.cpp:
  • src/DragScrollTimer.h:
  • src/ExternalPopupMenu.cpp:
  • src/FrameLoaderClientImpl.cpp:
  • src/GraphicsContext3DChromium.cpp:
  • src/IDBCallbacksProxy.cpp:
  • src/IDBCursorBackendProxy.cpp:
  • src/IDBFactoryBackendProxy.cpp:
  • src/IDBObjectStoreBackendProxy.cpp:
  • src/InspectorClientImpl.cpp:
  • src/InspectorFrontendClientImpl.cpp:
  • src/LocalFileSystemChromium.cpp:
  • src/LocalizedStrings.cpp:
  • src/NotificationPresenterImpl.cpp:
  • src/PlatformMessagePortChannel.cpp:
  • src/PlatformSupport.cpp:
  • src/ResourceHandle.cpp:
  • src/ResourceHandleInternal.h:
  • src/ScrollbarGroup.cpp:
  • src/SharedWorkerRepository.cpp:
  • src/SocketStreamHandle.cpp:
  • src/SpeechInputClientImpl.cpp:
  • src/StorageAreaProxy.cpp:
  • src/StorageEventDispatcherChromium.cpp:
  • src/StorageNamespaceProxy.cpp:
  • src/WebAccessibilityObject.cpp:
  • src/WebAnimationControllerImpl.cpp:
  • src/WebArrayBufferView.cpp:
  • src/WebAttribute.cpp:
  • src/WebAudioBus.cpp:
  • src/WebBindings.cpp:
  • src/WebBlobData.cpp:
  • src/WebCString.cpp:
  • src/WebColor.cpp:
  • src/WebCommon.cpp:
  • src/WebCompositorImpl.cpp:
  • src/WebCompositorInputHandlerImpl.cpp:
  • src/WebContentLayerImpl.cpp:
  • src/WebDOMEventListenerPrivate.h:
  • src/WebDOMMessageEvent.cpp:
  • src/WebDOMStringList.cpp:
  • src/WebData.cpp:
  • src/WebDataSourceImpl.cpp:
  • src/WebDatabase.cpp:
  • src/WebDevToolsAgentImpl.cpp:
  • src/WebDocument.cpp:
  • src/WebDocumentType.cpp:
  • src/WebDragData.cpp:
  • src/WebEntities.cpp:
  • src/WebExternalTextureLayerImpl.cpp:
  • src/WebFileChooserCompletionImpl.h:
  • src/WebFileSystemCallbacksImpl.cpp:
  • src/WebFileSystemCallbacksImpl.h:
  • src/WebFloatQuad.cpp:
  • src/WebFontImpl.cpp:
  • src/WebFormElement.cpp:
  • src/WebFrameImpl.cpp:
  • src/WebGeolocationError.cpp:
  • src/WebGeolocationPermissionRequest.cpp:
  • src/WebGraphicsContext3D.cpp:
  • src/WebHTTPBody.cpp:
  • src/WebHTTPLoadInfo.cpp:
  • src/WebHistoryItem.cpp:
  • src/WebIDBCallbacksImpl.cpp:
  • src/WebIDBCursorImpl.h:
  • src/WebIDBDatabaseCallbacksImpl.cpp:
  • src/WebIDBDatabaseCallbacksImpl.h:
  • src/WebIDBDatabaseError.cpp:
  • src/WebIDBDatabaseImpl.h:
  • src/WebIDBIndexImpl.h:
  • src/WebIDBKey.cpp:
  • src/WebIDBKeyPath.cpp:
  • src/WebIDBObjectStoreImpl.cpp:
  • src/WebIDBObjectStoreImpl.h:
  • src/WebIDBTransactionImpl.h:
  • src/WebIconLoadingCompletionImpl.h:
  • src/WebImageCG.cpp:
  • src/WebImageDecoder.cpp:
  • src/WebImageSkia.cpp:
  • src/WebInputElement.cpp:
  • src/WebKit.cpp:
  • src/WebLabelElement.cpp:
  • src/WebLayer.cpp:
  • src/WebLayerTreeView.cpp:
  • src/WebLayerTreeViewImpl.cpp:
  • src/WebMediaPlayerClientImpl.cpp:
  • src/WebMediaStreamDescriptor.cpp:
  • src/WebMediaStreamRegistry.cpp:
  • src/WebMediaStreamSource.cpp:
  • src/WebNode.cpp:
  • src/WebNotification.cpp:
  • src/WebOptionElement.cpp:
  • src/WebPageSerializer.cpp:
  • src/WebPageSerializerImpl.cpp:
  • src/WebPageSerializerImpl.h:
  • src/WebPluginContainerImpl.cpp:
  • src/WebPluginListBuilderImpl.cpp:
  • src/WebPluginLoadObserver.h:
  • src/WebPopupMenuImpl.cpp:
  • src/WebPopupMenuImpl.h:
  • src/WebRange.cpp:
  • src/WebRegularExpression.cpp:
  • src/WebScriptController.cpp:
  • src/WebScrollbarImpl.cpp:
  • src/WebSecurityOrigin.cpp:
  • src/WebSecurityPolicy.cpp:
  • src/WebSelectElement.cpp:
  • src/WebSerializedScriptValue.cpp:
  • src/WebSettingsImpl.cpp:
  • src/WebSharedWorkerImpl.cpp:
  • src/WebSocketImpl.cpp:
  • src/WebSocketImpl.h:
  • src/WebSpeechInputControllerMockImpl.cpp:
  • src/WebSpeechInputControllerMockImpl.h:
  • src/WebStorageAreaImpl.cpp:
  • src/WebStorageEventDispatcherImpl.cpp:
  • src/WebStorageNamespaceImpl.cpp:
  • src/WebString.cpp:
  • src/WebTextCheckingCompletionImpl.cpp:
  • src/WebThreadSafeData.cpp:
  • src/WebURL.cpp:
  • src/WebURLError.cpp:
  • src/WebURLLoadTiming.cpp:
  • src/WebURLRequest.cpp:
  • src/WebURLResponse.cpp:
  • src/WebURLResponsePrivate.h:
  • src/WebUserMediaRequest.cpp:
  • src/WebViewImpl.cpp:
  • src/WebViewImpl.h:
  • src/WebWorkerClientImpl.cpp:
  • src/WebWorkerClientImpl.h:
  • src/WebWorkerImpl.cpp:
  • src/WorkerAsyncFileSystemChromium.cpp:
  • src/WorkerAsyncFileWriterChromium.cpp:
  • src/WorkerFileSystemCallbacksBridge.cpp:
  • src/WorkerFileSystemCallbacksBridge.h:
  • src/WorkerFileWriterCallbacksBridge.cpp:
  • src/WrappedResourceRequest.h:
  • src/WrappedResourceResponse.h:
  • src/mac/WebSubstringUtil.mm:
  • tests/AssociatedURLLoaderTest.cpp:
  • tests/CCLayerTreeHostTest.cpp:
  • tests/FrameTestHelpers.cpp:
  • tests/MockWebGraphicsContext3D.h:
  • tests/PopupMenuTest.cpp:
  • tests/RunAllTests.cpp:
  • tests/WebLayerTest.cpp:
  • tests/WebPageNewSerializerTest.cpp:
  • tests/WebPageSerializerTest.cpp:
  • tests/WebURLRequestTest.cpp:
  • tests/WebUnitTests.h:
  • tests/WebViewTest.cpp:

Tools:

Update includes to point to the new header locations.

  • DumpRenderTree/chromium/AccessibilityController.cpp:
  • DumpRenderTree/chromium/AccessibilityUIElement.cpp:
  • DumpRenderTree/chromium/CppBoundClass.cpp:
  • DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
  • DumpRenderTree/chromium/DRTDevToolsAgent.h:
  • DumpRenderTree/chromium/DRTDevToolsClient.h:
  • DumpRenderTree/chromium/EventSender.cpp:
  • DumpRenderTree/chromium/EventSender.h:
  • DumpRenderTree/chromium/GamepadController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp:
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/MockSpellCheck.cpp:
  • DumpRenderTree/chromium/NotificationPresenter.cpp:
  • DumpRenderTree/chromium/PlainTextController.cpp:
  • DumpRenderTree/chromium/Task.cpp:
  • DumpRenderTree/chromium/TestNavigationController.h:
  • DumpRenderTree/chromium/TestShell.cpp:
  • DumpRenderTree/chromium/TestWebPlugin.cpp:
  • DumpRenderTree/chromium/TestWebPlugin.h:
  • DumpRenderTree/chromium/TextInputController.cpp:
  • DumpRenderTree/chromium/WebPermissions.cpp:
  • DumpRenderTree/chromium/WebPreferences.h:
  • DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
  • DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
  • DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
  • DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
  • DumpRenderTree/chromium/WebViewHost.cpp:
13:55 Changeset [102043] by commit-queue@webkit.org

[chromium] Set opaque flag for ImageLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=72964

Patch by Dana Jansens <danakj@chromium.org> on 2011-12-05
Reviewed by James Robinson.

Source/WebCore:

New unit test in tests/ImageLayerChromiumTest.cpp.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setContentsToImage):

  • platform/graphics/chromium/GraphicsLayerChromium.h:

(WebCore::GraphicsLayerChromium::contentsLayer):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::setContents):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/ImageLayerChromiumTest.cpp: Added.

(WebCore::MockGraphicsLayerClient::notifyAnimationStarted):
(WebCore::MockGraphicsLayerClient::notifySyncRequired):
(WebCore::MockGraphicsLayerClient::paintContents):
(WebCore::MockGraphicsLayerClient::showDebugBorders):
(WebCore::MockGraphicsLayerClient::showRepaintCounter):
(WebCore::TestImage::create):
(WebCore::TestImage::TestImage):
(WebCore::TestImage::~TestImage):
(WebCore::TestImage::isBitmapImage):
(WebCore::TestImage::currentFrameHasAlpha):
(WebCore::TestImage::size):
(WebCore::TestImage::nativeImageForCurrentFrame):
(WebCore::TestImage::destroyDecodedData):
(WebCore::TestImage::decodedSize):
(WebCore::TestImage::draw):
(WebCore::TEST):

13:45 Changeset [102042] by fpizlo@apple.com

Old JIT emits 32-bit offsets for put_by_id but sometimes patches them as if they
were compact offsets
https://bugs.webkit.org/show_bug.cgi?id=73861

Reviewed by Gavin Barraclough.

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::resetPatchPutById):

13:44 Changeset [102041] by rniwa@webkit.org

Add Aharon Lanin to the contributors list.

  • Scripts/webkitpy/common/config/committers.py:
13:38 Changeset [102040] by jchaffraix@webkit.org

TD width in precentage doesn't work.
https://bugs.webkit.org/show_bug.cgi?id=34758

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/table/colspan-with-all-percent-cells.html

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
In the case where all our columns have percent lengths, split the colspan
logical width using the percentages from the lengths. This should be properly
handled by the massive 'else' case but it is not and I did not feel like refactor
that due to massive compatibility issues that would arise.

LayoutTests:

  • fast/table/colspan-with-all-percent-cells-expected.png: Added.
  • fast/table/colspan-with-all-percent-cells-expected.txt: Added.
  • fast/table/colspan-with-all-percent-cells.html: Added.
  • platform/chromium-cg-mac/tables/mozilla/bugs/bug14929-expected.png:
  • platform/chromium-linux/fast/table/027-expected.png:
  • platform/chromium-linux/fast/table/027-vertical-expected.png:
  • platform/chromium-mac/fast/table/027-vertical-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug14929-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2947-expected.png:
  • platform/chromium-win/fast/table/027-expected.txt:
  • platform/chromium-win/fast/table/027-vertical-expected.txt:
  • platform/mac/fast/table/027-expected.png:
  • platform/mac/fast/table/027-expected.txt:
  • platform/mac/fast/table/027-vertical-expected.png:
  • platform/mac/fast/table/027-vertical-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug14929-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2947-expected.png:
  • platform/mac/tables/mozilla/bugs/bug2947-expected.txt:

Those changes are just rebaselines which now matches Firefox Nighly
more closely (thus progressions).

  • platform/chromium/test_expectations.txt: Skipped Windows that needs a new baseline.
  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:

Skipped the previous tests as they need a rebaseline on those platforms.

13:27 Changeset [102039] by alokp@chromium.org

Unreviewed chromium tests rebaseline.

  • platform/chromium/compositing/scaling: Added.
  • platform/chromium/compositing/scaling/tiled-layer-recursion-expected.png: Added.
13:25 Changeset [102038] by fpizlo@apple.com

Unreviewed, build fixes for ARM.

  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::unreachableForPlatform):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::loadDouble):
(JSC::MacroAssemblerARMv7::loadFloat):
(JSC::MacroAssemblerARMv7::storeFloat):
(JSC::MacroAssemblerARMv7::convertFloatToDouble):
(JSC::MacroAssemblerARMv7::convertDoubleToFloat):

13:23 Changeset [102037] by jarred@sencha.com

Moving myself from contributors to committers.

  • Scripts/webkitpy/common/config/committers.py:
13:22 Changeset [102036] by kubo@profusion.mobi

Add myself as a committer.

13:16 Changeset [102035] by commit-queue@webkit.org

[Qt] Rename QQuickWebView::canStop property to just loading
https://bugs.webkit.org/show_bug.cgi?id=73813

Patch by Michael Brüning <michael.bruning@nokia.com> on 2011-12-05
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Renamed canStop property of QQuickWebView and QtWebPageProxy
to loading and updated tests.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebView::loading):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::navigationStatusAtStartup):
(LoadStartedCatcher::onLoadStarted):
(tst_QQuickWebView::stopEnabledAfterLoadStarted):

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::loading):

  • UIProcess/qt/QtWebPageProxy.h:

Tools:

Replaced references to WebView.canStop with WebView.loading.

  • MiniBrowser/qt/qml/BrowserWindow.qml:
13:13 Changeset [102034] by alokp@chromium.org

[Chromium] Layout Test compositing/shadows/shadow-drawing.html is failing
https://bugs.webkit.org/show_bug.cgi?id=69062

Unreviewed chromium rebaseline.

  • platform/chromium-win/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium/test_expectations.txt:
13:07 Changeset [102033] by lforschler@apple.com

Merged r94901.

13:03 Changeset [102032] by lforschler@apple.com

Merged r94900.

12:59 Changeset [102031] by cfleizach@apple.com

platform/mac/accessibility/search-when-element-starts-in-table.html is failing
https://bugs.webkit.org/show_bug.cgi?id=73751

Source/WebCore:

When encountering a table, the rows() and not the cells() should be queried (otherwise
we can end up finding the element we started with).

When searching in reverse, we also need to account for searching elements within the
parent hierarchy. because technically it is "behind" the start element.

Reviewed by Darin Adler.

  • accessibility/AccessibilityObject.cpp:

(WebCore::appendChildrenToArray):
(WebCore::AccessibilityObject::objectMatchesSearchCriteriaWithResultLimit):
(WebCore::AccessibilityObject::findMatchingObjects):

  • accessibility/AccessibilityObject.h:

LayoutTests:

Updated tests to be more comprehensive.

Reviewed by Darin Adler.

  • platform/mac/accessibility/search-when-element-starts-in-table-expected.txt:
  • platform/mac/accessibility/search-when-element-starts-in-table.html:
12:47 Changeset [102030] by dpranke@chromium.org

run-webkit-tests: limit --child-processes properly on apple mac
https://bugs.webkit.org/show_bug.cgi?id=73856

Reviewed by Adam Roben.

Fix typos in r102013 so that we correctly pass --child-processes=1 on
the apple mac bots temporarily.

  • Scripts/run-webkit-tests:

(platformIsReadyForParallelTesting):

12:37 Changeset [102029] by lforschler@apple.com

Merge 94597.

12:27 Changeset [102028] by benjamin@webkit.org

Update String::containsOnlyLatin1() to avoid converting to 16 bits
https://bugs.webkit.org/show_bug.cgi?id=73797

Reviewed by Andreas Kling.

When the String use 8bits StringImpl, there is no need to iterate
over the string.

The function charactersAreAllLatin1() is removed because it is not
used anywhere.

  • wtf/text/WTFString.h:

(WTF::String::containsOnlyLatin1):

12:18 WebKit Team edited by tomz@codeaurora.org
(diff)
12:08 Changeset [102027] by lforschler@apple.com

Versioning.

12:07 Changeset [102026] by lforschler@apple.com

Fixes to the branch made by Simon to get us building again.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::mapNinePieceImageWidth):
(WebCore::CSSStyleSelector::loadPendingImages):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::computeBorderImageSide):
(WebCore::RenderBoxModelObject::paintNinePieceImage):

12:03 Changeset [102025] by alokp@chromium.org

Rebaseline tests after the patch for BUGWK73247
https://bugs.webkit.org/show_bug.cgi?id=73848

Unreviewed chromium rebaseline.

  • platform/chromium-cg-mac-leopard/compositing/color-matching: Added.
  • platform/chromium-cg-mac-leopard/compositing/color-matching/image-color-matching-expected.png: Added.
  • platform/chromium-cg-mac-leopard/compositing/direct-image-compositing-expected.png: Added.
  • platform/chromium-cg-mac-leopard/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
  • platform/chromium-cg-mac-leopard/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
  • platform/chromium-cg-mac-leopard/compositing/iframes: Added.
  • platform/chromium-cg-mac-leopard/compositing/iframes/composited-iframe-alignment-expected.png: Added.
  • platform/chromium-cg-mac-leopard/compositing/reflections: Added.
  • platform/chromium-cg-mac-leopard/compositing/reflections/nested-reflection-transformed-expected.png: Added.
  • platform/chromium-cg-mac-leopard/compositing/reflections/nested-reflection-transformed2-expected.png: Added.
  • platform/chromium-cg-mac-leopard/compositing/reflections/nested-reflection-transition-expected.png: Added.
  • platform/chromium-cg-mac-leopard/compositing/reflections/reflection-in-composited-expected.png: Added.
  • platform/chromium-cg-mac-leopard/compositing/scaling: Removed.
  • platform/chromium-cg-mac-leopard/compositing/scaling/tiled-layer-recursion-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/compositing/shadows: Added.
  • platform/chromium-cg-mac-leopard/compositing/shadows/shadow-drawing-expected.png: Added.
  • platform/chromium-cg-mac-leopard/platform/chromium/compositing: Added.
  • platform/chromium-cg-mac-leopard/platform/chromium/compositing/huge-layer-rotated-expected.png: Added.
  • platform/chromium-cg-mac-leopard/platform/chromium/compositing/layout-width-change-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/color-matching: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/color-matching/image-color-matching-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/direct-image-compositing-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
  • platform/chromium-cg-mac-snowleopard/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/iframes: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/iframes/composited-iframe-alignment-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/reflections: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/reflections/nested-reflection-transformed-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/reflections/nested-reflection-transformed2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/reflections/nested-reflection-transition-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/reflections/reflection-in-composited-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/scaling: Removed.
  • platform/chromium-cg-mac-snowleopard/compositing/shadows: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/shadows/shadow-drawing-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/media/video-layer-crash-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/media/video-transformed-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/platform/chromium/compositing/huge-layer-rotated-expected.png:
  • platform/chromium-cg-mac-snowleopard/platform/chromium/compositing/tiny-layer-rotated-expected.png:
  • platform/chromium-cg-mac/compositing/color-matching: Removed.
  • platform/chromium-cg-mac/compositing/color-matching/image-color-matching-expected.png: Removed.
  • platform/chromium-cg-mac/compositing/direct-image-compositing-expected.png: Removed.
  • platform/chromium-cg-mac/compositing/geometry/ancestor-overflow-change-expected.png: Removed.
  • platform/chromium-cg-mac/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Removed.
  • platform/chromium-cg-mac/compositing/geometry/layer-due-to-layer-children-expected.png: Removed.
  • platform/chromium-cg-mac/compositing/iframes/composited-iframe-alignment-expected.png: Removed.
  • platform/chromium-cg-mac/compositing/reflections/nested-reflection-transformed-expected.png: Removed.
  • platform/chromium-cg-mac/compositing/reflections/nested-reflection-transformed2-expected.png: Removed.
  • platform/chromium-cg-mac/compositing/reflections/nested-reflection-transition-expected.png: Removed.
  • platform/chromium-cg-mac/compositing/reflections/reflection-in-composited-expected.png: Removed.
  • platform/chromium-cg-mac/compositing/shadows: Removed.
  • platform/chromium-cg-mac/compositing/shadows/shadow-drawing-expected.png: Removed.
  • platform/chromium-cg-mac/media/video-layer-crash-expected.png: Removed.
  • platform/chromium-cg-mac/media/video-transformed-expected.png: Removed.
  • platform/chromium-gpu-cg-mac/media/video-layer-crash-expected.png:
  • platform/chromium-gpu-cg-mac/media/video-transformed-expected.png:
  • platform/chromium-gpu-cg-mac/media/video-zoom-controls-expected.png:
  • platform/chromium-gpu-mac/media/video-layer-crash-expected.png:
  • platform/chromium-gpu-mac/media/video-transformed-expected.png:
  • platform/chromium-gpu-mac/media/video-zoom-controls-expected.png:
  • platform/chromium-gpu-win/media/video-layer-crash-expected.png:
  • platform/chromium-gpu-win/media/video-layer-crash-expected.txt: Added.
  • platform/chromium-gpu-win/media/video-transformed-expected.png:
  • platform/chromium-gpu-win/media/video-zoom-controls-expected.png:
  • platform/chromium-linux/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-linux/compositing/direct-image-compositing-expected.png:
  • platform/chromium-linux/compositing/geometry/ancestor-overflow-change-expected.png:
  • platform/chromium-linux/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
  • platform/chromium-linux/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
  • platform/chromium-linux/compositing/geometry/layer-due-to-layer-children-expected.png:
  • platform/chromium-linux/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-linux/compositing/reflections/nested-reflection-transformed-expected.png:
  • platform/chromium-linux/compositing/reflections/nested-reflection-transformed2-expected.png:
  • platform/chromium-linux/compositing/reflections/nested-reflection-transition-expected.png:
  • platform/chromium-linux/compositing/reflections/reflection-in-composited-expected.png:
  • platform/chromium-linux/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-linux/platform/chromium/compositing/huge-layer-rotated-expected.png:
  • platform/chromium-linux/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-linux/platform/chromium/compositing/tiny-layer-rotated-expected.png:
  • platform/chromium-mac-leopard/compositing/color-matching: Added.
  • platform/chromium-mac-leopard/compositing/color-matching/image-color-matching-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/direct-image-compositing-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/iframes: Added.
  • platform/chromium-mac-leopard/compositing/iframes/composited-iframe-alignment-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/reflections: Added.
  • platform/chromium-mac-leopard/compositing/reflections/nested-reflection-transformed-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/reflections/nested-reflection-transformed2-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/reflections/nested-reflection-transition-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/reflections/reflection-in-composited-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/shadows: Added.
  • platform/chromium-mac-leopard/compositing/shadows/shadow-drawing-expected.png: Added.
  • platform/chromium-mac-leopard/platform/chromium/compositing: Added.
  • platform/chromium-mac-leopard/platform/chromium/compositing/layout-width-change-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/color-matching: Added.
  • platform/chromium-mac-snowleopard/compositing/color-matching/image-color-matching-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/direct-image-compositing-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
  • platform/chromium-mac-snowleopard/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/iframes: Added.
  • platform/chromium-mac-snowleopard/compositing/iframes/composited-iframe-alignment-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/reflections: Added.
  • platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-transformed-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-transformed2-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-transition-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/reflections/reflection-in-composited-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/shadows: Added.
  • platform/chromium-mac-snowleopard/compositing/shadows/shadow-drawing-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/visibility: Added.
  • platform/chromium-mac-snowleopard/compositing/visibility/visibility-image-layers-expected.png: Added.
  • platform/chromium-mac-snowleopard/media/video-layer-crash-expected.png: Added.
  • platform/chromium-mac-snowleopard/media/video-transformed-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/huge-layer-rotated-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/tiny-layer-rotated-expected.png:
  • platform/chromium-mac/compositing/color-matching/image-color-matching-expected.png: Removed.
  • platform/chromium-mac/compositing/direct-image-compositing-expected.png: Removed.
  • platform/chromium-mac/compositing/geometry/ancestor-overflow-change-expected.png: Removed.
  • platform/chromium-mac/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Removed.
  • platform/chromium-mac/compositing/geometry/layer-due-to-layer-children-expected.png: Removed.
  • platform/chromium-mac/compositing/iframes/composited-iframe-alignment-expected.png: Removed.
  • platform/chromium-mac/compositing/reflections/nested-reflection-transformed-expected.png: Removed.
  • platform/chromium-mac/compositing/reflections/nested-reflection-transformed2-expected.png: Removed.
  • platform/chromium-mac/compositing/reflections/nested-reflection-transition-expected.png: Removed.
  • platform/chromium-mac/compositing/reflections/reflection-in-composited-expected.png: Removed.
  • platform/chromium-mac/compositing/shadows: Removed.
  • platform/chromium-mac/compositing/shadows/shadow-drawing-expected.png: Removed.
  • platform/chromium-mac/compositing/visibility: Removed.
  • platform/chromium-mac/compositing/visibility/visibility-image-layers-expected.png: Removed.
  • platform/chromium-mac/media/video-layer-crash-expected.png: Removed.
  • platform/chromium-mac/media/video-transformed-expected.png: Removed.
  • platform/chromium-win/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-win/compositing/direct-image-compositing-expected.png:
  • platform/chromium-win/compositing/geometry/ancestor-overflow-change-expected.png:
  • platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
  • platform/chromium-win/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
  • platform/chromium-win/compositing/geometry/layer-due-to-layer-children-expected.png:
  • platform/chromium-win/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-win/compositing/iframes/composited-iframe-alignment-expected.png:
  • platform/chromium-win/compositing/reflections/nested-reflection-transformed-expected.png:
  • platform/chromium-win/compositing/reflections/nested-reflection-transformed2-expected.png:
  • platform/chromium-win/compositing/reflections/nested-reflection-transition-expected.png:
  • platform/chromium-win/compositing/reflections/reflection-in-composited-expected.png:
  • platform/chromium-win/compositing/scaling/tiled-layer-recursion-expected.png:
  • platform/chromium-win/compositing/visibility/visibility-image-layers-expected.png:
  • platform/chromium-win/platform/chromium/compositing/huge-layer-rotated-expected.png:
  • platform/chromium-win/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-win/platform/chromium/compositing/tiny-layer-rotated-expected.png:
  • platform/chromium/compositing/geometry/ancestor-overflow-change-expected.png: Added.
  • platform/chromium/compositing/geometry/vertical-scroll-composited-expected.png: Replaced.
  • platform/chromium/compositing/scaling: Removed.
  • platform/chromium/compositing/scaling/tiled-layer-recursion-expected.png: Removed.
  • platform/chromium/platform/chromium/compositing/layout-width-change-expected.png: Replaced.
  • platform/chromium/test_expectations.txt:
11:47 Changeset [102024] by jer.noble@apple.com

<video> elements should disable the system and display sleep when playing on OS X.
https://bugs.webkit.org/show_bug.cgi?id=73730
<rdar://problem/9502155>

Reviewed by Alexey Proskuryakov.

Source/WebCore:

No new tests; platform specific system behavior only.

Create a new DisplaySleepDisabler object when the playback rate becomes non-zero, and destroy
that object when the playback rate drops back to zero.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerRateChanged):

  • html/HTMLMediaElement.h:

Source/WebKit2:

Allow the WebProcess to make connections to the PowerManagement control mach server.

  • WebProcess/com.apple.WebProcess.sb:
11:33 Changeset [102023] by timothy_horton@apple.com

Unreviewed rebaseline of test added in r101537 for Lion.

  • platform/mac/svg/text/non-bmp-positioning-lists-expected.png:
  • platform/mac/svg/text/non-bmp-positioning-lists-expected.txt:
11:22 Changeset [102022] by lforschler@apple.com

New Tag.

11:22 Changeset [102021] by lforschler@apple.com

Remove incorrect tag.

11:17 Changeset [102020] by lforschler@apple.com

New Tag.

11:12 Changeset [102019] by jamesr@google.com

[chromium] Remove forwarding headers for WebLayer APIs
https://bugs.webkit.org/show_bug.cgi?id=73729

Reviewed by Adam Barth.

These are no longer necessary.

  • WebKit.gyp:
  • public/WebContentLayer.h: Removed.
  • public/WebContentLayerClient.h: Removed.
  • public/WebExternalTextureLayer.h: Removed.
  • public/WebLayer.h: Removed.
  • public/WebLayerClient.h: Removed.
  • public/WebLayerTreeView.h: Removed.
  • public/WebLayerTreeViewClient.h: Removed.
  • src/WebLayerTreeView.cpp:
  • src/WebLayerTreeViewImpl.cpp:
  • tests/WebLayerTest.cpp:
11:10 Changeset [102018] by peter@chromium.org

[Chromium] Add Android keycodes and build Linux clipboard/filesystem files.
https://bugs.webkit.org/show_bug.cgi?id=73672

Add the KeyCodeConversionAndroid.cpp file, which is a partial re-land
of an older file from the Android port:
http://trac.webkit.org/browser/trunk/WebCore/platform/android/KeyEventAndroid.cpp?rev=56704

Add IconChromiumAndroid.cpp which nullifies the rendering of icons in
file upload boxes, which is not something we want to support now. Also
include ClipboardChromiumLinux.cpp and FileSystemChromiumLinux.cpp
as their functionality can be re-used for Android.

Reviewed by Adam Barth.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/chromium/KeyCodeConversionAndroid.cpp: Added.

(WebCore::windowsKeyCodeForKeyEvent):

  • platform/graphics/chromium/IconChromiumAndroid.cpp: Added.

(WebCore::Icon::Icon):
(WebCore::Icon::~Icon):
(WebCore::Icon::paint):

11:08 Changeset [102017] by msaboff@apple.com

8 bit string work slows down Kraken json-stringify-tinderbox
https://bugs.webkit.org/show_bug.cgi?id=73457

Added 8 bit path to StringBuilder. StringBuilder starts
assuming 8 bit contents and gets converted to 16 bit upon
seeing the first 16 bit character or string. Split
appendUninitialiezed into an inlined fast and function call
slow case.

Factored out the processing of the UString argument from
Stringifier::appendQuotedString() to a static templated function
based on character size.

This change eliminates 5% of the 7% slowdown to json-stringify-tinderbox.
This change introduces a 4.8% slowdown to json-parse-financial.
This slowdown will be addressed in a subsequent patch to StringImpl::equal.

Reviewed by Oliver Hunt.

  • runtime/JSONObject.cpp:

(JSC::appendStringToUStringBuilder):
(JSC::Stringifier::appendQuotedString):

  • wtf/text/StringBuilder.cpp:

(WTF::StringBuilder::resize):
(WTF::StringBuilder::allocateBuffer):
(WTF::StringBuilder::allocateBufferUpConvert):
(WTF::LChar):
(WTF::UChar):
(WTF::StringBuilder::reserveCapacity):
(WTF::StringBuilder::appendUninitialized):
(WTF::StringBuilder::appendUninitializedSlow):
(WTF::StringBuilder::append):
(WTF::StringBuilder::shrinkToFit):

  • wtf/text/StringBuilder.h:

(WTF::StringBuilder::StringBuilder):
(WTF::StringBuilder::append):
(WTF::StringBuilder::operator[]):
(WTF::StringBuilder::characters8):
(WTF::StringBuilder::characters16):
(WTF::StringBuilder::charactersBlah):
(WTF::LChar):
(WTF::UChar):

10:46 Changeset [102016] by sfalken@apple.com

2011-12-05 Steve Falkenburg <sfalken@apple.com>

Reviewed by Sam Weinig.

On Windows, filenames not properly preserved when copied into a file list exposed by Event.dataTransfer
https://bugs.webkit.org/show_bug.cgi?id=73841
<rdar://problem/10521879>

No test since repro case involves dropping a file onto the WebView.


Calling characters() explicitly causes a non-terminated string buffer to get passed back
to the String() constructor that expects a terminated buffer. The characters() call isn't
necessary at all, since we have a String and the method we're calling expects a String.

  • platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::files): Remove characters() since it doesn't null terminate.
10:45 Changeset [102015] by mihnea@adobe.com

[regions] Need to verify the correctness of Win/Linux on overflow break tests
https://bugs.webkit.org/show_bug.cgi?id=73332

Reviewed by Tony Chang.

Using a monospace font (instead of Times) provides closer rendering results on several platforms
when used with text-align:justify.

  • fast/regions/region-overflow-auto-overflow-hidden.html:
  • fast/regions/region-overflow-auto-overflow-visible.html:
  • fast/regions/region-overflow-break.html:
  • platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Added.
  • platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Added.
  • platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.png: Added.
  • platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Added.
  • platform/mac-snowleopard/fast/regions/region-overflow-break-expected.png: Added.
  • platform/mac-snowleopard/fast/regions/region-overflow-break-expected.txt: Added.
  • platform/mac/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
  • platform/mac/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
  • platform/mac/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
  • platform/mac/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
  • platform/mac/fast/regions/region-overflow-break-expected.png: Removed.
  • platform/mac/fast/regions/region-overflow-break-expected.txt: Removed.
10:41 Changeset [102014] by weinig@apple.com

Move code for connections to/from the UIProcess/WebProcess into WebConnection subclasses
https://bugs.webkit.org/show_bug.cgi?id=73779

Reviewed by Anders Carlsson.

To allow for API objects representing the connection going to/from the UIProcess/WebProcess,
this patch separates out the connections into WebConnection subclasses. It does not yet
expose a way to access these connections, and is therefore not yet testable.

  • GNUmakefile.am:
  • Target.pri:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Add new files.

  • Platform/CoreIPC/MessageID.h:
  • Shared/CoreIPCSupport/WebConnectionMessageKinds.h: Added.

Add a new message type for communicating between WebConnections.

  • Shared/ChildProcess.h:

Make helper public so that WebConnectionToWebProcess can use it.

  • UIProcess/WebConnectionToWebProcess.cpp: Added.

(WebKit::WebConnectionToWebProcess::create):
(WebKit::WebConnectionToWebProcess::WebConnectionToWebProcess):
(WebKit::WebConnectionToWebProcess::invalidate):
(WebKit::WebConnectionToWebProcess::postMessage):
(WebKit::WebConnectionToWebProcess::didReceiveMessage):
(WebKit::WebConnectionToWebProcess::didReceiveSyncMessage):
(WebKit::WebConnectionToWebProcess::didClose):
(WebKit::WebConnectionToWebProcess::didReceiveInvalidMessage):
(WebKit::WebConnectionToWebProcess::syncMessageSendTimedOut):
(WebKit::WebConnectionToWebProcess::windowsToReceiveSentMessagesWhileWaitingForSyncReply):

  • UIProcess/WebConnectionToWebProcess.h: Added.

(WebKit::WebConnectionToWebProcess::connection):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::sendMessage):
(WebKit::WebProcessProxy::didReceiveInvalidMessage):
(WebKit::WebProcessProxy::didFinishLaunching):

  • UIProcess/WebProcessProxy.h:

(WebKit::WebProcessProxy::connection):
(WebKit::WebProcessProxy::webConnection):
(WebKit::WebProcessProxy::sendSync):
Thread connection code through WebConnectionToWebProcess.

  • WebProcess/WebConnectionToUIProcess.cpp: Added.

(WebKit::WebConnectionToUIProcess::create):
(WebKit::WebConnectionToUIProcess::WebConnectionToUIProcess):
(WebKit::WebConnectionToUIProcess::invalidate):
(WebKit::WebConnectionToUIProcess::postMessage):
(WebKit::WebConnectionToUIProcess::didReceiveMessage):
(WebKit::WebConnectionToUIProcess::didReceiveSyncMessage):
(WebKit::WebConnectionToUIProcess::didClose):
(WebKit::WebConnectionToUIProcess::didReceiveInvalidMessage):
(WebKit::WebConnectionToUIProcess::syncMessageSendTimedOut):
(WebKit::WebConnectionToUIProcess::windowsToReceiveSentMessagesWhileWaitingForSyncReply):
(WebKit::WebConnectionToUIProcess::willProcessMessageOnClientRunLoop):

  • WebProcess/WebConnectionToUIProcess.h: Added.

(WebKit::WebConnectionToUIProcess::connection):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initialize):
(WebKit::WebProcess::addVisitedLink):
(WebKit::WebProcess::shouldTerminate):
(WebKit::WebProcess::terminate):
(WebKit::WebProcess::removeWebFrame):
(WebKit::WebProcess::getSitesWithPluginData):
(WebKit::WebProcess::clearPluginSiteData):
(WebKit::WebProcess::getWebCoreStatistics):

  • WebProcess/WebProcess.h:

(WebKit::WebProcess::connection):
Thread connection code through WebConnectionToUIProcess.

10:40 Changeset [102013] by rniwa@webkit.org

Temporarily set --child-process=1 on Mac because 20+ tests are timing out
https://bugs.webkit.org/show_bug.cgi?id=73840

Reviewed by Simon Fraser.

Temporarily go back to single process mode on Mac.

  • Scripts/run-webkit-tests:

(platformIsReadyForParallelTesting):

10:40 Changeset [102012] by timothy@apple.com

Keep both InspectorBackend.js and InspectorBackendStub.js in Release builds after
they have been combined into inspector.js.

The InspectorBackend.js file split out of the generated InspectorBackendStub.js
in r101670, and both files are needed to be useful.

https://webkit.org/b/73839

Reviewed by Joseph Pecoraro and Brian Weinstein.

  • WebCore.xcodeproj/project.pbxproj: Pass -not -name "InspectorBackend*.js" to find

instead of -not -name InspectorBackendStub.js.

10:25 Changeset [102011] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=73624
JIT + INTERPRETER builds are broken

Reviewed by Geoff Garen, Sam Weinig.

These don't fallback to the interpreter correctly.
Thunk creation assumes that is the JIT is compiled in, then it is enabled.

  • jit/JITStubs.cpp:

(JSC::JITThunks::JITThunks):

  • runtime/Executable.h:

(JSC::NativeExecutable::create):
(JSC::NativeExecutable::finishCreation):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::getHostFunction):

10:13 Changeset [102010] by scheib@chromium.org

[Chromium] Marking animations/animation-add-events-in-handler CRASH in test_expectations

  • platform/chromium/test_expectations.txt:
09:59 Changeset [102009] by scheib@chromium.org

[Chromium] Rebaselining aria-checkbox-sends-notification-expected

  • platform/chromium-cg-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/accessibility/aria-checkbox-sends-notification-expected.txt: Added.
  • platform/chromium-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt: Added.
  • platform/chromium-mac-snowleopard/accessibility/aria-checkbox-sends-notification-expected.txt: Added.
09:47 Changeset [102008] by scheib@chromium.org

[Chromium] Expected flakey tests after fix for 73021 is committed
https://bugs.webkit.org/show_bug.cgi?id=73677

Unreviewed chromium tests expectations update.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-12-05

  • platform/chromium-linux/svg/stroke/zero-length-arc-linecaps-rendering-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/stroke: Added.
  • platform/chromium-mac-snowleopard/svg/stroke/zero-length-arc-linecaps-rendering-expected.png: Added.
  • platform/chromium-win/svg/stroke: Added.
  • platform/chromium-win/svg/stroke/zero-length-arc-linecaps-rendering-expected.png: Added.
  • platform/chromium/test_expectations.txt:
09:42 Changeset [102007] by scheib@chromium.org

[Chromium] Expected flakey tests after fix for 65796 is committed
https://bugs.webkit.org/show_bug.cgi?id=73587

Unreviewed chromium tests expectations update.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-12-05

  • platform/chromium-mac-snowleopard/svg/custom/path-moveto-only-rendering-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/subpaths-moveto-only-rendering-expected.png: Added.
  • platform/chromium-win/svg/custom/path-moveto-only-rendering-expected.png: Added.
  • platform/chromium-win/svg/custom/subpaths-moveto-only-rendering-expected.png: Added.
  • platform/chromium/test_expectations.txt: Removed redundant flakey
09:29 Changeset [102006] by mnaganov@chromium.org

Web Inspector: [Chromium] Heap profiler should designate weak references.
https://bugs.webkit.org/show_bug.cgi?id=69948

Weak references are now ignored when tracing paths to GC roots.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotEdge.prototype.get isWeak):
(WebInspector.HeapSnapshotEdge.prototype.toString):
(WebInspector.HeapSnapshotEdge.prototype.get _hasStringName):
(WebInspector.HeapSnapshotRetainerEdge.prototype.get isWeak):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshotPathFinder.prototype._fillRootChildren):
(WebInspector.HeapSnapshotPathFinder.prototype._skipEdge):

09:07 Changeset [102005] by vsevik@chromium.org

Unreviewed, rolling out r102004.
http://trac.webkit.org/changeset/102004
https://bugs.webkit.org/show_bug.cgi?id=73835

Breaks qt minimal release compilation (Requested by vsevik on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-05

  • inspector/CodeGeneratorInspector.py:

(Capitalizer.upper_camel_case_to_lower):
(RawTypes.get):
(RawTypes.String.get_c_param_type):
(RawTypes.Object.get_c_param_type):
(RawTypes.Object):
(ParamType):
(TypeData.init):
(TypeData.get_raw_type):
(TypeMap.init):
(InspectorFrontend_h):
(InspectorArray):
(InspectorObject):
(String):
(InspectorBackendDispatcher_h):
(Generator.process_command):

  • inspector/InspectorValues.h:
08:56 Changeset [102004] by commit-queue@webkit.org

Web Inspector: [protocol] generate C++ classes for protocol JSON named types
https://bugs.webkit.org/show_bug.cgi?id=72835

Patch by Peter Rybin <peter.rybin@gmail.com> on 2011-12-05
Reviewed by Yury Semikhatsky.

Extends python generator functionality.
Makes constructor in InspectorObject public.

  • inspector/CodeGeneratorInspector.py:
  • inspector/InspectorValues.h:
08:24 Changeset [102003] by podivilov@chromium.org

Web Inspector: fix fronted compilation.
https://bugs.webkit.org/show_bug.cgi?id=73831

Reviewed by Yury Semikhatsky.

  • inspector/front-end/CompilerSourceMapping.js:

(WebInspector.ClosureCompilerSourceMappingPayload):

08:17 Changeset [102002] by laszlo.1.gombos@nokia.com

[Qt] Remove viewModeChanged() from QQuickWebView
https://bugs.webkit.org/show_bug.cgi?id=73828

Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/API/qt/qquickwebview_p.h: viewModeChanged is not used

and we should not expose it.

07:53 Changeset [102001] by commit-queue@webkit.org

[Qt] Add Source/qtwebkitversion.h to .gitignore
https://bugs.webkit.org/show_bug.cgi?id=73823

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2011-12-05
Reviewed by Tor Arne Vestbø.

  • .gitignore:
07:52 Changeset [102000] by aroben@apple.com

Redeploy apple-macpro-7 and apple-xserve-1

These slaves have been sitting idle since we removed our Leopard builders in r97496.

Fixes <http://webkit.org/b/73829> REGRESSION (r97496): apple-macpro-7 and apple-xserve-1 are
sitting idle

Reviewed by Sam Weinig.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Re-added apple-macpro-7 and

apple-xserve-1. The former is now doing "SnowLeopard Intel Debug (WebKit2 Tests)", which
allows apple-xserve-9 to be a build-only slave, and the latter is doing "Lion Intel Debug
(WebKit2 Tests)".

07:38 Changeset [101999] by eric.carlson@apple.com

Out-of-band text tracks may only load from same origin as the media element's Document's origin
https://bugs.webkit.org/show_bug.cgi?id=73184

Reviewed by Sam Weinig.

Source/WebCore:

Test: http/tests/security/text-track-crossorigin.html

  • html/HTMLTrackElement.cpp:

(WebCore::urlForLogging): Debug-only function for logging urls.
(WebCore::HTMLTrackElement::scheduleLoad): Call canLoadUrl() before passing control off to

the Track.

(WebCore::HTMLTrackElement::canLoadUrl): Don't ask HTMLMediaElement to validate the url, the

requirements for <track> are different from <video>.

(WebCore::HTMLTrackElement::didCompleteLoad): Change bool param to enum.
(WebCore::HTMLTrackElement::mediaElementCrossOriginAttribute): New, return parent 'crossorigin'

attribute value.

  • html/HTMLTrackElement.h:
  • html/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::scheduleLoad): Add comments from the spec.
(WebCore::LoadableTextTrack::loadTimerFired): Always cancel pending loads. Let the caller know

if the loader refuses the url immediately.

(WebCore::LoadableTextTrack::cueLoadingStarted): The <track> deals with readyState.
(WebCore::LoadableTextTrack::cueLoadingCompleted): HTMLTrackElement::didCompleteLoad takes

an enum, not a bool.

  • loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::corsPolicyPreventedLoad): New, log the error and set m_state.
(WebCore::TextTrackLoader::notifyFinished): Check for CORS failure.
(WebCore::TextTrackLoader::load): Take media element cross-origin attribute as a param so we

can make the correct checks.

  • loader/TextTrackLoader.h:

LayoutTests:

  • http/tests/security/resources/captions-with-access-control-headers.php: Added
  • http/tests/security/resources/captions.vtt: Added.
  • http/tests/security/text-track-crossorigin-expected.txt: Added.
  • http/tests/security/text-track-crossorigin.html: Added.
  • media/track/track-add-track-expected.txt: Updated results.
  • media/track/track-add-track.html: readyState changes as soon as the track url is set.
  • platform/efl/Skipped: Skip new test.
  • platform/gtk/Skipped: Ditto.
  • platform/mac/Skipped: Ditto.
  • platform/qt/Skipped: Ditto.
  • platform/win/Skipped: Ditto.
  • platform/wincairo/Skipped: Ditto.
07:30 Changeset [101998] by rolandsteiner@chromium.org

"Raw" pseudo selectors don't match if immediately after a child or descendant combinator
https://bugs.webkit.org/show_bug.cgi?id=72933

Source/WebCore:

Remove shortcut that prevents universal selectors from being created before shadow pseudo-elements.

Reviewed by Antti Koivisto.

  • css/CSSParser.cpp:

(WebCore::CSSParser::updateSpecifiersWithElementName):

LayoutTests:

Add tests cases for "raw" shadow pseudo-element selectors with various combinators.
Also add cases with explicit universal '*' selector.

Reviewed by Antti Koivisto.

  • fast/css/css-selector-text-expected.txt:
  • fast/css/css-selector-text.html:
  • fast/css/css-set-selector-text-expected.txt:
  • fast/css/css-set-selector-text.html:
  • fast/css/unknown-pseudo-element-matching-expected.txt:
  • fast/css/unknown-pseudo-element-matching.html:
07:21 Changeset [101997] by vsevik@chromium.org

Unreviewed chromium tests rebaseline.

  • platform/chromium-cg-mac-snowleopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Copied from LayoutTests/platform/chromium/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt.
  • platform/chromium-cg-mac-snowleopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Copied from LayoutTests/platform/chromium/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt.
  • platform/chromium-mac-leopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Removed.
  • platform/chromium-mac-leopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Renamed from LayoutTests/platform/chromium/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt.
  • platform/chromium-mac-snowleopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Renamed from LayoutTests/platform/chromium/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt.
  • platform/chromium-win/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Removed.
06:47 Changeset [101996] by kenneth@webkit.org

[Qt] Make the UI of the MiniBrowser slightly nicer

Rubberstamped by Simon Hausmann.

  • Add proper padding
  • Show feedback when pressing on the toolbar icons
  • Make the text entry better looking
  • MiniBrowser/qt/qml/BrowserWindow.qml:
06:46 Changeset [101995] by commit-queue@webkit.org

Unreviewed, rolling out r101983.
http://trac.webkit.org/changeset/101983
https://bugs.webkit.org/show_bug.cgi?id=73827

It broke all tests on GTK and on Qt in debug mode (Requested
by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-05

  • dom/Document.h:

(WebCore::Node::Node):

  • dom/Node.cpp:

(WebCore::Node::~Node):

  • dom/Node.h:

(WebCore::Node::inDocument):

06:32 Changeset [101994] by vsevik@chromium.org

Unreviewed chromium tests expectations update.

  • platform/chromium/test_expectations.txt:
06:16 Changeset [101993] by vsevik@chromium.org

Unreviewed, fixed chromium DEPS syntax.

  • DEPS:
05:50 Changeset [101992] by vsevik@chromium.org

Unreviewed. Rolled DEPS.

  • DEPS:
05:44 Changeset [101991] by vsevik@chromium.org

Unreviewed chromium tests rebaseline.

  • platform/chromium-mac-leopard/svg/custom/svg-fonts-word-spacing-expected.txt: Removed.
05:35 Changeset [101990] by vsevik@chromium.org

Unreviewed chrmoium tests rebaseline.

  • platform/chromium-cg-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt: Removed.
04:24 Changeset [101989] by vsevik@chromium.org

Unreviewed chromium tests expectations update.

  • platform/chromium/test_expectations.txt:
03:54 Changeset [101988] by vsevik@chromium.org

Unreviewed chromium tests rebaseline.

  • platform/chromium-cg-mac-snowleopard/svg/custom/svg-fonts-word-spacing-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/custom/svg-fonts-word-spacing-expected.png.
  • platform/chromium-mac-leopard/svg/custom/svg-fonts-word-spacing-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/svg-fonts-word-spacing-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/custom/svg-fonts-word-spacing-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/svg-fonts-word-spacing-expected.png.
03:48 Changeset [101987] by rolandsteiner@chromium.org

<style scoped>: Add 'scoped' attribute
https://bugs.webkit.org/show_bug.cgi?id=67718

Source/WebCore:

Add 'scoped' attribute to IDL and attribute list,
implement and test setting/resetting of the attribute.

Reviewed by Antti Koivisto.

Test: fast/css/style-scoped/basic-attribute.html

  • html/HTMLAttributeNames.in:
  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::scoped):
(WebCore::HTMLStyleElement::setScoped):
(WebCore::HTMLStyleElement::scopingElement):

  • html/HTMLStyleElement.h:
  • html/HTMLStyleElement.idl:

LayoutTests:

Test setting/resetting of the 'scoped' attribute in various circumstances.
Disable test directory, since STYLE_SCOPED is not enabled by default.

Reviewed by Antti Koivisto.

  • fast/css/style-scoped/basic-attribute-expected.txt: Added.
  • fast/css/style-scoped/basic-attribute.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
03:38 Changeset [101986] by vsevik@chromium.org

Unreviewed chromium tests rebaseline.

  • platform/chromium-mac-leopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Added.
  • platform/chromium-mac-leopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Added.
03:26 Changeset [101985] by tkent@chromium.org

Convert input-appearance-spinbutton-visibility.html to a reftest
https://bugs.webkit.org/show_bug.cgi?id=73807

Reviewed by Hajime Morita.

  • fast/forms/input-appearance-spinbutton-visibility-expected.html: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
  • platform/chromium-linux/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
  • platform/chromium-win/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
  • platform/chromium-win/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Removed.
  • platform/efl/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
  • platform/efl/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Removed.
  • platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
  • platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Removed.
  • platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
  • platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Removed.
  • platform/qt/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
  • platform/qt/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Removed.
03:20 Changeset [101984] by vsevik@chromium.org

Unreviewed chromium test expectations update.

  • platform/chromium/test_expectations.txt:
03:15 Changeset [101983] by morrita@google.com

[Refactoring] Accessing Node::m_document should be minimized.
https://bugs.webkit.org/show_bug.cgi?id=73800

Reviewed by Kent Tamura.

No new tests. No behavioral change.

Replaced m_document reference with the document() accessor
or temporaril variables. This is a preparation for using
m_document space to point a shadow root pointer.

  • dom/Document.h:

(WebCore::Node::Node):

  • dom/Node.cpp:

(WebCore::Node::~Node):

  • dom/Node.h:

(WebCore::Node::inDocument):

02:00 Changeset [101982] by ossy@webkit.org

[Qt] Unreviewed gardening. Add platform specific results.

Patch by Czene Tamás <tczene@inf.u-szeged.hu> on 2011-12-05

  • platform/qt/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png: Added.
  • platform/qt/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Added.
  • platform/qt/svg/custom/pointer-events-image-css-transform-expected.png: Added.
  • platform/qt/svg/custom/pointer-events-image-css-transform-expected.txt: Added.
  • platform/qt/svg/custom/pointer-events-text-css-transform-expected.png: Added.
  • platform/qt/svg/custom/pointer-events-text-css-transform-expected.txt: Added.
  • platform/qt/svg/stroke/zero-length-arc-linecaps-rendering-expected.png: Added.
  • platform/qt/svg/stroke/zero-length-arc-linecaps-rendering-expected.txt: Added.
01:50 Changeset [101981] by vsevik@chromium.org

Unreviewed chromium expectations update.

  • platform/chromium-win/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Added.
  • platform/chromium-win/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Added.
  • platform/chromium/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Added.
  • platform/chromium/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Added.
01:41 Changeset [101980] by ossy@webkit.org

MacroAssemblerSH4 does not implement readCallTarget
https://bugs.webkit.org/show_bug.cgi?id=73434

Patch by Zoltan Herczeg <zherczeg@webkit.org> on 2011-12-05
Reviewed by Csaba Osztrogonác.

  • assembler/MacroAssemblerSH4.h: Support for SH4.

(JSC::MacroAssemblerSH4::readCallTarget):

  • assembler/SH4Assembler.h:

(JSC::SH4Assembler::readCallTarget):

01:28 Changeset [101979] by kkristof@inf.u-szeged.hu

NRWT should handle duplicated expectations
https://bugs.webkit.org/show_bug.cgi?id=69750

00:47 Changeset [101978] by commit-queue@webkit.org

Asynchronous SpellChecker should consider multiple requests.
https://bugs.webkit.org/show_bug.cgi?id=72939

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-12-05
Reviewed by Hajime Morita.

Source/WebCore:

Now SpellChecker saves a request when it is processing the previous spellcheck request.
If there is a request having the same root editable element, the older request is replaced by newer request

Test: editing/spelling/spellcheck-queue.html

  • editing/SpellChecker.cpp:

(WebCore::SpellChecker::SpellCheckRequest::SpellCheckRequest):

A structure to have spell check request.

(WebCore::SpellChecker::SpellCheckRequest::sequence):
(WebCore::SpellChecker::SpellCheckRequest::range):
(WebCore::SpellChecker::SpellCheckRequest::text):
(WebCore::SpellChecker::SpellCheckRequest::mask):
(WebCore::SpellChecker::SpellCheckRequest::rootEditableElement):
(WebCore::SpellChecker::SpellChecker):
(WebCore::SpellChecker::createRequest):
(WebCore::SpellChecker::timerFiredToProcessQueuedRequest):

When timer is fired, queued request is processed if any.

(WebCore::SpellChecker::canCheckAsynchronously):
(WebCore::SpellChecker::requestCheckingFor):

When the spellchecker is processing another request, the latest request is queued.

(WebCore::SpellChecker::invokeRequest):
(WebCore::SpellChecker::enqueueRequest):

Enqueues a request. If there is an older request whose root editable element is the same as the request,
it will be replaced.

(WebCore::SpellChecker::didCheck):

  • editing/SpellChecker.h:

LayoutTests:

Tests for multiple spellcheck requests.

  • editing/spelling/spellcheck-queue-expected.txt: Added.
  • editing/spelling/spellcheck-queue.html: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
00:42 Changeset [101977] by eric.carlson@apple.com

Source/WebCore: WebCore part of: Add WebKit preferences for text track settings
https://bugs.webkit.org/show_bug.cgi?id=73721

Reviewed by John Sullivan.

No new tests yet, still nothing to test.

  • page/Settings.cpp:

(WebCore::Settings::setShouldDisplaySubtitles): Move the setters to the .cpp file so they

aren't inlined.

(WebCore::Settings::setShouldDisplayCaptions): Ditto.
(WebCore::Settings::setShouldDisplayTextDescriptions): Ditto.

  • page/Settings.h:

Source/WebKit/chromium: WebKit/chromium part of: Add WebKit preferences for text track settings
https://bugs.webkit.org/show_bug.cgi?id=73721

Reviewed by John Sullivan.

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::shouldDisplaySubtitles): Added.
(WebKit::WebSettingsImpl::shouldDisplayCaptions): Ditto.
(WebKit::WebSettingsImpl::shouldDisplayTextDescriptions): Ditto.

  • src/WebSettingsImpl.h:

Source/WebKit/mac: Add WebKit preferences for text track settings
https://bugs.webkit.org/show_bug.cgi?id=73721

Reviewed by John Sullivan.

  • WebView/WebPreferenceKeysPrivate.h: Added #define for shouldDisplaySubtitles, shouldDisplayCaptions,

and shouldDisplayTextDescriptions properties.

  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]): Initialize new preferences to NO.
(-[WebPreferences setShouldDisplaySubtitles:]): Added.
(-[WebPreferences shouldDisplaySubtitles]): Ditto.
(-[WebPreferences setShouldDisplayCaptions:]): Ditto.
(-[WebPreferences shouldDisplayCaptions]): Ditto.
(-[WebPreferences setShouldDisplayTextDescriptions:]): Ditto.
(-[WebPreferences shouldDisplayTextDescriptions]): Ditto.

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]): Updates WebCore settings from WebKit prefs.

Source/WebKit/win: WebKit/mac part of: Add WebKit preferences for text track settings
https://bugs.webkit.org/show_bug.cgi?id=73721

Reviewed by John Sullivan.

  • Interfaces/IWebPreferences.idl: Declare getters and setters for new properties.
  • WebPreferenceKeysPrivate.h: Added #define for shouldDisplaySubtitles, shouldDisplayCaptions,

and shouldDisplayTextDescriptions properties.

  • WebPreferences.cpp:

(WebPreferences::setShouldDisplaySubtitles): Added.
(WebPreferences::shouldDisplaySubtitles): Ditto.
(WebPreferences::setShouldDisplayCaptions): Ditto.
(WebPreferences::shouldDisplayCaptions): Ditto.
(WebPreferences::setShouldDisplayTextDescriptions): Ditto.
(WebPreferences::shouldDisplayTextDescriptions): Ditto.

  • WebPreferences.h: Declare new methods.
  • WebView.cpp:

(WebView::notifyPreferencesChanged): Updates WebCore settings from WebKit prefs.

Source/WebKit2: WebKit2 part of: Add WebKit preferences for text track settings
https://bugs.webkit.org/show_bug.cgi?id=73721

Reviewed by John Sullivan.

  • Shared/WebPreferencesStore.h: Declared shouldDisplaySubtitles, shouldDisplayCaptions, and

shouldDisplayTextDescriptions properties with macros. All default to false.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetShouldDisplaySubtitles): Added.
(WKPreferencesGetShouldDisplaySubtitles): Ditto.
(WKPreferencesSetShouldDisplayCaptions): Ditto.
(WKPreferencesGetShouldDisplayCaptions): Ditto.
(WKPreferencesSetShouldDisplayTextDescriptions): Ditto.
(WKPreferencesGetShouldDisplayTextDescriptions): Ditto.

  • UIProcess/API/C/WKPreferences.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Updates WebCore settings from WebKit2 prefs.

00:19 Changeset [101976] by ossy@webkit.org

[Qt] REGRESSION(101967): It made editing/style/iframe-onload-crash-mac.html timeout
https://bugs.webkit.org/show_bug.cgi?id=73802

  • platform/qt/Skipped: Skip the failing test.

12/04/11:

23:58 Changeset [101975] by noel.gordon@gmail.com

ImageDecoder setSize() should check for backing store allocation failure
https://bugs.webkit.org/show_bug.cgi?id=72864

Reviewed by Adam Barth.

The backing store of a decoded image is a Vector<PixelData> on the affected
ports. And Vector<> provides a resize capacity member that returns false if
memory allocation fails.

setSize() should be called once only during an image decode - add an ASSERT
for that. Resize the backing store capacity to the requested image size and
return false if memory allocation fails.

ImageDecoder::isOverSize(width, height) is called to check that the decoded
width and height won't overflow 'width x height x sizeof(PixelData)' before
calls to setSize(). Refer to http://webkit.org/b/48634

No new tests. Covered by fast/images/size-failure.html

  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageFrame::setSize):

23:42 Changeset [101974] by commit-queue@webkit.org

Add binary support in WebSocket test server's echo handler.
https://bugs.webkit.org/show_bug.cgi?id=73649

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-12-04
Reviewed by Eric Seidel.

  • http/tests/websocket/tests/hybi/echo_wsh.py: Support binary frames.
22:52 Changeset [101973] by eric@webkit.org

After success with Mac, Win and Gtk, turning on parallel testing
by default for all platforms (except Qt).

We'll add more platforms to the blacklist if we see problems.

Unreviewed.

  • Scripts/run-webkit-tests:

(platformIsReadyForParallelTesting):

21:44 Changeset [101972] by kling@webkit.org

CSSStyleSheet can't be reparented, enforce this at compile time.
<http://webkit.org/b/73793>

Reviewed by Benjamin Poulain.

  • css/StyleSheet.h:

(WebCore::StyleSheet::clearOwnerRule):

Changed setParentRule(CSSImportRule*) to clearOwnerRule() to document and
enforce the fact that style sheets should never be reparented after creation.

(WebCore::StyleSheet::ownerRule):

Renamed parentRule() to ownerRule() to match the CSSOM name.

(WebCore::StyleSheet::ownerNode):
(WebCore::StyleSheet::clearOwnerNode):

Also renamed StyleSheet::m_parentNode to m_ownerNode to match its accessors.

  • css/CSSStyleSheet.h:

Removed ownerRule() as we now inherit it from StyleSheet.

  • bindings/js/JSDOMBinding.h:

(WebCore::root):

  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::~CSSImportRule):
(WebCore::CSSImportRule::setCSSStyleSheet):

  • css/StyleSheet.cpp:

(WebCore::StyleSheet::StyleSheet):
(WebCore::StyleSheet::parentStyleSheet):
(WebCore::StyleSheet::baseURL):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::fillMediaListChain):

Update call sites to use the new names.

21:24 Changeset [101971] by tkent@chromium.org

[Chromium] Rebaseline of placeholder tests for r101742 and r101848.

  • platform/chromium-cg-mac-leopard/fast/forms/input-placeholder-visibility-1-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/input-placeholder-visibility-3-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/placeholder-position-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/fast/forms/placeholder-position-expected.png.
  • platform/chromium-cg-mac-snowleopard/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
  • platform/chromium-linux/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-linux/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-linux/fast/forms/search-styled-expected.txt:
  • platform/chromium-linux/fast/forms/textarea-placeholder-visibility-1-expected.png:
  • platform/chromium-linux/fast/forms/textarea-placeholder-visibility-2-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-mac-leopard/fast/forms/textarea-placeholder-visibility-1-expected.png:
  • platform/chromium-mac-leopard/fast/forms/textarea-placeholder-visibility-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-position-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/placeholder-position-expected.png.
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-pseudo-style-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.png.
  • platform/chromium-mac-snowleopard/fast/forms/search-styled-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/search-styled-expected.png.
  • platform/chromium-mac-snowleopard/fast/forms/textarea-placeholder-pseudo-style-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/textarea-placeholder-pseudo-style-expected.png.
  • platform/chromium-mac-snowleopard/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-placeholder-visibility-1-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-placeholder-visibility-3-expected.png: Removed.
  • platform/chromium-mac/fast/forms/textarea-placeholder-visibility-1-expected.png: Removed.
  • platform/chromium-mac/fast/forms/textarea-placeholder-visibility-2-expected.png: Removed.
  • platform/chromium-win-xp/fast/forms/search-styled-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-position-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/chromium-win/fast/forms/search-styled-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.png:
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.png:
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.txt: Removed.
  • platform/mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.txt: Removed.
  • platform/mac-snowleopard/fast/forms/textarea-placeholder-visibility-1-expected.txt: Removed.
  • platform/mac-snowleopard/fast/forms/textarea-placeholder-visibility-2-expected.txt: Removed.
18:29 Changeset [101970] by kling@webkit.org

border-width: initial and border-color: initial cannot be removed via CSSOM.
<http://webkit.org/b/68551>

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/css/cssom-remove-shorthand-property.html

When asked to remove a shorthand property, we should toss out both the
sub-properties of that shorthand as well as the shorthand itself, should the
declaration contain it. The latter part was missing in our implementation.

  • css/CSSMutableStyleDeclaration.h:
  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
(WebCore::CSSMutableStyleDeclaration::removeShorthandProperty):

Changed to return true only if something was actually removed.

LayoutTests:

Add a test verifying that shorthand properties can be added/removed
via CSSOM'S CSSStyleDeclaration interface.

  • fast/css/cssom-remove-shorthand-property-expected.txt: Added.
  • fast/css/cssom-remove-shorthand-property.html: Added.
15:09 Changeset [101969] by commit-queue@webkit.org

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-04

  • DEPS:
14:10 Changeset [101968] by darin@apple.com

Removed obsolete expected results that should have been removed when converting to a ref test.

  • platform/chromium-cg-mac-leopard/css3/unicode-bidi-isolate-aharon-expected.png: Removed.
  • platform/chromium-linux/css3/unicode-bidi-isolate-aharon-expected.png: Removed.
  • platform/chromium-mac-leopard/css3/unicode-bidi-isolate-aharon-expected.png: Removed.
  • platform/chromium-mac/css3/unicode-bidi-isolate-aharon-expected.png: Removed.
  • platform/chromium-win/css3/unicode-bidi-isolate-aharon-expected.png: Removed.
  • platform/chromium-win/css3/unicode-bidi-isolate-aharon-expected.txt: Removed.
  • platform/efl/css3/unicode-bidi-isolate-aharon-expected.png: Removed.
  • platform/efl/css3/unicode-bidi-isolate-aharon-expected.txt: Removed.
  • platform/gtk/css3/unicode-bidi-isolate-aharon-expected.png: Removed.
  • platform/gtk/css3/unicode-bidi-isolate-aharon-expected.txt: Removed.
  • platform/mac/css3/unicode-bidi-isolate-aharon-expected.png: Removed.
  • platform/mac/css3/unicode-bidi-isolate-aharon-expected.txt: Removed.
13:52 Changeset [101967] by rniwa@webkit.org

HIERARCHY_REQUEST_ERR check in checkAcceptChild should be optimized for newChild without children
https://bugs.webkit.org/show_bug.cgi?id=73737

Reviewed by Darin Adler.

It turned out that 50-70% of nodes inserted by DOM APIs such as insertBefore and appendChild
don't have any descendent nodes. Optimize isDescendantOf which is used by checkAcceptChild for this case.
On a test case attached on the bug, we see a 40% improvement.

Also optimize for cases where either new child or new parent but not both are in document as suggested
by Erik Arvidsson. This appears to happen about 40-70% of the time, and the symmetric difference between
the two cases is about 50% so it's worth implementing both optimizations.

Unfortunately no tests because we still have a O(n) algorithm somewhere.

  • dom/Node.cpp:

(WebCore::Node::isDescendantOf):
(WebCore::Node::contains):

13:50 Changeset [101966] by darin@apple.com
  • platform/mac/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-visibility-2-expected.txt:

Oops, landed the wrong versions of these yesterday. These are the right ones.

13:25 Changeset [101965] by weinig@apple.com

Add tests for RetainPtr::adoptNS/adoptCF
https://bugs.webkit.org/show_bug.cgi?id=73470

Reviewed by Adam Roben and Darin Adler.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp: Added.

(TestWebKitAPI::TEST):
Test that adopting using adoptCF creates a RetainPtr with a
value whose retain count is 1.

  • TestWebKitAPI/Tests/WTF/ns: Added.
  • TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm: Added.

(TestWebKitAPI::TEST):
Test that adopting using adoptNS creates a RetainPtr with a
value whose retain count is 1.

13:16 Changeset [101964] by fpizlo@apple.com

DFG should optimize strict equality
https://bugs.webkit.org/show_bug.cgi?id=73764

Reviewed by Oliver Hunt.

1% speed-up on V8.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEqForConstant):
(JSC::DFG::SpeculativeJIT::compileStrictEq):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileIntegerCompare):
(JSC::DFG::SpeculativeJIT::compileDoubleCompare):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compileIntegerCompare):
(JSC::DFG::SpeculativeJIT::compileDoubleCompare):
(JSC::DFG::SpeculativeJIT::compile):

12:42 Changeset [101963] by commit-queue@webkit.org

[Qt] cleanup qmltests.pro
https://bugs.webkit.org/show_bug.cgi?id=73718

Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-12-04
Reviewed by Simon Hausmann.

Removed unused file WebView/tst_loadZeroSizeView.qml and reordered file list.

  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
11:09 Changeset [101962] by philn@webkit.org

[WK2][GTK] enable-fullscreen WebSettings
https://bugs.webkit.org/show_bug.cgi?id=73774

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_set_enable_fullscreen):
(webkit_settings_get_enable_fullscreen):

  • UIProcess/API/gtk/WebKitSettings.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings):

10:46 Changeset [101961] by mrobinson@webkit.org

[GTK] Include cairo, pixman and gnome-icon-theme in the jhbuild modules
https://bugs.webkit.org/show_bug.cgi?id=73748

Reviewed by Gustavo Noronha Silva.

  • gtk/jhbuild.modules: Add some new modules the jhbuild moduleset.
08:58 Changeset [101960] by mario@webkit.org

[Gtk] Check for the load-complete event only in the unit tests.

There is currently a known issue happening in debug builds when
reloading the webview if it was loaded before through the function
webkit_web_view_load_string, resulting in a ASSERT failing (see
bug 50331) so we can't check for the reload event here, since it
makes the test to fail. Fortunately, checking for load-complete
event is a good enough test, so this small patch is about that.

Rubber-stamped by Philippe Normand.

  • tests/testatk.c:

(testWebkitAtkDocumentLoadingEvents): Don't load and then reload
to check events, just load once and check whether the
'load-complete' event has happened.

08:31 Changeset [101959] by kling@webkit.org

CSSValuePool: Inline trivial getters.
<http://webkit.org/b/73763>

Reviewed by Anders Carlsson.

  • css/CSSValuePool.cpp:
  • css/CSSValuePool.h:

(WebCore::CSSValuePool::createInheritedValue): Inlined.
(WebCore::CSSValuePool::createImplicitInitialValue): Ditto.
(WebCore::CSSValuePool::createExplicitInitialValue): Ditto.

07:48 Changeset [101958] by philn@webkit.org

Unreviewed, skip two more tests.

  • platform/gtk/Skipped: Skip

platform/gtk/fonts/custom-font-missing-glyphs.html failing on
64-bit Debug.

  • platform/gtk/test_expectations.txt:

fast/table/multiple-captions-display.xhtml is flaky.

07:32 Changeset [101957] by philn@webkit.org

Unreviewed, moving flaky ref test to Skipped list.

  • platform/gtk/Skipped:
  • platform/gtk/test_expectations.txt:
05:59 Changeset [101956] by philn@webkit.org

Unreviewed, skip two flaky tests and one SVG test timing out on GTK.

  • platform/gtk/test_expectations.txt: Skip two fast/ tests.
  • platform/gtk/Skipped: Skip svg/text/text-style-recalc-crash.html
05:10 Changeset [101955] by philn@webkit.org

Another GTK build fix after r101922.

Rubber-stamped by Martin Robinson.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::pathToLocalResource): Plug possible String ref leak.

04:42 Changeset [101954] by xan@webkit.org

2011-12-04 Xan Lopez <xlopez@igalia.com>

Fix compiler warning in LayoutTestController

Reviewed by Philippe Normand.

  • DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): fix warning.
03:56 Changeset [101953] by commit-queue@webkit.org

Add missing methods used by fast/notifications tests to LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=63616

Patch by Alexandre Mazari <scaroo@gmail.com> on 2011-12-04
Reviewed by Martin Robinson.

Add missing simulateDesktopNotificationClick method used by
fast/notifications. Provide a default implementation for
areDesktopNotificationPermissionRequestsIgnored and
ignoreDesktopNotificationPermissionRequests.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController): call into the port implementation.
(simulateDesktopNotificationClickCallback): ditto.
(ignoreDesktopNotificationPermissionRequestsCallback): default implementation.
(LayoutTestController::staticFunctions): declare new methods.
(LayoutTestController::ignoreDesktopNotificationPermissionRequests): default implementation.

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController::areDesktopNotificationPermissionRequestsIgnored):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::simulateDesktopNotificationClick): dummy implementation.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::simulateDesktopNotificationClick): ditto.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::simulateDesktopNotificationClick): ditto.

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::simulateDesktopNotificationClick): ditto.

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::simulateDesktopNotificationClick): ditto.

03:32 Changeset [101952] by commit-queue@webkit.org

[EFL] Fix broken UTF-8 characters issue on editor command.
https://bugs.webkit.org/show_bug.cgi?id=73516

Patch by Kangil Han <kangil.han@samsung.com> on 2011-12-04
Reviewed by Ryosuke Niwa.

The issue has been described that Korean character is broken on pasting copied text.
In my analysis, this is from lack of format change between C style UTF-8 character pointer and C++ style String reference.
Therefore, this patch will convert types to resolve the problem.

  • ewk/ewk_view.cpp:

(_ewk_view_editor_command):

01:39 Changeset [101951] by mario@webkit.org

Source/WebKit/gtk: Removing document related events from DRT

[GTK] Don't log document events in DRT
https://bugs.webkit.org/show_bug.cgi?id=73746

Reviewed by Martin Robinson.

New unit test to check events when reloading a document. This
replaces the former document-reload-events.html layout test.

  • tests/testatk.c:

(updateLoadingEventsResult): New, updates a global variable to
allow checking later on that the right signals were emmitted.
(documentLoadingEventCallback): New, global listener for load-complete
and reload signals over the document object (the web area).
(testWebkitAtkDocumentLoadingEvents): New unit test, globally
connects to document-related signals and check they are properly
emitted when reloading the web view.
(main): Added new test.

Tools: [GTK] Don't log document events in DRT
https://bugs.webkit.org/show_bug.cgi?id=73746

Reviewed by Martin Robinson.

Stop connecting globally to document-related events.

  • DumpRenderTree/gtk/AccessibilityCallbacks.cpp:

(connectAccessibilityCallbacks): Removed connections.
(disconnectAccessibilityCallbacks): Removed disconnections.

LayoutTests: [GTK] Don't log document events in DRT
https://bugs.webkit.org/show_bug.cgi?id=73746

Reviewed by Martin Robinson.

Unskip passing test, remove other transformed into a unit test and
rebaseline expectations now we stopped logging document events.

  • platform/gtk/Skipped: Removed two skipped tests.
  • platform/gtk/accessibility/aria-slider-required-attributes-expected.txt: Rebaselined
  • platform/gtk/accessibility/combo-box-collapsed-selection-changed-expected.txt: Ditto.
  • platform/gtk/accessibility/document-reload-events-expected.txt: Removed.
  • platform/gtk/accessibility/document-reload-events.html: Removed.
00:55 Changeset [101950] by rniwa@webkit.org

Add failing expectation to css3/unicode-bidi-isolate-aharon-failing.html as it was split from
css3/unicode-bidi-isolate-aharon.html in r101949.

  • platform/chromium/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
  • platform/win/test_expectations.txt:
00:28 Changeset [101949] by rniwa@webkit.org

Convert isolate and plaintext tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=73680

Reviewed by Darin Adler.

Convert bdi-element-expected.html, unicode-bidi-isolate-aharon.html, and unicode-bidi-plaintext.html to reftests.
In addition, isolate the failing test case in unicode-bidi-plaintext.html as unicode-bidi-isolate-aharon-failing.html.

  • css3/bdi-element-expected.html: Copied from LayoutTests/css3/bdi-element.html.
  • css3/unicode-bidi-isolate-aharon-expected.html: Copied from LayoutTests/css3/unicode-bidi-isolate-aharon.html.
  • css3/unicode-bidi-isolate-aharon-failing-expected.html: Added.
  • css3/unicode-bidi-isolate-aharon-failing.html: Added.
  • css3/unicode-bidi-isolate-aharon.html:
  • fast/text/international/unicode-bidi-plaintext.html:
  • platform/chromium-cg-mac-leopard/css3/bdi-element-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css3/bdi-element-expected.txt: Removed.
  • platform/chromium-cg-mac-leopard/fast/text/international/unicode-bidi-plaintext-expected.png: Removed.
  • platform/chromium-cg-mac/css3/bdi-element-expected.png: Removed.
  • platform/chromium-linux/css3/bdi-element-expected.png: Removed.
  • platform/chromium-linux/fast/text/international/unicode-bidi-plaintext-expected.png: Removed.
  • platform/chromium-mac-leopard/css3/bdi-element-expected.png: Removed.
  • platform/chromium-mac-leopard/css3/bdi-element-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/text/international/unicode-bidi-plaintext-expected.png: Removed.
  • platform/chromium-mac/css3/bdi-element-expected.png: Removed.
  • platform/chromium-mac/fast/text/international/unicode-bidi-plaintext-expected.png: Removed.
  • platform/chromium-win/css3/bdi-element-expected.png: Removed.
  • platform/chromium-win/css3/bdi-element-expected.txt: Removed.
  • platform/chromium-win/fast/text/international/unicode-bidi-plaintext-expected.png: Removed.
  • platform/chromium-win/fast/text/international/unicode-bidi-plaintext-expected.txt: Removed.
  • platform/chromium/css3/bdi-element-expected.txt: Removed.
  • platform/efl/css3/bdi-element-expected.png: Removed.
  • platform/efl/css3/bdi-element-expected.txt: Removed.
  • platform/efl/fast/text/international/unicode-bidi-plaintext-expected.png: Removed.
  • platform/efl/fast/text/international/unicode-bidi-plaintext-expected.txt: Removed.
  • platform/gtk/css3/bdi-element-expected.png: Removed.
  • platform/gtk/css3/bdi-element-expected.txt: Removed.
  • platform/gtk/fast/text/international/unicode-bidi-plaintext-expected.png: Removed.
  • platform/gtk/fast/text/international/unicode-bidi-plaintext-expected.txt: Removed.
  • platform/mac/css3/bdi-element-expected.png: Removed.
  • platform/mac/css3/bdi-element-expected.txt: Removed.
  • platform/mac/fast/text/international/unicode-bidi-plaintext-expected.png: Removed.
  • platform/mac/fast/text/international/unicode-bidi-plaintext-expected.txt: Removed.
  • platform/qt/css3/bdi-element-expected.png: Removed.
  • platform/qt/css3/bdi-element-expected.txt: Removed.
  • platform/win/fast/text/international/unicode-bidi-plaintext-expected.png: Removed.
  • platform/win/fast/text/international/unicode-bidi-plaintext-expected.txt: Removed.

12/03/11:

22:46 Changeset [101948] by noel.gordon@gmail.com

Fix WebPImageDecoder decoder leak.
https://bugs.webkit.org/show_bug.cgi?id=73756

Reviewed by Andreas Kling.

Delete the m_decoder member in the destructor if needed with WebPIDelete.

No new tests, it's valgrind territory.

  • platform/image-decoders/webp/WEBPImageDecoder.cpp:

(WebCore::WEBPImageDecoder::~WEBPImageDecoder):

21:49 Changeset [101947] by scheib@chromium.org

[Chromium] Rebaselined /accessibility/aria-checkbox-sends-notification-expected.txt

  • platform/chromium-cg-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/accessibility/aria-checkbox-sends-notification-expected.txt.
  • platform/chromium-cg-mac-snowleopard/accessibility/aria-checkbox-sends-notification-expected.txt: Removed.
  • platform/chromium/accessibility/aria-checkbox-sends-notification-expected.txt: Renamed from LayoutTests/platform/chromium-win/accessibility/aria-checkbox-sends-notification-expected.txt.
  • platform/chromium/test_expectations.txt:
21:20 Changeset [101946] by darin@apple.com

Use HashMap<OwnPtr> for ScriptSampleRecordMap
https://bugs.webkit.org/show_bug.cgi?id=73758

Reviewed by Andreas Kling.

  • bytecode/SamplingTool.cpp:

(JSC::SamplingTool::notifyOfScope): Added adoptPtr.
(JSC::SamplingTool::dump): Added get.

  • bytecode/SamplingTool.h: Changed the value type of ScriptSampleRecordMap to be OwnPtr.
21:20 Changeset [101945] by darin@apple.com

Use HashMap<OwnPtr> for the opaqueJSClassData map
https://bugs.webkit.org/show_bug.cgi?id=73759

Reviewed by Andreas Kling.

  • API/JSClassRef.cpp:

(OpaqueJSClass::contextData): Update types.

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::~JSGlobalData): Add an explicit clear of opaqueJSClassData to keep the
timing the same. If we didn't care about the order of operations, we could remove this, too.

  • runtime/JSGlobalData.h: Use OwnPtr instead of raw pointer for the mapped type in the

opaqueJSClassData map.

21:11 Changeset [101944] by scheib@chromium.org

[Chromium] Supressing more failures via test_expectations.txt

  • platform/chromium/test_expectations.txt:

editing/spelling/markers.html, new expectations fail
svg/animations/svginteger-animation-1.html, merging overlapping lines

19:51 Changeset [101943] by kling@webkit.org

CSSStyleSheet: Parent rule can only ever be @import, enforce this at compile time.
<http://webkit.org/b/73725>

Reviewed by Darin Adler.

Made StyleSheet::m_parentRule a CSSImportRule* rather than a CSSRule*
and updated getters, setters and constructors accordingly.

There is no change in behavior, this simply enforces the status quo.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMBinding.h:
  • bindings/scripts/CodeGeneratorV8.pm:

(AddIncludesForType):

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::CSSStyleSheet):

  • css/CSSStyleSheet.h:

(WebCore::CSSStyleSheet::create):
(WebCore::CSSStyleSheet::ownerRule):

  • css/StyleSheet.cpp:

(WebCore::StyleSheet::StyleSheet):

  • css/StyleSheet.h:

(WebCore::StyleSheet::parentRule):
(WebCore::StyleSheet::setParentRule):

19:45 Changeset [101942] by darin@apple.com

Change HashMap implementation to use the pass type and peek type from traits for the mapped value
https://bugs.webkit.org/show_bug.cgi?id=72474

Reviewed by Anders Carlsson.

  • wtf/HashMap.h: Added ReferenceTypeMaker struct template. Get PassInType, PassOutType,

and PeekType from the traits of the mapped value instead of hard-coding them here.
Changed inlineAdd to take a reference to the PassInType instead of the PassInType itself,
to accomodate a PassInType that can't be copied. Use the store, peek, and passOut
functions from the traits as well.

  • wtf/HashTraits.h: Updated GenericHashTraits and HashTraits for OwnPtr to include

PassInType, PassOutType, PeekType, store, passOut, and peek. Before this, the file had
an earlier version that was just PassType, PeekType, pass, and peek. Also commented
the HashTraits for RefPtr to foreshadow some work we can do there.

  • wtf/RefPtrHashMap.h: Same changes as HashMap.h.
19:25 Changeset [101941] by darin@apple.com

Update some layout test expected results
https://bugs.webkit.org/show_bug.cgi?id=73755

Reviewed by Sam Weinig.

  • editing/spelling/markers-expected.txt: Added. We just forgot to check this in when the

test was added, and the test is skipped on most platforms so that was not noticed.

  • fast/css/getComputedStyle/computed-style-without-renderer.html: Changed this test to

share the list of properties to skip and the list of hidden properties.

  • fast/css/getComputedStyle/computed-style.html: Ditt.
  • fast/css/getComputedStyle/resources/property-names.js: Added. Besides the structural

change the change is that CSS_GRID_LAYOUT properties are now in the list to skip.

  • platform/mac/accessibility/multiselect-list-reports-active-option-expected.txt: Added.

Shows this test is failing on Mac, even though it is passing on Chromium. That needs a bug report.

  • platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-visibility-2-expected.txt:

Updated these results now that we don't use relative positioning for placeholders any more.
The original patch r101742 updated other platforms, including mac-snowleopard, but missed this one.

  • platform/mac/svg/css/getComputedStyle-basic-expected.txt: Removed. The Mac platform can

share the platform-independent expected results as long as we skip the CSS_GRID_LAYOUT
properties.

  • svg/css/getComputedStyle-basic.xhtml: Updated to skip the same properties that the tests

in fast/css/getComputedStyle skip.

17:22 Changeset [101940] by kling@webkit.org

Unreviewed, revert accidental change from r101932.

  • bindings/scripts/CodeGeneratorV8.pm:

(AddIncludesForType):

17:01 Changeset [101939] by mitz@apple.com

Source/WebKit/mac: <rdar://problem/10523721> Crash at WebCore::SubresourceLoader::releaseResources
Reviewed by Darin Adler.

  • WebView/WebView.mm:

(-[WebView _removeObjectForIdentifier:]): Changed the CFRelease(self) into
a WebCFAutorelease(self). This prevents re-entry into this method due to
the WebView closing and canceling all subresource loads, including the
one we have just removed.

Tools: Added a test for <rdar://problem/10523721> Crash at WebCore::SubresourceLoader::releaseResources

Reviewed by Darin Adler.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/SubresourceErrorCrash.mm: Added.

(TestWebKitAPI::TEST):

15:55 Changeset [101938] by darin@apple.com

Removed some obsolete expected result files that should have been removed in r97308 and r101738.

  • platform/efl/fast/regions/content-flowed-into-regions-dynamically-added-expected.png: Removed.
  • platform/efl/fast/regions/content-flowed-into-regions-dynamically-inserted-expected.png: Removed.
  • platform/efl/fast/regions/content-flowed-into-regions-dynamically-removed-expected.png: Removed.
  • platform/efl/fast/regions/content-flowed-into-regions-expected.png: Removed.
  • platform/efl/fast/regions/content-flowed-into-regions-with-dyn-index-expected.png: Removed.
  • platform/efl/fast/regions/content-flowed-into-regions-with-index-dom-expected.png: Removed.
  • platform/efl/fast/regions/content-flowed-into-regions-with-index-expected.png: Removed.
  • platform/mac/fast/regions/content-flowed-into-regions-dynamically-added-expected.png: Removed.
  • platform/mac/fast/regions/content-flowed-into-regions-dynamically-inserted-expected.png: Removed.
  • platform/mac/fast/regions/content-flowed-into-regions-dynamically-removed-expected.png: Removed.
  • platform/mac/fast/regions/content-flowed-into-regions-expected.png: Removed.
15:32 Changeset [101937] by commit-queue@webkit.org

[EFL] Revise ewk_view_fixed_layout_size_set
https://bugs.webkit.org/show_bug.cgi?id=73401

Patch by ChangSeok Oh <shivamidow@gmail.com> on 2011-12-03
Reviewed by Eric Seidel.

Improve readability and replace forceLayout to setNeedsLayout,
since it sometimes causes double drawing.

  • ewk/ewk_view.cpp:

(ewk_view_fixed_layout_size_set):

15:11 Changeset [101936] by commit-queue@webkit.org

Upstream 4 files into WebCore/platform/blackberry
https://bugs.webkit.org/show_bug.cgi?id=73614

Patch by Mary Wu <mary.wu@torchmobile.com.cn> on 2011-12-03
Reviewed by Eric Seidel.

  • platform/blackberry/CursorBlackBerry.cpp: Added.

(WebCore::AllCursors::AllCursors):
(WebCore::getCursor):
(WebCore::Cursor::Cursor):
(WebCore::Cursor::~Cursor):
(WebCore::Cursor::operator=):
(WebCore::aliasCursor):
(WebCore::cellCursor):
(WebCore::columnResizeCursor):
(WebCore::contextMenuCursor):
(WebCore::copyCursor):
(WebCore::crossCursor):
(WebCore::eastResizeCursor):
(WebCore::eastWestResizeCursor):
(WebCore::grabbingCursor):
(WebCore::grabCursor):
(WebCore::handCursor):
(WebCore::helpCursor):
(WebCore::iBeamCursor):
(WebCore::moveCursor):
(WebCore::noDropCursor):
(WebCore::noneCursor):
(WebCore::northEastResizeCursor):
(WebCore::northEastSouthWestResizeCursor):
(WebCore::northResizeCursor):
(WebCore::northSouthResizeCursor):
(WebCore::northWestResizeCursor):
(WebCore::northWestSouthEastResizeCursor):
(WebCore::notAllowedCursor):
(WebCore::pointerCursor):
(WebCore::progressCursor):
(WebCore::rowResizeCursor):
(WebCore::southEastResizeCursor):
(WebCore::southResizeCursor):
(WebCore::southWestResizeCursor):
(WebCore::verticalTextCursor):
(WebCore::waitCursor):
(WebCore::westResizeCursor):
(WebCore::zoomInCursor):
(WebCore::zoomOutCursor):
(WebCore::middlePanningCursor):
(WebCore::eastPanningCursor):
(WebCore::northPanningCursor):
(WebCore::northEastPanningCursor):
(WebCore::northWestPanningCursor):
(WebCore::southPanningCursor):
(WebCore::southEastPanningCursor):
(WebCore::southWestPanningCursor):
(WebCore::westPanningCursor):

  • platform/blackberry/DragDataBlackBerry.cpp: Added.

(WebCore::DragData::canSmartReplace):
(WebCore::DragData::containsColor):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::containsFiles):
(WebCore::DragData::containsPlainText):
(WebCore::DragData::containsURL):
(WebCore::DragData::asFilenames):
(WebCore::DragData::asColor):
(WebCore::DragData::asPlainText):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):

  • platform/blackberry/DragImageBlackBerry.cpp: Added.

(WebCore::createDragImageFromImage):
(WebCore::createDragImageIconForCachedImage):
(WebCore::deleteDragImage):
(WebCore::dissolveDragImageToFraction):
(WebCore::scaleDragImage):
(WebCore::dragImageSize):

  • platform/blackberry/EventLoopBlackBerry.cpp: Added.

(WebCore::EventLoop::platformInit):
(WebCore::EventLoop::cycle):

13:53 Changeset [101935] by kling@webkit.org

Cache CSSInitialValue instances per-document.
<http://webkit.org/b/73745>

Reviewed by Oliver Hunt.

Source/WebCore:

Test: http/tests/security/cross-origin-css-primitive.html

Have CSSValuePool manage the caching of CSSInitialValue objects.

  • css/CSSInitialValue.h:

(WebCore::CSSInitialValue::createExplicit):
(WebCore::CSSInitialValue::createImplicit):
(WebCore::CSSInitialValue::CSSInitialValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFillShorthand):
(WebCore::CSSParser::parseAnimationShorthand):
(WebCore::CSSParser::parseTransitionShorthand):
(WebCore::CSSParser::parseShorthand):

  • css/CSSValuePool.cpp:

(WebCore::CSSValuePool::CSSValuePool):
(WebCore::CSSValuePool::createImplicitInitialValue):
(WebCore::CSSValuePool::createExplicitInitialValue):

  • css/CSSValuePool.h:

LayoutTests:

Test that 'initial' and 'inherit' values are cached per-document.

  • http/tests/security/cross-origin-css-primitive-expected.txt:
  • http/tests/security/cross-origin-css-primitive.html:
  • http/tests/security/resources/cross-origin-css-primitive-iframe.html:
13:45 Changeset [101934] by kling@webkit.org

Keep CSSInheritedValue in the CSS value pool.
<http://webkit.org/b/73747>

Reviewed by Antti Koivisto.

We only need one CSSInheritedValue instance per document, so cache it
in CSSValuePool and have the parser create it through there.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSValuePool.cpp:

(WebCore::CSSValuePool::CSSValuePool):
(WebCore::CSSValuePool::createInheritedValue):

  • css/CSSValuePool.h:
12:06 Changeset [101933] by commit-queue@webkit.org

[GTK] Implement History API FrameLoaderClient methods
https://bugs.webkit.org/show_bug.cgi?id=59017

Patch by Xan Lopez <xlopez@igalia.com> on 2011-12-03
Reviewed by Gustavo Noronha Silva.

Fake the load process when the new HTML5 History APIs are
used. Otherwise the UA does not have a chance of updating the URL
entry, back/forward buttons, etc.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDidNavigateWithinPage): fake a
load process.
(WebKit::FrameLoaderClient::dispatchDidPushStateWithinPage): call
dispatchDidNavigateWithinPage.
(WebKit::FrameLoaderClient::dispatchDidReplaceStateWithinPage):
ditto.
(WebKit::FrameLoaderClient::dispatchDidPopStateWithinPage): do
nothing, because push was already called, but note this in a
comment.

  • WebCoreSupport/FrameLoaderClientGtk.h: add the new method.
10:19 Changeset [101932] by kling@webkit.org

Rename CSSPrimitiveValueCache to CSSValuePool.
<http://webkit.org/b/73742>

Reviewed by Antti Koivisto.

CSSPrimitiveValueCache -> CSSValuePool
Document::primitiveValueCache() -> Document::cssValuePool()

This is in preparation for sharing more than just primitive values.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGeneratorV8.pm:

(AddIncludesForType):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForNinePieceImageSlice):
(WebCore::valueForNinePieceImageQuad):
(WebCore::valueForNinePieceImageRepeat):
(WebCore::valueForNinePieceImage):
(WebCore::zoomAdjustedPixelValue):
(WebCore::zoomAdjustedNumberValue):
(WebCore::zoomAdjustedPixelValueForLength):
(WebCore::valueForReflection):
(WebCore::getPositionOffsetValue):
(WebCore::CSSComputedStyleDeclaration::currentColorOrValidColor):
(WebCore::getBorderRadiusCornerValue):
(WebCore::computedTransform):
(WebCore::CSSComputedStyleDeclaration::valueForFilter):
(WebCore::valueForGridTrackList):
(WebCore::getDelayValue):
(WebCore::getDurationValue):
(WebCore::createLineBoxContainValue):
(WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyword):
(WebCore::CSSComputedStyleDeclaration::valueForShadow):
(WebCore::valueForFamily):
(WebCore::renderTextDecorationFlagsToCSSValue):
(WebCore::fillRepeatToCSSValue):
(WebCore::fillSizeToCSSValue):
(WebCore::contentToCSSValue):
(WebCore::counterToCSSValue):
(WebCore::fontFamilyFromStyle):
(WebCore::lineHeightFromStyle):
(WebCore::fontSizeFromStyle):
(WebCore::fontStyleFromStyle):
(WebCore::fontVariantFromStyle):
(WebCore::fontWeightFromStyle):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::parseColorValue):
(WebCore::parseSimpleLengthValue):
(WebCore::CSSParser::setStyleSheet):
(WebCore::CSSParser::createPrimitiveNumericValue):
(WebCore::CSSParser::createPrimitiveStringValue):
(WebCore::CSSParser::parseValidPrimitive):
(WebCore::CSSParser::parseValue):
(WebCore::parseBackgroundClip):
(WebCore::CSSParser::parseFillShorthand):
(WebCore::CSSParser::parsePage):
(WebCore::CSSParser::parseSizeParameter):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseAttr):
(WebCore::CSSParser::parseBackgroundColor):
(WebCore::CSSParser::parseFillPositionX):
(WebCore::CSSParser::parseFillPositionY):
(WebCore::CSSParser::parseFillPositionComponent):
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parseFillRepeat):
(WebCore::CSSParser::parseFillSize):
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::parseAnimationDirection):
(WebCore::CSSParser::parseAnimationFillMode):
(WebCore::CSSParser::parseAnimationIterationCount):
(WebCore::CSSParser::parseAnimationName):
(WebCore::CSSParser::parseAnimationPlayState):
(WebCore::CSSParser::parseAnimationProperty):
(WebCore::CSSParser::parseAnimationTimingFunction):
(WebCore::CSSParser::parseGridTrackList):
(WebCore::CSSParser::parseDashboardRegions):
(WebCore::CSSParser::parseCounterContent):
(WebCore::CSSParser::parseShape):
(WebCore::CSSParser::parseWrapShape):
(WebCore::CSSParser::parseFont):
(WebCore::CSSParser::parseFontFamily):
(WebCore::CSSParser::parseFontStyle):
(WebCore::CSSParser::parseFontVariant):
(WebCore::CSSParser::parseFontWeight):
(WebCore::CSSParser::parseColor):
(WebCore::ShadowParseContext::ShadowParseContext):
(WebCore::ShadowParseContext::commitLength):
(WebCore::ShadowParseContext::commitStyle):
(WebCore::CSSParser::parseShadow):
(WebCore::CSSParser::parseReflect):
(WebCore::CSSParser::parseFlex):
(WebCore::BorderImageParseContext::BorderImageParseContext):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseBorderImageRepeat):
(WebCore::BorderImageSliceParseContext::BorderImageSliceParseContext):
(WebCore::BorderImageSliceParseContext::commitNumber):
(WebCore::BorderImageSliceParseContext::commitBorderImageSlice):
(WebCore::CSSParser::parseBorderImageSlice):
(WebCore::BorderImageQuadParseContext::BorderImageQuadParseContext):
(WebCore::BorderImageQuadParseContext::commitNumber):
(WebCore::BorderImageQuadParseContext::commitBorderImageQuad):
(WebCore::CSSParser::parseBorderImageQuad):
(WebCore::CSSParser::parseBorderRadius):
(WebCore::CSSParser::parseAspectRatio):
(WebCore::CSSParser::parseCounter):
(WebCore::parseDeprecatedGradientPoint):
(WebCore::parseDeprecatedGradientColorStop):
(WebCore::CSSParser::parseDeprecatedGradient):
(WebCore::valueFromSideKeyword):
(WebCore::parseGradientColorOrKeyword):
(WebCore::CSSParser::parseLinearGradient):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::parseCrossfade):
(WebCore::CSSParser::parseCustomFilter):
(WebCore::CSSParser::parseFilter):
(WebCore::CSSParser::parseFlowThread):
(WebCore::CSSParser::parseRegionThread):
(WebCore::CSSParser::parseTextEmphasisStyle):
(WebCore::CSSParser::parseFontFeatureSettings):

  • css/CSSParser.h:

(WebCore::CSSParser::cssValuePool):

  • css/CSSValuePool.cpp: Renamed from Source/WebCore/css/CSSPrimitiveValueCache.cpp.

(WebCore::CSSValuePool::CSSValuePool):
(WebCore::CSSValuePool::~CSSValuePool):
(WebCore::CSSValuePool::createIdentifierValue):
(WebCore::CSSValuePool::createColorValue):
(WebCore::CSSValuePool::createValue):

  • css/CSSValuePool.h: Renamed from Source/WebCore/css/CSSPrimitiveValueCache.h.

(WebCore::CSSValuePool::create):
(WebCore::CSSValuePool::createValue):

  • css/mediaControlsGtk.css:

(audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):

  • dom/Document.cpp:

(WebCore::Document::cssValuePool):

  • dom/Document.h:
10:17 Changeset [101931] by philn@webkit.org

Another GTK build fix after r101922.

Rubber-stamped by Martin James Robinson.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::pathToLocalResource): return value needs to
be a URI.

09:23 BuildingGtk edited by mrobinson@webkit.org
(diff)
08:37 Changeset [101930] by mrobinson@webkit.org

Small fix for my previous patch. Do not try to delete a member
of a dictionary that does not exist.

Reviewed by Gustavo Noronha Silva.

  • gtk/run-with-jhbuild:

(install_and_run_jhbuild):

07:55 Changeset [101929] by mrobinson@webkit.org

Fix jhbuild installation for people who have unusual MAKE environment
variables such as 'make -j4' as the jhbuild build does not handle it.

Reviewed by Gustavo Noronha Silva.

  • gtk/run-with-jhbuild:

(install_and_run_jhbuild): Remove any MAKE environment variable before building jhbuild.

07:39 Changeset [101928] by mrobinson@webkit.org

Fix the update-webkitgtk-libs script to properly trigger a jhbuild installation
when run for the first time.

Reviewed by Gustavo Noronha Silva.

  • Scripts/update-webkitgtk-libs: Fix first run.
06:07 Changeset [101927] by philn@webkit.org

Unreviewed, skip new failing tests on GTK.

  • platform/gtk/Skipped: Skip 3 new

http/tests/security/mixedContent failing partly because of bug 73743.

05:55 Changeset [101926] by philn@webkit.org

Unreviewed, GTK build fix after r101922.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::pathToLocalResource): Added sentinel in
g_build_filename call.

05:02 Changeset [101925] by philn@webkit.org

GTK API tests build fix. Run the tests inside jhbuild.

Rubber-stamped by Gustavo Noronha Silva.

  • Scripts/run-gtk-tests:

(TestRunner.init):
(TestRunner.run._error_handler):
(TestRunner):
(TestRunner.run):

04:20 Changeset [101924] by kling@webkit.org

Shrink CSSValueList.
<http://webkit.org/b/73732>

Reviewed by Antti Koivisto.

Packed CSSValueList::m_isSpaceSeparated into the CSSValue bit field
and renamed it to m_isSpaceSeparatedValue, shrinking CSSValueList
by one CPU word.

Also renamed CSSValue::m_isImplicit to m_isImplicitInitialValue
for good measure.

  • css/CSSInitialValue.h:

(WebCore::CSSInitialValue::CSSInitialValue):

  • css/CSSValue.h:

(WebCore::CSSValue::isImplicitInitialValue):
(WebCore::CSSValue::CSSValue):

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::CSSValueList):
(WebCore::CSSValueList::copy):
(WebCore::CSSValueList::customCssText):

  • css/CSSValueList.h:

(WebCore::CSSValueList::isSpaceSeparated):

04:12 Changeset [101923] by mrobinson@webkit.org

Small build fix. Properly specify the path to the locally installed jhbuild.

  • Scripts/update-webkitgtk-libs: Fix jhbuild path.
03:33 Changeset [101922] by commit-queue@webkit.org

[GTK][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
https://bugs.webkit.org/show_bug.cgi?id=67256

Patch by Martin Robinson <mrobinson@igalia.com> on 2011-12-03
Reviewed by Philippe Normand.

Implement LayoutTestController::pathToLocalResource for GTK+. Instead of passing
WEBKIT_TEST_FONTS to the GTK+ test harnesses, pass a more generic WEBKIT_TOP_LEVEL,
which points to the more generic top-level path of the WebKit checkout. This code is
duplicated between WK1 and WK2 harnesses because we do not currently have a way to
share code here.

If WEBKIT_TOP_LEVEL is not provided, we search for the top level based on the binary
location. This will cause the fallback to fail if you build into a non-typical location
or even fake it with a symlink. In this case it's important to use the environment variable.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(getTopLevelPath): Added.
(initializeFonts): Use the new helper to get the font path.

  • DumpRenderTree/gtk/DumpRenderTreeGtk.h: Expose the new helper.
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::pathToLocalResource):Use the new helper to normalize
test paths.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort.setup_environ_for_server):Pass the top-level path of the
checkout instead of passing the font path.

  • WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:

(WTR::getTopLevelPath): Added this helper.
(WTR::inititializeFontConfigSetting): Use the helper to find the font path.

03:26 BuildingGtk edited by kov@webkit.org
(diff)
03:19 BuildingGtk edited by mrobinson@webkit.org
Reorganize things (diff)
03:06 Changeset [101921] by philn@webkit.org

Unreviewed, GTK rebaseline after r101858.

  • platform/gtk/fast/writing-mode/broken-ideograph-small-caps-expected.txt:
02:39 BuildingGtk edited by kov@webkit.org
jhbuild update (diff)
02:29 WebKitGtkLayoutTests edited by kov@webkit.org
Document new jhbuild stuff (diff)
02:26 Changeset [101920] by philn@webkit.org

[GStreamer] Fullscreen controller support for the new WebKit Fullscreen API
https://bugs.webkit.org/show_bug.cgi?id=66968

Reviewed by Martin Robinson.

Source/WebCore:

  • GNUmakefile.am: Don't use the Quicktime fullscreen CSS anymore,

it wasn't suited for GTK in the first place anyway.

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::extraFullScreenStyleSheet): Simply reuse
GTK CSS.

Source/WebKit/gtk:

If the element being fullscreened is a video use the native
fullscreen controls.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::enterFullScreenForElement):
(WebKit::ChromeClient::exitFullScreenForElement):

LayoutTests:

  • platform/gtk/Skipped: Skip

fullscreen/video-controls-override.html now failing because of bug 73583.

01:44 Changeset [101919] by alex@webkit.org

2011-12-03 Alejandro G. Castro <alex@igalia.com>

[GTK] TextureMapperNode should not use Qt types and functions
https://bugs.webkit.org/show_bug.cgi?id=73713

Replace qreal with double and qMin with min.

Reviewed by Noam Rosenthal.

  • platform/graphics/texmap/TextureMapperNode.cpp: (WebCore::solveCubicBezierFunction): (WebCore::solveStepsFunction):
01:36 Changeset [101918] by ossy@webkit.org

[Qt] Unreviewed weekend gardening.

  • platform/qt/Skipped: Skip new failing tests.
  • platform/qt/fast/css/font-face-opentype-expected.png: Updated.
  • platform/qt/fast/css/font-face-opentype-expected.txt: Updated.
01:22 Changeset [101917] by mrobinson@webkit.org

.: [GTK] Update required libsoup version
https://bugs.webkit.org/show_bug.cgi?id=71611

Patch by Dan Winship <danw@gnome.org> on 2011-12-03
Reviewed by Martin Robinson.

  • configure.ac: require libsoup 2.37.2.1 for SoupRequestHTTP API

changes

Source/WebCore: [GTK] Remove lots of code that is now unnecessary after
SoupRequestHTTP API changes.
https://bugs.webkit.org/show_bug.cgi?id=71611

Patch by Dan Winship <danw@gnome.org> on 2011-12-03
Reviewed by Martin Robinson.

No new tests; behavior is unchanged

  • platform/network/ResourceHandleInternal.h:

(WebCore::ResourceHandleInternal::ResourceHandleInternal): remove
no-longer-needed fields.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::finishedCallback): remove this, and m_finished, which
we no longer need to explicitly track
(WebCore::statusWillBeHandledBySoup):
(WebCore::soupErrorShouldCauseLoadFailure): No longer needed;
SoupRequestHTTP's logic is now aligned with WebKit's.
(WebCore::gotChunkCallback): remove gotChunkCallback, which
is no longer needed
(WebCore::startHTTPRequest):
(WebCore::sendRequestCallback):
(WebCore::gotHeadersCallback):
(WebCore::contentSniffedCallback): merge the code from
gotHeadersCallback and contentSniffedCallback into
sendRequestCallback

  • platform/network/soup/ResourceResponseSoup.cpp:

(WebCore::ResourceResponse::updateFromSoupMessage): move the
sniffing override logic here

01:19 Changeset [101916] by mrobinson@webkit.org

[GTK] [EFL] Update some cookie-related tests
https://bugs.webkit.org/show_bug.cgi?id=73673

Patch by Dan Winship <danw@gnome.org> on 2011-12-03
Reviewed by Martin Robinson.

  • platform/efl/http/tests/cookies/double-quoted-value-with-semi-colon-expected.txt:
  • platform/gtk/http/tests/cookies/double-quoted-value-with-semi-colon-expected.txt:

Copied from platform/chromium because libsoup also follows the RFC
6265 behavior.

  • platform/efl/Skipped:
  • platform/gtk/Skipped: Unskip that, and another cookie test that

has been fixed for a while.

01:06 Changeset [101915] by ossy@webkit.org

Unreviewed, rolling out r101904.
http://trac.webkit.org/changeset/101904
https://bugs.webkit.org/show_bug.cgi?id=73739

It broke zillions of tests on all bot (Requested by
Ossy_weekend on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-03

Source/WebCore:

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::handlePostMessage):

LayoutTests:

  • fast/dom/Window/window-postmessage-args-expected.txt:

12/02/11:

23:22 Changeset [101914] by haraken@chromium.org

[Refactoring] Use join(", ", @arguments) to build a method argument string in CodeGenerator*.pm
https://bugs.webkit.org/show_bug.cgi?id=73651

Reviewed by Darin Adler.

The code in CodeGenerator*.pm to build a method argument string is really dirty
and error-prone. It is building an argument string incrementally judging whether
", " is necessary or not, like this:

my $method = ... ? "func(" : "func(a";
if (...) {

$method .= $method =~ /\($/ ? "b" : ", b";

}
$method .= ")";

Alternatively, we can refactor the code as follows:

my $funcName = "func";
my @arguments;
push(@arguments, "a") if (...);
push(@arguments, "b") if (...);
my $method = $funcName . "(" . join(", ", @arguments) . ")";

This patch just refactors the code, and generated .h and .cpp files should be
exactly the same as the current .h and .cpp files.

Tests: bindings/scripts/test/*

  • bindings/scripts/CodeGenerator.pm:

(GetterExpression):
(SetterExpression):

  • bindings/scripts/CodeGeneratorCPP.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorGObject.pm:

():

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorObjC.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):

23:06 Changeset [101913] by levin@chromium.org

Rename WTF class from TemporarilyChange to TemporaryChange.
https://bugs.webkit.org/show_bug.cgi?id=73479

Reviewed by Eric Seidel.

Source/JavaScriptCore:

(WTF::TemporaryChange::TemporaryChange):
(WTF::TemporaryChange::~TemporaryChange):

Source/JavaScriptGlue:

  • ForwardingHeaders/wtf/TemporarilyChange.h: Removed.
  • ForwardingHeaders/wtf/TemporaryChange.h: Added.

Source/WebCore:

  • ForwardingHeaders/wtf/TemporarilyChange.h: Removed.
  • ForwardingHeaders/wtf/TemporaryChange.h: Added.
  • page/FrameView.cpp:

(WebCore::FrameView::forceLayoutParentViewIfNeeded):
(WebCore::FrameView::layout):
(WebCore::FrameView::setScrollPosition):
(WebCore::FrameView::autoSizeIfEnabled):

Source/WebKit/mac:

  • ForwardingHeaders/wtf/TemporarilyChange.h: Removed.
  • ForwardingHeaders/wtf/TemporaryChange.h: Added.

Tools:

  • DumpRenderTree/ForwardingHeaders/wtf/TemporarilyChange.h: Removed.
  • DumpRenderTree/ForwardingHeaders/wtf/TemporaryChange.h: Added.
  • TestWebKitAPI/TestWebKitAPI.gypi:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/TemporaryChange.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/TemporarilyChange.cpp.

(TestWebKitAPI::TEST):

  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
22:56 Changeset [101912] by scheib@chromium.org

Unreviewed, rolling out r101906.
http://trac.webkit.org/changeset/101906
https://bugs.webkit.org/show_bug.cgi?id=73736

Failing chromium webkit_unit_tests (Requested by scheib on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-02

  • WebKit.gypi:
  • tests/DispatchEventTest.cpp: Removed.
  • tests/data/event_target.html: Removed.
22:47 Changeset [101911] by commit-queue@webkit.org

ASSERT fails in updateState ACTION_DRAW case
https://bugs.webkit.org/show_bug.cgi?id=73351

Patch by Armand Navabi <armand.navabi@gmail.com> on 2011-12-02
Reviewed by James Robinson.

Changed ASSERT in CCSchedulerStateMachine to include (
!m_visible) as discussed in bug

report. m_commitState is set to COMMIT_STATE_WAITING_FOR_FIRST_DRAW if m_needsCommit or
!m_visible, so in ACTION_DRAW the assert should have both conditions.

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::updateState):

22:31 Changeset [101910] by mhahnenberg@apple.com

REGRESSION (r99754): All layout tests crash on Windows
https://bugs.webkit.org/show_bug.cgi?id=72305

Reviewed by Geoffrey Garen.

Fixes a crash in release builds on Windows. Windows was optimizing the out-of-line virtual destructor in
JSFunction away, which left it with no virtual functions. Its vtable ptr was then identical to that of
a different class, therefore the optimization in the visitChildren helper function in MarkedStack.cpp was calling an
incorrect version of visitChildren on the object, which left its children unmarked, causing them to be
collected when they were still reachable.

  • runtime/JSFunction.cpp:

(JSC::JSFunction::vtableAnchor): Add a virtual function to JSFunction that Visual Studio can't optimize away.

  • runtime/JSFunction.h:
  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::storeVPtrs): Add checks to make sure that all virtual pointers that we rely on for optimization
purposes are distinct from one another.

22:21 Changeset [101909] by tony@chromium.org

remove a stale comment in flexbox code
https://bugs.webkit.org/show_bug.cgi?id=73720

Reviewed by Ojan Vafai.

This was fixed by Ojan in https://bugs.webkit.org/show_bug.cgi?id=70754.

  • css3/flexbox/flex-flow-padding.html:
22:14 Changeset [101908] by commit-queue@webkit.org

[chromium] Scissor rect optimization for chromium compositor
https://bugs.webkit.org/show_bug.cgi?id=67341

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-12-02
Reviewed by James Robinson.

Mostly covered by damage tracker tests. Currently this relies on
manually running layout tests, because this patch requires partial
swaps that are not supported by DumpRenderTree. The feature
automatically disables if partial swap is not supported.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::trackDamageForAllSurfaces):
(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::swapBuffers):
(WebCore::LayerRendererChromium::drawLayer):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):
(WebCore::LayerRendererCapabilities::LayerRendererCapabilities):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::draw):

  • platform/graphics/chromium/cc/CCRenderSurface.h:
22:06 Changeset [101907] by tony@chromium.org

[NRWT] reftest asserts intermittently on the Qt-WK2 bot
https://bugs.webkit.org/show_bug.cgi?id=73453

Reviewed by Ryosuke Niwa.

We used to assert if a ref test didn't generate pixel results. Instead, just claim it is a failing test.
The verbose output will include the failure reason.

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Don't assert, return FailureReftestNoImagesGenerated instead.
  • Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(write_test_result):

  • Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py: Remove stray letter t.
  • Scripts/webkitpy/layout_tests/models/test_failures.py: Add a new failure type: FailureReftestNoImagesGenerated

(determine_result_type):
(FailureReftestNoImagesGenerated.init):
(FailureReftestNoImagesGenerated):
(FailureReftestNoImagesGenerated.message):

  • Scripts/webkitpy/layout_tests/port/test.py: Add a test case for integration tests.
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Update test counts.

(MainTest.test_run_singly_actually_runs_tests):
(MainTest.test_unexpected_failures):
(EndToEndTest.test_end_to_end):

21:56 Changeset [101906] by commit-queue@webkit.org

Add a unit test for creating, listening for, and dispatching events
via the chromium API.
https://bugs.webkit.org/show_bug.cgi?id=72988

Patch by Dave Michael <dmichael@chromium.org> on 2011-12-02
Reviewed by Darin Fisher.

  • WebKit.gypi:
  • tests/DispatchEventTest.cpp: Added.

(WebKit::MockListener::MockListener):
(WebKit::MockListener::~MockListener):
(WebKit::MockListener::events):
(WebKit::DispatchEventTest::DispatchEventTest):
(WebKit::DispatchEventTest::TearDown):
(WebKit::TEST_F):

21:51 Changeset [101905] by japhet@chromium.org

Don't call FocusController:setActive() in
WebViewImpl::setFocus(), since being active and
being focused are different concepts and chromium
now properly sends setActive IPCs on all platforms.
https://bugs.webkit.org/show_bug.cgi?id=73687

Reviewed by Eric Seidel.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setFocus):

  • tests/WebViewTest.cpp: Test how different combinations of

setIsActive() and setFocus() affect whether the document
has focus.

21:40 Changeset [101904] by dslomov@google.com

https://bugs.webkit.org/show_bug.cgi?id=73691
[JSC] Implement correct order of window.postMessage arguments.

Reviewed by Geoffrey Garen.

Source/WebCore:

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::handlePostMessage):

LayoutTests:

  • fast/dom/Window/window-postmessage-args-expected.txt:
21:34 Changeset [101903] by commit-queue@webkit.org

REGRESSION (r91125): Polyline tool in google docs is broken
https://bugs.webkit.org/show_bug.cgi?id=65796

Source/WebCore:

Patch by Stephen Chenney <schenney@chromium.org> on 2011-12-02
Reviewed by Darin Adler.

Work around a bug in CoreGraphics, that caused incorrect bounds for paths
consisting only of move-to elements. This causes problems in SVG, when the enormous
bounds prevented the drawing of things behind.

Tests: svg/custom/path-moveto-only-rendering.svg

svg/custom/subpaths-moveto-only-rendering.svg

  • platform/graphics/cg/PathCG.cpp:

(WebCore::PathIsEmptyOrSingleMoveTester::PathIsEmptyOrSingleMoveTester): Class to
test for isEmpty accoridng ot the same rules as other platforms.
(WebCore::PathIsEmptyOrSingleMoveTester::isEmpty): Query the result
(WebCore::PathIsEmptyOrSingleMoveTester::testPathElement): Path iterator method
(WebCore::PathHasOnlyMoveToTester::PathHasOnlyMoveToTester): Class to test whether a
path contains only move-to elements, and hence should have null bounds.
(WebCore::PathHasOnlyMoveToTester::hasOnlyMoveTo): Query the result
(WebCore::PathHasOnlyMoveToTester::testPathElement): Path iterator method.
(WebCore::Path::boundingRect): Modified to check for move-to only paths
(WebCore::Path::fastBoundingRect): Modified to check for move-to only paths
(WebCore::Path::isEmpty): Now uses the method that matches other platforms.
(WebCore::Path::hasCurrentPoint): Now uses CGPathIsEmpty directly
(WebCore::Path::transform) : Now uses CGPathIsEmpty directly

LayoutTests:

Work around a bug in CoreGraphics, that caused incorrect bounds for paths
consisting only of move-to elements. This causes problems in SVG, when the enormous
bounds prevented the drawing of things behind.

Will revert expectation file when expectations are stable.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-12-02
Reviewed by Darin Adler.

  • platform/chromium-mac/svg/custom/zero-path-square-cap-rendering2-expected.txt: Removed.
  • platform/chromium-win/svg/custom/zero-path-square-cap-rendering2-expected.txt: Removed.
  • platform/mac/svg/custom/path-moveto-only-rendering-expected.png: Added.
  • platform/mac/svg/custom/path-moveto-only-rendering-expected.txt: Added.
  • platform/mac/svg/custom/subpaths-moveto-only-rendering-expected.png: Added.
  • platform/mac/svg/custom/subpaths-moveto-only-rendering-expected.txt: Added.
  • svg/custom/path-moveto-only-rendering.svg: Added.
  • svg/custom/subpaths-moveto-only-rendering.svg: Added.
  • svg/custom/zero-path-square-cap-rendering2-expected.txt: Modified text output
  • platform/chromium/test_expectations.txt: Added flakiness for new tests from this patch
21:26 Changeset [101902] by commit-queue@webkit.org

[Qt] [WK2] MiniBrowser --touch asserts in debug build
https://bugs.webkit.org/show_bug.cgi?id=73697

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-12-02
Reviewed by Eric Seidel.

Add missing guard to QtViewportInteractionEngine::itemSizeChanged().

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::itemSizeChanged):

20:59 Changeset [101901] by rniwa@webkit.org

ChangeLog should be able to parse annotated changelogs
https://bugs.webkit.org/show_bug.cgi?id=72703

Reviewed by Eric Seidel.

Make parse_entries_from_file aware of svn blame annotation such as "100000 ossy@webkit.org ",
and extract the revision number for each entry.

Also add a support to extract "svn blame" result from svn/git checkout to scm classes.

  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
  • Scripts/webkitpy/common/checkout/scm/git.py:
  • Scripts/webkitpy/common/checkout/scm/scm.py:
  • Scripts/webkitpy/common/checkout/scm/svn.py:
20:54 Changeset [101900] by scheib@chromium.org

[Chromium] test_expectations typo fix for chunked-progress-event-expectedLength.html

  • platform/chromium/test_expectations.txt:
20:46 Changeset [101899] by mihnea@adobe.com

[CSSRegions]More renaming for region style rules.
https://bugs.webkit.org/show_bug.cgi?id=73526

Reviewed by Eric Seidel.

Source/WebCore:

Rename isRegionStyleRule() -> isRegionRule()
WEBKIT_REGION_STYLE_RULE -> WEBKIT_REGION_RULE.

  • bindings/objc/DOMCSS.mm:

(kitClass):

  • bindings/v8/custom/V8CSSRuleCustom.cpp:

(WebCore::toV8):

  • css/CSSGrammar.y:
  • css/CSSParser.cpp:

(WebCore::CSSParser::createRegionRule):

  • css/CSSParser.h:
  • css/CSSRule.cpp:

(WebCore::CSSRule::cssText):
(WebCore::CSSRule::destroy):

  • css/CSSRule.h:

(WebCore::CSSRule::isRegionRule):

  • css/CSSRule.idl:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::addRegionRule):
(WebCore::RuleSet::addRulesFromSheet):

  • css/CSSStyleSelector.h:
  • css/WebKitCSSRegionRule.cpp:

(WebCore::WebKitCSSRegionRule::WebKitCSSRegionRule):

  • css/tokenizer.flex:

LayoutTests:

Rename WEBKIT_REGION_STYLE_RULE -> WEBKIT_REGION_RULE.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/regions/parsing-region-style-rule.html:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/win/fast/dom/Window/window-properties-expected.txt:
20:06 Changeset [101898] by tsepez@chromium.org

XSSAuditor includes more terminating characters when truncating
attribute values.
https://bugs.webkit.org/show_bug.cgi?id=73684

Reviewed by Daniel Bates.

Source/WebCore:

  • html/parser/XSSAuditor.cpp:

(WebCore::isTerminatingCharacter):
(WebCore::XSSAuditor::eraseDangerousAttributesIfInjected):

LayoutTests:

  • http/tests/security/xssAuditor/property-escape-comment-expected.txt:
  • http/tests/security/xssAuditor/property-escape-comment.html:
19:50 Changeset [101897] by tony@chromium.org

Need to implement flex-flow: column-reverse
https://bugs.webkit.org/show_bug.cgi?id=73504

Reviewed by David Hyatt.

Source/WebCore:

We can't just change the direction of the FlexOrderIterator because we want the overflow to be
on the top. We can't just position them in the reverse location since we don't know where the
bottom edge is until we've layed out the flex items. So we do an extra pass, but it should be
fast since we're not laying out, just moving.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::flowAwareBorderEnd):
(WebCore::RenderFlexibleBox::flowAwarePaddingEnd):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::layoutColumnReverse): Do an extra pass to reposition flexitems in the reverse order.

  • rendering/RenderFlexibleBox.h:

LayoutTests:

Enable testing of column-reverse.

  • css3/flexbox/flex-flow-expected.txt:
  • css3/flexbox/flex-flow.html: Added test cases to make sure start and end still apply to the text flow direction.
  • css3/flexbox/flex-flow-border-expected.txt:
  • css3/flexbox/flex-flow-border.html: Single flexitem, so reverse does nothing.
  • css3/flexbox/flex-flow-margins-auto-size-expected.txt:
  • css3/flexbox/flex-flow-margins-auto-size.html: Ditto. The vertical tests cases (orthogonal directions) have always failed.
  • css3/flexbox/flex-flow-margins-expected.txt:
  • css3/flexbox/flex-flow-margins.html: Ditto.
  • css3/flexbox/flex-flow-orientations-expected.txt:
  • css3/flexbox/flex-flow-orientations.html: This test has 2 flexitems, the positions of which are now flipped.
  • css3/flexbox/flex-flow-overflow-expected.txt:
  • css3/flexbox/flex-flow-overflow.html: The overflow should go in the opposite direction vertically, but the same direction horizontally.
  • css3/flexbox/flex-flow-padding-expected.txt:
  • css3/flexbox/flex-flow-padding.html: Single flexitem, no change.
19:13 Changeset [101896] by commit-queue@webkit.org

Add WebArrayBuffer to chromium API
https://bugs.webkit.org/show_bug.cgi?id=73593

Patch by Dave Michael <dmichael@chromium.org> on 2011-12-02
Reviewed by Darin Fisher.

  • WebKit.gyp:
  • public/WebArrayBuffer.h: Added.

(WebKit::WebArrayBuffer::~WebArrayBuffer):
(WebKit::WebArrayBuffer::WebArrayBuffer):
(WebKit::WebArrayBuffer::operator=):
(WebKit::WebArrayBuffer::isNull):

  • public/WebBindings.h:
  • src/WebArrayBuffer.cpp: Added.

(WebKit::WebArrayBuffer::create):
(WebKit::WebArrayBuffer::reset):
(WebKit::WebArrayBuffer::assign):
(WebKit::WebArrayBuffer::data):
(WebKit::WebArrayBuffer::byteLength):
(WebKit::WebArrayBuffer::toV8Value):
(WebKit::WebArrayBuffer::WebArrayBuffer):
(WebKit::WebArrayBuffer::operator=):
(WebKit::WebArrayBuffer::operator WTF::PassRefPtr<WTF::ArrayBuffer>):

  • src/WebBindings.cpp:

(WebKit::getArrayBufferImpl):
(WebKit::WebBindings::getArrayBuffer):

19:12 Changeset [101895] by commit-queue@webkit.org

Divide by zero for zero-length arcs
https://bugs.webkit.org/show_bug.cgi?id=73021

Source/WebCore:

Patch by Stephen Chenney <schenney@chromium.org> on 2011-12-02
Reviewed by Nikolas Zimmermann.

A zero-length path produces divide by zero, resulting in nothing being
drawn. This change modifies the behavior to produce a zero-length line
which will generate correct linecaps.

Test: svg/stroke/zero-length-arc-linecaps-rendering.svg

  • svg/SVGPathParser.cpp:

(WebCore::SVGPathParser::parseArcToSegment): Catch the case of
zero-length arcs and convert them to lines (the same as would happen
for zero arc radii).

LayoutTests:

A zero-length path produces divide by zero, resulting in nothing being
drawn. This change modifies the behavior to produce a zero-length line
which will generate correct linecaps.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-12-02
Reviewed by Nikolas Zimmermann.

  • platform/chromium/test_expectations.txt: Added flakiness for the new test until wehave expectations.
  • platform/mac/svg/stroke: Added.
  • platform/mac/svg/stroke/zero-length-arc-linecaps-rendering-expected.png: Added.
  • platform/mac/svg/stroke/zero-length-arc-linecaps-rendering-expected.txt: Added.
  • svg/stroke/zero-length-arc-linecaps-rendering.svg: Added.
18:43 Changeset [101894] by commit-queue@webkit.org

-Implement the SSE optimization for vsmul and vadd.
https://bugs.webkit.org/show_bug.cgi?id=73182

Patch by James Wei <james.wei@intel.com> & Xingnan Wang <xingnan.wang@intel.com> on 2011-12-02
Reviewed by Kenneth Russell.

  • platform/audio/VectorMath.cpp:

(WebCore:VectorMath):

18:34 Changeset [101893] by lforschler@apple.com

Versioning.

18:29 Changeset [101892] by lforschler@apple.com

New tag.

18:25 Changeset [101891] by lforschler@apple.com

Versioning.

18:20 Changeset [101890] by dgrogan@chromium.org

Grant workers experimental access to IndexedDB.
https://bugs.webkit.org/show_bug.cgi?id=73609

Reviewed by Nate Chapin.

Source/WebCore:

No new tests - there will be chromium ui tests that depend on
webkit.org/b/73297.

  • storage/IDBFactory.cpp:

(WebCore::IDBFactory::open): Call new function,
IDBFactoryBackendInterface::openFromWorker.

  • storage/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::open):
(WebCore::IDBFactoryBackendImpl::openFromWorker):
(WebCore::IDBFactoryBackendImpl::openInternal):

  • storage/IDBFactoryBackendImpl.h:
  • storage/IDBFactoryBackendInterface.h:
  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::webkitIndexedDB): Stores
IDBFactoryBackendInterface, implemented by IDBFactoryBackendProxy in
chromium, in the WorkerContext. For the Document case it is stored in
the PageGroup. Storing it in the WorkerContext causes more memory
churn, but that should be trivial. I don't know of any better
alternatives.

  • workers/WorkerContext.h:
  • workers/WorkerContext.idl:

Source/WebKit/chromium:

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::allowIDBFromWorkerThread): Return
true while behind a runtime flag, and while we figure out how to check
permission in a thread-safe manner.
(WebKit::IDBFactoryBackendProxy::openFromWorker): Using the webFrame
from the worker seems to satisfy the weak condition in chromium that
neither it nor it's associated RenderView is NULL.

  • src/IDBFactoryBackendProxy.h:
18:12 Changeset [101889] by lforschler@apple.com

Versioning.

18:07 Changeset [101888] by lforschler@apple.com

New Tag.

17:59 Changeset [101887] by commit-queue@webkit.org

[EFL] Remove entry pointer before freeing it from matrix.
https://bugs.webkit.org/show_bug.cgi?id=73625

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2011-12-02
Reviewed by Ryosuke Niwa.

To prevent leaving dangling pointer on the matrix, remove the entry before freeing it.

  • ewk/ewk_tiled_matrix.cpp:

(ewk_tile_matrix_free):

17:47 Changeset [101886] by oliver@apple.com

Improve float array support in the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=73722

Reviewed by Gavin Barraclough.

Add basic support for float typed arrays in JSC. This is currently
less optimal than it could be in the following ways:

  • float32Array1[0] = float32Array2[0] (eg. an element by element copy) promotes float to double and then back to float.
  • float64Array[0] will always perform NaN tests in order to prevent signalling NaNs from entering the engine.

We also don't support Float32Array on ARMv7

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::loadDouble):
(JSC::MacroAssemblerARMv7::loadFloat):
(JSC::MacroAssemblerARMv7::storeDouble):
(JSC::MacroAssemblerARMv7::storeFloat):
(JSC::MacroAssemblerARMv7::convertFloatToDouble):
(JSC::MacroAssemblerARMv7::convertDoubleToFloat):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::loadDouble):
(JSC::MacroAssemblerX86Common::loadFloat):
(JSC::MacroAssemblerX86Common::storeDouble):
(JSC::MacroAssemblerX86Common::storeFloat):
(JSC::MacroAssemblerX86Common::convertDoubleToFloat):
(JSC::MacroAssemblerX86Common::convertFloatToDouble):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::cvtsd2ss_rr):
(JSC::X86Assembler::cvtss2sd_rr):
(JSC::X86Assembler::movsd_rm):
(JSC::X86Assembler::movss_rm):
(JSC::X86Assembler::movsd_mr):
(JSC::X86Assembler::movss_mr):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGNode.h:

(JSC::DFG::Node::shouldSpeculateFloat32Array):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::compile):

17:42 Changeset [101885] by jamesr@google.com

[chromium] Move WebLayer APIs to platform directory
https://bugs.webkit.org/show_bug.cgi?id=73610

Reviewed by Darin Fisher.

  • public/WebContentLayer.h:
  • public/WebContentLayerClient.h:
  • public/WebExternalTextureLayer.h:
  • public/WebLayer.h:
  • public/WebLayerClient.h:
  • public/WebLayerTreeView.h:
  • public/WebLayerTreeViewClient.h:
  • public/platform/WebContentLayer.h: Copied from Source/WebKit/chromium/public/WebContentLayer.h.

(WebKit::WebContentLayer::WebContentLayer):
(WebKit::WebContentLayer::~WebContentLayer):
(WebKit::WebContentLayer::operator=):

  • public/platform/WebContentLayerClient.h: Copied from Source/WebKit/chromium/public/WebContentLayerClient.h.

(WebKit::WebContentLayerClient::~WebContentLayerClient):

  • public/platform/WebExternalTextureLayer.h: Copied from Source/WebKit/chromium/public/WebExternalTextureLayer.h.

(WebKit::WebExternalTextureLayer::WebExternalTextureLayer):
(WebKit::WebExternalTextureLayer::~WebExternalTextureLayer):
(WebKit::WebExternalTextureLayer::operator=):

  • public/platform/WebLayer.h: Copied from Source/WebKit/chromium/public/WebLayer.h.

(WebKit::WebLayer::WebLayer):
(WebKit::WebLayer::~WebLayer):
(WebKit::WebLayer::operator=):
(WebKit::WebLayer::isNull):
(WebKit::WebLayer::to):
(WebKit::WebLayer::toConst):
(WebKit::WebLayer::unwrap):
(WebKit::WebLayer::constUnwrap):
(WebKit::operator==):
(WebKit::operator!=):

  • public/platform/WebLayerClient.h: Copied from Source/WebKit/chromium/public/WebLayerClient.h.

(WebKit::WebLayerClient::~WebLayerClient):

  • public/platform/WebLayerTreeView.h: Copied from Source/WebKit/chromium/public/WebLayerTreeView.h.

(WebKit::WebLayerTreeView::Settings::Settings):
(WebKit::WebLayerTreeView::WebLayerTreeView):
(WebKit::WebLayerTreeView::~WebLayerTreeView):
(WebKit::WebLayerTreeView::operator=):
(WebKit::operator==):
(WebKit::operator!=):

  • public/platform/WebLayerTreeViewClient.h: Copied from Source/WebKit/chromium/public/WebLayerTreeViewClient.h.

(WebKit::WebLayerTreeViewClient::~WebLayerTreeViewClient):

  • public/platform/WebPrivatePtr.h:
  • src/WebContentLayer.cpp:
  • src/WebContentLayerImpl.cpp:
  • src/WebExternalTextureLayer.cpp:
  • src/WebExternalTextureLayerImpl.cpp:
  • src/WebLayer.cpp:
  • src/WebLayerImpl.cpp:
  • src/WebLayerTreeView.cpp:
  • src/WebLayerTreeViewImpl.h:
17:42 Changeset [101884] by lforschler@apple.com

Merged r90959.

17:38 Changeset [101883] by commit-queue@webkit.org

Source/WebCore: Fix mixed content handling for video in Chromium by having
CachedResourceLoader & SubresourceLoader use the
ResourceRequest::TargetType when determining if a RawResource can
be requested.
https://bugs.webkit.org/show_bug.cgi?id=72178

Patch by Aaron Colwell <acolwell@chromium.org> on 2011-12-02
Reviewed by Adam Barth.

Tests: http/tests/security/mixedContent/insecure-video-in-iframe.html

http/tests/security/mixedContent/insecure-video-in-main-frame.html
http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame.html
http/tests/security/mixedContent/redirect-https-to-http-video-in-main-frame.html

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequest):

  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::CachedRawResource):

  • loader/cache/CachedRawResource.h:
  • loader/cache/CachedResource.cpp:

(WebCore::defaultPriorityForResourceType):
(WebCore::cachedResourceTypeToTargetType):
(WebCore::CachedResource::targetTypeToCachedResourceType):

  • loader/cache/CachedResource.h:
  • loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource):
(WebCore::CachedResourceLoader::checkInsecureContent):
(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::requestResource):

LayoutTests: Adding mixed content tests for video tag.
https://bugs.webkit.org/show_bug.cgi?id=72178

Patch by Aaron Colwell <acolwell@chromium.org> on 2011-12-02
Reviewed by Adam Barth.

  • http/tests/security/mixedContent/insecure-video-in-iframe-expected.txt: Added.
  • http/tests/security/mixedContent/insecure-video-in-iframe.html: Added.
  • http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Added.
  • http/tests/security/mixedContent/insecure-video-in-main-frame.html: Added.
  • http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Added.
  • http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame.html: Added.
  • http/tests/security/mixedContent/redirect-https-to-http-video-in-main-frame-expected.txt: Added.
  • http/tests/security/mixedContent/redirect-https-to-http-video-in-main-frame.html: Added.
  • http/tests/security/mixedContent/resources/frame-with-insecure-video.html: Added.
  • http/tests/security/mixedContent/resources/frame-with-redirect-http-to-https-video.html: Added.
  • http/tests/security/mixedContent/resources/frame-with-redirect-https-to-http-video.html: Added.
17:35 Changeset [101882] by scheib@chromium.org

[Chromium] Rebaselining svg/custom/svg-fonts-word-spacing.html

  • platform/chromium-cg-mac-snowleopard/accessibility/aria-checkbox-sends-notification-expected.txt: Copied from LayoutTests/platform/chromium/accessibility/aria-checkbox-sends-notification-expected.txt.
  • platform/chromium-mac-snowleopard/accessibility/aria-checkbox-sends-notification-expected.txt: Copied from LayoutTests/platform/chromium/accessibility/aria-checkbox-sends-notification-expected.txt.
  • platform/chromium-win/accessibility/aria-checkbox-sends-notification-expected.txt: Renamed from LayoutTests/platform/chromium/accessibility/aria-checkbox-sends-notification-expected.txt.
17:28 Changeset [101881] by scheib@chromium.org

[Chromium] Marking svg/W3C-SVG-1.1/fonts-elem-04-b.svg flaky for image+text

  • platform/chromium/test_expectations.txt:
17:04 Changeset [101880] by eric@webkit.org

Enable parallel testing for Win and Gtk bots
after confirming with Lucas and Martin the bots should be OK.

Unreviewed. (I ran the idea by Lucas and Martin.)

  • Scripts/run-webkit-tests:

(platformIsReadyForParallelTesting):

16:53 Changeset [101879] by commit-queue@webkit.org

[chromium] add setOpener method to WebFrame
https://bugs.webkit.org/show_bug.cgi?id=73379

Patch by Karl Koscher <supersat@chromium.org> on 2011-12-02
Reviewed by Darin Fisher.

  • public/WebFrame.h:

(WebKit::WebFrame::clearOpener): now an inline call to setOpener(0)

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::setOpener): sets window.opener

  • src/WebFrameImpl.h:
16:41 Changeset [101878] by lforschler@apple.com

Merge 93445.

16:21 Changeset [101877] by lforschler@apple.com

Merge 93377.

16:13 Changeset [101876] by dcheng@chromium.org

Unreviewed, rolling out r101731.
http://trac.webkit.org/changeset/101731
https://bugs.webkit.org/show_bug.cgi?id=73706

Broke copy and paste in chromium. (Requested by dcheng on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-02

Source/WebCore:

  • editing/SpellChecker.cpp:

(WebCore::SpellChecker::SpellChecker):
(WebCore::SpellChecker::initRequest):
(WebCore::SpellChecker::clearRequest):
(WebCore::SpellChecker::canCheckAsynchronously):
(WebCore::SpellChecker::isBusy):
(WebCore::SpellChecker::isValid):
(WebCore::SpellChecker::requestCheckingFor):
(WebCore::SpellChecker::doRequestCheckingFor):
(WebCore::SpellChecker::didCheck):

  • editing/SpellChecker.h:

LayoutTests:

  • editing/spelling/spellcheck-queue-expected.txt: Removed.
  • editing/spelling/spellcheck-queue.html: Removed.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
16:04 Changeset [101875] by fsamuel@chromium.org

When page scaling is in use position:fixed has incorrect results
https://bugs.webkit.org/show_bug.cgi?id=68617

Reviewed by Simon Fraser.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

Add the option for position:fixed elements to be fixed to the frame
instead of the layout rectangle of the document.

Tests: fast/repaint/fixed-in-page-scale.html

fast/repaint/fixed-right-bottom-in-page-scale.html
fast/repaint/fixed-right-in-page-scale.html

  • WebCore.exp.in:
  • page/FrameView.cpp:

(WebCore::FrameView::reset):
(WebCore::FrameView::scrollXForFixedPosition):
(WebCore::FrameView::scrollYForFixedPosition):

If position:fixed elements are relative to the frame, disregard the
drag factor.

(WebCore::FrameView::setShouldLayoutFixedElementsRelativeToFrame):

  • page/FrameView.h:

(WebCore::FrameView::shouldLayoutFixedElementsRelativeToFrame):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::shouldLayoutFixedElementRelativeToFrame):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):

If position:fixed elements are relative to the frame, their container
is the frame instead of the layout rect of the document.
This allows proper positioning of these elements to the right and
bottom.

  • rendering/RenderBox.h:
  • testing/Internals.cpp:

(WebCore::Internals::setShouldLayoutFixedElementsRelativeToFrame):

  • testing/Internals.h:
  • testing/Internals.idl: Allow enabling and disabling the new behavior in layout tests.

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

  • fast/repaint/fixed-in-page-scale-expected.png: Added.
  • fast/repaint/fixed-in-page-scale-expected.txt: Added.
  • fast/repaint/fixed-in-page-scale.html: Added.
  • fast/repaint/fixed-right-bottom-in-page-scale-expected.png: Added.
  • fast/repaint/fixed-right-bottom-in-page-scale-expected.txt: Added.
  • fast/repaint/fixed-right-bottom-in-page-scale.html: Added.
  • fast/repaint/fixed-right-in-page-scale-expected.png: Added.
  • fast/repaint/fixed-right-in-page-scale-expected.txt: Added.
  • fast/repaint/fixed-right-in-page-scale.html: Added.
15:55 Changeset [101874] by benjamin@webkit.org

Build fix for SubresourceLoader when building with Core Foundation
https://bugs.webkit.org/show_bug.cgi?id=73709

Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-12-02
Reviewed by David Kilzer.

The patch r100311 removed SubresourceClient and merged it in SubresourceLoader.
Consequently, m_client does not exist anymore and there is no need to do the check
before invoking didReceiveData().

  • loader/cf/SubresourceLoaderCF.cpp:

(WebCore::SubresourceLoader::didReceiveDataArray):

15:54 Changeset [101873] by simon.fraser@apple.com

<rdar://problem/10423627> Layers are flipped in WebKit1 views

Reviewed by Sam Weinig.

Host the compositing layers in an NSView which is flipped, which helps AppKit
get the geometry right in some situations.

  • WebView/WebHTMLView.mm:

(-[WebLayerHostingFlippedView isFlipped]):
(-[WebHTMLView attachRootLayer:]):

15:54 Changeset [101872] by lforschler@apple.com

Merge 100809.

15:48 Changeset [101871] by mitz@apple.com

Fixed a typo

15:48 Changeset [101870] by kling@webkit.org

StyledElement: Simplify addCSSColor().
<http://webkit.org/b/73703>

Reviewed by Darin Adler.

The Color(const String&) constructor handles both named and 3/6-digit
hex colors, so there's no need to handle those separately here.
Also tweaked some comments and minor things.

  • dom/StyledElement.cpp:

(WebCore::StyledElement::addCSSColor):

15:45 Changeset [101869] by mrobinson@webkit.org

Try to fix the GTK+ debug bot. As discussed with other GTK+
hackers recently. It makes sense to just remove G_DISABLE_DEPRECATIONS
now in WebKit. The flag itself is now deprecated in GLib in favor of
the gcc attribute.

  • GNUmakefile.am: Remove G_DISABLE_DEPRECATED.
15:38 Changeset [101868] by scheib@chromium.org

[Chromium] Marking svg/W3C-SVG-1.1/fonts-elem-04-b.svg flaky for text

  • platform/chromium/test_expectations.txt:
15:36 Changeset [101867] by benjamin@webkit.org

Update platform/iphone to platform/ios
https://bugs.webkit.org/show_bug.cgi?id=73708

Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-12-02
Reviewed by Darin Adler.

The platform is now best known as iOS, update the platform layer accordingly.

  • Configurations/WebCore.xcconfig:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/cocoa/KeyEventCocoa.mm:
  • platform/ios/KeyEventCodesIOS.h: Renamed from Source/WebCore/platform/iphone/KeyEventCodesIPhone.h.
  • platform/ios/KeyEventIOS.mm: Renamed from Source/WebCore/platform/iphone/KeyEventIPhone.mm.

(WebCore::keyIdentifierForKeyEvent):
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
(WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):
(WebCore::PlatformKeyboardEvent::currentCapsLockState):
(WebCore::PlatformKeyboardEvent::getCurrentModifierState):

15:31 Changeset [101866] by scheib@chromium.org

[Chromium] Adding test expectation that svg/animations/svginteger-animation-1.html crashes leopard cg

  • platform/chromium/test_expectations.txt:
15:18 Changeset [101865] by scheib@chromium.org

[Chromium] Marking http/tests/appcache/video.html TIMEOUT

  • platform/chromium/test_expectations.txt:
15:03 Changeset [101864] by commit-queue@webkit.org

[chromium] Eliminate unnecessary state on previous CL
https://bugs.webkit.org/show_bug.cgi?id=73661

Patch by Jonathan Backer <backer@chromium.org> on 2011-12-02
Reviewed by Kenneth Russell.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):
(WebCore::LayerRendererCapabilities::LayerRendererCapabilities):

15:02 Changeset [101863] by scheib@chromium.org

[Chromium] Suppressing failures in test_expectations for 101844

  • platform/chromium/test_expectations.txt:
14:59 Changeset [101862] by mrobinson@webkit.org

Try to fix the GTK+ build.

  • gtk/jhbuild.modules: Properly specify the glib-networking

dependency for soup.

14:58 Changeset [101861] by mrobinson@webkit.org

Fix a syntax error in the committers.py file.

  • Scripts/webkitpy/common/config/committers.py: Add a missing comma.
14:56 Changeset [101860] by ap@apple.com

Update sandbox rules
https://bugs.webkit.org/show_bug.cgi?id=73675
<rdar://problem/9276430>

Reviewed by Sam Weinig.

  • WebProcess/com.apple.WebProcess.sb:
14:49 Changeset [101859] by rniwa@webkit.org

Add Alan Stearns and Peter Linss to the contributors list.

  • Scripts/webkitpy/common/config/committers.py:
14:49 Changeset [101858] by mitz@apple.com

<rdar://problem/10520670> REGRESSION (r91738): didFinishLoad is called before custom fonts have finished loading
https://bugs.webkit.org/show_bug.cgi?id=73688

Reviewed by Darin Adler.

Source/WebCore:

The problem was that after CSSFontFaceSource::getFontData() had scheduled a 0-delay timer to
begin loading the font, but before that timer fired, the subresource loader appeared to have
had no resources waiting to be loaded, and therefore didFinishLoad could be called. This change
reworks the fix for <http://webkit.org/b/65123> so that while the load is still started on a
0-dealy timer, the subresource loader’s request count is incremented immediately, preventing
it from hitting 0 while the font load is scheduled to begin. The delayed load mechanism is
moved from CSSFontFaceSource into CSSFontSelector in order to safely handle the possibility of
the latter being decommissioned while waiting for font loading to begin.

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::CSSFontFaceSource): Removed initializer for m_loadStartTimer.
(WebCore::CSSFontFaceSource::~CSSFontFaceSource): Removed stopping of m_loadStartTimer.
(WebCore::CSSFontFaceSource::getFontData): Replaced code to schedule loading on a timer with
a call to CSSFontSelector::beginLoadingFontSoon.

  • css/CSSFontFaceSource.h: Removed m_loadStartTimer and m_fontSelector member variables.
  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::CSSFontSelector): Added initialized for m_beginLoadingTimer.
(WebCore::CSSFontSelector::~CSSFontSelector): Added call to clearDocument(), to deal with
anything remaining in m_fontsToBeginLoading at this time.
(WebCore::CSSFontSelector::clearDocument): Now stops m_beginLoadingTimer and balances
incrementRequestCount() calls for anything remaining in m_fontsToBeginLoading.
(WebCore::CSSFontSelector::beginLoadingFontSoon): Added. Schedules the actual call to
CachedFont::beginLoadingIfNeeded on a 0-delay timer, and meanwhile increments the request count
on the CachedResourceLoader, which ensures that didFinishLoad will not be called while waiting
for the timer to fire.
(WebCore::CSSFontSelector::beginLoadTimerFired): Added. Actually calls
CachedFont::beginLoadIfNeeded and balances the incrementRequestCount() made when the timer was
scheduled.

  • css/CSSFontSelector.h:

LayoutTests:

Reverted test chnages from r91738. These tests were made to wait for the fonts to finish loading
using a DOM. Now again they do not need to.

  • fast/css/color-leakage.html:
  • fast/css/custom-font-xheight.html:
  • fast/css/font-face-multiple-faces.html:
  • fast/css/font-face-multiple-remote-sources.html:
  • fast/css/font-face-remote.html:
  • fast/css/font-face-woff.html:
  • fast/writing-mode/broken-ideograph-small-caps.html:
  • svg/W3C-SVG-1.1-SE/text-intro-09-b.svg:
  • svg/W3C-SVG-1.1/fonts-elem-07-b.svg:
  • svg/custom/svg-fonts-fallback.xhtml:
  • svg/custom/svg-fonts-in-html.html:
  • svg/custom/svg-fonts-segmented.xhtml:
  • svg/custom/svg-fonts-with-no-element-reference.html:
  • svg/custom/svg-fonts-without-missing-glyph.xhtml:
  • svg/text/text-overflow-ellipsis-svgfont.html:
14:42 Changeset [101857] by tkent@chromium.org

[Chromium] Fix compilation warnings for ASSERT()
https://bugs.webkit.org/show_bug.cgi?id=73623

Reviewed by Tony Chang.

  • DumpRenderTree/chromium/ImageDiff.cpp:
    • Fix fprintf format: %s -> %d for LINE
    • Do nothing for ASSERT() if NDEBUG.
14:37 Changeset [101856] by eric@webkit.org

Enable parallel testing for all Mac bots.

Unreviewed.

  • Scripts/run-webkit-tests:

(platformIsReadyForParallelTesting):

14:34 Changeset [101855] by commit-queue@webkit.org

Send an AXCheckedStateChanged notification when the aria-checked attribute changes.
https://bugs.webkit.org/show_bug.cgi?id=72754

Patch by David Tseng <dtseng@google.com> on 2011-12-02
Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/aria-checkbox-sends-notification.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::checkedStateChanged):

  • accessibility/AXObjectCache.h:
  • dom/Element.cpp:

(WebCore::Element::updateAfterAttributeChanged):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setChecked):

LayoutTests:

  • accessibility/aria-checkbox-sends-notification.html: Added.
  • platform/chromium/accessibility/aria-checkbox-sends-notification-expected.txt: Added.
14:30 Changeset [101854] by commit-queue@webkit.org

[chromium] Recycle tile-sized textures during commit to prevent reallocations
https://bugs.webkit.org/show_bug.cgi?id=70645

Patch by Grace Kloba <klobag@chromium.org> on 2011-12-02
Reviewed by James Robinson.

Currently texture request is capped by the high limit while we reclaim the
textures in each commit. This triggers new tiles always allocated when scrolling.
The proposal is to recycle the texture during request if the total used memory
is about to exceed the reclaim limit.

  • platform/graphics/chromium/ManagedTexture.cpp:

(WebCore::ManagedTexture::reserve):

  • platform/graphics/chromium/TextureManager.cpp:

(WebCore::TextureManager::setMemoryLimitBytes):
(WebCore::TextureManager::replaceTexture):
(WebCore::TextureManager::requestTexture):

  • platform/graphics/chromium/TextureManager.h:
14:26 Changeset [101853] by eric@webkit.org

Enable parallel testing for run-webkit-tests on Mac Lion.
I plan to move all the machines to parallel testing shortly
but we're starting with Lion.

Unreviewed.

  • Scripts/run-webkit-tests:

(platformIsReadyForParallelTesting):

14:17 Changeset [101852] by tkent@chromium.org

Unreviewed, rolling out r101337.
http://trac.webkit.org/changeset/101337
https://bugs.webkit.org/show_bug.cgi?id=73189

It's a wrong way to fix the problem

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::popupOpened):

LayoutTests:

  • fast/forms/select-popup-crash-expected.txt: Removed.
  • fast/forms/select-popup-crash.html: Removed.
14:07 Changeset [101851] by tkent@chromium.org

Added helper method to identify whether the page has custom page size style.
https://bugs.webkit.org/show_bug.cgi?id=73585

Patch by Kausalya Madhusudhanan <kmadhusu@chromium.org> on 2011-12-02
Reviewed by Darin Fisher.

Source/WebKit/chromium:

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::hasCustomPageSizeStyle):

  • src/WebFrameImpl.h:

Tools:

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::hasCustomPageSizeStyle):

  • DumpRenderTree/chromium/LayoutTestController.h:

LayoutTests:

  • platform/chromium/printing/custom-page-size-style-expected.txt: Added.
  • platform/chromium/printing/custom-page-size-style.html: Added.
14:02 Changeset [101850] by scheib@chromium.org

[Chromium] Adding flaky tests to test_expectations

inspector/extensions tests even flakier
newly flaky media/event-attributes.html

  • platform/chromium/test_expectations.txt:
13:59 Changeset [101849] by dslomov@google.com

Unreviewed: reset expectation for tests until https://bugs.webkit.org/show_bug.cgi?id=73691
is fixed.

  • fast/dom/Window/window-postmessage-args-expected.txt:
13:55 Changeset [101848] by tkent@chromium.org

[Chromium] Show placeholder even if the element is focused
https://bugs.webkit.org/show_bug.cgi?id=73629

Reviewed by Hajime Morita.

No new tests. Need to update some existing placeholder tests.

  • rendering/RenderThemeChromiumMac.h: Add shouldShowPlaceholderWhenFocused().
  • rendering/RenderThemeChromiumMac.mm:

(WebCore::RenderThemeChromiumMac::shouldShowPlaceholderWhenFocused):
Returns true.

  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::shouldShowPlaceholderWhenFocused): ditto.

  • rendering/RenderThemeChromiumSkia.h: Add shouldShowPlaceholderWhenFocused().
13:49 Changeset [101847] by tkent@chromium.org

[Lion][Windows] Both of placeholder and input text are shown in <input type=number>
https://bugs.webkit.org/show_bug.cgi?id=73615

Reviewed by Joseph Pecoraro.

Source/WebCore:

Placeholder visibility was checked by HTMLInputElement::value
emptiness. It should be innerTextValue emptiness because it is
possible that a number field has empty HTMLInputElement::value and
non-empty innerTextValue.

Tests: fast/forms/number/number-placeholder-with-unacceptable-value.html

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateInnerTextValue):
We should update placeholder visiblity when the innerTextValue is updated.
(WebCore::HTMLInputElement::subtreeHasChanged): ditto.
(WebCore::HTMLInputElement::setSuggestedValue):
We don't need to call updatePlaceholderVisibility() because updateInnerTextValue() calls it.
(WebCore::HTMLInputElement::setValueFromRenderer):
We don't need to call updatePlaceholderVisibility() because subtreeHasChanged() calls it.

  • html/HTMLInputElement.h: Checks innerTextValue emptiness.
  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::setValue):
We don't need to call updatePlaceholderVisibility() because updateInnerTextValue() calls it.

LayoutTests:

  • fast/forms/number/number-placeholder-with-unacceptable-value-expected.html: Added.
  • fast/forms/number/number-placeholder-with-unacceptable-value.html: Added.
13:49 Changeset [101846] by tony@chromium.org

[Chromium] GYP fix for Windows 2010 build
https://bugs.webkit.org/show_bug.cgi?id=73483

Reviewed by Adam Barth.

Patch by Carlos Pizano.

  • WebKit.gyp: Exclude the android directory and remove a file match that doesn't match anything.
13:42 Changeset [101845] by rniwa@webkit.org

[NRWT] reftest should support having multiple references per test
https://bugs.webkit.org/show_bug.cgi?id=73613

Reviewed by Dirk Pranke.

Add a support for having multiple reference files for a single test.

Because a reftest succeeds when it matches at least one of expected matches and fails when it matches
at least one of expected mismatches, we compare expected mismatches first in order to minimize
the number of reference files to open on DRT.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(interpret_test_failures): Remove checks no longer applicable.

  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ResultSummaryTest.test_interpret_test_failures): Ditto.

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner.init): Remove a bunch of code and just call port.reference_files.
(SingleTestRunner._driver_input):
(SingleTestRunner.run):
(SingleTestRunner._run_reftest): Compare the output of the test to each reference file.

  • Scripts/webkitpy/layout_tests/models/test_input.py:

(TestInput.init): Remove ref_file and is_mismatch_reftest because they are no longer used.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.reference_files): Renamed from _reference_file_for. Returns a list of expectation, filename pairs.
(_parse_reftest_list): Now supports parsing multiple entries for a single test.

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_parse_reftest_list):

  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_unexpected_failures):
(MainTest.test_reftest_skipped_if_unlisted): Renamed from test_missing_and_unexpected_results.
(EndToEndTest.test_end_to_end):
(EndToEndTest.test_reftest_with_two_notrefs): Added.

13:08 Changeset [101844] by alokp@chromium.org

Source/WebCore: [chromium] CCLayerQuad does not return FloatQuad in correct order
https://bugs.webkit.org/show_bug.cgi?id=73247

Reviewed by James Robinson.

Returned the FloatQuad coordinates in correct order.

Covered by new unit tests in CCLayerQuadTest.cpp.

  • platform/graphics/chromium/cc/CCLayerQuad.cpp:

(WebCore::CCLayerQuad::floatQuad):

Source/WebKit/chromium: [chromium] CCLayerQuad does not return FloatQuad in correct order
https://bugs.webkit.org/show_bug.cgi?id=73247

Reviewed by James Robinson.

  • WebKit.gypi:
  • tests/CCLayerQuadTest.cpp: Added.

(WebCore::TEST):

LayoutTests: [chromium] CCLayerQuad does not return FloatQuad in correct order
https://bugs.webkit.org/show_bug.cgi?id=73247

Reviewed by James Robinson.

  • platform/chromium/test_expectations.txt:
11:57 Changeset [101843] by scheib@chromium.org

[Chromium] Marking slow test: http/tests/appcache/video.html

  • platform/chromium/test_expectations.txt:
11:39 Changeset [101842] by adamk@chromium.org

[chromium] WebKitMutationObserver::deliverAllMutations should be exposed through the Chromium API
https://bugs.webkit.org/show_bug.cgi?id=71242

Reviewed by Darin Fisher.

Relanding, depends on http://codereview.chromium.org/8748015/
to fix a sandboxing issue on Chromium/Linux.

Add addTaskObserver and removeTaskObserver to WebThread,
along with a new WebThread::TaskObserver interface.

For mutation observers, add a TaskObserver to the main thread
to deliver mutations after each task runs.

The Chromium implementation of the new WebThread methods is in
http://codereview.chromium.org/8586038/.

  • public/platform/WebThread.h:

(WebKit::WebThread::TaskObserver::~TaskObserver):

  • src/WebKit.cpp:

(WebKit::initialize):
(WebKit::shutdown):

11:34 BuildBot edited by bfulgham@webkit.org
Some notes to prevent the "[executable] has crashed" dialog from … (diff)
11:31 Changeset [101841] by scheib@chromium.org

Unreviewed, rolling out r101833.
http://trac.webkit.org/changeset/101833
https://bugs.webkit.org/show_bug.cgi?id=73678

test_expectations file invalid: run Tools/Scripts/new-run-
webkit-tests --lint-test-files (Requested by scheib on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-02

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerQuad.cpp:

(WebCore::CCLayerQuad::floatQuad):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCLayerQuadTest.cpp: Removed.

LayoutTests:

  • platform/chromium/test_expectations.txt:
11:24 Changeset [101840] by kov@webkit.org

Build libsoup without gnome dependencies (like keyring).

  • gtk/jhbuild.modules:
11:21 Changeset [101839] by scheib@chromium.org

[Chromium] Fixe test_expectations.txt parse error

  • platform/chromium/test_expectations.txt:
11:21 Changeset [101838] by aestes@apple.com

WebKit2: Freeze the state of the layer tree until frame load completion if incremental rendering is suppressed
https://bugs.webkit.org/show_bug.cgi?id=73641

Reviewed by Darin Adler.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidFirstLayout): Do not
un-freeze the layer tree state if incremental rendering is suppressed.

  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::layerTreeStateIsFrozen): Add a getter for
m_layerTreeStateIsFrozen.

  • WebProcess/WebPage/DrawingAreaImpl.h:

(WebKit::DrawingAreaImpl::layerTreeStateIsFrozen): Ditto.

  • WebProcess/WebPage/ca/LayerTreeHostCA.cpp:

(WebKit::LayerTreeHostCA::initialize): WebFrameLoaderClient might have
tried to freeze the state of the layer tree before the layer tree host
was created. When creating the layer tree host, only schedule a layer
flush if the layer tree state isn't frozen.

11:19 Changeset [101837] by kov@webkit.org

Also build gcrypt and p11-kit, and make them dependencies of
gnutls.

  • gtk/jhbuild.modules:
11:19 Changeset [101836] by scheib@chromium.org

[Chromium] Expected flakey tests after fix for 73021 is committed
https://bugs.webkit.org/show_bug.cgi?id=73677

Unreviewed test_expectations update.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-12-02

  • platform/chromium/test_expectations.txt: Added flakey for svg/stroke/...
11:16 Changeset [101835] by kevino@webkit.org

[wx] Unreviewed build fixes for Windows build.

11:10 Changeset [101834] by eric@webkit.org

Reviewed by Adam Barth.

webkit-patch post, post-commits, upload should warn when posting to a closed bug, and offer to reopen it
https://bugs.webkit.org/show_bug.cgi?id=32006

I decided not to make it warn, and just have it re-open the bug.
That's not that different from today's behavior which will
just silently attach the patch.

This patch makes behavior between upload and land-safely consistent
(previously one would assign patches and the other would not)
as well as adds the ability for both to ensure that the bug is open.

To test this I had to add a few more methods to MockBugzilla which
(positively) affected a few other test results.

I also made AbstractStep keep a cached copy of the Bug object
and used the cached copy where appropriate (including for 'bug_title').
This should reduce the number of bug fetches we perform.

  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/init.py:
  • Scripts/webkitpy/tool/steps/abstractstep.py:
  • Scripts/webkitpy/tool/steps/closebug.py:
  • Scripts/webkitpy/tool/steps/ensurebugisopenandassigned.py: Added.
  • Scripts/webkitpy/tool/steps/postdiff.py:
  • Scripts/webkitpy/tool/steps/postdiffforcommit.py:
  • Scripts/webkitpy/tool/steps/preparechangelog.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
11:08 Changeset [101833] by alokp@chromium.org

[chromium] CCLayerQuad does not return FloatQuad in correct orientation
https://bugs.webkit.org/show_bug.cgi?id=73247

Reviewed by James Robinson.

Source/WebCore:

Returned the FloatQuad coordinates in correct order.

Covered by new unit tests in CCLayerQuadTest.cpp.

  • platform/graphics/chromium/cc/CCLayerQuad.cpp:

(WebCore::CCLayerQuad::floatQuad):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCLayerQuadTest.cpp: Added.

(WebCore::TEST):

LayoutTests:

  • platform/chromium/test_expectations.txt:
11:05 Changeset [101832] by kov@webkit.org

Also pass --no-interact to jhbuild when updating dependencies.

  • Scripts/update-webkitgtk-libs:
11:00 Changeset [101831] by dslomov@google.com

https://bugs.webkit.org/show_bug.cgi?id=73589
[V8][Chromium] Adjust postMessage to the latest "implementation-ready" spec.

  • postMessage should support transfer of MessagePorts
  • the order of arguments to Window::postMessage and Window::webkitPostMessage should be (msg, targetOrigin [, transfer])

Reviewed by David Levin.

Source/WebCore:

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::handlePostMessageCallback):

  • bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:

(WebCore::handlePostMessageCallback):

  • bindings/v8/custom/V8MessagePortCustom.cpp:

(WebCore::handlePostMessageCallback):

  • bindings/v8/custom/V8WorkerCustom.cpp:

(WebCore::handlePostMessageCallback):

LayoutTests:

  • fast/canvas/webgl/script-tests/arraybuffer-transfer-of-control.js:

(wrapSend):
(wrapFailSend):

  • fast/dom/Window/window-postmessage-args.html:
  • platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt:
10:57 Changeset [101830] by enrica@apple.com

https://bugs.webkit.org/show_bug.cgi?id=73497
This is a followup to the patch submitted for the bug above.
Tha patch was landed in r101575 and I missed to make one of the changes
suggested by the reviewer that had pointed out that the code was still
making use of the deprecatedNode method.

Unreviewed.

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::removeRedundantBlocks): Changed deprecatedNode to containerNode.

10:55 Changeset [101829] by tsepez@chromium.org

Content-security-policy script-src not enforced on workers.
https://bugs.webkit.org/show_bug.cgi?id=73240

Reviewed by Adam Barth.

Source/WebCore:

Add a CSP check in AbstractWorker.cpp as part of resolving URL.

Test: http/tests/security/contentSecurityPolicy/worker-script-src.html

  • workers/AbstractWorker.cpp:

(WebCore::AbstractWorker::resolveURL):

LayoutTests:

Added test to verify bug.

  • http/tests/security/contentSecurityPolicy/worker-script-src-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/worker-script-src.html: Added.
10:52 Changeset [101828] by dcheng@chromium.org

[chromium] Add plumbing for supporting custom MIME types in DataTransfer.
https://bugs.webkit.org/show_bug.cgi?id=73594

Reviewed by David Levin.

Source/WebCore:

Tests: editing/pasteboard/clipboard-customData.html

fast/events/drag-customData.html

  • platform/chromium/ChromiumDataObject.cpp:

(WebCore::ChromiumDataObject::types):
(WebCore::ChromiumDataObject::getData):
(WebCore::ChromiumDataObject::setData):

  • platform/chromium/ChromiumDataObject.h:

(WebCore::ChromiumDataObject::customData):

  • platform/chromium/PlatformSupport.h:

Source/WebKit/chromium:

  • public/platform/WebClipboard.h:

(WebKit::WebClipboard::readCustomData):

  • public/platform/WebDragData.h:
  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::clipboardReadCustomData):

  • src/WebDragData.cpp:

(WebKit::WebDragData::customData):
(WebKit::WebDragData::setCustomData):

LayoutTests:

  • editing/pasteboard/clipboard-customData-expected.txt: Added.
  • editing/pasteboard/clipboard-customData.html: Added.
  • fast/events/drag-customData-expected.txt: Added.
  • fast/events/drag-customData.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
10:47 Changeset [101827] by aboxhall@chromium.org

Make _build_path check more thoroughly that build paths exist.
https://bugs.webkit.org/show_bug.cgi?id=73601

Reviewed by Ojan Vafai.

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:

(ChromiumMacPort._build_path):

10:44 Changeset [101826] by kov@webkit.org

Add libffi to the jhbuild modules list as a glib dependency.

Rubber-stamped by Martin Robinson.

  • gtk/jhbuild.modules:
10:34 Changeset [101825] by darin@apple.com

[Mac] Form stream data structures still not threadsafe
https://bugs.webkit.org/show_bug.cgi?id=73674

Reviewed by Anders Carlsson.

  • platform/network/mac/FormDataStreamMac.mm:

(WebCore::streamFieldsMapMutex): Added.
(WebCore::associateStreamWithResourceHandle): Use streamFieldsMapMutex.
(WebCore::formCreate): Ditto.
(WebCore::formFinalize): Ditto.
(WebCore::httpBodyFromStream): Ditto.

10:31 Changeset [101824] by commit-queue@webkit.org

IndexedDB: Rename "multientry" to "multiEntry" per spec change
https://bugs.webkit.org/show_bug.cgi?id=73578

Patch by Joshua Bell <jsbell@chromium.org> on 2011-12-02
Reviewed by Darin Fisher.

Source/WebCore:

  • storage/IDBIndex.h:

(WebCore::IDBIndex::multiEntry):

  • storage/IDBIndex.idl:
  • storage/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::IDBIndexBackendImpl):

  • storage/IDBIndexBackendImpl.h:

(WebCore::IDBIndexBackendImpl::create):
(WebCore::IDBIndexBackendImpl::multiEntry):

  • storage/IDBIndexBackendInterface.h:
  • storage/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::getIndexes):
(WebCore::IDBLevelDBBackingStore::createIndex):

  • storage/IDBLevelDBCoding.cpp:
  • storage/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::createIndex):

  • storage/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::loadIndexes):

  • storage/IDBObjectStoreBackendImpl.h:
  • storage/IDBObjectStoreBackendInterface.h:

Source/WebKit/chromium:

  • public/WebIDBIndex.h:

(WebKit::WebIDBIndex::multiEntry):

  • public/WebIDBObjectStore.h:

(WebKit::WebIDBObjectStore::createIndex):

  • src/IDBIndexBackendProxy.cpp:

(WebKit::IDBIndexBackendProxy::multiEntry):

  • src/IDBIndexBackendProxy.h:
  • src/IDBObjectStoreBackendProxy.cpp:

(WebKit::IDBObjectStoreBackendProxy::createIndex):

  • src/IDBObjectStoreBackendProxy.h:
  • src/WebIDBIndexImpl.cpp:

(WebKit::WebIDBIndexImpl::multiEntry):

  • src/WebIDBIndexImpl.h:
  • src/WebIDBObjectStoreImpl.cpp:

(WebKit::WebIDBObjectStoreImpl::createIndex):

  • src/WebIDBObjectStoreImpl.h:

LayoutTests:

  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/index-multientry-expected.txt:
  • storage/indexeddb/index-multientry.html:
10:30 Changeset [101823] by kov@webkit.org

Build fix. Use internal pcre on glib, make gnutls a dependency of
glib-networking, unset AR_FLAGS for jhbuild builds, and run jhbuild
in non-interactive mode.

  • Scripts/update-webkitgtk-libs:
  • gtk/jhbuild.modules:
  • gtk/run-with-jhbuild:
10:26 Changeset [101822] by aroben@apple.com

Fix for Python 2.6

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunUnitTests.countFailures): Removed the flags parameter to re.split, which was only added
in Python 2.7, and used whitespace instead of start-of-string/end-of-string markers when
searching for "Tests that timed out:" etc. This makes our check less strict, but it
shouldn't matter given the kinds of content we parse.

10:19 Changeset [101821] by aroben@apple.com

Fix names of failed/timed out tests in run-api-tests output

Fixes <http://webkit.org/b/73663> run-api-tests prints suite names twice for failed or timed
out tests

We were ending up with the suite name doubled (e.g., "WebKit2.WebKit2.MouseMoveAfterCrash").

Reviewed by Simon Fraser.

  • Scripts/run-api-tests:

(runTest): Don't prepend the suite name to $test. It's already been prepended at the start
of this function.

10:17 Changeset [101820] by mrobinson@webkit.org

[GTK] generate-gtkdoc should respect build type
https://bugs.webkit.org/show_bug.cgi?id=73296

Reviewed by Philippe Normand.

  • Scripts/webkitdirs.pm:

(buildAutotoolsProject): Pass the --debug to the generate-gtkdoc script.

  • gtk/common.py: If --build is passed give preference to the Debug build directory.
10:11 Changeset [101819] by tony@chromium.org

[nrwt] fix wdiff output
https://bugs.webkit.org/show_bug.cgi?id=73604

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.wdiff_text):

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_wdiff_text):

10:01 Changeset [101818] by aroben@apple.com

Teach build.webkit.org to display how many unit tests failed or timed out

Fixes <http://webkit.org/b/73659> It's hard to tell how many unit tests are failing on
build.webkit.org

We now display something like "5 unit tests failed or timed out". Eventually we might want
to split out how many failure vs. timeouts there were.

Reviewed by Darin Adler.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(TestWithFailureCount): Moved this class up to the top of the file so it is before any other
classes that may want to subclass it.
(RunUnitTests): Changed to inherit from TestWithFailureCount.
(RunUnitTests.countFailures): Added. Counts the number of tests following the "Tests that
timed out:" and "Tests that failed:" lines, if present.

  • BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:

(StubStdio):
(StubRemoteCommand):
Added these two stub classes to mimic buildbot's RemoteCommand and log classes.

(RunUnitTestsTest.assertFailures): Helper method to check that we interpreted the results of
the test run correctly.

(RunUnitTestsTest.test_no_failures_or_timeouts):
(RunUnitTestsTest.test_one_failure):
(RunUnitTestsTest.test_multiple_failures):
(RunUnitTestsTest.test_one_timeout):
(RunUnitTestsTest.test_multiple_timeouts):
(RunUnitTestsTest.test_multiple_failures_and_timeouts):
Test various cases.

10:00 Changeset [101817] by aroben@apple.com

Teach prepare-ChangeLog to treat master.cfg as a Python file

Fixes <http://webkit.org/b/73658> prepare-ChangeLog doesn't show modified classes/functions
in buildbot's master.cfg

Reviewed by Darin Adler.

  • Scripts/prepare-ChangeLog:

(get_function_line_ranges): Use get_function_line_ranges_for_python if the filename is
master.cfg.

09:49 Changeset [101816] by darin@apple.com

Unreviewed, rolling out r101805.
http://trac.webkit.org/changeset/101805
https://bugs.webkit.org/show_bug.cgi?id=73670

Many canvas tests started failing due to the isEmpty change
(Requested by darin on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-02

Source/WebCore:

  • platform/graphics/cg/PathCG.cpp:

(WebCore::Path::boundingRect):
(WebCore::Path::fastBoundingRect):
(WebCore::Path::isEmpty):

LayoutTests:

  • platform/chromium-mac/svg/custom/path-moveto-only-rendering-expected.png: Removed.
  • platform/chromium-mac/svg/custom/path-moveto-only-rendering-expected.txt: Removed.
  • platform/chromium-mac/svg/custom/subpaths-moveto-only-rendering-expected.png: Removed.
  • platform/chromium-mac/svg/custom/subpaths-moveto-only-rendering-expected.txt: Removed.
  • platform/chromium-mac/svg/custom/zero-path-square-cap-rendering2-expected.txt: Copied from LayoutTests/svg/custom/zero-path-square-cap-rendering2-expected.txt.
  • platform/chromium-win/svg/custom/zero-path-square-cap-rendering2-expected.txt: Copied from LayoutTests/svg/custom/zero-path-square-cap-rendering2-expected.txt.
  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/custom/path-moveto-only-rendering-expected.png: Removed.
  • platform/mac/svg/custom/path-moveto-only-rendering-expected.txt: Removed.
  • platform/mac/svg/custom/subpaths-moveto-only-rendering-expected.png: Removed.
  • platform/mac/svg/custom/subpaths-moveto-only-rendering-expected.txt: Removed.
  • platform/win/svg/custom/path-moveto-only-rendering-expected.png: Removed.
  • platform/win/svg/custom/path-moveto-only-rendering-expected.txt: Removed.
  • platform/win/svg/custom/subpaths-moveto-only-rendering-expected.png: Removed.
  • platform/win/svg/custom/subpaths-moveto-only-rendering-expected.txt: Removed.
  • svg/custom/path-moveto-only-rendering.svg: Removed.
  • svg/custom/subpaths-moveto-only-rendering.svg: Removed.
  • svg/custom/zero-path-square-cap-rendering2-expected.txt:
09:44 Changeset [101815] by commit-queue@webkit.org

[WebKit2][gtk] Add 'enable-dns-prefetching' property to WebKitSettings
https://bugs.webkit.org/show_bug.cgi?id=73414

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-12-02
Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsSetProperty): Add new set function.
(webKitSettingsGetProperty): Add new get function.
(webkit_settings_class_init): Register new property.
(webkit_settings_get_enable_dns_prefetching): API to get 'enable-dns-prefetching' property.
(webkit_settings_set_enable_dns_prefetching): API to set 'enable-dns-prefetching' property.

  • UIProcess/API/gtk/WebKitSettings.h: Expose new public API's.
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new APIs to gtk-doc sections file.
  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings): Add new tests.

09:44 Changeset [101814] by mrobinson@webkit.org

[GTK] Create a wrapper script that knows how to install jhbuild and run commands with it
https://bugs.webkit.org/show_bug.cgi?id=73669

Reviewed by Gustavo Noronha Silva.

Add a wrapper script that knows how to install jhbuild and also to wrap commands
in the jhbuild shell.

  • Scripts/webkitdirs.pm:

(runAutogenForAutotoolsProject): Use the new wrapper script.
(mustReRunAutogen): Ditto.
(buildAutotoolsProject): Ditto.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkDriver.cmd_line): Ditto.

  • gtk/run-with-jhbuild: Added.
09:42 Changeset [101813] by darin@apple.com

[Mac] Reference count threading violation in FormDataStreamMac.mm
https://bugs.webkit.org/show_bug.cgi?id=73627

Reviewed by Sam Weinig.

Shows up as a crash during existing layout test runs so no new tests are required.

  • platform/network/mac/FormDataStreamMac.mm:

(WebCore::streamFieldsMap): Replaced getStreamFormDataMap with this.
Use an NSMapTable instead of a HashMap because we need to remove items from this
on a non-main thread.
(WebCore::associateStreamWithResourceHandle): Use NSMapGet instead of
HashMap::contains here.
(WebCore::formCreate): FormStreamFields now stores a RefPtr to the form data.
Added the code to fill that in. Did it in a more modern way to avoid the leakRef
and adoptRef that were used before. Replaced the code that set up the stream
form data map entry with code that sets an entry in the streamFieldsMap.
(WebCore::formFinishFinalizationOnMainThread): Added. Contains the work of
finalization that must be done on the main thread, specifically, destroying the
fields structure that contains objects with RefPtr in them. We can't touch these
reference counts on non-main threads.
(WebCore::formFinalize): Changed this to use NSMapRemove on the streamFieldsMap.
Added a callOnMainThread to finish the finalization.
(WebCore::setHTTPBody): Removed the leakRef, no longer needed, that used to be
balanced by an adoptRef in formCreate.
(WebCore::httpBodyFromStream): Changed to use NSMapGet.

09:42 Changeset [101812] by antti@apple.com

https://bugs.webkit.org/show_bug.cgi?id=73520
REGRESSION(r101524): Article titles invisible until hover on blaze.com

Source/WebCore:

Reviewed by Darin Adler.

We need to invalidate the matched declaration cache when new web fonts are loaded.
Fonts in the cached RenderStyles may not be valid anymore.

Also renamed m_matchStyleDeclarationCache -> m_matchedStyleDeclarationCache.

Test reduction by the Reduction Fairy (aka kling).

Test: fast/css/font-face-cache-bug.html

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::dispatchInvalidationCallbacks):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::findFromMatchedDeclarationCache):
(WebCore::CSSStyleSelector::addToMatchedDeclarationCache):
(WebCore::CSSStyleSelector::invalidateMatchedDeclarationCache):

  • css/CSSStyleSelector.h:

LayoutTests:

Reviewed by Darin Adler.

Test reduction by the Reduction Fairy (aka kling).

  • fast/css/font-face-cache-bug-expected.txt: Added.
  • fast/css/font-face-cache-bug.html: Added.
09:41 Changeset [101811] by kov@webkit.org

[GTK] Add glib, glib-networking, gnutls and libsoup to jhbuild
https://bugs.webkit.org/show_bug.cgi?id=73664

Reviewed by Martin Robinson.

This patch adds our HTTP library and its main dependencies; this
should not affect layout or rendering.

  • gtk/jhbuild.modules:
09:35 Changeset [101810] by jer.noble@apple.com

MediaControls should use MediaController if present.
https://bugs.webkit.org/show_bug.cgi?id=71410

Reviewed by Eric Carlson.

No new tests; covered by existing tests.

Add support for individual media controls to control the MediaController of their associated
HTMLMediaElement, if present.

The video spec requires that UA provided media controls be implemented in terms of their
HTMLMediaElement's MediaController, if present. So for each of the media controls, modify
their constructor to take a Document* instead of an HTMLMediaElement, and add an setter
taking a MediaControllerInterface.

Now that MediaControls have an abstract interface instead of an HTMLMediaElement, use toParentMediaElement
to find the controllingVideoElement.

  • accessibility/AccessibilityMediaControls.cpp:

(WebCore::AccessibilityMediaControlsContainer::controllingVideoElement):

Pass the MediaController or the HTMLMediaElement when setting up the elements controls.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::createMediaControls):
(WebCore::HTMLMediaElement::setMediaController):

The following functions have only constructor changes:

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlElement::MediaControlElement):
(WebCore::MediaControlPanelElement::MediaControlPanelElement):
(WebCore::MediaControlPanelElement::create):
(WebCore::MediaControlTimelineContainerElement::MediaControlTimelineContainerElement):
(WebCore::MediaControlTimelineContainerElement::create):
(WebCore::MediaControlVolumeSliderContainerElement::MediaControlVolumeSliderContainerElement):
(WebCore::MediaControlVolumeSliderContainerElement::create):
(WebCore::MediaControlStatusDisplayElement::MediaControlStatusDisplayElement):
(WebCore::MediaControlStatusDisplayElement::create):
(WebCore::MediaControlInputElement::MediaControlInputElement):
(WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement):
(WebCore::MediaControlMuteButtonElement::defaultEventHandler):
(WebCore::MediaControlPanelMuteButtonElement::MediaControlPanelMuteButtonElement):
(WebCore::MediaControlPanelMuteButtonElement::create):
(WebCore::MediaControlVolumeSliderMuteButtonElement::MediaControlVolumeSliderMuteButtonElement):
(WebCore::MediaControlVolumeSliderMuteButtonElement::create):
(WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement):
(WebCore::MediaControlPlayButtonElement::create):
(WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement):
(WebCore::MediaControlSeekForwardButtonElement::MediaControlSeekForwardButtonElement):
(WebCore::MediaControlSeekForwardButtonElement::create):
(WebCore::MediaControlSeekBackButtonElement::MediaControlSeekBackButtonElement):
(WebCore::MediaControlSeekBackButtonElement::create):
(WebCore::MediaControlRewindButtonElement::MediaControlRewindButtonElement):
(WebCore::MediaControlRewindButtonElement::create):
(WebCore::MediaControlReturnToRealtimeButtonElement::MediaControlReturnToRealtimeButtonElement):
(WebCore::MediaControlReturnToRealtimeButtonElement::create):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::create):
(WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
(WebCore::MediaControlTimelineElement::create):
(WebCore::MediaControlVolumeSliderElement::MediaControlVolumeSliderElement):
(WebCore::MediaControlVolumeSliderElement::create):
(WebCore::MediaControlVolumeSliderElement::defaultEventHandler):
(WebCore::MediaControlFullscreenVolumeSliderElement::MediaControlFullscreenVolumeSliderElement):
(WebCore::MediaControlFullscreenVolumeSliderElement::create):
(WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
(WebCore::MediaControlFullscreenButtonElement::create):
(WebCore::MediaControlFullscreenVolumeMinButtonElement::MediaControlFullscreenVolumeMinButtonElement):
(WebCore::MediaControlFullscreenVolumeMinButtonElement::create):
(WebCore::MediaControlFullscreenVolumeMaxButtonElement::MediaControlFullscreenVolumeMaxButtonElement):
(WebCore::MediaControlFullscreenVolumeMaxButtonElement::create):
(WebCore::MediaControlTimeDisplayElement::MediaControlTimeDisplayElement):
(WebCore::MediaControlTimeRemainingDisplayElement::create):
(WebCore::MediaControlTimeRemainingDisplayElement::MediaControlTimeRemainingDisplayElement):
(WebCore::MediaControlCurrentTimeDisplayElement::create):
(WebCore::MediaControlCurrentTimeDisplayElement::MediaControlCurrentTimeDisplayElement):

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::MediaControlRootElement):
(WebCore::MediaControls::create):
(WebCore::MediaControlRootElement::create):

  • html/shadow/MediaControlRootElement.h:
  • html/shadow/MediaControls.cpp:

(WebCore::MediaControls::MediaControls):

  • html/shadow/MediaControls.h:

The following functions now call MediaControllerInterface instead of HTMLMediaElement directly:

  • html/shadow/MediaControlElements.h:

(WebCore::MediaControlStatusDisplayElement::update):
(WebCore::MediaControlMuteButtonElement::updateDisplayType):
(WebCore::MediaControlPlayButtonElement::defaultEventHandler):
(WebCore::MediaControlPlayButtonElement::updateDisplayType):
(WebCore::MediaControlSeekButtonElement::startTimer):
(WebCore::MediaControlSeekButtonElement::stopTimer):
(WebCore::MediaControlSeekButtonElement::nextRate):
(WebCore::MediaControlSeekButtonElement::seekTimerFired):
(WebCore::MediaControlRewindButtonElement::defaultEventHandler):
(WebCore::MediaControlReturnToRealtimeButtonElement::defaultEventHandler):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::updateDisplayType):
(WebCore::MediaControlTimelineElement::defaultEventHandler):
(WebCore::MediaControlFullscreenButtonElement::defaultEventHandler):
(WebCore::MediaControlFullscreenVolumeMinButtonElement::defaultEventHandler):
(WebCore::MediaControlFullscreenVolumeMaxButtonElement::defaultEventHandler):

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::reset):
(WebCore::MediaControlRootElement::playbackStarted):
(WebCore::MediaControlRootElement::playbackProgressed):
(WebCore::MediaControlRootElement::playbackStopped):
(WebCore::MediaControlRootElement::updateTimeDisplay):
(WebCore::MediaControlRootElement::loadedMetadata):
(WebCore::MediaControlRootElement::changedVolume):
(WebCore::MediaControlRootElement::enteredFullscreen):
(WebCore::MediaControlRootElement::showVolumeSlider):
(WebCore::MediaControlRootElement::defaultEventHandler):
(WebCore::MediaControlRootElement::startHideFullscreenControlsTimer):
(WebCore::MediaControlRootElement::hideFullscreenControlsTimerFired):

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
(WebCore::MediaControls::create):
(WebCore::MediaControlRootElementChromium::create):
(WebCore::MediaControlRootElementChromium::reset):
(WebCore::MediaControlRootElementChromium::playbackStarted):
(WebCore::MediaControlRootElementChromium::playbackProgressed):
(WebCore::MediaControlRootElementChromium::playbackStopped):
(WebCore::MediaControlRootElementChromium::updateTimeDisplay):
(WebCore::MediaControlRootElementChromium::defaultEventHandler):
(WebCore::MediaControlRootElementChromium::changedVolume):
(WebCore::MediaControlRootElementChromium::showVolumeSlider):

  • html/shadow/MediaControlRootElementChromium.h:

The following functions set the current MediaControllerInterface.

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::setMediaController):

  • html/shadow/MediaControlElements.h:

(WebCore::MediaControlElement::setMediaController):
(WebCore::MediaControlElement::mediaController):
(WebCore::MediaControlInputElement::setMediaController):
(WebCore::MediaControlInputElement::mediaController):

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::setMediaController):

09:07 Changeset [101809] by commit-queue@webkit.org

Unreviewed, rolling out r101801.
http://trac.webkit.org/changeset/101801
https://bugs.webkit.org/show_bug.cgi?id=73667

Build is still broken (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-02

  • assembler/SH4Assembler.h:
09:04 Changeset [101808] by sfalken@apple.com

Changes to localStorageDatabasePath don't have any effect on Windows
https://bugs.webkit.org/show_bug.cgi?id=73606
<rdar://problem/10491296>

Reviewed by Darin Adler.

  • WebView.cpp:

(WebView::notifyPreferencesChanged): Propagate local storage path change to m_page's settings.

09:01 Changeset [101807] by philn@webkit.org

Unreviewed, skip failing websocket test on GTK.

  • platform/gtk/Skipped: Skip http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html
08:50 Changeset [101806] by darin@apple.com

Prepare to deploy pass and peek types in the HashMap class
https://bugs.webkit.org/show_bug.cgi?id=73477

Reviewed by Adam Roben.

This patch adds private typedefs inside the HashMap class,
and uses them as appropriate. A future patch will actually
tie those typedefs to hash traits, which will allow us to
make HashMap work with OwnPtr mapped values and to optimize
how HashMap works with RefPtr mapped values.

Also changed the hash translator and adapter struct templates
to use template functions to simplify them and make them more
flexible.

Also removed some unused template arguments.

This goes out of its way to not change behavior. Future patches
will change the peek type to be a reference type, which will
reduce reference count churn a bit for hash tables with RefPtr
mapped values, and then do further optimizations for RefPtr
and OwnPtr by getting types from the hash traits.

  • wtf/HashMap.h: Added MappedPassInType, MappedPassOutType,

and MappedPeekType typedefs, and used them for the arguments
and return types of the get, set, add, take, and inlineAdd
functions.
(WTF::HashMapTranslator): Changed this struct template to take
fewer arguments, and changed its member functions to be
function templates instead. This allows the compiler to
determine types more flexibly and also simplifies use of it.
(WTF::HashMapTranslatorAdapter): Ditto.
(WTF::HashMap::find): Updated to use new HashMapTranslatorAdapter.
Also reduced the arguments passed to the HashTable function template.
(WTF::HashMap::contains): Ditto.
(WTF::HashMap::inlineAdd): Ditto. Also take MappedPassInType.
(WTF::HashMap::set): Ditto.
(WTF::HashMap::add): Ditto.
(WTF::HashMap::inlineGet): Ditto, but return MappedPeekType.
(WTF::HashMap::get): Ditto.
(WTF::HashMap::take): Ditto, but return MappedPassOutType and use
that type in the implementation.
(WTF::deleteAllValues): Removed unneeded template arguments from
call to deleteAllPairSeconds.
(WTF::deleteAllKeys): Removed unneeded template arguments from
call to deleteAllPairFirsts.

  • wtf/HashSet.h:

(WTF::IdentityExtractor): Changed this to be a struct rather than
a struct template, and replaced the extract function with a function
template. This allows the compiler to deduce the type.
(WTF::HashSetTranslatorAdapter): Changed this struct template to take
fewer arguments, and changed its member functions to be
function templates instead. This allows the compiler to
determine types more flexibly and also simplifies use of it.
(WTF::HashSet::find): Updated to use new HashSetTranslatorAdapter.
Also reduced the arguments passed to the HashTable function template.
(WTF::HashSet::contains): Ditto.
(WTF::HashSet::add): Ditto.

  • wtf/HashTable.h:

(WTF::IdentityHashTranslator): Changed this struct template to take
fewer arguments, and changed its member functions to be
function templates instead. This allows the compiler to
determine types more flexibly and also simplifies use of it.
(WTF::HashTable::add): Reduced arguments passed to the function template.
(WTF::HashTable::find): Ditto, also reversed the template arguments so the
translator comes first so the compiler can deduce the other type.
(WTF::HashTable::contains): Ditto.
(WTF::HashTable::lookup): Ditto.
(WTF::HashTable::lookupForWriting): Ditto.
(WTF::HashTable::checkKey): Ditto.
(WTF::HashTable::fullLookupForWriting): Ditto.
(WTF::HashTable::add): Ditto.
(WTF::HashTable::addPassingHashCode): Ditto.
(WTF::HashTable::find): Ditto.
(WTF::HashTable::contains): Ditto.

  • wtf/ListHashSet.h:

(WTF::ListHashSetNodeHashFunctions): Changed this struct template to take
fewer arguments, and changed its member functions to be function templates
instead. This allows the compiler to determine types more flexibly and
also simplifies use of it.
(WTF::ListHashSet::find): Reduced the arguments passed to the HashTable
functon template.
(WTF::ListHashSetTranslatorAdapter): Changed this struct template in the
same way we changed ListHashSetNodeHashFunctions above.
(WTF::ListHashSetTranslatorAdapter::equal):
(WTF::::contains):
(WTF::::add):
(WTF::::insertBefore):

  • wtf/RefPtrHashMap.h: Updated comments. Removed the

RefPtrHashMapRawKeyTranslator struct template; we can use the
HashMapTranslator struct template from HashMap.h instead now that
it is more flexible. Added MappedPassInType, MappedPassOutType,
and MappedPeekType typedefs, and used them for the arguments
and return types of the get, inlineGet, set, add, take, and inlineAdd
functions. Changed the name of the RawKeyTranslator type to
Translator since it's now a class that can handle both raw keys
and conventional keys.
(WTF::HashMap::find): Changed to use Translator instead of RawKeyTranslator.
Reduced the arguments passed to the HashTable function template.
(WTF::HashMap::contains): Ditto.
(WTF::HashMap::inlineAdd): Ditto. Also take MappedPassInType.
(WTF::HashMap::set): Ditto.
(WTF::HashMap::add): Ditto.
(WTF::HashMap::inlineGet): Ditto, but return MappedPeekType.
(WTF::HashMap::get): Ditto.
(WTF::HashMap::take): Ditto, but return MappedPassOutType and use
that type in the implementation.
(WTF::deleteAllValues): Removed unneeded template arguments from
call to deleteAllPairSeconds.
(WTF::deleteAllKeys): Removed unneeded template arguments from
call to deleteAllPairFirsts.

08:41 WebKitGtkLayoutTests edited by kov@webkit.org
(diff)
08:37 Changeset [101805] by commit-queue@webkit.org

REGRESSION (r91125): Polyline tool in google docs is broken
https://bugs.webkit.org/show_bug.cgi?id=65796

Source/WebCore:

Patch by Stephen Chenney <schenney@chromium.org> on 2011-12-02
Reviewed by Darin Adler.

Work around a bug in CoreGraphics, that caused incorrect bounds for paths
consisting only of move-to elements. This causes problems in SVG, when the enormous
bounds prevented the drawing of things behind.

Tests: svg/custom/path-moveto-only-rendering.svg

svg/custom/subpaths-moveto-only-rendering.svg

  • platform/graphics/cg/PathCG.cpp:

(WebCore::PathIsEmptyOrSingleMoveTester::PathIsEmptyOrSingleMoveTester): Class to
test for isEmpty accoridng ot the same rules as other platforms.
(WebCore::PathIsEmptyOrSingleMoveTester::isEmpty): Query the result
(WebCore::PathIsEmptyOrSingleMoveTester::testPathElement): Path iterator method
(WebCore::PathHasOnlyMoveToTester::PathHasOnlyMoveToTester): Class to test whether a
path contains only move-to elements, and hence should have null bounds.
(WebCore::PathHasOnlyMoveToTester::hasOnlyMoveTo): Query the result
(WebCore::PathHasOnlyMoveToTester::testPathElement): Path iterator method.
(WebCore::Path::boundingRect): Modified to check for move-to only paths
(WebCore::Path::fastBoundingRect): Modified to check for move-to only paths
(WebCore::Path::isEmpty): Now uses the method that matches other platforms.

LayoutTests:

Work around a bug in CoreGraphics, that caused incorrect bounds for paths
consisting only of move-to elements. This causes problems in SVG, when the enormous
bounds prevented the drawing of things behind.

Will revert expectation file when expectations are stable.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-12-02
Reviewed by Darin Adler.

  • platform/chromium-mac/svg/custom/zero-path-square-cap-rendering2-expected.txt: Removed.
  • platform/chromium-win/svg/custom/zero-path-square-cap-rendering2-expected.txt: Removed.
  • platform/mac/svg/custom/path-moveto-only-rendering-expected.png: Added.
  • platform/mac/svg/custom/path-moveto-only-rendering-expected.txt: Added.
  • platform/mac/svg/custom/subpaths-moveto-only-rendering-expected.png: Added.
  • platform/mac/svg/custom/subpaths-moveto-only-rendering-expected.txt: Added.
  • platform/win/svg/custom/path-moveto-only-rendering-expected.png: Added.
  • platform/win/svg/custom/path-moveto-only-rendering-expected.txt: Added.
  • platform/win/svg/custom/subpaths-moveto-only-rendering-expected.png: Added.
  • platform/win/svg/custom/subpaths-moveto-only-rendering-expected.txt: Added.
  • svg/custom/path-moveto-only-rendering.svg: Added.
  • svg/custom/subpaths-moveto-only-rendering.svg: Added.
  • svg/custom/zero-path-square-cap-rendering2-expected.txt: Modified text output
  • platform/chromium/test_expectations.txt: Added flakiness for new tests from this patch
08:36 Changeset [101804] by abecsi@webkit.org

[Qt][WK2] Set event timestamps on custom input events

Reviewed by Simon Hausmann.

Since r101791 WebEventFactoryQt uses input event timestamps for WebEvents,
thus set the timestamp on the custom events as well.

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::handleHoverLeaveEvent):
(QtWebPageEventHandler::handleHoverMoveEvent):

  • UIProcess/qt/WebPopupMenuProxyQtDesktop.cpp:

(WebKit::WebPopupMenuProxyQtDesktop::showPopupMenu):

08:33 Changeset [101803] by aroben@apple.com

Teach check-webkit-style how to check the syntax of JSON files

Fixes <http://webkit.org/b/73590> check-webkit-style doesn't flag JSON syntax errors

I previously landed this patch as r101711, but the new tests failed on Snow Leopard. This
patch is identical to that one except for two change: assertIn(a, b) (which is new to Python
2.7) has been replaced with assertTrue(a in b), and the test_missing_closing_brace test has
been removed, since its output differs by platform.

Reviewed by Darin Adler.

  • Scripts/webkitpy/style/checker.py:

(_all_categories): Added JSONChecker's categories to the set of all categories.
(FileType): Added a JSON type. Incremented other types.
(CheckerDispatcher._file_type): Use the JSON file type for .json files.
(CheckerDispatcher._create_checker): Use a JSONChecker for JSON files.

  • Scripts/webkitpy/style/checker_unittest.py:

(CheckerDispatcherDispatchTest.assert_checker_json): Added this helper method.
(CheckerDispatcherDispatchTest.test_json_paths): Added. Based on test_python_paths.

  • Scripts/webkitpy/style/checkers/jsonchecker.py: Added. (I didn't name this just "json",

which would have matched our other checkers, because I couldn't figure out how to call
"json.loads" without hitting namespace conflicts.)
(JSONChecker.init): Turn of line filtering so that we always check the whole file, not
just the modified lines from a patch.
(JSONChecker.check): Try to parse the lines as JSON. Mark an error if there was an
exception.
(JSONChecker.line_number_from_json_exception): Parse the json modules exception message to
try to extract a line number.

  • Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Added.

(MockErrorHandler.init):
(MockErrorHandler.turn_off_line_filtering):
(MockErrorHandler.call):
Helper class. Copied from xml_unittest.py.

(JSONCheckerTest.test_line_number_from_json_exception): Test the
line_number_from_json_exception helper method.

(JSONCheckerTest.assert_no_error):
(JSONCheckerTest.assert_error):
Helper methods to assert that we did or didn't get an error.

(JSONCheckerTest.mock_handle_style_error): Helper method.

(JSONCheckerTest.test_conflict_marker):
(JSONCheckerTest.test_single_quote):
(JSONCheckerTest.test_init):
(JSONCheckerTest.test_no_error):
Test various cases.

08:30 Changeset [101802] by kov@webkit.org

[GTK] Also run DumpRenderTree under jhbuild
https://bugs.webkit.org/show_bug.cgi?id=73646

Reviewed by Martin Robinson.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkDriver.cmd_line):

08:30 Changeset [101801] by ossy@webkit.org

MacroAssemblerSH4 does not implement readCallTarget
https://bugs.webkit.org/show_bug.cgi?id=73434

Patch by Zoltan Herczeg <zherczeg@webkit.org> on 2011-12-02
Reviewed by Csaba Osztrogonác.

  • assembler/SH4Assembler.h:

(JSC::SH4Assembler::readCallTarget): Support for SH4.

08:17 Changeset [101800] by ossy@webkit.org

[Qt] fast/forms/select/listbox-in-multi-column.html fails
https://bugs.webkit.org/show_bug.cgi?id=73660

  • platform/qt/Skipped: Skip fast/forms/select/listbox-in-multi-column.html until fix.
08:16 Changeset [101799] by alex@webkit.org

2011-12-02 Alejandro G. Castro <alex@igalia.com>

[GTK] Fix TextureMapperCairo compilation
https://bugs.webkit.org/show_bug.cgi?id=73655

Reviewed by Martin Robinson.

  • GNUmakefile.am: The variables need the USE part in the name.
  • configure.ac: We can not define the variable twice.
08:14 Changeset [101798] by apavlov@chromium.org

[Chromium] Unreviewed expectation fix after r101787.

  • platform/chromium/svg/css/getComputedStyle-basic-expected.txt:
07:51 Changeset [101797] by vsevik@chromium.org

Unreviewed, rolling out r101794.
http://trac.webkit.org/changeset/101794
https://bugs.webkit.org/show_bug.cgi?id=73656

Broke win build (Requested by vsevik on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-02

  • bindings/js/ScriptCallStackFactory.cpp:
  • bindings/js/ScriptCallStackFactory.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheck):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateFunctionCallback):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::customArgsAndExceptionCallback):

  • bindings/v8/ScriptCallStackFactory.cpp:
  • bindings/v8/ScriptCallStackFactory.h:
  • inspector/InspectorInstrumentation.cpp:
  • inspector/InspectorInstrumentation.h:
  • inspector/WorkerInspectorController.h:
  • page/Console.cpp:

(WebCore::Console::shouldCaptureFullStackTrace):

  • page/Console.h:
07:32 Changeset [101796] by commit-queue@webkit.org

Unreviewed, revert r101347.
https://bugs.webkit.org/show_bug.cgi?id=73580

It breaks the linking of Tools/ targets due to missing functions.

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-12-02

.:

  • Source/cmake/OptionsEfl.cmake:

Source/WebCore:

  • PlatformEfl.cmake:
  • platform/graphics/GraphicsLayer.cpp:
  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/efl/GraphicsLayerEfl.cpp: Added.

(WebCore::GraphicsLayer::create):
(WebCore::GraphicsLayerEfl::GraphicsLayerEfl):
(WebCore::GraphicsLayerEfl::~GraphicsLayerEfl):
(WebCore::GraphicsLayerEfl::setNeedsDisplay):
(WebCore::GraphicsLayerEfl::setNeedsDisplayInRect):

  • platform/graphics/efl/GraphicsLayerEfl.h: Added.
  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::solveCubicBezierFunction):
(WebCore::solveStepsFunction):

07:27 Changeset [101795] by vsevik@chromium.org

Unreviewed, updated chromium test expectations.

  • platform/chromium/fast/events/offsetX-offsetY-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/events/offsetX-offsetY-expected.txt.
07:24 Changeset [101794] by vsevik@chromium.org

Web Inspector: Extract default call stack creation and check for front-end from console.
https://bugs.webkit.org/show_bug.cgi?id=73566

Reviewed by Yury Semikhatsky.

  • bindings/js/ScriptCallStackFactory.cpp:

(WebCore::createScriptCallStack):

  • bindings/js/ScriptCallStackFactory.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheck):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateFunctionCallback):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::customArgsAndExceptionCallback):

  • bindings/v8/ScriptCallStackFactory.cpp:

(WebCore::createScriptCallStack):

  • bindings/v8/ScriptCallStackFactory.h:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::hasFrontendForScriptContext):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::hasFrontendForScriptContext):

  • inspector/WorkerInspectorController.h:

(WebCore::WorkerInspectorController::hasFrontend):

  • page/Console.cpp:
  • page/Console.h:
07:17 Changeset [101793] by philn@webkit.org

Unreviewed, skip some new GTK multicol failures because of bug 73653.

  • platform/gtk/Skipped:
07:15 Changeset [101792] by gavinp@chromium.org

Remove instrumentation tracking a fixed bug
https://bugs.webkit.org/show_bug.cgi?id=73471

The underlying bug is fixed (bug 72068), and this instrumentation was intrusive and using
memory, plus the conditional compilation made me sad.

Reviewed by Nate Chapin.

No new tests.

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::ScriptElement):
(WebCore::ScriptElement::requestScript):
(WebCore::ScriptElement::stopLoadRequest):
(WebCore::ScriptElement::notifyFinished):

  • dom/ScriptElement.h:
  • dom/ScriptRunner.cpp:

(WebCore::ScriptRunner::queueScriptForExecution):

06:45 Changeset [101791] by abecsi@webkit.org

[Qt] [WK2] Use input event timestamps in WebEvents if available
https://bugs.webkit.org/show_bug.cgi?id=73647

Reviewed by Simon Hausmann.

Qt5 input events already have a native timestamp, use this timestamp
in WebEventFactory instead of WTF::currentTime if it is available.

  • Shared/qt/WebEventFactoryQt.cpp:

(WebKit::currentTimeForEvent):
(WebKit::WebEventFactory::createWebMouseEvent):
(WebKit::WebEventFactory::createWebWheelEvent):
(WebKit::WebEventFactory::createWebKeyboardEvent):
(WebKit::WebEventFactory::createWebTouchEvent):

  • Shared/qt/WebEventFactoryQt.h:
06:44 Changeset [101790] by vsevik@chromium.org

Web Inspector: Split view works weirdly in network panel when resizing, showing/hiding main element.
https://bugs.webkit.org/show_bug.cgi?id=73650

Reviewed by Pavel Feldman.

  • inspector/front-end/SplitView.js:

(WebInspector.SplitView.prototype._updateResizer):
(WebInspector.SplitView.prototype.hideMainElement):
(WebInspector.SplitView.prototype.showMainElement):
(WebInspector.SplitView.prototype.onResize):
(WebInspector.SplitView.prototype._restoreSidebarWidth):

06:15 Changeset [101789] by vsevik@chromium.org

Unreviewed, rolling out r101783.
http://trac.webkit.org/changeset/101783
https://bugs.webkit.org/show_bug.cgi?id=73652

Broke chromium win build. (Requested by vsevik on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-02

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/action_derivedsourcesallinone.py:

(main):

  • WebCore.gypi:
  • bindings/scripts/generate-bindings.pl:
  • page/DOMWindow.idl:
  • webaudio/DOMWindowWebAudio.idl: Removed.
05:37 Changeset [101788] by jesus@webkit.org

[Qt][WK2] Split the QtWebPageProxy into PageClient and QtPageProxy
https://bugs.webkit.org/show_bug.cgi?id=66668

Reviewed by Simon Hausmann.

Split QtPageClient out of QtWebPageProxy.
This client will live in QQuickWebViewPrivate and communicate directly
with QtWebPageProxy and QtWebPageEventHandler. The functions that need
anything else than these entities will need to call the proper implementation
through QtWebPageProxy itself.
With this we have a clear separation between PageClient and PageProxy, having
two well defined and separated entities for hooking our clients with our API layer (QtWebPageProxy)
and for hooking the WebPageProxy with our client implementations (QtPageClient).
As a positive side-effect we have a cleaner QtWebPageProxy.

  • Target.pri:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):

  • UIProcess/API/qt/qquickwebview_p_p.h:
  • UIProcess/qt/QtPageClient.cpp: Added.

(QtPageClient::QtPageClient):
(QtPageClient::~QtPageClient):
(QtPageClient::createDrawingAreaProxy):
(QtPageClient::setViewNeedsDisplay):
(QtPageClient::pageDidRequestScroll):
(QtPageClient::processDidCrash):
(QtPageClient::didRelaunchProcess):
(QtPageClient::didChangeContentsSize):
(QtPageClient::didChangeViewportProperties):
(QtPageClient::startDrag):
(QtPageClient::handleDownloadRequest):
(QtPageClient::setCursor):
(QtPageClient::setCursorHiddenUntilMouseMoves):
(QtPageClient::toolTipChanged):
(QtPageClient::registerEditCommand):
(QtPageClient::clearAllEditCommands):
(QtPageClient::canUndoRedo):
(QtPageClient::executeUndoRedo):
(QtPageClient::convertToDeviceSpace):
(QtPageClient::convertToUserSpace):
(QtPageClient::screenToWindow):
(QtPageClient::windowToScreen):
(QtPageClient::createPopupMenuProxy):
(QtPageClient::createContextMenuProxy):
(QtPageClient::flashBackingStoreUpdates):
(QtPageClient::didFindZoomableArea):
(QtPageClient::didReceiveMessageFromNavigatorQtObject):
(QtPageClient::doneWithTouchEvent):
(QtPageClient::displayView):
(QtPageClient::scrollView):
(QtPageClient::viewSize):
(QtPageClient::isViewWindowActive):
(QtPageClient::isViewFocused):
(QtPageClient::isViewVisible):
(QtPageClient::isViewInWindow):
(QtPageClient::enterAcceleratedCompositingMode):
(QtPageClient::exitAcceleratedCompositingMode):

  • UIProcess/qt/QtPageClient.h: Added.

(QtPageClient::pageClosed):
(QtPageClient::doneWithKeyEvent):
(QtPageClient::setFindIndicator):
(QtPageClient::didCommitLoadForMainFrame):
(QtPageClient::didFinishLoadingDataForCustomRepresentation):
(QtPageClient::customRepresentationZoomFactor):
(QtPageClient::setCustomRepresentationZoomFactor):
(QtPageClient::didChangeScrollbarsForMainFrame):
(QtPageClient::findStringInCustomRepresentation):
(QtPageClient::countStringMatchesInCustomRepresentation):
(QtPageClient::setEventHandler):
(QtPageClient::setPageProxy):

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):

  • UIProcess/qt/QtWebPageProxy.h:
05:32 Changeset [101787] by apavlov@chromium.org

Inline non-replaced elements are reported to have zero width and height
https://bugs.webkit.org/show_bug.cgi?id=61117

Reviewed by Antti Koivisto.

Source/WebCore:

According to http://www.w3.org/TR/CSS21/visudet.html, the "width" and "height" properties
do not apply for inline non-replaced elements and should have their initial value of "auto"
as their computed values.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

  • fast/dom/beforeload/image-object-before-load-innerHTML.html:
  • fast/dom/beforeload/image-object-before-load.html:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
04:58 Changeset [101786] by philn@webkit.org

Unreviewed, GTK rebaseline.

  • platform/gtk/Skipped: plugins/invalidate_rect.html was removed. Also skip one more SVG test.
  • platform/gtk/fast/writing-mode/broken-ideograph-small-caps-expected.txt:
  • platform/gtk/fonts/custom-font-missing-glyphs-expected.txt:
  • platform/gtk/fonts/fontconfig-synthetic-bold-expected.txt:
04:34 Changeset [101785] by commit-queue@webkit.org

[chromium] Make CCInputHandler scrolling stateful
https://bugs.webkit.org/show_bug.cgi?id=73345

This change makes the scrolling part of CCInputHandler stateful by
replacing scrollRootLayer() with scrollBegin(), scrollBy() and
scrollEnd(). This is done in preparation for scrollable sublayers.
Specifically, scrollBegin() will allow CCLayerTreeHostImpl to perform
input event hit testing to find the layer to be scrolled.

Patch by Sami Kyostila <skyostil@chromium.org> on 2011-12-02
Reviewed by Steve Block.

Source/WebCore:

Tested in CCLayerTreeHostImplTest.

  • platform/graphics/chromium/cc/CCInputHandler.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::currentTimeMs):
(WebCore::CCLayerTreeHostImpl::setNeedsRedraw):
(WebCore::findInnermostScrollableLayerAtPoint):
(WebCore::CCLayerTreeHostImpl::scrollBegin):
(WebCore::CCLayerTreeHostImpl::scrollBy):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

Source/WebKit/chromium:

  • src/WebCompositorImpl.cpp:

(WebKit::WebCompositorImpl::handleInputEvent):

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::TEST_F):

04:34 Changeset [101784] by alex@webkit.org

2011-12-02 Alejandro G. Castro <alex@igalia.com>

[GTK] Improve C++0x compat warnings check
https://bugs.webkit.org/show_bug.cgi?id=73642

Reviewed by Martin Robinson.

  • configure.ac:
04:13 Changeset [101783] by haraken@chromium.org

Use the [Supplemental] IDL for webaudio attributes in Chromium
https://bugs.webkit.org/show_bug.cgi?id=73394

Reviewed by Adam Barth.

  • Overview: Using the [Supplemental] IDL, this patch moves the attribute

declarations of webaudio from DOMWindow.idl into a new IDL file
webaudio/DOMWindowWebAudio.idl, which helps make webaudio a self-contained
feature (aka a module).

  • This patch changes the build flow of WebCore.gyp as follows:

Previous build flow:

foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl;
generate-bindings.pl reads $idl;
generate-bindings.pl generates .h and .cpp files for $idl;

}

New build flow (See the discussions in bug 72138 for more details):

resolve-supplemental.pl depends on all IDL files;
resolve-supplemental.pl reads all IDL files;
resolve-supplemental.pl resolves the dependency of [Supplemental=XXXX];
resolve-supplemental.pl outputs supplemental_dependency.tmp;
foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
generate-bindings.pl reads $idl;
generate-bindings.pl reads supplemental_dependency.tmp;
generate-bindings.pl generates .h and .cpp files for $idl, including all attributes in IDL files whilementing $idl;

}

  • This patch introduces a temporary IDL, [Supplemented]. The [Supplemented] IDL

will be removed after build scripts for all platforms support the [Supplemental] IDL.
The motivation for the [Supplemented] IDL is as follows:

In order to support the [Supplemental] IDL, we need to
(1) run resolve-supplemental.pl and generate supplemental_dependency.tmp
(2) and run generate-bindings.pl with the supplemental_dependency.tmp.

This build flow requires a change on the following build scripts,
but changing all the build scripts all at once without any regression is too difficult:

  • DerivedSources.make
  • DerivedSources.pri
  • GNUmakefile.am
  • PlatformBlackBerry.cmake
  • UseJSC.cmake
  • UseV8.cmake
  • WebCore.vcproj/MigrateScripts
  • WebCore.vcproj/WebCore.vcproj
  • bindings/gobject/GNUmakefile.am
  • WebCore.gyp/WebCore.gyp

Thus, we are planning to change the build scripts one by one, which implies that
we need to allow the temporary state in which some build scripts support [Supplemental] IDL
but others do not. To accomplish this, we introduce a temporary IDL, [Supplemented].
The [Supplemented] IDL on an attribute means that the attribute is marked with [Supplemental]
in another IDL file somewhere, like this:

DOMWindowWebAudio.idl:

interface [

Supplemental=DOMWindow

] DOMWindowWebAudio {

attribute attr1;
attribute attr2;

};

DOMWindow.idl:

interface [
] DOMWindow {

attribute [Supplemented] attr1; This line will be removed after all build scripts support the [Su IDL
attribute [Supplemented] attr2;
This line will be removed after all build scripts support the [Su IDL.
attribute attr3;
attribute attr4;

};

Assuming these IDL files, this patch implements the following logic in generate-bindings.pl:

  • If a given build script supports the [Supplemental] IDL, generate-bindings.pl ignores all attributes with the [Supplemented] IDL.
  • Otherwise, generate-bindings.pl treats all attributes with the [Supplemented] IDL as normal attributes and instead ignores all attributes with the [Supplemental] IDL (i.e. generate-bindings.pl generates nothing from the IDL file with the [Supplemental] IDL).

Tests: webaudio/*

  • WebCore.gyp/WebCore.gyp: Describes the build flow that I described above.
  • WebCore.gyp/scripts/action_derivedsourcesallinone.py:

(main): Reads the IDL file names from the input file (i.e. supplemental_dependency.tmp), which are described at the first column of each line in the input file.

  • WebCore.gypi: Added DOMWindowWebAudio.idl.
  • bindings/scripts/generate-bindings.pl: As a temporary solution, if the platform does not support the [Supplemental] IDL, the perl script ignores the [Supplemental] IDL and instead uses the [Supplemented] IDL. Otherwise, the perl script ignores the [Supplemented] IDL and instead uses the [Supplemental] IDL.
  • page/DOMWindow.idl: Added the [Supplemented] IDL to webaudio-related attributes. As I described above, the [Supplemented] IDL will be removed after all platforms support the [Supplemental] IDL.
  • webaudio/DOMWindowWebAudio.idl: Added. Describes the [Supplemental=DOMWindow] IDL. The attributes in this IDL file should be treated as if they are written in DOMWindow.idl.
04:10 Changeset [101782] by vsevik@chromium.org

Web Inspector: Network panel row highlighting does not work.
https://bugs.webkit.org/show_bug.cgi?id=73644

Reviewed by Pavel Feldman.

  • inspector/front-end/networkLogView.css:

(.network-log-grid tr.highlighted-row):
(from):
(to):

03:53 Changeset [101781] by kenneth@webkit.org

[Qt] Do not apply the transition state before we are unsuspended

Reviewed by Simon Hausmann.

Also remove an accessor in the private, which is unneeded as
everything in the private class is supposed to be public or
only used by the private itself.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::loadDidCommit):
(QQuickWebViewPrivate::didFinishFirstNonEmptyLayout):
(QQuickWebViewPrivate::_q_suspend):
(QQuickWebViewPrivate::_q_resume):
(QQuickWebViewPrivate::didChangeContentsSize):
(QQuickWebViewPrivate::didChangeViewportProperties):

  • UIProcess/API/qt/qquickwebview_p_p.h:
03:52 Changeset [101780] by kenneth@webkit.org

Unreviewed buildfix, add missing include.

  • WebProcess/Notifications/WebNotificationManager.cpp:
03:50 Changeset [101779] by pfeldman@chromium.org

Not reviewed: remove console.timeStamp from the inspector backend dispatcher.

  • inspector/front-end/InspectorBackend.js:

(InspectorBackendClass.prototype.sendMessageObjectToBackend):

03:41 Changeset [101778] by morrita@google.com

Unreviewed, rolling out r101751 and r101775.
http://trac.webkit.org/changeset/101751
http://trac.webkit.org/changeset/101775
https://bugs.webkit.org/show_bug.cgi?id=73191

breaks Windows build

Source/JavaScriptCore:

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • config.h:
  • runtime/JSExportMacros.h: Removed.
  • wtf/ExportMacros.h:
  • wtf/Platform.h:
  • wtf/WTFThreadData.h:
  • wtf/text/AtomicString.h:
  • wtf/text/StringStatics.cpp:

Source/JavaScriptGlue:

  • ForwardingHeaders/runtime/JSExportMacros.h: Removed.
  • ForwardingHeaders/wtf/ExportMacros.h: Removed.
  • config.h:

Source/WebCore:

  • ForwardingHeaders/runtime/JSExportMacros.h: Removed.
  • ForwardingHeaders/wtf/ExportMacros.h: Removed.
  • WebCore.vcproj/QTMovieWinCommon.vsprops:
  • WebCore.xcodeproj/project.pbxproj:
  • config.h:
  • platform/PlatformExportMacros.h: Removed.

Source/WebKit/cf:

  • WebCoreSupport/WebInspectorClientCF.cpp:

Source/WebKit/mac:

  • WebKitPrefix.h:

Source/WebKit/qt:

  • tests/MIMESniffing/MIMESniffing.pro:

Source/WebKit2:

  • config.h:

Tools:

  • DumpRenderTree/chromium/config.h:
  • DumpRenderTree/config.h:
  • TestWebKitAPI/config.h:
  • WebKitTestRunner/config.h:
03:37 Changeset [101777] by pfeldman@chromium.org

Web Inspector: introduce backend stub generation from JSON for the standalone development / remote front-ends.
https://bugs.webkit.org/show_bug.cgi?id=73636

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DOMStorage.js:
  • inspector/front-end/Database.js:
  • inspector/front-end/InspectorBackend.js:

(InspectorBackendClass):
(InspectorBackendClass.prototype.registerCommand):
(InspectorBackendClass.prototype.registerEvent):
(InspectorBackendClass.prototype.runAfterPendingDispatches):
(InspectorBackendClass.prototype.loadFromJSONIfNeeded):

  • inspector/front-end/TimelineManager.js:
  • inspector/front-end/inspector.js:
03:19 Changeset [101776] by vsevik@chromium.org

Unreviewed, updated test expectations.

  • platform/chromium/test_expectations.txt:
03:14 Changeset [101775] by morrita@google.com

Unreviewed, another attempt to build fix for r101751:
Adding an include path to make PlatformExportMacros.h visibile from QTMovieWin.

Patch by MORITA Hajime <morrita@google.com> on 2011-12-02

  • WebCore.vcproj/QTMovieWinCommon.vsprops:
03:09 Changeset [101774] by vsevik@chromium.org

Unreviewed test expectations.

  • platform/chromium-mac/fast/events/offsetX-offsetY-expected.txt: Renamed from LayoutTests/platform/gtk/fast/events/offsetX-offsetY-expected.txt.
03:08 Changeset [101773] by morrita@google.com

Unreviewed, rolling out r101772.
http://trac.webkit.org/changeset/101772

It didn't fix the build failure

  • WebCore.vcproj/QTMovieWinCommon.vsprops:
02:55 Changeset [101772] by morrita@google.com

2011-12-02 MORITA Hajime <morrita@google.com>

Unreviewed attempt to build fix for r101751:
Adding an include path to make PlatformExportMacros.h visibile from QTMovieWin.

  • WebCore.vcproj/QTMovieWinCommon.vsprops:
02:52 Changeset [101771] by philn@webkit.org

Unreviewed, GTK rebaseline after r101723 and skipping another set
of svg tests show 1px differences.

  • platform/gtk/Skipped:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
02:20 Changeset [101770] by carlosgc@webkit.org

Unreviewed. Fix GTK+ build after r101750.

  • GNUmakefile.am: Add missing files.
02:17 Changeset [101769] by caseq@chromium.org

Web Inspector: [Extensions API] pass preferred resource line number to extension's open resource handler
https://bugs.webkit.org/show_bug.cgi?id=73084

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/ExtensionAPI.js:

(injectedExtensionAPI.Panels.prototype.setOpenResourceHandler.else.callbackWrapper):
(injectedExtensionAPI.Panels.prototype.setOpenResourceHandler):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._handleOpenURL):

  • inspector/front-end/HandlerRegistry.js:

(get WebInspector.HandlerRegistry.prototype.set dispatch):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.populateTextAreaContextMenu):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.populateLineGutterContextMenu):
(WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.populateLineGutterContextMenu):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.populateTextAreaContextMenu):

  • inspector/front-end/TextViewer.js:

(WebInspector.TextViewer.prototype._contextMenu):
(WebInspector.TextViewerDelegate.prototype.populateLineGutterContextMenu):
(WebInspector.TextViewerDelegate.prototype.populateTextAreaContextMenu):

  • inspector/front-end/externs.js:

(WebInspector.populateResourceContextMenu):

  • inspector/front-end/inspector.js:

(WebInspector.populateResourceContextMenu):
(WebInspector._showAnchorLocation):

LayoutTests:

  • inspector/extensions/extensions-resources-expected.txt:
  • inspector/extensions/extensions-resources.html:
02:14 Changeset [101768] by kov@webkit.org

Unreviewed. GTK+ build fix.

  • GNUmakefile.am:
01:31 Changeset [101767] by haraken@chromium.org

Move run-bindings-tests implementation to webkitpy/bindings/main.py
https://bugs.webkit.org/show_bug.cgi?id=73619

Reviewed by Adam Barth.

As run-bindings-tests has been growing, this patch just moves its implementation
to webkitpy/bindings/main.py to integrate with the rest of webkitpy.

No change in behavior.

  • Scripts/run-bindings-tests:

(main):

  • Scripts/webkitpy/bindings/init.py: Added.
  • Scripts/webkitpy/bindings/main.py: Added.

(BindingsTests.init):
(BindingsTests.generate_from_idl):
(BindingsTests.generate_supplemental_dependency):
(BindingsTests.detect_changes):
(BindingsTests.run_tests):

01:24 Changeset [101766] by vsevik@chromium.org

Unreviewed, added custom chromium test expectations.

  • platform/chromium/fast/images/image-css3-content-data-expected.png: Added.
01:18 Changeset [101765] by philn@webkit.org

[GTK] scrollbars interfering with fullscreen (in-window) video rendering
https://bugs.webkit.org/show_bug.cgi?id=73577

Reviewed by Martin Robinson.

Disable scrollbars when switching to fullscreen.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::contentsSizeChanged): Ignore size changes
when an element is being displayed fullscreen.
(WebKit::ChromeClient::enterFullScreenForElement): Disable
scrollbars when entering fullscreen.

  • WebCoreSupport/GtkAdjustmentWatcher.cpp: Added 2 methods to

enable/disable scrollbars and one method to know whether they are
enabled or not.
(WebKit::GtkAdjustmentWatcher::GtkAdjustmentWatcher):
(WebKit::updateAdjustmentFromScrollbar):
(WebKit::GtkAdjustmentWatcher::updateAdjustmentsFromScrollbars):
(WebKit::GtkAdjustmentWatcher::updateAdjustmentsFromScrollbarsLater):
(WebKit::GtkAdjustmentWatcher::disableAllScrollbars):
(WebKit::GtkAdjustmentWatcher::enableAllScrollbars):

  • WebCoreSupport/GtkAdjustmentWatcher.h:

(WebKit::GtkAdjustmentWatcher::scrollbarsDisabled):

01:16 Changeset [101764] by mrobinson@webkit.org

[GTK] Add compilation options to enable/disable Accelerated Compositing and to choose texture mapper implementation.
https://bugs.webkit.org/show_bug.cgi?id=73458

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-12-01
Reviewed by Martin Robinson.

.:

  • GNUmakefile.am: Export new compilation macros.
  • configure.ac: Provide option to choose accelerated compositing and texture mapper variations.

Source/WebCore:

No new tests added as this patch doesn't affect any functionality.

  • GNUmakefile.am: Guard the include files.
  • GNUmakefile.list.am: Guard the compilation of few files.
  • platform/graphics/GraphicsLayer.h: Guard the typedef of GraphicsLayer.
01:15 Changeset [101763] by commit-queue@webkit.org

[Qt][WK2] ASSERT at QQuickWebViewPrivate::computeViewportConstraints() when API test is exercising zero sized views.
https://bugs.webkit.org/show_bug.cgi?id=73441

Do not assert on empty available size, but return default constrain values instead.

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2011-12-02
Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::computeViewportConstraints):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::dispatchViewportPropertiesDidChange):

01:12 Changeset [101762] by rniwa@webkit.org

Now that r101733 fixed fast/block/child-not-removed-from-parent-lineboxes-crash.html,
remove the failing expectation on Chromium and re-enable it on Qt.

  • platform/chromium/test_expectations.txt:
  • platform/qt/Skipped:
01:09 Changeset [101761] by pfeldman@chromium.org

Web Inspector [chromium]: provisional fix for interactive ui tests
https://bugs.webkit.org/show_bug.cgi?id=73633

Reviewed by Yury Semikhatsky.

  • src/js/Tests.js:

(.):
(.TestSuite.prototype._executeCodeWhenScriptsAreParsed):

01:06 Changeset [101760] by caseq@chromium.org

Web Inspector: use object properties, not element attributes to pass preferred panel/line/request id in linkified anchors
https://bugs.webkit.org/show_bug.cgi?id=73556

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/AuditFormatters.js:

(WebInspector.AuditFormatters.resourceLink):

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._formatMessage.else.else.linkifier):
(WebInspector.ConsoleMessageImpl.prototype._formatMessage):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkPanel.prototype._resourceByAnchor):
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):

  • inspector/front-end/ResourceUtils.js:

(WebInspector.linkifyStringAsFragment):
(WebInspector.linkifyResourceAsNode):
(WebInspector.linkifyRequestAsNode):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.showAnchorLocation):

  • inspector/front-end/inspector.js:

(WebInspector._showAnchorLocation):

LayoutTests:

  • inspector/extensions/extensions-audits-expected.txt:
  • inspector/extensions/extensions-audits.html:
00:58 Changeset [101759] by levin@chromium.org

[chromium] Add WebKit API's to support the autosize algorithm in renderer process.
https://bugs.webkit.org/show_bug.cgi?id=73058

Reviewed by Darin Fisher.

  • public/WebView.h: Expose the auto-resize method.
  • public/WebWidgetClient.h:

(WebKit::WebWidgetClient::didAutoResize):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::createFrameView): Set the auto-resize
state on the new view.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::resize): Extracted sendResizeEventAndRepaint, so
that it can be used by layoutUpdated.
(WebKit::WebViewImpl::queueBothResizeEventAndPaint): Ditto.
(WebKit::WebViewImpl::hasHorizontalScrollbar): Added for testing purposes.
(WebKit::WebViewImpl::hasVerticalScrollbar): Ditto.
(WebKit::WebViewImpl::enableAutoResizeMode): Set-up auto-resize.
(WebKit::WebViewImpl::layoutUpdated): Handle the auto-resize case by
sending events and invalidation.

  • src/WebViewImpl.h: Expose the aut-reosize information.

(WebKit::WebViewImpl::shouldAutoResize):
(WebKit::WebViewImpl::minAutoSize):
(WebKit::WebViewImpl::maxAutoSize):

  • tests/FrameTestHelpers.cpp:

(WebKit::FrameTestHelpers::createWebViewAndLoad): Added the ability to
specify the WebViewClient.

  • tests/FrameTestHelpers.h: Ditto.
  • tests/WebViewTest.cpp: Added a simple test for auto-resize.

(WebKit::TestData::setWebView):
(WebKit::TestData::setSize): Capture the new size.
(WebKit::TestData::hasHorizontalScrollbar):
(WebKit::TestData::hasVerticalScrollbar):
(WebKit::TestData::width):
(WebKit::TestData::height):
(WebKit::AutoResizeWebViewClient::didAutoResize): Handle the resize event.
(WebKit::AutoResizeWebViewClient::testData):
(WebKit::TEST_F): The actual test.

  • tests/data/specify_size.html: Added.
00:55 Changeset [101758] by commit-queue@webkit.org

[Chromium] Support adding/removing page overlay to WebView
https://bugs.webkit.org/show_bug.cgi?id=73235

Patch by Xiyuan Xia <xiyuan@chromium.org> on 2011-12-02
Reviewed by James Robinson.

  • WebKit.gyp:
  • public/WebPageOverlay.h: Added.

(WebKit::WebPageOverlay::~WebPageOverlay):

  • public/WebView.h:
  • src/PageOverlay.cpp:

(WebKit::PageOverlay::create):
(WebKit::PageOverlay::PageOverlay):
(WebKit::OverlayGraphicsLayerClientImpl::create):
(WebKit::OverlayGraphicsLayerClientImpl::paintContents):
(WebKit::OverlayGraphicsLayerClientImpl::OverlayGraphicsLayerClientImpl):
(WebKit::PageOverlay::update):
(WebKit::PageOverlay::paintWebFrame):
(WebKit::PageOverlay::invalidateWebFrame):

  • src/PageOverlay.h:

(WebKit::PageOverlay::overlay):
(WebKit::PageOverlay::setOverlay):
(WebKit::PageOverlay::zOrder):
(WebKit::PageOverlay::setZOrder):

  • src/PageOverlayList.cpp: Added.

(WebKit::PageOverlayList::create):
(WebKit::PageOverlayList::PageOverlayList):
(WebKit::PageOverlayList::~PageOverlayList):
(WebKit::PageOverlayList::add):
(WebKit::PageOverlayList::remove):
(WebKit::PageOverlayList::update):
(WebKit::PageOverlayList::paintWebFrame):
(WebKit::PageOverlayList::find):

  • src/PageOverlayList.h: Added.

(WebKit::PageOverlayList::empty):

  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::paintPageOverlay):
(WebKit::WebDevToolsAgentImpl::highlight):
(WebKit::WebDevToolsAgentImpl::hideHighlight):

  • src/WebDevToolsAgentImpl.h:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::paintWithContext):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::composite):
(WebKit::WebViewImpl::addPageOverlay):
(WebKit::WebViewImpl::removePageOverlay):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::didRecreateGraphicsContext):

  • src/WebViewImpl.h:

(WebKit::WebViewImpl::pageOverlays):

00:49 BuildingGtk edited by mrobinson@webkit.org
(diff)
00:44 Changeset [101757] by loislo@chromium.org

Tools/Scripts: eliminate find_test_files from Port class.
https://bugs.webkit.org/show_bug.cgi?id=73553

rebaseline.py and chromium_gpu.py use Port.find_test_files() the same way as it is used in Port.tests()
I'd like to replace all calls to find_test_files with tests and eliminate find_tests_files.
Also I'll move _is_test_file() and related functions close to Port.tests().

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.tests):
(Port.is_reference_html_file):
(Port._has_supported_extension):
(Port._is_test_file):

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_find_no_paths_specified):
(PortTest.test_find_one_test):
(PortTest.test_find_glob):
(PortTest.test_find_with_skipped_directories):
(PortTest.test_find_with_skipped_directories_2):
(PortTest.test_is_test_file):

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

(_default_tests_paths):
(ChromiumGpuLinuxPort.tests):
(ChromiumGpuCgMacPort.tests):
(ChromiumGpuMacPort.tests):

  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:

(ChromiumGpuTest.test_default_tests_paths.test_paths):
(ChromiumGpuTest.test_default_tests_paths):
(ChromiumGpuTest.test_test_files.test_paths):
(ChromiumGpuTest):
(ChromiumGpuTest.test_test_files):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(get_tests_run.RecordingTestDriver.run_test):

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(OptimizeBaselines._optimize_baseline):
(OptimizeBaselines.execute):
(AnalyzeBaselines._analyze_baseline):
(AnalyzeBaselines.execute):

00:30 Changeset [101756] by pfeldman@chromium.org

Web Inspector: refactor InspectorBackendDispatcher so that it does not use JSON-serialized command templates.
https://bugs.webkit.org/show_bug.cgi?id=73569

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/CodeGeneratorInspector.py:

(Generator.process_command):

  • inspector/Inspector.json:
  • inspector/front-end/InspectorBackend.js:

(InspectorBackendClass.prototype._wrap.callback):
(InspectorBackendClass.prototype._wrap):
(InspectorBackendClass.prototype.registerCommand):
(InspectorBackendClass.prototype._invoke):
(InspectorBackendClass.prototype._sendMessageToBackend):
(InspectorBackendClass.prototype._wrapCallbackAndSendMessageObject):

LayoutTests:

  • inspector/report-API-errors-expected.txt:
00:26 Changeset [101755] by commit-queue@webkit.org

Range sliders and spin buttons don't work with multi-columns.
https://bugs.webkit.org/show_bug.cgi?id=70898

Patch by Yosifumi Inoue <yosin@chromium.org> on 2011-12-02
Reviewed by Dan Bernstein.

Source/WebCore:

This patch makes RenderBlock::hitTestColumns and
RenderBoxModelObject::mapAbsoluteToLocal to handle point
in multi-column same logic.

In multi-column, coordinate of box model rendering object is different
from absolute coordinate.. Columns in box model rendering object spans
vertically rather than horizontally.

When absolute point is represented in (column[i]+dx, column[0]+dy),
it is (column[0]+dx, column[0] + columnHeight + dy) in box model
rendering object coordinate.

Tests: fast/events/document-elementFromPoint.html

fast/events/offsetX-offsetY.html
fast/forms/number/spin-in-multi-column.html
fast/forms/range/slider-in-multi-column.html
fast/forms/select/listbox-in-multi-column.html

  • rendering/RenderBlock.cpp:

(WebCore::ColumnRectIterator::ColumnRectIterator): Added
(WebCore::ColumnRectIterator::advance): Added
(WebCore::ColumnRectIterator::columnRect): Added
(WebCore::ColumnRectIterator::hasMore): Added
(WebCore::ColumnRectIterator::adjust): Added
(WebCore::ColumnRectIterator::update): Added
(WebCore::RenderBlock::hitTestColumns): Use ColumnRectIterator.
(WebCore::RenderBlock::adjustForColumnRect): Added

  • rendering/RenderBlock.h: Add adjustForColumnRect.
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::mapAbsoluteToLocalPoint): Call RenderBoxModelObject::mapAbsoluteToLocalPoint.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::mapAbsoluteToLocalPoint): Move from RenderInline::mapAbsoluteToLocalPoint and call RenderBlock::adjustForColumnRect.

  • rendering/RenderBoxModelObject.h: add mapAbsoluteToLocalPoint.
  • rendering/RenderInline.cpp: Move mapAbsoluteToLocalPoint to RenderBoxModelObject.
  • rendering/RenderInline.h: remove mapAbsoluteToLocalPoint.

LayoutTests:

  • fast/events/offsetX-offsetY-expected.txt: Change offset for "in-columns" test.
  • fast/events/offsetX-offsetY.html: Change offset for "in-columns" test.
  • fast/forms/listbox/listbox-in-multi-column-expected.txt: Added.
  • fast/forms/listbox/listbox-in-multi-column.html: Added.
  • fast/forms/number/spin-in-multi-column-expected.txt: Added.
  • fast/forms/number/spin-in-multi-column.html: Added.
  • fast/forms/range/slider-in-multi-column-expected.txt: Added.
  • fast/forms/range/slider-in-multi-column.html: Added.
  • platform/chromium-win/fast/events/offsetX-offsetY-expected.txt: Change offset for "in-columns" test.
  • platform/efl/fast/events/offsetX-offsetY-expected.txt: Change offset for "in-columns" test.
  • platform/gtk/fast/events/offsetX-offsetY-expected.txt: Change offset for "in-columns" test.
00:21 Changeset [101754] by pfeldman@chromium.org

InspectorController destruction order leads to use-after-free
https://bugs.webkit.org/show_bug.cgi?id=73582

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/InspectorBaseAgent.h:

(WebCore::InspectorBaseAgentInterface::discardAgent):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::~InspectorCSSAgent):
(WebCore::InspectorCSSAgent::discardAgent):

  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::~InspectorController):

  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::~InspectorDOMDebuggerAgent):
(WebCore::InspectorDOMDebuggerAgent::discardAgent):

  • inspector/InspectorDOMDebuggerAgent.h:

LayoutTests:

  • platform/chromium/test_expectations.txt:
00:05 Changeset [101753] by leo.yang@torchmobile.com.cn

image element with src attribute can't be replaced by content: url() style
https://bugs.webkit.org/show_bug.cgi?id=42840

Source/WebCore:

ImageLoader were updating renderer even if the renderer's image is
style generated content. This was wrong because if an image element
with src attribute and style="content: url(...)" attribute the
src image might override content image. The correct behavior should
be showing content image.

This patch is differentiating style generated RenderImage from the
normal RenderImage and keeps the RenderImageSource untouched if the
renderer is generated content.

Reviewed by Darin Adler.

Test: fast/images/image-css3-content-data.html

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::renderImageResource):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::RenderImage):

  • rendering/RenderImage.h:

(WebCore::RenderImage::setIsGeneratedContent):
(WebCore::RenderImage::isGeneratedContent):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):

LayoutTests:

Test case contains image element with src attribute and "content: url(...)"
style attribute.

Reviewed by Darin Adler.

  • fast/images/image-css3-content-data-expected.txt: Added.
  • fast/images/image-css3-content-data.html: Added.
  • fast/images/resources/green-24x24.jpg: Added.

12/01/11:

23:47 Changeset [101752] by levin@chromium.org

Add a way to automatically size a single frame to fit its content.
https://bugs.webkit.org/show_bug.cgi?id=73420

Reviewed by Dmitry Titov.

No new functionality exposed so no new tests. (There is a Chromium
specific test in https://bugs.webkit.org/show_bug.cgi?id=73058.)

  • page/FrameView.cpp:

(WebCore::FrameView::FrameView): Initialized the new variables.
(WebCore::FrameView::layout):
(WebCore::FrameView::autoSizeIfEnabled):
(WebCore::FrameView::enableAutoSizeMode):

  • page/FrameView.h:
23:33 Changeset [101751] by commit-queue@webkit.org

JS_INLINE and WTF_INLINE should be visible from WebCore
https://bugs.webkit.org/show_bug.cgi?id=73191

Source/JavaScriptCore:

  • Moved Export related macro definitions from config.h to ExportMacros.h and JSExportMacros.h.
  • Moved WTF_USE_JSC and WTF_USE_V8 from various config.h family to Platform.h.
  • Replaced JS_EXPORTDATA in wtf moudule with newly introduced WTF_EXPORTDATA.

Patch by Hajime Morrita <morrita@chromium.org> on 2011-12-01
Reviewed by Kevin Ollivier.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • config.h:
  • runtime/JSExportMacros.h: Added.
  • wtf/ExportMacros.h:
  • wtf/Platform.h:
  • wtf/WTFThreadData.h:
  • wtf/text/AtomicString.h:
  • wtf/text/StringStatics.cpp:

Source/JavaScriptGlue:

  • Extracted export related macro definitions to ExportMacros.h and JSExportMacros.h
  • Added forwarding headers which used in config.h

Patch by Hajime Morrita <morrita@chromium.org> on 2011-12-01
Reviewed by Kevin Ollivier.

  • ForwardingHeaders/runtime/JSExportMacros.h: Added.
  • ForwardingHeaders/wtf/ExportMacros.h: Added.
  • config.h:

Source/WebCore:

Patch by Hajime Morrita <morrita@chromium.org> on 2011-12-01
Reviewed by Kevin Ollivier.

  • Moved export related definitions from config.h to ExportMacros.h, JSExportMacros.h and PlatformExportMacros.h
  • Added forwarding headers which are referred from config.h

No new tests. Only build related changes.

  • ForwardingHeaders/runtime/JSExportMacros.h: Added.
  • ForwardingHeaders/wtf/ExportMacros.h: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • config.h:
  • platform/PlatformExportMacros.h: Copied from Source/JavaScriptCore/wtf/ExportMacros.h.

Source/WebKit/cf:

Patch by Hajime Morrita <morrita@chromium.org> on 2011-12-01
Reviewed by Kevin Ollivier.

Removed macro definitions which is now provided by Platform.h

  • WebCoreSupport/WebInspectorClientCF.cpp:

Source/WebKit/mac:

Patch by Hajime Morrita <morrita@chromium.org> on 2011-12-01
Reviewed by Kevin Ollivier.

Removed macro definitions which is now provided by Platform.h

  • WebKitPrefix.h:

Source/WebKit/qt:

Patch by Hajime Morrita <morrita@chromium.org> on 2011-12-01
Reviewed by Kevin Ollivier.

Added a INCLUDEPATH to make JSExportMacros.h visible.

  • tests/MIMESniffing/MIMESniffing.pro

Source/WebKit2:

Patch by Hajime Morrita <morrita@chromium.org> on 2011-12-01
Reviewed by Kevin Ollivier.

Removed macro definitions which is now provided by Platform.h

  • config.h:

Tools:

Patch by Hajime Morrita <morrita@chromium.org> on 2011-12-01
Reviewed by Kevin Ollivier.

Removed macro definitions which is now provided by Platform.h

  • DumpRenderTree/chromium/config.h:
  • DumpRenderTree/config.h:
  • TestWebKitAPI/config.h:
  • WebKitTestRunner/config.h:
23:13 Changeset [101750] by jonlee@apple.com

[WK2] Add further support for notifications
https://bugs.webkit.org/show_bug.cgi?id=73572
<rdar://problem/10472195>

Reviewed by Darin Adler.

Source/WebCore:

  • WebCore.exp.in: Export constructor and dispatch functions
  • dom/EventNames.h: Add show event.
  • notifications/Notification.cpp:

(WebCore::Notification::show): For the Mac platform, we just forward the show() call to the
notification client and update the state, because we cannot get synchronous acknowledgment that the
notification got delivered.
(WebCore::Notification::dispatchShowEvent): Create simple events and dispatch to the notification.
(WebCore::Notification::dispatchClickEvent): Ditto.
(WebCore::Notification::dispatchCloseEvent): Ditto.
(WebCore::Notification::dispatchErrorEvent): Ditto.

  • notifications/Notification.h: Add dispatch functions.
  • notifications/Notification.idl: Add onshow event listener. The ondisplay event listener should be

removed when implementations change the event listener to onshow.

Source/WebKit2:

  • WebProcess/Notifications/WebNotificationManager.messages.in: Added. Contains messages for callbacks

from the notification platform.

  • DerivedSources.make: Add WebNotificationManager.
  • DerivedSources.pri: Ditto.
  • Platform/CoreIPC/MessageID.h: Add message class.
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didReceiveMessage): Forward calls to WebNotificationManager when needed.

  • WebKit2.xcodeproj/project.pbxproj: Add new message files.
  • win/WebKit2.vcproj: Adding new files to project.
  • win/WebKit2Common.vsprops: Add Notifications to include paths
  • UIProcess/WebNotification.h: Add and expose internal ID of each notification sent to the platform.

(WebKit::WebNotification::create):
(WebKit::WebNotification::notificationID):
(WebKit::isNotificationIDValid): Checks that the ID is not a value that might trip up the HashMaps used
for mapping IDs to notifications.

  • UIProcess/WebNotification.cpp:

(WebKit::WebNotification::WebNotification):
(WebKit::WebNotification::encode):
(WebKit::WebNotification::decode):

  • UIProcess/API/C/WKNotification.h: Expose notification ID to WKAPI.
  • UIProcess/API/C/WKNotification.cpp:

(WKNotificationGetNotificationID):

  • UIProcess/WebNotificationManagerProxy.h: Add callbacks for dispatching events back to the notification.
  • UIProcess/WebNotificationManagerProxy.cpp:

(WebKit::WebNotificationManagerProxy::invalidate): Remove manager.
(WebKit::WebNotificationManagerProxy::show): Add manager prior to showing.
(WebKit::WebNotificationManagerProxy::cancel): Add manager prior to canceling.
(WebKit::WebNotificationManagerProxy::didDestroyNotification):
(WebKit::WebNotificationManagerProxy::providerDidShowNotification):
(WebKit::WebNotificationManagerProxy::providerDidClickNotification):
(WebKit::WebNotificationManagerProxy::providerDidCloseNotifications):

  • UIProcess/API/C/WKNotificationManager.h:
  • UIProcess/API/C/WKNotificationManager.cpp:

(WKNotificationManagerProviderDidShowNotification):
(WKNotificationManagerProviderDidClickNotification):
(WKNotificationManagerProviderDidCloseNotifications):

  • UIProcess/WebNotificationProvider.h:
  • UIProcess/WebNotificationProvider.cpp:

(WebKit::WebNotificationProvider::show):
(WebKit::WebNotificationProvider::cancel):
(WebKit::WebNotificationProvider::didDestroyNotification):
(WebKit::WebNotificationProvider::addNotificationManager):
(WebKit::WebNotificationProvider::removeNotificationManager):

  • UIProcess/API/C/WKNotificationProvider.h: Expose add/removeNotificationManager calls
  • WebProcess/Notifications/WebNotificationManager.h: Add bookkeeping to keep track of notification IDs with

Notification instances.

  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::generateNotificationID):
(WebKit::WebNotificationManager::didReceiveMessage):
(WebKit::WebNotificationManager::show):
(WebKit::WebNotificationManager::cancel):
(WebKit::WebNotificationManager::didDestroyNotification):
(WebKit::WebNotificationManager::didShowNotification):
(WebKit::WebNotificationManager::didClickNotification):
(WebKit::WebNotificationManager::didCloseNotifications):

  • UIProcess/WebNotificationManagerProxy.messages.in: Add DidDestroyNotification message.
  • WebProcess/WebCoreSupport/WebNotificationClient.cpp:

(WebKit::WebNotificationClient::notificationObjectDestroyed): Implemented.

23:12 Changeset [101749] by ossy@webkit.org

[Qt] Unreviewed gardening after r101742, update Qt specific expected files.

  • platform/qt/fast/forms/search-styled-expected.png:
  • platform/qt/fast/forms/search-styled-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.png:
  • platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-visibility-1-expected.png:
  • platform/qt/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-visibility-2-expected.png:
  • platform/qt/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/qt/test_expectations.txt:
23:06 Changeset [101748] by ossy@webkit.org

[Qt] Unreviewed morning gardening after r101723.

  • platform/qt/fast/dom/Window/window-properties-expected.txt: Updated.
23:04 Changeset [101747] by msaboff@apple.com

Changes proposed for 73457 slow down Kraken json-parse-financial
https://bugs.webkit.org/show_bug.cgi?id=73584

Restructured StringImpl::equal to take advantage of 8 or 4 bytes
at a time when possible.

This is worth ~3% on Kraken json-parse-financial. It provides
~2% on SunSpider string-unpack-code.

Reviewed by Sam Weinig.

  • wtf/text/StringImpl.cpp:

(WTF::equal):

23:01 Changeset [101746] by commit-queue@webkit.org

[WEBKIT2] Fix for compilation warnings in WebContext.cpp
https://bugs.webkit.org/show_bug.cgi?id=69080

Fix compilation warning in WebKit2 builds.

Patch by Goutham J <gouthamj@motorola.com> on 2011-12-01
Reviewed by Hajime Morita.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::processDidFinishLaunching):
(WebKit::WebContext::startMemorySampler):

22:55 Changeset [101745] by ossy@webkit.org

[Qt] Unreviewed morning gardening after r101742.

Remove tests from test_expectation.txt , because they are
in Skipped list too and NRWT can't handle this situation.
(See https://bugs.webkit.org/show_bug.cgi?id=69750 for details.)

  • platform/qt/test_expectations.txt:
22:39 Changeset [101744] by ryuan.choi@samsung.com

[EFL] Cleanup includes to reduce code complexity.
https://bugs.webkit.org/show_bug.cgi?id=73540

Reviewed by Gustavo Noronha Silva.

Source/WebKit:

  • CMakeLists.txt: Add loader/appcache to WebKit_INCLUDE_DIRECTORIES.

Source/WebKit/efl:

EWebKit.h is a list of public header files for application to use WebKit/Efl.
This patch removes EWebKit.h in internal files to reduce unnecessary includes.
In addition, reorders optional includes to fix style.

  • WebCoreSupport/ChromeClientEfl.cpp:
  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
  • WebCoreSupport/EditorClientEfl.cpp:
  • WebCoreSupport/FrameLoaderClientEfl.cpp:
  • ewk/ewk_auth_soup.cpp:
  • ewk/ewk_contextmenu.cpp:
  • ewk/ewk_cookies.cpp:
  • ewk/ewk_frame.cpp:
  • ewk/ewk_history.cpp:
  • ewk/ewk_main.cpp:
  • ewk/ewk_private.h:
  • ewk/ewk_settings.cpp:
  • ewk/ewk_util.cpp:
  • ewk/ewk_view.cpp:
  • ewk/ewk_view_single.cpp:
  • ewk/ewk_view_tiled.cpp:
  • ewk/ewk_window_features.cpp:
22:32 Changeset [101743] by commit-queue@webkit.org

Focus ring of imagemap's area element does not scale when CSS zoom style is applied
https://bugs.webkit.org/show_bug.cgi?id=73595

Patch by Max Vujovic <mvujovic@adobe.com> on 2011-12-01
Reviewed by Darin Adler.

Source/WebCore:

Tests: fast/images/imagemap-focus-ring-zoom-style-expected.html

fast/images/imagemap-focus-ring-zoom-style.html

  • html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::computePath):
The computePath method now uses the RenderObject's effectiveZoom
instead of the Frame's page zoom to compute the path for the area
element's focus ring.

LayoutTests:

  • fast/images/imagemap-focus-ring-zoom-style-expected.html: Added.
  • fast/images/imagemap-focus-ring-zoom-style.html: Added.
22:23 Changeset [101742] by tkent@chromium.org

REGRESSION(r90971): Placeholder text of input control is rendered
over positioned elements with z-index:0.
https://bugs.webkit.org/show_bug.cgi?id=67408

Reviewed by Darin Adler.

Source/WebCore:

The bug was caused by "position:relative" in the default style of
-webkit-input-placeholder. If there were other positioned elements
with z-index:0, a placeholder might be rendered over them.

"position:relative" is not needed because RenderTextControlSingleLine
and RenderTextControlMultipleLine lay out the placeholder renderer by
custom layout code.

Tests: fast/forms/placeholder-with-positioned-element.html

  • css/html.css:

(::-webkit-input-placeholder): Remove position:relative.

LayoutTests:

Need to update some placeholder-related tests because we don't use position:relative.

  • fast/forms/placeholder-with-positioned-element-expected.html: Added.
  • fast/forms/placeholder-with-positioned-element.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/mac-snowleopard/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/mac-snowleopard/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/mac/Skipped:
  • platform/mac/fast/forms/placeholder-position-expected.txt:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/mac/fast/forms/search-styled-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/qt/test_expectations.txt:
21:39 Changeset [101741] by kling@webkit.org

CSSMutableStyleDeclaration: Removed unused multiLength argument in setLengthProperty().
<http://webkit.org/b/73602>

Reviewed by Darin Adler.

  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::setLengthProperty):

  • css/CSSMutableStyleDeclaration.h:
20:51 Changeset [101740] by haraken@chromium.org

Unreviewed, rolling out r101737.
http://trac.webkit.org/changeset/101737
https://bugs.webkit.org/show_bug.cgi?id=73394

Chromium/Mac and Chromium/Win build are broken

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/action_derivedsourcesallinone.py:

(main):

  • WebCore.gypi:
  • bindings/scripts/generate-bindings.pl:
  • page/DOMWindow.idl:
  • webaudio/DOMWindowWebAudio.idl: Removed.
20:32 Changeset [101739] by hayato@chromium.org

Explicitly pass tolerance=0 to port.diff_image in case of RefTestMismatch failure.
https://bugs.webkit.org/show_bug.cgi?id=73406

Reviewed by Ryosuke Niwa.

WebKitPort's image_diff uses tolerance='0.1' in default.
When reftests fail, we should use tolerace=0 when diff-ing images.

Since ImageDiff on chromium port doesn't use tolerance value as of now,
this change doesn't affect chromium port's behavior.

  • Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(write_test_result):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.diff_image):

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.diff_image):

  • Scripts/webkitpy/layout_tests/port/test.py:

(TestPort.diff_image):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort.diff_image):
(WebKitPort._start_image_diff_process):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_tolerance.ImageDiffTestPort.diff_image):

20:12 Changeset [101738] by commit-queue@webkit.org

Convert some fast/regions pixel tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=73581

Patch by Jacob Goldstein <jacobg@adobe.com> on 2011-12-01
Reviewed by David Hyatt.

  • fast/regions/content-flowed-into-regions-dynamically-added-expected.html: Added.
  • fast/regions/content-flowed-into-regions-dynamically-added-expected.txt: Removed.
  • fast/regions/content-flowed-into-regions-dynamically-added.html:
  • fast/regions/content-flowed-into-regions-dynamically-inserted-expected.html: Added.
  • fast/regions/content-flowed-into-regions-dynamically-removed-expected.html: Added.
  • fast/regions/content-flowed-into-regions-dynamically-removed-expected.txt: Removed.
  • fast/regions/content-flowed-into-regions-dynamically-removed.html:
  • fast/regions/content-flowed-into-regions-expected.html: Added.
  • fast/regions/content-flowed-into-regions-expected.txt: Removed.
  • fast/regions/content-flowed-into-regions.html:
  • platform/efl/fast/regions/content-flowed-into-regions-dynamically-added-expected.png: Removed.
  • platform/efl/fast/regions/content-flowed-into-regions-dynamically-inserted-expected.png: Removed.
  • platform/efl/fast/regions/content-flowed-into-regions-dynamically-inserted-expected.txt: Removed.
  • platform/efl/fast/regions/content-flowed-into-regions-dynamically-removed-expected.png: Removed.
  • platform/efl/fast/regions/content-flowed-into-regions-expected.png: Removed.
  • platform/mac/fast/regions/content-flowed-into-regions-dynamically-added-expected.png: Removed.
  • platform/mac/fast/regions/content-flowed-into-regions-dynamically-inserted-expected.png: Removed.
  • platform/mac/fast/regions/content-flowed-into-regions-dynamically-inserted-expected.txt: Removed.
  • platform/mac/fast/regions/content-flowed-into-regions-dynamically-removed-expected.png: Removed.
  • platform/mac/fast/regions/content-flowed-into-regions-expected.png: Removed.
20:11 Changeset [101737] by haraken@chromium.org

Use the [Supplemental] IDL for webaudio attributes in Chromium
https://bugs.webkit.org/show_bug.cgi?id=73394

Reviewed by Adam Barth.

  • Overview: Using the [Supplemental] IDL, this patch moves the attribute

declarations of webaudio from DOMWindow.idl into a new IDL file
webaudio/DOMWindowWebAudio.idl, which helps make webaudio a self-contained
feature (aka a module).

  • This patch changes the build flow of WebCore.gyp as follows:

Previous build flow:

foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl;
generate-bindings.pl reads $idl;
generate-bindings.pl generates .h and .cpp files for $idl;

}

New build flow (See the discussions in bug 72138 for more details):

resolve-supplemental.pl depends on all IDL files;
resolve-supplemental.pl reads all IDL files;
resolve-supplemental.pl resolves the dependency of [Supplemental=XXXX];
resolve-supplemental.pl outputs supplemental_dependency.tmp;
foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
generate-bindings.pl reads $idl;
generate-bindings.pl reads supplemental_dependency.tmp;
generate-bindings.pl generates .h and .cpp files for $idl, including all attributes in IDL files whilementing $idl;

}

  • This patch introduces a temporary IDL, [Supplemented]. The [Supplemented] IDL

will be removed after build scripts for all platforms support the [Supplemental] IDL.
The motivation for the [Supplemented] IDL is as follows:

In order to support the [Supplemental] IDL, we need to
(1) run resolve-supplemental.pl and generate supplemental_dependency.tmp
(2) and run generate-bindings.pl with the supplemental_dependency.tmp.

This build flow requires a change on the following build scripts,
but changing all the build scripts all at once without any regression is too difficult:

  • DerivedSources.make
  • DerivedSources.pri
  • GNUmakefile.am
  • PlatformBlackBerry.cmake
  • UseJSC.cmake
  • UseV8.cmake
  • WebCore.vcproj/MigrateScripts
  • WebCore.vcproj/WebCore.vcproj
  • bindings/gobject/GNUmakefile.am
  • WebCore.gyp/WebCore.gyp

Thus, we are planning to change the build scripts one by one, which implies that
we need to allow the temporary state in which some build scripts support [Supplemental] IDL
but others do not. To accomplish this, we introduce a temporary IDL, [Supplemented].
The [Supplemented] IDL on an attribute means that the attribute is marked with [Supplemental]
in another IDL file somewhere, like this:

DOMWindowWebAudio.idl:

interface [

Supplemental=DOMWindow

] DOMWindowWebAudio {

attribute attr1;
attribute attr2;

};

DOMWindow.idl:

interface [
] DOMWindow {

attribute [Supplemented] attr1; This line will be removed after all build scripts support the [Su IDL
attribute [Supplemented] attr2;
This line will be removed after all build scripts support the [Su IDL.
attribute attr3;
attribute attr4;

};

Assuming these IDL files, this patch implements the following logic in generate-bindings.pl:

  • If a given build script supports the [Supplemental] IDL, generate-bindings.pl ignores all attributes with the [Supplemented] IDL.
  • Otherwise, generate-bindings.pl treats all attributes with the [Supplemented] IDL as normal attributes and instead ignores all attributes with the [Supplemental] IDL (i.e. generate-bindings.pl generates nothing from the IDL file with the [Supplemental] IDL).

Tests: webaudio/*

  • WebCore.gyp/WebCore.gyp: Describes the build flow that I described above.
  • WebCore.gyp/scripts/action_derivedsourcesallinone.py:

(main): Reads the IDL file names from the input file (i.e. supplemental_dependency.tmp), which are described at the first column of each line in the input file.

  • WebCore.gypi: Added DOMWindowWebAudio.idl.
  • bindings/scripts/generate-bindings.pl: As a temporary solution, if the platform does not support the [Supplemental] IDL, the perl script ignores the [Supplemental] IDL and instead uses the [Supplemented] IDL. Otherwise, the perl script ignores the [Supplemented] IDL and instead uses the [Supplemental] IDL.
  • page/DOMWindow.idl: Added the [Supplemented] IDL to webaudio-related attributes. As I described above, the [Supplemented] IDL will be removed after all platforms support the [Supplemental] IDL.
  • webaudio/DOMWindowWebAudio.idl: Added. Describes the [Supplemental=DOMWindow] IDL. The attributes in this IDL file should be treated as if they are written in DOMWindow.idl.
19:39 Changeset [101736] by commit-queue@webkit.org

[MutationObservers] StyleAttributeMutationScope shouldn't be implemented with static classes
https://bugs.webkit.org/show_bug.cgi?id=73596

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-12-01
Reviewed by Ojan Vafai.

No tests needed. This patch is a minor refactor.

  • css/CSSMutableStyleDeclaration.cpp:
19:31 Changeset [101735] by adamk@chromium.org

Add Chromium ToT GTest build bots (and group selection support) to flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=73599

Reviewed by Ojan Vafai.

  • TestResultServer/static-dashboards/builders.js:
  • TestResultServer/static-dashboards/dashboard_base.js:

():
(htmlForTestTypeSwitcher):

  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:

(testHtmlForTestTypeSwitcherGroup):

18:59 Changeset [101734] by kling@webkit.org

CSSMutableStyleDeclaration: Remove unused function setStringProperty().
<http://webkit.org/b/73597>

Reviewed by Darin Adler.

  • css/CSSMutableStyleDeclaration.cpp:
  • css/CSSMutableStyleDeclaration.h:
18:39 Changeset [101733] by rniwa@webkit.org

REGRESSION(r101268): Intermittent assertion failure in fast/block/child-not-removed-from-parent-lineboxes-crash.html
https://bugs.webkit.org/show_bug.cgi?id=73250

Reviewed by Darin Adler.

Reset the position when exiting early in layoutRunsAndFloatsInRange.

No new tests because we don't have a reliable reproduction for this failure.
However, the failure is caught by the existing fast/block/child-not-removed-from-parent-lineboxes-crash.html
intermittently with about 30% probability.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutRunsAndFloatsInRange):

18:38 Changeset [101732] by scheib@chromium.org

[Chromium] Marking increased flakiness in test_expectations
inspector/debugger/script-formatter-breakpoints.html

  • platform/chromium/test_expectations.txt:
18:15 Changeset [101731] by commit-queue@webkit.org

Asynchronous SpellChecker should consider multiple requests.
https://bugs.webkit.org/show_bug.cgi?id=72939

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-12-01
Reviewed by Hajime Morita.

Source/WebCore:

Now SpellChecker saves a request when it is processing the previous spellcheck request.
If there is a request having the same root editable element, the older request is replaced by newer request.

Test: editing/spelling/spellcheck-queue.html

  • editing/SpellChecker.cpp:

(WebCore::SpellChecker::SpellCheckRequest::SpellCheckRequest):

A structure to have spell check request.

(WebCore::SpellChecker::SpellCheckRequest::sequence):
(WebCore::SpellChecker::SpellCheckRequest::range):
(WebCore::SpellChecker::SpellCheckRequest::text):
(WebCore::SpellChecker::SpellCheckRequest::mask):
(WebCore::SpellChecker::SpellCheckRequest::rootEditableElement):
(WebCore::SpellChecker::SpellChecker):
(WebCore::SpellChecker::createRequest):
(WebCore::SpellChecker::timerFiredToProcessQueuedRequest):

When timer is fired, queued request is processed if any.

(WebCore::SpellChecker::canCheckAsynchronously):
(WebCore::SpellChecker::requestCheckingFor):

When the spellchecker is processing another request, the latest request is queued.

(WebCore::SpellChecker::invokeRequest):
(WebCore::SpellChecker::enqueueRequest):

Enqueues a request. If there is an older request whose root editable element is the same as the request,
it will be replaced.

(WebCore::SpellChecker::didCheck):

  • editing/SpellChecker.h:

LayoutTests:

Tests for multiple spellcheck requests.

  • editing/spelling/spellcheck-queue-expected.txt: Added.
  • editing/spelling/spellcheck-queue.html: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
17:58 Changeset [101730] by commit-queue@webkit.org

bufferedAmount calculation is wrong in CLOSING and CLOSED state.
https://bugs.webkit.org/show_bug.cgi?id=73404

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-12-01
Reviewed by Kent Tamura.

Source/WebCore:

WebSocket::bufferedAmount() must return buffered frame size including
disposed frames which are passed via send() calls after close().

Old implementation had a problem at CLOSING state. Buffered frame size
was added to m_bufferedAmountAfterClose at close(). But the function
returns the sum of m_bufferedAmountAfterClose and internally buffered
frame size, or m_channel->bufferedAmount(). So, buffered frames was
double counted.

In new implementation, m_bufferedAmount always represents buffered
frame size and m_bufferedAmountAfterClose does disposed frame size.
As a result, bufferedAmount() implementation become just to return the
sum of m_bufferedAmount and m_bufferedAmountAfterClose.

Test: http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html

  • websockets/WebSocket.cpp: Implement new bufferedAmount handling.

(WebCore::saturateAdd):
(WebCore::WebSocket::WebSocket):
(WebCore::WebSocket::send):
(WebCore::WebSocket::close):
(WebCore::WebSocket::bufferedAmount):
(WebCore::WebSocket::didUpdateBufferedAmount):
(WebCore::WebSocket::didClose):

  • websockets/WebSocket.h:

LayoutTests:

Add a layout test to check the WebSocket bufferedAmount property.
This test close the socket channel when it is busy and buffer some
message frames, then check the property's value in CLOSING and CLOSED
state.

  • http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy-expected.txt: Added.
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html: Added.
17:56 Changeset [101729] by oliver@apple.com

Support integer typed arrays in the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=73608

Reviewed by Filip Pizlo.

Add support for all the integral typed arrays in the DFG JIT.
Currently this loads the contents of Uint32 arrays as doubles,
which is clearly not as efficient as it could be, but this is
still in the order of 10-20x faster than the existing behaviour.

This needed us to add support for writing 16bit values to the
macroassembler, and also to support double<->unsigned conversion.

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::strh):
(JSC::ARMv7Assembler::vcvt_floatingPointToUnsigned):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::store16):
(JSC::MacroAssemblerARMv7::truncateDoubleToUint32):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::store16):
(JSC::MacroAssemblerX86Common::truncateDoubleToUint32):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::movw_rm):
(JSC::X86Assembler::cvttsd2siq_rr):

  • bytecode/PredictedType.cpp:

(JSC::predictionToString):
(JSC::predictionFromClassInfo):

  • bytecode/PredictedType.h:

(JSC::isInt8ArrayPrediction):
(JSC::isInt16ArrayPrediction):
(JSC::isInt32ArrayPrediction):
(JSC::isUint8ArrayPrediction):
(JSC::isUint16ArrayPrediction):
(JSC::isUint32ArrayPrediction):
(JSC::isFloat32ArrayPrediction):
(JSC::isFloat64ArrayPrediction):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::execute):

  • dfg/DFGNode.h:

(JSC::DFG::Node::shouldSpeculateInt8Array):
(JSC::DFG::Node::shouldSpeculateInt16Array):
(JSC::DFG::Node::shouldSpeculateInt32Array):
(JSC::DFG::Node::shouldSpeculateUint8Array):
(JSC::DFG::Node::shouldSpeculateUint16Array):
(JSC::DFG::Node::shouldSpeculateUint32Array):
(JSC::DFG::Node::shouldSpeculateFloat32Array):
(JSC::DFG::Node::shouldSpeculateFloat64Array):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::performNodeCSE):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::compileGetTypedArrayLength):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • runtime/JSGlobalData.h:
17:47 Changeset [101728] by scheib@chromium.org

[Chromium] Marking Flakey tests in test_expectations:

  • platform/chromium/test_expectations.txt:

inspector/styles/styles-computed-trace.html
fast/canvas/canvas-overloads-strokeText.html

17:46 Changeset [101727] by rniwa@webkit.org

Parse reftest.list and extract types of ref tests
https://bugs.webkit.org/show_bug.cgi?id=66837

Reviewed by Dirk Pranke.

Add support for reftest.list to base port.

  • Scripts/webkitpy/common/find_files.py:

(find):

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner.init):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.init): Initialize self._reftest_list. It's a dictionary mapping from a test directory
to a dictionary of {test path: ("==" or "!=", reference file path)}
(Port._get_reftest_list): Added; calls test_file.parse_reftest_list to fill self._reftest_list.
(Port._reference_file_for): Added; obtains the reference file name given a test name.
(Port.is_reftest): Added; Calls _reference_file_for.
(Port.reftest_expected_filename): Calls _reference_file_for.
(Port.reftest_expected_mismatch_filename): Ditto.
(Port.find_test_files):
(is_reference_html_file): Treat any file that starts with ref- or notref- or ends with
-expected, -expected-mismach, -ref, or -notref as a reference file.
(_is_test_file):
(_parse_reftest_list): Added.

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_is_test_file):
(PortTest.test_parse_reftest_list):

  • Scripts/webkitpy/layout_tests/port/dryrun.py:

(DryrunDriver.run_test):

  • Scripts/webkitpy/layout_tests/port/test.py:

(unit_test_filesystem.add_test_file):
(unit_test_filesystem.add_file):
(unit_test_filesystem):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(get_tests_run.RecordingTestDriver.run_test):
(MainTest.test_unexpected_failures):
(MainTest.test_missing_and_unexpected_results):
(EndToEndTest.test_end_to_end):

  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:

(Rebaseliner._compile_rebaselining_tests):

17:32 Changeset [101726] by commit-queue@webkit.org

[EFL] Remove the ewk_protocol_handler-related code
https://bugs.webkit.org/show_bug.cgi?id=73018

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-12-01
Reviewed by Martin Robinson.

This functionality has been broken since r99364, which stopped setting
the "webkit-resource" property needed by
ewk_protocol_handler_soup.cpp.

After giving it some thought, it looks clear that this code should not
be in ewk at all: it is very backend-specific (even in the function
signatures it expects), and it only allows callers to register schemes
once and provide a single handler to all of them, which does not make
much sense.

Client code using WebKit-EFL with the soup backend should be
responsible for creating their own request handlers (ie. subclass
SoupRequest) instead.

For that to be possible, a function which returns the default
SoupSession used by WebKit has been added.

  • CMakeListsEfl.txt:
  • ewk/ewk_network.cpp:

(ewk_network_default_soup_session_get):

  • ewk/ewk_network.h:
  • ewk/ewk_private.h:
  • ewk/ewk_protocol_handler.cpp: Removed.
  • ewk/ewk_protocol_handler.h: Removed.
  • ewk/ewk_protocol_handler_soup.cpp: Removed.
  • ewk/ewk_protocol_handler_soup.h: Removed.
  • ewk/ewk_view.cpp:
  • ewk/ewk_view.h:
17:14 Changeset [101725] by commit-queue@webkit.org

Unreviewed, rolling out r101711.
http://trac.webkit.org/changeset/101711
https://bugs.webkit.org/show_bug.cgi?id=73605

Broke 3 webkitpy tests (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-01

  • Scripts/webkitpy/style/checker.py:

(_all_categories):
(FileType):
(CheckerDispatcher._file_type):
(CheckerDispatcher._create_checker):

  • Scripts/webkitpy/style/checker_unittest.py:

(CheckerDispatcherDispatchTest.assert_checker_cpp):
(CheckerDispatcherDispatchTest.test_cpp_paths):

  • Scripts/webkitpy/style/checkers/jsonchecker.py: Removed.
  • Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Removed.
17:03 Changeset [101724] by haraken@chromium.org

Replace a custom constructor of window.Option with the [NamedConstructor] IDL
https://bugs.webkit.org/show_bug.cgi?id=73498

Reviewed by Adam Barth.

Removes JSOptionConstructor.{h,cpp} and generates the constructor of window.Option
by the [NamedConstructor] IDL.

Source/WebCore:

Tests: fast/js/custom-constructors.html

fast/forms/option-index.html
fast/forms/add-and-remove-option.html
fast/dom/dom-add-optionelement.html

  • GNUmakefile.list.am: Removed JSOptionConstructor.{h,cpp}.
  • Target.pri: Ditto.
  • UseJSC.cmake: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.order: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSBindingsAllInOne.cpp: Ditto.
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::option): Specifies the NamedConstructor.

  • bindings/js/JSOptionConstructor.cpp: Removed.
  • bindings/js/JSOptionConstructor.h: Removed.
  • page/DOMWindow.idl: Removed the [JSCustomConstructor] IDL.

LayoutTests:

  • platform/mac/fast/dom/Window/window-properties-expected.txt: Updated the test result.
16:59 Changeset [101723] by haraken@chromium.org

Replace a custom constructor of window.Audio with the [NamedConstructor] IDL
https://bugs.webkit.org/show_bug.cgi?id=73496

Reviewed by Adam Barth.

Removes JSAudioConstructor.{h,cpp} and generates the constructor of window.Audio
by the [NamedConstructor] IDL.

Source/WebCore:

Tests: fast/js/custom-constructors.html

media/audio-constructor.html
media/audio-constructor-src.html
media/audio-constructor-preload.html
media/audio-controls-do-not-fade-out.html
media/audio-controls-rendering.html

  • GNUmakefile.list.am: Removed JSAudioConstructor.{h,cpp}.
  • Target.pri: Ditto.
  • UseJSC.cmake: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.order: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSBindingsAllInOne.cpp: Ditto.
  • bindings/js/JSAudioConstructor.cpp: Removed.
  • bindings/js/JSAudioConstructor.h: Removed.
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::audio): Specifies the NamedConstructor.

  • page/DOMWindow.idl: Removed the [JSCustomConstructor] IDL.

LayoutTests:

  • platform/mac/fast/dom/Window/window-properties-expected.txt: Updated the test result.
16:52 Changeset [101722] by scheib@chromium.org

[Chromium] Marking animations/play-state.html even flakier in test_expectations

  • platform/chromium/test_expectations.txt:
16:49 Changeset [101721] by commit-queue@webkit.org

[FileSystem API] resolveLocalFileSystemURL required arguments
https://bugs.webkit.org/show_bug.cgi?id=69649

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-12-01
Reviewed by Darin Adler.

  • fast/filesystem/not-enough-arguments-expected.txt:
  • fast/filesystem/not-enough-arguments.html:
16:35 Changeset [101720] by scheib@chromium.org

[Chromium] Fixing test_expectations error

  • platform/chromium/test_expectations.txt:
15:32 Changeset [101719] by bdakin@apple.com

https://bugs.webkit.org/show_bug.cgi?id=73592
REGRESSION (r100483): Can't drag out of background window
-and corresponding-
<rdar://problem/10508870>

Reviewed by Darin Adler.

If the mouse is pressed we need to do a full, normal hit test even if the window
is not active.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::mouseEvent):
(WebKit::WebPage::mouseEventSyncForTesting):

15:17 Changeset [101718] by commit-queue@webkit.org

[FileSystem API] DirectoryEntry.removeRecursively successCallback is required
https://bugs.webkit.org/show_bug.cgi?id=69644

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-12-01
Reviewed by Adam Barth.

Source/WebCore:

  • fileapi/DirectoryEntry.idl: remove [Optional] flag from successCallback

LayoutTests:

  • fast/filesystem/not-enough-arguments-expected.txt: add removeRecursively test result
  • fast/filesystem/not-enough-arguments.html: add removeRecursively test
15:14 Changeset [101717] by commit-queue@webkit.org

[FileSystem API] DirectoryEntry.getDirectory path argument is required
https://bugs.webkit.org/show_bug.cgi?id=69643

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-12-01
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/filesystem/simple-required-arguments-getdirectory.html

  • bindings/js/JSDirectoryEntryCustom.cpp:

(WebCore::JSDirectoryEntry::getDirectory): throw TypeError if not enough arguments

  • bindings/v8/custom/V8DirectoryEntryCustom.cpp:

(WebCore::V8DirectoryEntry::getDirectoryCallback): throw TypeError if not enough arguments

LayoutTests:

  • fast/filesystem/resources/simple-required-arguments-getdirectory.js: Added.

(errorCallback):
(successCallback):

  • fast/filesystem/simple-required-arguments-getdirectory-expected.txt: Added.
  • fast/filesystem/simple-required-arguments-getdirectory.html: Added.
15:06 Changeset [101716] by commit-queue@webkit.org

V8 bindings cleanup: V8WindowErrorHandler shouldn't be directly invoking script
https://bugs.webkit.org/show_bug.cgi?id=73576

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-12-01
Reviewed by Adam Barth.

No tests needed. This patch is just bindings hygiene.

  • bindings/v8/V8WindowErrorHandler.cpp:

(WebCore::V8WindowErrorHandler::callListenerFunction):

15:00 Changeset [101715] by kov@webkit.org

Unreviewed. Add myself to GStreamer and WebKit2GTK+ watchlists.

  • Scripts/webkitpy/common/config/watchlist:
14:56 Changeset [101714] by kov@webkit.org

Unreviewed. Fix bad file =(.

  • gtk/jhbuild.modules:
  • Scripts/webkitdirs.pm:

(runAutogenForAutotoolsProject):

14:51 Changeset [101713] by benjamin@webkit.org

URLs are encoded in UTF-8, then decoded as if they are Latin1
https://bugs.webkit.org/show_bug.cgi?id=71758

Reviewed by Darin Adler.

Source/JavaScriptCore:

Add the operator == between a String and a Vector of char. The implementation
is the same as the comparison of String and char* but adds the length as a
parameter for comparing the strings.

(WTF::equal):

  • wtf/text/WTFString.h:

(WTF::operator==):
(WTF::operator!=):

Source/WebCore:

Previously, invalid URLs could have a string emanating from a
partial parsing of the input. The creation of the string was done
through the Latin1 codec regardless of the encoding of the char* url.

This caused two types of issues, URLs were evaluated as half-parsed,
and the coding and decoding of the string was not consistent.

This patch changes KURL::parse() to fallback on the original string
whenever the parsing of the URL fails.

Test: fast/url/invalid-urls-utf8.html

  • platform/KURL.cpp:

(WebCore::KURL::KURL):
(WebCore::KURL::init):
(WebCore::KURL::parse):
Previously, originalString was only used as an optimization to avoid
the allocation of a string. Since this optimization depends on the
comparison of the incoming string and the encoded buffer.
This patches generalizes originalString to always be the original string
being parsed by KURL. The optimization is kept by comparing that string
and the final parsed result.

  • platform/KURL.h:

(WebCore::KURL::parse):

  • platform/cf/KURLCFNet.cpp:

(WebCore::KURL::KURL):

  • platform/mac/KURLMac.mm:

(WebCore::KURL::KURL):

LayoutTests:

  • fast/url/invalid-urls-utf8-expected.txt: Added.
  • fast/url/invalid-urls-utf8.html: Added.

New test for invalid URL where the Unicode characters were mangled
by the parsing.

  • fast/url/file-expected.txt:
  • fast/url/file-http-base-expected.txt:

Two urls where expended by their base URL before found invalid. The partial
parsed result was saved as the new URL.

  • fast/url/host-expected.txt:

The host of two urls were invalid, and partially modified by the parsing.

  • fast/url/idna2003-expected.txt:

The first 'http://www.lookout.net⩴80/' encoded for parsing is http://www.lookout.net::=80/
and fails as invalid. The new result does not modify the original string.

The whitespace in 'http://www .lookout.net/' causes the parsing to fail when parsing
the username because a space is not a UserInfoChar.

  • fast/url/port-expected.txt:

The unicode characters used as the port number were transformed due to
the encoding UTF-8 -> Unicode through the Latin1 codec.

  • platform/chromium/test_expectations.txt: Skip the test on Chromium for now since Google URL

does not implement the extended version of parse().

14:45 Changeset [101712] by mrobinson@webkit.org

[GTK] Read fonts from the jhbuild root
https://bugs.webkit.org/show_bug.cgi?id=73487

Reviewed by Gustavo Noronha Silva.

Read fonts from the jhbuild root instead of from the system. This will ensure
that all testers use the same fonts instead of leaving this up to luck.

Source/JavaScriptCore:

  • wtf/gobject/GlibUtilities.h: Add Assertions.h which was required for the WebKit2TestRunner.

Tools:

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(initializeFonts): Load fonts from jhbuild root.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort.setup_environ_for_server): Pass an environment variable containing
the path to the jhbuild root.

  • WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:

(WTR::inititializeFontConfigSetting): Load fonts from the jhbuild root.

14:37 Changeset [101711] by aroben@apple.com

Teach check-webkit-style how to check the syntax of JSON files

Fixes <http://webkit.org/b/73590> check-webkit-style doesn't flag JSON syntax errors

Reviewed by Darin Adler.

  • Scripts/webkitpy/style/checker.py:

(_all_categories): Added JSONChecker's categories to the set of all categories.
(FileType): Added a JSON type. Incremented other types.
(CheckerDispatcher._file_type): Use the JSON file type for .json files.
(CheckerDispatcher._create_checker): Use a JSONChecker for JSON files.

  • Scripts/webkitpy/style/checker_unittest.py:

(CheckerDispatcherDispatchTest.assert_checker_json): Added this helper method.
(CheckerDispatcherDispatchTest.test_json_paths): Added. Based on test_python_paths.

  • Scripts/webkitpy/style/checkers/jsonchecker.py: Added. (I didn't name this just "json",

which would have matched our other checkers, because I couldn't figure out how to call
"json.loads" without hitting namespace conflicts.)
(JSONChecker.init): Turn of line filtering so that we always check the whole file, not
just the modified lines from a patch.
(JSONChecker.check): Try to parse the lines as JSON. Mark an error if there was an
exception.
(JSONChecker.line_number_from_json_exception): Parse the json modules exception message to
try to extract a line number.

  • Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Added.

(MockErrorHandler.init):
(MockErrorHandler.turn_off_line_filtering):
(MockErrorHandler.call):
Helper class. Copied from xml_unittest.py.

(JSONCheckerTest.test_line_number_from_json_exception): Test the
line_number_from_json_exception helper method.

(JSONCheckerTest.assert_no_error):
(JSONCheckerTest.assert_error):
Helper methods to assert that we did or didn't get an error.

(JSONCheckerTest.mock_handle_style_error): Helper method.

(JSONCheckerTest.test_conflict_marker):
(JSONCheckerTest.test_single_quote):
(JSONCheckerTest.test_init):
(JSONCheckerTest.test_missing_closing_brace):
(JSONCheckerTest.test_no_error):
Test various cases.

14:31 Changeset [101710] by mrobinson@webkit.org

[GTK] Add a helper function to find the current executable's path
https://bugs.webkit.org/show_bug.cgi?id=73473

Reviewed by Gustavo Noronha Silva.

Source/JavaScriptCore:

Add a WTF helper which gets the binary path. This is currently only used
in WebKit2.

  • GNUmakefile.list.am: Add the new file to the source list.
  • wtf/gobject/GlibUtilities.cpp: Added.

(getCurrentExecutablePath):

  • wtf/gobject/GlibUtilities.h: Added.

Source/WebCore:

No new tests. This should not change behavior.

  • platform/gtk/FileSystemGtk.cpp:

(WebCore::applicationDirectoryPath): Now use the new WTF function to get the
current executable's path.

Source/WebKit2:

Do a series of tests when looking for processes. First search the directory
specified by the environment variable, then the directory of the binary and
then the LIBEXECDIR.

  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:

(WebKit::findWebKitProcess): Added.
(WebKit::ProcessLauncher::launchProcess): Call the new helper to get the
binary location.

Tools:

Update MiniBrowser to not pass the binary directory as an environment variable.
This means that you can move the binaries around without it breaking.

  • MiniBrowser/gtk/main.c:

(main): No longer set the environment variable.

  • WebKitTestRunner/GNUmakefile.am: No longer add the directory path define.
  • WebKitTestRunner/gtk/main.cpp: Ditto.
14:25 Changeset [101709] by jochen@chromium.org

[chromium] add referrer policy to WebContextMenuData
https://bugs.webkit.org/show_bug.cgi?id=73567

Reviewed by Darin Fisher.

  • public/WebContextMenuData.h:
  • src/ContextMenuClientImpl.cpp:

(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

14:25 Changeset [101708] by kov@webkit.org

[GTK] Add freetype to our jhbuild setup
https://bugs.webkit.org/show_bug.cgi?id=73488

Reviewed by Martin Robinson.

This adds the first library to our jhbuild setup, and makes sure
build-webkit calls autogen.sh and make with jhbuild, so that the
environment is properly set.

  • Scripts/webkitdirs.pm:

(saveSum):
(hashFile):
(runAutogenForAutotoolsProject): save md5sum of jhbuild-related files, and
call autogen under jhbuild run;
(mustRunAutogen): generalized the arguments change checking to also force
running autogen when jhbuild files change;
(buildAutotoolsProject): run make under jhbuild;

  • gtk/jhbuild.modules: add freetype.
14:22 Changeset [101707] by kling@webkit.org

StyledElement: Clean up inline style accessors.
<http://webkit.org/b/73568>

Reviewed by Antti Koivisto.

Renamed StyledElement's getInlineStyleDecl() to ensureInlineStyleDecl() to
make it clear that it will always return non-null as opposed to inlineStyleDecl().

Also updated call sites to store the return value in a CSSInlineStyleDeclaration*
rather than a CSSMutableStyleDeclaration*, and reduced scoping of temporaries
in some cases.

  • dom/StyledElement.cpp:

(WebCore::StyledElement::createInlineStyleDecl):
(WebCore::StyledElement::destroyInlineStyleDecl):
(WebCore::StyledElement::parseMappedAttribute):
(WebCore::StyledElement::ensureInlineStyleDecl):
(WebCore::StyledElement::style):
(WebCore::StyledElement::copyNonAttributeProperties):
(WebCore::StyledElement::addSubresourceAttributeURLs):

  • dom/StyledElement.h:

(WebCore::StyledElement::inlineStyleDecl):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):
(WebCore::ApplyStyleCommand::addBlockStyle):
(WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):

  • editing/DeleteButtonController.cpp:

(WebCore::DeleteButtonController::createDeletionUI):
(WebCore::DeleteButtonController::show):
(WebCore::DeleteButtonController::hide):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
(WebCore::ReplaceSelectionCommand::handleStyleSpans):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::updatePlaceholderVisibility):

  • html/ValidationMessage.cpp:

(WebCore::adjustBubblePosition):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlElement::show):
(WebCore::MediaControlElement::hide):
(WebCore::MediaControlPanelElement::setPosition):
(WebCore::MediaControlPanelElement::resetPosition):
(WebCore::MediaControlPanelElement::makeOpaque):
(WebCore::MediaControlPanelElement::makeTransparent):
(WebCore::MediaControlInputElement::show):
(WebCore::MediaControlInputElement::hide):

  • html/shadow/MeterShadowElement.cpp:

(WebCore::MeterValueElement::setWidthPercentage):

  • html/shadow/ProgressShadowElement.cpp:

(WebCore::ProgressValueElement::setWidthPercentage):

  • html/shadow/SliderThumbElement.cpp:

(WebCore::TrackLimiterElement::create):

14:16 Changeset [101706] by knorton@google.com

More void functions eager to return values in RenderObject & WebFrameImpl
https://bugs.webkit.org/show_bug.cgi?id=73571

Reviewed by Adam Barth.

Source/WebCore:

  • rendering/RenderObject.h:

(WebCore::RenderObject::computeAbsoluteRepaintRect):

Source/WebKit/chromium:

  • src/WebFrameImpl.cpp:

(WebKit::ChromePrintContext::computePageRects):

14:12 Changeset [101705] by scheib@chromium.org

Unreviewed, rolling out r101691.
http://trac.webkit.org/changeset/101691
https://bugs.webkit.org/show_bug.cgi?id=73588

Tests fail on Chromium bots, early warning system warned
committer, please adjust test_expectations in patch (Requested
by scheib on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-01

Source/JavaScriptCore:

Source/WebCore:

  • platform/KURL.cpp:

(WebCore::KURL::KURL):
(WebCore::KURL::init):
(WebCore::KURL::parse):

  • platform/KURL.h:
  • platform/cf/KURLCFNet.cpp:

(WebCore::KURL::KURL):

  • platform/mac/KURLMac.mm:

(WebCore::KURL::KURL):

LayoutTests:

  • fast/url/file-expected.txt:
  • fast/url/file-http-base-expected.txt:
  • fast/url/host-expected.txt:
  • fast/url/idna2003-expected.txt:
  • fast/url/invalid-urls-utf8-expected.txt: Removed.
  • fast/url/invalid-urls-utf8.html: Removed.
  • fast/url/port-expected.txt:
14:08 Changeset [101704] by commit-queue@webkit.org

[Chromium] Add the FontCache implementation for Android
https://bugs.webkit.org/show_bug.cgi?id=73452

Add the FontCache implementation specific for the Chromium WebKit
port on Android, and include various font-related files intended for
Linux which can be re-used.

Patch by Peter Beverloo <peter@chromium.org> on 2011-12-01
Reviewed by Adam Barth.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/graphics/chromium/FontCacheAndroid.cpp: Added.

(WebCore::getFallbackFontName):
(WebCore::isFallbackFamily):
(WebCore::FontCache::platformInit):
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
(WebCore::FontCache::getTraitsInFamily):
(WebCore::FontCache::createFontPlatformData):

13:51 Changeset [101703] by tony@chromium.org

Need to implement flex-flow: row-reverse
https://bugs.webkit.org/show_bug.cgi?id=70778

Reviewed by Ojan Vafai.

Source/WebCore:

We can't just change the direction of the FlexOrderIterator because we want the overflow to be
on the left side. Instead, we apply similar logic as when we're laying out RTL content. Putting
the check in isLeftToRightFlow() lets us flip the flexbox's border and padding and the flexitems'
margins. We then layout from right to left in layoutAndPlaceChildren.

Also remove 2 uncalled functions.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::isReverseFlow):
(WebCore::RenderFlexibleBox::isLeftToRightFlow):

  • rendering/RenderFlexibleBox.h:

LayoutTests:

  • css3/flexbox/flex-flow-expected.txt:
  • css3/flexbox/flex-flow.html: Added test cases to make sure start and end still apply to the text flow direction.
  • css3/flexbox/flex-flow-border-expected.txt:
  • css3/flexbox/flex-flow-border.html: Single flexitem, so reverse does nothing
  • css3/flexbox/flex-flow-margins-auto-size-expected.txt:
  • css3/flexbox/flex-flow-margins-auto-size.html: Ditto. The orthogonal tests fail, but they've always failed.
  • css3/flexbox/flex-flow-margins-expected.txt:
  • css3/flexbox/flex-flow-margins.html: Ditto.
  • css3/flexbox/flex-flow-orientations-expected.txt:
  • css3/flexbox/flex-flow-orientations.html: This test has 2 flexitems, the positions of which are now flipped.
  • css3/flexbox/flex-flow-overflow-expected.txt:
  • css3/flexbox/flex-flow-overflow.html: The overflow should go in the opposite direction. That is, the overflow

of rtl should be the same as row-reverse.

  • css3/flexbox/flex-flow-padding-expected.txt:
  • css3/flexbox/flex-flow-padding.html: Single flexitem, no change.
13:44 Changeset [101702] by commit-queue@webkit.org

[Chromium] Early returns in calculateDrawTransformsAndVisibilityInternal() are not respected by parent.
https://bugs.webkit.org/show_bug.cgi?id=73270

Non-drawing child trees should not be added to the parent render surface's layer list
and should neither extend the parent layer's drawable content rect.

This also fixes assertions from the content texture residency logic, which doesn't like it
if we try to use a render surface through a parent, while that surface itself was never 'used'
in the same frame.

Patch by Daniel Sievers <sievers@chromium.org> on 2011-12-01
Reviewed by James Robinson.

Source/WebCore:

Added unit test.

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsAndVisibilityInternal):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostCommonTest.cpp:

(WebCore::TEST):

13:32 Changeset [101701] by commit-queue@webkit.org

[Chromium] Use contentBounds instead of bounds for invalidation.
https://bugs.webkit.org/show_bug.cgi?id=73525

Patch by David Reveman <reveman@chromium.org> on 2011-12-01
Reviewed by James Robinson.

Use setNeedsDisplay() instead of setNeedsDisplayRect() when possible.

Source/WebCore:

No new tests.

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setBounds):

Source/WebKit/chromium:

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::repaint):

13:13 Changeset [101700] by dmazzoni@google.com

Fix WebKitTestRunner compile warnings with XCode 3.2
https://bugs.webkit.org/show_bug.cgi?id=73378

Reviewed by Chris Fleizach.

  • WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:

(WTR::AccessibilityTextMarker::AccessibilityTextMarker):

  • WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:

(WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):

  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::AccessibilityUIElement):
(WTR::AccessibilityUIElement::verticalScrollbar):

12:36 Changeset [101699] by kling@webkit.org

CSSStyleSelector: Add missing fields to constructor initializer list.
<http://webkit.org/b/73565>

Reviewed by Antti Koivisto.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::CSSStyleSelector):

12:19 Changeset [101698] by benjamin@webkit.org

Get rid of the unused function nameForCursorType()
https://bugs.webkit.org/show_bug.cgi?id=73529

Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-12-01
Reviewed by Joseph Pecoraro.

The function nameForCursorType was introduced in r63339 and has not been used anywhere
since that commit.

  • WebCore.exp.in:
  • platform/Cursor.cpp:
  • platform/Cursor.h:
12:04 Changeset [101697] by kling@webkit.org

CSSMutableStyleDeclaration: Unnecessary double hash lookup in construction.
<http://webkit.org/b/73564>

Reviewed by Antti Koivisto.

Use HashMap::find() instead of contains() followed by get() on
successful lookup.

  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):

12:02 Changeset [101696] by commit-queue@webkit.org

Cleaning up comments and unused portions of a webgl test, as per review comments.
https://bugs.webkit.org/show_bug.cgi?id=73033

Patch by Jeff Timanus <twiz@chromium.org> on 2011-12-01
Reviewed by Stephen White.

  • fast/canvas/webgl/webgl-texture-binding-preserved.html:
11:58 Changeset [101695] by aroben@apple.com

Allow committers to use their Trac credentials to force builds on the buildbots

Fixes <http://webkit.org/b/73353>

A new class, CommitterAuth, handles authentication of WebKit committers. CommitterAuth uses
three files to do its job: a config file that contains a list of WebKit committer usernames,
an htdigest file that contains Trac credentials, and JSON file that gives the paths for
those two files.

Reviewed by Darin Adler.

  • BuildSlaveSupport/build.webkit.org-config/committer_auth.py: Added.

(Error): Basic wrapper around Exception that we use for cases where we couldn't even check
whether credentials were valid or not.
(CommitterAuth.init): Just store the path to auth.json.
(CommitterAuth.auth_json): Load, parse, and return auth.json.
(CommitterAuth.auth_json_filename): Return the path to auth.json.
(CommitterAuth.authenticate): Return true if the user is a WebKit committer and their
credentials are valid Trac credentials. Return false otherwise or if an error occurred while
checking those conditions.
(CommitterAuth.is_webkit_committer): Return true if the user is a WebKit committer. Return
false otherwise or if an exception was thrown.
(CommitterAuth.is_webkit_trac_user): Return true if the username/password are present in the
Trac credentials htdigest file. Return false otherwise or if an exception was thrown.

(CommitterAuth.open_auth_json_file):
(CommitterAuth.open_trac_credentials_file):
(CommitterAuth.open_webkit_committers_file):
Open the specified file. These are mostly useful for testing purposes.

(CommitterAuth.trac_credentials_filename):
(CommitterAuth.webkit_committers_filename):
Return the path to the specified file by retrieving it from auth.json.

(CommitterAuth.webkit_committers): Load and parse the committers file and extract the list
of WebKit committers from it.

  • BuildSlaveSupport/build.webkit.org-config/committer_auth_unittest.py: Added.

(CMStringIO.enter):
(CMStringIO.exit):
Helper class that makes it possible to use StringIO with the "with" statement.

(open_override): Helper context manager for overriding the global "open" function
temporarily.

(CommitterAuthTest.setUp): Set up a somewhat-mocked CommitterAuth that is used by most
tests.
(CommitterAuthTest.fake_open_function): Returns a function that can be used in place of
"open" to test that the expected path was opened.
(CommitterAuthTest.test_authentication_success): Test that committers can authenticate
successfully.
(CommitterAuthTest.test_committer_without_trac_credentials_fails): Test that committers who
somehow have no Trac account can't authenticate.

(CommitterAuthTest.test_fail_to_open_auth_json_file):
(CommitterAuthTest.test_fail_to_open_trac_credentials_file):
(CommitterAuthTest.test_fail_to_open_webkit_committers_file):
Test what happens when we can't open the three files we depend upon.

(CommitterAuthTest.test_implements_IAuth): Test that we fulfill buildbot's expectations for
an authentication class.

(CommitterAuthTest.test_invalid_auth_json_file):
(CommitterAuthTest.test_invalid_committers_file):
(CommitterAuthTest.test_invalid_trac_credentials_file):
(CommitterAuthTest.test_missing_auth_json_keys):
Test what happens when the three files we depend upon are invalid in some way.

(CommitterAuthTest.test_open_auth_json_file):
(CommitterAuthTest.test_open_trac_credentials_file):
(CommitterAuthTest.test_open_webkit_committers_file):
Test that we open the expected paths.

(CommitterAuthTest.test_trac_credentials_filename):
(CommitterAuthTest.test_webkit_committers_filename):
Test that we extract filenames out of auth.json correctly.

(CommitterAuthTest.test_non_committer_fails):
(CommitterAuthTest.test_unknown_user_fails):
(CommitterAuthTest.test_username_is_prefix_of_valid_user):
(CommitterAuthTest.test_wrong_password_fails):
Test various failed authentication attempts.

(CommitterAuthTest.test_webkit_committers): Test that we can parse the list of WebKit
committers out of the committers file correctly.

(CommitterAuthTest.fake_auth_json_file):
(CommitterAuthTest.invalid_auth_json_file):
(CommitterAuthTest.fake_committers_file):
(CommitterAuthTest.invalid_committers_file):
(CommitterAuthTest.fake_htdigest_file):
(CommitterAuthTest.invalid_htdigest_file):
Return various fake files for testing.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Specify an instance of CommitterAuth

to be used for authentication in the web interface, and specify that only authenticated
users may force builds.

11:58 Changeset [101694] by aroben@apple.com

Add an HTDigestParser class to webkitpy

Fixes <http://webkit.org/b/73575> webkitpy doesn't provide a way to parse htdigest files

This class can be used to parse Apache's htdigest files and check whether a given
username/realm/password tuple is present in the file. Eventually this will be used for
authenticating users on build.webkit.org (<http://webkit.org/b/73353>).

Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/net/htdigestparser.py: Added.

(HTDigestParser.init): Stores the parsed representation of the file.
(HTDigestParser.authenticate): Hashes the username/realm/password tuple to generate a hashed
password and returns whether the resulting tuple is present in the file.
(HTDigestParser.entries): Just returns the parsed representation of the file.
(HTDigestParser.parse_file): Splits each line on colons and checks that each line has the
expected syntax ('username:realm:hashed_password'). If any line is invalid, we treat the
whole file as invalid and all authentication attempts will fail.

  • Scripts/webkitpy/common/net/htdigestparser_unittest.py: Added.

(HTDigestParserTest.assertEntriesEqual): Helper method to assert that fake_htdigest_file,
optionally appended with some extra data, generates the expected entries.
(HTDigestParserTest.test_authenticate): Tests that tuples present in the file can
authenticate, and tuples not present cannot.
(HTDigestParserTest.test_entries): Tests that we get the expected entries from
fake_htdigest_file.

(HTDigestParserTest.test_empty_file):
(HTDigestParserTest.test_too_few_colons):
(HTDigestParserTest.test_too_many_colons):
(HTDigestParserTest.test_invalid_hash):
Test various forms of invalid files.

(HTDigestParserTest.fake_htdigest_file): Returns a fake valid htdigest file for testing.

11:45 Changeset [101693] by fpizlo@apple.com

ARMv7 only allows for one-shot patching of compact offsets, while the
JIT expects to be able to repatch
https://bugs.webkit.org/show_bug.cgi?id=73548

Reviewed by Oliver Hunt.

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::setUInt7ForLoad):

11:31 Changeset [101692] by loislo@chromium.org

Web Inspector: chromium: move and adapt Inspector's performance tests for running with run-inspector-perf-tests.py.
https://bugs.webkit.org/show_bug.cgi?id=72260

Reviewed by Pavel Feldman.

PerformanceTests:

  • inspector/first-open-elements.html: Renamed from LayoutTests/inspector/performance/resources/first-open-elements.html.
  • inspector/first-open-scripts.html: Renamed from LayoutTests/inspector/performance/resources/first-open-scripts.html.
  • inspector/inspector-startup-time.html: Renamed from LayoutTests/inspector/performance/resources/inspector-startup-time.html.
  • inspector/network-append-30-requests.html: Renamed from LayoutTests/inspector/performance/resources/network-append-30-requests.html.
  • inspector/performance-test.js: Renamed from LayoutTests/inspector/performance/resources/performance-test.js.

(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.start):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.finish):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype._getJSHeapSize):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.done):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype._runTest):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype._dump):
(initialize_TimeTracker.InspectorTest.runPerformanceTest):
(initialize_TimeTracker.InspectorTest.mark):

  • inspector/show-panel.html: Renamed from LayoutTests/inspector/performance/resources/show-panel.html.

LayoutTests:

  • inspector/performance/resources/console-append-100-lines.html: Removed.
  • inspector/performance/resources/first-open-resources.html: Removed.
11:11 Changeset [101691] by benjamin@webkit.org

URLs are encoded in UTF-8, then decoded as if they are Latin1
https://bugs.webkit.org/show_bug.cgi?id=71758

Reviewed by Darin Adler.

Source/JavaScriptCore:

Add the operator == between a String and a Vector of char. The implementation
is the same as the comparison of String and char* but adds the length as a
parameter for comparing the strings.

(WTF::equal):

  • wtf/text/WTFString.h:

(WTF::operator==):
(WTF::operator!=):

Source/WebCore:

Previously, invalid URLs could have a string emanating from a
partial parsing of the input. The creation of the string was done
through the Latin1 codec regardless of the encoding of the char* url.

This caused two types of issues, URLs were evaluated as half-parsed,
and the coding and decoding of the string was not consistent.

This patch changes KURL::parse() to fallback on the original string
whenever the parsing of the URL fails.

Test: fast/url/invalid-urls-utf8.html

  • platform/KURL.cpp:

(WebCore::KURL::KURL):
(WebCore::KURL::init):
(WebCore::KURL::parse):
Previously, originalString was only used as an optimization to avoid
the allocation of a string. Since this optimization depends on the
comparison of the incoming string and the encoded buffer.
This patches generalizes originalString to always be the original string
being parsed by KURL. The optimization is kept by comparing that string
and the final parsed result.

  • platform/KURL.h:

(WebCore::KURL::parse):

  • platform/cf/KURLCFNet.cpp:

(WebCore::KURL::KURL):

  • platform/mac/KURLMac.mm:

(WebCore::KURL::KURL):

LayoutTests:

  • fast/url/invalid-urls-utf8-expected.txt: Added.
  • fast/url/invalid-urls-utf8.html: Added.

New test for invalid URL where the Unicode characters were mangled
by the parsing.

  • fast/url/file-expected.txt:
  • fast/url/file-http-base-expected.txt:

Two urls where expended by their base URL before found invalid. The partial
parsed result was saved as the new URL.

  • fast/url/host-expected.txt:

The host of two urls were invalid, and partially modified by the parsing.

  • fast/url/idna2003-expected.txt:

The first 'http://www.lookout.net⩴80/' encoded for parsing is http://www.lookout.net::=80/
and fails as invalid. The new result does not modify the original string.

The whitespace in 'http://www .lookout.net/' causes the parsing to fail when parsing
the username because a space is not a UserInfoChar.

  • fast/url/port-expected.txt:

The unicode characters used as the port number were transformed due to
the encoding UTF-8 -> Unicode through the Latin1 codec.

11:02 Changeset [101690] by commit-queue@webkit.org

webkit->chromium DEPS roll 111575->112463
https://bugs.webkit.org/show_bug.cgi?id=73231

Patch by Elliot Poger <epoger@google.com> on 2011-12-01
Reviewed by Yury Semikhatsky.

  • DEPS:
11:00 Changeset [101689] by commit-queue@webkit.org

[Blackberry] Upstream BlackBerry porting of plugin framework -- part 2
https://bugs.webkit.org/show_bug.cgi?id=73513

Patch by Wei Charles <charles.wei@torchmobile.com.cn> on 2011-12-01
Reviewed by Antonio Gomes.

No new tests for now.

  • plugins/blackberry/NPCallbacksBlackBerry.cpp: Added.
  • plugins/blackberry/NPCallbacksBlackBerry.h: Added.
  • plugins/blackberry/PluginViewPrivateBlackBerry.cpp: Added.
  • plugins/blackberry/PluginViewPrivateBlackBerry.h: Added.
10:54 Changeset [101688] by lforschler@apple.com

Versioning.

10:49 Changeset [101687] by kling@webkit.org

JSC/CSSOM: root(CSSElementStyleDeclaration) should never need to follow the element.
<http://webkit.org/b/73561>

Reviewed by Antti Koivisto.

A CSSElementStyleDeclaration should always either have a null element pointer,
or return a valid parentStyleSheet(), since having an element pointer implies
having an associated element sheet.

In light of this, replace the opaque-root-from-element path for style declarations
by an assertion.

  • bindings/js/JSDOMBinding.h:

(WebCore::root):

10:49 Changeset [101686] by lforschler@apple.com

New Tag.

10:30 Changeset [101685] by paroga@webkit.org

[CMake] Make the feature defines for DOM names explicit
https://bugs.webkit.org/show_bug.cgi?id=72812

Reviewed by Daniel Bates.

.:

Preprocessor defines used in WebCore/dom/make_names.pl are set via WEBKIT_FEATURE
for every port in the correspondig platform file. Pass an explicit list of defines
to the CMake macro, so we need to maintain the list only once.

  • Source/cmake/OptionsBlackBerry.cmake:
  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsWinCE.cmake:
  • Source/cmake/WebKitFeatures.cmake:

Source/WebCore:

  • CMakeLists.txt:
10:24 Changeset [101684] by philn@webkit.org

[GTK] Make the new 64-bit Release bot part of the core set
https://bugs.webkit.org/show_bug.cgi?id=73570

Reviewed by Adam Roben.

The 64-bit Release bot re-introduced in r101676 replaces the 64-bit
Debug bot which was already part of the core set. The GTK
gardeners are willing to actively maintain it.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:

(BuildBot.init):

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

(test_builder_name_regexps):

10:02 Changeset [101683] by commit-queue@webkit.org

[Qt] [WK2] QQuickWebView covers QML elements that should be rendered on top.
https://bugs.webkit.org/show_bug.cgi?id=73338

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-12-01
Reviewed by Noam Rosenthal.

Move painting of QQuickWebPage content from canvas afterrendering() to
QSGGeometryNode/QSGMaterial based paint node. Implementation uses QSGMaterialShader
updateState() method to draw TextureMapper graphics layers.
This is considered to be temporary until QSGNode::UserNodeType will be available.

  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPage::QQuickWebPage):
(QQuickWebPagePrivate::QQuickWebPagePrivate):
(PageProxyMaterialShader::attributeNames):
(PageProxyMaterialShader::vertexShader):
(PageProxyMaterialShader::fragmentShader):
(PageProxyMaterial::PageProxyMaterial):
(PageProxyMaterial::type):
(PageProxyMaterial::createShader):
(PageProxyNode::PageProxyNode):
(PageProxyNode::~PageProxyNode):
(PageProxyMaterialShader::updateState):
(QQuickWebPage::updatePaintNode):
(QQuickWebPagePrivate::resetPaintNode):
(QQuickWebPagePrivate::~QQuickWebPagePrivate):

  • UIProcess/API/qt/qquickwebpage_p.h:
  • UIProcess/API/qt/qquickwebpage_p_p.h:
  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::showWebView):

  • UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::didRenderFrame):

09:57 Changeset [101682] by dslomov@google.com

https://bugs.webkit.org/show_bug.cgi?id=73503
[Chromium][V8] Implement ArrayBuffer transfer in chromium.
Portions of this patch come from Luke Zarko.

Source/JavaScriptCore:

Reviewed by David Levin.

  • wtf/ArrayBuffer.cpp:

(WTF::ArrayBuffer::transfer): Changed prototype from pointers to RefPtr.

  • wtf/ArrayBuffer.h:

(WTF::ArrayBufferContents::transfer): Changed prototype from pointers to RefPtr.
(WTF::ArrayBuffer::isNeutered):

  • wtf/TypedArrayBase.h:

(WTF::TypedArrayBase::neuter):

Source/WebCore:

Reviewed by David Levin.

Test: fast/canvas/webgl/arraybuffer-transfer-of-control.html

  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::V8ObjectMap::Writer::writeTransferredArrayBuffer):
(WebCore::V8ObjectMap::Serializer::Serializer):
(WebCore::V8ObjectMap::Serializer::writeAndGreyArrayBufferView):
(WebCore::V8ObjectMap::Serializer::writeArrayBuffer):
(WebCore::V8ObjectMap::Serializer::writeTransferredArrayBuffer):
(WebCore::V8ObjectMap::Serializer::doSerialize):
(WebCore::V8ObjectMap::Reader::read):
(WebCore::V8ObjectMap::Reader::readArrayBufferView):
(WebCore::V8ObjectMap::Deserializer::Deserializer):
(WebCore::V8ObjectMap::Deserializer::tryGetTransferredArrayBuffer):
(WebCore::SerializedScriptValue::create):
(WebCore::neuterBinding):
(WebCore::SerializedScriptValue::transferArrayBuffers):
(WebCore::SerializedScriptValue::SerializedScriptValue):
(WebCore::SerializedScriptValue::deserialize):

  • bindings/v8/SerializedScriptValue.h:

LayoutTests:

Reviewed by David Levin.

  • fast/canvas/webgl/arraybuffer-transfer-of-control-expected.txt: Added.
  • fast/canvas/webgl/arraybuffer-transfer-of-control.html: Added.
  • fast/canvas/webgl/script-tests/arraybuffer-transfer-of-control.js: Added.

(isTypedArray):
(isDataView):
(isArrayBuffer):
(assertBufferClosed):
(createBuffer):
(checkBuffer):
(createView):
(createEveryView):
(checkView):
(checkEmptyArray):
(wrapSend):
(wrapFailSend):
(testList.name.send):
(testList.test):
(.name.send):
(.test):
(testList.testList.concat.):
(viewAndBuffer.return.name.bufferType.0.send):
(viewAndBuffer.return.test):
():
(squashUnrelatedViews.return.name.bufferType.0.send):
(squashUnrelatedViews.return.test):
(squashUnrelatedViews):
(testList):
(doneTest):
(windowHandleMessage):

  • fast/dom/Window/window-postmessage-args.html:
  • platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt:
  • platform/gtk/Skipped: Skipped arraybuffer-transfer-of-control.js on JSC platfroms.
  • platform/mac/Skipped: Skipped arraybuffer-transfer-of-control.js on JSC platfroms.
  • platform/qt/Skipped: Skipped arraybuffer-transfer-of-control.js on JSC platfroms.
  • platform/win/Skipped: Skipped arraybuffer-transfer-of-control.js on JSC platfroms.
09:55 Changeset [101681] by scheib@chromium.org

[Chromium] Test expectations:
http/tests/appcache/fail-on-update-2.html timing out on all platforms
detailed-heapshots-dominators-expansion-preserved-when-sorting.html timing out

  • platform/chromium/test_expectations.txt:
09:49 Changeset [101680] by commit-queue@webkit.org

[WK2][GTK] Change default-font-size and default-monospace-font-size
https://bugs.webkit.org/show_bug.cgi?id=73468

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-12-01
Reviewed by Martin Robinson.

Set 'default-font-size' property value to 16px and 'default-monospace-font-size'
value to 13px.

  • UIProcess/API/gtk/WebKitSettings.cpp:

(webkit_settings_class_init): Change the default font size settings.

  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings): Correct the test.

09:47 Changeset [101679] by rolandsteiner@chromium.org

Shadow ID pseudo-element selectors serialize incorrectly
https://bugs.webkit.org/show_bug.cgi?id=73542

Source/WebCore:

Avoid space for ShadowDescendant combinator.

Reviewed by Dimitri Glazkov.

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::selectorText):

LayoutTests:

Add test cases for complex selectors with shadow ID pseudo-elements.

Reviewed by Dimitri Glazkov.

  • fast/css/css-selector-text-expected.txt:
  • fast/css/css-selector-text.html:
  • fast/css/css-set-selector-text-expected.txt:
  • fast/css/css-set-selector-text.html:
09:39 Changeset [101678] by commit-queue@webkit.org

Popup menu can get stuck in closed state when GtkMenu can't grab mouse.
https://bugs.webkit.org/show_bug.cgi?id=56466

Add a check if popup menu is not visible due to no mouse grab,
Ensure WebCore is in sync with proper state.

Patch by Wajahat Siddiqui <mdwajahatali.siddiqui@motorola.com> on 2011-12-01
Reviewed by Martin Robinson.

Source/WebCore:

  • platform/gtk/PopupMenuGtk.cpp:

(WebCore::PopupMenuGtk::show):

Source/WebKit2:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::failedToShowPopupMenu): Added Method to send message
to WebProcess.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPopupMenuProxy.h:
  • UIProcess/gtk/WebPopupMenuProxyGtk.cpp:

(WebKit::WebPopupMenuProxyGtk::showPopupMenu):

  • WebProcess/WebCoreSupport/WebPopupMenu.h:

(WebKit::WebPopupMenu::client): Added Method to get WebCore::PopupMenuClient.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::failedToShowPopupMenu):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in: Added Message to inform WebProcess ShowPopupMenu failed.
09:36 Changeset [101677] by philn@webkit.org

[GTK] Buildslave switch from 32-bit Debug to 64-bit Release
https://bugs.webkit.org/show_bug.cgi?id=73547

Reviewed by Adam Roben.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Rename

the 32-bit Debug configuration to 64-bit Release. The new slave is
a 64-bit machine already. The 32-bit slave will be shut down.
bui# Source/WebCore/GNUmakefile.am.orig

09:23 Changeset [101676] by commit-queue@webkit.org

[GTK] build-jsc should not trigger gtkdoc generation
https://bugs.webkit.org/show_bug.cgi?id=73552

Patch by Martin Robinson <mrobinson@igalia.com> on 2011-12-01
Reviewed by Philippe Normand.

Do not generate gtkdoc when building projects other than WebKit. In particular, this ensures
that build-jsc does not try to generate gtkdoc.

  • Scripts/webkitdirs.pm:

(buildAutotoolsProject): Only generate gtkdoc if the project is "WebKit".

08:59 Changeset [101675] by eric.carlson@apple.com

When playing audio in <video>, the poster is hidden on play
https://bugs.webkit.org/show_bug.cgi?id=73405

Reviewed by Darin Adler.

  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::hasAvailableVideoFrame): Don't return true if the file

doesn't have video.

08:53 Changeset [101674] by eric.carlson@apple.com

Add Settings for text track types
https://bugs.webkit.org/show_bug.cgi?id=73383

Reviewed by Darin Adler.

No new tests, settings are not used yet.

  • page/Settings.cpp:

(WebCore::Settings::Settings): Initialize new settings.

  • page/Settings.h:

(WebCore::Settings::setShouldDisplaySubtitles): New.
(WebCore::Settings::shouldDisplaySubtitles): Ditto.
(WebCore::Settings::setShouldDisplayCaptions): Ditto.
(WebCore::Settings::shouldDisplayCaptions): Ditto.
(WebCore::Settings::setShouldDisplayTextDescriptions): Ditto.
(WebCore::Settings::shouldDisplayTextDescriptions): Ditto.

08:42 Changeset [101673] by eric.carlson@apple.com

HTMLTrackElement.readyState should return TextTrack "readiness state".
https://bugs.webkit.org/show_bug.cgi?id=73466

Reviewed by Darin Adler.

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::HTMLTrackElement): Don't initialize m_readyState.
(WebCore::HTMLTrackElement::setReadyState): Return the TextTrack state.
(WebCore::HTMLTrackElement::readyState): Set the TextTrack state.

  • html/HTMLTrackElement.h: Remove m_readyState.
  • html/TextTrack.cpp:

(WebCore::TextTrack::TextTrack): Initialize m_readinessState.

  • html/TextTrack.h:

(WebCore::TextTrack::readinessState): New.
(WebCore::TextTrack::setReadinessState): New.

08:28 Changeset [101672] by haraken@chromium.org

Unreviewed, rolling out r101669.
http://trac.webkit.org/changeset/101669
https://bugs.webkit.org/show_bug.cgi?id=73394

Win build and Mac build are failing

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/action_derivedsourcesallinone.py:

(main):

  • WebCore.gypi:
  • bindings/scripts/generate-bindings.pl:
  • page/DOMWindow.idl:
  • webaudio/DOMWindowWebAudio.idl: Removed.
08:22 Changeset [101671] by pfeldman@chromium.org

Web Inspector: further align front-end configurations: get rid of saveAsAvailable preference, inline drag glass pane.
https://bugs.webkit.org/show_bug.cgi?id=73555

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendClientLocal.h:

(WebCore::InspectorFrontendClientLocal::canSaveAs):

  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::canSaveAs):

  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype.hasExtensions):

  • inspector/front-end/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.canSaveAs):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._contextMenu):

  • inspector/front-end/ResourcesPanel.js:
  • inspector/front-end/Settings.js:
  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):

  • inspector/front-end/StylesSidebarPane.js:
  • inspector/front-end/UIUtils.js:

(WebInspector.elementDragStart):
(WebInspector.elementDragEnd):

Source/WebKit/chromium:

  • src/InspectorFrontendClientImpl.cpp:

(WebKit::InspectorFrontendClientImpl::canSaveAs):

  • src/InspectorFrontendClientImpl.h:
  • src/js/DevTools.js:
08:20 Changeset [101670] by pfeldman@chromium.org

Web Inspector: extract static part of the InspectorBackend from the generator.
https://bugs.webkit.org/show_bug.cgi?id=73562

Reviewed by Timothy Hatcher.

We should only generate the mapping between the command parameters and slots,
rest of the backend is static.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/CodeGeneratorInspector.py:

(Generator.go):
(Generator.process_event):
(Generator.process_command):

  • inspector/compile-front-end.sh:
  • inspector/front-end/InspectorBackend.js: Added.

(InspectorBackendClass):
(InspectorBackendClass.prototype.registerCommand):
(InspectorBackendClass.prototype.registerEvent):
(InspectorBackendClass.prototype._invoke):
(InspectorBackendClass.prototype._sendMessageToBackend):
(InspectorBackendClass.prototype._wrapCallbackAndSendMessageObject):
(InspectorBackendClass.prototype.sendMessageObjectToBackend):
(InspectorBackendClass.prototype.registerDomainDispatcher):
(InspectorBackendClass.prototype.dispatch.messageObject.error.proto.getDescription):
(InspectorBackendClass.prototype.dispatch.messageObject.error.proto.toString):
(InspectorBackendClass.prototype.dispatch.messageObject.error.proto.getMessage):
(InspectorBackendClass.prototype.dispatch):
(InspectorBackendClass.prototype.reportProtocolError):
(InspectorBackendClass.prototype.runAfterPendingDispatches):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
08:07 Changeset [101669] by haraken@chromium.org

Use the [Supplemental] IDL for webaudio attributes in Chromium
https://bugs.webkit.org/show_bug.cgi?id=73394

Reviewed by Adam Barth.

  • Overview: Using the [Supplemental] IDL, this patch moves the attribute

declarations of webaudio from DOMWindow.idl into a new IDL file
webaudio/DOMWindowWebAudio.idl, which helps make webaudio a self-contained
feature (aka a module).

  • This patch changes the build flow of WebCore.gyp as follows:

Previous build flow:

foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl;
generate-bindings.pl reads $idl;
generate-bindings.pl generates .h and .cpp files for $idl;

}

New build flow (See the discussions in bug 72138 for more details):

resolve-supplemental.pl depends on all IDL files;
resolve-supplemental.pl reads all IDL files;
resolve-supplemental.pl resolves the dependency of [Supplemental=XXXX];
resolve-supplemental.pl outputs supplemental_dependency.tmp;
foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
generate-bindings.pl reads $idl;
generate-bindings.pl reads supplemental_dependency.tmp;
generate-bindings.pl generates .h and .cpp files for $idl, including all attributes in IDL files whilementing $idl;

}

  • This patch introduces a temporary IDL, [Supplemented]. The [Supplemented] IDL

will be removed after build scripts for all platforms support the [Supplemental] IDL.
The motivation for the [Supplemented] IDL is as follows:

In order to support the [Supplemental] IDL, we need to
(1) run resolve-supplemental.pl and generate supplemental_dependency.tmp
(2) and run generate-bindings.pl with the supplemental_dependency.tmp.

This build flow requires a change on the following build scripts,
but changing all the build scripts all at once without any regression is too difficult:

  • DerivedSources.make
  • DerivedSources.pri
  • GNUmakefile.am
  • PlatformBlackBerry.cmake
  • UseJSC.cmake
  • UseV8.cmake
  • WebCore.vcproj/MigrateScripts
  • WebCore.vcproj/WebCore.vcproj
  • bindings/gobject/GNUmakefile.am
  • WebCore.gyp/WebCore.gyp

Thus, we are planning to change the build scripts one by one, which implies that
we need to allow the temporary state in which some build scripts support [Supplemental] IDL
but others do not. To accomplish this, we introduce a temporary IDL, [Supplemented].
The [Supplemented] IDL on an attribute means that the attribute is marked with [Supplemental]
in another IDL file somewhere, like this:

DOMWindowWebAudio.idl:

interface [

Supplemental=DOMWindow

] DOMWindowWebAudio {

attribute attr1;
attribute attr2;

};

DOMWindow.idl:

interface [
] DOMWindow {

attribute [Supplemented] attr1; This line will be removed after all build scripts support the [Su IDL
attribute [Supplemented] attr2;
This line will be removed after all build scripts support the [Su IDL.
attribute attr3;
attribute attr4;

};

Assuming these IDL files, this patch implements the following logic in generate-bindings.pl:

  • If a given build script supports the [Supplemental] IDL, generate-bindings.pl ignores all attributes with the [Supplemented] IDL.
  • Otherwise, generate-bindings.pl treats all attributes with the [Supplemented] IDL as normal attributes and instead ignores all attributes with the [Supplemental] IDL (i.e. generate-bindings.pl generates nothing from the IDL file with the [Supplemental] IDL).

Tests: webaudio/*

  • WebCore.gyp/WebCore.gyp: Describes the build flow that I described above.
  • WebCore.gyp/scripts/action_derivedsourcesallinone.py:

(main): Reads the IDL file names from the input file (i.e. supplemental_dependency.tmp), which are described at the first column of each line in the input file.

  • WebCore.gypi: Added DOMWindowWebAudio.idl.
  • bindings/scripts/generate-bindings.pl: As a temporary solution, if the platform does not support the [Supplemental] IDL, the perl script ignores the [Supplemental] IDL and instead uses the [Supplemented] IDL. Otherwise, the perl script ignores the [Supplemented] IDL and instead uses the [Supplemental] IDL.
  • page/DOMWindow.idl: Added the [Supplemented] IDL to webaudio-related attributes. As I described above, the [Supplemented] IDL will be removed after all platforms support the [Supplemental] IDL.
  • webaudio/DOMWindowWebAudio.idl: Added. Describes the [Supplemental=DOMWindow] IDL. The attributes in this IDL file should be treated as if they are written in DOMWindow.idl.
08:04 WebKit Team edited by jarred@sencha.com
(diff)
07:56 Changeset [101668] by commit-queue@webkit.org

Upstream credential storage files of BlackBerry porting
https://bugs.webkit.org/show_bug.cgi?id=73280

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2011-12-01
Reviewed by Rob Buis.

Added the basic structure of class CredentialBackingStore
to persist the credential data, and generated
platform/network/blackberry/CredentialStorageBlackBerry.cpp,
to implement CredentialStorage::getFromPersistentStorage
for BlackBerry porting.
Contributed by Torch Team.

  • platform/network/blackberry/CredentialBackingStore.cpp: Added.

(WebCore::CredentialBackingStore::instance):
(WebCore::CredentialBackingStore::CredentialBackingStore):
(WebCore::CredentialBackingStore::~CredentialBackingStore):
(WebCore::CredentialBackingStore::open):
(WebCore::CredentialBackingStore::close):
(WebCore::CredentialBackingStore::addLogin):
(WebCore::CredentialBackingStore::updateLogin):
(WebCore::CredentialBackingStore::hasLogin):
(WebCore::CredentialBackingStore::getLogin):
(WebCore::CredentialBackingStore::removeLogin):
(WebCore::CredentialBackingStore::clear):
(WebCore::CredentialBackingStore::encryptedString):
(WebCore::CredentialBackingStore::decryptedString):

  • platform/network/blackberry/CredentialBackingStore.h: Added.
  • platform/network/blackberry/CredentialStorageBlackBerry.cpp: Added.

(WebCore::CredentialStorage::getFromPersistentStorage):

07:44 Changeset [101667] by ossy@webkit.org

tests_run0.txt gets clobbered when re-running failing tests
https://bugs.webkit.org/show_bug.cgi?id=63844

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-12-01
Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.results_directory):

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:

(AbstractWorker.init):
(_ManagerConnection.start_worker):
(_InlineManager.start_worker):
(_MultiProcessManager.start_worker):
(_WorkerConnection.init):
(_InlineWorkerConnection.init):
(_MultiProcessWorkerConnection.init):

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:

(_TestWorker.init):
(_TestsMixin.test_cancel):
(_TestsMixin.test_done):
(_TestsMixin.test_unknown_message):
(InterfaceTest.test_managerconnection_is_abstract):
(InterfaceTest.test_workerconnection_is_abstract):

  • Scripts/webkitpy/layout_tests/controllers/worker.py:

(Worker.init):
(Worker.safe_init):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_retries_directory):

07:22 Changeset [101666] by ossy@webkit.org

[Qt] http/tests/notifications tests make fast/notifications/notifications-click-event.html fail
https://bugs.webkit.org/show_bug.cgi?id=71693

  • platform/qt/Skipped: Skip one more test - http/tests/notifications/icon-exists-show-alert-during-load.html
07:19 Changeset [101665] by kling@webkit.org

StyledElement: Tidy up copyNonAttributeProperties().
<http://webkit.org/b/73501>

Reviewed by Antti Koivisto.

  • css/CSSStyleDeclaration.h:

Made CSSStyleDeclaration non-copyable.

  • css/CSSMutableStyleDeclaration.h:
  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::copyPropertiesFrom):

copyPropertiesAndStrictnessFrom() redone as copyPropertiesFrom()
since we can copy the strictness bit using existing accessors.

  • dom/StyledElement.cpp:

(WebCore::StyledElement::copyNonAttributeProperties):

Use copyPropertiesFrom() and copy the strictness bit to the new
inline style using the dedicated accessors. Also added some
assertions for good measure.

07:10 Changeset [101664] by haraken@chromium.org

run-bindings-tests is failing on Gtk/Qt/SnowLeopard/Lion bots
https://bugs.webkit.org/show_bug.cgi?id=73558

Reviewed by Csaba Osztrogonác.

The cause of the bug:

foreach my $idlFile (keys %documents) {

$supplementals{$idlFile} = [];
foreach my $dataNode (...) {

if (...) {

...;
push(@{$supplementals{$targetIdlFile}}, $idlFile);
...;

}

}

}

Even if we did push(@{$supplementals{$targetIdlFile}}, $idlFile),
the $supplementals{$targetIdlFile} can be re-initialized by
$supplementals{$idlFile} = [] in subsequent loops.
This patch fixes the bug.

Tests: bindings/scripts/test/TestInterface.idl

  • bindings/scripts/resolve-supplemental.pl:
05:45 Changeset [101663] by aroben@apple.com

Buildbot fix

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved all of the initialization of

BuildmasterConfig not performed by loadBuilderConfig up to the top of the file. This makes
it possible for build steps to reference things like the buildbotURL property of the config.

05:36 Changeset [101662] by aroben@apple.com

Use curl for downloading builds to test slaves

Buildbot's built-in file transfer capabilities are transferring files much more slowly than
curl does. This seems to be due to a combination of buildbot being single-threaded (and thus
often busy servicing web requests, etc.) and using an IPC mechanism with fairly high
overhead (courtesy of the Twisted framework).

Eventually we'd like to make Buildbot's built-in transferring more efficient. In the
meantime we'll try using curl for downloads and keep thinking about a solution for uploads.
This should make the test slaves quite a bit faster, and should ease the CPU load on
build.webkit.org a bit.

Part of <http://webkit.org/b/73484> Mac slaves take 7+ minutes to upload or download a build

Reviewed by Mark Rowe.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Added the CreateWebKitBuildDirectory

to Test slaves. It's run just before DownloadBuiltProduct.
(DownloadBuiltProduct): Changed to be a normal ShellCommand that invokes curl to perform the
download.
(CreateWebKitBuildDirectory): Added. Creates the WebKitBuild directory on a slave.
FileDownload used to do this for us automatically.

05:33 Changeset [101661] by pfeldman@chromium.org

Web Inspector: restore WebKit2 Safari menu items after capabilities refactoring regression.
https://bugs.webkit.org/show_bug.cgi?id=73554

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::frontendLoaded):
(WebCore::InspectorFrontendClientLocal::isDebuggingEnabled):
(WebCore::InspectorFrontendClientLocal::setDebuggingEnabled):
(WebCore::InspectorFrontendClientLocal::isTimelineProfilingEnabled):
(WebCore::InspectorFrontendClientLocal::setTimelineProfilingEnabled):
(WebCore::InspectorFrontendClientLocal::isProfilingJavaScript):
(WebCore::InspectorFrontendClientLocal::startProfilingJavaScript):
(WebCore::InspectorFrontendClientLocal::stopProfilingJavaScript):
(WebCore::InspectorFrontendClientLocal::showConsole):
(WebCore::InspectorFrontendClientLocal::evaluateOnLoad):

  • inspector/InspectorFrontendClientLocal.h:
  • inspector/front-end/InspectorFrontendAPI.js:

(InspectorFrontendAPI._pendingCommands.isDebuggingEnabled):
(InspectorFrontendAPI.setDebuggingEnabled):
(InspectorFrontendAPI.isTimelineProfilingEnabled):
(InspectorFrontendAPI.setTimelineProfilingEnabled):
(InspectorFrontendAPI.isProfilingJavaScript):
(InspectorFrontendAPI.startProfilingJavaScript):
(InspectorFrontendAPI.stopProfilingJavaScript):
(InspectorFrontendAPI.setAttachedWindow):
(InspectorFrontendAPI.showConsole):
(InspectorFrontendAPI.dispatch):
(InspectorFrontendAPI.loadCompleted):

  • inspector/front-end/inspector.js:

Source/WebKit2:

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::didClose):

05:30 Changeset [101660] by pfeldman@chromium.org

Web Inspector: remove capabilities along with the MetaAgent
https://bugs.webkit.org/show_bug.cgi?id=73550

Reviewed by Yury Semikhatsky.

We are now using explicit query commands in order to find out about the capabilities.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/CodeGeneratorInspector.py:

(Generator.go):

  • inspector/Inspector.json:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorMetaAgent.cpp: Removed.
  • inspector/InspectorMetaAgent.h: Removed.
  • inspector/generate-protocol-externs:
05:19 EFLWebKitCodingStyle edited by rakuco@FreeBSD.org
Removing formatting from plain text blocks (diff)
05:15 Changeset [101659] by commit-queue@webkit.org

Web Inspector: front-end should open with elements panel selected upon Inspect Element action.
https://bugs.webkit.org/show_bug.cgi?id=73539

Patch by Pavel Feldman <pfeldman@google.com> on 2011-12-01
Reviewed by Yury Semikhatsky.

  • inspector/front-end/inspector.js:

(WebInspector.doLoadedDone.showInitialPanel):
(WebInspector.inspect):

04:42 Changeset [101658] by commit-queue@webkit.org

MacroAssemblerMIPS does not implement readCallTarget
https://bugs.webkit.org/show_bug.cgi?id=73432

Patch by Chao-ying Fu <fu@mips.com> on 2011-12-01
Reviewed by Zoltan Herczeg.

  • assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::readCallTarget):

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::readCallTarget):

04:17 Changeset [101657] by hayato@chromium.org

Unreviewed. Update chromium test expectations.
Mark two tests flaky.

  • platform/chromium/test_expectations.txt:
04:10 Changeset [101656] by vsevik@chromium.org

Web Inspector: totalOffsetLeft and totalOffsetTop should take scroll into account.
https://bugs.webkit.org/show_bug.cgi?id=73443

Reviewed by Pavel Feldman.

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype._boxForAnchorAtStart):
(WebInspector.TextPrompt.SuggestBox):

  • inspector/front-end/utilities.js:

(Element.prototype.totalOffsetLeft):
(Element.prototype.totalOffsetTop):
(Element.prototype.boxInWindow):

04:04 Changeset [101655] by hayato@chromium.org

Unreviewed. Update chromium test expectations.

  • platform/chromium/test_expectations.txt:
03:58 Changeset [101654] by hayato@chromium.org

Unreviewed. Update chromium test expectations.
Mark svn perftest PASS TIMEOUT on DEBUG.

  • platform/chromium/test_expectations.txt:
03:44 Changeset [101653] by hayato@chromium.org

Unreviewed. Update chromium test expectations.
Mark one inspector tests flaky.

  • platform/chromium/test_expectations.txt:
03:40 Changeset [101652] by hayato@chromium.org

Unreviewed. Update chromium test expectations
Mark two inspector tests flaky.

  • platform/chromium/test_expectations.txt:
03:33 Changeset [101651] by pfeldman@chromium.org

Web Inspector: query backend for capabilities explicitly.
https://bugs.webkit.org/show_bug.cgi?id=73442

Reviewed by Yury Semikhatsky.

Source/WebCore:

This change removes the hardcoded Capabilities values in favor of
explicit query commands issued against the backend. I'll remove the
Meta agent in a subsequent change.

  • bindings/js/ScriptDebugServer.h:

(WebCore::ScriptDebugServer::causesRecompilation):
(WebCore::ScriptDebugServer::supportsNativeBreakpoints):

  • bindings/js/ScriptProfiler.h:

(WebCore::ScriptProfiler::causesRecompilation):
(WebCore::ScriptProfiler::isSampling):
(WebCore::ScriptProfiler::hasHeapProfiler):

  • bindings/v8/ScriptDebugServer.h:

(WebCore::ScriptDebugServer::causesRecompilation):
(WebCore::ScriptDebugServer::supportsNativeBreakpoints):

  • bindings/v8/ScriptProfiler.h:

(WebCore::ScriptProfiler::causesRecompilation):
(WebCore::ScriptProfiler::isSampling):
(WebCore::ScriptProfiler::hasHeapProfiler):

  • inspector/Inspector.json:
  • inspector/InspectorClient.h:

(WebCore::InspectorClient::canClearBrowserCache):
(WebCore::InspectorClient::canClearBrowserCookies):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::show):

  • inspector/InspectorController.h:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::causesRecompilation):
(WebCore::InspectorDebuggerAgent::canSetScriptSource):
(WebCore::InspectorDebuggerAgent::supportsNativeBreakpoints):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::frontendLoaded):

  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::causesRecompilation):
(WebCore::InspectorProfilerAgent::isSampling):
(WebCore::InspectorProfilerAgent::hasHeapProfiler):
(WebCore::InspectorProfilerAgent::disable):
(WebCore::InspectorProfilerAgent::enable):
(WebCore::InspectorProfilerAgent::setFrontend):

  • inspector/InspectorProfilerAgent.h:
  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::canClearBrowserCache):
(WebCore::InspectorResourceAgent::canClearBrowserCookies):

  • inspector/InspectorResourceAgent.h:
  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel):
(WebInspector.DebuggerModel.prototype.enableDebugger):
(WebInspector.DebuggerModel.prototype.canSetScriptSource):

  • inspector/front-end/NetworkItemView.js:

(WebInspector.NetworkItemView):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.onCanClearBrowserCache):
(WebInspector.NetworkLogView.onCanClearBrowserCookies):
(WebInspector.NetworkLogView):
(WebInspector.NetworkLogView.prototype._contextMenu):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):

  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/Settings.js:
  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):

  • inspector/front-end/inspector.js:

(WebInspector.get inspectedPageDomain):
(WebInspector._initializeCapability):
(WebInspector.doLoadedDone):

Source/WebKit/chromium:

  • src/InspectorClientImpl.cpp:

(WebKit::InspectorClientImpl::canClearBrowserCache):
(WebKit::InspectorClientImpl::canClearBrowserCookies):

  • src/InspectorClientImpl.h:
  • src/js/DevTools.js:

LayoutTests:

  • inspector/profiler/detailed-heapshots-test.js:
03:30 Changeset [101650] by hayato@chromium.org

Unreviewed. Update chromium test expectations, marking flaky.

  • platform/chromium/test_expectations.txt:
03:23 Changeset [101649] by hayato@chromium.org

Unreviewed. Update chromium test expectations.
It might be safe to make this svg test flaky.

  • platform/chromium/test_expectations.txt:
03:20 Changeset [101648] by hans@chromium.org

IndexedDB: Fix reverse cursor with non-existent upper bound
https://bugs.webkit.org/show_bug.cgi?id=73220

Reviewed by Tony Chang.

Source/WebCore:

The code previously did not properly handle the case where the
specified upper bound for a reverse cursor did not exist.

Test: storage/indexeddb/cursor-reverse-bug.html

  • storage/IDBLevelDBBackingStore.cpp:

(WebCore::findGreatestKeyLessThanOrEqual):
(WebCore::IDBLevelDBBackingStore::openObjectStoreCursor):
(WebCore::IDBLevelDBBackingStore::openIndexKeyCursor):
(WebCore::IDBLevelDBBackingStore::openIndexCursor):

LayoutTests:

Add test to check that opening a reverse cursor works even when the
key specified as the upper bound does not exist.

  • storage/indexeddb/cursor-reverse-bug-expected.txt: Added.
  • storage/indexeddb/cursor-reverse-bug.html: Added.
03:14 Changeset [101647] by hayato@chromium.org

Unreviewed. Chromium rebaselines after r101638.

  • platformgausi/chromium-cg-mac-leopard/svg/filters/feGaussianBlur-expected.png:
  • platform/chromium-cg-mac-snowleopard/svg/filters/feGaussianBlur-expected.png: Added.
  • platform/chromium-cg-mac/svg/filters/feGaussianBlur-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/filters/feGaussianBlur-expected.png: Added.
  • platform/chromium-mac/svg/filters/feGaussianBlur-expected.png: Removed.
  • platform/mac/svg/filters/feGaussianBlur-expected.txt: Removed.
  • platform/qt/svg/filters/feGaussianBlur-expected.txt: Removed.
  • svg/filters/feGaussianBlur-expected.txt: Renamed from LayoutTests/platform/gtk/svg/filters/feGaussianBlur-expected.txt.
03:08 Changeset [101646] by hayato@chromium.org

Unreviewed. Update chromium test expectations.
Yet another inspector test crash appeared. I really hope they could appear at once.
If I encounter another crash test, it might be better to mark all inspector tests SKIP for chromium for a while.

  • platform/chromium/test_expectations.txt:
02:54 Changeset [101645] by hans@chromium.org

IndexedDB: Cursor pre-fetching
https://bugs.webkit.org/show_bug.cgi?id=73025

Reviewed by Darin Fisher.

Source/WebCore:

No new tests. This doesn't change any semantics.
Actual pre-fetching will not happen in DumpRenderTree.
Chromium will request pre-fetching and have tests for it.

  • storage/IDBBackingStore.h:
  • storage/IDBCallbacks.h:
  • storage/IDBCursor.cpp:

(WebCore::IDBCursor::continueFunction):
(WebCore::IDBCursor::postSuccessHandlerCallback):

Adds a callback that is called everytime the onsuccess handler has
executed on a cursor. This allows the cursor to see if a new call
to continue() was made in the onsuccess handler.

  • storage/IDBCursor.h:
  • storage/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::continueFunction):
(WebCore::IDBCursorBackendImpl::prefetchContinue):
(WebCore::IDBCursorBackendImpl::prefetchContinueInternal):

This is the function that does actual pre-fetching. When called,
it will attempt to step the cursor up to n steps and send the
results back via the new onSuccessWithPrefetch() callback.

(WebCore::IDBCursorBackendImpl::prefetchReset):

This resets the cursor to the position it was at before the last
prefetch call.

  • storage/IDBCursorBackendImpl.h:

(WebCore::IDBCursorBackendImpl::postSuccessHandlerCallback):

  • storage/IDBCursorBackendInterface.h:
  • storage/IDBKey.h:

(WebCore::IDBKey::createInvalid):
(WebCore::IDBKey::createNumber):
(WebCore::IDBKey::createString):
(WebCore::IDBKey::createDate):
(WebCore::IDBKey::createArray):
(WebCore::IDBKey::sizeEstimate):

  • storage/IDBLevelDBBackingStore.cpp:

(WebCore::CursorOptions::CursorImplCommon::CursorImplCommon):
(WebCore::CursorOptions::ObjectStoreCursorImpl::clone):
(WebCore::CursorOptions::ObjectStoreCursorImpl::ObjectStoreCursorImpl):
(WebCore::CursorOptions::IndexKeyCursorImpl::clone):
(WebCore::CursorOptions::IndexKeyCursorImpl::IndexKeyCursorImpl):
(WebCore::CursorOptions::IndexCursorImpl::clone):
(WebCore::CursorOptions::IndexCursorImpl::IndexCursorImpl):

  • storage/IDBRequest.cpp:

(WebCore::IDBRequest::dispatchEvent):

Update dispatchEvent() to call the postSuccessHandlerCallback()

  • storage/IDBRequest.h:

(WebCore::IDBRequest::onSuccessWithPrefetch):

  • storage/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::addPendingEvents):

Allow for adding an arbitrary number of extra pending events.
When a cursor pre-fetches n elements, the transaction should
expect to see n extra onsuccess calls.

  • storage/IDBTransactionBackendImpl.h:
  • storage/IDBTransactionBackendInterface.h:

Source/WebKit/chromium:

Add plumbing for new pre-fetching related functions.

  • public/WebIDBCallbacks.h:

(WebKit::WebIDBCallbacks::onSuccessWithPrefetch):

  • public/WebIDBCursor.h:

(WebKit::WebIDBCursor::deleteFunction):
(WebKit::WebIDBCursor::prefetchContinue):
(WebKit::WebIDBCursor::prefetchReset):
(WebKit::WebIDBCursor::postSuccessHandlerCallback):

  • public/WebIDBTransaction.h:

(WebKit::WebIDBTransaction::addPendingEvents):

  • src/IDBCallbacksProxy.cpp:

(WebKit::IDBCallbacksProxy::onSuccessWithPrefetch):

  • src/IDBCallbacksProxy.h:
  • src/IDBCursorBackendProxy.cpp:

(WebKit::IDBCursorBackendProxy::postSuccessHandlerCallback):

  • src/IDBCursorBackendProxy.h:

(WebKit::IDBCursorBackendProxy::prefetchContinue):
(WebKit::IDBCursorBackendProxy::prefetchReset):

  • src/IDBTransactionBackendProxy.h:

(WebKit::IDBTransactionBackendProxy::addPendingEvents):

  • src/WebIDBCursorImpl.cpp:

(WebKit::WebIDBCursorImpl::prefetchContinue):
(WebKit::WebIDBCursorImpl::prefetchReset):

  • src/WebIDBCursorImpl.h:
02:48 Changeset [101644] by philn@webkit.org

[GTK] WebAudio wav resources access and management
https://bugs.webkit.org/show_bug.cgi?id=73080

Reviewed by Martin Robinson.

For the uninstalled case we assume the user will set a
AUDIO_RESOURCES_PATH environment variable pointing to
WebCore/platform/audio/resources.

  • GNUmakefile.am: Install WAV resources.
  • platform/audio/gtk/AudioBusGtk.cpp:

(WebCore::AudioBus::loadPlatformResource): Support for loading
uninstalled resources.

02:36 Changeset [101643] by hans@chromium.org

IndexedDB: Fix WebIDBObjectStore::createIndex() after r101602
https://bugs.webkit.org/show_bug.cgi?id=73543

Reviewed by Tony Gentilcore.

r101602 introduces a new signature for createIndex(). Until Chromium
has been updated to override that function, the default implementation
must call the old version.

  • public/WebIDBObjectStore.h:

(WebKit::WebIDBObjectStore::createIndex):

02:35 Changeset [101642] by hayato@chromium.org

Unreviewed. Update chromium test expectations, fixing dups.

  • platform/chromium/test_expectations.txt:
02:32 Changeset [101641] by philn@webkit.org

[GTK] enable-webaudio websetting
https://bugs.webkit.org/show_bug.cgi?id=69836

Reviewed by Martin Robinson.

WebKit/gtk:

  • webkit/webkitwebsettings.cpp: New enable-webaudio boolean

setting, set to FALSE by default.
(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):

  • webkit/webkitwebsettingsprivate.h: Ditto.
  • webkit/webkitwebview.cpp: Update WebCore settings when

enable-webaudio value changes.
(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):

Tools:

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::overridePreference): Update WebKitGTK
enable-webaudio setting when a layout test requests it.

01:47 Changeset [101640] by noel.gordon@gmail.com

[chromium] Remove wtf/qt/ThreadingQt.cpp from the gyp projects
https://bugs.webkit.org/show_bug.cgi?id=73527

Reviewed by Simon Hausmann.

wtf/qt/ThreadingQt.cpp was removed in r101477

01:05 Changeset [101639] by fpizlo@apple.com

BitVector isInline check could fail
https://bugs.webkit.org/show_bug.cgi?id=70691

Reviewed by Gavin Barraclough.

Switch back to using the high bit as the inline marker, to make
all of the bit indexing operations simpler. Computing the size in
words and in bytes of a bitvector, using the number of bits as
input is error-prone enough; and with the current approach to
solving the X86 bug we end up getting it wrong. Making it right
seems hard.

So instead, to solve the original problem (the high bit may be
meaningful on 32-bit systems), the out-of-line storage pointer is
right-shifted by 1. Compared to the original BitVector code, this
is a much smaller change (just three lines).

This solves a bug where the DFG was corrupting its call frame
because BitVector lost track of some bits.

  • wtf/BitVector.cpp:

(WTF::BitVector::setSlow):
(WTF::BitVector::resizeOutOfLine):

  • wtf/BitVector.h:

(WTF::BitVector::quickGet):
(WTF::BitVector::quickSet):
(WTF::BitVector::quickClear):
(WTF::BitVector::makeInlineBits):
(WTF::BitVector::isInline):
(WTF::BitVector::outOfLineBits):

01:02 Changeset [101638] by commit-queue@webkit.org

SVG Gaussian blur in 1-dimension is incorrect
https://bugs.webkit.org/show_bug.cgi?id=73029

Patch by Florin Malita <fmalita@google.com> on 2011-12-01
Reviewed by Simon Fraser.

Source/WebCore:

Ensure that the last blurBox result is stored when applying one-dimensional blurs.

  • platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::platformApplyGeneric):

LayoutTests:

  • platform/chromium-win/svg/filters/feGaussianBlur-expected.png: Rebaseline.
00:47 Changeset [101637] by vsevik@chromium.org

Web Inspector: Elements Panel edit as html looks weird with an arrow inside edit box.
https://bugs.webkit.org/show_bug.cgi?id=73462

Reviewed by Pavel Feldman.

  • inspector/front-end/elementsPanel.css:

(#elements-content .editing):
(.elements-tree-editor):

  • inspector/front-end/inspector.css:
00:40 Changeset [101636] by hayato@chromium.org

Unreviewed. Chromium rebaselines.

  • platform/chromium-mac-snowleopard/fast/forms/select-listbox-multiple-no-focusring-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/select-listbox-multiple-no-focusring-expected.png.
  • platform/chromium-win/fast/forms/select-listbox-multiple-no-focusring-expected.png:
00:34 Changeset [101635] by apavlov@chromium.org

Web Inspector: [Styles] Exclamation mark hint ignores property case
https://bugs.webkit.org/show_bug.cgi?id=73535

Reviewed by Pavel Feldman.

  • inspector/front-end/StylesSidebarPane.js:
00:29 Changeset [101634] by hayato@chromium.org

Unreviewed. Update chromium test expectations for xmlhttprequest test.

  • platform/chromium/test_expectations.txt:
00:26 Changeset [101633] by pfeldman@chromium.org

Web Inspector: fix dedicated workers inspection (undefined is not an object).
https://bugs.webkit.org/show_bug.cgi?id=73537

Reviewed by Yury Semikhatsky.

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype.resourceForURL):

  • inspector/front-end/WorkerManager.js:

(WebInspector.WorkerManager.loadCompleted):

00:16 Changeset [101632] by hayato@chromium.org

Unreviewed. Update chromium test expectations for flaky svg test.

  • platform/chromium/test_expectations.txt:
00:10 Changeset [101631] by hayato@chromium.org

Unreviewed. Update chromium test expectations for yet another inspector crash.

  • platform/chromium/test_expectations.txt:
00:07 Changeset [101630] by ossy@webkit.org

[Qt] Unreviewed gardening after r101591.

  • platform/qt/fast/dom/constructed-objects-prototypes-expected.txt: Updated.
00:05 Changeset [101629] by ossy@webkit.org

Fix typo in the tests added by r101575.

  • editing/deleting/delete-and-cleanup-expected.txt:
  • editing/pasteboard/paste-without-nesting-expected.txt:
00:03 Changeset [101628] by hayato@chromium.org

Unreviewed. Chromium rebaselines for svg test.

  • platform/chromium-win/svg/custom/gradient-with-1d-boundingbox-expected.png:
00:00 Changeset [101627] by haraken@chromium.org

[JSC] When XXXX has a NamedConstructor, window.XXXX should be XXXXConstructor
https://bugs.webkit.org/show_bug.cgi?id=73521

Reviewed by Adam Barth.

This is a regression caused by a patch of bug 73307.
If we replaced a custom constructor of window.XXXX (e.g. XXXX is Audio or Option)
with the [NamedConstructor] IDL, fast/js/global-constructors.html,
fast/dom/Window/window-properties.html and fast/dom/call-a-constructor-as-a-function.html
start to fail in JSC.

Before a patch of bug 73007: (correct behavior)

window.Audio => AudioConstructor
window.Option => OptionConstructor
window.HTMLAudioElement => HTMLAudioElementConstructor
window.HTMLOptionElement => HTMLOptionElementConstructor

After a patch of bug 73007: (wrong behavior)

window.Audio => HTMLAudioElementConstructor
window.Option => HTMLOptionElementConstructor
window.HTMLAudioElement => HTMLAudioElementConstructor
window.HTMLOptionElement => HTMLOptionElementConstructor

This patch fixes the above behavior.

Tests: bindings/scripts/test/TestNamedConstructor.idl

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/IDLParser.pm:

(parseExtendedAttributes):
(ParseInterface):

  • bindings/scripts/test/TestNamedConstructor.idl: The test IDL was wrong. NamedConstructor=XXXX(arguments) is a correct format.
  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp: Updated a run-bindings-tests result.
Note: See TracTimeline for information about the timeline view.