Timeline


and

04/12/12:

23:33 Changeset [114090] by tkent@chromium.org

Calendar Picker: remove unnecessary code from calendarPicker.{css,js}
https://bugs.webkit.org/show_bug.cgi?id=83685

Reviewed by Kentaro Hara.

Remove the followings from input files:

  • multi line comments /*...*/ (.js and .css)
  • single line comment ... (.js)
  • repeating whitespace (.js and .css)
  • leading and trailing whitespace (.js and .css)
  • empty lines (.js and .css)

This doesn't work for arbitrary JavaScript or CSS inputs, but
works well for expected input files like
css/make-css-file-arrays.pl

  • make-file-arrays.py:

(strip_whitespace_and_comments):
(main):

23:19 Changeset [114089] by antonm@chromium.org

Mark test as also crashing.

Unreviewed.

  • platform/chromium/test_expectations.txt:
23:14 Changeset [114088] by commit-queue@webkit.org

Chromium: Fix scrollbar tickmark drawing on Mountain Lion
https://bugs.webkit.org/show_bug.cgi?id=83844

Patch by Sailesh Agrawal <sail@chromium.org> on 2012-04-12
Reviewed by James Robinson.

On Mountain Lion overlay scrollbars have a new expanded mode. In expanded mode the scrolllbar is slightly wider which causes the tickmarks to look incorrect. Fix was to explicitly enter expanded mode to get the correct look.
Screenshots:
broken: http://i.imgur.com/PDKYH.png
fixed: http://i.imgur.com/utp0Y.png

  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::paint): Called setExpanded if API is available.

  • platform/mac/NSScrollerImpDetails.h: Exposed the isExpanded: API.
23:11 Changeset [114087] by antonm@chromium.org

Rebaselines.

Unreviewed.

  • platform/chromium-linux/svg/transforms/text-with-mask-with-svg-transform-expected.png:
23:08 Changeset [114086] by antonm@chromium.org

Rebaselines.

Unreviewed.

  • platform/chromium-linux/svg/text/font-size-below-point-five-expected.txt:
23:07 Changeset [114085] by tkent@chromium.org

LocalizedDateICU should ignore timezones
https://bugs.webkit.org/show_bug.cgi?id=83859

Reviewed by Hajime Morita.

udat_parse() and udat_format() shift the input date by the offset of the
default timezone. We don't need this behavior for type=date. So we
specify "GMT" to udat_open().

No new tests. This behavior depends on the timezone setting of the local machine.

  • platform/text/LocalizedDateICU.cpp:

(WebCore::createShortDateFormatter):
Added. Common factory functio for UDateFormat. Use "GMT" instead of the
default timezone.
(WebCore::parseLocalizedDate): Use createShortDateFormatter().
(WebCore::formatLocalizedDate): ditto.

23:00 Changeset [114084] by carlosgc@webkit.org

[GTK] Enable WebKit2 by default in configure
https://bugs.webkit.org/show_bug.cgi?id=83753

Reviewed by Martin Robinson.

  • configure.ac:
22:37 Changeset [114083] by antonm@chromium.org

Rebaselines.

Unreviewed.

  • fast/media/mq-min-pixel-ratio-expected.txt: Added.
  • fast/reflections/reflection-masks-expected.txt: Added.
  • fast/reflections/reflection-masks-opacity-expected.txt: Added.
  • fast/reflections/reflection-masks-outset-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/crash-filter-change-expected.png:
  • platform/chromium-mac-leopard/css3/filters/crash-hw-sw-switch-expected.png:
  • platform/chromium-mac-leopard/css3/filters/custom/missing-custom-filter-shader-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-blur-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-blur-hw-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-brightness-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-brightness-hw-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-combined-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-combined-hw-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-contrast-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-contrast-hw-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-drop-shadow-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-drop-shadow-hw-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-grayscale-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-grayscale-hw-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-hue-rotate-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-hue-rotate-hw-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-invert-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-invert-hw-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-opacity-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-opacity-hw-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-saturate-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-saturate-hw-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-sepia-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-sepia-hw-expected.png:
  • platform/chromium-mac-leopard/css3/filters/regions-expanding-expected.png:
  • platform/chromium-mac-leopard/fast/css/background-shorthand-invalid-url-expected.png:
  • platform/chromium-mac-leopard/fast/media/mq-min-pixel-ratio-expected.png:
  • platform/chromium-mac-leopard/fast/reflections/reflection-direction-expected.png:
  • platform/chromium-mac-leopard/fast/reflections/reflection-masks-expected.png:
  • platform/chromium-mac-leopard/fast/reflections/reflection-masks-opacity-expected.png:
  • platform/chromium-mac-leopard/fast/reflections/reflection-masks-outset-expected.png:
  • platform/chromium-mac-leopard/svg/custom/createImageElement-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/createImageElement2-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-leopard/svg/custom/focus-ring-expected.png:
  • platform/chromium-mac-leopard/svg/custom/image-parent-translation-expected.png:
  • platform/chromium-mac-leopard/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-mac-leopard/svg/custom/image-with-transform-clip-filter-expected.png:
  • platform/chromium-mac-leopard/svg/custom/js-update-image-and-display-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/js-update-image-and-display2-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/js-update-image-and-display3-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/js-update-image-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/pointer-events-image-css-transform-expected.png:
  • platform/chromium-mac-leopard/svg/custom/pointer-events-image-expected.png:
  • platform/chromium-mac-leopard/svg/custom/text-image-opacity-expected.png:
  • platform/chromium-mac-leopard/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png:
  • platform/chromium-mac-leopard/svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
  • platform/chromium-mac-leopard/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/chromium-mac-leopard/svg/wicd/test-rightsizing-b-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-background-images-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/masks/direct-image-mask-expected.png:
  • platform/chromium-mac-snowleopard/compositing/reflections/simple-composited-reflections-expected.png:
  • platform/chromium-mac-snowleopard/css3/filters/crash-hw-sw-switch-expected.png:
  • platform/chromium-mac-snowleopard/fast/media/mq-min-pixel-ratio-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/reflections/reflection-direction-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/fast/reflections/reflection-masks-opacity-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/createImageElement2-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/svg/custom/focus-ring-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/svg/custom/image-parent-translation-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/image-with-transform-clip-filter-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-css-transform-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/svg/custom/text-image-opacity-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/chromium-mac-snowleopard/svg/wicd/test-rightsizing-b-expected.png:
  • platform/chromium-mac/compositing/masks/direct-image-mask-expected.png:
  • platform/chromium-mac/compositing/reflections/simple-composited-reflections-expected.png:
  • platform/chromium-mac/compositing/visibility/visibility-image-layers-expected.png: Added.
  • platform/chromium-mac/css3/filters/crash-filter-change-expected.png:
  • platform/chromium-mac/css3/filters/crash-hw-sw-switch-expected.png:
  • platform/chromium-mac/css3/filters/custom/missing-custom-filter-shader-expected.png:
  • platform/chromium-mac/css3/filters/effect-blur-expected.png:
  • platform/chromium-mac/css3/filters/effect-blur-hw-expected.png:
  • platform/chromium-mac/css3/filters/effect-brightness-expected.png:
  • platform/chromium-mac/css3/filters/effect-brightness-hw-expected.png:
  • platform/chromium-mac/css3/filters/effect-combined-expected.png:
  • platform/chromium-mac/css3/filters/effect-combined-hw-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/css3/filters/effect-contrast-expected.png:
  • platform/chromium-mac/css3/filters/effect-contrast-hw-expected.png:
  • platform/chromium-mac/css3/filters/effect-drop-shadow-expected.png:
  • platform/chromium-mac/css3/filters/effect-drop-shadow-hw-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/css3/filters/effect-grayscale-expected.png:
  • platform/chromium-mac/css3/filters/effect-grayscale-hw-expected.png:
  • platform/chromium-mac/css3/filters/effect-hue-rotate-expected.png:
  • platform/chromium-mac/css3/filters/effect-hue-rotate-hw-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/css3/filters/effect-invert-expected.png:
  • platform/chromium-mac/css3/filters/effect-invert-hw-expected.png:
  • platform/chromium-mac/css3/filters/effect-opacity-expected.png:
  • platform/chromium-mac/css3/filters/effect-opacity-hw-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/css3/filters/effect-saturate-expected.png:
  • platform/chromium-mac/css3/filters/effect-saturate-hw-expected.png:
  • platform/chromium-mac/css3/filters/effect-sepia-expected.png:
  • platform/chromium-mac/css3/filters/effect-sepia-hw-expected.png:
  • platform/chromium-mac/css3/filters/regions-expanding-expected.png:
  • platform/chromium-mac/fast/css/background-shorthand-invalid-url-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/media/mq-min-pixel-ratio-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/reflections/reflection-direction-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/reflections/reflection-masks-expected.png:
  • platform/chromium-mac/fast/reflections/reflection-masks-opacity-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/reflections/reflection-masks-outset-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/threaded: Added.
  • platform/chromium-mac/platform/chromium/virtual/threaded/compositing: Added.
  • platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility: Added.
  • platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-expected.png: Added.
  • platform/chromium-mac/svg/custom/createImageElement-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/custom/createImageElement2-expected.png:
  • platform/chromium-mac/svg/custom/focus-ring-expected.png:
  • platform/chromium-mac/svg/custom/image-parent-translation-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-mac/svg/custom/image-with-transform-clip-filter-expected.png:
  • platform/chromium-mac/svg/custom/js-update-image-and-display-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/custom/js-update-image-and-display2-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/custom/js-update-image-and-display3-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/custom/js-update-image-expected.png:
  • platform/chromium-mac/svg/custom/pointer-events-image-css-transform-expected.png:
  • platform/chromium-mac/svg/custom/pointer-events-image-expected.png:
  • platform/chromium-mac/svg/custom/text-image-opacity-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/chromium-mac/svg/wicd/test-rightsizing-b-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-background-images-expected.png:
  • platform/efl/fast/media/mq-min-pixel-ratio-expected.txt: Removed.
  • platform/efl/fast/reflections/reflection-masks-expected.txt: Removed.
  • platform/efl/fast/reflections/reflection-masks-opacity-expected.txt: Removed.
  • platform/efl/fast/reflections/reflection-masks-outset-expected.png: Removed.
  • platform/efl/fast/reflections/reflection-masks-outset-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.txt: Removed.
  • platform/gtk/fast/media/mq-min-pixel-ratio-expected.txt: Removed.
  • platform/gtk/fast/reflections/reflection-masks-outset-expected.png: Removed.
  • platform/mac-snowleopard/svg/custom/js-update-image-expected.png: Removed.
  • platform/mac-snowleopard/svg/zoom/page/zoom-background-images-expected.png: Removed.
  • platform/mac/fast/media/mq-min-pixel-ratio-expected.txt: Removed.
  • platform/qt/fast/media/mq-min-pixel-ratio-expected.txt: Removed.
  • platform/win/svg/custom/image-with-transform-clip-filter-expected.txt: Removed.
22:31 Changeset [114082] by abarth@webkit.org

Prepare window.location for seamless navigation
https://bugs.webkit.org/show_bug.cgi?id=83843

Reviewed by Eric Seidel.

This patch refactors window.location to flow through
FrameLoader::findFrameForNavigation, which is where we're going to
implement the seamless navigation redirect. This patch shouldn't cause
any observable changes in behavior today, but it will make all the
seamless-window-location* tests in
https://github.com/eseidel/webkit/tree/seamless/LayoutTests/fast/frames/seamless
pass once we merge the seamlesss branch. See
https://github.com/eseidel/webkit/commit/a6e708fa6c643b156397e9a287b40a0868c7959c
for context.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::setLocation):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::locationAccessorSetter):

  • page/Location.cpp:

(WebCore::Location::setHref):
(WebCore::Location::setProtocol):
(WebCore::Location::setHost):
(WebCore::Location::setHostname):
(WebCore::Location::setPort):
(WebCore::Location::setPathname):
(WebCore::Location::setSearch):
(WebCore::Location::setHash):
(WebCore::Location::assign):
(WebCore::Location::replace):
(WebCore::Location::setLocation):
(WebCore):

  • page/Location.h:

(Location):

22:28 Changeset [114081] by danakj@chromium.org

[chromium] Background filters for composited layers
https://bugs.webkit.org/show_bug.cgi?id=80046

Reviewed by Adrienne Walker.

Source/WebCore:

Adds background filters to LayerChromium/CCLayerImpl. These filters are
applied to any pixels in the contents behind the layer and seen through
it.

This is done by adding a backgroundTexture() to the render surface, which
holds the read-back contents of the target framebuffer, background filter
applied, in the surface's own coordinate space. Then this is drawn back
into the frame buffer before the contents of the surface itself is drawn.

Tests: platform/chromium/compositing/filters/background-filter-blur-off-axis.html

platform/chromium/compositing/filters/background-filter-blur-outsets.html
platform/chromium/compositing/filters/background-filter-blur.html

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setBackgroundFilters):
(WebCore):
(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):
(WebCore::LayerChromium::backgroundFilters):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawBackgroundFilters):
(WebCore):
(WebCore::LayerRendererChromium::drawRenderSurfaceQuad):
(WebCore::LayerRendererChromium::getFramebufferTexture):
(WebCore::LayerRendererChromium::isCurrentRenderSurface):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::useManagedTexture):
(WebCore::LayerRendererChromium::bindFramebufferToTexture):
(WebCore::LayerRendererChromium::setScissorToRect):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

  • platform/graphics/chromium/RenderSurfaceChromium.h:

(WebCore::RenderSurfaceChromium::setBackgroundFilters):
(WebCore::RenderSurfaceChromium::backgroundFilters):
(RenderSurfaceChromium):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::setBackgroundFilters):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):
(WebCore::CCLayerImpl::backgroundFilters):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::subtreeShouldRenderToSeparateSurface):
(WebCore::calculateDrawTransformsAndVisibilityInternal):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::drawableContentRect):
(WebCore::CCRenderSurface::prepareBackgroundTexture):
(WebCore):
(WebCore::CCRenderSurface::releaseBackgroundTexture):
(WebCore::CCRenderSurface::computeDeviceTransform):
(WebCore::CCRenderSurface::computeDeviceBoundingBox):
(WebCore::CCRenderSurface::computeReadbackDeviceBoundingBox):
(WebCore::CCRenderSurface::readbackDeviceContentRect):
(WebCore::copyTextureToFramebuffer):
(WebCore::CCRenderSurface::copyDeviceToBackgroundTexture):
(WebCore::getSkBitmapTextureId):
(WebCore::CCRenderSurface::drawContents):
(WebCore::CCRenderSurface::drawReplica):
(WebCore::CCRenderSurface::drawLayer):
(WebCore::CCRenderSurface::drawSurface):
(WebCore::CCRenderSurface::applyFilters):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(CCRenderSurface):
(WebCore::CCRenderSurface::setBackgroundFilters):
(WebCore::CCRenderSurface::backgroundFilters):
(WebCore::CCRenderSurface::backgroundTexture):

  • testing/Internals.cpp:

(WebCore):
(WebCore::Internals::setBackgroundBlurOnNode):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit/chromium:

  • tests/CCLayerImplTest.cpp:

(WebCore::TEST):

LayoutTests:

  • platform/chromium/compositing/filters/background-filter-blur-expected.png: Added.
  • platform/chromium/compositing/filters/background-filter-blur-expected.txt: Added.
  • platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Added.
  • platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.txt: Added.
  • platform/chromium/compositing/filters/background-filter-blur-off-axis.html: Added.
  • platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Added.
  • platform/chromium/compositing/filters/background-filter-blur-outsets-expected.txt: Added.
  • platform/chromium/compositing/filters/background-filter-blur-outsets.html: Added.
  • platform/chromium/compositing/filters/background-filter-blur.html: Added.
21:39 Changeset [114080] by abarth@webkit.org

Remove V8DOMWindowShell::setLocation
https://bugs.webkit.org/show_bug.cgi?id=83833

Reviewed by Eric Seidel.

V8DOMWindowShell::setLocation is only used by document.location. It's
more direct for document.location to call Location::setHref directly.
This integrates correctly with the navigation rules for
<iframe seamless>.

(See https://github.com/eseidel/webkit/compare/master...seamless for
more context about the connection with seamless.)

Reviewed on GitHub:
https://github.com/abarth/webkit/commit/48601729d53a6ac39df5a43b22218c91330c3f61

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore):

  • bindings/v8/V8DOMWindowShell.h:

(V8DOMWindowShell):

  • bindings/v8/custom/V8DocumentLocationCustom.cpp:

(WebCore::V8Document::locationAccessorSetter):

21:19 Changeset [114079] by leviw@chromium.org

Prepare functions in LengthFunctions.h for LayoutUnits
https://bugs.webkit.org/show_bug.cgi?id=83726

Reviewed by Eric Seidel.

Preparing the functions that live in LengthFunctions for sub-pixel layout, which entails
using and returning LayoutUnits instead of integers. There are a number of rendering
classes that are laid out using integers -- see https://trac.webkit.org/wiki/LayoutUnit
for details -- so this also adds integer-specific versions of the length functions for
explicit use in those classes.

No new tests. No change in behavior.

  • css/LengthFunctions.h:

(WebCore): Using LayoutUnits for sub-pixel precision and adding integer-specific versions
of minimumValueForLength and valueForLength that truncate.

  • css/LengthFunctions.cpp:

(WebCore):

  • dom/Document.cpp:

(WebCore::Document::pageSizeAndMarginsInPixels): Document sizes are integral.

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::layOutAxis): The frame tree continues to be integral.

  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::timerFired): RenderMarquee scrolling uses integral values.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight): Table layout is integral.

20:51 Changeset [114078] by commit-queue@webkit.org

Unreviewed, rolling out r114075.
http://trac.webkit.org/changeset/114075
https://bugs.webkit.org/show_bug.cgi?id=83857

Breaks compile (Requested by jamesr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-12

Source/Platform:

  • Platform.gypi:

Source/WebCore:

  • WebCore.gypi:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawYUV):
(WebCore::LayerRendererChromium::drawRGBA):
(WebCore::LayerRendererChromium::copyFrameToTextures):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/VideoFrameChromium.cpp: Renamed from Source/Platform/chromium/src/WebVideoFrame.cpp.

(WebCore):
(WebCore::VideoFrameChromium::~VideoFrameChromium):

  • platform/graphics/chromium/VideoFrameChromium.h: Copied from Source/Platform/chromium/public/WebVideoFrame.h.

(WebCore):
(VideoFrameChromium):

  • platform/graphics/chromium/VideoFrameProvider.h:

(VideoFrameProvider):

  • platform/graphics/chromium/cc/CCVideoDrawQuad.cpp:

(WebCore::CCVideoDrawQuad::create):
(WebCore::CCVideoDrawQuad::CCVideoDrawQuad):

  • platform/graphics/chromium/cc/CCVideoDrawQuad.h:

(CCVideoDrawQuad):
(WebCore::CCVideoDrawQuad::frame):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore):
(WebCore::convertVFCFormatToGC3DFormat):
(WebCore::CCVideoLayerImpl::willDraw):
(WebCore::CCVideoLayerImpl::computeVisibleSize):
(WebCore::CCVideoLayerImpl::reserveTextures):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebVideoFrame.h:

(WebKit):
(WebVideoFrame):
(WebKit::WebVideoFrame::~WebVideoFrame):
(WebKit::WebVideoFrame::format):
(WebKit::WebVideoFrame::width):
(WebKit::WebVideoFrame::height):
(WebKit::WebVideoFrame::planes):
(WebKit::WebVideoFrame::stride):
(WebKit::WebVideoFrame::data):
(WebKit::WebVideoFrame::textureId):
(WebKit::WebVideoFrame::textureTarget):

  • src/AssertMatchingEnums.cpp:
  • src/VideoFrameChromiumImpl.cpp: Added.

(WebKit):
(WebKit::VideoFrameChromiumImpl::toWebVideoFrame):
(WebKit::VideoFrameChromiumImpl::VideoFrameChromiumImpl):
(WebKit::VideoFrameChromiumImpl::format):
(WebKit::VideoFrameChromiumImpl::width):
(WebKit::VideoFrameChromiumImpl::height):
(WebKit::VideoFrameChromiumImpl::planes):
(WebKit::VideoFrameChromiumImpl::stride):
(WebKit::VideoFrameChromiumImpl::data):
(WebKit::VideoFrameChromiumImpl::requiredTextureSize):
(WebKit::VideoFrameChromiumImpl::hasPaddingBytes):
(WebKit::VideoFrameChromiumImpl::textureId):
(WebKit::VideoFrameChromiumImpl::textureTarget):

  • src/VideoFrameChromiumImpl.h: Renamed from Source/Platform/chromium/public/WebVideoFrame.h.

(WebKit):
(VideoFrameChromiumImpl):

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::putCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::supportsType):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

20:47 Changeset [114077] by abarth@webkit.org

Use _self to represnet self-navigation, like in the HTML5 spec
https://bugs.webkit.org/show_bug.cgi?id=83834

Reviewed by Eric Seidel.

This patch aligns the internal state representation of the FrameLoader
more closely with the HTML5 spec. Both the null string and "_self"
represent self-navigation, but the HTML5 spec distinguishes them when
navigating seamless iframes. In that case, "_self" is explicit
self-navigation, whereas a null string will get redirected to the
"master" frame (the closest enclosing non-seamless frame).

This patch shouldn't have any observable behavior changes, but it will
be useful when we merge in the seamless branch from GitHub.
(See https://github.com/eseidel/webkit/commit/df0e71fcacdb0e7e45fe669afe1314cec5b76523
which contains this change.)

Once the seamless branch lands, this change will be tested by a number
of tests in
https://github.com/eseidel/webkit/tree/seamless/LayoutTests/fast/frames/seamless
including seamless-hyperlink.html.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadURLIntoChildFrame):
(WebCore::FrameLoader::loadURL):

20:11 Changeset [114076] by rniwa@webkit.org

Extract PerfTest class from PerfTestRunner
https://bugs.webkit.org/show_bug.cgi?id=83847

Reviewed by Hajime Morita.

Extracted PerfTest and ChromiumStylePerfTest from PerfTestRunner. This class abstracts a test
that was previously represented by a tuple.

Also moved the logic to determine whether a given test is chromium style or not from run() to
_collect_tests(). And moved the output parsing algorithms for parser style and chromium style
tests from PerfTestRunner to PerfTest and ChromiumStylePerfTest respectively so that we may
add new types of tests more easily.

  • Scripts/webkitpy/performance_tests/perftest.py: Added.

(PerfTest):
(PerfTest.init):
(PerfTest.test_name):
(PerfTest.dirname):
(PerfTest.path_or_url):
(PerfTest._should_ignore_line_in_parser_test_result):
(PerfTest.parse_output):
(ChromiumStylePerfTest):
(ChromiumStylePerfTest.init):
(ChromiumStylePerfTest.parse_output):

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._collect_tests):
(PerfTestsRunner.run):
(PerfTestsRunner._run_tests_set):
(PerfTestsRunner._run_single_test):

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(run_test):
(_tests_for_runner):
(test_run_test_set_with_json_output):
(test_run_test_set_with_json_source):
(test_run_test_set_with_multiple_repositories):
(_collect_tests_and_sort_test_name):
(test_collect_tests):
(test_collect_tests_with_skipped_list):

19:52 Changeset [114075] by jamesr@google.com

[chromium] Move WebVideoFrame into Platform and remove WebCore::VideoFrameChromium wrapper API
https://bugs.webkit.org/show_bug.cgi?id=83851

Reviewed by Adam Barth.

Source/Platform:

Move WebVideoFrame API into Platform.

  • Platform.gypi:
  • chromium/public/WebVideoFrame.h: Renamed from Source/WebCore/platform/graphics/chromium/VideoFrameChromium.h.

(WebKit):
(WebVideoFrame):
(WebKit::WebVideoFrame::~WebVideoFrame):
(WebKit::WebVideoFrame::format):
(WebKit::WebVideoFrame::width):
(WebKit::WebVideoFrame::height):
(WebKit::WebVideoFrame::planes):
(WebKit::WebVideoFrame::stride):
(WebKit::WebVideoFrame::data):
(WebKit::WebVideoFrame::textureId):
(WebKit::WebVideoFrame::textureTarget):

  • chromium/src/WebVideoFrame.cpp: Renamed from Source/WebCore/platform/graphics/chromium/VideoFrameChromium.cpp.

(WebKit):

Source/WebCore:

Remove VideoFrameChromium wrapper and converts WebCore code to using the Platform WebVideoFrame API directly.
Some utility code that previously existed on VideoFrameChromium and only had one caller, such as doing
width/height adjustements for YV12 frames, is moved into the calling code (CCVideoLayerImpl).

Covered by existing media/ and compositing/ layout tests.

  • WebCore.gypi:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawYUV):
(WebCore::LayerRendererChromium::drawRGBA):
(WebCore::LayerRendererChromium::copyFrameToTextures):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/VideoFrameProvider.h:

(VideoFrameProvider):

  • platform/graphics/chromium/cc/CCVideoDrawQuad.cpp:

(WebCore::CCVideoDrawQuad::create):
(WebCore::CCVideoDrawQuad::CCVideoDrawQuad):

  • platform/graphics/chromium/cc/CCVideoDrawQuad.h:

(WebKit):
(CCVideoDrawQuad):
(WebCore::CCVideoDrawQuad::frame):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore):
(WebCore::convertVFCFormatToGC3DFormat):
(WebCore::CCVideoLayerImpl::willDraw):
(WebCore::videoFrameDimension):
(WebCore::hasPaddingBytes):
(WebCore::CCVideoLayerImpl::computeVisibleSize):
(WebCore::CCVideoLayerImpl::reserveTextures):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:

(WebKit):

Source/WebKit/chromium:

Moves the WebVideoFrame interface into Platform and removes the now unnecessary VideoFrameChromiumImpl adapter
implementation.

  • WebKit.gyp:
  • public/WebVideoFrame.h:
  • src/AssertMatchingEnums.cpp:
  • src/VideoFrameChromiumImpl.cpp: Removed.
  • src/VideoFrameChromiumImpl.h: Removed.
  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::putCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::supportsType):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

19:51 Changeset [114074] by ap@apple.com

REGRESSION (r113900): Text tests started failing
https://bugs.webkit.org/show_bug.cgi?id=83724

Reviewed by Dan Bernstein.

Source/WebCore:

  • Resources/DefaultFonts.plist.in: Use serif fonts for standard family again,

and updated the list with better fonts for Japanese.

LayoutTests:

  • platform/mac/Skipped: unskip the tests.
  • platform/mac/fast/ruby/nested-ruby-expected.png:
  • platform/mac/fast/ruby/nested-ruby-expected.txt:
  • platform/mac/fast/text/international/002-expected.png:
  • platform/mac/fast/text/international/002-expected.txt:

Updated for minor rendering differences.

19:49 Changeset [114073] by dimich@chromium.org

Merge 113132 - [Chromium] Out-of-process font loading garbles text
https://bugs.webkit.org/show_bug.cgi?id=83002

Reviewed by Kent Tamura.

Initialize m_CTFont by using m_cgFont in FontPlatformData when we use
out-of-process font loading.

No new tests. This problem only occurs when the user uses a third party
font management software like Font Explorer so it is difficult to add
tests.

  • platform/graphics/chromium/CrossProcessFontLoading.mm:

(WebCore):
(WebCore::FontPlatformData::loadFont): If font loading fails, set null to outNSFont so that the FontPlatformData won't be used.

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::ctFont): Modified to return the appropriate NSFont object when the font from the browser process.

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::createFontPlatformData): Returns null when the generated FontPlatformData object doesn't have NSFont object.

TBR=bashi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10072004

19:30 Changeset [114072] by benjamin@webkit.org

Improve replaceUsingStringSearch() for case of a single character searchValue
https://bugs.webkit.org/show_bug.cgi?id=83738

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-12
Reviewed by Geoffrey Garen.

This patch improves replaceUsingStringSearch() with the following:
-Add a special case for single character search, taking advantage of the faster WTF::find().
-Inline replaceUsingStringSearch().
-Use StringImpl::create() instead of UString::substringSharingImpl() since we know we are in the bounds

by definition.

This gives less than 1% improvement for the multicharacter replace.
The single character search show about 9% improvement.

  • runtime/StringPrototype.cpp:

(JSC::replaceUsingStringSearch):

19:25 Changeset [114071] by benjamin@webkit.org

Inline StringImpl::find(UChar, ...)
https://bugs.webkit.org/show_bug.cgi?id=83737

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-12
Reviewed by Geoffrey Garen.

The implementation of StringImpl::find() is a simple branch before invoking one of
two inline functions. The overhead of having a function for StringImpl::find() is significant.

It is better to let the compiler decide if that should be inlined or not.

  • wtf/text/StringImpl.cpp:
  • wtf/text/StringImpl.h:

(StringImpl):
(WTF::find):
(WTF):
(WTF::reverseFind):
(WTF::StringImpl::find):

  • wtf/text/WTFString.h:
19:12 Changeset [114070] by lforschler@apple.com

Versioning.

18:54 Changeset [114069] by ap@apple.com

Preprocessing text files with modern clang treats double slashes in comments
https://bugs.webkit.org/show_bug.cgi?id=83827

Reviewed by Mark Rowe.

Source/WebCore:

  • DerivedSources.make: Pass appropriate flags to both llvm and gcc.

Source/WebKit2:

  • DerivedSources.make: Pass appropriate flags to both llvm and gcc.
18:36 Changeset [114068] by lforschler@apple.com

Merged r113415.

18:32 Changeset [114067] by commit-queue@webkit.org

Add Encrypted Media Extensions events and errors to HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=82974

Patch by David Dorwin <ddorwin@chromium.org> on 2012-04-12
Reviewed by Adam Barth.

The new events and errors are behind the ENABLE(ENCRYPTED_MEDIA) feature define.
Implementation is based on v0.1 of the draft proposal at
http://dvcs.w3.org/hg/html-media/raw-file/tip/encrypted-media/encrypted-media.html#events.

Source/WebCore:

Tests: fast/events/constructors/media-key-event-constructor.html

media/encrypted-media/encrypted-media-constants.html
media/encrypted-media/encrypted-media-events.html

  • WebCore.gypi:
  • bindings/v8/Dictionary.cpp:

(WebCore::Dictionary::get):
(WebCore):

  • bindings/v8/Dictionary.h:

(WebCore):
(Dictionary):

  • dom/EventNames.h:

(WebCore):

  • dom/EventNames.in:
  • html/HTMLAttributeNames.in:
  • html/HTMLMediaElement.cpp:

(WebCore):
(WebCore::HTMLMediaElement::mediaPlayerKeyAdded):
(WebCore::HTMLMediaElement::mediaPlayerKeyError):
(WebCore::HTMLMediaElement::mediaPlayerKeyMessage):
(WebCore::HTMLMediaElement::mediaPlayerKeyNeeded):

  • html/HTMLMediaElement.h:

(HTMLMediaElement):

  • html/HTMLMediaElement.idl:
  • html/MediaError.h:
  • html/MediaError.idl:
  • html/MediaKeyError.h: Added.

(WebCore):
(MediaKeyError):
(WebCore::MediaKeyError::create):
(WebCore::MediaKeyError::code):
(WebCore::MediaKeyError::MediaKeyError):

  • html/MediaKeyError.idl: Added.
  • html/MediaKeyEvent.cpp: Added.

(WebCore):
(WebCore::MediaKeyEventInit::MediaKeyEventInit):
(WebCore::MediaKeyEvent::MediaKeyEvent):
(WebCore::MediaKeyEvent::~MediaKeyEvent):
(WebCore::MediaKeyEvent::interfaceName):

  • html/MediaKeyEvent.h: Added.

(WebCore):
(MediaKeyEventInit):
(MediaKeyEvent):
(WebCore::MediaKeyEvent::create):
(WebCore::MediaKeyEvent::keySystem):
(WebCore::MediaKeyEvent::sessionId):
(WebCore::MediaKeyEvent::initData):
(WebCore::MediaKeyEvent::message):
(WebCore::MediaKeyEvent::defaultURL):
(WebCore::MediaKeyEvent::errorCode):
(WebCore::MediaKeyEvent::systemCode):

  • html/MediaKeyEvent.idl: Added.
  • page/DOMWindow.idl:
  • platform/graphics/MediaPlayer.cpp:

(WebCore):
(WebCore::MediaPlayer::keyAdded):
(WebCore::MediaPlayer::keyError):
(WebCore::MediaPlayer::keyMessage):
(WebCore::MediaPlayer::keyNeeded):

  • platform/graphics/MediaPlayer.h:

(MediaPlayerClient):
(WebCore::MediaPlayerClient::mediaPlayerKeyAdded):
(WebCore::MediaPlayerClient::mediaPlayerKeyError):
(WebCore::MediaPlayerClient::mediaPlayerKeyMessage):
(WebCore::MediaPlayerClient::mediaPlayerKeyNeeded):
(MediaPlayer):

Source/WebKit/chromium:

  • public/WebMediaPlayerClient.h:
  • src/AssertMatchingEnums.cpp:
  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::keyAdded):
(WebKit):
(WebKit::WebMediaPlayerClientImpl::keyError):
(WebKit::WebMediaPlayerClientImpl::keyMessage):
(WebKit::WebMediaPlayerClientImpl::keyNeeded):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

LayoutTests:

  • fast/events/constructors/media-key-event-constructor-expected.txt: Added.
  • fast/events/constructors/media-key-event-constructor.html: Added.
  • fast/js/resources/js-test-pre.js:

(shouldBeZero):
(shouldBeEmptyString):

  • media/encrypted-media/encrypted-media-constants-expected.txt: Added.
  • media/encrypted-media/encrypted-media-constants.html: Added.
  • media/encrypted-media/encrypted-media-events-expected.txt: Added.
  • media/encrypted-media/encrypted-media-events.html: Added.
  • media/video-test.js:

(testExpected):
(testArraysEqual):

18:29 Changeset [114066] by eae@chromium.org

Add size_t versions of multiplication and division operators to FractionalLayoutUnit and remove unneeded casts.

18:26 Changeset [114065] by andersca@apple.com

Reset the user preferred language overrides in Internals::reset
https://bugs.webkit.org/show_bug.cgi?id=83845

Reviewed by Ryosuke Niwa.

We don't want setting the language override in one test to affect subsequent tests,
so make sure to reset it in Internals::reset.

  • testing/Internals.cpp:

(WebCore::Internals::reset):

18:11 Changeset [114064] by commit-queue@webkit.org

Make layout tests not access apache on localhost:80
https://bugs.webkit.org/show_bug.cgi?id=82197

Patch by Pablo Flouret <pablof@motorola.com> on 2012-04-12
Reviewed by Ryosuke Niwa.

It pollutes the logs of people running a local webserver, and has the
potential for changing the results of tests run locally.

  • fast/dom/onerror-img.html:
  • fast/js/custom-constructors-expected.txt:
  • fast/js/script-tests/custom-constructors.js:
  • fast/notifications/notifications-double-show.html:
  • fast/notifications/notifications-with-permission.html:
  • fast/notifications/notifications-without-permission.html:
18:08 Changeset [114063] by caseq@chromium.org

[chromium][refactoring] merge CCSingleThreadProxy::{commitIfNeeded,doComposite} into commitAndComposite()
https://bugs.webkit.org/show_bug.cgi?id=83837

Reviewed by James Robinson.

  • merge CCSingleThreadProxy::commitIfNeeded() and CCSingleThreadProxy::doComposite() into commitAndComposite()
  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::compositeAndReadback): call site updated.
(WebCore::CCSingleThreadProxy::compositeImmediately): ditto.
(WebCore::CCSingleThreadProxy::commitAndComposite):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:
18:07 Changeset [114062] by japhet@chromium.org

Remove FrameLoader:m_isLoadingMainResource, since it is always
false at the only point it is checked.
https://bugs.webkit.org/show_bug.cgi?id=83819

Reviewed by Adam Barth.

No new tests, no functionality change intended.

  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::end): Merge with endIfNotLoadingMainResource(), always end, assert that we're still attached.

  • loader/DocumentWriter.h:
  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h: Remove isLoadingMainResource(), didEndDocument(), and m_isLoadingMainResource.
18:03 Changeset [114061] by lforschler@apple.com

Merged r113649.

18:01 Changeset [114060] by lforschler@apple.com

Merged r113528.

17:58 Changeset [114059] by rwlbuis@webkit.org

XMLSerializer().serializeToString() doesn't generate the XML declaration markup like Opera and Firefox
https://bugs.webkit.org/show_bug.cgi?id=83432

Reviewed by Ryosuke Niwa.

Source/WebCore:

Serialize the xml declaration exactly as parsed, if present in the document.

Test: fast/dom/dom-parse-serialize-xmldecl.html

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::setXMLStandalone): update xmlStandalone to either yes or no.

  • dom/Document.h:

(WebCore::Document::xmlStandalone):
(WebCore::Document::xmlStandaloneStatus): xmlStandalone can be unspecified, yes or no.
(WebCore::Document::hasXMLDeclaration): test if xml declaration is present.
(WebCore::Document::setHasXMLDeclaration):
(Document):

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendXMLDeclaration): write xml declaration if present.
(WebCore):
(WebCore::MarkupAccumulator::appendStartMarkup):

  • editing/MarkupAccumulator.h:

(MarkupAccumulator):

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::startDocument): call setHasXmlDeclaration and any declaration strings parsed.

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::startDocument): call setHasXmlDeclaration and any declaration strings parsed.

LayoutTests:

Verify that xml declaration gets serialized if present. The updated test results are improvements.

  • fast/dom/dom-parse-serialize-display-expected.txt:
  • fast/dom/dom-parse-serialize-expected.txt:
  • fast/dom/dom-parse-serialize-xmldecl-expected.txt: Added.
  • fast/dom/dom-parse-serialize-xmldecl.html: Added.
  • fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
  • fast/xsl/xslt-processor-expected.txt:
  • http/tests/xmlhttprequest/xml-encoding-expected.txt:
  • platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
  • platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
17:52 Changeset [114058] by lforschler@apple.com

Merged r112023.

17:42 Changeset [114057] by abarth@webkit.org

window.open should prepare for seamless navigation by using findFrameForNavigation
https://bugs.webkit.org/show_bug.cgi?id=83835

Reviewed by Ryosuke Niwa.

Before this patch, window.open called FrameTree::find and
Document::canNavigate separately. This patch refactors the code to
call FrameLoader::findFrameForNavigation, which does both. This
refactoring prepares window.open to understand seamless navigation,
which will happen in findFrameForNavigation.

This patch should have no behavior change today, but once we merge the
seamless branch, this change will be tested by
https://github.com/eseidel/webkit/blob/seamless/LayoutTests/fast/frames/seamless/seamless-window-open.html

See https://github.com/eseidel/webkit/commit/a0d8b7defbb63047912aefbc8e22bca4f0638c37 for context.

  • WebCore.exp.in:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::findFrameForNavigation):
(WebCore::createWindow):

  • loader/FrameLoader.h:

(FrameLoader):

17:26 Changeset [114056] by commit-queue@webkit.org

Convert layout test resource PNGs to sRGB. Some tests, such as
compositing/color-matching/image-color-matching.html, expect that
images with an RGB profile will not be altered when displayed. However,
some of the resources have RGB profiles that are different from sRGB
and actually should change when displayed with color profile support.

https://bugs.webkit.org/show_bug.cgi?id=83799

Patch by Tony Payne <tpayne@chromium.org> on 2012-04-12
Reviewed by Adam Barth.

  • compositing/resources/thiswayup.png:
  • css3/filters/resources/reference.png:
  • fast/media/resources/apple_logo_half_size.png:
  • fast/reflections/resources/kate.png:
  • svg/as-border-image/resources/large-tiles.png:
  • svg/custom/resources/green-checker.png:
  • svg/custom/resources/red-checker.png:
  • svg/wicd/resources/test-svg-child-object-rightsizing.png:
17:24 Changeset [114055] by lforschler@apple.com

Merged r111977.

17:20 Changeset [114054] by lforschler@apple.com

Merged r111108.

17:15 Changeset [114053] by lforschler@apple.com

Merged r110150.

17:09 Changeset [114052] by msaboff@apple.com

StructureStubInfo::reset() causes leaks of PolymorphicAccessStructureList and ExecutableMemoryHandle objects
https://bugs.webkit.org/show_bug.cgi?id=83823

Reviewed by Gavin Barraclough.

Put the clearing of the accessType to after the call to deref() so that
deref() can use the accessType to delete referenced objects as needed.

  • bytecode/StructureStubInfo.h:

(JSC::StructureStubInfo::reset):

17:08 Changeset [114051] by lforschler@apple.com

New Tag.

17:05 Changeset [114050] by lforschler@apple.com

Merged r110139.

17:03 Changeset [114049] by scheib@chromium.org

[Chromium] Marking fast/regions/region-overflow-break.html as image failure on Mac.

  • platform/chromium/test_expectations.txt:
16:58 Changeset [114048] by aestes@apple.com

REGRESSION (r102262): iAd Producer relies on CSSStyleDeclaration property setters respecting '!important'
https://bugs.webkit.org/show_bug.cgi?id=83832

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Shipping versions of iAd Producer rely on the pre-r102262 behavior of
respecting '!important' when specified in a CSSStyleDeclaration
property setter. Restore this quirky behavior for versions of the app
that expect it.

  • WebCore.exp.in: Export

Settings::setShouldRespectPriorityInCSSAttributeSetters().

  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::JSCSSStyleDeclaration::putDelegate): If
setShouldRespectPriorityInCSSAttributeSetters() is true, restore the
pre-r102262 behavior wherein we attempt to parse '!important' out of
the property value.

  • page/Settings.cpp:

(WebCore::Settings::setShouldRespectPriorityInCSSAttributeSetters):
(WebCore::Settings::shouldRespectPriorityInCSSAttributeSetters):

  • page/Settings.h:

Source/WebKit/mac:

  • Misc/WebKitVersionChecks.h: Indicate that 535.13.0 was the first

version of WebKit.framework to ignore '!important' in
CSSStyleDeclaration property setters.

  • WebView/WebView.mm:

(shouldRespectPriorityInCSSAttributeSetters):
(-[WebView _commonInitializationWithFrameName:groupName:]): Enable a
quirk to restore pre-r102262 behavior if the application is iAd Producer
and was linked against a version of WebKit.framework that had the old behavior.

16:58 Changeset [114047] by lforschler@apple.com

Merged r109480.

16:55 Changeset [114046] by achicu@adobe.com

REGRESSION(112745) [CSS Filters] Memory use explosion for offscreen filtered elements
https://bugs.webkit.org/show_bug.cgi?id=83815

Reviewed by Simon Fraser.

Source/WebCore:

The filtered area used to be the dirty rect intersected by the bounding box of the
layer. During a previous change that behavior was lost, so adding it back now.

Also, removing the memory buffers used to compute filters after the filter is computed.
They are deleted next time the filter is applied anyway, so there's no need to keep the
memory for them.

Test: css3/filters/offscreen-filters-memory-usage.html

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::prepare):
(WebCore):
(WebCore::FilterEffectRenderer::clearIntermediateResults):
(WebCore::FilterEffectRendererHelper::prepareFilterEffect):
(WebCore::FilterEffectRendererHelper::applyFilterEffect):

  • rendering/FilterEffectRenderer.h:

(FilterEffectRenderer):

LayoutTests:

Adding a test that creates a lot of layers outside the viewport. The memory should not grow
and the browser should not crash.

  • css3/filters/offscreen-filters-memory-usage-expected.txt: Added.
  • css3/filters/offscreen-filters-memory-usage.html: Added.
16:10 Changeset [114045] by bfulgham@webkit.org

[WinCairo] Build fix after Windows export definition file change.

  • win/WebKit2CFLite.def: This file needs to be kept in sync with

WebKit2.def (aside from the WebKitInterface exports.)

16:08 Changeset [114044] by bfulgham@webkit.org

[WinCairo] Build fix after addition of openTypeTable.

  • platform/graphics/FontPlatformData.h:

(FontPlatformData): The openTypeTable declaration is needed
for WinCairo as well.

  • platform/graphics/win/FontPlatformDataWin.cpp:

(WebCore):
(WebCore::FontPlatformData::openTypeTable): The implementation
of openTypeTable is needed for non-CG builds.

16:00 Changeset [114043] by scheib@chromium.org

Image failures due to text rendering change.
Bug filed and test flagged failing.
https://bugs.webkit.org/show_bug.cgi?id=83826

Unreviewed.

  • platform/chromium/test_expectations.txt:
15:28 Changeset [114042] by kbalazs@webkit.org

[Qt] Fix WebKit1 build with V8
https://bugs.webkit.org/show_bug.cgi?id=83322

Reviewed by Adam Barth.

Source/JavaScriptCore:

  • yarr/yarr.pri:

Source/WebCore:

Make it possible to build WebKit1 with v8.
WebKit2 is not covered yet so it need to be disabled.
To build webkit with --v8 one need a qtjsbackend with
an up-to-date copy of v8. Thanks to Peter Varga such
a public repository is available on gitorious:
https://qt.gitorious.org/~stampho/qt/stamphos-qtjsbackend.

This patch contains some build fix with !ENABLE(INSPECTOR)
from it's previous version. These are not necessary now
but I kept them because they makes sense.

No change in behaviour so no new tests.

  • DerivedSources.pri:
  • Target.pri:
  • WebCore.pri:
  • bindings/v8/ScriptController.cpp:
  • bindings/v8/ScriptControllerQt.cpp:
  • bindings/v8/ScriptProfiler.cpp:

(WebCore::retainedDOMInfo):
(WebCore::ScriptProfiler::initialize):

  • bindings/v8/ScriptState.cpp:

(WebCore::evalEnabled):
(WebCore::setEvalEnabled):

  • bindings/v8/V8Binding.cpp:

(WebCore):

  • bindings/v8/V8Binding.h:

(V8BindingPerIsolateData):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initContextIfNeeded):

  • bindings/v8/V8GCForContextDispose.cpp:

(WebCore::V8GCForContextDispose::pseudoIdleTimerFired):

  • bindings/v8/custom/V8InjectedScriptManager.cpp:
  • config.h:
  • editing/TextIterator.cpp:
  • html/MediaFragmentURIParser.cpp:
  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
  • platform/qt/PlatformSupportQt.cpp:

(WebCore::PlatformSupport::popupsAllowed):

Source/WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::didCreateScriptContext):

  • WebCoreSupport/FrameLoaderClientQt.h:

(FrameLoaderClientQt):
(WebCore::FrameLoaderClientQt::allowScriptExtension):

  • WebCoreSupport/InitWebCoreQt.cpp:

Source/WTF:

  • wtf/StdLibExtras.h:

(WTF):

Tools:

  • DumpRenderTree/qt/DumpRenderTree.pro:
  • qmake/mkspecs/features/default_post.prf:
  • qmake/mkspecs/features/default_pre.prf:
  • qmake/mkspecs/features/features.prf:
15:19 Changeset [114041] by commit-queue@webkit.org

IndexedDB: Refactor cursor iteration to remove duplicate code
https://bugs.webkit.org/show_bug.cgi?id=83302

Patch by Alec Flett <alecflett@chromium.org> on 2012-04-12
Reviewed by Ojan Vafai.

No new tests, no behavior changes.

  • Modules/indexeddb/IDBBackingStore.h:

(Cursor):

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore):

14:54 Changeset [114040] by andersca@apple.com

More rebaselining.

  • platform/mac/fast/dom/Window/window-properties-expected.txt:
14:39 Changeset [114039] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=83821
Move dfg repatching properties of structure stub info into a union

Reviewed by Oliver Hunt.

We want to be able to have similar properties for the baseline JIT, some restructuring to prepare for this.

  • bytecode/StructureStubInfo.h:

(StructureStubInfo):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

  • dfg/DFGRepatch.cpp:

(JSC::DFG::dfgRepatchByIdSelfAccess):
(JSC::DFG::linkRestoreScratch):
(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::tryBuildGetByIDProtoList):
(JSC::DFG::emitPutReplaceStub):
(JSC::DFG::emitPutTransitionStub):
(JSC::DFG::tryCachePutByID):
(JSC::DFG::tryBuildPutByIdList):
(JSC::DFG::dfgResetGetByID):
(JSC::DFG::dfgResetPutByID):

14:38 Changeset [114038] by barraclough@apple.com

Delete a bunch of unused, copy & pasted values in JIT.h
https://bugs.webkit.org/show_bug.cgi?id=83822

Reviewed by Oliver Hunt.

The only architecture we support the JSVALUE64 JIT on is x86-64, all the patch offsets for other architectures are just nonsense.

  • jit/JIT.h:

(JIT):

14:19 Changeset [114037] by schenney@chromium.org

[Chromium] Flaky svg/W3C-SVG-1.1/filters-conv-01-f.svg
https://bugs.webkit.org/show_bug.cgi?id=83820

Unreviewed Chromium test expectations.

  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
  • platform/chromium/test_expectations.txt:
14:15 Changeset [114036] by arv@chromium.org

Add support for [ArrayClass] and use that on NodeList
https://bugs.webkit.org/show_bug.cgi?id=

Reviewed by Adam Barth.

Attempt to reland r113931. Now with more updated test expectations.

With this patch NodeLists now have Array.prototype on their prototype chain which allows
methods such as forEach and map to work on NodeLists.

http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#interface-nodelist

For V8 we need to set a flag on the WrapperTypeInfo since V8 uses FunctionTemplates which
does not allow setting the prototype to a non FunctionTemplate so the prototype is therefore
set when the constructor is created.

For JSC we just pass the right prototype object when creating the NodeList prototype. JSC has
a bug (81588) that prevents toString to work as specced on Array.prototype.toString. This
causes test failures in the tests until that has been fixed.

Source/WebCore:

Test: fast/dom/NodeList/node-list-array-class.html

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader): Include ArrayPrototype.h if an ArrayClass.
(GenerateImplementation): If ArrayClass use arrayPrototype as prototype.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNamedConstructorCallback):
(GenerateImplementation): Adds a flag to the WrapperTypeInfo.

  • bindings/scripts/IDLAttributes.txt:: Adds new attribute: ArrayClass.
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::createPrototype):

  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore):

  • bindings/v8/NPV8Object.cpp:

(WebCore::npObjectTypeInfo):

  • bindings/v8/V8BindingPerContextData.cpp:

(WebCore::V8BindingPerContextData::init): Get the array prototype too.
(WebCore::V8BindingPerContextData::createWrapperFromCacheSlowCase):
(WebCore::V8BindingPerContextData::constructorForTypeSlowCase): If this is an ArrayClass we need to
set the [[Prototype]].

  • bindings/v8/V8BindingPerContextData.h:

(V8BindingPerContextData):

  • bindings/v8/V8HiddenPropertyName.h:

(WebCore):

  • bindings/v8/WrapperTypeInfo.h:

(WrapperTypeInfo):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore):

  • dom/NodeList.idl:

LayoutTests:

  • fast/dom/HTMLSelectElement/named-options-expected.txt:
  • fast/dom/HTMLSelectElement/script-tests/named-options.js:
  • fast/dom/NodeList/node-list-array-class-expected.txt: Added.
  • fast/dom/NodeList/node-list-array-class.html: Added.
  • fast/dom/NodeList/nodelist-item-call-as-function-expected.txt:
  • fast/dom/everything-to-string-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/js/recursion-limit-equal-expected.txt:
  • inspector/console/command-line-api-expected.txt:
  • inspector/console/console-dir-expected.txt:
  • inspector/console/console-format-collections-expected.txt:
  • jquery/traversing-expected.txt:
  • platform/chromium/fast/dom/HTMLSelectElement/named-options-expected.txt: Copied from LayoutTests/fast/dom/HTMLSelectElement/named-options-expected.txt.
  • platform/chromium/fast/dom/everything-to-string-expected.txt: Copied from LayoutTests/fast/dom/everything-to-string-expected.txt.
  • platform/chromium/inspector/console/command-line-api-expected.txt: Copied from LayoutTests/inspector/console/command-line-api-expected.txt.
  • platform/chromium/inspector/console/console-dir-expected.txt:
  • platform/chromium/inspector/console/console-format-collections-expected.txt:
  • platform/chromium/jquery/traversing-expected.txt: Copied from LayoutTests/jquery/traversing-expected.txt.
  • platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
14:14 Changeset [114035] by commit-queue@webkit.org

[BlackBerry] Web Inspector cookie expiry is showing the wrong date.
https://bugs.webkit.org/show_bug.cgi?id=83814

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-04-12
Reviewed by Rob Buis.

The internal representation for expiry is seconds, we need to convert it
to milliseconds by multiplying by 1000.

The value from this method doesn't get used anywhere except Web Inspector.
Manually tested with Web Inspector by examining the CookieItemView in the Resources Panel.

  • platform/blackberry/ParsedCookie.cpp:

(WebCore::ParsedCookie::appendWebCoreCookie):

14:11 Changeset [114034] by adamk@chromium.org

Always set V8 wrappers via V8DOMWrapper::setJSWrapperFor* instead of WeakReferenceMap::set()
https://bugs.webkit.org/show_bug.cgi?id=82256

Reviewed by Kentaro Hara.

This is an attempt to reland r112318, which was rolled out due to suspicion of OOM issues.

I've landed the refactoring bits of r112318 as separate changes,
so that this patch contains only the change in which map setter is called.

Binding tests have been updated with new output.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateToV8Converters): Call appropriate V8DOMWrapper::setJSWrapperFor*
to set up wrapper mapping and remove call to leakRef() which is handled
in V8DOMWrapper.

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::V8Float64Array::wrapSlow):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::wrapSlow):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::wrapSlow):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::wrapSlow):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::V8TestEventTarget::wrapSlow):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::wrapSlow):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::wrapSlow):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::wrapSlow):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::wrapSlow):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::wrapSlow):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):

14:09 Changeset [114033] by schenney@chromium.org

chromium windows + linux svg tests failing after r65665
https://bugs.webkit.org/show_bug.cgi?id=44278

Unreviewed Chromium test expectations update.

Looks like a result of the Skia switch plus some font adjustments.

  • platform/chromium-linux/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
  • platform/chromium-linux/svg/transforms/text-with-mask-with-svg-transform-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/transforms/text-with-mask-with-svg-transform-expected.png:
  • platform/chromium-mac-snowleopard/svg/transforms/text-with-mask-with-svg-transform-expected.png: Removed.
  • platform/chromium-mac/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
  • platform/chromium-win/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
  • platform/chromium-win/svg/transforms/text-with-mask-with-svg-transform-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
14:06 Changeset [114032] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=83817

This patch modifies RenderText so that it scans all of its characters up front to
determine whether or not the simple code path can be used for measurement/rendering
of the text for the whole run.

TextRun now has an additional field that indicates that the character scan is not
required, since the entire RenderText is known to be simple. This boolean is set
when constructing the TextRun from the places that make TextRuns from RenderTexts.

The character scan has been refactored into a static Font method so that it can be
called by RenderText. The scan of individual TextRuns is also done using the same method
so that the code is shared.

Reviewed by Dan Bernstein.

  • platform/graphics/Font.cpp:

(WebCore::Font::codePath):
(WebCore::Font::characterRangeCodePath):

  • platform/graphics/Font.h:
  • platform/graphics/TextRun.h:

(WebCore::TextRun::TextRun):
(WebCore::TextRun::characterScanForCodePath):
(WebCore::TextRun::setCharacterScanForCodePath):
(TextRun):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::constructTextRun):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::textWidth):

  • rendering/RenderText.cpp:

(WebCore::RenderText::RenderText):
(WebCore::RenderText::widthFromCache):
(WebCore::RenderText::setTextInternal):
(WebCore::RenderText::width):
(WebCore::RenderText::computeCanUseSimpleFontCodePath):
(WebCore):

  • rendering/RenderText.h:

(RenderText):
(WebCore::RenderText::canUseSimpleFontCodePath):

13:56 Changeset [114031] by leviw@chromium.org

Make AccessibilityObject::size non-virtual and fix platform accessibility code's LayoutUnit usage
https://bugs.webkit.org/show_bug.cgi?id=83803

Reviewed by Eric Seidel.

AccessibilityObject::size was virtual with a number of overloads, but all the implementations were
redundant. Avoiding the virtual thunk and code duplication by declaring it non-virtual and only
implementing it in AccessibilityObject.

Also adding a pixelSnappedSize method that returns an IntSize, and using it in platform
accessibility code.

No new tests. No change in behavior.

  • accessibility/AccessibilityMenuListOption.h:

(WebCore::AccessibilityMenuListOption::canHaveChildren):

  • accessibility/AccessibilityMenuListPopup.h:

(WebCore::AccessibilityMenuListPopup::elementRect):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::size):
(WebCore::AccessibilityObject::pixelSnappedSize):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

  • accessibility/AccessibilitySlider.cpp:

(WebCore):

  • accessibility/AccessibilitySlider.h:

(AccessibilitySliderThumb):

  • accessibility/AccessibilityTableColumn.cpp:

(WebCore):

  • accessibility/AccessibilityTableColumn.h:

(AccessibilityTableColumn):

  • accessibility/AccessibilityTableHeaderContainer.cpp:

(WebCore):

  • accessibility/AccessibilityTableHeaderContainer.h:

(AccessibilityTableHeaderContainer):

  • accessibility/gtk/WebKitAccessibleInterfaceComponent.cpp:

(webkitAccessibleComponentGetExtents):

  • accessibility/gtk/WebKitAccessibleInterfaceImage.cpp:

(webkitAccessibleImageGetImagePosition):
(webkitAccessibleImageGetImageSize):

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper position]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

13:55 Changeset [114030] by schenney@chromium.org

some clip paths broken on chromium win/linux after r65729
https://bugs.webkit.org/show_bug.cgi?id=44341

Unreviewed Chromium expectations update.

These tests are now matching the mac results, and the new results on
the bots look correct. Some changes are just font metric changes.

  • platform/chromium-linux/svg/clip-path/clip-path-childs-clipped-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-pixelation-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-childs-clipped-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-childs-clipped-expected.png: Added.
  • platform/chromium-win/svg/clip-path/clip-path-childs-clipped-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-pixelation-expected.png: Added.
  • platform/chromium-win/svg/clip-path/clip-path-pixelation-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
13:42 Changeset [114029] by leviw@chromium.org

Remove unnecessary virtual designation for AccessibilityObject::size, add pixelSnappedSize, and use it in platform code.

13:35 Changeset [114028] by jer.noble@apple.com

ThreadingWin: Mutex::unlock() can be "over-unlocked".
https://bugs.webkit.org/show_bug.cgi?id=83725

Reviewed by David Levin.

In order to support the behavior of pthread_mutex_trylock(), the Windows Mutex class includes
a recursion counter which is incremented in Mutex::lock(), decremented in Mutex::unlock(),
and checked in Mutex::tryLock(). If the mutex is "over-unlocked", the counter wraps around to
MAX_INT, and subsequent calls to Mutex::trylock() will fail. Raise an ASSERT in this situation
so the "over-unlock" will be caught.

  • wtf/ThreadingWin.cpp:

(WTF::Mutex::unlock): ASSERT if unlocking a non-locked mutex.

13:31 Changeset [114027] by schenney@chromium.org

[Chromium] filters/feDisplacementMap.svg crossHatch pattern improperly drawn
https://bugs.webkit.org/show_bug.cgi?id=83810

Unreviewed Chromium expectations update.

These test results match Firefox, and I see no reason to believe they
are incorrect.

  • platform/chromium-linux-x86/svg/filters/feDisplacementMap-expected.png: Added.
  • platform/chromium-linux/svg/filters/feDisplacementMap-expected.png: Added.
  • platform/chromium-win-vista/svg/filters/feDisplacementMap-expected.png: Added.
  • platform/chromium-win-xp/svg/filters/feDisplacementMap-expected.png: Added.
  • platform/chromium-win/svg/filters/feDisplacementMap-expected.png:
  • platform/chromium/test_expectations.txt:
13:29 Changeset [114026] by annacc@chromium.org

Update HTMLMediaElement's index of cues when TextTrack.mode changes to
and from TextTrack::DISABLED.
https://bugs.webkit.org/show_bug.cgi?id=83377

Reviewed by Eric Carlson.

Source/WebCore:

No new tests. Instead updated media/track/track-mode.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::textTrackModeChanged):

Add the track's cues to the index when the mode changes to HIDDEN or SHOWING.

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::textTrackRemoveCues):

Fix a copy pasta error.

  • html/track/TextTrack.cpp:

(WebCore::TextTrack::setMode):

Remove the track's cues from the index when the mode changes to DISABLED.

LayoutTests:

  • media/track/track-mode-expected.txt:
  • media/track/track-mode.html:
13:26 Changeset [114025] by commit-queue@webkit.org

Unreviewed, rolling out r114005.
http://trac.webkit.org/changeset/114005
https://bugs.webkit.org/show_bug.cgi?id=83809

This patch may have unveiled other bugs, need to investigate
(Requested by vrk on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-12

  • media/video-seek-past-end-paused-expected.txt:
  • media/video-seek-past-end-paused.html:
  • platform/chromium/test_expectations.txt:
13:23 Changeset [114024] by commit-queue@webkit.org

Allow certain Char events in fullscreen
https://bugs.webkit.org/show_bug.cgi?id=83330

Patch by Cem Kocagil <cem.kocagil@gmail.com> on 2012-04-12
Reviewed by Alexey Proskuryakov.

  • page/EventHandler.cpp:

(WebCore::EventHandler::isKeyEventAllowedInFullScreen):

13:04 Changeset [114023] by schenney@chromium.org

Shadow is not shown when using strokeRect with a gradient strokeStyle
https://bugs.webkit.org/show_bug.cgi?id=52509

Unreviewed Chromium expectations update (after all this time).

  • platform/chromium-win/svg/css/rect-gradient-stroke-shadow-expected.png: Added.
  • platform/chromium/test_expectations.txt:
13:01 Changeset [114022] by commit-queue@webkit.org

IndexedDB: Attributes for a cursor "run past the end" should be undefined.
https://bugs.webkit.org/show_bug.cgi?id=83492

Patch by Alec Flett <alecflett@chromium.org> on 2012-04-12
Reviewed by Ojan Vafai.

Source/WebCore:

This brings us up to spec with respect to when it's ok to call
cursor.continue() and the various behaviors around it:

If you call it more than once, continue() throws an exception.

The values of key/primaryKey/value are consistent, whether or not
continue has been called, meaning that if continue() results in
data being loaded from the backing store, that data does not
affect the cursor until the success callback has completed.

Calls to update() and delete() can happen before continue(), but
not afterwards.

Test: storage/indexeddb/cursor-continue-validity.html

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::IDBCursor):
(WebCore::IDBCursor::key):
(WebCore::IDBCursor::primaryKey):
(WebCore::IDBCursor::value):
(WebCore::IDBCursor::update):
(WebCore::IDBCursor::continueFunction):
(WebCore::IDBCursor::deleteFunction):
(WebCore::IDBCursor::setGotValue):
(WebCore):

  • Modules/indexeddb/IDBCursor.h:

(IDBCursor):

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::dispatchEvent):

LayoutTests:

  • storage/indexeddb/cursor-continue-validity-expected.txt: Added.
  • storage/indexeddb/cursor-continue-validity.html: Added.
  • storage/indexeddb/resources/cursor-continue-validity.js: Added.
  • storage/indexeddb/resources/mozilla/cursors-expected.txt:
  • storage/indexeddb/resources/shared.js:
12:58 Changeset [114021] by eric.carlson@apple.com

Media engine should not be told to prepare for playback if media loading is not allowed
https://bugs.webkit.org/show_bug.cgi?id=83620

Reviewed by Dan Bernstein.

Source/WebCore:

Test: media/video-load-require-user-gesture.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::load): Early return if user gesture requirement is not met.

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::setMediaPlaybackRequiresUserGesture): Moved the method here from

Internals to be with the rest of the Internals methods that expose preferences.

  • testing/InternalSettings.h:
  • testing/InternalSettings.idl:
  • testing/Internals.cpp: Moved setMediaPlaybackRequiresUserGesture to InternalSettings.
  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

  • media/video-load-require-user-gesture-expected.txt: Added.
  • media/video-load-require-user-gesture.html: Added.
  • media/video-play-require-user-gesture.html: Update for move of setMediaPlaybackRequiresUserGesture

from window.internals to window.internals.settings.

12:54 Changeset [114020] by commit-queue@webkit.org

[CSS Exclusions] Add flag to enable / disable exclusions at runtime
https://bugs.webkit.org/show_bug.cgi?id=83313

Patch by Bear Travis <betravis@adobe.com> on 2012-04-12
Reviewed by Ryosuke Niwa.

.:

Adding the GTK symbols

  • Source/autotools/symbols.filter:

Source/WebCore:

Adding setCSSExclusionsEnabled/cssExclusionsEnabled that is true by default.
The CSS parser will not accept values for the exclusions properties when
cssExclusionsEnabled is false. However, you will still get the default value
in the computed style.

Test: fast/exclusions/css-exclusions-disabled.html

  • WebCore.exp.in:
  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setCSSExclusionsEnabled):
(WebCore::RuntimeEnabledFeatures::cssExclusionsEnabled):
(RuntimeEnabledFeatures):

  • css/CSSParser.cpp:

(WebCore::isSimpleLengthValue):
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::CSSParser::parseValue):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::restoreTo):
(WebCore::InternalSettings::setCSSExclusionsEnabled):
(WebCore):

  • testing/InternalSettings.h:

(InternalSettings):

  • testing/InternalSettings.idl:

Source/WebKit2:

Adding windows symbols

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

Adding a test to cover CSS parsing, which is the only piece of exclusions
work in place. Updating other exclusions test to explicitly enable the
feature.

  • fast/exclusions/css-exclusions-disabled-expected.txt: Added.
  • fast/exclusions/css-exclusions-disabled.html: Added.
  • fast/exclusions/script-tests/parsing-wrap-shape-inside.js:
  • fast/exclusions/script-tests/parsing-wrap-shape-outside.js:
  • fast/exclusions/script-tests/wrap-flow-parsing.js:
  • fast/exclusions/script-tests/wrap-margin-parsing.js:
  • fast/exclusions/script-tests/wrap-padding-parsing.js:
  • fast/exclusions/script-tests/wrap-parsing.js:
  • fast/exclusions/script-tests/wrap-through-parsing.js:
12:50 Changeset [114019] by schenney@chromium.org

[Chromium] Layout test svg/text/font-size-below-point-five.svg needs rebaseline
https://bugs.webkit.org/show_bug.cgi?id=83806

Unreviewed Chromium test expectations update.

  • platform/chromium-linux/svg/text/font-size-below-point-five-expected.txt:
  • platform/chromium-mac-leopard/svg/text/font-size-below-point-five-expected.png: Added.
  • platform/chromium-mac-leopard/svg/text/font-size-below-point-five-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/text/font-size-below-point-five-expected.png: Removed.
  • platform/chromium-mac/svg/text/font-size-below-point-five-expected.png: Added.
  • platform/chromium/test_expectations.txt:
12:35 Changeset [114018] by andersca@apple.com

Add fast/frames/flattening/frameset-flattening-simple.html to the Skipped list.

  • platform/mac/Skipped:
12:27 Changeset [114017] by schenney@chromium.org

[Chromium] LayoutTest update for several Mac filter tests
https://bugs.webkit.org/show_bug.cgi?id=83717

Unreviewed Chromium test expectations update.

Second attempt, now leaving some tests as flakey.

  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png: Added.
  • platform/chromium/test_expectations.txt:
12:27 Changeset [114016] by japhet@chromium.org

Move Archive processing to DocumentLoader, instead of FrameLoader.
https://bugs.webkit.org/show_bug.cgi?id=83055

Reviewed by Adam Barth.

No new tests, no functionality change intended.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::setupForReplaceByMIMEType):
(WebCore::DocumentLoader::maybeCreateArchive): Renamed from

FrameLoader::finishedLoadingDocument(). Returns true if an archive
was created.

(WebCore::DocumentLoader::setArchive):
(WebCore::DocumentLoader::scheduleArchiveLoad):
(WebCore::DocumentLoader::documentURL): Add a check for whether an archive url

should be returned, so that we don't need special handling in Document and
FrameLoader for overriding the document url later.

  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::receivedFirstData): Remove archive special cases, since

DocumentLoader::documentURL() will return the right thing for legacy archives
and maybeCreateArchive() will override the base url for mhtml.

(WebCore::FrameLoader::loadArchive):

  • loader/FrameLoader.h:
12:23 Changeset [114015] by andersca@apple.com

Update test results after r113945.

  • fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
12:19 Changeset [114014] by dpranke@chromium.org

test-webkitpy fails on metered_stream_unittest for non-US West Coast Time Zones
https://bugs.webkit.org/show_bug.cgi?id=83583

Reviewed by Philippe Normand

Updated the unit test to ignore the hours and minutes of the
localtime for time(0), since we can't easily guarantee which
timezone we're in or what timezone rules were in effect on
1/1/1970; this should be mostly fine since we can trust that
time.localtime() will work, although there is the possibility
that we'll screw up the time formatting of which field is the
hours and which is the minutes.

  • Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:

(VerboseTest):
(VerboseTest.test_basic):
(VerboseTest.test_log_after_update):

12:16 Changeset [114013] by dslomov@google.com

Source/WebCore: REGRESSION (r113233): fast/canvas/webgl/array-message-passing.html crashing on Lion and Snow Leopard bots.
https://bugs.webkit.org/show_bug.cgi?id=83427.
Due to incorrect merge by me when landing r113233, call to find got replaces with call to add in
checking for duplicates in ObjectPool when serializing.

Reviewed by Dean Jackson.

Covered by existing tests.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::checkForDuplicate):

LayoutTests: REGRESSION (r113233): fast/canvas/webgl/array-message-passing.html crashing on Lion and Snow Leopard bots.
https://bugs.webkit.org/show_bug.cgi?id=83427.
Bug fixed, unskipping tests.

Reviewed by Dean Jackson.

  • platform/mac/Skipped:
12:07 Changeset [114012] by commit-queue@webkit.org

Don't modify shared style objects in RenderMathMLRoot.cpp
https://bugs.webkit.org/show_bug.cgi?id=83736

Patch by David Barton <dbarton@mathscribe.com> on 2012-04-12
Reviewed by Julien Chaffraix.

Source/WebCore:

To leave room for the radical sign and absolutely positioned "index", we switch to using
intrinsic padding. RenderMathMLRoot.cpp is also cleaned up and prepared for merging with
RenderMathMLSquareRoot.cpp. The base and index are no longer wrapped in extra renderers,
and the child renderers are now in the same order as in the DOM. Some padding/placement
terms are unified and debugged.

Tested by existing tests in roots.xhtml.

  • css/mathml.css:

(mroot):
(mroot > * + *):
(mroot > * + mrow, mroot > * + mfenced):

  • rendering/mathml/RenderMathMLRoot.cpp:

(WebCore):
(WebCore::RenderMathMLRoot::index):
(WebCore::RenderMathMLRoot::paint):
(WebCore::RenderMathMLRoot::layout):

  • rendering/mathml/RenderMathMLRoot.h:

(RenderMathMLRoot):

  • rendering/mathml/RenderMathMLSquareRoot.cpp:

(WebCore):
(WebCore::RenderMathMLSquareRoot::paint):

LayoutTests:

  • platform/mac/mathml/presentation/roots-expected.png:
  • platform/mac/mathml/presentation/roots-expected.txt:
12:03 Changeset [114011] by commit-queue@webkit.org

[BlackBerry] Web Inspector messages incorrectly converted
https://bugs.webkit.org/show_bug.cgi?id=83796

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-04-12
Reviewed by Rob Buis.

The JSON sent over from the remote Web Inspector front-end was being
mis interpreted as ISO-8859-1. This caused all non ascii characters to
become garbled when using the String constructor, so we use fromtUTF8 instead.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::dispatchInspectorMessage):

11:57 Changeset [114010] by tsepez@chromium.org

Typos in LayoutTests/http/tests/security/xssAuditor/script-tag-inside-svg-tag*.html
https://bugs.webkit.org/show_bug.cgi?id=83794

Reviewed by Adam Barth.

Several changes needed to make the XSS in these test cases fire against actual
vulnerable browsers. The tests were still valid, but it is more helpful to see
the XSS pop up.

  • http/tests/security/xssAuditor/script-tag-inside-svg-tag.html:
  • http/tests/security/xssAuditor/script-tag-inside-svg-tag2.html:
  • http/tests/security/xssAuditor/script-tag-inside-svg-tag3.html:
11:54 Changeset [114009] by aestes@apple.com

Remove unused WebKit1 SPI for suppressing incremental rendering.
https://bugs.webkit.org/show_bug.cgi?id=83801

Reviewed by Simon Fraser.

This SPI is unused and has been replaced by API ([setS|s]uppressesIncrementalRendering).

  • WebView/WebPreferences.mm:
  • WebView/WebPreferencesPrivate.h:
11:51 Changeset [114008] by philn@webkit.org

Unreviewed, GTK test_expectations.

  • platform/gtk/test_expectations.txt: Flaky tests list update.
11:32 Changeset [114007] by andersca@apple.com

Build fix.

  • page/mac/SettingsMac.mm:

(WebCore::defaultFontFamilyDictionary):

11:28 Changeset [114006] by antti@apple.com

Remove style sheet argument from StyleRuleImport constructor
https://bugs.webkit.org/show_bug.cgi?id=83740

Reviewed by Andreas Kling.

The style sheet is set when the rule is added to one. The parser does not need to know about it.

  • css/CSSImportRule.cpp:

(WebCore::StyleRuleImport::StyleRuleImport):

  • css/CSSImportRule.h:

(StyleRuleImport):
(WebCore::StyleRuleImport::setParentStyleSheet):

  • css/CSSParser.cpp:

(WebCore::CSSParser::createImportRule):

  • css/CSSStyleSheet.cpp:

(WebCore::StyleSheetInternal::parserAppendRule):
(WebCore::StyleSheetInternal::wrapperInsertRule):

11:24 Changeset [114005] by vrk@chromium.org

Remove setTimeout from media/video-seek-past-end-paused.html and fix other minor issues
https://bugs.webkit.org/show_bug.cgi?id=83505

The test had an arbitrary performance expectation to start playing in 200 ms,
which caused the layout test to fail for Chromium when the Chromium's
audio buffer size increased.
This CL removes that expectation and fixes some HTML and grammar mistakes.

Reviewed by Eric Carlson.

  • media/video-seek-past-end-paused-expected.txt:
  • media/video-seek-past-end-paused.html:
  • platform/chromium/test_expectations.txt:
11:11 Changeset [114004] by ap@apple.com

REGRESSION (r113900): In nightly builds, Safari Webpage Preview Fetcher crashes in Settings::initializeDefaultFontFamilies() due to uncaught exception (sandbox preventing access to fonts plist)
https://bugs.webkit.org/show_bug.cgi?id=83792
<rdar://problem/11234002>

Reviewed by Dan Bernstein.

  • page/mac/SettingsMac.mm: (WebCore::defaultFontFamilyDictionary): Bail out without setting font preferences if the process doesn't have read access to WebCore.framework.
11:10 Changeset [114003] by commit-queue@webkit.org

Add an EFL Debug Buildbot to the master configuration
https://bugs.webkit.org/show_bug.cgi?id=82711

Forgot to add EFL Linux Debug to scheduler.

Patch by Dominik Rottsches <dominik.rottsches@linux.intel.com> on 2012-04-12
Reviewed by Philippe Normand.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
10:49 PrefixedAPIs edited by scheib@chromium.org
Pointer Lock spec link (diff)
10:47 Changeset [114002] by efidler@rim.com

[BlackBerry] Set up default fonts for BlackBerry
https://bugs.webkit.org/show_bug.cgi?id=83775

Reviewed by Antonio Gomes.

  • PlatformBlackBerry.cmake:
  • page/Settings.cpp:

(WebCore):

  • page/blackberry/SettingsBlackBerry.cpp: Added.

(WebCore):
(WebCore::Settings::initializeDefaultFontFamilies):

10:23 Changeset [114001] by jonlee@apple.com

Implement Dictionary.h on mac (83472)
https://bugs.webkit.org/show_bug.cgi?id=83472
<rdar://problem/11209766>

Reviewed by Kentaro Hara.

A difference between Dictionary and JSDictionary makes it difficult to merge the two together and avoid
creating a confusing API. The boolean returned by Dictionary::get() represents whether the
property was found. The boolean returned by JSDictionary::tryGetProperty() represents whether an
exception was thrown.

  • WebCore.xcodeproj/project.pbxproj: Add Dictionary.h and Dictionary.cpp.
  • bindings/js/Dictionary.cpp: Added.

(WebCore::Dictionary::Dictionary):
(WebCore::Dictionary::get):

  • bindings/js/Dictionary.h: Leverage JSDictionary's functionality to obtain the data.

(WebCore::Dictionary::isObject): Mark an unimplemented.
(WebCore::Dictionary::isUndefinedOrNull): Mark an unimplemented.
(WebCore::Dictionary::getWithUndefinedOrNullCheck): Mark an unimplemented.

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::tryGetProperty): Convert to a const function.

  • bindings/js/JSDictionary.h:

(WebCore::JSDictionary::isValid):
(WebCore::JSDictionary::tryGetProperty): Convert to a const function.
(WebCore::JSDictionary::get): Similar to tryGetProperty(), but returns true if the
property was found, converting the value succeeded and the out parameter "result" was set.
(WebCore::JSDictionary::tryGetPropertyAndResult): Refactor tryGetProperty() to return the enum directly.

Change bindings scripts to use Dictionary constructor.

  • bindings/js/IDBBindingUtilities.cpp: Remove createDictionaryFromValue().
  • bindings/js/IDBBindingUtilities.h: Remove createDictionaryFromValue().
  • bindings/scripts/CodeGeneratorJS.pm:

(JSValueToNative): Update to remove IDBBindingUtilities.h dependency, and use Dictionary constructor.

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionOptionsObject): Update expected generated output.

10:16 Changeset [114000] by commit-queue@webkit.org

[chromium] Fix threaded compositor HUD crash
https://bugs.webkit.org/show_bug.cgi?id=83778

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-04-12
Reviewed by James Robinson.

Don't try to read font metrics in threaded compositing mode, since we
currently can't render HUD text with the threaded compositor.

HUD is not testable in WebKit.

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::drawHudContents):

10:09 Changeset [113999] by philn@webkit.org

Unreviewed, GTK test_expectations.

  • platform/gtk/test_expectations.txt: Marking 2 media tests flaky.
10:02 Changeset [113998] by commit-queue@webkit.org

[CSS Regions] Convert a fast/regions pixel test to a ref test
https://bugs.webkit.org/show_bug.cgi?id=83713

Patch by David Alcala <dalcala@adobe.com> on 2012-04-12
Reviewed by Dirk Schulze.

  • fast/regions/region-overflow-break-expected.html: Added.
  • platform/chromium-mac-snowleopard/fast/regions/region-overflow-break-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/regions/region-overflow-break-expected.txt: Removed.
  • platform/efl/fast/regions/region-overflow-break-expected.png: Removed.
  • platform/efl/fast/regions/region-overflow-break-expected.txt: Removed.
  • platform/mac-snowleopard/fast/regions/region-overflow-break-expected.png: Removed.
  • platform/mac-snowleopard/fast/regions/region-overflow-break-expected.txt: Removed.
  • platform/mac/fast/regions/region-overflow-break-expected.txt: Removed.
10:02 Changeset [113997] by commit-queue@webkit.org

Add an EFL Debug Buildbot to the master configuration
https://bugs.webkit.org/show_bug.cgi?id=82711

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-12
Reviewed by Philippe Normand.

Hooking up our EFL Linux 64bit debug configuration buildbot to the buildbot master.

  • BuildSlaveSupport/build.webkit.org-config/config.json: EFL Debug builder added
09:40 Changeset [113996] by caseq@chromium.org

Web Inspector: zoom timeline frame on dblclick on the frame bar
https://bugs.webkit.org/show_bug.cgi?id=83741

Reviewed by Pavel Feldman.

  • put timeline frame bars into a container, so we can have one listener;
  • upon dblclick, find the frame, get its window coordinates and set overview selection window accordingly.
  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane.prototype.zoomToFrame): Get frame coordinates, set overview window.
(WebInspector.TimelineVerticalOverview.prototype.update): Maintain framesPerBar as a member for reuse in getFramePosition()
(WebInspector.TimelineVerticalOverview.prototype.framePosition): Map frame to screen positions.
(WebInspector.TimelineVerticalOverview.prototype._renderBars): Factored out barNumberToScreenPosition()
(WebInspector.TimelineVerticalOverview.prototype._barNumberToScreenPosition):
(WebInspector.TimelineVerticalOverview.prototype.getWindowTimes): Drive-by style fix.

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._updateFrames): Put frames into a containing div.
(WebInspector.TimelinePanel.prototype._onFrameDoubleClicked): Zoom to frame upon double click.

  • inspector/front-end/timelinePanel.css:

(.timeline-frame-container):

09:31 Changeset [113995] by philn@webkit.org

Unreviewed, GTK test_expectations post-Skipped-migration update #2.

  • platform/gtk/test_expectations.txt:
09:29 Changeset [113994] by caseq@chromium.org

Web Inspector: show wall time frame duration on the vertical overview
https://bugs.webkit.org/show_bug.cgi?id=83718

Reviewed by Pavel Feldman.

Source/WebCore:

  • show frame duration as a contour of the frame bar in vertical overview;
  • when scaling, normalize bar to a max of 3 * median frame duration, so too long frames do not dwarf the majority;
  • add Array.prototype.qselect() for the above;
  • factor our partition algorithm onto Array.prototype for better reuse;
  • inspector/front-end/PartialQuickSort.js: factor out partition()

(Object.defineProperty.):
(Object.defineProperty):

  • inspector/front-end/TimelineFrameController.js:

(WebInspector.TimelineFrameController.prototype._flushFrame): add frame.duration.
(WebInspector.TimelineFrameController.prototype._createSyntheticFrame): ditto.

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineVerticalOverview):
(WebInspector.TimelineVerticalOverview.prototype.reset): this._longestFrameTime is gone.
(WebInspector.TimelineVerticalOverview.prototype.update): ditto.
(WebInspector.TimelineVerticalOverview.prototype._aggregateFrames): return frames to display, not just their timeByCatogory.
(WebInspector.TimelineVerticalOverview.prototype._renderBars): use entire frames, not timeByCategory.
(WebInspector.TimelineVerticalOverview.prototype._renderBar): ditto.

  • inspector/front-end/externs.js: Added annotations for partition() and qselect()

(Array.prototype.partition):
(Array.prototype.qselect):

  • inspector/front-end/utilities.js:

(.):

LayoutTests:

  • inspector/utilities-expected.txt:
  • inspector/utilities.html: added results for Array.prototype.qselect()
09:20 Changeset [113993] by pierre.rossi@gmail.com

[Qt] More unreviewed gardening after r113968.

Set the right expected results this time.

  • platform/qt-5.0/css1/text_properties/letter_spacing-expected.txt:
  • platform/qt-5.0/editing/inserting/5549929-2-expected.txt:
  • platform/qt-5.0/editing/inserting/5549929-3-expected.txt:
  • platform/qt-5.0/editing/inserting/insert-br-at-tabspan-001-expected.txt:
  • platform/qt-5.0/editing/inserting/insert-br-at-tabspan-002-expected.txt:
  • platform/qt-5.0/editing/inserting/insert-br-at-tabspan-003-expected.txt:
  • platform/qt-5.0/editing/inserting/insert-tab-001-expected.txt:
  • platform/qt-5.0/editing/inserting/insert-tab-002-expected.txt:
  • platform/qt-5.0/editing/inserting/insert-tab-004-expected.txt:
  • platform/qt-5.0/editing/inserting/insert-text-at-tabspan-001-expected.txt:
  • platform/qt-5.0/editing/inserting/insert-text-at-tabspan-002-expected.txt:
  • platform/qt-5.0/editing/inserting/insert-text-at-tabspan-003-expected.txt:
  • platform/qt-5.0/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
  • platform/qt-5.0/editing/selection/editable-html-element-expected.txt:
  • platform/qt-5.0/editing/selection/extend-by-word-001-expected.txt:
  • platform/qt-5.0/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
  • platform/qt-5.0/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
  • platform/qt-5.0/fast/css/word-space-extra-expected.txt:
  • platform/qt-5.0/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt:
  • platform/qt-5.0/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt:
  • platform/qt-5.0/fast/table/border-collapsing/004-expected.txt:
  • platform/qt-5.0/fast/text/international/hindi-whitespace-expected.txt:
  • platform/qt-5.0/fast/text/text-letter-spacing-expected.txt:
  • platform/qt-5.0/svg/batik/text/textPosition-expected.txt:
  • platform/qt-5.0/svg/batik/text/textPosition2-expected.txt:
  • platform/qt-5.0/svg/custom/glyph-selection-arabic-forms-expected.txt:
  • platform/qt-5.0/svg/custom/glyph-selection-bidi-mirror-expected.txt:
  • platform/qt-5.0/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
09:05 Changeset [113992] by staikos@webkit.org

Enable the fullscreen API for BlackBerry.
https://bugs.webkit.org/show_bug.cgi?id=83757

Reviewed by Antonio Gomes.

.:

  • Source/cmake/OptionsBlackBerry.cmake:

Tools:

  • Scripts/build-webkit:
09:04 Changeset [113991] by commit-queue@webkit.org

Optimize non-rounded double border rendering to avoid transparency layers
https://bugs.webkit.org/show_bug.cgi?id=83745

Patch by David Barr <davidbarr@chromium.org> on 2012-04-12
Reviewed by Simon Fraser.

No functional change, painting optimization only.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBorder):

09:02 Changeset [113990] by jchaffraix@webkit.org

Reduce the use of RenderLayer outside of the rendering code
https://bugs.webkit.org/show_bug.cgi?id=83728

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/layers/scrollByLines-overflow-no-layer.html

This is mostly a layering violation change. This changes reduces the number of
RenderLayer use outside rendering/ by a third but there are still numerous uses.

While auditing the different uses of RenderLayer, I found a potential crasher
and fixed it which is why we have a test case.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::visiblePositionForPoint):

  • dom/Document.cpp:

(WebCore::Document::nodesFromRect):
(WebCore::Document::handleZeroPadding):
(WebCore::nodeFromPoint):
(WebCore::Document::prepareMouseEvent):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::contains):

  • page/DragController.cpp:

(WebCore::elementUnderMouse):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseDraggedEvent):
(WebCore::EventHandler::eventMayStartDrag):
(WebCore::EventHandler::updateSelectionForMouseDrag):
(WebCore::EventHandler::hitTestResultAtPoint):
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::hoverTimerFired):
(WebCore::EventHandler::handleDrag):
Updated these call sites to use RenderView::hitTest.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • page/FrameView.cpp:

(WebCore::FrameView::contentsInCompositedLayer):
(WebCore::FrameView::scrollContentsFastPath):
Updated these call sites to use RenderObject::isComposited().

  • dom/Element.cpp:

(WebCore::Element::scrollByUnits):
Call directly RenderBox::scroll instead of calling the layer.
This actually fixes a crasher that slipped through the cracks.

  • editing/visible_units.cpp:
  • html/shadow/TextControlInnerElements.cpp:
  • page/ContextMenuController.cpp:
  • page/FocusController.cpp:
  • page/Frame.cpp:
  • page/GestureTapHighlighter.cpp:
  • page/PrintContext.cpp:
  • plugins/mac/PluginViewMac.mm:

Removed unneeded #include.

  • plugins/gtk/PluginViewGtk.cpp:
  • plugins/qt/PluginViewQt.cpp:

Replaced RenderLayer.h #include with RenderObject.h as
we use RenderObject::absoluteToLocal.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::isComposited):

  • rendering/RenderObject.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::hitTest):

  • rendering/RenderView.h:

Added 2 new functions that pipe through the RenderLayer.

LayoutTests:

The test checks that calling scrollByUnit without a RenderLayer doesn't crash.

  • fast/layers/scrollByLines-overflow-no-layer.html: Added.
  • fast/layers/scrollByLines-overflow-no-layer-expected.txt: Added.
09:00 Changeset [113989] by commit-queue@webkit.org

font-size:0 text runs has non zero width in case of Windows Safari.
https://bugs.webkit.org/show_bug.cgi?id=83559

Patch by Pravinin D <pravind.2k4@gmail.com> on 2012-04-12
Reviewed by Dan Bernstein.

Test case already exits.
LayoutTest/fast/text/font-size-zero.html

  • platform/graphics/win/SimpleFontDataCGWin.cpp:

(WebCore):
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):

08:57 Changeset [113988] by commit-queue@webkit.org

Web Inspector: Move meta node out of nodes in snapshot serialization.
https://bugs.webkit.org/show_bug.cgi?id=83701

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-04-12
Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
(WebInspector.HeapSnapshot):

LayoutTests:

  • inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotSplitNodesEdgesMockRaw):

08:53 Changeset [113987] by mifenton@rim.com

[BlackBerry] Speed up processing of Selection region generation.
https://bugs.webkit.org/show_bug.cgi?id=82766

Reviewed by Rob Buis.

PR 136593.

Re-speed up text selection. The previous patch had a merge
error causing text selection not to function. The fix
implemented removed the optimization. This fixes the error
in the original patch and removes the temporary fix.

Make style updated as suggested by Antonio Gomes.

Reviewed Internally by Gen Mak.

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::regionForTextQuads):
(BlackBerry::WebKit::regionRectListContainsPoint):

08:48 Changeset [113986] by philn@webkit.org

Unreviewed, GTK test_expectations post-Skipped-migration update.

  • platform/gtk/fast/dynamic/layer-hit-test-crash-expected.txt:
  • platform/gtk/http/tests/misc/acid2-expected.txt:
  • platform/gtk/svg/hittest/svg-ellipse-non-scale-stroke-expected.txt: Copied from LayoutTests/svg/hittest/svg-ellipse-non-scale-stroke-expected.txt.
  • platform/gtk/svg/hixie/perf/001-expected.txt: Added.
  • platform/gtk/svg/hixie/perf/002-expected.txt: Added.
  • platform/gtk/svg/hixie/perf/003-expected.txt:
  • platform/gtk/svg/hixie/perf/004-expected.txt:
  • platform/gtk/svg/hixie/perf/005-expected.txt:
  • platform/gtk/svg/hixie/perf/006-expected.txt:
  • platform/gtk/svg/hixie/perf/007-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
  • platform/gtk/svg/text/text-deco-01-b-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
  • platform/gtk/test_expectations.txt:
  • svg/hittest/svg-ellipse-non-scale-stroke-expected.txt:
08:43 Changeset [113985] by schenney@chromium.org

[Chromium] LayoutTest update for several Mac filter tests
https://bugs.webkit.org/show_bug.cgi?id=83717

Unreviewed Chromium test expectations update.

  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png: Added.
  • platform/chromium-mac-leopard/svg/as-border-image/svg-as-border-image-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-border-image/svg-as-border-image-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/as-border-image/svg-as-border-image-2-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/custom/foreign-object-skew-expected.png: Modified property svn:mime-type.
  • platform/chromium/test_expectations.txt:
08:38 Changeset [113984] by antonm@chromium.org

More Mac rebaselines.

Unreviewed.

  • platform/chromium-mac-leopard/css2.1/20110323/replaced-elements-001-expected.png:
08:35 Changeset [113983] by yael.aharon@nokia.com

[Qt][WK2] Nested fixed elements scroll too fast
https://bugs.webkit.org/show_bug.cgi?id=83720

Reviewed by Noam Rosenthal.

.:

  • ManualTests/nested-fixed-position.html: Added.

Source/WebCore:

Before setting the scrollPositionDelta to a fixed layer, check if it has an ancestor which also has fixed position.
If it does, do not set scrollPositionDelta.
Added a flag to TextureMapperLayer and GraphicsLayerTextureMapper indicating if it is a fixed position layer.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:

(WebCore::GraphicsLayerTextureMapper::setFixedToViewport):
(WebCore::GraphicsLayerTextureMapper::fixedToViewport):
(GraphicsLayerTextureMapper):

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::syncCompositingStateSelf):
(WebCore::TextureMapperLayer::isAncestorFixedToViewport):
(WebCore):
(WebCore::TextureMapperLayer::setScrollPositionDeltaIfNeeded):

  • platform/graphics/texmap/TextureMapperLayer.h:

(TextureMapperLayer):
(WebCore::TextureMapperLayer::setFixedToViewport):

Source/WebKit2:

Set the fixedToViewport flag on the fixed position layers and adjust to
the new function name for setting scrollPositionDelta.

  • UIProcess/WebLayerTreeRenderer.cpp:

(WebKit::WebLayerTreeRenderer::adjustPositionForFixedLayers):
(WebKit::WebLayerTreeRenderer::setLayerState):

08:32 Changeset [113982] by pierre.rossi@gmail.com

[Qt] Unreviewed gardening after r113968

Since we now use QRawFont, some tests need a Qt5 specific baseline.

  • platform/qt-5.0/Skipped: skipped two tests with suspicious results.
  • platform/qt-5.0/css1/text_properties/letter_spacing-expected.txt: Added.
  • platform/qt-5.0/editing/inserting/5549929-2-expected.txt: Added.
  • platform/qt-5.0/editing/inserting/5549929-3-expected.txt: Added.
  • platform/qt-5.0/editing/inserting/insert-br-at-tabspan-001-expected.txt: Added.
  • platform/qt-5.0/editing/inserting/insert-br-at-tabspan-002-expected.txt: Added.
  • platform/qt-5.0/editing/inserting/insert-br-at-tabspan-003-expected.txt: Added.
  • platform/qt-5.0/editing/inserting/insert-tab-001-expected.txt: Added.
  • platform/qt-5.0/editing/inserting/insert-tab-002-expected.txt: Added.
  • platform/qt-5.0/editing/inserting/insert-tab-004-expected.txt: Added.
  • platform/qt-5.0/editing/inserting/insert-text-at-tabspan-001-expected.txt: Added.
  • platform/qt-5.0/editing/inserting/insert-text-at-tabspan-002-expected.txt: Added.
  • platform/qt-5.0/editing/inserting/insert-text-at-tabspan-003-expected.txt: Added.
  • platform/qt-5.0/editing/pasteboard/paste-text-at-tabspan-003-expected.txt: Added.
  • platform/qt-5.0/editing/selection/editable-html-element-expected.txt: Added.
  • platform/qt-5.0/editing/selection/extend-by-word-001-expected.txt: Added.
  • platform/qt-5.0/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt: Added.
  • platform/qt-5.0/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt: Added.
  • platform/qt-5.0/fast/css/word-space-extra-expected.txt: Added.
  • platform/qt-5.0/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
  • platform/qt-5.0/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Added.
  • platform/qt-5.0/fast/table/border-collapsing/004-expected.txt: Added.
  • platform/qt-5.0/fast/text/international/hindi-whitespace-expected.txt: Added.
  • platform/qt-5.0/fast/text/text-letter-spacing-expected.txt: Added.
  • platform/qt-5.0/svg/batik/text/textPosition-expected.txt: Added.
  • platform/qt-5.0/svg/batik/text/textPosition2-expected.txt: Added.
  • platform/qt-5.0/svg/custom/glyph-selection-arabic-forms-expected.txt: Added.
  • platform/qt-5.0/svg/custom/glyph-selection-bidi-mirror-expected.txt: Added.
08:12 Changeset [113981] by philn@webkit.org

[GTK] Migrate Skipped tests to test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=83768

Reviewed by Martin Robinson.

This will hopefully simplify gardening tasks. The tests without
bug entry have been marked with BUGWKGTK and the most problematic
suites (mostly for unimplemented or heavily unreliable features
(inspector)) have been SKIP flagged.

  • platform/gtk/Skipped: Removed.
  • platform/gtk/test_expectations.txt:
08:09 Changeset [113980] by mifenton@rim.com

Pattern matching for hexadecimal should include * as an allowable count.
https://bugs.webkit.org/show_bug.cgi?id=83779

Reviewed by Rob Buis.

Update pattern matching check to allow wildcard for number
of characters allowed.

PR 148907.

Reviewed Internally by Gen Mak.

  • WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::elementPatternIndicatesHexadecimal):

08:07 Changeset [113979] by antonm@chromium.org

Mark test as flaky on all platforms and add new failure mode.

Unreviewed.

  • platform/chromium/test_expectations.txt:
08:01 Changeset [113978] by antonm@chromium.org

Rebaseline Mac expectations.

Unreviewed.

  • platform/chromium-mac-leopard/fast/block/float/avoiding-float-centered-expected.png: Added.
07:55 Changeset [113977] by antonm@chromium.org

Mark test as flaking on all platforms.

Unreviewed.

  • platform/chromium/test_expectations.txt:
07:55 Changeset [113976] by charles.wei@torchmobile.com.cn

[BlackBerry] Revert the patch for 82764
https://bugs.webkit.org/show_bug.cgi?id=83767

Reviewed by Rob Buis.

Revert the patch for 82764, which is causing misfunction.
The internal commit is: 800213f5

  • plugins/blackberry/PluginViewBlackBerry.cpp:

(WebCore::PluginView::setNPWindowIfNeeded):
(WebCore::PluginView::platformGetValue):
(WebCore::PluginView::platformDestroy):

  • plugins/blackberry/PluginViewPrivateBlackBerry.h:

(PluginViewPrivate):

07:52 Changeset [113975] by ossy@webkit.org

[Qt]{Mac] Unreviewed, skip new failing tests to paint the bot green.

  • platform/qt-mac/Skipped:
07:43 Changeset [113974] by kenneth@webkit.org

Move viewport meta handling to the web process side
https://bugs.webkit.org/show_bug.cgi?id=83771

Reviewed by Simon Hausmann.

Instead of computing the viewport attributes on both sides,
we now do everything on the web process side, and just send
over the computed result.

  • Scripts/webkit2/messages.py:

(struct_or_class):
(headers_for_type):

  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

  • Shared/WebCoreArgumentCoders.h:

(WebCore):

  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::didChangeViewportProperties):

  • UIProcess/API/efl/PageClientImpl.h:

(PageClientImpl):

  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::didChangeViewportProperties):

  • UIProcess/API/gtk/PageClientImpl.h:

(PageClientImpl):

  • UIProcess/API/mac/PageClientImpl.h:

(PageClientImpl):

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::didChangeViewportProperties):

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::didRelaunchProcess):
(QQuickWebViewFlickablePrivate::didChangeViewportProperties):
(QQuickWebViewFlickablePrivate::updateViewportSize):

  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate::didChangeViewportProperties):
(QQuickWebViewPrivate):
(QQuickWebViewFlickablePrivate):

  • UIProcess/PageClient.h:

(WebCore):
(PageClient):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didChangeViewportProperties):

  • UIProcess/WebPageProxy.h:

(WebCore):
(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/qt/QtPageClient.cpp:

(QtPageClient::didChangeViewportProperties):

  • UIProcess/qt/QtPageClient.h:

(QtPageClient):

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::didChangeViewportProperties):

  • UIProcess/win/WebView.h:

(WebView):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::dispatchViewportPropertiesDidChange):
(WebKit):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::sendViewportAttributesChanged):
(WebKit):
(WebKit::WebPage::setViewportSize):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

07:23 Changeset [113973] by ossy@webkit.org

[Qt] One more unreviewed gardening after r113945 and r113961.

  • platform/qt-5.0-wk2/fast/dom/prototype-inheritance-2-expected.txt:
07:21 Changeset [113972] by tkent@chromium.org

[Chromium] Enable INPUT_TYPE_DATE
https://bugs.webkit.org/show_bug.cgi?id=83761

Reviewed by Kentaro Hara.

Source/WebCore:

  • html/DateInputType.cpp:

Touch it to avoid build issues. No code changes.

  • html/DateInputType.h: ditto.
  • html/InputType.cpp: ditto.

Source/WebKit/chromium:

  • features.gypi: Turn ENABLE_INPUT_TYPE_DATE on.
07:13 Changeset [113971] by yurys@chromium.org

Web Inspector: annotate the rest of profiler front-end for closure compiler
https://bugs.webkit.org/show_bug.cgi?id=83781

All remaining Profiler front-end files are annotated for closure compiler.

Reviewed by Pavel Feldman.

  • inspector/compile-front-end.py:
  • inspector/front-end/CSSSelectorProfileView.js:
  • inspector/front-end/HeapSnapshotProxy.js:

(WebInspector.HeapSnapshotWorkerWrapper):
(WebInspector.HeapSnapshotWorkerWrapper.prototype.postMessag):
(WebInspector.HeapSnapshotWorkerWrapper.prototype.terminate):
(WebInspector.HeapSnapshotWorker):
(WebInspector.HeapSnapshotProxyObject.prototype.callFactoryMethod):
(WebInspector.HeapSnapshotProxyObject.prototype.callMethod):

  • inspector/front-end/HeapSnapshotWorkerDispatcher.js:
  • inspector/front-end/TopDownProfileDataGridTree.js:

(WebInspector.TopDownProfileDataGridTree.prototype.exclude):

  • inspector/front-end/externs.js:

(addEventListener):

06:39 Changeset [113970] by commit-queue@webkit.org

Web Inspector: Node Value should not get corrupt while jump over different matches in search.
https://bugs.webkit.org/show_bug.cgi?id=83758

The order in which updateEntryHide is called for cached
highlightResults is changed in "last changed first corrected" order to preserve the semantic of node.

Patch by Sam D <dsam2912@gmail.com> on 2012-04-12
Reviewed by Pavel Feldman.

No new tests required.

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype._updateSearchHighlight):

06:33 Changeset [113969] by commit-queue@webkit.org

[GTK] Test runner crashes without recent versions of pulseaudio-utils
https://bugs.webkit.org/show_bug.cgi?id=83774

Patch by Simon Pena <spena@igalia.com> on 2012-04-12
Reviewed by Philippe Normand.

Besides checking that pactl is available, check also that its output
is the expected one, and handle gracefully when it isn't, when
trying to unload pulseaudio modules.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort._unload_pulseaudio_module):
(GtkPort._restore_pulseaudio_module):

06:28 Changeset [113968] by pierre.rossi@gmail.com

[Qt] Use QRawFont when building with Qt 5
https://bugs.webkit.org/show_bug.cgi?id=78001

Source/WebCore:

Up until now, fonts in the Qt port have been handled via
the QFont API. QRawFont offers a lower-level API enabling
us to be more in line with what other WebKit ports do.
This patch proceeds to switching over to QRawFont, and
effectively use an earlier change by Andreas Kling
that remained guarded up until now.

Reviewed by Simon Hausmann.

No new tests since this is refactoring of existing
functionality.

  • Target.pri:
  • platform/graphics/Font.cpp:

(WebCore::Font::drawText):

  • platform/graphics/Font.h:

(Font):
(WebCore):
(WebCore::Font::syntheticFont): Added.

  • platform/graphics/SimpleFontData.h:

(SimpleFontData):
(WebCore::SimpleFontData::getQtRawFont):
(WebCore):

  • platform/graphics/qt/FontCacheQt.cpp:

(WebCore::rawFontForCharacters):
(WebCore):
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::createFontPlatformData):

  • platform/graphics/qt/FontCustomPlatformData.h:

(FontCustomPlatformData):

  • platform/graphics/qt/FontCustomPlatformDataQt.cpp:

(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::FontCustomPlatformData::fontPlatformData):
(WebCore::createFontCustomPlatformData):

  • platform/graphics/qt/FontPlatformData.h:

(WebCore::FontPlatformDataPrivate::FontPlatformDataPrivate):
(FontPlatformDataPrivate):
(FontPlatformData):

  • platform/graphics/qt/FontPlatformDataQt.cpp:

(WebCore::FontPlatformData::FontPlatformData):
(WebCore):
(WebCore::FontPlatformData::operator==):

  • platform/graphics/qt/FontQt.cpp:

(WebCore::fillPenForContext):
(WebCore::pathForGlyphs):
(WebCore::drawQtGlyphRun):
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):
(WebCore::Font::initFormatForTextLayout):
(WebCore):
(WebCore::Font::drawGlyphs):
(WebCore::Font::syntheticFont):
(WebCore::Font::rawFont):

  • platform/graphics/qt/FontQt4.cpp: Copied from Source/WebCore/platform/graphics/qt/FontQt.cpp.

(WebCore):
(WebCore::fromRawDataWithoutRef):
(WebCore::setupLayout):
(WebCore::fillPenForContext):
(WebCore::strokePenForContext):
(WebCore::drawTextCommon):
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):
(WebCore::Font::canReturnFallbackFontsForComplexText):
(WebCore::Font::drawEmphasisMarksForComplexText):
(WebCore::Font::drawSimpleText):
(WebCore::Font::offsetForPositionForSimpleText):
(WebCore::Font::floatWidthForSimpleText):
(WebCore::Font::selectionRectForSimpleText):
(WebCore::Font::canExpandAroundIdeographsInComplexText):
(WebCore::Font::primaryFontHasGlyphForCharacter):
(WebCore::Font::emphasisMarkAscent):
(WebCore::Font::emphasisMarkDescent):
(WebCore::Font::emphasisMarkHeight):
(WebCore::Font::drawEmphasisMarksForSimpleText):
(WebCore::Font::font):

  • platform/graphics/qt/SimpleFontDataQt.cpp:

(WebCore::SimpleFontData::platformInit):

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::fileListNameForWidth):

  • platform/qt/RenderThemeQtMobile.cpp:

(WebCore::RenderThemeQtMobile::computeSizeBasedOnStyle):

Source/WebKit/qt:

Since QFont is not used internally, we now need
to query for a QFont that should be a good
enough match.

Reviewed by Simon Hausmann.

  • Api/qwebpage.cpp:

(QWebPage::inputMethodQuery):

  • WebCoreSupport/PopupMenuQt.cpp:

(WebCore::PopupMenuQt::show):

  • WebCoreSupport/RenderThemeQStyle.cpp:

(WebCore::RenderThemeQStyle::computeSizeBasedOnStyle):

Tools:

Flip the QRawFont switch for Qt 5.

Reviewed by Simon Hausmann.

  • qmake/mkspecs/features/features.prf:
06:22 Changeset [113967] by commit-queue@webkit.org

Calculate the cover rect of tiled backing store with the trajectory vector.
https://bugs.webkit.org/show_bug.cgi?id=83462

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2012-04-12
Reviewed by Kenneth Rohde Christiansen.

When trajectory vector is not zero, it is able to calculate the proper cover area.
No new tests - no new functionality.

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::computeCoverAndKeepRect):

06:12 Changeset [113966] by pfeldman@chromium.org

Source/WebCore: Web Inspector: extracting NetworkRequest from Resource (step 2)
https://bugs.webkit.org/show_bug.cgi?id=83773

Reviewed by Yury Semikhatsky.

This step moves request-related views from being resource-based to request-based.
See https://bugs.webkit.org/show_bug.cgi?id=61363 for the meta bug.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/ContentProviders.js:

(WebInspector.ResourceContentProvider):
(WebInspector.ResourceContentProvider.prototype.requestContent):
(WebInspector.ResourceContentProvider.prototype.searchInContent):

  • inspector/front-end/NetworkItemView.js:

(WebInspector.NetworkItemView):
(WebInspector.RequestContentView):
(WebInspector.RequestContentView.prototype._ensureInnerViewShown):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._showPopover):

  • inspector/front-end/NetworkRequest.js:

(WebInspector.NetworkRequest.prototype.resource):

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode.prototype._createContentProvider):

  • inspector/front-end/RequestCookiesView.js: Renamed from Source/WebCore/inspector/front-end/ResourceCookiesView.js.

(WebInspector.RequestCookiesView):

  • inspector/front-end/RequestHTMLView.js: Renamed from Source/WebCore/inspector/front-end/ResourceHTMLView.js.

(WebInspector.RequestHTMLView):
(WebInspector.RequestHTMLView.prototype._createIFrame):

  • inspector/front-end/RequestHeadersView.js: Renamed from Source/WebCore/inspector/front-end/ResourceHeadersView.js.

(WebInspector.RequestHeadersView):

  • inspector/front-end/RequestJSONView.js: Renamed from Source/WebCore/inspector/front-end/ResourceJSONView.js.

(WebInspector.RequestJSONView):
(WebInspector.RequestJSONView.parseJSON.WebInspector.RequestJSONView.parseJSONP):

  • inspector/front-end/RequestPreviewView.js: Renamed from Source/WebCore/inspector/front-end/ResourcePreviewView.js.

(WebInspector.RequestPreviewView):
(WebInspector.RequestPreviewView.prototype.contentLoaded):
(WebInspector.RequestPreviewView.prototype._createPreviewView):

  • inspector/front-end/RequestResponseView.js: Renamed from Source/WebCore/inspector/front-end/ResourceResponseView.js.

(WebInspector.RequestResponseView):
(WebInspector.RequestResponseView.prototype.get sourceView):
(WebInspector.RequestResponseView.prototype.contentLoaded):

  • inspector/front-end/RequestTimingView.js: Renamed from Source/WebCore/inspector/front-end/ResourceTimingView.js.

(WebInspector.RequestTimingView):
(WebInspector.RequestTimingView.prototype._refresh):

  • inspector/front-end/RequestView.js: Copied from Source/WebCore/inspector/front-end/NetworkRequest.js.

(WebInspector.RequestView):
(WebInspector.RequestView.prototype.hasContent):
(WebInspector.RequestView.hasTextContent):
(WebInspector.RequestView.nonSourceViewForRequest):

  • inspector/front-end/ResourceView.js:

(WebInspector.ResourceSourceFrame._canonicalMIMEType):
(WebInspector.ResourceSourceFrame._mimeTypeForResource):
(WebInspector.ResourceSourceFrame.prototype.requestContent):
(WebInspector.ResourceSourceFrame.prototype._contentChanged):
(WebInspector.ResourceRevisionSourceFrame.prototype.requestContent):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:

Tools: Web Inspector: Disabling Inspector causes build failure on Windows
https://bugs.webkit.org/show_bug.cgi?id=83557

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-04-11
Reviewed by Pavel Feldman.

The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
This change brings all such API calls under the guard.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(LayoutTestController):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::invoke):

LayoutTests: Web Inspector: extracting NetworkRequest from Resource (step 2)
https://bugs.webkit.org/show_bug.cgi?id=83773

Reviewed by Yury Semikhatsky.

  • http/tests/inspector/network/network-request-revision-content.html:
  • http/tests/inspector/network/request-parameters-decoding.html:
05:42 Changeset [113965] by ossy@webkit.org

[Qt] Unreviewed gardening after r113945, update platform specific expected files.

  • platform/qt-5.0-wk2/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt-5.0/Skipped: Unskip dom/prototype-inheritance-2.html and update its results.
  • platform/qt-5.0/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
05:19 Changeset [113964] by yurys@chromium.org

2012-04-12 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Fix a couple of compiler annotations after r113963.

  • inspector/front-end/TopDownProfileDataGridTree.js: (WebInspector.TopDownProfileDataGridTree): (WebInspector.TopDownProfileDataGridTree.prototype.exclude):
05:03 Changeset [113963] by yurys@chromium.org

Web Inspector: add closure compiler annotations for profiler code
https://bugs.webkit.org/show_bug.cgi?id=83700

Basic type annotations are added to most of the profiler front-end. Some
dead code removed.

Reviewed by Pavel Feldman.

  • inspector/compile-front-end.py:
  • inspector/front-end/BinarySearch.js:

(Object.defineProperty):

  • inspector/front-end/BottomUpProfileDataGridTree.js:

(WebInspector.BottomUpProfileDataGridNode.prototype._restore):
(WebInspector.BottomUpProfileDataGridNode.prototype._sharedPopulate):
(WebInspector.BottomUpProfileDataGridNode.prototype._willHaveChildren):
(WebInspector.BottomUpProfileDataGridTree):

  • inspector/front-end/DataGrid.js:
  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotInstanceNode.prototype._createChildNode):
(WebInspector.HeapSnapshotDiffNode.prototype.populateChildren.firstProviderPopulated):
(WebInspector.HeapSnapshotDiffNode.prototype.populateChildren.else.firstProviderPopulated):
(WebInspector.HeapSnapshotDiffNode.prototype.populateChildren):

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype._changeBase):
(WebInspector.DetailedHeapshotView.prototype._setRetainmentDataGridSource):
(WebInspector.DetailedHeapshotView.prototype._helpClicked.appendHelp):
(WebInspector.DetailedHeapshotView.prototype._helpClicked):

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot):
(HeapSnapshotMetainfo):
(WebInspector.HeapSnapshot.prototype._buildRetainers):
(WebInspector.HeapSnapshot.prototype._buildDominatedNodes):
(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):

  • inspector/front-end/ProfileDataGridTree.js:

(WebInspector.ProfileDataGridNode.prototype.insertChild):
(WebInspector.ProfileDataGridNode.prototype.removeChild):
(WebInspector.ProfileDataGridNode.prototype.removeChildren):
(WebInspector.ProfileDataGridNode.prototype._populate):
(WebInspector.ProfileDataGridTree.propertyComparator):

  • inspector/front-end/ProfileView.js:
  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfileHeader):
(WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.parsed):
(WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
(WebInspector.ProfilesPanel.prototype.performSearch.finishedCallback):
(WebInspector.ProfilesPanel.prototype.setRecordingProfile):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
(WebInspector.ProfilerDispatcher.prototype.addProfileHeader):

  • inspector/front-end/TopDownProfileDataGridTree.js:

(WebInspector.TopDownProfileDataGridTree):
(WebInspector.TopDownProfileDataGridTree.prototype.exclude):

  • inspector/front-end/externs.js:

(Array.prototype.binaryIndexOf):
(Array.prototype.sortRange):
(WebInspector.CSSSelectorProfileType):
(WebInspector.HeapSnapshotWorker):
(WebInspector.HeapSnapshotWorker.prototype.createObject):
(WebInspector.HeapSnapshotWorker.prototype.startCheckingForLongRunningCalls):

  • inspector/front-end/heapProfiler.css:
04:27 Component Model edited by hayato@chromium.org
(diff)
04:12 Changeset [113962] by commit-queue@webkit.org

[Qt][WK2] Zoom gesture with double tap crashes on iframe when main frame has scroll offset.
https://bugs.webkit.org/show_bug.cgi?id=83428

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-12
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

When delegate scrolling is on, the frame view needs to ignore scrolling offset when converting
coordinates. It is already done at ScrollView base class and this patch copies the logic to the
FrameView subclass.
Also make sure that TouchAdjustment's findBest*() functions' return value are not ignored by the caller.

Test: touchadjustment/iframe-with-mainframe-scroll-offset.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::bestClickableNodeForTouchPoint):
(WebCore::EventHandler::bestZoomableAreaForTouchPoint):

  • page/EventHandler.h:

(EventHandler):

  • page/FrameView.cpp:

(WebCore::FrameView::convertFromRenderer):
(WebCore::FrameView::convertToRenderer):

  • page/GestureTapHighlighter.cpp:
  • testing/Internals.cpp:

(WebCore::Internals::setDelegatesScrolling):
(WebCore::Internals::touchPositionAdjustedToBestClickableNode):
(WebCore::Internals::bestZoomableAreaForTouchPoint):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit2:

When delegate scrolling is on, the frame view needs to ignore scrolling offset when converting
coordinates. It is already done at ScrollView base class and this patch copies the logic to the
FrameView subclass.
Also make sure that TouchAdjustment's findBest*() functions' return value are not ignored by the caller.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::highlightPotentialActivation):
(WebKit::WebPage::findZoomableAreaForPoint):

LayoutTests:

  • touchadjustment/scroll-delegation/iframe-with-mainframe-scroll-offset-expected.txt: Added.
  • touchadjustment/scroll-delegation/iframe-with-mainframe-scroll-offset.html: Added.
  • touchadjustment/zoom-basic.html:
04:01 Changeset [113961] by ossy@webkit.org

[Qt] Unreviewed gardening after r113945, update platform specific expected files.

  • platform/qt-4.8/fast/dom/Window/window-properties-expected.txt:
  • platform/qt-5.0-wk2/fast/dom/Window/window-properties-expected.txt:
  • platform/qt-5.0/fast/dom/Window/window-properties-expected.txt:
03:52 Changeset [113960] by ossy@webkit.org

[Qt] Two canvas tests fail with QT_IMAGE_DECODER=0 setup
https://bugs.webkit.org/show_bug.cgi?id=83764

The following tests were failed after r108792:

  • canvas-toDataURL-case-insensitive-mimetype.html
  • toDataURL-supportedTypes.html

because supportedImageMIMETypesForEncoding wasn't filled
with MIME types in case of QT_IMAGE_DECODER=0 build setup.

Patch by Zoltan Horvath <zoltan@webkit.org> on 2012-04-12
Reviewed by Csaba Osztrogonác.

Fixes existing tests.

  • platform/MIMETypeRegistry.cpp:

(WebCore::initializeSupportedImageMIMETypesForEncoding):

03:32 Changeset [113959] by commit-queue@webkit.org

Unreviewed, rolling out r113931.
http://trac.webkit.org/changeset/113931
https://bugs.webkit.org/show_bug.cgi?id=83766

broke 4 tests on JSC platforms (Requested by philn-tp on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-12

Source/WebCore:

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNamedConstructorCallback):
(GenerateImplementation):

  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::createPrototype):

  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore):

  • bindings/v8/NPV8Object.cpp:

(WebCore::npObjectTypeInfo):

  • bindings/v8/V8BindingPerContextData.cpp:

(WebCore::V8BindingPerContextData::init):
(WebCore::V8BindingPerContextData::createWrapperFromCacheSlowCase):
(WebCore::V8BindingPerContextData::constructorForTypeSlowCase):

  • bindings/v8/V8BindingPerContextData.h:

(V8BindingPerContextData):

  • bindings/v8/V8HiddenPropertyName.h:

(WebCore):

  • bindings/v8/WrapperTypeInfo.h:

(WrapperTypeInfo):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore):

  • dom/NodeList.idl:

LayoutTests:

  • fast/dom/HTMLSelectElement/named-options-expected.txt:
  • fast/dom/HTMLSelectElement/script-tests/named-options.js:
  • fast/dom/NodeList/node-list-array-class-expected.txt: Removed.
  • fast/dom/NodeList/node-list-array-class.html: Removed.
  • fast/dom/NodeList/nodelist-item-call-as-function-expected.txt:
  • platform/chromium/fast/dom/HTMLSelectElement/named-options-expected.txt: Removed.
  • platform/chromium/inspector/console/command-line-api-expected.txt: Removed.
  • platform/chromium/inspector/console/console-dir-expected.txt:
  • platform/chromium/inspector/console/console-format-collections-expected.txt:
  • platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
03:26 Changeset [113958] by tkent@chromium.org

[Chromium] Fix !ENABLE(PAGE_POPUP) build

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl): Wrap m_pagePopup with ENABLE(PAGE_POPUP).

03:19 Changeset [113957] by yutak@chromium.org

Unreviewed, remove test expectations for worker-reload.html, as
the source of flakiness was removed in r113292.

  • platform/chromium/test_expectations.txt:
  • platform/mac/test_expectations.txt:
02:59 Changeset [113956] by tkent@chromium.org

[Chromium] Add PagePopup implementation
https://bugs.webkit.org/show_bug.cgi?id=81081

Reviewed by Adam Barth.

Add WebPagePopupImpl class, which is an implementation of
WebCore::PagePopup interface and WebKit::WebPagePopup interface. It's a
WebWidget which has a Page object.

No new tests because this makes no behavior change yet.

  • WebKit.gyp: Add WebPagePopupImpl.h.
  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::hasOpenedPopup): Supports the PagePopup.
(WebKit::ChromeClientImpl::openPagePopup):
just delegate to WebViewImpl::openPagePopup().
(WebKit::ChromeClientImpl::closePagePopup): ditto.

  • src/WebPagePopupImpl.cpp:

(PagePopupChromeClient):
This is a light implementation of ChromeClient for the page in
WebPagePopupImpl. This is a friend of WebPagePopupImpl becase of ease of
access to its members.
(WebKit::PagePopupChromeClient::PagePopupChromeClient):
(WebKit::WebPagePopupImpl::WebPagePopupImpl):
(WebKit::WebPagePopupImpl::~WebPagePopupImpl):
(WebKit::WebPagePopupImpl::init):
(WebKit::WebPagePopupImpl::initPage):
(WebKit::WebPagePopupImpl::size):
(WebKit::WebPagePopupImpl::animate): Calls PageWidgetDelegate::animate().
(WebKit::WebPagePopupImpl::composite):
(WebKit::WebPagePopupImpl::layout): Calls PageWidgetDelegate::layout().
(WebKit::WebPagePopupImpl::paint): Calls PageWidgetDelegate::paint().
(WebKit::WebPagePopupImpl::resize):
(WebKit::WebPagePopupImpl::handleKeyEvent):
(WebKit::WebPagePopupImpl::handleCharEvent):
(WebKit::WebPagePopupImpl::handleGestureEvent):
(WebKit::WebPagePopupImpl::handleInputEvent):
(WebKit::WebPagePopupImpl::setFocus):
(WebKit::WebPagePopupImpl::close): Delete the page, and kill itself.
(WebKit::WebPagePopupImpl::closePopup):
(WebKit::WebPagePopup::create):

  • src/WebPagePopupImpl.h: Added.
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl): Initialize m_pagePopup.
(WebKit::WebViewImpl::handleKeyEvent):
Renamed from keyEvent(). Forward key events to a PagePopup if it is open.
(WebKit::WebViewImpl::handleCharEvent):
Renamed from charEvent(). Forward char events to a PagePopup if it is open.
(WebKit::WebViewImpl::openPagePopup):
Added. Instantiate a WebPagePopupImpl, calculates a good bounding
rectangle of the page popup from the specified element rectangle,
initialize the WebPagePopupImpl, and stop caret blink.
(WebKit::WebViewImpl::closePagePopup):
Close the popup, clear m_pagePopup, and resume caret blink.
(WebKit::WebViewImpl::setFocus): Hide all the popups.
(WebKit::WebViewImpl::hidePopups): Hide the page popup too.

  • src/WebViewImpl.h:

(WebKit::WebViewImpl::hasOpenedPopup): Checks the page popup too.

02:51 Changeset [113955] by ossy@webkit.org

[Qt][ARM] Buildfix after r113934.

Reviewed by Zoltan Herczeg.

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::compare8):
(MacroAssemblerARM):

02:01 Changeset [113954] by kkristof@inf.u-szeged.hu

[Qt] Unreviewed gardening after r113885.

  • platform/qt/css2.1/20110323/replaced-elements-001-expected.png:
  • platform/qt/css2.1/20110323/replaced-elements-001-expected.txt:
01:51 Changeset [113953] by charles.wei@torchmobile.com.cn

[BlackBerry] Upstreaming BlackBerry-specific changes to PluginView -- remove unused functions
https://bugs.webkit.org/show_bug.cgi?id=83756

Reviewed by George Staikos.

PluginView::halt(), PluginView::restart() have been removed from
upstreaming code, should remove them from BlackBerry porting also.

  • plugins/blackberry/PluginViewBlackBerry.cpp:
01:50 Changeset [113952] by kkristof@inf.u-szeged.hu

[Qt] Unreveiwed gardening. Skip the failing reftest.

  • platform/qt/Skipped: skip fast/workers/worker-multi-startup.html
01:49 Changeset [113951] by bashi@chromium.org

[Chromium] The size of glyphStorage should be passed to substituteWithVerticalGlyphs()
https://bugs.webkit.org/show_bug.cgi?id=83751

Reviewed by Kent Tamura.

The last argument of substituteWithVerticalGlyphs() should be
the size of |glyphStorage|.

No new tests because we can't test the fix by layout tests.
I confirmed the fix with ASAN.

  • platform/graphics/skia/GlyphPageTreeNodeSkia.cpp:

(WebCore::GlyphPage::fill):

01:37 Changeset [113950] by commit-queue@webkit.org

[BlackBerry] We shouldn't set empty Content-Length & Content-Type to a request's headers.
https://bugs.webkit.org/show_bug.cgi?id=83349

When there is a redirection for a POST request, we change POST to GET and set
Content-Length/Content-Type to empty strings.
We should remove these headers instead of adding empty strings.

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-12
Reviewed by George Staikos.

No new tests. Refactor.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::handleRedirect):

  • platform/network/blackberry/ResourceRequest.h:

(ResourceRequest):

  • platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::ResourceRequest::clearHTTPContentLength):
(WebCore):
(WebCore::ResourceRequest::clearHTTPContentType):

01:31 Changeset [113949] by noel.gordon@gmail.com

[Qt] ImageBuffer: Canonical mimeType for encoding implies startsWith('image/')
https://bugs.webkit.org/show_bug.cgi?id=83746

Reviewed by Simon Hausmann.

Canonical image mimeTypes begin with "image/", and this is tested by an ASSERT
guard in toDataURL(): that checks the WebCore mimeType registry for image-for-
encoding mimeType. There is no need to also test mimeType.startsWith("image/")
since that is a given.

No new tests. Covered by existing fast/canvas/*toDataURL* tests.

  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::ImageBuffer::toDataURL):

01:22 Changeset [113948] by tkent@chromium.org

[Chromium] Move some code of WebViewImpl and WebFrameImpl to PageWidgetDelegate
https://bugs.webkit.org/show_bug.cgi?id=83750

Reviewed by Adam Barth.

In order to share code in WebViewImpl and the incoming WebPagePopupImpl,
we move some code of WebViewImpl and WebFrameImpl to PageWidgetDelegate.
PageWidgetDelegate is a set of static functions because we can't use
virtual inheritance in this case and we don't want to move WebView's
data members to another class.

No new tests. Just refactoring.

  • WebKit.gyp: Add PageWidgetDelegate.{cpp,h} and WebPagePopupImpl.h.
  • src/PageWidgetDelegate.cpp: Added.

(WebKit::mainFrameView):
(WebKit::PageWidgetDelegate::animate):
Moved from a part of WebViewImpl::animatie()
(WebKit::PageWidgetDelegate::layout):
Moved from WebViewImpl::layout() and WebFrameImpl::layout().
(WebKit::PageWidgetDelegate::paint):
Moved from WebFrameImpl::paint() and paintWithContext().
(WebKit::PageWidgetDelegate::handleInputEvent):
Moved from a part of WebViewImpl::handleInputEvent().
(WebKit::PageWidgetEventHandler::handleMouseMove):
Common implementation of an event handling.
(WebKit::PageWidgetEventHandler::handleMouseLeave): ditto.
(WebKit::PageWidgetEventHandler::handleMouseDown): ditto.
(WebKit::PageWidgetEventHandler::handleMouseUp): ditto.
(WebKit::PageWidgetEventHandler::handleMouseWheel): ditto.
(WebKit::PageWidgetEventHandler::handleTouchEvent): ditto.

  • src/PageWidgetDelegate.h: Added.
  • src/WebFrameImpl.cpp:

Remove layout(), paintWithContext(), and paint(). They are moved to
PageWidgetDelegate.

  • src/WebFrameImpl.h:

(WebFrameImpl): Remove layout(), paintWithContext(), and paint().

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleMouseLeave):
Renamed from mouseLeave(), use PageWidgetDelegate::handleMouseLeave().
(WebKit::WebViewImpl::handleMouseDown):
Renamed from mouseDown(), use PageWidgetDelegate::handleMouseDown().
(WebKit::WebViewImpl::handleMouseUp):
Renamed from mouseUp(), use PageWidgetDelegate::handleMouseUp().
(WebKit::WebViewImpl::scrollBy): Calls renamed handleMouseWheel().
(WebKit::WebViewImpl::handleGestureEvent): Renamed from gestureEvent().
(WebKit::WebViewImpl::handleKeyEvent): Renamed from keyEvent().
(WebKit::WebViewImpl::handleCharEvent): Renamed from charEvent().
(WebKit::WebViewImpl::updateAnimations): Uses PageWidgetDelegate::animate().
(WebKit::WebViewImpl::layout): Uses PageWidgetDelegate::layout().
(WebKit::WebViewImpl::paint): Uses PageWidgetDelegate::paint().
(WebKit::WebViewImpl::handleInputEvent): Uses PageWidgetDelegate::handleInputEvent().

  • src/WebViewImpl.h:
01:09 Changeset [113947] by enne@google.com

[chromium] Fix Windows compiler warnings in webkit_unit_test target
https://bugs.webkit.org/show_bug.cgi?id=83732

Reviewed by Kent Tamura.

  • tests/CCDamageTrackerTest.cpp:

(WebKitTests::TEST_F):

  • tests/CCLayerImplTest.cpp:

(WebCore::TEST):

  • tests/CCLayerTreeHostCommonTest.cpp:

(WebKitTests::TEST):

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKitTests::TEST_F):

  • tests/CCQuadCullerTest.cpp:

(WebCore::TEST):

  • tests/FloatQuadTest.cpp:

(WebCore::TEST):

  • tests/ScrollAnimatorNoneTest.cpp:

(TEST_F):

  • tests/TreeSynchronizerTest.cpp:

(WebKitTests::TEST):

  • tests/WebLayerTest.cpp:
00:08 Changeset [113946] by philn@webkit.org

Unreviewed, GTK rebaseline after r113945.

  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:

04/11/12:

23:35 Changeset [113945] by abarth@webkit.org

Implement Location.ancestorOrigins
https://bugs.webkit.org/show_bug.cgi?id=83493

Reviewed by David Levin.

Source/WebCore:

Test: fast/dom/Window/Location/ancestor-origins.html

This patch implements Location.ancestorOrigins(), which returns a list
of the origins of the enclosing frames. This API has been discussed
both on webkit-dev (see discussion following
https://lists.webkit.org/pipermail/webkit-dev/2012-March/020090.html)
and on the whatwg list (see discussion following
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-March/035188.html).

  • page/Location.cpp:

(WebCore::Location::ancestorOrigins):
(WebCore):

  • page/Location.h:

(Location):

  • page/Location.idl:

LayoutTests:

  • fast/dom/Window/Location/ancestor-origins-expected.txt: Added.
  • fast/dom/Window/Location/ancestor-origins.html: Added.
23:30 WebKitIDL edited by arv@chromium.org
Document the ArrayClass IDL attribute (diff)
23:05 Changeset [113944] by commit-queue@webkit.org

Unreviewed rebaseline.

Patch by Antonio Gomes <agomes@rim.com> on 2012-04-11

  • media/nodesFromRect-shadowContent-expected.txt:
22:51 Changeset [113943] by commit-queue@webkit.org

IndexedDB: Stub out WebKit interface for get(IndexedKeyRange)
https://bugs.webkit.org/show_bug.cgi?id=83637

Patch by Alec Flett <alecflett@chromium.org> on 2012-04-11
Reviewed by Kent Tamura.

This is just a stub-out of IDBObjectStore.get(IDBKeyRange) to coordinate
a landing in chromium

  • public/WebIDBObjectStore.h:

(WebKit::WebIDBObjectStore::get):
(WebIDBObjectStore):

  • src/IDBObjectStoreBackendProxy.cpp:

(WebKit::IDBObjectStoreBackendProxy::get):
(WebKit):

  • src/IDBObjectStoreBackendProxy.h:

(IDBObjectStoreBackendProxy):

  • src/WebIDBObjectStoreImpl.cpp:

(WebKit::WebIDBObjectStoreImpl::get):
(WebKit):

  • src/WebIDBObjectStoreImpl.h:

(WebIDBObjectStoreImpl):

22:40 Changeset [113942] by commit-queue@webkit.org

fast/text/international/font-fallback-to-common-script.html fails on Mac
https://bugs.webkit.org/show_bug.cgi?id=83743

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-04-11
Reviewed by Kent Tamura.

Change test not assume that there is no font setting for Simplified Chinese.

  • fast/text/international/font-fallback-to-common-script.html:
  • platform/mac/Skipped:
21:19 Changeset [113941] by fpizlo@apple.com

It is incorrect to short-circuit Branch(LogicalNot(@a)) if boolean speculations on @a may fail
https://bugs.webkit.org/show_bug.cgi?id=83744
<rdar://problem/11206946>

Source/JavaScriptCore:

Reviewed by Andy Estes.

This does the conservative thing: it only short-circuits Branch(LogicalNot(@a)) if @a is a node
that is statically known to return boolean results.

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

LayoutTests:

Rubber stamped by Andy Estes.

  • fast/js/dfg-branch-not-fail-expected.txt: Added.
  • fast/js/dfg-branch-not-fail.html: Added.
  • fast/js/script-tests/dfg-branch-not-fail.js: Added.

(foo):
(bar):

20:48 Changeset [113940] by commit-queue@webkit.org

AudioContext createChannelSplitter() method should have optional argument for number of outputs
https://bugs.webkit.org/show_bug.cgi?id=83648

Patch by Raymond Liu <raymond.liu@intel.com> on 2012-04-11
Reviewed by Chris Rogers.

Check https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html for the optional argument.

Source/WebCore:

Test: webaudio/audiochannelsplitter.html

  • Modules/webaudio/AudioChannelSplitter.cpp:

(WebCore::AudioChannelSplitter::create):
(WebCore::AudioChannelSplitter::AudioChannelSplitter):
(WebCore::AudioChannelSplitter::process):

  • Modules/webaudio/AudioChannelSplitter.h:

(AudioChannelSplitter):

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::createChannelSplitter):
(WebCore):

  • Modules/webaudio/AudioContext.h:

(AudioContext):

  • Modules/webaudio/AudioContext.idl:

LayoutTests:

  • webaudio/audiochannelsplitter-expected.txt: Added.
  • webaudio/audiochannelsplitter.html: Added.
20:34 Changeset [113939] by charles.wei@torchmobile.com.cn

[BlackBerry] Revert the changes that depend on Event changes, which is reverted already internally.
https://bugs.webkit.org/show_bug.cgi?id=83456

Reviewed by George Staikos.

No new tests, just to make BlackBerry-porting to build.

  • plugins/blackberry/PluginViewBlackBerry.cpp:

(WebCore::PluginView::handleWheelEvent):
(WebCore::PluginView::handleTouchEvent):
(WebCore::PluginView::handleMouseEvent):

20:06 Changeset [113938] by commit-queue@webkit.org

[BlackBerry] There shouldn't be two or more Accept-Language in platformRequest's headerList.
https://bugs.webkit.org/show_bug.cgi?id=83670

FrameLoaderClientBlackBerry::dispatchWillSendRequest and NetworkManager::startJob will call
ResourceRequest::initializePlatformRequest. Accept-Language is added two times.
We should avoid the second adding to improve performance.

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-11
Reviewed by Rob Buis.

No new tests. Refactor.

  • platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::ResourceRequest::initializePlatformRequest):

19:32 April 2012 Meeting edited by rniwa@webkit.org
Add slides for perf-o-matic / performance tests talk (diff)
19:10 Changeset [113937] by commit-queue@webkit.org

[BlackBerry] MMRPlayer will hang webkit thread when retrieving media metadata
https://bugs.webkit.org/show_bug.cgi?id=80978

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-04-11
Reviewed by Rob Buis.

Source/WebCore:

RIM PR: 143471
Implemented the interface function onWaitMetadataNotified()
which starts a timer to wait for the metadata retrieving to
finish, and pops up a dialog to notify the user what to do
if there still is no metadata when the timer fires.

This patch also contributed by Max Feil <mfeil@rim.com>.
Internally reviewed by Max Feil.

Test: http/tests/media/video-throttled-load-metadata.html

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore):
(WebCore::MediaPlayerPrivate::onWaitMetadataNotified):
(WebCore::MediaPlayerPrivate::waitMetadataTimerFired):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:

(MediaPlayerPrivate):

LayoutTests:

RIM PR: 143471
Added a layout test which simulates a slow network, and starts a web worker
thread to write a log message when retrieving media metadata to see if the
webkit thread is blocked by media retrieving thread.

  • http/tests/media/video-throttled-load-metadata-expected.txt: Added.
  • http/tests/media/video-throttled-load-metadata-worker.js: Added.
  • http/tests/media/video-throttled-load-metadata.html: Added.
18:55 Changeset [113936] by bashi@chromium.org

[chromium] Fix Windows warnings in WebSocketDeflaterTest
https://bugs.webkit.org/show_bug.cgi?id=83731

Reviewed by Kent Tamura.

Use const char* instead of const char[] to suppress warnings on
Windows.

  • tests/WebSocketDeflaterTest.cpp:

(WebCore::TEST):

18:38 Changeset [113935] by msaboff@apple.com

Invalid Union Reference in StructureStubInfo.{cpp.h}
https://bugs.webkit.org/show_bug.cgi?id=83735

Reviewed by Filip Pizlo.

Changed the references to u.getByIdProtoList and u.getByIdSelfList
to be consistent.

  • bytecode/StructureStubInfo.cpp:

(JSC::StructureStubInfo::visitWeakReferences):

  • bytecode/StructureStubInfo.h:

(JSC::StructureStubInfo::initGetByIdSelfList):

18:31 April 2012 Meeting edited by rniwa@webkit.org
Merge two test importing topics into one (diff)
18:13 Changeset [113934] by fpizlo@apple.com

Unreviewed attempting to make Qt's eccentric hardware work.

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::compare8):
(MacroAssemblerARM):

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::compare8):
(MacroAssemblerMIPS):

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::compare8):
(MacroAssemblerSH4):

18:09 Changeset [113933] by jer.noble@apple.com

Layout Test webaudio/* is flaky
https://bugs.webkit.org/show_bug.cgi?id=83624

Reviewed by Chris Rogers.

Source/WebCore:

No new tests; fixes webaudio/ layout tests.

A merge error led to an Mutex overunlock situation, which caused all future mutex trylock
attempts to fail, but only on Windows. Remove the extraneous mutex unlock().

  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::process):

LayoutTests:

Re-enable webaudio/ layout tests on chromium-win.

  • platform/chromium/test_expectations.txt:
18:02 Changeset [113932] by leviw@chromium.org

Correct pixel snapping error in RenderBox::pixelSnappedClientWidth/Height
https://bugs.webkit.org/show_bug.cgi?id=83621

Reviewed by Eric Seidel.

Though the problem wouldn't yet manifest itself since we haven't flipped the switch on sub-pixel
layout, clientWidth and clientHeight, when pixel snapped, need to take the RenderBox's location
into account. Previously, ClientLeft/Top were used, but these are simply the width of the borders,
and don't include the box's sub-pixel location, which is needed to properly snap the width/height.

No new tests. Untestable until we switch to FractionalLayoutUnits. A test case that covers this
is in the subpixellayout branch and will land with the switch.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::pixelSnappedClientWidth):
(WebCore::RenderBox::pixelSnappedClientHeight):
(WebCore::RenderBox::scrollWidth): Replacing a raw zero with ZERO_LAYOUT_UNIT.

18:00 Changeset [113931] by arv@chromium.org

Add support for [ArrayClass] and use that on NodeList
https://bugs.webkit.org/show_bug.cgi?id=81573

Reviewed by Adam Barth.

With this patch NodeLists now have Array.prototype on their prototype chain which allows
methods such as forEach and map to work on NodeLists.

http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#interface-nodelist

For V8 we need to set a flag on the WrapperTypeInfo since V8 uses FunctionTemplates which
does not allow setting the prototype to a non FunctionTemplate so the prototype is therefore
set when the constructor is created.

For JSC we just pass the right prototype object when creating the NodeList prototype. JSC has
a bug (81588) that prevents toString to work as specced on Array.prototype.toString. This
causes test failures in the tests until that has been fixed.

Source/WebCore:

Test: fast/dom/NodeList/node-list-array-class.html

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader): Include ArrayPrototype.h if an ArrayClass.
(GenerateImplementation): If ArrayClass use arrayPrototype as prototype.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNamedConstructorCallback):
(GenerateImplementation): Adds a flag to the WrapperTypeInfo.

  • bindings/scripts/IDLAttributes.txt: Adds new attribute: ArrayClass.
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::createPrototype):

  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore):

  • bindings/v8/V8BindingPerContextData.cpp:

(WebCore::V8BindingPerContextData::init): Get the array prototype too.
(WebCore::V8BindingPerContextData::createWrapperFromCacheSlowCase):
(WebCore::V8BindingPerContextData::constructorForTypeSlowCase): If this is an ArrayClass we need to
set the Prototype?.

  • bindings/v8/V8BindingPerContextData.h:

(V8BindingPerContextData):

  • bindings/v8/V8HiddenPropertyName.h:

(WebCore):

  • bindings/v8/WrapperTypeInfo.h:

(WrapperTypeInfo):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore):

  • dom/NodeList.idl:

LayoutTests:

  • fast/dom/HTMLSelectElement/named-options-expected.txt:
  • fast/dom/HTMLSelectElement/script-tests/named-options.js:
  • fast/dom/NodeList/node-list-array-class-expected.txt: Added.
  • fast/dom/NodeList/node-list-array-class.html: Added.
  • fast/dom/NodeList/nodelist-item-call-as-function-expected.txt:
  • platform/chromium/fast/dom/HTMLSelectElement/named-options-expected.txt: Copied from LayoutTests/fast/dom/HTMLSelectElement/named-options-expected.txt.
  • platform/chromium/inspector/console/command-line-api-expected.txt: Added.
  • platform/chromium/inspector/console/console-dir-expected.txt:
  • platform/chromium/inspector/console/console-format-collections-expected.txt:
  • platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
17:55 Changeset [113930] by fpizlo@apple.com

op_is_foo should be optimized
https://bugs.webkit.org/show_bug.cgi?id=83666

Reviewed by Gavin Barraclough.

This implements inlining of op_is_undefined, op_is_string, op_is_number,
and op_is_boolean in LLInt and the baseline JIT. op_is_object and
op_is_function are not inlined because they are quite a bit more complex.

This also implements all of the op_is_foo opcodes in the DFG, but it does
not do any type profiling based optimizations, yet.

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::compare8):
(MacroAssemblerARMv7):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::compare8):
(MacroAssemblerX86Common):

  • assembler/MacroAssemblerX86_64.h:

(MacroAssemblerX86_64):
(JSC::MacroAssemblerX86_64::testPtr):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCCallHelpers.h:

(JSC::DFG::CCallHelpers::setupArguments):
(CCallHelpers):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):
(JSC::DFG::SpeculativeJIT::appendCallSetResult):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

  • jit/JIT.h:

(JIT):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_is_undefined):
(JSC):
(JSC::JIT::emit_op_is_boolean):
(JSC::JIT::emit_op_is_number):
(JSC::JIT::emit_op_is_string):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_is_undefined):
(JSC):
(JSC::JIT::emit_op_is_boolean):
(JSC::JIT::emit_op_is_number):
(JSC::JIT::emit_op_is_string):

  • jit/JITStubs.cpp:

(JSC):

  • llint/LLIntSlowPaths.cpp:

(LLInt):

  • llint/LLIntSlowPaths.h:

(LLInt):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • offlineasm/armv7.rb:
  • offlineasm/instructions.rb:
  • offlineasm/x86.rb:
17:43 Changeset [113929] by dpranke@chromium.org

Fix regression introduced in r113927.

Unreviewed, build fix.

I failed to rename skipped_tests() to skipped_layout_tests()
everywhere it needed to be renamed. The unit tests didn't catch
this because the TestPort was one of the places that didn't get
renamed :(.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.parse_expectations):

  • Scripts/webkitpy/layout_tests/port/test.py:

(TestPort.skipped_layout_tests):

  • Scripts/webkitpy/tool/commands/queries.py:

(PrintExpectations._model):

17:29 Changeset [113928] by fpizlo@apple.com

If you use an IntegerOperand and want to return it with integerResult, you need to
zero extend to get rid of the box
https://bugs.webkit.org/show_bug.cgi?id=83734
<rdar://problem/11232296>

Reviewed by Oliver Hunt.

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):

17:13 Changeset [113927] by dpranke@chromium.org

new-run-webkit-tests: 'webkit-patch skipped-ports' introduced bad layering
https://bugs.webkit.org/show_bug.cgi?id=47528

Reviewed by Adam Barth.

The skipped-ports command has been replaced by 'webkit-patch
print-expectations', which offers the equivalent functionality
via 'webkit-patch print-expectations --platform \* -t skip'
(and other features, of course).

This also allows me to fix a nasty layering violation where the
chromium port had to know about the TestExpectations objects in
order to implement the command properly.

Lastly, this allows me to rename skipped_tests() to
skipped_layout_tests() to more consistent with
skipped_perf_tests().

This patch removes skips_layout_test() from the Port interface,
because that can't be implemented without the port knowing about
Expectations objects (and skipped-ports was the only thing using it).

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.skipped_layout_tests):
(Port.skipped_perf_tests):

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_default_configuration_notfound):

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.test_expectations_overrides):

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumPortTest.test_path_to_image_diff):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort.skipped_layout_tests):

  • Scripts/webkitpy/tool/commands/queries.py:

(execute):

  • Scripts/webkitpy/tool/commands/queries_unittest.py:

(QueryCommandsTest.test_tree_status):

16:46 Changeset [113926] by aestes@apple.com

Remove an autorelease pool made redundant by r113923.
https://bugs.webkit.org/show_bug.cgi?id=83730

Reviewed by Dan Bernstein.

Remove flushLayer()'s autorelease pool, since one now exists in the
call frame above it (in LayerFlushScheduler::runLoopObserverCallback()).

  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:

(WebKit::LayerTreeHostCAMac::flushLayers):

16:41 Changeset [113925] by antti@apple.com

Try to fix build with XSLT disabled.

Not reviewed.

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::parseStyleSheet):

16:32 April 2012 Meeting edited by adele@apple.com
(diff)
16:31 Changeset [113924] by arv@chromium.org

File API does not support DOM events (like addEventListener)
https://bugs.webkit.org/show_bug.cgi?id=83688

Reviewed by Adam Barth.

Source/WebCore:

The IDL files where missing addEventListener, removeEventListener and dispatchEvent.

Tests: fast/filesystem/file-writer-events.html

fast/speech/scripted/basics.html

  • Modules/filesystem/FileWriter.idl: Add missing methods.
  • Modules/mediastream/LocalMediaStream.idl: This one gets its EventTarget from MediaStream.
  • Modules/speech/SpeechRecognition.idl: Add missing methods.

LayoutTests:

  • fast/filesystem/resources/file-writer-events.js:

(runTest):

  • fast/speech/scripted/basics-expected.txt:
  • fast/speech/scripted/basics.html:
16:28 Changeset [113923] by aestes@apple.com

LayerFlushScheduler's run loop observer should have an autorelease pool.
https://bugs.webkit.org/show_bug.cgi?id=83729

Reviewed by Dan Bernstein.

LayerFlushScheduler's run loop observer needs an autorelease pool.
NSApplication creates one, but it is only drained after processing user
input. In the case where a WebView is displaying composited content but
not receiving user input, NSApplication's pool will accumulate a large
number of objects autoreleased by the run loop observer. Have
LayerFlushScheduler create an autorelease pool that is drained after
each run loop observer callback.

  • platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp:

(WebCore::LayerFlushScheduler::runLoopObserverCallback):

16:20 Changeset [113922] by antti@apple.com

Split CSSStyleSheet into internal and CSSOM type
https://bugs.webkit.org/show_bug.cgi?id=83612

Reviewed by Andreas Kling.

This will complete the separation of our style sheet data structures from CSSOM.

The internal parts of CSSStyleSheet move to StyleSheetInternal. CSS parser
and style selector will now operate on internal types. Unlike other CSSOM types
CSSStyleSheets are still always instantiated to hold the top level author stylesheets
(by Nodes).

  • css/CSSFontFaceSrcValue.cpp:

(WebCore::CSSFontFaceSrcValue::addSubresourceStyleURLs):

  • css/CSSFontFaceSrcValue.h:

(CSSFontFaceSrcValue):

  • css/CSSImportRule.cpp:

(WebCore::StyleRuleImport::create):
(WebCore::StyleRuleImport::StyleRuleImport):
(WebCore::StyleRuleImport::setCSSStyleSheet):
(WebCore::StyleRuleImport::requestStyleSheet):
(WebCore::CSSImportRule::~CSSImportRule):
(WebCore):
(WebCore::CSSImportRule::styleSheet):

  • css/CSSImportRule.h:

(WebCore):
(StyleRuleImport):
(WebCore::StyleRuleImport::parentStyleSheet):
(WebCore::StyleRuleImport::styleSheet):
(CSSImportRule):

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::insertRule):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseSheet):
(WebCore::CSSParser::parseRule):
(WebCore::CSSParser::parseKeyframeRule):
(WebCore::CSSParser::parseFontFaceValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseSelector):
(WebCore::CSSParser::parseDeclaration):
(WebCore::CSSParser::setStyleSheet):
(WebCore::CSSParser::parseFlowThread):

  • css/CSSParser.h:

(WebCore):
(CSSParser):

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::addSubresourceStyleURLs):

  • css/CSSPrimitiveValue.h:

(CSSPrimitiveValue):

  • css/CSSReflectValue.cpp:

(WebCore::CSSReflectValue::addSubresourceStyleURLs):

  • css/CSSReflectValue.h:

(CSSReflectValue):

  • css/CSSRule.h:

(CSSRule):

  • css/CSSStyleSelector.cpp:

(RuleSet):
(WebCore):
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::addAuthorRulesAndCollectUserRulesFromSheets):
(WebCore::CSSStyleSelector::determineScope):
(WebCore::CSSStyleSelector::appendAuthorStylesheets):
(WebCore::parseUASheet):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • css/CSSStyleSelector.h:

(CSSStyleSelector):

Add a set for root CSSStyleSheet objects so that the wrappers created in ensureFullCSSOMWrapperForInspector
stay valid.


  • css/CSSStyleSheet.cpp:

(WebCore::StyleSheetInternal::StyleSheetInternal):
(WebCore::StyleSheetInternal::~StyleSheetInternal):
(WebCore::StyleSheetInternal::parserAppendRule):
(WebCore::StyleSheetInternal::createChildRuleCSSOMWrapper):
(WebCore::StyleSheetInternal::ruleCount):
(WebCore::StyleSheetInternal::clearCharsetRule):
(WebCore::StyleSheetInternal::clearRules):
(WebCore::StyleSheetInternal::parserSetEncodingFromCharsetRule):
(WebCore::StyleSheetInternal::wrapperInsertRule):
(WebCore::StyleSheetInternal::wrapperDeleteRule):
(WebCore::StyleSheetInternal::addNamespace):
(WebCore::StyleSheetInternal::determineNamespace):
(WebCore::StyleSheetInternal::parseString):
(WebCore::StyleSheetInternal::parseStringAtLine):
(WebCore::StyleSheetInternal::isLoading):
(WebCore::StyleSheetInternal::checkLoaded):
(WebCore::StyleSheetInternal::notifyLoadedSheet):
(WebCore::StyleSheetInternal::startLoadingDynamicSheet):
(WebCore::StyleSheetInternal::findStyleSheetOwnerNode):
(WebCore::StyleSheetInternal::findDocument):
(WebCore::StyleSheetInternal::setMediaQueries):
(WebCore::StyleSheetInternal::styleSheetChanged):
(WebCore):
(WebCore::StyleSheetInternal::baseURL):
(WebCore::StyleSheetInternal::completeURL):
(WebCore::StyleSheetInternal::addSubresourceStyleURLs):
(WebCore::StyleSheetInternal::parentStyleSheet):
(WebCore::CSSStyleSheet::CSSStyleSheet):
(WebCore::CSSStyleSheet::~CSSStyleSheet):
(WebCore::CSSStyleSheet::setDisabled):
(WebCore::CSSStyleSheet::length):
(WebCore::CSSStyleSheet::item):
(WebCore::CSSStyleSheet::rules):
(WebCore::CSSStyleSheet::insertRule):
(WebCore::CSSStyleSheet::addRule):
(WebCore::CSSStyleSheet::cssRules):
(WebCore::CSSStyleSheet::deleteRule):
(WebCore::CSSStyleSheet::media):
(WebCore::CSSStyleSheet::parentStyleSheet):

  • css/CSSStyleSheet.h:

(WebCore):
(WebCore::StyleSheetInternal::create):
(WebCore::StyleSheetInternal::createInline):
(StyleSheetInternal):
(WebCore::StyleSheetInternal::ownerNode):
(WebCore::StyleSheetInternal::clearOwnerNode):
(WebCore::StyleSheetInternal::ownerRule):
(WebCore::StyleSheetInternal::originalURL):
(WebCore::StyleSheetInternal::title):
(WebCore::StyleSheetInternal::setTitle):
(WebCore::StyleSheetInternal::setFinalURL):
(WebCore::StyleSheetInternal::finalURL):
(CSSStyleSheet):
(WebCore::CSSStyleSheet::create):
(WebCore::CSSStyleSheet::removeRule):
(WebCore::CSSStyleSheet::clearOwnerRule):
(WebCore::CSSStyleSheet::styleSheetChanged):
(WebCore::CSSStyleSheet::findDocument):
(WebCore::CSSStyleSheet::internal):
(WebCore::CSSStyleSheet::isCSSStyleSheet):
(WebCore::CSSStyleSheet::type):

  • css/CSSValue.cpp:

(WebCore::CSSValue::addSubresourceStyleURLs):

  • css/CSSValue.h:

(WebCore):
(CSSValue):

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::addSubresourceStyleURLs):

  • css/CSSValueList.h:

(CSSValueList):

  • css/CSSValuePool.cpp:

(WebCore::CSSValuePool::createFontFaceValue):

  • css/CSSValuePool.h:

(WebCore):
(CSSValuePool):

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):

  • css/PropertySetCSSStyleDeclaration.h:

(WebCore):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::setProperty):
(WebCore::StylePropertySet::parseDeclaration):
(WebCore::StylePropertySet::addSubresourceStyleURLs):

  • css/StylePropertySet.h:

(WebCore):
(StylePropertySet):

  • css/StyleSheet.cpp:

(WebCore):

  • css/StyleSheet.h:

(StyleSheet):
(WebCore::StyleSheet::media):
(WebCore::StyleSheet::ownerRule):
(WebCore::StyleSheet::isXSLStyleSheet):

  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::insertRule):

  • dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createCSSStyleSheet):

  • dom/Document.cpp:

(WebCore::Document::updateBaseURL):
(WebCore::Document::pageUserSheet):
(WebCore::Document::pageGroupUserSheets):
(WebCore::Document::addUserSheet):
(WebCore::Document::elementSheet):
(WebCore::Document::testAddedStylesheetRequiresStyleRecalc):
(WebCore::Document::analyzeStylesheetChange):

  • dom/Document.h:

(WebCore):
(Document):
(WebCore::Document::documentUserSheets):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::updateInlineStyleAvoidingMutation):

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::setCSSStyleSheet):
(WebCore::ProcessingInstruction::parseStyleSheet):

  • dom/StyleElement.cpp:

(WebCore::StyleElement::createSheet):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::addSubresourceAttributeURLs):
(WebCore):
(WebCore::StyledElement::addPropertyToAttributeStyle):

  • dom/StyledElement.h:

(WebCore):

  • html/HTMLFontElement.cpp:

(WebCore::HTMLFontElement::collectStyleForAttribute):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::parseAttribute):
(WebCore::HTMLLinkElement::setCSSStyleSheet):
(WebCore::HTMLLinkElement::styleSheetIsLoading):
(WebCore::HTMLLinkElement::addSubresourceAttributeURLs):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::parseAttribute):
(WebCore::HTMLStyleElement::addSubresourceAttributeURLs):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::fillMediaListChain):
(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyleSheet::styleSheetURL):
(WebCore::InspectorStyleSheet::reparseStyleSheet):
(WebCore::InspectorStyleSheet::ensureSourceData):
(WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeCSSStyleSheet):

  • svg/SVGStyleElement.cpp:

(WebCore::SVGStyleElement::parseAttribute):

  • xml/XSLStyleSheet.h:

(XSLStyleSheet):
(WebCore::XSLStyleSheet::finalURL):

  • xml/XSLStyleSheetLibxslt.cpp:

(WebCore::XSLStyleSheet::XSLStyleSheet):
(WebCore::XSLStyleSheet::isLoading):

16:14 Changeset [113921] by commit-queue@webkit.org

Unreviewed, rolling out r113912.
http://trac.webkit.org/changeset/113912
https://bugs.webkit.org/show_bug.cgi?id=83727

broke atsui-spacing-features.html on windows (Requested by
simonjam on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-11

Source/WebCore:

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::justify):

LayoutTests:

  • fast/text/international/arabic-justify.html: Removed.
  • platform/chromium-win/fast/text/international/arabic-justify-expected.png: Removed.
  • platform/chromium-win/fast/text/international/arabic-justify-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac-snowleopard/fast/text/international/arabic-justify-expected.png: Removed.
  • platform/mac-snowleopard/fast/text/international/arabic-justify-expected.txt: Removed.
16:08 Changeset [113920] by mrowe@apple.com

Remove a fprintf from LayoutTestController.

This fprintf is causing 100+MB of data to be written to stderr during a single run of the tests.
It was added for no apparent reason by Ryosuke in r113651.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::redirectionDestinationForURL):

15:52 Changeset [113919] by fpizlo@apple.com

SpeculativeJIT::fillStorage() should work with all the states that a cell may be in
https://bugs.webkit.org/show_bug.cgi?id=83722

Reviewed by Gavin Barraclough.

It's now possible to do StorageOperand on a cell, in the case that the storage is
inline. But this means that fillStorage() must be able to handle all of the states
that a cell might be in. Previously it didn't.

With this change, it now does handle all of the states, and moreover, it does so
by preserving the DataFormat of cells and performing all of the cell speculations
that should be performed if you're using a cell as storage. But if you use this on
something that is known to be storage already then it behaves as it did before.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::fillStorage):

15:48 Changeset [113918] by commit-queue@webkit.org

[chromium] When rendering goes idle, do not count that time against frame rate
https://bugs.webkit.org/show_bug.cgi?id=73454

The FPS counter had a few issues with its reporting. The first
3 swapbuffers are non-blocking and create FPS rates that are
unrealistically high, throwing off the moving averages and
introducing false spikes into the FPS graph. There was also no
way to monitor the smoothness of the animation, or to focus in
on a particular animation or transition.

This patch updates the FPS counter code so that bad data points
are trimmed and not graphed; so that the graph itself is taller
and more legible; so that there is a clear boundary between 40FPS
and better; and to keep statistics on frame rate between
pauses in the activity in the UI so that you can trigger a
transition and read off the average and standard deviation for
that transition to judge it smooth enough or not.

Patch by Alex Nicolaou <anicolao@chromium.org> on 2012-04-11
Reviewed by James Robinson.

HUD is not testable in webkit.

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
(WebCore::CCHeadsUpDisplay::onFrameBegin):
(WebCore::CCHeadsUpDisplay::drawHudContents):
(WebCore::CCHeadsUpDisplay::drawFPSCounter):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
15:47 April 2012 Meeting edited by jacobg@adobe.com
(diff)
15:47 April 2012 Meeting edited by jacobg@adobe.com
(diff)
15:44 Changeset [113917] by andersca@apple.com

Add two flaky plug-in tests.

  • platform/mac/Skipped:
15:38 Changeset [113916] by andersca@apple.com

Add tests that broke in r113900 to the Skipped list.

  • platform/mac/Skipped:
15:29 April 2012 Meeting edited by tomz@codeaurora.org
(diff)
15:25 April 2012 Meeting edited by rniwa@webkit.org
(diff)
15:12 Changeset [113915] by zmo@google.com

WebGLRenderingContext should defer caching program info
https://bugs.webkit.org/show_bug.cgi?id=83513

Reviewed by Kenneth Russell.

  • html/canvas/WebGLProgram.cpp:

(WebCore::WebGLProgram::WebGLProgram):
(WebCore::WebGLProgram::numActiveAttribLocations): call cacheInfoIfNeeded();
(WebCore::WebGLProgram::getActiveAttribLocation): Ditto.
(WebCore::WebGLProgram::isUsingVertexAttrib0): Ditto.
(WebCore::WebGLProgram::getLinkStatus): Ditto.
(WebCore):
(WebCore::WebGLProgram::cacheActiveAttribLocations):
(WebCore::WebGLProgram::cacheInfoIfNeeded): Cache link status, active attire locations, etc if needed.
(WebCore::WebGLProgram::increaseLinkCount): also invalidate cached info.

  • html/canvas/WebGLProgram.h:

(WebGLProgram):

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::linkProgram): Do not cache program info immediately.

15:04 Changeset [113914] by commit-queue@webkit.org

Add keySystem attribute to canPlayType() for Encrypted Media Extensions
https://bugs.webkit.org/show_bug.cgi?id=82973

Patch by David Dorwin <ddorwin@chromium.org> on 2012-04-11
Reviewed by Adam Barth.

The new attribute is behind the ENABLE(ENCRYPTED_MEDIA) feature define.
Implementation is based on v0.1 of the draft proposal at
http://dvcs.w3.org/hg/html-media/raw-file/tip/encrypted-media/encrypted-media.html#extensions.

Source/Platform:

  • chromium/public/WebMimeRegistry.h:

(WebKit::WebMimeRegistry::supportsMediaMIMEType):

Source/WebCore:

Tests: media/encrypted-media/encrypted-media-can-play-type-webm.html

media/encrypted-media/encrypted-media-can-play-type.html

  • dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createDocument):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::canPlayType):
(WebCore::HTMLMediaElement::selectMediaResource):
(WebCore::HTMLMediaElement::loadNextSourceChild):
(WebCore::HTMLMediaElement::loadResource):
(WebCore::HTMLMediaElement::havePotentialSourceChild):
(WebCore::HTMLMediaElement::selectNextSourceChild):
(WebCore::HTMLMediaElement::getPluginProxyParams):

  • html/HTMLMediaElement.h:

(HTMLMediaElement):

  • html/HTMLMediaElement.idl:
  • platform/graphics/MediaPlayer.cpp:

(WebCore):
(WebCore::bestMediaEngineForTypeAndCodecs):
(WebCore::MediaPlayer::load):
(WebCore::MediaPlayer::loadWithNextMediaEngine):
(WebCore::MediaPlayer::supportsType):
(WebCore::MediaPlayer::networkStateChanged):

  • platform/graphics/MediaPlayer.h:

(MediaPlayer):
(WebCore):

Source/WebKit/chromium:

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::supportsType):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

LayoutTests:

  • media/encrypted-media/encrypted-media-can-play-type-expected.txt: Added.
  • media/encrypted-media/encrypted-media-can-play-type-webm-expected.txt: Added.
  • media/encrypted-media/encrypted-media-can-play-type-webm.html: Added.
  • media/encrypted-media/encrypted-media-can-play-type.html: Added.
14:43 Changeset [113913] by andersca@apple.com

[Qt] InspectorServer: Add an API level auto test
https://bugs.webkit.org/show_bug.cgi?id=83594

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2012-04-10
Reviewed by Kenneth Rohde Christiansen.

  • Source/tests.pri:
14:42 Changeset [113912] by xji@chromium.org

[chromium] wrong justification for arabic/persian page in cr-win.
https://bugs.webkit.org/show_bug.cgi?id=83227

Reviewed by Kent Tamura.

Source/WebCore:

GDI used to do Kashida justification.
After switch to Skia, we need to use space padding to justify the text
(assume Skia can not do Kashida justification -- stretching words).

Test: fast/text/international/arabic-justify.html

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::justify):

LayoutTests:

  • fast/text/international/arabic-justify.html: Added.
  • platform/chromium-win/fast/text/international/arabic-justify-expected.png: Added.
  • platform/chromium-win/fast/text/international/arabic-justify-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac-snowleopard/fast/text/international/arabic-justify-expected.png: Added.
  • platform/mac-snowleopard/fast/text/international/arabic-justify-expected.txt: Added.
14:33 Changeset [113911] by philn@webkit.org

Unreviewed, GTK rebaseline after r113885.

  • platform/gtk/css2.1/20110323/replaced-elements-001-expected.txt:
14:27 Changeset [113910] by tonikitoo@webkit.org

All Mac bots occasionally fail tons of media/ sputnik/ and svg/ tests
https://bugs.webkit.org/show_bug.cgi?id=83411

Reviewed by Eric Carlson.
Patch by Antonio Gomes <agomes@rim.com>

Fix obvious problems with the test in order to make tests lets
flaky.

  • media/nodesFromRect-shadowContent.html:
  • platform/gtk/media/nodesFromRect-shadowContent-expected.txt:
14:07 Changeset [113909] by mrobinson@webkit.org

[CAIRO] Make GLContextGLX a subclass of GLContext
https://bugs.webkit.org/show_bug.cgi?id=81285

Reviewed by Gustavo Noronha Silva.

.:

  • GNUmakefile.am: Add a configuration option for activating GLX.

This is selected automatically now, but in the future there will be
the choice to turn on EGL and turn off GLX at compilation time.

  • configure.ac: Ditto.

Source/WebCore:

No new tests. This should not change behavior.

  • GNUmakefile.list.am: Add new GLContextGLX files.
  • platform/graphics/cairo/GLContext.cpp: Added. Composed of the

EGL/GLX independent portions of GLContext. Made the current context
a static variable so we can keep getting the current context platform-
-independent.

  • platform/graphics/cairo/GLContext.h: Make this class an abstract

class. GLContextGLX is a concrete implementation.

  • platform/graphics/cairo/GraphicsContext3DPrivate.cpp: Updated to reflect

slightly different calling conventions to create a sharing context.

  • platform/graphics/glx/GLContextGLX.cpp: Updated to reflect

that this code is in a subclass now.

  • platform/graphics/glx/GLContextGLX.h: Copied from Source/WebCore/platform/graphics/cairo/GLContext.h.
  • platform/graphics/gtk/GLContextGtk.cpp:

(WebCore::GLContext::getContextForWidget): Updated to respect the new
USE(GLX) flag.

14:03 Changeset [113908] by rniwa@webkit.org

fast/dom/dom-parse-serialize.html and dom-parse-serialize-display.html should be text tests
https://bugs.webkit.org/show_bug.cgi?id=83715

Reviewed by Rob Buis.

Converted the fast/dom/dom-parse-serialize.html and dom-parse-serialize-display.html to dumpAsText tests.

  • fast/dom/dom-parse-serialize-display-expected.txt: Added.
  • fast/dom/dom-parse-serialize-display.html:
  • fast/dom/dom-parse-serialize-expected.txt: Added.
  • fast/dom/dom-parse-serialize.html:
  • platform/chromium-linux/fast/dom/dom-parse-serialize-display-expected.png: Removed.
  • platform/chromium-linux/fast/dom/dom-parse-serialize-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/dom/dom-parse-serialize-display-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/dom/dom-parse-serialize-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/dom/dom-parse-serialize-display-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/dom/dom-parse-serialize-expected.png: Removed.
  • platform/chromium-mac/fast/dom/dom-parse-serialize-display-expected.png: Removed.
  • platform/chromium-mac/fast/dom/dom-parse-serialize-expected.png: Removed.
  • platform/chromium-win/fast/dom/dom-parse-serialize-display-expected.png: Removed.
  • platform/chromium-win/fast/dom/dom-parse-serialize-display-expected.txt: Removed.
  • platform/chromium-win/fast/dom/dom-parse-serialize-expected.png: Removed.
  • platform/chromium-win/fast/dom/dom-parse-serialize-expected.txt: Removed.
  • platform/efl/fast/dom/dom-parse-serialize-display-expected.png: Removed.
  • platform/efl/fast/dom/dom-parse-serialize-display-expected.txt: Removed.
  • platform/efl/fast/dom/dom-parse-serialize-expected.png: Removed.
  • platform/efl/fast/dom/dom-parse-serialize-expected.txt: Removed.
  • platform/gtk/fast/dom/dom-parse-serialize-display-expected.png: Removed.
  • platform/gtk/fast/dom/dom-parse-serialize-display-expected.txt: Removed.
  • platform/gtk/fast/dom/dom-parse-serialize-expected.png: Removed.
  • platform/gtk/fast/dom/dom-parse-serialize-expected.txt: Removed.
  • platform/mac-leopard/fast/dom/dom-parse-serialize-display-expected.png: Removed.
  • platform/mac-leopard/fast/dom/dom-parse-serialize-expected.png: Removed.
  • platform/mac/fast/dom/dom-parse-serialize-display-expected.png: Removed.
  • platform/mac/fast/dom/dom-parse-serialize-display-expected.txt: Removed.
  • platform/mac/fast/dom/dom-parse-serialize-expected.png: Removed.
  • platform/mac/fast/dom/dom-parse-serialize-expected.txt: Removed.
  • platform/qt/fast/dom/dom-parse-serialize-display-expected.png: Removed.
  • platform/qt/fast/dom/dom-parse-serialize-display-expected.txt: Removed.
  • platform/qt/fast/dom/dom-parse-serialize-expected.png: Removed.
  • platform/qt/fast/dom/dom-parse-serialize-expected.txt: Removed.
13:57 Changeset [113907] by leviw@chromium.org

Fixing a truncation of length values that was occuring after a refactor in LengthFunctions and dealing with the repercussions in RenderMarquee, Document, and RenderFrameSet. Also correcting a table border painting issue evident in fast/multicol/table-vertical-align that only crops up in multi-column tables. We must floor the size when painting the Table's decorations because we ultimately lay out the contents using flooring.

13:51 Changeset [113906] by fpizlo@apple.com

Global variable predictions should not be coalesced unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=83678

Reviewed by Geoff Garen.

Removed the PredictionTracker and everyone who used it. Converted GetGlobalVar
to have a heapPrediction like a civilized DFG opcode ought to.

No performance effect.

  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/CodeBlock.h:
  • bytecode/PredictionTracker.h: Removed.
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGenerationInfo.h:
  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:

(Graph):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasHeapPrediction):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

13:34 Changeset [113905] by tomz@codeaurora.org

Unreviewed gardening and fix naming on EFL expected.txt files

  • platform/chromium-linux/fast/text/text-shadow-no-default-color-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png:
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png:
  • platform/chromium-mac-leopard/fast/text/text-shadow-no-default-color-expected.png: Added.
  • platform/chromium-mac-leopard/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png:
  • platform/chromium-mac-leopard/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/text-shadow-no-default-color-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png:
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png:
  • platform/chromium-mac/fast/text/text-shadow-no-default-color-expected.png: Added.
  • platform/chromium-mac/fast/text/text-shadow-no-default-color-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png:
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png:
  • platform/chromium-win/fast/text/text-shadow-no-default-color-expected.png: Added.
  • platform/chromium-win/fast/text/text-shadow-no-default-color-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/efl/fast/text/text-shadow-no-default-color-expected.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background-color-border-box-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-002-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-001-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-002-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-003-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-004-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/color-behind-images-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/order-of-images-actual.txt.
  • platform/efl/ietestcenter/css3/text/textshadow-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-001-actual.txt.
  • platform/efl/ietestcenter/css3/text/textshadow-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-002-actual.txt.
  • platform/efl/ietestcenter/css3/text/textshadow-003-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-003-actual.txt.
  • platform/efl/ietestcenter/css3/text/textshadow-004-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-004-actual.txt.
  • platform/efl/ietestcenter/css3/text/textshadow-005-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-005-actual.txt.
  • platform/efl/ietestcenter/css3/text/textshadow-006-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-006-actual.txt.
  • platform/efl/ietestcenter/css3/text/textshadow-007-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-007-actual.txt.
  • platform/efl/ietestcenter/css3/text/textshadow-008-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-008-actual.txt.
  • platform/efl/ietestcenter/css3/text/textshadow-009-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-009-actual.txt.
  • platform/efl/ietestcenter/css3/text/textshadow-010-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-010-actual.txt.
  • platform/efl/test_expectations.txt:
  • platform/mac/fast/text/text-shadow-no-default-color-expected.txt: Added.
  • platform/mac/test_expectations.txt:
  • platform/qt/fast/text/text-shadow-no-default-color-expected.txt: Added.
  • platform/qt/test_expectations.txt:
13:26 Changeset [113904] by lforschler@apple.com

Versioning.

13:25 Changeset [113903] by rwlbuis@webkit.org

[BlackBerry] Upstream BlackBerry change to PatternSkia.cpp
https://bugs.webkit.org/show_bug.cgi?id=83361

Reviewed by Antonio Gomes.

Upstream a cleaned up version.

  • platform/graphics/skia/PatternSkia.cpp:

(WebCore::Pattern::platformDestroy):
(WebCore::Pattern::platformPattern):

13:19 Changeset [113902] by jamesr@google.com

[chromium] Add OVERRIDE annotations for cc layer types
https://bugs.webkit.org/show_bug.cgi?id=83658

Reviewed by Daniel Bates.

This adds OVERRIDE annotations to overrides of functions on these classes:

  • CCLayerImpl
  • LayerChromium
  • TiledLayerChromium

Source/WebCore:

  • platform/graphics/chromium/Canvas2DLayerChromium.h:

(Canvas2DLayerChromium):

  • platform/graphics/chromium/CanvasLayerChromium.h:

(CanvasLayerChromium):

  • platform/graphics/chromium/ContentLayerChromium.h:

(ContentLayerChromium):

  • platform/graphics/chromium/ImageLayerChromium.h:

(ImageLayerChromium):

  • platform/graphics/chromium/PluginLayerChromium.h:

(PluginLayerChromium):

  • platform/graphics/chromium/TiledLayerChromium.h:

(TiledLayerChromium):

  • platform/graphics/chromium/VideoLayerChromium.h:

(VideoLayerChromium):

  • platform/graphics/chromium/WebGLLayerChromium.h:

(WebGLLayerChromium):

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:

(CCScrollbarLayerImpl):

  • platform/graphics/chromium/cc/CCSolidColorLayerImpl.h:

(CCSolidColorLayerImpl):

  • platform/graphics/chromium/cc/CCTextureLayerImpl.h:

(CCTextureLayerImpl):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:

(CCTiledLayerImpl):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:

(CCVideoLayerImpl):

Source/WebKit/chromium:

  • src/WebLayerImpl.cpp:
  • src/WebLayerImpl.h:

(WebLayerImpl): Removed unused and empty paintContents() function.

  • tests/CCLayerIteratorTest.cpp:
  • tests/CCLayerTreeHostCommonTest.cpp:
  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/CCLayerTreeHostTest.cpp:
  • tests/CCOcclusionTrackerTest.cpp:
  • tests/CCTiledLayerTestCommon.h:

(FakeTiledLayerChromium):

  • tests/LayerChromiumTest.cpp:
  • tests/TreeSynchronizerTest.cpp:
13:16 Changeset [113901] by thakis@chromium.org

[mac] Suppress deprecation warning for GlobalToLocal in the carbon parts of the test plugin.
https://bugs.webkit.org/show_bug.cgi?id=83709

Reviewed by Anders Carlsson.

  • DumpRenderTree/TestNetscapePlugIn/main.cpp:

(handleEventCarbon):

13:13 Changeset [113900] by ap@apple.com

[Mac] lang, xml:lang, content-language ignored when choosing fonts
https://bugs.webkit.org/show_bug.cgi?id=10874
<rdar://problem/3220202>

Reviewed by Dan Bernstein.

Adding a default font table for Mac port. Clients can still override these if they want to,
but knowing which fonts to use is more about the platform than about the client.

Tests: platform/mac/fonts/han-disunification.html

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • Resources/DefaultFonts.plist.in: Added. Added SettingsMac.mm. Added preprocessed property list with default fonts.
  • page/Settings.cpp: (WebCore::setGenericFontFamilyMap): Don't notify the page if we don't have one yet. (WebCore::Settings::Settings): Assign to m_page after calling initializeDefaultFontFamilies, so that we won't try to call page->setNeedsRecalcStyleInAllFrames() in a half-initialized Page that's creating settings. (WebCore::Settings::initializeDefaultFontFamilies): Dummy imlplementation for ports that rely on client to set defaults.
  • page/Settings.h: Added initializeDefaultFontFamilies().
  • page/mac/SettingsMac.mm: Added. (WebCore::defaultFontFamilyDictionary): (WebCore::Settings::initializeDefaultFontFamilies): Load defaults from a plist file inside WebCore framework.
13:05 Changeset [113899] by simonjam@chromium.org

[Chromium] Unreviewed gardening.

  • platform/chromium-linux/css2.1/20110323/replaced-elements-001-expected.png:
  • platform/chromium-linux/css2.1/20110323/replaced-elements-001-expected.txt:
  • platform/chromium-linux/fast/block/float/avoiding-float-centered-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/replaced-elements-001-expected.png:
  • platform/chromium-mac-snowleopard/fast/block/float/avoiding-float-centered-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/replaced-elements-001-expected.png:
  • platform/chromium-mac/fast/block/float/avoiding-float-centered-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/replaced-elements-001-expected.png:
  • platform/chromium-win/css2.1/20110323/replaced-elements-001-expected.txt:
  • platform/chromium-win/fast/block/float/avoiding-float-centered-expected.png: Added.
  • platform/chromium-win/fast/block/float/avoiding-float-centered-expected.txt: Added.
  • platform/chromium-win/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt:
  • platform/chromium/test_expectations.txt:
13:03 Changeset [113898] by antti@apple.com

Crash in CSSStyleSheet::deleteRule
https://bugs.webkit.org/show_bug.cgi?id=83708

Source/WebCore:

Reviewed by Andreas Kling.

Andreas spotted that the wrapper needs to be null checked before calling setParentStyleSheet(0).

Test: fast/css/delete-rule-crash.html

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::deleteRule):

LayoutTests:

Reviewed by Andreas Kling.

  • fast/css/delete-rule-crash.html: Added.
  • fast/css/delete-rule-crash-expected.txt: Added.
13:00 Changeset [113897] by adamk@chromium.org

[MutationObservers] Setting an attributeFilter should filter out all namespaced attribute mutations
https://bugs.webkit.org/show_bug.cgi?id=83706

Reviewed by Ryosuke Niwa.

Source/WebCore:

The patch amounts to plumbing QualifiedName all the way down to shouldReceiveMutationFrom
as it now needs to know about namespaceURI as well as localName.

This change is coming soon to the DOM4 spec, see
https://www.w3.org/Bugs/Public/show_bug.cgi?id=16563 for more discussion.

  • dom/MutationObserverInterestGroup.cpp:

(WebCore::MutationObserverInterestGroup::createIfNeeded):

  • dom/MutationObserverInterestGroup.h:

(WebCore::MutationObserverInterestGroup::createForChildListMutation):
(WebCore::MutationObserverInterestGroup::createForCharacterDataMutation):
(WebCore::MutationObserverInterestGroup::createForAttributesMutation):
(MutationObserverInterestGroup):

  • dom/MutationObserverRegistration.cpp:

(WebCore::MutationObserverRegistration::shouldReceiveMutationFrom):

  • dom/MutationObserverRegistration.h:

(WebCore):
(MutationObserverRegistration):

  • dom/Node.cpp:

(WebCore::Node::collectMatchingObserversForMutation):
(WebCore::Node::getRegisteredMutationObserversOfType):

  • dom/Node.h:

(Node):

LayoutTests:

Updated attributes test to match new behavior.

  • fast/mutation/observe-attributes-expected.txt:
  • fast/mutation/observe-attributes.html:
13:00 Changeset [113896] by lforschler@apple.com

New Branch.

12:52 Changeset [113895] by rafael.lobo@openbossa.org

Adding myself to committers.py
https://bugs.webkit.org/show_bug.cgi?id=83711

Unreviewed update to committers.py.

  • Scripts/webkitpy/common/config/committers.py:
12:51 Changeset [113894] by andersca@apple.com

Add two more DOM storage tests to the Skipped list.

  • platform/mac/Skipped:
12:45 Changeset [113893] by commit-queue@webkit.org

[EFL] LayoutTestController needs implementation of pageProperty
https://bugs.webkit.org/show_bug.cgi?id=82449

Source/WebKit/efl:

Add missing implementation pageProperty to EFL's
DumpRenderTreeSupport.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-11
Reviewed by Antonio Gomes.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::pageProperty):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Add missing implementation pageProperty to EFL's LayoutTestController
in order to unskip printing/page-rule-selection.html

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-11
Reviewed by Antonio Gomes.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::pageProperty):

LayoutTests:

Unskip printing/page-rule-selection.html

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-11
Reviewed by Antonio Gomes.

  • platform/efl/Skipped:
12:40 Changeset [113892] by andersca@apple.com

Move fast/js/navigator-language.html to platform/qt
https://bugs.webkit.org/show_bug.cgi?id=83710

Reviewed by Ryosuke Niwa.

This test was for a Qt specific bug, and using setlocale on Mac will not update the preferred language correctly.

  • platform/qt/fast/js/navigator-language-expected.txt: Renamed from LayoutTests/fast/js/navigator-language-expected.txt.
  • platform/qt/fast/js/navigator-language.html: Renamed from LayoutTests/fast/js/navigator-language.html.
12:39 Changeset [113891] by schenney@chromium.org

[Chromium/Linux] fonts-glyph-04-t.svg fails after r87152
https://bugs.webkit.org/show_bug.cgi?id=61370

Unreviewed Chromium linux expectations update.

This test is now behaving like Mac. No complaints there, just a font change.

  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.png:
  • platform/chromium/test_expectations.txt:
12:33 Changeset [113890] by schenney@chromium.org

[chromium] svg/wicd/test-rightsizing-a.xhtml is flaky
https://bugs.webkit.org/show_bug.cgi?id=66320

Unreviewed Chromium test expectations cleanup.

This test had been fixed some time ago and has no appearance in the flakiness board.

  • platform/chromium/test_expectations.txt:
12:26 Changeset [113889] by commit-queue@webkit.org

add stereo source support in EqualPowerPanner
https://bugs.webkit.org/show_bug.cgi?id=81092

Patch by Wei James <james.wei@intel.com> on 2012-04-11
Reviewed by Chris Rogers.

Source/WebCore:

Test: webaudio/panner-equalpower-stereo.html

  • platform/audio/EqualPowerPanner.cpp:

(WebCore::EqualPowerPanner::pan):

LayoutTests:

  • webaudio/panner-equalpower-stereo-expected.txt: Added.
  • webaudio/panner-equalpower-stereo.html: Copied from LayoutTests/webaudio/panner-equalpower.html.
  • webaudio/panner-equalpower.html:
  • webaudio/resources/audio-testing.js:

(createStereoImpulseBuffer):

  • webaudio/resources/panner-model-testing.js:

(createGraph):
(createTestAndRun):
(equalPowerGain):
(checkResult):

12:23 Changeset [113888] by schenney@chromium.org

[chromium] Need new image baseline for svg/dom/SVGTransformList-basics.xhtml
https://bugs.webkit.org/show_bug.cgi?id=63036

Unreviewed Chromium test expectations update.

  • platform/chromium-mac-leopard/svg/dom/SVGTransformList-basics-expected.png:
  • platform/chromium-mac-snowleopard/svg/dom/SVGTransformList-basics-expected.png:
  • platform/chromium-mac/svg/dom/SVGTransformList-basics-expected.png: Added.
  • platform/chromium/test_expectations.txt:
12:21 Changeset [113887] by arv@chromium.org

StyleElement ownerNode is not cleared correctly
https://bugs.webkit.org/show_bug.cgi?id=83696

Reviewed by Antti Koivisto.

Source/WebCore:

When the css text changes in such a way that we remove the sheet of a style element or a link[rel=stylesheet]
element we need to ensure that the ownerNode of the sheet is cleared. If we don't do this and there is a
wrapper for the sheet the sheet is kept alive but the ownerNode of the sheet may point to a deleted node.

Tests: fast/dom/StyleSheet/detached-sheet-owner-node-link.html

fast/dom/StyleSheet/detached-sheet-owner-node.html

  • dom/StyleElement.cpp:

(WebCore::StyleElement::removedFromDocument):
(WebCore::StyleElement::clearSheet):
(WebCore):
(WebCore::StyleElement::createSheet):

  • dom/StyleElement.h:

(StyleElement):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::clearSheet):
(WebCore):

  • html/HTMLLinkElement.h:

(HTMLLinkElement):

LayoutTests:

  • fast/dom/StyleSheet/detached-sheet-owner-node-expected.txt: Added.
  • fast/dom/StyleSheet/detached-sheet-owner-node-link-expected.txt: Added.
  • fast/dom/StyleSheet/detached-sheet-owner-node-link.html: Added.
  • fast/dom/StyleSheet/detached-sheet-owner-node.html: Added.
12:09 Changeset [113886] by benjamin@webkit.org

Optimize String.split() for 1 character separator
https://bugs.webkit.org/show_bug.cgi?id=83546

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-11
Reviewed by Gavin Barraclough.

This patch adds a serie of optimizations to make stringProtoFuncSplit() faster in the common case
where the separator is a single character.

The two main gains are:
-Use of the find() function with a single character instead of doing a full string matching.
-Use of WTF::find() instead of UString::find() to avoid branching on is8Bit() and have a simpler inline

function.

The code is also changed to avoid making unnecessary allocations by converting the 8bit string to 16bits.

This makes String.split() faster by about 13% in that particular case.

  • runtime/StringPrototype.cpp:

(JSC):
(JSC::splitStringByOneCharacterImpl):
(JSC::stringProtoFuncSplit):

11:35 Changeset [113885] by hyatt@apple.com

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=83614
<rdar://problem/11177351>

REGRESSION: Table on wikipedia overlaps float on right hand side.

Revise how auto margins are resolved so that for objects that avoid floats, the available line
width is always used instead of the overall containing block width. computeLogicalWidth now
always properly computes inline margins (based off the object's current logicalTop() position)
and so the code in computeStartPositionDeltaForChildAvoidingFloats that recomputes inline
direction margins can now be removed.

Reviewed by Dan Bernstein.

Added new test in fast/block/float.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats):
(WebCore::RenderBlock::determineLogicalLeftPositionForChild):

  • rendering/RenderBlock.h:

(RenderBlock):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::containingBlockAvailableLineWidthInRegion):
(WebCore):
(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::renderBoxRegionInfo):
(WebCore::RenderBox::shrinkToAvoidFloats):

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=83614

Improve how auto margins are handled on objects that avoid floats. Add a new test covering this
for tables and overflow sections and revise existing results. The CSS2.1 test in particular is
a progression.

Reviewed by Dan Bernstein.

  • fast/block/float/avoiding-float-centered.html: Added.
  • platform/mac/css2.1/20110323/replaced-elements-001-expected.txt:
  • platform/mac/fast/block/float/avoiding-float-centered-expected.png: Added.
  • platform/mac/fast/block/float/avoiding-float-centered-expected.txt: Added.
  • platform/mac/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt:
11:30 Changeset [113884] by tomz@codeaurora.org

Unreviewed gardening. Found EFL results.

  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-color-border-box-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-002-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-002-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-003-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-004-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/color-behind-images-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/order-of-images-actual.txt: Added.
  • platform/efl/ietestcenter/css3/text/textshadow-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/text/textshadow-002-actual.txt: Added.
  • platform/efl/ietestcenter/css3/text/textshadow-003-actual.txt: Added.
  • platform/efl/ietestcenter/css3/text/textshadow-004-actual.txt: Added.
  • platform/efl/ietestcenter/css3/text/textshadow-005-actual.txt: Added.
  • platform/efl/ietestcenter/css3/text/textshadow-006-actual.txt: Added.
  • platform/efl/ietestcenter/css3/text/textshadow-007-actual.txt: Added.
  • platform/efl/ietestcenter/css3/text/textshadow-008-actual.txt: Added.
  • platform/efl/ietestcenter/css3/text/textshadow-009-actual.txt: Added.
  • platform/efl/ietestcenter/css3/text/textshadow-010-actual.txt: Added.
  • platform/efl/test_expectations.txt:
11:20 Changeset [113883] by enne@google.com

Fix regression where a clip style change did not update layer sizes
https://bugs.webkit.org/show_bug.cgi?id=82990

Reviewed by Simon Fraser.

Source/WebCore:

After r111456, the size of composited layers also used clip, whereas
it previously had only used overflow. Because of this, when clip
changes on a render layer, it needs to recalculate its layer tree.

Test: compositing/clip-change.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::styleChanged):

LayoutTests:

  • compositing/clip-change-expected.png: Added.
  • compositing/clip-change-expected.txt: Added.
  • compositing/clip-change.html: Added.
11:19 April 2012 Meeting edited by jchaffraix@webkit.org
Added a topic + myself to some existing proposals (diff)
11:03 Changeset [113882] by tomz@codeaurora.org

Expectations update after 81936 and 82734
https://bugs.webkit.org/show_bug.cgi?id=81936

Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-04-11
Reviewed by Adam Barth.

  • platform/mac/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.txt: Added.
  • platform/mac/ietestcenter/css3/text/textshadow-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/text/textshadow-002-expected.txt: Added.
  • platform/mac/ietestcenter/css3/text/textshadow-003-expected.txt: Added.
  • platform/mac/ietestcenter/css3/text/textshadow-004-expected.txt: Added.
  • platform/mac/ietestcenter/css3/text/textshadow-005-expected.txt: Added.
  • platform/mac/ietestcenter/css3/text/textshadow-006-expected.txt: Added.
  • platform/mac/ietestcenter/css3/text/textshadow-007-expected.txt: Added.
  • platform/mac/ietestcenter/css3/text/textshadow-008-expected.txt: Added.
  • platform/mac/ietestcenter/css3/text/textshadow-009-expected.txt: Added.
  • platform/mac/ietestcenter/css3/text/textshadow-010-expected.txt: Added.
  • platform/mac/test_expectations.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.txt: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-002-expected.txt: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-003-expected.txt: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-004-expected.txt: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-005-expected.txt: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-006-expected.txt: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-007-expected.txt: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-008-expected.txt: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-009-expected.txt: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-010-expected.txt: Added.
  • platform/qt/test_expectations.txt:
11:02 Changeset [113881] by antti@apple.com

V8 bindings are polluting WebCore namespace with overly generic FooInternal namespaces
https://bugs.webkit.org/show_bug.cgi?id=83699

Reviewed by Adam Barth.

Call them FooV8Internal instead.

  • bindings/scripts/CodeGeneratorV8.pm:

(GetFunctionTemplateCallbackName):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):

10:58 Changeset [113880] by jamesr@google.com

[chromium] Add OVERRIDE annotations for cc animation-related interfaces
https://bugs.webkit.org/show_bug.cgi?id=83650

Reviewed by Daniel Bates.

This adds OVERRIDE annotations to the implementations of the following interfaces:

  • CCAnimationCurve
  • CCFloatAnimationCurve
  • CCLayerAnimationControllerClient
  • CCTransformAnimationCurve

Source/WebCore:

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/cc/CCTimingFunction.h:
  • platform/graphics/chromium/cc/CCKeyframedAnimationCurve.h:

(CCKeyframedFloatAnimationCurve):
(CCKeyframedTransformAnimationCurve):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

Source/WebKit/chromium:

  • tests/CCAnimationTestCommon.h:
10:50 Changeset [113879] by pdr@google.com

Fix bug where stroke's bounding box was clipped
https://bugs.webkit.org/show_bug.cgi?id=83651

Reviewed by Dirk Schulze.

Source/WebCore:

This change contains two fixes for one bug:
1) FloatRect::contains contained a nasty mistake where

maxy() < y() was compared instead of maxy() < point.y().

2) RenderSVGShape::strokeContains was depending on its internal

m_strokeAndMarkerBoundingBox instead of calling the virtual
method strokeBoundingBox(). This change switches to using
strokeBoundingBox().

Test: svg/hittest/svg-ellipse-rect-stroke.xhtml

  • platform/graphics/FloatRect.cpp:

(WebCore::FloatRect::contains):

  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::strokeContains):

LayoutTests:

  • svg/hittest/svg-ellipse-rect-stroke-expected.txt: Added.
  • svg/hittest/svg-ellipse-rect-stroke.xhtml: Added.
10:45 Changeset [113878] by haraken@chromium.org

Enable the [Supplemental] IDL on BlackBerry
https://bugs.webkit.org/show_bug.cgi?id=75413

Reviewed by Rob Buis.

This patch enables the [Supplemental] IDL on BlackBerry by changing the build
flow of BlackBerry as follows.

  • Previous build flow:

foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl;
generate-bindings.pl reads $idl;
generate-bindings.pl generates .h and .cpp files for $idl;

}

  • New build flow (See the discussions in bug 72138 for more details):

preprocess-idls.pl depends on all IDL files;
preprocess-idls.pl reads all IDL files;
preprocess-idls.pl resolves the dependency of [Supplemental=XXXX];
preprocess-idls.pl outputs supplemental_dependency.tmp;
foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
generate-bindings.pl reads $idl;
generate-bindings.pl reads supplemental_dependency.tmp;
generate-bindings.pl generates .h and .cpp files for $idl,

including all attributes in the IDL files that are implementing $idl;

}

Tests: Confirm that build succeeds.

http/tests/websocket/tests/*

  • PlatformBlackBerry.cmake: This change is similar to the change we have done for

UseJSC.cmake and UseV8.cmake (bug 75345).

10:44 Changeset [113877] by commit-queue@webkit.org

Unreviewed, rolling out r113836.
http://trac.webkit.org/changeset/113836
https://bugs.webkit.org/show_bug.cgi?id=83705

Broke all the WebKit2 inspector tests (Requested by andersca
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-11

Source/WebKit/win:

  • WebCoreSupport/WebInspectorClient.cpp:

(registerWindowClass):

(WebInspector::setTimelineProfilingEnabled):

  • WebNodeHighlight.cpp:

(WebNodeHighlight::WebNodeHighlight):
(WebNodeHighlight::update):

  • WebNodeHighlight.h:

(WebNodeHighlight):

  • WebView.cpp:

(WebView::WebView):
(WebView::close):
(WebView::initWithFrame):
(WebView::inspector):

  • WebView.h:

(WebView):

Tools:

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::showWebInspector):
(WTR::LayoutTestController::closeWebInspector):
(WTR::LayoutTestController::evaluateInWebInspector):
(WTR::LayoutTestController::setJavaScriptProfilingEnabled):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(LayoutTestController):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::invoke):

10:36 Changeset [113876] by commit-queue@webkit.org

Unreviewed, rolling out r113872.
http://trac.webkit.org/changeset/113872
https://bugs.webkit.org/show_bug.cgi?id=83703

broke chromium win/mac builds (Requested by simonjam on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-11

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
(WebCore::CCHeadsUpDisplay::initializeFonts):
(WebCore::CCHeadsUpDisplay::onFrameBegin):
(WebCore::CCHeadsUpDisplay::drawHudContents):
(WebCore::CCHeadsUpDisplay::drawFPSCounter):
(WebCore::CCHeadsUpDisplay::drawFPSCounterText):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h:

(CCHeadsUpDisplay):

10:32 Changeset [113875] by commit-queue@webkit.org

Remove webkit prefix from Media Source runtime feature name.
https://bugs.webkit.org/show_bug.cgi?id=83633

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-04-11
Reviewed by Adam Barth.

Source/WebCore:

  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::mediaSourceEnabled):
(WebCore::RuntimeEnabledFeatures::setMediaSourceEnabled):

  • html/HTMLMediaElement.idl:

Source/WebKit/chromium:

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableMediaSource):
(WebKit::WebRuntimeFeatures::isMediaSourceEnabled):

10:05 Changeset [113874] by antonm@chromium.org

Wider suppression.

Unreviewed.

  • platform/chromium/test_expectations.txt:
09:59 Changeset [113873] by noam.rosenthal@nokia.com

Single ShareableBitmap revision blacks out WebView on Harmattan
https://bugs.webkit.org/show_bug.cgi?id=83631

When swizzling is not supported in the driver, we need to initialize the texture as RGBA,
and make sure that the manual swizzling only modifies the sub-image.

Rubber stamped by Kenneth Rohde Christiansen.

Covered by existing tests.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::swizzleBGRAToRGBA):
(WebCore::BitmapTextureGL::didReset):
(WebCore):
(WebCore::BitmapTextureGL::updateContents):

09:57 Changeset [113872] by commit-queue@webkit.org

[chromium] When rendering goes idle, do not count that time against frame rate
https://bugs.webkit.org/show_bug.cgi?id=73454

The FPS counter had a few issues with its reporting. The first
3 swapbuffers are non-blocking and create FPS rates that are
unrealistically high, throwing off the moving averages and
introducing false spikes into the FPS graph. There was also no
way to monitor the smoothness of the animation, or to focus in
on a particular animation or transition.

This patch updates the FPS counter code so that bad data points
are trimmed and not graphed; so that the graph itself is taller
and more legible; so that there is a clear boundary between 40FPS
and better; and to keep statistics on frame rate between
pauses in the activity in the UI so that you can trigger a
transition and read off the average and standard deviation for
that transition to judge it smooth enough or not.

Patch by Alex Nicolaou <anicolao@chromium.org> on 2012-04-11
Reviewed by James Robinson.

HUD is not testable in webkit.

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
(WebCore::CCHeadsUpDisplay::onFrameBegin):
(WebCore::CCHeadsUpDisplay::drawHudContents):
(WebCore::CCHeadsUpDisplay::drawFPSCounter):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
09:21 Changeset [113871] by enne@google.com

[chromium] Draw missing layer tile checkerboards as checkerboards
https://bugs.webkit.org/show_bug.cgi?id=83241

Reviewed by James Robinson.

Source/WebCore:

For non-Android platforms, draw missing tile checkerboards as actual
checkerboards. Use a shader to do this so that no texture uploads are
needed. This only happens on the non-composited content host to avoid
having unexpected (or transformed and aliased) checkerboards on other
content layers.

  • WebCore.gypi:
  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::setDrawCheckerboardForMissingTiles):
(WebCore::LayerChromium::drawCheckerboardForMissingTiles):
(LayerChromium):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawQuad):
(WebCore::LayerRendererChromium::drawCheckerboardQuad):
(WebCore):
(WebCore::LayerRendererChromium::checkerboardProgram):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

  • platform/graphics/chromium/ShaderChromium.cpp:

(WebCore::FragmentShaderCheckerboard::FragmentShaderCheckerboard):
(WebCore):
(WebCore::FragmentShaderCheckerboard::init):
(WebCore::FragmentShaderCheckerboard::getShaderString):

  • platform/graphics/chromium/ShaderChromium.h:

(FragmentShaderCheckerboard):
(WebCore::FragmentShaderCheckerboard::alphaLocation):
(WebCore::FragmentShaderCheckerboard::texTransformLocation):
(WebCore::FragmentShaderCheckerboard::frequencyLocation):
(WebCore):

  • platform/graphics/chromium/cc/CCCheckerboardDrawQuad.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCSolidColorLayerImpl.h.

(WebCore):
(WebCore::CCCheckerboardDrawQuad::create):
(WebCore::CCCheckerboardDrawQuad::CCCheckerboardDrawQuad):

  • platform/graphics/chromium/cc/CCCheckerboardDrawQuad.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCSolidColorLayerImpl.h.

(WebCore):
(CCCheckerboardDrawQuad):

  • platform/graphics/chromium/cc/CCDrawQuad.cpp:

(WebCore::CCDrawQuad::toCheckerboardDrawQuad):
(WebCore):

  • platform/graphics/chromium/cc/CCDrawQuad.h:

(WebCore):
(CCDrawQuad):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):
(WebCore::CCLayerImpl::setDrawCheckerboardForMissingTiles):
(WebCore::CCLayerImpl::drawCheckerboardForMissingTiles):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::appendQuadsForLayer):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(CCRenderPass):

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:

(CCScrollbarLayerImpl):

  • platform/graphics/chromium/cc/CCSolidColorLayerImpl.h:

(CCSolidColorLayerImpl):

  • platform/graphics/chromium/cc/CCTextureLayerImpl.h:

(CCTextureLayerImpl):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:

(CCTiledLayerImpl):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:

(CCVideoLayerImpl):

Source/WebKit/chromium:

Rename usedCheckerboard to hadMissingTile to avoid confusion. Update
tests to not expect SolidColor quads for checkerboards.

  • src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::NonCompositedContentHost):

  • tests/CCQuadCullerTest.cpp:

(WebCore::appendQuads):

  • tests/CCSolidColorLayerImplTest.cpp:

(CCLayerTestCommon::TEST):

  • tests/CCTiledLayerImplTest.cpp:

(CCLayerTestCommon::TEST):
(CCLayerTestCommon::getQuads):

  • tests/LayerChromiumTest.cpp:
09:14 Changeset [113870] by carlosgc@webkit.org

[GTK] Initial cookies API for WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=82441

Reviewed by Gustavo Noronha Silva.

  • GNUmakefile.am: Add new files to compilation.
  • UIProcess/API/gtk/WebKitCookieManager.cpp: Added.

(webkit_cookie_manager_init):
(webkitCookieManagerFinalize):
(webkit_cookie_manager_class_init):
(webkitCookieManagerCreate): Create a new WebKitCookieManager for
the given WKCookieManagerRef.
(webkit_cookie_manager_set_accept_policy): Set the cookie
acceptance policy.
(webkitCookieManagerGetAcceptPolicyCallback): Callback called by
the C API when the cookie acceptance policy has been received.
(webkit_cookie_manager_get_accept_policy): Asynchronously get the
cookie acceptance policy.
(webkit_cookie_manager_get_accept_policy_finish): Finish async
operation started by webkit_cookie_manager_get_accept_policy()
returning the cookie acceptance policy.
(webkitCookieManagerGetDomainsWithCookiesCallback): Callback
called by the C API when the list of hostnames with cookies has
been received.
(webkit_cookie_manager_get_domains_with_cookies): Asynchronously
get the list of domains with cookies.
(webkit_cookie_manager_get_domains_with_cookies_finish): Finish
async operation started by
webkit_cookie_manager_get_domains_with_cookies() returning the
list of domains.
(webkit_cookie_manager_delete_cookies_for_domain): Delete all
cookies for the given domain.
(webkit_cookie_manager_delete_all_cookies): Delete all cookies.

  • UIProcess/API/gtk/WebKitCookieManager.h: Added.
  • UIProcess/API/gtk/WebKitCookieManagerPrivate.h: Added.
  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkit_web_context_get_cookie_manager): Get the
WebKitCookieManager associated with the web context.

  • UIProcess/API/gtk/WebKitWebContext.h:
  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new chapter for

WebKitCookieManager.

  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
  • UIProcess/API/gtk/docs/webkit2gtk.types: Add

webkit_cookie_manager_get_type.

  • UIProcess/API/gtk/tests/GNUmakefile.am:
  • UIProcess/API/gtk/tests/TestCookieManager.cpp: Added.

(testCookieManagerAcceptPolicy):
(testCookieManagerDeleteCookies):
(serverCallback):
(beforeAll):
(afterAll):

  • UIProcess/API/gtk/webkit2.h: Include WebKitCookieManager.h.
09:09 Changeset [113869] by ossy@webkit.org

[Qt] Unreviewed gardening after r113738.

  • platform/qt/Skipped: Unskip a non-existing test.
  • platform/qt/fast/multicol/cell-shrinkback-expected.png: Added.
  • platform/qt/fast/multicol/cell-shrinkback-expected.txt: Added.
  • platform/qt/fast/multicol/table-vertical-align-expected.png:
  • platform/qt/fast/multicol/table-vertical-align-expected.txt:
09:05 Changeset [113868] by commit-queue@webkit.org

[BlackBerry] Update to the thread-safe GuardedPointer API
https://bugs.webkit.org/show_bug.cgi?id=83603

Patch by Joe Mason <jmason@rim.com> on 2012-04-11
Reviewed by Rob Buis.

Source/WebCore:

RIM PR: 134894
Make the destructors of all objects inheriting GuardedPointerBase protected or
private, and delete them using BlackBerry::Platform::deleteGuardedObject.
Access all GuardedPointers through GuardedPointerLocker. Use GuardedPointerDeleter
to delete LayerCompositingThread to avoid a deadlock.

No new tests, refactor.

Reviewed internally by Yong Li and George Staikos.

  • platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:

(WebCore::CookieDatabaseBackingStore::~CookieDatabaseBackingStore):

  • platform/blackberry/CookieManager.h:
  • platform/graphics/blackberry/LayerCompositingThread.cpp:
  • platform/graphics/blackberry/LayerCompositingThread.h:

(LayerCompositingThread):
(WTF::::deref):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):

Source/WebKit/blackberry:

RIM PR: 134984
Make the destructors of all objects inheriting GuardedPointerBase protected or
private, and delete them using BlackBerry::Platform::deleteGuardedObject.
Access all GuardedPointers through GuardedPointerLocker.

No new tests, refactor.

Reviewed internally by Yong Li and George Staikos.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStore::~BackingStore):

  • Api/BackingStore_p.h:

(BackingStorePrivate):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::~WebPage):
(BlackBerry::WebKit::WebPage::destroy):

  • Api/WebPage.h:
  • Api/WebPage_p.h:

(WebPagePrivate):

09:03 Changeset [113867] by rakuco@webkit.org

[EFL][DRT] SVG dynamic-updates rebaseline
https://bugs.webkit.org/show_bug.cgi?id=83689

Unreviewed, EFL gardening.

Bug 83562 landed EFL fixes for SVG support from JavaScript.
This allows us to unskip the dynamic-updates/* family of SVG tests.
All results were visually inspected and produced PASS results.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-11

  • platform/efl/Skipped: dynamic-updates removed.
  • platform/efl/svg/dynamic-updates/: New baselines.
08:53 Changeset [113866] by abecsi@webkit.org

[Qt] Fix the build on OpenGL ES2 platforms

Unreviewed build fix.

No new tests needed.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::updateContents):
Fix typo in TEXMAP_OPENGL_ES_2 define.

08:49 Changeset [113865] by fischman@chromium.org

Remove unused WebVideoFrame::Format values
https://bugs.webkit.org/show_bug.cgi?id=83625

Reviewed by Kenneth Russell.

Source/WebCore:

Covered by existing tests.

  • platform/graphics/chromium/VideoFrameChromium.h:
  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::convertVFCFormatToGC3DFormat):

Source/WebKit/chromium:

  • public/WebVideoFrame.h:

(WebKit):

  • src/AssertMatchingEnums.cpp:
08:40 Changeset [113864] by pfeldman@chromium.org

Follow up to r113863: fix chromium inspector interactive test harness.

  • src/js/Tests.js:
08:29 Changeset [113863] by pfeldman@chromium.org

Source/WebCore: Web Inspector: extracting NetworkRequest from Resource (step 1)
https://bugs.webkit.org/show_bug.cgi?id=83684

Reviewed by Yury Semikhatsky.

Meta bug: https://bugs.webkit.org/show_bug.cgi?id=61363.
In this step, NetworkRequest is introduced. It temporarily inherits from
the Resource, but all the call sites are now referring to it as to request.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/ApplicationCacheItemsView.js:

(WebInspector.ApplicationCacheItemsView.prototype._updateCallback):

  • inspector/front-end/AuditLauncherView.js:

(WebInspector.AuditLauncherView):
(WebInspector.AuditLauncherView.prototype._onRequestStarted):
(WebInspector.AuditLauncherView.prototype._onRequestFinished):

  • inspector/front-end/AuditRules.js:

(WebInspector.AuditRules.getDomainToResourcesMap):
(WebInspector.AuditRules.GzipRule.prototype.doRun):
(WebInspector.AuditRules.GzipRule.prototype._isCompressed):
(WebInspector.AuditRules.GzipRule.prototype._shouldCompress):
(WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun):
(WebInspector.AuditRules.MinimizeDnsLookupsRule.prototype.doRun):
(WebInspector.AuditRules.ParallelizeDownloadRule.prototype.doRun):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
(WebInspector.AuditRules.CacheControlRule.prototype.doRun):
(WebInspector.AuditRules.CacheControlRule.prototype.handleNonCacheableResources):
(WebInspector.AuditRules.CacheControlRule.prototype._cacheableAndNonCacheableResources):
(WebInspector.AuditRules.CacheControlRule.prototype.execCheck):
(WebInspector.AuditRules.CacheControlRule.prototype.freshnessLifetimeGreaterThan):
(WebInspector.AuditRules.CacheControlRule.prototype.responseHeader):
(WebInspector.AuditRules.CacheControlRule.prototype.hasResponseHeader):
(WebInspector.AuditRules.CacheControlRule.prototype.isCompressible):
(WebInspector.AuditRules.CacheControlRule.prototype.isPubliclyCacheable):
(WebInspector.AuditRules.CacheControlRule.prototype.responseHeaderMatch):
(WebInspector.AuditRules.CacheControlRule.prototype.hasExplicitExpiration):
(WebInspector.AuditRules.CacheControlRule.prototype._isExplicitlyNonCacheable):
(WebInspector.AuditRules.CacheControlRule.prototype.isCacheableResource):
(WebInspector.AuditRules.BrowserCacheControlRule.prototype.handleNonCacheableResources):
(WebInspector.AuditRules.BrowserCacheControlRule.prototype.runChecks):
(WebInspector.AuditRules.BrowserCacheControlRule.prototype._missingExpirationCheck):
(WebInspector.AuditRules.BrowserCacheControlRule.prototype._varyCheck):
(WebInspector.AuditRules.BrowserCacheControlRule.prototype._oneMonthExpirationCheck):
(WebInspector.AuditRules.BrowserCacheControlRule.prototype._oneYearExpirationCheck):
(WebInspector.AuditRules.ProxyCacheControlRule.prototype.runChecks):
(WebInspector.AuditRules.ProxyCacheControlRule.prototype._questionMarkCheck):
(WebInspector.AuditRules.ProxyCacheControlRule.prototype._publicCachingCheck):
(WebInspector.AuditRules.ProxyCacheControlRule.prototype._setCookieCacheableCheck):
(WebInspector.AuditRules.CookieRuleBase.prototype.doRun.resultCallback):
(WebInspector.AuditRules.CookieRuleBase.prototype.doRun):
(WebInspector.AuditRules.CookieRuleBase.prototype.mapResourceCookies):
(WebInspector.AuditRules.CookieRuleBase.prototype._callbackForResourceCookiePairs):
(WebInspector.AuditRules.CookieSizeRule.prototype.processCookies):
(WebInspector.AuditRules.StaticCookielessRule.prototype.processCookies):
(WebInspector.AuditRules.StaticCookielessRule.prototype._collectorCallback):

  • inspector/front-end/AuditsPanel.js:

(WebInspector.AuditsPanel.prototype._executeAudit):
(WebInspector.AuditCategory.prototype.run):
(WebInspector.AuditRule.prototype.run):
(WebInspector.AuditRule.prototype.doRun):

  • inspector/front-end/ConsoleMessage.js:
  • inspector/front-end/ConsoleModel.js:

(WebInspector.ConsoleDispatcher.prototype.messageAdded):

  • inspector/front-end/ContentProviders.js:

(WebInspector.ResourceContentProvider):
(WebInspector.ResourceContentProvider.prototype.requestContent):
(WebInspector.ResourceContentProvider.prototype.searchInContent):

  • inspector/front-end/DebuggerPresentationModel.js:
  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onGetHAR):
(WebInspector.ExtensionServer.prototype._notifyRequestFinished):

  • inspector/front-end/HAREntry.js:

(WebInspector.HAREntry):
(WebInspector.HAREntry.prototype.build):
(WebInspector.HAREntry.prototype._buildRequest):
(WebInspector.HAREntry.prototype._buildResponse):
(WebInspector.HAREntry.prototype._buildContent):
(WebInspector.HAREntry.prototype._buildTimings):
(WebInspector.HAREntry.prototype._buildPostData):
(WebInspector.HAREntry.prototype._buildCookie):
(WebInspector.HAREntry.prototype._interval):
(WebInspector.HAREntry.prototype.get requestBodySize):
(WebInspector.HAREntry.prototype.get responseBodySize):
(WebInspector.HAREntry.prototype.get responseCompression):
(WebInspector.HARLog):
(WebInspector.HARLog.prototype.build):
(WebInspector.HARLog.prototype._buildPages):
(WebInspector.HARLog.prototype._convertResource):

  • inspector/front-end/NetworkItemView.js:

(WebInspector.NetworkItemView):

  • inspector/front-end/NetworkLog.js:

(WebInspector.NetworkLog):
(WebInspector.NetworkLog.prototype.get requests):
(WebInspector.NetworkLog.prototype.pageLoadForRequest):
(WebInspector.NetworkLog.prototype._onMainFrameNavigated):
(WebInspector.NetworkLog.prototype._onRequestStarted):
(WebInspector.NetworkLog.prototype._onLoad):
(WebInspector.PageLoad):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkManager.get this):
(WebInspector.NetworkManager.get NetworkAgent):
(WebInspector.NetworkManager):
(WebInspector.NetworkManager.prototype.inflightRequestForURL):
(WebInspector.NetworkDispatcher):
(WebInspector.NetworkDispatcher.prototype._updateNetworkRequestWithRequest):
(WebInspector.NetworkDispatcher.prototype._updateNetworkRequestWithResponse):
(WebInspector.NetworkDispatcher.prototype._mimeTypeIsConsistentWithType):
(WebInspector.NetworkDispatcher.prototype._updateNetworkRequestWithCachedResource):
(WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
(WebInspector.NetworkDispatcher.prototype.requestServedFromCache):
(WebInspector.NetworkDispatcher.prototype.responseReceived):
(WebInspector.NetworkDispatcher.prototype.dataReceived):
(WebInspector.NetworkDispatcher.prototype.loadingFinished):
(WebInspector.NetworkDispatcher.prototype.loadingFailed):
(WebInspector.NetworkDispatcher.prototype.requestServedFromMemoryCache):
(WebInspector.NetworkDispatcher.prototype.webSocketCreated):
(WebInspector.NetworkDispatcher.prototype.webSocketWillSendHandshakeRequest):
(WebInspector.NetworkDispatcher.prototype.webSocketHandshakeResponseReceived):
(WebInspector.NetworkDispatcher.prototype.webSocketClosed):
(WebInspector.NetworkDispatcher.prototype._appendRedirect):
(WebInspector.NetworkDispatcher.prototype._startNetworkRequest):
(WebInspector.NetworkDispatcher.prototype._updateNetworkRequest):
(WebInspector.NetworkDispatcher.prototype._finishNetworkRequest):
(WebInspector.NetworkDispatcher.prototype._dispatchEventToListeners):
(WebInspector.NetworkDispatcher.prototype._createNetworkRequest):
(get WebInspector):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._initializeView):
(WebInspector.NetworkLogView.prototype.get statusBarItems):
(WebInspector.NetworkLogView.prototype._createSortingFunctions):
(WebInspector.NetworkLogView.prototype._updateSummaryBar):
(WebInspector.NetworkLogView.prototype._updateDividersIfNeeded):
(WebInspector.NetworkLogView.prototype._invalidateAllItems):
(WebInspector.NetworkLogView.prototype._requestGridNode):
(WebInspector.NetworkLogView.prototype._createRequestGridNode):
(WebInspector.NetworkLogView.prototype._onLoadEventFired):
(WebInspector.NetworkLogView.prototype._domContentLoadedEventFired):
(WebInspector.NetworkLogView.prototype.refresh):
(WebInspector.NetworkLogView.prototype._reset):
(WebInspector.NetworkLogView.prototype.get requests):
(WebInspector.NetworkLogView.prototype.requestById):
(WebInspector.NetworkLogView.prototype._onRequestStarted):
(WebInspector.NetworkLogView.prototype._appendRequest):
(WebInspector.NetworkLogView.prototype._onRequestUpdated):
(WebInspector.NetworkLogView.prototype._refreshRequest):
(WebInspector.NetworkLogView.prototype._mainFrameNavigated):
(WebInspector.NetworkLogView.prototype.get _setLargerRequests):
(WebInspector.NetworkLogView.prototype._getPopoverAnchor):
(WebInspector.NetworkLogView.prototype._showPopover):
(WebInspector.NetworkLogView.prototype._contextMenu):
(WebInspector.NetworkLogView.prototype._copyAll):
(WebInspector.NetworkLogView.prototype._copyRequest):
(WebInspector.NetworkLogView.prototype._copyLocation):
(WebInspector.NetworkLogView.prototype._copyRequestHeaders):
(WebInspector.NetworkLogView.prototype._copyResponseHeaders):
(WebInspector.NetworkLogView.prototype._exportAll):
(WebInspector.NetworkLogView.prototype._exportRequest):
(WebInspector.NetworkLogView.prototype._matchRequest):
(WebInspector.NetworkLogView.prototype._clearSearchMatchedList):
(WebInspector.NetworkLogView.prototype._updateSearchMatchedListAfterRequestIdChanged):
(WebInspector.NetworkLogView.prototype._updateHighlightIfMatched):
(WebInspector.NetworkLogView.prototype._highlightNthMatchedRequest):
(WebInspector.NetworkLogView.prototype.performSearch):
(WebInspector.NetworkLogView.prototype.jumpToPreviousSearchResult):
(WebInspector.NetworkLogView.prototype.jumpToNextSearchResult):
(WebInspector.NetworkLogView.prototype.revealAndHighlightRequest):
(WebInspector.NetworkPanel.prototype.handleShortcut):
(WebInspector.NetworkPanel.prototype.get requests):
(WebInspector.NetworkPanel.prototype.requestById):
(WebInspector.NetworkPanel.prototype._requestByAnchor):
(WebInspector.NetworkPanel.prototype.canShowAnchorLocation):
(WebInspector.NetworkPanel.prototype.showAnchorLocation):
(WebInspector.NetworkPanel.prototype.revealAndHighlightRequest):
(WebInspector.NetworkPanel.prototype._onViewCleared):
(WebInspector.NetworkPanel.prototype._onRequestSelected):
(WebInspector.NetworkPanel.prototype._showRequest):
(WebInspector.NetworkPanel.prototype._closeVisibleRequest):
(WebInspector.NetworkPanel.prototype._toggleGridMode):
(WebInspector.NetworkPanel.prototype._toggleViewingRequestMode):
(WebInspector.NetworkTimeCalculator.prototype.computeBarGraphPercentages):
(WebInspector.NetworkTimeCalculator.prototype.computeBarGraphLabels):
(WebInspector.NetworkTimeCalculator.prototype.updateBoundaries):
(WebInspector.NetworkTimeCalculator.prototype._lowerBound):
(WebInspector.NetworkTimeCalculator.prototype._upperBound):
(WebInspector.NetworkTransferTimeCalculator.prototype._lowerBound):
(WebInspector.NetworkTransferTimeCalculator.prototype._upperBound):
(WebInspector.NetworkTransferDurationCalculator.prototype._upperBound):
(WebInspector.NetworkDataGridNode):
(WebInspector.NetworkDataGridNode.prototype.isFilteredOut):
(WebInspector.NetworkDataGridNode.prototype.select):
(WebInspector.NetworkDataGridNode.prototype._openInNewTab):
(WebInspector.NetworkDataGridNode.prototype.get selectable):
(WebInspector.NetworkDataGridNode.prototype._createTimelineCell):
(WebInspector.NetworkDataGridNode.prototype.refreshRequest):
(WebInspector.NetworkDataGridNode.prototype._refreshNameCell):
(WebInspector.NetworkDataGridNode.prototype._fileName):
(WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):
(WebInspector.NetworkDataGridNode.prototype._refreshTypeCell):
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
(WebInspector.NetworkDataGridNode.prototype._refreshSizeCell):
(WebInspector.NetworkDataGridNode.prototype._refreshTimeCell):
(WebInspector.NetworkDataGridNode.prototype.refreshGraph):
(WebInspector.NetworkDataGridNode.NameComparator):
(WebInspector.NetworkDataGridNode.SizeComparator):
(WebInspector.NetworkDataGridNode.InitiatorComparator):
(WebInspector.NetworkDataGridNode.RequestPropertyComparator):

  • inspector/front-end/NetworkRequest.js: Added.

(WebInspector.NetworkRequest):

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype._requestFinished):
(WebInspector.RawSourceCode.prototype._createContentProvider):

  • inspector/front-end/Resource.js:

(WebInspector.Resource):
(WebInspector.Resource.displayName):
(WebInspector.Resource.prototype.get request):
(WebInspector.Resource.prototype.set finished):
(WebInspector.Resource.prototype.set timing):
(WebInspector.Resource.prototype.set requestHeaders):
(WebInspector.Resource.prototype.set requestHeadersText):
(WebInspector.Resource.prototype.set responseHeaders):
(WebInspector.Resource.prototype.set responseHeadersText):
(WebInspector.Resource.prototype.requestContent):

  • inspector/front-end/ResourceCookiesView.js:

(WebInspector.ResourceCookiesView):
(WebInspector.ResourceCookiesView.prototype.get _gotCookies):
(WebInspector.ResourceCookiesView.prototype._buildCookiesTable):

  • inspector/front-end/ResourceHeadersView.js:

(WebInspector.ResourceHeadersView):
(WebInspector.ResourceHeadersView.prototype._refreshURL):
(WebInspector.ResourceHeadersView.prototype._refreshQueryString):
(WebInspector.ResourceHeadersView.prototype._refreshUrlFragment):
(WebInspector.ResourceHeadersView.prototype._refreshFormData):
(WebInspector.ResourceHeadersView.prototype._refreshRequestHeaders):
(WebInspector.ResourceHeadersView.prototype._refreshResponseHeaders):
(WebInspector.ResourceHeadersView.prototype._refreshHTTPInformation):

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype.addScript):

  • inspector/front-end/ResourceTimingView.js:

(WebInspector.ResourceTimingView):
(WebInspector.ResourceTimingView.prototype.wasShown):
(WebInspector.ResourceTimingView.prototype._refresh):
(WebInspector.ResourceTimingView.createTimingTable):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel):
(WebInspector.ResourceTreeModel.prototype._frontendReused):
(WebInspector.ResourceTreeModel.prototype._onRequestUpdated):
(WebInspector.ResourceTreeModel.prototype._onRequestUpdateDropped):
(WebInspector.ResourceTreeModel.prototype._createResource):
(WebInspector.ResourceTreeFrame):
(WebInspector.ResourceTreeFrame.prototype._addRequest):

  • inspector/front-end/ResourceUtils.js:
  • inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameResourceTreeElement.prototype._appendOpenInNetworkPanelAction):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/externs.js:

(WebInspector.networkRequestById):

  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

(WebInspector.networkRequestById):
(WebInspector.openRequestInNetworkPanel):

Tools: Web Inspector: Disabling Inspector causes build failure on Windows
https://bugs.webkit.org/show_bug.cgi?id=83557

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-04-11
Reviewed by Pavel Feldman.

The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
This change brings all such API calls under the guard.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(LayoutTestController):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::invoke):

LayoutTests: Web Inspector: extracting NetworkRequest from Resource (step 1)
https://bugs.webkit.org/show_bug.cgi?id=83684

Reviewed by Yury Semikhatsky.

  • http/tests/inspector/network-preflight-options.html:
  • http/tests/inspector/network-test.js:
  • http/tests/inspector/network/async-xhr-json-mime-type.html:
  • http/tests/inspector/network/download.html:
  • http/tests/inspector/network/network-cachedresources-with-same-urls.html:
  • http/tests/inspector/network/network-content-replacement-embed.html:
  • http/tests/inspector/network/network-content-replacement-xhr.html:
  • http/tests/inspector/network/network-cyrillic-xhr.html:
  • http/tests/inspector/network/network-disable-cache-memory.html:
  • http/tests/inspector/network/network-disable-cache-xhrs.html:
  • http/tests/inspector/network/network-disabling-check-no-memory-leak.html:
  • http/tests/inspector/network/network-embed.html:
  • http/tests/inspector/network/network-empty-xhr.html:
  • http/tests/inspector/network/network-iframe-load-and-delete.html:
  • http/tests/inspector/network/network-initiator-from-console.html:
  • http/tests/inspector/network/network-initiator.html:
  • http/tests/inspector/network/network-request-revision-content.html:
  • http/tests/inspector/network/network-shared-worker.html:
  • http/tests/inspector/network/network-sidebar-width.html:
  • http/tests/inspector/network/network-size-chunked.html:
  • http/tests/inspector/network/network-size-sync.html:
  • http/tests/inspector/network/network-size.html:
  • http/tests/inspector/network/network-timing.html:
  • http/tests/inspector/network/network-worker.html:
  • http/tests/inspector/network/network-xhr-async.html:
  • http/tests/inspector/network/network-xhr-same-url-as-main-resource.html:
  • http/tests/inspector/network/network-xhr-sync.html:
  • http/tests/inspector/network/ping.html:
  • http/tests/inspector/network/x-frame-options-deny.html:
  • http/tests/inspector/resource-har-conversion.html:
  • http/tests/inspector/resource-har-headers.html:
  • http/tests/inspector/resource-har-pages.html:
  • http/tests/inspector/resource-parameters.html:
  • http/tests/inspector/resources-test.js:

(initialize_ResourceTest.InspectorTest.requestURLComparer):

  • inspector/debugger/raw-source-code.html:
  • inspector/debugger/source-frame.html:
  • inspector/network-status-non-http.html:
08:20 Changeset [113862] by arko@motorola.com

Microdata: Implement cache mechanism for HTMLPropertiesCollection.
https://bugs.webkit.org/show_bug.cgi?id=80490

Reviewed by Ryosuke Niwa.

Implemented caching mechanism for HTMLPropertiesCollection.
propertyCache - contains microdata item properties.
itemRefElements - contains sorted microdata item and itemref elements.
propertyNames - contains microdata property names of the elements in the collection.
itemRefElementPosition - store the current position of itemRefElements.
hasItemRefElements - set to ture once we have sorted microdata item and itemref elements list i.e, itemRefElements.
Cache is invalidated only when dom tree modified. Whenever any query is made on HTMLPropertiesCollection,
result is returned from the cache. Earliar we used to calculate properties node list every time a query is made.

  • html/HTMLPropertiesCollection.cpp:

(WebCore):
(WebCore::HTMLPropertiesCollection::HTMLPropertiesCollection):
(WebCore::HTMLPropertiesCollection::invalidateCacheIfNeeded):
(WebCore::HTMLPropertiesCollection::updateRefElements): Appends microdata item element and elements which
are added through itemref attribute in itemRefElements (in tree order).
(WebCore::nextNodeWithProperty):
(WebCore::HTMLPropertiesCollection::itemAfter): Takes parent base and previous item property as argument.
Finds the next item property in base.
(WebCore::HTMLPropertiesCollection::calcLength): Calculates the length of properties collection if length
is not available in the cache.
(WebCore::HTMLPropertiesCollection::length):
(WebCore::HTMLPropertiesCollection::firstProperty): Returns the first property in the collection.
(WebCore::HTMLPropertiesCollection::item):
(WebCore::HTMLPropertiesCollection::findProperties): Finds microdata item properties in the base element.
Appends the properties in propertyCache and property names in propertyNames.
(WebCore::HTMLPropertiesCollection::updateNameCache): It updates the propertyCache and propertyNames if hasNameCache is false.
(WebCore::HTMLPropertiesCollection::names):
(WebCore::HTMLPropertiesCollection::namedItem):
(WebCore::HTMLPropertiesCollection::hasNamedItem):

  • html/HTMLPropertiesCollection.h:

(HTMLPropertiesCollection):

07:53 Changeset [113861] by jocelyn.turcotte@nokia.com

[Qt] InspectorServer: Add an API level auto test
https://bugs.webkit.org/show_bug.cgi?id=83594

Reviewed by Kenneth Rohde Christiansen.

.:

  • Source/tests.pri:

Source/WebKit2:

This tests InspectorServer and WebSocketServer.

  • UIProcess/API/qt/tests/inspectorserver/inspectorserver.pro: Added.
  • UIProcess/API/qt/tests/inspectorserver/tst_inspectorserver.cpp: Added.

(tst_InspectorServer):
(tst_InspectorServer::tst_InspectorServer):
(tst_InspectorServer::prepareWebViewComponent):
(tst_InspectorServer::newWebView):
(tst_InspectorServer::init):
(tst_InspectorServer::cleanup):
(tst_InspectorServer::webView):
(tst_InspectorServer::fetchPageList):
(tst_InspectorServer::testPageList): This tests that pages with developerExtrasEnabled appear available for inspection.
(tst_InspectorServer::testRemoteDebuggingMessage): This tests a web socket connection using a raw inspector command.
(tst_InspectorServer::openRemoteDebuggingSession): This tests the whole pipeline by starting a remote inspection session.

  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView):
(tst_QQuickWebView::prepareWebViewComponent):

  • UIProcess/API/qt/tests/tests.pri:
  • UIProcess/API/qt/tests/util.cpp:

(LoadStartedCatcher::LoadStartedCatcher):
(LoadStartedCatcher::onLoadingChanged):

  • UIProcess/API/qt/tests/util.h:

(LoadStartedCatcher):

07:52 Changeset [113860] by jocelyn.turcotte@nokia.com

[Qt] InspectorServer: Improve the JSON page list's parameter names
https://bugs.webkit.org/show_bug.cgi?id=83592

Reviewed by Simon Hausmann.

  • Add "id" that would be needed to build the URL when using local front-end resources (and will be used by tests)
  • Rename description to "title", the description contains both the title and URL on the final list
  • Rename inspectorLocation to "inspectorUrl" to match with the url parameter.
  • UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp:

(WebKit::WebInspectorServer::buildPageList):

  • qt/Resources/inspectorPageIndex.html:
07:50 Changeset [113859] by jocelyn.turcotte@nokia.com

[Qt] Fix issues when using the WebView as ShaderEffectSource
https://bugs.webkit.org/show_bug.cgi?id=83587

Reviewed by Noam Rosenthal.

Source/WebCore:

  • Make sure that the bound frame buffer is preserved instead of binding to the default one
  • Accept a "mirrored" flag in beginPainting that we're applying on the projection matrix just as with internal FBOs

The "flip" logic in createProjectionMatrix has been reversed and renamed to
mirrored so that FBO rendering is considered the special case and not the
other way around just like within Qt.

  • platform/graphics/texmap/TextureMapper.h:

(WebCore::TextureMapper::beginPainting):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGLData::TextureMapperGLData):
(TextureMapperGLData):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::createProjectionMatrix):
(WebCore::BitmapTextureGL::bind):
(WebCore::TextureMapperGL::bindSurface):

  • platform/graphics/texmap/TextureMapperGL.h:

Source/WebKit2:

Qt is going to mirror the projection matrix when the shader effect source
is grabbed. Detect that the matrix is mirrored and pass on this information
to TextureMapper so that it can do the same.

  • UIProcess/WebLayerTreeRenderer.cpp:

(WebKit::WebLayerTreeRenderer::paintToCurrentGLContext):

  • UIProcess/WebLayerTreeRenderer.h:

(WebLayerTreeRenderer):

  • UIProcess/qt/QtWebPageSGNode.cpp:

(WebKit::ContentsSGNode::render):

07:49 Changeset [113858] by jocelyn.turcotte@nokia.com

[Qt] Remove unnecessary rendering code
https://bugs.webkit.org/show_bug.cgi?id=83591

Reviewed by Noam Rosenthal.

  • Remove code that isn't needed since the introduction of WebLayerTreeRenderer
  • Remove TextureMapper::bindSurface(0) calls following beginPainting, which calls it itself.
  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPagePrivate::paint):

  • UIProcess/API/qt/qquickwebpage_p_p.h:

(QQuickWebPagePrivate):

  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxyImpl.cpp:
  • UIProcess/DrawingAreaProxyImpl.h:

(DrawingAreaProxyImpl):

  • UIProcess/LayerTreeHostProxy.cpp:
  • UIProcess/LayerTreeHostProxy.h:

(LayerTreeHostProxy):

  • UIProcess/WebLayerTreeRenderer.cpp:

(WebKit::WebLayerTreeRenderer::paintToCurrentGLContext):
(WebKit::WebLayerTreeRenderer::paintToGraphicsContext):

07:00 Changeset [113857] by schenney@chromium.org

svg/text/svg-zoom-large-value.xhtml ASSERTs on Chromium Linux Debug
https://bugs.webkit.org/show_bug.cgi?id=63400

Unreviewed Chromium test expectation removal.

  • platform/chromium/test_expectations.txt:
06:41 Changeset [113856] by schenney@chromium.org

Shadow tree TreeScope data is not removed by ContainerNode::removeAllChildren
https://bugs.webkit.org/show_bug.cgi?id=83484

Unreviewed attempted build fix.

  • dom/ContainerNodeAlgorithms.h: Adding Document.h include.
06:31 Changeset [113855] by ossy@webkit.org

[Qt] Skip a new test because of missing layoutTestController.setBackingScaleFactor() implemetation.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-04-11
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
06:29 Changeset [113854] by macpherson@chromium.org

Remove unnecessary assignments from CSSParser::parseLinearGradient().
https://bugs.webkit.org/show_bug.cgi?id=83661

Reviewed by Kentaro Hara.

No new tests / code cleanup only.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseLinearGradient):

06:23 Changeset [113853] by noam.rosenthal@nokia.com

[Qt][WK2] Manage graphics buffers in the web process
https://bugs.webkit.org/show_bug.cgi?id=78675

Make graphics surface available only for Qt 5, attempting to fix
the Qt-mac build.

Unreviewed build fix.

  • qmake/mkspecs/features/features.prf:
06:18 Changeset [113852] by schenney@chromium.org

Shadow tree TreeScope data is not removed by ContainerNode::removeAllChildren
https://bugs.webkit.org/show_bug.cgi?id=83484

Reviewed by Hajime Morita.

The ContainerNode::removeAllChildren method does fast and dirty node removal.
As compared to ContainerNode::removeChildren, it does not include the
method to adopt the removed child node into the root document's TreeScope.
Rather, it leaves the existing TreeScope in place. However, the existing
TreeScope may be removed, causing a crash when something prevents the child
node from being deleted immediately. The fix is to modify the code in
ContainerNodeAlgorithms to do the TreeScope adoption.

Could not reproduce crash in layout test.

  • dom/ContainerNodeAlgorithms.h:

(Private):
(WebCore::Private::NodeRemovalDispatcher::dispatch):
(WebCore::Private::addChildNodesToDeletionQueue):

05:52 Changeset [113851] by yurys@chromium.org

Web Inspector: showing summary view is very slow on a snapshot with thousands of constructors
https://bugs.webkit.org/show_bug.cgi?id=83682

Node content is created only when the node becomes visible in the corresponding view.
This saves a lot of time when openning summary/comparison view of a snapshot
with lots of different classes.

Reviewed by Pavel Feldman.

  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotGridNode.prototype.ensureContentCreated):
(WebInspector.HeapSnapshotLazyGridNode):
(WebInspector.HeapSnapshotLazyGridNode.prototype.ensureContentCreated):
(WebInspector.HeapSnapshotLazyGridNode.prototype.createCells):
(WebInspector.HeapSnapshotConstructorNode):
(WebInspector.HeapSnapshotDiffNode):

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.HeapSnapshotSortableDataGrid):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.updateVisibleNodes):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.onResize):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._onScroll):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):
(WebInspector.HeapSnapshotConstructorsDataGrid):
(WebInspector.HeapSnapshotDiffDataGrid):
(WebInspector.DetailedHeapshotView.prototype._changeNameFilter):

  • inspector/front-end/heapProfiler.css:

(.detailed-heapshot-view .data-grid tr:empty):

05:24 WebKitGtkLayoutTests edited by philn@webkit.org
(diff)
05:24 Changeset [113850] by philn@webkit.org

Unreviewed, GTK NRWT follow-up fix after r113849.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort._unload_pulseaudio_module): Exit early if pactl is not found.

04:57 Changeset [113849] by commit-queue@webkit.org

[GTK] media/event-attributes.html fails
https://bugs.webkit.org/show_bug.cgi?id=71662

Patch by Simon Pena <spena@igalia.com> on 2012-04-11
Reviewed by Philippe Normand.

Source/WebCore:

In MediaPlayerPrivateGStreamer::didEnd, when EOS is reached, don't
synchronize position and duration on regular playback. That is:
synchronize it (and fire the durationChange signal) only on reverse
playback.

This change makes media/event-attributes.html pass. It was
previously failing because an additional durationChange signal was
emitted.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: Avoid

sending durationChange signal on regular playback.

Tools:

PulseAudio's module "module-stream-restore" allows saving the volume
of a stream, restoring it the next time it runs.
This affects the tests, since DumpRenderTree's volume settings are
saved between test runs, and tests relying on specific volume values
would miss some volumeChange events (or get additional ones).

This patch hooks on the existing GtkPort setup_test_run method and
creates a new clean_up_test_run method, so PulseAudio's module is
unloaded (if found) before running the tests, and restored (if it
was there previously) after they finished, ensuring the tests run in
the right environment.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._clean_up_run): Invoke the port implementation of
clean_up_test_run.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.clean_up_test_run): Add an empty implementation of
clean_up_test_run.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort._unload_pulseaudio_module): Unloads the offending
pulseaudio module, if found.
(GtkPort):
(GtkPort._restore_pulseaudio_module): Restores the offending
pulseaudio module, if it was there previously.
(GtkPort.setup_test_run): Calls _unload_pulseaudio_module.
(GtkPort.clean_up_test_run): Calls _restore_pulseaudio_module.

LayoutTests:

Unskip tests media/video-seek-past-end-playing and
media/sources-fallback-codecs, which no longer fail, and
media/event-attributes, which is fixed with this patch.

  • platform/gtk/Skipped: Unskip media/video-seek-past-end-playing,

media/sources-fallback-codecs and media/event-attributes

04:23 Changeset [113848] by abecsi@webkit.org

Fix the build with gcc 4.7.0
https://bugs.webkit.org/show_bug.cgi?id=83584

Reviewed by Alexey Proskuryakov.

Source/WebCore:

No new tests needed.

  • Target.pri: Disable Werror on the ANGLE code since it has several recurring issues

because older versions of flex (<2.5.35) and bison (<2.5) generate code which
triggers warnings. This generated code is committed on each version update of ANGLE,
and it is very likely that the code is generated with older versions of the mentioned
tools.

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::createForJSConstructor): Fails because of -Werror=extra

  • platform/graphics/TiledBackingStoreClient.h: Fails because -Werror=delete-non-virtual-dtor,

gcc requires classes which have virtual methods to have a virtual destructor, if their instances
or the instances of their subclasses are deleted.
(WebCore::TiledBackingStoreClient::~TiledBackingStoreClient):

  • platform/graphics/texmap/TextureMapperPlatformLayer.h: Ditto.

(WebCore::TextureMapperPlatformLayer::~TextureMapperPlatformLayer):

Tools:

  • qmake/mkspecs/features/unix/default_post.prf:

The -fuse-ld=gold option is not supported with upstream gcc.

03:50 Changeset [113847] by philn@webkit.org

Unreviewed, GTK gardening.

  • platform/gtk/test_expectations.txt: Mark two a11y tests as flaky.
03:06 Changeset [113846] by tkent@chromium.org

[V8] Calendar Picker: Add a helper function to expose PagePopupClient::setValueAndClosePopup() to JavaScript
https://bugs.webkit.org/show_bug.cgi?id=83561

Reviewed by Adam Barth.

Add ScriptController::installFunctionsForPagePopup(), which add
window.setValueAndClosePopup() for JavaScript code in PagePopup
environment, and the function calls
WebCore::PagePopupClient::setValueAndClosePopup().

This patch introduces Supplement<DOMWindow> object to hold a
PagePopupClient object. It makes keeping a PagePopupClient easier.

  • WebCore.gypi: Add DOMWindowPagePopup.{cpp,h}
  • bindings/v8/ScriptController.cpp:

(WebCore::setValueAndClosePopupCallback):
(WebCore::ScriptController::installFunctionsForPagePopup):

  • bindings/v8/ScriptController.h:

(ScriptController): Add installFunctionsForPagePopup().

  • page/DOMWindowPagePopup.cpp: Added.

(WebCore::DOMWindowPagePopup::DOMWindowPagePopup):
(WebCore::DOMWindowPagePopup::supplementName):
Returns "DOMWindowPagePopup" as a key of this Supplement<DOMWindow>.
(WebCore::DOMWindowPagePopup::setValueAndClosePopup):
Gets a DOMWindowPagePopup from the window, then calls PagePopupClient::setValueAndClosePopup().
(WebCore::DOMWindowPagePopup::install):
On-demand creation of DOMWindowPagePopup doesn't work because it
must have a PagePopupClient object. We need to install
DOMWindowPagePopup explicitly.

  • page/DOMWindowPagePopup.h: Added.
03:00 Changeset [113845] by commit-queue@webkit.org

[chromium] Add Battery Status API support.

Source/WebCore:

Add Battery Status API support to chromium.
https://bugs.webkit.org/show_bug.cgi?id=83284

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-04-11
Reviewed by Adam Barth.

This change is covered by tests in batterystatus/.

  • Modules/battery/BatteryController.cpp:

(WebCore::BatteryController::updateBatteryStatus):
(WebCore):

  • Modules/battery/BatteryController.h:

(BatteryController):

  • Modules/battery/BatteryManager.cpp:

(WebCore::BatteryManager::charging):
(WebCore::BatteryManager::chargingTime):
(WebCore::BatteryManager::dischargingTime):
(WebCore::BatteryManager::level):

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:

Source/WebKit/chromium:

The battery-client (BatteryClientChromium) will notify the client (WebBatteryStatusClient) when to start or stop
sending battery status updates. The client, in response will send the notifications to WebViewImpl, which sends
this update information to the WebCore::BatteryClient, and it triggers the appropriate javascript-callbacks.
The spec is at http://www.w3.org/TR/2011/WD-battery-status-20111129/.
https://bugs.webkit.org/show_bug.cgi?id=83284

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-04-11
Reviewed by Adam Barth.

  • WebKit.gyp:
  • features.gypi:
  • public/WebBatteryStatus.h: Added.

(WebKit):
(WebBatteryStatus):
(WebKit::WebBatteryStatus::WebBatteryStatus):

  • public/WebBatteryStatusClient.h: Added.

(WebKit):
(WebBatteryStatusClient):
(WebKit::WebBatteryStatusClient::~WebBatteryStatusClient):

  • public/WebView.h:

(WebKit):
(WebView):
(WebKit::WebView::updateBatteryStatus):

  • public/WebViewClient.h:

(WebKit):
(WebViewClient):
(WebKit::WebViewClient::batteryStatusClient):

  • src/BatteryClientImpl.cpp: Added.

(WebKit):
(WebKit::BatteryClientImpl::BatteryClientImpl):
(WebKit::BatteryClientImpl::updateBatteryStatus):
(WebKit::BatteryClientImpl::setController):
(WebKit::BatteryClientImpl::startUpdating):
(WebKit::BatteryClientImpl::stopUpdating):
(WebKit::BatteryClientImpl::batteryControllerDestroyed):

  • src/BatteryClientImpl.h: Added.

(WebKit):
(BatteryClientImpl):
(WebKit::BatteryClientImpl::~BatteryClientImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit):
(WebKit::WebViewImpl::updateBatteryStatus):

  • src/WebViewImpl.h:

(WebKit):
(WebViewImpl):

LayoutTests:

Add Battery Status API support to chromium.
https://bugs.webkit.org/show_bug.cgi?id=83284

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-04-11
Reviewed by Adam Barth.

  • platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
  • platform/chromium/test_expectations.txt:
02:44 Changeset [113844] by paroga@webkit.org

[CMake] Add WEBKIT_CREATE_FORWARDING_HEADERS macro
https://bugs.webkit.org/show_bug.cgi?id=83574

Reviewed by Daniel Bates.

This new macro generates forwarding headers with absolute paths to the original files.
It accepts a list of files and/or a list of directories as input.

  • Source/cmake/WebKitMacros.cmake:
02:43 Changeset [113843] by philn@webkit.org

Unreviewed, GTK gardening.

  • platform/gtk/test_expectations.txt: Mark an editing test as flaky.
02:41 Changeset [113842] by mihnea@adobe.com

[CSS Regions]Add helper class for flow threads info in RenderView
https://bugs.webkit.org/show_bug.cgi?id=83464

Reviewed by David Hyatt.

This patch creates a new helper class FlowThreadController that will accommodate all the flow thread
related info from RenderView and moves all the data structures/methods from RenderView into this new class.
There is only one FlowThreadController object per RenderView and it can be retrieved using flowThreadController() method from RenderView.
The flow thread controller object is owned by the RenderView and it is created on demand only if there are flowing
threads in the page.

Since there is no change in functionality, there are no new tests added.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:

(WebCore::Document::webkitGetFlowByName):

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):

  • rendering/FlowThreadController.cpp: Added.

(WebCore):
(WebCore::FlowThreadController::create):
(WebCore::FlowThreadController::FlowThreadController):
(WebCore::FlowThreadController::~FlowThreadController):
(WebCore::FlowThreadController::ensureRenderFlowThreadWithName):
(WebCore::FlowThreadController::layoutRenderNamedFlowThreads):

  • rendering/FlowThreadController.h: Added.

(WebCore):
(FlowThreadController):
(WebCore::FlowThreadController::currentRenderFlowThread):
(WebCore::FlowThreadController::setCurrentRenderFlowThread):
(WebCore::FlowThreadController::isRenderNamedFlowThreadOrderDirty):
(WebCore::FlowThreadController::setIsRenderNamedFlowThreadOrderDirty):
(WebCore::FlowThreadController::renderNamedFlowThreadList):
(WebCore::FlowThreadController::hasRenderNamedFlowThreads):

  • rendering/RenderFlowThread.cpp:

(WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer):
(WebCore::CurrentRenderFlowThreadMaintainer::~CurrentRenderFlowThreadMaintainer):
(WebCore::CurrentRenderFlowThreadDisabler::CurrentRenderFlowThreadDisabler):
(WebCore::CurrentRenderFlowThreadDisabler::~CurrentRenderFlowThreadDisabler):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::nextRendererForNode):
(WebCore::RenderNamedFlowThread::previousRendererForNode):
(WebCore::RenderNamedFlowThread::removeRegionFromThread):
(WebCore::RenderNamedFlowThread::addDependencyOnFlowThread):
(WebCore::RenderNamedFlowThread::removeDependencyOnFlowThread):

  • rendering/RenderNamedFlowThread.h:

(RenderNamedFlowThread):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):
(WebCore::RenderObject::enclosingRenderFlowThread):
(WebCore::RenderObject::willBeDestroyed):

  • rendering/RenderTreeAsText.cpp:

(WebCore::writeRenderNamedFlowThreads):

  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):
(WebCore::RenderView::layout):
(WebCore::RenderView::hasRenderNamedFlowThreads):
(WebCore::RenderView::flowThreadController):

  • rendering/RenderView.h:

(WebCore):
(RenderView):

02:29 Changeset [113841] by commit-queue@webkit.org

[EFL][DRT] SVG Filters rebaseline
https://bugs.webkit.org/show_bug.cgi?id=83673

Unreviewed, EFL rebaseline.

Bug 83562 fixed programmatically creating filters from JS, this
allows us to unskip a lot of SVG tests. This is part two.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-11

  • platform/efl/Skipped: Removed svg/filters/*.
  • platform/efl/svg/filters/: New baselines.
  • platform/efl/test_expectations.txt: Added one dropShadow filter failure.
02:16 Changeset [113840] by apavlov@chromium.org

Web Inspector: [Device Metrics] Implement dimension swapping
https://bugs.webkit.org/show_bug.cgi?id=83676

The change adds a "Swap dimensions" button that swaps the emulated device dimensions to
mimic the device rotation (give that the ORIENTATION_EVENTS feature is disabled in Chromium).

Reviewed by Yury Semikhatsky.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen.prototype._createDeviceMetricsElement.swapDimensionsClicked):
(WebInspector.SettingsScreen.prototype._createDeviceMetricsElement):

01:54 Changeset [113839] by rniwa@webkit.org

Refactor PerfTestRunner to include file extensions in test names
https://bugs.webkit.org/show_bug.cgi?id=83677

Reviewed by Hajime Morita.

Move the logic that extracts the test name from _process_parser_test_result to _collect_tests.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._collect_tests):
(PerfTestsRunner._run_tests_set):
(PerfTestsRunner._process_parser_test_result): Still replace "/" by ": " to keep the output format.
We can make the said behavior change by simply removing "test_name = re.sub(r'\.\w+$', , test_name)" here.
(PerfTestsRunner._run_single_test):

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(run_test):
(_tests_for_runner):
(test_run_test_set):
(test_run_test_set_kills_drt_per_run):
(test_run_test_pause_before_testing):
(test_run_test_set_for_parser_tests):
(test_collect_tests):
(test_collect_tests_with_skipped_list):

01:52 Changeset [113838] by tkent@chromium.org

Fix compiler warnings for generated CalendarPicker.cpp with VC++
https://bugs.webkit.org/show_bug.cgi?id=83672

Reviewed by Kentaro Hara.

  • make-file-arrays.py:

(main): Do not generate literal integers larger than 127 for
members of char arrays. Use '\xHH' instead.

01:49 Changeset [113837] by philn@webkit.org

Unreviewed, GTK rebaseline and baselines for new tests.

  • platform/gtk/fast/hidpi/image-set-background-dynamic-expected.txt: Added.
  • platform/gtk/fast/hidpi/image-set-border-image-dynamic-expected.txt: Added.
  • platform/gtk/fast/hidpi/image-set-in-content-dynamic-expected.txt: Added.
  • platform/gtk/fast/table/cell-pref-width-invalidation-expected.txt:
  • platform/gtk/fast/text/text-shadow-no-default-color-expected.txt: Added.
  • platform/gtk/ietestcenter/: Added.
  • platform/gtk/tables/mozilla/bugs/bug2123-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2509-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug34176-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug44505-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug59252-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug7243-expected.txt:
01:49 Changeset [113836] by commit-queue@webkit.org

Web Inspector: Disabling Inspector causes build failure on Windows
https://bugs.webkit.org/show_bug.cgi?id=83557

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-04-11
Reviewed by Pavel Feldman.

Source/WebKit/win:

The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
This change brings all such API calls under the guard.

  • WebCoreSupport/WebInspectorClient.cpp:
  • WebInspector.cpp:
  • WebNodeHighlight.cpp:

(WebNodeHighlight::WebNodeHighlight):
(WebNodeHighlight::update):

  • WebNodeHighlight.h:

(WebNodeHighlight):

  • WebView.cpp:

(WebView::WebView):
(WebView::close):
(WebView::initWithFrame):
(WebView::inspector):

  • WebView.h:

(WebView):

Tools:

The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
This change brings all such API calls under the guard.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(LayoutTestController):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::invoke):

01:43 UsingGitWithWebKit edited by dominik.rottsches@intel.com
link to using github page (diff)
01:38 Changeset [113835] by pfeldman@chromium.org

Web Inspector: fix category -> type refactoring implications.
https://bugs.webkit.org/show_bug.cgi?id=83680

Reviewed by Yury Semikhatsky.

We are now using type identifiers (singulars) as opposed to category identifier (plurals) in the style.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._createFilterStatusBarItems.createFilterElement):
(WebInspector.NetworkLogView.prototype._createFilterStatusBarItems):
(WebInspector.NetworkLogView.prototype._showCategory):
(WebInspector.NetworkLogView.prototype._hideCategory):
(WebInspector.NetworkLogView.prototype._filter):
(WebInspector.NetworkDataGridNode.prototype.refreshResource):
(WebInspector.NetworkDataGridNode.prototype.refreshGraph):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameResourceTreeElement):
(WebInspector.ResourceRevisionTreeElement):

  • inspector/front-end/networkLogView.css:

(.network-log-grid.data-grid .network-type-script .icon):
(.network-log-grid.data-grid.small .network-type-script .icon):
(.network-log-grid.data-grid .network-type-document .icon):
(.network-log-grid.data-grid.small .network-type-document .icon):
(.network-log-grid.data-grid .network-type-stylesheet .icon):
(.network-log-grid.data-grid.small .network-type-stylesheet .icon):
(.network-log-grid.data-grid .network-type-image .icon):
(.network-log-grid.data-grid.small .network-type-image .icon):
(.network-type-document .network-graph-bar):
(.network-type-document.resource-cached .network-graph-bar):
(.network-type-stylesheet .network-graph-bar):
(.network-type-stylesheet.resource-cached .network-graph-bar):
(.network-type-image .network-graph-bar):
(.network-type-image.resource-cached .network-graph-bar):
(.network-type-font .network-graph-bar):
(.network-type-font.resource-cached .network-graph-bar):
(.network-type-script .network-graph-bar):
(.network-type-script.resource-cached .network-graph-bar):
(.network-type-xhr .network-graph-bar):
(.network-type-xhr.resource-cached .network-graph-bar):
(.network-type-websocket .network-graph-bar):
(.network-type-websocket.resource-cached .network-graph-bar):
(.network-log-grid.data-grid.filter-other table.data tr.revealed.network-type-other):

  • inspector/front-end/resourcesPanel.css:

(.resource-sidebar-tree-item.resources-type-image .icon):
(.resources-type-image .image-resource-icon-preview):
(.children.small .resource-sidebar-tree-item.resources-type-image .icon):
(.children.small .resources-type-image .image-resource-icon-preview):
(.resource-sidebar-tree-item.resources-type-document .icon):
(.children.small .resource-sidebar-tree-item.resources-type-document .icon):
(.resource-sidebar-tree-item.resources-type-stylesheet .icon):
(.children.small .resource-sidebar-tree-item.resources-type-stylesheet .icon):
(.resource-sidebar-tree-item.resources-type-font .icon):
(.children.small .resource-sidebar-tree-item.resources-type-font .icon):
(.resource-sidebar-tree-item.resources-type-script .icon):
(.children.small .resource-sidebar-tree-item.resources-type-script .icon):
(.resource-sidebar-tree-item.resources-type-xhr .icon):
(.children.small .resource-sidebar-tree-item.resources-type-xhr .icon):

01:29 Changeset [113834] by philn@webkit.org

Unreviewed, GTK gardening.

  • platform/gtk/Skipped: Skip failing ref test
  • platform/gtk/test_expectations.txt: Mark two tests as crashing

and unskip tests needing rebaseline.

00:02 Changeset [113833] by noel.gordon@gmail.com

[GTK] ImageBuffer: Canonical mimeType for encoding implies startsWith('image/')
https://bugs.webkit.org/show_bug.cgi?id=83657

Reviewed by Martin Robinson.

Canonical image mimeTypes begin with "image/", and this is tested by an ASSERT
guard in toDataURL(): that checks the WebCore mimeType registry for image-for-
encoding mimeType. There is no need to also test mimeType.startsWith("image/")
because that is a given.

No new tests. Covered by existing fast/canvas/*toDataURL* tests.

  • platform/graphics/gtk/ImageBufferGtk.cpp:

(WebCore::ImageBuffer::toDataURL):

00:00 Changeset [113832] by philn@webkit.org

Unreviewed, GTK rebaseline after r113756.

  • platform/gtk/fast/multicol/table-vertical-align-expected.txt:
  • platform/gtk/fast/overflow/hidden-scrollbar-resize-expected.txt:
  • platform/gtk/fast/repaint/overflow-outline-repaint-expected.txt:
  • platform/gtk/scrollbars/scrollbars-on-positioned-content-expected.txt:

04/10/12:

23:46 Changeset [113831] by carlosgc@webkit.org

Unreviewed. Fix make distcheck issues.

Source/JavaScriptCore:

  • GNUmakefile.list.am: Ad missing files.

Source/WebCore:

  • GNUmakefile.list.am: Add missing header file.

Source/WebKit2:

  • GNUmakefile.am: Add missing header file.
23:26 Changeset [113830] by enne@google.com

[chromium] Signedness issue with code informing v8 of PatternSkia memory use
https://bugs.webkit.org/show_bug.cgi?id=83642

Reviewed by James Robinson.

The unary negation of size_t is still a size_t, so clamp and cast to
an int instead when adjusting v8 memory limits.

  • platform/graphics/Pattern.h:

(Pattern):

  • platform/graphics/skia/PatternSkia.cpp:

(WebCore::Pattern::platformPattern):

22:39 Changeset [113829] by tkent@chromium.org

Unreviewed. Using tkent+wkapi@ for ChromiumPublicApi notifications.

  • Scripts/webkitpy/common/config/watchlist:
  • Scripts/webkitpy/common/config/committers.py: Add tkent+wkapi@ to pass the style checker.
22:35 Changeset [113828] by noel.gordon@gmail.com

[chromium] ImageBuffer minor style fix: remove compound declaration
https://bugs.webkit.org/show_bug.cgi?id=83660

Reviewed by Kent Tamura.

No new tests. Covered by existing fast/canvas/*toDataURL* tests.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::toDataURL):
(WebCore::ImageDataToDataURL):

22:23 Changeset [113827] by fischman@chromium.org

Roll Chromium DEPS to last-known good revision
https://bugs.webkit.org/show_bug.cgi?id=83652

Unreviewed, just a DEPS roll (131469:131684)

  • DEPS:
21:58 Changeset [113826] by commit-queue@webkit.org

Add gesture event enums for long-press and pinch
https://bugs.webkit.org/show_bug.cgi?id=83640

Patch by Alexandre Elias <aelias@google.com> on 2012-04-10
Reviewed by James Robinson.

Add new enum values GestureLongPress and GesturePinchBegin/End/Update,
along with no-op default handling.

Source/WebCore:

No new tests. (No-op change.)

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):

  • platform/PlatformEvent.h:

Source/WebKit/chromium:

  • public/WebInputEvent.h:
  • src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::gestureEvent):

21:48 Changeset [113825] by inferno@chromium.org

Crash due to intruding float not removed from next siblings.
https://bugs.webkit.org/show_bug.cgi?id=83301

Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/block/float/intruding-float-not-removed-from-next-sibling-crash.html

markSiblingsWithFloatsForLayout currently only handled overhanging floats and made
checks for those by checking if logicalBottomForFloat > our logicalHeight. We need
to take care of intruding floats as well, since these can intrude into the neighbouring
blocks too. So, generalized the function to check all our next siblings if they contains
that float (one getting removed) and if yes, mark it and all its descendants for layout.
This fixes the crash.

For performance, we change the looping condition to iterate over the next sibling
blocks first and finding which ones can contain floats and then check it against
our floating object list. Currently, it is the other way around and is less
performant due to repeated calls to isRenderBlock(), isFloatingOrPositioned()
and avoidFloats().

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::markSiblingsWithFloatsForLayout):

LayoutTests:

  • fast/block/float/intruding-float-not-removed-from-next-sibling-crash-expected.txt: Added.
  • fast/block/float/intruding-float-not-removed-from-next-sibling-crash.html: Added.
21:35 April 2012 Meeting edited by morrita@google.com
(diff)
21:19 Changeset [113824] by mikelawther@chromium.org

Prevent fallthrough to keep static analysis tools happy
https://bugs.webkit.org/show_bug.cgi?id=83639

Reviewed by Darin Adler.

No new tests - no new behaviour.

  • css/LengthFunctions.cpp:

(WebCore::valueForLength):

21:15 Changeset [113823] by jchaffraix@webkit.org

Don't expose the intrinsic padding concept to the code outside rendering
https://bugs.webkit.org/show_bug.cgi?id=83380

Reviewed by Eric Seidel.

No new tests, refactoring only.

The current code would expose the concept of intrinsic padding to every
object holding a renderer through an enum on the padding* functions.

This was very fragile as only the class using intrinsic padding should know about
its very existence, the rest of the code shouldn't have to special case for it.
There is one exception: the getComputedStyle logic needs the opposite value
rendering needs. To handle that, we make it more explicit what returns the
computed values vs the rendering values.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::sizingBox):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Updated those functions to use the new computedCSS* functions below.

  • rendering/RenderBox.h:

(RenderBox):
(WebCore::RenderBox::computedCSSContentBoxRect):
This is the computed content box. It includes the intrinsic padding.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::computedCSSPaddingTop):
(WebCore::RenderBoxModelObject::computedCSSPaddingBottom):
(WebCore::RenderBoxModelObject::computedCSSPaddingLeft):
(WebCore::RenderBoxModelObject::computedCSSPaddingRight):
(WebCore::RenderBoxModelObject::computedCSSPaddingBefore):
(WebCore::RenderBoxModelObject::computedCSSPaddingAfter):
(WebCore::RenderBoxModelObject::computedCSSPaddingStart):
(WebCore::RenderBoxModelObject::computedCSSPaddingEnd):
Renamed from padding* as they returned the CSS computed values.

  • rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):
Killed the enum paddingOptions!

(WebCore::RenderBoxModelObject::paddingTop):
(WebCore::RenderBoxModelObject::paddingBottom):
(WebCore::RenderBoxModelObject::paddingLeft):
(WebCore::RenderBoxModelObject::paddingRight):
(WebCore::RenderBoxModelObject::paddingBefore):
(WebCore::RenderBoxModelObject::paddingAfter):
(WebCore::RenderBoxModelObject::paddingStart):
(WebCore::RenderBoxModelObject::paddingEnd):
All padding* functions call the computedCSSPadding* ones above.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paddingTop):
(WebCore::RenderTableCell::paddingBottom):
(WebCore::RenderTableCell::paddingLeft):
(WebCore::RenderTableCell::paddingRight):
(WebCore::RenderTableCell::paddingBefore):
(WebCore::RenderTableCell::paddingAfter):
Updated these functions after the renaming.

  • rendering/RenderTableCell.h:

(RenderTableCell):
Updated the functions signature and decorated them with OVERRIDE.

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::paddingTop):
(WebCore::RenderMathMLBlock::paddingBottom):
(WebCore::RenderMathMLBlock::paddingLeft):
(WebCore::RenderMathMLBlock::paddingRight):
(WebCore::RenderMathMLBlock::paddingBefore):
(WebCore::RenderMathMLBlock::paddingAfter):
(WebCore::RenderMathMLBlock::paddingStart):
(WebCore::RenderMathMLBlock::paddingEnd):

  • rendering/mathml/RenderMathMLBlock.h:

(RenderMathMLBlock):
Updated these functions after the renaming.

  • rendering/mathml/RenderMathMLSquareRoot.cpp:

(WebCore::RenderMathMLSquareRoot::paint):
Updated this function to use computeCSSContentBoxRect.location().

20:35 Changeset [113822] by commit-queue@webkit.org

TextureMapperGL.cpp breaks build with OpenGL ES
https://bugs.webkit.org/show_bug.cgi?id=83622

Patch by Lauro Neto <lauro.neto@openbossa.org> on 2012-04-10
Reviewed by Noam Rosenthal.

Add !defined(TEXMAP_OPENGL_ES_2) guards as suggested by
No'am Rosenthal.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::updateContents):

20:33 Changeset [113821] by tkent@chromium.org

Calendar Picker: Initialize CalendarPickerElement::m_popup
https://bugs.webkit.org/show_bug.cgi?id=83656

Reviewed by Hajime Morita.

  • html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::CalendarPickerElement): Set 0 to m_popup.

20:26 Changeset [113820] by adamk@chromium.org

CodeGeneratorV8 cleanup: eliminate redundant calls to IsRefPtrType
https://bugs.webkit.org/show_bug.cgi?id=83623

Reviewed by Adam Barth.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader): Always emit toV8(PassRefPtr), as all wrapped types are RefCounted.
(GenerateImplementation): Always emit code for derefObject, as all wrapped types are RefCounted.

20:02 Changeset [113819] by jamesr@google.com

[chromium] Add OVERRIDE annotations for cc tree host and proxy interfaces
https://bugs.webkit.org/show_bug.cgi?id=83653

Reviewed by Adrienne Walker.

This adds OVERRIDE annotations to the implementations of the following interfaces:

  • CCLayerTreeHostClient
  • CCLayerTreeHostImplClient
  • CCProxy
  • LayerRendererChromiumClient

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
  • platform/graphics/chromium/cc/CCProxy.h:

(WebCore):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(CCSingleThreadProxy):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

  • src/WebLayerTreeViewImpl.h:

(WebLayerTreeViewImpl):

  • src/WebViewImpl.h:

(WebViewImpl):

  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/CCLayerTreeHostTest.cpp:
  • tests/FakeCCLayerTreeHostClient.h:
  • tests/LayerRendererChromiumTest.cpp:
19:59 Changeset [113818] by dgrogan@chromium.org

Notify observers of WorkerRunLoop stopping before the V8 isolate dies.
https://bugs.webkit.org/show_bug.cgi?id=83104

Source/WebCore:

PlatformSupport::didStopWorkerRunLoop ultimately causes
~V8AbstractEventListener to call
v8::Local<v8::Object>::New(m_listener) after the V8 isolate has been
disposed, which manifests as a crash in V8.

The current code in trunk runs this at shutdown:
1) removeAllDOMObjects()
2) dispose of V8
3) didStopWorkerRunLoop() <-- problem

This patch changes the order to be:
1) removeAllDOMObjects()
2) didStopWorkerRunLoop()
3) dispose of V8

We put didStopWorkerRunLoop after removeAllDOMObjects because we don't
want chromium code that runs on a webcore worker to run after it
receives the didStopWorkerRunLoop signal. The destructors of some IDB
objects are run by removeAllDOMObjects, so putting
didStopWorkerRunLoop before removeAllDOMObjects would violate that
constraint.

It's possible that there's a lower layer fix available in V8 or the
bindings.

Reviewed by David Levin.

Test: storage/indexeddb/pending-version-change-on-exit.html

  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::~WorkerScriptController):
New location of didStopWorkerRunLoop. removeAllDOMObjects and V8
disposal are called here, to run something between them it also has
to go here.

  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::workerThread): Old location of
didStopWorkerRunLoop.

LayoutTests:

Reviewed by David Levin.

  • storage/indexeddb/pending-version-change-on-exit-expected.txt: Added.
  • storage/indexeddb/pending-version-change-on-exit.html: Added.
  • storage/indexeddb/resources/pending-version-change-on-exit.js: Added.

(test.request.onsuccess.request.onblocked):
(test.request.onsuccess):
(test):

19:57 Changeset [113817] by adamk@chromium.org

Break the association between form controls and their owner when the owner leaves the tree
https://bugs.webkit.org/show_bug.cgi?id=81420

Reviewed by Kent Tamura.

Source/WebCore:

When parsing malformed markup, it's possible for a form and a
form-associated element to not be in an ancestor/descendant relationship.
When that form is later removed from the tree, the relationship needs to be updated.

Test: fast/forms/parser-associated-form-removal.html

  • html/FormAssociatedElement.cpp:

(WebCore::FormAssociatedElement::FormAssociatedElement):
(WebCore::FormAssociatedElement::formRemovedFromTree): New method called when
by the form when it's being removed: handles either resetting the
owner or storing a bit to optimize away a second walk up the tree.

  • html/FormAssociatedElement.h:

(FormAssociatedElement):

  • html/HTMLFormElement.cpp:

(WebCore::findRoot): Simple helper method copied from FormAssociatedElement (this should probably live elsewhere).
(WebCore::HTMLFormElement::removedFromTree): Override removedFromTree to notify associated elements of the removal.

  • html/HTMLFormElement.h:

(HTMLFormElement):

LayoutTests:

  • fast/forms/parser-associated-form-removal-expected.txt: Added.
  • fast/forms/parser-associated-form-removal.html: Added.
19:55 Changeset [113816] by jamesr@google.com

[chromium] Add OVERRIDE annotations for cc scheduler-related client interfaces
https://bugs.webkit.org/show_bug.cgi?id=83646

Reviewed by Adrienne Walker.

This adds OVERRIDE annotations to the implementations of the following interfaces:

  • CCFrameRateControllerClient
  • CCSchedulerClient
  • CCTimeSource
  • CCTimeSourceClient
  • CCTimerClient

Source/WebCore:

  • platform/graphics/chromium/cc/CCDelayBasedTimeSource.h:
  • platform/graphics/chromium/cc/CCFrameRateController.cpp:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
  • platform/graphics/chromium/cc/CCScheduler.h:

(CCScheduler):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:
  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

  • tests/CCSchedulerTest.cpp:
  • tests/CCSchedulerTestCommon.h:
19:51 Changeset [113815] by commit-queue@webkit.org

[CSS Regions] Convert a fast/regions pixel test to a ref test
https://bugs.webkit.org/show_bug.cgi?id=83529

Patch by David Alcala <dalcala@adobe.com> on 2012-04-10
Reviewed by Ryosuke Niwa.

  • fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.html: Added.
  • platform/chromium-linux/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Removed.
  • platform/chromium-mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Removed.
  • platform/chromium-mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.txt: Removed.
  • platform/chromium-win/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Removed.
  • platform/chromium-win/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.txt: Removed.
  • platform/efl/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Removed.
  • platform/efl/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.txt: Removed.
  • platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Removed.
  • platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.txt: Removed.
19:49 Changeset [113814] by mrowe@apple.com

Attempt to fix the Windows build.

19:38 Changeset [113813] by dpranke@chromium.org

If NRWT gets killed halfway through a run, it incorrectly reports tests that weren't run as passes
https://bugs.webkit.org/show_bug.cgi?id=82799

Reviewed by Ojan Vafai.

The tests we were skipping in _mark_interrupted_tests_as_skipped
had incorrectly-constructed TestResults, and so they were not
being treated as failures. The JSON generator doesn't record
tests that are passed or skiped in incremental_results, so you
couldn't tell these tests were being skipped at all.

This change changes _mark_interrupted_tests_as_skipped() to
treat the skipped tests as failures; this is arguably still
incorrect but is minimally invasive for now. We probably need to
revisit how we are uploading information about tests that are
skipped and passed altogether in a separate change.

This change also cleans up a couple of other nits that were
unnecessary or broken in this same code path.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._mark_interrupted_tests_as_skipped):
(Manager._upload_json_files): Deletes the check for
chromium-mac-leopard (as it is no longer necessary).

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:

(JSONLayoutResultsGenerator.init): Here we were
recalculating the failure type unnecessarily.

  • Scripts/webkitpy/layout_tests/models/test_failures.py:

(determine_result_type):
(FailureEarlyExit): Adds a new failure type so we can tell what
happened.
(FailureEarlyExit.message):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_exit_after_n_failures_upload): Add more checks to
ensure that we are recording the SKIP correctly; this is less
than ideal, because we can't actually test the contents of
incremental_results.json. We should fix that at some point.

19:28 Changeset [113812] by bashi@chromium.org

Merge 113132 - [Chromium] Out-of-process font loading garbles text
https://bugs.webkit.org/show_bug.cgi?id=83002

Reviewed by Kent Tamura.

Initialize m_CTFont by using m_cgFont in FontPlatformData when we use
out-of-process font loading.

No new tests. This problem only occurs when the user uses a third party
font management software like Font Explorer so it is difficult to add
tests.

  • platform/graphics/chromium/CrossProcessFontLoading.mm:

(WebCore):
(WebCore::FontPlatformData::loadFont): If font loading fails, set null to outNSFont so that the FontPlatformData won't be used.

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::ctFont): Modified to return the appropriate NSFont object when the font from the browser process.

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::createFontPlatformData): Returns null when the generated FontPlatformData object doesn't have NSFont object.

TBR=bashi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10034005

19:27 Changeset [113811] by tkent@chromium.org

Add a function to set empty clients to a PageClients
https://bugs.webkit.org/show_bug.cgi?id=83555

Reviewed by Adam Barth.

No new tests because of no behavior change.

  • CMakeLists.txt: Add EmptyClients.cpp.
  • GNUmakefile.list.am: ditto.
  • Target.pri: ditto.
  • WebCore.gypi: ditto.
  • WebCore.vcproj/WebCore.vcproj: ditto.
  • WebCore.xcodeproj/project.pbxproj: ditto.
  • loader/EmptyClients.cpp: Added.

(WebCore::fillWithEmptyClients): Some code was moved from SVGImage::dataChanged().

  • loader/EmptyClients.h: Add the declaration of fillWithEmptyClients().
  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::dataChanged): Moved some code to fillWithEmptyClients().

19:25 FeatureFlags edited by tkent@chromium.org
add LEGACY_CSS_VENDOR_PREFIXES (diff)
19:19 Changeset [113810] by rakuco@webkit.org

[EFL] Garden fast/{backgrounds,dynamic,encoding}.

  • platform/efl/fast/backgrounds/svg-as-mask-expected.txt:
  • platform/efl/fast/dynamic/002-expected.png:
  • platform/efl/fast/dynamic/004-expected.png:
  • platform/efl/fast/dynamic/006-expected.png:
  • platform/efl/fast/dynamic/012-expected.png:
  • platform/efl/fast/dynamic/015-expected.png:
  • platform/efl/fast/dynamic/anchor-lock-expected.txt:
  • platform/efl/fast/dynamic/anonymous-block-orphaned-lines-expected.png:
  • platform/efl/fast/dynamic/containing-block-change-expected.png:
  • platform/efl/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-expected.png:
  • platform/efl/fast/dynamic/float-withdrawal-expected.png:
  • platform/efl/fast/dynamic/insert-before-table-part-in-continuation-expected.png:
  • platform/efl/fast/dynamic/noninlinebadness-expected.png:
  • platform/efl/fast/dynamic/outerHTML-doc-expected.png:
  • platform/efl/fast/dynamic/outerHTML-img-expected.png:
  • platform/efl/fast/dynamic/selection-highlight-adjust-expected.png:
  • platform/efl/fast/dynamic/staticY-marking-parents-regression-expected.png:
  • platform/efl/fast/dynamic/text-combine-expected.png:
  • platform/efl/fast/dynamic/text-combine-expected.txt:
  • platform/efl/fast/dynamic/view-overflow-expected.png:
  • platform/efl/fast/encoding/denormalised-voiced-japanese-chars-expected.png:
  • platform/efl/fast/encoding/invalid-UTF-8-expected.png:
  • platform/efl/fast/encoding/utf-16-big-endian-expected.png:
  • platform/efl/fast/encoding/utf-16-big-endian-expected.txt:
  • platform/efl/fast/encoding/utf-16-little-endian-expected.png:
  • platform/efl/fast/encoding/utf-16-little-endian-expected.txt:
  • platform/efl/fast/encoding/xmacroman-encoding-test-expected.png:
19:13 Changeset [113809] by jamesr@google.com

[chromium] Fold LayerChromium::updateCompositorResources into main update
https://bugs.webkit.org/show_bug.cgi?id=83530

Reviewed by Adrienne Walker.

Source/WebCore:

We used to update layer contents in two phases. The first, called paintContentsIfDirty() /
idlePaintContentsIfDirty(), ran on the main WebKit thread and took care of any main-thread work - primarily
WebCore painting as the name implies. The second, called updateCompositorResources(), ran on the compositor
thread with the main thread blocked and took care of any actions that required direct access to the compositor's
context - such as texture uploads into compositor-managed textures. Now that all compositor texture operations
are queued on a CCTextureUpdater, the compositor can take care of these operations on the correct thread at the
right time without needing layer-specific logic.

This folds both functions into one function called LayerChromium::update() (and idleUpdate() for idle
prepainting) and adds a CCTextureUpdater reference for queuing up texture operations.

The CCProxy is responsible for the lifetime of the CCTextureUpdater. In the threaded proxy, the updater is
tied to the lifetime of the beginFrame operation. Specifically it's constructed on the impl thread when the
beginFrame message is generated, is accessed by reference on the main thread during the commit, and then
destroyed by the proxy when the commit is complete. CCTextureUpdater::update should only be called on the impl
thread by the proxy. In the future, it might be worth exposing a more limited interface to layers.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::update):

  • platform/graphics/chromium/Canvas2DLayerChromium.h:

(Canvas2DLayerChromium):

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::update):
(WebCore::ContentLayerChromium::idleUpdate):

  • platform/graphics/chromium/ContentLayerChromium.h:

(ContentLayerChromium):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerTextureUpdater::updateLayerRect):
(WebCore::ImageLayerChromium::update):

  • platform/graphics/chromium/ImageLayerChromium.h:

(ImageLayerChromium):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::update):
(WebCore::LayerChromium::idleUpdate):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::UpdatableTile::isDirty):
(WebCore::UpdatableTile::copyAndClearDirty):
(WebCore::UpdatableTile::isDirtyForCurrentFrame):
(UpdatableTile):
(WebCore::UpdatableTile::UpdatableTile):
(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::createTile):
(WebCore::TiledLayerChromium::invalidateRect):
(WebCore::TiledLayerChromium::tileOnlyNeedsPartialUpdate):
(WebCore::TiledLayerChromium::updateTiles):
(WebCore::TiledLayerChromium::reserveTextures):
(WebCore::TiledLayerChromium::resetUpdateState):
(WebCore::TiledLayerChromium::updateLayerRect):
(WebCore::TiledLayerChromium::idleUpdateLayerRect):
(WebCore::TiledLayerChromium::needsIdlePaint):

  • platform/graphics/chromium/TiledLayerChromium.h:

(TiledLayerChromium):

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::update):

  • platform/graphics/chromium/WebGLLayerChromium.h:

(WebGLLayerChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::~CCLayerTreeHost):
(WebCore::CCLayerTreeHost::commitComplete):
(WebCore::CCLayerTreeHost::updateLayers):
(WebCore::CCLayerTreeHost::reserveTextures):
(WebCore::CCLayerTreeHost::update):
(WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::doCommit):
(WebCore::CCSingleThreadProxy::commitIfNeeded):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(CCSingleThreadProxy):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionBeginFrame):
(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
(WebCore::CCThreadProxy::scheduledActionCommit):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(WebCore::CCThreadProxy::BeginFrameAndCommitState::BeginFrameAndCommitState):
(BeginFrameAndCommitState):

Source/WebKit/chromium:

Update tests for interface changes.

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::runTest):
(WTF::ContentLayerChromiumWithUpdateTracking::update):
(WTF::ContentLayerChromiumWithUpdateTracking::idleUpdate):
(WTF::ContentLayerChromiumWithUpdateTracking::ContentLayerChromiumWithUpdateTracking):
(ContentLayerChromiumWithUpdateTracking):
(WTF::CCLayerTreeHostTestOpacityChange::afterTest):
(WTF::CCLayerTreeHostTestSetViewportSize::beginTest):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::commitCompleteOnCCThread):
(WTF::TestLayerChromium::update):
(WTF::CCLayerTreeHostTestLayerOcclusion::beginTest):
(WTF::CCLayerTreeHostTestContentLayerOcclusion::beginTest):
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest):
(WTF::CCLayerTreeHostTestManySurfaces::beginTest):

  • tests/CCTiledLayerTestCommon.cpp:

(WebKitTests::FakeLayerTextureUpdater::updateLayerRect):
(WebKitTests::FakeTiledLayerChromium::update):

  • tests/CCTiledLayerTestCommon.h:

(FakeLayerTextureUpdater):
(FakeTiledLayerChromium):

  • tests/Canvas2DLayerChromiumTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):
(WTF::idlePaintRepeat):

19:07 Changeset [113808] by dglazkov@chromium.org

fast/forms/implicit-submission.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=39056

Speed up the test by removing unnecessary iframe and navigation,
make it less flaky by removing timeouts.

Reviewed by Hajime Morita.

  • fast/forms/implicit-submission.html: Deflakified and sped up.
19:05 Changeset [113807] by rakuco@webkit.org

[EFL] Garden fast/css.

Account for some changes related to the jhbuild and font commits
and adjust some wrong results with fonts that are too big.

  • platform/efl/fast/css/001-expected.png:
  • platform/efl/fast/css/003-expected.png:
  • platform/efl/fast/css/004-expected.png:
  • platform/efl/fast/css/005-expected.png:
  • platform/efl/fast/css/MarqueeLayoutTest-expected.png:
  • platform/efl/fast/css/ZeroOpacityLayers-expected.png:
  • platform/efl/fast/css/ZeroOpacityLayers2-expected.png:
  • platform/efl/fast/css/absolute-poition-in-rtl-parent-expected.png:
  • platform/efl/fast/css/acid2-pixel-expected.png:
  • platform/efl/fast/css/apple-prefix-expected.png:
  • platform/efl/fast/css/begin-end-contain-selector-empty-value-expected.png:
  • platform/efl/fast/css/bidi-override-in-anonymous-block-expected.png:
  • platform/efl/fast/css/bidi-override-in-anonymous-block-expected.txt:
  • platform/efl/fast/css/border-radius-outline-offset-expected.png:
  • platform/efl/fast/css/color-correction-backgrounds-and-text-expected.png:
  • platform/efl/fast/css/color-correction-expected.png:
  • platform/efl/fast/css/color-correction-on-text-expected.png:
  • platform/efl/fast/css/compare-content-style-expected.png:
  • platform/efl/fast/css/continuationCrash-expected.png:
  • platform/efl/fast/css/create_element_align-expected.png:
  • platform/efl/fast/css/css-imports-expected.png:
  • platform/efl/fast/css/css1_forward_compatible_parsing-expected.png:
  • platform/efl/fast/css/css2-system-fonts-expected.png:
  • platform/efl/fast/css/css3-modsel-22-expected.png:
  • platform/efl/fast/css/css3-nth-child-expected.png:
  • platform/efl/fast/css/css3-space-in-nth-and-lang-expected.png:
  • platform/efl/fast/css/empty-pseudo-class-expected.png:
  • platform/efl/fast/css/error-in-last-decl-expected.png:
  • platform/efl/fast/css/ex-after-font-variant-expected.png:
  • platform/efl/fast/css/fieldset-display-row-expected.png:
  • platform/efl/fast/css/find-next-layer-expected.png:
  • platform/efl/fast/css/first-child-pseudo-class-expected.png:
  • platform/efl/fast/css/first-letter-capitalized-expected.png:
  • platform/efl/fast/css/first-letter-detach-expected.png:
  • platform/efl/fast/css/first-letter-float-after-float-expected.png:
  • platform/efl/fast/css/first-letter-float-expected.png:
  • platform/efl/fast/css/first-letter-hover-expected.png:
  • platform/efl/fast/css/first-letter-punctuation-expected.png:
  • platform/efl/fast/css/first-letter-recalculation-expected.png:
  • platform/efl/fast/css/first-letter-skip-out-of-flow-expected.png:
  • platform/efl/fast/css/first-letter-visibility-expected.png:
  • platform/efl/fast/css/first-of-type-pseudo-class-expected.png:
  • platform/efl/fast/css/focus-ring-detached-expected.png:
  • platform/efl/fast/css/focus-ring-multiline-expected.png:
  • platform/efl/fast/css/focus-ring-multiline-writingmode-vertical-expected.png:
  • platform/efl/fast/css/focus-ring-outline-offset-expected.png:
  • platform/efl/fast/css/font-face-implicit-local-font-expected.png:
  • platform/efl/fast/css/font-face-locally-installed-expected.png:
  • platform/efl/fast/css/font-face-multiple-faces-expected.png:
  • platform/efl/fast/css/font-face-unicode-range-expected.png:
  • platform/efl/fast/css/font-weight-1-expected.png:
  • platform/efl/fast/css/font_property_normal-expected.png:
  • platform/efl/fast/css/h1-in-section-elements-expected.png:
  • platform/efl/fast/css/hover-subselector-expected.png:
  • platform/efl/fast/css/hsl-color-expected.png:
  • platform/efl/fast/css/import-rule-regression-11590-expected.png:
  • platform/efl/fast/css/import-rule-regression-11590-expected.txt:
  • platform/efl/fast/css/inline-element-line-break-expected.png:
  • platform/efl/fast/css/inline-element-line-break-expected.txt:
  • platform/efl/fast/css/inline-properties-important-expected.png:
  • platform/efl/fast/css/inline-properties-important-expected.txt:
  • platform/efl/fast/css/invalid-percentage-property-expected.png:
  • platform/efl/fast/css/invalid-percentage-property-expected.txt:
  • platform/efl/fast/css/invalidation-errors-2-expected.png:
  • platform/efl/fast/css/invalidation-errors-2-expected.txt:
  • platform/efl/fast/css/invalidation-errors-3-expected.png:
  • platform/efl/fast/css/invalidation-errors-3-expected.txt:
  • platform/efl/fast/css/invalidation-errors-expected.png:
  • platform/efl/fast/css/invalidation-errors-expected.txt:
  • platform/efl/fast/css/last-child-pseudo-class-expected.png:
  • platform/efl/fast/css/last-child-pseudo-class-expected.txt:
  • platform/efl/fast/css/last-of-type-pseudo-class-expected.png:
  • platform/efl/fast/css/last-of-type-pseudo-class-expected.txt:
  • platform/efl/fast/css/layerZOrderCrash-expected.png:
  • platform/efl/fast/css/layerZOrderCrash-expected.txt:
  • platform/efl/fast/css/line-height-expected.png:
  • platform/efl/fast/css/line-height-expected.txt:
  • platform/efl/fast/css/line-height-overflow-expected.png:
  • platform/efl/fast/css/line-height-overflow-expected.txt:
  • platform/efl/fast/css/list-outline-expected.png:
  • platform/efl/fast/css/list-outline-expected.txt:
  • platform/efl/fast/css/margin-bottom-form-element-quirk-expected.png:
  • platform/efl/fast/css/margin-bottom-form-element-quirk-expected.txt:
  • platform/efl/fast/css/margin-bottom-form-element-strict-expected.png:
  • platform/efl/fast/css/margin-bottom-form-element-strict-expected.txt:
  • platform/efl/fast/css/margin-top-bottom-dynamic-expected.png:
  • platform/efl/fast/css/margin-top-bottom-dynamic-expected.txt:
  • platform/efl/fast/css/namespaces/004-expected.png:
  • platform/efl/fast/css/namespaces/005-expected.png:
  • platform/efl/fast/css/namespaces/namespaces-comments-expected.png:
  • platform/efl/fast/css/namespaces/namespaces-empty-expected.png:
  • platform/efl/fast/css/namespaces/namespaces-escapes-expected.png:
  • platform/efl/fast/css/namespaces/namespaces-invalid-at-expected.png:
  • platform/efl/fast/css/negative-leading-expected.png:
  • platform/efl/fast/css/negative-leading-expected.txt:
  • platform/efl/fast/css/negative-nth-child-expected.png:
  • platform/efl/fast/css/negative-nth-child-expected.txt:
  • platform/efl/fast/css/nested-floating-relative-position-percentages-expected.png:
  • platform/efl/fast/css/nested-floating-relative-position-percentages-expected.txt:
  • platform/efl/fast/css/nested-layers-with-hover-expected.png:
  • platform/efl/fast/css/nested-layers-with-hover-expected.txt:
  • platform/efl/fast/css/nested-rounded-corners-expected.png:
  • platform/efl/fast/css/nth-child-dynamic-expected.png:
  • platform/efl/fast/css/nth-child-dynamic-expected.txt:
  • platform/efl/fast/css/only-child-pseudo-class-expected.png:
  • platform/efl/fast/css/only-child-pseudo-class-expected.txt:
  • platform/efl/fast/css/only-of-type-pseudo-class-expected.png:
  • platform/efl/fast/css/only-of-type-pseudo-class-expected.txt:
  • platform/efl/fast/css/outline-auto-location-expected.png:
  • platform/efl/fast/css/outline-auto-location-expected.txt:
  • platform/efl/fast/css/outline-narrowLine-expected.png:
  • platform/efl/fast/css/outline-narrowLine-expected.txt:
  • platform/efl/fast/css/percent-top-relative-container-height-unspecified-expected.png:
  • platform/efl/fast/css/percent-top-relative-container-height-unspecified-expected.txt:
  • platform/efl/fast/css/percentage-non-integer-expected.png:
  • platform/efl/fast/css/percentage-non-integer-expected.txt:
  • platform/efl/fast/css/positioned-overflow-scroll-expected.png:
  • platform/efl/fast/css/pseudo-element-line-break-expected.png:
  • platform/efl/fast/css/pseudo-element-line-break-expected.txt:
  • platform/efl/fast/css/pseudo-first-line-border-width-expected.png:
  • platform/efl/fast/css/pseudo-first-line-border-width-expected.txt: Added.
  • platform/efl/fast/css/quirk-orphaned-units-expected.png:
  • platform/efl/fast/css/quirk-orphaned-units-expected.txt:
  • platform/efl/fast/css/resize-corner-tracking-expected.png:
  • platform/efl/fast/css/resize-corner-tracking-expected.txt:
  • platform/efl/fast/css/resize-corner-tracking-transformed-expected.png:
  • platform/efl/fast/css/resize-corner-tracking-transformed-expected.txt:
  • platform/efl/fast/css/rtl-ordering-expected.png:
  • platform/efl/fast/css/rtl-ordering-expected.txt:
  • platform/efl/fast/css/selector-set-attribute-expected.png:
  • platform/efl/fast/css/selector-set-attribute-expected.txt:
  • platform/efl/fast/css/table-text-align-quirk-expected.png:
  • platform/efl/fast/css/table-text-align-quirk-expected.txt:
  • platform/efl/fast/css/table-text-align-strict-expected.png:
  • platform/efl/fast/css/table-text-align-strict-expected.txt:
  • platform/efl/fast/css/text-align-expected.png:
  • platform/efl/fast/css/text-align-expected.txt:
  • platform/efl/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/efl/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/efl/fast/css/text-overflow-ellipsis-bidi-expected.png:
  • platform/efl/fast/css/text-overflow-ellipsis-bidi-expected.txt:
  • platform/efl/fast/css/text-overflow-ellipsis-expected.png:
  • platform/efl/fast/css/text-overflow-ellipsis-expected.txt:
  • platform/efl/fast/css/text-overflow-ellipsis-strict-expected.png:
  • platform/efl/fast/css/text-overflow-ellipsis-strict-expected.txt:
  • platform/efl/fast/css/text-security-expected.png:
  • platform/efl/fast/css/text-security-expected.txt:
  • platform/efl/fast/css/text-transform-select-expected.png:
  • platform/efl/fast/css/text-transform-select-expected.txt:
  • platform/efl/fast/css/textCapitalizeEdgeCases-expected.png:
  • platform/efl/fast/css/textCapitalizeEdgeCases-expected.txt:
  • platform/efl/fast/css/transformed-mask-expected.png:
  • platform/efl/fast/css/transformed-mask-expected.txt:
  • platform/efl/fast/css/universal-hover-quirk-expected.png:
  • platform/efl/fast/css/universal-hover-quirk-expected.txt:
  • platform/efl/fast/css/value-list-out-of-bounds-crash-expected.png:
  • platform/efl/fast/css/value-list-out-of-bounds-crash-expected.txt:
  • platform/efl/fast/css/word-space-extra-expected.png:
  • platform/efl/fast/css/word-space-extra-expected.txt:
  • platform/efl/fast/css/zoom-font-size-expected.png:
  • platform/efl/fast/css/zoom-font-size-expected.txt:
18:57 Changeset [113806] by adamk@chromium.org

Store V8 SVGElementInstance wrappers in the regular DOMObjectMap
https://bugs.webkit.org/show_bug.cgi?id=83615

Reviewed by Adam Barth.

Historically, these wrappers had their own map, but there doesn't seem
to be any particular reason for this. The V8GCController doesn't
treat them specially (which is the reason you normally need a separate
wrapper map).

No new tests, no expected change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GetDomMapName):

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::DOMDataStore):
(WebCore::DOMDataStore::getDOMWrapperMap):

  • bindings/v8/DOMDataStore.h:

(DOMDataStore):

  • bindings/v8/ScopedDOMDataStore.cpp:

(WebCore::ScopedDOMDataStore::ScopedDOMDataStore):
(WebCore::ScopedDOMDataStore::~ScopedDOMDataStore):

  • bindings/v8/StaticDOMDataStore.cpp:

(WebCore::StaticDOMDataStore::StaticDOMDataStore):

  • bindings/v8/StaticDOMDataStore.h:

(StaticDOMDataStore):

  • bindings/v8/V8DOMMap.cpp:

(WebCore::removeAllDOMObjects):

  • bindings/v8/V8DOMMap.h:

(WebCore):

  • bindings/v8/V8DOMWrapper.cpp:
18:46 Changeset [113805] by noel.gordon@gmail.com

[Qt] Separate image encoding from dataURL construction
https://bugs.webkit.org/show_bug.cgi?id=83132

Reviewed by Noam Rosenthal.

Remove the implicit assumption that a dataURL is the only desired output format
of the image encoding phase.

No new tests, refactoring only, covered by existing canvas tests.

  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::encodeImage): Output the encoded image to the provided QByteArray.
(WebCore):
(WebCore::ImageBuffer::toDataURL) Format the dataURL encoding of the mimeType
encoded image data here. Clarify the comment.

18:45 Changeset [113804] by dpranke@chromium.org

make chromium layout tests not depend on platform/win, platform/mac-leopard, or platform/mac-snowleopard
https://bugs.webkit.org/show_bug.cgi?id=83401

Reviewed by Adam Barth.

Last patch in the series - no longer look in mac-leopard,
mac-snowleopard, or mac-lion.

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:

(ChromiumMacPort):

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
18:39 Changeset [113803] by paroga@webkit.org

Build fix for WinCE after r113730.

  • platform/FractionalLayoutUnit.h:

(WebCore::FractionalLayoutUnit::isInBounds):

18:37 Changeset [113802] by dpranke@chromium.org

webkit-patch: add a print-expectations command
https://bugs.webkit.org/show_bug.cgi?id=83347

Reviewed by Adam Barth.

This command will print the expected results for a given set of
tests on a given set of ports matching a given set of keywords.

Example output (printing all the tests not expected to pass, and their
expected results, on a Mac):

$ webkit-patch print-expectations -x pass fast/html
For mac-snowleopard
fast/html/details-open4.html = TEXT
fast/html/details-open2.html = TEXT
fast/html/details-no-summary4.html = TEXT
fast/html/details-open-javascript.html = TEXT
$

You can also print full test-expectatons.txt lines using --full and a
CSV-style report (which can be useful for post-processing) using --csv.

It will replace the 'skipped-files' command (which will be
removed in a subsequent patch) and is a more general (and
cleaner and properly layered) solution.

Also add an update() command to MockOptions() to make overriding keywords easier.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationSerializer.to_string):
(TestExpectationSerializer):
(TestExpectationSerializer.to_csv):
(TestExpectationSerializer._format_result):
(TestExpectationLine.create_passing_expectation):
(TestExpectationsModel.get_test_set_for_keyword):
(TestExpectationsModel.has_keyword):
(TestExpectations.model):

  • Scripts/webkitpy/tool/commands/queries.py:

(execute):
(PrintExpectations):
(PrintExpectations.init):
(PrintExpectations.execute):
(PrintExpectations._filter_tests):
(PrintExpectations._format_lines):
(PrintExpectations._model):

  • Scripts/webkitpy/tool/commands/queries_unittest.py:

(TestPrintExpectations): Added.

  • Scripts/webkitpy/tool/mocktool.py:

(MockOptions):
(MockOptions.init):
(MockOptions.update): Added.

18:30 Changeset [113801] by dpranke@chromium.org

webkitpy: refactor handling of --platform and related options
https://bugs.webkit.org/show_bug.cgi?id=83525

Reviewed by Adam Barth.

This change moves to centralize handling of --platform, --debug,
--gtk, and other similar flags into a central place next to the
code that actually uses those flags in PortFactory to get the
right Port object.

  • Scripts/webkitpy/layout_tests/port/init.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:

(port_options):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

  • Scripts/webkitpy/tool/commands/queries.py:

(PrintBaselines.init):

18:24 Changeset [113800] by mrowe@apple.com

<rdar://problem/10583749> WebKit2 should log to both ASL and stderr

Source/WebKit2:

Replace direct calls to fprintf stderr with calls to WTFLogAlways.

Reviewed by Sam Weinig.

  • PluginProcess/mac/PluginProcessMainMac.mm:

(WebKit::PluginProcessMain):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::checkURLReceivedFromWebProcess):
(WebKit::WebProcessProxy::didReceiveInvalidMessage):

  • WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:

(WebKit::InjectedBundle::load):

  • WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm:

(readSandboxProfile):
(WKN_EnterSandbox):

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::initializeSandbox):

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain):

Source/WTF:

Reviewed by Sam Weinig.

  • wtf/Assertions.cpp: Add a WTFLogAlways function that unconditionally logs the given message.
  • wtf/Assertions.h:
18:19 FeatureFlags edited by tkent@chromium.org
Add ENCRYPTED_MEDIA (diff)
18:15 Changeset [113799] by commit-queue@webkit.org

Add transfer map argument to Intent constructor
http://dvcs.w3.org/hg/web-intents/raw-file/tip/spec/Overview.html
This adds the ability to pass transferables (i.e. MessagePorts)
through web intents, and puts the calling convention in line
with the Web Messaging spec:
http://dev.w3.org/html5/postmsg/

Implementation in chromium API follows the port-passing method
of PlatformMessagePortChannel.

https://bugs.webkit.org/show_bug.cgi?id=80200

Patch by Greg Billock <gbillock@google.com> on 2012-04-10
Reviewed by Adam Barth.

  • Modules/intents/Intent.cpp:

(WebCore::Intent::create):

  • Modules/intents/Intent.idl:
  • WebCore.gypi:
  • bindings/v8/custom/V8IntentCustom.cpp: Added.

(WebCore):
(WebCore::V8Intent::constructorCallback):

18:09 Changeset [113798] by paroga@webkit.org

Cleanup wtf/Platform.h and config.h files
https://bugs.webkit.org/show_bug.cgi?id=83431

Reviewed by Eric Seidel.

The ENABLE() and USE() macros take care about the case when the flag
isn't defined. So there is no need to define anything with 0.

Also move duplicated code from the config.h files to Platform.h and
merge a few preprocessor commands to make the file more readable.

Source/JavaScriptCore:

  • config.h:

Source/WebCore:

  • config.h:

Source/WTF:

  • config.h:
  • wtf/Platform.h:
17:56 Changeset [113797] by simonjam@chromium.org

[Chromium] Unreviewed gardening.

  • platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/forms/basic-textareas-expected.txt.
  • platform/chromium-mac/fast/forms/basic-textareas-expected.png:
  • platform/chromium-mac/fast/forms/basic-textareas-expected.txt:
  • platform/chromium/test_expectations.txt:
17:37 Changeset [113796] by fpizlo@apple.com

DFG should flush SetLocals to arguments
https://bugs.webkit.org/show_bug.cgi?id=83554

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

This is necessary to match baseline JIT argument capture behavior.

But to make this work right we need to have a story for arguments into
which we store values of different formats. This patch introduces the
notion of an ArgumentPosition - i.e. an argument in a particular inline
call frame - and forces unification of all data pertinent to selecting
the argument's data format.

Also fixed an amusing bug in the handling of OSR on SetLocals if there
was any insertion/deletion of nodes in the basic block. This is benign
for now but won't be eventually since the DFG is getting smarter. So
better fix it now.

Also fixed an amusing bug in the handling of OSR on SetLocals if they
are immediately followed by a Flush. I think this bug might have always
been there but now it'll happen more commonly, and it's covered by the
run-javascriptcore-tests.

(JSC::DFG::AbstractState::execute):

  • dfg/DFGArgumentPosition.h: Added.

(DFG):
(ArgumentPosition):
(JSC::DFG::ArgumentPosition::ArgumentPosition):
(JSC::DFG::ArgumentPosition::addVariable):
(JSC::DFG::ArgumentPosition::mergeArgumentAwareness):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::setArgument):
(InlineStackEntry):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGDoubleFormatState.h: Added.

(DFG):
(JSC::DFG::mergeDoubleFormatStates):
(JSC::DFG::mergeDoubleFormatState):
(JSC::DFG::doubleFormatStateToString):

  • dfg/DFGGraph.h:

(Graph):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGVariableAccessData.h:

(JSC::DFG::VariableAccessData::VariableAccessData):
(JSC::DFG::VariableAccessData::predict):
(JSC::DFG::VariableAccessData::argumentAwarePrediction):
(VariableAccessData):
(JSC::DFG::VariableAccessData::mergeArgumentAwarePrediction):
(JSC::DFG::VariableAccessData::doubleFormatState):
(JSC::DFG::VariableAccessData::shouldUseDoubleFormat):
(JSC::DFG::VariableAccessData::tallyVotesForShouldUseDoubleFormat):
(JSC::DFG::VariableAccessData::mergeDoubleFormatState):
(JSC::DFG::VariableAccessData::makePredictionForDoubleFormat):

Source/WTF:

Reviewed by Gavin Barraclough.

Added an isRoot() method that is a faster shorthand for saying
find() == this.

  • wtf/UnionFind.h:

(WTF::UnionFind::isRoot):
(UnionFind):

LayoutTests:

Rubber stamped by Gavin Barraclough.

Added a variety of tests for reassigning arguments prior to function.arguments
retrieval.

  • fast/js/dfg-inline-arguments-become-double-expected.txt: Added.
  • fast/js/dfg-inline-arguments-become-double.html: Added.
  • fast/js/dfg-inline-arguments-become-int32-expected.txt: Added.
  • fast/js/dfg-inline-arguments-become-int32.html: Added.
  • fast/js/dfg-inline-arguments-reset-changetype-expected.txt: Added.
  • fast/js/dfg-inline-arguments-reset-changetype.html: Added.
  • fast/js/dfg-inline-arguments-reset-expected.txt: Added.
  • fast/js/dfg-inline-arguments-reset.html: Added.
  • fast/js/script-tests/dfg-inline-arguments-become-double.js: Added.

(foo):
(bar):
(baz):
(argsToStr):

  • fast/js/script-tests/dfg-inline-arguments-become-int32.js: Added.

(foo):
(bar):
(baz):
(argsToStr):

  • fast/js/script-tests/dfg-inline-arguments-reset-changetype.js: Added.

(foo):
(bar):
(baz):
(argsToStr):

  • fast/js/script-tests/dfg-inline-arguments-reset.js: Added.

(foo):
(bar):
(baz):
(argsToStr):

17:17 Changeset [113795] by abarth@webkit.org

Source/WebCore: Limit -apple- and -khtml- to ENABLE(DASHBOARD_SUPPORT)
https://bugs.webkit.org/show_bug.cgi?id=83256

Reviewed by Eric Seidel.

As recommended by David Hyatt in
<https://lists.webkit.org/pipermail/webkit-dev/2010-July/013536.html>,
we should phase out support for -khtml- and -apple- vendor prefixes in
CSS (in favor of -webkit-).

As noted in <https://bugs.webkit.org/show_bug.cgi?id=42093#c29>, Dave's
proposal is a bit too agressive. These prefixes appear to be needed
for a number of dashboard widgets. For that reason, this patch limits
the prefixes to ENABLE(LEGACY_CSS_VENDOR_PREFIXES).

This patch enables ENABLE(LEGACY_CSS_VENDOR_PREFIXES) on apple-mac and
apple-win, which will let us learn whether removing these prefixes
causes a compatibility problem on the broader web.

  • Configurations/FeatureDefines.xcconfig:
  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::getCSSPropertyNamePrefix):
(WebCore::cssPropertyIDForJSCSSPropertyName):

  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:

(WebCore::cssPropertyInfo):

  • css/CSSParser.cpp:

(WebCore::cssPropertyID):

Source/WebKit/chromium: Limit -apple- and -khtml- to ENABLE(DASHBOARD_SUPPORT)
https://bugs.webkit.org/show_bug.cgi?id=83256

Reviewed by Eric Seidel.

  • features.gypi:

WebKitLibraries: Limit -apple- and -khtml- to ENABLE(DASHBOARD_SUPPORT)
https://bugs.webkit.org/show_bug.cgi?id=83256

Reviewed by Eric Seidel.

  • win/tools/vsprops/FeatureDefines.vsprops:

LayoutTests: Limit -apple- and -khtml- to ENABLE(LEGACY_CSS_VENDOR_PREFIXES)
https://bugs.webkit.org/show_bug.cgi?id=83256

Reviewed by Eric Seidel.

Skip these two tests, which are testing that -apple- and -khtml- vendor
prefixes work correctly.

  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
17:15 Changeset [113794] by adamk@chromium.org

Remove unused NonNullPassRefPtr from WTF
https://bugs.webkit.org/show_bug.cgi?id=82389

Reviewed by Kentaro Hara.

Source/JavaScriptCore:

  • JavaScriptCore.order: Remove nonexistent symbols referencing NonNullPassRefPtr.

Source/WTF:

NonNullPassRefPtr seems to be unused since JSC allocation was
restructured in r84052.

If someone decides they need this later, they can always revert this patch.

  • wtf/PassRefPtr.h:
  • wtf/RefPtr.h:

(RefPtr):

17:09 Changeset [113793] by yael.aharon@nokia.com

Unreviewed build fix after r113791.

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::WebGraphicsLayer):

16:44 Changeset [113792] by leviw@chromium.org

Clean up multiple RenderedPosition::absoluteRect definitions and correct LayoutUnit usage
https://bugs.webkit.org/show_bug.cgi?id=83604

Reviewed by Julien Chaffraix.

Removing unnecessary definitions of absoluteRect and replacing them with a single public
version that's more explicit about its contract.

Also correcting a LayoutUnit misuse, as rects in absolute coordinates should be returned
using integers, not LayoutUnits. See https://trac.webkit.org/wiki/LayoutUnit for details.

No new tests. No change in behavior.

  • editing/Editor.cpp:

(WebCore::Editor::firstRectForRange):

  • editing/RenderedPosition.cpp:

(WebCore::RenderedPosition::absoluteRect): Pixel snapping the local rect before converting
to absolute coordinates.

  • editing/RenderedPosition.h:

(RenderedPosition):

16:40 Changeset [113791] by yael.aharon@nokia.com

Initial support for fixed position elements in Qt WebKit2
https://bugs.webkit.org/show_bug.cgi?id=81786

Reviewed by Noam Rosenthal.

.:

  • ManualTests/fixed-position.html: Added.

Source/WebCore:

When the setting acceleratedCompositingForFixedPositionEnabled is true, we update
the position of fixed layers, and send updates to the UI process as we scroll.
Before painting, TextureMapperLayer receives a delta of the scroll positions between the UI
and the web processes, and adjusts its transform position accordingly.

  • page/FrameView.cpp:

(WebCore::FrameView::setFixedVisibleContentRect):

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::setScrollPositionDelta):
(WebCore):

  • platform/graphics/texmap/TextureMapperLayer.h:

(TextureMapperLayer):

Source/WebKit2:

Turn on the flag acceleratedCompositingForFixedPositionEnabled when using fixed layout.
As we scroll, we keep track of the delta in scroll position between the UI and web processes,
and adjust the position of all the fixed layers by that delta.
When WebLayerTreeRenderer receives a new scroll position from the web process, it keeps it as pending,
and commit the new scroll position in flushLayerChanges.
This patch does not address scrolling overshoot and it does not fix the wrong positioning
that occurs when we zoom. These issues will be addressed in future patches.

  • Shared/WebLayerTreeInfo.h:
  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPagePrivate::updateSize):

  • UIProcess/LayerTreeHostProxy.cpp:

(WebKit::LayerTreeHostProxy::setContentsSize):
(WebKit):
(WebKit::LayerTreeHostProxy::renderNextFrame):
(WebKit::LayerTreeHostProxy::didChangeScrollPosition):

  • UIProcess/LayerTreeHostProxy.h:

(LayerTreeHostProxy):

  • UIProcess/LayerTreeHostProxy.messages.in:
  • UIProcess/WebLayerTreeRenderer.cpp:

(WebKit::boundedScrollPosition):
(WebKit):
(WebKit::WebLayerTreeRenderer::paintToCurrentGLContext):
(WebKit::WebLayerTreeRenderer::setContentsSize):
(WebKit::WebLayerTreeRenderer::adjustPositionForFixedLayers):
(WebKit::WebLayerTreeRenderer::didChangeScrollPosition):
(WebKit::WebLayerTreeRenderer::syncLayerParameters):
(WebKit::WebLayerTreeRenderer::deleteLayer):
(WebKit::WebLayerTreeRenderer::flushLayerChanges):

  • UIProcess/WebLayerTreeRenderer.h:

(WebLayerTreeRenderer):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::WebGraphicsLayer):
(WebCore::WebGraphicsLayer::syncCompositingState):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:

(WebGraphicsLayerClient):
(WebCore::WebGraphicsLayer::fixedToViewport):
(WebCore::WebGraphicsLayer::setFixedToViewport):
(WebGraphicsLayer):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setResizesToContentsUsingLayoutSize):

  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::LayerTreeHostQt):
(WebKit::LayerTreeHostQt::didSyncCompositingStateForLayer):
(WebKit::updateOffsetFromViewportForSelf):
(WebKit):
(WebKit::updateOffsetFromViewportForLayer):
(WebKit::LayerTreeHostQt::syncFixedLayers):
(WebKit::LayerTreeHostQt::setVisibleContentsRect):

  • WebProcess/WebPage/qt/LayerTreeHostQt.h:

(LayerTreeHostQt):

16:34 Changeset [113790] by simonjam@chromium.org

[Chromium] Unreviewed gardening.

  • platform/chromium-linux/fast/multicol/cell-shrinkback-expected.png: Added.
  • platform/chromium-linux/scrollbars/scrollbars-on-positioned-content-expected.png:
  • platform/chromium-mac-leopard/fast/forms/basic-textareas-expected.png:
  • platform/chromium-mac-leopard/scrollbars/scrollbars-on-positioned-content-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/scrollbars/scrollbars-on-positioned-content-expected.png:
  • platform/chromium-mac/fast/overflow/hidden-scrollbar-resize-expected.txt: Removed.
  • platform/chromium-mac/scrollbars/scrollbars-on-positioned-content-expected.png:
  • platform/chromium-mac/scrollbars/scrollbars-on-positioned-content-expected.txt: Removed.
  • platform/chromium-win/fast/multicol/cell-shrinkback-expected.png: Added.
  • platform/chromium-win/fast/multicol/table-vertical-align-expected.txt:
  • platform/chromium-win/fast/overflow/hidden-scrollbar-resize-expected.txt:
  • platform/chromium-win/scrollbars/scrollbars-on-positioned-content-expected.png:
  • platform/chromium-win/scrollbars/scrollbars-on-positioned-content-expected.txt:
  • platform/chromium/test_expectations.txt:
16:16 Changeset [113789] by abarth@webkit.org

Remove empty directories.

16:10 Changeset [113788] by dpranke@chromium.org

Clone any baselines chromium is using from mac-leopard and mac-snowleopard into chromium dirs.
https://bugs.webkit.org/show_bug.cgi?id=83401

Unreviewed, baseline shuffling.

  • platform/chromium-mac-leopard/accessibility/aria-tables-expected.txt: Added.
  • platform/chromium-mac-leopard/accessibility/lists-expected.txt: Added.
  • platform/chromium-mac-leopard/accessibility/media-element-expected.txt: Added.
  • platform/chromium-mac-leopard/accessibility/table-attributes-expected.txt: Added.
  • platform/chromium-mac-leopard/accessibility/table-cell-spans-expected.txt: Added.
  • platform/chromium-mac-leopard/accessibility/table-cells-expected.txt: Added.
  • platform/chromium-mac-leopard/accessibility/table-detection-expected.txt: Added.
  • platform/chromium-mac-leopard/accessibility/table-sections-expected.txt: Added.
  • platform/chromium-mac-leopard/accessibility/table-with-rules-expected.txt: Added.
  • platform/chromium-mac-leopard/dom/xhtml/level3/core/documentgetinputencoding03-expected.png: Added.
  • platform/chromium-mac-leopard/dom/xhtml/level3/core/entitygetinputencoding02-expected.png: Added.
  • platform/chromium-mac-leopard/dom/xhtml/level3/core/entitygetxmlversion02-expected.png: Added.
  • platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri05-expected.png: Added.
  • platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri07-expected.png: Added.
  • platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri09-expected.png: Added.
  • platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri10-expected.png: Added.
  • platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri11-expected.png: Added.
  • platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri15-expected.png: Added.
  • platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri17-expected.png: Added.
  • platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri18-expected.png: Added.
  • platform/chromium-mac-leopard/dom/xhtml/level3/core/nodelookupnamespaceuri01-expected.png: Added.
  • platform/chromium-mac-leopard/dom/xhtml/level3/core/nodelookupprefix19-expected.png: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/paste-RTFD-expected.png: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/paste-TIFF-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/designmode-no-caret-expected.png: Added.
  • platform/chromium-mac-leopard/editing/spelling/grammar-expected.txt: Added.
  • platform/chromium-mac-leopard/editing/text-iterator/findString-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/backgrounds/animated-gif-as-background-expected.png: Added.
  • platform/chromium-mac-leopard/fast/backgrounds/solid-color-context-restore-expected.png: Added.
  • platform/chromium-mac-leopard/fast/canvas/fill-stroke-clip-reset-path-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/color-correction-on-box-shadow-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/color-correction-on-text-shadow-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/disabled-author-styles-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/font-weight-1-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/outline-auto-empty-rects-expected.png: Added.
  • platform/chromium-mac-leopard/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png: Added.
  • platform/chromium-mac-leopard/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
  • platform/chromium-mac-leopard/fast/dom/gc-10-expected.png: Added.
  • platform/chromium-mac-leopard/fast/events/keydown-1-expected.png: Added.
  • platform/chromium-mac-leopard/fast/fast-mobile-scrolling/fixed-position-element-expected.png: Added.
  • platform/chromium-mac-leopard/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.png: Added.
  • platform/chromium-mac-leopard/fast/frames/flattening/frameset-flattening-advanced-expected.png: Added.
  • platform/chromium-mac-leopard/fast/frames/flattening/frameset-flattening-grid-expected.png: Added.
  • platform/chromium-mac-leopard/fast/frames/flattening/frameset-flattening-simple-expected.png: Added.
  • platform/chromium-mac-leopard/fast/frames/flattening/frameset-flattening-subframe-resize-expected.png: Added.
  • platform/chromium-mac-leopard/fast/frames/flattening/frameset-flattening-subframesets-expected.png: Added.
  • platform/chromium-mac-leopard/fast/frames/flattening/iframe-flattening-fixed-height-expected.png: Added.
  • platform/chromium-mac-leopard/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.png: Added.
  • platform/chromium-mac-leopard/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.png: Added.
  • platform/chromium-mac-leopard/fast/frames/flattening/iframe-flattening-fixed-width-expected.png: Added.
  • platform/chromium-mac-leopard/fast/frames/flattening/iframe-flattening-offscreen-expected.png: Added.
  • platform/chromium-mac-leopard/fast/frames/flattening/iframe-flattening-simple-expected.png: Added.
  • platform/chromium-mac-leopard/fast/frames/inline-object-inside-frameset-expected.png: Added.
  • platform/chromium-mac-leopard/fast/images/pdf-as-image-landscape-expected.png: Added.
  • platform/chromium-mac-leopard/fast/reflections/inline-crash-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/fixed-child-move-after-scroll-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/fixed-move-after-scroll-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-in-scrolled-clipped-block-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/rel-positioned-inline-with-overflow-expected.png: Added.
  • platform/chromium-mac-leopard/fast/replaced/pdf-as-image-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/empty-section-crash-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/font-initial-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/text/international/bidi-neutral-run-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/text/international/bold-bengali-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/international/thai-baht-space-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/text/whitespace/normal-after-nowrap-breaking-expected.png: Added.
  • platform/chromium-mac-leopard/fast/writing-mode/border-vertical-lr-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/writing-mode/japanese-lr-selection-expected.png: Added.
  • platform/chromium-mac-leopard/fast/writing-mode/japanese-rl-selection-expected.png: Added.
  • platform/chromium-mac-leopard/http/tests/inspector/console-websocket-error-expected.txt: Added.
  • platform/chromium-mac-leopard/http/tests/misc/favicon-as-image-expected.png: Added.
  • platform/chromium-mac-leopard/http/tests/misc/slow-loading-image-in-pattern-expected.png: Added.
  • platform/chromium-mac-leopard/http/tests/misc/slow-loading-mask-expected.png: Added.
  • platform/chromium-mac-leopard/http/tests/navigation/error404-goback-expected.png: Added.
  • platform/chromium-mac-leopard/http/tests/navigation/error404-subframeload-expected.png: Added.
  • platform/chromium-mac-leopard/java/lc3/JavaObject/JavaObjectToDouble-001-expected.txt: Added.
  • platform/chromium-mac-leopard/media/video-replaces-poster-expected.png: Added.
  • platform/chromium-mac-leopard/platform/mac/editing/input/devanagari-ligature-expected.txt: Added.
  • platform/chromium-mac-leopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Added.
  • platform/chromium-mac-leopard/platform/mac/fast/loader/file-url-mimetypes-3-expected.txt: Added.
  • platform/chromium-mac-leopard/platform/mac/fast/loader/file-url-mimetypes-expected.txt: Added.
  • platform/chromium-mac-leopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
  • platform/chromium-mac-leopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_500/S7.6_A3.1-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_500/S7.6_A3.2-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_500/S7.6_A5.3_T1-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_500/S7.6_A5.3_T2-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S15.5.4.16_A1-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S15.5.4.18_A1-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A1.1_T1-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A1.1_T2-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A1.1_T4-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A2.2_T1-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A2.2_T2-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A2.3-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A5.2_T1-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A5.2_T2-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A5.2_T4-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A5.2_T7-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A5.2_T8-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A5.2_T9-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/custom/image-with-prefix-in-webarchive-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/style-attribute-font-size-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dom/SVGTransformList-basics-expected.png: Added.
  • platform/chromium-mac-leopard/svg/hixie/error/012-expected.png: Added.
  • platform/chromium-mac-leopard/svg/hixie/error/012-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/hixie/mixed/007-expected.png: Added.
  • platform/chromium-mac-leopard/svg/text/font-size-below-point-five-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
  • platform/chromium-mac-leopard/svg/webarchive/svg-cursor-subresources-expected.png: Added.
  • platform/chromium-mac-leopard/svg/webarchive/svg-feimage-subresources-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/core/captions1-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/core/captions2-expected.png: Added.
  • platform/chromium-mac-leopard/transforms/2d/zoom-menulist-expected.png: Added.
  • platform/chromium-mac-leopard/transforms/3d/general/perspective-units-expected.png: Added.
  • platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-2-expected.png: Added.
  • platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Added.
  • platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png: Added.
  • platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-expected.png: Added.
  • platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png: Added.
  • platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.png: Added.
  • platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/masks/layer-mask-placement-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/video/video-background-color-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t1202-counter-09-b-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css2.1/t1202-counters-09-b-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/images/cross-fade-background-size-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/images/cross-fade-blending-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/images/cross-fade-simple-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/images/cross-fade-sizing-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-TIFF-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/canvas/set-colors-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/images/pdf-as-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/span/generated-child-split-flow-crash-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/preloader/document-write-2-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/preloader/document-write-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/regions/region-overflow-break-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/regions/region-overflow-break-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/fallback-traits-fixup-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/hyphenate-character-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/hyphenate-limit-before-after-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/hyphenate-limit-lines-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/hyphenate-limit-lines-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/hyphenate-locale-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/hyphens-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-AN-after-empty-run-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-AN-after-empty-run-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-neutral-run-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-neutral-run-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bold-bengali-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bold-bengali-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/khmer-selection-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/midword-break-before-surrogate-pair-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/midword-break-before-surrogate-pair-2-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/whitespace/normal-after-nowrap-breaking-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/mac/compositing/canvas/accelerated-canvas-compositing-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/mac/editing/selection/25228-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-3-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/mac/fast/text/combining-character-sequence-fallback-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/mac/fast/text/combining-character-sequence-fallback-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/mac/fast/text/line-break-locale-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/mac/fast/text/line-break-locale-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/mac/scrollbars/key-window-not-first-responder-expected.png: Added.
  • platform/chromium-mac-snowleopard/printing/compositing-layer-printing-expected.png: Added.
  • platform/chromium-mac-snowleopard/printing/media-queries-print-expected.png: Added.
  • platform/chromium-mac-snowleopard/printing/page-rule-in-media-query-expected.png: Added.
  • platform/chromium-mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt: Added.
  • platform/chromium-mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Added.
  • platform/chromium-mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Added.
  • platform/chromium-mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/custom/image-with-prefix-in-webarchive-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/style-attribute-font-size-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/transform-with-shadow-and-gradient-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dom/SVGLocatable-getCTM-svg-root-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dom/SVGTransformList-basics-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGAElement-dom-href-attr-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGAElement-dom-target-attr-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGAElement-svgdom-href-prop-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGAElement-svgdom-target-prop-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/sourceAlpha-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/error/012-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/mixed/007-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/viewbox/001-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/viewbox/002-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/text/non-bmp-positioning-lists-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/text/text-intro-05-t-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/webarchive/svg-cursor-subresources-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/webarchive/svg-feimage-subresources-expected.png: Added.
  • platform/chromium-mac-snowleopard/transforms/2d/hindi-rotated-expected.png: Added.
  • platform/chromium-mac-snowleopard/transforms/3d/general/perspective-units-expected.png: Added.
  • platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png: Added.
  • platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-expected.png: Added.
  • platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png: Added.
  • platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png: Added.
  • platform/chromium-mac-snowleopard/webarchive/adopt-attribute-styled-body-webarchive-expected.png: Added.
  • platform/chromium-mac-snowleopard/webarchive/test-css-url-resources-in-stylesheets-expected.png: Added.
  • platform/chromium-mac-snowleopard/webarchive/test-link-rel-icon-beforeload-expected.png: Added.
15:59 Changeset [113787] by ojan@chromium.org

Add a chromeless view to the individual tests view
https://bugs.webkit.org/show_bug.cgi?id=83541

Reviewed by Daniel Bates.

This is the view suitable to inlining in other contexts (e.g. garden-o-matic).

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:

(testHtmlForIndividualTestOnAllBuilders):
(testHtmlForIndividualTestOnAllBuildersWithChromeNonexistant):
(testHtmlForIndividualTestOnAllBuildersWithChrome):
(testHtmlForIndividualTestOnAllBuildersWithChromeWebkitMaster):
(testHtmlForIndividualTests):
(htmlEscape):
(runTests):

15:59 Changeset [113786] by rakuco@webkit.org

[CMake] Do not pass -P to the preprocessor when running make_names.pl.
https://bugs.webkit.org/show_bug.cgi?id=83225

Reviewed by Rob Buis.

This is necessary to make CMake-based ports build with the
recently-released GCC 4.7.0, whose preprocessor seems to ignore
empty lines when -P is passed to it. Such behavior breaks
make_names.pl (in fact, InFilesParser.pm), which expects an empty
line to separate common and specific sections in .in files.

A fix for this same problem has been supposedly done in r84123,
but as the CMake-based ports always pass --preprocessor to the
Perl tools the fix never reached us.

The idea is to define CODE_GENERATOR_PREPROCESSOR_WITH_LINEMARKERS
for (!MSVC && !QNX) and use it in the macros which call
make_names.pl.

  • Source/cmake/OptionsCommon.cmake:
  • Source/cmake/WebKitMacros.cmake:
15:52 Changeset [113785] by tomz@codeaurora.org

Unreviewed update to test expectations

  • platform/efl/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
  • platform/win/test_expectations.txt:
15:41 Changeset [113784] by simonjam@chromium.org

[Chromium] Fix test_expectations.txt from r113776.

  • platform/chromium/test_expectations.txt:
15:39 Changeset [113783] by commit-queue@webkit.org

Web Inspector: CodeGeneratorInspector.py: do not expose raw methods from generated types
https://bugs.webkit.org/show_bug.cgi?id=83390

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-04-10
Reviewed by Yury Semikhatsky.

Intermediate classes InspectorObjectBase and InspectorArrayBase are created. They have all raw methos
protected. InspectorObject and InspectorArray now inherit the corresponding base classes with exposing
all their protected methods.

"Open types" are left inheriting from InspectorObject, plus field name constants are generated for
an easy random access to all properties.

All the client code is fixed to use type-safe API rather than raw access methods in function parameter
and return types and bodies.

  • inspector/CodeGeneratorInspector.py:

(RawTypes.Object):
(RawTypes.Object.get_setter_name):
(RawTypes.Array):
(RawTypes.Array.get_setter_name):
(TypeBindings.create_type_declaration_.ClassBinding.get_code_generator.CodeGenerator.generate_type_builder):
(Array):
(Generator):
(Generator.resolve_type_and_generate_ad_hoc.InterfaceGenerateContext):
(Generator.process_types.GenerateContext):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::querySelectorAll):
(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::buildObjectForEventListener):

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::descriptionForDOMEvent):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::didPause):

  • inspector/InspectorPageAgent.cpp:

(WebCore::buildObjectForSearchResult):
(WebCore::InspectorPageAgent::searchInResources):
(WebCore::InspectorPageAgent::buildObjectForFrameTree):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::didReceiveResponse):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::fillMediaListChain):
(WebCore::InspectorStyle::styleWithProperties):

  • inspector/InspectorValues.cpp:

(WebCore::InspectorObjectBase::~InspectorObjectBase):
(WebCore::InspectorObjectBase::asObject):
(WebCore::InspectorObjectBase::openAccessors):
(WebCore):
(WebCore::InspectorObjectBase::getBoolean):
(WebCore::InspectorObjectBase::getString):
(WebCore::InspectorObjectBase::getObject):
(WebCore::InspectorObjectBase::getArray):
(WebCore::InspectorObjectBase::get):
(WebCore::InspectorObjectBase::remove):
(WebCore::InspectorObjectBase::writeJSON):
(WebCore::InspectorObjectBase::InspectorObjectBase):
(WebCore::InspectorArrayBase::~InspectorArrayBase):
(WebCore::InspectorArrayBase::asArray):
(WebCore::InspectorArrayBase::writeJSON):
(WebCore::InspectorArrayBase::InspectorArrayBase):
(WebCore::InspectorArrayBase::get):

  • inspector/InspectorValues.h:

(InspectorObjectBase):
(InspectorObject):
(WebCore::InspectorObject::create):
(WebCore):
(InspectorArrayBase):
(WebCore::InspectorArrayBase::length):
(InspectorArray):
(WebCore::InspectorArray::create):
(WebCore::InspectorObjectBase::find):
(WebCore::InspectorObjectBase::setBoolean):
(WebCore::InspectorObjectBase::setNumber):
(WebCore::InspectorObjectBase::setString):
(WebCore::InspectorObjectBase::setValue):
(WebCore::InspectorObjectBase::setObject):
(WebCore::InspectorObjectBase::setArray):
(WebCore::InspectorArrayBase::pushBoolean):
(WebCore::InspectorArrayBase::pushInt):
(WebCore::InspectorArrayBase::pushNumber):
(WebCore::InspectorArrayBase::pushString):
(WebCore::InspectorArrayBase::pushValue):
(WebCore::InspectorArrayBase::pushObject):
(WebCore::InspectorArrayBase::pushArray):

  • inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createGenericRecord):

15:37 Changeset [113782] by commit-queue@webkit.org

[Chromium] defaultDeviceScaleFactor != 0 should set deviceScaleFactor = defaultDeviceScaleFactor in the absence of a viewport tag for debugging purposes
https://bugs.webkit.org/show_bug.cgi?id=82757

Patch by Tim Dresser <tdresser@chromium.org> on 2012-04-10
Reviewed by Darin Fisher.

If there is no viewport tag, the deviceScaleFactor is set to the defaultDeviceScaleFactor.
Tested by: WebFrameTest.DeviceScaleFactorUsesDefaultWithoutViewportTag.

  • src/ChromeClientImpl.cpp:

(WebKit):
(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):

  • tests/WebFrameTest.cpp:

(WebKit):
(FixedLayoutTestWebViewClient):
(WebKit::TEST_F):

  • tests/data/no_viewport_tag.html: Added.
15:36 Changeset [113781] by pdr@google.com

Remove unnecessary calls to RenderSVGShape::createShape()
https://bugs.webkit.org/show_bug.cgi?id=83598

Reviewed by Rob Buis.

RenderSVGShape::strokeContains contains calls to fall back to path stroke hit detection
in several cases (dashed strokes, for example). One of these cases, a check for isStyled,
is not needed and is always true for Ellipses, Circles, and Rects (all styled elements).
This change removes the check for isStyled.

No new tests as this only affects performance, not test results.

  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::strokeContains):

15:33 Changeset [113780] by mitz@apple.com

<rdar://problem/10912486> CanvasRenderingContext2D does not expose its backing store resolution
https://bugs.webkit.org/show_bug.cgi?id=83619

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/canvas/2d.backingStorePixelRatio.html

Added a backingStorePixelRatio attribute to CanvasRenderingContext2D, as proposed in
<http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-March/035112.html>. The attribute
is prefixed with “webkit” for now.

  • html/HTMLCanvasElement.h:

(WebCore::HTMLCanvasElement::deviceScaleFactor): Added this getter.

  • html/canvas/CanvasRenderingContext2D.h:

(WebCore::CanvasRenderingContext2D::webkitBackingStorePixelRatio): Added. Returns the canvas
element’s device scale factor.
(CanvasRenderingContext2D):

  • html/canvas/CanvasRenderingContext2D.idl: Added webkitBackingStorePixelRatio as a

read-only attribute.

LayoutTests:

  • fast/canvas/2d.backingStorePixelRatio-expected.txt: Added.
  • fast/canvas/2d.backingStorePixelRatio.html: Added.
  • platform/mac/fast/canvas/2d.backingStorePixelRatio-expected.txt: Added.
  • platform/win/fast/canvas/2d.backingStorePixelRatio-expected.txt: Added.
15:26 Changeset [113779] by rakuco@webkit.org

[EFL][DRT] Top level SVG rebaselines
https://bugs.webkit.org/show_bug.cgi?id=83585

Unreviewed, EFL rebaseline.

Landing bug 83562 enables us to do a bigger rebaselining and
unskipping of EFL SVG testcases. This is part one.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-10

  • platform/efl/Skipped:
  • platform/efl/svg/as-object/object-box-sizing-no-width-height-expected.png: Added.
  • platform/efl/svg/as-object/object-box-sizing-no-width-height-expected.txt: Added.
  • platform/efl/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
  • platform/efl/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
  • platform/efl/svg/dom/SVGPathSegList-cloning-expected.png: Added.
  • platform/efl/svg/dom/SVGPathSegList-cloning-expected.txt: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.txt: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.txt: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.txt: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.txt: Added.
15:24 Changeset [113778] by commit-queue@webkit.org

Segmentation fault in JS drop-down menus in facebook.com
https://bugs.webkit.org/show_bug.cgi?id=82896

Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2012-04-10
Reviewed by Chris Fleizach.

Make sure changes introduced with r110819 affect to the Mac
platform only, since they depend on platform specific behaviour,
as not all the platforms treat attachments in the same way.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::updateChildrenIfNecessary):

  • accessibility/AccessibilityObject.h:

(AccessibilityObject):
(WebCore::AccessibilityObject::detachFromParent):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore):
(WebCore::AccessibilityRenderObject::addChildren):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

  • accessibility/mac/AccessibilityObjectMac.mm:

(WebCore::AccessibilityObject::detachFromParent):
(WebCore):

15:18 Changeset [113777] by andersca@apple.com

Fix fast/images/exif-orientation.html WebKitTestRunner failure
https://bugs.webkit.org/show_bug.cgi?id=83627

Reviewed by Sam Weinig.

Handle overriding the WebKitShouldRespectImageOrientation preference.

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

15:17 Changeset [113776] by jer.noble@apple.com

Layout Test webaudio/* is flaky
https://bugs.webkit.org/show_bug.cgi?id=83624

Add failing tests to skipped list.

  • platform/chromium/test_expectations.txt:
15:15 Changeset [113775] by dpranke@chromium.org

remove 'win' from chromium-win, chromium-linux fallback paths
https://bugs.webkit.org/show_bug.cgi?id=83613

Reviewed by Ojan Vafai.

The chromium ports no longer need to look at the apple 'win'
directory for baseline results.

Also remove the old '-gpu-' entries from the flakiness dashboard
map since I'm touching lines nearby.

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:

(ChromiumLinuxPort):

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:

(ChromiumWinPort):

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
14:57 Changeset [113774] by kling@webkit.org

REGRESSION(r113588): 15-30% perf. regression on CSS/CSSPropertySetterGetter.
<http://webkit.org/b/83540>

Reviewed by Antti Koivisto.

Changed the behavior of getPropertyCSSValueInternal() to actually return the internal
value rather than a cloned one. There is an assertion in the CSSValue bindings that
will catch anyone trying to expose these values to the web.

This avoids constructing "safe" CSSValue objects in the bindings layer, for the cases
where we only want to extract the cssText or numeric value. These cloned objects are
only needed when exposing fully-fledged CSSValues to the web, which must be tied to
a single document.

  • css/CSSStyleDeclaration.h:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValueInternal):

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal):

14:52 Changeset [113773] by noam.rosenthal@nokia.com

[Qt][WK2] Manage graphics buffers in the web process
https://bugs.webkit.org/show_bug.cgi?id=78675

Source/WebCore:

Added WebCore::GraphicsSurface, a wrapper class to a platform-dependant
surface that can be accessed efficiently by both the CPU and the GPU.
This will allow fast texture uploads for WebKit2, and in the future
fast copies for 2D canvas and WebGL.
The first implementation is for Mac using IOSurfaces.

TextureMapperGL had to be modified to use GL_UNSIGNED_INT_8_8_8_8_REV
for textures on Mac, since that's the native pixel format of BGRA
IOSurfaces.

Though this feature is not written in a Qt-specific way, it's currently
only enabled for Qt and is protected by USE(GRAPHICS_SURFACE).

Reviewed by Kenneth Rohde Christiansen.

Covered by existing API tests.

  • Target.pri:
  • WebCore.pri:
  • platform/graphics/surfaces/GraphicsSurface.cpp: Added.
  • platform/graphics/surfaces/GraphicsSurface.h: Added.
  • platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp: Added.
  • platform/graphics/surfaces/qt/GraphicsSurfaceQt.cpp: Added.

(WebCore::GraphicsSurface::didReleaseImage):
(WebCore):
(WebCore::GraphicsSurface::platformBeginPaint):
(WebCore::GraphicsSurface::createReadOnlyImage):

  • platform/graphics/texmap/TextureMapper.h:

(WebCore::BitmapTexture::isOpenGLBacked):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::toBitmapTextureGL):
(WebCore):
(WebCore::BitmapTextureGL::didReset):
(WebCore::BitmapTextureGL::updateContents):

  • platform/graphics/texmap/TextureMapperGL.h:

(WebCore::BitmapTextureGL::isOpenGLBacked):
(WebCore):

Source/WebKit2:

Added ShareableSurface, a class allowing the use of GPU-enabled
surfaces for bitmap transfer between the web and UI processes.
Since GraphicsSurfaces may not always be available, ShareableSurface
uses a standard ShareableBitmap as a fallback backend.

The necessary plumbing was added in WebKit2 for passing updates via
ShareableSurfaces instead of ShareableBitmaps. SurfaceUpdateInfo was
added, as to not make UpdateInfo more complicated.

Reviewed by Kenneth Rohde Christiansen.

  • Shared/ShareableSurface.cpp: Added.
  • Shared/ShareableSurface.h: Added.
  • Shared/SurfaceUpdateInfo.cpp: Added.
  • Shared/SurfaceUpdateInfo.h: Added.
  • Target.pri:
  • UIProcess/LayerTreeHostProxy.cpp:

(WebKit::LayerTreeHostProxy::createTileForLayer):
(WebKit::LayerTreeHostProxy::updateTileForLayer):

  • UIProcess/LayerTreeHostProxy.h:

(LayerTreeHostProxy):

  • UIProcess/LayerTreeHostProxy.messages.in:
  • UIProcess/WebLayerTreeRenderer.cpp:

(WebKit::WebLayerTreeRenderer::updateTile):

  • UIProcess/WebLayerTreeRenderer.h:

(TileUpdate):
(WebKit::WebLayerTreeRenderer::TileUpdate::TileUpdate):

  • UIProcess/qt/LayerBackingStore.cpp:

(WebKit::LayerBackingStoreTile::swapBuffers):
(WebKit::LayerBackingStoreTile::setBackBuffer):
(WebKit::LayerBackingStore::updateTile):

  • UIProcess/qt/LayerBackingStore.h:

(LayerBackingStoreTile):
(LayerBackingStore):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::beginContentUpdate):
(WebCore::WebGraphicsLayer::createTile):
(WebCore::WebGraphicsLayer::updateTile):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:

(WebGraphicsLayerClient):
(WebGraphicsLayer):

  • WebProcess/WebPage/TiledBackingStoreRemoteTile.cpp:

(WebKit::TiledBackingStoreRemoteTile::updateBackBuffer):

  • WebProcess/WebPage/TiledBackingStoreRemoteTile.h:

(WebKit):
(TiledBackingStoreRemoteTileClient):

  • WebProcess/WebPage/UpdateAtlas.cpp:

(WebKit::UpdateAtlas::UpdateAtlas):
(WebKit::UpdateAtlas::beginPaintingOnAvailableBuffer):

  • WebProcess/WebPage/UpdateAtlas.h:

(WebKit::UpdateAtlas::surface):
(WebKit::UpdateAtlas::size):

  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::createTile):
(WebKit::LayerTreeHostQt::updateTile):
(WebKit::LayerTreeHostQt::beginContentUpdate):

  • WebProcess/WebPage/qt/LayerTreeHostQt.h:

(LayerTreeHostQt):

Tools:

Enable graphics surfaces on Mac for Qt.

Reviewed by Kenneth Rohde Christiansen.

  • qmake/mkspecs/features/features.prf:
14:52 Changeset [113772] by andersca@apple.com

Add fast/dom/inline-event-attributes-release.html to the Skipped list.

  • platform/mac/Skipped:
14:45 Changeset [113771] by commit-queue@webkit.org

Web Inspector: split nodes and edges array in heap profiler serialization.
https://bugs.webkit.org/show_bug.cgi?id=83465

Frontend is now able to read format when nodes and edges arrive
in two separate arrays.

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-04-10
Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotLoader.prototype._parseIntArray):
(WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
(WebInspector.HeapSnapshot):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):

LayoutTests:

  • inspector/profiler/heap-snapshot-loader-expected.txt:
  • inspector/profiler/heap-snapshot-loader.html:
  • inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotSplitNodesEdgesMockRaw):

14:41 Changeset [113770] by commit-queue@webkit.org

CSS box-shadow default color should be something other than transparent
https://bugs.webkit.org/show_bug.cgi?id=58511

Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-04-10
Reviewed by Simon Fraser.

Source/WebCore:

If box-shadow or text-shadow color is not specified, color defaults to
the value specified in the 'color' property of the element (as specified in W3C
spec).

Test: fast/text/text-shadow-no-default-color.html. Also existing
tests ietestcenter/css3/box-shadow-002 and ietestcenter/css3/box-shadow-003

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

LayoutTests:

Added new test for the case where no color is specified for text
shadow. This test and two others are marked as expected fail pending
rebaseline.

  • fast/text/text-shadow-no-default-color.html: Added.
  • platform/chromium/test_expectations.txt:
14:28 Changeset [113769] by crogers@google.com

AudioParam must support connections from audio-rate signals
https://bugs.webkit.org/show_bug.cgi?id=83524

Source/WebCore:

Reviewed by Eric Carlson.

In the Web Audio API, it's possible to connect one AudioNode to another AudioNode.
Similary we should allow an AudioNode to connect to an AudioParam, thus controlling
a parameter with an audio-rate signal. This is important in many audio processing
applications.

Test: webaudio/audioparam-connect-audioratesignal.html

Simple method name change of AudioParam::hasTimelineValues() to AudioParam::hasSampleAccurateValues().

  • Modules/webaudio/AudioGainNode.cpp:

(WebCore::AudioGainNode::process):

  • Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::connect): Add connect() method from AudioNode -> AudioParam.
(WebCore):
(WebCore::AudioNode::disconnect):
(WebCore::AudioNode::finishDeref):
Use AudioNodeOutput::disconnectAll() instead of AudioNodeOutput::disconnectAllInputs().

  • Modules/webaudio/AudioNode.h: Add connect() method from AudioNode -> AudioParam.

(WebCore):
(AudioNode):

  • Modules/webaudio/AudioNode.idl: Add connect() method from AudioNode -> AudioParam.

Implement support for an AudioNodeOutput to fanout to multiple AudioParams.

  • Modules/webaudio/AudioNodeOutput.cpp:

(WebCore::AudioNodeOutput::AudioNodeOutput):
(WebCore::AudioNodeOutput::updateRenderingState): Update rendering state related to AudioParams.
(WebCore::AudioNodeOutput::pull): pull() must now take into account fanout to AudioParams for in-place processing.
(WebCore::AudioNodeOutput::fanOutCount):
(WebCore):
(WebCore::AudioNodeOutput::paramFanOutCount): New method keeping track of number of connections to AudioParams.
(WebCore::AudioNodeOutput::renderingParamFanOutCount): New method keeping track of number of connections to AudioParams for rendering.
(WebCore::AudioNodeOutput::addParam): Add a connection to an AudioParam.
(WebCore::AudioNodeOutput::removeParam): Remove a connection to an AudioParam.
(WebCore::AudioNodeOutput::disconnectAllParams): Remove all connections to AudioParams.
(WebCore::AudioNodeOutput::disconnectAll): New method to disconnect all AudioNodeInputs and AudioParams.

  • Modules/webaudio/AudioNodeOutput.h:

(AudioNodeOutput):

Allow an AudioParam to accept a connection from an AudioNodeOutput, thus being controlled
by an audio-rate signal.

  • Modules/webaudio/AudioParam.cpp:

(WebCore::AudioParam::calculateSampleAccurateValues): Calculates sample-accurate values from timeline or an AudioNode.
(WebCore):
(WebCore::AudioParam::calculateAudioRateSignalValues): Calculates sample-accurate values from an AudioNode.
(WebCore::AudioParam::calculateTimelineValues): Calculates sample-accurate values scheduled on the timeline.
(WebCore::AudioParam::connect): Connect from an AudioNodeOutput for control from an audio-rate signal.
(WebCore::AudioParam::disconnect): Disconnect from an AudioNodeOutput.

  • Modules/webaudio/AudioParam.h:

(WebCore):
(WebCore::AudioParam::AudioParam):
(WebCore::AudioParam::hasSampleAccurateValues): Change name from hasTimelineValues() and return true
either if we have timeline values or if we've been connected from an AudioNode.
(AudioParam):

Simple method name change of AudioParam::hasTimelineValues() to AudioParam::hasSampleAccurateValues().

  • Modules/webaudio/Oscillator.cpp:

(WebCore::Oscillator::calculateSampleAccuratePhaseIncrements):
(WebCore::Oscillator::process):

LayoutTests:

Reviewed by Eric Carlson.

  • webaudio/audioparam-connect-audioratesignal-expected.txt: Added.
  • webaudio/audioparam-connect-audioratesignal.html: Added.
  • webaudio/resources/audio-testing.js:

(createLinearRampBuffer):
(createConstantBuffer):

14:25 Changeset [113768] by leviw@chromium.org

Fix that mirrors the change from Bug 83604. Cleaning up RenderedPosition::absoluteRect and its usage in Editor.

14:16 Changeset [113767] by paroga@webkit.org

[CMake][WIN] Add /MP flag when using a compiler with support for it
https://bugs.webkit.org/show_bug.cgi?id=83577

Reviewed by Daniel Bates.

  • Source/cmake/OptionsWindows.cmake:
14:14 Changeset [113766] by paroga@webkit.org

[CMake] Add missing DERIVED_SOURCES_WEBKIT_DIR variable
https://bugs.webkit.org/show_bug.cgi?id=83573

Reviewed by Daniel Bates.

We need this variable when ports want to generate files in the WebKit target.

  • CMakeLists.txt:
14:12 Changeset [113765] by darin@apple.com

Remove unused data member from Lexer class
https://bugs.webkit.org/show_bug.cgi?id=83429

Reviewed by Kentaro Hara.

I noticed that m_delimited was "write-only", so I deleted it.

  • parser/Lexer.cpp:

(JSC::Lexer::setCode): Removed code to set m_delimited.
(JSC::Lexer::parseIdentifier): Ditto.
(JSC::Lexer::parseIdentifierSlowCase): Ditto.
(JSC::Lexer::lex): Ditto.

  • parser/Lexer.h: Deleted m_delimited.
14:07 Changeset [113764] by paroga@webkit.org

[CMake] Enable USE_FOLDERS property
https://bugs.webkit.org/show_bug.cgi?id=83571

Reviewed by Daniel Bates.

.:

Setting the FOLDER property on targets gives more structure
to the generated Visual Studio solutions.
This does not affect other CMake generators.

  • Source/cmake/OptionsCommon.cmake:

Source/JavaScriptCore:

Setting the FOLDER property on targets gives more structure
to the generated Visual Studio solutions.
This does not affect other CMake generators.

  • CMakeLists.txt:
  • shell/CMakeLists.txt:

Source/WebCore:

Setting the FOLDER property on targets gives more structure
to the generated Visual Studio solutions.
This does not affect other CMake generators.

  • CMakeLists.txt:

Source/WebKit:

Setting the FOLDER property on targets gives more structure
to the generated Visual Studio solutions.
This does not affect other CMake generators.

  • CMakeLists.txt:

Source/WebKit2:

Setting the FOLDER property on targets gives more structure
to the generated Visual Studio solutions.
This does not affect other CMake generators.

  • CMakeLists.txt:

Source/WTF:

Setting the FOLDER property on targets gives more structure
to the generated Visual Studio solutions.
This does not affect other CMake generators.

  • wtf/CMakeLists.txt:

Tools:

Setting the FOLDER property on targets gives more structure
to the generated Visual Studio solutions.
This does not affect other CMake generators.

  • DumpRenderTree/efl/CMakeLists.txt:
  • EWebLauncher/CMakeLists.txt:
  • WinCELauncher/CMakeLists.txt:
14:05 Changeset [113763] by commit-queue@webkit.org

[CMake] CMake SVG Code Generation fails to generate code for extra defines
https://bugs.webkit.org/show_bug.cgi?id=83562

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-10
Reviewed by Rob Buis.

Fixing CMakeLists.txt to generate correct extra defines for SVG code generator.

  • CMakeLists.txt:
13:52 Changeset [113762] by lforschler@apple.com

Versioning.

13:50 Changeset [113761] by lforschler@apple.com

New tag.

13:40 BuildBot edited by rniwa@webkit.org
Update non-cygwin Windows instruction (diff)
13:34 Changeset [113760] by eae@chromium.org

chromium/linux and apple/win build fixes for branch.

13:32 Changeset [113759] by inferno@chromium.org

Crash due to captions list not updated after section recalc.
https://bugs.webkit.org/show_bug.cgi?id=83552

Reviewed by Julien Chaffraix.

Source/WebCore:

Test: fast/table/table-caption-not-removed-crash.html

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::addChild): no need to set the need for
section recalc. It was needed in old code when we had more than
one caption and we need to call section recalc to destroy the other
captions.
(WebCore::RenderTable::recalcSections): need to rebuild captions list.
This is how the old code worked before r100177. Basically, children can
moved without calling RenderTable::removeChild, so we should depend on
recalcSections to update our captions list. Also, fix a style nit of aligning
case labels with the switch statement.

LayoutTests:

  • fast/table/table-caption-not-removed-crash-expected.txt: Added.
  • fast/table/table-caption-not-removed-crash.html: Added.
13:09 Changeset [113758] by senorblanco@chromium.org

Merge 113373 - [chromium] Drawing an accelerated canvas onto itself is slow.
https://bugs.webkit.org/show_bug.cgi?id=83295

Fixed by using a GPU-side deepCopy() in skia, so we don't trigger a
readback and re-upload.

Reviewed by James Robinson.

Correctness is covered by existing tests. Performance is covered
by the test case attached to the bug.

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::BitmapImageSingleFrameSkia::create):

TBR=laforge@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9960076

12:55 Changeset [113757] by commit-queue@webkit.org

[BlackBerry] Crash when tearing down web page rendered using WebPageCompositor
https://bugs.webkit.org/show_bug.cgi?id=83567

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-04-10
Reviewed by Antonio Gomes.

Fixed by checking if there's a layer renderer before calling into it.

  • Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::releaseLayerResources):

12:48 Changeset [113756] by andersca@apple.com

Unreviewed, rolling out r113611.
http://trac.webkit.org/changeset/113611
https://bugs.webkit.org/show_bug.cgi?id=71541

Broke fast/forms/basic-textareas.html

Source/WebCore:

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hasHorizontalOverflow):
(WebCore::RenderLayer::hasVerticalOverflow):

LayoutTests:

  • fast/overflow/overflow-auto-destroy-scroll-after-resizing-expected.html: Removed.
  • fast/overflow/overflow-auto-destroy-scroll-after-resizing.html: Removed.
  • platform/efl/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
12:45 Changeset [113755] by commit-queue@webkit.org

Unreviewed, rolling out r113734.
http://trac.webkit.org/changeset/113734
https://bugs.webkit.org/show_bug.cgi?id=83606

causing a bunch of unrelated test failures (Requested by
simonjam on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-10

Source/WebCore:

  • Modules/battery/BatteryController.cpp:
  • Modules/battery/BatteryController.h:

(BatteryController):

  • Modules/battery/BatteryManager.cpp:

(WebCore::BatteryManager::charging):
(WebCore::BatteryManager::chargingTime):
(WebCore::BatteryManager::dischargingTime):
(WebCore::BatteryManager::level):

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:

Source/WebKit/chromium:

  • WebKit.gyp:
  • features.gypi:
  • public/WebBatteryStatus.h: Removed.
  • public/WebBatteryStatusClient.h: Removed.
  • public/WebView.h:

(WebKit):
(WebView):

  • public/WebViewClient.h:

(WebKit):

  • src/BatteryClientImpl.cpp: Removed.
  • src/BatteryClientImpl.h: Removed.
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

  • src/WebViewImpl.h:

(WebKit):
(WebViewImpl):

LayoutTests:

  • platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
  • platform/chromium/test_expectations.txt:
12:41 Changeset [113754] by adamk@chromium.org

Add setJSWrapperForActiveDOMNode and use it for Nodes that are also ActiveDOMObjects
https://bugs.webkit.org/show_bug.cgi?id=83528

Reviewed by Kentaro Hara.

Instead of using a run-time call to isActiveNode to determine which
map to put a Node wrapper in, generate the proper call in the CodeGenerator.

This was originally part of r112318, which got rolled out due to OOM concerns.
I'm splitting it into smaller pieces so that each can be landed and
watched for issues seperately.

No new tests, no change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateConstructorCallback): Use new GetDomMapName function to
figure out which setJSWrapper to call.
(GenerateNamedConstructorCallback): ditto.
(GetDomMapFunction): Delegate to GetDomMapName for logic.
(GetDomMapName): New helper factored out of GetDomMapFunction.

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::setJSWrapperForDOMNode): Assert !isActiveNode instead of branching on it.
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMNode): New method split ouf of the above.
Assert isActiveNode instead of branching on it.

  • bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):

12:36 Changeset [113753] by macpherson@chromium.org

Pass PropertyHandler by reference in CSSStyleApplyProperty.h.
https://bugs.webkit.org/show_bug.cgi?id=83551

Reviewed by Kentaro Hara.

No new tests / cleanup only.

  • css/CSSStyleApplyProperty.h:

(WebCore::CSSStyleApplyProperty::setPropertyHandler):

12:31 Changeset [113752] by macpherson@chromium.org

Pass FontDescription as const reference instead of by value in CSSStyleSelector.h.
https://bugs.webkit.org/show_bug.cgi?id=83548

Reviewed by Kentaro Hara.

FontDescription is relatively large, so pass-by-reference is preferred.

No new tests / code cleanup only.

  • css/CSSStyleSelector.h:

(WebCore::CSSStyleSelector::fontDescription):
(WebCore::CSSStyleSelector::parentFontDescription):
(WebCore::CSSStyleSelector::setFontDescription):

12:23 Changeset [113751] by adamk@chromium.org

Add TestNode.idl to run-binding-tests
https://bugs.webkit.org/show_bug.cgi?id=83599

Reviewed by Adam Barth.

TestNode.idl is a minimized version of Node.idl with enough attributes
to exercise CodeGenerator.pm's handling of Node subtypes.

  • bindings/scripts/test/CPP/WebDOMTestNode.cpp: Added.
  • bindings/scripts/test/CPP/WebDOMTestNode.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestNode.cpp: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestNode.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestNodePrivate.h: Added.
  • bindings/scripts/test/JS/JSTestNode.cpp: Added.
  • bindings/scripts/test/JS/JSTestNode.h: Added.
  • bindings/scripts/test/ObjC/DOMTestNode.h: Added.
  • bindings/scripts/test/ObjC/DOMTestNode.mm: Added.
  • bindings/scripts/test/ObjC/DOMTestNodeInternal.h: Added.
  • bindings/scripts/test/TestNode.idl: Added.
  • bindings/scripts/test/V8/V8TestNode.cpp: Added.
  • bindings/scripts/test/V8/V8TestNode.h: Added.
12:18 Changeset [113750] by eae@chromium.org

Fix style issues on branch.

12:15 Changeset [113749] by commit-queue@webkit.org

msqrt's implied mrow should do operator stretching
https://bugs.webkit.org/show_bug.cgi?id=82353

Patch by David Barton <dbarton@mathscribe.com> on 2012-04-10
Reviewed by Julien Chaffraix.

Source/WebCore:

An <msqrt> with more than one child is supposed to surround them with an implied <mrow>.
This patch does this, and thus includes vertical operator stretching. We also fix some
problems with the old RenderMathMLSquareRoot.cpp: possibly shared RenderStyles were
being modified, and layout() was using heights of children without checking whether they
needed layout themselves first.

To leave room for the radical sign, we use intrinsic padding. This is simpler and more
efficient than using anonymous RenderStyles.

Added tests to mo-stretch.html and style.xhtml. Regression tests are in roots.xhtml.

  • css/mathml.css:

(msqrt):

  • rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::RenderMathMLBlock):
(WebCore::RenderMathMLBlock::paddingTop):
(WebCore::RenderMathMLBlock::paddingBottom):
(WebCore::RenderMathMLBlock::paddingLeft):
(WebCore::RenderMathMLBlock::paddingRight):
(WebCore::RenderMathMLBlock::paddingBefore):
(WebCore::RenderMathMLBlock::paddingAfter):
(WebCore::RenderMathMLBlock::paddingStart):
(WebCore::RenderMathMLBlock::paddingEnd):

  • rendering/mathml/RenderMathMLBlock.h:

(RenderMathMLBlock):

  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::RenderMathMLRow):
(WebCore::RenderMathMLRow::createAnonymousWithParentRenderer):

  • rendering/mathml/RenderMathMLRow.h:

(RenderMathMLRow):

  • rendering/mathml/RenderMathMLSquareRoot.cpp:

(WebCore):
(WebCore::RenderMathMLSquareRoot::addChild):
(WebCore::RenderMathMLSquareRoot::computePreferredLogicalWidths):
(WebCore::RenderMathMLSquareRoot::computeLogicalHeight):
(WebCore::RenderMathMLSquareRoot::layout):
(WebCore::RenderMathMLSquareRoot::paint):

  • rendering/mathml/RenderMathMLSquareRoot.h:

(RenderMathMLSquareRoot):

LayoutTests:

  • mathml/presentation/mo-stretch.html:
  • mathml/presentation/style.xhtml:
  • platform/mac/mathml/presentation/attributes-expected.txt:
  • platform/mac/mathml/presentation/mo-stretch-expected.png:
  • platform/mac/mathml/presentation/mo-stretch-expected.txt:
  • platform/mac/mathml/presentation/roots-expected.txt:
  • platform/mac/mathml/presentation/style-expected.png:
  • platform/mac/mathml/presentation/style-expected.txt:
12:10 Changeset [113748] by macpherson@chromium.org

Don't allow fallthrough for CSSPropertyBaselineShift in CSSComputedStyleDeclaration::getSVGPropertyCSSValue().
https://bugs.webkit.org/show_bug.cgi?id=83536

Reviewed by Daniel Bates.

Add a return statement to the case CSSPropertyBaselineShift so that we don't fall through to the next case statement.

No new tests / code cleanup from coverity static analysis.

  • css/SVGCSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):

12:01 Changeset [113747] by adamk@chromium.org

Merge 113378 - Crash in MutationObservers due to an invalid HashSet iterator
https://bugs.webkit.org/show_bug.cgi?id=83304

Reviewed by Ojan Vafai.

Source/WebCore:

If the observed node has been GCed when we clear transient observers
from it, the HashSet iterator in WebKitMutationObserver::deliver would
be invalidated. This patch fixes that behavior by copying the relevant
registrations into a seperate vector first and operating on the copy.

This patch also fixes a bug: transient observers should be cleared
after every microtask, not just when delivering.

Tests: fast/mutation/clear-transient-without-delivery.html

fast/mutation/transient-gc-crash.html

  • dom/MutationObserverRegistration.cpp:

(WebCore::MutationObserverRegistration::observedSubtreeNodeWillDetach):
Notify the observer that it has a transient registration so it can be properly cleared.

  • dom/MutationObserverRegistration.h:

(WebCore::MutationObserverRegistration::hasTransientRegistrations):
Add an accessor for use when deliver() creates its vector of registrations.

  • dom/WebKitMutationObserver.cpp:

(WebCore::WebKitMutationObserver::setHasTransientRegistration): Add this to the active observer set
to allow transient registrations to be cleared appropriately.
(WebCore::WebKitMutationObserver::deliver): Avoid modifying m_registrations while iterating over it.
Clear registrations before checking for a lack of records to deliver.

  • dom/WebKitMutationObserver.h:

LayoutTests:

  • fast/mutation/clear-transient-without-delivery-expected.txt: Added.
  • fast/mutation/clear-transient-without-delivery.html: Added.
  • fast/mutation/transient-gc-crash-expected.txt: Added.
  • fast/mutation/transient-gc-crash.html: Added.

TBR=inferno@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9999033

11:56 Changeset [113746] by alex@webkit.org

2012-04-10 Alejandro G. Castro <alex@igalia.com>

[GTK] Build fix TextureMapper compilation and solve warning.

Reviewed by Martin Robinson.

  • platform/graphics/texmap/TextureMapperGL.cpp: (WebCore::BitmapTextureGL::updateContents):
  • platform/graphics/texmap/TextureMapperShaderManager.h: (WebCore::TextureMapperShaderManager::getShaderProgram):
11:52 Changeset [113745] by eae@chromium.org

Merge trunk changes up until 113730 into subpixel branch.

11:46 Changeset [113744] by andersca@apple.com

Add fast/events/drop-handler-should-not-stop-navigate.html.

Like fast/events/drop-with-file-paths.html, this expects eventSender.beginDragWithFiles to be implemented.

  • platform/wk2/Skipped:
11:44 Changeset [113743] by andersca@apple.com

Add fast/events/drop-with-file-paths.html to the WebKit2 Skipped list.

  • platform/wk2/Skipped:
11:29 Changeset [113742] by noel.gordon@gmail.com

[GTK] Separate image encoding from dataURL construction
https://bugs.webkit.org/show_bug.cgi?id=83152

Reviewed by Martin Robinson.

Remove the implicit assumption that a dataURL is the only desired output format
of the image encoding phase.

No new tests, refactoring only, covered by existing canvas tests.

  • platform/graphics/gtk/ImageBufferGtk.cpp:

(WebCore::encodeImage): Output the encoded image to the provided GOwnPtr<gchar>&
buffer. Update GTK document reference to a valid URL. Round the quality argument
to an int like the toDataURL() implementations of other ports. Ditch the success
variable; instead test the GError* error return to indicate success.
(WebCore):
(WebCore::ImageBuffer::toDataURL): Format the dataURL encoding of the mimeType
encoded image data buffer herein.

11:20 Changeset [113741] by antonm@chromium.org

Add test expectations for Mac debug builds.

Unreviewed.

  • platform/chromium-mac-snowleopard/fast/dom/shadow: Added.
  • platform/chromium-mac-snowleopard/fast/dom/shadow/selection-in-shadow-expected.txt: Added.
11:17 Changeset [113740] by jamesr@google.com

[chromium] Defer texture id allocation for copies until the actual copy executes
https://bugs.webkit.org/show_bug.cgi?id=83514

Reviewed by Adrienne Walker.

Source/WebCore:

This allows for queuing a texture copy operation into a ManagedTexture whose texture ID has not yet been
allocated. The ManagedTexture* serves as a promise that an ID will be available when the copy is executed.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::doCommit):

  • platform/graphics/chromium/cc/CCTextureUpdater.cpp:

(WebCore::CCTextureUpdater::CCTextureUpdater):
(WebCore::CCTextureUpdater::appendManagedCopy):
(WebCore):
(WebCore::CCTextureUpdater::hasMoreUpdates):
(WebCore::CCTextureUpdater::update):
(WebCore::CCTextureUpdater::clear):

  • platform/graphics/chromium/cc/CCTextureUpdater.h:

(CCTextureUpdater):
(ManagedCopyEntry):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):

Source/WebKit/chromium:

  • tests/CCTiledLayerTestCommon.cpp:
  • tests/CCTiledLayerTestCommon.h:
  • tests/Canvas2DLayerChromiumTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):

11:14 Changeset [113739] by hyatt@apple.com

Add ref test expected result.

11:14 Changeset [113738] by hyatt@apple.com

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=83595
<rdar://problem/10443278> Overlapping text in table cell across column break

If a cell's height changes such that it is taller than the overall row height because
of pagination, then grow the entire row height to enclose the cell instead of shrinking
the cell.

Reviewed by Dan Bernstein.

Added fast/multicol/cell-shrinkback.html

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=83595

Add new layout test for cells paginating across columns.

Reviewed by Dan Bernstein.

  • fast/multicol/cell-shrinkback.html: Added.
  • fast/multicol/cell-shrinkback-expected.html: Added.
  • platform/mac/fast/multicol/table-vertical-align-expected.txt:
11:10 Changeset [113737] by macpherson@chromium.org

Remove unnecessary null check in void SimplifyMarkupCommand::doApply().
https://bugs.webkit.org/show_bug.cgi?id=83535

Reviewed by Kentaro Hara.

No new tests / code cleanup only.

currentNode cannot be null within the loop body.
It is dereferenced before and after the removed line without checking.
Additionally I have added an assertion to express this loop invariant.

  • editing/SimplifyMarkupCommand.cpp:

(WebCore::SimplifyMarkupCommand::doApply):

10:47 Changeset [113736] by commit-queue@webkit.org

Add Encrypted Media Extensions methods to HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=82971

Patch by David Dorwin <ddorwin@chromium.org> on 2012-04-10
Reviewed by Adam Barth.

The extensions are behind the ENABLE(ENCRYPTED_MEDIA) feature define.
Implementation is based on v0.1 of the draft proposal at
http://dvcs.w3.org/hg/html-media/raw-file/tip/encrypted-media/encrypted-media.html.

Source/WebCore:

Tests: media/encrypted-media/encrypted-media-not-loaded.html

media/encrypted-media/encrypted-media-syntax.html

  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::webkitEncryptedMediaEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitEncryptedMediaEnabled):

  • html/HTMLMediaElement.cpp:

(WebCore):
(WebCore::exceptionCodeForMediaKeyException):
(WebCore::HTMLMediaElement::webkitGenerateKeyRequest):
(WebCore::HTMLMediaElement::webkitAddKey):
(WebCore::HTMLMediaElement::webkitCancelKeyRequest):
(WebCore::HTMLMediaElement::setVolume):
(WebCore::HTMLMediaElement::togglePlayState):
(WebCore::HTMLMediaElement::beginScrubbing):
(WebCore::HTMLMediaElement::addTextTrack):
(WebCore::HTMLMediaElement::textTracks):
(WebCore::HTMLMediaElement::showingTrackWithSameKind):
(WebCore::HTMLMediaElement::didAddTrack):

  • html/HTMLMediaElement.h:
  • html/HTMLMediaElement.idl:
  • platform/graphics/MediaPlayer.cpp:

(NullMediaPlayerPrivate):
(WebCore):
(WebCore::MediaPlayer::generateKeyRequest):
(WebCore::MediaPlayer::addKey):
(WebCore::MediaPlayer::cancelKeyRequest):

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(MediaPlayerPrivateInterface):
(WebCore::MediaPlayerPrivateInterface::addKey):
(WebCore::MediaPlayerPrivateInterface::generateKeyRequest):
(WebCore::MediaPlayerPrivateInterface::cancelKeyRequest):

Source/WebKit/chromium:

  • features.gypi:
  • public/WebMediaPlayer.h:

(WebKit):
(WebMediaPlayer):
(WebKit::WebMediaPlayer::generateKeyRequest):
(WebKit::WebMediaPlayer::addKey):
(WebKit::WebMediaPlayer::cancelKeyRequest):

  • public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

  • src/AssertMatchingEnums.cpp:
  • src/WebMediaPlayerClientImpl.cpp:

(WebKit):
(WebKit::WebMediaPlayerClientImpl::generateKeyRequest):
(WebKit::WebMediaPlayerClientImpl::addKey):
(WebKit::WebMediaPlayerClientImpl::cancelKeyRequest):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::isMediaStreamEnabled):
(WebKit::WebRuntimeFeatures::enableEncryptedMedia):
(WebKit):
(WebKit::WebRuntimeFeatures::isEncryptedMediaEnabled):

Tools:

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

LayoutTests:

  • media/encrypted-media/encrypted-media-not-loaded-expected.txt: Added.
  • media/encrypted-media/encrypted-media-not-loaded.html: Added.
  • media/encrypted-media/encrypted-media-syntax-expected.txt: Added.
  • media/encrypted-media/encrypted-media-syntax.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
10:33 Changeset [113735] by leviw@chromium.org

Build Fix for GTK.

10:28 Changeset [113734] by commit-queue@webkit.org

[chromium] Add Battery Status API support.

Source/WebCore:

Add Battery Status API support to chromium.
https://bugs.webkit.org/show_bug.cgi?id=83284

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-04-10
Reviewed by Adam Barth.

This change is covered by tests in batterystatus/.

  • Modules/battery/BatteryController.cpp:

(WebCore::BatteryController::updateBatteryStatus):
(WebCore):

  • Modules/battery/BatteryController.h:

(BatteryController):

  • Modules/battery/BatteryManager.cpp:

(WebCore::BatteryManager::charging):
(WebCore::BatteryManager::chargingTime):
(WebCore::BatteryManager::dischargingTime):
(WebCore::BatteryManager::level):

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:

Source/WebKit/chromium:

The battery-client (BatteryClientChromium) will notify the client (WebBatteryStatusClient) when to start or stop
sending battery status updates. The client, in response will send the notifications to WebViewImpl, which sends
this update information to the WebCore::BatteryClient, and it triggers the appropriate javascript-callbacks.
The spec is at http://www.w3.org/TR/2011/WD-battery-status-20111129/.
https://bugs.webkit.org/show_bug.cgi?id=83284

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-04-10
Reviewed by Adam Barth.

  • WebKit.gyp:
  • features.gypi:
  • public/WebBatteryStatus.h: Added.

(WebKit):
(WebBatteryStatus):
(WebKit::WebBatteryStatus::WebBatteryStatus):

  • public/WebBatteryStatusClient.h: Added.

(WebKit):
(WebBatteryStatusClient):
(WebKit::WebBatteryStatusClient::~WebBatteryStatusClient):

  • public/WebView.h:

(WebKit):
(WebView):
(WebKit::WebView::updateBatteryStatus):

  • public/WebViewClient.h:

(WebKit):
(WebViewClient):
(WebKit::WebViewClient::batteryStatusClient):

  • src/BatteryClientImpl.cpp: Added.

(WebKit):
(WebKit::BatteryClientImpl::BatteryClientImpl):
(WebKit::BatteryClientImpl::updateBatteryStatus):
(WebKit::BatteryClientImpl::setController):
(WebKit::BatteryClientImpl::startUpdating):
(WebKit::BatteryClientImpl::stopUpdating):
(WebKit::BatteryClientImpl::batteryControllerDestroyed):

  • src/BatteryClientImpl.h: Added.

(WebKit):
(BatteryClientImpl):
(WebKit::BatteryClientImpl::~BatteryClientImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit):
(WebKit::WebViewImpl::updateBatteryStatus):

  • src/WebViewImpl.h:

(WebKit):
(WebViewImpl):

LayoutTests:

Add Battery Status API support to chromium.
https://bugs.webkit.org/show_bug.cgi?id=83284

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-04-10
Reviewed by Adam Barth.

  • platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
  • platform/chromium/test_expectations.txt:
10:25 Changeset [113733] by zmo@google.com

getShaderFormatPrecision should return sensible values
https://bugs.webkit.org/show_bug.cgi?id=83520

Reviewed by Kenneth Russell.

Source/WebCore:

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: Fix getShaderPrecisionFormat values.

(WebCore::GraphicsContext3D::getShaderPrecisionFormat):

  • platform/graphics/qt/GraphicsContext3DQt.cpp: Ditto.

(WebCore::GraphicsContext3D::getShaderPrecisionFormat):

LayoutTests:

  • fast/canvas/webgl/shader-precision-format-expected.txt:
  • fast/canvas/webgl/shader-precision-format.html: Add tests to make sure getShaderPrecisionFormat returns sensible values.
10:20 Changeset [113732] by lforschler@apple.com

Merged r113654.

10:18 Changeset [113731] by apavlov@chromium.org

Web Inspector: Add Galaxy Nexus to the list of emulated user agents
https://bugs.webkit.org/show_bug.cgi?id=83589

The new record contains the device display metrics and the User Agent string.

Reviewed by Pavel Feldman.

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.get const):

10:11 Changeset [113730] by eae@chromium.org

Add missing methods and operators to FractionalLayoutUnit
https://bugs.webkit.org/show_bug.cgi?id=82403

Reviewed by Eric Seidel.

Add missing methods and operators and from branch version of
FractionalLayoutUnit. Also fix overflow assertion and add const keyword
to a couple of methods.

No new tests.

  • platform/FractionalLayoutUnit.h:

(WebCore::FractionalLayoutUnit::abs):
(FractionalLayoutUnit):
(WebCore::FractionalLayoutUnit::ceil):
(WebCore::FractionalLayoutUnit::round):
(WebCore::FractionalLayoutUnit::floor):
(WebCore::FractionalLayoutUnit::isInBounds):
(WebCore::operator<):
(WebCore):
(WebCore::operator-):

10:07 Changeset [113729] by zmo@google.com

2012-04-10 Zhenyao Mo <zmo@google.com>

Unreviewed, roll chromium to 131469

  • DEPS:
10:04 Changeset [113728] by jer.noble@apple.com

WebAudio: propagate a silence hint through the AudioNode graph.
https://bugs.webkit.org/show_bug.cgi?id=74553

Reviewed by Chris Rogers.

No new tests; optimization of existing code path, so covered by existing tests.

Introduce the concept of a "silent" channel:

  • platform/audio/AudioChannel.h:

(WebCore::AudioChannel::AudioChannel):
(WebCore::AudioChannel::set): Clear silent bit.
(WebCore::AudioChannel::zero): Set silent bit.
(WebCore::AudioChannel::clearSilentFlag): Clear silent bit.
(WebCore::AudioChannel::isSilent): Accessor.

Optimize a few channel operations when the source or destination channels are silent.

  • platform/audio/AudioChannel.cpp:

(WebCore::AudioChannel::scale): No-op on a silent channel.
(WebCore::AudioChannel::copyFrom): zero() when source is silent.
(WebCore::AudioChannel::copyFromRange): possibly zero() when source is silent.
(WebCore::AudioChannel::sumFrom): No-op when source is silent.
(WebCore::AudioChannel::maxAbsValue): 0 on a silent channel.

Optimize a few bus operations when the source or destination channels are silent.

  • platform/audio/AudioBus.cpp:

(WebCore::AudioBus::processWithGainFromMonoStereo): No-op if source is silent and either

the destination bus is silent, or the output is not summed to the destination.

(WebCore::AudioBus::copyWithSampleAccurateGainValuesFrom): zero() if the source is silent

and the lengths of the gain values, source, and destination match.

(WebCore::AudioBus::createBySampleRateConverting): Return an empty bus if the source is silent.
(WebCore::AudioBus::createByMixingToMono): Ditto; clear the destination's silent bit otherwise.
(WebCore::AudioBus::isSilent): Return whether all channels are silent.
(WebCore::AudioBus::clearSilentFlag): Clear silent bit of constituent channels.

  • platform/audio/AudioBus.h:

Make sure that classes which generate audio clear their busses' silent bit.

  • webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::process): Ditto.
(WebCore::AudioBufferSourceNode::renderFromBuffer): Ditto.
(WebCore::AudioBufferSourceNode::propagatesSilence): Propagate silence only when the source node

has nothing left to render.

  • webaudio/AudioBufferSourceNode.h:

(WebCore::AudioBufferSourceNode::playbackState): Made const correct.
(WebCore::AudioBufferSourceNode::isPlaying): Added simple accessor.
(WebCore::AudioBufferSourceNode::hasFinished): Ditto.

  • webaudio/AudioDestinationNode.h:

(WebCore::AudioDestinationNode::currentSampleFrame): Made const correct.
(WebCore::AudioDestinationNode::currentTime): Ditto.

Audio nodes should not process audio data when the input is silent and the nodes will propagate silences.

  • webaudio/AudioNode.cpp:

(WebCore::AudioNode::processIfNecessary):
(WebCore::AudioNode::inputsAreSilent): Convenience function which walk over the node's inputs.
(WebCore::AudioNode::silenceOutputs): Ditto.
(WebCore::AudioNode::unsilenceOutputs): Ditto.

  • webaudio/AudioNode.h:

(WebCore::AudioNode::propagatesSilence):

These Nodes can generate audio when given silent input, so return false from propagatesSilence.

  • Modules/webaudio/Oscillator.h:

(WebCore::Oscillator::propagatesSilence): Added.

09:40 Changeset [113727] by apavlov@chromium.org

[Chromium] Unreviewed, add baselines for fast/dom/shadow/selection-in-shadow.html

  • platform/chromium/fast/dom/shadow/selection-in-shadow-expected.txt: Added.
09:36 Changeset [113726] by fpizlo@apple.com

It should be possible to see why a code block was not compiled by the DFG
https://bugs.webkit.org/show_bug.cgi?id=83553

Reviewed by Geoff Garen.

If DFG_ENABLE(DEBUG_VERBOSE) and a code block is rejected, then print the
opcode that caused the rejection.

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::debugFail):
(DFG):
(JSC::DFG::canHandleOpcodes):

09:29 Changeset [113725] by zandobersek@gmail.com

Unreviewed - adding myself as a committer.

09:22 Changeset [113724] by commit-queue@webkit.org

[EFL][DRT] Catch the "title,changed" signal
https://bugs.webkit.org/show_bug.cgi?id=82174

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-04-10
Reviewed by Gustavo Noronha Silva.

Tools:

EFL's DumpRenderTree now catches the "title,changed" signal, and
prints out the needed information.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::onTitleChanged):

LayoutTests:

Unskip tests which requires EFL's DumpRenderTree to catch the
"title,changed" signal and print out information, now that it
is implemented.

  • platform/efl/Skipped:
09:19 Changeset [113723] by yi.4.shen@nokia.com

Pressing enter on blank line after bullet deletes entire bulleted line.
https://bugs.webkit.org/show_bug.cgi?id=82690

Reviewed by Enrica Casucci.

In CompositeEditCommand::breakOutOfEmptyListItem(), it checks the empty list item's renderer's siblings
to decide which empty part of the list should be removed. However, if the empty list item's renderer is
wrapped by an anonymous block, e.g. <ul><li>hello</li><br></ul>, the check may fail. So, we use isListItem
on the empty list node's siblings instead.

Source/WebCore:

No new tests : added new test case in the existing test (break-out-of-empty-list-item.html)

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::breakOutOfEmptyListItem):

LayoutTests:

  • editing/execCommand/break-out-of-empty-list-item-expected.txt:
  • editing/execCommand/script-tests/break-out-of-empty-list-item.js:
09:15 Changeset [113722] by commit-queue@webkit.org

[EFL] DRT should support LayoutTestController's willSendRequestReturnsNull()
https://bugs.webkit.org/show_bug.cgi?id=82443

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-04-10
Reviewed by Philippe Normand.

Tools:

EFL's DRT needs to support LayoutTestController's
willSendRequestReturnsNull() and return NULL when expected. This
allows for several tests to be removed from the skip list.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::onWillSendRequest):

LayoutTests:

Unskip tests which depend on EFL's DumpRenderTree support for
LayoutTestController's willSendRequestReturnsNull(), now that it is
implemented.

  • platform/efl/Skipped:
08:50 Changeset [113721] by apavlov@chromium.org

Web Inspector: Inspect Element - Edit as HTML - scrolling bug
https://bugs.webkit.org/show_bug.cgi?id=83563

mousedown in the scrollbar focuses the Elements tree outline container DIV element,
so the corresponding mousedown event should be consumed in the AT_TARGET phase.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype._startEditingAsHTML.consume):
(WebInspector.ElementsTreeElement.prototype._startEditingAsHTML.dispose):
(WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):

08:42 WebKit Team edited by pdr@google.com
Adding my team to the committers wiki page. (diff)
08:36 Changeset [113720] by commit-queue@webkit.org

[Qt][WK2] Assertion failure on loading new page after panning/zooming
https://bugs.webkit.org/show_bug.cgi?id=83049

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-04-10
Reviewed by Kenneth Rohde Christiansen.

When handling contents size change, set the visible content rectangle immediately,
instead of animating to it.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::itemSizeChanged):

08:35 Changeset [113719] by commit-queue@webkit.org

[EFL] LayoutTestController needs implementation of addUserStyleSheet
https://bugs.webkit.org/show_bug.cgi?id=82446

Source/WebKit/efl:

Add missing implementation addUserStyleSheet to EFL's
DumpRenderTreeSupport.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-10
Reviewed by Antonio Gomes.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::addUserStyleSheet):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Adding missing implementation addUserStyleSheet to EFL's LayoutTestController
so that we can unskip related tests from the skip list.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-10
Reviewed by Antonio Gomes.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::addUserStyleSheet): Implemented.

LayoutTests:

Unskipping the following test cases:
userscripts/mixed-case-stylesheet.html
userscripts/user-style-all-frames.html
userscripts/simple-stylesheet.html
userscripts/script-run-at-end.html

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-10
Reviewed by Antonio Gomes.

  • platform/efl/Skipped:
08:33 Changeset [113718] by pdr@google.com

Adding myself to committers.py!

Unreviewed update to committers.py.

  • Scripts/webkitpy/common/config/committers.py:
08:33 Changeset [113717] by ossy@webkit.org

[Qt][WK2] Unreviewed gardening, skip a test to try to paint the bot greener.

  • platform/qt-5.0-wk2/Skipped:
08:32 Changeset [113716] by commit-queue@webkit.org

Remove the unused function WebCore::toIconIndex
https://bugs.webkit.org/show_bug.cgi?id=83037

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-04-10
Reviewed by Kentaro Hara.

  • WebCore.order:
  • dom/IconURL.cpp:
  • dom/IconURL.h:

(WebCore):

08:25 Changeset [113715] by commit-queue@webkit.org

[Qt][WK2] Title in MiniBrowser is not updated for a page with no title
https://bugs.webkit.org/show_bug.cgi?id=82483

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-04-10
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

titleChanged signal is not emitted on comitting a new load.

  • UIProcess/API/qt/tests/html/basic_page.html:
  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView):
(tst_QQuickWebView::titleUpdate):

  • UIProcess/qt/QtWebPageLoadClient.cpp:

(QtWebPageLoadClient::didCommitLoadForFrame):

Tools:

Set window title to default if there is no page title.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::onTitleChanged):

  • MiniBrowser/qt/BrowserWindow.h:

(BrowserWindow):

08:14 Changeset [113714] by jesus@webkit.org

[Qt][WK2] Implement PageClient::isViewWindowActive()
https://bugs.webkit.org/show_bug.cgi?id=81143

Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

This patch implements PageClient::isViewWindowActive()
now that QQuickCanvas::isActive() is available (from QWindow).

  • UIProcess/qt/QtPageClient.cpp:

(QtPageClient::isViewWindowActive):

Tools:

Fix the WrapperWindow from our PlatformWebView
so it correctly creates the platform related
stuff for QWindow, which is not created unless
QWindow::setVisible() or QWindow::show() are called.

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::PlatformWebView):

07:42 Changeset [113713] by ossy@webkit.org

[Wk2] Gradening. Skip failing test.
https://bugs.webkit.org/show_bug.cgi?id=83581

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-04-10
Reviewed by Csaba Osztrogonác.

  • platform/wk2/Skipped:
06:52 Changeset [113712] by ossy@webkit.org

[Qt] Unreviewed gardening. Skip a failing, a timeouting and a crashing test to paint the bots green.

  • platform/qt-5.0-wk2/Skipped:
05:53 Changeset [113711] by pfeldman@chromium.org

Web Inspector: make error a string on the front-end side, not an object.
https://bugs.webkit.org/show_bug.cgi?id=83570

Reviewed by Yury Semikhatsky.

Source/WebCore:

We already expect it to be a string in all the code, we never use the error code in it.

  • inspector/front-end/InspectorBackend.js:

(InspectorBackendClass.prototype.dispatch):

LayoutTests:

  • inspector/debugger/debugger-set-breakpoint-regex-expected.txt:
  • inspector/debugger/debugger-set-breakpoint-regex.html:
  • inspector/elements/resolve-node-blocked-expected.txt:
  • inspector/elements/set-attribute.html:
  • inspector/profiler/heap-snapshot-inspect-dom-wrapper-expected.txt:
  • inspector/report-protocol-errors-expected.txt:
  • inspector/report-protocol-errors.html:
  • inspector/styles/set-property-boundaries-expected.txt:
05:34 Changeset [113710] by rwlbuis@webkit.org

getElementsByTagName unable to find SVG camelCase elements imported into HTML
https://bugs.webkit.org/show_bug.cgi?id=46800

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Implement getElementsByTagName according to the algorithm in
http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#concept-getelementsbytagname.
If the owner document of the element is html, the new class HTMLTagNodeList deals with
finding the match(es) based on this algorithm. If the owner document is non HTML, the existing
TagNodeList is used.

Implement getElementsByTagNameNS according to the algorithm in
http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#concept-getelementsbytagnamens.
The existing TagNodeList implements this algorithm.

Cached results may have less hits after this change. Tag names that are equal when case
insensitive but different when case sensitive can't share the result due to above algorithms, i.e.
they would match differently in the non html part of the document.

Tests: fast/dom/getElementsByTagName-localName-matching.html

fast/dom/getElementsByTagName-localName-matching2.xhtml
svg/dom/getElementsByTagName-localName-matching.html

  • dom/Node.cpp:

(WebCore::Node::getElementsByTagName): create TagNodeList depending on owner document type.
(WebCore::Node::getElementsByTagNameNS): do not lowercase localName for html.

  • dom/TagNodeList.cpp:

(WebCore::HTMLTagNodeList::HTMLTagNodeList): add specialized TagNodeList for html matching rules.
(WebCore):
(WebCore::HTMLTagNodeList::nodeMatches):

  • dom/TagNodeList.h:

(TagNodeList):
(HTMLTagNodeList):
(WebCore::HTMLTagNodeList::create):

LayoutTests:

Add tests for getElementsByTagName(NS) in html, xhtml, and svg documents.

  • fast/dom/getElementsByTagName-localName-matching-expected.txt: Added.
  • fast/dom/getElementsByTagName-localName-matching.html: Added.
  • fast/dom/getElementsByTagName-localName-matching2-expected.txt: Added.
  • fast/dom/getElementsByTagName-localName-matching2.xhtml: Added.
  • svg/dom/getElementsByTagName-localName-matching-expected.txt: Added.
  • svg/dom/getElementsByTagName-localName-matching.html: Added.
  • svg/dom/script-tests/getElementsByTagName-localName-matching.js: Added.
05:29 Changeset [113709] by apavlov@chromium.org

Web Inspector: [Device Metrics] Introduce the "Fit window" option
https://bugs.webkit.org/show_bug.cgi?id=83280

Source/WebCore:

This change adds the "Fit window" option to the Settings pane of Web Inspector, which lets users
resize the FrameView to fit the WebViewImpl size. When the user resizes the browser window
in the device metrics override mode with the option enabled, the FrameView follows
to match WebViewImpl by at least one dimension.

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/Inspector.json:
  • inspector/InspectorClient.h:

(WebCore::InspectorClient::overrideDeviceMetrics):
(WebCore::InspectorClient::autoZoomPageToFitWidth):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::shouldApplyScreenWidthOverrideImpl):
(WebCore):
(WebCore::InspectorInstrumentation::shouldApplyScreenHeightOverrideImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::shouldApplyScreenWidthOverride):
(WebCore):
(WebCore::InspectorInstrumentation::shouldApplyScreenHeightOverride):

  • inspector/InspectorPageAgent.cpp:

(PageAgentState):
(WebCore::InspectorPageAgent::restore):
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::setDeviceMetricsOverride):
(WebCore::InspectorPageAgent::updateViewMetrics):

  • inspector/InspectorPageAgent.h:
  • inspector/front-end/Settings.js:
  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen.prototype._createDeviceMetricsElement):

  • inspector/front-end/UserAgentSupport.js:
  • inspector/front-end/helpScreen.css:

(.help-content input[type=checkbox]):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::innerHeight):
(WebCore::DOMWindow::innerWidth):

Source/WebKit/chromium:

Implement the scaling of the FrameView to the WebViewImpl size, handle WebViewImpl resizes.

Reviewed by Pavel Feldman.

  • src/InspectorClientImpl.cpp:

(WebKit::InspectorClientImpl::overrideDeviceMetrics):

  • src/InspectorClientImpl.h:

(InspectorClientImpl):

  • src/WebDevToolsAgentImpl.cpp:

(WebKit::DeviceMetricsSupport::DeviceMetricsSupport):
(WebKit::DeviceMetricsSupport::setDeviceMetrics):
(WebKit::DeviceMetricsSupport::autoZoomPageToFitWidthOnNavigation):
(DeviceMetricsSupport):
(WebKit::DeviceMetricsSupport::autoZoomPageToFitWidth):
(WebKit::DeviceMetricsSupport::webViewResized):
(WebKit::DeviceMetricsSupport::applySizeOverrideIfNecessary):
(WebKit::DeviceMetricsSupport::ensureOriginalZoomFactor):
(WebKit::DeviceMetricsSupport::restore):
(WebKit::DeviceMetricsSupport::scaledEmulatedFrameSize):
(WebKit::DeviceMetricsSupport::forcedScrollbarDimensions):
(WebKit::DeviceMetricsSupport::applySizeOverrideInternal):
(WebKit::WebDevToolsAgentImpl::webViewResized):
(WebKit):
(WebKit::WebDevToolsAgentImpl::overrideDeviceMetrics):
(WebKit::WebDevToolsAgentImpl::autoZoomPageToFitWidth):

  • src/WebDevToolsAgentImpl.h:

(WebDevToolsAgentImpl):

  • src/WebDevToolsAgentPrivate.h:

(WebDevToolsAgentPrivate):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::resize):

LayoutTests:

Update the test to follow the protocol change and test the "Fit window" parameter.

Reviewed by Pavel Feldman.

  • inspector/styles/override-screen-size-expected.txt:
  • inspector/styles/override-screen-size.html:
04:34 Changeset [113708] by loislo@chromium.org

Web Inspector: use maxJSObjectId that is provided by back-end.
https://bugs.webkit.org/show_bug.cgi?id=82451

Summary view can filter objects in snapshot. It uses maxJSObjectId for this.
There was no such field in the profile header at the
moment but I've landed a patch in downstream.

Reviewed by Yury Semikhatsky.

  • bindings/js/ScriptHeapSnapshot.h:

(WebCore):
(WebCore::ScriptHeapSnapshot::maxSnapshotJSObjectId):

  • bindings/v8/ScriptHeapSnapshot.cpp:

(WebCore::ScriptHeapSnapshot::maxSnapshotJSObjectId):
(WebCore):

  • bindings/v8/ScriptHeapSnapshot.h:

(WebCore):
(ScriptHeapSnapshot):

  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::createSnapshotHeader):

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.HeapSnapshotConstructorsDataGrid):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._filterSelectIndexChanged):
(WebInspector.DetailedHeapshotView.prototype._changeFilter):

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype.updateStaticData):

  • inspector/front-end/HeapSnapshotProxy.js:
04:26 Changeset [113707] by pfeldman@chromium.org

Web Inspector: annotate front-end for newer closure compiler.
https://bugs.webkit.org/show_bug.cgi?id=83478

Reviewed by Yury Semikhatsky.

This change mostly adds annotations to bound functions and !!bool expressions.
As a result, it makes closure compiler v20120305 happy.

  • inspector/Inspector.json:
  • inspector/front-end/BreakpointManager.js:
  • inspector/front-end/CSSStyleModel.js:
  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype.evalInInspectedWindow.evalCallback):
(WebInspector.ConsoleView.prototype.evalInInspectedWindow):

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode.prototype.removeAttribute):
(WebInspector.DOMAgent.prototype.pushNodeToFrontend):

  • inspector/front-end/DebuggerModel.js:
  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):

  • inspector/front-end/ElementsPanel.js:
  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):

  • inspector/front-end/ObjectPropertiesSection.js:
  • inspector/front-end/RemoteObject.js:
  • inspector/front-end/Resource.js:

(WebInspector.ResourceDomainModelBinding.prototype.canSetContent):

  • inspector/front-end/ResourceUtils.js:
  • inspector/front-end/ScopeChainSidebarPane.js:
  • inspector/front-end/Script.js:

(WebInspector.Script.prototype.editSource):

  • inspector/front-end/ScriptFormatter.js:

(WebInspector.ScriptFormatter.prototype.get _worker):

  • inspector/front-end/WorkerManager.js:
04:26 Changeset [113706] by kkristof@inf.u-szeged.hu

[Qt] Gardening after r113701.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-04-10
Reviewed by Csaba Osztrogonác.

  • platform/wk2/Skipped:
04:14 PrefixedAPIs edited by hans@chromium.org
add spec links for speech and speech input (diff)
03:56 Changeset [113705] by philn@webkit.org

Unreviewed, skip a failing test and rebaseline another one after r113611.

  • platform/gtk/Skipped:
  • platform/gtk/scrollbars/scrollbars-on-positioned-content-expected.txt:
03:55 PrefixedAPIs edited by tonyg@chromium.org
(diff)
03:38 Changeset [113704] by gyuyoung.kim@samsung.com

[EFL] Unreviewed. Gardening Add 19 missing expectations.

  • platform/efl/Skipped:
  • platform/efl/http/tests/loading/simple-subframe-expected.txt: Added.
  • platform/efl/http/tests/local/file-url-sent-as-referer-expected.txt: Added.
  • platform/efl/http/tests/misc/acid2-expected.txt: Added.
  • platform/efl/http/tests/misc/error404-expected.txt: Added.
  • platform/efl/http/tests/misc/favicon-as-image-expected.txt: Added.
  • platform/efl/http/tests/misc/frame-access-during-load-expected.txt: Added.
  • platform/efl/http/tests/misc/generated-content-inside-table-expected.txt: Added.
  • platform/efl/http/tests/misc/iframe404-expected.txt: Added.
  • platform/efl/http/tests/misc/location-replace-crossdomain-expected.txt: Added.
  • platform/efl/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt: Added.
  • platform/efl/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
  • platform/efl/http/tests/misc/slow-loading-image-in-pattern-expected.txt: Added.
  • platform/efl/http/tests/navigation/error404-basic-expected.txt: Added.
  • platform/efl/http/tests/navigation/error404-goback-expected.txt: Added.
  • platform/efl/http/tests/navigation/error404-subframeload-expected.txt: Added.
  • platform/efl/http/tests/navigation/javascriptlink-frames-expected.txt: Added.
  • platform/efl/http/tests/navigation/postredirect-basic-expected.txt: Added.
  • platform/efl/http/tests/navigation/postredirect-goback1-expected.txt: Added.
  • platform/efl/http/tests/uri/css-href-expected.txt: Added.
03:10 Changeset [113703] by kbalazs@webkit.org

[Qt][WK2] TestNetscapePlugin is broken
https://bugs.webkit.org/show_bug.cgi?id=83024

Reviewed by Csaba Osztrogonác.

Tools:

  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:

Fix X11 availability check. embedded is always true with QPA.

  • Tools.pro:

Build the test plugin if plugins are enabled for WebKit2.

  • qmake/mkspecs/features/features.prf:
  • qmake/mkspecs/features/functions.prf:

Added a convenience function to determine availability
of X11 libraries.

LayoutTests:

Remove plugins from skiplist and put the rest
of failing tests to their group.

  • platform/qt-5.0-wk2/Skipped:
02:52 Changeset [113702] by paroga@webkit.org

[WIN] Fix build without precompiled header.

  • DumpRenderTree/cg/ImageDiffCG.cpp: Define max as max as we do for min.
02:30 Changeset [113701] by ossy@webkit.org

[Qt] Gardening. Skip failing tests because of missing DnD support and ENABLE(SHADOW_DOM) is disabled.
[WK2] Skip tests because of missing layoutTestController.setAlwaysAcceptCookies().

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-04-10
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
  • platform/wk2/Skipped:
02:20 Changeset [113700] by pfeldman@chromium.org

Web Inspector: searching document with no documentElement results in 0x0 access.
https://bugs.webkit.org/show_bug.cgi?id=83483

Reviewed by Yury Semikhatsky.

Source/WebCore:

Added the null check.

Test: inspector/elements/dom-search-crash.html

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::performSearch):

LayoutTests:

  • inspector/elements/dom-search-crash-expected.txt: Added.
  • inspector/elements/dom-search-crash.html: Added.
  • inspector/elements/resources/dom-search-crash-iframe.html: Added.
02:13 Changeset [113699] by pfeldman@chromium.org

Merge 113585 - Web Inspector: [network panel] type column shows "undefined" instead of "(Pending)" upon load.
https://bugs.webkit.org/show_bug.cgi?id=83470

Reviewed by Yury Semikhatsky.

isPingRequest is tested for as a field, not a function return value.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkDataGridNode.prototype._refreshTypeCell):

TBR=pfeldman@chromium.org
BUG=122639
Review URL: https://chromiumcodereview.appspot.com/10031030

01:15 Changeset [113698] by philn@webkit.org

Unreviewed, GTK baselines for two new tests.

  • platform/gtk/fast/events/drop-with-file-paths-expected.txt: Added.
  • platform/gtk/media/nodesFromRect-shadowContent-expected.txt: Added.
00:40 Changeset [113697] by carlosgc@webkit.org

[WK2][GTK] FullScreen signals
https://bugs.webkit.org/show_bug.cgi?id=76166

Reviewed by Gustavo Noronha Silva.

  • GNUmakefile.am: Add new files to compilation.
  • UIProcess/API/C/gtk/WKFullScreenClientGtk.cpp:

(WKViewSetFullScreenClientGtk): Initialize WebKitWebViewBase
fullscreen client.

  • UIProcess/API/C/gtk/WKFullScreenClientGtk.h:
  • UIProcess/API/gtk/WebKitFullscreenClient.cpp: Added.

(willEnterFullScreen): Call webkitWebViewEnterFullScreen().
(willExitFullScreen): Call webkitWebViewLeaveFullScreen().
(attachFullScreenClientToView): Initialize FullScreenClient adding
implementations for willEnterFullScreen and willExitFullScreen callbacks.

  • UIProcess/API/gtk/WebKitFullscreenClient.h: Added.
  • UIProcess/API/gtk/WebKitPrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewConstructed): Attach fullscreen client to view.
(webkit_web_view_class_init): Add WebKitWebView::enter-fullscreen
and WebKitWebView::leave-fullscreen signals.
(webkitWebViewEnterFullScreen): Emit
WebKitWebView::enter-fullscreen signal.
(webkitWebViewLeaveFullScreen): Emit
WebKitWebView::leave-fullscreen signal.

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseKeyPressEvent): Only return early when leaving
fullscreen, otherwise let the view process the key pressed.
(webkitWebViewBaseEnterFullScreen): Return early if
willEnterFullScreen callback is handled and returns false.
(webkitWebViewBaseExitFullScreen): Return early if
willExitFullScreen callback is handled and returns false.
(webkitWebViewBaseInitializeFullScreenClient): Initialize the
fullscreen client.

  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
  • UIProcess/API/gtk/WebKitWebViewPrivate.h:
  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(testWebViewFullScreen):
(beforeAll):

  • UIProcess/API/gtk/tests/WebViewTest.cpp:

(WebViewTest::keyStroke): Helper function to synthesize key
press/release events.

  • UIProcess/API/gtk/tests/WebViewTest.h:
  • UIProcess/API/gtk/webkit2marshal.list:
  • UIProcess/gtk/WebFullScreenClientGtk.cpp:

(WebKit::WebFullScreenClientGtk::willEnterFullScreen): Call
willEnterFullScreen callback if defined.
(WebKit::WebFullScreenClientGtk::willExitFullScreen): Call
willExitFullScreen callback if defined.

  • UIProcess/gtk/WebFullScreenClientGtk.h:
00:38 Changeset [113696] by paroga@webkit.org

[CMake] Add missing source files to build system

Source/WebCore:

  • CMakeLists.txt:

Source/WebKit2:

  • CMakeLists.txt:
00:29 Changeset [113695] by haraken@chromium.org

Unreviewed. Fixed AppleWin and Chromium-win build failure.

Renamed 'exceptionNameDescription' to per-file variable name to avoid
name conflict.

  • Modules/indexeddb/IDBDatabaseException.cpp:

(WebCore::IDBDatabaseException::initializeDescription):

  • Modules/webdatabase/SQLException.cpp:

(WebCore::SQLException::initializeDescription):

  • dom/EventException.cpp:

(WebCore::EventException::initializeDescription):

  • dom/RangeException.cpp:

(WebCore::RangeException::initializeDescription):

  • fileapi/FileException.cpp:

(WebCore::FileException::initializeDescription):

  • fileapi/OperationNotAllowedException.cpp:

(WebCore::OperationNotAllowedException::initializeDescription):

  • svg/SVGException.cpp:

(WebCore::SVGException::initializeDescription):

  • xml/XPathException.cpp:

(WebCore::XPathException::initializeDescription):

00:18 Changeset [113694] by arko@motorola.com

Unreviewed: adding myself to committers.py.

  • Scripts/webkitpy/common/config/committers.py:
00:11 Changeset [113693] by haraken@chromium.org

Unreviewed. Fixed AppleWin and Chromium-win build failure.

Renamed 'exceptions' to 'exceptionNameDescription' to avoid
variable name conflict.

  • Modules/indexeddb/IDBDatabaseException.cpp:

(WebCore::IDBDatabaseException::initializeDescription):

  • Modules/webdatabase/SQLException.cpp:

(WebCore::SQLException::initializeDescription):

  • dom/EventException.cpp:

(WebCore::EventException::initializeDescription):

  • dom/RangeException.cpp:

(WebCore::RangeException::initializeDescription):

  • fileapi/FileException.cpp:

(WebCore::FileException::initializeDescription):

  • fileapi/OperationNotAllowedException.cpp:

(WebCore::OperationNotAllowedException::initializeDescription):

  • svg/SVGException.cpp:

(WebCore::SVGException::initializeDescription):

  • xml/XPathException.cpp:

(WebCore::XPathException::initializeDescription):

00:05 Changeset [113692] by philn@webkit.org

Unreviewed, GTK rebaseline.

  • platform/gtk/editing/pasteboard/interchange-newline-2-expected.txt:
  • platform/gtk/editing/selection/editable-html-element-expected.txt:
  • platform/gtk/fast/overflow/hidden-scrollbar-resize-expected.txt:
  • platform/gtk/fast/repaint/overflow-outline-repaint-expected.txt:
  • platform/gtk/http/tests/xmlhttprequest/send-array-buffer-expected.txt:
  • platform/gtk/http/tests/xmlhttprequest/send-undefined-and-null-expected.txt:

04/09/12:

23:33 Changeset [113691] by kaustubh@motorola.com

Unreviewed: adding myself to committers.py.

  • Scripts/webkitpy/common/config/committers.py:
23:24 Changeset [113690] by commit-queue@webkit.org

combine two arrays in XPathException into one
https://bugs.webkit.org/show_bug.cgi?id=83442

Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-04-09
Reviewed by Kentaro Hara.

No new tests required.

  • xml/XPathException.cpp:

(XPathExceptionNameDescription):
(WebCore):
(WebCore::XPathException::initializeDescription):

23:18 Changeset [113689] by commit-queue@webkit.org

combine exceptionNames and exceptionDescriptions in IDBDatabaseException.cpp into one array
https://bugs.webkit.org/show_bug.cgi?id=83433

Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-04-09
Reviewed by Kentaro Hara.

No new tests required.

  • Modules/indexeddb/IDBDatabaseException.cpp:

(IDBDatabaseExceptionNameDescription):
(WebCore):
(WebCore::IDBDatabaseException::initializeDescription):

23:07 Changeset [113688] by tkent@chromium.org

[Chromium] Remove unused variable, WebViewImpl::m_lastMousePosition.
https://bugs.webkit.org/show_bug.cgi?id=83550

Reviewed by Kentaro Hara.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::mouseMove):

  • src/WebViewImpl.h:
22:54 Changeset [113687] by commit-queue@webkit.org

combine two arrays in SQLException.cpp into one
https://bugs.webkit.org/show_bug.cgi?id=83452

Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-04-09
Reviewed by Kentaro Hara.

No new tests required.

  • Modules/webdatabase/SQLException.cpp:

(SQLExceptionNameDescription):
(WebCore):
(WebCore::SQLException::initializeDescription):

22:51 Changeset [113686] by commit-queue@webkit.org

combine two arrays in EventException.cpp into one
https://bugs.webkit.org/show_bug.cgi?id=83451

Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-04-09
Reviewed by Kentaro Hara.

No new tests required.

  • dom/EventException.cpp:

(EventExceptionNameDescription):
(WebCore):
(WebCore::EventException::initializeDescription):

22:50 Changeset [113685] by commit-queue@webkit.org

combine two arrays in RangeException.cpp into one
https://bugs.webkit.org/show_bug.cgi?id=83450

Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-04-09
Reviewed by Kentaro Hara.

No new tests required.

  • dom/RangeException.cpp:

(RangeExceptionNameDescription):
(WebCore):
(WebCore::RangeException::initializeDescription):

22:47 Changeset [113684] by noam.rosenthal@nokia.com

[Texmap] Improve TextureMapperGL readability
https://bugs.webkit.org/show_bug.cgi?id=83477

Change the debugging macros for TextureMapperGL, so that the GL_CMD call can include a semicolon.
Modify some if blocks to have an early return.

Reviewed by Martin Robinson.

No new functionality.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGLData::SharedGLData::scissorClip):
(WebCore::TextureMapperGLData::SharedGLData::applyCurrentClip):
(WebCore::TextureMapperGLData::SharedGLData::~SharedGLData):
(WebCore::TextureMapperGLData::initializeStencil):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::TextureMapperGL::endPainting):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::BitmapTextureGL::didReset):
(WebCore::BitmapTextureGL::updateContents):
(WebCore::BitmapTextureGL::initializeStencil):
(WebCore::BitmapTextureGL::bind):
(WebCore::BitmapTextureGL::~BitmapTextureGL):
(WebCore::TextureMapperGL::bindSurface):
(WebCore::TextureMapperGL::beginClip):

22:45 Changeset [113683] by commit-queue@webkit.org

combine two arrays in FileException.cpp into one
https://bugs.webkit.org/show_bug.cgi?id=83449

Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-04-09
Reviewed by Kentaro Hara.

No new tests required.

  • fileapi/FileException.cpp:

(FileExceptionNameDescription):
(WebCore):
(WebCore::FileException::initializeDescription):

22:43 Changeset [113682] by commit-queue@webkit.org

combine two arrays in OperationNotAllowedException.cpp into one
https://bugs.webkit.org/show_bug.cgi?id=83445

Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-04-09
Reviewed by Kentaro Hara.

No new tests required.

  • fileapi/OperationNotAllowedException.cpp:

(OperationNotAllowedExceptionNameDescription):
(WebCore):
(WebCore::OperationNotAllowedException::initializeDescription):

22:39 Changeset [113681] by shinyak@chromium.org

Assert triggers VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries.
https://bugs.webkit.org/show_bug.cgi?id=83118

Reviewed by Hajime Morita.

Source/WebCore:

VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries did not work correctly.
There was a case that selection crosses shadow boundaries.

This patch introduces a class TreeScopeAdjuster, which enables us to adjust Node or Position
into a specified tree scope.

Test: fast/dom/shadow/selections-in-shadow.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.ext.in:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/TreeScope.h:

(TreeScope):

  • dom/TreeScopeAdjuster.cpp: Added.

(WebCore):
(WebCore::TreeScopeAdjuster::TreeScopeAdjuster):
(WebCore::TreeScopeAdjuster::ancestorInThisScope):

Returns the node itself if it's in the same tree scope.
Otherwise, this method checks the shadow ancestor of the node recursively.
If no corresponding node is found, 0 will be returned.

(WebCore::TreeScopeAdjuster::adjustPositionBefore):
(WebCore::TreeScopeAdjuster::adjustPositionAfter):

  • dom/TreeScopeAdjuster.h: Added.

(WebCore):
(TreeScopeAdjuster):
(WebCore::TreeScopeAdjuster::treeScope):

  • editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries):

LayoutTests:

This tests checks all the combination of element not in a shadow tree, element in a shadow tree,
element in a nested shadow tree, element in a non-youngest shadow tree, element in a nested shadow tree
in non-youngest shadow treee.

  • fast/dom/resources/event-sender-util.js: Added.

(mouseMoveToElem):

  • fast/dom/shadow/selections-in-shadow-expected.txt: Added.
  • fast/dom/shadow/selections-in-shadow.html: Added.
22:36 Changeset [113680] by commit-queue@webkit.org

combine two arrays in SVGException.cpp into one
https://bugs.webkit.org/show_bug.cgi?id=83444

Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-04-09
Reviewed by Kentaro Hara.

No new tests required.

  • svg/SVGException.cpp:

(SVGExceptionNameDescription):
(WebCore):
(WebCore::SVGException::initializeDescription):

22:30 Changeset [113679] by commit-queue@webkit.org

combine two arrays in XMLHttpRequestException.cpp into one
https://bugs.webkit.org/show_bug.cgi?id=83443

Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-04-09
Reviewed by Kentaro Hara.

No new tests requied.

  • xml/XMLHttpRequestException.cpp:

(XMLHttpRequestExceptionNameDescription):
(WebCore):
(WebCore::XMLHttpRequestException::initializeDescription):

21:57 Changeset [113678] by noam.rosenthal@nokia.com

[WK2] Enable using a single ShareableBitmap for multiple updates
https://bugs.webkit.org/show_bug.cgi?id=83424

Source/WebCore:

Modify BitmapTexture::updateContents to include a source offset.
This allows us to update a texture from a sub-image.

Reviewed by Kenneth Rohde Christiansen.

Tested by existing API tests.

  • platform/graphics/texmap/TextureMapper.h:

(BitmapTexture):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::didReset):
(WebCore::driverSupportsBGRASwizzling):
(WebCore::BitmapTextureGL::updateContents):

  • platform/graphics/texmap/TextureMapperGL.h:

(WebCore::BitmapTextureGL::textureTarget):
(BitmapTextureGL):

  • platform/graphics/texmap/TextureMapperImageBuffer.cpp:

(WebCore::BitmapTextureImageBuffer::updateContents):

  • platform/graphics/texmap/TextureMapperImageBuffer.h:

(BitmapTextureImageBuffer):

Source/WebKit2:

Reviewed by Kenneth Rohde Christiansen.

Enabled creating a GraphicsContext that references a rect inside ShareableBitmap.
Added bitmapOffset to UpdateInfo, to allow updates to reference an offset inside the bitmap.
Added UpdateAtlas, a class that manages available rects in a larger ShareableBitmap.

In this iteration, UpdateAtlas has a simple behavior where a rect inside the bitmap is
either available or used. When the buffers are swapped, all used buffers become available
again. A future enhancement might allow triple-buffering, where available rects can be
updated while other rects from the same atlas are in use.

Added the necessary plumbing to allow Qt's UI-side compositing to take advantage of
UpdateAtlas. LayerTreeHostQt creates an atlas per type of bitmap (i.e. one opaque and one
alpha-enabled atlas). When a tile wants to update and there's no available scratch-buffer,
the update would be postponed to the next frame, creating a tiling-artifact in low memory
situations.

  • Shared/UpdateInfo.cpp:

(WebKit::UpdateInfo::encode):
(WebKit::UpdateInfo::decode):

  • Shared/UpdateInfo.h:

(UpdateInfo):

  • Target.pri:
  • UIProcess/LayerTreeHostProxy.cpp:

(WebKit::LayerTreeHostProxy::updateTileForLayer):

  • UIProcess/WebLayerTreeRenderer.cpp:

(WebKit::WebLayerTreeRenderer::syncLayerParameters):
(WebKit::WebLayerTreeRenderer::updateTile):
(WebKit::WebLayerTreeRenderer::createImage):

  • UIProcess/WebLayerTreeRenderer.h:

(TileUpdate):
(WebKit::WebLayerTreeRenderer::TileUpdate::TileUpdate):
(WebLayerTreeRenderer):

  • UIProcess/qt/LayerBackingStore.cpp:

(WebKit::LayerBackingStoreTile::swapBuffers):
(WebKit::LayerBackingStoreTile::setBackBuffer):
(WebKit::LayerBackingStore::createTile):

  • UIProcess/qt/LayerBackingStore.h:

(LayerBackingStoreTile):
(LayerBackingStore):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::tiledBackingStoreBackgroundColor):
(WebCore::WebGraphicsLayer::beginContentUpdate):
(WebCore):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:

(WebGraphicsLayerClient):
(WebGraphicsLayer):

  • WebProcess/WebPage/TiledBackingStoreRemoteTile.cpp:

(WebKit::TiledBackingStoreRemoteTile::updateBackBuffer):

  • WebProcess/WebPage/TiledBackingStoreRemoteTile.h:

(TiledBackingStoreRemoteTileClient):

  • WebProcess/WebPage/UpdateAtlas.cpp: Added.

(WebKit):
(WebKit::UpdateAtlas::UpdateAtlas):
(WebKit::nextPowerOfTwo):
(WebKit::UpdateAtlas::buildLayoutIfNeeded):
(WebKit::UpdateAtlas::findAvailableIndex):
(WebKit::UpdateAtlas::didSwapBuffers):
(WebKit::UpdateAtlas::acquireScratchBuffer):
(WebKit::UpdateAtlas::offsetForIndex):

  • WebProcess/WebPage/UpdateAtlas.h: Added.

(WebCore):
(WebKit):
(UpdateAtlas):
(WebKit::UpdateAtlas::bitmap):
(WebKit::UpdateAtlas::size):
(WebKit::UpdateAtlas::flags):

  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::adoptImageBackingStore):
(WebKit::LayerTreeHostQt::renderNextFrame):
(WebKit::LayerTreeHostQt::purgeBackingStores):
(WebKit):
(WebKit::LayerTreeHostQt::getAtlas):
(WebKit::LayerTreeHostQt::beginContentUpdate):

  • WebProcess/WebPage/qt/LayerTreeHostQt.h:

(LayerTreeHostQt):

21:54 Changeset [113677] by danakj@chromium.org

[chromium] Viewport is not filled when out of texture memory on mac
https://bugs.webkit.org/show_bug.cgi?id=83351

Reviewed by Adrienne Walker.

Source/Platform:

  • chromium/public/WebLayerTreeView.h:

(WebLayerTreeView):

Source/WebCore:

Currently we add gutter quads on the NonCompositedContentHost layer,
which lies above another visible layer - the rubberband layer on mac.
For this reason, on mac, gutter quads were disabled, as well as forcing
the NCCH layer to draw, in order to make the rubberband layer appear.

We move the logic for adding gutter quads into CCRenderPass, and add
gutter quads for all pixels that are visible through the viewport.
This allows us to stop special-casing the NCCH layer, and allows us
to skip drawing the layer equally with other layers. We remove the
backgroundCoversViewport() flag entirely.

In order to do this, we fix a bug in the occlusion tracker, that
allowed opaque() layers with skipsDraw to occlude, by making
the visibleContentOpaqueRegion() method on the layer classes
also return the opaque region for non-tiled layers, always use
its value in the occlusion tracker.

Unit test: CCLayerTreeHostImplTest.viewportCovered

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::pushPropertiesTo):
(WebCore::LayerChromium::visibleContentOpaqueRegion):
(WebCore):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::prepareToUpdateTiles):
(WebCore::TiledLayerChromium::visibleContentOpaqueRegion):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::visibleContentOpaqueRegion):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::appendQuads):
(CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeHost::setBackgroundColor):
(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore::CCLayerTreeHostImpl::backgroundColor):
(WebCore::CCLayerTreeHostImpl::setBackgroundColor):
(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::computeOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):

  • platform/graphics/chromium/cc/CCOcclusionTracker.h:

(CCOcclusionTrackerBase):
(WebCore::CCOcclusionTrackerBase::computeVisibleRegionInScreen):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::appendQuadsToFillScreen):
(WebCore):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(WebCore):
(CCRenderPass):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::appendQuads):
(WebCore::CCTiledLayerImpl::visibleContentOpaqueRegion):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:

(WebCore::CCTiledLayerImpl::skipsDraw):
(CCTiledLayerImpl):

Source/WebKit/chromium:

  • src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setBackgroundColor):

  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::setBackgroundColor):
(WebKit):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setBackgroundColor):
(WebKit):
(WebKit::WebViewImplContentPainter::paint):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • src/WebViewImpl.h:

(WebCore):
(WebViewImpl):

  • tests/CCLayerImplTest.cpp:

(WebCore::TEST):

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKitTests::BlendStateCheckLayer::appendQuads):
(WebKitTests::TEST_F):
(WebKitTests):

  • tests/CCLayerTreeHostTest.cpp:

(WTF):
(CCLayerTreeHostTestCommit):
(WTF::CCLayerTreeHostTestCommit::CCLayerTreeHostTestCommit):
(WTF::CCLayerTreeHostTestCommit::beginTest):
(WTF::CCLayerTreeHostTestCommit::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestCommit::afterTest):
(WTF::TEST_F):
(TestLayerChromium):

  • tests/CCOcclusionTrackerTest.cpp:

(WebKitTests::TestContentLayerChromium::TestContentLayerChromium):
(WebKitTests::TestContentLayerChromium::visibleContentOpaqueRegion):
(WebKitTests::TestContentLayerChromium::setOpaqueContentsRect):
(TestContentLayerChromium):
(WebKitTests::TestContentLayerImpl::TestContentLayerImpl):
(TestContentLayerImpl):
(WebKitTests::TestContentLayerImpl::visibleContentOpaqueRegion):
(WebKitTests::TestContentLayerImpl::setOpaqueContentsRect):

  • tests/CCTiledLayerImplTest.cpp:
  • tests/LayerChromiumTest.cpp:
21:47 Changeset [113676] by macpherson@chromium.org

Don't let CSSPropertyWebkitPerspective dereference primitiveValue without null check.
https://bugs.webkit.org/show_bug.cgi?id=83538

Reviewed by Daniel Bates.

No new tests / code cleanup only.

Coverity pointed out that we potentially dereference primitiveValue here without checking for null.
I've added an early out for that case to make sure it can't ever happen. I don't know if it's actually
possible to exercise that code path or not - probably the parser prevents it from being hit in practice.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

21:42 Changeset [113675] by commit-queue@webkit.org

<http://webkit.org/b/83539> Web Inspector: ASSERT attempting to unbind null contentDocument

Avoid calling unbind with a null object. The HTMLFrameOwnerElement's
contentDocument can be null.

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2012-04-09
Reviewed by Timothy Hatcher.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::unbind):

21:27 Changeset [113674] by commit-queue@webkit.org

[BlackBerry] Parsed Cookie's m_isMaxAgeSet is not needed.
https://bugs.webkit.org/show_bug.cgi?id=83457

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-09
Reviewed by Rob Buis.

When m_expiry is not -1, it must be set by setExpiry or setMaxAge. setExpiry will return when m_expiry
has been set. This ensures Max-Age's precedence.
And m_isMaxAgeSet is always false when the cookie is from database. This is not right.

So we use m_expiry instead of m_isMaxAgeSet.

No new tests. Refactor.

  • platform/blackberry/ParsedCookie.cpp:

(WebCore::ParsedCookie::ParsedCookie):
(WebCore::ParsedCookie::setExpiry):
(WebCore::ParsedCookie::setMaxAge):

  • platform/blackberry/ParsedCookie.h:

(ParsedCookie):

21:05 Changeset [113673] by commit-queue@webkit.org

Fixed ordering of deleting CCInputHandler and CCLayerTreeHostImpl in layerTreeHostClosedOnImplThread
https://bugs.webkit.org/show_bug.cgi?id=83488

Patch by Min Qin <qinmin@google.com> on 2012-04-09
Reviewed by James Robinson.

CCInputHandler(WebCompositorInputHandlerImpl) has a pointer to CCLayerTreeHostImpl.
So we should delete CCInputHandler earlier as otherwise that pointer could get misused after LayerTreeHostImpl is deleted.
Just fixing a potential NPE error, no behavior change.

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::layerTreeHostClosedOnImplThread):

20:59 Changeset [113672] by efidler@rim.com

[BlackBerry] Update about:config page
https://bugs.webkit.org/show_bug.cgi?id=83515

Reviewed by Rob Buis.

  • WebCoreSupport/AboutData.cpp:

(WebCore::configPage):

  • WebCoreSupport/AboutDataEnableFeatures.in:
  • WebCoreSupport/AboutDataHaveFeatures.in:
  • WebCoreSupport/AboutDataUseFeatures.in:
20:46 Changeset [113671] by commit-queue@webkit.org

Unreviewed, rolling out r113656.
http://trac.webkit.org/changeset/113656
https://bugs.webkit.org/show_bug.cgi?id=83542

test is broken on chromium-win (Requested by simonjam on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-09

Source/WebCore:

  • Modules/intents/Intent.cpp:

(WebCore::Intent::Intent):

  • Modules/intents/Intent.h:

(Intent):

  • Modules/intents/Intent.idl:
  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateParametersCheck):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

Source/WebKit/chromium:

  • public/WebIntent.h:

(WebIntent):

  • src/WebIntent.cpp:

Tools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::dispatchIntent):

LayoutTests:

  • webintents/web-intents-invoke-port-expected.txt: Removed.
  • webintents/web-intents-invoke-port.html: Removed.
20:41 Changeset [113670] by inferno@chromium.org

ASSERTION FAILED: !attached() in Node::attach.
https://bugs.webkit.org/show_bug.cgi?id=80726

Reviewed by Adam Barth.

Source/WebCore:

While parsing XML document, prevent attaching the leaf text node
back to document, if its parent is not attached.

Test: fast/dom/text-node-attach-crash.xhtml

  • xml/parser/XMLDocumentParser.cpp:

(WebCore::XMLDocumentParser::exitText):

LayoutTests:

  • fast/dom/text-node-attach-crash-expected.txt: Added.
  • fast/dom/text-node-attach-crash.xhtml: Added.
20:39 Changeset [113669] by simonjam@chromium.org

[Chromium] Unreviewed gardening.

  • platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.txt: Added.
  • platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
20:11 Changeset [113668] by danakj@chromium.org

[chromium] Replica layers are not drawn, so should not be painted
https://bugs.webkit.org/show_bug.cgi?id=83504

Reviewed by James Robinson.

We attempt to paint replica layers when we are painting the mask layers
in CCLayerTreeHost.cpp.

This is useless code, replica layers have drawsContent() == false, and
have an empty visibleLayerRect, so the paint functions end up early-
outting. But it is a waste of time to try, and confusing to have
this attempted in the code at all, since the replica layers are never
drawn. They exist only for their transforms.

Also the dimensions used for the replica mask are different from the
surface mask, which is confusing and unnecessary as well. The mask is
applied to the same surface contents as the surface mask would be, so
only the surface's contentBounds need to be painted in the replica
mask.

Covered by existing tests.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintMasksForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
20:05 Changeset [113667] by shinyak@chromium.org

ShadowRoot should have selection attribute.
https://bugs.webkit.org/show_bug.cgi?id=82429

Reviewed by Hajime Morita.

Source/WebCore:

This patch makes ShadowRoot have selection attribute. Currently the selection returns
the same object as what window.getSelection() returns.

We will extend DOMSelection to have TreeScope. It will adjust Node into TreeScope.
This will be tracked in Bug 82698.

Test: fast/dom/shadow/selection-in-shadow.html

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::selection):
(WebCore):

  • dom/ShadowRoot.h:

(WebCore):
(ShadowRoot):

  • dom/ShadowRoot.idl:

LayoutTests:

Checks ShadowRoot.selection returns the same selection as what window.getSelection() returns.

  • fast/dom/shadow/selection-in-shadow.html: Added.
20:02 Changeset [113666] by rakuco@webkit.org

[EFL] Gardening in fast/text/whitespace.

The last commit to these baselines had some weird fonts for some
reason, fix the expected sizes.

  • platform/efl/fast/text/whitespace/002-expected.png:
  • platform/efl/fast/text/whitespace/002-expected.txt:
  • platform/efl/fast/text/whitespace/003-expected.png:
  • platform/efl/fast/text/whitespace/003-expected.txt:
  • platform/efl/fast/text/whitespace/004-expected.png:
  • platform/efl/fast/text/whitespace/004-expected.txt:
  • platform/efl/fast/text/whitespace/005-expected.png:
  • platform/efl/fast/text/whitespace/005-expected.txt:
  • platform/efl/fast/text/whitespace/006-expected.png:
  • platform/efl/fast/text/whitespace/006-expected.txt:
  • platform/efl/fast/text/whitespace/007-expected.png:
  • platform/efl/fast/text/whitespace/007-expected.txt:
  • platform/efl/fast/text/whitespace/008-expected.png:
  • platform/efl/fast/text/whitespace/008-expected.txt:
  • platform/efl/fast/text/whitespace/009-expected.png:
  • platform/efl/fast/text/whitespace/009-expected.txt:
  • platform/efl/fast/text/whitespace/010-expected.png:
  • platform/efl/fast/text/whitespace/010-expected.txt:
  • platform/efl/fast/text/whitespace/011-expected.png:
  • platform/efl/fast/text/whitespace/011-expected.txt:
  • platform/efl/fast/text/whitespace/012-expected.png:
  • platform/efl/fast/text/whitespace/012-expected.txt:
  • platform/efl/fast/text/whitespace/013-expected.png:
  • platform/efl/fast/text/whitespace/013-expected.txt:
  • platform/efl/fast/text/whitespace/014-expected.png:
  • platform/efl/fast/text/whitespace/014-expected.txt:
  • platform/efl/fast/text/whitespace/015-expected.png:
  • platform/efl/fast/text/whitespace/015-expected.txt:
  • platform/efl/fast/text/whitespace/016-expected.png:
  • platform/efl/fast/text/whitespace/016-expected.txt:
  • platform/efl/fast/text/whitespace/018-expected.png:
  • platform/efl/fast/text/whitespace/018-expected.txt:
  • platform/efl/fast/text/whitespace/020-expected.png:
  • platform/efl/fast/text/whitespace/020-expected.txt:
  • platform/efl/fast/text/whitespace/021-expected.png:
  • platform/efl/fast/text/whitespace/021-expected.txt:
  • platform/efl/fast/text/whitespace/025-expected.png:
  • platform/efl/fast/text/whitespace/025-expected.txt:
  • platform/efl/fast/text/whitespace/027-expected.png:
  • platform/efl/fast/text/whitespace/027-expected.txt:
  • platform/efl/fast/text/whitespace/030-expected.png:
  • platform/efl/fast/text/whitespace/030-expected.txt:
  • platform/efl/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
  • platform/efl/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
  • platform/efl/fast/text/whitespace/pre-break-word-expected.png:
  • platform/efl/fast/text/whitespace/pre-break-word-expected.txt:
  • platform/efl/fast/text/whitespace/pre-wrap-last-char-expected.png:
  • platform/efl/fast/text/whitespace/pre-wrap-last-char-expected.txt:
  • platform/efl/fast/text/whitespace/pre-wrap-line-test-expected.png:
  • platform/efl/fast/text/whitespace/pre-wrap-line-test-expected.txt:
  • platform/efl/fast/text/whitespace/pre-wrap-overflow-selection-expected.png:
  • platform/efl/fast/text/whitespace/pre-wrap-overflow-selection-expected.txt:
  • platform/efl/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png:
  • platform/efl/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
19:54 Changeset [113665] by eae@chromium.org

Replace numeric_limits<LayoutUnit>::min/max with constants
https://bugs.webkit.org/show_bug.cgi?id=83497

Reviewed by Eric Seidel.

Replace all uses of numeric_limits<LayoutUnit>::min/max with
MIN_LAYOUT_UNIT and MAX_LAYOUT_UNIT respectively in preparation for the
switch to subpixel layout.

Also rename zeroLayoutUnit to ZERO_LAYOUT_UNIT to be consistent and
change it to be a define as to avoid global initializer warnings once we
change the definition of LayoutUnit from int to FractionalLayoutUnit.

No new tests, no change in functionality.

  • dom/ElementRareData.h:

(WebCore::defaultMinimumSizeForResizing):

  • editing/FrameSelection.cpp:

(WebCore::NoXPosForVerticalArrowNavigation):

  • platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::clampEdgeValue):
(WebCore::TransformationMatrix::clampedBoundsOfProjectedQuad):

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::computePreferredLogicalWidths):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
(WebCore::InlineFlowBox::addBorderOutsetVisualOverflow):
(WebCore::InlineFlowBox::paintFillLayer):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):
(WebCore::InlineFlowBox::computeOverAnnotationAdjustment):

  • rendering/LayoutTypes.h:

(WebCore):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::computeInitialRegionRangeForBlock):
(WebCore::RenderBlock::adjustFloatingBlock):
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::nextFloatLogicalBottomBelow):
(WebCore::RenderBlock::markLinesDirtyInBlockRange):
(WebCore::RenderBlock::clearFloats):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::getClearDelta):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
(WebCore::getHeightForLineCount):
(WebCore::RenderBlock::borderFitAdjust):
(WebCore::RenderBlock::adjustForUnsplittableChild):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::paginationStrut):
(WebCore::RenderBlock::pageLogicalOffset):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineLayoutState::updateRepaintRangeFromBox):
(WebCore::RenderBlock::checkFloatsInCleanLine):
(WebCore::RenderBlock::addOverflowFromInlineChildren):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::shrinkLogicalWidthToAvoidFloats):
(WebCore::RenderBox::positionForPoint):

  • rendering/RenderBox.h:

(WebCore::RenderBox::minYVisualOverflow):
(WebCore::RenderBox::minXVisualOverflow):
(RenderBox):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::offsetLeft):
(WebCore::RenderBoxModelObject::offsetTop):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
(WebCore::RenderDeprecatedFlexibleBox::allowedChildFlex):

  • rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::paintBoxDecorations):
(WebCore::RenderFieldset::paintMask):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::repositionLogicalHeightDependentFlexItems):
(WebCore::RenderFlexibleBox::lineBreakLength):
(WebCore::RenderFlexibleBox::alignChildren):
(WebCore::RenderFlexibleBox::applyStretchAlignmentToChild):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::computeLogicalWidth):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::linesVisualOverflowBoundingBox):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::resize):

  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::updateMargins):

  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::computePosition):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::repaintAfterLayoutIfNeeded):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeReplacedLogicalWidth):
(WebCore::RenderReplaced::computePreferredLogicalWidths):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
(WebCore::RenderTable::layout):

  • rendering/RenderTable.h:

(WebCore::RenderTable::bordersPaddingAndSpacingInRowDirection):

  • rendering/RenderText.cpp:

(WebCore::RenderText::linesVisualOverflowBoundingBox):

19:50 Changeset [113664] by rakuco@webkit.org

[EFL] Gardening in transforms/2d.

Mostly account for the changes caused by the jhbuild and font
commits.

  • platform/efl/transforms/2d/compound-transforms-vs-containers-expected.png:
  • platform/efl/transforms/2d/hindi-rotated-expected.png:
  • platform/efl/transforms/2d/transform-borderbox-expected.png:
  • platform/efl/transforms/2d/transform-fixed-container-expected.png:
  • platform/efl/transforms/2d/transform-origin-borderbox-expected.png:
19:32 Changeset [113663] by leviw@chromium.org

Clean up LayoutUnit usage in DOMNodeHighlighter
https://bugs.webkit.org/show_bug.cgi?id=83507

Reviewed by Eric Seidel.

Ensuring DOMNodeHighlighter uses pixel snapping that matches that done in the RenderTree. Changes include:

  • Reverting drawSubstring to use an IntPoint with pixel snapped values instead of a LayoutPoint.
  • Reverting borderBox to an IntRect since it's in absolute coordinates. See https://trac.webkit.org/wiki/LayoutUnit.
  • Frames are still laid out with integers. Cleaning up mainFrameOffset to reflect that.

No new tests. No change in behavior.

  • inspector/DOMNodeHighlighter.cpp:
19:26 Changeset [113662] by commit-queue@webkit.org

Add missing IndexedDB files to CMake build
https://bugs.webkit.org/show_bug.cgi?id=83495

Patch by Jeff Rogers <jrogers@rim.com> on 2012-04-09
Reviewed by Rob Buis.

  • CMakeLists.txt:
  • UseJSC.cmake:
19:13 Changeset [113661] by bdakin@apple.com

https://bugs.webkit.org/show_bug.cgi?id=83411

All Mac bots occasionally fail tons of media/ sputnik/ and svg/ tests

This is a speculative fix.

  • platform/mac/Skipped:
19:12 Changeset [113660] by barraclough@apple.com

If a callback constructor returns a C++ null, throw a type error.
https://bugs.webkit.org/show_bug.cgi?id=83537

Rubber Stamped by Geoff Garen.

  • API/JSCallbackConstructor.cpp:

(JSC::constructJSCallback):

  • If a callback constructor returns a C++ null, throw a type error.
  • API/tests/testapi.c:

(Base_returnHardNull):

  • API/tests/testapi.js:
    • Add a test case for callback constructors that return a C++ null.
19:06 Changeset [113659] by ap@apple.com

[Mac] WebProcess dies due to m_process->checkURLReceivedFromWebProcess(url) dropping a file URL
https://bugs.webkit.org/show_bug.cgi?id=83506
<rdar://problem/11171264>

Reviewed by Darin Adler.

Cannot test, because dragging within a single window never initiates a navigation, and dragging
across windows is too much for DRT and WTR.

  • platform/mac/DragDataMac.mm: (WebCore::DragData::asURL): Add the same checks that we had

for NSURLPboardType to NSStringPboardType case, preventing dropping of non-HTTP URLs.
String types cannot be sanitized when they are modified by JavaScript, and are thus less trusted.
String checks should be at least as restrictive as URL ones.

19:05 Changeset [113658] by jamesr@google.com

[chromium] More unreviewed OwnPtr<>::operator= related clang build fixes in unit tests.

  • tests/Canvas2DLayerChromiumTest.cpp:
  • tests/LayerChromiumTest.cpp:
18:53 Changeset [113657] by paroga@webkit.org

Port BinarySemaphoreWin.cpp to WinCE
https://bugs.webkit.org/show_bug.cgi?id=83502

Reviewed by Daniel Bates.

Replace WaitForSingleObjectEx with WaitForSingleObject since
the additonal parameter supported by the extended function
is not used anyway and the function does not exist on WinCE.

  • wtf/CMakeLists.txt:
  • wtf/PlatformWinCE.cmake:
  • wtf/threads/win/BinarySemaphoreWin.cpp:

(WTF::BinarySemaphore::wait):

18:46 Changeset [113656] by commit-queue@webkit.org

Add transfer map argument to Intent constructor
http://dvcs.w3.org/hg/web-intents/raw-file/tip/spec/Overview.html
This adds the ability to pass transferables (i.e. MessagePorts)
through web intents, and puts the calling convention in line
with the Web Messaging spec:
http://dev.w3.org/html5/postmsg/

Implementation in chromium API follows the port-passing method
of PlatformMessagePortChannel.

https://bugs.webkit.org/show_bug.cgi?id=80200

Patch by Greg Billock <gbillock@google.com> on 2012-04-09
Reviewed by Adam Barth.

  • Modules/intents/Intent.cpp:

(WebCore::Intent::create):

  • Modules/intents/Intent.idl:
  • WebCore.gypi:
  • bindings/v8/custom/V8IntentCustom.cpp: Added.

(WebCore):
(WebCore::V8Intent::constructorCallback):

18:44 Changeset [113655] by toyoshim@chromium.org

Update pywebsocket to 0.7.4.
https://bugs.webkit.org/show_bug.cgi?id=83461

Reviewed by Kent Tamura.

This version supports TLS by using ssl in addition to pyOpenSSL.
Other functional difrerences from 0.7.2 are:

  • strict Sec-WebSocket-Key validation conforming RFC 4648
  • compression ratio logging in debug
  • Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook._install_pywebsocket):

18:41 Changeset [113654] by barraclough@apple.com

If a callback function returns a C++ null, convert to undefined.
https://bugs.webkit.org/show_bug.cgi?id=83534

Reviewed by Geoff Garen.

  • API/JSCallbackFunction.cpp:
    • If a callback function returns a C++ null, convert to undefined.

(JSC::JSCallbackFunction::call):

  • API/tests/testapi.c:

(Base_returnHardNull):

  • API/tests/testapi.js:
    • Add a test case for callback functions that return a C++ null.
18:30 Changeset [113653] by simonjam@chromium.org

[Chromium] Unreviewed gardening.

  • platform/chromium-linux/media/media-document-audio-repaint-expected.png:
  • platform/chromium-linux/media/media-document-audio-repaint-expected.txt: Added.
  • platform/chromium-linux/scrollbars/scrollbars-on-positioned-content-expected.png:
  • platform/chromium-mac-leopard/scrollbars/scrollbars-on-positioned-content-expected.png:
  • platform/chromium-mac-snowleopard/scrollbars/scrollbars-on-positioned-content-expected.png:
  • platform/chromium-mac/fast/forms/basic-textareas-expected.png:
  • platform/chromium-mac/fast/overflow/hidden-scrollbar-resize-expected.txt: Added.
  • platform/chromium-mac/scrollbars/scrollbars-on-positioned-content-expected.png:
  • platform/chromium-mac/scrollbars/scrollbars-on-positioned-content-expected.txt: Copied from LayoutTests/platform/chromium-win/scrollbars/scrollbars-on-positioned-content-expected.txt.
  • platform/chromium-win/fast/overflow/hidden-scrollbar-resize-expected.txt:
  • platform/chromium-win/scrollbars/scrollbars-on-positioned-content-expected.png:
  • platform/chromium-win/scrollbars/scrollbars-on-positioned-content-expected.txt:
18:23 Changeset [113652] by danakj@chromium.org

[chromium] Cull occluded surface quads
https://bugs.webkit.org/show_bug.cgi?id=81227

Reviewed by Adrienne Walker.

Source/WebCore:

Cull render surface and replica quads during draw based on occlusion.

In order to compute occlusion for the surface or replica, it must not
consider occlusion found in the surface's own subtree. To do this, we
reorder the calls to the occlusion tracker, and add the surface and
replica quads before we "leaveToTargetRenderSurface" which merges
occlusion from the surface's subtree up into its parent.

Unit test: CCOcclusionTrackerTestReplicaOccluded

CCOcclusionTrackerTestSurfaceWithReplicaUnoccluded
CCOcclusionTrackerTestSurfaceAndReplicaOccludedDifferently
CCOcclusionTrackerTestSurfaceChildOfSurface
CCOcclusionTrackerTestSurfaceChildOfClippingSurface

And added some sanity checks to other CCOcclusionTracker tests that have
render surfaces.

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::::leaveToTargetRenderSurface):
(WebCore::::unoccludedContributingSurfaceContentRect):
(WebCore):

  • platform/graphics/chromium/cc/CCOcclusionTracker.h:

(CCOcclusionTrackerBase):

  • platform/graphics/chromium/cc/CCQuadCuller.cpp:

(WebCore::CCQuadCuller::CCQuadCuller):
(WebCore::appendQuadInternal):
(WebCore::CCQuadCuller::append):
(WebCore):
(WebCore::CCQuadCuller::appendSurface):
(WebCore::CCQuadCuller::appendReplica):

  • platform/graphics/chromium/cc/CCQuadCuller.h:

(CCQuadCuller):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::appendQuadsForRenderSurfaceLayer):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(CCRenderPass):

Source/WebKit/chromium:

  • tests/CCOcclusionTrackerTest.cpp:

(WebKitTests::CCOcclusionTrackerTest::TearDown):
(WebKitTests::CCOcclusionTrackerTest::createReplicaLayer):
(CCOcclusionTrackerTest):
(WebKitTests::CCOcclusionTrackerTest::setReplica):
(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationTranslateOnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceOcclusionTranslatesWithClipping::runMyTest):
(WebKitTests):
(CCOcclusionTrackerTestReplicaOccluded):
(WebKitTests::CCOcclusionTrackerTestReplicaOccluded::runMyTest):
(CCOcclusionTrackerTestSurfaceWithReplicaUnoccluded):
(WebKitTests::CCOcclusionTrackerTestSurfaceWithReplicaUnoccluded::runMyTest):
(CCOcclusionTrackerTestSurfaceAndReplicaOccludedDifferently):
(WebKitTests::CCOcclusionTrackerTestSurfaceAndReplicaOccludedDifferently::runMyTest):
(CCOcclusionTrackerTestSurfaceChildOfSurface):
(WebKitTests::CCOcclusionTrackerTestSurfaceChildOfSurface::runMyTest):

18:19 Changeset [113651] by rniwa@webkit.org

Update perf-o-matic config.js per upstream change.

  • Websites/webkit-perf.appspot.com/js/config.js:

(var):

18:10 Changeset [113650] by jamesr@google.com

[chromium] Unreviewed build fix. OwnPtr<>::operator = breaks the build on clang, but not gcc :(

  • tests/CCLayerTreeHostTest.cpp:

(WTF::MockLayerTreeHost::create):

  • tests/Canvas2DLayerChromiumTest.cpp:
  • tests/LayerChromiumTest.cpp:
18:02 Changeset [113649] by bdakin@apple.com

<rdar://problem/11214796>

New WKSI will hopefully fix a common crash seen by the bots in libRIP.A.dylib:
symmetric_convolve

Reviewed by Simon Fraser.

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
18:00 Changeset [113648] by fpizlo@apple.com

Classic interpreter's GC hooks shouldn't attempt to scan instructions for code blocks that
are currently being generated
https://bugs.webkit.org/show_bug.cgi?id=83531
<rdar://problem/11215200>

Reviewed by Gavin Barraclough.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::stronglyVisitStrongReferences):

17:44 Changeset [113647] by kling@webkit.org

Make CSSValuePool share values globally.
<http://webkit.org/b/77700>

Reviewed by Antti Koivisto.

Remove the per-Document CSSValuePool and have everyone use a global pool
accessed via "CSSValuePool& cssValuePool()".

This reduces memory usage by sharing cached CSSValues between all documents,
and relaxes heap churn since the common, persistenly cached values are held
by CSSValuePool forever.

No behavior change thanks to r113588 which introduced a mechanism that makes
sure we never expose internal CSSValue objects to bindings, but read-only
clones of those values.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForNinePieceImageSlice):
(WebCore::valueForNinePieceImageQuad):
(WebCore::valueForNinePieceImageRepeat):
(WebCore::valueForNinePieceImage):
(WebCore::zoomAdjustedPixelValue):
(WebCore::zoomAdjustedNumberValue):
(WebCore::zoomAdjustedPixelValueForLength):
(WebCore::valueForReflection):
(WebCore::getPositionOffsetValue):
(WebCore::CSSComputedStyleDeclaration::currentColorOrValidColor):
(WebCore::getBorderRadiusCornerValues):
(WebCore::getBorderRadiusCornerValue):
(WebCore::getBorderRadiusShorthandValue):
(WebCore::computedTransform):
(WebCore::CSSComputedStyleDeclaration::valueForCustomFilterNumberParameter):
(WebCore::CSSComputedStyleDeclaration::valueForFilter):
(WebCore::valueForGridTrackBreadth):
(WebCore::valueForGridTrackList):
(WebCore::valueForGridPosition):
(WebCore::getDelayValue):
(WebCore::getDurationValue):
(WebCore::createLineBoxContainValue):
(WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyword):
(WebCore::CSSComputedStyleDeclaration::valueForShadow):
(WebCore::valueForFamily):
(WebCore::renderUnicodeBidiFlagsToCSSValue):
(WebCore::renderTextDecorationFlagsToCSSValue):
(WebCore::fillRepeatToCSSValue):
(WebCore::fillSizeToCSSValue):
(WebCore::contentToCSSValue):
(WebCore::counterToCSSValue):
(WebCore::fontFamilyFromStyle):
(WebCore::lineHeightFromStyle):
(WebCore::fontSizeFromStyle):
(WebCore::fontStyleFromStyle):
(WebCore::fontVariantFromStyle):
(WebCore::fontWeightFromStyle):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSComputedStyleDeclaration.h:

(WebCore):

  • css/CSSParser.cpp:

(WebCore::parseColorValue):
(WebCore::parseSimpleLengthValue):
(WebCore::parseKeywordValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseColor):
(WebCore::CSSParser::setStyleSheet):
(WebCore::CSSParser::createPrimitiveNumericValue):
(WebCore::CSSParser::createPrimitiveStringValue):
(WebCore::CSSParser::parseValidPrimitive):
(WebCore::parseBackgroundClip):
(WebCore::CSSParser::parseFillShorthand):
(WebCore::CSSParser::parseAnimationShorthand):
(WebCore::CSSParser::parseTransitionShorthand):
(WebCore::CSSParser::parseShorthand):
(WebCore::CSSParser::parsePage):
(WebCore::CSSParser::parseSizeParameter):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseAttr):
(WebCore::CSSParser::parseBackgroundColor):
(WebCore::CSSParser::parseFillImage):
(WebCore::CSSParser::parseFillPositionX):
(WebCore::CSSParser::parseFillPositionY):
(WebCore::CSSParser::parseFillPositionComponent):
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parseFillRepeat):
(WebCore::CSSParser::parseFillSize):
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::parseAnimationDirection):
(WebCore::CSSParser::parseAnimationFillMode):
(WebCore::CSSParser::parseAnimationIterationCount):
(WebCore::CSSParser::parseAnimationName):
(WebCore::CSSParser::parseAnimationPlayState):
(WebCore::CSSParser::parseAnimationProperty):
(WebCore::CSSParser::parseAnimationTimingFunction):
(WebCore::CSSParser::parseGridTrackList):
(WebCore::CSSParser::parseDashboardRegions):
(WebCore::CSSParser::parseCounterContent):
(WebCore::CSSParser::parseClipShape):
(WebCore::CSSParser::parseExclusionShape):
(WebCore::CSSParser::parseFont):
(WebCore::FontFamilyValueBuilder::FontFamilyValueBuilder):
(WebCore::FontFamilyValueBuilder::commit):
(FontFamilyValueBuilder):
(WebCore::CSSParser::parseFontFamily):
(WebCore::CSSParser::parseFontVariant):
(WebCore::CSSParser::parseFontWeight):
(WebCore::ShadowParseContext::commitStyle):
(WebCore::CSSParser::parseShadow):
(WebCore::CSSParser::parseReflect):
(WebCore::CSSParser::parseFlex):
(WebCore::BorderImageParseContext::commitBorderImageProperty):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseBorderImageRepeat):
(WebCore::BorderImageSliceParseContext::commitBorderImageSlice):
(WebCore::BorderImageQuadParseContext::commitNumber):
(WebCore::BorderImageQuadParseContext::commitBorderImageQuad):
(WebCore::CSSParser::parseBorderRadius):
(WebCore::CSSParser::parseAspectRatio):
(WebCore::CSSParser::parseCounter):
(WebCore::parseDeprecatedGradientPoint):
(WebCore::parseDeprecatedGradientColorStop):
(WebCore::CSSParser::parseDeprecatedGradient):
(WebCore::valueFromSideKeyword):
(WebCore::parseGradientColorOrKeyword):
(WebCore::CSSParser::parseLinearGradient):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::parseCrossfade):
(WebCore::CSSParser::parseImageSet):
(WebCore::CSSParser::parseCustomFilter):
(WebCore::CSSParser::parseBuiltinFilterArguments):
(WebCore::CSSParser::parseFilter):
(WebCore::CSSParser::parseFlowThread):
(WebCore::CSSParser::parseRegionThread):
(WebCore::CSSParser::parseTextEmphasisStyle):
(WebCore::CSSParser::parseFontFeatureSettings):
(WebCore::CSSParser::parseFontVariantLigatures):

  • css/CSSParser.h:

(WebCore):
(CSSParser):

  • css/CSSValuePool.cpp:

(WebCore::cssValuePool):
(WebCore):

  • css/CSSValuePool.h:

(CSSValuePool):
(WebCore):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::setProperty):

  • css/StylePropertySet.h:

(StylePropertySet):

  • dom/Document.cpp:
  • dom/Document.h:

(WebCore):
(Document):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::addPropertyToAttributeStyle):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::addHTMLColorToStyle):

  • html/HTMLFontElement.cpp:

(WebCore::HTMLFontElement::collectStyleForAttribute):

  • html/HTMLHRElement.cpp:

(WebCore::HTMLHRElement::collectStyleForAttribute):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::createSharedCellStyle):

17:20 Changeset [113646] by simonjam@chromium.org

[Chromium] Unreviewed, roll out rebaselines for feature that was rolled out.

  • platform/chromium-linux-x86/media/video-empty-source-expected.txt: Copied from LayoutTests/platform/chromium-win/media/video-empty-source-expected.txt.
  • platform/chromium-linux/media/video-empty-source-expected.txt: Copied from LayoutTests/platform/chromium-win/media/video-empty-source-expected.txt.
  • platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/media/video-empty-source-expected.txt: Copied from LayoutTests/platform/chromium-mac/media/video-empty-source-expected.txt.
  • platform/chromium-mac/fast/forms/basic-textareas-expected.txt:
  • platform/chromium-mac/fast/layers/video-layer-expected.txt:
  • platform/chromium-mac/media/audio-controls-rendering-expected.txt:
  • platform/chromium-mac/media/audio-repaint-expected.txt:
  • platform/chromium-mac/media/controls-after-reload-expected.txt:
  • platform/chromium-mac/media/controls-strict-expected.txt:
  • platform/chromium-mac/media/controls-styling-expected.txt:
  • platform/chromium-mac/media/controls-without-preload-expected.txt:
  • platform/chromium-mac/media/media-controls-clone-expected.txt:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-mac/media/video-controls-rendering-expected.txt:
  • platform/chromium-mac/media/video-display-toggle-expected.txt:
  • platform/chromium-mac/media/video-empty-source-expected.txt:
  • platform/chromium-mac/media/video-no-audio-expected.txt:
  • platform/chromium-mac/media/video-playing-and-pause-expected.txt:
  • platform/chromium-mac/media/video-volume-slider-expected.txt:
  • platform/chromium-mac/media/video-zoom-controls-expected.txt:
  • platform/chromium-win-vista/media/video-empty-source-expected.txt: Copied from LayoutTests/platform/chromium-win/media/video-empty-source-expected.txt.
  • platform/chromium-win/fast/layers/video-layer-expected.txt:
  • platform/chromium-win/media/audio-controls-rendering-expected.txt:
  • platform/chromium-win/media/audio-repaint-expected.txt:
  • platform/chromium-win/media/controls-after-reload-expected.txt:
  • platform/chromium-win/media/controls-strict-expected.txt:
  • platform/chromium-win/media/controls-styling-expected.txt:
  • platform/chromium-win/media/controls-without-preload-expected.txt:
  • platform/chromium-win/media/media-controls-clone-expected.txt:
  • platform/chromium-win/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-win/media/video-controls-rendering-expected.txt:
  • platform/chromium-win/media/video-display-toggle-expected.txt:
  • platform/chromium-win/media/video-empty-source-expected.txt:
  • platform/chromium-win/media/video-no-audio-expected.txt:
  • platform/chromium-win/media/video-playing-and-pause-expected.txt:
  • platform/chromium-win/media/video-volume-slider-expected.txt:
  • platform/chromium-win/media/video-zoom-controls-expected.txt:
17:03 Changeset [113645] by leviw@chromium.org

Prepare html classes for sub-pixel LayoutUnits
https://bugs.webkit.org/show_bug.cgi?id=83491

Reviewed by Eric Seidel.

This patch brings the entire HTML folder up to the current state of the subpixellayout branch. Adding
an intValue flavor of Length that maps to the current value function was also necessary to get us
there. See https://trac.webkit.org/wiki/LayoutUnit and the descriptions below for details.

No new tests. No change in behavior.

  • html/HTMLMarqueeElement.cpp:

(WebCore::HTMLMarqueeElement::scrollAmount): Fixes a compiler error when length returns a float, as
we intend it to do when switching to sub-pixel layout.

  • html/ImageDocument.cpp:

(WebCore::ImageDocumentParser::finish): imageSize is always integral.

  • platform/Length.h:

(WebCore::Length::Length): Added a constructor that takes a FractionalLayoutUnit.
(Length):
(WebCore::Length::intValue): Currently maps directly to Length::value, but the current logic of value
will be migrated here when value is changed to return a float.
(WebCore::Length::setValue): Added a variant that takes a FractionalLayoutUnit.

17:01 Changeset [113644] by commit-queue@webkit.org

[BlackBerry] requestAnimationFrame performance choppy & inconsistent
https://bugs.webkit.org/show_bug.cgi?id=83499

Patch by Andrew Lo <anlo@rim.com> on 2012-04-09
Reviewed by Rob Buis.

Respect m_scheduled & m_previousFrameDone flags like the Mac port of
DisplayRefreshMonitor does.
Internal PR: 147826

requestAnimationFrame already covered by tests in LayoutTests/fast/animation.

  • platform/graphics/blackberry/DisplayRefreshMonitorBlackBerry.cpp:

(WebCore::DisplayRefreshMonitor::displayLinkFired):

16:58 Changeset [113643] by macpherson@chromium.org

Make CSSValueID's into an enum instead of a collection of integers.
https://bugs.webkit.org/show_bug.cgi?id=83246

Reviewed by Simon Fraser.

This patch simply converts the list of integers into an enum.
Follow-up patches will then convert existing code that uses integers to use the new enum.

No new tests / no functionality changed.

  • css/makevalues.pl:
16:54 Changeset [113642] by fpizlo@apple.com

Unreviewed, modernize and clean up uses of ARM assembly mnemonics in inline asm blocks.

  • dfg/DFGOperations.cpp:

(JSC):

  • offlineasm/armv7.rb:
16:49 Changeset [113641] by commit-queue@webkit.org

Unreviewed, rolling out r113609.
http://trac.webkit.org/changeset/113609
https://bugs.webkit.org/show_bug.cgi?id=83522

it broke tests (Requested by dethbakin on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-09

Source/WebCore:

  • css/mediaControlsChromium.css:

(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):

  • css/mediaControlsQuickTime.css:

(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
(audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):

  • html/shadow/MediaControlElements.cpp:

(RenderMediaVolumeSliderContainer):
(WebCore):
(WebCore::RenderMediaVolumeSliderContainer::RenderMediaVolumeSliderContainer):
(WebCore::RenderMediaVolumeSliderContainer::layout):
(WebCore::MediaControlVolumeSliderContainerElement::createRenderer):

  • html/shadow/MediaControlElements.h:

(MediaControlVolumeSliderContainerElement):

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::create):

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::create):

LayoutTests:

  • media/video-controls-rendering-toggle-display-none-expected.txt: Removed.
  • media/video-controls-rendering-toggle-display-none.html: Removed.
16:45 Changeset [113640] by noam.rosenthal@nokia.com

[Qt][WK2] Sync the layer's state and the layer's children separately
https://bugs.webkit.org/show_bug.cgi?id=82534

Reviewed by Kenneth Rohde Christiansen.

Switched the WebLayerInfo struct, which includes a single layer's state,
to use only POD types that can be serialized via SimpleArgumentCoder.
To allow POD-serialization, we serialize the children IDs in a seperate
message (SetLayerChildren), and only when the tree layout has actually
been modified.

  • Shared/WebLayerTreeInfo.cpp:

(WebKit::WebLayerInfo::encode):
(WebKit::WebLayerInfo::decode):

  • Shared/WebLayerTreeInfo.h:

(WebKit::WebLayerInfo::WebLayerInfo):

  • UIProcess/LayerTreeHostProxy.cpp:

(WebKit::LayerTreeHostProxy::setCompositingLayerState):
(WebKit):
(WebKit::LayerTreeHostProxy::setCompositingLayerChildren):

  • UIProcess/LayerTreeHostProxy.h:

(LayerTreeHostProxy):

  • UIProcess/LayerTreeHostProxy.messages.in:
  • UIProcess/WebLayerTreeRenderer.cpp:

(WebKit::WebLayerTreeRenderer::setLayerChildren):
(WebKit):
(WebKit::WebLayerTreeRenderer::setLayerState):

  • UIProcess/WebLayerTreeRenderer.h:

(WebLayerTreeRenderer):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::didChangeLayerState):
(WebCore):
(WebCore::WebGraphicsLayer::didChangeChildren):
(WebCore::WebGraphicsLayer::didChangeGeometry):
(WebCore::WebGraphicsLayer::WebGraphicsLayer):
(WebCore::WebGraphicsLayer::setChildren):
(WebCore::WebGraphicsLayer::addChild):
(WebCore::WebGraphicsLayer::addChildAtIndex):
(WebCore::WebGraphicsLayer::addChildAbove):
(WebCore::WebGraphicsLayer::addChildBelow):
(WebCore::WebGraphicsLayer::replaceChild):
(WebCore::WebGraphicsLayer::removeFromParent):
(WebCore::WebGraphicsLayer::setDrawsContent):
(WebCore::WebGraphicsLayer::setContentsOpaque):
(WebCore::WebGraphicsLayer::setBackfaceVisibility):
(WebCore::WebGraphicsLayer::setOpacity):
(WebCore::WebGraphicsLayer::setContentsRect):
(WebCore::WebGraphicsLayer::setContentsToImage):
(WebCore::WebGraphicsLayer::setMaskLayer):
(WebCore::WebGraphicsLayer::setReplicatedByLayer):
(WebCore::WebGraphicsLayer::setNeedsDisplayInRect):
(WebCore::WebGraphicsLayer::id):
(WebCore::WebGraphicsLayer::syncChildren):
(WebCore::WebGraphicsLayer::syncLayerState):
(WebCore::WebGraphicsLayer::syncImageBackingStore):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
(WebCore::WebGraphicsLayer::setRootLayer):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:

(WebGraphicsLayerClient):
(WebGraphicsLayer):

  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::syncLayerState):
(WebKit):
(WebKit::LayerTreeHostQt::syncLayerChildren):

  • WebProcess/WebPage/qt/LayerTreeHostQt.h:

(LayerTreeHostQt):

16:28 Changeset [113639] by dpranke@chromium.org

add a webkit-patch print-baselines command
https://bugs.webkit.org/show_bug.cgi?id=83348

Reviewed by Adam Barth.

This adds a simple 'print-baselines' command to webkit-patch
that can be used in one of two forms: to print where the
baselines for a given test (or set of tests) on a single port
will be found, or to generate a report for multiple ports.

Example of the former:

$ webkit-patch print-baselines fast/html/keygen.html
For mac-snowleopard
platform/mac/fast/html/keygen-expected.txt
platform/mac/fast/html/keygen-expected.png
$

The latter is most useful for finding out which fallback dirs are
used by which ports for which tests, for example,
'chromium-mac-leopard' uses 100 results from 'platform/mac/leopard'.
No example output is given because the reports are pretty wordy :).

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.baseline_extensions): Added.
(Port.expected_baseline_dict): Added.

  • Scripts/webkitpy/tool/commands/queries.py:

(PrintBaselines):
(PrintBaselines.init):
(PrintBaselines.execute):
(PrintBaselines._print_baselines):
(PrintBaselines._platform_for_path):

16:20 Changeset [113638] by fmalita@chromium.org

Unreviewed: adding myself to committers.py.

Patch by Florin Malita <fmalita@chromium.org> on 2012-04-09

  • Scripts/webkitpy/common/config/committers.py:
15:52 Changeset [113637] by danakj@chromium.org

[chromium] Make culling work with clipped rects
https://bugs.webkit.org/show_bug.cgi?id=83494

Reviewed by Adrienne Walker.

Source/WebCore:

Use new CCMathUtil transformation methods to deal with rects that clip
the camera plane. This fixes three things:

  1. A layer completely behind the camera is not visible and should not

occlude.

  1. A layer that is clipped by the camera is treated like a

non-axis-aligned transform, as the result of a mapClippedRect() is a
bounding box and may contain pixels not in the original rect. This guards
our use of mapRect() when transforming occluded regions.

  1. A layer's occlusion must be clipped by its scissor rect. This scissor

rect exists in its target space, so occlusion in screen space is only
possible if its target also is axis aligned in the screen, such that
the layer's scissor rect remains a rect in screen space.

Unit tests: CCOcclusionTrackerTestLayerBehindCameraDoesNotOcclude

CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect

  • platform/graphics/chromium/cc/CCMathUtil.cpp:

(WebCore::CCMathUtil::mapQuad):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::transformSurfaceOpaqueRegion):
(WebCore::computeOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):
(WebCore::testContentRectOccluded):
(WebCore::computeUnoccludedContentRect):

Source/WebKit/chromium:

  • tests/CCOcclusionTrackerTest.cpp:

(CCOcclusionTrackerTestLayerBehindCameraDoesNotOcclude):
(WebKitTests::CCOcclusionTrackerTestLayerBehindCameraDoesNotOcclude::runMyTest):
(WebKitTests):
(CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect):
(WebKitTests::CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect::runMyTest):

  • tests/CCQuadCullerTest.cpp:

(WebCore::TestCCOcclusionTrackerImpl::TestCCOcclusionTrackerImpl):
(WebCore::makeLayer):
(WebCore::TEST):

15:49 Changeset [113636] by commit-queue@webkit.org

Remove unworkable video-buffering-repaints-controls test.
https://bugs.webkit.org/show_bug.cgi?id=83097

.:

Replaces the automated test for progress bar repaints during buffering
with a manual test entry.

Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-04-09
Reviewed by Eric Carlson.

  • ManualTests/media-controls.html:

LayoutTests:

Test has been broken in one way or another for some time now. I've
approached multiple people about possible solutions, but nothing ends
up being stable.

After discussion with fischman and trying a couple more solutions
today, we decided the best course of action is to remove the test.

Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-04-09
Reviewed by Eric Carlson.

  • http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
  • http/tests/media/video-buffering-repaints-controls.html: Removed.
  • platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
  • platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
  • platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
  • platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
  • platform/chromium-mac/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
  • platform/chromium-win/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
  • platform/mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
  • platform/mac/Skipped:
  • platform/mac/test_expectations.txt:
15:44 Changeset [113635] by commit-queue@webkit.org

Unreviewed, rolling out r113613.
http://trac.webkit.org/changeset/113613
https://bugs.webkit.org/show_bug.cgi?id=83509

crashing most chromium bots (Requested by simonjam on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-09

Source/WebCore:

  • Modules/battery/BatteryController.cpp:
  • Modules/battery/BatteryController.h:

(BatteryController):

  • Modules/battery/BatteryManager.cpp:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:

Source/WebKit/chromium:

  • WebKit.gyp:
  • features.gypi:
  • public/WebBatteryStatus.h: Removed.
  • public/WebBatteryStatusClient.h: Removed.
  • public/WebView.h:

(WebKit):
(WebView):

  • public/WebViewClient.h:

(WebKit):

  • src/BatteryClientImpl.cpp: Removed.
  • src/BatteryClientImpl.h: Removed.
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

  • src/WebViewImpl.h:

(WebKit):
(WebViewImpl):

LayoutTests:

  • platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
  • platform/chromium/test_expectations.txt:
15:40 Changeset [113634] by zmo@google.com

bindAttribLocation should check webgl reserved prefix
https://bugs.webkit.org/show_bug.cgi?id=83409

Reviewed by Kenneth Russell.

Source/WebCore:

  • html/canvas/WebGLRenderingContext.cpp: Check for invalid parameters for a few functions.

(WebCore):
(WebCore::WebGLRenderingContext::bindAttribLocation):
(WebCore::WebGLRenderingContext::getAttribLocation):
(WebCore::WebGLRenderingContext::getUniformLocation):

LayoutTests:

  • fast/canvas/webgl/webgl-specific-expected.txt: Added webgl prefix test case for bindAttribLocation.
  • fast/canvas/webgl/webgl-specific.html:
15:40 Changeset [113633] by commit-queue@webkit.org

[BlackBerry] Allow simulator to use GLES2 acceleration
https://bugs.webkit.org/show_bug.cgi?id=81672

Patch by Ming Xie <mxie@rim.com> on 2012-04-09
Reviewed by Rob Buis.

.:

  • Source/cmake/OptionsBlackBerry.cmake:

Tools:

  • Scripts/webkitdirs.pm:

(blackberryCMakeArguments):

15:17 Changeset [113632] by simonjam@chromium.org

[Chromium] Unreviewed gardening fix.

  • platform/chromium/virtual/threaded/compositing/visibility/README.txt: Added.
15:14 Changeset [113631] by timothy@apple.com

Fix the assertion in PageScriptDebugServer::didPause.

https://webkit.org/b/82943

Reviewed by Simon Fraser.

  • bindings/js/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::PageScriptDebugServer): Initialize m_pausedPage
to zero so the assert in didPause will not randomly fire the first time.

15:06 PrefixedAPIs edited by ericu@chromium.org
(diff)
15:05 Changeset [113630] by lforschler@apple.com

Merged r113501.

15:00 Changeset [113629] by lforschler@apple.com

Merged r113523.

14:59 Changeset [113628] by noam.rosenthal@nokia.com

[Qt][WK2] Accelerated and non-accelerated animations need to be synchronized
https://bugs.webkit.org/show_bug.cgi?id=75780

Reviewed by Kenneth Rohde Christiansen.

Remove the ui-side animation code, and return false from addAnimation so that web-side
animations kick in.

  • Shared/WebLayerTreeInfo.cpp:

(WebKit):

  • Shared/WebLayerTreeInfo.h:

(WebLayerInfo):

  • UIProcess/WebLayerTreeRenderer.cpp:

(WebKit::WebLayerTreeRenderer::paintToCurrentGLContext):
(WebKit::WebLayerTreeRenderer::setLayerState):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::didChangeGeometry):
(WebCore::WebGraphicsLayer::syncLayerState):
(WebCore::WebGraphicsLayer::computeTransformedVisibleRect):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:

(WebGraphicsLayer):

14:58 Changeset [113627] by lforschler@apple.com

Versioning.

14:58 Changeset [113626] by simonjam@chromium.org

[Chromium] Unreviewed gardening.

  • platform/chromium-linux-x86/media/video-empty-source-expected.txt: Removed.
  • platform/chromium-linux/media/media-document-audio-repaint-expected.png:
  • platform/chromium-linux/media/video-empty-source-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/forms/basic-textareas-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/forms/basic-textareas-expected.txt.
  • platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
  • platform/chromium-mac-snowleopard/media/video-empty-source-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/basic-textareas-expected.png:
  • platform/chromium-mac/fast/forms/basic-textareas-expected.txt:
  • platform/chromium-mac/fast/layers/video-layer-expected.txt:
  • platform/chromium-mac/media/audio-controls-rendering-expected.txt:
  • platform/chromium-mac/media/audio-repaint-expected.txt:
  • platform/chromium-mac/media/controls-after-reload-expected.txt:
  • platform/chromium-mac/media/controls-strict-expected.txt:
  • platform/chromium-mac/media/controls-styling-expected.txt:
  • platform/chromium-mac/media/controls-without-preload-expected.txt:
  • platform/chromium-mac/media/media-controls-clone-expected.txt:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-mac/media/video-controls-rendering-expected.txt:
  • platform/chromium-mac/media/video-display-toggle-expected.txt:
  • platform/chromium-mac/media/video-empty-source-expected.txt:
  • platform/chromium-mac/media/video-no-audio-expected.txt:
  • platform/chromium-mac/media/video-playing-and-pause-expected.txt:
  • platform/chromium-mac/media/video-volume-slider-expected.txt:
  • platform/chromium-mac/media/video-zoom-controls-expected.txt:
  • platform/chromium-win-vista/media/video-empty-source-expected.txt: Removed.
  • platform/chromium-win/fast/layers/video-layer-expected.txt:
  • platform/chromium-win/media/audio-controls-rendering-expected.txt:
  • platform/chromium-win/media/audio-repaint-expected.txt:
  • platform/chromium-win/media/controls-after-reload-expected.txt:
  • platform/chromium-win/media/controls-strict-expected.txt:
  • platform/chromium-win/media/controls-styling-expected.txt:
  • platform/chromium-win/media/controls-without-preload-expected.txt:
  • platform/chromium-win/media/media-controls-clone-expected.txt:
  • platform/chromium-win/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-win/media/video-controls-rendering-expected.txt:
  • platform/chromium-win/media/video-display-toggle-expected.txt:
  • platform/chromium-win/media/video-empty-source-expected.txt:
  • platform/chromium-win/media/video-no-audio-expected.txt:
  • platform/chromium-win/media/video-playing-and-pause-expected.txt:
  • platform/chromium-win/media/video-volume-slider-expected.txt:
  • platform/chromium-win/media/video-zoom-controls-expected.txt:
  • platform/chromium/test_expectations.txt:
14:58 Changeset [113625] by wjmaclean@chromium.org

Mark myself as a committer
https://bugs.webkit.org/show_bug.cgi?id=83510

Reviewed by Adrienne Walker.

  • Scripts/webkitpy/common/config/committers.py:
14:46 Changeset [113624] by timothy_horton@apple.com

FrameData constructor zeroes all fields, causing ImageOrientation to be 0
https://bugs.webkit.org/show_bug.cgi?id=83416

Reviewed by Geoff Garen.

Reinstate SimpleClassVectorTraits on FrameData (which were removed by http://trac.webkit.org/changeset/113543)
with canInitializeWithMemset disabled, since two of the FrameData fields cannot be initialized to zero.

No new tests.

  • platform/graphics/BitmapImage.h:
14:40 Changeset [113623] by commit-queue@webkit.org

[chromium] CCLayerTreeHost / WebLayerTreeView should be single ownership, not RefCounted
https://bugs.webkit.org/show_bug.cgi?id=83413

Patch by James Robinson <jamesr@chromium.org> on 2012-04-09
Reviewed by Adrienne Walker.

Source/Platform:

This makes WebLayerTreeView noncopyable to better match the underlying semantics. There is no code currently
that attempts to copy WebLayerTreeView instances.

  • chromium/public/WebLayerTreeView.h:

(WebKit):
(WebLayerTreeView):

Source/WebCore:

CCLayerTreeHost always has a single logical owner, typically a WebLayerTreeView via either WebViewImpl or the
public API. It is currently refcounted for historical reasons but this isn't necessary and adds confusion.
CCLayerTreeHost instances and pointers are carefully managed currently to avoid leaks. In particular, while
LayerChromium instances hold RefPtr<CCLayerTreeHost>s, whenever we want to destroy a CCLayerTreeHost we
proactively clear out these references inside setRootLayer() to break the cycle.

Refactor covered by existing unit and layout tests.

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setMaskLayer):
(WebCore::LayerChromium::setReplicaLayer):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::layerTreeHost):
(LayerChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::create):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

Source/WebKit/chromium:

Updates tests and implementation for RefPtr->OwnPtr switch. One nice benefit is that since WebLayerTreeView is
explicitly owned by the user of the API we can safely rely on them managing the lifetime of the client and thus
don't have to null check the client all the time.

  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::reset):
(WebKit::WebLayerTreeView::isNull):
(WebKit::WebLayerTreeView::initialize):

  • src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::create):
(WebKit::WebLayerTreeViewImpl::willBeginFrame):
(WebKit::WebLayerTreeViewImpl::updateAnimations):
(WebKit::WebLayerTreeViewImpl::layout):
(WebKit::WebLayerTreeViewImpl::applyScrollAndScale):
(WebKit::WebLayerTreeViewImpl::createContext):
(WebKit::WebLayerTreeViewImpl::didRecreateContext):
(WebKit::WebLayerTreeViewImpl::didCommit):
(WebKit::WebLayerTreeViewImpl::didCommitAndDrawFrame):
(WebKit::WebLayerTreeViewImpl::didCompleteSwapBuffers):
(WebKit::WebLayerTreeViewImpl::scheduleComposite):

  • src/WebLayerTreeViewImpl.h:

(WebLayerTreeViewImpl):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::MockLayerTreeHost::create):
(CCLayerTreeHostTest):

  • tests/Canvas2DLayerChromiumTest.cpp:
  • tests/LayerChromiumTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):

14:37 Changeset [113622] by jsbell@chromium.org

Unreviewed, rolling out r113473.
http://trac.webkit.org/changeset/113473
https://bugs.webkit.org/show_bug.cgi?id=83074

Change does not handle cursor retention of LevelDB iterators

Source/WebCore:

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::~IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::loadObjectStores):

  • Modules/indexeddb/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::IDBIndexBackendImpl):
(WebCore::IDBIndexBackendImpl::openCursorInternal):
(WebCore::IDBIndexBackendImpl::countInternal):
(WebCore::IDBIndexBackendImpl::getInternal):
(WebCore::IDBIndexBackendImpl::addingKeyAllowed):

  • Modules/indexeddb/IDBIndexBackendImpl.h:

(WebCore::IDBIndexBackendImpl::create):
(IDBIndexBackendImpl):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl):
(WebCore::IDBObjectStoreBackendImpl::getInternal):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):
(WebCore::IDBObjectStoreBackendImpl::clearInternal):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
(WebCore::IDBObjectStoreBackendImpl::countInternal):
(WebCore::IDBObjectStoreBackendImpl::loadIndexes):
(WebCore::IDBObjectStoreBackendImpl::genAutoIncrementKey):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(WebCore):
(WebCore::IDBObjectStoreBackendImpl::create):
(WebCore::IDBObjectStoreBackendImpl::databaseId):
(IDBObjectStoreBackendImpl):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/IDBDatabaseBackendTest.cpp: Removed.
14:32 Changeset [113621] by leviw@chromium.org

Cleaning up LayoutUnit usage in DOMNodeHighlighter and removing unnecessary static_casts in ValidationMessage.

14:30 Changeset [113620] by lforschler@apple.com

New Tag.

14:26 Changeset [113619] by commit-queue@webkit.org

[CSS Regions] Convert a fast/regions pixel test to a ref test
https://bugs.webkit.org/show_bug.cgi?id=83398

Patch by David Alcala <dalcala@adobe.com> on 2012-04-09
Reviewed by Dirk Schulze.

  • fast/regions/position-writing-modes-in-variable-width-regions-expected.html: Added.
  • platform/chromium-linux/fast/regions/position-writing-modes-in-variable-width-regions-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/regions/position-writing-modes-in-variable-width-regions-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/regions/position-writing-modes-in-variable-width-regions-expected.png: Removed.
  • platform/chromium-mac/fast/regions/position-writing-modes-in-variable-width-regions-expected.png: Removed.
  • platform/chromium-mac/fast/regions/position-writing-modes-in-variable-width-regions-expected.txt: Removed.
  • platform/chromium-win/fast/regions/position-writing-modes-in-variable-width-regions-expected.png: Removed.
  • platform/chromium-win/fast/regions/position-writing-modes-in-variable-width-regions-expected.txt: Removed.
  • platform/efl/fast/regions/position-writing-modes-in-variable-width-regions-expected.png: Removed.
  • platform/efl/fast/regions/position-writing-modes-in-variable-width-regions-expected.txt: Removed.
  • platform/mac/fast/regions/position-writing-modes-in-variable-width-regions-expected.png: Removed.
  • platform/mac/fast/regions/position-writing-modes-in-variable-width-regions-expected.txt: Removed.
14:24 Changeset [113618] by jamesr@google.com

[chromium] Texture copies should happen after incremental updates to preserve commit atomicity
https://bugs.webkit.org/show_bug.cgi?id=83392

Reviewed by Adrienne Walker.

Source/WebCore:

This enqueues texture copy operations in the CCTextureUpdater's list instead of evaluating them immediately so
if the update is spread over multiple frames we can properly defer the texture copy until the end. Otherwise,
the texture copy for WebGL / Canvas 2D content happens before the commit completes and the compositor might pick
up a frame for the canvas that's "ahead" of the content around it.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/cc/CCTextureUpdater.cpp:

(WebCore::CCTextureUpdater::appendUpdate):
(WebCore::CCTextureUpdater::appendPartialUpdate):
(WebCore):
(WebCore::CCTextureUpdater::appendCopy):
(WebCore::CCTextureUpdater::hasMoreUpdates):
(WebCore::CCTextureUpdater::update):
(WebCore::CCTextureUpdater::clear):

  • platform/graphics/chromium/cc/CCTextureUpdater.h:

(CCTextureUpdater):
(UpdateEntry):
(CopyEntry):

Source/WebKit/chromium:

  • tests/Canvas2DLayerChromiumTest.cpp:
14:07 Changeset [113617] by dpranke@chromium.org

nrwt is failing to upload test results on the chromium-mac-leopard bots
https://bugs.webkit.org/show_bug.cgi?id=83230

Unreviewed, build fix.

It looks like the change in r113399 to use the per-request
timeout variable didn't actually work, so I am removing the
timeout code altogether and counting on the idea that upload
just isn't likely to take that long and the timeouts and
retransmits are largely unused and largely unnecessary. We'll
see if this breaks anywhere else.

  • Scripts/webkitpy/common/net/file_uploader.py:

(FileUploader.init):
(FileUploader._upload_data.callback):
(FileUploader):

13:59 Changeset [113616] by rwlbuis@webkit.org

[BlackBerry] Cleanup LayoutTestControllerBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=83469

Reviewed by Dirk Schulze.

Remove WTF:: prefixes and fix a warning with the length variable.

  • DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:

(jsStringRefToWebCoreString):
(LayoutTestController::execCommand):
(LayoutTestController::isCommandEnabled):
(LayoutTestController::setUserStyleSheetLocation):
(LayoutTestController::counterValueForElementById):
(LayoutTestController::overridePreference):
(LayoutTestController::setMockGeolocationError):
(LayoutTestController::findString):

13:57 Changeset [113615] by noam.rosenthal@nokia.com

[Qt][WK2] Don't synchronize WebGraphicsLayers to the UI process if the actual layer information wasn't changed
https://bugs.webkit.org/show_bug.cgi?id=82522

Reviewed by Kenneth Rohde Christiansen.

Currently we set the m_modified flags for all of the descendants of a layer
that has changed its geometry. This causes unnecessary layer sync messages.
Instead, we only sync when the actual layer has changed, and add a flag
called m_shouldUpdateVisibleRect that applies to descendants of a layer
that has a modified geometry.

  • Shared/WebLayerTreeInfo.h:
  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::didChangeChildren):
(WebCore):
(WebCore::WebGraphicsLayer::setShouldUpdateVisibleRect):
(WebCore::WebGraphicsLayer::didChangeGeometry):
(WebCore::WebGraphicsLayer::WebGraphicsLayer):
(WebCore::WebGraphicsLayer::setPosition):
(WebCore::WebGraphicsLayer::setAnchorPoint):
(WebCore::WebGraphicsLayer::setSize):
(WebCore::WebGraphicsLayer::setTransform):
(WebCore::WebGraphicsLayer::setChildrenTransform):
(WebCore::WebGraphicsLayer::setPreserves3D):
(WebCore::WebGraphicsLayer::setContentsToImage):
(WebCore::WebGraphicsLayer::setNeedsDisplayInRect):
(WebCore::WebGraphicsLayer::syncImageBackingStore):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
(WebCore::WebGraphicsLayer::tiledBackingStorePaintBegin):
(WebCore::WebGraphicsLayer::setRootLayer):
(WebCore::WebGraphicsLayer::setVisibleContentRectTrajectoryVector):
(WebCore::WebGraphicsLayer::setContentsScale):
(WebCore::WebGraphicsLayer::effectiveContentsScale):
(WebCore::WebGraphicsLayer::adjustContentsScale):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:

(WebGraphicsLayer):

13:50 Changeset [113614] by eae@chromium.org

Replace numeric_limits<LayoutUnit>::min/max with constants on branch.

13:43 Changeset [113613] by commit-queue@webkit.org

[chromium] Add Battery Status API support.

Source/WebCore:

Add Battery Status API support to chromium.
https://bugs.webkit.org/show_bug.cgi?id=83284

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-04-09
Reviewed by Adam Barth.

This change is covered by tests in batterystatus/.

  • Modules/battery/BatteryController.cpp:

(WebCore::BatteryController::updateBatteryStatus):
(WebCore):

  • Modules/battery/BatteryController.h:

(BatteryController):

  • Modules/battery/BatteryManager.cpp:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:

Source/WebKit/chromium:

The battery-client (BatteryClientChromium) will notify the client (WebBatteryStatusClient) when to start or stop
sending battery status updates. The client, in response will send the notifications to WebViewImpl, which sends
this update information to the WebCore::BatteryClient, and it triggers the appropriate javascript-callbacks.
The spec is at http://www.w3.org/TR/2011/WD-battery-status-20111129/.
https://bugs.webkit.org/show_bug.cgi?id=83284

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-04-09
Reviewed by Adam Barth.

  • WebKit.gyp:
  • features.gypi:
  • public/WebBatteryStatus.h: Added.

(WebKit):
(WebBatteryStatus):
(WebKit::WebBatteryStatus::WebBatteryStatus):

  • public/WebBatteryStatusClient.h: Added.

(WebKit):
(WebBatteryStatusClient):
(WebKit::WebBatteryStatusClient::~WebBatteryStatusClient):

  • public/WebView.h:

(WebKit):
(WebView):
(WebKit::WebView::updateBatteryStatus):

  • public/WebViewClient.h:

(WebKit):
(WebViewClient):
(WebKit::WebViewClient::batteryStatusClient):

  • src/BatteryClientImpl.cpp: Added.

(WebKit):
(WebKit::BatteryClientImpl::BatteryClientImpl):
(WebKit::BatteryClientImpl::updateBatteryStatus):
(WebKit::BatteryClientImpl::setController):
(WebKit::BatteryClientImpl::startUpdating):
(WebKit::BatteryClientImpl::stopUpdating):
(WebKit::BatteryClientImpl::batteryControllerDestroyed):

  • src/BatteryClientImpl.h: Added.

(WebKit):
(BatteryClientImpl):
(WebKit::BatteryClientImpl::~BatteryClientImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit):
(WebKit::WebViewImpl::updateBatteryStatus):

  • src/WebViewImpl.h:

(WebKit):
(WebViewImpl):

LayoutTests:

Add Battery Status API support to chromium.
https://bugs.webkit.org/show_bug.cgi?id=83284

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-04-09
Reviewed by Adam Barth.

  • platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
  • platform/chromium/test_expectations.txt:
13:31 Changeset [113612] by leviw@chromium.org

Adding more missing double overloads to avoid unnecessary static_casting.

13:31 Changeset [113611] by commit-queue@webkit.org

Unnecessary scroll bar after changing the dimensions of a DIV
https://bugs.webkit.org/show_bug.cgi?id=71541

Patch by SravanKumar Sandela <ssandela@innominds.com> on 2012-04-09
Reviewed by Julien Chaffraix.

Source/WebCore:

overflow: auto was being determined based on clientWidth and clientHeight, which during style change
scenarii will blindly exclude previous scrollbars while computing overflow. This is valid only for
overflow: scroll, but for other cases it wrongly reduces available area. Now it is taken care by
determining the overflow based on pixelSnappedPaddingBoxWidth/Height() which are newly added in RenderBox.

Tests: fast/overflow/overflow-auto-destroy-scroll-after-resizing-expected.html

fast/overflow/overflow-auto-destroy-scroll-after-resizing.html

  • rendering/RenderBox.h:

(WebCore::RenderBox::paddingBoxWidth):
(WebCore::RenderBox::paddingBoxHeight):
(WebCore::RenderBox::pixelSnappedPaddingBoxWidth):
(WebCore::RenderBox::pixelSnappedPaddingBoxHeight):
(RenderBox):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hasHorizontalOverflow):
(WebCore::RenderLayer::hasVerticalOverflow):

LayoutTests:

Ref tests to check scrollbar behaviour in overflow: auto, on resizing.

  • fast/overflow/overflow-auto-destroy-scroll-after-resizing-expected.html: Added.
  • fast/overflow/overflow-auto-destroy-scroll-after-resizing.html: Added.

scrollbars-on-positioned-content.html and hidden-scrollbar-resize.html needs to be rebaselined
as their expected values were buggy because of redundant scrollbars.

  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
13:26 Changeset [113610] by noam.rosenthal@nokia.com

[Qt][WK2] Remove all USE(TILED_BACKING_STORE) defines from code that contains UI_SIDE_COMPOSITING
https://bugs.webkit.org/show_bug.cgi?id=82533

Reviewed by Kenneth Rohde Christiansen.

No change in behavior, removing some #defines.

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::setShouldUpdateVisibleRect):
(WebCore::WebGraphicsLayer::adjustContentsScale):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:

(WebGraphicsLayer):

  • WebProcess/WebPage/LayerTreeHost.h:

(LayerTreeHost):

  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::LayerTreeHostQt):
(WebKit::LayerTreeHostQt::detachLayer):

13:10 Changeset [113609] by commit-queue@webkit.org

Source/WebCore: Simplified volume slider rendering.
https://bugs.webkit.org/show_bug.cgi?id=82150

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-04-09
Reviewed by Eric Carlson.

Test: media/video-controls-rendering-toggle-display-none.html

  • css/mediaControlsChromium.css: Update controls css for Chromium.

(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):

  • css/mediaControlsQuickTime.css: Update controls css for Safari.

(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):

  • html/shadow/MediaControlElements.cpp: Removed particular renderer.

(WebCore):

  • html/shadow/MediaControlElements.h:

(MediaControlVolumeSliderContainerElement): Removed particular renderer.

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::create): Added a div element as a container. Removed extra
unused mute button.

  • html/shadow/MediaControlRootElementChromium.cpp: Added an extra div element as a container for

the mute button and the volume slider to easily position them relative to each other.
(WebCore::MediaControlRootElementChromium::create):

LayoutTests: Simplified volume rendering.
https://bugs.webkit.org/show_bug.cgi?id=82150

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-04-09
Reviewed by Eric Carlson.

  • media/video-controls-rendering-toggle-display-none-expected.txt: Added.
  • media/video-controls-rendering-toggle-display-none.html: Added.
  • platform/chromium/test_expectations.txt: Marked tests for rebaseline.
13:01 Changeset [113608] by noam.rosenthal@nokia.com

[Qt][WK2] Disable the content-scaling and visible contents rect when the layer's transform is not affine
https://bugs.webkit.org/show_bug.cgi?id=82523

Reviewed by Kenneth Rohde Christiansen.

Always use contentsScale of 1 and a full visibleContentsRect when
the layer's transform is not affine. That's because layer's with
complex transform would not gain from the benefit of contents scaling,
and might also create unexpected layer content sizes.

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::createBackingStore):
(WebCore):
(WebCore::WebGraphicsLayer::tiledBackingStorePaint):
(WebCore::WebGraphicsLayer::tiledBackingStorePaintEnd):
(WebCore::WebGraphicsLayer::tiledBackingStoreVisibleRect):
(WebCore::WebGraphicsLayer::updateTile):
(WebCore::WebGraphicsLayer::removeTile):
(WebCore::WebGraphicsLayer::updateContentBuffers):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:

(WebGraphicsLayer):

12:46 Changeset [113607] by leviw@chromium.org

Correct some LayoutUnit misuse in FilterEffectRenderer, and RenderBlock
https://bugs.webkit.org/show_bug.cgi?id=83366

Reviewed by Eric Seidel.

Some more preparation of Render classes for FractionalLayoutUnits. See below for details
of each change.

No new tests. No change in behavior.

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRendererHelper::applyFilterEffect): Pixel snapping image rect before
drawing it.

  • rendering/RenderBlock.cpp:

(WebCore::::string): Pixel snapping outputted values for debug.

12:31 Changeset [113606] by shawnsingh@chromium.org

[chromium] Fix layer sorting perspective w if w becomes negative
https://bugs.webkit.org/show_bug.cgi?id=82997

Reviewed by Adrienne Walker.

Source/WebCore:

Unit test added to CCLayerSorterTest.cpp.

This is a follow-up patch after r113364. That other patch
implemented proper clipping so that perspective transforms do not
accidentally make geometry disappear. This patch fixes a similar
problem in the layer sorter code so that layers do not
accidentally get sorted incorrectly.

  • platform/graphics/chromium/cc/CCLayerSorter.cpp:

(WebCore::CCLayerSorter::LayerShape::LayerShape):

  • platform/graphics/chromium/cc/CCMathUtil.cpp:

(WebCore::computeEnclosingRect):
(WebCore::addVertexToClippedQuad):
(WebCore::CCMathUtil::mapClippedQuad):
(WebCore):
(WebCore::CCMathUtil::computeEnclosingRectOfVertices):

  • platform/graphics/chromium/cc/CCMathUtil.h:

(WebCore):
(CCMathUtil):

Source/WebKit/chromium:

  • tests/CCLayerSorterTest.cpp:

(WebCore::TEST):
(WebCore):

12:31 Changeset [113605] by commit-queue@webkit.org

[Qt][WK2] Fail to activate links after double tap gesture.
https://bugs.webkit.org/show_bug.cgi?id=83468

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-09
Reviewed by Kenneth Rohde Christiansen.

.:

  • ManualTests/link-activation-fails-after-double-tap-gesture.html: Added.

Source/WebKit2:

After a recognized double tap gesture, QtTapGestureRecognizer
gets stuck in the double-tap state. Only tapping outside of
the double tap radius cancels it.
Call reset() to set the default state back.

  • UIProcess/qt/QtTapGestureRecognizer.cpp:

(WebKit::QtTapGestureRecognizer::recognize):

ManualTests/link-activation-fails-after-double-tap-gesture.html: Added.

12:28 Changeset [113604] by commit-queue@webkit.org

[soup] Crash while loading http://www.jusco.cn
https://bugs.webkit.org/show_bug.cgi?id=68238

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-04-09
Reviewed by Philippe Normand.

.:

  • configure.ac: Bumped the libsoup dependency to 2.37.90.

Source/WebCore:

Test: http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers.html

When running synchronous XMLHttpRequests, push a new inner thread default
context, so that other sources from timers and network activity do not run.
This will make synchronous requests truly synchronous with the rest of
WebCore.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCoreSynchronousLoader): Clean up the method definitions a bit by writing them inline.
(WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader): Push a new thread default
context to prevent other sources from running.
(WebCore::WebCoreSynchronousLoader::~WebCoreSynchronousLoader): Pop the inner thread default context.
(WebCore::closeCallback): If the client is synchronous call didFinishLoading now.
(WebCore::readCallback): Only call didFinishLoading if the client isn't synchronous.
(WebCore::ResourceHandle::defaultSession): Activate use-thread-context so that the soup session
respects the inner thread context.

LayoutTests:

  • http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers-expected.txt: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers.html: Added.
12:17 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
12:06 Changeset [113603] by leviw@chromium.org

Using FractionalLayoutUnit instead of LayoutUnit for overloaded functions in Length, and using static_cast's in html/ValidationMessage.cpp so the changes can be landed in trunk.

11:58 Changeset [113602] by commit-queue@webkit.org

[chromium] Flip transition painting delayed with threaded animations
https://bugs.webkit.org/show_bug.cgi?id=82571

Patch by Dana Jansens <danakj@chromium.org> on 2012-04-09
Reviewed by Adrienne Walker.

Source/WebCore:

This allows for prepainting to see and paint layers that are not facing
the camera but have animating transforms. This is needed to prepaint
animations that "flip" layers around to make the front visible.

The changes are to add a backFaceIsVisible() helper function in
CCLTHCommon. This is used like before to cull non-double sided
layers, but culling is prevented on main thread when the screen
space transform is unknown due to animation. We add new
helper methods transformToScreenIsKnown() to identify this.

However the layer is not actually visible, so we set the
visibleLayerRect to be empty in this case.

The calculateVisibleLayerRect needs to use the backFaceIsVisible()
helper, so we move it into the .cpp file where it belongs, and make
it static to the file since it is not used outide of CCLTHCommon.cpp
at all.

Unit test: CCLayerTreeHostCommonTest.verifyBackFaceCulling

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore):
(WebCore::backFaceIsVisible):
(WebCore::calculateVisibleLayerRect):
(WebCore::layerOpacityIsOpaque):
(WebCore::transformToParentIsKnown):
(WebCore::transformToScreenIsKnown):
(WebCore::layerShouldBeSkipped):
(WebCore::calculateDrawTransformsAndVisibilityInternal):
(WebCore::walkLayersAndCalculateVisibleLayerRects):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:

(WebCore):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostCommonTest.cpp:

(WebKitTests::TEST):
(WebKitTests):

11:56 Changeset [113601] by commit-queue@webkit.org

[GTK] Toggle buttons do not size appropriately in some themes
https://bugs.webkit.org/show_bug.cgi?id=82833

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-04-09
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Test: platform/gtk/fast/forms/large-toggle-elements.html

Instead of drawing a toggle button across the entire rectangle of
the WebCore control, draw a default-sized one cenetered in the rectangle.

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore::paintToggle): Draw default-sized toggles.

LayoutTests:

Add a test for this issue.

  • platform/gtk/fast/forms/large-toggle-elements-expected.png: Added.
  • platform/gtk/fast/forms/large-toggle-elements-expected.txt: Added.
  • platform/gtk/fast/forms/large-toggle-elements.html: Added.
11:50 PrefixedAPIs edited by kbr@google.com
Added links about postMessage prefixing and Transferables (diff)
11:49 Changeset [113600] by commit-queue@webkit.org

When create JavaScriptNode, do not ignore NumberOfOutputChannels parameter.
https://bugs.webkit.org/show_bug.cgi?id=83250

Patch by Raymond Liu <raymond.liu@intel.com> on 2012-04-09
Reviewed by Chris Rogers.

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::createJavaScriptNode):
(WebCore):

  • Modules/webaudio/AudioContext.h:

(AudioContext):

  • Modules/webaudio/AudioContext.idl:
  • Modules/webaudio/JavaScriptAudioNode.cpp:

(WebCore::JavaScriptAudioNode::create):
(WebCore):
(WebCore::JavaScriptAudioNode::JavaScriptAudioNode):
(WebCore::JavaScriptAudioNode::initialize):
(WebCore::JavaScriptAudioNode::process):

  • Modules/webaudio/JavaScriptAudioNode.h:

(JavaScriptAudioNode):

11:34 Changeset [113599] by eae@chromium.org

Remove size_t versions of methods and numeric_limits from FractionalLayoutUnit on branch.

11:29 Changeset [113598] by robert@webkit.org

Skip fast/css/align-positioned-object-on-resize.html on Mac platforms.
window.resizeTo() doesn't behave as expected in Mac DRT.

Unreviewed.

  • platform/mac/Skipped:
11:21 Changeset [113597] by inferno@chromium.org

Crash due to floats not cleared before starting SVG <text> layout.
https://bugs.webkit.org/show_bug.cgi?id=83021

Reviewed by Dirk Schulze.

.:

  • ManualTests/svg-text-float-not-removed-crash.html: Added.

Source/WebCore:

Manual Test - ManualTests/svg-text-float-not-removed-crash.html.
Can't reproduce the failure in DRT.

forceLayoutInlineChildren is used in SVG <text> layout and overrides
RenderBlock::layoutBlock. However, it missed the 'clearFloats' step,
which will cause a crash when trying to access removed renderers.

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::forceLayoutInlineChildren):

11:19 Changeset [113596] by jpfau@apple.com

Filter files from dataTransfer.getData on Mac
https://bugs.webkit.org/show_bug.cgi?id=38876

Reviewed by Enrica Casucci.

Source/WebCore:

The ClipboardMac class now keeps track of whether it was created for copy and paste, dragging and dropping
files or dragging and dropping generic data. This enables the class to block calls to set-/getData when the
clipboard is not operating on generic data, and vice-versa.

Test: fast/events/drop-with-file-paths.html

  • editing/mac/EditorMac.mm:

(WebCore::Editor::newGeneralClipboard):

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::createDraggingClipboard):

  • platform/mac/ClipboardMac.h:

(WebCore::ClipboardMac::create):
(ClipboardMac):

  • platform/mac/ClipboardMac.mm:

(WebCore::Clipboard::create):
(WebCore::ClipboardMac::ClipboardMac):
(WebCore::ClipboardMac::getData):
(WebCore::ClipboardMac::setData):
(WebCore::ClipboardMac::files):

LayoutTests:

  • fast/events/drop-with-file-paths-expected.txt: Added.
  • fast/events/drop-with-file-paths.html: Added.
  • fast/events/resources/file-for-drop-with-file-paths.html: Added.
11:13 Changeset [113595] by commit-queue@webkit.org

Unreviewed, rolling out r113561.
http://trac.webkit.org/changeset/113561
https://bugs.webkit.org/show_bug.cgi?id=83487

broke webkit_unit_tests (Requested by simonjam on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-09

Source/WebCore:

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::transformSurfaceOpaqueRegion):
(WebCore::computeOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):
(WebCore::testContentRectOccluded):
(WebCore::computeUnoccludedContentRect):

Source/WebKit/chromium:

  • tests/CCOcclusionTrackerTest.cpp:

(WebKitTests):

  • tests/CCQuadCullerTest.cpp:

(WebCore::TestCCOcclusionTrackerImpl::TestCCOcclusionTrackerImpl):

11:09 Changeset [113594] by leviw@chromium.org

Correct LayoutUnit usage in style functions getRoundedBorderFor
https://bugs.webkit.org/show_bug.cgi?id=83154

Reviewed by Julien Chaffraix.

Correcting LayoutUnit usage in getRoundedBorderFor and the calcRadiiFor helper function.

No new tests. No change in behavior.

  • rendering/style/RenderStyle.cpp:

(WebCore::calcRadiiFor): This is a static internal function that returns the radii based on a size.
It's only called from getRoundedBorderFor, so we're now pixel snapping the size before handing it
to this function.
(WebCore::RenderStyle::getRoundedBorderFor): Takes a LayoutRect and returns the pixel-snapped
resulting RoundedRect. Using a local IntRect to avoid snapping twice.

11:03 WebKitGTK/1.8.x edited by kov@webkit.org
(diff)
11:00 Changeset [113593] by kov@webkit.org

Merging 113019

10:37 Changeset [113592] by robert@webkit.org

Fix layout test for r113584 on Qt and Mac

Unreviewed.

  • fast/css/align-positioned-object-on-resize.html: Use layoutTestController.display() so that window.resizeTo() is honoured on all DRTs.
  • platform/qt/Skipped: Unskip the above test.
10:36 Changeset [113591] by caseq@chromium.org

Web Inspector: zoom on vertical mousewheel in Timeline overview
https://bugs.webkit.org/show_bug.cgi?id=83379

Reviewed by Pavel Feldman.

  • added support for zooming around mouse cursor upon mousewheel event;
  • handle mousewheel event by _onMouseWheel, not scrollWindow, so we only zoom on events internal to overview.
  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewWindow):
(WebInspector.TimelineOverviewWindow.prototype._endWindowSelectorDragging):
(WebInspector.TimelineOverviewWindow.prototype._onMouseWheel):
(WebInspector.TimelineOverviewWindow.prototype._zoom):

10:26 Changeset [113590] by leviw@chromium.org

Fix a bug in calculating pixelSnappedClientWidth/Height (thanks Julien), and cleaning up some style errors in LayoutTypes and Length.

10:17 Changeset [113589] by bbudge@chromium.org

Cross-origin preflight request should not include credentials.
https://bugs.webkit.org/show_bug.cgi?id=37676

Source/WebCore:

Modifies createAccessControlPreflightRequest so it never allows credentials.

Reviewed by Adam Barth.

http/tests/xmlhttprequest/access-control-preflight-credential-sync.html
http/tests/xmlhttprequest/access-control-preflight-credential-async.html

  • loader/CrossOriginAccessControl.cpp:

(WebCore::createAccessControlPreflightRequest):

  • loader/CrossOriginAccessControl.h:

(WebCore):

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequestWithPreflight):

LayoutTests:

Modifies preflight credential tests to make sure that cookies aren't sent along with the
CORS prefetch request.

Reviewed by Adam Barth.

  • http/tests/xmlhttprequest/access-control-preflight-credential-async-expected.txt:
  • http/tests/xmlhttprequest/access-control-preflight-credential-async.html:
  • http/tests/xmlhttprequest/access-control-preflight-credential-sync-expected.txt:
  • http/tests/xmlhttprequest/access-control-preflight-credential-sync.html:
  • http/tests/xmlhttprequest/resources/basic-auth/access-control-auth-basic.php:
10:01 Changeset [113588] by antti@apple.com

Don't expose internal CSSValues in API
https://bugs.webkit.org/show_bug.cgi?id=83426

Reviewed by Andreas Kling.

The CSSValues returned from functions like CSSStyleDeclaration.getPropertyCSSValue() are currently
the same instances we use internally. This creates various problems. The values can't be shared between
documents as the wrappers would be shared too. Having to maintain per-document CSSValuePools complicate
the architecture and increase memory usage. This also blocks sharing style sheet data structures
between documents.

This patch adds a concept of CSSOM-safe CSSValue. Only the safe values can be wrapped for JS access.
Values are unsafe by default. The CSSOM functions that return CSSValues create safe instances by
cloning the internal values.

The use of APIs that return CSSValues is very rare (the currect CSSOM draft deprecates them) and
cloning is cheap in any case. Future patches will eliminate the per-document value pool in favor
of a global one for a memory win.

In the future we want to replace internally used CSSValues with true internal types (StyleValues) and
use CSSValues exclusively as wrappers (similar to how CSSStyleRule wraps internal StyleRule).

  • bindings/js/JSCSSValueCustom.cpp:

(WebCore::toJS):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValueInternal):

  • css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::CSSImageSetValue):
(WebCore):
(WebCore::CSSImageSetValue::cloneForCSSOM):

  • css/CSSImageSetValue.h:

(CSSImageSetValue):

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::cleanup):

Opportunistically fix a string leak for CSS_COUNTER_NAME values.
Add all cases, remove default.

(WebCore::CSSPrimitiveValue::cloneForCSSOM):
(WebCore):

  • css/CSSPrimitiveValue.h:

(CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::setCSSOMSafe):

  • css/CSSValue.cpp:

(WebCore):
(TextCloneCSSValue):
(WebCore::TextCloneCSSValue::create):
(WebCore::TextCloneCSSValue::cssText):
(WebCore::TextCloneCSSValue::TextCloneCSSValue):

Most non-primitive value types are not exposed in CSSOM. For those we create a dummy value
that contains only the data that is accessible though the base CSSValue interface.

(WebCore::CSSValue::addSubresourceStyleURLs):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
(WebCore::CSSValue::cloneForCSSOM):

  • css/CSSValue.h:

(WebCore):
(CSSValue):
(WebCore::CSSValue::isCSSOMSafe):
(WebCore::CSSValue::isSubtypeExposedToCSSOM):
(WebCore::CSSValue::CSSValue):

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::CSSValueList):
(WebCore):
(WebCore::CSSValueList::cloneForCSSOM):

  • css/CSSValueList.h:

(CSSValueList):

  • css/Counter.h:

(Counter):
(WebCore::Counter::cloneForCSSOM):

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
(WebCore::PropertySetCSSStyleDeclaration::didMutate):
(WebCore):
(WebCore::PropertySetCSSStyleDeclaration::cloneAndCacheForCSSOM):

Maintain a map of safe CSSValues so we can maintain object identity.

  • css/PropertySetCSSStyleDeclaration.h:

(WebCore::PropertySetCSSStyleDeclaration::setNeedsStyleRecalc):
(PropertySetCSSStyleDeclaration):

  • css/RGBColor.cpp:

(WebCore::RGBColor::red):
(WebCore::RGBColor::green):
(WebCore::RGBColor::blue):
(WebCore::RGBColor::alpha):

  • css/Rect.h:

(WebCore::RectBase::RectBase):
(RectBase):
(Rect):
(WebCore::Rect::cloneForCSSOM):
(WebCore::Rect::Rect):
(Quad):
(WebCore::Quad::cloneForCSSOM):
(WebCore::Quad::Quad):

  • css/WebKitCSSFilterValue.cpp:

(WebCore::WebKitCSSFilterValue::WebKitCSSFilterValue):
(WebCore):
(WebCore::WebKitCSSFilterValue::cloneForCSSOM):

  • css/WebKitCSSFilterValue.h:

(WebKitCSSFilterValue):

  • css/WebKitCSSTransformValue.cpp:

(WebCore::WebKitCSSTransformValue::WebKitCSSTransformValue):
(WebCore):
(WebCore::WebKitCSSTransformValue::cloneForCSSOM):

  • css/WebKitCSSTransformValue.h:

(WebKitCSSTransformValue):

  • svg/SVGColor.cpp:

(WebCore::SVGColor::SVGColor):
(WebCore):
(WebCore::SVGColor::cloneForCSSOM):

  • svg/SVGColor.h:

(SVGColor):

  • svg/SVGPaint.cpp:

(WebCore::SVGPaint::SVGPaint):
(WebCore):
(WebCore::SVGPaint::cloneForCSSOM):

  • svg/SVGPaint.h:

(SVGPaint):

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::getPresentationAttribute):

09:44 Changeset [113587] by pfeldman@chromium.org

Web Inspector: get rid of WebInspector.Resource.category, use WebInspector.Resource.type instead.
https://bugs.webkit.org/show_bug.cgi?id=83467

Reviewed by Yury Semikhatsky.

Source/WebCore:

WebInspector.Resource.category is derived from the WebInspector.Resource.type and there is no real need it maintaining both.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/AuditLauncherView.js:

(WebInspector.AuditLauncherView.prototype._onResourceStarted):
(WebInspector.AuditLauncherView.prototype._onResourceFinished):

  • inspector/front-end/AuditRules.js:

(WebInspector.AuditRules.GzipRule.prototype._shouldCompress):
(WebInspector.AuditRules.CombineJsResourcesRule):
(WebInspector.AuditRules.CombineCssResourcesRule):
(WebInspector.AuditRules.ParallelizeDownloadRule.prototype.doRun):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
(WebInspector.AuditRules.CacheControlRule.prototype.isCompressible):
(WebInspector.AuditRules.StaticCookielessRule.prototype.processCookies):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModelResourceBinding):
(WebInspector.CSSStyleModelResourceBinding.prototype.setContent):
(WebInspector.CSSStyleModelResourceBinding.prototype._innerStyleSheetChanged):

  • inspector/front-end/ContentProviders.js:

(WebInspector.ResourceContentProvider):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModelResourceBinding):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype._getPopoverAnchor):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._makeResource):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkManager.get this):
(WebInspector.NetworkManager.get NetworkAgent):
(WebInspector.NetworkManager):
(WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
(WebInspector.NetworkDispatcher.prototype._mimeTypeIsConsistentWithType):
(WebInspector.NetworkDispatcher.prototype._updateResourceWithCachedResource):
(WebInspector.NetworkDispatcher.prototype.responseReceived):
(WebInspector.NetworkDispatcher.prototype.webSocketCreated):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._createFilterStatusBarItems):
(WebInspector.NetworkLogView.prototype._updateSummaryBar):
(WebInspector.NetworkDataGridNode.prototype.isFilteredOut):
(WebInspector.NetworkDataGridNode.prototype.refreshResource):
(WebInspector.NetworkDataGridNode.prototype._refreshNameCell):
(WebInspector.NetworkDataGridNode.prototype.refreshGraph):

  • inspector/front-end/Resource.js:

(WebInspector.Resource):
(WebInspector.Resource.registerDomainModelBinding):
(WebInspector.Resource.prototype.set type):
(WebInspector.Resource.prototype.isEditable):
(WebInspector.Resource.prototype.setContent):
(WebInspector.Resource.prototype.requestContent):

  • inspector/front-end/ResourceCategory.js: Removed.
  • inspector/front-end/ResourcePreviewView.js:

(WebInspector.ResourcePreviewView.prototype._createPreviewView):

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype.addScript):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype._onResourceUpdated):
(WebInspector.ResourceTreeModel.prototype._onResourceUpdateDropped):
(WebInspector.ResourceTreeModel.prototype._addFramesRecursively):

  • inspector/front-end/ResourceType.js: Added.

(WebInspector.ResourceType):
(WebInspector.ResourceType.prototype.name):
(WebInspector.ResourceType.prototype.title):
(WebInspector.ResourceType.prototype.categoryTitle):
(WebInspector.ResourceType.prototype.color):
(WebInspector.ResourceType.prototype.isTextType):
(WebInspector.ResourceType.prototype.toString):

  • inspector/front-end/ResourceView.js:

(WebInspector.ResourceView.hasTextContent):
(WebInspector.ResourceView.nonSourceViewForResource):
(WebInspector.EditableResourceSourceFrame.prototype.canEditSource):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameTreeElement.prototype.appendResource):
(WebInspector.FrameResourceTreeElement):
(WebInspector.FrameResourceTreeElement.prototype.onattach):
(WebInspector.ResourceRevisionTreeElement):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:

LayoutTests:

  • http/tests/inspector/network/async-xhr-json-mime-type-expected.txt:
  • http/tests/inspector/network/network-iframe-load-and-delete-expected.txt:
  • http/tests/inspector/network/network-xhr-async-expected.txt:
  • http/tests/inspector/network/network-xhr-same-url-as-main-resource.html:
  • http/tests/inspector/network/network-xhr-sync-expected.txt:
  • http/tests/inspector/resource-tree/resource-tree-invalid-mime-type-css-content.html:
  • http/tests/inspector/resource-tree/resource-tree-mimetype.html:
  • http/tests/inspector/resource-tree/resource-tree-test.js:

(initialize_ResourceTreeTest.InspectorTest.dumpResourceTreeEverything):
(initialize_ResourceTreeTest):

  • inspector/debugger/raw-source-code.html:
09:37 Changeset [113586] by alexis.menard@openbossa.org

Unreviewed, adding a missing header for the Qt port.

  • Target.pri:
09:35 Changeset [113585] by pfeldman@chromium.org

Web Inspector: [network panel] type column shows "undefined" instead of "(Pending)" upon load.
https://bugs.webkit.org/show_bug.cgi?id=83470

Reviewed by Yury Semikhatsky.

isPingRequest is tested for as a field, not a function return value.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkDataGridNode.prototype._refreshTypeCell):

09:34 Changeset [113584] by robert@webkit.org

REGRESSION (r94492): Incorrect initial layout of absolutely positioned <input> inside centering div
https://bugs.webkit.org/show_bug.cgi?id=77754

Reviewed by David Hyatt.

Source/WebCore:

The correct static position of an center-aligned, inline, absolutely positioned object with a block child can't be known
until the width of the child has been computed. This means that setStaticPositions() in RenderBlockLineLayout is setting
the position too early, before the width of the child has been finalised. To fix, adjust the static position of the inline
positioned object once its child's width has been calculated.

Test: fast/css/align-positioned-object-on-resize.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutPositionedObjects):

LayoutTests:

  • fast/css/align-positioned-object-on-resize-expected.txt: Added.
  • fast/css/align-positioned-object-on-resize.html: Added.
  • platform/qt/Skipped: Skipped on Qt as window.resizeTo() does not work properly in Qt DRT.
09:12 Changeset [113583] by eric.carlson@apple.com

WebVTT parser unnecessarily limits the value of a timestamp
https://bugs.webkit.org/show_bug.cgi?id=83422

Reviewed by Dan Bernstein.

Source/WebCore:

Test: media/track/track-large-timestamp.html

  • html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::collectTimeStamp): Make all constants double instead of int so

the maximum number of hours is increased and so we don't need any casts.

LayoutTests:

  • media/track/captions-webvtt/large-timestamp.vtt: Added.
  • media/track/track-large-timestamp-expected.txt: Added.
  • media/track/track-large-timestamp.html: Added.
09:05 Changeset [113582] by eae@chromium.org

Merge trunk changes up until 113577 into subpixel branch.

09:03 Changeset [113581] by inferno@chromium.org

Incorrect placement of new child to table when before child parent is not |this|.
https://bugs.webkit.org/show_bug.cgi?id=82630

Reviewed by Julien Chaffraix.

Source/WebCore:

Tests: fast/table/table-row-split2.html

fast/table/table-section-split2.html
fast/table/table-split.html
fast/table/table-split2.html

and tested by layouttests in commits r97180, r108127, and a few others.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addChildToAnonymousColumnBlocks): function rename, block->box.
(WebCore::RenderBlock::makeChildrenAnonymousColumnBlocks): ditto.
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks): ditto.

  • rendering/RenderBlock.h:

(RenderBlock):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::moveChildTo): move these functions from RenderBlock, needs to be
used in RenderBox::splitAnonymousBoxesAroundChild.
(WebCore):
(WebCore::RenderBox::moveChildrenTo): ditto.
(WebCore::markBoxForRelayoutAfterSplit): helper to mark a block or table part for complete relayout
after anonymous boxes are split around child.
(WebCore::RenderBox::splitAnonymousBoxesAroundChild): moved from RenderBlock to be able
to work with table parts.

  • rendering/RenderBox.h:

(RenderBox):
(WebCore::RenderBox::moveChildTo):
(WebCore::RenderBox::moveAllChildrenTo):
(WebCore::RenderBox::moveChildrenTo):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::addChild): no longer need the hack added in r95461.

  • rendering/RenderRubyBase.cpp:

(WebCore::RenderRubyBase::moveChildren): function rename, block->box.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::addChild): Use splitAnonymousBoxesAroundChild function when |beforeChild| != |this|.

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::addChild): ditto.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::addChild): ditto.

LayoutTests:

  • fast/table/cell-in-row-before-misnested-text-crash-css-expected.txt: rebaseline, corrects layout.
  • fast/table/cell-in-row-before-misnested-text-crash-expected.txt: rebaseline, corrects layout.
  • fast/table/row-in-tbody-before-misnested-text-crash-css-expected.txt: rebaseline, corrects layout.
  • fast/table/row-in-tbody-before-misnested-text-crash-expected.txt: rebaseline, corrects layout.
  • fast/table/table-row-split2-expected.png: Added.
  • fast/table/table-row-split2-expected.txt: Added.
  • fast/table/table-row-split2.html: Added.
  • fast/table/table-section-split2-expected.png: Added.
  • fast/table/table-section-split2-expected.txt: Added.
  • fast/table/table-section-split2.html: Added.
  • fast/table/table-split-expected.png: Added.
  • fast/table/table-split-expected.txt: Added.
  • fast/table/table-split.html: Added.
  • fast/table/table-split2-expected.png: Added.
  • fast/table/table-split2-expected.txt: Added.
  • fast/table/table-split2.html: Added.
08:52 PrefixedAPIs edited by jsbell@chromium.org
(diff)
08:51 PrefixedAPIs edited by jsbell@chromium.org
Added IndexedDB links (diff)
08:31 Changeset [113580] by jocelyn.turcotte@nokia.com

WebSocketServer: Honour WebSocketFrame::masked in makeFrameData
https://bugs.webkit.org/show_bug.cgi?id=83042

Reviewed by Kent Tamura.

Frames from the server should not be masked.
Currently, the flag is set to false, but the frames were masked anyway.
This causes clients with recent builds of WebKit to abort the connection to the
inspector server, refusing masked frames from the server as per the spec.
This doesn't change the behavior of WebSocket clients, which set the masked flag to true.

  • Modules/websockets/WebSocketFrame.cpp:

(WebCore::appendFramePayload):
(WebCore::WebSocketFrame::makeFrameData):

08:29 Changeset [113579] by schenney@chromium.org

Layout Test in svg are failing
https://bugs.webkit.org/show_bug.cgi?id=82232

Unreviewed Chromium expectations update.

All the tests covered by this bug ran without crashes over a five day
period. Given the previous crash rates, this suggests we've fixed the
problem.

  • platform/chromium/test_expectations.txt:
07:59 Changeset [113578] by eae@chromium.org

Revert abs changes from 113447 on branch as it broke linux builds.

06:43 Changeset [113577] by alexis.menard@openbossa.org

[Part 5] We should use CSSPropertyID rather than integers when manipulating CSS property ids.
https://bugs.webkit.org/show_bug.cgi?id=83466

Reviewed by Kentaro Hara.

CSSPropertyID enum holds all the CSS property ids but many parts of WebKit treat the ids
as integers, this patch should adress the last remaining occurences of ints rather than CSSPropertyIDs.

No new tests : There should be no behavior change in this patch.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • css/CSSStyleSelector.h:

(CSSStyleSelector):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::removePropertiesInSet):

  • page/animation/AnimationBase.cpp:

(WebCore::gatherEnclosingShorthandProperties):
(WebCore::AnimationBase::animatableShorthandsAffectingProperty):

  • page/animation/AnimationBase.h:

(AnimationBase):

  • page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::pauseTransitionAtTime):

  • page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::animate):
(WebCore::KeyframeAnimation::getAnimatedStyle):
(WebCore::KeyframeAnimation::overrideAnimations):
(WebCore::KeyframeAnimation::resumeOverriddenAnimations):
(WebCore::KeyframeAnimation::timeToNextService):

  • rendering/style/KeyframeList.cpp:

(WebCore::KeyframeList::insert):

  • rendering/style/KeyframeList.h:

(WebCore::KeyframeValue::addProperty):
(WebCore::KeyframeValue::containsProperty):
(WebCore::KeyframeValue::properties):
(KeyframeValue):
(WebCore::KeyframeList::addProperty):
(WebCore::KeyframeList::containsProperty):
(WebCore::KeyframeList::beginProperties):
(WebCore::KeyframeList::endProperties):
(KeyframeList):

06:34 Changeset [113576] by haraken@chromium.org

Unreviewed, rebaselined run-bindings-tests results.

  • bindings/scripts/test/JS/JSFloat64Array.cpp:

(WebCore::JSFloat64ArrayConstructor::getOwnPropertySlot):
(WebCore::JSFloat64ArrayConstructor::getOwnPropertyDescriptor):
(WebCore::jsFloat64ArrayConstructor):
(WebCore::JSFloat64Array::getConstructor):
(WebCore::jsFloat64ArrayPrototypeFunctionFoo):
(WebCore::toFloat64Array):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::JSTestActiveDOMObjectConstructor::getOwnPropertySlot):
(WebCore::JSTestActiveDOMObjectConstructor::getOwnPropertyDescriptor):
(WebCore::jsTestActiveDOMObjectExcitingAttr):
(WebCore::jsTestActiveDOMObjectConstructor):
(WebCore::JSTestActiveDOMObject::getConstructor):
(WebCore::jsTestActiveDOMObjectPrototypeFunctionExcitingFunction):
(WebCore::jsTestActiveDOMObjectPrototypeFunctionPostMessage):
(WebCore::JSTestActiveDOMObjectOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestActiveDOMObjectOwner::finalize):
(WebCore::toTestActiveDOMObject):

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore::JSTestCustomNamedGetterConstructor::getOwnPropertySlot):
(WebCore::JSTestCustomNamedGetterConstructor::getOwnPropertyDescriptor):
(WebCore::jsTestCustomNamedGetterConstructor):
(WebCore::JSTestCustomNamedGetter::getConstructor):
(WebCore::jsTestCustomNamedGetterPrototypeFunctionAnotherFunction):
(WebCore::JSTestCustomNamedGetterOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestCustomNamedGetterOwner::finalize):
(WebCore::toTestCustomNamedGetter):

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructorConstructor::getOwnPropertySlot):
(WebCore::JSTestEventConstructorConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestEventConstructorConstructor::constructJSTestEventConstructor):
(WebCore::jsTestEventConstructorAttr1):
(WebCore::jsTestEventConstructorAttr2):
(WebCore::jsTestEventConstructorConstructor):
(WebCore::JSTestEventConstructor::getConstructor):
(WebCore::JSTestEventConstructorOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestEventConstructorOwner::finalize):
(WebCore::toTestEventConstructor):

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::JSTestEventTargetConstructor::getOwnPropertySlot):
(WebCore::JSTestEventTargetConstructor::getOwnPropertyDescriptor):
(WebCore::jsTestEventTargetConstructor):
(WebCore::JSTestEventTarget::getConstructor):
(WebCore::jsTestEventTargetPrototypeFunctionItem):
(WebCore::jsTestEventTargetPrototypeFunctionAddEventListener):
(WebCore::jsTestEventTargetPrototypeFunctionRemoveEventListener):
(WebCore::jsTestEventTargetPrototypeFunctionDispatchEvent):
(WebCore::JSTestEventTarget::indexGetter):
(WebCore::JSTestEventTargetOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestEventTargetOwner::finalize):
(WebCore::toTestEventTarget):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::getOwnPropertySlot):
(WebCore::JSTestInterfaceConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestInterfaceConstructor::constructJSTestInterface):
(WebCore::jsTestInterfaceSupplementalStr1):
(WebCore::jsTestInterfaceSupplementalStr2):
(WebCore::jsTestInterfaceSupplementalStr3):
(WebCore::jsTestInterfaceSupplementalNode):
(WebCore::jsTestInterfaceConstructor):
(WebCore::setJSTestInterfaceSupplementalStr2):
(WebCore::setJSTestInterfaceSupplementalStr3):
(WebCore::setJSTestInterfaceSupplementalNode):
(WebCore::JSTestInterface::getConstructor):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod1):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod2):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod3):
(WebCore::JSTestInterfaceOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestInterfaceOwner::finalize):
(WebCore::toTestInterface):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListenerConstructor::getOwnPropertySlot):
(WebCore::JSTestMediaQueryListListenerConstructor::getOwnPropertyDescriptor):
(WebCore::jsTestMediaQueryListListenerConstructor):
(WebCore::JSTestMediaQueryListListener::getConstructor):
(WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):
(WebCore::JSTestMediaQueryListListenerOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestMediaQueryListListenerOwner::finalize):
(WebCore::toTestMediaQueryListListener):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorConstructor::getOwnPropertySlot):
(WebCore::JSTestNamedConstructorConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):
(WebCore::jsTestNamedConstructorConstructor):
(WebCore::JSTestNamedConstructor::getConstructor):
(WebCore::JSTestNamedConstructorOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestNamedConstructorOwner::finalize):
(WebCore::toTestNamedConstructor):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjConstructor::getOwnPropertySlot):
(WebCore::JSTestObjConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestObjConstructor::constructJSTestObj):
(WebCore::jsTestObjReadOnlyIntAttr):
(WebCore::jsTestObjReadOnlyStringAttr):
(WebCore::jsTestObjReadOnlyTestObjAttr):
(WebCore::jsTestObjShortAttr):
(WebCore::jsTestObjUnsignedShortAttr):
(WebCore::jsTestObjIntAttr):
(WebCore::jsTestObjLongLongAttr):
(WebCore::jsTestObjUnsignedLongLongAttr):
(WebCore::jsTestObjStringAttr):
(WebCore::jsTestObjTestObjAttr):
(WebCore::jsTestObjSequenceAttr):
(WebCore::jsTestObjXMLObjAttr):
(WebCore::jsTestObjCreate):
(WebCore::jsTestObjReflectedStringAttr):
(WebCore::jsTestObjReflectedIntegralAttr):
(WebCore::jsTestObjReflectedUnsignedIntegralAttr):
(WebCore::jsTestObjReflectedBooleanAttr):
(WebCore::jsTestObjReflectedURLAttr):
(WebCore::jsTestObjReflectedCustomIntegralAttr):
(WebCore::jsTestObjReflectedCustomBooleanAttr):
(WebCore::jsTestObjReflectedCustomURLAttr):
(WebCore::jsTestObjAttrWithGetterException):
(WebCore::jsTestObjAttrWithSetterException):
(WebCore::jsTestObjStringAttrWithGetterException):
(WebCore::jsTestObjStringAttrWithSetterException):
(WebCore::jsTestObjCustomAttr):
(WebCore::jsTestObjWithScriptStateAttribute):
(WebCore::jsTestObjWithScriptExecutionContextAttribute):
(WebCore::jsTestObjWithScriptStateAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttribute):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute):
(WebCore::jsTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::jsTestObjConditionalAttr1):
(WebCore::jsTestObjConditionalAttr2):
(WebCore::jsTestObjConditionalAttr3):
(WebCore::jsTestObjConditionalAttr4Constructor):
(WebCore::jsTestObjConditionalAttr5Constructor):
(WebCore::jsTestObjConditionalAttr6Constructor):
(WebCore::jsTestObjCachedAttribute1):
(WebCore::jsTestObjCachedAttribute2):
(WebCore::jsTestObjContentDocument):
(WebCore::jsTestObjMutablePoint):
(WebCore::jsTestObjImmutablePoint):
(WebCore::jsTestObjStrawberry):
(WebCore::jsTestObjStrictFloat):
(WebCore::jsTestObjDescription):
(WebCore::jsTestObjId):
(WebCore::jsTestObjHash):
(WebCore::jsTestObjConstructor):
(WebCore::setJSTestObjShortAttr):
(WebCore::setJSTestObjUnsignedShortAttr):
(WebCore::setJSTestObjIntAttr):
(WebCore::setJSTestObjLongLongAttr):
(WebCore::setJSTestObjUnsignedLongLongAttr):
(WebCore::setJSTestObjStringAttr):
(WebCore::setJSTestObjTestObjAttr):
(WebCore::setJSTestObjSequenceAttr):
(WebCore::setJSTestObjXMLObjAttr):
(WebCore::setJSTestObjCreate):
(WebCore::setJSTestObjReflectedStringAttr):
(WebCore::setJSTestObjReflectedIntegralAttr):
(WebCore::setJSTestObjReflectedUnsignedIntegralAttr):
(WebCore::setJSTestObjReflectedBooleanAttr):
(WebCore::setJSTestObjReflectedURLAttr):
(WebCore::setJSTestObjReflectedCustomIntegralAttr):
(WebCore::setJSTestObjReflectedCustomBooleanAttr):
(WebCore::setJSTestObjReflectedCustomURLAttr):
(WebCore::setJSTestObjAttrWithGetterException):
(WebCore::setJSTestObjAttrWithSetterException):
(WebCore::setJSTestObjStringAttrWithGetterException):
(WebCore::setJSTestObjStringAttrWithSetterException):
(WebCore::setJSTestObjCustomAttr):
(WebCore::setJSTestObjWithScriptStateAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAttribute):
(WebCore::setJSTestObjWithScriptStateAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute):
(WebCore::setJSTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::setJSTestObjConditionalAttr1):
(WebCore::setJSTestObjConditionalAttr2):
(WebCore::setJSTestObjConditionalAttr3):
(WebCore::setJSTestObjConditionalAttr4Constructor):
(WebCore::setJSTestObjConditionalAttr5Constructor):
(WebCore::setJSTestObjConditionalAttr6Constructor):
(WebCore::setJSTestObjMutablePoint):
(WebCore::setJSTestObjImmutablePoint):
(WebCore::setJSTestObjStrawberry):
(WebCore::setJSTestObjStrictFloat):
(WebCore::setJSTestObjId):
(WebCore::JSTestObj::getConstructor):
(WebCore::jsTestObjPrototypeFunctionVoidMethod):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionIntMethod):
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethod):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithSequenceArg):
(WebCore::jsTestObjPrototypeFunctionMethodReturningSequence):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionSerializedValue):
(WebCore::jsTestObjPrototypeFunctionIdbKey):
(WebCore::jsTestObjPrototypeFunctionOptionsObject):
(WebCore::jsTestObjPrototypeFunctionMethodWithException):
(WebCore::jsTestObjPrototypeFunctionCustomMethod):
(WebCore::jsTestObjPrototypeFunctionCustomMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionAddEventListener):
(WebCore::jsTestObjPrototypeFunctionRemoveEventListener):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoid):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObj):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoidException):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObjException):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContext):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptState):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateObjException):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateWithSpaces):
(WebCore::jsTestObjPrototypeFunctionWithScriptArgumentsAndCallStack):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalString):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsUndefined):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsNullString):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionConditionalMethod1):
(WebCore::jsTestObjPrototypeFunctionConditionalMethod2):
(WebCore::jsTestObjPrototypeFunctionConditionalMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod5):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod6):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod7):
(WebCore::jsTestObjPrototypeFunctionMethodWithUnsignedLongArray):
(WebCore::jsTestObjPrototypeFunctionGetSVGDocument):
(WebCore::jsTestObjPrototypeFunctionConvert1):
(WebCore::jsTestObjPrototypeFunctionConvert2):
(WebCore::jsTestObjPrototypeFunctionConvert3):
(WebCore::jsTestObjPrototypeFunctionConvert4):
(WebCore::jsTestObjPrototypeFunctionConvert5):
(WebCore::jsTestObjPrototypeFunctionMutablePointFunction):
(WebCore::jsTestObjPrototypeFunctionImmutablePointFunction):
(WebCore::jsTestObjPrototypeFunctionOrange):
(WebCore::jsTestObjPrototypeFunctionStrictFunction):
(WebCore::JSTestObjOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestObjOwner::finalize):
(WebCore::toTestObj):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::getOwnPropertySlot):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):
(WebCore::jsTestSerializedScriptValueInterfaceValue):
(WebCore::jsTestSerializedScriptValueInterfaceReadonlyValue):
(WebCore::jsTestSerializedScriptValueInterfaceCachedValue):
(WebCore::jsTestSerializedScriptValueInterfaceCachedReadonlyValue):
(WebCore::jsTestSerializedScriptValueInterfaceConstructor):
(WebCore::setJSTestSerializedScriptValueInterfaceValue):
(WebCore::setJSTestSerializedScriptValueInterfaceCachedValue):
(WebCore::JSTestSerializedScriptValueInterface::getConstructor):
(WebCore::jsTestSerializedScriptValueInterfacePrototypeFunctionAcceptTransferList):
(WebCore::jsTestSerializedScriptValueInterfacePrototypeFunctionMultiTransferList):
(WebCore::JSTestSerializedScriptValueInterfaceOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestSerializedScriptValueInterfaceOwner::finalize):
(WebCore::toTestSerializedScriptValueInterface):

06:24 Changeset [113575] by charles.wei@torchmobile.com.cn

[BlackBerry] Upstream BlackBerry change to WebCore::TouchEvent
https://bugs.webkit.org/show_bug.cgi?id=83454

Reviewed by Rob Buis.

BlackBerry-port enhances the TouchEvent by adding member variables
to indicate if the event is double-tap or touch-hold.

  • dom/TouchEvent.cpp:

(WebCore::TouchEvent::TouchEvent):
(WebCore::TouchEvent::initTouchEvent):

  • dom/TouchEvent.h:

(TouchEvent):
(WebCore::TouchEvent::setDoubleTap):
(WebCore::TouchEvent::isDoubleTap):
(WebCore::TouchEvent::setTouchHold):
(WebCore::TouchEvent::isTouchHold):

06:20 PrefixedAPIs edited by chutten@rim.com
CSS Properties added sourced from CSSProperty::isInheritedProperty (diff)
05:35 Changeset [113574] by paroga@webkit.org

[CMake] Build fix for USE_SYSTEM_MALLOC after r113570.

.:

  • Source/cmakeconfig.h.cmake:

Source/WTF:

  • wtf/CMakeLists.txt:
04:42 Changeset [113573] by commit-queue@webkit.org

Remove partially implemented per-Element visibility checks from requestAnimationFrame logic
https://bugs.webkit.org/show_bug.cgi?id=74232

Patch by James Robinson <jamesr@chromium.org> on 2012-04-09
Reviewed by Dean Jackson.

Source/WebCore:

The initial requestAnimationFrame implementation had an Element parameter as the second argument to the
function. This element was intended to convey the element associated with the animation so that when the element
was not visible the animation callback would not be run. The checked in implementation does a very limited check

  • testing for display:none and being detached from the tree - but does it in a way that does not work correctly

if an element's visibility is manipulated by a callback running from a different document. It also adds
significant complexity to the code, making it less hackable and easy to introduce subtle security bugs or
infinite loops.

This patch removes the parameter. Since it has always been marked optional, there is no web compat risk.

If this functionality is added back in the future it needs to be implemented in a way that considers all
callbacks within a Page and not only those within a single Document.

  • dom/Document.cpp:

(WebCore::Document::webkitRequestAnimationFrame):

  • dom/Document.h:
  • dom/RequestAnimationFrameCallback.h:
  • dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::registerCallback):
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):

  • dom/ScriptedAnimationController.h:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::webkitRequestAnimationFrame):

  • page/DOMWindow.h:
  • page/DOMWindow.idl:

LayoutTests:

Remove tests for removed functionality.

  • fast/animation/request-animation-frame-display-expected.txt: Removed.
  • fast/animation/request-animation-frame-display.html: Removed.
  • fast/animation/script-tests/request-animation-frame-display.js: Removed.
03:58 Changeset [113572] by paroga@webkit.org

Build fix for WinCE after r113570.

  • Scripts/build-webkit: Do not use FastMalloc for WinCE.
03:49 Changeset [113571] by paroga@webkit.org

Remove HAVE_STDINT_H
https://bugs.webkit.org/show_bug.cgi?id=83434

Reviewed by Kentaro Hara.

HAVE_STDINT_H is defined with 1 all the time and we us stdint.h without HAVE(STDINT_H) already.

Source/JavaScriptCore:

  • config.h:

Source/WTF:

  • config.h:
  • wtf/FastMalloc.cpp:
  • wtf/TCPageMap.h:
  • wtf/TCSpinLock.h:
  • wtf/TCSystemAlloc.cpp:
03:45 Changeset [113570] by paroga@webkit.org

[CMake] Share build system options across ports
https://bugs.webkit.org/show_bug.cgi?id=72815

Reviewed by Daniel Bates.

Don't define the generic features for every port again.
Add a few macros for reusing the central defined options.

  • CMakeLists.txt:
  • Source/cmake/OptionsBlackBerry.cmake:
  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsWinCE.cmake:
  • Source/cmake/WebKitFeatures.cmake:
03:33 Changeset [113569] by commit-queue@webkit.org

[Blackberry] m_isRequestedByPlugin should be copied in ResourceRequest
https://bugs.webkit.org/show_bug.cgi?id=83447

Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-04-09
Reviewed by George Staikos.

It is an obvious error, We should copy m_isRequestedByPlugin in ResourceReuest.

No new tests, because those existing plugin test cases are enough.

  • platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::ResourceRequest::doPlatformCopyData):
(WebCore::ResourceRequest::doPlatformAdopt):

03:19 Changeset [113568] by eric.carlson@apple.com

Subscribe eric.carlson@apple.com to Media-related changes
https://bugs.webkit.org/show_bug.cgi?id=83421

Reviewed by Dan Bernstein.

  • Scripts/webkitpy/common/config/watchlist:
03:02 Changeset [113567] by fischman@chromium.org

Layout Test http/tests/media/media-document.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=83391

[Chromium] Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
02:50 Changeset [113566] by fischman@chromium.org

several http tests are flaky and crashing on win, debug
https://bugs.webkit.org/show_bug.cgi?id=82505

Remove the expectations of a crash now that the fix (http://crrev.com/131170)
has rolled into webkit in http://trac.webkit.org/changeset/113512

Reviewed by Tony Chang.

  • platform/chromium/test_expectations.txt:
02:48 Changeset [113565] by commit-queue@webkit.org

check-webkit-style should ignore NULL usage in gtk_style_context_get_style
https://bugs.webkit.org/show_bug.cgi?id=83412

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-04-09
Reviewed by David Levin.

Accept NULL as an argument for gtk_style_context_get_style, because it's
used as a sentinel in a variable argument list.

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_for_null): Add an exception.

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(WebKitStyleTest.test_null_false_zero): Add a test for the exception.

02:42 Changeset [113564] by pfeldman@chromium.org

Not reviewed: fixing inspector front-end compilation that has been broken by the
recent SaveAs and DOMStorage changes.

  • inspector/front-end/DOMStorage.js:
  • inspector/front-end/externs.js:

(WebInspector.isURLSaved):

02:39 Changeset [113563] by pfeldman@chromium.org

Web Inspector: remove ComboBoxFileSelector and SingleFileEditorContainer.
https://bugs.webkit.org/show_bug.cgi?id=83460

Reviewed by Yury Semikhatsky.

Source/WebCore:

We are now using scripts navigator and tabbed editor container, removing the old components.
This change removes the corresponding classes and the abstractions used during the
transition period.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator.prototype._scriptSelected):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.get this):
(WebInspector.ScriptsPanel.prototype.get defaultFocusedElement):
(WebInspector.ScriptsPanel.prototype._addUISourceCode):
(WebInspector.ScriptsPanel.prototype.setScriptSourceIsDirty):
(WebInspector.ScriptsPanel.prototype._reset):
(WebInspector.ScriptsPanel.prototype._showFile):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):
(WebInspector.ScriptsPanel.prototype._editorClosed):
(WebInspector.ScriptsPanel.prototype._scriptSelected):
(WebInspector.ScriptsPanel.prototype._hidePinnedNavigator):
(WebInspector.ScriptsPanel.prototype.set _pinNavigator):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):

  • inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainerDelegate):
(WebInspector.TabbedEditorContainerDelegate.prototype.viewForFile):
(get WebInspector):
(WebInspector.TabbedEditorContainer.prototype._tabClosed):

  • inspector/front-end/scriptsPanel.css:

LayoutTests:

  • inspector/debugger/scripts-combobox-file-selector-history-expected.txt: Removed.
  • inspector/debugger/scripts-combobox-file-selector-history.html: Removed.
  • inspector/debugger/scripts-file-selector-expected.txt:
  • inspector/debugger/scripts-file-selector.html:
  • inspector/debugger/scripts-panel-expected.txt:
  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/scripts-sorting-expected.txt:
  • inspector/debugger/scripts-sorting.html:
  • inspector/debugger/source-frame-count.html:
02:22 Changeset [113562] by dpranke@chromium.org

webkitpy: use the filesystem object properly in fileuploader
https://bugs.webkit.org/show_bug.cgi?id=83326

Reviewed by Adam Barth.

We should be using the filesystem object rather than the codecs
object.

  • Scripts/webkitpy/common/net/file_uploader.py:

(FileUploader.upload_as_multipart_form_data):

02:05 Changeset [113561] by commit-queue@webkit.org

[chromium] Make culling work with clipped rects
https://bugs.webkit.org/show_bug.cgi?id=83217

Patch by Dana Jansens <danakj@chromium.org> on 2012-04-09
Reviewed by Adrienne Walker.

Source/WebCore:

Use new CCMathUtil transformation methods to deal with rects that clip
the camera plane. This fixes three things:

  1. A layer completely behind the camera is not visible and should not

occlude.

  1. A layer that is clipped by the camera is treated like a

non-axis-aligned transform, as the result of a mapClippedRect() is a
bounding box and may contain pixels not in the original rect. This guards
our use of mapRect() when transforming occluded regions.

  1. A layer's occlusion must be clipped by its scissor rect. This scissor

rect exists in its target space, so occlusion in screen space is only
possible if its target also is axis aligned in the screen, such that
the layer's scissor rect remains a rect in screen space.

Unit tests: CCOcclusionTrackerTestLayerBehindCameraDoesNotOcclude

CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::transformSurfaceOpaqueRegion):
(WebCore::computeOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):
(WebCore::testContentRectOccluded):
(WebCore::computeUnoccludedContentRect):

Source/WebKit/chromium:

  • tests/CCOcclusionTrackerTest.cpp:

(CCOcclusionTrackerTestLayerBehindCameraDoesNotOcclude):
(WebKitTests::CCOcclusionTrackerTestLayerBehindCameraDoesNotOcclude::runMyTest):
(WebKitTests):
(CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect):
(WebKitTests::CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect::runMyTest):

  • tests/CCQuadCullerTest.cpp:

(WebCore::TestCCOcclusionTrackerImpl::TestCCOcclusionTrackerImpl):

01:49 Changeset [113560] by commit-queue@webkit.org

[Gtk] Web Inspector noinst_DATA images are copied into innacurately named directory
https://bugs.webkit.org/show_bug.cgi?id=83423

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-04-09
Reviewed by Martin Robinson.

Copy Web Inspector images that are a part of the data not meant
for installation into a directory named 'Images' rather than
a lower-case version of that. This is required as until now,
when using these inspector resources (for example during layout
tests or manually pointing WEBKIT_INSPECTOR_PATH env to that
location), the images were not displayed as they were not loadable.

No new tests - no new functionality.

  • GNUmakefile.am:
00:55 Changeset [113559] by eric@webkit.org

Enable webkit_unit_tests for commit queue and EWS while tracking failures
https://bugs.webkit.org/show_bug.cgi?id=83329

Unreviewed. Add a missing import to unbreak all the Chromium EWS/CQ bots. :)

line 62, in _create_unit_test_results

return UnitTestResults.results_from_string(results_xml)
NameError: global name 'UnitTestResults' is not defined

  • Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
  • Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:

(LayoutTestResultsReaderTest.test_create_unit_test_results):

00:50 Changeset [113558] by pfeldman@chromium.org

Web Inspector: move breakpoints active state from scripts panel to debugger presentation model.
https://bugs.webkit.org/show_bug.cgi?id=83374

Reviewed by Yury Semikhatsky.

Source/WebCore:

Just moves the state and adds event to propagate it. This is needed to abstract
JavaScriptSourceFrame from the ScriptsPanel.

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpointsActive):
(WebInspector.DebuggerPresentationModel.prototype.breakpointsActive):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype._setBreakpoint):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._toggleBreakpointsClicked):
(WebInspector.ScriptsPanel.prototype._breakpointsActiveStateChanged):
(WebInspector.ScriptsPanel.prototype._createDebugToolbar):

LayoutTests:

  • http/tests/inspector/debugger-test.js:
  • inspector/debugger/debugger-breakpoints-not-activated-on-reload.html:
00:48 Changeset [113557] by fpizlo@apple.com

DFG should not load the property storage if it is inline.
https://bugs.webkit.org/show_bug.cgi?id=83455

Reviewed by Gavin Barraclough.

We had previously decided to have all property storage accesses go through
the property storage pointer even if they don't "really" have to, because
we were thinking this would help GC barriers somehow. Well, we never ended
up doing anything with that. Hence, doing these wasted loads of the
property storage pointer when the storage is inline is just a waste of CPU
cycles.

This change makes the DFG's inline property accesses (GetByOffset and
PutByOffset) go directly to the inline property storage if the structure(s)
tell us that it's OK.

This looks like an across-the-board 1% win.

  • bytecode/StructureSet.h:

(JSC):
(JSC::StructureSet::allAreUsingInlinePropertyStorage):
(StructureSet):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::fillStorage):

04/08/12:

22:25 Changeset [113556] by mitz@apple.com

[mac] REGRESSION (r113467): Some canvas tests are failing in WebKit1 when run after compositing/tiled-layers-hidpi.html
https://bugs.webkit.org/show_bug.cgi?id=83453

Reviewed by Sam Weinig.

  • WebView/WebView.mm:

(-[WebView _setCustomBackingScaleFactor:]): When the scale factor parameter was 0, meaning
no custom scale factor, this method was setting the Page scale factor to 0, and that value
was used by canvas. Changed it to correctly set the Page scale factor back to the device
scale factor.

21:59 Changeset [113555] by commit-queue@webkit.org

<content> in <meter> is not rendered correctly.
https://bugs.webkit.org/show_bug.cgi?id=81311

This code changes a code location where MeterValueElement's value
attribute is initialized. In the old code, HTMLMeterElement's attach
did. It is better to initialize the attribute just after creating
meter's shadow subtree.

Patch by Takashi Sakamoto <tasak@google.com> on 2012-04-08
Reviewed by Hajime Morita.

No new tests, because an existing test,
content-element-in-meter-element.html covers.
However test_expectations.txt is changed. Now the test passes.

  • html/HTMLMeterElement.cpp:
  • html/HTMLMeterElement.h:

(HTMLMeterElement):
(HTMLMeterElement::attach):
Removed attach method, because attach method is just calling
LabelableElement::attach after removing didElementStateChange.
(HTMLMeterElement::createShadowSubTree):
Added setWidthPercentage to initialize MeterValueElement's value
attribute.

  • LayoutTests/platform/chromium/test_expectations.txt:

Removed BUGWK81311 fast/dom/shadow/content-element-in-meter.html,
because now contentElementInMeterElement passes.

21:04 Changeset [113554] by abarth@webkit.org

The port object is missing unit_tests_results_path
https://bugs.webkit.org/show_bug.cgi?id=83448

Unreviewed.

This is causing the cr-linux-ews to throw an exception.

  • Scripts/webkitpy/common/config/ports.py:

(DeprecatedPort.unit_tests_results_path):

13:50 Changeset [113553] by fpizlo@apple.com

Command-line jsc's exception handling should be rationalized
https://bugs.webkit.org/show_bug.cgi?id=83437

Reviewed by Dan Bernstein.

  • If an exception is thrown during run() execution, it is now propagated, so that it will terminate program execution unless it is caught.


  • If program execution terminates with an exception, the exception is now always printed.


  • When printing the exception, the backtrace is now also printed if one is available. It will only not be available if you use something akin to my favorite line of code, 'throw "error"', since primitives don't have properties and hence we cannot attach a "stack" property to them.
  • jsc.cpp:

(functionRun):
(runWithScripts):

13:46 Changeset [113552] by fpizlo@apple.com

Forced OSR exits should lead to recompilation based on count, not rate
https://bugs.webkit.org/show_bug.cgi?id=83247
<rdar://problem/10720925>

Reviewed by Geoff Garen.

Track which OSR exits happen because of inadequate coverage. Count them
separately. If the count reaches a threshold, immediately trigger
reoptimization.

This is in contrast to the recompilation trigger for all other OSR exits.
Normally recomp is triggered when the exit rate exceeds a certain ratio.

Looks like a slight V8 speedup (sub 1%).

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::forcedOSRExitCounter):
(JSC::CodeBlock::addressOfForcedOSRExitCounter):
(JSC::CodeBlock::offsetOfForcedOSRExitCounter):
(JSC::CodeBlock::shouldReoptimizeNow):
(JSC::CodeBlock::shouldReoptimizeFromLoopNow):
(CodeBlock):

  • bytecode/DFGExitProfile.h:

(JSC::DFG::exitKindToString):

  • dfg/DFGOSRExitCompiler.cpp:

(JSC::DFG::OSRExitCompiler::handleExitCounts):
(DFG):

  • dfg/DFGOSRExitCompiler.h:

(OSRExitCompiler):

  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOperations.cpp:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • runtime/Options.cpp:

(Options):
(JSC::Options::initializeOptions):

  • runtime/Options.h:

(Options):

13:38 PrefixedAPIs edited by jhawkins@chromium.org
(diff)
11:35 Changeset [113551] by paroga@webkit.org

Build fix for !ENABLE(CSS_FILTERS) && ASSERT_DISABLED after r109953.

  • platform/graphics/ca/GraphicsLayerCA.cpp:
Note: See TracTimeline for information about the timeline view.