Timeline



Apr 27, 2012:

11:32 PM Changeset in webkit [115550] by Csaba Osztrogonác
  • 9 edits in trunk/LayoutTests

Unreviewed gardening, update expected files after r115446.

  • fast/dom/Window/window-lookup-precedence-expected.txt: Updated after r115446.
  • platform/qt-4.8/fast/dom/Window/window-properties-expected.txt: Updated after r115446.
  • platform/qt-5.0-wk2/fast/dom/Window/window-properties-expected.txt: Updated after r115446.
  • platform/qt-5.0-wk2/fast/dom/prototype-inheritance-2-expected.txt: Updated after r115446.
  • platform/qt-5.0/fast/dom/Window/window-properties-expected.txt: Updated after r115446.
  • platform/qt-5.0/fast/dom/prototype-inheritance-2-expected.txt: Updated after r115446.
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt: Updated after r115446.
  • platform/qt/fast/js/global-constructors-expected.txt: Updated after r115446.
11:28 PM Changeset in webkit [115549] by jochen@chromium.org
  • 2 edits in trunk/Source/WebCore

Ensure that there's always a provisional document loader if the frame loader is in provisional state
https://bugs.webkit.org/show_bug.cgi?id=83894

Reviewed by Nate Chapin.

We're still seeing crashes in the FrameLoader where the FrameLoader's
state is "provisional" but there is no provisional document loader. I
added code to update the FrameLoader's state everytime the provisional
document loader is cleared, and added checks that the FrameLoader's
state can't be set to provisional without a provisional loader.

If the crashes go away, or the newly added checks reveal the culprit,
we should relex the checks to use ASSERT() instead of CRASH().

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::init):
(WebCore::FrameLoader::setupForReplace):
(WebCore::FrameLoader::stopAllLoaders):
(WebCore::FrameLoader::clearProvisionalLoad):
(WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):

11:06 PM Changeset in webkit [115548] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Try to fix the Windows build.

  • heap/WeakBlock.h:

(WeakBlock):

11:05 PM Changeset in webkit [115547] by zandobersek@gmail.com
  • 6 edits in trunk/LayoutTests

Unreviewed, rebaselining after revisions 115446, 115510 and 115533.

  • fast/dom/Window/window-lookup-precedence-expected.txt:
  • http/tests/websocket/tests/hixie76/url-parsing-expected.txt:
  • http/tests/websocket/tests/hybi/url-parsing-expected.txt:
  • platform/gtk/media/video-colorspace-yuv420-expected.txt:
  • platform/gtk/media/video-colorspace-yuv422-expected.txt:
11:02 PM Changeset in webkit [115546] by ggaren@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix the Qt build.

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMethod::finishCreation):

10:57 PM Changeset in webkit [115545] by ggaren@apple.com
  • 27 edits
    1 copy in trunk/Source

Made WeakSet::allocate() static and removed its JSGlobalData argument
https://bugs.webkit.org/show_bug.cgi?id=85128

Reviewed by Anders Carlsson.

../JavaScriptCore:

This is a step toward faster finalization.

WeakSet::allocate() now deduces which WeakSet to allocate from based on
its JSCell* argument. (Currently, there's only one WeakSet, but soon
there will be many.)

This was a global replace of "globalData.heap.weakSet()->allocate" with
"WeakSet::allocate", plus by-hand removal of the JSGlobalData argument.

  • heap/WeakSetInlines.h: Copied from Source/JavaScriptCore/heap/WeakSet.h.

I had to split out WeakSet::allocate() in to a separate header to avoid
a cycle.

(JSC::WeakSet::allocate): We can mask the pointer we're passed to
figure out where to allocate our WeakImpl. (Soon, we'll use this to
associate the WeakImpl with the GC block it references.)

../WebCore:

Mechanically removed JSGlobalData arguments from PassWeak<T> and Weak<T> allocation.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::jsStringSlowCase):

  • bindings/js/JSEventListener.h:

(WebCore::JSEventListener::setWrapper):

  • bindings/js/JSNodeFilterCondition.cpp:

(WebCore::JSNodeFilterCondition::JSNodeFilterCondition):

  • bindings/js/ScriptWrappable.h:

(WebCore::ScriptWrappable::setWrapper):

  • bridge/jsc/BridgeJSC.cpp:

(JSC::Bindings::Instance::createRuntimeObject):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMethod::finishCreation):

  • bridge/runtime_root.cpp:

(JSC::Bindings::RootObject::addRuntimeObject):

../WebKit2:

Mechanically removed JSGlobalData arguments from PassWeak<T> and Weak<T> allocation.

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::getOrCreateJSObject):

10:33 PM DeprecatingFeatures edited by dbates@webkit.org
Spelling corrections (diff)
10:31 PM Changeset in webkit [115544] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/10346980> REGRESSION: Cannot enter text in Dashboard widget fields that have placeholder attribute

Remove a dashboard backwards compatibility quirk that was in place to support an old version
of the Stocks widget. It prevented the pointer-events property from being applied in Dashboard
widgets, which caused -webkit-input-placeholder elements to eat mouse clicks rather than giving
focus to the containing input elements. The offending widget has long since been fixed.

Reviewed by Dan Bernstein.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

10:20 PM Changeset in webkit [115543] by mrowe@apple.com
  • 17 edits in tags/Safari-536.8.5

Merge r115501.

10:19 PM Changeset in webkit [115542] by mrowe@apple.com
  • 4 edits in tags/Safari-536.8.5/Source

Versioning.

10:16 PM Changeset in webkit [115541] by mrowe@apple.com
  • 1 copy in tags/Safari-536.8.5

New tag.

9:59 PM Changeset in webkit [115540] by dino@apple.com
  • 8 edits
    14 adds in trunk

Support reverse and alternate-reverse in CA animations
https://bugs.webkit.org/show_bug.cgi?id=78041

Reviewed by Beth Dakin.

Source/WebCore:

CoreAnimation does not natively support reverse and alternate-reverse
animation directions so we need to flip the animation values (keyframe
keys and timing functions) that we send to GraphicsLayerCA. Unfortunately
this code adds a lot of conditionals because it isn't as simple as
reversing the order of keys. You also now have a different alignment of
timing functions to the reversed list.

New tests to cover the two new directions, making sure the timing
functions are correctly inverted, and exercising fill modes.

Tests: animations/animation-direction-reverse-fill-mode-hardware.html

animations/animation-direction-reverse-fill-mode.html
animations/animation-direction-reverse-hardware-opacity.html
animations/animation-direction-reverse-hardware.html
animations/animation-direction-reverse-non-hardware.html
animations/animation-direction-reverse-timing-functions-hardware.html
animations/animation-direction-reverse-timing-functions.html

  • platform/graphics/ca/GraphicsLayerCA.cpp: Handle the previously unsupported animation directions, reversing the list of values and keytimes that would be used to create the CA Animation.

(WebCore::GraphicsLayerCA::addAnimation):

Do not create an animation if on Windows and using a reverse
direction.

(WebCore::GraphicsLayerCA::createFilterAnimationsFromKeyframes):
(WebCore::GraphicsLayerCA::setupAnimation):
(WebCore::GraphicsLayerCA::setAnimationEndpoints):
(WebCore::GraphicsLayerCA::setAnimationKeyframes):
(WebCore::GraphicsLayerCA::setTransformAnimationEndpoints):
(WebCore::GraphicsLayerCA::setTransformAnimationKeyframes):
(WebCore::GraphicsLayerCA::setFilterAnimationEndpoints):
(WebCore::GraphicsLayerCA::setFilterAnimationKeyframes):

  • platform/graphics/ca/PlatformCAAnimation.h:

(PlatformCAAnimation): Pass through a flag that tells the CA Animation
that it should invert the timing functions.

  • platform/graphics/ca/mac/PlatformCAAnimationMac.mm:

(toCAMediaTimingFunction): Add a parameter that will invert the timing
function coefficients if necessary.
(PlatformCAAnimation::setTimingFunction):
(PlatformCAAnimation::setTimingFunctions):

  • platform/graphics/ca/win/PlatformCAAnimationWin.cpp:

(toCACFTimingFunction):

New unused parameter.

LayoutTests:

Tests support for reverse and alternate-reverse animations on
CoreAnimation objects, as well as filling out some of the software
animator tests. There are three variables to exercise: reverse vs
forward direction animations, whether reversed timing functions are
inverted correctly, and that fill mode respects the direction of
animation.

Refactored the animation test helper class so we could reuse
property parsing and evaluation.

  • animations/animation-direction-reverse-fill-mode-expected.txt: Added.
  • animations/animation-direction-reverse-fill-mode-hardware-expected.txt: Added.
  • animations/animation-direction-reverse-fill-mode-hardware.html: Added.
  • animations/animation-direction-reverse-fill-mode.html: Added.
  • animations/animation-direction-reverse-hardware-expected.txt: Added.
  • animations/animation-direction-reverse-hardware-opacity-expected.txt: Added.
  • animations/animation-direction-reverse-hardware-opacity.html: Added.
  • animations/animation-direction-reverse-hardware.html: Added.
  • animations/animation-direction-reverse-non-hardware-expected.txt: Added.
  • animations/animation-direction-reverse-non-hardware.html: Added.
  • animations/animation-direction-reverse-timing-functions-expected.txt: Added.
  • animations/animation-direction-reverse-timing-functions-hardware-expected.txt: Added.
  • animations/animation-direction-reverse-timing-functions-hardware.html: Added.
  • animations/animation-direction-reverse-timing-functions.html: Added.
  • animations/resources/animation-test-helpers.js:

(checkExpectedValue):
(getPropertyValue):
(comparePropertyValue):

9:57 PM Changeset in webkit [115539] by commit-queue@webkit.org
  • 4 edits
    2 deletes in trunk

Unreviewed, rolling out r115407.
http://trac.webkit.org/changeset/115407
https://bugs.webkit.org/show_bug.cgi?id=85126

Caused heap use after free (Requested by keishi_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-27

Source/WebCore:

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::HTMLFormControlElement):
(WebCore::HTMLFormControlElement::updateFieldSetAndLegendAncestor):
(WebCore::HTMLFormControlElement::insertedInto):
(WebCore::HTMLFormControlElement::removedFrom):
(WebCore::HTMLFormControlElement::disabled):
(WebCore::HTMLFormControlElement::recalcWillValidate):
(WebCore::HTMLFormControlElement::setNeedsWillValidateCheck):

  • html/HTMLFormControlElement.h:

(HTMLFormControlElement):

LayoutTests:

  • fast/forms/datalist/datalist-child-validation-expected.txt: Removed.
  • fast/forms/datalist/datalist-child-validation.html: Removed.
9:26 PM Changeset in webkit [115538] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Stop using aligned allocation for WeakBlock
https://bugs.webkit.org/show_bug.cgi?id=85124

Reviewed by Anders Carlsson.

We don't actually use the alignment for anything.

  • heap/WeakBlock.cpp:

(JSC::WeakBlock::create):
(JSC::WeakBlock::WeakBlock): Switched from aligned allocation to regular
allocation.

  • heap/WeakBlock.h:

(WeakBlock): Don't use HeapBlock because HeapBlock requires aligned
allocation. This change required me to add some declarations that we used
to inherit from HeapBlock.

(WeakBlock::blockFor): Removed. This function relied on aligned allocation
but didn't do anything for us.

(WeakBlock::deallocate): Removed. WeakBlock doesn't own any of the deallocation
logic, so it shouldn't own the function.

  • heap/WeakSet.cpp:

(JSC::WeakSet::~WeakSet):
(JSC::WeakSet::finalizeAll):
(JSC::WeakSet::visitLiveWeakImpls):
(JSC::WeakSet::visitDeadWeakImpls):
(JSC::WeakSet::sweep):
(JSC::WeakSet::shrink):
(JSC::WeakSet::resetAllocator):
(JSC::WeakSet::tryFindAllocator):

  • heap/WeakSet.h:

(WeakSet): Updated declarations to reflect WeakBlock not inheriting from
HeapBlock. This allowed me to remove some casts, which was nice.

(JSC::WeakSet::deallocate): Directly set the deallocated flag instead of
asking WeakBlock to do it for us. We don't need to have a WeakBlock
pointer to set the flag, so stop asking for one.

9:16 PM Changeset in webkit [115537] by commit-queue@webkit.org
  • 4 edits
    1 delete in trunk/Source/WebKit/chromium

Unreviewed, rolling out r115529.
http://trac.webkit.org/changeset/115529
https://bugs.webkit.org/show_bug.cgi?id=85125

Broke Clang build (Requested by enne on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-27

  • WebKit.gypi:
  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::setVideoFrameProviderClient):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

  • tests/WebMediaPlayerClientImplTest.cpp: Removed.
8:58 PM Changeset in webkit [115536] by haraken@chromium.org
  • 21 edits in trunk/Source

[JSC] Implement a helper method createNotEnoughArgumentsError()
https://bugs.webkit.org/show_bug.cgi?id=85102

Reviewed by Geoffrey Garen.

In bug 84787, kbr@ requested to avoid hard-coding
createTypeError(exec, "Not enough arguments") here and there.
This patch implements createNotEnoughArgumentsError(exec)
and uses it in JSC bindings.

c.f. a corresponding bug for V8 bindings is bug 85097.

Source/JavaScriptCore:

  • runtime/Error.cpp:

(JSC::createNotEnoughArgumentsError):
(JSC):

  • runtime/Error.h:

(JSC):

Source/WebCore:

Test: bindings/scripts/test/TestObj.idl

  • bindings/scripts/CodeGeneratorJS.pm: Modified as described above.

(GenerateArgumentsCountCheck):

  • bindings/js/JSDataViewCustom.cpp: Ditto.

(WebCore::getDataViewMember):
(WebCore::setDataViewMember):

  • bindings/js/JSDeprecatedPeerConnectionCustom.cpp:

(WebCore::JSDeprecatedPeerConnectionConstructor::constructJSDeprecatedPeerConnection):

  • bindings/js/JSDirectoryEntryCustom.cpp:

(WebCore::JSDirectoryEntry::getFile):
(WebCore::JSDirectoryEntry::getDirectory):

  • bindings/js/JSSharedWorkerCustom.cpp:

(WebCore::JSSharedWorkerConstructor::constructJSSharedWorker):

  • bindings/js/JSWebKitMutationObserverCustom.cpp:

(WebCore::JSWebKitMutationObserverConstructor::constructJSWebKitMutationObserver):
(WebCore::JSWebKitMutationObserver::observe):

  • bindings/js/JSWorkerCustom.cpp:

(WebCore::JSWorkerConstructor::constructJSWorker):

  • bindings/scripts/test/JS/JSFloat64Array.cpp: Updated run-bindings-tests.

(WebCore::jsFloat64ArrayPrototypeFunctionFoo):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::jsTestActiveDOMObjectPrototypeFunctionExcitingFunction):
(WebCore::jsTestActiveDOMObjectPrototypeFunctionPostMessage):

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore::jsTestCustomNamedGetterPrototypeFunctionAnotherFunction):

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::jsTestEventTargetPrototypeFunctionItem):
(WebCore::jsTestEventTargetPrototypeFunctionAddEventListener):
(WebCore::jsTestEventTargetPrototypeFunctionRemoveEventListener):
(WebCore::jsTestEventTargetPrototypeFunctionDispatchEvent):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::constructJSTestInterface):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod2):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjConstructor::constructJSTestObj):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithSequenceArg):
(WebCore::jsTestObjPrototypeFunctionMethodReturningSequence):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionSerializedValue):
(WebCore::jsTestObjPrototypeFunctionIdbKey):
(WebCore::jsTestObjPrototypeFunctionOptionsObject):
(WebCore::jsTestObjPrototypeFunctionAddEventListener):
(WebCore::jsTestObjPrototypeFunctionRemoveEventListener):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod5):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod6):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod7):
(WebCore::jsTestObjConstructorFunctionClassMethod2):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod11):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod12):
(WebCore::jsTestObjPrototypeFunctionMethodWithUnsignedLongArray):
(WebCore::jsTestObjPrototypeFunctionConvert1):
(WebCore::jsTestObjPrototypeFunctionConvert2):
(WebCore::jsTestObjPrototypeFunctionConvert3):
(WebCore::jsTestObjPrototypeFunctionConvert4):
(WebCore::jsTestObjPrototypeFunctionConvert5):
(WebCore::jsTestObjPrototypeFunctionStrictFunction):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):
(WebCore::jsTestSerializedScriptValueInterfacePrototypeFunctionAcceptTransferList):

8:56 PM Changeset in webkit [115535] by pilgrim@chromium.org
  • 8 edits in trunk/Source

[Chromium] Call highMemoryUsageMB directly
https://bugs.webkit.org/show_bug.cgi?id=84841

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

  • bindings/v8/V8GCController.cpp:

(WebCore::V8GCController::checkMemoryUsage):

  • platform/MemoryUsageSupport.cpp:

(WebCore::MemoryUsageSupport::highMemoryUsageMB):
(WebCore):

  • platform/MemoryUsageSupport.h:

(MemoryUsageSupport):

  • platform/chromium/MemoryUsageSupportChromium.cpp:

(WebCore::MemoryUsageSupport::highMemoryUsageMB):
(WebCore):

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore):

8:43 PM Changeset in webkit [115534] by ggaren@apple.com
  • 7 edits in trunk/Source

Only allow non-null pointers in the WeakSet
https://bugs.webkit.org/show_bug.cgi?id=85119

Reviewed by Darin Adler.

../JavaScriptCore:

This is a step toward more efficient finalization.

No clients put non-pointers (JSValues) into Weak<T> and PassWeak<T>.

Some clients put null pointers into Weak<T> and PassWeak<T>, but this is
more efficient and straight-forward to model with a null in the Weak<T>
or PassWeak<T> instead of allocating a WeakImpl just to hold null.

  • heap/PassWeak.h:

(JSC): Removed the Unknown (JSValue) type of weak pointer because it's
unused now.

(PassWeak): Don't provide a default initializer for our JSCell* argument.
This feature was only used in one place, and it was a bug.

(JSC::::get): Don't check for a null stored inside our WeakImpl: that's
not allowed anymore.

(JSC::PassWeak::PassWeak): Handle null as a null WeakImpl instead of
allocating a WeakImpl and storing null into it.

  • heap/Weak.h:

(Weak):
(JSC::::Weak): Same changes as in PassWeak<T>.

  • heap/WeakBlock.cpp:

(JSC::WeakBlock::visitLiveWeakImpls):
(JSC::WeakBlock::visitDeadWeakImpls): Only non-null cells are valid in
the WeakSet now, so no need to check for non-cells and null cell pointers.

  • heap/WeakImpl.h:

(JSC::WeakImpl::WeakImpl): Only non-null cells are valid in the WeakSet
now, so ASSERT that.

../WebCore:

  • bridge/jsc/BridgeJSC.cpp:

(JSC::Bindings::Instance::Instance): Don't allocate a WeakImpl just to
store null. This was needless, and is now a compile error. Instead,
rely on the default constructor, which will produce a cheap null.

8:30 PM Changeset in webkit [115533] by haraken@chromium.org
  • 21 edits in trunk

"Not enough arguments" error should be TypeError
https://bugs.webkit.org/show_bug.cgi?id=84628

Reviewed by Darin Adler.

Source/WebCore:

Currently, some custom bindings implement "Not enough arguments"
error as SyntaxError. The Web IDL spec requires that it should be
TypeError: http://www.w3.org/TR/WebIDL/#dfn-overload-resolution-algorithm
Thus, this patch changes SyntaxError to TypeError.

Tests: http/tests/websocket/tests/hixie76/url-parsing.html:

http/tests/websocket/tests/hybi/url-parsing.html:
http/tests/xmlhttprequest/exceptions.html:
svg/dom/SVGLength.html:
webaudio/audionode.html:

  • bindings/js/JSAudioContextCustom.cpp:

(WebCore::JSAudioContextConstructor::constructJSAudioContext):

  • bindings/js/JSSVGLengthCustom.cpp:

(WebCore::JSSVGLength::convertToSpecifiedUnits):

  • bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocketConstructor::constructJSWebSocket):
(WebCore::JSWebSocket::send):

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::open):

  • bindings/v8/custom/V8AudioContextCustom.cpp:

(WebCore::V8AudioContext::constructorCallback):

  • bindings/v8/custom/V8SVGLengthCustom.cpp:

(WebCore::V8SVGLength::convertToSpecifiedUnitsCallback):

  • bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::V8WebSocket::constructorCallback):
(WebCore::V8WebSocket::sendCallback):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::openCallback):

LayoutTests:

Currently, some custom bindings implement "Not enough arguments"
error as SyntaxError. The Web IDL spec requires that it should be
TypeError: http://www.w3.org/TR/WebIDL/#dfn-overload-resolution-algorithm
Thus, this patch changes SyntaxError to TypeError, and adds test
cases for the exception.

  • http/tests/websocket/tests/hixie76/send-empty-expected.txt:
  • http/tests/websocket/tests/hixie76/url-parsing.html:
  • http/tests/websocket/tests/hybi/send-empty-expected.txt:
  • http/tests/websocket/tests/hybi/url-parsing.html:
  • http/tests/xmlhttprequest/exceptions-expected.txt:
  • http/tests/xmlhttprequest/exceptions.html:
  • platform/chromium-linux/http/tests/websocket/tests/hixie76/url-parsing-expected.txt:
  • platform/chromium/http/tests/websocket/tests/hybi/url-parsing-expected.txt:
  • svg/dom/SVGLength-expected.txt:
  • webaudio/audionode-expected.txt:
  • webaudio/audionode.html:
8:23 PM Changeset in webkit [115532] by kov@webkit.org
  • 5 edits in trunk/Tools

[GTK] jhbuild cloning is not following WEBKITOUTPUTDIR.
https://bugs.webkit.org/show_bug.cgi?id=76161

Reviewed by Martin Robinson.

  • Scripts/webkitdirs.pm:

(getJhbuildPath): New method to obtain the jhbuild base directory,
using the product base directory
(jhbuildConfigurationChanged): Use the new method
(buildAutotoolsProject): Ditto.

  • efl/jhbuildrc: Use WEBKITOUTPUTDIR when calculating the path.
  • gtk/jhbuildrc: Ditto.
  • jhbuild/jhbuild-wrapper: Ditto.
8:20 PM Changeset in webkit [115531] by kbr@google.com
  • 5 edits in trunk

Remove SHADER_COMPILER constant
https://bugs.webkit.org/show_bug.cgi?id=85115

Reviewed by Darin Adler.

Source/WebCore:

Removed constant which was previously removed from spec. Updated
layout test and expected results.

  • html/canvas/WebGLRenderingContext.idl:

LayoutTests:

  • fast/canvas/webgl/constants-expected.txt: Updated expected results.
  • fast/canvas/webgl/constants.html: Synced test with Khronos repository.
8:12 PM Changeset in webkit [115530] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Fixed background is scrolling in http://www.nieuwecode.nl
https://bugs.webkit.org/show_bug.cgi?id=85109

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-04-27
Reviewed by Antonio Gomes.

Since the BlackBerry port uses very similar fixed position acceleration
as the Qt WebKit2 port, the same fix that worked for them in bug 83980
works for us.

Fixed by opting in to the FIXED_POSITION_CREATES_STACKING_CONTEXT
mechanism.

Covered by existing manual test fixed-position-no-z-index.html.

  • css/StyleResolver.cpp:
7:55 PM Changeset in webkit [115529] by enne@google.com
  • 4 edits
    1 add in trunk/Source/WebKit/chromium

[chromium] Allow WebMediaPlayerClientImpl to switch clients
https://bugs.webkit.org/show_bug.cgi?id=85093

Reviewed by James Robinson.

WebVideoFrameProviderClient has a 1:1 relationship with a
WebVideoFrameProvider. The client here is CCVideoLayerImpl and the
provider is WebMediaPlayerClientImpl. If the provider gets a new
client, then the old client needs to be informed to stop using the
provider.

If this doesn't happen, then the old client will have an unsafe
pointer to the provider, will not get informed if the provider gets
deleted, and the client will crash when it dereferences the provider
pointer trying to tell the provider that its client is going away.

Test: WebMediaPlayerClientImplTest.InitialNullVideoClient

WebMediaPlayerClientImplTest.SetAndUnsetVideoClient
WebMediaPlayerClientImplTest.DestroyProvider
WebMediaPlayerClientImplTest.SetMultipleVideoClients

  • WebKit.gypi:
  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::setVideoFrameProviderClient):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

  • tests/WebMediaPlayerClientImplTest.cpp: Added.

(WebKit):
(FakeWebMediaPlayerClientImpl):
(WebKit::FakeWebMediaPlayerClientImpl::create):
(WebKit::FakeWebMediaPlayerClientImpl::FakeWebMediaPlayerClientImpl):
(FakeVideoFrameProviderClient):
(WebKit::FakeVideoFrameProviderClient::create):
(WebKit::FakeVideoFrameProviderClient::~FakeVideoFrameProviderClient):
(WebKit::FakeVideoFrameProviderClient::didReceiveFrame):
(WebKit::FakeVideoFrameProviderClient::didUpdateMatrix):
(WebKit::FakeVideoFrameProviderClient::stopUsingProvider):
(WebKit::FakeVideoFrameProviderClient::provider):
(WebKit::FakeVideoFrameProviderClient::FakeVideoFrameProviderClient):
(WebKit::TEST):

7:43 PM Changeset in webkit [115528] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Double tap zooming does nothing on table element on bustedtees.com
https://bugs.webkit.org/show_bug.cgi?id=85104

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-04-27
Reviewed by George Staikos.

PR: 147006
This was caused by the incorrect fix master_33/SHA:612caec4.
Calculations like this "originalArea / pageArea" would always return 0
so that the incorrect node and blockRect were used by block zoom. This
patch takes care of it.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
(BlackBerry::WebKit::WebPage::blockZoom):

7:29 PM Changeset in webkit [115527] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Fix compiler warning in CCSchedulerTest.cpp with gcc 4.6.3
https://bugs.webkit.org/show_bug.cgi?id=85110

Reviewed by James Robinson.

Using gcc 4.6.3 (default on Precise), I get:
third_party/WebKit/Source/WebKit/chromium/tests/CCSchedulerTest.cpp:188:5: error: converting 'false' to pointer type
for argument 1 of 'char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)' [-Werror=conversion-null]

  • tests/CCSchedulerTest.cpp:

(WebKitTests::TEST):

7:16 PM Changeset in webkit [115526] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

fast/forms/listbox-clear-restore.html is failing
https://bugs.webkit.org/show_bug.cgi?id=82818

Patch by Joe Thomas <joethomas@motorola.com> on 2012-04-27
Reviewed by Darin Adler.

This testcase was flaky on the bot and from the screenshots it looks like the timer failed to fire.
Using document.body.offsetWidth to force a layout instead of timer.

  • fast/forms/listbox-clear-restore.html:
  • platform/mac/Skipped:
6:28 PM Changeset in webkit [115525] by nduca@chromium.org
  • 18 edits in trunk/Source

Expose high-resolution on requestAnimationFrame callback
https://bugs.webkit.org/show_bug.cgi?id=66683

This changes requestAnimationFrame's animationStartTime argument
to be a high resolution DOM timestamp, per disucssion here:
http://lists.w3.org/Archives/Public/public-web-perf/2012Apr/0004.html

Reviewed by James Robinson.

Source/WebCore:

Covered by existing requestAnimationFrame tests.

  • dom/Document.cpp:

(WebCore::Document::serviceScriptedAnimations):

  • dom/Document.h:

(Document):

  • dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::ScriptedAnimationController):
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
(WebCore):
(WebCore::ScriptedAnimationController::windowScreenDidChange):
(WebCore::ScriptedAnimationController::scheduleAnimation):
(WebCore::ScriptedAnimationController::animationTimerFired):
(WebCore::ScriptedAnimationController::displayRefreshFired):

  • dom/ScriptedAnimationController.h:

(ScriptedAnimationController):

  • page/FrameView.cpp:

(WebCore::FrameView::serviceScriptedAnimations):

  • page/FrameView.h:

(FrameView):

  • platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitor::DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::notifyClients):

  • platform/graphics/DisplayRefreshMonitor.h:

(DisplayRefreshMonitor):

  • platform/graphics/blackberry/DisplayRefreshMonitorBlackBerry.cpp:

(WebCore::DisplayRefreshMonitor::displayLinkFired):

  • platform/graphics/mac/DisplayRefreshMonitorMac.cpp:

(WebCore):
(WebCore::DisplayRefreshMonitor::requestRefreshCallback):
(WebCore::DisplayRefreshMonitor::displayLinkFired):

Source/WebKit/chromium:

  • src/PageWidgetDelegate.cpp:

(WebKit::PageWidgetDelegate::animate):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::updateAnimations):

6:26 PM Changeset in webkit [115524] by scherkus@chromium.org
  • 16 edits in trunk/LayoutTests

[Chromium] Unreviewed, updating baselines for media/video-colorspace-yuv420/422.html due to r115510.

  • platform/chromium-linux/media/video-colorspace-yuv420-expected.png:
  • platform/chromium-linux/media/video-colorspace-yuv422-expected.png:
  • platform/chromium-mac-leopard/media/video-colorspace-yuv420-expected.png:
  • platform/chromium-mac-leopard/media/video-colorspace-yuv422-expected.png:
  • platform/chromium-mac-snowleopard/media/video-colorspace-yuv420-expected.png:
  • platform/chromium-mac-snowleopard/media/video-colorspace-yuv422-expected.png:
  • platform/chromium-mac/media/video-colorspace-yuv420-expected.png:
  • platform/chromium-mac/media/video-colorspace-yuv420-expected.txt:
  • platform/chromium-mac/media/video-colorspace-yuv422-expected.png:
  • platform/chromium-mac/media/video-colorspace-yuv422-expected.txt:
  • platform/chromium-win/media/video-colorspace-yuv420-expected.png:
  • platform/chromium-win/media/video-colorspace-yuv420-expected.txt:
  • platform/chromium-win/media/video-colorspace-yuv422-expected.png:
  • platform/chromium-win/media/video-colorspace-yuv422-expected.txt:
  • platform/chromium/test_expectations.txt:
6:02 PM Changeset in webkit [115523] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

<rdar://problem/7909395> Math in JavaScript is inaccurate on iOS

By defalut IEEE754 denormal support is disabled on iOS;
turn it on.

Reviewed by Filip Pizlo.

  • jsc.cpp:

(main):

  • clear the appropriate bit in the fpscr.
6:00 PM Changeset in webkit [115522] by haraken@chromium.org
  • 18 edits in trunk/Source/WebCore

[V8] Implement a helper method V8Proxy::throwNotEnoughArgumentsError()
https://bugs.webkit.org/show_bug.cgi?id=85097

Reviewed by Kenneth Russell.

In bug 84787, kbr requested to avoid hard-coding
throwError("Not enough arguments", V8Proxy::TypeError) here and there.
This patch implements V8Proxy::throwNotEnoughArgumentsError()
and uses it in V8 bindings.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateArgumentsCountCheck):
(GenerateEventConstructorCallback):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::throwNotEnoughArgmentsError):
(WebCore):

  • bindings/v8/V8Proxy.h:

(V8Proxy):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::getInt8Callback):
(WebCore::V8DataView::getUint8Callback):
(WebCore::V8DataView::setInt8Callback):
(WebCore::V8DataView::setUint8Callback):

  • bindings/v8/custom/V8DirectoryEntryCustom.cpp:

(WebCore::V8DirectoryEntry::getDirectoryCallback):
(WebCore::V8DirectoryEntry::getFileCallback):

  • bindings/v8/custom/V8IntentConstructor.cpp:

(WebCore::V8Intent::constructorCallback):

  • bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:

(WebCore::V8WebKitMutationObserver::constructorCallback):
(WebCore::V8WebKitMutationObserver::observeCallback):

Test: bindings/scripts/test/TestObj.idl

  • bindings/scripts/CodeGeneratorV8.pm: Modified as described above.

(GenerateArgumentsCountCheck):
(GenerateEventConstructorCallback):

  • bindings/v8/V8Proxy.cpp: Ditto.

(WebCore::V8Proxy::throwNotEnoughArgumentsError):
(WebCore):

  • bindings/v8/V8Proxy.h:

(V8Proxy):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::getInt8Callback):
(WebCore::V8DataView::getUint8Callback):
(WebCore::V8DataView::setInt8Callback):
(WebCore::V8DataView::setUint8Callback):

  • bindings/v8/custom/V8DirectoryEntryCustom.cpp:

(WebCore::V8DirectoryEntry::getDirectoryCallback):
(WebCore::V8DirectoryEntry::getFileCallback):

  • bindings/v8/custom/V8IntentConstructor.cpp:

(WebCore::V8Intent::constructorCallback):

  • bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:

(WebCore::V8WebKitMutationObserver::constructorCallback):
(WebCore::V8WebKitMutationObserver::observeCallback):

  • bindings/scripts/test/V8/V8Float64Array.cpp: Updated run-bindings-tests.

(WebCore::Float64ArrayV8Internal::fooCallback):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionCallback):
(WebCore::TestActiveDOMObjectV8Internal::postMessageCallback):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::TestCustomNamedGetterV8Internal::anotherFunctionCallback):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::constructorCallback):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::itemCallback):
(WebCore::TestEventTargetV8Internal::dispatchEventCallback):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
(WebCore::V8TestInterface::constructorCallback):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::TestMediaQueryListListenerV8Internal::methodCallback):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::voidMethodWithArgsCallback):
(WebCore::TestObjV8Internal::intMethodWithArgsCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodWithSequenceArgCallback):
(WebCore::TestObjV8Internal::methodReturningSequenceCallback):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::serializedValueCallback):
(WebCore::TestObjV8Internal::idbKeyCallback):
(WebCore::TestObjV8Internal::optionsObjectCallback):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndOptionalArgCallback):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
(WebCore::TestObjV8Internal::methodWithCallbackArgCallback):
(WebCore::TestObjV8Internal::methodWithNonCallbackArgAndCallbackArgCallback):
(WebCore::TestObjV8Internal::overloadedMethod1Callback):
(WebCore::TestObjV8Internal::overloadedMethod2Callback):
(WebCore::TestObjV8Internal::overloadedMethod3Callback):
(WebCore::TestObjV8Internal::overloadedMethod4Callback):
(WebCore::TestObjV8Internal::overloadedMethod5Callback):
(WebCore::TestObjV8Internal::overloadedMethod6Callback):
(WebCore::TestObjV8Internal::overloadedMethod7Callback):
(WebCore::TestObjV8Internal::overloadedMethod11Callback):
(WebCore::TestObjV8Internal::overloadedMethod12Callback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod1Callback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod2Callback):
(WebCore::TestObjV8Internal::convert1Callback):
(WebCore::TestObjV8Internal::convert2Callback):
(WebCore::TestObjV8Internal::convert3Callback):
(WebCore::TestObjV8Internal::convert4Callback):
(WebCore::TestObjV8Internal::convert5Callback):
(WebCore::TestObjV8Internal::strictFunctionCallback):
(WebCore::V8TestObj::constructorCallback):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::TestSerializedScriptValueInterfaceV8Internal::acceptTransferListCallback):
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):

5:34 PM Changeset in webkit [115521] by pilgrim@chromium.org
  • 8 edits in trunk/Source

[Chromium] Call lowMemoryUsageMB directly
https://bugs.webkit.org/show_bug.cgi?id=84840

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

  • bindings/v8/V8GCController.cpp:

(WebCore::V8GCController::checkMemoryUsage):

  • platform/MemoryUsageSupport.cpp:

(WebCore::MemoryUsageSupport::lowMemoryUsageMB):
(WebCore):

  • platform/MemoryUsageSupport.h:

(MemoryUsageSupport):

  • platform/chromium/MemoryUsageSupportChromium.cpp:

(WebCore::MemoryUsageSupport::lowMemoryUsageMB):
(WebCore):

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore):

5:10 PM Changeset in webkit [115520] by yi.4.shen@nokia.com
  • 5 edits in trunk

REGRESSION(113723): Pressing enter in this list example deletes the whole list
https://bugs.webkit.org/show_bug.cgi?id=85016

Reviewed by Enrica Casucci.

The bug was caused by CompositeEditCommand::breakOutOfEmptyListItem, which calls isListItem
on the empty list's siblings to decide which part of the list should get removed. However,
the check fails when the empty list's sibling is a text node, or a list element (e.g. ul, ol).
Fixed it by skipping empty list's non-element sibling and calling isListElement to do further
check.

Source/WebCore:

Test: added new test cases in the existing test (break-out-of-empty-list-item.html)

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::breakOutOfEmptyListItem):

LayoutTests:

  • editing/execCommand/break-out-of-empty-list-item-expected.txt:
  • editing/execCommand/script-tests/break-out-of-empty-list-item.js:
5:07 PM Changeset in webkit [115519] by commit-queue@webkit.org
  • 12 edits in trunk/Source

[chromium] Add pause and resume support for accelerated css animations.
https://bugs.webkit.org/show_bug.cgi?id=84601

Patch by Ian Vollick <vollick@chromium.org> on 2012-04-27
Reviewed by James Robinson.

Source/WebCore:

Tested in:
CCLayerAnimationControllerTest.syncPauseResume
CCActiveAnimationTest.TrimTimeTimeOffset
CCActiveAnimationTest.TrimTimeSuspendResume
CCActiveAnimationTest.IsFinishedNeedsSynchronizedStartTime
CCActiveAnimationTest.RunStateChangesIgnoredWhileSuspended

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::suspendAnimations):
(WebCore::GraphicsLayerChromium::resumeAnimations):

  • platform/graphics/chromium/GraphicsLayerChromium.h:

(GraphicsLayerChromium):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::suspendAnimations):
(WebCore::LayerChromium::resumeAnimations):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):

  • platform/graphics/chromium/cc/CCActiveAnimation.cpp:

(WebCore::CCActiveAnimation::CCActiveAnimation):
(WebCore::CCActiveAnimation::setRunState):
(WebCore::CCActiveAnimation::suspend):
(WebCore::CCActiveAnimation::resume):
(WebCore::CCActiveAnimation::isFinishedAt):
(WebCore::CCActiveAnimation::trimTimeToCurrentIteration):
(WebCore::CCActiveAnimation::cloneForImplThread):
(WebCore::CCActiveAnimation::pushPropertiesTo):

  • platform/graphics/chromium/cc/CCActiveAnimation.h:

(CCActiveAnimation):
(WebCore::CCActiveAnimation::setStartTime):
(WebCore::CCActiveAnimation::timeOffset):
(WebCore::CCActiveAnimation::setTimeOffset):
(WebCore::CCActiveAnimation::isFinished):

  • platform/graphics/chromium/cc/CCLayerAnimationController.cpp:

(WebCore::CCLayerAnimationController::addAnimation):
(WebCore::CCLayerAnimationController::pauseAnimation):
(WebCore::CCLayerAnimationController::suspendAnimations):
(WebCore::CCLayerAnimationController::resumeAnimations):
(WebCore::CCLayerAnimationController::pushAnimationUpdatesTo):
(WebCore::CCLayerAnimationController::getActiveAnimation):
(WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):
(WebCore::CCLayerAnimationController::removeAnimationsCompletedOnMainThread):
(WebCore::CCLayerAnimationController::pushPropertiesToImplThread):
(WebCore):
(WebCore::CCLayerAnimationController::tickAnimations):

  • platform/graphics/chromium/cc/CCLayerAnimationController.h:

(CCLayerAnimationController):

Source/WebKit/chromium:

  • tests/CCActiveAnimationTest.cpp:

(WebCore::TEST):
(WebCore):

  • tests/CCLayerAnimationControllerTest.cpp:

(WebKitTests::TEST):
(WebKitTests):

5:04 PM Changeset in webkit [115518] by timothy_horton@apple.com
  • 40 edits
    10 adds in trunk

SMIL animation causes leak of the related Document (and many elements)
https://bugs.webkit.org/show_bug.cgi?id=83856
<rdar://problem/11216047>

Reviewed by Dean Jackson.

The SVGAnimatedProperty cache was previously holding a reference to the properties it contained;
said references were cleared in the SVGAnimatedProperty destructor (which was never called because
there was always one remaining reference from the cache).

The SVGAnimatedProperty cache now holds raw pointers instead of RefPtrs; the SVGAnimateElement now
owns its own SVGAnimatedProperties, both for itself and for any <use/> instances of itself. They're
cleared and destroyed within SVGAnimateElement::targetElementWillChange, at which time they're removed
from the cache.

SVGPropertyTearOffs now keep a reference to their SVGElement (m_contextElement) instead of their SVGAnimatedProperty;
this way, there is no reference cycle, but the animated property (owned by the element) and the element itself are
kept alive until the TearOff is garbage collected.

Add a few tests for different parts of this patch: smil-leak-elements tests that animated
elements are garbage collected properly after being removed from the page;

smil-leak-element-instances and its related smil-leak-element-instances-noBaseValRef test
that we don't leak instances after they're removed from the document while the original element is still alive;

smil-leak-dynamically-added-element-instances tests the same thing, but adds half of the instances
while the animation is in the middle of running;

svglength-element-removed-crash ensures that an animated element is not freed
if JavaScript code is holding a reference to an animated property wrapper.

File lists left off because they're very long.

4:56 PM Changeset in webkit [115517] by adamk@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove misspelled, unused, unimplemented method from V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=85091

Reviewed by Dimitri Glazkov.

  • bindings/v8/V8Proxy.h:

(V8Proxy):

4:51 PM Changeset in webkit [115516] by msaboff@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Memory wasted in JSString for non-rope strings
https://bugs.webkit.org/show_bug.cgi?id=84907

Reviewed by Geoffrey Garen.

Split JSString into two classes, JSString as a base class that does not
include the fibers of a Rope, and a subclass JSRopeString that has the
rope functionality. Both classes "share" the same ClassInfo. Added
a bool to JSString to indicate that the string was allocated as a JSRopeString
to properly handle visiting the fiber children when the rope is resolved and
the JSRopeString appears as a JSString. Didn't change the interface of JSString
to require any JIT changes.

As part of this change, removed "cellSize" from ClassInfo since both classes
share the same ClassInfo, but have different sizes. The only use I could find
for cellSize was an ASSERT in allocateCell().

This appears to be neutral on performance tests.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Changed JSString::resolveRope

to JSRopeString::resolveRope

  • runtime/ClassInfo.h:

(JSC):
(ClassInfo):

  • runtime/JSCell.h:

(JSC::allocateCell):

  • runtime/JSString.cpp:

(JSC::JSRopeString::RopeBuilder::expand):
(JSC::JSString::visitChildren):
(JSC):
(JSC::JSRopeString::visitFibers):
(JSC::JSRopeString::resolveRope):
(JSC::JSRopeString::resolveRopeSlowCase8):
(JSC::JSRopeString::resolveRopeSlowCase):
(JSC::JSRopeString::outOfMemory):
(JSC::JSRopeString::getIndexSlowCase):

  • runtime/JSString.h:

(JSC):
(JSString):
(JSC::JSString::finishCreation):
(JSC::JSString::create):
(JSC::JSString::isRope):
(JSC::JSString::is8Bit):
(JSRopeString):
(RopeBuilder):
(JSC::JSRopeString::RopeBuilder::RopeBuilder):
(JSC::JSRopeString::RopeBuilder::append):
(JSC::JSRopeString::RopeBuilder::release):
(JSC::JSRopeString::RopeBuilder::length):
(JSC::JSRopeString::JSRopeString):
(JSC::JSRopeString::finishCreation):
(JSC::JSRopeString::createNull):
(JSC::JSRopeString::create):
(JSC::JSString::value):
(JSC::JSString::tryGetValue):
(JSC::JSString::getIndex):
(JSC::jsStringBuilder):

  • runtime/Operations.h:

(JSC::jsString):
(JSC::jsStringFromArguments):

4:48 PM Changeset in webkit [115515] by yael.aharon@nokia.com
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] Don't call syncRemoteContents from WebLayerTreeRenderer::paintToCurrentGLContext
https://bugs.webkit.org/show_bug.cgi?id=85088

Reviewed by Noam Rosenthal.

Remove the call to syncRemoteContents from WebLayerTreeRenderer::paintToCurrentGLContext,
since it was moved to QQuickWebPage::updatePaintNode.
To make sure that we always sync before painting, this patch also calls page->update()
when the viewport changes.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewFlickablePrivate::_q_contentViewportChanged):

  • UIProcess/WebLayerTreeRenderer.cpp:

(WebKit::WebLayerTreeRenderer::paintToCurrentGLContext):

4:31 PM Changeset in webkit [115514] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Mark tables/mozilla/other/slashlogo.html as SLOW
https://bugs.webkit.org/show_bug.cgi?id=85106

  • platform/chromium/test_expectations.txt:
4:27 PM Changeset in webkit [115513] by jpfau@apple.com
  • 3 edits
    3 adds in trunk

Disable RTF in JavaScript drag-and-drop
https://bugs.webkit.org/show_bug.cgi?id=76597

Reviewed by Maciej Stachowiak.

Source/WebCore:

Test: fast/events/drag-and-drop-subframe-dataTransfer.html

  • platform/mac/ClipboardMac.mm:

(WebCore::cocoaTypeFromHTMLClipboardType):

LayoutTests:

  • fast/events/drag-and-drop-subframe-dataTransfer-expected.txt: Added.
  • fast/events/drag-and-drop-subframe-dataTransfer.html: Added.
  • fast/events/resources/file-for-drag-and-drop-subframe-dataTransfer.html: Added.
4:26 PM Changeset in webkit [115512] by fpizlo@apple.com
  • 76 edits
    4 adds in branches/dfgopt/Source

DFG should have control flow graph simplification
https://bugs.webkit.org/show_bug.cgi?id=84553

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

This change gives the DFG the ability to simplify the control flow graph
as part of an optimization fixpoint that includes CSE, CFA, and constant
folding. This required a number of interesting changes including:

  • Solidifying the set of invariants that the DFG obeys. For example, the head and tail of each basic block must advertise the set of live locals and the set of available locals, respectively. It must do so by referring to the first access to the local in the block (for head) and the last one (for tail). This patch introduces the start of a validation step that may be turned on even with asserts disabled. To ensure that these invariants are preserved, I had to remove the redundant phi elimination phase. For now I just remove the call, but in the future we will probably remove it entirely unless we find a use for it.


  • Making it easier to get the boolean version of a JSValue. This is a pure operation, but we previously did not treat it as such.


  • Fixing the merging and filtering of AbstractValues that correspond to concrete JSValues. This was previously broken and was limiting the effect of running constant folding. Fixing this meant that I had to change how constant folding eliminates GetLocal nodes, so as to ensure that the resulting graph still obeys DFG rules.


  • Introducing simplified getters for some of the things that DFG phases want to know about, like the Nth child of a node (now just graph.child(...) if you don't care about performance too much) or getting successors of a basic block.


The current CFG simplifier can handle almost all of the cases that it
ought to handle; the noteworthy one that is not yet handled is removing
basic blocks that just have jumps. To do this right we need to be able
to remove jump-only blocks that also perform keep-alive on some values.
To make this work, we need to be able to hoist the keep-alive into (or
just above) a Branch. This is not fundamentally difficult but I opted to
let this patch omit this optimization. We can handle this later.

This is a big win on programs that include inline functions that are
often called with constant arguments. Of course, SunSpider, V8, and
Kraken don't count. Those benchmarks are completely neutral with this
change.

  • API/JSValueRef.cpp:

(JSValueToBoolean):

(JSC::CodeBlock::dfgOSREntryDataForBytecodeIndex):

  • bytecode/Operands.h:

(JSC::Operands::setOperandFirstTime):
(Operands):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::mergeStateAtTail):
(JSC::DFG::AbstractState::mergeToSuccessors):

  • dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::isClear):
(JSC::DFG::AbstractValue::operator!=):
(JSC::DFG::AbstractValue::merge):
(JSC::DFG::AbstractValue::filter):
(JSC::DFG::AbstractValue::validateIgnoringValue):
(AbstractValue):

  • dfg/DFGAdjacencyList.h:

(JSC::DFG::AdjacencyList::child):
(JSC::DFG::AdjacencyList::setChild):
(AdjacencyList):

  • dfg/DFGBasicBlock.h:

(JSC::DFG::BasicBlock::~BasicBlock):
(BasicBlock):
(JSC::DFG::BasicBlock::numNodes):
(JSC::DFG::BasicBlock::nodeIndex):
(JSC::DFG::BasicBlock::isPhiIndex):
(JSC::DFG::BasicBlock::isInPhis):
(JSC::DFG::BasicBlock::isInBlock):

  • dfg/DFGByteCodeParser.cpp:

(ByteCodeParser):
(DFG):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGCFAPhase.cpp:

(JSC::DFG::CFAPhase::run):
(JSC::DFG::CFAPhase::performBlockCFA):
(JSC::DFG::performCFA):

  • dfg/DFGCFAPhase.h:

(DFG):

  • dfg/DFGCFGSimplificationPhase.cpp: Added.

(DFG):
(CFGSimplificationPhase):
(JSC::DFG::CFGSimplificationPhase::CFGSimplificationPhase):
(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::killUnreachable):
(JSC::DFG::CFGSimplificationPhase::findOperandSource):
(JSC::DFG::CFGSimplificationPhase::keepOperandAlive):
(JSC::DFG::CFGSimplificationPhase::fixPossibleGetLocal):
(JSC::DFG::CFGSimplificationPhase::jettisonBlock):
(JSC::DFG::CFGSimplificationPhase::fixPhis):
(JSC::DFG::CFGSimplificationPhase::fixJettisonedPredecessors):
(JSC::DFG::CFGSimplificationPhase::removePotentiallyDeadPhiReference):
(JSC::DFG::CFGSimplificationPhase::OperandSubstitution::OperandSubstitution):
(OperandSubstitution):
(JSC::DFG::CFGSimplificationPhase::OperandSubstitution::dump):
(JSC::DFG::CFGSimplificationPhase::skipGetLocal):
(JSC::DFG::CFGSimplificationPhase::fixTailOperand):
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):
(JSC::DFG::performCFGSimplification):

  • dfg/DFGCFGSimplificationPhase.h: Added.

(DFG):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::run):
(CSEPhase):
(JSC::DFG::CSEPhase::impureCSE):
(JSC::DFG::CSEPhase::globalVarLoadElimination):
(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::checkStructureLoadElimination):
(JSC::DFG::CSEPhase::getByOffsetLoadElimination):
(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
(JSC::DFG::CSEPhase::performBlockCSE):
(JSC::DFG::performCSE):

  • dfg/DFGCSEPhase.h:

(DFG):

  • dfg/DFGCommon.h:
  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::run):
(JSC::DFG::performConstantFolding):

  • dfg/DFGConstantFoldingPhase.h:

(DFG):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGEdge.h:

(Edge):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::run):
(JSC::DFG::FixupPhase::fixupBlock):
(JSC::DFG::performFixup):

  • dfg/DFGFixupPhase.h:

(DFG):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::handleSuccessor):
(DFG):
(JSC::DFG::Graph::determineReachability):
(JSC::DFG::Graph::resetReachability):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::deref):
(JSC::DFG::Graph::changeIndex):
(Graph):
(JSC::DFG::Graph::changeEdge):
(JSC::DFG::Graph::numSuccessors):
(JSC::DFG::Graph::successor):
(JSC::DFG::Graph::successorForCondition):
(JSC::DFG::Graph::isPredictedNumerical):
(JSC::DFG::Graph::byValIsPure):
(JSC::DFG::Graph::clobbersWorld):
(JSC::DFG::Graph::numChildren):
(JSC::DFG::Graph::child):

  • dfg/DFGNode.h:

(JSC::DFG::Node::convertToConstant):
(JSC::DFG::Node::numSuccessors):
(Node):
(JSC::DFG::Node::successor):
(JSC::DFG::Node::successorForCondition):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

  • dfg/DFGOperations.cpp:
  • dfg/DFGPhase.cpp:

(JSC::DFG::Phase::endPhase):

  • dfg/DFGPhase.h:

(JSC::DFG::runPhase):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::run):
(JSC::DFG::performPredictionPropagation):

  • dfg/DFGPredictionPropagationPhase.h:

(DFG):

  • dfg/DFGRedundantPhiEliminationPhase.cpp:

(JSC::DFG::RedundantPhiEliminationPhase::run):
(JSC::DFG::performRedundantPhiElimination):

  • dfg/DFGRedundantPhiEliminationPhase.h:

(DFG):

  • dfg/DFGScoreBoard.h:

(JSC::DFG::ScoreBoard::use):
(ScoreBoard):
(JSC::DFG::ScoreBoard::useIfHasResult):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::createOSREntries):
(JSC::DFG::SpeculativeJIT::linkOSREntries):
(JSC::DFG::SpeculativeJIT::compileStrictEqForConstant):
(JSC::DFG::SpeculativeJIT::compileRegExpExec):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::nextBlock):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::use):
(JSC::DFG::SpeculativeJIT::jump):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGValidate.cpp: Added.

(DFG):
(Validate):
(JSC::DFG::Validate::Validate):
(JSC::DFG::Validate::validate):
(JSC::DFG::Validate::reportValidationContext):
(JSC::DFG::Validate::dumpData):
(JSC::DFG::Validate::dumpGraphIfAppropriate):
(JSC::DFG::validate):

  • dfg/DFGValidate.h: Added.

(DFG):
(JSC::DFG::validate):

  • dfg/DFGVirtualRegisterAllocationPhase.cpp:

(JSC::DFG::VirtualRegisterAllocationPhase::run):
(JSC::DFG::performVirtualRegisterAllocation):

  • dfg/DFGVirtualRegisterAllocationPhase.h:

(DFG):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncSome):

  • runtime/BooleanConstructor.cpp:

(JSC::constructBoolean):
(JSC::callBooleanConstructor):

  • runtime/JSCell.h:

(JSCell):

  • runtime/JSObject.cpp:

(JSC):

  • runtime/JSObject.h:
  • runtime/JSString.cpp:

(JSC::JSString::toBoolean):

  • runtime/JSString.h:

(JSString):
(JSC::JSCell::toBoolean):
(JSC::JSValue::toBoolean):

  • runtime/JSValue.h:
  • runtime/ObjectConstructor.cpp:

(JSC::toPropertyDescriptor):

  • runtime/RegExpConstructor.cpp:

(JSC::setRegExpConstructorMultiline):

  • runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncToString):

Source/WebCore:

Reviewed by Oliver Hunt.

JSValue::toBoolean(ExecState*) -> JSValue::toBoolean()

No new tests, because no new behavior.

  • bindings/js/JSCustomSQLStatementErrorCallback.cpp:

(WebCore::JSSQLStatementErrorCallback::handleEvent):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener):

  • bindings/js/JSDataViewCustom.cpp:

(WebCore::getDataViewMember):

  • bindings/js/JSDeviceMotionEventCustom.cpp:

(WebCore::JSDeviceMotionEvent::initDeviceMotionEvent):

  • bindings/js/JSDeviceOrientationEventCustom.cpp:

(WebCore::JSDeviceOrientationEvent::initDeviceOrientationEvent):

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue):

  • bindings/js/JSDirectoryEntryCustom.cpp:

(WebCore::JSDirectoryEntry::getFile):
(WebCore::JSDirectoryEntry::getDirectory):

  • bindings/js/JSDirectoryEntrySyncCustom.cpp:

(WebCore::getFlags):

  • bindings/js/JSHTMLCanvasElementCustom.cpp:

(WebCore::JSHTMLCanvasElement::getContext):

  • bindings/js/JSInspectorFrontendHostCustom.cpp:

(WebCore::JSInspectorFrontendHost::showContextMenu):

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::handleInitMessageEvent):

  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::dataFunctionMatrix):

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::open):

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::hasBreakpoint):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateEventListenerCall):
(GenerateImplementation):
(JSValueToNative):

  • bridge/c/c_utility.cpp:

(JSC::Bindings::convertValueToNPVariant):

  • bridge/jni/jni_jsobject.mm:

(JavaJSObject::convertValueToJObject):

Source/WebKit/mac:

Reviewed by Oliver Hunt.

JSValue::toBoolean(ExecState*) -> JSValue::toBoolean()

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::addValueToArray):

Source/WebKit2:

Reviewed by Oliver Hunt.

JSValue::toBoolean(ExecState*) -> JSValue::toBoolean()

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant):

4:23 PM Changeset in webkit [115511] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] [DRT] Unskip passing tests related to editing commands
https://bugs.webkit.org/show_bug.cgi?id=84944

Unreviewed, unskip passing editing commands tests.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-27

  • platform/efl/Skipped:
4:18 PM Changeset in webkit [115510] by scherkus@chromium.org
  • 6 edits
    2 adds in trunk/LayoutTests

Support video format yuv422p tests on different ports.
https://bugs.webkit.org/show_bug.cgi?id=82281

Patch by Shadi Khalek <shadi@chromium.org>
Reviewed by Eric Carlson.

  • media/content/test_yuv420.mp4: Added.
  • media/content/test_yuv420.ogv:
  • media/content/test_yuv422.mp4: Added.
  • media/content/test_yuv422.ogv:
  • media/video-colorspace-yuv420.html:
  • media/video-colorspace-yuv422.html:
4:15 PM Changeset in webkit [115509] by jamesr@google.com
  • 18 edits
    6 copies in trunk/Source

[chromium] Separate IOSurface layer type from texture layers
https://bugs.webkit.org/show_bug.cgi?id=85030

Reviewed by Adrienne Walker.

Source/Platform:

Adds a new layer type for IOSurface backed layers, instead of sharing that functionality in
WebExternalTextureLayer. IOSurface backed layers do not share any other properties with external texture layers.

  • Platform.gypi:
  • chromium/public/WebExternalTextureLayer.h:

(WebExternalTextureLayer):

  • chromium/public/WebIOSurfaceLayer.h:

(WebCore):
(WebKit):
(WebIOSurfaceLayer):
(WebKit::WebIOSurfaceLayer::WebIOSurfaceLayer):
(WebKit::WebIOSurfaceLayer::~WebIOSurfaceLayer):

Source/WebCore:

Adds a new layer type for IOSurface layers and pipes through a separate path through to rendering. IOSurface
layers are very simple - they have an IOSurface id and size, nothing else. All IOSurface layers are "flipped" in
our terminology.

  • WebCore.gypi:
  • platform/graphics/chromium/IOSurfaceLayerChromium.cpp:

(WebCore):
(WebCore::IOSurfaceLayerChromium::create):
(WebCore::IOSurfaceLayerChromium::IOSurfaceLayerChromium):
(WebCore::IOSurfaceLayerChromium::~IOSurfaceLayerChromium):
(WebCore::IOSurfaceLayerChromium::setIOSurfaceProperties):
(WebCore::IOSurfaceLayerChromium::createCCLayerImpl):
(WebCore::IOSurfaceLayerChromium::drawsContent):
(WebCore::IOSurfaceLayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/IOSurfaceLayerChromium.h:

(WebCore):
(IOSurfaceLayerChromium):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawIOSurfaceQuad):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

  • platform/graphics/chromium/TextureLayerChromium.cpp:

(WebCore::TextureLayerChromium::TextureLayerChromium):
(WebCore::TextureLayerChromium::drawsContent):
(WebCore::TextureLayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/TextureLayerChromium.h:

(TextureLayerChromium):

  • platform/graphics/chromium/cc/CCIOSurfaceDrawQuad.cpp:

(WebCore::CCIOSurfaceDrawQuad::create):
(WebCore::CCIOSurfaceDrawQuad::CCIOSurfaceDrawQuad):

  • platform/graphics/chromium/cc/CCIOSurfaceDrawQuad.h:

(CCIOSurfaceDrawQuad):

  • platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:

(WebCore):
(WebCore::CCIOSurfaceLayerImpl::CCIOSurfaceLayerImpl):
(WebCore::CCIOSurfaceLayerImpl::~CCIOSurfaceLayerImpl):
(WebCore::CCIOSurfaceLayerImpl::willDraw):
(WebCore::CCIOSurfaceLayerImpl::appendQuads):
(WebCore::CCIOSurfaceLayerImpl::dumpLayerProperties):
(WebCore::CCIOSurfaceLayerImpl::didLoseContext):
(WebCore::CCIOSurfaceLayerImpl::setIOSurfaceProperties):

  • platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.h:

(WebCore):
(CCIOSurfaceLayerImpl):
(WebCore::CCIOSurfaceLayerImpl::create):

  • platform/graphics/chromium/cc/CCTextureLayerImpl.cpp:

(WebCore::CCTextureLayerImpl::CCTextureLayerImpl):
(WebCore::CCTextureLayerImpl::~CCTextureLayerImpl):
(WebCore::CCTextureLayerImpl::appendQuads):
(WebCore::CCTextureLayerImpl::didLoseContext):

  • platform/graphics/chromium/cc/CCTextureLayerImpl.h:

(CCTextureLayerImpl):

Source/WebKit/chromium:

Update WebPluginContainerImpl to support having either a texture or IOSurface layer (but never both) depending
on the plugin's contents.

  • WebKit.gyp:
  • src/WebExternalTextureLayer.cpp:
  • src/WebIOSurfaceLayer.cpp:

(WebKit):
(WebKit::WebIOSurfaceLayer::create):
(WebKit::WebIOSurfaceLayer::setIOSurfaceProperties):
(WebKit::WebIOSurfaceLayer::WebIOSurfaceLayer):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::setBackingTextureId):
(WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
(WebKit::WebPluginContainerImpl::commitBackingTexture):
(WebKit::WebPluginContainerImpl::setOpaque):
(WebKit::WebPluginContainerImpl::platformLayer):
(WebKit::WebPluginContainerImpl::WebPluginContainerImpl):

  • src/WebPluginContainerImpl.h:

(WebPluginContainerImpl):

4:13 PM Changeset in webkit [115508] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] fast/js/dfg-uint32array.html is a flaky timeout.
https://bugs.webkit.org/show_bug.cgi?id=85090

  • platform/chromium/test_expectations.txt: Added.
4:09 PM Changeset in webkit [115507] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

Mark svg/as-image/svg-as-relative-image-with-explicit-size.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=85107

  • platform/chromium/test_expectations.txt: Registered flakiness.
4:08 PM Changeset in webkit [115506] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[BlackBerry] OpenGL related bug fixes
https://bugs.webkit.org/show_bug.cgi?id=84836

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-04-27
Reviewed by Antonio Gomes.

PR147254, 148933, 149117, 149721, 150228

No new tests, covered by existing BlackBerry browser stress tests

  • platform/graphics/blackberry/CanvasLayerWebKitThread.cpp:

(WebCore::CanvasLayerWebKitThread::updateTextureContentsIfNeeded):

  • platform/graphics/blackberry/LayerCompositingThread.cpp:

(WebCore::LayerCompositingThread::drawTextures):

  • platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::~LayerRenderer):
(WebCore::LayerRenderer::drawLayers):
(WebCore::LayerRenderer::initializeSharedGLObjects):

4:06 PM Changeset in webkit [115505] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

Mark tables/mozilla/other/slashlogo.html as flaky timeout.
https://bugs.webkit.org/show_bug.cgi?id=85106

  • platform/chromium/test_expectations.txt: Marked.
4:06 PM UsingGitWithWebKit edited by jamesr@google.com
Change "path/to/resolve-ChangeLogs" to … (diff)
4:03 PM Changeset in webkit [115504] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Remove remaining mentions of platform/mac-leopard.

  • platform/chromium/test_expectations.txt: Removed.
3:36 PM LayoutTestsSearchPath edited by tony@chromium.org
(diff)
3:34 PM Changeset in webkit [115503] by nduca@chromium.org
  • 9 edits
    6 adds in trunk

Source/WebCore: Implement high-resolution time via window.performance.webkitNow()
https://bugs.webkit.org/show_bug.cgi?id=66684

This implements the high resolution time spec from
http://www.w3.org/TR/hr-time/, giving javascript access to
sub-millisecond timestamps that increase over time instead of being
subject to skewing, for example when the host machine's clock changes.

Reviewed by Tony Gentilcore.

Test: fast/performance/performance-now-timestamps.html

  • page/Performance.cpp:

(WebCore::Performance::now):
(WebCore):

  • page/Performance.h:

(Performance):

  • page/Performance.idl:

LayoutTests: Implement high-resolution time via window.performance.now()
https://bugs.webkit.org/show_bug.cgi?id=66684

This implements the high resolution time spec from
http://www.w3.org/TR/hr-time/, giving javascript access to
sub-millisecond timestamps that increase over time instead of being
subject to skewing, for example when the host machine's clock changes.

Reviewed by Tony Gentilcore.

  • fast/dom/Window/window-properties-performance-expected.txt:
  • fast/performance/performance-now-timestamps-expected.txt: Added.
  • fast/performance/performance-now-timestamps.html: Added.
  • fast/performance/script-tests/TEMPLATE.html: Added.
  • fast/performance/script-tests/performance-now-timestamps.js: Added.

(busyWait):

  • platform/qt/fast/dom/Window/window-properties-performance-expected.txt:
3:30 PM Changeset in webkit [115502] by tony@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

remove LayoutTests/platform/mac-leopard
https://bugs.webkit.org/show_bug.cgi?id=84999

These results are no longer used by any ports.

  • platform/mac-leopard: Removed.
3:14 PM Changeset in webkit [115501] by mrowe@apple.com
  • 17 edits in trunk

<rdar://problem/11339645> WebKit projects should explicitly ask for dSYM files in production builds

Rubber-stamped by Dan Bernstein.

3:11 PM Changeset in webkit [115500] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[chromium] make case of npTestNetscapePlugIn.dll match case in copy rule
https://bugs.webkit.org/show_bug.cgi?id=85083

Patch by Scott Graham <scottmg@chromium.org> on 2012-04-27
Reviewed by Dirk Pranke.

Make output product_name for npTestNetscapePlugIn.dll match the case
of the copy_TestNetscapePlugIn rule. This is required for ninja, which
is more particular about case matching in rules than the VS build.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3:02 PM Changeset in webkit [115499] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

[EFL] Several media layout tests need rebaselining
https://bugs.webkit.org/show_bug.cgi?id=84943

Unreviewed, rebaseline EFL media layout tests due to r114957.

Patch by Christophe Dumez <Christophe Dumez> on 2012-04-27

  • platform/efl/media/media-controls-clone-expected.txt:
  • platform/efl/media/video-empty-source-expected.txt:
  • platform/efl/media/video-zoom-controls-expected.txt:
2:55 PM Changeset in webkit [115498] by fpizlo@apple.com
  • 7 edits in trunk/Source/WebCore

If you get a list of DOMWrapperWorld*'s and then plan to allocate in the heap, you should ref
the DOMWrapperWorld*'s
https://bugs.webkit.org/show_bug.cgi?id=85098
<rdar://problem/11318170>

Reviewed by Sam Weinig.

No new tests because this addresses hard-to-repro flaky behavior arising from GCs at inconvenient
times.

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::getAllWorlds):

  • bindings/js/ScriptController.h:

(ScriptController):

  • bindings/js/WebCoreJSClientData.h:

(WebCore::WebCoreJSClientData::getAllWorlds):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::getAllWorlds):

  • bindings/v8/ScriptController.h:

(ScriptController):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::dispatchDidClearWindowObjectsInAllWorlds):
(WebCore::FrameLoader::dispatchGlobalObjectAvailableInAllWorlds):

2:47 PM Changeset in webkit [115497] by ggaren@apple.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

Fixed accidental ';' in ChangeLog

2:46 PM Changeset in webkit [115496] by ggaren@apple.com
  • 3 edits in trunk/Source/WebCore

;2012-04-27 Geoffrey Garen <ggaren@apple.com>

Removed the sole use of Weak<Unknown>
https://bugs.webkit.org/show_bug.cgi?id=85099

Reviewed by Sam Weinig.

The semantics and implementation of Weak<Unknown> are unclear because:

  • Should you call a finalizer for a non-GC thingy? If so, when?
  • Possible answer: No.
  • If WeakImpls for GC thingies live with the GC thingies in the heap, where do WeakImpls for non-GC thingies live?
  • Possible answer: Directly in the Weak<T>.

Since no clients actually want these behaviors, it's hard to tell if
they're the right behaviors, and it's not worth the implementation
complexity. If we come up with a client that wants these behaviors, we
can always revisit this.

  • bindings/js/JSNodeFilterCondition.cpp:

(WebCore::JSNodeFilterCondition::JSNodeFilterCondition): Just leave our
filter NULL if it's not an object -- that's a better way to indicate
"not a valid filter object".

(WebCore::JSNodeFilterCondition::acceptNode): Fixed up some naming to
clarify that the object we're working with is not necessarily a function.

  • bindings/js/JSNodeFilterCondition.h:

(JSNodeFilterCondition): Use Weak<JSObject>, since that more closely
matches what we're trying to do.

2:38 PM Changeset in webkit [115495] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[V8] Pass Isolate to getDOMXXXMap()
https://bugs.webkit.org/show_bug.cgi?id=85022

Reviewed by Nate Chapin.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to getDOMXXXMap().

Also this patch removes DOMMap::getDOMDataStore() and
DOMData::getDefalutStore(), since the indirection by the
methods is redundant. This is not for performance
optimization but just for refactoring.

No tests. No change in behavior.

  • bindings/v8/DOMData.cpp:

(WebCore::DOMData::getCurrentStore):

  • bindings/v8/DOMData.h:

(DOMData):

  • bindings/v8/V8DOMMap.cpp:

(WebCore::getDOMNodeMap):
(WebCore::getActiveDOMNodeMap):
(WebCore::getDOMObjectMap):
(WebCore::getActiveDOMObjectMap):
(WebCore::removeAllDOMObjects):

  • bindings/v8/V8DOMMap.h:

(WebCore):

2:36 PM Changeset in webkit [115494] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Pass Isolate to V8BindingPerIsolateData::current()
https://bugs.webkit.org/show_bug.cgi?id=85023

Reviewed by Nate Chapin.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to V8BindingPerIsolateData::current().

No tests. No change in behavior.

  • bindings/v8/V8Binding.h:

(WebCore::V8BindingPerIsolateData::current):
(WebCore::v8ExternalString):

2:16 PM Changeset in webkit [115493] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Correct assertion.

2:08 PM Changeset in webkit [115492] by enne@google.com
  • 2 edits in branches/chromium/1084/Source

Merge 114791 - [chromium] Clip TransparencyWin to prevent OOM from large Skia canvas
https://bugs.webkit.org/show_bug.cgi?id=84289

Reviewed by James Robinson.

Source/WebCore:

TransparencyWin will create a Skia canvas of whatever size is passed
in, even if the result will ultimately be clipped. Handle the clip
implicitly and try (in some cases) to create a smaller canvas. This
can happen due to RenderBox::paintBoxDecorations passing a paint rect
down of the entire element's size.

Modes with more complicated transforms (ScaleTransform, UnTransform)
are not handled yet.

Tests: TransparencyWin.ClippedKeepTransformNoLayer

TransparencyWin.ClippedKeepTransformOpaqueCompositeLayer
TransparencyWin.ClippedKeepTransformOpaqueWhiteLayer

  • platform/graphics/chromium/TransparencyWin.cpp:

(WebCore::TransparencyWin::computeLayerSize):

Source/WebKit/chromium:

Add a test that would OOM if the layer wasn't clipped. Also, verify
that clipping the canvas doesn't shift pixels around incorrectly.

  • tests/TransparencyWinTest.cpp:

(WebCore::testClippedLayerKeepTransform):
(WebCore):
(WebCore::TEST):

TBR=enne@google.com
Review URL: https://chromiumcodereview.appspot.com/10254020

2:07 PM Changeset in webkit [115491] by Dimitri Glazkov
  • 42 edits
    3 deletes in trunk

Unreviewed, rolling out r115484.
http://trac.webkit.org/changeset/115484
https://bugs.webkit.org/show_bug.cgi?id=84555

Broke Chromium compile.

Source/WebCore:

  • bindings/js/JSBlobCustom.cpp:
  • bindings/v8/custom/V8BlobCustom.cpp:
  • fileapi/Blob.cpp:
  • fileapi/Blob.h:

(Blob):

  • fileapi/Blob.idl:
  • workers/WorkerContext.idl:

LayoutTests:

  • fast/dom/HTMLAnchorElement/anchor-download-unset.html:
  • fast/dom/HTMLAnchorElement/anchor-download.html:
  • fast/dom/HTMLAnchorElement/anchor-nodownload-set.html:
  • fast/dom/HTMLAnchorElement/anchor-nodownload.html:
  • fast/dom/window-domurl-crash.html:
  • fast/files/blob-constructor-expected.txt: Removed.
  • fast/files/blob-constructor.html: Removed.
  • fast/files/blob-slice-overflow.html:
  • fast/files/blob-slice-test.html:
  • fast/files/file-reader-fffd.html:
  • fast/files/not-enough-arguments.html:
  • fast/files/resources/read-blob-test-cases.js:

(testReadingTripleSlicedHybridBlob):

  • fast/files/resources/read-common.js:

(buildBlob):

  • fast/files/script-tests/blob-constructor.js: Removed.
  • fast/files/workers/inline-worker-via-blob-url.html:
  • fast/filesystem/resources/file-writer-abort-continue.js:

(tenXBlob):
(startWrite):

  • fast/filesystem/resources/file-writer-abort-depth.js:
  • fast/filesystem/resources/file-writer-abort.js:

(tenXBlob):
(startWrite):

  • fast/filesystem/resources/file-writer-events.js:

(tenXBlob):
(startWrite):

  • fast/filesystem/resources/file-writer-gc-blob.js:

(tenXBlob):
(startWrite):

  • fast/filesystem/resources/file-writer-sync-truncate-extend.js:
  • fast/filesystem/resources/file-writer-sync-write-overlapped.js:
  • fast/filesystem/resources/file-writer-utils.js:
  • http/tests/fileapi/create-blob-url-from-data-url.html:
  • http/tests/filesystem/no-cache-filesystem-url.html:
  • http/tests/local/blob/resources/hybrid-blob-util.js:

(HybridBlobTestUtil.this.appendAndCreateBlob):
(HybridBlobTestUtil):

  • http/tests/security/resources/create-filesystem-file.html:
  • http/tests/websocket/tests/hixie76/send-object.html:
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html:
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close.html:
  • http/tests/websocket/tests/hybi/send-blob.html:
  • http/tests/websocket/tests/hybi/send-file-blob-fail.html:
  • http/tests/websocket/tests/hybi/send-file-blob.html:
  • http/tests/websocket/tests/hybi/workers/resources/send-blob.js:

(createBlobContainingHelloWorld):
(createEmptyBlob):
(createBlobContainingAllDistinctBytes):

  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • storage/indexeddb/noblobs.html:
  • storage/indexeddb/structured-clone.html:
2:03 PM Changeset in webkit [115490] by dpranke@chromium.org
  • 5 edits in trunk

[chromium] use "drt-style" output, not "test-shell-style" output, on mac and linux DRT
https://bugs.webkit.org/show_bug.cgi?id=84917

Unreviewed, build fix.

Tools:

Reland the change in r115453 with a fix for chromium win.
The logic in ChromiumDriver was busted on windows, causing DRT
to get launched without the --test-shell flag.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumDriver):
(ChromiumDriver.init):
(ChromiumDriver._wrapper_options):
(ChromiumDriver.cmd_line):
(ChromiumDriver._start):
(ChromiumDriver.has_crashed):
(ChromiumDriver.run_test):
(ChromiumDriver.stop):

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumDriverTest.setUp):
(ChromiumDriverTest.test_stop):
(ChromiumDriverTest.test_two_drivers.MockDriver.init):
(ChromiumDriverTest.test_two_drivers):

LayoutTests:

Reland the change in r115453 with a fix for chromium win.

  • platform/chromium/test_expectations.txt:
1:59 PM Changeset in webkit [115489] by peter@chromium.org
  • 2 edits in trunk/Tools

Add John Grabowski as a non-committer to committers.py
https://bugs.webkit.org/show_bug.cgi?id=85080

Reviewed by Dirk Pranke.

He's being CC'ed often enough because of his involvement in the Chromium
side of Chrome for Android upstreaming.

1:32 PM Changeset in webkit [115488] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=85038

Unreviewed, Mac test_expectations update.

  • platform/mac/test_expectations.txt: Skip http/tests/inspector/network/network-initiator.html.
1:30 PM Changeset in webkit [115487] by Alexandru Chiculita
  • 9 edits
    3 adds in trunk

[CSS Shaders] Implement CSS Animations and Transitions for CSS Shaders
https://bugs.webkit.org/show_bug.cgi?id=71406

Reviewed by Dean Jackson.

Source/WebCore:

I've implemented the blend function for the CustomFilterOperation. This should enable animations for CSS Shaders.
Currently, just floats are implemented. If any of the filter attributes like shader, mesh size or box mode are different,
the fallback is to use the "to" part of the animation instead. If other shader parameters do not match, it will merge the parameter values
between the "from" and "to" states.

Test: css3/filters/custom/custom-filter-animation.html

  • platform/graphics/filters/CustomFilterNumberParameter.h:

(WebCore::CustomFilterNumberParameter::blend):
(CustomFilterNumberParameter):
(WebCore::CustomFilterNumberParameter::operator==):

  • platform/graphics/filters/CustomFilterOperation.cpp:

(WebCore::equalCustomFilterParameters):
(WebCore):
(WebCore::checkCustomFilterParametersOrder):
(WebCore::blendCustomFilterParameters):
(WebCore::CustomFilterOperation::CustomFilterOperation):
(WebCore::CustomFilterOperation::blend):

  • platform/graphics/filters/CustomFilterOperation.h:

(WebCore):
(CustomFilterOperation):
(WebCore::CustomFilterOperation::operator==):
(WebCore::CustomFilterOperation::operator!=):

  • platform/graphics/filters/CustomFilterParameter.h:

(CustomFilterParameter):
(WebCore::CustomFilterParameter::isSameType):
(WebCore::CustomFilterParameter::operator==):
(WebCore::CustomFilterParameter::operator!=):

  • platform/graphics/filters/CustomFilterProgram.h:
  • rendering/style/StyleCustomFilterProgram.h:

(StyleCustomFilterProgram):
(WebCore::StyleCustomFilterProgram::cachedVertexShader):
(WebCore::StyleCustomFilterProgram::cachedFragmentShader):
(WebCore::StyleCustomFilterProgram::operator==):

LayoutTests:

  • animations/resources/animation-test-helpers.js: Added a check for the "custom" function and used the parser in custom-filter-parser.js instead.

(getFilterParameters):
(filterParametersMatch):

  • css3/filters/custom/custom-filter-animation-expected.txt: Added.
  • css3/filters/custom/custom-filter-animation.html: Added.
  • css3/filters/resources/custom-filter-parser.js: Added a simple parser for the "custom" function, so that multiple types can be checked correctly.
1:29 PM Changeset in webkit [115486] by hans@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

Speech JavaScript API: Fix Vector use failure
https://bugs.webkit.org/show_bug.cgi?id=85069

Reviewed by Tony Gentilcore.

Fix think-o in code copying from WebVector to Vector.

  • src/SpeechRecognitionClientProxy.cpp:

(WebKit::SpeechRecognitionClientProxy::didReceiveResult):
(WebKit::SpeechRecognitionClientProxy::didDeleteResult):

  • src/WebSpeechRecognitionResult.cpp:

(WebKit::WebSpeechRecognitionResult::assign):

1:27 PM Changeset in webkit [115485] by crogers@google.com
  • 6 edits
    2 adds in trunk/Source/WebCore

Re-factor scheduling logic from AudioBufferSourceNode into AudioScheduledSourceNode
https://bugs.webkit.org/show_bug.cgi?id=84639

Reviewed by Eric Carlson.

Playback logic involving noteOn(), noteOff(), and playbackState were intertwined with
the AudioBufferSourceNode's buffer playback code. These are more general concepts and
may be implemented separately in another class called AudioScheduledSourceNode.

No new tests. Covered by existing layout tests.

  • GNUmakefile.list.am:

Add AudioScheduledSourceNode files to makefile.

  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore):
(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
Re-factor some member variables into new base class AudioScheduledSourceNode.

(WebCore::AudioBufferSourceNode::process):
Re-factor scheduling logic into AudioScheduledSourceNode.

  • Modules/webaudio/AudioBufferSourceNode.h:

(AudioBufferSourceNode):
Simplify by re-factoring scheduling logic into AudioScheduledSourceNode.

  • Modules/webaudio/AudioScheduledSourceNode.cpp: Added.

(WebCore):
(WebCore::AudioScheduledSourceNode::AudioScheduledSourceNode):
(WebCore::AudioScheduledSourceNode::updateSchedulingInfo):
Get frame information for the current time quantum.

  • Modules/webaudio/AudioScheduledSourceNode.h: Added.

(WebCore::AudioScheduledSourceNode::noteOn):
(WebCore::AudioScheduledSourceNode::noteOff):
(WebCore::AudioScheduledSourceNode::finish):
(WebCore::AudioScheduledSourceNode::playbackState):
(WebCore::AudioScheduledSourceNode::isPlayingOrScheduled):
(WebCore::AudioScheduledSourceNode::hasFinished):
Re-factored from AudioBufferSourceNode.

  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:

Add AudioScheduledSourceNode files to makefiles.

1:23 PM Changeset in webkit [115484] by weinig@apple.com
  • 42 edits
    3 adds in trunk

Add support for the Blob constructor
https://bugs.webkit.org/show_bug.cgi?id=84555

Reviewed by Maciej Stachowiak.

Source/WebCore:

Test: fast/files/blob-constructor.html

This adds an implementation of the Blob constructor that willfully
violates the W3C Editor’s Draft 29 February 2012 in the following ways:

  • bindings/js/JSBlobCustom.cpp:

(WebCore::JSBlobConstructor::constructJSBlob):
Implement blob constructor.

  • bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCallback):
Implement blob constructor.

  • fileapi/Blob.idl:

Add constructor to IDL.

  • workers/WorkerContext.idl:

Add Blob constructor to the worker global object.

LayoutTests:

Switch tests that were not directly testing BlobBuilder over to
using the Blob constructor, to get test coverage of standard way
constructing blobs.

  • fast/files/blob-constructor.html:
  • fast/files/blob-constructor-expected.txt:
  • fast/files/script-tests/blob-constructor.js:

New test.

  • fast/dom/HTMLAnchorElement/anchor-download-unset.html:
  • fast/dom/HTMLAnchorElement/anchor-download.html:
  • fast/dom/HTMLAnchorElement/anchor-nodownload-set.html:
  • fast/dom/HTMLAnchorElement/anchor-nodownload.html:
  • fast/dom/window-domurl-crash.html:
  • fast/files/blob-builder-crash-expected.txt: Removed.
  • fast/files/blob-builder-crash.html: Removed.
  • fast/files/blob-slice-overflow.html:
  • fast/files/blob-slice-test.html:
  • fast/files/file-reader-fffd.html:
  • fast/files/not-enough-arguments.html:
  • fast/files/resources/read-blob-test-cases.js:
  • fast/files/resources/read-common.js:
  • fast/files/workers/inline-worker-via-blob-url.html:
  • fast/filesystem/resources/file-writer-abort-continue.js:
  • fast/filesystem/resources/file-writer-abort-depth.js:
  • fast/filesystem/resources/file-writer-abort.js:
  • fast/filesystem/resources/file-writer-events.js:
  • fast/filesystem/resources/file-writer-gc-blob.js:
  • fast/filesystem/resources/file-writer-sync-truncate-extend.js:
  • fast/filesystem/resources/file-writer-sync-write-overlapped.js:
  • fast/filesystem/resources/file-writer-utils.js:
  • http/tests/fileapi/create-blob-url-from-data-url.html:
  • http/tests/filesystem/no-cache-filesystem-url.html:
  • http/tests/local/blob/resources/hybrid-blob-util.js:
  • http/tests/security/resources/create-filesystem-file.html:
  • http/tests/websocket/tests/hixie76/send-object.html:
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html:
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close.html:
  • http/tests/websocket/tests/hybi/send-blob.html:
  • http/tests/websocket/tests/hybi/send-file-blob-fail.html:
  • http/tests/websocket/tests/hybi/send-file-blob.html:
  • http/tests/websocket/tests/hybi/workers/resources/send-blob.js:
  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • storage/indexeddb/noblobs.html:
  • storage/indexeddb/structured-clone.html:
1:19 PM Changeset in webkit [115483] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Lazy link phase of baseline jit fails to propagate exception
https://bugs.webkit.org/show_bug.cgi?id=85092

Reviewed by Filip Pizlo.

Very simple patch, when linking produces an error we need to actually store
the exception prior to throwing it. I can't find any other examples of this,
but as we're already in the slow path when throwing an exception I've hardened
exception throwing against null exceptions.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::throwException):

  • jit/JITStubs.cpp:

(JSC::lazyLinkFor):

1:18 PM Changeset in webkit [115482] by commit-queue@webkit.org
  • 4 edits in trunk

[Qt] Fix minimal build.
https://bugs.webkit.org/show_bug.cgi?id=85045

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-27
Reviewed by Tor Arne Vestbø.

Source/WebCore:

Compile LIBXML XML parser even if ENABLE_XSLT is not set.

  • Target.pri:

Tools:

Do not set conflicting values of ENABLE_XSLT.

  • qmake/mkspecs/features/features.prf:
1:18 PM Changeset in webkit [115481] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

Remove passing test from expectations.

  • platform/chromium/test_expectations.txt: Another one bites the dust.
1:09 PM Changeset in webkit [115480] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Layout Tests fast/js/dfg-float64array.html, fast/js/dfg-uint16array.html, and fast/js/dfg-uint8array.html are flaky timeouts.
https://bugs.webkit.org/show_bug.cgi?id=85090

  • platform/chromium/test_expectations.txt: Marked as flakes.
1:07 PM Changeset in webkit [115479] by Lucas Forschler
  • 2 edits in tags/Safari-536.8.4/Source/WebCore

Merged r114792.

1:07 PM Changeset in webkit [115478] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/Tools

[EFL][DRT] EFL should sanitize pulseaudio module configuration too
https://bugs.webkit.org/show_bug.cgi?id=85047

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-27
Reviewed by Dirk Pranke.

PulseAudio test setup sanitization shared between EFL and GTK.

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort):
(EflPort.setup_test_run):
(EflPort.clean_up_test_run):

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort): Moving pulseaudio unload/restore out to shared class.

  • Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer.py: Added.

(PulseAudioSanitizer):
(PulseAudioSanitizer._unload_pulseaudio_module):
(PulseAudioSanitizer._restore_pulseaudio_module):

1:05 PM Changeset in webkit [115477] by Lucas Forschler
  • 6 edits in tags/Safari-536.8.4/Source

Merged r114778.

1:02 PM Changeset in webkit [115476] by Lucas Forschler
  • 4 edits in tags/Safari-536.8.4/Source

Versioning.

1:00 PM Changeset in webkit [115475] by Lucas Forschler
  • 1 copy in tags/Safari-536.8.4

New Tag.

1:00 PM Changeset in webkit [115474] by Lucas Forschler
  • 1 delete in tags/Safari-536.8.5

Remove Tag.

12:59 PM Changeset in webkit [115473] by Lucas Forschler
  • 1 copy in tags/Safari-536.8.5

New Tag.

12:44 PM Changeset in webkit [115472] by leandrogracia@chromium.org
  • 8 edits
    4 adds in trunk/Source/WebKit/chromium

Selectively retrieve text around a touched point.
https://bugs.webkit.org/show_bug.cgi?id=82460

Reviewed by Darin Fisher.

Implements an embedding API to WebCore's SurroundingText, adding also
the possibility of select and highlight the retrieved text range.

  • WebKit.gyp:
  • public/WebFrame.h:

(WebFrame):

  • public/WebHitTestResult.h: Added.

(WebCore):
(WebKit):
(WebHitTestResult):
(WebKit::WebHitTestResult::WebHitTestResult):
(WebKit::WebHitTestResult::~WebHitTestResult):

  • public/WebRange.h:

(WebKit):
(WebRange):

  • public/WebSurroundingText.h: Added.

(WebCore):
(WebKit):
(WebSurroundingText):
(WebKit::WebSurroundingText::WebSurroundingText):
(WebKit::WebSurroundingText::~WebSurroundingText):

  • public/WebView.h:

(WebKit):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::selectRange):
(WebKit):

  • src/WebFrameImpl.h:

(WebFrameImpl):

  • src/WebHitTestResult.cpp: Added.

(WebKit):
(WebKit::WebHitTestResult::node):
(WebKit::WebHitTestResult::localPoint):
(WebKit::WebHitTestResult::WebHitTestResult):
(WebKit::WebHitTestResult::operator=):
(WebKit::WebHitTestResult::operator HitTestResult):
(WebKit::WebHitTestResult::isNull):
(WebKit::WebHitTestResult::assign):
(WebKit::WebHitTestResult::reset):

  • src/WebRange.cpp:

(WebKit::WebRange::textQuads):
(WebKit):

  • src/WebSurroundingText.cpp: Added.

(WebKit):
(WebKit::WebSurroundingText::initialize):
(WebKit::WebSurroundingText::textContent):
(WebKit::WebSurroundingText::hitOffsetInTextContent):
(WebKit::WebSurroundingText::rangeFromContentOffsets):
(WebKit::WebSurroundingText::isNull):
(WebKit::WebSurroundingText::reset):

12:35 PM Changeset in webkit [115471] by shawnsingh@chromium.org
  • 4 edits
    4 adds in trunk

Infinite backgroundClipRect should not be scrolled.
https://bugs.webkit.org/show_bug.cgi?id=84979

Reviewed by Adrienne Walker.

Source/WebCore:

Test: compositing/iframes/scroll-fixed-transformed-element.html

By accidentally scrolling clipRects that should be considered
"infinite", they were no longer being considered infinite. This
caused a chain of un-intended code paths that caused fixed
position elements to stutter when scrolling in Chromium.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::backgroundClipRect):

LayoutTests:

  • compositing/iframes/resources/fixed-position-transformed-subframe.html: Added.
  • compositing/iframes/scroll-fixed-transformed-element-expected.png: Added.
  • compositing/iframes/scroll-fixed-transformed-element-expected.txt: Added.
  • compositing/iframes/scroll-fixed-transformed-element.html: Added.
12:31 PM Changeset in webkit [115470] by arv@chromium.org
  • 14 edits in trunk/LayoutTests

Clean up tests in preparation for ES5.2 global scope fix
https://bugs.webkit.org/show_bug.cgi?id=85001

Reviewed by Gavin Barraclough.

  • fast/css/resize-value-compared.html:
  • fast/dom/resources/navigation-type-matches-querystring.html:
  • fast/dom/script-tests/webtiming-document-open.js:
  • fast/dom/script-tests/webtiming-navigate-within-document.js:
  • fast/dom/script-tests/webtiming.js:
  • http/tests/inspector/indexeddb/indexeddb-test.js:
  • http/tests/misc/resources/webtiming-cross-origin-and-back2.html:
  • http/tests/misc/resources/webtiming-cross-origin-redirect.html:
  • http/tests/misc/resources/webtiming-no-origin.html:
  • http/tests/misc/resources/webtiming-one-redirect.html:
  • http/tests/misc/resources/webtiming-ssl.html:
  • http/tests/misc/resources/webtiming-two-redirects.html:
  • http/tests/misc/webtiming-slow-load.php:
12:24 PM Changeset in webkit [115469] by dpranke@chromium.org
  • 5 edits in trunk

Unreviewed, revert r115453 - broke chromium win bots

Tools:

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort._path_to_image_diff):
(ChromiumDriver):
(ChromiumDriver.init):
(ChromiumDriver._wrapper_options):
(ChromiumDriver.cmd_line):
(ChromiumDriver.stop):

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumDriverTest.setUp):
(ChromiumDriverTest.test_stop):
(ChromiumDriverTest.test_two_drivers):
(ChromiumDriverTest.test_two_drivers.MockDriver.init):

LayoutTests:

  • platform/chromium/test_expectations.txt:
12:24 PM Changeset in webkit [115468] by Lucas Forschler
  • 5 edits in tags/Safari-536.8.3

rollout 113723.

12:24 PM Changeset in webkit [115467] by Dimitri Glazkov
  • 8 edits
    4 deletes in trunk/Source/WebKit/chromium

Unreviewed, rolling out r115463.
http://trac.webkit.org/changeset/115463
https://bugs.webkit.org/show_bug.cgi?id=82460

Broke Mac build.

  • WebKit.gyp:
  • public/WebFrame.h:

(WebFrame):

  • public/WebHitTestResult.h: Removed.
  • public/WebRange.h:

(WebRange):

  • public/WebSurroundingText.h: Removed.
  • public/WebView.h:

(WebKit):

  • src/WebFrameImpl.cpp:
  • src/WebFrameImpl.h:

(WebFrameImpl):

  • src/WebHitTestResult.cpp: Removed.
  • src/WebRange.cpp:
  • src/WebSurroundingText.cpp: Removed.
12:21 PM Changeset in webkit [115466] by rniwa@webkit.org
  • 6 edits in trunk/Tools

Chromium Windows Perf bots timeout due to not output
https://bugs.webkit.org/show_bug.cgi?id=84940

Reviewed by Dirk Pranke.

Dirk and I investigated the issue on the bot but we couldn't figure out what is going wrong.
Since we run-perf-tests don't need any of fancy feature printer provides, just use python's
built-in logging module instead. Printing out to stdout and stderr seem to work so hopefully
this will fix the issue on the bot.

  • Scripts/run-perf-tests:
  • Scripts/webkitpy/performance_tests/perftest.py:

(PerfTest.run):
(PerfTest.run_failed):
(PerfTest.parse_output):
(PerfTest.output_statistics):
(ChromiumStylePerfTest.parse_output):
(PageLoadingPerfTest.run):

  • Scripts/webkitpy/performance_tests/perftest_unittest.py:

(MainTest.test_parse_output):
(MainTest.test_parse_output_with_failing_line):
(TestPageLoadingPerfTest):
(TestPageLoadingPerfTest.test_run):
(TestPageLoadingPerfTest.test_run_with_bad_output):

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner.init):
(PerfTestsRunner._parse_args):
(PerfTestsRunner.run):
(PerfTestsRunner._upload_json):
(PerfTestsRunner._print_status):
(PerfTestsRunner._run_tests_set):
(PerfTestsRunner._run_single_test):

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(create_runner):
(test_run_test_set):
(test_run_test_set_kills_drt_per_run):
(test_run_test_pause_before_testing):
(test_run_test_set_for_parser_tests):
(test_run_test_set_with_json_output):
(test_run_test_set_with_json_source):
(test_run_test_set_with_multiple_repositories):
(test_upload_json):
(test_parse_args):

12:15 PM Changeset in webkit [115465] by benjamin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Generalize the single character optimization of numberProtoFuncToString
https://bugs.webkit.org/show_bug.cgi?id=85027

Reviewed by Geoffrey Garen.

The function numberProtoFuncToString() has an optimization to use SmallStrings::singleCharacterString()
when the radix is 36.

This patch generalize the optimization for any radix. Any positive number smaller than its radix
can be represented by a single character of radixDigits.

This makes numberProtoFuncToString() about twice as fast for this case of single digit conversion.

  • runtime/NumberPrototype.cpp:

(JSC::numberProtoFuncToString):

12:02 PM Changeset in webkit [115464] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Source/WebKit/chromium

Added a chromium webkit public header file to support different web print scaling options.
https://bugs.webkit.org/show_bug.cgi?id=84608

Patch by Kausalya Madhusudhanan <kmadhusu@chromium.org> on 2012-04-27
Reviewed by Darin Fisher.

  • WebKit.gyp:
  • public/WebPrintScalingOption.h: Added.

(WebKit):

11:56 AM Changeset in webkit [115463] by leandrogracia@chromium.org
  • 8 edits
    4 adds in trunk/Source/WebKit/chromium

Selectively retrieve text around a touched point.
https://bugs.webkit.org/show_bug.cgi?id=82460

Reviewed by Darin Fisher.

Implements an embedding API to WebCore's SurroundingText, adding also
the possibility of select and highlight the retrieved text range.

  • WebKit.gyp:
  • public/WebFrame.h:

(WebFrame):

  • public/WebHitTestResult.h: Added.

(WebCore):
(WebKit):
(WebHitTestResult):
(WebKit::WebHitTestResult::WebHitTestResult):
(WebKit::WebHitTestResult::~WebHitTestResult):

  • public/WebRange.h:

(WebKit):
(WebRange):

  • public/WebSurroundingText.h: Added.

(WebCore):
(WebKit):
(WebSurroundingText):
(WebKit::WebSurroundingText::WebSurroundingText):
(WebKit::WebSurroundingText::~WebSurroundingText):

  • public/WebView.h:

(WebKit):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::selectRange):
(WebKit):

  • src/WebFrameImpl.h:

(WebFrameImpl):

  • src/WebHitTestResult.cpp: Added.

(WebKit):
(WebKit::WebHitTestResult::node):
(WebKit::WebHitTestResult::localPoint):
(WebKit::WebHitTestResult::WebHitTestResult):
(WebKit::WebHitTestResult::operator=):
(WebKit::WebHitTestResult::operator HitTestResult):
(WebKit::WebHitTestResult::isNull):
(WebKit::WebHitTestResult::assign):
(WebKit::WebHitTestResult::reset):

  • src/WebRange.cpp:

(WebKit::WebRange::textQuads):
(WebKit):

  • src/WebSurroundingText.cpp: Added.

(WebKit):
(WebKit::WebSurroundingText::initialize):
(WebKit::WebSurroundingText::textContent):
(WebKit::WebSurroundingText::hitOffsetInTextContent):
(WebKit::WebSurroundingText::rangeFromContentOffsets):
(WebKit::WebSurroundingText::isNull):
(WebKit::WebSurroundingText::reset):

11:55 AM Changeset in webkit [115462] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

Layout Test media/video-currentTime-set.html is still flaky
https://bugs.webkit.org/show_bug.cgi?id=85003

Reviewed by Eric Carlson.

  • media/video-currentTime-set.html: Removed extraneous timeout code.
11:53 AM Changeset in webkit [115461] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

FormatBlock crashes when body element is removed prior to the command execution
https://bugs.webkit.org/show_bug.cgi?id=84937

Reviewed by Tony Chang.

Source/WebCore:

The crash was because because DOM had been modified since the last time selection had been "validated",
and therefore frame selection's endpoints are no longer visible when we instantiated visibleStart
and visibleEnd from m_endingSelection of the edit command.

Fixed the bug by checking the nullity and orphanedness of visible start and visible end directly.
I suspect we have similar bugs in other commands. The fundamental problem is that the copy constructor
of VisibleSelection never validates so when a VisibleSelection is passed from one class to another
(e.g. FrameSelection to EditCommand), we may not adjust end points as needed.

Test: editing/execCommand/format-block-without-body-crash.html

  • editing/ApplyBlockElementCommand.cpp:

(WebCore::ApplyBlockElementCommand::doApply):

LayoutTests:

Add a regression test for executing FormatCommand immediately after removing
the body element thereby turning the selection end points to non-candidates.

  • editing/execCommand/format-block-without-body-crash-expected.txt: Added.
  • editing/execCommand/format-block-without-body-crash.html: Added.
11:51 AM Changeset in webkit [115460] by enrica@apple.com
  • 4 edits in trunk/Source/WebCore

REGRESSION(r96257): Deleting a large amount of text is very slow.
https://bugs.webkit.org/show_bug.cgi?id=83983
<rdar://problem/10826076>

Reviewed by Ryosuke Niwa.

The change in r96257 did not cause the performance regression per se,
but exposed a problem in the way we calculate the offset in container
node when the anchorType is PositionIsOffsetInAnchor.
The offset was computed as the minimum between the given offset and
lastOffsetInNode. If the container has a very large number of children,
we walk the entire list of child nodes in the container simply to find
out how many they are.
Looking through the entire editing code, I found other 2 cases (one
is only an ASSERT) where we could do a similar optimization.

No new tests. No behavior change, only performance optimization.

  • dom/Position.cpp:

(WebCore::Position::computeOffsetInContainerNode):

  • dom/Position.h:

(WebCore::minOffsetForNode):
(WebCore::offsetIsBeforeLastNodeOffset):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::removeInlineStyle):
(WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical):

11:49 AM Changeset in webkit [115459] by eae@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/css/CSSPrimitiveValue.h

Merge length changes into subpixel branch.

11:44 AM Changeset in webkit [115458] by jchaffraix@webkit.org
  • 3 edits
    2 adds in trunk

NULL-deref in RenderBox::clippedOverflowRectForRepaint
https://bugs.webkit.org/show_bug.cgi?id=84774

Reviewed by Tony Chang.

Source/WebCore:

Test: fast/inline/crash-new-continuation-with-outline.html

The bug comes from trying to repaint the :after content as part of updateBeforeAfterContent.
The repainting logic would query the yet-to-be-inserted continuation(). Then we would crash in
RenderBox::clippedOverflowRectForRepaint as we didn't have an enclosingLayer() (which any
RenderObject in the tree will have).

The fix is to check in RenderInline::clippedOverflowRectForRepaint that our continuation()
is properly inserted in the tree. We could check that it isRooted() but it's an overkill here.

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::clippedOverflowRectForRepaint):

LayoutTests:

  • fast/inline/crash-new-continuation-with-outline-expected.txt: Added.
  • fast/inline/crash-new-continuation-with-outline.html: Added.
11:37 AM Changeset in webkit [115457] by Lucas Forschler
  • 4 edits in tags/Safari-536.8.3/Source

Versioning.

11:34 AM Changeset in webkit [115456] by Lucas Forschler
  • 1 copy in tags/Safari-536.8.3

New Tag.

11:33 AM Changeset in webkit [115455] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/platform/win/PopupMenuWin.cpp

Using minimumIntValueForLength instead of a static_cast.

11:26 AM Changeset in webkit [115454] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

Memory cache pruning should be protected against reentering.
https://bugs.webkit.org/show_bug.cgi?id=85077

Reviewed by Alexey Proskuryakov.

MemoryCache::pruneDeadResourcesToSize() has some ad-hock protection against reentering.
This patch adds more complete protection.

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::MemoryCache):
(WebCore::MemoryCache::pruneLiveResourcesToSize):

Protect live resource pruning too.

(WebCore::MemoryCache::pruneDeadResourcesToSize):

Remove the existing weak reentrancy handling in favor of full proctection.

  • loader/cache/MemoryCache.h:

(MemoryCache):

11:24 AM Changeset in webkit [115453] by dpranke@chromium.org
  • 5 edits in trunk

[chromium] use "drt-style" output, not "test-shell-style" output, on mac and linux DRT
https://bugs.webkit.org/show_bug.cgi?id=84917

Tools:

Reviewed by Ojan Vafai.

This change changes the chromium new-run-webkit-tests
implementation to use the code in WebKitDriver and ServerProcess
by default on Mac and Linux, instead of using the old-style
Chromium/test_shell style of output.

We will still use the test_shell style on Windows for now
and you can still get the old style of behavior with
new-run-webkit-tests --additional-drt-flag --test-shell

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumDriver):
(ChromiumDriver.init):
(ChromiumDriver._wrapper_options):
(ChromiumDriver.cmd_line):
(ChromiumDriver._start):
(ChromiumDriver.has_crashed):
(ChromiumDriver.run_test):
(ChromiumDriver.stop):

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumDriverTest.setUp):
(ChromiumDriverTest.test_stop):
(ChromiumDriverTest.test_two_drivers.MockDriver.init):
(ChromiumDriverTest.test_two_drivers):

LayoutTests:

Unreviewed, expectations change to accompany the new-run-webkit-tests change.

  • platform/chromium/test_expectations.txt
11:12 AM Changeset in webkit [115452] by dpranke@chromium.org
  • 4 edits in trunk/Tools

webkitpy: fix race in unit tests for manager_worker_broker
https://bugs.webkit.org/show_bug.cgi?id=84925

Reviewed by Ojan Vafai.

I have been intermittently seeing hangs when running
test-webkitpy on Mac SL; it appears that there's a bug (?) in
the multiprocessing module where queue references are getting
leaked or not cleaned up somehow. By explicitly closing the
queues, things seem to be happy, so this patch adds a cleanup()
method to the message broker and modifies the manager (and the
unit tests) to call it. This may get rid of the intermittent
error on shutdown on Linux I've seen as well.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._run_tests):

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:

(_Broker.del):
(_Broker):
(_Broker.cleanup):
(_BrokerConnection.cleanup):

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:

(_TestsMixin.test_name):
(_TestsMixin.test_cancel):
(_TestsMixin.test_done):
(_TestsMixin.test_unknown_message):

11:05 AM Changeset in webkit [115451] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] ResourceError domain needs to be properly set in FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=84129

Patch by Christophe Dumez <Christophe Dumez> on 2012-04-27
Reviewed by Nate Chapin.

Source/WebKit/efl:

Properly set ResourceError objects' domain instead of using a generic
one. This allows WebKit and NSURL errors to be distinguished, which is
required to properly print out information in EFL's DumpRenderTree
when dumpResourceLoadCallbacks() returns true.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::cancelledError):
(WebCore::FrameLoaderClientEfl::blockedError):
(WebCore::FrameLoaderClientEfl::cannotShowURLError):
(WebCore::FrameLoaderClientEfl::interruptedForPolicyChangeError):
(WebCore::FrameLoaderClientEfl::cannotShowMIMETypeError):
(WebCore::FrameLoaderClientEfl::fileDoesNotExistError):
(WebCore::FrameLoaderClientEfl::pluginWillHandleLoadError):

LayoutTests:

Unskip the tests which require EFL's DumpRenderTree to support
LayoutTestController's dumpResourceLoadCallbacks() and print out
correctly information about resource loading errors.

  • platform/efl/Skipped:
11:03 AM Changeset in webkit [115450] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] platform/chromium/media/video-capture-preview.html is a flaky crash.
https://bugs.webkit.org/show_bug.cgi?id=85082

  • platform/chromium/test_expectations.txt: Added expectation of flakiness.
11:01 AM Changeset in webkit [115449] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/efl

[EFL] tabsToLinks ewk_view setting
https://bugs.webkit.org/show_bug.cgi?id=84340

Exporting new ewk_view setting: tabsToLinks - enbles/disables tab key focusing of page elements.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-04-27
Reviewed by Antonio Gomes.

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::keyboardUIMode):

  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(ewk_view_setting_include_links_in_focus_chain_get):
(ewk_view_setting_include_links_in_focus_chain_set):

  • ewk/ewk_view.h:
10:37 AM Changeset in webkit [115448] by tonyg@chromium.org
  • 2 edits
    1 add in trunk/Source/WebKit/chromium

Unreviewed, rolling out r115436.
http://trac.webkit.org/changeset/115436
https://bugs.webkit.org/show_bug.cgi?id=85079

"broke the build" (Requested by tonyg-cr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-27

  • WebKit.gyp:
  • public/WebReferrerPolicy.h: Added.
10:32 AM Changeset in webkit [115447] by apavlov@chromium.org
  • 8 edits
    2 adds in trunk

Source/WebCore: Web Inspector: Implement the "Disable JavaScript" option in the settings dialog
(re-landing r115417 with a test that should work on Windows.)
https://bugs.webkit.org/show_bug.cgi?id=84946

Reviewed by Yury Semikhatsky.

Test: inspector/debugger/disable-script.html

  • inspector/Inspector.json:
  • inspector/InspectorPageAgent.cpp:

(PageAgentState):
(WebCore::InspectorPageAgent::enable):
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::getScriptExecutionStatus):
(WebCore):
(WebCore::InspectorPageAgent::setScriptExecutionDisabled):

  • inspector/InspectorPageAgent.h:
  • inspector/front-end/Settings.js:
  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):
(WebInspector.SettingsScreen.prototype.get _updateScriptDisabledCheckbox):
(WebInspector.SettingsScreen.prototype._javaScriptDisabledChanged):

  • inspector/front-end/inspector.js:

LayoutTests: Web Inspector: Implement the "Disable JavaScript" option in the settings dialog
https://bugs.webkit.org/show_bug.cgi?id=84946

Reviewed by Yury Semikhatsky.

  • inspector/debugger/disable-script-expected.txt: Added.
  • inspector/debugger/disable-script.html: Added.
9:56 AM Changeset in webkit [115446] by keishi@webkit.org
  • 5 edits in trunk

IETC HTML5: verify HTMLDataListElement - instanceof HTMLDataListElement fails.
https://bugs.webkit.org/show_bug.cgi?id=81196

Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/dom/Window/window-properties.html, fast/dom/Window/window-lookup-precedence.html

HTMLDataListElement should be available on DOMWindow.

  • page/DOMWindow.idl: Added HTMLDataListElement.

LayoutTests:

  • fast/dom/Window/resources/window-properties.js: Added HTMLDataListElement to the list.
  • platform/chromium/fast/dom/Window/window-lookup-precedence-expected.txt:
9:53 AM Changeset in webkit [115445] by Dimitri Glazkov
  • 8 edits
    2 deletes in trunk

Unreviewed, rolling out r115417.
http://trac.webkit.org/changeset/115417
https://bugs.webkit.org/show_bug.cgi?id=84946

Added test is broken on windows.

Source/WebCore:

  • inspector/Inspector.json:
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::enable):
(WebCore::InspectorPageAgent::disable):

  • inspector/InspectorPageAgent.h:
  • inspector/front-end/Settings.js:
  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):

  • inspector/front-end/inspector.js:

LayoutTests:

  • inspector/debugger/disable-script-expected.txt: Removed.
  • inspector/debugger/disable-script.html: Removed.
9:46 AM Changeset in webkit [115444] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] fast/images/gif-large-checkerboard.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=85073

  • platform/chromium/test_expectations.txt: Marked flaky crash.
9:38 AM Changeset in webkit [115443] by gavinp@chromium.org
  • 15 edits in trunk

Add new ENABLE_LINK_PRERENDER define to control the Prerendering API
https://bugs.webkit.org/show_bug.cgi?id=84871

Reviewed by Adam Barth.

Source/JavaScriptCore:

Prerendering is currently covered by the ENABLE_LINK_PREFETCH macro, but the new Prerendering
API separates it from prefetching. Having separate include guards lets ports enable prefetching,
a relatively easy change, without needing to build the infrastructure for prerendering, which
is considerably more complicated.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Prerendering is currently covered by the ENABLE_LINK_PREFETCH macro, but the new Prerendering
API separates it from prefetching. Having separate include guards lets ports enable prefetching,
a relatively easy change, without needing to build the infrastructure for prerendering, which
is considerably more complicated.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/chromium:

Prerendering is currently covered by the ENABLE_LINK_PREFETCH macro, but the new Prerendering
API separates it from prefetching. Having separate include guards lets ports enable prefetching,
a relatively easy change, without needing to build the infrastructure for prerendering, which
is considerably more complicated.

Source/WebKit/mac:

Prerendering is currently covered by the ENABLE_LINK_PREFETCH macro, but the new Prerendering
API separates it from prefetching. Having separate include guards lets ports enable prefetching,
a relatively easy change, without needing to build the infrastructure for prerendering, which
is considerably more complicated.

Source/WebKit2:

Prerendering is currently covered by the ENABLE_LINK_PREFETCH macro, but the new Prerendering
API separates it from prefetching. Having separate include guards lets ports enable prefetching,
a relatively easy change, without needing to build the infrastructure for prerendering, which
is considerably more complicated.

Tools:

Prerendering is currently covered by the ENABLE_LINK_PREFETCH macro, but the new Prerendering
API separates it from prefetching. Having separate include guards lets ports enable prefetching,
a relatively easy change, without needing to build the infrastructure for prerendering, which
is considerably more complicated.

WebKitLibraries:

Prerendering is currently covered by the ENABLE_LINK_PREFETCH macro, but the new Prerendering
API separates it from prefetching. Having separate include guards lets ports enable prefetching,
a relatively easy change, without needing to build the infrastructure for prerendering, which
is considerably more complicated.

  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
9:35 AM Changeset in webkit [115442] by zandobersek@gmail.com
  • 5 edits in trunk/Source/WebCore

[Gtk][DOM Bindings] Feature-protected properties are put under condition guards
https://bugs.webkit.org/show_bug.cgi?id=85068

Reviewed by Martin Robinson.

Generated feature-dependent properties are now present regardless of that
feature being enabled. On getting or setting that property's value a warning
is thrown if the feature is not enabled. Additionally, if the generated
interface is feature-dependant, when getting or setting any property's value
a warning is thrown if the feature is not enabled.

No new tests - covered by existing bindings tests.

  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateProperty):
(GenerateProperties):

  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp: Rebaseline.

(webkit_dom_test_interface_set_property):
(webkit_dom_test_interface_get_property):
(webkit_dom_test_interface_class_init):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto.

(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):

  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp: Ditto.

(webkit_dom_test_serialized_script_value_interface_get_property):

9:34 AM Changeset in webkit [115441] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r115433.
http://trac.webkit.org/changeset/115433
https://bugs.webkit.org/show_bug.cgi?id=85052

Enable unit tests again.

  • tests/PopupMenuTest.cpp:

(WebKit::TEST_F):

9:32 AM Changeset in webkit [115440] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r115421.
http://trac.webkit.org/changeset/115421
https://bugs.webkit.org/show_bug.cgi?id=85052

Enable unit tests again.

  • tests/PopupMenuTest.cpp:

(WebKit::TEST_F):

9:29 AM Changeset in webkit [115439] by Dimitri Glazkov
  • 3 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r115400.
http://trac.webkit.org/changeset/115400
https://bugs.webkit.org/show_bug.cgi?id=84420

Broke unit tests.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::popupOpened):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::applyAutofillSuggestions):

9:27 AM Changeset in webkit [115438] by zandobersek@gmail.com
  • 5 edits in trunk/Source/WebCore

[Gtk][DOM Bindings] Conditional string in implementation file generated in wrong place after 113450
https://bugs.webkit.org/show_bug.cgi?id=85065

Reviewed by Martin Robinson.

Put the condition string in implementation file after the header inclusions. This ensures
that build errors do not occur when disabling the future that applies to the condition string
because of WebCore objects and methods that are still in use despite the feature being disabled.

No new tests - covered by bindings tests.

  • bindings/scripts/CodeGeneratorGObject.pm:

(WriteData):

  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp: Rebaseline generated results.
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp: Ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp: Ditto.
9:10 AM Changeset in webkit [115437] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Improve log output in InputHandler.cpp
https://bugs.webkit.org/show_bug.cgi?id=85007

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-04-27
Reviewed by Antonio Gomes.

PR 138292
Improving logging in InputHandler.
In setText we had an early return which wasn't being captured.
Also, cleaning up the output to make it more clear and descriptive.

Internally reviewed by Mike Fenton.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::learnText):
(BlackBerry::WebKit::InputHandler::enableInputMode):
(BlackBerry::WebKit::InputHandler::setText):

8:57 AM Changeset in webkit [115436] by gavinp@chromium.org
  • 2 edits
    1 delete in trunk/Source/WebKit/chromium

[Chromium] Remove Webkit/chromium/public/WebReferrerPolicy.h thunk.
https://bugs.webkit.org/show_bug.cgi?id=84552

After http://codereview.chromium.org/10139023/ lands, this thunk is no
longer needed.

Reviewed by Adam Barth.

  • WebKit.gyp:
  • public/WebReferrerPolicy.h: Removed.
8:29 AM Changeset in webkit [115435] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[Blackberry] remove redundant returns
https://bugs.webkit.org/show_bug.cgi?id=85033

Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-04-27
Reviewed by Antonio Gomes.

Remove two redundant returns which were added by accident.

No new test cases, because no behaviour has changed.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::setSelection):
(BlackBerry::WebKit::WebPage::setCaretPosition):

8:27 AM Changeset in webkit [115434] by kling@webkit.org
  • 5 edits
    2 adds in trunk

Avoid mutating Element attribute storage in StepRange constructor.
<http://webkit.org/b/84797>

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/selectors/querySelector-in-range-crash.html

  • dom/Attribute.h:

Add comment about the volatility of references returned by getters.

  • html/StepRange.cpp:

(WebCore::StepRange::StepRange):

Replace hasAttribute/getAttribute pair by a single fastGetAttribute.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateType):
(WebCore::HTMLInputElement::value):

Store the value attribute in an local variable before passing it to sanitizeValue().

LayoutTests:

  • fast/selectors/querySelector-in-range-crash-expected.txt: Added.
  • fast/selectors/querySelector-in-range-crash.html: Added.
8:14 AM Changeset in webkit [115433] by bulach@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Disables a few more webkit_unittests.
https://bugs.webkit.org/show_bug.cgi?id=85052

Unreviewed build fix.

Failing on Windows bots, probably due to r115400.

  • tests/PopupMenuTest.cpp:

(WebKit::TEST_F):

8:05 AM Changeset in webkit [115432] by rwlbuis@webkit.org
  • 3 edits
    8 adds in trunk

SVG inline style of 'marker-*' does not override
https://bugs.webkit.org/show_bug.cgi?id=84824

Source/WebCore:

Reviewed by Nikolas Zimmermann.

Properly handle CSSValueNone for clip-path, filter, mask and marker-* properties. Instead
of bailing out, set the none value explicitly, since an earlier match may have set it to
something other than none.

Tests: svg/custom/inline-style-overrides-clipPath-expected.svg

svg/custom/inline-style-overrides-clipPath.svg
svg/custom/inline-style-overrides-filter-expected.svg
svg/custom/inline-style-overrides-filter.svg
svg/custom/inline-style-overrides-markers-expected.svg
svg/custom/inline-style-overrides-markers.svg
svg/custom/inline-style-overrides-mask-expected.svg
svg/custom/inline-style-overrides-mask.svg

  • css/SVGCSSStyleSelector.cpp:

(WebCore::StyleResolver::applySVGProperty):

LayoutTests:

Add tests for clip-path, filter, mask and marker-* properties.

Reviewed by Nikolas Zimmermann.

  • svg/custom/inline-style-overrides-clipPath-expected.svg: Added.
  • svg/custom/inline-style-overrides-clipPath.svg: Added.
  • svg/custom/inline-style-overrides-filter-expected.svg: Added.
  • svg/custom/inline-style-overrides-filter.svg: Added.
  • svg/custom/inline-style-overrides-markers-expected.svg: Added.
  • svg/custom/inline-style-overrides-markers.svg: Added.
  • svg/custom/inline-style-overrides-mask-expected.svg: Added.
  • svg/custom/inline-style-overrides-mask.svg: Added.
8:05 AM Changeset in webkit [115431] by Philippe Normand
  • 2 edits in trunk/Tools

Unreviewed, GTK gardening.

  • Scripts/run-gtk-tests:

(TestRunner): Skip flaky WebKit2 API test.

8:00 AM Changeset in webkit [115430] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] media/video-controls-rendering-toggle-display-none.html is failing
https://bugs.webkit.org/show_bug.cgi?id=84949

Patch by Christophe Dumez <Christophe Dumez> on 2012-04-27
Reviewed by Antonio Gomes.

Fix volume slider rendering so that the
media/video-controls-rendering-toggle-display-none.html passes.

  • css/mediaControlsEfl.css:

(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
(audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):

7:58 AM Changeset in webkit [115429] by Nikolas Zimmermann
  • 3 edits
    4 adds in trunk

Support values animation mode with just a single value
https://bugs.webkit.org/show_bug.cgi?id=85064

Reviewed by Antti Koivisto.

Source/WebCore:

values="a" is equal to <set to="a"> per SMIL specification.
We currently only support values animation if at least two values are given, fix that.

The reference animations in Dr. Olaf Hoffmanns SVG Animation test suite are mostly using
values animations, sometimes with only a single value given. Lots of the reference animations
are broken in trunk w/o this patch and now work as expected.

See http://hoffmann.bplaced.net/svgtest/index.php?s=en&in=start.

Test: svg/animations/single-values-animation.html

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::calculateKeyTimesForCalcModePaced):
(WebCore::SVGAnimationElement::currentValuesForValuesAnimation):
(WebCore::SVGAnimationElement::startedActiveInterval):

LayoutTests:

  • svg/animations/resources/single-values-animation.svg: Added.
  • svg/animations/script-tests/single-values-animation.js: Added.

(sample1):
(sample2):
(executeTest):

  • svg/animations/single-values-animation-expected.txt: Added.
  • svg/animations/single-values-animation.html: Added.
7:55 AM Changeset in webkit [115428] by bulach@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Update test expectation.
https://bugs.webkit.org/show_bug.cgi?id=85038

Unreviewed, chromium test_expectations update.

  • platform/chromium/test_expectations.txt:
7:17 AM Changeset in webkit [115427] by commit-queue@webkit.org
  • 17 edits
    5 adds in trunk

Web Inspector: Allow inspection of Web Socket Frames
https://bugs.webkit.org/show_bug.cgi?id=83282

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-04-27
Reviewed by Pavel Feldman.

Source/WebCore:

Tests: http/tests/inspector/web-socket-frame-error.html

http/tests/inspector/web-socket-frame.html

  • English.lproj/localizedStrings.js: Added new Web Inspector front-end UI strings.
  • Modules/websockets/WebSocketChannel.cpp: Added InspectorInstrumentation calls to

the following methods.

(WebCore::WebSocketChannel::fail):
(WebCore::WebSocketChannel::processFrame):
(WebCore::WebSocketChannel::sendFrame):

  • WebCore.gypi: Added new Web Inspector resource file.
  • WebCore.vcproj/WebCore.vcproj: Added new Web Inspector resource file.
  • inspector/Inspector.json: Added new Web Inspector resource file.
  • inspector/InspectorInstrumentation.cpp: Added new methods for instrumenting a Web Socket frame or error.

(WebCore::InspectorInstrumentation::didReceiveWebSocketFrameImpl):
(WebCore::InspectorInstrumentation::didReceiveWebSocketFrameErrorImpl):
(WebCore::InspectorInstrumentation::didSendWebSocketFrameImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didReceiveWebSocketFrame):
(WebCore::InspectorInstrumentation::didReceiveWebSocketFrameError):
(WebCore::InspectorInstrumentation::didSendWebSocketFrame):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::didReceiveWebSocketFrame):
(WebCore):
(WebCore::InspectorResourceAgent::didSendWebSocketFrame):
(WebCore::InspectorResourceAgent::didReceiveWebSocketFrameError):

  • inspector/InspectorResourceAgent.h:

(WebCore):
(InspectorResourceAgent):

  • inspector/compile-front-end.py: Added new Web Inspector resource file.
  • inspector/front-end/NetworkItemView.js: Added a new View for inspecting Web Socket frames and errors.

(WebInspector.NetworkItemView):

  • inspector/front-end/NetworkManager.js: Implemented callback called by InspectorResourceAgent for

the new Web Socket frame and error calls.

(WebInspector.NetworkDispatcher.prototype.webSocketFrameReceived):
(WebInspector.NetworkDispatcher.prototype.webSocketFrameSent):
(WebInspector.NetworkDispatcher.prototype.webSocketFrameError):

  • inspector/front-end/NetworkRequest.js: Added a frames array to a Resource request along

with accessor and helper methods

(WebInspector.NetworkRequest):
(WebInspector.NetworkRequest.prototype.resource):
(WebInspector.NetworkRequest.prototype.hasFrames):
(WebInspector.NetworkRequest.prototype.frameLength):
(WebInspector.NetworkRequest.prototype.getFrame):
(WebInspector.NetworkRequest.prototype.addFrameError):
(WebInspector.NetworkRequest.prototype.addFrame):
(WebInspector.NetworkRequest.prototype._pushFrame):

  • inspector/front-end/ResourceWebSocketFrameView.js: Added to help display Web Socket frame and error data.

(WebInspector.ResourceWebSocketFrameView):

  • inspector/front-end/WebKit.qrc: Added new Web Inspector resource file.
  • inspector/front-end/inspector.html: Added new Web Inspector resource file.

LayoutTests:

  • http/tests/inspector/web-socket-frame-error-expected.txt: Added.
  • http/tests/inspector/web-socket-frame-error.html: Added.
  • http/tests/inspector/web-socket-frame-expected.txt: Added.
  • http/tests/inspector/web-socket-frame.html: Added.
7:12 AM Changeset in webkit [115426] by yael.aharon@nokia.com
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] setVisibleContentsRect is not thread safe
https://bugs.webkit.org/show_bug.cgi?id=85060

Reviewed by Noam Rosenthal.

Don't call WebLayerTreeRenderer::setVisibleContentsRect directly. Use bind() instead.

  • UIProcess/LayerTreeHostProxy.cpp:

(WebKit::LayerTreeHostProxy::setVisibleContentsRect):

7:10 AM Changeset in webkit [115425] by Nikolas Zimmermann
  • 16 edits
    20 adds in trunk

Fix repetitions & by animation support for SVGAnimateTransformElement
https://bugs.webkit.org/show_bug.cgi?id=85051

Reviewed by Antti Koivisto.

Source/WebCore:

Repetitions are currently handled by adjusting percentage (percentage += repeatCount).
This doesn't work for <animateTransform> as each repetition has to be post-multiplied to the animated transform list. Fix that.

By-animations are equal to values="0;by" animations in SMIL. '0' is the neutral element of addition, which is the _zero_ matrix,
not the identity matrix for SVGTransform. Add a new construction mode to SVGTransform to be able to construct zero transforms.

Tests: svg/animations/animateTransform-accumulation-expected.svg

svg/animations/animateTransform-accumulation.svg
svg/animations/animateTransform-by-scale-expected.svg
svg/animations/animateTransform-by-scale.svg
svg/animations/animateTransform-from-by-from-to-comparision-expected.svg
svg/animations/animateTransform-from-by-from-to-comparision.svg
svg/animations/animateTransform-from-by-scale-additive-sum-expected.svg
svg/animations/animateTransform-from-by-scale-additive-sum.svg
svg/animations/animateTransform-from-by-scale-expected.svg
svg/animations/animateTransform-from-by-scale.svg
svg/animations/animateTransform-rotate-around-point-expected.svg
svg/animations/animateTransform-rotate-around-point.svg
svg/animations/animateTransform-skewX-expected.svg
svg/animations/animateTransform-skewX.svg
svg/animations/animateTransform-skewY-expected.svg
svg/animations/animateTransform-skewY.svg
svg/animations/animateTransform-translate-expected.svg
svg/animations/animateTransform-translate.svg
svg/animations/multiple-animateTransform-additive-sum-expected.svg
svg/animations/multiple-animateTransform-additive-sum.svg

  • svg/SVGAnimateTransformElement.cpp:

(WebCore::SVGAnimateTransformElement::parseAttribute):

  • svg/SVGAnimatedTransformList.cpp:

(WebCore::SVGAnimatedTransformListAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedTransformListAnimator::calculateAnimatedValue):

  • svg/SVGAnimationElement.h:

(WebCore::SVGAnimationElement::adjustFromToListValues):

  • svg/SVGTransform.cpp:

(WebCore::SVGTransform::SVGTransform):

  • svg/SVGTransform.h:
  • svg/SVGTransformDistance.cpp:

(WebCore::SVGTransformDistance::SVGTransformDistance):
(WebCore::SVGTransformDistance::scaledDistance):
(WebCore::SVGTransformDistance::addSVGTransforms):
(WebCore::SVGTransformDistance::addToSVGTransform):
(WebCore::SVGTransformDistance::distance):

  • svg/SVGTransformDistance.h:

(SVGTransformDistance):

LayoutTests:

Enable <animateTransform> test in additive-type-by-animation, which was disabled as it triggered assertions before this patch.
Add lots of new <animateTransform> covering additive/accumulative animations using reftests, for all animateTransform types (translate/rotate/skewX/skewY/scale).

  • svg/animations/additive-type-by-animation-expected.txt:
  • svg/animations/animateTransform-accumulation-expected.svg: Added.
  • svg/animations/animateTransform-accumulation.svg: Added.
  • svg/animations/animateTransform-by-scale-expected.svg: Added.
  • svg/animations/animateTransform-by-scale.svg: Added.
  • svg/animations/animateTransform-from-by-from-to-comparision-expected.svg: Added.
  • svg/animations/animateTransform-from-by-from-to-comparision.svg: Added.
  • svg/animations/animateTransform-from-by-scale-additive-sum-expected.svg: Added.
  • svg/animations/animateTransform-from-by-scale-additive-sum.svg: Added.
  • svg/animations/animateTransform-from-by-scale-expected.svg: Added.
  • svg/animations/animateTransform-from-by-scale.svg: Added.
  • svg/animations/animateTransform-rotate-around-point-expected.svg: Added.
  • svg/animations/animateTransform-rotate-around-point.svg: Added.
  • svg/animations/animateTransform-skewX-expected.svg: Added.
  • svg/animations/animateTransform-skewX.svg: Added.
  • svg/animations/animateTransform-skewY-expected.svg: Added.
  • svg/animations/animateTransform-skewY.svg: Added.
  • svg/animations/animateTransform-translate-expected.svg: Added.
  • svg/animations/animateTransform-translate.svg: Added.
  • svg/animations/multiple-animateTransform-additive-sum-expected.svg: Added.
  • svg/animations/multiple-animateTransform-additive-sum.svg: Added.
  • svg/animations/resources/additive-type-by-animation.svg:
  • svg/animations/script-tests/additive-type-by-animation.js:

(checkBaseVal):
(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/svgtransform-animation-1.js:

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(sample6):
(sample7):
(executeTest):

  • svg/animations/script-tests/svgtransform-animation-discrete.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/svgtransform-animation-1-expected.txt:
  • svg/animations/svgtransform-animation-discrete-expected.txt:
6:52 AM Changeset in webkit [115424] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Find-in-page fails to deactivate the old active match when moving backwards
https://bugs.webkit.org/show_bug.cgi?id=84892

Patch by Andy Chen <andchen@rim.com> on 2012-04-27
Reviewed by Antonio Gomes.

Find in page fails to deactivate the old active match when moving backwards
because searchStartingPoint was incorrectly initialized.
Create a real range object instead of referencing other range object.
PR 152009

Internally reviewed by Yongxin Dai.

  • WebKitSupport/InPageSearchManager.cpp:

(BlackBerry::WebKit::InPageSearchManager::findNextString):

6:50 AM Changeset in webkit [115423] by Nikolas Zimmermann
  • 16 edits
    8 adds in trunk

SVG Animations update baseVal instead of animVal
https://bugs.webkit.org/show_bug.cgi?id=12437

Reviewed by Dirk Schulze.

Source/WebCore:

Cleanup animation code, remove last remaining crufts of the old setAttribute() animation model.
Now only two animation modes remain: animate SVG DOM animVal properties or CSS properties.

Stop caching base values per string in SMILTimeContainer, as it breaks additive="sum" for CSS
properties if the underlying base value is changed from the outside (eg. when calling
style.fontSize="20px", if font-size was 10px, and we're running an additive by-animation with 50px).

This requires us to cache the computed style of a SVGElement, without SMIL style property changes,
in SVGElementRareData, similar to how the computed style itself is cached in ElementRareData.
To be able to compute the base value for a CSS property at any time, we have to exclude any
previous animation effects residing in the SMIL animated style properties, per SMIL2/3 specs.

NOTE: This doesn't change or affect the way CSS Animations/Transitions are applied, we still

have some bugs in that area, but this patch doesn't address them. The idea is to only
remove the cache, to pave the way for future additive="sum" patches.

Tests: svg/animations/change-css-property-while-animating-fill-freeze.html

svg/animations/change-css-property-while-animating-fill-remove.html

  • dom/Element.cpp:

(WebCore::Element::recalcStyle):

  • dom/Node.h:
  • svg/SVGAnimateElement.cpp:

(WebCore::propertyTypesAreConsistent):
(WebCore::SVGAnimateElement::resetToBaseValue):
(WebCore::SVGAnimateElement::applyResultsToTarget):

  • svg/SVGAnimateElement.h:

(SVGAnimateElement):

  • svg/SVGAnimateMotionElement.cpp:

(WebCore::SVGAnimateMotionElement::resetToBaseValue):

  • svg/SVGAnimateMotionElement.h:

(SVGAnimateMotionElement):

  • svg/SVGAnimationElement.cpp:

(WebCore::applyCSSPropertyToTarget):
(WebCore::SVGAnimationElement::setTargetAttributeAnimatedCSSValue):

  • svg/SVGAnimationElement.h:
  • svg/SVGElement.cpp:

(WebCore::SVGElement::SVGElement):
(WebCore::SVGElement::willRecalcStyle):
(WebCore):
(WebCore::SVGElement::rareSVGData):
(WebCore::SVGElement::ensureRareSVGData):
(WebCore::SVGElement::computedStyle):
(WebCore::SVGElement::isAnimatableAttribute):

  • svg/SVGElement.h:

(SVGElement):

  • svg/SVGElementRareData.h:

(WebCore::SVGElementRareData::SVGElementRareData):
(WebCore::SVGElementRareData::ensureAnimatedSMILStyleProperties):
(WebCore::SVGElementRareData::destroyAnimatedSMILStyleProperties):
(WebCore::SVGElementRareData::overrideComputedStyle):
(WebCore::SVGElementRareData::setUseOverrideComputedStyle):

  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::updateAnimations):

  • svg/animation/SMILTimeContainer.h:

(SMILTimeContainer):

  • svg/animation/SVGSMILElement.h:

(SVGSMILElement):

LayoutTests:

Add tests that change the CSS property while an animation is running, finally fixed now for both SVG DOM & CSS animations.

  • svg/animations/change-css-property-while-animating-fill-freeze-expected.txt: Added.
  • svg/animations/change-css-property-while-animating-fill-freeze.html: Added.
  • svg/animations/change-css-property-while-animating-fill-remove-expected.txt: Added.
  • svg/animations/change-css-property-while-animating-fill-remove.html: Added.
  • svg/animations/resources/change-css-property-while-animating-fill-freeze.svg: Added.
  • svg/animations/resources/change-css-property-while-animating-fill-remove.svg: Added.
  • svg/animations/script-tests/change-css-property-while-animating-fill-freeze.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(executeTest):

  • svg/animations/script-tests/change-css-property-while-animating-fill-remove.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(executeTest):

6:13 AM Changeset in webkit [115422] by Philippe Normand
  • 2 edits in trunk/Tools

Unreviewed, GTK gardening.

  • Scripts/run-gtk-tests:

(TestRunner): Fix another typo. So easy to get confused by a Test
name and the actual name of the executable...

5:24 AM Changeset in webkit [115421] by bulach@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Disables a few webkit_unittests.
https://bugs.webkit.org/show_bug.cgi?id=85052

Unreviewed build fix.

  • tests/PopupMenuTest.cpp:

(WebKit::TEST_F):

5:02 AM Changeset in webkit [115420] by kkristof@inf.u-szeged.hu
  • 3 edits in trunk/Source/WebKit/qt

Move WebKit1 specific conversion of touch-events to WebKit1
https://bugs.webkit.org/show_bug.cgi?id=84951

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-27
Reviewed by Kenneth Rohde Christiansen.

Fix compile when touch-events are disabled.

  • WebCoreSupport/WebEventConversion.cpp:

(WebCore):

  • WebCoreSupport/WebEventConversion.h:

(WebCore):

4:51 AM Changeset in webkit [115419] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update.

  • platform/gtk/test_expectations.txt: Mark another http/inspector

test as crashing.

4:42 AM Changeset in webkit [115418] by Philippe Normand
  • 2 edits in trunk/Tools

Unreviewed, GTK gardening.

  • Scripts/run-gtk-tests:

(TestRunner): Skip failing WebKit2 API test.

3:07 AM Changeset in webkit [115417] by apavlov@chromium.org
  • 8 edits
    2 adds in trunk

Source/WebCore: Web Inspector: Implement the "Disable JavaScript" option in the settings dialog
(re-landing r115323 with a fixed test.)
https://bugs.webkit.org/show_bug.cgi?id=84946

Based on user actions in the Inspector frontend, InspectorPageAgent invokes Settings::setScriptEnabled()
for the associated page to switch the script execution therein.

Reviewed by Yury Semikhatsky.

Test: inspector/debugger/disable-script.html

  • inspector/Inspector.json:
  • inspector/InspectorPageAgent.cpp:

(PageAgentState):
(WebCore::InspectorPageAgent::enable):
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::getScriptExecutionStatus):
(WebCore):
(WebCore::InspectorPageAgent::setScriptExecutionDisabled):

  • inspector/InspectorPageAgent.h:
  • inspector/front-end/Settings.js:
  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):
(WebInspector.SettingsScreen.prototype.get _updateScriptDisabledCheckbox):
(WebInspector.SettingsScreen.prototype._javaScriptDisabledChanged):

  • inspector/front-end/inspector.js:

LayoutTests: Web Inspector: Implement the "Disable JavaScript" option in the settings dialog
https://bugs.webkit.org/show_bug.cgi?id=84946

Reviewed by Yury Semikhatsky.

  • inspector/debugger/disable-script-expected.txt: Added.
  • inspector/debugger/disable-script.html: Added.
2:59 AM Changeset in webkit [115416] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update.

  • platform/gtk/test_expectations.txt: Flag http test hitting an ASSERT.
2:47 AM Changeset in webkit [115415] by commit-queue@webkit.org
  • 11 edits in trunk

[EFL] DRT should support LayoutTestController's dumpResourceLoadCallbacks()
https://bugs.webkit.org/show_bug.cgi?id=81891

Patch by Christophe Dumez <Christophe Dumez> on 2012-04-27
Reviewed by Philippe Normand.

Source/WebKit/efl:

New "load,resource,finished", "load,resource,failed", and
"resource,response,received" signals were added to notify about different
resource load events. These additional signals are needed for proper
support of LayoutTestController's dumpResourceLoadCallbacks() in EFL's
DumpRenderTree.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::assignIdentifierToInitialRequest):
(WebCore::FrameLoaderClientEfl::dispatchDidReceiveResponse):
(WebCore::FrameLoaderClientEfl::dispatchDidFinishLoading):
(WebCore::FrameLoaderClientEfl::dispatchDidFailLoading):

  • ewk/ewk_frame.cpp:

(ewk_frame_response_received):
(ewk_frame_load_finished):
(ewk_frame_load_resource_finished):
(ewk_frame_load_resource_failed):
(ewk_frame_load_error):

  • ewk/ewk_frame.h:
  • ewk/ewk_private.h:
  • ewk/ewk_view.h:

Tools:

Implement support for LayoutTestController's
dumpResourceLoadCallbacks() in EFL's DumpRenderTree by catching new
ewk_view signals about resource loading and print out the expected
information. This allows for several test cases to be removed from the
skip list.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::createView):
(descriptionSuitableForTestResult):
(DumpRenderTreeChrome::onResponseReceived):
(DumpRenderTreeChrome::onResourceLoadFinished):
(DumpRenderTreeChrome::onResourceLoadFailed):
(DumpRenderTreeChrome::onNewResourceRequest):

  • DumpRenderTree/efl/DumpRenderTreeChrome.h:

(DumpRenderTreeChrome):

LayoutTests:

Unskip tests which depend on EFL's DumpRenderTree support for
LayoutTestController's dumpResourceLoadCallbacks(), now that it is
implemented.

  • platform/efl/Skipped:
2:16 AM Changeset in webkit [115414] by Philippe Normand
  • 2 edits in trunk/Tools

Unreviewed, GTK typo fix.

  • Scripts/run-gtk-tests:

(TestRunner): Fix-up skipped WebKit2 API test name TestWKConnection.

2:07 AM Changeset in webkit [115413] by bulach@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Update test expectation.
https://bugs.webkit.org/show_bug.cgi?id=85038

Unreviewed, chromium test_expectations update.

  • platform/chromium/test_expectations.txt:
1:42 AM PrefixedAPIs edited by sh4.seo@samsung.com
CSS Transitions (diff)
1:38 AM PrefixedAPIs edited by sh4.seo@samsung.com
CSS Animations (diff)
1:09 AM Changeset in webkit [115412] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update.

  • platform/gtk/test_expectations.txt: Fix expected results of

css2.1 results and remove non-existant fast/form test.

12:13 AM Changeset in webkit [115411] by Carlos Garcia Campos
  • 19 edits
    20 adds in trunk

[SOUP] Add a way to register custom uri schemes in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=84130

Reviewed by Martin Robinson.

.:

  • GNUmakefile.am: Add BUILDING_SOUP macro to compilation.

Source/WebKit2:

  • GNUmakefile.am: Add new files to compilation.
  • Platform/CoreIPC/MessageID.h: Add

MessageClassWebSoupRequestManager and
MessageClassWebSoupRequestManagerProxy message types to identify
WebSoupRequestManager messages.

  • Shared/API/c/WKBase.h: Include WKBaseSoup.h when building with

soup network backend.

  • Shared/API/c/soup/WKBaseSoup.h: Added.
  • Shared/APIObject.h: Add SoupRequestManager type when using soup.
  • UIProcess/API/C/WKAPICast.h: Include WKAPICastSoup.h when

building with soup network backend.

  • UIProcess/API/C/soup/WKAPICastSoup.h: Added.

(WebKit): Map WKSoupRequestManagerRef to
WebSoupRequestManagerProxy.

  • UIProcess/API/C/soup/WKContextSoup.cpp: Added.

(WKContextGetSoupRequestManager): Return WKSoupRequestManagerRef
associated to the context.

  • UIProcess/API/C/soup/WKContextSoup.h: Added.
  • UIProcess/API/C/soup/WKSoupRequestManager.cpp: Added.

(WKSoupRequestManagerGetTypeID): Return the
WebSoupRequestManagerProxy API type.
(WKSoupRequestManagerSetClient): Set the WKSoupRequestManagerClient.
(WKSoupRequestManagerRegisterURIScheme): Call
WebSoupRequestManagerProxy::registerURIScheme().
(WKSoupRequestManagerHandleURIRequest): Call
WebSoupRequestManagerProxy::handleURIRequest().

  • UIProcess/API/C/soup/WKSoupRequestManager.h: Added.
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext): Initialize
m_soupRequestManagerProxy when using soup.
(WebKit::WebContext::~WebContext): Invalidate and clear the
m_soupRequestManagerProxy when using soup.
(WebKit::WebContext::disconnectProcess): Invalidate the
m_soupRequestManagerProxy when using soup.
(WebKit::WebContext::didReceiveMessage): Forward the message to
m_soupRequestManagerProxy if it's a
MessageClassWebSoupRequestManagerProxy message.

  • UIProcess/WebContext.h:

(WebKit::WebContext::soupRequestManagerProxy): Return
m_soupRequestManagerProxy.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveMessage): Forward message to
the web context if it's a MessageClassWebSoupRequestManagerProxy
message.

  • UIProcess/soup/WebSoupRequestManagerClient.cpp: Added.

(WebKit::WebSoupRequestManagerClient::didReceiveURIRequest): Call
didReceiveURIRequest callback if it has an implementation.

  • UIProcess/soup/WebSoupRequestManagerClient.h: Added.
  • UIProcess/soup/WebSoupRequestManagerProxy.cpp: Added.

(WebKit::WebSoupRequestManagerProxy::create): Create a new
WebSoupRequestManagerProxy.
(WebKit::WebSoupRequestManagerProxy::WebSoupRequestManagerProxy):
(WebKit::WebSoupRequestManagerProxy::~WebSoupRequestManagerProxy):
(WebKit::WebSoupRequestManagerProxy::invalidate):
(WebKit::WebSoupRequestManagerProxy::initializeClient):
(WebKit::WebSoupRequestManagerProxy::didReceiveMessage):
(WebKit::WebSoupRequestManagerProxy::registerURIScheme): Send
RegisterURIScheme message to the WebProcess to register the given
URI scheme.
(WebKit::WebSoupRequestManagerProxy::handleURIRequest): Send
HandleURIRequest message to the WebProcess with the given data and
data type.
(WebKit::WebSoupRequestManagerProxy::didReceiveURIRequest): Call
didReceiveURIRequest callback to allow the user to handle the
request.

  • UIProcess/soup/WebSoupRequestManagerProxy.h: Added.
  • UIProcess/soup/WebSoupRequestManagerProxy.messages.in: Added.
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess): Initialize m_soupRequestManager
when using soup.
(WebKit::WebProcess::didReceiveMessage): Forward the message to
m_soupRequestManager if it's a MessageClassWebSoupRequestManager
message.

  • WebProcess/WebProcess.h:

(WebKit::WebProcess::soupRequestManager): Return m_soupRequestManager.

  • WebProcess/soup/WebKitSoupRequestGeneric.cpp: Added.

(webkitSoupRequestGenericFinalize):
(webkit_soup_request_generic_init):
(webkitSoupRequestGenericSendAsync): Create a GSimpleAsyncResult
to handle the request and pass it to the WebSoupRequestManager.
(webkitSoupRequestGenericSendFinish): Finish the async operation
started by webkitSoupRequestGenericSendAsync() and return the
contents of the request as returned by WebSoupRequestManager.
(webkitSoupRequestGenericGetContentLength): Get the request
contents length.
(webkitSoupRequestGenericGetContentType): Get the request mime
type.
(webkit_soup_request_generic_class_init):
(webkitSoupRequestGenericSetContentLength): Set the request
contents length.
(webkitSoupRequestGenericSetContentType): Set the request mime
type.

  • WebProcess/soup/WebKitSoupRequestGeneric.h: Added.
  • WebProcess/soup/WebSoupRequestManager.cpp: Added.

(WebKit::generateSoupRequestID): Helper function to generate a
unique request identifier.
(WebKit::WebSoupRequestManager::WebSoupRequestManager):
(WebKit::WebSoupRequestManager::~WebSoupRequestManager):
(WebKit::WebSoupRequestManager::didReceiveMessage):
(WebKit::WebSoupRequestManager::registerURIScheme): Add the scheme
to the schemes array and add a new WebKitSoupRequestGeneric
feature with the new scheme list to the SoupRequester feature.
(WebKit::WebSoupRequestManager::handleURIRequest): Complete the
async operation by creating a GInputStream with the request data,
or setting an error in case of failure.
(WebKit::WebSoupRequestManager::send): Send DidReceiveURIRequest
message to the UI process.
(WebKit::WebSoupRequestManager::finish): Return the GInputStream
containing the request data.

  • WebProcess/soup/WebSoupRequestManager.h: Added.
  • WebProcess/soup/WebSoupRequestManager.messages.in: Added.

Source/WTF:

Add GPtrArray template to be able to use GRefPtr with GPtrArrays.

  • wtf/gobject/GRefPtr.cpp:

(WTF::refGPtr):
(WTF):
(WTF::derefGPtr):

  • wtf/gobject/GRefPtr.h:

(WTF):

  • wtf/gobject/GTypedefs.h:

Tools:

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_identifier_name_in_declaration): Add webkit_soup prefix to
the list of exceptions to the underscores in identifiers rule.

12:05 AM Changeset in webkit [115410] by rniwa@webkit.org
  • 5 edits in trunk/Tools

Extract PerfTestFactory
https://bugs.webkit.org/show_bug.cgi?id=83944

Reviewed by Dirk Pranke.

Extracted PerfTestFactory out of PerfTest. This class creates appropriate PerfTest object given
a test name and a path. Also removed dirname from the constructors of PerfTest and its subclasses.

Also added simple test cases to sanity check PerfTestFactory.

  • Scripts/webkitpy/performance_tests/perftest.py:

(PerfTest.init):
(PerfTest.test_name):
(ChromiumStylePerfTest.init):
(PageLoadingPerfTest.init):
(PageLoadingPerfTest.run):
(PerfTestFactory):
(PerfTestFactory.create_perf_test):

  • Scripts/webkitpy/performance_tests/perftest_unittest.py:

(MainTest.test_parse_output):
(MainTest.test_parse_output_with_failing_line):
(TestPageLoadingPerfTest.test_run):
(TestPageLoadingPerfTest.test_run_with_bad_output):
(TestPerfTestFactory):
(TestPerfTestFactory.test_regular_test):
(TestPerfTestFactory.test_inspector_test):
(TestPerfTestFactory.test_page_loading_test):

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner):
(PerfTestsRunner._collect_tests):

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(run_test):
(_tests_for_runner):

Apr 26, 2012:

11:45 PM Changeset in webkit [115409] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION (r94497): Pressing Command+A when inline (Marked Text) is not empty will clean whole content
https://bugs.webkit.org/show_bug.cgi?id=84501

Reviewed by Alexey Proskuryakov.

Source/WebCore:

The bug was caused by setComposition, which is called by cancelComposition, deleting the contents when
the passed text is empty. Fixed it by not deleting text when canceling compositions. This is okay because
as the comment above the line suggests, this particular call to TypingCommand::deleteSelection is only useful
when the confirmed text is empty and the composition text had previously been non-empty.

Test: editing/input/select-all-clear-input-method.html

  • editing/Editor.cpp:

(WebCore::Editor::setComposition):

LayoutTests:

Add a regression test for selecting all when there is a composition text.

  • editing/input/select-all-clear-input-method-expected.txt: Added.
  • editing/input/select-all-clear-input-method.html: Added.
11:11 PM Changeset in webkit [115408] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed morning gardening, skip a new failing test.

  • platform/qt/Skipped:
9:04 PM Changeset in webkit [115407] by keishi@webkit.org
  • 4 edits
    2 adds in trunk

datalist: Form control in a <datalist> should be barred from constraint validation
https://bugs.webkit.org/show_bug.cgi?id=84359

Source/WebCore:

http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html#the-datalist-element
According to this, if an element has a datalist element ancestor, it is barred from constraint validation.

Reviewed by Kent Tamura.

Test: fast/forms/datalist/datalist-child-validation.html

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::HTMLFormControlElement):
(WebCore::HTMLFormControlElement::updateAncestors): Updates the ancestor information.
(WebCore::HTMLFormControlElement::insertedInto): Invalidates the ancestor information and calls setNeedsWillValidateCheck
(WebCore::HTMLFormControlElement::removedFrom): Invalidates the ancestor information and calls setNeedsWillValidateCheck
(WebCore::HTMLFormControlElement::disabled):
(WebCore::HTMLFormControlElement::recalcWillValidate): Returns false if element has a datalist ancestor.
(WebCore::HTMLFormControlElement::setNeedsWillValidateCheck): Check if ancestor information is valid too.

  • html/HTMLFormControlElement.h:

(HTMLFormControlElement):

LayoutTests:

Reviewed by Kent Tamura.

  • fast/forms/datalist/datalist-child-validation-expected.txt: Added.
  • fast/forms/datalist/datalist-child-validation.html: Added. Tests that willValidate changes from false to true when we move the element out of the datalist.
8:51 PM Changeset in webkit [115406] by thakis@chromium.org
  • 2 edits in trunk/Source/WTF

Don't define WTF_COMPILER_SUPPORTS_CXX_NULLPTR twice when building with clang on windows.
https://bugs.webkit.org/show_bug.cgi?id=85018

Reviewed by Anders Carlsson.

Clang sets _MSC_VER when compiling for a -pc-win32 target (just like it sets GNUC on unix).
As a result, WTF_COMPILER_SUPPORTS_CXX_NULLPTR gets currently set twice, once for clang and
once for _MSC_VER. Guard the second instance with !COMPILER(CLANG). This matches the gcc code
for WTF_COMPILER_SUPPORTS_CXX_NULLPTR in the same file.

  • wtf/Compiler.h:
8:35 PM Changeset in webkit [115405] by enne@google.com
  • 3 edits in trunk/Source/WebCore

[chromium] Remove unused CCLayerImpl::debugID()
https://bugs.webkit.org/show_bug.cgi?id=85019

Reviewed by James Robinson.

CCLayerSorter used debugID() but it was never set anywhere. Change
the CCLayerSorter LOG messages to use id(), which does get set.

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerSorter.cpp:

(WebCore::CCLayerSorter::createGraphNodes):
(WebCore::CCLayerSorter::createGraphEdges):
(WebCore::CCLayerSorter::sort):

8:32 PM Changeset in webkit [115404] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Fix C++ language use.
https://bugs.webkit.org/show_bug.cgi?id=85015

Reviewed by James Robinson.

Even though MSVC allows it, a sizeof followed by a non-parenthesized
typename is not valid C++.

No functionality change.

  • rendering/RenderThemeChromiumWin.cpp:

(WebCore):
(WebCore::getNonClientMetrics):

8:22 PM Changeset in webkit [115403] by jamesr@google.com
  • 18 edits in trunk/Source

[chromium] Move ProgramBinding definitions to LayerRendererChromium and normalize naming
https://bugs.webkit.org/show_bug.cgi?id=84808

Reviewed by Adrienne Walker.

Source/WebCore:

The GL programs used are logically part of LayerRendererChromium and not something specific to a layer type,
since a different renderer would want to use a different thing to render the same layer types. This moves all of
the ProgramBinding definitions into LayerRendererChromium and gives them consistent names. With the exception of
CCRenderSurface (noted by an inline comment), these programs are private to LRC.

This patch also deduplicates programs a bit:
1.) Video's NativeTexture and RGBA programs were the same thing, folded.
2.) The TexStretch and TexTransform shaders are basically the same thing, folded together.

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawCheckerboardQuad):
(WebCore::LayerRendererChromium::drawDebugBorderQuad):
(WebCore::LayerRendererChromium::drawSolidColorQuad):
(WebCore::LayerRendererChromium::drawTileQuad):
(WebCore::LayerRendererChromium::drawYUV):
(WebCore::LayerRendererChromium::drawRGBA):
(WebCore::LayerRendererChromium::drawNativeTexture2D):
(WebCore::LayerRendererChromium::drawStreamTexture):
(WebCore::LayerRendererChromium::drawTextureQuad):
(WebCore::LayerRendererChromium::drawHeadsUpDisplay):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::tileCheckerboardProgram):
(WebCore::LayerRendererChromium::solidColorProgram):
(WebCore::LayerRendererChromium::headsUpDisplayProgram):
(WebCore::LayerRendererChromium::renderSurfaceProgram):
(WebCore::LayerRendererChromium::renderSurfaceProgramAA):
(WebCore::LayerRendererChromium::renderSurfaceMaskProgram):
(WebCore::LayerRendererChromium::renderSurfaceMaskProgramAA):
(WebCore::LayerRendererChromium::tileProgram):
(WebCore::LayerRendererChromium::tileProgramOpaque):
(WebCore::LayerRendererChromium::tileProgramAA):
(WebCore::LayerRendererChromium::tileProgramSwizzle):
(WebCore::LayerRendererChromium::tileProgramSwizzleOpaque):
(WebCore::LayerRendererChromium::tileProgramSwizzleAA):
(WebCore::LayerRendererChromium::textureProgramFlip):
(WebCore::LayerRendererChromium::textureTexRectProgram):
(WebCore::LayerRendererChromium::textureTexRectProgramFlip):
(WebCore::LayerRendererChromium::videoRGBAProgram):
(WebCore::LayerRendererChromium::videoYUVProgram):
(WebCore::LayerRendererChromium::videoStreamTextureProgram):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:

(WebCore):
(LayerRendererChromium):

  • platform/graphics/chromium/ShaderChromium.cpp:
  • platform/graphics/chromium/ShaderChromium.h:
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h:

(CCHeadsUpDisplay):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::copyTextureToFramebuffer):
(WebCore::CCRenderSurface::drawLayer):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(CCRenderSurface):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
  • platform/graphics/chromium/cc/CCTextureLayerImpl.h:

(CCTextureLayerImpl):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:
  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:

(CCTiledLayerImpl):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:

(WebCore):
(CCVideoLayerImpl):

Source/WebKit/chromium:

Add some includes needed by this test that were previously picked up by upstream headers.

  • tests/CCLayerTreeHostImplTest.cpp:
8:16 PM Changeset in webkit [115402] by noam.rosenthal@nokia.com
  • 4 edits in trunk/Source/WebKit2

[Qt][WK2] A GraphicsSurface instance is created with every update
https://bugs.webkit.org/show_bug.cgi?id=85014

Reviewed by Kenneth Rohde Christiansen.

Keep a copy of the GraphicsSurface in the UI process, and reuse it for
subsequent updates. This ensure that the texture and other data associated
with the GraphicsSurface does not need to be reconstructed.

  • Shared/ShareableSurface.h:

(Handle):
(WebKit::ShareableSurface::Handle::graphicsSurfaceToken):

  • UIProcess/LayerTreeHostProxy.cpp:

(WebKit::LayerTreeHostProxy::updateTileForLayer):

  • UIProcess/LayerTreeHostProxy.h:

(LayerTreeHostProxy):

8:08 PM Changeset in webkit [115401] by tonikitoo@webkit.org
  • 1 edit in trunk/Source/WebCore/platform/ScrollView.cpp

Unreviewed amend to bug 84873 (r115345).

  • platform/ScrollView.cpp:

(WebCore::ScrollView::scrollSize):

7:44 PM Changeset in webkit [115400] by isherman@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Security: Autofill info can be captured by innocuous social engineering
Prevent users from interacting with invisible popups rendered outside the main frame's contents view.
https://bugs.webkit.org/show_bug.cgi?id=84420
https://code.google.com/p/chromium/issues/detail?id=122925

Reviewed by Kent Tamura.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::popupOpened): Hide popups rendered outside the main frame's contents view.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::applyAutofillSuggestions): Fix up order of operations to support immediately hiding a popup if it would not be visible

7:38 PM Changeset in webkit [115399] by rniwa@webkit.org
  • 8 edits in branches/chromium/1084

Source/WebCore: Merge r115227, r115244, and r115302.

REGRESSION(r112177): listStyleType CSS property gets converted into listStyle
https://bugs.webkit.org/show_bug.cgi?id=83026

Reviewed by Darin Adler.

Fixed the bug by not using shorthand notations when some values are missing.

However, we still want to return a value when shorthand border property is explicitly
requested so extract borderPropertyValue with a flag to support both behaviors.

  • css/StylePropertySet.cpp:

(WebCore::borderPropertyValue): Extracted from getPropertyValue.
(WebCore::StylePropertySet::getPropertyValue):
(WebCore::StylePropertySet::get4Values): Don't return values when priority don't match.
(WebCore::StylePropertySet::getShorthandValue):
(WebCore::StylePropertySet::getCommonValue): Don't return null string for initial values
to disambiguate missing values and "initial" in getPropertyValue. Also check propriety.
(WebCore::StylePropertySet::asText): Support emitting border-width, border-style, and
border-color when border doesn't work but the former properties do.

LayoutTests: REGRESSION(r112177): listStyleType CSS property gets converted into listStyle
https://bugs.webkit.org/show_bug.cgi?id=83026

Reviewed by Darin Adler.

Added test cases to cssText-shorthand.html and rebaselined some tests.

  • fast/css/cssText-shorthand-expected.txt:
  • fast/css/cssText-shorthand.html: Added more test cases.
  • fast/css/remove-shorthand-expected.txt: Correctly adds both border-width and border-style

when border-color is missing.

  • printing/page-rule-css-text-expected.txt: Correctly uses border-width instead of border.
7:35 PM Changeset in webkit [115398] by jpfau@apple.com
  • 3 edits
    2 adds in trunk

Invalid cast in WebCore::HTMLCollection::isAcceptableElement
https://bugs.webkit.org/show_bug.cgi?id=84626

Reviewed by Darin Adler.

Source/WebCore:

Check if the object is an HTMLElement before casting.

Test: fast/dom/htmlcollection-non-html.html

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::isAcceptableElement):

LayoutTests:

Add tests to make sure only HTML elements are present in most HTMLCollection objects.

  • fast/dom/htmlcollection-non-html-option-expected.txt: Added.
  • fast/dom/htmlcollection-non-html.html: Added.
7:17 PM Changeset in webkit [115397] by danakj@chromium.org
  • 5 edits in trunk/Source

[chromium] Some background filters require inflating damage on the surface behind them
https://bugs.webkit.org/show_bug.cgi?id=84479

Reviewed by Adrienne Walker.

Source/WebCore:

A layer with a background blur will expand the damage from pixels in the
surface below it. We extend the damage tracker to expand damage in a
surface below such layers.

Unit test: CCDamageTrackerTest.verifyDamageForBackgroundBlurredChild

  • platform/graphics/chromium/cc/CCDamageTracker.cpp:

(WebCore::expandPixelOutsetsWithFilters):
(WebCore):
(WebCore::expandDamageRectInsideRectWithFilters):
(WebCore::expandDamageRectWithFilters):
(WebCore::CCDamageTracker::updateDamageTrackingState):
(WebCore::CCDamageTracker::trackDamageFromActiveLayers):

  • platform/graphics/chromium/cc/CCDamageTracker.h:

(CCDamageTracker):

Source/WebKit/chromium:

  • tests/CCDamageTrackerTest.cpp:

(WebKitTests::TEST_F):
(WebKitTests):

6:40 PM Changeset in webkit [115396] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Improve compositing logging output
https://bugs.webkit.org/show_bug.cgi?id=85010

Reviewed by Dean Jackson.

In the compositing log channel output, indent the layers
based on z-order tree depth. Tabulate the summary, and
show obligate and secondary backing store area separately.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateClipRects):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::logLayerInfo):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
(WebCore::RenderLayerCompositor::updateLayerTreeGeometry):
(WebCore::RenderLayerCompositor::reasonForCompositing):

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

6:38 PM Changeset in webkit [115395] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r115163): Unable to scroll article body with trackpad on altdevblogaday.com blog post
https://bugs.webkit.org/show_bug.cgi?id=85024
<rdar://problem/11330758>

Reviewed by Sam Weinig.

Fix broken logic in canHaveScrollbars.

  • page/scrolling/ScrollingTreeNode.h:

(WebCore::ScrollingTreeNode::canHaveScrollbars):

6:24 PM Changeset in webkit [115394] by jamesr@google.com
  • 9 edits
    2 copies in trunk/Source/WebCore

[chromium] Use different CCDrawQuad types for textures vs IOSurfaces
https://bugs.webkit.org/show_bug.cgi?id=84811

Reviewed by Adrienne Walker.

IOSurface and texture backed layers share few properties (only the flipped bool), so it doesn't make a lot of
sense for them to use the same CCDrawQuad type for both. This splits IOSurfaces out to a dedicated quad type to
make it easier to understand which bits of state apply to each.

The logical next step after this is to split the layer type as well, but that will be awkward until bug 84808 is
resolved.

  • WebCore.gypi:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawQuad):
(WebCore::LayerRendererChromium::drawTextureQuad):
(WebCore):
(WebCore::LayerRendererChromium::drawIOSurfaceQuad):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

  • platform/graphics/chromium/cc/CCDrawQuad.cpp:

(WebCore::CCDrawQuad::toIOSurfaceDrawQuad):
(WebCore):

  • platform/graphics/chromium/cc/CCDrawQuad.h:

(WebCore):
(CCDrawQuad):

  • platform/graphics/chromium/cc/CCIOSurfaceDrawQuad.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCTextureDrawQuad.cpp.

(WebCore):
(WebCore::CCIOSurfaceDrawQuad::create):
(WebCore::CCIOSurfaceDrawQuad::CCIOSurfaceDrawQuad):

  • platform/graphics/chromium/cc/CCIOSurfaceDrawQuad.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCTextureDrawQuad.h.

(WebCore):
(CCIOSurfaceDrawQuad):
(WebCore::CCIOSurfaceDrawQuad::flipped):
(WebCore::CCIOSurfaceDrawQuad::ioSurfaceSize):
(WebCore::CCIOSurfaceDrawQuad::ioSurfaceTextureId):

  • platform/graphics/chromium/cc/CCTextureDrawQuad.cpp:

(WebCore::CCTextureDrawQuad::create):
(WebCore::CCTextureDrawQuad::CCTextureDrawQuad):

  • platform/graphics/chromium/cc/CCTextureDrawQuad.h:

(CCTextureDrawQuad):

  • platform/graphics/chromium/cc/CCTextureLayerImpl.cpp:

(WebCore::CCTextureLayerImpl::appendQuads):

6:06 PM Changeset in webkit [115393] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Cleanup WebMediaPlayer enum values that didn't match Chromium style guidelines
https://bugs.webkit.org/show_bug.cgi?id=84998

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-04-26
Reviewed by Darin Fisher.

  • public/WebMediaPlayer.h:

(WebKit::WebMediaPlayer::generateKeyRequest):
(WebKit::WebMediaPlayer::addKey):
(WebKit::WebMediaPlayer::cancelKeyRequest):

6:03 PM Changeset in webkit [115392] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

Use WebKit types for the cache of ObjcClass::methodsNamed()
https://bugs.webkit.org/show_bug.cgi?id=85012

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-26
Reviewed by Geoffrey Garen.

This patch redefines the method cache ObjcClass to avoid memory allocations in the case of positive match.

Instead of using the converted name as the key, the original identifier string is used. This shortcuts
all the other operations when there is a match.

A side effect is a method can appear multiple times in the cache if it is invoked with different names using
the escape character "$". An attaquer could bloat the cache with a few hundreds strings.
In the common case, having each name mapped is an improvment.

  • bridge/objc/objc_class.h:

(ObjcClass):

  • bridge/objc/objc_class.mm:

(JSC::Bindings::ObjcClass::ObjcClass):
(JSC::Bindings::ObjcClass::methodsNamed):

5:51 PM Changeset in webkit [115391] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Allocating WeakImpl should not trigger GC, as that makes the world very tricksy.
https://bugs.webkit.org/show_bug.cgi?id=85020

Reviewed by Gavin Barraclough.

Now in the event that we are unable to find an allocator for a new handle, just
add a new allocator rather than trying to recover "dead" handles through a GC.

Find allocator is now much simpler, and addAllocator directly reports the
increased memory usage to the heap without causing any GC to happen immediately.

  • heap/WeakSet.cpp:

(JSC::WeakSet::findAllocator):
(JSC::WeakSet::addAllocator):

5:49 PM Changeset in webkit [115390] by benjamin@webkit.org
  • 2 edits in trunk/LayoutTests

Skip the new ObjC tests for WebKit2

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-26
Reviewed by Andreas Kling.

WebKitTestRunner doesn't have objCController, the new tests for
the Objective-C bindings should be skipped on WebKit2.

  • platform/wk2/Skipped:
5:48 PM Changeset in webkit [115389] by ojan@chromium.org
  • 3 edits in trunk/Source/WebCore

Delete dead code in Arena.h/cpp
https://bugs.webkit.org/show_bug.cgi?id=84997

Reviewed by Eric Seidel.

Also cleaned up some style issues. Renamed some single-letter variable names.
Avoided anything other than totally trivial style changes to be 100% sure
that there is no change in behavior.

No new tests. There's no non-style code changes except inlining CLEAR_UNUSED
and CLEAR_ARENA.

  • platform/Arena.cpp:

(WebCore):
(WebCore::CeilingLog2):
(WebCore::InitArenaPool):
(WebCore::ArenaAllocate):
(WebCore::FreeArenaList):
(WebCore::FinishArenaPool):

  • platform/Arena.h:

(WebCore):

5:07 PM Changeset in webkit [115388] by oliver@apple.com
  • 16 edits in trunk

Remove RegisterFile::end()/m_end
https://bugs.webkit.org/show_bug.cgi?id=85011

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Get rid of end() and m_end from RegisterFile. From now on
we only care about the end of the committed region when calling
code. When re-entering the VM we now plant the new CallFrame
immediately after whatever the current topCallFrame is. This
required adding a routine to CallFrame to determine exactly what
we should be doing (in the absence of an existing CallFrame, we
can't reason about the frameExtent() so we check for that).

This also now means that the GC only marks the portion of the
RegisterFile that is actually in use, and that VM re-entry doesn't
exhaust the RegisterFile as rapidly.

  • dfg/DFGOperations.cpp:
  • heap/Heap.cpp:

(JSC::Heap::getConservativeRegisterRoots):
(JSC::Heap::markRoots):

  • interpreter/CallFrame.h:

(JSC::ExecState::init):
(JSC::ExecState::startOfReusableRegisterFile):
(ExecState):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::privateExecute):

  • interpreter/Interpreter.h:

(JSC::Interpreter::execute):

  • interpreter/RegisterFile.cpp:

(JSC::RegisterFile::growSlowCase):
(JSC::RegisterFile::gatherConservativeRoots):

  • interpreter/RegisterFile.h:

(JSC::RegisterFile::commitEnd):
(JSC::RegisterFile::addressOfEnd):
(RegisterFile):
(JSC::RegisterFile::RegisterFile):
(JSC::RegisterFile::shrink):
(JSC::RegisterFile::grow):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):
(JSC::jitCompileFor):
(JSC::lazyLinkFor):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::handleHostCall):

  • llint/LowLevelInterpreter.asm:
  • runtime/CommonSlowPaths.h:

(JSC::CommonSlowPaths::arityCheckFor):

LayoutTests:

Now that we recurse on the top of the used portion of the stack we
can provide an error message even when the stack is completely full.

Also made sure we were consistent in which callframe we used when
creating stack overflow errors.

  • fast/js/global-recursion-on-full-stack-expected.txt:
  • fast/js/stack-trace-expected.txt:
5:00 PM Changeset in webkit [115387] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/css/CSSPrimitiveValue.h

Removing bounds checking in float case of roundForImpreciseConversion (numeric_limits<float>::min() is positive, and bounds checking isn't meaningful here).

5:00 PM Changeset in webkit [115386] by shawnsingh@chromium.org
  • 6 edits
    1 add in trunk/Source

Source/WebCore: Re-implement backFaceVisibility to avoid dealing with perspective w < 0 problem
https://bugs.webkit.org/show_bug.cgi?id=84059

Reviewed by Adrienne Walker.

Unit tests added to CCMathUtilTest.cpp.

This patch changes the implementation of backFaceIsVisible so that
it doesn't need to deal with the w < 0 problem from of perspective
projections. Instead, it is equally correct to simply use the
inverse-transpose of the matrix, and quickly check the third row,
third column element. Additionally, it was appropriate to move
this function into TransformationMatrix itself.

Making this change fixes some issues related to disappearing
layers in Chromium (where the compositor incorrectly thought that
the back face was visible, and skipped the layer).

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateVisibleLayerRect):
(WebCore::layerShouldBeSkipped):

  • platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::TransformationMatrix::isBackFaceVisible):
(WebCore):

  • platform/graphics/transforms/TransformationMatrix.h:

(TransformationMatrix):

Source/WebKit/chromium: [chromium] re-implement backFaceVisibility to avoid dealing with perspective w<0 problem
https://bugs.webkit.org/show_bug.cgi?id=84059

Reviewed by Adrienne Walker.

  • WebKit.gypi:
  • tests/CCMathUtilTest.cpp: Added.

(WebCore):
(WebCore::TEST):

4:03 PM Changeset in webkit [115385] by mrobinson@webkit.org
  • 17 edits
    1 copy
    2 adds in trunk/Source

[Cairo] Wrap cairo surfaces in a class when storing native images
https://bugs.webkit.org/show_bug.cgi?id=83611

Reviewed by Alejandro G. Castro.

Source/WebCore:

No new tests. This is just a refactoring. This shouldn't change
functionality.

Added class that wraps Cairo images surfaces to serve as the "native image"
type for the Cairo platform. This will allow the addition of caching resampled
images as well as versions of the image for non-image Cairo backends. Also
split out BitmapImageCairo.cpp from ImageCairo.cpp since these classes are
defined in two headers.

  • GNUmakefile.list.am: Added new files.
  • platform/graphics/BitmapImage.h: Added a factory method that takes an image surface to

reduce code churn.

  • platform/graphics/ImageSource.h: NativeImagePtr is now NativeImageCairo*.

(WebCore):

  • platform/graphics/cairo/BitmapImageCairo.cpp: Copied from Source/WebCore/platform/graphics/cairo/ImageCairo.cpp.
  • platform/graphics/cairo/GraphicsContext3DCairo.cpp: Updated to reflect use of NativeImageCairo.
  • platform/graphics/cairo/ImageCairo.cpp: Ditto.
  • platform/graphics/cairo/NativeImageCairo.cpp: Added.
  • platform/graphics/cairo/NativeImageCairo.h: Added.
  • platform/graphics/cairo/PatternCairo.cpp: Updated to reflect use of NativeImageCairo.
  • platform/graphics/gtk/ImageGtk.cpp: Ditto.
  • platform/image-decoders/cairo/ImageDecoderCairo.cpp: Ditto.

Source/WebKit/efl:

  • ewk/ewk_history.cpp: Updated to reflect addition of NativeImageCario.
  • ewk/ewk_settings.cpp: Ditto.

Source/WebKit2:

  • Shared/gtk/ArgumentCodersGtk.cpp: Updated to reflect the addition of NativeImageCairo.
3:57 PM Changeset in webkit [115384] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/css/CSSPrimitiveValue.h

Fixing roundForImpreciseConversion for the float case with template specialization.

3:53 PM Changeset in webkit [115383] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/WebCore

[GTK] Massive media tests failures since r115288
https://bugs.webkit.org/show_bug.cgi?id=84950

Reviewed by Filip Pizlo.

No new tests.

Since the "cross-platform" WebCore timer is at too high of a level in terms of the layers
of WebKit for JSC to use, we are not currently able to use it in JSC, thus only those
platforms that support CoreFoundation can currently take advantage of the new and improved
GC activity timer. We've restored the old code paths for those platforms that don't have
CF so that they will at least have the same behavior as before when calling garbageCollectSoon.

  • bindings/js/GCController.cpp: Added back the old WebCore timer along with some

if-defs that do away with the WebCore timer on platforms that support CoreFoundation.
(WebCore::GCController::GCController):
(WebCore::GCController::garbageCollectSoon):
(WebCore):
(WebCore::GCController::gcTimerFired):

  • bindings/js/GCController.h: Ditto.

(GCController):

3:42 PM Changeset in webkit [115382] by tomz@codeaurora.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening

  • platform/qt/test_expectations.txt:
3:36 PM Changeset in webkit [115381] by adamk@chromium.org
  • 2 edits in trunk/Source/WebCore

Don't include V8Proxy.h in ScriptValue.h when V8GCController is all that's required
https://bugs.webkit.org/show_bug.cgi?id=84986

Reviewed by Kentaro Hara.

This makes it easier to include ScriptValue.h since it greatly reduces
that header's dependencies.

  • bindings/v8/ScriptValue.h: Changed to include just V8GCController.h and

removed comment which is redundant with explicit V8GCController references nearby.

3:34 PM Changeset in webkit [115380] by commit-queue@webkit.org
  • 5 edits in trunk

Source/WebCore: Fix missing sourceState change on MEDIA_ERR_SOURCE_NOT_SUPPORTED error.
https://bugs.webkit.org/show_bug.cgi?id=84996

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-04-26
Reviewed by Eric Carlson.

No new tests. http/tests/media/media-source/webm/video-media-source-errors.html was updated to verify that webkitSourceState is always SOURCE_CLOSED when the onerror event fires.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::noneSupported):

LayoutTests: Updating MediaSource layout test to verify that webkitSourceState is always
SOURCE_CLOSED when an error occurs.

Minor style fixes and informative console messages were also added.
https://bugs.webkit.org/show_bug.cgi?id=84996

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-04-26
Reviewed by Eric Carlson.

  • http/tests/media/media-source/webm/video-media-source-errors-expected.txt:
  • http/tests/media/media-source/webm/video-media-source-errors.html:
3:26 PM Changeset in webkit [115379] by Antti Koivisto
  • 10 edits in trunk/Source/WebCore

Cache parsed stylesheets
https://bugs.webkit.org/show_bug.cgi?id=85004

Reviewed by Andreas Kling.

CSS parsing is 1-2% of WebKit CPU usage on average pages, more on sites with large stylesheets.
We currently reparse all stylesheets from source text when they are encountered again. In many
browsing scenarios we can eliminate lot of this by caching the parsed stylesheets. For example
it is very common for subpages of a site to share the stylesheets.

This patch enables memory caching for stylesheet loaded using the <link> element. Only stylesheets
that have no import rules are cacheable for now.

Cached stylesheets are copied on restore so there is no sharing (and no memory wins) yet.
In the future we will also be able to share the actual data structures between pages for
significant memory savings.

After browsing around for a while <5% of the memory cache data was in parsed stylesheets so this
does not bloat the cache significantly.

  • css/CSSStyleSheet.cpp:

(WebCore):
(WebCore::StyleSheetInternal::estimatedSizeInBytes):

Estimate stylesheet size so we can handle decoded data pruning correctly.

  • css/CSSStyleSheet.h:

(StyleSheetInternal):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::averageSizeInBytes):
(WebCore):

  • css/StylePropertySet.h:

(StylePropertySet):

  • css/StyleRule.cpp:

(WebCore::StyleRule::averageSizeInBytes):
(WebCore):

  • css/StyleRule.h:

(StyleRule):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::setCSSStyleSheet):

Save and restore parsed stylesheet. The current CSS parse context must be identical to the cached
stylesheets. This ensures that the parsing results would be identical.

  • loader/cache/CachedCSSStyleSheet.cpp:

(WebCore):
(WebCore::CachedCSSStyleSheet::destroyDecodedData):
(WebCore::CachedCSSStyleSheet::restoreParsedStyleSheet):
(WebCore::CachedCSSStyleSheet::saveParsedStyleSheet):

  • loader/cache/CachedCSSStyleSheet.h:


The parsed stylesheet cache is considered decoded data, similar to the image bitmaps. It uses the
same mechanism for pruning.

(WebCore):
(CachedCSSStyleSheet):

3:25 PM Changeset in webkit [115378] by mrobinson@webkit.org
  • 4 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore

[Gtk] WebKitGTK+ 1.8.1 fails to build when disabling HTML Video feature
https://bugs.webkit.org/show_bug.cgi?id=84838

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-04-26
Reviewed by Martin Robinson.

Wrap WebCore objects and functions in GObject property setters and getters
with conditional guards (if present) to avoid compilation errors.

No new tests - changes covered by existing bindings tests.

  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateProperty):
(GenerateProperties):

  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp: Rebaseline.

(webkit_dom_test_interface_set_property):
(webkit_dom_test_interface_get_property):

  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp: Ditto.

(webkit_dom_test_serialized_script_value_interface_get_property):

3:10 PM Changeset in webkit [115377] by dpranke@chromium.org
  • 7 edits in trunk/Tools

nrwt: clean up server process, webkit driver so chromium can use it
https://bugs.webkit.org/show_bug.cgi?id=84910

Reviewed by Ojan Vafai.

This change moves the "sample a process" logic out of
server_process.py and into a port-specific class (where really
only the mac has an implementation), and also preemptively kills
DRT when a test times out in WebKitDriver (rather than waiting through the
additional delays caused by calling stop() when we would want to
restart the driver generically in worker.py).

These changes will make it possible for the chromium port to
switch over to the stock WebKitDriver implementation, at least
on mac and linux.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.sample_process):

  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.sample_process):

  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:

(test_helper_fails_to_stop):
(test_sample_process):
(test_sample_process.logging_run_command):
(test_sample_process_throws_exception):
(test_sample_process_throws_exception.throwing_run_command):

  • Scripts/webkitpy/layout_tests/port/server_process.py:

(ServerProcess._log):
(ServerProcess._handle_timeout):
(ServerProcess.stop):
(ServerProcess):
(ServerProcess.kill): Here we add a method to immediately stop
the process rather than trying to shut it down cleanly.

  • Scripts/webkitpy/layout_tests/port/server_process_unittest.py:

(TestServerProcess.test_broken_pipe):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitDriver.run_test): Fix an issue where we weren't passing
along any per-test args (only needed for Chromium, but still).
Also, kill the driver immediately if we time out a test.

3:03 PM Changeset in webkit [115376] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

A TileCache should never outlive its WebTileCacheLayer
https://bugs.webkit.org/show_bug.cgi?id=85008
<rdar://problem/11141172>

Reviewed by Andreas Kling.

Since WebTileCacheLayer objects can be destroyed on the scrolling thread, make sure to delete the TileCache layer
when the PlatformCALayer is destroyed. This fixes a crash when the tile revalidation timer fires after the WebTileCacheLayer has
been destroyed, but before the TileCache itself has been destroyed.

  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::~PlatformCALayer):

  • platform/graphics/ca/mac/WebTileCacheLayer.h:
  • platform/graphics/ca/mac/WebTileCacheLayer.mm:

(-[WebTileCacheLayer dealloc]):
(-[WebTileCacheLayer invalidate]):

2:56 PM Changeset in webkit [115375] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Use String instead of RefPtr<StringImpl> for the cache of ObjcClass
https://bugs.webkit.org/show_bug.cgi?id=84932

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-26
Reviewed by Andreas Kling.

The cache with RefPtr<StringImpl*> was added with r115007.

This patch aims at making the code a little easier to read. By using String,
one would not need to know the Traits for StringImpl.

  • bridge/objc/objc_class.h:

(ObjcClass):

2:53 PM Changeset in webkit [115374] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Pass Isolate to wrap() in SerializedScriptValue.cpp
https://bugs.webkit.org/show_bug.cgi?id=84923

Reviewed by Nate Chapin.

The objective is to pass Isolate around in V8 bindings.
In this bug we pass Isolate to wrap() in SerializedScriptValue.cpp.

No tests. No change in behavior.

  • bindings/v8/SerializedScriptValue.cpp:
2:51 PM Changeset in webkit [115373] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[chromium] Complex text support for Android.
https://bugs.webkit.org/show_bug.cgi?id=84431

Complex text support is different on Android from other platforms.
There are 2 kinds of font on Android: system fonts and fallback fonts.
System fonts have a name, and are accessible in FontPlatformData.
Fallback fonts do not have specific names, so they are not accessible
from WebKit directly. There is one font for each script support.
To feed Harfbuzz, use a trick to get correct SkTypeface based on script.

Patch by Hao Zheng <zhenghao@chromium.org> on 2012-04-26
Reviewed by Tony Chang.

No new tests. Current tests are runnable on Android.

  • platform/graphics/FontCache.h:

(FontCache): Make ComplexTextController friend of FontCache on Android.

  • platform/graphics/chromium/FontCacheAndroid.cpp:

(WebCore::FontCache::createFontPlatformData):

  • platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp:

(WebCore::ComplexTextController::getComplexFontPlatformData):
(WebCore):
(WebCore::ComplexTextController::setupFontForScriptRun):

  • platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.h:

(ComplexTextController):

2:40 PM Changeset in webkit [115372] by haraken@chromium.org
  • 9 edits in trunk/Source/WebCore

[V8] Pass Isolate to wrap() (Part2)
https://bugs.webkit.org/show_bug.cgi?id=84922

Reviewed by Nate Chapin.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to wrap() in custom bindings.

No tests. No change in behavior.

  • bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8SVGPathSegCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8StyleSheetCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Uint16ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Uint32ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Uint8ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp:

(WebCore::toV8):

2:37 PM Changeset in webkit [115371] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Remove Chromium test expectation after r115244.

  • platform/chromium/test_expectations.txt:
2:36 PM Changeset in webkit [115370] by dgrogan@chromium.org
  • 2 edits
    3 copies in branches/chromium/1084

Merge 113818 - Notify observers of WorkerRunLoop stopping before the V8 isolate dies.
https://bugs.webkit.org/show_bug.cgi?id=83104

Source/WebCore:

PlatformSupport::didStopWorkerRunLoop ultimately causes
~V8AbstractEventListener to call
v8::Local<v8::Object>::New(m_listener) after the V8 isolate has been
disposed, which manifests as a crash in V8.

The current code in trunk runs this at shutdown:
1) removeAllDOMObjects()
2) dispose of V8
3) didStopWorkerRunLoop() <-- problem

This patch changes the order to be:
1) removeAllDOMObjects()
2) didStopWorkerRunLoop()
3) dispose of V8

We put didStopWorkerRunLoop after removeAllDOMObjects because we don't
want chromium code that runs on a webcore worker to run after it
receives the didStopWorkerRunLoop signal. The destructors of some IDB
objects are run by removeAllDOMObjects, so putting
didStopWorkerRunLoop before removeAllDOMObjects would violate that
constraint.

It's possible that there's a lower layer fix available in V8 or the
bindings.

Reviewed by David Levin.

Test: storage/indexeddb/pending-version-change-on-exit.html

  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::~WorkerScriptController):
New location of didStopWorkerRunLoop. removeAllDOMObjects and V8
disposal are called here, to run something between them it also has
to go here.

  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::workerThread): Old location of
didStopWorkerRunLoop.

LayoutTests:

Reviewed by David Levin.

  • storage/indexeddb/pending-version-change-on-exit-expected.txt: Added.
  • storage/indexeddb/pending-version-change-on-exit.html: Added.
  • storage/indexeddb/resources/pending-version-change-on-exit.js: Added.

(test.request.onsuccess.request.onblocked):
(test.request.onsuccess):
(test):

TBR=dgrogan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10232019

2:35 PM Changeset in webkit [115369] by jonlee@apple.com
  • 9 edits in trunk/Source

[WK2] AlternativeTextClient leaks when the page is destroyed
https://bugs.webkit.org/show_bug.cgi?id=84307
<rdar://problem/11328431>

Reviewed by Enrica Casucci.

Source/WebCore:

  • page/AlternativeTextClient.h: Add pageDestroyed() call, as in EditorClient.

(AlternativeTextClient):

  • page/Page.cpp:

(WebCore::Page::~Page): When the page is destroyed, notify the client if it exists.

Source/WebKit/mac:

  • WebCoreSupport/WebAlternativeTextClient.h: Implement pageDestroyed(), as in EditorClient.

(WebAlternativeTextClient):

  • WebCoreSupport/WebAlternativeTextClient.mm:

(WebAlternativeTextClient::pageDestroyed): Deletes itself.

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebAlternativeTextClient.h: Implement pageDestroyed(), as in EditorClient.

(WebAlternativeTextClient):

  • WebProcess/WebCoreSupport/mac/WebAlternativeTextClient.cpp:

(WebKit::WebAlternativeTextClient::pageDestroyed): Deletes itself.

2:29 PM Changeset in webkit [115368] by jer.noble@apple.com
  • 4 edits in trunk/Source

Full Screen mode does not preserve CALayer ordering after exiting.
https://bugs.webkit.org/show_bug.cgi?id=83931

Reviewed by Eric Carlson.

Further corrections to r114567. When swapping view for otherView, give the correct
relative view to -[NSView addSubview:positioned:relativeTo:].

Source/WebKit/mac:

  • WebView/WebFullScreenController.mm:

(-[WebFullScreenController _swapView:with:]):

Source/WebKit2:

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController _swapView:with:]):

2:27 PM Changeset in webkit [115367] by tomz@codeaurora.org
  • 6 edits
    43 adds in trunk/LayoutTests

Integrate IETC CSS : multicolumn tests
https://bugs.webkit.org/show_bug.cgi?id=84784

Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-04-26
Reviewed by Beth Dakin.

Adding IETC CSS Multicolumn tests along with corresponding reference tests.
Failures are noted in port-specific test_expectations.txt.

  • ietestcenter/css3/multicolumn/column-block-formatting-context-001-expected.htm: Added.
  • ietestcenter/css3/multicolumn/column-block-formatting-context-001.htm: Added.
  • ietestcenter/css3/multicolumn/column-containing-block-001-expected.htm: Added.
  • ietestcenter/css3/multicolumn/column-containing-block-001.htm: Added.
  • ietestcenter/css3/multicolumn/column-containing-block-002-expected.htm: Added.
  • ietestcenter/css3/multicolumn/column-containing-block-002.htm: Added.
  • ietestcenter/css3/multicolumn/column-containing-block-003-expected.htm: Added.
  • ietestcenter/css3/multicolumn/column-containing-block-003.htm: Added.
  • ietestcenter/css3/multicolumn/column-filling-001-expected.htm: Added.
  • ietestcenter/css3/multicolumn/column-filling-001.htm: Added.
  • ietestcenter/css3/multicolumn/column-width-applies-to-001-expected.htm: Added.
  • ietestcenter/css3/multicolumn/column-width-applies-to-001.htm: Added.
  • ietestcenter/css3/multicolumn/column-width-applies-to-002-expected.htm: Added.
  • ietestcenter/css3/multicolumn/column-width-applies-to-002.htm: Added.
  • ietestcenter/css3/multicolumn/column-width-applies-to-003-expected.htm: Added.
  • ietestcenter/css3/multicolumn/column-width-applies-to-003.htm: Added.
  • ietestcenter/css3/multicolumn/column-width-applies-to-004-expected.htm: Added.
  • ietestcenter/css3/multicolumn/column-width-applies-to-004.htm: Added.
  • ietestcenter/css3/multicolumn/column-width-applies-to-005-expected.htm: Added.
  • ietestcenter/css3/multicolumn/column-width-applies-to-005.htm: Added.
  • ietestcenter/css3/multicolumn/column-width-applies-to-006-expected.htm: Added.
  • ietestcenter/css3/multicolumn/column-width-applies-to-006.htm: Added.
  • ietestcenter/css3/multicolumn/column-width-applies-to-007-expected.htm: Added.
  • ietestcenter/css3/multicolumn/column-width-applies-to-007.htm: Added.
  • ietestcenter/css3/multicolumn/column-width-applies-to-008-expected.htm: Added.
  • ietestcenter/css3/multicolumn/column-width-applies-to-008.htm: Added.
  • ietestcenter/css3/multicolumn/column-width-applies-to-009-expected.htm: Added.
  • ietestcenter/css3/multicolumn/column-width-applies-to-009.htm: Added.
  • ietestcenter/css3/multicolumn/column-width-applies-to-010-expected.htm: Added.
  • ietestcenter/css3/multicolumn/column-width-applies-to-010.htm: Added.
  • ietestcenter/css3/multicolumn/column-width-applies-to-012-expected.htm: Added.
  • ietestcenter/css3/multicolumn/column-width-applies-to-012.htm: Added.
  • ietestcenter/css3/multicolumn/column-width-applies-to-013-expected.htm: Added.
  • ietestcenter/css3/multicolumn/column-width-applies-to-013.htm: Added.
  • ietestcenter/css3/multicolumn/column-width-applies-to-014-expected.htm: Added.
  • ietestcenter/css3/multicolumn/column-width-applies-to-014.htm: Added.
  • ietestcenter/css3/multicolumn/column-width-applies-to-015-expected.htm: Added.
  • ietestcenter/css3/multicolumn/column-width-applies-to-015.htm: Added.
  • ietestcenter/css3/multicolumn/column-width-negative-001-expected.htm: Added.
  • ietestcenter/css3/multicolumn/column-width-negative-001.htm: Added.
  • ietestcenter/css3/multicolumn/column-width-percentage-001-expected.htm: Added.
  • ietestcenter/css3/multicolumn/column-width-percentage-001.htm: Added.
  • platform/chromium/test_expectations.txt:
  • platform/efl/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
2:25 PM Changeset in webkit [115366] by haraken@chromium.org
  • 16 edits in trunk/Source/WebCore

[V8] Pass Isolate to wrap() (Part1)
https://bugs.webkit.org/show_bug.cgi?id=84921

Reviewed by Nate Chapin.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to wrap() in custom bindings.

No tests. No change in behavior.

  • bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8CSSRuleCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8CSSStyleSheetCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8CSSValueCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8DOMTokenListCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8EventCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Float32ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Float64ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8ImageDataCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Int16ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Int32ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Int8ArrayCustom.cpp:

(WebCore::toV8):

2:24 PM Changeset in webkit [115365] by rakuco@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Update expectations in security/ after r115294.

  • platform/efl/security/block-test-expected.txt:
  • platform/efl/security/block-test-no-port-expected.txt:
2:24 PM Changeset in webkit [115364] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/css/CSSPrimitiveValue.cpp

Continuing to use roundForImpreciseConversion when subpixel-layout is disabled, but Lengths are still treated as floats.

2:21 PM Changeset in webkit [115363] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

DFG ARMv7 backend should optimize Float32 arrays
https://bugs.webkit.org/show_bug.cgi?id=85000
<rdar://problem/10652827>

Reviewed by Gavin Barraclough.

  • assembler/ARMv7Assembler.h:

(ARMv7Assembler):
(JSC::ARMv7Assembler::flds):
(JSC::ARMv7Assembler::fsts):
(JSC::ARMv7Assembler::vcvtds):
(JSC::ARMv7Assembler::vcvtsd):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::loadFloat):
(MacroAssemblerARMv7):
(JSC::MacroAssemblerARMv7::storeFloat):
(JSC::MacroAssemblerARMv7::convertFloatToDouble):
(JSC::MacroAssemblerARMv7::convertDoubleToFloat):

  • bytecode/PredictedType.h:

(JSC::isActionableFloatMutableArrayPrediction):

  • dfg/DFGNode.h:

(JSC::DFG::Node::shouldSpeculateFloat32Array):

2:15 PM Changeset in webkit [115362] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Remove expectation of failure for a fixed test.

  • platform/chromium/test_expectations.txt: Now passing.
2:12 PM Changeset in webkit [115361] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, remove tests that now pass from test_expectations.txt

  • platform/mac/test_expectations.txt:
2:10 PM Changeset in webkit [115360] by rniwa@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add a test for crash in DOMSelection::deleteFromDocument
https://bugs.webkit.org/show_bug.cgi?id=84991

Reviewed by Alexey Proskuryakov.

Add a test for the bug 44153 (fixed in r65587).

  • editing/selection/deleteFromDocument-after-document-open-crash-expected.txt: Added.
  • editing/selection/deleteFromDocument-after-document-open-crash.html: Added.
2:08 PM Changeset in webkit [115359] by Lucas Forschler
  • 4 edits in trunk/Source

Versioning.

2:07 PM Changeset in webkit [115358] by benjamin@webkit.org
  • 5 edits
    4 adds in trunk

ObjcClass::methodsNamed() can leak if buffer is dynamically allocated
https://bugs.webkit.org/show_bug.cgi?id=84668

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-26
Reviewed by Alexey Proskuryakov.

Source/WebCore:

Change ObjcClass::methodsNamed() to be based on a vector instead of managing
the memory manually.

Tests: platform/mac/plugins/bindings-objc-long-method-name.html

platform/mac/plugins/bindings-objc-method-name-conversion.html

  • bridge/objc/objc_class.mm:

(Bindings):
(JSC::Bindings::convertJSMethodNameToObjc):
(JSC::Bindings::ObjcClass::methodsNamed):

Tools:

Extend ObjCPlugin to support the new layout tests of the Objective-C bridge.

  • DumpRenderTree/mac/ObjCPlugin.m:

(+[ObjCPlugin isSelectorExcludedFromWebScript:]):
(+[ObjCPlugin webScriptNameForSelector:]):
(-[ObjCPlugin methodMappedToLongName]):
(-[ObjCPlugin testConversionColon:]):
(-[ObjCPlugin _:]):

LayoutTests:

Extend the test coverage to accessor with very long name. Add coverage for the
JavaScript to Objective-C method name conversion.

  • platform/mac/plugins/bindings-objc-long-method-name-expected.txt: Added.
  • platform/mac/plugins/bindings-objc-long-method-name.html: Added.
  • platform/mac/plugins/bindings-objc-method-name-conversion-expected.txt: Added.
  • platform/mac/plugins/bindings-objc-method-name-conversion.html: Added.
2:05 PM Changeset in webkit [115357] by Lucas Forschler
  • 1 copy in tags/Safari-536.9

New Tag.

2:01 PM Changeset in webkit [115356] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] media/video-currentTime-set.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=85003

  • platform/chromium/test_expectations.txt: Added expectation of flakiness.
1:58 PM Changeset in webkit [115355] by jamesr@google.com
  • 18 edits in trunk/Source

[Chromium] Single buffered canvas layers with the threaded compositor
https://bugs.webkit.org/show_bug.cgi?id=80540

Patch by Justin Novosad <junov@chromium.org> on 2012-04-26
Reviewed by James Robinson.

Source/WebCore:

Tests:
CCLayerTreeHostTestWriteLayersRedraw
CCLayerTreeHostTestWriteLayersAfterVisible
Canvas2DLayerChromiumTest.testFullLifecycleSingleThreadDeferred
Canvas2DLayerChromiumTest.testFullLifecycleThreadDeferred
CCSchedulerTest.VisibilitySwitchWithTextureAcquisition
CCSchedulerTest.TextureAcquisitionCollision

Disable double buffering and rate limiting on accelerated canvas
when the threaded compositor and deferred canvas are enabled.
Concurrent access to the layer texture by the main renderer thread and
the compositor thread is avoided by enforcing a lock. The state of the
lock is maintained by CCSchedulerStateMachine. Write access by the main
thread is acquired through a signal round trip to the compositor thread,
which may block the main thread in the event that one or more committed
layers need to be protected until the compositor completes the requested
draw. Draws on the impl thread are cancelled if the main thread has
obtained write access to the texture. The write access is relinquished
by the main thread upon commit completion. The scheduler state machine
is responsible for preventing the texture lock from causing deadlocks by
detecting and resolving problematic states.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::create):
(WebCore::Canvas2DLayerChromium::Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::drawingIntoImplThreadTexture):
(WebCore):
(WebCore::Canvas2DLayerChromium::setTextureId):
(WebCore::Canvas2DLayerChromium::setNeedsDisplayRect):
(WebCore::Canvas2DLayerChromium::update):
(WebCore::Canvas2DLayerChromium::layerWillDraw):
(WebCore::Canvas2DLayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/Canvas2DLayerChromium.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::acquireLayerTextures):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCProxy.h:

(CCProxy):

  • platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::setMainThreadNeedsLayerTextures):
(WebCore):
(WebCore::CCScheduler::processScheduledActions):

  • platform/graphics/chromium/cc/CCScheduler.h:

(CCSchedulerClient):
(CCScheduler):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::drawSuspendedUntilCommit):
(WebCore):
(WebCore::CCSchedulerStateMachine::scheduledToDraw):
(WebCore::CCSchedulerStateMachine::shouldDraw):
(WebCore::CCSchedulerStateMachine::shouldAcquireLayerTexturesForMainThread):
(WebCore::CCSchedulerStateMachine::nextAction):
(WebCore::CCSchedulerStateMachine::updateState):
(WebCore::CCSchedulerStateMachine::setMainThreadNeedsLayerTextures):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.h:

(CCSchedulerStateMachine):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal):
(WebCore):
(WebCore::CCThreadProxy::acquireLayerTextures):
(WebCore::CCThreadProxy::acquireLayerTexturesForMainThreadOnImplThread):
(WebCore::CCThreadProxy::scheduledActionAcquireLayerTexturesForMainThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore):
(WebCore::AcceleratedDeviceContext::AcceleratedDeviceContext):
(WebCore::AcceleratedDeviceContext::prepareForDraw):
(AcceleratedDeviceContext):
(WebCore::createAcceleratedCanvas):
(WebCore::ImageBuffer::context):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::AcquireLayerTextures):
(CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::dispatchAcquireLayerTextures):
(WTF::TEST_F):
(WTF):
(CCLayerTreeHostTestWriteLayersRedraw):
(WTF::CCLayerTreeHostTestWriteLayersRedraw::CCLayerTreeHostTestWriteLayersRedraw):
(WTF::CCLayerTreeHostTestWriteLayersRedraw::beginTest):
(WTF::CCLayerTreeHostTestWriteLayersRedraw::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestWriteLayersRedraw::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestWriteLayersRedraw::afterTest):
(CCLayerTreeHostTestWriteLayersAfterVisible):
(WTF::CCLayerTreeHostTestWriteLayersAfterVisible::CCLayerTreeHostTestWriteLayersAfterVisible):
(WTF::CCLayerTreeHostTestWriteLayersAfterVisible::beginTest):
(WTF::CCLayerTreeHostTestWriteLayersAfterVisible::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestWriteLayersAfterVisible::afterTest):

  • tests/CCSchedulerTest.cpp:

(WebKitTests::TEST):
(WebKitTests):

  • tests/Canvas2DLayerChromiumTest.cpp:

(Canvas2DLayerChromiumTest::fullLifecycleTest):

1:53 PM Changeset in webkit [115354] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r115342.
http://trac.webkit.org/changeset/115342

r115340 was rolled out

  • platform/qt/test_expectations.txt:
1:50 PM Changeset in webkit [115353] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r115349.
http://trac.webkit.org/changeset/115349

Patch that required this change was reverted.

  • platform/chromium/test_expectations.txt:
1:47 PM Changeset in webkit [115352] by Dimitri Glazkov
  • 8 edits
    130 adds
    10 deletes in trunk

Unreviewed, rolling out r115340.
http://trac.webkit.org/changeset/115340
https://bugs.webkit.org/show_bug.cgi?id=83048

Does not work with Windows.

Tools:

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner._run_reftest):

  • Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(copy_file):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port._parse_reftest_list):
(Port.reference_files):
(Port._real_tests):

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_reference_files):

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumDriverTest.test_write_command_and_read_line):

LayoutTests:

  • css2.1/20110323/abspos-containing-block-initial-004-ref-expected.png: Added.
  • css2.1/20110323/abspos-containing-block-initial-004-ref-expected.txt: Added.
  • css2.1/20110323/abspos-containing-block-initial-004a-expected.png: Added.
  • css2.1/20110323/abspos-containing-block-initial-004a-expected.txt: Added.
  • css2.1/20110323/abspos-containing-block-initial-004b-expected.png: Added.
  • css2.1/20110323/abspos-containing-block-initial-004b-expected.txt: Added.
  • css2.1/20110323/abspos-containing-block-initial-004c-expected.png: Added.
  • css2.1/20110323/abspos-containing-block-initial-004c-expected.txt: Added.
  • css2.1/20110323/abspos-containing-block-initial-004d-expected.png: Added.
  • css2.1/20110323/abspos-containing-block-initial-004d-expected.txt: Added.
  • css2.1/20110323/abspos-containing-block-initial-004e-expected.png: Added.
  • css2.1/20110323/abspos-containing-block-initial-004e-expected.txt: Added.
  • css2.1/20110323/abspos-containing-block-initial-004f-expected.png: Added.
  • css2.1/20110323/abspos-containing-block-initial-004f-expected.txt: Added.
  • css2.1/20110323/abspos-containing-block-initial-005-ref-expected.png: Added.
  • css2.1/20110323/abspos-containing-block-initial-005-ref-expected.txt: Added.
  • css2.1/20110323/abspos-containing-block-initial-005a-expected.png: Added.
  • css2.1/20110323/abspos-containing-block-initial-005a-expected.txt: Added.
  • css2.1/20110323/abspos-containing-block-initial-005b-expected.png: Added.
  • css2.1/20110323/abspos-containing-block-initial-005b-expected.txt: Added.
  • css2.1/20110323/abspos-containing-block-initial-005c-expected.png: Added.
  • css2.1/20110323/abspos-containing-block-initial-005c-expected.txt: Added.
  • css2.1/20110323/abspos-containing-block-initial-005d-expected.png: Added.
  • css2.1/20110323/abspos-containing-block-initial-005d-expected.txt: Added.
  • css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Added.
  • css2.1/20110323/abspos-containing-block-initial-007-ref-expected.txt: Added.
  • css2.1/20110323/abspos-containing-block-initial-009-ref-expected.png: Added.
  • css2.1/20110323/abspos-containing-block-initial-009-ref-expected.txt: Added.
  • css2.1/20110323/abspos-containing-block-initial-009a-expected.png: Added.
  • css2.1/20110323/abspos-containing-block-initial-009a-expected.txt: Added.
  • css2.1/20110323/abspos-containing-block-initial-009b-expected.png: Added.
  • css2.1/20110323/abspos-containing-block-initial-009b-expected.txt: Added.
  • css2.1/20110323/abspos-containing-block-initial-009e-expected.png: Added.
  • css2.1/20110323/abspos-containing-block-initial-009e-expected.txt: Added.
  • css2.1/20110323/abspos-containing-block-initial-009f-expected.png: Added.
  • css2.1/20110323/abspos-containing-block-initial-009f-expected.txt: Added.
  • css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt: Added.
  • css2.1/20110323/abspos-replaced-width-margin-000-expected.txt: Added.
  • css2.1/20110323/background-016.htm: Removed.
  • css2.1/20110323/block-replaced-width-001.htm: Added.
  • css2.1/20110323/empty-inline-001.htm:
  • css2.1/20110323/reftest.list: Removed.
  • css2.1/reference/ref-filled-green-100px-square.htm: Removed.
  • css2.1/reference/ref-filled-green-100px-square.xht: Removed.
  • css2.1/reference/ref-if-there-is-no-red.htm: Removed.
  • css2.1/reference/ref-if-there-is-no-red.xht: Removed.
  • css2.1/reference/ref-nothing-below.htm: Removed.
  • css2.1/reference/ref-nothing-below.xht: Removed.
  • css2.1/reference/ref-this-text-should-be-green.htm: Removed.
  • css2.1/reference/ref-this-text-should-be-green.xht: Removed.
  • platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/empty-inline-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/block-replaced-width-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/empty-inline-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/abspos-containing-block-initial-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/block-replaced-width-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/empty-inline-001-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/abspos-containing-block-initial-001-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/block-replaced-width-001-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/empty-inline-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/abspos-containing-block-initial-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/empty-inline-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/empty-inline-001-expected.txt: Added.
  • platform/chromium/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.png: Added.
  • platform/chromium/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.png: Added.
  • platform/efl/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Added.
  • platform/efl/css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Added.
  • platform/efl/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.png: Added.
  • platform/efl/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.txt: Added.
  • platform/efl/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Added.
  • platform/efl/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt: Added.
  • platform/efl/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.png: Added.
  • platform/efl/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.txt: Added.
  • platform/efl/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Added.
  • platform/efl/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt: Added.
  • platform/efl/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.png: Added.
  • platform/efl/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.txt: Added.
  • platform/efl/css2.1/20110323/block-replaced-width-001-expected.png: Added.
  • platform/efl/css2.1/20110323/block-replaced-width-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/abspos-containing-block-initial-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.txt: Added.
  • platform/gtk/css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Added.
  • platform/gtk/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Added.
  • platform/gtk/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt: Added.
  • platform/gtk/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.png: Added.
  • platform/gtk/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.txt: Added.
  • platform/gtk/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Added.
  • platform/gtk/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt: Added.
  • platform/gtk/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.png: Added.
  • platform/gtk/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.txt: Added.
  • platform/gtk/css2.1/20110323/block-replaced-width-001-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/abspos-containing-block-initial-001-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Added.
  • platform/mac/css2.1/20110323/abspos-containing-block-initial-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.txt: Added.
  • platform/mac/css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Added.
  • platform/mac/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.txt: Added.
  • platform/mac/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Added.
  • platform/mac/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt: Added.
  • platform/mac/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.png: Added.
  • platform/mac/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.txt: Added.
  • platform/mac/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Added.
  • platform/mac/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt: Added.
  • platform/mac/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.png: Added.
  • platform/mac/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.txt: Added.
  • platform/mac/css2.1/20110323/block-replaced-width-001-expected.png: Added.
  • platform/mac/css2.1/20110323/block-replaced-width-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/empty-inline-001-expected.png: Added.
  • platform/mac/css2.1/20110323/empty-inline-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/abspos-containing-block-initial-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.txt: Added.
  • platform/qt/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Added.
  • platform/qt/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.png: Added.
  • platform/qt/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.txt: Added.
  • platform/qt/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Added.
  • platform/qt/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.png: Added.
  • platform/qt/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.txt: Added.
  • platform/qt/css2.1/20110323/block-replaced-width-001-expected.png: Added.
  • platform/qt/css2.1/20110323/block-replaced-width-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/empty-inline-001-expected.txt: Added.
1:41 PM Changeset in webkit [115351] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Pass Isolate to toV8() in SerializedScriptValue.cpp
https://bugs.webkit.org/show_bug.cgi?id=84918

Reviewed by Nate Chapin.

This is the last step to pass Isolate around in
SerializedScriptValue.cpp. This patch passes Isolate
to toV8().

No tests. No change in behavior.

  • bindings/v8/SerializedScriptValue.cpp:
1:34 PM Changeset in webkit [115350] by haraken@chromium.org
  • 24 edits in trunk/Source/WebCore

[V8] Pass Isolate to wrapSlow()
https://bugs.webkit.org/show_bug.cgi?id=84919

Reviewed by Nate Chapin.

The objective is to pass Isolate around in V8 bindings.
In this bug, we pass Isolate to wrapSlow().

Test: bindings/scripts/test/TestObj.idl etc

  • bindings/scripts/CodeGeneratorV8.pm: Modified as described above.

(GenerateHeader):
(GenerateToV8Converters):

  • bindings/scripts/test/V8/V8Float64Array.cpp: Updated run-bindings-tests.

(WebCore::V8Float64Array::wrapSlow):

  • bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):
(WebCore::V8Float64Array::wrap):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::wrapSlow):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):
(WebCore::V8TestActiveDOMObject::wrap):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::wrapSlow):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):
(WebCore::V8TestCustomNamedGetter::wrap):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::wrapSlow):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):
(WebCore::V8TestEventConstructor::wrap):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::V8TestEventTarget::wrapSlow):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):
(WebCore::V8TestEventTarget::wrap):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::wrapSlow):

  • bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):
(WebCore::V8TestInterface::wrap):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::wrapSlow):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):
(WebCore::V8TestMediaQueryListListener::wrap):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::wrapSlow):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):
(WebCore::V8TestNamedConstructor::wrap):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::wrapSlow):

  • bindings/scripts/test/V8/V8TestNode.h:

(V8TestNode):
(WebCore::V8TestNode::wrap):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::wrapSlow):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):
(WebCore::V8TestObj::wrap):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):
(WebCore::V8TestSerializedScriptValueInterface::wrap):

1:17 PM Changeset in webkit [115349] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Remove expectation of a test failure after the test itself was removed in r115340.

  • platform/chromium/test_expectations.txt: Removed failure expectation.
1:15 PM Changeset in webkit [115348] by tonikitoo@webkit.org
  • 8 edits in trunk

[BlackBerry] properly disable DRAG_SUPPORT
https://bugs.webkit.org/show_bug.cgi?id=84952

Reviewed by Daniel Bates.
Patch by Antonio Gomes <agomes@rim.com>

.:

Add CMake build options to toggle DRAG_SUPPORT on/off,
and set its value for BlackBerry port.

  • Source/cmake/OptionsBlackBerry.cmake: Set it OFF by default.
  • Source/cmake/OptionsEFL.cmake: Set it ON by default.
  • Source/cmake/OptionsWinCE.cmake: Set it OFF by default.
  • Source/cmake/OptionsWindows.cmake: Set it ON by default.
  • Source/cmakeconfig.h.cmake:

Source/WTF:

  • wtf/Platform.h: Remove the line that disables drag support from here.
1:15 PM Changeset in webkit [115347] by tonikitoo@webkit.org
  • 4 edits
    2 adds in trunk/Source/WebCore

Add ScrollAnimatorBlackBerry as an extension to ScrollAnimatorNone
https://bugs.webkit.org/show_bug.cgi?id=84625

Reviewed by Anders Carlsson.
Patch by Antonio Gomes <agomes@rim.com>

Patch adds ScrollAnimatorBlackBerry class as an extension to of
ScrollAnimatorNone. The main goal here is extending the later to allow
overscrolling while the animation runs.

Once the animation finishes, the flag gets reseted and
ScrollableArea::constrainsScrollingtoContentEdge is set back to the value
it had before, so this method has to be explicitly called anytime it is wanted.

  • CMakeLists.txt:
  • platform/ScrollAnimator.h:

(WebCore::ScrollAnimator::animationWillStart):
(WebCore::ScrollAnimator::animationDidFinish):
(ScrollAnimator):

  • platform/ScrollAnimatorNone.cpp:

(WebCore):
(WebCore::ScrollAnimatorNone::scroll):
(WebCore::ScrollAnimatorNone::animationTimerFired):

  • platform/blackberry/ScrollAnimatorBlackBerry.cpp: Added.

(WebCore):
(WebCore::ScrollAnimator::create):
(WebCore::ScrollAnimatorBlackBerry::ScrollAnimatorBlackBerry):
(WebCore::ScrollAnimatorBlackBerry::animationWillStart):
(WebCore::ScrollAnimatorBlackBerry::animationDidFinish):
(WebCore::ScrollAnimatorBlackBerry::setDisableConstrainsScrollingToContentEdgeWhileAnimating):

  • platform/blackberry/ScrollAnimatorBlackBerry.h: Added.

(WebCore):
(ScrollAnimatorBlackBerry):

1:14 PM Changeset in webkit [115346] by tonikitoo@webkit.org
  • 5 edits in trunk

[BlackBerry] Add smooth_scrolling options to CMAKE and enable it for Blackberry
https://bugs.webkit.org/show_bug.cgi?id=84954

Reviewed by Daniel Bates.
Patch by Antonio Gomes <agomes@rim.com>

.:

  • Source/cmakeconfig.h.cmake: Make it possible for CMake builds to toggle SMOOTH_SCROLLING on/off
  • Source/cmake/OptionsBlackBerry.cmake: ... and set it to ON by defualt for the Blackberry port.

Source/WebCore:

Add the default scroll animator to the build system (ScrollAnimatorNone.cpp)

  • CMakeLists.txt:
1:14 PM Changeset in webkit [115345] by tonikitoo@webkit.org
  • 2 edits in trunk/Source/WebCore

Make ScrollView::scrollSize scrollbar-independent
https://bugs.webkit.org/show_bug.cgi?id=84873

Reviewed by Anders Carlsson.
Patch by Antonio Gomes <agomes@rim.com>

For ports that disable scrollbars creation at FrameView creation time
ScrollView::scrollSize should still return the scrollable ammount of
content (if any) if scrolling is not prohibted.

No new test, but it makes ScrollAnimator work for the BlackBerry port.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::scrollSize):

1:01 PM Changeset in webkit [115344] by andersca@apple.com
  • 6 edits in trunk/Source/WebCore

The tile cache should know if a frame view can ever have scrollbars
https://bugs.webkit.org/show_bug.cgi?id=84888

Reviewed by Andreas Kling.

If a frame view has overflow: hidden on its body element we know that the document will most
likely never be scrolled. The tile cache should know about this so we can optimize.

  • page/FrameView.cpp:

(WebCore::FrameView::performPostLayoutTasks):

  • platform/graphics/TiledBacking.h:

(TiledBacking):

  • platform/graphics/ca/mac/TileCache.h:

(TileCache):

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::TileCache):
(WebCore::TileCache::setCanHaveScrollbars):
(WebCore):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::RenderLayerBacking):

12:59 PM Changeset in webkit [115343] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Crash from removal of line break object after layout
https://bugs.webkit.org/show_bug.cgi?id=75461

Source/WebCore:

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-04-26
Reviewed by David Hyatt.

There is a condition where objects can get removed from underneath
inlines while they represent a line break object in a RootInlineBox
of an ancestor block. If an intermediary inline has already been
marked as needing layout, then the line box will not get dirtied
because dirtyLineFromChangedChild thinks it already has been.

This patch introduces a new set in RenderObject to indicate whether
an ancestral line box corresponding to the current line has been
marked dirty or not. dirtyLinesFromChangedChild() can use this set
rather than m_selfNeedsLayout, so it will not be confused if a
container was dirtied for some other reason that did not affect the
line box.

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild): Use the new
set rather than m_selfNeedsLayout in the container to determine
whether to continue propagating upward.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::s_ancestorLineboxDirtySet): Instantiate the
static member.
(WebCore::RenderObject::willBeDestroyed): Clears the object from the
linebox set when it is being destroyed.

  • rendering/RenderObject.h:

(WebCore::RenderObject::s_ancestorLineboxDirtySet): Added static
member set.
(WebCore::RenderObject::setNeedsLayout): Clears the
object from the linebox set when layout bits are getting cleared.
(WebCore::RenderObject::ancestorLineBoxDirty): Added.
(WebCore::RenderObject::setAncestorLineBoxDirty): Added.

LayoutTests:

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-04-25
Reviewed by David Hyatt.

Test exercising crashing condition in bug 75461.

  • fast/block/line-layout/line-break-obj-removal-crash-expected.txt: Added
  • fast/block/line-layout/line-break-obj-removal-crash.html: Added
12:54 PM Changeset in webkit [115342] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

Update Qt expectations after r115340

css2.1/20110323/abspos-replaced-width-margin-000.htm fails the reftest due to
scrollbar artefacts.

Unreviewed.

  • platform/qt/test_expectations.txt:
12:48 PM Changeset in webkit [115341] by commit-queue@webkit.org
  • 16 edits in trunk

[EFL] Enable VIDEO_TRACK feature
https://bugs.webkit.org/show_bug.cgi?id=84830

Patch by Christophe Dumez <Christophe Dumez> on 2012-04-26
Reviewed by Gustavo Noronha Silva.

.:

Enable VIDEO_TRACK feature by default on EFL port.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/WebCore:

Enable support for VIDEO_TRACK feature by default for EFL port.

  • UseJSC.cmake:
  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

Source/WebKit:

Enable VIDEO_TRACK feature by default for EFL port.

  • PlatformEfl.cmake:

Source/WebKit/efl:

Add functions on the ewk_view to toggle runtime support for text
tracks in HTML5 video.

  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(ewk_view_setting_should_display_subtitles_get):
(ewk_view_setting_should_display_subtitles_set):
(ewk_view_setting_should_display_captions_get):
(ewk_view_setting_should_display_captions_set):
(ewk_view_setting_should_display_text_descriptions_get):
(ewk_view_setting_should_display_text_descriptions_set):

  • ewk/ewk_view.h:

Tools:

Enable VIDEO_TRACK by default on EFL port whenever build-webkit is
used.

  • Scripts/build-webkit:

LayoutTests:

Unskip test cases which requires the VIDEO_TRACK feature now that it
is enabled by default for EFL port.

  • platform/efl/Skipped:
12:21 PM Changeset in webkit [115340] by robert@webkit.org
  • 8 edits
    11 adds
    130 deletes in trunk

new-webkit-run-tests: handle ref tests from the CSS test suite
https://bugs.webkit.org/show_bug.cgi?id=83048

Reviewed by Ryosuke Niwa.

Tools:

This allows new-run-webkit-tests to run reference tests created for the CSS test suite. It removes a big swathe
of pixel and text results that are no longer required now that the reference results are used and adds in the support
files from the CSS test suite that allow the ref tests to run.

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner._run_reftest): Assert that the reference result exists. Previously the test would

run without it and report a pass!

  • Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(copy_file): ensure the output directory exists, it may not if the reference test is

contained in a folder that contains nothing but reference tests.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.available_reference_files): Add as a helper. Handle embedded relative paths, e.g: some/../path
(Port.reference_files): Only return reference results in the reftest list that actually exist on

disk. Also, don't ignore potential reference results on disk that are not in the reftest list, and
don't ignore them just because we have a reftest list for the test's directory.

(Port._real_tests): ignore anything that looks like a test in a 'support' directory, this semantic

is used by the CSS 2.1 test suite.

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_reference_files_when_reftestlist_and_reference_file_present): Ensure that a test with a reference result

on disk but no reference result listed in the directory's reftest list picks up its reference result.

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumDriverTest.test_strip_uri): Test that some/test.html and some/other/../test.html are treated

as the same file.

LayoutTests:

Add some of the reference infrastructure from the CSS 2.1 test suite.

  • css2.1/20110323/abspos-containing-block-initial-004-ref-expected.png: Removed.
  • css2.1/20110323/abspos-containing-block-initial-004-ref-expected.txt: Removed.
  • css2.1/20110323/abspos-containing-block-initial-004a-expected.png: Removed.
  • css2.1/20110323/abspos-containing-block-initial-004a-expected.txt: Removed.
  • css2.1/20110323/abspos-containing-block-initial-004b-expected.png: Removed.
  • css2.1/20110323/abspos-containing-block-initial-004b-expected.txt: Removed.
  • css2.1/20110323/abspos-containing-block-initial-004c-expected.png: Removed.
  • css2.1/20110323/abspos-containing-block-initial-004c-expected.txt: Removed.
  • css2.1/20110323/abspos-containing-block-initial-004d-expected.png: Removed.
  • css2.1/20110323/abspos-containing-block-initial-004d-expected.txt: Removed.
  • css2.1/20110323/abspos-containing-block-initial-004e-expected.png: Removed.
  • css2.1/20110323/abspos-containing-block-initial-004e-expected.txt: Removed.
  • css2.1/20110323/abspos-containing-block-initial-004f-expected.png: Removed.
  • css2.1/20110323/abspos-containing-block-initial-004f-expected.txt: Removed.
  • css2.1/20110323/abspos-containing-block-initial-005-ref-expected.png: Removed.
  • css2.1/20110323/abspos-containing-block-initial-005-ref-expected.txt: Removed.
  • css2.1/20110323/abspos-containing-block-initial-005a-expected.png: Removed.
  • css2.1/20110323/abspos-containing-block-initial-005a-expected.txt: Removed.
  • css2.1/20110323/abspos-containing-block-initial-005b-expected.png: Removed.
  • css2.1/20110323/abspos-containing-block-initial-005b-expected.txt: Removed.
  • css2.1/20110323/abspos-containing-block-initial-005c-expected.png: Removed.
  • css2.1/20110323/abspos-containing-block-initial-005c-expected.txt: Removed.
  • css2.1/20110323/abspos-containing-block-initial-005d-expected.png: Removed.
  • css2.1/20110323/abspos-containing-block-initial-005d-expected.txt: Removed.
  • css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Removed.
  • css2.1/20110323/abspos-containing-block-initial-007-ref-expected.txt: Removed.
  • css2.1/20110323/abspos-containing-block-initial-009-ref-expected.png: Removed.
  • css2.1/20110323/abspos-containing-block-initial-009-ref-expected.txt: Removed.
  • css2.1/20110323/abspos-containing-block-initial-009a-expected.png: Removed.
  • css2.1/20110323/abspos-containing-block-initial-009a-expected.txt: Removed.
  • css2.1/20110323/abspos-containing-block-initial-009b-expected.png: Removed.
  • css2.1/20110323/abspos-containing-block-initial-009b-expected.txt: Removed.
  • css2.1/20110323/abspos-containing-block-initial-009e-expected.png: Removed.
  • css2.1/20110323/abspos-containing-block-initial-009e-expected.txt: Removed.
  • css2.1/20110323/abspos-containing-block-initial-009f-expected.png: Removed.
  • css2.1/20110323/abspos-containing-block-initial-009f-expected.txt: Removed.
  • css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt: Removed.
  • css2.1/20110323/abspos-replaced-width-margin-000-expected.txt: Removed. These results are superseded by the reference results.
  • css2.1/20110323/background-016.htm: Added to prove the CSS test suite reference results work.
  • css2.1/20110323/block-replaced-width-001.htm: Removed. This test does not pass its reference result. It regressed at some point.
  • css2.1/20110323/empty-inline-001.htm: The test has been updated from the CSS test suite.
  • css2.1/20110323/reftest.list: Added.
  • css2.1/reference/ref-filled-green-100px-square.htm: Added.
  • css2.1/reference/ref-filled-green-100px-square.xht: Added.
  • css2.1/reference/ref-if-there-is-no-red.htm: Added.
  • css2.1/reference/ref-if-there-is-no-red.xht: Added.
  • css2.1/reference/ref-nothing-below.htm: Added.
  • css2.1/reference/ref-nothing-below.xht: Added.
  • css2.1/reference/ref-this-text-should-be-green.htm: Added.
  • css2.1/reference/ref-this-text-should-be-green.xht: Added.

Ref test infrastructure from the CSS test suite.

  • platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-001-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/empty-inline-001-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/block-replaced-width-001-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/empty-inline-001-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/20110323/abspos-containing-block-initial-001-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/20110323/block-replaced-width-001-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/20110323/empty-inline-001-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/abspos-containing-block-initial-001-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/block-replaced-width-001-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/empty-inline-001-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/abspos-containing-block-initial-001-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/empty-inline-001-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/empty-inline-001-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.png: Removed.
  • platform/chromium/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.png: Removed.
  • platform/efl/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Removed.
  • platform/efl/css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Removed.
  • platform/efl/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.png: Removed.
  • platform/efl/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.txt: Removed.
  • platform/efl/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Removed.
  • platform/efl/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt: Removed.
  • platform/efl/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.png: Removed.
  • platform/efl/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.txt: Removed.
  • platform/efl/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Removed.
  • platform/efl/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt: Removed.
  • platform/efl/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.png: Removed.
  • platform/efl/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.txt: Removed.
  • platform/efl/css2.1/20110323/block-replaced-width-001-expected.png: Removed.
  • platform/efl/css2.1/20110323/block-replaced-width-001-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/abspos-containing-block-initial-001-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Removed.
  • platform/gtk/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.png: Removed.
  • platform/gtk/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Removed.
  • platform/gtk/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.png: Removed.
  • platform/gtk/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/block-replaced-width-001-expected.png: Removed.
  • platform/gtk/css2.1/20110323/block-replaced-width-001-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/empty-inline-001-expected.txt: Removed.
  • platform/mac-snowleopard/css2.1/20110323/abspos-containing-block-initial-001-expected.png: Removed.
  • platform/mac-snowleopard/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Removed.
  • platform/mac-snowleopard/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Removed.
  • platform/mac/css2.1/20110323/abspos-containing-block-initial-001-expected.txt: Removed.
  • platform/mac/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.txt: Removed.
  • platform/mac/css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Removed.
  • platform/mac/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.txt: Removed.
  • platform/mac/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Removed.
  • platform/mac/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt: Removed.
  • platform/mac/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.png: Removed.
  • platform/mac/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.txt: Removed.
  • platform/mac/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Removed.
  • platform/mac/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt: Removed.
  • platform/mac/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.png: Removed.
  • platform/mac/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.txt: Removed.
  • platform/mac/css2.1/20110323/block-replaced-width-001-expected.png: Removed.
  • platform/mac/css2.1/20110323/block-replaced-width-001-expected.txt: Removed.
  • platform/mac/css2.1/20110323/empty-inline-001-expected.png: Removed.
  • platform/mac/css2.1/20110323/empty-inline-001-expected.txt: Removed.
  • platform/qt/css2.1/20110323/abspos-containing-block-initial-001-expected.txt: Removed.
  • platform/qt/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.txt: Removed.
  • platform/qt/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Removed.
  • platform/qt/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.png: Removed.
  • platform/qt/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.txt: Removed.
  • platform/qt/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Removed.
  • platform/qt/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.png: Removed.
  • platform/qt/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.txt: Removed.
  • platform/qt/css2.1/20110323/block-replaced-width-001-expected.png: Removed.
  • platform/qt/css2.1/20110323/block-replaced-width-001-expected.txt: Removed.
  • platform/qt/css2.1/20110323/empty-inline-001-expected.txt: Removed.

These results are superseded by the reference results.

12:19 PM Changeset in webkit [115339] by jsbell@chromium.org
  • 14 edits in trunk/Source/WebKit/chromium

[Chromium] IndexedDB: Use WebIDBKeyPath type for key paths in WebKit API
https://bugs.webkit.org/show_bug.cgi?id=84631

Reviewed by James Robinson.

WebIDBKeyPath was previously a utility class for parsing key paths into components,
but the API exposed key paths only as nullable strings. To support array-type keypaths,
WebIDBKeyPath becomes a value class with type flags. For landing, several legacy methods
are retained but will be cleaned up after all callers have been updated, tracked as
the bug: http://webkit.org/b/84207

  • public/WebIDBDatabase.h:

(WebKit::WebIDBDatabase::createObjectStore): Add WebIDBKeyPath overload; WebString overload delegates so implementers can switch.

  • public/WebIDBIndex.h:

(WebKit::WebIDBIndex::keyPath): Calls keyPathString if not overridden.
(WebKit::WebIDBIndex::keyPathString): Comment change.

  • public/WebIDBKeyPath.h:

(WebKit::WebIDBKeyPath::create): Overload added for creating array-type key paths.
(WebKit::WebIDBKeyPath::array): Accessor for array-type key paths.
(WebKit::WebIDBKeyPath::operator const WebString ): Temporary, for compatibility.

  • public/WebIDBObjectStore.h:

(WebKit::WebIDBObjectStore::keyPath): Calls keyPathString if not overridden.
(WebKit::WebIDBObjectStore::keyPathString): Comment change.
(WebKit::WebIDBObjectStore::createIndex): Add WebIDBKeyPath overload; WebString overload delegates so implementers can switch.

  • public/platform/WebKitPlatformSupport.h:

(WebKitPlatformSupport): WebIDBKeyPath overloads for these methods added, delegate to WebString version until implementers are updated.
(WebKit::WebKitPlatformSupport::createIDBKeysFromSerializedValuesAndKeyPath):
(WebKit::WebKitPlatformSupport::injectIDBKeyIntoSerializedValue):

  • src/IDBIndexBackendProxy.cpp:

(WebKit::IDBIndexBackendProxy::keyPath): Returns the string version until WebCore is updated.

  • src/IDBObjectStoreBackendProxy.cpp:

(WebKit::IDBObjectStoreBackendProxy::keyPath): Returns the string version until WebCore is updated.

  • src/WebIDBDatabaseImpl.h:

(WebIDBDatabaseImpl): Add createObjectStore overload for WebIDBKeyPath type, delegates to WebString version until callers are updated.

  • src/WebIDBIndexImpl.cpp:

(WebKit::WebIDBIndexImpl::keyPath): Implements the new WebIDBKeyPath return type.
(WebKit):

  • src/WebIDBIndexImpl.h:

(WebIDBIndexImpl): Implements the new WebIDBKeyPath return type.

  • src/WebIDBKeyPath.cpp:

(WebKit::WebIDBKeyPath::create): Support null key path types.
(WebKit::WebIDBKeyPath::createNull): New API.
(WebKit):
(WebKit::WebIDBKeyPath::isValid): New API.
(WebKit::WebIDBKeyPath::type): New API.
(WebKit::WebIDBKeyPath::string): New API (value accessor).
(WebKit::WebIDBKeyPath::WebIDBKeyPath):
(WebKit::WebIDBKeyPath::assign): This API will be removed.
(WebKit::WebIDBKeyPath::operator const WTF::Vector<WTF::String, 0>&): Ensure it is non-null - only used in copy constructor which guards against this.

  • src/WebIDBObjectStoreImpl.cpp:

(WebKit::WebIDBObjectStoreImpl::keyPath): Implement the new WebIDBKeyPath return type.
(WebKit):

  • src/WebIDBObjectStoreImpl.h:

(WebIDBObjectStoreImpl): Add createIndex overload for WebIDBKeyPath type, delegates to WebString version until callers are updated.

12:01 PM Changeset in webkit [115338] by Carlos Garcia Campos
  • 3 edits in trunk/Tools

Unreviewed. Fix GTK+ build after r115314.

For some reason it fails while bulding GtkVersioning for WTR, but
it didn't fail neither in EWS nor in my laptop. We don't really
need GtkVersioning in WTR since it already depends on GTK+3
unconditionally.

  • WebKitTestRunner/GNUmakefile.am: Remove GtkVersioning.c from

compilation.

  • WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

(WTR::EventSenderProxy::createMouseButtonEvent): Use GTK+ 3 API
directly instead of getDefaultGDKPointerDevice() helper.
(WTR::EventSenderProxy::keyDown): Ditto.
(WTR::EventSenderProxy::mouseMoveTo): Ditto.

11:47 AM Changeset in webkit [115337] by ojan@chromium.org
  • 8 edits in trunk/Tools

Show flakiness dashboard data in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=83716

Reviewed by Dimitri Glazkov.

Put an iframe below the expected/actual results in the Results view.
Size the iframe to it's height.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
11:44 AM Changeset in webkit [115336] by Antti Koivisto
  • 6 edits in trunk/Source/WebCore

Implement StyleSheetInternal copying
https://bugs.webkit.org/show_bug.cgi?id=84969

Reviewed by Andreas Kling.

We need to be able to copy stylesheets to cache them. Copying is already implement for
most of the stylesheet data types but StyleSheetInternal::copy() is still missing.

Preparation for stylesheet caching. The copying code is not used yet.

  • css/CSSNamespace.h:


Instead of making it copyable, remove CSSNamespace class.


  • css/CSSParser.cpp:

(WebCore::operator==):
(WebCore):
(WebCore::CSSParser::addNamespace):

Avoid ping-ponging to StyleSheetInternal and back to set the default namespace.

  • css/CSSParserMode.h:

(WebCore):
(WebCore::operator!=):

Add equality comparison operator to CSSParseMode. This will be needed to determine
if a cached copy can be used.


  • css/CSSStyleSheet.cpp:

(WebCore::StyleSheetInternal::StyleSheetInternal):
(WebCore):
(WebCore::StyleSheetInternal::isCacheable):
(WebCore::StyleSheetInternal::parserAddNamespace):
(WebCore::StyleSheetInternal::determineNamespace):

Use HashMap instead of iterating a linked list of CSSNamespaces.

(WebCore::StyleSheetInternal::styleSheetChanged):

Add mutation bit.

  • css/CSSStyleSheet.h:

(WebCore):
(StyleSheetInternal):
(WebCore::StyleSheetInternal::copy):

Copy constructor. It only usable for cacheable stylesheets.

11:24 AM Changeset in webkit [115335] by pdr@google.com
  • 3 edits
    2 adds in trunk

Fix Skia's SkPathContainsPoint to work with sub-pixel accuracy
https://bugs.webkit.org/show_bug.cgi?id=84117

Reviewed by Eric Seidel.

Source/WebCore:

Because we do hit testing in object-space (i.e., we may see a 0.1px*0.1px path) we
need to support sub-pixel hit testing in Skia. Skia does not provide analytical
path hit testing, so hit tests are done by rasterizing a path and checking if a
specific pixel is drawn. SkPathContainsPoint did not work with sub-pixel values
because this rasterization was sometimes very small which did not give enough
resolution to check if the hit test pixel was drawn.

This patch scales the path to a very large size during hit testing so that Skia's
raster-based hit testing will work properly. Because Skia avoids unnecessary
path rasterization, this is actually inexpensive.

Below is a summary of a performance test on simple and complex paths:

(before patch, after patch)

Skia/Chrome 10,000 hit tests on a simple path: (229ms, 238ms)
Skia/Chrome 10,000 hit tests on a complex path: (701ms, 704ms)
For comparison, CG/Safari takes 236ms on the simple path and 466ms on the complex path.

Therefore, this patch introduces small but measurable regression in hit testing
performance due to scaling the path.

Test: svg/hittest/svg-small-path.xhtml

  • platform/graphics/skia/SkiaUtils.cpp:

(WebCore::SkPathContainsPoint):

LayoutTests:

  • svg/hittest/svg-small-path-expected.txt: Added.
  • svg/hittest/svg-small-path.xhtml: Added.
11:20 AM Changeset in webkit [115334] by commit-queue@webkit.org
  • 8 edits
    2 deletes in trunk

Unreviewed, rolling out r115323.
http://trac.webkit.org/changeset/115323
https://bugs.webkit.org/show_bug.cgi?id=84975

Bad test, breaks all builds (Requested by apavlov1 on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-26

Source/WebCore:

  • inspector/Inspector.json:
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::enable):
(WebCore::InspectorPageAgent::disable):

  • inspector/InspectorPageAgent.h:
  • inspector/front-end/Settings.js:
  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):

  • inspector/front-end/inspector.js:

LayoutTests:

  • inspector/debugger/disable-script-expected.txt: Removed.
  • inspector/debugger/disable-script.html: Removed.
11:12 AM Changeset in webkit [115333] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

IndexedDB: cursor does not correctly iterate over keys added and removed during iteration
https://bugs.webkit.org/show_bug.cgi?id=84467

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-04-26
Reviewed by Ojan Vafai.

Source/WebCore:

Ensure that the iterator over the tree of cached adds/removes always points at
the current key, or if the db iterator is current, the next key:

  • When refreshing the tree iterator after a mutation, always seek unless the

tree iterator is current.

  • When handing conflicts and delete markers, only advance the tree iterator as

far as the db iterator.

Remove the expensive (and now redundant) logic that issued a get() to check
whether an item had been deleted.

Test: storage/indexeddb/cursor-added-bug.html

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore):

  • platform/leveldb/LevelDBTransaction.cpp:

(WebCore::LevelDBTransaction::TransactionIterator::refreshTreeIterator):
(WebCore::LevelDBTransaction::TransactionIterator::handleConflictsAndDeletes):

LayoutTests:

New test for keys added in reverse order during cursor iteration.

  • storage/indexeddb/cursor-added-bug-expected.txt: Added.
  • storage/indexeddb/cursor-added-bug.html: Added.
  • storage/indexeddb/resources/cursor-added-bug.js: Added.

(test):
(openSuccess):
(setVersionSuccess):
(openCursor):
(cursorSuccess):

11:09 AM Changeset in webkit [115332] by commit-queue@webkit.org
  • 8 edits in trunk

[EFL] [DRT] LayoutTestController needs implementation of setJavaScriptProfilingEnabled
https://bugs.webkit.org/show_bug.cgi?id=84576

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-26
Reviewed by Martin Robinson.

Source/WebKit/efl:

Add missing implementation setJavaScriptProfilingEnabled to EFL's
DumpRenderTreeSupport. This setting allows layout tests to start
JavaScript profiling.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::setJavaScriptProfilingEnabled):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Add missing implementation setJavaScriptProfilingEnabled to EFL's
LayoutTestController in order to unskip tests rely on this setting.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setJavaScriptProfilingEnabled):

LayoutTests:

Unskip test cases which rely on LayoutTestController's
setJavaScriptProfilingEnabled implementation.

  • platform/efl/Skipped:
11:07 AM Changeset in webkit [115331] by Lucas Forschler
  • 2 edits in tags/Safari-536.8.2/Source/JavaScriptCore

Merged r115253.

11:05 AM Changeset in webkit [115330] by Lucas Forschler
  • 2 edits in tags/Safari-536.8.2/Source/JavaScriptCore

Merged r115252.

11:02 AM Changeset in webkit [115329] by Lucas Forschler
  • 4 edits
    3 copies in tags/Safari-536.8.2

Merged r115096.

10:52 AM Changeset in webkit [115328] by wangxianzhu@chromium.org
  • 2 edits in trunk/Tools

Add Jing Zhao, Min Qin, Tien-Ren Chen and Hao Zheng into contributors list.

Not reviewed.

  • Scripts/webkitpy/common/config/committers.py:
10:27 AM Changeset in webkit [115327] by Lucas Forschler
  • 4 edits in tags/Safari-536.8.2/Source

Versioning.

10:25 AM Changeset in webkit [115326] by Lucas Forschler
  • 1 copy in tags/Safari-536.8.2

New Tag.

10:22 AM HackingWebInspector edited by alex.bravo@nokia.com
(diff)
10:01 AM Changeset in webkit [115325] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] webaudio/audioparam-exponentialRampToValueAtTime.html is occasionally crashing
https://bugs.webkit.org/show_bug.cgi?id=84972

  • platform/chromium/test_expectations.txt: Marked as flaky.
9:52 AM Changeset in webkit [115324] by jer.noble@apple.com
  • 4 edits in trunk/Source

Placeholder view is immediately removed from hosting window upon entering full screen.
https://bugs.webkit.org/show_bug.cgi?id=84916

Reviewed by Darin Adler.

Correct a mistake added in r114567. When swapping view for otherView, add otherView and
remove view (rather than adding otherView and removing otherView).

Source/WebKit/mac:

  • WebView/WebFullScreenController.mm:

(-[WebFullScreenController _swapView:with:]):

Source/WebKit2:

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController _swapView:with:]):

9:44 AM Changeset in webkit [115323] by apavlov@chromium.org
  • 8 edits
    2 adds in trunk

Web Inspector: Implement the "Disable JavaScript" option in the settings dialog
https://bugs.webkit.org/show_bug.cgi?id=84946

Source/WebCore:

Based on user actions in the Inspector frontend, InspectorPageAgent invokes Settings::setScriptEnabled()
for the associated page to switch the script execution therein.

Reviewed by Yury Semikhatsky.

Test: inspector/debugger/disable-script.html

  • inspector/Inspector.json:
  • inspector/InspectorPageAgent.cpp:

(PageAgentState):
(WebCore::InspectorPageAgent::enable):
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::getScriptExecutionStatus):
(WebCore):
(WebCore::InspectorPageAgent::setScriptExecutionDisabled):

  • inspector/InspectorPageAgent.h:
  • inspector/front-end/Settings.js:
  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):
(WebInspector.SettingsScreen.prototype.get _updateScriptDisabledCheckbox):
(WebInspector.SettingsScreen.prototype._javaScriptDisabledChanged):

  • inspector/front-end/inspector.js:

LayoutTests:

Reviewed by Yury Semikhatsky.

  • inspector/debugger/disable-script-expected.txt: Added.
  • inspector/debugger/disable-script.html: Added.
9:19 AM Changeset in webkit [115322] by Carlos Garcia Campos
  • 3 edits in trunk/Tools

[GTK] Test TestWebKitAPI/WebKit2/TestNewFirstVisuallyNonEmptyLayout times out
https://bugs.webkit.org/show_bug.cgi?id=84957

Reviewed by Martin Robinson.

  • Scripts/run-gtk-tests:

(TestRunner): Unskip TestNewFirstVisuallyNonEmptyLayout and
TestNewFirstVisuallyNonEmptyLayoutForImages.

  • TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:

(TestWebKitAPI::PlatformWebView::PlatformWebView): Show the
toplevel window containing the web view to make sure events are
received.

9:13 AM Changeset in webkit [115321] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

[cairo] CairoGraphicsContext fillRect (with Color) overrides composite operator
https://bugs.webkit.org/show_bug.cgi?id=84848

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-26
Reviewed by Martin Robinson.

Source/WebCore:

FillRectWithColor used to be called fillRectSourceOver before r89314
where this operator still made sense. The way this function is used
these days doesn't expect the composite operator to be overridden anymore.

No new tests, covered by existing tests, e.g.
svg/filters/feDropShadow.svg

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::fillRectWithColor):

LayoutTests:

Unskipping and baselining feDropShadow test,
now works because of composite operator fix.
Fixed png baseline result for drop shadow test on GTK.

  • platform/efl/svg/filters/feDropShadow-expected.png: Added.
  • platform/efl/svg/filters/feDropShadow-expected.txt: Added.
  • platform/efl/test_expectations.txt:
  • platform/gtk/svg/filters/feDropShadow-expected.png:
8:51 AM Changeset in webkit [115320] by Nikolas Zimmermann
  • 9 edits
    46 adds in trunk

Fix additive by animations for most SMIL list types
https://bugs.webkit.org/show_bug.cgi?id=84968

Reviewed by Antti Koivisto.

Source/WebCore:

Unify SMIL list animation code, to correctly respect the underlying from value for by-animations.
Add lots of new tests covering by-animations for all primitives (except AnimatedPath/TransformList).
AnimatedTransformList is not working correctly yet, and will be covered in a follow-up patch.
AnimatdPath by-animations are complex, and thus also handled in another follow-up patch.

Tests: svg/animations/additive-type-by-animation.html

svg/animations/length-list-animation-expected.svg
svg/animations/length-list-animation.svg
svg/animations/svglength-additive-by-1.html
svg/animations/svglength-additive-by-2.html
svg/animations/svglength-additive-by-3.html
svg/animations/svglength-additive-by-4.html
svg/animations/svglength-additive-by-5.html
svg/animations/svglength-additive-by-6.html
svg/animations/svglength-additive-from-by-1.html
svg/animations/svglength-additive-from-by-2.html
svg/animations/svglength-additive-from-by-3.html
svg/animations/svglength-additive-from-by-4.html

  • svg/SVGAnimatedLengthList.cpp:

(WebCore::SVGAnimatedLengthListAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedNumberList.cpp:

(WebCore::SVGAnimatedNumberListAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedNumberListAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedPointList.cpp:

(WebCore::SVGAnimatedPointListAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedPointListAnimator::calculateAnimatedValue):

  • svg/SVGAnimationElement.h:

(WebCore::SVGAnimationElement::adjustFromToListValues):

LayoutTests:

Add lots of new tests covering SMIL by-animations on all primitives.

  • svg/animations/additive-type-by-animation-expected.txt: Added.
  • svg/animations/additive-type-by-animation.html: Added.
  • svg/animations/length-list-animation-expected.svg: Added.
  • svg/animations/length-list-animation.svg: Added.
  • svg/animations/non-additive-type-by-animation-expected.txt:
  • svg/animations/resources/additive-type-by-animation.svg: Added.
  • svg/animations/resources/non-additive-type-by-animation.svg:
  • svg/animations/resources/svglength-additive-by-1.svg: Added.
  • svg/animations/resources/svglength-additive-by-2.svg: Added.
  • svg/animations/resources/svglength-additive-by-3.svg: Added.
  • svg/animations/resources/svglength-additive-by-4.svg: Added.
  • svg/animations/resources/svglength-additive-by-5.svg: Added.
  • svg/animations/resources/svglength-additive-by-6.svg: Added.
  • svg/animations/resources/svglength-additive-from-by-1.svg: Added.
  • svg/animations/resources/svglength-additive-from-by-2.svg: Added.
  • svg/animations/resources/svglength-additive-from-by-3.svg: Added.
  • svg/animations/resources/svglength-additive-from-by-4.svg: Added.
  • svg/animations/script-tests/additive-type-by-animation.js: Added.

(checkBaseVal):
(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/non-additive-type-by-animation.js:

(sample):

  • svg/animations/script-tests/svglength-additive-by-1.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(executeTest):

  • svg/animations/script-tests/svglength-additive-by-2.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(executeTest):

  • svg/animations/script-tests/svglength-additive-by-3.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(sample6):
(executeTest):

  • svg/animations/script-tests/svglength-additive-by-4.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(sample6):
(executeTest):

  • svg/animations/script-tests/svglength-additive-by-5.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(sample6):
(executeTest):

  • svg/animations/script-tests/svglength-additive-by-6.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(sample6):
(executeTest):

  • svg/animations/script-tests/svglength-additive-from-by-1.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(executeTest):

  • svg/animations/script-tests/svglength-additive-from-by-2.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(sample6):
(executeTest):

  • svg/animations/script-tests/svglength-additive-from-by-3.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(sample6):
(executeTest):

  • svg/animations/script-tests/svglength-additive-from-by-4.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(sample6):
(executeTest):

  • svg/animations/svglength-additive-by-1-expected.txt: Added.
  • svg/animations/svglength-additive-by-1.html: Added.
  • svg/animations/svglength-additive-by-2-expected.txt: Added.
  • svg/animations/svglength-additive-by-2.html: Added.
  • svg/animations/svglength-additive-by-3-expected.txt: Added.
  • svg/animations/svglength-additive-by-3.html: Added.
  • svg/animations/svglength-additive-by-4-expected.txt: Added.
  • svg/animations/svglength-additive-by-4.html: Added.
  • svg/animations/svglength-additive-by-5-expected.txt: Added.
  • svg/animations/svglength-additive-by-5.html: Added.
  • svg/animations/svglength-additive-by-6-expected.txt: Added.
  • svg/animations/svglength-additive-by-6.html: Added.
  • svg/animations/svglength-additive-from-by-1-expected.txt: Added.
  • svg/animations/svglength-additive-from-by-1.html: Added.
  • svg/animations/svglength-additive-from-by-2-expected.txt: Added.
  • svg/animations/svglength-additive-from-by-2.html: Added.
  • svg/animations/svglength-additive-from-by-3-expected.txt: Added.
  • svg/animations/svglength-additive-from-by-3.html: Added.
  • svg/animations/svglength-additive-from-by-4-expected.txt: Added.
  • svg/animations/svglength-additive-from-by-4.html: Added.
8:43 AM Changeset in webkit [115319] by Antti Koivisto
  • 4 edits in trunk/Source/WebCore

Add copy constructor to CSSSelector
https://bugs.webkit.org/show_bug.cgi?id=84956

Reviewed by Anders Carlsson.

To copy CSSSelectorLists correctly CSSSelector needs a copy constructor.

This will be needed to implement stylesheet caching. The code is not used yet.

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::createRareData):

  • css/CSSSelector.h:

(CSSSelector):
(WebCore::CSSSelector::RareData::create):
(RareData):

Refcount RareData to make copying easier. This has no significant memory impact, rare data is rare.

(WebCore::CSSSelector::CSSSelector):
(WebCore):
(WebCore::CSSSelector::~CSSSelector):

  • css/CSSSelectorList.cpp:

(WebCore::CSSSelectorList::CSSSelectorList):

Use copy constructor instead of memcpy (which doesn't work).

8:28 AM WebKitGTK/1.8.x edited by mrobinson@webkit.org
Reflect the correct versions, added a section for 1.8.2 (diff)
8:15 AM Changeset in webkit [115318] by rakuco@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Fix the build with DRAG_SUPPORT disabled.
https://bugs.webkit.org/show_bug.cgi?id=84963

Reviewed by Antonio Gomes.

No new tests, build system-related change.

EventHandlerEfl.cpp always assumed DRAG_SUPPORT was enabled and lacked
the proper #if ENABLED() checks for some member variables and methods
conditionally defined in EventHandler.h.

  • page/efl/EventHandlerEfl.cpp:

(WebCore):

8:14 AM Changeset in webkit [115317] by pfeldman@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: remove stackTrace property from requestWillBeSent - it is already a part of the initiator.
https://bugs.webkit.org/show_bug.cgi?id=84964

Reviewed by Yury Semikhatsky.

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::willSendRequest):

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._formatMessage):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
(WebInspector.NetworkDispatcher.prototype.requestServedFromMemoryCache):
(WebInspector.NetworkDispatcher.prototype._appendRedirect):
(WebInspector.NetworkDispatcher.prototype._createNetworkRequest):
(get WebInspector):

8:06 AM Changeset in webkit [115316] by schenney@chromium.org
  • 19 edits
    16 adds in trunk

SVG FEConvolveMatrix does not check for invalid property values
https://bugs.webkit.org/show_bug.cgi?id=84363

Reviewed by Dirk Schulze.

Source/WebCore:

Adding code to check for valid input values on SVG feConvolveMatrix properties.
And adding some of the first effective error reporting for SVG elements.

Tests: svg/filters/feConvolveMatrix-invalid-targetX-expected.svg

svg/filters/feConvolveMatrix-invalid-targetX.svg
svg/filters/feConvolveMatrix-invalid-targetY-expected.svg
svg/filters/feConvolveMatrix-invalid-targetY.svg
svg/filters/feConvolveMatrix-negative-kernelUnitLengthX-expected.svg
svg/filters/feConvolveMatrix-negative-kernelUnitLengthX.svg
svg/filters/feConvolveMatrix-negative-kernelUnitLengthY-expected.svg
svg/filters/feConvolveMatrix-negative-kernelUnitLengthY.svg
svg/filters/feConvolveMatrix-negative-orderX-expected.svg
svg/filters/feConvolveMatrix-negative-orderX.svg
svg/filters/feConvolveMatrix-negative-orderY-expected.svg
svg/filters/feConvolveMatrix-negative-orderY.svg
svg/filters/feConvolveMatrix-non-integral-order-expected.svg
svg/filters/feConvolveMatrix-non-integral-order.svg
svg/filters/feConvolveMatrix-zero-divisor-expected.svg
svg/filters/feConvolveMatrix-zero-divisor.svg

  • platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::FEConvolveMatrix):
(WebCore::FEConvolveMatrix::setKernelSize):
(WebCore::FEConvolveMatrix::setDivisor):
(WebCore::FEConvolveMatrix::setKernelUnitLength):

  • svg/SVGFEConvolveMatrixElement.cpp:

(WebCore::SVGFEConvolveMatrixElement::parseAttribute):
(WebCore::SVGFEConvolveMatrixElement::build):

LayoutTests:

Adding code to check for valid input values on SVG feConvolveMatrix properties.

  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
  • platform/efl/svg/filters/feConvolveFilter-y-bounds-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
  • platform/gtk/svg/custom/convolution-crash-expected.txt:
  • platform/gtk/svg/filters/feConvolveFilter-y-bounds-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
  • platform/mac/svg/custom/convolution-crash-expected.txt:
  • platform/mac/svg/filters/feConvolveFilter-y-bounds-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
  • platform/qt/svg/custom/convolution-crash-expected.txt:
  • platform/qt/svg/filters/feConvolveFilter-y-bounds-expected.txt:
  • svg/filters/feConvolveMatrix-invalid-targetX-expected.svg: Added.
  • svg/filters/feConvolveMatrix-invalid-targetX.svg: Added.
  • svg/filters/feConvolveMatrix-invalid-targetY-expected.svg: Added.
  • svg/filters/feConvolveMatrix-invalid-targetY.svg: Added.
  • svg/filters/feConvolveMatrix-negative-kernelUnitLengthX-expected.svg: Added.
  • svg/filters/feConvolveMatrix-negative-kernelUnitLengthX.svg: Added.
  • svg/filters/feConvolveMatrix-negative-kernelUnitLengthY-expected.svg: Added.
  • svg/filters/feConvolveMatrix-negative-kernelUnitLengthY.svg: Added.
  • svg/filters/feConvolveMatrix-negative-orderX-expected.svg: Added.
  • svg/filters/feConvolveMatrix-negative-orderX.svg: Added.
  • svg/filters/feConvolveMatrix-negative-orderY-expected.svg: Added.
  • svg/filters/feConvolveMatrix-negative-orderY.svg: Added.
  • svg/filters/feConvolveMatrix-non-integral-order-expected.svg: Added.
  • svg/filters/feConvolveMatrix-non-integral-order.svg: Added.
  • svg/filters/feConvolveMatrix-zero-divisor-expected.svg: Added.
  • svg/filters/feConvolveMatrix-zero-divisor.svg: Added.
8:01 AM Changeset in webkit [115315] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

Unreviewed. Add bug numbers to skipped tests.

  • Scripts/run-gtk-tests:

(TestRunner):

7:47 AM Changeset in webkit [115314] by Carlos Garcia Campos
  • 12 edits
    2 copies
    3 adds in trunk

[GTK] Build and run TestWebKitAPI WebKit2 unit tests
https://bugs.webkit.org/show_bug.cgi?id=84446

Reviewed by Philippe Normand.

Source/ThirdParty:

  • gtest/GNUmakefile.am: Do not build libgtestmain anymmore since

all tests use now a custom main to make sure WTF threads are
initialized.

Source/WebKit2:

  • UIProcess/API/C/WKNativeEvent.h: Define WKNativeEventPtr as

GdkEvent for the GTK+ port.

Tools:

  • Scripts/run-gtk-tests:

(TestRunner): Add TestWebKitAPI/WebKit2 to the list of directories
containing tests. Unskip FunctionalTest.RefCountedStorage, since
we are now using a custom main that initializes WTF threading.
(TestRunner._setup_testing_environment): Set environment variables
required to run WebKit2 tests.

  • TestWebKitAPI/GNUmakefile.am:
  • TestWebKitAPI/JavaScriptTest.cpp: Use

JavaScriptCore/JSContextRef.h instead of
JavaScriptCore/JavaScriptCore.h since it includes JSStringRefCF.h
unconditionally.

  • TestWebKitAPI/PlatformWebView.h: Define PlatformWKView and

PlatformWindow for GTK.

  • TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp: Remove

unneded header that breaks the build of GTK port.

  • TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp: Use

JavaScriptCore/JSContextRef.h instead of
JavaScriptCore/JavaScriptCore.h since it includes JSStringRefCF.h
unconditionally.

  • TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:

(TestWebKitAPI::TEST): Add expected values for GTK+ port.

  • TestWebKitAPI/gtk/InjectedBundleControllerGtk.cpp:

(TestWebKitAPI):
(TestWebKitAPI::InjectedBundleController::platformInitialize):

  • TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp: Added.

(TestWebKitAPI::Util::checkTestFinished):
(TestWebKitAPI::Util::run):
(TestWebKitAPI::Util::sleep):
(TestWebKitAPI::Util::getFilenameFromEnvironmentVariableAsUTF8):
(TestWebKitAPI::Util::createInjectedBundlePath):
(TestWebKitAPI::Util::createURLForResource):
(TestWebKitAPI::Util::URLForNonExistentResource):
(TestWebKitAPI::Util::isKeyDown):

  • TestWebKitAPI/gtk/PlatformWebViewGtk.cpp: Added.

(TestWebKitAPI::PlatformWebView::PlatformWebView):
(TestWebKitAPI::PlatformWebView::~PlatformWebView):
(TestWebKitAPI::PlatformWebView::page):
(TestWebKitAPI::PlatformWebView::resizeTo):
(TestWebKitAPI::doKeyStroke):
(TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
(TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
(TestWebKitAPI::doMouseButtonEvent):
(TestWebKitAPI::PlatformWebView::simulateRightClick):
(TestWebKitAPI::PlatformWebView::simulateMouseMove):

  • TestWebKitAPI/gtk/main.cpp:

(main):

7:45 AM Changeset in webkit [115313] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] run-gtk-tests: Use a timeout per test instead of a global timeout
https://bugs.webkit.org/show_bug.cgi?id=84695

Reviewed by Philippe Normand.

It also adds a command line option to be able to pass a custom
timeout value, instead of hard-coding it. The default timeout is 10
seconds if no other value is passed to the script.

  • Scripts/run-gtk-tests:

(TestTimeout): Exception raised when a test times out.
(TestRunner._get_child_pid_from_test_output): Helper function to
get the pid of the running test from gtester output.
(TestRunner._kill_process): Helper funtion ot kill a process
ignoring exceptions if the process is already died.
(TestRunner._run_test_command): Run the test command raising
TestTimeout exception if the test doesn't finish before the given
timeout in seconds.
(TestRunner._run_test_command.alarm_handler): Alarm handler that
raises TestTimeout exception.
(TestRunner._run_test_glib): Use _run_test_command() to run the test.
(TestRunner._run_test_google): Ditto.
(TestRunner.run_tests): Add current test to the list of timed out
test if TestTimeout exception is raised. Show the list of timed
out test at the end.

7:30 AM Changeset in webkit [115312] by commit-queue@webkit.org
  • 8 edits
    2 deletes in trunk/Source

Move WebKit1 specific conversion of touch-events to WebKit1.
https://bugs.webkit.org/show_bug.cgi?id=84951

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-26
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

No change in functionality. No new tests.

  • Target.pri:
  • platform/PlatformTouchEvent.h:

(PlatformTouchEvent):

  • platform/PlatformTouchPoint.h:

(PlatformTouchPoint):

  • platform/qt/PlatformTouchEventQt.cpp: Removed.
  • platform/qt/PlatformTouchPointQt.cpp: Removed.

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPagePrivate::touchEvent):

  • WebCoreSupport/WebEventConversion.cpp:

(WebKitPlatformTouchEvent):
(WebKitPlatformTouchPoint):
(WebCore::WebKitPlatformTouchEvent::WebKitPlatformTouchEvent):
(WebCore::WebKitPlatformTouchPoint::WebKitPlatformTouchPoint):
(WebCore::convertTouchEvent):

  • WebCoreSupport/WebEventConversion.h:
7:11 AM Changeset in webkit [115311] by abecsi@webkit.org
  • 4 edits in trunk/Source/WebKit2

[Qt][WK2] Tap highlight should have a delay not to interfere with panning
https://bugs.webkit.org/show_bug.cgi?id=84948

Reviewed by Kenneth Rohde Christiansen.

Start the tap highlight animation after a slight delay so that pan
gestures do not result in flashing highlight rects which slow down
flicking, especially during continuous pan gestures.

  • UIProcess/qt/QtTapGestureRecognizer.cpp:

(WebKit::QtTapGestureRecognizer::update):
(WebKit::QtTapGestureRecognizer::highlightTimeout):
(WebKit):
(WebKit::QtTapGestureRecognizer::reset):
(WebKit::QtTapGestureRecognizer::timerEvent):

  • UIProcess/qt/QtTapGestureRecognizer.h:

(QtTapGestureRecognizer):

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(WebKit::QtWebPageEventHandler::doneWithTouchEvent):

7:08 AM April 2012 Keeping the bots green edited by aroben@webkit.org
Fix indentation, add real headings (diff)
7:06 AM Changeset in webkit [115310] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebKit2

Make it possible to use accelerated compositing for page overlay fading
https://bugs.webkit.org/show_bug.cgi?id=82336

Patch by Lars Knudsen <lars.knudsen@nokia.com> on 2012-04-26
Reviewed by Noam Rosenthal.

Page overlay fading will use AC where possible. Otherwise, it will
fall back to the previous method of redrawing each frame in the animation.

  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::setPageOverlayOpacity):
(DrawingArea):
(WebKit::DrawingArea::pageOverlayShouldApplyFadeWhenPainting):

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::setPageOverlayOpacity):
(WebKit):
(WebKit::DrawingAreaImpl::pageOverlayShouldApplyFadeWhenPainting):

  • WebProcess/WebPage/DrawingAreaImpl.h:

(DrawingAreaImpl):

  • WebProcess/WebPage/LayerTreeHost.h:

(WebKit::LayerTreeHost::setPageOverlayOpacity):
(WebKit::LayerTreeHost::pageOverlayShouldApplyFadeWhenPainting):

  • WebProcess/WebPage/PageOverlay.cpp:

(WebKit::PageOverlay::PageOverlay):
(WebKit::PageOverlay::setPage):
(WebKit::PageOverlay::fadeAnimationTimerFired):

  • WebProcess/WebPage/PageOverlay.h:
  • WebProcess/WebPage/TapHighlightController.cpp:

(WebKit::TapHighlightController::drawRect):

  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::setPageOverlayOpacity):
(WebKit):

  • WebProcess/WebPage/qt/LayerTreeHostQt.h:

(LayerTreeHostQt):
(WebKit::LayerTreeHostQt::pageOverlayShouldApplyFadeWhenPainting):

7:05 AM Changeset in webkit [115309] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][DRT] Unskip media tests that were already fixed in r113178
https://bugs.webkit.org/show_bug.cgi?id=84947

Unreviewed, EFL gardening.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-26

  • platform/efl/Skipped: Removed a group of media tests.
6:55 AM Changeset in webkit [115308] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] A quick fix to the previous patch r115245.
https://bugs.webkit.org/show_bug.cgi?id=84862

Patch by Yong Li <yoli@rim.com> on 2012-04-26
Reviewed by Antonio Gomes.

Fix an obvious bug in previous patch: DeferredTaskLoadManualScript
was using a wrong flag.

  • Api/WebPage.cpp:
  • Api/WebPage_p.h:

(WebPagePrivate):

6:43 AM Changeset in webkit [115307] by commit-queue@webkit.org
  • 5 edits in trunk

[EFL] [DRT] LayoutTestController needs implementation of addOriginAccessWhitelistEntry and removeOriginAccessWhitelistEntry
https://bugs.webkit.org/show_bug.cgi?id=83880

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-26
Reviewed by Antonio Gomes.

Tools:

Add missing implementation addOriginAccessWhitelistEntry and
removeOriginAccessWhitelistEntry to EFL's LayoutTestController
in order to unskip tests which rely on this.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::addOriginAccessWhitelistEntry):
(LayoutTestController::removeOriginAccessWhitelistEntry):

LayoutTests:

Unskip test cases which rely on LayoutTestController's addOriginAccessWhitelistEntry
and removeOriginAccessWhitelistEntry implementation.

  • platform/efl/Skipped:
6:34 AM Changeset in webkit [115306] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] WebGL support ewk_view setting
https://bugs.webkit.org/show_bug.cgi?id=84534

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-04-26
Reviewed by Antonio Gomes.

Exporting new ewk_view setting: webGLEnabled - enbles/disables WebGL support.

  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(ewk_view_setting_enable_webgl_get):
(ewk_view_setting_enable_webgl_set):

  • ewk/ewk_view.h:
6:14 AM Changeset in webkit [115305] by Nikolas Zimmermann
  • 14 edits in trunk/Source/WebCore

Share code used to animate numbers types between all animators
https://bugs.webkit.org/show_bug.cgi?id=84945

Reviewed by Antti Koivisto.

Refactor animateAdditiveNumber() from SVGAnimatedNumberAnimator into SVGAnimationElement,
to reuse it for all primitives. Converted most primitives to use the new code. Lists, paths,
colors are still todo.

Doesn't affect any tests.

  • svg/SVGAnimatedAngle.cpp:

(WebCore::SVGAnimatedAngleAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedInteger.cpp:

(WebCore::SVGAnimatedIntegerAnimator::calculateAnimatedInteger):
(WebCore::SVGAnimatedIntegerAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedInteger.h:

(SVGAnimatedIntegerAnimator):

  • svg/SVGAnimatedIntegerOptionalInteger.cpp:

(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedLength.cpp:

(WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedLengthList.cpp:

(WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedNumber.cpp:

(WebCore::SVGAnimatedNumberAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedNumber.h:
  • svg/SVGAnimatedNumberList.cpp:

(WebCore::SVGAnimatedNumberListAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedNumberOptionalNumber.cpp:

(WebCore::SVGAnimatedNumberOptionalNumberAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedNumberOptionalNumber.h:
  • svg/SVGAnimatedRect.cpp:

(WebCore::SVGAnimatedRectAnimator::calculateAnimatedValue):

  • svg/SVGAnimationElement.h:

(WebCore::SVGAnimationElement::animateAdditiveNumber):
(SVGAnimationElement):

5:08 AM SettingUpDevelopmentEnvironmentForN9 edited by zarvai@inf.u-szeged.hu
(diff)
4:59 AM SettingUpDevelopmentEnvironmentForN9 edited by zarvai@inf.u-szeged.hu
(diff)
4:52 AM Changeset in webkit [115304] by ahf@0x90.dk
  • 2 edits in trunk/Source/WebKit2

[Qt] r115300 broke the Qt build on Mac OS X.

This patch adds guards around the createPluginContainer and
windowedPluginGeometryDidChange member functions in WebPageProxy.

Unreviewed build fix.

  • UIProcess/qt/WebPageProxyQt.cpp:

(WebKit):

4:51 AM Changeset in webkit [115303] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Web Inspector: [CRASH] WebViewImpl::setZoomLevel when emulating device metrics
https://bugs.webkit.org/show_bug.cgi?id=84938

Check for the presence of a live Frame/FrameView before invoking methods that depend on them.

Reviewed by Yury Semikhatsky.

  • src/WebDevToolsAgentImpl.cpp:

(WebKit::DeviceMetricsSupport::restore):

4:45 AM Changeset in webkit [115302] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Forgotten build fix after r115227.

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::get4Values):

4:42 AM SettingUpDevelopmentEnvironmentForN9 edited by zarvai@inf.u-szeged.hu
(diff)
4:01 AM Changeset in webkit [115301] by Carlos Garcia Campos
  • 3 edits
    2 adds in trunk/Tools

[GTK] Add downloads support to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=73662

Reviewed by Philippe Normand.

  • MiniBrowser/gtk/BrowserDownloadsBar.c: Added.

(browserDownloadsBarChildRemoved): Close the downloads bar if
there aren't active downloads.
(browserDownloadsBarResponse): Destroy the downloads bar when
closed.
(browser_downloads_bar_init):
(browser_downloads_bar_class_init):
(browser_downloads_bar_new): Create a new downloads bar.
(actionButtonClicked): Cancel the download if cancel button was
clicked, or open the downloaded file if the download finished.
(browserDownloadFinalize):
(browser_download_init):
(browser_download_class_init):
(downloadReceivedResponse): Update download message using the
response URI.
(remainingTime): Helper function to get human readable remaining
time.
(downloadProgress): Update downloads progress.
(downloadReceivedData):
(downloadFinished): Update download message and turn download
button into open.
(downloadFailed): Show error message or destroy the download UI if
it was cancelled.
(browserDownloadNew): Create a new download widget for the given
WebKitDownload.
(browser_downloads_bar_add_download): Add download widget to the
downloads bar.

  • MiniBrowser/gtk/BrowserDownloadsBar.h: Added.
  • MiniBrowser/gtk/BrowserWindow.c:

(downloadStarted): Create a download widget and add it to the
downloads bar when a new download is started.
(browserWindowConstructed): Connect to
WebKitWebContext::download-started signal.

  • MiniBrowser/gtk/GNUmakefile.am: Add new files to compilation.
3:58 AM Changeset in webkit [115300] by Carlos Garcia Campos
  • 18 edits in trunk/Source/WebKit2

[GTK][WebKit2] Initial windowed plugins implementation
https://bugs.webkit.org/show_bug.cgi?id=61065

Reviewed by Philippe Normand.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::createPluginContainer):
(WebKit::PluginControllerProxy::windowedPluginGeometryDidChange):

  • PluginProcess/PluginControllerProxy.h:
  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseContainerAdd): Implement GtkContainer::add().
(webkitWebViewBaseContainerRemove): Implement GtkContainer::remove().
(webkitWebViewBaseContainerForall): Implement GtkContainer::forall().
(webkitWebViewBaseChildMoveResize): Set a new geometry for a child widget.
(webkitWebViewBaseChildAllocate): Allocate a child widget.
(resizeWebKitWebViewBaseFromAllocation): Allocate child widgets.
(webkit_web_view_base_class_init):

  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h: Add webkitWebViewBaseSizeAllocate().
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in: Add createPluginContainer

and windowedPluginGeometryDidChange messages.

  • UIProcess/gtk/WebPageProxyGtk.cpp:

(WebKit::pluginWindowMap):
(WebKit::pluginContainerPlugRemoved): Remove the socket from the
hash map when its plug is removed.
(WebKit::WebPageProxy::createPluginContainer): Create a GtkSocket
as container widget for windowed plugins.
(WebKit::WebPageProxy::windowedPluginGeometryDidChange): Call
webkitWebViewBaseSizeAllocate() to update the plugin widget
geometry.

  • UIProcess/qt/WebPageProxyQt.cpp:

(WebKit::WebPageProxy::createPluginContainer):
(WebKit::WebPageProxy::windowedPluginGeometryDidChange):

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::socketPlugRemovedCallback): Return TRUE to avoid the
socket to be destroyed, since we need to reuse it.
(WebKit::NetscapePlugin::platformPostInitializeWindowed): Ask the
ui process to create a plugin container.
(WebKit::NetscapePlugin::platformPostInitializeWindowless):
(WebKit::NetscapePlugin::platformPostInitialize):
(WebKit::NetscapePlugin::platformGeometryDidChange): For windowed
plugins notify the ui process that the plugin geometry has
changed.
(WebKit::NetscapePlugin::platformPaint): Do nothing for windowed
plugins, the caller already calls callSetWindow().

  • WebProcess/Plugins/PluginController.h:
  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::createPluginContainer):
(WebKit::PluginProxy::windowedPluginGeometryDidChange):

  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/Plugins/PluginProxy.messages.in:
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::createPluginContainer):
(WebKit::PluginView::windowedPluginGeometryDidChange):

  • WebProcess/Plugins/PluginView.h:
3:27 AM Changeset in webkit [115299] by commit-queue@webkit.org
  • 2 edits
    2 deletes in trunk/LayoutTests

http/tests/security/cross-frame-access-put.html is failing
https://bugs.webkit.org/show_bug.cgi?id=82751

Patch by Christophe Dumez <Christophe Dumez> on 2012-04-26
Reviewed by Kentaro Hara.

  • http/tests/security/cross-frame-access-put-expected.txt: Correct

expected value for window.frameElement. It is now 'null' instead of
'undefined' when shouldAllowAccessToNode() check fails, since bug
80205 fix.

  • platform/gtk/http/tests/security/cross-frame-access-put-expected.txt: Removed.

It is now identifical to the global expectation.

  • platform/qt/http/tests/security/cross-frame-access-put-expected.txt: Removed. Ditto.
2:35 AM SettingUpDevelopmentEnvironmentForN9 edited by zarvai@inf.u-szeged.hu
(diff)
2:33 AM SettingUpDevelopmentEnvironmentForN9 edited by zarvai@inf.u-szeged.hu
(diff)
1:32 AM Changeset in webkit [115298] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

Unreviewed. Skip unit test failing in debug bot.

  • Scripts/run-gtk-tests:

(TestRunner):

12:59 AM Changeset in webkit [115297] by mihnea@adobe.com
  • 5 edits
    2 adds in trunk

Crash when collecting svg symbol element in named flow.
https://bugs.webkit.org/show_bug.cgi?id=84493

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/regions/symbol-in-named-flow-crash.svg

  • dom/Element.cpp:

(WebCore::Element::~Element):
Add an assert that an element that was collected into a named flow was already removed at this point
(when the document is not in the process of destruction)
(WebCore::Element::unregisterNamedFlowContentNode):
Created a new function for unregistering a content node. In the future, this function may be used for
content nodes from shadow dom.
(WebCore::Element::detach):

  • dom/Element.h:

(Element):

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
Prevent elements that are part of shadow dom to be collected into a named flow.

LayoutTests:

  • fast/regions/symbol-in-named-flow-crash-expected.txt: Added.
  • fast/regions/symbol-in-named-flow-crash.svg: Added.
12:52 AM Changeset in webkit [115296] by Nikolas Zimmermann
  • 11 edits
    4 adds in trunk

Share code used to animate discrete types between all animators
https://bugs.webkit.org/show_bug.cgi?id=84853

Reviewed by Andreas Kling.

Source/WebCore:

Share by-animation handling for non-additive types in a central method in SVGAnimatedTypeAnimator,
to be reusable by SVGAnimatedBoolean/Enumeration/PreserveAspectRatio/String. Add a new test covering
these animations have no effect.

Test: svg/animations/non-additive-type-by-animation.html

  • svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::calculateFromAndByValues):
(WebCore::SVGAnimateElement::isAdditive):

  • svg/SVGAnimateElement.h:

(SVGAnimateElement):

  • svg/SVGAnimateMotionElement.cpp:

(WebCore::SVGAnimateMotionElement::calculateFromAndByValues):

  • svg/SVGAnimatedBoolean.cpp:

(WebCore::isTrueString):
(WebCore::SVGAnimatedBooleanAnimator::constructFromString):
(WebCore::SVGAnimatedBooleanAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedBooleanAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedEnumeration.cpp:

(WebCore::SVGAnimatedEnumerationAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedEnumerationAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedPreserveAspectRatio.cpp:

(WebCore::SVGAnimatedPreserveAspectRatioAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedString.cpp:

(WebCore::SVGAnimatedStringAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedStringAnimator::calculateAnimatedValue):

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::startedActiveInterval):

  • svg/SVGAnimationElement.h:

(SVGAnimationElement):
(WebCore::SVGAnimationElement::animateDiscreteType):

LayoutTests:

Add tests covering by-animation on non-additive types, which should have no effect.

  • svg/animations/non-additive-type-by-animation-expected.txt: Added.
  • svg/animations/non-additive-type-by-animation.html: Added.
  • svg/animations/resources/non-additive-type-by-animation.svg: Added.
  • svg/animations/script-tests/non-additive-type-by-animation.js: Added.

(sample):
(executeTest):

12:37 AM Changeset in webkit [115295] by Chris Fleizach
  • 4 edits in trunk/Source

CrashTracer: [USER] 157 crashes in WebProcess at com.apple.WebCore: WebCore::AccessibilityRenderObject::isAttachment const + 29
https://bugs.webkit.org/show_bug.cgi?id=84463

Reviewed by Darin Adler.

Source/WebCore:

Accessibility was not being enabled when WK2 was asking only for the focused UI element.

No layout test could be written because the WKTestRunner mechanism works differently when asking for this.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::focusedUIElementForPage):
(WebCore::AXObjectCache::rootObject):
(WebCore::AXObjectCache::rootObjectForFrame):

Source/WebKit2:

  • WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:

(WebKit):

12:09 AM Changeset in webkit [115294] by commit-queue@webkit.org
  • 8 edits in trunk

[EFL][DRT] "resource,request,willsend" signal needs to provide more information
https://bugs.webkit.org/show_bug.cgi?id=84670

Patch by Christophe Dumez <Christophe Dumez> on 2012-04-26
Reviewed by Andreas Kling.

Source/WebKit/efl:

The "resource,request,willsend" signal now provides more information
about the network request as well as information about the possible
redirect response. This extra information will be needed to support
LayoutTestController's dumpResourceLoadCallbacks() in EFL's
DumpRenderTree.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchWillSendRequest):
(WebCore::FrameLoaderClientEfl::assignIdentifierToInitialRequest):
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction):

  • ewk/ewk_frame.cpp:

(ewk_frame_request_will_send):

  • ewk/ewk_frame.h:
  • ewk/ewk_private.h:
  • ewk/ewk_view.h:

Tools:

Handle in EFL's DumpRenderTree the new Ewk_Frame_Resource_Messages now
passed with the "resource,request,willsend" signal and dump
information about the network request and the possible network
response if LayoutTestController's dumpResourceLoadCallbacks() returns
true.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(pathSuitableForTestResult):
(urlSuitableForTestResult):
(descriptionSuitableForTestResult):
(DumpRenderTreeChrome::onWillSendRequest):

12:02 AM Changeset in webkit [115293] by Csaba Osztrogonác
  • 8 edits in trunk

[Qt][WK2] Unreviewed, rolling out r113703 because of crashing tests.
http://trac.webkit.org/changeset/113703
https://bugs.webkit.org/show_bug.cgi?id=83024

Tools:

  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • Tools.pro:
  • qmake/mkspecs/features/features.prf:
  • qmake/mkspecs/features/functions.prf:

LayoutTests:

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0-wk2/fast/dom/prototype-inheritance-2-expected.txt:

Apr 25, 2012:

11:27 PM Changeset in webkit [115292] by mjs@apple.com
  • 2 edits in trunk/Tools

Teach LayoutTestHelper to correctly restore the color profile when it's a factory profile
https://bugs.webkit.org/show_bug.cgi?id=84931

Reviewed by Filip Pizlo.

  • DumpRenderTree/mac/LayoutTestHelper.m:

(installLayoutTestColorProfile): Account for the possibility of the default
profile being a factory profile.

11:19 PM Styling Form Controls edited by paulirish@chromium.org
autofill (diff)
10:44 PM Changeset in webkit [115291] by danakj@chromium.org
  • 7 edits
    1 delete in trunk/Source

[chromium] Remove guarded virtual methods from WebFilterOperation API
https://bugs.webkit.org/show_bug.cgi?id=84926

Reviewed by James Robinson.

Source/Platform:

We remove the virtual methods from the WebFilterOperation class,
and use an enum in the base class to distinguish which subclass
the object is. Then WebFilterOperations can access the correct
subclass to get the filter operation's data and construct a
WebCore::FilterOperation to store internally.

  • chromium/public/WebFilterOperation.h:

(WebKit::WebFilterOperation::WebFilterOperation):
(WebKit::WebBasicColorMatrixFilterOperation::WebBasicColorMatrixFilterOperation):
(WebBasicColorMatrixFilterOperation):
(WebKit::WebBasicComponentTransferFilterOperation::WebBasicComponentTransferFilterOperation):
(WebBasicComponentTransferFilterOperation):
(WebKit::WebBlurFilterOperation::WebBlurFilterOperation):
(WebKit::WebDropShadowFilterOperation::WebDropShadowFilterOperation):

Source/WebCore:

  • WebCore.gypi:
  • platform/chromium/support/WebFilterOperation.cpp: Removed.
  • platform/chromium/support/WebFilterOperations.cpp:

(WebKit::WebFilterOperations::append):

Source/WebKit/chromium:

  • src/AssertMatchingEnums.cpp:
10:27 PM Changeset in webkit [115290] by benjamin@webkit.org
  • 13 edits in trunk/Source

Add a version of StringImpl::find() without offset
https://bugs.webkit.org/show_bug.cgi?id=83968

Source/JavaScriptCore:

Reviewed by Sam Weinig.

Add support for the new StringImpl::find() to UString.

Change stringProtoFuncIndexOf() to specifically take advatage of the feature.
This gives a 12% gains on a distribution of strings between 30 and 100 characters.

  • runtime/StringPrototype.cpp:

(JSC::substituteBackreferences):
(JSC::stringProtoFuncIndexOf):

  • runtime/UString.h:

(UString):
(JSC::UString::find):

Source/WebCore:

Reviewed by Sam Weinig.

Remove the zero offset of the find() functions on strings.

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::init):

  • platform/network/ResourceResponseBase.cpp:

(WebCore::trimToNextSeparator):
(WebCore::parseCacheHeader):

Source/WebKit2:

Update the symbols files.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

Source/WTF:

Reviewed by Sam Weinig.

This patch add a version of StringImpl::find() without offset, Instead of using the default
value for the index.

By not having the index, we can skip a couple of branches and a few instructions. This gives
significant gains when the strings are short-ish.

The case of empty string is moved below (matchLength == 1) since it is a less common operation.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::find):
(WTF):

  • wtf/text/StringImpl.h:

(StringImpl):

  • wtf/text/WTFString.h:

(String):
(WTF::String::find):

10:17 PM Changeset in webkit [115289] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[Blackberry] add a new function in BackingStore
https://bugs.webkit.org/show_bug.cgi?id=84818

Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-04-25
Reviewed by Antonio Gomes.

Adding two functions in BackingStorePrivate and
BackingStore, which could render out webpage contents
into BlackBerry::Platform::Graphics::Drawable.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::renderContents):
(WebKit):
(BlackBerry::WebKit::BackingStore::drawContents):

  • Api/BackingStore.h:
  • Api/BackingStore_p.h:

(BackingStorePrivate):

10:08 PM Changeset in webkit [115288] by mhahnenberg@apple.com
  • 10 edits in trunk/Source

WebCore shouldn't call collectAllGarbage directly
https://bugs.webkit.org/show_bug.cgi?id=84897

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Exported symbol

for reportAbanondedObjectGraph so WebCore can use it.

  • heap/Heap.h: Ditto.

Source/WebCore:

No new tests.

Currently, GCController calls Heap::collectAllGarbage directly, which leads
to an overload of collections as the timer in GCController and the timer in
GCActivityCallback compete for collection time and fire independently. As a
result, we end up doing almost 600 full collections during an in-browser run
of SunSpider, or 20 full collections on a single load of TechCrunch.

We can do better by preventing WebCore from calling collectAllGarbage directly
and instead going through Heap::reportAbandonedObjectGraph, since that is what
WebCore is trying to do--notify the Heap that a lot of garbage may have just
been generated when we left a page.

  • WebCore.exp.in:
  • bindings/js/GCController.cpp: Removed all timer stuff.

(WebCore::GCController::GCController):
(WebCore::GCController::garbageCollectSoon): Changed to call Heap::reportAbandonedObjectGraph.
(WebCore::GCController::garbageCollectNow): Changed to still directly call collectAllGarbage.
We will deprecate this function soon hopefully.

  • bindings/js/GCController.h: Removed timer stuff.

(GCController):

  • bindings/js/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::collectGarbage): Changed to call garbageCollectSoon.

Source/WebKit2:

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didClose): Changed to call garbageCollectSoon. This is the
function that causes us to do so much collection on page navigation.

10:07 PM Changeset in webkit [115287] by mhahnenberg@apple.com
  • 2 edits in trunk/LayoutTests

fast/js/random-array-gc-stress times out in debug mode
https://bugs.webkit.org/show_bug.cgi?id=84821

Reviewed by Geoffrey Garen.

  • fast/js/script-tests/random-array-gc-stress.js: Trying a lower number of iterations

to make the slow bots happy.

9:57 PM Changeset in webkit [115286] by Csaba Osztrogonác
  • 3 edits
    1 delete in trunk/Tools

Unreviewed, rolling out r115240.
http://trac.webkit.org/changeset/115240
https://bugs.webkit.org/show_bug.cgi?id=84928

It broke everything (Requested by Ossy_HOME on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-25

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkDriver):
(GtkDriver._start):
(GtkDriver._start.x_filter):
(GtkDriver.stop):
(GtkPort._driver_class):

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort._build_driver):

  • Scripts/webkitpy/layout_tests/port/xvfbdriver.py: Removed.
9:50 PM Changeset in webkit [115285] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[chromium] REGRESSION(112286) Compositor initialization blocks for program compilation / linking
https://bugs.webkit.org/show_bug.cgi?id=84822

Patch by James Robinson <jamesr@chromium.org> on 2012-04-25
Reviewed by Adrienne Walker.

Source/WebCore:

r112286 introduced a subtle regression in the chromium compositor startup sequence - by querying the texture
copy program's uniform location at the end of LayerRendererChromium::initialize(), the compositor's thread was
blocked until the service side compiled _all_ eagerly initialized shaders. The intent of the way the compositor
programs are created is that a set of commonly-used programs are sent to the service side, but no blocking calls
are made until after we go through the first paint (with the hope that the service side will complete the
compilation by then).

Fixed by moving program initialization (which also grabs uniform locations) until the first actual use of the
copier. It may be worth deferring the program initialization completely if it's not used very often.

Added unit test in LayerRendererChromiumTests to make sure LRC initialization does not make any
synchronous calls (like getUniformLocation()).

  • platform/graphics/chromium/TextureCopier.cpp:

(WebCore::AcceleratedTextureCopier::AcceleratedTextureCopier):
(WebCore::AcceleratedTextureCopier::copyTexture):

Source/WebKit/chromium:

Add a test that makes sure we don't make blocking calls during LayerRendererChromium initialization.

  • tests/LayerRendererChromiumTest.cpp:

(ForbidSynchronousCallContext):
(ForbidSynchronousCallContext::ForbidSynchronousCallContext):
(ForbidSynchronousCallContext::finish):
(ForbidSynchronousCallContext::getActiveAttrib):
(ForbidSynchronousCallContext::getActiveUniform):
(ForbidSynchronousCallContext::getAttachedShaders):
(ForbidSynchronousCallContext::getAttribLocation):
(ForbidSynchronousCallContext::getBooleanv):
(ForbidSynchronousCallContext::getBufferParameteriv):
(ForbidSynchronousCallContext::getContextAttributes):
(ForbidSynchronousCallContext::getError):
(ForbidSynchronousCallContext::getFloatv):
(ForbidSynchronousCallContext::getFramebufferAttachmentParameteriv):
(TEST):

9:03 PM Changeset in webkit [115284] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Authenticated proxy isn't working.
https://bugs.webkit.org/show_bug.cgi?id=84579

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-25
Reviewed by Antonio Gomes.

We should try to get username and password from WiFi advanced configuration first
when 407 is received.

No new tests. This is covered by existing http tests when proxy's username and password
are configured for WiFi.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::sendRequestWithCredentials):

7:26 PM Changeset in webkit [115283] by commit-queue@webkit.org
  • 10 edits in trunk/LayoutTests

Rebaseline *.png pixel test files after bug 84649 fix
https://bugs.webkit.org/show_bug.cgi?id=84905

Patch by David Barton <Dave Barton> on 2012-04-25
Reviewed by Beth Dakin.

  • platform/mac/mathml/presentation/fenced-expected.png:
  • platform/mac/mathml/presentation/fenced-mi-expected.png:
  • platform/mac/mathml/presentation/mo-expected.png:
  • platform/mac/mathml/presentation/mo-stretch-expected.png:
  • platform/mac/mathml/presentation/over-expected.png:
  • platform/mac/mathml/presentation/row-alignment-expected.png:
  • platform/mac/mathml/presentation/row-expected.png:
  • platform/mac/mathml/presentation/sub-expected.png:
  • platform/mac/mathml/presentation/subsup-expected.png:
7:23 PM Changeset in webkit [115282] by commit-queue@webkit.org
  • 14 edits
    3 adds in trunk

IndexedDB: implement cursor.advance()
https://bugs.webkit.org/show_bug.cgi?id=84174

Patch by Alec Flett <alecflett@chromium.org> on 2012-04-25
Reviewed by Ojan Vafai.

Source/WebCore:

Implement IDBCursor.advance() to spec.

Test: storage/indexeddb/cursor-advance.html

  • Modules/indexeddb/IDBBackingStore.h:
  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::advance):
(WebCore):

  • Modules/indexeddb/IDBCursor.h:

(IDBCursor):

  • Modules/indexeddb/IDBCursor.idl:
  • Modules/indexeddb/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::advance):
(WebCore):
(WebCore::IDBCursorBackendImpl::advanceInternal):

  • Modules/indexeddb/IDBCursorBackendImpl.h:

(IDBCursorBackendImpl):

  • Modules/indexeddb/IDBCursorBackendInterface.h:
  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore):

Source/WebKit/chromium:

Hook up chromium IPC to IDBCursor.advance().

  • src/IDBCursorBackendProxy.cpp:

(WebKit::IDBCursorBackendProxy::advance):
(WebKit):

  • src/IDBCursorBackendProxy.h:

(IDBCursorBackendProxy):

  • src/WebIDBCursorImpl.cpp:

(WebKit::WebIDBCursorImpl::advance):

LayoutTests:

Tests for cursor.advance().

  • storage/indexeddb/cursor-advance-expected.txt: Added.
  • storage/indexeddb/cursor-advance.html: Added.
  • storage/indexeddb/resources/cursor-advance.js: Added.

(test):
(openSuccess):
(createAndPopulateObjectStore):
(makeAdvanceTest.continueToTest):
(makeAdvanceTest.request.onerror):
(makeAdvanceTest):
(mkCursor):
(runTest):
(testAll):
(testSimple):
(testContinueThenAdvance):
(testAdvanceMultiple):
(testAdvanceToEnd):

7:06 PM Changeset in webkit [115281] by enne@google.com
  • 3 edits in trunk/Source/WebCore

[chromium] Hold video provider lock from willDraw to didDraw
https://bugs.webkit.org/show_bug.cgi?id=84805

Reviewed by James Robinson.

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::willDraw):
(WebCore):
(WebCore::CCVideoLayerImpl::willDrawInternal):
(WebCore::CCVideoLayerImpl::appendQuads):
(WebCore::CCVideoLayerImpl::didDraw):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:
7:02 PM Changeset in webkit [115280] by charles.wei@torchmobile.com.cn
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Input Range element expects mouse events
https://bugs.webkit.org/show_bug.cgi?id=84571

Reviewed by Antonio Gomes.

This just cleans up the code a bit to make it less code and more readable.

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::shouldConvertTouchToMouse):
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
(BlackBerry::WebKit::TouchEventHandler::spellCheck):

6:56 PM Changeset in webkit [115279] by hclam@chromium.org
  • 14 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r115262.
http://trac.webkit.org/changeset/115262
https://bugs.webkit.org/show_bug.cgi?id=84631

r115262 is causing link error in WebKit Win Builder (dbg)

  • public/WebIDBDatabase.h:

(WebKit::WebIDBDatabase::createObjectStore):

  • public/WebIDBIndex.h:

(WebKit::WebIDBIndex::keyPath):
(WebKit::WebIDBIndex::keyPathString):

  • public/WebIDBKeyPath.h:

(WebKit):
(WebIDBKeyPath):

  • public/WebIDBObjectStore.h:

(WebKit::WebIDBObjectStore::keyPath):
(WebKit::WebIDBObjectStore::keyPathString):
(WebKit::WebIDBObjectStore::createIndex):

  • public/platform/WebKitPlatformSupport.h:

(WebKit::WebKitPlatformSupport::createIDBKeysFromSerializedValuesAndKeyPath):
(WebKit::WebKitPlatformSupport::injectIDBKeyIntoSerializedValue):

  • src/IDBIndexBackendProxy.cpp:

(WebKit::IDBIndexBackendProxy::keyPath):

  • src/IDBObjectStoreBackendProxy.cpp:

(WebKit::IDBObjectStoreBackendProxy::keyPath):

  • src/WebIDBDatabaseImpl.h:

(WebIDBDatabaseImpl):

  • src/WebIDBIndexImpl.cpp:
  • src/WebIDBIndexImpl.h:

(WebIDBIndexImpl):

  • src/WebIDBKeyPath.cpp:

(WebKit::WebIDBKeyPath::create):
(WebKit::WebIDBKeyPath::assign):
(WebKit::WebIDBKeyPath::operator const WTF::Vector<WTF::String, 0>&):

  • src/WebIDBObjectStoreImpl.cpp:
  • src/WebIDBObjectStoreImpl.h:

(WebIDBObjectStoreImpl):
(WebKit::WebIDBObjectStoreImpl::createIndex):

6:48 PM Changeset in webkit [115278] by enne@google.com
  • 12 edits in trunk/Source

[chromium] Prevent CCLayerImpl::willDraw/didDraw mismatches
https://bugs.webkit.org/show_bug.cgi?id=84812

Reviewed by James Robinson.

Source/WebCore:

Because some layers lock/unlock resources, it needs to be guaranteed
that if willDraw is called on a layer then didDraw will also be called
on that layer before another willDraw or before layer destruction. Add
asserts to make sure that this is the case.

willDraw is called via CCLayerTreeHostImpl::prepareToDraw ->
calculateRenderPasses. didDraw was previously called in
CCLayerTreeHostImpl::drawLayers. Sometimes drawLayers was being
skipped by the caller of these functions based on what prepareToDraw
returned (causing didDraw to not be called). Fix this by having an
explicit step to call didDraw on all layers. This new didDrawAllLayers
function must be called if and only if prepareToDraw is called.

Tested by existing tests via new asserts in CCLayerImpl.

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::~CCLayerImpl):
(WebCore::CCLayerImpl::willDraw):
(WebCore):
(WebCore::CCLayerImpl::didDraw):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::drawLayers):
(WebCore::CCLayerTreeHostImpl::didDrawAllLayers):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:

(WebCore::CCScrollbarLayerImpl::willDraw):
(WebCore::CCScrollbarLayerImpl::didDraw):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::doComposite):

  • platform/graphics/chromium/cc/CCTextureLayerImpl.cpp:

(WebCore::CCTextureLayerImpl::willDraw):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::willDraw):
(WebCore::CCVideoLayerImpl::didDraw):

Source/WebKit/chromium:

Update all tests to call CCLayerTreeHostImpl::didDrawAllLayers if they
call CCLayerTreeHostImpl::prepareToDraw.

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKitTests::CCLayerTreeHostImplTest::initializeLayerRendererAndDrawFrame):
(WebKitTests::TEST_F):

6:26 PM Changeset in webkit [115277] by mikelawther@chromium.org
  • 2 edits in branches/chromium/1084/Source/WebCore/css

Merge 114699 - REGRESSION(r112177): Numbered list item rendered bulleted
https://bugs.webkit.org/show_bug.cgi?id=84216

NOTE: CSSParser.cpp:3663 modified as this patch depends on another one that

was not merged to this branch.

Patch by David Barr <davidbarr@chromium.org> on 2012-04-19
Reviewed by Ryosuke Niwa.

Shorthands that imply omitted values cannot be derived from
an incomplete set of longhand rules.

No new tests; updated existing tests that should have caught this.

Source/WebCore:

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseTransformOriginShorthand):
Set implicit initial for Z when omitted.

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getShorthandValue):

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10225019

6:26 PM Changeset in webkit [115276] by tkent@chromium.org
  • 7 edits in trunk

Calendar Picker: Resize to minimal size to fit the content
https://bugs.webkit.org/show_bug.cgi?id=84826

Reviewed by Hajime Morita.

.:

  • ManualTests/forms/calendar-picker.html:

Sync with the size specified in CalendarPickerElement.cpp.

Source/WebCore:

Using fixed-size popup isn't nice. The calender picker popup size should
be minimal.

The minimal size depends on font settings, localized labels, and
localized formats. So we put visible objects on a transparent element,
calculate minimal size, resize the popup, then show the objects.

  • Resources/calendarPicker.css:

(body): Don't use purple. It was for debugging purpose.
The body is visible for a short period becuse we use transparent element.
(#main):

  • Add nowrap to avoid text wrapping.
  • Add wider width to avoid wrapping.
  • Add opacity to hide incomplete layout.

(.year-month-upper): Don't set flexible box yet.
(.month-selector-box): Fix incorrect display value.
(.days-area):
Don't set table-layout:fixed and width:100% in order that it has the
minimal width.

  • Resources/calendarPicker.js:

(initialize): Make a new functio to resize.
(fixWindowSize):
Compute the required width from the right edge of the next year button,
the maximum cell width, and so on. Then, set CSS properties to have
correct layout.
(YearMonthController.prototype.attachTo):
Set min-width property for a long year-month string.
(YearMonthController.prototype._showPopup):
Center the _monthPopup vertically.

  • html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::contentSize):
Specify small size for the initial size. It's better than showing a
large window then shrink the size.

  • page/PagePopupClient.h:

(PagePopupClient): Remove a false comment. We should support resize*().

6:18 PM Changeset in webkit [115275] by hclam@chromium.org
  • 5 edits
    3 deletes in trunk

Unreviewed, rolling out r115260.
http://trac.webkit.org/changeset/115260
https://bugs.webkit.org/show_bug.cgi?id=84467

r115260 is crashing a list of IndexDB tests, revert.

Source/WebCore:

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore):

  • platform/leveldb/LevelDBTransaction.cpp:

(WebCore::LevelDBTransaction::TransactionIterator::refreshTreeIterator):
(WebCore::LevelDBTransaction::TransactionIterator::handleConflictsAndDeletes):

  • platform/leveldb/LevelDBTransaction.h:

(TransactionIterator):

LayoutTests:

  • storage/indexeddb/cursor-added-bug-expected.txt: Removed.
  • storage/indexeddb/cursor-added-bug.html: Removed.
  • storage/indexeddb/resources/cursor-added-bug.js: Removed.
6:17 PM Changeset in webkit [115274] by simonjam@chromium.org
  • 11 edits
    6 copies in trunk/Source/WebCore

[Web Timing] Add a vendor-prefixed Performance Timeline API
https://bugs.webkit.org/show_bug.cgi?id=80350

As described here: http://dvcs.w3.org/hg/webperf/raw-file/tip/specs/PerformanceTimeline/Overview.html

The API is there and should be correct, but it isn't particularly useful,
because nothing is populated. Upcoming changes will add Navigation Timing
and Resource Timing.

Reviewed by Tony Gentilcore.

No new tests. Functionality is disabled on all platforms.

  • CMakeLists.txt: Added PerformanceEntry* files.
  • DerivedSources.pri: Ditto.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • page/Performance.cpp:

(WebCore::Performance::webkitGetEntries): Added.
(WebCore::Performance::webkitGetEntriesByType): Added.
(WebCore::Performance::webkitGetEntriesByName): Added.

  • page/Performance.h:

(Performance):

  • page/Performance.idl:
  • page/PerformanceEntry.cpp: Added.

(WebCore):
(WebCore::PerformanceEntry::PerformanceEntry):
(WebCore::PerformanceEntry::name):
(WebCore::PerformanceEntry::entryType):
(WebCore::PerformanceEntry::startTime):
(WebCore::PerformanceEntry::duration):

  • page/PerformanceEntry.h: Added.

(WebCore):
(PerformanceEntry):

  • page/PerformanceEntry.idl: Added.
  • page/PerformanceEntryList.cpp: Added.

(WebCore):
(WebCore::PerformanceEntryList::PerformanceEntryList):
(WebCore::PerformanceEntryList::~PerformanceEntryList):
(WebCore::PerformanceEntryList::length):
(WebCore::PerformanceEntryList::item):
(WebCore::PerformanceEntryList::append):

  • page/PerformanceEntryList.h: Added.

(WebCore):
(PerformanceEntryList):
(WebCore::PerformanceEntryList::create):

  • page/PerformanceEntryList.idl: Added.
6:16 PM Changeset in webkit [115273] by Dimitri Glazkov
  • 5 edits in trunk/LayoutTests

Remove unnecessary timeouts (and closures) from content-element-in-* tests.
https://bugs.webkit.org/show_bug.cgi?id=84896

These tests don't need any of them. Not sure how they got there in the first place. Oh wait. I reviewed this code. /me hands head in shame.

Reviewed by Ojan Vafai.

  • fast/dom/shadow/content-element-in-media-element.html: Removed the timeout and extra closures.
  • fast/dom/shadow/content-element-in-meter-element.html: Ditto.
  • fast/dom/shadow/content-element-in-progress-element.html: Ditto.
  • fast/dom/shadow/content-element-in-select-element.html: Ditto.
6:13 PM Changeset in webkit [115272] by Darin Adler
  • 2 edits in trunk/Source/WTF

Iterating a HashMap<String, X> involves a string equality comparison to check for the empty value
https://bugs.webkit.org/show_bug.cgi?id=84524

Reviewed by Antti Koivisto.

  • wtf/HashMap.h: Added a struct template, HashMapValueTraits, that derives from

PairHashTraits, adds an isEmptyValue function that looks only at the key, not
the mapped value, in the hash table value, and uses the isHashTraitsEmptyValue
function template to check if the key is empty.

6:11 PM Changeset in webkit [115271] by Beth Dakin
  • 2 edits in trunk/Source/WebKit/mac

https://bugs.webkit.org/show_bug.cgi?id=84913
WebKit 1: Initialize deviceScaleFactor on creation of the WebView
-and corresponding-
<rdar://problem/11322716>

Reviewed by Darin Adler.

Before this patch, we weren't setting the deviceScaleFactor until
viewDidMoveToWindow which is quite late for background tabs. setHostWindow will
happen early on though. For applications that don't use host windows, also set it
from _initWithFrame.

  • WebView/WebView.mm:

(-[WebView _initWithFrame:frameName:groupName:usesDocumentViews:]):
(-[WebView setHostWindow:]):
(-[WebView _deviceScaleFactor]):

6:07 PM Changeset in webkit [115270] by Beth Dakin
  • 4 edits in trunk/Source/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=84909
Background tabs are fuzzy until repaint when deviceScaleFactor > 1
-and corresponding-
<rdar://problem/11312064>

Rubber-stamped by Darin Adler.

Re-order the parameters of paintBitmapContext to match paintImage.

  • Platform/cg/CGUtilities.cpp:

(WebKit::paintBitmapContext):

  • Platform/cg/CGUtilities.h:

(WebKit):

  • UIProcess/mac/BackingStoreMac.mm:

(WebKit::BackingStore::resetScrolledRect):
(WebKit::BackingStore::paint):
(WebKit::BackingStore::backingStoreContext):

6:06 PM Changeset in webkit [115269] by benjamin@webkit.org
  • 4 edits in trunk/Source/WebCore

Move convertJSMethodNameToObjc() to be a utility function of ObjcClass
https://bugs.webkit.org/show_bug.cgi?id=84915

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-25
Reviewed by Darin Adler.

The function convertJSMethodNameToObjc() is only useful for ObjcClass::methodsNamed().

This patch moves the function from objc_utility.mm to be a static function in objc_class.mm.
It aims at simplifying the code for future changes of ObjcClass.

  • bridge/objc/objc_class.mm:

(Bindings):
(JSC::Bindings::convertJSMethodNameToObjc):

  • bridge/objc/objc_utility.h:
  • bridge/objc/objc_utility.mm:

(Bindings):

6:03 PM Changeset in webkit [115268] by dpranke@chromium.org
  • 4 edits in trunk/Tools

[chromium] change DRT's "DRT" output to match the other ports
https://bugs.webkit.org/show_bug.cgi?id=84904

Reviewed by Kent Tamura.

Since we run Chromium's DRT in --test-shell mode, the
non-test-shell output has never been really beaten on to make
sure it's right. This fixes a few issues and will be tested
with upcoming NRWT changes that'll land in a separate patch.
In particular we should never output framing text like "\n"
or "#EOF" outside of something outside of TestEventPrinter,
and we weren't handling audio output properly at all.

  • DumpRenderTree/chromium/TestEventPrinter.cpp:

(DRTPrinter):
(TestShellPrinter):
(DRTPrinter::handleTextFooter):
(DRTPrinter::handleAudioFooter):
(DRTPrinter::handleTestFooter):
(TestShellPrinter::handleAudioFooter):

  • DumpRenderTree/chromium/TestEventPrinter.h:

(TestEventPrinter):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):
(TestShell::dump):

6:03 PM Changeset in webkit [115267] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed. Sort Xcode project file.

  • WebCore.xcodeproj/project.pbxproj:
5:46 PM Changeset in webkit [115266] by Beth Dakin
  • 4 edits in trunk/Source/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=84909
Background tabs are fuzzy until repaint when deviceScaleFactor > 1
-and corresponding-
<rdar://problem/11312064>

Reviewed by Darin Adler.

BackingStoreMac paints into a Bitmap instead of a CGLayer when there is no
containing window. That bitmap is used for the initial paint when a background tab
first comes to he foreground, so it needs to be HiDPI-aware.

paintBitmapContext() now takes a scale factor that it passes along to paintImage
rather than hardcoding a scale factor of 1 for paintImage.

  • Platform/cg/CGUtilities.cpp:

(WebKit::paintBitmapContext):

  • Platform/cg/CGUtilities.h:

(WebKit):

When these functions fall into the bitmap case, they need to adopt the device
scale factor, which means they need to scale in size by the scale factor, and also
scale their context.

  • UIProcess/mac/BackingStoreMac.mm:

(WebKit::BackingStore::resetScrolledRect):
(WebKit::BackingStore::paint):
(WebKit::BackingStore::backingStoreContext):

5:29 PM Changeset in webkit [115265] by Alexandru Chiculita
  • 9 edits
    1 delete in trunk/LayoutTests

[Chromium] Layout Test css3/filters/custom/custom-filter-property-computed-style.html is failing
https://bugs.webkit.org/show_bug.cgi?id=84067

Reviewed by Ryosuke Niwa.

All the CSS filters/shaders script tests expected to have a document.styleSheets.item(0) that they could change.
The script-tests add a <link> that references a CSS file from a different parent folder, so the script
has no access to the actual rules anymore. Updated all the tests to use createElement("style")
and get the styleSheet by using el.sheet instead of assuming that there's one style already created.

  • css3/filters/script-tests/custom-filter-property-computed-style.js:
  • css3/filters/script-tests/custom-filter-property-parsing-invalid.js:

(testInvalidFilterRule):

  • css3/filters/script-tests/effect-custom-disabled.js:

(testInvalidFilterRule):

  • css3/filters/script-tests/filter-property-computed-style.js:

(testComputedFilterRule):

  • css3/filters/script-tests/filter-property-parsing-invalid.js:

(testInvalidFilterRule):

  • css3/filters/script-tests/filter-property-parsing.js:

(testFilterRule):

  • css3/filters/script-tests/filter-property.js:
  • platform/chromium/test_expectations.txt: Removed reference to this bug.
  • platform/mac/css3/filters/custom/custom-filter-property-computed-style-expected.txt: Removed. This is not necessary anymore.
5:28 PM Changeset in webkit [115264] by commit-queue@webkit.org
  • 14 edits
    3 adds in trunk

Implement object-literal constructor for the Intent object.
https://bugs.webkit.org/show_bug.cgi?id=84220

Patch by Greg Billock <gbillock@google.com> on 2012-04-25
Reviewed by Kentaro Hara.

The use of the custom constructor will hopefully be temporary, as we plan
to convert to just using the object literal constructor, which can then use codegen.
See spec: http://dvcs.w3.org/hg/web-intents/raw-file/tip/spec/Overview.html

Added support for the service and extras parameters in the Intent
object to support the speced members in the object literal constructor.

Added supporting accessor to Dictionary to retrieve a sub-Dictionary,
and a utility to ScriptValue to serialize with ports.

Test: webintents/web-intent-obj-constructor.html

(WebCore):

  • Modules/intents/Intent.cpp:

(WebCore::Intent::create):
(WebCore::Intent::Intent):
(WebCore::Intent::service):
(WebCore):
(WebCore::Intent::extras):

  • Modules/intents/Intent.h:

(WebCore):
(Intent):

  • Modules/intents/Intent.idl:
  • WebCore.gypi:
  • bindings/v8/Dictionary.cpp:

(WebCore::Dictionary::get):
(WebCore):

  • bindings/v8/Dictionary.h:

(Dictionary):

  • bindings/v8/ScriptValue.cpp:

(WebCore::ScriptValue::serialize):
(WebCore):

  • bindings/v8/ScriptValue.h:

(WTF):
(WebCore):
(ScriptValue):

  • bindings/v8/custom/V8IntentConstructor.cpp: Added.

(WebCore):
(WebCore::V8Intent::constructorCallback):

5:26 PM Changeset in webkit [115263] by Alexandru Chiculita
  • 6 edits in trunk

CSS Shaders: Use u_texture instead of s_texture. It was updated in the spec
https://bugs.webkit.org/show_bug.cgi?id=82618

Source/WebCore:

Reviewed by Dean Jackson.

Changed the uniform name passed to the CSS Shaders from s_texture to u_texture.
https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html

No new tests, just updating existing ones.

  • platform/graphics/filters/CustomFilterShader.cpp:

(WebCore::CustomFilterShader::defaultFragmentShaderString):
(WebCore::CustomFilterShader::initializeParameterLocations):

LayoutTests:

Reviewed by Dean Jackson.

Changed the uniform name passed to the CSS Shaders from s_texture to u_texture.
https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html

  • css3/filters/resources/color-add.fs:
  • css3/filters/resources/color-offset-parameters.fs:
  • css3/filters/resources/color-offset.fs:
5:07 PM Changeset in webkit [115262] by jsbell@chromium.org
  • 14 edits in trunk/Source/WebKit/chromium

[Chromium] IndexedDB: Use WebIDBKeyPath type for key paths in WebKit API
https://bugs.webkit.org/show_bug.cgi?id=84631

Reviewed by James Robinson.

WebIDBKeyPath was previously a utility class for parsing key paths into components,
but the API exposed key paths only as nullable strings. To support array-type keypaths,
WebIDBKeyPath becomes a value class with type flags. For landing, several legacy methods
are retained but will be cleaned up after all callers have been updated, tracked as
the bug: http://webkit.org/b/84207

  • public/WebIDBDatabase.h:

(WebKit::WebIDBDatabase::createObjectStore): Add WebIDBKeyPath overload; WebString overload delegates so implementers can switch.

  • public/WebIDBIndex.h:

(WebKit::WebIDBIndex::keyPath): Calls keyPathString if not overridden.
(WebKit::WebIDBIndex::keyPathString): Comment change.

  • public/WebIDBKeyPath.h:

(WebKit::WebIDBKeyPath::create): Overload added for creating array-type key paths.
(WebKit::WebIDBKeyPath::array): Accessor for array-type key paths.
(WebKit::WebIDBKeyPath::operator const WebString ): Temporary, for compatibility.

  • public/WebIDBObjectStore.h:

(WebKit::WebIDBObjectStore::keyPath): Calls keyPathString if not overridden.
(WebKit::WebIDBObjectStore::keyPathString): Comment change.
(WebKit::WebIDBObjectStore::createIndex): Add WebIDBKeyPath overload; WebString overload delegates so implementers can switch.

  • public/platform/WebKitPlatformSupport.h:

(WebKitPlatformSupport): WebIDBKeyPath overloads for these methods added, delegate to WebString version until implementers are updated.
(WebKit::WebKitPlatformSupport::createIDBKeysFromSerializedValuesAndKeyPath):
(WebKit::WebKitPlatformSupport::injectIDBKeyIntoSerializedValue):

  • src/IDBIndexBackendProxy.cpp:

(WebKit::IDBIndexBackendProxy::keyPath): Returns the string version until WebCore is updated.

  • src/IDBObjectStoreBackendProxy.cpp:

(WebKit::IDBObjectStoreBackendProxy::keyPath): Returns the string version until WebCore is updated.

  • src/WebIDBDatabaseImpl.h:

(WebIDBDatabaseImpl): Add createObjectStore overload for WebIDBKeyPath type, delegates to WebString version until callers are updated.

  • src/WebIDBIndexImpl.cpp:

(WebKit::WebIDBIndexImpl::keyPath): Implements the new WebIDBKeyPath return type.
(WebKit):

  • src/WebIDBIndexImpl.h:

(WebIDBIndexImpl): Implements the new WebIDBKeyPath return type.

  • src/WebIDBKeyPath.cpp:

(WebKit::WebIDBKeyPath::create): Support null key path types.
(WebKit::WebIDBKeyPath::createNull): New API.
(WebKit):
(WebKit::WebIDBKeyPath::isValid): New API.
(WebKit::WebIDBKeyPath::type): New API.
(WebKit::WebIDBKeyPath::string): New API (value accessor).
(WebKit::WebIDBKeyPath::WebIDBKeyPath):
(WebKit::WebIDBKeyPath::assign): This API will be removed.
(WebKit::WebIDBKeyPath::operator const WTF::Vector<WTF::String, 0>&): Ensure it is non-null - only used in copy constructor which guards against this.

  • src/WebIDBObjectStoreImpl.cpp:

(WebKit::WebIDBObjectStoreImpl::keyPath): Implement the new WebIDBKeyPath return type.
(WebKit):

  • src/WebIDBObjectStoreImpl.h:

(WebIDBObjectStoreImpl): Add createIndex overload for WebIDBKeyPath type, delegates to WebString version until callers are updated.

5:00 PM Changeset in webkit [115261] by leviw@chromium.org
  • 2 edits in branches/subpixellayout/LayoutTests/css2.1

Adding a tiny fraction to the css values of these tests to make up for lost Float precision when calculating margins when Lengths are floats.

4:52 PM Changeset in webkit [115260] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

IndexedDB: cursor does not correctly iterate over keys added and removed during iteration
https://bugs.webkit.org/show_bug.cgi?id=84467

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-04-25
Reviewed by Ojan Vafai.

Source/WebCore:

Ensure that the iterator over the tree of cached adds/removes always points at
the current key, or if the db iterator is current, the next key:

  • When refreshing the tree iterator after a mutation, always seek unless the

tree iterator is current.

  • When handing conflicts and delete markers, only advance the tree iterator as

far as the db iterator.

Remove the expensive (and now redundant) logic that issued a get() to check
whether an item had been deleted.

Test: storage/indexeddb/cursor-added-bug.html

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore):

  • platform/leveldb/LevelDBTransaction.cpp:

(WebCore::LevelDBTransaction::TransactionIterator::refreshTreeIterator):
(WebCore::LevelDBTransaction::TransactionIterator::handleConflictsAndDeletes):

LayoutTests:

New test for keys added in reverse order during cursor iteration.

  • storage/indexeddb/cursor-added-bug-expected.txt: Added.
  • storage/indexeddb/cursor-added-bug.html: Added.
  • storage/indexeddb/resources/cursor-added-bug.js: Added.

(test):
(openSuccess):
(setVersionSuccess):
(openCursor):
(cursorSuccess):

4:51 PM Changeset in webkit [115259] by eae@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/platform/graphics/FractionalLayoutRect.cpp

Fix enclosingFractionalLayoutRect for 1/1 on branch.

4:39 PM Changeset in webkit [115258] by jsbell@chromium.org
  • 2 edits in trunk/Tools

Unreviewed: Adding Alec Flett as a contributor (non-committer).

  • Scripts/webkitpy/common/config/committers.py:
4:30 PM Changeset in webkit [115257] by inferno@chromium.org
  • 2 edits in trunk/Tools

Mark myself as a reviewer.
https://bugs.webkit.org/show_bug.cgi?id=84902

Reviewed by Dimitri Glazkov.

  • Scripts/webkitpy/common/config/committers.py:
4:18 PM WebKit Team edited by inferno@chromium.org
(diff)
4:09 PM April 2012 HTML5 Media Element & WebAudio edited by fischman@chromium.org
(diff)
4:07 PM Changeset in webkit [115256] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Try to fix build with STYLE_SCOPED enabled.

Not reviewed.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::determineScope):

4:05 PM Changeset in webkit [115255] by commit-queue@webkit.org
  • 13 edits
    3 adds in trunk

IndexedDB: support openCursor(IDBKey)
https://bugs.webkit.org/show_bug.cgi?id=84652

Patch by Alec Flett <alecflett@chromium.org> on 2012-04-25
Reviewed by Ojan Vafai.

Source/WebCore:

Add signatures for openCursor/openKeyCursor(IDBKey).

Test: storage/indexeddb/opencursor-key.html

  • Modules/indexeddb/IDBIndex.cpp:

(WebCore::IDBIndex::openCursor):
(WebCore):
(WebCore::IDBIndex::openKeyCursor):

  • Modules/indexeddb/IDBIndex.h:

(WebCore::IDBIndex::openCursor):
(IDBIndex):
(WebCore::IDBIndex::openKeyCursor):

  • Modules/indexeddb/IDBIndex.idl:
  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::openCursor):
(WebCore):

  • Modules/indexeddb/IDBObjectStore.h:

(WebCore::IDBObjectStore::openCursor):
(IDBObjectStore):

  • Modules/indexeddb/IDBObjectStore.idl:

LayoutTests:

Augment existing tests, and add new tests to support
IDBKey parameter to openCursor/openKeyCursor. Note that this removes
a test that was previously using dictionary-style parameters,
which have been temporarily broken due to IDL limitations.

  • storage/indexeddb/cursor-delete-expected.txt:
  • storage/indexeddb/open-cursor-expected.txt:
  • storage/indexeddb/opencursor-key-expected.txt: Added.
  • storage/indexeddb/opencursor-key.html: Added.
  • storage/indexeddb/resources/cursor-delete.js:

(openCursor):

  • storage/indexeddb/resources/open-cursor.js:

(emptyCursorWithKeySuccess):
(openEmptyCursorWithKey):
(cursorWithKeySuccess):
(openCursorWithKey):
(emptyCursorSuccess):
(openEmptyCursor):
(cursorSuccess):

  • storage/indexeddb/resources/opencursor-key.js: Added.

(test):
(openSuccess):
(createAndPopulateObjectStore):
(createIndexes):
(testAll):
(testObjectStore.request.onsuccess):
(testObjectStore):
(testIndex.request.onsuccess):
(testIndex):
(testIndexWithKey.request.onsuccess):
(testIndexWithKey):

4:02 PM Changeset in webkit [115254] by rakuco@webkit.org
  • 2 edits in trunk/Source/WTF

Include <sys/param.h>, needed for sysctl() on OpenBSD/NetBSD
https://bugs.webkit.org/show_bug.cgi?id=82585

Patch by Landry Breuil <landry@openbsd.org> on 2012-04-25
Reviewed by Zoltan Herczeg.

  • wtf/NumberOfCores.cpp: include <sys/param.h> on the BSDs
4:01 PM Changeset in webkit [115253] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Biolab disaster crashes on ToT
https://bugs.webkit.org/show_bug.cgi?id=84898

Reviewed by Filip Pizlo.

Whoops, committed without saving reviewer requested change.

  • dfg/DFGVirtualRegisterAllocationPhase.cpp:

(JSC::DFG::VirtualRegisterAllocationPhase::run):

3:58 PM Changeset in webkit [115252] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Biolab disaster crashes on ToT
https://bugs.webkit.org/show_bug.cgi?id=84898

Reviewed by Filip Pizlo.

I recently added an assertion to the Interpreter to catch incorrect
updates of topCallFrame. This caused a bunch of sites (including biolab
disaster) to crash as we were not correctly handling callee registers
of inlined functions, leading to a mismatch.

I could not actually make this trigger directly, although it does trigger
already on some of the GTK and QT bots.

  • dfg/DFGVirtualRegisterAllocationPhase.cpp:

(JSC::DFG::VirtualRegisterAllocationPhase::run):

3:52 PM Changeset in webkit [115251] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium[ Remove a flaky expectation for a test that's been consistently passing.

  • platform/chromium/test_expectations.txt: Removed.
3:42 PM Changeset in webkit [115250] by Antti Koivisto
  • 19 edits in trunk/Source/WebCore

Remove owner node pointer from StyleSheetInternal
https://bugs.webkit.org/show_bug.cgi?id=84882

Reviewed by Andread Kling.

To make sharing between multiple nodes possible StyleSheetInternal should not have a Node pointer.

  • Make StyleSheetInternal constructor take CSSParserContext instead of Node*
  • Move owner node pointer to CSSStyleSheet. CSSStyleSheet now acts as a client for StyleSheetInternal.


This gets us closer to being able to cache stylesheet data structures.

  • css/CSSImportRule.cpp:

(WebCore::StyleRuleImport::setCSSStyleSheet):
(WebCore::StyleRuleImport::requestStyleSheet):

Setup CSSParserContext.
Remove FIXME about updateBaseURL(). It is no longer possible to change URL of StyleSheetInternal.

  • css/CSSPageRule.cpp:

(WebCore::CSSPageRule::setSelectorText):

  • css/CSSParser.cpp:

(WebCore::CSSParserContext::CSSParserContext):

  • css/CSSParserMode.h:

(CSSParserContext):

Expand CSSParserContext constructors.

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::setSelectorText):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::addAuthorRulesAndCollectUserRulesFromSheets):
(WebCore::StyleResolver::collectMatchingRulesForList):

  • css/StyleResolver.h:

(StyleResolver):

  • css/CSSStyleSheet.cpp:

User stylesheets went back to being CSSStyleSheets. Adapt to that.

(WebCore::StyleSheetInternal::StyleSheetInternal):
(WebCore):
(WebCore::StyleSheetInternal::checkLoaded):
(WebCore::StyleSheetInternal::startLoadingDynamicSheet):
(WebCore::StyleSheetInternal::rootStyleSheet):
(WebCore::StyleSheetInternal::singleOwnerNode):
(WebCore::StyleSheetInternal::singleOwnerDocument):
(WebCore::StyleSheetInternal::styleSheetChanged):

The owner node is now located through CSSStyleSheet. Only one client is supported atm.

(WebCore::StyleSheetInternal::registerClient):
(WebCore::StyleSheetInternal::unregisterClient):

Register CSSStyleSheets.

(WebCore::CSSStyleSheet::CSSStyleSheet):
(WebCore::CSSStyleSheet::~CSSStyleSheet):
(WebCore::CSSStyleSheet::rules):
(WebCore::CSSStyleSheet::cssRules):
(WebCore::CSSStyleSheet::ownerDocument):

  • css/CSSStyleSheet.h:

(WebCore::StyleSheetInternal::create):
(WebCore::StyleSheetInternal::createInline):
(StyleSheetInternal):
(WebCore::CSSStyleSheet::create):
(CSSStyleSheet):

Moved m_ownerNode.
Changed constructors
Removed setFinalURL().

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::StyleRuleCSSStyleDeclaration::setNeedsStyleRecalc):

  • dom/Document.cpp:

(WebCore::Document::updateBaseURL):

Instead of setFinalURL, construct a new StyleSheetInternal if the base url ever changes.

(WebCore::Document::pageUserSheet):
(WebCore::Document::pageGroupUserSheets):
(WebCore::Document::addUserSheet):
(WebCore::Document::elementSheet):

  • dom/Document.h:

(Document):
(WebCore::Document::documentUserSheets):

Adapt to the new interface.
Turned user stylesheets CSSStyleSheets so they can find the owner node.

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::setCSSStyleSheet):

  • dom/StyleElement.cpp:

(WebCore::StyleElement::createSheet):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::setCSSStyleSheet):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::SelectorProfile::startSelector):
(WebCore::InspectorCSSAgent::bindStyleSheet):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::fillMediaListChain):
(WebCore::InspectorStyleSheet::ownerDocument):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeCSSStyleSheet):

3:33 PM Changeset in webkit [115249] by adamk@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix uninitialized variable warnings in PasteboardMac.mm after 115145
https://bugs.webkit.org/show_bug.cgi?id=84879

Reviewed by Enrica Casucci.

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::getDataSelection): Initialize attributedString to nil.
(WebCore::Pasteboard::writeSelectionForTypes): ditto.

3:12 PM Changeset in webkit [115248] by kbr@google.com
  • 52 edits
    9 deletes in trunk/Source

Delete CanvasPixelArray, ByteArray, JSByteArray and JSC code once unreferenced
https://bugs.webkit.org/show_bug.cgi?id=83655

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

(JSC::predictionToString):
(JSC::predictionToAbbreviatedString):
(JSC::predictionFromClassInfo):

  • bytecode/PredictedType.h:

(JSC):
(JSC::isActionableIntMutableArrayPrediction):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::execute):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGNode.h:
  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOperations.cpp:

(JSC::DFG::putByVal):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::ValueSource::forPrediction):
(SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jit/JITStubs.h:
  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::getByVal):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • runtime/JSByteArray.cpp: Removed.
  • runtime/JSByteArray.h: Removed.
  • runtime/JSGlobalData.cpp:

Source/WebCore:

Removed last few references to ByteArray, replacing with
Uint8ClampedArray as necessary, and deleted now-obsolete
CanvasPixelArray, ByteArray and JSByteArray. Removed code from
JavaScriptCore special-casing ByteArray.

No new tests. Did full layout test run on Mac OS; no regressions
seen from this change.

  • CMakeLists.txt:
  • DerivedSources.pri:
  • ForwardingHeaders/runtime/JSByteArray.h: Removed.
  • GNUmakefile.list.am:
  • PlatformBlackBerry.cmake:
  • Target.pri:
  • UseV8.cmake:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/v8/SerializedScriptValue.cpp:
  • bindings/v8/V8Binding.h:

(WebCore::isHostObject):

  • bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Removed.
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::typeCallback):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::isJSUint8ClampedArray):
(Bindings):
(JSC::Bindings::valueRealType):
(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue):

  • html/canvas/CanvasPixelArray.cpp: Removed.
  • html/canvas/CanvasPixelArray.h: Removed.
  • html/canvas/CanvasPixelArray.idl: Removed.
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):

  • platform/graphics/filters/FEConvolveMatrix.h:
  • rendering/svg/RenderSVGResourceMasker.cpp:

Source/WTF:

  • GNUmakefile.list.am:
  • WTF.gypi:
  • WTF.pro:
  • WTF.vcproj/WTF.vcproj:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/ByteArray.cpp: Removed.
  • wtf/ByteArray.h: Removed.
  • wtf/CMakeLists.txt:
2:58 PM QtWebKitContrib edited by alex.bravo@nokia.com
(diff)
2:36 PM Changeset in webkit [115247] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84890

Rebaseline chromium-mac test expectation for media/audio-repaint.html after r115235.

  • platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
2:30 PM Changeset in webkit [115246] by hclam@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix.

Build fix for compilation failure due to r115243.

  • platform/graphics/chromium/LayerChromium.h:

(WebCore):

2:22 PM Changeset in webkit [115245] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Possible JS re-entrancy caused by UI events.
https://bugs.webkit.org/show_bug.cgi?id=84862

Patch by Yong Li <yoli@rim.com> on 2012-04-25
Reviewed by Antonio Gomes.

  1. block UI events when running in nested event loop
  2. defer some tasks we still want to perform when it is safe to do, with cached data.
  3. deferred task can be cancelled by clearing the flag. duplicate tasks is not a problem because they share same flag and data.
  4. move deferred manual script from FrameLoaderClientBlackBerry to WebPagePrivate and make it a deferred task
  • Api/WebPage.cpp:

(WebKit):
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::load):
(BlackBerry::WebKit::WebPagePrivate::stopCurrentLoad):
(BlackBerry::WebKit::WebPagePrivate::willDeferLoading):
(BlackBerry::WebKit::WebPagePrivate::didResumeLoading):
(BlackBerry::WebKit::WebPagePrivate::deferredTasksTimerFired):
(BlackBerry::WebKit::WebPage::assignFocus):
(BlackBerry::WebKit::WebPagePrivate::setPageVisibilityState):
(BlackBerry::WebKit::WebPage::setInputSelection):
(BlackBerry::WebKit::WebPage::popupListClosed):
(BlackBerry::WebKit::WebPage::setDateTimeInput):
(BlackBerry::WebKit::WebPage::setColorInput):
(BlackBerry::WebKit::WebPage::mouseEvent):
(BlackBerry::WebKit::WebPage::touchEvent):
(BlackBerry::WebKit::WebPage::touchPointAsMouseEvent):
(BlackBerry::WebKit::WebPage::touchEventCancel):
(BlackBerry::WebKit::WebPage::touchEventCancelAndClearFocusedNode):
(BlackBerry::WebKit::WebPage::keyEvent):
(BlackBerry::WebKit::WebPage::deleteTextRelativeToCursor):
(BlackBerry::WebKit::WebPage::setComposingText):
(BlackBerry::WebKit::WebPage::commitText):
(BlackBerry::WebKit::WebPage::selectionCancelled):
(BlackBerry::WebKit::WebPage::cutSelectedText):
(BlackBerry::WebKit::WebPage::insertText):
(BlackBerry::WebKit::WebPage::clearCurrentInputField):
(BlackBerry::WebKit::WebPage::cut):
(BlackBerry::WebKit::WebPage::paste):
(BlackBerry::WebKit::WebPage::setSelection):
(BlackBerry::WebKit::WebPage::setCaretPosition):
(BlackBerry::WebKit::WebPage::selectAtPoint):
(BlackBerry::WebKit::WebPage::setFocused):

  • Api/WebPage.h:
  • Api/WebPage_p.h:

(WebCore):
(WebPagePrivate):
(DeferredTaskBase):
(BlackBerry::WebKit::WebPagePrivate::DeferredTaskBase::perform):
(BlackBerry::WebKit::WebPagePrivate::DeferredTaskBase::DeferredTaskBase):

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::FrameLoaderClientBlackBerry):
(WebCore::FrameLoaderClientBlackBerry::~FrameLoaderClientBlackBerry):
(WebCore::FrameLoaderClientBlackBerry::willDeferLoading):
(WebCore::FrameLoaderClientBlackBerry::didResumeLoading):

  • WebCoreSupport/FrameLoaderClientBlackBerry.h:

(FrameLoaderClientBlackBerry):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::setPopupListIndexes):

  • WebKitSupport/InputHandler.h:

(InputHandler):

2:19 PM Apple_Bot_Watchers edited by kling@webkit.org
Fixing the links. (diff)
2:15 PM Changeset in webkit [115244] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix after r115227. Return null string when the string builder is empty
to match the old behavior.

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::borderPropertyValue):

2:13 PM Changeset in webkit [115243] by commit-queue@webkit.org
  • 13 edits in trunk/Source

[chromium] Add support for animation finished events.
https://bugs.webkit.org/show_bug.cgi?id=84454

Patch by Ian Vollick <vollick@chromium.org> on 2012-04-25
Reviewed by James Robinson.

Source/WebCore:

Tested in CCLayerTreeHostTestAnimationFinishedEvents

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::willBeDestroyed):
(WebCore::GraphicsLayerChromium::notifyAnimationFinished):
(WebCore):

  • platform/graphics/chromium/GraphicsLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::notifyAnimationStarted):
(WebCore::LayerChromium::notifyAnimationFinished):
(WebCore):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore):
(LayerChromium):

  • platform/graphics/chromium/cc/CCAnimationEvents.h:

(WebCore::CCAnimationEvent::CCAnimationEvent):
(CCAnimationEvent):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerAnimationController.cpp:

(WebCore::CCLayerAnimationController::animate):
(WebCore::CCLayerAnimationController::notifyAnimationStarted):
(WebCore::CCLayerAnimationController::startAnimationsWaitingForNextTick):
(WebCore::CCLayerAnimationController::startAnimationsWaitingForStartTime):
(WebCore::CCLayerAnimationController::startAnimationsWaitingForTargetAvailability):
(WebCore::CCLayerAnimationController::purgeFinishedAnimations):

  • platform/graphics/chromium/cc/CCLayerAnimationController.h:

(CCLayerAnimationController):

  • platform/graphics/chromium/cc/CCLayerAnimationDelegate.h:

(CCLayerAnimationDelegate):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::setAnimationEventsRecursive):

Source/WebKit/chromium:

  • tests/CCLayerAnimationControllerTest.cpp:

(WebKitTests::TEST):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::TestHooks::notifyAnimationFinished):
(WTF::TEST_F):
(WTF):
(CCLayerTreeHostTestAnimationFinishedEvents):
(WTF::CCLayerTreeHostTestAnimationFinishedEvents::CCLayerTreeHostTestAnimationFinishedEvents):
(WTF::CCLayerTreeHostTestAnimationFinishedEvents::beginTest):
(WTF::CCLayerTreeHostTestAnimationFinishedEvents::notifyAnimationFinished):
(WTF::CCLayerTreeHostTestAnimationFinishedEvents::afterTest):

1:59 PM Changeset in webkit [115242] by enrica@apple.com
  • 4 edits in trunk/Source

Source/WebCore: REGRESSION (r110494): Dragging images from Safari to Finder results in .webloc rather than image file
https://bugs.webkit.org/show_bug.cgi?id=84878
<rdar://problem/11155407>

In WebKit2, it could happen to try to start the drag twice, given the asynchronous nature
of the communication between the UI process and the WebProcess.
We need to guarantee that we don't do that, otherwise on OS X the pasteboard ownership
gets changed which affects the promised file types.

Reviewed by Alexey Proskuryakov.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleDrag): Reset m_mouseDownMayStartDrag to false to
avoid attempting to start another drag.

Source/WebKit2: REGRESSION (r110494): Dragging images from Safari to Finder results in .webloc rather than image file
https://bugs.webkit.org/show_bug.cgi?id=84878
<rdar://problem/11155407>

In WebKit2, it could happen to try to start the drag twice, given the asynchronous nature
of the communication between the UI process and the WebProcess.
We need to guarantee that we don't do that, otherwise on OS X the pasteboard ownership
gets changed which affects the promised file types.
The fix for the problem is in WebCore and we can now remove the guard on _setDragImage.

Reviewed by Alexey Proskuryakov.

  • UIProcess/API/mac/WKView.mm:

(-[WKView mouseDown:]):
(-[WKView _setDragImage:at:linkDrag:]):

1:58 PM Apple_Bot_Watchers created by mjs@apple.com
1:40 PM Changeset in webkit [115241] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unused Attribute constructor.

Semi-knowingly rubber-stamped by Antti Koivisto.

  • dom/Attribute.h:
1:34 PM Changeset in webkit [115240] by kkristof@inf.u-szeged.hu
  • 3 edits
    1 add in trunk/Tools

[Qt][NRWT] Run each DRT in it's own xvfb
https://bugs.webkit.org/show_bug.cgi?id=77335

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort._driver_class):

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort._driver_class):

  • Scripts/webkitpy/layout_tests/port/xvfbdriver.py: Added.

(XvfbDriver):
(XvfbDriver._start):
(XvfbDriver._start.x_filter):
(XvfbDriver.stop):

1:04 PM Changeset in webkit [115239] by schenney@chromium.org
  • 17 edits
    8 adds
    3 deletes in trunk/LayoutTests

Rebaseline chromium test results after bug 72796 is fixed
https://bugs.webkit.org/show_bug.cgi?id=84731

Unreviewed Chromikum expectations update.

Text baselines changed now that this bug has been fixed.

  • platform/chromium-linux-x86/svg/custom/use-clipped-hit-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/use-modify-target-symbol-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • platform/chromium-linux/svg/custom/use-clipped-hit-expected.txt: Added.
  • platform/chromium-linux/svg/custom/use-modify-target-symbol-expected.txt: Added.
  • platform/chromium-linux/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • platform/chromium-linux/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
  • platform/chromium-mac-leopard/svg/custom/use-on-disallowed-foreign-object-5-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/use-on-disallowed-foreign-object-5-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/use-on-disallowed-foreign-object-5-expected.txt: Removed.
  • platform/chromium-mac/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • platform/chromium-win-vista/svg/custom/use-clipped-hit-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/use-modify-target-symbol-expected.txt: Added.
  • platform/chromium-win-xp/svg/custom/use-clipped-hit-expected.txt: Added.
  • platform/chromium-win-xp/svg/custom/use-modify-target-symbol-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
  • platform/chromium-win/svg/carto.net/button-expected.txt:
  • platform/chromium-win/svg/carto.net/colourpicker-expected.txt:
  • platform/chromium-win/svg/carto.net/slider-expected.txt:
  • platform/chromium-win/svg/custom/use-clipped-hit-expected.txt:
  • platform/chromium-win/svg/custom/use-modify-target-symbol-expected.txt:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
  • platform/chromium-win/svg/custom/use-on-g-containing-symbol-expected.txt:
  • platform/chromium-win/svg/custom/use-on-symbol-expected.txt:
  • platform/chromium-win/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • platform/chromium-win/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
  • platform/chromium/test_expectations.txt:
12:55 PM Changeset in webkit [115238] by kling@webkit.org
  • 1 edit
    2 moves in trunk/LayoutTests

Use the same results for fast/html/details-marker-style.html on all mac bots.

  • platform/mac/fast/html/details-marker-style-expected.png: Renamed from LayoutTests/platform/mac-snowleopard/fast/html/details-marker-style-expected.png.
  • platform/mac/fast/html/details-marker-style-expected.txt: Renamed from LayoutTests/platform/mac-snowleopard/fast/html/details-marker-style-expected.txt.
12:53 PM Changeset in webkit [115237] by fpizlo@apple.com
  • 4 edits
    3 adds in trunk

http://bellard.org/jslinux/ triggers an assertion failure in the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=84815
<rdar://problem/11319514>

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::forwardSpeculationCheck):

LayoutTests:

Rubber stamped by Gavin Barraclough.

  • fast/js/dfg-uint32-to-number-on-captured-variable-expected.txt: Added.
  • fast/js/dfg-uint32-to-number-on-captured-variable.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-uint32-to-number-on-captured-variable.js: Added.

(foo):

12:31 PM Changeset in webkit [115236] by Nate Chapin
  • 3 edits
    2 adds in trunk

Source/WebCore: Crash in CachedRawResource::didAddClient() due to missing protector.
https://bugs.webkit.org/show_bug.cgi?id=83632

Reviewed by Eric Seidel.

Test: http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash.html

  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::didAddClient):

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=83632.

Reviewed by Eric Seidel.

  • http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash.html: Added.
12:26 PM Changeset in webkit [115235] by scherkus@chromium.org
  • 41 edits
    1 move
    1 delete in trunk/LayoutTests

2012-04-25 Andrew Scherkus <scherkus@chromium.org>

Rebaseline Chromium media layout tests due to r114957.

  • platform/chromium-linux-x86/media/video-empty-source-expected.txt:
  • platform/chromium-linux/media/media-document-audio-repaint-expected.txt: Removed.
  • platform/chromium-linux/media/video-empty-source-expected.txt:
  • platform/chromium-mac-leopard/media/video-empty-source-expected.txt:
  • platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
  • platform/chromium-mac-snowleopard/media/video-empty-source-expected.txt:
  • platform/chromium-mac/fast/layers/video-layer-expected.txt:
  • platform/chromium-mac/media/audio-controls-rendering-expected.txt:
  • platform/chromium-mac/media/audio-repaint-expected.txt:
  • platform/chromium-mac/media/controls-after-reload-expected.txt:
  • platform/chromium-mac/media/controls-strict-expected.txt:
  • platform/chromium-mac/media/controls-styling-expected.txt:
  • platform/chromium-mac/media/controls-without-preload-expected.txt:
  • platform/chromium-mac/media/media-controls-clone-expected.txt:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-mac/media/video-controls-rendering-expected.txt:
  • platform/chromium-mac/media/video-display-toggle-expected.txt:
  • platform/chromium-mac/media/video-empty-source-expected.txt:
  • platform/chromium-mac/media/video-no-audio-expected.txt:
  • platform/chromium-mac/media/video-playing-and-pause-expected.txt:
  • platform/chromium-mac/media/video-volume-slider-expected.txt:
  • platform/chromium-mac/media/video-zoom-controls-expected.txt:
  • platform/chromium-win-vista/media/video-empty-source-expected.txt:
  • platform/chromium-win-xp/media/video-empty-source-expected.txt:
  • platform/chromium-win/fast/layers/video-layer-expected.txt:
  • platform/chromium-win/media/audio-controls-rendering-expected.txt:
  • platform/chromium-win/media/audio-repaint-expected.txt:
  • platform/chromium-win/media/controls-after-reload-expected.txt:
  • platform/chromium-win/media/controls-strict-expected.txt:
  • platform/chromium-win/media/controls-styling-expected.txt:
  • platform/chromium-win/media/controls-without-preload-expected.txt:
  • platform/chromium-win/media/media-controls-clone-expected.txt:
  • platform/chromium-win/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-win/media/video-controls-rendering-expected.txt:
  • platform/chromium-win/media/video-display-toggle-expected.txt:
  • platform/chromium-win/media/video-empty-source-expected.txt:
  • platform/chromium-win/media/video-no-audio-expected.txt:
  • platform/chromium-win/media/video-playing-and-pause-expected.txt:
  • platform/chromium-win/media/video-volume-slider-expected.txt:
  • platform/chromium-win/media/video-zoom-controls-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/qt/media/audio-repaint-expected.txt: Renamed from LayoutTests/media/audio-repaint-expected.txt.
11:57 AM Changeset in webkit [115234] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[V8] Pass Isolate to SerializedScriptValue::deserialize()
https://bugs.webkit.org/show_bug.cgi?id=84758

Reviewed by Nate Chapin.

The objective is to pass Isolate around. This patch passes
Isolate to SerializedScriptValue::deserialize().

No tests. No change in behavior.

  • bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::stateAccessorGetter):

  • bindings/v8/custom/V8IDBAnyCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAccessorGetter):

  • bindings/v8/custom/V8PopStateEventCustom.cpp:

(WebCore::V8PopStateEvent::stateAccessorGetter):

11:38 AM Changeset in webkit [115233] by haraken@chromium.org
  • 6 edits in trunk/Source/WebCore

[V8] Pass Isolate to SerializedScriptValue::create() in custom bindings
https://bugs.webkit.org/show_bug.cgi?id=84757

Reviewed by Nate Chapin.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to SerializedScriptValue::create()
in custom bindings.

No tests. No change in behavior.

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::handlePostMessageCallback):

  • bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:

(WebCore::handlePostMessageCallback):

  • bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):

  • bindings/v8/custom/V8MessagePortCustom.cpp:

(WebCore::handlePostMessageCallback):

  • bindings/v8/custom/V8WorkerCustom.cpp:

(WebCore::handlePostMessageCallback):

11:21 AM Changeset in webkit [115232] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84877

Mark a failing test after changes in r115227.

  • platform/chromium/test_expectations.txt:
11:14 AM Changeset in webkit [115231] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

[V8] Pass Isolate to SerializedScriptValue::create() in CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=84753

Reviewed by Nate Chapin.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to SerializedScriptValue::create()
in CodeGeneratorV8.pm.

Tests: bindings/scripts/test/TestObj.idl

bindings/scripts/test/TestSerializedScriptValueInterface.idl

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrSetter):
(GenerateParametersCheck):
(JSValueToNative):

  • bindings/scripts/test/V8/V8TestObj.cpp: Updated run-bindings-tests results.

(WebCore::TestObjV8Internal::intSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::shortSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::longSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::longLongSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::unsignedIntSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::unsignedShortSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::unsignedLongSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::unsignedLongLongSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::floatSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::doubleSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::booleanSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::voidSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::dateSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::serializedValueCallback):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrSetter):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrSetter):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::acceptTransferListCallback):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::multiTransferListCallback):
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):

11:12 AM Changeset in webkit [115230] by commit-queue@webkit.org
  • 4 edits in trunk

Unreviewed, rolling out r115222.
http://trac.webkit.org/changeset/115222
https://bugs.webkit.org/show_bug.cgi?id=84874

Caused test regressions on the EFL build (Requested by rakuco
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-25

Tools:

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::addOriginAccessWhitelistEntry):
(LayoutTestController::removeOriginAccessWhitelistEntry):

LayoutTests:

  • platform/efl/Skipped:
11:09 AM Scrolling Session Meeting 2012 edited by jchaffraix@webkit.org
Added line breaks for better formatting, also fixed my name (diff)
11:07 AM Changeset in webkit [115229] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[V8] Add m_isolate to SerializedScriptValue::Writer
and SerializedScriptValue::Reader
https://bugs.webkit.org/show_bug.cgi?id=84739

Reviewed by Nate Chapin.

This is the second step to pass Isolate around
in SerializedScriptValue. This patch adds m_isolate to
SerializedScriptValue::Writer and SerializedScriptValue::Reader,
so that they can use the isolate around. The fix is safe since
Writer and Reader are guaranteed to be used by one Isolate.

No tests. No change in behavior.

  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::nullValue):
(WebCore::SerializedScriptValue::undefinedValue):
(WebCore::SerializedScriptValue::booleanValue):
(WebCore::SerializedScriptValue::numberValue):
(WebCore::SerializedScriptValue::SerializedScriptValue):
(WebCore::SerializedScriptValue::deserialize):

  • bindings/v8/SerializedScriptValue.h:

(SerializedScriptValue):

10:58 AM Changeset in webkit [115228] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Make the Isolate* parameter non-optional in setDOMException()
https://bugs.webkit.org/show_bug.cgi?id=84736

Reviewed by Nate Chapin.

Now all setDOMException() callers pass Isolate* to setDOMException().
This patch makes the Isolate* parameter non-optional.

No tests. No change in behavior.

  • bindings/v8/V8Proxy.h:

(V8Proxy):

10:44 AM Changeset in webkit [115227] by rniwa@webkit.org
  • 8 edits in trunk

REGRESSION(r112177): listStyleType CSS property gets converted into listStyle
https://bugs.webkit.org/show_bug.cgi?id=83026

Reviewed by Darin Adler.

Source/WebCore:

Fixed the bug by not using shorthand notations when some values are missing.

However, we still want to return a value when shorthand border property is explicitly
requested so extract borderPropertyValue with a flag to support both behaviors.

  • css/StylePropertySet.cpp:

(WebCore::borderPropertyValue): Extracted from getPropertyValue.
(WebCore::StylePropertySet::getPropertyValue):
(WebCore::StylePropertySet::get4Values): Don't return values when priority don't match.
(WebCore::StylePropertySet::getShorthandValue):
(WebCore::StylePropertySet::getCommonValue): Don't return null string for initial values
to disambiguate missing values and "initial" in getPropertyValue. Also check propriety.
(WebCore::StylePropertySet::asText): Support emitting border-width, border-style, and
border-color when border doesn't work but the former properties do.

LayoutTests:

Added test cases to cssText-shorthand.html and rebaselined some tests.

  • fast/css/cssText-shorthand-expected.txt:
  • fast/css/cssText-shorthand.html: Added more test cases.
  • fast/css/remove-shorthand-expected.txt: Correctly adds both border-width and border-style

when border-color is missing.

  • printing/page-rule-css-text-expected.txt: Correctly uses border-width instead of border.
10:32 AM Changeset in webkit [115226] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[chromium] Do not clobber synchronized start times.
https://bugs.webkit.org/show_bug.cgi?id=84605

Patch by Ian Vollick <vollick@chromium.org> on 2012-04-25
Reviewed by James Robinson.

Source/WebCore:

Tested in CCLayerAnimationControllerTest.doNotClobberStartTimes

(WebCore):

  • platform/graphics/chromium/cc/CCActiveAnimation.h:

(CCActiveAnimation):
(WebCore::CCActiveAnimation::hasSetStartTime):

  • platform/graphics/chromium/cc/CCLayerAnimationController.cpp:

(WebCore::CCLayerAnimationController::startAnimationsWaitingForNextTick):
(WebCore::CCLayerAnimationController::startAnimationsWaitingForTargetAvailability):

Source/WebKit/chromium:

  • tests/CCLayerAnimationControllerTest.cpp:

(WebKitTests):
(WebKitTests::TEST):

10:16 AM Changeset in webkit [115225] by Lucas Forschler
  • 4 edits in tags/Safari-536.8.1/Source

Versioning.

10:13 AM Changeset in webkit [115224] by Lucas Forschler
  • 1 copy in tags/Safari-536.8.1

New Tag.

10:12 AM Changeset in webkit [115223] by Nate Chapin
  • 4 edits
    2 adds in trunk

Source/WebCore: REGRESSION (r100311): YummySoup app crashes when trying to print
https://bugs.webkit.org/show_bug.cgi?id=83918

Reviewed by Alexey Proskuryakov.

Test: http/tests/xmlhttprequest/cancel-during-failure-crash.html

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::didFail): Set m_calledDidFinishLoad when calling

didFailToLoad() to prevent it from getting called twice if we cancel
re-entrantly.

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=83918.

Reviewed by Alexey Proskuryakov.

  • http/tests/cache/cancel-during-failure-crash-expected.txt: Added.
  • http/tests/cache/cancel-during-failure-crash.html: Added.
10:09 AM Deprecating features and vendor prefixes edited by jchaffraix@webkit.org
Added a link to the new deprecating features page (diff)
10:07 AM DeprecatingFeatures created by jchaffraix@webkit.org
Dumping a first draft of the proposal using the talk's notes
10:04 AM Changeset in webkit [115222] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] [DRT] LayoutTestController needs implementation of addOriginAccessWhitelistEntry and removeOriginAccessWhitelistEntry
https://bugs.webkit.org/show_bug.cgi?id=83880

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-25
Reviewed by Antonio Gomes.

Tools:

Add missing implementation addOriginAccessWhitelistEntry and
removeOriginAccessWhitelistEntry to EFL's LayoutTestController
in order to unskip tests which rely on this.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::addOriginAccessWhitelistEntry):
(LayoutTestController::removeOriginAccessWhitelistEntry):

LayoutTests:

Unskip test cases which rely on LayoutTestController's addOriginAccessWhitelistEntry
and removeOriginAccessWhitelistEntry implementation.

  • platform/efl/Skipped:
9:48 AM WikiStart edited by jchaffraix@webkit.org
Adding a new page about "deprecating features" (diff)
9:46 AM Changeset in webkit [115221] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

Not reviewed, fix Windows build after r115215.

  • css/CSSAllInOne.cpp:
9:28 AM Changeset in webkit [115220] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

Not reviewed, attempt to fix Windows build after r115215.

  • css/CSSAllInOne.cpp: Don't try to include CSSStyleSelector.cpp.
9:16 AM Changeset in webkit [115219] by pilgrim@chromium.org
  • 9 edits in trunk/Source

[Chromium] Call actualMemoryUsageMB directly
https://bugs.webkit.org/show_bug.cgi?id=84837

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::reportFatalErrorInV8):

  • bindings/v8/V8GCController.cpp:

(WebCore):

  • platform/MemoryUsageSupport.cpp:

(WebCore::MemoryUsageSupport::actualMemoryUsageMB):
(WebCore):

  • platform/MemoryUsageSupport.h:

(MemoryUsageSupport):

  • platform/chromium/MemoryUsageSupportChromium.cpp:

(WebCore::MemoryUsageSupport::actualMemoryUsageMB):
(WebCore):

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore):

9:12 AM Changeset in webkit [115218] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] [DRT] Reset text zoom factor before running a test
https://bugs.webkit.org/show_bug.cgi?id=84861

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-25
Reviewed by Antonio Gomes.

This fix eliminates most of the current flakiness on EFL build
bots, although some CSS tests will now need rebasiling.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

9:11 AM Changeset in webkit [115217] by msaboff@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Closure in try {} with catch captures all locals from the enclosing function
https://bugs.webkit.org/show_bug.cgi?id=84804

Reviewed by Oliver Hunt.

Changed the capturing of local variables from capturing when eval is used,
within a "with" or within a "catch" to be just when an eval is used.
Renamed the function returning that we should capture from
getCapturedVariables() to usesEval(), since that what it noew returns.
Needed to fix the "with" code to only range check when the activation
has actually been torn off. Added m_isTornOff to JSActivation to
track this.

  • parser/Parser.h:

(JSC::Scope::usesEval):
(JSC::Scope::getCapturedVariables):

  • runtime/JSActivation.cpp:

(JSC::JSActivation::JSActivation):
(JSC::JSActivation::symbolTableGet):
(JSC::JSActivation::symbolTablePut):

  • runtime/JSActivation.h:

(JSActivation):
(JSC::JSActivation::tearOff):

8:51 AM Changeset in webkit [115216] by commit-queue@webkit.org
  • 1 edit
    418 deletes in trunk/LayoutTests

[EFL] Remove duplicated test expectations
https://bugs.webkit.org/show_bug.cgi?id=84717

Unreviewed gardening.

These expected results are the same as the global ones.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-25

  • platform/efl/compositing/geometry/tall-page-composited-expected.txt: Removed.
  • platform/efl/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt: Removed.
  • platform/efl/fast/block/float/in-margin-expected.txt: Removed.
  • platform/efl/fast/block/positioning/028-expected.txt: Removed.
  • platform/efl/fast/block/positioning/031-expected.txt: Removed.
  • platform/efl/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Removed.
  • platform/efl/fast/borders/border-image-outset-split-inline-vertical-lr-expected.txt: Removed.
  • platform/efl/fast/borders/border-radius-different-width-001-expected.txt: Removed.
  • platform/efl/fast/borders/borderRadiusDashed01-expected.txt: Removed.
  • platform/efl/fast/borders/borderRadiusDashed06-expected.txt: Removed.
  • platform/efl/fast/borders/borderRadiusDotted02-expected.txt: Removed.
  • platform/efl/fast/borders/borderRadiusDotted03-expected.txt: Removed.
  • platform/efl/fast/borders/inline-mask-overlay-image-outset-expected.txt: Removed.
  • platform/efl/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.txt: Removed.
  • platform/efl/fast/borders/only-one-border-with-width-expected.txt: Removed.
  • platform/efl/fast/clip/017-expected.txt: Removed.
  • platform/efl/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Removed.
  • platform/efl/fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.txt: Removed.
  • platform/efl/fast/dom/HTMLMeterElement/meter-element-expected.txt: Removed.
  • platform/efl/fast/dom/Window/webkitConvertPoint-expected.txt: Removed.
  • platform/efl/fast/dynamic/subtree-boundary-percent-height-expected.txt: Removed.
  • platform/efl/fast/dynamic/subtree-no-common-root-static-y-expected.txt: Removed.
  • platform/efl/fast/dynamic/subtree-table-cell-height-expected.txt: Removed.
  • platform/efl/fast/files/url-required-arguments-expected.txt: Removed.
  • platform/efl/fast/gradients/border-image-gradient-expected.txt: Removed.
  • platform/efl/fast/gradients/border-image-gradient-sides-and-corners-expected.txt: Removed.
  • platform/efl/fast/images/color-jpeg-with-color-profile-expected.txt: Removed.
  • platform/efl/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Removed.
  • platform/efl/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
  • platform/efl/fast/parser/comment-in-script-expected.txt: Removed.
  • platform/efl/fast/repaint/overflow-clip-subtree-layout-expected.txt: Removed.
  • platform/efl/fast/repaint/subtree-root-clip-2-expected.txt: Removed.
  • platform/efl/fast/repaint/subtree-root-clip-3-expected.txt: Removed.
  • platform/efl/fast/repaint/subtree-root-clip-expected.txt: Removed.
  • platform/efl/fast/replaced/image-tag-expected.txt: Removed.
  • platform/efl/fast/ruby/ruby-base-merge-block-children-crash-expected.txt: Removed.
  • platform/efl/svg/as-background-image/background-image-tiled-expected.txt: Removed.
  • platform/efl/svg/as-background-image/same-image-two-instances-background-image-expected.txt: Removed.
  • platform/efl/svg/as-image/svg-as-relative-image-with-explicit-size-expected.txt: Removed.
  • platform/efl/svg/clip-path/clip-in-mask-expected.txt: Removed.
  • platform/efl/svg/clip-path/clip-path-css-transform-1-expected.txt: Removed.
  • platform/efl/svg/clip-path/clip-path-css-transform-2-expected.txt: Removed.
  • platform/efl/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.txt: Removed.
  • platform/efl/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.txt: Removed.
  • platform/efl/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.txt: Removed.
  • platform/efl/svg/css/mask-with-shadow-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVG-dynamic-css-transform-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGAElement-dom-href-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGAElement-dom-target-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGAElement-svgdom-href-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGAElement-svgdom-target-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGCircleElement-dom-cx-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGCircleElement-dom-cy-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGCircleElement-dom-r-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGCircleElement-dom-requiredFeatures-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGCircleElement-svgdom-cx-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGCircleElement-svgdom-cy-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGCircleElement-svgdom-r-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGClipPathElement-svgdom-clipPathUnits-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGEllipseElement-dom-cx-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGEllipseElement-dom-cy-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGEllipseElement-dom-requiredFeatures-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGEllipseElement-dom-rx-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGEllipseElement-dom-ry-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGEllipseElement-svgdom-cx-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGEllipseElement-svgdom-cy-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGEllipseElement-svgdom-requiredFeatures-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGEllipseElement-svgdom-rx-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGEllipseElement-svgdom-ry-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEDistantLightElement-dom-azimuth-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEDistantLightElement-dom-elevation-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEDistantLightElement-svgdom-azimuth-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEDistantLightElement-svgdom-elevation-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEOffsetElement-dom-dx-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEOffsetElement-dom-dy-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEOffsetElement-dom-in-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dx-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dy-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEOffsetElement-svgdom-in-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-dom-limitingConeAngle-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtZ-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-dom-specularExponent-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-svgdom-limitingConeAngle-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtZ-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-svgdom-specularExponent-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-svgdom-z-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFilterElement-dom-height-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFilterElement-dom-width-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFilterElement-dom-x-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFilterElement-dom-y-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFilterElement-svgdom-height-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFilterElement-svgdom-width-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFilterElement-svgdom-x-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFilterElement-svgdom-y-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGForeignObjectElement-dom-height-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGForeignObjectElement-dom-requiredFeatures-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGForeignObjectElement-dom-width-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGForeignObjectElement-dom-x-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGForeignObjectElement-dom-y-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGForeignObjectElement-svgdom-height-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGForeignObjectElement-svgdom-requiredFeatures-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGForeignObjectElement-svgdom-width-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGForeignObjectElement-svgdom-x-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGForeignObjectElement-svgdom-y-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGGElement-dom-requiredFeatures-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGGElement-svgdom-requiredFeatures-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGImageElement-dom-requiredFeatures-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGLineElement-dom-x1-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGLineElement-dom-x2-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGLineElement-dom-y1-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGLineElement-dom-y2-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGLineElement-svgdom-x1-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGLineElement-svgdom-x2-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGLineElement-svgdom-y1-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGLineElement-svgdom-y2-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-dom-markerUnits-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-dom-markerWidth-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-dom-orient-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-dom-refX-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-dom-refY-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-svgdom-markerHeight-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-svgdom-markerUnits-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-svgdom-markerWidth-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-svgdom-orientAngle-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-svgdom-orientType-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-svgdom-refX-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-svgdom-refY-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAuto-call-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGMaskElement-dom-height-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGMaskElement-dom-width-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGMaskElement-dom-x-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGMaskElement-dom-y-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGMaskElement-svgdom-height-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGMaskElement-svgdom-width-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGMaskElement-svgdom-x-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGMaskElement-svgdom-y-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGPathElement-dom-requiredFeatures-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGPatternElement-dom-height-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGPatternElement-dom-patternUnits-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGPatternElement-dom-width-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGPatternElement-dom-x-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGPatternElement-dom-y-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGPatternElement-svgdom-height-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGPatternElement-svgdom-patternContentUnits-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGPatternElement-svgdom-patternUnits-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGPatternElement-svgdom-width-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGRectElement-dom-height-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGRectElement-dom-requiredFeatures-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGRectElement-dom-width-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGRectElement-dom-x-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGRectElement-dom-y-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGRectElement-svgdom-height-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGRectElement-svgdom-width-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGRectElement-svgdom-x-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGRectElement-svgdom-y-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGTRefElement-dom-href-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGTextElement-dom-dx-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGTextElement-dom-dy-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGTextElement-dom-requiredFeatures-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGTextElement-dom-transform-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGTextElement-dom-x-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGTextElement-dom-y-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGTextElement-svgdom-rotate-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGTextElement-svgdom-transform-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGTextElement-svgdom-x-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGTextElement-svgdom-y-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.txt: Removed.
  • platform/efl/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.txt: Removed.
  • platform/efl/svg/zoom/page/zoom-svg-as-image-expected.txt: Removed.
  • platform/efl/svg/zoom/page/zoom-svg-as-object-expected.txt: Removed.
  • platform/efl/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Removed.
  • platform/efl/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.txt: Removed.
  • platform/efl/svg/zoom/text/absolute-sized-document-scrollbars-expected.txt: Removed.
  • platform/efl/svg/zoom/text/relative-sized-document-scrollbars-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug120107-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug1271-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug12908-2-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug13169-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug196870-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug50695-2-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug9024-expected.txt: Removed.
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
8:49 AM Changeset in webkit [115215] by alexis.menard@openbossa.org
  • 71 edits
    2 moves in trunk/Source

Rename CSSStyleSelector files to StyleResolver.
https://bugs.webkit.org/show_bug.cgi?id=84814

Reviewed by Antti Koivisto.

Rename CSSStyleSelector files to match the new class name StyleResolver.
Update the includes all over the code base to the new name.

Source/WebCore:

No new tests : renaming files, no behavior changes expected.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSAllInOne.cpp:
  • css/CSSCalculationValue.cpp:
  • css/CSSFontSelector.cpp:
  • css/CSSGradientValue.cpp:
  • css/MediaQueryEvaluator.cpp:
  • css/MediaQueryMatcher.cpp:
  • css/SVGCSSStyleSelector.cpp:
  • css/StyleBuilder.cpp:
  • css/StyleMedia.cpp:
  • css/StyleResolver.cpp: Renamed from Source/WebCore/css/CSSStyleSelector.cpp.

(WebCore):
(RuleData):
(WebCore::RuleData::position):
(WebCore::RuleData::rule):
(WebCore::RuleData::selector):
(WebCore::RuleData::hasFastCheckableSelector):
(WebCore::RuleData::hasMultipartSelector):
(WebCore::RuleData::hasRightmostSelectorMatchingHTMLBasedOnRuleHash):
(WebCore::RuleData::containsUncommonAttributeSelector):
(WebCore::RuleData::specificity):
(WebCore::RuleData::linkMatchType):
(WebCore::RuleData::hasDocumentSecurityOrigin):
(WebCore::RuleData::isInRegionRule):
(WebCore::RuleData::descendantSelectorIdentifierHashes):
(SameSizeAsRuleData):
(RuleSet):
(WebCore::RuleSet::create):
(WebCore::RuleSet::disableAutoShrinkToFit):
(WebCore::RuleSet::features):
(WebCore::RuleSet::idRules):
(WebCore::RuleSet::classRules):
(WebCore::RuleSet::tagRules):
(WebCore::RuleSet::shadowPseudoElementRules):
(WebCore::RuleSet::linkPseudoClassRules):
(WebCore::RuleSet::focusPseudoClassRules):
(WebCore::RuleSet::universalRules):
(WebCore::RuleSet::pageRules):
(WebCore::RuleSet::RuleSetSelectorPair::RuleSetSelectorPair):
(RuleSetSelectorPair):
(WebCore::elementCanUseSimpleDefaultStyle):
(WebCore::screenEval):
(WebCore::printEval):
(WebCore::leftToRightDeclaration):
(WebCore::rightToLeftDeclaration):
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::addAuthorRulesAndCollectUserRulesFromSheets):
(WebCore::makeRuleSet):
(WebCore::StyleResolver::collectFeatures):
(WebCore::StyleResolver::determineScope):
(WebCore::StyleResolver::ruleSetForScope):
(WebCore::StyleResolver::appendAuthorStylesheets):
(WebCore::StyleResolver::setupScopeStack):
(WebCore::StyleResolver::pushScope):
(WebCore::StyleResolver::popScope):
(WebCore::StyleResolver::pushParentElement):
(WebCore::StyleResolver::popParentElement):
(WebCore::StyleResolver::pushParentShadowRoot):
(WebCore::StyleResolver::popParentShadowRoot):
(WebCore::StyleResolver::addKeyframeStyle):
(WebCore::StyleResolver::~StyleResolver):
(WebCore::StyleResolver::sweepMatchedPropertiesCache):
(WebCore::StyleResolver::Features::Features):
(WebCore::StyleResolver::Features::~Features):
(WebCore::StyleResolver::Features::add):
(WebCore::StyleResolver::Features::clear):
(WebCore::parseUASheet):
(WebCore::loadFullDefaultStyle):
(WebCore::loadSimpleDefaultStyle):
(WebCore::loadViewSourceStyle):
(WebCore::ensureDefaultStyleSheetsForElement):
(WebCore::StyleResolver::addMatchedProperties):
(WebCore::StyleResolver::addElementStyleProperties):
(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::collectMatchingRulesForRegion):
(WebCore::StyleResolver::sortAndTransferMatchedRules):
(WebCore::StyleResolver::matchScopedAuthorRules):
(WebCore::StyleResolver::matchAuthorRules):
(WebCore::StyleResolver::matchUserRules):
(WebCore::StyleResolver::matchUARules):
(MatchingUARulesScope):
(WebCore::MatchingUARulesScope::MatchingUARulesScope):
(WebCore::MatchingUARulesScope::~MatchingUARulesScope):
(WebCore::MatchingUARulesScope::isMatchingUARules):
(WebCore::StyleResolver::collectMatchingRulesForList):

  • css/StyleResolver.h: Renamed from Source/WebCore/css/CSSStyleSelector.h.

(WebCore):
(MediaQueryResult):
(WebCore::MediaQueryResult::MediaQueryResult):
(StyleResolver):
(WebCore::StyleResolver::style):
(WebCore::StyleResolver::parentStyle):
(WebCore::StyleResolver::rootElementStyle):
(WebCore::StyleResolver::element):
(WebCore::StyleResolver::document):
(WebCore::StyleResolver::fontDescription):
(WebCore::StyleResolver::parentFontDescription):
(WebCore::StyleResolver::setFontDescription):
(WebCore::StyleResolver::setZoom):
(WebCore::StyleResolver::setEffectiveZoom):
(WebCore::StyleResolver::setTextSizeAdjust):
(WebCore::StyleResolver::hasParentNode):
(WebCore::StyleResolver::pushScope):
(WebCore::StyleResolver::popScope):
(WebCore::StyleResolver::setStyle):
(WebCore::StyleResolver::fontSelector):
(WebCore::StyleResolver::allVisitedStateChanged):
(WebCore::StyleResolver::visitedStateChanged):
(WebCore::StyleResolver::usesSiblingRules):
(WebCore::StyleResolver::usesFirstLineRules):
(WebCore::StyleResolver::usesBeforeAfterRules):
(WebCore::StyleResolver::usesLinkRules):
(WebCore::StyleResolver::RuleFeature::RuleFeature):
(RuleFeature):
(Features):
(WebCore::StyleResolver::addMatchedRule):
(WebCore::StyleResolver::MatchRanges::MatchRanges):
(MatchRanges):
(WebCore::StyleResolver::MatchedProperties::MatchedProperties):
(MatchedProperties):
(WebCore::StyleResolver::MatchResult::MatchResult):
(MatchResult):
(WebCore::StyleResolver::MatchOptions::MatchOptions):
(MatchOptions):
(WebCore::StyleResolver::isRightPage):
(WebCore::StyleResolver::styleNotYetAvailable):
(WebCore::StyleResolver::applyPropertyToRegularStyle):
(WebCore::StyleResolver::applyPropertyToVisitedLinkStyle):
(MatchedPropertiesCacheItem):
(WebCore::StyleResolver::scopeStackIsConsistent):
(WebCore::StyleResolver::ScopeStackFrame::ScopeStackFrame):
(ScopeStackFrame):

  • css/WebKitCSSMatrix.cpp:
  • dom/Document.cpp:
  • dom/Element.cpp:
  • dom/Node.cpp:
  • dom/ShadowRoot.cpp:
  • dom/ShadowTree.cpp:
  • dom/StyledElement.cpp:
  • editing/ApplyStyleCommand.cpp:
  • editing/EditingStyle.cpp:
  • editing/Editor.cpp:
  • editing/markup.cpp:
  • history/CachedPage.cpp:
  • html/HTMLDocument.cpp:
  • html/HTMLLinkElement.cpp:
  • html/HTMLOptGroupElement.cpp:
  • html/HTMLOptionElement.cpp:
  • html/ValidationMessage.cpp:
  • html/canvas/CanvasRenderingContext2D.cpp:
  • html/shadow/MediaControlElements.cpp:
  • inspector/InspectorCSSAgent.cpp:
  • inspector/InspectorDOMAgent.cpp:
  • inspector/InspectorStyleSheet.cpp:
  • loader/LinkLoader.cpp:
  • page/DOMWindow.cpp:
  • page/FrameView.cpp:
  • page/Page.cpp:
  • page/animation/KeyframeAnimation.cpp:
  • platform/qt/RenderThemeQt.cpp:
  • platform/qt/RenderThemeQtMobile.cpp:
  • rendering/RenderLayer.cpp:
  • rendering/RenderLayerBacking.cpp:
  • rendering/RenderListBox.cpp:
  • rendering/RenderMenuList.cpp:
  • rendering/RenderObject.cpp:
  • rendering/RenderRegion.cpp:
  • rendering/RenderSlider.cpp:
  • rendering/RenderTextControlSingleLine.cpp:
  • rendering/RenderThemeMac.mm:
  • rendering/RenderThemeSafari.cpp:
  • rendering/style/RenderStyle.cpp:
  • rendering/style/StyleGeneratedImage.cpp:
  • rendering/style/StyleRareNonInheritedData.cpp:
  • rendering/svg/RenderSVGInlineText.cpp:
  • svg/SVGClipPathElement.cpp:
  • svg/SVGElement.cpp:
  • svg/SVGFontFaceElement.cpp:
  • svg/SVGGradientElement.cpp:
  • svg/SVGMaskElement.cpp:
  • svg/SVGUseElement.cpp:

Source/WebKit/chromium:

  • src/AutofillPopupMenuClient.cpp:
  • src/WebViewImpl.cpp:

Source/WebKit/qt:

  • Api/qwebelement.cpp:
  • WebCoreSupport/RenderThemeQStyle.cpp:
8:37 AM Changeset in webkit [115214] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update
https://bugs.webkit.org/show_bug.cgi?id=84427

Unmark platform/chromium/editing/spelling/delete-misspelled-word.html as flaky.
The test has been fixed in r114866.

  • platform/chromium/test_expectations.txt:
8:36 AM Changeset in webkit [115213] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip a flaky test.
https://bugs.webkit.org/show_bug.cgi?id=84866

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-04-25

  • platform/qt/Skipped:
8:29 AM Changeset in webkit [115212] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=84875

make-css-file-arrays.pl now only take css files, make it also take js files,
as for html popups we also need load js files.

Reviewed by Antonio Gomes.

  • css/make-css-file-arrays.pl:

Patch by Crystal Zhang <haizhang@rim.com> on 2012-04-25

8:24 AM Changeset in webkit [115211] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update
https://bugs.webkit.org/show_bug.cgi?id=82300

Unmark compositing/images/direct-pdf-image.html as failing on Mac 10.6

  • platform/chromium/test_expectations.txt:
8:22 AM Changeset in webkit [115210] by commit-queue@webkit.org
  • 8 edits
    8 adds in trunk

[Qt] add LayoutTestController::setPrinting support to Qt unit tests
https://bugs.webkit.org/show_bug.cgi?id=84246

Patch by Milian Wolff <milian.wolff@kdab.com> on 2012-04-25
Reviewed by Simon Hausmann.

Source/WebKit/qt:

  • Api/qwebframe.cpp:

(QWebFrame::paintPagesWithBoundaries):

  • Api/qwebframe.h:
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::paintPagesWithBoundaries):

  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::dump):

LayoutTests:

  • platform/qt/printing/compositing-layer-printing-expected.png: Added.
  • platform/qt/printing/compositing-layer-printing-expected.txt: Added.
  • platform/qt/printing/media-queries-print-expected.png: Added.
  • platform/qt/printing/media-queries-print-expected.txt: Added.
  • platform/qt/printing/page-rule-in-media-query-expected.png: Added.
  • platform/qt/printing/page-rule-in-media-query-expected.txt: Renamed from LayoutTests/platform/qt/printing/page-rule-in-media-query-expected.txt.
  • platform/qt/printing/simultaneous-position-float-change-expected.png: Added.
  • platform/qt/printing/simultaneous-position-float-change-expected.txt: Added.
  • platform/qt/printing/width-overflow-expected.png: Added.
  • platform/qt/printing/width-overflow-expected.txt: Added.
  • platform/qt/Skipped:
  • platform/qt/printing/page-rule-in-media-query-expected.png: Removed.
8:16 AM Changeset in webkit [115209] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update
https://bugs.webkit.org/show_bug.cgi?id=74055

Unmark fast/canvas/canvas-largedraws.html as failing on Mac 10.5

  • platform/chromium/test_expectations.txt:
8:10 AM Changeset in webkit [115208] by mhahnenberg@apple.com
  • 2 edits in trunk/LayoutTests

fast/js/random-array-gc-stress times out in debug mode
https://bugs.webkit.org/show_bug.cgi?id=84821

Reviewed by Darin Adler.

  • fast/js/script-tests/random-array-gc-stress.js: Reduce number of iterations so

that the test can complete without timing out. Also remove the gc() function because
a gc() function is already provided in resources/js-test-pre.js.

7:52 AM Changeset in webkit [115207] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium][workers] setTargetType(ResourceRequest::TargetIsWorker) is repeatedly called in chromium
https://bugs.webkit.org/show_bug.cgi?id=84542

Patch by Li Yin <li.yin@intel.com> on 2012-04-25
Reviewed by David Levin.

In chromium platform, the default value of m_targetType is ResourceRequest::TargetIsWorker
it isn't necessary to call
worker->m_scriptLoader->setTargetType(ResourceRequest::TargetIsWorker) again in Worker.cpp
In chromium platform, the m_targettype value determines the priority of resource loaded.

No new tests because this patch just deletes a repeated code, it can reduce code workload and can't impact any feature.
If the target type isn't set correctly, the following test maybe fail because of timeout in the chromium.
fast/workers/storage/multiple-transactions-on-different-handles.html
fast/workers/storage/multiple-transactions-on-different-handles-sync.html
fast/workers/storage/interrupt-database.html

  • workers/Worker.cpp:

(WebCore::Worker::create):

7:42 AM Changeset in webkit [115206] by gavinp@chromium.org
  • 6 edits in trunk/Source

[Chromium] Fix some conditional compilation logic in Platform
https://bugs.webkit.org/show_bug.cgi?id=83798

Reviewed by Darin Fisher.

Source/Platform:

  • chromium/public/WebURLError.h:

(WebURLError):

  • chromium/public/WebURLRequest.h:

(WebURLRequest):

  • chromium/public/WebURLResponse.h:

(WebURLResponse):

Source/WebKit/chromium:

  • tests/WebFrameTest.cpp:

(WebKit::TestReloadDoesntRedirectWebFrameClient::cancelledError):

7:39 AM Changeset in webkit [115205] by yurys@chromium.org
  • 10 edits
    1 add in trunk/Source

Web Inspector: move HeapSnapshotLoader into a separate file
https://bugs.webkit.org/show_bug.cgi?id=84860

Extracted HeapSnapshotLoader into its own file.

Reviewed by Pavel Feldman.

Source/WebCore:

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/HeapSnapshot.js:
  • inspector/front-end/HeapSnapshotLoader.js: Added.

(WebInspector.HeapSnapshotLoader):
(WebInspector.HeapSnapshotLoader.prototype._findBalancedCurlyBrackets):
(WebInspector.HeapSnapshotLoader.prototype.finishLoading):
(WebInspector.HeapSnapshotLoader.prototype._parseUintArray):
(WebInspector.HeapSnapshotLoader.prototype._parseStringsArray):
(WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:

Source/WebKit/chromium:

  • WebKit.gyp:
7:35 AM Changeset in webkit [115204] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebaseline after r115187.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-04-25

  • platform/qt/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
7:28 AM Changeset in webkit [115203] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Not reviewed: inspector frontend tests fix.

  • inspector/front-end/ScriptsSearchScope.js:
7:16 AM Changeset in webkit [115202] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[chromium] Animations waiting for a synchronized start time should never be marked finished.
https://bugs.webkit.org/show_bug.cgi?id=84519

Patch by Ian Vollick <vollick@chromium.org> on 2012-04-25
Reviewed by James Robinson.

Source/WebCore:

Tested in CCLayerAnimationControllerTest.AnimationsWaitingForStartTimeDoNotFinishIfTheyWaitLongerToStartThanTheirDuration

  • platform/graphics/chromium/cc/CCLayerAnimationController.cpp:

(WebCore::CCLayerAnimationController::tickAnimations):

Source/WebKit/chromium:

  • tests/CCLayerAnimationControllerTest.cpp:

(WebKitTests::TEST):
(WebKitTests):

7:04 AM Changeset in webkit [115201] by pierre.rossi@gmail.com
  • 9 edits in trunk

[SVG] Nothing should be stroked when the stroke-width is 0
https://bugs.webkit.org/show_bug.cgi?id=83568

Reviewed by Nikolas Zimmermann.

Source/WebCore:

The spec states that "A zero value causes no stroke to be painted".
We should avoid calling functions that could incorrectly paint something
in that case.

Test: svg/custom/path-zero-strokewidth.svg

  • rendering/style/SVGRenderStyle.h:

(WebCore::SVGRenderStyle::hasVisibleStroke):

  • rendering/svg/RenderSVGEllipse.cpp:

(WebCore::RenderSVGEllipse::strokeShape): Check if the stroke should be visible before painting.

  • rendering/svg/RenderSVGRect.cpp:

(WebCore::RenderSVGRect::strokeShape): Ditto.

  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::strokeShape): Ditto.
(WebCore::RenderSVGShape::strokePath): Ditto.

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::paint): Dont call paintText for zero-width stroke.
(WebCore::SVGInlineTextBox::paintDecoration): Ditto.

LayoutTests:

  • platform/chromium/test_expectations.txt: mark affected tests for rebaseline.
  • platform/qt/Skipped: Unskip svg/custom/path-zero-strokewidth.svg
7:02 AM Changeset in webkit [115200] by gavinp@chromium.org
  • 9 edits
    2 copies in trunk/Source

Move WebReferrerPolicy.h from WebKit to Platform
https://bugs.webkit.org/show_bug.cgi?id=84539

Reviewed by Adam Barth.

Source/Platform:

  • Platform.gypi:
  • chromium/public/WebReferrerPolicy.h: Copied from Source/WebKit/chromium/public/WebReferrerPolicy.h.

(WebKit):

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebContextMenuData.h:
  • public/WebFrame.h:
  • public/WebReferrerPolicy.h:
  • public/WebSecurityPolicy.h:
  • public/platform/WebReferrerPolicy.h: Copied from Source/WebKit/chromium/public/WebReferrerPolicy.h.
  • src/AssertMatchingEnums.cpp:
6:59 AM Changeset in webkit [115199] by alexis.menard@openbossa.org
  • 1 edit
    2 copies in trunk/Source/WebCore

Unfortunately http://trac.webkit.org/changeset/115055 was landed using webkit-patch
land-from bug but didn't do the right thing, we lost the history.

This commit is merging back CSSStyleApplyProperty.* and their history, rename the files
to StyleBuilder and re-apply the two patches on trunk that were apply after the rename.

Rename CSSStyleSelector class to StyleResolver.
https://bugs.webkit.org/show_bug.cgi?id=84734

The name CSSStyleSelector is confusing as it conflicts a bit with
the CSS concept of selectors. One could think it's an encapsulation
of the CSS selectors but it's not, in fact this class is responsible
of finding the RenderStyle for a given element. This is the first patch
as I will later rename the files, and then rename the local variables.

Replace occurences of style selector from variables and methods names by style resolver.
https://bugs.webkit.org/show_bug.cgi?id=84765


Rename methods and variables to follow the new name StyleResolver. It requires to update the
local variables, methods parameters, and function names to match the new name and to remove
the concept of "selector" to avoid clashing with the CSS concept. The next and last patch
will be to rename CSSStyleSelector file and update the includes.

Source/WebCore:

  • css/StyleBuilder.cpp: Replaced with Source/WebCore/css/CSSStyleApplyProperty.cpp. (WebCore::ApplyPropertyExpanding::applyInheritValue): (WebCore::ApplyPropertyExpanding::applyInitialValue): (WebCore::ApplyPropertyExpanding::applyValue): (WebCore::ApplyPropertyDefaultBase::applyInheritValue): (WebCore::ApplyPropertyDefaultBase::applyInitialValue): (WebCore::ApplyPropertyDefaultBase::applyValue): (WebCore::ApplyPropertyDefault::applyValue): (WebCore::ApplyPropertyNumber::applyValue): (WebCore::ApplyPropertyStyleImage::applyValue): (WebCore::ApplyPropertyAuto::applyInheritValue): (WebCore::ApplyPropertyAuto::applyInitialValue): (WebCore::ApplyPropertyAuto::applyValue): (WebCore::ApplyPropertyClip::convertToLength): (WebCore::ApplyPropertyClip::applyInheritValue): (WebCore::ApplyPropertyClip::applyInitialValue): (WebCore::ApplyPropertyClip::applyValue): (WebCore::ApplyPropertyColor::applyInheritValue): (WebCore::ApplyPropertyColor::applyInitialValue): (WebCore::ApplyPropertyColor::applyValue): (WebCore::ApplyPropertyColor::applyColorValue): (WebCore::ApplyPropertyDirection::applyValue): (WebCore::ApplyPropertyLength::applyValue): (WebCore::ApplyPropertyString::applyValue): (WebCore::ApplyPropertyBorderRadius::applyValue): (WebCore::ApplyPropertyFillLayer::applyInheritValue): (WebCore::ApplyPropertyFillLayer::applyInitialValue): (WebCore::ApplyPropertyFillLayer::applyValue): (WebCore::ApplyPropertyComputeLength::applyValue): (WebCore::ApplyPropertyFont::applyInheritValue): (WebCore::ApplyPropertyFont::applyInitialValue): (WebCore::ApplyPropertyFont::applyValue): (WebCore::ApplyPropertyFontSize::applyInheritValue): (WebCore::ApplyPropertyFontSize::applyInitialValue): (WebCore::ApplyPropertyFontSize::applyValue): (WebCore::ApplyPropertyFontWeight::applyValue): (WebCore::ApplyPropertyFontVariantLigatures::applyInheritValue): (WebCore::ApplyPropertyFontVariantLigatures::applyInitialValue): (WebCore::ApplyPropertyFontVariantLigatures::applyValue): (WebCore::ApplyPropertyBorderImage::applyValue): (WebCore::ApplyPropertyBorderImageModifier::applyInheritValue): (WebCore::ApplyPropertyBorderImageModifier::applyInitialValue): (WebCore::ApplyPropertyBorderImageModifier::applyValue): (WebCore::ApplyPropertyBorderImageSource::applyValue): (WebCore::ApplyPropertyCounter::emptyFunction): (WebCore::ApplyPropertyCounter::applyInheritValue): (WebCore::ApplyPropertyCounter::applyValue): (WebCore::ApplyPropertyCursor::applyInheritValue): (WebCore::ApplyPropertyCursor::applyInitialValue): (WebCore::ApplyPropertyCursor::applyValue): (WebCore::ApplyPropertyTextAlign::applyValue): (WebCore::ApplyPropertyTextDecoration::applyValue): (WebCore::ApplyPropertyUnicodeBidi::applyValue): (WebCore::ApplyPropertyLineHeight::applyValue): (WebCore::ApplyPropertyPageSize::applyInheritValue): (WebCore::ApplyPropertyPageSize::applyInitialValue): (WebCore::ApplyPropertyPageSize::applyValue): (WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue): (WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue): (WebCore::ApplyPropertyTextEmphasisStyle::applyValue): (WebCore): (WebCore::ApplyPropertyAnimation::map): (WebCore::ApplyPropertyAnimation::applyInheritValue): (WebCore::ApplyPropertyAnimation::applyInitialValue): (WebCore::ApplyPropertyAnimation::applyValue): (WebCore::ApplyPropertyOutlineStyle::applyInheritValue): (WebCore::ApplyPropertyOutlineStyle::applyInitialValue): (WebCore::ApplyPropertyOutlineStyle::applyValue): (WebCore::ApplyPropertyResize::applyValue): (WebCore::ApplyPropertyVerticalAlign::applyValue): (WebCore::ApplyPropertyAspectRatio::applyInheritValue): (WebCore::ApplyPropertyAspectRatio::applyInitialValue): (WebCore::ApplyPropertyAspectRatio::applyValue): (WebCore::ApplyPropertyZoom::resetEffectiveZoom): (WebCore::ApplyPropertyZoom::applyInheritValue): (WebCore::ApplyPropertyZoom::applyInitialValue): (WebCore::ApplyPropertyZoom::applyValue): (WebCore::ApplyPropertyDisplay::isValidDisplayValue): (WebCore::ApplyPropertyDisplay::applyInheritValue): (WebCore::ApplyPropertyDisplay::applyInitialValue): (WebCore::ApplyPropertyDisplay::applyValue): (WebCore::ApplyPropertyFlex::applyInheritValue): (WebCore::ApplyPropertyFlex::applyInitialValue): (WebCore::ApplyPropertyFlex::applyValue): (WebCore::StyleBuilder::StyleBuilder):
  • css/StyleBuilder.h: Replaced with Source/WebCore/css/CSSStyleApplyProperty.h. (WebCore): (PropertyHandler): (WebCore::PropertyHandler::applyInheritValue): (WebCore::PropertyHandler::applyInitialValue): (WebCore::PropertyHandler::applyValue):
6:57 AM Changeset in webkit [115198] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

Not reviewed, fix Windows build after r115165.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateCompositingLayers): Initialize logging variable.

6:48 AM Changeset in webkit [115197] by Philippe Normand
  • 4 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update.

  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:

Rebaseline after r115187.

  • platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:

Rebaseline after r115091.

  • platform/gtk/test_expectations.txt:
6:45 AM Changeset in webkit [115196] by fmalita@chromium.org
  • 3 edits in trunk/Source/WebCore

[Coverity] Uninitialized fields in RenderSVGShape constructors
https://bugs.webkit.org/show_bug.cgi?id=84749

Reviewed by Darin Adler.

Removing unused RenderSVGShape constructor and field.

No new tests - no behavior change.

  • rendering/svg/RenderSVGShape.cpp:
  • rendering/svg/RenderSVGShape.h:

(RenderSVGShape):

6:36 AM Changeset in webkit [115195] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Not reviewed: follow up to r115194, removed debug output.

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):

6:34 AM Changeset in webkit [115194] by pfeldman@chromium.org
  • 18 edits
    1 add in trunk

Source/WebCore: Web Inspector: extract Linkifier from DebuggerPresentationModel.
https://bugs.webkit.org/show_bug.cgi?id=84855

Reviewed by Yury Semikhatsky.

There is nothing Linkifier needs from the model, extracting as a top-level class.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/ConsoleMessage.js:
  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView):

  • inspector/front-end/DebuggerPresentationModel.js:
  • inspector/front-end/EventListenersSidebarPane.js:
  • inspector/front-end/Linkifier.js: Added.

(WebInspector.LinkifierFormatter):
(WebInspector.LinkifierFormatter.prototype.formatLiveAnchor):
(WebInspector.Linkifier):
(WebInspector.Linkifier.prototype.linkifyLocation):
(WebInspector.Linkifier.prototype.linkifyRawLocation):
(WebInspector.Linkifier.prototype.reset):
(WebInspector.Linkifier.prototype._updateAnchor):
(WebInspector.Linkifier.DefaultFormatter):
(WebInspector.Linkifier.DefaultFormatter.prototype.formatLiveAnchor):

  • inspector/front-end/NetworkPanel.js:
  • inspector/front-end/ObjectPopoverHelper.js:

(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover.showObjectPopover.):
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):

  • inspector/front-end/ProfileView.js:
  • inspector/front-end/ScriptsSearchScope.js:

(WebInspector.ScriptsSearchResultsPane):

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:

Source/WebKit2: [Qt] Make the web view's url property follow the active url

https://bugs.webkit.org/show_bug.cgi?id=77554

The url property of the webview now reflects the 'active' url of the
page, which maps to either the currently loading url, in the case of
an ongoing load, or the result of a load, even when the load failed.

In practice this means that setting the url though QML, or navigating
to a new url in the page by e.g clicking, will both instantly change
the url-property of the webview to the target url. This differs from
earlier behavior, where we would update the url when the load
committed.

An optional argument is added to loadHtml(), to allow setting
the unreachable url when providing replacement content for failed
loads.

A slight change in the activeUrl() implementation is also done,
where we now favour the url of an pending API request, even when
we don't have a mainframe yet.

Finally, the location bar in the minibrowser is updated to behave
a bit more like normal browsers in terms of when the url will change
and how active focus is handled.

Patch by Tor Arne Vestbø <tor.arne.vestbo@nokia.com> on 2012-04-18
Reviewed by Simon Hausmann.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::onComponentComplete):
(QQuickWebView::reload):
(QQuickWebView::url):
(QQuickWebView::setUrl):
(QQuickWebView::loadHtml):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior.pro:
  • UIProcess/API/qt/tests/qmltests/WebView.pro:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadUrl.qml:
  • UIProcess/API/qt/tests/qmltests/common/link.html: Added.
  • UIProcess/API/qt/tests/qmltests/common/redirect.html: Added.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::activeURL):

  • UIProcess/qt/QtWebPageLoadClient.cpp:

(QtWebPageLoadClient::QtWebPageLoadClient):
(QtWebPageLoadClient::didStartProvisionalLoadForFrame):
(QtWebPageLoadClient::didReceiveServerRedirectForProvisionalLoadForFrame):
(QtWebPageLoadClient::didCommitLoadForFrame):
(QtWebPageLoadClient::dispatchLoadFailed):
(QtWebPageLoadClient::didFailProvisionalLoadWithErrorForFrame):
(QtWebPageLoadClient::didFailLoadWithErrorForFrame):

  • UIProcess/qt/QtWebPageLoadClient.h:

(QtWebPageLoadClient):

LayoutTests: Web Inspector: extract Linkifier from DebuggerPresentationModel.
https://bugs.webkit.org/show_bug.cgi?id=84855

Reviewed by Yury Semikhatsky.

  • inspector/debugger/linkifier.html:
6:32 AM Changeset in webkit [115193] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk

[Qt] Zoom back can overscroll document edges.
https://bugs.webkit.org/show_bug.cgi?id=84851

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-25
Reviewed by Kenneth Rohde Christiansen.

.:

Manual test for overscroll on zoom-back. Needs to be manual since we do not yet
have automatic testing for this type of UI-side behaviour.

  • ManualTests/qt/double-tap-overscroll.html: Added.

Source/WebKit2:

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):

6:31 AM Changeset in webkit [115192] by pfeldman@chromium.org
  • 20 edits in trunk

Web Inspector: move sourcemap-agnostic part of the debugger presentation model into the raw debugger.
https://bugs.webkit.org/show_bug.cgi?id=84852

Reviewed by Yury Semikhatsky.

Source/WebCore:

There is no need to keep that much debugging functionality in the debugger presentation model.
It all perfectly applies to the raw script debugger. Methods for selecting call frames, activating breakpoints
and paused details were moved to the WebInspector.DebuggerModel.

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype._removeBreakpointFromUI):

  • inspector/front-end/CallStackSidebarPane.js:

(WebInspector.CallStackSidebarPane):
(WebInspector.CallStackSidebarPane.prototype.update):
(WebInspector.CallStackSidebarPane.prototype.setSelectedCallFrame):
(WebInspector.CallStackSidebarPane.prototype._selectedCallFrameIndex):
(WebInspector.CallStackSidebarPane.prototype._placardSelected):
(WebInspector.CallStackSidebarPane.Placard):
(WebInspector.CallStackSidebarPane.Placard.prototype._update):

  • inspector/front-end/ConsoleView.js:
  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.prototype._globalObjectCleared):
(WebInspector.DebuggerModel.prototype._didEditScriptSource):
(WebInspector.DebuggerModel.prototype._setDebuggerPausedDetails):
(WebInspector.DebuggerModel.prototype._pausedScript):
(WebInspector.DebuggerModel.prototype._resumedScript):
(WebInspector.DebuggerModel.prototype.isPaused):
(WebInspector.DebuggerModel.prototype.setSelectedCallFrame.updateExecutionLine):
(WebInspector.DebuggerModel.prototype.setSelectedCallFrame):
(WebInspector.DebuggerModel.prototype.selectedCallFrame):
(WebInspector.DebuggerModel.prototype.evaluateOnSelectedCallFrame):
(WebInspector.DebuggerModel.prototype.getSelectedCallFrameVariables.propertiesCollected):
(WebInspector.DebuggerModel.prototype.getSelectedCallFrameVariables):
(WebInspector.DebuggerModel.prototype.setBreakpointsActive):
(WebInspector.DebuggerModel.prototype.breakpointsActive):
(WebInspector.DebuggerModel.CallFrame):
(WebInspector.DebuggerModel.CallFrame.prototype.get script):
(WebInspector.DebuggerModel.CallFrame.prototype.get type):
(WebInspector.DebuggerModel.CallFrame.prototype.get scopeChain):
(WebInspector.DebuggerModel.CallFrame.prototype.get this):
(WebInspector.DebuggerModel.CallFrame.prototype.get functionName):
(WebInspector.DebuggerModel.CallFrame.prototype.get location):
(WebInspector.DebuggerModel.CallFrame.prototype.evaluate):
(WebInspector.DebuggerModel.CallFrame.prototype.createLiveLocation):
(WebInspector.DebuggerModel.CallFrame.prototype.dispose):
(WebInspector.DebuggerPausedDetails):
(WebInspector.DebuggerPausedDetails.prototype.dispose):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.createLiveLocation):
(WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._callFrameSelected):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource.didEditScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):

  • inspector/front-end/JavaScriptSource.js:

(WebInspector.JavaScriptSource.prototype.setBreakpoint):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype._resolveObjectForPopover):

  • inspector/front-end/Script.js:

(WebInspector.Script.prototype.setSourceMapping):
(WebInspector.Script.prototype.createLiveLocation):
(WebInspector.Script.Location.prototype.update):

  • inspector/front-end/ScriptMapping.js:

(WebInspector.LiveLocation):
(WebInspector.LiveLocation.prototype.update):
(WebInspector.LiveLocation.prototype.dispose):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._consoleCommandEvaluatedInSelectedCallFrame):
(WebInspector.ScriptsPanel.prototype._debuggerPaused):
(WebInspector.ScriptsPanel.prototype._callFrameSelected):
(WebInspector.ScriptsPanel.prototype._toggleBreakpointsClicked):

  • inspector/front-end/UISourceCode.js:

LayoutTests:

  • http/tests/inspector/debugger-test.js:
  • inspector/debugger/callstack-placards-discarded.html:
  • inspector/debugger/debugger-breakpoints-not-activated-on-reload.html:
  • inspector/debugger/live-edit-expected.txt:
  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/selected-call-frame-after-formatting-source.html:
  • inspector/debugger/set-breakpoint.html:
6:29 AM Changeset in webkit [115191] by vestbo@webkit.org
  • 14 edits
    2 adds in trunk

[Qt] Make the web view's url property follow the active url

https://bugs.webkit.org/show_bug.cgi?id=77554

The url property of the webview now reflects the 'active' url of the
page, which maps to either the currently loading url, in the case of
an ongoing load, or the result of a load, even when the load failed.

In practice this means that setting the url though QML, or navigating
to a new url in the page by e.g clicking, will both instantly change
the url-property of the webview to the target url. This differs from
earlier behavior, where we would update the url when the load
committed.

An optional argument is added to loadHtml(), to allow setting
the unreachable url when providing replacement content for failed
loads.

A slight change in the activeUrl() implementation is also done,
where we now favour the url of an pending API request, even when
we don't have a mainframe yet.

Finally, the location bar in the minibrowser is updated to behave
a bit more like normal browsers in terms of when the url will change
and how active focus is handled.

Reviewed by Simon Hausmann.

6:15 AM Changeset in webkit [115190] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update
https://bugs.webkit.org/show_bug.cgi?id=84854

Mark the following tests as flaky on Linux 32-bit:

svg/batik/text/textOnPath.svg
svg/batik/text/verticalTextOnPath.svg

  • platform/chromium/test_expectations.txt:
5:32 AM Changeset in webkit [115189] by yurys@chromium.org
  • 8 edits in trunk

Web Inspector: use composite node provider for diff nodes in heap profiler
https://bugs.webkit.org/show_bug.cgi?id=84849

Inroduced HeapSnapshotDiffNodesProvider which is basically a composite provider
combining providers for added and deleted nodes. This allowed to remove custom
implementation of HeapSnapshotGridNode.prototype.populateChildren.

Source/WebCore:

Reviewed by Pavel Feldman.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNodesProvider.prototype.sort.sortByNodeField): moved index assignment to sortByComparator
so that it is done only once.
(WebInspector.HeapSnapshotNodesProvider.prototype.sort.sortByComparator):
(WebInspector.HeapSnapshotNodesProvider.prototype.sort):

  • inspector/front-end/HeapSnapshotGridNodes.js:

(WebInspector.HeapSnapshotGridNode):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren.callSerialize):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved.notify):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
(WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort):
(WebInspector.HeapSnapshotGridNode.prototype.sort):
(WebInspector.HeapSnapshotDiffNodesProvider):
(WebInspector.HeapSnapshotDiffNodesProvider.prototype.dispose):
(WebInspector.HeapSnapshotDiffNodesProvider.prototype.isEmpty):
(WebInspector.HeapSnapshotDiffNodesProvider.prototype.serializeNextItems):
(WebInspector.HeapSnapshotDiffNodesProvider.prototype.serializeNextItems.didReceiveDeletedItems):
(WebInspector.HeapSnapshotDiffNodesProvider.prototype.serializeNextItems.didReceiveAddedItems):
(WebInspector.HeapSnapshotDiffNodesProvider.prototype.sortAndRewind.afterSort):
(WebInspector.HeapSnapshotDiffNodesProvider.prototype.sortAndRewind):
(WebInspector.HeapSnapshotDiffNode):
(WebInspector.HeapSnapshotDiffNode._createProvider):
(WebInspector.HeapSnapshotDiffNode.prototype._createChildNode):

LayoutTests:

Reviewed by Pavel Feldman.

  • inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting.html:
  • inspector/profiler/heap-snapshot-comparison-show-all.html:
  • inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting.html:
5:25 AM Changeset in webkit [115188] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Gardening. Skipped a failing test.
https://bugs.webkit.org/show_bug.cgi?id=84566

Removed a test from test_expectations after r115171.

Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-04-25
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
  • platform/qt/test_expectations.txt:
4:57 AM Changeset in webkit [115187] by Nikolas Zimmermann
  • 27 edits in trunk

Refactor to/from/animatedType creation, to share more code between animators
https://bugs.webkit.org/show_bug.cgi?id=84846

Reviewed by Antti Koivisto.

Source/WebCore:

Share more code bewteen animators, doesn't change functionality yet, except for one bug in SVGAnimatedString.
SVGAnimatedString used to mutate the from/to values during animation, leading to problems in animate-element-31-t.svg.
It now needs a rebaseline, now that this bug is fixed as side-effect.

  • svg/SVGAnimateColorElement.cpp:

(WebCore::attributeValueIsCurrentColor):
(WebCore::SVGAnimateColorElement::determinePropertyValueTypes):
(WebCore):

  • svg/SVGAnimateColorElement.h:

(SVGAnimateColorElement):

  • svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::SVGAnimateElement):

  • svg/SVGAnimateElement.h:

(SVGAnimateElement):

  • svg/SVGAnimatedAngle.cpp:

(WebCore::SVGAnimatedAngleAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedBoolean.cpp:

(WebCore::SVGAnimatedBooleanAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedColor.cpp:

(WebCore::adjustForCurrentColor):
(WebCore):
(WebCore::parseColorFromString):
(WebCore::SVGAnimatedColorAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedEnumeration.cpp:

(WebCore::SVGAnimatedEnumerationAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedInteger.cpp:

(WebCore::SVGAnimatedIntegerAnimator::calculateAnimatedInteger):
(WebCore::SVGAnimatedIntegerAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedIntegerOptionalInteger.cpp:

(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedLength.cpp:

(WebCore::parseLengthFromString):
(WebCore):
(WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedLengthList.cpp:

(WebCore::parseLengthListFromString):
(WebCore):
(WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedNumber.cpp:

(WebCore::parseNumberFromString):
(WebCore):
(WebCore::SVGAnimatedNumberAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedNumberList.cpp:

(WebCore::SVGAnimatedNumberListAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedNumberOptionalNumber.cpp:

(WebCore::SVGAnimatedNumberOptionalNumberAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedPointList.cpp:

(WebCore::SVGAnimatedPointListAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedPreserveAspectRatio.cpp:

(WebCore::SVGAnimatedPreserveAspectRatioAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedRect.cpp:

(WebCore::SVGAnimatedRectAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedString.cpp:

(WebCore::parseStringFromString):
(WebCore):
(WebCore::SVGAnimatedStringAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedTransformList.cpp:

(WebCore::SVGAnimatedTransformListAnimator::calculateAnimatedValue):

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::SVGAnimationElement):
(WebCore::SVGAnimationElement::adjustForInheritance):
(WebCore):
(WebCore::inheritsFromProperty):
(WebCore::SVGAnimationElement::determinePropertyValueTypes):

  • svg/SVGAnimationElement.h:

(WebCore::SVGAnimationElement::fromPropertyValueType):
(WebCore::SVGAnimationElement::toPropertyValueType):
(SVGAnimationElement):
(WebCore::SVGAnimationElement::adjustForInheritance):
(WebCore::SVGAnimationElement::adjustFromToValues):
(WebCore::SVGAnimationElement::adjustFromToListValues):

LayoutTests:

Rebaseline one test result, which shows a progression.
(At the initial time when we capture the result, only two circles should be visible.)

  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
4:54 AM Changeset in webkit [115186] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update
https://bugs.webkit.org/show_bug.cgi?id=84847

Mark inspector/timeline/timeline-start-time.html as flaky on Windows.

  • platform/chromium/test_expectations.txt:
4:46 AM Changeset in webkit [115185] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update

Unmark the following CSS pseudo-class tests:

fast/css/empty-pseudo-class.html
fast/css/first-child-pseudo-class.html
fast/css/first-of-type-pseudo-class.html
fast/css/last-child-pseudo-class.html
fast/css/last-of-type-pseudo-class.html
fast/css/only-child-pseudo-class.html
fast/css/only-of-type-pseudo-class.html

  • platform/chromium/test_expectations.txt:
4:42 AM WebKit Team edited by qi.2.zhang@nokia.com
(diff)
4:36 AM Changeset in webkit [115184] by commit-queue@webkit.org
  • 4 edits in trunk

Webkit build fails due to missing gstreamer include file on Kubuntu 8.04
https://bugs.webkit.org/show_bug.cgi?id=81913

Patch by Philippe Normand <pnormand@igalia.com> on 2012-04-25
Reviewed by Tor Arne Vestbø.

Source/WTF:

  • WTF.pri: GStreamer build support implies GLib support, as it's

done in WebCore.pri.

Tools:

  • qmake/mkspecs/features/features.prf: Check for gstreamer-0.10

and gstreamer-plugins-base >= 0.10.30 just like the GTK port
does. 0.10.27 is unfortunately not recent enough to get the media
player working reliably.

4:17 AM Changeset in webkit [115183] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update

Remove expectation for a passing test:

fast/dom/error-to-string-stack-overflow.html

Add an expectation for a passing test:

fast/viewport/scroll-delegates-switch-on-page-with-no-composition-mode-asserts.html

  • platform/chromium/test_expectations.txt:
4:01 AM Changeset in webkit [115182] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[BlackBerry] Run tests in '/http/tests/local' with local URI
https://bugs.webkit.org/show_bug.cgi?id=84820

Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2012-04-25
Reviewed by Nikolas Zimmermann.

Currently we run all tests under folder "/http/tests/" as HTTP
tests (http://...). However in WebKit ORWT and NRWT scripts, tests in
'http/tests/local' are run with local path (like '/developer/LayoutTests
/http/tests/local/absolute-url-strip-whitespace.html').
With this patch we can keep the same behaviour as other portings.

  • DumpRenderTree/blackberry/DumpRenderTree.cpp:

(BlackBerry::WebKit::DumpRenderTree::isHTTPTest):

3:44 AM Changeset in webkit [115181] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update

Unmark these tests as failing on Windows:

fast/repaint/moving-shadow-on-container.html
fast/repaint/moving-shadow-on-path.html

  • platform/chromium/test_expectations.txt:
3:40 AM Changeset in webkit [115180] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update
https://bugs.webkit.org/show_bug.cgi?id=84813

Mark these tests as failing only on Mac and Windows:

css3/filters/custom/custom-filter-shader-cache.html
css3/filters/custom/effect-custom-combined-missing.html
css3/filters/custom/effect-custom.html

  • platform/chromium/test_expectations.txt:
3:34 AM Changeset in webkit [115179] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update

Unmark html5lib/runner.html -- changes that broke it were reverted in r115149.

  • platform/chromium/test_expectations.txt:
3:05 AM Changeset in webkit [115178] by Nikolas Zimmermann
  • 37 edits in trunk/Source/WebCore

Share single calculateFromToValues/calculateFromByValues between all SVGAnimatedTypeAnimators
https://bugs.webkit.org/show_bug.cgi?id=84832

Reviewed by Antti Koivisto.

calculateFromAndToValues / calculateFromAndByValues don't need to be spread across all SVGAnimatedTypeAnimators.
Centralize these new implementations in SVGAnimatedTypeAnimator.h. Refactored addAnimatedTypes() from constructFromAndByValues.

calculateFromAndToValues:

from = constructFromString(fromString)
to = constructFromString(toString)

calculateFromAndByValues:

from = constructFromString(fromString)
to = constructFromString(byString)
addAnimatedTypes(from, to)

Doesn't affect any tests, just refactors code.

  • svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::calculateFromAndToValues):
(WebCore::SVGAnimateElement::calculateFromAndByValues):

  • svg/SVGAnimatedAngle.cpp:

(WebCore::SVGAnimatedAngleAnimator::addAnimatedTypes):

  • svg/SVGAnimatedAngle.h:

(SVGAnimatedAngleAnimator):

  • svg/SVGAnimatedBoolean.cpp:

(WebCore::SVGAnimatedBooleanAnimator::addAnimatedTypes):

  • svg/SVGAnimatedBoolean.h:

(SVGAnimatedBooleanAnimator):

  • svg/SVGAnimatedColor.cpp:

(WebCore::SVGAnimatedColorAnimator::addAnimatedTypes):

  • svg/SVGAnimatedColor.h:

(SVGAnimatedColorAnimator):

  • svg/SVGAnimatedEnumeration.cpp:

(WebCore::SVGAnimatedEnumerationAnimator::addAnimatedTypes):

  • svg/SVGAnimatedEnumeration.h:

(SVGAnimatedEnumerationAnimator):

  • svg/SVGAnimatedInteger.cpp:

(WebCore::SVGAnimatedIntegerAnimator::addAnimatedTypes):

  • svg/SVGAnimatedInteger.h:

(SVGAnimatedIntegerAnimator):

  • svg/SVGAnimatedIntegerOptionalInteger.cpp:

(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::addAnimatedTypes):

  • svg/SVGAnimatedIntegerOptionalInteger.h:

(SVGAnimatedIntegerOptionalIntegerAnimator):

  • svg/SVGAnimatedLength.cpp:

(WebCore::SVGAnimatedLengthAnimator::addAnimatedTypes):

  • svg/SVGAnimatedLength.h:

(SVGAnimatedLengthAnimator):

  • svg/SVGAnimatedLengthList.cpp:

(WebCore::SVGAnimatedLengthListAnimator::addAnimatedTypes):

  • svg/SVGAnimatedLengthList.h:

(SVGAnimatedLengthListAnimator):

  • svg/SVGAnimatedNumber.cpp:

(WebCore::SVGAnimatedNumberAnimator::addAnimatedTypes):

  • svg/SVGAnimatedNumber.h:

(SVGAnimatedNumberAnimator):

  • svg/SVGAnimatedNumberList.cpp:

(WebCore::SVGAnimatedNumberListAnimator::addAnimatedTypes):

  • svg/SVGAnimatedNumberList.h:

(SVGAnimatedNumberListAnimator):

  • svg/SVGAnimatedNumberOptionalNumber.cpp:

(WebCore::SVGAnimatedNumberOptionalNumberAnimator::addAnimatedTypes):

  • svg/SVGAnimatedNumberOptionalNumber.h:

(SVGAnimatedNumberOptionalNumberAnimator):

  • svg/SVGAnimatedPath.cpp:

(WebCore::SVGAnimatedPathAnimator::constructFromString):
(WebCore::SVGAnimatedPathAnimator::addAnimatedTypes):

  • svg/SVGAnimatedPath.h:

(SVGAnimatedPathAnimator):

  • svg/SVGAnimatedPointList.cpp:

(WebCore::SVGAnimatedPointListAnimator::addAnimatedTypes):

  • svg/SVGAnimatedPointList.h:

(SVGAnimatedPointListAnimator):

  • svg/SVGAnimatedPreserveAspectRatio.cpp:

(WebCore::SVGAnimatedPreserveAspectRatioAnimator::addAnimatedTypes):

  • svg/SVGAnimatedPreserveAspectRatio.h:

(SVGAnimatedPreserveAspectRatioAnimator):

  • svg/SVGAnimatedRect.cpp:

(WebCore::SVGAnimatedRectAnimator::addAnimatedTypes):

  • svg/SVGAnimatedRect.h:

(SVGAnimatedRectAnimator):

  • svg/SVGAnimatedString.cpp:

(WebCore::SVGAnimatedStringAnimator::addAnimatedTypes):

  • svg/SVGAnimatedString.h:

(SVGAnimatedStringAnimator):

  • svg/SVGAnimatedTransformList.cpp:

(WebCore::SVGAnimatedTransformListAnimator::SVGAnimatedTransformListAnimator):
(WebCore::SVGAnimatedTransformListAnimator::constructFromString):
(WebCore::SVGAnimatedTransformListAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedTransformListAnimator::calculateDistance):

  • svg/SVGAnimatedTransformList.h:

(SVGAnimatedTransformListAnimator):

  • svg/SVGAnimatedTypeAnimator.h:

(SVGAnimatedTypeAnimator):
(WebCore::SVGAnimatedTypeAnimator::calculateFromAndToValues):
(WebCore::SVGAnimatedTypeAnimator::calculateFromAndByValues):
(WebCore::SVGAnimatedTypeAnimator::setContextElement):

1:18 AM Changeset in webkit [115177] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

Shrink RenderText by 8 bytes on 64-bit.
<http://webkit.org/b/84828>

Reviewed by Maciej Stachowiak.

Reorder the members so that the bits in RenderText falls into the padding at
the end of RenderObject on 64-bit. Updated the compile-time size assertion to
account for the new object structure.

This shrinks RenderText from 104 to 96 bytes on 64-bit release builds.

  • rendering/RenderText.cpp:

(SameSizeAsRenderText):
(WebCore::RenderText::RenderText):

  • rendering/RenderText.h:

(RenderText):

1:09 AM Changeset in webkit [115176] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Unskipped 28 http tests passing on all the GTK+ bots.

  • platform/gtk/test_expectations.txt:
12:56 AM Changeset in webkit [115175] by Nikolas Zimmermann
  • 33 edits in trunk/LayoutTests

2012-04-25 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Update pixel test baseline on Lion. All color space changes when painting images.
I noticed that svg/custom/focus-ring.svg is flakey, the result may be off by two 1px changes.

  • platform/mac/svg/as-background-image/svg-as-background-4-expected.png:
  • platform/mac/svg/as-border-image/svg-as-border-image-2-expected.png:
  • platform/mac/svg/carto.net/window-expected.png:
  • platform/mac/svg/custom/createImageElement-expected.png:
  • platform/mac/svg/custom/createImageElement2-expected.png:
  • platform/mac/svg/custom/deep-dynamic-updates-expected.png:
  • platform/mac/svg/custom/focus-ring-expected.png:
  • platform/mac/svg/custom/image-parent-translation-expected.png:
  • platform/mac/svg/custom/image-small-width-height-expected.png:
  • platform/mac/svg/custom/image-with-prefix-in-webarchive-expected.png:
  • platform/mac/svg/custom/image-with-transform-clip-filter-expected.png:
  • platform/mac/svg/custom/js-update-image-and-display-expected.png:
  • platform/mac/svg/custom/js-update-image-and-display2-expected.png:
  • platform/mac/svg/custom/js-update-image-and-display3-expected.png:
  • platform/mac/svg/custom/js-update-image-expected.png:
  • platform/mac/svg/custom/pointer-events-image-css-transform-expected.png:
  • platform/mac/svg/custom/pointer-events-image-expected.png:
  • platform/mac/svg/custom/text-image-opacity-expected.png:
  • platform/mac/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png:
  • platform/mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
  • platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/mac/svg/wicd/test-rightsizing-b-expected.png:
  • platform/mac/svg/zoom/page/zoom-background-images-expected.png:
12:55 AM Changeset in webkit [115174] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

No audio from MediaElementAudioSourceNode
https://bugs.webkit.org/show_bug.cgi?id=84669

MediaElementAudioSourceNode needs custom propagatesSilence() to
return false to indicate the node never propagates silence.

Patch by Raymond Toy <Raymond Toy> on 2012-04-25
Reviewed by Chris Rogers.

  • Modules/webaudio/MediaElementAudioSourceNode.h:

(MediaElementAudioSourceNode): Add propagatesSilence().

12:39 AM Changeset in webkit [115173] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][DRT] Reset DRT settings to their default values after a testcase was executed.
https://bugs.webkit.org/show_bug.cgi?id=84709

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-04-25
Reviewed by Eric Seidel.

Not all the settings that can be changed by layout testcases through a JS API were
reset in DumpRenderTreeChrome::resetDefaultsToConsistentValues().

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(defaultEditingBehavior): returns editing behavior depending on current platform.
(DumpRenderTreeChrome::resetDefaultsToConsistentValues): reset some missed DRT settings

12:11 AM Changeset in webkit [115172] by wangxianzhu@chromium.org
  • 8 edits
    2 adds in trunk

Source/WebCore: Web Inspector: Incorrect highlight position of inspected element in a scrolled page
https://bugs.webkit.org/show_bug.cgi?id=84755

Reviewed by Pavel Feldman.

Test: inspector/elements/highlight-node-scroll.html

  • inspector/DOMNodeHighlighter.cpp: Ensures the highlight position is in page coordinates.

LayoutTests: Web Inspector: REGRESSION: Incorrect highlight position of inspected element in scrolled page
https://bugs.webkit.org/show_bug.cgi?id=84755

Reviewed by Pavel Feldman.

  • http/tests/inspector/elements-test.js: Extracted common function dumpInspectorHighlightRects() into here with a small bug fixed (x and y inversed).
  • inspector/elements/highlight-node-scaled-expected.txt: Corrected the wrong inversed x and y.
  • inspector/elements/highlight-node-scaled.html: Extracted out dumpInspectorHighlightRects().
  • inspector/elements/highlight-node-scroll-expected.txt: Added. Expectation of the new test case.
  • inspector/elements/highlight-node-scroll.html: Added. The new test case.
  • inspector/elements/highlight-node.html: Extracted out dumpInspectorHighlightRects(). Expectation not changed because the x and y happened to be the same in the original expectation.
  • inspector/elements/highlight-svg-root.html: Ditto.
12:08 AM Changeset in webkit [115171] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed morning gardening after r115091.

  • platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
  • platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
12:02 AM Changeset in webkit [115170] by Csaba Osztrogonác
  • 11 edits in trunk/LayoutTests

[Qt] Unreviewed morning gardening after r115085.

  • platform/qt/Skipped: Unskip a non-existing test.
  • platform/qt/svg/custom/embedding-external-svgs-expected.txt:
  • platform/qt/svg/custom/relative-sized-use-on-symbol-expected.txt:
  • platform/qt/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
  • platform/qt/svg/custom/use-clipped-hit-expected.txt:
  • platform/qt/svg/custom/use-modify-target-symbol-expected.txt:
  • platform/qt/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
  • platform/qt/svg/custom/use-setAttribute-crash-expected.txt:
  • platform/qt/svg/custom/use-symbol-overflow-expected.txt:
  • platform/wk2/Skipped: Unskip a non-existing test.
12:00 AM Changeset in webkit [115169] by yurys@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed. Skip inspector/profiler/heap-snapshot-comparison-dom-groups-change.html
on Win and Win Cairo in addition to Mac and Qt(JSC doesn't support heap profiling and
the test doesn't make sense there).

  • platform/win/Skipped:
  • platform/wincairo/Skipped:

Apr 24, 2012:

11:52 PM Changeset in webkit [115168] by Philippe Normand
  • 18 edits in trunk/LayoutTests

Unreviewed, GTK svg rebaseline after r115085.

  • platform/gtk/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
  • platform/gtk/svg/carto.net/button-expected.txt:
  • platform/gtk/svg/carto.net/colourpicker-expected.txt:
  • platform/gtk/svg/carto.net/slider-expected.txt:
  • platform/gtk/svg/carto.net/window-expected.txt:
  • platform/gtk/svg/custom/embedding-external-svgs-expected.txt:
  • platform/gtk/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
  • platform/gtk/svg/custom/relative-sized-use-on-symbol-expected.txt:
  • platform/gtk/svg/custom/use-clipped-hit-expected.txt:
  • platform/gtk/svg/custom/use-modify-target-symbol-expected.txt:
  • platform/gtk/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
  • platform/gtk/svg/custom/use-on-g-containing-symbol-expected.txt:
  • platform/gtk/svg/custom/use-on-symbol-expected.txt:
  • platform/gtk/svg/custom/use-recalcStyle-crash-expected.txt:
  • platform/gtk/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
  • platform/gtk/svg/custom/use-setAttribute-crash-expected.txt:
  • platform/gtk/svg/custom/use-symbol-overflow-expected.txt:
11:37 PM Changeset in webkit [115167] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

2012-04-24 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Revert part of the change r115063 which commented out
real worker creation. It was commited by mistake.

  • inspector/front-end/HeapSnapshotProxy.js: (WebInspector.HeapSnapshotWorker):
10:52 PM Changeset in webkit [115166] by jonlee@apple.com
  • 3 edits in trunk/Source/WebCore

New Notification constructor do not take into account security origin permissions
https://bugs.webkit.org/show_bug.cgi?id=84825
<rdar://problem/11315405>

Reviewed by Darin Adler.

Tests requires support for notifications on Mac (see 79492).

When the task timer fires, we should check to see that the notification has permission
to show. If not, we fire the onError event.

  • notifications/Notification.cpp:

(WebCore::Notification::Notification): Since the timer may show, or call the onerror event,
we rename it from m_showTaskTimer. to m_taskTimer.
(WebCore::Notification::dispatchErrorEvent): The default constructor of ErrorEvent doesn't
create the proper event object. Create it using Event::create().
(WebCore::Notification::taskTimerFired): Check to see that we have permission first.

  • notifications/Notification.h:

(Notification):

9:30 PM Changeset in webkit [115165] by Simon Fraser
  • 12 edits in trunk/Source/WebCore

Add a logging channel and some ouput for compositing
https://bugs.webkit.org/show_bug.cgi?id=84817

Reviewed by Darin Adler.

Add a logging channel called "Compositing".

Output useful information to this channel, including
a line for each composited layer, its composited bounds,
the reason it was composited, the backing store megapixels,
and a count of total composited layers and total backing
store megapixels.

  • platform/Logging.cpp:

(WebCore):
(WebCore::getChannelFromName):

  • platform/Logging.h:

(WebCore):

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::backingStoreArea):

  • platform/graphics/GraphicsLayer.h:

(GraphicsLayer):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::backingStoreArea):
(WebCore):

  • platform/graphics/ca/GraphicsLayerCA.h:

(GraphicsLayerCA):

  • platform/mac/LoggingMac.mm:

(WebCore::initializeLoggingChannelsIfNecessary):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::nameForLayer):
(WebCore::RenderLayerBacking::backingStoreArea):
(WebCore):

  • rendering/RenderLayerBacking.h:

(RenderLayerBacking):

  • rendering/RenderLayerCompositor.cpp:

(WebCore):
(WebCore::compositingLogEnabled):
(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::logCompositingInfo):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
(WebCore::RenderLayerCompositor::updateLayerTreeGeometry):
(WebCore::RenderLayerCompositor::reasonForCompositing):

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

8:25 PM Changeset in webkit [115164] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

getMatchedCSSRules() should return null when the second argument is an unrecognized pseudo-element name
https://bugs.webkit.org/show_bug.cgi?id=83298

Patch by Kulanthaivel Palanichamy <kulanthaivel@codeaurora.org> on 2012-04-24
Reviewed by Ojan Vafai.

Source/WebCore:

I couldn't find any specification or any meaningful discussion on this API, but I
assume that it shouldn't be any different from window.getComputedStyle()
as far as the parameters are concerned.

Test: fast/dom/Window/getMatchedCSSRules-with-invalid-pseudo-elements.html

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::getMatchedCSSRules):

  • page/DOMWindow.idl:

LayoutTests:

  • fast/dom/Window/getMatchedCSSRules-with-invalid-pseudo-elements-expected.txt: Added.
  • fast/dom/Window/getMatchedCSSRules-with-invalid-pseudo-elements.html: Added.
8:02 PM Changeset in webkit [115163] by andersca@apple.com
  • 8 edits in trunk/Source/WebCore

overflow: hidden on the main frame is broken with threaded scrolling
https://bugs.webkit.org/show_bug.cgi?id=84819
<rdar://problem/10920677>

Reviewed by Darin Adler.

Pass along the horizontal and vertical scrollbar modes to the scrolling tree and use it
to determine if wheel events should be handled or not. This matches what we do for non-threaded scrolling.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::ScrollingCoordinator::setScrollParameters):

  • page/scrolling/ScrollingCoordinator.h:

(ScrollParameters):

  • page/scrolling/ScrollingTreeNode.cpp:

(WebCore::ScrollingTreeNode::ScrollingTreeNode):
(WebCore::ScrollingTreeNode::update):

  • page/scrolling/ScrollingTreeNode.h:

(WebCore::ScrollingTreeNode::canHaveScrollbars):
(ScrollingTreeNode):

  • page/scrolling/ScrollingTreeState.cpp:

(WebCore::ScrollingTreeState::ScrollingTreeState):
(WebCore::ScrollingTreeState::setHorizontalScrollbarMode):
(WebCore):
(WebCore::ScrollingTreeState::setVerticalScrollbarMode):

  • page/scrolling/ScrollingTreeState.h:

(WebCore::ScrollingTreeState::horizontalScrollbarMode):
(ScrollingTreeState):
(WebCore::ScrollingTreeState::verticalScrollbarMode):

  • page/scrolling/mac/ScrollingTreeNodeMac.mm:

(WebCore::ScrollingTreeNodeMac::handleWheelEvent):

7:58 PM Changeset in webkit [115162] by enne@google.com
  • 3 edits in trunk/Source/WebCore

[chromium] Don't call calculateRenderPasses in CCLayerTreeHostImpl::scrollBegin()
https://bugs.webkit.org/show_bug.cgi?id=84807

Reviewed by James Robinson.

Instead of calculate render passes and quads and tracking damage,
simply calculate the updated render layer list, which is what is
needed for scrolling. This prevents a willDraw/didDraw mismatch on
layers.

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
(WebCore):
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::ensureMostRecentRenderSurfaceLayerList):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

7:46 PM Changeset in webkit [115161] by danakj@chromium.org
  • 5 edits in trunk/Source

[chromium] Unbounded draws should use clip to limit their damage to opaque tracking
https://bugs.webkit.org/show_bug.cgi?id=84494

Reviewed by Adrienne Walker.

Source/WebCore:

Unit test: PlatformContextSkiaTest.UnboundedDrawsAreClipped

  • platform/graphics/skia/OpaqueRegionSkia.cpp:

(WebCore::OpaqueRegionSkia::didDrawRect):
(WebCore::OpaqueRegionSkia::didDrawPath):
(WebCore::OpaqueRegionSkia::didDrawPoints):
(WebCore::OpaqueRegionSkia::didDrawBounded):
(WebCore::OpaqueRegionSkia::didDrawUnbounded):

  • platform/graphics/skia/OpaqueRegionSkia.h:

(OpaqueRegionSkia):

Source/WebKit/chromium:

  • tests/PlatformContextSkiaTest.cpp:

(WebCore::TEST):
(WebCore):

7:11 PM Changeset in webkit [115160] by alexis.menard@openbossa.org
  • 5 edits
    6 adds in trunk

Implement createTBody for table element.
https://bugs.webkit.org/show_bug.cgi?id=84465

Reviewed by Ojan Vafai.

Source/WebCore:

Implement createTBody of table element to allow creating tbodies from JS.
It's following the specification http://dev.w3.org/html5/spec/the-table-element.html#dom-table-createtbody.

Tests: fast/table/table-create-tbody-existing-tbody.html

fast/table/table-create-tbody-multiple-tbody.html
fast/table/table-create-tbody.html

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::createTBody):
(WebCore):

  • html/HTMLTableElement.h:

(HTMLTableElement):

  • html/HTMLTableElement.idl:

LayoutTests:

Add test to cover the new createTBody method.

  • fast/table/table-create-tbody-existing-tbody-expected.txt: Added.
  • fast/table/table-create-tbody-existing-tbody.html: Added.
  • fast/table/table-create-tbody-expected.txt: Added.
  • fast/table/table-create-tbody-multiple-tbody-expected.txt: Added.
  • fast/table/table-create-tbody-multiple-tbody.html: Added.
  • fast/table/table-create-tbody.html: Added.
7:07 PM Changeset in webkit [115159] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

ScrollingCoordinator::setScrollParameters should take a single struct
https://bugs.webkit.org/show_bug.cgi?id=84816

Reviewed by Andreas Kling.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::ScrollingCoordinator::setScrollParameters):

  • page/scrolling/ScrollingCoordinator.h:

(ScrollingCoordinator):
(ScrollParameters):

  • page/scrolling/ScrollingCoordinatorNone.cpp:

(WebCore::ScrollingCoordinator::setScrollParameters):

  • page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::ScrollingCoordinator::setScrollParameters):

7:05 PM Changeset in webkit [115158] by adamk@chromium.org
  • 3 edits in trunk/Source/WebCore

Remove unused undefined() method from ScriptValue
https://bugs.webkit.org/show_bug.cgi?id=84751

Reviewed by Kentaro Hara.

  • bindings/js/ScriptValue.h:

(ScriptValue):

  • bindings/v8/ScriptValue.h:

(ScriptValue):

6:59 PM Changeset in webkit [115157] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

ASSERT failure in RenderLayer::computeRepaintRects
https://bugs.webkit.org/show_bug.cgi?id=84480

Patch by Yong Li <yoli@rim.com> on 2012-04-24
Reviewed by Simon Fraser.

Source/WebCore:

Update visibility status if necessary before updating
compositing state in RenderLayer::styleChanged().

No new tests because this is obviously right thing to do
and creating new test seems too much for this small change.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::styleChanged):

LayoutTests:

Add a layout test for it.

  • compositing/visibility/compositing-and-visibility-turned-off-together-expected.txt: Added.
  • compositing/visibility/compositing-and-visibility-turned-off-together.html: Added.
6:29 PM Changeset in webkit [115156] by mhahnenberg@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

GC Activity Callback timer should be based on how much has been allocated since the last collection
https://bugs.webkit.org/show_bug.cgi?id=84763

Reviewed by Geoffrey Garen.

The desired behavior for the GC timer is to collect at some point in the future,
regardless of how little we've allocated. A secondary goal, which is almost if not
as important, is for the timer to collect sooner if there is the potential to
collect a greater amount of memory. Conversely, as we allocate more memory we'd
like to reduce the delay to the next collection. If we're allocating quickly enough,
the timer should be preempted in favor of a normal allocation-triggered collection.
If allocation were to slow or stop, we'd like the timer to be able to opportunistically
run a collection without us having to allocate to the hard limit set by the Heap.

This type of policy can be described in terms of the amount of CPU we are willing
to dedicate to reclaim a single MB of memory. For example, we might be willing to
dedicate 1% of our CPU to reclaim 1 MB. We base our CPU usage off of the length of
the last collection, e.g. if our last collection took 1ms, we would want to wait about
100ms before running another collection to reclaim 1 MB. These constants should be
tune-able, e.g. 0.1% CPU = 1 MB vs. 1% CPU = 1 MB vs. 10% CPU = 1 MB.

  • API/JSBase.cpp: Use the new reportAbandonedObjectGraph.

(JSGarbageCollect):

  • API/JSContextRef.cpp: Ditto.
  • heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::reportAbandonedObjectGraph): Similar to reportExtraMemoryCost. Clients call
this function to notify the Heap that some unknown number of JSC objects might have just
been abandoned and are now garbage. The Heap might schedule a new collection timer based
on this notification.
(JSC):
(JSC::Heap::collect): Renamed m_lastFullGCSize to the less confusing m_sizeAfterLastCollect.

  • heap/Heap.h:

(Heap):

  • heap/MarkedAllocator.h:

(JSC::MarkedAllocator::zapFreeList): Fixed a bug in zapFreeList that failed to nullify the
current allocator's FreeList once zapping was complete.

  • runtime/GCActivityCallback.cpp: Removed didAbandonObjectGraph because it was replaced by

Heap::reportAbandonedObjectGraph.
(JSC):

  • runtime/GCActivityCallback.h:

(JSC::GCActivityCallback::willCollect):
(DefaultGCActivityCallback):

  • runtime/GCActivityCallbackCF.cpp: Refactored the GC timer code so that we now schedule the

timer based on how much we have allocated since the last collection up to a certain amount.
We use the length of the previous GC to try to keep our total cost of opportunistic timer-triggered
collections around 1% of the CPU per MB of garbage we expect to reclaim up to a maximum of 5 MB.
(DefaultGCActivityCallbackPlatformData):
(JSC):
(JSC::DefaultGCActivityCallback::~DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::commonConstructor):
(JSC::scheduleTimer):
(JSC::cancelTimer):
(JSC::DefaultGCActivityCallback::didAllocate):

6:17 PM Changeset in webkit [115155] by tkent@chromium.org
  • 9 edits in trunk

Calendar Picker: Open a calendar picker by keyboard operation
https://bugs.webkit.org/show_bug.cgi?id=84680

Reviewed by Kentaro Hara.

Source/WebCore:

  • Open a calendar picker by the down arrow key.
  • Remove stepping down/up by keyboard and wheel operations. This behavior was for text fields with spin buttons. Because the date

type doesn't have spin buttons, we should remove this behavior.

No new tests for opening a calendar picker. This behavior is not
testable by DRT yet. For removal of stepping up/down,
fast/forms/date/date-stepup-stepdown-from-renderer.html is updated.

  • html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::handleKeydownEvent):
Check shouldHaveSpinButton() before spin button key operations.
(WebCore::BaseDateAndTimeInputType::handleWheelEvent):
Check shouldHaveSpinButton() before spin button wheel operations.

  • html/BaseDateAndTimeInputType.h:

(BaseDateAndTimeInputType):
Make handleKeydownEvent() protected because a subclass overrides it.

  • html/DateInputType.cpp:

(WebCore::DateInputType::handleKeydownEvent):
Open a calendar picker by the down arrow key.

  • html/DateInputType.h:

(DateInputType): Add handleKeydownEvent() declaration.

  • html/shadow/CalendarPickerElement.h:

(CalendarPickerElement): Make openPopup() public because DateInputType calls it.

LayoutTests:

  • fast/forms/date/date-stepup-stepdown-from-renderer-expected.txt:
  • fast/forms/date/date-stepup-stepdown-from-renderer.html:

Stepping up/down by kerboard was removed. Update the test to confirm it doesn't work.

6:11 PM Changeset in webkit [115154] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84813

Suppress test image mismatch due to r115123. Rebaseline is coming soon.

  • platform/chromium/test_expectations.txt:
6:10 PM Changeset in webkit [115153] by yael.aharon@nokia.com
  • 9 edits
    12 deletes in trunk/LayoutTests

[Qt] Move notification icon download out of WebCore
https://bugs.webkit.org/show_bug.cgi?id=80700

Reviewed by Jian Li.

Remove http/tests/notifications after the code the tests were testing has been removed.

  • http/tests/notifications: Removed.
  • http/tests/notifications/icon-does-not-exist-expected.txt: Removed.
  • http/tests/notifications/icon-does-not-exist.html: Removed.
  • http/tests/notifications/icon-exists-cancel-expected.txt: Removed.
  • http/tests/notifications/icon-exists-cancel.html: Removed.
  • http/tests/notifications/icon-exists-expected.txt: Removed.
  • http/tests/notifications/icon-exists-show-alert-during-load-expected.txt: Removed.
  • http/tests/notifications/icon-exists-show-alert-during-load.html: Removed.
  • http/tests/notifications/icon-exists.html: Removed.
  • http/tests/notifications/icon-requires-auth-expected.txt: Removed.
  • http/tests/notifications/icon-requires-auth.html: Removed.
  • http/tests/notifications/resources: Removed.
  • http/tests/notifications/resources/icon-exists.png: Removed.
  • http/tests/notifications/resources/icon-requires-auth.php: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/gtk/test_expectations.txt:
  • platform/mac/Skipped:
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
6:02 PM Changeset in webkit [115152] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Perform spellcheck before handling TouchRelease event
https://bugs.webkit.org/show_bug.cgi?id=84744

After rebasing to master_35, it appears as though some code had been moved around.
Here, we were handling the TouchReleased event before calling spellcheck. This
meant that when we finally got the call to spellcheck, the fatFinger result had been
reset and the spelling markers had been removed.

In addition, based on https://bugs.webkit.org/show_bug.cgi?id=66330
I am also updating the BlackBerry specific documentMarkerContainingPoint to use
LayoutPoint instead of IntPoint.

Internally reviewed by Mike Fenton.

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-04-24
Reviewed by Antonio Gomes.

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
(BlackBerry::WebKit::TouchEventHandler::spellCheck):

  • dom/DocumentMarkerController.cpp:

(WebCore::DocumentMarkerController::markerContainingPoint):

  • dom/DocumentMarkerController.h:
5:58 PM Changeset in webkit [115151] by msaboff@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

objectProtoFuncToString creates new string every invocation
https://bugs.webkit.org/show_bug.cgi?id=84781

Reviewed by Geoffrey Garen.

Cache the results of object toString() in the attached Structure.

  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncToString):

  • runtime/Structure.cpp:

(JSC::Structure::visitChildren): visit new m_hasObjectToStringValue.

  • runtime/Structure.h: Added new member m_hasObjectToStringValue

(JSC):
(JSC::Structure::objectToStringValue):
(Structure):
(JSC::Structure::setObjectToStringValue):

5:49 PM Changeset in webkit [115150] by yael.aharon@nokia.com
  • 3 edits in trunk/LayoutTests

Unreviewed rebaseline after r115134.

  • platform/qt/fast/block/positioning/016-expected.txt:
  • platform/qt/fast/block/positioning/025-expected.txt:
5:47 PM Changeset in webkit [115149] by commit-queue@webkit.org
  • 13 edits in trunk/Source/WebCore

Unreviewed, rolling out r115099, r115102, and r115127.
http://trac.webkit.org/changeset/115099
http://trac.webkit.org/changeset/115102
http://trac.webkit.org/changeset/115127
https://bugs.webkit.org/show_bug.cgi?id=84809

Made html5lib/runner.html crash, spot fix didn't help so
rolling out so original author can do over. (Requested by
kling on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-24

  • dom/Element.cpp:

(WebCore::Element::parserSetAttributes):
(WebCore::Element::normalizeAttributes):

  • dom/Element.h:

(Element):

  • dom/ElementAttributeData.cpp:

(WebCore::AttributeVector::removeAttribute):
(WebCore):

  • dom/ElementAttributeData.h:

(AttributeVector):
(WebCore::AttributeVector::AttributeVector):
(WebCore):
(WebCore::AttributeVector::getAttributeItem):
(WebCore::AttributeVector::getAttributeItemIndex):
(WebCore::AttributeVector::insertAttribute):
(WebCore::ElementAttributeData::getAttributeItem):
(WebCore::ElementAttributeData::getAttributeItemIndex):
(WebCore::ElementAttributeData::attributeVector):
(WebCore::ElementAttributeData::clonedAttributeVector):
(ElementAttributeData):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::createHTMLElementFromSavedElement):

  • html/parser/HTMLToken.h:

(WebCore::AtomicHTMLToken::AtomicHTMLToken):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processFakeStartTag):
(WebCore::HTMLTreeBuilder::attributesForIsindexInput):

  • html/parser/HTMLTreeBuilder.h:
  • html/parser/TextDocumentParser.cpp:

(WebCore::TextDocumentParser::insertFakePreElement):

  • xml/XMLErrors.cpp:

(WebCore::createXHTMLParserErrorHeader):
(WebCore::XMLErrors::insertErrorMessageBlock):

  • xml/parser/MarkupTokenBase.h:

(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):
(WebCore::AtomicMarkupTokenBase::getAttributeItem):
(WebCore::AtomicMarkupTokenBase::attributes):
(AtomicMarkupTokenBase):
(WebCore::::initializeAttributes):

  • xml/parser/XMLToken.h:

(WebCore::AtomicXMLToken::AtomicXMLToken):

5:43 PM Changeset in webkit [115148] by jpfau@apple.com
  • 5 edits in trunk

Prevent drag and drop from setting file URLs
https://bugs.webkit.org/show_bug.cgi?id=76596

Reviewed by Enrica Casucci.

Source/WebCore:

Blacklisted file URLs from being set via dataTransfer.setData for specific types.

  • platform/mac/ClipboardMac.mm:

(WebCore::ClipboardMac::setData):

LayoutTests:

Updated tests to reflect new expectations.

  • http/tests/security/dataTransfer-set-data-file-url.html:
  • platform/mac/editing/pasteboard/dataTransfer-set-data-file-url.html:
5:33 PM Changeset in webkit [115147] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84810

Mark svg/carto.net/window.svg as fail due to changes in r115085.

  • platform/chromium/test_expectations.txt:
5:28 PM Changeset in webkit [115146] by dpranke@chromium.org
  • 2 edits in trunk/Tools

nrwt: add ASAN handling to chromium crash logs
https://bugs.webkit.org/show_bug.cgi?id=84664

Reviewed by Ojan Vafai.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort._get_crash_log):

5:25 PM Changeset in webkit [115145] by enrica@apple.com
  • 13 edits in trunk/Source

REGRESSION (r109022) Safari not placing service data on pasteboard.
https://bugs.webkit.org/show_bug.cgi?id=84766
<rdar://problem/11085756>

The support for OS X services requires that the write operations to
the pasteboard occur synchronously. This behavior was changed with r109022.
This change removes the original synchronous call to the WebProcess to perform
the pasteboard write that had become asynchronous after r109022.
It implements instead a synchronous call to retrive the content to be placed
in the pasteboard.

Reviewed by Alexey Proskuryakov.

Source/WebCore:

  • WebCore.exp.in:
  • editing/Editor.h:
  • editing/mac/EditorMac.mm:

(WebCore::Editor::writeSelectionToPasteboard):
(WebCore::Editor::stringSelectionForPasteboard): Added.
(WebCore::Editor::dataSelectionForPasteboard): Added.

  • platform/Pasteboard.h:
  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::getStringSelection): Added.
(WebCore::Pasteboard::getDataSelection): Added.
(WebCore::Pasteboard::writeSelectionForTypes):
(WebCore::Pasteboard::writeSelection):

Source/WebKit2:

  • UIProcess/API/mac/WKView.mm:

(-[WKView writeSelectionToPasteboard:types:]): Uses new methods.

  • UIProcess/WebPageProxy.h:
  • UIProcess/mac/WebPageProxyMac.mm: Removed writeSelectionToPasteboard.

(WebKit::WebPageProxy::getStringSelectionForPasteboard): Added.
(WebKit::WebPageProxy::getBufferSelectionForPasteboard): Added.

  • WebProcess/WebPage/WebPage.h: Added support for the new messages and

removed old message.

  • WebProcess/WebPage/WebPage.messages.in: Ditto.
  • WebProcess/WebPage/mac/WebPageMac.mm: Ditto.

(WebKit::WebPage::readSelectionFromPasteboard): Added.
(WebKit::WebPage::getBufferSelectionForPasteboard): Added.

5:12 PM Changeset in webkit [115144] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Patch by Thouraya ANDOLSI <thouraya.andolsi@st.com> on 2012-04-24
Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=84727.
Fix build when ENABLE_JIT_CONSTANT_BLINDING enabled.

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::or32):
(JSC::MacroAssemblerSH4::and32):
(JSC::MacroAssemblerSH4::lshift32):
(JSC::MacroAssemblerSH4::xor32):
(JSC::MacroAssemblerSH4::branchSub32):
(JSC::MacroAssemblerSH4::urshift32):

5:11 PM Changeset in webkit [115143] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84806

html5lib/runner.html fails after r115099 and r115127, mark it so.

  • platform/chromium/test_expectations.txt:
5:10 PM Changeset in webkit [115142] by dpranke@chromium.org
  • 3 edits in trunk/Tools

webkit-patch rebaseline-test is retrieving stale expectations
https://bugs.webkit.org/show_bug.cgi?id=84762

Reviewed by Ojan Vafai.

webkit-patch rebaseline-expectations is fetching files directly
from the layout-test-results directory on the buildbots, rather
than fetching them from the archive. This is problematic because
we don't clobber the directory after each run and so you can end
up fetching stale failing results.

This change temporarily changes the code to fetch the zip file
instead -- making things much slower -- until I can confer w/
abarth and ojan over the best way to fix this for the long-term.

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineTest.init):
(RebaselineTest._zip_file_set):
(RebaselineTest):
(RebaselineTest._fetch_baseline):
(RebaselineTest._rebaseline_test):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaseline.stub_rebaseline_test_command_and_tool):
(TestRebaseline.stub_rebaseline_test_command_and_tool.FakeZipFileSet):
(TestRebaseline.stub_rebaseline_test_command_and_tool.FakeZipFileSet.read):
(TestRebaseline.test_rebaseline_updates_expectations_file_noop):
(test_rebaseline_updates_expectations_file):
(test_rebaseline_test):
(test_rebaseline_and_copy_test):
(test_rebaseline_and_copy_test_no_existing_result):
(test_rebaseline_and_copy_test_with_lion_result):
(test_rebaseline_and_copy_no_overwrite_test):

5:06 PM Changeset in webkit [115141] by barraclough@apple.com
  • 14 edits in trunk/Source/JavaScriptCore

Add explicit patchableBranchPtrWithPatch/patchableJump methods
https://bugs.webkit.org/show_bug.cgi?id=84498

Reviewed by Filip Pizlo.

Don't rely on inUninterruptedSequence to distinguish which jumps we need to be able to repatch.

  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::PatchableJump::PatchableJump):
(PatchableJump):
(JSC::AbstractMacroAssembler::PatchableJump::operator Jump&):
(AbstractMacroAssembler):
(JSC::AbstractMacroAssembler::AbstractMacroAssembler):

  • Added PatchableJump type, removed inUninterruptedSequence.
  • assembler/LinkBuffer.h:

(LinkBuffer):
(JSC::LinkBuffer::locationOf):

  • Only allow the location to be taken of patchable branches
  • assembler/MacroAssembler.h:

(MacroAssembler):
(JSC::MacroAssembler::patchableBranchPtrWithPatch):
(JSC::MacroAssembler::patchableJump):
(JSC::MacroAssembler::shouldBlind):

  • Added default implementation of patchableBranchPtrWithPatch, patchableJump.
  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::MacroAssemblerARMv7):
(MacroAssemblerARMv7):
(JSC::MacroAssemblerARMv7::patchableBranchPtrWithPatch):
(JSC::MacroAssemblerARMv7::patchableJump):
(JSC::MacroAssemblerARMv7::jump):
(JSC::MacroAssemblerARMv7::makeBranch):

  • Added ARMv7 implementation of patchableBranchPtrWithPatch, patchableJump.
  • dfg/DFGCorrectableJumpPoint.h:

(DFG):
(JSC::DFG::CorrectableJumpPoint::switchToLateJump):

  • Late jumps are PatchableJumps.
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::linkOSRExits):

  • replace use of inUninterruptedSequence
  • dfg/DFGJITCompiler.h:

(JSC::DFG::PropertyAccessRecord::PropertyAccessRecord):
(PropertyAccessRecord):

  • replace use of inUninterruptedSequence
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):

  • replace use of inUninterruptedSequence
  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):

  • replace use of inUninterruptedSequence
  • jit/JIT.h:

(PropertyStubCompilationInfo):

  • replace use of inUninterruptedSequence
  • jit/JITInlineMethods.h:

(JSC::JIT::beginUninterruptedSequence):
(JSC::JIT::endUninterruptedSequence):

  • replace use of inUninterruptedSequence
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::compileGetByIdHotPath):

  • replace use of inUninterruptedSequence
  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::compileGetByIdHotPath):

  • replace use of inUninterruptedSequence
4:59 PM Changeset in webkit [115140] by crogers@google.com
  • 2 edits in trunk/LayoutTests

Fix layout test failures for Oscillator because WaveTable now normalizes to 0dBFS instead of -6dbFS
https://bugs.webkit.org/show_bug.cgi?id=84799

Reviewed by James Robinson.

This fixes failures caused by: http://trac.webkit.org/changeset/115111
We need to adjust the layout test itself to scale by 1/2 to compensate for the new WaveTable normalization.
The reason we don't change the audio .wav file baselines themselves is because audio values can potentially
clip past full scale, and we need to be able to avoid this "overshoot".

  • webaudio/resources/oscillator-testing.js:

(generateExponentialOscillatorSweep):

4:58 PM Changeset in webkit [115139] by danakj@chromium.org
  • 6 edits in trunk/Source

[chromium] Image masks are considered opaque incorrectly
https://bugs.webkit.org/show_bug.cgi?id=84275

Reviewed by Adrienne Walker.

Source/WebCore:

Match the behaviour of SkCanvas layers more closely while tracking
opaque paints. SkCanvas layers actually act as a separate device
(ie. pixels) and when the layer is popped off, the pixels are copied
down to the layer below.

While we can use the total clip to decide what pixels the the
drawing operation will affect in the final device, the blending
down through layers needs to consider each layer carefully.

In this case the image mask is drawn into a layer which is copied
down using the DestinationIn operation. Since the layer contains
non-opaque pixels, the DestinationIn copy can destroy opaque
areas in the next layer. We add OpaqueRegionSkia::FillByCopy to
distinguish the case where we are copying a block of pixels, and the
alpha values are essentially unknown.

Unit test: PlatformContextSkiaTest.trackImageMask

PlatformContextSkiaTest.trackImageMaskWithOpaqueRect

  • platform/graphics/skia/OpaqueRegionSkia.cpp:

(WebCore::paintIsOpaque):
(WebCore::OpaqueRegionSkia::applyOpaqueRegionFromLayer):
(WebCore::OpaqueRegionSkia::pushCanvasLayer):
(WebCore::OpaqueRegionSkia::popCanvasLayer):
(WebCore::OpaqueRegionSkia::didDrawRect):
(WebCore::OpaqueRegionSkia::didDrawPath):
(WebCore::OpaqueRegionSkia::didDrawPoints):
(WebCore::OpaqueRegionSkia::didDrawBounded):
(WebCore::OpaqueRegionSkia::didDraw):
(WebCore::OpaqueRegionSkia::didDrawUnbounded):
(WebCore::OpaqueRegionSkia::markRectAsOpaque):
(WebCore::OpaqueRegionSkia::markRectAsNonOpaque):
(WebCore::OpaqueRegionSkia::markAllAsNonOpaque):

  • platform/graphics/skia/OpaqueRegionSkia.h:

(OpaqueRegionSkia):
(CanvasLayerState):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::restoreLayer):

Source/WebKit/chromium:

  • tests/PlatformContextSkiaTest.cpp:

(WebCore):
(WebCore::TEST):

4:55 PM Changeset in webkit [115138] by Alexandru Chiculita
  • 6 edits
    15 adds in trunk

CSS Shaders: Repainting the FECustomFilter requires full source image
https://bugs.webkit.org/show_bug.cgi?id=76689

Source/WebCore:

Reviewed by Dean Jackson..

When a pixel of a filtered layer changes we need to update the whole bounding box of the layer and
not just the dirty rectangle. That's because the shader might change the color of any of the pixels inside the box.

Added tests where a shader is moving and rotating the contents and the actual
dirty box of the source image is not the same as the output dirty rectangle.

Tests: css3/filters/custom/filter-repaint-custom-clipped.html

css3/filters/custom/filter-repaint-custom-rotated.html
css3/filters/custom/filter-repaint-custom.html

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::FilterEffectRenderer):
(WebCore::FilterEffectRenderer::build):
(WebCore::FilterEffectRenderer::computeSourceImageRectForDirtyRect):

  • rendering/FilterEffectRenderer.h:

(FilterEffectRenderer):
(WebCore::FilterEffectRenderer::hasCustomShaderFilter):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::setFilterBackendNeedsRepaintingInRect):

LayoutTests:

Reviewed by Dean Jackson.

  • css3/filters/custom/filter-repaint-custom-clipped-expected.png: Added.
  • css3/filters/custom/filter-repaint-custom-clipped-expected.txt: Added.
  • css3/filters/custom/filter-repaint-custom-clipped.html: Added.
  • css3/filters/custom/filter-repaint-custom-expected.png: Added.
  • css3/filters/custom/filter-repaint-custom-expected.txt: Added.
  • css3/filters/custom/filter-repaint-custom-rotated-expected.png: Added.
  • css3/filters/custom/filter-repaint-custom-rotated-expected.txt: Added.
  • css3/filters/custom/filter-repaint-custom-rotated.html: Added.
  • css3/filters/custom/filter-repaint-custom.html: Added.
  • css3/filters/resources/color-add.fs: Added.
  • css3/filters/resources/vertex-horizontal-offset.vs: Added.
  • css3/filters/resources/vertex-rotate.vs: Added.
  • platform/chromium-mac/css3/filters/custom/filter-repaint-custom-clipped-expected.png: Added.
  • platform/chromium-mac/css3/filters/custom/filter-repaint-custom-expected.png: Added.
  • platform/chromium-mac/css3/filters/custom/filter-repaint-custom-rotated-expected.png: Added.
  • platform/chromium/test_expectations.txt:
4:52 PM Changeset in webkit [115137] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84802

New test added in r115096 is failing on Chromium, mark it so.

  • platform/chromium/test_expectations.txt:
4:51 PM Changeset in webkit [115136] by alexis.menard@openbossa.org
  • 68 edits in trunk/Source

Replace occurences of style selector from variables and methods names by style resolver.
https://bugs.webkit.org/show_bug.cgi?id=84765

Reviewed by Andreas Kling.

Rename methods and variables to follow the new name StyleResolver. It requires to update the
local variables, methods parameters, and function names to match the new name and to remove
the concept of "selector" to avoid clashing with the CSS concept. The next and last patch
will be to rename CSSStyleSelector file and update the includes.

Source/WebCore:

No new tests : just renaming the variables and method names. No behavior changes expected.

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::dispatchInvalidationCallbacks):

  • css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::addStops):

  • css/CSSPageRule.cpp:

(WebCore::CSSPageRule::setSelectorText):

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::setSelectorText):

  • css/CSSStyleSheet.cpp:

(WebCore::StyleSheetInternal::styleSheetChanged):

  • css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::eval):

  • css/MediaQueryMatcher.cpp:

(WebCore::MediaQueryMatcher::prepareEvaluator):
(WebCore::MediaQueryMatcher::styleResolverChanged):

  • css/MediaQueryMatcher.h:

(MediaQueryMatcher):

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::StyleRuleCSSStyleDeclaration::setNeedsStyleRecalc):

  • css/StyleBuilder.cpp:

(WebCore::ApplyPropertyExpanding::applyInheritValue):
(WebCore::ApplyPropertyExpanding::applyInitialValue):
(WebCore::ApplyPropertyExpanding::applyValue):
(WebCore::ApplyPropertyDefaultBase::applyInheritValue):
(WebCore::ApplyPropertyDefaultBase::applyInitialValue):
(WebCore::ApplyPropertyDefault::applyValue):
(WebCore::ApplyPropertyNumber::applyValue):
(WebCore::ApplyPropertyStyleImage::applyValue):
(WebCore::ApplyPropertyAuto::applyInheritValue):
(WebCore::ApplyPropertyAuto::applyInitialValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::convertToLength):
(WebCore::ApplyPropertyClip::applyInheritValue):
(WebCore::ApplyPropertyClip::applyInitialValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyColor::applyInheritValue):
(WebCore::ApplyPropertyColor::applyInitialValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyColor::applyColorValue):
(WebCore::ApplyPropertyDirection::applyValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyFillLayer::applyInheritValue):
(WebCore::ApplyPropertyFillLayer::applyInitialValue):
(WebCore::ApplyPropertyFillLayer::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFont::applyInheritValue):
(WebCore::ApplyPropertyFont::applyInitialValue):
(WebCore::ApplyPropertyFont::applyValue):
(WebCore::ApplyPropertyFontSize::applyInheritValue):
(WebCore::ApplyPropertyFontSize::applyInitialValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyInheritValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyInitialValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyBorderImage::applyValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInheritValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInitialValue):
(WebCore::ApplyPropertyBorderImageModifier::applyValue):
(WebCore::ApplyPropertyBorderImageSource::applyValue):
(WebCore::ApplyPropertyCounter::applyInheritValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCursor::applyInheritValue):
(WebCore::ApplyPropertyCursor::applyInitialValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyTextAlign::applyValue):
(WebCore::ApplyPropertyTextDecoration::applyValue):
(WebCore::ApplyPropertyUnicodeBidi::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyAnimation::map):
(WebCore::ApplyPropertyAnimation::applyInheritValue):
(WebCore::ApplyPropertyAnimation::applyInitialValue):
(WebCore::ApplyPropertyAnimation::applyValue):
(WebCore::ApplyPropertyOutlineStyle::applyInheritValue):
(WebCore::ApplyPropertyOutlineStyle::applyInitialValue):
(WebCore::ApplyPropertyOutlineStyle::applyValue):
(WebCore::ApplyPropertyResize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyAspectRatio::applyInheritValue):
(WebCore::ApplyPropertyAspectRatio::applyInitialValue):
(WebCore::ApplyPropertyAspectRatio::applyValue):
(WebCore::ApplyPropertyZoom::resetEffectiveZoom):
(WebCore::ApplyPropertyZoom::applyInheritValue):
(WebCore::ApplyPropertyZoom::applyInitialValue):
(WebCore::ApplyPropertyZoom::applyValue):
(WebCore::ApplyPropertyDisplay::isValidDisplayValue):
(WebCore::ApplyPropertyDisplay::applyInheritValue):
(WebCore::ApplyPropertyDisplay::applyInitialValue):
(WebCore::ApplyPropertyDisplay::applyValue):
(WebCore::ApplyPropertyFlex::applyInheritValue):
(WebCore::ApplyPropertyFlex::applyInitialValue):
(WebCore::ApplyPropertyFlex::applyValue):

  • css/StyleBuilder.h:

(WebCore::PropertyHandler::applyInheritValue):
(WebCore::PropertyHandler::applyInitialValue):
(WebCore::PropertyHandler::applyValue):

  • css/StyleMedia.cpp:

(WebCore::StyleMedia::matchMedium):

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::setDocType):
(WebCore::Document::childrenChanged):
(WebCore::Document::setContentLanguage):
(WebCore::Document::recalcStyle):
(WebCore::Document::updateLayoutIgnorePendingStylesheets):
(WebCore::Document::styleForElementIgnoringPendingStylesheets):
(WebCore::Document::styleForPage):
(WebCore::Document::combineCSSFeatureFlags):
(WebCore::Document::resetCSSFeatureFlags):
(WebCore::Document::createStyleResolver):
(WebCore::Document::clearStyleResolver):
(WebCore::Document::clearPageUserSheet):
(WebCore::Document::updatePageUserSheet):
(WebCore::Document::clearPageGroupUserSheets):
(WebCore::Document::updatePageGroupUserSheets):
(WebCore::Document::addUserSheet):
(WebCore::Document::processHttpEquiv):
(WebCore::Document::setSelectedStylesheetSet):
(WebCore::Document::removePendingSheet):
(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::styleResolverChanged):
(WebCore::Document::analyzeStylesheetChange):
(WebCore::Document::updateActiveStylesheets):

  • dom/Document.h:

(WebCore::Document::styleResolverIfExists):
(WebCore::Document::styleResolver):
(Document):

  • dom/Element.cpp:

(WebCore::StyleResolverParentPusher::StyleResolverParentPusher):
(WebCore::StyleResolverParentPusher::push):
(WebCore::StyleResolverParentPusher::~StyleResolverParentPusher):
(StyleResolverParentPusher):
(WebCore::Element::attributeChanged):
(WebCore::Element::attach):
(WebCore::Element::styleForRenderer):
(WebCore::Element::recalcStyle):
(WebCore::Element::beginParsingChildren):
(WebCore::Element::finishParsingChildren):

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::removedFrom):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::attach):

  • dom/ShadowTree.cpp:

(WebCore::ShadowTree::recalcShadowTreeStyle):

  • dom/StyleElement.cpp:

(WebCore::StyleElement::removedFromDocument):

  • editing/EditingStyle.cpp:

(WebCore::styleFromMatchedRulesForElement):

  • history/CachedPage.cpp:

(WebCore::CachedPage::restore):

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::styleResolver):

  • html/HTMLCanvasElement.h:

(HTMLCanvasElement):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::setDisabledState):
(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::removedFrom):
(WebCore::HTMLLinkElement::removePendingSheet):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::registerWithScopingNode):
(WebCore::HTMLStyleElement::unregisterWithScopingNode):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setFont):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::recalcStyleForPseudoStateIfNeeded):
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::buildArrayForRuleList):
(WebCore::InspectorCSSAgent::clearPseudoState):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::updateViewMetrics):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::getMatchedCSSRules):

  • page/Frame.cpp:

(WebCore::Frame::setPrinting):

  • page/FrameView.cpp:

(WebCore::FrameView::layout):

  • page/Page.cpp:

(WebCore::Page::setViewMode):
(WebCore::Page::setNeedsRecalcStyleInAllFrames):
(WebCore::Page::allVisitedStateChanged):
(WebCore::Page::visitedStateChanged):

  • page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::KeyframeAnimation):

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::adjustSliderTrackStyle):
(WebCore::RenderThemeEfl::adjustSliderThumbStyle):
(WebCore::RenderThemeEfl::adjustCheckboxStyle):
(WebCore::RenderThemeEfl::adjustRadioStyle):
(WebCore::RenderThemeEfl::adjustButtonStyle):
(WebCore::RenderThemeEfl::adjustMenuListStyle):
(WebCore::RenderThemeEfl::adjustMenuListButtonStyle):
(WebCore::RenderThemeEfl::adjustTextFieldStyle):
(WebCore::RenderThemeEfl::adjustTextAreaStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldStyle):
(WebCore::RenderThemeEfl::adjustProgressBarStyle):

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::adjustButtonStyle):
(WebCore::RenderThemeGtk::adjustMenuListStyle):
(WebCore::RenderThemeGtk::adjustMenuListButtonStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldStyle):
(WebCore::RenderThemeGtk::adjustSliderThumbStyle):

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::adjustSliderThumbStyle):
(WebCore::RenderThemeQt::adjustSearchFieldStyle):
(WebCore::RenderThemeQt::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeQt::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQt::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeQt::adjustInnerSpinButtonStyle):

  • platform/qt/RenderThemeQtMobile.cpp:

(WebCore::RenderThemeQtMobile::adjustButtonStyle):
(WebCore::RenderThemeQtMobile::adjustMenuListStyle):

  • platform/wx/RenderThemeWx.cpp:

(WebCore::RenderThemeWx::adjustButtonStyle):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::paintItemForeground):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::fontSelector):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::getUncachedPseudoStyle):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::styleDidChange):
(WebCore::RenderRegion::computeStyleInRegion):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::fontSelector):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::adjustInputFieldSpeechButtonStyle):

  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::adjustMenuListStyle):
(WebCore::RenderThemeChromiumSkia::adjustMenuListButtonStyle):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::adjustMenuListStyle):
(WebCore::RenderThemeMac::adjustSliderThumbStyle):
(WebCore::RenderThemeMac::adjustSearchFieldStyle):

  • rendering/RenderThemeSafari.cpp:

(WebCore::RenderThemeSafari::setFontFromControlSize):
(WebCore::RenderThemeSafari::adjustButtonStyle):
(WebCore::RenderThemeSafari::adjustMenuListStyle):
(WebCore::RenderThemeSafari::adjustMenuListButtonStyle):
(WebCore::RenderThemeSafari::adjustSliderThumbStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldResultsButtonStyle):

  • rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeWin::adjustMenuListStyle):
(WebCore::RenderThemeWin::adjustMenuListButtonStyle):
(WebCore::RenderThemeWin::adjustSearchFieldStyle):
(WebCore::RenderThemeWin::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeWin::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeWin::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeWin::adjustSearchFieldResultsButtonStyle):

  • rendering/RenderThemeWinCE.cpp:

(WebCore::RenderThemeWinCE::adjustMenuListStyle):
(WebCore::RenderThemeWinCE::adjustSearchFieldStyle):
(WebCore::RenderThemeWinCE::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeWinCE::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeWinCE::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeWinCE::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeWinCE::adjustMenuListButtonStyle):

  • rendering/style/StyleGeneratedImage.cpp:

(WebCore::StyleGeneratedImage::image):

  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::computeNewScaledFontForStyle):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::customStyleForRenderer):

  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::rebuildFontFace):
(WebCore::SVGFontFaceElement::removedFrom):

  • xml/XMLTreeViewer.cpp:

(WebCore::XMLTreeViewer::transformDocumentToTreeView):

  • xml/parser/XMLDocumentParser.cpp:

(WebCore::XMLDocumentParser::end):

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::doEnd):

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::doEnd):

  • WebCore.exp.in:

Source/WebKit/chromium:

  • src/AutofillPopupMenuClient.cpp:

(WebKit::AutofillPopupMenuClient::fontSelector):
(WebKit::AutofillPopupMenuClient::initialize):

  • src/WebDevToolsAgentImpl.cpp:

(WebKit::DeviceMetricsSupport::autoZoomPageToFitWidth):
(WebKit::DeviceMetricsSupport::applySizeOverrideInternal):

Source/WebKit/mac:

  • WebView/WebHTMLView.mm:

(-[WebHTMLView reapplyStyles]):
(-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):

Source/WebKit/qt:

  • Api/qwebelement.cpp:

(QWebElement::styleProperty):

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setMediaType):

  • WebCoreSupport/RenderThemeQStyle.cpp:

(WebCore::RenderThemeQStyle::adjustButtonStyle):
(WebCore::RenderThemeQStyle::adjustTextAreaStyle):
(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
(WebCore::RenderThemeQStyle::adjustSliderThumbStyle):
(WebCore::RenderThemeQStyle::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQStyle::adjustSearchFieldResultsDecorationStyle):

4:45 PM Changeset in webkit [115135] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] setUserViewportArguments not always respected.
https://bugs.webkit.org/show_bug.cgi?id=84738

Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-04-24
Reviewed by Antonio Gomes.

Remove the unnecessary logic in
WebPagePrivate::recomputeVirtualViewportFromViewportArguments().
Instead it is much simpler to just set the m_viewportArguments to
m_userViewportArguments on LoadCommitted. If there is a viewport
tag in the content, m_viewportArguments will be replaced with it
as usual during normal page load.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):

4:43 PM Changeset in webkit [115134] by yael.aharon@nokia.com
  • 3 edits
    1 add in trunk

Fixed background is scrolling in http://www.nieuwecode.nl/ in Qt webkit2
https://bugs.webkit.org/show_bug.cgi?id=83980

Reviewed by Simon Fraser.

.:

  • ManualTests/fixed-position-no-z-index.html: Added.

Source/WebCore:

When a fixed position element does not have z-index explicitly specified, it does not create a
stacking context. This results in fixed elements scrolling with the content layer.
This patch creates a stacking context for fixed positioned elements for the Qt port, by enabling
the flag ENABLE_FIXED_POSITION_CREATES_STACKING_CONTEXT.
Added a manual test because this patch takes effect only during scrolling.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

4:43 PM Changeset in webkit [115133] by ojan@chromium.org
  • 2 edits
    1 add in trunk/Tools

Improve code for embedding flakiness dashboard as an iframe
https://bugs.webkit.org/show_bug.cgi?id=84782

Reviewed by Dirk Pranke.

-Include the horizontal scrollbar height in the measured height of the page.
-Post a message everytime the height changes instead of in response to a queryContentHeight message.
This way, the embedder doesn't need to poll.

No new tests. This is hard to test because it involves postMessage and iframes.
Once we switch the dashboard tests over to qunit, we should be able to write an
asyncTest for this.

  • TestResultServer/static-dashboards/flakiness_dashboard.js:

(generatePage):
(appendHTML):
(appendExpectations):
(postHeightChangedMessage):
(generatePageForIndividualTests.if):
(generatePageForIndividualTests):

  • TestResultServer/static-dashboards/flakiness_dashboard_embedded.html: Added.
4:41 PM Changeset in webkit [115132] by benjamin@webkit.org
  • 5 edits in trunk/Source

Generalize the single character optimization of r114072
https://bugs.webkit.org/show_bug.cgi?id=83961

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-24
Reviewed by Eric Seidel.

Source/JavaScriptCore:

Use the regular String::find(StringImpl*) in all cases now that it has been made faster.

  • runtime/StringPrototype.cpp:

(JSC::replaceUsingStringSearch):

Source/WTF:

This patch makes some improvment over String::find() in the case of lookup for a single
character.

The two function find(UChar|LChar) are replaced by a template.

The case of searching a UChar in a 8bit string has a shortcut if the UChar cannot
possibly match any character in the range of the type LChar.

The slow case StringImpl::find(StringImpl*) is modified to
-Do not allocate in the fast case if only one string is 8bit.
-Use the shortcut for searching UChar in LChar.

This speed up the function by about 7% when avoiding string conversion.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::find):

  • wtf/text/StringImpl.h:

(StringImpl):
(WTF):
(WTF::find):
(WTF::StringImpl::find):

4:33 PM Changeset in webkit [115131] by ojan@chromium.org
  • 4 edits in trunk/Tools

Replace garden-o-matic accordion UI with a panel UI
https://bugs.webkit.org/show_bug.cgi?id=84081

Reviewed by Dimitri Glazkov.

This is a nicer UI to work with and makes it easier to embed the flakiness dashboard,
since we can reuse the same iframe without moving it in the DOM.

Also, excise unnecessary jquery-isms.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
4:16 PM Changeset in webkit [115130] by rwlbuis@webkit.org
  • 2 edits
    1 add
    12 deletes in trunk/LayoutTests

REGRESSION (r115083-r115087): 6 tests failing on Lion Release (WebKit2 Tests)
https://bugs.webkit.org/show_bug.cgi?id=84783

Reviewed by Dirk Schulze.

Fix struct-use-09-b.svg missing test result by converting to a reftest.

  • platform/chromium-linux/svg/custom/struct-use-09-b-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/custom/struct-use-09-b-expected.png: Removed.
  • platform/chromium-mac/svg/custom/struct-use-09-b-expected.png: Removed.
  • platform/chromium-mac/svg/custom/struct-use-09-b-expected.txt: Removed.
  • platform/chromium-win/svg/custom/struct-use-09-b-expected.png: Removed.
  • platform/chromium-win/svg/custom/struct-use-09-b-expected.txt: Removed.
  • platform/gtk/svg/custom/struct-use-09-b-expected.png: Removed.
  • platform/gtk/svg/custom/struct-use-09-b-expected.txt: Removed.
  • platform/mac-leopard/svg/custom/struct-use-09-b-expected.png: Removed.
  • platform/mac/svg/custom/struct-use-09-b-expected.png: Removed.
  • platform/qt/svg/custom/struct-use-09-b-expected.png: Removed.
  • platform/qt/svg/custom/struct-use-09-b-expected.txt: Removed.
  • svg/custom/struct-use-09-b-expected.svg:
  • svg/custom/struct-use-09-b.svg:
4:08 PM Changeset in webkit [115129] by hclam@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

[chromium] Unreviewd test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84790

Adding expectations for new tests added in r115091.

  • platform/chromium-mac/fast/css/table-rules-attribute-groups-with-frame-expected.png: Added.
  • platform/chromium-mac/fast/css/table-rules-attribute-with-frame1-expected.png: Added.
  • platform/chromium-mac/fast/css/table-rules-attribute-with-frame2-expected.png: Added.
4:00 PM Changeset in webkit [115128] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix Windows build.

  • WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.h:

(~InjectedBundleDOMWindowExtension): VS doesn't like OVERRIDE on d'tor's

3:55 PM Changeset in webkit [115127] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r115099): html5lib/runner.html crashes.
<http://webkit.org/b/84791>

Reviewed by Anders Carlsson.

Unbreak and simplify the code that filters attributes on isindex elements.
It's perfectly safe to remove elements from a Vector while iterating over it.

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::attributesForIsindexInput):

3:55 PM Changeset in webkit [115126] by peter@chromium.org
  • 2 edits in trunk/Tools

[Chromium] DumpRenderTree should depend on base.gyp:test_support_base
https://bugs.webkit.org/show_bug.cgi?id=84729

Reviewed by Dirk Pranke.

This dependency is necessary for Android since it'll soon be
calling InitAndroidOSPathStub() in it's platform support. The
TestWebKitAPI and webkit_unit_tests already have this dependency.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3:50 PM Changeset in webkit [115125] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Extra display logic for the media control panel element
https://bugs.webkit.org/show_bug.cgi?id=82476

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-04-24
Reviewed by Eric Carlson.

Source/WebCore:

This patch fixes a bug which caused the controls to be displayed
when they should remain hidden. Added an extra variable to the
panel elements which properly keeps the state of the panel (visible or not).

Test: media/video-controls-toggling.html

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::MediaControlPanelElement): Added the
variable m_isDisplayed to hold the state whether the panel is visible or not.
(WebCore::MediaControlPanelElement::makeOpaque): Showing the panel only if it
is visible.
(WebCore::MediaControlPanelElement::makeTransparent): Enabled the transition
timer which sets the display:none property on the controls.
(WebCore::MediaControlPanelElement::setIsDisplayed): Setter for the state variable.
(WebCore):

  • html/shadow/MediaControlElements.h:

(MediaControlPanelElement):

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::show): Updated the panel visibility state.
(WebCore::MediaControlRootElement::hide): Updated the panel visibility state.

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::show): Updated the panel visibility state.
(WebCore::MediaControlRootElementChromium::hide): Updated the panel visibility state.

LayoutTests:

Added test to ensure that controls are not displayed when
the controls attribute is not set.

  • media/video-controls-toggling-expected.txt: Added.
  • media/video-controls-toggling.html: Added.
3:46 PM Changeset in webkit [115124] by ojan@chromium.org
  • 4 edits in trunk/Tools

Replace vague informative statement with the list of builders where the test isn't listed
https://bugs.webkit.org/show_bug.cgi?id=84779

Reviewed by Dirk Pranke.

This is more informative and more likely to be noticed. With the old UI, people never
read the line and if they did, they didn't really understand what it meant. Hopefully
have the list of builders will be more clear.

  • TestResultServer/static-dashboards/flakiness_dashboard.js:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3:44 PM Changeset in webkit [115123] by Alexandru Chiculita
  • 14 edits
    1 delete in trunk

CSS Shaders: Custom filters painting is broken
https://bugs.webkit.org/show_bug.cgi?id=82803

Reviewed by Kenneth Russell.

Source/WebCore:

In this patch I moved CSS Shaders file loading notifications from FilterEffectRenderer to the new RenderLayerFilterInfo.
That's because FilterEffectRenderer is only used when running the filters in the software pipeline
and has a very short lifetime. Due to a recent change FilterEffectRenderer actually
gets deleted if the shader is not loaded, so it doesn't live that much to be notified when the shader
was actually loaded.

Also removed the FilterEffectObserver, that was only used to notify the RenderLayer about the loaded shader.

No new tests. This is making existing CSS Shaders tests pass again.
Cannot un-skip on Mac for now because the feature is compile time disabled.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/filters/CustomFilterOperation.h:

(WebCore::CustomFilterOperation::affectsOpacity):
(WebCore::CustomFilterOperation::movesPixels):

  • platform/graphics/filters/FilterOperations.cpp:

(WebCore):
(WebCore::FilterOperations::hasCustomFilter):

  • platform/graphics/filters/FilterOperations.h:

(FilterOperations):

  • platform/graphics/texmap/TextureMapperImageBuffer.cpp:

(WebCore::BitmapTextureImageBuffer::applyFilters):

  • rendering/FilterEffectObserver.h: Removed.
  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::FilterEffectRenderer):
(WebCore::FilterEffectRenderer::~FilterEffectRenderer):
(WebCore::FilterEffectRenderer::build):

  • rendering/FilterEffectRenderer.h:

(WebCore):
(WebCore::FilterEffectRenderer::create):
(FilterEffectRenderer):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateOrRemoveFilterEffect):

  • rendering/RenderLayer.h:
  • rendering/RenderLayerFilterInfo.cpp:

(WebCore::RenderLayerFilterInfo::~RenderLayerFilterInfo):
(WebCore::RenderLayerFilterInfo::notifyCustomFilterProgramLoaded):
(WebCore):
(WebCore::RenderLayerFilterInfo::updateCustomFilterClients):
(WebCore::RenderLayerFilterInfo::removeCustomFilterClients):

  • rendering/RenderLayerFilterInfo.h:

(WebCore):
(RenderLayerFilterInfo):

LayoutTests:

  • platform/chromium/test_expectations.txt: Un-skipping related tests on Chromium.
3:30 PM Changeset in webkit [115122] by rwlbuis@webkit.org
  • 1 edit
    1 add
    14 deletes in trunk/LayoutTests

[SVG] convert use-css-events.svg to be a reftest
https://bugs.webkit.org/show_bug.cgi?id=84788

Reviewed by Andreas Kling.

  • platform/chromium-linux/svg/custom/use-css-events-expected.png: Removed.
  • platform/chromium-mac/svg/custom/use-css-events-expected.png: Removed.
  • platform/chromium-mac/svg/custom/use-css-events-expected.txt: Removed.
  • platform/chromium-win/svg/custom/use-css-events-expected.png: Removed.
  • platform/chromium-win/svg/custom/use-css-events-expected.txt: Removed.
  • platform/gtk/svg/custom/use-css-events-expected.png: Removed.
  • platform/gtk/svg/custom/use-css-events-expected.txt: Removed.
  • platform/mac-leopard/svg/custom/use-css-events-expected.png: Removed.
  • platform/mac-snowleopard/svg/custom/use-css-events-expected.png: Removed.
  • platform/mac/svg/custom/use-css-events-expected.png: Removed.
  • platform/mac/svg/custom/use-css-events-expected.txt: Removed.
  • platform/qt/svg/custom/use-css-events-expected.png: Removed.
  • platform/qt/svg/custom/use-css-events-expected.txt: Removed.
  • platform/win/svg/custom/use-css-events-expected.txt: Removed.
  • svg/custom/use-css-events-expected.svg: Added.
3:20 PM Changeset in webkit [115121] by eae@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/rendering/LayoutTypes.h

Fix clampToLayoutUnit on branch.

3:14 PM Changeset in webkit [115120] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

Another build fix.

Not reviewed.

  • css/MediaList.cpp:

(WebCore::MediaQuerySet::MediaQuerySet):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::StylePropertySet):

3:12 PM Changeset in webkit [115119] by rwlbuis@webkit.org
  • 4 edits in trunk/LayoutTests

REGRESSION (r115083-r115087): 6 tests failing on Lion Release (WebKit2 Tests)
https://bugs.webkit.org/show_bug.cgi?id=84783

Reviewed by Andreas Kling.

This regression was caused because the test results from an old patch were
blindly taken, rebaseline these against trunk.

  • svg/custom/use-in-symbol-with-offset-expected.txt:
  • svg/custom/use-transfer-width-height-properties-to-svg2-expected.txt:
  • svg/custom/use-transfer-width-height-properties-to-symbol-expected.txt:
3:06 PM Changeset in webkit [115118] by hclam@chromium.org
  • 7 edits
    2 moves
    2 adds
    6 deletes in trunk/LayoutTests

[chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84785

Updating test expectation changes due to r115085.

  • platform/chromium-linux-x86/svg/custom/use-setAttribute-crash-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/use-setAttribute-crash-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/custom/use-setAttribute-crash-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/use-setAttribute-crash-expected.txt: Removed.
  • platform/chromium-mac/svg/custom/struct-use-09-b-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/use-setAttribute-crash-expected.txt: Removed.
  • platform/chromium-win-xp/svg/custom/use-setAttribute-crash-expected.txt: Removed.
  • platform/chromium-win/svg/custom/embedding-external-svgs-expected.txt:
  • platform/chromium-win/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
  • platform/chromium-win/svg/custom/relative-sized-use-on-symbol-expected.txt:
  • platform/chromium-win/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
  • platform/chromium-win/svg/custom/struct-use-09-b-expected.txt:
  • platform/chromium-win/svg/custom/use-setAttribute-crash-expected.txt:
  • platform/chromium/svg/custom/use-in-symbol-with-offset-expected.txt: Added.
  • platform/chromium/svg/custom/use-transfer-width-height-properties-to-svg2-expected.txt: Renamed from LayoutTests/platform/qt/svg/custom/use-transfer-width-height-properties-to-svg2-expected.txt.
  • platform/chromium/svg/custom/use-transfer-width-height-properties-to-symbol-expected.txt: Renamed from LayoutTests/platform/qt/svg/custom/use-transfer-width-height-properties-to-symbol-expected.txt.
3:03 PM Changeset in webkit [115117] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Try to fix Qt build.

Not reviewed.

  • css/StyleRule.h:

(WebCore::StyleRuleBase::StyleRuleBase):

2:58 PM Changeset in webkit [115116] by tkent@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Implement WebCore::dateFormat{DayInMonth,Month,Year}Text()
https://bugs.webkit.org/show_bug.cgi?id=84683

Reviewed by Dimitri Glazkov.

  • public/platform/WebLocalizedString.h:

Add DateFormat{DayInMonth,Month,Year}Label

  • src/LocalizedStrings.cpp:

(WebCore::dateFormatYearText): Implemented.
(WebCore::dateFormatMonthText): ditto.
(WebCore::dateFormatDayInMonthText): ditto.

2:56 PM Changeset in webkit [115115] by Antti Koivisto
  • 15 edits in trunk/Source/WebCore

Implement StyleRule copying
https://bugs.webkit.org/show_bug.cgi?id=84752

Reviewed by Andreas Kling.

We'll need this for copy-on-write when style sheet data is shared between documents.

Implement copy() and copy constructor for style rules their children as needed.

The code is not yet used.

  • css/CSSSelectorList.cpp:

(WebCore::CSSSelectorList::CSSSelectorList):
(WebCore):

  • css/CSSSelectorList.h:

(CSSSelectorList):

  • css/MediaList.h:

(WebCore::MediaQuerySet::copy):
(MediaQuerySet):

  • css/MediaQuery.cpp:

(WebCore::MediaQuery::MediaQuery):
(WebCore):

  • css/MediaQuery.h:

(MediaQuery):
(WebCore::MediaQuery::copy):

  • css/MediaQueryExp.h:

(WebCore::MediaQueryExp::copy):
(MediaQueryExp):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::StylePropertySet):
(WebCore):
(WebCore::StylePropertySet::copy):

  • css/StylePropertySet.h:


Make this copy parse mode too. As a result ElementAttributeData no longer needs to set it explicitly after copying.

(StylePropertySet):

  • css/StyleRule.cpp:

(WebCore::StyleRuleBase::copy):
(WebCore):
(WebCore::StyleRule::StyleRule):
(WebCore::StyleRulePage::StyleRulePage):
(WebCore::StyleRuleFontFace::StyleRuleFontFace):
(WebCore::StyleRuleBlock::StyleRuleBlock):
(WebCore::StyleRuleMedia::StyleRuleMedia):
(WebCore::StyleRuleRegion::StyleRuleRegion):

  • css/StyleRule.h:

(StyleRuleBase):
(WebCore::StyleRuleBase::StyleRuleBase):
(WebCore::StyleRule::copy):
(StyleRule):
(WebCore::StyleRuleFontFace::copy):
(StyleRuleFontFace):
(WebCore::StyleRulePage::copy):
(StyleRulePage):
(StyleRuleBlock):
(WebCore::StyleRuleMedia::copy):
(StyleRuleMedia):
(WebCore::StyleRuleRegion::copy):
(StyleRuleRegion):

  • css/WebKitCSSKeyframesRule.cpp:

(WebCore):
(WebCore::StyleRuleKeyframes::StyleRuleKeyframes):

  • css/WebKitCSSKeyframesRule.h:

(WebCore):
(WebCore::StyleRuleKeyframes::copy):
(StyleRuleKeyframes):

2:34 PM Changeset in webkit [115114] by Lucas Forschler
  • 5 edits in branches/safari-534.57-branch/Source

Versioning.

2:33 PM Changeset in webkit [115113] by Lucas Forschler
  • 1 copy in tags/Safari-534.57.3

New tag.

2:24 PM Changeset in webkit [115112] by rniwa@webkit.org
  • 17 edits
    5 deletes in trunk

Revert r115009; It doesn't make necessary changes to NodeRareData and Node.

Source/WebCore:

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::getNamedItems):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:

(WebCore::getNamedItems):

  • html/CollectionType.h:
  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::shouldIncludeChildren):
(WebCore::HTMLCollection::isAcceptableElement):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::HTMLFormCollection):

  • html/RadioNodeList.cpp: Removed.
  • html/RadioNodeList.h: Removed.
  • html/RadioNodeList.idl: Removed.

LayoutTests:

  • fast/forms/form-collection-radio-node-list-expected.txt: Removed.
  • fast/forms/form-collection-radio-node-list.html: Removed.
2:20 PM Changeset in webkit [115111] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

WaveTable should normalize to 0dbFS instead of -6dbFS
https://bugs.webkit.org/show_bug.cgi?id=84644

Reviewed by Kenneth Russell.

No new tests. Oscillator tests will be rebaselined after landing, since several platforms are affected.

  • Modules/webaudio/WaveTable.cpp:

(WebCore::WaveTable::createBandLimitedTables):

2:15 PM Changeset in webkit [115110] by hclam@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed. Test expectations updates to make lint happy.

Some test files are removed or moved so update test expectations accordingly.

  • platform/chromium/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
2:14 PM Changeset in webkit [115109] by tommyw@google.com
  • 8 edits in trunk

MediaStream API: Create a new flag for PeerConnection
https://bugs.webkit.org/show_bug.cgi?id=84723

Reviewed by Dimitri Glazkov.

To allow Chrome to make the GetUserMedia functionality available by default we
need another flag for the PeerConnection related parts. This new flag is in
addition to the general media stream flag, and both need to be enabled for
PeerConnection object creation.

Source/WebCore:

No code behavior changes.

  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::peerConnectionEnabled):
(WebCore::RuntimeEnabledFeatures::setPeerConnectionEnabled):
(WebCore::RuntimeEnabledFeatures::webkitDeprecatedPeerConnectionEnabled):
(WebCore::RuntimeEnabledFeatures::webkitPeerConnection00Enabled):

Source/WebKit/chromium:

  • public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enablePeerConnection):
(WebKit):
(WebKit::WebRuntimeFeatures::isPeerConnectionEnabled):

Tools:

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

2:13 PM Changeset in webkit [115108] by robert@webkit.org
  • 3 edits in trunk/LayoutTests

Rebaseline 2 tests after r115091

Unreviewed.

  • platform/mac/accessibility/table-detection-expected.txt:
  • platform/mac/accessibility/table-with-rules-expected.txt:
2:13 PM Changeset in webkit [115107] by Lucas Forschler
  • 2 edits in branches/safari-534.57-branch/Source/JavaScriptCore

Merge fix for radar 11310337.

2:10 PM Changeset in webkit [115106] by danakj@chromium.org
  • 3 edits
    2 adds
    1 delete in trunk/LayoutTests

[chromium] Rebaseline and enable the background-blur layout tests
https://bugs.webkit.org/show_bug.cgi?id=84654

Unreviewed.

  • platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.txt: Removed.
  • platform/chromium-mac/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Added.
  • platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png:
  • platform/chromium/test_expectations.txt:
2:01 PM Changeset in webkit [115105] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, 32-bit build fix.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

1:52 PM Changeset in webkit [115104] by commit-queue@webkit.org
  • 11 edits in trunk

[BlackBerry] Revert broken changes to authentication dialog
https://bugs.webkit.org/show_bug.cgi?id=80135

Patch by Joe Mason <jmason@rim.com> on 2012-04-24
Reviewed by Antonio Gomes.

The previous patches from this bug caused an infinite loop when using digest auth;
apparently they were only tested with basic.

Source/WebCore:

  • platform/blackberry/PageClientBlackBerry.h:
  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::handleAuthHeader):
(WebCore::NetworkJob::sendRequestWithCredentials):

Source/WebKit/blackberry:

  • Api/DumpRenderTreeClient.h:
  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):

  • Api/WebPageClient.h:
  • Api/WebPage_p.h:

(WebPagePrivate):

Tools:

  • DumpRenderTree/blackberry/DumpRenderTree.cpp:
  • DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:

(WebCore):

1:43 PM Changeset in webkit [115103] by fpizlo@apple.com
  • 8 edits
    6 adds in trunk

DFG performs incorrect DCE on (some?) intrinsics
https://bugs.webkit.org/show_bug.cgi?id=84746
<rdar://problem/11310772>

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(ByteCodeParser):
(JSC::DFG::ByteCodeParser::setIntrinsicResult):
(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::handleIntrinsic):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

LayoutTests:

Rubber stamped by Oliver Hunt.

  • fast/js/dfg-dead-min-one-arg-expected.txt: Added.
  • fast/js/dfg-dead-min-one-arg.html: Added.
  • fast/js/dfg-dead-min-two-args-expected.txt: Added.
  • fast/js/dfg-dead-min-two-args.html: Added.
  • fast/js/script-tests/dfg-dead-min-one-arg.js: Added.

(foo):
(.x.f.valueOf):

  • fast/js/script-tests/dfg-dead-min-two-args.js: Added.

(foo):
(bar):
(.x.f.valueOf):
(.y.f.valueOf):

1:35 PM WebKit Team edited by jocelyn.turcotte@nokia.com
Move myself to reviewers. (diff)
1:23 PM Changeset in webkit [115102] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebCore

Fix wrong ASSERT() in findAttributeInVector()
https://bugs.webkit.org/show_bug.cgi?id=84756

Unreviewed build fix.

  • dom/ElementAttributeData.h:

(WebCore::findAttributeInVector):

1:15 PM Changeset in webkit [115101] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Update the scroll layer position on the main thread when viewing full-frame images
https://bugs.webkit.org/show_bug.cgi?id=84754
<rdar://problem/11193304>

Reviewed by Andreas Kling.

Showing really big images can be slow sometimes and in that case it's better to update the scroll layer position on
the main thread, which will avoid flashing white.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::updateShouldUpdateScrollLayerPositionOnMainThread):

1:01 PM Changeset in webkit [115100] by kling@webkit.org
  • 2 edits in trunk/LayoutTests

Rebaseline mac rendertree output for svg/custom/use-css-events.svg.

  • platform/mac/svg/custom/use-css-events-expected.txt: Updated for custom ellipse renderer changes.
12:59 PM Changeset in webkit [115099] by caio.oliveira@openbossa.org
  • 13 edits in trunk/Source/WebCore

Use Vector<Attribute> directly instead of encapsulating it in AttributeVector
https://bugs.webkit.org/show_bug.cgi?id=84413

Reviewed by Andreas Kling.

As commented in https://bugs.webkit.org/show_bug.cgi?id=79963#c16 we do not
usually subclass basic types like Vector. This patch changes code to use
Vector<Attribute> directly and move around the functionality of the former
methods to more specific helper functions or inline code at the callers.

  • dom/Element.cpp:

(WebCore::Element::parserSetAttributes):
(WebCore::Element::normalizeAttributes):

  • dom/Element.h:

(Element):

  • dom/ElementAttributeData.cpp:
  • dom/ElementAttributeData.h:

(WebCore::getAttributeFromVector):
(WebCore::ElementAttributeData::getAttributeItem):
(ElementAttributeData):
(WebCore::ElementAttributeData::attributeVector):
(WebCore::ElementAttributeData::clonedAttributeVector):
(WebCore::ElementAttributeData::getAttributeItemIndex):
(WebCore):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::createHTMLElementFromSavedElement):

  • html/parser/HTMLToken.h:

(WebCore::AtomicHTMLToken::AtomicHTMLToken):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processFakeStartTag):
(WebCore::HTMLTreeBuilder::attributesForIsindexInput):

  • html/parser/HTMLTreeBuilder.h:
  • html/parser/TextDocumentParser.cpp:

(WebCore::TextDocumentParser::insertFakePreElement):

  • xml/XMLErrors.cpp:

(WebCore::createXHTMLParserErrorHeader):
(WebCore::XMLErrors::insertErrorMessageBlock):

  • xml/parser/MarkupTokenBase.h:

(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):
(WebCore::AtomicMarkupTokenBase::getAttributeItem):
(WebCore::AtomicMarkupTokenBase::attributes):
(AtomicMarkupTokenBase):
(WebCore::::initializeAttributes):

  • xml/parser/XMLToken.h:

(WebCore::AtomicXMLToken::AtomicXMLToken):

12:47 PM Changeset in webkit [115098] by tommyw@google.com
  • 9 edits
    1 copy
    9 moves
    1 delete in trunk/LayoutTests

MediaStream API: Moving LT/fast/dom/MediaStream/* to LT/fast/mediastream
https://bugs.webkit.org/show_bug.cgi?id=82870

Reviewed by Dimitri Glazkov.

  • fast/dom/MediaStream/script-tests/argument-types.js: Removed.
  • fast/mediastream/argument-types-expected.txt: Renamed from LayoutTests/fast/dom/MediaStream/argument-types-expected.txt.
  • fast/mediastream/argument-types.html: Renamed from LayoutTests/fast/dom/MediaStream/argument-types.html.
  • fast/mediastream/enabled-expected.txt: Renamed from LayoutTests/fast/dom/MediaStream/enabled-expected.txt.
  • fast/mediastream/enabled.html: Renamed from LayoutTests/fast/dom/MediaStream/enabled.html.
  • fast/mediastream/no-interface-object-expected.txt: Renamed from LayoutTests/fast/dom/MediaStream/no-interface-object-expected.txt.
  • fast/mediastream/no-interface-object.html: Renamed from LayoutTests/fast/dom/MediaStream/no-interface-object.html.
  • fast/mediastream/peerconnection-Attributes.html:
  • fast/mediastream/peerconnection-argument-types.html:
  • fast/mediastream/script-tests/argument-types.js:

(test):

  • fast/mediastream/script-tests/enabled.js: Renamed from LayoutTests/fast/dom/MediaStream/script-tests/enabled.js.

(hasGetUserMediaProperty):

  • fast/mediastream/script-tests/no-interface-object.js: Renamed from LayoutTests/fast/dom/MediaStream/script-tests/no-interface-object.js.

(shouldThrowReferenceError):
(test):

  • fast/mediastream/script-tests/peerconnection-Attributes.js: Renamed from LayoutTests/fast/mediastream/script-tests/Attributes.js.

(shouldNotThrow):
(test):
(shouldBeA):
(shouldBeTrueA):
(emptyFunction):
(ObjectThrowingException.prototype.toString):
(gotStream):
(gotStreamFailed):

  • fast/mediastream/script-tests/peerconnection-argument-types.js: Copied from LayoutTests/fast/mediastream/script-tests/argument-types.js.

(shouldNotThrow):
(test):
(emptyFunction):
(ObjectThrowingException.prototype.toString):

  • platform/efl/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
12:46 PM Changeset in webkit [115097] by alexis.menard@openbossa.org
  • 73 edits in trunk/Source

Rename CSSStyleSelector class to StyleResolver.
https://bugs.webkit.org/show_bug.cgi?id=84734

Reviewed by Andreas Kling.

The name CSSStyleSelector is confusing as it conflicts a bit with
the CSS concept of selectors. One could think it's an encapsulation
of the CSS selectors but it's not, in fact this class is responsible
of finding the RenderStyle for a given element. This is the first patch
as I will later rename the files, and then rename the local variables.

Source/WebCore:

No new tests : renaming, no behavior changes should appear.

  • css/CSSCalculationValue.cpp:

(WebCore::CSSCalcPrimitiveValue::toCalcValue):

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::dispatchInvalidationCallbacks):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseSizeParameter):

  • css/CSSStyleSelector.cpp:

(RuleSet):
(WebCore::RuleSet::features):
(WebCore):
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::addAuthorRulesAndCollectUserRulesFromSheets):
(WebCore::makeRuleSet):
(WebCore::StyleResolver::collectFeatures):
(WebCore::StyleResolver::determineScope):
(WebCore::StyleResolver::ruleSetForScope):
(WebCore::StyleResolver::appendAuthorStylesheets):
(WebCore::StyleResolver::setupScopeStack):
(WebCore::StyleResolver::pushScope):
(WebCore::StyleResolver::popScope):
(WebCore::StyleResolver::pushParentElement):
(WebCore::StyleResolver::popParentElement):
(WebCore::StyleResolver::pushParentShadowRoot):
(WebCore::StyleResolver::popParentShadowRoot):
(WebCore::StyleResolver::addKeyframeStyle):
(WebCore::StyleResolver::~StyleResolver):
(WebCore::StyleResolver::sweepMatchedPropertiesCache):
(WebCore::StyleResolver::Features::Features):
(WebCore::StyleResolver::Features::~Features):
(WebCore::StyleResolver::Features::add):
(WebCore::StyleResolver::Features::clear):
(WebCore::StyleResolver::addMatchedProperties):
(WebCore::StyleResolver::addElementStyleProperties):
(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::collectMatchingRulesForRegion):
(WebCore::StyleResolver::sortAndTransferMatchedRules):
(WebCore::StyleResolver::matchScopedAuthorRules):
(WebCore::StyleResolver::matchAuthorRules):
(WebCore::StyleResolver::matchUserRules):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::collectMatchingRulesForList):

  • css/CSSStyleSelector.h:

(StyleResolver):
(Features):

  • css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::eval):

  • css/MediaQueryEvaluator.h:

(WebCore):
(MediaQueryEvaluator):

  • css/MediaQueryMatcher.cpp:

(WebCore::MediaQueryMatcher::prepareEvaluator):

  • css/SVGCSSStyleSelector.cpp:

(WebCore::StyleResolver::applySVGProperty):

  • css/StyleBuilder.cpp:

(WebCore::ApplyPropertyExpanding::applyInheritValue):
(WebCore::ApplyPropertyExpanding::applyInitialValue):
(WebCore::ApplyPropertyExpanding::applyValue):
(WebCore::ApplyPropertyDefaultBase::applyInheritValue):
(WebCore::ApplyPropertyDefaultBase::applyInitialValue):
(WebCore::ApplyPropertyDefaultBase::applyValue):
(WebCore::ApplyPropertyDefault::applyValue):
(WebCore::ApplyPropertyNumber::applyValue):
(WebCore::ApplyPropertyStyleImage::applyValue):
(WebCore::ApplyPropertyAuto::applyInheritValue):
(WebCore::ApplyPropertyAuto::applyInitialValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::convertToLength):
(WebCore::ApplyPropertyClip::applyInheritValue):
(WebCore::ApplyPropertyClip::applyInitialValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyColor::applyInheritValue):
(WebCore::ApplyPropertyColor::applyInitialValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyColor::applyColorValue):
(WebCore::ApplyPropertyDirection::applyValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyFillLayer::applyInheritValue):
(WebCore::ApplyPropertyFillLayer::applyInitialValue):
(WebCore::ApplyPropertyFillLayer::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFont::applyInheritValue):
(WebCore::ApplyPropertyFont::applyInitialValue):
(WebCore::ApplyPropertyFont::applyValue):
(WebCore::ApplyPropertyFontSize::applyInheritValue):
(WebCore::ApplyPropertyFontSize::applyInitialValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyInheritValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyInitialValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyBorderImage::applyValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInheritValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInitialValue):
(WebCore::ApplyPropertyBorderImageModifier::applyValue):
(WebCore::ApplyPropertyBorderImageSource::applyValue):
(WebCore::ApplyPropertyCounter::emptyFunction):
(WebCore::ApplyPropertyCounter::applyInheritValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCursor::applyInheritValue):
(WebCore::ApplyPropertyCursor::applyInitialValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyTextAlign::applyValue):
(WebCore::ApplyPropertyTextDecoration::applyValue):
(WebCore::ApplyPropertyUnicodeBidi::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyPageSize::applyInheritValue):
(WebCore::ApplyPropertyPageSize::applyInitialValue):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore):
(WebCore::ApplyPropertyAnimation::map):
(WebCore::ApplyPropertyAnimation::applyInheritValue):
(WebCore::ApplyPropertyAnimation::applyInitialValue):
(WebCore::ApplyPropertyAnimation::applyValue):
(WebCore::ApplyPropertyOutlineStyle::applyInheritValue):
(WebCore::ApplyPropertyOutlineStyle::applyInitialValue):
(WebCore::ApplyPropertyOutlineStyle::applyValue):
(WebCore::ApplyPropertyResize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyAspectRatio::applyInheritValue):
(WebCore::ApplyPropertyAspectRatio::applyInitialValue):
(WebCore::ApplyPropertyAspectRatio::applyValue):
(WebCore::ApplyPropertyZoom::resetEffectiveZoom):
(WebCore::ApplyPropertyZoom::applyInheritValue):
(WebCore::ApplyPropertyZoom::applyInitialValue):
(WebCore::ApplyPropertyZoom::applyValue):
(WebCore::ApplyPropertyDisplay::isValidDisplayValue):
(WebCore::ApplyPropertyDisplay::applyInheritValue):
(WebCore::ApplyPropertyDisplay::applyInitialValue):
(WebCore::ApplyPropertyDisplay::applyValue):
(WebCore::ApplyPropertyFlex::applyInheritValue):
(WebCore::ApplyPropertyFlex::applyInitialValue):
(WebCore::ApplyPropertyFlex::applyValue):
(WebCore::StyleBuilder::StyleBuilder):

  • css/StyleBuilder.h:

(WebCore):
(PropertyHandler):
(WebCore::PropertyHandler::applyInheritValue):
(WebCore::PropertyHandler::applyInitialValue):
(WebCore::PropertyHandler::applyValue):

  • css/StyleMedia.cpp:

(WebCore::StyleMedia::matchMedium):

  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::setName):

  • css/WebKitCSSMatrix.cpp:

(WebCore::WebKitCSSMatrix::setMatrixValue):

  • dom/Document.cpp:

(WebCore::Document::recalcStyle):
(WebCore::Document::createStyleSelector):
(WebCore::Document::testAddedStylesheetRequiresStyleRecalc):

  • dom/Document.h:

(WebCore):
(WebCore::Document::styleSelectorIfExists):
(WebCore::Document::styleSelector):
(Document):

  • dom/Element.cpp:

(StyleSelectorParentPusher):
(WebCore::Element::attributeChanged):
(WebCore::Element::beginParsingChildren):
(WebCore::Element::finishParsingChildren):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::attach):

  • dom/ShadowTree.cpp:

(WebCore::ShadowTree::recalcShadowTreeStyle):

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::mergeStyleFromRules):
(WebCore::EditingStyle::removeStyleFromRulesAndContext):
(WebCore::EditingStyle::removePropertiesInElementDefaultStyle):
(WebCore::legacyFontSizeFromCSSValue):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::focusedOrActiveStateChanged):

  • history/CachedPage.cpp:

(WebCore::CachedPage::restore):

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::styleSelector):

  • html/HTMLCanvasElement.h:

(HTMLCanvasElement):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setFont):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::buildArrayForRuleList):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::getMatchedCSSRules):

  • page/Page.cpp:

(WebCore::Page::allVisitedStateChanged):
(WebCore::Page::visitedStateChanged):

  • page/animation/AnimationController.cpp:

(WebCore::AnimationController::updateAnimations):

  • platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::adjustButtonStyle):
(WebCore::RenderThemeBlackBerry::adjustTextAreaStyle):
(WebCore::RenderThemeBlackBerry::adjustTextFieldStyle):
(WebCore::RenderThemeBlackBerry::adjustSearchFieldStyle):
(WebCore::RenderThemeBlackBerry::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeBlackBerry::adjustMenuListButtonStyle):
(WebCore::RenderThemeBlackBerry::adjustMenuListStyle):
(WebCore::RenderThemeBlackBerry::adjustCheckboxStyle):
(WebCore::RenderThemeBlackBerry::adjustRadioStyle):

  • platform/blackberry/RenderThemeBlackBerry.h:

(RenderThemeBlackBerry):

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::adjustSliderTrackStyle):
(WebCore::RenderThemeEfl::adjustSliderThumbStyle):
(WebCore::RenderThemeEfl::adjustCheckboxStyle):
(WebCore::RenderThemeEfl::adjustRadioStyle):
(WebCore::RenderThemeEfl::adjustButtonStyle):
(WebCore::RenderThemeEfl::adjustMenuListStyle):
(WebCore::RenderThemeEfl::adjustMenuListButtonStyle):
(WebCore::RenderThemeEfl::adjustTextFieldStyle):
(WebCore::RenderThemeEfl::adjustTextAreaStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldStyle):
(WebCore::RenderThemeEfl::adjustProgressBarStyle):

  • platform/efl/RenderThemeEfl.h:

(RenderThemeEfl):

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::adjustButtonStyle):
(WebCore::RenderThemeGtk::adjustMenuListStyle):
(WebCore::RenderThemeGtk::adjustMenuListButtonStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldStyle):
(WebCore::RenderThemeGtk::adjustSliderTrackStyle):
(WebCore::RenderThemeGtk::adjustSliderThumbStyle):
(WebCore::RenderThemeGtk::adjustProgressBarStyle):

  • platform/gtk/RenderThemeGtk.h:

(RenderThemeGtk):

  • platform/gtk/RenderThemeGtk2.cpp:

(WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle):

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle):

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::adjustTextFieldStyle):
(WebCore::RenderThemeQt::adjustTextAreaStyle):
(WebCore::RenderThemeQt::adjustMenuListStyle):
(WebCore::RenderThemeQt::adjustMenuListButtonStyle):
(WebCore::RenderThemeQt::adjustProgressBarStyle):
(WebCore::RenderThemeQt::adjustSliderTrackStyle):
(WebCore::RenderThemeQt::adjustSliderThumbStyle):
(WebCore::RenderThemeQt::adjustSearchFieldStyle):
(WebCore::RenderThemeQt::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeQt::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQt::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeQt::adjustInnerSpinButtonStyle):

  • platform/qt/RenderThemeQt.h:

(RenderThemeQt):

  • platform/qt/RenderThemeQtMobile.cpp:

(WebCore::RenderThemeQtMobile::adjustButtonStyle):
(WebCore::RenderThemeQtMobile::adjustTextFieldStyle):
(WebCore::RenderThemeQtMobile::adjustMenuListStyle):

  • platform/qt/RenderThemeQtMobile.h:

(RenderThemeQtMobile):

  • platform/wx/RenderThemeWx.cpp:

(RenderThemeWx):
(WebCore::RenderThemeWx::adjustButtonStyle):
(WebCore::RenderThemeWx::adjustTextFieldStyle):
(WebCore::RenderThemeWx::adjustMenuListStyle):
(WebCore::RenderThemeWx::adjustMenuListButtonStyle):

  • rendering/RenderInputSpeech.cpp:

(WebCore::RenderInputSpeech::adjustInputFieldSpeechButtonStyle):

  • rendering/RenderInputSpeech.h:

(RenderInputSpeech):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::adjustCheckboxStyle):
(WebCore::RenderTheme::adjustRadioStyle):
(WebCore::RenderTheme::adjustButtonStyle):
(WebCore::RenderTheme::adjustInnerSpinButtonStyle):
(WebCore::RenderTheme::adjustTextFieldStyle):
(WebCore::RenderTheme::adjustTextAreaStyle):
(WebCore::RenderTheme::adjustMenuListStyle):
(WebCore::RenderTheme::adjustInputFieldSpeechButtonStyle):
(WebCore::RenderTheme::adjustMeterStyle):
(WebCore::RenderTheme::adjustProgressBarStyle):
(WebCore::RenderTheme::adjustMenuListButtonStyle):
(WebCore::RenderTheme::adjustSliderTrackStyle):
(WebCore::RenderTheme::adjustSliderThumbStyle):
(WebCore::RenderTheme::adjustSearchFieldStyle):
(WebCore::RenderTheme::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderTheme::adjustSearchFieldDecorationStyle):
(WebCore::RenderTheme::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderTheme::adjustSearchFieldResultsButtonStyle):

  • rendering/RenderTheme.h:

(RenderTheme):

  • rendering/RenderThemeChromiumAndroid.cpp:

(WebCore::RenderThemeChromiumAndroid::adjustInnerSpinButtonStyle):

  • rendering/RenderThemeChromiumAndroid.h:

(RenderThemeChromiumAndroid):

  • rendering/RenderThemeChromiumLinux.cpp:

(WebCore::RenderThemeChromiumLinux::adjustInnerSpinButtonStyle):

  • rendering/RenderThemeChromiumLinux.h:

(RenderThemeChromiumLinux):

  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::adjustButtonStyle):
(WebCore::RenderThemeChromiumSkia::adjustSearchFieldStyle):
(WebCore::RenderThemeChromiumSkia::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeChromiumSkia::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeChromiumSkia::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeChromiumSkia::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeChromiumSkia::adjustMenuListStyle):
(WebCore::RenderThemeChromiumSkia::adjustMenuListButtonStyle):

  • rendering/RenderThemeChromiumSkia.h:

(RenderThemeChromiumSkia):

  • rendering/RenderThemeChromiumWin.cpp:

(WebCore):
(WebCore::RenderThemeChromiumWin::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeChromiumWin::adjustProgressBarStyle):

  • rendering/RenderThemeChromiumWin.h:

(RenderThemeChromiumWin):

  • rendering/RenderThemeMac.h:

(RenderThemeMac):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::setFontFromControlSize):
(WebCore::RenderThemeMac::adjustTextFieldStyle):
(WebCore::RenderThemeMac::adjustTextAreaStyle):
(WebCore::RenderThemeMac::adjustProgressBarStyle):
(WebCore::RenderThemeMac::adjustMenuListStyle):
(WebCore::RenderThemeMac::adjustMenuListButtonStyle):
(WebCore::RenderThemeMac::adjustSliderTrackStyle):
(WebCore::RenderThemeMac::adjustSliderThumbStyle):
(WebCore::RenderThemeMac::adjustSearchFieldStyle):
(WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):

  • rendering/RenderThemeSafari.cpp:

(WebCore::RenderThemeSafari::setFontFromControlSize):
(WebCore::RenderThemeSafari::adjustButtonStyle):
(WebCore::RenderThemeSafari::adjustTextFieldStyle):
(WebCore::RenderThemeSafari::adjustTextAreaStyle):
(WebCore::RenderThemeSafari::adjustMenuListStyle):
(WebCore::RenderThemeSafari::adjustMenuListButtonStyle):
(WebCore::RenderThemeSafari::adjustSliderThumbStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldResultsButtonStyle):

  • rendering/RenderThemeSafari.h:

(RenderThemeSafari):

  • rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeWin::adjustMenuListStyle):
(WebCore::RenderThemeWin::adjustMenuListButtonStyle):
(WebCore::RenderThemeWin::adjustSearchFieldStyle):
(WebCore::RenderThemeWin::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeWin::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeWin::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeWin::adjustSearchFieldResultsButtonStyle):

  • rendering/RenderThemeWin.h:

(RenderThemeWin):
(WebCore::RenderThemeWin::adjustButtonStyle):
(WebCore::RenderThemeWin::adjustTextFieldStyle):
(WebCore::RenderThemeWin::adjustTextAreaStyle):

  • rendering/RenderThemeWinCE.cpp:

(WebCore::RenderThemeWinCE::adjustMenuListStyle):
(WebCore::RenderThemeWinCE::adjustSearchFieldStyle):
(WebCore::RenderThemeWinCE::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeWinCE::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeWinCE::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeWinCE::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeWinCE::adjustMenuListButtonStyle):

  • rendering/RenderThemeWinCE.h:

(RenderThemeWinCE):
(WebCore::RenderThemeWinCE::adjustButtonStyle):
(WebCore::RenderThemeWinCE::adjustTextFieldStyle):
(WebCore::RenderThemeWinCE::adjustTextAreaStyle):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::isStyleAvailable):

  • rendering/style/RenderStyle.h:

(WebCore):

  • rendering/style/StyleRareNonInheritedData.h:

(WebCore):

  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::computeNewScaledFontForStyle):

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::isOverflowHidden):

Source/WebKit/qt:

  • WebCoreSupport/RenderThemeQStyle.cpp:

(WebCore::RenderThemeQStyle::adjustButtonStyle):
(WebCore::RenderThemeQStyle::adjustTextAreaStyle):
(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
(WebCore::RenderThemeQStyle::adjustSliderTrackStyle):
(WebCore::RenderThemeQStyle::adjustSliderThumbStyle):
(WebCore::RenderThemeQStyle::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQStyle::adjustSearchFieldResultsDecorationStyle):

  • WebCoreSupport/RenderThemeQStyle.h:

(RenderThemeQStyle):

12:43 PM Changeset in webkit [115096] by mhahnenberg@apple.com
  • 4 edits
    3 adds in trunk

Failure to allocate ArrayStorage in emit_op_new_array leads to poisonous JSArray
https://bugs.webkit.org/show_bug.cgi?id=84648

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

When emit_op_new_array successfully allocates a new JSArray but fails to allocate
the corresponding ArrayStorage for it, it falls back to the out-of-line stub call
to constructArray, which constructs and entirely new JSArray/ArrayStorage pair.
This leaves us with a JSArray hanging around on the stack or in a register that
did not go through its own constructor, thus giving it uninitialized memory in the
two fields that are checked in JSArray::visitChildren.

  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateJSArray): We try to allocate the ArrayStorage first, so that
if we fail we haven't generated the poisonous JSArray that can cause a GC crash.

  • jit/JITOpcodes.cpp:

(JSC::JIT::emitSlow_op_new_array):

LayoutTests:

Added a test that randomly allocates new arrays, modifies the object graph by
pointing arrays to other arrays, and removes arrays from the global list. This test
is sufficient to repro this bug when the DFG is disabled, and it should serve as
a good regression test as we implement more optimizations for array allocation in
both JITs.

  • fast/js/random-array-gc-stress-expected.txt: Added.
  • fast/js/random-array-gc-stress.html: Added.
  • fast/js/script-tests/random-array-gc-stress.js: Added.

(gc):
(getRandomIndex):
(test):

12:41 PM Changeset in webkit [115095] by jesus@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Unreviewed build fix after r115083

  • WebProcess/qt/QtBuiltinBundlePage.cpp:

(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage):

12:28 PM Changeset in webkit [115094] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

[TestResultsServer] Add a unit test for changes in r114868
https://bugs.webkit.org/show_bug.cgi?id=84713

Reviewed by Ojan Vafai.

Add a new unit test to test the isToTWebKit attribute of a BuilderGroup object
that is created for either DEPS or ToT builder groups. The unit test covers changes
made in r114868.

  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

(testBuilderGroupIsToTWebKitAttribute.g_handleBuildersListLoaded):
(testBuilderGroupIsToTWebKitAttribute.assertEquals):

12:19 PM Changeset in webkit [115093] by fpizlo@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

DFG on ARMv7 should not OSR exit on every integer division
https://bugs.webkit.org/show_bug.cgi?id=84661

Reviewed by Oliver Hunt.

On ARMv7, ArithDiv no longer has to know whether or not to speculate integer (since
that was broken with the introduction of Int32ToDouble) nor does it have to know
whether or not to convert its result to integer. This is now taken care of for free
with the addition of the DoubleAsInt32 node, which represents a double-is-really-int
speculation.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::OSRExit::considerAddingAsFrequentExitSiteSlow):

  • dfg/DFGOSRExit.h:

(OSRExit):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
(JSC::DFG::SpeculativeJIT::compileDoubleAsInt32):
(DFG):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::forwardSpeculationCheck):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

12:11 PM Changeset in webkit [115092] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

"GlobalHandle" HandleHeap (now WeakSet) allocations grow but do not shrink
https://bugs.webkit.org/show_bug.cgi?id=84740
<rdar://problem/9917638>

Reviewed by Gavin Barraclough.

Shrink!

  • heap/Heap.cpp:

(JSC::Heap::destroy): Be more specific about what's shrinking, since we
can also shrink the WeakSet, but we don't do so here.

(JSC::Heap::collect): If we're going to shrink the heap, shrink the
WeakSet too. Otherwise, its footprint is permanent.

  • heap/Heap.h:

(Heap): Removed shrink() as a public interface, since it's vague about
which parts of the heap it affects, and it's really an internal detail.

  • heap/WeakSet.cpp:

(JSC::WeakSet::shrink): Nix any free blocks. We assume that sweep() has
already taken place, since that's the convention for shrink() in the heap.

  • heap/WeakSet.h:

(WeakSet): New function!

12:03 PM Changeset in webkit [115091] by robert@webkit.org
  • 10 edits
    17 adds in trunk

CSS 2.1 failure: table-columns-example-001 fails
https://bugs.webkit.org/show_bug.cgi?id=83978

Reviewed by David Hyatt.

Source/WebCore:

Tests: css2.1/20110323/table-columns-example-001.html

fast/css/table-rules-attribute-groups-with-frame.html
fast/css/table-rules-attribute-groups.html
fast/css/table-rules-attribute-none-with-frame.html
fast/css/table-rules-attribute-with-frame1.html
fast/css/table-rules-attribute-with-frame2.html
fast/css/table-rules-attribute.html

WebKit does not implement the 'cols', 'rows', and 'all' rules attributes correctly
for cells that are adjacent to the table's edges. The solution is to follow the hint in the
spec at http://www.w3.org/TR/CSS21/tables.html#columns and set the table's border to
hidden when the rules attribute is set to one of 'cols', 'rows' or 'all', and the table itself
has no explicit border. Border collapsing will take care of the rest as 'hidden' always wins in
border-conflict resolution. It's not completely clear from the spec that an explicit table border
should trump a cols rule but doing so is consistent with FF and Opera at least. A 'rules' attribute
is trumped by anything specified for the 'frame' attribute so need to ensure that is respected too.

In short, any 'rules' attribute means a hidden table border unless there's a frame or border attribute.

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::additionalAttributeStyle):

LayoutTests:

  • css2.1/20110323/table-columns-example-001-expected.html: Added.
  • css2.1/20110323/table-columns-example-001.htm: Added.
  • fast/css/table-rules-attribute-expected.html: Added.
  • fast/css/table-rules-attribute-groups-expected.html: Added.
  • fast/css/table-rules-attribute-groups-with-frame-expected.png: Added.
  • fast/css/table-rules-attribute-groups-with-frame-expected.txt: Added.
  • fast/css/table-rules-attribute-groups-with-frame.html: Added.
  • fast/css/table-rules-attribute-groups.html: Added.
  • fast/css/table-rules-attribute-none-with-frame-expected.html: Added.
  • fast/css/table-rules-attribute-none-with-frame.html: Added.
  • fast/css/table-rules-attribute-with-frame1-expected.png: Added.
  • fast/css/table-rules-attribute-with-frame1-expected.txt: Added.
  • fast/css/table-rules-attribute-with-frame1.html: Added.
  • fast/css/table-rules-attribute-with-frame2-expected.png: Added.
  • fast/css/table-rules-attribute-with-frame2-expected.txt: Added.
  • fast/css/table-rules-attribute-with-frame2.html: Added. These test the correct interaction of a rules attribute with a frame attribute. 'cols' is used for the test, but each of cols, rows, and all have the same effect on the table's borders. It wasn't possible to create reftests for all of them because of the different behaviour of the frame attr to a simple border, probably due to painting order.
  • fast/css/table-rules-attribute.html: Added. This tests correct rendering of the rules attribute on a table without its own border. It also tests border collapsing on tables with a rules attribute.
  • platform/chromium-linux/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:

This is a progression - the table's border is hidden.

  • platform/chromium/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/Skipped:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
11:55 AM Changeset in webkit [115090] by commit-queue@webkit.org
  • 31 edits
    5 adds
    11 deletes in trunk/LayoutTests

[EFL] Rebaseline background tests
https://bugs.webkit.org/show_bug.cgi?id=84686

Unreviewed rebaseline.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-24

  • platform/efl/Skipped:
  • platform/efl/fast/backgrounds/001-expected.txt:
  • platform/efl/fast/backgrounds/animated-gif-as-background-expected.png:
  • platform/efl/fast/backgrounds/animated-svg-as-mask-expected.txt:
  • platform/efl/fast/backgrounds/background-leakage-expected.txt:
  • platform/efl/fast/backgrounds/background-leakage-transforms-expected.txt:
  • platform/efl/fast/backgrounds/background-origin-root-element-expected.txt:
  • platform/efl/fast/backgrounds/background-position-1-expected.png:
  • platform/efl/fast/backgrounds/background-position-parsing-expected.txt:
  • platform/efl/fast/backgrounds/background-position-rounding-expected.png:
  • platform/efl/fast/backgrounds/body-generated-image-propagated-to-root-expected.txt:
  • platform/efl/fast/backgrounds/mask-box-image-expected.png: Added.
  • platform/efl/fast/backgrounds/mask-box-image-expected.txt: Added.
  • platform/efl/fast/backgrounds/mask-composite-expected.png:
  • platform/efl/fast/backgrounds/opacity-on-document-element-expected.txt:
  • platform/efl/fast/backgrounds/positioned-root-expected.png: Removed.
  • platform/efl/fast/backgrounds/positioned-root-expected.txt: Removed.
  • platform/efl/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.txt:
  • platform/efl/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.txt:
  • platform/efl/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
  • platform/efl/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/efl/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.txt:
  • platform/efl/fast/backgrounds/repeat/noRepeatCorrectClip-expected.png:
  • platform/efl/fast/backgrounds/size/backgroundSize15-expected.txt:
  • platform/efl/fast/backgrounds/size/backgroundSize16-expected.txt:
  • platform/efl/fast/backgrounds/size/backgroundSize17-expected.png:
  • platform/efl/fast/backgrounds/size/backgroundSize17-expected.txt: Removed.
  • platform/efl/fast/backgrounds/size/backgroundSize18-expected.png:
  • platform/efl/fast/backgrounds/size/backgroundSize18-expected.txt: Removed.
  • platform/efl/fast/backgrounds/size/backgroundSize19-expected.png:
  • platform/efl/fast/backgrounds/size/backgroundSize19-expected.txt: Removed.
  • platform/efl/fast/backgrounds/size/backgroundSize20-expected.png:
  • platform/efl/fast/backgrounds/size/backgroundSize20-expected.txt: Removed.
  • platform/efl/fast/backgrounds/size/backgroundSize21-expected.png:
  • platform/efl/fast/backgrounds/size/backgroundSize21-expected.txt: Removed.
  • platform/efl/fast/backgrounds/size/backgroundSize22-expected.png:
  • platform/efl/fast/backgrounds/size/backgroundSize22-expected.txt: Removed.
  • platform/efl/fast/backgrounds/size/contain-and-cover-expected.png: Added.
  • platform/efl/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
  • platform/efl/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
  • platform/efl/fast/backgrounds/size/zero-expected.txt:
  • platform/efl/fast/backgrounds/solid-color-context-restore-expected.png:
  • platform/efl/fast/backgrounds/solid-color-context-restore-expected.txt:
  • platform/efl/fast/backgrounds/svg-as-mask-expected.txt: Removed.
  • platform/efl/fast/backgrounds/table-root-expected.png: Removed.
  • platform/efl/fast/backgrounds/table-root-expected.txt: Removed.
11:51 AM Changeset in webkit [115089] by timothy@apple.com
  • 2 edits in trunk/Source/WebCore

Stop installing localizedStrings.js in Production builds.

<rdar://problem/11296649>

Reviewed by Joseph Pecoraro.

  • Configurations/WebCore.xcconfig: Added EXCLUDED_SOURCE_FILE_NAMES_Production_macosx

and modified EXCLUDED_SOURCE_FILE_NAMES to look for CONFIGURATION variant.

11:44 AM Changeset in webkit [115088] by kbr@google.com
  • 2 edits in trunk/LayoutTests

fast/dom/Window/window-postmessage-clone.html failing on Mac after r114992
https://bugs.webkit.org/show_bug.cgi?id=84741

Not reviewed. Rebaseline only; verified locally.

  • fast/dom/Window/window-postmessage-clone-expected.txt:
11:34 AM Changeset in webkit [115087] by kling@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, skip unsupported inspector heap profiler test on mac.

  • platform/mac/Skipped: Skip inspector/profiler/heap-snapshot-comparison-dom-groups-change.html
11:32 AM Changeset in webkit [115086] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[chromium] Add a description field in WebURLError and show failure description in the inspector network tab.
https://bugs.webkit.org/show_bug.cgi?id=84566

Patch by Yuzhu Shen <yzshen@chromium.org> on 2012-04-24
Reviewed by Pavel Feldman.

Source/Platform:

  • chromium/public/WebURLError.h:

(WebURLError):

Source/WebCore:

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):

  • platform/chromium/support/WebURLError.cpp:

(WebKit::WebURLError::operator=):
(WebKit::WebURLError::operator ResourceError):

11:21 AM Changeset in webkit [115085] by rwlbuis@webkit.org
  • 44 edits
    4 adds
    1 delete in trunk

[SVG] getBBox on a <g> within symbol returns 0 but with defs it works correctly
https://bugs.webkit.org/show_bug.cgi?id=72796

SVG <use> of <symbol> containing <linearGradient> renders black
https://bugs.webkit.org/show_bug.cgi?id=82775

Source/WebCore:

Reviewed by Dirk Schulze.

Create RenderSVGHiddenContainer for each <symbol>, which allows creation of child renderers too. This fixes
both bugs since the bbox can be calculated at all times now and gradients in <symbol> are always created.
This does allocate more memory but in general <symbol> is not used a lot and they tend to be small subtrees.

Patch by Leo Yang.

Tests: svg/custom/bbox-of-g-in-symbol.svg

svg/custom/gradient-in-symbol-expected.svg
svg/custom/gradient-in-symbol.svg

  • svg/SVGSymbolElement.cpp:

(WebCore::SVGSymbolElement::createRenderer):
(WebCore):

  • svg/SVGSymbolElement.h:

(SVGSymbolElement):

LayoutTests:

Add a new test for each bug. Also rebaseline some test results since
RenderSVGHiddenContainer is dumped now.

Reviewed by Dirk Schulze.

  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
  • platform/mac/svg/carto.net/button-expected.txt:
  • platform/mac/svg/carto.net/colourpicker-expected.txt:
  • platform/mac/svg/carto.net/slider-expected.txt:
  • platform/mac/svg/carto.net/window-expected.txt:
  • platform/mac/svg/custom/embedding-external-svgs-expected.txt:
  • platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
  • platform/mac/svg/custom/relative-sized-use-on-symbol-expected.txt:
  • platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
  • platform/mac/svg/custom/struct-use-09-b-expected.txt: Removed.
  • platform/mac/svg/custom/use-clipped-hit-expected.txt:
  • platform/mac/svg/custom/use-css-events-expected.txt:
  • platform/mac/svg/custom/use-modify-target-symbol-expected.txt:
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
  • platform/mac/svg/custom/use-on-g-containing-symbol-expected.txt:
  • platform/mac/svg/custom/use-on-symbol-expected.txt:
  • platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • platform/mac/svg/custom/use-recalcStyle-crash-expected.txt:
  • platform/mac/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
  • platform/mac/svg/custom/use-symbol-overflow-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
  • platform/qt/svg/carto.net/button-expected.txt:
  • platform/qt/svg/carto.net/colourpicker-expected.txt:
  • platform/qt/svg/carto.net/slider-expected.txt:
  • platform/qt/svg/carto.net/window-expected.txt:
  • platform/qt/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
  • platform/qt/svg/custom/use-on-g-containing-symbol-expected.txt:
  • platform/qt/svg/custom/use-on-symbol-expected.txt:
  • platform/qt/svg/custom/use-recalcStyle-crash-expected.txt:
  • platform/qt/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-svg2-expected.txt:
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-symbol-expected.txt:
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-symbol2-expected.txt:
  • svg/custom/bbox-of-g-in-symbol-expected.txt: Added.
  • svg/custom/bbox-of-g-in-symbol.svg: Added.
  • svg/custom/deep-dynamic-updates-expected.txt:
  • svg/custom/gradient-in-symbol-expected.svg: Added.
  • svg/custom/gradient-in-symbol.svg: Added.
  • svg/custom/use-in-symbol-with-offset-expected.txt:
  • svg/custom/use-setAttribute-crash-expected.txt:
  • svg/custom/use-transfer-width-height-properties-to-svg2-expected.txt:
  • svg/custom/use-transfer-width-height-properties-to-symbol-expected.txt:
  • svg/custom/use-transfer-width-height-properties-to-symbol1-expected.txt:
  • svg/custom/use-transfer-width-height-properties-to-symbol2-expected.txt:
11:13 AM Changeset in webkit [115084] by eae@chromium.org
  • 2 edits in branches/subpixellayout/Source/WebKit/gtk/webkit

Misc GTK fixes on branch.

11:12 AM Changeset in webkit [115083] by beidson@apple.com
  • 31 edits
    8 adds in trunk

<rdar://problem/10120155> and https://bugs.webkit.org/show_bug.cgi?id=82664 Need DOMWindow mechanism to supplement UserScripts for page cache notifications

Source/WebCore:

This patch creates a new object type "DOMWindowExtension" which extends DOMWindowProperty.
A DOMWindowExtension is tied to a particular DOMWindow and represents extensibility in that
DOMWindow within a particular DOMWrapperWorld.

It is a token object meant designed to notify clients of the various events in the lifetime
of a DOMWindow property such as creation, disconnecting for the page cache, reconnecting
when restoring from the page cache, and DOMWindow destruction.

Reviewed by Sam Weinig.

New WebKit API test DOMWindowExtensionBasic added.

Add hooks for 4 new client calls regarding DOMWindowExtensions and global object lifetime:

  • loader/FrameLoaderClient.h:

(WebCore::FrameLoaderClient::dispatchCanCreateGlobalObject):
(WebCore::FrameLoaderClient::dispatchWillDisconnectDOMWindowExtensionFromGlobalObject):
(WebCore::FrameLoaderClient::dispatchDidReconnectDOMWindowExtensionToGlobalObject):
(WebCore::FrameLoaderClient::dispatchWillDestroyGlobalObjectForDOMWindowExtension):

At the same time "DidClearWindowObject" is called, also notify clients that the global object is available:

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::receivedFirstData):
(WebCore::FrameLoader::dispatchGlobalObjectAvailableInAllWorlds):

  • loader/FrameLoader.h:

DOMWindowProperties might want to unregister themselves during these notifications, so copy
the set to a Vector. While this technique is arguably fragile, its certainly less fragile than
mutating a set while iterating it:

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::willDetachPage):
(WebCore::DOMWindow::disconnectDOMWindowProperties):
(WebCore::DOMWindow::reconnectDOMWindowProperties):

Implement the DOMWindowExtension object. It acts like a DOMWindowProperty with the added capability
of remembering what Frame it used to be connected to so it can *always* notify clients on willDetachPage:

  • page/DOMWindowExtension.cpp: Added.

(WebCore::DOMWindowExtension::DOMWindowExtension):
(WebCore::DOMWindowExtension::~DOMWindowExtension):
(WebCore::DOMWindowExtension::disconnectFrame):
(WebCore::DOMWindowExtension::reconnectFrame):
(WebCore::DOMWindowExtension::willDetachPage):

  • page/DOMWindowExtension.h: Added.

(WebCore::DOMWindowExtension::create):
(WebCore::DOMWindowExtension::world):

Project files:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit2:

Reviewed by Sam Weinig.

  • Adds a new API object WKBundleDOMWindowExtension
  • Exposes callbacks about the lifetime of DOMWindowExtensions through BundlePageLoaderClient

Add new API casts:

  • Shared/API/c/WKBase.h:
  • Shared/APIClientTraits.cpp:
  • Shared/APIObject.h:
  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:

Add API for the new DOMWindowExtension object:

  • WebProcess/InjectedBundle/API/c/WKBundleDOMWindowExtension.cpp: Added.

(WKBundleDOMWindowExtensionGetTypeID):
(WKBundleDOMWindowExtensionCreate):
(WKBundleDOMWindowExtensionGetFrame):
(WKBundleDOMWindowExtensionGetScriptWorld):

  • WebProcess/InjectedBundle/API/c/WKBundleDOMWindowExtension.h: Added.

Add implementation for that API which wraps the WebCore::DOMWindowExtension:

  • WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp: Added.

(WebKit::allExtensions):
(WebKit::InjectedBundleDOMWindowExtension::create):
(WebKit::InjectedBundleDOMWindowExtension::get):
(WebKit::InjectedBundleDOMWindowExtension::InjectedBundleDOMWindowExtension):
(WebKit::InjectedBundleDOMWindowExtension::~InjectedBundleDOMWindowExtension):
(WebKit::InjectedBundleDOMWindowExtension::frame):
(WebKit::InjectedBundleDOMWindowExtension::world):

  • WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.h: Added.

(InjectedBundleDOMWindowExtension):
(WebKit::InjectedBundleDOMWindowExtension::type):

Add new BundlePageLoaderClient methods:

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::didCreateGlobalObjectForFrame):
(WebKit::InjectedBundlePageLoaderClient::willDisconnectDOMWindowExtensionFromGlobalObject):
(WebKit::InjectedBundlePageLoaderClient::didReconnectDOMWindowExtensionToGlobalObject):
(WebKit::InjectedBundlePageLoaderClient::willDestroyGlobalObjectForDOMWindowExtension):

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:

(InjectedBundlePageLoaderClient):

Implement the 4 new callbacks from WebCore which notify the BundlePageLoaderClient:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchGlobalObjectAvailable):
(WebKit::WebFrameLoaderClient::dispatchWillDisconnectDOMWindowExtensionFromGlobalObject):
(WebKit::WebFrameLoaderClient::dispatchDidReconnectDOMWindowExtensionToGlobalObject):
(WebKit::WebFrameLoaderClient::dispatchWillDestroyGlobalObjectForDOMWindowExtension):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Project Files:

  • CMakeLists.txt:
  • GNUmakefile.am:
  • Target.pri:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Tools:

Reviewed by Sam Weinig.

Add a new bundle test that stresses the basics of the WKBundleDOMWindowExtension API.

It makes sure new extensions can be added at the right times, and that all of the expected
callbacks are made.

  • TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp: Added.

(TestWebKitAPI::didReceiveMessageFromInjectedBundle): Record all messages sent from the bundle.
(TestWebKitAPI::TEST): Run a page through some basic exercises, then compared messages sent from the

bundle to a set of known expected messages.

Listen to all the new client callbacks, create some extensions, and monitor their lifetimes:

  • TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp: Added.

(TestWebKitAPI::DOMWindowExtensionBasic::DOMWindowExtensionBasic):
(TestWebKitAPI::DOMWindowExtensionBasic::frameLoadFinished):
(TestWebKitAPI::DOMWindowExtensionBasic::sendExtensionStateMessage):
(TestWebKitAPI::DOMWindowExtensionBasic::initialize):
(TestWebKitAPI::DOMWindowExtensionBasic::didCreatePage):
(TestWebKitAPI::DOMWindowExtensionBasic::updateExtensionStateRecord):
(TestWebKitAPI::DOMWindowExtensionBasic::sendBundleMessage):
(TestWebKitAPI::DOMWindowExtensionBasic::didCreateGlobalObjectForFrame):
(TestWebKitAPI::DOMWindowExtensionBasic::willDisconnectDOMWindowExtensionFromGlobalObject):
(TestWebKitAPI::DOMWindowExtensionBasic::didReconnectDOMWindowExtensionToGlobalObject):
(TestWebKitAPI::DOMWindowExtensionBasic::willDestroyGlobalObjectForDOMWindowExtension):
(TestWebKitAPI::didFinishLoadForFrameCallback):
(TestWebKitAPI::didCreateGlobalObjectForFrameCallback):
(TestWebKitAPI::willDisconnectDOMWindowExtensionFromGlobalObjectCallback):
(TestWebKitAPI::didReconnectDOMWindowExtensionToGlobalObjectCallback):
(TestWebKitAPI::willDestroyGlobalObjectForDOMWindowExtensionCallback):

  • TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:

(TestWebKitAPI::didReceiveMessageFromInjectedBundle): Make this method static, as it always should have been.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
10:48 AM Changeset in webkit [115082] by abecsi@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] Implement axis locking on the WebView for pan gestures
https://bugs.webkit.org/show_bug.cgi?id=84350

Reviewed by Kenneth Rohde Christiansen.

If a pan gesture has sufficient velocity along one axis the WebView
should automatically lock the page movement to that axis.
This locking should be maintained until the ongoing pan gesture ends.

This patch implements a simple axis locker which adjusts the positions
sent to the Flickable to the initial reference position according to the
direction an velocity information it gathered from incoming touch events.

The FlickableAxisLocker makes use of the velocity information of the touch point
if available, else an approximate velocity of the incoming event is
calculated.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::FlickableAxisLocker::FlickableAxisLocker):
(QQuickWebViewPrivate::FlickableAxisLocker::touchVelocity):
(QQuickWebViewPrivate::FlickableAxisLocker::update):
(QQuickWebViewPrivate::FlickableAxisLocker::setReferencePosition):
(QQuickWebViewPrivate::FlickableAxisLocker::reset):
(QQuickWebViewPrivate::FlickableAxisLocker::adjust):
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebView::touchEvent):
(QQuickWebView::handleFlickableMousePress):
(QQuickWebView::handleFlickableMouseMove):
(QQuickWebView::handleFlickableMouseRelease):

  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

10:46 AM Changeset in webkit [115081] by pdr@google.com
  • 4 edits
    1 delete in trunk/LayoutTests

Update svg-ellipse-non-scale-stroke expectations
https://bugs.webkit.org/show_bug.cgi?id=82628

Unreviewed update of test expectations.

  • platform/chromium/test_expectations.txt:
  • platform/gtk/svg/hittest/svg-ellipse-non-scale-stroke-expected.txt: Removed.
  • platform/gtk/test_expectations.txt:
  • svg/hittest/svg-ellipse-non-scale-stroke-expected.txt:
10:43 AM Changeset in webkit [115080] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[chromium] Don't keep pointers to released layer tree
https://bugs.webkit.org/show_bug.cgi?id=84715

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-04-24
Reviewed by Adrienne Walker.

Source/WebCore:

As part of tree synchronization, CCLayerTreeHostImpl loses ownership of
the previous tree (as per releaseRootLayer()). After this point we
should not retain any pointers to the old tree, because they are
effectively invalid as soon as the root layer is released.

For processing scroll updates we need to keep track of which layer is
being scrolled, and this state needs to survive tree synchronizations.
Instead of keeping a direct pointer to the scrolled layer, we now save
the id of that layer and use it to look up the same layer from the new
tree.

Unit test: CCLayerTreeHostImplTest.replaceTreeWhileScrolling

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::setRootLayer):
(WebCore::CCLayerTreeHostImpl::releaseRootLayer):
(WebCore::CCLayerTreeHostImpl::scrollBegin):
(WebCore::CCLayerTreeHostImpl::scrollEnd):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

Source/WebKit/chromium:

Added new unit test to check that we can keep scrolling even if the layer
tree is replaced from under us.

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKitTests::TEST_F):
(WebKitTests):

10:17 AM Changeset in webkit [115079] by Alexandru Chiculita
  • 9 edits
    2 adds in trunk/Source/WebCore

[CSS Filters] Move m_filter and related fields from RenderLayer to a different structure and only allocate it when needed
https://bugs.webkit.org/show_bug.cgi?id=84460

Reviewed by Dean Jackson.

The new RenderLayerFilterInfo is meant to be allocated only when needed by filters. The link to the RenderLayerFilterInfo
is maintained using a HashMap and a single boolean in the RenderLayer class.

No new tests, just extracted a couple of fields inside the RenderLayer to a separate class.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRendererHelper::prepareFilterEffect):
(WebCore::FilterEffectRendererHelper::beginFilterEffect):
(WebCore::FilterEffectRendererHelper::applyFilterEffect):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::~RenderLayer):
(WebCore::RenderLayer::paintsWithFilters):
(WebCore::RenderLayer::requiresFullLayerImageForFilters):
(WebCore::RenderLayer::setFilterBackendNeedsRepaintingInRect):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::updateOrRemoveFilterEffect):

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::filterRenderer):
(RenderLayer):
(WebCore::RenderLayer::filterInfo):
(WebCore::RenderLayer::ensureFilterInfo):
(WebCore::RenderLayer::removeFilterInfoIfNeeded):
(WebCore::RenderLayer::hasFilterInfo):
(WebCore::RenderLayer::setHasFilterInfo):

  • rendering/RenderLayerFilterInfo.cpp: Added.

(WebCore):
(WebCore::RenderLayerFilterInfo::filterInfoForRenderLayer):
(WebCore::RenderLayerFilterInfo::createFilterInfoForRenderLayerIfNeeded):
(WebCore::RenderLayerFilterInfo::removeFilterInfoForRenderLayer):
(WebCore::RenderLayerFilterInfo::RenderLayerFilterInfo):
(WebCore::RenderLayerFilterInfo::~RenderLayerFilterInfo):
(WebCore::RenderLayerFilterInfo::setRenderer):

  • rendering/RenderLayerFilterInfo.h: Added.

(WebCore):
(RenderLayerFilterInfo):
(WebCore::RenderLayerFilterInfo::dirtySourceRect):
(WebCore::RenderLayerFilterInfo::addDirtySourceRect):
(WebCore::RenderLayerFilterInfo::resetDirtySourceRect):
(WebCore::RenderLayerFilterInfo::renderer):

10:09 AM Changeset in webkit [115078] by Darin Adler
  • 4 edits in trunk/Source/WTF

Iterating a HashMap<String, X> involves a string equality comparison to check for the empty value
https://bugs.webkit.org/show_bug.cgi?id=84524

Reviewed by Antti Koivisto.

Added a new algorithm for checking for empty buckets that can be specialized.
Specialized it for String. We may later want to do the same thing for KURL.
It's not important to do it for AtomicString, since AtomicString's == function
is already a simple pointer equality compare. We may also later want to do
something similar for pairs that have String objects in them.

  • wtf/HashTable.h:

(WTF::HashTable::isEmptyBucket): Call the new isHashTraitsEmptyValue function, which
will do something more efficient for String.

  • wtf/HashTraits.h: Added hasIsEmptyValueFunction to hash traits, with a default value

of false. This allows us to continue to get automatic comparison with the appropriate
emptyValue result for all existing traits, but supply a custom isEmptyValue function
for HashTraits<String>. Putting an isEmptyValue function into the traits would require
overriding it in every class that has a custom value for emptyValue. Specialized
HashTraits for String to add hasIsEmptyValueFunction and declare, but not define, the
isEmptyValue function.
(WTF::isHashTraitsEmptyValue): Added a function that uses the HashTraitsEmptyValueChecker
struct to use either == combined with the emptyValue function or the isEmptyValue function.

  • wtf/text/StringHash.h: Removed unneeded includes and sorted the using statements at

the bottom of the file.
(WTF::HashTraits<String>::isEmptyValue): Define this function here, since here we have
included the WTFString.h header; the HashTraits.h header compiles without WTFString.h.

10:01 AM Changeset in webkit [115077] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[V8] Pass Isolate around in SerializedScriptValue.cpp (Part1)
https://bugs.webkit.org/show_bug.cgi?id=84663

Reviewed by Nate Chapin.

The objective is to pass Isolate to toV8() in SerializedScriptValue.cpp.

Part1: Add an Isolate argument to SerializedScriptValue::create(),
SerializedScriptValue::deserialize(), etc.
Part2: Add an m_isolate member to SerializedScriptValue::Writer()
and SerializedScriptValue::Reader().
Part3: Pass Isolate to toV8().

This patch fixes Part1.

No tests. No change in behavior.

  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::undefinedValue):
(WebCore::SerializedScriptValue::booleanValue):
(WebCore::SerializedScriptValue::numberValue):
(WebCore::SerializedScriptValue::SerializedScriptValue):
(WebCore::SerializedScriptValue::deserialize):
(WebCore::SerializedScriptValue::deserializeForInspector):

  • bindings/v8/SerializedScriptValue.h:

(SerializedScriptValue):

9:51 AM Changeset in webkit [115076] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84735

Mark http/tests/inspector/change-iframe-src.html as flaky on Windows

  • platform/chromium/test_expectations.txt:
9:48 AM Changeset in webkit [115075] by Carlos Garcia Campos
  • 6 edits
    2 adds in trunk

[GTK] Build and run TestWebKitAPI unit tests
https://bugs.webkit.org/show_bug.cgi?id=84325

Reviewed by Philippe Normand.

.:

  • GNUmakefile.am: Include makefiles to build gtest and

TestWebKitAPI. Add BUILDING_WEBKIT2 macro to compilation when
building WebKit2.

Source/ThirdParty:

  • gtest/GNUmakefile.am: Added.

Tools:

We only build WTF unit tests for now. WebKit2 tests will be
enabled in a follow up patch.

  • Scripts/run-gtk-tests:

(TestRunner): Add TestWebKitAPI/WTF to the list of directories
containing unit tests.
(TestRunner._run_test_glib): Run glib tests using gtester.
(TestRunner._run_test_google): Run google tests.
(TestRunner._run_test): Use _run_test_glib or _run_test_google
depending on whether given test is glib or google test

  • TestWebKitAPI/GNUmakefile.am: Added.
  • TestWebKitAPI/config.h: Use #ifdef instead of # to fix a compile

warning with -Wundef. Include WebKit2 headers only when building
WebKit2.

9:44 AM Changeset in webkit [115074] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[V8][Refactoring] Remove deserializeAndSetProperty()
from SerializedScriptValue.cpp
https://bugs.webkit.org/show_bug.cgi?id=84662

Reviewed by Nate Chapin.

SerializedScriptValue::deserializeAndSetProperty() is no
longer used. This patch removes it.

No tests. No change in behavior.

  • bindings/v8/SerializedScriptValue.cpp:
  • bindings/v8/SerializedScriptValue.h:
9:40 AM Changeset in webkit [115073] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[V8] Pass Isolate to setDOMException() in CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=84660

Reviewed by Nate Chapin.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to setDOMException() in CodeGeneratorV8.pm.

Test: bindings/scripts/test/TestEventTarget.idl

bindings/scripts/test/TestObj.idl
bindings/scripts/test/TestInterface.idl

  • bindings/scripts/CodeGeneratorV8.pm: Modified as described above.

(GenerateSetDOMException):
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateFunctionCallback):
(GenerateParametersCheck):
(GenerateFunctionCallString):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

Updated run-bindings-tests results.
(WebCore::TestEventTargetV8Internal::itemCallback):
(WebCore::TestEventTargetV8Internal::dispatchEventCallback):

  • bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.

(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):

  • bindings/scripts/test/V8/V8TestObj.cpp: Ditto.

(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::attrWithSetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::methodWithExceptionCallback):
(WebCore::TestObjV8Internal::withScriptStateVoidExceptionCallback):
(WebCore::TestObjV8Internal::withScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::getSVGDocumentCallback):
(WebCore::TestObjV8Internal::strictFunctionCallback):

9:31 AM Changeset in webkit [115072] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84733

Mark fast/canvas/canvas-composite.html as flaky on Vista.

9:28 AM Changeset in webkit [115071] by commit-queue@webkit.org
  • 7 edits in trunk/Tools

[Qt][WK2] Convert touch-point area
https://bugs.webkit.org/show_bug.cgi?id=84434

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-24
Reviewed by Kenneth Rohde Christiansen.

Fix failing test after r114917 by also adding the new EventSender API
to WebKitTestRunner.

  • WebKitTestRunner/EventSenderProxy.h:

(EventSenderProxy):

  • WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::EventSendingController::setTouchPointRadius):

  • WebKitTestRunner/InjectedBundle/EventSendingController.h:

(EventSendingController):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):

  • WebKitTestRunner/qt/EventSenderProxyQt.cpp:

(WTR::EventSenderProxy::addTouchPoint):
(WTR::EventSenderProxy::updateTouchPoint):
(WTR::EventSenderProxy::setTouchPointRadius):
(WTR::EventSenderProxy::clearTouchPoints):

9:21 AM Changeset in webkit [115070] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update.

  • platform/gtk/test_expectations.txt: One more drag&drop test

failing and mark fast/events/panScroll-click-hyperlink.html as
missing result.

9:18 AM Changeset in webkit [115069] by inferno@chromium.org
  • 6 edits in branches/chromium/1084

Revert 114994 - Merge 114699 - REGRESSION(r112177): Numbered list item rendered bulleted
https://bugs.webkit.org/show_bug.cgi?id=84216

Patch by David Barr <davidbarr@chromium.org> on 2012-04-19
Reviewed by Ryosuke Niwa.

Shorthands that imply omitted values cannot be derived from
an incomplete set of longhand rules.

No new tests; updated existing tests that should have caught this.

Source/WebCore:

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseTransformOriginShorthand):
Set implicit initial for Z when omitted.

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getShorthandValue):

LayoutTests:

  • css3/flexbox/css-properties.html:
  • fast/css/cssText-shorthand.html:
  • fast/css/uri-token-parsing-expected.txt:
  • fast/css/uri-token-parsing.html:
  • fast/dom/css-dom-read-2-expected.txt:

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10140014

TBR=mikelawther@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10204020

9:14 AM Changeset in webkit [115068] by haraken@chromium.org
  • 15 edits in trunk/Source/WebCore

[V8] Pass Isolate to setDOMException() (Part2)
https://bugs.webkit.org/show_bug.cgi?id=84658

Reviewed by Nate Chapin.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to setDOMException() in custom
binding code.

No tests. No change in behavior.

  • bindings/v8/V8Collection.cpp:

(WebCore::toOptionsCollectionSetter):

  • bindings/v8/V8Collection.h:

(WebCore):

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArrayWithArrayBufferArgument):
(WebCore::setWebGLArrayHelper):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::WindowSetTimeoutImpl):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::getInt8Callback):
(WebCore::V8DataView::getUint8Callback):
(WebCore::V8DataView::setInt8Callback):
(WebCore::V8DataView::setUint8Callback):

  • bindings/v8/custom/V8DirectoryEntrySyncCustom.cpp:

(WebCore::V8DirectoryEntrySync::getDirectoryCallback):
(WebCore::V8DirectoryEntrySync::getFileCallback):

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::toDataURLCallback):

  • bindings/v8/custom/V8HTMLElementCustom.cpp:

(WebCore::V8HTMLElement::itemValueAccessorSetter):

  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::addCallback):
(WebCore::V8HTMLOptionsCollection::lengthAccessorSetter):
(WebCore::V8HTMLOptionsCollection::indexedPropertySetter):

  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp:

(WebCore::V8HTMLSelectElement::indexedPropertySetter):

  • bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::V8Node::insertBeforeCallback):
(WebCore::V8Node::replaceChildCallback):
(WebCore::V8Node::removeChildCallback):
(WebCore::V8Node::appendChildCallback):

  • bindings/v8/custom/V8SQLTransactionCustom.cpp:

(WebCore::V8SQLTransaction::executeSqlCallback):

  • bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:

(WebCore::V8WebKitMutationObserver::observeCallback):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::responseAccessorGetter):

9:06 AM Changeset in webkit [115067] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[V8] Pass Isolate to setDOMException() (Part1)
https://bugs.webkit.org/show_bug.cgi?id=84656

Reviewed by Nate Chapin.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to setDOMException() in custom binding code.

No tests. No change in behavior.

  • bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::protocolAccessorSetter):

  • bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:

(WebCore::V8SQLTransactionSync::executeSqlCallback):

  • bindings/v8/custom/V8SVGLengthCustom.cpp:

(WebCore::V8SVGLength::valueAccessorGetter):
(WebCore::V8SVGLength::valueAccessorSetter):
(WebCore::V8SVGLength::convertToSpecifiedUnitsCallback):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::getObjectParameter):
(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
(WebCore::V8WebGLRenderingContext::getExtensionCallback):
(WebCore::V8WebGLRenderingContext::getFramebufferAttachmentParameterCallback):
(WebCore::V8WebGLRenderingContext::getParameterCallback):
(WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
(WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
(WebCore::V8WebGLRenderingContext::getUniformCallback):
(WebCore::vertexAttribAndUniformHelperf):
(WebCore::uniformHelperi):
(WebCore::uniformMatrixHelper):

9:05 AM Changeset in webkit [115066] by mifenton@rim.com
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Add additional details including the bounds of the box for caretPositionChanged.
https://bugs.webkit.org/show_bug.cgi?id=84728

Reviewed by Antonio Gomes.

PR 138988.

Update caretPositionChanged to include the limit of the input field
for single line inputs.

Reviewed Internally by Gen Mak.

  • Api/WebPageClient.h:
  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::boundingBoxForInputField):
(WebKit):

  • WebKitSupport/InputHandler.h:

(InputHandler):

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::clippingRectForVisibleContent):
(BlackBerry::WebKit::SelectionHandler::caretPositionChanged):

8:57 AM Changeset in webkit [115065] by charles.wei@torchmobile.com.cn
  • 3 edits
    1 add in trunk

[BlackBerry] Input Range element expects mouse events
https://bugs.webkit.org/show_bug.cgi?id=84571

Reviewed by Antonio Gomes.

.:

Input element with Range type expects mouse events to
drag the handle. Note that Input Range could appear
in both the web page directly, or in some shadow tree,
like the MediaControlTimeline and MediaControlVolume.

  • ManualTests/blackberry/slider-thumb-consumes-event.html: Added.

Source/WebKit/blackberry:

Input element with Range type expects mouse events to
drag the handle. Note that Input Range could appear
in both the web page directly, or in some shadow tree,
like the MediaControlTimeline and MediaControlVolume.

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::isRangeControlElement):
(WebKit):
(BlackBerry::WebKit::elementExpectsMouseEvents):
(BlackBerry::WebKit::shouldConvertTouchToMouse):

8:46 AM Changeset in webkit [115064] by pfeldman@chromium.org
  • 12 edits in trunk

Web Inspector: encapsulate live location into the Script.
https://bugs.webkit.org/show_bug.cgi?id=84722

Reviewed by Yury Semikhatsky.

Source/WebCore:

Live location is just a location on the script. The way it is implemented today involves too many indirections.

  • inspector/front-end/CompilerScriptMapping.js:
  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.prototype.setBreakpointByScriptLocation):
(WebInspector.DebuggerModel.prototype.scriptForId):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.createLiveLocation):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessageToScript):
(WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
(WebInspector.PresentationCallFrame.prototype.uiLocation):
(WebInspector.DebuggerPresentationModel.CallFramePlacard):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyRawLocation):

  • inspector/front-end/RawSourceCode.js:
  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype.addScript):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeChanged):
(WebInspector.ResourceScriptMapping.prototype._bindScriptToRawSourceCode):

  • inspector/front-end/Script.js:

(WebInspector.Script):
(WebInspector.Script.prototype.isInlineScript):
(WebInspector.Script.prototype.setSourceMapping):
(WebInspector.Script.prototype.createLocation):
(WebInspector.Script.Location):
(WebInspector.Script.Location.prototype.dispose):
(WebInspector.Script.Location.prototype._update):

  • inspector/front-end/ScriptMapping.js:

(WebInspector.UILocation):
(WebInspector.SourceMapping):
(WebInspector.SourceMapping.prototype.rawLocationToUILocation):
(WebInspector.SourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.MainScriptMapping):
(WebInspector.MainScriptMapping.prototype.addScript):
(WebInspector.MainScriptMapping.prototype.reset):

  • inspector/front-end/SnippetsModel.js:

(WebInspector.SnippetsScriptMapping.prototype._createUISourceCodeForScript):

LayoutTests:

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • inspector/debugger/linkifier.html:
8:37 AM Changeset in webkit [115063] by yurys@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: a bunch of heap profiler cleanups
https://bugs.webkit.org/show_bug.cgi?id=84730

  • HeapSnapshotProviderProxy passed explicitely as a parameter to HeapSnapshotGridNode

constructor

  • Removed dead code
  • Removed unused parameters
  • Added more closure compiler annotations
  • Extracted code finding cycled among node ancestors into a separate method

Reviewed by Pavel Feldman.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype.createEdgesProvider):
(WebInspector.HeapSnapshot.prototype.createRetainingEdgesProvider):
(WebInspector.HeapSnapshot.prototype.createNodesProviderForDominator):
(WebInspector.HeapSnapshotEdgesProvider):

  • inspector/front-end/HeapSnapshotDataGrids.js:
  • inspector/front-end/HeapSnapshotGridNodes.js:

(WebInspector.HeapSnapshotGridNode):
(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotObjectNode):
(WebInspector.HeapSnapshotObjectNode.prototype._findAncestorWithSameSnapshotNodeId):
(WebInspector.HeapSnapshotInstanceNode):
(WebInspector.HeapSnapshotConstructorNode):
(WebInspector.HeapSnapshotDiffNode):
(WebInspector.HeapSnapshotDiffNode._createProvider):
(WebInspector.HeapSnapshotDominatorObjectNode):

  • inspector/front-end/HeapSnapshotProxy.js:

(WebInspector.HeapSnapshotWorker):
(WebInspector.HeapSnapshotProxy.prototype.createNodesProviderForDominator):

  • inspector/front-end/utilities.js:
8:35 AM Changeset in webkit [115062] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update.

The following tests have been marked as crashing in debug mode only:

http/tests/websocket/tests/hixie76/workers/close-in-onmessage-crash.html
http/tests/websocket/tests/hixie76/workers/close-in-worker.html
http/tests/websocket/tests/hixie76/workers/worker-handshake-challenge-randomness.html
http/tests/websocket/tests/hixie76/workers/worker-simple.html
media/media-controller-playback.html
media/track/track-cues-missed.html
media/track/track-cues-pause-on-exit.html
media/track/track-cues-sorted-before-dispatch.html

  • platform/chromium/test_expectations.txt:
8:29 AM Changeset in webkit [115061] by adamk@chromium.org
  • 5 edits in trunk/Source

Fix includes in StrongInlines.h and ScriptValue.h
https://bugs.webkit.org/show_bug.cgi?id=84659

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • heap/StrongInlines.h: Include JSGlobalData.h, since JSGlobalData's

definiition is required here.

Source/WebCore:

This change was prompted by an attempt to use ScriptValue.h from a
WebCore header file and running into trouble with the (as it turns out
unnecessary) include of JSDOMBinding.h.

  • bindings/js/ScriptValue.cpp: Add include of JSDOMBinding.h, now that

it's not included by the header.

  • bindings/js/ScriptValue.h: Remove unnecessary include of JSDOMBinding.h.
8:27 AM Changeset in webkit [115060] by Antti Koivisto
  • 11 edits in trunk/Source/WebCore

Move MediaList CSSOM wrapper ownership to parent rule or stylesheet
https://bugs.webkit.org/show_bug.cgi?id=84716

Reviewed by Anders Carlsson.

MediaList CSSOM wrapper should be owned by a rule or a stylesheet, not by the underlying
MediaQuerySet.

Remove the ref forwarding from MediaList in favor of regular refcounting. Use the usual
pattern where the parent wrapper refs the child wrapper and zeroes the backpointer
on destruction.

  • bindings/js/JSDOMBinding.h:

(WebCore::root):

  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::~CSSImportRule):
(WebCore::CSSImportRule::media):

  • css/CSSImportRule.h:

(StyleRuleImport):
(CSSImportRule):

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::~CSSMediaRule):
(WebCore::CSSMediaRule::media):

  • css/CSSMediaRule.h:

(CSSMediaRule):

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::~CSSStyleSheet):
(WebCore::CSSStyleSheet::media):

  • css/CSSStyleSheet.h:

(CSSStyleSheet):

  • css/MediaList.cpp:

(WebCore::MediaQuerySet::mediaText):
(WebCore::MediaList::MediaList):
(WebCore):
(WebCore::MediaList::notifyChanged):

  • css/MediaList.h:

(MediaQuerySet):
(WebCore::MediaList::create):
(WebCore::MediaList::parentRule):
(WebCore::MediaList::clearParentStyleSheet):
(WebCore::MediaList::clearParentRule):
(WebCore::MediaList::queries):
(MediaList):

  • css/StyleRule.h:

(WebCore::StyleRuleMedia::mediaQueries):

8:27 AM Changeset in webkit [115059] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Tap-to zoom should navigate when appropiate
https://bugs.webkit.org/show_bug.cgi?id=84602

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-24
Reviewed by Simon Hausmann.

When a zoomable area is returned and has the same zoom-level as the current,
examine if the using this target would expose currently unexposed parts of
the zoom-target. If it does, pan to that area instead of zooming back.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):

8:25 AM Changeset in webkit [115058] by Carlos Garcia Campos
  • 4 edits in trunk

[GTK] Should pass canvas/philip/tests/toDataURL.jpeg.alpha.html
https://bugs.webkit.org/show_bug.cgi?id=83973

Reviewed by Philippe Normand.

Source/WebCore:

Test: canvas/philip/tests/toDataURL.jpeg.alpha.html

  • platform/graphics/gtk/ImageBufferGtk.cpp:

(WebCore::encodeImage): Convert ARGB32 cairo surface into RGB24
when encoding JPEG images since JPEG encoder doesn't support alpha
channel.

LayoutTests:

  • platform/gtk/test_expectations.txt: Unskip

canvas/philip/tests/toDataURL.jpeg.alpha.html

8:18 AM Changeset in webkit [115057] by Carlos Garcia Campos
  • 6 edits
    1 add in trunk/Source

[GTK] Add WebKitCookieManager::changed signal to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=82598

Reviewed by Philippe Normand.

Source/WebCore:

  • GNUmakefile.list.am: Add new files to compilation.
  • platform/gtk/TemporaryLinkStubs.cpp: Remove stubs for

setCookieStoragePrivateBrowsingEnabled,
startObservingCookieChanges and stopObservingCookieChanges.

  • platform/network/soup/CookieStorageSoup.cpp: Added.

(WebCore::setCookieStoragePrivateBrowsingEnabled):
(WebCore::soupCookiesChanged): Notify cookies changes using
platform strategies.
(WebCore::startObservingCookieChanges): Connect to changed signal
of the soup cookie jar.
(WebCore::stopObservingCookieChanges): Disconnect signals handlers
for changed signals of the soup cookie jar.

Source/WebKit2:

  • UIProcess/API/gtk/WebKitCookieManager.cpp:

(webkitCookieManagerFinalize): Stop observing cookie changes.
(webkit_cookie_manager_class_init): Add
WebKitCookieManager::changed signal.
(cookiesDidChange): Emit WebKitCookieManager::changed signal.
(webkitCookieManagerCreate): Implement WKCookieManagerClient and
start observing cookie changes.

  • UIProcess/API/gtk/tests/TestCookieManager.cpp:

(testCookieManagerCookiesChanged):
(beforeAll):

8:16 AM Changeset in webkit [115056] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-24

  • DEPS:
7:59 AM Changeset in webkit [115055] by alexis.menard@openbossa.org
  • 9 edits
    2 adds
    2 deletes in trunk/Source/WebCore

Rename CSSStyleApplyProperty files to StyleBuilder.
https://bugs.webkit.org/show_bug.cgi?id=84721

Reviewed by Antti Koivisto.

r115043 renamed CSSStyleApplyProperty class to StyleBuilder. This
patch rename the files to match the new class name.

No new tests : renaming of files, no behavior changes expected.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSAllInOne.cpp:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • css/StyleBuilder.cpp: Renamed from Source/WebCore/css/CSSStyleApplyProperty.cpp.

(WebCore):
(ApplyPropertyExpanding):
(WebCore::ApplyPropertyExpanding::applyInheritValue):
(WebCore::ApplyPropertyExpanding::applyInitialValue):
(WebCore::ApplyPropertyExpanding::applyValue):
(WebCore::ApplyPropertyExpanding::createHandler):
(ApplyPropertyDefaultBase):
(WebCore::ApplyPropertyDefaultBase::setValue):
(WebCore::ApplyPropertyDefaultBase::value):
(WebCore::ApplyPropertyDefaultBase::initial):
(WebCore::ApplyPropertyDefaultBase::applyInheritValue):
(WebCore::ApplyPropertyDefaultBase::applyInitialValue):
(WebCore::ApplyPropertyDefaultBase::applyValue):
(WebCore::ApplyPropertyDefaultBase::createHandler):
(ApplyPropertyDefault):
(WebCore::ApplyPropertyDefault::setValue):
(WebCore::ApplyPropertyDefault::applyValue):
(WebCore::ApplyPropertyDefault::createHandler):
(ApplyPropertyNumber):
(WebCore::ApplyPropertyNumber::setValue):
(WebCore::ApplyPropertyNumber::applyValue):
(WebCore::ApplyPropertyNumber::createHandler):
(ApplyPropertyStyleImage):
(WebCore::ApplyPropertyStyleImage::applyValue):
(WebCore::ApplyPropertyStyleImage::createHandler):
(ApplyPropertyAuto):
(WebCore::ApplyPropertyAuto::setValue):
(WebCore::ApplyPropertyAuto::value):
(WebCore::ApplyPropertyAuto::hasAuto):
(WebCore::ApplyPropertyAuto::setAuto):
(WebCore::ApplyPropertyAuto::applyInheritValue):
(WebCore::ApplyPropertyAuto::applyInitialValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyAuto::createHandler):
(ApplyPropertyClip):
(WebCore::ApplyPropertyClip::convertToLength):
(WebCore::ApplyPropertyClip::applyInheritValue):
(WebCore::ApplyPropertyClip::applyInitialValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyClip::createHandler):
(WebCore::defaultInitialColor):
(ApplyPropertyColor):
(WebCore::ApplyPropertyColor::applyInheritValue):
(WebCore::ApplyPropertyColor::applyInitialValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyColor::applyColorValue):
(WebCore::ApplyPropertyColor::createHandler):
(ApplyPropertyDirection):
(WebCore::ApplyPropertyDirection::applyValue):
(WebCore::ApplyPropertyDirection::createHandler):
(ApplyPropertyLength):
(WebCore::ApplyPropertyLength::setValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyLength::createHandler):
(ApplyPropertyString):
(WebCore::ApplyPropertyString::setValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyString::createHandler):
(ApplyPropertyBorderRadius):
(WebCore::ApplyPropertyBorderRadius::setValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyBorderRadius::createHandler):
(FillLayerAccessorTypes):
(ApplyPropertyFillLayer):
(WebCore::ApplyPropertyFillLayer::applyInheritValue):
(WebCore::ApplyPropertyFillLayer::applyInitialValue):
(WebCore::ApplyPropertyFillLayer::applyValue):
(WebCore::ApplyPropertyFillLayer::createHandler):
(ApplyPropertyComputeLength):
(WebCore::ApplyPropertyComputeLength::setValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyComputeLength::createHandler):
(ApplyPropertyFont):
(WebCore::ApplyPropertyFont::applyInheritValue):
(WebCore::ApplyPropertyFont::applyInitialValue):
(WebCore::ApplyPropertyFont::applyValue):
(WebCore::ApplyPropertyFont::createHandler):
(ApplyPropertyFontSize):
(WebCore::ApplyPropertyFontSize::largerFontSize):
(WebCore::ApplyPropertyFontSize::smallerFontSize):
(WebCore::ApplyPropertyFontSize::applyInheritValue):
(WebCore::ApplyPropertyFontSize::applyInitialValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyFontSize::createHandler):
(ApplyPropertyFontWeight):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontWeight::createHandler):
(ApplyPropertyFontVariantLigatures):
(WebCore::ApplyPropertyFontVariantLigatures::applyInheritValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyInitialValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyFontVariantLigatures::createHandler):
(ApplyPropertyBorderImage):
(WebCore::ApplyPropertyBorderImage::applyValue):
(WebCore::ApplyPropertyBorderImage::createHandler):
(ApplyPropertyBorderImageModifier):
(WebCore::ApplyPropertyBorderImageModifier::getValue):
(WebCore::ApplyPropertyBorderImageModifier::setValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInheritValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInitialValue):
(WebCore::ApplyPropertyBorderImageModifier::applyValue):
(WebCore::ApplyPropertyBorderImageModifier::createHandler):
(ApplyPropertyBorderImageSource):
(WebCore::ApplyPropertyBorderImageSource::applyValue):
(WebCore::ApplyPropertyBorderImageSource::createHandler):
(ApplyPropertyCounter):
(WebCore::ApplyPropertyCounter::emptyFunction):
(WebCore::ApplyPropertyCounter::applyInheritValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCounter::createHandler):
(ApplyPropertyCursor):
(WebCore::ApplyPropertyCursor::applyInheritValue):
(WebCore::ApplyPropertyCursor::applyInitialValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyCursor::createHandler):
(ApplyPropertyTextAlign):
(WebCore::ApplyPropertyTextAlign::applyValue):
(WebCore::ApplyPropertyTextAlign::createHandler):
(ApplyPropertyTextDecoration):
(WebCore::ApplyPropertyTextDecoration::applyValue):
(WebCore::ApplyPropertyTextDecoration::createHandler):
(ApplyPropertyUnicodeBidi):
(WebCore::ApplyPropertyUnicodeBidi::applyValue):
(WebCore::ApplyPropertyUnicodeBidi::createHandler):
(ApplyPropertyLineHeight):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyLineHeight::createHandler):
(ApplyPropertyPageSize):
(WebCore::ApplyPropertyPageSize::mmLength):
(WebCore::ApplyPropertyPageSize::inchLength):
(WebCore::ApplyPropertyPageSize::getPageSizeFromName):
(WebCore::ApplyPropertyPageSize::applyInheritValue):
(WebCore::ApplyPropertyPageSize::applyInitialValue):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyPageSize::createHandler):
(ApplyPropertyTextEmphasisStyle):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::createHandler):
(ApplyPropertyAnimation):
(WebCore::ApplyPropertyAnimation::setValue):
(WebCore::ApplyPropertyAnimation::value):
(WebCore::ApplyPropertyAnimation::test):
(WebCore::ApplyPropertyAnimation::clear):
(WebCore::ApplyPropertyAnimation::initial):
(WebCore::ApplyPropertyAnimation::map):
(WebCore::ApplyPropertyAnimation::accessAnimations):
(WebCore::ApplyPropertyAnimation::animations):
(WebCore::ApplyPropertyAnimation::applyInheritValue):
(WebCore::ApplyPropertyAnimation::applyInitialValue):
(WebCore::ApplyPropertyAnimation::applyValue):
(WebCore::ApplyPropertyAnimation::createHandler):
(ApplyPropertyOutlineStyle):
(WebCore::ApplyPropertyOutlineStyle::applyInheritValue):
(WebCore::ApplyPropertyOutlineStyle::applyInitialValue):
(WebCore::ApplyPropertyOutlineStyle::applyValue):
(WebCore::ApplyPropertyOutlineStyle::createHandler):
(ApplyPropertyResize):
(WebCore::ApplyPropertyResize::applyValue):
(WebCore::ApplyPropertyResize::createHandler):
(ApplyPropertyVerticalAlign):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyVerticalAlign::createHandler):
(ApplyPropertyAspectRatio):
(WebCore::ApplyPropertyAspectRatio::applyInheritValue):
(WebCore::ApplyPropertyAspectRatio::applyInitialValue):
(WebCore::ApplyPropertyAspectRatio::applyValue):
(WebCore::ApplyPropertyAspectRatio::createHandler):
(ApplyPropertyZoom):
(WebCore::ApplyPropertyZoom::resetEffectiveZoom):
(WebCore::ApplyPropertyZoom::applyInheritValue):
(WebCore::ApplyPropertyZoom::applyInitialValue):
(WebCore::ApplyPropertyZoom::applyValue):
(WebCore::ApplyPropertyZoom::createHandler):
(ApplyPropertyDisplay):
(WebCore::ApplyPropertyDisplay::isValidDisplayValue):
(WebCore::ApplyPropertyDisplay::applyInheritValue):
(WebCore::ApplyPropertyDisplay::applyInitialValue):
(WebCore::ApplyPropertyDisplay::applyValue):
(WebCore::ApplyPropertyDisplay::createHandler):
(ApplyPropertyFlex):
(WebCore::ApplyPropertyFlex::applyInheritValue):
(WebCore::ApplyPropertyFlex::applyInitialValue):
(WebCore::ApplyPropertyFlex::applyValue):
(WebCore::ApplyPropertyFlex::createHandler):
(WebCore::ApplyPropertyFlex::getFlexValue):
(WebCore::StyleBuilder::sharedStyleBuilder):
(WebCore::StyleBuilder::StyleBuilder):

  • css/StyleBuilder.h: Renamed from Source/WebCore/css/CSSStyleApplyProperty.h.

(WebCore):
(PropertyHandler):
(WebCore::PropertyHandler::PropertyHandler):
(WebCore::PropertyHandler::applyInheritValue):
(WebCore::PropertyHandler::applyInitialValue):
(WebCore::PropertyHandler::applyValue):
(WebCore::PropertyHandler::isValid):
(WebCore::PropertyHandler::inheritFunction):
(WebCore::PropertyHandler::initialFunction):
(WebCore::PropertyHandler::applyFunction):
(StyleBuilder):
(WebCore::StyleBuilder::propertyHandler):
(WebCore::StyleBuilder::index):
(WebCore::StyleBuilder::valid):
(WebCore::StyleBuilder::setPropertyHandler):

7:51 AM Changeset in webkit [115054] by mnaganov@chromium.org
  • 2 edits in trunk/Tools

[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84726

Mark webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_start_cmd as failing on Windows.

  • Scripts/webkitpy/test/test_finder.py:

(TestFinder._default_names):

7:49 AM Changeset in webkit [115053] by fmalita@chromium.org
  • 3 edits
    2 adds in trunk

WebCore::EventTarget::addEventListener crash
https://bugs.webkit.org/show_bug.cgi?id=84171

Source/WebCore:

Reviewed by Nikolas Zimmermann.

Test: svg/custom/use-tref-crash.svg

Adding tref target event listeners while building the shadow tree is
problematic, because SVGUseElement::buildShadowAndInstanceTree() only
sets the element instance<->shadow element association at a later time.

Fortunately, buildShadowAndInstanceTree() also propagates the event
handlers (transferEventListenersToShadowTree) - so we can simply skip
them in SVGTRefElement::buildPendingResource() for shadow elements.

  • svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::buildPendingResource):

LayoutTests:

Reviewed by Nikolas Zimmermann.

  • svg/custom/use-tref-crash-expected.txt: Added.
  • svg/custom/use-tref-crash.svg: Added.
7:47 AM Changeset in webkit [115052] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Clickable area of a calendar picker indicator is too small.
https://bugs.webkit.org/show_bug.cgi?id=84677

Reviewed by Kentaro Hara.

Test: fast/forms/date/date-appearance.html is affected.

  • css/html.css:

(input::-webkit-calendar-picker-indicator):

  • Remove unnecessary disaplay:inline-block.
  • Add paddings instead of the margin.

(input::-webkit-calendar-picker-indicator:hover):
Add hover style.

7:29 AM Changeset in webkit [115051] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84724

Mark platform/chromium/media/video-frame-size-change.html as flaky on Mac 10.6.

  • platform/chromium/test_expectations.txt:
7:22 AM Changeset in webkit [115050] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update.
http://crbug.com/31623

Mark http/tests/appcache/remove-cache.html as flaky on Mac 10.6.

  • platform/chromium/test_expectations.txt:
7:16 AM Changeset in webkit [115049] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84720

Mark fast/repaint/fixed-right-in-page-scale.html as flaky in debug mode.

  • platform/chromium/test_expectations.txt:
7:09 AM Changeset in webkit [115048] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84719

Mark svg/text/select-text-svgfont.html as flaky on Windows.

  • platform/chromium/test_expectations.txt:
6:50 AM Changeset in webkit [115047] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

Another unreviewed build fix for Mac.

  • css/CSSStyleSelector.h:

(CSSStyleSelector):

6:48 AM Changeset in webkit [115046] by commit-queue@webkit.org
  • 6 edits in trunk

[EFL] Enable Web Timing
https://bugs.webkit.org/show_bug.cgi?id=84705

Patch by Christophe Dumez <Christophe Dumez> on 2012-04-24
Reviewed by Tony Gentilcore.

.:

Enable Web Timing in EFL port for for performance profiling and
improvement.

  • Source/cmake/OptionsEfl.cmake:

Tools:

Enable web timing by default whenever build-webkit is used.

  • Scripts/build-webkit:

LayoutTests:

Unskip the test cases that require Web Timing now that it is enabled
by default in EFL port.

  • platform/efl/Skipped:
6:44 AM Changeset in webkit [115045] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix attempt for Mac.

  • rendering/style/RenderStyle.h:
6:28 AM Changeset in webkit [115044] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=65063

Unmark as failing on Mac 10.6 css2.1/t0905-c414-flt-01-d-g.html.

  • platform/chromium/test_expectations.txt:
6:28 AM Changeset in webkit [115043] by alexis.menard@openbossa.org
  • 5 edits in trunk/Source/WebCore

Rename CSSStyleApplyProperty class to StyleBuilder.
https://bugs.webkit.org/show_bug.cgi?id=84711

Reviewed by Antti Koivisto.

As per discussion on bug https://bugs.webkit.org/show_bug.cgi?id=42764
the name is a bit confusing. This first patch rename the class and a
following one will rename the files. We also drop the CSS prefix of the
class to keep CSS prefixed classes for CSSOM types.

No new tests : renaming, no behavior changes should appear.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyExpanding::applyInheritValue):
(WebCore::ApplyPropertyExpanding::applyInitialValue):
(WebCore::ApplyPropertyExpanding::applyValue):
(WebCore::StyleBuilder::sharedStyleBuilder):
(WebCore::StyleBuilder::StyleBuilder):

  • css/CSSStyleApplyProperty.h:

(WebCore):
(StyleBuilder):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • css/CSSStyleSelector.h:

(CSSStyleSelector):

6:21 AM Changeset in webkit [115042] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update.

Unmark as failing on Mac 10.5 the following tests:

fast/backgrounds/size/backgroundSize15.html
fast/events/reveal-link-when-focused.html
fast/frames/content-opacity-1.html
fast/frames/content-opacity-2.html
fast/xsl/xslt-extra-content-at-end.xml
printing/return-from-printing-mode.html

  • platform/chromium/test_expectations.txt:
6:03 AM Changeset in webkit [115041] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=82628

Unmark svg/hittest/svg-ellipse-non-scale-stroke.xhtml -- passes for a long time.

  • platform/chromium/test_expectations.txt:
5:56 AM Changeset in webkit [115040] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=75161

Unmark media/video-poster-blocked-by-willsendrequest.html -- fails no more after FFmpeg roll 132717:133551 in Chromium.

  • platform/chromium/test_expectations.txt:
5:49 AM Changeset in webkit [115039] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewe