Timeline



May 5, 2012:

10:27 PM Changeset in webkit [116233] by barraclough@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Remove TrustedImm32::m_isPointer
https://bugs.webkit.org/show_bug.cgi?id=85726

Rubber stamped by Sam Weinig.

We used to rely on being able to generate code with known, fixed offsets – to do so we
would inhibit more optimal code generation for pointers. This is no longer necessary.

  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::TrustedImm32::TrustedImm32):
(TrustedImm32):

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::store32):
(JSC::MacroAssemblerARM::move):
(JSC::MacroAssemblerARM::branch32):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::move):

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::add32):
(JSC::MacroAssemblerMIPS::and32):
(JSC::MacroAssemblerMIPS::mul32):
(JSC::MacroAssemblerMIPS::or32):
(JSC::MacroAssemblerMIPS::sub32):
(JSC::MacroAssemblerMIPS::store32):
(JSC::MacroAssemblerMIPS::move):

4:04 PM Changeset in webkit [116232] by commit-queue@webkit.org
  • 7 edits in trunk

Unreviewed, rolling out r116221.
http://trac.webkit.org/changeset/116221
https://bugs.webkit.org/show_bug.cgi?id=85722

broke builds that use -Wshorten-64-to-32 (Requested by pizlo
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-05

Source/WebCore:

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::bufferData):
(WebCore::WebGLRenderingContext::bufferSubData):
(WebCore::WebGLRenderingContext::drawElements):
(WebCore::WebGLRenderingContext::getVertexAttribOffset):
(WebCore::WebGLRenderingContext::vertexAttribPointer):

  • html/canvas/WebGLRenderingContext.h:

(WebGLRenderingContext):

  • html/canvas/WebGLRenderingContext.idl:

LayoutTests:

  • fast/canvas/webgl/index-validation-expected.txt:
  • fast/canvas/webgl/index-validation.html:
2:41 PM Changeset in webkit [116231] by kov@webkit.org
  • 5 edits in trunk/Source

[GTK] WebKit should properly set the input method context window location
https://bugs.webkit.org/show_bug.cgi?id=84981

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-05-05
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

  • platform/gtk/GtkInputMethodFilter.cpp:

(WebCore::GtkInputMethodFilter::setCursorRect): Add this method to plumb the
cursor rect through to the input method.

  • platform/gtk/GtkInputMethodFilter.h: Add the new method declaration.

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::paint): During painting, update the cursor rectangle
if possible.

2:38 PM Changeset in webkit [116230] by dino@apple.com
  • 27 edits
    3 adds in trunk

Add new Setting/Preference to disable requestAnimationFrame
https://bugs.webkit.org/show_bug.cgi?id=85693

Reviewed by Simon Fraser.

Source/WebCore:

Hook up the new WebPreference for disabling requestAnimationFrame
to Settings. This isn't disabling the feature in the typical
WebKit ENABLE() way - it's still available in the DOM, it's
just that the animations will never be serviced. This allows a client
to disable the machinery without breaking content (other than the
animations).

The new test is currently skipped on all platforms because toggling
the preference interferes with the other tests that are running
at the same time (and expect a working requestAnimationFrame).
https://bugs.webkit.org/show_bug.cgi?id=85689

Test: fast/animation/request-animation-frame-disabled.html

  • dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
(WebCore::ScriptedAnimationController::windowScreenDidChange):
(WebCore::ScriptedAnimationController::scheduleAnimation):
Check the setting before deciding to act.

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setRequestAnimationFrameEnabled):
(WebCore::Settings::requestAnimationFrameEnabled):
(Settings):

Source/WebKit/mac:

Exposes a new WebPreference: WebKitRequestAnimationFrameEnabled.
The default value is true. The majority of applications will leave
it this way.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences requestAnimationFrameEnabled]):
(-[WebPreferences setRequestAnimationFrameEnabled:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit/win:

Exposes a new WebPreference: WebKitRequestAnimationFrameEnabled.
The default value is true. The majority of applications will leave
it this way.

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::setRequestAnimationFrameEnabled):
(WebPreferences::requestAnimationFrameEnabled):

  • WebPreferences.h:

(WebPreferences):

  • WebView.cpp:

(WebView::notifyPreferencesChanged):

Source/WebKit2:

Exposes a new WebPreference: WebKitRequestAnimationFrameEnabled.
The default value is true. The majority of applications will leave
it this way.

  • Shared/WebPreferencesStore.h:

(WebKit):

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetRequestAnimationFrameEnabled):
(WKPreferencesGetRequestAnimationFrameEnabled):

  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

LayoutTests:

A new test that exercises turning the requestAnimationFrame
preference off. Unfortunately this conflicts with the parallel
tests that expect the preference to be on (as it should by default),
so the test is skipped on all platforms. It can be run in isolation.
https://bugs.webkit.org/show_bug.cgi?id=85689

  • fast/animation/request-animation-frame-disabled-expected.txt: Added.
  • fast/animation/request-animation-frame-disabled.html: Added.
  • fast/animation/script-tests/request-animation-frame-disabled.js: Added.
  • platform/chromium/test_expectations.txt:
  • platform/efl/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/Skipped:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
  • platform/win/Skipped:
  • platform/win/test_expectations.txt:
2:08 PM Changeset in webkit [116229] by rakuco@webkit.org
  • 2 edits in trunk/Tools

webkitpy: Use os.pathsep instead of manually finding out the path separator in NRWT.
https://bugs.webkit.org/show_bug.cgi?id=85697

Reviewed by Eric Seidel.

  • Scripts/new-run-webkit-tests: Instead of manually detecting whether

the path separator should be ':' or ';' by checking sys.platform, rely
on os.pathsep which has exactly the same information (os.pathsep is
':' for Cygwin, from what I could check in Python's sources).

2:00 PM Changeset in webkit [116228] by kov@webkit.org
  • 4 edits in trunk

Unreviewed preparation for 1.9.2.

  • configure.ac: bump version to 1.9.2 and bump libtool version.

Source/WebKit/gtk:

  • NEWS: changes from 1.9.1.
1:59 PM Changeset in webkit [116227] by kov@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, make distcheck fix.

Source/WebCore:

  • GNUmakefile.list.am: Add missing headers to the sources list.
12:38 PM Changeset in webkit [116226] by jonlee@apple.com
  • 3 edits in trunk/Source/WebKit2

[WK2] Incoming events may be processed out-of-order
https://bugs.webkit.org/show_bug.cgi?id=85696
<rdar://problem/11386129>

Reviewed by Maciej Stachowiak.

All messages go to a single queue that gets iterated over by dispatchMessages(). If an input
event arrives in the middle of a flood of messages, all of them will be dispatched before the
input event is dispatched.

In other words, the first dispatchMessages() call will process all of the messages in the queue,
and all subsequent dispatchMessages() calls will act as no-ops, since there is nothing in the queue.

To fix this, we rename dispatchMessages to dispatchOneMessage, and only process one message at a
time.

  • Platform/CoreIPC/Connection.h: Rename dispatchMessages() to dispatchOneMessage().
  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::enqueueIncomingMessage): Dispatch a call to dispatchOneMessage() on the
run loop.
(CoreIPC::Connection::dispatchOneMessage): Remove the while(true) loop.

10:05 AM Changeset in webkit [116225] by loislo@chromium.org
  • 2 edits in trunk/PerformanceTests

Web Inspector: unreviewed followup fix for the performance test after r116218.

  • inspector/heap-snapshot.html:
9:54 AM Changeset in webkit [116224] by rakuco@webkit.org
  • 3 edits in trunk/Tools

Unreviewed, rolling out r116223.
http://trac.webkit.org/changeset/116223
https://bugs.webkit.org/show_bug.cgi?id=85718

The bots need to set XDG_DATA_DIRS (Requested by rakuco on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-05

  • efl/jhbuildrc:
  • gtk/jhbuildrc:
9:34 AM Changeset in webkit [116223] by rakuco@webkit.org
  • 3 edits in trunk/Tools

[jhbuild] Do not set XDG_DATA_DIRS in jhbuildrc.
https://bugs.webkit.org/show_bug.cgi?id=85717

Reviewed by Martin Robinson.

After r116209, the XDG_DATA_DIRS environment variable is now
passed by webkitpy's layout_tests code to run-with-jhbuild, so
instead of setting a few defaults in jhbuildrc we can now rely on
the values set and really used by each system.

  • efl/jhbuildrc:
  • gtk/jhbuildrc:
8:33 AM Changeset in webkit [116222] by loislo@chromium.org
  • 15 edits
    1 add in trunk/Source/WebCore

Web Inspector: convert standalone functions save/append/savedURL/appendedToURL into WebInspector.FileManager object.
https://bugs.webkit.org/show_bug.cgi?id=85710

The idea is to have an object and be able to add/remove event listeners from it.

Reviewed by Yury Semikhatsky.

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/FileManager.js: Copied from Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js.

(WebInspector.FileManager):
(WebInspector.FileManager.prototype.canSave):
(WebInspector.FileManager.prototype.canAppend):
(WebInspector.FileManager.prototype.append):
(WebInspector.FileManager.prototype.appendedToURL):

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapProfileHeader.prototype.canSave):
(WebInspector.HeapProfileHeader.prototype.save):

  • inspector/front-end/InspectorFrontendHostStub.js:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
7:51 AM Changeset in webkit [116221] by zmo@google.com
  • 7 edits in trunk

vertexAttribPointer needs to reject large negative offsets
https://bugs.webkit.org/show_bug.cgi?id=85117

Reviewed by Kenneth Russell.

Source/WebCore:

  • html/canvas/WebGLRenderingContext.cpp: Use long long for GLsizeiptr and GLintptr

(WebCore):
(WebCore::WebGLRenderingContext::bufferData):
(WebCore::WebGLRenderingContext::bufferSubData):
(WebCore::WebGLRenderingContext::drawElements):
(WebCore::WebGLRenderingContext::getVertexAttribOffset):
(WebCore::WebGLRenderingContext::vertexAttribPointer):

  • html/canvas/WebGLRenderingContext.h: Ditto

(WebGLRenderingContext):

  • html/canvas/WebGLRenderingContext.idl: Ditto

LayoutTests:

  • fast/canvas/webgl/index-validation-expected.txt:
  • fast/canvas/webgl/index-validation.html: Add a test case for large negative offset.
5:24 AM Changeset in webkit [116220] by caseq@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: add separate timeline overview item for the frame mode
https://bugs.webkit.org/show_bug.cgi?id=85706

  • remove two-buttons horizontal/vertical mode switch from Timelines item of the timeline overview menu;
  • rename "Timeline" into "Events";
  • add "Frames" item;
  • replace overview sidebar icons with smaller, monochrome ones.
  • English.lproj/localizedStrings.js: Added "Frames" and "Events".
  • inspector/front-end/Images/statusbarButtonGlyphs.png: Added icon for "Memory".
  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype._showEvents):
(WebInspector.TimelineOverviewPane.prototype._showFrames):
(WebInspector.TimelineOverviewPane.prototype._showMemoryGraph):
(WebInspector.TimelineOverviewPane.prototype._setMode):

  • inspector/front-end/timelinePanel.css:

(#timeline-overview-sidebar .sidebar-tree-item):
(#timeline-overview-sidebar .sidebar-tree-item .titles.no-subtitle):
(#timeline-overview-sidebar .icon):
(.timeline-overview-sidebar-events .icon):
(.timeline-overview-sidebar-frames .icon):
(.timeline-overview-sidebar-memory .icon):

3:25 AM Changeset in webkit [116219] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

Not reviewed: follow up to r116216, fixing the inspector test.

  • inspector/debugger/script-extract-outline.html:
  • inspector/debugger/script-extract-outline-expected.txt:
3:23 AM Changeset in webkit [116218] by loislo@chromium.org
  • 8 edits in trunk

Web Inspector: save HeapSnapshot implementation.
https://bugs.webkit.org/show_bug.cgi?id=85595

HeapSnapshot specific implementation for loading was moved
from ProfilesPanel to HeapProfileHeader class.

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotView.prototype.get profileWrapper):
(WebInspector.HeapSnapshotView.prototype.get baseProfileWrapper):
(WebInspector.HeapProfileHeader):
(WebInspector.HeapProfileHeader.prototype.load.setProfileWait):
(WebInspector.HeapProfileHeader.prototype.load.done):
(WebInspector.HeapProfileHeader.prototype.load):
(WebInspector.HeapProfileHeader.prototype._saveStatusUpdate):
(WebInspector.HeapProfileHeader.prototype.pushJSONChunk):
(WebInspector.HeapProfileHeader.prototype.finishHeapSnapshot):
(WebInspector.HeapProfileHeader.prototype.canSave):
(WebInspector.HeapProfileHeader.prototype.save):

  • inspector/front-end/InspectorFrontendAPI.js:

(InspectorFrontendAPI.appendedToURL):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype._registerProfileType):
(WebInspector.ProfilesPanel.prototype._handleContextMenuEvent):
(WebInspector.ProfilesPanel.prototype.loadHeapSnapshot):
(WebInspector.ProfilesPanel.prototype._addHeapSnapshotChunk):
(WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
(WebInspector.ProfileSidebarTreeElement.prototype.set searchMatches):
(WebInspector.ProfileSidebarTreeElement.prototype.handleContextMenuEvent):

  • inspector/front-end/inspector.js:

(WebInspector.append):
(WebInspector.appendedToURL):

LayoutTests:

  • inspector/profiler/heap-snapshot-inspect-dom-wrapper.html:
  • inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest):

3:07 AM Changeset in webkit [116217] by pfeldman@chromium.org
  • 5 edits in trunk

Web Inspector: allow overriding the script mapping on the UI level
https://bugs.webkit.org/show_bug.cgi?id=85702

Reviewed by Yury Semikhatsky.

Source/WebCore:

This allows formatting update live locations all over the place automatically.

  • inspector/front-end/Script.js:

(WebInspector.Script.prototype.rawLocationToUILocation):
(WebInspector.Script.Location):
(WebInspector.Script.Location.prototype.update):
(WebInspector.Script.Location.prototype.dispose):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.addLiveLocation):
(WebInspector.UISourceCode.prototype.removeLiveLocation):
(WebInspector.UISourceCode.prototype.updateLiveLocations):
(WebInspector.UISourceCode.prototype.overrideLocation):

LayoutTests:

  • inspector/debugger/breakpoint-manager.html:
2:46 AM Changeset in webkit [116216] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: simplify the JavaScriptOutline dialog interaction.
https://bugs.webkit.org/show_bug.cgi?id=85701

Reviewed by Yury Semikhatsky.

Removed bidirectional dependency between scripts panel and outline dialog.

  • inspector/front-end/FilteredItemSelectionDialog.js:

(WebInspector.JavaScriptOutlineDialog):
(WebInspector.JavaScriptOutlineDialog.show):
(WebInspector.JavaScriptOutlineDialog.prototype.requestItems):
(WebInspector.JavaScriptOutlineDialog.prototype._didBuildOutlineChunk):
(WebInspector.JavaScriptOutlineDialog.prototype.selectItem):

  • inspector/front-end/ScriptFormatterWorker.js:
  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.addToWatch):
(WebInspector.ScriptsPanel.prototype._showJavaScriptOutlineDialog):

2:38 AM Changeset in webkit [116215] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt] Buildfix for --minimal build after r116107.

Patch by Tor Arne Vestbø <tor.arne.vestbo@nokia.com> on 2012-05-05
Reviewed by Csaba Osztrogonác.

  • qmake/mkspecs/features/features.prf:
12:46 AM Changeset in webkit [116214] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed Gtk gardening, mark fullscreen/non-ancestor-iframe.html as
failing after it was added in r116165.

  • platform/gtk/test_expectations.txt:
12:43 AM Changeset in webkit [116213] by caseq@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed. Rebaseline fast/events/attribute-listener-deletion-crash.html (added in r116191).

  • platform/chromium/fast/events/attribute-listener-deletion-crash-expected.txt: Added.
12:34 AM Changeset in webkit [116212] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

[Gtk] GtkDriver is not required anymore after r116134
https://bugs.webkit.org/show_bug.cgi?id=85699

Reviewed by Csaba Osztrogonác.

Remove GtkDriver as it was replaced by the XvfbDriver and is
no longer needed.

  • Scripts/webkitpy/layout_tests/port/gtk.py:
12:25 AM Changeset in webkit [116211] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

Increase the display ID for the Xvfb process to use if pixel_tests argument
is true rather than if pixel_tests option is present. This fixes the
XvfbDriver in the same way r115825 fixed the now-redundant GtkDriver.

Rubber-stamped by Csaba Osztrogonác.

  • Scripts/webkitpy/layout_tests/port/xvfbdriver.py:

(XvfbDriver._start):

May 4, 2012:

11:52 PM Changeset in webkit [116210] by loislo@chromium.org
  • 8 edits in trunk/Source/WebCore

Web Inspector: annotate ProfilerAgent.
https://bugs.webkit.org/show_bug.cgi?id=85630

Reviewed by Pavel Feldman.

  • inspector/Inspector.json:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::createProfileHeader):
(WebCore::InspectorProfilerAgent::createSnapshotHeader):
(WebCore::InspectorProfilerAgent::getProfileHeaders):
(WebCore):
(WebCore::InspectorProfilerAgent::getProfile):

  • inspector/InspectorProfilerAgent.h:

(InspectorProfilerAgent):

  • inspector/front-end/CSSSelectorProfileView.js:
  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotProfileType.prototype.createProfile):

  • inspector/front-end/ProfileView.js:
  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype.addProfileHeader):
(WebInspector.ProfilesPanel.prototype._addHeapSnapshotChunk):
(WebInspector.ProfilerDispatcher.prototype.resetProfiles):

10:48 PM Changeset in webkit [116209] by rakuco@webkit.org
  • 2 edits in trunk/Tools

webkitpy: Preserve XDG_DATA_DIRS in the environment passed to ServerProcess.
https://bugs.webkit.org/show_bug.cgi?id=85694

Reviewed by Martin Robinson.

This is sort of a follow-up to r100674: $XDG_DATA_DIRS should be
preserved, as it is particularly useful for Linux/Unix
environments. As a real use case, if shared-mime-info is
installed into a non-trivial prefix, Glib and other libraries will
have trouble to properly identify mimetypes (in ResourceResponses,
for example) as the base freedesktop.org mimetype file will not be
found.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.to.setup_environ_for_server):

9:26 PM Changeset in webkit [116208] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening, unskip test after r116097.

The test was unskipped from Skipped, but some other commit added it to
test_expectations.txt as well...

  • platform/efl/test_expectations.txt:
9:26 PM Changeset in webkit [116207] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening; skip tests that depend on beginDragWithFiles.

  • platform/efl/Skipped:
8:56 PM Changeset in webkit [116206] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed, rebaseline after r116009.

  • platform/efl/fast/block/float/float-not-removed-from-next-sibling4-expected.txt:
8:35 PM Changeset in webkit [116205] by kov@webkit.org
  • 8 edits in trunk

[GTK] Simplify how libWebCoreModules is linked in, and fix WebKit2 build
https://bugs.webkit.org/show_bug.cgi?id=85691

Source/WebCore:

  • GNUmakefile.am: link libWebCoreModules into libWebCore.

Source/WebKit/gtk:

  • GNUmakefile.am: no longer link libwebkitgtk to libWebCoreModules.

Source/WebKit2:

  • GNUmakefile.am: no longer link libWebCoreModules, and remove -no-

fast-install and -no-install from link flags, since we want those
programs installed.

Tools:

  • GNUmakefile.am: no longer link libWebCoreModules to DumpRenderTree.
7:54 PM Changeset in webkit [116204] by tkent@chromium.org
  • 6 edits
    2 moves in trunk/Source

Rename ICULocale to LocaleICU, part 1
https://bugs.webkit.org/show_bug.cgi?id=85688

Reviewed by Kentaro Hara.

Source/WebCore:

Rename it for consistency. Our convention is Foo<Platform>.{cpp,h}.
This patch changes only file names. We'll rename ICULocale class
by a following patch.

No behavior changes.

  • WebCore.gypi:
  • platform/text/LocaleICU.cpp: Renamed from Source/WebCore/platform/text/ICULocale.cpp.
  • platform/text/LocaleICU.h: Renamed from Source/WebCore/platform/text/ICULocale.h.
  • platform/text/LocalizedDateICU.cpp: Rename ICULocale.h to LocaleICU.h.
  • platform/text/LocalizedNumberICU.cpp: ditto.

Source/WebKit/chromium:

  • tests/LocalizedNumberICUTest.cpp: Rename ICULocale.h to LocaleICU.h.
7:17 PM Changeset in webkit [116203] by jchaffraix@webkit.org
  • 2 edits in trunk/Source/WebCore

Leaf non self-painting layers should bail out early in RenderLayer::paintLayer
https://bugs.webkit.org/show_bug.cgi?id=85678

Reviewed by Darin Adler.

Performance optimization, no expected change in behavior.

The gist of the change is that leaf non self-painting layers don't need to be painted as their
associated RenderBoxModelObject should properly paint itself without any help.

For RenderLayer trees that have a large number of leafs nodes (like a table with a leaf RenderLayer for
each cells), not bailing out is a big overhead as it ends up doing a lot of computation for no real
painting. See http://dglazkov.github.com/performance-tests/biggrid.html for a benchmark for that. On
my machine, it reduces the paint time when scrolling to 70ms from 120ms (45% speedup).

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayer):

6:43 PM Changeset in webkit [116202] by rwlbuis@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove InlineBox::next()
https://bugs.webkit.org/show_bug.cgi?id=85668

Reviewed by Nikolas Zimmermann.

InlineBox::next() not needed since nextOnLine() does the same.

  • rendering/InlineBox.h:

(InlineBox):

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::setConstructed):

6:28 PM Changeset in webkit [116201] by crogers@google.com
  • 10 edits
    1 add in trunk

Oscillator must implement noteOn() and noteOff()
https://bugs.webkit.org/show_bug.cgi?id=85236

Reviewed by Kenneth Russell.

Source/WebCore:

Test: webaudio/oscillator-scheduling.html
to be landed separately to get proper platform baselines

  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::process):
Simplify/remove zeroing-out silence at end of buffer, since it's now handled in the base-class AudioScheduledSourceNode::updateSchedulingInfo().

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::createBufferSource):
Improve comment about ownership and dynamic-lifetime of AudioBufferSourceNode.

(WebCore::AudioContext::createOscillator):
AudioContext keeps a reference to the Oscillator and that reference is released in AudioScheduledSourceNode,
when it has finished playing.

  • Modules/webaudio/AudioScheduledSourceNode.h:
  • Modules/webaudio/AudioScheduledSourceNode.cpp:

(WebCore::AudioScheduledSourceNode::updateSchedulingInfo):
updateSchedulingInfo() is now responsible for zeroing out the very start (before a note starts)
and the very end (after note ends) of the output AudioBus. We've also simplified the number
of arguments passed to this method, because of this. It now handles playbackState transition to FINISHED_STATE.

  • Modules/webaudio/Oscillator.cpp:

(WebCore::Oscillator::Oscillator):
(WebCore::Oscillator::calculateSampleAccuratePhaseIncrements):
The frequency value needs to snap immediately to its correct value the very first time.
This bug needs to be fixed here so that the Oscillator layout scheduling test works correctly.

(WebCore::Oscillator::process):
Since Oscillator in now changing to be a AudioScheduledSourceNode, we need to call AudioScheduledSourceNode::updateSchedulingInfo()
to handle playbackState for us.

(WebCore::Oscillator::propagatesSilence):
Add scheduling logic for propagatesSilence().

(Oscillator):

  • Modules/webaudio/Oscillator.idl:

Add noteOn(), noteOff() methods and playbackState according to specification.

LayoutTests:

  • webaudio/oscillator-scheduling-expected.wav: Added.
  • webaudio/resources/oscillator-testing.js:

(generateExponentialOscillatorSweep):

6:17 PM Changeset in webkit [116200] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix a leak in WebProcess when it is used to launch the UI process.

Rubber-stamped by Anders Carlsson.

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain): Destory the attributes and file actions after
spawning the subprocess.

6:12 PM Changeset in webkit [116199] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/blackberry

[Blackberry] Implement over-scroll background image
https://bugs.webkit.org/show_bug.cgi?id=85538

Patch by Andrew Lo <anlo@rim.com> on 2012-05-04
Reviewed by Rob Buis.

Use over-scroll image when set instead of the solid colour.
Internal PR146652

  • Api/BackingStore.cpp:

(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::ensureOverScrollImage):
(BlackBerry::WebKit::BackingStorePrivate::paintDefaultBackground):

  • Api/BackingStore_p.h:

(BackingStorePrivate):

  • Api/WebSettings.cpp:

(WebKit):
(BlackBerry::WebKit::WebSettings::standardSettings):
(BlackBerry::WebKit::WebSettings::overScrollImagePath):
(BlackBerry::WebKit::WebSettings::setOverScrollImagePath):

  • Api/WebSettings.h:
5:54 PM Changeset in webkit [116198] by aestes@apple.com
  • 8 edits in trunk/Source/WebCore

Remove uses of ASSERT(false)
https://bugs.webkit.org/show_bug.cgi?id=85686

Reviewed by Dean Jackson.

Replace uses of ASSERT(false) with ASSERT_NOT_REACHED(). Also, in two places, there was code structured like:

if (expr) {

do something

} else {

ASSERT(false);

}

Replace this with:

ASSERT(expr);
if (!expr)

return;

do something

  • Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::deleteOrigin):
(WebCore::DatabaseTracker::doneCreatingDatabase):
(WebCore::DatabaseTracker::doneDeletingDatabase):
(WebCore::DatabaseTracker::deleteDatabase):

  • bridge/objc/objc_instance.mm:

(ObjcInstance::invokeObjcMethod):

  • bridge/objc/objc_utility.mm:

(JSC::Bindings::convertObjcValueToValue):
(JSC::Bindings::objcValueTypeForType):

  • dom/Node.cpp:

(WebCore::Node::createRenderer):

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::setIconURLForPageURLInSQLDatabase):
(WebCore::IconDatabase::setIconIDForPageURLInSQLDatabase):

  • platform/graphics/GraphicsContext3D.cpp:

(WebCore::doPacking):

  • platform/text/BidiResolver.h:

(WebCore::::createBidiRunsForLine):

5:54 PM Changeset in webkit [116197] by commit-queue@webkit.org
  • 7 edits
    1 move
    2 adds
    1 delete in trunk/LayoutTests

Rebaseline chromium after r116069 (bug 85031)
https://bugs.webkit.org/show_bug.cgi?id=85626

Patch by David Barr <davidbarr@chromium.org> on 2012-05-04
Reviewed by Ojan Vafai.

  • fast/block/float/016-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/float/016-expected.txt.
  • platform/chromium-linux/fast/block/float/016-expected.png:
  • platform/chromium-linux/fast/css/border-solid-single-edge-antialias-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/016-expected.png:
  • platform/chromium-mac-snowleopard/fast/block/float/016-expected.png:
  • platform/chromium-mac/fast/block/float/016-expected.png:
  • platform/chromium-win/fast/block/float/016-expected.png:
  • platform/chromium-win/fast/css/border-solid-single-edge-antialias-expected.png: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/block/float/016-expected.txt: Removed.
5:49 PM Changeset in webkit [116196] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

[CG] Minor refactor of ImageBuffer::CGImageToDataURL and its callers
https://bugs.webkit.org/show_bug.cgi?id=85280

Reviewed by Kenneth Russell.

This patch means to simplify the diff of an upcoming patch. Refactoring
here in preparation for that patch.

No new tests. No behavioral change. Covered by canvas 2d and 3d tests:

canvas/philip/tests/*toDataURL*.html
fast/canvas/webgl/premultiplyalpha-test.html

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::CGImageToDataURL): Move the invalid image (!image) test here.
The comments are about JPEG images; say that. Rename out to base64Data.
(WebCore::ImageBuffer::toDataURL): Remove the !image test.
(WebCore::ImageDataToDataURL): Move and define variables where used and
make the code flow read similarly to toDataURL. Remove the !image test.

5:38 PM Changeset in webkit [116195] by shawnsingh@chromium.org
  • 7 edits in trunk/Source

[chromium] Changes to layer tree structure need to be tracked properly
https://bugs.webkit.org/show_bug.cgi?id=85421

Reviewed by Adrienne Walker.

Unit test added: TreeSynchronizerTest.syncSimpleTreeAndTrackStackingOrderChange

Source/WebCore:

Earlier, we were relying on WebCore behavior that always called
setNeedsDisplay whenever the layer tree structure changed.
However, in general it is more correct to consider layer tree
changes even when things don't need repainting; for example Aura
code is encountring this bug now. This patch corrects the
compositor so that layer tree structural changes are considered
property changes, without requiring that layers needed to be
repainted.

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::insertChild):
(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::setStackingOrderChanged):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):

Source/WebKit/chromium:

  • tests/TreeSynchronizerTest.cpp:

(WebKitTests):
(WebKitTests::TEST):

5:10 PM Changeset in webkit [116194] by jpfau@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed; build fix after r116191.

  • bindings/js/JSEventListener.h:
5:04 PM Changeset in webkit [116193] by eric@webkit.org
  • 2 edits in trunk/Tools

Make capitalization and descriptions in FeatureList.pm more consistent to make easier to autogenerate
https://bugs.webkit.org/show_bug.cgi?id=85583

Reviewed by Daniel Bates.

  • Scripts/webkitperl/FeatureList.pm:
4:55 PM Changeset in webkit [116192] by enrica@apple.com
  • 5 edits
    2 adds in trunk

REGRESSION: Cursor jumps to the first line after deleting the last word.
https://bugs.webkit.org/show_bug.cgi?id=85334
<rdar://problem/11210059>

Reviewed by Ryosuke Niwa.

Source/WebCore:

This regression was introduced with the work to remove redundant divs.
When we decide to remove a DIV, we need to adjust the selection, if it is
expressed in terms of the node being removed. The new position was computed
using updatePositionForNodeRemoval that was not designed for the case where we
remove preserving children.
This patch adds a new method to CompositeEditCommand to do this properly.

Test: editing/deleting/delete-word-from-unstyled-div.html

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::isRemovableBlock): Code clenup.
(WebCore::CompositeEditCommand::updatePositionForNodeRemovalPreservingChildren): Added.

  • editing/CompositeEditCommand.h:
  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::removeRedundantBlocks): Uses updatePositionForNodeRemovalPreservingChildren.

LayoutTests:

  • editing/deleting/delete-word-from-unstyled-div-expected.txt: Added.
  • editing/deleting/delete-word-from-unstyled-div.html: Added.
4:42 PM Changeset in webkit [116191] by jpfau@apple.com
  • 3 edits
    2 adds in trunk

Prevent early EventListener deletion
https://bugs.webkit.org/show_bug.cgi?id=73970

Reviewed by Oliver Hunt.

Source/WebCore:

Test: fast/events/attribute-listener-deletion-crash.html

  • bindings/js/JSEventListener.h:

(WebCore::JSEventListener::jsFunction):

LayoutTests:

  • fast/events/attribute-listener-deletion-crash-expected.txt: Added.
  • fast/events/attribute-listener-deletion-crash.html: Added.
4:42 PM Changeset in webkit [116190] by tony@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] enable msvs_error_on_missing_sources at gyp time
https://bugs.webkit.org/show_bug.cgi?id=85683

Reviewed by Adam Barth.

This flag checks for missing files, which cause compile times to be
slow on Windows. Since this flag is on by default for the
build.chromium.org bots, we should add it here too so everyone can fix
these errors.

  • DEPS: Roll to a chromium version that has no missing files.
  • gyp_webkit: Add the flag.
4:34 PM Changeset in webkit [116189] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Add "combining short stroke overlay character (u0335)" to lookalike characters blacklist.
https://bugs.webkit.org/show_bug.cgi?id=85440

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2012-05-04
Reviewed by David Kilzer.

We should add u0335 to the characters blacklist.

  • platform/mac/WebCoreNSURLExtras.mm:

(WebCore::isLookalikeCharacter):

4:31 PM Changeset in webkit [116188] by jer.noble@apple.com
  • 3 edits
    1 add in trunk

Flash of white when exiting full screen HTML5 video
https://bugs.webkit.org/show_bug.cgi?id=85438

.:

Reviewed by Sam Weinig.

  • ManualTests/fullscreen/full-screen-flash.html: Added.

Source/WebKit2:

Reviewed by Maciej Stachowiak.

Force a repaint before displaying the newly exited WebView window. This gives the window
a chance to seamlessly repaint before enabling screen updates.

Also, send the WebProcess the didExitFullScreen and setAnimatingFullScreen(false) messages
after swapping the WebView back into its original window. Doing otherwise seems to cause
forceRepaint to paint a white frame.

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):
(-[WKFullScreenWindowController completeFinishExitFullScreenAnimationAfterRepaint]):
(completeFinishExitFullScreenAnimationAfterRepaint):

4:11 PM Changeset in webkit [116187] by eric@webkit.org
  • 2 edits in trunk/Tools

Sort entries in FeaturesList.pm to make them easier to autogenerate
https://bugs.webkit.org/show_bug.cgi?id=85584

Reviewed by Daniel Bates.

No functional changes, only sorting.

  • Scripts/webkitperl/FeatureList.pm:
3:59 PM Changeset in webkit [116186] by commit-queue@webkit.org
  • 6 edits in trunk/Source

[chromium] Add plumbing for file display names for drag and drop
https://bugs.webkit.org/show_bug.cgi?id=85673

Patch by Satoru Takabayashi <satorux@chromium.org> on 2012-05-04
Reviewed by Darin Fisher.

Source/WebCore:

No new tests: this change itself shouldn't change existing behavior.

  • platform/chromium/ChromiumDataObject.cpp:

(WebCore::ChromiumDataObject::addFilename):

  • platform/chromium/ChromiumDataObject.h:

(ChromiumDataObject):

Source/WebKit/chromium:

  • public/platform/WebDragData.h:
  • src/WebDragData.cpp:

(WebKit::WebDragData::items):
(WebKit::WebDragData::addItem):

3:55 PM Changeset in webkit [116185] by leviw@chromium.org
  • 2 edits in trunk/Source/WebCore

Correct pixel snapping in RenderSVGRoot::paintReplaced
https://bugs.webkit.org/show_bug.cgi?id=85671

Reviewed by Eric Seidel.

SVG root elements are still painted on pixel boundaries, so their children should
apply transforms based on their actual painted location, not their sub-pixel
one. This corrects a clipping and painting issue where these sub-pixel units are
incorrectly applied to the graphics context.

Covered by existing tests when sub-pixel layout is enabled.

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::paintReplaced):

3:54 PM Changeset in webkit [116184] by Lucas Forschler
  • 4 edits in trunk/Source

Versioning.

3:44 PM Changeset in webkit [116183] by Lucas Forschler
  • 4 edits in tags/Safari-536.10.1/Source

Versioning.

3:38 PM Changeset in webkit [116182] by Lucas Forschler
  • 1 copy in tags/Safari-536.10.1

New Tag.

3:25 PM Changeset in webkit [116181] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk/po

Updated Spanish translation
https://bugs.webkit.org/show_bug.cgi?id=83995

Patch by Daniel Mustieles <daniel.mustieles@gmail.com> on 2012-05-04
Reviewed by Gustavo Noronha Silva.

  • es.po:
3:19 PM Changeset in webkit [116180] by aestes@apple.com
  • 2 edits in trunk/Tools

REGRESSION (r115752): WebKit2.NewFirstVisuallyNonEmptyLayout API test times out
https://bugs.webkit.org/show_bug.cgi?id=85675

  • TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:

(TestWebKitAPI::TEST): Disable the test.

3:08 PM Changeset in webkit [116179] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit/mac

REGRESSION (r116127-r116165): 6 tests failing on Lion Debug (Tests)
https://bugs.webkit.org/show_bug.cgi?id=85674

Reviewed by Oliver Hunt.

Null check the results of core([frame DOMDocument]).

  • WebView/WebView.mm:

(-[WebView _didStartProvisionalLoadForFrame:]):

3:01 PM Changeset in webkit [116178] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Set the right device scale factor when creating the web page
https://bugs.webkit.org/show_bug.cgi?id=85667
<rdar://problem/11376611>

Reviewed by Oliver Hunt.

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:contextRef:pageGroupRef:]):
Set the scale factor before initializing the page, to ensure that the WebPageCreationParameters struct gets the right scale factor.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setIntrinsicDeviceScaleFactor):
This can now be called with a null drawing area. Also, remove the isValid() check since we still want to update the scale factor even if the web process has crashed.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
Set the device scale factor from the creation parameters.

2:40 PM Changeset in webkit [116177] by abarth@webkit.org
  • 8 edits in trunk/Source

Refactor CSP state to prepare for having both a ReportOnly and an Enforced policy
https://bugs.webkit.org/show_bug.cgi?id=85662

Reviewed by Eric Seidel.

Source/WebCore:

This patch refactors the ContentSecurityPolicy state into a separate
DirectiveList class to prepare for
https://bugs.webkit.org/show_bug.cgi?id=85561, which will cause us to
need two directive lists: one for enforcement and one for monitoring.

This patch shouldn't cause any change in behavior.

  • page/ContentSecurityPolicy.cpp:

(CSPDirectiveList):
(WebCore::CSPDirectiveList::header):
(WebCore::CSPDirectiveList::headerType):
(WebCore::CSPDirectiveList::denyIfEnforcingPolicy):
(WebCore):
(WebCore::CSPDirectiveList::CSPDirectiveList):
(WebCore::CSPDirectiveList::create):
(WebCore::CSPDirectiveList::reportViolation):
(WebCore::CSPDirectiveList::logUnrecognizedDirective):
(WebCore::CSPDirectiveList::checkEval):
(WebCore::CSPDirectiveList::operativeDirective):
(WebCore::CSPDirectiveList::checkInlineAndReportViolation):
(WebCore::CSPDirectiveList::checkEvalAndReportViolation):
(WebCore::CSPDirectiveList::checkSourceAndReportViolation):
(WebCore::CSPDirectiveList::allowJavaScriptURLs):
(WebCore::CSPDirectiveList::allowInlineEventHandlers):
(WebCore::CSPDirectiveList::allowInlineScript):
(WebCore::CSPDirectiveList::allowInlineStyle):
(WebCore::CSPDirectiveList::allowEval):
(WebCore::CSPDirectiveList::allowScriptFromSource):
(WebCore::CSPDirectiveList::allowObjectFromSource):
(WebCore::CSPDirectiveList::allowChildFrameFromSource):
(WebCore::CSPDirectiveList::allowImageFromSource):
(WebCore::CSPDirectiveList::allowStyleFromSource):
(WebCore::CSPDirectiveList::allowFontFromSource):
(WebCore::CSPDirectiveList::allowMediaFromSource):
(WebCore::CSPDirectiveList::allowConnectFromSource):
(WebCore::CSPDirectiveList::parse):
(WebCore::CSPDirectiveList::parseDirective):
(WebCore::CSPDirectiveList::parseReportURI):
(WebCore::CSPDirectiveList::createCSPDirective):
(WebCore::CSPDirectiveList::applySandboxPolicy):
(WebCore::CSPDirectiveList::addDirective):
(WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
(WebCore::ContentSecurityPolicy::~ContentSecurityPolicy):
(WebCore::ContentSecurityPolicy::copyStateFrom):
(WebCore::ContentSecurityPolicy::didReceiveHeader):
(WebCore::ContentSecurityPolicy::setOverrideAllowInlineStyle):
(WebCore::ContentSecurityPolicy::header):
(WebCore::ContentSecurityPolicy::headerType):
(WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
(WebCore::ContentSecurityPolicy::allowInlineEventHandlers):
(WebCore::ContentSecurityPolicy::allowInlineScript):
(WebCore::ContentSecurityPolicy::allowInlineStyle):
(WebCore::ContentSecurityPolicy::allowEval):
(WebCore::ContentSecurityPolicy::allowScriptFromSource):
(WebCore::ContentSecurityPolicy::allowObjectFromSource):
(WebCore::ContentSecurityPolicy::allowChildFrameFromSource):
(WebCore::ContentSecurityPolicy::allowImageFromSource):
(WebCore::ContentSecurityPolicy::allowStyleFromSource):
(WebCore::ContentSecurityPolicy::allowFontFromSource):
(WebCore::ContentSecurityPolicy::allowMediaFromSource):
(WebCore::ContentSecurityPolicy::allowConnectFromSource):

  • page/ContentSecurityPolicy.h:

(WebCore):

  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::startWorkerContext):

Source/WebKit/chromium:

Update callers to the new function name.

  • src/SharedWorkerRepository.cpp:

(WebCore::SharedWorkerScriptLoader::notifyFinished):

  • src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::startWorkerContext):

2:38 PM Changeset in webkit [116176] by fpizlo@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed, updating expectations.

  • platform/mac/fast/block/float/overhanging-tall-block-expected.txt:
2:34 PM Changeset in webkit [116175] by fpizlo@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed, checking in new expectation file.

  • platform/mac/fast/images/png-suite/test-expected.txt: Added.
2:33 PM Changeset in webkit [116174] by inferno@chromium.org
  • 16 edits
    2 adds in trunk

ASSERT(beforeChildAnonymousContainer->isTable()); fails in RenderBlock::addChildIgnoringAnonymousColumnBlocks.
https://bugs.webkit.org/show_bug.cgi?id=84606

Reviewed by Julien Chaffraix.

Source/WebCore:

RenderBlock::removeChild forgot to set display on the anonymous block, causing it
to display as INLINE. To prevent this kind of failure in future, we replace
createAnonymousStyle with createAnonymousStyleWithDisplay to make everyone explictly
pass display as the argument.

Test: fast/block/block-add-child-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeChild):
(WebCore::RenderBlock::createAnonymousWithParentRendererAndDisplay):
(WebCore::RenderBlock::createAnonymousColumnsWithParentRenderer):
(WebCore::RenderBlock::createAnonymousColumnSpanWithParentRenderer):

  • rendering/RenderInline.cpp:

(WebCore::updateStyleOfAnonymousBlockContinuations):
(WebCore::RenderInline::addChildIgnoringContinuation):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::propagateStyleToAnonymousChildren):

  • rendering/RenderRuby.cpp:

(WebCore::createAnonymousRubyInlineBlock):

  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::createRubyBase):
(WebCore::RenderRubyRun::staticCreateRubyRun):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::createAnonymousWithParentRenderer):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::createAnonymousWithParentRenderer):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::createAnonymousWithParentRenderer):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::createAnonymousWithParentRenderer):

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::createAlmostAnonymousBlock):

  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::createAnonymousWithParentRenderer):

  • rendering/mathml/RenderMathMLSubSup.cpp:

(WebCore::RenderMathMLSubSup::addChild):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::createAnonymousStyleWithDisplay):

  • rendering/style/RenderStyle.h:

LayoutTests:

  • fast/block/block-add-child-crash-expected.txt: Added.
  • fast/block/block-add-child-crash.html: Added.
2:30 PM Changeset in webkit [116173] by jer.noble@apple.com
  • 5 edits
    2 adds in trunk

Taking a visibility:hidden element full screen causes full screen window to disappear.
https://bugs.webkit.org/show_bug.cgi?id=85432

Reviewed by Maciej Stachowiak.

.:

  • ManualTests/fullscreen/full-screen-zero-width.html: Added.

Source/WebKit/mac:

When given an initial or final frame with a zero width or height, return a rect representing
the entire screen, rather than a rect with a zero or infinite size. Doing otherwise will
confuse the window server when it's instructed to scale the full screen window to that size.

  • WebView/WebFullScreenController.mm:

(windowFrameFromApparentFrames):

Source/WebKit2:

When given an initial or final frame with a zero width or height, return a rect representing
the entire screen, rather than a rect with a zero or infinite size. Doing otherwise will
confuse the window server when it's instructed to scale the full screen window to that size.

  • UIProcess/mac/WKFullScreenWindowController.mm:

(windowFrameFromApparentFrames):

2:23 PM Changeset in webkit [116172] by arv@chromium.org
  • 13 edits
    1 copy
    12 adds in trunk/Source/WebCore

WebKit IDL does not use exception syntax
https://bugs.webkit.org/show_bug.cgi?id=85100

Reviewed by Dimitri Glazkov.

This adds support for exception ExceptionName { ... } which currently sets a flag
on the domClass.

Binding tests updated.

  • Modules/indexeddb/IDBDatabaseException.idl:
  • Modules/webdatabase/SQLException.idl:
  • bindings/scripts/IDLParser.pm:

(ParseInterface):
(DetermineParseMode):
(ProcessSection):

  • bindings/scripts/IDLStructure.pm:
  • bindings/scripts/test/CPP/WebDOMTestException.cpp: Added.

(WebDOMTestException::WebDOMTestExceptionPrivate::WebDOMTestExceptionPrivate):
(WebDOMTestException::WebDOMTestExceptionPrivate):
(WebDOMTestException::WebDOMTestException):
(WebDOMTestException::operator=):
(WebDOMTestException::impl):
(WebDOMTestException::~WebDOMTestException):
(WebDOMTestException::name):
(toWebCore):
(toWebKit):

  • bindings/scripts/test/CPP/WebDOMTestException.h: Added.

(WebCore):
(WebDOMTestException):

  • bindings/scripts/test/GObject/WebKitDOMTestException.cpp: Added.

(WebKit):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestException):
(webkit_dom_test_exception_finalize):
(webkit_dom_test_exception_set_property):
(webkit_dom_test_exception_get_property):
(webkit_dom_test_exception_constructed):
(webkit_dom_test_exception_class_init):
(webkit_dom_test_exception_init):
(webkit_dom_test_exception_get_name):

  • bindings/scripts/test/GObject/WebKitDOMTestException.h: Added.

(_WebKitDOMTestException):
(_WebKitDOMTestExceptionClass):

  • bindings/scripts/test/GObject/WebKitDOMTestExceptionPrivate.h: Added.

(WebKit):

  • bindings/scripts/test/JS/JSTestException.cpp: Added.

(WebCore):
(WebCore::JSTestExceptionConstructor::JSTestExceptionConstructor):
(WebCore::JSTestExceptionConstructor::finishCreation):
(WebCore::JSTestExceptionConstructor::getOwnPropertySlot):
(WebCore::JSTestExceptionConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestExceptionPrototype::self):
(WebCore::JSTestException::JSTestException):
(WebCore::JSTestException::finishCreation):
(WebCore::JSTestException::createPrototype):
(WebCore::JSTestException::destroy):
(WebCore::JSTestException::~JSTestException):
(WebCore::JSTestException::getOwnPropertySlot):
(WebCore::JSTestException::getOwnPropertyDescriptor):
(WebCore::jsTestExceptionName):
(WebCore::jsTestExceptionConstructor):
(WebCore::JSTestException::getConstructor):
(WebCore::isObservable):
(WebCore::JSTestExceptionOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestExceptionOwner::finalize):
(WebCore::toJS):
(WebCore::toTestException):

  • bindings/scripts/test/JS/JSTestException.h: Added.

(WebCore):
(JSTestException):
(WebCore::JSTestException::create):
(WebCore::JSTestException::createStructure):
(WebCore::JSTestException::impl):
(WebCore::JSTestException::releaseImpl):
(WebCore::JSTestException::releaseImplIfNotNull):
(JSTestExceptionOwner):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
(JSTestExceptionPrototype):
(WebCore::JSTestExceptionPrototype::create):
(WebCore::JSTestExceptionPrototype::createStructure):
(WebCore::JSTestExceptionPrototype::JSTestExceptionPrototype):
(JSTestExceptionConstructor):
(WebCore::JSTestExceptionConstructor::create):
(WebCore::JSTestExceptionConstructor::createStructure):

  • bindings/scripts/test/ObjC/DOMTestException.h: Added.
  • bindings/scripts/test/ObjC/DOMTestException.mm: Added.

(-[DOMTestException dealloc]):
(-[DOMTestException finalize]):
(-[DOMTestException name]):
(core):
(kit):

  • bindings/scripts/test/ObjC/DOMTestExceptionInternal.h: Added.

(WebCore):

  • bindings/scripts/test/TestException.idl: Copied from Source/WebCore/xml/XPathException.idl.
  • bindings/scripts/test/V8/V8TestException.cpp: Added.

(WebCore):
(TestExceptionV8Internal):
(WebCore::TestExceptionV8Internal::V8_USE):
(WebCore::TestExceptionV8Internal::nameAttrGetter):
(WebCore::ConfigureV8TestExceptionTemplate):
(WebCore::V8TestException::GetRawTemplate):
(WebCore::V8TestException::GetTemplate):
(WebCore::V8TestException::HasInstance):
(WebCore::V8TestException::wrapSlow):
(WebCore::V8TestException::derefObject):

  • bindings/scripts/test/V8/V8TestException.h: Added.

(WebCore):
(V8TestException):
(WebCore::V8TestException::toNative):
(WebCore::V8TestException::wrap):
(WebCore::toV8):

  • dom/DOMCoreException.idl:
  • dom/EventException.idl:
  • dom/RangeException.idl:
  • fileapi/FileException.idl:
  • fileapi/OperationNotAllowedException.idl:
  • svg/SVGException.idl:
  • xml/XMLHttpRequestException.idl:
  • xml/XPathException.idl:
2:21 PM Changeset in webkit [116171] by rafaelw@chromium.org
  • 2 edits in trunk/Source/WebCore

V8RecursionScope not declared in V8Proxy::newInstance which causes ASSERT() failure from NPAPI
https://bugs.webkit.org/show_bug.cgi?id=85659

Reviewed by Ojan Vafai.

Added a stack-allocted V8RecursionScope to the newInstance call.

No new tests. No change in observable behavior.

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::newInstance):

2:20 PM Changeset in webkit [116170] by jsbell@chromium.org
  • 4 edits in trunk/Source/WebCore

IndexedDB: Remove all index metadata records when deleting an index
https://bugs.webkit.org/show_bug.cgi?id=85557

Reviewed by Tony Chang.

An assert is hit when re-loading database from backing store due to stale index
metadata entry. Do a range delete to clear all metadata entries when deleting an
index. Define metadata entries as enum and limits as consts instead of hardcoded ints.

No new tests - issue does not repro as layout test. Will land test in Chromium.

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore::getBool): Helper functions; replaces pattern of putInt()/read only lead byte.
(WebCore):
(WebCore::putBool):
(WebCore::IDBLevelDBBackingStore::getObjectStores): Skip stale data. Use enums, helpers.
(WebCore::IDBLevelDBBackingStore::createObjectStore): Use enums.
(WebCore::IDBLevelDBBackingStore::deleteObjectStore): Use enums.
(WebCore::getNewVersionNumber): Use enums.
(WebCore::IDBLevelDBBackingStore::getIndexes): Skip stale data. Use enums, helpers.
(WebCore::getNewIndexId): Use enums.
(WebCore::IDBLevelDBBackingStore::createIndex): Use enums.
(WebCore::IDBLevelDBBackingStore::deleteIndex): Delete metadata by range.

  • Modules/indexeddb/IDBLevelDBCoding.cpp:

(IDBLevelDBCoding): Add constants for metadata maximum values.
(WebCore::IDBLevelDBCoding::encodeBool):
(WebCore::IDBLevelDBCoding::decodeBool):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encodeMaxKey): Use consts.
(WebCore::IDBLevelDBCoding::IndexMetaDataKey::encodeMaxKey): Use consts.

  • Modules/indexeddb/IDBLevelDBCoding.h:

(IDBLevelDBCoding): Expose enums for metadata types.

2:19 PM Changeset in webkit [116169] by aestes@apple.com
  • 2 edits in trunk/LayoutTests

[Mac] IETC flexbox reference tests have pixel differences (due to embedded color profiles?)
https://bugs.webkit.org/show_bug.cgi?id=85666

  • platform/mac/Skipped: Skip the tests.
2:18 PM Changeset in webkit [116168] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

DFG should not Flush GetLocal's
https://bugs.webkit.org/show_bug.cgi?id=85663
<rdar://problem/11373600>

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::flushArgument):
(JSC::DFG::ByteCodeParser::handleCall):

LayoutTests:

  • fast/js/dfg-flush-get-local-expected.txt: Added.
  • fast/js/dfg-flush-get-local.html: Added.
  • fast/js/script-tests/dfg-flush-get-local.js: Added.

(foo):
(fuzz):
(bar):

2:16 PM Changeset in webkit [116167] by andersca@apple.com
  • 9 edits in trunk/Source/WebCore

Move markPagesForFullStyleRecalc to PageCache
https://bugs.webkit.org/show_bug.cgi?id=85664

Reviewed by Dan Bernstein.

Instead of going through all the history items in the back/forward list looking for cached pages, just iterate over the cached pages in the page.

  • history/BackForwardController.cpp:
  • history/BackForwardController.h:
  • history/HistoryItem.cpp:
  • history/HistoryItem.h:
  • history/PageCache.cpp:

(WebCore::PageCache::markPagesForFullStyleRecalc):
(WebCore):

  • history/PageCache.h:

(PageCache):

  • page/Frame.cpp:

(WebCore::Frame::setPageAndTextZoomFactors):

  • page/Page.cpp:

(WebCore::Page::setDeviceScaleFactor):
(WebCore::Page::setPagination):

2:15 PM Changeset in webkit [116166] by tony@chromium.org
  • 5 edits in trunk

The computed style of flex-item-align should never be auto.
https://bugs.webkit.org/show_bug.cgi?id=85656

Reviewed by Ojan Vafai.

Source/WebCore:

If the node lacks a parent and flex-item-align is auto, we should
return stretch. This was recently clarified in the spec.

New testcase in css3/flexbox/css-properties.html.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/css-properties.html:
2:00 PM Changeset in webkit [116165] by jer.noble@apple.com
  • 16 edits
    3 adds in trunk

Full screen will exit during a provisional load of a non-ancestor iframe.
https://bugs.webkit.org/show_bug.cgi?id=85230

Reviewed by Maciej Stachowiak .

Source/WebKit/mac:

Only exit full screen mode if the frame being loaded contains the full
screen element.

  • WebView/WebView.mm:

(-[WebView _didStartProvisionalLoadForFrame:]): Give the UIDelegate a first crack at handling the
request to close the full screen window when a provisional load occurs.

Source/WebKit2:

Only exit full screen mode if the frame being loaded contains the full
screen element:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):

Move the full screen exiting logic up into WebFrameLoaderClient in the
WebProcess:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):

Add a WebFullScreenManager "close" method & message:

  • UIProcess/WebFullScreenManagerProxy.messages.in:
  • WebProcess/FullScreen/WebFullScreenManager.cpp:

(WebKit::WebFullScreenManager::close):

  • WebProcess/FullScreen/WebFullScreenManager.h:

Add support for this new message to the WKBundlePage and client:

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp:

(WebKit::InjectedBundlePageFullScreenClient::closeFullScreen):

  • WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.h:

Tools:

Add support for the new UIDelegate webView:closeFullScreenWithListener: method:

  • DumpRenderTree/mac/UIDelegate.mm:

(-[UIDelegate webView:closeFullScreenWithListener:]):

Add support for the new closeFullScreen injected bundle method:

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::closeFullScreen):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

LayoutTests:

  • fullscreen/non-ancestor-iframe-expected.txt: Added.
  • fullscreen/non-ancestor-iframe.html: Added.
  • fullscreen/resources/empty.html: Added.
1:59 PM Changeset in webkit [116164] by jer.noble@apple.com
  • 4 edits
    2 adds in trunk/Source/WebKit

Move WebKitFullScreenListener into its own file.
https://bugs.webkit.org/show_bug.cgi?id=85640

Source/WebKit:

Reviewed by Maciej Stachowiak .

Pull WebKitFullScreenListener into its own file.

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

Reviewed by Maciej Stachowiak.

Move WebKitFullScreenListener into its own file, so it can be used by multiple classes.

  • WebCoreSupport/WebKitFullScreenListener.h: Added.
  • WebCoreSupport/WebKitFullScreenListener.mm: Added.

(-[WebKitFullScreenListener webkitWillEnterFullScreen]):
(-[WebKitFullScreenListener webkitDidEnterFullScreen]):
(-[WebKitFullScreenListener webkitWillExitFullScreen]):
(-[WebKitFullScreenListener webkitDidExitFullScreen]):

  • WebCoreSupport/WebChromeClient.mm:
1:54 PM Changeset in webkit [116163] by ojan@chromium.org
  • 2 edits in trunk/Tools

Fix test naming to be camel-case like the methods they are testing.

  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

(test):

1:50 PM Changeset in webkit [116162] by ojan@chromium.org
  • 3 edits in trunk/Tools

Show the results links in the embedded flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=85660

Reviewed by Adam Barth.

Turns out these links don't add much visual noise and it's annoying
to have to go to the dashboard from garden-o-matic just to view the
results for a test.

This is useful for cases where garden-o-matic doesn't properly show the
results (e.g. missing tests). If we address all those cases, then
we could easily hide the results links again if we wanted to.

  • TestResultServer/static-dashboards/flakiness_dashboard.js:

(showUpdateInfoForTest):
(htmlForIndividualTestOnAllBuildersWithResultsLinks):

  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

(test):

1:46 PM Changeset in webkit [116161] by dpranke@chromium.org
  • 2 edits in trunk/Tools

Revert to using chromium --test-shell mode on SL in NRWT

https://bugs.webkit.org/show_bug.cgi?id=83076

Unreviewed, build fix.

We seem to be seeing a lot more flakiness on the bot since
I switched NRWT to "DRT" mode. We'll try reverting back and
see if this helps things.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumDriver.init):

1:33 PM WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
1:28 PM Changeset in webkit [116160] by commit-queue@webkit.org
  • 4 edits in trunk

[soup] URL of the ResourceResponse passed to willSendRequest is incorrect
https://bugs.webkit.org/show_bug.cgi?id=85072

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-04
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Store the response message by catching the "got-headers" signal so
that it can be passed later to willSendRequest() in case of
redirection. This is required because the SoupMessage headers and URL
have already been updated once restartedCallback() is called.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore):
(WebCore::gotHeadersCallback):
(WebCore::restartedCallback):
(WebCore::sendRequestCallback):
(WebCore::startHTTPRequest):

LayoutTests:

Unskip http/tests/misc/will-send-request-returns-null-on-redirect.html
and http/tests/loading/307-after-303-after-post.html now that the
response passed to willSendRequest is correct and now that the right
redirect URL is being printed in EFL port.

Unfortunately, http/tests/loading/redirect-methods.html cannot be
unskipped yet due to bug 66873.

  • platform/efl/test_expectations.txt:
1:20 PM Changeset in webkit [116159] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

REGRESSION(r116134): It made 3 inspector tests fail
https://bugs.webkit.org/show_bug.cgi?id=85654

Unreviewed gardening, skip failing tests until proper fix.

  • platform/qt/Skipped:
1:14 PM Changeset in webkit [116158] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

[EFL] Implement layoutTestController.dumpResourceResponseMIMETypes
https://bugs.webkit.org/show_bug.cgi?id=84941

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-04
Reviewed by Martin Robinson.

Source/WebKit/efl:

Extend Ewk_Frame_Resource_Response structure to pass resource MIME type
information.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchWillSendRequest):
(WebCore::FrameLoaderClientEfl::dispatchDidReceiveResponse):

  • ewk/ewk_frame.h:

Tools:

Print MIME type detection messages in EFL's DumpRenderTree if
LayoutTestController's dumpResourceResponseMIMETypes() returns true.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::onResponseReceived):

LayoutTests:

  • platform/efl/Skipped: Unskip test cases which require MIME type

detection messages now that is is implemented in EFL port.

  • platform/efl/fast/preloader/script-expected.txt: Added. Use same

EFL expectation as in chromium and mac ports (MIME type is
"application/javascript" instead of "application/x-javascript").

1:13 PM Changeset in webkit [116157] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

[BlackBerry] Implement numberOfProcessorCores() for QNX
https://bugs.webkit.org/show_bug.cgi?id=85638

Patch by Jeff Rogers <jrogers@rim.com> on 2012-05-04
Reviewed by Antonio Gomes.

  • wtf/NumberOfCores.cpp:

(WTF::numberOfProcessorCores):

1:12 PM Changeset in webkit [116156] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Fix expectation for test after http://trac.webkit.org/changeset/116143.

  • platform/chromium/test_expectations.txt:
1:10 PM Changeset in webkit [116155] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

All the inspector tests are skipped on chromium-mac. We should
skip the new ones in platform/chromium as well.

  • platform/chromium/test_expectations.txt:
1:08 PM Changeset in webkit [116154] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Suppress yet more Chromium Mac SL timeouts; hopefully close to end
https://bugs.webkit.org/show_bug.cgi?id=83076

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
1:07 PM Changeset in webkit [116153] by inferno@chromium.org
  • 1 edit in branches/chromium/1084/Source/WebCore/rendering/RenderBox.cpp

Merge 115668 - Source/WebCore: Remove positioned float code.
BUG=124919
Review URL: https://chromiumcodereview.appspot.com/10368021

1:06 PM Changeset in webkit [116152] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[chromium] CCProxy's shouldn't try to draw if there is no layer renderer
https://bugs.webkit.org/show_bug.cgi?id=85218

Patch by Ian Vollick <vollick@chromium.org> on 2012-05-04
Reviewed by Adrienne Walker.

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal):

1:01 PM Changeset in webkit [116151] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, test_expectations update.
Remove media/W3C/video/events/event_order_canplay_canplaythrough.html.
The crash is not happening anymore.

Patch by Shadi Khalek <shadi@chromium.org> on 2012-05-04

  • platform/chromium/test_expectations.txt:
12:58 PM Changeset in webkit [116150] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Suppress more Chromium Mac SL timeouts ...
https://bugs.webkit.org/show_bug.cgi?id=83076

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
12:57 PM Changeset in webkit [116149] by rwlbuis@webkit.org
  • 3 edits
    35 deletes in trunk/LayoutTests

Rebaseline some SVG Snow Leopard results
https://bugs.webkit.org/show_bug.cgi?id=85637

Reviewed by Nikolas Zimmermann.

Remove batik expected pngs for Snow Leopard since the generic mac ones match.
Fix types-dom-01-b-expected.txt to expect RenderSVGEllipse.

  • platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
  • platform/mac-snowleopard/svg/batik/filters/feTile-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/filters/filterRegions-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/masking/maskRegions-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/paints/gradientLimit-expected.png:
  • platform/mac-snowleopard/svg/batik/paints/patternPreserveAspectRatioA-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/paints/patternRegionA-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/paints/patternRegions-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/paints/patternRegions-positioned-objects-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/longTextOnPath-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/smallFonts-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textAnchor-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textAnchor2-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textAnchor3-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textDecoration-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textDecoration2-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textEffect-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textEffect2-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textEffect3-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textFeatures-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textGlyphOrientationHorizontal-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textLayout-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textLayout2-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textLength-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textOnPath-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textOnPath2-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textOnPath3-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textOnPathSpaces-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textPCDATA-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textPosition-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textPosition2-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textProperties-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textProperties2-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textStyles-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/verticalText-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/verticalTextOnPath-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/xmlSpace-expected.png: Removed.
12:53 PM Changeset in webkit [116148] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

Layout Test media/track/track-cues-pause-on-exit.html is flaky on chromium debug builds
https://bugs.webkit.org/show_bug.cgi?id=80067

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-05-04
Reviewed by Eric Carlson.

Trying a different approach, blocking on waitForEvent for the video element.

  • media/track/track-cues-pause-on-exit-expected.txt: Updated.
  • media/track/track-cues-pause-on-exit.html: Changed to use

waitForEvent and listen to exit events right after.

  • media/video-test.js: Updated waitForEvent to enable listening for

events on other elements as well.
(waitForEvent._eventCallback):
(waitForEvent):

12:46 PM Changeset in webkit [116147] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/1084

Merge 115343
BUG=108958
Review URL: https://chromiumcodereview.appspot.com/10368019

12:45 PM Changeset in webkit [116146] by commit-queue@webkit.org
  • 8 edits in trunk

[GTK] DRT needs an implementation of LayoutTestController::setDefersLoading and ::goBack
https://bugs.webkit.org/show_bug.cgi?id=85134

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-04
Reviewed by Martin Robinson.

Source/WebKit/gtk:

Add support for setDefersLoading in DumpRenderTreeSupportGtk.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::setDefersLoading):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Tools:

Add missing implementation setDefersLoading and goBack to GTK's
LayoutTestController so that the test case rely on these methods
can be enabled.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::goBack):
(LayoutTestController::setDefersLoading):

LayoutTests:

Unskip loader/navigation-while-deferring-loads.html and disable
loader/load-defer-resume-crash.html as it triggers an assertion
failure.

  • platform/gtk/test_expectations.txt:
12:44 PM Changeset in webkit [116145] by rwlbuis@webkit.org
  • 7 edits in trunk/Source

[BlackBerry] Rendering bmp file as text file when Content-Type:image/x-ms-bmp from apache web server.
https://bugs.webkit.org/show_bug.cgi?id=85036

Reviewed by Antonio Gomes.

Source/WebCore:

Move getNormalizedMIMEType from WebKit into MIMETypeRegistry. This way we support uncommon mime types like image/pjpeg
and image/x-ms-bmp out of the box since we map to the more common image/jpeg and image/bmp respectively.

  • platform/MIMETypeRegistry.cpp:

(WebCore::initializeSupportedImageMIMETypes):
(WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
(WebCore::MIMETypeRegistry::isSupportedImageResourceMIMEType):
(WebCore):
(WebCore::mimeTypeAssociationMap):
(WebCore::MIMETypeRegistry::getNormalizedMIMEType):

  • platform/MIMETypeRegistry.h:

(MIMETypeRegistry):

Source/WebKit/blackberry:

Move getNormalizedMIMEType into WebCore::MIMETypeRegistry.

  • Api/WebSettings.cpp:

(WebKit):
(BlackBerry::WebKit::WebSettings::isSupportedObjectMIMEType):

  • Api/WebSettings.h:
  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::createPlugin):
(WebCore::FrameLoaderClientBlackBerry::canShowMIMEType):
(WebCore::FrameLoaderClientBlackBerry::objectContentType):

12:38 PM Changeset in webkit [116144] by cevans@google.com
  • 3 edits in branches/chromium/1084

Merge 115763
BUG=125494
Review URL: https://chromiumcodereview.appspot.com/10377014

12:35 PM Changeset in webkit [116143] by aestes@apple.com
  • 2 edits in trunk/LayoutTests

REGRESSION (r116009): image no longer visible on fast/block/float/float-not-removed-from-next-sibling4.html
https://bugs.webkit.org/show_bug.cgi?id=85651

Check in failing results for platform/mac/.

  • platform/mac/fast/block/float/float-not-removed-from-next-sibling4-expected.txt:
12:25 PM Changeset in webkit [116142] by commit-queue@webkit.org
  • 18 edits in trunk/Source

[chromium] Revert compositor layer scrolling
https://bugs.webkit.org/show_bug.cgi?id=85644

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-05-04
Reviewed by Steve Block.

Source/WebCore:

This patch reverts the following commits because they were found to
trigger crashes. See discussion at http://code.google.com/p/chromium/issues/detail?id=124393.

[chromium] Allow scrolling non-root layers in the compositor thread
http://trac.webkit.org/changeset/114651

[chromium] Don't crash when scrolling empty layer tree
http://trac.webkit.org/changeset/114761

[chromium] Don't keep pointers to released layer tree
http://trac.webkit.org/changeset/115080

  • platform/graphics/chromium/ContentLayerChromium.cpp:
  • platform/graphics/chromium/ContentLayerChromium.h:

(ContentLayerChromium):

  • platform/graphics/chromium/GraphicsLayerChromium.h:

(GraphicsLayerChromium):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:
  • platform/graphics/chromium/cc/CCLayerImpl.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::applyScrollAndScale):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:

(CCLayerTreeHostCommon):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::startPageScaleAnimation):
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
(WebCore::CCLayerTreeHostImpl::contentSize):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):
(WebCore::findScrollLayer):
(WebCore::CCLayerTreeHostImpl::setRootLayer):
(WebCore::CCLayerTreeHostImpl::setPageScaleFactorAndLimits):
(WebCore):
(WebCore::CCLayerTreeHostImpl::adjustScrollsForPageScaleChange):
(WebCore::CCLayerTreeHostImpl::setPageScaleDelta):
(WebCore::CCLayerTreeHostImpl::applyPageScaleDeltaToScrollLayer):
(WebCore::CCLayerTreeHostImpl::updateMaxScrollPosition):
(WebCore::CCLayerTreeHostImpl::scrollBegin):
(WebCore::CCLayerTreeHostImpl::scrollBy):
(WebCore::CCLayerTreeHostImpl::scrollEnd):
(WebCore::CCLayerTreeHostImpl::pinchGestureUpdate):
(WebCore::CCLayerTreeHostImpl::computePinchZoomDeltas):
(WebCore::CCLayerTreeHostImpl::makeScrollAndScaleSet):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):
(WebCore::CCLayerTreeHostImpl::animatePageScale):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore::CCLayerTreeHostImpl::releaseRootLayer):
(WebCore::CCLayerTreeHostImpl::scrollLayer):
(CCLayerTreeHostImpl):

Source/WebKit/chromium:

  • src/WebContentLayerImpl.cpp:
  • src/WebContentLayerImpl.h:

(WebContentLayerImpl):

  • tests/CCLayerTreeHostCommonTest.cpp:
  • tests/CCLayerTreeHostImplTest.cpp:

(WebKitTests::TEST_F):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::MockContentLayerDelegate::paintContents):

12:25 PM Changeset in webkit [116141] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1084

Merge 115398
BUG=124893
Review URL: https://chromiumcodereview.appspot.com/10368018

12:25 PM Changeset in webkit [116140] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Mark editing tests as slow.
https://bugs.webkit.org/show_bug.cgi?id=85649

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
12:15 PM Changeset in webkit [116139] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/1084

Merge 115646
BUG=124895

12:10 PM Changeset in webkit [116138] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Mark a few more tests as flaky across all macs.

Unreviewed, expectations change.

fast/loader/javascript-url-in-embed.html = TEXT PASS (Release only)
http/tests/security/sandboxed-iframe-modify-self.html = TEXT PASS
media/video-poster-blocked-by-willsendrequest.html = TEXT PASS
userscripts/user-style-all-frames.html = TEXT PASS

  • platform/chromium/test_expectations.txt:
12:05 PM Changeset in webkit [116137] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Fix path to external JS file that was not updated when the file
was moved in http://trac.webkit.org/changeset/116128/.

  • platform/chromium/inspector/styles/device-metrics-fit-window.html:
12:00 PM Changeset in webkit [116136] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Mark tests as flaky timeouts on chromium Mac 10.6
https://bugs.webkit.org/show_bug.cgi?id=83076

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
11:58 AM Changeset in webkit [116135] by mrobinson@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

Fix the GTK+ debug build after the r116114.

  • WebCoreSupport/EditorClientGtk.cpp:

(WebKit::EditorClient::handleInputMethodKeyboardEvent): Update an
assertion to reflect a real method name in PlatformKeyboardEvent
and remove an unnecessary call to preventDefault() which triggered
an assertion failure higher in the call stack.

11:44 AM Changeset in webkit [116134] by Csaba Osztrogonác
  • 3 edits
    1 add in trunk/Tools

[Qt][NRWT] Run each DRT in it's own xvfb
https://bugs.webkit.org/show_bug.cgi?id=77335

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2012-05-04
Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort._driver_class):

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort._driver_class):

  • Scripts/webkitpy/layout_tests/port/xvfbdriver.py: Added.

(XvfbDriver):
(XvfbDriver._start):
(XvfbDriver._start.x_filter):
(XvfbDriver.stop):

11:42 AM Changeset in webkit [116133] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, marking a test added in r116127 as failing.

  • platform/gtk/test_expectations.txt:
11:38 AM Changeset in webkit [116132] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

CSP: Eval isn't blocked in about:blank subframes
https://bugs.webkit.org/show_bug.cgi?id=85553

Reviewed by Eric Seidel.

This patch fixes a race condition in this test. We need to wait for
the load event to ensure that the iframe has finished loading.

  • http/tests/security/contentSecurityPolicy/eval-blocked-in-about-blank-iframe.html:
11:31 AM Changeset in webkit [116131] by ojan@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove file that was deleted in http://trac.webkit.org/changeset/116085/.
For some reason, this was breaking the chromium build (probably a gyp bug
since chromium shouldn't be pulling in this file).

  • WebCore.gypi:
11:30 AM Changeset in webkit [116130] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

TiledCoreAnimationDrawingArea should handle visibility changes
https://bugs.webkit.org/show_bug.cgi?id=85645
<rdar://problem/11247192>

Reviewed by Oliver Hunt.

Replicate the visibility handling logic from DrawingAreaImpl and LayerTreeHostCAMac.

  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:

(TiledCoreAnimationDrawingAreaProxy):

  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::visibilityDidChange):
(WebKit):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::suspendPainting):
(WebKit):
(WebKit::TiledCoreAnimationDrawingArea::resumePainting):

11:28 AM Changeset in webkit [116129] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

fix bit packing in FillLayer on Windows
https://bugs.webkit.org/show_bug.cgi?id=85636

Reviewed by Ryosuke Niwa.

Use unsigned for all bit packed types. I manually verified that
the current uses of these member variables always assign true or false.

No new tests, adding a compile assert to verify bit packing.

  • rendering/style/FillLayer.cpp:

(SameSizeAsFillLayer): Added compile assert.
(WebCore):
(WebCore::FillLayer::FillLayer): Reorder m_sizeLength so bit packed fields are adjacent.
(WebCore::FillLayer::operator=): Ditto.

  • rendering/style/FillLayer.h:

(FillLayer): Convert bools to unsigned to match other bit packed fields.

10:57 AM Changeset in webkit [116128] by apavlov@chromium.org
  • 1 edit
    2 moves
    1 add in trunk/LayoutTests

Unreviewed, build fix.
Move Chromium-specific test into platform/chromium.

  • platform/chromium/inspector/styles/device-metrics-fit-window-expected.txt: Renamed from LayoutTests/inspector/styles/device-metrics-fit-window-expected.txt.
  • platform/chromium/inspector/styles/device-metrics-fit-window.html: Renamed from LayoutTests/inspector/styles/device-metrics-fit-window.html.
10:55 AM Changeset in webkit [116127] by tommyw@google.com
  • 11 edits
    2 adds in trunk

MediaStream API: Make PeerConnection00's API fully compliant with the draft
https://bugs.webkit.org/show_bug.cgi?id=85491

Reviewed by Adam Barth.

Source/Platform:

  • chromium/public/WebPeerConnection00HandlerClient.h:

Source/WebCore:

Mainly making the relevant API's use objects (aka Dictionaries) instead of the temporary strings,
but also making a few API's exception aware and changing the name of a flag.

Test: fast/mediastream/peerconnection-iceoptions.html

  • Modules/mediastream/PeerConnection00.cpp:

(WebCore::PeerConnection00::createMediaHints):
(WebCore::PeerConnection00::createOffer):
(WebCore):
(WebCore::PeerConnection00::createAnswer):
(WebCore::PeerConnection00::createIceOptions):
(WebCore::PeerConnection00::createDefaultIceOptions):
(WebCore::PeerConnection00::startIce):
(WebCore::PeerConnection00::addStream):
(WebCore::PeerConnection00::changeReadyState):

  • Modules/mediastream/PeerConnection00.h:

(WebCore):
(PeerConnection00):

  • Modules/mediastream/PeerConnection00.idl:
  • platform/mediastream/chromium/PeerConnection00HandlerInternal.cpp:

(WebCore::PeerConnection00HandlerInternal::startIce):

Source/WebKit/chromium:

  • src/AssertMatchingEnums.cpp:

LayoutTests:

  • fast/mediastream/peerconnection-Attributes-expected.txt:
  • fast/mediastream/peerconnection-iceoptions-expected.txt: Added.
  • fast/mediastream/peerconnection-iceoptions.html: Added.
10:52 AM Changeset in webkit [116126] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

Use destructuring assingment for the return values of the
port.diff_image() method call.

Rubber-stamped by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(write_test_result):

10:47 AM Changeset in webkit [116125] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Chromium should include MenuListPopups' and MenuListOptions' within the ax tree.
https://bugs.webkit.org/show_bug.cgi?id=85541

Patch by David Tseng <dtseng@google.com> on 2012-05-04
Reviewed by Chris Fleizach.

Covered by existing tests.
LayoutTests/accessibility/menu-list-sends-change-notification.html

  • accessibility/AccessibilityMockObject.h:

(WebCore::AccessibilityMockObject::accessibilityIsIgnored):

  • accessibility/chromium/AccessibilityObjectChromium.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

10:44 AM Changeset in webkit [116124] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit/mac

<rdar://problem/11312853> and https://bugs.webkit.org/show_bug.cgi?id=85635 Exception in [WebFrame loadRequest:] breaks some WebKit apps

Reviewed by Alexey Proskuryakov.

Some API clients pass in nil requests or requests with nil URLs.
In r112571 we started rewriting these URLs resulting in an exception.
Since we've supported nil requests until now, we should not try to rewrite these URLs.

  • WebView/WebFrame.mm:

(-[WebFrame loadRequest:]): Don't try to rewrite invalid URLs if they are also null.

10:44 AM Changeset in webkit [116123] by ojan@chromium.org
  • 2 edits in trunk/Tools

Store fewer runs by default in the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=85568

Reviewed by Dirk Pranke.

This will greatly shrink the size of the json files we load,
resulting in a much faster initial load. People rarely care
about more than 100 runs. For the cases they do, they can still click
the show all runs checkbox to show 500 runs.

  • TestResultServer/model/jsonresults.py:
10:41 AM Changeset in webkit [116122] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

[Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=85591

Reviewed by Martin Robinson.

Remove incorrect test expectations for tests that are lately consistently
passing on all the Gtk builders but only turned out to be passing after
the Gtk port moved from using Skipped list to test_expectations.txt.
Their proper bug entries will be handled later, after all the tests are
confirmed to still pass. If any test backfires the correct test expectation
will be renewed and bug entries refreshed with latest information.

  • platform/gtk/test_expectations.txt:
10:31 AM Changeset in webkit [116121] by Nate Chapin
  • 25 edits in trunk/Source

Don't require FrameLoaderClient to manufacture a commitData() call for empty documents.
https://bugs.webkit.org/show_bug.cgi?id=85533

Reviewed by Alexey Proskuryakov.

Source/WebKit/blackberry:

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::finishedLoading):

Source/WebKit/chromium:

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::FrameLoaderClientImpl):
(WebKit):
(WebKit::FrameLoaderClientImpl::finishedLoading):

  • src/FrameLoaderClientImpl.h:

(WebKit::FrameLoaderClientImpl::makeRepresentation):
(WebKit::FrameLoaderClientImpl::revertToProvisionalState):
(FrameLoaderClientImpl):

Source/WebKit/efl:

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::FrameLoaderClientEfl):
(WebCore):
(WebCore::FrameLoaderClientEfl::finishedLoading):

  • WebCoreSupport/FrameLoaderClientEfl.h:

(WebCore::FrameLoaderClientEfl::makeRepresentation):
(WebCore::FrameLoaderClientEfl::revertToProvisionalState):
(FrameLoaderClientEfl):

Source/WebKit/gtk:

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::FrameLoaderClient):
(WebKit):
(WebKit::FrameLoaderClient::finishedLoading):

  • WebCoreSupport/FrameLoaderClientGtk.h:

(WebKit::FrameLoaderClient::makeRepresentation):
(WebKit::FrameLoaderClient::revertToProvisionalState):
(FrameLoaderClient):

Source/WebKit/mac:

  • WebView/WebHTMLRepresentation.mm:

(-[WebHTMLRepresentation finishedLoadingWithDataSource:]): Calling commitData when finishing is no longer necessary,

as WebCore will take care of simulating the receipt of data and ensuring the requisite work gets done in the blank document case.

Source/WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::FrameLoaderClientQt):
(WebCore):
(WebCore::FrameLoaderClientQt::finishedLoading):

  • WebCoreSupport/FrameLoaderClientQt.h:

(WebCore::FrameLoaderClientQt::makeRepresentation):
(WebCore::FrameLoaderClientQt::revertToProvisionalState):
(FrameLoaderClientQt):

Source/WebKit/win:

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::finishedLoading):

Source/WebKit/wince:

  • WebCoreSupport/FrameLoaderClientWinCE.cpp:

(WebKit::FrameLoaderClientWinCE::finishedLoading):

Source/WebKit/wx:

  • WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore::FrameLoaderClientWx::finishedLoading):
(WebCore::FrameLoaderClientWx::setMainDocumentError):
(WebCore::FrameLoaderClientWx::dispatchDidReceiveResponse):
(WebCore::FrameLoaderClientWx::dispatchDidFailLoading):

  • WebKitSupport/FrameLoaderClientWx.h:

(FrameLoaderClientWx):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::finishedLoading):

10:23 AM Changeset in webkit [116120] by leviw@chromium.org
  • 1 edit in trunk/Source/WebCore/ChangeLog

Unreviewed. Fixing ChangeLog conflict markers after 116009.

10:22 AM Changeset in webkit [116119] by commit-queue@webkit.org
  • 11 edits in trunk

[EFL] Frame load callbacks output is missing for redirections
https://bugs.webkit.org/show_bug.cgi?id=85173

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-04
Reviewed by Antonio Gomes.

Source/WebKit/efl:

Add a few redirection-related signals on the ewk_frame so that EFL's
DumpRenderTree can print the expected output when
LayoutTestController's dumpFrameLoadCallbacks() returns true.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchWillSendRequest):
(WebCore::FrameLoaderClientEfl::dispatchDidReceiveResponse):
(WebCore::FrameLoaderClientEfl::dispatchDidReceiveServerRedirectForProvisionalLoad):
(WebCore::FrameLoaderClientEfl::dispatchWillPerformClientRedirect):

  • ewk/ewk_frame.cpp:

(ewk_frame_redirect_provisional_load):
(ewk_frame_redirect_requested):

  • ewk/ewk_frame.h:
  • ewk/ewk_private.h:

Tools:

Catch the new ewk_frame signals to print the expected output in case
of redirections, when LayoutTestController's dumpFrameLoadCallbacks()
returns true.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onWillSendRequest):
(DumpRenderTreeChrome::onFrameCreated):
(DumpRenderTreeChrome::onFrameRedirectForProvisionalLoad):
(DumpRenderTreeChrome::onFrameRedirectRequested):
(DumpRenderTreeChrome::onResponseReceived):

  • DumpRenderTree/efl/DumpRenderTreeChrome.h:

(DumpRenderTreeChrome):

LayoutTests:

Update test_expectations.txt now that EFL's DumpRenderTree is
correctly printing frame load callbacks information in case of
redirections.

  • platform/efl/Skipped:
  • platform/efl/test_expectations.txt:
10:19 AM Changeset in webkit [116118] by commit-queue@webkit.org
  • 2 edits
    3 adds in trunk/LayoutTests

[EFL] [DRT] Gardening some failure cases on EFL port
https://bugs.webkit.org/show_bug.cgi?id=85605

Unreviewed, EFL gardening.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-04

  • platform/efl/fast/canvas/fillText-shadow-expected.txt: Added.
  • platform/efl/fast/dom/Window/window-lookup-precedence-expected.txt: Added.
  • platform/efl/fast/dom/Window/window-properties-performance-expected.txt: Added.
  • platform/efl/test_expectations.txt:
10:12 AM Changeset in webkit [116117] by danw@gnome.org
  • 2 edits in trunk/Source/WebCore
[GTK] ASSERTION FAILED: shouldLoadAsEmptyDocument(r.url())

!defersLoading() in MainResourceLoader.cpp:382

Remove a soup_session_pause_message() call that got left behind,
update the defersLoading stuff to handle this case.

https://bugs.webkit.org/show_bug.cgi?id=85159

Reviewed by Martin Robinson.

No new tests. Now passes loader/load-defer-resume-crash.html under
debug build.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::sendRequestCallback):
(WebCore::ResourceHandle::platformSetDefersLoading):

10:05 AM Changeset in webkit [116116] by apavlov@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: [Device Metrics] With "Fit window" option on, page contents are downscaled incorrectly
https://bugs.webkit.org/show_bug.cgi?id=85510

Reviewed by Pavel Feldman.

Source/WebKit/chromium:

Use the RenderView width rather than FrameView contents width whenever possible.
Drive-by: add protection from division-by-zero (for some weird rendering states).

Test: inspector/styles/device-metrics-fit-window.html

  • src/WebDevToolsAgentImpl.cpp:

(WebKit::DeviceMetricsSupport::ensureOriginalZoomFactor):
(WebKit::DeviceMetricsSupport::scaledEmulatedFrameSize):

LayoutTests:

  • inspector/styles/device-metrics-fit-window-expected.txt: Added.
  • inspector/styles/device-metrics-fit-window.html: Added.
9:57 AM Changeset in webkit [116115] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Fix up warning about missing GLib/Gio/GStreamer

We don't actually fall back.

Rubber-stamped by Csaba Osztrogonác.

9:49 AM Changeset in webkit [116114] by mrobinson@webkit.org
  • 11 edits
    5 adds in trunk/Source

[GTK] Rework IME handling to fix bugs and prepare for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=84556

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

No new tests. This change is already covered by a suite of keyboard
handling unit tests in WebKitGTK+. There are some changes in behavior,
but they are difficult to test without mocking out an entire GtkIMContext.

Add a struct, CompositionResults, which is used by PlatformKeyboardEvent
to package composition information with a keyboard event. Also add some logic
to PlatformKeyboardEvent to give the right information when it has composition
results.

  • GNUmakefile.list.am: Added new sources to the list.
  • platform/PlatformKeyboardEvent.h: Added a new CompositionResults member,

getter, and argument to the constructor.

  • platform/gtk/CompositionResults.h: Added.
  • platform/gtk/GtkInputMethodFilter.cpp: Added.
  • platform/gtk/GtkInputMethodFilter.h: Added.
  • platform/gtk/PlatformKeyboardEventGtk.cpp:

(WebCore::PlatformKeyboardEvent::windowsKeyCodeForGdkKeyCode): When
the key value is void return the VK_PROCESS keycode, which is the keycode
that web content expects with keystrokes that trigger composition events.
(WebCore::eventTypeForGdkKeyEvent): Abstract out this helper.
(WebCore::modifiersForGdkKeyEvent): Abstract out this helper.
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): When a PlatformKeyEvent
has composition results, use VK_PROCESS as the keycode for this event.
(WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent): When this event is
transformed into a Char event, the PlatformKeyboardEvent used for DOM keypress
events, and it has composition results clear the text members. This forces the
EventHandler code to drop the keypress event. Platform events that change the
composition states do not have corresponding keypress DOM events (only keydown
and keyup events), so this is necessary to ensure web compatibility.

Source/WebKit/gtk:

Rework input method handling logic into a class called GtkInputMethodFilter.
This filter now runs before WebCore event handling, allowing the code to more
easily fake simple compositions that should be seen as keystrokes. We can also
filter keypresses that should not go to web content at all, such as key up events
related to key down events that were filtered.

Also added is a WebViewInputMethodFilter which is a concrete implementation of
GtkInputMethodFilter. This class contains logic for actually sending events to
WebCore. In WebKit2 an implementation of GtkInputMethodFilter will send events
across the IPC channel.

  • GNUmakefile.am: Add new files to the source list.
  • WebCoreSupport/ContextMenuClientGtk.cpp:

(WebKit::inputMethodsMenuItem): Access the input method context via the filter.

  • WebCoreSupport/EditorClientGtk.cpp: Remove the tricky logic of input method

events from this class, because it's now in the GtkInputMethodFilter.
(WebKit::EditorClient::setInputMethodState): Call into the filter.
(WebKit::EditorClient::shouldBeginEditing): We no longer need to update the composition here.
This is handled by the focus in and focus out logic in the filter.
(WebKit::EditorClient::shouldEndEditing): Ditto.
(WebKit::EditorClient::respondToChangedSelection): Call into the filter now.
(WebKit::EditorClient::handleInputMethodKeyboardEvent): Added this helper which executes
any pending composition confirmation or preedit update actions as the default action of
the keydown event.
(WebKit::EditorClient::handleKeyboardEvent): Call handleInputMethodKeyboardEvent to do
any pending composition action.
(WebKit::EditorClient::handleInputMethodKeydown): Remove all the logic from this method.
Keys are filtered before they are sent to WebCore now and the actual action of input method
events happens in the keydown default action to increase compatibility with other browsers.
(WebKit::EditorClient::EditorClient): Remove context signal management.
(WebKit::EditorClient::~EditorClient): Ditto.

  • WebCoreSupport/EditorClientGtk.h:

(EditorClient): No longer has some members that tracked IME status.

  • WebCoreSupport/WebViewInputMethodFilter.cpp: Added.
  • WebCoreSupport/WebViewInputMethodFilter.h: Added.
  • webkit/webkitwebview.cpp:

(webkit_web_view_get_property): Get the context from the filter now.
(webkit_web_view_key_press_event): Just send events straight to the filter.
The filter will decide whether or not to send them to WebCore.
(webkit_web_view_key_release_event): Ditto.
(webkit_web_view_button_press_event): Use the filter to handle button press
events related to IME.
(webkit_web_view_focus_in_event): Notify the filter now.
(webkit_web_view_focus_out_event): Ditto.
(webkit_web_view_realize): The filter takes care of listening for realize now.
(webkit_web_view_init): Set the WebView widget on the filter.

  • webkit/webkitwebviewprivate.h: Change the GtkIMContext member to be a GtkInputMethodFilter member.
9:43 AM Changeset in webkit [116113] by jochen@chromium.org
  • 3 edits
    3 adds in trunk

Correctly update the outgoing referrer when navigating back from an history item created by pushState/replaceState
https://bugs.webkit.org/show_bug.cgi?id=85374

Reviewed by Nate Chapin.

Source/WebCore:

Test: http/tests/history/history-navigations-set-referrer.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadInSameDocument):

LayoutTests:

  • http/tests/history/history-navigations-set-referrer-expected.txt: Added.
  • http/tests/history/history-navigations-set-referrer.html: Added.
  • http/tests/history/resources/check-referrer.html: Added.
9:35 AM Changeset in webkit [116112] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Web Timing tests gardening
https://bugs.webkit.org/show_bug.cgi?id=85619

Unreviewed, EFL gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-04

  • platform/efl/test_expectations.txt:
9:32 AM Changeset in webkit [116111] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] REGRESSION: http/tests/xmlhttprequest/basic-auth-nopassword.html started to crash with newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=85632

Unreviewed gardening, skip the new _crashing_ test to paint the bot green.

  • platform/qt-5.0-wk1/Skipped:
9:32 AM Changeset in webkit [116110] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Clarify warning about missing GLib/Gio/GStreamer for media support

And only print it once.

Reviewed by Csaba Osztrogonác.

9:25 AM Changeset in webkit [116109] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] REGRESSION: 350 tests started to fail with newer Qt5-WK1
https://bugs.webkit.org/show_bug.cgi?id=85631

Unreviewed gardening, skip new failing tests to paint the bot green.

  • platform/qt-5.0-wk1/Skipped:
9:17 AM Changeset in webkit [116108] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] REGRESSION: 10 tests started to fail with newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=85629

Unreviewed fix after r116106.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
9:09 AM Changeset in webkit [116107] by vestbo@webkit.org
  • 6 edits
    1 add in trunk

[Qt] Clean up and split features.prf into a static list of defaults

The static list of feature defaults is used as a fallback for any
feature that's not dynamically detected or overriden on the command
line (though build-webkit or passing DEFINES+= to qmake).

The static list is complete, which allows for auto-generation based
on Features.py (see bug https://bugs.webkit.org/show_bug.cgi?id=85456)

https://bugs.webkit.org/show_bug.cgi?id=85611

Reviewed by Simon Hausmann.

8:43 AM Changeset in webkit [116106] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] REGRESSION: 10 tests started to fail with newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=85629

Unreviewed gardening, skip new failing tests to paint the bot green.

  • platform/qt-5.0-wk2/Skipped:
8:27 AM Changeset in webkit [116105] by zoltan@webkit.org
  • 13 edits
    1 add in trunk

Unreviewed, rolling out r116085, r116091, and r116095.
http://trac.webkit.org/changeset/116085
http://trac.webkit.org/changeset/116091
http://trac.webkit.org/changeset/116095
https://bugs.webkit.org/show_bug.cgi?id=85628

We are not ready with dependencies on all platform yet (mac) +
problems with debug builds. (Requested by Zoltan on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-04

Source/WebCore:

  • Target.pri:
  • WebCore.pri:
  • platform/MIMETypeRegistry.cpp:

(WebCore::initializeSupportedImageMIMETypes):
(WebCore::initializeSupportedImageMIMETypesForEncoding):

  • platform/graphics/ImageSource.cpp:
  • platform/graphics/ImageSource.h:

(WebCore):

  • platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoder::create):
(WebCore):
(WebCore::ImageDecoderQt::filenameExtension):
(WebCore::ImageDecoderQt::internalHandleCurrentImage):
(WebCore::ImageDecoderQt::clearPointers):

  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageDecoder::create):

  • platform/image-decoders/ImageDecoder.h:

(WebCore::ImageFrame::getAddr):
(ImageFrame):

  • platform/image-decoders/qt/ImageFrameQt.cpp: Added.

(WebCore):
(WebCore::ImageFrame::ImageFrame):
(WebCore::ImageFrame::operator=):
(WebCore::ImageFrame::clearPixelData):
(WebCore::ImageFrame::zeroFillPixelData):
(WebCore::ImageFrame::copyBitmapData):
(WebCore::ImageFrame::setSize):
(WebCore::ImageFrame::asNewNativeImage):
(WebCore::ImageFrame::hasAlpha):
(WebCore::ImageFrame::setHasAlpha):
(WebCore::ImageFrame::setColorProfile):
(WebCore::ImageFrame::setStatus):
(WebCore::ImageFrame::setPixmap):
(WebCore::ImageFrame::width):
(WebCore::ImageFrame::height):

Source/WebKit/blackberry:

  • WebCoreSupport/AboutDataEnableFeatures.in:

Tools:

  • qmake/mkspecs/features/features.prf:
8:24 AM Changeset in webkit [116104] by loislo@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: eliminate temporaryProfile property from ProfilesPanel.
https://bugs.webkit.org/show_bug.cgi?id=85623

We can run different profilers at the same time therefore we have to keep temorary profile per profiler type.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/CSSSelectorProfileView.js:

(WebInspector.CSSSelectorProfileType.prototype.createView):
(WebInspector.CSSSelectorProfileType.prototype.createTemporaryProfile):
(WebInspector.CSSSelectorProfileType.prototype.createProfile):

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotProfileType.prototype.createView):
(WebInspector.HeapSnapshotProfileType.prototype.createTemporaryProfile):
(WebInspector.HeapSnapshotProfileType.prototype.createProfile):

  • inspector/front-end/ProfileView.js:

(WebInspector.CPUProfileType.prototype.startRecordingProfile):
(WebInspector.CPUProfileType.prototype.createView):
(WebInspector.CPUProfileType.prototype.createTemporaryProfile):
(WebInspector.CPUProfileType.prototype.createProfile):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfileType.prototype.createSidebarTreeElementForProfile):
(WebInspector.ProfileType.prototype.createTemporaryProfile):
(WebInspector.ProfileType.prototype.createProfile):
(WebInspector.ProfileHeader):
(WebInspector.HeapProfileHeader):
(WebInspector.ProfilesPanel.prototype.addProfileHeader):
(WebInspector.ProfilesPanel.prototype.findTemporaryProfile):
(WebInspector.ProfilesPanel.prototype._removeTemporaryProfile):
(WebInspector.ProfilesPanel.prototype._populateProfiles.populateCallback.var):
(WebInspector.ProfilesPanel.prototype._populateProfiles.populateCallback):
(WebInspector.ProfilesPanel.prototype._populateProfiles):
(WebInspector.ProfilesPanel.prototype.setRecordingProfile):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
(WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):
(WebInspector.ProfilerDispatcher.prototype.addProfileHeader):

8:14 AM Changeset in webkit [116103] by loislo@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: [chromium] ScriptGCEvent should not be static.
https://bugs.webkit.org/show_bug.cgi?id=80788

The static members of ScriptGCEvent were moved into per isolate data structure.
Drive by fix: Sometimes the used heap size after a GC is slightly more than it was before.

Reviewed by Yury Semikhatsky.

  • bindings/v8/ScriptGCEvent.cpp:

(WebCore::ScriptGCEvent::gcPrologueCallback):
(WebCore::ScriptGCEvent::gcEpilogueCallback):

  • bindings/v8/V8Binding.h:

(WebCore::GCEventData::GCEventData):
(WebCore::GCEventData::clear):
(GCEventData):
(WebCore):
(WebCore::V8BindingPerIsolateData::gcEventData):
(V8BindingPerIsolateData):

7:52 AM Changeset in webkit [116102] by Csaba Osztrogonác
  • 8 edits
    1 copy in trunk/Source

[Qt] Update Qt bridge after changes to QMetaMethod
https://bugs.webkit.org/show_bug.cgi?id=85478

Patch by Kent Hansen <kent.hansen@nokia.com> on 2012-05-04
Reviewed by Tor Arne Vestbø.

QMetaMethod::signature() has been renamed to methodSignature() and
returns a QByteArray.

The new function QMetaMethod::name() gives direct access to a
method's name. returnType(), parameterCount(), and parameterType()
give direct access to type information.

Ported the custom QtConnectionObject meta-object to revision 7;
revision 6 and below aren't supported (and don't compile) with Qt5.

Source/WebCore:

  • Target.pri:
  • bridge/qt/qt_class.cpp:

(JSC::Bindings::QtClass::fallbackObject):

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtInstance::getPropertyNames):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::findMethodIndex):
(Bindings):
(qt_meta_stringdata_QtConnectionObject_t):
(JSC::Bindings::QtConnectionObject::qt_static_metacall):
(JSC::Bindings::QtConnectionObject::qt_metacast):
(JSC::Bindings::QtConnectionObject::qt_metacall):
(JSC::Bindings::QtConnectionObject::execute):

  • bridge/qt/qt_runtime.h:

(QtConnectionObject):

  • bridge/qt/qt_runtime_qt4.cpp: Copied from Source/WebCore/bridge/qt/qt_runtime.cpp.

(Bindings):
(QWKNoDebug):
(JSC::Bindings::QWKNoDebug::QWKNoDebug):
(JSC::Bindings::QWKNoDebug::~QWKNoDebug):
(JSC::Bindings::QWKNoDebug::operator<<):
(JSC::Bindings::operator<<):
(RuntimeConversion):
(JSC::Bindings::registerCustomType):
(JSC::Bindings::isJSUint8ClampedArray):
(JSC::Bindings::valueRealType):
(JSC::Bindings::convertValueToQVariantMap):
(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue):
(JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMethod::finishCreation):
(JSC::Bindings::QtRuntimeMethod::~QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMethod::destroy):
(JSC::Bindings::QtRuntimeMethodData::~QtRuntimeMethodData):
(JSC::Bindings::QtRuntimeMethodData::finalize):
(JSC::Bindings::QtRuntimeMetaMethodData::~QtRuntimeMetaMethodData):
(JSC::Bindings::QtRuntimeConnectionMethodData::~QtRuntimeConnectionMethodData):
(QtMethodMatchType):
(JSC::Bindings::QtMethodMatchType::QtMethodMatchType):
(JSC::Bindings::QtMethodMatchType::kind):
(JSC::Bindings::QtMethodMatchType::isValid):
(JSC::Bindings::QtMethodMatchType::isVariant):
(JSC::Bindings::QtMethodMatchType::isMetaType):
(JSC::Bindings::QtMethodMatchType::isUnresolved):
(JSC::Bindings::QtMethodMatchType::isMetaEnum):
(JSC::Bindings::QtMethodMatchType::enumeratorIndex):
(JSC::Bindings::QtMethodMatchType::variant):
(JSC::Bindings::QtMethodMatchType::metaType):
(JSC::Bindings::QtMethodMatchType::metaEnum):
(JSC::Bindings::QtMethodMatchType::unresolved):
(JSC::Bindings::QtMethodMatchType::typeId):
(JSC::Bindings::QtMethodMatchType::name):
(QtMethodMatchData):
(JSC::Bindings::QtMethodMatchData::QtMethodMatchData):
(JSC::Bindings::QtMethodMatchData::isValid):
(JSC::Bindings::QtMethodMatchData::firstUnresolvedIndex):
(JSC::Bindings::indexOfMetaEnum):
(JSC::Bindings::findMethodIndex):
(JSC::Bindings::findSignalIndex):
(JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod):
(JSC::Bindings::QtRuntimeMetaMethod::finishCreation):
(JSC::Bindings::QtRuntimeMetaMethod::visitChildren):
(JSC::Bindings::QtRuntimeMetaMethod::call):
(JSC::Bindings::QtRuntimeMetaMethod::getCallData):
(JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertySlot):
(JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertyDescriptor):
(JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertyNames):
(JSC::Bindings::QtRuntimeMetaMethod::lengthGetter):
(JSC::Bindings::QtRuntimeMetaMethod::connectGetter):
(JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter):
(JSC::Bindings::QtRuntimeConnectionMethod::QtRuntimeConnectionMethod):
(JSC::Bindings::QtRuntimeConnectionMethod::finishCreation):
(JSC::Bindings::QtRuntimeConnectionMethod::call):
(JSC::Bindings::QtRuntimeConnectionMethod::getCallData):
(JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertySlot):
(JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertyDescriptor):
(JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertyNames):
(JSC::Bindings::QtRuntimeConnectionMethod::lengthGetter):
(JSC::Bindings::QtConnectionObject::QtConnectionObject):
(JSC::Bindings::QtConnectionObject::~QtConnectionObject):
(JSC::Bindings::QtConnectionObject::metaObject):
(JSC::Bindings::QtConnectionObject::qt_metacast):
(JSC::Bindings::QtConnectionObject::qt_metacall):
(JSC::Bindings::isJavaScriptFunction):
(JSC::Bindings::QtConnectionObject::execute):
(JSC::Bindings::QtConnectionObject::match):
(JSC::Bindings::QtConnectionObject::createWithInternalJSC):
(JSC::Bindings::::QtArray):
(JSC::Bindings::::~QtArray):
(JSC::Bindings::::rootObject):
(JSC::Bindings::::setValueAt):
(JSC::Bindings::::valueAt):

Source/WebKit2:

  • UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp:

(gatherAPI):

7:50 AM Changeset in webkit [116101] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

[Qt] Don't pass viewport-create function to quick_test_main.
https://bugs.webkit.org/show_bug.cgi?id=85478

Patch by Tor Arne Vestbø <tor.arne.vestbo@nokia.com> on 2012-05-04
Reviewed by Csaba Osztrogonác.

  • UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp:

(main):

7:49 AM Changeset in webkit [116100] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebKit2

[Qt] Buildfix for newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=85478

Reviewed by Tor Arne Vestbø.

  • Shared/qt/ProcessExecutablePathQt.cpp:

(WebKit::executablePath):

  • UIProcess/API/qt/qwebiconimageprovider_p.h:
7:36 AM Changeset in webkit [116099] by yurys@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: use single method for retrieving evaluation context in the runtime agent
https://bugs.webkit.org/show_bug.cgi?id=85621

Reviewed by Pavel Feldman.

Merged two script state retrieval methods into one. Moved Page specific logic
into PageRuntimeAgent.

  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::evaluate):

  • inspector/InspectorRuntimeAgent.h:

(InspectorRuntimeAgent):

  • inspector/PageRuntimeAgent.cpp:

(WebCore::PageRuntimeAgent::scriptStateForEval):

  • inspector/PageRuntimeAgent.h:

(PageRuntimeAgent):

  • inspector/WorkerRuntimeAgent.cpp:

(WebCore::WorkerRuntimeAgent::scriptStateForEval):

  • inspector/WorkerRuntimeAgent.h:

(WorkerRuntimeAgent):

7:33 AM Changeset in webkit [116098] by jochen@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r115549.
http://trac.webkit.org/changeset/115549
https://bugs.webkit.org/show_bug.cgi?id=83894

The newly added CRASH() statements are triggered too often

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::init):
(WebCore::FrameLoader::setupForReplace):
(WebCore::FrameLoader::stopAllLoaders):
(WebCore::FrameLoader::clearProvisionalLoad):
(WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):

7:32 AM Changeset in webkit [116097] by commit-queue@webkit.org
  • 8 edits in trunk

[EFL] LayoutTestController does not support overriding WebKitLoadSiteIconsKey
https://bugs.webkit.org/show_bug.cgi?id=85171

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-04
Reviewed by Andreas Kling.

Source/WebKit/efl:

Add a helper function to DumpRenderTreeSupportEfl to override the
"WebKitLoadSiteIconsKey" setting on the view page.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::setLoadsSiteIconsIgnoringImageLoadingSetting):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Implement support for overriding "WebKitLoadSiteIconsKey" setting in
EFL's LayoutTestController.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::overridePreference):

LayoutTests:

Unskip http/tests/misc/favicon-loads-with-icon-loading-override.html
now that EFL's LayoutTestController support overriding
WebKitLoadSiteIconsKey.

  • platform/efl/Skipped:
7:29 AM Changeset in webkit [116096] by commit-queue@webkit.org
  • 16 edits
    13 adds in trunk/LayoutTests

[EFL][DRT] Gardening away remaining SVG failures
https://bugs.webkit.org/show_bug.cgi?id=85600

Unreviewed, EFL gardening.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-05-04

  • platform/efl/svg/batik/filters/feTile-expected.png: Added.
  • platform/efl/svg/batik/filters/feTile-expected.txt:
  • platform/efl/svg/batik/filters/filterRegions-expected.png: Added.
  • platform/efl/svg/batik/filters/filterRegions-expected.txt:
  • platform/efl/svg/carto.net/button-expected.txt:
  • platform/efl/svg/carto.net/colourpicker-expected.txt:
  • platform/efl/svg/carto.net/slider-expected.txt:
  • platform/efl/svg/carto.net/window-expected.txt:
  • platform/efl/svg/css/stars-with-shadow-expected.txt: Added.
  • platform/efl/svg/hixie/error/014-expected.png: Added.
  • platform/efl/svg/hixie/error/014-expected.txt:
  • platform/efl/svg/hixie/perf/003-expected.png: Added.
  • platform/efl/svg/hixie/perf/003-expected.txt:
  • platform/efl/svg/hixie/shapes/path/001-expected.png: Added.
  • platform/efl/svg/hixie/shapes/path/001-expected.txt: Added.
  • platform/efl/svg/hixie/use/002-expected.png: Added.
  • platform/efl/svg/hixie/use/002-expected.txt:
  • platform/efl/svg/repaint/filter-child-repaint-expected.png: Added.
  • platform/efl/svg/repaint/filter-child-repaint-expected.txt:
  • platform/efl/svg/repaint/filter-repaint-expected.png: Added.
  • platform/efl/svg/repaint/filter-repaint-expected.txt:
  • platform/efl/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
  • platform/efl/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
  • platform/efl/svg/zoom/page/zoom-foreignObject-expected.png: Added.
  • platform/efl/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/efl/svg/zoom/text/zoom-foreignObject-expected.png: Added.
  • platform/efl/svg/zoom/text/zoom-foreignObject-expected.txt:
  • platform/efl/test_expectations.txt:
7:24 AM Changeset in webkit [116095] by zoltan@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Error message fix after r116091
https://bugs.webkit.org/show_bug.cgi?id=85614

Reviewed by Alexis Menard.

No new tests : error message fix.

  • WebCore.pri:
7:16 AM Changeset in webkit [116094] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

[Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=85591

Unreviewed, removing incorrect test expectations for tests that turned
to be passing on all the Gtk builders after moving from using Skipped
to test_expectations.txt and have the generic BUGWKGTK modifier.

  • platform/gtk/test_expectations.txt:
7:01 AM Changeset in webkit [116093] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, refined specifiers for unexpectedly passing tests.

  • platform/chromium/test_expectations.txt:
7:00 AM BuildingQtOnLinux edited by zoltan@webkit.org
(diff)
6:57 AM Changeset in webkit [116092] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Doesn't build with ENABLE_JIT=0
https://bugs.webkit.org/show_bug.cgi?id=85042

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-04
Reviewed by Gavin Barraclough.

  • bytecode/Operands.h:
6:50 AM Changeset in webkit [116091] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

[Qt] Build fix when using libpng version > 1.2.
https://bugs.webkit.org/show_bug.cgi?id=85614

Reviewed by Tor Arne Vestbø.

Don't enforce the version of libpng when passing the option to the linker.

No new tests : build fix.

  • WebCore.pri:
6:36 AM Changeset in webkit [116090] by rakuco@webkit.org
  • 1 edit
    3 moves in trunk/LayoutTests

[EFL] Unreviewed, fix r116067 and r116068.

Fix the names of the expectations I added in those revisions.

  • platform/efl/fast/html/details-marker-style-expected.txt: Renamed from LayoutTests/platform/efl/fast/html/details-marker-style-actual.txt.
  • platform/efl/media/media-can-play-webm-expected.txt: Renamed from LayoutTests/platform/efl/media/media-can-play-webm-actual.txt.
  • platform/efl/svg/as-image/image-respects-pageScaleFactor-expected.txt: Renamed from LayoutTests/platform/efl/svg/as-image/image-respects-pageScaleFactor-actual.txt.
6:32 AM Changeset in webkit [116089] by alexis.menard@openbossa.org
  • 13 edits in trunk

[Qt] Enable fullscreen API for WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=85498

Reviewed by Simon Hausmann.

Source/WebKit2:

Enable the fullscreen API for Qt port. It is only
supported on WebKit2. It adds experimental settings
to enable it and also add two experimental signals so
the API user can react when the fullscreen is requested
(e.g hide the urlbar of a browser and change the state
of the window to be fullscreen).

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qwebpreferences.cpp:

(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferences::fullScreenEnabled):
(QWebPreferences::setFullScreenEnabled):

  • UIProcess/API/qt/qwebpreferences_p.h:
  • UIProcess/API/qt/qwebpreferences_p_p.h:
  • UIProcess/WebFullScreenManagerProxy.h:

(WebKit):

  • UIProcess/qt/WebFullScreenManagerProxyQt.cpp:

(WebKit::WebFullScreenManagerProxy::enterFullScreen):
(WebKit::WebFullScreenManagerProxy::exitFullScreen):

Tools:

Enable the fullscreen API on the MiniBrowser and turn
it default on WebKit2, disable it on WK1.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):

  • MiniBrowser/qt/qml/BrowserWindow.qml:
  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.prf:
6:16 AM Changeset in webkit [116088] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

REGRESSION(r116008) old-run-webkit-tests broken
https://bugs.webkit.org/show_bug.cgi?id=85597

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-04
Reviewed by Simon Hausmann.

Reinstate libraryContainsSymbol.

  • Scripts/webkitperl/features.pm:

(libraryContainsSymbol):

5:53 AM Changeset in webkit [116087] by Simon Hausmann
  • 4 edits in trunk/Source

[Qt] Images are scaled badly in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=85610

Reviewed by Jocelyn Turcotte.

Source/WebCore:

Enable smooth pixmap transforms when rendering into the GraphicsSurface image.
This class is only used in WK2.

  • platform/graphics/surfaces/qt/GraphicsSurfaceQt.cpp:

(WebCore::GraphicsSurface::platformBeginPaint):

Source/WebKit2:

Enable smooth pixmap transforms for WK2 bitmaps.

  • Shared/qt/ShareableBitmapQt.cpp:

(WebKit::ShareableBitmap::createGraphicsContext):

5:19 AM Changeset in webkit [116086] by zoltan@webkit.org
  • 9 edits in trunk/Source/WebCore

[Qt] Remove unnecessary executeable bits after r116085

No new tests.

  • Target.pri:
  • WebCore.pri:
  • platform/graphics/ImageSource.cpp:
  • platform/graphics/ImageSource.h:
  • platform/graphics/qt/ImageDecoderQt.cpp:
  • platform/graphics/qt/ImageDecoderQt.h:
  • platform/image-decoders/ImageDecoder.cpp:
  • platform/image-decoders/ImageDecoder.h:
5:10 AM Changeset in webkit [116085] by zoltan@webkit.org
  • 14 edits
    1 delete in trunk

[Qt] Set WebCore imagedecoders as default and add fallback to QImageDecoder
https://bugs.webkit.org/show_bug.cgi?id=80400

Source/WebCore:

This change modifies the default ImageDecoder for Qt-port from QImageDecoder to WebCore ImageDecoder.
The new behavior is to use QImageDecoder only if WebCoreImageDecoder doesn't support the requested
image type.
The WTF_USE_QT_IMAGE_DECODER macro has been removed, since it is no longer needed.

This change adds build depedency for libpng-dev and libjpeg-dev packages, becuase PNG and JPEG imagedecoders
need not only these libraries, but their headers also. Qmake-config tests for these libraries were
introduced in r110045.

Reviewed by Simon Hausmann.

No new tests needed.

  • Target.pri: Move WebCore ImageDecoder files out of guards. Remove ImageFrameQt.cpp from sources.
  • WebCore.pri: Move WebCore ImageDecoder include paths out of guards.
  • platform/MIMETypeRegistry.cpp:

(WebCore::initializeSupportedImageMIMETypes): Add WebCore supported and Qt supported MIME types.
(WebCore::initializeSupportedImageMIMETypesForEncoding): Use Qt supported MIME types.

  • platform/graphics/ImageSource.cpp: Remove unnecessary includes.
  • platform/graphics/ImageSource.h: Remove unnecessary typedefs.

(WebCore):

  • platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoderQt::filenameExtension): Remove unnecessary semicolon.
(WebCore::ImageDecoderQt::internalHandleCurrentImage): Use QImage and ImageFrame instead of QPixmap.
(WebCore):
(WebCore::ImageFrame::asNewNativeImage): Moved here from removed ImageFrameQt.cpp.

  • platform/image-decoders/ImageDecoder.cpp: Reorganize the includes of the header.

(WebCore::ImageDecoder::create): Add platform macro guarded fallback case for QImageDecoder.

  • platform/image-decoders/ImageDecoder.h: Remove Qt-specific codes.

(WebCore::ImageFrame::getAddr): Remove Qt-specific case, since it is no longer needed.
(ImageFrame):

  • platform/image-decoders/qt/ImageFrameQt.cpp: Removed. Dead code, other code has been moved to

ImageDecoderQt.cpp.

Source/WebKit/blackberry:

Get rid off QT_IMAGE_DECODER flag.

Reviewed by Simon Hausmann.

  • WebCoreSupport/AboutDataEnableFeatures.in:

Tools:

Remove WTF_USE_QT_IMAGE_DECODER macro.

Reviewed by Simon Hausmann.

  • qmake/mkspecs/features/features.prf:
5:00 AM Changeset in webkit [116084] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, eval-blocked-in-about-blank-iframe.html: SLOW -> TIMEOUT

  • platform/chromium/test_expectations.txt:
3:59 AM Changeset in webkit [116083] by Csaba Osztrogonác
  • 6 edits
    1 add in trunk/LayoutTests

[Qt] Unreviewed gardening, update expected files.

  • platform/qt/Skipped: Typo fix.
  • platform/qt/fast/block/float/float-not-removed-from-next-sibling4-expected.png: Added.
  • platform/qt/fast/block/float/float-not-removed-from-next-sibling4-expected.txt:
  • platform/qt/fast/block/float/overhanging-tall-block-expected.png:
  • platform/qt/fast/block/float/overhanging-tall-block-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-device-orientation-expected.txt:
3:46 AM Changeset in webkit [116082] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] ietestcenter/css3/flexbox tests fail on 32 bit
https://bugs.webkit.org/show_bug.cgi?id=85596

Unreviewed gardening, skip new failing tests.

  • platform/qt/Skipped:
3:37 AM Changeset in webkit [116081] by noel.gordon@gmail.com
  • 2 edits
    6 adds in trunk/LayoutTests

[chromium] Unreviewed test expectations update after r116074

  • platform/chromium-mac/fast/images/png-suite/test-expected.png: Added.
  • platform/chromium-win/fast/images/png-suite/test-expected.png: Added.
  • platform/chromium/fast/images/png-suite/test-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
3:21 AM Changeset in webkit [116080] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, changed expectations for fast/images/png-suite/test.html from IMAGE to MISSING.

  • platform/chromium/test_expectations.txt:
3:08 AM Changeset in webkit [116079] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, marking http/tests/security/contentSecurityPolicy/eval-blocked-in-about-blank-iframe.html as slow.

  • platform/chromium/test_expectations.txt:
2:39 AM Changeset in webkit [116078] by Carlos Garcia Campos
  • 2 edits in trunk

Unreviewed, rolling out r116075.
http://trac.webkit.org/changeset/116075

WebKit2 build was broken while WebKit2 build was disabled in bots,
so nobody noticed it. Disable the WebKit2 build for now to keep
the bots green again until we find the actual commit that
broke the WebKit2 build.

  • configure.ac:
2:10 AM Changeset in webkit [116077] by loislo@chromium.org
  • 6 edits in trunk

Web Inspector: createRawLocationByURL is too slow if a big number of evals happen.
https://bugs.webkit.org/show_bug.cgi?id=85477

It iterates through all the _scripts even they have no url.
We can keep a separate map of scripts with url.

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel):
(WebInspector.DebuggerModel.prototype._globalObjectCleared):
(WebInspector.DebuggerModel.prototype._resetScriptsMap):
(WebInspector.DebuggerModel.prototype._parsedScriptSource):
(WebInspector.DebuggerModel.prototype.createRawLocationByURL):

LayoutTests:

  • http/tests/inspector/compiler-script-mapping.html:
  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • inspector/debugger/raw-source-code.html:
2:07 AM Changeset in webkit [116076] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] [DRT] fast/table/quote-text-around-iframe.html needs rebaselining
https://bugs.webkit.org/show_bug.cgi?id=85487

Unreviewed, EFL rebaseline after r115218.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-04

  • platform/efl/fast/table/quote-text-around-iframe-expected.png:
  • platform/efl/fast/table/quote-text-around-iframe-expected.txt:
1:20 AM Changeset in webkit [116075] by Carlos Garcia Campos
  • 2 edits in trunk

Unreviewed. Enable WebKit2 by default in configure.

This was removed in r115624 to make sure release 1.9.1 didn't have
WebKit2 enabled by default, because we are using the same library
versions for WebKit1 and WebKit2.

  • configure.ac: Enable WebKit2 by default.
12:25 AM Changeset in webkit [116074] by noel.gordon@gmail.com
  • 6 edits
    180 adds in trunk/LayoutTests

Add PNG image pngsuite test
https://bugs.webkit.org/show_bug.cgi?id=85567

Reviewed by Eric Seidel.

From http://www.schaik.com/pngsuite, add images from this suite and license
details. Add a layout test. Add platform exceptions (since all ports have a
different broken image).

  • fast/images/png-suite/PngSuite.LICENSE: Added.
  • fast/images/png-suite/samples/basi0g01.png: Added.
  • fast/images/png-suite/samples/basi0g02.png: Added.
  • fast/images/png-suite/samples/basi0g04.png: Added.
  • fast/images/png-suite/samples/basi0g08.png: Added.
  • fast/images/png-suite/samples/basi0g16.png: Added.
  • fast/images/png-suite/samples/basi2c08.png: Added.
  • fast/images/png-suite/samples/basi2c16.png: Added.
  • fast/images/png-suite/samples/basi3p01.png: Added.
  • fast/images/png-suite/samples/basi3p02.png: Added.
  • fast/images/png-suite/samples/basi3p04.png: Added.
  • fast/images/png-suite/samples/basi3p08.png: Added.
  • fast/images/png-suite/samples/basi4a08.png: Added.
  • fast/images/png-suite/samples/basi4a16.png: Added.
  • fast/images/png-suite/samples/basi6a08.png: Added.
  • fast/images/png-suite/samples/basi6a16.png: Added.
  • fast/images/png-suite/samples/basn0g01.png: Added.
  • fast/images/png-suite/samples/basn0g02.png: Added.
  • fast/images/png-suite/samples/basn0g04.png: Added.
  • fast/images/png-suite/samples/basn0g08.png: Added.
  • fast/images/png-suite/samples/basn0g16.png: Added.
  • fast/images/png-suite/samples/basn2c08.png: Added.
  • fast/images/png-suite/samples/basn2c16.png: Added.
  • fast/images/png-suite/samples/basn3p01.png: Added.
  • fast/images/png-suite/samples/basn3p02.png: Added.
  • fast/images/png-suite/samples/basn3p04.png: Added.
  • fast/images/png-suite/samples/basn3p08.png: Added.
  • fast/images/png-suite/samples/basn4a08.png: Added.
  • fast/images/png-suite/samples/basn4a16.png: Added.
  • fast/images/png-suite/samples/basn6a08.png: Added.
  • fast/images/png-suite/samples/basn6a16.png: Added.
  • fast/images/png-suite/samples/bgai4a08.png: Added.
  • fast/images/png-suite/samples/bgai4a16.png: Added.
  • fast/images/png-suite/samples/bgan6a08.png: Added.
  • fast/images/png-suite/samples/bgan6a16.png: Added.
  • fast/images/png-suite/samples/bgbn4a08.png: Added.
  • fast/images/png-suite/samples/bggn4a16.png: Added.
  • fast/images/png-suite/samples/bgwn6a08.png: Added.
  • fast/images/png-suite/samples/bgyn6a16.png: Added.
  • fast/images/png-suite/samples/ccwn2c08.png: Added.
  • fast/images/png-suite/samples/ccwn3p08.png: Added.
  • fast/images/png-suite/samples/cdfn2c08.png: Added.
  • fast/images/png-suite/samples/cdhn2c08.png: Added.
  • fast/images/png-suite/samples/cdsn2c08.png: Added.
  • fast/images/png-suite/samples/cdun2c08.png: Added.
  • fast/images/png-suite/samples/ch1n3p04.png: Added.
  • fast/images/png-suite/samples/ch2n3p08.png: Added.
  • fast/images/png-suite/samples/cm0n0g04.png: Added.
  • fast/images/png-suite/samples/cm7n0g04.png: Added.
  • fast/images/png-suite/samples/cm9n0g04.png: Added.
  • fast/images/png-suite/samples/cs3n2c16.png: Added.
  • fast/images/png-suite/samples/cs3n3p08.png: Added.
  • fast/images/png-suite/samples/cs5n2c08.png: Added.
  • fast/images/png-suite/samples/cs5n3p08.png: Added.
  • fast/images/png-suite/samples/cs8n2c08.png: Added.
  • fast/images/png-suite/samples/cs8n3p08.png: Added.
  • fast/images/png-suite/samples/ct0n0g04.png: Added.
  • fast/images/png-suite/samples/ct1n0g04.png: Added.
  • fast/images/png-suite/samples/cten0g04.png: Added.
  • fast/images/png-suite/samples/ctfn0g04.png: Added.
  • fast/images/png-suite/samples/ctgn0g04.png: Added.
  • fast/images/png-suite/samples/cthn0g04.png: Added.
  • fast/images/png-suite/samples/ctjn0g04.png: Added.
  • fast/images/png-suite/samples/ctzn0g04.png: Added.
  • fast/images/png-suite/samples/f00n0g08.png: Added.
  • fast/images/png-suite/samples/f00n2c08.png: Added.
  • fast/images/png-suite/samples/f01n0g08.png: Added.
  • fast/images/png-suite/samples/f01n2c08.png: Added.
  • fast/images/png-suite/samples/f02n0g08.png: Added.
  • fast/images/png-suite/samples/f02n2c08.png: Added.
  • fast/images/png-suite/samples/f03n0g08.png: Added.
  • fast/images/png-suite/samples/f03n2c08.png: Added.
  • fast/images/png-suite/samples/f04n0g08.png: Added.
  • fast/images/png-suite/samples/f04n2c08.png: Added.
  • fast/images/png-suite/samples/f99n0g04.png: Added.
  • fast/images/png-suite/samples/g03n0g16.png: Added.
  • fast/images/png-suite/samples/g03n2c08.png: Added.
  • fast/images/png-suite/samples/g03n3p04.png: Added.
  • fast/images/png-suite/samples/g04n0g16.png: Added.
  • fast/images/png-suite/samples/g04n2c08.png: Added.
  • fast/images/png-suite/samples/g04n3p04.png: Added.
  • fast/images/png-suite/samples/g05n0g16.png: Added.
  • fast/images/png-suite/samples/g05n2c08.png: Added.
  • fast/images/png-suite/samples/g05n3p04.png: Added.
  • fast/images/png-suite/samples/g07n0g16.png: Added.
  • fast/images/png-suite/samples/g07n2c08.png: Added.
  • fast/images/png-suite/samples/g07n3p04.png: Added.
  • fast/images/png-suite/samples/g10n0g16.png: Added.
  • fast/images/png-suite/samples/g10n2c08.png: Added.
  • fast/images/png-suite/samples/g10n3p04.png: Added.
  • fast/images/png-suite/samples/g25n0g16.png: Added.
  • fast/images/png-suite/samples/g25n2c08.png: Added.
  • fast/images/png-suite/samples/g25n3p04.png: Added.
  • fast/images/png-suite/samples/oi1n0g16.png: Added.
  • fast/images/png-suite/samples/oi1n2c16.png: Added.
  • fast/images/png-suite/samples/oi2n0g16.png: Added.
  • fast/images/png-suite/samples/oi2n2c16.png: Added.
  • fast/images/png-suite/samples/oi4n0g16.png: Added.
  • fast/images/png-suite/samples/oi4n2c16.png: Added.
  • fast/images/png-suite/samples/oi9n0g16.png: Added.
  • fast/images/png-suite/samples/oi9n2c16.png: Added.
  • fast/images/png-suite/samples/pp0n2c16.png: Added.
  • fast/images/png-suite/samples/pp0n6a08.png: Added.
  • fast/images/png-suite/samples/ps1n0g08.png: Added.
  • fast/images/png-suite/samples/ps1n2c16.png: Added.
  • fast/images/png-suite/samples/ps2n0g08.png: Added.
  • fast/images/png-suite/samples/ps2n2c16.png: Added.
  • fast/images/png-suite/samples/s01i3p01.png: Added.
  • fast/images/png-suite/samples/s01n3p01.png: Added.
  • fast/images/png-suite/samples/s02i3p01.png: Added.
  • fast/images/png-suite/samples/s02n3p01.png: Added.
  • fast/images/png-suite/samples/s03i3p01.png: Added.
  • fast/images/png-suite/samples/s03n3p01.png: Added.
  • fast/images/png-suite/samples/s04i3p01.png: Added.
  • fast/images/png-suite/samples/s04n3p01.png: Added.
  • fast/images/png-suite/samples/s05i3p02.png: Added.
  • fast/images/png-suite/samples/s05n3p02.png: Added.
  • fast/images/png-suite/samples/s06i3p02.png: Added.
  • fast/images/png-suite/samples/s06n3p02.png: Added.
  • fast/images/png-suite/samples/s07i3p02.png: Added.
  • fast/images/png-suite/samples/s07n3p02.png: Added.
  • fast/images/png-suite/samples/s08i3p02.png: Added.
  • fast/images/png-suite/samples/s08n3p02.png: Added.
  • fast/images/png-suite/samples/s09i3p02.png: Added.
  • fast/images/png-suite/samples/s09n3p02.png: Added.
  • fast/images/png-suite/samples/s32i3p04.png: Added.
  • fast/images/png-suite/samples/s32n3p04.png: Added.
  • fast/images/png-suite/samples/s33i3p04.png: Added.
  • fast/images/png-suite/samples/s33n3p04.png: Added.
  • fast/images/png-suite/samples/s34i3p04.png: Added.
  • fast/images/png-suite/samples/s34n3p04.png: Added.
  • fast/images/png-suite/samples/s35i3p04.png: Added.
  • fast/images/png-suite/samples/s35n3p04.png: Added.
  • fast/images/png-suite/samples/s36i3p04.png: Added.
  • fast/images/png-suite/samples/s36n3p04.png: Added.
  • fast/images/png-suite/samples/s37i3p04.png: Added.
  • fast/images/png-suite/samples/s37n3p04.png: Added.
  • fast/images/png-suite/samples/s38i3p04.png: Added.
  • fast/images/png-suite/samples/s38n3p04.png: Added.
  • fast/images/png-suite/samples/s39i3p04.png: Added.
  • fast/images/png-suite/samples/s39n3p04.png: Added.
  • fast/images/png-suite/samples/s40i3p04.png: Added.
  • fast/images/png-suite/samples/s40n3p04.png: Added.
  • fast/images/png-suite/samples/tbbn0g04.png: Added.
  • fast/images/png-suite/samples/tbbn2c16.png: Added.
  • fast/images/png-suite/samples/tbbn3p08.png: Added.
  • fast/images/png-suite/samples/tbgn2c16.png: Added.
  • fast/images/png-suite/samples/tbgn3p08.png: Added.
  • fast/images/png-suite/samples/tbrn2c08.png: Added.
  • fast/images/png-suite/samples/tbwn0g16.png: Added.
  • fast/images/png-suite/samples/tbwn3p08.png: Added.
  • fast/images/png-suite/samples/tbyn3p08.png: Added.
  • fast/images/png-suite/samples/tp0n0g08.png: Added.
  • fast/images/png-suite/samples/tp0n2c08.png: Added.
  • fast/images/png-suite/samples/tp0n3p08.png: Added.
  • fast/images/png-suite/samples/tp1n3p08.png: Added.
  • fast/images/png-suite/samples/xc1n0g08.png: Added.
  • fast/images/png-suite/samples/xc9n2c08.png: Added.
  • fast/images/png-suite/samples/xcrn0g04.png: Added.
  • fast/images/png-suite/samples/xcsn0g01.png: Added.
  • fast/images/png-suite/samples/xd0n2c08.png: Added.
  • fast/images/png-suite/samples/xd3n2c08.png: Added.
  • fast/images/png-suite/samples/xd9n2c08.png: Added.
  • fast/images/png-suite/samples/xdtn0g01.png: Added.
  • fast/images/png-suite/samples/xhdn0g08.png: Added.
  • fast/images/png-suite/samples/xlfn0g04.png: Added.
  • fast/images/png-suite/samples/xs1n0g01.png: Added.
  • fast/images/png-suite/samples/xs2n0g01.png: Added.
  • fast/images/png-suite/samples/xs4n0g01.png: Added.
  • fast/images/png-suite/samples/xs7n0g01.png: Added.
  • fast/images/png-suite/samples/z00n2c08.png: Added.
  • fast/images/png-suite/samples/z03n2c08.png: Added.
  • fast/images/png-suite/samples/z06n2c08.png: Added.
  • fast/images/png-suite/samples/z09n2c08.png: Added.
  • fast/images/png-suite/test-expected.png: Added.
  • fast/images/png-suite/test.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/efl/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/fast/images/png-suite/test-expected.png: Added.
  • platform/qt/test_expectations.txt:
  • platform/wincairo/Skipped:

May 3, 2012:

11:59 PM Changeset in webkit [116073] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] DRT should obey layoutTestController's addURLToRedirect()
https://bugs.webkit.org/show_bug.cgi?id=82722

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-03
Reviewed by Maciej Stachowiak.

Tools:

Implement support for layoutTestController's addURLToRedirect()
in EFL's DRT so that it redirects properly when indicated.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::onWillSendRequest):

LayoutTests:

Unskip http/tests/loading/cross-origin-XHR-willLoadRequest.html now
that EFL's DRT obeys layoutTestController's addURLToRedirect().

  • platform/efl/Skipped:
11:47 PM Changeset in webkit [116072] by isherman@chromium.org
  • 2 edits in trunk/LayoutTests

[Qt] REGRESSION(r113511): fast/forms/input-autofilled.html fails
Unskip the failing test now that r113511 has been reverted.
https://bugs.webkit.org/show_bug.cgi?id=83418

Reviewed by Simon Hausmann.

  • platform/qt/Skipped:
11:24 PM Changeset in webkit [116071] by commit-queue@webkit.org
  • 5 edits in trunk

[EFL] DRT should support LayoutTestController's willSendRequestReturnsNullOnRedirect()
https://bugs.webkit.org/show_bug.cgi?id=82704

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-03
Reviewed by Antonio Gomes.

Tools:

EFL's DRT needs to obey LayoutTestController's
willSendRequestReturnsNullOnRedirect().

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::onWillSendRequest):

LayoutTests:

Update test_expectations.txt now that EFL's DumpRenderTree supports
LayoutTestController's willSendRequestReturnsNullOnRedirect().

  • platform/efl/Skipped:
  • platform/efl/test_expectations.txt:
11:05 PM Changeset in webkit [116070] by zandobersek@gmail.com
  • 6 edits in trunk/LayoutTests

Unreviewed, gardening after r116009 and r116039.

  • fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
  • http/tests/workers/worker-importScriptsOnError-expected.txt:
  • platform/gtk/fast/block/float/float-not-removed-from-next-sibling4-expected.txt:
  • platform/gtk/fast/block/float/overhanging-tall-block-expected.txt:
  • platform/gtk/test_expectations.txt:
10:52 PM Changeset in webkit [116069] by commit-queue@webkit.org
  • 9 edits
    3 adds in trunk

Antialias single-edge solid borders
https://bugs.webkit.org/show_bug.cgi?id=85031

Patch by David Barr <davidbarr@chromium.org> on 2012-05-03
Reviewed by Simon Fraser.

Source/WebCore:

Antialiasing is avoided for adjacent edges due to artifacts at the seam.
There are no such artifacts for single-edge borders so enable antialiasing.

Test: fast/css/border-solid-single-edge-antialias.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBorder):

LayoutTests:

  • fast/css/border-solid-single-edge-antialias-expected.png: Added.
  • fast/css/border-solid-single-edge-antialias-expected.txt: Added.
  • fast/css/border-solid-single-edge-antialias.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/efl/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
  • platform/win/test_expectations.txt:
9:43 PM WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
9:37 PM WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
8:55 PM Changeset in webkit [116068] by rakuco@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[EFL] Unreviewed, add some other missing baselines.

  • platform/efl/fast/html/details-marker-style-actual.txt: Added.
  • platform/efl/media/media-can-play-webm-actual.txt: Added.
8:52 PM Changeset in webkit [116067] by rakuco@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

[EFL] Unreviewed, add baseline for r116001.

  • platform/efl/svg/as-image/image-respects-pageScaleFactor-actual.txt: Added.
8:45 PM Changeset in webkit [116066] by abarth@webkit.org
  • 12 edits
    3 adds in trunk

CSP: Eval isn't blocked in about:blank subframes
https://bugs.webkit.org/show_bug.cgi?id=85553

Reviewed by Eric Seidel.

Source/WebCore:

ContentSecurityPolicy has a back pointer to ScriptExecutionContext.
That means we shouldn't share a single ContentSecurityPolicy object
between multiple ScriptExecutionContexts. This patch copies the state
from one ScriptExecutionContext to another rather than sharing the
ContentSecurityPolicy object itself.

This resulted in a subtle but w.r.t. blocking eval. Because we block
eval by setting a bit in the JavaScript engine when enforcing the
policy, that bit wasn't copied along with the rest of the state when we
were sharing the ContentSecurityPolicy object. Now that we use the
more robust ContentSecurityPolicy::copyStateFrom function, we don't
have that bug.

Test: http/tests/security/contentSecurityPolicy/eval-blocked-in-about-blank-iframe.html

  • dom/Document.cpp:

(WebCore::Document::initSecurityContext):
(WebCore):
(WebCore::Document::initContentSecurityPolicy):

  • dom/Document.h:

(Document):

  • dom/SecurityContext.cpp:

(WebCore::SecurityContext::setContentSecurityPolicy):

  • dom/SecurityContext.h:

(SecurityContext):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::didBeginDocument):

  • page/ContentSecurityPolicy.h:

(WebCore::ContentSecurityPolicy::create):

LayoutTests:

  • http/tests/security/contentSecurityPolicy/eval-blocked-in-about-blank-iframe-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/eval-blocked-in-about-blank-iframe.html: Added.
    • New test for the eval issue.
  • http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt:
  • http/tests/security/contentSecurityPolicy/javascript-url-allowed-expected.txt:
  • http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-src-in-iframe-expected.txt:
    • Now that we re-parse the CSP policy, we log parse errors to the console more times. This isn't ideal and is something we might change in the future.
  • platform/chromium/http/tests/security/contentSecurityPolicy/eval-blocked-in-about-blank-iframe-expected.txt: Added.
    • Add a Chromium-specific baseline for this test because the eval error is slightly different between V8 and JSC.
8:42 PM Changeset in webkit [116065] by inferno@chromium.org
  • 3 edits in trunk/Source/WebCore

Regression(r113769): Crash in AudioNodeOutput::disconnectAllParams.
https://bugs.webkit.org/show_bug.cgi?id=85196

Reviewed by Chris Rogers.

RefPtr the AudioParam hashset in AudioNodeOutput to prevent accessing
destroyed entries.

No new tests. Unable to reproduce it in DRT.

  • Modules/webaudio/AudioNodeOutput.cpp:

(WebCore::AudioNodeOutput::disconnectAllParams):

  • Modules/webaudio/AudioNodeOutput.h:

(AudioNodeOutput):

8:25 PM Changeset in webkit [116064] by rakuco@webkit.org
  • 2 edits in trunk/Tools

git-add-reviewer: Do not put the bug title and its URL in the same line in the commit message.
https://bugs.webkit.org/show_bug.cgi?id=85570

Reviewed by Adam Roben.

The standard format of commit messages and ChangeLog entries has a
short summary in the first line, followed by the bug URL in
Bugzilla. Passing "%s" in the pretty format line to git-rev-list
merges these two lines into a single one separated by a space
character, which is not what we want.

Since "%s%n%n%b" is in practice "%B" (raw message), use it
instead, as the first two lines do not end up being merged
together.

  • Scripts/git-add-reviewer:

(writeCommitMessageToFile):

7:41 PM Changeset in webkit [116063] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Update mac test expectations after r115927
https://bugs.webkit.org/show_bug.cgi?id=85569

Patch by David Barr <davidbarr@chromium.org> on 2012-05-03
Reviewed by Dirk Pranke.

The tests were removed on r115927. Remove them from the mac test expectations.

  • platform/mac/test_expectations.txt:
6:57 PM Changeset in webkit [116062] by ojan@chromium.org
  • 4 edits in trunk/Tools

Improve UI for garden-o-matic examine view when there are fewer than 5 tests.
https://bugs.webkit.org/show_bug.cgi?id=85566

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:

(.):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:

(.):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
6:53 PM Changeset in webkit [116061] by rakuco@webkit.org
  • 5 edits in trunk/Tools

webkitpy: Recognize FreeBSD as a valid platform.
https://bugs.webkit.org/show_bug.cgi?id=81467

Reviewed by Adam Barth.

Add PlatformInfo.is_freebsd() so that trying to use webkit-patch
on FreeBSD does not raise an "unrecognized platform" exception.

Most of this patch contains some unit tests for the mentioned
method, as currently platform-specific code is needed only on
Windows.

  • Scripts/webkitpy/common/system/platforminfo.py:

(PlatformInfo.init):
(PlatformInfo.is_freebsd):
(PlatformInfo._determine_os_name):

  • Scripts/webkitpy/common/system/platforminfo_mock.py:

(MockPlatformInfo.is_freebsd):

  • Scripts/webkitpy/common/system/platforminfo_unittest.py:

(fake_platform):
(fake_platform.FakePlatformModule.release):
(TestPlatformInfo.test_real_code):
(TestPlatformInfo.test_os_name_and_wrappers):
(TestPlatformInfo.test_os_version):
(TestPlatformInfo.test_display_name):
(TestPlatformInfo.test_total_bytes_memory):
(TestPlatformInfo.test_free_bytes_memory):

  • Scripts/webkitpy/layout_tests/port/factory.py:

(PortFactory._default_port):

6:51 PM Changeset in webkit [116060] by ojan@chromium.org
  • 2 edits in trunk/Tools

Make the table headers white-space:nowrap. This decreases the vertical size,
which makes for more minimal embedding in garden-o-matic.

  • TestResultServer/static-dashboards/flakiness_dashboard_tests.css:

(.table-header-content *):

6:45 PM Changeset in webkit [116059] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

PNGImageDecoder: Clean up rowAvailable() some more
https://bugs.webkit.org/show_bug.cgi?id=85464

Reviewed by Eric Seidel.

No new tests. Covered by existing tests: fast/images/png-extra-row-crash.html in
particular.

  • platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageDecoder::rowAvailable): Use colorChannels consistently. Split
the useful libpng comments in two, then place the early-out code and conditions
inbetween. The png variable is only used in one place so move it there.

6:35 PM Changeset in webkit [116058] by ojan@chromium.org
  • 9 edits in trunk/Source

Histogram total allocated bytes in the arena in addition to the render tree size
https://bugs.webkit.org/show_bug.cgi?id=85537

Reviewed by Eric Seidel.

Source/WebCore:

We only free bytes allocated to a RenderArena when destroying the Document.
Histogram both the render tree size and the total bytes allocated. This
gives a better sense of the overhead of RenderArena as well as giving a more
accurate number for the amount of actual memory used by the render tree.

No new tests. This is not webfacing, so this can't be tested without adding
API to layout test controller, which doesn't seem worth it for this code.

  • page/Page.cpp:

(WebCore::Page::renderTreeSize):
(WebCore::Page::setVisibilityState):

  • page/Page.h:

(Page):

  • platform/Arena.cpp:

(WebCore::ArenaAllocate):

  • platform/Arena.h:

(WebCore):

  • rendering/RenderArena.cpp:

(WebCore::RenderArena::allocate):

  • rendering/RenderArena.h:

(WebCore::RenderArena::totalRenderArenaAllocatedBytes):
(RenderArena):

Source/WebKit2:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::renderTreeSize):

6:28 PM Changeset in webkit [116057] by mary.wu@torchmobile.com.cn
  • 3 edits in trunk/Source/WebCore

[BlackBerry] Add missed member in CrossThreadResourceRequestData
https://bugs.webkit.org/show_bug.cgi?id=85448

Reviewed by Antonio Gomes.

  • platform/network/blackberry/ResourceRequest.h:

(CrossThreadResourceRequestData):

  • platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::ResourceRequest::doPlatformCopyData):
(WebCore::ResourceRequest::doPlatformAdopt):

6:21 PM Changeset in webkit [116056] by zmo@google.com
  • 2 edits
    4 adds
    2 deletes in trunk/LayoutTests

Unreviewed, rebaseline.

  • platform/chromium-linux/fast/xmlhttprequest: Added.
  • platform/chromium-linux/fast/xmlhttprequest/xmlhttprequest-get-expected.txt: Added.
  • platform/chromium-mac/fast/xmlhttprequest: Removed.
  • platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt: Removed.
  • platform/chromium-mac/http/tests/workers: Removed.
  • platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
  • platform/chromium/fast/xmlhttprequest/xmlhttprequest-get-expected.txt: Added.
  • platform/chromium/http/tests/workers/worker-importScriptsOnError-expected.txt: Replaced.
6:06 PM Changeset in webkit [116055] by eric@webkit.org
  • 2 edits
    1 add in trunk/Tools

Split build-webkit's feature option list off into its own module in preparation for autogeneration
https://bugs.webkit.org/show_bug.cgi?id=85548

Reviewed by Daniel Bates.

My Perl-fu is very weak. This moves the feature option list off into a separate module
file so that I can easily autogenerate just that file with the fancy new generate-feature-files command.
It's a bit odd to have an array which we return out to build-webkit to modify, but it turns out
not to matter. Also, build-webkit doesn't actually use any of the variables we're using to
store the results from the option parse, so those end up inaccessible from build-webkit (except by reference)
which is actually cleaner. Callers can't assume that they would get a new array every time, but someone
with more Perl-fu than I could create something fancier than this if we need in the future.

  • Scripts/build-webkit:
  • Scripts/webkitperl/FeatureList.pm: Added.

(getFeatureOptionList):

6:05 PM Changeset in webkit [116054] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Regression(r114702): Clobbering the caller frame register before we've stored it.
https://bugs.webkit.org/show_bug.cgi?id=85564

Reviewed by Filip Pizlo.

Don't use t0 as a temporary, when we're about to use the value in t0.

  • llint/LowLevelInterpreter32_64.asm:
6:00 PM Changeset in webkit [116053] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/mac

useWebKitWebInspector should be more robust against missing files
https://bugs.webkit.org/show_bug.cgi?id=85563
<rdar://problem/11373948>

Reviewed by Dan Bernstein.

  • WebCoreSupport/WebInspectorClient.mm:

(useWebKitWebInspector):

5:53 PM Changeset in webkit [116052] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

CSP shouldn't block about:blank for iframes
https://bugs.webkit.org/show_bug.cgi?id=85233

Reviewed by Eric Seidel.

Source/WebCore:

As discussed at the W3C WebAppSec face-to-face meeting, there's no
point in blocking about:blank iframes or objects because blocking a
frame or object just results in displaying about:blank anyway. This
patch just removes the spurious console message and violation report.

Test: http/tests/security/contentSecurityPolicy/frame-src-about-blank-allowed-by-default.html

  • page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::allowObjectFromSource):
(WebCore::ContentSecurityPolicy::allowChildFrameFromSource):

LayoutTests:

Test that about:blank iframes and objects don't generate debug log
messages.

  • http/tests/security/contentSecurityPolicy/frame-src-about-blank-allowed-by-default-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/frame-src-about-blank-allowed-by-default.html: Added.
5:49 PM Changeset in webkit [116051] by zmo@google.com
  • 147 edits
    3 deletes in trunk

Unreviewed, rolling out r116040.
http://trac.webkit.org/changeset/116040
https://bugs.webkit.org/show_bug.cgi?id=85559

Broke a few IndexedDB browsertests (Requested by zhenyao on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-03

Source/WebCore:

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::direction):

  • Modules/indexeddb/IDBCursor.h:

(IDBCursor):

  • Modules/indexeddb/IDBCursor.idl:
  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::transaction):
(WebCore):

  • Modules/indexeddb/IDBDatabase.h:
  • Modules/indexeddb/IDBDatabase.idl:
  • Modules/indexeddb/IDBIndex.cpp:

(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):

  • Modules/indexeddb/IDBIndex.h:

(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):

  • Modules/indexeddb/IDBIndex.idl:
  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::openCursor):

  • Modules/indexeddb/IDBObjectStore.h:

(WebCore::IDBObjectStore::openCursor):
(IDBObjectStore):

  • Modules/indexeddb/IDBObjectStore.idl:
  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::readyState):
(WebCore::IDBRequest::markEarlyDeath):
(WebCore::IDBRequest::resetReadyState):
(WebCore::IDBRequest::abort):
(WebCore::IDBRequest::finishCursor):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::stop):

  • Modules/indexeddb/IDBRequest.h:
  • Modules/indexeddb/IDBRequest.idl:
  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::mode):

  • Modules/indexeddb/IDBTransaction.h:

(IDBTransaction):

  • Modules/indexeddb/IDBTransaction.idl:

LayoutTests:

  • http/tests/inspector/indexeddb/indexeddb-test.js:
  • storage/indexeddb/basics-expected.txt:
  • storage/indexeddb/basics-workers-expected.txt:
  • storage/indexeddb/constants-expected.txt:
  • storage/indexeddb/create-object-store-options-expected.txt:
  • storage/indexeddb/cursor-added-bug-expected.txt:
  • storage/indexeddb/cursor-advance-expected.txt:
  • storage/indexeddb/cursor-continue-expected.txt:
  • storage/indexeddb/cursor-continue-validity-expected.txt:
  • storage/indexeddb/cursor-delete-expected.txt:
  • storage/indexeddb/cursor-inconsistency-expected.txt:
  • storage/indexeddb/cursor-index-delete-expected.txt:
  • storage/indexeddb/cursor-key-order-expected.txt:
  • storage/indexeddb/cursor-prev-no-duplicate-expected.txt:
  • storage/indexeddb/cursor-primary-key-order-expected.txt:
  • storage/indexeddb/cursor-reverse-bug-expected.txt:
  • storage/indexeddb/cursor-skip-deleted-expected.txt:
  • storage/indexeddb/cursor-update-expected.txt:
  • storage/indexeddb/data-corruption-expected.txt:
  • storage/indexeddb/database-quota-expected.txt:
  • storage/indexeddb/delete-range-expected.txt:
  • storage/indexeddb/error-causes-abort-by-default-expected.txt:
  • storage/indexeddb/exception-in-event-aborts-expected.txt:
  • storage/indexeddb/factory-deletedatabase-expected.txt:
  • storage/indexeddb/index-count-expected.txt:
  • storage/indexeddb/index-multientry-expected.txt:
  • storage/indexeddb/index-unique-expected.txt:
  • storage/indexeddb/key-generator-expected.txt:
  • storage/indexeddb/key-type-array-expected.txt:
  • storage/indexeddb/keypath-edges-expected.txt:
  • storage/indexeddb/keypath-intrinsic-properties-expected.txt:
  • storage/indexeddb/legacy-constants-expected.txt: Removed.
  • storage/indexeddb/legacy-constants.html: Removed.
  • storage/indexeddb/mozilla/clear-expected.txt:
  • storage/indexeddb/mozilla/create-index-unique-expected.txt:
  • storage/indexeddb/mozilla/create-objectstore-basics-expected.txt:
  • storage/indexeddb/mozilla/cursor-mutation-expected.txt:
  • storage/indexeddb/mozilla/cursor-mutation-objectstore-only-expected.txt:
  • storage/indexeddb/mozilla/cursors-expected.txt:
  • storage/indexeddb/mozilla/index-prev-no-duplicate-expected.txt:
  • storage/indexeddb/mozilla/index-prev-no-duplicate.html:
  • storage/indexeddb/mozilla/indexes-expected.txt:
  • storage/indexeddb/mozilla/odd-result-order-expected.txt:
  • storage/indexeddb/mozilla/readwrite-transactions-expected.txt:
  • storage/indexeddb/mozilla/readyState-expected.txt:
  • storage/indexeddb/mozilla/resources/clear.js:

(clear):

  • storage/indexeddb/mozilla/resources/create-index-unique.js:

(createAndVerifyIndex):

  • storage/indexeddb/mozilla/resources/create-objectstore-basics.js:

(cleanDatabase):

  • storage/indexeddb/mozilla/resources/cursor-mutation-objectstore-only.js:

(checkCursorResultsAndSetupMutatingCursor):

  • storage/indexeddb/mozilla/resources/cursor-mutation.js:

(setupMutatingCursor):

  • storage/indexeddb/mozilla/resources/cursors.js:
  • storage/indexeddb/mozilla/resources/indexes.js:
  • storage/indexeddb/mozilla/resources/odd-result-order.js:

(addRecord):
(deleteRecord):

  • storage/indexeddb/mozilla/resources/readwrite-transactions.js:

(setVersionComplete):
(postAdd):
(postAdd2):
(postPut):
(postPut2):
(postPut3):
(postPut4):
(postDelete):
(postDelete2):

  • storage/indexeddb/mozilla/resources/readyState.js:

(test):
(openSuccess):
(setupObjectStore):
(getRecord):
(finalCheck):

  • storage/indexeddb/mozilla/resources/versionchange.js:

(postSetVersion):
(postSetVersion2):

  • storage/indexeddb/mozilla/versionchange-expected.txt:
  • storage/indexeddb/mutating-cursor-expected.txt:
  • storage/indexeddb/noblobs-expected.txt:
  • storage/indexeddb/noblobs.html:
  • storage/indexeddb/objectstore-autoincrement-expected.txt:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics-workers-expected.txt:
  • storage/indexeddb/objectstore-count-expected.txt:
  • storage/indexeddb/open-cursor-expected.txt:
  • storage/indexeddb/open-during-transaction-expected.txt:
  • storage/indexeddb/opencursor-key-expected.txt:
  • storage/indexeddb/prefetch-bugfix-108071-expected.txt:
  • storage/indexeddb/readonly-expected.txt:
  • storage/indexeddb/request-event-propagation-expected.txt:
  • storage/indexeddb/resources/basics.js:

(test):
(openCallback):

  • storage/indexeddb/resources/constants.js:

(test):

  • storage/indexeddb/resources/create-object-store-options.js:

(setVersionComplete):

  • storage/indexeddb/resources/cursor-added-bug.js:

(openCursor):

  • storage/indexeddb/resources/cursor-advance.js:

(runTest):
(testAdvanceIndexNoDupe):
(testAdvanceIndexPrev):
(testAdvanceIndexPrevNoDupe):

  • storage/indexeddb/resources/cursor-continue-validity.js:

(continueTest):
(continueIndexTest):
(testModifyContinueOrder):

  • storage/indexeddb/resources/cursor-continue.js:

(ascendingTest):
(descendingTest):

  • storage/indexeddb/resources/cursor-delete.js:

(openCursor):
(addObject):

  • storage/indexeddb/resources/cursor-inconsistency.js:

(openBasicCursor):

  • storage/indexeddb/resources/cursor-index-delete.js:

(openCursor):
(addObject):

  • storage/indexeddb/resources/cursor-key-order.js:
  • storage/indexeddb/resources/cursor-prev-no-duplicate.js:

(populateStore):
(testFarRangeCursor_closed):
(testFarRangeCursor_open):
(testFarRangeCursor_indexClosed):
(testFarRangeCursor_indexOpen):
(testFarRangeCursor_indexKeyOpen):
(testFarRangeCursor_indexKeyClosed):
(testBoundaryCursor_closed):
(testBoundaryCursor_open):
(testBoundaryCursor_indexClosed):
(testBoundaryCursor_indexOpen):
(testBoundaryCursor_indexKeyClosed):
(testBoundaryCursor_indexKeyOpen):
(testNoDuplicate_closed):
(testNoDuplicate_open):
(testNoDuplicate_indexKeyClosed):

  • storage/indexeddb/resources/cursor-primary-key-order.js:

(populateStore):

  • storage/indexeddb/resources/cursor-reverse-bug.js:

(populateStore):
(testCursor):

  • storage/indexeddb/resources/cursor-skip-deleted.js:

(basicCursorTest):
(reverseCursorTest):

  • storage/indexeddb/resources/cursor-update.js:

(openBasicCursor):

  • storage/indexeddb/resources/data-corruption.js:

(addData):
(getData):

  • storage/indexeddb/resources/database-quota.js:

(checkQuotaEnforcing):

  • storage/indexeddb/resources/delete-range.js:

(runTests.nextTest):
(runTests):

  • storage/indexeddb/resources/error-causes-abort-by-default.js:

(addData):
(transactionCompleted):
(transactionAborted1):

  • storage/indexeddb/resources/exception-in-event-aborts.js:

(startTest):
(transactionAborted1):
(transactionAborted2):

  • storage/indexeddb/resources/factory-deletedatabase.js:

(getValue):

  • storage/indexeddb/resources/index-count.js:
  • storage/indexeddb/resources/index-cursor.js:

(runNextTest):
(testNullKeyRange):

  • storage/indexeddb/resources/index-multientry.js:
  • storage/indexeddb/resources/index-unique.js:

(setVersionCompleted):

  • storage/indexeddb/resources/key-generator.js:

(.):

  • storage/indexeddb/resources/key-type-array.js:
  • storage/indexeddb/resources/keypath-edges.js:
  • storage/indexeddb/resources/keypath-intrinsic-properties.js:
  • storage/indexeddb/resources/legacy-constants.js: Removed.
  • storage/indexeddb/resources/mutating-cursor.js:

(openForwardCursor):
(openReverseCursor):

  • storage/indexeddb/resources/objectstore-autoincrement.js:

(setVersionCompleted):

  • storage/indexeddb/resources/objectstore-basics.js:

(addData):
(addAgainFailure):

  • storage/indexeddb/resources/objectstore-count.js:
  • storage/indexeddb/resources/objectstore-cursor.js:

(runNextTest):
(testNullKeyRange):

  • storage/indexeddb/resources/open-cursor.js:

(cursorWithKeySuccess):
(cursorSuccess):

  • storage/indexeddb/resources/open-during-transaction.js:
  • storage/indexeddb/resources/opencursor-key.js:
  • storage/indexeddb/resources/prefetch-bugfix-108071.js:
  • storage/indexeddb/resources/request-event-propagation.js:

(startTest):
(transactionAborted):
(transactionAborted2):

  • storage/indexeddb/resources/set_version_blocked.js:

(blocked):

  • storage/indexeddb/resources/transaction-abort.js:

(startTest):

  • storage/indexeddb/resources/transaction-after-close.js:

(runFirstRegularTransaction):
(firstTransactionComplete):
(onSecondOpen):

  • storage/indexeddb/resources/transaction-basics.js:

(testInvalidMode):

  • storage/indexeddb/resources/transaction-event-propagation.js:

(startTest):
(dbAbortBubbleCallback):

  • storage/indexeddb/resources/transaction-rollback.js:

(setVersionComplete):
(abortCallback):

  • storage/indexeddb/set_version_blocked-expected.txt:
  • storage/indexeddb/structured-clone-expected.txt:
  • storage/indexeddb/structured-clone.html:
  • storage/indexeddb/transaction-abort-expected.txt:
  • storage/indexeddb/transaction-abort-with-js-recursion-cross-frame-expected.txt:
  • storage/indexeddb/transaction-abort-with-js-recursion-cross-frame.html:
  • storage/indexeddb/transaction-abort-with-js-recursion-expected.txt:
  • storage/indexeddb/transaction-abort-with-js-recursion.html:
  • storage/indexeddb/transaction-after-close-expected.txt:
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-event-propagation-expected.txt:
  • storage/indexeddb/transaction-rollback-expected.txt:
  • storage/indexeddb/tutorial.html:
5:49 PM FeatureFlags edited by tkent@chromium.org
Remove NATIVE_FULLSCREEN_VIDEO, add PARSED_STYLE_SHEET_CACHING (diff)
5:42 PM Changeset in webkit [116050] by dpranke@chromium.org
  • 2 edits in trunk/Tools

REGRESSION: run-webkit-tests failing on Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=85459

Unreviewed, build fix.

Turns out select doesn't throw IOErrors, it has it's own kind of
error :(. Trap that instead.

  • Scripts/webkitpy/layout_tests/port/server_process.py:

(ServerProcess._wait_for_data_and_update_buffers_using_select):

5:39 PM Changeset in webkit [116049] by rakuco@webkit.org
  • 11 edits in trunk

[CMake] Rewrite FindCairo.cmake.
https://bugs.webkit.org/show_bug.cgi?id=84895

Reviewed by Daniel Bates.

The old approach relied on pkg-config for finding Cairo (which
introduced a dependency on pkg-config that could be avoided), used
the LibFindMacros code that we should probably remove in the
future and did not use the FindPackageHandleStandardArguments
module.

Change all that by rewriting the module.

  • Use the pkg-config output optionally instead of requiring it

like LibFindMacros did.

  • Remove the implicit dependency on FreeType which often found it

the wrong way via pkg-config and without considering
CMAKE_PREFIX_PATH.

  • Retrieve the Cairo version by looking at cairo-version.h instead

of relying on pkg-config. It requires some additional code for
checking if the desired version has been found, but that will not
be needed once we start depending on CMake 2.8.3 or later.

The only downside is that FPHSA sets <UPPERCASED_NAME>_FOUND
instead of <Name>_FOUND, and to keep things consistent
Cairo_LIBRARIES and Cairo_INCLUDE_DIRS have become CAIRO_LIBRARIES
and CAIRO_INCLUDE_DIRS.

.:

  • Source/cmake/FindCairo.cmake:

Source/WebCore:

No new tests, build system change.

  • PlatformEfl.cmake: Use CAIRO_FOO instead of Cairo_FOO.

Source/WebKit:

  • PlatformEfl.cmake: Use CAIRO_FOO instead of Cairo_FOO.

Source/WebKit2:

  • PlatformEfl.cmake: Use CAIRO_FOO instead of Cairo_FOO.

Tools:

  • DumpRenderTree/efl/CMakeLists.txt: Use CAIRO_FOO instead of

Cairo_FOO.

  • EWebLauncher/CMakeLists.txt: Ditto.
5:36 PM Changeset in webkit [116048] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Focus ring only appears in top-left tile
https://bugs.webkit.org/show_bug.cgi?id=85556
<rdar://problem/11359656>

Reviewed by Simon Fraser.

It is sufficient to just apply the current CTM to the clip rect and set that as the focus ring clip rect.

  • platform/graphics/mac/WebLayer.mm:

(drawLayerContents):

5:16 PM Changeset in webkit [116047] by zmo@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
5:04 PM Changeset in webkit [116046] by ojan@chromium.org
  • 3 edits in trunk/Tools

Fix modifier and bug sorting on the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=85554

Reviewed by Dirk Pranke.

The sorting assumes that the column header name matches a field
in the testResults object and uses that field for sorting.
Filter the bugs out of the modifiers list and put them in a bugs field
and only put the non-bug modifiers in the modifiers list.

  • TestResultServer/static-dashboards/flakiness_dashboard.js:

(populateExpectationsData):
(htmlForSingleTestRow):

  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
4:57 PM Changeset in webkit [116045] by ojan@chromium.org
  • 3 edits in trunk/Tools

Fix some state resetting when running unittests. HtmlForSingleTestRow
was flaky.

  • TestResultServer/static-dashboards/flakiness_dashboard.js:

(htmlForSingleTestRow):

  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

(resetGlobals):

4:55 PM Changeset in webkit [116044] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Removing remainder of accidental printfs.

  • heap/Heap.cpp:

(JSC::Heap::collect):

4:51 PM Changeset in webkit [116043] by aestes@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

If you add printf()s to your garbage collector, the layout tests are gonna have a bad time.

  • runtime/GCActivityCallbackCF.cpp:

(JSC::DefaultGCActivityCallbackPlatformData::timerDidFire):

4:45 PM Changeset in webkit [116042] by rakuco@webkit.org
  • 2 edits in trunk/Tools

webkitpy: Use PlatformInfo wherever possible in the User class.
https://bugs.webkit.org/show_bug.cgi?id=85549

Reviewed by Dirk Pranke.

Instead of relying on sys.platform to detect whether the current
platform is a Mac, use the PlatformInfo class instead.

  • Scripts/webkitpy/common/system/user.py:

(User.init):
(User.edit_changelog):

4:41 PM Changeset in webkit [116041] by ojan@chromium.org
  • 3 edits in trunk/Tools

Remove the percent failed column from the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=85552

Reviewed by Dirk Pranke.

This column isn't useful enough to justify the visual noise.

  • TestResultServer/static-dashboards/flakiness_dashboard.js:

(processMissingAndExtraExpectations):
(tableHeaders):
(htmlForSingleTestRow):
(sortTests):

  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

(test):

4:39 PM Changeset in webkit [116040] by commit-queue@webkit.org
  • 147 edits
    3 adds in trunk

IndexedDB: Replace numeric constants with strings
https://bugs.webkit.org/show_bug.cgi?id=84894

Patch by Alec Flett <alecflett@chromium.org> on 2012-05-03
Reviewed by Tony Chang.

Source/WebCore:

Test: storage/indexeddb/legacy-constants.html

Update IDBObjectStore.openCursor, IDBIndex.openCursor,
IDBIndex.openKeyCursor, IDBDatabase.transaction,
IDBCursor.direction, IDBTransaction.mode, and
IDBRequest.readyState to meet the latest spec. All of these APIs
now support string-based values in addition to the
legacy/deprecated enum-based values.

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore):
(WebCore::IDBCursor::direction):
(WebCore::IDBCursor::stringToDirection):
(WebCore::IDBCursor::directionToString):

  • Modules/indexeddb/IDBCursor.h:

(IDBCursor):

  • Modules/indexeddb/IDBCursor.idl:
  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::transaction):
(WebCore):

  • Modules/indexeddb/IDBDatabase.h:

(IDBDatabase):

  • Modules/indexeddb/IDBDatabase.idl:
  • Modules/indexeddb/IDBIndex.cpp:

(WebCore::IDBIndex::openCursor):
(WebCore):
(WebCore::IDBIndex::openKeyCursor):

  • Modules/indexeddb/IDBIndex.h:

(WebCore::IDBIndex::openCursor):
(IDBIndex):
(WebCore::IDBIndex::openKeyCursor):

  • Modules/indexeddb/IDBIndex.idl:
  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::openCursor):
(WebCore):

  • Modules/indexeddb/IDBObjectStore.h:

(WebCore::IDBObjectStore::openCursor):
(IDBObjectStore):

  • Modules/indexeddb/IDBObjectStore.idl:
  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::readyState):
(WebCore::IDBRequest::markEarlyDeath):
(WebCore::IDBRequest::resetReadyState):
(WebCore::IDBRequest::abort):
(WebCore::IDBRequest::finishCursor):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::stop):

  • Modules/indexeddb/IDBRequest.h:
  • Modules/indexeddb/IDBRequest.idl:
  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore):
(WebCore::IDBTransaction::mode):
(WebCore::IDBTransaction::stringToMode):
(WebCore::IDBTransaction::modeToString):

  • Modules/indexeddb/IDBTransaction.h:

(IDBTransaction):

  • Modules/indexeddb/IDBTransaction.idl:

LayoutTests:

New test for legacy constants (legacy-constants) and update all
other tests to use the new string-based constants.

  • storage/indexeddb/basics-expected.txt:
  • storage/indexeddb/basics-workers-expected.txt:
  • storage/indexeddb/constants-expected.txt:
  • storage/indexeddb/create-object-store-options-expected.txt:
  • storage/indexeddb/cursor-added-bug-expected.txt:
  • storage/indexeddb/cursor-advance-expected.txt:
  • storage/indexeddb/cursor-continue-expected.txt:
  • storage/indexeddb/cursor-continue-validity-expected.txt:
  • storage/indexeddb/cursor-delete-expected.txt:
  • storage/indexeddb/cursor-inconsistency-expected.txt:
  • storage/indexeddb/cursor-index-delete-expected.txt:
  • storage/indexeddb/cursor-key-order-expected.txt:
  • storage/indexeddb/cursor-prev-no-duplicate-expected.txt:
  • storage/indexeddb/cursor-primary-key-order-expected.txt:
  • storage/indexeddb/cursor-reverse-bug-expected.txt:
  • storage/indexeddb/cursor-skip-deleted-expected.txt:
  • storage/indexeddb/cursor-update-expected.txt:
  • storage/indexeddb/data-corruption-expected.txt:
  • storage/indexeddb/database-quota-expected.txt:
  • storage/indexeddb/delete-range-expected.txt:
  • storage/indexeddb/error-causes-abort-by-default-expected.txt:
  • storage/indexeddb/exception-in-event-aborts-expected.txt:
  • storage/indexeddb/factory-deletedatabase-expected.txt:
  • storage/indexeddb/index-count-expected.txt:
  • storage/indexeddb/index-multientry-expected.txt:
  • storage/indexeddb/index-unique-expected.txt:
  • storage/indexeddb/key-generator-expected.txt:
  • storage/indexeddb/key-type-array-expected.txt:
  • storage/indexeddb/keypath-edges-expected.txt:
  • storage/indexeddb/keypath-intrinsic-properties-expected.txt:
  • storage/indexeddb/legacy-constants-expected.txt: Added.
  • storage/indexeddb/legacy-constants.html: Added.
  • storage/indexeddb/mozilla/clear-expected.txt:
  • storage/indexeddb/mozilla/create-index-unique-expected.txt:
  • storage/indexeddb/mozilla/create-objectstore-basics-expected.txt:
  • storage/indexeddb/mozilla/cursor-mutation-expected.txt:
  • storage/indexeddb/mozilla/cursor-mutation-objectstore-only-expected.txt:
  • storage/indexeddb/mozilla/cursors-expected.txt:
  • storage/indexeddb/mozilla/index-prev-no-duplicate-expected.txt:
  • storage/indexeddb/mozilla/index-prev-no-duplicate.html:
  • storage/indexeddb/mozilla/indexes-expected.txt:
  • storage/indexeddb/mozilla/odd-result-order-expected.txt:
  • storage/indexeddb/mozilla/readwrite-transactions-expected.txt:
  • storage/indexeddb/mozilla/readyState-expected.txt:
  • storage/indexeddb/mozilla/resources/clear.js:

(clear):

  • storage/indexeddb/mozilla/resources/create-index-unique.js:

(createAndVerifyIndex):

  • storage/indexeddb/mozilla/resources/create-objectstore-basics.js:

(cleanDatabase):

  • storage/indexeddb/mozilla/resources/cursor-mutation-objectstore-only.js:

(checkCursorResultsAndSetupMutatingCursor):

  • storage/indexeddb/mozilla/resources/cursor-mutation.js:

(setupMutatingCursor):

  • storage/indexeddb/mozilla/resources/cursors.js:
  • storage/indexeddb/mozilla/resources/indexes.js:
  • storage/indexeddb/mozilla/resources/odd-result-order.js:

(addRecord):
(deleteRecord):

  • storage/indexeddb/mozilla/resources/readwrite-transactions.js:

(setVersionComplete):
(postAdd):
(postAdd2):
(postPut):
(postPut2):
(postPut3):
(postPut4):
(postDelete):
(postDelete2):

  • storage/indexeddb/mozilla/resources/readyState.js:

(test):
(openSuccess):
(setupObjectStore):
(getRecord):
(finalCheck):

  • storage/indexeddb/mozilla/resources/versionchange.js:

(postSetVersion):
(postSetVersion2):

  • storage/indexeddb/mozilla/versionchange-expected.txt:
  • storage/indexeddb/mutating-cursor-expected.txt:
  • storage/indexeddb/noblobs-expected.txt:
  • storage/indexeddb/noblobs.html:
  • storage/indexeddb/objectstore-autoincrement-expected.txt:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics-workers-expected.txt:
  • storage/indexeddb/objectstore-count-expected.txt:
  • storage/indexeddb/open-cursor-expected.txt:
  • storage/indexeddb/open-during-transaction-expected.txt:
  • storage/indexeddb/opencursor-key-expected.txt:
  • storage/indexeddb/prefetch-bugfix-108071-expected.txt:
  • storage/indexeddb/readonly-expected.txt:
  • storage/indexeddb/request-event-propagation-expected.txt:
  • storage/indexeddb/resources/basics.js:

(test):
(openCallback):

  • storage/indexeddb/resources/constants.js:

(test):

  • storage/indexeddb/resources/create-object-store-options.js:

(setVersionComplete):

  • storage/indexeddb/resources/cursor-added-bug.js:

(openCursor):

  • storage/indexeddb/resources/cursor-advance.js:

(runTest):
(testAdvanceIndexNoDupe):
(testAdvanceIndexPrev):
(testAdvanceIndexPrevNoDupe):

  • storage/indexeddb/resources/cursor-continue-validity.js:

(continueTest):
(continueIndexTest):
(testModifyContinueOrder):

  • storage/indexeddb/resources/cursor-continue.js:

(ascendingTest):
(descendingTest):

  • storage/indexeddb/resources/cursor-delete.js:

(openCursor):
(addObject):

  • storage/indexeddb/resources/cursor-inconsistency.js:

(openBasicCursor):

  • storage/indexeddb/resources/cursor-index-delete.js:

(openCursor):
(addObject):

  • storage/indexeddb/resources/cursor-key-order.js:
  • storage/indexeddb/resources/cursor-prev-no-duplicate.js:

(populateStore):
(testFarRangeCursor_closed):
(testFarRangeCursor_open):
(testFarRangeCursor_indexClosed):
(testFarRangeCursor_indexOpen):
(testFarRangeCursor_indexKeyOpen):
(testFarRangeCursor_indexKeyClosed):
(testBoundaryCursor_closed):
(testBoundaryCursor_open):
(testBoundaryCursor_indexClosed):
(testBoundaryCursor_indexOpen):
(testBoundaryCursor_indexKeyClosed):
(testBoundaryCursor_indexKeyOpen):
(testNoDuplicate_closed):
(testNoDuplicate_open):
(testNoDuplicate_indexKeyClosed):

  • storage/indexeddb/resources/cursor-primary-key-order.js:

(populateStore):

  • storage/indexeddb/resources/cursor-reverse-bug.js:

(populateStore):
(testCursor):

  • storage/indexeddb/resources/cursor-skip-deleted.js:

(basicCursorTest):
(reverseCursorTest):

  • storage/indexeddb/resources/cursor-update.js:

(openBasicCursor):

  • storage/indexeddb/resources/data-corruption.js:

(addData):
(getData):

  • storage/indexeddb/resources/database-quota.js:

(checkQuotaEnforcing):

  • storage/indexeddb/resources/delete-range.js:

(runTests.nextTest):
(runTests):

  • storage/indexeddb/resources/error-causes-abort-by-default.js:

(addData):
(transactionCompleted):
(transactionAborted1):

  • storage/indexeddb/resources/exception-in-event-aborts.js:

(startTest):
(transactionAborted1):
(transactionAborted2):

  • storage/indexeddb/resources/factory-deletedatabase.js:

(getValue):

  • storage/indexeddb/resources/index-count.js:
  • storage/indexeddb/resources/index-cursor.js:

(runNextTest):
(testNullKeyRange):

  • storage/indexeddb/resources/index-multientry.js:
  • storage/indexeddb/resources/index-unique.js:

(setVersionCompleted):

  • storage/indexeddb/resources/key-generator.js:

(.):

  • storage/indexeddb/resources/key-type-array.js:
  • storage/indexeddb/resources/keypath-edges.js:
  • storage/indexeddb/resources/keypath-intrinsic-properties.js:
  • storage/indexeddb/resources/legacy-constants.js: Added.

(test):
(prepareDatabase.openreq.onsuccess.verreq.onsuccess):
(prepareDatabase.openreq.onsuccess):
(prepareDatabase):
(populateStore):
(checkNext.request.onsuccess):
(checkNext):
(checkNextNoDuplicate.request.onsuccess):
(checkNextNoDuplicate):
(checkPrev.request.onsuccess):
(checkPrev):
(checkPrevNoDuplicate.request.onsuccess):
(checkPrevNoDuplicate):

  • storage/indexeddb/resources/mutating-cursor.js:

(openForwardCursor):
(openReverseCursor):

  • storage/indexeddb/resources/objectstore-autoincrement.js:

(setVersionCompleted):

  • storage/indexeddb/resources/objectstore-basics.js:

(addData):
(addAgainFailure):

  • storage/indexeddb/resources/objectstore-count.js:
  • storage/indexeddb/resources/objectstore-cursor.js:

(runNextTest):
(testNullKeyRange):

  • storage/indexeddb/resources/open-cursor.js:

(cursorWithKeySuccess):
(cursorSuccess):

  • storage/indexeddb/resources/open-during-transaction.js:
  • storage/indexeddb/resources/opencursor-key.js:
  • storage/indexeddb/resources/prefetch-bugfix-108071.js:
  • storage/indexeddb/resources/request-event-propagation.js:

(startTest):
(transactionAborted):
(transactionAborted2):

  • storage/indexeddb/resources/set_version_blocked.js:

(blocked):

  • storage/indexeddb/resources/transaction-abort.js:

(startTest):

  • storage/indexeddb/resources/transaction-after-close.js:

(runFirstRegularTransaction):
(firstTransactionComplete):
(onSecondOpen):

  • storage/indexeddb/resources/transaction-basics.js:

(testInvalidMode):

  • storage/indexeddb/resources/transaction-event-propagation.js:

(startTest):
(dbAbortBubbleCallback):

  • storage/indexeddb/resources/transaction-rollback.js:

(setVersionComplete):
(abortCallback):

  • storage/indexeddb/set_version_blocked-expected.txt:
  • storage/indexeddb/structured-clone-expected.txt:
  • storage/indexeddb/structured-clone.html:
  • storage/indexeddb/transaction-abort-expected.txt:
  • storage/indexeddb/transaction-abort-with-js-recursion-cross-frame-expected.txt:
  • storage/indexeddb/transaction-abort-with-js-recursion-cross-frame.html:
  • storage/indexeddb/transaction-abort-with-js-recursion-expected.txt:
  • storage/indexeddb/transaction-abort-with-js-recursion.html:
  • storage/indexeddb/transaction-after-close-expected.txt:
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-event-propagation-expected.txt:
  • storage/indexeddb/transaction-rollback-expected.txt:
  • storage/indexeddb/tutorial.html:
4:24 PM Changeset in webkit [116039] by weinig@apple.com
  • 8 edits in trunk

Add an eventPhase NONE constant
https://bugs.webkit.org/show_bug.cgi?id=85397

Reviewed by Anders Carlsson.

Source/WebCore:

Updates existing tests.

  • dom/Event.h:
  • dom/Event.idl:

Add NONE constant.

LayoutTests:

  • fast/dom/constants-expected.txt:
  • fast/dom/constants.html:

Test the value of the constant.

  • fast/events/event-trace-expected.txt:
  • fast/events/event-trace.html:

Ensure that the eventPhase is NONE when first initialized.

4:21 PM Changeset in webkit [116038] by tony@chromium.org
  • 3 edits
    2 adds in trunk

Height overflow when nesting multiple new Flexbox'es.
https://bugs.webkit.org/show_bug.cgi?id=83572

Reviewed by Ojan Vafai.

Source/WebCore:

Test: css3/flexbox/nested-stretch.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computeAvailableFreeSpace):

LayoutTests:

  • css3/flexbox/nested-stretch-expected.txt: Added.
  • css3/flexbox/nested-stretch.html: Added.
4:10 PM Changeset in webkit [116037] by tomz@codeaurora.org
  • 6 edits in trunk/LayoutTests

Unreviewed gardening

  • platform/chromium/test_expectations.txt:
  • platform/efl/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
4:09 PM Changeset in webkit [116036] by eric@webkit.org
  • 2 edits in trunk/Tools

--coverage should not not use the "feature" options system in build-webkit, similarly remove special-casing for WTF_URL
https://bugs.webkit.org/show_bug.cgi?id=85542

Reviewed by Daniel Bates.

Remove these last two odd-men-out, so that we can generate the default feature options
for build-webkit using the new generate-feature-files command.
The Mac build system has some special casing for ENABLE_ defines which gets them
defined as -D on the build command, even though initially they start out as
environment variables ENABLE_FOO = ENABLE_FOO. The Feature options in build-webkit
depend on this support, but it doesn't work for WTF_USE_ defines like WTF_USE_WTF_URL.
I'm told that WTF_URL is not actively being worked on, so just removing it for now.
It should probably come back to life as an ENABLE_, or build-webkit or the Xcode projects
should be made generically smarter about these USE_WTF defines.
(There is still WTF_USE_TILED_BACKING_STORE in the feature list, but it only seems
used by Qt. If someone tried build-webkit --tiled-backing-store on Mac today it
would not work!)

  • Scripts/build-webkit:
3:59 PM Changeset in webkit [116035] by zmo@google.com
  • 2 edits
    2 adds in trunk/LayoutTests

Unreviewed, rebaseline.

  • platform/chromium-win-vista/fast/css/zoom-body-scroll-expected.txt: Added.
  • platform/chromium-win-xp/fast/css/zoom-body-scroll-expected.txt: Added.
  • platform/chromium-win/fast/css/zoom-body-scroll-expected.txt:
3:54 PM Changeset in webkit [116034] by eric@webkit.org
  • 4 edits in trunk/Tools

Remove the last bits of Leopard support from our perl scripts
https://bugs.webkit.org/show_bug.cgi?id=85545

Reviewed by Daniel Bates.

Chromium still supports Leopard (for a little while yet), but AppleMacWebKit dropped
Leopard support several months ago. Remove the last bits of isLeopard() branching
in our Perl scripts, since no one is using this (Chromium has never used this Perl code).

  • Scripts/build-webkit:
  • Scripts/old-run-webkit-tests:

(countAndPrintLeaks):
(captureSavedCrashLog):

  • Scripts/webkitdirs.pm:

(determineArchitecture):
(argumentsForRunAndDebugMacWebKitApp):

3:51 PM Changeset in webkit [116033] by leviw@chromium.org
  • 2 edits
    2 adds
    3 deletes in trunk/LayoutTests

Updating expectations after r116009.

  • platform/chromium-linux/fast/block/float/overhanging-tall-block-expected.txt: Removed.
  • platform/chromium-mac/fast/block/float/overhanging-tall-block-expected.png: Added.
  • platform/chromium-mac/fast/block/float/overhanging-tall-block-expected.txt: Added.
  • platform/chromium-win/fast/block/float/overhanging-tall-block-expected.txt:
  • platform/chromium/fast/block/float/overhanging-tall-block-expected.png: Removed.
  • platform/chromium/fast/block/float/overhanging-tall-block-expected.txt: Removed.
3:50 PM Changeset in webkit [116032] by jchaffraix@webkit.org
  • 3 edits in trunk/Source/WebCore

ASSERT(!m_zOrderListsDirty) is triggering in Safari
https://bugs.webkit.org/show_bug.cgi?id=85512

Reviewed by Simon Fraser.

Unfortunately no test as I don't think the 2 cases are testable reliably.

A better fix would be to introduce some iterator that handle updating the
lists for you. For now, just adding the missing updateLayerListsIfNeeded()
calls.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::hasVisibleNonCompositingDescendantLayers):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::layerHas3DContent):

3:48 PM Changeset in webkit [116031] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Bugs in WebFullScreenController
https://bugs.webkit.org/show_bug.cgi?id=85388

Patch by Tobias Netzel <tobias.netzel@googlemail.com> on 2012-05-03
Reviewed by Alexey Proskuryakov.

Leopard specific fixes:
NSWindow doesn't respond to isOnActiveSpace so find out first.
Values passed to SetSystemUIMode were swapped.

Source/WebKit/mac:

  • WebView/WebFullScreenController.mm:

(-[WebFullScreenController exitFullScreen]):
(-[WebFullScreenController _updateMenuAndDockForFullScreen]):

Source/WebKit2:

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController beganExitFullScreenWithInitialFrame:WebCore::finalFrame:WebCore::]):
(-[WKFullScreenWindowController _updateMenuAndDockForFullScreen]):

3:44 PM Changeset in webkit [116030] by pdr@google.com
  • 3 edits
    3 adds in trunk

Fix numeric precision issue in SVG animations
https://bugs.webkit.org/show_bug.cgi?id=85502

Reviewed by Dirk Schulze.

Source/WebCore:

r93938 had a bug where floating point numbers where compared exactly,
exposing a bug when floating point precision was not sufficient. This
change compares against an epsilon value to get around these precision
issues.

Test: svg/animations/animate-end-attribute-numeric-precision.html

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):

LayoutTests:

  • svg/animations/animate-end-attribute-numeric-precision-expected.txt: Added.
  • svg/animations/animate-end-attribute-numeric-precision.html: Added.
  • svg/animations/script-tests/animate-end-attribute-numeric-precision.js: Added.

(sample1):
(sample2):
(executeTest):

3:44 PM Changeset in webkit [116029] by ojan@chromium.org
  • 3 edits in trunk/Tools

[Chromium] Don't show the WebKit Linux ASAN bot on the flakiness dashboard.
https://bugs.webkit.org/show_bug.cgi?id=85551

Reviewed by Dirk Pranke.

It's not uploading results and in the short term we don't plan to have it start.

  • TestResultServer/static-dashboards/builders.js:

(isChromiumWebkitTipOfTreeTestRunner):

  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3:41 PM Changeset in webkit [116028] by jsbell@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix coding style issues in IDBLevelDBCoding.cpp
https://bugs.webkit.org/show_bug.cgi?id=85536

Reviewed by Tony Chang.

No tests - just code formatting changes.

  • Modules/indexeddb/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::encodeIDBKey):
(WebCore::IDBLevelDBCoding::decodeIDBKey):
(WebCore::IDBLevelDBCoding::extractEncodedIDBKey):
(WebCore::IDBLevelDBCoding::compareEncodedIDBKeys):

3:36 PM Changeset in webkit [116027] by fpizlo@apple.com
  • 3 edits in trunk/Source/WebCore

PageCache autorelease should not wait until 3 seconds and 42 pages
https://bugs.webkit.org/show_bug.cgi?id=85254
<rdar://problem/11349613>

Reviewed by Geoffrey Garen.

No new tests, since there is no change in behavior.

  • history/PageCache.cpp:

(WebCore):
(WebCore::PageCache::PageCache):
(WebCore::PageCache::releaseAutoreleasedPagesNowDueToTimer):

  • history/PageCache.h:

(PageCache):

3:34 PM Changeset in webkit [116026] by ojan@chromium.org
  • 3 edits in trunk/Tools

Show the test name in the dashboard if showChrome==false and we're showing multiple tests
https://bugs.webkit.org/show_bug.cgi?id=85243

Reviewed by Dirk Pranke.

This happens for cases where a test name matches multiple tests.
In practice, this only happens for virtual test suites (e.g. the canvas tests).

  • TestResultServer/static-dashboards/flakiness_dashboard.js:

(htmlForIndividualTestOnAllBuildersWithChrome):

  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

(testHtmlForIndividualTestOnAllBuildersWithChromeNonexistant):
(testHtmlForIndividualTestOnAllBuildersWithChrome):
(testHtmlForIndividualTestOnAllBuildersWithChromeWebkitMaster):
(testHtmlForIndividualTests):

3:31 PM Changeset in webkit [116025] by mhahnenberg@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Heap::reportAbandonedObjectGraph should not hasten an allocation-triggered collection
https://bugs.webkit.org/show_bug.cgi?id=85543

Reviewed by Filip Pizlo.

Currently reportAbandonedObjectGraph causes the Heap to think it is closer to its
allocation limit for the current cycle, thus hastening an allocation-triggered collection.
In reality, it should just affect the opportunistic GC timer. We should track the bytes
we think have been abandoned and the bytes that have been allocated separately.

  • heap/Heap.cpp: Added a new field m_abandonedBytes to Heap to keep track of how much

we think we've abandoned.
(JSC::Heap::Heap):
(JSC::Heap::reportAbandonedObjectGraph):
(JSC):
(JSC::Heap::didAbandon): Added this function for reportAbandonedObjectGraph to call
rather than didAllocate. Works the same as didAllocate, but modifies bytes abandoned rather
than bytes allocated. Also notifies the timer, summing the two values together.
(JSC::Heap::collect):
(JSC::Heap::didAllocate): Now adds the bytes allocated and bytes abandoned when reporting
to GCActivityCallback.

  • heap/Heap.h:

(Heap):

3:29 PM Changeset in webkit [116024] by ojan@chromium.org
  • 3 edits
    1 add in trunk/Tools

Port the flakiness dashboard unittests to qunit
https://bugs.webkit.org/show_bug.cgi?id=85544

Reviewed by Adam Barth.

  • TestResultServer/static-dashboards/dashboard_base.js:

(appendJSONScriptElements):

  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

(resetGlobals):
(runExpectationsTest):
(test):

  • TestResultServer/static-dashboards/run-unittests.html: Added.
3:29 PM Changeset in webkit [116023] by zmo@google.com
  • 1 edit
    11 adds in trunk/LayoutTests

Unreviewed, rebaseline.

  • platform/chromium-mac-leopard/svg/as-image/image-respects-pageScaleFactor-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-image/image-respects-pageScaleFactor-expected.png: Added.
  • platform/chromium-mac/svg/as-image/image-respects-pageScaleFactor-expected.png: Added.
  • platform/chromium-win-vista/svg/as-image: Added.
  • platform/chromium-win-vista/svg/as-image/image-respects-pageScaleFactor-expected.png: Added.
  • platform/chromium-win-vista/svg/as-image/image-respects-pageScaleFactor-expected.txt: Added.
  • platform/chromium-win-xp/svg/as-image: Added.
  • platform/chromium-win-xp/svg/as-image/image-respects-pageScaleFactor-expected.png: Added.
  • platform/chromium-win-xp/svg/as-image/image-respects-pageScaleFactor-expected.txt: Added.
  • platform/chromium-win/svg/as-image/image-respects-pageScaleFactor-expected.png: Added.
  • platform/chromium-win/svg/as-image/image-respects-pageScaleFactor-expected.txt: Added.
3:10 PM Changeset in webkit [116022] by rakuco@webkit.org
  • 2 edits in trunk/Tools

webkitpy: Remove check for readline on Mac.
https://bugs.webkit.org/show_bug.cgi?id=85547

Reviewed by Eric Seidel.

Python 2.5 is not supported by the WebKit project anymore, and
Python's readline documentation does not mention the module not
being available in the supported versions.

  • Scripts/webkitpy/common/system/user.py:
3:09 PM Changeset in webkit [116021] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[NRWT] Run performance tests with lock
https://bugs.webkit.org/show_bug.cgi?id=78628

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-03
Reviewed by Tony Chang.

Locking performance tests (like we do for http tests) will force them
to run in serial. This reduces the load of the machine when running perf
tests and minimizes the chances of the tests to fail, specially
timeouts.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.init):
(Manager._is_perf_test):
(Manager._test_requires_lock):

  • Scripts/webkitpy/layout_tests/port/http_lock.py:
3:06 PM Changeset in webkit [116020] by dpranke@chromium.org
  • 2 edits in trunk/Tools

Attempt to fix a crash on SL ...

Unreviewed, build fix.

It looks like we may be getting an IOError raised during
select() on chromium mac, and that error isn't being caught.
Pushing it into the try/catch block will hopefully catch this
and allow us to see why the subprocess is crashing.

  • Scripts/webkitpy/layout_tests/port/server_process.py:

(ServerProcess._wait_for_data_and_update_buffers_using_select):

2:56 PM Changeset in webkit [116019] by eae@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed test expectations update for zoom event test due to slight change in rounding in hit testing code post the switch to FractionalLayoutUnits.

  • fast/events/zoom-dblclick-expected.txt:
  • fast/events/zoom-dblclick.html:
2:49 PM Changeset in webkit [116018] by tomz@codeaurora.org
  • 6 edits
    49 adds in trunk/LayoutTests

Integrate IETC CSS : flexbox tests
https://bugs.webkit.org/show_bug.cgi?id=85210

Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-05-03
Reviewed by Adam Barth.

Added 24 IETC Flexbox tests and reference tests. Three of these fail and have
new bugs written against them. Failing tests added to test_expectations.txt
for the various ports.

  • ietestcenter/css3/flexbox/flexbox-align-baseline-001-expected.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-align-baseline-001.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-align-center-001-expected.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-align-center-001.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-align-center-002-expected.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-align-center-002.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-align-end-001-expected.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-align-end-001.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-align-start-001-expected.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-align-start-001.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-align-stretch-001-expected.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-align-stretch-001.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-direction-001-expected.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-direction-001.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-flex-001-expected.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-flex-001.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-flex-002-expected.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-flex-002.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-flex-003-expected.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-flex-003.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-flex-004-expected.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-flex-004.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-flex-005-expected.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-flex-005.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-groups-001-expected.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-groups-001.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-groups-002-expected.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-groups-002.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-groups-003-expected.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-groups-003.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-groups-004-expected.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-groups-004.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-layout-001-expected.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-layout-001.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-layout-002-expected.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-layout-002.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-layout-003-expected.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-layout-003.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-ordinal-group-001-expected.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-ordinal-group-001.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-pack-center-001-expected.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-pack-center-001.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-pack-end-001-expected.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-pack-end-001.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-pack-justify-001-expected.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-pack-justify-001.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-pack-start-001-expected.htm: Added.
  • ietestcenter/css3/flexbox/flexbox-pack-start-001.htm: Added.
  • platform/chromium/test_expectations.txt:
  • platform/efl/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
2:47 PM Changeset in webkit [116017] by leviw@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for Mac WK2. Adding a mistakenly removed symbol back to WebCore.exp.in.

  • WebCore.exp.in:
2:47 PM Changeset in webkit [116016] by jhoneycutt@apple.com
  • 9 edits
    1 copy
    2 adds in trunk

WebFrameLoaderClient::dispatchWillSendSubmitEvent() needs to be
implemented for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=84304

Reviewed by Jessie Berlin.

Source/WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:

Declare willSendSubmitEvent on WKBundlePageFormClient.

  • WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:

(WebKit::InjectedBundlePageFormClient::willSendSubmitEvent):
From the String pair vector, create a map from control name to value.
Call the client's willSendSubmitEvent.

  • WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:

Declare willSendSubmitEvent.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchWillSendSubmitEvent):
Call the injected bundle form client's willSendSubmitEvent.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Un-stub willSendSubmitEvent.

  • Shared/APIClientTraits.cpp:

(WebKit):
Set the interface sizes for WKBundlePageFormClient; version 1 includes
willSendSubmitEvent.

  • Shared/APIClientTraits.h:

Declare a specialization for WKBundlePageFormClient.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:

Bump the WKBundlePageFormClient version number.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

Added new files to project.

  • TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp: Added.

(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
Look for the "DidReceiveWillSendSubmitEvent" message. The message body
will be the dictionary of form control names and values passed to the
injected bundle's willSendSubmitEvent handler; look for the pairs
"textField" -> "text field" and "passwordField" -> "password field".
Check that "hiddenField" is not included.
(TestWebKitAPI::setInjectedBundleClient):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp: Added.

(TestWebKitAPI::willSendSubmitEvent):
Post a message to the TestWebKitAPI process with the dictionary of form
control names and values that we received.
(TestWebKitAPI::WillSendSubmitEventTest::WillSendSubmitEventTest):
(TestWebKitAPI::WillSendSubmitEventTest::didCreatePage):
Set up the page's form client.

  • TestWebKitAPI/Tests/WebKit2/auto-submitting-form.html: Added.
2:46 PM Changeset in webkit [116015] by Lucas Forschler
  • 1 copy in tags/Safari-536.10

New Tag.

2:44 PM Changeset in webkit [116014] by eae@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations update, mark a column test as failing due to overflow.

  • platform/chromium/test_expectations.txt:
2:31 PM Changeset in webkit [116013] by leviw@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for Qt after 116009. No changes in behavior.

  • rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):

2:18 PM Changeset in webkit [116012] by eae@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed test expectations change for chromium, skip subpixel tests until SUBPIXEL_LAYOUT is enabled.

  • platform/chromium/test_expectations.txt:
2:17 PM Changeset in webkit [116011] by wjmaclean@chromium.org
  • 4 edits in trunk/Source

[chromium] Revise touchpad fling curve to use exponential curve, to improve feel and small fling performance.
https://bugs.webkit.org/show_bug.cgi?id=85530

Reviewed by Kenneth Russell.

Source/WebCore:

Existing unit tests updated for new curve.

Modifies TouchpadFLingGestureCurve to use an exponential, rather than polynomial, curve.
This change appears to improve the overall feel of touchpad fling, and substantially
improves small-fling performance.

  • platform/TouchpadFlingPlatformGestureCurve.cpp:

(WebCore::TouchpadFlingPlatformGestureCurve::create):
(WebCore):
(WebCore::position):
(WebCore::velocity):
(WebCore::TouchpadFlingPlatformGestureCurve::TouchpadFlingPlatformGestureCurve):

Source/WebKit/chromium:

  • tests/PlatformGestureCurveTest.cpp:
2:10 PM Changeset in webkit [116010] by rakuco@webkit.org
  • 3 edits
    1 add in trunk/LayoutTests

[EFL] Unreviewed gardening.

  • platform/efl/fast/html/details-position-expected.txt: Added.
  • platform/efl/fast/replaced/width100percent-checkbox-expected.txt:
  • platform/efl/fast/replaced/width100percent-radio-expected.txt:
2:07 PM Changeset in webkit [116009] by leviw@chromium.org
  • 32 edits
    7 adds in trunk

[meta] Switch away from integers representing pixels for layout/event handling/rendering
https://bugs.webkit.org/show_bug.cgi?id=60318

Source/WebCore:

Patch by Levi Weintraub <leviw@chromium.org> and Emil A Eklund <eae@chromium.org> on 2012-04-23
Reviewed by Eric Seidel.

Swapping the LayoutUnit backend to FractionalLayoutUnit from int.

FractionalLayoutUnit is a new type that uses an integer to represent a fraction of a pixel.
We're also adding a feature flag -- ENABLE_SUBPIXEL_LAYOUT -- that toggles this fraction
between 1/1 and 1/60. Initially, all platforms will default to subpixel layout being off,
so FractionalLayoutUnits will effectively continue to act as integers.

With ENABLE_SUBPIXEL_LAYOUT turned on, FractionalLayoutUnits accumulate error from sub-pixel
CSS values and applied zooming, and painting uses pixel-snapping to align these values
to pixels. See http://trac.webkit.org/wiki/LayoutUnit for details.

In a number of previous patches, LayoutUnits were plumbed throughout the rendering tree
to prepare for this change. This included a number of functions in LayoutTypes.h and
the IntRect/Point/Size classes that were effectively no-ops while LayoutUnits were
integers. Subsequent patches will remove unnecessary versions of these functions; see
http://webkit.org/b/84616 for tracking these changes.

Tests: fast/sub-pixel/client-width-height-snapping.html

fast/sub-pixel/layout-boxes-with-zoom.html
fast/sub-pixel/size-of-box-with-zoom.html

  • WebCore.exp.in: Updating function signatures that expose FractionalLayoutUnits.
  • WebCore.xcodeproj/project.pbxproj: Adding missing FractionalLayoutPoint.h header.
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::zoomAdjustedPixelValue): Using adjustFloatForAbsoluteZoom instead of int
to make use of extra precision before returning the pixel value.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::computeLength): No longer rounds for imprecise conversion
when sub-pixel layout is enabled.
(WebCore::CSSPrimitiveValue::customCssText): Returning integer values for pixels.

  • dom/Element.cpp:

(WebCore::adjustForLocalZoom): Using rounding instead of incrementing the value before
adjusting to account for truncation when sub-pixel layout is enabled.

  • page/SpatialNavigation.cpp:

(WebCore::distanceDataForNode): Using FractionalLayoutUnit::abs instead of std::abs.

  • platform/FractionalLayoutUnit.h: Adding some missing operators and a flag around the

constant denominator to switch it between 1/1 and 1/60 depending on the feature flag.

  • platform/Length.h: Changing the default type for value to float, and adding intValue

since this more closely matches usage in a sub-pixel layout world.

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::paint): Using minimumIntValueForLength in this platform code
instead of LayoutUnits.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesInBlockDirection):

  • rendering/LayoutTypes.h: This file contains the actual switch for changing LayoutUnits

to be FractionalLayoutUnits. Also updating stub methods with their proper implementations.

  • rendering/PaintInfo.h:

(WebCore::PaintInfo::infiniteRect): Ensuring the infiniteRect doesn't overflow the
FractionalLayoutUnit bounds.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::checkPaginationAndFloatsAtEndLine): Switch to
FractionalLayoutUnit's abs function instead of std::abs.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): Add rounding for
setting the phase of the background geometry before applying modulo from the tile size.

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox): Stop applying flex when
we have less than a pixel to distribute.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::backgroundClipRect): Replace PaintInfo::infiniteRect with the
LayoutRect equivalent.

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::rangeIntersectsRect): Using FractionalLayoutUnit::abs
instead of std::abs.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::repaintAfterLayoutIfNeeded): Ditto.

  • rendering/RenderObject.h:

(WebCore): Removing unnecessary adjustForAbsoluteZoom function.
(WebCore::RenderObject::outlineSize): Outlines remain ints.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::styleOrColLogicalWidth): Build fix. Using floats because
colWidthSum is a Length which uses floats.

  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton): Explicit templatization
for max.

  • rendering/RenderTreeAsText.cpp: Adding code to minimize test expectation churn. It

may be worth outputting float values in test expectations, but this isn't done with
the inline box tree yet, either.

  • rendering/RenderTreeAsText.h:

(WebCore): Adding a FractionalLayoutPoint operator.

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::updateWidgetGeometry): Adding missing pixel snapping, and switching
absoluteContentBox to an IntRect, as this is what boundingBox returns.

  • rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::writePositionAndStyle): Adding an enclosingIntRect for consistency with old results.

LayoutTests:

Reviewed by Eric Seidel.

  • fast/sub-pixel: Added.
  • fast/sub-pixel/client-width-height-snapping-expected.txt: Added.
  • fast/sub-pixel/client-width-height-snapping.html: Added.
  • fast/sub-pixel/size-of-box-with-zoom-expected.html: Added.
  • fast/sub-pixel/size-of-box-with-zoom.html: Added.
  • fast/sub-pixel/layout-boxes-with-zoom-expected.html: Added.
  • fast/sub-pixel/layout-boxes-with-zoom.html: Added.
2:07 PM Changeset in webkit [116008] by eric@webkit.org
  • 3 edits in trunk/Tools

Remove dead code from build-webkit for working around old XCode dependency bug
https://bugs.webkit.org/show_bug.cgi?id=85535

Reviewed by Adam Barth.

Xcode used to have a bug whereby it didn't notice if you changed the #defines
passed on the command line to xcodebuild. I wrote code to work around this
while bringing up SVG support 5-6 years ago. I think we can finally remove this
code from build-webkit, since SVG is the only feature flag to ever use it
(modern in-progress features like MathML don't seem to be using the support)
an I suspect the XCode bug has long been fixed.

  • Scripts/build-webkit:
  • Scripts/webkitperl/features.pm:
2:01 PM Changeset in webkit [116007] by rakuco@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

[EFL] Unreviewed, remove expectation which was failing.

The current result matches the base expectation, so remove the
port-specific one.

  • platform/efl/fast/css/zoom-body-scroll-expected.txt: Removed.
1:55 PM Changeset in webkit [116006] by zmo@google.com
  • 5 edits
    1 add
    3 deletes in trunk/LayoutTests

Unreviewed, rebaseline.

  • platform/chromium-mac/compositing/geometry/foreground-layer-expected.txt: Removed.
  • platform/chromium-mac/compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • platform/chromium-win/compositing/geometry/ancestor-overflow-change-expected.txt:
  • platform/chromium-win/compositing/geometry/foreground-layer-expected.txt: Removed.
  • platform/chromium-win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • platform/chromium-win/compositing/overflow/clip-descendents-expected.txt:
  • platform/chromium/compositing/geometry/foreground-layer-expected.txt: Replaced.
  • platform/chromium/compositing/iframes/invisible-nested-iframe-show-expected.txt: Removed.
1:43 PM Changeset in webkit [116005] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Move repaint counter drawing code out into a separate function
https://bugs.webkit.org/show_bug.cgi?id=85539

Reviewed by Simon Fraser.

The majority of code in TileCache::drawLayer deals with drawing the repaint counter. Move this code out
into a separate function to make it more clear what drawLayer does.

  • platform/graphics/ca/mac/TileCache.h:

(TileCache):

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::drawLayer):
(WebCore::TileCache::drawRepaintCounter):
(WebCore):

1:42 PM Changeset in webkit [116004] by fpizlo@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed, unskipping fixed test.

  • platform/mac/Skipped:
1:39 PM PrefixedAPIs edited by ddorwin@chromium.org
Added Encrypted Media and link for Media Source. (diff)
1:32 PM Changeset in webkit [116003] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Compositing 'requiresOwnBackingStore' logic caused new clip rect assertions
https://bugs.webkit.org/show_bug.cgi?id=85455

Reviewed by Dean Jackson.

r114283 added logic that allows compositing layers to avoid allocating their own
backing store and to paint into an ancestor instead. However, that caused
assertions in RenderLayer::updateClipRects() about m_clipRectsRoot being
incorrect, because clip rect code assumed that compositing layers
always painted themselves.

Fixed by calling paintsIntoCompositedAncestor() in RenderLayer::clippingRoot(),
so that clip rect computation matches painting.

I wasn't able to easily make a test that reproduces the assertion in DRT.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::clippingRoot):

1:29 PM Changeset in webkit [116002] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Use correct define in the features.gypi
https://bugs.webkit.org/show_bug.cgi?id=85520

Patch by Ben Goodger.

Patch by Dimitri Glazkov <Dimitri Glazkov> on 2012-05-03
Reviewed by Tony Chang.

  • features.gypi: Replaced use_aura with a more appropriate chromeos
1:25 PM Changeset in webkit [116001] by timothy_horton@apple.com
  • 10 edits
    8 adds in trunk

REGRESSION(99539): SVG <img> disregards page scale and device scale
https://bugs.webkit.org/show_bug.cgi?id=77237
<rdar://problem/10767413>

Reviewed by Simon Fraser.

Rename SVGImageCache::SizeAndZoom to SVGImageCache::SizeAndScales, as it carries more than just zoom now.

Pass the product of the device and page scales through everything that takes a SVGImageCache::SizeAndScales,
using it to inflate the size of the buffer created in lookupOrCreateBitmapImageForRenderer,
and to inflate the destination rectangle passed to SVGImage::draw, which will cause a transformation
on the context being drawn into.

Invalidate the SVGImageCache entry on device/page scale changes in addition to zoom changes.

This patch does not cause SVGImageCache to take into account scale caused by CSS transforms; that is tracked
separately by https://bugs.webkit.org/show_bug.cgi?id=85335.

Tests: svg/as-image/image-respects-deviceScaleFactor.html

svg/as-image/image-respects-pageScaleFactor.html

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::setContainerSizeForRenderer):
(WebCore::CachedImage::imageSizeForRenderer):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawSVGToImageBuffer):

  • svg/graphics/SVGImage.h:
  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::~SVGImageCache):
(WebCore::SVGImageCache::removeRendererFromCache):
(WebCore::SVGImageCache::setRequestedSizeAndScales):
(WebCore::SVGImageCache::requestedSizeAndScales):
(WebCore::SVGImageCache::redraw):
(WebCore::SVGImageCache::lookupOrCreateBitmapImageForRenderer):

  • svg/graphics/SVGImageCache.h:

(WebCore::SVGImageCache::SizeAndScales::SizeAndScales):
(SizeAndScales):
(SVGImageCache):
(WebCore::SVGImageCache::ImageData::ImageData):
(ImageData):

Add tests ensuring that SVG used via <img> respects deviceScaleFactor and pageScaleFactor.

  • platform/chromium-linux/svg/as-image/image-respects-pageScaleFactor-expected.txt: Added.
  • platform/chromium-linux/svg/as-image/image-respects-pageScaleFactor-expected.png: Added.
  • platform/chromium/test_expectations.txt:
  • platform/qt/Skipped:
  • platform/mac/svg/as-image/image-respects-deviceScaleFactor-expected.png: Added.
  • platform/mac/svg/as-image/image-respects-deviceScaleFactor-expected.txt: Added.
  • platform/mac/svg/as-image/image-respects-pageScaleFactor-expected.png: Added.
  • platform/mac/svg/as-image/image-respects-pageScaleFactor-expected.txt: Added.
  • platform/efl/Skipped:
  • svg/as-image/image-respects-deviceScaleFactor.html: Added.
  • svg/as-image/image-respects-pageScaleFactor.html: Added.
1:04 PM Changeset in webkit [116000] by aestes@apple.com
  • 2 edits in trunk/Tools

InjectedBundleControllerMac.mm needs to include config.h
https://bugs.webkit.org/show_bug.cgi?id=85531

Reviewed by Andreas Kling.

  • TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
12:59 PM Changeset in webkit [115999] by rakuco@webkit.org
  • 3 edits in trunk/Tools

webkitpy: Use PlatformInfo whenever possible in server_process.py.
https://bugs.webkit.org/show_bug.cgi?id=85516

Reviewed by Eric Seidel.

Eliminate direct access to sys.platform wherever possible by using
PlatformInfo.is_win() instead.

  • Scripts/webkitpy/layout_tests/port/server_process.py:

(ServerProcess.init): Remove the executive parameter as it was
not passed by any caller, obtain a SystemHost from port_obj
instead.
(ServerProcess._log): Style, remove extra empty line.
(ServerProcess._start):
(ServerProcess.stop):
(ServerProcess.kill):

  • Scripts/webkitpy/layout_tests/port/server_process_unittest.py:

(TrivialMockPort.init): Create a MockSystemHost used by
ServerProcess.
(TestServerProcess.test_broken_pipe): Test different platforms.

12:41 PM Changeset in webkit [115998] by fsamuel@chromium.org
  • 19 edits in trunk

Removing line in computeViewportAttributes that enforces a minimum scale factor to never allow zooming out more than viewport
https://bugs.webkit.org/show_bug.cgi?id=70609

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Make Viewport Attributes' layoutSize be a FloatRect to avoid rounding
too early, and the occasional off by one fixed layout dimensions.

  • dom/ViewportArguments.cpp:

(WebCore::computeViewportAttributes):

  • dom/ViewportArguments.h:

(ViewportAttributes):

Source/WebKit/blackberry:

  • WebKitSupport/DumpRenderTreeSupport.cpp:

(DumpRenderTreeSupport::dumpConfigurationForViewport):

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::dumpConfigurationForViewport):

Source/WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::dumpConfigurationForViewport):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPage::viewportAttributesForSize):

  • Api/qwebpage.h:
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::viewportAsText):

Source/WebKit2:

  • UIProcess/API/qt/qwebviewportinfo.cpp:

(QWebViewportInfo::layoutSize):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::sendViewportAttributesChanged):
(WebKit::WebPage::viewportConfigurationAsText):

12:33 PM Changeset in webkit [115997] by jsbell@chromium.org
  • 9 edits in trunk

IndexedDB: Handle generated keys up to 253
https://bugs.webkit.org/show_bug.cgi?id=85114

Source/WebCore:

The spec defines the behavior for generated keys up to 253
(the maximum integer storable as an ECMAScript number) and
the error case when going beyond that. Ensure that we can
handle values up to that point and generate errors beyond.

Reviewed by Tony Chang.

Test: storage/indexeddb/key-generator.html

  • Modules/indexeddb/IDBBackingStore.h:

(IDBBackingStore):

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):

  • Modules/indexeddb/IDBLevelDBBackingStore.h:

(IDBLevelDBBackingStore):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::genAutoIncrementKey):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(IDBObjectStoreBackendImpl):

LayoutTests:

Reviewed by Tony Chang.

  • storage/indexeddb/key-generator-expected.txt:
  • storage/indexeddb/resources/key-generator.js:

(get defineTest):

12:00 PM Changeset in webkit [115996] by fpizlo@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. skip failing test.

https://bugs.webkit.org/show_bug.cgi?id=85529

  • platform/mac/Skipped:
11:57 AM Changeset in webkit [115995] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

Add methods to create WebArrayBuffer/WebArrayBufferView from v8 objects
https://bugs.webkit.org/show_bug.cgi?id=84899

Patch by Antony Sargent <asargent@chromium.org> on 2012-05-03
Reviewed by Adam Barth.

  • public/WebArrayBuffer.h:

(WebArrayBuffer):

  • public/platform/WebArrayBufferView.h:

(v8):
(WebArrayBufferView):

  • src/WebArrayBuffer.cpp:

(WebKit):
(WebKit::WebArrayBuffer::createFromV8Value):

  • src/WebArrayBufferView.cpp:

(WebKit):
(WebKit::WebArrayBufferView::createFromV8Value):

11:47 AM Changeset in webkit [115994] by fpizlo@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed, skipping flaky tests.

https://bugs.webkit.org/show_bug.cgi?id=85522
https://bugs.webkit.org/show_bug.cgi?id=85523
https://bugs.webkit.org/show_bug.cgi?id=85524
https://bugs.webkit.org/show_bug.cgi?id=85525

  • platform/mac/Skipped:
11:18 AM Changeset in webkit [115993] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Removed dumpAsText() from this ref test, since that apparently confuses the test tool.

  • fast/writing-mode/flipped-blocks-inline-map-local-to-container.html:
11:15 AM Changeset in webkit [115992] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

Remove RenderLayerCompositor::didStartAcceleratedAnimation()
https://bugs.webkit.org/show_bug.cgi?id=85514

Reviewed by Antti Koivisto.

Remove RenderLayerCompositor::didStartAcceleratedAnimation(), which is no longer
needed.

Code removal, no new tests.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::startTransition):

  • rendering/RenderLayerCompositor.cpp:
  • rendering/RenderLayerCompositor.h:
11:08 AM Changeset in webkit [115991] by kling@webkit.org
  • 8 edits in trunk

REGRESSION(r111387): CSSOM representation of 'background-image' values should be CSSPrimitiveValue.
<http://webkit.org/b/85500>

Reviewed by Antti Koivisto.

Source/WebCore:

Use the cloneForCSSOM() mechanism in CSSValue to expose CSSImageValue to bindings as a URI
primitive value. This matches the specced behavior of computed image values, and restores our
previous behavior without having CSSImageValue subclass CSSPrimitiveValue.

Also added a failsafe return after the isCSSOMSafe() assertion in the JSC bindings, since it's
better to expose an incorrect return value than an insecurely shared one, should we have or add
bugs in this code.

  • bindings/js/JSCSSValueCustom.cpp:

(WebCore::toJS):

  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::cloneForCSSOM):

  • css/CSSImageValue.h:
  • css/CSSValue.cpp:

(WebCore::CSSValue::cloneForCSSOM):

LayoutTests:

Update fast/css/image-value-type.html to reflect that CSSImageValue are now exposed
as primitive values in the CSSOM.

  • fast/css/image-value-type-expected.txt:
  • fast/css/image-value-type.html:
10:54 AM Changeset in webkit [115990] by keishi@webkit.org
  • 7 edits in trunk

Crash in HTMLFormControlElement::m_fieldSetAncestor
https://bugs.webkit.org/show_bug.cgi?id=85453

Reviewed by Kent Tamura.

Source/WebCore:

Modified tests: fast/forms/datalist/datalist-child-validation.html

fast/forms/form-control-element-crash.html

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::removedFrom): Only set the invalid ancestor flag.
The element will be detached from the document so there is no need to update the style.
And the validation message will be hidden by the blur event.
(WebCore::HTMLFormControlElement::willValidate): Because of the change to removedFrom,
m_ancestorsValid may be false.

LayoutTests:

  • fast/forms/datalist/datalist-child-validation-expected.txt:
  • fast/forms/datalist/datalist-child-validation.html: Added tests that check the validation status of removed node.
  • fast/forms/form-control-element-crash-expected.txt:
  • fast/forms/form-control-element-crash.html: Replaced with a better, easier to understand test case from the cluster-fuzz.
10:50 AM Changeset in webkit [115989] by Simon Fraser
  • 9 edits
    4 adds in trunk

Keep overlap testing for compositing on pages with 3d transforms when possible
https://bugs.webkit.org/show_bug.cgi?id=62487

Source/WebCore:

Reviewed by Antti Koivisto.

Change RenderLayerCompositor to always use overlap testing when possible.

Rather than turn off overlap testing wholesale when encountering a non-affine
transform, or starting an accelerated transform animation, we constrain
the disabling of overlap testing to within overflow:hidden areas when possible.

Tests: compositing/layer-creation/overlap-animation.html

compositing/layer-creation/overlap-transforms.html

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::setCompositedBounds): Whitespace fix.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::CompositingState::CompositingState):
(CompositingState): Add a member boolean to track whether we're testing overlap. Add a copy
constructor.
(WebCore::RenderLayerCompositor::updateCompositingLayers): Initialize the 'testing overlap'
setting based on m_compositingConsultsOverlap (though this will always be true until removed
in a future commit).
(WebCore::RenderLayerCompositor::updateBacking): No longer turn off overlap testing
when we see a non-affine transform.
(WebCore::RenderLayerCompositor::computeCompositingRequirements): No need for the 'struct'
in the arguments.
Consult compositingState.m_testingOverlap to see if we want to test overlap.
Use the new CompositingState copy ctor for childState, but set m_subtreeIsCompositing to false
as before.
If this layer is composited, look to see if need to disable over lap testing based on
the transform or an animation.
Just as we propagate m_subtreeIsCompositing, we have to propagate m_testingOverlap=false
for the rest of the traverse.
If we've just processed a layer which clips compositing descendants, we can go back
to testing for overlap.
(WebCore::RenderLayerCompositor::didStartAcceleratedAnimation): No need to do anything
here now. It will be removed in future.
(WebCore::RenderLayerCompositor::hasNonAffineTransform): No longer check
perspective here, since that doesn't affect whether _this_ layer should disable
overlap testing. Checking for a non-affine transform is sufficient.
(WebCore::RenderLayerCompositor::isRunningAcceleratedTransformAnimation):
New method to check if AnimationController is running a transform animation.

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

LayoutTests:

Reviewed by Antti Koivisto.

Two new tests that check for layer creation outside of an overflow:hidden
stacking context.

Updated results for other tests whose results are affected by the
'compositingConsultsOverlap' flag; their layers are now constrained to
the viewport.

  • compositing/geometry/ancestor-overflow-change-expected.txt:
  • compositing/geometry/foreground-layer-expected.txt:
  • compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • compositing/layer-creation/overlap-animation-expected.txt: Added.
  • compositing/layer-creation/overlap-animation.html: Added.
  • compositing/layer-creation/overlap-transforms-expected.txt: Added.
  • compositing/layer-creation/overlap-transforms.html: Added.
10:18 AM Changeset in webkit [115988] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WTF

Mutex failure when HashTable is memory moved in debug build
https://bugs.webkit.org/show_bug.cgi?id=84970

Patch by Yong Li <yoli@rim.com> on 2012-05-03
Reviewed by Rob Buis.

  1. Replace m_mutex with OwnPtr<m_mutex> so HashTable is still memory movable in debug build.
  2. Assert successes of pthread_mutex_init() and pthread_mutex_destroy().
  • wtf/HashTable.h:

(HashTable):
(WTF::::HashTable):
(WTF::::invalidateIterators):
(WTF::addIterator):
(WTF::removeIterator):

  • wtf/ThreadingPthreads.cpp:

(WTF::Mutex::Mutex):
(WTF::Mutex::~Mutex):

10:10 AM Changeset in webkit [115987] by commit-queue@webkit.org
  • 20 edits
    79 adds
    3 deletes in trunk/LayoutTests

[EFL] CSS tests needs gardening
https://bugs.webkit.org/show_bug.cgi?id=85499

Unreviewed gardening.

Moved CSS tests from Skipped to test_expectations.txt and made the
reference to the appropriated bug. Also updated missing/wrong
baselines.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-03

  • platform/efl/Skipped:
  • platform/efl/css1/basic/class_as_selector-expected.png:
  • platform/efl/css1/basic/comments-expected.png:
  • platform/efl/css1/basic/containment-expected.png:
  • platform/efl/css1/box_properties/acid_test-expected.png:
  • platform/efl/css1/box_properties/border-expected.png:
  • platform/efl/css1/cascade/cascade_order-expected.png:
  • platform/efl/css1/cascade/important-expected.png:
  • platform/efl/css1/classification/display-expected.png:
  • platform/efl/css1/classification/list_style-expected.png:
  • platform/efl/css1/color_and_background/background-expected.png:
  • platform/efl/css1/color_and_background/background_attachment-expected.png:
  • platform/efl/css1/conformance/forward_compatible_parsing-expected.png:
  • platform/efl/css2.1/20110323/abspos-containing-block-initial-001-expected.png: Added.
  • platform/efl/css2.1/20110323/abspos-containing-block-initial-001-expected.txt: Added.
  • platform/efl/css2.1/20110323/background-intrinsic-001-expected.png: Added.
  • platform/efl/css2.1/20110323/background-intrinsic-001-expected.txt: Added.
  • platform/efl/css2.1/20110323/background-intrinsic-002-expected.png: Added.
  • platform/efl/css2.1/20110323/background-intrinsic-002-expected.txt: Added.
  • platform/efl/css2.1/20110323/background-intrinsic-003-expected.png: Added.
  • platform/efl/css2.1/20110323/background-intrinsic-003-expected.txt: Added.
  • platform/efl/css2.1/20110323/background-intrinsic-004-expected.png: Added.
  • platform/efl/css2.1/20110323/background-intrinsic-004-expected.txt: Added.
  • platform/efl/css2.1/20110323/background-intrinsic-005-expected.png: Added.
  • platform/efl/css2.1/20110323/background-intrinsic-005-expected.txt: Added.
  • platform/efl/css2.1/20110323/background-intrinsic-006-expected.png: Added.
  • platform/efl/css2.1/20110323/background-intrinsic-006-expected.txt: Added.
  • platform/efl/css2.1/20110323/background-intrinsic-007-expected.png: Added.
  • platform/efl/css2.1/20110323/background-intrinsic-007-expected.txt: Added.
  • platform/efl/css2.1/20110323/background-intrinsic-008-expected.png: Added.
  • platform/efl/css2.1/20110323/background-intrinsic-008-expected.txt: Added.
  • platform/efl/css2.1/20110323/background-intrinsic-009-expected.png: Added.
  • platform/efl/css2.1/20110323/background-intrinsic-009-expected.txt: Added.
  • platform/efl/css2.1/20110323/border-collapse-offset-002-expected.png: Added.
  • platform/efl/css2.1/20110323/border-collapse-offset-002-expected.txt: Added.
  • platform/efl/css2.1/20110323/border-spacing-applies-to-015-expected.png: Added.
  • platform/efl/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Added.
  • platform/efl/css2.1/20110323/dynamic-top-change-001-expected.png: Added.
  • platform/efl/css2.1/20110323/dynamic-top-change-001-expected.txt: Added.
  • platform/efl/css2.1/20110323/dynamic-top-change-002-expected.png: Added.
  • platform/efl/css2.1/20110323/dynamic-top-change-002-expected.txt: Added.
  • platform/efl/css2.1/20110323/dynamic-top-change-003-expected.png: Added.
  • platform/efl/css2.1/20110323/dynamic-top-change-003-expected.txt: Added.
  • platform/efl/css2.1/20110323/dynamic-top-change-004-expected.png: Added.
  • platform/efl/css2.1/20110323/dynamic-top-change-004-expected.txt: Added.
  • platform/efl/css2.1/20110323/empty-inline-001-expected.png: Added.
  • platform/efl/css2.1/20110323/empty-inline-001-expected.txt: Added.
  • platform/efl/css2.1/20110323/empty-inline-002-expected.png: Added.
  • platform/efl/css2.1/20110323/empty-inline-002-expected.txt: Added.
  • platform/efl/css2.1/20110323/empty-inline-003-expected.png: Added.
  • platform/efl/css2.1/20110323/empty-inline-003-expected.txt: Added.
  • platform/efl/css2.1/20110323/outline-color-applies-to-008-expected.png: Added.
  • platform/efl/css2.1/20110323/outline-color-applies-to-008-expected.txt: Added.
  • platform/efl/css2.1/20110323/table-caption-001-expected.png: Added.
  • platform/efl/css2.1/20110323/table-caption-001-expected.txt: Added.
  • platform/efl/css2.1/20110323/table-caption-002-expected.png: Added.
  • platform/efl/css2.1/20110323/table-caption-002-expected.txt: Added.
  • platform/efl/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Added.
  • platform/efl/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Added.
  • platform/efl/css2.1/20110323/table-caption-margins-001-expected.png: Added.
  • platform/efl/css2.1/20110323/table-caption-margins-001-expected.txt: Added.
  • platform/efl/css2.1/20110323/table-caption-optional-001-expected.png: Added.
  • platform/efl/css2.1/20110323/table-caption-optional-001-expected.txt: Added.
  • platform/efl/css2.1/20110323/table-caption-optional-002-expected.png: Added.
  • platform/efl/css2.1/20110323/table-caption-optional-002-expected.txt: Added.
  • platform/efl/css3/images/cross-fade-background-size-expected.txt: Added.
  • platform/efl/css3/images/cross-fade-blending-expected.png: Added.
  • platform/efl/css3/images/cross-fade-blending-expected.txt: Added.
  • platform/efl/css3/images/cross-fade-invalidation-expected.png: Added.
  • platform/efl/css3/images/cross-fade-invalidation-expected.txt: Added.
  • platform/efl/css3/images/cross-fade-simple-expected.png: Added.
  • platform/efl/css3/images/cross-fade-simple-expected.txt: Added.
  • platform/efl/css3/images/cross-fade-sizing-expected.png: Added.
  • platform/efl/css3/images/cross-fade-sizing-expected.txt: Added.
  • platform/efl/css3/images/cross-fade-tiled-expected.png: Added.
  • platform/efl/css3/images/cross-fade-tiled-expected.txt: Added.
  • platform/efl/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png: Added.
  • platform/efl/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Added.
  • platform/efl/fast/css/child-style-can-override-visited-style-expected.png: Added.
  • platform/efl/fast/css/child-style-can-override-visited-style-expected.txt: Added.
  • platform/efl/fast/css/clip-text-in-scaled-div-expected.png: Added.
  • platform/efl/fast/css/clip-text-in-scaled-div-expected.txt: Added.
  • platform/efl/fast/css/color-correction-on-background-image-expected.txt: Added.
  • platform/efl/fast/css/color-correction-on-backgrounds-expected.txt: Added.
  • platform/efl/fast/css/color-correction-on-box-shadow-expected.txt: Added.
  • platform/efl/fast/css/color-correction-on-text-shadow-expected.txt: Added.
  • platform/efl/fast/css/color-correction-untagged-images-expected.txt: Added.
  • platform/efl/fast/css/invalidation-errors-2-expected.txt:
  • platform/efl/fast/css/invalidation-errors-expected.txt:
  • platform/efl/fast/css/shadow-multiple-expected.png:
  • platform/efl/fast/css/text-overflow-input-expected.png: Added.
  • platform/efl/fast/css/text-overflow-input-expected.txt: Added.
  • platform/efl/fast/css/text-rendering-expected.png: Removed.
  • platform/efl/fast/css/text-rendering-expected.txt: Added.
  • platform/efl/svg/css/composite-shadow-example-expected.txt: Removed.
  • platform/efl/svg/css/composite-shadow-with-opacity-expected.txt: Removed.
  • platform/efl/svg/css/group-with-shadow-expected.png: Added.
  • platform/efl/svg/css/stars-with-shadow-expected.png: Added.
  • platform/efl/test_expectations.txt:
  • platform/efl/transforms/svg-vs-css-expected.png:
  • platform/efl/transforms/svg-vs-css-expected.txt:
10:07 AM Changeset in webkit [115986] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

webkitpy: Style checker broken when committing a PNG
https://bugs.webkit.org/show_bug.cgi?id=85504

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-03
Reviewed by Dirk Pranke.

  • Scripts/webkitpy/style/checkers/png.py:

(PNGChecker.init):

10:07 AM Changeset in webkit [115985] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

accessibility/misspelled-attributed-string.html test sometimes throws exceptions
https://bugs.webkit.org/show_bug.cgi?id=85081

Reviewed by Darin Adler.

Add in more range checking in case we get back ranges from spell checking that are wrong.

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(AXAttributeStringSetFont):
(AXAttributeStringSetColor):
(AXAttributeStringSetNumber):
(AXAttributeStringSetBlockquoteLevel):
(AXAttributeStringSetHeadingLevel):
(AXAttributeStringSetElement):

9:48 AM Changeset in webkit [115984] by pfeldman@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: move canonical mime type calculation to Resource
https://bugs.webkit.org/show_bug.cgi?id=85507

Reviewed by Yury Semikhatsky.

Drive-by: small refactoring that prepares code for formatter extraction.

  • inspector/front-end/BreakpointsSidebarPane.js:
  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.prototype.createLiveLocation):
(WebInspector.DebuggerModel.prototype.rawLocationToUILocation):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModelResourceBinding.prototype._uiSourceCodeForResource):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkDispatcher.prototype._createNetworkRequest):
(get WebInspector):

  • inspector/front-end/Resource.js:

(WebInspector.Resource.prototype.requestContent):
(WebInspector.Resource.prototype.canonicalMimeType):
(WebInspector.Resource.prototype._innerRequestContent.callback):
(WebInspector.Resource.prototype._innerRequestContent):

  • inspector/front-end/ResourceView.js:

(WebInspector.ResourceSourceFrame.prototype.requestContent):
(WebInspector.ResourceSourceFrame.prototype._contentChanged):

9:46 AM Changeset in webkit [115983] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: 'expires' value is incorrect for cookies
https://bugs.webkit.org/show_bug.cgi?id=85489

Reviewed by Pavel Feldman.

Fixed cookie 'expires' property type from integer to number so that
we don't lose precision when assembling Cookie parameter in InspectorResourceAgent.

  • inspector/Inspector.json:
9:42 AM Changeset in webkit [115982] by zmo@google.com
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed, rebaseline

  • platform/chromium-linux-x86/fast/js/dfg-double-vote-fuzz-expected.txt: Added.
9:32 AM Changeset in webkit [115981] by mitz@apple.com
  • 21 edits
    2 adds in trunk

highlight for Ruby text is mispositioned in the Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=82684

Reviewed by Simon Fraser.

Source/WebCore:

Tests: fast/writing-mode/flipped-blocks-inline-map-local-to-container-expected.html

fast/writing-mode/flipped-blocks-inline-map-local-to-container.html

In flipped blocks writing modes, flipping was being applied twice to box descendants of
inline children of the flipped block, once during RenderBox::mapLocalToContainer, and then
again by RenderInline::mapLocalToContainer. The fix is to make the latter only apply the
flip to local coordinates originating in the inline or a descendant inline. This is done
by adding a parameter of type ApplyContainerFlipOrNot, which defaults to ApplyContainerFlip
but is reset to DoNotApplyContainerFlip in recursive calls into mapLocalToContainer().

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::mapLocalToContainer): Added ApplyContainerFlipOrNot parameter, passing
DoNotApplyContainerFlip when recursing into the container.

  • rendering/RenderBox.h:
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::mapLocalToContainer): Added ApplyContainerFlipOrNot paramerer, and
made the flipping conditional on its value.

  • rendering/RenderInline.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::mapLocalToContainer): Added ApplyContainerFlipOrNot parameter,
passing DoNotApplyContainerFlip when recursing into the container.
(WebCore::RenderObject::localToContainerQuad): Pass ApplyContainerFlip.
(WebCore::RenderObject::localToContainerPoint): Ditto.

  • rendering/RenderObject.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::mapLocalToContainer): Added ApplyContainerFlipOrNot parameter.

  • rendering/RenderView.h:
  • rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::mapLocalToContainer): Ditto.

  • rendering/svg/RenderSVGForeignObject.h:
  • rendering/svg/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::mapLocalToContainer): Ditto.

  • rendering/svg/RenderSVGInline.h:
  • rendering/svg/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::mapLocalToContainer): Ditto.

  • rendering/svg/RenderSVGModelObject.h:
  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::mapLocalToContainer): Ditto.

  • rendering/svg/RenderSVGRoot.h:
  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::mapLocalToContainer): Ditto.

  • rendering/svg/RenderSVGText.h:
  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::mapLocalToContainer): Pass DoNotApplyContainerFlip when
recursing into the parent.

LayoutTests:

  • fast/writing-mode/flipped-blocks-inline-map-local-to-container-expected.html: Added.
  • fast/writing-mode/flipped-blocks-inline-map-local-to-container.html: Added.
9:29 AM Changeset in webkit [115980] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, adjusted platform specifiers for fast/js/dfg-double-vote-fuzz.html

  • platform/chromium/test_expectations.txt:
9:25 AM Changeset in webkit [115979] by pfeldman@chromium.org
  • 10 edits in trunk

Web Inspector: make Script a ContentProvider.
https://bugs.webkit.org/show_bug.cgi?id=85486

Reviewed by Yury Semikhatsky.

This allows us to get rid of the corresponding content provider wrapper.

  • inspector/front-end/ContentProviders.js:
  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode.prototype._createContentProvider):

  • inspector/front-end/Script.js:

(WebInspector.Script.prototype.contentURL):
(WebInspector.Script.prototype.requestContent.didGetScriptSource):
(WebInspector.Script.prototype.requestContent):

  • inspector/front-end/SnippetsModel.js:

(WebInspector.SnippetsScriptMapping.prototype._createUISourceCodeForScript):

9:24 AM Changeset in webkit [115978] by Philippe Normand
  • 2 edits in trunk/Tools

Unreviewed, fix another call to join(), similar to the ones landed
in r115975.

  • Scripts/webkitdirs.pm:

(jhbuildConfigurationChanged):

9:23 AM Changeset in webkit [115977] by rakuco@webkit.org
  • 6 edits in trunk/Tools

webkitpy: Remove sys.platform accesses in CrashLogs.
https://bugs.webkit.org/show_bug.cgi?id=85436

Reviewed by Dirk Pranke.

Instead of directly checking for sys.platform == 'darwin', use a
SystemHost and call PlatformInfo.is_mac().

  • Scripts/webkitpy/common/system/crashlogs.py:

(CrashLogs.init):
(CrashLogs.find_newest_log):
(CrashLogs._log_directory_darwin):
(CrashLogs._find_newest_log_darwin):

  • Scripts/webkitpy/common/system/crashlogs_unittest.py:

(CrashLogsTest.test_find_log_darwin):

  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort._get_crash_log):

  • Scripts/webkitpy/layout_tests/port/test.py:

(TestDriver.run_test):

  • Scripts/webkitpy/tool/commands/queries.py:

(execute):

9:19 AM Changeset in webkit [115976] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Narrowed down platform specifiers for some tests, removed some entries.

  • platform/chromium/test_expectations.txt:
8:55 AM Changeset in webkit [115975] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] join() is wrongly used in webkitdirs.pm since r115532
https://bugs.webkit.org/show_bug.cgi?id=85501

Patch by Philippe Normand <pnormand@igalia.com> on 2012-05-03
Reviewed by Martin Robinson.

  • Scripts/webkitdirs.pm:

(getJhbuildPath):
(buildAutotoolsProject):

8:40 AM Changeset in webkit [115974] by mifenton@rim.com
  • 4 edits in trunk

.: Rename attribute.

[BlackBerry] Add special attribute for alternate selection touch handling.
https://bugs.webkit.org/show_bug.cgi?id=85284

Reviewed by Rob Buis.

  • ManualTests/blackberry/selection-touch-override.html:

Source/WebKit/blackberry: [BlackBerry] Add special attribute for alternate selection touch handling.
https://bugs.webkit.org/show_bug.cgi?id=85284

Reviewed by Rob Buis.

Rename the custom attribute and make it a data- attribute.

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::inputNodeOverridesTouch):

8:15 AM Changeset in webkit [115973] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Also update Qt::ImEnabled flag when updating the input method.
https://bugs.webkit.org/show_bug.cgi?id=85495

Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-05-03
Reviewed by Simon Hausmann.

QInputMethod only issues a new inputMethodQuery if the Qt::ImEnabled
flag got updated as well.

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(WebKit::QtWebPageEventHandler::updateTextInputState):
(WebKit::QtWebPageEventHandler::doneWithGestureEvent):

8:11 AM Changeset in webkit [115972] by caio.oliveira@openbossa.org
  • 4 edits
    2 adds in trunk

Remove extra checks for empty string when parsing CSS value
https://bugs.webkit.org/show_bug.cgi?id=85480

Reviewed by Alexis Menard.

Source/WebCore:

Each parse value helper function was checking whether the value string was empty. For the
common case this check is already done by StylePropertySet::setProperty(). So this patch
make CSSParser::parseValue() assume the value string is not empty, and fix the other two
clients.

Test: fast/html/font-face-empty-should-not-crash.html

  • css/CSSParser.cpp:

(WebCore::parseColorValue): Replace the string empty check by an ASSERT() to document
function's expectations.
(WebCore::parseSimpleLengthValue): Ditto.
(WebCore::parseKeywordValue): Ditto.
(WebCore::CSSParser::parseFontFaceValue): This will be covered by the added test.
(WebCore::CSSParser::parseValue):

  • css/WebKitCSSMatrix.cpp:

(WebCore::WebKitCSSMatrix::setMatrixValue): This is already covered by
transforms/cssmatrix-2d-interface.xhtml.

LayoutTests:

  • fast/html/font-face-empty-should-not-crash-expected.txt: Added.
  • fast/html/font-face-empty-should-not-crash.html: Added.
7:45 AM Changeset in webkit [115971] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

Broken handling of pseudo-elements in selectors API
https://bugs.webkit.org/show_bug.cgi?id=83446

Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-05-03
Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/dom/Window/querySelectorAll-with-pseudo-elements.html

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::SelectorChecker):
Setting the default value for the enum member m_mode to ResolvingStyle.

(WebCore::SelectorChecker::checkSelector):
Instead of verifying against the bool m_isCollectingRulesOnly, we now check whether or not
m_mode is set to ResolvingStyle.

(WebCore::SelectorChecker::checkOneSelector):
Instead of verifying against the bool m_isCollectingRulesOnly, we now check whether or not
m_mode is set to ResolvingStyle. Also, for the pseudo-elements case we check if its
value is set to QueryingRules in which case we return false.

  • css/SelectorChecker.h:

(WebCore::SelectorChecker::mode):
Returns the mode (m_mode) value.

(WebCore::SelectorChecker::setMode):
Sets the mode (m_mode) to the passed enum value.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::sortAndTransferMatchedRules):
(WebCore::StyleResolver::collectMatchingRulesForList):
Retrieves SelectorChecker's mode value.

  • dom/SelectorQuery.cpp:

(WebCore::SelectorQuery::SelectorQuery):
Sets SelectorChecker's mode to QueryingRules.

  • html/shadow/ContentSelectorQuery.cpp:

(WebCore::ContentSelectorQuery::ContentSelectorQuery):
Sets SelectorChecker's mode to CollectingRules.

LayoutTests:

  • fast/dom/Window/querySelectorAll-with-pseudo-elements-expected.txt: Added.
  • fast/dom/Window/querySelectorAll-with-pseudo-elements.html: Added.

New layout testcase added for verifying that the querySelectorAll() API returns zero
when querying for pseudo-elements selectors; as per the specification.

7:05 AM Changeset in webkit [115970] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Tap-highlight blinks when activated.
https://bugs.webkit.org/show_bug.cgi?id=85481

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-03
Reviewed by Kenneth Rohde Christiansen.

Set the opacity on the page-overlay the first time it is requested to be drawn. Otherwiser
it will start fully opaque before fading in.

  • WebProcess/WebPage/PageOverlay.cpp:

(WebKit::PageOverlay::setNeedsDisplay):

6:35 AM Changeset in webkit [115969] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: EXC_BAD_ACCESS in DOM breakpoint processing code.
https://bugs.webkit.org/show_bug.cgi?id=85482

Reviewed by Yury Semikhatsky.

0 check added since we are guaranteed to get immediate parent, but not the whole ancestor tree.

  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::descriptionForDOMEvent):

6:24 AM Changeset in webkit [115968] by commit-queue@webkit.org
  • 21 edits in trunk/LayoutTests

[EFL] [DRT] Update EFL baselines after r115846
https://bugs.webkit.org/show_bug.cgi?id=85474

Unreviewed, EFL rebaseline after changes in r115846.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-03

  • platform/efl/fast/block/float/032-expected.txt:
  • platform/efl/fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt:
  • platform/efl/fast/block/float/shrink-to-avoid-float-complexity-expected.txt:
  • platform/efl/fast/block/lineboxcontain/parsing-invalid-expected.txt:
  • platform/efl/fast/block/margin-collapse/103-expected.txt:
  • platform/efl/fast/clip/008-expected.txt:
  • platform/efl/fast/clip/011-expected.txt:
  • platform/efl/fast/clip/012-expected.txt:
  • platform/efl/fast/html/details-no-summary4-expected.txt:
  • platform/efl/fast/html/details-open-javascript-expected.txt:
  • platform/efl/fast/html/details-open2-expected.txt:
  • platform/efl/fast/html/details-open4-expected.txt:
  • platform/efl/fast/replaced/replaced-breaking-expected.txt:
  • platform/efl/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/efl/fast/table/003-expected.txt:
  • platform/efl/fast/table/overflowHidden-expected.txt:
  • platform/efl/fast/table/text-field-baseline-expected.txt:
  • platform/efl/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/efl/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/efl/http/tests/navigation/javascriptlink-frames-expected.txt:
6:16 AM Changeset in webkit [115967] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

[Gtk] ImageDiff crashes when it can't open a display
https://bugs.webkit.org/show_bug.cgi?id=85476

Reviewed by Martin Robinson.

Replace gdk_init() initialization call with the g_type_init()
call. GdkPixbufLoader doesn't actually need the current call to be
made and this change will also remove crashes when ImageDiff
is started in an environment without a DISPLAY env.

  • DumpRenderTree/gtk/ImageDiff.cpp:

(main):

5:40 AM Changeset in webkit [115966] by mihnea@adobe.com
  • 4 edits in trunk/LayoutTests

[CSSRegions]Correct fast/regions/region-style-inline-background-color.html
https://bugs.webkit.org/show_bug.cgi?id=85470

Reviewed by Andreas Kling.

Fix a typo in the original test and update the expectations.
The purpose of this test is to verify that region styling is NOT enabled for inline elements. The test was passing
because region styling rule was not applied due to incorrect region selector.

The corrected test makes sure that region styling rule has the right region selector and can be applied to the first region in the test file.

  • fast/regions/region-style-inline-background-color.html:
  • platform/chromium-win/fast/regions/region-style-inline-background-color-expected.txt:
  • platform/mac/fast/regions/region-style-inline-background-color-expected.txt:
5:39 AM Changeset in webkit [115965] by loislo@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: compile time ambiguity happens when I try to assign a TypeBuilder object to an out argument.
https://bugs.webkit.org/show_bug.cgi?id=85462

It happens because we have type casting operators for both types RefPtr<*Type*> and PassRefPtr<*Type*>.
I think we can drop PassRefPtr type casting operator and use a named function 'release'.

Reviewed by Yury Semikhatsky.

  • inspector/CodeGeneratorInspector.py:
  • inspector/ContentSearchUtils.cpp:

(WebCore::ContentSearchUtils::buildObjectForSearchMatch):

  • inspector/InspectorApplicationCacheAgent.cpp:

(WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCache):

  • inspector/InspectorPageAgent.cpp:

(WebCore::buildObjectForCookie):
(WebCore::buildObjectForSearchResult):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::buildObjectForTiming):
(WebCore::InspectorResourceAgent::buildInitiatorObject):

  • inspector/ScriptCallFrame.cpp:

(WebCore::ScriptCallFrame::buildInspectorObject):

5:35 AM Changeset in webkit [115964] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: crash in InspectorResourceAgent::didReceiveWebSocketFrame
https://bugs.webkit.org/show_bug.cgi?id=85394

Reviewed by Pavel Feldman.

Pass string length explicitely when creating String object from non-null-terminated
char* strings.

  • inspector/InspectorResourceAgent.cpp:

(WebCore):
(WebCore::InspectorResourceAgent::didReceiveWebSocketFrame):
(WebCore::InspectorResourceAgent::didSendWebSocketFrame):

5:26 AM Changeset in webkit [115963] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Not reviewed: never surround InspectorInstrumentation:: with ENABLED(INSPECTOR)

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::appendChild):
(WebCore::dispatchChildRemovalEvents):

5:13 AM Changeset in webkit [115962] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

ImageDiff should be run inside a properly established environment
https://bugs.webkit.org/show_bug.cgi?id=85292

Reviewed by Martin Robinson.

When creating the ImageDiff server process, pass along a freshly-set-up environment
in which the process should be executed in.

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._start_image_diff_process):

5:08 AM Changeset in webkit [115961] by pfeldman@chromium.org
  • 22 edits
    1 delete in trunk

Web Inspector: migrate breakpoint manager to live locations.
https://bugs.webkit.org/show_bug.cgi?id=85136

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • Merges Breakpoint and UIBreakpoint to have single instance
  • Extracts storage from the breakpoint manager
  • Makes breakpoint manager use source mapping from the script, not the presentation model
  • Removes breakpoints collection from the UISourceCode

Unfortunately, there are too many inter-dependencies that require that these changes are done simultaneously.

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager):
(WebInspector.BreakpointManager.prototype.setBreakpoint):
(WebInspector.BreakpointManager.prototype.breakpoint):
(WebInspector.BreakpointManager.prototype.breakpointLocationsForUISourceCode):
(WebInspector.BreakpointManager.prototype.removeAllBreakpoints):
(WebInspector.BreakpointManager.prototype.reset):
(WebInspector.BreakpointManager.prototype.debuggerReset):
(WebInspector.BreakpointManager.prototype._breakpointResolved):
(WebInspector.BreakpointManager.prototype._removeBreakpoint):
(WebInspector.BreakpointManager.prototype._uiLocationAdded):
(WebInspector.BreakpointManager.prototype._uiLocationRemoved):
(WebInspector.BreakpointManager.prototype.storage):
(WebInspector.BreakpointManager.Breakpoint):
(WebInspector.BreakpointManager.Breakpoint.prototype.primaryUILocation):
(WebInspector.BreakpointManager.Breakpoint.prototype._addResolvedLocation):
(WebInspector.BreakpointManager.Breakpoint.prototype.enabled):
(WebInspector.BreakpointManager.Breakpoint.prototype.setEnabled):
(WebInspector.BreakpointManager.Breakpoint.prototype.condition):
(WebInspector.BreakpointManager.Breakpoint.prototype.setCondition):
(WebInspector.BreakpointManager.Breakpoint.prototype._updateBreakpoint):
(WebInspector.BreakpointManager.Breakpoint.prototype.remove):
(WebInspector.BreakpointManager.Breakpoint.prototype._setInDebugger.didSetBreakpoint):
(WebInspector.BreakpointManager.Breakpoint.prototype._setInDebugger):
(WebInspector.BreakpointManager.Breakpoint.prototype._removeFromDebugger):
(WebInspector.BreakpointManager.Breakpoint.prototype._resetLocations):
(WebInspector.BreakpointManager.Breakpoint.prototype._breakpointStorageId):
(WebInspector.BreakpointManager.Breakpoint.prototype._fakeBreakpointAtPrimaryLocation):
(WebInspector.BreakpointManager.Storage.get this):
(WebInspector.BreakpointManager.Storage):
(WebInspector.BreakpointManager.Storage.prototype.restoreBreakpoints):
(WebInspector.BreakpointManager.Storage.prototype._updateBreakpoint):
(WebInspector.BreakpointManager.Storage.prototype._removeBreakpoint):
(WebInspector.BreakpointManager.Storage.prototype._save):
(set WebInspector.BreakpointManager.Storage.Item):

  • inspector/front-end/BreakpointsSidebarPane.js:

(WebInspector.JavaScriptBreakpointsSidebarPane):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointAdded.didRequestContent):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointAdded):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointRemoved):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.highlightBreakpoint):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._createBreakpointItemId):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointClicked):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointCheckboxClicked):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointContextMenu):

  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel):
(WebInspector.DebuggerModel.prototype.breakpointsActive):
(WebInspector.DebuggerModel.prototype.createLiveLocation):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype._handleUISourceCodeListChanged):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype._setContentWithInitialContent):

  • inspector/front-end/JavaScriptSource.js:

(WebInspector.JavaScriptSource):
(WebInspector.JavaScriptSource.prototype.consoleMessagesCleared):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.canEditSource):
(WebInspector.JavaScriptSourceFrame.prototype.editContent):
(WebInspector.JavaScriptSourceFrame.prototype._onContentChanged):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu):
(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype.didEditContent):
(WebInspector.JavaScriptSourceFrame.prototype._addBreakpointDecoration):
(WebInspector.JavaScriptSourceFrame.prototype._onMouseDown):
(WebInspector.JavaScriptSourceFrame.prototype._editBreakpointCondition.finishEditing):
(WebInspector.JavaScriptSourceFrame.prototype._editBreakpointCondition):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointAdded):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointRemoved):
(WebInspector.JavaScriptSourceFrame.prototype.onTextViewerContentLoaded):
(WebInspector.JavaScriptSourceFrame.prototype._setBreakpoint):
(WebInspector.JavaScriptSourceFrame.prototype._continueToLine):
(WebInspector.JavaScriptSourceFrame.prototype._updateBreakpointsAfterLiveEdit):

  • inspector/front-end/Script.js:

(WebInspector.Script.prototype.rawLocationToUILocation):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeRemoved):
(WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetUILocation):
(WebInspector.ScriptsPanel.prototype._debuggerPaused):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.contentChanged):

LayoutTests:

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • inspector/debugger/breakpoint-manager-expected.txt:
  • inspector/debugger/breakpoint-manager.html:
  • inspector/debugger/debugger-breakpoints-not-activated-on-reload.html:
  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/source-frame-expected.txt:
  • inspector/debugger/source-frame.html:
  • platform/chromium/inspector/debugger/breakpoint-manager-expected.txt: Removed.
5:07 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
Sort tasks by target version and status (diff)
5:00 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
Update Roadmap after 1.9.1 release (diff)
4:36 AM Changeset in webkit [115960] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed attemp to fix chromium win build broken at r115943.

  • notifications/NotificationClient.h:

(WebCore):

4:16 AM Changeset in webkit [115959] by kenneth@webkit.org
  • 2 edits in trunk/Source/WebKit2

Document the QML WebViewExperimental API devicePixelRatio.

Rubberstamped by Simon Hausmann.

  • UIProcess/API/qt/qquickwebview.cpp:
4:14 AM Changeset in webkit [115958] by vestbo@webkit.org
  • 6 edits in trunk

[Qt] Allow the web process and WTR to be paused on startup

Makes it easier to debug the web process or run-webkit-tests -2, as you
have ample time to attach gdb to the process.

Reviewed by Simon Hausmann.

4:01 AM Changeset in webkit [115957] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Password protect "Stop build" button
https://bugs.webkit.org/show_bug.cgi?id=81982

Reviewed by Ryosuke Niwa.

Only authenticated users should be able to use stopBuild, stopAllBuilds, cancelPendingBuild
features to prevent killing builds on build.webkit.org by SPAM bots.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
3:38 AM Changeset in webkit [115956] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Linker warnings due to duplicate symbols for SimplifyMarkupCommand.cpp on Windows
https://bugs.webkit.org/show_bug.cgi?id=85467

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-05-03
Reviewed by Ryosuke Niwa.

Removed the multiple inclusion of the file SimplifyMarkupCommand.cpp

No new tests required.

  • WebCore.vcproj/WebCore.vcproj:
3:37 AM Changeset in webkit [115955] by ahf@0x90.dk
  • 2 edits in trunk/Source/WebKit2

Rename deviceDPI to devicePixelRatio https://bugs.webkit.org/show_bug.cgi?id=85049

Reviewed by Kenneth Rohde Christiansen.

This patch fixes an API test regression from r115948 in
tst_QQuickWebView::scrollRequest() by setting the device pixel ratio
for the test WebView to 1.5.

  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::newWebView):

3:30 AM Changeset in webkit [115954] by commit-queue@webkit.org
  • 6 edits in trunk/Tools

[DRT] Remove the name of parameter, visibility, from the setPageVisibility stub implementations.
https://bugs.webkit.org/show_bug.cgi?id=85468

Patch by Dongwoo Im <dw.im@samsung.com> on 2012-05-03
Reviewed by Nikolas Zimmermann.

  • DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:

(LayoutTestController::setPageVisibility): Remove the name of parameter, visibility.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::setPageVisibility): Remove the name of parameter, visibility.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::setPageVisibility): Remove the name of parameter, visibility.

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::setPageVisibility): Remove the name of parameter, visibility.

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::setPageVisibility): Remove the name of parameter, visibility.

3:02 AM Changeset in webkit [115953] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

CSS clip: auto clips to box borders instead of removing clipping
https://bugs.webkit.org/show_bug.cgi?id=36772

Patch by Uday Kiran <udaykiran@motorola.com> on 2012-05-03
Reviewed by Andreas Kling.

Source/WebCore:

According to CSS 2.1 spec, http://www.w3.org/TR/CSS2/visufx.html#propdef-clip,
clip property with value 'auto' the element does not clip.
Also getPropertyValue for clip when auto is specified should return "auto"
and not "rect(0px 0px 0px 0px)".

Tests: css2.1/20110323/clip-001-expected.html

css2.1/20110323/clip-001.html

  • css/StyleBuilder.cpp:

(WebCore::ApplyPropertyClip::applyValue):

LayoutTests:

CSS 2.1 test case added for clip:auto

  • css2.1/20110323/clip-001-expected.html: Added.
  • css2.1/20110323/clip-001.html: Added.
  • fast/css/getPropertyValue-clip.html: getPropertyValue for clip when auto is specified should return auto and not rect(0px 0px 0px 0px).
2:51 AM Changeset in webkit [115952] by Stephanie Lewis
  • 8 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=85450 unbounded growth of JSDOMWindowShells loading pages in the same window
<rdar://problem/11320059> REGRESSION (r115083): PLT3 shows linear memory growth and gets slower with each run

Reviewed by Brady Eidson.

The API added for DOMWindowExtension, didCreateGlobalObjectForFrame, would create a global object
for every world, even those that did not need the callback. This had the side effect of creating a
JSDOMWindowShell that the associated world didn't necessarily know to clean up. Instead of creating
unnecessary objects change the API to globalObjectIsAvailableForFrame and do not pass the global object
in the API. The object can be accessed later by those worlds which require it.

Source/WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::globalObjectIsAvailableForFrame): rename API and remove globalObject parameter

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:

(InjectedBundlePageLoaderClient): ditto

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchGlobalObjectAvailable): ditto

Tools:

  • TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:

(TestWebKitAPI):
(TestWebKitAPI::didReceiveMessageFromInjectedBundle):

  • TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:

(TestWebKitAPI):
(DOMWindowExtensionBasic):
(TestWebKitAPI::DOMWindowExtensionBasic::didCreatePage):
(TestWebKitAPI::DOMWindowExtensionBasic::globalObjectIsAvailableForFrame):
(TestWebKitAPI::globalObjectIsAvailableForFrameCallback):

2:49 AM Changeset in webkit [115951] by Antti Koivisto
  • 4 edits in trunk/Source

Add temporary feature define for parsed stylesheet caching
https://bugs.webkit.org/show_bug.cgi?id=85413

Rubber-stamped by Nikolas Zimmermann.

While not an externally visible feature this is still a significant internal change.
It is good to have define in case someone has an urgent need to turn it off.

Caching is enabled by default on all platforms. The define should be removed after some bake time.

Source/WebCore:

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::setCSSStyleSheet):

Source/WTF:

  • wtf/Platform.h:
2:09 AM Changeset in webkit [115950] by Nikolas Zimmermann
  • 26 edits in trunk/Source/WebCore

Accumulation for values-animation is broken
https://bugs.webkit.org/show_bug.cgi?id=85158

Reviewed by Zoltan Herczeg.

Follow-up patch: Add const Foo& foo() const accessors to SVGAnimatedType,
to avoid the "Foo& foo = animated->foo()" idiom in all cases where we
don't need to mutate 'foo'. Use "const Foo& foo = animated->foo()" instead.
Inline all of these methods to avoid the function call overhead.

For to-animations we actually mutated the from value before, but it wasn't a
problem in practive, as we did that on every animation step. Fully avoid these
inconsitencies by never mutating the from/to types stored in SVGAnimateElement.

Cache toAtEndOfDurationType just like m_toType/m_fromType in SVGAnimateElement,
to avoid reconstructing it on every animation step.

No new tests, only design/performance fixes.

  • svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::calculateAnimatedValue):
(WebCore::SVGAnimateElement::calculateToAtEndOfDurationValue):
(WebCore::SVGAnimateElement::targetElementWillChange):

  • svg/SVGAnimateElement.h:

(SVGAnimateElement):

  • svg/SVGAnimateMotionElement.cpp:

(WebCore::SVGAnimateMotionElement::SVGAnimateMotionElement):
(WebCore::SVGAnimateMotionElement::calculateToAtEndOfDurationValue):
(WebCore::SVGAnimateMotionElement::calculateFromAndToValues):
(WebCore::SVGAnimateMotionElement::calculateFromAndByValues):
(WebCore::SVGAnimateMotionElement::calculateAnimatedValue):

  • svg/SVGAnimateMotionElement.h:

(SVGAnimateMotionElement):

  • svg/SVGAnimatedAngle.cpp:

(WebCore::SVGAnimatedAngleAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedAngleAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedBoolean.cpp:

(WebCore::SVGAnimatedBooleanAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedColor.cpp:

(WebCore::SVGAnimatedColorAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedEnumeration.cpp:

(WebCore::SVGAnimatedEnumerationAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedInteger.cpp:

(WebCore::SVGAnimatedIntegerAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedIntegerOptionalInteger.cpp:

(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedLength.cpp:

(WebCore::SVGAnimatedLengthAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedLengthList.cpp:

(WebCore::SVGAnimatedLengthListAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedNumber.cpp:

(WebCore::SVGAnimatedNumberAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedNumberList.cpp:

(WebCore::SVGAnimatedNumberListAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedNumberListAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedNumberOptionalNumber.cpp:

(WebCore::SVGAnimatedNumberOptionalNumberAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedPath.cpp:

(WebCore::SVGAnimatedPathAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedPointList.cpp:

(WebCore::SVGAnimatedPointListAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedPointListAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedPreserveAspectRatio.cpp:

(WebCore::SVGAnimatedPreserveAspectRatioAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedRect.cpp:

(WebCore::SVGAnimatedRectAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedString.cpp:

(WebCore::SVGAnimatedStringAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedTransformList.cpp:

(WebCore::SVGAnimatedTransformListAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedTransformListAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedType.cpp:
  • svg/SVGAnimatedType.h:

(WebCore::SVGAnimatedType::angleAndEnumeration):
(SVGAnimatedType):
(WebCore::SVGAnimatedType::boolean):
(WebCore::SVGAnimatedType::color):
(WebCore::SVGAnimatedType::enumeration):
(WebCore::SVGAnimatedType::integer):
(WebCore::SVGAnimatedType::integerOptionalInteger):
(WebCore::SVGAnimatedType::length):
(WebCore::SVGAnimatedType::lengthList):
(WebCore::SVGAnimatedType::number):
(WebCore::SVGAnimatedType::numberList):
(WebCore::SVGAnimatedType::numberOptionalNumber):
(WebCore::SVGAnimatedType::path):
(WebCore::SVGAnimatedType::pointList):
(WebCore::SVGAnimatedType::preserveAspectRatio):
(WebCore::SVGAnimatedType::rect):
(WebCore::SVGAnimatedType::string):
(WebCore::SVGAnimatedType::transformList):

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::currentValuesForValuesAnimation):
(WebCore::SVGAnimationElement::startedActiveInterval):
(WebCore::SVGAnimationElement::updateAnimation):

  • svg/SVGAnimationElement.h:

(WebCore::SVGAnimationElement::adjustFromToListValues):
(WebCore::SVGAnimationElement::animateDiscreteType):
(SVGAnimationElement):

2:02 AM Changeset in webkit [115949] by Nikolas Zimmermann
  • 2 edits in trunk/Tools

2012-05-03 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix mac build, it was missing setPageVisibility/resetPageVisibility stub implementations.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::resetPageVisibility): (LayoutTestController::setPageVisibility):
1:54 AM Changeset in webkit [115948] by ahf@0x90.dk
  • 10 edits in trunk

Rename deviceDPI to devicePixelRatio https://bugs.webkit.org/show_bug.cgi?id=85049

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

No new tests added since this is a minor refactoring with no changes
that should affect tests.

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setDevicePixelRatio):
(WebCore::Settings::devicePixelRatio):
(Settings):

Source/WebKit2:

Add experimental QML API to set and get the device pixel ratio.

  • Shared/WebPreferencesStore.h:

(WebKit):

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewFlickablePrivate::updateViewportSize):
(QQuickWebViewExperimental::devicePixelRatio):
(QQuickWebViewExperimental::setDevicePixelRatio):

  • UIProcess/API/qt/qquickwebview_p.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::sendViewportAttributesChanged):
(WebKit::WebPage::updatePreferences):

Tools:

Use 1.5 as device pixel ratio for the Qt MiniBrowser.

  • MiniBrowser/qt/qml/BrowserWindow.qml:
1:45 AM Changeset in webkit [115947] by Nikolas Zimmermann
  • 6 edits
    8 adds in trunk

Fix multiple begin values support - especially with seeking through setCurrentTime
https://bugs.webkit.org/show_bug.cgi?id=85372

Reviewed by Zoltan Herczeg.

Source/WebCore:

Multiple begin values aka. begin="0s; 2s" aren't correctly handled - resulting in broken & unexpected behavior.
Supporting seeking properly on documents containing such animations is very important, otherwise we can't reliable
test animations using either reftests or the SVG JS animation test framework.

Testcase:
<rect height="100" fill="green">

<animate attributeName="width" begin="0s; 2s" dur="8s" from="0" to="100" fill="freeze"/>

</rect>

What's expected?
Two times should be contained in the 'begin' times list in SVGSMILElement: m_beginTimes = { 0s, 2s }.
The initial first resolved interval is: m_intervalBegin=0.0s, m_intervalEnd=8.0s.

During t=0s..1.9999s the m_intervalBegin/m_intervalEnd are correct.
At t=2s, a new interval can be started. m_intervalEnd should be set to nextBeginTime, where nextBeginTime=2s.
The current interval should get cropped to: m_intervalBegin=0s, m_intervalEnd=2s. The following call to
resolveNextInterval() sees that elapsed >= m_intervalEnd, and thus moves on to the next interval.
m_intervalBegin should be 2s and m_intervalEnd=10s after that.

In trunk this behavior is only partly implemented and broken. Especially broken together with seeking via SVGSVGElement.setCurrentTime.
That's because we don't correctly seek to the right interval in case of multiple begin values, eg. if we sample an animation with
begin="0s; 3s" dur="6s" we always remain in the first interval and don't move on.

Fix all of these issues, making lots more tests work in Dr. Olaf Hofmanns SVG Animation test suite.

Tests: svg/animations/multiple-begin-additive-animation.html

svg/animations/multiple-begin-animation-discrete-expected.svg
svg/animations/multiple-begin-animation-discrete.svg
svg/animations/multiple-begin-animation-expected.svg
svg/animations/multiple-begin-animation.svg

  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::begin):
(WebCore::SMILTimeContainer::setElapsed):
(WebCore::SMILTimeContainer::updateAnimations):

  • svg/animation/SMILTimeContainer.h:

(SMILTimeContainer):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::findInstanceTime):
(WebCore::SVGSMILElement::resolveInterval):
(WebCore::SVGSMILElement::resolveNextInterval):
(WebCore):
(WebCore::SVGSMILElement::checkRestart):
(WebCore::SVGSMILElement::seekToIntervalCorrespondingToTime):
(WebCore::SVGSMILElement::progress):

  • svg/animation/SVGSMILElement.h:

(SVGSMILElement):

LayoutTests:

  • svg/animations/multiple-begin-additive-animation-expected.txt: Added.
  • svg/animations/multiple-begin-additive-animation.html: Added.
  • svg/animations/multiple-begin-animation-discrete-expected.svg: Added.
  • svg/animations/multiple-begin-animation-discrete.svg: Added.
  • svg/animations/multiple-begin-animation-expected.svg: Added.
  • svg/animations/multiple-begin-animation.svg: Added.
  • svg/animations/resources/multiple-begin-additive-animation.svg: Added.
  • svg/animations/script-tests/multiple-begin-additive-animation.js: Added.

(checkBaseValues):
(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(sample6):
(sample7):
(sample8):
(sample9):
(sample10):
(sample11):
(sample12):
(sample13):
(executeTest):

1:22 AM Changeset in webkit [115946] by commit-queue@webkit.org
  • 11 edits in trunk

[EFL][DRT] Implement the LayoutTestController's methods related to the Page Visibility API.
https://bugs.webkit.org/show_bug.cgi?id=85347

Patch by Dongwoo Im <dw.im@samsung.com> on 2012-05-03
Reviewed by Nikolas Zimmermann.

Tools:

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:

(LayoutTestController::resetPageVisibility): Not implemented.
(LayoutTestController::setPageVisibility): Not implemented.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::resetPageVisibility): Reset the page visibility.
(LayoutTestController::setPageVisibility): Set the page visibility.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::resetPageVisibility): Not implemented.
(LayoutTestController::setPageVisibility): Not implemented.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::resetPageVisibility): Not implemented.
(LayoutTestController::setPageVisibility): Not implemented.

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::resetPageVisibility): Not implemented.
(LayoutTestController::setPageVisibility): Not implemented.

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::resetPageVisibility): Not implemented.
(LayoutTestController::setPageVisibility): Not implemented.

LayoutTests:

  • platformrm/efl/Skipped: Remove one test case of the Page Visibility API.
1:03 AM Changeset in webkit [115945] by gyuyoung.kim@samsung.com
  • 2 edits in trunk

[CMAKE] Remove unneeded keyword in WebKitFeatures.cmake
https://bugs.webkit.org/show_bug.cgi?id=85461

Reviewed by Eric Seidel.

DEFAULT keyword wasn't removed on Bug 72815.

  • Source/cmake/WebKitFeatures.cmake: Remove DEFAULT keyword in ENABLE_DRAG_SUPPORT field.
12:23 AM Changeset in webkit [115944] by danakj@chromium.org
  • 9 edits in trunk/Source

[chromium] Don't add small opaque areas to the occlusion tracker's Region
https://bugs.webkit.org/show_bug.cgi?id=85297

Reviewed by Adrienne Walker.

Source/WebCore:

Don't add small opaque areas (smaller than 160x160) to the occlusion
tracker's Region objects to avoid high Region::unite() costs.

We would like Region to just be fast enough that this isn't a concern,
and there are patches in flight to do this, but at the moment, small
opaque areas add significant cost if there is many of them, for
potentially small gains since they do not cover entire tiles.

Comments in http://code.google.com/p/chromium/issues/detail?id=124687
motivate this approach for now, and point to around 160x160 being
a reasonable threshold.

Removes the opaque paint tracking flag while we're here. The flag is
no longer used, and was broken when we moved the "paint vs opaque
flag" distinction out to the layers.

Unit test: CCOcclusionTrackerTestMinimumTrackingSize

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintLayerContents):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::::CCOcclusionTrackerBase):
(WebCore::addOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):

  • platform/graphics/chromium/cc/CCOcclusionTracker.h:

(WebCore::CCOcclusionTrackerBase::setMinimumTrackingSize):
(CCOcclusionTrackerBase):
(WebCore::CCOcclusionTrackerBase::preferredMinimumTrackingSize):

Source/WebKit/chromium:

  • tests/CCOcclusionTrackerTest.cpp:

(WebKitTests):
(CCOcclusionTrackerTestMinimumTrackingSize):
(WebKitTests::CCOcclusionTrackerTestMinimumTrackingSize::runMyTest):

12:06 AM Changeset in webkit [115943] by jonlee@apple.com
  • 38 edits
    3 copies
    1 add in trunk/Source

Migrate permission functions to Notification from NotificationCenter
https://bugs.webkit.org/show_bug.cgi?id=80485
<rdar://problem/10965458>

Reviewed by Jian Li.

Source/WebCore:

  • notifications/Notification.idl: Add permission functions.
  • notifications/DOMWindowNotifications.idl: Wrap webkitNotifications as part of legacy API.
  • notifications/Notification.cpp: New permission functions are wrapped with ENABLE(NOTIFICATIONS)

(WebCore::Notification::taskTimerFired): Use the new permission functions to determine whether we can show the
notification.
(WebCore::Notification::permissionLevel):
(WebCore::Notification::permissionString): Declare three static locals for each of the values, and return
based on the permission enum.
(WebCore::Notification::requestPermission): Forward request to client.

  • notifications/Notification.h:
  • notifications/NotificationPermissionCallback.h: Added.

(NotificationPermissionCallback):
(WebCore::NotificationPermissionCallback::~NotificationPermissionCallback):

  • notifications/NotificationPermissionCallback.idl: Added.
  • notifications/NotificationCenter.cpp: Wrap permission functions in ENABLE(LEGACY_NOTIFICATIONS)
  • notifications/NotificationCenter.h: Wrap permission functions in ENABLE(LEGACY_NOTIFICATIONS)
  • notifications/NotificationCenter.idl: Refactor conditionals to make the center available only when

ENABLE(LEGACY_NOTIFICATIONS) is on.

  • notifications/NotificationPresenter.h:

(WebCore::NotificationPresenter::requestPermission): Add new requestPermission() function for new
NotificationPermissionCallback type. Make it a stub implementation until all ports have adopted.

  • notifications/NotificationClient.h: Add another requestPermission() client call, wrapped in

ENABLE(NOTIFICATIONS) that accepts the NotificationPermissionCallback. Wrap the original one in
ENABLE(LEGACY_NOTIFICATIONS).

  • bindings/js/JSDesktopNotificationsCustom.cpp: Change to include the implementation only in

ENABLE(LEGACY_NOTIFICATIONS).

  • bindings/js/JSNotificationsCustom.cpp: Custom implementation of requestPermission().
  • bindings/v8/custom/V8NotificationCustom.cpp: Custom implementation of requestPermission().
  • notifications/WorkerContextNotifications.idl: Make webktNotifications available only in legacy API.
  • CMakeLists.txt: Add new callback idl.
  • DerivedSources.make: Add new callback idl.
  • DerivedSources.pri: Add new callback idl.
  • GNUmakefile.list.am: Add NotificationPermissionCallback files.
  • Target.pri: Include JSNotificationCustom.cpp, V8NotificationCustom.cpp
  • UseJSC.cmake: Include JSNotificationCustom.cpp
  • UseV8.cmake: Include V8NotificationCustom.cpp
  • WebCore.gypi: Include JSNotificationCustom.cpp, V8NotificationCustom.cpp, JSNotificationPermissionCallback.{h,cpp}
  • WebCore.vcproj/WebCore.vcproj: Include JSNotificationCustom.cpp, JSNotificationPermissionCallback.{h,cpp}
  • WebCore.exp.in: Export permissionString().
  • WebCore.xcodeproj/project.pbxproj: Add callback idl, h, and cpp files.

Source/WebKit/chromium:

  • src/NotificationPresenterImpl.h:

(NotificationPresenterImpl): Add stub implementation of requestPermission.
(WebKit::NotificationPresenterImpl::requestPermission):

Source/WebKit/mac:

  • WebCoreSupport/WebNotificationClient.h: *

WebCoreSupport/WebNotificationClient.mm: Add a separate callback
variable depending on the notifications API enabled.
(WebNotificationClient::requestPermission): Add
NotificationPermissionCallback version of the same
function. And refactor common code into private function.
(-[WebNotificationPolicyListener initWithCallback:]): Refactor to
take the NotificationPermissionCallback as a parameter.
(-[WebNotificationPolicyListener initWithVoidCallback:]): Add new
init method to handle legacy API.
(-[WebNotificationPolicyListener allow]): Invoke the callback for
both variables. If only one of the APIs is enabled, we are
guaranteed that the relevant callback variable exists. If both
APIs are supported, it is possible that _voidCallback will be nil
if the callback is NotificationPermissionCallback, so we need the
extra pointer check.
(-[WebNotificationPolicyListener deny]): Ditto.

Source/WebKit/qt:

  • WebCoreSupport/NotificationPresenterClientQt.h:

(NotificationPresenterClientQt): Add stub implementation of requestPermission.
(WebCore::NotificationPresenterClientQt::requestPermission):

Source/WebKit/win:

  • WebCoreSupport/WebDesktopNotificationsDelegate.cpp:

(WebDesktopNotificationsDelegate::requestPermission):

  • WebCoreSupport/WebDesktopNotificationsDelegate.h:

(WebDesktopNotificationsDelegate): Add stub implementation of requestPermission.

Source/WebKit2:

  • WebProcess/Notifications/NotificationPermissionRequestManager.cpp:

(WebKit::NotificationPermissionRequestManager::startRequest): Add version to support both kinds of
callbacks.
(WebKit::NotificationPermissionRequestManager::cancelRequest):
(WebKit::NotificationPermissionRequestManager::didReceiveNotificationPermissionDecision):

  • WebProcess/Notifications/NotificationPermissionRequestManager.h: Add another map for new callback type.

(NotificationPermissionRequestManager):

  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::show): Add #ifdef to use replaceId() or tag() depending on which feature
has been enabled. In the case where both are enabled, we prefer tag() since that is in the latest spec.

  • WebProcess/WebCoreSupport/WebNotificationClient.cpp:

(WebKit::WebNotificationClient::requestPermission):

  • WebProcess/WebCoreSupport/WebNotificationClient.h: Implement both client functions to request permissions.

May 2, 2012:

11:43 PM Changeset in webkit [115942] by tomz@codeaurora.org
  • 4 edits
    2 adds in trunk

Need tests for PerfTestRunner.computeStatistics
https://bugs.webkit.org/show_bug.cgi?id=85410

Reviewed by Ryosuke Niwa.

PerformanceTests:

  • resources/runner.js:

LayoutTests:

  • fast/harness/perftests/perf-runner-compute-statistics-expected.txt: Added.
  • fast/harness/perftests/perf-runner-compute-statistics.html: Added.
  • platform/chromium/test_expectations.txt:
11:41 PM PrefixedAPIs edited by kihong.kwon@samsung.com
(diff)
11:40 PM Changeset in webkit [115941] by Csaba Osztrogonác
  • 4 edits
    1 add in trunk/LayoutTests

[Qt] Unreviewed morning gardening.

  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/fast/forms/search-rtl-expected.png: Added.
  • platform/qt-5.0/fast/forms/search-rtl-expected.txt:
  • platform/qt/Skipped:
11:10 PM Changeset in webkit [115940] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

[Qt]r57240 broke Qt build (gcc bug)
https://bugs.webkit.org/show_bug.cgi?id=37253

Patch by Lauro Neto <lauro.neto@openbossa.org> on 2012-05-02
Reviewed by Csaba Osztrogonác.

Add back the inline hack just for ARM due to old version of
gcc still being used on Harmattan SDK. Thanks to Ossy for the
suggestion.

  • wtf/PassRefPtr.h:

(WTF):

10:51 PM Changeset in webkit [115939] by Csaba Osztrogonác
  • 10 edits in trunk/Source

Unreviewed, rolling out r115907.
http://trac.webkit.org/changeset/115907
https://bugs.webkit.org/show_bug.cgi?id=85458

It broke all viewport tests on Qt and on GTK (Requested by
Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-02

Source/WebCore:

  • dom/ViewportArguments.cpp:

(WebCore::computeViewportAttributes):

  • dom/ViewportArguments.h:

(ViewportAttributes):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPage::viewportAttributesForSize):

  • Api/qwebpage.h:
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::viewportAsText):

Source/WebKit2:

  • UIProcess/API/qt/qwebviewportinfo.cpp:

(QWebViewportInfo::layoutSize):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::sendViewportAttributesChanged):
(WebKit::WebPage::viewportConfigurationAsText):

10:45 PM Changeset in webkit [115938] by eric@webkit.org
  • 2 edits in trunk/WebKitLibraries

Resort FeatureDefinesCairo.vcprops to actually be alphabetical (in preparation for autogeneration)
https://bugs.webkit.org/show_bug.cgi?id=85454

Reviewed by Adam Barth.

The PreprocessorDefinitions line is still not sorted, but I'll do that in a separate patch.
There is no functional change in this patch. Just moving the defines around.
Its interesting to me that now that it's sorted and I can easily compare this with other
ports and found that a whole bunch of defines which should be on for Cairo are off,
likely due to Cairo simply being overlooked. These oversights should be easy to avoid
in an autogenerated world.

  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
10:03 PM Changeset in webkit [115937] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Adjusted expectations for slow tests.

  • platform/chromium/test_expectations.txt:
9:50 PM Changeset in webkit [115936] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Removed entry for fast/dom/prototype-inheritance-2.html to keep lint happy.

  • platform/chromium/test_expectations.txt:
9:07 PM Changeset in webkit [115935] by commit-queue@webkit.org
  • 6 edits in trunk/Tools

Unreviewed, rolling out r115918.
http://trac.webkit.org/changeset/115918
https://bugs.webkit.org/show_bug.cgi?id=85452

"Broke test-webkitpy on Apple Lion bots" (Requested by estes
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-02

  • Scripts/webkitpy/common/system/crashlogs.py:

(CrashLogs.init):
(CrashLogs.find_newest_log):
(CrashLogs._log_directory_darwin):
(CrashLogs._find_newest_log_darwin):

  • Scripts/webkitpy/common/system/crashlogs_unittest.py:

(CrashLogsTest.test_find_log_darwin):

  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort._get_crash_log):

  • Scripts/webkitpy/layout_tests/port/test.py:

(TestDriver.run_test):

  • Scripts/webkitpy/tool/commands/queries.py:

(execute):

8:33 PM Changeset in webkit [115934] by eric@webkit.org
  • 2 edits in trunk/WebKitLibraries

Fix tabs vs. space formating in FeatureDefines.vsprops and fix alphabetical sorting
https://bugs.webkit.org/show_bug.cgi?id=85445

Reviewed by Adam Barth.

I noticed this when comparing my auto-generated output for this file vs. the one
we have checked in. Seems we might as well fix the checked in file to be
consistent in style with itself. :)

  • win/tools/vsprops/FeatureDefines.vsprops:
8:05 PM Changeset in webkit [115933] by kov@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Finish moving modules into libWebCoreModules.la
https://bugs.webkit.org/show_bug.cgi?id=85449

Unreviewed build fix.

  • GNUmakefile.list.am: move remaining modules source files into the

libWebCoreModules library, this should fix the problems people had
building the 1.9.1 tarball with unpatched make.

8:01 PM Changeset in webkit [115932] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Unreviewed, Fix build break when WEB_AUDIO is enabled.
https://bugs.webkit.org/show_bug.cgi?id=85443

Unreviewed build fix.

Three new files were added in the Modules/webaudio directory.
These files should be included into the CMakeLists.txt file.

Patch by Dongwoo Im <dw.im@samsung.com> on 2012-05-02

  • CMakeLists.txt: Add the newly created files into the CMakeLists.txt
7:52 PM Changeset in webkit [115931] by eric@webkit.org
  • 8 edits in trunk/Source

Sort ENABLE_ defines in FeatureDefines.xcconfig files to make them easier to compare with one another (and easier to autogenerate)
https://bugs.webkit.org/show_bug.cgi?id=85433

Reviewed by Adam Barth.

I have a script which can autogenerate these xcconfig files as well as the
vsprops files (and soon the Chromium, cmake, gnumake and qmake) feature lists
from a central feature list file.
In preparation for posting such a tool, I'm re-sorting these xcconfig files to be
alphabetically ordered (currently they're close, but not quite).
There is also at least one inconsistency between these files (CSS_LEGACY_PREFIXES) which
I will fix in a second pass. I will also sort the FEATURE_DEFINES = line in a follow-up patch.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
7:42 PM Changeset in webkit [115930] by danakj@chromium.org
  • 8 edits in trunk/Source

[chromium] Don't occlude pixels in a surface that are needed for a background filter blur
https://bugs.webkit.org/show_bug.cgi?id=84317

Reviewed by Adrienne Walker.

Source/Platform:

  • chromium/public/WebFilterOperation.h:

Source/WebCore:

Blur filters move pixels around, so a pixel can influence the value of
pixels at some distance away. If a pixel is not occluded, then all
pixels within the radius of the blur may influence the value of that
pixel, so they should also stay unoccluded.

For background filters, the pixels are read from the filter's target
surface, so we remove occlusion from that target surface from pixels
that will blur into visible pixels.

Unit test: CCOcclusionTrackerTestDontOccludePixelsNeededForBackgroundFilter

CCOcclusionTrackerTestTwoBackgroundFiltersReduceOcclusionTwice
CCOcclusionTrackerTestDontOccludePixelsNeededForBackgroundFilterWithClip
CCOcclusionTrackerTestDontReduceOcclusionBelowBackgroundFilter
CCOcclusionTrackerTestDontReduceOcclusionIfBackgroundFilterIsOccluded
CCOcclusionTrackerTestReduceOcclusionWhenBackgroundFilterIsPartiallyOccluded

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::reduceOcclusion):
(WebCore):
(WebCore::reduceOcclusionBelowSurface):
(WebCore::::leaveToTargetRenderSurface):
(WebCore::::unoccludedContributingSurfaceContentRect):

  • platform/graphics/chromium/cc/CCOcclusionTracker.h:

(CCOcclusionTrackerBase):

  • platform/graphics/chromium/cc/CCQuadCuller.cpp:

(WebCore::CCQuadCuller::appendSurface):
(WebCore::CCQuadCuller::appendReplica):

Source/WebKit/chromium:

  • tests/CCOcclusionTrackerTest.cpp:

(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationTranslateOnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestReplicaOccluded::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceWithReplicaUnoccluded::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceAndReplicaOccludedDifferently::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceChildOfSurface::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceChildOfClippingSurface::runMyTest):
(WebKitTests):
(CCOcclusionTrackerTestDontOccludePixelsNeededForBackgroundFilter):
(WebKitTests::CCOcclusionTrackerTestDontOccludePixelsNeededForBackgroundFilter::runMyTest):
(CCOcclusionTrackerTestTwoBackgroundFiltersReduceOcclusionTwice):
(WebKitTests::CCOcclusionTrackerTestTwoBackgroundFiltersReduceOcclusionTwice::runMyTest):
(CCOcclusionTrackerTestDontOccludePixelsNeededForBackgroundFilterWithClip):
(WebKitTests::CCOcclusionTrackerTestDontOccludePixelsNeededForBackgroundFilterWithClip::runMyTest):
(CCOcclusionTrackerTestDontReduceOcclusionBelowBackgroundFilter):
(WebKitTests::CCOcclusionTrackerTestDontReduceOcclusionBelowBackgroundFilter::runMyTest):
(CCOcclusionTrackerTestDontReduceOcclusionIfBackgroundFilterIsOccluded):
(WebKitTests::CCOcclusionTrackerTestDontReduceOcclusionIfBackgroundFilterIsOccluded::runMyTest):
(CCOcclusionTrackerTestReduceOcclusionWhenBackgroundFilterIsPartiallyOccluded):
(WebKitTests::CCOcclusionTrackerTestReduceOcclusionWhenBackgroundFilterIsPartiallyOccluded::runMyTest):

7:15 PM Changeset in webkit [115929] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

ARM_TRADITIONAL build fix
https://bugs.webkit.org/show_bug.cgi?id=85358

Patch by Hojong Han <hojong.han@samsung.com> on 2012-05-02
Reviewed by Gavin Barraclough.

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::lshift32):
(MacroAssemblerARM):
(JSC::MacroAssemblerARM::or32):
(JSC::MacroAssemblerARM::urshift32):
(JSC::MacroAssemblerARM::xor32):
(JSC::MacroAssemblerARM::branchSub32):

7:01 PM Changeset in webkit [115928] by leviw@chromium.org
  • 2 edits in trunk/Source/WebCore

Convert FractionalLayoutUnit overflow assertions to stderr warnings
https://bugs.webkit.org/show_bug.cgi?id=85393

Reviewed by Eric Seidel.

Writing warnings to stderr when FractionalLayoutUnits overflow on debug builds instead of asserting
and crashing. It can be very useful to WebKit developers know when overflow is occurring, but it's
not always a programming error, so assert wasn't the right action.

No new tests. No change in behavior.

  • platform/FractionalLayoutUnit.h:

(WebCore):
(WebCore::FractionalLayoutUnit::FractionalLayoutUnit):
(WebCore::FractionalLayoutUnit::toUnsigned):
(WebCore::FractionalLayoutUnit::setRawValue):

6:48 PM Changeset in webkit [115927] by arv@chromium.org
  • 6 edits
    27 deletes in trunk/LayoutTests

Remove window-properties.html and other iterate over all possible properties tests
https://bugs.webkit.org/show_bug.cgi?id=85430

Reviewed by Eric Seidel.

These tests iterate over all properties in the global scope and their respective properties.
These tests are different on all platforms because they depend on build flags.
Each feature should be covered by a more specific test than a global catch all that breaks
every time anyone touches any IDL file.

  • fast/dom/Window/window-properties-expected.txt: Removed.
  • fast/dom/Window/window-properties.html: Removed.
  • fast/dom/prototype-inheritance-2-expected.txt: Removed.
  • fast/dom/prototype-inheritance-2.html: Removed.
  • fast/dom/prototype-inheritance-expected.txt: Removed.
  • fast/dom/prototype-inheritance.html: Removed.
  • fast/dom/script-tests/prototype-inheritance-2.js: Removed.
  • fast/dom/script-tests/prototype-inheritance.js: Removed.
  • platform/chromium-win/fast/dom/Window/window-properties-expected.txt: Removed.
  • platform/chromium-win/fast/dom/prototype-inheritance-2-expected.txt: Removed.
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt: Removed.
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: Removed.
  • platform/mac/fast/dom/Window/window-properties-expected.txt: Removed.
  • platform/mac/fast/dom/prototype-inheritance-2-expected.txt: Removed.
  • platform/qt-4.8/fast/dom/Window/window-properties-expected.png: Removed.
  • platform/qt-4.8/fast/dom/Window/window-properties-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/dom/Window/window-properties-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/dom/prototype-inheritance-2-expected.txt: Removed.
  • platform/qt-5.0/fast/dom/Window/window-properties-expected.png: Removed.
  • platform/qt-5.0/fast/dom/Window/window-properties-expected.txt: Removed.
  • platform/qt-5.0/fast/dom/prototype-inheritance-2-expected.txt: Removed.
  • platform/qt-arm/Skipped:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.png: Removed.
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt: Removed.
  • platform/qt/fast/dom/prototype-inheritance-expected.png: Removed.
  • platform/win/Skipped:
  • platform/win/fast/dom/Window/window-properties-expected.txt: Removed.
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt: Removed.
  • platform/wincairo/Skipped:
6:39 PM Changeset in webkit [115926] by jhoneycutt@apple.com
  • 29 edits in trunk/Source

FrameLoaderClient::dispatchWillSendSubmitEvent() should be given more
information about the form being submitted
https://bugs.webkit.org/show_bug.cgi?id=84297

Reviewed by Andy Estes.

Source/WebCore:

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::prepareForSubmission):
Get the form field names and values, and use them to create a FormState
object. Pass this object when calling dispatchWillSendSubmitEvent().
(WebCore::HTMLFormElement::getTextFieldValues):
Loop over the associated elements, looking for <input> elements.
Collect their names and values.

  • html/HTMLFormElement.h:

Declare getTextFieldData().

  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::dispatchWillSendSubmitEvent):
Updated declaration for new parameter type.

  • loader/FrameLoaderClient.h:

Updated declaration of dispatchWillSendSubmitEvent() for new param
type.

Source/WebKit/blackberry:

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendSubmitEvent):
Updated to use the FormState.

  • WebCoreSupport/FrameLoaderClientBlackBerry.h:

(FrameLoaderClientBlackBerry):
Updated method declaration.

Source/WebKit/chromium:

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchWillSendSubmitEvent):
Updated to use the FormState.

  • src/FrameLoaderClientImpl.h:

(FrameLoaderClientImpl):
Updated method declaration.

Source/WebKit/efl:

  • WebCoreSupport/FrameLoaderClientEfl.h:

(WebCore::FrameLoaderClientEfl::dispatchWillSendSubmitEvent):
Updated method declaration.

Source/WebKit/gtk:

  • WebCoreSupport/FrameLoaderClientGtk.h:

(WebKit::FrameLoaderClient::dispatchWillSendSubmitEvent):
Updated method declaration.

Source/WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.h:

Updated method declaration.

Source/WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.h:

(WebCore::FrameLoaderClientQt::dispatchWillSendSubmitEvent):
Updated method declaration.

Source/WebKit/win:

  • WebFrame.h:

Fix function stub for new parameter.

Source/WebKit/wince:

  • WebCoreSupport/FrameLoaderClientWinCE.h:

(WebKit::FrameLoaderClientWinCE::dispatchWillSendSubmitEvent):
Updated method declaration.

Source/WebKit/wx:

  • WebKitSupport/FrameLoaderClientWx.h:

(WebCore::FrameLoaderClientWx::dispatchWillSendSubmitEvent):
Updated method declaration.

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

(WebFrameLoaderClient):
Updated method declaration.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::willSendSubmitEvent):
Stubbed.

6:39 PM Changeset in webkit [115925] by jhoneycutt@apple.com
  • 13 edits in trunk/Source

Make Page::setDefersLoading() have a call count so that each time
loading is deferred, it must be balanced with a call to resume.
https://bugs.webkit.org/show_bug.cgi?id=84522

Reviewed by Andy Estes.

Source/WebCore:

  • page/Page.cpp:

(WebCore::Page::Page):
Initialize new call count member.
(WebCore::Page::setDefersLoading):
Check whether the callers wants balanced defer/resume loading behavior.
If the call count is not changing from 0 to 1 or 1 to 0, return early.
Otherwise, defer or resume loading for frames in this page.

  • page/Page.h:

(WebCore::Page::defersLoading):
Added a member to hold the call count.

  • page/Settings.cpp:

(WebCore::Settings::Settings):
Initialized new member m_wantsBalancedSetDefersLoadingBehavior.

  • page/Settings.h:

(Settings):
Added new member m_wantsBalancedSetDefersLoadingBehavior.
(WebCore::Settings::setWantsBalancedSetDefersLoadingBehavior):
Setter.
(WebCore::Settings::wantsBalancedSetDefersLoadingBehavior):
Getter.

Source/WebKit/mac:

  • WebView/WebPreferenceKeysPrivate.h:

Declare a new key for this preference.

  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
Initialize new preference to NO.
(-[WebPreferences setWantsBalancedSetDefersLoadingBehavior:]):
Setter.
(-[WebPreferences wantsBalancedSetDefersLoadingBehavior]):
Getter.

  • WebView/WebPreferencesPrivate.h:

Declare setter and getter.

  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):
Set the setting from the WebPreferences object's value.

Source/WebKit2:

  • Shared/WebPreferencesStore.h:

Use the macro to declare the new preference.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
Set the setting from the WebPreferencesStore's value.

6:24 PM Changeset in webkit [115924] by ojan@chromium.org
  • 9 edits in trunk/Source

Add a histogram for rendertree size
https://bugs.webkit.org/show_bug.cgi?id=85226

Reviewed by Eric Seidel.

Source/WebCore:

We record it when the page gets hidden, since this is a point
at which, in theory, we could kill the rendertree.

No new tests. This isn't web visible, so there's no way to test it.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::clear):

  • page/Page.cpp:

(WebCore::Page::renderTreeSize):
(WebCore):
(WebCore::Page::setVisibilityState):

  • page/Page.h:

(Page):

  • platform/HistogramSupport.cpp:

(WebCore::HistogramSupport::histogramCustomCounts):
(WebCore):

  • platform/HistogramSupport.h:

(HistogramSupport):

  • platform/chromium/HistogramSupportChromium.cpp:

(WebCore::HistogramSupport::histogramCustomCounts):
(WebCore):

Source/WebKit2:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::renderTreeSize):
Move the renderTreeSize code into Page.cpp, so it can be reused.

6:13 PM Changeset in webkit [115923] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Suppress svg failure after switching chromium-win to DRT mode.

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
6:12 PM Changeset in webkit [115922] by zmo@google.com
  • 9 edits in trunk

Unreviewed, rolling out r115902.
http://trac.webkit.org/changeset/115902
https://bugs.webkit.org/show_bug.cgi?id=85441

Compile failure on linux 32 (Requested by zhenyao on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-02

Source/WebCore:

  • Modules/indexeddb/IDBBackingStore.h:

(IDBBackingStore):

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):

  • Modules/indexeddb/IDBLevelDBBackingStore.h:

(IDBLevelDBBackingStore):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::genAutoIncrementKey):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(IDBObjectStoreBackendImpl):

LayoutTests:

  • storage/indexeddb/key-generator-expected.txt:
  • storage/indexeddb/resources/key-generator.js:
5:53 PM Changeset in webkit [115921] by jsbell@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll Chromium DEPS r134537 to r134581.
https://bugs.webkit.org/show_bug.cgi?id=85428

Unreviewed - just a deps roll.

  • DEPS:
5:43 PM Changeset in webkit [115920] by kareng@chromium.org
  • 16 edits in branches/chromium/1123/Source

Revert 115525 - Expose high-resolution on requestAnimationFrame callback
https://bugs.webkit.org/show_bug.cgi?id=66683

This changes requestAnimationFrame's animationStartTime argument
to be a high resolution DOM timestamp, per disucssion here:
http://lists.w3.org/Archives/Public/public-web-perf/2012Apr/0004.html

Reviewed by James Robinson.

Source/WebCore:

Covered by existing requestAnimationFrame tests.

  • dom/Document.cpp:

(WebCore::Document::serviceScriptedAnimations):

  • dom/Document.h:

(Document):

  • dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::ScriptedAnimationController):
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
(WebCore):
(WebCore::ScriptedAnimationController::windowScreenDidChange):
(WebCore::ScriptedAnimationController::scheduleAnimation):
(WebCore::ScriptedAnimationController::animationTimerFired):
(WebCore::ScriptedAnimationController::displayRefreshFired):

  • dom/ScriptedAnimationController.h:

(ScriptedAnimationController):

  • page/FrameView.cpp:

(WebCore::FrameView::serviceScriptedAnimations):

  • page/FrameView.h:

(FrameView):

  • platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitor::DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::notifyClients):

  • platform/graphics/DisplayRefreshMonitor.h:

(DisplayRefreshMonitor):

  • platform/graphics/blackberry/DisplayRefreshMonitorBlackBerry.cpp:

(WebCore::DisplayRefreshMonitor::displayLinkFired):

  • platform/graphics/mac/DisplayRefreshMonitorMac.cpp:

(WebCore):
(WebCore::DisplayRefreshMonitor::requestRefreshCallback):
(WebCore::DisplayRefreshMonitor::displayLinkFired):

Source/WebKit/chromium:

  • src/PageWidgetDelegate.cpp:

(WebKit::PageWidgetDelegate::animate):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::updateAnimations):

TBR=nduca@chromium.org

5:40 PM Changeset in webkit [115919] by kareng@chromium.org
  • 26 edits in branches/chromium/1123

Revert 115573 - Move Length and CSS length computation to float
https://bugs.webkit.org/show_bug.cgi?id=84801

Source/WebCore:

Patch by Emil A Eklund <eae@chromium.org> and Levi Weintraub <leviw@chromium.org> on 2012-04-26
Reviewed by Eric Seidel.

Change Length and CSS length computation to floating point. This gets us
closer to the goal of supporting subpixel layout and improves precision
for SVG which already uses floating point for its layout.

This change makes computedStyle return fractional values for pixel values
if a fraction is specified. It also changes the result of computations
where two or more values with fractional precision. Prior to this change
the result of Length(2.9) + Length(2.9) would be 4 as each value would be
floored. With this change the result is 5 as the addition is done with
floating point precision and then the result will be floored. Once we
enable subpixel layout the resulting value in this example would be 5.8.

Updated existing layout tests.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::zoomAdjustedPixelValue):

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::computeLength):

  • css/CSSPrimitiveValue.h:

(WebCore):
(WebCore::roundForImpreciseConversion):
Add specialized float version of roundForImpreciseConversion that matches
the int versions rounding logic.

If a value is sufficiently close to the next integer round it up to
ensure that a style rule such as "width: 4.999px" evaluates to 5px
instead of 4px. This is needed as, although Lengths are using floating
point, the layout system still uses integer precision and floors the
Length values.
This will change once we move to FractionalLayoutUnits but for now this
is needed to ensure compatibility with the existing system and tests.

Without this specialized rounding logic we fail a handful of tests
including acid3.

  • platform/Length.h:

(WebCore::Length::value):
(Length):
(WebCore::Length::intValue):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::styleOrColLogicalWidth):

LayoutTests:

Reviewed by Eric Seidel.

Change Length and CSS length computation to floating point. This gets us
closer to the goal of supporting subpixel layout and improves precision
for SVG which already uses floating point for its layout.

This change makes computedStyle return fractional values for pixel values
if a fraction is specified. It also changes the result of computations
where two or more values with fractional precision. Prior to this change
the result of Length(2.9) + Length(2.9) would be 4 as each value would be
floored. with this change the result is 5 as the addition is done with
floating point precision and then the result will be floored. Once we
enable subpixel layout the resulting value in this example would be 5.8.

  • fast/dom/length-attribute-mapping-expected.txt:
  • fast/dom/length-attribute-mapping.html:
  • platform/mac-snowleopard/fast/forms/001-expected.png:
  • platform/mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/mac/fast/forms/001-expected.txt:
  • platform/mac/fast/html/details-position-expected.png:
  • platform/mac/fast/html/details-position-expected.txt:
  • platform/mac/fast/replaced/width100percent-checkbox-expected.png:
  • platform/mac/fast/replaced/width100percent-checkbox-expected.txt:
  • platform/mac/fast/replaced/width100percent-radio-expected.png:
  • platform/mac/fast/replaced/width100percent-radio-expected.txt:
  • platform/mac/mathml/presentation/fractions-expected.png:
  • platform/mac/mathml/presentation/fractions-expected.txt:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/mac/mathml/presentation/mo-stretch-expected.png:
  • platform/mac/mathml/presentation/mo-stretch-expected.txt:
  • platform/mac/mathml/presentation/subsup-expected.png:
  • platform/mac/mathml/presentation/subsup-expected.txt:
  • platform/mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug1318-expected.png:
  • platform/mac/tables/mozilla/bugs/bug1318-expected.txt:

TBR=eae@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10349004

5:31 PM Changeset in webkit [115918] by rakuco@webkit.org
  • 6 edits in trunk/Tools

webkitpy: Remove sys.platform accesses in CrashLogs.
https://bugs.webkit.org/show_bug.cgi?id=85436

Reviewed by Dirk Pranke.

Instead of directly checking for sys.platform == 'darwin', use a
SystemHost and call PlatformInfo.is_mac().

  • Scripts/webkitpy/common/system/crashlogs.py:

(CrashLogs.init):
(CrashLogs.find_newest_log):
(CrashLogs._log_directory_darwin):
(CrashLogs._find_newest_log_darwin):

  • Scripts/webkitpy/common/system/crashlogs_unittest.py:

(CrashLogsTest.test_find_log_darwin):

  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort._get_crash_log):

  • Scripts/webkitpy/layout_tests/port/test.py:

(TestDriver.run_test):

  • Scripts/webkitpy/tool/commands/queries.py:

(execute):

5:29 PM Changeset in webkit [115917] by commit-queue@webkit.org
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r115905.
http://trac.webkit.org/changeset/115905
https://bugs.webkit.org/show_bug.cgi?id=85435

New computeStatistics test is failing on chromium ports
(Requested by tomz on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-02

PerformanceTests:

  • resources/runner.js:

LayoutTests:

  • fast/harness/perftests/perf-runner-compute-statistics-expected.txt: Removed.
  • fast/harness/perftests/perf-runner-compute-statistics.html: Removed.
5:18 PM Changeset in webkit [115916] by kareng@chromium.org
  • 1 edit in branches/chromium/1123/Source/WebCore/loader/FrameLoader.cpp

Revert 115549 - Ensure that there's always a provisional document loader if the frame loader is in provisional state
https://bugs.webkit.org/show_bug.cgi?id=83894

Reviewed by Nate Chapin.

We're still seeing crashes in the FrameLoader where the FrameLoader's
state is "provisional" but there is no provisional document loader. I
added code to update the FrameLoader's state everytime the provisional
document loader is cleared, and added checks that the FrameLoader's
state can't be set to provisional without a provisional loader.

If the crashes go away, or the newly added checks reveal the culprit,
we should relex the checks to use ASSERT() instead of CRASH().

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::init):
(WebCore::FrameLoader::setupForReplace):
(WebCore::FrameLoader::stopAllLoaders):
(WebCore::FrameLoader::clearProvisionalLoad):
(WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):

TBR=jochen@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10331005

5:14 PM Changeset in webkit [115915] by mhahnenberg@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

Opportunistic GC should give up if the Heap is paged out
https://bugs.webkit.org/show_bug.cgi?id=85411

Reviewed by Filip Pizlo.

Opportunistic GC is punishing us severely in limited memory situations because its
assumptions about how much time a collection will take are way out of whack when the Heap
has been paged out by the OS. We should add a simple detection function to the Heap that
detects if its is paged out. It will do this by iterating each block of both the MarkedSpace
and CopiedSpace. If that operation takes longer than a fixed amount of time (e.g. 100ms),
the function returns true. This function will only be run prior to an opportunistic
collection (i.e. it will not run during our normal allocation-triggered collections).

In my tests, steady state was drastically improved in high memory pressure situations (i.e.
the browser was still usable, significant reduction in SPODs). Occasionally, a normal GC
would be triggered due to pages doing things in the background, which would cause a
significant pause. As we close pages we now cause normal collections rather than full
collections, which prevents us from collecting all of the dead memory immediately. One
nice way to deal with this issue might be to do incremental sweeping.

  • heap/CopiedSpace.cpp:

(JSC::isBlockListPagedOut): Helper function to reduce code duplication when iterating over
to-space, from-space, and the oversize blocks.
(JSC):
(JSC::CopiedSpace::isPagedOut): Tries to determine whether or not CopiedSpace is paged out
by iterating all of the blocks.

  • heap/CopiedSpace.h:

(CopiedSpace):

  • heap/Heap.cpp:

(JSC::Heap::isPagedOut): Tries to determine whether the Heap is paged out by asking the
MarkedSpace and CopiedSpace if they are paged out.
(JSC):

  • heap/Heap.h:

(Heap):
(JSC::Heap::increaseLastGCLength): Added this so that the GC timer can linearly back off
each time it determines that the Heap is paged out.

  • heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::isPagedOut): Tries to determine if this particular MarkedAllocator's
list of blocks are paged out.
(JSC):

  • heap/MarkedAllocator.h:

(MarkedAllocator):

  • heap/MarkedSpace.cpp:

(JSC::MarkedSpace::isPagedOut): For each MarkedAllocator, check to see if they're paged out.

  • heap/MarkedSpace.h:

(MarkedSpace):

  • runtime/GCActivityCallback.cpp:

(JSC::DefaultGCActivityCallback::cancel):
(JSC):

  • runtime/GCActivityCallback.h:

(JSC::GCActivityCallback::cancel):
(DefaultGCActivityCallback):

  • runtime/GCActivityCallbackCF.cpp: Added a constant of 100ms for the timeout in determining

whether the Heap is paged out or not.
(JSC):
(JSC::DefaultGCActivityCallbackPlatformData::timerDidFire): Added the check to see if we
should attempt a collection based on whether or not we can iterate the blocks of the Heap in
100ms. If we can't, we cancel the timer and tell the Heap we just wasted 100ms more trying to
do a collection. This gives us a nice linear backoff so we're not constantly re-trying in
steady state paged-out-ness.
(JSC::DefaultGCActivityCallback::cancel): Added this function which, while currently doing
exactly the same thing as willCollect, is more obvious as to what it's doing when we call it
in timerDidFire.

5:12 PM Changeset in webkit [115914] by kareng@chromium.org
  • 12 edits in branches/chromium/1123

Revert 114283 - Avoid using backing store for compositing layers that just need to clip
https://bugs.webkit.org/show_bug.cgi?id=40547

Source/WebCore:

Reviewed by Dean Jackson.

If a layer becomes composited because it needs to clip composited
descendants, or if it has perspective, then it doesn't actually
needs its own backing store; its contents can be painted by an
ancestor, and we can just have an empty layer that does the clipping
or applies the perspective transform.

This saves backing store memory on some pages.

Tests: compositing/backing/no-backing-for-clip-overlap.html

compositing/backing/no-backing-for-clip.html
compositing/backing/no-backing-for-perspective.html

  • rendering/RenderLayer.cpp:

(WebCore):
(WebCore::RenderLayer::enclosingCompositingLayerForRepaint):
(WebCore::RenderLayer::paintLayer):

  • rendering/RenderLayer.h:

(RenderLayer):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::RenderLayerBacking):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::containsPaintedContent):
(WebCore::RenderLayerBacking::setContentsNeedDisplay):
(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
(WebCore::RenderLayerBacking::paintIntoLayer):

  • rendering/RenderLayerBacking.h:

(RenderLayerBacking):
(WebCore::RenderLayerBacking::paintsIntoCompositedAncestor):
(WebCore::RenderLayerBacking::setRequiresOwnBackingStore):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::layerWillBeRemoved):
(WebCore::RenderLayerCompositor::recursiveRepaintLayerRect):
(WebCore::RenderLayerCompositor::requiresCompositingLayer):
(WebCore::RenderLayerCompositor::requiresOwnBackingStore):
(WebCore):

  • rendering/RenderLayerCompositor.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::containerForRepaint):

  • rendering/RenderTreeAsText.cpp:

(WebCore::write):

  • rendering/RenderView.cpp:

(WebCore::RenderView::paintBoxDecorations):

LayoutTests:

Reviewed by Dean Jackson.

New tests for backing store elimination with clip or perspective.

New results for some tests that no longer have backing store on some
layers.

  • compositing/backing/no-backing-for-clip-expected.txt: Added.
  • compositing/backing/no-backing-for-clip-overlap-expected.txt: Added.
  • compositing/backing/no-backing-for-clip-overlap.html: Added.
  • compositing/backing/no-backing-for-clip.html: Added.
  • compositing/backing/no-backing-for-perspective-expected.txt: Added.
  • compositing/backing/no-backing-for-perspective.html: Added.
  • compositing/geometry/preserve-3d-switching-expected.txt:
  • compositing/visibility/layer-visible-content-expected.png:
  • compositing/visibility/layer-visible-content-expected.txt:

TBR=Simon Fraser
Review URL: https://chromiumcodereview.appspot.com/10342008

4:56 PM Changeset in webkit [115913] by jchaffraix@webkit.org
  • 5 edits in trunk/Source/WebCore

Add ASSERTs to avoid querying dirtied z-index or normal flow lists on RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=84920

Reviewed by Simon Fraser.

Covered by existing tests in Debug (at least several time!).

This change adds some ASSERTs on RenderLayer that prevent any use of its lists if they
are dirtied.

On top of this change, we added an invariant that non-stacking contexts should have their
z-index lists NULL (instead of empty or NULL previously). This is enforced at
updateZOrderLists time as we now ensure that it is called in a timely manner.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateLayerBounds):
Added call to updateLayersIfNeeded as we will query them later and there is no guarantee
that they are not dirty (we recurse in our children as part of calculateLayerBounds).
This was causing the new ASSERTs to trigger on css3/filter/ tests.

(WebCore::RenderLayer::dirtyZOrderLists):
Added a comment as to why we can't ASSERT that we are in a stacking context here.

(WebCore::RenderLayer::rebuildZOrderLists):
Added an ASSERT that we only rebuild z-index lists for dirtied stacking context.

(WebCore::RenderLayer::updateLayerListsIfNeeded):
Updated to ensure that the reflection layer has its layers updated too. This was triggering
the new ASSERTs on fast/runins/run-in-layer-not-removed-crash.html.

(WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded):
Updated to use the new isDirtyStackingContext function.

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::isDirtyStackingContext):
New helper function. Also made updateLayerListsIfNeeded() the only way
to update layer. That should prevent any misuse.

(WebCore::RenderLayer::posZOrderList):
(WebCore::RenderLayer::negZOrderList):
(WebCore::RenderLayer::normalFlowList):
ASSERT that we don't query any of the previous lists if they are dirty. Also
enforce the invariant that non-stacking contexts should have NULL z-index lists.

(WebCore::RenderLayer::clearZOrderLists):
New function to clearZOrderLists so that we can enfore the previous invariant.

(WebCore::RenderLayer::updateZOrderLists):
Updated to clear the dirty flag and the z-index lists for non-stacking context.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::addToOverlapMapRecursive):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
Removed the explicit ASSERTs.

(WebCore::RenderLayerCompositor::updateLayerTreeGeometry):
(WebCore::RenderLayerCompositor::canBeComposited):
Disabled compositing on RenderLayer in flow thread. Because flow thread's
RenderLayer are not collected as part of RenderLayer's lists and could be composited,
this was causing the new ASSERTs to trigger (e.g. on fast/regions/webkit-flow-renderer-layer.html).

  • rendering/RenderTreeAsText.cpp:

(WebCore::writeLayers):
Updated to use updateLayerListsIfNeeded().

4:48 PM Changeset in webkit [115912] by rakuco@webkit.org
  • 3 edits in trunk/Tools

webkitpy: Special-case win32 calls in file_lock and executive.
https://bugs.webkit.org/show_bug.cgi?id=85431

Reviewed by Dirk Pranke.

Simplify accesses to sys.platform by only checking if sys.platform
is "win32" and removing explicit checks for the else case.

  • Scripts/webkitpy/common/system/executive.py:

(Executive.check_running_pid):

  • Scripts/webkitpy/common/system/file_lock.py:

(FileLock._create_lock):
(FileLock._remove_lock):

4:42 PM Changeset in webkit [115911] by zmo@google.com
  • 2 edits
    2 adds in trunk/LayoutTests

Rebaseline, unreviewed.

  • platform/chromium-linux-x86/http/tests/loading: Added.
  • platform/chromium-linux-x86/http/tests/loading/pdf-commit-load-callbacks-expected.txt: Added.
  • platform/chromium-linux/http/tests/loading/pdf-commit-load-callbacks-expected.txt:
4:35 PM Changeset in webkit [115910] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

PDF page does not show up when opened in the background
https://bugs.webkit.org/show_bug.cgi?id=85427
<rdar://problem/11259951>

Reviewed by Sam Weinig.

Ensure that the accelerated hosting view is always the bottom view so it won't obscure subviews that are before it.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _enterAcceleratedCompositingMode:]):

4:27 PM Changeset in webkit [115909] by ojan@chromium.org
  • 4 edits in trunk/Tools

Remove pink from flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=85422

Reviewed by Dirk Pranke.

The pink indicates that the test doesn't match it's listing in test_expectations.txt.
In practice, this just added noise and confused people.

  • TestResultServer/static-dashboards/flakiness_dashboard.js:

(htmlForSingleTestRow):
(showLegend):

  • TestResultServer/static-dashboards/flakiness_dashboard_tests.css:

(#legend-contents *):

  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

(testHtmlForSingleTestRow):

4:26 PM Changeset in webkit [115908] by leviw@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove unused adjustForAbsoluteZoom method in RenderObject.h
https://bugs.webkit.org/show_bug.cgi?id=85396

Reviewed by Eric Seidel.

We only want to use the integer adjustForAbsoluteZoom method, so this remnant is both unused
and potentially confusing.

No new tests. Removing unused code.

  • rendering/RenderObject.h:

(WebCore):

4:15 PM Changeset in webkit [115907] by fsamuel@chromium.org
  • 10 edits in trunk/Source

Removing line in computeViewportAttributes that enforces a minimum scale factor to never allow zooming out more than viewport
https://bugs.webkit.org/show_bug.cgi?id=70609

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Make ViewportAttributes' layoutSize be a FloatRect to avoid rounding
too early, and the occasional off by one fixed layout dimensions.

  • dom/ViewportArguments.cpp:

(WebCore::computeViewportAttributes):

  • dom/ViewportArguments.h:

(ViewportAttributes):

Source/WebKit/qt:

  • Api/qwebpage.h:
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::viewportAsText):

Source/WebKit2:

  • UIProcess/API/qt/qwebviewportinfo.cpp:

(QWebViewportInfo::layoutSize):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::viewportConfigurationAsText):

4:11 PM Changeset in webkit [115906] by jchaffraix@webkit.org
  • 4 edits
    3 adds
    4 deletes in trunk/LayoutTests

Unreviewed gardening.

Rebaselined overflow-delete-line.html and ancestor-overflow.html.

The pixel changes are only text differences.

  • fast/repaint/overflow-delete-line-expected.txt: Added.
  • platform/chromium-mac-leopard/compositing/overflow/ancestor-overflow-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/overflow-delete-line-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/overflow-delete-line-expected.png:
  • platform/chromium-mac/compositing/overflow/ancestor-overflow-expected.txt: Removed.
  • platform/chromium-mac/fast/repaint/overflow-delete-line-expected.txt: Removed.
  • platform/chromium-win/compositing/overflow/ancestor-overflow-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/efl/fast/repaint/overflow-delete-line-expected.txt: Removed.
  • platform/gtk/fast/repaint/overflow-delete-line-expected.txt: Removed.
4:08 PM Changeset in webkit [115905] by tomz@codeaurora.org
  • 3 edits
    3 adds in trunk

Need tests for PerfTestRunner.computeStatistics
https://bugs.webkit.org/show_bug.cgi?id=85410

Reviewed by Ryosuke Niwa.

PerformanceTests:

  • resources/runner.js:

LayoutTests:

  • fast/harness/perftests/perf-runner-compute-statistics-expected.txt: Added.
  • fast/harness/perftests/perf-runner-compute-statistics.html: Added.
4:08 PM Changeset in webkit [115904] by kov@webkit.org
  • 2 edits in trunk/Tools

Unreviewed. Fix mistake I committed when applying review comments.

  • jhbuild/jhbuild-wrapper: dependencies_path was getting 'Root'

appended to its path, so jhbuild itself was being cloned and
installed in the wrong place when using WEBKITOUTPUTDIR.

4:05 PM Changeset in webkit [115903] by dpranke@chromium.org
  • 4 edits in trunk/Tools

nrwt: make ServerProcess work on chromium win
https://bugs.webkit.org/show_bug.cgi?id=85333

Reviewed by Ojan Vafai.

This change implements a poor man's select() that will
slow-spin doing non-blocking reads on the stdout and stderr
named pipes connecting the worker to the driver. Seems to work
and I have yet to see much overhead or ill effects but it
probably needs more testing.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumDriver.init):

  • Scripts/webkitpy/layout_tests/port/server_process.py:

(ServerProcess._start):
(ServerProcess._wait_for_data_and_update_buffers_using_select):
(ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
(ServerProcess):
(ServerProcess._non_blocking_read_win32):
(ServerProcess._read):

  • Scripts/webkitpy/layout_tests/port/server_process_unittest.py:

(TestServerProcess.test_basic): Added.

4:03 PM Changeset in webkit [115902] by jsbell@chromium.org
  • 9 edits in trunk

IndexedDB: Handle generated keys up to 253
https://bugs.webkit.org/show_bug.cgi?id=85114

Source/WebCore:

The spec defines the behavior for generated keys up to 253
(the maximum integer storable as an ECMAScript number) and
the error case when going beyond that. Ensure that we can
handle values up to that point and generate errors beyond.

Reviewed by Tony Chang.

Test: storage/indexeddb/key-generator.html

  • Modules/indexeddb/IDBBackingStore.h:

(IDBBackingStore):

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):

  • Modules/indexeddb/IDBLevelDBBackingStore.h:

(IDBLevelDBBackingStore):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::genAutoIncrementKey):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(IDBObjectStoreBackendImpl):

LayoutTests:

Reviewed by Tony Chang.

  • storage/indexeddb/key-generator-expected.txt:
  • storage/indexeddb/resources/key-generator.js:

(get defineTest):

4:01 PM Changeset in webkit [115901] by zmo@google.com
  • 2 edits in trunk/LayoutTests

Rebaseline, unreviewed.

  • platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.txt:
3:55 PM Changeset in webkit [115900] by rakuco@webkit.org
  • 4 edits in trunk/Tools

webkitpy: Use a SystemHost instead of PlatformInfo in the PNG checker.
https://bugs.webkit.org/show_bug.cgi?id=85426

Reviewed by Dirk Pranke.

r115880 replaced the direct use of sys.platform with a
PlatformInfo object. Dirk Pranke later told me SystemHost objects
should be preferred, as nothing out of webkitpy.common.system
should create its own PlatformInfo instances.

  • Scripts/webkitpy/common/system/systemhost_mock.py:

(MockSystemHost.init): Make it possible to specify a custom
filesystem object.

  • Scripts/webkitpy/style/checkers/png.py:

(PNGChecker.init): Accept a host object instead of a
filesystem one, which is now obtained from host.
(PNGChecker._config_file_path): Retrieve PlatformInfo from
SystemHost.

  • Scripts/webkitpy/style/checkers/png_unittest.py:

(PNGCheckerTest.test_init): Adjust calls to PNGChecker to its new
constructor signature.
(PNGCheckerTest.test_check): Ditto.

3:53 PM Changeset in webkit [115899] by zmo@google.com
  • 2 edits
    1 add in trunk/LayoutTests

Rebaseline, unreviewed.

  • platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/chromium/media/media-can-play-wav-audio-expected.txt: Added.
3:22 PM Changeset in webkit [115898] by rakuco@webkit.org
  • 3 edits in trunk/Tools

webkitpy: Remove direct checks for sys.platform == 'darwin' in the layout test classes.
https://bugs.webkit.org/show_bug.cgi?id=85424

Reviewed by Tony Chang.

We should reduce direct usage of sys.platform in webkitpy and use
PlatformInfo instead.

  • Scripts/webkitpy/layout_tests/servers/http_server.py:

(Lighttpd._prepare_config): Call PlatformInfo.is_mac() instead of
checking for 'darwin' directly.

  • Scripts/webkitpy/layout_tests/servers/http_server_base.py:

(HttpServerBase.init): Ditto.

3:04 PM Changeset in webkit [115897] by adamk@chromium.org
  • 3 edits
    2 adds in trunk

Childlist mutations in shadow DOM should be observable with MutationObservers
https://bugs.webkit.org/show_bug.cgi?id=85402

Reviewed by Ojan Vafai.

Source/WebCore:

Though Mutation Events are not supported in Shadow DOM,
MutationObservers are supposed to be. Due to a misplacement of the
ChildListMutationScope, they were erroneously getting skipped.

This patch moves code around to properly notify when childlist are
mutated in shadow DOM and covers that change with a new test.

Test: fast/mutation/shadow-dom.html

  • dom/ContainerNode.cpp:

(WebCore::willRemoveChild): Handle notification of removal directly.
(WebCore::willRemoveChildren): ditto.
(WebCore::dispatchChildInsertionEvents): Remove notification of insertion.
(WebCore::dispatchChildRemovalEvents): Remove notification of removal.
(WebCore::updateTreeAfterInsertion): Handle notification of insertion directly.

LayoutTests:

Added test covering childList mutations as well as attribute and
characterData mutations (these were already working).

  • fast/mutation/shadow-dom-expected.txt: Added.
  • fast/mutation/shadow-dom.html: Added.
3:01 PM Changeset in webkit [115896] by eric.carlson@apple.com
  • 3 edits
    2 adds in trunk

Crash in WebCore::TextTrackList::remove
https://bugs.webkit.org/show_bug.cgi?id=85095

Reviewed by Maciej Stachowiak.

Source/WebCore:

Test: media/track/track-remove-quickly.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::willRemoveTrack): Return immediately if the tracks collection

has not been allocated yet.

LayoutTests:

  • media/track/track-remove-quickly-expected.txt: Added.
  • media/track/track-remove-quickly.html: Added.
3:00 PM Changeset in webkit [115895] by commit-queue@webkit.org
  • 15 edits in trunk

After appending MathML with jquery the table renders with overlaps
https://bugs.webkit.org/show_bug.cgi?id=52444

Patch by David Barton <Dave Barton> on 2012-05-02
Reviewed by Julien Chaffraix.

Source/WebCore:

This patch also fixes bugs 72834 and 47781. The main problem is that correct preferred
logical widths are affected by operator stretching. Thus we add a call to
setNeedsLayoutAndPrefWidthsRecalc() after the stretching code in
RenderMathMLOperator.cpp, and change RenderMathMLBlock and RenderMathMLRow to make sure
that stretching of children is done before an <mrow>'s preferred logical widths are
computed.

Test: Added a test to mathml/presentation/mo-stretch.html

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::RenderMathMLBlock):
(WebCore::RenderMathMLBlock::computePreferredLogicalWidths):
(WebCore::RenderMathMLBlock::computeChildrenPreferredLogicalHeights):
(WebCore::RenderMathMLBlock::preferredLogicalHeightAfterSizing):

  • rendering/mathml/RenderMathMLBlock.h:

(WebCore::RenderMathMLBlock::unembellishedOperator):
(WebCore::RenderMathMLBlock::isPreferredLogicalHeightDirty):
(WebCore::RenderMathMLBlock::preferredLogicalHeight):
(WebCore::RenderMathMLBlock::setPreferredLogicalHeight):

  • Add m_preferredLogicalHeight and methods to compute and return it.
  • Remove stretchToHeight() from most classes as it no longer needs to be done recursively. We just call it on the base of an embellished operator, and that calls setNeedsLayoutAndPrefWidthsRecalc() to mark itself and its container chain.
  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::stretchToHeight):

  • Don't compare an unexpanded height to an expanded one.

(WebCore::RenderMathMLOperator::computePreferredLogicalWidths):
(WebCore::RenderMathMLOperator::updateFromElement):

  • After stretching, call setNeedsLayoutAndPrefWidthsRecalc().
  • rendering/mathml/RenderMathMLOperator.h:

(RenderMathMLOperator):

  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::computePreferredLogicalWidths):
(WebCore::RenderMathMLRow::layout):

  • rendering/mathml/RenderMathMLRow.h:

(RenderMathMLRow):

  • Add computePreferredLogicalWidths(), using computeChildrenPreferredLogicalHeights() to compute our children's preferred logical heights if necessary, followed by operator stretching.
  • rendering/mathml/RenderMathMLSubSup.cpp:
  • rendering/mathml/RenderMathMLSubSup.h:

(RenderMathMLSubSup):

  • rendering/mathml/RenderMathMLUnderOver.cpp:
  • rendering/mathml/RenderMathMLUnderOver.h:

(RenderMathMLUnderOver):

LayoutTests:

  • mathml/presentation/mo-stretch.html:
  • platform/mac/mathml/presentation/mo-stretch-expected.png:
  • platform/mac/mathml/presentation/mo-stretch-expected.txt:
2:55 PM Changeset in webkit [115894] by rakuco@webkit.org
  • 2 edits in trunk/Tools

webkitpy: Remove direct sys.platform usage in run_webkit_tests_integrationtest.
https://bugs.webkit.org/show_bug.cgi?id=85419

Reviewed by Dirk Pranke.

As pointed out by Dirk Pranke, a PlatformInfo is not supposed to
be created directly, we should should a SystemHost instead.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.setUp): Create a SystemHost and obtain the PlatformInfo
object from it instead of creating PlatformInfo directly.

2:51 PM Changeset in webkit [115893] by thakis@chromium.org
  • 2 edits in trunk/Source/WTF

Let WebKit parse with clang on windows with -std=c++11
https://bugs.webkit.org/show_bug.cgi?id=85398

Reviewed by Ryosuke Niwa.

See http://trac.webkit.org/changeset/85945 for background on the line
I'm changing. With clang, GXX_EXPERIMENTLAL_CXX0X is set in c++11
mode, but MSVC's c++ library doesn't have a tr1/memory header. So also
check for GLIBCXX, like it's done in the rest of this file.

  • wtf/TypeTraits.h:
2:49 PM Changeset in webkit [115892] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

  • platform/gtk/test_expectations.txt: remove duplicate annotation

for fast/workers/storage/use-same-database-in-page-and-workers.html,
added comment explaining the ocasional ASSERT that's a
cross-platform problem.

2:44 PM Changeset in webkit [115891] by aestes@apple.com
  • 2 edits in trunk/LayoutTests

media/audio-repaint.html sometimes fails on Lion Debug (Tests)
https://bugs.webkit.org/show_bug.cgi?id=84357

  • platform/mac/Skipped: Skipped the flaky test.
2:41 PM Changeset in webkit [115890] by aestes@apple.com
  • 3 edits in trunk/LayoutTests

Update two more Mac baselines.

  • platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
2:40 PM Changeset in webkit [115889] by jochen@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Add WebDocument::referrerPolicy() which wraps the same method on Document
https://bugs.webkit.org/show_bug.cgi?id=85201

Reviewed by Adam Barth.

Embedders should use webFrame->document()->referrerPolicy() instead of webFrame->referrerPolicy(). The latter will be removed soon.

  • public/WebDocument.h:

(WebDocument):

  • src/WebDocument.cpp:

(WebKit::WebDocument::referrerPolicy):
(WebKit):

2:32 PM Changeset in webkit [115888] by rakuco@webkit.org
  • 2 edits in trunk/Tools

webkitpy: Remove direct sys.platform usage in run_webkit_tests_integrationtest.
https://bugs.webkit.org/show_bug.cgi?id=85419

Rubber-stamped by Dirk Pranke.

Follow-up patch to r115887 which fixes some capitalization problems
pointed out in comments 2 and 4.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.setUp):
(MainTest.test_child_processes_2):
(MainTest.test_child_processes_min):
(MainTest.test_exception_raised):
(MainTest.test_keyboard_interrupt):

2:16 PM Changeset in webkit [115887] by rakuco@webkit.org
  • 2 edits in trunk/Tools

webkitpy: Remove direct sys.platform usage in run_webkit_tests_integrationtest.
https://bugs.webkit.org/show_bug.cgi?id=85419

Reviewed by Dirk Pranke.

Another part of the work towards replacing direct sys.platform
usage with PlatformInfo.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.setUp): Move the setting of SHOULD_TEST_PROCESSES
here. Even though it is costlier, unittest.setUpClass was
introduced in Python 2.7.
(MainTest.test_child_processes_2): Use self.SHOULD_TEST_PROCESSES.
(MainTest.test_child_processes_min): Ditto.
(MainTest.test_exception_raised): Ditto.
(MainTest.test_keyboard_interrupt): Ditto.
(MainTest.test_crash_log): Check for PlatformInfo.is_mac().
(MainTest.test_web_process_crash_log): Ditto, and remove duplicate
check at the end.
(MainTest.test_no_http_tests): Remove check for (cygwin && Python
2.5.2), as we only support Python 2.6+.

2:09 PM Changeset in webkit [115886] by danakj@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Avoid extra Region copies in CCOcclusionTracker
https://bugs.webkit.org/show_bug.cgi?id=85257

Reviewed by Adrienne Walker.

Instead of making a Region for each layer and then uniting the region
with the current occlusion, directly add the rects for the given layer
to the current occlusion.

When subtracting a region from a rect, just subtract the region
directly instead of computing the intersecting region.

Covered by existing tests.

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::addOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):
(WebCore::rectSubtractRegion):

1:54 PM Changeset in webkit [115885] by aestes@apple.com
  • 5 edits in trunk/LayoutTests

Update more Mac baselines after r115846.

  • platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/mac/fast/block/float/avoiding-float-centered-expected.txt:
  • platform/mac/fast/block/float/float-not-removed-from-next-sibling3-expected.txt:
  • platform/mac/media/audio-controls-rendering-expected.txt:
1:53 PM Changeset in webkit [115884] by rniwa@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

blockquote gets clobbered on delete, but the font-tag inside it doesn't
https://bugs.webkit.org/show_bug.cgi?id=19702

Reviewed by Enrica Casucci.

Add a regression test initially authored by Ojan Vafai since this bug appears to have been fixed already.

  • editing/execCommand/delete-line-and-insert-text-in-font-inside-blockquote-expected.txt: Added.
  • editing/execCommand/delete-line-and-insert-text-in-font-inside-blockquote.html: Added.
1:53 PM Changeset in webkit [115883] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Double tap zooming does nothing on small size table
https://bugs.webkit.org/show_bug.cgi?id=85383

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-05-02
Reviewed by George Staikos.

PR: 153232
When we search the best node for block zoom, if the initial node's new
scale exceeds the maximum block zoom scale, we will try to walk through
it's ancestors and pick the acceptable one. But the reality is that the
acceptable ancestor's size can be too close to the size of the actual
contents, we will do nothing for it. As we will still select the
minimum of the new scale and the maximum block zoom scale as block zoom
scale, we can ignore such kind of node and use the initial node instead.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::adjustedBlockZoomNodeForZoomLimits):

1:48 PM Changeset in webkit [115882] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[Qt] ASSERT in FontCustomPlatformDataQt.cpp with invalid font in data URI
https://bugs.webkit.org/show_bug.cgi?id=85089

Patch by Keith Rosenblatt <keith.rosenblatt@nokia.com> on 2012-05-02
Reviewed by Simon Hausmann.

Source/WebCore:

Do not return data referencing an invalid QRawFont from createFontCustomPlatformData(). Instead
return null.

Test: fast/css/font-face-data-uri-invalid.html

  • platform/graphics/qt/FontCustomPlatformDataQt.cpp:

(WebCore::createFontCustomPlatformData):

LayoutTests:

  • fast/css/font-face-data-uri-invalid-expected.txt: Added.
  • fast/css/font-face-data-uri-invalid.html: Added.
1:42 PM Changeset in webkit [115881] by commit-queue@webkit.org
  • 16 edits in trunk/Source

[chromium] Set contents texture manager preferred memory limit based on GpuMemoryManager suggestion.
https://bugs.webkit.org/show_bug.cgi?id=84270

Patch by Michal Mocny <mmocny@google.com> on 2012-05-02
Reviewed by Kenneth Russell.

Source/WebCore:

Updates the content texture manager memory limits based on GpuMemoryManager memory allocation suggestions.

The memory allocation size (in bytes) is fed from LayerRendererChromium memory allocation changed callback
handler to CCLayerTreeHost. At that point we adjust the limits, using the existing notions of preferred and
max limits.

On android, the preferred limit is half the maximum (as it has always been), but on all other platforms the
preferred limit is now equal to max, in order to allow more agressive prepainting.

Finally, android has memory constraints dependant on viewportSize, but that logic has been pushed into
the GpuMemoryManager.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererGpuMemoryAllocationChangedCallbackAdapter::onGpuMemoryAllocationChanged):
(WebCore::LayerRendererChromium::beginDrawingFrame):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromiumClient):

  • platform/graphics/chromium/TextureManager.cpp:

(WebCore::TextureManager::setMemoryAllocationLimitBytes):
(WebCore):

  • platform/graphics/chromium/TextureManager.h:

(TextureManager):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::setViewportSize):
(WebCore::CCLayerTreeHost::setContentsMemoryAllocationLimitBytes):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::setContentsMemoryAllocationLimitBytes):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImplClient):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::postSetContentsMemoryAllocationLimitBytesToMainThreadOnImplThread):
(WebCore):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::postSetContentsMemoryAllocationLimitBytesToMainThreadOnImplThread):
(WebCore):
(WebCore::CCThreadProxy::setContentsMemoryAllocationLimitBytes):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/LayerRendererChromiumTest.cpp:
1:38 PM Changeset in webkit [115880] by rakuco@webkit.org
  • 4 edits in trunk/Tools

webkitpy: Remove direct sys.platform usage in the PNG checker.
https://bugs.webkit.org/show_bug.cgi?id=85407

Reviewed by Tony Chang.

Work towards replacing direct sys.platform usage with
PlatformInfo.

  • Scripts/webkitpy/common/system/platforminfo_mock.py:

(MockPlatformInfo.init): Accept os_name and os_version as
arguments.

  • Scripts/webkitpy/style/checkers/png.py:

(PNGChecker.init): Create a PlatformInfo object instead of
using sys.platform when needed.
(PNGChecker._config_file_path): Check for the current platform via
PlatformInfo.

  • Scripts/webkitpy/style/checkers/png_unittest.py:

(PNGCheckerTest.test_check): Update tests after the changes above.

1:31 PM Changeset in webkit [115879] by aestes@apple.com
  • 16 edits
    2 adds in trunk/LayoutTests

Update Mac baselines after r115846.

  • platform/mac/fast/clip/008-expected.txt:
  • platform/mac/fast/clip/011-expected.txt:
  • platform/mac/fast/clip/012-expected.txt:
  • platform/mac/fast/forms/input-text-double-click-expected.txt:
  • platform/mac/fast/repaint/overflow-delete-line-expected.txt:
  • platform/mac/media/controls-after-reload-expected.txt:
  • platform/mac/media/controls-strict-expected.txt:
  • platform/mac/media/video-controls-rendering-expected.txt:
  • platform/mac/media/video-display-toggle-expected.txt:
  • platform/mac/media/video-no-audio-expected.txt:
  • platform/mac/media/video-playing-and-pause-expected.txt:
  • platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt: Added.
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/mac/svg/hixie/mixed/003-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/mac/transforms/3d/general/perspective-non-layer-expected.txt:
1:30 PM Changeset in webkit [115878] by leviw@chromium.org
  • 6 edits in branches/subpixellayout

Changing expectations and outputting overflow warnings to stdout instead of stderr to trigger test failure in debug builds.

1:29 PM Changeset in webkit [115877] by eae@chromium.org
  • 11 edits in trunk/Source

Fix usage of layout types in platform code
https://bugs.webkit.org/show_bug.cgi?id=85392

Reviewed by Eric Seidel.

Source/WebCore:

No new tests, no change in functionality.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureTap):
Use rounded point for gestures as event handling is still mostly int based.

Source/WebKit/chromium:

  • src/WebHitTestResult.cpp:

(WebKit::WebHitTestResult::localPoint):

  • src/WebSurroundingText.cpp:

(WebKit::WebSurroundingText::initialize):
Explicitly cast WebPoint to IntPoint to avoid ambiguous conversion error.

Source/WebKit/efl:

  • ewk/ewk_frame.cpp:

(ewk_frame_focused_element_geometry_get):

  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(ewk_view_scale_set):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::tiledBackingStoreVisibleRect):
Use enclosingIntRect to convert visible rect for transform results to
line up with device pixels.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::editorState):
Use pixelSnapped rect for editor rect calculation as it represents a
device coordinate.

1:27 PM Changeset in webkit [115876] by Nate Chapin
  • 1 edit
    1 add in trunk/LayoutTests

2012-05-02 Nate Chapin <Nate Chapin>

Unreviewed, rebaseline pdf-commit-load-callbacks.html for chromium-linux.

  • platform/chromium-linux/http/tests/loading/pdf-commit-load-callbacks-expected.txt: Added.
1:17 PM Changeset in webkit [115875] by Csaba Osztrogonác
  • 243 edits
    7 copies
    44 adds in trunk/LayoutTests

[Qt] Unreviewed, rebaselining after changes in r115846.

REGRESSION(110072): Clipping is not applied on layers that are animated using platform code
https://bugs.webkit.org/show_bug.cgi?id=83954

  • platform/qt/animations/combo-transform-translate+scale-expected.txt: Added.
  • platform/qt/compositing/geometry/object-clip-rects-assertion-expected.txt: Added.
  • platform/qt/compositing/overflow/ancestor-overflow-expected.png:
  • platform/qt/compositing/overflow/ancestor-overflow-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-23-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-23-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-24-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-24-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-68-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-68-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-69-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-69-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-23-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-23-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-24-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-68-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-69-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-69-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-23-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-23-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-24-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-24-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-68-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-68-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-69-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-69-expected.txt:
  • platform/qt/editing/pasteboard/4806874-expected.png:
  • platform/qt/editing/pasteboard/4806874-expected.txt:
  • platform/qt/editing/pasteboard/input-field-1-expected.png:
  • platform/qt/editing/pasteboard/input-field-1-expected.txt:
  • platform/qt/editing/selection/3690703-2-expected.png:
  • platform/qt/editing/selection/3690703-2-expected.txt:
  • platform/qt/editing/selection/3690703-expected.png:
  • platform/qt/editing/selection/3690703-expected.txt:
  • platform/qt/editing/selection/3690719-expected.png:
  • platform/qt/editing/selection/3690719-expected.txt:
  • platform/qt/editing/selection/4895428-3-expected.png:
  • platform/qt/editing/selection/4895428-3-expected.txt:
  • platform/qt/editing/selection/4975120-expected.png:
  • platform/qt/editing/selection/4975120-expected.txt:
  • platform/qt/editing/selection/drag-select-1-expected.png:
  • platform/qt/editing/selection/drag-select-1-expected.txt:
  • platform/qt/editing/selection/expanding-selections-expected.png:
  • platform/qt/editing/selection/expanding-selections-expected.txt:
  • platform/qt/editing/selection/leave-requested-block-expected.png:
  • platform/qt/editing/selection/leave-requested-block-expected.txt:
  • platform/qt/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/qt/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/qt/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/qt/editing/selection/select-across-readonly-input-2-expected.txt:
  • platform/qt/editing/selection/select-across-readonly-input-3-expected.png:
  • platform/qt/editing/selection/select-across-readonly-input-3-expected.txt:
  • platform/qt/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/qt/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/qt/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/qt/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/qt/fast/block/float/032-expected.png:
  • platform/qt/fast/block/float/032-expected.txt:
  • platform/qt/fast/block/float/033-expected.txt:
  • platform/qt/fast/block/float/avoidance-rtl-expected.txt:
  • platform/qt/fast/block/float/float-not-removed-from-next-sibling3-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png.
  • platform/qt/fast/block/float/float-not-removed-from-next-sibling3-expected.txt:
  • platform/qt/fast/block/float/float-overflow-hidden-containing-block-width-expected.png:
  • platform/qt/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt:
  • platform/qt/fast/block/float/in-margin-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/iframe-scroll-repaint-expected.png.
  • platform/qt/fast/block/float/in-margin-expected.txt:
  • platform/qt/fast/block/float/overlapping-floats-with-overflow-hidden-expected.png:
  • platform/qt/fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt:
  • platform/qt/fast/block/float/shrink-to-avoid-float-complexity-expected.png:
  • platform/qt/fast/block/float/shrink-to-avoid-float-complexity-expected.txt:
  • platform/qt/fast/block/lineboxcontain/parsing-invalid-expected.png:
  • platform/qt/fast/block/lineboxcontain/parsing-invalid-expected.txt:
  • platform/qt/fast/clip/008-expected.png:
  • platform/qt/fast/clip/008-expected.txt:
  • platform/qt/fast/clip/011-expected.png:
  • platform/qt/fast/clip/011-expected.txt:
  • platform/qt/fast/clip/012-expected.png:
  • platform/qt/fast/clip/012-expected.txt:
  • platform/qt/fast/clip/017-expected.png: Copied from LayoutTests/platform/qt/tables/mozilla_expected_failures/bugs/bug45621-expected.png.
  • platform/qt/fast/clip/017-expected.txt:
  • platform/qt/fast/css/input-search-padding-expected.png:
  • platform/qt/fast/css/input-search-padding-expected.txt:
  • platform/qt/fast/css/invalidation-errors-2-expected.png:
  • platform/qt/fast/css/invalidation-errors-2-expected.txt:
  • platform/qt/fast/css/invalidation-errors-expected.png:
  • platform/qt/fast/css/invalidation-errors-expected.txt:
  • platform/qt/fast/css/line-height-expected.png:
  • platform/qt/fast/css/line-height-expected.txt:
  • platform/qt/fast/css/nested-layers-with-hover-expected.png:
  • platform/qt/fast/css/nested-layers-with-hover-expected.txt:
  • platform/qt/fast/css/resize-single-axis-expected.txt: Added.
  • platform/qt/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/qt/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/qt/fast/css/text-overflow-input-expected.txt:
  • platform/qt/fast/dom/isindex-001-expected.png: Added.
  • platform/qt/fast/dom/isindex-001-expected.txt:
  • platform/qt/fast/dynamic/subtree-boundary-percent-height-expected.png:
  • platform/qt/fast/dynamic/subtree-boundary-percent-height-expected.txt:
  • platform/qt/fast/dynamic/subtree-no-common-root-static-y-expected.png:
  • platform/qt/fast/dynamic/subtree-no-common-root-static-y-expected.txt:
  • platform/qt/fast/dynamic/subtree-table-cell-height-expected.png:
  • platform/qt/fast/dynamic/subtree-table-cell-height-expected.txt:
  • platform/qt/fast/events/context-no-deselect-expected.png: Added.
  • platform/qt/fast/events/context-no-deselect-expected.txt:
  • platform/qt/fast/events/mouse-relative-position-expected.txt: Added.
  • platform/qt/fast/forms/basic-inputs-expected.txt:
  • platform/qt/fast/forms/date/date-appearance-expected.png: Added.
  • platform/qt/fast/forms/date/date-appearance-expected.txt: Added.
  • platform/qt/fast/forms/encoding-test-expected.png: Copied from LayoutTests/platform/qt/fast/forms/search-styled-expected.png.
  • platform/qt/fast/forms/encoding-test-expected.txt:
  • platform/qt/fast/forms/fieldset-align-expected.png: Added.
  • platform/qt/fast/forms/fieldset-align-expected.txt:
  • platform/qt/fast/forms/floating-textfield-relayout-expected.png: Added.
  • platform/qt/fast/forms/floating-textfield-relayout-expected.txt:
  • platform/qt/fast/forms/input-align-expected.png: Added.
  • platform/qt/fast/forms/input-align-expected.txt:
  • platform/qt/fast/forms/input-appearance-bkcolor-expected.png: Added.
  • platform/qt/fast/forms/input-appearance-bkcolor-expected.txt:
  • platform/qt/fast/forms/input-appearance-default-bkcolor-expected.png: Added.
  • platform/qt/fast/forms/input-appearance-default-bkcolor-expected.txt:
  • platform/qt/fast/forms/input-appearance-disabled-expected.png: Added.
  • platform/qt/fast/forms/input-appearance-disabled-expected.txt:
  • platform/qt/fast/forms/input-appearance-focus-expected.png: Added.
  • platform/qt/fast/forms/input-appearance-focus-expected.txt:
  • platform/qt/fast/forms/input-appearance-preventDefault-expected.png: Added.
  • platform/qt/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/qt/fast/forms/input-appearance-readonly-expected.png: Added.
  • platform/qt/fast/forms/input-appearance-readonly-expected.txt:
  • platform/qt/fast/forms/input-appearance-selection-expected.png: Added.
  • platform/qt/fast/forms/input-appearance-visibility-expected.png: Added.
  • platform/qt/fast/forms/input-appearance-visibility-expected.txt:
  • platform/qt/fast/forms/input-baseline-expected.png: Added.
  • platform/qt/fast/forms/input-baseline-expected.txt:
  • platform/qt/fast/forms/input-double-click-selection-gap-bug-expected.png: Added.
  • platform/qt/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/qt/fast/forms/input-field-text-truncated-expected.png: Added.
  • platform/qt/fast/forms/input-field-text-truncated-expected.txt:
  • platform/qt/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/qt/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/qt/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/qt/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/qt/fast/forms/input-readonly-empty-expected.png: Added.
  • platform/qt/fast/forms/input-readonly-empty-expected.txt:
  • platform/qt/fast/forms/input-spaces-expected.png: Added.
  • platform/qt/fast/forms/input-spaces-expected.txt:
  • platform/qt/fast/forms/input-text-click-inside-expected.png: Added.
  • platform/qt/fast/forms/input-text-click-inside-expected.txt:
  • platform/qt/fast/forms/input-text-double-click-expected.png: Added.
  • platform/qt/fast/forms/input-text-double-click-expected.txt:
  • platform/qt/fast/forms/input-text-option-delete-expected.png: Added.
  • platform/qt/fast/forms/input-text-option-delete-expected.txt:
  • platform/qt/fast/forms/input-text-self-emptying-click-expected.png: Added.
  • platform/qt/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/qt/fast/forms/input-width-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png.
  • platform/qt/fast/forms/input-width-expected.txt:
  • platform/qt/fast/forms/number/input-appearance-number-rtl-expected.png:
  • platform/qt/fast/forms/number/input-appearance-number-rtl-expected.txt:
  • platform/qt/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/qt/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/qt/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/qt/fast/forms/number/input-appearance-spinbutton-layer-expected.txt:
  • platform/qt/fast/forms/placeholder-position-expected.png:
  • platform/qt/fast/forms/placeholder-position-expected.txt:
  • platform/qt/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/qt/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/qt/fast/forms/search-display-none-cancel-button-expected.png:
  • platform/qt/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/qt/fast/forms/search-rtl-expected.png:
  • platform/qt/fast/forms/search-rtl-expected.txt:
  • platform/qt/fast/forms/search-styled-expected.png:
  • platform/qt/fast/forms/search-styled-expected.txt:
  • platform/qt/fast/forms/search-vertical-alignment-expected.png:
  • platform/qt/fast/forms/search-vertical-alignment-expected.txt:
  • platform/qt/fast/forms/text-style-color-expected.png: Added.
  • platform/qt/fast/forms/text-style-color-expected.txt:
  • platform/qt/fast/forms/textfield-focus-ring-expected.png:
  • platform/qt/fast/forms/textfield-focus-ring-expected.txt:
  • platform/qt/fast/frames/take-focus-from-iframe-expected.png:
  • platform/qt/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/qt/fast/html/details-no-summary4-expected.png:
  • platform/qt/fast/html/details-no-summary4-expected.txt:
  • platform/qt/fast/html/details-open-javascript-expected.png:
  • platform/qt/fast/html/details-open-javascript-expected.txt:
  • platform/qt/fast/html/details-open2-expected.png:
  • platform/qt/fast/html/details-open2-expected.txt:
  • platform/qt/fast/html/details-open4-expected.png:
  • platform/qt/fast/html/details-open4-expected.txt:
  • platform/qt/fast/layers/add-layer-with-nested-stacking-expected.txt:
  • platform/qt/fast/layers/remove-layer-with-nested-stacking-expected.png:
  • platform/qt/fast/layers/remove-layer-with-nested-stacking-expected.txt:
  • platform/qt/fast/layers/self-painting-outline-expected.txt:
  • platform/qt/fast/lists/dynamic-marker-crash-expected.png: Added.
  • platform/qt/fast/lists/dynamic-marker-crash-expected.txt:
  • platform/qt/fast/multicol/layers-split-across-columns-expected.png:
  • platform/qt/fast/multicol/layers-split-across-columns-expected.txt:
  • platform/qt/fast/overflow/004-expected.png: Added.
  • platform/qt/fast/overflow/004-expected.txt:
  • platform/qt/fast/overflow/line-clamp-expected.png:
  • platform/qt/fast/overflow/line-clamp-expected.txt:
  • platform/qt/fast/overflow/overflow-focus-ring-expected.png: Added.
  • platform/qt/fast/overflow/overflow-focus-ring-expected.txt:
  • platform/qt/fast/repaint/iframe-scroll-repaint-expected.png:
  • platform/qt/fast/repaint/iframe-scroll-repaint-expected.txt:
  • platform/qt/fast/repaint/lines-with-layout-delta-expected.png:
  • platform/qt/fast/repaint/lines-with-layout-delta-expected.txt:
  • platform/qt/fast/repaint/opacity-change-on-overflow-float-expected.png:
  • platform/qt/fast/repaint/opacity-change-on-overflow-float-expected.txt:
  • platform/qt/fast/repaint/overflow-clip-subtree-layout-expected.txt:
  • platform/qt/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
  • platform/qt/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/qt/fast/repaint/repaint-resized-overflow-expected.png:
  • platform/qt/fast/repaint/repaint-resized-overflow-expected.txt:
  • platform/qt/fast/repaint/search-field-cancel-expected.png:
  • platform/qt/fast/repaint/search-field-cancel-expected.txt:
  • platform/qt/fast/repaint/subtree-layoutstate-transform-expected.png: Added.
  • platform/qt/fast/repaint/subtree-layoutstate-transform-expected.txt:
  • platform/qt/fast/repaint/subtree-root-clip-2-expected.txt:
  • platform/qt/fast/repaint/subtree-root-clip-3-expected.txt:
  • platform/qt/fast/repaint/subtree-root-clip-expected.txt:
  • platform/qt/fast/repaint/subtree-root-skipped-expected.png:
  • platform/qt/fast/repaint/subtree-root-skipped-expected.txt:
  • platform/qt/fast/repaint/table-hover-on-link-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png.
  • platform/qt/fast/repaint/table-hover-on-link-expected.txt: Added.
  • platform/qt/fast/replaced/replaced-breaking-expected.txt:
  • platform/qt/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/qt/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/qt/fast/replaced/width100percent-searchfield-expected.png:
  • platform/qt/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/qt/fast/replaced/width100percent-textfield-expected.png:
  • platform/qt/fast/replaced/width100percent-textfield-expected.txt:
  • platform/qt/fast/speech/input-appearance-searchandspeech-expected.png: Added.
  • platform/qt/fast/speech/input-appearance-searchandspeech-expected.txt: Added.
  • platform/qt/fast/speech/input-appearance-speechbutton-expected.png: Added.
  • platform/qt/fast/speech/input-appearance-speechbutton-expected.txt: Added.
  • platform/qt/fast/speech/speech-bidi-rendering-expected.png: Added.
  • platform/qt/fast/speech/speech-bidi-rendering-expected.txt: Added.
  • platform/qt/fast/table/029-expected.png:
  • platform/qt/fast/table/029-expected.txt:
  • platform/qt/fast/table/colspanMinWidth-expected.png:
  • platform/qt/fast/table/colspanMinWidth-expected.txt:
  • platform/qt/fast/table/colspanMinWidth-vertical-expected.png:
  • platform/qt/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/qt/fast/table/overflowHidden-expected.png:
  • platform/qt/fast/table/overflowHidden-expected.txt:
  • platform/qt/fast/table/spanOverlapRepaint-expected.png:
  • platform/qt/fast/table/spanOverlapRepaint-expected.txt:
  • platform/qt/fast/table/text-field-baseline-expected.png:
  • platform/qt/fast/table/text-field-baseline-expected.txt:
  • platform/qt/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/qt/fast/transforms/transformed-focused-text-input-expected.png:
  • platform/qt/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/qt/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/qt/plugins/mouse-click-plugin-clears-selection-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/iframe-scroll-repaint-expected.png.
  • platform/qt/plugins/mouse-click-plugin-clears-selection-expected.txt:
  • platform/qt/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/qt/svg/hixie/mixed/003-expected.png:
  • platform/qt/svg/hixie/mixed/003-expected.txt:
  • platform/qt/tables/mozilla/bugs/45621-expected.png:
  • platform/qt/tables/mozilla/bugs/45621-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug154780-expected.png:
  • platform/qt/tables/mozilla/bugs/bug154780-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug24200-expected.png:
  • platform/qt/tables/mozilla/bugs/bug24200-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug55545-expected.png:
  • platform/qt/tables/mozilla/bugs/bug55545-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/qt/tables/mozilla/dom/tableDom-expected.txt:
  • platform/qt/tables/mozilla/other/move_row-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug106966-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png: Added.
  • platform/qt/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug45621-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug45621-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
  • platform/qt/test_expectations.txt:
1:12 PM Changeset in webkit [115874] by rakuco@webkit.org
  • 2 edits in trunk/Tools

[watchlist] Update watchlist rules for EFL-related patches.
http://bugs.webkit.org/show_bug.cgi?id=85160

Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/config/watchlist: Monitor

Source/WTF/wtf/efl and LayoutTests/platform/efl as well.

1:06 PM Changeset in webkit [115873] by eric.carlson@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Mac media engine doesn't reccognize canPlayType('audio/wav; codecs=1')
https://bugs.webkit.org/show_bug.cgi?id=85409

Not reviewed, new platform results added after r115798.

  • platform/mac/media/media-can-play-wav-audio-expected.txt: Added.
1:05 PM Changeset in webkit [115872] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening after r115821.

  • platform/qt-5.0-wk2/fast/dom/Window/window-properties-expected.txt: Updated.
1:01 PM Changeset in webkit [115871] by fpizlo@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed, changing test expectations due to https://bugs.webkit.org/show_bug.cgi?id=85408

  • platform/mac/test_expectations.txt:
12:57 PM Changeset in webkit [115870] by kbr@google.com
  • 8 edits in trunk

Don't allocate stencil buffer if stencil flag is false in context creation attributes
https://bugs.webkit.org/show_bug.cgi?id=85317

Reviewed by Dimitri Glazkov.

Source/WebCore:

Make it appear to WebGL application that there is no stencil
buffer even if the underlying GraphicsContext3D allocated one.
Verified intended behavior with test case from Mozilla's bug report.

Updated context-attributes-alpha-depth-stencil-antialias.html test
from Khronos repository. Ran WebGL layout tests on Linux in
Chrome's DRT and on Mac OS in Safari's.

  • html/canvas/WebGLFramebuffer.cpp:

(WebCore::WebGLFramebuffer::hasStencilBuffer): Added query method.
(WebCore): Changed desired semantics of isValidRenderbuffer.

  • html/canvas/WebGLFramebuffer.h:

(WebGLFramebuffer): Added hasStencilBuffer.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::initializeNewContext):

Clear new flag.

(WebCore::WebGLRenderingContext::bindFramebuffer):

Reset stencil test upon framebuffer change.

(WebCore::WebGLRenderingContext::disable):

Cache flag; reset stencil test.

(WebCore::WebGLRenderingContext::enable):

Cache flag; reset stencil test.

(WebCore::WebGLRenderingContext::framebufferRenderbuffer):

Reset stencil test upon renderbuffer change.

(WebCore::WebGLRenderingContext::getContextAttributes):

Force depth and stencil to false if false was requested.

(WebCore::WebGLRenderingContext::isEnabled):

Return cached flag.

(WebCore::WebGLRenderingContext::renderbufferStorage):

Reset stencil test upon renderbuffer reallocation.

(WebCore::WebGLRenderingContext::applyStencilTest):

Enable or disable stencil test based on request and availability.

(WebCore::WebGLRenderingContext::enableOrDisable):

Helper function.

  • html/canvas/WebGLRenderingContext.h:

(WebGLRenderingContext):

Added cache of STENCIL_TEST flag. Deleted unused m_stencilBits.

LayoutTests:

  • fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-expected.txt:
  • fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html:
12:50 PM Changeset in webkit [115869] by rniwa@webkit.org
  • 2 edits
    2 adds in trunk

Drag and drop text into table is pasting the text in the next <td> element
https://bugs.webkit.org/show_bug.cgi?id=75004

Reviewed by Darin Adler.

The bug was caused by ReplaceSelectionCommand adjusting the insertion position to be before
of the block element containing the insertion position even when the block element is a table cell.

Fixed the bug by not moving the insertion position before the table cell in this case.

Test: editing/pasteboard/paste-into-table-cell.html

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::doApply):

12:47 PM Changeset in webkit [115868] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=85309
supportsExpandedScrollbars() should check for the method we actually call rather
than a related method

Reviewed by Anders Carlsson.

Missing colon.

  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::supportsExpandedScrollbars):

12:47 PM Changeset in webkit [115867] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix GCC X86 build error
https://bugs.webkit.org/show_bug.cgi?id=85379

Patch by Yong Li <yoli@rim.com> on 2012-05-02
Reviewed by Rob Buis.

Always explicitly claim ".text" to make sure
functions defined with inline assembly will be
created in the correct section.

  • dfg/DFGOperations.cpp:

(JSC):

12:46 PM Changeset in webkit [115866] by zandobersek@gmail.com
  • 131 edits in trunk/LayoutTests

Unreviewed, rebaselining after changes in r115846.

  • fast/repaint/table-hover-on-link-expected.txt:
  • platform/gtk/editing/inserting/before-after-input-element-expected.txt:
  • platform/gtk/editing/pasteboard/4806874-expected.txt:
  • platform/gtk/editing/pasteboard/input-field-1-expected.txt:
  • platform/gtk/editing/selection/3690703-2-expected.txt:
  • platform/gtk/editing/selection/3690703-expected.txt:
  • platform/gtk/editing/selection/3690719-expected.txt:
  • platform/gtk/editing/selection/4895428-3-expected.txt:
  • platform/gtk/editing/selection/4975120-expected.txt:
  • platform/gtk/editing/selection/drag-select-1-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/gtk/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/gtk/editing/spelling/inline_spelling_markers-expected.txt:
  • platform/gtk/fast/block/float/032-expected.txt:
  • platform/gtk/fast/block/float/033-expected.txt:
  • platform/gtk/fast/block/float/avoidance-rtl-expected.txt:
  • platform/gtk/fast/block/float/float-not-removed-from-next-sibling3-expected.txt:
  • platform/gtk/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt:
  • platform/gtk/fast/block/float/in-margin-expected.txt:
  • platform/gtk/fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt:
  • platform/gtk/fast/block/float/shrink-to-avoid-float-complexity-expected.txt:
  • platform/gtk/fast/block/lineboxcontain/parsing-invalid-expected.txt:
  • platform/gtk/fast/block/margin-collapse/103-expected.txt:
  • platform/gtk/fast/clip/008-expected.txt:
  • platform/gtk/fast/clip/011-expected.txt:
  • platform/gtk/fast/clip/012-expected.txt:
  • platform/gtk/fast/clip/017-expected.txt:
  • platform/gtk/fast/css/input-search-padding-expected.txt:
  • platform/gtk/fast/css/invalidation-errors-2-expected.txt:
  • platform/gtk/fast/css/invalidation-errors-expected.txt:
  • platform/gtk/fast/css/text-overflow-input-expected.txt:
  • platform/gtk/fast/dom/isindex-001-expected.txt:
  • platform/gtk/fast/dom/isindex-002-expected.txt:
  • platform/gtk/fast/dynamic/subtree-boundary-percent-height-expected.txt:
  • platform/gtk/fast/dynamic/subtree-no-common-root-static-y-expected.txt:
  • platform/gtk/fast/dynamic/subtree-table-cell-height-expected.txt:
  • platform/gtk/fast/events/autoscroll-expected.txt:
  • platform/gtk/fast/events/context-no-deselect-expected.txt:
  • platform/gtk/fast/forms/box-shadow-override-expected.txt:
  • platform/gtk/fast/forms/encoding-test-expected.txt:
  • platform/gtk/fast/forms/fieldset-align-expected.txt:
  • platform/gtk/fast/forms/input-appearance-bkcolor-expected.txt:
  • platform/gtk/fast/forms/input-appearance-focus-expected.txt:
  • platform/gtk/fast/forms/input-appearance-height-expected.txt:
  • platform/gtk/fast/forms/input-appearance-readonly-expected.txt:
  • platform/gtk/fast/forms/input-appearance-selection-expected.txt:
  • platform/gtk/fast/forms/input-appearance-width-expected.txt:
  • platform/gtk/fast/forms/input-baseline-expected.txt:
  • platform/gtk/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/gtk/fast/forms/input-field-text-truncated-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/gtk/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/gtk/fast/forms/input-readonly-empty-expected.txt:
  • platform/gtk/fast/forms/input-table-expected.txt:
  • platform/gtk/fast/forms/input-text-click-inside-expected.txt:
  • platform/gtk/fast/forms/input-text-click-outside-expected.txt:
  • platform/gtk/fast/forms/input-text-double-click-expected.txt:
  • platform/gtk/fast/forms/input-text-drag-down-expected.txt:
  • platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/gtk/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/gtk/fast/forms/input-width-expected.txt:
  • platform/gtk/fast/forms/placeholder-position-expected.txt:
  • platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/gtk/fast/forms/search-rtl-expected.txt:
  • platform/gtk/fast/forms/search-styled-expected.txt:
  • platform/gtk/fast/forms/searchfield-heights-expected.txt:
  • platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/gtk/fast/forms/textfield-focus-ring-expected.txt:
  • platform/gtk/fast/forms/textfield-overflow-expected.txt:
  • platform/gtk/fast/forms/validation-message-appearance-expected.txt:
  • platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/gtk/fast/html/details-no-summary4-expected.txt:
  • platform/gtk/fast/html/details-open-javascript-expected.txt:
  • platform/gtk/fast/html/details-open2-expected.txt:
  • platform/gtk/fast/html/details-open4-expected.txt:
  • platform/gtk/fast/invalid/residual-style-expected.txt:
  • platform/gtk/fast/layers/add-layer-with-nested-stacking-expected.txt:
  • platform/gtk/fast/layers/remove-layer-with-nested-stacking-expected.txt:
  • platform/gtk/fast/layers/self-painting-outline-expected.txt:
  • platform/gtk/fast/multicol/layers-split-across-columns-expected.txt:
  • platform/gtk/fast/overflow/004-expected.txt:
  • platform/gtk/fast/overflow/clip-rects-fixed-ancestor-expected.txt:
  • platform/gtk/fast/overflow/overflow-focus-ring-expected.txt:
  • platform/gtk/fast/repaint/inline-relative-positioned-expected.txt:
  • platform/gtk/fast/repaint/layer-outline-expected.txt:
  • platform/gtk/fast/repaint/layer-outline-horizontal-expected.txt:
  • platform/gtk/fast/repaint/opacity-change-on-overflow-float-expected.txt:
  • platform/gtk/fast/repaint/overflow-clip-subtree-layout-expected.txt:
  • platform/gtk/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/gtk/fast/repaint/repaint-resized-overflow-expected.txt:
  • platform/gtk/fast/repaint/subtree-layoutstate-transform-expected.txt:
  • platform/gtk/fast/repaint/subtree-root-clip-2-expected.txt:
  • platform/gtk/fast/repaint/subtree-root-clip-3-expected.txt:
  • platform/gtk/fast/repaint/subtree-root-clip-expected.txt:
  • platform/gtk/fast/repaint/subtree-root-skipped-expected.txt:
  • platform/gtk/fast/replaced/replaced-breaking-expected.txt:
  • platform/gtk/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/gtk/fast/table/003-expected.txt:
  • platform/gtk/fast/table/029-expected.txt:
  • platform/gtk/fast/table/colspanMinWidth-expected.txt:
  • platform/gtk/fast/table/overflowHidden-expected.txt:
  • platform/gtk/fast/table/text-field-baseline-expected.txt:
  • platform/gtk/fast/text/selection-painted-separately-expected.txt:
  • platform/gtk/fast/text/selection-rect-rounding-expected.txt:
  • platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/gtk/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/gtk/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/gtk/plugins/mouse-click-plugin-clears-selection-expected.txt:
  • platform/gtk/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/gtk/tables/mozilla/bugs/45621-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug12384-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug24200-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug44505-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug55545-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug99948-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug45621-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
12:41 PM Changeset in webkit [115865] by fpizlo@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed, changing test expectations due to https://bugs.webkit.org/show_bug.cgi?id=85404

  • platform/mac/test_expectations.txt:
12:37 PM Changeset in webkit [115864] by Nate Chapin
  • 4 edits
    3 adds in trunk/LayoutTests

2012-05-02 Nate Chapin <Nate Chapin>

Unreviewed, expectations updates after r115774.

  • platform/chromium-win/http/tests/loading/pdf-commit-load-callbacks-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/http/tests/loading/pdf-commit-load-callbacks-expected.txt: Added.
  • platform/gtk/test_expectations.txt:
  • platform/qt/Skipped:
  • platform/qt/http/tests/loading/pdf-commit-load-callbacks-expected.txt: Added.
12:28 PM Changeset in webkit [115863] by fpizlo@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed, changing test expectations due to https://bugs.webkit.org/show_bug.cgi?id=85401

  • platform/mac/test_expectations.txt:
12:19 PM Changeset in webkit [115862] by vestbo@webkit.org
  • 14 edits
    2 deletes in trunk

Revert r115191 - "Make the web view's url property follow the active url"

It uncovered/caused issues in the icon-implementation that can't be
easily fixed, so rolling out instead.

https://bugs.webkit.org/show_bug.cgi?id=77554

Rubber-stamped by Simon Hausmann.

12:18 PM Changeset in webkit [115861] by oliver@apple.com
  • 16 edits in trunk

Unreviewed, rolling out r115388.
http://trac.webkit.org/changeset/115388
https://bugs.webkit.org/show_bug.cgi?id=85011

This caused many weird performance problems, and needs to be
landed in pieces.

Source/JavaScriptCore:

  • dfg/DFGOperations.cpp:
  • heap/Heap.cpp:

(JSC::Heap::getConservativeRegisterRoots):
(JSC::Heap::markRoots):

  • interpreter/CallFrame.cpp:

(JSC::CallFrame::dumpCaller):
(JSC):

  • interpreter/CallFrame.h:

(JSC::ExecState::init):
(ExecState):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::privateExecute):

  • interpreter/Interpreter.h:

(JSC::Interpreter::execute):

  • interpreter/RegisterFile.cpp:

(JSC::RegisterFile::growSlowCase):
(JSC::RegisterFile::gatherConservativeRoots):

  • interpreter/RegisterFile.h:

(JSC::RegisterFile::end):
(JSC::RegisterFile::size):
(JSC::RegisterFile::addressOfEnd):
(RegisterFile):
(JSC::RegisterFile::RegisterFile):
(JSC::RegisterFile::shrink):
(JSC::RegisterFile::grow):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):
(JSC::jitCompileFor):
(JSC::lazyLinkFor):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::handleHostCall):

  • llint/LowLevelInterpreter.asm:
  • runtime/CommonSlowPaths.h:

(JSC::CommonSlowPaths::arityCheckFor):

LayoutTests:

  • fast/js/global-recursion-on-full-stack-expected.txt:
  • fast/js/stack-trace-expected.txt:
12:05 PM Changeset in webkit [115860] by Antti Koivisto
  • 10 edits in trunk/Source/WebCore

Move title and media queries from StyleSheetInternal to CSSStyleSheet
https://bugs.webkit.org/show_bug.cgi?id=85387

Reviewed by Anders Carlsson.

Stylesheet title and media queries are determined by the owner, not by the stylesheet itself.
The fields belong to CSSStyleSheet.

This will make it easier to share StyleSheetInternal instances between documents.

  • css/CSSStyleSheet.cpp:

(WebCore::StyleSheetInternal::StyleSheetInternal):
(WebCore::StyleSheetInternal::isCacheable):
(WebCore):
(WebCore::CSSStyleSheet::setDisabled):

Invalidate the document style directly instead of ping-ponging through StyleSheetInternal.

(WebCore::CSSStyleSheet::setMediaQueries):
(WebCore::CSSStyleSheet::media):

  • css/CSSStyleSheet.h:

(StyleSheetInternal):
(WebCore::StyleSheetInternal::originalURL):
(WebCore::StyleSheetInternal::hasCharsetRule):
(WebCore::CSSStyleSheet::mediaQueries):
(CSSStyleSheet):
(WebCore::CSSStyleSheet::setTitle):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::appendAuthorStylesheets):
(WebCore::StyleResolver::collectMatchingRulesForList):

  • dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createCSSStyleSheet):

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::setCSSStyleSheet):

  • dom/StyleElement.cpp:

(WebCore::StyleElement::createSheet):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::parseAttribute):
(WebCore::HTMLLinkElement::setCSSStyleSheet):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::parseAttribute):

  • svg/SVGStyleElement.cpp:

(WebCore::SVGStyleElement::parseAttribute):

12:01 PM Changeset in webkit [115859] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

When viewing a PDF, the Safari Status Bar shows other text
https://bugs.webkit.org/show_bug.cgi?id=85395
<rdar://problem/11297250>

Reviewed by Beth Dakin.

Set the layer contents placement for the WKView so that its layer will get masksToBounds set.

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:contextRef:pageGroupRef:]):

11:53 AM Changeset in webkit [115858] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed, removing recent test expectations for changes in r115846
to get proper new baselines from the buildbots.

  • platform/gtk/test_expectations.txt:
11:52 AM Changeset in webkit [115857] by alexis.menard@openbossa.org
  • 4 edits in trunk/Source/WebCore

Unreviewed Qt build fix with GCC 4.7.0.

  • platform/qt/DeviceMotionProviderQt.h:

(DeviceMotionProviderQt):

  • platform/qt/DeviceOrientationProviderQt.cpp:

(WebCore::DeviceOrientationProviderQt::~DeviceOrientationProviderQt):
(WebCore):

  • platform/qt/DeviceOrientationProviderQt.h:

(DeviceOrientationProviderQt):

11:50 AM Changeset in webkit [115856] by jchaffraix@webkit.org
  • 5 edits
    4 adds
    2 deletes in trunk/LayoutTests

Unreviewed Chromium gardening.

  • platform/chromium-mac-leopard/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/speech/input-appearance-searchandspeech-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
  • platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/chromium-mac/editing/spelling/inline_spelling_markers-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/form-element-geometry-expected.txt:
  • platform/chromium-mac/fast/forms/input-value-expected.txt:
  • platform/chromium-mac/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
  • platform/chromium-mac/fast/layers/remove-layer-with-nested-stacking-expected.txt: Removed.

Rebaselined the previous tests.

  • platform/chromium/test_expectations.txt:

Tweaked the expectation files to cover the failures on Mac.

11:26 AM Changeset in webkit [115855] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebCore

[Texmap] Enable css filters in TextureMapperGL
https://bugs.webkit.org/show_bug.cgi?id=75778

Unreviewed build fix to greenify the Qt Minimal bot.

  • platform/graphics/texmap/TextureMapperShaderManager.h:
11:22 AM Changeset in webkit [115854] by jchaffraix@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed expectation updates after r115846.

  • platform/gtk/test_expectations.txt:
  • platform/qt/test_expectations.txt:

Added more files after triaging the diffs.

11:01 AM Changeset in webkit [115853] by zandobersek@gmail.com
  • 5 edits in trunk/Tools

Reftest mismatches are providing undefined diff percent in results.html
https://bugs.webkit.org/show_bug.cgi?id=85283

Reviewed by Ojan Vafai.

When writing test results for a reftest mismatch, also take into account the
difference percent that is produced when generating image diff. This value is
then used when creating test results in the form of dictionaries, stored under
the 'image_diff_percent' key. It ultimately ends up in JSON results data,
providing additional information about the reftest difference.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(interpret_test_failures): Store the diff percent for reftest failure under the
'image_diff_percent' key.

  • Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(write_test_result): Also set the new diff_percent attribute of the reftest
mismatch failure to the value of the difference percent ImageDiff outputs.

  • Scripts/webkitpy/layout_tests/models/test_failures.py:

(FailureReftestMismatch.init): Add the new diff_percent attribute with the
default value of None.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(EndToEndTest.test_reftest_with_two_notrefs): Update the test case expected results.

10:57 AM Changeset in webkit [115852] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

[GTK] Compilation warnings in RenderTheme
https://bugs.webkit.org/show_bug.cgi?id=85286

Reviewed by Martin Robinson.

Removed un-needed code and refactored fileListNameForWidth
accordingly to avoid un-used variable warnings during compilation.

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore):
(WebCore::RenderThemeGtk::fileListNameForWidth):

10:50 AM Changeset in webkit [115851] by eae@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/page/EventHandler.cpp

Whitespace cleanup on branch.

10:49 AM Changeset in webkit [115850] by eae@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebKit2/WebProcess/WebPage/WebPage.cpp

qt wk2 build fix on branch.

10:48 AM Changeset in webkit [115849] by leviw@chromium.org
  • 6 edits in branches/subpixellayout

Adding skips for overflowing test cases in all platform test_expectations.txt files, and adding parenthesis for FractionalLayoutUnit's overflow message.

10:45 AM Changeset in webkit [115848] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

NULL ptr in WebCore::AppendNodeCommand::AppendNodeCommand
https://bugs.webkit.org/show_bug.cgi?id=75843

Reviewed by Tony Chang.

Source/WebCore:

The crash was caused by indentIntoBlockquote's passing a bad outerBlock to moveParagraphsWithClone.

When the position is created after blockquote in the following DOM:
BODY

  • BLOCKQUOTE style=margin: 0 0 0 40px; border: none; padding: 0px;

E

#text "\nx\n"

VisiblePosition's constructor (of startOfContents) turns the position into a legacy position (blockquote, 0).
The crash occurs because this position doesn't belong in the same paragraph as E, which is the paragraph
we're trying to move into the blockquote.

Fixed bug by calling positionInParentAfterNode instead of positionAfterNode for now. We should eventually be
able to use positionAfterNode here once VisiblePosition's constructor starts handling before/after positions
properly.

Test: editing/execCommand/indent-with-after-content-crash.html

  • editing/IndentOutdentCommand.cpp:

(WebCore::IndentOutdentCommand::indentIntoBlockquote):

LayoutTests:

Add a regression test.

  • editing/execCommand/indent-with-after-content-crash-expected.txt: Added.
  • editing/execCommand/indent-with-after-content-crash.html: Added.
10:42 AM Changeset in webkit [115847] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

WebWindowFadeAnimation ignores "duration" parameter. https://bugs.webkit.org/show_bug.cgi?id=85386

Reviewed by Brady Eidson.

Ignoring the "duration" parameter causes the full screen fade and scale animations
to get out of sync.

  • platform/mac/WebWindowAnimation.mm:

(-[WebWindowFadeAnimation initWithDuration:window:initialAlpha:finalAlpha:]):

10:17 AM Changeset in webkit [115846] by jchaffraix@webkit.org
  • 20 edits
    6 adds in trunk

REGRESSION(110072): Clipping is not applied on layers that are animated using platform code
https://bugs.webkit.org/show_bug.cgi?id=83954

Reviewed by Simon Fraser.

Source/WebCore:

Tests: fast/layers/no-clipping-overflow-hidden-added-after-transform-expected.html

fast/layers/no-clipping-overflow-hidden-added-after-transform.html
fast/layers/no-clipping-overflow-hidden-added-after-transition-expected.html
fast/layers/no-clipping-overflow-hidden-added-after-transition.html
fast/layers/no-clipping-overflow-hidden-hardware-acceleration-expected.html
fast/layers/no-clipping-overflow-hidden-hardware-acceleration.html
(and all the tests that will need to be rebaselined)

r110072 changed the way we create layers to lazily allocate overflow: hidden ones
based on layout overflow. However with hardware acceleration, certain operations
do cause overflow without actually calling layout (the test cases added as part
of this change are using transition / animation). This means that those cases
wouldn't properly clip.

Due to the above issue and the other regressions from r110072, the easiest fix is
to just to roll it out.

  • rendering/RenderBox.h:

Changed to allocate a layer whenever we have an overflow clip.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::scrolledContentOffset):
(WebCore::RenderBox::cachedSizeForOverflowClip):
Reverted those 2 to avoid using the cached size logic.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateScrollInfoAfterLayout):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::paint):
(WebCore::RenderBlock::isPointInOverflowControl):

  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::willBeDestroyed):
(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::layout):
(WebCore::RenderBox::scrollWidth):
(WebCore::RenderBox::scrollHeight):
(WebCore::RenderBox::scrollLeft):
(WebCore::RenderBox::scrollTop):
(WebCore::RenderBox::setScrollLeft):
(WebCore::RenderBox::setScrollTop):
(WebCore::RenderBox::includeVerticalScrollbarSize):
(WebCore::RenderBox::includeHorizontalScrollbarSize):
(WebCore::RenderBox::pushContentsClip):
(WebCore::RenderBox::popContentsClip):
(WebCore::RenderBox::addLayoutOverflow):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::styleDidChange):

  • rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):

  • rendering/RenderTableRow.h:

(RenderTableRow):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layout):
Removed the previous scaffolding code and reverted some functions to
being private (as they were prior to r110072).

LayoutTests:

  • fast/layers/no-clipping-overflow-hidden-added-after-transform-expected.html: Added.
  • fast/layers/no-clipping-overflow-hidden-added-after-transform.html: Added.
  • fast/layers/no-clipping-overflow-hidden-added-after-transition-expected.html: Added.
  • fast/layers/no-clipping-overflow-hidden-added-after-transition.html: Added.
  • fast/layers/no-clipping-overflow-hidden-hardware-acceleration-expected.html: Added.
  • fast/layers/no-clipping-overflow-hidden-hardware-acceleration.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/qt/test_expectations.txt:

Disabled some tests for those platforms.

  • platform/efl/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • platform/qt/Skipped:
  • platform/win/Skipped:

Re-enabled those tests on the premises that r11072 / bug 75568 got rolled out.

10:13 AM Changeset in webkit [115845] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Addition of a contributor to committers.py
https://bugs.webkit.org/show_bug.cgi?id=85324

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-05-02
Reviewed by Unreviewed.

  • Scripts/webkitpy/common/config/committers.py:
10:03 AM Changeset in webkit [115844] by mahesh.kulkarni@nokia.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed. Build fix for Qt port on mac.

  • UIProcess/API/qt/qwebnavigationhistory_p.h:
9:52 AM Changeset in webkit [115843] by commit-queue@webkit.org
  • 5 edits in trunk

[EFL] EFL's LayoutTestController overridePreference implementation
https://bugs.webkit.org/show_bug.cgi?id=83007

Tools:

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-02
Reviewed by Antonio Gomes.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(toBool): aux function converting JSStringRef to bool
(toInt): aux function converting JSStringRef to int
(LayoutTestController::overridePreference): added implementation

LayoutTests:

Unskip tescases depending on LayoutTestController overridePreference method.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-02
Reviewed by Antonio Gomes.

  • platform/efl/Skipped:
9:38 AM Changeset in webkit [115842] by eae@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/page/EventHandler.cpp

Use getPixelSnappedRect in EventHandler::handleGestureTap on branch.

9:15 AM Changeset in webkit [115841] by vestbo@webkit.org
  • 2 edits in trunk/Source/WebKit2

Make ShareableSurface's ref-counting thread-safe

Fixes assert when threaded rendering is enabled for the Qt scene-graph.

https://bugs.webkit.org/show_bug.cgi?id=85381

Reviewed by Noam Rosenthal.

8:49 AM Changeset in webkit [115840] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Refining expectations for passing tests.

  • platform/chromium/test_expectations.txt:
8:32 AM Changeset in webkit [115839] by rakuco@webkit.org
  • 5 edits in trunk/LayoutTests

Unreviewed, EFL rebaseline after r115415 and r115294.

  • platform/efl/fast/images/support-broken-image-delegate-expected.txt:
  • platform/efl/http/tests/loading/simple-subframe-expected.txt:
  • platform/efl/security/block-test-expected.txt:
  • platform/efl/security/block-test-no-port-expected.txt:
8:30 AM Changeset in webkit [115838] by noam.rosenthal@nokia.com
  • 22 edits in trunk/Source

[Texmap] Enable css filters in TextureMapperGL
https://bugs.webkit.org/show_bug.cgi?id=75778

Source/WebCore:

Reviewed by Jocelyn Turcotte.

Added support for color filters in TextureMapperGL. Blur and shadow would be done in a
different patch.

Modified BitmapTexture::applyFilters to return a texture, since GL cannot paint a texture
into itself.
Created a shader map for standard filters, since all of them work more or less the same way
with a single uniform. Added the colorization shaders based on the W3C filter spec, as
already implemented in FEFilterRenderer.cpp and FEColorMatrix.cpp.
We use two swapping textures to render the filters.

Covered by tests in css3/filters.

  • platform/graphics/texmap/TextureMapper.cpp:

(WebCore::TextureMapper::acquireTextureFromPool):

  • platform/graphics/texmap/TextureMapper.h:

(WebCore::BitmapTexture::applyFilters):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::updateContents):
(WebCore):
(WebCore::TextureMapperGL::drawFiltered):
(WebCore::BitmapTextureGL::applyFilters):
(WebCore::BitmapTextureGL::bind):

  • platform/graphics/texmap/TextureMapperGL.h:

(TextureMapperGL):
(BitmapTextureGL):

  • platform/graphics/texmap/TextureMapperImageBuffer.cpp:

(WebCore::BitmapTextureImageBuffer::applyFilters):

  • platform/graphics/texmap/TextureMapperImageBuffer.h:

(BitmapTextureImageBuffer):

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::applyFilters):
(WebCore::TextureMapperLayer::syncCompositingStateSelf):

  • platform/graphics/texmap/TextureMapperShaderManager.cpp:

(WebCore::TextureMapperShaderManager::~TextureMapperShaderManager):
(WebCore):
(WebCore::StandardFilterProgram::~StandardFilterProgram):
(WebCore::StandardFilterProgram::StandardFilterProgram):
(WebCore::StandardFilterProgram::create):
(WebCore::StandardFilterProgram::prepare):
(WebCore::TextureMapperShaderManager::getShaderForFilter):

  • platform/graphics/texmap/TextureMapperShaderManager.h:

(WebCore):
(StandardFilterProgram):
(WebCore::StandardFilterProgram::vertexAttrib):
(WebCore::StandardFilterProgram::texCoordAttrib):
(WebCore::StandardFilterProgram::textureUniform):
(TextureMapperShaderManager):

Source/WebKit2:

Add the plumbing in the ui-side compositing code in Qt to support filters.
Serialize the filter operations for a layer when it's changed.

Reviewed by Jocelyn Turcotte.

  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC):
(CoreIPC::::encode):
(CoreIPC::::decode):

  • Shared/WebCoreArgumentCoders.h:

(WebCore):

  • UIProcess/LayerTreeHostProxy.cpp:

(WebKit):
(WebKit::LayerTreeHostProxy::setCompositingLayerFilters):

  • UIProcess/LayerTreeHostProxy.h:

(LayerTreeHostProxy):

  • UIProcess/LayerTreeHostProxy.messages.in:
  • UIProcess/WebLayerTreeRenderer.cpp:

(WebKit):
(WebKit::WebLayerTreeRenderer::setLayerFilters):

  • UIProcess/WebLayerTreeRenderer.h:

(WebLayerTreeRenderer):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore):
(WebCore::WebGraphicsLayer::didChangeFilters):
(WebCore::WebGraphicsLayer::setFilters):
(WebCore::WebGraphicsLayer::syncFilters):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:

(WebGraphicsLayerClient):
(WebGraphicsLayer):

  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit):
(WebKit::LayerTreeHostQt::syncLayerFilters):

  • WebProcess/WebPage/qt/LayerTreeHostQt.h:

(LayerTreeHostQt):

8:29 AM Changeset in webkit [115837] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r115825.

  • platform/gtk/fast/lists/drag-into-marker-expected.txt:
8:20 AM Changeset in webkit [115836] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, EFL rebaseline after r113885.

  • platform/efl/css2.1/20110323/replaced-elements-001-expected.txt:
8:17 AM Changeset in webkit [115835] by Philippe Normand
  • 4 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r115829.

  • platform/gtk/fast/hidpi/video-controls-in-hidpi-expected.txt:
  • platform/gtk/fast/layers/video-layer-expected.txt:
  • platform/gtk/test_expectations.txt:
8:17 AM Changeset in webkit [115834] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Hyperlink auditing ewk_view setting
https://bugs.webkit.org/show_bug.cgi?id=84451

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-02
Reviewed by Antonio Gomes.

Exporting new ewk_view setting: hyperlinkAuditingEnabled - enbles/disables hyperlink auditing.

  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(ewk_view_setting_enable_hyperlink_auditing_get):
(ewk_view_setting_enable_hyperlink_auditing_set):

  • ewk/ewk_view.h:
8:13 AM Changeset in webkit [115833] by rakuco@webkit.org
  • 2 edits in trunk/Tools

webkitpy: Fix sys.platform check in find_files_unittest.
https://bugs.webkit.org/show_bug.cgi?id=85339

Reviewed by Ryosuke Niwa.

Follow-up to r101618 -- 'win' is not a valid sys.platform value,
'win32' should be used instead. The check always returned false
due to this, so assert_normalize() was never called.

  • Scripts/webkitpy/common/find_files_unittest.py:

(TestWinNormalize.test_win): Add the missing import for the
FileSystem class and fix the sys.platform check.

8:08 AM Changeset in webkit [115832] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Pass page-height to PrintContext::begin to fix print layouting
https://bugs.webkit.org/show_bug.cgi?id=84864

Patch by Milian Wolff <milian.wolff@kdab.com> on 2012-05-02
Reviewed by Simon Hausmann.

  • Api/qwebframe.cpp:

(QWebFrame::print):

7:55 AM Changeset in webkit [115831] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit2

[Qt] Fix vkb showing incorrect flags/keys when content changes

Reviewed by Tor Arne Vestbø.

When the editor state changes we have to inform the input method about changed
properties so that it can issue a new input method query. Otherwise it may use old values
from other QQuickItems or other incorrectly initialized data.

Also use isActiveFocus() instead of hasFocus() to detect whether we're actively focused.
This is also what QQuick uses internally to determine whether it can make calls to the input method
or not.

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(WebKit::QtWebPageEventHandler::inputPanelVisibleChanged):
(WebKit::QtWebPageEventHandler::updateTextInputState):
(WebKit::QtWebPageEventHandler::doneWithGestureEvent):

7:37 AM Changeset in webkit [115830] by kenneth@webkit.org
  • 5 edits in trunk/Source

[Qt] Add initial QML documentation
https://bugs.webkit.org/show_bug.cgi?id=85370

Reviewed by Simon Hausmann.

Source/WebKit/qt:

  • docs/qtwebkit.qdocconf: Add WebKit2 dirs.

Source/WebKit2:

Add initial documentation which also serves as an example on how it
should be done.

  • UIProcess/API/qt/qquickwebview.cpp:
  • UIProcess/API/qt/qwebloadrequest.cpp:
7:19 AM Changeset in webkit [115829] by Philippe Normand
  • 18 edits in trunk

[GTK] media/track/track-cue-rendering-snap-to-lines-not-set.html fails
https://bugs.webkit.org/show_bug.cgi?id=84378

Reviewed by Eric Carlson.

Source/WebCore:

Fix positioning of the controls panel back to relative, as it is
in the parent CSS. Also remove some duplicate CSS attributes.

  • css/mediaControlsGtk.css:

(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):

LayoutTests:

  • platform/gtk/media/audio-controls-rendering-expected.txt:
  • platform/gtk/media/audio-repaint-expected.txt:
  • platform/gtk/media/controls-after-reload-expected.txt:
  • platform/gtk/media/controls-strict-expected.txt:
  • platform/gtk/media/controls-styling-expected.txt:
  • platform/gtk/media/controls-without-preload-expected.txt:
  • platform/gtk/media/media-controls-clone-expected.txt:
  • platform/gtk/media/media-document-audio-repaint-expected.txt:
  • platform/gtk/media/video-controls-rendering-expected.txt:
  • platform/gtk/media/video-display-toggle-expected.txt:
  • platform/gtk/media/video-empty-source-expected.txt:
  • platform/gtk/media/video-no-audio-expected.txt:
  • platform/gtk/media/video-playing-and-pause-expected.txt:
  • platform/gtk/media/video-volume-slider-expected.txt:
  • platform/gtk/media/video-zoom-controls-expected.txt:
  • platform/gtk/test_expectations.txt: Unflag fixed test.
7:18 AM Changeset in webkit [115828] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Buildfix after r115812 for !ENABLE(DEVICE_ORIENTATION) builds.
https://bugs.webkit.org/show_bug.cgi?id=64595

Reviewed by Kenneth Rohde Christiansen.

  • Api/qwebpage.cpp:
7:10 AM Changeset in webkit [115827] by yurys@chromium.org
  • 5 edits in trunk/Source/WebKit/chromium

Web Inspector: TypeError: Cannot call method 'createLiveLocation' of undefined
https://bugs.webkit.org/show_bug.cgi?id=85371

Standard extension scripts injected to the Chromium background page should have
correct script data which means that context debug id should be already set on
the context where they are compiled before the compilation. This patch moves
assignment of context debug id earlier where it is known that no scripts have
been evaluated in the context.

Reviewed by Pavel Feldman.

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchDidClearWindowObjectInWorld):
(WebKit::FrameLoaderClientImpl::didCreateScriptContext):

  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::didCreateScriptContext):

  • src/WebDevToolsAgentImpl.h:

(WebDevToolsAgentImpl):

  • src/WebDevToolsAgentPrivate.h:

(WebDevToolsAgentPrivate):

7:09 AM Changeset in webkit [115826] by Simon Hausmann
  • 2 edits in trunk

[Qt] Unreviewed prospective QtMobility build fix.

  • Source/api.pri: The Qt 4 equivalent of QT += sensors should be handled by

WebCore.pri, but somehow it isn't.

7:08 AM Changeset in webkit [115825] by zandobersek@gmail.com
  • 4 edits in trunk

[GTK] drag&drop related failures
https://bugs.webkit.org/show_bug.cgi?id=84675

Reviewed by Philippe Normand.

Tools:

Rather than checking options to see whether we're running pixel tests
the pixel_tests argument passed to GtkDriver._start should be used as
it also covers cases when pixel tests should be run because of testing
reftests. This again creates different Xvfb processes with proper
display IDs for a worker that's performing both ordinary and pixel
tests, as was the case before changes made in r114788.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkDriver._start):

LayoutTests:

Remove test cases from expectations that are now passing.

  • platform/gtk/test_expectations.txt:
7:01 AM Changeset in webkit [115824] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Removed entries for 4 media tests that pass now.

  • platform/chromium/test_expectations.txt:
6:41 AM Changeset in webkit [115823] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=85309
supportsExpandedScrollbars() should check for the method we actually call rather
than a related method
-and corresponding-
<rdar://problem/11065691>

Reviewed by Anders Carlsson.

  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::supportsExpandedScrollbars):

6:37 AM Changeset in webkit [115822] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update.

  • platform/gtk/test_expectations.txt:

http/tests/loading/pdf-commit-load-callbacks.html is failing.

6:19 AM Changeset in webkit [115821] by Simon Hausmann
  • 2 edits in trunk/Tools

[Qt] Enable device orientation/motion with Qt 5

Reviewed by Tor Arne Vestbø.

Enable device orientation/motion features with Qt 5 if Qt Sensors is available.

  • qmake/mkspecs/features/features.prf:
6:17 AM Changeset in webkit [115820] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL][DRT] Gardening failure cases on EFL port
https://bugs.webkit.org/show_bug.cgi?id=85365

Unreviewed EFL gardening.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-02

  • platform/efl/Skipped:
  • platform/efl/test_expectations.txt:
6:00 AM Changeset in webkit [115819] by commit-queue@webkit.org
  • 6 edits in trunk/Source

Source/WebCore: [Qt] Remove redundant updateViewportArguments() call from HTMLBodyElement::didNotifyDescendantInseretions()
https://bugs.webkit.org/show_bug.cgi?id=84241

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-05-02
Reviewed by Kenneth Rohde Christiansen.

No need to update viewport arguments when the body element is inserted into the Document.
Viewport arguments are updated first when the Document is set on the Frame, and later
on any subsequent occurence of the viewport meta tag in the document.
It is sufficient to dispatch viewport update once per main frame, if no viewport meta tag is present.

Also add a flag to be able to track viewport argument update dispatch.

No tests. Currrent viewport tests cover this behaviour.

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::updateViewportArguments):
(WebCore::Document::documentWillSuspendForPageCache):

  • dom/Document.h:

(Document):
(WebCore::Document::didDispatchViewportPropertiesChanged):

  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::didNotifyDescendantInseretions):

Source/WebKit2: [Qt][WK2] Remove redundant updateViewportArguments() call from HTMLBodyElement::didNotifyDescendantInseretions()
https://bugs.webkit.org/show_bug.cgi?id=84241

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-05-02
Reviewed by Kenneth Rohde Christiansen.

Add ASSERT to ensure at least one viewport argument change call is dispatched to WebPage per main frame.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidFirstLayout):

5:13 AM Changeset in webkit [115818] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][Mac] Skip new failing tests and one crashing test to paint the bot green.

  • platform/qt-mac/Skipped:
5:07 AM Changeset in webkit [115817] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Cannot read property 'length' of undefined TextEditorModel.js:467
https://bugs.webkit.org/show_bug.cgi?id=85360

Reviewed by Yury Semikhatsky.

Added the undo/redo stack length checks.

  • inspector/front-end/TextEditorModel.js:

(WebInspector.TextEditorModel.endsWithBracketRegex.):

5:04 AM Changeset in webkit [115816] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skipping failing test

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-05-02

  • platform/qt/Skipped:
5:03 AM Changeset in webkit [115815] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

WebInspector: Scripts panel editor dirty state is cleared when the tab with editor is closed.
https://bugs.webkit.org/show_bug.cgi?id=85361

Reviewed by Yury Semikhatsky.

Added content validation upon script show.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.wasShown):

5:01 AM Changeset in webkit [115814] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: breakpoints are de-activated only upon the second click.
https://bugs.webkit.org/show_bug.cgi?id=85359

Reviewed by Yury Semikhatsky.

Initial value for activated state is set.

  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel):

4:56 AM Changeset in webkit [115813] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: live edit fails to report error
https://bugs.webkit.org/show_bug.cgi?id=85357

Reviewed by Yury Semikhatsky.

ProtocolError is now a string, not an error object.

  • inspector/front-end/DatabaseQueryView.js:

(WebInspector.DatabaseQueryView.prototype._queryError):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.didEditContent):

4:51 AM Changeset in webkit [115812] by commit-queue@webkit.org
  • 7 edits
    8 moves in trunk

[Qt] Make DeviceMotion and DeviceOrientation work with WebKit2
https://bugs.webkit.org/show_bug.cgi?id=64595

Patch by Lars Knudsen <lars.knudsen@nokia.com> on 2012-05-02
Reviewed by Kenneth Rohde Christiansen.

.:

Moving DeviceMotion and DeviceOrientation clients and providers
to WebCore. This is done to allow clean dependencies when
statically linking WK2.

  • Source/api.pri:

Source/WebCore:

No new tests added. This change adds support for WK2
what was in WK1.

Also moving DeviceMotion and DeviceOrientation clients and
providers to WebCore. This is done to allow clean dependencies
when statically linking WK2.

  • Target.pri:
  • WebCore.pri:
  • platform/qt/DeviceMotionClientQt.cpp: Renamed from Source/WebKit/qt/WebCoreSupport/DeviceMotionClientQt.cpp.

(WebCore):
(WebCore::DeviceMotionClientQt::~DeviceMotionClientQt):
(WebCore::DeviceMotionClientQt::deviceMotionControllerDestroyed):
(WebCore::DeviceMotionClientQt::setController):
(WebCore::DeviceMotionClientQt::startUpdating):
(WebCore::DeviceMotionClientQt::stopUpdating):
(WebCore::DeviceMotionClientQt::currentDeviceMotion):

  • platform/qt/DeviceMotionClientQt.h: Renamed from Source/WebKit/qt/WebCoreSupport/DeviceMotionClientQt.h.

(WebCore):
(DeviceMotionClientQt):
(WebCore::DeviceMotionClientQt::DeviceMotionClientQt):

  • platform/qt/DeviceMotionProviderQt.cpp: Renamed from Source/WebKit/qt/WebCoreSupport/DeviceMotionProviderQt.cpp.

(WebCore):
(WebCore::DeviceMotionProviderQt::DeviceMotionProviderQt):
(WebCore::DeviceMotionProviderQt::~DeviceMotionProviderQt):
(WebCore::DeviceMotionProviderQt::setController):
(WebCore::DeviceMotionProviderQt::start):
(WebCore::DeviceMotionProviderQt::stop):
(WebCore::DeviceMotionProviderQt::filter):

  • platform/qt/DeviceMotionProviderQt.h: Renamed from Source/WebKit/qt/WebCoreSupport/DeviceMotionProviderQt.h.

(WebCore):
(DeviceMotionProviderQt):
(WebCore::DeviceMotionProviderQt::currentDeviceMotion):

  • platform/qt/DeviceOrientationClientQt.cpp: Renamed from Source/WebKit/qt/WebCoreSupport/DeviceOrientationClientQt.cpp.

(WebCore):
(WebCore::DeviceOrientationClientQt::deviceOrientationControllerDestroyed):
(WebCore::DeviceOrientationClientQt::setController):
(WebCore::DeviceOrientationClientQt::startUpdating):
(WebCore::DeviceOrientationClientQt::stopUpdating):
(WebCore::DeviceOrientationClientQt::lastOrientation):

  • platform/qt/DeviceOrientationClientQt.h: Renamed from Source/WebKit/qt/WebCoreSupport/DeviceOrientationClientQt.h.

(WebCore):
(DeviceOrientationClientQt):

  • platform/qt/DeviceOrientationProviderQt.cpp: Renamed from Source/WebKit/qt/WebCoreSupport/DeviceOrientationProviderQt.cpp.

(WebCore):
(WebCore::DeviceOrientationProviderQt::DeviceOrientationProviderQt):
(WebCore::DeviceOrientationProviderQt::~DeviceOrientationProviderQt):
(WebCore::DeviceOrientationProviderQt::setController):
(WebCore::DeviceOrientationProviderQt::start):
(WebCore::DeviceOrientationProviderQt::stop):
(WebCore::DeviceOrientationProviderQt::filter):

  • platform/qt/DeviceOrientationProviderQt.h: Renamed from Source/WebKit/qt/WebCoreSupport/DeviceOrientationProviderQt.h.

(WebCore):
(DeviceOrientationProviderQt):
(WebCore::DeviceOrientationProviderQt::isActive):
(WebCore::DeviceOrientationProviderQt::lastOrientation):
(WebCore::DeviceOrientationProviderQt::hasAlpha):

Source/WebKit2:

Adding support for DeviceOrientation in WK2 WebPage

  • Target.pri:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

3:43 AM Changeset in webkit [115811] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: exception in console when there are watch expressions
https://bugs.webkit.org/show_bug.cgi?id=85351

Check if script execution is still paused before trying to resolve an
object for script popover because execution may be resumed after popover
showing is scheduled but before we start resolving the object under
the cursor in which case there is no selected call frame any more and
we should hide the popover.

Reviewed by Pavel Feldman.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype._resolveObjectForPopover):

3:31 AM Changeset in webkit [115810] by tommyw@google.com
  • 16 edits in trunk

MediaStream API: Changing webkitGetUserMedia to take an object instead of a string
https://bugs.webkit.org/show_bug.cgi?id=84850

Reviewed by Dimitri Glazkov.

Source/WebCore:

The standard changed a while back to use an object as a dictionary but since JSC
didn't support the Dictionary class until just recently we have not updated the API until now.

Change covered by existing, and edited, tests.

  • Modules/mediastream/NavigatorMediaStream.cpp:

(WebCore::NavigatorMediaStream::webkitGetUserMedia):

  • Modules/mediastream/NavigatorMediaStream.h:

(WebCore):
(NavigatorMediaStream):

  • Modules/mediastream/NavigatorMediaStream.idl:
  • Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::create):
(WebCore::UserMediaRequest::UserMediaRequest):

  • Modules/mediastream/UserMediaRequest.h:

(WebCore):
(UserMediaRequest):

  • platform/mediastream/MediaStreamSourcesQueryClient.h:

(MediaStreamSourcesQueryClient):

Source/WebKit/chromium:

  • public/WebUserMediaRequest.h:

(WebUserMediaRequest):

  • src/WebUserMediaRequest.cpp:

LayoutTests:

Also took the opportunity to update the peerconnection-Attributes test
to test PeerConnection00 instead.

  • fast/mediastream/argument-types-expected.txt:
  • fast/mediastream/peerconnection-Attributes-expected.txt:
  • fast/mediastream/script-tests/argument-types.js:

(emptyFunction):

  • fast/mediastream/script-tests/peerconnection-Attributes.js:
  • platform/chromium/media/video-capture-preview.html:
3:14 AM Changeset in webkit [115809] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Fix typo introduced in r115800.
https://bugs.webkit.org/show_bug.cgi?id=85354

Patch by Dongwoo Im <dw.im@samsung.com> on 2012-05-02
Reviewed by Nikolas Zimmermann.

  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data): Assign 1 bit to the boolean attribute, webAudio.

3:00 AM Changeset in webkit [115808] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

[Qt][WK2] Minibrowser's progress bar should reset when WebProcess crashes while loading.
https://bugs.webkit.org/show_bug.cgi?id=84445

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-05-02
Reviewed by Jocelyn Turcotte.

Progress value needs resetting, when WebProcess crashes.
This patch moves crash logic for loading to QtWebPageLoadClient. It
also simplifies the callback function names in QtWebPageLoadClient, as they
all valid only for main frames.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::processDidCrash):
(QQuickWebViewFlickablePrivate::loadDidSucceed):

  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate::didChangeViewportProperties):
(QQuickWebViewPrivate):

  • UIProcess/qt/QtWebPageLoadClient.cpp:

(WebKit::QtWebPageLoadClient::QtWebPageLoadClient):
(WebKit::QtWebPageLoadClient::completeLoadWhenProcessDidCrashIfNeeded):
(WebKit):
(WebKit::QtWebPageLoadClient::didStartProvisionalLoad):
(WebKit::QtWebPageLoadClient::didReceiveServerRedirectForProvisionalLoad):
(WebKit::QtWebPageLoadClient::didCommitLoad):
(WebKit::QtWebPageLoadClient::didSameDocumentNavigation):
(WebKit::QtWebPageLoadClient::didReceiveTitle):
(WebKit::QtWebPageLoadClient::didFirstVisuallyNonEmptyLayout):
(WebKit::QtWebPageLoadClient::didStartProvisionalLoadForFrame):
(WebKit::QtWebPageLoadClient::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::QtWebPageLoadClient::didCommitLoadForFrame):
(WebKit::QtWebPageLoadClient::didSameDocumentNavigationForFrame):
(WebKit::QtWebPageLoadClient::didReceiveTitleForFrame):
(WebKit::QtWebPageLoadClient::didFirstVisuallyNonEmptyLayoutForFrame):

  • UIProcess/qt/QtWebPageLoadClient.h:

(WebKit):
(QtWebPageLoadClient):

2:52 AM Changeset in webkit [115807] by commit-queue@webkit.org
  • 67 edits
    1 add in trunk/LayoutTests

[EFL] CSS tests needs rebaselining
https://bugs.webkit.org/show_bug.cgi?id=85177

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-02

  • platform/efl/fast/css/disabled-author-styles-expected.png: Added.
  • platform/efl/fast/css/import-rule-regression-11590-expected.txt:
  • platform/efl/fast/css/inline-element-line-break-expected.txt:
  • platform/efl/fast/css/inline-properties-important-expected.txt:
  • platform/efl/fast/css/invalid-percentage-property-expected.txt:
  • platform/efl/fast/css/invalidation-errors-3-expected.txt:
  • platform/efl/fast/css/last-child-pseudo-class-expected.txt:
  • platform/efl/fast/css/last-of-type-pseudo-class-expected.txt:
  • platform/efl/fast/css/layerZOrderCrash-expected.txt:
  • platform/efl/fast/css/line-height-expected.txt:
  • platform/efl/fast/css/line-height-overflow-expected.txt:
  • platform/efl/fast/css/list-outline-expected.txt:
  • platform/efl/fast/css/margin-bottom-form-element-quirk-expected.txt:
  • platform/efl/fast/css/margin-bottom-form-element-strict-expected.txt:
  • platform/efl/fast/css/margin-top-bottom-dynamic-expected.txt:
  • platform/efl/fast/css/negative-leading-expected.txt:
  • platform/efl/fast/css/negative-nth-child-expected.txt:
  • platform/efl/fast/css/nested-floating-relative-position-percentages-expected.txt:
  • platform/efl/fast/css/nested-layers-with-hover-expected.txt:
  • platform/efl/fast/css/non-empty-span-expected.png:
  • platform/efl/fast/css/non-empty-span-expected.txt:
  • platform/efl/fast/css/nth-child-dynamic-expected.txt:
  • platform/efl/fast/css/only-child-pseudo-class-expected.txt:
  • platform/efl/fast/css/only-of-type-pseudo-class-expected.txt:
  • platform/efl/fast/css/outline-auto-location-expected.txt:
  • platform/efl/fast/css/outline-narrowLine-expected.txt:
  • platform/efl/fast/css/percent-top-relative-container-height-unspecified-expected.txt:
  • platform/efl/fast/css/preserve-user-specified-zoom-level-on-reload-expected.png:
  • platform/efl/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt:
  • platform/efl/fast/css/pseudo-element-line-break-expected.txt:
  • platform/efl/fast/css/quirk-orphaned-units-expected.txt:
  • platform/efl/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png:
  • platform/efl/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.txt:
  • platform/efl/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png:
  • platform/efl/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.txt:
  • platform/efl/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png:
  • platform/efl/fast/css/relative-positioned-block-nested-with-inline-parent-expected.txt:
  • platform/efl/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png:
  • platform/efl/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.txt:
  • platform/efl/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png:
  • platform/efl/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.txt:
  • platform/efl/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png:
  • platform/efl/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.txt:
  • platform/efl/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png:
  • platform/efl/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.txt:
  • platform/efl/fast/css/relative-positioned-block-with-inline-ancestor-expected.png:
  • platform/efl/fast/css/relative-positioned-block-with-inline-ancestor-expected.txt:
  • platform/efl/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png:
  • platform/efl/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.txt:
  • platform/efl/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png:
  • platform/efl/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.txt:
  • platform/efl/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png:
  • platform/efl/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.txt:
  • platform/efl/fast/css/selector-set-attribute-expected.txt:
  • platform/efl/fast/css/table-text-align-quirk-expected.txt:
  • platform/efl/fast/css/table-text-align-strict-expected.txt:
  • platform/efl/fast/css/text-align-expected.txt:
  • platform/efl/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/efl/fast/css/text-overflow-ellipsis-bidi-expected.txt:
  • platform/efl/fast/css/text-overflow-ellipsis-expected.txt:
  • platform/efl/fast/css/text-overflow-ellipsis-strict-expected.txt:
  • platform/efl/fast/css/text-transform-select-expected.txt:
  • platform/efl/fast/css/textCapitalizeEdgeCases-expected.txt:
  • platform/efl/fast/css/universal-hover-quirk-expected.txt:
  • platform/efl/fast/css/value-list-out-of-bounds-crash-expected.txt:
  • platform/efl/fast/css/word-space-extra-expected.txt:
  • platform/efl/fast/css/zoom-font-size-expected.txt:
2:39 AM Changeset in webkit [115806] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, marked fast/js/random-array-gc-stress.html as SLOW on debug.

  • platform/chromium/test_expectations.txt:
2:02 AM Changeset in webkit [115805] by Antti Koivisto
  • 5 edits in trunk/Source/WebCore

StyleSheetInternal::parseUserStyleSheet() should be called parseAuthorStyleSheet().

Rubber-stamped by Nikolas Zimmermann.

  • css/CSSImportRule.cpp:

(WebCore::StyleRuleImport::setCSSStyleSheet):

  • css/CSSStyleSheet.cpp:

(WebCore::StyleSheetInternal::parseAuthorStyleSheet):

  • css/CSSStyleSheet.h:

(StyleSheetInternal):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::setCSSStyleSheet):

1:51 AM Changeset in webkit [115804] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

REGRESSION: Web Inspector doesn't show cookies anymore
https://bugs.webkit.org/show_bug.cgi?id=85349

Pass root node instead of DataGrid object to the "populateNode" method.
Added compiler annotations so that closure compiler catches such errors.

Reviewed by Pavel Feldman.

  • inspector/front-end/CookiesTable.js:

(WebInspector.CookiesTable.prototype._rebuildTable):

  • inspector/front-end/NetworkRequest.js:

(WebInspector.NetworkRequest.prototype.addFrameError):

1:29 AM Changeset in webkit [115803] by caseq@chromium.org
  • 15 edits in trunk/LayoutTests

Unreviewed test rebaseline after r115749.

  • platform/chromium-mac-leopard/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac-leopard/media/audio-repaint-expected.png:
  • platform/chromium-mac-leopard/media/controls-after-reload-expected.png:
  • platform/chromium-mac/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac/media/audio-repaint-expected.png:
  • platform/chromium-mac/media/controls-after-reload-expected.png:
  • platform/chromium-mac/media/controls-layout-direction-expected.png:
  • platform/chromium-mac/media/media-controls-clone-expected.png:
  • platform/chromium-win/media/audio-controls-rendering-expected.png:
  • platform/chromium-win/media/audio-repaint-expected.png:
  • platform/chromium-win/media/controls-after-reload-expected.png:
  • platform/chromium-win/media/controls-layout-direction-expected.png:
  • platform/chromium-win/media/media-controls-clone-expected.png:
  • platform/chromium/test_expectations.txt:
1:20 AM Changeset in webkit [115802] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WTF

[Qt]r57240 broke Qt build (gcc bug)
https://bugs.webkit.org/show_bug.cgi?id=37253

Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2012-05-02
Reviewed by Noam Rosenthal.

Removing workaround macro since current gcc/Qt doesn't require it to compile.

  • wtf/PassRefPtr.h:

(WTF):

1:10 AM Changeset in webkit [115801] by Simon Hausmann
  • 5 edits
    1 add in trunk/Source/WebKit2

[Qt] QQuickWebView does not allow for input from virtual keyboard
https://bugs.webkit.org/show_bug.cgi?id=85350

Reviewed by Kenneth Christiansen.

It is necessary to set the ItemAcceptsInputMethod flag on the QQuickWebView if we have editable
content, in order for the input method to recognize that we can handle input method events.

Analyzed by Michael Brüning.

  • UIProcess/API/qt/qquickwebview.cpp: Add simple hook for executing JS as private C++ API.

(JSCallbackClosure):
(javaScriptCallback):
(QQuickWebView::runJavaScriptInMainFrame):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/tests/html/inputmethod.html: Added.
  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView):
(tst_QQuickWebView::runJavaScript): Simple helper for running JS.
(tst_QQuickWebView::inputMethod): Added simple test for ItemAcceptsInputMethod toggling.

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(WebKit::QtWebPageEventHandler::updateTextInputState): Set ItemAcceptsInputMethod as soon as we
have editable content.

12:58 AM Changeset in webkit [115800] by commit-queue@webkit.org
  • 13 edits
    4 adds in trunk

[EFL] Implement the Web Audio API feature.
https://bugs.webkit.org/show_bug.cgi?id=78688

Patch by Dongwoo Im <dw.im@samsung.com> on 2012-05-02
Reviewed by Philippe Normand.

Implement the Web Audio API feature on the EFL port.
https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html

.:

  • Source/cmake/FindGStreamer-Audio.cmake: Added. Find the pkgconfig of the GStreamer-audio.
  • Source/cmake/FindGStreamer-FFT.cmake: Added. Find the pkgconfig of the GStreamer-fft.
  • Source/cmake/OptionsEfl.cmake: Add the ENABLE_WEB_AUDIO option.
  • Source/cmakeconfig.h.cmake: Add the ENABLE_WEB_AUDIO option.

Source/WebCore:

  • CMakeLists.txt: Add the list of the files which are needed for the Web Audio APi.
  • PlatformEfl.cmake: Add the list of the files which are needed for the Web Audio APi.
  • UseJSC.cmake: Add the list of the files which are needed for the Web Audio APi.
  • platform/audio/HRTFElevation.cpp: Enable the USE_CONCATENATED_IMPULSE_RESPONSES macro.

(WebCore):

  • platform/audio/efl/AudioBusEfl.cpp: Added.

(WebCore):
(WebCore::AudioBus::loadPlatformResource): Create the absolute path of the audio resource.

Source/WebKit/efl:

  • ewk/ewk_view.cpp: Add the setter/getter of the webaudio feature.

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(ewk_view_setting_web_audio_get): Enable/disable the Web Audio API feature.
(ewk_view_setting_web_audio_set): Query if the Web Audio API feature is enabled.

  • ewk/ewk_view.h: Add the prototypes.

LayoutTests:

  • platform/efl/Skipped: Change the comment of webaudio.
12:00 AM Changeset in webkit [115799] by scherkus@chromium.org
  • 1 edit
    1 move in trunk/LayoutTests

[Chromium] Adjust baseline location for media/media-can-play-type-webm.html.

  • platform/chromium/media/media-can-play-webm-expected.txt: Renamed from LayoutTests/media/media-can-play-webm-expected.txt.

May 1, 2012:

11:07 PM Changeset in webkit [115798] by scherkus@chromium.org
  • 14 edits
    1 move
    7 adds
    1 delete in trunk/LayoutTests

Clean up media canPlayType() tests and add a test for WebM.
https://bugs.webkit.org/show_bug.cgi?id=85116

Reviewed by Eric Carlson.

  • media/media-can-play-flac-audio-expected.txt:
  • media/media-can-play-flac-audio.html:
  • media/media-can-play-mpeg-audio-expected.txt:
  • media/media-can-play-mpeg-audio.html:
  • media/media-can-play-mpeg4-video.html:
  • media/media-can-play-octet-stream-expected.txt:
  • media/media-can-play-octet-stream.html:
  • media/media-can-play-ogg-expected.txt:
  • media/media-can-play-ogg.html:
  • media/media-can-play-type-expected.txt: Renamed from LayoutTests/media/video-can-play-type-expected.txt.
  • media/media-can-play-type.html: Added.
  • media/media-can-play-wav-audio-expected.txt:
  • media/media-can-play-wav-audio.html:
  • media/media-can-play-webm-expected.txt: Added.
  • media/media-can-play-webm.html: Added.
  • media/video-can-play-type.html: Removed.
11:07 PM Changeset in webkit [115797] by haraken@chromium.org
  • 15 edits in trunk/Source/WebCore

[V8] Add an Isolate parameter to setJSWrapperForXXX()
https://bugs.webkit.org/show_bug.cgi?id=85329

Reviewed by Adam Barth.

The objective is to pass Isolate around in V8 bindings.
This patch adds an Isolate parameter to setJSWrapperForXXX()
and passes Isolate to setJSWrapperForXXX() in CodeGeneratorV8.pm.
I'll pass Isolate to setJSWrapperForXXX() in custom bindings
in a follow-up patch.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm: Modified as described above.

(GenerateConstructorCallback):
(GenerateEventConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateToV8Converters):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::setJSWrapperForDOMNode):
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMNode):

  • bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject):
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMObject):

  • bindings/scripts/test/V8/V8Float64Array.cpp: Updated run-bindings-tests results.

(WebCore::V8Float64Array::wrapSlow):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::wrapSlow):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::wrapSlow):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::constructorCallback):
(WebCore::V8TestEventConstructor::wrapSlow):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::V8TestEventTarget::wrapSlow):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::constructorCallback):
(WebCore::V8TestInterface::wrapSlow):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::wrapSlow):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):
(WebCore::V8TestNamedConstructor::wrapSlow):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::constructorCallback):
(WebCore::V8TestNode::wrapSlow):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::constructorCallback):
(WebCore::V8TestObj::wrapSlow):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):

10:54 PM Changeset in webkit [115796] by eric@webkit.org
  • 13 edits in trunk

Add <iframe seamless> navigation code (and pass all the navigation tests)
https://bugs.webkit.org/show_bug.cgi?id=85340

Reviewed by Adam Barth.

Source/WebCore:

This code was primarily written by Adam Barth and then submitted to my
GitHub branch via a pull request:
https://github.com/eseidel/webkit/compare/master...seamless
https://github.com/eseidel/webkit/pull/2
https://github.com/eseidel/webkit/pull/3

I rewrote parts of it to use Docment::shouldDisplaySeamlesslyWithParent.

Other parts of the original change have already been committed to WebKit by Adam
as part of prep-work for making the loader seamless-ready.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::findFrameForNavigation):

LayoutTests:

Update results now that we pass all the navigation tests.

  • fast/frames/seamless/seamless-form-get-expected.txt:
  • fast/frames/seamless/seamless-form-get-named-expected.txt:
  • fast/frames/seamless/seamless-form-post-expected.txt:
  • fast/frames/seamless/seamless-form-post-named-expected.txt:
  • fast/frames/seamless/seamless-hyperlink-expected.txt:
  • fast/frames/seamless/seamless-hyperlink-named-expected.txt:
  • fast/frames/seamless/seamless-window-location-expected.txt:
  • fast/frames/seamless/seamless-window-location-href-expected.txt:
  • fast/frames/seamless/seamless-window-location-sandbox-expected.txt:
  • fast/frames/seamless/seamless-window-open-expected.txt:
10:12 PM Changeset in webkit [115795] by tkent@chromium.org
  • 1 edit
    1 copy
    1 delete in trunk/LayoutTests

[Chromium] Move date-input-visible-strings-expected.txt to the correct place.

  • platform/chromium-linux/fast/forms/date/date-input-visible-strings-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/forms/date/date-input-visible-strings-expected.txt.
9:57 PM Changeset in webkit [115794] by rniwa@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Unnecessary <form> tags created inside of an <iframe> with designMode on
https://bugs.webkit.org/show_bug.cgi?id=13126

Reviewed by Eric Seidel.

Add a regression test since this bug doesn't reproduce anymore but it's still good to test it.

  • editing/inserting/insert-paragraph-inside-form-expected.txt: Added.
  • editing/inserting/insert-paragraph-inside-form.html: Added.
9:44 PM Changeset in webkit [115793] by eae@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/page/EventHandler.cpp

Remove extra round call in EventHandler on branch.

9:28 PM Changeset in webkit [115792] by scheib@chromium.org
  • 2 edits in trunk/Source/WebCore

Fullscreen pop-up logic restored to using processingUserGesture.
https://bugs.webkit.org/show_bug.cgi?id=85105

WebKit was recently updated to the new Fullscreen API:
http://dvcs.w3.org/hg/fullscreen/raw-file/tip/Overview.html#api
http://trac.webkit.org/changeset/111028

This change reverts back to using processingUserGesture() instead
of DOMWindow::allowPopUp(). This fixes incorrect behavior in
at least the Chromium port and is consistent with the cited
definition of "allowed to show a pop-up":

An algorithm is allowed to show a pop-up if, in the task in which the algorithm is running, either:

  • an activation behavior is currently being processed whose click event was trusted, or
  • the event listener for a trusted click event is being handled.

Reviewed by Dimitri Glazkov.

No new tests.

  • dom/Document.cpp:

(WebCore::Document::requestFullScreenForElement):

9:22 PM Changeset in webkit [115791] by eae@chromium.org
  • 540 edits
    82 copies
    3 deletes in branches/subpixellayout

Merge trunk changes up until 115787 into subpixel branch.

9:16 PM Changeset in webkit [115790] by xji@chromium.org
  • 3 edits in trunk/LayoutTests

2012-05-01 Xiaomei Ji <xji@chromium.org>

Skip editing/selection/move-by-word-visually-mac.html (introduced in r115788) in qt and wk2.

  • platform/qt/Skipped:
  • platform/wk2/Skipped:
9:01 PM Changeset in webkit [115789] by rakuco@webkit.org
  • 3 edits in trunk/Tools

webkitpy: Remove unused platform imports.
https://bugs.webkit.org/show_bug.cgi?id=85341

Reviewed by Eric Seidel.

Remove a few uses of `import platform' which were either rendered
unneeded after r105931 or were never needed at all.

  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/tool/bot/flakytestreporter.py:
8:41 PM Changeset in webkit [115788] by xji@chromium.org
  • 6 edits
    2 adds
    2 deletes in trunk

Source/WebCore: enable ctrl-arrow move by word visually in non-Windows platforms.
https://bugs.webkit.org/show_bug.cgi?id=85017

Reviewed by Ryosuke Niwa.

Enable ctrl-arrow moves caret by word in visual order in non-Windows platforms that use ICU word
break iterator (it is not enabled for WinCE and Qt where ICU is not used). For those platforms, ctrl-arrow
moves caret to word break position before spaces. For example, given a logical text "abc def hij", the word
break positions using ctrl-left-arrow from rightmost position are "|abc |def |hij".
The word break positions using ctrl-right-arrow from leftmost position are "abc| def| hij|".

Test: editing/selection/move-by-word-visually-mac.html

  • editing/EditingBehavior.h:

(EditingBehavior):
(WebCore::EditingBehavior::shouldEatSpaceToNextWord): To control different word break positions
(regards to space) for different platforms.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::modifyMovingRight): Enable visual word movement for all platforms that use ICU.
(WebCore::FrameSelection::modifyMovingLeft):

  • editing/visible_units.cpp:

(WebCore::visualWordPosition): Determine the right word break position (regards to space) based on EditingBehavior.
(WebCore::leftWordPosition):
(WebCore::rightWordPosition):

  • editing/visible_units.h:

LayoutTests: enable ctrl-arrow move by word visually in other platforms (besides Windows)
https://bugs.webkit.org/show_bug.cgi?id=85017

Reviewed by Ryosuke Niwa.

Since DOMSelection.modify('move', 'left'/'right', 'word') moves caret by word in visual order (instead of
logical order) now, there are several changes to the test file:

  1. file name renamed from move-left-right-by-word-mac.html to move-by-word-visually-mac.html.
  2. test expectations change from moving caret by word in logical order to moving caret by word in visual order.
  3. since test expectations are inside test file itself, test file itself changes accordingly.
  • editing/selection/move-by-word-visually-mac-expected.txt: Copied from LayoutTests/editing/selection/move-left-right-by-word-mac-expected.txt.
  • editing/selection/move-by-word-visually-mac.html: Copied from LayoutTests/editing/selection/move-left-right-by-word-mac.html.
  • editing/selection/move-left-right-by-word-mac-expected.txt: Removed.
  • editing/selection/move-left-right-by-word-mac.html: Removed.
8:38 PM Changeset in webkit [115787] by commit-queue@webkit.org
  • 12 edits
    4 adds in trunk

Modify RealtimeAnalyserNode pull mechanism
https://bugs.webkit.org/show_bug.cgi?id=77515

Patch by Raymond Liu <raymond.liu@intel.com> on 2012-05-01
Reviewed by Chris Rogers.

Source/WebCore:

Test: webaudio/automatic-pull-node.html

  • GNUmakefile.list.am:
  • Modules/webaudio/AudioBasicInspectorNode.cpp: Added.

(WebCore):
(WebCore::AudioBasicInspectorNode::AudioBasicInspectorNode):
(WebCore::AudioBasicInspectorNode::pullInputs):
(WebCore::AudioBasicInspectorNode::connect):
(WebCore::AudioBasicInspectorNode::disconnect):
(WebCore::AudioBasicInspectorNode::checkNumberOfChannelsForInput):
(WebCore::AudioBasicInspectorNode::updatePullStatus):

  • Modules/webaudio/AudioBasicInspectorNode.h: Added.

(WebCore):
(AudioBasicInspectorNode):

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::AudioContext):
(WebCore::AudioContext::~AudioContext):
(WebCore::AudioContext::handlePreRenderTasks):
(WebCore::AudioContext::handlePostRenderTasks):
(WebCore::AudioContext::markForDeletion):
(WebCore):
(WebCore::AudioContext::addAutomaticPullNode):
(WebCore::AudioContext::removeAutomaticPullNode):
(WebCore::AudioContext::updateAutomaticPullNodes):
(WebCore::AudioContext::processAutomaticPullNodes):

  • Modules/webaudio/AudioContext.h:

(AudioContext):

  • Modules/webaudio/AudioDestinationNode.cpp:

(WebCore::AudioDestinationNode::provideInput):

  • Modules/webaudio/AudioNode.h:

(AudioNode):

  • Modules/webaudio/AudioNodeOutput.h:

(WebCore::AudioNodeOutput::isConnected):
(AudioNodeOutput):

  • Modules/webaudio/RealtimeAnalyserNode.cpp:

(WebCore::RealtimeAnalyserNode::RealtimeAnalyserNode):

  • Modules/webaudio/RealtimeAnalyserNode.h:

(RealtimeAnalyserNode):

  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:

LayoutTests:

  • webaudio/automatic-pull-node-expected.txt: Added.
  • webaudio/automatic-pull-node.html: Added.
8:35 PM Changeset in webkit [115786] by keishi@webkit.org
  • 4 edits
    4 adds in trunk

datalist: Form control in a <datalist> should be barred from constraint validation
https://bugs.webkit.org/show_bug.cgi?id=84359

Reviewed by Kent Tamura.

Source/WebCore:

Tests: fast/forms/datalist/datalist-child-validation.html

fast/forms/form-control-element-crash.html

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::HTMLFormControlElement):
(WebCore::HTMLFormControlElement::updateAncestors): Updates the ancestor information.
(WebCore::HTMLFormControlElement::insertedInto): Invalidate the ancestor information and call setNeedsWillValidateCheck because willValidate might have changed.
(WebCore::HTMLFormControlElement::removedFrom): Ditto.
(WebCore::HTMLFormControlElement::disabled):
(WebCore::HTMLFormControlElement::recalcWillValidate): Returns false if element has a datalist ancestor.
(WebCore::HTMLFormControlElement::willValidate): Check if ancestor information is valid too.
(WebCore::HTMLFormControlElement::setNeedsWillValidateCheck):

  • html/HTMLFormControlElement.h:

(HTMLFormControlElement):

LayoutTests:

  • fast/forms/datalist/datalist-child-validation-expected.txt: Added.
  • fast/forms/datalist/datalist-child-validation.html: Added. Tests that willValidate changes from false to true when we move the element out of the datalist.
  • fast/forms/form-control-element-crash-expected.txt: Added.
  • fast/forms/form-control-element-crash.html: Added. Tests for the crash reported in Bug 85149.
8:27 PM Changeset in webkit [115785] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Calendar Picker: Close the picker by ESC key
https://bugs.webkit.org/show_bug.cgi?id=85337

Reviewed by Kentaro Hara.

No new tests. Calendar picker is not testable in DRT yet.

  • Resources/calendarPicker.js:

(handleGlobalKey): Close the popup by ESC key.

8:20 PM Changeset in webkit [115784] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

PNGImageDecoder: Handle interlace buffer allocation failure
https://bugs.webkit.org/show_bug.cgi?id=85276

Reviewed by Eric Seidel.

No new tests. Not something we can easily test (malloc failure).

  • platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageDecoder::rowAvailable): Check interlace buffer allocations
and bail via longjmp on failure. Note PNG_INTERLACE_ADAM7 is the only libpng
supported interlace type so test for it explicitly.

8:01 PM Changeset in webkit [115783] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Calendar Picker: Too wide in Japanese locale
https://bugs.webkit.org/show_bug.cgi?id=85331

Reviewed by Kentaro Hara.

No new tests. This is a locale-specific behavior.

  • Resources/calendarPicker.js:

(formatJapaneseImperialEra):
Do not show an imperial era later than 平成99年 to avoid very long
year string like "275760年(平成273772年)."
(YearMonthController.prototype.attachTo):

  • Respect the maximum year specfied by <input max=...> If <input max="9999-12-31"> is specified, we don't need to secure space for the year 275,760.
  • Check the width for 平成99年 as well as the maximum year because "2087年(平成99年)" is usually wider than "275760年".
7:52 PM Changeset in webkit [115782] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

PNGImageDecoder: Add ENABLE(IMAGE_DECODER_DOWN_SAMPLING) guards to rowAvailable
https://bugs.webkit.org/show_bug.cgi?id=85268

Reviewed by Eric Seidel.

PNGImageDecoder supports image downsampling. Add ENABLE guards to show where
downsampling is applied when outputting decoded rows to the frame buffer. Most
ports don't enable the flag: don't penalize them in terms speed in this tight
row pixel write loop. s/y/destY/ to match setRGBA() and amend some comments.

No new tests. No change in behavior.

  • platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageDecoder::rowAvailable):

7:24 PM Changeset in webkit [115781] by tkent@chromium.org
  • 2 edits
    1 copy
    1 move
    1 add in trunk/LayoutTests

[Chromium] Rebaseline for date-input-visible-strings.html.

  • platform/chromium-linux-x86/fast/forms/date/date-input-visible-strings-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/forms/date/date-input-visible-strings-expected.txt.
  • platform/chromium/fast/forms/date/date-input-visible-strings-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/forms/date/date-input-visible-strings-expected.txt.
  • platform/chromium/test_expectations.txt:
7:14 PM Changeset in webkit [115780] by aestes@apple.com
  • 2 edits in trunk/LayoutTests

scrollbars/scrollbar-miss-mousemove-disabled.html is asserting in markAllMisspellingsAndBadGrammarInRanges()
https://bugs.webkit.org/show_bug.cgi?id=85273

  • platform/mac/Skipped: Skip the test.
7:09 PM Changeset in webkit [115779] by eric@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove uneeded min/max pref width assignment from RenderView
https://bugs.webkit.org/show_bug.cgi?id=85325

Reviewed by Julien Chaffraix.

This code has been with us since the original import from KDE:
http://trac.webkit.org/browser/trunk/WebCore/khtml/rendering/render_root.cpp?annotate=blame&rev=4#L93
It's never been documented, or explained. Removing it showed no
effect on my local layout tests run.
However this code blocks proper implementation of <iframe seamless>
as we have to do proper min/max width negotiation across the iframe boundary.

I would remove the whole function, but doing so opens a whole can of worms
as this override is public, yet normally this function is *private* (well protected on RenderBox).
It seems plausible that frame flattening code needs this override since it doesn't always
call the min/maxPreferredWidth() calls which normally automatically call this compute*
function if the pref-widths are dirty.
Instead of trying to track that all down, I'm just removing this line, and we'll go
back and remove the whole function at a later date if possible.

  • rendering/RenderView.cpp:

(WebCore::RenderView::computePreferredLogicalWidths):

6:36 PM Changeset in webkit [115778] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests/platform

Actually commit changes.

6:34 PM Changeset in webkit [115777] by rniwa@webkit.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Skip the test added by r115724 on WebKit2 and Qt because drag and drop isn't supported by DRT
on those platforms.

  • platform/qt/Skipped:
  • platform/wk2/Skipped:
6:32 PM Changeset in webkit [115776] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[GTK] new ref test fast/forms/listbox-clear-restore.html fails.
https://bugs.webkit.org/show_bug.cgi?id=77633

Patch by Joe Thomas <joethomas@motorola.com> on 2012-05-01
Reviewed by Martin Robinson.

Flakiness of the test case is fixed in http://trac.webkit.org/changeset/115526.
Enabling the test for GTK and Chromium ports.

  • platform/chromium/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
6:24 PM Changeset in webkit [115775] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/platform/FractionalLayoutUnit.h

Changing the asserts in FractionalLayoutUnit to stderr logs.

6:23 PM Changeset in webkit [115774] by Nate Chapin
  • 5 edits
    4 adds in trunk

Source/WebCore: REGRESSION(r115654): PDFs come up blank
https://bugs.webkit.org/show_bug.cgi?id=85275

Reviewed by Alexey Proskuryakov.

Test: http/tests/loading/pdf-commit-load-callbacks.html

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::finishedLoading): The load needs to be

committed before we call finishedLoading on the
FrameLoaderClient.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::transitionToCommitted): We're guaranteeing

that receivedFirstData() will be called other ways (namely,
DocumentLoader won't finish without doing so). This call now
causes custom representations to double-commit, which is bad.

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=85275.

Reviewed by Alexey Proskuryakov.

  • http/tests/loading/pdf-commit-load-callbacks-expected.txt: Added.
  • http/tests/loading/pdf-commit-load-callbacks.html: Added.
  • platform/chromium/http/tests/loading: Added.
  • platform/chromium/http/tests/loading/pdf-commit-load-callbacks-expected.txt: Added.
  • platform/wk2/Skipped: New test requires layoutTestController.dumpResourceLoadCallbacks(),

which isn't support for wk2 yet.

6:09 PM Changeset in webkit [115773] by eric@webkit.org
  • 17 edits
    1 copy
    1 add in trunk

Add support for seamless attribute as well as seamless sandbox flag and default CSS styling
https://bugs.webkit.org/show_bug.cgi?id=85302

Reviewed by Ojan Vafai.

Source/WebCore:

This also adds support for the seamless sandbox flag from HTML 5.
The sandbox flag is not speficially overridable in the current HTML5,
but it is set (like all sandbox flags) by default when sandbox is specified.
Unfortunately this support is not yet observable in this patch, as
this patch adds not observable features of seamless.

This patch also adds the html.css additions for seamless, as specified:
http://www.whatwg.org/specs/web-apps/current-work/multipage/rendering.html#replaced-elements

I noticed that my previous testing did not confirm that iframes marked
for seamless (but not possible to display as seamless due to sandbox, etc.)
were still to have this seamless styling. I've added additional testing for this case.

I also added another test for the about:blank FIXME added as part of this change.

In order to support srcdoc w/ seamless, we needed to move the srcdoc determination
sooner in the initSecurityContext function (before the should-inherit early return).

The next patch will make seamless actually observable from JS/DOM, this one
just lays down all the plumbing, and separates the security aspects for
easy review.

Test: fast/frames/seamless/seamless-inherited-origin.html

  • css/html.css:

(iframe:not([seamless])):
(iframe[seamless]):

  • dom/Document.cpp:

(WebCore::isEligibleForSeamless):
(WebCore):
(WebCore::Document::initSecurityContext):
(WebCore::Document::seamlessParentIFrame):
(WebCore::Document::shouldDisplaySeamlesslyWithParent):

  • dom/Document.h:

(WebCore):
(Document):

  • dom/SecurityContext.cpp:

(WebCore::SecurityContext::SecurityContext):

  • dom/SecurityContext.h:

(WebCore::SecurityContext::mayDisplaySeamlessWithParent):
(SecurityContext):

  • html/HTMLAttributeNames.in:
  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::shouldDisplaySeamlessly):
(WebCore):

  • html/HTMLIFrameElement.h:

(HTMLIFrameElement):

  • html/HTMLIFrameElement.idl:

LayoutTests:

Update all the test results now that the html.css changes have
been added for seamless, as specified by HTML5:
http://www.whatwg.org/specs/web-apps/current-work/multipage/rendering.html#replaced-elements

I also added a new test for about:blank iframes (per a code-FIXME)
as well as some new testing to confirm that the default seamless-CSS style
applies even when iframes cannot render seamless due to security restrictions.

  • fast/frames/seamless/seamless-basic-expected.txt:
  • fast/frames/seamless/seamless-basic.html:
  • fast/frames/seamless/seamless-inherited-origin-expected.txt: Added.
  • fast/frames/seamless/seamless-inherited-origin.html: Added.
  • fast/frames/seamless/seamless-inline-expected.txt:
  • fast/frames/seamless/seamless-min-max-expected.txt:
  • fast/frames/seamless/seamless-nested-expected.txt:
  • fast/frames/seamless/seamless-quirks-expected.txt:
  • fast/frames/seamless/seamless-sandbox-flag-expected.txt:
  • fast/frames/seamless/seamless-sandbox-flag.html:
  • fast/frames/seamless/seamless-sandbox-srcdoc-expected.txt:
  • http/tests/security/seamless/seamless-cross-origin-expected.txt:
  • http/tests/security/seamless/seamless-sandbox-srcdoc-expected.txt:
  • svg/in-html/by-reference.html: was using seamless, but really doens't want to, doing so just adds noise.
5:41 PM Changeset in webkit [115772] by pilgrim@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Additional instances of calling histogramCustomCounts directly
https://bugs.webkit.org/show_bug.cgi?id=85322

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

  • src/painting/PaintAggregator.cpp:

(WebKit::PaintAggregator::invalidateRect):

5:39 PM Changeset in webkit [115771] by commit-queue@webkit.org
  • 10 edits in trunk/Source

use USE(NATIVE_FULLSCREEN_VIDEO) instead of ENABLE(NATIVE_FULLSCREEN_VIDEO)
https://bugs.webkit.org/show_bug.cgi?id=85316

Patch by Min Qin <qinmin@google.com> on 2012-05-01
Reviewed by Kent Tamura.

Source/WebCore:

NATIVE_FULLSCREEN_VIDEO means the fullscreen video is implemented by native
system view instead of webkit.
So it is more appropriate to use USE(NATIVE_FULLSCREEN_VIDEO).
This chagne also disabled the rendering of the fullscreen video element in webkit
when that flag is set.
Just renaming the variable, no new tests.

  • dom/Document.cpp:

(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore):

  • platform/graphics/MediaPlayer.cpp:

(WebCore):

  • platform/graphics/MediaPlayer.h:

(MediaPlayer):

  • platform/graphics/MediaPlayerPrivate.h:

(MediaPlayerPrivateInterface):

Source/WebKit/chromium:

NATIVE_FULLSCREEN_VIDEO means the fullscreen video is implemented by native
system view instead of webkit
So it is more appropriate to use USE(NATIVE_FULLSCREEN_VIDEO).
Just rename the flag, no new tests

  • features.gypi:
  • src/WebMediaPlayerClientImpl.cpp:

(WebKit):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::enterFullScreenForElement):
(WebKit::WebViewImpl::exitFullScreenForElement):

5:36 PM Changeset in webkit [115770] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

inspectorReallyUsesWebKitUserInterface should be more robust against missing files
https://bugs.webkit.org/show_bug.cgi?id=85327
<rdar://problem/11332864>

Reviewed by Timothy Hatcher.

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::inspectorReallyUsesWebKitUserInterface):

  • WebProcess/WebPage/mac/WebInspectorMac.mm:

(WebKit::inspectorReallyUsesWebKitUserInterface):

5:33 PM Changeset in webkit [115769] by pilgrim@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Additional instances of calling createAudioDevice directly
https://bugs.webkit.org/show_bug.cgi?id=85321

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

  • src/AudioDestinationChromium.cpp:

(WebCore::AudioDestinationChromium::AudioDestinationChromium):

5:27 PM Changeset in webkit [115768] by pilgrim@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Additional instances of calling mimeRegistry directly
https://bugs.webkit.org/show_bug.cgi?id=85320

Reviewed by Eric Seidel.

Part of a refactoring series. See tracking bug 82948.

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::canShowMIMEType):

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::supportsType):

5:21 PM Changeset in webkit [115767] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[chromium] Accept four parameters when dispatching a WebInputEvent::GestureTap in chromium DRT eventSender
https://bugs.webkit.org/show_bug.cgi?id=85289

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-05-01
Reviewed by Eric Seidel.

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::gestureEvent):

This change will allow for testing of WK85101. Currently
no tests use the extra parameters deltaX and deltaY. Added
a check for the size of |arguments|.

5:21 PM Changeset in webkit [115766] by eae@chromium.org
  • 2 edits in branches/subpixellayout/Source/WebCore

Fix mac build on branch.

5:17 PM Changeset in webkit [115765] by jpfau@apple.com
  • 10 edits in trunk/Source

<rdar://problem/10422318> Support for web content filter delegate for filtering https content
https://bugs.webkit.org/show_bug.cgi?id=85300

Reviewed by Alexey Proskuryakov.

Source/WebCore:

No new tests.

  • WebCore.exp.in:
  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::MainResourceLoader):
(WebCore::MainResourceLoader::~MainResourceLoader):
(WebCore::MainResourceLoader::didCancel):
(WebCore::MainResourceLoader::didReceiveResponse):
(WebCore::MainResourceLoader::didReceiveData):
(WebCore::MainResourceLoader::didFinishLoading):
(WebCore::MainResourceLoader::didFail):

  • loader/MainResourceLoader.h:

(MainResourceLoader):

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

5:12 PM Changeset in webkit [115764] by tkent@chromium.org
  • 8 edits
    1 add in trunk/Source/WebCore

Calendar Picker: Add capability to add platform-specific style sheet
https://bugs.webkit.org/show_bug.cgi?id=85272

Reviewed by Kentaro Hara.

Add RenderTheme::extraCalendarPickerStyleSheet(). The resultant string
of the function is inserted into the calendar picker page.

No new tests. Calendar picker apperance is not testable yet.

  • Resources/calendarPicker.css: Removed styles for year-month buttons.
  • Resources/calendarPickerMac.css:

Moved from calendarPicker.css, and adjust styles so that they look
standard Lion buttons.
(.year-month-button):
(.year-month-button:active):
(.year-month-button:disabled):

  • WebCore.gyp/WebCore.gyp: Add a rule to produce CalendarPickerMac.{cpp,h}.
  • html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::writeDocument):
Add extraCalendarPickerStyleSheet() result to the document.

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::extraCalendarPickerStyleSheet):
Added. Returns an empty CString by default.

  • rendering/RenderTheme.h:

(RenderTheme): Added extraCalendarPickerStyleSheet().

  • rendering/RenderThemeChromiumMac.h: Added extraCalendarPickerStyleSheet().
  • rendering/RenderThemeChromiumMac.mm:

(WebCore::RenderThemeChromiumMac::extraCalendarPickerStyleSheet):
Added. Returns the content of Resources/calendarPickerMac.css.

5:04 PM Changeset in webkit [115763] by simonjam@chromium.org
  • 5 edits in trunk

Ensure HTMLElementStack fails gracefully if it has a non-Element.
https://bugs.webkit.org/show_bug.cgi?id=85167

Reviewed by Adam Barth.

Source/WebCore:

Test: Added to html5lib/resources/webkit02.dat

  • html/parser/HTMLElementStack.cpp:

(WebCore::HTMLElementStack::oneBelowTop):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processEndTag):

LayoutTests:

  • html5lib/resources/webkit02.dat:
4:45 PM Changeset in webkit [115762] by jchaffraix@webkit.org
  • 2 edits in branches/chromium/1084

Partial revert of r110072: Lazily allocate overflow: hidden layers if we have overflowing content

This chage forces us to allocate RenderLayers for overflow: hidden as it has been causing several
regressions. It leaves all of the scaffolding around to keep the change small. See bug 83954 for
the proper revert for trunk.

4:39 PM Changeset in webkit [115761] by eric@webkit.org
  • 2 edits in trunk/Tools

Add myself to the watchlist to watch all rendering changes, as well as sort the watchers in the list
https://bugs.webkit.org/show_bug.cgi?id=85305

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/config/watchlist:
4:36 PM Changeset in webkit [115760] by rniwa@webkit.org
  • 16 edits in trunk/Source

*Command.h files shouldn't be exported to WebKit layer
https://bugs.webkit.org/show_bug.cgi?id=74778

Reviewed by Eric Seidel.

Source/WebCore:

Remove the dependency on *Command.h files from Mac port's WebKit layer.
Also wrapped the call to TypingCommand::insertParagraphSeparatorInQuotedContent in the Editor class
so that we can just expose Editor's method instead of directly exposing the said static method.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • editing/Editor.h:

(Editor):

  • editing/mac/EditorMac.mm:

(WebCore::Editor::insertParagraphSeparatorInQuotedContent):
(WebCore):

Source/WebKit/chromium:

  • src/WebFrameImpl.cpp:
  • src/WebViewImpl.cpp:

Source/WebKit/gtk:

  • webkit/webkitwebframe.cpp:

Source/WebKit/mac:

  • WebView/WebFrame.mm:

(-[WebFrame _insertParagraphSeparatorInQuotedContent]):

Source/WebKit/win:

  • WebView.cpp:

Source/WebKit2:

  • WebProcess/WebPage/WebPage.cpp:
4:18 PM Changeset in webkit [115759] by eae@chromium.org
  • 5 edits in branches/subpixellayout/Source

Chromium/linux fixes for branch.

4:09 PM Changeset in webkit [115758] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

[EFL] fast/loader/file-protocol-fragment.html needs rebaselining
https://bugs.webkit.org/show_bug.cgi?id=85182

Unreviewed, add EFL expectation for fast/loader/file-protocol-fragment.html
and unskip the test.

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-01

  • platform/efl/Skipped:
  • platform/efl/fast/loader/file-protocol-fragment-expected.txt: Added.
4:01 PM Changeset in webkit [115757] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Remove expectations for media/encrypted-media/encrypted-media-events.html now that crash is fixed.
https://bugs.webkit.org/show_bug.cgi?id=84596

Unreviewed expectations update.

Patch by David Dorwin <ddorwin@chromium.org> on 2012-05-01

  • platform/chromium/test_expectations.txt:
3:52 PM Changeset in webkit [115756] by aestes@apple.com
  • 2 edits in trunk/LayoutTests

[Mac] inspector/debugger/linkifier.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=85319

  • platform/mac/Skipped: Skip the flakey test.
3:35 PM Changeset in webkit [115755] by jchaffraix@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove one bit from m_column to pack RenderTableCell bits more
https://bugs.webkit.org/show_bug.cgi?id=85291

Reviewed by Ojan Vafai.

Memory improvement, covered by the existing unit tests.

  • rendering/RenderTableCell.cpp:
  • rendering/RenderTableCell.h:

Remove one bit from m_column (which should be fine as I wouldn't expect tables above 1 millions
columns to render at all anyway) to pack the bitfields in 32 bits. Re-arranged the bits to have the bigger
bitfield first.

3:30 PM Changeset in webkit [115754] by fpizlo@apple.com
  • 8 edits
    3 adds in branches/dfgopt/Source

DFG should be able to compute dominators
https://bugs.webkit.org/show_bug.cgi?id=85269

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Implements a naive dominator calculator, which is currently just used to
print information in graph dumps. I've enabled it by default mainly to
be able to track its performance impact. So far it appears that there is
none, which is unsurprising given that the number of basic blocks in most
procedures is small.

Also tweaked bytecode dumping to reveal more useful information about the
nature of the code block.

(JSC::CodeBlock::dump):

  • dfg/DFGDominators.cpp: Added.

(DFG):
(JSC::DFG::Dominators::Dominators):
(JSC::DFG::Dominators::~Dominators):
(JSC::DFG::Dominators::compute):
(JSC::DFG::Dominators::iterateForBlock):

  • dfg/DFGDominators.h: Added.

(DFG):
(Dominators):
(JSC::DFG::Dominators::invalidate):
(JSC::DFG::Dominators::computeIfNecessary):
(JSC::DFG::Dominators::isValid):
(JSC::DFG::Dominators::dominates):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:

(Graph):

Source/WTF:

Reviewed by Oliver Hunt.

Added a bitvector class suitable for cheap static analysis. This class
differs from BitVector in that instead of optimizing for space, it
optimizes for execution time. Its API is also somewhat less friendly,
which is intentional; it's meant to be used in places where you know
up front how bit your bitvectors are going to be.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/FastBitVector.h: Added.

(WTF):
(FastBitVector):
(WTF::FastBitVector::FastBitVector):
(WTF::FastBitVector::~FastBitVector):
(WTF::FastBitVector::operator=):
(WTF::FastBitVector::numBits):
(WTF::FastBitVector::resize):
(WTF::FastBitVector::setAll):
(WTF::FastBitVector::clearAll):
(WTF::FastBitVector::set):
(WTF::FastBitVector::setAndCheck):
(WTF::FastBitVector::equals):
(WTF::FastBitVector::merge):
(WTF::FastBitVector::filter):
(WTF::FastBitVector::exclude):
(WTF::FastBitVector::clear):
(WTF::FastBitVector::get):
(WTF::FastBitVector::arrayLength):

3:25 PM Changeset in webkit [115753] by zmo@google.com
  • 2 edits in trunk/Tools

Unreviewed, rolling out r115735.
http://trac.webkit.org/changeset/115735
https://bugs.webkit.org/show_bug.cgi?id=85314

cause two tests to crash due to an ASSERTION failure
(Requested by zhenyao on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-01

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::gestureEvent):

3:22 PM Changeset in webkit [115752] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Slow scrolling on www.sholby.net
https://bugs.webkit.org/show_bug.cgi?id=85304
<rdar://problem/11138952>

Reviewed by Beth Dakin.

Fix two performance issues that showed up on the profiles.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
Reset the relevant painted object counter; it's only interesting when loading.

  • page/Page.cpp:

(WebCore::Page::startCountingRelevantRepaintedObjects):
Set m_isCountingRelevantRepaintedObjects to true after calling reset, since reset now sets it to false.

(WebCore::Page::resetRelevantPaintedObjectCounter):
Set m_isCountingRelevantRepaintedObjects to false.

(WebCore::Page::addRelevantRepaintedObject):
Use HashSet::find to avoid an extra hash lookup.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::updateMainFrameScrollPositionAndScrollLayerPosition):
Remove the call to FrameView::updateCompositingLayersAfterLayout now, since FrameView::notifyScrollPositionChanged
already calls this and was making us to a lot of work twice.

3:03 PM Changeset in webkit [115751] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Use the new barrier function in TiledCoreAnimationDrawingArea::forceRepaintAsync
https://bugs.webkit.org/show_bug.cgi?id=85313
<rdar://problem/10996039>

Reviewed by Sam Weinig.

Use the new dispatchAfterEnsuringUpdatedScrollPosition function in forceRepaintAsync to
ensure that the scroll position is up to date.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::forceRepaintAsync):

2:34 PM Changeset in webkit [115750] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Physijs demo crashes due to DFG not updating topCallFrame correctly.
https://bugs.webkit.org/show_bug.cgi?id=85311

Reviewed by Filip Pizlo.

A few of the dfg operations failed to correctly set the topCallFrame,
and so everything goes wrong. This patch corrects the effected operations,
and makes debug builds poison topCallFrame before calling a dfg operation.

  • dfg/DFGOperations.cpp:

(JSC::DFG::putByVal):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::prepareForExternalCall):
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheck):
(JSC::DFG::SpeculativeJIT::appendCallSetResult):

2:26 PM Changeset in webkit [115749] by commit-queue@webkit.org
  • 25 edits in trunk

Source/WebCore: Audio controls have a 1px surplus outline coming from RenderImage::paintReplaced base class,
which needs overwriting.
https://bugs.webkit.org/show_bug.cgi?id=84570

Patch by Silvia Pfeiffer <silviapf@chromium.org> on 2012-05-01
Reviewed by Eric Carlson.

No new tests - covered by existing audio rendering tests.

  • rendering/RenderMedia.cpp:

(WebCore::RenderMedia::paintReplaced): Overwrite inherited function.
(WebCore):

  • rendering/RenderMedia.h:

(RenderMedia):

LayoutTests: Audio controls have a 1px surplus outline coming from RenderImage::paintReplaced base class,
which needs overwriting. All layout tests with an audio element need a
visual update.
https://bugs.webkit.org/show_bug.cgi?id=84570

Patch by Silvia Pfeiffer <silviapf@chromium.org> on 2012-05-01
Reviewed by Eric Carlson.

  • platform/chromium-linux/media/audio-controls-rendering-expected.png:
  • platform/chromium-linux/media/audio-repaint-expected.png:
  • platform/chromium-linux/media/controls-after-reload-expected.png:
  • platform/chromium-linux/media/controls-layout-direction-expected.png:
  • platform/chromium-linux/media/media-controls-clone-expected.png:
  • platform/chromium-mac-leopard/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac-leopard/media/audio-repaint-expected.png:
  • platform/chromium-mac-leopard/media/controls-after-reload-expected.png:
  • platform/chromium-mac-snowleopard/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-layout-direction-expected.png:
  • platform/chromium-mac-snowleopard/media/media-controls-clone-expected.png:
  • platform/chromium-mac/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac/media/audio-repaint-expected.png:
  • platform/chromium-mac/media/controls-after-reload-expected.png:
  • platform/chromium-mac/media/controls-layout-direction-expected.png:
  • platform/chromium-mac/media/media-controls-clone-expected.png:
  • platform/chromium-win/media/audio-controls-rendering-expected.png:
  • platform/chromium-win/media/audio-repaint-expected.png:
  • platform/chromium-win/media/controls-after-reload-expected.png:
  • platform/chromium-win/media/controls-layout-direction-expected.png:
  • platform/chromium-win/media/media-controls-clone-expected.png:
2:21 PM Changeset in webkit [115748] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebKit/efl/ewk/ewk_view.cpp

Correct misuse of LayoutUnits for scroll coordinates (we only scroll in full-pixels).

1:50 PM Changeset in webkit [115747] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Allow a pre-targeted node to be specified when dispatching a GestureTap event
https://bugs.webkit.org/show_bug.cgi?id=85296

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-05-01
Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=85101

The new parameter will be used and tested in this patch.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureTap):

The new preTargetedNode parameter can be used to pass in the Node that is
the target of the GestureTap event. If this parameter is used, adjustedPoint
is changed to be the center of the Node's bounding rectangle.

  • page/EventHandler.h:

(EventHandler):

1:15 PM Changeset in webkit [115746] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebCore

Crash calling disconnectFrame on a DOMWindowExtension a second time.
https://bugs.webkit.org/show_bug.cgi?id=85301

Reviewed by Darin Adler.

DOMWindowExtension::disconnectFrame assumed it would only be called when there was a frame
to disconnect. However, DOMWindow's destructor invokes disconnectFrame on all its
DOMWindowProperties, even if it already did so when it entered the page cache.

  • page/DOMWindowExtension.cpp:

(WebCore::DOMWindowExtension::disconnectFrame):
Don't do anything if the frame has already been disconnected.

12:27 PM Changeset in webkit [115745] by commit-queue@webkit.org
  • 4 edits
    2 deletes in trunk

Source/WebCore: Temporarily remove webkitSourceAddId() & webkitSourceRemoveId() from DOM
until the rest of the Media Source v0.5 methods are implemented. This is
to prevent ambiguity about whether v0.5 is fully supported or not.
https://bugs.webkit.org/show_bug.cgi?id=85295

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-05-01
Reviewed by Eric Carlson.

No new tests. Removing methods from DOM so relevant tests are removed.

  • html/HTMLMediaElement.idl:

LayoutTests: Temporarily removing tests for webkitSourceAddId() & webkitSourceRemoveId()
until the rest of the Media Source v0.5 methods are implemented.
https://bugs.webkit.org/show_bug.cgi?id=85295

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-05-01
Reviewed by Eric Carlson.

  • http/tests/media/media-source/webm/video-media-source-add-and-remove-ids-expected.txt: Removed.
  • http/tests/media/media-source/webm/video-media-source-add-and-remove-ids.html: Removed.
  • platform/chromium/test_expectations.txt:
12:21 PM Changeset in webkit [115744] by eae@chromium.org
  • 502 edits
    10 copies in branches/subpixellayout

Merge trunk changes up until 115741 into subpixel branch.

12:05 PM Changeset in webkit [115743] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

IndexedDB: stale index entries may not be removed in some cases
https://bugs.webkit.org/show_bug.cgi?id=85224

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-05-01
Reviewed by Ojan Vafai.

Ensure that stale index entries are removed when the corresponding
object store entry no longer exists.

No new tests. Addresses a performance / storage leak that is
not amenable to verification in a layout test.

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore):

11:50 AM Changeset in webkit [115742] by eric@webkit.org
  • 1 edit
    63 adds in trunk/LayoutTests

Add seamless test cases (all of these will pass as we land the implementation patches)
https://bugs.webkit.org/show_bug.cgi?id=85251

Reviewed by Adam Barth.

These are all test cases which were written as part of implementing seamless
on my github branch: https://github.com/eseidel/webkit/compare/master...seamless
All of these will pass once the implementation is landed, which I am uploading
as a series of patches as we speak. Because the each of pieces
affects variety of tests, it seems easiest to read the implmentation
diffs if I land all the tests up-front.

  • fast/frames/seamless/resources/css-cascade-child.html: Added.
  • fast/frames/seamless/resources/done.html: Added.
  • fast/frames/seamless/resources/nested-seamless.html: Added.
  • fast/frames/seamless/resources/quirks-square.html: Added.
  • fast/frames/seamless/resources/square.html: Added.
  • fast/frames/seamless/resources/two-inline-blocks.html: Added.
  • fast/frames/seamless/seamless-basic-expected.txt: Added.
  • fast/frames/seamless/seamless-basic.html: Added.
  • fast/frames/seamless/seamless-css-cascade-expected.txt: Added.
  • fast/frames/seamless/seamless-css-cascade.html: Added.
  • fast/frames/seamless/seamless-designMode-expected.txt: Added.
  • fast/frames/seamless/seamless-designMode.html: Added.
  • fast/frames/seamless/seamless-float-expected.txt: Added.
  • fast/frames/seamless/seamless-float.html: Added.
  • fast/frames/seamless/seamless-form-get-expected.txt: Added.
  • fast/frames/seamless/seamless-form-get-named-expected.txt: Added.
  • fast/frames/seamless/seamless-form-get-named.html: Added.
  • fast/frames/seamless/seamless-form-get-override-expected.txt: Added.
  • fast/frames/seamless/seamless-form-get-override.html: Added.
  • fast/frames/seamless/seamless-form-get.html: Added.
  • fast/frames/seamless/seamless-form-post-expected.txt: Added.
  • fast/frames/seamless/seamless-form-post-named-expected.txt: Added.
  • fast/frames/seamless/seamless-form-post-named.html: Added.
  • fast/frames/seamless/seamless-form-post-override-expected.txt: Added.
  • fast/frames/seamless/seamless-form-post-override.html: Added.
  • fast/frames/seamless/seamless-form-post.html: Added.
  • fast/frames/seamless/seamless-hyperlink-expected.txt: Added.
  • fast/frames/seamless/seamless-hyperlink-named-expected.txt: Added.
  • fast/frames/seamless/seamless-hyperlink-named.html: Added.
  • fast/frames/seamless/seamless-hyperlink-override-expected.txt: Added.
  • fast/frames/seamless/seamless-hyperlink-override.html: Added.
  • fast/frames/seamless/seamless-hyperlink.html: Added.
  • fast/frames/seamless/seamless-inline-expected.txt: Added.
  • fast/frames/seamless/seamless-inline.html: Added.
  • fast/frames/seamless/seamless-min-max-expected.txt: Added.
  • fast/frames/seamless/seamless-min-max.html: Added.
  • fast/frames/seamless/seamless-nested-expected.txt: Added.
  • fast/frames/seamless/seamless-nested.html: Added.
  • fast/frames/seamless/seamless-quirks-expected.txt: Added.
  • fast/frames/seamless/seamless-quirks.html: Added.
  • fast/frames/seamless/seamless-sandbox-flag-expected.txt: Added.
  • fast/frames/seamless/seamless-sandbox-flag.html: Added.
  • fast/frames/seamless/seamless-sandbox-srcdoc-expected.txt: Added.
  • fast/frames/seamless/seamless-sandbox-srcdoc.html: Added.
  • fast/frames/seamless/seamless-window-location-expected.txt: Added.
  • fast/frames/seamless/seamless-window-location-href-expected.txt: Added.
  • fast/frames/seamless/seamless-window-location-href.html: Added.
  • fast/frames/seamless/seamless-window-location-replace-expected.txt: Added.
  • fast/frames/seamless/seamless-window-location-replace.html: Added.
  • fast/frames/seamless/seamless-window-location-sandbox-expected.txt: Added.
  • fast/frames/seamless/seamless-window-location-sandbox.html: Added.
  • fast/frames/seamless/seamless-window-location.html: Added.
  • fast/frames/seamless/seamless-window-open-expected.txt: Added.
  • fast/frames/seamless/seamless-window-open-override-expected.txt: Added.
  • fast/frames/seamless/seamless-window-open-override.html: Added.
  • fast/frames/seamless/seamless-window-open.html: Added.
  • http/tests/security/seamless/resources/square.html: Added.
  • http/tests/security/seamless/seamless-cross-origin-expected.txt: Added.
  • http/tests/security/seamless/seamless-cross-origin.html: Added.
  • http/tests/security/seamless/seamless-sandbox-srcdoc-expected.txt: Added.
  • http/tests/security/seamless/seamless-sandbox-srcdoc.html: Added.
11:33 AM Changeset in webkit [115741] by kareng@chromium.org
  • 1 add in branches/chromium/1123/codereview.settings

adding codereview.setings so we can drover

11:31 AM Changeset in webkit [115740] by kareng@chromium.org
  • 1 copy in branches/chromium/1123

branching for chrome

11:23 AM Changeset in webkit [115739] by gavinp@chromium.org
  • 2 edits in trunk/Source/Platform

[Chromium] Fix WebPrerender::referrer() thunk.
https://bugs.webkit.org/show_bug.cgi?id=85290

Reviewed by Dimitri Glazkov.

  • chromium/public/WebPrerender.h:

(WebKit::WebPrerender::referrer):

11:18 AM Changeset in webkit [115738] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebKit/efl/ewk/ewk_frame.cpp

Fixing a pixel snapping/build issue in EFL.

11:04 AM Changeset in webkit [115737] by commit-queue@webkit.org
  • 2 edits in trunk

[GTK] Fix gstreamer detection during configure
https://bugs.webkit.org/show_bug.cgi?id=84325

Patch by Landry Breuil <landry@openbsd.org> on 2012-05-01
Reviewed by Philippe Normand.

  • configure.ac: Fix GSTREAMER_REQUIRED_VERSION and

GSTREAMER_PLUGINS_BASE_REQUIRED_VERSION assignments.

10:40 AM Changeset in webkit [115736] by igor.o@sisa.samsung.com
  • 2 edits in trunk/Source/WebCore

Use HashMap<OwnPtr> for CounterMap in RenderCounter
https://bugs.webkit.org/show_bug.cgi?id=85294

Reviewed by Eric Seidel.

  • rendering/RenderCounter.cpp:

(WebCore):
(WebCore::makeCounterNode):
(WebCore::RenderCounter::destroyCounterNodes):

10:19 AM Changeset in webkit [115735] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[chromium] Accept four parameters when dispatching a WebInputEvent::GestureTap in chromium DRT eventSender
https://bugs.webkit.org/show_bug.cgi?id=85289

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-05-01
Reviewed by Eric Seidel.

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::gestureEvent):

This change will allow for testing of WK85101. Currently no tests use the extra
parameters deltaX and deltaY.

10:08 AM Changeset in webkit [115734] by enne@google.com
  • 2 edits in branches/chromium/1084/Source/WebCore/platform/graphics/chromium/cc

Merged 115281 - [chromium] Hold video provider lock from willDraw to didDraw
https://bugs.webkit.org/show_bug.cgi?id=84805

Reviewed by James Robinson.

Note: merged by hand due to conflicts.

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp: (WebCore::CCVideoLayerImpl::willDraw): (WebCore): (WebCore::CCVideoLayerImpl::willDrawInternal): (WebCore::CCVideoLayerImpl::appendQuads): (WebCore::CCVideoLayerImpl::didDraw):
  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:
9:59 AM Changeset in webkit [115733] by jchaffraix@webkit.org
  • 4 edits
    1 copy in trunk/Source/WebKit/chromium

WebKit test RenderTableCellDeathTest.CanSetRow is failing as of r115705
https://bugs.webkit.org/show_bug.cgi?id=85274

Reviewed by Ojan Vafai.

The tests were crashing as we were creating a RenderTableCell without any RenderTableRow parent
which shouldn't happen inside the render tree.

Using RenderTableCell to access RenderTableRow was artificial and the checks have now been moved
to using a RenderTableRow directly.

  • WebKit.gyp:
  • WebKit.gypi:

Added the new file.

  • tests/RenderTableCellTest.cpp:

Removed the row index tests as they are now in the following file.

  • tests/RenderTableRowTest.cpp: Copied from Source/WebKit/chromium/tests/RenderTableCellTest.cpp.

Changed a bit the row index tests and re-enabled them.

9:52 AM Changeset in webkit [115732] by eae@chromium.org
  • 512 edits
    18 copies
    2 deletes in branches/subpixellayout

Merge trunk changes up until 115722 into subpixel branch.

9:41 AM Changeset in webkit [115731] by enne@google.com
  • 10 edits in branches/chromium/1084/Source

Merge 115278 - [chromium] Prevent CCLayerImpl::willDraw/didDraw mismatches
https://bugs.webkit.org/show_bug.cgi?id=84812

Reviewed by James Robinson.

Note: this did not merge cleanly, and was merged by hand.

Source/WebCore:

Because some layers lock/unlock resources, it needs to be guaranteed
that if willDraw is called on a layer then didDraw will also be called
on that layer before another willDraw or before layer destruction. Add
asserts to make sure that this is the case.

willDraw is called via CCLayerTreeHostImpl::prepareToDraw ->
calculateRenderPasses. didDraw was previously called in
CCLayerTreeHostImpl::drawLayers. Sometimes drawLayers was being
skipped by the caller of these functions based on what prepareToDraw
returned (causing didDraw to not be called). Fix this by having an
explicit step to call didDraw on all layers. This new didDrawAllLayers
function must be called if and only if prepareToDraw is called.

Tested by existing tests via new asserts in CCLayerImpl.

  • platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::CCLayerImpl): (WebCore::CCLayerImpl::~CCLayerImpl): (WebCore::CCLayerImpl::willDraw): (WebCore): (WebCore::CCLayerImpl::didDraw):
  • platform/graphics/chromium/cc/CCLayerImpl.h: (CCLayerImpl):
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: (WebCore::CCLayerTreeHostImpl::drawLayers): (WebCore::CCLayerTreeHostImpl::didDrawAllLayers): (WebCore):
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: (CCLayerTreeHostImpl):
  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp: (WebCore::CCScrollbarLayerImpl::willDraw): (WebCore::CCScrollbarLayerImpl::didDraw):
  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp: (WebCore::CCSingleThreadProxy::doComposite):
  • platform/graphics/chromium/cc/CCTextureLayerImpl.cpp: (WebCore::CCTextureLayerImpl::willDraw):
  • platform/graphics/chromium/cc/CCThreadProxy.cpp: (WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal):
  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp: (WebCore::CCVideoLayerImpl::willDraw): (WebCore::CCVideoLayerImpl::didDraw):

Source/WebKit/chromium:

Update all tests to call CCLayerTreeHostImpl::didDrawAllLayers if they
call CCLayerTreeHostImpl::prepareToDraw.

  • tests/CCLayerTreeHostImplTest.cpp: (WebKitTests::CCLayerTreeHostImplTest::initializeLayerRendererAndDrawFrame): (WebKitTests::TEST_F):
9:10 AM Changeset in webkit [115730] by pdr@google.com
  • 7 edits
    2 adds in trunk

Skip building instance tree for disallowed target
https://bugs.webkit.org/show_bug.cgi?id=85202

Reviewed by Nikolas Zimmermann.

Source/WebCore:

When the target of a use is disallowed (e.g., a mask element) we can
skip building the instance tree because the shadow tree will be
skipped as well.

Test: svg/custom/animate-disallowed-mask-element.svg

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::buildInstanceTree):

LayoutTests:

  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-3-expected.txt:
  • platform/gtk/svg/custom/use-on-disallowed-foreign-object-3-expected.txt:
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-3-expected.txt:
  • platform/qt/svg/custom/use-on-disallowed-foreign-object-3-expected.txt:
  • svg/custom/animate-disallowed-mask-element-expected.txt: Added.
  • svg/custom/animate-disallowed-mask-element.svg: Added.
8:52 AM Changeset in webkit [115729] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

Print out stderr output of ImageDiff if it is present
https://bugs.webkit.org/show_bug.cgi?id=85285

Reviewed by Philippe Normand.

Log the stderr output of ImageDiff as a warning if present. This is
especially helpful when ImageDiff crashes and stderr data might contain
relevant information about what caused the crash.

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._read_image_diff):

8:32 AM Changeset in webkit [115728] by mifenton@rim.com
  • 5 edits
    1 add in trunk

Add special attribute for alternate selection touch handling.
https://bugs.webkit.org/show_bug.cgi?id=85284

Reviewed by Antonio Gomes.

PR 152975.

.:

Add manual test for -bb-selection-touchoverride.

Reviewed Internally by Gen Mak.

  • ManualTests/blackberry/selection-touch-override.html: Added.

Source/WebKit/blackberry:

Add attribute -bb-selection-touchoverride to override
touch handling on selection overlay.

Reviewed Internally by Gen Mak.

  • Api/WebPageClient.h:
  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::inputNodeOverridesTouch):
(WebKit):
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):

  • WebKitSupport/SelectionHandler.h:

(SelectionHandler):

8:30 AM Changeset in webkit [115727] by kenneth@webkit.org
  • 6 edits in trunk

[Qt] Add an experimental extension to set the min. contents width
https://bugs.webkit.org/show_bug.cgi?id=85281

Reviewed by Antonio Gomes.

Source/WebKit2:

Add the experimental property preferredMinimumContentsWidth: which
can be used to set the minimum contents width when not overriden by
the page itself.

Default value is set to 0, which defines normal [desktop] behaviour.

  • Shared/WebPreferencesStore.h:

(WebKit):

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewExperimental::preferredMinimumContentsWidth):
(QQuickWebViewExperimental::setPreferredMinimumContentsWidth):

  • UIProcess/API/qt/qquickwebview_p.h:

Tools:

  • MiniBrowser/qt/qml/BrowserWindow.qml:

Set the value of preferredMinimumContentsWidth to 980.

8:18 AM Changeset in webkit [115726] by Nikolas Zimmermann
  • 43 edits
    4 adds in trunk

Accumulation for values-animation is broken
https://bugs.webkit.org/show_bug.cgi?id=85158

Reviewed by Darin Adler.

Source/WebCore:

Example:
<rect width="999" height="100" fill="green"/>

<animate begin="0s" values="0; 30; 20" accumulate="sum" repeatCount="5" dur="2s"/>

</rect>

The rect should animate like this:
0.000s -> 0
0.500s -> 15
1.000s -> 30
1.500s -> 25
1.999s -> 20
2.000s -> 20 (first accumulation, starts accumulating from the last set value, here '20').
2.500s -> 45
3.000s -> 50
3.500s -> 45
3.999s -> 40
4.000s -> 40 (second accumulation)
etc.

This is currently broken for values-animation. The accumulation should happen after a full cycle of the values animation ran (aka. at the end of the duration).
A values animation works like this: iterate over the list of values, and calculate a 'from' and 'to' value for a given time. Example for values="0; 30; 20" dur="2s":

  • 0.0s .. 1.0s -> from=0, to=30
  • 1.0s .. 2.0s -> from=30, to=20

Accumulation currently is taken into account at each interval for a values-animation instead of the end of the cycle. Fix that
by passing an additional 'toAtEndOfDuration' type to calculateAnimatedValue() which is used for accumulation instead of the
current 'to' value.

Test: svg/animations/accumulate-values-width-animation.html

  • svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::calculateAnimatedValue):

  • svg/SVGAnimateElement.h:

(SVGAnimateElement):

  • svg/SVGAnimateMotionElement.cpp:

(WebCore::SVGAnimateMotionElement::calculateAnimatedValue):

  • svg/SVGAnimateMotionElement.h:

(SVGAnimateMotionElement):

  • svg/SVGAnimatedAngle.cpp:

(WebCore::SVGAnimatedAngleAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedAngle.h:

(SVGAnimatedAngleAnimator):

  • svg/SVGAnimatedBoolean.cpp:

(WebCore::SVGAnimatedBooleanAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedBoolean.h:

(SVGAnimatedBooleanAnimator):

  • svg/SVGAnimatedColor.cpp:

(WebCore::SVGAnimatedColorAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedColor.h:

(SVGAnimatedColorAnimator):

  • svg/SVGAnimatedEnumeration.cpp:

(WebCore::SVGAnimatedEnumerationAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedEnumeration.h:

(SVGAnimatedEnumerationAnimator):

  • svg/SVGAnimatedInteger.cpp:

(WebCore::SVGAnimatedIntegerAnimator::calculateAnimatedInteger):
(WebCore::SVGAnimatedIntegerAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedInteger.h:

(SVGAnimatedIntegerAnimator):

  • svg/SVGAnimatedIntegerOptionalInteger.cpp:

(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedIntegerOptionalInteger.h:

(SVGAnimatedIntegerOptionalIntegerAnimator):

  • svg/SVGAnimatedLength.cpp:

(WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedLength.h:

(SVGAnimatedLengthAnimator):

  • svg/SVGAnimatedLengthList.cpp:

(WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedLengthList.h:

(SVGAnimatedLengthListAnimator):

  • svg/SVGAnimatedNumber.cpp:

(WebCore::SVGAnimatedNumberAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedNumber.h:

(SVGAnimatedNumberAnimator):

  • svg/SVGAnimatedNumberList.cpp:

(WebCore::SVGAnimatedNumberListAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedNumberList.h:

(SVGAnimatedNumberListAnimator):

  • svg/SVGAnimatedNumberOptionalNumber.cpp:

(WebCore::SVGAnimatedNumberOptionalNumberAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedNumberOptionalNumber.h:

(SVGAnimatedNumberOptionalNumberAnimator):

  • svg/SVGAnimatedPath.cpp:

(WebCore::SVGAnimatedPathAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedPath.h:

(SVGAnimatedPathAnimator):

  • svg/SVGAnimatedPointList.cpp:

(WebCore::SVGAnimatedPointListAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedPointList.h:

(SVGAnimatedPointListAnimator):

  • svg/SVGAnimatedPreserveAspectRatio.cpp:

(WebCore::SVGAnimatedPreserveAspectRatioAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedPreserveAspectRatio.h:

(SVGAnimatedPreserveAspectRatioAnimator):

  • svg/SVGAnimatedRect.cpp:

(WebCore::SVGAnimatedRectAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedRect.h:

(SVGAnimatedRectAnimator):

  • svg/SVGAnimatedString.cpp:

(WebCore::SVGAnimatedStringAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedString.h:

(SVGAnimatedStringAnimator):

  • svg/SVGAnimatedTransformList.cpp:

(WebCore::SVGAnimatedTransformListAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedTransformList.h:

(SVGAnimatedTransformListAnimator):

  • svg/SVGAnimatedTypeAnimator.h:

(SVGAnimatedTypeAnimator):

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::currentValuesForValuesAnimation):
(WebCore::SVGAnimationElement::updateAnimation):

  • svg/SVGAnimationElement.h:

(WebCore::SVGAnimationElement::animateAdditiveNumber):
(SVGAnimationElement):

LayoutTests:

  • svg/animations/accumulate-values-width-animation-expected.txt: Added.
  • svg/animations/accumulate-values-width-animation.html: Added.
  • svg/animations/resources/accumulate-values-width-animation.svg: Added.
  • svg/animations/script-tests/accumulate-values-width-animation.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(sample6):
(sample7):
(sample8):
(sample9):
(sample10):
(sample11):
(executeTest):

8:08 AM Changeset in webkit [115725] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=85231
Fixed position objects that are removed from the DOM don't kick off
fixed position recalculation
-and corresponding-
<rdar://problem/11297916>

Reviewed by Darin Adler.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::willBeDestroyed):

7:57 AM Changeset in webkit [115724] by rniwa@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

drag of links with styled text drop as links with plain text
https://bugs.webkit.org/show_bug.cgi?id=19386

Reviewed by Hajime Morita.

Add a regression test since the said bug appears to have been fixed on ToT WebKit.

  • editing/pasteboard/drag-drop-url-with-style-expected.txt: Added.
  • editing/pasteboard/drag-drop-url-with-style.html: Added.
7:53 AM Changeset in webkit [115723] by kenneth@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Stop repeating timers which should only fire once
https://bugs.webkit.org/show_bug.cgi?id=85277

Reviewed by Antonio Gomes.

The TapGestureRecognizer uses QBasicTimers which are
repeating timers, so stop then when they fire.

  • UIProcess/qt/QtTapGestureRecognizer.cpp:

(WebKit::QtTapGestureRecognizer::highlightTimeout):
(WebKit::QtTapGestureRecognizer::singleTapTimeout):
(WebKit::QtTapGestureRecognizer::tapAndHoldTimeout):

7:20 AM Changeset in webkit [115722] by kling@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

Remove Mac WK2-specific result for svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm.

  • platform/mac-wk2/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Removed.
5:55 AM Changeset in webkit [115721] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

WebKit unit tests RenderTableCellDeathTest.CanSetRow* are failing as of r115705
https://bugs.webkit.org/show_bug.cgi?id=85274

Not reviewed: test disabled.

  • tests/RenderTableCellTest.cpp:
5:28 AM Changeset in webkit [115720] by kling@webkit.org
  • 3 edits in trunk/LayoutTests

Fix test regression introduced by r115086.
https://bugs.webkit.org/show_bug.cgi?id=84566

Patch by Yuzhu Shen <yzshen@chromium.org> on 2012-05-01
Reviewed by Pavel Feldman.

  • inspector/network-status-non-http.html:
  • platform/qt/Skipped:
5:12 AM Changeset in webkit [115719] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

WebKit test RenderTableCellDeathTest.CanSetRow is failing as of r115705
https://bugs.webkit.org/show_bug.cgi?id=85274

Not reviewed: test disabled.

The test is based on the standalone cell, while the new logic
requires parent to be present upon the row index set.

  • tests/RenderTableCellTest.cpp:
4:18 AM Changeset in webkit [115718] by hbono@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Regression r113405 ContextMenuImpl does not set a misspelled word
https://bugs.webkit.org/show_bug.cgi?id=85271

Reviewed by Kent Tamura.

This change calls selectMisspelledWord() to get a misspelled word so Chrome can
set the misspelledWord variable without selecting text.

  • src/ContextMenuClientImpl.cpp:

(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

3:47 AM Changeset in webkit [115717] by tkent@chromium.org
  • 8 edits
    1 copy
    1 move in trunk/LayoutTests

[Chromium] Rebaseline for recent changes about <input type=date>.

  • platform/chromium-linux/fast/forms/date/date-appearance-expected.png:
  • platform/chromium-linux/fast/forms/date/date-appearance-expected.txt:
  • platform/chromium-mac/fast/forms/date/date-appearance-expected.png:
  • platform/chromium-mac/fast/forms/date/date-appearance-expected.txt:
  • platform/chromium-mac/fast/forms/date/date-input-visible-strings-expected.txt: Copied from LayoutTests/platform/chromium/fast/forms/date/date-input-visible-strings-expected.txt.
  • platform/chromium-win/fast/forms/date/date-appearance-expected.png:
  • platform/chromium-win/fast/forms/date/date-appearance-expected.txt:
  • platform/chromium-win/fast/forms/date/date-input-visible-strings-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/date/date-input-visible-strings-expected.txt.
  • platform/chromium/test_expectations.txt:
2:15 AM Changeset in webkit [115716] by danakj@chromium.org
  • 2 edits in trunk/Source/WebCore

Early-out for subtracting a non-intersecting region
https://bugs.webkit.org/show_bug.cgi?id=85258

Reviewed by Hajime Morita.

Given regions A and B, if the bounds of the regions do not intersect,
then the regions themselves do not intersect. If the intersection of
A and B is empty, then A subtract B == A.

  • platform/graphics/Region.cpp:

(WebCore::Region::subtract):

1:43 AM Changeset in webkit [115715] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update for r115713.
https://bugs.webkit.org/show_bug.cgi?id=84935

  • platform/chromium/test_expectations.txt:

Mark TEXT for date-input-visible-strings.html

1:39 AM Changeset in webkit [115714] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update.

  • platform/gtk/test_expectations.txt: media/track/track-mode.html

is still flaky as per bug 83878.

12:54 AM Changeset in webkit [115713] by tkent@chromium.org
  • 5 edits
    4 adds in trunk/Source

[Chromium/Windows] Add LocalizedDateWin
https://bugs.webkit.org/show_bug.cgi?id=84935

Reviewed by Kentaro Hara.

Source/WebCore:

LocalizedDateICU.cpp doesn't reflect system settings. So there were some
problems such as <input type=date> doesn't use system's date format.

We need to use Windows API to get a date format and calendar parameters.

We obtain a date format like "MM/dd/yy" via Windows API, and
format/parse dates for the format by our own code because Windows API
can't handle years older than 1601 and doesn't have date parsing API.

Unit test: Source/WebKit/chromium/tests/LocaleWinTest.cpp

  • WebCore.gypi: Add LocalizedDateWin.cpp.
  • WebCore.gyp/WebCore.gyp:

For Windows, remove LocalizedDateICU.cpp and add LocalizedDateWin.cpp.
All of *Win.cpp files are excluded by default.

  • platform/text/LocaleWin.cpp: Added.

(WebCore::LocaleWin::LocaleWin):
(WebCore::LocaleWin::create):
(WebCore::LocaleWin::currentLocale):
(WebCore::LocaleWin::~LocaleWin):
(WebCore::LocaleWin::getLocaleInfoString):
A helper function to obtain a string by GetLocaleInfo().
(WebCore::LocaleWin::initializeShortMonthLabels):
Obtain short month names from Windows.

(WebCore::DateFormatToken): A struct to represent a token in a date format.
e.g. A format string "MM/dd/yy" generates five DateFormatToken:

Month2, Literal, Day2, Literal, Year2.

(isEraSymbol): A readability helper function.
(isYearSymbol): ditto.
(isMonthSymbol): ditto.
(isDaySymbol): ditto.
(countContinuousLetters):
(commitLiteralToken): A helper for parseDateFormat().
(parseDateFormat):
Parse a format string, and generate a list of DateFormatToken.

(WebCore::parseNumber): A helper for parseDate().
(WebCore::LocaleWin::parseNumberOrMonth): ditto.
(WebCore::LocaleWin::parseDate):
Parse a user-provided date string by matching with a DateFormatToken list.

(WebCore::appendNumber): A helper for formatDate().
(WebCore::appendTwoDigitsNumber): ditto. Write at least two digits.
(WebCore::appendFourDigitsNumber): ditto. Write at least four digits.
(WebCore::LocaleWin::formatDate):
Format a DateComponents by iterating a DateFormatToken list.

(WebCore::LocaleWin::initializeShortDateTokens):
(WebCore::substituteLabelsIntoFormat):
Creates a user-visible format string by iterating a DateFormatToken list.
(WebCore::LocaleWin::dateFormatText):
(WebCore::LocaleWin::initializeMonthLabels):
Creates month names by Windows API.
(WebCore::LocaleWin::initializeWeekDayShortLabels):

Creates day names by Windows API.

(WebCore::LocaleWin::monthLabels):
Public accessor function for month names.
(WebCore::LocaleWin::weekDayShortLabels):
Public accessor function for day names.

  • platform/text/LocaleWin.h: Added.
  • platform/text/LocalizedDateWin.cpp:

Added. The following functions simply delegate to LocaleWin::currentLocale().
(WebCore::parseLocalizedDate):
(WebCore::formatLocalizedDate):
(WebCore::localizedDateFormatText):
(WebCore::monthLabels):
(WebCore::weekDayShortLabels):
(WebCore::firstDayOfWeek):

Source/WebKit/chromium:

Add test for LocaleWin.cpp.

  • WebKit.gypi:
  • tests/LocaleWinTest.cpp: Added.

(msForDate): A helper function.
(TEST):

Note: See TracTimeline for information about the timeline view.