Timeline



May 13, 2012:

11:47 PM Changeset in webkit [116925] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

DFG performs incorrect constant folding on double-to-uint32 conversion in
Uint32Array PutByVal
https://bugs.webkit.org/show_bug.cgi?id=86330

Source/JavaScriptCore:

Reviewed by Darin Adler.

static_cast<int>(d) is wrong, since JS semantics require us to use toInt32(d).
In particular, C++ casts on typical hardware (like x86 and similar) will
return 0x80000000 for double values that are out of range of the int32 domain
(i.e. less than -231 or greater than or equal to 231). But JS semantics call
for wrap-around; for example the double value 4294967297 ought to become the
int32 value 1, not 0x80000000.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):

LayoutTests:

Rubber stamped by Darin Adler.

  • fast/js/dfg-uint32array-overflow-constant-expected.txt: Added.
  • fast/js/dfg-uint32array-overflow-constant.html: Added.
  • fast/js/script-tests/dfg-uint32array-overflow-constant.js: Added.

(foo):

11:44 PM Changeset in webkit [116924] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

[chromium] Remove platform/image-decoders/xbm from WebCore.gyp
https://bugs.webkit.org/show_bug.cgi?id=86333

Reviewed by Adam Barth.

No new tests. No change in behavior.

  • WebCore.gyp/WebCore.gyp: Remove reference to platform/image-decoders/xbm

since that directory was removed from the repository long ago.

11:42 PM Changeset in webkit [116923] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip new asserting and failing test to paint the bots green.

  • platform/qt/Skipped:
11:27 PM Changeset in webkit [116922] by noel.gordon@gmail.com
  • 3 edits in trunk/LayoutTests

Unreviewed test fix: these calc() tests are dumpAsText().

  • css3/calc/transition-crash.html:
  • css3/calc/transition-crash2.html:
11:23 PM Changeset in webkit [116921] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Several dom tests are failing after r116828
https://bugs.webkit.org/show_bug.cgi?id=86334

Unreviewed EFL gardening.

Move fast/dom/CSSStyleDeclaration/empty-string-property.html and
fast/dom/collection-null-like-arguments.html to test_expectations.txt.
Those tests are failing due to a regression introduced in r116828.

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-13

  • platform/efl/test_expectations.txt:
10:58 PM Changeset in webkit [116920] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

[Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=85591

Unreviewed, remove test expectations for plenty of sputnik tests that
were specific for debug builds. These tests are now consistently
passing on all the builders but that was only noticed when migration to
using test_expectations.txt was complete, meaning their test expectations
were out of date and moreover erroneous.

  • platform/gtk/test_expectations.txt:
10:34 PM Changeset in webkit [116919] by Darin Adler
  • 2 edits in trunk/Source/WebCore

[CG] Unneeded CFRetain/Release of CGImageRef in BitmapImage::draw
https://bugs.webkit.org/show_bug.cgi?id=86332

Reviewed by Dan Bernstein.

  • platform/graphics/cg/ImageCG.cpp:

(WebCore::BitmapImage::draw): Don't use RetainPtr since the result of
the function is used before anything could call CFRelease on it.

10:32 PM Changeset in webkit [116918] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

[Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=85591

Unreviewed, remove test expectations for another test which
consistently passess on all the Gtk builders.

  • platform/gtk/test_expectations.txt:
10:26 PM Changeset in webkit [116917] by Darin Adler
  • 5 edits in trunk/Source/WebCore

Listeners map uses raw pointers, but should use OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=86298

Reviewed by Dan Bernstein.

  • bindings/js/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::~PageScriptDebugServer): Removed call
to deleteAllValues since the destructor now takes care of this
(WebCore::PageScriptDebugServer::addListener): Changed idiom of the add
function call here to use adoptPtr.
(WebCore::PageScriptDebugServer::removeListener): Added a now-needed
call to get and removed a now-uneeeded call to delete.

  • bindings/js/PageScriptDebugServer.h: Changed the key type of

PageListenersMap to OwnPtr.

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::~ScriptDebugServer): Removed code to delete
the values in m_pageListenersMap. This map was never used and so I have
removed it.

  • bindings/js/ScriptDebugServer.h: Removed the type PageListenersMap

and the unused data member, m_pageListenersMap.

10:23 PM Changeset in webkit [116916] by rniwa@webkit.org
  • 9 edits
    4 adds in trunk

performance tests should be able to measure runs/sec rather than time
https://bugs.webkit.org/show_bug.cgi?id=86021

Reviewed by Ojan Vafai.

PerformanceTests:

Add PerfTestRunner.runPerSecond. It uses _runLoop but replaces _runner by _perSecondRunner
to compute runs/s of runFunction.

When _perSecondRunner is called for the first time, i.e. _completedRuns is 0 (notice this is -1
in regular run/_runner), it slowly increases the number of function calls to runFunction between
time measurements in order to discount the time used by new Date() calls themselves until the
total time spent reaches 100 milliseconds.

By default, runPerSecond runs the test for at least 750 milliseconds in each run, and executes
21 runs, yielding the total run time of roughly 18 seconds. This is significantly faster than
most of existing performance tests. Also see http://ejohn.org/blog/accuracy-of-javascript-time/.

Finally, refactored the existing methods of PerfTestRunner to allow "runs/s" unit and share code.

  • Layout/flexbox-column-nowrap.html:
  • Layout/flexbox-column-wrap.html:
  • Layout/flexbox-row-nowrap.html:
  • Layout/flexbox-row-wrap.html:
  • resources/runner.js:

(PerfTestRunner.computeStatistics): Takes unit.
(PerfTestRunner.logStatistics): Ditto.
(PerfTestRunner._runLoop):
(PerfTestRunner._runner):
(PerfTestRunner.runPerSecond): Added.
(PerfTestRunner._perSecondRunner): Added. Called by _runLoop.
(PerfTestRunner._perSecondRunnerIterator): Added.

Tools:

Allow " runs/s" or " ms" to appear after numerical values in tests.

  • Scripts/webkitpy/performance_tests/perftest.py:

(PerfTest):

LayoutTests:

Add tests for PerfTestRunner.runPerSecond.

  • fast/harness/perftests/runs-per-second-iterations-expected.txt: Added.
  • fast/harness/perftests/runs-per-second-iterations.html: Added.
  • fast/harness/perftests/runs-per-second-log-expected.txt: Added.
  • fast/harness/perftests/runs-per-second-log.html: Added.
9:22 PM Changeset in webkit [116915] by commit-queue@webkit.org
  • 16 edits in trunk/Source/WebCore

[Forms] Move ValidityState methods implementation to another place
https://bugs.webkit.org/show_bug.cgi?id=86058

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-05-13
Reviewed by Kent Tamura.

This patch changes ValidityState class for limiting scope of
number/range input type related methods for introducing decimal
arithmetic.

Methods related to validation are moved from ValidateState to
input, select and textarea elements with virtual method based
dispatching via FormAssociateElement instead of tag name
dispatching so far for code simplification.

No new tests. This patch doesn't change behavior.

  • html/FormAssociatedElement.cpp:

(WebCore::FormAssociatedElement::customError): Added. Called from ValidateState. Returns custom error mssage in member variable.
(WebCore::FormAssociatedElement::patternMismatch): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::rangeOverflow): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::rangeUnderflow): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::stepMismatch): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::tooLong): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::typeMismatch): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::valid): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::valueMissing): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::customValidationMessage): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::validationMessage): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::setCustomValidity): Added. set custom error message.

  • html/FormAssociatedElement.h:

(FormAssociatedElement): Added new instance value m_customValidationMessage.

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::validationMessage): Removed. Note: HTMLInputElement, HTMLSelectElement, and HTMLTextAreaElement implement this method.
(WebCore::HTMLFormControlElement::setCustomValidity): Changed. Calls base class setCustomValidity.

  • html/HTMLFormControlElement.h:

(HTMLFormControlElement):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::isValidValue): Call m_inputType methods instead of HTMLInputElement's.
(WebCore::HTMLInputElement::tooLong): Call m_inputType methods instead of HTMLInputElement's.
(WebCore):
(WebCore::HTMLInputElement::typeMismatch): Move implementation to InputType.
(WebCore::HTMLInputElement::valueMissing): Move implementation to InputType.
(WebCore::HTMLInputElement::patternMismatch): Move implementation to InputType.
(WebCore::HTMLInputElement::rangeUnderflow): Move implementation to InputType.
(WebCore::HTMLInputElement::rangeOverflow): Move implementation to InputType.
(WebCore::HTMLInputElement::validationMessage): Move implementation to InputType.
(WebCore::HTMLInputElement::stepMismatch): Move implementation to InputType.
(WebCore::HTMLInputElement::isInRange): Call m_inputType methods instead of HTMLInputElement's.
(WebCore::HTMLInputElement::isOutOfRange): Call m_inputType methods instead of HTMLInputElement's.

  • html/HTMLInputElement.h:

(HTMLInputElement): Make tooLong method private.

  • html/HTMLObjectElement.h: Add "virtual" and "OVERRIDE".
  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::validationMessage): Added. Implementation for HTMLSelectElement.
(WebCore::HTMLSelectElement::valueMissing): Added. Implementation for HTMLSelectElement.

  • html/HTMLSelectElement.h:

(HTMLSelectElement): Added entries for newly added methods.

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::validationMessage): Added. Implementation for HTMLTextAreaElement.
(WebCore::HTMLTextAreaElement::valueMissing): Added. Implementation for HTMLTextAreaElement.
(WebCore::HTMLTextAreaElement::tooLong): Added. Implementation for HTMLTextAreaElement.

  • html/HTMLTextAreaElement.h:

(HTMLTextAreaElement): Added entries for newly added methods. Change tooLong and valueMissing private.

  • html/InputType.cpp:

(WebCore::InputType::stepMismatch): Change method signature.
(WebCore::InputType::alignValueForStep): Changed for calling InputClass instead of HTMLINputElement.
(WebCore::InputType::stepUpFromRenderer): Added. Moved from HTMLInputElement.
(WebCore::InputType::validationMessage): Added. Moved from HTMLInputElement.

  • html/InputType.h:

(InputType): Added entries for newly added methods and update methods signature.

  • html/ValidityState.cpp: Move actual implementation to FormAssociatedElement and derived classes for localizing implementation change of elements and input types.

(WebCore::ValidityState::validationMessage): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::valueMissing): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::typeMismatch): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::patternMismatch): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::tooLong): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::rangeUnderflow): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::rangeOverflow): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::stepMismatch): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::customError): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::valid):

  • html/ValidityState.h:

(ValidityState): Remove custom validation message related things.

8:30 PM Changeset in webkit [116914] by mikelawther@chromium.org
  • 5 edits
    4 adds in trunk

Heap-use-after-free in WTF::HashMap<int, WTF::RefPtr<WebCore::CalculationValue>, WTF::IntHash<unsigned int>, WTF::HashTrait
https://bugs.webkit.org/show_bug.cgi?id=85195

Source/WebCore:

This bug was caused by Length not understanding that calc expressions shouldn't be
blended - a Length with a calc expression handle was created without incrementing
the ref count of the expression. Length no longer attempts to blend calc expressions,
http://webkit.org/b/86160 has been filed to track expression blending. Fixing this fixed
the crash.

Once this was fixed, the RenderStyle diff checker thought the style was changing,
as Length didn't know how to compare calc expressions, resulting in an infinite
loop of style recalcs. Expressions can now compare themselves.

Reviewed by Darin Adler.

Tests: css3/calc/transition-crash.html

css3/calc/transition-crash2.html

  • platform/CalculationValue.h:

(WebCore::CalcExpressionNode::CalcExpressionNode):
(CalcExpressionNode):
(WebCore::CalcExpressionNode::type):
(CalculationValue):
(WebCore::CalculationValue::operator==):
(WebCore::CalcExpressionNumber::CalcExpressionNumber):
(WebCore::CalcExpressionNumber::operator==):
(CalcExpressionNumber):
(WebCore::CalcExpressionLength::CalcExpressionLength):
(WebCore::CalcExpressionLength::operator==):
(CalcExpressionLength):
(WebCore::CalcExpressionBinaryOperation::CalcExpressionBinaryOperation):
(WebCore::CalcExpressionBinaryOperation::operator==):
(CalcExpressionBinaryOperation):

  • platform/Length.cpp:

(WebCore::Length::isCalculatedEqual):
(WebCore):

  • platform/Length.h:

(WebCore::Length::operator==):
(Length):
(WebCore::Length::blend):

LayoutTests:

Reviewed by Darin Adler.

  • css3/calc/transition-crash-expected.txt: Added.
  • css3/calc/transition-crash.html: Added.
  • css3/calc/transition-crash2-expected.txt: Added.
  • css3/calc/transition-crash2.html: Added.
8:23 PM Changeset in webkit [116913] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed GTK test_expectations update.

  • platform/gtk/test_expectations.txt: Mark

media/video-controls-toggling.html as failing and move 2 other
media failures to the correct section.

7:17 PM WebKitGTK/1.8.x edited by kov@webkit.org
(diff)
7:16 PM Changeset in webkit [116912] by fpizlo@apple.com
  • 22 edits in branches/dfgopt/Source/JavaScriptCore

DFG should be able to optimize foo.apply(bar, arguments)
https://bugs.webkit.org/show_bug.cgi?id=86306

Reviewed by Gavin Barraclough.

Enables compilation of op_jneq_ptr and some forms of op_call_varargs.

Also includes a bunch of bug fixes that were made necessary by the increased
pressure on the CFG simplifier.

This is a 1-2% win on V8.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printCallOp):
(JSC::CodeBlock::CodeBlock):
(JSC::ProgramCodeBlock::canCompileWithDFGInternal):
(JSC::EvalCodeBlock::canCompileWithDFGInternal):
(JSC::FunctionCodeBlock::canCompileWithDFGInternal):

  • bytecode/CodeBlock.h:

(CodeBlock):
(JSC::CodeBlock::canCompileWithDFG):
(JSC::CodeBlock::canCompileWithDFGState):
(ProgramCodeBlock):
(EvalCodeBlock):
(FunctionCodeBlock):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::fixPossibleGetLocal):
(JSC::DFG::CFGSimplificationPhase::fixTailOperand):
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::getLocalLoadElimination):
(CSEPhase):
(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::debugFail):
(DFG):
(JSC::DFG::canHandleOpcodes):
(JSC::DFG::canCompileOpcodes):
(JSC::DFG::canInlineOpcodes):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):
(JSC::DFG::canInlineOpcode):
(DFG):
(JSC::DFG::canCompileOpcodes):
(JSC::DFG::canCompileEval):
(JSC::DFG::canCompileProgram):
(JSC::DFG::canCompileFunctionForCall):
(JSC::DFG::canCompileFunctionForConstruct):

  • dfg/DFGCommon.h:
  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGValidate.cpp:

(Validate):
(JSC::DFG::Validate::validate):
(JSC::DFG::Validate::checkOperand):
(JSC::DFG::Validate::reportValidationContext):

  • jit/JIT.cpp:

(JSC::JIT::emitOptimizationCheck):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):

  • jit/JIT.h:
  • jit/JITArithmetic.cpp:

(JSC::JIT::compileBinaryArithOp):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::privateCompilePutByIdTransition):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::privateCompilePutByIdTransition):

  • tools/CodeProfile.cpp:

(JSC::CodeProfile::sample):

7:10 PM WebKitGTK/1.8.x edited by kov@webkit.org
(diff)
6:48 PM Changeset in webkit [116911] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed GTK test_expectations update.

  • platform/gtk/test_expectations.txt: Flag another 2 media failures.
6:40 PM Changeset in webkit [116910] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed GTK test_expectations update.

  • platform/gtk/test_expectations.txt: Flag failing media test.
4:48 PM Changeset in webkit [116909] by Darin Adler
  • 4 edits in trunk/Source/WebCore

Roll out local changes accidentally landed in r116905.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cg/GraphicsContextCG.cpp:
  • platform/graphics/cg/ImageCG.cpp:
4:47 PM Changeset in webkit [116908] by rwlbuis@webkit.org
  • 10 edits in trunk/Source/WebCore

Use emptyString instead of String("")
https://bugs.webkit.org/show_bug.cgi?id=86305

Reviewed by Darin Adler.

Use emptyString() instead of String("") because it is better style and faster.

No new tests. No change in behavior.

  • Modules/webdatabase/AbstractDatabase.cpp:

(WebCore::AbstractDatabase::performOpenAndVerify):

  • Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::subprotocol):
(WebCore::ThreadableWebSocketChannelClientWrapper::extensions):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setValueFromRenderer):

  • platform/SharedBufferChunkReader.cpp:

(WebCore::SharedBufferChunkReader::nextChunkAsUTF8StringWithLatin1Fallback):

  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::ResourceHandleManager::setProxyInfo):

  • platform/text/LocaleICU.cpp:

(WebCore::LocaleICU::initializeLocalizedDateFormatText):

  • rendering/RenderQuote.cpp:

(WebCore::RenderQuote::originalText):

  • storage/StorageNamespaceImpl.cpp:

(WebCore::StorageNamespaceImpl::localStorageNamespace):

  • svg/SVGStringList.cpp:

(WebCore::SVGStringList::reset):

4:42 PM Changeset in webkit [116907] by Darin Adler
  • 13 edits in trunk/Source/WebCore

Image::initPlatformData is always an empty function so we can remove it
https://bugs.webkit.org/show_bug.cgi?id=86297

Reviewed by Dan Bernstein.

  • platform/graphics/BitmapImage.h: Removed declaration of initPlatformData.
  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::BitmapImage): Removed call to initPlatformData.

  • platform/graphics/cairo/BitmapImageCairo.cpp:

(WebCore::BitmapImage::BitmapImage): Ditto.

  • platform/graphics/cg/ImageCG.cpp:

(WebCore::BitmapImage::BitmapImage): Ditto.

  • platform/graphics/chromium/ImageChromiumMac.mm: Removed empty

initPlatformData function.

  • platform/graphics/efl/ImageEfl.cpp: Ditto.
  • platform/graphics/gtk/ImageGtk.cpp:
  • platform/graphics/mac/ImageMac.mm:
  • platform/graphics/openvg/ImageOpenVG.cpp:

(WebCore::BitmapImage::BitmapImage): Removed call to initPlatformData.
Removed empty initPlatformData function.

  • platform/graphics/qt/ImageQt.cpp:

(WebCore::BitmapImage::BitmapImage): Removed call to initPlatformData.
Removed empty initPlatformData function.

  • platform/graphics/skia/ImageSkia.cpp: Removed empty initPlatformData function.
  • platform/graphics/win/ImageWin.cpp: Ditto.
  • platform/graphics/wx/ImageWx.cpp: Ditto.

(WebCore::BitmapImage::BitmapImage): Removed call to initPlatformData.

4:39 PM Changeset in webkit [116906] by Darin Adler
  • 2 edits in trunk/Source/WebCore

RenderView::selectionBounds and RenderView::setSelection use maps with raw pointers that should be OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=86300

Reviewed by Eric Seidel.

  • rendering/RenderView.cpp:

(WebCore::RenderView::selectionBounds): Changed SelectionMap type to use OwnPtr.
Added code to do adoptPtr as needed and removed explicit delete code.
(WebCore::RenderView::setSelection): Changed SelectedBlockMap type to use OwnPtr.
Added code to do adoptPtr as needed and removed explicit delete code.

4:36 PM Changeset in webkit [116905] by Darin Adler
  • 5 edits in trunk/Source/WebCore

FractionalLayoutUnit class has unneeded redundant uses of "inline" keyword
https://bugs.webkit.org/show_bug.cgi?id=86301

Reviewed by Andreas Kling.

  • platform/FractionalLayoutUnit.h: Removed uses of inline for functions

defined inside a class definition. The C++ language defines that all such
functions are treated as if specified with inline, and explicitly stating
inline in addition does not add anything or change behavior.

4:25 PM Changeset in webkit [116904] by Darin Adler
  • 3 edits in trunk/Source/WebCore

Dangling node to ID maps vector uses raw pointers, but should use OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=86299

Reviewed by Pavel Feldman.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::releaseDanglingNodes): Removed now-unneeded call
to deleteAllValues since the clear function now takes care of that.
(WebCore::InspectorDOMAgent::pushNodePathToFrontend): Added code that uses
adoptPtr and release as neeed to deal with a Vector<OwnPtr>.

  • inspector/InspectorDOMAgent.h: Changed m_danglingNodeToIdMaps to be

Vector<OwnPtr> instead of a vector of raw pointers.

2:45 PM Changeset in webkit [116903] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed, fix test skipped in the previous commit.

  • platform/efl/test_expectations.txt:
2:43 PM Changeset in webkit [116902] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening; skip tests after r116900.

The patch only updated the chromium and mac expectations...

  • platform/efl/test_expectations.txt:
2:09 PM Changeset in webkit [116901] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening; skip test added in r116858.

  • platform/efl/test_expectations.txt:
12:11 PM Changeset in webkit [116900] by commit-queue@webkit.org
  • 15 edits
    2 adds in trunk

Volume slider needs to be displayed below the mute button
https://bugs.webkit.org/show_bug.cgi?id=85990

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-05-13
Reviewed by Dimitri Glazkov.

Source/WebCore:

Added back code for rendering offset, but used only when the volume slider
needs to be displayed below the controls.

Test: media/media-volume-slider-rendered-below.html

  • css/mediaControlsChromium.css:

(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
Changed positioning of the slider to absolute, otherwise it is not possible to position it from the layout() method.

  • css/mediaControlsQuickTime.css:

Added back the double mute-button and changed the z-index of the original button. When the slider is displayed
the second mute button is actually there.
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
(audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):
Added copy.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::makeTransparent): Disabled the possible of hiding controls. WebVTT rendering
in the place of controls when these are visible is not possible with the current code.
(RenderMediaVolumeSliderContainer):
(WebCore):
(WebCore::RenderMediaVolumeSliderContainer::RenderMediaVolumeSliderContainer):
(WebCore::RenderMediaVolumeSliderContainer::layout):
Checked if the absolute coordinates of the corner of the slider would be rendered outside the page. This part of the
code is faulty if display:none is toggled on the controls.
(WebCore::MediaControlVolumeSliderContainerElement::createRenderer):

  • html/shadow/MediaControlElements.h:

(MediaControlVolumeSliderContainerElement):

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::create):

LayoutTests:

Updated tests expectation and marked failing tests accordingly.

  • media/media-volume-slider-rendered-below.html: Added.
  • media/media-volume-slider-rendered-expected.txt: Added.
  • platform/chromium/test_expectations.txt: Updated.
  • platform/mac/media/audio-controls-rendering-expected.txt: Updated (z-index change).
  • platform/mac/media/controls-after-reload-expected.txt: Same.
  • platform/mac/media/controls-strict-expected.txt: Same.
  • platform/mac/media/video-controls-rendering-expected.txt: Same.
  • platform/mac/media/video-display-toggle-expected.txt: Same.
  • platform/mac/media/video-playing-and-pause-expected.txt: Same.
  • platform/mac/test_expectations.txt: Updated.
10:00 AM Changeset in webkit [116899] by igor.o@sisa.samsung.com
  • 3 edits in trunk/Source/WebCore

[Texmap] TextureMapperAnimations does not support keyframe with multiple animations
https://bugs.webkit.org/show_bug.cgi?id=86303

Qt and GTK, in WebKit1, use TextureMapper to store AC animations using
TextureMapperAnimations::add(keyframeName, TextureMapperAnimation). And when a
CSS animation animates several CSS properties, TextureMapperAnimations::add is
called more than once with the same keyframeName value. However, currently,
TextureMapperAnimations can not store more than one animated property in the keyframe
because it is using HashMap<String, TextureMapperAnimation>, and WebKit HashMap
does not support add the same key twice.

Reviewed by Noam Rosenthal.

  • platform/graphics/texmap/TextureMapperAnimation.cpp:

(WebCore::TextureMapperAnimations::hasActiveAnimationsOfType):
(WebCore::TextureMapperAnimations::hasRunningAnimations):
(WebCore::TextureMapperAnimations::add):
(WebCore):
(WebCore::TextureMapperAnimations::pause):
(WebCore::TextureMapperAnimations::apply):

  • platform/graphics/texmap/TextureMapperAnimation.h:

(TextureMapperAnimations): Use HashMap<String, Vector<TextureMapperAnimation> >,
so we can support an keyframe with multiple animations.

6:46 AM Changeset in webkit [116898] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/LayoutTests

Merge 113995 - Unreviewed, GTK test_expectations post-Skipped-migration update #2.

  • platform/gtk/test_expectations.txt:
6:46 AM Changeset in webkit [116897] by kov@webkit.org
  • 14 edits
    2 adds in releases/WebKitGTK/webkit-1.8/LayoutTests

Merge 113986 - Unreviewed, GTK test_expectations post-Skipped-migration update.

  • platform/gtk/fast/dynamic/layer-hit-test-crash-expected.txt:
  • platform/gtk/http/tests/misc/acid2-expected.txt:
  • platform/gtk/svg/hittest/svg-ellipse-non-scale-stroke-expected.txt: Copied from LayoutTests/svg/hittest/svg-ellipse-non-scale-stroke-expected.txt.
  • platform/gtk/svg/hixie/perf/001-expected.txt: Added.
  • platform/gtk/svg/hixie/perf/002-expected.txt: Added.
  • platform/gtk/svg/hixie/perf/003-expected.txt:
  • platform/gtk/svg/hixie/perf/004-expected.txt:
  • platform/gtk/svg/hixie/perf/005-expected.txt:
  • platform/gtk/svg/hixie/perf/006-expected.txt:
  • platform/gtk/svg/hixie/perf/007-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
  • platform/gtk/svg/text/text-deco-01-b-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
  • platform/gtk/test_expectations.txt:
  • svg/hittest/svg-ellipse-non-scale-stroke-expected.txt:

Conflicts:

LayoutTests/platform/gtk/svg/hixie/perf/001-expected.txt
LayoutTests/platform/gtk/svg/hixie/perf/002-expected.txt
LayoutTests/svg/hittest/svg-ellipse-non-scale-stroke-expected.txt

6:46 AM Changeset in webkit [116896] by kov@webkit.org
  • 7 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merge 110563 - Crash in WebCore::GraphicsContext::paintingDisabled
https://bugs.webkit.org/show_bug.cgi?id=80669

Reviewed by Nikolas Zimmermann.

Source/WebCore:

The SVGImageBufferTools::clipToImageBuffer method deletes the clip
image when it thinks it is not needed. However, there are cases when
it is in fact still needed, particularly when the clip buffer is
coming from higher up in the stack where it may be needed again.

So this patch adds a flag to only allow deletion of the image buffer
if it was created at the most recent call site.

Tests: svg/custom/circular-clip-path-references-crash-expected.svg

svg/custom/circular-clip-path-references-crash.svg

  • rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::applyClippingToContext):

  • rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::clipToTextMask):

  • rendering/svg/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::applyResource):

  • rendering/svg/SVGImageBufferTools.cpp:

(WebCore::SVGImageBufferTools::clipToImageBuffer):

  • rendering/svg/SVGImageBufferTools.h:

(SVGImageBufferTools):

LayoutTests:

  • svg/custom/circular-clip-path-references-crash-expected.svg: Added.
  • svg/custom/circular-clip-path-references-crash.svg: Added.
6:45 AM Changeset in webkit [116895] by kov@webkit.org
  • 4 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merge 110332 - Crash due to inserting letter into div with first-letter
https://bugs.webkit.org/show_bug.cgi?id=78534

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-03-09
Reviewed by David Hyatt.

Source/WebCore:

This fixes an issue in RenderTextFragment with setTextInternal
getting called with different intents. While most calls to it
are intended to change the underlying DOM node string, it can
also be called as a result of styleDidChange just for transforms
on the substring text fragment. This adds a mechanism for internal
callers to specify if the internal text is being updated without
a DOM node text change.

  • rendering/RenderTextFragment.cpp:

(WebCore::RenderTextFragment::styleDidChange)
(WebCore::RenderTextFragment::setTextInternal)

  • rendering/RenderTextFragment.h:

(WebCore::RenderTextFragment)

LayoutTests:

Test case to exercise the crashing condition in bug 78534. It inserts
a character in a first-letter div to induce an invalid RenderTextFragment
state.

  • editing/inserting/insert-character-in-first-letter-crash-expected.txt: Added
  • editing/inserting/insert-character-in-first-letter-crash.html: Added

Conflicts:

Source/WebCore/rendering/RenderTextFragment.cpp

6:45 AM Changeset in webkit [116894] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 115978 - Unreviewed, fix another call to join(), similar to the ones landed
in r115975.

  • Scripts/webkitdirs.pm:

(jhbuildConfigurationChanged):

6:45 AM Changeset in webkit [116893] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 115975 - [GTK] join() is wrongly used in webkitdirs.pm since r115532
https://bugs.webkit.org/show_bug.cgi?id=85501

Patch by Philippe Normand <pnormand@igalia.com> on 2012-05-03
Reviewed by Martin Robinson.

  • Scripts/webkitdirs.pm:

(getJhbuildPath):
(buildAutotoolsProject):

6:45 AM Changeset in webkit [116892] by kov@webkit.org
  • 3 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 112408 - [GTK] generate-gtk-doc doesn't cope with custom build directory
https://bugs.webkit.org/show_bug.cgi?id=82448

Reviewed by Martin Robinson.

Pass the product directory in generate-gtkdoc arguments from
build-webkit.

  • Scripts/webkitdirs.pm:

(buildAutotoolsProject):

  • gtk/common.py:

(get_build_path):

6:44 AM Changeset in webkit [116891] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 115904 - Unreviewed. Fix mistake I committed when applying review comments.

  • jhbuild/jhbuild-wrapper: dependencies_path was getting 'Root'

appended to its path, so jhbuild itself was being cloned and
installed in the wrong place when using WEBKITOUTPUTDIR.

6:44 AM Changeset in webkit [116890] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 115659 - [GTK] Add glib as a dependency to build glib-networking
https://bugs.webkit.org/show_bug.cgi?id=85181

Reviewed by Martin Robinson.

  • gtk/jhbuild.modules:
6:44 AM Changeset in webkit [116889] by kov@webkit.org
  • 5 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 115532 - [GTK] jhbuild cloning is not following WEBKITOUTPUTDIR.
https://bugs.webkit.org/show_bug.cgi?id=76161

Reviewed by Martin Robinson.

  • Scripts/webkitdirs.pm:

(getJhbuildPath): New method to obtain the jhbuild base directory,
using the product base directory
(jhbuildConfigurationChanged): Use the new method
(buildAutotoolsProject): Ditto.

  • efl/jhbuildrc: Use WEBKITOUTPUTDIR when calculating the path.
  • gtk/jhbuildrc: Ditto.
  • jhbuild/jhbuild-wrapper: Ditto.
6:44 AM Changeset in webkit [116888] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 112372 - [GTK] jhbuild wrongly tricked into clean-up
https://bugs.webkit.org/show_bug.cgi?id=82216

Reviewed by Gustavo Noronha Silva.

Save jhbuild{rc,.modules}.md5sum in Dependencies instead of the
build tree. Also when checking if the jhbuild configuration
changed use absolute md5sum paths.

  • Scripts/webkitdirs.pm:

(runAutogenForAutotoolsProjectIfNecessary):
(jhbuildConfigurationChanged):
(buildAutotoolsProject):

6:43 AM Changeset in webkit [116887] by kov@webkit.org
  • 5 edits in releases/WebKitGTK/webkit-1.8

Merge 114653 - [GTK] 3 fast/ layout tests failing after upgrading libsoup to 2.37.92
https://bugs.webkit.org/show_bug.cgi?id=82484

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-19
Reviewed by Martin Robinson.

Tools:

Bumping libsoup to version 2.38.1 which fixes the above WebKit bug.

  • efl/jhbuild.modules:
  • gtk/jhbuild.modules:

LayoutTests:

Unskipping tests that were previously failing due to a bug in libsoup.

  • platform/gtk/test_expectations.txt:

Conflicts:

LayoutTests/platform/gtk/test_expectations.txt
Tools/efl/jhbuild.modules

6:43 AM Changeset in webkit [116886] by kov@webkit.org
  • 2 edits
    1 delete in releases/WebKitGTK/webkit-1.8/LayoutTests

Merge 113981 - [GTK] Migrate Skipped tests to test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=83768

Reviewed by Martin Robinson.

This will hopefully simplify gardening tasks. The tests without
bug entry have been marked with BUGWKGTK and the most problematic
suites (mostly for unimplemented or heavily unreliable features
(inspector)) have been SKIP flagged.

  • platform/gtk/Skipped: Removed.
  • platform/gtk/test_expectations.txt:

Conflicts:

LayoutTests/platform/gtk/Skipped
LayoutTests/platform/gtk/test_expectations.txt

6:43 AM Changeset in webkit [116885] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 114332 - [GTK] Use configure instead of autogen.sh for gtk+
https://bugs.webkit.org/show_bug.cgi?id=84112

Rubber-stamped by Martin Robinson.

  • gtk/jhbuild.modules: GTK+'s autogen requires gobject-introspection;

we don't want to depend on that for now, so run configure instead - we
can, since we are using a tarball

6:43 AM Changeset in webkit [116884] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 114312 - [GTK] Add pango to jhbuild
https://bugs.webkit.org/show_bug.cgi?id=84086

Unreviewed build fix.

  • gtk/jhbuild.modules: Add pango's latest stable release, 1.30, to our

jhbuild environment. It's required for latest stable GTK+ and some
systems may lack it.

6:42 AM Changeset in webkit [116883] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 114308 - [GTK] fonts jhbuild module needs an empty clean target
https://bugs.webkit.org/show_bug.cgi?id=84085

Rubber-stamped by Martin Robinson.

  • gtk/jhbuild.modules: update to webkitgtk-test-fonts 0.0.2, which

includes a phony clean target that should make warnings and errors go
away.

6:42 AM Changeset in webkit [116882] by kov@webkit.org
  • 4 edits in releases/WebKitGTK/webkit-1.8

Merge 114297 - [GTK] Bump dependency on GTK+ 3.x to match reality
https://bugs.webkit.org/show_bug.cgi?id=84060

Rubber-stamped by Martin Robinson.

.:

  • configure.ac: Bump GTK+ 3 requirement to 3.4.0. In practice we

already depend on this version because of our dependency on a recent
glib, which causes linking issues with older GTK+; also bump glib to
its earliest version.

Tools:

  • gtk/jhbuild.modules: Bump GTK+ to 3.4.0, plus glib and gdk-pixbuf

to their GNOME 3.4 versions.

  • gtk/patches/gtk+-3.0.12-gtkprinter.patch: Removed. This patch

is applied upstream.

Conflicts:

Tools/gtk/jhbuild.modules

6:42 AM Changeset in webkit [116881] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 113066 - [GTK] Tools/Scripts/run-gtk-tests should not force you to use the WebKit jhbuild
https://bugs.webkit.org/show_bug.cgi?id=82473

Reviewed by Philippe Normand.

Only use jhbuild if WebKitBuild/Dependencies exists (if update-webkitgtk-libs)
was ever run.

  • gtk/run-with-jhbuild: Instead of using jhbuild unconditionally, first

check if the user has ever run update-gtk-libs and, if so, then use jhbuild.

6:42 AM Changeset in webkit [116880] by kov@webkit.org
  • 3 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 112309 - [jhbuild] Prepend jhbuildrc's directory to sys.path instead of appending.
https://bugs.webkit.org/show_bug.cgi?id=82252

Reviewed by Gustavo Noronha Silva.

Appending the directory containing common.py may be problematic if
another path in sys.path also contains either a common.py or a
common/ module, so prepend to select our version instead. This is
the case with fail2ban, which has a common/ directory which may
end up being in Python's default path.

  • efl/jhbuildrc:
  • gtk/jhbuildrc:
6:41 AM Changeset in webkit [116879] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 112294 - [GTK] Build gnutls without p11-kit support
https://bugs.webkit.org/show_bug.cgi?id=82212

Reviewed by Martin Robinson.

  • gtk/jhbuild.modules: pass --without-p11-kit to gnutls'

configure, to avoid requiring that dependency, which is not used
by libsoup and WebKit anyway

6:41 AM Changeset in webkit [116878] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 112153 - [jhbuild] Use $MAKE if it is defined to build jhbuild itself.
https://bugs.webkit.org/show_bug.cgi?id=82209

Reviewed by Martin Robinson.

Respecting the $MAKE environment variable when it is defined makes
building jhbuild more portable, as some platforms may have GNU
make as gmake, for example.

  • jhbuild/jhbuild-wrapper:

(install_jhbuild):

6:41 AM Changeset in webkit [116877] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 112139 - [jhbuild] Revert $MAKE environment hack introduced in r101929.
https://bugs.webkit.org/show_bug.cgi?id=82234

Reviewed by Martin Robinson.

The problem it was supposedly fixing was fixed in jhbuild itself
in git revision da8944d8ca987ca48c91b350257a530050406092, so we
can remove the workaround added to the script.

  • jhbuild/jhbuild-wrapper:

(install_jhbuild):

6:41 AM Changeset in webkit [116876] by kov@webkit.org
  • 3 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 112101 - [jhbuild] Explicitly disable DTrace when building glib.
https://bugs.webkit.org/show_bug.cgi?id=82145

Reviewed by Gustavo Noronha Silva.

DTrace support is not really needed by WebKit, so disabling it
helps avoid some build errors on more exotic platforms (such as
FreeBSD).

  • efl/jhbuild.modules:
  • gtk/jhbuild.modules:
6:40 AM Changeset in webkit [116875] by kov@webkit.org
  • 4 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 111929 - [GTK] libgcrypt and p11-kit should not be in jhbuild modules
https://bugs.webkit.org/show_bug.cgi?id=82073

Reviewed by Martin Robinson.

  • Scripts/webkitdirs.pm:

(jhbuildConfigurationChanged): new function that isolates the
jhbuild configuration change checking from the autogen logic.
(mustReRunAutogen): code for the new function lived here.
(buildAutotoolsProject): now calls jhbuildConfigurationChanged
itself, and cleans up the jhbuild root if configuration has
changed; it also forces autogen to be run in that case, to
make sure the new libraries are used.

  • gtk/jhbuild.modules: removed libgcrypt and p11-kit.
  • jhbuild/jhbuild-wrapper:

(ensure_jhbuild): this might be run inside a jhbuild environment,
in which case aclocal fails when trying to use the now deleted
aclocal directory in the jhbuild prefix, so work around that.

6:40 AM Changeset in webkit [116874] by kov@webkit.org
  • 5 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 111668 - [GTK] Allow to run any jhbuild command with jhbuild-wrapper script
https://bugs.webkit.org/show_bug.cgi?id=81888

Reviewed by Philippe Normand.

  • Scripts/update-webkit-libs-jhbuild:

(runJhbuild): Helper function to run jhbuild with a given command.
Instead of running jhbuild directly, use the jhbuild-wrapper, so
that we don't need to run it first to check whether jhbuild is
installed or not.

  • efl/run-with-jhbuild: Call jhbuild-wrapper with run command.
  • gtk/run-with-jhbuild: Ditto.
  • jhbuild/jhbuild-wrapper: Allow to execute any jhbuild command,

not only run.

6:40 AM Changeset in webkit [116873] by kov@webkit.org
  • 2 edits
    6 adds in releases/WebKitGTK/webkit-1.8/Tools

Merge 111115 - [EFL] Add and use run-with-jhbuild and update-webkitefl-libs scripts for EFL
https://bugs.webkit.org/show_bug.cgi?id=79904

build-webkit --efl will use jhbuild for fetching and building dependencies.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-03-17
Reviewed by Gustavo Noronha Silva.

  • Scripts/update-webkitefl-libs: Added.
  • Scripts/webkitdirs.pm:

(jhbuildWrapperPrefixIfNeeded):
(generateBuildSystemFromCMakeProject):
(buildCMakeGeneratedProject):

  • efl/common.py: Added.

(script_path):
(top_level_path):
(number_of_cpus):

  • efl/jhbuild.modules: Added.
  • efl/jhbuildrc: Added.
  • efl/run-with-jhbuild: Added.
6:40 AM Changeset in webkit [116872] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 111175 - jhbuild: Call jhbuild's autogen.sh via bash.
https://bugs.webkit.org/show_bug.cgi?id=81485

Reviewed by Philippe Normand.

jhbuild's autogen.sh uses "/bin/bash" in the shebang line, however
this is usually true only on Linux systems, and even then bash for
some reason might not be available in that location. It is safer to
call bash directly and pass autogen.sh to it instead.

  • jhbuild/jhbuild-wrapper:

(install_jhbuild):

6:39 AM Changeset in webkit [116871] by kov@webkit.org
  • 3 edits
    2 copies
    1 add in releases/WebKitGTK/webkit-1.8/Tools

Merge 110846 - Parametrize run-with-jhbuild and update-webkitgtk-libs with platform --gtk/--efl
https://bugs.webkit.org/show_bug.cgi?id=79673

Preparatory work for bringing jhbuild enabled build to EFL port.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-03-15
Reviewed by Philippe Normand.

  • Scripts/update-webkit-libs-jhbuild: Copied from Tools/Scripts/update-webkitgtk-libs.
  • Scripts/update-webkitgtk-libs:
  • gtk/run-with-jhbuild:
  • jhbuild/jhbuild-wrapper: Copied from Tools/gtk/run-with-jhbuild.

(top_level_path):
(jhbuild_installed):
(jhbuild_cloned):
(jhbuild_at_expected_revision):
(update_jhbuild):
(clone_jhbuild):
(install_jhbuild):
(update_webkit_libs_jhbuild):
(determine_platform):
(ensure_jhbuild):

6:39 AM Changeset in webkit [116870] by kov@webkit.org
  • 2 edits
    3 adds in releases/WebKitGTK/webkit-1.8/Tools

Merge 111749 - [GTK] Add make to the jhbuild moduleset
https://bugs.webkit.org/show_bug.cgi?id=81769

Reviewed by Martin Robinson.

Mostly based on a patch by Carlos Garcia Campos <cgarcia@igalia.com>.
Add GNU make with custom patches to fix several issues:

  • make-3.82-arg-list-length.patch: Patch by Ralf Wildenhues to fix the argument list limit of GNU make when running make distcheck.
  • make-3.82-parallel-build.patch: Patch by Kamil Mierzejewski and Jeremy Devenport to fix parallel build issues present in GNU make 3.82
  • gtk/jhbuild.modules: Added make with patches.
  • gtk/patches/make-3.82-arg-list-length.patch: Added.
  • gtk/patches/make-3.82-parallel-build.patch: Added.
6:39 AM Changeset in webkit [116869] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 112672 - [GTK] Disable introspection build in the at-spi2-core module.
https://bugs.webkit.org/show_bug.cgi?id=82729

Patch by Vineet Chaudhary <Vineet> on 2012-03-30
Reviewed by Philippe Normand.

This change is a follow-up of bug 82395 which initially disabled for other modules of the set.

  • gtk/jhbuild.modules: Disable introspection.
6:39 AM Changeset in webkit [116868] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 112392 - [GTK] Disable introspection for jhbuild modules
https://bugs.webkit.org/show_bug.cgi?id=82395

Reviewed by Philippe Normand.

  • efl/jhbuild.modules: add --disable-introspection to all modules

that support it

  • gtk/jhbuild.modules: ditto.

Conflicts:

Tools/efl/jhbuild.modules

6:38 AM Changeset in webkit [116867] by kov@webkit.org
  • 1 edit in releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog

Merge 111607 - Unreviewed, GTK gardening after r111601.

  • platform/gtk/svg/custom/delete-text-crash-expected.txt: Removed.
6:38 AM Changeset in webkit [116866] by kov@webkit.org
  • 5 edits
    3 adds in releases/WebKitGTK/webkit-1.8

Merge 110593 - Fix the use of stale text fragments
https://bugs.webkit.org/show_bug.cgi?id=80729

Patch by Philip Rogers <pdr@google.com> on 2012-03-13
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Previously, we were allowing SVGTextFragments to get out of sync with the
actual text in RenderSVGInlineTextBox. This patch reuses the dirty line
box code in RenderText::setTextWithOffset to force
clearTextFragments() when setTextWithOffset is called, preventing the use
of stale SVGTextFragments.

Test: svg/custom/delete-text-crash.html

  • rendering/InlineBox.h:

(InlineBox):

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::dirtyLineBoxes):
(WebCore):

  • rendering/svg/SVGInlineTextBox.h:

(SVGInlineTextBox):

LayoutTests:

  • svg/custom/delete-text-crash-expected.png: Added.
  • svg/custom/delete-text-crash-expected.txt: Added.
  • svg/custom/delete-text-crash.html: Added.

May 12, 2012:

11:07 PM Changeset in webkit [116865] by commit-queue@webkit.org
  • 10 edits
    2 deletes in trunk/Source

Unreviewed, rolling out r116812.
http://trac.webkit.org/changeset/116812
https://bugs.webkit.org/show_bug.cgi?id=86313

Appears to be causing a top crash (Requested by abarth on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-12

Source/Platform:

  • Platform.gypi:
  • chromium/public/Platform.h:

(WebKit):

  • chromium/public/WebStorageArea.h: Removed.
  • chromium/public/WebStorageNamespace.h: Removed.

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebStorageArea.h:

(WebKit):
(WebStorageArea):
(WebKit::WebStorageArea::~WebStorageArea):
(WebKit::WebStorageArea::setItem):
(WebKit::WebStorageArea::removeItem):
(WebKit::WebStorageArea::clear):

  • public/WebStorageNamespace.h:

(WebKit):
(WebStorageNamespace):
(WebKit::WebStorageNamespace::~WebStorageNamespace):
(WebKit::WebStorageNamespace::isSameNamespace):

  • public/platform/WebKitPlatformSupport.h:

(WebKit):
(WebKitPlatformSupport):
(WebKit::WebKitPlatformSupport::createLocalStorageNamespace):

  • src/StorageAreaProxy.cpp:
  • src/StorageNamespaceProxy.cpp:

(WebCore::StorageNamespace::localStorageNamespace):

9:22 PM Changeset in webkit [116864] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash in HTMLSelectElement::setOption
https://bugs.webkit.org/show_bug.cgi?id=85420

Source/WebCore:

Reviewed by Eric Seidel

RefPtr before option in HTMLSelectElement::setOption since it
can get destroyed due to mutation events.

Test: fast/dom/HTMLSelectElement/option-add-crash.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::setOption):

LayoutTests:

Reviewed by Eric Seidel.

  • fast/dom/HTMLSelectElement/option-add-crash-expected.txt: Added.
  • fast/dom/HTMLSelectElement/option-add-crash.html: Added.
8:51 PM Changeset in webkit [116863] by kevino@webkit.org
  • 5 edits in trunk/Source

[wx] Restore paste implementation and fix a couple typos.
https://bugs.webkit.org/show_bug.cgi?id=86311

6:40 PM Changeset in webkit [116862] by kevino@webkit.org
  • 2 edits in trunk/Source/WebKit/wx

[wx] Fix backing bitmap creation under wxMSW.
https://bugs.webkit.org/show_bug.cgi?id=86304

Reviewed by Kevin Ollivier.

12:23 PM Changeset in webkit [116861] by kov@webkit.org
  • 3 edits in releases/WebKitGTK/webkit-1.8

Merging 111925.

12:14 PM Changeset in webkit [116860] by pdr@google.com
  • 3 edits
    2 adds in trunk

Cleanup before changing attributeName in SVG <animate>
https://bugs.webkit.org/show_bug.cgi?id=86100

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Changing attributeName caused a crash because references were not removed from the old target.
This change simply cleans up before changing attributeName in SVG animation elements.

Test: svg/animations/dynamic-modify-attributename-crash.svg

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::svgAttributeChanged):

LayoutTests:

  • svg/animations/dynamic-modify-attributename-crash-expected.txt: Added.
  • svg/animations/dynamic-modify-attributename-crash.svg: Added.
11:08 AM Changeset in webkit [116859] by timothy_horton@apple.com
  • 4 edits in trunk/Tools

run-safari and co. should support --guard-malloc command line argument
https://bugs.webkit.org/show_bug.cgi?id=86287

Reviewed by Dan Bernstein.

Add setUpGuardMallocIfNeeded(), which consults the argument --guard-malloc on OS X,
setting DYLD_INSERT_LIBRARIES="/usr/lib/libgmalloc.dylib" if it's enabled.

Use setUpGuardMallocIfNeeded() before running a WebKit app (whether standalone or
in the debugger). This will cause gmalloc to be loaded for gdb as well, but this
tends to be harmless.

Change "malloc guard" to the more common "Guard Malloc" in run-webkit-tests.

  • Scripts/old-run-webkit-tests:
  • Scripts/webkitdirs.pm:

(appendToEnvironmentVariableList):
(setUpGuardMallocIfNeeded):
(printHelpAndExitForRunAndDebugWebKitAppIfNeeded):
(runMacWebKitApp):
(execMacWebKitAppForDebugging):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

10:09 AM Changeset in webkit [116858] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

[BlackBerry] Allow the platform media player to determine the media element's paused/playing status
https://bugs.webkit.org/show_bug.cgi?id=86235

Patch by Max Feil <mfeil@rim.com> on 2012-05-12
Reviewed by George Staikos.

Source/WebCore:

The platform media player needs to know when the HTMLMediaElement
is not paused. This is to address problems when switching
source element, which causes the destruction of the old
MediaPlayerPrivate object and construction of a new one. The
new one must resume playing ASAP if the old one was playing.

Test: media/media-continues-playing-after-replace-source.html

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::isElementPaused):
(WebCore):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:

(MediaPlayerPrivate):

LayoutTests:

This test replaces the source element of a playing media object
and makes sure the new source element begins playing.

  • media/media-continues-playing-after-replace-source-expected.txt: Added.
  • media/media-continues-playing-after-replace-source.html: Added.
9:35 AM Changeset in webkit [116857] by yurys@chromium.org
  • 12 edits in trunk/Source/WebCore

Web Inspector: heap profiler should allow revealing an element which is logged to the console
https://bugs.webkit.org/show_bug.cgi?id=86204

Reviewed by Pavel Feldman.

JS objects in the console have context menu item that allows to reveal them in a heap snapshot view.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsObject):

  • inspector/front-end/ContextMenu.js:

(WebInspector.ContextMenu.prototype.isEmpty):

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGridNode.prototype._detach):
(WebInspector.DataGridNode.prototype.wasDetached):

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype.nodeClassName):
(WebInspector.HeapSnapshotNodesProvider.prototype.nodePosition):

  • inspector/front-end/HeapSnapshotDataGrids.js:

(WebInspector.HeapSnapshotSortableDataGrid):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.highlightObjectByHeapSnapshotId):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.highlightNode):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.nodeWasDetached):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._clearCurrentHighlight):
(WebInspector.HeapSnapshotViewportDataGrid):
(WebInspector.HeapSnapshotViewportDataGrid.prototype.highlightNode):
(WebInspector.HeapSnapshotViewportDataGrid.prototype._onScroll):
(WebInspector.HeapSnapshotConstructorsDataGrid):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.highlightObjectByHeapSnapshotId.didGetClassName):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.highlightObjectByHeapSnapshotId):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.setDataSource):

  • inspector/front-end/HeapSnapshotGridNodes.js:

(WebInspector.HeapSnapshotGridNode.prototype.wasDetached):
(WebInspector.HeapSnapshotConstructorNode.prototype.revealNodeBySnapshotObjectId):
(WebInspector.HeapSnapshotConstructorNode.prototype.revealNodeBySnapshotObjectId.didPopulateChildren):

  • inspector/front-end/HeapSnapshotProxy.js:

(WebInspector.HeapSnapshotProxy.prototype.nodeClassName):
(WebInspector.HeapSnapshotProviderProxy.prototype.nodePosition):

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertiesSection.ContextMenuProvider):
(WebInspector.ObjectPropertiesSection.ContextMenuProvider.prototype.populateContextMenu):
(WebInspector.ObjectPropertiesSection.addContextMenuProvider):
(WebInspector.ObjectPropertiesSection.prototype.enableContextMenu):
(WebInspector.ObjectPropertiesSection.prototype._contextMenuEventFired):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype.showObject):
(WebInspector.RevealInHeapSnapshotContextMenuProvider):
(WebInspector.RevealInHeapSnapshotContextMenuProvider.prototype.populateContextMenu.revealInSummaryView):
(WebInspector.RevealInHeapSnapshotContextMenuProvider.prototype.populateContextMenu.didReceiveHeapObjectId):
(WebInspector.RevealInHeapSnapshotContextMenuProvider.prototype.populateContextMenu):

  • inspector/front-end/profilesPanel.css:

(.highlighted-row):
(@-webkit-keyframes row_highlight):
(to):

7:29 AM Changeset in webkit [116856] by zandobersek@gmail.com
  • 2 edits
    27 adds in trunk/LayoutTests

Unreviewed, GTK gardening. Also add baselines for new tests after
r116001, r116373 and r116438.

  • platform/gtk/css2.1/20110323/first-letter-000-expected.txt: Added.
  • platform/gtk/css2.1/20110323/first-letter-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/first-letter-dynamic-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/first-letter-dynamic-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/first-letter-dynamic-003a-expected.txt: Added.
  • platform/gtk/css2.1/20110323/first-letter-dynamic-003b-expected.txt: Added.
  • platform/gtk/css2.1/20110323/first-letter-inherit-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/first-letter-nested-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/first-letter-nested-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/first-letter-nested-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/first-letter-nested-004-expected.txt: Added.
  • platform/gtk/css2.1/20110323/first-letter-nested-005-expected.txt: Added.
  • platform/gtk/css2.1/20110323/first-letter-nested-006-expected.txt: Added.
  • platform/gtk/css2.1/20110323/first-letter-nested-007-expected.txt: Added.
  • platform/gtk/css2.1/20110323/first-letter-quote-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/first-letter-quote-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/first-letter-quote-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/first-letter-quote-004-expected.txt: Added.
  • platform/gtk/css2.1/20110323/first-letter-quote-005-expected.txt: Added.
  • platform/gtk/css2.1/20110323/first-letter-quote-006-expected.txt: Added.
  • platform/gtk/fast/css/first-letter-nested-positioned-expected.txt: Added.
  • platform/gtk/fast/css/first-letter-quotes-no-content-before-after-expected.txt: Added.
  • platform/gtk/fast/css/first-line-text-decoration-expected.txt: Added.
  • platform/gtk/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt: Added.
  • platform/gtk/media/media-can-play-webm-expected.txt: Added.
  • platform/gtk/svg/as-image/image-respects-deviceScaleFactor-expected.txt: Added.
  • platform/gtk/svg/as-image/image-respects-pageScaleFactor-expected.txt: Added.
  • platform/gtk/test_expectations.txt:
6:54 AM Changeset in webkit [116855] by loislo@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: move recording button state control out of addProfileHeader.
https://bugs.webkit.org/show_bug.cgi?id=86293

Reviewed by Yury Semikhatsky.

  • inspector/front-end/CSSSelectorProfileView.js:

(WebInspector.CSSSelectorProfileType.prototype.buttonClicked):

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):

  • inspector/front-end/ProfileView.js:

(WebInspector.CPUProfileType.prototype.buttonClicked):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfileType.prototype.buttonClicked):
(WebInspector.ProfilesPanel.prototype.toggleRecordButton):
(WebInspector.ProfilesPanel.prototype.addProfileHeader):
(WebInspector.ProfilesPanel.prototype.setRecordingProfile):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot.done):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):

6:39 AM Changeset in webkit [116854] by caseq@chromium.org
  • 9 edits in trunk/Source/WebCore

Web Inspector: Turn HelpScreen to be View.
https://bugs.webkit.org/show_bug.cgi?id=85711

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-05-12
Reviewed by Yury Semikhatsky.

Motivation: for further UI changes, HelpSceen needs to be View.
It is planned to combine Settings Screen and Shortcuts Screen in one
tabbed screen.
Bonus: "helpScreen.css" will be lazy-loaded.
Additional changes: move settingsScreen logic out of inspector.js

UI change, no test required.

  • WebCore.gypi: Change "helpScreen.css" file group.
  • inspector/front-end/HelpScreen.js:

(WebInspector.HelpScreen): Turned to View subclass.
(WebInspector.HelpScreen.prototype.showModal): Remove "onHide" param
(WebInspector.HelpScreen.prototype.hide): Ditto.
(WebInspector.HelpScreen.prototype._onKeyDown): Adopt View members.
(WebInspector.HelpScreen.prototype._onBlur): Ditto.

  • inspector/front-end/SettingsScreen.js: Adopt new workflow.

(WebInspector.SettingsScreen): Put onHide function to member
(WebInspector.SettingsScreen.prototype.willHide): Invoke onHide
(WebInspector.SettingsController): Mediator pattern - this class
takes care of status bar button - settings screen relationship.
(WebInspector.SettingsController.prototype.get statusBarItem):
Getter fot representative element.
(WebInspector.SettingsController.prototype._buttonClicked):
Classifies user action.
(WebInspector.SettingsController.prototype._onHideSettingsScreen):
Cleanup after settings screen is hidden.
(WebInspector.SettingsController.prototype._showSettingsScreen):
Presents settings screen.
(WebInspector.SettingsController.prototype._hideSettingsScreen):
Hides settings screen.

  • inspector/front-end/ShortcutsScreen.js: Adopt new workflow.

(WebInspector.ShortcutsScreen.prototype.wasShown): Lazy initialization.

  • inspector/front-end/WorkerManager.js: Adopt new workflow.

(WebInspector.WorkerManager.prototype._disconnectedFromWorker): Ditto.
(WebInspector.WorkerTerminatedScreen.prototype.willHide): Ditto.

  • inspector/front-end/helpScreen.css: Fix spacing.

(.help-window-outer): Ditto.
(body.compact .help-window-outer): Ditto.
(body.compact .help-window-main): Ditto.
(body.compact .help-window-caption): Ditto.
(.help-content): Ditto.
(body.compact .help-content): Ditto.
(.help-content select): Ditto.

  • inspector/front-end/inspector.html: Ditto.
  • inspector/front-end/inspector.js: Ditto.

(WebInspector._createGlobalStatusBarItems): Create SettingsController.
(WebInspector.documentKeyDown): Adopt new workflow.

6:09 AM Changeset in webkit [116853] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: add tab context menu
https://bugs.webkit.org/show_bug.cgi?id=86292

Reviewed by Yury Semikhatsky.

This tab context menu will have "Close", "Close Others" and "Close All".

  • English.lproj/localizedStrings.js:
  • inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPane.prototype.closeOtherTabs):
(WebInspector.TabbedPaneTab.prototype._createTabElement):
(WebInspector.TabbedPaneTab.prototype._tabClicked):
(WebInspector.TabbedPaneTab.prototype._tabContextMenu):
(WebInspector.TabbedPaneTab.prototype._tabContextMenu.closeOthers):
(WebInspector.TabbedPaneTab.prototype._tabContextMenu.closeAll):

5:52 AM Changeset in webkit [116852] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: make call frame selector pane focusable, allow Up / Down to select current call frame.
https://bugs.webkit.org/show_bug.cgi?id=86291

Reviewed by Yury Semikhatsky.

This change makes sidebar section focusable, introduces key listeners for Up and Down.

  • inspector/front-end/CallStackSidebarPane.js:

(WebInspector.CallStackSidebarPane):
(WebInspector.CallStackSidebarPane.prototype.setStatus):
(WebInspector.CallStackSidebarPane.prototype._treeKeyDown):

  • inspector/front-end/UISourceCode.js:
  • inspector/front-end/scriptsPanel.css:

(#scripts-debug-toolbar img):

5:36 AM Changeset in webkit [116851] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: unreviewed one line fix.

  • inspector/front-end/HeapSnapshotProxy.js:

(WebInspector.HeapSnapshotWorker):

5:02 AM Changeset in webkit [116850] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Load context menu item has to be shown for all Profiles panel.
https://bugs.webkit.org/show_bug.cgi?id=86290

Reviewed by Pavel Feldman.

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype._handleContextMenuEvent):

4:56 AM Changeset in webkit [116849] by tkent@chromium.org
  • 4 edits
    2 deletes in trunk/LayoutTests

[Chromium] Update test expectations

  • platform/chromium-linux-x86/fast/speech/input-appearance-searchandspeech-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/custom/inline-svg-in-xhtml-expected.txt: Removed.
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-linux/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/chromium/test_expectations.txt:
4:09 AM Changeset in webkit [116848] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: shrink SourceFrame editing API to two methods (was 4).
https://bugs.webkit.org/show_bug.cgi?id=86288

Reviewed by Yury Semikhatsky.

Used specific workflow in two SourceFrame implementations.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.commitEditing):
(WebInspector.JavaScriptSourceFrame.prototype.afterTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype._didEditContent):

  • inspector/front-end/ResourceView.js:

(WebInspector.EditableResourceSourceFrame.prototype.commitEditing.callbackWrapper):
(WebInspector.EditableResourceSourceFrame.prototype.commitEditing):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.commitEditing):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.commitEditing):

3:17 AM Changeset in webkit [116847] by yurys@chromium.org
  • 15 edits
    2 adds in trunk

Web Inspector: allow showing arbitrary range of nodes in heap snapshot view
https://bugs.webkit.org/show_bug.cgi?id=86230

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/profiler/heap-snapshot-summary-show-ranges.html

It was only possible to expand heap snapshot node children sequentially starting
from the first child and then pressing either "Show next X items" or "Show all X items".
This change makes it possible to show any range of children.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotFilteredOrderedIterator):
(WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.serializeItemsRange):
(WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.sortAll):
(WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.sortAndRewind):
(WebInspector.HeapSnapshotEdgesProvider.prototype.serializeItem):
(WebInspector.HeapSnapshotNodesProvider.prototype.serializeItem):

  • inspector/front-end/HeapSnapshotGridNodes.js:

(WebInspector.HeapSnapshotGridNode):
(WebInspector.HeapSnapshotGridNode.prototype._populate.sorted):
(WebInspector.HeapSnapshotGridNode.prototype._populate):
(WebInspector.HeapSnapshotGridNode.prototype._populateChildren.serializeNextChunk):
(WebInspector.HeapSnapshotGridNode.prototype._populateChildren.insertRetrievedChild):
(WebInspector.HeapSnapshotGridNode.prototype._populateChildren.insertShowMoreButton):
(WebInspector.HeapSnapshotGridNode.prototype._populateChildren.childrenRetrieved):
(WebInspector.HeapSnapshotGridNode.prototype._populateChildren):
(WebInspector.HeapSnapshotGridNode.prototype._saveChildren):
(WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort):
(WebInspector.HeapSnapshotGridNode.prototype.sort):
(WebInspector.HeapSnapshotDiffNodesProvider):
(WebInspector.HeapSnapshotDiffNodesProvider.prototype.serializeItemsRange):
(WebInspector.HeapSnapshotDiffNodesProvider.prototype.serializeItemsRange.didReceiveDeletedItems):
(WebInspector.HeapSnapshotDiffNodesProvider.prototype.serializeItemsRange.didReceiveAddedItems):
(WebInspector.HeapSnapshotDiffNodesProvider.prototype.sortAndRewind):

  • inspector/front-end/HeapSnapshotProxy.js:

(WebInspector.HeapSnapshotWorker):
(WebInspector.HeapSnapshotProviderProxy.prototype.serializeItemsRange):

  • inspector/front-end/ShowMoreDataGridNode.js:

(WebInspector.ShowMoreDataGridNode):
(WebInspector.ShowMoreDataGridNode.prototype._showNextChunk):
(WebInspector.ShowMoreDataGridNode.prototype._showAll):
(WebInspector.ShowMoreDataGridNode.prototype._updateLabels):
(WebInspector.ShowMoreDataGridNode.prototype.setStartPosition):
(WebInspector.ShowMoreDataGridNode.prototype.setEndPosition):

  • inspector/front-end/utilities.js:

LayoutTests:

  • inspector/profiler/heap-snapshot-comparison-show-all.html:
  • inspector/profiler/heap-snapshot-containment-show-all.html:
  • inspector/profiler/heap-snapshot-dominators-show-all.html:
  • inspector/profiler/heap-snapshot-summary-show-all.html:
  • inspector/profiler/heap-snapshot-summary-show-ranges-expected.txt: Added.
  • inspector/profiler/heap-snapshot-summary-show-ranges.html: Added. Test that

showing overlapping and disjoint ranges of node children will leave the node
in a valid state.

  • platform/mac/Skipped: Skip the test on platforms that don't support heap profiling.
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
3:02 AM Changeset in webkit [116846] by pfeldman@chromium.org
  • 16 edits in trunk

Web Inspector: remove UISourceCode.id since it is no longer used.
https://bugs.webkit.org/show_bug.cgi?id=86286

Reviewed by Vsevolod Vlasov.

Source/WebCore:

We are now using breakpointStorageId property for breakpoint persistence.

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager):
(WebInspector.BreakpointManager.prototype._debuggerReset):
(WebInspector.BreakpointManager.prototype._uiLocationAdded.get if):
(WebInspector.BreakpointManager.prototype._uiLocationAdded):
(WebInspector.BreakpointManager.prototype._uiLocationRemoved.get if):
(WebInspector.BreakpointManager.prototype._uiLocationRemoved):

  • inspector/front-end/CompilerScriptMapping.js:
  • inspector/front-end/JavaScriptSource.js:

(WebInspector.JavaScriptSource):

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.prototype._createUISourceCode):
(WebInspector.RawSourceCode.prototype._finishedLoading):

  • inspector/front-end/SnippetsModel.js:

(WebInspector.SnippetsScriptMapping.prototype._snippetAdded):
(WebInspector.SnippetsScriptMapping.prototype._createUISourceCodeForScript):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):

LayoutTests:

  • inspector/debugger/breakpoint-manager.html:
  • inspector/debugger/raw-source-code.html:
  • inspector/debugger/scripts-file-selector.html:
  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/scripts-sorting.html:
  • inspector/debugger/ui-source-code-display-name.html:
  • inspector/debugger/ui-source-code.html:
1:51 AM Changeset in webkit [116845] by tkent@chromium.org
  • 36 edits
    4 copies
    5 moves
    1 add
    23 deletes in trunk/LayoutTests

[Chromium] Test expectation update.

  • fast/block/float/avoiding-float-centered-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/float/avoiding-float-centered-expected.txt.
  • fast/clip/008-expected.txt: Renamed from LayoutTests/platform/efl/fast/clip/008-expected.txt.
  • fast/clip/011-expected.txt: Renamed from LayoutTests/platform/efl/fast/clip/011-expected.txt.
  • fast/clip/012-expected.txt: Renamed from LayoutTests/platform/efl/fast/clip/012-expected.txt.
  • platform/chromium-linux-x86/fast/speech/input-appearance-searchandspeech-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.txt.
  • platform/chromium-linux-x86/svg/custom/inline-svg-in-xhtml-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/custom/inline-svg-in-xhtml-expected.txt.
  • platform/chromium-linux/editing/selection/3690703-2-expected.txt:
  • platform/chromium-linux/editing/selection/3690703-expected.txt:
  • platform/chromium-linux/editing/selection/3690719-expected.txt:
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/block-glyphs-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/block/lineboxcontain/block-glyphs-expected.txt.
  • platform/chromium-mac-snowleopard/fast/block/lineboxcontain/block-glyphs-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/block/lineboxcontain/block-glyphs-expected.txt.
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.txt: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/speech/input-appearance-searchandspeech-expected.txt.
  • platform/chromium-mac/editing/inserting/before-after-input-element-expected.txt: Removed.
  • platform/chromium-mac/editing/pasteboard/4806874-expected.txt: Removed.
  • platform/chromium-mac/editing/pasteboard/input-field-1-expected.txt: Removed.
  • platform/chromium-mac/editing/selection/3690703-2-expected.txt: Removed.
  • platform/chromium-mac/editing/selection/3690703-expected.txt: Removed.
  • platform/chromium-mac/editing/selection/3690719-expected.txt: Removed.
  • platform/chromium-mac/editing/selection/4895428-3-expected.txt: Removed.
  • platform/chromium-mac/editing/selection/4975120-expected.txt: Removed.
  • platform/chromium-mac/editing/selection/drag-select-1-expected.txt: Removed.
  • platform/chromium-mac/editing/selection/expanding-selections-expected.txt: Removed.
  • platform/chromium-mac/editing/selection/leave-requested-block-expected.txt: Removed.
  • platform/chromium-mac/editing/selection/select-across-readonly-input-1-expected.txt: Removed.
  • platform/chromium-mac/editing/selection/select-across-readonly-input-2-expected.txt: Removed.
  • platform/chromium-mac/editing/selection/select-across-readonly-input-3-expected.txt: Removed.
  • platform/chromium-mac/editing/selection/select-across-readonly-input-4-expected.txt: Removed.
  • platform/chromium-mac/editing/selection/select-across-readonly-input-5-expected.txt: Removed.
  • platform/chromium-mac/fast/block/lineboxcontain/block-font-expected.txt: Removed.
  • platform/chromium-mac/fast/block/lineboxcontain/block-glyphs-expected.txt:
  • platform/chromium-mac/fast/block/lineboxcontain/font-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-mac/fast/forms/placeholder-position-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/chromium-mac/fast/forms/search-rtl-expected.png:
  • platform/chromium-mac/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-mac/fast/forms/searchfield-heights-expected.png:
  • platform/chromium-win/editing/inserting/before-after-input-element-expected.txt:
  • platform/chromium-win/editing/pasteboard/4806874-expected.txt:
  • platform/chromium-win/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/chromium-win/editing/pasteboard/input-field-1-expected.txt:
  • platform/chromium-win/editing/selection/3690703-2-expected.txt:
  • platform/chromium-win/editing/selection/3690703-expected.txt:
  • platform/chromium-win/editing/selection/3690719-expected.txt:
  • platform/chromium-win/editing/selection/4895428-3-expected.txt:
  • platform/chromium-win/editing/selection/4975120-expected.txt:
  • platform/chromium-win/editing/selection/drag-select-1-expected.txt:
  • platform/chromium-win/editing/selection/expanding-selections-expected.txt:
  • platform/chromium-win/editing/selection/leave-requested-block-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-2-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-3-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/chromium-win/fast/block/float/avoiding-float-centered-expected.txt:
  • platform/chromium-win/fast/clip/008-expected.txt:
  • platform/chromium-win/fast/clip/011-expected.txt:
  • platform/chromium-win/fast/clip/012-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-position-expected.txt:
  • platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-win/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/chromium-win/svg/hixie/mixed/003-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/block/float/avoiding-float-centered-expected.txt: Removed.
  • platform/gtk/fast/clip/008-expected.txt: Removed.
  • platform/gtk/fast/clip/011-expected.txt: Removed.
  • platform/gtk/fast/clip/012-expected.txt: Removed.
1:44 AM Changeset in webkit [116844] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK gardening.

  • platform/gtk/test_expectations.txt: Also remove expectations for some

tests that were recently removed.

1:33 AM Changeset in webkit [116843] by pfeldman@chromium.org
  • 13 edits
    2 adds in trunk

Web Inspector: merge MainScriptMapping into DebuggerPresentationModel; move other classes into their own files.
https://bugs.webkit.org/show_bug.cgi?id=86285

Reviewed by Yury Semikhatsky.

Source/WebCore:

The only purpose of the debugger presentation model now is to manage mappings. Merging main script mapping back into it.
Other classes defined in that class are moved out into their own files.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):

  • inspector/front-end/DebuggerResourceBinding.js: Added.

(WebInspector.DebuggerResourceBinding):
(WebInspector.DebuggerResourceBinding.canEditScriptSource):
(WebInspector.DebuggerResourceBinding.setScriptSource.didEditScriptSource):
(WebInspector.DebuggerResourceBinding.setScriptSource):
(WebInspector.DebuggerResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerResourceBinding.prototype.setContent):
(WebInspector.DebuggerResourceBinding.prototype._uiSourceCodeForResource):
(WebInspector.DebuggerResourceBinding.prototype._setContentWithInitialContent):

  • inspector/front-end/PresentationConsoleMessageHelper.js: Added.

(WebInspector.PresentationConsoleMessageHelper):
(WebInspector.PresentationConsoleMessageHelper.prototype._consoleMessageAdded):
(WebInspector.PresentationConsoleMessageHelper.prototype._addConsoleMessageToScript):
(WebInspector.PresentationConsoleMessageHelper.prototype._addPendingConsoleMessage):
(WebInspector.PresentationConsoleMessageHelper.prototype._parsedScriptSource):
(WebInspector.PresentationConsoleMessageHelper.prototype._consoleCleared):
(WebInspector.PresentationConsoleMessageHelper.prototype._debuggerReset):
(WebInspector.PresentationConsoleMessage):
(WebInspector.PresentationConsoleMessage.prototype._updateLocation):
(WebInspector.PresentationConsoleMessage.prototype.get lineNumber):
(WebInspector.PresentationConsoleMessage.prototype.dispose):

  • inspector/front-end/ScriptMapping.js:
  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

LayoutTests:

  • http/tests/inspector/compiler-script-mapping-expected.txt:
  • http/tests/inspector/compiler-script-mapping.html:
1:31 AM Changeset in webkit [116842] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Cleanup ContentSecurityPolicy naming conventions.
https://bugs.webkit.org/show_bug.cgi?id=86282

Patch by Mike West <mkwst@chromium.org> on 2012-05-12
Reviewed by Adam Barth.

Two tiny changes:

  1. reportURI and reportURL are both used within the CSP implementation. We should standardize on reportURI to match the spec.
  1. Renames ContentSecurityPolicy::allowConnectFromSource to ContentSecurityPolicy::allowConnectToSource for clarity.

No new tests, as there's no user-visible change.

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::connect):

  • page/ContentSecurityPolicy.cpp:

(CSPDirectiveList):
(WebCore::CSPDirectiveList::reportViolation):
(WebCore::CSPDirectiveList::allowConnectToSource):
(WebCore::CSPDirectiveList::parseReportURI):
(WebCore::CSPDirectiveList::addDirective):
(WebCore::ContentSecurityPolicy::allowConnectToSource):

  • page/ContentSecurityPolicy.h:
  • page/EventSource.cpp:

(WebCore::EventSource::create):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::open):

12:43 AM Changeset in webkit [116841] by tkent@chromium.org
  • 198 edits
    40 moves
    5 adds
    177 deletes in trunk/LayoutTests

[Chromium] Rebaseline for some tests.

  • css3/selectors3/html/css3-modsel-23-expected.txt: Renamed from LayoutTests/platform/efl/css3/selectors3/html/css3-modsel-23-expected.txt.
  • css3/selectors3/html/css3-modsel-24-expected.txt: Renamed from LayoutTests/platform/efl/css3/selectors3/html/css3-modsel-24-expected.txt.
  • css3/selectors3/html/css3-modsel-68-expected.txt: Renamed from LayoutTests/platform/efl/css3/selectors3/html/css3-modsel-68-expected.txt.
  • css3/selectors3/html/css3-modsel-69-expected.txt: Renamed from LayoutTests/platform/efl/css3/selectors3/html/css3-modsel-69-expected.txt.
  • css3/selectors3/xhtml/css3-modsel-23-expected.txt: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-23-expected.txt.
  • css3/selectors3/xhtml/css3-modsel-24-expected.txt: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-24-expected.txt.
  • css3/selectors3/xhtml/css3-modsel-68-expected.txt: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-68-expected.txt.
  • css3/selectors3/xhtml/css3-modsel-69-expected.txt: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-69-expected.txt.
  • css3/selectors3/xml/css3-modsel-23-expected.txt: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-23-expected.txt.
  • css3/selectors3/xml/css3-modsel-24-expected.txt: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-24-expected.txt.
  • css3/selectors3/xml/css3-modsel-68-expected.txt: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-68-expected.txt.
  • css3/selectors3/xml/css3-modsel-69-expected.txt: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-69-expected.txt.
  • fast/block/float/033-expected.txt:
  • fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/float/float-not-removed-from-next-sibling3-expected.txt.
  • fast/block/float/in-margin-expected.png: Renamed from LayoutTests/platform/efl/fast/block/float/in-margin-expected.png.
  • fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt.
  • fast/block/float/shrink-to-avoid-float-complexity-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/float/shrink-to-avoid-float-complexity-expected.txt.
  • fast/block/lineboxcontain/parsing-invalid-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/lineboxcontain/parsing-invalid-expected.txt.
  • fast/clip/017-expected.png: Renamed from LayoutTests/platform/efl/fast/clip/017-expected.png.
  • fast/css/invalidation-errors-2-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/invalidation-errors-2-expected.txt.
  • fast/css/invalidation-errors-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/invalidation-errors-expected.txt.
  • fast/css/nested-layers-with-hover-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/nested-layers-with-hover-expected.txt.
  • fast/dynamic/subtree-boundary-percent-height-expected.png: Renamed from LayoutTests/platform/efl/fast/dynamic/subtree-boundary-percent-height-expected.png.
  • fast/dynamic/subtree-no-common-root-static-y-expected.png: Renamed from LayoutTests/platform/efl/fast/dynamic/subtree-no-common-root-static-y-expected.png.
  • fast/dynamic/subtree-table-cell-height-expected.png: Renamed from LayoutTests/platform/efl/fast/dynamic/subtree-table-cell-height-expected.png.
  • fast/inline/continuation-outlines-expected.txt: Renamed from LayoutTests/platform/efl/fast/inline/continuation-outlines-expected.txt.
  • fast/layers/self-painting-outline-expected.png: Renamed from LayoutTests/platform/efl/fast/layers/self-painting-outline-expected.png.
  • fast/multicol/layers-split-across-columns-expected.txt: Renamed from LayoutTests/platform/efl/fast/multicol/layers-split-across-columns-expected.txt.
  • fast/overflow/004-expected.txt: Renamed from LayoutTests/platform/efl/fast/overflow/004-expected.txt.
  • fast/overflow/clip-rects-fixed-ancestor-expected.txt: Renamed from LayoutTests/platform/efl/fast/overflow/clip-rects-fixed-ancestor-expected.txt.
  • fast/overflow/line-clamp-expected.txt: Renamed from LayoutTests/platform/efl/fast/overflow/line-clamp-expected.txt.
  • fast/overflow/overflow-focus-ring-expected.txt: Renamed from LayoutTests/platform/efl/fast/overflow/overflow-focus-ring-expected.txt.
  • fast/repaint/layer-outline-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/layer-outline-expected.txt.
  • fast/repaint/layer-outline-horizontal-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/layer-outline-horizontal-expected.txt.
  • fast/repaint/opacity-change-on-overflow-float-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/opacity-change-on-overflow-float-expected.txt.
  • fast/repaint/subtree-root-clip-3-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/subtree-root-clip-3-expected.png.
  • fast/table/029-expected.txt: Renamed from LayoutTests/platform/efl/fast/table/029-expected.txt.
  • fast/table/overflowHidden-expected.txt: Renamed from LayoutTests/platform/efl/fast/table/overflowHidden-expected.txt.
  • platform/chromium-linux-x86/fast/text/selection-painted-separately-expected.txt:
  • platform/chromium-linux-x86/fast/text/selection-rect-rounding-expected.txt: Added.
  • platform/chromium-linux/fast/block/margin-collapse/103-expected.txt:
  • platform/chromium-linux/fast/css/input-search-padding-expected.txt:
  • platform/chromium-linux/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-linux/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-linux/fast/forms/input-baseline-expected.txt:
  • platform/chromium-linux/fast/forms/input-text-double-click-expected.txt:
  • platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/chromium-linux/fast/forms/search-styled-expected.txt:
  • platform/chromium-linux/fast/forms/searchfield-heights-expected.txt:
  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-linux/fast/invalid/residual-style-expected.txt:
  • platform/chromium-linux/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-linux/fast/text/selection-painted-separately-expected.txt:
  • platform/chromium-linux/fast/text/selection-rect-rounding-expected.txt: Added.
  • platform/chromium-linux/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug44505-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/chromium-linux/tables/mozilla/dom/tableDom-expected.txt:
  • platform/chromium-linux/tables/mozilla/other/move_row-expected.txt:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/chromium-mac-leopard/css3/selectors3/html/css3-modsel-23-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/html/css3-modsel-24-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/html/css3-modsel-68-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/html/css3-modsel-69-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/xhtml/css3-modsel-23-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/xhtml/css3-modsel-24-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/xhtml/css3-modsel-68-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/xhtml/css3-modsel-69-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/xml/css3-modsel-23-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/xml/css3-modsel-24-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/xml/css3-modsel-68-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/xml/css3-modsel-69-expected.png:
  • platform/chromium-mac-leopard/fast/events/context-no-deselect-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/forms/input-disabled-color-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-disabled-color-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/forms/number/input-appearance-number-rtl-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/inline/continuation-outlines-expected.png:
  • platform/chromium-mac-leopard/fast/text/selection-painted-separately-expected.txt:
  • platform/chromium-mac-leopard/fast/text/selection-rect-rounding-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/events/context-no-deselect-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-disabled-color-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-disabled-color-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-number-rtl-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/inline/continuation-outlines-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/selection-painted-separately-expected.txt:
  • platform/chromium-mac-snowleopard/fast/text/selection-rect-rounding-expected.txt:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-23-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-24-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-68-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-69-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-23-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-24-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-68-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-69-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-23-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-24-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-68-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-69-expected.png:
  • platform/chromium-mac/fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt: Removed.
  • platform/chromium-mac/fast/block/float/shrink-to-avoid-float-complexity-expected.txt: Removed.
  • platform/chromium-mac/fast/block/lineboxcontain/parsing-invalid-expected.txt: Removed.
  • platform/chromium-mac/fast/block/margin-collapse/103-expected.txt: Removed.
  • platform/chromium-mac/fast/css/input-search-padding-expected.txt: Removed.
  • platform/chromium-mac/fast/css/invalidation-errors-2-expected.txt: Removed.
  • platform/chromium-mac/fast/css/invalidation-errors-expected.txt: Removed.
  • platform/chromium-mac/fast/css/line-height-expected.txt: Removed.
  • platform/chromium-mac/fast/css/nested-layers-with-hover-expected.txt: Removed.
  • platform/chromium-mac/fast/css/text-input-with-webkit-border-radius-expected.txt: Removed.
  • platform/chromium-mac/fast/css/text-overflow-input-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/isindex-001-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/isindex-002-expected.txt: Removed.
  • platform/chromium-mac/fast/events/context-no-deselect-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/basic-inputs-expected.txt:
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-mac/fast/forms/encoding-test-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/fieldset-align-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/floating-textfield-relayout-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-align-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-default-bkcolor-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-disabled-expected.txt:
  • platform/chromium-mac/fast/forms/input-appearance-focus-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-mac/fast/forms/input-appearance-readonly-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-visibility-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-width-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-baseline-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-disabled-color-expected.png:
  • platform/chromium-mac/fast/forms/input-double-click-selection-gap-bug-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-field-text-truncated-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-placeholder-visibility-1-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-placeholder-visibility-3-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-readonly-empty-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-spaces-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-table-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-text-click-inside-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-text-click-outside-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-text-double-click-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-text-option-delete-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-text-self-emptying-click-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-width-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/number/input-appearance-number-rtl-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/chromium-mac/fast/forms/plaintext-mode-2-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/chromium-mac/fast/forms/search-cancel-button-style-sharing-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/search-display-none-cancel-button-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/search-rtl-expected.png:
  • platform/chromium-mac/fast/forms/search-styled-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-mac/fast/forms/search-vertical-alignment-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/searchfield-heights-expected.png:
  • platform/chromium-mac/fast/forms/searchfield-heights-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/tabbing-input-iframe-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/textfield-focus-ring-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-mac/fast/forms/visual-hebrew-text-field-expected.txt: Removed.
  • platform/chromium-mac/fast/frames/take-focus-from-iframe-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-no-summary4-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-open-javascript-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-open2-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-open4-expected.txt: Removed.
  • platform/chromium-mac/fast/inline/continuation-outlines-expected.png:
  • platform/chromium-mac/fast/invalid/residual-style-expected.txt: Removed.
  • platform/chromium-mac/fast/lists/dynamic-marker-crash-expected.txt: Removed.
  • platform/chromium-mac/fast/multicol/layers-split-across-columns-expected.txt: Removed.
  • platform/chromium-mac/fast/overflow/004-expected.txt: Removed.
  • platform/chromium-mac/fast/overflow/clip-rects-fixed-ancestor-expected.txt: Removed.
  • platform/chromium-mac/fast/overflow/line-clamp-expected.txt: Removed.
  • platform/chromium-mac/fast/overflow/overflow-focus-ring-expected.txt: Removed.
  • platform/chromium-mac/fast/repaint/layer-outline-expected.txt: Removed.
  • platform/chromium-mac/fast/repaint/layer-outline-horizontal-expected.txt: Removed.
  • platform/chromium-mac/fast/repaint/opacity-change-on-overflow-float-expected.txt: Removed.
  • platform/chromium-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt: Removed.
  • platform/chromium-mac/fast/replaced/replaced-breaking-mixture-expected.txt: Removed.
  • platform/chromium-mac/fast/replaced/width100percent-textfield-expected.txt: Removed.
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-mac/fast/speech/speech-bidi-rendering-expected.txt: Removed.
  • platform/chromium-mac/fast/table/003-expected.txt: Removed.
  • platform/chromium-mac/fast/table/029-expected.txt: Removed.
  • platform/chromium-mac/fast/table/colspanMinWidth-expected.txt: Removed.
  • platform/chromium-mac/fast/table/overflowHidden-expected.txt: Removed.
  • platform/chromium-mac/fast/table/spanOverlapRepaint-expected.txt: Removed.
  • platform/chromium-mac/fast/table/text-field-baseline-expected.txt: Removed.
  • platform/chromium-mac/fast/text/selection-painted-separately-expected.txt:
  • platform/chromium-mac/fast/transforms/transformed-focused-text-input-expected.txt: Removed.
  • platform/chromium-mac/http/tests/navigation/javascriptlink-frames-expected.txt: Removed.
  • platform/chromium-mac/plugins/mouse-click-plugin-clears-selection-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/45621-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug12384-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug154780-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug24200-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-3-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-4-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug4382-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug44505-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-1-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-2-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug51037-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug55545-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug7342-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/dom/tableDom-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/other/move_row-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug45621-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt: Removed.
  • platform/chromium-win-vista/fast/text/selection-painted-separately-expected.txt:
  • platform/chromium-win-vista/fast/text/selection-rect-rounding-expected.txt: Added.
  • platform/chromium-win-xp/fast/forms/search-styled-expected.txt:
  • platform/chromium-win-xp/fast/text/selection-painted-separately-expected.txt:
  • platform/chromium-win-xp/fast/text/selection-rect-rounding-expected.txt: Added.
  • platform/chromium-win/fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt:
  • platform/chromium-win/fast/block/float/shrink-to-avoid-float-complexity-expected.txt:
  • platform/chromium-win/fast/block/lineboxcontain/parsing-invalid-expected.txt:
  • platform/chromium-win/fast/block/margin-collapse/103-expected.txt:
  • platform/chromium-win/fast/css/input-search-padding-expected.txt:
  • platform/chromium-win/fast/css/invalidation-errors-2-expected.txt:
  • platform/chromium-win/fast/css/invalidation-errors-expected.txt:
  • platform/chromium-win/fast/css/line-height-expected.txt:
  • platform/chromium-win/fast/css/nested-layers-with-hover-expected.txt:
  • platform/chromium-win/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/chromium-win/fast/css/text-overflow-input-expected.txt:
  • platform/chromium-win/fast/dom/isindex-001-expected.txt:
  • platform/chromium-win/fast/dom/isindex-002-expected.txt:
  • platform/chromium-win/fast/events/autoscroll-expected.txt:
  • platform/chromium-win/fast/events/context-no-deselect-expected.txt:
  • platform/chromium-win/fast/forms/basic-inputs-expected.txt:
  • platform/chromium-win/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-win/fast/forms/encoding-test-expected.txt:
  • platform/chromium-win/fast/forms/fieldset-align-expected.txt:
  • platform/chromium-win/fast/forms/floating-textfield-relayout-expected.txt:
  • platform/chromium-win/fast/forms/input-align-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-default-bkcolor-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-disabled-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-focus-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-readonly-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-selection-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-visibility-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-width-expected.txt:
  • platform/chromium-win/fast/forms/input-baseline-expected.txt:
  • platform/chromium-win/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/chromium-win/fast/forms/input-field-text-truncated-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/chromium-win/fast/forms/input-readonly-empty-expected.txt:
  • platform/chromium-win/fast/forms/input-spaces-expected.txt:
  • platform/chromium-win/fast/forms/input-table-expected.txt:
  • platform/chromium-win/fast/forms/input-text-click-inside-expected.txt:
  • platform/chromium-win/fast/forms/input-text-click-outside-expected.txt:
  • platform/chromium-win/fast/forms/input-text-double-click-expected.txt:
  • platform/chromium-win/fast/forms/input-text-option-delete-expected.txt:
  • platform/chromium-win/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/chromium-win/fast/forms/input-width-expected.txt:
  • platform/chromium-win/fast/forms/number/input-appearance-number-rtl-expected.txt:
  • platform/chromium-win/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/chromium-win/fast/forms/number/input-appearance-spinbutton-layer-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/chromium-win/fast/forms/plaintext-mode-2-expected.txt:
  • platform/chromium-win/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/chromium-win/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/chromium-win/fast/forms/search-rtl-expected.txt:
  • platform/chromium-win/fast/forms/search-styled-expected.txt:
  • platform/chromium-win/fast/forms/search-vertical-alignment-expected.txt:
  • platform/chromium-win/fast/forms/searchfield-heights-expected.txt:
  • platform/chromium-win/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/chromium-win/fast/forms/textfield-focus-ring-expected.txt:
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-win/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/chromium-win/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/chromium-win/fast/html/details-no-summary4-expected.txt:
  • platform/chromium-win/fast/html/details-open-javascript-expected.txt:
  • platform/chromium-win/fast/html/details-open2-expected.txt:
  • platform/chromium-win/fast/html/details-open4-expected.txt:
  • platform/chromium-win/fast/invalid/residual-style-expected.txt:
  • platform/chromium-win/fast/lists/dynamic-marker-crash-expected.txt:
  • platform/chromium-win/fast/multicol/layers-split-across-columns-expected.txt:
  • platform/chromium-win/fast/overflow/004-expected.txt:
  • platform/chromium-win/fast/overflow/clip-rects-fixed-ancestor-expected.txt:
  • platform/chromium-win/fast/overflow/line-clamp-expected.txt:
  • platform/chromium-win/fast/overflow/overflow-focus-ring-expected.txt:
  • platform/chromium-win/fast/repaint/layer-outline-expected.txt:
  • platform/chromium-win/fast/repaint/layer-outline-horizontal-expected.txt:
  • platform/chromium-win/fast/repaint/opacity-change-on-overflow-float-expected.txt:
  • platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/chromium-win/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/chromium-win/fast/replaced/width100percent-textfield-expected.txt:
  • platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-win/fast/speech/speech-bidi-rendering-expected.txt:
  • platform/chromium-win/fast/table/003-expected.txt:
  • platform/chromium-win/fast/table/029-expected.txt:
  • platform/chromium-win/fast/table/colspanMinWidth-expected.txt:
  • platform/chromium-win/fast/table/overflowHidden-expected.txt:
  • platform/chromium-win/fast/table/spanOverlapRepaint-expected.txt:
  • platform/chromium-win/fast/table/text-field-baseline-expected.txt:
  • platform/chromium-win/fast/text/selection-painted-separately-expected.txt:
  • platform/chromium-win/fast/text/selection-rect-rounding-expected.txt:
  • platform/chromium-win/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/chromium-win/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/chromium-win/plugins/mouse-click-plugin-clears-selection-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/45621-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug12384-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug154780-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug24200-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug44505-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug55545-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/chromium-win/tables/mozilla/dom/tableDom-expected.txt:
  • platform/chromium-win/tables/mozilla/other/move_row-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug45621-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
  • platform/chromium/fast/block/float/033-expected.txt: Removed.
  • platform/chromium/fast/block/float/avoidance-rtl-expected.txt: Removed.
  • platform/chromium/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Removed.
  • platform/chromium/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt: Removed.
  • platform/chromium/fast/block/float/in-margin-expected.txt: Removed.
  • platform/chromium/fast/clip/017-expected.txt: Removed.
  • platform/chromium/fast/dynamic/subtree-boundary-percent-height-expected.txt: Removed.
  • platform/chromium/fast/dynamic/subtree-no-common-root-static-y-expected.txt: Removed.
  • platform/chromium/fast/dynamic/subtree-table-cell-height-expected.txt: Removed.
  • platform/chromium/fast/layers/self-painting-outline-expected.txt: Removed.
  • platform/chromium/fast/repaint/subtree-root-clip-3-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/efl/fast/block/float/033-expected.txt: Removed.
  • platform/gtk/css3/selectors3/html/css3-modsel-23-expected.txt: Removed.
  • platform/gtk/css3/selectors3/html/css3-modsel-24-expected.txt: Removed.
  • platform/gtk/css3/selectors3/html/css3-modsel-68-expected.txt: Removed.
  • platform/gtk/css3/selectors3/html/css3-modsel-69-expected.txt: Removed.
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-23-expected.txt: Removed.
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-24-expected.txt: Removed.
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-68-expected.txt: Removed.
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-69-expected.txt: Removed.
  • platform/gtk/css3/selectors3/xml/css3-modsel-23-expected.txt: Removed.
  • platform/gtk/css3/selectors3/xml/css3-modsel-24-expected.txt: Removed.
  • platform/gtk/css3/selectors3/xml/css3-modsel-68-expected.txt: Removed.
  • platform/gtk/css3/selectors3/xml/css3-modsel-69-expected.txt: Removed.
  • platform/gtk/fast/block/float/033-expected.txt: Removed.
  • platform/gtk/fast/block/float/avoidance-rtl-expected.txt: Removed.
  • platform/gtk/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Removed.
  • platform/gtk/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt: Removed.
  • platform/gtk/fast/block/float/in-margin-expected.png: Removed.
  • platform/gtk/fast/block/float/in-margin-expected.txt: Removed.
  • platform/gtk/fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt: Removed.
  • platform/gtk/fast/block/float/shrink-to-avoid-float-complexity-expected.txt: Removed.
  • platform/gtk/fast/block/lineboxcontain/parsing-invalid-expected.txt: Removed.
  • platform/gtk/fast/clip/017-expected.png: Removed.
  • platform/gtk/fast/clip/017-expected.txt: Removed.
  • platform/gtk/fast/css/invalidation-errors-2-expected.txt: Removed.
  • platform/gtk/fast/css/invalidation-errors-expected.txt: Removed.
  • platform/gtk/fast/css/nested-layers-with-hover-expected.txt: Removed.
  • platform/gtk/fast/dynamic/subtree-boundary-percent-height-expected.png: Removed.
  • platform/gtk/fast/dynamic/subtree-boundary-percent-height-expected.txt: Removed.
  • platform/gtk/fast/dynamic/subtree-no-common-root-static-y-expected.png: Removed.
  • platform/gtk/fast/dynamic/subtree-no-common-root-static-y-expected.txt: Removed.
  • platform/gtk/fast/dynamic/subtree-table-cell-height-expected.png: Removed.
  • platform/gtk/fast/dynamic/subtree-table-cell-height-expected.txt: Removed.
  • platform/gtk/fast/inline/continuation-outlines-expected.txt: Removed.
  • platform/gtk/fast/layers/self-painting-outline-expected.png: Removed.
  • platform/gtk/fast/layers/self-painting-outline-expected.txt: Removed.
  • platform/gtk/fast/multicol/layers-split-across-columns-expected.txt: Removed.
  • platform/gtk/fast/overflow/004-expected.txt: Removed.
  • platform/gtk/fast/overflow/clip-rects-fixed-ancestor-expected.txt: Removed.
  • platform/gtk/fast/overflow/line-clamp-expected.txt: Removed.
  • platform/gtk/fast/overflow/overflow-focus-ring-expected.txt: Removed.
  • platform/gtk/fast/repaint/layer-outline-expected.txt: Removed.
  • platform/gtk/fast/repaint/layer-outline-horizontal-expected.txt: Removed.
  • platform/gtk/fast/repaint/opacity-change-on-overflow-float-expected.txt: Removed.
  • platform/gtk/fast/repaint/subtree-root-clip-3-expected.png: Removed.
  • platform/gtk/fast/repaint/subtree-root-clip-3-expected.txt: Removed.
  • platform/gtk/fast/table/029-expected.txt: Removed.
  • platform/gtk/fast/table/overflowHidden-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug154780-expected.txt: Removed.
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug45621-expected.png: Removed.
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug45621-expected.txt: Removed.
  • platform/mac/fast/block/float/033-expected.txt: Removed.
  • platform/mac/fast/block/float/float-not-removed-from-next-sibling3-expected.png: Removed.
  • platform/mac/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt: Removed.
  • platform/mac/fast/block/float/in-margin-expected.txt: Removed.
  • platform/mac/fast/clip/017-expected.txt: Removed.
  • platform/mac/fast/dynamic/subtree-boundary-percent-height-expected.txt: Removed.
  • platform/mac/fast/dynamic/subtree-no-common-root-static-y-expected.txt: Removed.
  • platform/mac/fast/dynamic/subtree-table-cell-height-expected.txt: Removed.
  • platform/qt/fast/block/float/avoidance-rtl-expected.txt: Removed.
  • platform/qt/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt: Removed.
  • platform/qt/fast/block/float/in-margin-expected.txt: Removed.
  • platform/qt/fast/clip/017-expected.txt: Removed.
  • platform/qt/fast/css/resize-single-axis-expected.txt: Removed.
  • platform/qt/fast/dynamic/subtree-boundary-percent-height-expected.txt: Removed.
  • platform/qt/fast/dynamic/subtree-no-common-root-static-y-expected.txt: Removed.
  • platform/qt/fast/dynamic/subtree-table-cell-height-expected.txt: Removed.
  • platform/qt/fast/layers/self-painting-outline-expected.txt: Removed.
  • platform/qt/fast/repaint/subtree-root-clip-3-expected.txt: Removed.
  • tables/mozilla/bugs/bug154780-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug154780-expected.txt.
  • tables/mozilla_expected_failures/bugs/bug45621-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/bugs/bug45621-expected.png.
  • tables/mozilla_expected_failures/bugs/bug45621-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/bugs/bug45621-expected.txt.

May 11, 2012:

11:45 PM Changeset in webkit [116840] by pilgrim@chromium.org
  • 11 edits
    3 adds in trunk/Source

[Chromium] Call isLinkVisited directly
https://bugs.webkit.org/show_bug.cgi?id=85412

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/PageGroup.cpp:

(WebCore::PageGroup::isLinkVisited):

  • platform/VisitedLinks.cpp: Added.

(WebCore):
(WebCore::VisitedLinks::isLinkVisited):

  • platform/VisitedLinks.h: Added.

(WebCore):
(VisitedLinks):

  • platform/chromium/PlatformSupport.h:
  • platform/chromium/VisitedLinksChromium.cpp: Added.

(WebCore):
(WebCore::VisitedLinks::isLinkVisited):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore):

10:43 PM Changeset in webkit [116839] by noel.gordon@gmail.com
  • 429 edits
    2 copies
    60 moves
    74 adds
    71 deletes in trunk/LayoutTests

Optimise and update test expectations after r116636

Unreviewed test expectations update.

  • fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Renamed from LayoutTests/platform/efl/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt.
  • fast/block/float/014-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/float/014-expected.txt.
  • fast/images/gray-scale-jpeg-with-color-profile-expected.txt:
  • fast/repaint/backgroundSizeRepaint-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/backgroundSizeRepaint-expected.txt.
  • fast/repaint/clipped-relative-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/clipped-relative-expected.txt.
  • fast/repaint/selected-replaced-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/selected-replaced-expected.txt.
  • fast/replaced/absolute-image-sizing-expected.txt: Renamed from LayoutTests/platform/efl/fast/replaced/absolute-image-sizing-expected.txt.
  • fast/replaced/image-onload-expected.txt: Renamed from LayoutTests/platform/efl/fast/replaced/image-onload-expected.txt.
  • fast/replaced/image-sizing-expected.txt: Renamed from LayoutTests/platform/efl/fast/replaced/image-sizing-expected.txt.
  • fast/replaced/width100percent-image-expected.txt: Renamed from LayoutTests/platform/efl/fast/replaced/width100percent-image-expected.txt.
  • fast/writing-mode/background-horizontal-bt-expected.txt: Renamed from LayoutTests/platform/efl/fast/writing-mode/background-horizontal-bt-expected.txt.
  • fast/writing-mode/background-vertical-lr-expected.txt: Renamed from LayoutTests/platform/efl/fast/writing-mode/background-vertical-lr-expected.txt.
  • fast/writing-mode/background-vertical-rl-expected.txt: Renamed from LayoutTests/platform/efl/fast/writing-mode/background-vertical-rl-expected.txt.
  • platform/chromium-linux-x86/fast/backgrounds/size/backgroundSize20-expected.png: Added.
  • platform/chromium-linux-x86/fast/backgrounds/size/backgroundSize21-expected.png: Added.
  • platform/chromium-linux-x86/fast/backgrounds/size/backgroundSize22-expected.png: Added.
  • platform/chromium-linux-x86/fast/replaced/image-tag-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug120107-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug1271-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug12908-2-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug13169-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug196870-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug50695-2-expected.png: Added.
  • platform/chromium-linux/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize20-expected.png: Added.
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize21-expected.png: Added.
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize22-expected.png: Added.
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-linux/fast/block/float/014-expected.png:
  • platform/chromium-linux/fast/images/gray-scale-jpeg-with-color-profile-expected.png:
  • platform/chromium-linux/fast/repaint/backgroundSizeRepaint-expected.png:
  • platform/chromium-linux/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/chromium-linux/fast/repaint/clipped-relative-expected.png:
  • platform/chromium-linux/fast/repaint/selected-replaced-expected.png:
  • platform/chromium-linux/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-linux/fast/replaced/image-onload-expected.png:
  • platform/chromium-linux/fast/replaced/image-sizing-expected.png:
  • platform/chromium-linux/fast/replaced/image-tag-expected.png: Added.
  • platform/chromium-linux/fast/replaced/width100percent-image-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-01-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-04-t-expected.png:
  • platform/chromium-linux/svg/carto.net/scrollbar-expected.png:
  • platform/chromium-linux/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-linux/svg/custom/image-rescale-clip-expected.png:
  • platform/chromium-linux/svg/custom/image-rescale-scroll-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug101674-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug10565-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug11026-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug120107-expected.png: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug1271-expected.png: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug12908-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug12908-2-expected.png: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug13169-expected.png: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug17138-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug196870-expected.png: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug29314-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2981-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4093-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4284-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug50695-2-expected.png: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug56563-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug5797-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug6404-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug82946-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug86708-expected.png:
  • platform/chromium-linux/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-linux/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-linux/tables/mozilla/core/misc-expected.png:
  • platform/chromium-linux/tables/mozilla/core/row_span-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/other/cell_widths-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-mac-leopard/fast/backgrounds/size/backgroundSize20-expected.png: Added.
  • platform/chromium-mac-leopard/fast/backgrounds/size/backgroundSize21-expected.png: Added.
  • platform/chromium-mac-leopard/fast/backgrounds/size/backgroundSize22-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/014-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/backgroundSizeRepaint-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/clipped-relative-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/selected-replaced-expected.png:
  • platform/chromium-mac-leopard/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-mac-leopard/fast/replaced/image-onload-expected.png:
  • platform/chromium-mac-leopard/fast/replaced/image-sizing-expected.png:
  • platform/chromium-mac-leopard/fast/replaced/image-tag-expected.png: Added.
  • platform/chromium-mac-leopard/fast/replaced/width100percent-image-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.png:
  • platform/chromium-mac-leopard/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-mac-leopard/svg/custom/image-rescale-clip-expected.png:
  • platform/chromium-mac-leopard/svg/custom/image-rescale-scroll-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug101674-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug10565-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug11026-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug120107-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1271-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug12908-1-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug12908-2-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug13169-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug17138-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug196870-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2981-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4093-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4284-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug50695-2-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug56563-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug5797-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug6404-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug82946-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug86708-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/core/misc-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/core/row_span-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/other/cell_widths-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize20-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize21-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize22-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/float/014-expected.png:
  • platform/chromium-mac-snowleopard/fast/images/gray-scale-jpeg-with-color-profile-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/backgroundSizeRepaint-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/clipped-relative-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/selected-replaced-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/image-onload-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/image-sizing-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/image-tag-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-image-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/carto.net/scrollbar-expected.png:
  • platform/chromium-mac-snowleopard/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/image-rescale-clip-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/image-rescale-scroll-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug101674-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug10565-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug11026-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug120107-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1271-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug12908-1-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug12908-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug13169-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug17138-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug196870-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug29314-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2981-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4093-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4284-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug50695-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug56563-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug5797-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug6404-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug82946-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug86708-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/core/misc-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/core/row_span-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/other/cell_widths-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-mac/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize17-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize18-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize19-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize20-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize21-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize22-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-mac/fast/block/float/014-expected.png:
  • platform/chromium-mac/fast/images/gray-scale-jpeg-with-color-profile-expected.png:
  • platform/chromium-mac/fast/images/image-css3-content-data-expected.png:
  • platform/chromium-mac/fast/images/rgb-jpeg-with-adobe-marker-only-expected.png:
  • platform/chromium-mac/fast/images/ycbcr-with-cmyk-color-profile-expected.png:
  • platform/chromium-mac/fast/repaint/backgroundSizeRepaint-expected.png:
  • platform/chromium-mac/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/chromium-mac/fast/repaint/clipped-relative-expected.png:
  • platform/chromium-mac/fast/repaint/selected-replaced-expected.png:
  • platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-mac/fast/replaced/image-onload-expected.png:
  • platform/chromium-mac/fast/replaced/image-sizing-expected.png:
  • platform/chromium-mac/fast/replaced/image-tag-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-image-expected.png:
  • platform/chromium-mac/fast/writing-mode/background-horizontal-bt-expected.png:
  • platform/chromium-mac/fast/writing-mode/background-vertical-lr-expected.png:
  • platform/chromium-mac/fast/writing-mode/background-vertical-rl-expected.png:
  • platform/chromium-mac/platform/chromium/compositing/img-layer-grow-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-01-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-04-t-expected.png:
  • platform/chromium-mac/svg/carto.net/scrollbar-expected.png:
  • platform/chromium-mac/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-mac/svg/custom/image-rescale-clip-expected.png:
  • platform/chromium-mac/svg/custom/image-rescale-expected.png:
  • platform/chromium-mac/svg/custom/image-rescale-scroll-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac/svg/repaint/image-href-change-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug101674-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug10565-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug11026-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug120107-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1271-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug12908-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug12908-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug13169-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug17138-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug196870-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug29314-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2981-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4093-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4284-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug50695-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug56563-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug5797-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug6404-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug82946-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug86708-expected.png:
  • platform/chromium-mac/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-mac/tables/mozilla/core/misc-expected.png:
  • platform/chromium-mac/tables/mozilla/core/row_span-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/other/cell_widths-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-win-vista/fast/backgrounds/size/backgroundSize20-expected.png: Added.
  • platform/chromium-win-vista/fast/backgrounds/size/backgroundSize21-expected.png: Added.
  • platform/chromium-win-vista/fast/backgrounds/size/backgroundSize22-expected.png: Added.
  • platform/chromium-win-vista/fast/replaced/image-tag-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla/bugs/bug120107-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla/bugs/bug1271-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla/bugs/bug12908-2-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla/bugs/bug13169-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla/bugs/bug196870-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla/bugs/bug50695-2-expected.png: Added.
  • platform/chromium-win-xp/fast/backgrounds/size/backgroundSize20-expected.png: Added.
  • platform/chromium-win-xp/fast/backgrounds/size/backgroundSize21-expected.png: Added.
  • platform/chromium-win-xp/fast/backgrounds/size/backgroundSize22-expected.png: Added.
  • platform/chromium-win-xp/fast/replaced/image-tag-expected.png: Added.
  • platform/chromium-win-xp/tables/mozilla/bugs/bug120107-expected.png: Added.
  • platform/chromium-win-xp/tables/mozilla/bugs/bug1271-expected.png: Added.
  • platform/chromium-win-xp/tables/mozilla/bugs/bug12908-2-expected.png: Added.
  • platform/chromium-win-xp/tables/mozilla/bugs/bug13169-expected.png: Added.
  • platform/chromium-win-xp/tables/mozilla/bugs/bug196870-expected.png: Added.
  • platform/chromium-win-xp/tables/mozilla/bugs/bug50695-2-expected.png: Added.
  • platform/chromium-win/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize17-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize18-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize19-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize20-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize21-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize22-expected.png:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-win/fast/block/float/014-expected.png:
  • platform/chromium-win/fast/images/gray-scale-jpeg-with-color-profile-expected.png:
  • platform/chromium-win/fast/images/image-css3-content-data-expected.png:
  • platform/chromium-win/fast/images/rgb-jpeg-with-adobe-marker-only-expected.png:
  • platform/chromium-win/fast/images/ycbcr-with-cmyk-color-profile-expected.png:
  • platform/chromium-win/fast/repaint/backgroundSizeRepaint-expected.png:
  • platform/chromium-win/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/chromium-win/fast/repaint/clipped-relative-expected.png:
  • platform/chromium-win/fast/repaint/selected-replaced-expected.png:
  • platform/chromium-win/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-win/fast/replaced/image-onload-expected.png:
  • platform/chromium-win/fast/replaced/image-sizing-expected.png:
  • platform/chromium-win/fast/replaced/image-tag-expected.png:
  • platform/chromium-win/fast/replaced/width100percent-image-expected.png:
  • platform/chromium-win/fast/writing-mode/background-horizontal-bt-expected.png:
  • platform/chromium-win/fast/writing-mode/background-vertical-lr-expected.png:
  • platform/chromium-win/fast/writing-mode/background-vertical-rl-expected.png:
  • platform/chromium-win/platform/chromium/compositing/img-layer-grow-expected.png: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-image-01-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-image-04-t-expected.png:
  • platform/chromium-win/svg/carto.net/scrollbar-expected.png:
  • platform/chromium-win/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-win/svg/custom/image-rescale-clip-expected.png:
  • platform/chromium-win/svg/custom/image-rescale-expected.png:
  • platform/chromium-win/svg/custom/image-rescale-scroll-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-win/svg/repaint/image-href-change-expected.png: Added.
  • platform/chromium-win/tables/mozilla/bugs/bug101674-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug10565-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug11026-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug120107-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1271-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug12908-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug12908-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug13169-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug17138-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug196870-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug29314-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2981-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4093-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4284-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug50695-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug56563-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug5797-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug6404-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug82946-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug86708-expected.png:
  • platform/chromium-win/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-win/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-win/tables/mozilla/core/misc-expected.png:
  • platform/chromium-win/tables/mozilla/core/row_span-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/other/cell_widths-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/efl/fast/images/gray-scale-jpeg-with-color-profile-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug29314-expected.txt: Removed.
  • platform/gtk/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Removed.
  • platform/gtk/fast/block/float/014-expected.txt: Removed.
  • platform/gtk/fast/images/gray-scale-jpeg-with-color-profile-expected.txt: Removed.
  • platform/gtk/fast/repaint/backgroundSizeRepaint-expected.txt: Removed.
  • platform/gtk/fast/repaint/clipped-relative-expected.txt: Removed.
  • platform/gtk/fast/repaint/selected-replaced-expected.txt: Removed.
  • platform/gtk/fast/replaced/absolute-image-sizing-expected.txt: Removed.
  • platform/gtk/fast/replaced/image-onload-expected.txt: Removed.
  • platform/gtk/fast/replaced/image-sizing-expected.txt: Removed.
  • platform/gtk/fast/replaced/width100percent-image-expected.txt: Removed.
  • platform/gtk/fast/writing-mode/background-horizontal-bt-expected.txt: Removed.
  • platform/gtk/fast/writing-mode/background-vertical-lr-expected.txt: Removed.
  • platform/gtk/fast/writing-mode/background-vertical-rl-expected.txt: Removed.
  • platform/gtk/svg/carto.net/scrollbar-expected.txt: Removed.
  • platform/gtk/svg/carto.net/selectionlist-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug10565-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug11026-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug12908-1-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug1296-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug1430-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug15544-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug17138-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug29314-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug2981-2-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug4093-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug4284-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug4427-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug56563-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug5797-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug625-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug6404-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug82946-2-expected.txt: Removed.
  • platform/gtk/tables/mozilla/core/bloomberg-expected.txt: Removed.
  • platform/gtk/tables/mozilla/core/col_widths_auto_autoFix-expected.txt: Removed.
  • platform/gtk/tables/mozilla/core/misc-expected.txt: Removed.
  • platform/gtk/tables/mozilla/core/row_span-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/tbody_valign_baseline-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/tbody_valign_bottom-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/tbody_valign_middle-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/tbody_valign_top-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/td_valign_baseline-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/td_valign_bottom-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/td_valign_middle-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/td_valign_top-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/tfoot_valign_bottom-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/tfoot_valign_middle-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/tfoot_valign_top-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/th_valign_baseline-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/th_valign_bottom-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/th_valign_middle-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/th_valign_top-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/thead_valign_baseline-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/thead_valign_bottom-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/thead_valign_middle-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/thead_valign_top-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/tr_valign_baseline-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/tr_valign_bottom-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/tr_valign_middle-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/tr_valign_top-expected.txt: Removed.
  • platform/gtk/tables/mozilla/other/cell_widths-expected.txt: Removed.
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug6933-expected.txt: Removed.
  • platform/mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Removed.
  • platform/mac/fast/images/gray-scale-jpeg-with-color-profile-expected.txt: Removed.
  • platform/mac/tables/mozilla/bugs/bug29314-expected.txt: Removed.
  • platform/qt/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Removed.
  • platform/qt/fast/images/gray-scale-jpeg-with-color-profile-expected.txt: Copied from LayoutTests/fast/images/gray-scale-jpeg-with-color-profile-expected.txt.
  • platform/qt/tables/mozilla/bugs/bug29314-expected.txt: Copied from LayoutTests/tables/mozilla/bugs/bug29314-expected.txt.
  • svg/carto.net/scrollbar-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/scrollbar-expected.txt.
  • svg/carto.net/selectionlist-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/selectionlist-expected.txt.
  • tables/mozilla/bugs/bug10565-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug10565-expected.txt.
  • tables/mozilla/bugs/bug11026-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug11026-expected.txt.
  • tables/mozilla/bugs/bug12908-1-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug12908-1-expected.txt.
  • tables/mozilla/bugs/bug1296-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug1296-expected.txt.
  • tables/mozilla/bugs/bug1430-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug1430-expected.txt.
  • tables/mozilla/bugs/bug15544-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug15544-expected.txt.
  • tables/mozilla/bugs/bug17138-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug17138-expected.txt.
  • tables/mozilla/bugs/bug29314-expected.txt:
  • tables/mozilla/bugs/bug2981-2-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug2981-2-expected.txt.
  • tables/mozilla/bugs/bug4093-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug4093-expected.txt.
  • tables/mozilla/bugs/bug4284-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug4284-expected.txt.
  • tables/mozilla/bugs/bug4427-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug4427-expected.txt.
  • tables/mozilla/bugs/bug56563-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug56563-expected.txt.
  • tables/mozilla/bugs/bug5797-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug5797-expected.txt.
  • tables/mozilla/bugs/bug625-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug625-expected.txt.
  • tables/mozilla/bugs/bug6404-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug6404-expected.txt.
  • tables/mozilla/bugs/bug82946-2-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug82946-2-expected.txt.
  • tables/mozilla/core/bloomberg-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/core/bloomberg-expected.txt.
  • tables/mozilla/core/col_widths_auto_autoFix-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/core/col_widths_auto_autoFix-expected.txt.
  • tables/mozilla/core/misc-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/core/misc-expected.txt.
  • tables/mozilla/core/row_span-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/core/row_span-expected.txt.
  • tables/mozilla/marvin/tbody_valign_baseline-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/tbody_valign_baseline-expected.txt.
  • tables/mozilla/marvin/tbody_valign_bottom-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/tbody_valign_bottom-expected.txt.
  • tables/mozilla/marvin/tbody_valign_middle-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/tbody_valign_middle-expected.txt.
  • tables/mozilla/marvin/tbody_valign_top-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/tbody_valign_top-expected.txt.
  • tables/mozilla/marvin/td_valign_baseline-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/td_valign_baseline-expected.txt.
  • tables/mozilla/marvin/td_valign_bottom-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/td_valign_bottom-expected.txt.
  • tables/mozilla/marvin/td_valign_middle-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/td_valign_middle-expected.txt.
  • tables/mozilla/marvin/td_valign_top-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/td_valign_top-expected.txt.
  • tables/mozilla/marvin/tfoot_valign_baseline-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt.
  • tables/mozilla/marvin/tfoot_valign_bottom-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/tfoot_valign_bottom-expected.txt.
  • tables/mozilla/marvin/tfoot_valign_middle-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/tfoot_valign_middle-expected.txt.
  • tables/mozilla/marvin/tfoot_valign_top-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/tfoot_valign_top-expected.txt.
  • tables/mozilla/marvin/th_valign_baseline-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/th_valign_baseline-expected.txt.
  • tables/mozilla/marvin/th_valign_bottom-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/th_valign_bottom-expected.txt.
  • tables/mozilla/marvin/th_valign_middle-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/th_valign_middle-expected.txt.
  • tables/mozilla/marvin/th_valign_top-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/th_valign_top-expected.txt.
  • tables/mozilla/marvin/thead_valign_baseline-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/thead_valign_baseline-expected.txt.
  • tables/mozilla/marvin/thead_valign_bottom-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/thead_valign_bottom-expected.txt.
  • tables/mozilla/marvin/thead_valign_middle-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/thead_valign_middle-expected.txt.
  • tables/mozilla/marvin/thead_valign_top-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/thead_valign_top-expected.txt.
  • tables/mozilla/marvin/tr_valign_baseline-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/tr_valign_baseline-expected.txt.
  • tables/mozilla/marvin/tr_valign_bottom-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/tr_valign_bottom-expected.txt.
  • tables/mozilla/marvin/tr_valign_middle-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/tr_valign_middle-expected.txt.
  • tables/mozilla/marvin/tr_valign_top-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/tr_valign_top-expected.txt.
  • tables/mozilla/other/cell_widths-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/other/cell_widths-expected.txt.
  • tables/mozilla_expected_failures/bugs/bug6933-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/bugs/bug6933-expected.txt.
9:14 PM Changeset in webkit [116838] by fpizlo@apple.com
  • 19 edits in branches/dfgopt/Source/JavaScriptCore

DFG should be able to inline functions that use arguments reflectively
https://bugs.webkit.org/show_bug.cgi?id=86132

Reviewed by Oliver Hunt.

This turns on inlining of functions that use arguments reflectively, but it
does not do any of the obvious optimizations that this exposes. I'll save that
for another patch - the important thing for now is that this contains all of
the plumbing necessary to make this kind of inlining sound even in bizarro
cases like an inline callee escaping the arguments object to parts of the
inline caller where the arguments are otherwise dead. Or even more fun cases
like where you've inlined to an inline stack that is three-deep, and the
function on top of the inline stack reflectively accesses the arguments of a
function that is in the middle of the inline stack. Any subsequent
optimizations that we do for the obvious cases of arguments usage in inline
functions will have to take care not to break the baseline functionality that
this patch plumbs together.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printCallOp):
(JSC::CodeBlock::dump):

  • bytecode/CodeBlock.h:
  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::argumentsRegisterFor):
(AssemblyHelpers):

  • dfg/DFGByteCodeParser.cpp:

(InlineStackEntry):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGCCallHelpers.h:

(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(CCallHelpers):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canInlineOpcode):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • interpreter/CallFrame.cpp:

(JSC):
(JSC::CallFrame::someCodeBlockForPossiblyInlinedCode):

  • interpreter/CallFrame.h:

(ExecState):
(JSC::ExecState::someCodeBlockForPossiblyInlinedCode):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::retrieveArgumentsFromVMCode):

  • runtime/Arguments.cpp:

(JSC::Arguments::tearOff):
(JSC):
(JSC::Arguments::tearOffForInlineCallFrame):

  • runtime/Arguments.h:

(Arguments):
(JSC::Arguments::create):
(JSC::Arguments::finishCreation):
(JSC):

8:15 PM Changeset in webkit [116837] by ojan@chromium.org
  • 4 edits in trunk/Tools

Add previous/next buttons the garden-o-matics perf panel
https://bugs.webkit.org/show_bug.cgi?id=86280

Reviewed by Dimitri Glazkov.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/perf.css:
8:04 PM Changeset in webkit [116836] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Port gtest WebViewTest.ActiveState from test_shell_tests to webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=86271

Reviewed by James Robinson.

The original test is in src/webkit/glue/webview_unittest.cc.

  • tests/WebViewTest.cpp:

(WebKit::TEST_F):
(WebKit):

7:20 PM Changeset in webkit [116835] by shawnsingh@chromium.org
  • 9 edits in trunk/Source

[chromium] Plumb --show-paint-rects to accelerated compositor
https://bugs.webkit.org/show_bug.cgi?id=86255

Reviewed by James Robinson.

Source/Platform:

  • chromium/public/WebLayerTreeView.h:

(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):

Source/WebKit/chromium:

  • public/WebSettings.h:
  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCSettings):

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setShowPaintRects):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):
(WebKit::WebSettingsImpl::showFPSCounter):
(WebKit::WebSettingsImpl::showPlatformLayerTree):
(WebKit::WebSettingsImpl::showPaintRects):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::settingsImpl):
(WebKit::WebViewImpl::settings):
(WebKit):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • src/WebViewImpl.h:
7:11 PM Changeset in webkit [116834] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[TextureMapper] Tiles are not created for large textures
https://bugs.webkit.org/show_bug.cgi?id=86245

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-05-11
Reviewed by Noam Rosenthal.

No new tests. This will not produce any observable behavior changes,
unless run on a machine with a small texture size limit.

The maxTextureSize() method on TextureMapperGL was missing a "const"
keyword, meaning that it was not properly overriding the version in
the abstract base class (TextureMapper). This patch adds the const
modifier and cleans up the list of override methods in the two
TextureMapper sublcasses, adding the OVERRIDE macro for compilers that
support it and removing a couple unused methods.

  • platform/graphics/texmap/TextureMapperGL.cpp:
  • platform/graphics/texmap/TextureMapperGL.h:

(WebCore::TextureMapperGL::create):

  • platform/graphics/texmap/TextureMapperImageBuffer.h:

(TextureMapperImageBuffer):

7:04 PM Changeset in webkit [116833] by enne@google.com
  • 2 edits in trunk/Source/WebCore

[chromium] Prevent deadlock on CCVideoLayerImpl destruction
https://bugs.webkit.org/show_bug.cgi?id=86258

Reviewed by James Robinson.

~CCVideoLayerImpl had a common deadlock issue where if it got
destroyed before WebMediaPlayerClientImpl, it would take a lock,
call WebMediaPlayerClientImpl::setVideoFrameProviderClient(0),
which in turn would call CCVideoLayerImpl::stopUsingProvider(),
which would try to take the same lock and would deadlock.

CCVideoLayerImpl is only created and destroyed during tree
synchronization in a commit or during synchronous compositor thread
destruction. In either case, the main thread is blocked, and so no
lock needs to be taken at all.

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::CCVideoLayerImpl):
(WebCore::CCVideoLayerImpl::~CCVideoLayerImpl):
(WebCore::CCVideoLayerImpl::stopUsingProvider):

7:01 PM Changeset in webkit [116832] by jpfau@apple.com
  • 3 edits
    3 adds in trunk

REGRESSION (r114170): Scroll areas in nested frames improperly placed when tiled drawing is enabled
https://bugs.webkit.org/show_bug.cgi?id=86239

Reviewed by Anders Carlsson.

.:

  • ManualTests/resources/frame-textarea.html: Added.
  • ManualTests/scrollable-positioned-frame.html: Added.
  • ManualTests/scrollable-positioned-nested-frame.html: Added.

Source/WebCore:

Fixes a regression introduced in r114170 by recursively adding positions of parent frames to placement of nested frame scroll areas.

Manual tests: ManualTests/scrollable-positioned-frame.html

ManualTests/scrollable-positioned-nested-frame.html

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::computeNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):

6:19 PM Changeset in webkit [116831] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=86278
Composited layers should only run the overlay scrollbars painting pass
if necessary

Reviewed by Dan Bernstein.

It's not enough that the rootLayer has dirty scrollbars; we also have
to actually be doing the overlay scrollbars painting pass to skip the
early return.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayer):

5:56 PM Changeset in webkit [116830] by andersca@apple.com
  • 6 edits in trunk/Source/WebCore

Comcast website displays bottom of page when loaded
https://bugs.webkit.org/show_bug.cgi?id=86277
<rdar://problem/11426887>

Reviewed by Beth Dakin.

There were two bugs here. The first bug was that FrameView::setScrollPosition didn't end up calling into the scrolling coordinator
to update the scroll position. The second bug was that ScrollingTreeNodeMac::setScrollPosition didn't constrain the scroll position
to the edge of the page.

  • page/FrameView.cpp:

(WebCore::FrameView::setScrollPosition):
Call requestScrollPositionUpdate.

  • page/scrolling/ScrollingTree.cpp:
  • page/scrolling/ScrollingTree.h:

Remove setMainFrameScrollPosition, it is not called by anyone.

  • page/scrolling/mac/ScrollingTreeNodeMac.h:
  • page/scrolling/mac/ScrollingTreeNodeMac.mm:

(WebCore::ScrollingTreeNodeMac::setScrollPosition):
Clamp to the page size and call setScrollPositionWithoutContentEdgeConstraints.

(WebCore::ScrollingTreeNodeMac::setScrollPositionWithoutContentEdgeConstraints):
Update the scroll layer position and call back to the main thread.

(WebCore::ScrollingTreeNodeMac::scrollBy):
Call setScrollPosition.

(WebCore::ScrollingTreeNodeMac::scrollByWithoutContentEdgeConstraints):
Call setScrollPositionWithoutContentEdgeConstraints.

5:42 PM Changeset in webkit [116829] by commit-queue@webkit.org
  • 1 edit
    7 adds
    35 deletes in trunk/LayoutTests

Convert some MathML layout tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=86250

Patch by David Barton <Dave Barton> on 2012-05-11
Reviewed by Ryosuke Niwa.

  • mathml/presentation/msub-base-changed-expected.html: Added.
  • mathml/presentation/msub-sub-changed-expected.html: Added.
  • mathml/presentation/msubsup-base-changed-expected.html: Added.
  • mathml/presentation/msubsup-sub-changed-expected.html: Added.
  • mathml/presentation/msubsup-sup-changed-expected.html: Added.
  • mathml/presentation/msup-base-changed-expected.html: Added.
  • mathml/presentation/msup-sup-changed-expected.html: Added.
  • platform/efl/mathml/presentation/msub-base-changed-expected.png: Removed.
  • platform/efl/mathml/presentation/msub-base-changed-expected.txt: Removed.
  • platform/efl/mathml/presentation/msub-sub-changed-expected.png: Removed.
  • platform/efl/mathml/presentation/msub-sub-changed-expected.txt: Removed.
  • platform/efl/mathml/presentation/msubsup-base-changed-expected.png: Removed.
  • platform/efl/mathml/presentation/msubsup-base-changed-expected.txt: Removed.
  • platform/efl/mathml/presentation/msubsup-sub-changed-expected.png: Removed.
  • platform/efl/mathml/presentation/msubsup-sub-changed-expected.txt: Removed.
  • platform/efl/mathml/presentation/msubsup-sup-changed-expected.png: Removed.
  • platform/efl/mathml/presentation/msubsup-sup-changed-expected.txt: Removed.
  • platform/efl/mathml/presentation/msup-base-changed-expected.png: Removed.
  • platform/efl/mathml/presentation/msup-base-changed-expected.txt: Removed.
  • platform/efl/mathml/presentation/msup-sup-changed-expected.png: Removed.
  • platform/efl/mathml/presentation/msup-sup-changed-expected.txt: Removed.
  • platform/gtk/mathml/presentation/msub-base-changed-expected.txt: Removed.
  • platform/gtk/mathml/presentation/msub-sub-changed-expected.txt: Removed.
  • platform/gtk/mathml/presentation/msubsup-base-changed-expected.txt: Removed.
  • platform/gtk/mathml/presentation/msubsup-sub-changed-expected.txt: Removed.
  • platform/gtk/mathml/presentation/msubsup-sup-changed-expected.txt: Removed.
  • platform/gtk/mathml/presentation/msup-base-changed-expected.txt: Removed.
  • platform/gtk/mathml/presentation/msup-sup-changed-expected.txt: Removed.
  • platform/mac/mathml/presentation/msub-base-changed-expected.png: Removed.
  • platform/mac/mathml/presentation/msub-base-changed-expected.txt: Removed.
  • platform/mac/mathml/presentation/msub-sub-changed-expected.png: Removed.
  • platform/mac/mathml/presentation/msub-sub-changed-expected.txt: Removed.
  • platform/mac/mathml/presentation/msubsup-base-changed-expected.png: Removed.
  • platform/mac/mathml/presentation/msubsup-base-changed-expected.txt: Removed.
  • platform/mac/mathml/presentation/msubsup-sub-changed-expected.png: Removed.
  • platform/mac/mathml/presentation/msubsup-sub-changed-expected.txt: Removed.
  • platform/mac/mathml/presentation/msubsup-sup-changed-expected.png: Removed.
  • platform/mac/mathml/presentation/msubsup-sup-changed-expected.txt: Removed.
  • platform/mac/mathml/presentation/msup-base-changed-expected.png: Removed.
  • platform/mac/mathml/presentation/msup-base-changed-expected.txt: Removed.
  • platform/mac/mathml/presentation/msup-sup-changed-expected.png: Removed.
  • platform/mac/mathml/presentation/msup-sup-changed-expected.txt: Removed.
5:39 PM Changeset in webkit [116828] by barraclough@apple.com
  • 186 edits
    1 add in trunk/Source

Introduce PropertyName class
https://bugs.webkit.org/show_bug.cgi?id=86241

Reviewed by Geoff Garen.

Replace 'const Identifier&' arguments to functions accessing object properties with a new 'PropertyName' type.
This change paves the way to allow for properties keyed by values that are not Identifiers.

This change is largely a mechanical find & replace.
It also changes JSFunction's constructor to take a UString& instead of an Identifier&
(since in some cases we can no longer guarantee that we'lll have an Identifier), and
unifies Identifier's methods to obtain array indices onto PropertyName.

The new PropertyName class retains the ability to support .impl() and .ustring(), but
in a future patch we may need to rework this, since not all PropertyNames should be
equal based on their string representation.

Source/JavaScriptCore:

  • API/JSCallbackFunction.cpp:

(JSC::JSCallbackFunction::finishCreation):

  • API/JSCallbackFunction.h:

(JSCallbackFunction):
(JSC::JSCallbackFunction::create):

  • API/JSCallbackObject.h:

(JSCallbackObject):

  • API/JSCallbackObjectFunctions.h:

(JSC::::getOwnPropertySlot):
(JSC::::getOwnPropertyDescriptor):
(JSC::::put):
(JSC::::deleteProperty):
(JSC::::getStaticValue):
(JSC::::staticFunctionGetter):
(JSC::::callbackGetter):

  • API/JSObjectRef.cpp:

(JSObjectMakeFunctionWithCallback):

  • JSCTypedArrayStubs.h:

(JSC):

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • debugger/DebuggerActivation.cpp:

(JSC::DebuggerActivation::getOwnPropertySlot):
(JSC::DebuggerActivation::put):
(JSC::DebuggerActivation::putDirectVirtual):
(JSC::DebuggerActivation::deleteProperty):
(JSC::DebuggerActivation::getOwnPropertyDescriptor):
(JSC::DebuggerActivation::defineOwnProperty):

  • debugger/DebuggerActivation.h:

(DebuggerActivation):

  • jsc.cpp:

(GlobalObject::addFunction):
(GlobalObject::addConstructableFunction):

  • runtime/Arguments.cpp:

(JSC::Arguments::getOwnPropertySlot):
(JSC::Arguments::getOwnPropertyDescriptor):
(JSC::Arguments::put):
(JSC::Arguments::deleteProperty):
(JSC::Arguments::defineOwnProperty):

  • runtime/Arguments.h:

(Arguments):

  • runtime/ArrayConstructor.cpp:

(JSC::ArrayConstructor::finishCreation):
(JSC::ArrayConstructor::getOwnPropertySlot):
(JSC::ArrayConstructor::getOwnPropertyDescriptor):

  • runtime/ArrayConstructor.h:

(ArrayConstructor):

  • runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::getOwnPropertySlot):
(JSC::ArrayPrototype::getOwnPropertyDescriptor):
(JSC::putProperty):

  • runtime/ArrayPrototype.h:

(ArrayPrototype):

  • runtime/BooleanConstructor.cpp:

(JSC::BooleanConstructor::finishCreation):

  • runtime/BooleanPrototype.cpp:

(JSC::BooleanPrototype::getOwnPropertySlot):
(JSC::BooleanPrototype::getOwnPropertyDescriptor):

  • runtime/BooleanPrototype.h:

(BooleanPrototype):

  • runtime/ClassInfo.h:

(MethodTable):

  • runtime/DateConstructor.cpp:

(JSC::DateConstructor::finishCreation):
(JSC::DateConstructor::getOwnPropertySlot):
(JSC::DateConstructor::getOwnPropertyDescriptor):

  • runtime/DateConstructor.h:

(DateConstructor):

  • runtime/DatePrototype.cpp:

(JSC::DatePrototype::getOwnPropertySlot):
(JSC::DatePrototype::getOwnPropertyDescriptor):

  • runtime/DatePrototype.h:

(DatePrototype):

  • runtime/Error.h:

(JSC::StrictModeTypeErrorFunction::create):

  • runtime/ErrorConstructor.cpp:

(JSC::ErrorConstructor::finishCreation):

  • runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::getOwnPropertySlot):
(JSC::ErrorPrototype::getOwnPropertyDescriptor):

  • runtime/ErrorPrototype.h:

(ErrorPrototype):

  • runtime/FunctionConstructor.cpp:

(JSC::FunctionConstructor::finishCreation):

  • runtime/FunctionPrototype.cpp:

(JSC::FunctionPrototype::finishCreation):
(JSC::FunctionPrototype::addFunctionProperties):
(JSC::functionProtoFuncBind):

  • runtime/FunctionPrototype.h:

(JSC::FunctionPrototype::create):
(FunctionPrototype):

  • runtime/Identifier.cpp:

(JSC):

  • runtime/Identifier.h:

(Identifier):

  • runtime/InternalFunction.cpp:

(JSC::InternalFunction::finishCreation):

  • runtime/InternalFunction.h:

(InternalFunction):

  • runtime/JSActivation.cpp:

(JSC::JSActivation::symbolTableGet):
(JSC::JSActivation::symbolTablePut):
(JSC::JSActivation::symbolTablePutWithAttributes):
(JSC::JSActivation::getOwnPropertySlot):
(JSC::JSActivation::put):
(JSC::JSActivation::putDirectVirtual):
(JSC::JSActivation::deleteProperty):
(JSC::JSActivation::argumentsGetter):

  • runtime/JSActivation.h:

(JSActivation):

  • runtime/JSArray.cpp:

(JSC::JSArray::defineOwnProperty):
(JSC::JSArray::getOwnPropertySlot):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::put):
(JSC::JSArray::deleteProperty):

  • runtime/JSArray.h:

(JSArray):
(JSC):

  • runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::create):
(JSC::JSBoundFunction::finishCreation):

  • runtime/JSBoundFunction.h:

(JSBoundFunction):

  • runtime/JSCell.cpp:

(JSC::JSCell::getOwnPropertySlot):
(JSC::JSCell::put):
(JSC::JSCell::deleteProperty):
(JSC::JSCell::putDirectVirtual):
(JSC::JSCell::defineOwnProperty):
(JSC::JSCell::getOwnPropertyDescriptor):

  • runtime/JSCell.h:

(JSCell):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::create):
(JSC::JSFunction::finishCreation):
(JSC::JSFunction::argumentsGetter):
(JSC::JSFunction::callerGetter):
(JSC::JSFunction::lengthGetter):
(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::getOwnPropertyDescriptor):
(JSC::JSFunction::put):
(JSC::JSFunction::deleteProperty):
(JSC::JSFunction::defineOwnProperty):
(JSC::getCalculatedDisplayName):

  • runtime/JSFunction.h:

(JSFunction):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::put):
(JSC::JSGlobalObject::putDirectVirtual):
(JSC::JSGlobalObject::defineOwnProperty):
(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::createThrowTypeError):
(JSC::JSGlobalObject::getOwnPropertySlot):
(JSC::JSGlobalObject::getOwnPropertyDescriptor):

  • runtime/JSGlobalObject.h:

(JSGlobalObject):
(JSC::JSGlobalObject::hasOwnPropertyForWrite):
(JSC::JSGlobalObject::symbolTableHasProperty):

  • runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::getOwnPropertySlot):
(JSC::JSNotAnObject::getOwnPropertyDescriptor):
(JSC::JSNotAnObject::put):
(JSC::JSNotAnObject::deleteProperty):

  • runtime/JSNotAnObject.h:

(JSNotAnObject):

  • runtime/JSONObject.cpp:

(JSC::JSONObject::getOwnPropertySlot):
(JSC::JSONObject::getOwnPropertyDescriptor):

  • runtime/JSONObject.h:

(JSONObject):

  • runtime/JSObject.cpp:

(JSC::JSObject::put):
(JSC::JSObject::putDirectVirtual):
(JSC::JSObject::putDirectAccessor):
(JSC::JSObject::hasProperty):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::hasOwnProperty):
(JSC::callDefaultValueFunction):
(JSC::JSObject::findPropertyHashEntry):
(JSC::JSObject::getPropertySpecificValue):
(JSC::JSObject::removeDirect):
(JSC::JSObject::getOwnPropertyDescriptor):
(JSC::JSObject::getPropertyDescriptor):
(JSC::putDescriptor):
(JSC::JSObject::defineOwnProperty):

  • runtime/JSObject.h:

(JSObject):
(JSC::JSObject::getDirect):
(JSC::JSObject::getDirectLocation):
(JSC::JSObject::inlineGetOwnPropertySlot):
(JSC::JSObject::getOwnPropertySlot):
(JSC::JSCell::fastGetOwnPropertySlot):
(JSC::JSObject::getPropertySlot):
(JSC::JSObject::get):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putOwnDataProperty):
(JSC::JSObject::putDirect):
(JSC::JSObject::putDirectWithoutTransition):
(JSC::JSValue::get):
(JSC::JSValue::put):

  • runtime/JSStaticScopeObject.cpp:

(JSC::JSStaticScopeObject::put):
(JSC::JSStaticScopeObject::putDirectVirtual):
(JSC::JSStaticScopeObject::getOwnPropertySlot):

  • runtime/JSStaticScopeObject.h:

(JSStaticScopeObject):

  • runtime/JSString.cpp:

(JSC::JSString::getOwnPropertySlot):
(JSC::JSString::getStringPropertyDescriptor):

  • runtime/JSString.h:

(JSString):
(JSC::JSString::getStringPropertySlot):

  • runtime/JSValue.cpp:

(JSC::JSValue::putToPrimitive):

  • runtime/JSValue.h:

(JSC):
(JSValue):

  • runtime/JSVariableObject.cpp:

(JSC::JSVariableObject::deleteProperty):
(JSC::JSVariableObject::symbolTableGet):
(JSC::JSVariableObject::putDirectVirtual):

  • runtime/JSVariableObject.h:

(JSVariableObject):
(JSC::JSVariableObject::symbolTableGet):
(JSC::JSVariableObject::symbolTablePut):
(JSC::JSVariableObject::symbolTablePutWithAttributes):

  • runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

  • runtime/Lookup.h:

(JSC::HashTable::entry):
(JSC):
(JSC::getStaticPropertySlot):
(JSC::getStaticPropertyDescriptor):
(JSC::getStaticFunctionSlot):
(JSC::getStaticFunctionDescriptor):
(JSC::getStaticValueSlot):
(JSC::getStaticValueDescriptor):
(JSC::lookupPut):

  • runtime/MathObject.cpp:

(JSC::MathObject::getOwnPropertySlot):
(JSC::MathObject::getOwnPropertyDescriptor):

  • runtime/MathObject.h:

(MathObject):

  • runtime/NativeErrorConstructor.h:

(JSC::NativeErrorConstructor::finishCreation):

  • runtime/NumberConstructor.cpp:

(JSC):
(JSC::NumberConstructor::finishCreation):
(JSC::NumberConstructor::getOwnPropertySlot):
(JSC::NumberConstructor::getOwnPropertyDescriptor):
(JSC::NumberConstructor::put):
(JSC::numberConstructorNaNValue):
(JSC::numberConstructorNegInfinity):
(JSC::numberConstructorPosInfinity):
(JSC::numberConstructorMaxValue):
(JSC::numberConstructorMinValue):

  • runtime/NumberConstructor.h:

(NumberConstructor):

  • runtime/NumberPrototype.cpp:

(JSC::NumberPrototype::getOwnPropertySlot):
(JSC::NumberPrototype::getOwnPropertyDescriptor):

  • runtime/NumberPrototype.h:

(NumberPrototype):

  • runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::finishCreation):
(JSC::ObjectConstructor::getOwnPropertySlot):
(JSC::ObjectConstructor::getOwnPropertyDescriptor):

  • runtime/ObjectConstructor.h:

(ObjectConstructor):

  • runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::put):
(JSC::ObjectPrototype::defineOwnProperty):
(JSC::ObjectPrototype::getOwnPropertySlot):
(JSC::ObjectPrototype::getOwnPropertyDescriptor):

  • runtime/ObjectPrototype.h:

(ObjectPrototype):

  • runtime/PropertySlot.h:

(PropertySlot):
(JSC::PropertySlot::getValue):

  • runtime/RegExpConstructor.cpp:

(JSC):
(JSC::RegExpConstructor::finishCreation):
(JSC::RegExpConstructor::getOwnPropertySlot):
(JSC::RegExpConstructor::getOwnPropertyDescriptor):
(JSC::regExpConstructorDollar1):
(JSC::regExpConstructorDollar2):
(JSC::regExpConstructorDollar3):
(JSC::regExpConstructorDollar4):
(JSC::regExpConstructorDollar5):
(JSC::regExpConstructorDollar6):
(JSC::regExpConstructorDollar7):
(JSC::regExpConstructorDollar8):
(JSC::regExpConstructorDollar9):
(JSC::regExpConstructorInput):
(JSC::regExpConstructorMultiline):
(JSC::regExpConstructorLastMatch):
(JSC::regExpConstructorLastParen):
(JSC::regExpConstructorLeftContext):
(JSC::regExpConstructorRightContext):
(JSC::RegExpConstructor::put):

  • runtime/RegExpConstructor.h:

(RegExpConstructor):

  • runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::getOwnPropertySlot):
(JSC::RegExpMatchesArray::getOwnPropertyDescriptor):
(JSC::RegExpMatchesArray::put):
(JSC::RegExpMatchesArray::deleteProperty):
(JSC::RegExpMatchesArray::defineOwnProperty):

  • runtime/RegExpObject.cpp:

(JSC):
(JSC::RegExpObject::getOwnPropertySlot):
(JSC::RegExpObject::getOwnPropertyDescriptor):
(JSC::RegExpObject::deleteProperty):
(JSC::RegExpObject::defineOwnProperty):
(JSC::regExpObjectGlobal):
(JSC::regExpObjectIgnoreCase):
(JSC::regExpObjectMultiline):
(JSC::regExpObjectSource):
(JSC::RegExpObject::put):

  • runtime/RegExpObject.h:

(RegExpObject):

  • runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::getOwnPropertySlot):
(JSC::RegExpPrototype::getOwnPropertyDescriptor):

  • runtime/RegExpPrototype.h:

(RegExpPrototype):

  • runtime/StrictEvalActivation.cpp:

(JSC::StrictEvalActivation::deleteProperty):

  • runtime/StrictEvalActivation.h:

(StrictEvalActivation):

  • runtime/StringConstructor.cpp:

(JSC::StringConstructor::finishCreation):
(JSC::StringConstructor::getOwnPropertySlot):
(JSC::StringConstructor::getOwnPropertyDescriptor):

  • runtime/StringConstructor.h:

(StringConstructor):

  • runtime/StringObject.cpp:

(JSC::StringObject::getOwnPropertySlot):
(JSC::StringObject::getOwnPropertyDescriptor):
(JSC::StringObject::put):
(JSC::StringObject::defineOwnProperty):
(JSC::StringObject::deleteProperty):

  • runtime/StringObject.h:

(StringObject):

  • runtime/StringPrototype.cpp:

(JSC::StringPrototype::getOwnPropertySlot):
(JSC::StringPrototype::getOwnPropertyDescriptor):

  • runtime/StringPrototype.h:

(StringPrototype):

  • runtime/Structure.cpp:

(JSC::Structure::despecifyDictionaryFunction):
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::removePropertyTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::removePropertyWithoutTransition):
(JSC::Structure::get):
(JSC::Structure::despecifyFunction):
(JSC::Structure::putSpecificValue):
(JSC::Structure::remove):

  • runtime/Structure.h:

(Structure):
(JSC::Structure::get):

Source/WebCore:

  • WebCore.exp.in:
  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::cssPropertyIDForJSCSSPropertyName):
(WebCore::JSCSSStyleDeclaration::getOwnPropertySlotDelegate):
(WebCore::JSCSSStyleDeclaration::getOwnPropertyDescriptorDelegate):
(WebCore::JSCSSStyleDeclaration::putDelegate):

  • bindings/js/JSDOMBinding.cpp:

(WebCore::findAtomicString):
(WebCore::objectToStringFunctionGetter):

  • bindings/js/JSDOMBinding.h:

(WebCore):
(WebCore::propertyNameToString):
(WebCore::propertyNameToAtomicString):

  • bindings/js/JSDOMMimeTypeArrayCustom.cpp:

(WebCore::JSDOMMimeTypeArray::canGetItemsForName):
(WebCore::JSDOMMimeTypeArray::nameGetter):

  • bindings/js/JSDOMPluginArrayCustom.cpp:

(WebCore::JSDOMPluginArray::canGetItemsForName):
(WebCore::JSDOMPluginArray::nameGetter):

  • bindings/js/JSDOMPluginCustom.cpp:

(WebCore::JSDOMPlugin::canGetItemsForName):
(WebCore::JSDOMPlugin::nameGetter):

  • bindings/js/JSDOMStringMapCustom.cpp:

(WebCore::JSDOMStringMap::canGetItemsForName):
(WebCore::JSDOMStringMap::nameGetter):
(WebCore::JSDOMStringMap::deleteProperty):
(WebCore::JSDOMStringMap::putDelegate):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::nonCachingStaticFunctionGetter):
(WebCore::childFrameGetter):
(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertyDescriptor):
(WebCore::JSDOMWindow::put):
(WebCore::JSDOMWindow::deleteProperty):
(WebCore::JSDOMWindow::defineOwnProperty):

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::getOwnPropertySlot):
(WebCore::JSDOMWindowShell::getOwnPropertyDescriptor):
(WebCore::JSDOMWindowShell::put):
(WebCore::JSDOMWindowShell::putDirectVirtual):
(WebCore::JSDOMWindowShell::defineOwnProperty):
(WebCore::JSDOMWindowShell::deleteProperty):

  • bindings/js/JSDOMWindowShell.h:

(JSDOMWindowShell):

  • bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::getNamedItems):
(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::canGetItemsForName):
(WebCore::JSHTMLAllCollection::nameGetter):
(WebCore::JSHTMLAllCollection::item):

  • bindings/js/JSHTMLAppletElementCustom.cpp:

(WebCore::JSHTMLAppletElement::getOwnPropertySlotDelegate):
(WebCore::JSHTMLAppletElement::getOwnPropertyDescriptorDelegate):
(WebCore::JSHTMLAppletElement::putDelegate):

  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::getNamedItems):
(WebCore::JSHTMLCollection::canGetItemsForName):
(WebCore::JSHTMLCollection::nameGetter):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::canGetItemsForName):
(WebCore::JSHTMLDocument::nameGetter):

  • bindings/js/JSHTMLEmbedElementCustom.cpp:

(WebCore::JSHTMLEmbedElement::getOwnPropertySlotDelegate):
(WebCore::JSHTMLEmbedElement::getOwnPropertyDescriptorDelegate):
(WebCore::JSHTMLEmbedElement::putDelegate):

  • bindings/js/JSHTMLFormElementCustom.cpp:

(WebCore::JSHTMLFormElement::canGetItemsForName):
(WebCore::JSHTMLFormElement::nameGetter):

  • bindings/js/JSHTMLFrameSetElementCustom.cpp:

(WebCore::JSHTMLFrameSetElement::canGetItemsForName):
(WebCore::JSHTMLFrameSetElement::nameGetter):

  • bindings/js/JSHTMLObjectElementCustom.cpp:

(WebCore::JSHTMLObjectElement::getOwnPropertySlotDelegate):
(WebCore::JSHTMLObjectElement::getOwnPropertyDescriptorDelegate):
(WebCore::JSHTMLObjectElement::putDelegate):

  • bindings/js/JSHistoryCustom.cpp:

(WebCore::nonCachingStaticBackFunctionGetter):
(WebCore::nonCachingStaticForwardFunctionGetter):
(WebCore::nonCachingStaticGoFunctionGetter):
(WebCore::JSHistory::getOwnPropertySlotDelegate):
(WebCore::JSHistory::getOwnPropertyDescriptorDelegate):
(WebCore::JSHistory::putDelegate):
(WebCore::JSHistory::deleteProperty):

  • bindings/js/JSLocationCustom.cpp:

(WebCore::nonCachingStaticReplaceFunctionGetter):
(WebCore::nonCachingStaticReloadFunctionGetter):
(WebCore::nonCachingStaticAssignFunctionGetter):
(WebCore::JSLocation::getOwnPropertySlotDelegate):
(WebCore::JSLocation::getOwnPropertyDescriptorDelegate):
(WebCore::JSLocation::putDelegate):
(WebCore::JSLocation::deleteProperty):
(WebCore::JSLocation::defineOwnProperty):
(WebCore::JSLocationPrototype::putDelegate):
(WebCore::JSLocationPrototype::defineOwnProperty):

  • bindings/js/JSNamedNodeMapCustom.cpp:

(WebCore::JSNamedNodeMap::canGetItemsForName):
(WebCore::JSNamedNodeMap::nameGetter):

  • bindings/js/JSNodeListCustom.cpp:

(WebCore::JSNodeList::canGetItemsForName):
(WebCore::JSNodeList::nameGetter):

  • bindings/js/JSPluginElementFunctions.cpp:

(WebCore::runtimeObjectPropertyGetter):
(WebCore::runtimeObjectCustomGetOwnPropertySlot):
(WebCore::runtimeObjectCustomGetOwnPropertyDescriptor):
(WebCore::runtimeObjectCustomPut):

  • bindings/js/JSPluginElementFunctions.h:

(WebCore):

  • bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::canGetItemsForName):
(WebCore::JSStorage::nameGetter):
(WebCore::JSStorage::deleteProperty):
(WebCore::JSStorage::putDelegate):

  • bindings/js/JSStyleSheetListCustom.cpp:

(WebCore::JSStyleSheetList::canGetItemsForName):
(WebCore::JSStyleSheetList::nameGetter):

  • bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::getOwnPropertySlotDelegate):
(WebCore::JSWorkerContext::getOwnPropertyDescriptorDelegate):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorDeclaration):
(GenerateConstructorDefinition):

  • bridge/c/c_class.cpp:

(JSC::Bindings::CClass::methodsNamed):
(JSC::Bindings::CClass::fieldNamed):

  • bridge/c/c_class.h:

(CClass):

  • bridge/c/c_instance.cpp:

(JSC::Bindings::CRuntimeMethod::create):
(JSC::Bindings::CRuntimeMethod::finishCreation):
(JSC::Bindings::CInstance::getMethod):

  • bridge/c/c_instance.h:

(CInstance):

  • bridge/jni/jsc/JavaClassJSC.cpp:

(JavaClass::methodsNamed):
(JavaClass::fieldNamed):

  • bridge/jni/jsc/JavaClassJSC.h:

(JavaClass):

  • bridge/jni/jsc/JavaInstanceJSC.cpp:

(JavaRuntimeMethod::create):
(JavaRuntimeMethod::finishCreation):

  • bridge/jni/jsc/JavaInstanceJSC.h:

(JavaInstance):

  • bridge/jsc/BridgeJSC.h:

(Class):
(JSC::Bindings::Class::fallbackObject):
(JSC::Bindings::Instance::setValueOfUndefinedField):
(Instance):
(JSC::Bindings::Instance::getOwnPropertySlot):
(JSC::Bindings::Instance::getOwnPropertyDescriptor):
(JSC::Bindings::Instance::put):

  • bridge/objc/objc_class.h:

(ObjcClass):

  • bridge/objc/objc_class.mm:

(JSC::Bindings::ObjcClass::methodsNamed):
(JSC::Bindings::ObjcClass::fieldNamed):
(JSC::Bindings::ObjcClass::fallbackObject):

  • bridge/objc/objc_instance.h:

(ObjcInstance):

  • bridge/objc/objc_instance.mm:

(ObjCRuntimeMethod::create):
(ObjCRuntimeMethod::finishCreation):
(ObjcInstance::setValueOfUndefinedField):
(ObjcInstance::getValueOfUndefinedField):

  • bridge/objc/objc_runtime.h:

(JSC::Bindings::ObjcFallbackObjectImp::create):
(JSC::Bindings::ObjcFallbackObjectImp::propertyName):
(ObjcFallbackObjectImp):

  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):
(JSC::Bindings::ObjcFallbackObjectImp::getOwnPropertySlot):
(JSC::Bindings::ObjcFallbackObjectImp::getOwnPropertyDescriptor):
(JSC::Bindings::ObjcFallbackObjectImp::put):
(JSC::Bindings::callObjCFallbackObject):
(JSC::Bindings::ObjcFallbackObjectImp::deleteProperty):
(JSC::Bindings::ObjcFallbackObjectImp::defaultValue):

  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::lengthGetter):
(JSC::RuntimeArray::getOwnPropertySlot):
(JSC::RuntimeArray::getOwnPropertyDescriptor):
(JSC::RuntimeArray::put):
(JSC::RuntimeArray::deleteProperty):

  • bridge/runtime_array.h:

(RuntimeArray):

  • bridge/runtime_method.cpp:

(JSC::RuntimeMethod::finishCreation):
(JSC::RuntimeMethod::lengthGetter):
(JSC::RuntimeMethod::getOwnPropertySlot):
(JSC::RuntimeMethod::getOwnPropertyDescriptor):

  • bridge/runtime_method.h:

(JSC::RuntimeMethod::create):
(RuntimeMethod):

  • bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::fallbackObjectGetter):
(JSC::Bindings::RuntimeObject::fieldGetter):
(JSC::Bindings::RuntimeObject::methodGetter):
(JSC::Bindings::RuntimeObject::getOwnPropertySlot):
(JSC::Bindings::RuntimeObject::getOwnPropertyDescriptor):
(JSC::Bindings::RuntimeObject::put):
(JSC::Bindings::RuntimeObject::deleteProperty):

  • bridge/runtime_object.h:

(RuntimeObject):

Source/WebKit/mac:

  • Plugins/Hosted/ProxyInstance.h:

(ProxyInstance):

  • Plugins/Hosted/ProxyInstance.mm:

(ProxyClass):
(WebKit::ProxyClass::methodsNamed):
(WebKit::ProxyClass::fieldNamed):
(WebKit::ProxyRuntimeMethod::create):
(WebKit::ProxyRuntimeMethod::finishCreation):
(WebKit::ProxyInstance::getMethod):
(WebKit::ProxyInstance::methodsNamed):
(WebKit::ProxyInstance::fieldNamed):

Source/WebKit2:

  • WebProcess/Plugins/Netscape/JSNPMethod.cpp:

(WebKit::JSNPMethod::finishCreation):

  • WebProcess/Plugins/Netscape/JSNPMethod.h:

(WebKit::JSNPMethod::create):
(JSNPMethod):

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::npIdentifierFromIdentifier):
(WebKit::JSNPObject::getOwnPropertySlot):
(WebKit::JSNPObject::getOwnPropertyDescriptor):
(WebKit::JSNPObject::put):
(WebKit::JSNPObject::deleteProperty):
(WebKit::JSNPObject::propertyGetter):
(WebKit::JSNPObject::methodGetter):

  • WebProcess/Plugins/Netscape/JSNPObject.h:

(JSNPObject):

5:28 PM Changeset in webkit [116827] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk

use after free in WebCore::RenderObject::document
https://bugs.webkit.org/show_bug.cgi?id=84891

Patch by David Barton <Dave Barton> on 2012-05-11
Reviewed by Julien Chaffraix.

Source/WebCore:

Change RenderMathMLFenced::addChild() to use the beforeChild parameter. When beforeChild
is 0, insert child renderers before the closing fence, which might not be the same as
this->lastChild(), e.g. possibly due to anonymous blocks or generated content.

Tests: mathml/presentation/mfenced-add-child1-expected.html

mathml/presentation/mfenced-add-child1.html
mathml/presentation/mfenced-add-child2-expected.html
mathml/presentation/mfenced-add-child2.html

  • rendering/mathml/RenderMathMLFenced.cpp:

(WebCore::RenderMathMLFenced::RenderMathMLFenced):
(WebCore::RenderMathMLFenced::makeFences):
(WebCore::RenderMathMLFenced::addChild):

  • rendering/mathml/RenderMathMLFenced.h:

(RenderMathMLFenced):

LayoutTests:

  • mathml/presentation/mfenced-add-child1-expected.html: Added.
  • mathml/presentation/mfenced-add-child1.html: Added.
  • mathml/presentation/mfenced-add-child2-expected.html: Added.
  • mathml/presentation/mfenced-add-child2.html: Added.
5:17 PM Changeset in webkit [116826] by Lucas Forschler
  • 4 edits in branches/safari-536-branch/Source

Versioning.

5:14 PM Changeset in webkit [116825] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Do a DEPS roll per build failure caused by r116810.

See http://webkitmemes.tumblr.com/post/21734202168/the-solution-to-any-chromium-problem for the rationale.

  • DEPS:
5:09 PM Changeset in webkit [116824] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Can't scroll on webpage after following links from Blogger
https://bugs.webkit.org/show_bug.cgi?id=86274
<rdar://problem/11431352>

Reviewed by Beth Dakin.

When committing a new scroll layer, make sure to reset the scroll position.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::commitNewTreeState):

4:57 PM Changeset in webkit [116823] by commit-queue@webkit.org
  • 13 edits in trunk/Source/WebCore

[TextureMapper] Support drawing debug borders
https://bugs.webkit.org/show_bug.cgi?id=86237

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-05-11
Reviewed by Noam Rosenthal.

No new tests. This is the implementation of an interactive debugging
feature.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayer::create): Moved this to the top of the file to
reduce contention for the coveted last spot in the file. This also
follows the pattern used in many WebCore files of having the factories
at the top.
(WebCore::GraphicsLayerTextureMapper::setDebugBorder): Added this
plumbing.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h: Added

plumbing.

  • platform/graphics/texmap/TextureMapper.h: Ditto.
  • platform/graphics/texmap/TextureMapperBackingStore.cpp:

(WebCore::TextureMapperTiledBackingStore::TextureMapperTiledBackingStore):
Initialize the new member.
(WebCore::TextureMapperTiledBackingStore::paintToTextureMapper): When
debug borders are enabled call the new drawBorder method on the TM.
(WebCore::TextureMapperTiledBackingStore::setDebugBorder): Added this
plumbing.

  • platform/graphics/texmap/TextureMapperBackingStore.h: Added plumbing

and members to store debug border states. This is necessary because of
the when painting there is no handle on the GraphicsLayers.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::drawRect): Factored out the common bits of
drawTexture and drawBorder into this helper.
(WebCore::TextureMapperGL::drawBorder): Added this method, which works
very similarly to drawTexture, but uses a different shader program and
must also set the line width and color.
(WebCore::TextureMapperGL::drawTexture): Factored out the bits that
are shared with drawRect.

  • platform/graphics/texmap/TextureMapperGL.h:

(TextureMapperGL): Added the new method declarations.

  • platform/graphics/texmap/TextureMapperImageBuffer.h:

(WebCore::TextureMapperImageBuffer::drawBorder): Added an empty
implementation. Later we can add an implementation for the ImageBuffer
TM.

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::updateBackingStore): When updating the
backing store send the debug border information through.
(WebCore::TextureMapperLayer::syncCompositingStateSelf): When updating
the layer state, also update the debug indicators. This is required to
initialize the debug border values for the layer.
(WebCore::TextureMapperLayer::setDebugBorder): Added this plumbing.

  • platform/graphics/texmap/TextureMapperLayer.h: Ditto.
  • platform/graphics/texmap/TextureMapperShaderManager.cpp: Added a

solid color shader that doesn't care about texture coordinates or
opacity values.
(WebCore::TextureMapperShaderManager::solidColorProgram): Added. This
is a shorter getter for the solid color program that doesn't require
casting from the caller.
(WebCore::TextureMapperShaderManager::getShaderProgram): Added support
for the solid color program.
(WebCore::TextureMapperShaderProgramSolidColor::create): Added.
(WebCore::TextureMapperShaderProgramSolidColor::TextureMapperShaderProgramSolidColor):
Ditto.
(WebCore::TextureMapperShaderProgramSolidColor::vertexShaderSource):
Ditto.
(WebCore::TextureMapperShaderProgramSolidColor::fragmentShaderSource):
Ditto.

  • platform/graphics/texmap/TextureMapperShaderManager.h:

(TextureMapperShaderProgramSolidColor): Added.
(WebCore::TextureMapperShaderProgramSolidColor::colorVariable): Added.

4:50 PM Changeset in webkit [116822] by msaboff@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Rolling out r116659.

Causes ASSERT failures on bots.

Rubber stamped by Geoff Garen.

  • heap/Heap.cpp:

(JSC::Heap::markRoots):

  • heap/MarkStack.cpp:

(JSC::MarkStackThreadSharedData::markingThreadMain):
(JSC::MarkStackThreadSharedData::markingThreadStartFunc):
(JSC::MarkStackThreadSharedData::MarkStackThreadSharedData):
(JSC::MarkStackThreadSharedData::reset):
(JSC::MarkStack::reset):
(JSC):
(JSC::SlotVisitor::copyAndAppend):

  • heap/MarkStack.h:

(MarkStackThreadSharedData):
(MarkStack):

  • runtime/JSString.h:

(JSString):
(JSC::JSString::finishCreation):
(JSC::JSString::is8Bit):
(JSC::JSRopeString::finishCreation):

4:40 PM Changeset in webkit [116821] by timothy@apple.com
  • 7 edits
    3 adds in trunk

Instrument timer function calls so they show up in the Web Inspector Timeline.

https://webkit.org/b/86173

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/timeline/timeline-timer.html

  • bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::executeFunctionInContext): Wrap the call with JSMainThreadExecState::instrumentFunctionCall
and InspectorInstrumentation::didCallFunction.

LayoutTests:

  • inspector/timeline/timeline-injected-script-eval-expected.txt: Updated for the blocked scriptName and scriptLine.
  • inspector/timeline/timeline-script-tag-1-expected.txt: Updated for the blocked lineNumber.
  • inspector/timeline/timeline-script-tag-2-expected.txt: Ditto.
  • inspector/timeline/timeline-test.js: Block scriptName, scriptLine, lineNumber and timerId.
  • inspector/timeline/timeline-timer-expected.txt: Added.
  • inspector/timeline/timeline-timer.html: Added.
  • platform/chromium/inspector/timeline/timeline-timer-expected.txt: Added.
4:20 PM Changeset in webkit [116820] by beidson@apple.com
  • 4 edits in trunk/Source/WebKit/mac

<rdar://problem/11361907> and https://bugs.webkit.org/show_bug.cgi?id=86265
REGRESSION(r104885): Images missing from printed YummySoup! recipes

We thought clients were passing paths as URLs.
It turns out it was more likely they were passing file: URLs with the file: scheme removed.
And that jives perfectly with the behavior change caused by r104885.

Reviewed by Alexey Proskuryakov.

Rename _webkit_URLFromURLOrPath to _webkit_URLFromURLOrSchemelessFileURL, and change it
to create the new URL simply by appending "file:":

  • Misc/WebNSURLExtras.h:
  • Misc/WebNSURLExtras.mm:

(-[NSURL _webkit_URLFromURLOrSchemelessFileURL]):

  • WebView/WebFrame.mm:

(-[WebFrame loadRequest:]): Create the fixed url simply by appending "file:" to the

existing URL string.

(-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]):
(-[WebFrame loadHTMLString:baseURL:]):
(-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]):

4:08 PM Changeset in webkit [116819] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] [WK2] Memory leak in PluginProcessProxy::scanPlugin
https://bugs.webkit.org/show_bug.cgi?id=86240

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-11
Reviewed by Martin Robinson.

Free the output received from the g_spawn_sync().

  • UIProcess/Plugins/gtk/PluginProcessProxyGtk.cpp:

(WebKit::PluginProcessProxy::scanPlugin):

4:07 PM Changeset in webkit [116818] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Appease thread verifier when dealing with the JSC API's shared VM
https://bugs.webkit.org/show_bug.cgi?id=86268

Reviewed by Geoffrey Garen.

If we're the shared VM, just disable the verifier. This makes debug builds
livable against non-webkit clients.

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

4:03 PM Changeset in webkit [116817] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium/mac] Let libwebkit.dylib link in Debug/components build
https://bugs.webkit.org/show_bug.cgi?id=86244

Reviewed by James Robinson.

In static builds, this was not needed because the targets depending on
'webkit' already link in QuartzCore. In Release components builds, it wasn't
needed because they are built with -dead_strip, which stripped the referencing
code.

  • WebCore.gyp/WebCore.gyp:
3:58 PM Changeset in webkit [116816] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Remove a Chromium test expectation now that the regression is fixed in r116814.

  • platform/chromium/test_expectations.txt:
3:55 PM Changeset in webkit [116815] by commit-queue@webkit.org
  • 7 edits in trunk

Unreviewed, rolling out r116802.
http://trac.webkit.org/changeset/116802
https://bugs.webkit.org/show_bug.cgi?id=86260

This patch causes compiling error to chromium builds
(Requested by jianli_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-11

Source/WebCore:

  • WebCore.gypi:

Source/WebKit/chromium:

  • features.gypi:
  • src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

LayoutTests:

  • platform/chromium/test_expectations.txt:
3:38 PM Changeset in webkit [116814] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Regression fix after r116798.

We need to return true for the html element in the design mode
in which case parentNode() is editable and is not a body element.

  • dom/Node.cpp:

(WebCore::Node::isRootEditableElement):

3:37 PM Changeset in webkit [116813] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JIT memory allocator is not returning memory to the OS on Darwin
https://bugs.webkit.org/show_bug.cgi?id=86047

Reviewed by Geoff Garen.

  • jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::FixedVMPoolExecutableAllocator::notifyPageIsFree):

3:30 PM Changeset in webkit [116812] by pilgrim@chromium.org
  • 10 edits
    2 copies in trunk/Source

[Chromium] Move createLocalStorageNamespace to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=85766

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

  • Platform.gypi:
  • chromium/public/Platform.h:

(WebKit):
(Platform):
(WebKit::Platform::createLocalStorageNamespace):

  • chromium/public/WebStorageArea.h: Added.

(WebKit):
(WebStorageArea):
(WebKit::WebStorageArea::~WebStorageArea):
(WebKit::WebStorageArea::setItem):
(WebKit::WebStorageArea::removeItem):
(WebKit::WebStorageArea::clear):

  • chromium/public/WebStorageNamespace.h: Added.

(WebKit):
(WebStorageNamespace):
(WebKit::WebStorageNamespace::~WebStorageNamespace):
(WebKit::WebStorageNamespace::isSameNamespace):

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebStorageArea.h:
  • public/WebStorageNamespace.h:
  • public/platform/WebKitPlatformSupport.h:

(WebKit):
(WebKit::WebKitPlatformSupport::blobRegistry):

  • src/StorageAreaProxy.cpp:
  • src/StorageNamespaceProxy.cpp:

(WebCore::StorageNamespace::localStorageNamespace):

3:19 PM Changeset in webkit [116811] by jamesr@google.com
  • 4 edits
    3 moves in trunk/Source

[chromium] Move implementation of WebCore::GraphicsContext3D and related from WebKit/chromium/src to WebCore/platform/chromium/support
https://bugs.webkit.org/show_bug.cgi?id=86257

Reviewed by Adam Barth.

Source/WebCore:

The WebCore platform interfaces GraphicsContext3D and Extensions3DChromium are implemented in chromium on top of
the Platform interface WebGraphicsContext3D. This moves the implementation support code from WebKit/chromium/src
to WebCore/platform/chromium/support, which avoids having code in WebKit/ implementing WebCore interfaces and
allows code in WebCore/platform to use this support code directly where appropriate.

Refactor only, no new functionality or tests.

  • WebCore.gypi:
  • platform/chromium/support/Extensions3DChromium.cpp: Renamed from Source/WebKit/chromium/src/Extensions3DChromium.cpp.

(WebCore):
(WebCore::Extensions3DChromium::Extensions3DChromium):
(WebCore::Extensions3DChromium::~Extensions3DChromium):
(WebCore::Extensions3DChromium::supports):
(WebCore::Extensions3DChromium::ensureEnabled):
(WebCore::Extensions3DChromium::isEnabled):
(WebCore::Extensions3DChromium::getGraphicsResetStatusARB):
(WebCore::Extensions3DChromium::blitFramebuffer):
(WebCore::Extensions3DChromium::renderbufferStorageMultisample):
(WebCore::Extensions3DChromium::postSubBufferCHROMIUM):
(WebCore::Extensions3DChromium::mapBufferSubDataCHROMIUM):
(WebCore::Extensions3DChromium::unmapBufferSubDataCHROMIUM):
(WebCore::Extensions3DChromium::mapTexSubImage2DCHROMIUM):
(WebCore::Extensions3DChromium::unmapTexSubImage2DCHROMIUM):
(WebCore::Extensions3DChromium::setVisibilityCHROMIUM):
(WebCore::Extensions3DChromium::discardFramebufferEXT):
(WebCore::Extensions3DChromium::ensureFramebufferCHROMIUM):
(WebCore::Extensions3DChromium::setGpuMemoryAllocationChangedCallbackCHROMIUM):
(WebCore::Extensions3DChromium::createVertexArrayOES):
(WebCore::Extensions3DChromium::deleteVertexArrayOES):
(WebCore::Extensions3DChromium::isVertexArrayOES):
(WebCore::Extensions3DChromium::bindVertexArrayOES):
(WebCore::Extensions3DChromium::getTranslatedShaderSourceANGLE):
(WebCore::Extensions3DChromium::setSwapBuffersCompleteCallbackCHROMIUM):
(WebCore::Extensions3DChromium::rateLimitOffscreenContextCHROMIUM):
(WebCore::Extensions3DChromium::paintFramebufferToCanvas):
(WebCore::Extensions3DChromium::texImageIOSurface2DCHROMIUM):
(WebCore::Extensions3DChromium::texStorage2DEXT):
(WebCore::Extensions3DChromium::createQueryEXT):
(WebCore::Extensions3DChromium::deleteQueryEXT):
(WebCore::Extensions3DChromium::isQueryEXT):
(WebCore::Extensions3DChromium::beginQueryEXT):
(WebCore::Extensions3DChromium::endQueryEXT):
(WebCore::Extensions3DChromium::getQueryivEXT):
(WebCore::Extensions3DChromium::getQueryObjectuivEXT):

  • platform/chromium/support/GraphicsContext3DChromium.cpp: Renamed from Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp.

(WebCore):
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):
(WebCore::GraphicsContext3DPrivate::extractWebGraphicsContext3D):
(WebCore::GraphicsContext3DPrivate::platformGraphicsContext3D):
(WebCore::GraphicsContext3DPrivate::platformTexture):
(GrMemoryAllocationChangedCallback):
(WebCore::GrMemoryAllocationChangedCallback::GrMemoryAllocationChangedCallback):
(WebCore::GrMemoryAllocationChangedCallback::onGpuMemoryAllocationChanged):
(WebCore::GraphicsContext3DPrivate::grContext):
(WebCore::GraphicsContext3DPrivate::prepareTexture):
(WebCore::GraphicsContext3DPrivate::markContextChanged):
(WebCore::GraphicsContext3DPrivate::markLayerComposited):
(WebCore::GraphicsContext3DPrivate::layerComposited):
(WebCore::GraphicsContext3DPrivate::paintFramebufferToCanvas):
(WebCore::GraphicsContext3DPrivate::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3DPrivate::paintCompositedResultsToCanvas):
(WebCore::GraphicsContext3DPrivate::paintRenderingResultsToImageData):
(WebCore::GraphicsContext3DPrivate::reshape):
(WebCore::GraphicsContext3DPrivate::getInternalFramebufferSize):
(WebCore::GraphicsContext3DPrivate::isContextLost):
(WebCore::GraphicsContext3DPrivate::isGLES2Compliant):
(WebCore::GraphicsContext3DPrivate::bindAttribLocation):
(WebCore::GraphicsContext3DPrivate::bufferData):
(WebCore::GraphicsContext3DPrivate::bufferSubData):
(WebCore::GraphicsContext3DPrivate::getActiveAttrib):
(WebCore::GraphicsContext3DPrivate::getActiveUniform):
(WebCore::GraphicsContext3DPrivate::getAttribLocation):
(WebCore::GraphicsContext3DPrivate::getContextAttributes):
(WebCore::GraphicsContext3DPrivate::getProgramInfoLog):
(WebCore::GraphicsContext3DPrivate::getShaderInfoLog):
(WebCore::GraphicsContext3DPrivate::getShaderSource):
(WebCore::GraphicsContext3DPrivate::getString):
(WebCore::GraphicsContext3DPrivate::getUniformLocation):
(WebCore::GraphicsContext3DPrivate::shaderSource):
(WebCore::GraphicsContext3DPrivate::texImage2D):
(WebCore::GraphicsContext3DPrivate::texSubImage2D):
(WebCore::GraphicsContext3DPrivate::uniform1fv):
(WebCore::GraphicsContext3DPrivate::uniform1iv):
(WebCore::GraphicsContext3DPrivate::uniform2fv):
(WebCore::GraphicsContext3DPrivate::uniform2iv):
(WebCore::GraphicsContext3DPrivate::uniform3fv):
(WebCore::GraphicsContext3DPrivate::uniform3iv):
(WebCore::GraphicsContext3DPrivate::uniform4fv):
(WebCore::GraphicsContext3DPrivate::uniform4iv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix2fv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix3fv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix4fv):
(WebCore::GraphicsContext3DPrivate::getExtensions):
(WebCore::GraphicsContext3DPrivate::isResourceSafe):
(WebCore::GraphicsContext3DPrivate::initializeExtensions):
(WebCore::GraphicsContext3DPrivate::supportsExtension):
(WebCore::GraphicsContext3DPrivate::ensureExtensionEnabled):
(WebCore::GraphicsContext3DPrivate::isExtensionEnabled):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
(WebCore::GraphicsContext3D::platformTexture):
(WebCore::GraphicsContext3D::grContext):
(WebCore::GraphicsContext3D::prepareTexture):
(WebCore::GraphicsContext3D::getInternalFramebufferSize):
(WebCore::GraphicsContext3D::isResourceSafe):
(WebCore::GraphicsContext3D::platformLayer):
(WebCore::GraphicsContext3D::layerComposited):
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
(GraphicsContextLostCallbackAdapter):
(WebCore::GraphicsContextLostCallbackAdapter::~GraphicsContextLostCallbackAdapter):
(WebCore::GraphicsContextLostCallbackAdapter::GraphicsContextLostCallbackAdapter):
(WebCore::GraphicsContextLostCallbackAdapter::onContextLost):
(WebCore::GraphicsContextLostCallbackAdapter::create):
(WebCore::GraphicsContext3DPrivate::setContextLostCallback):
(GraphicsErrorMessageCallbackAdapter):
(WebCore::GraphicsErrorMessageCallbackAdapter::~GraphicsErrorMessageCallbackAdapter):
(WebCore::GraphicsErrorMessageCallbackAdapter::GraphicsErrorMessageCallbackAdapter):
(WebCore::GraphicsErrorMessageCallbackAdapter::onErrorMessage):
(WebCore::GraphicsErrorMessageCallbackAdapter::create):
(WebCore::GraphicsContext3DPrivate::setErrorMessageCallback):
(WebCore::GraphicsContext3D::isGLES2Compliant):
(GraphicsContext3DSwapBuffersCompleteCallbackAdapter):
(WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::~GraphicsContext3DSwapBuffersCompleteCallbackAdapter):
(WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::GraphicsContext3DSwapBuffersCompleteCallbackAdapter):
(WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::onSwapBuffersComplete):
(WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::create):
(WebCore::GraphicsContext3DPrivate::setSwapBuffersCompleteCallbackCHROMIUM):
(GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::~GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::onMemoryAllocationChanged):
(WebCore::GraphicsContext3DPrivate::setGpuMemoryAllocationChangedCallbackCHROMIUM):

  • platform/chromium/support/GraphicsContext3DPrivate.h: Renamed from Source/WebKit/chromium/src/GraphicsContext3DPrivate.h.

(WebKit):
(WebCore):
(GraphicsContext3DPrivate):

Source/WebKit/chromium:

  • WebKit.gyp:
3:18 PM Changeset in webkit [116810] by fsamuel@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Expose WebPluginContainer of WebPlugin to embedder
https://bugs.webkit.org/show_bug.cgi?id=85916

Reviewed by Darin Fisher.

The browser plugin needs to access its current guest's WebPluginContainer
so that it can replace the guest with another guest WebPlugin when navigating
across processes.

  • public/WebPlugin.h:

(WebPlugin):
(WebKit::WebPlugin::container):

3:17 PM Changeset in webkit [116809] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Clarified JSGlobalData (JavaScript VM) lifetime
https://bugs.webkit.org/show_bug.cgi?id=85142

Reviewed by Alexey Proskuryakov.

(Follow-up fix.)

  • API/JSContextRef.cpp:

(JSGlobalContextCreate): Restored some code I removed because I misread an #ifdef.
(We don't need to test BUILDING_ON_LEOPARD, but we still need the linked-on
test, because apps might have been linked on older OS's.)

2:53 PM Changeset in webkit [116808] by tomz@codeaurora.org
  • 6 edits
    35 adds in trunk/LayoutTests

Integrate IETC CSS : xml namespace tests
https://bugs.webkit.org/show_bug.cgi?id=86144

Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-05-11
Reviewed by Adam Barth.

Integrating 17 IETC xml namespace tests, along with associated
reference tests.

  • ietestcenter/css3/namespaces/declaring-001-expected.xml: Added.
  • ietestcenter/css3/namespaces/declaring-001.xml: Added.
  • ietestcenter/css3/namespaces/prefix-007-expected.xml: Added.
  • ietestcenter/css3/namespaces/prefix-007.xml: Added.
  • ietestcenter/css3/namespaces/prefix-008-expected.xml: Added.
  • ietestcenter/css3/namespaces/prefix-008.xml: Added.
  • ietestcenter/css3/namespaces/prefix-009-expected.xml: Added.
  • ietestcenter/css3/namespaces/prefix-009.xml: Added.
  • ietestcenter/css3/namespaces/prefix-010-expected.xml: Added.
  • ietestcenter/css3/namespaces/prefix-010.xml: Added.
  • ietestcenter/css3/namespaces/prefix-011-expected.xml: Added.
  • ietestcenter/css3/namespaces/prefix-011.xml: Added.
  • ietestcenter/css3/namespaces/qualifiedNames-001-expected.xml: Added.
  • ietestcenter/css3/namespaces/qualifiedNames-001.xml: Added.
  • ietestcenter/css3/namespaces/scope-003-expected.xml: Added.
  • ietestcenter/css3/namespaces/scope-003.xml: Added.
  • ietestcenter/css3/namespaces/syntax-016-expected.xml: Added.
  • ietestcenter/css3/namespaces/syntax-016.xml: Added.
  • ietestcenter/css3/namespaces/syntax-017-expected.xml: Added.
  • ietestcenter/css3/namespaces/syntax-017.xml: Added.
  • ietestcenter/css3/namespaces/syntax-018-expected.xml: Added.
  • ietestcenter/css3/namespaces/syntax-018.xml: Added.
  • ietestcenter/css3/namespaces/syntax-019-expected.xml: Added.
  • ietestcenter/css3/namespaces/syntax-019.xml: Added.
  • ietestcenter/css3/namespaces/syntax-020-expected.xml: Added.
  • ietestcenter/css3/namespaces/syntax-020.xml: Added.
  • ietestcenter/css3/namespaces/syntax-021-expected.xml: Added.
  • ietestcenter/css3/namespaces/syntax-021.xml: Added.
  • ietestcenter/css3/namespaces/syntax-022-expected.xml: Added.
  • ietestcenter/css3/namespaces/syntax-022.xml: Added.
  • ietestcenter/css3/namespaces/syntax-023-expected.xml: Added.
  • ietestcenter/css3/namespaces/syntax-023.xml: Added.
  • ietestcenter/css3/namespaces/terminology-001-expected.xml: Added.
  • ietestcenter/css3/namespaces/terminology-001.xml: Added.
  • platform/chromium/test_expectations.txt:
  • platform/efl/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
2:49 PM Changeset in webkit [116807] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Mark 1 crashed test for chromium mac.

  • platform/chromium/test_expectations.txt:
2:40 PM Changeset in webkit [116806] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

ImageSkia.cpp does not conform to style guidelines
https://bugs.webkit.org/show_bug.cgi?id=86219

Patch by Keyar Hood <keyar@chromium.org> on 2012-05-11
Reviewed by Stephen White.

No tests as this is purely style changees.

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::TransformDimensions):
(WebCore::BitmapImage::draw):
(WebCore::BitmapImageSingleFrameSkia::draw):

2:36 PM Changeset in webkit [116805] by jianli@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed. Rebaseline one test for chromium mac.

  • platform/chromium-mac-leopard/css3/filters/custom/effect-color-check-expected.png: Added.
2:28 PM Changeset in webkit [116804] by Philippe Normand
  • 53 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after fonts update in r116778.

  • platform/gtk/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
  • platform/gtk/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
  • platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/gtk/fast/css/line-height-determined-by-primary-font-expected.txt:
  • platform/gtk/fast/dynamic/text-combine-expected.txt:
  • platform/gtk/fast/encoding/denormalised-voiced-japanese-chars-expected.txt:
  • platform/gtk/fast/repaint/japanese-rl-selection-clear-expected.txt:
  • platform/gtk/fast/repaint/japanese-rl-selection-repaint-expected.txt:
  • platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
  • platform/gtk/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
  • platform/gtk/fast/ruby/base-shorter-than-text-expected.txt:
  • platform/gtk/fast/ruby/nested-ruby-expected.txt:
  • platform/gtk/fast/text/backslash-to-yen-sign-euc-expected.txt:
  • platform/gtk/fast/text/backslash-to-yen-sign-expected.txt:
  • platform/gtk/fast/text/emphasis-combined-text-expected.txt:
  • platform/gtk/fast/text/emphasis-vertical-expected.txt:
  • platform/gtk/fast/text/international/001-expected.txt:
  • platform/gtk/fast/text/international/002-expected.txt:
  • platform/gtk/fast/text/international/003-expected.txt:
  • platform/gtk/fast/text/international/plane2-expected.txt:
  • platform/gtk/fast/text/international/text-combine-image-test-expected.txt:
  • platform/gtk/fast/text/international/text-spliced-font-expected.txt:
  • platform/gtk/fast/text/international/vertical-text-glyph-test-expected.txt:
  • platform/gtk/fast/text/international/vertical-text-metrics-test-expected.txt:
  • platform/gtk/fast/text/international/wrap-CJK-001-expected.txt:
  • platform/gtk/fast/text/justify-ideograph-complex-expected.txt:
  • platform/gtk/fast/text/justify-ideograph-simple-expected.txt:
  • platform/gtk/fast/text/justify-ideograph-vertical-expected.txt:
  • platform/gtk/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
  • platform/gtk/fast/writing-mode/border-vertical-lr-expected.txt:
  • platform/gtk/fast/writing-mode/fallback-orientation-expected.txt:
  • platform/gtk/fast/writing-mode/japanese-lr-selection-expected.txt:
  • platform/gtk/fast/writing-mode/japanese-lr-text-expected.txt:
  • platform/gtk/fast/writing-mode/japanese-rl-selection-expected.txt:
  • platform/gtk/fast/writing-mode/japanese-rl-text-expected.txt:
  • platform/gtk/fast/writing-mode/japanese-ruby-horizontal-bt-expected.txt:
  • platform/gtk/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
  • platform/gtk/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
  • platform/gtk/fast/writing-mode/vertical-align-table-baseline-expected.txt:
  • platform/gtk/fast/writing-mode/vertical-baseline-alignment-expected.txt:
  • platform/gtk/fast/writing-mode/vertical-font-fallback-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
  • platform/gtk/svg/dom/altGlyph-dom-expected.txt:
  • platform/gtk/svg/text/text-fonts-01-t-expected.txt:
2:24 PM Changeset in webkit [116803] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed Chromium build fix after http://trac.webkit.org/changeset/116799.

  • rendering/RenderLayerBacking.cpp:
2:16 PM Changeset in webkit [116802] by commit-queue@webkit.org
  • 7 edits in trunk

[chromium] Compute the best target node on a GestureTap event
https://bugs.webkit.org/show_bug.cgi?id=85101

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-05-11
Reviewed by Adam Barth.

Source/WebCore:

Will be using the tests in the touchadjustment/ directory.

  • WebCore.gypi:

Include TouchAdjustment.* files.

Source/WebKit/chromium:

  • features.gypi:

Enable the touch adjustment code by default.

  • src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
In the case of a GestureTap, deltaX represents the horizontal padding of the touch
area and deltaY represents the vertical padding of the touch area.

LayoutTests:

  • platform/chromium/test_expectations.txt:

Skipping two layout tests in the touchadjustment/ directory that
fail using DRT but pass when I run through the test cases manually.
Allan Jensen experiences a similar problem with these two tests
on the qt port (see comment 36 in the bug description) and will be
investigating why these tests have unexpected behavior.

2:12 PM Changeset in webkit [116801] by commit-queue@webkit.org
  • 8 edits
    4 deletes in trunk

Unreviewed, rolling out r116498.
http://trac.webkit.org/changeset/116498
https://bugs.webkit.org/show_bug.cgi?id=86251

Causes crashes in major sites and security issues (Requested
by schenney on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-11

Source/WebCore:

  • rendering/svg/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::addChild):

  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::willBeDestroyed):
(WebCore::RenderSVGInlineText::setTextInternal):
(WebCore::RenderSVGInlineText::styleDidChange):

  • rendering/svg/RenderSVGText.cpp:

(WebCore::recursiveUpdateLayoutAttributes):
(WebCore::RenderSVGText::layoutAttributesChanged):
(WebCore::RenderSVGText::layoutAttributesWillBeDestroyed):
(WebCore::RenderSVGText::invalidateTextPositioningElements):
(WebCore::recursiveUpdateScaledFont):
(WebCore::RenderSVGText::layout):
(WebCore::RenderSVGText::addChild):
(WebCore::recursiveCollectLayoutAttributes):
(WebCore::RenderSVGText::rebuildLayoutAttributes):
(WebCore):

  • rendering/svg/RenderSVGText.h:

(RenderSVGText):
(WebCore::RenderSVGText::layoutAttributes):

  • rendering/svg/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):

  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp:

(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributes):

LayoutTests:

  • svg/text/add-tspan-position-bug-expected.html: Removed.
  • svg/text/add-tspan-position-bug.html: Removed.
  • svg/text/modify-tspan-position-bug-expected.html: Removed.
  • svg/text/modify-tspan-position-bug.html: Removed.
1:24 PM Changeset in webkit [116800] by kevino@webkit.org
  • 4 edits in trunk

[wx] Unreviewed build fixes for recent trunk changes and 32-bit ld *nix builds.

1:16 PM Changeset in webkit [116799] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebCore

FrameView->m_lastPaintTime is not updated in the tiled drawing case
https://bugs.webkit.org/show_bug.cgi?id=86246
<rdar://problem/11248475>

Reviewed by Simon Fraser.

Update FrameView's m_lastPaintTime from RenderLayerBacking::paintContents
if the RenderLayerBacking is backing a tiled drawing layer.

In the future we might want to consider updating m_lastPaintTime when any
compositing layer is painted into, but this change gets us on par with the
non-tiled-drawing case as it stands now.

No new tests.

  • page/FrameView.h:

(WebCore::FrameView::setLastPaintTime):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintContents):

1:09 PM Changeset in webkit [116798] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebCore

Add helper function for node()->rootEditableElement() == node()
https://bugs.webkit.org/show_bug.cgi?id=86217

Patch by Shezan Baig <shezbaig.wk@gmail.com> on 2012-05-11
Reviewed by Ryosuke Niwa.

Added Node::isRootEditableElement and updated existing code that did
(node->rootEditableElement() == node) to use isRootEditableElement
instead.

No new tests. No change in behavior.

  • dom/Node.cpp:

(WebCore::Node::isRootEditableElement):
(WebCore):

  • dom/Node.h:

(Node):
Added new helper function.

  • dom/Document.cpp:

(WebCore::Document::setFocusedNode):

  • dom/Element.cpp:

(WebCore::Element::updateFocusAppearance):

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::removeNode):

  • editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::doApply):

  • page/FocusController.cpp:

(WebCore::FocusController::setFocusedNode):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::hasLineIfEmpty):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::addOverflowFromInlineChildren):
Updates to existing code to use the new helper function.

1:07 PM Changeset in webkit [116797] by shawnsingh@chromium.org
  • 5 edits
    2 adds in trunk/Source

[chromium] Create WebTransformationMatrix interface for chromium platform
https://bugs.webkit.org/show_bug.cgi?id=86049

Reviewed by James Robinson.

Source/Platform:

  • Platform.gyp/Platform.gyp:
  • Platform.gypi:
  • chromium/public/WebTransformationMatrix.h: Added.

(WebCore):
(WebKit):
(WebTransformationMatrix):

Source/WebCore:

This patch creates a WebTransformationMatrix interface. It will
remain unused at the moment, until (a) unit tests are created
and (b) when we are ready to make a brief transition of all other
chromium code to use it.

  • WebCore.gypi:
  • platform/chromium/support/WebTransformationMatrix.cpp: Added.

(WebKit):
(WebKit::WebTransformationMatrix::WebTransformationMatrix):
(WebKit::WebTransformationMatrix::operator=):
(WebKit::WebTransformationMatrix::operator==):
(WebKit::WebTransformationMatrix::operator*):
(WebKit::WebTransformationMatrix::inverse):
(WebKit::WebTransformationMatrix::to2dTransform):
(WebKit::WebTransformationMatrix::multiply):
(WebKit::WebTransformationMatrix::makeIdentity):
(WebKit::WebTransformationMatrix::translate):
(WebKit::WebTransformationMatrix::translate3d):
(WebKit::WebTransformationMatrix::translateRight3d):
(WebKit::WebTransformationMatrix::scale):
(WebKit::WebTransformationMatrix::scaleNonUniform):
(WebKit::WebTransformationMatrix::scale3d):
(WebKit::WebTransformationMatrix::rotate):
(WebKit::WebTransformationMatrix::rotate3d):
(WebKit::WebTransformationMatrix::skewX):
(WebKit::WebTransformationMatrix::skewY):
(WebKit::WebTransformationMatrix::applyPerspective):
(WebKit::WebTransformationMatrix::blend):
(WebKit::WebTransformationMatrix::hasPerspective):
(WebKit::WebTransformationMatrix::isInvertible):
(WebKit::WebTransformationMatrix::isBackFaceVisible):
(WebKit::WebTransformationMatrix::isIdentity):
(WebKit::WebTransformationMatrix::isIdentityOrTranslation):
(WebKit::WebTransformationMatrix::isIntegerTranslation):
(WebKit::WebTransformationMatrix::m11):
(WebKit::WebTransformationMatrix::setM11):
(WebKit::WebTransformationMatrix::m12):
(WebKit::WebTransformationMatrix::setM12):
(WebKit::WebTransformationMatrix::m13):
(WebKit::WebTransformationMatrix::setM13):
(WebKit::WebTransformationMatrix::m14):
(WebKit::WebTransformationMatrix::setM14):
(WebKit::WebTransformationMatrix::m21):
(WebKit::WebTransformationMatrix::setM21):
(WebKit::WebTransformationMatrix::m22):
(WebKit::WebTransformationMatrix::setM22):
(WebKit::WebTransformationMatrix::m23):
(WebKit::WebTransformationMatrix::setM23):
(WebKit::WebTransformationMatrix::m24):
(WebKit::WebTransformationMatrix::setM24):
(WebKit::WebTransformationMatrix::m31):
(WebKit::WebTransformationMatrix::setM31):
(WebKit::WebTransformationMatrix::m32):
(WebKit::WebTransformationMatrix::setM32):
(WebKit::WebTransformationMatrix::m33):
(WebKit::WebTransformationMatrix::setM33):
(WebKit::WebTransformationMatrix::m34):
(WebKit::WebTransformationMatrix::setM34):
(WebKit::WebTransformationMatrix::m41):
(WebKit::WebTransformationMatrix::setM41):
(WebKit::WebTransformationMatrix::m42):
(WebKit::WebTransformationMatrix::setM42):
(WebKit::WebTransformationMatrix::m43):
(WebKit::WebTransformationMatrix::setM43):
(WebKit::WebTransformationMatrix::m44):
(WebKit::WebTransformationMatrix::setM44):
(WebKit::WebTransformationMatrix::a):
(WebKit::WebTransformationMatrix::setA):
(WebKit::WebTransformationMatrix::b):
(WebKit::WebTransformationMatrix::setB):
(WebKit::WebTransformationMatrix::c):
(WebKit::WebTransformationMatrix::setC):
(WebKit::WebTransformationMatrix::d):
(WebKit::WebTransformationMatrix::setD):
(WebKit::WebTransformationMatrix::e):
(WebKit::WebTransformationMatrix::setE):
(WebKit::WebTransformationMatrix::f):
(WebKit::WebTransformationMatrix::setF):
(WebKit::WebTransformationMatrix::toWebCoreTransform):
(WebKit::WebTransformationMatrix::mapRect):
(WebKit::WebTransformationMatrix::mapPoint):
(WebKit::WebTransformationMatrix::mapQuad):
(WebKit::WebTransformationMatrix::projectPoint):

12:49 PM Changeset in webkit [116796] by kling@webkit.org
  • 15 edits
    1 move in trunk/Source/WebKit2

WK2/Plugins: Move enumeration of plugins to a secondary UIProcess thread.
<http://webkit.org/b/86143>
<rdar://problem/10777218>

Reviewed by Anders Carlsson.

To avoid spins beneath PluginInfoStore::getPluginInfo(), do this work on a secondary
thread in the UIProcess.

  • Shared/APIObject.h:

Made APIObject a ThreadSafeRefCounted. In the context of this patch, this is to
be able to dispatch bound Functions on WebContext.

  • WebProcess/mac/KeychainItemShimMethods.mm:

(WebKit::responseMap):

  • WebProcess/mac/SecItemShimMethods.mm:

(WebKit::responseMap):

  • WebKit2.xcodeproj/project.pbxproj:
  • Shared/BlockingResponseMap.h:

(BlockingResponseMap):
(BlockingResponseMap::waitForResponse):
(BlockingResponseMap::didReceiveResponse):

Renamed from Source/WebKit2/WebProcess/mac/KeychainShimResponseMap.h.
Generalize this somewhat since it's useful in more than just the keychain scenario.
This can/should be generalized further, but that's a topic for another patch.

  • UIProcess/Plugins/PluginInfoStore.h:
  • UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::PluginInfoStore::plugins):
(WebKit::PluginInfoStore::findPluginForMIMEType):
(WebKit::PluginInfoStore::findPluginForExtension):
(WebKit::PluginInfoStore::findPlugin):
(WebKit::PluginInfoStore::infoForPluginWithPath):

Slap a mutex on the PluginInfoStore since it can now be called from both the
main thread (via WKFrameCanShowMIMEType) and the GetPlugin work queue.

  • UIProcess/WebContext.messages.in:
  • UIProcess/WebContext.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::processDidFinishLaunching):
(WebKit::WebContext::sendDidGetPlugins):
(WebKit::WebContext::handleGetPlugins):
(WebKit::WebContext::getPlugins):
(WebKit::WebContext::didReceiveMessageOnConnectionWorkQueue):

Make GetPlugins a DispatchOnConnectionQueue message and execute it on a new
plug-in work queue. This effectively makes the GetPlugin call asynchronous.
On Mac, the built-in PDF reader is still registered on the main thread as that
ends up calling into localizedString().

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didGetPlugins):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:

Add a DidGetPlugins message to WebProcess. This is passed directly to the handler
in WebPlatformStrategies.cpp.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::responseMap):
(WebKit::handleDidGetPlugins):
(WebKit::generateRequestID):
(WebKit::WebPlatformStrategies::populatePluginCache):

Use a BlockingResponseMap to block the WebProcess main thread until the UIProcess
responds with DidGetPlugins.

12:45 PM Changeset in webkit [116795] by Alexandru Chiculita
  • 8 edits
    5 adds in trunk

[CSS Shaders] Make CSS Shaders render to texture framebuffers
https://bugs.webkit.org/show_bug.cgi?id=85113

Reviewed by Dean Jackson.

Source/WebCore:

Added the required members to store the framebuffer, the texture and the depth buffer. Also removed the m_drawingBuffer
because context->readPixels doesn't require one anymore.

ReadPixels is not flipping the result, so I've also removed the flipping projection matrix that was specific only to Chromium.

Added a test to check that colors are not switched and the resulting image is not mirrored.

Test: css3/filters/custom/effect-color-check.html

  • platform/graphics/filters/FECustomFilter.cpp:

(WebCore::FECustomFilter::FECustomFilter):
(WebCore::FECustomFilter::~FECustomFilter):
(WebCore):
(WebCore::FECustomFilter::deleteRenderBuffers):
(WebCore::FECustomFilter::platformApplySoftware):
(WebCore::FECustomFilter::initializeContext):
(WebCore::FECustomFilter::resizeContext):
(WebCore::FECustomFilter::bindProgramAndBuffers):

  • platform/graphics/filters/FECustomFilter.h:

(FECustomFilter):

LayoutTests:

Added a test to check that colors are not switched and the resulting image is not mirrored.

  • css3/filters/custom/effect-color-check-expected.png: Added.
  • css3/filters/custom/effect-color-check-expected.txt: Added.
  • css3/filters/custom/effect-color-check.html: Added.
  • css3/filters/resources/color-fill.fs: Added.
  • platform/chromium-linux/css3/filters/custom/custom-filter-shader-cache-expected.png:
  • platform/chromium-linux/css3/filters/custom/effect-custom-combined-missing-expected.png:
  • platform/chromium-linux/css3/filters/custom/effect-custom-expected.png:
  • platform/chromium-mac/css3/filters/custom/effect-color-check-expected.png: Added.
  • platform/chromium/test_expectations.txt:
12:40 PM Changeset in webkit [116794] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

REGRESSION(r116687): [Chromium] plugins/embed-attributes-style.html shows a garbled string
https://bugs.webkit.org/show_bug.cgi?id=86170

Reviewed by Andreas Kling.

The string we are passing to the TextRun constructor needs to stay alive for longer so revert back to the old
behavior where we store it as a member variable.

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::unavailablePluginReplacementText):
(WebCore):
(WebCore::RenderEmbeddedObject::setPluginUnavailabilityReason):
(WebCore::RenderEmbeddedObject::getReplacementTextGeometry):

  • rendering/RenderEmbeddedObject.h:

(RenderEmbeddedObject):

12:21 PM Changeset in webkit [116793] by commit-queue@webkit.org
  • 29 edits in trunk/LayoutTests

[EFL] Tests needs rebaselining after r116776
https://bugs.webkit.org/show_bug.cgi?id=86227

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-11

  • platform/efl/fast/css/line-height-determined-by-primary-font-expected.png:
  • platform/efl/fast/css/line-height-determined-by-primary-font-expected.txt:
  • platform/efl/fast/dynamic/text-combine-expected.png:
  • platform/efl/fast/dynamic/text-combine-expected.txt:
  • platform/efl/fast/encoding/denormalised-voiced-japanese-chars-expected.png:
  • platform/efl/fast/encoding/denormalised-voiced-japanese-chars-expected.txt:
  • platform/efl/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/efl/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
  • platform/efl/fast/ruby/base-shorter-than-text-expected.png:
  • platform/efl/fast/ruby/base-shorter-than-text-expected.txt:
  • platform/efl/fast/ruby/nested-ruby-expected.png:
  • platform/efl/fast/ruby/nested-ruby-expected.txt:
  • platform/efl/fast/text/backslash-to-yen-sign-euc-expected.png:
  • platform/efl/fast/text/backslash-to-yen-sign-euc-expected.txt:
  • platform/efl/fast/text/backslash-to-yen-sign-expected.png:
  • platform/efl/fast/text/backslash-to-yen-sign-expected.txt:
  • platform/efl/fast/text/emphasis-combined-text-expected.png:
  • platform/efl/fast/text/emphasis-combined-text-expected.txt:
  • platform/efl/fast/text/justify-ideograph-leading-expansion-expected.png:
  • platform/efl/fast/text/justify-ideograph-leading-expansion-expected.txt:
  • platform/efl/fast/text/justify-ideograph-simple-expected.png:
  • platform/efl/fast/text/justify-ideograph-simple-expected.txt:
  • platform/efl/fast/text/justify-ideograph-vertical-expected.png:
  • platform/efl/fast/text/justify-ideograph-vertical-expected.txt:
  • platform/efl/fast/writing-mode/vertical-align-table-baseline-expected.png:
  • platform/efl/fast/writing-mode/vertical-align-table-baseline-expected.txt:
  • platform/efl/fast/writing-mode/vertical-baseline-alignment-expected.png:
  • platform/efl/fast/writing-mode/vertical-baseline-alignment-expected.txt:
11:56 AM Changeset in webkit [116792] by Simon Fraser
  • 6 edits
    2 adds in trunk

Source/WebCore: CVDisplayLink keeps running after a single requestAnimationFrame
https://bugs.webkit.org/show_bug.cgi?id=86174

Reviewed by Sam Weinig.

A DisplayRefreshMonitor would keep its CVDisplayLink alive for as long
as it had clients, and the client is the ScriptedAnimationController, which
lives on the document. So a single requestAnimationFrame call would kick
off a CVDisplayLink which lived until the document was destroyed.

Fix by having the DisplayRefreshMonitor kill itself if the CVDisplayLink
fires for 10 times with no scheduled callbacks (to avoid creation/deletion
thrash on pages that call requestAnimationFrames with short setTimeouts,
as some do).

Use a HashMap in DisplayRefreshMonitorManager for the set of DisplayRefreshMonitor,
with the displayID as the key (using UnsignedWithZeroKeyHashTraits<uint64_t> since
we want to allow for 0 to be a valid displayID).

Use a HashSet in DisplayRefreshMonitor for the client set, so that we don't have to
worry about adding clients twice.

Also fix a possible crash when the only client of a DisplayRefreshMonitor
was removed from inside the callback by making DisplayRefreshMonitor ref-counted,
with a protector.

Test: fast/animation/request-animation-frame-detach-element2.html

  • platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitor::DisplayRefreshMonitor): Initialize m_unscheduledFireCount
(WebCore::DisplayRefreshMonitor::handleDisplayRefreshedNotificationOnMainThread): Renamed
from refreshDisplayOnMainThread, since it doesn't just refresh the display.
(WebCore::DisplayRefreshMonitor::addClient): No longer inline.
(WebCore::DisplayRefreshMonitor::removeClient): No longer inline.
(WebCore::DisplayRefreshMonitor::displayDidRefresh): Keep track of m_unscheduledFireCount,
which we used to kill this monitor if it has been idle for a while.
Use a RefPtr<DisplayRefreshMonitor> to prevent deletion while running the callback.
Copy the clients to a vector to protect against mutating the set while enumerating it.
Notify the DisplayRefreshMonitorManager when we're done, so that it can decide
to delete inactive monitors.

(WebCore::DisplayRefreshMonitorManager::ensureMonitorForClient): find or allocate
a DisplayRefreshMonitor for a given client.
(WebCore::DisplayRefreshMonitorManager::registerClient): Simplified by use of HashMap.
(WebCore::DisplayRefreshMonitorManager::unregisterClient): Ditto.
(WebCore::DisplayRefreshMonitorManager::scheduleAnimation): Ditto. Uses
ensureMonitorForClient() since an earlier inactive monitor may have been removed.
(WebCore::DisplayRefreshMonitorManager::displayDidRefresh): Remove inactive
monitors.

  • platform/graphics/DisplayRefreshMonitor.h: Make DisplayRefreshMonitor

ref-counted, to make it easier to avoid deletion while it's on the stack.
(WebCore::DisplayRefreshMonitor::create):
(DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::shouldBeTerminated):
(DisplayRefreshMonitorManager):

  • platform/graphics/blackberry/DisplayRefreshMonitorBlackBerry.cpp: Attempt to

keep things building.
(WebCore::DisplayRefreshMonitor::~DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::displayLinkFired):
to give the manager a chance to kill this monitor.

  • platform/graphics/mac/DisplayRefreshMonitorMac.cpp:

(WebCore::DisplayRefreshMonitor::~DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::displayLinkFired): Don't bail early
if not scheduled; we want to call handleDisplayRefreshedNotificationOnMainThread(),

LayoutTests: CVDisplayLink keeps running after a single requestAnimationFrame
https://bugs.webkit.org/show_bug.cgi?id=86174

Reviewed by Sam Weinig.

Test removing a frame inside its requestAnimationFrame callback.

  • fast/animation/request-animation-frame-detach-element2-expected.txt: Added.
  • fast/animation/request-animation-frame-detach-element2.html: Added.
11:50 AM Changeset in webkit [116791] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: move canEditScriptSource and setScriptSource from DebuggerPresentationModel into ResourceBinding
https://bugs.webkit.org/show_bug.cgi?id=86234

Reviewed by Vsevolod Vlasov.

Simple move refactoring.

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerResourceBinding):
(WebInspector.DebuggerResourceBinding.canEditScriptSource):
(WebInspector.DebuggerResourceBinding.setScriptSource.didEditScriptSource):
(WebInspector.DebuggerResourceBinding.setScriptSource):
(WebInspector.DebuggerResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerResourceBinding.prototype._uiSourceCodeForResource):
(WebInspector.DebuggerResourceBinding.prototype._setContentWithInitialContent):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.canEditSource):
(WebInspector.JavaScriptSourceFrame.prototype.editContent):

11:48 AM Changeset in webkit [116790] by jchaffraix@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove RenderLayer::m_scrollOverflow
https://bugs.webkit.org/show_bug.cgi?id=86226

Reviewed by Simon Fraser.

No expected change in behavior.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::computeScrollDimensions):
Added 2 local variables to compute the left / top scrollable overflows.

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::scrolledContentOffset):
Returned m_scrollOffset directly as this is what the old code was doing by adding
m_scrollOrigin then adding m_scrollOverflow (which was set to -m_scrollOrigin in
computeScrollDimensions).

(RenderLayer::m_scrollOffset): Improved the comment about what m_scrollOffset is.

11:31 AM Changeset in webkit [116789] by pfeldman@chromium.org
  • 9 edits in trunk

Web Inspector: extract PresentationConsoleMessageHelper from DebuggerPresentationModel.
https://bugs.webkit.org/show_bug.cgi?id=86229

Reviewed by Vsevolod Vlasov.

This change also starts tracking messages along with the live location changes.

Tested with script-formatter-console.html.

  • inspector/front-end/BreakpointManager.js:
  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.PresentationConsoleMessageHelper):
(WebInspector.PresentationConsoleMessageHelper.prototype._addPendingConsoleMessage):
(WebInspector.PresentationConsoleMessageHelper.prototype._parsedScriptSource):
(WebInspector.PresentationConsoleMessageHelper.prototype._debuggerReset):
(WebInspector.PresentationConsoleMessage):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu):
(WebInspector.JavaScriptSourceFrame.prototype._consoleMessageAdded):
(WebInspector.JavaScriptSourceFrame.prototype._setBreakpoint):

11:21 AM Changeset in webkit [116788] by eae@chromium.org
  • 3 edits in trunk/Source/WebCore

Simplify FloatingObject by removing unnecessary convenience methods.
https://bugs.webkit.org/show_bug.cgi?id=86163

Reviewed by Eric Seidel.

Simplify the pixel snapping in FloatingObject by getting rid of a bunch
of convenience methods.

No new tests, no change in functionality.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::FloatingObjects::intervalForFloatingObject):
(WebCore::::string):

  • rendering/RenderBlock.h:

(FloatingObject):
(WebCore::RenderBlock::pixelSnappedLogicalTopForFloat):
(WebCore::RenderBlock::pixelSnappedLogicalBottomForFloat):
(WebCore::RenderBlock::pixelSnappedLogicalLeftForFloat):
(WebCore::RenderBlock::pixelSnappedLogicalRightForFloat):

11:10 AM Changeset in webkit [116787] by dpranke@chromium.org
  • 3 edits in trunk/Tools

webkit-patch rebaseline should fetch stale expectations :)
https://bugs.webkit.org/show_bug.cgi?id=86231

Unreviewed, build fix.

This change reverts r115492 and goes back to fetching individual
baselines from the layout tests directory, rather than fetching
entire zip files. The performance hit over networks for people
far away from the bots has turned out to be severe, so we need a
better solution to this.

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineTest._results_url):
(RebaselineTest._file_name_for_expected_result):
(RebaselineTest._rebaseline_test):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaseline.test_rebaseline_updates_expectations_file_noop):
(test_rebaseline_updates_expectations_file):
(test_rebaseline_test):
(test_rebaseline_and_copy_test):
(test_rebaseline_and_copy_test_no_existing_result):
(test_rebaseline_and_copy_test_with_lion_result):
(test_rebaseline_and_copy_no_overwrite_test):

11:04 AM Changeset in webkit [116786] by commit-queue@webkit.org
  • 9 edits
    4 adds in trunk

[chromium] Ensure that animations continue to run when transform-style is changed
https://bugs.webkit.org/show_bug.cgi?id=83283

Source/WebCore:

Make sure that we transfer animations when changing layers due to a transform-style change.
Unit tested in GraphicsLayerChromiumTest.updateLayerPreserves3DWithAnimations

Patch by Ian Vollick <vollick@chromium.org> on 2012-05-11
Reviewed by James Robinson.

Test: animations/change-transform-style-during-animation.html

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setLayerAnimationController):
(WebCore::LayerChromium::releaseLayerAnimationController):
(WebCore):
(WebCore::LayerChromium::notifyAnimationStarted):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):

  • platform/graphics/chromium/cc/CCLayerAnimationController.cpp:

(WebCore::CCLayerAnimationController::CCLayerAnimationController):
(WebCore::CCLayerAnimationController::pushAnimationUpdatesTo):
(WebCore::CCLayerAnimationController::notifyAnimationStarted):
(WebCore::CCLayerAnimationController::setClient):
(WebCore):
(WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):
(WebCore::CCLayerAnimationController::replaceImplThreadAnimations):

  • platform/graphics/chromium/cc/CCLayerAnimationController.h:

(CCLayerAnimationController):
(WebCore::CCLayerAnimationController::setForceSync):

Source/WebKit/chromium:

Patch by Ian Vollick <vollick@chromium.org> on 2012-05-11
Reviewed by James Robinson.

  • WebKit.gypi:
  • tests/GraphicsLayerChromiumTest.cpp: Added.

(WebKitTests):
(MockGraphicsLayerClient):
(WebKitTests::MockGraphicsLayerClient::notifyAnimationStarted):
(WebKitTests::MockGraphicsLayerClient::notifySyncRequired):
(WebKitTests::MockGraphicsLayerClient::paintContents):
(WebKitTests::MockGraphicsLayerClient::showDebugBorders):
(WebKitTests::MockGraphicsLayerClient::showRepaintCounter):
(WebKitTests::TEST):

LayoutTests:

Patch by Ian Vollick <vollick@chromium.org> on 2012-05-11
Reviewed by James Robinson.

  • animations/change-transform-style-during-animation-expected.png: Added.
  • animations/change-transform-style-during-animation-expected.txt: Added.
  • animations/change-transform-style-during-animation.html: Added.
10:57 AM Changeset in webkit [116785] by weinig@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix crash seen when running with libgmalloc
<rdar://problem/11435411>
https://bugs.webkit.org/show_bug.cgi?id=86232

Reviewed by Gavin Barraclough.

  • heap/MarkStack.cpp:

(JSC::MarkStackThreadSharedData::markingThreadMain):
Don't delete the SlotVisitor before the ParallelModeEnabler has had a chance to run its
destructor.

10:28 AM Changeset in webkit [116784] by tomz@codeaurora.org
  • 23 edits in trunk/LayoutTests

[Qt]ietestcenter/css3/flexbox tests fail on 32 bit
https://bugs.webkit.org/show_bug.cgi?id=85596

Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-05-11
Reviewed by Csaba Osztrogonác.

Reference tests originally assumed "background: green" was identical
to the green used in the pngs used by the feature tests. On local builds
of QT, GTK, and chromium, this assumption seemed to hold up. On the Mac
and QT bots however, it became clear this was an invalid assumption. I've
re-written the reference tests to use the original pngs as appropriate.
I have reproduced the failures on a Mac & Qt32 and verified that the newly
re-written reference tests behave properly now.

  • ietestcenter/css3/flexbox/flexbox-align-end-001-expected.htm:
  • ietestcenter/css3/flexbox/flexbox-align-start-001-expected.htm:
  • ietestcenter/css3/flexbox/flexbox-flex-001-expected.htm:
  • ietestcenter/css3/flexbox/flexbox-flex-002-expected.htm:
  • ietestcenter/css3/flexbox/flexbox-flex-003-expected.htm:
  • ietestcenter/css3/flexbox/flexbox-flex-004-expected.htm:
  • ietestcenter/css3/flexbox/flexbox-groups-001-expected.htm:
  • ietestcenter/css3/flexbox/flexbox-groups-002-expected.htm:
  • ietestcenter/css3/flexbox/flexbox-groups-003-expected.htm:
  • ietestcenter/css3/flexbox/flexbox-groups-004-expected.htm:
  • ietestcenter/css3/flexbox/flexbox-layout-001-expected.htm:
  • ietestcenter/css3/flexbox/flexbox-layout-003-expected.htm:
  • ietestcenter/css3/flexbox/flexbox-pack-end-001-expected.htm:
  • ietestcenter/css3/flexbox/flexbox-pack-justify-001-expected.htm:
  • ietestcenter/css3/flexbox/flexbox-pack-start-001-expected.htm:
  • platform/chromium/test_expectations.txt:
  • platform/efl/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/Skipped:
  • platform/mac/test_expectations.txt:
  • platform/qt/Skipped:
  • platform/qt/test_expectations.txt:
10:09 AM Changeset in webkit [116783] by tommyw@google.com
  • 3 edits
    1 add in trunk

MediaStream API: Fix a reference counting issue in UserMediaRequest
https://bugs.webkit.org/show_bug.cgi?id=86210

Reviewed by Abhishek Arya.

.:

  • ManualTests/user-media-request-crash.html: Added.

Source/WebCore:

When contextDestroyed() is called on UserMediaRequest it does a callback to the
page client. If the receiving code clears their stored copy the UserMediaRequest
object is destroyed in the middle of the call.

Currently only testable manually against chrome, preferably with asan turned on.
I have added a manual test that verifies the fix, but I have started work
to make DumpRenderTree able to test this and many other things. The first patch is here:
https://bugs.webkit.org/show_bug.cgi?id=86215

  • Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::contextDestroyed):

10:05 AM Changeset in webkit [116782] by commit-queue@webkit.org
  • 9 edits in trunk/Source

split MediaPlayer::enterFullscreen into 2 seperate functions
https://bugs.webkit.org/show_bug.cgi?id=86052

Patch by Min Qin <qinmin@google.com> on 2012-05-11
Reviewed by Adam Barth.

Source/WebCore:

It is confusing that enterFullscreen returns a boolean while exitFullscreen does
not do the same. And ios does not need the return value.
So remove the return value on enterFullscreen and make a seperate canEnterFullscreen()
function for android.
No tests as there are no behavior change, just refactoring.

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::enterFullscreen):
(WebCore):
(WebCore::MediaPlayer::canEnterFullscreen):

  • platform/graphics/MediaPlayer.h:

(MediaPlayer):

  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::enterFullscreen):
(MediaPlayerPrivateInterface):
(WebCore::MediaPlayerPrivateInterface::canEnterFullscreen):

Source/WebKit/chromium:

In WebCore, we splitted bool enterFullscreen() into two seperate calls:
void enterFullscreen() and bool canEnterFullscreen()
This is the change in the chromium part that we needed to support the WebCore change
No behavior change, just refactoring.

  • public/WebMediaPlayer.h:

(WebMediaPlayer):
(WebKit::WebMediaPlayer::enterFullscreen):
(WebKit::WebMediaPlayer::canEnterFullscreen):

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::enterFullscreen):
(WebKit):
(WebKit::WebMediaPlayerClientImpl::exitFullscreen):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::enterFullScreenForElement):

9:51 AM Changeset in webkit [116781] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Gardening failure test cases.
https://bugs.webkit.org/show_bug.cgi?id=86212

Unreviewed EFL gardening.

Test expectations update, moving related bugs from Skipped list to test_expectations.txt.

Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-05-11

  • platform/efl/Skipped:
  • platform/efl/test_expectations.txt: adding new bug regarding to missing contextClick implementation.
9:46 AM Changeset in webkit [116780] by pfeldman@chromium.org
  • 8 edits in trunk

Web Inspector: move breakpoint manager from debuggerPresentationModel to WebInspector.
https://bugs.webkit.org/show_bug.cgi?id=86220

Reviewed by Yury Semikhatsky.

Source/WebCore:

Now that breakpoint manager does not depend on the source mapping instance from the
debugger presentation model, it can be moved out.

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):

  • inspector/front-end/JavaScriptSource.js:

(WebInspector.JavaScriptSource):
(WebInspector.JavaScriptSource.prototype.setFormatted.didGetContent.didFormatContent):
(WebInspector.JavaScriptSource.prototype.setFormatted.didGetContent):
(WebInspector.JavaScriptSource.prototype.setFormatted):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):

  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/inspector.js:

LayoutTests:

  • inspector/debugger/scripts-panel.html:
9:41 AM Changeset in webkit [116779] by commit-queue@webkit.org
  • 10 edits in trunk/Source

[Chromium] Move instantiation of texture uploader to LayerRendererChromium.
https://bugs.webkit.org/show_bug.cgi?id=85893

Patch by David Reveman <reveman@chromium.org> on 2012-05-11
Reviewed by Adrienne Walker.

Source/WebCore:

Move instantiation of texture uploader to LayerRendererChromium and
allow CCProxy to decide between a throttled or unthrottled uploader
using a flag passed to the LayerRendererChromium constructor.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::initializeSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::recreateContext):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::initializeLayerRendererOnImplThread):
(WebCore::CCThreadProxy::recreateContextOnImplThread):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKitTests::CCLayerTreeHostImplTest::CCLayerTreeHostImplTest):
(WebKitTests::TEST_F):

  • tests/LayerRendererChromiumTest.cpp:

(FakeLayerRendererChromium::FakeLayerRendererChromium):
(LayerRendererChromiumTest::LayerRendererChromiumTest):
(TEST):

9:41 AM Changeset in webkit [116778] by commit-queue@webkit.org
  • 5 edits in trunk

[GTK] LayoutTests/svg/batik/text/verticalText.svg fails to display Chinese characters
https://bugs.webkit.org/show_bug.cgi?id=86198

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-11
Reviewed by Martin Robinson.

Tools:

Update webkitgtk-fonts package to v0.0.3 in order to get new Kochi
Mincho / Gothic fonts to display Japanese and Chinese characters.

  • gtk/jhbuild.modules:

LayoutTests:

Rebaseline svg/batik/text/verticalText.svg now that GTK's
DumpRenderTree is able to display Chinese characters.

  • platform/gtk/svg/batik/text/verticalText-expected.png:
  • platform/gtk/svg/batik/text/verticalText-expected.txt:
9:33 AM Changeset in webkit [116777] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

Two of the touch-adjustment tests are flaky.
https://bugs.webkit.org/show_bug.cgi?id=86218

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-11
Reviewed by Simon Hausmann.

Move the touch points and text so the tests are more stable.

  • touchadjustment/event-triggered-widgets-expected.txt:
  • touchadjustment/event-triggered-widgets.html:
  • touchadjustment/touch-inlines.html:
9:28 AM Changeset in webkit [116776] by commit-queue@webkit.org
  • 6 edits in trunk

[EFL][DRT] SVG Batik test fails to display Chinese characters
https://bugs.webkit.org/show_bug.cgi?id=84461

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-11
Reviewed by Martin Robinson.

Tools:

Update webkitgtk-fonts package from v0.0.1 to v0.0.3 in order to get
new Kochi Mincho / Gothic fonts to display Japanese and Chinese
characters.

  • DumpRenderTree/efl/CMakeLists.txt:
  • efl/jhbuild.modules:

LayoutTests:

Rebaseline svg/batik/text/verticalText.svg now that EFL's
DumpRenderTree is able to display Chinese characters.

  • platform/efl/svg/batik/text/verticalText-expected.png:
  • platform/efl/svg/batik/text/verticalText-expected.txt:
9:13 AM Changeset in webkit [116775] by pfeldman@chromium.org
  • 26 edits
    1 delete in trunk

Web Inspector: pass source mapping into UISourceCode's constructor; move formatting outside mapping.
https://bugs.webkit.org/show_bug.cgi?id=86099

Reviewed by Vsevolod Vlasov.

Source/WebCore:

This changes moves formatting out of the source mapping machinery.
As a result, it removes most of the DebuggerPresentation's mapping-related code as well
as most of the raw source code's code.

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager):
(WebInspector.BreakpointManager.prototype.restoreBreakpoints):
(WebInspector.BreakpointManager.Breakpoint):

  • inspector/front-end/CallStackSidebarPane.js:

(WebInspector.CallStackSidebarPane.prototype.setStatus):

  • inspector/front-end/CompilerScriptMapping.js:
  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._callFrameSelected):
(WebInspector.DebuggerPresentationModel.prototype._handleUISourceCodeListChanged):
(WebInspector.DebuggerPresentationModel.prototype.continueToLine):

  • inspector/front-end/JavaScriptSource.js:

(WebInspector.JavaScriptSource):
(WebInspector.JavaScriptSource.prototype.fireContentAvailable):
(WebInspector.JavaScriptSource.prototype.setFormatted.if):
(WebInspector.JavaScriptSource.prototype.setFormatted.didGetContent.didFormatContent):
(WebInspector.JavaScriptSource.prototype.setFormatted.didGetContent):
(WebInspector.JavaScriptSource.prototype.setFormatted):
(WebInspector.JavaScriptSource.prototype.togglingFormatter):
(WebInspector.JavaScriptSource.prototype.uiLocationToRawLocation):
(WebInspector.JavaScriptSource.prototype.overrideLocation):
(WebInspector.JavaScriptSource.prototype.breakpointStorageId):
(WebInspector):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype._onContentChanged):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointRemoved):

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.addScript):
(WebInspector.RawSourceCode.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.prototype._createUISourceCode):
(WebInspector.RawSourceCode.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.prototype.uiSourceCode):
(WebInspector.RawSourceCode.prototype._finishedLoading):

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype.addScript):
(WebInspector.ResourceScriptMapping.prototype._handleUISourceCodeChanged):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeChanged):

  • inspector/front-end/Script.js:

(WebInspector.Script.prototype.rawLocationToUILocation):

  • inspector/front-end/ScriptFormatter.js:

(WebInspector.ScriptFormatter.prototype._didFormatContent):
(WebInspector.FormatterSourceMapping):
(WebInspector.FormatterSourceMapping.prototype.originalToFormatted):
(WebInspector.FormatterSourceMapping.prototype.formattedToOriginal):
(WebInspector.IdentityFormatterSourceMapping):
(WebInspector.IdentityFormatterSourceMapping.prototype.originalToFormatted):
(WebInspector.IdentityFormatterSourceMapping.prototype.formattedToOriginal):
(WebInspector.FormatterSourceMappingImpl):
(WebInspector.FormatterSourceMappingImpl.prototype.originalToFormatted):
(WebInspector.FormatterSourceMappingImpl.prototype.formattedToOriginal):

  • inspector/front-end/ScriptMapping.js:

(WebInspector.MainScriptMapping):
(WebInspector.MainScriptMapping.prototype._handleUISourceCodeListChanged):
(WebInspector.MainScriptMapping.prototype.reset):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._handleUISourceCodeAdded):
(WebInspector.ScriptsPanel.prototype.showFunctionDefinition):
(WebInspector.ScriptsPanel.prototype._showFile):
(WebInspector.ScriptsPanel.prototype._revealExecutionLine):
(WebInspector.ScriptsPanel.prototype._toggleFormatSource):

  • inspector/front-end/ScriptsSearchScope.js:

(WebInspector.ScriptsSearchResultsPane.prototype.createAnchor):

  • inspector/front-end/SnippetsModel.js:

(WebInspector.SnippetsScriptMapping.prototype._snippetAdded):
(WebInspector.SnippetsScriptMapping.prototype._createUISourceCodeForScript):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.requestContent):
(WebInspector.UISourceCode.prototype.mimeType):
(WebInspector.UISourceCode.prototype.content):
(WebInspector.UISourceCode.prototype.fireContentAvailable):
(WebInspector.UISourceCode.prototype.contentLoaded):
(WebInspector.UISourceCode.prototype.uiLocationToRawLocation):

LayoutTests:

  • inspector/debugger/breakpoint-manager.html:
  • inspector/debugger/linkifier.html:
  • inspector/debugger/pause-in-inline-script.html:
  • inspector/debugger/raw-source-code-expected.txt:
  • inspector/debugger/raw-source-code.html:
  • inspector/debugger/resources/test-navigation.html: Removed.
  • inspector/debugger/script-formatter-breakpoints-expected.txt:
  • inspector/debugger/script-formatter-breakpoints.html:
  • inspector/debugger/script-formatter-console.html:
  • inspector/debugger/selected-call-frame-after-formatting-source.html:
8:51 AM Changeset in webkit [116774] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL][DRT] Input Attribute Placeholder RefTests failing
https://bugs.webkit.org/show_bug.cgi?id=85603

Unreviewed, build fix for EFL.

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-05-11

  • platform/efl/RenderThemeEfl.cpp:
8:51 AM Changeset in webkit [116773] by Darin Adler
  • 2 edits in trunk/Websites/webkit.org

Try to make spacing of fine print items in lower left nicer looking.

  • css/main.css:

(#notice, #trademark, #terms): Changed top margin to 10px.
(#notice): Put 30px margin here.

8:48 AM Changeset in webkit [116772] by Darin Adler
  • 2 edits in trunk/Websites/webkit.org

CSS tweak needed for the trademark terms of use.

  • css/main.css:

(#notice, #trademark, #terms): Added #trademark.

8:46 AM Changeset in webkit [116771] by commit-queue@webkit.org
  • 9 edits in trunk

Web Inspector: Remove support of combined nodes and edges serialization schema.
https://bugs.webkit.org/show_bug.cgi?id=86209

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-05-11
Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.get _nodes):
(WebInspector.HeapSnapshotNode.prototype._edgeIndexesStart):
(WebInspector.HeapSnapshotNode.prototype._edgeIndexesEnd):
(WebInspector.HeapSnapshot):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype._buildRetainers):
(WebInspector.HeapSnapshot.prototype._bfs):
(WebInspector.HeapSnapshot.prototype._buildAggregates):
(WebInspector.HeapSnapshot.prototype._calculateClassesRetainedSize):
(WebInspector.HeapSnapshot.prototype._buildDominatedNodes):

  • inspector/front-end/HeapSnapshotLoader.js:

(WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):

LayoutTests:

  • inspector/profiler/heap-snapshot-expected.txt:
  • inspector/profiler/heap-snapshot-loader-expected.txt:
  • inspector/profiler/heap-snapshot-loader.html:
  • inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockObject):
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockRaw):
(initialize_HeapSnapshotTest.InspectorTest._postprocessHeapSnapshotMock):
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockWithDOM):
(initialize_HeapSnapshotTest.):
(initialize_HeapSnapshotTest):

  • inspector/profiler/heap-snapshot.html:
8:40 AM Changeset in webkit [116770] by Darin Adler
  • 3 edits in trunk/Websites/webkit.org

Add a link to WebKit trademark terms of use, other small website changes
https://bugs.webkit.org/show_bug.cgi?id=86112

Reviewed by Dan Bernstein.

  • contact.html: Use RIGHT SINGLE QUOTATION MARK instead of APOSTROPHE as appropriate.

Fixed awkward use of the phrase "per itself" and the use of "intent" where "intend"
was intended.

  • nav.inc: Added mention of the WebKit trademark and a link to the trademark terms

of use on the macosforge.org terms of use page.

8:23 AM Changeset in webkit [116769] by Philippe Normand
  • 2 edits in trunk/Tools

Unreviewed, GTK 64-bit Debug bot fix attempt.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort._get_gdb_output): Ignore unicode decoding errors when
processing gdb output.

8:05 AM Changeset in webkit [116768] by yurys@chromium.org
  • 12 edits in trunk/Source/WebCore

Web Inspector: add Profiler.getHeapObjectId command
https://bugs.webkit.org/show_bug.cgi?id=86211

Reviewed by Pavel Feldman.

Added Profiler.getHeapObjectId command to the protocol which allows to convert remote
object id to heap snapshot object id.

  • bindings/js/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::getHeapObjectId):
(WebCore):

  • bindings/js/ScriptProfiler.h:

(WebCore):
(ScriptProfiler):

  • bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::getHeapObjectId):
(WebCore):

  • bindings/v8/ScriptProfiler.h:

(WebCore):
(ScriptProfiler):

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::findObjectById):
(WebCore):

  • inspector/InjectedScript.h:

(InjectedScript):

  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::getHeapObjectId):
(WebCore):

  • inspector/InspectorProfilerAgent.h:

(InspectorProfilerAgent):

7:11 AM Changeset in webkit [116767] by commit-queue@webkit.org
  • 6 edits
    3 adds in trunk/Source/WebCore

Qt support for new layout types.
https://bugs.webkit.org/show_bug.cgi?id=85607

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-11
Reviewed by Simon Hausmann.

Adds similar Qt support to FractionalLayout classes as Qt has for
FloatSomething and IntSomething classes. This means Qt code can stay
unchanged from after the redefinition of Layout classes.

No new functionality. No new tests.

  • Target.pri:
  • platform/FractionalLayoutUnit.h:

(WebCore::operator<<):
(WebCore::operator>>):

  • platform/graphics/FractionalLayoutPoint.h:

(FractionalLayoutPoint):

  • platform/graphics/FractionalLayoutRect.h:

(FractionalLayoutRect):

  • platform/graphics/FractionalLayoutSize.h:

(FractionalLayoutSize):

  • platform/graphics/qt/FractionalLayoutPointQt.cpp: Added.

(WebCore::FractionalLayoutPoint::FractionalLayoutPoint):
(WebCore::FractionalLayoutPoint::operator QPointF):

  • platform/graphics/qt/FractionalLayoutRectQt.cpp: Added.

(WebCore::FractionalLayoutRect::FractionalLayoutRect):
(WebCore::FractionalLayoutRect::operator QRectF):

  • platform/graphics/qt/FractionalLayoutSizeQt.cpp: Added.

(WebCore::FractionalLayoutSize::FractionalLayoutSize):
(WebCore::FractionalLayoutSize::operator QSizeF):

7:04 AM Changeset in webkit [116766] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Internals::touchPositionAdjustedToBestClickableNode adjust twice for scroll-offset
https://bugs.webkit.org/show_bug.cgi?id=86205

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-11
Reviewed by Simon Hausmann.

Source/WebCore:

Remove the redundant conversion from document to window coords.

Test: touchadjustment/scroll-offset.html

  • testing/Internals.cpp:

(WebCore::Internals::touchPositionAdjustedToBestClickableNode):
(WebCore::Internals::bestZoomableAreaForTouchPoint):

LayoutTests:

Add test of touchPositionAdjustedToBestClickableNode with scroll-offset.

  • touchadjustment/scroll-offset-expected.txt: Added.
  • touchadjustment/scroll-offset.html: Added.
6:55 AM Changeset in webkit [116765] by tkent@chromium.org
  • 3 edits
    3 deletes in trunk/LayoutTests

[Chromium] Updat test expectations.

  • platform/chromium-mac-leopard/fast/block/float/032-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/block/float/032-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/block/float/032-expected.png:
  • platform/chromium-mac-snowleopard/fast/block/float/032-expected.txt: Removed.
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
6:53 AM Changeset in webkit [116764] by loislo@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: load heap snapshot implementation.
https://bugs.webkit.org/show_bug.cgi?id=86097

The idea is to have a hidden file selector control.
When the user select a context menu item or click a button
we redirect this user-action to file selector.
As result we see the standard file selector dialog.
When the user selects a file we load it's chunks and push the chunks to the worker.
The loaded snapshot can be completely unrelated to the current page.
Thats why we have to skip range selection options in Summary tab.

Reviewed by Yury Semikhatsky.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/CSSSelectorProfileView.js:

(WebInspector.CSSSelectorProfileType.prototype.createTemporaryProfile): now it accepts a custom title.

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotView.prototype._updateFilterOptions): we have to skip the profiles loaded from file because there is no guaranty t
(WebInspector.HeapSnapshotProfileType.prototype.createTemporaryProfile): now it accepts a custom title.
(WebInspector.HeapSnapshotProfileType.prototype.createProfile): cosmetic changes.
(WebInspector.HeapProfileHeader):
(WebInspector.HeapProfileHeader.prototype._setupWorker): a common part was extracted from load method and reused in loadFromFile.
(WebInspector.HeapProfileHeader.prototype._saveStatusUpdate): cosmetic changes.
(WebInspector.HeapProfileHeader.prototype.finishHeapSnapshot):
(WebInspector.HeapProfileHeader.prototype.canSaveToFile): cosmetic rename for better consistency with 'load' part.
(WebInspector.HeapProfileHeader.prototype.saveToFile): cosmetic rename for better consistency with 'load' part.
(WebInspector.HeapProfileHeader.prototype.canLoadFromFile): cosmetic rename for better consistency with 'load' part.
(WebInspector.HeapProfileHeader.prototype.loadFromFile): chunk based file loader.
(WebInspector.HeapProfileHeader.prototype.loadFromFile.loadNextChunk):
(WebInspector.HeapProfileHeader.prototype.loadFromFile.onLoad):

  • inspector/front-end/ProfileView.js:

(WebInspector.CPUProfileType.prototype.createTemporaryProfile): now it accepts a custom title.

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfileType.prototype.createTemporaryProfile): now it accepts a custom title.
(WebInspector.ProfileHeader.prototype.canSaveToFile): cosmetic rename for better consistency with 'load' part.
(WebInspector.ProfileHeader.prototype.saveToFile): cosmetic rename for better consistency with 'load' part.
(WebInspector.ProfileHeader.prototype.canLoadFromFile): default implementation for 'load' part.
(WebInspector.ProfileHeader.prototype.loadFromFile): default implementation for 'load' part.
(WebInspector.ProfilesPanel.prototype._createFileSelectorElement):
(WebInspector.ProfilesPanel.prototype._loadFromFile):
(WebInspector.ProfileSidebarTreeElement.prototype.handleContextMenuEvent):

6:49 AM Changeset in webkit [116763] by commit-queue@webkit.org
  • 16 edits in trunk

Web Intents code only supports V8
https://bugs.webkit.org/show_bug.cgi?id=85954

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-11
Reviewed by Adam Barth.

.:

Add ENABLE_WEB_INTENTS flag to CMake.

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/WebCore:

Add necessary abstraction for js Dictionary and ScriptValue so that
the Web Intents code in WebCore compiles with JSC, not just V8.

This required changes in the JSC bindings generator to pass
callback arguments of type SerializedScriptValue as raw pointers
instead of RefPtr. This matches the change made to the V8 bindings
generator in r104531.

  • CMakeLists.txt:
  • Modules/intents/Intent.cpp:
  • Modules/intents/Intent.h:
  • bindings/js/Dictionary.cpp:

(WebCore::Dictionary::Dictionary):
(WebCore):
(WebCore::Dictionary::getOwnPropertiesAsStringHashMap):

  • bindings/js/Dictionary.h:

(Dictionary):

  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue):
(WebCore):

  • bindings/js/JSDictionary.h:

(WebCore):
(WebCore::JSDictionary::initializerObject):

  • bindings/js/ScriptValue.cpp:

(WebCore::ScriptValue::serialize):
(WebCore):

  • bindings/js/ScriptValue.h:

(ScriptValue):

  • bindings/scripts/CodeGeneratorJS.pm:

(AddIncludesForType):
(GenerateCallbackHeader):
(GenerateCallbackImplementation):
(GetNativeTypeForCallbacks):

6:42 AM Changeset in webkit [116762] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Can't type spaces in "Override User Agent" field
https://bugs.webkit.org/show_bug.cgi?id=86202

Reviewed by Yury Semikhatsky.

  • inspector/front-end/HelpScreen.js:

(WebInspector.HelpScreen.prototype.isClosingKey):
(WebInspector.HelpScreen.prototype._onKeyDown):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen.prototype.isClosingKey):

6:39 AM Changeset in webkit [116761] by commit-queue@webkit.org
  • 151 edits in trunk

[EFL][DRT] Input Attribute Placeholder RefTests failing
https://bugs.webkit.org/show_bug.cgi?id=85603

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-05-11
Reviewed by Hajime Morita.

Source/WebCore:

Refrain from overriding style coloring by theme coloring.
RenderThemeEfl was always overriding colors and whitespace
handling leading to failures in reftests that verify placeholder styling
which expect the user agent stylesheet to be applied correctly
without any color overrides. Also, leave whitespace handling untouched.

No new tests, covered by existing tests. See also
the LayoutTests/ChangeLog in this commit for the required
rebaselining.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::createEdje):
(WebCore::RenderThemeEfl::applyEdjeColors):
(WebCore::RenderThemeEfl::RenderThemeEfl):
(WebCore::RenderThemeEfl::adjustButtonStyle):
(WebCore::RenderThemeEfl::adjustMenuListStyle):
(WebCore::RenderThemeEfl::adjustTextFieldStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldStyle):

  • platform/efl/RenderThemeEfl.h:

(RenderThemeEfl):

Source/WebKit/efl:

Removing color classes which we don't need anymore after
RenderThemeEfl.cpp is less aggressively overriding styling.

  • DefaultTheme/default.edc:

LayoutTests:

Rebaselining after we're allowing color styling of menulists,
search and text fields and textareas and after removing
whitespace handling override.

  • platform/efl/Skipped:
  • platform/efl/css3/selectors3/html/css3-modsel-161-expected.txt:
  • platform/efl/css3/selectors3/xhtml/css3-modsel-161-expected.txt:
  • platform/efl/css3/selectors3/xml/css3-modsel-161-expected.txt:
  • platform/efl/editing/input/reveal-caret-of-multiline-input-expected.txt:
  • platform/efl/fast/block/float/float-avoidance-expected.txt:
  • platform/efl/fast/block/margin-collapse/103-expected.txt:
  • platform/efl/fast/css/continuationCrash-expected.txt:
  • platform/efl/fast/css/input-search-padding-expected.txt:
  • platform/efl/fast/css/line-height-expected.txt:
  • platform/efl/fast/css/margin-top-bottom-dynamic-expected.txt:
  • platform/efl/fast/css/rtl-ordering-expected.txt:
  • platform/efl/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/efl/fast/css/text-overflow-input-expected.txt:
  • platform/efl/fast/css/text-transform-select-expected.txt:
  • platform/efl/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
  • platform/efl/fast/dom/isindex-001-expected.txt:
  • platform/efl/fast/dom/isindex-002-expected.txt:
  • platform/efl/fast/dynamic/008-expected.txt:
  • platform/efl/fast/events/autoscroll-expected.txt:
  • platform/efl/fast/forms/003-expected.txt:
  • platform/efl/fast/forms/004-expected.txt:
  • platform/efl/fast/forms/HTMLOptionElement_label01-expected.txt:
  • platform/efl/fast/forms/HTMLOptionElement_label02-expected.txt:
  • platform/efl/fast/forms/HTMLOptionElement_label03-expected.txt:
  • platform/efl/fast/forms/HTMLOptionElement_label04-expected.txt:
  • platform/efl/fast/forms/HTMLOptionElement_label06-expected.txt:
  • platform/efl/fast/forms/HTMLOptionElement_label07-expected.txt:
  • platform/efl/fast/forms/basic-buttons-expected.txt:
  • platform/efl/fast/forms/basic-inputs-expected.txt:
  • platform/efl/fast/forms/blankbuttons-expected.txt:
  • platform/efl/fast/forms/box-shadow-override-expected.txt:
  • platform/efl/fast/forms/button-positioned-expected.txt:
  • platform/efl/fast/forms/button-sizes-expected.txt:
  • platform/efl/fast/forms/button-style-color-expected.txt:
  • platform/efl/fast/forms/button-table-styles-expected.txt:
  • platform/efl/fast/forms/button-text-transform-expected.txt:
  • platform/efl/fast/forms/control-clip-overflow-expected.txt:
  • platform/efl/fast/forms/control-restrict-line-height-expected.txt:
  • platform/efl/fast/forms/disabled-select-change-index-expected.txt:
  • platform/efl/fast/forms/encoding-test-expected.txt:
  • platform/efl/fast/forms/fieldset-align-expected.txt:
  • platform/efl/fast/forms/file/file-input-direction-expected.txt:
  • platform/efl/fast/forms/file/file-input-disabled-expected.txt:
  • platform/efl/fast/forms/floating-textfield-relayout-expected.txt:
  • platform/efl/fast/forms/formmove3-expected.txt:
  • platform/efl/fast/forms/input-align-expected.txt:
  • platform/efl/fast/forms/input-appearance-default-bkcolor-expected.txt:
  • platform/efl/fast/forms/input-appearance-focus-expected.txt:
  • platform/efl/fast/forms/input-appearance-height-expected.txt:
  • platform/efl/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/efl/fast/forms/input-appearance-selection-expected.txt:
  • platform/efl/fast/forms/input-appearance-visibility-expected.txt:
  • platform/efl/fast/forms/input-appearance-width-expected.txt:
  • platform/efl/fast/forms/input-button-sizes-expected.txt:
  • platform/efl/fast/forms/input-disabled-color-expected.txt:
  • platform/efl/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/efl/fast/forms/input-field-text-truncated-expected.txt:
  • platform/efl/fast/forms/input-readonly-dimmed-expected.txt:
  • platform/efl/fast/forms/input-readonly-empty-expected.txt:
  • platform/efl/fast/forms/input-spaces-expected.txt:
  • platform/efl/fast/forms/input-table-expected.txt:
  • platform/efl/fast/forms/input-text-click-inside-expected.txt:
  • platform/efl/fast/forms/input-text-option-delete-expected.txt:
  • platform/efl/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/efl/fast/forms/input-text-word-wrap-expected.txt:
  • platform/efl/fast/forms/input-type-text-min-width-expected.txt:
  • platform/efl/fast/forms/input-value-expected.txt:
  • platform/efl/fast/forms/input-width-expected.txt:
  • platform/efl/fast/forms/menulist-deselect-update-expected.txt:
  • platform/efl/fast/forms/menulist-narrow-width-expected.txt:
  • platform/efl/fast/forms/menulist-no-overflow-expected.txt:
  • platform/efl/fast/forms/menulist-restrict-line-height-expected.txt:
  • platform/efl/fast/forms/menulist-separator-painting-expected.txt:
  • platform/efl/fast/forms/menulist-style-color-expected.txt:
  • platform/efl/fast/forms/menulist-width-change-expected.txt:
  • platform/efl/fast/forms/minWidthPercent-expected.txt:
  • platform/efl/fast/forms/number/input-appearance-number-rtl-expected.txt:
  • platform/efl/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/efl/fast/forms/number/input-appearance-spinbutton-layer-expected.txt:
  • platform/efl/fast/forms/option-script-expected.txt:
  • platform/efl/fast/forms/option-strip-whitespace-expected.txt:
  • platform/efl/fast/forms/option-text-clip-expected.txt:
  • platform/efl/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/efl/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/efl/fast/forms/search-rtl-expected.txt:
  • platform/efl/fast/forms/searchfield-heights-expected.txt:
  • platform/efl/fast/forms/select-align-expected.txt:
  • platform/efl/fast/forms/select-background-none-expected.txt:
  • platform/efl/fast/forms/select-baseline-expected.txt:
  • platform/efl/fast/forms/select-change-listbox-to-popup-expected.txt:
  • platform/efl/fast/forms/select-dirty-parent-pref-widths-expected.txt:
  • platform/efl/fast/forms/select-initial-position-expected.txt:
  • platform/efl/fast/forms/select-selected-expected.txt:
  • platform/efl/fast/forms/select-size-expected.txt:
  • platform/efl/fast/forms/select-style-expected.txt:
  • platform/efl/fast/forms/select-visual-hebrew-expected.txt:
  • platform/efl/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/efl/fast/forms/selectlist-minsize-expected.txt:
  • platform/efl/fast/forms/stuff-on-my-optgroup-expected.txt:
  • platform/efl/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/efl/fast/forms/targeted-frame-submission-expected.txt:
  • platform/efl/fast/forms/text-style-color-expected.txt:
  • platform/efl/fast/forms/textAreaLineHeight-expected.txt:
  • platform/efl/fast/forms/textarea-align-expected.txt:
  • platform/efl/fast/forms/textarea-scroll-height-expected.txt:
  • platform/efl/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/efl/fast/forms/textarea-setinnerhtml-expected.txt:
  • platform/efl/fast/forms/textarea-width-expected.txt:
  • platform/efl/fast/forms/textfield-focus-ring-expected.txt:
  • platform/efl/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/efl/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/efl/fast/html/details-no-summary4-expected.txt:
  • platform/efl/fast/html/details-open-javascript-expected.txt:
  • platform/efl/fast/html/details-open2-expected.txt:
  • platform/efl/fast/html/details-open4-expected.txt:
  • platform/efl/fast/html/details-replace-summary-child-expected.txt:
  • platform/efl/fast/html/details-replace-text-expected.txt:
  • platform/efl/fast/html/keygen-expected.txt:
  • platform/efl/fast/invalid/014-expected.txt:
  • platform/efl/fast/lists/dynamic-marker-crash-expected.txt:
  • platform/efl/fast/overflow/overflow-x-y-expected.txt:
  • platform/efl/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
  • platform/efl/fast/overflow/scrollRevealButton-expected.txt:
  • platform/efl/fast/parser/document-write-option-expected.txt:
  • platform/efl/fast/parser/entity-comment-in-textarea-expected.txt:
  • platform/efl/fast/parser/open-comment-in-textarea-expected.txt:
  • platform/efl/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/efl/fast/repaint/search-field-cancel-expected.txt:
  • platform/efl/fast/repaint/subtree-root-skipped-expected.txt:
  • platform/efl/fast/replaced/replaced-breaking-expected.txt:
  • platform/efl/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/efl/fast/replaced/three-selects-break-expected.txt:
  • platform/efl/fast/replaced/width100percent-button-expected.txt:
  • platform/efl/fast/replaced/width100percent-menulist-expected.txt:
  • platform/efl/fast/replaced/width100percent-textarea-expected.txt:
  • platform/efl/fast/replaced/width100percent-textfield-expected.txt:
  • platform/efl/fast/table/003-expected.txt:
  • platform/efl/fast/table/colspanMinWidth-expected.txt:
  • platform/efl/fast/table/spanOverlapRepaint-expected.txt:
  • platform/efl/fast/table/text-field-baseline-expected.txt:
  • platform/efl/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/efl/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/efl/test_expectations.txt:
  • platform/efl/transforms/2d/zoom-menulist-expected.txt:
6:34 AM Changeset in webkit [116760] by kov@webkit.org
  • 8 edits in trunk

REGRESSION(r116205): [GTK]: build no longer supports thin archives
https://bugs.webkit.org/show_bug.cgi?id=86207

Source/WebCore:

  • GNUmakefile.am: go back to not linking libWebCoreModules into

libWebCore; when linking 2 convenience libraries libtools tries to
extract the object files from one of them to add to the other, breaking
thin archive builds

Source/WebKit/gtk:

  • GNUmakefile.am: link libWebCoreModules into the webkitgtk shared

library.

Source/WebKit2:

  • GNUmakefile.am: link libWebCoreModules to the webkit2gtk shared

library; tell the linker to ignore internal unresolved symbols for
PluginProcess and avoid linking libWebCoreModules.

Tools:

  • GNUmakefile.am: link libWebCoreModules to DRT.
6:33 AM SettingUpDevelopmentEnvironmentForN9 edited by zarvai@inf.u-szeged.hu
Qt5 r26+ configure -sysroot bug workaround (diff)
6:32 AM Changeset in webkit [116759] by Antti Koivisto
  • 2 edits in trunk/LayoutTests

Assertion failure in ietestcenter/css3/valuesandunits/units-000.htm
https://bugs.webkit.org/show_bug.cgi?id=86208

Not reviewed.

  • platform/mac/Skipped:
6:25 AM Changeset in webkit [116758] by commit-queue@webkit.org
  • 3 edits in trunk

[BlackBerry] Update DumpRenderTree.cpp to also run ref-tests if there're any
https://bugs.webkit.org/show_bug.cgi?id=86055

Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2012-05-11
Reviewed by Rob Buis.

Ref-tests are tests with suffix "-expected", "-expected-mismatch" and a valid
extension(".html", ".htm", etc.).
Currently torch-launcher only run tests parsed by NRWT, with ref-tests
excluded. As a result, if a test have ref-tests (which were not run), our
DumpRenderTree Perl script will think there's a crash and exit with code 1.
So NRWT will report the result as CRASH.
We need to update DumpRenderTree.cpp to try to find ref-tests and run them.

  • DumpRenderTree/blackberry/DumpRenderTree.cpp:

(BlackBerry::WebKit::DumpRenderTree::DumpRenderTree):
(BlackBerry::WebKit::DumpRenderTree::getRefTests):
(WebKit):
(BlackBerry::WebKit::DumpRenderTree::runCurrentTest):
(BlackBerry::WebKit::DumpRenderTree::runRemainingTests):
(BlackBerry::WebKit::DumpRenderTree::runTests):

  • DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:

(DumpRenderTree):

6:04 AM Changeset in webkit [116757] by keishi@webkit.org
  • 7 edits in trunk

Sanitization algorithm for input type=email should strip whitespaces
https://bugs.webkit.org/show_bug.cgi?id=86177

Reviewed by Kent Tamura.

Source/WebCore:

No new tests. Covered by: fast/forms/ValidityState-typeMismatch-email.html

The spec says that the value sanitization algorithm should

Strip line breaks from the value, then strip leading and trailing whitespace from the value.

  • html/EmailInputType.cpp:

(WebCore::EmailInputType::sanitizeValue):

LayoutTests:

  • fast/forms/ValidityState-typeMismatch-email-expected.txt:
  • fast/forms/input-value-sanitization-expected.txt:
  • fast/forms/input-value-sanitization.html:
  • fast/forms/resources/ValidityState-typeMismatch-email.js:
5:56 AM Changeset in webkit [116756] by commit-queue@webkit.org
  • 16 edits in trunk/Source/WebCore

Unreviewed, rolling out r116752.
http://trac.webkit.org/changeset/116752
https://bugs.webkit.org/show_bug.cgi?id=86201

Build failure on Chromium-mac (Requested by tkent on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-11

  • html/FormAssociatedElement.cpp:
  • html/FormAssociatedElement.h:

(FormAssociatedElement):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::setCustomValidity):

  • html/HTMLFormControlElement.h:

(HTMLFormControlElement):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::isValidValue):
(WebCore::HTMLInputElement::typeMismatch):
(WebCore::HTMLInputElement::valueMissing):
(WebCore::HTMLInputElement::patternMismatch):
(WebCore::HTMLInputElement::rangeUnderflow):
(WebCore::HTMLInputElement::rangeOverflow):
(WebCore::HTMLInputElement::minimum):
(WebCore::HTMLInputElement::maximum):
(WebCore::HTMLInputElement::stepMismatch):
(WebCore::HTMLInputElement::minimumString):
(WebCore::HTMLInputElement::maximumString):
(WebCore):
(WebCore::HTMLInputElement::stepBaseString):
(WebCore::HTMLInputElement::stepString):
(WebCore::HTMLInputElement::typeMismatchText):
(WebCore::HTMLInputElement::valueMissingText):
(WebCore::HTMLInputElement::isInRange):
(WebCore::HTMLInputElement::isOutOfRange):

  • html/HTMLInputElement.h:

(HTMLInputElement):

  • html/HTMLObjectElement.h:

(WebCore::HTMLObjectElement::setCustomValidity):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::valueMissing):

  • html/HTMLSelectElement.h:

(HTMLSelectElement):

  • html/HTMLTextAreaElement.cpp:
  • html/HTMLTextAreaElement.h:

(WebCore::HTMLTextAreaElement::valueMissing):
(HTMLTextAreaElement):

  • html/InputType.cpp:

(WebCore::InputType::alignValueForStep):
(WebCore::InputType::stepUpFromRenderer):

  • html/InputType.h:

(InputType):

  • html/ValidityState.cpp:

(WebCore::ValidityState::validationMessage):
(WebCore):
(WebCore::ValidityState::setCustomErrorMessage):
(WebCore::ValidityState::valueMissing):
(WebCore::ValidityState::typeMismatch):
(WebCore::ValidityState::patternMismatch):
(WebCore::ValidityState::tooLong):
(WebCore::ValidityState::rangeUnderflow):
(WebCore::ValidityState::rangeOverflow):
(WebCore::ValidityState::stepMismatch):
(WebCore::ValidityState::customError):
(WebCore::ValidityState::valid):

  • html/ValidityState.h:

(ValidityState):

5:47 AM Changeset in webkit [116755] by apavlov@chromium.org
  • 5 edits in trunk

Web Inspector: Search box doesn't allow CSS selectors anymore
https://bugs.webkit.org/show_bug.cgi?id=86196

Reviewed by Pavel Feldman.

Source/WebCore:

Refactoring in http://trac.webkit.org/changeset/99983 inadvertently removed the selector matching during
node search in the InspectorDOMAgent. This change re-introduces the Document::querySelectorAll() evaluation
for the user query.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::performSearch):

LayoutTests:

  • inspector/elements/elements-panel-search-expected.txt:
  • inspector/elements/elements-panel-search.html:
5:45 AM Changeset in webkit [116754] by inferno@chromium.org
  • 4 edits
    2 deletes in trunk

Unreviewed, rolling out r116527.
http://trac.webkit.org/changeset/116527
https://bugs.webkit.org/show_bug.cgi?id=86199

Causing crashes on ClusterFuzz (Requested by inferno-sec on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-11

Source/WebCore:

  • rendering/RenderScrollbar.cpp:

(WebCore::RenderScrollbar::updateScrollbarPart):

  • rendering/RenderScrollbarPart.h:

LayoutTests:

  • scrollbars/scrollbar-percent-padding-crash-expected.txt: Removed.
  • scrollbars/scrollbar-percent-padding-crash.html: Removed.
5:41 AM Changeset in webkit [116753] by tkent@chromium.org
  • 2 edits
    1 move
    2 deletes in trunk/LayoutTests

[Chromium] Update wrong expectations.

  • platform/chromium-linux-x86/fast/forms/date/date-appearance-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/date/date-appearance-expected.txt:
  • platform/chromium-mac-leopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt.
5:39 AM Changeset in webkit [116752] by commit-queue@webkit.org
  • 16 edits in trunk/Source/WebCore

[Forms] Move ValidityState methods implementation to another place
https://bugs.webkit.org/show_bug.cgi?id=86058

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-05-11
Reviewed by Kent Tamura.

This patch changes ValidityState class for limiting scope of
number/range input type related methods for introducing decimal
arithmetic.

Methods related to validation are moved from ValidateState to
input, select and textarea elements with virtual method based
dispatching via FormAssociateElement instead of tag name
dispatching so far for code simplification.

No new tests. This patch doesn't change behavior.

  • html/FormAssociatedElement.cpp:

(WebCore::FormAssociatedElement::customError): Added. Called from ValidateState. Returns custom error mssage in member variable.
(WebCore::FormAssociatedElement::patternMismatch): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::rangeOverflow): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::rangeUnderflow): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::stepMismatch): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::tooLong): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::typeMismatch): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::valid): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::valueMissing): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::customValidationMessage): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::validationMessage): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::setCustomValidity): Added. set custom error message.

  • html/FormAssociatedElement.h:

(FormAssociatedElement): Added new instance value m_customValidationMessage.

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::setCustomValidity): Changed. Calls base class setCustomValidity.

  • html/HTMLFormControlElement.h:

(HTMLFormControlElement):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::isValidValue): Call m_inputType methods instead of HTMLInputElement's.
(WebCore::HTMLInputElement::tooLong): Call m_inputType methods instead of HTMLInputElement's.
(WebCore):
(WebCore::HTMLInputElement::typeMismatch): Move implementation to InputType.
(WebCore::HTMLInputElement::valueMissing): Move implementation to InputType.
(WebCore::HTMLInputElement::patternMismatch): Move implementation to InputType.
(WebCore::HTMLInputElement::rangeUnderflow): Move implementation to InputType.
(WebCore::HTMLInputElement::rangeOverflow): Move implementation to InputType.
(WebCore::HTMLInputElement::validationMessage): Move implementation to InputType.
(WebCore::HTMLInputElement::stepMismatch): Move implementation to InputType.
(WebCore::HTMLInputElement::isInRange): Call m_inputType methods instead of HTMLInputElement's.
(WebCore::HTMLInputElement::isOutOfRange): Call m_inputType methods instead of HTMLInputElement's.

  • html/HTMLInputElement.h:

(HTMLInputElement): Make tooLong method private.

  • html/HTMLObjectElement.h: Add "virtual" and "OVERRIDE".
  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::validationMessage): Added. Implementation for HTMLSelectElement.
(WebCore::HTMLSelectElement::valueMissing): Added. Implementation for HTMLSelectElement.

  • html/HTMLSelectElement.h:

(HTMLSelectElement): Added entries for newly added methods.

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::validationMessage): Added. Implementation for HTMLTextAreaElement.
(WebCore::HTMLTextAreaElement::valueMissing): Added. Implementation for HTMLTextAreaElement.
(WebCore::HTMLTextAreaElement::tooLong): Added. Implementation for HTMLTextAreaElement.

  • html/HTMLTextAreaElement.h:

(HTMLTextAreaElement): Added entries for newly added methods. Change tooLong and valueMissing private.

  • html/InputType.cpp:

(WebCore::InputType::stepMismatch): Change method signature.
(WebCore::InputType::alignValueForStep): Changed for calling InputClass instead of HTMLINputElement.
(WebCore::InputType::stepUpFromRenderer): Added. Moved from HTMLInputElement.
(WebCore::InputType::validationMessage): Added. Moved from HTMLInputElement.

  • html/InputType.h:

(InputType): Added entries for newly added methods and update methods signature.

  • html/ValidityState.cpp: Move actual implementation to FormAssociatedElement and derived classes for localizing implementation change of elements and input types.

(WebCore::ValidityState::validationMessage): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::valueMissing): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::typeMismatch): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::patternMismatch): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::tooLong): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::rangeUnderflow): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::rangeOverflow): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::stepMismatch): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::customError): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::valid):

  • html/ValidityState.h:

(ValidityState): Remove custom validation message related things.

5:14 AM Changeset in webkit [116751] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix a build error without SVG, introduced by tab-size support.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

5:06 AM Changeset in webkit [116750] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][DRT] Gardening failure cases on EFL build bot
https://bugs.webkit.org/show_bug.cgi?id=86192

Unreviewed, EFL gardening.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-11

  • platform/efl/test_expectations.txt:
4:52 AM Changeset in webkit [116749] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening failure cases on editing/style and editing/pasteboard
https://bugs.webkit.org/show_bug.cgi?id=86184

Unreviewed EFL gardening.

Test expectations update.

Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-05-11

  • platform/efl/test_expectations.txt: adding tests regarding to missing beginDragWithFiles

execCommand('copy') and execCommand('paste') implementation.

4:43 AM Changeset in webkit [116748] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][DRT] fast/css/getComputedStyle/computed-style-without-renderer.html fails on EFL
https://bugs.webkit.org/show_bug.cgi?id=86190

Unreviewed, EFL rebaseline after r116723.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-11

  • platform/efl/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
4:23 AM Changeset in webkit [116747] by tkent@chromium.org
  • 32 edits
    1 copy
    4 moves
    7 adds
    12 deletes in trunk/LayoutTests

[Chromium] Rebaseline for some tests, and optimization.

  • fast/block/float/032-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/float/032-expected.txt.
  • fast/forms/input-appearance-bkcolor-expected.txt: Renamed from LayoutTests/platform/efl/fast/forms/input-appearance-bkcolor-expected.txt.
  • fast/images/color-jpeg-with-color-profile-expected.png: Renamed from LayoutTests/platform/efl/fast/images/color-jpeg-with-color-profile-expected.png.
  • platform/chromium-linux-x86/fast/forms/date/date-appearance-expected.txt: Added.
  • platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-leopard/fast/block/float/032-expected.png:
  • platform/chromium-mac-leopard/fast/block/float/032-expected.txt:
  • platform/chromium-mac-leopard/fast/css/getComputedStyle/computed-style-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt.
  • platform/chromium-mac-leopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-bkcolor-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/forms/text-style-color-expected.png:
  • platform/chromium-mac-leopard/fast/forms/text-style-color-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/images/color-jpeg-with-color-profile-expected.png:
  • platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug99948-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/text-style-color-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/text-style-color-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug99948-expected.png:
  • platform/chromium-mac/fast/block/float/032-expected.png:
  • platform/chromium-mac/fast/block/float/032-expected.txt: Removed.
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac/fast/forms/date/date-appearance-expected.png:
  • platform/chromium-mac/fast/forms/date/date-appearance-expected.txt:
  • platform/chromium-mac/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-bkcolor-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/text-style-color-expected.png:
  • platform/chromium-mac/fast/forms/text-style-color-expected.txt: Removed.
  • platform/chromium-mac/fast/images/color-jpeg-with-color-profile-expected.png:
  • platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug99948-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug99948-expected.txt: Removed.
  • platform/chromium-win-vista/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
  • platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-win/fast/block/float/032-expected.txt:
  • platform/chromium-win/fast/forms/date/date-appearance-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-bkcolor-expected.txt:
  • platform/chromium-win/fast/forms/text-style-color-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug99948-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/block/float/032-expected.txt: Removed.
  • platform/gtk/fast/forms/input-appearance-bkcolor-expected.txt: Removed.
  • platform/gtk/fast/images/color-jpeg-with-color-profile-expected.png: Removed.
  • platform/gtk/tables/mozilla/bugs/bug99948-expected.txt: Removed.
  • tables/mozilla/bugs/bug99948-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug99948-expected.txt.
4:11 AM SettingUpDevelopmentEnvironmentForN9 edited by zarvai@inf.u-szeged.hu
(diff)
4:10 AM SettingUpDevelopmentEnvironmentForN9 edited by zarvai@inf.u-szeged.hu
(diff)
3:36 AM Changeset in webkit [116746] by shinyak@chromium.org
  • 10 edits in trunk/Source/WebCore

[Refactoring] Move Selection from DOMWindow to TreeScope.
https://bugs.webkit.org/show_bug.cgi?id=82699

Reviewed by Ryosuke Niwa.

Since ShadowRoot will also manage its own version of DOMSelection, we would like to
share the code among Document and DOMSelection. This patch moves DOMSelection from DOMWindow to TreeScope
so that ShadowRoot can also use it.

No new tests, should covered by existing tests.

  • dom/Document.cpp:

(WebCore::Document::updateFocusAppearanceTimerFired):

  • dom/Document.h:

(Document):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::selection):

  • dom/TreeScope.cpp:

(WebCore::TreeScope::~TreeScope):
(WebCore::TreeScope::getSelection):
(WebCore):

  • dom/TreeScope.h:

(WebCore):
(TreeScope):

  • page/DOMSelection.cpp:

(WebCore::DOMSelection::DOMSelection):
(WebCore::DOMSelection::clearTreeScope):
(WebCore):

  • page/DOMSelection.h:

(WebCore):
(WebCore::DOMSelection::create):
(DOMSelection):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::clearDOMWindowProperties):
(WebCore::DOMWindow::getSelection):

  • page/DOMWindow.h:

(DOMWindow):

3:26 AM Changeset in webkit [116745] by morrita@google.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix attempt.

  • WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:

(WebKit::WebPopupMenu::setUpPlatformData):

2:55 AM Changeset in webkit [116744] by yurys@chromium.org
  • 23 edits in trunk/Source/WebCore

Web Inspector: console should allow JS execution in the context of an isolated world
https://bugs.webkit.org/show_bug.cgi?id=85612

Reviewed by Pavel Feldman.

Added an option to select not only a frame but also isolated world in which
to perform evaluation of the code typed into the console.

Each execution context can be identified using it injected script id. We call it
execution context id in the protocol. Runtime agent is extended with an event that
is sent when new ExecutionContext is created. The event tracking can be enabled/disabled
using setReportExecutionContextCreation command.

  • bindings/js/ScriptController.cpp:

(WebCore):
(WebCore::isolatedWorldToSecurityOriginMap):

  • bindings/js/ScriptController.h:

(ScriptController):

  • bindings/js/ScriptState.cpp:

(WebCore::isolatedWorldScriptState):
(WebCore):

  • bindings/js/ScriptState.h:

(WebCore):

  • bindings/v8/ScriptController.cpp:

(WebCore):
(WebCore::ScriptController::isolatedWorldToSecurityOriginMap):

  • bindings/v8/ScriptController.h:

(ScriptController):

  • bindings/v8/ScriptState.cpp:

(WebCore::isolatedWorldScriptState):
(WebCore):

  • bindings/v8/ScriptState.h:

(WebCore):

  • bindings/v8/V8IsolatedContext.cpp:

(WebCore::V8IsolatedContext::setSecurityOrigin):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::setIsolatedWorldSecurityOrigin):
(WebCore::V8Proxy::isolatedWorldContext):
(WebCore):
(WebCore::V8Proxy::isolatedWorldToSecurityOriginMap):

  • bindings/v8/V8Proxy.h:

(V8Proxy):

  • inspector/CodeGeneratorInspector.py:

(DomainNameFixes):

  • inspector/Inspector.json:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didCreateIsolatedContextImpl):
(WebCore):

  • inspector/InspectorInstrumentation.h:

(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCreateIsolatedContext):

  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::evaluate):

  • inspector/InspectorRuntimeAgent.h:

(InspectorRuntimeAgent):

  • inspector/InstrumentingAgents.h:

(WebCore):
(WebCore::InstrumentingAgents::InstrumentingAgents):
(WebCore::InstrumentingAgents::pageRuntimeAgent):
(WebCore::InstrumentingAgents::setPageRuntimeAgent):
(InstrumentingAgents):

  • inspector/PageRuntimeAgent.cpp:

(PageRuntimeAgentState):
(WebCore):
(WebCore::PageRuntimeAgent::PageRuntimeAgent):
(WebCore::PageRuntimeAgent::setFrontend):
(WebCore::PageRuntimeAgent::clearFrontend):
(WebCore::PageRuntimeAgent::restore):
(WebCore::PageRuntimeAgent::setReportExecutionContextCreation):
(WebCore::PageRuntimeAgent::didCreateExecutionContext):
(WebCore::PageRuntimeAgent::getScriptStateForEval):

  • inspector/PageRuntimeAgent.h:

(WebCore):
(PageRuntimeAgent):

  • inspector/WorkerRuntimeAgent.cpp:

(WebCore::WorkerRuntimeAgent::setReportExecutionContextCreation):
(WebCore::WorkerRuntimeAgent::getScriptStateForEval):

  • inspector/WorkerRuntimeAgent.h:

(WorkerRuntimeAgent):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype.get statusBarItems):
(WebInspector.ConsoleView.prototype.addContext):
(WebInspector.ConsoleView.prototype.removeContext):
(WebInspector.ConsoleView.prototype._updateIsolatedWorldSelector):
(WebInspector.ConsoleView.prototype._contextUpdated):
(WebInspector.ConsoleView.prototype._addedExecutionContext):
(WebInspector.ConsoleView.prototype._currentEvaluationContextId):
(WebInspector.ConsoleView.prototype._currentEvaluationContext):
(WebInspector.ConsoleView.prototype._currentIsolatedWorldId):
(WebInspector.ConsoleView.prototype.evalInInspectedWindow):

  • inspector/front-end/ExtensionPanel.js:

(WebInspector.ExtensionSidebarPane.prototype.setExpression):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):

  • inspector/front-end/JavaScriptContextManager.js:

(WebInspector.JavaScriptContextManager):
(WebInspector.JavaScriptContextManager.prototype._didLoadCachedResources):
(WebInspector.JavaScriptContextManager.prototype.isolatedContextCreated):
(WebInspector.RuntimeDispatcher):
(WebInspector.RuntimeDispatcher.prototype.isolatedContextCreated):
(WebInspector.ExecutionContext):
(WebInspector.ExecutionContext.comparator):
(WebInspector.FrameEvaluationContext):
(WebInspector.FrameEvaluationContext.prototype._frameNavigated):
(WebInspector.FrameEvaluationContext.prototype._addExecutionContext):
(WebInspector.FrameEvaluationContext.prototype._ensureMainWorldContextAdded):
(WebInspector.FrameEvaluationContext.prototype.isolatedContexts):

2:35 AM Changeset in webkit [116743] by caseq@chromium.org
  • 4 edits in trunk

Web Inspector: use div, not span as a parent element for ElementsTreeOutline in Audits panel
https://bugs.webkit.org/show_bug.cgi?id=86188

Reviewed by Yury Semikhatsky.

Source/WebCore:

We need to use <div>, not <span> as a container for ElementsTreeOutline, as latter accesses its parent offsetWidth
within _treeElementFromEvent(), which returns 0 for inline elements.

  • inspector/front-end/AuditFormatters.js:

(WebInspector.AuditFormatters.node.onNodeAvailable):
(WebInspector.AuditFormatters.node):

LayoutTests:

  • inspector/extensions/extensions-audits-expected.txt: rebaseline to account for extra <div>.
2:28 AM Changeset in webkit [116742] by Antti Koivisto
  • 6 edits in trunk/Source/WebCore

Inline Node::traverseNextNode
https://bugs.webkit.org/show_bug.cgi?id=85844

Reviewed by Ryosuke Niwa.

Inline traverseNextNode and traverseNextSibling to reduce entry/exit overhead and allow better code generation
for many hot loops.

In this version only the firstChild()/nextSibling() tests are inlined and the ancestor traversal is not.

Performance bots will tell if this was worthwhile.

  • dom/ContainerNode.h:

(WebCore::Node::traverseNextNode):
(WebCore):
(WebCore::Node::traverseNextSibling):

  • dom/Node.cpp:

(WebCore::Node::traverseNextAncestorSibling):

  • dom/Node.h:

(Node):

  • bindings/v8/RetainedDOMInfo.cpp:
2:05 AM Changeset in webkit [116741] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update

  • platform/chromium/test_expectations.txt:
1:42 AM Changeset in webkit [116740] by yurys@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: get rid of InspectorAgent::emitCommitLoadIfNeeded method
https://bugs.webkit.org/show_bug.cgi?id=85708

Reviewed by Pavel Feldman.

Instead of calling emitCommitLoadIfNeeded after all agents are restored
required actions are performed directly in the restore() methods.

  • inspector/InspectorAgent.cpp:
  • inspector/InspectorAgent.h:

(WebCore::InspectorAgent::didCommitLoadFired):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::restoreInspectorStateFromCookie):

  • inspector/InspectorDatabaseAgent.cpp:

(WebCore::InspectorDatabaseAgent::restore):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::create):
(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::restore):

  • inspector/InspectorPageAgent.h:

(WebCore):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::restore):

1:29 AM Changeset in webkit [116739] by caseq@chromium.org
  • 11 edits in trunk

Web Inspector: [Extensions API] add audit formatters for remote objects and DOM elements
https://bugs.webkit.org/show_bug.cgi?id=86108

Reviewed by Pavel Feldman.

Source/WebCore:

  • added two new formatters to AuditResults object of webInspector.audits API;
  • inspector/front-end/AuditFormatters.js:

(WebInspector.AuditFormatters.resourceLink):
(WebInspector.AuditFormatters.object.onEvaluate):
(WebInspector.AuditFormatters.object): format as a remote object property list;
(WebInspector.AuditFormatters.node.onNodeAvailable):
(WebInspector.AuditFormatters.node.onEvaluate):
(WebInspector.AuditFormatters.node): format as a DOM elements sub-tree;
(WebInspector.AuditFormatters.Utilities.evaluate): common expression evaluation logic for both new formatters;

  • inspector/front-end/ExtensionAPI.js:

(injectedExtensionAPI.AuditResultImpl):

  • inspector/front-end/auditsPanel.css:

(.audit-result-tree ol.outline-disclosure):
(.audit-result-tree .section .header):
(.audit-result-tree .section .header::before):

LayoutTests:

  • rebaselined tests to account for two new AuditResults method and their results;
  • inspector/extensions/extensions-audits-api-expected.txt:
  • inspector/extensions/extensions-audits-expected.txt:
  • inspector/extensions/extensions-audits-tests.js:

(initialize_ExtensionsAuditsTest.InspectorTest.startExtensionAudits.onAuditsDone):

  • inspector/extensions/extensions-audits.html:
1:14 AM Changeset in webkit [116738] by Carlos Garcia Campos
  • 9 edits
    2 adds in trunk/Source/WebKit2

[SOUP] Allow sending URI request data in chunks
https://bugs.webkit.org/show_bug.cgi?id=85880

Reviewed by Martin Robinson.

The API to handle custom URI schemes will receive an input stream
to read from. Current code requires to buffer the whole stream
before sending it to the WebProcess. This patch allows to send the
data in chunks while it's read from the stream.

  • GNUmakefile.list.am: Add new files to compilation
  • UIProcess/API/C/soup/WKSoupRequestManager.cpp:

(WKSoupRequestManagerRegisterURIScheme): Use toWTFString() to
convert from WKString to WTFString.
(WKSoupRequestManagerDidHandleURIRequest): Use didHandleURIRequest
as it has been renamed.
(WKSoupRequestManagerDidReceiveURIRequestData): New method to send
more data for the uri request to the web process.

  • UIProcess/API/C/soup/WKSoupRequestManager.h:
  • UIProcess/soup/WebSoupRequestManagerProxy.cpp:

(WebKit::WebSoupRequestManagerProxy::didHandleURIRequest):
HandleURIRequest has been renamed to DidHandleURIRequest.
(WebKit::WebSoupRequestManagerProxy::didReceiveURIRequestData):
Send DidReceiveURIRequestData message to the web process.
(WebKit::WebSoupRequestManagerProxy::didReceiveURIRequest): Use
didHandleURIRequest as it has been renamed.

  • UIProcess/soup/WebSoupRequestManagerProxy.h:

(WebSoupRequestManagerProxy):

  • WebProcess/soup/WebKitSoupRequestInputStream.cpp: Added.

(AsyncReadData::AsyncReadData): Helper struct to store information
about pending async read operations.
(_WebKitSoupRequestInputStreamPrivate):
(webkitSoupRequestInputStreamReadAsyncResultComplete): Read the
data from the memory input stream and complete the async read
operation.
(webkitSoupRequestInputStreamReadAsync): Read the data from the
memory input stream and complete the async read operation if
there's data to read, or save the async result to be completed
when more data is added to the stream.
(webkitSoupRequestInputStreamReadFinish): Finish an async read
started with webkitSoupRequestInputStreamReadAsync.
(webkitSoupRequestInputStreamFinalize):
(webkit_soup_request_input_stream_init):
(webkit_soup_request_input_stream_class_init):
(webkitSoupRequestInputStreamNew): Create a new input stream with
a fixed size or 0 if content length is not known.
(webkitSoupRequestInputStreamAddData): Add more data to the
stream and complete any pending async read.
(webkitSoupRequestInputStreamFinished): Whether all data expected
by the stream has been received.

  • WebProcess/soup/WebKitSoupRequestInputStream.h: Added.
  • WebProcess/soup/WebSoupRequestManager.cpp:

(WebKit::WebSoupRequestManager::didHandleURIRequest): Create a
WebKitSoupRequestInputStream if we haven't received all the
request data in the HandleURIRequest message. Otherwise just
create a memory input stream with all the data.
(WebKit::WebSoupRequestManager::didReceiveURIRequestData): Add the data
received to the WebKitSoupRequestInputStream associated to the
given request identifier.

  • WebProcess/soup/WebSoupRequestManager.h:
  • WebProcess/soup/WebSoupRequestManager.messages.in: Add

contentLength parameter to DidHandleURIRequest message and add
DidReceiveURIRequestData message.

12:53 AM Changeset in webkit [116737] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, skip a new failing test.

  • platform/qt/Skipped:
12:33 AM Changeset in webkit [116736] by commit-queue@webkit.org
  • 9 edits in trunk/Source

Unreviewed, rolling out r116727.
http://trac.webkit.org/changeset/116727
https://bugs.webkit.org/show_bug.cgi?id=86181

Build error on Chromium-Android (Requested by tkent on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-11

Source/WebCore:

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::enterFullscreen):
(WebCore):

  • platform/graphics/MediaPlayer.h:

(MediaPlayer):

  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::enterFullscreen):
(MediaPlayerPrivateInterface):

Source/WebKit/chromium:

  • public/WebMediaPlayer.h:

(WebMediaPlayer):
(WebKit::WebMediaPlayer::enterFullscreen):
(WebKit::WebMediaPlayer::exitFullscreen):

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::enterFullscreen):
(WebKit::WebMediaPlayerClientImpl::exitFullscreen):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::enterFullScreenForElement):

12:16 AM Changeset in webkit [116735] by morrita@google.com
  • 4 edits in trunk/LayoutTests

Unreviewed expectation update.

  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/svg/css/getComputedStyle-basic-expected.txt:
12:11 AM Changeset in webkit [116734] by Csaba Osztrogonác
  • 5 edits in trunk/LayoutTests

Unreviewed gardening.

  • fast/css/getComputedStyle/computed-style-expected.txt: Updated after r116723.
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Updated after r116723.
  • platform/qt/Skipped: Skip new crashing and failing tests.
  • platform/qt/svg/css/getComputedStyle-basic-expected.txt: Updated after r116723.
12:00 AM Changeset in webkit [116733] by commit-queue@webkit.org
  • 10 edits in trunk/Source

Unreviewed, rolling out r116731.
http://trac.webkit.org/changeset/116731
https://bugs.webkit.org/show_bug.cgi?id=86178

Build failure on Chromium-mac (Requested by tkent on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-11

Source/WebCore:

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::initializeSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(UnthrottledTextureUploader):
(WebCore::UnthrottledTextureUploader::create):
(WebCore::UnthrottledTextureUploader::~UnthrottledTextureUploader):
(WebCore::UnthrottledTextureUploader::isBusy):
(WebCore::UnthrottledTextureUploader::beginUploads):
(WebCore::UnthrottledTextureUploader::endUploads):
(WebCore::UnthrottledTextureUploader::uploadTexture):
(WebCore::UnthrottledTextureUploader::UnthrottledTextureUploader):
(WebCore):
(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::recreateContext):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore):
(UnthrottledTextureUploader):
(WebCore::UnthrottledTextureUploader::create):
(WebCore::UnthrottledTextureUploader::~UnthrottledTextureUploader):
(WebCore::UnthrottledTextureUploader::isBusy):
(WebCore::UnthrottledTextureUploader::beginUploads):
(WebCore::UnthrottledTextureUploader::endUploads):
(WebCore::UnthrottledTextureUploader::uploadTexture):
(WebCore::UnthrottledTextureUploader::UnthrottledTextureUploader):
(WebCore::CCThreadProxy::initializeLayerRendererOnImplThread):
(WebCore::CCThreadProxy::recreateContextOnImplThread):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKitTests::CCLayerTreeHostImplTest::CCLayerTreeHostImplTest):
(WebKitTests::TEST_F):

  • tests/LayerRendererChromiumTest.cpp:

(FakeLayerRendererChromium::FakeLayerRendererChromium):
(LayerRendererChromiumTest::LayerRendererChromiumTest):
(TEST):

May 10, 2012:

11:56 PM Changeset in webkit [116732] by ojan@chromium.org
  • 9 edits
    3 adds in trunk/Tools

Add a perf tab to garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=86169

Reviewed by Dimitri Glazkov.

This is a first stab at making it easier to view the Chromium WebKit canary
perf graphs. For now, it's just a couple select elements and an iframe.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf_unittests.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/perf.css: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
11:33 PM Changeset in webkit [116731] by commit-queue@webkit.org
  • 10 edits in trunk/Source

[Chromium] Move instantiation of texture uploader to LayerRendererChromium.
https://bugs.webkit.org/show_bug.cgi?id=85893

Patch by David Reveman <reveman@chromium.org> on 2012-05-10
Reviewed by Adrienne Walker.

Source/WebCore:

Move instantiation of texture uploader to LayerRendererChromium and
allow CCProxy to decide between a throttled or unthrottled uploader
using a flag passed to the LayerRendererChromium constructor.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::initializeSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::recreateContext):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::initializeLayerRendererOnImplThread):
(WebCore::CCThreadProxy::recreateContextOnImplThread):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKitTests::CCLayerTreeHostImplTest::CCLayerTreeHostImplTest):
(WebKitTests::TEST_F):

  • tests/LayerRendererChromiumTest.cpp:

(FakeLayerRendererChromium::FakeLayerRendererChromium):
(LayerRendererChromiumTest::LayerRendererChromiumTest):
(TEST):

10:35 PM Changeset in webkit [116730] by morrita@google.com
  • 48 edits in trunk

ElementShadow should minimize the usage of "ShadowRoot" name
https://bugs.webkit.org/show_bug.cgi?id=85970

Reviewed by Dimitri Glazkov.

.:

Removed symbols which no longer exists

  • Source/autotools/symbols.filter:

Source/WebCore:

This change cleans two out dated assumptions which brought in at
early stage of Shadow DOM implementation.

  • Removed Element::hasShadowRoot(): shadow existence can be checked by Element::shadow().
  • Made ElementShadow::removeAllShadowRoots() private: we no longer allow ShadowRoot removal. It can only happens at the ElementShadow destruction.

Most of changes in element implementations are basically simple
replacement from hasShadowRoot() to shadow().

No new tests. Covered by existing tests.

  • WebCore.exp.in:
  • dom/ContainerNodeAlgorithms.h:

(WebCore::ChildFrameDisconnector::collectDescendant):

  • dom/ComposedShadowTreeWalker.cpp:

(WebCore::ComposedShadowTreeWalker::traverseChild):

  • dom/Document.cpp:

(WebCore::Document::buildAccessKeyMap):

  • dom/Element.cpp:

(WebCore::Element::recalcStyle):
(WebCore::Element::ensureShadowRoot):
(WebCore::Element::childrenChanged):

  • dom/Element.h:

(Element):
(WebCore::isShadowHost):
(WebCore):

  • dom/ElementShadow.cpp:

(WebCore::ElementShadow::~ElementShadow):
(WebCore::ElementShadow::removeAllShadowRoots):

  • dom/ElementShadow.h:

(ElementShadow):
(WebCore::ElementShadow::host):

  • dom/EventDispatcher.cpp:
  • dom/Node.cpp:

(WebCore::oldestShadowRootFor):

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::create):

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::createShadowSubtree):

  • html/FileInputType.cpp:

(WebCore::FileInputType::createShadowSubtree):
(WebCore::FileInputType::multipleAttributeChanged):

  • html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::createShadowSubtree):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::createShadowSubtree):

  • html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::HTMLKeygenElement):
(WebCore::HTMLKeygenElement::shadowSelect):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::hasMediaControls):

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::createShadowSubtree):

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::createShadowSubtree):

  • html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::createShadowSubtree):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::createShadowSubtree):

  • html/InputType.cpp:

(WebCore::InputType::destroyShadowSubtree):

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::handleMouseDownEvent):
(WebCore::RangeInputType::createShadowSubtree):

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::createShadowSubtree):

  • html/shadow/SliderThumbElement.cpp:

(WebCore::trackLimiterElementOf):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::unbind):
(WebCore::InspectorDOMAgent::buildObjectForNode):

  • page/FocusController.cpp:

(WebCore):

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::uploadButton):

  • svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::updateReferencedText):
(WebCore::SVGTRefElement::detachTarget):

  • testing/Internals.cpp:

(WebCore::Internals::ensureShadowRoot):
(WebCore::Internals::youngestShadowRoot):
(WebCore::Internals::oldestShadowRoot):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit2:

Removed symbols which no longer exists

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

Removed tests cases which exercise shadow root removals.
Such functionality was only available from Internals object
and it made little sense to test it.

  • fast/dom/shadow/content-element-move-expected.txt:
  • fast/dom/shadow/content-element-move.html:
  • fast/dom/shadow/dynamically-created-shadow-root-expected.html:
  • fast/dom/shadow/dynamically-created-shadow-root.html:
  • fast/dom/shadow/layout-tests-can-access-shadow-expected.txt:
  • fast/dom/shadow/layout-tests-can-access-shadow.html:
  • fast/dom/shadow/multiple-shadowroot-expected.txt:
  • fast/dom/shadow/multiple-shadowroot.html:
10:31 PM Changeset in webkit [116729] by gyuyoung.kim@samsung.com
  • 46 edits in trunk

Move resumeAnimations to use Internals interface
https://bugs.webkit.org/show_bug.cgi?id=86063

Reviewed by Alexey Proskuryakov.

.:

  • Source/autotools/symbols.filter: Add a symbol filter for resumeAnimations.

Source/WebCore:

Add resumeAnimations functions, because it is able to work in the
cross-port way through the Internals interface.

No new tests, since we are improving here the infra-structure for testing
a specific method.

  • testing/Internals.cpp:

(WebCore::Internals::resumeAnimations):
(WebCore):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit/efl:

Remove resumeAnimations functions, because it is able to work in the
cross-port way through the Internals interface.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Source/WebKit/gtk:

Remove resumeAnimations functions, because it is able to work in the
cross-port way through the Internals interface.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Source/WebKit/mac:

Remove resumeAnimations functions, because it is able to work in the
cross-port way through the Internals interface.

  • WebKit.order:
  • WebView/WebFrame.mm:
  • WebView/WebFramePrivate.h:

Source/WebKit/qt:

Remove resumeAnimations functions, because it is able to work in the
cross-port way through the Internals interface.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Source/WebKit/win:

Remove resumeAnimations functions, because it is able to work in the
cross-port way through the Internals interface.

  • Interfaces/IWebFramePrivate.idl:
  • WebFrame.cpp:
  • WebFrame.h:

Source/WebKit2:

  • win/WebKit2.def: Add a symbol filter for resumeAnimations.

Tools:

Remove resumeAnimations functions, because it is able to work in the
cross-port way through the Internals interface.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  • DumpRenderTree/qt/LayoutTestControllerQt.h:

(LayoutTestController):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(LayoutTestController):

LayoutTests:

Call resumeAnimations functions from internals, because it is able to work in the
cross-port way through the Internals interface.

  • animations/play-state-suspend.html:
  • animations/stop-animation-on-suspend.html:
  • animations/suspend-resume-animation-events.html:
  • animations/suspend-resume-animation.html:
9:51 PM Changeset in webkit [116728] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update

  • platform/chromium/test_expectations.txt:
9:27 PM Changeset in webkit [116727] by commit-queue@webkit.org
  • 9 edits in trunk/Source

split MediaPlayer::enterFullscreen into 2 seperate functions
https://bugs.webkit.org/show_bug.cgi?id=86052

Patch by Min Qin <qinmin@google.com> on 2012-05-10
Reviewed by Benjamin Poulain.

Source/WebCore:

It is confusing that enterFullscreen returns a boolean while exitFullscreen does
not do the same. And ios does not need the return value.
So remove the return value on enterFullscreen and make a seperate canEnterFullscreen()
function for android.
No tests as there are no behavior change, just refactoring.

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::enterFullscreen):
(WebCore):
(WebCore::MediaPlayer::canEnterFullscreen):

  • platform/graphics/MediaPlayer.h:

(MediaPlayer):

  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::enterFullscreen):
(MediaPlayerPrivateInterface):
(WebCore::MediaPlayerPrivateInterface::canEnterFullscreen):

Source/WebKit/chromium:

It is confusing that enterFullscreen returns a boolean while exitFullscreen does
not do the same. And ios does not need the return value.
So remove the return value on enterFullscreen and make a seperate canEnterFullscreen()
function for android.
No behavior change, just refactoring.

  • public/WebMediaPlayer.h:

(WebMediaPlayer):
(WebKit::WebMediaPlayer::enterFullscreen):
(WebKit::WebMediaPlayer::canEnterFullscreen):

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::enterFullscreen):
(WebKit):
(WebKit::WebMediaPlayerClientImpl::exitFullscreen):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::enterFullScreenForElement):

9:16 PM Changeset in webkit [116726] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL][DRT] Editor doesn't cancel composition as change of value
https://bugs.webkit.org/show_bug.cgi?id=85122

Patch by Kangil Han <kangil.han@samsung.com> on 2012-05-10
Reviewed by Martin Robinson.

IME composition should be cancelled when the value of input element is changed programmatically.
However, EFL port doesn't cancel as change of value.
Therefore, this patch will fix the bug.

Source/WebKit/efl:

  • WebCoreSupport/EditorClientEfl.cpp:

(WebCore::EditorClientEfl::respondToChangedSelection):

LayoutTests:

  • platform/efl/Skipped:
9:14 PM Changeset in webkit [116725] by noel.gordon@gmail.com
  • 3 edits
    7 adds in trunk/LayoutTests

[chromium] Rebaseline compositing/geometry/horizontal-scroll-composited.html after r107389

Unreviewed test expectations update.

  • platform/chromium-linux-x86/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
  • platform/chromium-linux/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
  • platform/chromium-mac/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-win-xp/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
  • platform/chromium/test_expectations.txt:
9:00 PM Changeset in webkit [116724] by tkent@chromium.org
  • 10 edits in trunk/Source/WebCore

Unreviewed, rolling out r116715.
http://trac.webkit.org/changeset/116715
https://bugs.webkit.org/show_bug.cgi?id=86172

Broke http/tests/security/cross-frame-access-selection.html
(Requested by tkent on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-10

  • dom/Document.cpp:

(WebCore):
(WebCore::Document::getSelection):

  • dom/Document.h:

(Document):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::selection):

  • dom/TreeScope.cpp:

(WebCore::TreeScope::~TreeScope):

  • dom/TreeScope.h:

(WebCore):
(TreeScope):

  • page/DOMSelection.cpp:

(WebCore::DOMSelection::DOMSelection):

  • page/DOMSelection.h:

(WebCore):
(WebCore::DOMSelection::create):
(DOMSelection):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::clearDOMWindowProperties):
(WebCore::DOMWindow::getSelection):

  • page/DOMWindow.h:

(DOMWindow):

8:28 PM Changeset in webkit [116723] by morrita@google.com
  • 32 edits
    2 adds in trunk

WebKit should support tab-size.
https://bugs.webkit.org/show_bug.cgi?id=52994

Source/WebCore:

  • Added boilerplate for "tab-size" CSS property.
  • Added RenderStye::tabSize() as a RareInheritedData.
  • Replaced TextRun::m_allowTabs into TextRun::m_tabSize.

Reviewed by Simon Fraser.

Tests: fast/css/tab-size-expected.html

fast/css/tab-size.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawTextInternal):

  • platform/chromium/PopupListBox.cpp:

(WebCore::PopupListBox::paintRow):

  • platform/graphics/Font.h:

(WebCore::Font::tabWidth):

  • platform/graphics/TextRun.h:

(WebCore::TextRun::TextRun):
(WebCore::TextRun::allowTabs):
(WebCore::TextRun::tabSize):
(WebCore::TextRun::setTabSize):

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::advance):

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::paint):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::constructTextRun):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::constructTextRun):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::textWidth):
(WebCore::tryHyphenating):

  • rendering/RenderText.cpp:

(WebCore::RenderText::widthFromCache):
(WebCore::RenderText::computePreferredLogicalWidths):
(WebCore::RenderText::width):

  • rendering/RenderText.h:
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyleBitfields::tabSize):
(WebCore::RenderStyleBitfields::collapsedTabSize):
(WebCore::RenderStyleBitfields::setTabSize):
(WebCore::RenderStyleBitfields::initialTabSize):

  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h:
  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::constructTextRun):

  • rendering/svg/SVGTextMetrics.cpp:

(WebCore::constructTextRun):

Source/WebKit/chromium:

Reviewed by Simon Fraser.

  • src/WebTextRun.cpp:

(WebKit::WebTextRun::operator WebCore::TextRun):

LayoutTests:

Reviewed by Simon Fraser.

  • fast/css/tab-size-expected.html: Added.
  • fast/css/tab-size.html: Added.
  • platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
8:07 PM Changeset in webkit [116722] by piman@chromium.org
  • 5 edits
    1 add in trunk/Source

Sync with impl thread when removing references to external textures
https://bugs.webkit.org/show_bug.cgi?id=86054

We want to ensure the client side is safe to release textures, so we
sync with the impl thread when:

  • we change the texture (and we had one)
  • the layer is removed from the tree (and we had a texture)
  • the layer is destroyed (and we had a texture)

Reviewed by James Robinson.

Test: TextureLayerChromiumTest.

  • platform/graphics/chromium/TextureLayerChromium.cpp:

(WebCore::TextureLayerChromium::~TextureLayerChromium):
(WebCore::TextureLayerChromium::setTextureId):
(WebCore::TextureLayerChromium::setLayerTreeHost):
(WebCore):

  • platform/graphics/chromium/TextureLayerChromium.h:

(TextureLayerChromium):

7:47 PM Changeset in webkit [116721] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] attempt to build fix for Chromium-mac.
r116697 introduced an override of a system function. It's intentional
and WebCoreTextFieldCell should be in the whitelist.

  • WebCore.gyp/WebCore.gyp:
7:34 PM Changeset in webkit [116720] by andersca@apple.com
  • 20 edits in trunk/Source

PDF files won't scroll in Safari when using Adobe plug-in
https://bugs.webkit.org/show_bug.cgi?id=86167
<rdar://problem/11389719>

Reviewed by Sam Weinig.

Source/WebCore:

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::computeNonFastScrollableRegion):
Loop over the frame view children looking for plug-in views that want wheel events
and add them to the non-fast scrollable region. Ideally, the plug-ins should be added
to the set of scrollable areas, but PluginView in WebKit2 is not a ScrollableArea yet.

  • plugins/PluginViewBase.h:

(PluginViewBase):
(WebCore::PluginViewBase::wantsWheelEvents):

Source/WebKit2:

Add a way to whitelist plug-ins that we know will process wheel events correctly. Add the new
Adobe Reader plug-in to this whitelist. Only send wheel events to plug-ins that are in the whitelist.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::wantsWheelEvents):
(WebKit):

  • PluginProcess/PluginControllerProxy.h:

(PluginControllerProxy):

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::createPlugin):

  • PluginProcess/WebProcessConnection.h:

(WebProcessConnection):

  • PluginProcess/WebProcessConnection.messages.in:
  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:

(WebKit::NetscapePluginModule::determineQuirks):

  • Shared/Plugins/PluginQuirks.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::wantsWheelEvents):
(WebKit):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

(NetscapePlugin):

  • WebProcess/Plugins/PDF/BuiltInPDFView.h:

(BuiltInPDFView):

  • WebProcess/Plugins/PDF/BuiltInPDFView.mm:

(WebKit::BuiltInPDFView::wantsWheelEvents):
(WebKit):

  • WebProcess/Plugins/Plugin.h:

(Plugin):

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::PluginProxy):
(WebKit::PluginProxy::initialize):
(WebKit::PluginProxy::wantsWheelEvents):
(WebKit):

  • WebProcess/Plugins/PluginProxy.h:

(PluginProxy):

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::initializePlugin):
(WebKit::PluginView::wantsWheelEvents):
(WebKit):
(WebKit::PluginView::handleEvent):

  • WebProcess/Plugins/PluginView.h:

(PluginView):

7:31 PM Changeset in webkit [116719] by ap@apple.com
  • 13 edits
    2 adds in trunk

Crash in 3rd party WebKit apps that disable cache at a wrong time
https://bugs.webkit.org/show_bug.cgi?id=86027
<rdar://problem/10615880>

Reviewed by Antti Koivisto.

Source/WebCore:

Added an API test.

The fix is to use CachedResourceHandle throughout MemoryCache, which will certainly
keep the resource alive. Also removed earlier fixes.

  • css/CSSImageSetValue.cpp: (WebCore::CSSImageSetValue::cachedImageSet):
  • css/CSSImageValue.cpp: (WebCore::CSSImageValue::cachedImage):
  • css/WebKitCSSShaderValue.cpp: (WebCore::WebKitCSSShaderValue::cachedShader):
  • history/PageCache.cpp: (WebCore::PageCache::releaseAutoreleasedPagesNow):
  • loader/ImageLoader.cpp: (WebCore::ImageLoader::updateFromElement):
  • loader/TextTrackLoader.cpp: (WebCore::TextTrackLoader::load):
  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::requestFont):
(WebCore::CachedResourceLoader::requestTextTrack):
(WebCore::CachedResourceLoader::requestShader):
(WebCore::CachedResourceLoader::requestCSSStyleSheet):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestScript):
(WebCore::CachedResourceLoader::requestXSLStyleSheet):
(WebCore::CachedResourceLoader::requestSVGDocument):
(WebCore::CachedResourceLoader::requestLinkResource):
(WebCore::CachedResourceLoader::requestRawResource):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadResource):
(WebCore::CachedResourceLoader::requestPreload):

  • loader/cache/CachedResourceLoader.h: (CachedResourceLoader):
  • loader/cache/MemoryCache.h: (WebCore::MemoryCache::setPruneEnabled):
  • loader/cache/CachedResourceHandle.h:

(WebCore::CachedResourceHandle::CachedResourceHandle):
(WebCore::CachedResourceHandle::operator=):
Teach CachedResourceHandle how to make CachedResourceHandle<CachedResource> from
a handle to subclass.

Tools:

Added a test that's very similar to MemoryCachePruneWithinResourceLoadDelegate,
but for disabling the cache instead of triggering a prune.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.html: Added.
  • TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.mm: Added.

(-[MemoryCacheDisableTestResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
(-[MemoryCacheDisableTestResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
(-[MemoryCacheDisableTestResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
(-[MemoryCacheDisableTestResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
(TestWebKitAPI::TEST):

7:21 PM Acronyms edited by yosin@chromium.org
Add link to EWS queue status page (diff)
7:08 PM Changeset in webkit [116718] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Eliminate duplicated code for culled line box in RenderInline
https://bugs.webkit.org/show_bug.cgi?id=85725

This patch extracts the common part of culledInlineBoundingBox() /
culledInlineAbsoluteRects() / culledInlineAbsoluteQuads() to become a
template function generateCulledLineBoxRects(). The template function
accepts a new parameter, GeneratorContext functor, which will be
invoked everytime a new line box rect has been generated. The generated
rect will be in local coordinate. The functor will be responsible for
appropriate transformation, then appending to vector or union with
existing bounding box.

Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-05-10
Reviewed by Eric Seidel.

No new tests. No change in behavior.

  • rendering/RenderInline.cpp:

(WebCore):
(WebCore::RenderInline::generateLineBoxRects):
(WebCore::RenderInline::generateCulledLineBoxRects):
(WebCore::RenderInline::absoluteRects):
(WebCore::RenderInline::absoluteQuads):
(WebCore::RenderInline::linesBoundingBox):
(WebCore::RenderInline::culledInlineVisualOverflowBoundingBox):
(WebCore::RenderInline::addFocusRingRects):

  • rendering/RenderInline.h:

(RenderInline):

7:06 PM Changeset in webkit [116717] by inferno@chromium.org
  • 2 edits in trunk/Source/WebCore

Crash in swapInNodePreservingAttributesAndChildren.
https://bugs.webkit.org/show_bug.cgi?id=85197

Reviewed by Ryosuke Niwa.

Keep the children in a ref vector before adding them to newNode.
They can get destroyed due to mutation events.

No new tests because we don't have a reduction.

  • editing/ReplaceNodeWithSpanCommand.cpp:

(WebCore::swapInNodePreservingAttributesAndChildren):

6:49 PM Changeset in webkit [116716] by andersca@apple.com
  • 25 edits in trunk

WebKit2: Add a way to blacklist specific plug-ins/plug-in versions
https://bugs.webkit.org/show_bug.cgi?id=86164
<rdar://problem/9551196>

Reviewed by Sam Weinig.

Source/WebKit2:

  • Shared/API/c/WKError.h:

Add kWKErrorCodeInsecurePlugInVersion error code.

  • Shared/APIClientTraits.cpp:

Update now that didFailToInitializePlugin is deprecated.

  • UIProcess/API/C/WKPage.h:

Deprecate didFailToInitializePlugin and replace it with the more generic pluginDidFail.
Also, deprecate missingPluginButtonClicked and replace it with unavailablePluginButtonClicked.

  • UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::PluginInfoStore::shouldBlockPlugin):
Non-Mac version, always return false.

  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::PluginInfoStore::shouldBlockPlugin):
Call WKShouldBlockPlugin.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::getPluginPath):
Check if the plug-in should be blocked.

  • UIProcess/WebContext.messages.in:

GetPluginPath now takes an additional out parameter, a boolean that determines whether the plug-in
should be blocked from loading or not.

  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didFailToInitializePlugin):
Call m_client.pluginDidFail.

(WebKit::WebLoaderClient::didBlockInsecurePluginVersion):
Ditto.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::unavailablePluginButtonClicked):
Call the loader client.

(WebKit::WebPageProxy::didBlockInsecurePluginVersion):
Ditto.

  • UIProcess/WebPageProxy.messages.in:

Rename MissingPluginButtonClicked to UnavailablePluginButtonClicked and add a new DidBlockInsecurePluginVersion message.

  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::unavailablePluginButtonClicked):
Call missingPluginButtonClicked and unavailablePluginButtonClicked.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::shouldUnavailablePluginMessageBeButton):
(WebKit::WebChromeClient::unavailablePluginButtonClicked):
Handle RenderEmbeddedObject::InsecurePluginVersion.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createPlugin):
WebPage::createPlugin now takes the plug-in element.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):
If the plug-in is blocked, set the appropriate unavailability reason.

  • WebProcess/WebProcess.cpp:

(WebKit::canPluginHandleResponse):
Update now that GetPluginPath returns a blocked parameter as well.

Tools:

Update for WK2 API changes.

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):

6:45 PM Changeset in webkit [116715] by shinyak@chromium.org
  • 10 edits in trunk/Source/WebCore

[Refactoring] Move Selection from DOMWindow to TreeScope.
https://bugs.webkit.org/show_bug.cgi?id=82699

Reviewed by Ryosuke Niwa.

Since ShadowRoot will also manage its own version of DOMSelection, we would like to
share the code among Document and DOMSelection. This patch moves DOMSelection from DOMWindow to TreeScope
so that ShadowRoot can also use it.

No new tests, should covered by existing tests.

  • dom/Document.cpp:

(WebCore::Document::updateFocusAppearanceTimerFired):

  • dom/Document.h:

(Document):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::selection):

  • do/mTreeScope.cpp:

(WebCore::TreeScope::~TreeScope):
(WebCore::TreeScope::getSelection):
(WebCore):

  • dom/TreeScope.h:

(WebCore):
(TreeScope):

  • page/DOMSelection.cpp:

(WebCore::DOMSelection::DOMSelection):
(WebCore::DOMSelection::clearTreeScope):
(WebCore):

  • page/DOMSelection.h:

(WebCore):
(WebCore::DOMSelection::create):
(DOMSelection):
(WebCore::DOMSelection::frame):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::clearDOMWindowProperties):
(WebCore::DOMWindow::getSelection):

  • page/DOMWindow.h:

(DOMWindow):

6:20 PM Changeset in webkit [116714] by tkent@chromium.org
  • 12 edits in trunk/Source

Unreviewed, rolling out r116594.
http://trac.webkit.org/changeset/116594
https://bugs.webkit.org/show_bug.cgi?id=86013

r116594 might have made some composition tests flaky.

Source/WebCore:

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::addAnimation):

  • platform/graphics/chromium/cc/CCLayerAnimationController.cpp:

(WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCProxy.h:

(CCProxy):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::CCSingleThreadProxy):
(WebCore::CCSingleThreadProxy::doComposite):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(WebCore):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestTickAnimationWhileBackgrounded::animateLayers):
(WTF):
(WTF::TEST_F):

6:08 PM Changeset in webkit [116713] by jianli@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Fix chromium build break.

  • src/LocalizedStrings.cpp:

(WebCore::insecurePluginVersionText):

5:42 PM Changeset in webkit [116712] by Michael Nordman
  • 15 edits
    3 deletes in trunk/Source

Source/WebCore: [chromium] DomStorage events handling needs TLC (2)
https://bugs.webkit.org/show_bug.cgi?id=85221
Alter the StorageArea virtual interface such that the mutators no longer
return old values. This is to allow implementations of the interface to operate
more asynchronously.

Reviewed by Adam Barth.

No new tests. Existing tests cover this.

  • storage/StorageArea.h: Alter the interface so the mutators no longer return previous values
  • storage/StorageAreaImpl.cpp:

(WebCore::StorageAreaImpl::disabledByPrivateBrowsingInFrame): removed an unneeded PLATFORM(CHROMIUM) guard
(WebCore::StorageAreaImpl::setItem): no longer return the old value
(WebCore::StorageAreaImpl::removeItem): no longer return the old value
(WebCore::StorageAreaImpl::clear): no longer return whether something was cleared

  • storage/StorageAreaImpl.h: match StorageArea's virtual interface

Source/WebKit/chromium: [chromium] DomStorage events handling needs TLC (2)
https://bugs.webkit.org/show_bug.cgi?id=85221
Alter the WebStorageArea virtual interface such that the mutators no longer
return old values. This is to allow implementations of the interface to operate
more asynchronously.

Also clean up from the last patch, remove support for the DEPRECATED event
dispatching API.

Reviewed by Adam Barth.

  • WebKit.gyp: delete three files indicated below
  • public/WebStorageArea.h:

(WebKit::WebStorageArea::setItem): no longer returns the old value
(WebKit::WebStorageArea::removeItem): no longer returns the old value
(WebKit::WebStorageArea::clear): no longer returns a bool indicated if something was cleared

  • public/WebStorageEventDispatcher.h: removed the DEPRECATED instance methods
  • public/WebStorageNamespace.h: removed the DEPRECATED close() method
  • public/platform/WebKitPlatformSupport.h: removed the DEPRECATED dispatchStorageEvent() method
  • src/StorageAreaProxy.cpp: removed the DEPREACTED storageEvent() method

(WebCore::StorageAreaProxy::setItem): no return value
(WebCore::StorageAreaProxy::removeItem): no return value
(WebCore::StorageAreaProxy::clear): no return value
(WebCore::StorageAreaProxy::dispatchLocalStorageEvent): remove an early return thats no longer needed
(WebCore::findPageWithSessionStorageNamespace): switched to passing pageGroup by ptr value instead of by name
(WebCore::StorageAreaProxy::dispatchSessionStorageEvent): remove an early return thats no longer needed

  • src/StorageAreaProxy.h:

(WebCore):
(StorageAreaProxy):

  • src/StorageEventDispatcherImpl.cpp: Deleted the file.
  • src/StorageEventDispatcherImpl.h: Deleted the file.
  • src/WebStorageEventDispatcherImpl.cpp: Deleted the DEPRECATED instance methods.

(WebKit::WebStorageEventDispatcher::dispatchLocalStorageEvent): use WebViewImpl::defaultPageGroup
(WebKit::WebStorageEventDispatcher::dispatchSessionStorageEvent): use WebViewImpl::defaultPageGroup

  • src/WebStorageEventDispatcherImpl.h: Deleted the file.
  • src/WebViewImpl.cpp: added a static method to retrieve a ptr to the default page group,

(WebKit::WebViewImpl::defaultPageGroup):

  • src/WebViewImpl.h:
5:31 PM Changeset in webkit [116711] by Beth Dakin
  • 3 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=86158
Overlay scrollbars without layers never paint in overflow regions in
tiled drawing mode
-and corresponding-
<rdar://problem/11289546>

Reviewed by Darin Adler.

RenderLayers paint scrollbars that do not have their own layers by
running a second pass through the layer tree after the layer tree has
painted. This ensures that the scrollbars always paint on top of
content. However, this mechanism was relying on
FrameView::paintContents() as a choke-point for all painting to
trigger the second painting pass. That is not a reasonable choke-point
in tiled drawing, so this patch adds similar code to
RenderLayerBacking.

Only opt into the second painting pass for scrollbars that do not have
their own layers.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintOverflowControls):

A layer that paints into its backing cannot return early here if it
has overlay scrollbars to paint.
(WebCore::RenderLayer::paintLayer):

This replicates code in FrameView::paintContents(). After painting the
owning layer, do a second pass if there are overlay scrollbars to
paint.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintIntoLayer):

5:19 PM Changeset in webkit [116710] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Well, at least fixing the GTK+ build is something!

  • platform/gtk/LocalizedStringsGtk.cpp:

(WebCore::insecurePluginVersionText):
(WebCore):

5:07 PM Changeset in webkit [116709] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/chromium

Add insecurePluginVersionText stub here too.

  • src/LocalizedStrings.cpp:
5:06 PM Changeset in webkit [116708] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Add insecurePluginVersionText stubs.

  • platform/blackberry/LocalizedStringsBlackBerry.cpp:

(WebCore::insecurePluginVersionText):
(WebCore):

  • platform/efl/LocalizedStringsEfl.cpp:

(WebCore::insecurePluginVersionText):
(WebCore):

  • platform/qt/LocalizedStringsQt.cpp:

(WebCore::insecurePluginVersionText):
(WebCore):

5:06 PM Changeset in webkit [116707] by dpranke@chromium.org
  • 2 edits in trunk/Tools

nrwt: [chromium] fix path to asan symbolize script
https://bugs.webkit.org/show_bug.cgi?id=86161

Reviewed by Abhishek Arya.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort._get_crash_log):

5:03 PM Changeset in webkit [116706] by jsbell@chromium.org
  • 2 edits in branches/chromium/1132/Source

Merge 116333 - IndexedDB: LevelDB coding for bools is broken
https://bugs.webkit.org/show_bug.cgi?id=85810

Reviewed by Tony Chang.

Source/WebCore:

Code was appending to a pre-sized Vector, rather than using an
index setter. This caused uninitialized data to be written out.
Issue was detected on the Chromium side in http://crbug.com/126388

Tests: webkit_unit_tests --gtest_filter='IDBLevelDBCodingTest.*codeBool'

  • Modules/indexeddb/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::encodeBool):

Source/WebKit/chromium:

Added tests for encodeBool/decodeBool.

  • tests/IDBLevelDBCodingTest.cpp:

(IDBLevelDBCoding::TEST):
(IDBLevelDBCoding):

TBR=jsbell@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10377101

5:02 PM Changeset in webkit [116705] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Unreviewed, rolling out r116677.
http://trac.webkit.org/changeset/116677
https://bugs.webkit.org/show_bug.cgi?id=86159

This patch causes linker error to some mac bots (Requested by
jianli_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-10

  • WebCore.exp.in:
  • dom/ContainerNode.h:
  • dom/Node.cpp:

(WebCore::Node::traverseNextNode):
(WebCore::Node::traverseNextSibling):

  • dom/Node.h:

(Node):

4:53 PM Changeset in webkit [116704] by Lucas Forschler
  • 1 copy in tags/Safari-536.11

New Tag.

4:48 PM Changeset in webkit [116703] by dpranke@chromium.org
  • 2 edits in trunk/Tools

[chromium] Set Valgrind environment variables for layout tests.
https://bugs.webkit.org/show_bug.cgi?id=86156

Patch by Lei Zhang <thestig@chromium.org> on 2012-05-10
Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.setup_environ_for_server):

4:38 PM Changeset in webkit [116702] by kerz@chromium.org
  • 1 copy in branches/chromium/1132/Tools/Scripts/webkitpy/thirdparty/mod_pywebsocket

Add new pywebsocket files.

4:35 PM Changeset in webkit [116701] by kerz@chromium.org
  • 4 edits in branches/chromium/1132/Tools

Merge 116668 - don't use autoinstall to import pywebsocket but check it in WebKit directly.
https://bugs.webkit.org/show_bug.cgi?id=86107

Reviewed by Adam Barth.

This change removes pywebsocket from webkitpy's autoinstall list and
imports pywebsocket 0.7.4 directly into webkitpy/thirparty.

  • Scripts/webkitpy/layout_tests/servers/websocket_server.py:

(PyWebSocket._prepare_config):

  • Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook.find_module):
(AutoinstallImportHook._install_irc):

  • Scripts/webkitpy/thirdparty/init_unittest.py:

(ThirdpartyTest.test_import_hook.MockImportHook.init):
(ThirdpartyTest.test_import_hook.MockImportHook._install_eliza):
(ThirdpartyTest):
(ThirdpartyTest.test_import_hook):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/COPYING: Added.
  • Scripts/webkitpy/thirdparty/mod_pywebsocket/init.py: Added.
  • Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py: Added.

(ConnectionTerminatedException):
(InvalidFrameException):
(BadOperationException):
(UnsupportedFrameException):
(InvalidUTF8Exception):
(StreamBase):
(StreamBase.init):
(StreamBase._read):
(StreamBase._write):
(StreamBase.receive_bytes):
(StreamBase._read_until):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hixie75.py: Added.

(for):
(StreamHixie75):
(StreamHixie75.for):
(StreamHixie75.init):
(StreamHixie75.send_message):
(StreamHixie75._read_payload_length_hixie75):
(StreamHixie75.receive_message):
(StreamHixie75._send_closing_handshake):
(StreamHixie75.close_connection):
(StreamHixie75.send_ping):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py: Added.

(Frame):
(Frame.init):
(create_length_header):
(create_header):
(_build_frame):
(_filter_and_format_frame_object):
(create_binary_frame):
(create_text_frame):
(FragmentedFrameBuilder):
(FragmentedFrameBuilder.to):
(FragmentedFrameBuilder.init):
(FragmentedFrameBuilder.build):
(_create_control_frame):
(create_ping_frame):
(create_pong_frame):
(create_close_frame):
(StreamOptions):
(StreamOptions.init):
(Stream):
(Stream.for):
(Stream.init):
(Stream._receive_frame):
(Stream._receive_frame_as_frame_object):
(Stream.send_message):
(Stream.receive_message):
(Stream._send_closing_handshake):
(Stream.close_connection):
(Stream.send_ping):
(Stream._send_pong):
(Stream._drain_received_data):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py: Added.

(is_control_opcode):
(ExtensionParameter):
(ExtensionParameter.init):
(ExtensionParameter.name):
(ExtensionParameter.add_parameter):
(ExtensionParameter.get_parameters):
(ExtensionParameter.get_parameter_names):
(ExtensionParameter.has_parameter):
(ExtensionParameter.get_parameter_value):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py: Added.

(DispatchException):
(DispatchException.init):
(_default_passive_closing_handshake_handler):
(_normalize_path):
(_create_path_to_resource_converter):
(_create_path_to_resource_converter.converter):
(_enumerate_handler_file_paths):
(_HandlerSuite):
(_HandlerSuite.init):
(_source_handler_file):
(_extract_handler):
(Dispatcher):
(Dispatcher.maintains):
(Dispatcher.init):
(Dispatcher.add_resource_path_alias):
(Dispatcher.source_warnings):
(Dispatcher.do_extra_handshake):
(Dispatcher.transfer_data):
(Dispatcher.passive_closing_handshake):
(Dispatcher.get_handler_suite):
(Dispatcher._source_handler_files_in_dir):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py: Added.

(ExtensionProcessorInterface):
(ExtensionProcessorInterface.get_extension_response):
(ExtensionProcessorInterface.setup_stream_options):
(DeflateStreamExtensionProcessor):
(DeflateStreamExtensionProcessor.init):
(DeflateStreamExtensionProcessor.get_extension_response):
(DeflateStreamExtensionProcessor.setup_stream_options):
(DeflateFrameExtensionProcessor):
(DeflateFrameExtensionProcessor.init):
(DeflateFrameExtensionProcessor.get_extension_response):
(DeflateFrameExtensionProcessor.setup_stream_options):
(DeflateFrameExtensionProcessor.setup_stream_options._OutgoingFilter):
(DeflateFrameExtensionProcessor.setup_stream_options._OutgoingFilter.init):
(DeflateFrameExtensionProcessor.setup_stream_options._OutgoingFilter.filter):
(DeflateFrameExtensionProcessor.setup_stream_options._IncomingFilter):
(DeflateFrameExtensionProcessor.setup_stream_options._IncomingFilter.init):
(DeflateFrameExtensionProcessor.setup_stream_options._IncomingFilter.filter):
(DeflateFrameExtensionProcessor.set_response_window_bits):
(DeflateFrameExtensionProcessor.set_response_no_context_takeover):
(DeflateFrameExtensionProcessor.enable_outgoing_compression):
(DeflateFrameExtensionProcessor.disable_outgoing_compression):
(DeflateFrameExtensionProcessor._outgoing_filter):
(DeflateFrameExtensionProcessor._incoming_filter):
(get_extension_processor):
(get_extension_processor.is):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/init.py: Added.

(try):
(do_handshake):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py: Added.

(AbortedByUserException):
(HandshakeException):
(HandshakeException.init):
(VersionException):
(VersionException.init):
(get_default_port):
(validate_subprotocol):
(parse_host_header):
(format_header):
(build_location):
(get_mandatory_header):
(validate_mandatory_header):
(check_request_line):
(check_header_lines):
(parse_token_list):
(_parse_extension_param):
(_parse_extension):
(parse_extensions):
(format_extensions):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/draft75.py: Added.

(Handshaker):
(Handshaker.performs):
(Handshaker.init):
(Handshaker.do_handshake):
(Handshaker._set_resource):
(Handshaker._set_origin):
(Handshaker._set_location):
(Handshaker._set_subprotocol):
(Handshaker._set_protocol_version):
(Handshaker._sendall):
(Handshaker._send_handshake):
(Handshaker._check_header_lines):
(Handshaker._check_first_lines):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py: Added.

(compute_accept):
(Handshaker):
(Handshaker.init):
(Handshaker._validate_connection_header):
(Handshaker.do_handshake):
(Handshaker._get_origin):
(Handshaker._check_version):
(Handshaker._set_protocol):
(Handshaker._parse_extensions):
(Handshaker._validate_key):
(Handshaker._get_key):
(Handshaker._send_handshake):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py: Added.

(Handshaker):
(Handshaker.init):
(Handshaker.do_handshake):
(Handshaker._set_resource):
(Handshaker._set_subprotocol):
(Handshaker._set_location):
(Handshaker._set_origin):
(Handshaker._set_protocol_version):
(Handshaker._set_challenge_response):
(Handshaker._get_key_value):
(Handshaker._get_challenge):
(Handshaker._send_handshake):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py: Added.

(ApacheLogHandler):
(ApacheLogHandler.init):
(ApacheLogHandler.emit):
(_configure_logging):
(_parse_option):
(_create_dispatcher):
(headerparserhandler):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/http_header_util.py: Added.

(_is_char):
(_is_ctl):
(ParsingState):
(ParsingState.init):
(peek):
(consume):
(consume_string):
(consume_lws):
(consume_lwses):
(consume_token):
(consume_token_or_quoted_string):
(quote_if_necessary):
(parse_uri):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/memorizingfile.py: Added.

(MemorizingFile):
(MemorizingFile.init):
(MemorizingFile.getattribute):
(MemorizingFile.readline):
(MemorizingFile.get_memorized_lines):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/msgutil.py: Added.

(close_connection):
(send_message):
(receive_message):
(send_ping):
(MessageReceiver):
(MessageReceiver.receives):
(MessageReceiver.provides):
(MessageReceiver.should):
(MessageReceiver.init):
(MessageReceiver.run):
(MessageReceiver.receive):
(MessageReceiver.receive_nowait):
(MessageReceiver.stop):
(MessageSender):
(MessageSender.sends):
(MessageSender.provides):
(MessageSender.should):
(MessageSender.init):
(MessageSender.run):
(MessageSender.send):
(MessageSender.send_nowait):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py: Added.

(_StandaloneConnection):
(_StandaloneConnection.init):
(_StandaloneConnection.get_local_addr):
(_StandaloneConnection.get_remote_addr):
(_StandaloneConnection.write):
(_StandaloneConnection.read):
(_StandaloneConnection.get_memorized_lines):
(_StandaloneRequest):
(_StandaloneRequest.init):
(_StandaloneRequest.get_uri):
(_StandaloneRequest.get_method):
(_StandaloneRequest.is_https):
(_StandaloneRequest._drain_received_data):
(_StandaloneSSLConnection):
(_StandaloneSSLConnection.for):
(_StandaloneSSLConnection.init):
(_StandaloneSSLConnection.getattribute):
(_StandaloneSSLConnection.setattr):
(_StandaloneSSLConnection.makefile):
(WebSocketServer):
(WebSocketServer.init):
(WebSocketServer._create_sockets):
(WebSocketServer.server_bind):
(WebSocketServer.server_activate):
(WebSocketServer.server_close):
(WebSocketServer.fileno):
(WebSocketServer.handle_error):
(WebSocketServer.get_request):
(WebSocketServer.serve_forever):
(WebSocketServer.shutdown):
(WebSocketRequestHandler):
(WebSocketRequestHandler.setup):
(WebSocketRequestHandler.setup.SocketServer):
(WebSocketRequestHandler.init):
(WebSocketRequestHandler.parse_request):
(WebSocketRequestHandler.log_request):
(WebSocketRequestHandler.log_error):
(WebSocketRequestHandler.is_cgi):
(_configure_logging):
(_alias_handlers):
(_build_option_parser):
(ThreadMonitor):
(ThreadMonitor.init):
(ThreadMonitor.run):
(_parse_args_and_config):
(_main):
(_main.if):
(_main.if.check_script):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/stream.py: Copied from Tools/Scripts/webkitpy/thirdparty/init_unittest.py.
  • Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py: Added.

(get_stack_trace):
(prepend_message_to_exception):
(translate_interp):
(get_script_interp):
(wrap_popen3_for_win):
(wrap_popen3_for_win.
wrap_popen3):
(hexify):
(get_class_logger):
(NoopMasker):
(NoopMasker.init):
(NoopMasker.mask):
(RepeatedXorMasker):
(RepeatedXorMasker.init):
(RepeatedXorMasker.mask):
(DeflateRequest):
(DeflateRequest.for):
(DeflateRequest.init):
(DeflateRequest.getattribute):
(DeflateRequest.setattr):
(_Deflater):
(_Deflater.init):
(_Deflater.compress_and_flush):
(_Inflater):
(_Inflater.init):
(_Inflater.decompress):
(_Inflater.append):
(_Inflater.reset):
(_RFC1979Deflater):
(_RFC1979Deflater.that):
(_RFC1979Deflater.init):
(_RFC1979Deflater.filter):
(_RFC1979Inflater):
(_RFC1979Inflater.for):
(_RFC1979Inflater.init):
(_RFC1979Inflater.filter):
(DeflateSocket):
(DeflateSocket.for):
(DeflateSocket.init):
(DeflateSocket.recv):
(DeflateSocket.sendall):
(DeflateSocket.send):
(DeflateConnection):
(DeflateConnection.for):
(DeflateConnection.init):
(DeflateConnection.get_remote_addr):
(DeflateConnection.put_bytes):
(DeflateConnection.read):
(DeflateConnection.write):
(_is_ewouldblock_errno):
(drain_received_data):

TBR=toyoshim@chromium.org

4:11 PM Changeset in webkit [116700] by Lucas Forschler
  • 4 edits in tags/Safari-536.10.3/Source

Versioning.

4:10 PM Changeset in webkit [116699] by Lucas Forschler
  • 24 edits
    4 copies in tags/Safari-536.10.3

Merged r116595.

4:02 PM Changeset in webkit [116698] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash in FontCache::releaseFontData due to infinite float size.
https://bugs.webkit.org/show_bug.cgi?id=86110

Reviewed by Andreas Kling.

Source/WebCore:

New callers always forget to clamp the font size, which overflows
to infinity on multiplication. It is best to clamp it at the end
to avoid getting greater than std::numeric_limits<float>::max().

Test: fast/css/large-font-size-crash.html

  • platform/graphics/FontDescription.h:

(WebCore::FontDescription::setComputedSize):
(WebCore::FontDescription::setSpecifiedSize):

LayoutTests:

  • fast/css/large-font-size-crash-expected.txt: Added.
  • fast/css/large-font-size-crash.html: Added.
3:58 PM Changeset in webkit [116697] by Beth Dakin
  • 3 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=82131
[Mac] REGRESSION (r110480): Text field that specifies background-color
(or is auto-filled) gets un-themed border
-and corresponding-
<rdar://problem/11115221>

Reviewed by Maciej Stachowiak.

This change rolls out r110480 which is what caused styled text fields
to get the un-themed border, and it does a bunch of work to make sure
we get the pretty, new version of the NSTextField art whenever
possible. We do this differently for post-Lion OS's since there is now
a way to opt into it all the time. Lion and SnowLeopard can only use
the new art in HiDPI mode when the background color of the text field
is just white.

RenderThemeMac::textField() takes a boolean paramter used to determine
if the new gradient will be used.

  • rendering/RenderThemeMac.h:

(RenderThemeMac):

This is the post-Lion workaround. This code has no effect on Lion and
SnowLeopard. This allows up to opt into a version of [NSTextField drawWithFrame:] that will only draw the frame of the text field; without this, it will draw the frame and the background, which creates a number of problems with styled text fields and text fields in HiDPI. There is a less comprehesive workaround for Lion and SnowLeopard in place in RenderThemeMac::textField().

  • rendering/RenderThemeMac.mm:

(-[WebCoreTextFieldCell _coreUIDrawOptionsWithFrame:inView:includeFocus:]):

This is the roll-out of r110480.
(WebCore::RenderThemeMac::isControlStyled):

See the comments for a full explanation, but this is mostly code for
Lion and SnowLeopard to determine if we can opt into the new artwork.
(WebCore::RenderThemeMac::paintTextField):
(WebCore::RenderThemeMac::textField):

3:55 PM Changeset in webkit [116696] by Lucas Forschler
  • 1 copy in tags/Safari-536.10.3

new Tag.

3:45 PM Changeset in webkit [116695] by andersca@apple.com
  • 16 edits in trunk

WebKit1: Add a way to blacklist specific plug-ins/plug-in versions
https://bugs.webkit.org/show_bug.cgi?id=86150
<rdar://problem/9551196>

Reviewed by Sam Weinig.

Source/WebCore:

  • English.lproj/Localizable.strings:

Update.

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::loadPlugin):
It is possible that the client has already set the unavailability reason so don't try to set it twice.

  • platform/LocalizedStrings.cpp:

(WebCore::insecurePluginVersionText):

  • platform/LocalizedStrings.h:

Add insecure plug-in version text.

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::unavailablePluginReplacementText):

  • rendering/RenderEmbeddedObject.h:

Add InsecurePluginVersion unavailability reason.

Source/WebKit/mac:

  • Misc/WebKitErrors.h:

Add WebKitErrorInsecurePlugInVersion enum.

  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm:

(-[WebBasePluginPackage bundleIdentifier]):
(-[WebBasePluginPackage bundleVersion]):
Add bundleIdentifier and bundleVersion getters.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::createPlugin):
Check if the plug-in is blocked. If it is, set the unavailability reason and the error code.

WebKitLibraries:

Add WKShouldBlockPlugin.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
3:11 PM Changeset in webkit [116694] by eric@webkit.org
  • 7 edits
    2 adds in trunk

Make IFRAME_SEAMLESS child documents inherit styles from their parent iframe element
https://bugs.webkit.org/show_bug.cgi?id=85940

Reviewed by Ojan Vafai.

Source/WebCore:

The HTML5 <iframe seamless> spec says:
In a CSS-supporting user agent: the user agent must, for the purpose of CSS property
inheritance only, treat the root element of the active document of the iframe
element's nested browsing context as being a child of the iframe element.
(Thus inherited properties on the root element of the document in the
iframe will inherit the computed values of those properties on the iframe
element instead of taking their initial values.)

Initially I implemented this support to the letter of the spec. However, doing so I learned
that WebKit has a RenderStyle for the Document Node, not just the root element of the document.
In this RenderStyle on the Document, we add a bunch of per-document styles from settings
including designMode.

This change makes StyleResolver::styleForDocument inherit style from the parent iframe's
style, before applying any of these per-document styles. This may or may not be correct
depending on what behavior we want for rtl-ordering, page-zoom, locale, design mode, etc.
For now, we continue to treat the iframe's document as independent in these regards, and
the settings on that document override those inherited from the iframe.

Also, intially when making this work, I added redirects in recalcStyle and scheduleStyleRecalc
from the child document to the parent document in the case of seamless (since the parent
document effectively manages the style resolve and layout of the child in seamless mode).
However, I was not able to find a test which depended on this code change, so in this final patch
I have removed both of these modifications and replaced them with FIXMEs. Based on discussions
with Ojan and James Robinson, I believe both of those changes may eventually be wanted.

This change basically does 3 things:

  1. Makes StyleResolver::styleForDocument inherit from the parent iframe.
  2. Makes any recalcStyle calls on the iframe propogate down into the child document (HTMLIFrameElement::didRecalcStyle).
  3. Makes Document::recalcStyle aware of the fact that the Document's style *can* change

for reasons other than recalcStyle(Force).

I'm open to more testing suggestions, if reviewers have settings on the Document's style
that you want to make sure we inherit from the parent iframe, or don't inherit, etc.
I view this as a complete solution to this aspect of the current <iframe seamless> spec,
but likely not the last code we will write for this aspect of the seamless feature. :)

Tested by fast/frames/seamlesss/seamless-css-cascade.html and seamless-designMode.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

  • dom/Document.cpp:

(WebCore::Document::scheduleStyleRecalc):
(WebCore::Document::recalcStyle):

  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::HTMLIFrameElement):
(WebCore::HTMLIFrameElement::didRecalcStyle):
(WebCore):

  • html/HTMLIFrameElement.h:

(HTMLIFrameElement):

LayoutTests:

This single pass is deceptive. seamless-designMode exists
to make sure that we do not regress application of Document-level
styles in the child document.

  • fast/frames/seamless/seamless-css-cascade-expected.txt:
3:08 PM Changeset in webkit [116693] by jchaffraix@webkit.org
  • 3 edits
    4 adds in trunk

Crash in computedCSSPadding* functions due to RenderImage::imageDimensionsChanged called during attachment
https://bugs.webkit.org/show_bug.cgi?id=85912

Reviewed by Eric Seidel.

Source/WebCore:

Tests: fast/images/link-body-content-imageDimensionChanged-crash.html

fast/images/script-counter-imageDimensionChanged-crash.html

The bug comes from CSS generated images that could end up calling imageDimensionsChanged during attachment. As the
rest of the code (e.g. computedCSSPadding*) would assumes that we are already inserted in the tree, we would crash.

The solution is to bail out in this case as newly inserted RenderObject will trigger layout later on and properly
handle what we would be doing as part of imageDimensionChanged (the only exception being updating our intrinsic
size which should be done as part of imageDimensionsChanged).

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::imageDimensionsChanged):

LayoutTests:

  • fast/images/link-body-content-imageDimensionChanged-crash-expected.txt: Added.
  • fast/images/link-body-content-imageDimensionChanged-crash.html: Added.
  • fast/images/script-counter-imageDimensionChanged-crash-expected.txt: Added.
  • fast/images/script-counter-imageDimensionChanged-crash.html: Added.
3:00 PM Changeset in webkit [116692] by rakuco@webkit.org
  • 3 edits in trunk/Tools

[webkitpy][EFL] It should be possible to use a wrapper command for ImageDiff.
https://bugs.webkit.org/show_bug.cgi?id=86145

Reviewed by Dirk Pranke.

The GTK+ and EFL ports use jhbuild to build a few base libraries
which are then used when building the port itself. Programs such
as DRT and ImageDiff are then supposed to be run with the
`run-with-jhbuild' wrapper so that the libraries are properly
found and loaded.

This was already the case for DumpRenderTree (EflPort defines the
'wrapper' option for that), but it was not possible to do the same
with ImageDiff so far.

The code which created the ImageDiff command-line call has been
moved to a separate method, _image_diff_command, which is then
overridden by EflPort to add the jhbuild wrapper.

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort.init):
(EflPort._image_diff_command):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort):
(WebKitPort._image_diff_command):
(WebKitPort._start_image_diff_process):

2:53 PM Changeset in webkit [116691] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

ASSERT in BidiResolver<Iterator, Run>::commitExplicitEmbedding makes running debug builds annoying
https://bugs.webkit.org/show_bug.cgi?id=86140

Reviewed by Eric Seidel.

The correct fix here is to resolve
https://bugs.webkit.org/show_bug.cgi?id=76574, but in the mean time,
this ASSERT is annoying.

  • platform/text/BidiResolver.h:

(WebCore::::commitExplicitEmbedding):

2:52 PM Changeset in webkit [116690] by pilgrim@chromium.org
  • 11 edits
    3 adds in trunk/Source

[Chromium] Call addTraceEvent and getTraceCategoryEnabledFlag directly
https://bugs.webkit.org/show_bug.cgi?id=85399

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/EventTracer.cpp: Added.

(WebCore):
(WebCore::EventTracer::getTraceCategoryEnabledFlag):
(WebCore::EventTracer::addTraceEvent):

  • platform/EventTracer.h: Added.

(WebCore):
(EventTracer):

  • platform/chromium/EventTracerChromium.cpp: Added.

(WebCore):
(WebCore::EventTracer::getTraceCategoryEnabledFlag):
(WebCore::EventTracer::addTraceEvent):

  • platform/chromium/PlatformSupport.h:
  • platform/chromium/TraceEvent.h:

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore):

2:44 PM Changeset in webkit [116689] by pilgrim@chromium.org
  • 16 edits in trunk/Source

[Chromium] Remove WEBKIT_USING_SKIA ifdefs that are always true
https://bugs.webkit.org/show_bug.cgi?id=86121

Reviewed by Adam Barth.

Chromium always uses Skia now, so this just removes the barriers
around code that was previously #if'd.

Source/Platform:

  • chromium/public/WebCanvas.h:

(WebKit):

  • chromium/public/WebGraphicsContext3D.h:

(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::onCreateGrGLInterface):

  • chromium/public/WebImage.h:

(WebImage):

Source/WebKit/chromium:

  • README:
  • src/DragClientImpl.cpp:

(WebKit::DragClientImpl::startDrag):

  • src/PageOverlay.cpp:
  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::clipboardWriteImage):
(WebCore::PlatformSupport::paintScrollbarThumb):

  • src/WebContentLayerImpl.cpp:

(WebKit::WebContentLayerImpl::paintContents):

  • src/WebFontImpl.cpp:

(WebKit::WebFontImpl::drawText):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::printPage):
(WebKit::WebFrameImpl::printPagesWithBoundaries):

  • src/WebGraphicsContext3D.cpp:

(WebKit::WebGraphicsContext3D::createGrGLInterface):

  • src/WebImageDecoder.cpp:

(WebKit::WebImageDecoder::getFrameAtIndex):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::paint):
(WebKit::WebPluginContainerImpl::printPage):

  • src/painting/GraphicsContextBuilder.h:

(WebKit):

2:37 PM Changeset in webkit [116688] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

ScrollView::fixedVisibleContentRect should be public
https://bugs.webkit.org/show_bug.cgi?id=86147

Reviewed by Eric Seidel.

Some code in the WebKit layer of OS(ANDROID) uses this function. That
could will be upstreamed in a later patch. For now, this patch just
makes this function public so that we remove the diff to this file.

  • platform/ScrollView.h:

(WebCore::ScrollView::fixedVisibleContentRect):
(WebCore::ScrollView::delegatesScrollingDidChange):

2:21 PM Changeset in webkit [116687] by andersca@apple.com
  • 22 edits in trunk/Source

Rename the missing plug-in indicator to the unavailable plug-in indicator
https://bugs.webkit.org/show_bug.cgi?id=86136

Reviewed by Sam Weinig.

Source/WebCore:

Since the indicator is shown for more than just missing plug-ins, generalize it and use a plug-in unavailability
reason enum to make it easier to extend. Also, pass the unavailability reason to the ChromeClient member functions.

  • WebCore.exp.in:
  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::updateWidget):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateWidget):

  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::defaultEventHandler):

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::updateWidgetIfNecessary):

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::loadPlugin):

  • page/ChromeClient.h:

(WebCore::ChromeClient::shouldUnavailablePluginMessageBeButton):
(WebCore::ChromeClient::unavailablePluginButtonClicked):

  • page/FrameView.cpp:

(WebCore::FrameView::updateWidget):

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::RenderEmbeddedObject):
(WebCore::RenderEmbeddedObject::setPluginUnavailabilityReason):
(WebCore::RenderEmbeddedObject::showsUnavailablePluginIndicator):
(WebCore::RenderEmbeddedObject::setUnavailablePluginIndicatorIsPressed):
(WebCore::RenderEmbeddedObject::paint):
(WebCore::RenderEmbeddedObject::paintReplaced):
(WebCore::RenderEmbeddedObject::getReplacementTextGeometry):
(WebCore::RenderEmbeddedObject::unavailablePluginReplacementText):
(WebCore):
(WebCore::RenderEmbeddedObject::isInUnavailablePluginIndicator):
(WebCore::shouldUnavailablePluginMessageBeButton):
(WebCore::RenderEmbeddedObject::handleUnavailablePluginIndicatorEvent):
(WebCore::RenderEmbeddedObject::getCursor):

  • rendering/RenderEmbeddedObject.h:

(RenderEmbeddedObject):

Source/WebKit/mac:

  • Plugins/Hosted/WebHostedNetscapePluginView.mm:

(-[WebHostedNetscapePluginView pluginHostDied]):

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::shouldUnavailablePluginMessageBeButton):
(WebChromeClient::unavailablePluginButtonClicked):

Source/WebKit/win:

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::shouldUnavailablePluginMessageBeButton):
(WebChromeClient::unavailablePluginButtonClicked):

  • WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

Source/WebKit2:

Update for WebCore changes.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::pluginProcessCrashed):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::shouldUnavailablePluginMessageBeButton):
(WebKit::WebChromeClient::unavailablePluginButtonClicked):

  • WebProcess/WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

2:14 PM Changeset in webkit [116686] by tsepez@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] WebFrameTest.ChromePageNoJavascript isn't catching regressions
https://bugs.webkit.org/show_bug.cgi?id=86046

Reviewed by Adam Barth.

Test both cases for registerURLSchemeAsNotAllowingJavascriptURLs. Also add
a call to layout() to ensure the javascript result is seen.

  • tests/WebFrameTest.cpp:

(WebKit::TEST_F):
(WebKit):

2:09 PM Changeset in webkit [116685] by beidson@apple.com
  • 8 edits
    2 adds in trunk

<rdar://problem/10972577> and https://bugs.webkit.org/show_bug.cgi?id=80170
Contents of noscript elements turned into strings in WebArchives

Source/WebCore:

Reviewed by Andy Estes.

There's a much deeper question about how innerHTML of <noscript> is expected to work in
both a scripting and non-scripting environment that we should pursue separately.

But for webarchives, we can solve this by filtering out the <noscript> elements completely
if scripting is enabled.

Test: webarchive/ignore-noscript-if-scripting-enabled.html

  • WebCore.exp.in:

Add arguments to createMarkup and MarkupAccumulator methods to pass a Vector of QualifiedNames
that should be filtered from the resulting markup:

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::serializeNodes):
(WebCore::MarkupAccumulator::serializeNodesWithNamespaces):

  • editing/MarkupAccumulator.h:
  • editing/markup.cpp:

(WebCore::createMarkup):

  • editing/markup.h:

If scripting is enabled, add the noscriptTag to the tag names to filter:

  • loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::create):

LayoutTests:

Reviewed by Andy Estes.

  • webarchive/ignore-noscript-if-scripting-enabled-expected.txt: Added.
  • webarchive/ignore-noscript-if-scripting-enabled.html: Added.
2:01 PM Changeset in webkit [116684] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

Caret node boundary should be adjusted to account for the visible region.
https://bugs.webkit.org/show_bug.cgi?id=86116

Reviewed by Antonio Gomes.

PR 138988.

Update the node bounding box to be clipped and adjusted
for the visible region of the frame.

Reviewed Internally by Gen Mak.

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::caretPositionChanged):

1:50 PM Changeset in webkit [116683] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

Crash due to floats not removed from first-letter element.
https://bugs.webkit.org/show_bug.cgi?id=86019

Reviewed by Julien Chaffraix.

Source/WebCore:

Move clearing logic of a floating/positioned object from removeChild
to removeChildNode. There are lot of places which use removeChildNode
directly and hence the object is not removed from the floating or
positioned objects list.

Test: fast/block/float/float-not-removed-from-first-letter.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::removeChild):

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode):

LayoutTests:

  • fast/block/float/float-not-removed-from-first-letter-expected.txt: Added.
  • fast/block/float/float-not-removed-from-first-letter.html: Added.
1:43 PM Changeset in webkit [116682] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove empty ElementAttributeData destructor.
<http://webkit.org/b/86126>

Reviewed by Antti Koivisto.

  • dom/ElementAttributeData.cpp:
  • dom/ElementAttributeData.h:
1:24 PM Changeset in webkit [116681] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: heap snapshot comparison view is broken
https://bugs.webkit.org/show_bug.cgi?id=86102

Reviewed by Pavel Feldman.

Pass HeapSnapshotProxy instead of undefined to the profile load callback. Added
compiler annotations to avoid such errors in the future.

  • inspector/front-end/HeapSnapshotView.js:
1:24 PM Changeset in webkit [116680] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium gardening. Updated failed tests.

  • platform/chromium/test_expectations.txt:
1:10 PM Changeset in webkit [116679] by zandobersek@gmail.com
  • 8 edits in trunk

[GTK] ENABLE_IFRAME_SEAMLESS support
https://bugs.webkit.org/show_bug.cgi?id=85843

Reviewed by Eric Seidel.

.:

Add a configuration option for enabling the iframe seamless
attribute support, enabling it by default.

  • configure.ac:

Source/WebCore:

Export the ENABLE_IFRAME_SEAMLESS feature define when the feature is
enabled.

No new tests - all the related tests should now be passing.

  • GNUmakefile.am:

Tools:

Add the iframe-seamless option to the options list. This makes it
possible to enable the iframe seamless support through build-webkit
script. Enabled by default for all the ports.

  • Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Remove test expectations for the iframe seamless tests. All these
tests should be passing now as the feature is enabled.

  • platform/gtk/test_expectations.txt:
12:57 PM Changeset in webkit [116678] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed Qt gardening.

  • platform/qt/Skipped:

Skipped the test as it fails only on Qt (double-checked locally on Mac),
the difference is very small and likely minor.

12:52 PM Changeset in webkit [116677] by Antti Koivisto
  • 5 edits in trunk/Source/WebCore

Inline Node::traverseNextNode
https://bugs.webkit.org/show_bug.cgi?id=85844

Reviewed by Ryosuke Niwa.

Inline traverseNextNode and traverseNextSibling to reduce entry/exit overhead and allow better code generation
for many hot loops.

In this version only the firstChild()/nextSibling() tests are inlined and the ancestor traversal is not.

Performance bots will tell if this was worthwhile.

  • dom/ContainerNode.h:

(WebCore::Node::traverseNextNode):
(WebCore):
(WebCore::Node::traverseNextSibling):

  • dom/Node.cpp:

(WebCore::Node::traverseNextAncestorSibling):

  • dom/Node.h:

(Node):

12:50 PM BuildingGtk edited by mrobinson@webkit.org
(diff)
12:28 PM Changeset in webkit [116676] by rakuco@webkit.org
  • 3 edits in trunk/Tools

[EFL][webkitpy] Do not redefine check_build() in EflPort.
https://bugs.webkit.org/show_bug.cgi?id=86124

Reviewed by Dirk Pranke.

Remove an old FIXME and do not redefine check_build in EflPort;
once build-dumprendertree recognizes --efl, we can use the
check_build implementation in WebKitPort.

  • Scripts/build-dumprendertree:
  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort.check_build):

12:17 PM Changeset in webkit [116675] by tommyw@google.com
  • 2 edits in trunk/Source/WebCore

MediaStream API: Fix MediaHints parsing
https://bugs.webkit.org/show_bug.cgi?id=86098

Reviewed by Adam Barth.

Not currently testable. Working on a series of patches that will fix that.

  • Modules/mediastream/PeerConnection00.cpp:

(WebCore::PeerConnection00::createMediaHints):

12:11 PM Changeset in webkit [116674] by tommyw@google.com
  • 4 edits in trunk

[chromium] MediaStream API: Fix the ExtraData functionality in WebMediaStreamDescriptor
https://bugs.webkit.org/show_bug.cgi?id=86087

Reviewed by Adam Barth.

Source/WebCore:

Not easy to test but I have added code that excercises this to WebUserMediaClientMock (in DumpRenderTree).

  • platform/chromium/support/WebMediaStreamDescriptor.cpp:

(WebKit::WebMediaStreamDescriptor::setExtraData):

Tools:

  • DumpRenderTree/chromium/WebUserMediaClientMock.cpp:

(MockExtraData):
(WebKit):
(WebKit::WebUserMediaClientMock::requestUserMedia):

12:01 PM Changeset in webkit [116673] by barraclough@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

Remove op_get_callee

Rubber stamped by Geoff Garen.

This is now redundant.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):

  • bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

  • jit/JIT.h:
  • jit/JITOpcodes.cpp:

(JSC):

  • jit/JITOpcodes32_64.cpp:

(JSC):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
11:47 AM Changeset in webkit [116672] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: search title is shown beside the search field (not under) in the vertical mode.
https://bugs.webkit.org/show_bug.cgi?id=86120

Reviewed by Yury Semikhatsky.

This change makes search title render as placeholder at all times.
It also adjusts the size of the search field when navigation arrows appear.

  • inspector/front-end/SearchController.js:

(WebInspector.SearchController):
(WebInspector.SearchController.prototype.updateSearchLabel):
(WebInspector.SearchController.prototype._updateSearchNavigationButtonState):
(WebInspector.SearchController.prototype._createSearchNavigationButton):

  • inspector/front-end/inspector.css:

(#toolbar-search-item):
(.with-navigation-buttons #search):
(.toolbar-search-navigation-label):
(.with-navigation-buttons .toolbar-search-navigation-label):

  • inspector/front-end/inspector.html:
11:42 AM Changeset in webkit [116671] by commit-queue@webkit.org
  • 10 edits
    2 adds in trunk

[chromium] Trigger context menu for long press gesture
https://bugs.webkit.org/show_bug.cgi?id=85919

Patch by Varun Jain <varunjain@google.com> on 2012-05-10
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/events/touch/gesture/context-menu-on-long-press.html

  • page/EventHandler.cpp:

(WebCore):
(WebCore::EventHandler::sendContextMenuEventForGesture):

  • page/EventHandler.h:

(EventHandler):

Source/WebKit/chromium:

  • src/PageWidgetDelegate.cpp:

(WebKit::PageWidgetDelegate::handleInputEvent):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):

Tools:

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::EventSender):
(EventSender::gestureLongPress):
(EventSender::gestureEvent):

  • DumpRenderTree/chromium/EventSender.h:

(EventSender):

LayoutTests:

  • fast/events/touch/gesture/context-menu-on-long-press.html: Added.
  • platform/chromium/fast/events/touch/gesture/context-menu-on-long-press-expected.txt: Added.
11:40 AM Changeset in webkit [116670] by barraclough@apple.com
  • 21 edits in trunk/Source/JavaScriptCore

Cache inheritorID on JSFunction
https://bugs.webkit.org/show_bug.cgi?id=85853

Reviewed by Geoff Garen & Filip Pizlo.

An object's prototype is indicated via its structure. To create an otherwise
empty object with object A as its prototype, we require a structure with its
prototype set to point to A. We wish to use this same structure for all empty
objects created with a prototype of A, so we presently store this structure as
a property of A, known as the inheritorID.

When a function F is invoked as a constructor, where F has a property 'prototype'
set to point to A, in order to create the 'this' value for the constructor to
use the following steps are taken:

  • the 'prototype' proptery of F is read, via a regular Get? access.
  • the inheritorID internal property of the prototype is read.
  • a new, empty object is constructed with its structure set to point to inheritorID.

There are two drawbacks to the current approach:

  • it requires that every object has an inheritorID field.
  • it requires a Get? access on every constructor call to access the 'prototype' property.

Instead, switch to caching a copy of the inheritorID on the function. Constructor
calls now only need read the internal property from the callee, saving a Get?.
This also means that JSObject::m_inheritorID is no longer commonly read, and in a
future patch we can move to storing this in a more memory efficient fashion.

(JSC::CodeBlock::dump):

  • bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateJSFunction):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_create_this):
(JSC::JIT::emitSlow_op_create_this):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_create_this):
(JSC::JIT::emitSlow_op_create_this):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/JSFunction.cpp:

(JSC::JSFunction::JSFunction):
(JSC::JSFunction::cacheInheritorID):
(JSC):
(JSC::JSFunction::put):
(JSC::JSFunction::defineOwnProperty):

  • runtime/JSFunction.h:

(JSC::JSFunction::cachedInheritorID):
(JSFunction):
(JSC::JSFunction::offsetOfCachedInheritorID):

11:39 AM Changeset in webkit [116669] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash in ApplyStyleCommand::joinChildTextNodes.
https://bugs.webkit.org/show_bug.cgi?id=85939

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: editing/style/apply-style-join-child-text-nodes-crash.html

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): add conditions
to bail out if our start and end position nodes are removed due to
mutation events in joinChildTextNodes.
(WebCore::ApplyStyleCommand::applyInlineStyle): this executes after
applyRelativeFontStyleChange in ApplyStyleCommand::doApply. So, need
to bail out if our start and end position nodes are removed due to
mutation events.
(WebCore::ApplyStyleCommand::joinChildTextNodes): hold all the children
in a ref vector to prevent them from getting destroyed due to mutation events.

LayoutTests:

  • editing/style/apply-style-join-child-text-nodes-crash-expected.txt: Added.
  • editing/style/apply-style-join-child-text-nodes-crash.html: Added.
11:38 AM Changeset in webkit [116668] by toyoshim@chromium.org
  • 4 edits
    1 copy
    21 adds in trunk/Tools

don't use autoinstall to import pywebsocket but check it in WebKit directly.
https://bugs.webkit.org/show_bug.cgi?id=86107

Reviewed by Adam Barth.

This change removes pywebsocket from webkitpy's autoinstall list and
imports pywebsocket 0.7.4 directly into webkitpy/thirparty.

  • Scripts/webkitpy/layout_tests/servers/websocket_server.py:

(PyWebSocket._prepare_config):

  • Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook.find_module):
(AutoinstallImportHook._install_irc):

  • Scripts/webkitpy/thirdparty/init_unittest.py:

(ThirdpartyTest.test_import_hook.MockImportHook.init):
(ThirdpartyTest.test_import_hook.MockImportHook._install_eliza):
(ThirdpartyTest):
(ThirdpartyTest.test_import_hook):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/COPYING: Added.
  • Scripts/webkitpy/thirdparty/mod_pywebsocket/init.py: Added.
  • Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py: Added.

(ConnectionTerminatedException):
(InvalidFrameException):
(BadOperationException):
(UnsupportedFrameException):
(InvalidUTF8Exception):
(StreamBase):
(StreamBase.init):
(StreamBase._read):
(StreamBase._write):
(StreamBase.receive_bytes):
(StreamBase._read_until):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hixie75.py: Added.

(for):
(StreamHixie75):
(StreamHixie75.for):
(StreamHixie75.init):
(StreamHixie75.send_message):
(StreamHixie75._read_payload_length_hixie75):
(StreamHixie75.receive_message):
(StreamHixie75._send_closing_handshake):
(StreamHixie75.close_connection):
(StreamHixie75.send_ping):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py: Added.

(Frame):
(Frame.init):
(create_length_header):
(create_header):
(_build_frame):
(_filter_and_format_frame_object):
(create_binary_frame):
(create_text_frame):
(FragmentedFrameBuilder):
(FragmentedFrameBuilder.to):
(FragmentedFrameBuilder.init):
(FragmentedFrameBuilder.build):
(_create_control_frame):
(create_ping_frame):
(create_pong_frame):
(create_close_frame):
(StreamOptions):
(StreamOptions.init):
(Stream):
(Stream.for):
(Stream.init):
(Stream._receive_frame):
(Stream._receive_frame_as_frame_object):
(Stream.send_message):
(Stream.receive_message):
(Stream._send_closing_handshake):
(Stream.close_connection):
(Stream.send_ping):
(Stream._send_pong):
(Stream._drain_received_data):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py: Added.

(is_control_opcode):
(ExtensionParameter):
(ExtensionParameter.init):
(ExtensionParameter.name):
(ExtensionParameter.add_parameter):
(ExtensionParameter.get_parameters):
(ExtensionParameter.get_parameter_names):
(ExtensionParameter.has_parameter):
(ExtensionParameter.get_parameter_value):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py: Added.

(DispatchException):
(DispatchException.init):
(_default_passive_closing_handshake_handler):
(_normalize_path):
(_create_path_to_resource_converter):
(_create_path_to_resource_converter.converter):
(_enumerate_handler_file_paths):
(_HandlerSuite):
(_HandlerSuite.init):
(_source_handler_file):
(_extract_handler):
(Dispatcher):
(Dispatcher.maintains):
(Dispatcher.init):
(Dispatcher.add_resource_path_alias):
(Dispatcher.source_warnings):
(Dispatcher.do_extra_handshake):
(Dispatcher.transfer_data):
(Dispatcher.passive_closing_handshake):
(Dispatcher.get_handler_suite):
(Dispatcher._source_handler_files_in_dir):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py: Added.

(ExtensionProcessorInterface):
(ExtensionProcessorInterface.get_extension_response):
(ExtensionProcessorInterface.setup_stream_options):
(DeflateStreamExtensionProcessor):
(DeflateStreamExtensionProcessor.init):
(DeflateStreamExtensionProcessor.get_extension_response):
(DeflateStreamExtensionProcessor.setup_stream_options):
(DeflateFrameExtensionProcessor):
(DeflateFrameExtensionProcessor.init):
(DeflateFrameExtensionProcessor.get_extension_response):
(DeflateFrameExtensionProcessor.setup_stream_options):
(DeflateFrameExtensionProcessor.setup_stream_options._OutgoingFilter):
(DeflateFrameExtensionProcessor.setup_stream_options._OutgoingFilter.init):
(DeflateFrameExtensionProcessor.setup_stream_options._OutgoingFilter.filter):
(DeflateFrameExtensionProcessor.setup_stream_options._IncomingFilter):
(DeflateFrameExtensionProcessor.setup_stream_options._IncomingFilter.init):
(DeflateFrameExtensionProcessor.setup_stream_options._IncomingFilter.filter):
(DeflateFrameExtensionProcessor.set_response_window_bits):
(DeflateFrameExtensionProcessor.set_response_no_context_takeover):
(DeflateFrameExtensionProcessor.enable_outgoing_compression):
(DeflateFrameExtensionProcessor.disable_outgoing_compression):
(DeflateFrameExtensionProcessor._outgoing_filter):
(DeflateFrameExtensionProcessor._incoming_filter):
(get_extension_processor):
(get_extension_processor.is):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/init.py: Added.

(try):
(do_handshake):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py: Added.

(AbortedByUserException):
(HandshakeException):
(HandshakeException.init):
(VersionException):
(VersionException.init):
(get_default_port):
(validate_subprotocol):
(parse_host_header):
(format_header):
(build_location):
(get_mandatory_header):
(validate_mandatory_header):
(check_request_line):
(check_header_lines):
(parse_token_list):
(_parse_extension_param):
(_parse_extension):
(parse_extensions):
(format_extensions):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/draft75.py: Added.

(Handshaker):
(Handshaker.performs):
(Handshaker.init):
(Handshaker.do_handshake):
(Handshaker._set_resource):
(Handshaker._set_origin):
(Handshaker._set_location):
(Handshaker._set_subprotocol):
(Handshaker._set_protocol_version):
(Handshaker._sendall):
(Handshaker._send_handshake):
(Handshaker._check_header_lines):
(Handshaker._check_first_lines):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py: Added.

(compute_accept):
(Handshaker):
(Handshaker.init):
(Handshaker._validate_connection_header):
(Handshaker.do_handshake):
(Handshaker._get_origin):
(Handshaker._check_version):
(Handshaker._set_protocol):
(Handshaker._parse_extensions):
(Handshaker._validate_key):
(Handshaker._get_key):
(Handshaker._send_handshake):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py: Added.

(Handshaker):
(Handshaker.init):
(Handshaker.do_handshake):
(Handshaker._set_resource):
(Handshaker._set_subprotocol):
(Handshaker._set_location):
(Handshaker._set_origin):
(Handshaker._set_protocol_version):
(Handshaker._set_challenge_response):
(Handshaker._get_key_value):
(Handshaker._get_challenge):
(Handshaker._send_handshake):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py: Added.

(ApacheLogHandler):
(ApacheLogHandler.init):
(ApacheLogHandler.emit):
(_configure_logging):
(_parse_option):
(_create_dispatcher):
(headerparserhandler):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/http_header_util.py: Added.

(_is_char):
(_is_ctl):
(ParsingState):
(ParsingState.init):
(peek):
(consume):
(consume_string):
(consume_lws):
(consume_lwses):
(consume_token):
(consume_token_or_quoted_string):
(quote_if_necessary):
(parse_uri):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/memorizingfile.py: Added.

(MemorizingFile):
(MemorizingFile.init):
(MemorizingFile.getattribute):
(MemorizingFile.readline):
(MemorizingFile.get_memorized_lines):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/msgutil.py: Added.

(close_connection):
(send_message):
(receive_message):
(send_ping):
(MessageReceiver):
(MessageReceiver.receives):
(MessageReceiver.provides):
(MessageReceiver.should):
(MessageReceiver.init):
(MessageReceiver.run):
(MessageReceiver.receive):
(MessageReceiver.receive_nowait):
(MessageReceiver.stop):
(MessageSender):
(MessageSender.sends):
(MessageSender.provides):
(MessageSender.should):
(MessageSender.init):
(MessageSender.run):
(MessageSender.send):
(MessageSender.send_nowait):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py: Added.

(_StandaloneConnection):
(_StandaloneConnection.init):
(_StandaloneConnection.get_local_addr):
(_StandaloneConnection.get_remote_addr):
(_StandaloneConnection.write):
(_StandaloneConnection.read):
(_StandaloneConnection.get_memorized_lines):
(_StandaloneRequest):
(_StandaloneRequest.init):
(_StandaloneRequest.get_uri):
(_StandaloneRequest.get_method):
(_StandaloneRequest.is_https):
(_StandaloneRequest._drain_received_data):
(_StandaloneSSLConnection):
(_StandaloneSSLConnection.for):
(_StandaloneSSLConnection.init):
(_StandaloneSSLConnection.getattribute):
(_StandaloneSSLConnection.setattr):
(_StandaloneSSLConnection.makefile):
(WebSocketServer):
(WebSocketServer.init):
(WebSocketServer._create_sockets):
(WebSocketServer.server_bind):
(WebSocketServer.server_activate):
(WebSocketServer.server_close):
(WebSocketServer.fileno):
(WebSocketServer.handle_error):
(WebSocketServer.get_request):
(WebSocketServer.serve_forever):
(WebSocketServer.shutdown):
(WebSocketRequestHandler):
(WebSocketRequestHandler.setup):
(WebSocketRequestHandler.setup.SocketServer):
(WebSocketRequestHandler.init):
(WebSocketRequestHandler.parse_request):
(WebSocketRequestHandler.log_request):
(WebSocketRequestHandler.log_error):
(WebSocketRequestHandler.is_cgi):
(_configure_logging):
(_alias_handlers):
(_build_option_parser):
(ThreadMonitor):
(ThreadMonitor.init):
(ThreadMonitor.run):
(_parse_args_and_config):
(_main):
(_main.if):
(_main.if.check_script):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/stream.py: Copied from Tools/Scripts/webkitpy/thirdparty/init_unittest.py.
  • Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py: Added.

(get_stack_trace):
(prepend_message_to_exception):
(translate_interp):
(get_script_interp):
(wrap_popen3_for_win):
(wrap_popen3_for_win.
wrap_popen3):
(hexify):
(get_class_logger):
(NoopMasker):
(NoopMasker.init):
(NoopMasker.mask):
(RepeatedXorMasker):
(RepeatedXorMasker.init):
(RepeatedXorMasker.mask):
(DeflateRequest):
(DeflateRequest.for):
(DeflateRequest.init):
(DeflateRequest.getattribute):
(DeflateRequest.setattr):
(_Deflater):
(_Deflater.init):
(_Deflater.compress_and_flush):
(_Inflater):
(_Inflater.init):
(_Inflater.decompress):
(_Inflater.append):
(_Inflater.reset):
(_RFC1979Deflater):
(_RFC1979Deflater.that):
(_RFC1979Deflater.init):
(_RFC1979Deflater.filter):
(_RFC1979Inflater):
(_RFC1979Inflater.for):
(_RFC1979Inflater.init):
(_RFC1979Inflater.filter):
(DeflateSocket):
(DeflateSocket.for):
(DeflateSocket.init):
(DeflateSocket.recv):
(DeflateSocket.sendall):
(DeflateSocket.send):
(DeflateConnection):
(DeflateConnection.for):
(DeflateConnection.init):
(DeflateConnection.get_remote_addr):
(DeflateConnection.put_bytes):
(DeflateConnection.read):
(DeflateConnection.write):
(_is_ewouldblock_errno):
(drain_received_data):

11:34 AM Changeset in webkit [116667] by kerz@chromium.org
  • 2 edits in branches/chromium/1132/Source/WebCore

Merge 116316 - [chromium] setContentsMemoryAllocationLimitBytes needs to setNeedsCommit.
https://bugs.webkit.org/show_bug.cgi?id=85801

Patch by Michal Mocny <mmocny@google.com> on 2012-05-07
Reviewed by Adrienne Walker.

CCLayerTreeHost::setContentsMemoryAllocationLimitBytes needs to call setNeedsCommit after adjusting memory
limits, so that we push a new frame. In particular, when returning from non visibile state, we adjust
memory allocation from 0 to non 0, and we need to push a non blank frame.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::setContentsMemoryAllocationLimitBytes):

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10332095

11:25 AM Changeset in webkit [116666] by pilgrim@chromium.org
  • 11 edits in trunk/Source

[Chromium] Remove dead code behind unused WEBKIT_USING_CG
https://bugs.webkit.org/show_bug.cgi?id=86018

Reviewed by Adam Barth.

We never use CoreGraphics as the backend for GraphicsContext in
Chromium, so this is all dead code.

Source/Platform:

  • chromium/public/WebCanvas.h:

(WebKit):

  • chromium/public/WebImage.h:

(WebImage):

Source/WebKit/chromium:

  • README:
  • src/PageOverlay.cpp:
  • src/WebContentLayerImpl.cpp:

(WebKit::WebContentLayerImpl::paintContents):

  • src/WebFontImpl.cpp:

(WebKit::WebFontImpl::drawText):

  • src/WebImageDecoder.cpp:

(WebKit::WebImageDecoder::getFrameAtIndex):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::paint):
(WebKit::WebPluginContainerImpl::printPage):

  • src/painting/GraphicsContextBuilder.h:

(WebKit):

11:23 AM Changeset in webkit [116665] by inferno@chromium.org
  • 1 edit
    2 moves in trunk/LayoutTests

Unreviewed. Correct spelling in test name.

  • editing/inserting/insert-paragraph-separator-crash-expected.txt: Renamed from LayoutTests/editing/inserting/insert-paragraph-seperator-crash-expected.txt.
  • editing/inserting/insert-paragraph-separator-crash.html: Renamed from LayoutTests/editing/inserting/insert-paragraph-seperator-crash.html.
11:22 AM Changeset in webkit [116664] by arv@chromium.org
  • 5 edits in trunk/Source/WebCore

Unreviewed, rebaselined run-bindings-tests results.

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::jsTestEventTargetPrototypeFunctionAddEventListener):
(WebCore::jsTestEventTargetPrototypeFunctionRemoveEventListener):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionAddEventListener):
(WebCore::jsTestObjPrototypeFunctionRemoveEventListener):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::wrapSlow):

  • bindings/scripts/test/V8/V8TestException.h:

(WebCore::V8TestException::wrap):

11:15 AM Changeset in webkit [116663] by commit-queue@webkit.org
  • 5 edits
    1 add
    1 delete in trunk/LayoutTests

Test from bug 34875 does not work on chromium/mac
https://bugs.webkit.org/show_bug.cgi?id=85913

Patch by Shezan Baig <shezbaig.wk@gmail.com> on 2012-05-10
Reviewed by Julien Chaffraix.

  • fast/block/positioning/offsetLeft-offsetTop-multicolumn-expected.html: Added.
  • fast/block/positioning/offsetLeft-offsetTop-multicolumn-expected.txt: Removed.
  • fast/block/positioning/offsetLeft-offsetTop-multicolumn.html:

Turned the test back into a ref-test as keeping the test cross-platform and
dumpAsText is proving cumbersome. Apart from that, it also make the test work
cross-browser.

  • platform/chromium/test_expectations.txt:
  • platform/mac/Skipped:
  • platform/qt-mac/Skipped:

Re-enabled the test.

11:15 AM Changeset in webkit [116662] by rakuco@webkit.org
  • 2 edits in trunk/Tools

[EFL][webkitpy] Define the 'wrapper' option in EflPort instead of creating a EflDriver.
https://bugs.webkit.org/show_bug.cgi?id=86117

Reviewed by Adam Barth.

Simplify the code used to wrap driver calls with jhbuild: we can
just define the 'wrapper' option instead of having to create a
Driver class just for that.

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort.init):
(EflPort._port_flag_for_scripts):

11:09 AM Changeset in webkit [116661] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening away IETC crash for now
https://bugs.webkit.org/show_bug.cgi?id=86115

Unreviewed, EFL gardening.

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-05-10

  • platform/efl/test_expectations.txt:
11:05 AM Changeset in webkit [116660] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium gardening. Marked tests as failure.

  • platform/chromium/test_expectations.txt:
10:32 AM Changeset in webkit [116659] by msaboff@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Enh: Hash Const JSString in Backing Stores to Save Memory
https://bugs.webkit.org/show_bug.cgi?id=86024

Reviewed by Filip Pizlo.

During garbage collection, each marking thread keeps a HashMap of
strings. While visiting via MarkStack::copyAndAppend(), we check to
see if the string we are visiting is already in the HashMap. If not
we add it. If so, we change the reference to the current string we're
visiting to the prior string.

To somewhat reduce the performance impact of this change, if a string
is unique at the end of a marking it will not be checked during further
GC phases. In some cases this won't catch all duplicates, but we are
trying to catch the growth of duplicate strings.

  • heap/Heap.cpp:

(JSC::Heap::markRoots):

  • heap/MarkStack.cpp:

(JSC::MarkStackThreadSharedData::resetChildren): New method called by the
main thread to reset the slave threads. This is primarily done to
clear the m_uniqueStrings HashMap.
(JSC):
(JSC::MarkStackThreadSharedData::markingThreadMain):
(JSC::MarkStackThreadSharedData::markingThreadStartFunc):
(JSC::MarkStackThreadSharedData::MarkStackThreadSharedData):
(JSC::MarkStackThreadSharedData::reset):
(JSC::MarkStack::reset): Added call to clear m_uniqueStrings.
(JSC::MarkStack::internalAppend): New method that performs the hash consting.
(JSC::SlotVisitor::copyAndAppend): Changed to call the new hash consting
internalAppend()

  • heap/MarkStack.h:

(MarkStackThreadSharedData):
(MarkStack):
(JSC::MarkStack::sharedData):

  • runtime/JSString.h:

(JSString): Added m_isHashConstSingleton flag, accessors for the flag and
code to initialize the flag.
(JSC::JSString::finishCreation):
(JSC::JSString::isHashConstSingleton):
(JSC::JSString::clearHashConstSingleton):
(JSC::JSString::setHashConstSingleton):
(JSC::JSRopeString::finishCreation):

10:26 AM Changeset in webkit [116658] by tomz@codeaurora.org
  • 6 edits
    7 adds in trunk/LayoutTests

Integrate IETC CSS : values and units tests
https://bugs.webkit.org/show_bug.cgi?id=85307

Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-05-10
Reviewed by Adam Barth.

Added the IETC values and unit tests and associated reference tests.

Also removed two "file not found" test entries in the mac test_expectations.txt
file that were causing a style check failure.

  • ietestcenter/css3/valuesandunits/units-000-expected.htm: Added.
  • ietestcenter/css3/valuesandunits/units-000.htm: Added.
  • ietestcenter/css3/valuesandunits/units-010-expected.htm: Added.
  • ietestcenter/css3/valuesandunits/units-010.htm: Added.
  • ietestcenter/css3/valuesandunits/units-020-expected.htm: Added.
  • ietestcenter/css3/valuesandunits/units-020.htm: Added.
  • platform/chromium/test_expectations.txt:
  • platform/efl/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
10:15 AM Changeset in webkit [116657] by tonikitoo@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Assertions and assumptions in BackingStoreClient around m_frame and m_frame->view() are invalid
https://bugs.webkit.org/show_bug.cgi?id=86096

Reviewed by Rob Buis.
Patch by Antonio Gomes <agomes@rim.com>

A Frame's FrameView has always to be checked since it is
a volatile object, and gets created and destroyed all the time.

We have been facing a particular issue, where during our automated
interaction tests, the main frame object was being pinch zoomed in
the middle of it creation, and WebKit thread was blocked by a mutex.
In practice, it is a case that would not be possible in a real
world scenario, but shows that the ASSERTs are bogus regardless.

  • WebKitSupport/BackingStoreClient.cpp:

(BlackBerry::WebKit::BackingStoreClient::scrollPosition):
(BlackBerry::WebKit::BackingStoreClient::setScrollPosition):
(BlackBerry::WebKit::BackingStoreClient::maximumScrollPosition):
(BlackBerry::WebKit::BackingStoreClient::viewportSize):
(BlackBerry::WebKit::BackingStoreClient::transformedViewportSize):
(BlackBerry::WebKit::BackingStoreClient::visibleContentsRect):
(BlackBerry::WebKit::BackingStoreClient::contentsSize):

9:54 AM Changeset in webkit [116656] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL][DRT] ewk_view_paint_contents may trigger assertion failure
https://bugs.webkit.org/show_bug.cgi?id=85058

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-05-10
Reviewed by Gustavo Noronha Silva.

Source/WebKit/efl:

Fixing assertion failure triggered in media/media-fragment cases.
The assertion is hit because of a race between scheduleRelayout() and
the EWK's idle tiling painting. This is exposed by test cases
that rapidly insert child nodes to the document which lead to
scheduleRelayout() calls. Using the general purpose defensive
layout function, not causing any extra relayout work if there's
nothing to be done, but still avoiding the assertion failure if
layout is needed.

  • ewk/ewk_view.cpp:

(ewk_view_paint):
(ewk_view_paint_contents):

LayoutTests:

Unskipping media-fragments that pass after the assertion failure was fixed.

  • platform/efl/Skipped:
9:47 AM Changeset in webkit [116655] by arv@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

Add test that makes sure wrappers are setup using the correct window scope
https://bugs.webkit.org/show_bug.cgi?id=85526

Reviewed by Ojan Vafai.

This tests the same thing as the recently removed fast/dom/prototype-inheritance.html test.

  • fast/dom/wrapper-scope-expected.txt: Added.
  • fast/dom/wrapper-scope.html: Added.
  • platform/chromium/test_expectations.txt:
9:45 AM Changeset in webkit [116654] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Test /webkit2/WebKitWebView/resources times out
https://bugs.webkit.org/show_bug.cgi?id=86088

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/tests/TestResources.cpp:

(testWebViewResources): Use webkit_web_view_reload_bypass_cache()
instead of webkit_web_view_reload() to make sure resources are not
read from the cache.

9:44 AM Changeset in webkit [116653] by inferno@chromium.org
  • 7 edits
    2 adds in trunk

Crash in InsertParagraphSeparatorCommand::doApply.
https://bugs.webkit.org/show_bug.cgi?id=84995

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: editing/inserting/insert-paragraph-seperator-crash.html

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::mergeParagraphs): no need of static cast, since
type of enclosingBlock returned is already Element*.

  • editing/IndentOutdentCommand.cpp:

(WebCore::IndentOutdentCommand::tryIndentingAsListItem): no need of static cast, since
type of enclosingBlock returned is already Element*.

  • editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::doApply): RefPtr startBlock to guard against
mutation events.

  • editing/htmlediting.cpp:

(WebCore::enclosingBlock): make sure type of enclosingNode is an element before doing
the static cast. This was already failing in a couple of layout tests. Also, isBlock
check already exists in the function call to enclosingNodeOfType, so don't need it
again on enclosingNode's renderer.

  • editing/htmlediting.h:

(WebCore):

LayoutTests:

  • editing/inserting/insert-paragraph-seperator-crash-expected.txt: Added.
  • editing/inserting/insert-paragraph-seperator-crash.html: Added.
9:38 AM Changeset in webkit [116652] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

[GTK] WK2 misses WebKitSettings for media playback requiring user gestures and inline playback
https://bugs.webkit.org/show_bug.cgi?id=85999

Patch by Simon Pena <Simon Pena> on 2012-05-10
Reviewed by Martin Robinson.

Expose WebKitSettings for media playback requiring user gesture and
media playback allows inline to GTK side.

This adds two properties (mediaPlaybackRequiresUserGesture and
mediaPlaybackAllowsInline), with their setters and getters, to
WebKitSettings. It also updates the WebKitSettings tests so these
two properties are checked, and includes the new methods in the
documentation.

  • UIProcess/API/gtk/WebKitSettings.cpp: added the new properties and

their accessors
(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_set_media_playback_requires_user_gesture):
(webkit_settings_get_media_playback_requires_user_gesture):
(webkit_settings_set_media_playback_allows_inline):
(webkit_settings_get_media_playback_allows_inline):

  • UIProcess/API/gtk/WebKitSettings.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: included the new

methods in the documentation

  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp: tested the newly

added methods
(testWebKitSettings):

9:33 AM Changeset in webkit [116651] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Missing field initializers for WKPageLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=86005

Patch by Simon Pena <Simon Pena> on 2012-05-10
Reviewed by Martin Robinson.

Initialize willGoToBackForwardListItem and
interactionOccurredWhileProcessUnresponsive fields of
WKPageLoaderClient.

  • UIProcess/API/gtk/WebKitLoaderClient.cpp:

(attachLoaderClientToView):

9:17 AM Changeset in webkit [116650] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

TouchAdjustment doesn't correct for scroll-offsets.
https://bugs.webkit.org/show_bug.cgi?id=86083

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-10
Reviewed by Kenneth Rohde Christiansen.

Already tested by: touchadjustment/scroll-delegation

  • page/EventHandler.cpp:

(WebCore::EventHandler::bestClickableNodeForTouchPoint):
(WebCore::EventHandler::bestZoomableAreaForTouchPoint):

  • page/TouchAdjustment.cpp:

(WebCore::TouchAdjustment::findNodeWithLowestDistanceMetric):

  • testing/Internals.cpp:

(WebCore::Internals::bestZoomableAreaForTouchPoint):

8:59 AM Changeset in webkit [116649] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix typo in filename
https://bugs.webkit.org/show_bug.cgi?id=86095

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-05-10
Reviewed by Andreas Kling.

  • UseJSC.cmake:
8:35 AM Changeset in webkit [116648] by kenneth@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Double tap to zoom is considered a user interaction
https://bugs.webkit.org/show_bug.cgi?id=86094

Reviewed by Simon Hausmann.

This makes it so that the content size change doesn't change scale
after a double tap to zoom.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):

8:22 AM Changeset in webkit [116647] by schenney@chromium.org
  • 5 edits
    1 add in trunk

SVG Filters allow invalid elements as children
https://bugs.webkit.org/show_bug.cgi?id=83979

Reviewed by Nikolas Zimmermann.

.:

This test will crash upon load in Chromium, unless the associated fix is in.

  • ManualTests/bugzilla-83979.svg: Added.

Source/WebCore:

According to the SVG spec, there are numerous restrictions on the
content of nodes (that is, their children). Specific to this problem,
SVGFilter elements may only contain SVGFilterPrimitive elements, and
those may only contain animation related elements. This patch enforces
the restriction on filters in the render tree, thus preventing us from
having (for instance) content that is inside a filter yet filtered by
the filter.

Manual test: ManualTests/bugzilla-83979.svg

  • svg/SVGFilterElement.cpp:

(WebCore::SVGFilterElement::childShouldCreateRenderer): Added to only allow renderers for fe* children
(WebCore):

  • svg/SVGFilterElement.h:

(SVGFilterElement):

  • svg/SVGFilterPrimitiveStandardAttributes.h: Do not allow any children at all for fe* elements.

(SVGFilterPrimitiveStandardAttributes):

8:12 AM Changeset in webkit [116646] by kent.hansen@nokia.com
  • 11 edits in trunk/Source/WebKit2

[Qt] Rename QDeclarative* to QQml*
https://bugs.webkit.org/show_bug.cgi?id=86089

Reviewed by Simon Hausmann.

The QtDeclarative module was deprecated in favor of QtQml.

  • Target.pri:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::_q_onReceivedResponseFromDownload):
(QQuickWebViewExperimental::alertDialog):
(QQuickWebViewExperimental::setAlertDialog):
(QQuickWebViewExperimental::confirmDialog):
(QQuickWebViewExperimental::setConfirmDialog):
(QQuickWebViewExperimental::promptDialog):
(QQuickWebViewExperimental::setPromptDialog):
(QQuickWebViewExperimental::authenticationDialog):
(QQuickWebViewExperimental::setAuthenticationDialog):
(QQuickWebViewExperimental::proxyAuthenticationDialog):
(QQuickWebViewExperimental::setProxyAuthenticationDialog):
(QQuickWebViewExperimental::certificateVerificationDialog):
(QQuickWebViewExperimental::setCertificateVerificationDialog):
(QQuickWebViewExperimental::itemSelector):
(QQuickWebViewExperimental::setItemSelector):
(QQuickWebViewExperimental::filePicker):
(QQuickWebViewExperimental::setFilePicker):
(QQuickWebViewExperimental::databaseQuotaDialog):
(QQuickWebViewExperimental::setDatabaseQuotaDialog):
(QQuickWebViewExperimental::schemeDelegates_At):
(QQuickWebViewExperimental::schemeDelegates_Append):
(QQuickWebViewExperimental::schemeDelegates_Count):
(QQuickWebViewExperimental::schemeDelegates_Clear):
(QQuickWebViewExperimental::schemeDelegates):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

  • UIProcess/API/qt/qwebiconimageprovider.cpp:

(QWebIconImageProvider::QWebIconImageProvider):

  • UIProcess/API/qt/qwebiconimageprovider_p.h:
  • UIProcess/API/qt/qwebviewportinfo_p.h:
  • UIProcess/API/qt/tests/tests.pri:
  • UIProcess/qt/QtDialogRunner.h:

(QtDialogRunner):

  • UIProcess/qt/WebPopupMenuProxyQt.h:

(WebPopupMenuProxyQt):

8:10 AM Changeset in webkit [116645] by commit-queue@webkit.org
  • 13 edits
    4 adds in trunk

[CSS3 Backgrounds and Borders] Add background-size to the background shorthand
https://bugs.webkit.org/show_bug.cgi?id=27577

Patch by Joe Thomas <joethomas@motorola.com> on 2012-05-10
Reviewed by Alexis Menard.

Added CSSPropertyBackgroundSize to the background shorthand propery. Added the logic for parsing background-size.
bakground-size appears after background-position followed by a '/'.
The specification related to this change is http://www.w3.org/TR/css3-background/#the-background

Source/WebCore:

Tests: fast/backgrounds/background-shorthand-with-backgroundSize-style.html

fast/backgrounds/size/backgroundSize-in-background-shorthand.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
(WebCore::CSSComputedStyleDeclaration::getBackgroundShorthandValue):
(WebCore):

  • css/CSSComputedStyleDeclaration.h:

(CSSComputedStyleDeclaration):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFillShorthand):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getLayeredShorthandValue):

  • css/StylePropertyShorthand.cpp:

(WebCore):
(WebCore::backgroundShorthand):

LayoutTests:

  • fast/backgrounds/background-shorthand-with-backgroundSize-style-expected.txt: Added.
  • fast/backgrounds/background-shorthand-with-backgroundSize-style.html: Added.
  • fast/backgrounds/size/backgroundSize-in-background-shorthand-expected.html: Added.
  • fast/backgrounds/size/backgroundSize-in-background-shorthand.html: Added.
  • fast/css/getComputedStyle/getComputedStyle-background-shorthand-expected.txt:
  • fast/css/getComputedStyle/getComputedStyle-background-shorthand.html:
  • fast/inspector-support/style-expected.txt:
  • inspector/styles/lazy-computed-style-expected.txt:
  • inspector/styles/styles-computed-trace-expected.txt:
  • inspector/styles/styles-new-API-expected.txt:
7:43 AM Changeset in webkit [116644] by morrita@google.com
  • 4 edits in trunk/Source/WebCore

Node::InDetachFlag could be removed.
https://bugs.webkit.org/show_bug.cgi?id=85963

Reviewed by Antti Koivisto.

Removed Node::inDetach() since it can never true
on the only call site setFocusedNode().

No new test. Covered by existing tests.

  • dom/Document.cpp:

(WebCore::Document::setFocusedNode):

  • dom/Node.cpp:

(WebCore::Node::detach):

  • dom/Node.h:

(WebCore):
(Node):

7:32 AM FeatureFlags edited by tkent@chromium.org
Add MEDIA_CAPTURE (diff)
7:23 AM Changeset in webkit [116643] by kareng@chromium.org
  • 16 edits in branches/chromium/1132/Source

Merge 116319 - Unreviewed, rolling out r115525.
http://trac.webkit.org/changeset/115525
https://bugs.webkit.org/show_bug.cgi?id=66683

Too many pages rely on DOMTimeStamp as first argument.
Reverting while we consider next steps.

Source/WebCore:

  • WebCore.exp.in:
  • bindings/js/JSRequestAnimationFrameCallbackCustom.cpp:

(WebCore::JSRequestAnimationFrameCallback::handleEvent):

  • dom/Document.cpp:

(WebCore::Document::serviceScriptedAnimations):

  • dom/Document.h:

(Document):

  • dom/RequestAnimationFrameCallback.h:

(RequestAnimationFrameCallback):

  • dom/RequestAnimationFrameCallback.idl:
  • dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::ScriptedAnimationController):
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
(WebCore):
(WebCore::ScriptedAnimationController::windowScreenDidChange):
(WebCore::ScriptedAnimationController::scheduleAnimation):
(WebCore::ScriptedAnimationController::animationTimerFired):

  • dom/ScriptedAnimationController.h:

(ScriptedAnimationController):
(WebCore::ScriptedAnimationController::displayRefreshFired):

  • page/FrameView.cpp:

(WebCore::FrameView::serviceScriptedAnimations):

  • page/FrameView.h:

(FrameView):

  • platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitor::DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::notifyClients):

  • platform/graphics/DisplayRefreshMonitor.h:

(DisplayRefreshMonitor):

  • platform/graphics/blackberry/DisplayRefreshMonitorBlackBerry.cpp:

(WebCore::DisplayRefreshMonitor::displayLinkFired):

  • platform/graphics/mac/DisplayRefreshMonitorMac.cpp:

(WebCore):
(WebCore::DisplayRefreshMonitor::requestRefreshCallback):
(WebCore::DisplayRefreshMonitor::displayLinkFired):

Source/WebKit/chromium:

  • src/PageWidgetDelegate.cpp:

(WebKit::PageWidgetDelegate::animate):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::updateAnimations):

TBR=nduca@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10391049

7:11 AM Changeset in webkit [116642] by keishi@webkit.org
  • 3 edits in trunk/Source/WebCore

Crash in HTMLFormControlElement::m_fieldSetAncestor
https://bugs.webkit.org/show_bug.cgi?id=86070

Reviewed by Kent Tamura.

No new tests.

The previous patch r115990 didn't completely resolve the crash (Bug 85453)
We don't have a reproducible test case, so we are reverting to the old code for setting m_fieldSetAncestor.

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::HTMLFormControlElement):
(WebCore::HTMLFormControlElement::updateFieldSetAndLegendAncestor):
(WebCore::HTMLFormControlElement::insertedInto): Set m_dataListAncestorState to Unknown because ancestor has changed. Call setNeedsWillValidateCheck because style might need to be updated.
(WebCore::HTMLFormControlElement::removedFrom):
(WebCore::HTMLFormControlElement::disabled):
(WebCore::HTMLFormControlElement::recalcWillValidate):
(WebCore::HTMLFormControlElement::willValidate):
(WebCore::HTMLFormControlElement::setNeedsWillValidateCheck):

  • html/HTMLFormControlElement.h:

(HTMLFormControlElement): Added m_dataListAncestorState.

7:05 AM Changeset in webkit [116641] by commit-queue@webkit.org
  • 15 edits
    1 move in trunk/Source

Web Inspector: rename InspectorBackendStub.js to InspectorBackendCommands.js
https://bugs.webkit.org/show_bug.cgi?id=72306

Source/WebCore:

Changed name for InspectorBackendStub.js to
InspectorBackendCommands.js

Patch by Sam D <dsam2912@gmail.com> on 2012-05-10
Reviewed by Yury Semikhatsky.

No new tests required. File name is changed.

  • DerivedSources.pri:
  • GNUmakefile.am:
  • Target.pri:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.vcproj/copyWebCoreResourceFiles.cmd:
  • WebCore.xcodeproj/project.pbxproj:
  • gyp/copy-inspector-resources.sh:
  • inspector/CodeGeneratorInspector.py:
  • inspector/front-end/InspectorBackendCommands.qrc: Added.
  • inspector/front-end/InspectorBackendStub.qrc: Removed.
  • inspector/front-end/inspector.html:

Source/WebKit:

Changed name for InspectorBackendStub.js to
InspectorBackendCommands.js

Patch by Sam D <dsam2912@gmail.com> on 2012-05-10
Reviewed by Yury Semikhatsky.

  • PlatformBlackBerry.cmake:

Source/WebKit/chromium:

Changed name for InspectorBackendStub.js to InspectorBackendCommands.js

Patch by Sam D <dsam2912@gmail.com> on 2012-05-10
Reviewed by Yury Semikhatsky.

  • WebKit.gyp:
7:04 AM Changeset in webkit [116640] by rakuco@webkit.org
  • 3 edits in trunk/Source/WTF

[EFL] Add OwnPtr specialization for Eina_Hash.
https://bugs.webkit.org/show_bug.cgi?id=85046

Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2012-05-10
Reviewed by Andreas Kling.

Add an override for Eina_Hash for EFL port.

  • wtf/OwnPtrCommon.h:

(WTF):

  • wtf/efl/OwnPtrEfl.cpp:

(WTF::deleteOwnedPtr):
(WTF):

6:48 AM Changeset in webkit [116639] by commit-queue@webkit.org
  • 9 edits in trunk

Unreviewed, rolling out r116633.
http://trac.webkit.org/changeset/116633
https://bugs.webkit.org/show_bug.cgi?id=86093

Breaks EFL tests (Requested by kov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-10

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

  • DumpRenderTree/efl/EventSender.cpp:

(keyDownCallback):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setTabKeyCyclesThroughElements):

LayoutTests:

  • platform/efl/Skipped:
6:42 AM Changeset in webkit [116638] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[EFL] Memory leaks found in EFL DRT
https://bugs.webkit.org/show_bug.cgi?id=85889

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-10
Reviewed by Gustavo Noronha Silva.

Fix two memory leaks in EFL's DRT by using JSRetainPtr for JSString
created with JSStringCreateWithUTF8CString.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::onWindowObjectCleared):

  • DumpRenderTree/efl/EventSender.cpp:

(modifiersFromJSValue):

6:19 AM Changeset in webkit [116637] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

[Qt] Avoid string conversions to construct a QUrl when using Qt5.
https://bugs.webkit.org/show_bug.cgi?id=86006

Reviewed by Kenneth Rohde Christiansen.

In Qt5, the QUrl constructor can handle the string directly, even in UTF-16 because the
constructor QUrl(QString) has been fixed. Unfortunately we still need to use the old
code path when building with Qt4.

No new tests : it's a performance improvement which should be covered by tests.

  • platform/qt/KURLQt.cpp:

(WebCore::KURL::operator QUrl):

6:15 AM Changeset in webkit [116636] by noel.gordon@gmail.com
  • 4 edits in trunk

Source/WebCore: [chromium] REGRESSION(r107389) Visible line artifacts on some JPEG images
https://bugs.webkit.org/show_bug.cgi?id=85772

Reviewed by Kent Tamura.

On some JPEG images, vertical and horizontal lines artifacts might appear in image
regions with very high frequency color variation when using DCT_IFAST decodes. Use
DCT_IFAST on small screen devices only (Chromium Android).

No new tests. Covered by existing tests.

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(dctMethod): Permit DCT_IFAST decoding for Chromium Android only.

LayoutTests: [chromium] REGRESSION(r107389) Visible line artifacts on JPEG images
https://bugs.webkit.org/show_bug.cgi?id=85772

Reviewed by Kent Tamura.

  • platform/chromium/test_expectations.txt: Add IMAGE expectations.
5:55 AM Changeset in webkit [116635] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening of flaky tests
https://bugs.webkit.org/show_bug.cgi?id=86069

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-10

  • platform/efl/test_expectations.txt:
5:39 AM QtWebKitBuildBots edited by Csaba Osztrogonác
Add gardening timetable and list of gardeners. Feel free to join us ;-) (diff)
5:38 AM Changeset in webkit [116634] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/Source/WebKit2

[Qt] Fix sites with a viewport meta tag when devicePixelRatio isn't explicitely set on the WebView
https://bugs.webkit.org/show_bug.cgi?id=86002

Reviewed by Kenneth Rohde Christiansen.

The preference was recently changed to a double ratio, but was still left under
FOR_EACH_WEBKIT_UINT32_PREFERENCE and was initialized to inf instead of 1.0.
This would cause the viewport constraints to apply a multi-millionaire device
pixel ratio and make the contents invisible.

This moves it with other double preferences under FOR_EACH_WEBKIT_DOUBLE_PREFERENCE.

  • Shared/WebPreferencesStore.h:

(WebKit):

5:28 AM Changeset in webkit [116633] by commit-queue@webkit.org
  • 9 edits in trunk

[EFL] LayoutTestController needs implementation of setTabKeyCyclesThroughElements
https://bugs.webkit.org/show_bug.cgi?id=82864

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-05-10
Reviewed by Gustavo Noronha Silva.

Source/WebKit/efl:

Add missing implementation for setTabKeyCyclesThroughElements to EFL's
DumpRenderTreeSupport.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::setTabKeyCyclesThroughElements):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Add missing implementation for setTabKeyCyclesThroughElements to EFL's LayoutTestController
in order to unskip fast/events/keypress-insert-tab.html

  • DumpRenderTree/efl/EventSender.cpp:

(keyDownCallback):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setTabKeyCyclesThroughElements):

LayoutTests:

Unskip fast/events/keypress-insert-tab.html

  • platform/efl/Skipped:
5:20 AM Changeset in webkit [116632] by kenneth@webkit.org
  • 7 edits in trunk/Source

[Qt] Implement fit-to-width behaviour
https://bugs.webkit.org/show_bug.cgi?id=86085

Reviewed by Simon Hausmann.

Source/WebCore:

Add a method to get the minimum scale factor that contains the content
without showing any chrome background.

  • dom/ViewportArguments.cpp:

(WebCore::computeMinimumScaleFactorForContentContained):
(WebCore):

  • dom/ViewportArguments.h:

(WebCore):

Source/WebKit2:

We don't restrict the minimum scale to the layout viewport anymore,
but instead update the minimum scale when the content size changes.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewFlickablePrivate::didChangeViewportProperties):
(QQuickWebViewFlickablePrivate::didChangeContentsSize):

  • UIProcess/API/qt/qwebviewportinfo.cpp:

(QWebViewportInfo::minimumScale):
(QWebViewportInfo::maximumScale):

  • UIProcess/qt/QtViewportInteractionEngine.h:

(QtViewportInteractionEngine):

5:09 AM Changeset in webkit [116631] by vestbo@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Fix \sa usage in documentation

Ensure comma between elements (6 missing).

Patch by Marius Storm-Olsen <marius.storm-olsen@nokia.com> on 2012-05-10
Reviewed by Tor Arne Vestbø.

4:56 AM Changeset in webkit [116630] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL][DRT] EventSender - set delayed event information if it was not set before
https://bugs.webkit.org/show_bug.cgi?id=85972

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-05-10
Reviewed by Gustavo Noronha Silva.

Tools:

Reset delayed event information if it is missing.

  • DumpRenderTree/efl/EventSender.cpp:

(feedOrQueueMouseEvent):

LayoutTests:

Unskipping layout tests that were skipped because of the bug.

  • platform/efl/Skipped:
4:37 AM Changeset in webkit [116629] by morrita@google.com
  • 24 edits in trunk/Source/WebCore

Remove support for Node::willRemove()
https://bugs.webkit.org/show_bug.cgi?id=55209

Reviewed by Ryosuke Niwa.

This change de-virtualizes Node::willRemove(), gains
5% speedup on Dromaeo dom-modify.

Originally there were 5 willRemove() overrides:

  • Element
  • HTMLStyleElement
  • HTMLSourceElement
  • HTMLTrackElement
  • HTMLFrameOwnerElement

For first 4 items, this change moves their implementations to
Node::removedFrom() overrides.

Then HTMLFrameOwnerElement is the only class which needs the
notification. Because it emits the "unload" event, it needs some
notification _before_ its removal. To handle that, this change
introduces ChildFrameDisconnector which collects
corresponding decendant elements and disconnect their content frame.

Even though this approach doesn't kill pre-removal tree traversal
completely, it's a bit more efficient due to the de-virtualization.

No new tests. Covered by existing test.

  • dom/ContainerNode.cpp:

(WebCore::willRemoveChild): Replaced willRemove() call with ChildFrameDisconnector.
(WebCore::willRemoveChildren): Ditto.
(WebCore::ContainerNode::disconnectDescendantFrames): Added. Used from FrameLoader to replace Document::willRemove() call.
(WebCore):

  • dom/ContainerNode.h:

(ContainerNode):

  • dom/ContainerNodeAlgorithms.cpp:

(WebCore::ChildFrameDisconnector::collectDescendant):
(WebCore):
(WebCore::ChildFrameDisconnector::Target::disconnect):

  • dom/ContainerNodeAlgorithms.h:

(ChildFrameDisconnector):
(Target):
(WebCore::ChildFrameDisconnector::Target::Target):
(WebCore::ChildFrameDisconnector::Target::isValid):
(WebCore):
(WebCore::ChildFrameDisconnector::ChildFrameDisconnector):
(WebCore::ChildFrameDisconnector::collectDescendant):
(WebCore::ChildFrameDisconnector::disconnect):

  • dom/Element.cpp:

(WebCore::Element::removedFrom):

  • dom/Element.h:
  • dom/ElementShadow.cpp:
  • dom/ElementShadow.h:

(ElementShadow):

  • dom/Node.cpp:
  • dom/Node.h: Added IsFrameOwnerElement flag to de-virtualize IsFrameOwnerElement().

(WebCore::Node::isFrameOwnerElement): De-virtualized.
(Node):

  • html/HTMLElement.h:

(HTMLElement):
(WebCore::HTMLElement::HTMLElement):

  • html/HTMLFrameOwnerElement.cpp:

(WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement):
(WebCore::HTMLFrameOwnerElement::disconnectContentFrame): Extracted from original willRemove().

  • html/HTMLFrameOwnerElement.h:

(HTMLFrameOwnerElement):
(WebCore::toFrameOwnerElement):
(WebCore):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::sourceWasRemoved): Renamed from sourceWillBeRemoved(), dealing with the timing change.

  • html/HTMLMediaElement.h:

(HTMLMediaElement):
(WebCore::isMediaElement):
(WebCore):
(WebCore::toMediaElement):

  • html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::removedFrom): Moved some code from willRemove().

  • html/HTMLSourceElement.h:

(HTMLSourceElement):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::removedFrom):
(WebCore):

  • html/HTMLStyleElement.h:

(HTMLStyleElement):

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::removedFrom): Moved some code from willRemove().

  • html/HTMLTrackElement.h:

(HTMLTrackElement):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::clear):

4:25 AM Changeset in webkit [116628] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] REGRESSION(r116560): It made 7 compositing tests fail
https://bugs.webkit.org/show_bug.cgi?id=86086

Unreviewed gardening, skip new failing tests.

  • platform/qt-5.0-wk2/Skipped:
4:21 AM Changeset in webkit [116627] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

[Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=85591

Unreviewed, unskipping another batch of tests that are passing but have
test expectations present that indicate a failure is expected. Their
bug entries will be properly updated after they either remain stable and
passing or they backfire.

  • platform/gtk/test_expectations.txt:
4:12 AM Changeset in webkit [116626] by vestbo@webkit.org
  • 4 edits in trunk

WebPageProxy::activeURL() should return the pending API request, even when there's no main frame

https://bugs.webkit.org/show_bug.cgi?id=85806

The m_pendingAPIRequestURL member is used (presumably) to mask over the async
nature of WebKit2, so that starting a load of a URL will reflect that URL
immedeatly from activeURL, even if the request has not been passed over to
the web process yet and reflected there.

This works well, except in the case of the initial request, where the main
frame creation happens on the web process side and is notified back to the
UI process. Until we've recived the notification we don't know about the main
frame, and this race condition will potentially give us an empty url instead
of the pending request.

To solve this we always return the pending API request if it's set, even
when there's no mainframe yet (that we known about).

Reviewed by Simon Hausmann.

3:56 AM Changeset in webkit [116625] by commit-queue@webkit.org
  • 7 edits in trunk

[EFL][DRT] Clear added user style sheets before a new testcase execution.
https://bugs.webkit.org/show_bug.cgi?id=84792

Source/WebKit/efl:

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-10
Reviewed by Gustavo Noronha Silva.

Add a helper function for clearing of the added user style sheets.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::clearUserStyleSheets):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Reviewed Gustavo Noronha Silva.

The added user style sheets from the previous testcases are cleared in order to avoid
flaky results.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-10

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

LayoutTests:

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-10
Reviewed by Gustavo Noronha Silva.

Unskip userscripts/user-style-top-frame-only.html

  • platform/efl/Skipped:
3:06 AM Changeset in webkit [116624] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

[EFL][DRT] fast/events/js-keyboard-event-creation.html needs rebaselining
https://bugs.webkit.org/show_bug.cgi?id=85485

Unreviewed, fast/events/js-keyboard-event-creation.html is rebased.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-10

  • platform/efl/Skipped: removed fast/events/js-keyboard-event-creation.html
  • platform/efl/fast/events/js-keyboard-event-creation-expected.txt: Added (Taken from GTK port).
2:59 AM Changeset in webkit [116623] by kinuko@chromium.org
  • 3 edits in trunk/Source/WebCore

Change the return type of Entry.toURL() back to String from KURL
https://bugs.webkit.org/show_bug.cgi?id=85858

Reviewed by Ryosuke Niwa.

I once changed it from String to KURL in r116273 but it turned out that
it involves implicit conversion and may incur extra overhead.
This partly reverts r116273 while keeping some internal functions
returning KURL as it's what we initially create as and is more
convenient to operate on.

No new tests; no functional or visible changes.

  • Modules/filesystem/EntryBase.cpp:

(WebCore::EntryBase::toURL):

  • Modules/filesystem/EntryBase.h:

(EntryBase):

2:23 AM Changeset in webkit [116622] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip news failing and crashing tests to paint the bot green.

  • platform/qt-mac/Skipped:
1:26 AM Changeset in webkit [116621] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] new test http/tests/cookies/single-quoted-value.html is failing
https://bugs.webkit.org/show_bug.cgi?id=86066

Unreviewed gardening after r116601

  • platform/qt/Skipped:
1:00 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
(diff)
12:53 AM Changeset in webkit [116620] by fpizlo@apple.com
  • 2 edits in branches/dfgopt/Source/JavaScriptCore

DFG should allow inlining in case of certain arity mismatches
https://bugs.webkit.org/show_bug.cgi?id=86059

Reviewed by Geoff Garen.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleInlining):

12:48 AM Changeset in webkit [116619] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Autocomplete for CSS property values in the Styles pane behaving incorrectly
https://bugs.webkit.org/show_bug.cgi?id=85784

Reviewed by Vsevolod Vlasov.

Before executing the number increment/decrement within CSS property value, the current word is checked
for being a valid suggestion for the current property, and if it is, the numeric change is skipped
in favor of the suggested property value switch by a suggest box.

  • inspector/front-end/StylesSidebarPane.js:
12:42 AM Changeset in webkit [116618] by inferno@chromium.org
  • 4 edits in trunk

Make DOMCharacterDataModified a scoped event (similar to r73690).
https://bugs.webkit.org/show_bug.cgi?id=85920

Reviewed by Ryosuke Niwa.

Source/WebCore:

DOMCharacterDataModified was missing in the list of already scoped
DOM mutation events like DOMSubtreeModified, DOMNodeInserted, etc.
It helps to delay event dispatches until the completion of each call
of EditCommand::doApply. This has been useful in the past and helped to
prevent unexpected DOM tree mutations while the editing command is executing.

  • dom/CharacterData.cpp:

(WebCore::CharacterData::dispatchModifiedEvent):

LayoutTests:

  • fast/events/scoped/editing-commands.html: test modified to check DOMCharacterDataModified event.
12:38 AM Changeset in webkit [116617] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Default to null value for HistoryItem::m_pageScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=84385

Patch by Alexandre Elias <aelias@google.com> on 2012-05-10
Reviewed by Adam Barth.

Previously, HistoryItem::m_pageScaleFactor defaulted to a value
of 1, making it impossible to determine whether this value was never
set, or intentionally set to 1. This patch introduces a default value
of 0 and makes restoreScrollPositionAndViewState not touch the page
scale factor if this value is still present at time of reload.

This is a no-op change for common navigation scenarios. The
motivation for this change is the corner case of syncing history items
from a desktop browser to a mobile device. In that case, we need a
way to specify that the history item does not contain a
pageScaleFactor so that the mobile device does not display the page
overly zoomed in.

No new tests.

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::HistoryItem):

  • loader/HistoryController.cpp:

(WebCore::HistoryController::restoreScrollPositionAndViewState):

12:34 AM Changeset in webkit [116616] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Use suitable viewport values when a Mobile DTD is used.
https://bugs.webkit.org/show_bug.cgi?id=85425

Unreviewed debug buildfix after r116571.

  • dom/Document.cpp:

(WebCore::Document::setDocType):

12:22 AM Changeset in webkit [116615] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[Forms] Move step related methods to InputType class from HTMLInputElement class
https://bugs.webkit.org/show_bug.cgi?id=85978

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-05-10
Reviewed by Kent Tamura.

This patch is part of re-factoring of HTMLInputElement.cpp for numeric input type.
In this patch, we move implementation of getAllowedValueStep and stepUp/stepUpFromRenderer
to InputType class because of these are for DateTime/Number/Range.

Following patches will change implementation of getAllowedValueStep to use StepRange and
remove step related methods, defaultStep, stepScaleFactor, and so on.

No new tests. This patch should not change behavior.

  • html/HTMLInputElement.cpp:

(WebCore):
(WebCore::HTMLInputElement::getAllowedValueStep):
(WebCore::HTMLInputElement::stepUp):
(WebCore::HTMLInputElement::stepDown):
(WebCore::HTMLInputElement::stepUpFromRenderer):

  • html/HTMLInputElement.h:

(HTMLInputElement):

  • html/InputType.cpp:

(WebCore::InputType::applyStep):
(WebCore):
(WebCore::InputType::alignValueForStep):
(WebCore::InputType::getAllowedValueStep):
(WebCore::InputType::getAllowedValueStepWithDecimalPlaces):
(WebCore::InputType::stepUp):
(WebCore::InputType::stepUpFromRenderer):

  • html/InputType.h:

(InputType):

12:19 AM WebInspector edited by uuopii@gmail.com
add info about the weinre experiment (diff)
12:10 AM Changeset in webkit [116614] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/test_expectations.txt:
12:00 AM Changeset in webkit [116613] by tkent@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Mark CCLayerTreeHostTestSetNeedsCommit2.runMultiThread and
CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity.runMultiThread flaky.

  • tests/CCLayerTreeHostTest.cpp:

May 9, 2012:

11:42 PM Changeset in webkit [116612] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/Source/WebKit/chromium

[chromium] Add ability to override user agent string per-WebFrameClient
https://bugs.webkit.org/show_bug.cgi?id=83959

Patch by Dan Alcantara <dfalcantara@chromium.org> on 2012-05-09
Reviewed by Adam Barth.

Adds a method that can be used to override the normal user agent in
chromium. Also adds a unit test to check if the override is taking effect.

  • WebKit.gypi:
  • public/WebFrameClient.h:

(WebFrameClient):
(WebKit::WebFrameClient::userAgent):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::userAgent):

  • tests/FrameLoaderClientImplTest.cpp: Added.

(WebKit):
(TestWebFrameClient):
(WebKit::TestWebFrameClient::setUserAgentOverride):
(FrameLoaderClientImplTest):
(WebKit::FrameLoaderClientImplTest::SetUp):
(WebKit::FrameLoaderClientImplTest::TearDown):
(WebKit::FrameLoaderClientImplTest::setUserAgentOverride):
(WebKit::FrameLoaderClientImplTest::userAgent):
(WebKit::TEST_F):

11:13 PM Changeset in webkit [116611] by tkent@chromium.org
  • 4 edits
    1 add in trunk

Calendar Picker: Fix a crash by changing input type.
https://bugs.webkit.org/show_bug.cgi?id=86007

Reviewed by Hajime Morita.

.:

  • ManualTests/forms/calendar-picker-crash-by-type-change.html: Added.

Source/WebCore:

Manual test: forms/calendar-picker-crash-by-type-change.html

  • html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::~CalendarPickerElement):
Added. Make sure the popup is closed.

  • html/shadow/CalendarPickerElement.h:

(CalendarPickerElement): Add declaration of the destructor.

11:11 PM Changeset in webkit [116610] by gyuyoung.kim@samsung.com
  • 45 edits in trunk

Move suspendAnimations to use Internals interface.
https://bugs.webkit.org/show_bug.cgi?id=85986

Reviewed by Ryosuke Niwa.

.:

  • Source/autotools/symbols.filter: Add a symbol filter for suspendAnimations.

Source/WebCore:

Add suspendAnimations functions, because it is able to work in the
cross-port way through the Internals interface.

No new tests, since we are improving here the infra-structure for testing
a specific method.

  • testing/Internals.cpp:

(WebCore::Internals::suspendAnimations):
(WebCore):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit/efl:

Remove suspendAnimations functions, because it is able to work in the
cross-port way through the Internals interface.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Source/WebKit/gtk:

Remove suspendAnimations functions, because it is able to work in the
cross-port way through the Internals interface.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Source/WebKit/mac:

Remove suspendAnimations functions, because it is able to work in the
cross-port way through the Internals interface.

  • WebKit.order:
  • WebView/WebFrame.mm:
  • WebView/WebFramePrivate.h:

Source/WebKit/qt:

Remove suspendAnimations functions, because it is able to work in the
cross-port way through the Internals interface.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Source/WebKit/win:

Remove suspendAnimations functions, because it is able to work in the
cross-port way through the Internals interface.

  • Interfaces/IWebFramePrivate.idl:
  • WebFrame.cpp:
  • WebFrame.h:

Source/WebKit2:

  • win/WebKit2.def: Add a symbol filter for suspendAnimations.

Tools:

Remove suspendAnimations functions, because it is able to work in the
cross-port way through the Internals interface

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  • DumpRenderTree/qt/LayoutTestControllerQt.h:

(LayoutTestController):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

LayoutTests:

Call suspendAnimations functions from internals, because it is able to work in the
cross-port way through the Internals interface.

  • animations/play-state-suspend.html:
  • animations/stop-animation-on-suspend.html:
  • animations/suspend-resume-animation-events.html:
  • animations/suspend-resume-animation.html:
  • animations/suspend-transform-animation.html:
  • transitions/suspend-transform-transition.html:
10:47 PM Changeset in webkit [116609] by tkent@chromium.org
  • 2 edits in trunk/Tools

[Chromium] Attempt to fix an Android build error.
https://bugs.webkit.org/show_bug.cgi?id=86045

  • DumpRenderTree/DumpRenderTree.gypi:
10:31 PM Changeset in webkit [116608] by creis@chromium.org
  • 9 edits
    1 add in trunk/Source

Source/WebCore: Add dispatchMessageEventWithOriginCheck to DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=85815

Reviewed by Adam Barth.

Useful for ports that support cross-process postMessage.
No new tests, since covered by existing postMessage tests.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessageTimerFired):
(WebCore):
(WebCore::DOMWindow::dispatchMessageEventWithOriginCheck):

  • page/DOMWindow.h:

(WebCore):
(DOMWindow):

Source/WebKit/chromium: Add dispatchMessageEventWithOriginCheck to WebFrame
https://bugs.webkit.org/show_bug.cgi?id=85815

Reviewed by Adam Barth.

Tested by WebFrameTest.DispatchMessageEventWithOriginCheck.
Also fixes source frame bug in willCheckAndDispatchMessageEvent.

  • public/WebFrame.h:

(WebFrame):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::willCheckAndDispatchMessageEvent):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::checkAndDispatchMessageEvent):
(WebKit):

  • src/WebFrameImpl.h:

(WebFrameImpl):

10:08 PM Changeset in webkit [116607] by hbono@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Fix a crash in ContextMenuClientImpl::getCustomMenuFromDefaultItems
https://bugs.webkit.org/show_bug.cgi?id=85866

Reviewed by Ryosuke Niwa.

DocumentMarkerController::markersInRange crashes if the input range is NULL.
This change adds a NULL check before getCustomMenuFromDefaultItems() calls this
function to avoid this crash.

  • src/ContextMenuClientImpl.cpp:

(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Added a NULL check.

9:34 PM Changeset in webkit [116606] by ojan@chromium.org
  • 4 edits in trunk/Tools

Don't show partytime if there are non-layout test failures.
https://bugs.webkit.org/show_bug.cgi?id=86056

Reviewed by Dimitri Glazkov.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
9:14 PM Changeset in webkit [116605] by tkent@chromium.org
  • 4 edits
    1 delete in trunk/Source/WebKit/chromium

Unreviewed, rolling out r116602.
http://trac.webkit.org/changeset/116602
https://bugs.webkit.org/show_bug.cgi?id=86057

Build error on Windows (Requested by tkent on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-09

  • WebKit.gypi:
  • public/WebFrameClient.h:
  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::userAgent):

  • tests/FrameLoaderClientImplTest.cpp: Removed.
9:03 PM Changeset in webkit [116604] by tkent@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Fix compilation warning on Android.
https://bugs.webkit.org/show_bug.cgi?id=85958

  • features.gypi: Move ENABLE_MEDIA_CAPTURE=0 to non-Android block.
8:58 PM Changeset in webkit [116603] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Autofill feature implementation for BlackBerry porting
https://bugs.webkit.org/show_bug.cgi?id=85577

Patch by Jonathan Dong <Jonathan Dong> on 2012-05-09
Reviewed by Rob Buis.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::autofillTextField): Added this interface
function to auto fill the inputting text field when user selects
a autofill candidate value from autofill context dialog.
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::notifyPopupAutofillDialog): Added
this interface function to notify WebPageClient to pop up the autofill
context dialog with the suggested input items.
(BlackBerry::WebKit::WebPage::clearAutofillData):

  • Api/WebPage.h:
  • Api/WebPageClient.h:
  • Api/WebPage_p.h:

(WebCore):
(WebPagePrivate):

  • WebCoreSupport/AutofillManager.cpp:

(WebCore::AutofillManager::didChangeInTextField):

  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::textDidChangeInTextField): Implemented
this function to listen to the notification of text field change, and
notify AutofillManager to handle the autofill.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchWillSubmitForm):
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendSubmitEvent):
Save the name and value pair of every autofillable input text field when
user submitting a form.

8:44 PM Changeset in webkit [116602] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/Source/WebKit/chromium

[chromium] Add ability to override user agent string per-WebFrameClient
https://bugs.webkit.org/show_bug.cgi?id=83959

Patch by Dan Alcantara <dfalcantara@chromium.org> on 2012-05-09
Reviewed by Adam Barth.

Adds a method that can be used to override the normal user agent in
chromium. Also adds a unit test to check if the override is taking effect.

  • WebKit.gypi:
  • public/WebFrameClient.h:

(WebFrameClient):
(WebKit::WebFrameClient::userAgent):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::userAgent):

  • tests/FrameLoaderClientImplTest.cpp: Added.

(WebKit):
(TestWebFrameClient):
(WebKit::TestWebFrameClient::setUserAgentOverride):
(FrameLoaderClientImplTest):
(WebKit::FrameLoaderClientImplTest::SetUp):
(WebKit::FrameLoaderClientImplTest::TearDown):
(WebKit::FrameLoaderClientImplTest::setUserAgentOverride):
(WebKit::FrameLoaderClientImplTest::userAgent):
(WebKit::TEST_F):

8:30 PM Changeset in webkit [116601] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

[BlackBerry] Cookie parsing issue. If the cookie value provided was (") then the browser creates a session cookie instead.
https://bugs.webkit.org/show_bug.cgi?id=85775

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-05-09
Reviewed by Rob Buis.

Source/WebCore:

Make CookieParser::parseOneCookie handle (cookiename="cookievalue;expires=xxxx) correctly.
This cookie's value is "cookievalue not "cookievalue;expires=xxxx.

Test: http/tests/cookies/single-quoted-value.html

  • platform/blackberry/CookieParser.cpp:

(WebCore::CookieParser::parseOneCookie):

LayoutTests:

  • http/tests/cookies/script-tests/single-quoted-value.js: Added.
  • http/tests/cookies/single-quoted-value-expected.txt: Added.
  • http/tests/cookies/single-quoted-value.html: Added.
8:24 PM Changeset in webkit [116600] by hayato@chromium.org
  • 2 edits in trunk/Tools

Improve a warning message for a reftest having an unused expectation file.
https://bugs.webkit.org/show_bug.cgi?id=85975

Reviewed by Adam Barth.

The current warning message is not intuitive. It might be better to update the message
so that it encourage users to remove unused expectation files.

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner.init):

8:08 PM Changeset in webkit [116599] by ojan@chromium.org
  • 12 edits in trunk/Tools

Change "losing test coverage" to cover all non-layout test problems in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=86043

Reviewed by Adam Barth.

-Get rid of the gtest iframe.
-Cover all non-layout test problems. Before we wouldn't catch compile failures
or gtest failures since they were not on the webkit testing bots.
-Include the list of failing steps next to the builder name. This is a lot less
cluttered than you'd expect and already helped me find a compile failure early.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:

Delete unused map.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
7:49 PM WebKit Team edited by creis@chromium.org
Adding Charles Reis as committer. (diff)
7:48 PM Changeset in webkit [116598] by hayato@chromium.org
  • 1 edit
    4 deletes in trunk/LayoutTests

Remove unused test expectation files.
https://bugs.webkit.org/show_bug.cgi?id=85973

Reviewed by Ojan Vafai.

Since cell-shrinkback.html is a reftest, these txt and png
expectations files are not used by test runner and cause warning messages when running tests.

  • platform/chromium-linux/fast/multicol/cell-shrinkback-expected.png: Removed.
  • platform/chromium-win/fast/multicol/cell-shrinkback-expected.png: Removed.
  • platform/qt/fast/multicol/cell-shrinkback-expected.png: Removed.
  • platform/qt/fast/multicol/cell-shrinkback-expected.txt: Removed.
7:45 PM Changeset in webkit [116597] by creis@chromium.org
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Added myself as a committer.

7:32 PM Changeset in webkit [116596] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Add multi-channels support for CopyWithGainFrom in AudioBus
https://bugs.webkit.org/show_bug.cgi?id=80675

Patch by Raymond Liu <raymond.liu@intel.com> on 2012-05-09
Reviewed by Chris Rogers.

  • platform/audio/AudioBus.cpp:

(WebCore):
(WebCore::AudioBus::AudioBus):
(WebCore::AudioBus::copyWithGainFrom):

  • platform/audio/AudioBus.h:

(AudioBus):

7:00 PM Changeset in webkit [116595] by jberlin@webkit.org
  • 24 edits
    1 copy
    3 adds in trunk

Crash using the new WKBundleDOMWindowExtensions APIs.
https://bugs.webkit.org/show_bug.cgi?id=85888

Reviewed by Brady Eidson.

Source/WebCore:

WKBundlePageWillDestroyGlobalObjectForDOMWindowExtensionCallback was only being invoked when
the WKPage was destroyed, and then only for the child frames. In addition, the
DOMWindowExtension was holding onto a destroyed DOMWindow and attempting to unregister from
when the WK2 wrapper object was attempting to destroy the DOMWindowExtension.

The underlying issue here was that the DOMWindowProperties were getting disconnectFrame
and willDetachPage called on them at the wrong times.

Rename DOMWindowProperty::disconnectFrame and reconnectFrame to disconnectFrameForPageCache
and reconnectFrameFromPageCache for clarity.

Only invoke DOMWindowProperty::disconnectFrameForPageCache when the frame is going into the
page cache.

In the cases where the DOMWindow is getting destroyed, the frame is being destroyed, or the
DOMWindow is getting cleared because the frame is being navigated, invoke
DOMWindowProperty::willDestroyGlobalObjectInFrame instead of disconnectFrame.

Invoke DOMWindowProperty::willDetachGlobalObjectFromFrame when a document is being detached
because the frame has been detached (e.g. fast/storage/storage-detached-iframe.html) and
won't be immediately destroyed.

Invoke DOMWindowProperty::willDestroyGlobalObjectInCachedFrame when a cached frame is
being destroyed.

New WK2 API Test: DOMWindowExtensionNoCache.

  • Modules/indexeddb/DOMWindowIndexedDatabase.cpp:

(WebCore::DOMWindowIndexedDatabase::disconnectFrameForPageCache):
Updated for disconnectFrame rename.
(WebCore::DOMWindowIndexedDatabase::reconnectFrameFromPageCache):
Updated for reconnectFrame rename.
(WebCore::DOMWindowIndexedDatabase::willDestroyGlobalObjectInCachedFrame):
Get rid of the suspended IDBFactory.
(WebCore::DOMWindowIndexedDatabase::willDestroyGlobalObjectInFrame):
Get rid of the IDBFactory.
(WebCore::DOMWindowIndexedDatabase::willDetachGlobalObjectFromFrame):
Ditto.

  • Modules/indexeddb/DOMWindowIndexedDatabase.h:
  • dom/Document.cpp:

(WebCore::Document::prepareForDestruction):
Tell the DOMWindow before detaching the Document.

  • dom/Document.h:
  • history/CachedFrame.cpp:

(WebCore::CachedFrame::destroy):
Tell the DOMWindow.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::clear):
Use Document::prepareForDestruction so that the DOMWindow is told about the main frame
navigation before detaching the Document.

  • loader/appcache/DOMApplicationCache.cpp:

(WebCore::DOMApplicationCache::disconnectFrameForPageCache):
Updated for the disconnectFrame rename.
(WebCore::DOMApplicationCache::reconnectFrameFromPageCache):
Updated for the reconnectFrame rename.
(WebCore::DOMApplicationCache::willDestroyGlobalObjectInFrame):
Cover the cases formerly covered by disconnectFrame (which was sometimes being called when
called when the frame was destroyed).

  • loader/appcache/DOMApplicationCache.h:
  • notifications/DOMWindowNotifications.cpp:

(WebCore::DOMWindowNotifications::disconnectFrameForPageCache):
Updated for the disconnectFrame rename.
(WebCore::DOMWindowNotifications::reconnectFrameFromPageCache):
Updated for the reconnectFrame rename.
(WebCore::DOMWindowNotifications::willDestroyGlobalObjectInCachedFrame):
Get rid of the suspended notification center.
(WebCore::DOMWindowNotifications::willDestroyGlobalObjectInFrame):
Get rid of the notification center.
(WebCore::DOMWindowNotifications::willDetachGlobalObjectFromFrame):
Do not allow use of the notification center by detached frames.

  • notifications/DOMWindowNotifications.h:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::clearDOMWindowProperties):
Do not call disconnectDOMWindowProperties. It is now the responsibility of the callers to
tell the DOMWindowProperties the correct cause of being cleared.
(WebCore::DOMWindow::~DOMWindow):
Make sure the DOMWindowProperties still know that the DOMWindow is going away.
(WebCore::DOMWindow::frameDestroyed):
Invoke willDestroyGlobalObjectInFrame on the DOMWindowProperties.
(WebCore::DOMWindow::willDetachPage):
It is no longer necessary to tell the DOMWindowProperties anything here.
(WebCore::DOMWindow::willDestroyCachedFrame):
Tell the DOMWindowProperties.
(WebCore::DOMWindow::willDestroyDocumentInFrame):
Ditto.
(WebCore::DOMWindow::willDetachDocumentFromFrame):
Ditto.
(WebCore::DOMWindow::clear):
Ditto.
(WebCore::DOMWindow::disconnectDOMWindowProperties):
Updated for the disconnectFrame rename.
(WebCore::DOMWindow::reconnectDOMWindowProperties):
Ditto.

  • page/DOMWindow.h:
  • page/DOMWindowExtension.cpp:

(WebCore::DOMWindowExtension::DOMWindowExtension):
Move the responsibility for tracking the disconnected DOMWindow to DOMWindowProperty, since
DOMWindowProperty will need it to unregister the property when a cached frame is destroyed.
(WebCore::DOMWindowExtension::disconnectFrameForPageCache):
Remove the code to check for disconnectFrame being called twice - it is now only called when
a frame goes into the page cache.
Let the DOMWindowProperty keep track of the disconnected DOMWindow.
(WebCore::DOMWindowExtension::reconnectFrameFromPageCache):
Let the DOMWindowProperty keep track of the disconnected DOMWindow.
(WebCore::DOMWindowExtension::willDestroyGlobalObjectInCachedFrame):
Dispatch the willDestroyGlobalObjectForDOMWindowExtension callback.
(WebCore::DOMWindowExtension::willDestroyGlobalObjectInFrame):
Ditto, but only if the callback hasn't already been sent because the frame has been detached.
(WebCore::DOMWindowExtension::willDetachGlobalObjectFromFrame):
Send the callback because nothing interesting can be done in the frame once it has been
detached.

  • page/DOMWindowExtension.h:
  • page/DOMWindowProperty.cpp:

(WebCore::DOMWindowProperty::DOMWindowProperty):
Keep track of the disconnected DOMWindow so it can be used to unregister the property when a
cached frame is destroyed.
(WebCore::DOMWindowProperty::~DOMWindowProperty):
Also unregister the property when a DOMWindowProperty for a cached frame is destroyed.
(WebCore::DOMWindowProperty::disconnectFrameForPageCache):
Keep track of the disconnected DOMWindow.
(WebCore::DOMWindowProperty::reconnectFrameFromPageCache):
Ditto.
(WebCore::DOMWindowProperty::willDestroyGlobalObjectInCachedFrame):
Unregister the property from the disconnected DOMWindow.
(WebCore::DOMWindowProperty::willDestroyGlobalObjectInFrame):
Unregister the property from the DOMWindow and stop keeping track of the frame.
(WebCore::DOMWindowProperty::willDetachGlobalObjectFromFrame):
Do not set m_frame to 0 because detached frames still have access to the DOMWindow, even if
they can't do anything meaningful with it.

  • page/DOMWindowProperty.h:
  • page/Frame.cpp:

(WebCore::Frame::setView):
Tell the DOMWindow that the Document is being detached so it can tell the
DOMWindowProperties.

  • page/PointerLock.cpp:

(WebCore::PointerLock::disconnectFrameForPageCache):
Updated for disconnectFrame rename.
(WebCore::PointerLock::willDestroyGlobalObjectInFrame):
Cover the cases formerly covered by disconnectFrame (which was sometimes being called when
called when the frame was destroyed).

  • page/PointerLock.h:

Tools:

Cached frames can live slightly longer than the page, but most clients unregister themselves
and do other cleanup in the willDestroyPage callback, making them miss the
willDestroyGlobalObjectForDOMWindowExtension callbacks.

The calls to willDestroyGlobalObjectForDOMWindowExtension in the DOMWindowExtensionBasic
test were all being invoked underneath WebPage::close. This is unrealistic. Update that test
to destroy the BundleDOMWindowExtensions in response to the willDestroyPage callback.

Add a test to verify that willDestroyGlobalObjectForDOMWindowExtension is being called for
pages that don't go into the page cache.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

Add DOMWindowExtensionNoCache.cpp, DOMWindowExtensionNoCache_Bundle.cpp, simple-unload.html
and simple-iframe-unload.html

  • TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:

(TestWebKitAPI):
Remove the expected messages for willDestroyGlobalObjectForDOMWindowExtension.
(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
Do not bother to keep track of the live extension count - all of them are expected to be
live until the test completes.
(TestWebKitAPI::TEST):
Fix the calls to EXPECT to pass the expected value first, and use EXPECT_WK_STREQ so that
message failures will be clearer.

  • TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:

(TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
Clean up the BundleDOMWindowExtensions.
(TestWebKitAPI::DOMWindowExtensionBasic::willDestroyGlobalObjectForDOMWindowExtension):
Add an ASSERT_NOT_REACHED.

  • TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp: Added.

(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
Keep track of the messages received so they can be checked at the end of the test.
(TestWebKitAPI::TEST):
Navigate to uncacheable pages and back.

  • TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp: Copied from Tools/TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp.

(DOMWindowExtensionNoCache):
(TestWebKitAPI::DOMWindowExtensionNoCache::DOMWindowExtensionNoCache):
Set up all the states for each BundleDOMWindowExtension.
(TestWebKitAPI::DOMWindowExtensionNoCache::frameLoadFinished):
Tell the UI Process about the states of the BundleDOMWindowExtensions.
(TestWebKitAPI::DOMWindowExtensionNoCache::sendExtensionStateMessage):
(TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
(TestWebKitAPI::DOMWindowExtensionNoCache::didCreatePage):
(TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
Remvoe the remaining BundleDOMWindowExtensions, send the updated state, and finish the test.
(TestWebKitAPI::DOMWindowExtensionNoCache::updateExtensionStateRecord):
(TestWebKitAPI::DOMWindowExtensionNoCache::sendBundleMessage):
(TestWebKitAPI::DOMWindowExtensionNoCache::globalObjectIsAvailableForFrame):
(TestWebKitAPI::DOMWindowExtensionNoCache::willDisconnectDOMWindowExtensionFromGlobalObject):
ASSERT that these pages not going into the page cache are not getting disconnected to go into
the page cache.
(TestWebKitAPI::DOMWindowExtensionNoCache::didReconnectDOMWindowExtensionToGlobalObject):
Ditto about getting reconnected when coming out of the page cache.
(TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyGlobalObjectForDOMWindowExtension):
Tell the UI Process, update the state, and get rid of the BundleDOMWindowExtension.
(TestWebKitAPI::didFinishLoadForFrameCallback):
(TestWebKitAPI::globalObjectIsAvailableForFrameCallback):
(TestWebKitAPI::willDisconnectDOMWindowExtensionFromGlobalObjectCallback):
(TestWebKitAPI::didReconnectDOMWindowExtensionToGlobalObjectCallback):
(TestWebKitAPI::willDestroyGlobalObjectForDOMWindowExtensionCallback):

  • TestWebKitAPI/Tests/WebKit2/simple-iframe-unload.html: Added.
  • TestWebKitAPI/Tests/WebKit2/simple-unload.html: Added.
6:52 PM Changeset in webkit [116594] by commit-queue@webkit.org
  • 12 edits in trunk/Source

[chromium] Ensure animations get ticked at least once when added.
https://bugs.webkit.org/show_bug.cgi?id=86013

Patch by Ian Vollick <vollick@chromium.org> on 2012-05-09
Reviewed by James Robinson.

Source/WebCore:

Tested in

CCLayerTreeHostTestTickAnimationWhileBackgrounded.runSingleThreaded
CCLayerTreeHostTestAddAnimationWithTimingFunction.runSingleThreaded
CCLayerTreeHostTestSynchronizeAnimationStartTimes.runSingleThreaded
CCLayerTreeHostTestAnimationFinishedEvents.runSingleThreaded

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::addAnimation):

  • platform/graphics/chromium/cc/CCLayerAnimationController.cpp:

(WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::didAddAnimation):
(WebCore):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCProxy.h:

(CCProxy):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(CCSingleThreadProxyAnimationTimer):
(WebCore::CCSingleThreadProxyAnimationTimer::create):
(WebCore::CCSingleThreadProxyAnimationTimer::CCSingleThreadProxyAnimationTimer):
(WebCore):
(WebCore::CCSingleThreadProxy::CCSingleThreadProxy):
(WebCore::CCSingleThreadProxy::didAddAnimation):
(WebCore::CCSingleThreadProxy::doComposite):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(WebCore):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestTickAnimationWhileBackgrounded::animateLayers):
(WTF):

6:31 PM Changeset in webkit [116593] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JIT memory allocator is not returning memory to the OS on Darwin
https://bugs.webkit.org/show_bug.cgi?id=86047
<rdar://problem/11414948>

Reviewed by Geoff Garen.

Work around the problem by using a different madvise() flag, but only for the JIT memory
allocator. Also put in ASSERTs that the call is actually working.

  • jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::FixedVMPoolExecutableAllocator::notifyNeedPage):
(JSC::FixedVMPoolExecutableAllocator::notifyPageIsFree):

6:21 PM Changeset in webkit [116592] by abarth@webkit.org
  • 18 edits
    2 adds in trunk

Implement HTML Media Capture
https://bugs.webkit.org/show_bug.cgi?id=85958

Reviewed by Eric Seidel.

Source/WebCore:

This patch begins the implementation of
http://www.w3.org/TR/html-media-capture/ by adding the capture
attribute to HTMLInputElement.

Test: fast/forms/file/file-input-capture.html

  • html/FileInputType.cpp:

(WebCore::FileInputType::handleDOMActivateEvent):

  • html/HTMLAttributeNames.in:
  • html/HTMLInputElement.cpp:

(WebCore):
(WebCore::HTMLInputElement::capture):
(WebCore::HTMLInputElement::setCapture):

  • html/HTMLInputElement.h:

(HTMLInputElement):

  • html/HTMLInputElement.idl:
  • platform/FileChooser.h:

(FileChooserSettings):

Source/WebKit/chromium:

  • features.gypi:
  • public/WebFileChooserParams.h:

(WebFileChooserParams):

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::runOpenPanel):

LayoutTests:

  • fast/forms/file/file-input-capture-expected.txt: Added.
  • fast/forms/file/file-input-capture.html: Added.
    • Test that the capture attribute works properly.
  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/gtk/test_expectations.txt:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
    • Skip the test on all platforms. The feature is enabled only on Android, which isn't yet able to run LayoutTests upstream.
6:13 PM Changeset in webkit [116591] by charles.wei@torchmobile.com.cn
  • 4 edits in trunk/Source/WebCore

[BlackBerry] Refactor data scheme support
https://bugs.webkit.org/show_bug.cgi?id=85938

Reviewed by Rob Buis.

We will create a DataStream in our platform repository,
so that can be wrapped up by NetworkJob for webkit rendering,
and by DownloadStream for downloading.

Refactor, no new tests.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::NetworkJob):
(WebCore::NetworkJob::initialize):
(WebCore::NetworkJob::cancelJob):
(WebCore::NetworkJob::sendResponseIfNeeded):

  • platform/network/blackberry/NetworkJob.h:

(NetworkJob):

  • platform/network/blackberry/NetworkManager.cpp:

(WebCore::NetworkManager::startJob):

6:01 PM Changeset in webkit [116590] by abarth@webkit.org
  • 2 edits in trunk/Tools

[Chromium] Android's DRT doesn't want to build WebUserMediaClientMock
https://bugs.webkit.org/show_bug.cgi?id=86045

Reviewed by Eric Seidel.

  • DumpRenderTree/DumpRenderTree.gypi:
5:56 PM Changeset in webkit [116589] by abarth@webkit.org
  • 2 edits in trunk/Tools

[Chromium] MockWebSpeechInputController.cpp should be guarded by ENABLE(INPUT_SPEECH)
https://bugs.webkit.org/show_bug.cgi?id=86041

Reviewed by Eric Seidel.

  • DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
5:51 PM Changeset in webkit [116588] by abarth@webkit.org
  • 2 edits in trunk/Tools

[Chromium] Android needs to swizzle pixel dumps in order to get the same hash as other platforms
https://bugs.webkit.org/show_bug.cgi?id=86040

Reviewed by Kent Tamura.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::dumpImage):

5:41 PM Changeset in webkit [116587] by danakj@chromium.org
  • 7 edits in trunk/Source

[chromium] Don't draw when canDraw() is false
https://bugs.webkit.org/show_bug.cgi?id=85829

Reviewed by Adrienne Walker.

Source/WebCore:

This is based on the work of Daniel Sievers in bug
https://bugs.webkit.org/show_bug.cgi?id=82680. When canDraw() is false,
we should not call drawLayers() or prepareToDraw() in both Single- and
Multi-Threaded mode.

drawLayers() is crashing in single threaded mode, and this attempts to
prevent it from being called with invalid state. While making it behave
properly in single-threaded mode, it seems appropriate to unrevert the
parts of 82680 that made threaded mode behave similarly appropriately.

A single-threaded test is not included since LTHTests is unable to run
in single-threaded mode at this time (pending work from Ian Vollick). So
we test in threaded mode only with a note to include a single thread
version.

Tests: CCLayerTreeHostTestCanDrawBlocksDrawing.runMultiThread

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::prepareToDraw):
(WebCore::CCLayerTreeHostImpl::drawLayers):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::doComposite):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKitTests::CCLayerTreeHostImplTest::CCLayerTreeHostImplTest):
(WebKitTests::TEST_F):

  • tests/CCLayerTreeHostTest.cpp:

(WTF):
(CCLayerTreeHostTestCanDrawBlocksDrawing):
(WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::CCLayerTreeHostTestCanDrawBlocksDrawing):
(WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::beginTest):
(WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::didCommitAndDrawFrame):
(WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::afterTest):
(WTF::TEST_F):

5:35 PM Changeset in webkit [116586] by rakuco@webkit.org
  • 2 edits in trunk/Tools

[EFL] Build fix after r116464.

`ulong' is a type defined by glibc, so it is not very
portable. Use `unsigned long' instead.

  • DumpRenderTree/efl/EventSender.cpp:

(DelayedEvent::DelayedEvent):
(DelayedEvent):
(leapForwardCallback):

5:34 PM Changeset in webkit [116585] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Cairo] GLContextGLX releases the context with an uninitialized display
https://bugs.webkit.org/show_bug.cgi?id=86039

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-05-09
Reviewed by Philippe Normand.

No new tests. This does not change behavior on most machines, but has
the potential to prevent a pretty nasty crash on others.

Use the shared display to release GLX contexts instead of the uninitialized
m_display member.

  • platform/graphics/glx/GLContextGLX.cpp:

(WebCore::GLContextGLX::~GLContextGLX): Release the display with the shared
display.

  • platform/graphics/glx/GLContextGLX.h:

(GLContextGLX): Remove the m_display member.

5:32 PM Changeset in webkit [116584] by tonyg@chromium.org
  • 3 edits
    6 adds in trunk

Subresources loaded after a reload completes shouldn't be revalidated.
https://bugs.webkit.org/show_bug.cgi?id=84614

Source/WebCore:

Based on patch by Darin Fisher.

Reviewed by Darin Fisher.

Tests: http/tests/cache/loaded-from-cache-after-reload-within-iframe.html

http/tests/cache/loaded-from-cache-after-reload.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkLoadCompleteForThisFrame): Reset m_loadType after the load completes.

LayoutTests:

Tests by Darin Fisher.

Reviewed by Darin Fisher.

  • http/tests/cache/loaded-from-cache-after-reload-expected.txt: Added.
  • http/tests/cache/loaded-from-cache-after-reload-within-iframe-expected.txt: Added.
  • http/tests/cache/loaded-from-cache-after-reload-within-iframe.html: Added.
  • http/tests/cache/loaded-from-cache-after-reload.html: Added.
  • http/tests/cache/resources/loaded-from-cache-after-reload-within-iframe-subframe.html: Added.
  • http/tests/cache/resources/random-cached.cgi: Added.
5:19 PM Changeset in webkit [116583] by fpizlo@apple.com
  • 4 edits in trunk/Source

It should be possible to get useful debug logging from the JIT memory allocator
https://bugs.webkit.org/show_bug.cgi?id=86042

Reviewed by Geoff Garen.

Source/JavaScriptCore:

  • jit/ExecutableAllocator.h:

Source/WTF:

  • wtf/MetaAllocator.cpp:

(WTF::MetaAllocator::findAndRemoveFreeSpace):
(WTF::MetaAllocator::addFreeSpace):
(WTF::MetaAllocator::dumpProfile):

5:18 PM Changeset in webkit [116582] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r116573.
http://trac.webkit.org/changeset/116573
https://bugs.webkit.org/show_bug.cgi?id=86038

Broke the Chromium Mac compile (Requested by ojan_gardening on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-09

  • public/WebPlugin.h:

(WebPlugin):

5:15 PM Changeset in webkit [116581] by abarth@webkit.org
  • 4 edits in trunk/Tools

[Chromium] LayoutTestController should use ENABLE guards for some features
https://bugs.webkit.org/show_bug.cgi?id=86030

Reviewed by Eric Seidel.

These features are disabled on OS(ANDROID) and so shouldn't be compiled
when the feature is off.

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell):

5:14 PM Changeset in webkit [116580] by arv@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Fix issue where V8BindingPerContextData could keep the context object alive
https://bugs.webkit.org/show_bug.cgi?id=86036

Reviewed by Kentaro Hara.

This is a partial revert of http://trac.webkit.org/changeset/114320/. This keeps
the layout tests that were introduced since it turns out that
http://trac.webkit.org/changeset/114989 fixes the tests too.

Covered by: http/tests/security/isolatedWorld/context-destroy.html

  • bindings/v8/V8IsolatedContext.cpp:

(WebCore::V8IsolatedContext::destroy):

5:12 PM Changeset in webkit [116579] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Speed up some parts of TileCache drawing
https://bugs.webkit.org/show_bug.cgi?id=86033
<rdar://problem/10919373>

Reviewed by Sam Weinig.

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::tileCoverageRect):
If we can't have scrollbars, there's not much need to extend the tile coverage rect outside of the visible rect, since it's
unlikely that we'll do any form of scrolling here.

(WebCore::TileCache::revalidateTiles):
Don't update the tile layer frame if it's big enough to contain the tile size. Also, if there are no new tiles created,
don't call platformCALayerDidCreateTiles since that will trigger an extra layer flush.

5:11 PM WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
5:04 PM Changeset in webkit [116578] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

GC race condition in OpaqueJSClass::prototype
https://bugs.webkit.org/show_bug.cgi?id=86034

Build fix.

  • API/JSClassRef.cpp:

(OpaqueJSClass::prototype):

  • Eeeep, landed bad version of patch!
5:01 PM Changeset in webkit [116577] by kareng@chromium.org
  • 1 edit in branches/chromium/1132/Source/WebCore/rendering/RenderObject.cpp

Merge 116339 - Fix containerForRepaint() assumption about non-null enclosingLayer()
https://bugs.webkit.org/show_bug.cgi?id=85807

Reviewed by Simon Fraser.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::containerForRepaint):

TBR=enne@google.com
Review URL: https://chromiumcodereview.appspot.com/10378082

4:57 PM Changeset in webkit [116576] by kareng@chromium.org
  • 1 edit
    2 deletes in branches/chromium/1132

Revert 114320 - [V8] Don't delete the per context data until the V8IsolatedContext is deleted
https://bugs.webkit.org/show_bug.cgi?id=83831

Reviewed by Nate Chapin.

Source/WebCore:

Test: http/tests/security/isolatedWorld/context-destroy.html

  • bindings/v8/V8IsolatedContext.cpp:

(WebCore::V8IsolatedContext::destroy):

LayoutTests:

  • http/tests/security/isolatedWorld/context-destroy-expected.txt: Added.
  • http/tests/security/isolatedWorld/context-destroy.html: Added.

TBR=arv@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10386064

4:56 PM Changeset in webkit [116575] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

GC race condition in OpaqueJSClass::prototype
https://bugs.webkit.org/show_bug.cgi?id=86034

Reviewed by Filip Pizlo.

The bug here is basically:

if (weakref) weakref->method()

where a GC may occur between the if & the method call.

  • API/JSClassRef.cpp:

(OpaqueJSClass::prototype):

4:44 PM Changeset in webkit [116574] by commit-queue@webkit.org
  • 4 edits in trunk

setPageScaleFactor should setScrollPosition if scale is unchanged
https://bugs.webkit.org/show_bug.cgi?id=84400

Patch by Alexandre Elias <aelias@google.com> on 2012-05-09
Reviewed by Adam Barth.

Previously, setPageScaleFactor forgot about its "origin" argument if
the page scale factor is unchanged. This has proven undesirable in
practice because, for example, a single pinch gesture may zoom in and
back out to the original page scale factor, but at a different scroll
offset.

New test case added to scale-and-scroll-body-expected.txt

  • page/Page.cpp:

(WebCore::Page::setPageScaleFactor):

4:33 PM Changeset in webkit [116573] by fsamuel@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Expose WebPluginContainer of WebPlugin to embedder
https://bugs.webkit.org/show_bug.cgi?id=85916

Reviewed by Darin Fisher.

The browser plugin needs to access its current guest's WebPluginContainer
so that it can replace the guest with another guest WebPlugin when navigating
across processes.

  • public/WebPlugin.h:

(WebPlugin):
(WebKit::WebPlugin::container):

4:22 PM Changeset in webkit [116572] by tomz@codeaurora.org
  • 7 edits in trunk/Tools

Fix overzealous re-opened since blocked by... message
https://bugs.webkit.org/show_bug.cgi?id=86020

Reviewed by Adam Barth.

Changed CreateBug behavior to only re-open a blocked bug if it
was RESOLVED. Also had to update the test infrastructure slightly
to allow for distinct mock commit revisions, so one could point
to a RESOLVED bug for testing while another pointed to an OPEN bug.

Also moved default created mock bug to be 60001 instead of 50004
which already exists as a reference mock bug.

  • Scripts/webkitpy/common/checkout/checkout_mock.py:

(MockCheckout.init):
(MockCheckout.commit_info_for_revision):

  • Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:

(MockBugzilla.create_bug):

  • Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:

(test_create_rollout_resolved):

  • Scripts/webkitpy/tool/commands/queries_unittest.py:

(FailureReasonTest.test_blame_line_for_revision):

  • Scripts/webkitpy/tool/steps/createbug.py:

(CreateBug.run):

4:10 PM Changeset in webkit [116571] by commit-queue@webkit.org
  • 10 edits
    6 adds in trunk

Use suitable viewport values on XHTML-MP pages.
https://bugs.webkit.org/show_bug.cgi?id=85425

Patch by Hugo Parente Lima <Hugo Parente Lima> on 2012-05-09
Reviewed by Kenneth Rohde Christiansen.

.:

Add LEGACY_VIEWPORT_ADAPTION use feature to cmake build system,
this feature will enable the use of a suitable viewport size
on legacy XHTML-MP pages.

  • Source/cmake/WebKitFeatures.cmake:

Source/WebCore:

Tests: fast/viewport/viewport-legacy-xhtmlmp-misplaced-doctype.html

fast/viewport/viewport-legacy-xhtmlmp-ordering.html
fast/viewport/viewport-legacy-xhtmlmp.html

Use device-width and device-height as viewport size on
XHTML-MP pages if the use feature LEGACY_VIEWPORT_ADAPTION
is set according as the non normative section of
http://www.w3.org/TR/css-device-adapt/

  • dom/Document.cpp:

(WebCore::Document::setDocType):

Tools:

Enable LEGACY_VIEWPORT_ADAPTION on Qt port.

  • qmake/mkspecs/features/features.prf:

LayoutTests:

Add tests for legacy viewport adaption and skip them
on all ports but the Qt one.

  • fast/viewport/viewport-legacy-xhtmlmp-expected.txt: Added.
  • fast/viewport/viewport-legacy-xhtmlmp-misplaced-doctype-expected.txt: Added.
  • fast/viewport/viewport-legacy-xhtmlmp-misplaced-doctype.html: Added.
  • fast/viewport/viewport-legacy-xhtmlmp-ordering-expected.txt: Added.
  • fast/viewport/viewport-legacy-xhtmlmp-ordering.html: Added.
  • fast/viewport/viewport-legacy-xhtmlmp.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/gtk/test_expectations.txt:
4:06 PM Changeset in webkit [116570] by Beth Dakin
  • 10 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=86025
RTL and vertical text documents do no scroll properly with the new
tiled scrolling model
-and corresponding-
<rdar://problem/11077589>

Reviewed by Dan Bernstein.

Most of the fix here is just to teach the scrolling tree about the
scroll origin.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::ScrollingCoordinator::setScrollParameters):

  • page/scrolling/ScrollingCoordinator.h:

(ScrollParameters):

  • page/scrolling/ScrollingTreeNode.cpp:

(WebCore::ScrollingTreeNode::update):

  • page/scrolling/ScrollingTreeNode.h:

(WebCore::ScrollingTreeNode::scrollOrigin):
(ScrollingTreeNode):

  • page/scrolling/ScrollingTreeState.cpp:

(WebCore::ScrollingTreeState::setScrollOrigin):
(WebCore):

  • page/scrolling/ScrollingTreeState.h:

(WebCore::ScrollingTreeState::scrollOrigin):
(ScrollingTreeState):

  • page/scrolling/mac/ScrollingTreeNodeMac.mm:

(WebCore::ScrollingTreeNodeMac::scrollPosition):
(WebCore::ScrollingTreeNodeMac::setScrollLayerPosition):
(WebCore::ScrollingTreeNodeMac::minimumScrollPosition):
(WebCore::ScrollingTreeNodeMac::maximumScrollPosition):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::frameViewDidScroll):

Teaching the scrolling tree about the scroll origin revealed this pre-
existing bug. layoutOverflowRect() is not the right rect to use since
it is not writing-mode savvy. unscaledDocumentRect() is the right rect
for the view's bounds.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateCompositedBounds):

3:53 PM Changeset in webkit [116569] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebCore

Cleanup SVGElement.cpp
https://bugs.webkit.org/show_bug.cgi?id=86004

Reviewed by Eric Seidel.

Remove unneeded includes. We do not need to check attr in SVGElement::attributeChanged,
lower layers assume it is non-null and we do not call attributeChanged in SVG.

  • svg/SVGElement.cpp:

(WebCore::SVGElement::attributeChanged):
(WebCore::SVGElement::isAnimatableAttribute):

3:52 PM Changeset in webkit [116568] by kareng@chromium.org
  • 1 add in branches/chromium/1132/codereview.settings

adding for easy drovering

3:51 PM Changeset in webkit [116567] by kareng@chromium.org
  • 1 copy in branches/chromium/1132

chromium branch for M20

3:50 PM Changeset in webkit [116566] by pilgrim@chromium.org
  • 18 edits
    3 copies in trunk/Source

[Chromium] Move clipboard to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=85758

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

  • Platform.gypi:
  • chromium/public/Platform.h:

(WebKit):
(Platform):
(WebKit::Platform::clipboard):

  • chromium/public/WebClipboard.h: Added.

(WebKit):
(WebClipboard):
(WebKit::WebClipboard::sequenceNumber):
(WebKit::WebClipboard::isFormatAvailable):
(WebKit::WebClipboard::readAvailableTypes):
(WebKit::WebClipboard::readPlainText):
(WebKit::WebClipboard::readHTML):
(WebKit::WebClipboard::readImage):
(WebKit::WebClipboard::readCustomData):
(WebKit::WebClipboard::writePlainText):
(WebKit::WebClipboard::writeHTML):
(WebKit::WebClipboard::writeURL):
(WebKit::WebClipboard::writeImage):
(WebKit::WebClipboard::writeDataObject):
(WebKit::WebClipboard::~WebClipboard):

  • chromium/public/WebDragData.h: Added.

(WebKit):
(WebDragData):
(WebKit::WebDragData::~WebDragData):
(WebKit::WebDragData::WebDragData):
(WebKit::WebDragData::operator=):
(WebKit::WebDragData::isNull):

  • chromium/public/WebImage.h: Added.

(WebKit):
(WebImage):
(WebKit::WebImage::~WebImage):
(WebKit::WebImage::WebImage):
(WebKit::WebImage::operator=):
(WebKit::WebImage::getSkBitmap):
(WebKit::WebImage::init):
(WebKit::WebImage::getCGImageRef):

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/platform/WebClipboard.h:
  • public/platform/WebDragData.h:
  • public/platform/WebImage.h:
  • public/platform/WebKitPlatformSupport.h:

(WebKit):
(WebKitPlatformSupport):

  • src/AssertMatchingEnums.cpp:
  • src/DragClientImpl.cpp:
  • src/PlatformSupport.cpp:
  • src/WebDragData.cpp:
  • src/WebImageCG.cpp:
  • src/WebImageDecoder.cpp:
  • src/WebImageSkia.cpp:
  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::copy):

  • src/WebViewImpl.cpp:
3:50 PM Changeset in webkit [116565] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

CopiedSpace does not add pinned blocks back to the to-space filter
https://bugs.webkit.org/show_bug.cgi?id=86011

Reviewed by Geoffrey Garen.

After a collection has finished, we go through the blocks in from-space
and move any of them that are pinned into to-space. At the beginning of
collection, we reset the to-space block filter that is used during
conservative scanning and add back the blocks that are filled during the
collection. However, we neglect to add back those blocks that are moved
from from-space to to-space, which can cause the conservative scan to
think that some pinned items are not actually in CopiedSpace.

  • heap/CopiedSpace.cpp:

(JSC::CopiedSpace::doneCopying): Add the pinned blocks back to the
to-space filter. Also added a comment and assert for future readers that
indicates that it's okay that we don't also add the block to the
to-space block set since it was never removed.

3:45 PM Changeset in webkit [116564] by tony@chromium.org
  • 1 edit
    4 adds in trunk/PerformanceTests

add some basic perf-o-matic tests for flexbox
https://bugs.webkit.org/show_bug.cgi?id=86017

Reviewed by Ryosuke Niwa.

Each of these tests take < 3s on my machine.

  • Layout/flexbox-column-nowrap.html: Added.
  • Layout/flexbox-column-wrap.html: Added.
  • Layout/flexbox-row-nowrap.html: Added.
  • Layout/flexbox-row-wrap.html: Added.
3:13 PM Changeset in webkit [116563] by jochen@chromium.org
  • 12 edits
    4 adds in trunk

When creating a new page during a navigation, prime the initial document with the correct referrer policy
https://bugs.webkit.org/show_bug.cgi?id=86001

Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/referrer-policy-redirect-link.html

  • dom/Document.h:

(WebCore::Document::setReferrerPolicy):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):

Tools:

Store the referrer policy in the request, so the network stack can comply with it.

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::willSendRequest):

LayoutTests:

Skip the test on all but chromium, see https://bugs.webkit.org/show_bug.cgi?id=86000

  • http/tests/security/referrer-policy-redirect-link-expected.txt: Added.
  • http/tests/security/referrer-policy-redirect-link.html: Added.
  • http/tests/security/resources/referrer-policy-postmessage.php: Added.
  • http/tests/security/resources/referrer-policy-redirect-link.html: Added.
  • platform/efl/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
3:09 PM Changeset in webkit [116562] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

IndexedDB: call abort handler when there are problems committing
https://bugs.webkit.org/show_bug.cgi?id=85841

Patch by Alec Flett <alecflett@chromium.org> on 2012-05-09
Reviewed by Ojan Vafai.

No new tests. Every existing test that calls commit() is testing
the success side of this, and this only throws when there are
LevelDB errors, which is exactly what we're trying to diagnose
with this patch.

  • Modules/indexeddb/IDBBackingStore.h:

(Transaction):

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::deleteDatabase):
(WebCore::IDBLevelDBBackingStore::Transaction::commit):

  • Modules/indexeddb/IDBLevelDBBackingStore.h:

(Transaction):

  • Modules/indexeddb/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::commit):

3:06 PM Changeset in webkit [116561] by pilgrim@chromium.org
  • 7 edits
    1 delete in trunk/Source

[Chromium] Remove PlatformSupport::loadPlatformImageResource, call loadResource directly
https://bugs.webkit.org/show_bug.cgi?id=84417

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

  • platform/graphics/chromium/ImageChromium.cpp:

(WebCore::Image::loadPlatformResource):

  • platform/graphics/chromium/ImageChromiumMac.mm: Removed.

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore):

3:01 PM Changeset in webkit [116560] by enne@google.com
  • 25 edits in trunk/LayoutTests

Update compositing/RTL tests to fail if the root layer is shifted incorrectly
https://bugs.webkit.org/show_bug.cgi?id=85820

Reviewed by James Robinson.

For the Chromium port, if the root layer was shifted incorrectly, the
non-composited red indicator layers would get drawn outside the root
layers bounds, making it impossible to see if the test was failing.

Also turn off overflow:hidden because compositing/ tests have mock
scrollbars. This makes it much easier to debug these tests locally.

  • compositing/rtl/rtl-absolute-expected.png:
  • compositing/rtl/rtl-absolute-overflow-expected.png:
  • compositing/rtl/rtl-absolute-overflow-expected.txt:
  • compositing/rtl/rtl-absolute-overflow-scrolled-expected.png:
  • compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
  • compositing/rtl/rtl-absolute-overflow-scrolled.html:
  • compositing/rtl/rtl-absolute-overflow.html:
  • compositing/rtl/rtl-absolute.html:
  • compositing/rtl/rtl-fixed-expected.png:
  • compositing/rtl/rtl-fixed-overflow-expected.png:
  • compositing/rtl/rtl-fixed-overflow-expected.txt:
  • compositing/rtl/rtl-fixed-overflow-scrolled-expected.png:
  • compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • compositing/rtl/rtl-fixed-overflow-scrolled.html:
  • compositing/rtl/rtl-fixed-overflow.html:
  • compositing/rtl/rtl-fixed.html:
  • compositing/rtl/rtl-iframe-absolute-overflow-expected.png:
  • compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
  • compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png:
  • compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
  • compositing/rtl/rtl-iframe-fixed-overflow-expected.png:
  • compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
  • compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png:
  • compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
2:56 PM Changeset in webkit [116559] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Remove CYGWIN=tty from environment variable as its no longer supported
https://bugs.webkit.org/show_bug.cgi?id=85791

The CYGWIN=tty environment variable is no longer supported from Cygwin
version 1.7.10. This fix avoids addition of this environment variable
for Cygwin versions greater than 1.7.9. For supporting older versions
i.e. 1.7.9 or older, the script takes care of retaining the environment
variable.

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-05-09
Reviewed by Adam Roben.

  • Scripts/webkitdirs.pm:

(setupAppleWinEnv):

2:27 PM Changeset in webkit [116558] by jochen@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] remove the obsolete WebFrame::referrerPolicy method
https://bugs.webkit.org/show_bug.cgi?id=86003

Reviewed by Adam Barth.

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp:
  • src/WebFrameImpl.h:

(WebFrameImpl):

2:20 PM Changeset in webkit [116557] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Remove some isSVGFoo methods
https://bugs.webkit.org/show_bug.cgi?id=86009

Patch by Rob Buis <rbuis@rim.com> on 2012-05-09
Reviewed by Eric Seidel.

These are not used at the moment and were probably just copy and pasted from
isSVGFoo methods in RenderObject.h.

  • rendering/RenderObject.h:
  • rendering/svg/RenderSVGEllipse.h:

(RenderSVGEllipse):

  • rendering/svg/RenderSVGRect.h:

(RenderSVGRect):

  • rendering/svg/RenderSVGShape.h:
2:17 PM Changeset in webkit [116556] by jochen@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Check whether an active document loader exists before accessing it
https://bugs.webkit.org/show_bug.cgi?id=85892

Reviewed by Eric Seidel.

Although FrameLoader::loadInSameDocument which invokes this
method does not have a provisional document loader, we're seeing crashes
where the FrameLoader is in provisional state, and thus
activeDocumentLoader returns 0. Lacking any understanding of how this
can happen, we do this check here to avoid crashing.

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):

2:06 PM Changeset in webkit [116555] by fpizlo@apple.com
  • 15 edits in branches/dfgopt/Source/JavaScriptCore

DFG variable capture analysis should work even if the variables arose through inlining
https://bugs.webkit.org/show_bug.cgi?id=85945

Reviewed by Oliver Hunt.

This just changes how the DFG queries whether a variable is captured. It does not
change any user-visible behavior.

As part of this change, I further solidified the policy that the CFA behaves in an
undefined way for captured locals and queries about their values will not yield
reliable results. This will likely be changed in the future, but for now it makes
sense.

One fun part about this change is that it recognizes that the same variable may
be both captured and not, at the same time, because their live interval spans
inlining boundaries. This only happens in the case of arguments to functions that
capture their arguments, and this change treats them with just the right touch of
conservatism: they will be treated as if captured by the caller as well as the
callee.

Finally, this also adds captured variable reasoning to the InlineCallFrame, which
I thought might be useful for later tooling.

This is perf-neutral, since it does it does not make the DFG take advantage of this
new functionality in any way. In particular, it is still the case that the DFG will
not inline functions that use arguments reflectively or that create activations.

  • bytecode/CodeBlock.h:

(CodeBlock):
(JSC::CodeBlock::needsActivation):
(JSC::CodeBlock::argumentIsCaptured):
(JSC::CodeBlock::localIsCaptured):
(JSC::CodeBlock::isCaptured):

  • bytecode/CodeOrigin.h:

(InlineCallFrame):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::merge):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::newVariableAccessData):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::flushArgument):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::fixVariableAccessPredictions):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGCFGSimplificationPhase.cpp:

(CFGSimplificationPhase):
(JSC::DFG::CFGSimplificationPhase::keepOperandAlive):
(JSC::DFG::CFGSimplificationPhase::fixPossibleGetLocal):
(JSC::DFG::CFGSimplificationPhase::fixTailOperand):

  • dfg/DFGCommon.h:
  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::nameOfVariableAccessData):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::needsActivation):
(JSC::DFG::Graph::usesArguments):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGVariableAccessData.h:

(JSC::DFG::VariableAccessData::VariableAccessData):
(JSC::DFG::VariableAccessData::mergeIsCaptured):
(VariableAccessData):
(JSC::DFG::VariableAccessData::isCaptured):

1:27 PM Changeset in webkit [116554] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[chromium] Add impl-thread support for fill-mode and direction css animation properties
https://bugs.webkit.org/show_bug.cgi?id=77662

Patch by Ian Vollick <vollick@chromium.org> on 2012-05-09
Reviewed by James Robinson.

Source/WebCore:

Adds support for accelerating css animations with -webkit-animation-fill-mode,
and -webkit-animation-direction properties.

Tested in:

CCActiveAnimationTest.TrimTimeAlternating
CCLayerAnimationControllerTest.createReversedAnimation
CCLayerAnimationControllerTest.createAlternatingAnimation
CCLayerAnimationControllerTest.createReversedAlternatingAnimation

  • platform/graphics/chromium/cc/CCActiveAnimation.cpp:

(WebCore::CCActiveAnimation::CCActiveAnimation):
(WebCore::CCActiveAnimation::trimTimeToCurrentIteration):
(WebCore::CCActiveAnimation::cloneForImplThread):

  • platform/graphics/chromium/cc/CCActiveAnimation.h:

(CCActiveAnimation):
(WebCore::CCActiveAnimation::alternatesDirection):
(WebCore::CCActiveAnimation::setAlternatesDirection):

  • platform/graphics/chromium/cc/CCLayerAnimationController.cpp:

Source/WebKit/chromium:

  • tests/CCActiveAnimationTest.cpp:

(WebCore::TEST):
(WebCore):

  • tests/CCLayerAnimationControllerTest.cpp:

(WebKitTests::TEST):
(WebKitTests):

1:25 PM Changeset in webkit [116553] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

[Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=85591

Reviewed by Philippe Normand.

Remove all the test expectations for tests that seem to consistently
pass on the Gtk bots but are expected to crash. Any tests that backfire
will have their bug entries updated or closed otherwise.

  • platform/gtk/test_expectations.txt:
12:59 PM Changeset in webkit [116552] by dpranke@chromium.org
  • 4 edits in trunk/Tools

nrwt: --skip-failing-tests should also skip flaky tests
https://bugs.webkit.org/show_bug.cgi?id=85941

Reviewed by Ojan Vafai.

This changes --skip-failing-tests so that we skip tests that
are believed to pass sometimes as well as tests that are
believed to always fail.

In addition, in testing this I discovered that we had lousy
test coverage of the details of retrying test failures and
--clobber-old-results, so I wrote some more tests.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.prepare_lists_and_print_output):

  • Scripts/webkitpy/layout_tests/port/test.py:

(unit_test_list):
(TestPort.init):
(TestDriver.run_test):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_skip_failing_tests):
(MainTest.test_retrying_and_flaky_tests):

12:48 PM Changeset in webkit [116551] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Crash from removal of a line break object
https://bugs.webkit.org/show_bug.cgi?id=85997

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-05-09
Reviewed by David Hyatt.

Source/WebCore:

Regression from r115343. That replaced a call to setNeedsLayout()
with a separate call that used a different bit during linebox
invalidation after renderer child removal. There are special cases
where layout isn't marked on parent nodes just from the removal, so
line dirtying needs to explicitly mark ancestors for layout.

  • rendering/RenderObject.h:

(WebCore::RenderObject::setAncestorLineBoxDirty):

LayoutTests:

Test case to exercise crashing condition in bug 85997.

  • fast/block/line-layout/line-break-removal-near-textarea-crash-expected.txt: Added
  • fast/block/line-layout/line-break-removal-near-textarea-crash.html: Added
12:37 PM Changeset in webkit [116550] by alexis.menard@openbossa.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] REGRESSION(r113678):After this change fast/text/text-stroke-width-cairo-dos.html makes the next test crash
https://bugs.webkit.org/show_bug.cgi?id=83582

Unreviewed gardening : I don't observe crashes anymore.

  • platform/qt-5.0-wk2/Skipped:
12:36 PM Changeset in webkit [116549] by leviw@chromium.org
  • 13 edits
    1 delete in trunk/Source/WebCore

Fix performance regression for floats caused by LayoutUnit change
https://bugs.webkit.org/show_bug.cgi?id=85834

Reviewed by Ojan Vafai.

Refactoring FractionalLayout types to alleviate performance issues. Explicitly
inlining constructor and operator functions in FractionalLayoutUnit, as well as
pixelSnappedIntSize and pixelSnappedIntRect (particularly hot code paths). Also
further simplifying round and ceil functions when sub-pixel layout is not enabled.

pixelSnappedIntSize was the only function defined in FractionalLayoutSize.cpp,
so it is removed.

No new tests. No change in functionality.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/FractionalLayoutUnit.h:

(WebCore::FractionalLayoutUnit::FractionalLayoutUnit):
(FractionalLayoutUnit):
(WebCore::FractionalLayoutUnit::toInt):
(WebCore::FractionalLayoutUnit::toFloat):
(WebCore::FractionalLayoutUnit::toDouble):
(WebCore::FractionalLayoutUnit::toUnsigned):
(WebCore::FractionalLayoutUnit::operator int):
(WebCore::FractionalLayoutUnit::operator unsigned):
(WebCore::FractionalLayoutUnit::operator float):
(WebCore::FractionalLayoutUnit::operator double):
(WebCore::FractionalLayoutUnit::operator bool):
(WebCore::FractionalLayoutUnit::ceil):
(WebCore::FractionalLayoutUnit::round):

  • platform/graphics/FractionalLayoutRect.cpp:

(WebCore):

  • platform/graphics/FractionalLayoutRect.h:

(WebCore::FractionalLayoutRect::pixelSnappedSize):
(WebCore::pixelSnappedIntRect):
(WebCore):

  • platform/graphics/FractionalLayoutSize.cpp: Removed.
  • platform/graphics/FractionalLayoutSize.h:

(WebCore):

  • rendering/LayoutTypes.h:

(WebCore::pixelSnappedIntSize):
(WebCore):

12:01 PM Changeset in webkit [116548] by ojan@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
11:41 AM BuildingGtk edited by philn@igalia.com
(diff)
11:40 AM Changeset in webkit [116547] by commit-queue@webkit.org
  • 10 edits in trunk

[EFL][DRT] EFL's DRT needs to support LayoutTestController.dumpIconChanges()
https://bugs.webkit.org/show_bug.cgi?id=84435

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-09
Reviewed by Antonio Gomes.

Source/WebKit/efl:

Emit a "icon,changed" signal on the frame when its favion changed.
Clarify that the "icon,loaded" signal is only emitted for the main
frame.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchDidReceiveIcon):
(WebCore::FrameLoaderClientEfl::dispatchDidChangeIcons):

  • ewk/ewk_frame.cpp:

(ewk_frame_icon_changed):

  • ewk/ewk_frame.h:
  • ewk/ewk_private.h:

Tools:

Catch the "icon,changed" signal on the frames in EFL's DumpRenderTree
to support LayoutTestController's dumpIconChanges().

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onFrameIconChanged):
(DumpRenderTreeChrome::onFrameCreated):

  • DumpRenderTree/efl/DumpRenderTreeChrome.h:

(DumpRenderTreeChrome):

LayoutTests:

Unskip the test checking for DumpRenderTree's support for
LayoutTestController's dumpIconChanges() in EFL port.

  • platform/efl/Skipped:
11:30 AM Changeset in webkit [116546] by Csaba Osztrogonác
  • 2 edits
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-5.0/fast/text/international/text-spliced-font-expected.png: Added.
  • platform/qt-5.0/fast/text/international/text-spliced-font-expected.txt: Added.
  • platform/qt/Skipped:
11:28 AM Changeset in webkit [116545] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash in ReplaceSelectionCommand::performTrivialReplace
https://bugs.webkit.org/show_bug.cgi?id=85943

Reviewed by Ryosuke Niwa.

Source/WebCore:

RefPtr nodeAfterInsertionPos to guard against mutation events.

Test: editing/inserting/insert-html-crash.html

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::performTrivialReplace):

LayoutTests:

  • editing/inserting/insert-html-crash-expected.txt: Added.
  • editing/inserting/insert-html-crash.html: Added.
10:58 AM Changeset in webkit [116544] by bulach@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Exposes OrientationChangeEvent.
https://bugs.webkit.org/show_bug.cgi?id=85976

Reviewed by Adam Barth.

This is used by the android port, we need to expose the existing
WebCore API.

  • public/WebFrame.h:

(WebFrame):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::sendOrientationChangeEvent):
(WebKit):

  • src/WebFrameImpl.h:

(WebFrameImpl):

10:57 AM Changeset in webkit [116543] by shawnsingh@chromium.org
  • 3 edits
    4 adds in trunk

Hit testing is incorrect in some cases with perspective transforms
https://bugs.webkit.org/show_bug.cgi?id=79136

Reviewed by Simon Fraser.

Source/WebCore:

Tests: transforms/3d/hit-testing/coplanar-with-camera.html

transforms/3d/hit-testing/perspective-clipped.html

  • platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::TransformationMatrix::projectPoint): Fix a
divide-by-zero error so that values do not become Inf or Nan. Also
fix an overflow error by using a large, but not-too-large constant
to represent infinity.

(WebCore::TransformationMatrix::projectQuad): Fix an error where
incorrect quads were being returned. Incorrect quads can occur
when projectPoint clamped==true after returning.

LayoutTests:

  • transforms/3d/hit-testing/coplanar-with-camera-expected.txt: Added.
  • transforms/3d/hit-testing/coplanar-with-camera.html: Added.
  • transforms/3d/hit-testing/perspective-clipped-expected.txt: Added.
  • transforms/3d/hit-testing/perspective-clipped.html: Added.
10:47 AM Changeset in webkit [116542] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Textarea-placeholder-wrapping.html may fail because of scrollbars
https://bugs.webkit.org/show_bug.cgi?id=85989

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-05-09
Reviewed by Ryosuke Niwa.

Increasing rows to avoid scrollbar single pixel differences
to cause failures of this test.

  • fast/forms/textarea-placeholder-wrapping-expected.html:
  • fast/forms/textarea-placeholder-wrapping.html:
10:23 AM Changeset in webkit [116541] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/gtk

[GTK] Missing WebPreferences for media playback requiring user gestures and inline playback
https://bugs.webkit.org/show_bug.cgi?id=85194

Patch by Simon Pena <Simon Pena> on 2012-05-09
Reviewed by Martin Robinson.

Expose WebPreferences for media playback requires user gesture and
media playback allows inline to GTK side.

This adds two properties (mediaPlaybackRequiresUserGesture and
mediaPlaybackAllowsInline) to GTK WebKit WebSettings, and connects
them to the WebKit WebView, so clients can programmatically modify
them.

  • webkit/webkitwebsettings.cpp: install new properties and update

setter and getter
(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):

  • webkit/webkitwebsettingsprivate.h: add media playback related

properties

  • webkit/webkitwebview.cpp: connect newly added properties

(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):

10:06 AM Changeset in webkit [116540] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebCore

Simplify CSSParser::parseSimpleLengthValue()
https://bugs.webkit.org/show_bug.cgi?id=85910

Reviewed by Alexis Menard.

Various small improvements to this function, mainly:

  • Move the check if the property ID accepts a simple length as early as possible;
  • Remove the check for the characters{8,16} pointers since they'll be valid (we ASSERT that);
  • Use a template to avoid duplicate code for 8 and 16 bit characters.
  • css/CSSParser.cpp:

(WebCore):
(WebCore::parseSimpleLength):
(WebCore::parseSimpleLengthValue):

10:02 AM Changeset in webkit [116539] by fischman@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Support multiple buffered time ranges
https://bugs.webkit.org/show_bug.cgi?id=85926

Reviewed by Eric Carlson.

Preserve existing rendering of a single rect even in the presence of multiple buffered regions.

No new tests as this change has no functional effects.

  • rendering/RenderMediaControlsChromium.cpp:

(WebCore::paintMediaSlider):

10:01 AM Changeset in webkit [116538] by danakj@chromium.org
  • 5 edits in trunk/Source

Early-out and avoid any copying when possible for Region operations
https://bugs.webkit.org/show_bug.cgi?id=85260

Reviewed by Anders Carlsson.

Source/WebCore:

For an empty region, any intersection or subtraction will not modify
the region, so we can simply return instead of creating a new Shape
and replacing the current empty Shape.

When a region is united with a region it contains, the orignal
containing region is the result. So, if A.unite(B) and A.contains(B)
then A does not need to change at all and we can return without making
a copy of A's shape. When A is a rect, we can do this test even more
simply.

We also remove redundant checks from trySimpleOperation() methods, where
the test is already done in the Region calling site.

This change improves the performance of the Region overlap testing for
composited layers, and allows us to avoid unnecessary copies of the
Region during unite. With a layout test (attached to bug #81087), that
creates a Region from the union of 225 composited layers, as well as
600 overlapping layers above them, this change decreases the running
time of the test by 3.2% by avoiding a copy of the entire Region for
each insertion that does not change the resulting Region.

Unit tests: RegionTest.unite

  • platform/graphics/Region.cpp:

(WebCore::Region::Shape::UnionOperation::trySimpleOperation):
(WebCore::Region::Shape::IntersectOperation::trySimpleOperation):
(WebCore::Region::Shape::SubtractOperation::trySimpleOperation):
(WebCore::Region::intersect):
(WebCore::Region::unite):
(WebCore::Region::subtract):

  • platform/graphics/Region.h:

(WebCore::Region::isRect):
(WebCore::Region::Shape::isRect):

Source/WebKit/chromium:

  • tests/RegionTest.cpp:

(WebCore::TEST):
(WebCore):

9:32 AM Changeset in webkit [116537] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

webkit-patch upload Fails Behind Load-balancing Proxies
https://bugs.webkit.org/show_bug.cgi?id=85980

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-05-09
Reviewed by Adam Barth.

Unchecking the login restriction to IP to allow the tool
to function behind load-balancing proxies that use multiple
outgoing IPs.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(Bugzilla.authenticate):

9:31 AM Changeset in webkit [116536] by commit-queue@webkit.org
  • 9 edits in trunk

[BlackBerry] Enable PAGE_POPUP in make file, and implement required methods
https://bugs.webkit.org/show_bug.cgi?id=85907

.:

Patch by Crystal Zhang <haizhang@rim.com> on 2012-05-09
Reviewed by Rob Buis.

Enable PAGE_POPUP option in make files.

Internal reviewed by Yong Li.

  • Source/cmake/OptionsBlackBerry.cmake:
  • Source/cmakeconfig.h.cmake:

Source/WebKit/blackberry:

Patch by Crystal Zhang <haizhang@rim.com> on 2012-05-09
Reviewed by Rob Buis.

Internal reviewed by Yong Li.

Enable PAGE_POPUP so we can use WebCore::PagePopup and WebCore::PagePopupClient interface.
Implement virtual methods in WebCore::ChromeClientBlackBerry that required for the
implementation and add methods in WebKit::WebPage that needed for PagePopupClient.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
(BlackBerry::WebKit::WebPage::initPopupWebView):
(WebKit):
(BlackBerry::WebKit::WebPage::popupOpened):
(BlackBerry::WebKit::WebPage::popupClosed):
(BlackBerry::WebKit::WebPage::hasOpenedPopup):
(BlackBerry::WebKit::WebPage::popup):
(BlackBerry::WebKit::WebPagePrivate::setParentPopup):

  • Api/WebPage.h:

(WebCore):

  • Api/WebPage_p.h:

(WebCore):
(WebPagePrivate):

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::hasOpenedPopup):
(WebCore::ChromeClientBlackBerry::openPagePopup):
(WebCore):
(WebCore::ChromeClientBlackBerry::closePagePopup):

  • WebCoreSupport/ChromeClientBlackBerry.h:

(WebCore):
(ChromeClientBlackBerry):

9:21 AM Changeset in webkit [116535] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] shared-stylesheet-mutation tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=85901

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-09
Reviewed by Antti Koivisto.

This test is flaky on EFL because the timeout for applying
the style is too short for a Debug build.

  • http/tests/css/resources/shared-stylesheet-mutation.js:

(executeTests):

9:08 AM Changeset in webkit [116534] by Carlos Garcia Campos
  • 4 edits
    1 copy in trunk

[GTK] Split WebKit2 Makefile moving source code listings to GNUmakefile.list.am
https://bugs.webkit.org/show_bug.cgi?id=85985

Reviewed by Gustavo Noronha Silva.

.:

  • GNUmakefile.am:

Source/WebKit2:

  • GNUmakefile.am:
  • GNUmakefile.list.am: Copied from Source/WebKit2/GNUmakefile.am.
9:05 AM Changeset in webkit [116533] by Carlos Garcia Campos
  • 6 edits in trunk

[GTK] Use independent version numbers for public libraries
https://bugs.webkit.org/show_bug.cgi?id=85984

Reviewed by Gustavo Noronha Silva.

.:

  • configure.ac: Define LIBJAVASCRIPTCOREGTK_VERSION and

LIBWEBKIT2GTK_VERSION using the same version as
LIBWEBKITGTK_VERSION for backwards compatibility.

Source/JavaScriptCore:

  • GNUmakefile.am: Use LIBJAVASCRIPTCOREGTK_VERSION for library

version.

Source/WebKit2:

  • GNUmakefile.am: Use LIBWEBKIT2GTK_VERSION for library version.
9:02 AM Changeset in webkit [116532] by Carlos Garcia Campos
  • 2 edits in trunk/Source/JavaScriptCore

[GTK] Do not install JavaScriptCore platform-specific headers
https://bugs.webkit.org/show_bug.cgi?id=85983

Reviewed by Gustavo Noronha Silva.

JavaScriptCore.h includes JSStringRefCF.h unconditionally. It was
renamed to JavaScript.h in r29234 and it still exists for
compatibility with mac and windows users.

and JSStringRefBSTR.h from the sources and headers list.

8:57 AM Changeset in webkit [116531] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][DRT] Gardening failures and crashes
https://bugs.webkit.org/show_bug.cgi?id=85996

Unreviewed, EFL gardening.

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-05-09

  • platform/efl/test_expectations.txt:
8:55 AM Changeset in webkit [116530] by tommyw@google.com
  • 5 edits
    2 adds in trunk

MediaStream API: SessionDescription::addCandidate should not crash for malformed input
https://bugs.webkit.org/show_bug.cgi?id=85988

Reviewed by Adam Barth.

Source/WebCore:

Sending null would crash the browser. Added safeguards in both the bindings and the native code.

Test: fast/mediastream/SessionDescription.html

  • Modules/mediastream/SessionDescription.cpp:

(WebCore::SessionDescription::addCandidate):

  • Modules/mediastream/SessionDescription.h:

(SessionDescription):

  • Modules/mediastream/SessionDescription.idl:

LayoutTests:

  • fast/mediastream/SessionDescription-expected.txt: Added.
  • fast/mediastream/SessionDescription.html: Added.
8:49 AM Changeset in webkit [116529] by tommyw@google.com
  • 5 edits in trunk/Source

MediaStream API: Adding the possibility of port specific information in MediaStreamDescriptor
https://bugs.webkit.org/show_bug.cgi?id=85794

Reviewed by Adam Barth.

To facilitate for ports I have added an ExtraData field that can be used for whatever purpose is needed.

Source/Platform:

  • chromium/public/WebMediaStreamDescriptor.h:

(ExtraData):
(WebKit::WebMediaStreamDescriptor::ExtraData::~ExtraData):
(WebMediaStreamDescriptor):

Source/WebCore:

No behavioral changes.

  • platform/chromium/support/WebMediaStreamDescriptor.cpp:

(ExtraDataContainer):
(WebKit::ExtraDataContainer::ExtraDataContainer):
(WebKit::ExtraDataContainer::extraData):
(WebKit):
(WebKit::WebMediaStreamDescriptor::extraData):
(WebKit::WebMediaStreamDescriptor::setExtraData):

  • platform/mediastream/MediaStreamDescriptor.h:

(ExtraData):
(WebCore::MediaStreamDescriptor::ExtraData::~ExtraData):
(MediaStreamDescriptor):
(WebCore::MediaStreamDescriptor::extraData):
(WebCore::MediaStreamDescriptor::setExtraData):

8:45 AM Changeset in webkit [116528] by tommyw@google.com
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] MediaStream API: Fixing a memory leak in WebUserMediaRequest
https://bugs.webkit.org/show_bug.cgi?id=85992

Reviewed by Adam Barth.

  • src/WebUserMediaRequest.cpp:

(WebKit::WebUserMediaRequest::assign):

8:37 AM Changeset in webkit [116527] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Crash in WebCore::RenderBoxModelObject::paddingLeft
https://bugs.webkit.org/show_bug.cgi?id=83889

Patch by Takashi Sakamoto <tasak@google.com> on 2012-05-09
Reviewed by Abhishek Arya.

Source/WebCore:

RenderScrollbar creates RenderScrollbarPart without any parent
renderers. However, if the scrollbar has percent padding styles,
non-null parent renderer is required. So after creating/destroying
RenderScrollbarPart instances, set owningRenderer(creating)/0
(destroying) as its parent renderer.

Test: scrollbars/scrollbar-percent-padding-crash.html

scrollbars/scrollbar-percent-padding-crash-expected.txt

  • rendering/RenderScrollbar.cpp:

(WebCore::RenderScrollbar::updateScrollbarPart):
Added setParent after creating/destroying RenderScrollbarPart.

  • rendering/RenderScrollbarPart.cpp:

Made RenderScollbar friend, because setParent is protected and
RenderScrollbar is not inherited from class RenderObject.

LayoutTests:

As just invoking layoutTestController.display() invokes scrollbar's
WebCore::RenderScrollbarPart::paintIntoRect(), adding display() after
invoking layoutTestController.dumpAsText().

  • scrollbars/scrollbar-percent-padding-crash.html: Added.
  • scrollbars/scrollbar-percent-padding-crash-expected.txt: Added.
8:28 AM Changeset in webkit [116526] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[Chromium-android] Add unit test for Android layout test script (chromium_android.py)
https://bugs.webkit.org/show_bug.cgi?id=80852

Patch by Hao Zheng <zhenghao@chromium.org> on 2012-05-09
Reviewed by Adam Barth.

Add some tests to ensure that chromium android port works to some
extent. Some methods is hard to test, as they rely on the actual
behavior on device, e.g. pushing files to device.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.get_last_stacktrace): Check if dir exists.

  • Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:

(ChromiumAndroidPortTest):
(ChromiumAndroidPortTest.test_attributes):
(ChromiumAndroidPortTest.test_get_last_stacktrace):
(ChromiumAndroidPortTest.test_get_last_stacktrace.mock_run_command_no_dir):
(ChromiumAndroidPortTest.test_get_last_stacktrace.mock_run_command_no_file):
(ChromiumAndroidPortTest.test_get_last_stacktrace.mock_run_command_non_empty):
(ChromiumAndroidDriverTest):
(ChromiumAndroidDriverTest.setUp):
(ChromiumAndroidDriverTest.test_get_drt_return_value):
(ChromiumAndroidDriverTest.test_has_crash_hint):
(ChromiumAndroidDriverTest.test_read_prompt):
(ChromiumAndroidDriverTest.test_test_shell_command):
(ChromiumAndroidDriverTest.test_write_command_and_read_line):

8:23 AM Changeset in webkit [116525] by danw@gnome.org
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] don't use soup_session_pause_message in webkitdownload
https://bugs.webkit.org/show_bug.cgi?id=85931

Reviewed by Martin Robinson.

  • webkit/webkitdownload.cpp:

(webkit_download_new_with_handle):
(webkit_download_start):

8:14 AM Changeset in webkit [116524] by Antti Koivisto
  • 2 edits in trunk/LayoutTests

Skip failing test http/tests/loading/post-in-iframe-with-back-navigation.html.

Not reviewed.

  • platform/mac/Skipped:
7:40 AM Changeset in webkit [116523] by Antti Koivisto
  • 2 edits in trunk/LayoutTests

Test from bug 34875 should specify font-size
https://bugs.webkit.org/show_bug.cgi?id=85913

Not reviewed.

Skip fast/block/positioning/offsetLeft-offsetTop-multicolumn.html

  • platform/mac/Skipped:
6:19 AM Changeset in webkit [116522] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening a timeout failure
https://bugs.webkit.org/show_bug.cgi?id=85979

Unreviewed, EFL gardening.

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-05-09

  • platform/efl/test_expectations.txt: Adding font-face-download-error.html.
5:53 AM Changeset in webkit [116521] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

ShadowRoot needs applyAuthorStyles
https://bugs.webkit.org/show_bug.cgi?id=78472

Patch by Takashi Sakamoto <tasak@google.com> on 2012-05-09
Reviewed by Hajime Morita.

Source/WebCore:

Implemented applyAuthorStyles attribute defined in the following spec:
http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#shadow-root-attributes
Since applyAuthorSheets attribute has been already implemented,
renamed all applyAuthorSheets to applyAuthorStyles and
added applyAuthorStyles to ShadowRoot.idl.
Currently, changing dynamically applyAuthorStyles doesn't work. I will fix this isse in bugs:84215: https://bugs.webkit.org/show_bug.cgi?id=84251

Test: fast/dom/shadow/shadow-root-applyAuthorStyles.html

fast/dom/shadow/shadow-root-applyAuthorStyles-expected.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::applyAuthorStyles):
(WebCore::ShadowRoot::setApplyAuthorStyles):

  • dom/ShadowRoot.h:
  • dom/TreeScope.cpp:

(WebCore::TreeScope::applyAuthorStyles):

  • dom/TreeScope.h:

(TreeScope):
Changed all applyAuthorSheets to applyAuthorSytles.
(ShadowRoot):

  • dom/ShadowRoot.idl:

Added a new attribute, boolean applyAuthorStyles.

LayoutTests:

  • fast/dom/shadow/shadow-root-applyAuthorStyles.html:
  • fast/dom/shadow/shadow-root-applyAuthorStyles-expected.html:

Tested four cases:
case 1: applyAuthorStyles is false,
case 2: applyAuthorStyles is true with <script>..</script>,
case 3: applyAuthorStyles is true with inline script declaration, and
case 4: applyAuthorStyles is true with important UA property.
The case 1, 2 and 3 specify "span { ... }" with author styles and
verify rendering results.
The case 4 specifies '<input type="file" />' with an author style,
text-align: end, and verify rendering result.

5:39 AM Changeset in webkit [116520] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Tap-to-zoom zooms to wrong area.
https://bugs.webkit.org/show_bug.cgi?id=85982

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-09
Reviewed by Kenneth Rohde Christiansen.

Fix computation and take more care when to use CSS scale and when to use Item scale.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):

5:34 AM Changeset in webkit [116519] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] fast/overflow/scroll-div-hide-show.html testcase does not pass
https://bugs.webkit.org/show_bug.cgi?id=85960

Unreviewed. Gardening.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-09

  • platform/efl/Skipped: Skipping fast/overflow/scroll-div-hide-show.html.
5:22 AM Changeset in webkit [116518] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt] ORWT fails with Qt 5 and WK2.
https://bugs.webkit.org/show_bug.cgi?id=85968

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-09
Reviewed by Csaba Osztrogonác.

The Qt5 binary does not have a -style argument, so avoid using it.

  • Scripts/old-run-webkit-tests:
5:19 AM Changeset in webkit [116517] by commit-queue@webkit.org
  • 1 edit
    44 adds in trunk/LayoutTests

[EFL][DRT] Add baselines for new CSS cases after r116438
https://bugs.webkit.org/show_bug.cgi?id=85967

Unreviewed, add EFL baselines for new tests after r116438.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-09

  • platform/efl/css2.1/20110323/first-letter-000-expected.png: Added.
  • platform/efl/css2.1/20110323/first-letter-000-expected.txt: Added.
  • platform/efl/css2.1/20110323/first-letter-001-expected.png: Added.
  • platform/efl/css2.1/20110323/first-letter-001-expected.txt: Added.
  • platform/efl/css2.1/20110323/first-letter-dynamic-001-expected.png: Added.
  • platform/efl/css2.1/20110323/first-letter-dynamic-001-expected.txt: Added.
  • platform/efl/css2.1/20110323/first-letter-dynamic-002-expected.png: Added.
  • platform/efl/css2.1/20110323/first-letter-dynamic-002-expected.txt: Added.
  • platform/efl/css2.1/20110323/first-letter-dynamic-003a-expected.png: Added.
  • platform/efl/css2.1/20110323/first-letter-dynamic-003a-expected.txt: Added.
  • platform/efl/css2.1/20110323/first-letter-dynamic-003b-expected.png: Added.
  • platform/efl/css2.1/20110323/first-letter-dynamic-003b-expected.txt: Added.
  • platform/efl/css2.1/20110323/first-letter-inherit-001-expected.png: Added.
  • platform/efl/css2.1/20110323/first-letter-inherit-001-expected.txt: Added.
  • platform/efl/css2.1/20110323/first-letter-nested-001-expected.png: Added.
  • platform/efl/css2.1/20110323/first-letter-nested-001-expected.txt: Added.
  • platform/efl/css2.1/20110323/first-letter-nested-002-expected.png: Added.
  • platform/efl/css2.1/20110323/first-letter-nested-002-expected.txt: Added.
  • platform/efl/css2.1/20110323/first-letter-nested-003-expected.png: Added.
  • platform/efl/css2.1/20110323/first-letter-nested-003-expected.txt: Added.
  • platform/efl/css2.1/20110323/first-letter-nested-004-expected.png: Added.
  • platform/efl/css2.1/20110323/first-letter-nested-004-expected.txt: Added.
  • platform/efl/css2.1/20110323/first-letter-nested-005-expected.png: Added.
  • platform/efl/css2.1/20110323/first-letter-nested-005-expected.txt: Added.
  • platform/efl/css2.1/20110323/first-letter-nested-006-expected.png: Added.
  • platform/efl/css2.1/20110323/first-letter-nested-006-expected.txt: Added.
  • platform/efl/css2.1/20110323/first-letter-nested-007-expected.png: Added.
  • platform/efl/css2.1/20110323/first-letter-nested-007-expected.txt: Added.
  • platform/efl/css2.1/20110323/first-letter-quote-001-expected.png: Added.
  • platform/efl/css2.1/20110323/first-letter-quote-001-expected.txt: Added.
  • platform/efl/css2.1/20110323/first-letter-quote-002-expected.png: Added.
  • platform/efl/css2.1/20110323/first-letter-quote-002-expected.txt: Added.
  • platform/efl/css2.1/20110323/first-letter-quote-003-expected.png: Added.
  • platform/efl/css2.1/20110323/first-letter-quote-003-expected.txt: Added.
  • platform/efl/css2.1/20110323/first-letter-quote-004-expected.png: Added.
  • platform/efl/css2.1/20110323/first-letter-quote-004-expected.txt: Added.
  • platform/efl/css2.1/20110323/first-letter-quote-005-expected.png: Added.
  • platform/efl/css2.1/20110323/first-letter-quote-005-expected.txt: Added.
  • platform/efl/css2.1/20110323/first-letter-quote-006-expected.png: Added.
  • platform/efl/css2.1/20110323/first-letter-quote-006-expected.txt: Added.
  • platform/efl/fast/css/first-letter-nested-positioned-expected.png: Added.
  • platform/efl/fast/css/first-letter-nested-positioned-expected.txt: Added.
  • platform/efl/fast/css/first-letter-quotes-no-content-before-after-expected.png: Added.
  • platform/efl/fast/css/first-letter-quotes-no-content-before-after-expected.txt: Added.
5:11 AM Changeset in webkit [116516] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit2

[Qt][WK2] Define clear split between QtWebPageLoadClient and QQuickWebViewPrivate for loading tasks.
https://bugs.webkit.org/show_bug.cgi?id=84527#c3

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-05-09
Reviewed by Simon Hausmann.

Moving loading related code and signal emission from QtWebPageLoadClient to QQuickWebViewPrivate.
It puts the loading code that implements an API right where the API is defined, including
signal emission as well as translation of WebPageProxy internals to public Qt API with correct types.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::provisionalLoadDidStart):
(QQuickWebViewPrivate::loadDidCommit):
(QQuickWebViewPrivate::didSameDocumentNavigation):
(QQuickWebViewPrivate::titleDidChange):
(QQuickWebViewPrivate::loadProgressDidChange):
(QQuickWebViewPrivate::backForwardListDidChange):
(QQuickWebViewPrivate::loadDidFail):
(QQuickWebViewPrivate::processDidCrash):
(QQuickWebView::loadProgress):

  • UIProcess/API/qt/qquickwebview_p_p.h:

(WebKit):
(QQuickWebViewPrivate):
(QQuickWebViewPrivate::didChangeViewportProperties):
(QQuickWebViewPrivate::loadProgress):
(QQuickWebViewFlickablePrivate):

  • UIProcess/qt/QtWebError.cpp:

(WebKit::QtWebError::isCancellation):
(WebKit):

  • UIProcess/qt/QtWebError.h:
  • UIProcess/qt/QtWebPageLoadClient.cpp:

(WebKit::QtWebPageLoadClient::QtWebPageLoadClient):
(WebKit):
(WebKit::QtWebPageLoadClient::didStartProvisionalLoad):
(WebKit::QtWebPageLoadClient::didCommitLoad):
(WebKit::QtWebPageLoadClient::didSameDocumentNavigation):
(WebKit::QtWebPageLoadClient::didReceiveTitle):
(WebKit::QtWebPageLoadClient::didChangeProgress):
(WebKit::QtWebPageLoadClient::didChangeBackForwardList):
(WebKit::QtWebPageLoadClient::dispatchLoadFailed):
(WebKit::QtWebPageLoadClient::didFailProvisionalLoadWithErrorForFrame):
(WebKit::QtWebPageLoadClient::didFailLoadWithErrorForFrame):
(WebKit::QtWebPageLoadClient::didStartProgress):
(WebKit::QtWebPageLoadClient::didFinishProgress):

  • UIProcess/qt/QtWebPageLoadClient.h:

(WebKit):
(QtWebPageLoadClient):

4:38 AM Changeset in webkit [116515] by Csaba Osztrogonác
  • 1 edit
    56 adds in trunk/LayoutTests

[Qt] Unreviewed gardening, add platform specific expected files for new tests.

  • platform/qt/css2.1/20110323/first-letter-000-expected.png: Added.
  • platform/qt/css2.1/20110323/first-letter-000-expected.txt: Added.
  • platform/qt/css2.1/20110323/first-letter-001-expected.png: Added.
  • platform/qt/css2.1/20110323/first-letter-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/first-letter-dynamic-001-expected.png: Added.
  • platform/qt/css2.1/20110323/first-letter-dynamic-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/first-letter-dynamic-002-expected.png: Added.
  • platform/qt/css2.1/20110323/first-letter-dynamic-002-expected.txt: Added.
  • platform/qt/css2.1/20110323/first-letter-dynamic-003a-expected.png: Added.
  • platform/qt/css2.1/20110323/first-letter-dynamic-003a-expected.txt: Added.
  • platform/qt/css2.1/20110323/first-letter-dynamic-003b-expected.png: Added.
  • platform/qt/css2.1/20110323/first-letter-dynamic-003b-expected.txt: Added.
  • platform/qt/css2.1/20110323/first-letter-inherit-001-expected.png: Added.
  • platform/qt/css2.1/20110323/first-letter-inherit-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/first-letter-nested-001-expected.png: Added.
  • platform/qt/css2.1/20110323/first-letter-nested-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/first-letter-nested-002-expected.png: Added.
  • platform/qt/css2.1/20110323/first-letter-nested-002-expected.txt: Added.
  • platform/qt/css2.1/20110323/first-letter-nested-003-expected.png: Added.
  • platform/qt/css2.1/20110323/first-letter-nested-003-expected.txt: Added.
  • platform/qt/css2.1/20110323/first-letter-nested-004-expected.png: Added.
  • platform/qt/css2.1/20110323/first-letter-nested-004-expected.txt: Added.
  • platform/qt/css2.1/20110323/first-letter-nested-005-expected.png: Added.
  • platform/qt/css2.1/20110323/first-letter-nested-005-expected.txt: Added.
  • platform/qt/css2.1/20110323/first-letter-nested-006-expected.png: Added.
  • platform/qt/css2.1/20110323/first-letter-nested-006-expected.txt: Added.
  • platform/qt/css2.1/20110323/first-letter-nested-007-expected.png: Added.
  • platform/qt/css2.1/20110323/first-letter-nested-007-expected.txt: Added.
  • platform/qt/css2.1/20110323/first-letter-quote-001-expected.png: Added.
  • platform/qt/css2.1/20110323/first-letter-quote-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/first-letter-quote-002-expected.png: Added.
  • platform/qt/css2.1/20110323/first-letter-quote-002-expected.txt: Added.
  • platform/qt/css2.1/20110323/first-letter-quote-003-expected.png: Added.
  • platform/qt/css2.1/20110323/first-letter-quote-003-expected.txt: Added.
  • platform/qt/css2.1/20110323/first-letter-quote-004-expected.png: Added.
  • platform/qt/css2.1/20110323/first-letter-quote-004-expected.txt: Added.
  • platform/qt/css2.1/20110323/first-letter-quote-005-expected.png: Added.
  • platform/qt/css2.1/20110323/first-letter-quote-005-expected.txt: Added.
  • platform/qt/css2.1/20110323/first-letter-quote-006-expected.png: Added.
  • platform/qt/css2.1/20110323/first-letter-quote-006-expected.txt: Added.
  • platform/qt/fast/block/float/avoiding-float-centered-expected.png: Added.
  • platform/qt/fast/block/float/avoiding-float-centered-expected.txt: Added.
  • platform/qt/fast/css/first-letter-nested-positioned-expected.png: Added.
  • platform/qt/fast/css/first-letter-nested-positioned-expected.txt: Added.
  • platform/qt/fast/css/first-letter-quotes-no-content-before-after-expected.png: Added.
  • platform/qt/fast/css/first-letter-quotes-no-content-before-after-expected.txt: Added.
  • platform/qt/fast/html/details-marker-style-expected.png: Added.
  • platform/qt/fast/html/details-marker-style-expected.txt: Added.
  • platform/qt/fast/images/png-suite/test-expected.txt: Added.
  • platform/qt/fast/text/international/text-spliced-font-expected.png: Added.
  • platform/qt/fast/text/international/text-spliced-font-expected.txt: Added.
  • platform/qt/svg/as-image/image-respects-pageScaleFactor-expected.png: Added.
  • platform/qt/svg/as-image/image-respects-pageScaleFactor-expected.txt: Added.
  • platform/qt/svg/custom/path-zero-strokewidth-expected.png: Added.
  • platform/qt/svg/custom/path-zero-strokewidth-expected.txt: Added.
4:13 AM Changeset in webkit [116514] by Csaba Osztrogonác
  • 1 edit
    1 add in trunk/LayoutTests

[Qt] Unreviewed gardening, add a platform specific expected file for a passing test.

  • platform/qt-5.0-wk2/fast/repaint/focus-ring-expected.txt: Added.
4:10 AM Changeset in webkit [116513] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

[Chromium][Forms] HTMLOptionsCollection doesn't have indexed properties on property enumeration
https://bugs.webkit.org/show_bug.cgi?id=85937

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-05-09
Reviewed by Kentaro Hara.

Source/WebCore:

This patch adds numeric indices to properties in enumeration to HTMLOptionsCollection V8 binding
to changes Objects.keys in ECMAScript5 and for-in statement behavior for compatibility with
Firefox 12, IE9, Opera 11, and Safari 5.

Test: fast/forms/select/options-indexed-properties.html

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateImplementationIndexer): Set $hasEnumerator true for interface HTMLOptionsCollection

LayoutTests:

  • fast/forms/select/options-indexed-properties-expected.txt: Added.
  • fast/forms/select/options-indexed-properties.html: Added.
  • platform/chromium/inspector/console/console-format-collections-expected.txt: Changed for HTMLOptionCollection printed output
4:02 AM Changeset in webkit [116512] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] http/tests/loading/post-in-iframe-with-back-navigation.html fails
https://bugs.webkit.org/show_bug.cgi?id=85974

Unreviewed EFL gardening.

Move http/tests/loading/post-in-iframe-with-back-navigation.html to
test_expectations.txt. This test was added in r116473 but fails on all
the bots.

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-09

  • platform/efl/test_expectations.txt:
3:49 AM Changeset in webkit [116511] by tommyw@google.com
  • 6 edits
    2 adds in trunk/LayoutTests

MediaStream API: Adding a test for constructed from JS MediaStreams
https://bugs.webkit.org/show_bug.cgi?id=85883

Reviewed by Kent Tamura.

Also moved shouldNotThrow to js-test-pre, and removed it from all mediastream tests.

  • fast/js/resources/js-test-pre.js:

(shouldNotThrow):

  • fast/mediastream/MediaStreamConstructor-expected.txt: Added.
  • fast/mediastream/MediaStreamConstructor.html: Added.
  • fast/mediastream/peerconnection-argument-types-expected.txt:
  • fast/mediastream/peerconnection-iceoptions.html:
  • fast/mediastream/script-tests/argument-types.js:
  • fast/mediastream/script-tests/peerconnection-argument-types.js:
3:01 AM Changeset in webkit [116510] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update for media-stream tests
https://bugs.webkit.org/show_bug.cgi?id=85952

  • platform/chromium/test_expectations.txt:
2:37 AM Changeset in webkit [116509] by Csaba Osztrogonác
  • 2 edits
    1 delete in trunk/LayoutTests

[Qt] Gardening. Skip a failing test, remove an unnecessary platform specific expected file.
https://bugs.webkit.org/show_bug.cgi?id=85969

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-05-09
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
  • platform/qt/fast/forms/form-collection-radio-node-list-expected.txt: Removed after r116491.
2:26 AM Changeset in webkit [116508] by shinyak@chromium.org
  • 11 edits
    7 adds in trunk

Position should be able to have ShadowRoot as a container.
https://bugs.webkit.org/show_bug.cgi?id=82021

Reviewed by Ryosuke Niwa.

Source/WebCore:

Since Position could not take a shadow root as a container node, pointing the direct children
of a shadow root was difficult.

This patch makes it enabled, and fixes a lot of crashes caused by that limitation.
Also, we confirm that ShadowRoot is not exposed to JavaScript layer.

Currently this change is only enabled if shadow dom flag is enabled, since we cannot
prove this change does not destroy the existing behavior. However, this change is really required
to fix other editing bugs in Shadow DOM. A bunch of patches and tests will be added to
fix other editing bugs and they will check this patch does not break editing.
We will also add a fuzzer to check the stability of editing in Shadow DOM later, and it will
also help to confirm the patch will not break the editing.

Tests: editing/shadow/doubleclick-on-meter-in-shadow-crash.html

editing/shadow/rightclick-on-meter-in-shadow-crash.html
editing/shadow/shadow-selection-not-exported.html

  • dom/Position.cpp:

(WebCore::Position::Position):
(WebCore::Position::containerNode):
(WebCore::Position::parentAnchoredEquivalent):
(WebCore::Position::previous):
(WebCore::Position::next):
(WebCore::Position::atStartOfTree):
(WebCore::Position::atEndOfTree):
(WebCore::Position::findParent):

  • dom/Position.h:

(WebCore):
(WebCore::positionInParentBeforeNode):
(WebCore::positionInParentAfterNode):

LayoutTests:

Skipped non-chromium port since SHADOW_DOM flag is not enabled in those platforms.
We will add bunch of tests for editing in Shadow DOM into editing/shadow later,
so I added the whole directory name to the skipped list.

  • editing/shadow/doubleclick-on-meter-in-shadow-crash-expected.txt: Added.
  • editing/shadow/doubleclick-on-meter-in-shadow-crash.html: Added.
  • editing/shadow/rightclick-on-meter-in-shadow-crash-expected.txt: Added.
  • editing/shadow/rightclick-on-meter-in-shadow-crash.html: Added.
  • editing/shadow/shadow-selection-not-exported-expected.txt: Added.
  • editing/shadow/shadow-selection-not-exported.html: Added.
  • platform/efl/Skipped:
  • platform/gtk/test_expectations.txt:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
2:07 AM Changeset in webkit [116507] by zoltan@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Build fix when using libpng version != 1.2
https://bugs.webkit.org/show_bug.cgi?id=85614

Reviewed by Eric Seidel.

Don't enforce the version of libpng when passing the option to the linker.

No new tests, no intended functionality change.

  • WebCore.pri:
2:04 AM Changeset in webkit [116506] by commit-queue@webkit.org
  • 8 edits in trunk

[EFL][DRT] LayoutTestController addUserScript implementation
https://bugs.webkit.org/show_bug.cgi?id=84718

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-09
Reviewed by Antonio Gomes.

Source/WebKit/efl:

Added helper functions for adding/clearing of user scripts.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::addUserScript):
(DumpRenderTreeSupportEfl::clearUserScripts):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Added implementation of addUserScript() to LayoutTestController.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues): clear added user scripts

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::addUserScript): added implementation

LayoutTests:

Unskipped corresponding testcases.

  • platform/efl/Skipped:
1:42 AM Changeset in webkit [116505] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] Remove delayed loadDidSucceed() signaling and m_deferedUrlToLoad from QQuickWebViewPrivate
https://bugs.webkit.org/show_bug.cgi?id=85906

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-05-09
Reviewed by Kenneth Rohde Christiansen.

Deferred loading activies were introduced to work around the delayed Flickable construction
at onComponentComplete(). QQuickWebView inherits from QQuickFlickable now,
so no need for the workaround anymore.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewFlickablePrivate::QQuickWebViewFlickablePrivate):
(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebView::setUrl):
(QQuickWebView::componentComplete):

  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate::onComponentComplete):
(QQuickWebViewPrivate):
(QQuickWebViewFlickablePrivate):

1:34 AM Changeset in webkit [116504] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update.

  • platform/chromium/test_expectations.txt:

video-media-source-seek.html is also SLOW?

12:54 AM Changeset in webkit [116503] by tkent@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Disable WebViewTest.TextInputType because the test is incomplete.

  • tests/WebViewTest.cpp:
12:51 AM Changeset in webkit [116502] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] http/tests/loading/pdf-commit-load-callbacks.html is failing
https://bugs.webkit.org/show_bug.cgi?id=85957

Unreviewed gardening.

Move http/tests/loading/pdf-commit-load-callbacks.html to
test_expectations.txt while Bug 85956 is fixed.

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-09

  • platform/efl/test_expectations.txt:
12:46 AM Changeset in webkit [116501] by mitz@apple.com
  • 3 edits in trunk/Tools

Made build-webkit copy WebKitLibraries to the right location again after r116257

Reviewed by Mark Rowe.

  • Scripts/build-webkit: Pass the built product directory to copy-webkitlibraries-to-product-directory.
  • Scripts/copy-webkitlibraries-to-product-directory: Use the first argument, if present, as the

product directory.

12:42 AM Changeset in webkit [116500] by tkent@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Some of *.runMultiThread tests intermittently crash.
Mark them flaky.

  • tests/CCLayerTreeHostTest.cpp:
12:19 AM Changeset in webkit [116499] by commit-queue@webkit.org
  • 21 edits
    13 adds in trunk/Source

Source/WebCore: Add identifying methods for date/time input types.

This patch adds methods isDateField(), isDateTimeField(), isDateTimeLocalField(),
isMonthField(), isTimeField() and isWeekField() to InputType and the appropriate
HTMLInputElement classes, to allow date/time input types to be identified.

The new methods match the existing methods for types such as email, search and number.

https://bugs.webkit.org/show_bug.cgi?id=78746

Patch by Oli Lan <olilan@chromium.org> on 2012-05-09
Reviewed by Kent Tamura.

A new test WebViewTest.TextInputType has been added in WebKit/chromium/tests that calls
through to these methods via WebViewImpl.textInputType().

  • html/DateInputType.cpp:

(WebCore::DateInputType::isDateField):
(WebCore):

  • html/DateInputType.h:

(DateInputType):

  • html/DateTimeInputType.cpp:

(WebCore::DateTimeInputType::isDateTimeField):
(WebCore):

  • html/DateTimeInputType.h:

(DateTimeInputType):

  • html/DateTimeLocalInputType.cpp:

(WebCore::DateTimeLocalInputType::isDateTimeLocalField):
(WebCore):

  • html/DateTimeLocalInputType.h:

(DateTimeLocalInputType):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::isDateField):
(WebCore):
(WebCore::HTMLInputElement::isDateTimeField):
(WebCore::HTMLInputElement::isDateTimeLocalField):
(WebCore::HTMLInputElement::isMonthField):
(WebCore::HTMLInputElement::isTimeField):
(WebCore::HTMLInputElement::isWeekField):

  • html/HTMLInputElement.h:

(HTMLInputElement):

  • html/InputType.cpp:

(WebCore::InputType::isDateField):
(WebCore):
(WebCore::InputType::isDateTimeField):
(WebCore::InputType::isDateTimeLocalField):
(WebCore::InputType::isMonthField):
(WebCore::InputType::isTimeField):
(WebCore::InputType::isWeekField):

  • html/InputType.h:

(InputType):

  • html/MonthInputType.cpp:

(WebCore::MonthInputType::isMonthField):
(WebCore):

  • html/MonthInputType.h:

(MonthInputType):

  • html/TimeInputType.cpp:

(WebCore::TimeInputType::isTimeField):
(WebCore):

  • html/TimeInputType.h:

(TimeInputType):

  • html/WeekInputType.cpp:

(WebCore::WeekInputType::isWeekField):
(WebCore):

  • html/WeekInputType.h:

(WeekInputType):

Source/WebKit/chromium: Adds date/time input types to WebTextInputType, and adds support for these
to WebViewImpl.textInputType().

Adds a new test WebViewTest.TextInputType to test WebViewImpl.textInputType(),
including the new types.

https://bugs.webkit.org/show_bug.cgi?id=78746

Patch by Oli Lan <olilan@chromium.org> on 2012-05-09
Reviewed by Kent Tamura.

  • public/WebTextInputType.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::textInputType):

  • tests/WebViewTest.cpp:

(WebViewTest):
(WebKit::WebViewTest::testTextInputType):
(WebKit):
(WebKit::TEST_F):

  • tests/data/input_field_date.html: Added.
  • tests/data/input_field_datetime.html: Added.
  • tests/data/input_field_default.html: Added.
  • tests/data/input_field_email.html: Added.
  • tests/data/input_field_number.html: Added.
  • tests/data/input_field_search.html: Added.
  • tests/data/input_field_time.html: Added.
  • tests/data/input_field_week.html: Added.
12:17 AM Changeset in webkit [116498] by Nikolas Zimmermann
  • 8 edits
    4 adds in trunk

REGRESSION(r105057): Infinite loop inside SVGTextLayoutEngine::currentLogicalCharacterMetrics
https://bugs.webkit.org/show_bug.cgi?id=83405

Reviewed by Darin Adler.

Source/WebCore:

Dynamically adding tspans carrying position information in the x/y/dx/dy/rotate lists is broken.
To avoid mistakes like this in future, simplify the calling code in RenderSVGInlineText and centralize
the managment of all caches (text positioning element cache / metrics map / layout attributes) in
RenderSVGText. This avoids the hack in SVGRootInlineBox::computePerCharacterLayoutInformation() which
called textRoot->rebuildLayoutAttributes(), which was used to fix previous security issues with this code.
Instead correctly handle destruction of RenderSVGInlineText in RenderSVGText, keeping the m_layoutAttributes
synchronized with the current state of the render tree. Fixes highcharts problems.

Tests: svg/text/add-tspan-position-bug.html

svg/text/modify-tspan-position-bug.html

  • rendering/svg/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::addChild):

  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::willBeDestroyed):
(WebCore::RenderSVGInlineText::setTextInternal):
(WebCore::RenderSVGInlineText::styleDidChange):

  • rendering/svg/RenderSVGText.cpp:

(WebCore::recursiveUpdateMetrics):
(WebCore::RenderSVGText::subtreeChildAdded):
(WebCore::RenderSVGText::subtreeChildWillBeDestroyed):
(WebCore::recursiveCollectLayoutAttributes):
(WebCore::checkLayoutAttributesConsistency):
(WebCore::RenderSVGText::subtreeChildWasDestroyed):
(WebCore::RenderSVGText::subtreeStyleChanged):
(WebCore::RenderSVGText::subtreeTextChanged):
(WebCore::RenderSVGText::layout):
(WebCore::RenderSVGText::addChild):
(WebCore::RenderSVGText::rebuildAllLayoutAttributes):
(WebCore::RenderSVGText::rebuildLayoutAttributes):

  • rendering/svg/RenderSVGText.h:

(WebCore::RenderSVGText::layoutAttributes):

  • rendering/svg/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):

  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp:

(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributes):

LayoutTests:

Add two new testcases covering the problem.

  • svg/text/add-tspan-position-bug-expected.html: Added.
  • svg/text/add-tspan-position-bug.html: Added.
  • svg/text/modify-tspan-position-bug-expected.html: Added.
  • svg/text/modify-tspan-position-bug.html: Added.
12:07 AM SettingUpDevelopmentEnvironmentForN9 edited by zarvai@inf.u-szeged.hu
(diff)
Note: See TracTimeline for information about the timeline view.