Timeline



Jun 30, 2012:

8:54 PM Changeset in webkit [121633] by fpizlo@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

JSObject wastes too much memory on unused property slots
https://bugs.webkit.org/show_bug.cgi?id=90255

Reviewed by Mark Hahnenberg.

Rolling back in after applying a simple fix: it appears that
JSObject::setStructureAndReallocateStorageIfNecessary() was allocating more
property storage than necessary. Fixing this appears to resolve the crash.

This does a few things:

  • JSNonFinalObject no longer has inline property storage.


  • Initial out-of-line property storage size is 4 slots for JSNonFinalObject, or 2x the inline storage for JSFinalObject.


  • Property storage is only reallocated if it needs to be. Previously, we would reallocate the property storage on any transition where the original structure said shouldGrowProperyStorage(), but this led to spurious reallocations when doing transitionless property adds and there are deleted property slots available. That in turn led to crashes, because we would switch to out-of-line storage even if the capacity matched the criteria for inline storage.


  • Inline JSFunction allocation is killed off because we don't have a good way of inlining property storage allocation. This didn't hurt performance. Killing off code is better than fixing it if that code wasn't doing any good.


This looks like a 1% progression on V8.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:
  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicJSObject):
(JSC):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_new_func):
(JSC):
(JSC::JIT::emit_op_new_func_exp):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::finishCreation):

  • runtime/JSObject.h:

(JSC::JSObject::isUsingInlineStorage):
(JSObject):
(JSC::JSObject::finishCreation):
(JSC):
(JSC::JSNonFinalObject::hasInlineStorage):
(JSNonFinalObject):
(JSC::JSNonFinalObject::JSNonFinalObject):
(JSC::JSNonFinalObject::finishCreation):
(JSC::JSFinalObject::hasInlineStorage):
(JSC::JSFinalObject::finishCreation):
(JSC::JSObject::offsetOfInlineStorage):
(JSC::JSObject::setPropertyStorage):
(JSC::Structure::inlineStorageCapacity):
(JSC::Structure::isUsingInlineStorage):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::setStructureAndReallocateStorageIfNecessary):
(JSC::JSObject::putDirectWithoutTransition):

  • runtime/Structure.cpp:

(JSC::Structure::Structure):
(JSC::nextPropertyStorageCapacity):
(JSC):
(JSC::Structure::growPropertyStorageCapacity):
(JSC::Structure::suggestedNewPropertyStorageSize):

  • runtime/Structure.h:

(JSC::Structure::putWillGrowPropertyStorage):
(Structure):

4:32 PM Changeset in webkit [121632] by eae@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

Unreviewed chromium rebaseline for svg/zoom.

  • platform/chromium-linux-x86/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/chromium-win-xp/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/chromium-win-xp/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/chromium-win-xp/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Added.
4:29 PM Changeset in webkit [121631] by eae@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium windows rebaseline.

  • platform/chromium-win-xp/http/tests/inspector/resource-tree/resource-request-content-while-loading-expected.txt:
3:54 PM Changeset in webkit [121630] by commit-queue@webkit.org
  • 4 edits in trunk

[BlackBerry] WebView/Browser cause blank screen when selecting a dropdown field.
https://bugs.webkit.org/show_bug.cgi?id=90241

This issue is caused by single quotes in option's labels.
We should use the escape character of single quotes in JavaScript's string which
starts and ends with single quotes.
So we replace lablels' single quotes with its escape character during generating the
select popUp's HTML.

.:

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-06-30
Reviewed by George Staikos.

  • ManualTests/blackberry/select-popup-items-unicode-display.html:

Source/WebKit/blackberry:

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-06-30
Reviewed by George Staikos.

  • WebCoreSupport/SelectPopupClient.cpp:

(WebCore::SelectPopupClient::generateHTML):

12:28 PM Changeset in webkit [121629] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

Webkit crashes in DFG on Google Docs when creating a new document
https://bugs.webkit.org/show_bug.cgi?id=90209

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

Don't attempt to short-circuit Phantom(GetLocal) if the GetLocal is for a
captured variable.

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::mergeBlocks):

LayoutTests:

Reviewed by Gavin Barraclough.

  • fast/js/dfg-cfg-simplify-phantom-get-local-on-same-block-set-local-expected.txt: Added.
  • fast/js/dfg-cfg-simplify-phantom-get-local-on-same-block-set-local.html: Added.
  • fast/js/script-tests/dfg-cfg-simplify-phantom-get-local-on-same-block-set-local.js: Added.

(baz):
(stuff):
(foo):
(o.g):

8:55 AM Changeset in webkit [121628] by commit-queue@webkit.org
  • 22 edits
    1 add in trunk/Source

[chromium] CanvasLayerTextureUpdater needs to convert opaque rects back to content space.
https://bugs.webkit.org/show_bug.cgi?id=90092

The CanvasLayerTextureUpdater currently receives its opaque rects in
layer space, but is expected to return them in content space and does
not convert them. This patch adds this conversion. To avoid numerical
errors, this patch also switches to using float rects to store opaque
rects where appropriate.

Patch by Ian Vollick <vollick@chromium.org> on 2012-06-30
Reviewed by Adrienne Walker.

Source/Platform:

  • chromium/public/WebContentLayerClient.h:

(WebKit):
(WebContentLayerClient):

Source/WebCore:

Unit test: ContentLayerTest.ContentLayerPainterWithDeviceScale

  • platform/graphics/chromium/CanvasLayerTextureUpdater.cpp:

(WebCore::CanvasLayerTextureUpdater::paintContents):

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerPainter::ContentLayerPainter):
(WebCore::ContentLayerPainter::create):
(WebCore::ContentLayerPainter::paint):

  • platform/graphics/chromium/ContentLayerChromium.h:

(WebCore):
(ContentLayerDelegate):
(ContentLayerPainter):

  • platform/graphics/chromium/LayerPainterChromium.h:

(WebCore):
(LayerPainterChromium):

  • platform/graphics/chromium/LinkHighlight.cpp:

(WebCore::LinkHighlight::paintContents):

  • platform/graphics/chromium/LinkHighlight.h:

(LinkHighlight):

  • platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp:

(WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents):

  • platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.h:

(OpaqueRectTrackingContentLayerDelegate):

  • platform/graphics/chromium/ScrollbarLayerChromium.cpp:

Source/WebKit/chromium:

  • WebKit.gypi:
  • src/WebContentLayerImpl.cpp:

(WebKit::WebContentLayerImpl::paintContents):

  • src/WebContentLayerImpl.h:

(WebContentLayerImpl):

  • tests/CCLayerTreeHostCommonTest.cpp:
  • tests/CCLayerTreeHostTest.cpp:

(WTF::TestOpacityChangeLayerDelegate::paintContents):
(WTF::MockContentLayerDelegate::paintContents):

  • tests/ContentLayerChromiumTest.cpp: Added.

(WebKit):
(OpaqueRectDrawingGraphicsContextPainter):
(WebKit::OpaqueRectDrawingGraphicsContextPainter::OpaqueRectDrawingGraphicsContextPainter):
(WebKit::OpaqueRectDrawingGraphicsContextPainter::~OpaqueRectDrawingGraphicsContextPainter):
(MockContentLayerDelegate):
(WebKit::MockContentLayerDelegate::MockContentLayerDelegate):
(WebKit::TEST):

  • tests/LayerChromiumTest.cpp:
  • tests/OpaqueRectTrackingContentLayerDelegateTest.cpp:

(WebCore::TEST_F):

  • tests/TiledLayerChromiumTest.cpp:
  • tests/WebLayerTest.cpp:
5:09 AM Changeset in webkit [121627] by zandobersek@gmail.com
  • 10 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r121605.
http://trac.webkit.org/changeset/121605
https://bugs.webkit.org/show_bug.cgi?id=90336

Changes caused flaky crashes in sputnik/Unicode tests on Apple
WK1 and GTK Linux builders

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:
  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicJSObject):
(JSC::JIT::emitAllocateJSFinalObject):
(JSC):
(JSC::JIT::emitAllocateJSFunction):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_new_func):
(JSC::JIT::emitSlow_op_new_func):
(JSC):
(JSC::JIT::emit_op_new_func_exp):
(JSC::JIT::emitSlow_op_new_func_exp):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::finishCreation):

  • runtime/JSObject.h:

(JSC::JSObject::isUsingInlineStorage):
(JSObject):
(JSC::JSObject::finishCreation):
(JSC):
(JSNonFinalObject):
(JSC::JSNonFinalObject::JSNonFinalObject):
(JSC::JSNonFinalObject::finishCreation):
(JSFinalObject):
(JSC::JSFinalObject::finishCreation):
(JSC::JSObject::offsetOfInlineStorage):
(JSC::JSObject::setPropertyStorage):
(JSC::Structure::isUsingInlineStorage):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirectWithoutTransition):
(JSC::JSObject::transitionTo):

  • runtime/Structure.cpp:

(JSC::Structure::Structure):
(JSC):
(JSC::Structure::growPropertyStorageCapacity):
(JSC::Structure::suggestedNewPropertyStorageSize):

  • runtime/Structure.h:

(JSC::Structure::shouldGrowPropertyStorage):
(JSC::Structure::propertyStorageSize):

4:56 AM Changeset in webkit [121626] by jpetsovits@rim.com
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Allow surface resizing for use cases other than rotation.
https://bugs.webkit.org/show_bug.cgi?id=90295
RIM PR 171459

Reviewed by George Staikos.

A new API method setHasPendingSurfaceSizeChange() is
introduced for that effect, and used inside of
setViewportSize() to let the WebPageClient do the
resizing. Methods are renamed to reflect that this
is not exclusively meant for rotation anymore.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPage::setScreenOrientation):
(WebKit):
(BlackBerry::WebKit::WebPage::setHasPendingSurfaceSizeChange):
(BlackBerry::WebKit::WebPagePrivate::resizeSurfaceIfNeeded):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):

  • Api/WebPage.h:
  • Api/WebPageClient.h:
  • Api/WebPage_p.h:

(WebPagePrivate):

3:39 AM Changeset in webkit [121625] by zandobersek@gmail.com
  • 3 edits in trunk/LayoutTests

Unreviewed GTK and EFL gardening, adding image expectation
for the failing css3/flexbox/anonymous-block.html test.

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
3:21 AM Changeset in webkit [121624] by zandobersek@gmail.com
  • 4 edits
    1 add in trunk/LayoutTests

Unreviewed GTK gardening, updating baselines after r121599.

  • platform/gtk/fast/transforms/bounding-rect-zoom-expected.txt: Added.
  • platform/gtk/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
2:29 AM Changeset in webkit [121623] by kseo@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed. Remove unused declaration.
HTMLDocumentParser::begin() has no method definition.

  • html/parser/HTMLDocumentParser.h:

Jun 29, 2012:

10:02 PM Changeset in webkit [121622] by abarth@webkit.org
  • 2 edits in trunk/Tools

Turns out we need zip too.

  • EWSTools/cold-boot.sh:
10:00 PM Changeset in webkit [121621] by abarth@webkit.org
  • 2 edits
    1 add in trunk/Tools

Add a cold-boot.sh script for the EWS
https://bugs.webkit.org/show_bug.cgi?id=90330

Unreviewed.

  • EWSTools/cold-boot.sh: Added.
    • This script can take us from a cold GCE instance to a running EWS bot in one fell swoop.
  • EWSTools/start-queue.sh:
    • The if-block at the top of this script was causing trouble. I removed it from the bots a while ago. Now that we're using SVN to cold-boot the EWS bots, we need to make this change in the repo.
9:18 PM Changeset in webkit [121620] by commit-queue@webkit.org
  • 7 edits
    18 adds in trunk

[Qt][WK2] Private non-QtQuick API
https://bugs.webkit.org/show_bug.cgi?id=84532

.:

Patch by Luiz Agostini <luiz.agostini@nokia.com> on 2012-06-29
Reviewed by Noam Rosenthal.

API tests for QRawWebView.

  • Source/tests.pri:

Source/WebKit2:

Patch by Luiz Agostini <luiz.agostini@nokia.com> on 2012-06-29
Reviewed by Noam Rosenthal.

Adding new private non-QtQuick API. This new C++ API makes it possible
to have control over the lower levels of WebKit without going via QML.

This is a first version of the API, enough to show pages on the screen.
Many features are not implemented.

  • Target.pri:
  • UIProcess/API/qt/raw/qrawwebview.cpp: Added.
  • UIProcess/API/qt/raw/qrawwebview_p.h: Added.
  • UIProcess/API/qt/raw/qrawwebview_p_p.h: Added.

The tests for the new API are pixel tests. They use QRawWebView to load
html files and generate images, and them compare those images to the ones
in UIProcess/API/qt/tests/html/resources.

  • UIProcess/API/qt/tests/html/bluesquare.html: Added.
  • UIProcess/API/qt/tests/html/redsquare.html: Added.
  • UIProcess/API/qt/tests/html/resources/qwkview_noBackground1.png: Added.
  • UIProcess/API/qt/tests/html/resources/qwkview_noBackground3.png: Added.
  • UIProcess/API/qt/tests/html/resources/qwkview_paint.png: Added.
  • UIProcess/API/qt/tests/qrawwebview/qrawwebview.pro: Added.
  • UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp: Added.

Tools:

MiniBrowserRaw is an usage example for the QRawWebView API.
It is only an example and is not fully implemented.

Patch by Luiz Agostini <luiz.agostini@nokia.com> on 2012-06-29
Reviewed by Noam Rosenthal.

  • MiniBrowser/qt/raw/DerivedSources.pri: Added.
  • MiniBrowser/qt/raw/MiniBrowserRaw.pro: Added.
  • MiniBrowser/qt/raw/Target.pri: Added.
  • MiniBrowser/qt/raw/View.cpp: Added.
  • MiniBrowser/qt/raw/View.h: Added.
  • Scripts/webkitpy/style/checker.py:
  • Tools.pro:
8:54 PM Changeset in webkit [121619] by ojan@chromium.org
  • 4 edits in trunk/Tools

Remove leopard bots from garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=90328

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
8:52 PM Changeset in webkit [121618] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r121569.
http://trac.webkit.org/changeset/121569
https://bugs.webkit.org/show_bug.cgi?id=90082

It broke a couple of tests in Qt Linux Release

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::fillRect):

8:36 PM Changeset in webkit [121617] by ojan@chromium.org
  • 3 edits in trunk/Tools

garden-o-matic broken: TypeError: 'undefined' is not an object (evaluating 'buildLocations[currentIndex].url')
https://bugs.webkit.org/show_bug.cgi?id=90243

Reviewed by Dirk Pranke.

jQuery was trying to be too smart and parsing the jsonp as json because of it's content-type.
Excise jQuery and just use XHR directly since it's easier to maintain something where we control it
all.

Not really sure how to unittest this. I tested it all manually of course.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:

Made net.ajax a drop-in replacement for the features of $.ajax that we were using.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:

Not related to this patch, but figured I'd update the failing test while I was at it.

8:36 PM Changeset in webkit [121616] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

updateDescendantDependentFlags() is inside #if USE(ACCELERATED_COMPOSITING)
https://bugs.webkit.org/show_bug.cgi?id=90245

Reviewed by Dan Bernstein.

updateDescendantDependentFlags() and updateTransform() should be
outside the USE(ACCELERATED_COMPOSITING) #ifdef. They do work
that is needed even if accelerated compositing is disabled.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::styleChanged):

8:32 PM Changeset in webkit [121615] by arv@chromium.org
  • 7 edits
    4 adds in trunk

[V8] HTMLCollection wrappers are not retained
https://bugs.webkit.org/show_bug.cgi?id=90208

Reviewed by Adam Barth.

Source/WebCore:

Generate visitDOMWrapper for HTMLCollection and HTMLAllCollection so that we add an implicit reference from the owner
to the collection.

Tests: fast/dom/htmlallcollection-reachable.html

fast/dom/htmlcollection-reachable.html

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation): Instead of hard coding to use base() for HTMLAllCollection and HTMLCollection we now
annotate the IDL file to use GenerateIsReachable=ImplBaseRoot.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateVisitDOMWrapper): Generate visitDOMWrapper if GenerateIsReachable is ImplBaseRoot.

  • bindings/scripts/IDLAttributes.txt: Added ImplBaseRoot.
  • html/HTMLAllCollection.idl: Added annotations.
  • html/HTMLCollection.idl: Ditto.

LayoutTests:

  • fast/dom/htmlallcollection-reachable-expected.txt: Added.
  • fast/dom/htmlallcollection-reachable.html: Added.
  • fast/dom/htmlcollection-reachable-expected.txt: Added.
  • fast/dom/htmlcollection-reachable.html: Added.
8:27 PM Changeset in webkit [121614] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Fix layout test runner for Android after https://bugs.webkit.org/show_bug.cgi?id=88134
https://bugs.webkit.org/show_bug.cgi?id=90309

Patch by Yaron Friedman <yfriedman@chromium.org> on 2012-06-29
Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.start_http_server):

8:16 PM Changeset in webkit [121613] by tony@chromium.org
  • 7 edits in trunk

All child elements of a flex container should be turned into a flex item
https://bugs.webkit.org/show_bug.cgi?id=90323

Reviewed by Ojan Vafai.

Source/WebCore:

We used to only convert some elements to blocks, but now we convert everything except text nodes.
This was recently changed here:
http://wiki.csswg.org/topics/css3-flexbox-flexbox-replaced-children

Tests: css3/flexbox/anonymous-block.html : Add new test case.

css3/flexbox/flexitem.html: Update results.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

LayoutTests:

  • css3/flexbox/anonymous-block-expected.html:
  • css3/flexbox/anonymous-block.html:
  • css3/flexbox/flexitem-expected.txt:
  • css3/flexbox/flexitem.html:
8:09 PM Changeset in webkit [121612] by jsbell@chromium.org
  • 17 edits in trunk/Source

IndexedDB: Keep direction on IDBCursor to avoid calls to back end
https://bugs.webkit.org/show_bug.cgi?id=90114

Source/WebCore:

Reviewed by Tony Chang.

Let IDBCursor handle direction() accessor locally, without a call to
the IDBCursorBackendImpl which (in some ports) may reside in a different
process. Not a heavily called function, but further reduces the surface
area exposed by the XXXInterface classes.

No new tests - no functional changes.

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::create): Accept direction, known at creation time.
(WebCore::IDBCursor::IDBCursor): Stash in member.
(WebCore::IDBCursor::direction): Use local copy
(WebCore::IDBCursor::stringToDirection): Return enum value, not int.

  • Modules/indexeddb/IDBCursor.h:

(IDBCursor):

  • Modules/indexeddb/IDBCursorBackendImpl.cpp: Remove accessor.
  • Modules/indexeddb/IDBCursorBackendImpl.h:

(IDBCursorBackendImpl):

  • Modules/indexeddb/IDBCursorBackendInterface.h: Remove accessor.
  • Modules/indexeddb/IDBCursorWithValue.cpp:

(WebCore::IDBCursorWithValue::create):
(WebCore::IDBCursorWithValue::IDBCursorWithValue):

  • Modules/indexeddb/IDBCursorWithValue.h:

(IDBCursorWithValue):

  • Modules/indexeddb/IDBIndex.cpp: Prep IDBRequest with cursor direction too.

(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):

  • Modules/indexeddb/IDBObjectStore.cpp: Ditto.

(WebCore::IDBObjectStore::openCursor):

  • Modules/indexeddb/IDBRequest.cpp: Stash direction for pending cursor too.

(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::setCursorDetails):
(WebCore::IDBRequest::onSuccess): Apply stashed direction to new cursor.

  • Modules/indexeddb/IDBRequest.h:

(IDBRequest):

Source/WebKit/chromium:

Stop plumbing IDBCursorBackendInterface::direction() through API.

Reviewed by Tony Chang.

  • src/IDBCursorBackendProxy.cpp:
  • src/IDBCursorBackendProxy.h:

(IDBCursorBackendProxy):

  • src/WebIDBCursorImpl.cpp:
  • src/WebIDBCursorImpl.h:

(WebIDBCursorImpl):

7:36 PM Changeset in webkit [121611] by tony@chromium.org
  • 6 edits in trunk

Allow align-self: stretch to cause the item size to shrink below its intrinsic size
https://bugs.webkit.org/show_bug.cgi?id=90304

Reviewed by Ojan Vafai.

Source/WebCore:

The spec used to say that stretch could only make items grow, but now
it allows items to shrink.
http://dev.w3.org/csswg/css3-flexbox/#align-items-stretch

Tests: css3/flexbox/flex-align-stretch.html Updated expectations.

css3/flexbox/child-overflow.html Updated expectations.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::applyStretchAlignmentToChild):

LayoutTests:

  • css3/flexbox/child-overflow-expected.html:
  • css3/flexbox/child-overflow.html:
  • css3/flexbox/flex-align-stretch.html:
7:02 PM Changeset in webkit [121610] by commit-queue@webkit.org
  • 12 edits
    3 adds
    2 deletes in trunk

NPObjectWrapper may not address all window script object lifetime issues
https://bugs.webkit.org/show_bug.cgi?id=85679

Source/WebCore:

The ScriptController implementations force-deallocate the window script object to ensure that DOM objects are not leaked if an NPAPI plugin fails to release a reference to it before being destroyed. The NPObjectWrapper was added to ensure that NPAPI scripting could not touch the real window script object after it had been deallocated, by providing the plugin with a small wrapper which will leak if the plugin fails to dereference it.

This patch removes NPObjectWrapper and instead drops the window script NPObject's reference to the underlying V8Object in ScriptController::clearScriptObjects(). If a plugin fails to dereference the object then the NPV8Object wrapper will be leaked but the DOM objects it references will not.

Patch by James Weatherall <wez@chromium.org> on 2012-06-29
Reviewed by Nate Chapin.

Test: plugins/npruntime/leak-window-scriptable-object.html

  • WebCore.gypi:
  • bindings/v8/NPObjectWrapper.cpp: Removed.
  • bindings/v8/NPObjectWrapper.h: Removed.
  • bindings/v8/NPV8Object.cpp:

(WebCore::disposeUnderlyingV8Object):
(WebCore):
(WebCore::freeV8NPObject):
(_NPN_Invoke):
(_NPN_InvokeDefault):
(_NPN_EvaluateHelper):
(_NPN_GetProperty):
(_NPN_SetProperty):
(_NPN_RemoveProperty):
(_NPN_HasProperty):
(_NPN_HasMethod):
(_NPN_Enumerate):
(_NPN_Construct):

  • bindings/v8/NPV8Object.h:

(WebCore):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::ScriptController):
(WebCore::ScriptController::clearScriptObjects):
(WebCore::ScriptController::windowScriptNPObject):

  • bindings/v8/ScriptController.h:

(ScriptController):

Tools:

TestNetscapePlugin now has a leak-window-scriptable-object test which takes a reference to the window script object, and a second reference to it via the "self" property, and does not release those references. This is used to simulate a leaky plugin in layout tests of the NPAPI scripting interface glue code.

Patch by James Weatherall <wez@chromium.org> on 2012-06-29
Reviewed by Nate Chapin.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:

(PluginTest::NPN_GetProperty):

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h:

(PluginTest):

  • DumpRenderTree/TestNetscapePlugIn/Tests/LeakWindowScriptableObject.cpp: Added.

(LeakWindowScriptableObject):
(LeakWindowScriptableObject::LeakWindowScriptableObject):
(LeakWindowScriptableObject::NPP_New):

LayoutTests:

Test that NPAPI plugins that leak references to the window script object don't cause the containing document to be leaked.

Patch by James Weatherall <wez@chromium.org> on 2012-06-29
Reviewed by Nate Chapin.

  • plugins/npruntime/leak-window-scriptable-object-expected.txt: Added.
  • plugins/npruntime/leak-window-scriptable-object.html: Added.
6:23 PM Changeset in webkit [121609] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Update complex fonts on Android to use fonts from a newer SDK
https://bugs.webkit.org/show_bug.cgi?id=90296

Reviewed by Nate Chapin.

These fonts are available in the Jelly Bean SDK.

  • platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp:

(WebCore::ComplexTextController::ComplexTextController):
(WebCore::ComplexTextController::getComplexFontPlatformData):

6:20 PM Changeset in webkit [121608] by commit-queue@webkit.org
  • 3 edits
    8 adds in trunk/Source/WebKit

Source/WebKit: [EFL] Add support for Unit Tests, based on the gtest library.
https://bugs.webkit.org/show_bug.cgi?id=68509

Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-06-29
Reviewed by Chang Shu.

Add configuration for building gtest library, testing framework and unit tests.

  • PlatformEfl.cmake:

Source/WebKit/efl: [EFL] Implementation of testing framework and unit tests for WebKit-EFL port.
https://bugs.webkit.org/show_bug.cgi?id=68509

Patch by Krzysztof Czech <k.czech@samsung.com>, Tomasz Morawski <t.morawski@samsung.com> on 2012-06-29
Reviewed by Chang Shu.

Testing framework is based on gtest library. Gtest library is part of the WebKit project. Framework is devided into base part and view part.
Base part takes care of efl initialization, defines test macros and prepares test to run. View part is a context of each test.

  • tests/UnitTestUtils/EWKTestBase.cpp: Added.

(EWKUnitTests):
(EWKUnitTests::EWKTestBase::init):
(EWKUnitTests::EWKTestBase::shutdown):
(EWKUnitTests::EWKTestBase::shutdownAll):
(EWKUnitTests::EWKTestBase::startTest):
(EWKUnitTests::EWKTestBase::endTest):
(EWKUnitTests::EWKTestBase::createTest):
(EWKUnitTests::EWKTestBase::runTest):

  • tests/UnitTestUtils/EWKTestBase.h: Added.

(EWKUnitTests):
(EWKTestBase):

  • tests/UnitTestUtils/EWKTestConfig.h: Added.

(Config):

  • tests/UnitTestUtils/EWKTestView.cpp: Added.

(EWKUnitTests):
(EWKUnitTests::EWKTestEcoreEvas::EWKTestEcoreEvas):
(EWKUnitTests::EWKTestEcoreEvas::evas):
(EWKUnitTests::EWKTestEcoreEvas::show):
(EWKUnitTests::EWKTestView::EWKTestView):
(EWKUnitTests::EWKTestView::init):
(EWKUnitTests::EWKTestView::show):
(EWKUnitTests::EWKTestView::mainFrame):
(EWKUnitTests::EWKTestView::evas):
(EWKUnitTests::EWKTestView::bindEvents):

  • tests/UnitTestUtils/EWKTestView.h: Added.

(EWKUnitTests):
(EWKTestEcoreEvas):
(EWKTestView):
(EWKUnitTests::EWKTestView::webView):

  • tests/resources/default_test_page.html: Added.
  • tests/test_ewk_view.cpp: Added.

(ewkViewEditableGetCb):
(TEST):
(ewkViewUriGetCb):

  • tests/test_runner.cpp: Added.

(parseCustomArguments):
(main):

6:14 PM Changeset in webkit [121607] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Remove warning about protected values when the Heap is being destroyed
https://bugs.webkit.org/show_bug.cgi?id=90302

Reviewed by Geoffrey Garen.

Having to do book-keeping about whether values allocated from a certain
VM are or are not protected makes the JSC API much more difficult to use
correctly. Clients should be able to throw an entire VM away and not have
to worry about unprotecting all of the values that they protected earlier.

  • heap/Heap.cpp:

(JSC::Heap::lastChanceToFinalize):

5:58 PM Changeset in webkit [121606] by eae@chromium.org
  • 6 edits in trunk/LayoutTests

Unreviewed chromium windows rebaselines for r121599.

  • platform/chromium-win/fast/reflections/reflection-with-zoom-expected.png:
  • platform/chromium-win/fast/transforms/bounding-rect-zoom-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
5:25 PM Changeset in webkit [121605] by fpizlo@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

JSObject wastes too much memory on unused property slots
https://bugs.webkit.org/show_bug.cgi?id=90255

Reviewed by Mark Hahnenberg.

This does a few things:

  • JSNonFinalObject no longer has inline property storage.


  • Initial out-of-line property storage size is 4 slots for JSNonFinalObject, or 2x the inline storage for JSFinalObject.


  • Property storage is only reallocated if it needs to be. Previously, we would reallocate the property storage on any transition where the original structure said shouldGrowProperyStorage(), but this led to spurious reallocations when doing transitionless property adds and there are deleted property slots available. That in turn led to crashes, because we would switch to out-of-line storage even if the capacity matched the criteria for inline storage.


  • Inline JSFunction allocation is killed off because we don't have a good way of inlining property storage allocation. This didn't hurt performance. Killing off code is better than fixing it if that code wasn't doing any good.


This looks like a 1% progression on V8.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:
  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicJSObject):
(JSC):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_new_func):
(JSC):
(JSC::JIT::emit_op_new_func_exp):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::finishCreation):

  • runtime/JSObject.h:

(JSC::JSObject::isUsingInlineStorage):
(JSObject):
(JSC::JSObject::finishCreation):
(JSC):
(JSC::JSNonFinalObject::hasInlineStorage):
(JSNonFinalObject):
(JSC::JSNonFinalObject::JSNonFinalObject):
(JSC::JSNonFinalObject::finishCreation):
(JSC::JSFinalObject::hasInlineStorage):
(JSC::JSFinalObject::finishCreation):
(JSC::JSObject::offsetOfInlineStorage):
(JSC::JSObject::setPropertyStorage):
(JSC::Structure::inlineStorageCapacity):
(JSC::Structure::isUsingInlineStorage):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::setStructureAndReallocateStorageIfNecessary):
(JSC::JSObject::putDirectWithoutTransition):

  • runtime/Structure.cpp:

(JSC::Structure::Structure):
(JSC::nextPropertyStorageCapacity):
(JSC):
(JSC::Structure::growPropertyStorageCapacity):
(JSC::Structure::suggestedNewPropertyStorageSize):

  • runtime/Structure.h:

(JSC::Structure::putWillGrowPropertyStorage):
(Structure):

5:20 PM Changeset in webkit [121604] by eae@chromium.org
  • 9 edits in trunk/LayoutTests

Unreviewed chromium rebaselines for r121599.

  • platform/chromium-mac-snowleopard/fast/reflections/reflection-with-zoom-expected.png:
  • platform/chromium-mac-snowleopard/fast/transforms/bounding-rect-zoom-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-mac/fast/reflections/reflection-with-zoom-expected.png:
  • platform/chromium-mac/fast/transforms/bounding-rect-zoom-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
4:56 PM Changeset in webkit [121603] by rniwa@webkit.org
  • 27 edits in trunk/Source/WebCore

HTMLCollection's caches should be owned by either ElementRareData or Document
https://bugs.webkit.org/show_bug.cgi?id=90322

Reviewed by Anders Carlsson.

Removed all instances of OwnPtr<HTMLCollection> except ones on ElementRareData and Document.
ElementRareData::ensureCachedHTMLCollection then polymorphically creates HTMLCollection or
its subclass as deemed necessary.

This refactoring allows us to move HTMLCollection to use the same invalidation model as
DynamicNodeList (invalidated during DOM mutations) in a follow up.

  • dom/Document.cpp:

(WebCore::Document::all):

  • dom/Document.h:

(Document):

  • dom/Element.cpp:

(WebCore::ElementRareData::ensureCachedHTMLCollection):
(WebCore):
(WebCore::Element::cachedHTMLCollection):

  • dom/Element.h:

(Element):

  • dom/ElementRareData.h:

(WebCore):
(ElementRareData):
(WebCore::ElementRareData::cachedHTMLCollection):

  • dom/Node.cpp:

(WebCore):

  • dom/Node.h:

(Node):

  • dom/NodeRareData.h:

(WebCore::NodeRareData::setItemType):
(NodeRareData):

  • html/CollectionType.h:
  • html/HTMLCollection.cpp:

(WebCore::shouldIncludeChildren):
(WebCore::HTMLCollection::isAcceptableElement):

  • html/HTMLElement.cpp:

(WebCore):
(WebCore::HTMLElement::properties):

  • html/HTMLElement.h:

(HTMLElement):

  • html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::elements):

  • html/HTMLFieldSetElement.h:

(HTMLFieldSetElement):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::HTMLFormCollection):
(WebCore::HTMLFormCollection::create):

  • html/HTMLFormCollection.h:

(HTMLFormCollection):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::elements):

  • html/HTMLFormElement.h:
  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::HTMLOptionsCollection):
(WebCore::HTMLOptionsCollection::create):

  • html/HTMLOptionsCollection.h:

(HTMLOptionsCollection):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::selectedOptions):
(WebCore::HTMLSelectElement::options):
(WebCore::HTMLSelectElement::invalidateSelectedItems):
(WebCore::HTMLSelectElement::setRecalcListItems):

  • html/HTMLSelectElement.h:
  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::rows):

  • html/HTMLTableElement.h:
  • html/HTMLTableRowsCollection.cpp:

(WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection):
(WebCore::HTMLTableRowsCollection::create):

  • html/HTMLTableRowsCollection.h:

(HTMLTableRowsCollection):

4:49 PM Changeset in webkit [121602] by ojan@chromium.org
  • 2 edits in trunk/Source/WebCore

Add FIXMEs for vertical writing mode and override sizes.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::overrideLogicalContentWidth):
(WebCore::RenderBox::overrideLogicalContentHeight):

4:45 PM Changeset in webkit [121601] by jamesr@google.com
  • 4 edits in trunk/Source/WebCore

[chromium] Use CCThread::Task in compositor's RateLimiter instead of Timer
https://bugs.webkit.org/show_bug.cgi?id=90300

Reviewed by Adrienne Walker.

  • platform/graphics/chromium/RateLimiter.cpp:

(RateLimiter::Task):
(WebCore::RateLimiter::Task::create):
(WebCore::RateLimiter::Task::~Task):
(WebCore::RateLimiter::Task::Task):
(WebCore):
(WebCore::RateLimiter::RateLimiter):
(WebCore::RateLimiter::start):
(WebCore::RateLimiter::stop):
(WebCore::RateLimiter::rateLimitContext):

  • platform/graphics/chromium/RateLimiter.h:

(WebCore):
(RateLimiter):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::~CCLayerTreeHost):

4:40 PM Changeset in webkit [121600] by commit-queue@webkit.org
  • 12 edits in trunk/Source

Remove type from screenColorProfile API
https://bugs.webkit.org/show_bug.cgi?id=90299

Patch by Tony Payne <tpayne@chromium.org> on 2012-06-29
Reviewed by Adam Barth.

Source/Platform:

  • chromium/public/Platform.h:

(WebKit::Platform::screenColorProfile): Removed type from chromium
public API's version of screenColorProfile().

Source/WebCore:

Covered by existing tests.

  • platform/PlatformScreen.h:

(WebCore): Removed type from screenColorProfile().

  • platform/blackberry/PlatformScreenBlackBerry.cpp:

(WebCore::screenColorProfile):

  • platform/chromium/PlatformScreenChromium.cpp:

(WebCore::screenColorProfile):

  • platform/efl/PlatformScreenEfl.cpp:

(WebCore::screenColorProfile):

  • platform/gtk/PlatformScreenGtk.cpp:

(WebCore::screenColorProfile):

  • platform/image-decoders/ImageDecoder.h:

(WebCore::ImageDecoder::qcmsOutputDeviceProfile): Updated call to
screenColorProfile() to not pass type param.

  • platform/mac/PlatformScreenMac.mm:

(WebCore::screenColorProfile):

  • platform/qt/PlatformScreenQt.cpp:

(WebCore::screenColorProfile):

  • platform/win/PlatformScreenWin.cpp:

(WebCore::screenColorProfile):

4:26 PM Changeset in webkit [121599] by eae@chromium.org
  • 19 edits
    2 adds in trunk

Allow non-borders to be adjusted to less than 1 when zoomed out
https://bugs.webkit.org/show_bug.cgi?id=90104

Reviewed by Eric Seidel.

Source/WebCore:

Change CSSPrimitiveValue::computeLengthDouble to allow values to be
adjusted to less than 1.0 when zoomed out. This avoids an off by one
error for floats with margins when zoomed out that can cause floats to
wrap and break pages.

The logic that prevents the value from being adjusted to less than 1 was
added to ensure that borders are still painted even when zoomed out.
By moving the logic to ApplyPropertyComputeLength::applyValue, which is
used for borders and outlines, that functionality is preserved.

Test: fast/sub-pixel/float-with-margin-in-container.html

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::computeLengthDouble):

  • css/StyleBuilder.cpp:

(WebCore::ApplyPropertyComputeLength::applyValue):

LayoutTests:

Add test ensuring that floats with margins do not wrap in fixed sized
containers and update existing results as needed.

  • fast/css/zoom-background-repeat-x.html:
  • fast/sub-pixel/float-with-margin-in-container-expected.txt: Added.
  • fast/sub-pixel/float-with-margin-in-container.html: Added.
  • platform/chromium-linux/fast/reflections/reflection-with-zoom-expected.png:
  • platform/chromium-linux/fast/transforms/bounding-rect-zoom-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-mac/fast/transforms/bounding-rect-zoom-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/chromium-win/fast/transforms/bounding-rect-zoom-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/mac/fast/transforms/bounding-rect-zoom-expected.txt:
  • platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
  • platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
3:55 PM Changeset in webkit [121598] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Let Xcode have its own way after r121513.

  • WebCore.xcodeproj/project.pbxproj:
3:51 PM Changeset in webkit [121597] by commit-queue@webkit.org
  • 13 edits in trunk

[CSS Regions] Adding feature defines for CSS Regions for Windows
https://bugs.webkit.org/show_bug.cgi?id=88645

Patch by Mihai Balan <mibalan@adobe.com> on 2012-06-29
Reviewed by Tony Chang.

Source/WebCore:

Re-trying to enable CSS regions on Windows. This time only enabling
regions (not exclusions) because of some strange compilation/linking
issues.

  • css/CSSPropertyNames.in: Touched file to make sure property names get properly rebuilt.

Source/WebKit/win:

Re-trying to enable CSS regions on Windows. This time only enabling
regions since exclusions lead to some very strange compiling/linking
problems. This time adding preferences code to make sure the settings
get propagated to DRT (previous experiments by abucur showed they
didn't.).

  • WebPreferenceKeysPrivate.h: Added preference key for CSS regions
  • Interfaces/IWebPreferences.idl: Added getters and setters for CSS regions settings
  • WebPreferences.cpp: ditto

(WebPreferences::initializeDefaultSettings):
(WebPreferences::isCSSRegionsEnabled):
(WebPreferences::setCSSRegionsEnabled):

  • WebPreferences.h: ditto

(WebPreferences):

  • WebView.cpp: Added settings code to handle CSS regions, too

(WebView::notifyPreferencesChanged):

WebKitLibraries:

Re-trying to enable CSS regions on Windows. This time only enabling
regions since exclusions lead to some very strange compiling/linking
problems.

  • win/tools/vsprops/FeatureDefines.vsprops: Added default value for ENABLE_CSS_REGIONS
  • win/tools/vsprops/FeatureDefinesCairo.vsprops: ditto

LayoutTests:

Re-trying to enable CSS regions on Windows. This time only enabling
regions (not exclusions) because of some strange compilation/linking
issues. Fixing a couple of non-regions related tests that get different
results once regions are enabled.

  • platform/win/fast/js/global-constructors-expected.txt: Added WebKitCSSRule to expected
3:45 PM WebKitIDL edited by arv@chromium.org
(diff)
3:25 PM Changeset in webkit [121596] by dpranke@chromium.org
  • 2 edits in trunk/Tools

webkitpy: add comment about how determine_full_port_name() works for apple ports, fix -wk2 bug
https://bugs.webkit.org/show_bug.cgi?id=90314

Reviewed by Ojan Vafai.

Add comments and fix a bug in how we would handle the mac-wk2
and win-wk2 port names after confusion around in bug 90312 :).

  • Scripts/webkitpy/layout_tests/port/apple.py:

(ApplePort.determine_full_port_name):

3:16 PM Changeset in webkit [121595] by dpranke@chromium.org
  • 8 edits in trunk/Tools

webkitpy: remove support for mac leopard from chromium configurations
https://bugs.webkit.org/show_bug.cgi?id=90313

Reviewed by Tony Chang.

Google has shipped the last version of Chrome that will support
Mac OS 10.5 (Leopard), and we no longer have bots that run this
configuration, so we're removing support for it.

A subsequent change will remove the baselines in platform/chromium-mac-leopard.

  • Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:

(BaselineOptimizerTest.test_complex_shadowing):

  • Scripts/webkitpy/layout_tests/port/builders.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort):

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:

(ChromiumMacPort):

  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:

(ChromiumMacPortTest.test_versions):

  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:

(FactoryTest.test_mac):
(FactoryTest.test_chromium_mac):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(test_rebaseline_and_copy_test_with_lion_result):

3:10 PM Changeset in webkit [121594] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] WebFontRendering.cpp requires some OS(ANDROID) ifdefs to build downstream
https://bugs.webkit.org/show_bug.cgi?id=90292

Reviewed by Nate Chapin.

These ifdefs are required to build this file downstream. There's some
sublte difference between how the OS flags are set upstream and
downstream. This is on our list of issues to resolve, but in the
meantime, this patch makes these files identical upstream and
downstream to reduce noise in the upstreaming queue.

  • src/linux/WebFontRendering.cpp:

(WebKit::WebFontRendering::setSubpixelPositioning):

3:02 PM Changeset in webkit [121593] by noam.rosenthal@nokia.com
  • 2 edits
    53 adds
    1 delete in trunk/LayoutTests

[Qt][WK2] Unskip/rebaseline some compositing tests.
https://bugs.webkit.org/show_bug.cgi?id=90290

Reviewed by Laszlo Gombos.

Rebaseline compositing tests that have good results that are slightly different than the
generic results, and unskipping several tests that should not be skipped.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0-wk2/compositing/iframes/composited-iframe-scroll-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/fixed-position-iframe-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/iframe-content-flipping-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/iframe-size-to-zero-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/invisible-iframe-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-hide-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/layout-on-compositing-change-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/leave-compositing-iframe-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/nested-composited-iframe-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/nested-iframe-scrolling-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/overlapped-iframe-iframe-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/remove-iframe-crash-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/repaint-after-losing-scrollbars-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/scroll-fixed-transformed-element-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/scroll-grandchild-iframe-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/masks/direct-image-mask-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/masks/masked-ancestor-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/masks/multiple-masks-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/masks/simple-composited-mask-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/reflections/become-simple-composited-reflection-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/reflections/compositing-change-inside-reflection-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/reflections/empty-reflection-with-mask-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/reflections/masked-reflection-on-composited-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/reflections/nested-reflection-mask-change-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/reflections/nested-reflection-transformed-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/reflections/nested-reflection-transformed2-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/reflections/reflection-in-composited-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/reflections/reflection-on-composited-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/reflections/reflection-opacity-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/reflections/reflection-ordering-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/reflections/reflection-positioning-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/reflections/reflection-positioning2-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/reflections/remove-add-reflection-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/reflections/remove-reflection-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/reflections/simple-composited-reflections-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-absolute-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-absolute-overflow-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-relative-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-relative-expected.txt: Added.
2:57 PM Changeset in webkit [121592] by commit-queue@webkit.org
  • 12 edits
    2 adds in trunk

Source/WebCore: Web Inspector: Add data length to resource events on timeline to
keep track of the amount of data loaded and the total data length
https://bugs.webkit.org/show_bug.cgi?id=89244

Patch by Hanna Ma <Hanma@rim.com> on 2012-06-29
Reviewed by Pavel Feldman.

Added data length to inspector timeline popup
content for resources to keep track of the amount of data loaded.
Tests: inspector/timeline/timeline-network-received-data.html

  • English.lproj/localizedStrings.js:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willReceiveResourceDataImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willReceiveResourceData):

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::willReceiveResourceData):

  • inspector/InspectorTimelineAgent.h:

(InspectorTimelineAgent):

  • inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createReceiveResourceData):

  • inspector/TimelineRecordFactory.h:

(TimelineRecordFactory):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._showPopover):

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.prototype.reset):
(WebInspector.TimelinePresentationModel.Record):
(WebInspector.TimelinePresentationModel.Record.prototype.generatePopupContent):

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::didReceiveData):

  • inspector/timeline/timeline-network-received-data.html: Added.
  • inspector/timeline/timeline-network-received-data-expected.txt: Added.
  • inspector/timeline/timeline-test.js:

LayoutTests: Web Inspector: Add data length to resource events on timeline to
keep track of the amount of data loaded and the total data length.
https://bugs.webkit.org/show_bug.cgi?id=89244

Patch by Hanna Ma <Hanma@rim.com> on 2012-06-29
Reviewed by Pavel Feldman.

Added tests for resource receive data events.

  • inspector/timeline/timeline-network-received-data-expected.txt: Added.
  • inspector/timeline/timeline-network-received-data.html: Added.
  • inspector/timeline/timeline-test.js:
2:53 PM Changeset in webkit [121591] by ojan@chromium.org
  • 3 edits in trunk/Tools

Fix optimize-baselines to not move baselines from win to win-7sp0
https://bugs.webkit.org/show_bug.cgi?id=90312

Reviewed by Dirk Pranke.

It used to consider win-7sp0 as the common directory for all the Apple
windows ports and incorrectly move results out of win.

  • Scripts/webkitpy/common/checkout/baselineoptimizer.py:
  • Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:

(BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
(BaselineOptimizerTest.test_common_directory_includes_root):

2:43 PM Changeset in webkit [121590] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit2

[WK2] Move intent delivery code from the frame to the page
https://bugs.webkit.org/show_bug.cgi?id=89974

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-29
Reviewed by Anders Carlsson.

Move the intent delivery code from the frame to the page
and add the corresponding C API for WKPage.

  • UIProcess/API/C/WKPage.cpp:

(WKPageDeliverIntentToFrame):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::stopLoading):

  • UIProcess/WebFrameProxy.h:

(WebKit):

  • UIProcess/WebPageProxy.cpp:

(WebKit):
(WebKit::WebPageProxy::deliverIntentToFrame):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

2:25 PM Changeset in webkit [121589] by shawnsingh@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after 121580.

WebKit Linux debug bots was complaining about signed vs unsigned integer comparison.

  • html/HTMLCollection.h:

(WebCore::HTMLCollectionCacheBase::HTMLCollectionCacheBase):

2:23 PM Changeset in webkit [121588] by eae@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

Unreviewed chromium xp rebaseline.

  • platform/chromium-win-xp/http/tests/inspector: Added.
  • platform/chromium-win-xp/http/tests/inspector/resource-tree: Added.
  • platform/chromium-win-xp/http/tests/inspector/resource-tree/resource-request-content-while-loading-expected.txt: Added.
2:13 PM Changeset in webkit [121587] by danakj@chromium.org
  • 1 edit in branches/chromium/1180/Source/WebCore/platform/graphics/chromium/cc/CCOverdrawMetrics.cpp

Merge 121224 - [chromium] CCOverdrawMetrics should use the deviceViewportSize to count actual pixels
https://bugs.webkit.org/show_bug.cgi?id=89922

Reviewed by Adrienne Walker.

  • platform/graphics/chromium/cc/CCOverdrawMetrics.cpp:

(WebCore::CCOverdrawMetrics::recordMetricsInternal):

TBR=danakj@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10704050

2:11 PM Changeset in webkit [121586] by zhajiang@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Page jumps after post-pinch-zoom re-render
https://bugs.webkit.org/show_bug.cgi?id=90282

Reviewed by Antonio Gomes.
Patch by Jacky Jiang <zhajiang@rim.com>

PR: 170255
In r120622, we moved ScrollableArea::setConstrainsScrollingToContentEdge(false|true)
from WebPage::setScrollPosition() to BackingStorePrivate::setScrollingOrZooming()
to address an overscroll reset issue.
However, when we are ending bitmap zooming, UI thread can call
BackingStorePrivate::setScrollingOrZooming(false) before WebKit thread
calls WebPage::setScrollPosition(), in which case it will set
ScrollableArea::m_constrainsScrollingToContentEdge to true earlier.
To fix this, we can cache ScrollableArea::m_constrainsScrollingToContentEdge
and always set it to false before we set scroll position in WebKit
thread to avoid scroll position clamping during scrolling, and restore
it to what it was after that.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::setScrollPosition):

1:32 PM Changeset in webkit [121585] by ojan@chromium.org
  • 2 edits
    2 adds
    1 delete in trunk/LayoutTests

Rebaseline some tests where Chrome differs due to V8's different toString implementation
for some built-ins. We should probably get V8 and JSC to agree here, but that's not terribly
pressing since the web clearly doesn't depend on the specifics here.

  • platform/chromium-win/fast/js/global-constructors-expected.txt: Removed.
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/js/function-names-expected.txt: Added.
  • platform/chromium/fast/js/global-constructors-expected.txt: Added.
1:26 PM Changeset in webkit [121584] by mitz@apple.com
  • 10 edits in trunk/Source/WebKit2

Can’t get basic element info from a WKRenderObject
https://bugs.webkit.org/show_bug.cgi?id=90301

Reviewed by Anders Carlsson.

Moved the element info (tag name, id and class names) from WebRenderLayer to WebRenderObject,
and gave WebRenderLayer a reference to a (shallow) WebRenderObject. Added WKRenderObject API
for getting element info, while leaving the WKRenderLayer API in place for now for Safari.

  • Shared/API/c/WKRenderLayer.cpp:

(WKRenderLayerGetRenderer): Added this wrapper.
(WKRenderLayerCopyRendererName): Changed to get the name from the renderer.
(WKRenderLayerCopyElementTagName): Changed to go through the renderer.
(WKRenderLayerCopyElementID): Ditto.
(WKRenderLayerGetElementClassNames): Ditto.

  • Shared/API/c/WKRenderLayer.h: Added declaration of WKRenderLayerGetRenderer() and comments

about removing older API.

  • Shared/API/c/WKRenderObject.cpp:

(WKRenderObjectCopyElementTagName): Added this wrapper.
(WKRenderObjectCopyElementID): Ditto.
(WKRenderObjectGetElementClassNames): Ditto.

  • Shared/API/c/WKRenderObject.h:
  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode): Removed the element info from the encoding of
WebRenderLayer, and added the renderer. Added the element info to the encoding of
WebRenderObject.
(WebKit::UserMessageDecoder::baseDecode): Updated to match the encoding changes.

  • Shared/WebRenderLayer.cpp:

(WebKit::WebRenderLayer::WebRenderLayer): Changed to initialize the m_renderer member
variable with a WebRenderObject for the layer’s renderer, and removed the initialization of
the element-related member variables that were removed.

  • Shared/WebRenderLayer.h:

(WebKit::WebRenderLayer::create): Changed to take a renderer instead of renderer and element
info.
(WebKit::WebRenderLayer::renderer): Added this getter.
(WebKit::WebRenderLayer::WebRenderLayer): Changed to take a renderer instead of renderer and
element info.

  • Shared/WebRenderObject.cpp:

(WebKit::WebRenderObject::create): Changed to pass true for the shouldIncludeDescendants
parameter.
(WebKit::WebRenderObject::WebRenderObject): Added a shouldIncludeDescdendants boolean
parameter. When it is false, the m_children array remains null. Added initialization of
member variables with the element’s tag name, id and class list.

  • Shared/WebRenderObject.h:

(WebKit::WebRenderObject::create): Added an overload that takes a RenderObject and creates
a shallow WebRenderObject.
(WebRenderObject): Changed to take element tag name, id and class list.
(WebKit::WebRenderObject::elementTagName): Added this getter.
(WebKit::WebRenderObject::elementID): Ditto.
(WebKit::WebRenderObject::elementClassNames): Ditto.
(WebKit::WebRenderObject::WebRenderObject):

12:57 PM Changeset in webkit [121583] by jamesr@google.com
  • 13 edits in trunk/Source

[chromium] Remove mapRect and mapQuad from WebTransformationMatrix
https://bugs.webkit.org/show_bug.cgi?id=90230

Reviewed by Adrienne Walker.

Source/Platform:

Removes clipping-unaware mapRect, mapQuad and projectPoint functions from the WebTransformationMatrix interface.

  • chromium/public/WebTransformationMatrix.h:

(WebTransformationMatrix):

Source/WebCore:

Replaces calls to WebTransformationMatrix::mapRect/mapQuad with clipping-aware calls to CCMathUtils. In most
cases, we do not expect clipping to happen. For others (such as area calculations in CCOverdrawMetrics) we can
handle a clipped quad easily.

  • platform/chromium/support/WebTransformationMatrix.cpp:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawRenderPassQuad):
(WebCore::LayerRendererChromium::drawTileQuad):

  • platform/graphics/chromium/RenderSurfaceChromium.cpp:

(WebCore::RenderSurfaceChromium::drawableContentRect):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::getDrawRect):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::transformSurfaceOpaqueRegion):
(WebCore::addOcclusionBehindLayer):

  • platform/graphics/chromium/cc/CCOverdrawMetrics.cpp:

(WebCore):
(WebCore::polygonArea):
(WebCore::areaOfMappedQuad):
(WebCore::CCOverdrawMetrics::didUpload):
(WebCore::CCOverdrawMetrics::didCullForDrawing):
(WebCore::CCOverdrawMetrics::didDraw):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::appendQuadsToFillScreen):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::drawableContentRect):

  • platform/graphics/chromium/cc/CCSharedQuadState.cpp:

(WebCore::CCSharedQuadState::isLayerAxisAlignedIntRect):

12:05 PM Changeset in webkit [121582] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Mac build fix after r121575. It rolls out r121547 but didn't roll out the follow up build fix r121553.

  • platform/graphics/mac/FontCustomPlatformData.h:

(FontCustomPlatformData):

12:03 PM Changeset in webkit [121581] by zandobersek@gmail.com
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed GTK gardening, adding a new baseline required after r121555.

  • platform/gtk/fast/viewport/viewport-91-expected.txt: Added.
11:58 AM Changeset in webkit [121580] by rniwa@webkit.org
  • 13 edits in trunk/Source/WebCore

Share the same cache in HTMLCollection and DynamicNodeLists
https://bugs.webkit.org/show_bug.cgi?id=90118

Reviewed by Anders Carlsson.

This patch introduces two new base classes DynamicNodeListCacheBase and HTMLCollectionCacheBase to share
the cache object between DynamicNodeList and HTMLCollection. HTMLCollectionCacheBase inherits from
DynamicNodeListCacheBase and contains extra caches and bit flags for HTMLCollection. DynamicNodeList::Cache
and HTMLCollection::Cache had been removed and flattened into these two classes for the easy inheritance.

In DynamicNodeList, we have a very straight forward one-to-one mapping from old Caches member variables:

m_caches.lastItem -> cachedItem()
m_caches.lastItemOffset -> cachedItemOffset()
m_caches.cachedLength -> cachedLength()
m_caches.isItemCacheValid -> isItemCacheValid()
m_caches.isLengthCacheValid -> isLengthCacheValid()
m_caches.type -> removed because it was never used.
m_caches.rootedAtDocument -> isRootedAtDocument()
m_caches.shouldInvalidateOnAttributeChange -> shouldInvalidateOnAttributeChange()

In HTMLCollection, there is one semantic change in the way item cache is managed. Previously, we only had
m_cache.current which was used as both cachedItem() and isItemCacheValid() (not valid when current is null).
There are some asymmetric code changes due to one-to-many relationship. Also, all method names have been updated
to use that of DynamicNodeList terminology. Thus we have the following correspondence:

m_cache.current -> cachedItem() / isItemCacheValid()
m_cache.position -> cachedItemOffset()
m_cache.length -> cachedLength()
m_cache.elementsArrayPosition -> cachedElementsArrayOffset()
m_cache.hasLength -> isLengthCacheValid()
m_cache.hasNameCache -> hasNameCache() / setHasNameCache()
m_cache.idCache -> idCache() / addIdCache()
m_cache.nameCache -> idCache() / addNameCache()

In addition, we had to rename HTMLCollection::clearCache to invalidateCache to avoid the name collision with
HTMLCollectionCacheBase::clearCache.

  • dom/ChildNodeList.cpp:

(WebCore::ChildNodeList::length):
(WebCore::ChildNodeList::item):

  • dom/DynamicNodeList.cpp:

(WebCore::DynamicSubtreeNodeList::length):
(WebCore::DynamicSubtreeNodeList::itemForwardsFromCurrent):
(WebCore::DynamicSubtreeNodeList::itemBackwardsFromCurrent):
(WebCore::DynamicSubtreeNodeList::item):

  • dom/DynamicNodeList.h:

(DynamicNodeListCacheBase):
(WebCore::DynamicNodeListCacheBase::DynamicNodeListCacheBase):
(WebCore::DynamicNodeListCacheBase::isRootedAtDocument):
(WebCore::DynamicNodeListCacheBase::shouldInvalidateOnAttributeChange):
(WebCore::DynamicNodeListCacheBase::isItemCacheValid):
(WebCore::DynamicNodeListCacheBase::cachedItem):
(WebCore::DynamicNodeListCacheBase::cachedItemOffset):
(WebCore::DynamicNodeListCacheBase::isLengthCacheValid):
(WebCore::DynamicNodeListCacheBase::cachedLength):
(WebCore::DynamicNodeListCacheBase::setLengthCache):
(WebCore::DynamicNodeListCacheBase::setItemCache):
(WebCore::DynamicNodeListCacheBase::clearCache):
(WebCore):
(WebCore::DynamicNodeList::DynamicNodeList):
(WebCore::DynamicNodeList::invalidateCache):
(WebCore::DynamicNodeList::rootNode):
(DynamicNodeList):

  • html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::namedItemWithIndex):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::invalidateCacheIfNeeded):
(WebCore::HTMLCollection::invalidateCache):
(WebCore::HTMLCollection::isAcceptableElement):
(WebCore::HTMLCollection::itemAfter):
(WebCore::HTMLCollection::length):
(WebCore::HTMLCollection::item):
(WebCore::HTMLCollection::checkForNameMatch):
(WebCore::HTMLCollection::namedItem):
(WebCore::HTMLCollection::updateNameCache):
(WebCore::HTMLCollection::hasNamedItem):
(WebCore::HTMLCollection::namedItems):
(WebCore::HTMLCollectionCacheBase::append):

  • html/HTMLCollection.h:

(HTMLCollectionCacheBase):
(WebCore::HTMLCollectionCacheBase::HTMLCollectionCacheBase):
(WebCore::HTMLCollectionCacheBase::type):
(WebCore::HTMLCollectionCacheBase::clearCache):
(WebCore::HTMLCollectionCacheBase::setItemCache):
(WebCore::HTMLCollectionCacheBase::cachedElementsArrayOffset):
(WebCore::HTMLCollectionCacheBase::includeChildren):
(WebCore::HTMLCollectionCacheBase::cacheTreeVersion):
(WebCore::HTMLCollectionCacheBase::idCache):
(WebCore::HTMLCollectionCacheBase::nameCache):
(WebCore::HTMLCollectionCacheBase::appendIdCache):
(WebCore::HTMLCollectionCacheBase::appendNameCache):
(WebCore::HTMLCollectionCacheBase::hasNameCache):
(WebCore::HTMLCollectionCacheBase::setHasNameCache):
(WebCore):
(WebCore::HTMLCollection::isEmpty):
(WebCore::HTMLCollection::hasExactlyOneItem):
(WebCore::HTMLCollection::base):
(HTMLCollection):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::item):
(WebCore::HTMLFormCollection::updateNameCache):

  • html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::itemAfter):

  • html/HTMLNameCollection.h:

(HTMLNameCollection):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::invalidateSelectedItems):

  • html/HTMLTableRowsCollection.cpp:

(WebCore::HTMLTableRowsCollection::itemAfter):

  • html/HTMLTableRowsCollection.h:

(HTMLTableRowsCollection):

11:52 AM Changeset in webkit [121579] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

[EFL] [GTK] [QT] fast/viewport/viewport-91.html is failing after r121555
https://bugs.webkit.org/show_bug.cgi?id=90287

Unreviewed gardening. Skip fast/viewport/viewport-91.html
for EFL, GTK and QT ports. The test is failing after r121555.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-29

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/qt/TestExpectations:
11:43 AM Changeset in webkit [121578] by tony@chromium.org
  • 18 edits in trunk/Source

Unreviewed, rolling out r121572.
http://trac.webkit.org/changeset/121572
https://bugs.webkit.org/show_bug.cgi?id=90249

Breaks Mac build since it depends on r121547, which was rolled
out

Source/WebCore:

  • WebCore.exp.in:
  • page/AlternativeTextClient.h:
  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::populate):

  • platform/graphics/cg/ImageBufferDataCG.h:
  • platform/graphics/mac/GraphicsContextMac.mm:

(WebCore::GraphicsContext::drawLineForDocumentMarker):

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::setClosedCaptionsVisible):

  • platform/mac/WebCoreSystemInterface.h:
  • platform/network/Credential.h:
  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore):
(WebCore::initializeMaximumHTTPConnectionCountPerHost):

  • platform/text/TextChecking.h:

(WebCore):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::containsPaintedContent):

Source/WebKit2:

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue):

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::shouldEraseMarkersAfterChangeSelection):

  • WebProcess/WebCoreSupport/WebEditorClient.h:

Source/WTF:

  • wtf/ThreadingPthreads.cpp:

(WTF::initializeCurrentThreadInternal):

11:28 AM Changeset in webkit [121577] by ojan@chromium.org
  • 5 edits in trunk/Tools

Fix rebaselining for Qt and Apple ports
https://bugs.webkit.org/show_bug.cgi?id=90204

Reviewed by Dirk Pranke.

-Apporpriately put wk2 results in the -wk2 directories.
-Since Qt and Apple-Win don't have bots that correspond to the
platform/qt and platform/win directories, we need to fudge it
and always put the results in those directories for those ports.

  • Scripts/webkitpy/layout_tests/port/builders.py:

(rebaseline_override_dir):

  • Scripts/webkitpy/layout_tests/port/factory.py:

(_builder_options):
Identify webkit2 builders by the WK2 in the builder name.

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineTest._baseline_directory):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaseline.test_baseline_directory):

11:27 AM Changeset in webkit [121576] by jpetsovits@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

Add blitVisibleContents() as public API.
https://bugs.webkit.org/show_bug.cgi?id=90211

Reviewed by Adam Treat.

We keep blitContents() (with src/dst rectangles)
for compatibility with older Cascades sprints for now,
but want to switch to always blitting the full viewport
and this is a good first step.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
(BlackBerry::WebKit::BackingStore::blitVisibleContents):
(WebKit):

  • Api/BackingStore.h:
11:14 AM Changeset in webkit [121575] by tony@chromium.org
  • 21 edits in trunk/Source/WebCore

Unreviewed, rolling out r121547.
http://trac.webkit.org/changeset/121547
https://bugs.webkit.org/show_bug.cgi?id=90256

Breaks Chromium Mac build

  • platform/LocalizedStrings.cpp:

(WebCore::imageTitle):

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::setAllowsFontSmoothing):

  • platform/graphics/cg/ImageCG.cpp:

(WebCore::Image::drawPattern):

  • platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::ImageSource::clear):

  • platform/graphics/cg/PathCG.cpp:

(WebCore::Path::boundingRect):

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore):
(WebCore::canSetCascadeListForCustomFont):
(WebCore::FontPlatformData::ctFont):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
  • platform/graphics/mac/ComplexTextController.cpp:
  • platform/graphics/mac/FontCacheMac.mm:

(WebCore):
(WebCore::fontCacheATSNotificationCallback):
(WebCore::FontCache::platformInit):

  • platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::createFontCustomPlatformData):

  • platform/graphics/mac/FontCustomPlatformData.h:

(WebCore::FontCustomPlatformData::FontCustomPlatformData):

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformInit):

  • platform/graphics/mac/WebLayer.h:
  • platform/mac/CursorMac.mm:

(WebCore::Cursor::ensurePlatformCursor):

  • platform/mac/DisplaySleepDisabler.cpp:

(WebCore::DisplaySleepDisabler::DisplaySleepDisabler):
(WebCore):
(WebCore::DisplaySleepDisabler::systemActivityTimerFired):

  • platform/mac/DisplaySleepDisabler.h:

(DisplaySleepDisabler):

  • platform/mac/HTMLConverter.h:
  • platform/mac/HTMLConverter.mm:
  • platform/mac/PopupMenuMac.mm:

(WebCore::PopupMenuMac::populate):

  • platform/mac/ScrollElasticityController.mm:
10:55 AM Changeset in webkit [121574] by commit-queue@webkit.org
  • 27 edits
    7 adds in trunk/Source

[chromium] Adding PrioritizedTexture and replacing ContentsTextureManager
https://bugs.webkit.org/show_bug.cgi?id=84308

Patch by Eric Penner <epenner@google.com> on 2012-06-29
Reviewed by Adrienne Walker.

Source/WebCore:

PrioritizedTextures have a priority such that all texture requests can be
prioritized. There are three steps involved:

  • Call setRequestPriority()
  • Check if the request succeeded with canAcquireBackingTexture()
  • Call acquireBackingTexture() when uploading a new texture.

Internally both the texture requests and the backing textures get sorted.
Requests are sorted so they can be prioritized. Backing textures are sorted
so that they can be recycled/evicted in the right order (lowest priority first).

Prioritizing textures doesn't assign backing textures to texture requests but
rather just marks which textures can have a backing texture "when needed". This
allows us to keep the old textures in use as long as possible.

The unit tests support all the use cases from the original texture manager
but also adds assumptions about priority order throughout all the tests. The
function assertInvariants() is added to test the validity of the manager
and all textures/allocations within it.

The TiledLayerChromium tests are updated to request textures first with
prioritizeTextures(), and update them with the updater (such that allocate
gets called) before pushPropertiesTo is called (when they need to be valid).

  • WebCore.gypi:
  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:

(WebCore::BitmapCanvasLayerTextureUpdater::Texture::Texture):
(WebCore::BitmapCanvasLayerTextureUpdater::createTexture):
(WebCore::BitmapCanvasLayerTextureUpdater::updateTextureRect):

  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h:

(WebCore):
(Texture):
(BitmapCanvasLayerTextureUpdater):

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::Texture):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::createTexture):

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:

(Texture):
(BitmapSkPictureCanvasLayerTextureUpdater):

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::setTexturePriorities):
(WebCore):
(WebCore::ContentLayerChromium::update):

  • platform/graphics/chromium/ContentLayerChromium.h:

(ContentLayerChromium):

  • platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::createAcceleratedCanvas):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::Texture::Texture):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::createTexture):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):

  • platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.h:

(Texture):
(FrameBufferSkPictureCanvasLayerTextureUpdater):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerTextureUpdater::Texture::Texture):
(WebCore::ImageLayerTextureUpdater::createTexture):
(WebCore::ImageLayerTextureUpdater::updateTextureRect):
(WebCore::ImageLayerChromium::setTexturePriorities):
(WebCore):

  • platform/graphics/chromium/ImageLayerChromium.h:

(ImageLayerChromium):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):
(WebCore::LayerChromium::setTexturePriorities):

  • platform/graphics/chromium/LayerTextureUpdater.h:

(WebCore::LayerTextureUpdater::Texture::texture):
(WebCore::LayerTextureUpdater::Texture::swapTextureWith):
(WebCore::LayerTextureUpdater::Texture::Texture):
(Texture):

  • platform/graphics/chromium/ScrollbarLayerChromium.cpp:

(WebCore::ScrollbarLayerChromium::pushPropertiesTo):
(WebCore::ScrollbarLayerChromium::createTextureUpdaterIfNeeded):
(WebCore::ScrollbarLayerChromium::updatePart):
(WebCore):
(WebCore::ScrollbarLayerChromium::setTexturePriorities):

  • platform/graphics/chromium/ScrollbarLayerChromium.h:

(ScrollbarLayerChromium):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::UpdatableTile::managedTexture):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::textureManager):
(WebCore::TiledLayerChromium::createTile):
(WebCore::TiledLayerChromium::tileNeedsBufferedUpdate):
(WebCore::TiledLayerChromium::updateTiles):
(WebCore::TiledLayerChromium::setTexturePriorities):
(WebCore):
(WebCore::TiledLayerChromium::setTexturePrioritiesInRect):
(WebCore::TiledLayerChromium::resetUpdateState):
(WebCore::TiledLayerChromium::updateLayerRect):
(WebCore::TiledLayerChromium::idleUpdateLayerRect):
(WebCore::TiledLayerChromium::needsIdlePaint):
(WebCore::TiledLayerChromium::idlePaintRect):

  • platform/graphics/chromium/TiledLayerChromium.h:

(TiledLayerChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initializeLayerRenderer):
(WebCore::CCLayerTreeHost::deleteContentsTexturesOnImplThread):
(WebCore::CCLayerTreeHost::beginCommitOnImplThread):
(WebCore::CCLayerTreeHost::commitComplete):
(WebCore::CCLayerTreeHost::evictAllContentTextures):
(WebCore::CCLayerTreeHost::contentsTextureManager):
(WebCore::CCLayerTreeHost::updateLayers):
(WebCore::CCLayerTreeHost::prioritizeTextures):
(WebCore::CCLayerTreeHost::deleteTextureAfterCommit):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore):
(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCPrioritizedTexture.cpp: Added.

(WebCore):
(WebCore::CCPrioritizedTexture::CCPrioritizedTexture):
(WebCore::CCPrioritizedTexture::~CCPrioritizedTexture):
(WebCore::CCPrioritizedTexture::setTextureManager):
(WebCore::CCPrioritizedTexture::setDimensions):
(WebCore::CCPrioritizedTexture::requestLate):
(WebCore::CCPrioritizedTexture::acquireBackingTexture):
(WebCore::CCPrioritizedTexture::textureId):
(WebCore::CCPrioritizedTexture::bindTexture):
(WebCore::CCPrioritizedTexture::framebufferTexture2D):
(WebCore::CCPrioritizedTexture::setCurrentBacking):

  • platform/graphics/chromium/cc/CCPrioritizedTexture.h: Added.

(WebCore):
(CCPrioritizedTexture):
(WebCore::CCPrioritizedTexture::create):
(WebCore::CCPrioritizedTexture::textureManager):
(WebCore::CCPrioritizedTexture::format):
(WebCore::CCPrioritizedTexture::size):
(WebCore::CCPrioritizedTexture::memorySizeBytes):
(WebCore::CCPrioritizedTexture::setRequestPriority):
(WebCore::CCPrioritizedTexture::requestPriority):
(WebCore::CCPrioritizedTexture::canAcquireBackingTexture):
(WebCore::CCPrioritizedTexture::haveBackingTexture):
(Backing):
(WebCore::CCPrioritizedTexture::Backing::size):
(WebCore::CCPrioritizedTexture::Backing::format):
(WebCore::CCPrioritizedTexture::Backing::memorySizeBytes):
(WebCore::CCPrioritizedTexture::Backing::textureId):
(WebCore::CCPrioritizedTexture::Backing::currentTexture):
(WebCore::CCPrioritizedTexture::Backing::setCurrentTexture):
(WebCore::CCPrioritizedTexture::Backing::Backing):
(WebCore::CCPrioritizedTexture::Backing::~Backing):
(WebCore::CCPrioritizedTexture::isAbovePriorityCutoff):
(WebCore::CCPrioritizedTexture::setAbovePriorityCutoff):
(WebCore::CCPrioritizedTexture::setManagerInternal):
(WebCore::CCPrioritizedTexture::currentBacking):

  • platform/graphics/chromium/cc/CCPrioritizedTextureManager.cpp: Added.

(WebCore):
(WebCore::CCPrioritizedTextureManager::CCPrioritizedTextureManager):
(WebCore::CCPrioritizedTextureManager::~CCPrioritizedTextureManager):
(WebCore::CCPrioritizedTextureManager::setMemoryAllocationLimitBytes):
(WebCore::CCPrioritizedTextureManager::prioritizeTextures):
(WebCore::CCPrioritizedTextureManager::clearPriorities):
(WebCore::CCPrioritizedTextureManager::requestLate):
(WebCore::CCPrioritizedTextureManager::acquireBackingTextureIfNeeded):
(WebCore::CCPrioritizedTextureManager::reduceMemory):
(WebCore::CCPrioritizedTextureManager::clearAllMemory):
(WebCore::CCPrioritizedTextureManager::allBackingTexturesWereDeleted):
(WebCore::CCPrioritizedTextureManager::unlink):
(WebCore::CCPrioritizedTextureManager::link):
(WebCore::CCPrioritizedTextureManager::registerTexture):
(WebCore::CCPrioritizedTextureManager::unregisterTexture):
(WebCore::CCPrioritizedTextureManager::returnBackingTexture):
(WebCore::CCPrioritizedTextureManager::createBacking):
(WebCore::CCPrioritizedTextureManager::destroyBacking):
(WebCore::CCPrioritizedTextureManager::assertInvariants):

  • platform/graphics/chromium/cc/CCPrioritizedTextureManager.h: Added.

(WebCore):
(CCPrioritizedTextureManager):
(WebCore::CCPrioritizedTextureManager::create):
(WebCore::CCPrioritizedTextureManager::createTexture):
(WebCore::CCPrioritizedTextureManager::memoryUseBytes):
(WebCore::CCPrioritizedTextureManager::memoryAboveCutoffBytes):
(WebCore::CCPrioritizedTextureManager::setMaxMemoryLimitBytes):
(WebCore::CCPrioritizedTextureManager::maxMemoryLimitBytes):
(WebCore::CCPrioritizedTextureManager::setPreferredMemoryLimitBytes):
(WebCore::CCPrioritizedTextureManager::preferredMemoryLimitBytes):
(WebCore::CCPrioritizedTextureManager::setMaxMemoryPriorityCutoff):
(WebCore::CCPrioritizedTextureManager::maxMemoryPriorityCutoff):
(WebCore::CCPrioritizedTextureManager::compareTextures):
(WebCore::CCPrioritizedTextureManager::compareBackings):

  • platform/graphics/chromium/cc/CCPriorityCalculator.cpp: Added.

(WebCore):
(WebCore::CCPriorityCalculator::uiPriority):
(WebCore::CCPriorityCalculator::visiblePriority):
(WebCore::CCPriorityCalculator::lingeringPriority):
(WebCore::CCPriorityCalculator::priorityFromDistance):
(WebCore::CCPriorityCalculator::priorityFromVisibility):

  • platform/graphics/chromium/cc/CCPriorityCalculator.h: Added.

(WebCore):
(CCPriorityCalculator):
(WebCore::CCPriorityCalculator::highestPriority):
(WebCore::CCPriorityCalculator::lowestPriority):
(WebCore::CCPriorityCalculator::priorityIsLower):
(WebCore::CCPriorityCalculator::priorityIsHigher):

  • platform/graphics/chromium/cc/CCTextureUpdater.cpp:

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::commitCompleteOnCCThread):

  • tests/CCPrioritizedTextureTest.cpp: Added.

(WTF):
(CCPrioritizedTextureTest):
(WTF::CCPrioritizedTextureTest::CCPrioritizedTextureTest):
(WTF::CCPrioritizedTextureTest::~CCPrioritizedTextureTest):
(WTF::CCPrioritizedTextureTest::texturesMemorySize):
(WTF::CCPrioritizedTextureTest::createManager):
(WTF::CCPrioritizedTextureTest::validateTexture):
(WTF::CCPrioritizedTextureTest::allocator):
(WTF::TEST_F):

  • tests/CCTiledLayerTestCommon.cpp:

(WebKitTests::FakeLayerTextureUpdater::Texture::Texture):
(WebKitTests::FakeLayerTextureUpdater::Texture::updateRect):
(WebKitTests::FakeLayerTextureUpdater::createTexture):
(WebKitTests::FakeTiledLayerChromium::FakeTiledLayerChromium):
(WebKitTests::FakeTiledLayerWithScaledBounds::FakeTiledLayerWithScaledBounds):

  • tests/CCTiledLayerTestCommon.h:

(Texture):
(FakeLayerTextureUpdater):
(FakeTiledLayerChromium):
(FakeTiledLayerWithScaledBounds):

  • tests/TiledLayerChromiumTest.cpp:
10:47 AM Changeset in webkit [121573] by Lucas Forschler
  • 3 edits in branches/safari-534.57-branch/Source/WebCore

Merge <rdar://problem/11736630>

10:36 AM Changeset in webkit [121572] by eric@webkit.org
  • 18 edits in trunk/Source

Remove BUILDING_ON_LEOPARD now that no ports build on Leopard
https://bugs.webkit.org/show_bug.cgi?id=90249

Reviewed by Ryosuke Niwa.

Source/WebCore:

I don't think I quite got it all yet, but this is another step towards
removing Leopard support in WebCore.

  • WebCore.exp.in:
  • page/AlternativeTextClient.h:
  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::populate):

  • platform/graphics/cg/ImageBufferDataCG.h:
  • platform/graphics/mac/GraphicsContextMac.mm:

(WebCore::GraphicsContext::drawLineForDocumentMarker):

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::setClosedCaptionsVisible):

  • platform/mac/WebCoreSystemInterface.h:
  • platform/network/Credential.h:
  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore):
(WebCore::initializeMaximumHTTPConnectionCountPerHost):

  • platform/text/TextChecking.h:

(WebCore):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::containsPaintedContent):

Source/WebKit2:

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue):

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::shouldEraseMarkersAfterChangeSelection):

  • WebProcess/WebCoreSupport/WebEditorClient.h:

Source/WTF:

  • wtf/ThreadingPthreads.cpp:

(WTF::initializeCurrentThreadInternal):

10:29 AM Changeset in webkit [121571] by zoltan@webkit.org
  • 3 edits in trunk/Tools

Add support for --force parameter to run-performance-tests
https://bugs.webkit.org/show_bug.cgi?id=90279

Reviewed by Dirk Pranke.

It's helpful to be able to run tests from the Skipped list of the performance tests.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._parse_args):
(PerfTestsRunner._collect_tests):

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: Add test.

(test_collect_tests_with_skipped_list):

10:20 AM Changeset in webkit [121570] by kling@webkit.org
  • 9 edits in trunk/Source/WebCore

Unreviewed, rolling out r121562.
http://trac.webkit.org/changeset/121562
https://bugs.webkit.org/show_bug.cgi?id=89945

Broke a couple of editing/pasteboard tests.

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::length):
(WebCore::PropertySetCSSStyleDeclaration::item):
(WebCore::PropertySetCSSStyleDeclaration::cssText):
(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyPriority):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyShorthand):
(WebCore::PropertySetCSSStyleDeclaration::isPropertyImplicit):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
(WebCore::PropertySetCSSStyleDeclaration::copy):
(WebCore::PropertySetCSSStyleDeclaration::makeMutable):
(WebCore::PropertySetCSSStyleDeclaration::cssPropertyMatches):
(WebCore::InlineCSSStyleDeclaration::didMutate):
(WebCore::InlineCSSStyleDeclaration::parentStyleSheet):

  • css/PropertySetCSSStyleDeclaration.h:

(WebCore::PropertySetCSSStyleDeclaration::clearParentElement):
(PropertySetCSSStyleDeclaration):
(WebCore::InlineCSSStyleDeclaration::InlineCSSStyleDeclaration):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::ensureInlineCSSStyleDeclaration):
(WebCore::StylePropertySet::clearParentElement):
(WebCore):

  • css/StylePropertySet.h:

(StylePropertySet):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::destroyInlineStyle):
(WebCore):

  • dom/ElementAttributeData.h:

(ElementAttributeData):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::~StyledElement):
(WebCore):
(WebCore::StyledElement::styleAttributeChanged):

  • dom/StyledElement.h:

(StyledElement):
(WebCore::StyledElement::destroyInlineStyle):

10:17 AM Changeset in webkit [121569] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Add missing support for tiled shadow blur on fillRect
https://bugs.webkit.org/show_bug.cgi?id=90082

Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2012-06-29
Reviewed by Noam Rosenthal.

This overloaded fillRect implementation also supports this optimization in
certain situations.

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::fillRect):

9:48 AM Changeset in webkit [121568] by tony@chromium.org
  • 8 edits in trunk

[GTK] Enable CSS grid layout LayoutTests on GTK+
https://bugs.webkit.org/show_bug.cgi?id=90226

Reviewed by Martin Robinson.

Source/WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::setCSSGridLayoutEnabled): Pass through to Settings object.

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Tools:

This feature is disabled via Settings by default, but for testing,
we enable it using layoutTestController.overridePreferences. Add the
necessary plumbing for DRT.

WTR already works because support was added for Apple Mac earlier.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues): Feature is off by default.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::overridePreference): Add handling of WebKitCSSGridLayoutEnabled.

LayoutTests:

  • platform/gtk/TestExpectations: Tests should pass.
9:01 AM Changeset in webkit [121567] by senorblanco@chromium.org
  • 87 edits
    18 adds
    18 deletes in trunk/LayoutTests

Unreviewed gardening.

Rebaseline tests affected by r121452.

  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-linux/svg/carto.net/scrollbar-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-mac-snowleopard/svg/carto.net/scrollbar-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-mac-snowleopard/transitions/cross-fade-background-image-expected.png:
  • platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png:
  • platform/chromium-mac/svg/carto.net/scrollbar-expected.png:
  • platform/chromium-mac/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-mac/transitions/cross-fade-background-image-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-win-xp/svg/carto.net: Removed.
  • platform/chromium-win/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png:
  • platform/chromium-win/svg/carto.net/scrollbar-expected.png:
  • platform/chromium-win/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-win/transitions/cross-fade-background-image-expected.png:
  • platform/chromium/TestExpectations:
  • platform/win-7sp0/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Added.
  • platform/win-7sp0/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Added.
  • platform/win-7sp0/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Added.
  • platform/win-7sp0/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Added.
  • platform/win-7sp0/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Added.
  • platform/win-7sp0/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Added.
  • platform/win-7sp0/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Added.
  • platform/win-7sp0/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Added.
  • platform/win-7sp0/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Added.
  • platform/win-7sp0/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Added.
  • platform/win-7sp0/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Added.
  • platform/win-7sp0/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Added.
  • platform/win-7sp0/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Added.
  • platform/win-7sp0/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Added.
  • platform/win-7sp0/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Added.
  • platform/win-7sp0/svg/W3C-I18N/text-anchor-no-markup-expected.png: Added.
  • platform/win-7sp0/svg/carto.net: Added.
  • platform/win-7sp0/svg/carto.net/scrollbar-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Removed.
  • platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Removed.
  • platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Removed.
  • platform/win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Removed.
  • platform/win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Removed.
  • platform/win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Removed.
  • platform/win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Removed.
  • platform/win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Removed.
  • platform/win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Removed.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Removed.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Removed.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Removed.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Removed.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Removed.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Removed.
  • platform/win/svg/W3C-I18N/text-anchor-no-markup-expected.png: Removed.
  • platform/win/svg/carto.net: Removed.
  • platform/win/svg/carto.net/scrollbar-expected.png: Removed.
8:57 AM Changeset in webkit [121566] by beidson@apple.com
  • 3 edits in trunk/Source/WebCore

Build fix - These should not be executable!

Rubberstamped by Jessie Berlin.

  • loader/cache/CachedSVGDocument.cpp: Removed property svn:executable.
  • loader/cache/CachedSVGDocument.h: Removed property svn:executable.
8:30 AM Changeset in webkit [121565] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Layout Test inspector/debugger/debugger-compile-and-run.html is failing
https://bugs.webkit.org/show_bug.cgi?id=90285

Reviewed by Pavel Feldman.

  • inspector/debugger/debugger-compile-and-run.html:
8:27 AM Changeset in webkit [121564] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Update FIXME comment in XMLDocumentParser::wellFormed
https://bugs.webkit.org/show_bug.cgi?id=90223

Patch by Kwang Yul Seo <skyul@company100.net> on 2012-06-29
Reviewed by Adam Barth.

XMLDocumentParser::wellFormed is still used by the XMLHttpRequest to check if the responseXML was well formed.
So it can't be removed.

  • xml/parser/XMLDocumentParser.h:

(XMLDocumentParser):

8:23 AM Changeset in webkit [121563] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt] Added Qt port for garden-o-matic.
https://bugs.webkit.org/show_bug.cgi?id=82719

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-06-29
Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:

(.):

8:21 AM Changeset in webkit [121562] by kling@webkit.org
  • 9 edits in trunk/Source/WebCore

Separate mutating CSSStyleDeclaration operations.
<http://webkit.org/b/89945>

Reviewed by Antti Koivisto.

Use separate paths for mutating the StylePropertySet wrapped by a CSSStyleDeclaration.
PropertySetCSSStyleDeclaration now has:

  • propertySet() const
  • ensureMutablePropertySet()

This is prep work for supporting immutable ElementAttributeData objects, the idea being
that calling ensureMutablePropertySet() may cause the element to convert its internal
attribute storage (which also holds the inline StylePropertySet.)

To that end, also removed the weird logic that allowed you to kill the inline style object
by removing the 'style' attribute. We now simply clear out all the properties in that case
which saves us a bunch of hassle (no need for a ~StyledElement anymore.)
Note that InlineCSSStyleDeclaration now refs the element rather than the inline style.

There should be no web-facing behavior change from any of this.

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::length):
(WebCore::PropertySetCSSStyleDeclaration::item):
(WebCore::PropertySetCSSStyleDeclaration::cssText):
(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyPriority):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyShorthand):
(WebCore::PropertySetCSSStyleDeclaration::isPropertyImplicit):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
(WebCore::PropertySetCSSStyleDeclaration::copy):
(WebCore::PropertySetCSSStyleDeclaration::makeMutable):
(WebCore::PropertySetCSSStyleDeclaration::cssPropertyMatches):
(WebCore::InlineCSSStyleDeclaration::InlineCSSStyleDeclaration):
(WebCore::InlineCSSStyleDeclaration::ref):
(WebCore::InlineCSSStyleDeclaration::deref):
(WebCore::InlineCSSStyleDeclaration::didMutate):
(WebCore::InlineCSSStyleDeclaration::parentStyleSheet):
(WebCore::InlineCSSStyleDeclaration::ensureMutablePropertySet):

  • css/PropertySetCSSStyleDeclaration.h:

(PropertySetCSSStyleDeclaration):
(WebCore::PropertySetCSSStyleDeclaration::propertySet):
(WebCore::PropertySetCSSStyleDeclaration::ensureMutablePropertySet):
(InlineCSSStyleDeclaration):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::ensureInlineCSSStyleDeclaration):

  • css/StylePropertySet.h:

(StylePropertySet):

  • dom/ElementAttributeData.cpp:
  • dom/ElementAttributeData.h:

(ElementAttributeData):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::styleAttributeChanged):

  • dom/StyledElement.h:

(WebCore::StyledElement::~StyledElement):
(StyledElement):

8:19 AM Changeset in webkit [121561] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Roll chromium rev to 144906
https://bugs.webkit.org/show_bug.cgi?id=90278

Unreviewed. Deps roll.

Patch by Ian Vollick <vollick@chromium.org> on 2012-06-29

  • DEPS:
8:16 AM Changeset in webkit [121560] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Don't call SegmentedString::toString() twice in XMLDocumentParser::append(const SegmentedString&)
https://bugs.webkit.org/show_bug.cgi?id=90254

Patch by Kwang Yul Seo <skyul@company100.net> on 2012-06-29
Reviewed by Adam Barth.

We can reuse the local variable parseString instead of calling s.toString() again.
No behavior change, so no new tests.

  • xml/parser/XMLDocumentParser.cpp:

(WebCore::XMLDocumentParser::append):

7:38 AM Changeset in webkit [121559] by zandobersek@gmail.com
  • 2 edits in trunk

Unreviewed build fix after r121518, adding a missing symbol to symbols.filter.

  • Source/autotools/symbols.filter:
7:35 AM Changeset in webkit [121558] by senorblanco@chromium.org
  • 2 edits
    15 adds
    8 deletes in trunk/LayoutTests

[chromium] Unreviewed gardening.

New baselines for tests added in r121513.

  • platform/chromium-linux/css3/filters/effect-reference-expected.png: Removed.
  • platform/chromium-linux/css3/filters/effect-reference-expected.txt: Removed.
  • platform/chromium-linux/css3/filters/effect-reference-external-expected.png: Removed.
  • platform/chromium-linux/css3/filters/effect-reference-external-expected.txt: Removed.
  • platform/chromium-linux/css3/filters/effect-reference-hw-expected.png: Removed.
  • platform/chromium-linux/css3/filters/effect-reference-hw-expected.txt: Removed.
  • platform/chromium-linux/css3/filters/effect-reference-ordering-expected.png: Removed.
  • platform/chromium-linux/css3/filters/effect-reference-ordering-expected.txt: Removed.
  • platform/chromium-mac/css3/filters/effect-reference-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-reference-expected.txt: Added.
  • platform/chromium-mac/css3/filters/effect-reference-external-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-reference-hw-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-reference-hw-expected.txt: Added.
  • platform/chromium-mac/css3/filters/effect-reference-ordering-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-reference-ordering-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-reference-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-reference-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-reference-external-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-reference-hw-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-reference-hw-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-reference-ordering-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-reference-ordering-expected.txt: Added.
  • platform/chromium/TestExpectations:
  • platform/chromium/css3/filters/effect-reference-external-expected.txt: Added.
7:31 AM Changeset in webkit [121557] by mihnea@adobe.com
  • 7 edits
    10 adds in trunk

Crash when flowing a fixed positioned element into a region.
https://bugs.webkit.org/show_bug.cgi?id=88133

Reviewed by Julien Chaffraix and Abhishek Arya.

Source/WebCore:

When a fixed positioned element is collected into a named flow, we have to make sure
that such element has the RenderFlowThread as containing block instead of RenderView,
so that the fixed positioned element is laid out properly.
Making the RenderFlowThread the top most containing block for named flow elements required the
modification of RenderLayer::convertToLayerCoords so that the fixed positioned elements inside the
named flow take the same code path as the absolute positioned elements inside the named flow.
I also added a method, checkBlockPositionedObjectsNeedLayout, in order to verify that a block
that is ending its layout, setNeedsLayout(false), has all the positioned children laid out.
This way, we will hit an assertion if an out-of-flow positioned child inside a RenderFlowThread
is not laid out after the RenderFlowThread is laid out.

Tests: fast/regions/absolute-pos-elem-in-named-flow.html

fast/regions/absolute-pos-elem-in-region.html
fast/regions/fixed-pos-elem-in-named-flow.html
fast/regions/fixed-pos-elem-in-named-flow2.html
fast/regions/fixed-pos-elem-in-region.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::checkPositionedObjectsNeedLayout):

  • rendering/RenderBlock.h:

(RenderBlock):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::convertToLayerCoords):

  • rendering/RenderObject.cpp:

(WebCore):
(WebCore::RenderObject::checkBlockPositionedObjectsNeedLayout):
(WebCore::RenderObject::containingBlock):
(WebCore::RenderObject::container):

  • rendering/RenderObject.h:

(RenderObject):
(WebCore::RenderObject::setNeedsLayout):

LayoutTests:

When a fixed positioned element is collected into a named flow, we have to make sure
that such element has the RenderFlowThread as containing block instead of RenderView,
so that the fixed positioned element is laid out properly.

  • fast/regions/absolute-pos-elem-in-named-flow-expected.txt: Added.
  • fast/regions/absolute-pos-elem-in-named-flow.html: Added.
  • fast/regions/absolute-pos-elem-in-region-expected.html: Added.
  • fast/regions/absolute-pos-elem-in-region.html: Added.
  • fast/regions/fixed-pos-elem-in-named-flow-expected.txt: Added.
  • fast/regions/fixed-pos-elem-in-named-flow.html: Added.
  • fast/regions/fixed-pos-elem-in-named-flow2-expected.txt: Added.
  • fast/regions/fixed-pos-elem-in-named-flow2.html: Added.
  • fast/regions/fixed-pos-elem-in-region-expected.html: Added.
  • fast/regions/fixed-pos-elem-in-region.html: Added.
6:52 AM Changeset in webkit [121556] by apavlov@chromium.org
  • 5 edits in trunk

Web Inspector: [Device Metrics] "Fit window" option inhibits adjusting the page zoom factor
https://bugs.webkit.org/show_bug.cgi?id=90187

Reviewed by Vsevolod Vlasov.

Source/WebKit/chromium:

This change fixes the stale zoom factor, which does not get updated upon browser window resize in the "Fit window" mode.
The expected test results have little to do with actual dimensions of the test page in Chrome on a real mobile device,
since Chrome on the mobile uses a different zooming technique (pageScaleFactor-based viewport using layout width
rather than plain pageZoomFactor) and font boosting, which has not been upstreamed yet.

  • src/WebDevToolsAgentImpl.cpp:

(WebKit::DeviceMetricsSupport::autoZoomPageToFitWidth):
(WebKit::DeviceMetricsSupport::ensureOriginalZoomFactor):

LayoutTests:

  • inspector/styles/override-screen-size-expected.txt:
  • platform/chromium/inspector/styles/device-metrics-fit-window-expected.txt:
5:51 AM Changeset in webkit [121555] by commit-queue@webkit.org
  • 24 edits in trunk/Source

Don't hardcode target dpi of 160 (it should be 96 on desktop)
https://bugs.webkit.org/show_bug.cgi?id=88114

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-06-29
Reviewed by Adam Barth.

Source/WebCore:

No behavioural change, current tests in fast/viewport cover all
functionality.

  • WebCore.exp.in: Updated symbol for computeViewportAttributes.
  • dom/ViewportArguments.cpp: Use new parameter for devicePixelRatio

and don't calculate it anymore.

(WebCore::computeViewportAttributes):

  • dom/ViewportArguments.h: Change the deviceDPI parameter to

devicePixelRatio and put the onus
on the embedder to supply the
correct value. Add temporary constant.

(WebCore):

Source/WebKit/blackberry:

Added new WebSetting to specify what the devicePixelRatio should be.
Updated the call to computeViewportAttributes.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):

  • Api/WebSettings.cpp:

(WebKit):
(BlackBerry::WebKit::WebSettings::standardSettings):
(BlackBerry::WebKit::WebSettings::devicePixelRatio):
(BlackBerry::WebKit::WebSettings::setDevicePixelRatio):

  • Api/WebSettings.h:
  • WebKitSupport/DumpRenderTreeSupport.cpp:

(DumpRenderTreeSupport::dumpConfigurationForViewport):

Source/WebKit/chromium:

Updated the call to computeViewportAttributes.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):

Source/WebKit/efl:

Updated the call to computeViewportAttributes.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::dumpConfigurationForViewport):

  • ewk/ewk_view.cpp:

(_ewk_view_viewport_attributes_compute):

Source/WebKit/gtk:

Updated the call to computeViewportAttributes.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::dumpConfigurationForViewport):

  • webkit/webkitviewportattributes.cpp:

(webkitViewportAttributesRecompute):

Source/WebKit/qt:

Updated the call to computeViewportAttributes.

  • Api/qwebpage.cpp:

(QWebPage::viewportAttributesForSize):

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::viewportAsText):

Source/WebKit2:

Updated the call to computeViewportAttributes.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::sendViewportAttributesChanged):
(WebKit::WebPage::viewportConfigurationAsText):

5:49 AM WebKitGTK/WebKit2Roadmap edited by mario@webkit.org
(diff)
5:47 AM WebKitGTK/WebKit2Roadmap edited by mario@webkit.org
(diff)
5:25 AM Changeset in webkit [121554] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

JS binding code generator doesn't handle "attribute unsigned long[]" well.
https://bugs.webkit.org/show_bug.cgi?id=84540

Patch by Vineet Chaudhary <Vineet> on 2012-06-29
Reviewed by Kentaro Hara.

In JS/V8 Bindings using traits instead of specialised functions.
Also added support for "unsigned long" in JSDOMBinding and V8Binding.

No new tests, as no behavioural changes.

  • bindings/js/JSDOMBinding.h:

(WebCore::Traits::arrayJSValue):
(WebCore::jsArray):

  • bindings/v8/V8Binding.h:

(WebCore::Traits::arrayV8Value):
(WebCore::v8Array):

5:23 AM Changeset in webkit [121553] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed mac build fix after r121547.
Remove the now-unused FontCustomPlatformData::m_atsContainer.

  • platform/graphics/mac/FontCustomPlatformData.h:

(FontCustomPlatformData):

5:08 AM Changeset in webkit [121552] by tkent@chromium.org
  • 3 edits
    2 adds in trunk

<textarea> unnecessarily saves the value in some cases
https://bugs.webkit.org/show_bug.cgi?id=90259

Reviewed by Hajime Morita.

Source/WebCore:

Test: fast/forms/textarea/textarea-state-restore.html

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::saveFormControlState):
We apply EOL normalization to value(), but don't apply it to
defaultValue(). Also value() can return a null string, which never
equals to any strings. To check m_isDirty is what we need..

LayoutTests:

  • fast/forms/textarea/textarea-state-restore-expected.txt: Added.
  • fast/forms/textarea/textarea-state-restore.html: Added.
5:06 AM Changeset in webkit [121551] by apavlov@chromium.org
  • 8 edits in trunk/Source/WebCore

Web Inspector: Provide source data for all known rule types in CSSParser, except "keyframe" and "region"
https://bugs.webkit.org/show_bug.cgi?id=88420

Reviewed by Antti Koivisto.

This change transitions the CSS source code model from a flat list of style rules to a tree of all types of CSS rules
(some of them lack actual source code data), which is crucial to model-based CSS stylesheet source editing
(add/remove CSS rule) and navigation.
As a side effect, the CSS parsing performance on PerformanceTests/Parser/css-parser-yui.html is improved roughly by 2%:

  • originally: median= 282.051282051 runs/s, stdev= 1.51236798322 runs/s, min= 278.481012658 runs/s, max= 283.870967742 runs/s
  • with patch applied: median= 287.206266319 runs/s, stdev= 1.31518320219 runs/s, min= 282.051282051 runs/s, max= 288.713910761 runs/s

No new tests, as there is no client-visible behavior change. Existing Inspector tests will be modified
to test the new data provided, along with the necessary Inspector plumbing.

  • css/CSSGrammar.y:
  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::reattach): Check for mediaQueries() validity before reattaching.

  • css/CSSParser.cpp: Unless explicitly specified below, the method changes are related to the extension of the

source-based CSS model provided by the parser.
(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::setupParser):
(WebCore::CSSParser::parseDeclaration): Accept a CSSRuleSourceData for filling, since it now contains
the related style source range.
(WebCore::CSSParser::createImportRule):
(WebCore::CSSParser::createMediaRule): Create CSSMediaRule even if media and rules are empty,
which is consistent with Mozilla.
(WebCore::CSSParser::processAndAddNewRuleToSourceTreeIfNeeded):
(WebCore):
(WebCore::CSSParser::addNewRuleToSourceTree):
(WebCore::CSSParser::createKeyframesRule):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createRegionRule):
(WebCore::CSSParser::fixUnparsedPropertyRanges):
(WebCore::CSSParser::markRuleHeaderStart):
(WebCore::CSSParser::markRuleHeaderEnd):
(WebCore::CSSParser::markRuleBodyStart):
(WebCore::CSSParser::markRuleBodyEnd):
(WebCore::CSSParser::markPropertyStart):
(WebCore::CSSParser::markPropertyEnd):

  • css/CSSParser.h:

(CSSParser):

  • css/CSSPropertySourceData.h: Extend the model to handle more types of rules and their containments.

(WebCore):
(WebCore::CSSRuleSourceData::create):
(WebCore::CSSRuleSourceData::createUnknown):
(CSSRuleSourceData):
(WebCore::CSSRuleSourceData::CSSRuleSourceData):

  • inspector/InspectorStyleSheet.cpp: Follow the CSSParser API changes but retain the flat stored CSS rules structure.

(ParsedStyleSheet):
(flattenSourceData): Flatten the rule tree to retain the existing rule-handling code intact.
(ParsedStyleSheet::setSourceData):
(ParsedStyleSheet::ruleSourceDataAt):
(WebCore::InspectorStyle::buildObjectForStyle):
(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyle::styleText):
(WebCore::InspectorStyleSheet::setRuleSelector):
(WebCore::InspectorStyleSheet::deleteRule):
(WebCore::InspectorStyleSheet::buildObjectForRule):
(WebCore::InspectorStyleSheet::buildObjectForStyle):
(WebCore::InspectorStyleSheet::ensureSourceData):
(WebCore::InspectorStyleSheet::styleSheetTextWithChangedStyle):
(WebCore::InspectorStyleSheetForInlineStyle::ensureParsedDataReady):
(WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):

  • inspector/InspectorStyleSheet.h:
5:05 AM Changeset in webkit [121550] by kbalazs@webkit.org
  • 4 edits in trunk/Tools

[Qt][WTR] Get rid of using DumpRenderTreeSupportQt
https://bugs.webkit.org/show_bug.cgi?id=90262

Reviewed by Alexey Proskuryakov.

Now that we decided to not support v8 in WebKit2
we can get rid of using DumpRenderTreeSupportQt
in WebKitTestRunner.

  • Tools.pro:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::resetAfterTest):
(WTR::InjectedBundlePage::didClearWindowForFrame):

  • WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
4:22 AM Changeset in webkit [121549] by vsevik@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: Annotate TextViewer.js
https://bugs.webkit.org/show_bug.cgi?id=90266

Reviewed by Yury Semikhatsky.

Annotated TextViewer.js and fixed found errors.
Drive-by: Fixed NativeMemorySnapshotView.js compilation.
Drive-by: Fixed protocol-externs.js compilation.
Drive-by: Removed unused platform parameter from TextViewer constructor.

  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::runScript):

  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

  • inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.NativeMemoryBarChart.prototype._updateView):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame):

  • inspector/front-end/TextViewer.js:

(WebInspector.TextEditorMainPanel.prototype._updateHighlightsForRange):

4:21 AM Changeset in webkit [121548] by commit-queue@webkit.org
  • 1 edit
    2 adds
    1 delete in trunk/LayoutTests

[EFL] Gardening after r121468
https://bugs.webkit.org/show_bug.cgi?id=90257

Unreviewed EFL gardening after r121468.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-29

  • platform/efl/fast/dom/Window/window-lookup-precedence-expected.txt: Removed.
  • platform/efl/fast/forms/label/labelable-elements-expected.txt: Added.
3:44 AM Changeset in webkit [121547] by eric@webkit.org
  • 21 edits in trunk/Source/WebCore

Remove still more BUILDING_ON_LEOPARD branches now that no port supports leopard
https://bugs.webkit.org/show_bug.cgi?id=90256

Reviewed by Ryosuke Niwa.

  • platform/LocalizedStrings.cpp:

(WebCore::imageTitle):

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::setAllowsFontSmoothing):

  • platform/graphics/cg/ImageCG.cpp:

(WebCore::Image::drawPattern):

  • platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::ImageSource::clear):

  • platform/graphics/cg/PathCG.cpp:

(WebCore::Path::boundingRect):

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::ctFont):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
  • platform/graphics/mac/ComplexTextController.cpp:
  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::fontCacheRegisteredFontsChangedNotificationCallback):
(WebCore::FontCache::platformInit):

  • platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::createFontCustomPlatformData):

  • platform/graphics/mac/FontCustomPlatformData.h:

(WebCore::FontCustomPlatformData::FontCustomPlatformData):

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformInit):

  • platform/graphics/mac/WebLayer.h:
  • platform/mac/CursorMac.mm:

(WebCore::Cursor::ensurePlatformCursor):

  • platform/mac/DisplaySleepDisabler.cpp:

(WebCore::DisplaySleepDisabler::DisplaySleepDisabler):
(WebCore::DisplaySleepDisabler::~DisplaySleepDisabler):

  • platform/mac/DisplaySleepDisabler.h:

(DisplaySleepDisabler):

  • platform/mac/HTMLConverter.h:
  • platform/mac/HTMLConverter.mm:
  • platform/mac/PopupMenuMac.mm:

(WebCore::PopupMenuMac::populate):

  • platform/mac/ScrollElasticityController.mm:
3:31 AM Changeset in webkit [121546] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Unreviewed attempt at a build fix for 64-bit debug build,
touch InsertionPoint.cpp to try to get it rebuilt.

  • html/shadow/InsertionPoint.cpp:

(WebCore):

3:15 AM Changeset in webkit [121545] by vestbo@webkit.org
  • 3 edits in trunk/Tools

Revert r121540, it broke most Qt builds

3:09 AM Changeset in webkit [121544] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Make build-webkit reject uknown configurations, eg. --profile

The qmake-based buildsystem doesn't support it.

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-06-29
Reviewed by Tor Arne Vestbø.

  • Scripts/webkitdirs.pm:

(buildQMakeProjects):

3:03 AM Changeset in webkit [121543] by vestbo@webkit.org
  • 4 edits in trunk

[Qt] Don't add Qt module dependencies in features.prf

The required dependencies are already added in WebCore.pri.

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-06-29
Reviewed by Tor Arne Vestbø.

2:54 AM Changeset in webkit [121542] by commit-queue@webkit.org
  • 10 edits
    3 adds in trunk

Web Inspector: Add FileSystemView
https://bugs.webkit.org/show_bug.cgi?id=73301

This patch introduce a split view as FileSystemView. Including directory tree as sidebar tree.

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-06-29
Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test: http/tests/inspector/filesystem/directory-tree.html

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/FileSystemModel.js:

(WebInspector.FileSystemModel.Entry.compare):

  • inspector/front-end/FileSystemView.js: Added.
  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.showFileSystem):
(WebInspector.FileSystemTreeElement.prototype.get itemURL):
(WebInspector.FileSystemTreeElement.prototype.onattach):
(WebInspector.FileSystemTreeElement.prototype._handleContextMenuEvent):
(WebInspector.FileSystemTreeElement.prototype._refreshFileSystem):
(WebInspector.FileSystemTreeElement.prototype.onselect):
(WebInspector.FileSystemTreeElement.prototype.clear):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:

LayoutTests:

  • http/tests/inspector/filesystem/directory-tree-expected.txt: Added.
  • http/tests/inspector/filesystem/directory-tree.html: Added.
  • http/tests/inspector/filesystem/filesystem-test.js:

(initialize_FileSystemTest.incrementRequestCount):
(initialize_FileSystemTest.decrementRequestCount):
(initialize_FileSystemTest.InspectorTest.callOnRequestCompleted):

2:50 AM Changeset in webkit [121541] by haraken@chromium.org
  • 17 edits in trunk/Source/WebCore

[V8] Replace v8::Integer::New() with v8Integer() in custom bindings
https://bugs.webkit.org/show_bug.cgi?id=90242

Reviewed by Yury Semikhatsky.

v8Integer() is a fast wrapper of v8::Integer::New().
This patch replaces v8::Integer::New() with v8Integer() in custom bindings,
and pass isolates.

No tests. No change in behavior.

  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:

(WebCore::V8CSSStyleDeclaration::namedPropertyEnumerator):
(WebCore::V8CSSStyleDeclaration::namedPropertyQuery):

  • bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::typesAccessorGetter):

  • bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::V8DOMStringMap::namedPropertyQuery):
(WebCore::V8DOMStringMap::namedPropertyEnumerator):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::WindowSetTimeoutImpl):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::getInt8Callback):
(WebCore::V8DataView::getUint8Callback):

  • bindings/v8/custom/V8HTMLInputElementCustom.cpp:

(WebCore::V8HTMLInputElement::selectionStartAccessorGetter):
(WebCore::V8HTMLInputElement::selectionEndAccessorGetter):

  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::lengthAccessorGetter):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::functionDetailsCallback):

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::portsAccessorGetter):

  • bindings/v8/custom/V8MutationCallbackCustom.cpp:

(WebCore::V8MutationCallback::handleEvent):

  • bindings/v8/custom/V8NodeListCustom.cpp:

(WebCore::V8NodeList::namedPropertyGetter):

  • bindings/v8/custom/V8SQLTransactionCustom.cpp:

(WebCore::V8SQLTransaction::executeSqlCallback):

  • bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:

(WebCore::V8SQLTransactionSync::executeSqlCallback):

  • bindings/v8/custom/V8StorageCustom.cpp:

(WebCore::V8Storage::namedPropertyEnumerator):
(WebCore::V8Storage::indexedPropertyGetter):
(WebCore::V8Storage::namedPropertyQuery):
(WebCore::V8Storage::indexedPropertySetter):
(WebCore::V8Storage::indexedPropertyDeleter):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):
(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
(WebCore::V8WebGLRenderingContext::getSupportedExtensionsCallback):

  • bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::SetTimeoutOrInterval):

2:49 AM Changeset in webkit [121540] by vestbo@webkit.org
  • 3 edits in trunk/Tools

[Qt] Use LIBS_PRIVATE instead of putting dependencies into LIBS

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-06-27
Reviewed by Tor Arne Vestbø..

  • qmake/mkspecs/features/default_post.prf:
  • qmake/mkspecs/features/functions.prf:
2:44 AM Changeset in webkit [121539] by haraken@chromium.org
  • 6 edits in trunk/Source/WebCore

Unreviewed, rolling out r121520.
http://trac.webkit.org/changeset/121520
https://bugs.webkit.org/show_bug.cgi?id=90246

the performance optimization needs more investigation

  • dom/DatasetDOMStringMap.cpp:

(WebCore::convertPropertyNameToAttributeName):

  • dom/Element.cpp:

(WebCore::Element::getAttributeNS):
(WebCore::Element::removeAttribute):
(WebCore::Element::removeAttributeNS):
(WebCore::Element::getAttributeNode):
(WebCore::Element::getAttributeNodeNS):
(WebCore::Element::hasAttribute):
(WebCore::Element::hasAttributeNS):

  • dom/Element.h:

(Element):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::getAttributeNode):

  • dom/ElementAttributeData.h:

(ElementAttributeData):

2:35 AM Changeset in webkit [121538] by haraken@chromium.org
  • 17 edits in trunk/Source/WebCore

[V8] Replace v8::Integer::New() with v8Integer() in bindings/v8/*.{h,cpp}
https://bugs.webkit.org/show_bug.cgi?id=90238

Reviewed by Yury Semikhatsky.

v8Integer() is a fast wrapper of v8::Integer::New().
We can replace v8::Integer::New() with v8Integer()
in bindings/v8/*.{h,cpp}. In addition, we pass isolate
to v8Integer() where possible.

No tests. No change in behavior.

  • bindings/v8/Dictionary.cpp:

(WebCore::Dictionary::get):

  • bindings/v8/NPV8Object.cpp:

(_NPN_Enumerate): Changed v8::None to 0, for consistency with other code.

  • bindings/v8/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::addListener):

  • bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::compileScript):

  • bindings/v8/SerializedScriptValue.cpp:
  • bindings/v8/V8Binding.cpp:

(WebCore::v8Array):
(WebCore::v8ValueToWebCoreDOMStringList):

  • bindings/v8/V8Binding.h:

(WebCore::v8Array):
(WebCore::v8NumberArrayToVector):

  • bindings/v8/V8Collection.h:

(WebCore::nodeCollectionIndexedPropertyEnumerator):
(WebCore::collectionIndexedPropertyEnumerator):

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

  • bindings/v8/V8NPObject.cpp:

(WebCore::npObjectQueryProperty):
(WebCore::npObjectPropertyEnumerator):

  • bindings/v8/V8NPUtils.cpp:

(WebCore::convertNPVariantToV8Object):

  • bindings/v8/V8Proxy.cpp:

(WebCore::batchConfigureConstants):
(WebCore::V8Proxy::compileScript):

  • bindings/v8/V8Utilities.cpp:

(WebCore::createHiddenDependency):
(WebCore::removeHiddenDependency):

  • bindings/v8/V8WindowErrorHandler.cpp:

(WebCore::V8WindowErrorHandler::callListenerFunction):

  • bindings/v8/V8WorkerContextErrorHandler.cpp:

(WebCore::V8WorkerContextErrorHandler::callListenerFunction):

  • bindings/v8/WorkerScriptDebugServer.cpp:

(WebCore::WorkerScriptDebugServer::addListener):

2:32 AM Changeset in webkit [121537] by vsevik@chromium.org
  • 7 edits
    2 adds in trunk

Web Inspector: Resource content is not loaded if Resource.requestContent method is called before network request is finished.
https://bugs.webkit.org/show_bug.cgi?id=90153

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: http/tests/inspector/resource-tree/resource-request-content-while-loading.html

  • inspector/front-end/NetworkRequest.js:
  • inspector/front-end/Resource.js:

(WebInspector.Resource):
(WebInspector.Resource.prototype.requestContent):
(WebInspector.Resource.prototype._requestFinished):

LayoutTests:

Resource.requestContent() now checks that request (if there is one) was already loaded before requesting content from PageAgent.
Drive-by: Removed unneeded legacy request._resource field.

  • http/tests/inspector/network/network-request-revision-content.html:
  • http/tests/inspector/resource-tree/resource-request-content-while-loading-expected.txt: Added.
  • http/tests/inspector/resource-tree/resource-request-content-while-loading.html: Added.
  • http/tests/inspector/resources-test.js:

(initialize_ResourceTest.InspectorTest.runAfterResourcesAreFinished.checkResources):
(initialize_ResourceTest.InspectorTest.runAfterResourcesAreFinished):
(initialize_ResourceTest.InspectorTest.showResource.showResourceCallback):
(initialize_ResourceTest.InspectorTest.showResource):
(initialize_ResourceTest.InspectorTest.resourceMatchingURL.visit):
(initialize_ResourceTest.InspectorTest.resourceMatchingURL):
(initialize_ResourceTest):

  • inspector/debugger/raw-source-code.html:
2:17 AM Changeset in webkit [121536] by keishi@webkit.org
  • 33 edits in trunk/Source

Unreviewed, rolling out r121529.
http://trac.webkit.org/changeset/121529
https://bugs.webkit.org/show_bug.cgi?id=90260

Failed to compile on Chromium WebKitMacBuilder (Requested by
keishi on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-29

Source/WebCore:

  • platform/LocalizedStrings.cpp:

(WebCore):

  • platform/graphics/cg/PathCG.cpp:

(WebCore::Path::platformAddPathForRoundedRect):

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::setFont):

  • platform/graphics/mac/ComplexTextControllerCoreText.mm:

(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):

  • platform/graphics/mac/FontMac.mm:

(WebCore::showGlyphsWithAdvances):

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore):

  • platform/mac/CursorMac.mm:

(WebCore::Cursor::ensurePlatformCursor):

  • platform/mac/MemoryPressureHandlerMac.mm:

(WebCore):

  • platform/mac/PlatformEventFactoryMac.mm:

(WebCore::momentumPhaseForEvent):
(WebCore::phaseForEvent):

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):

  • platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::doUpdatePlatformRequest):

  • platform/text/cf/HyphenationCF.cpp:
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::shouldShowPlaceholderWhenFocused):

Source/WebKit/mac:

  • DefaultDelegates/WebDefaultContextMenuDelegate.mm:

(-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):

  • Misc/WebNSControlExtras.m:

(-[NSControl sizeToFitAndAdjustWindowHeight]):

  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::shouldEraseMarkersAfterChangeSelection):
(WebEditorClient::getGuessesForWord):

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchDidFirstLayout):
(WebFrameLoaderClient::provisionalLoadStarted):

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

  • WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView scrollWheel:]):

  • WebView/WebFullScreenController.mm:

(-[WebFullScreenController finishedEnterFullScreenAnimation:]):
(-[WebFullScreenController exitFullScreen]):

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):

  • WebView/WebView.mm:

(+[WebView initialize]):
(-[WebView _deviceScaleFactor]):

Source/WebKit2:

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]):
(-[WKFullScreenWindowController beganExitFullScreenWithInitialFrame:WebCore::finalFrame:WebCore::]):

  • WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm:
  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WTF:

  • wtf/FastMalloc.cpp:

(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):

  • wtf/unicode/icu/CollatorICU.cpp:

(WTF::Collator::userDefault):

2:12 AM Changeset in webkit [121535] by vsevik@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Add toggle breakpoint shortcut.
https://bugs.webkit.org/show_bug.cgi?id=90188

Reviewed by Yury Semikhatsky.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype._onMouseDown):
(WebInspector.JavaScriptSourceFrame.prototype._toggleBreakpoint):
(WebInspector.JavaScriptSourceFrame.prototype.toggleBreakpointOnCurrentLine):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._toggleBreakpoint):
(WebInspector.ScriptsPanel.prototype._showOutlineDialog):

  • inspector/front-end/TextViewer.js:

(WebInspector.TextViewer.prototype.selection):

2:09 AM Changeset in webkit [121534] by vsevik@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: Cursor should follow execution line when debugging.
https://bugs.webkit.org/show_bug.cgi?id=90184

Reviewed by Yury Semikhatsky.

Added TextViewer.setSelection public method to set cursor selection in the editor.
Added TextRange.createFromLocation method to create TextRanges with the same start and end points.
Drive-by: removed unused _setCaretLocation() method in TextViewer.js

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.setExecutionLine):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._revealExecutionLine):
(WebInspector.ScriptsPanel.prototype._editorSelected):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.setSelection):
(WebInspector.SourceFrame.prototype.setContent):

  • inspector/front-end/TextEditorModel.js:

(WebInspector.TextRange.createFromLocation):

  • inspector/front-end/TextViewer.js:

(WebInspector.TextViewer.prototype.setSelection):
(WebInspector.TextEditorMainPanel.prototype.highlightLine):

2:05 AM Changeset in webkit [121533] by vsevik@chromium.org
  • 9 edits in trunk

Web Inspector: IDBObjectStore.autoIncrement flag not exposed
https://bugs.webkit.org/show_bug.cgi?id=89701

Reviewed by Yury Semikhatsky.

Source/WebCore:

Plumbed objectStore.autoIncrement to inspector front-end and added it to tooltip.

  • English.lproj/localizedStrings.js:
  • inspector/Inspector.json:
  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):

  • inspector/front-end/IndexedDBModel.js:

(WebInspector.IndexedDBModel.prototype._loadDatabase.callback):
(WebInspector.IndexedDBModel.prototype._loadDatabase):
(WebInspector.IndexedDBModel.ObjectStore):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.IDBObjectStoreTreeElement.prototype._updateTooltip):

LayoutTests:

  • http/tests/inspector/indexeddb/database-structure-expected.txt:
  • http/tests/inspector/indexeddb/database-structure.html:
2:02 AM Changeset in webkit [121532] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

Deleting unused function in WebDeviceOrientation
https://bugs.webkit.org/show_bug.cgi?id=90185

Patch by Amy Ousterhout <aousterh@chromium.org> on 2012-06-29
Reviewed by Adam Barth.

Deleting the unused copy assignment function in WebDeviceOrientation.

  • public/WebDeviceOrientation.h:

(WebDeviceOrientation):

  • src/WebDeviceOrientation.cpp:
1:55 AM Changeset in webkit [121531] by apavlov@chromium.org
  • 5 edits
    2 adds in trunk

Use floating keyframe rule list when parsing @-webkit-keyframes and allow abrupt rule termination
https://bugs.webkit.org/show_bug.cgi?id=90073

Reviewed by Antti Koivisto.

Source/WebCore:

  • The grammar is changed to allow abruptly terminated stylesheet in the @-webkit-keyframes (use closing_brace, not '}').
  • A floating StyleKeyframe vector is introduced to separate the creation and filling of StyleRuleKeyframes, as other rules do.

Test: fast/css/css-keyframe-unexpected-end.html

  • css/CSSGrammar.y:
  • css/CSSParser.cpp:

(WebCore::CSSParser::createFloatingKeyframeVector):
(WebCore):
(WebCore::CSSParser::sinkFloatingKeyframeVector):
(WebCore::CSSParser::createKeyframesRule):

  • css/CSSParser.h:

LayoutTests:

  • fast/css/css-keyframe-unexpected-end-expected.txt: Added.
  • fast/css/css-keyframe-unexpected-end.html: Added.
1:46 AM Changeset in webkit [121530] by yurys@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: add character data to the DOM section of native memory view
https://bugs.webkit.org/show_bug.cgi?id=89968

Reviewed by Vsevolod Vlasov.

Count strings referenced from CharacterData node and its descendants
as part of the DOM tree structures in the native memory view.

  • dom/CharacterData.cpp:

(WebCore::CharacterData::reportMemoryUsage):
(WebCore):

  • dom/CharacterData.h:

(CharacterData):

  • dom/MemoryInstrumentation.h:

(MemoryInstrumentation):
(WebCore::MemoryObjectInfo::reportString):
(MemoryObjectInfo):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore):
(WebCore::domTreeInfo):
(WebCore::jsExternalResourcesInfo):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):

  • inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.MemoryBlockViewProperties._initialize):

1:28 AM Changeset in webkit [121529] by eric@webkit.org
  • 33 edits in trunk/Source

Remove more BUILDING_ON_LEOPARD branches now that no port builds on Leopard
https://bugs.webkit.org/show_bug.cgi?id=90252

Reviewed by Ryosuke Niwa.

Source/WebCore:

  • platform/LocalizedStrings.cpp:

(WebCore):

  • platform/graphics/cg/PathCG.cpp:

(WebCore::Path::platformAddPathForRoundedRect):

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::setFont):

  • platform/graphics/mac/ComplexTextControllerCoreText.mm:

(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):

  • platform/graphics/mac/FontMac.mm:

(WebCore::showGlyphsWithAdvances):

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore):

  • platform/mac/CursorMac.mm:

(WebCore::Cursor::ensurePlatformCursor):

  • platform/mac/MemoryPressureHandlerMac.mm:

(WebCore):

  • platform/mac/PlatformEventFactoryMac.mm:

(WebCore::momentumPhaseForEvent):
(WebCore::phaseForEvent):

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):

  • platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::doUpdatePlatformRequest):

  • platform/text/cf/HyphenationCF.cpp:
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::shouldShowPlaceholderWhenFocused):

Source/WebKit/mac:

  • DefaultDelegates/WebDefaultContextMenuDelegate.mm:

(-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):

  • Misc/WebNSControlExtras.m:

(-[NSControl sizeToFitAndAdjustWindowHeight]):

  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::shouldEraseMarkersAfterChangeSelection):
(WebEditorClient::getGuessesForWord):

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchDidFirstLayout):
(WebFrameLoaderClient::provisionalLoadStarted):

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

  • WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView scrollWheel:]):

  • WebView/WebFullScreenController.mm:

(-[WebFullScreenController finishedEnterFullScreenAnimation:]):
(-[WebFullScreenController exitFullScreen]):

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):

  • WebView/WebView.mm:

(+[WebView initialize]):
(-[WebView _deviceScaleFactor]):

Source/WebKit2:

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]):
(-[WKFullScreenWindowController beganExitFullScreenWithInitialFrame:WebCore::finalFrame:WebCore::]):

  • WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm:
  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WTF:

  • wtf/FastMalloc.cpp:

(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):

  • wtf/unicode/icu/CollatorICU.cpp:

(WTF::Collator::userDefault):

1:14 AM Changeset in webkit [121528] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: showConsole() should close previous view in drawer.
https://bugs.webkit.org/show_bug.cgi?id=90070

Reviewed by Yury Semikhatsky.

  • inspector/front-end/inspector.js:

(WebInspector.showConsole):
(WebInspector.showPanel):

12:59 AM BuildingQtOnLinux edited by ssandela@innominds.com
Update the required dependencies on Debian/Ubuntu command (diff)
12:46 AM Changeset in webkit [121527] by kkristof@inf.u-szeged.hu
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r121494. Added new baseline to
fast/frames/flattening/frameset-flattening-advanced.html

Patch by János Badics <János Badics> on 2012-06-29

  • platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.png:
  • platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.txt:
12:44 AM Changeset in webkit [121526] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove a #include erroneously added in r120896.

  • editing/VisibleSelection.h:
12:26 AM Changeset in webkit [121525] by yosin@chromium.org
  • 9 edits
    3 adds in trunk/Source

[Platform] Implement Date Time format parser
https://bugs.webkit.org/show_bug.cgi?id=89963

Reviewed by Kent Tamura.

Source/WebCore:

This patch introduces Unicode TR35 LDML date time format parser for
input type "time" if ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS) is true.

Test: WebKit/chromium/tests/DateTimeFormatTest.cpp

  • CMakeLists.txt: Added DateTimeFormat.cpp
  • GNUmakefile.list.am: Added DateTimeFormat.{cpp,h}
  • Target.pri: ditto
  • WebCore.gypi: ditto
  • WebCore.vcproj/WebCore.vcproj: ditto
  • WebCore.xcodeproj/product.pbxproj: ditto
  • platform/text/DateTimeFormat.cpp: Added.

(WebCore::mapCharacterToFieldTypeInternal):
(WebCore::DateTimeFormat::DateTimeFormat):
(WebCore::DateTimeFormat::mapCharacterToFieldType):
(WebCore::DateTimeFormat::parse):

  • platform/text/DateTimeFormat.h: Added.

(DateTimeFormat):
(TokenHandler):
(WebCore::DateTimeFormat::TokenHandler::~TokenHandler):

Source/WebKit/chromium:

This patch adds an unit test for date time format parser if
ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS) is true.

  • tests/DateTimeFormatTest.cpp: Added.

(DateTimeFormatTest):
(Token):
(DateTimeFormatTest::Token::Token):
(DateTimeFormatTest::Token::operator==):
(DateTimeFormatTest::Token::toString):
(Tokens):
(DateTimeFormatTest::Tokens::Tokens):
(DateTimeFormatTest::Tokens::operator==):
(DateTimeFormatTest::Tokens::toString):
(DateTimeFormatTest::parse):
(DateTimeFormatTest::single):
(TokenHandler):
(DateTimeFormatTest::TokenHandler::~TokenHandler):
(DateTimeFormatTest::TokenHandler::fieldType):
(DateTimeFormatTest::TokenHandler::tokens):
(DateTimeFormatTest::TokenHandler::visitField):
(DateTimeFormatTest::TokenHandler::visitLiteral):
(operator<<):
(TEST_F):

12:15 AM Changeset in webkit [121524] by eric@webkit.org
  • 15 edits in trunk/Source

Remove more BUILDING_ON_LEOPARD usage in PLATFORM(MAC) code
https://bugs.webkit.org/show_bug.cgi?id=85846

Reviewed by Adam Barth.

PLATFORM(MAC) has not supported Leopard for several months now.
This change removes about 1/3 of the remaining BUILDING_ON_LEOPARD
uses in the PLATFORM(MAC) codepaths. PLATFORM(CHROMIUM) still
supports BUILDING_ON_LEOPARD for now.

Source/WebCore:

  • WebCore.exp.in:
  • dom/Document.cpp:

(WebCore::Document::updateRangesAfterChildrenChanged):
(WebCore::Document::nodeChildrenWillBeRemoved):
(WebCore::Document::nodeWillBeRemoved):
(WebCore::Document::textInserted):
(WebCore::Document::textRemoved):
(WebCore::Document::textNodesMerged):
(WebCore::Document::textNodeSplit):

  • editing/Editor.cpp:

(WebCore::Editor::respondToChangedSelection):

  • editing/TypingCommand.cpp:

(WebCore::TypingCommand::markMisspellingsAfterTyping):
(WebCore::TypingCommand::typingAddedToOpenCommand):

  • editing/mac/EditorMac.mm:

(WebCore::Editor::pasteWithPasteboard):

  • loader/EmptyClients.h:

(EmptyEditorClient):

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::createAndAppendSpellingAndGrammarSubMenu):
(WebCore):
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::checkOrEnableIfNeeded):

  • page/EditorClient.h:

(EditorClient):

  • platform/LocalizedStrings.cpp:

(WebCore::contextMenuItemTagSearchWeb):

  • platform/MemoryPressureHandler.cpp:

(WebCore):

  • platform/SuddenTermination.h:

(WebCore):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::updateContentsImage):
(WebCore::GraphicsLayerCA::constrainedSize):

  • platform/graphics/ca/PlatformCALayer.h:

(PlatformCALayer):

  • platform/graphics/ca/mac/PlatformCAAnimationMac.mm:

(fromCAValueFunctionType):
(PlatformCAAnimation::valueFunction):
(PlatformCAAnimation::setValueFunction):

  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(toCAFilterType):
(PlatformCALayer::anchorPoint):
(PlatformCALayer::setAnchorPoint):
(PlatformCALayer::contentsTransform):
(PlatformCALayer::setContentsTransform):
(PlatformCALayer::isGeometryFlipped):
(PlatformCALayer::setGeometryFlipped):
(PlatformCALayer::acceleratesDrawing):
(PlatformCALayer::setAcceleratesDrawing):
(PlatformCALayer::setMinificationFilter):
(PlatformCALayer::setMagnificationFilter):
(PlatformCALayer::contentsScale):
(PlatformCALayer::setContentsScale):

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::setScale):
(WebCore::TileCache::setAcceleratesDrawing):
(WebCore::TileCache::createTileLayer):

Source/WTF:

  • wtf/Platform.h:
12:06 AM Changeset in webkit [121523] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Use StringBuilder in SegmentedString::toString()
https://bugs.webkit.org/show_bug.cgi?id=90247

Patch by Kwang Yul Seo <skyul@company100.net> on 2012-06-29
Reviewed by Adam Barth.

Use a StringBuilder instead of String concatenation because StringBuilder is generally faster.
No new tests. Covered by existing tests.

  • platform/text/SegmentedString.cpp:

(WebCore::SegmentedString::toString):

  • platform/text/SegmentedString.h:

(WebCore::SegmentedSubstring::appendTo):

Jun 28, 2012:

11:54 PM Changeset in webkit [121522] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Mac build fix after r121518.

  • WebCore.exp.in:
11:38 PM Changeset in webkit [121521] by rniwa@webkit.org
  • 4 edits
    2 copies in trunk

DOMHTMLCollection::item may return a wrong element after namedItem is called
https://bugs.webkit.org/show_bug.cgi?id=90240

Reviewed by Antti Koivisto.

Source/WebCore:

The bug was caused by namedItem updating m_cache.current without updating m_cache.position.
Fixed the bug by updating both. This is similar to the bug I fixed in r121478.

WebKit API Test: WebKit1.HTMLCollectionNamedItemTest

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::namedItem):

Tools:

Add a WebKit API test since namedItem is not used in the JS/V8 binding code.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.html: Copied from Tools/TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.html.
  • TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm: Copied from Tools/TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm.

(TestWebKitAPI::TEST):

11:20 PM Changeset in webkit [121520] by haraken@chromium.org
  • 6 edits in trunk/Source/WebCore

Change argument types of Element::getAttribute*() from String to AtomicString
https://bugs.webkit.org/show_bug.cgi?id=90246

Reviewed by Ryosuke Niwa.

This is a follow-up patch for r121439. r121439 changed an argument type of
Element::getAttribute() from String to AtomicString, which optimized
performance of Dromaeo/dom-attr.html. This patch changes other argument types
of Element::getAttribute*() from String to AtomicString. See the ChangeLog in
http://trac.webkit.org/changeset/121439 for more details about why this change
optimizes performance.

No tests. No change in behavior.

  • dom/DatasetDOMStringMap.cpp:

(WebCore::convertPropertyNameToAttributeName):

  • dom/Element.cpp:

(WebCore::Element::getAttributeNS):
(WebCore::Element::removeAttribute):
(WebCore::Element::removeAttributeNS):
(WebCore::Element::getAttributeNode):
(WebCore::Element::getAttributeNodeNS):
(WebCore::Element::hasAttribute):
(WebCore::Element::hasAttributeNS):

  • dom/Element.h:

(Element):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::getAttributeNode):

  • dom/ElementAttributeData.h:

(ElementAttributeData):

11:12 PM Changeset in webkit [121519] by tkent@chromium.org
  • 6 edits in trunk

REGRESSION(r106388): Form hidden element values being restored
incorrectly for dynamically generated content
https://bugs.webkit.org/show_bug.cgi?id=88685

Reviewed by Hajime Morita.

Source/WebCore:

We should not save value attribute updated during parsing.

Test: fast/forms/state-restore-to-non-edited-controls.html

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::HTMLInputElement):
Initialize m_valueAttributeWasUpdatedAfterParsing.
(WebCore::HTMLInputElement::parseAttribute):
Set true to m_valueAttributeWasUpdatedAfterParsing if value
attribute is updated and it's not in parsing.

  • html/HTMLInputElement.h:

(WebCore::HTMLInputElement::valueAttributeWasUpdatedAfterParsing):
Added for HiddenInputType.

  • html/HiddenInputType.cpp:

(WebCore::HiddenInputType::saveFormControlState):
Save the value only if valueAttributeWasUpdatedAfterParsing() is true.

LayoutTests:

  • fast/forms/state-restore-to-non-edited-controls-expected.txt:

A failing test is fixed.

11:00 PM Changeset in webkit [121518] by morrita@google.com
  • 11 edits in trunk

[Refactoring] NodeRenderingContext ctor could be built on top of the ComposedShadowTreeWalker
https://bugs.webkit.org/show_bug.cgi?id=89732

Reviewed by Dimitri Glazkov.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

The constructor of NodeRenderingContext implements almost same
logic as ComposedShadowTreeWalker::parent(). This change
eliminates the duplication by employing ComposedShadowTreeWalker in the constructor.

ComposedShadowTreeWalker has same difference from
NodeRenderingContext though. So this change also extends
ComposedShadowTreeWalker to support these missing pieces, which
are encapsulated in newly introduced ParentTranversalDetails
class where:

  • not only the parent, but also the insertion point of the child is returned,
  • resetStyleInheritance from the child-parent traversal is computed and
  • if the starting point is out of the composition, it returns null as a parent.

This change also inlines some ComposedShadowTreeWalker methods for speed.

No new tests. Covered by existing tests.

  • WebCore.exp.in:
  • dom/ComposedShadowTreeWalker.cpp:

(WebCore::shadowOfParent):
(WebCore::ComposedShadowTreeWalker::ParentTranversalDetails::didTraverseInsertionPoint):
(WebCore):
(WebCore::ComposedShadowTreeWalker::ParentTranversalDetails::didTraverseShadowRoot):
(WebCore::ComposedShadowTreeWalker::ParentTranversalDetails::didFindNode):
(WebCore::ComposedShadowTreeWalker::findParent):
(WebCore::ComposedShadowTreeWalker::escapeFallbackContentElement):
(WebCore::ComposedShadowTreeWalker::traverseNodeEscapingFallbackContents):
(WebCore::ComposedShadowTreeWalker::traverseParent):
(WebCore::ComposedShadowTreeWalker::traverseParentInCurrentTree):
(WebCore::ComposedShadowTreeWalker::traverseParentBackToYoungerShadowRootOrHost):

  • dom/ComposedShadowTreeWalker.h:

(ParentTranversalDetails):
(WebCore::ComposedShadowTreeWalker::ParentTranversalDetails::ParentTranversalDetails):
(WebCore::ComposedShadowTreeWalker::ParentTranversalDetails::node):
(WebCore::ComposedShadowTreeWalker::ParentTranversalDetails::insertionPoint):
(WebCore::ComposedShadowTreeWalker::ParentTranversalDetails::resetStyleInheritance):
(WebCore::ComposedShadowTreeWalker::ParentTranversalDetails::outOfComposition):
(WebCore::ComposedShadowTreeWalker::ParentTranversalDetails::childWasOutOfComposition):
(ComposedShadowTreeWalker):
(WebCore::ComposedShadowTreeWalker::ComposedShadowTreeWalker):
(WebCore):

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):
(WebCore::NodeRenderingContext::parentRenderer):
(WebCore::NodeRenderingContext::shouldCreateRenderer):
(WebCore::NodeRenderingContext::isOnEncapsulationBoundary):

  • dom/NodeRenderingContext.h:

(NodeRenderingContext):
(WebCore::NodeRenderingContext::parentNodeForRenderingAndStyle):
(WebCore::NodeRenderingContext::resetStyleInheritance):
(WebCore::NodeRenderingContext::insertionPoint):

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
9:45 PM Changeset in webkit [121517] by bashi@chromium.org
  • 2 edits
    4 adds in trunk/LayoutTests

[Chromium] unreviewed test expectations update after r121510.

  • platform/chromium-mac-leopard/css3/font-feature-settings-rendering-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/font-feature-settings-rendering-expected.png: Added.
  • platform/chromium-mac/css3/font-feature-settings-rendering-expected.png: Added.
  • platform/chromium-mac/css3/font-feature-settings-rendering-expected.txt: Added.
  • platform/chromium/TestExpectations:
9:20 PM Changeset in webkit [121516] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk

[BlackBerry] Selection items show as garbage for non-ascii characters.
https://bugs.webkit.org/show_bug.cgi?id=89969

Add charset utf-8 to the select popup's page.

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-06-28
Reviewed by Antonio Gomes.

.:

  • ManualTests/blackberry/select-popup-items-unicode-display.html: Added.

Source/WebKit/blackberry:

  • WebCoreSupport/SelectPopupClient.cpp:

(WebCore::SelectPopupClient::generateHTML):

8:59 PM Changeset in webkit [121515] by keishi@webkit.org
  • 2 edits in trunk/LayoutTests

[Chromium] Mark 4 tests in css3/filters as MISSING. Caused by r121513.

Unreviewed.

  • platform/chromium/TestExpectations:
7:52 PM Changeset in webkit [121514] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Checkerboard shown when clicking on error page buttons
https://bugs.webkit.org/show_bug.cgi?id=90152
RIM PR #161867

Reviewed by George Staikos.

Reset m_hasBlitJobs when resetting tiles to prevent ui thread from drawing checkerboard unintentionally.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::resetTiles):

7:50 PM Changeset in webkit [121513] by senorblanco@chromium.org
  • 31 edits
    16 adds in trunk

Source/WebCore: Implement filter url() function.
https://bugs.webkit.org/show_bug.cgi?id=72443

url() references can be internal, in which case the DOM nodes are
retrieved directly from the current document, or external, in which
case a CachedSVGDocument request is made, and the filter node build is
deferred until the document is loaded. WebKitSVGDocumentValue
holds the CachedSVGDocument (if any) and the URL as a CSSValue,
and is stored in the CSSValue chain as the argument to the reference
filter.

One notable difference between internal and external references is
that internal references will automatically update on an SVG filter node
attribute change, while external references will not, since they live
in a separate document. This is consistent with the Mozilla
implementation. In order to make this work, the RenderLayer is made a
client of the RenderSVGResourceContainer, and calls
filterNeedsRepaint() when the SVG nodes are invalidated.

Some plumbing: The CSS StyleResolver was refactored to load all
all external resources (images, shaders and (now) SVG filters) in a
single function, loadPendingResources(). The PlatformLayer typedef
was moved out into its own file, in order to break a cyclic
dependency. SVGFilterBuilder was modified to accept the SourceGraphic
and SourceAlpha FilterEffects in its constructor and factory function,
rather than extracting them from the parent Filter. (This is necessary
so that the url() filter can correctly hook up its inputs from
previous CSS filters.)

Reviewed by Dean Jackson.

Tests: css3/filters/effect-reference-external.html

css3/filters/effect-reference-hw.html
css3/filters/effect-reference-ordering.html
css3/filters/effect-reference.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Add WebKitCSSSVGDocumentValue to the various build files.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::valueForFilter):
Use the reference filter's url when getting the computed style for
a reference filter.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFilter):
Create the referenceFilterValue's argument as a
WebKitCSSSVGDocumentValue instead of a CSS string.

  • css/CSSValue.cpp:

(WebCore::CSSValue::cssText):
Add support for WebKitCSSSVGDocumentValue.
(WebCore::CSSValue::destroy):
Add support for WebKitCSSSVGDocumentValue.

  • css/CSSValue.h:

(WebCore::CSSValue::isWebKitCSSSVGDocumentValue):
Add support for WebKitCSSSVGDocumentValue.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):
Keep track of pending SVG document references, and load them when
necessary.

  • css/StyleResolver.h:
  • css/WebKitCSSSVGDocumentValue.cpp: Added.

New CSSValue subclass for holding SVG document references.
(WebCore::WebKitCSSSVGDocumentValue::WebKitCSSSVGDocumentValue):
(WebCore::WebKitCSSSVGDocumentValue::~WebKitCSSSVGDocumentValue):
(WebCore::WebKitCSSSVGDocumentValue::load):
(WebCore::WebKitCSSSVGDocumentValue::customCssText):

  • css/WebKitCSSSVGDocumentValue.h: Added.

(WebCore::WebKitCSSSVGDocumentValue::create):
(WebCore::WebKitCSSSVGDocumentValue::cachedSVGDocument):
(WebCore::WebKitCSSSVGDocumentValue::url):
(WebCore::WebKitCSSSVGDocumentValue::loadRequested):

  • platform/graphics/GraphicsLayer.h:

Refactor PlatformLayer out into its own file, to avoid circular
includes.

  • platform/graphics/ImageBuffer.h:

Include PlatformLayer.h instead of GraphicsLayer.h.

  • platform/graphics/PlatformLayer.h: Added.

Refactor PlatformLayer out into its own file, to avoid circular
includes.

  • platform/graphics/filters/FilterOperation.h:

(WebCore::ReferenceFilterOperation::create):
(WebCore::ReferenceFilterOperation::clone):
(WebCore::ReferenceFilterOperation::url):
(WebCore::ReferenceFilterOperation::fragment):
(ReferenceFilterOperation):
(WebCore::ReferenceFilterOperation::data):
(WebCore::ReferenceFilterOperation::setData):
(WebCore::ReferenceFilterOperation::operator==):
(WebCore::ReferenceFilterOperation::ReferenceFilterOperation):
Augment ReferenceFilterOperation to maintain a data pointer,
in order to preserve context while loading external SVG documents.
Replace "reference" with "url" and "fragment" members, in order to
ease retrieval of the appropriate DOM objects.

  • platform/graphics/filters/FilterOperations.cpp:

(WebCore::FilterOperations::hasReferenceFilter):
Convenience function for finding reference filters.

  • platform/graphics/filters/FilterOperations.h:

(FilterOperations):

  • platform/mac/ScrollbarThemeMac.mm:

Include GraphicsLayer.h explicitly, since ImageBuffer.h no longer
includes it (and only includes PlatformLayer.h).

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::buildReferenceFilter):
Utility function to build a FilterEffect node graph for a
ReferenceFilterOperation.
(WebCore::FilterEffectRenderer::build):
Call the above builder function for ReferenceFilterOperations.

  • rendering/FilterEffectRenderer.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateOrRemoveFilterEffect):
If we have reference filters, update them along with other filters.
(WebCore::RenderLayer::filterNeedsRepaint):

  • rendering/RenderLayerFilterInfo.cpp:

(WebCore::RenderLayerFilterInfo::~RenderLayerFilterInfo):
(WebCore::RenderLayerFilterInfo::notifyFinished):
Implement callback function when external SVGDocuments are loaded.
(WebCore::RenderLayerFilterInfo::updateReferenceFilterClients):
Add the FilterInfo as a client to be called when SVGDocuments are
loaded.
(WebCore::RenderLayerFilterInfo::removeReferenceFilterClients):
Remove this from the list of notified clients.

  • rendering/RenderLayerFilterInfo.h:

Add new member vars for tracking internal and external SVG
references, so we can remove ourselves as a client when done.

  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::markAllClientsForInvalidation):
When marking client DOM nodes for repaint, also mark any RenderLayers
referring to this DOM tree via filters as needing repaint.
(WebCore::RenderSVGResourceContainer::addClientRenderLayer):
(WebCore::RenderSVGResourceContainer::removeClientRenderLayer):

  • rendering/svg/RenderSVGResourceContainer.h:

Maintain a list of RenderLayer clients on each SVG resource container,
and turn SVG DOM repaint notifications into filter repaint (CSS)
notifications.

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::buildPrimitives):
Construct a SourceGraphic and SourceAlpha node explicitly for the
SVG builder case.

  • svg/graphics/filters/SVGFilterBuilder.cpp:

(WebCore::SVGFilterBuilder::SVGFilterBuilder):

  • svg/graphics/filters/SVGFilterBuilder.h:

(WebCore::SVGFilterBuilder::create):
Add the SourceGraphic and SourceAlpha as parameters to the constructor
and create() methods, so they can be supplied by the caller.

LayoutTests: Add tests for the url() filter function.
https://bugs.webkit.org/show_bug.cgi?id=72443

Reviewed by Dean Jackson.

  • css3/filters/effect-reference-external.html: Added.
  • css3/filters/effect-reference-hw.html: Added.
  • css3/filters/effect-reference-ordering.html: Added.
  • css3/filters/effect-reference.html: Added.
  • css3/filters/resources/hueRotate.svg: Added.
  • platform/chromium-linux/css3/filters/effect-reference-expected.png: Added.
  • platform/chromium-linux/css3/filters/effect-reference-expected.txt: Added.
  • platform/chromium-linux/css3/filters/effect-reference-external-expected.png: Added.
  • platform/chromium-linux/css3/filters/effect-reference-external-expected.txt: Added.
  • platform/chromium-linux/css3/filters/effect-reference-hw-expected.png: Added.
  • platform/chromium-linux/css3/filters/effect-reference-hw-expected.txt: Added.
  • platform/chromium-linux/css3/filters/effect-reference-ordering-expected.png: Added.
  • platform/chromium-linux/css3/filters/effect-reference-ordering-expected.txt: Added.
  • platform/chromium/TestExpectations:
7:46 PM Changeset in webkit [121512] by dpranke@chromium.org
  • 7 edits
    2 deletes in trunk/Tools

nrwt: remove the 'google-chrome' port code
https://bugs.webkit.org/show_bug.cgi?id=88824

Reviewed by Ojan Vafai.

NRWT now supports passing additional baseline directories
and expectations files on the command line, so there's no need
to support the concept of a 'google-chrome' port directly.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.path_to_test_expectations_file):

  • Scripts/webkitpy/layout_tests/port/builders.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:

(ChromiumMacPort.init):

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:

(ChromiumWinPort.init):

  • Scripts/webkitpy/layout_tests/port/factory.py:

(PortFactory):

  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:

(FactoryTest.test_win):

  • Scripts/webkitpy/layout_tests/port/google_chrome.py: Removed.
  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py: Removed.
7:40 PM Changeset in webkit [121511] by fpizlo@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

DFG recompilation heuristics should be based on count, not rate
https://bugs.webkit.org/show_bug.cgi?id=90146

Reviewed by Oliver Hunt.

This removes a bunch of code that was previously trying to prevent spurious
reoptimizations if a large enough majority of executions of a code block did
not result in OSR exit. It turns out that this code was purely harmful. This
patch removes all of that logic and replaces it with a dead-simple
heuristic: if you exit more than N times (where N is an exponential function
of the number of times the code block has already been recompiled) then we
will recompile.

This appears to be a broad ~1% win on many benchmarks large and small.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::osrExitCounter):
(JSC::CodeBlock::countOSRExit):
(CodeBlock):
(JSC::CodeBlock::addressOfOSRExitCounter):
(JSC::CodeBlock::offsetOfOSRExitCounter):
(JSC::CodeBlock::adjustedExitCountThreshold):
(JSC::CodeBlock::exitCountThresholdForReoptimization):
(JSC::CodeBlock::exitCountThresholdForReoptimizationFromLoop):
(JSC::CodeBlock::shouldReoptimizeNow):
(JSC::CodeBlock::shouldReoptimizeFromLoopNow):

  • bytecode/ExecutionCounter.cpp:

(JSC::ExecutionCounter::setThreshold):

  • bytecode/ExecutionCounter.h:

(ExecutionCounter):
(JSC::ExecutionCounter::clippedThreshold):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileBody):

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::considerAddingAsFrequentExitSiteSlow):

  • dfg/DFGOSRExitCompiler.cpp:

(JSC::DFG::OSRExitCompiler::handleExitCounts):

  • dfg/DFGOperations.cpp:
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Options.cpp:

(Options):
(JSC::Options::initializeOptions):

  • runtime/Options.h:

(Options):

7:37 PM Changeset in webkit [121510] by bashi@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] CTFontCopyTable of MacOSX10.5 SDK doesn't work for layout tables
https://bugs.webkit.org/show_bug.cgi?id=90235

Reviewed by Kent Tamura.

Use CGFontCopyTableForTag instead.

No new tests. css3/font-feature-settings-rendering.html should pass. I'll rebase expectations once bots get the result.

  • platform/graphics/harfbuzz/ng/HarfBuzzFaceCoreText.cpp:

(WebCore::harfbuzzCoreTextGetTable):

7:37 PM Changeset in webkit [121509] by dpranke@chromium.org
  • 6 edits
    1 delete in trunk/Tools

nrwt: clean up how arguments are passed to workers
https://bugs.webkit.org/show_bug.cgi?id=90126

Reviewed by Ojan Vafai.

The way arguments are passed to workers has been crufty. It
turns out it can be a lot cleaner via two things:
1) using a factory method instead of instantiating objects
directly in manager_worker_broker removes the need for passing
'worker arguments' to the broker.
2) it turns out that since mock hosts and test ports are purely
in-memory constructions, they can be pickled and passed to child
workers, meaning that the worker no longer needs hacky code to
pass the port in a special case or to guess what to do if we
don't have a host - all of the test-specific logic can move to
the test file, where we can stub out the mock host's
port_factory to return the same already-created port when it
needs to be shared.

This change also moves WorkerException to manager_worker_broker.py
where it belongs, and removes several useless tests that were
just a maintenance burden (and would've needed rewriting when we
change the rest of the broker implementation).

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._run_tests.worker_factory):
(Manager._run_tests):

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:

(get):
(WorkerException):
(AbstractWorker.init):
(_ManagerConnection.init):
(_ManagerConnection.start_worker):
(_InlineManager.init):
(_InlineManager.start_worker):
(_MultiProcessManager._can_pickle_host):
(_MultiProcessManager):
(_MultiProcessManager.start_worker):
(_WorkerConnection.init):
(_InlineWorkerConnection.init):
(_InlineWorkerConnection.join):
(_InlineWorkerConnection.run):
(_Process.run):
(_MultiProcessWorkerConnection.init):
(_MultiProcessWorkerConnection.start):
(_MultiProcessWorkerConnection):
(_MultiProcessWorkerConnection.run):

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:

(_TestWorker.init):
(_TestWorker.run):
(_TestsMixin.test_name):
(_TestsMixin.test_cancel):
(_TestsMixin.test_done):
(_TestsMixin.test_unknown_message):
(InlineBrokerTests.setUp):
(MultiProcessBrokerTests.setUp):

  • Scripts/webkitpy/layout_tests/controllers/worker.py:

(Worker.init):
(Worker.run):

  • Scripts/webkitpy/layout_tests/controllers/worker_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(passing_run):
(logging_run):
(run_and_capture):
(MainTest.test_child_processes_2):
(MainTest.test_child_processes_min):
(MainTest.test_exception_raised):
(MainTest.test_keyboard_interrupt):
(MainTest.test_retrying_and_flaky_tests):
(MainTest.test_run_orderinline):

7:36 PM Changeset in webkit [121508] by pdr@google.com
  • 2 edits in trunk/Source/WebCore

Add preventative assert in SVGTRefElement
https://bugs.webkit.org/show_bug.cgi?id=90203

Reviewed by Abhishek Arya.

SVGTRefElement::detachTarget() adds a pending resource via addPendingResource.
Due to some recent bugs in this area, an assert is being added to prevent
users from calling detachTarget when not in a document. Doing
so would create a bug such as in WK90042.

This assert will not fire currently because detachTarget is only called after
a DOMNodeRemovedFromDocumentEvent event fires, which only comes from
dispatchChildRemovalEvents when the node is in a document.

  • svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::detachTarget):

7:13 PM Changeset in webkit [121507] by dpranke@chromium.org
  • 3 edits in trunk/Tools

nrwt: don't try to catch worker exceptions in run_webkit_tests.main
https://bugs.webkit.org/show_bug.cgi?id=90125

Reviewed by Ojan Vafai.

It turns out run_webkit_tests.py wasn't really using
WorkerException and the catch we had for it was pointless. I've
removed the symbol import and moved it to the integration tests
where it is needed. Eventually the definition of the exception
moves to the broker module, and so minimizing the number of
users of it is a good thing.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_exception_raised):

7:09 PM Changeset in webkit [121506] by mikelawther@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed gardening.

Mark css3/calc/transitions.html flaky (http://webkit.org/b/90234)

  • platform/chromium/TestExpectations:
  • platform/mac/TestExpectations:
6:59 PM Changeset in webkit [121505] by dpranke@chromium.org
  • 4 edits in trunk/Tools

nrwt: clean up passing of log messages between processes
https://bugs.webkit.org/show_bug.cgi?id=90123

Reviewed by Ojan Vafai.

It turns out log messages are perfectly picklable by themselves
and contain the process id of the process that generated the
message, so if we just pass the record from the worker to the
manager and call logger.handle() in the manager, everything just
works :).

The change is covered by existing tests.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._log_messages):

  • Scripts/webkitpy/layout_tests/controllers/worker.py:

(_WorkerLogHandler.emit):

  • Scripts/webkitpy/layout_tests/views/metered_stream.py:

(MeteredStream.init):
(_LogHandler.emit):

6:56 PM Changeset in webkit [121504] by wsiegrist@apple.com
  • 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/buildbot.tac

Make sure master umask is set correctly

6:45 PM Changeset in webkit [121503] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

[Qt] Remove unnecessary AffineTransform calls
https://bugs.webkit.org/show_bug.cgi?id=90178

Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2012-06-28
Reviewed by Noam Rosenthal.

Qt currently ignores the const AffineTransform& parameter on
Pattern::createPlatformPattern, so removing it from all its Qt calls and
changing the function signature if platform is Qt.

  • platform/graphics/Pattern.h:

(Pattern):

  • platform/graphics/qt/FontQt.cpp:

(WebCore::fillPenForContext):
(WebCore::strokePenForContext):

  • platform/graphics/qt/FontQt4.cpp:

(WebCore::fillPenForContext):
(WebCore::strokePenForContext):

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::drawRepeatPattern):

  • platform/graphics/qt/PatternQt.cpp:

(WebCore::Pattern::createPlatformPattern):

6:45 PM Changeset in webkit [121502] by dpranke@chromium.org
  • 2 edits
    2 adds in trunk/Tools

add a pylint wrapper for linting python code
https://bugs.webkit.org/show_bug.cgi?id=90232

Reviewed by Adam Barth.

Currently we use 'pep8' to check python code in
check-webkit-style. pep8 is fast but simple; pylint is slower
but has much more robust linting capabilities and will catch
variable typos and all sorts of other things. Eventually we
should switch check-webkit-style to use this, but our code is
far from linting now so it needs to be cleaned up first.

This change adds the infrastructure and a wrapper so we can
start doing that.

  • Scripts/lint-webkitpy: Added.
  • Scripts/webkitpy/pylintrc: Added.
  • Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook.find_module):
(AutoinstallImportHook._install_pylint):

6:42 PM Changeset in webkit [121501] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebCore

[Qt] When uploading an opaque image to a texture for TextureMapper, unnecessary alpha operations take place
https://bugs.webkit.org/show_bug.cgi?id=90229

Reviewed by Luiz Agostini.

For opaque web content in WebKit2, we use the RGB32 image format. When we special-case
it in GraphicsContext3DQt, we can avoid any alpha operations and perform a regular copy.

Covered existing API tests, as this code path is always used when rendering.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::getImageData):

6:30 PM Changeset in webkit [121500] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

[chromium] Compile chromium compositor implementation files into separate .lib
https://bugs.webkit.org/show_bug.cgi?id=90233

Reviewed by Adam Barth.

  • WebCore.gyp/WebCore.gyp:
6:18 PM Changeset in webkit [121499] by tony@chromium.org
  • 4 edits in trunk/Tools

[GTK] Use WEBKITOUTPUTDIR to find fonts in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=90215

Reviewed by Martin Robinson.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(initializeFonts): Check for WEBKITOUTPUTDIR first.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort.setup_environ_for_server): Copy the environment variable to the child process.

  • WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:

(WTR::inititializeFontConfigSetting): Check for WEBKITOUTPUTDIR first.

6:18 PM Changeset in webkit [121498] by wsiegrist@apple.com
  • 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg

Switch master ditto command to unzip since the new master does not have ditto.

6:14 PM Changeset in webkit [121497] by dpranke@chromium.org
  • 19 edits
    1 copy in trunk/Tools

derive ChromiumPort from WebKitPort in NRWT in order to support skipping tests if symbols are missing
https://bugs.webkit.org/show_bug.cgi?id=89706

Reviewed by Ojan Vafai.

Try again to land the change first landed in r121363. This patch
adds a bunch more tests and reworks the handling of
port-specific default values for --pixel-tests and --time-out-ms
to be more consistent (adding a default_pixel_tests() method,
pushing the webkit default_timeout_ms() value up into base.py,
and overriding it properly in the chromium and apple mac ports.

Also change the logic in
run_webkit_tests._setup_derived_options() to not second-guess
what the port wants the timeout value to be for debug builds;
computing this in two different places led to several bugs.

This change also changes the Chromium unittest ports to derive
from ChromiumPortTestCase instead of PortTestCase, so that we
ensure that we're running the same tests on all port variants
more easily. There's more cleanup that can be done here, but
this is good enough for now

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.default_pixel_tests):
(Port):
(Port.default_timeout_ms):

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort):
(ChromiumPort.init):
(ChromiumPort.default_pixel_tests):
(ChromiumPort.default_timeout_ms):
(ChromiumPort.driver_name):
(ChromiumPort._driver_class):
(ChromiumPort._missing_symbol_to_skipped_tests):
(ChromiumPort.skipped_layout_tests):
(ChromiumPort.setup_test_run):
(ChromiumPort._path_to_image_diff):
(ChromiumPort._convert_path):

  • Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:

(ChromiumAndroidPortTest):
(ChromiumAndroidPortTest.test_expectations_files):

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:

(ChromiumLinuxPort._modules_to_search_for_symbols):

  • Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:

(ChromiumLinuxPortTest):

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:

(ChromiumMacPort._modules_to_search_for_symbols):

  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:

(ChromiumMacPortTest):

  • Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:

split off from chromium_unittest.

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:

(ChromiumWinPort._modules_to_search_for_symbols):

  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:

(ChromiumWinTest):

  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.default_timeout_ms):

  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:

(MacTest.test_default_timeout_ms):

  • Scripts/webkitpy/layout_tests/port/mock_drt.py:

(MockDRTPort.start_http_server):

  • Scripts/webkitpy/layout_tests/port/port_testcase.py:

(PortTestCase.test_default_timeout_ms):
(PortTestCase):
(PortTestCase.test_default_pixel_tests):

  • Scripts/webkitpy/layout_tests/port/test.py:

(TestPort.default_pixel_tests):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._modules_to_search_for_symbols):
(WebKitPort):
(WebKitPort._symbols_string):
(WebKitPort._skipped_tests_for_unsupported_features):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(TestWebKitPort._symbols_string):
(TestWebKitPort._tests_for_disabled_features):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(_set_up_derived_options):

6:13 PM Changeset in webkit [121496] by arv@chromium.org
  • 4 edits
    3 adds in trunk

[V8] NodeList wrappers are not kept alive as needed
https://bugs.webkit.org/show_bug.cgi?id=90194

Reviewed by Ojan Vafai.

Source/WebCore:

We need to add custom reachability code for DynamicNodeLists. If the owner of
a DynamicNodeList is reachable then the DynamicNodeList must also be reachable.

Test: fast/dom/NodeList/nodelist-reachable.html

  • bindings/v8/custom/V8NodeListCustom.cpp:

(WebCore::V8NodeList::visitDOMWrapper): AddImplicitReferences from the owner wrapper.
(WebCore):

  • dom/NodeList.idl:

LayoutTests:

  • fast/dom/NodeList/nodelist-reachable-expected.txt: Added.
  • fast/dom/NodeList/nodelist-reachable.html: Added.
  • platform/chromium/fast/dom/NodeList/nodelist-reachable-expected.txt: Added.
5:59 PM Changeset in webkit [121495] by hayato@chromium.org
  • 3 edits in trunk/LayoutTests

Add a test for a 'user-modify' css property of distributed nodes.
https://bugs.webkit.org/show_bug.cgi?id=90197

Reviewed by Ryosuke Niwa.

  • fast/dom/shadow/user-modify-inheritance-expected.txt:
  • fast/dom/shadow/user-modify-inheritance.html:
5:55 PM Changeset in webkit [121494] by commit-queue@webkit.org
  • 4 edits
    6 adds in trunk

frameborder="no" on frameset is ignored if border attribute set
https://bugs.webkit.org/show_bug.cgi?id=17767

Patch by Elliott Sprehn <Elliott Sprehn> on 2012-06-28
Reviewed by Tony Chang.

Source/WebCore:

Fixes <frameset> frameborder and border handling. Previously we'd
override the frameborder=no setting if border was set. We also
treated frameborder="anything" the same as frameborder=0 since we
we just converted it to a number so frameborder=yes was incorrectly
treated the same as frameborder=no.

Tests: fast/frames/frameset-frameborder-boolean-values.html

fast/frames/frameset-frameborder-inheritance.html
fast/frames/frameset-frameborder-overrides-border.html

  • html/HTMLFrameSetElement.cpp: Proper parsing of yes,no,1,0 values.

(WebCore::HTMLFrameSetElement::parseAttribute):

  • html/HTMLFrameSetElement.h:

(WebCore::HTMLFrameSetElement::border): Border should be 0 if frameborder=no.

LayoutTests:

Add lots of tests for <frameset> frameborder and border handling.

  • fast/frames/frameset-frameborder-boolean-values-expected.txt: Added.
  • fast/frames/frameset-frameborder-boolean-values.html: Added.
  • fast/frames/frameset-frameborder-inheritance-expected.txt: Added.
  • fast/frames/frameset-frameborder-inheritance.html: Added.
  • fast/frames/frameset-frameborder-overrides-border-expected.txt: Added.
  • fast/frames/frameset-frameborder-overrides-border.html: Added.
5:47 PM Changeset in webkit [121493] by jsbell@chromium.org
  • 2 edits in trunk/Tools

run-bindings-tests should return non-zero exit code on test failure
https://bugs.webkit.org/show_bug.cgi?id=90205

Reviewed by Adam Barth.

  • Scripts/run-bindings-tests:

(main):

5:38 PM Changeset in webkit [121492] by jsbell@chromium.org
  • 20 edits
    7 moves
    3 adds in trunk

IndexedDB: Implement IDBTransaction internal active flag
https://bugs.webkit.org/show_bug.cgi?id=89379

Reviewed by Tony Chang.

Source/WebCore:

IDB transactions should only be "active" during IDB success/error callbacks;
attempts to make new requests otherwise (e.g. in a setTimeout callback)
should fail even if the transaction has not yet finished. Implement this logic,
and the closely related requirement that transactions are deactivated when
the context they were created in returns to the event loop, and finally that
when so deactivated they should commit rather than abort (as previously
implemented) if no requests have been filed.

Tests: storage/indexeddb/transaction-active-flag.html

storage/indexeddb/transaction-complete-with-js-recursion-cross-frame.html
storage/indexeddb/transaction-complete-with-js-recursion.html
storage/indexeddb/transaction-complete-workers.html

  • Modules/indexeddb/IDBPendingTransactionMonitor.cpp: Simplify API.

(WebCore::transactions):
(WebCore::IDBPendingTransactionMonitor::addNewTransaction):
(WebCore::IDBPendingTransactionMonitor::deactivateNewTransactions):

  • Modules/indexeddb/IDBPendingTransactionMonitor.h:

(WebCore):
(IDBPendingTransactionMonitor):

  • Modules/indexeddb/IDBRequest.cpp: Unregisters from transaction when done,

not on destruction. No longer responsible for working with the pending monitor.
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::~IDBRequest):
(WebCore::IDBRequest::markEarlyDeath):
(WebCore::IDBRequest::resetReadyState):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::dispatchEvent): Set active flag on transaction during callback.

  • Modules/indexeddb/IDBTransaction.cpp: Use state enum to better track lifecycle, and

take ownership of relationship with pending monitor.
(WebCore::IDBTransaction::IDBTransaction): Special cases for version change
transactions.
(WebCore::IDBTransaction::~IDBTransaction):
(WebCore::IDBTransaction::error):
(WebCore::IDBTransaction::setError):
(WebCore::IDBTransaction::objectStore):
(WebCore::IDBTransaction::objectStoreCreated):
(WebCore::IDBTransaction::objectStoreDeleted):
(WebCore::IDBTransaction::setActive): Let IDBRequest and IDBPendingTransactionMonitor
toggle the active state. Needs some smarts because (1) state may move to Finishing during
the request's dispatch phase due to an implicit/explicit abort, and (2) a monitor call
will only trigger a commit if the transaction hasn't had any requests filed.
(WebCore):
(WebCore::IDBTransaction::abort):
(WebCore::IDBTransaction::registerRequest):
(WebCore::IDBTransaction::unregisterRequest):
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):
(WebCore::IDBTransaction::hasPendingActivity):
(WebCore::IDBTransaction::dispatchEvent):
(WebCore::IDBTransaction::canSuspend):
(WebCore::IDBTransaction::enqueueEvent):

  • Modules/indexeddb/IDBTransaction.h:

(WebCore::IDBTransaction::isFinished):
(IDBTransaction):

  • Modules/indexeddb/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::commit): Allow explicit commit() calls from the front end
if no requests have been filed.

  • Modules/indexeddb/IDBTransactionBackendInterface.h:

(IDBTransactionBackendInterface): Expose commit() method.

  • bindings/js/JSMainThreadExecState.cpp:

(WebCore::JSMainThreadExecState::didLeaveScriptContext): Change target function name.

  • bindings/v8/V8RecursionScope.cpp:

(WebCore::V8RecursionScope::didLeaveScriptContext): Change target function name.

Source/WebKit/chromium:

To match the IDB spec, transactions that have had no requests
filed against them should commit, not abort. This requires plumbing
through the commit() call from front-end to back-end.

  • src/IDBTransactionBackendProxy.cpp:

(WebKit::IDBTransactionBackendProxy::commit):
(WebKit):

  • src/IDBTransactionBackendProxy.h:

(IDBTransactionBackendProxy):

  • src/WebIDBTransactionImpl.cpp:

(WebKit::WebIDBTransactionImpl::commit):
(WebKit):

  • src/WebIDBTransactionImpl.h:

LayoutTests:

  • storage/indexeddb/resources/transaction-active-flag.js: Added.
  • storage/indexeddb/resources/transaction-basics.js:

(completeCallback): Empty transactions now commit rather than abort.
(emptyCompleteCallback):

  • storage/indexeddb/resources/transaction-complete-workers.js: Renamed from LayoutTests/storage/indexeddb/resources/transaction-abort-workers.js.
  • storage/indexeddb/structured-clone.html: Assumed empty transactions aborted.
  • storage/indexeddb/transaction-active-flag-expected.txt: Added.
  • storage/indexeddb/transaction-active-flag.html: Added.
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-complete-with-js-recursion-cross-frame-expected.txt: Renamed from LayoutTests/storage/indexeddb/transaction-abort-with-js-recursion-cross-frame-expected.txt.
  • storage/indexeddb/transaction-complete-with-js-recursion-cross-frame.html: Renamed from LayoutTests/storage/indexeddb/transaction-abort-with-js-recursion-cross-frame.html.
  • storage/indexeddb/transaction-complete-with-js-recursion-expected.txt: Renamed from LayoutTests/storage/indexeddb/transaction-abort-with-js-recursion-expected.txt.
  • storage/indexeddb/transaction-complete-with-js-recursion.html: Renamed from LayoutTests/storage/indexeddb/transaction-abort-with-js-recursion.html.
  • storage/indexeddb/transaction-complete-workers-expected.txt: Renamed from LayoutTests/storage/indexeddb/transaction-abort-workers-expected.txt.
  • storage/indexeddb/transaction-complete-workers.html: Renamed from LayoutTests/storage/indexeddb/transaction-abort-workers.html.
  • storage/indexeddb/tutorial.html: Assumed empty transactions aborted.
5:13 PM Changeset in webkit [121491] by pdr@google.com
  • 3 edits
    2 adds in trunk

Prevent crash in animate resource handling
https://bugs.webkit.org/show_bug.cgi?id=90042

Reviewed by Abhishek Arya.

Source/WebCore:

This patch adds a check that we are in a document before registering animation
resources and creating a target element in SVGSMILElement. This prevents a crash where
we would register resources and create the target when we were not in a document
but fail to deregister / reset the target when we were removed from a document.
In failing to reset the target, we can crash when trying to deregister resources that
were not created after being inserted into a document and then removed.

The existence of m_targetResources and registered animation resources is now
tied to being in a document.

Test: svg/custom/animate-reference-crash.html

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::targetElement):

LayoutTests:

  • svg/custom/animate-reference-crash-expected.txt: Added.
  • svg/custom/animate-reference-crash.html: Added.
5:06 PM Changeset in webkit [121490] by wsiegrist@apple.com
  • 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/buildbot.tac

Update buildbot config for new hardware.

5:01 PM Changeset in webkit [121489] by abarth@webkit.org
  • 2 edits in trunk/Tools

[chromium] Reset the device scale factor to 1 before each test is run
https://bugs.webkit.org/show_bug.cgi?id=90212

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-06-28
Reviewed by Adam Barth.

Some tests change the device scale factor, so this needs to be reset to
1.0 at the start of each test to avoid test flakiness.

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::reset):

4:48 PM Changeset in webkit [121488] by jsbell@chromium.org
  • 3 edits
    3 adds in trunk

IndexedDB: IDBDatabase should have a close pending field.
https://bugs.webkit.org/show_bug.cgi?id=71129

Reviewed by Tony Chang.

Source/WebCore:

Handle the IDB spec case that "versionchange" events should not be fired
against connections that have the internal "closePending" flag set but
are not yet closed due to running transactions.

Test: storage/indexeddb/database-closepending-flag.html

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::onVersionChange):

LayoutTests:

  • storage/indexeddb/database-closepending-flag-expected.txt: Added.
  • storage/indexeddb/database-closepending-flag.html: Added.
  • storage/indexeddb/resources/database-closepending-flag.js: Added.

(test):
(openConnection.request.onsuccess.request.onsuccess):
(openConnection.request.onsuccess):
(openConnection):
(testIDBDatabaseName):
(testIDBDatabaseObjectStoreNames.request.onsuccess.request.onsuccess.transaction.oncomplete):
(testIDBDatabaseObjectStoreNames.request.onsuccess.request.onsuccess):
(testIDBDatabaseObjectStoreNames.request.onsuccess):
(testIDBDatabaseObjectStoreNames):
(testIDBDatabaseTransaction):
(testVersionChangeTransactionSteps.request.onsuccess.request.onsuccess.request.onblocked):
(testVersionChangeTransactionSteps.request.onsuccess.request.onsuccess.request.onsuccess.transaction.oncomplete):
(testVersionChangeTransactionSteps.request.onsuccess.request.onsuccess.request.onsuccess):
(testVersionChangeTransactionSteps.request.onsuccess.request.onsuccess):
(testDatabaseDeletion.request.onsuccess.request.onblocked):
(testDatabaseDeletion.request.onsuccess.request.onsuccess):

4:38 PM Changeset in webkit [121487] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Replace a BUG_OJAN with a proper tracking bug and unskip two
tests in preparation for rebaselining them.

  • platform/chromium/TestExpectations:
4:27 PM Changeset in webkit [121486] by enne@google.com
  • 11 edits
    1 copy
    1 move
    1 add
    3 deletes in trunk/Source

[chromium] Split WebScrollbar into WebPluginScrollbar and WebScrollbar
https://bugs.webkit.org/show_bug.cgi?id=90117

Reviewed by James Robinson.

Source/Platform:

Move WebScrollbar from client API to Platform.

  • Platform.gypi:
  • chromium/public/WebScrollbar.h: Copied from Source/WebKit/chromium/public/WebPluginScrollbarClient.h.

(WebKit):
(WebScrollbar):
(WebKit::WebScrollbar::~WebScrollbar):

Source/WebCore:

Make WebCore also depend on Platform.

  • WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

Convert WebScrollbar/WebScrollbarClient/WebScrollbarImpl to be
WebPluginScrollbar, WebPluginScrollbarClient, and
WebPluginScrollbarImpl. Modify ScrollbarGroup
to use this instead.

WebScrollbar is now the base interface for a pre-existing scrollbar
that is accessed in a const manner. It also provides all of the common
WebKit ScrollTypes.h enums. WebPluginScrollbar is now a scrollbar that
has been externally created and is externally modified in terms of its
position, invalidation, and painting.

This is a pre-refactoring for adding Web versions of ScrollbarTheme
into the Platform directory which will operate on WebScrollbar, but
that don't need all of what WebPluginScrollbar provides.

As WebScrollbar is moved to Platform, WebKit.gyp now must depend on
Platform as well.

  • WebKit.gyp:
  • public/WebPluginScrollbar.h:

(WebKit):
(WebPluginScrollbar):
(WebKit::WebPluginScrollbar::~WebPluginScrollbar):

  • public/WebPluginScrollbarClient.h:

(WebKit):
(WebPluginScrollbarClient):

  • public/WebScrollbar.h: Removed.
  • public/WebScrollbarClient.h: Removed.
  • src/AssertMatchingEnums.cpp:
  • src/ScrollbarGroup.cpp:

(WebKit::ScrollbarGroup::scrollbarCreated):
(WebKit::ScrollbarGroup::scrollbarDestroyed):
(WebKit::ScrollbarGroup::scrollSize):
(WebKit::ScrollbarGroup::scrollPosition):
(WebKit::ScrollbarGroup::contentsSize):

  • src/ScrollbarGroup.h:

(WebKit):
(ScrollbarGroup):

  • src/WebPluginScrollbarImpl.cpp: Renamed from Source/WebKit/chromium/src/WebScrollbarImpl.cpp.

(WebKit):
(WebKit::WebPluginScrollbar::createForPlugin):
(WebKit::WebPluginScrollbar::defaultThickness):
(WebKit::WebPluginScrollbarImpl::WebPluginScrollbarImpl):
(WebKit::WebPluginScrollbarImpl::~WebPluginScrollbarImpl):
(WebKit::WebPluginScrollbarImpl::setScrollOffset):
(WebKit::WebPluginScrollbarImpl::invalidateScrollbarRect):
(WebKit::WebPluginScrollbarImpl::getTickmarks):
(WebKit::WebPluginScrollbarImpl::convertFromContainingViewToScrollbar):
(WebKit::WebPluginScrollbarImpl::scrollbarStyleChanged):
(WebKit::WebPluginScrollbarImpl::isOverlay):
(WebKit::WebPluginScrollbarImpl::value):
(WebKit::WebPluginScrollbarImpl::setLocation):
(WebKit::WebPluginScrollbarImpl::setValue):
(WebKit::WebPluginScrollbarImpl::setDocumentSize):
(WebKit::WebPluginScrollbarImpl::scroll):
(WebKit::WebPluginScrollbarImpl::paint):
(WebKit::WebPluginScrollbarImpl::handleInputEvent):
(WebKit::WebPluginScrollbarImpl::onMouseDown):
(WebKit::WebPluginScrollbarImpl::onMouseUp):
(WebKit::WebPluginScrollbarImpl::onMouseMove):
(WebKit::WebPluginScrollbarImpl::onMouseLeave):
(WebKit::WebPluginScrollbarImpl::onMouseWheel):
(WebKit::WebPluginScrollbarImpl::onKeyDown):

  • src/WebPluginScrollbarImpl.h: Added.

(WebCore):
(WebKit):
(WebPluginScrollbarImpl):
(WebKit::WebPluginScrollbarImpl::scrollOffset):
(WebKit::WebPluginScrollbarImpl::scrollbar):

  • src/WebScrollbarImpl.h: Removed.
4:25 PM Changeset in webkit [121485] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Mark a test as failing on Linux debug

fast/forms/select/select-state-restore.html is failing on Linux debug because of timeout.

Not reviewed.

  • platform/chromium/TestExpectations:
4:21 PM Changeset in webkit [121484] by ojan@chromium.org
  • 14 edits
    1 copy
    1 move in trunk/LayoutTests

Rebaselines after http://trac.webkit.org/changeset/119507.
These were all done using "webkit-patch rebaseline-expectations".

  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug131020-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug131020-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug131020-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug131020-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug131020-expected.png:
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/efl/tables/mozilla/bugs/bug131020-expected.txt: Copied from LayoutTests/tables/mozilla/bugs/bug131020-expected.txt.
  • platform/gtk/TestExpectations:
  • platform/gtk/tables/mozilla/bugs/bug131020-expected.txt: Renamed from LayoutTests/tables/mozilla/bugs/bug131020-expected.txt.
  • platform/mac/TestExpectations:
  • platform/mac/tables/mozilla/bugs/bug131020-expected.txt:
  • platform/qt/TestExpectations:
  • platform/qt/tables/mozilla/bugs/bug131020-expected.txt:
  • platform/win/TestExpectations:
4:20 PM Changeset in webkit [121483] by abarth@webkit.org
  • 3 edits
    1 add in trunk/Source/WebKit/chromium

[Chromium] On Android, we should be able to ask the embedder what intents exist in a region of the page
https://bugs.webkit.org/show_bug.cgi?id=90210

Reviewed by Dimitri Glazkov.

This patch introduces a function that asks the embedder to analyze the
region around a hit test result for interesting content, like phone
numbers, email addresses, or physical addresses. The embedder then
responds with the "most interesting" content, together with an intent
URL for enacting the intent embodied by that content.

This function will be used in a subsequent patch to detect content
after touch events.

  • WebKit.gyp:
  • public/WebContentDetectionResult.h: Added.

(WebKit):
(WebContentDetectionResult):
(WebKit::WebContentDetectionResult::WebContentDetectionResult):
(WebKit::WebContentDetectionResult::isValid):
(WebKit::WebContentDetectionResult::range):
(WebKit::WebContentDetectionResult::string):
(WebKit::WebContentDetectionResult::intent):

  • public/WebViewClient.h:

(WebViewClient):
(WebKit::WebViewClient::detechContentAround):

4:12 PM Changeset in webkit [121482] by sullivan@apple.com
  • 4 edits in trunk/Source/WebKit2

<https://bugs.webkit.org/show_bug.cgi?id=90216>
<rdar://problem/11766518>
Undo handling in WebKit2 is not robust against some page-closing code paths

Reviewed by Enrica Casucci.

  • UIProcess/API/mac/PageClientImpl.h:

Declared public function viewWillMoveToAnotherWindow().

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::viewWillMoveToAnotherWindow):
New function, calls clearAllEditCommands() to remove any Undo actions from the stack.
This guarantees that no Undo actions will be abandoned when the PageClientImpl is dealloc'ed.

  • UIProcess/API/mac/WKView.mm:

(-[WKView viewWillMoveToWindow:]):
Now informs PageClientImpl via new function PageClientImpl::viewWillMoveToAnotherWindow().

4:05 PM Changeset in webkit [121481] by hayato@chromium.org
  • 5 edits in trunk

CompositeShadowTreeWalker should use InsertionPoint::hasDistribution() instead of InsertionPoint::isActive().
https://bugs.webkit.org/show_bug.cgi?id=89177

Reviewed by Dimitri Glazkov.

Source/WebCore:

Prevents ComposedShadowTreeWalker from escaping out of an
insertion point (which has distributed nodes) from a non-used
fallback element in the insertion point. Such a fallback element
should be treated as in an orphaned subtree.

ComposedShadowTreeParentWalker will be also fixed in a follow-up patch.

Test: fast/dom/shadow/composed-shadow-tree-walker.html

  • dom/ComposedShadowTreeWalker.cpp:

(WebCore::ComposedShadowTreeWalker::traverseNodeEscapingFallbackContents):

LayoutTests:

  • fast/dom/shadow/composed-shadow-tree-walker-expected.txt:
  • fast/dom/shadow/composed-shadow-tree-walker.html:
4:03 PM Changeset in webkit [121480] by commit-queue@webkit.org
  • 8 edits
    1 add in trunk/Source/JavaScriptCore

Adding a commenting utility to record BytecodeGenerator comments
with opcodes that are emitted. Presently, the comments can only
be constant strings. Adding comments for opcodes is optional.
If a comment is added, the comment will be printed following the
opcode when CodeBlock::dump() is called.

This utility is disabled by default, and is only meant for VM
development purposes. It should not be enabled for product builds.

To enable this utility, set ENABLE_BYTECODE_COMMENTS in CodeBlock.h
to 1.

https://bugs.webkit.org/show_bug.cgi?id=90095

Patch by Mark Lam <mark.lam@apple.com> on 2012-06-28
Reviewed by Geoffrey Garen.

  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecodeCommentAndNewLine): Dumps the comment.
(JSC):
(JSC::CodeBlock::printUnaryOp): Add comment dumps.
(JSC::CodeBlock::printBinaryOp): Add comment dumps.
(JSC::CodeBlock::printConditionalJump): Add comment dumps.
(JSC::CodeBlock::printCallOp): Add comment dumps.
(JSC::CodeBlock::printPutByIdOp): Add comment dumps.
(JSC::CodeBlock::dump): Add comment dumps.
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::commentForBytecodeOffset):

Finds the comment for an opcode if available.

(JSC::CodeBlock::dumpBytecodeComments):

For debugging whether comments are collected.
It is not being called anywhere.

  • bytecode/CodeBlock.h:

(CodeBlock):
(JSC::CodeBlock::bytecodeComments):

  • bytecode/Comment.h: Added.

(JSC):
(Comment):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitOpcode): Calls emitComment().
(JSC):
(JSC::BytecodeGenerator::emitComment): Adds comment to CodeBlock.
(JSC::BytecodeGenerator::prependComment):

Registers a comment for emitComemnt() to use later.

  • bytecompiler/BytecodeGenerator.h:

(BytecodeGenerator):
(JSC::BytecodeGenerator::emitComment):
(JSC::BytecodeGenerator::prependComment):

These are inlined versions of these functions that nullify them
when ENABLE_BYTECODE_COMMENTS is 0.

(JSC::BytecodeGenerator::comments):

4:02 PM Changeset in webkit [121479] by rniwa@webkit.org
  • 1 edit in trunk/Source/WebCore/ChangeLog

Fix a typo in the change log per review comment.

4:01 PM Changeset in webkit [121478] by rniwa@webkit.org
  • 5 edits
    2 adds in trunk

Cleanup HTMLFormCollection
https://bugs.webkit.org/show_bug.cgi?id=90111

Reviewed by Andreas Kling.

Source/WebCore:

Got rid of getNamedItem and enamed getNamedFormItem to firstNamedItem and got rid of duplicateNumber argument since
it's always 0. Also made it a static local function. In addition, removed nextItem() since it's not used anywhere.

WebKit API Test: WebKit1.HTMLFormCollectionNamedItemTest

  • html/HTMLFormCollection.cpp:

(WebCore::firstNamedItem):
(WebCore):
(WebCore::HTMLFormCollection::namedItem):

  • html/HTMLFormCollection.h:

(HTMLFormCollection):

Tools:

Add a WebKit API test using copy-paste design pattern per kling's request.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.html: Added.
  • TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm: Added.

(-[HTMLFormCollectionNamedItemTest webView:didFinishLoadForFrame:]):
(TestWebKitAPI):
(TestWebKitAPI::TEST):

3:57 PM Changeset in webkit [121477] by commit-queue@webkit.org
  • 12 edits in trunk/Source

IndexedDB: Hook up render-side key ASSERTing for get()
https://bugs.webkit.org/show_bug.cgi?id=90001

Patch by Alec Flett <alecflett@chromium.org> on 2012-06-28
Reviewed by Tony Chang.

Source/WebCore:

Hook up the new onSuccess and add it to the interface. For now,
simply assert that the right value is set. Add the same assertion
logic in the value-construction logic when the cursor advances.

No new tests, existing tests verify this refactor is correct.

  • Modules/indexeddb/IDBCallbacks.h:

(IDBCallbacks):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::getInternal):

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore):
(WebCore::IDBRequest::onSuccess):

  • Modules/indexeddb/IDBRequest.h:
  • bindings/v8/IDBBindingUtilities.cpp:

(WebCore::createIDBKeyFromSerializedValueAndKeyPath):

  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):

Source/WebKit/chromium:

Hook up Chromium WebKit API to new onSuccess handler.

  • src/WebIDBCallbacksImpl.cpp:

(WebKit::WebIDBCallbacksImpl::onSuccess):

  • tests/IDBAbortOnCorruptTest.cpp:

(WebCore::MockIDBCallbacks::onSuccess):

  • tests/IDBDatabaseBackendTest.cpp:
3:45 PM Changeset in webkit [121476] by timothy_horton@apple.com
  • 2 edits in trunk/Tools

[mac] WKTR windows still don't stay off screen sometimes
https://bugs.webkit.org/show_bug.cgi?id=90214
<rdar://problem/11760263>

Reviewed by Simon Fraser.

In some cases, the system itself will consult [WebKitTestRunnerWindow frame], so we should refrain from
overriding it and instead provide a different method to use when we want the web-facing "fake" window origin
(for PlatformWebView::windowFrame()).

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
(WTR::PlatformWebView::windowFrame):

3:41 PM NewRunWebKitTests edited by rafael.lobo@openbossa.org
Adding a tip about how to put expected results into a given platform path. (diff)
3:34 PM Changeset in webkit [121475] by Martin Robinson
  • 4 edits
    2 adds in trunk/Tools

[GTK] Add unit tests for GtkInputMethodFilter
https://bugs.webkit.org/show_bug.cgi?id=88698

Reviewed by Carlos Garcia Campos.

Add unit tests for GtkInputMethodFilter in the WebCore platform layer.
This change adds the TestGtk test suite which will be used for all non-API
layer GTK unit tests.

  • TestWebKitAPI/GNUmakefile.am: Update the build to include the new tests.
  • TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp: Added.

(TestWebKitAPI::PlatformWebView::PlatformWebView): Remove the call to gtk_init here
as it's now in main.cpp.

  • TestWebKitAPI/gtk/main.cpp: Change the g_type_init call to gtk_init, because now

a majority of all unit tests depend on GTK+ being initialized.

2:55 PM Changeset in webkit [121474] by commit-queue@webkit.org
  • 7 edits in trunk

Add support for DEPTH_STENCIL to WEBGL_depth_texture
https://bugs.webkit.org/show_bug.cgi?id=90109

Patch by Gregg Tavares <gman@google.com> on 2012-06-28
Reviewed by Kenneth Russell.

Source/WebCore:

  • html/canvas/WebGLDepthTexture.idl:
  • html/canvas/WebGLFramebuffer.cpp:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::validateTexFuncFormatAndType):

LayoutTests:

  • fast/canvas/webgl/webgl-depth-texture-expected.txt:
  • fast/canvas/webgl/webgl-depth-texture.html:
2:51 PM Changeset in webkit [121473] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[chromium] Move chromium compositor implementation files into separate section in WebCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=90201

Patch by James Robinson <jamesr@chromium.org> on 2012-06-28
Reviewed by Adam Barth.

This moves the chromium compositor implementation files to a separate gyp variable to make future changes
easier. The files still all link into webcore_platform.lib, as before.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
2:43 PM Changeset in webkit [121472] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-28

  • DEPS:
2:30 PM Changeset in webkit [121471] by schenney@chromium.org
  • 2 edits
    8 adds in trunk/LayoutTests

[chromium] rebaseline svg text layouts?
https://bugs.webkit.org/show_bug.cgi?id=89936

Unreviewed Chromium test expectations update.

The SVG tests for this bug all seem OK, so they are being rebaselined.
The other content is less clear, so it is being left for an expert.

  • platform/chromium-win-xp/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Added.
  • platform/chromium-win-xp/svg/custom/js-late-gradient-and-object-creation-expected.png: Added.
  • platform/chromium-win-xp/svg/text/text-intro-05-t-expected.txt: Added.
  • platform/chromium-win-xp/svg/zoom/page/zoom-foreignObject-expected.png: Added.
  • platform/chromium/TestExpectations:
2:26 PM Changeset in webkit [121470] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Mark a test as slow.
https://bugs.webkit.org/show_bug.cgi?id=90207

fast/forms/select/select-state-restore.html is a slow test on debug builds.
Not reviewed.

  • platform/chromium/TestExpectations:
2:10 PM Changeset in webkit [121469] by hclam@chromium.org
  • 15 edits
    2 deletes in trunk/Source/WebKit/chromium

Unreviewed, rolling out r121463.
http://trac.webkit.org/changeset/121463
https://bugs.webkit.org/show_bug.cgi?id=90094

Broke Windows build.

  • WebKit.gypi:
  • WebKitUnitTests.gyp:
  • public/WebDOMMessageEvent.h:
  • tests/AssociatedURLLoaderTest.cpp:

(WebKit::AssociatedURLLoaderTest::AssociatedURLLoaderTest):
(WebKit::AssociatedURLLoaderTest::SetUp):
(WebKit::AssociatedURLLoaderTest::CheckMethodFails):
(WebKit::AssociatedURLLoaderTest::CheckHeaderFails):
(WebKit::AssociatedURLLoaderTest::CheckAccessControlHeaders):
(WebKit::TEST_F):

  • tests/EventListenerTest.cpp:
  • tests/FrameTestHelpers.cpp:

(WebKit::FrameTestHelpers::registerMockedURLLoad):
(FrameTestHelpers):
(WebKit::FrameTestHelpers::loadFrame):

  • tests/FrameTestHelpers.h:

(FrameTestHelpers):

  • tests/ListenerLeakTest.cpp:

(WebKit::ListenerLeakTest::RunTest):

  • tests/PopupMenuTest.cpp:

(WebKit::SelectPopupMenuTest::registerMockedURLLoad):
(WebKit::SelectPopupMenuTest::loadFrame):
(WebKit::TEST_F):

  • tests/RunAllTests.cpp:
  • tests/URLTestHelpers.cpp: Removed.
  • tests/URLTestHelpers.h: Removed.
  • tests/WebFrameTest.cpp:

(WebKit::WebFrameTest::registerMockedHttpURLLoad):
(WebKit::WebFrameTest::registerMockedChromeURLLoad):
(WebKit::TEST_F):

  • tests/WebPageNewSerializerTest.cpp:

(WebKit::WebPageNewSerializeTest::registerMockedURLLoad):
(WebPageNewSerializeTest):
(WebKit::WebPageNewSerializeTest::setUpCSSTestPage):
(WebKit::WebPageNewSerializeTest::loadURLInTopFrame):
(WebKit::WebPageNewSerializeTest::resourceVectorContains):
(WebKit::TEST_F):

  • tests/WebPageSerializerTest.cpp:

(WebKit::WebPageSerializerTest::registerMockedURLLoad):
(WebKit::WebPageSerializerTest::loadURLInTopFrame):
(WebKit::WebPageSerializerTest::webVectorContains):
(WebKit::TEST_F):

  • tests/WebViewTest.cpp:

(WebKit::TEST_F):
(WebKit::WebViewTest::testAutoResize):
(WebKit::WebViewTest::testTextInputType):

2:02 PM Changeset in webkit [121468] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

[EFL] Enable support for HTML5 datalist
https://bugs.webkit.org/show_bug.cgi?id=90157

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-28
Reviewed by Martin Robinson.

.:

Turn on DATALIST flag by default on EFL port to
support HTML5 datalist tag.

  • Source/cmake/OptionsEfl.cmake:

Tools:

Turn on DATALIST flag by default on EFL port to
support HTML5 datalist tag.

  • Scripts/webkitperl/FeatureList.pm:

LayoutTests:

  • platform/efl/Skipped: Unskip fast/forms/datalist tests now that

the DATALIST flag is turned on by default on EFL port.

  • platform/efl/fast/forms/datalist/input-list-expected.txt: Added.

We need platform-specific result because we don't support datalist
UI for any element yet. This should be progressively added later
on and the expected result will evolve.

1:56 PM Changeset in webkit [121467] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[EFL] Use Eina_Module API instead of dlopen in PluginPackageEfl
https://bugs.webkit.org/show_bug.cgi?id=89972

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-28
Reviewed by Antonio Gomes.

Use convenience helpers in Eina_Module to load plugins instead
of POSIX dlopen().

No new tests, behavior has not changed.

  • platform/FileSystem.h:

(WebCore):

  • platform/efl/FileSystemEfl.cpp:

(WebCore::unloadModule):

  • plugins/efl/PluginPackageEfl.cpp:

(WebCore::PluginPackage::load):

1:54 PM Changeset in webkit [121466] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

32bit DFG incorrectly claims an fpr is fillable even if it has not been proven double
https://bugs.webkit.org/show_bug.cgi?id=90127

Reviewed by Filip Pizlo.

The 32-bit version of fillSpeculateDouble doesn't handle Number->fpr loads
correctly. This patch fixes this by killing the fill info in the GenerationInfo
when the spillFormat doesn't guarantee the value is a double.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):

1:47 PM Changeset in webkit [121465] by bfulgham@webkit.org
  • 2 edits in trunk/WebKitLibraries

[WinCairo] Unreviewed build correction. Add two missing macro
declarations to vsprops file.

  • win/tools/vsprops/FeatureDefinesCairo.vsprops: Add missing

ENABLE_HIGH_DPI_CANVAS and ENABLE_REQUEST_ANIMATION_FRAME macros.

1:37 PM Changeset in webkit [121464] by tony@chromium.org
  • 10 edits in trunk

Enable CSS grid layout LayoutTests on platform Mac
https://bugs.webkit.org/show_bug.cgi?id=90113

Reviewed by Ojan Vafai.

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues): Reset the value to NO between tests.

LayoutTests:

Use 1 instead of true, since that's what WebView.mm expects.

  • fast/css-grid-layout/containing-block-grids.html:
  • fast/css-grid-layout/display-grid-set-get.html:
  • fast/css-grid-layout/floating-empty-grids.html:
  • fast/css-grid-layout/grid-columns-rows-get-set-multiple.html:
  • fast/css-grid-layout/grid-columns-rows-get-set.html:
  • fast/css-grid-layout/grid-item-column-row-get-set.html:
  • platform/mac/Skipped: Unskip tests.
1:34 PM Changeset in webkit [121463] by shawnsingh@chromium.org
  • 15 edits
    1 copy
    1 add in trunk/Source/WebKit/chromium

[chromium] Use WEBKIT_IMPLEMENTATION == 1 for webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=90094

Reviewed by Adam Barth.

This patch adds the WEBKIT_IMPLEMENTATION = 1 define to
WebKitUnitTests.gyp. To get it to compile correctly, some string
and URL code was refactored and fixed.

  • WebKit.gypi:
  • WebKitUnitTests.gyp:
  • public/WebDOMMessageEvent.h:

(WebKit::WebDOMMessageEvent::WebDOMMessageEvent):

  • tests/AssociatedURLLoaderTest.cpp:
  • tests/EventListenerTest.cpp:
  • tests/FrameTestHelpers.cpp:

(WebKit::FrameTestHelpers::loadFrame):

  • tests/FrameTestHelpers.h:
  • tests/ListenerLeakTest.cpp:

(WebKit::ListenerLeakTest::RunTest):

  • tests/PopupMenuTest.cpp:
  • tests/RunAllTests.cpp:
  • tests/URLTestHelpers.cpp: Added.

(URLTestHelpers):
(WebKit::URLTestHelpers::registerMockedURLFromBaseURL):
(WebKit::URLTestHelpers::registerMockedURLLoad):

  • tests/URLTestHelpers.h: Copied from Source/WebKit/chromium/public/WebDOMMessageEvent.h.

(WebKit):
(URLTestHelpers):
(WebKit::URLTestHelpers::toKURL):

  • tests/WebFrameTest.cpp:
  • tests/WebPageNewSerializerTest.cpp:
  • tests/WebPageSerializerTest.cpp:
  • tests/WebViewTest.cpp:
1:33 PM Changeset in webkit [121462] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[Qt] Fix TextureMapper rendering of GraphicsSurface on Mac
https://bugs.webkit.org/show_bug.cgi?id=90154

Patch by Jocelyn Turcotte <turcotte.j@gmail.com> on 2012-06-28
Reviewed by Noam Rosenthal.

Fix a regression introduced in r120608.
texture2DRect takes texel coordinates, unlike texture2D which needs normalized coordinates.

Pass an additional textureSize uniform and multiply it by the normalized coordinates.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::drawTextureRectangleARB):

  • platform/graphics/texmap/TextureMapperShaderManager.cpp:

(WebCore::TextureMapperShaderProgram::TextureMapperShaderProgram):
(WebCore::TextureMapperShaderProgramRectSimple::TextureMapperShaderProgramRectSimple):

  • platform/graphics/texmap/TextureMapperShaderManager.h:

(WebCore::TextureMapperShaderProgram::textureSizeLocation):
(TextureMapperShaderProgram):

1:28 PM Changeset in webkit [121461] by Simon Fraser
  • 9 edits in trunk/Source/WebCore

Improve compositing logging output
https://bugs.webkit.org/show_bug.cgi?id=90199

Reviewed by Tim Horton (w00t!).

Improve the compositing logging channel output in a few
useful ways:

  1. Report memory use, rather than megapixels
  2. Show element class names
  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::backingStoreMemoryEstimate):

  • platform/graphics/GraphicsLayer.h:

(GraphicsLayer):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::backingStoreMemoryEstimate):

  • platform/graphics/ca/GraphicsLayerCA.h:

(GraphicsLayerCA):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::nameForLayer):
(WebCore::RenderLayerBacking::backingStoreMemoryEstimate):

  • rendering/RenderLayerBacking.h:

(RenderLayerBacking):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::logLayerInfo):
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

1:27 PM Changeset in webkit [121460] by mifenton@rim.com
  • 2 edits in trunk/Tools

[BlackBerry] Add watchlist options for Blackberry and editing.
https://bugs.webkit.org/show_bug.cgi?id=90193

Unreviewed.

Add BlackBerry and Editing watchlist and monitor them.

  • Scripts/webkitpy/common/config/watchlist:
1:22 PM Changeset in webkit [121459] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

Remove a duplicate expectation.

  • platform/chromium/TestExpectations:
1:19 PM Changeset in webkit [121458] by jamesr@google.com
  • 8 edits in trunk/Source/WebCore

[chromium] Fix up more includes in compositor code
https://bugs.webkit.org/show_bug.cgi?id=90200

Reviewed by Adrienne Walker.

Adds includes we are using and removes ones that we aren't using.

  • platform/graphics/chromium/CanvasLayerTextureUpdater.cpp:
  • platform/graphics/chromium/ContentLayerChromium.cpp:
  • platform/graphics/chromium/ProgramBinding.cpp:
  • platform/graphics/chromium/RenderSurfaceChromium.cpp:
  • platform/graphics/chromium/cc/CCGraphicsContext.h:
  • platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore):

  • platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:
1:13 PM Changeset in webkit [121457] by schenney@chromium.org
  • 4 edits in trunk/LayoutTests

[chromium] svg/custom/clip-path-referencing-use2.svg fails in "drt mode" in DRT
https://bugs.webkit.org/show_bug.cgi?id=85085

Unreviewed Chromium expectations update.

NRWT is not printing the stdout from this test, which is not really
enough to warrant keeping the expectations incorrect. The bug stays
open.

  • platform/chromium-mac/svg/custom/clip-path-referencing-use2-expected.txt:
  • platform/chromium-win/svg/custom/clip-path-referencing-use2-expected.txt:
  • platform/chromium/TestExpectations:
1:02 PM Changeset in webkit [121456] by commit-queue@webkit.org
  • 5 edits
    1 move
    1 add
    1 delete in trunk

[CSSRegions]Rename NamedFlow::contentNodes to NamedFlow::getContent()
https://bugs.webkit.org/show_bug.cgi?id=90163

Patch by Andrei Onea <onea@adobe.com> on 2012-06-28
Reviewed by Andreas Kling.

Source/WebCore:

Latest CSS Regions spec defines the NamedFlow interface as having a function named getContent,
rather than an attribute named contentNodes.
http://www.w3.org/TR/css3-regions/#the-namedflow-interface

Test: fast/regions/webkit-named-flow-get-content.html

  • dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::getContent):

  • dom/WebKitNamedFlow.h:

(WebKitNamedFlow):

  • dom/WebKitNamedFlow.idl:

LayoutTests:

Changed test for NameFlow::contentNodes to reflect new spec, which uses
NameFlow::getContent().

  • fast/regions/webkit-named-flow-content-nodes-expected.txt: Removed.
  • fast/regions/webkit-named-flow-get-content-expected.txt: Added.
  • fast/regions/webkit-named-flow-get-content.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-content-nodes.html.
12:56 PM Changeset in webkit [121455] by timothy_horton@apple.com
  • 2 edits in trunk/Tools

Unreviewed, upgrade myself to a reviewer!

http://www.webkit.org/blog/2082/tim-horton-is-now-a-webkit-reviewer/

  • Scripts/webkitpy/common/config/committers.py:
12:48 PM Changeset in webkit [121454] by rniwa@webkit.org
  • 6 edits
    2 adds in trunk

REGRESSION(r121232): named properties on document and window may return wrong object
https://bugs.webkit.org/show_bug.cgi?id=90133

Reviewed by Andreas Kling.

Source/WebCore:

Fixed the bug. Also replaced hasAnyItem by isEmpty (hasAnyItem() is equivalent to !isEmpty()).

Test: fast/dom/HTMLDocument/named-item-multiple-match.html

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::nameGetter):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::GetNamedProperty):

  • html/HTMLCollection.h:

(WebCore::HTMLCollection::isEmpty):
(WebCore::HTMLCollection::hasExactlyOneItem):

LayoutTests:

Add a regression test.

  • fast/dom/HTMLDocument/named-item-multiple-match-expected.txt: Added.
  • fast/dom/HTMLDocument/named-item-multiple-match.html: Added.
12:45 PM Changeset in webkit [121453] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[Chromium] Chromium's LayoutTestController is missing setBackingScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=83635

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-06-28
Reviewed by Adam Barth.

Added InvokeCallbackTask, a new derived class of MethodTask. When
setBackingScaleFactor is called, a call to setDeviceScaleFactor in
WebView is made and then postTask is used to invoke the callback
function specified in testRunner.setBackingScaleFactor.

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(InvokeCallbackTask):
(InvokeCallbackTask::InvokeCallbackTask):
(InvokeCallbackTask::runIfValid):
(LayoutTestController::setBackingScaleFactor):

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController):

12:37 PM Changeset in webkit [121452] by commit-queue@webkit.org
  • 28 edits in trunk

[Skia] Computing the resampling mode ignores scale applied to the canvas
https://bugs.webkit.org/show_bug.cgi?id=72073

Patch by Zeev Lieber <zlieber@chromium.org> on 2012-06-28
Reviewed by Stephen White.

Source/WebCore:

Re-basing earlier patch by Daniel Sievers; updated tests.

Take into account canvas scale when computing image resampling mode.

When drawing a bitmap and computing the best resampling mode based
on the requested scale, take into account CSS scale and page scale
that are applied to the canvas. This allows for single-pass scaling
in potentially better quality (RESAMPLE_AWESOME) and also takes
better advantage of the scaled image cache in that codepath.

Existing tests updated to expect different resampling method (and
therefore a different image) whenever canvas scaling changes.

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::paintSkBitmap):

LayoutTests:

Updated tests to expect different image when resampling method changed.

  • platform/chromium-linux/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png:
  • platform/chromium-linux/svg/carto.net/scrollbar-expected.png:
  • platform/chromium-linux/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-linux/transitions/cross-fade-background-image-expected.png:
  • platform/chromium/TestExpectations:
12:35 PM Changeset in webkit [121451] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Change WebViewImpl::textInputInfo to use root editable element.
https://bugs.webkit.org/show_bug.cgi?id=90179

Patch by Oli Lan <olilan@chromium.org> on 2012-06-28
Reviewed by Adam Barth.

WebViewImpl::textInputInfo currently returns text value and offsets relative to the
focused node. For contenteditable nodes, this may not give the expected result.

This patch changes the method to return value and offsets for the root editable element.
This also allows the implementation to be simplified somewhat.

This also ensures that the offsets returned will use the same basis as the recently added
method Editor::setSelectionOffsets (and WebViewImpl::setEditableSelectionOffsets).

Testing for textInputInfo has been added to WebViewTest.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::textInputInfo):

  • tests/WebViewTest.cpp:

(WebKit::TEST_F):

12:27 PM Changeset in webkit [121450] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[chromium] Should schedule a commit when dropping contents textures
https://bugs.webkit.org/show_bug.cgi?id=90031

Patch by James Robinson <jamesr@chromium.org> on 2012-06-28
Reviewed by Adrienne Walker.

Source/WebCore:

If we're dropping contents textures on the impl thread, we need to schedule a commit to pick up new contents at
the next commit opportunity. Also adds some traces to make debugging issues like this easier.

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::commitComplete):
(WebCore::CCLayerTreeHostImpl::canDraw):
(WebCore::CCLayerTreeHostImpl::releaseContentsTextures):

  • platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::processScheduledActions):

Source/WebKit/chromium:

Adds a somewhat vacuous test unit test for committing when releasing textures.

  • tests/CCLayerTreeHostImplTest.cpp:
12:20 PM Changeset in webkit [121449] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk/Source/WebKit2

[WK2] Add C API to inspect a Web Intent service
https://bugs.webkit.org/show_bug.cgi?id=89276

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-28
Reviewed by Anders Carlsson.

Add C API for Web intent service so that it can be queried
on client side.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • UIProcess/API/C/WKIntentServiceInfo.cpp: Added.

(WKIntentServiceInfoGetTypeID):
(WKIntentServiceInfoCopyAction):
(WKIntentServiceInfoCopyType):
(WKIntentServiceInfoCopyHref):
(WKIntentServiceInfoCopyTitle):
(WKIntentServiceInfoCopyDisposition):

  • UIProcess/API/C/WKIntentServiceInfo.h: Added.
12:15 PM Changeset in webkit [121448] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

ThreadingWin: Silence GCC compiler warnings
https://bugs.webkit.org/show_bug.cgi?id=89491

Patch by Kalev Lember <kalevlember@gmail.com> on 2012-06-28
Reviewed by Adam Roben.

  • wtf/ThreadingWin.cpp:

(WTF::createThreadInternal):
(WTF::PlatformCondition::timedWait):
(WTF::PlatformCondition::signal): Fix unused-but-set-variable
warnings.

12:03 PM Changeset in webkit [121447] by ojan@chromium.org
  • 6 edits in trunk/Tools

Make rebaseline-test and rebaseline-expectations work for non-Chromium ports
https://bugs.webkit.org/show_bug.cgi?id=90186

Reviewed by Adam Barth.

This makes rebaselining work for all ports that have a TestExpectations file
in the tree. I didn't test other ports.

This doesn't address 100% of the problem. The rebaseline code puts the expectations
in the most specific directory and relies on optimize-baselines to merge baselines
appropriately. This only works if every platform directory has an equivalent bot
that runs the tests, which is not true for most ports.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:

(Builder._revision_and_build_for_filename):
Some bots have filenames that aren't revision/build number pairs
e.g. they are random junk like aQhxvx. Handle this gracefully.
(Builder._fetch_revision_to_build_map):
(Builder._file_info_list_to_revision_to_build_list):

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

(BuilderTest.test_build_and_revision_for_filename):
(BuilderTest.test_file_info_list_to_revision_to_build_list):

  • Scripts/webkitpy/layout_tests/port/builders.py:

Update the list of builders. This list needs to be kept up
to date for the rebaseline tool to work.

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineTest._results_url):
(RebaselineExpectations._run_webkit_patch):
(RebaselineExpectations._rebaseline_port):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

Qt port uses qmake to determine the right version. Systems without qmake correctly fallback
to a specific version.

11:58 AM Changeset in webkit [121446] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

Don't malloc RenderGeometryMap steps individually
https://bugs.webkit.org/show_bug.cgi?id=90074

Reviewed by Simon Fraser.

Mallocs and frees for steps under RenderGeometryMap::pus/popMappingsToAncestor can total ~2% of the profile when animating transforms.

  • rendering/RenderGeometryMap.cpp:

(WebCore):
(WebCore::RenderGeometryMap::absolutePoint):
(WebCore::RenderGeometryMap::absoluteRect):
(WebCore::RenderGeometryMap::mapToAbsolute):
(WebCore::RenderGeometryMap::push):
(WebCore::RenderGeometryMap::pushView):
(WebCore::RenderGeometryMap::popMappingsToAncestor):

  • rendering/RenderGeometryMap.h:

(WebCore):
(WebCore::RenderGeometryMapStep::RenderGeometryMapStep):

Move to header.

(RenderGeometryMapStep):
(RenderGeometryMap):

Make the step vector hold RenderGeometryMapSteps instead of RenderGeometryMapStep*'s.

(WTF):

Give RenderGeometryMapSteps SimpleClassVectorTraits. This is needed for dealing with OwnPtr in the struct (and makes it faster too).
The type is simple enought to move by memcpy.

11:22 AM WebKitGTK/1.8.x edited by kalevlember@gmail.com
Add patches for Windows NPAPI plugin support (diff)
11:15 AM Changeset in webkit [121445] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[GTK] Remove Windows support from plugins/gtk/
https://bugs.webkit.org/show_bug.cgi?id=89501

Patch by Kalev Lember <kalevlember@gmail.com> on 2012-06-28
Reviewed by Martin Robinson.

The GTK+ port now uses plugins/gtk/ on Windows, which leaves
PluginPackageGtk.cpp and PluginViewGtk.cpp solely for XP_UNIX platforms.

  • plugins/gtk/PluginPackageGtk.cpp:

(WebCore::PluginPackage::fetchInfo):
(WebCore::webkitgtkXError):
(WebCore::PluginPackage::load):

  • plugins/gtk/PluginViewGtk.cpp:

(WebCore::getRootWindow):
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paint):
(WebCore::PluginView::handleKeyboardEvent):
(WebCore::setXCrossingEventSpecificFields):
(WebCore::PluginView::handleMouseEvent):
(WebCore::PluginView::handleFocusOutEvent):
(WebCore::PluginView::setNPWindowIfNeeded):
(WebCore::PluginView::platformGetValueStatic):
(WebCore::PluginView::platformGetValue):
(WebCore::getPluginDisplay):
(WebCore::getVisualAndColormap):
(WebCore::PluginView::platformStart):
(WebCore::PluginView::platformDestroy):

11:09 AM Changeset in webkit [121444] by jschuh@chromium.org
  • 1 edit in branches/chromium/1132/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp

Merge 120881

TBR=raymes@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10692027

11:08 AM Changeset in webkit [121443] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Change FrameView::scrollContentsFastPath to use m_fixedObjects
https://bugs.webkit.org/show_bug.cgi?id=90045

Reviewed by James Robinson.

FrameView now has a hash set of fixed-position objects, so use
that instead of RenderBlock::positionedObjects(); we'll avoid traversing
through absolutely positioned objects, and this will work better for sticky
positioning in future.

No behavior change, so no new tests.

  • page/FrameView.cpp:

(WebCore::FrameView::scrollContentsFastPath):

11:06 AM Changeset in webkit [121442] by tony@chromium.org
  • 18 edits
    2 adds in trunk

Split flex into flex-grow/flex-shrink/flex-basis
https://bugs.webkit.org/show_bug.cgi?id=86525

Reviewed by Ojan Vafai.

Source/WebCore:

Split flex into 3 separate properties per the spec:
http://dev.w3.org/csswg/css3-flexbox/#flex-components

Tests: css3/flexbox/flex-longhand-parsing.html

css3/flexbox/flex-property-parsing.html: Updated test results.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore): -webkit-flex is no longer enumerable.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Add new css property names and use
getCSSPropertyValuesForShorthandProperties for WebkitFlex. Also sort flex propery names.

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue): Fix indent.
(WebCore::CSSParser::parseValue): Add parsing for new properties and handle -webkit-flex: none.
(WebCore::CSSParser::parseFlex): Switch to new names (positive -> grow, negative -> shrink,
preferred size -> basis) and assign to longhand properties.

  • css/CSSParser.h:
  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty): Add new properties.

  • css/CSSPropertyNames.in: Add new properties.
  • css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder): Delete special handling of applying flex and just use shorthand handlers.

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getPropertyValue): Add new shorthand.
(WebCore::StylePropertySet::asText):

  • css/StylePropertyShorthand.cpp:

(WebCore::webkitFlexShorthand): Add new shorthand.
(WebCore::shorthandForProperty):

  • css/StylePropertyShorthand.h:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList): Add to list of properties applied by StyleBuilder.
Handle initial and inherit for flex.

LayoutTests:

If -webkit-flex is set to none, when the user reads the value back out, it is
now 0 0 auto. 'none' is for convenience, not an actual value.

  • css3/flexbox/flex-longhand-parsing-expected.txt:
  • css3/flexbox/flex-longhand-parsing.html: Test flex-grow, flex-shrink and flex-basis.
  • css3/flexbox/flex-property-parsing-expected.txt:
  • css3/flexbox/flex-property-parsing.html: Update results for 'none'.
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/css/getComputedStyle/resources/property-names.js: Remove -webkit-flex since it's no longer enumerable.
  • svg/css/getComputedStyle-basic-expected.txt:
11:00 AM Changeset in webkit [121441] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK][Win]: Fix plugin drawing to an offscreen buffer
https://bugs.webkit.org/show_bug.cgi?id=89499

Patch by Kalev Lember <kalevlember@gmail.com> on 2012-06-28
Reviewed by Brent Fulgham.

Take into account that the GTK+ port draws to a backing store and adjust
the target rectangle calculation accordingly.

  • plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::paint):
(WebCore::PluginView::setNPWindowRect):

10:14 AM Changeset in webkit [121440] by kling@webkit.org
  • 2 edits in trunk/LayoutTests

[WK2] platform/mac/editing/spelling/autocorrection-blockquote-crash.html fails.
<http://webkit.org/b/90156>

Skip this test on mac-wk2 for now.

  • platform/mac-wk2/Skipped:
10:07 AM Changeset in webkit [121439] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

Optimize Dromaeo/dom-attr.html by speeding up Element::getAttribute()
https://bugs.webkit.org/show_bug.cgi?id=90174

Reviewed by Adam Barth.

This patch improves performance of Dromaeo/dom-attr.html by 4.0%.
The patch improves performance of getAttribute() and JavaScript
property setter for DOM objects (e.g. 'div.foo = 123').
The performance improvement becomes larger, as the number of
attributes defined on the DOM object increases.

Without the patch in Chromium/Linux (runs/s)
7679.4, 7739.7, 7634.0, 7726.4, 7663.9

With the patch in Chromium/Linux (runs/s)
7977.7, 8032.2, 8112.8, 7948.1, 7924.5

This patch just changes a type of 'name' of Element::getAttribute(String& name)
from String& to AtomicString&.

The key observation is that AtomicString(String& x) is faster than
operator==(String& x, AtomicString& y). AtomicString(String& x) calculates
a hash of a given String and adds it to a hash table. The calculation
complexity is O(the length of x). On the other hand,
operator==(String& x, AtomicString& y) compares a String and an AtomicString by
StringImpl::equal(StringImpl*, StringImpl*), the calculation complexity of
which is O(2 * min(the length of x, the length of y)).
In addition, the comparison logic is more complicated than the logic
of calculating the hash. Consequently, AtomicString(String& x) is
faster than operator==(String& x, AtomicString& y).

Keeping that in mind, let's estimate the performance of
Element::getAttribute("class") for <div id="A" lang="B" title="C" class="D" dir="E">.
Here "id", "lang", "title", "class" and "dir" are stored as AtomicStrings
in QualifiedName::localName(). Initially, "class" in Element::getAttribute("class")
is a String.

If we use Element::getAttribute(String& name) (i.e. without the patch),
ElementAttributeData::getAttributeItemIndex() executes four
operator==(String&, AtomicString&) by the time it finds the "class" attribute:

(1) if ("class" == "id") operator==(String&, AtomicString&)
(2) if ("class" == "lang")
operator==(String&, AtomicString&)
(3) if ("class" == "title") operator==(String&, AtomicString&)
(4) if ("class" == "class")
operator==(String&, AtomicString&)

On the other hand, if we use Element::getAttribute(AtomicString& name)
(i.e. with the patch), ElementAttributeData::getAttributeItemIndex()
executes one AtomicString(String&) and four operator==(AtomicString&, AtomicString&)
by the time it finds the "class" attribute:

(1) AtomicString("class") AtomicString(String&)
(2) if ("class" == "id")
operator==(AtomicString&, AtomicString&)
(3) if ("class" == "lang") operator==(AtomicString&, AtomicString&)
(4) if ("class" == "title")
operator==(AtomicString&, AtomicString&)
(5) if ("class" == "class") operator==(AtomicString&, AtomicString&)

Considering that the overhead of operator==(AtomicString&, AtomicString&) is close
to 0 since it is just a pointer comparison, the latter approach is faster than
the former approach.

Performance improvement will be large for elements that have multiple attributes,
but it is faster even for elements that have only one attribute.
For exmaple, Dromaeo/dom-attr.html tests getAttribute() for an element that has
only one attribute, the result shows 4.0% improvement.

Another example optimized by this patch is 'div.foo = 123', where foo is not
an attribute of div. In this case, before 123 is set, JavaScript calls back
Element::getAttribute() to check whether 'foo' is defined on div by
scanning all the attributes of div.

No tests. No change in behavior.

  • dom/Element.cpp:

(WebCore::Element::getAttribute):

  • dom/Element.h:

(Element):
(WebCore::Element::getAttributeItemIndex):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::getAttributeItemIndexSlowCase):

  • dom/ElementAttributeData.h:

(ElementAttributeData):
(WebCore::ElementAttributeData::getAttributeItem):
(WebCore::ElementAttributeData::getAttributeItemIndex):

9:52 AM Changeset in webkit [121438] by hans@chromium.org
  • 5 edits in trunk

Speech JavaScript API: Don't dispatch end event after ActiveDOMObject::stop()
https://bugs.webkit.org/show_bug.cgi?id=90176

Reviewed by Adam Barth.

Source/WebCore:

It is probably not safe to dispatch an event on an object that has
been ActiveDOMObject::stop()'ed.

This used to happen in the navigate-away.html test, which I believe
then caused speechgrammar-basics.html (which was typically run
afterwards, by the same worker), to crash flakily. See Bug 89717.

Test: speechgrammar-basics.html should no longer be flaky.

  • Modules/speech/SpeechRecognition.cpp:

(WebCore::SpeechRecognition::didEnd):
(WebCore::SpeechRecognition::stop):
(WebCore::SpeechRecognition::SpeechRecognition):

  • Modules/speech/SpeechRecognition.h:

LayoutTests:

speechgrammar-basics.html should no longer be flaky.

  • platform/chromium/TestExpectations:
9:43 AM Changeset in webkit [121437] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] [WK2] Memory leak in ResourceHandleSoup.cpp
https://bugs.webkit.org/show_bug.cgi?id=90168

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-28
Reviewed by Martin Robinson.

Fixed a memory leak in WebCoreSynchronousLoader by using adoptGRef
instead of just getting new reference of GMainLoop.

No new tests. No change in behavior.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):

9:35 AM Changeset in webkit [121436] by danakj@chromium.org
  • 16 edits in trunk/Source

[chromium] Do not multiply bounds by contentsScale in TiledLayerChromium and CanvasLayerTextureUpdater
https://bugs.webkit.org/show_bug.cgi?id=90103

Reviewed by Adrienne Walker.

Source/WebCore:

Non-integer scale factors can scale the bounds of a layer such that
different rounding is applied to the width and height in the content
bounds. We should never multiply bounds by contentsScale in order to
work correctly with non-integer scale factors. Instead, always use the
contentBounds/bounds ratio for width and height independently.

Tests: TiledLayerChromiumTest.nonIntegerContentsScaleIsNotDistortedDuringPaint

TiledLayerChromiumTest.nonIntegerContentsScaleIsNotDistortedDuringInvalidation

  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:

(WebCore::BitmapCanvasLayerTextureUpdater::prepareToUpdate):

  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h:

(BitmapCanvasLayerTextureUpdater):

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::prepareToUpdate):

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:

(BitmapSkPictureCanvasLayerTextureUpdater):

  • platform/graphics/chromium/CanvasLayerTextureUpdater.cpp:

(WebCore::CanvasLayerTextureUpdater::paintContents):

  • platform/graphics/chromium/CanvasLayerTextureUpdater.h:

(CanvasLayerTextureUpdater):

  • platform/graphics/chromium/LayerTextureUpdater.h:

(WebCore::LayerTextureUpdater::prepareToUpdate):

  • platform/graphics/chromium/ScrollbarLayerChromium.cpp:

(WebCore::ScrollbarLayerChromium::updatePart):

  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::SkPictureCanvasLayerTextureUpdater::prepareToUpdate):

  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h:

(SkPictureCanvasLayerTextureUpdater):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::setNeedsDisplayRect):
(WebCore::TiledLayerChromium::updateTiles):

Source/WebKit/chromium:

  • tests/CCTiledLayerTestCommon.cpp:

(WebKitTests::FakeLayerTextureUpdater::prepareToUpdate):

  • tests/CCTiledLayerTestCommon.h:

(FakeTiledLayerChromium):

  • tests/TiledLayerChromiumTest.cpp:
9:14 AM Changeset in webkit [121435] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Make GC's fill{Rounded}Rect use optimized shadow blur code
https://bugs.webkit.org/show_bug.cgi?id=90082

Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2012-06-28
Reviewed by Noam Rosenthal.

ShadowBlur::drawRectShadow makes use of optimized tiles-based drawPattern, which
is not present when using {begin/end}shadowLayer.

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::pushTransparencyLayerInternal):

9:05 AM Changeset in webkit [121434] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[chromium] Introduce way to reload a page using the original request URL
https://bugs.webkit.org/show_bug.cgi?id=89788

Patch by Dan Alcantara <dfalcantara@chromium.org> on 2012-06-28
Reviewed by Adam Barth.

Adds a new reload method for cases where we need to override the URL
when reloading a page. This is needed for situations where a server
redirects navigation based on information that may have changed since
the last time the page was loaded.

User agents, for example, can cause a server to redirect to the mobile
version of a page. Changing to the desktop version by switching user agents
requires loading a URL from before the redirect occurred.

Also adds a unit test to confirm that scroll position and page scale are
saved when the reload occurs.

  • public/WebFrame.h:

(WebFrame):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::reloadWithGivenURL):
(WebKit):

  • src/WebFrameImpl.h:

(WebFrameImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setClearPageScaleFactorOnLoad):
(WebKit):
(WebKit::WebViewImpl::didCommitLoad):

  • src/WebViewImpl.h:

(WebViewImpl):

8:43 AM Changeset in webkit [121433] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Provide context menu 'Delete all watch expressions.'
https://bugs.webkit.org/show_bug.cgi?id=89735

Patch by Rahul Tiwari <rahultiwari.cse.iitr@gmail.com> on 2012-06-28
Reviewed by Yury Semikhatsky.

Added context menu delete and delete all watch expressions.

No new tests required as its a minor UI related change.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/WatchExpressionsSidebarPane.js:

(WebInspector.WatchExpressionsSection.prototype.updateExpression):
(WebInspector.WatchExpressionsSection.prototype._deleteAllExpressions):
(WebInspector.WatchExpressionsSection.prototype.findAddedTreeElement):
(WebInspector.WatchExpressionTreeElement.prototype.update):
(WebInspector.WatchExpressionTreeElement.prototype._contextMenu):
(WebInspector.WatchExpressionTreeElement.prototype._deleteAllButtonClicked):

8:33 AM Changeset in webkit [121432] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

m_cssVariablesEnabled member is not initialized in Page Settings
https://bugs.webkit.org/show_bug.cgi?id=90147

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-28
Reviewed by Simon Hausmann.

Properly initialize the m_cssVariablesEnabled member in Page
Settings.

No new tests, no behavior change.

  • page/Settings.cpp:

(WebCore::Settings::Settings):

7:43 AM Changeset in webkit [121431] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt][NRWT] Fix baseline and skipped file search path.
https://bugs.webkit.org/show_bug.cgi?id=89882

Unreviewed trivial typo fix after r121430.

  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:

(QtPortTest._assert_search_path):
(QtPortTest._assert_skipped_path):

7:33 AM Changeset in webkit [121430] by Csaba Osztrogonác
  • 3 edits in trunk/Tools

[Qt][NRWT] Fix baseline and skipped file search path.
https://bugs.webkit.org/show_bug.cgi?id=89882

Patch by János Badics <János Badics> on 2012-06-28
Reviewed by Csaba Osztrogonác.

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort._search_paths):
(QtPort):
(QtPort.baseline_search_path):
(QtPort._skipped_file_search_paths):

  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:

(QtPortTest):
(QtPortTest._assert_skipped_path):
(QtPortTest.test_baseline_search_path):
(QtPortTest.test_skipped_file_search_path):

7:27 AM Changeset in webkit [121429] by apavlov@chromium.org
  • 7 edits in trunk

[Qt] inspector/styles/inject-stylesheet.html makes 4 tests flakey (TEXT PASS)
https://bugs.webkit.org/show_bug.cgi?id=90167

Reviewed by Csaba Osztrogonác.

Source/WebKit/qt:

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::removeUserStyleSheets):

  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

DRT should remove user stylesheets from the page group when resetting before running another test.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):

LayoutTests:

Unskip the previously offensive test.

  • platform/qt/Skipped:
7:10 AM Changeset in webkit [121428] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[WK2] New fast/events/drag-display-none-element.html fails
https://bugs.webkit.org/show_bug.cgi?id=90177

Unreviewed gardening, skip the new failing test.

  • platform/wk2/Skipped:
6:16 AM Changeset in webkit [121427] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] css3/filters/huge-region-composited.html makes css3/filters/huge-region.html crash
https://bugs.webkit.org/show_bug.cgi?id=90165

[Qt] inspector/styles/inject-stylesheet.html makes 4 tests flakey (TEXT PASS)
https://bugs.webkit.org/show_bug.cgi?id=90167

Unreviewed gardening, skip the guilty tests.

  • platform/qt/Skipped:
6:07 AM Changeset in webkit [121426] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt][DRT] Reset AcceleratedCompositingEnabled between tests
https://bugs.webkit.org/show_bug.cgi?id=90164

Reviewed by Simon Hausmann.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::resetSettings):

4:39 AM Changeset in webkit [121425] by Csaba Osztrogonác
  • 9 edits in trunk

[Qt] Restore original value of mock scrollbars between tests
https://bugs.webkit.org/show_bug.cgi?id=90155

Reviewed by Simon Hausmann.

Source/WebKit/qt:

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setMockScrollbarsEnabled):

  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::resetSettings):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::setMockScrollbarsEnabled):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:

(LayoutTestController):

LayoutTests:

  • platform/qt/Skipped: Unskip tests which doesn't break anything now.
2:57 AM Changeset in webkit [121424] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening after r121388
https://bugs.webkit.org/show_bug.cgi?id=90145

Unreviewed EFL gardening. The new fast/events/drag-display-none-element.html
test added in r121388 does not pass on EFL port because of missing drag'n'drop support.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-06-28

  • platform/efl/TestExpectations:
2:36 AM Changeset in webkit [121423] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] plugin is loaded to the web process via MainResourceLoader::substituteMIMETypeFromPluginDatabase
https://bugs.webkit.org/show_bug.cgi?id=86489

Reviewed by Simon Hausmann.

Removed the substituteMIMETypeFromPluginDatabase quirk from
MainResourceLoader. It would be possible to fix it in a way
that is compatible with WebKit2, but given that it was a Qt
only fix, and that it's not clear that we still need it, and
it's not even work currently, I decided to remove it. At least
it is -1 platform ifdef in common code.

Just removed a non-tested quirk, no test needed.

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::didReceiveResponse):

2:30 AM Changeset in webkit [121422] by mrowe@apple.com
  • 2 edits in trunk/Tools

<http://webkit.org/b/90096> Building within Xcode sometimes does a full rebuild after building via build-webkit

We need to ensure that build-webkit uses the same setting for SHARED_PRECOMPS_DIR
as what Xcode itself will use when building, otherwise switching between the two
can result in the precompiled headers being rebuilt and thus the entire world
rebuilding.

Reviewed by Dan Bernstein.

  • Scripts/webkitdirs.pm:

(determineBaseProductDir):

1:51 AM Changeset in webkit [121421] by haraken@chromium.org
  • 8 edits in trunk/Source/WebCore

[V8] Optimize Integer::New() by caching persistent handles for small integers
https://bugs.webkit.org/show_bug.cgi?id=90043

Reviewed by Adam Barth.

The patch improves performance of Dromaeo/dom-query.html by 3.6%,
and Bindings/scroll-top.html by 17.3%.

The performance results in my Chromium/Linux:

[Dromaeo/dom-query.html]
796310.4 runs/s => 824745.4 runs/s (+3.6%)

[Bindings/scroll-top.html]
204.68 runs/s => 240.15 runs/s (+17.3%)

This patch introduces V8BindingPerIsolateData::IntegerCache (just like
V8BindingPerIsolateData::StringCache) to cache persistent handles
for small integers.

No new tests. No change in behavior.

  • bindings/v8/V8Binding.h: Implemented v8Integer() and v8UnsignedInteger(),

which returns cached persistent handles for integers smaller than 64.
(WebCore):
(IntegerCache):
(WebCore::IntegerCache::IntegerCache):
(WebCore::IntegerCache::v8Integer):
(WebCore::IntegerCache::v8UnsignedInteger):
(WebCore::V8BindingPerIsolateData::integerCache):
(V8BindingPerIsolateData):
(WebCore::v8Integer):
(WebCore::v8UnsignedInteger):

  • bindings/v8/V8Binding.cpp:

(WebCore):
(WebCore::IntegerCache::createSmallIntegers):

  • bindings/v8/WorkerScriptController.cpp:

(~WorkerScriptController): ~V8BindingPerIsolateData() should be called before
isolate->Exit(), since ~V8BindingPerIsolateData() calls V8 APIs that requires
the current isolate.

  • bindings/scripts/CodeGeneratorV8.pm: Replaced Integer::New() and Integer::NewFromUnsigned()

with v8Integer() and v8UnsignedInteger().
(GenerateNormalAttrGetter):
(NativeToJSValue):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp: Updated run-bindings-tests results.

(WebCore::TestActiveDOMObjectV8Internal::excitingAttrAttrGetter):

  • bindings/scripts/test/V8/V8TestObj.cpp: Ditto.

(WebCore::TestObjV8Internal::readOnlyIntAttrAttrGetter):
(WebCore::TestObjV8Internal::shortAttrAttrGetter):
(WebCore::TestObjV8Internal::unsignedShortAttrAttrGetter):
(WebCore::TestObjV8Internal::intAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedIntegralAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedUnsignedIntegralAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedCustomIntegralAttrAttrGetter):
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::attrWithSetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeAttrGetter):
(WebCore::TestObjV8Internal::conditionalAttr1AttrGetter):
(WebCore::TestObjV8Internal::conditionalAttr2AttrGetter):
(WebCore::TestObjV8Internal::conditionalAttr3AttrGetter):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr1AttrGetter):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr2AttrGetter):
(WebCore::TestObjV8Internal::enabledAtContextAttr1AttrGetter):
(WebCore::TestObjV8Internal::enabledAtContextAttr2AttrGetter):
(WebCore::TestObjV8Internal::strawberryAttrGetter):
(WebCore::TestObjV8Internal::descriptionAttrGetter):
(WebCore::TestObjV8Internal::idAttrGetter):
(WebCore::TestObjV8Internal::intMethodCallback):
(WebCore::TestObjV8Internal::intMethodWithArgsCallback):
(WebCore::TestObjV8Internal::classMethodWithOptionalCallback):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp: Ditto.

(WebCore::TestSerializedScriptValueInterfaceV8Internal::portsAttrGetter):

1:48 AM Changeset in webkit [121420] by tkent@chromium.org
  • 8 edits
    3 adds in trunk

Classify form control states by their owner forms
https://bugs.webkit.org/show_bug.cgi?id=89950

Reviewed by Hajime Morita.

Source/JavaScriptCore:

Expose WTF::StringBuilder::canShrink()

Source/WebCore:

To improve robustness of the form state restore feature, we classify
form control states by their owner forms. Owner forms are identified by
their action URLs and index numbers in forms with the same action URLs.

Implementation approach:
Extend FormElementKey class to have "formKey" string, which is a
combination of the action URL and an index number, or a fixed string for
no form owner.
FormKeyGenerator class is responsible to generate the "formKey" strings

Test: fast/forms/state-restore-per-form.html

  • html/FormController.cpp:

(FormKeyGenerator):
(WebCore::FormKeyGenerator::create): A factory function.
(WebCore::FormKeyGenerator::FormKeyGenerator): A private constructor.
(WebCore::createKey):
A helper for formKey(). This makes strings like "<action URL> #<index>".
(WebCore::FormKeyGenerator::formKey):
Returns a formKey for the specified HTMLFormElement*.
(WebCore::FormKeyGenerator::willDeleteForm):
Unregister HTMLFormElement*. This function is necessary because form
restore feature works during parsing and a script might delete form
elements.
(WebCore::formStateSignature): Bump the version.
(WebCore::FormController::formElementsState):
Records a formKey string for each of control state.
(WebCore::FormController::setStateForNewFormElements):
Loads formKeys from stateVector, and uses them for FormElementKey.
(WebCore::FormController::takeStateForFormElement):

  • Construct and destruct FormKeyGenerator if needed.
  • Passing a formKey for the specified form control to FormElementKey.

(WebCore::FormController::willDeleteForm):
Delegate to FormKeyGenerator::willDeleteForm.

(WebCore::FormElementKey::FormElementKey): Add formKey argument and member.
(WebCore::FormElementKey::operator=): ditto.
(WebCore::FormElementKey::ref): ditto.
(WebCore::FormElementKey::deref): ditto.

  • html/FormController.h:

(FormElementKey): Add formKey argument and member.
(FormController): Add a FormKeyGenerator member which is used during restoring.

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::~HTMLFormElement): Notify the death to FormController.

LayoutTests:

  • fast/forms/resources/state-restore-per-form-back.html: Added.
  • fast/forms/state-restore-per-form-expected.txt:

Added. This contains some FAIL lines. They are expected and will
be fixed in webkit.org/b/89962.

  • fast/forms/state-restore-per-form.html: Added.
  • fast/forms/state-restore-broken-state-expected.txt:

Updated for the serialization format change.

1:44 AM Changeset in webkit [121419] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update

  • platform/chromium/TestExpectations:

platform/chromium/accessibility/add-to-menu-list-crashes.html is passing.

1:39 AM Changeset in webkit [121418] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening, removing crash expectation for the
fast/workers/worker-context-gc.html test as the offending revision
was rolled out in r121417.

  • platform/gtk/TestExpectations:
1:34 AM Changeset in webkit [121417] by zandobersek@gmail.com
  • 13 edits in trunk/Source

Unreviewed, rolling out r121395.
http://trac.webkit.org/changeset/121395
https://bugs.webkit.org/show_bug.cgi?id=90143

Patch causes crashes in fast/workers/worker-context-gc.html
(Requested by zdobersek on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-28

Source/WebCore:

  • Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::open):

  • workers/DedicatedWorkerThread.cpp:

(WebCore::DedicatedWorkerThread::create):
(WebCore::DedicatedWorkerThread::DedicatedWorkerThread):

  • workers/DedicatedWorkerThread.h:

(DedicatedWorkerThread):

  • workers/DefaultSharedWorkerRepository.cpp:

(SharedWorkerProxy):
(WebCore::DefaultSharedWorkerRepository::workerScriptLoaded):

  • workers/SharedWorkerThread.cpp:

(WebCore::SharedWorkerThread::create):
(WebCore::SharedWorkerThread::SharedWorkerThread):

  • workers/SharedWorkerThread.h:

(SharedWorkerThread):

  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::startWorkerContext):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThreadStartupData::create):
(WorkerThreadStartupData):
(WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
(WebCore::WorkerThread::WorkerThread):

  • workers/WorkerThread.h:

(WorkerThread):

Source/WebKit/chromium:

  • src/WebSharedWorkerImpl.cpp:

(WebKit::WebSharedWorkerImpl::startWorkerContext):

  • src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::startWorkerContext):

12:46 AM Changeset in webkit [121416] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] KURL assert at fast/loader/opaque-base-url.html
https://bugs.webkit.org/show_bug.cgi?id=89468

Reviewed by Simon Hausmann.

Don't use the KURL(ParsedURLStringTag, const String&) constructor.
We cannot be sure that the url in encode was valid and even if it
was the message could have been corrupted.

  • Shared/qt/WebCoreArgumentCodersQt.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

12:30 AM Changeset in webkit [121415] by yosin@chromium.org
  • 7 edits
    1 add in trunk/Source

[Platform] Implement functions for localized time format information
https://bugs.webkit.org/show_bug.cgi?id=89965

Reviewed by Kent Tamura.

Source/WebCore:

This patch introduces three functions for time format:

  1. localizedTimeFormatText()
  2. localizedShortTimeFormatText()
  3. timeAMPMLabels()

for input type "time" if ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS) is true.

Having both localizedTimeFormat and localizedShortTimeFormat is for
displaying only two fields hour and minute when step >= 60. There is
no way to remove second field from "h:m:s" pattern string. We don't
know whether ":" after "m" belongs minute or second field.

Test: WebKit/chromium/tests/LocalizedDateICUTest.cpp

  • platform/text/LocaleICU.cpp:

(WebCore::LocaleICU::LocaleICU):
(WebCore::createFallbackAMPMLabels): Added.
(WebCore::LocaleICU::initializeDateTimeFormat): Added.
(WebCore::LocaleICU::localizedTimeFormatText): Added.
(WebCore::LocaleICU::localizedShortTimeFormatText): Added.
(WebCore::LocaleICU::timeAMPMLabels): Added.

  • platform/text/LocaleICU.h:

(LocaleICU):

  • platform/text/LocalizedDate.h:
  • platform/text/LocalizedDateICU.cpp:

(WebCore::localizedTimeFormatText): Added.
(WebCore::localizedShortTimeFormatText): Added.
(WebCore::timeAMPMLabels): Added.

Source/WebKit/chromium:

This patch adds new test LocalizedDateICUTest if ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS)
is true.

  • WebKit.gypi:
  • tests/LocalizedDateICUTest.cpp: Added.

(LocalizedDateICUTest):
(Labels):
(LocalizedDateICUTest::Labels::Labels):
(LocalizedDateICUTest::Labels::operator==):
(LocalizedDateICUTest::Labels::toString):
(LocalizedDateICUTest::labels):
(LocalizedDateICUTest::localizedDateFormatText):
(LocalizedDateICUTest::localizedShortDateFormatText):
(LocalizedDateICUTest::timeAMPMLabels):
(operator<<):
(TEST_F):

12:25 AM Changeset in webkit [121414] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip a new test to hide an annoying bug
https://bugs.webkit.org/show_bug.cgi?id=87680 (and paint the bot green)

  • platform/qt/Skipped:
12:17 AM Changeset in webkit [121413] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening, adding a crash expectation for the
fast/workers/worker-context-gc.html test that started crashing after r121395.

  • platform/gtk/TestExpectations:

Jun 27, 2012:

11:29 PM Changeset in webkit [121412] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

Performance: Optimize Dromaeo/dom-query.html by caching NodeRareData on Document
https://bugs.webkit.org/show_bug.cgi?id=90059

Reviewed by Ryosuke Niwa.

This patch improves performance of document.getElementsBy*().
e.g. the patch makes Dromaeo/dom-query.html 5.4% faster.

Dromaeo/dom-query.html without the patch (Chromium/Linux):
784714 runs/s, 765947 runs/s, 803109 runs/s, 804450 runs/s

Dromaeo/dom-query.html with the patch (Chromium/Linux):
839245 runs/s, 829867 runs/s, 811032 runs/s, 847486 runs/s

Based on the assumption that document.getElementsByClassName(),
document.getElementsByTagName() and document.getElementsByName()
would be used frequently in the real world, this patch implements
a fast path for Document methods that require to access NodeRareData.
Specifically, this patch caches a pointer to NodeRareData on Document,
by which Document can access NodeRareData without looking up a HashMap.

The only performance concern is the overhead of the isDocumentNode() check
that this patch added to Node::ensureRareData. However, I could not
observe any performance regression caused by the overhead.

No tests. No change in behavior.

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::setCachedRareData): I didn't inline this method,
since the inlining slightly regressed performance for some reason.
(WebCore):

  • dom/Document.h:

(WebCore):
(WebCore::Document::cachedRareData):
(Document):
(~Document): Moved 'm_document = 0' to the tail of the destructor,
since isDocumentNode() has to return true in clearRareData() that is called
in ~Document().

  • dom/Node.cpp:

(WebCore::Node::ensureRareData):
(~Node): Moved the assertion into clearRareData().

11:24 PM Changeset in webkit [121411] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

Unreviewed. Fix the build without TEXTURE_MAPPER_GL.

  • WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
  • WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
  • WebProcess/WebPage/gtk/WebPageGtk.cpp:

(WebKit::WebPage::platformInitialize):

11:13 PM FeatureFlags edited by tkent@chromium.org
Add INPUT_TYPE_TIME_MULTIPLE_FIELDS (diff)
11:09 PM Changeset in webkit [121410] by mary.wu@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] 0-length response with no content-type shouldn't download
https://bugs.webkit.org/show_bug.cgi?id=89860

Reviewed by Rob Buis.

RIM PR# 168419

For 0-length response, if we can't get its mimetype from the filename,
we set the mimetype to "text/plain" instead of "application/octet-stream",
so it won't go to download.

Reviewed internally by Charles Wei.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::sendResponseIfNeeded):

10:36 PM Changeset in webkit [121409] by ryuan.choi@samsung.com
  • 3 edits
    8 deletes in trunk/Source/WebKit

Unreviewed, rolling out r121398.
http://trac.webkit.org/changeset/121398
https://bugs.webkit.org/show_bug.cgi?id=90136

broke efl build (Requested by ryuan on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-27

Source/WebKit:

  • PlatformEfl.cmake:

Source/WebKit/efl:

  • tests/UnitTestUtils/EWKTestBase.cpp: Removed.
  • tests/UnitTestUtils/EWKTestBase.h: Removed.
  • tests/UnitTestUtils/EWKTestConfig.h: Removed.
  • tests/UnitTestUtils/EWKTestView.cpp: Removed.
  • tests/UnitTestUtils/EWKTestView.h: Removed.
  • tests/resources/default_test_page.html: Removed.
  • tests/test_ewk_view.cpp: Removed.
  • tests/test_runner.cpp: Removed.
10:34 PM Changeset in webkit [121408] by commit-queue@webkit.org
  • 15 edits
    2 deletes in trunk/Source/WebKit/chromium

Unreviewed, rolling out r121405.
http://trac.webkit.org/changeset/121405
https://bugs.webkit.org/show_bug.cgi?id=90135

broke windows build (Requested by shawnsingh_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-27

  • WebKit.gypi:
  • WebKitUnitTests.gyp:
  • public/WebDOMMessageEvent.h:
  • tests/AssociatedURLLoaderTest.cpp:

(WebKit::AssociatedURLLoaderTest::AssociatedURLLoaderTest):
(WebKit::AssociatedURLLoaderTest::SetUp):
(WebKit::AssociatedURLLoaderTest::CheckMethodFails):
(WebKit::AssociatedURLLoaderTest::CheckHeaderFails):
(WebKit::AssociatedURLLoaderTest::CheckAccessControlHeaders):
(WebKit::TEST_F):

  • tests/EventListenerTest.cpp:
  • tests/FrameTestHelpers.cpp:

(WebKit::FrameTestHelpers::registerMockedURLLoad):
(FrameTestHelpers):
(WebKit::FrameTestHelpers::loadFrame):

  • tests/FrameTestHelpers.h:

(FrameTestHelpers):

  • tests/ListenerLeakTest.cpp:

(WebKit::ListenerLeakTest::RunTest):

  • tests/PopupMenuTest.cpp:

(WebKit::SelectPopupMenuTest::registerMockedURLLoad):
(WebKit::SelectPopupMenuTest::loadFrame):

  • tests/RunAllTests.cpp:
  • tests/URLTestHelpers.cpp: Removed.
  • tests/URLTestHelpers.h: Removed.
  • tests/WebFrameTest.cpp:

(WebKit::WebFrameTest::registerMockedHttpURLLoad):
(WebKit::WebFrameTest::registerMockedChromeURLLoad):
(WebKit::TEST_F):

  • tests/WebPageNewSerializerTest.cpp:

(WebKit::WebPageNewSerializeTest::registerMockedURLLoad):
(WebPageNewSerializeTest):
(WebKit::WebPageNewSerializeTest::setUpCSSTestPage):
(WebKit::WebPageNewSerializeTest::loadURLInTopFrame):
(WebKit::WebPageNewSerializeTest::resourceVectorContains):
(WebKit::TEST_F):

  • tests/WebPageSerializerTest.cpp:

(WebKit::WebPageSerializerTest::registerMockedURLLoad):
(WebKit::WebPageSerializerTest::loadURLInTopFrame):
(WebKit::WebPageSerializerTest::webVectorContains):
(WebKit::TEST_F):

  • tests/WebViewTest.cpp:

(WebKit::TEST_F):
(WebKit::WebViewTest::testAutoResize):
(WebKit::WebViewTest::testTextInputType):

10:17 PM Changeset in webkit [121407] by bfulgham@webkit.org
  • 2 edits in trunk/WebKitLibraries

[WinCairo] Unreviewed build correction. Accidentally turned on
CSS_FILTERS, which is not available in tree.

  • win/tools/vsprops/FeatureDefinesCairo.vsprops: Turn CSS_FILTERS

back off for WinCairo target.

10:15 PM Changeset in webkit [121406] by Csaba Osztrogonác
  • 8 edits in trunk/Tools

Unreviewed, rolling out r121363, r121367, r121384, and
r121390.
http://trac.webkit.org/changeset/121363
http://trac.webkit.org/changeset/121367
http://trac.webkit.org/changeset/121384
http://trac.webkit.org/changeset/121390
https://bugs.webkit.org/show_bug.cgi?id=90134

It broke debug NRWT on GTK and on Qt (Requested by Ossy_NIGHT
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-27

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort):
(ChromiumPort.init):
(ChromiumPort._check_file_exists):
(ChromiumPort.default_results_directory):
(ChromiumPort._driver_class):
(ChromiumPort._build_path):
(ChromiumPort._path_to_image_diff):

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:

(ChromiumLinuxPort.baseline_search_path):

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:

(ChromiumMacPort.baseline_search_path):

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumPortTest):

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:

(ChromiumWinPort.baseline_search_path):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort.init):
(WebKitPort._webcore_symbols_string):
(WebKitPort._skipped_tests_for_unsupported_features):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(TestWebKitPort._webcore_symbols_string):
(WebKitPortUnitTests.test_default_options):

10:00 PM Changeset in webkit [121405] by shawnsingh@chromium.org
  • 15 edits
    1 copy
    1 add in trunk/Source/WebKit/chromium

[chromium] Use WEBKIT_IMPLEMENTATION == 1 for webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=90094

Reviewed by James Robinson.

This patch adds the WEBKIT_IMPLEMENTATION = 1 define to
WebKitUnitTests.gyp. To get it to compile correctly, some string
and URL code was refactored and fixed.

  • WebKit.gypi:
  • WebKitUnitTests.gyp:
  • public/WebDOMMessageEvent.h:

(WebKit::WebDOMMessageEvent::WebDOMMessageEvent):

  • tests/AssociatedURLLoaderTest.cpp:
  • tests/EventListenerTest.cpp:
  • tests/FrameTestHelpers.cpp:

(WebKit::FrameTestHelpers::loadFrame):

  • tests/FrameTestHelpers.h:
  • tests/ListenerLeakTest.cpp:

(WebKit::ListenerLeakTest::RunTest):

  • tests/PopupMenuTest.cpp:
  • tests/RunAllTests.cpp:
  • tests/URLTestHelpers.cpp: Added.

(URLTestHelpers):
(WebKit::URLTestHelpers::registerMockedURLFromBaseURL):
(WebKit::URLTestHelpers::registerMockedURLLoad):

  • tests/URLTestHelpers.h: Copied from Source/WebKit/chromium/public/WebDOMMessageEvent.h.

(WebKit):
(URLTestHelpers):
(WebKit::URLTestHelpers::toKURL):

  • tests/WebFrameTest.cpp:
  • tests/WebPageNewSerializerTest.cpp:
  • tests/WebPageSerializerTest.cpp:
  • tests/WebViewTest.cpp:
9:58 PM Changeset in webkit [121404] by yosin@chromium.org
  • 9 edits in trunk/Source

[Platform] Implement localizedDecimalSeparator function
https://bugs.webkit.org/show_bug.cgi?id=90036

Reviewed by Kent Tamura.

Source/WebCore:

This patch introduces new function localizedDecimalSeparator() when
ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS). It will be used for
displaying millisecond for time fields UI.

Test: WebKit/chromium/tests/LocalizedNumberICUTest.cpp

  • platform/text/LocaleICU.cpp:

(WebCore::LocaleICU::localizedDecimalSeparator): Added

  • platform/text/LocaleICU.h:

(LocaleICU): Added localizedDecimalSeparator.

  • platform/text/LocalizedNumber.h:
  • platform/text/LocalizedNumberICU.cpp:

(WebCore::localizedDecimalSeparator): Added.

  • platform/text/LocalizedNumberNone.cpp:

(WebCore::localizedDecimalSeparator): Added.

  • platform/text/mac/LocalizedNumberMac.mm:

(WebCore::localizedDecimalSeparator): Added.

Source/WebKit/chromium:

This patch adds test case for localizedDecimalSeparator().

  • tests/LocalizedNumberICUTest.cpp:

(testDecimalSeparator):
(TEST):

9:49 PM Changeset in webkit [121403] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Add OVERRIDE to functions in UnthrottledTextureUploader class
https://bugs.webkit.org/show_bug.cgi?id=90130

Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-06-27
Reviewed by James Robinson.

No new tests required.

  • platform/graphics/chromium/LayerRendererChromium.cpp:
9:08 PM Changeset in webkit [121402] by bfulgham@webkit.org
  • 2 edits in trunk/WebKitLibraries

[WinCairo] Unreviewed build correction. Resync feature defines with
Apple port. Things have drifted apart a little.

  • win/tools/vsprops/FeatureDefinesCairo.vsprops: Update to match

Apple port, define some missing features.

8:58 PM Changeset in webkit [121401] by commit-queue@webkit.org
  • 5 edits in trunk

pattern="" should only accept the empty string
https://bugs.webkit.org/show_bug.cgi?id=89569

Patch by Pablo Flouret <pablof@motorola.com> on 2012-06-27
Reviewed by Kent Tamura.

Source/WebCore:

An empty pattern attribute was being treated essentially as if the
pattern wasn't present.

No new tests. Covered by existing tests (plus a modified one).

  • html/BaseTextInputType.cpp:

(WebCore::BaseTextInputType::patternMismatch):

Check if the pattern attribute is present. If it is then use the
pattern as is (in the particular case of this bug, an empty pattern
will only match an empty value).

LayoutTests:

  • fast/forms/ValidityState-patternMismatch-expected.txt:
  • fast/forms/ValidityState-patternMismatch.html:

Modified the test to check the results of an empty pattern both with an empty
value, and with some value specified.

8:33 PM Changeset in webkit [121400] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Selection overlay can become visible after it has been hidden
https://bugs.webkit.org/show_bug.cgi?id=90105

Patch by Andrew Lo <anlo@rim.com> on 2012-06-27
Reviewed by George Staikos.

When SelectionOverlay::hide is called from UI thread,
rather than setting the override opacity, dispatch to the
WebKit thread, which removes the overlay (normal case).

Internal PR164183.
Internally Reviewed by: Arvid Nilsson.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
(BlackBerry::WebKit::WebPage::selectionOverlay):

  • Api/WebPage_p.h:

(WebPagePrivate):

  • Api/WebSelectionOverlay.h:
  • WebKitSupport/SelectionOverlay.cpp:

(BlackBerry::WebKit::SelectionOverlay::SelectionOverlay):
(BlackBerry::WebKit::SelectionOverlay::hide):

  • WebKitSupport/SelectionOverlay.h:

(BlackBerry::WebKit::SelectionOverlay::create):
(SelectionOverlay):

8:22 PM Changeset in webkit [121399] by yosin@chromium.org
  • 1 edit
    6 copies in branches/chromium/1180

Merge 121019 - REGRESSION(r117738):[Forms] validationMessage IDL attribute should not have range overflow message if value isn't range overflow
https://bugs.webkit.org/show_bug.cgi?id=89736

Reviewed by Kent Tamura.

Source/WebCore:

Tests: fast/forms/date/input-date-validation-message.html

fast/forms/number/input-number-validation-message.html
fast/forms/range/input-range-validation-message.html

This patch changes comparison operator for range overflow message in
InputType::validationMessage().

  • html/InputType.cpp:

(WebCore::InputType::validationMessage):

LayoutTests:

Tests for HTMLInputElement.validationMessage attribute.

  • fast/forms/date/input-date-validation-message-expected.txt: Added.
  • fast/forms/date/input-date-validation-message.html: Added.
  • fast/forms/number/input-number-validation-message-expected.txt: Added.
  • fast/forms/number/input-number-validation-message.html: Added.
  • fast/forms/range/input-range-validation-message-expected.txt: Added.
  • fast/forms/range/input-range-validation-message.html: Added.

TBR=yosin@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10695026

7:17 PM Changeset in webkit [121398] by commit-queue@webkit.org
  • 3 edits
    11 adds in trunk/Source/WebKit

Source/WebKit: [EFL] Add support for Unit Tests, based on the gtest library.
https://bugs.webkit.org/show_bug.cgi?id=68509

Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-06-27
Reviewed by Chang Shu.

Add configuration for building gtest library, testing framework and unit tests.

  • PlatformEfl.cmake:

Source/WebKit/efl: [EFL] Implementation of testing framework and unit tests for WebKit-EFL port.
https://bugs.webkit.org/show_bug.cgi?id=68509

Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-06-27
Reviewed by Chang Shu.

Testing framework is based on gtest library. Gtest library is part of the WebKit project. Framework is devided into base part and view part.
Base part takes care of efl initialization, defines test macros and prepares test to run. View part is a context of each test.

  • tests/UnitTestUtils/EWKTestBase.cpp: Added.

(EWKUnitTests):
(EWKUnitTests::EWKTestBase::init):
(EWKUnitTests::EWKTestBase::shutdown):
(EWKUnitTests::EWKTestBase::shutdownAll):
(EWKUnitTests::EWKTestBase::startTest):
(EWKUnitTests::EWKTestBase::endTest):
(EWKUnitTests::EWKTestBase::createTest):
(EWKUnitTests::EWKTestBase::runTest):

  • tests/UnitTestUtils/EWKTestBase.h: Added.

(EWKUnitTests):
(EWKTestBase):

  • tests/UnitTestUtils/EWKTestConfig.h: Added.

(Config):

  • tests/UnitTestUtils/EWKTestView.cpp: Added.

(EWKUnitTests):
(EWKUnitTests::EWKTestEcoreEvas::EWKTestEcoreEvas):
(EWKUnitTests::EWKTestEcoreEvas::evas):
(EWKUnitTests::EWKTestEcoreEvas::show):
(EWKUnitTests::EWKTestView::EWKTestView):
(EWKUnitTests::EWKTestView::init):
(EWKUnitTests::EWKTestView::show):
(EWKUnitTests::EWKTestView::mainFrame):
(EWKUnitTests::EWKTestView::evas):
(EWKUnitTests::EWKTestView::bindEvents):

  • tests/UnitTestUtils/EWKTestView.h: Added.

(EWKUnitTests):
(EWKTestEcoreEvas):
(EWKTestView):
(EWKUnitTests::EWKTestView::webView):

  • tests/resources/default_test_page.html: Added.
  • tests/test_ewk_view.cpp: Added.

(ewkViewEditableGetCb):
(TEST):
(ewkViewUriGetCb):

  • tests/test_runner.cpp: Added.

(parseCustomArguments):
(main):

7:06 PM Changeset in webkit [121397] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Improve keyboardEvent() so a web page could receive a DOM3 spec compliant keyboard event.
https://bugs.webkit.org/show_bug.cgi?id=89637

Patch by Yusuke Sato <yusukes@chromium.org> on 2012-06-27
Reviewed by Tony Chang.

This is a Gtk port of http://crrev.com/142209.

Normalizes event->state to make it Windows/Mac compatible. Since the
way of setting modifier mask on X is very different than Windows/Mac
as shown in http://crbug.com/127142#c8, the normalization is necessary.

  • src/gtk/WebInputEventFactory.cpp:

(WebKit):
(WebKit::normalizeEventState):
(WebKit::WebInputEventFactory::keyboardEvent):

7:03 PM Changeset in webkit [121396] by jamesr@google.com
  • 25 edits in trunk/Source

[chromium] Use SkColor in compositor internals
https://bugs.webkit.org/show_bug.cgi?id=90108

Reviewed by Adrienne Walker.

Source/WebCore:

As the title says, cutting dependencies. If we support color spaces in the compositor we will probably need to
use a more sophisticated type, but for our current use SkColor is sufficient and matches our API better.

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setBackgroundColor):
(WebCore::LayerChromium::setDebugBorderColor):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):
(WebCore::LayerChromium::backgroundColor):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawDebugBorderQuad):
(WebCore::LayerRendererChromium::drawSolidColorQuad):

  • platform/graphics/chromium/cc/CCDebugBorderDrawQuad.cpp:

(WebCore::CCDebugBorderDrawQuad::create):
(WebCore::CCDebugBorderDrawQuad::CCDebugBorderDrawQuad):

  • platform/graphics/chromium/cc/CCDebugBorderDrawQuad.h:

(CCDebugBorderDrawQuad):
(WebCore::CCDebugBorderDrawQuad::color):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::setBackgroundColor):
(WebCore::CCLayerImpl::setDebugBorderColor):
(WebCore::CCLayerImpl::hasDebugBorders):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):
(WebCore::CCLayerImpl::backgroundColor):
(WebCore::CCLayerImpl::debugBorderColor):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeHost::setBackgroundColor):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore::CCLayerTreeHostImpl::backgroundColor):
(WebCore::CCLayerTreeHostImpl::setBackgroundColor):
(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCQuadCuller.cpp:

(WebCore::appendQuadInternal):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::appendQuadsToFillScreen):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(WebCore):
(CCRenderPass):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::appendQuads):

  • platform/graphics/chromium/cc/CCSolidColorDrawQuad.cpp:

(WebCore::CCSolidColorDrawQuad::create):
(WebCore::CCSolidColorDrawQuad::CCSolidColorDrawQuad):

  • platform/graphics/chromium/cc/CCSolidColorDrawQuad.h:

(CCSolidColorDrawQuad):
(WebCore::CCSolidColorDrawQuad::color):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::appendQuads):

Source/WebKit/chromium:

  • src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::setBackgroundColor):

  • tests/CCLayerImplTest.cpp:

(WebCore::TEST):

  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/CCSolidColorLayerImplTest.cpp:

(CCLayerTestCommon::TEST):

  • tests/LayerChromiumTest.cpp:
6:58 PM Changeset in webkit [121395] by charles.wei@torchmobile.com.cn
  • 13 edits in trunk/Source

IndexedDB: should make the LevelDB persistant to the directory indicated in PageGroupSettings::indexedDBDataBasePath
https://bugs.webkit.org/show_bug.cgi?id=88338

Reviewed by David Levin.

Source/WebCore:

If the indexedDB runs in main thread it can access the GroupSettings via the document;
otherwise, we need to pass the page GroupSettings to the worker thread so that accessible
to the indexedDB running in WorkerContext.

  • Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::open):

  • workers/DedicatedWorkerThread.cpp:

(WebCore::DedicatedWorkerThread::create):
(WebCore::DedicatedWorkerThread::DedicatedWorkerThread):

  • workers/DedicatedWorkerThread.h:

(DedicatedWorkerThread):

  • workers/DefaultSharedWorkerRepository.cpp:

(SharedWorkerProxy):
(WebCore::SharedWorkerProxy::groupSettings):
(WebCore):
(WebCore::DefaultSharedWorkerRepository::workerScriptLoaded):

  • workers/SharedWorkerThread.cpp:

(WebCore::SharedWorkerThread::create):
(WebCore::SharedWorkerThread::SharedWorkerThread):

  • workers/SharedWorkerThread.h:

(SharedWorkerThread):

  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::startWorkerContext):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThreadStartupData::create):
(WorkerThreadStartupData):
(WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
(WebCore::WorkerThread::WorkerThread):
(WebCore::WorkerThread::groupSettings):
(WebCore):

  • workers/WorkerThread.h:

(WorkerThread):

Source/WebKit/chromium:

  • src/WebSharedWorkerImpl.cpp:

(WebKit::WebSharedWorkerImpl::startWorkerContext):

  • src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::startWorkerContext):

6:14 PM Changeset in webkit [121394] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

[Win] jscore-tests flakey
https://bugs.webkit.org/show_bug.cgi?id=88118

Reviewed by Jessie Berlin.

jsDriver.pl on windows intermittently doesn't get the returned value from jsc,
instead it gets 126. Added a new option to jsc (-x) which prints the exit
code before exiting. jsDriver.pl uses this option on Windows and parses the
exit code output for the exit code, removing it before comparing the actual
and expected outputs. Filed a follow on "FIXME" defect:
[WIN] Intermittent failure for jsc return value to propagate through jsDriver.pl
https://bugs.webkit.org/show_bug.cgi?id=90119

  • jsc.cpp:

(CommandLine::CommandLine):
(CommandLine):
(printUsageStatement):
(parseArguments):
(jscmain):

  • tests/mozilla/jsDriver.pl:

(execute_tests):

6:09 PM Changeset in webkit [121393] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Unreviewed, rolling out r121359.
http://trac.webkit.org/changeset/121359
https://bugs.webkit.org/show_bug.cgi?id=90115

Broke many inspector tests (Requested by jpfau on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-27

Source/JavaScriptCore:

  • interpreter/Interpreter.h:

(JSC::StackFrame::toString):

Source/WebCore:

  • bindings/js/ScriptCallStackFactory.cpp:

(WebCore::createScriptCallStack):

6:05 PM Changeset in webkit [121392] by alexis.menard@openbossa.org
  • 11 edits
    2 adds in trunk

Implement selectedOptions attribute of HTMLSelectElement.
https://bugs.webkit.org/show_bug.cgi?id=80631

Reviewed by Ryosuke Niwa.

Source/WebCore:

Add a new collection as a member of HTMLSelectElement which is
used to store the selected elements. Extend HTMLCollection to
support the new collection type needed by this feature. Make sure
that we invalidate the collection when the select state of an
option changes as the select state change does not trigger a dom
tree version change.

Reference : http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html#dom-select-selectedoptions

Test: fast/dom/HTMLSelectElement/select-selectedOptions.html

  • html/CollectionType.h:
  • html/HTMLCollection.cpp:

(WebCore::shouldIncludeChildren):
(WebCore::HTMLCollection::clearCache):
(WebCore):
(WebCore::HTMLCollection::isAcceptableElement):

  • html/HTMLCollection.h:

(HTMLCollection):

  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::setSelectedState):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::selectedOptions):
(WebCore):
(WebCore::HTMLSelectElement::invalidateSelectedItems):
(WebCore::HTMLSelectElement::setRecalcListItems):

  • html/HTMLSelectElement.h:

(WebCore):
(HTMLSelectElement):

  • html/HTMLSelectElement.idl:

LayoutTests:

New tests to cover the feature.

  • fast/dom/HTMLSelectElement/select-selectedOptions-expected.txt: Added.
  • fast/dom/HTMLSelectElement/select-selectedOptions.html: Added.
  • fast/dom/htmlcollection-non-html-expected.txt:
  • fast/dom/htmlcollection-non-html.html:
5:49 PM Changeset in webkit [121391] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

Javascript SHA-512 gives wrong hash on second and subsequent runs unless Web Inspector Javascript Debugging is on
https://bugs.webkit.org/show_bug.cgi?id=90053
<rdar://problem/11764613>

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

The problem is that the code was assuming that the recovery should be Undefined if the source of
the SetLocal was !shouldGenerate(). But that's wrong, since the DFG optimizer may skip around a
UInt32ToNumber node (hence making it !shouldGenerate()) and keep the source of that node alive.
In that case we should base the recovery on the source of the UInt32ToNumber. The logic for this
was already in place but the fast check for !shouldGenerate() broke it.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

LayoutTests:

Reviewed by Mark Hahnenberg.

  • fast/js/dfg-uint32-to-number-skip-then-exit-expected.txt: Added.
  • fast/js/dfg-uint32-to-number-skip-then-exit.html: Added.
  • fast/js/script-tests/dfg-uint32-to-number-skip-then-exit.js: Added.

(foo):

5:48 PM Changeset in webkit [121390] by dpranke@chromium.org
  • 2 edits in trunk/Tools

Fix typo in r121384 :(

Unreviewed, build fix.

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort.default_test_timeout_ms):

5:32 PM Changeset in webkit [121389] by hclam@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

[chromium] Rebase image mismatch caused by 121371.

Rebase test results for:
platform/chromium/compositing/scrollbars/custom-composited-different-track-parts.html

Not reviewed.

  • platform/chromium-linux/platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.png: Added.
5:09 PM Changeset in webkit [121388] by dcheng@chromium.org
  • 5 edits
    2 adds in trunk

Fix crash in Frame::nodeImage.
https://bugs.webkit.org/show_bug.cgi?id=89911

Reviewed by Abhishek Arya.

Source/WebCore:

We were caching a pointer to a RenderObject and then calling updateLayout(). Instead, we
need to get a pointer to the RenderObject again after updateLayout().

Test: fast/events/drag-display-none-element.html

  • page/Frame.cpp:

(WebCore::Frame::nodeImage):

  • page/mac/FrameMac.mm:

(WebCore::Frame::snapshotDragImage):
(WebCore::Frame::nodeImage):

LayoutTests:

  • fast/events/drag-display-none-element-expected.txt: Added.
  • fast/events/drag-display-none-element.html: Added.
5:04 PM Changeset in webkit [121387] by tony@chromium.org
  • 18 edits
    2 deletes in trunk

Unreviewed, rolling out r121380.
http://trac.webkit.org/changeset/121380
https://bugs.webkit.org/show_bug.cgi?id=86525

Hits an ASSERT in debug.

Source/WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFlex):

  • css/CSSParser.h:
  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/StyleBuilder.cpp:

(ApplyPropertyFlex):
(WebCore::ApplyPropertyFlex::applyInheritValue):
(WebCore::ApplyPropertyFlex::applyInitialValue):
(WebCore::ApplyPropertyFlex::applyValue):
(WebCore::ApplyPropertyFlex::createHandler):
(WebCore::ApplyPropertyFlex::getFlexValue):
(WebCore):
(WebCore::StyleBuilder::StyleBuilder):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getPropertyValue):
(WebCore::StylePropertySet::asText):

  • css/StylePropertyShorthand.cpp:

(WebCore::webkitFlexFlowShorthand):
(WebCore::shorthandForProperty):

  • css/StylePropertyShorthand.h:

(WebCore):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

LayoutTests:

  • css3/flexbox/flex-longhand-parsing-expected.txt: Removed.
  • css3/flexbox/flex-longhand-parsing.html: Removed.
  • css3/flexbox/flex-property-parsing-expected.txt:
  • css3/flexbox/flex-property-parsing.html:
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/css/getComputedStyle/resources/property-names.js:
  • svg/css/getComputedStyle-basic-expected.txt:
4:53 PM Changeset in webkit [121386] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

HTMLFieldSetElement::m_documentVersion is not initialized
https://bugs.webkit.org/show_bug.cgi?id=90038

Patch by Rakesh KN <rakesh.kn@motorola.com> on 2012-06-27
Reviewed by Kent Tamura.

Initialised m_documentVersion member as HTMLFieldSetElement::elements can return an wrong collection.

Covered by existing tests.

  • html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::HTMLFieldSetElement):
Initialised m_documentVersion.

4:50 PM Changeset in webkit [121385] by jpfau@apple.com
  • 2 edits in trunk/LayoutTests

[Mac] Fix test expectation introduced in r121299

Unreviewed.

  • platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt:
4:49 PM Changeset in webkit [121384] by dpranke@chromium.org
  • 4 edits in trunk/Tools

nrwt: default timeout for debug bots broke in r121363
https://bugs.webkit.org/show_bug.cgi?id=90112

Unreviewed, build fix.

I forgot to account for release and debug having different
default values :(.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.default_test_timeout_ms):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort):
(WebKitPort.default_test_timeout_ms):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(WebKitPortUnitTests.test_default_options):

4:27 PM Changeset in webkit [121383] by hclam@chromium.org
  • 1 edit
    6 adds in trunk/LayoutTests

[chromium] Rebase image mismatch caused by 121371.

Rebase test results for:
platform/chromium/compositing/scrollbars/custom-composited-different-track-parts.html

Not reviewed.

  • platform/chromium-mac-snowleopard/platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.png: Added.
  • platform/chromium-mac/platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.png: Added.
  • platform/chromium-win/platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.png: Added.
4:16 PM Changeset in webkit [121382] by fpizlo@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

DFG disassembly should be easier to read
https://bugs.webkit.org/show_bug.cgi?id=90106

Reviewed by Mark Hahnenberg.

Did a few things:

  • Options::showDFGDisassembly now shows OSR exit disassembly as well.


  • Phi node dumping doesn't attempt to do line wrapping since it just made the dump harder to read.


  • DFG graph disassembly view shows a few additional node types that turn out to be essential for understanding OSR exits.


Put together, these changes reinforce the philosophy that anything needed for computing
OSR exit is just as important as the machine code itself. Of course, we still don't take
that philosophy to its full extreme - for example Phantom nodes are not dumped. We may
revisit that in the future.

  • assembler/LinkBuffer.cpp:

(JSC::LinkBuffer::finalizeCodeWithDisassembly):

  • assembler/LinkBuffer.h:

(JSC):

  • dfg/DFGDisassembler.cpp:

(JSC::DFG::Disassembler::dump):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dumpBlockHeader):

  • dfg/DFGNode.h:

(JSC::DFG::Node::willHaveCodeGenOrOSR):

  • dfg/DFGOSRExitCompiler.cpp:
  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

4:08 PM Changeset in webkit [121381] by mhahnenberg@apple.com
  • 122 edits in trunk/Source

JSLock should be per-JSGlobalData
https://bugs.webkit.org/show_bug.cgi?id=89123

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • API/APIShims.h:

(APIEntryShimWithoutLock):
(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock): Added an extra parameter to the constructor to
determine whether we should ref the JSGlobalData or not. We want to ref all the time except for in the
HeapTimer class because timerDidFire could run after somebody has started to tear down that particular
JSGlobalData, so we wouldn't want to resurrect the ref count of that JSGlobalData from 0 back to 1 after
its destruction has begun.
(JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock):
(JSC::APIEntryShim::APIEntryShim):
(APIEntryShim):
(JSC::APIEntryShim::~APIEntryShim):
(JSC::APIEntryShim::init): Factored out common initialization code for the various APIEntryShim constructors.
Also moved the timeoutChecker stop and start here because we need to start after we've grabbed the API lock
and before we've released it, which can only done in APIEntryShim.
(JSC::APICallbackShim::~APICallbackShim): We no longer need to synchronize here.

  • API/JSContextRef.cpp:

(JSGlobalContextCreate):
(JSGlobalContextCreateInGroup):
(JSGlobalContextRelease):
(JSContextCreateBacktrace):

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • heap/CopiedSpace.cpp:

(JSC::CopiedSpace::tryAllocateSlowCase):

  • heap/Heap.cpp:

(JSC::Heap::protect):
(JSC::Heap::unprotect):
(JSC::Heap::collect):
(JSC::Heap::setActivityCallback):
(JSC::Heap::activityCallback):
(JSC::Heap::sweeper):

  • heap/Heap.h: Changed m_activityCallback and m_sweeper to be raw pointers rather than OwnPtrs because they

are now responsible for their own lifetime. Also changed the order of declaration of the GCActivityCallback
and the IncrementalSweeper to make sure they're the last things that get initialized during construction to
prevent any issues with uninitialized memory in the JSGlobalData/Heap they might care about.
(Heap):

  • heap/HeapTimer.cpp: Refactored to allow for thread-safe operation and shutdown.

(JSC::HeapTimer::~HeapTimer):
(JSC::HeapTimer::invalidate):
(JSC):
(JSC::HeapTimer::didStartVMShutdown): Called at the beginning of ~JSGlobalData. If we're on the same thread
that the HeapTimer is running on, we kill the HeapTimer ourselves. If not, then we set some state in the
HeapTimer and schedule it to fire immediately so that it can notice and kill itself.
(JSC::HeapTimer::timerDidFire): We grab our mutex and check our JSGlobalData pointer. If it has been zero-ed
out, then we know the VM has started to shutdown and we should kill ourselves. Otherwise, grab the APIEntryShim,
but without ref-ing the JSGlobalData (we don't want to bring the JSGlobalData's ref-count from 0 to 1) in case
we were interrupted between releasing our mutex and trying to grab the APILock.

  • heap/HeapTimer.h:

(HeapTimer):

  • heap/IncrementalSweeper.cpp:

(JSC::IncrementalSweeper::doWork): We no longer need the API shim here since HeapTimer::timerDidFire handles
all of that for us.
(JSC::IncrementalSweeper::create):

  • heap/IncrementalSweeper.h:

(IncrementalSweeper):

  • heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::allocateSlowCase):

  • heap/WeakBlock.cpp:

(JSC::WeakBlock::reap):

  • jsc.cpp:

(functionGC):
(functionReleaseExecutableMemory):
(jscmain):

  • runtime/Completion.cpp:

(JSC::checkSyntax):
(JSC::evaluate):

  • runtime/GCActivityCallback.h:

(DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::create):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData): Signals to the two HeapTimers (GCActivityCallback and IncrementalSweeper)
that the VM has started shutting down. It then waits until the HeapTimer is done with whatever activity
it needs to do before continuing with any further destruction. Also asserts that we do not currently hold the
APILock because this could potentially cause deadlock when we try to signal to the HeapTimers using their mutexes.
(JSC::JSGlobalData::sharedInstance): Protect the initialization for the shared instance with the GlobalJSLock.
(JSC::JSGlobalData::sharedInstanceInternal):

  • runtime/JSGlobalData.h: Change to be ThreadSafeRefCounted so that we don't have to worry about refing and

de-refing JSGlobalDatas on separate threads since we don't do it that often anyways.
(JSGlobalData):
(JSC::JSGlobalData::apiLock):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::~JSGlobalObject):
(JSC::JSGlobalObject::init):

  • runtime/JSLock.cpp:

(JSC):
(JSC::GlobalJSLock::GlobalJSLock): For accessing the shared instance.
(JSC::GlobalJSLock::~GlobalJSLock):
(JSC::JSLockHolder::JSLockHolder): MutexLocker for JSLock. Also refs the JSGlobalData to keep it alive so that
it can successfully unlock it later without it disappearing from underneath it.
(JSC::JSLockHolder::~JSLockHolder):
(JSC::JSLock::JSLock):
(JSC::JSLock::~JSLock):
(JSC::JSLock::lock): Uses the spin lock for guarding the lock count and owner thread fields. Uses the mutex for
actually waiting for long periods.
(JSC::JSLock::unlock):
(JSC::JSLock::currentThreadIsHoldingLock):
(JSC::JSLock::dropAllLocks):
(JSC::JSLock::dropAllLocksUnconditionally):
(JSC::JSLock::grabAllLocks):
(JSC::JSLock::DropAllLocks::DropAllLocks):
(JSC::JSLock::DropAllLocks::~DropAllLocks):

  • runtime/JSLock.h:

(JSC):
(GlobalJSLock):
(JSLockHolder):
(JSLock):
(DropAllLocks):

  • runtime/WeakGCMap.h:

(JSC::WeakGCMap::set):

  • testRegExp.cpp:

(realMain):

Source/WebCore:

No new tests. Current regression tests are sufficient.

Changed all sites that used JSLock to instead use the new JSLockHolder
and pass in the correct JS context that the code is about to interact with that
needs protection. Also added a couple JSLocks to places that didn't already
have it that needed it.

  • bindings/js/GCController.cpp:

(WebCore::collect):
(WebCore::GCController::garbageCollectSoon):
(WebCore::GCController::garbageCollectNow):
(WebCore::GCController::discardAllCompiledCode):

  • bindings/js/JSCustomSQLStatementErrorCallback.cpp:

(WebCore::JSSQLStatementErrorCallback::handleEvent):

  • bindings/js/JSCustomVoidCallback.cpp:

(WebCore::JSCustomVoidCallback::handleEvent):

  • bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):

  • bindings/js/JSErrorHandler.cpp:

(WebCore::JSErrorHandler::handleEvent):

  • bindings/js/JSEventCustom.cpp:

(WebCore::toJS):

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::InjectedScriptHost::nodeAsScriptValue):
(WebCore::JSInjectedScriptHost::inspectedObject):

  • bindings/js/JSInjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::createInjectedScript):
(WebCore::InjectedScriptManager::canAccessInspectedWindow):

  • bindings/js/JSLazyEventListener.cpp:

(WebCore::JSLazyEventListener::initializeJSFunction):

  • bindings/js/JSMainThreadExecState.h:

(WebCore::JSMainThreadExecState::evaluate):

  • bindings/js/JSMutationCallbackCustom.cpp:

(WebCore::JSMutationCallback::handleEvent):

  • bindings/js/JSNodeFilterCondition.cpp:

(WebCore::JSNodeFilterCondition::acceptNode):

  • bindings/js/JSRequestAnimationFrameCallbackCustom.cpp:

(WebCore::JSRequestAnimationFrameCallback::handleEvent):

  • bindings/js/JavaScriptCallFrame.cpp:

(WebCore::JavaScriptCallFrame::evaluate):

  • bindings/js/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::recompileAllJSFunctions):

  • bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::executeFunctionInContext):

  • bindings/js/ScriptCachedFrameData.cpp:

(WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::restore):
(WebCore::ScriptCachedFrameData::clear):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::evaluateInWorld):
(WebCore::ScriptController::clearWindowShell):
(WebCore::ScriptController::initScript):
(WebCore::ScriptController::updateDocument):
(WebCore::ScriptController::cacheableBindingRootObject):
(WebCore::ScriptController::bindingRootObject):
(WebCore::ScriptController::windowScriptNPObject):
(WebCore::ScriptController::jsObjectForPluginElement):
(WebCore::ScriptController::clearScriptObjects):

  • bindings/js/ScriptControllerMac.mm:

(WebCore::ScriptController::windowScriptObject):

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::dispatchDidPause):

  • bindings/js/ScriptEventListener.cpp:

(WebCore::eventListenerHandlerBody):
(WebCore::eventListenerHandlerLocation):

  • bindings/js/ScriptFunctionCall.cpp:

(WebCore::ScriptCallArgumentHandler::appendArgument):
(WebCore::ScriptFunctionCall::call):
(WebCore::ScriptFunctionCall::construct):
(WebCore::ScriptCallback::call):

  • bindings/js/ScriptObject.cpp:

(WebCore::ScriptGlobalObject::set):
(WebCore::ScriptGlobalObject::get):
(WebCore::ScriptGlobalObject::remove):

  • bindings/js/ScriptValue.cpp:

(WebCore::ScriptValue::getString):
(WebCore::ScriptValue::toInspectorValue):

  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::~WorkerScriptController):
(WebCore::WorkerScriptController::initScript):
(WebCore::WorkerScriptController::evaluate):
(WebCore::WorkerScriptController::disableEval):

  • bindings/objc/WebScriptObject.mm:

(_didExecute):
(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject evaluateWebScript:]):
(-[WebScriptObject setValue:forKey:]):
(-[WebScriptObject valueForKey:]):
(-[WebScriptObject removeWebScriptKey:]):
(-[WebScriptObject hasWebScriptKey:]):
(-[WebScriptObject stringRepresentation]):
(-[WebScriptObject webScriptValueAtIndex:]):
(-[WebScriptObject setWebScriptValueAtIndex:value:]):
(+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateCallbackImplementation):

  • bindings/scripts/test/JS/JSTestCallback.cpp:

(WebCore::JSTestCallback::callbackWithNoParam):
(WebCore::JSTestCallback::callbackWithClass1Param):
(WebCore::JSTestCallback::callbackWithClass2Param):
(WebCore::JSTestCallback::callbackWithStringList):
(WebCore::JSTestCallback::callbackWithBoolean):
(WebCore::JSTestCallback::callbackRequiresThisToPass):

  • bridge/NP_jsobject.cpp:

(_NPN_InvokeDefault):
(_NPN_Invoke):
(_NPN_Evaluate):
(_NPN_GetProperty):
(_NPN_SetProperty):
(_NPN_RemoveProperty):
(_NPN_HasProperty):
(_NPN_HasMethod):
(_NPN_Enumerate):
(_NPN_Construct):

  • bridge/c/c_class.cpp:

(JSC::Bindings::CClass::~CClass):
(JSC::Bindings::CClass::methodsNamed):
(JSC::Bindings::CClass::fieldNamed):

  • bridge/c/c_instance.cpp:

(JSC::Bindings::CInstance::moveGlobalExceptionToExecState):
(JSC::Bindings::CInstance::invokeMethod):
(JSC::Bindings::CInstance::invokeDefaultMethod):
(JSC::Bindings::CInstance::invokeConstruct):
(JSC::Bindings::CInstance::getPropertyNames):

  • bridge/c/c_runtime.cpp:

(JSC::Bindings::CField::valueFromInstance):
(JSC::Bindings::CField::setValueToInstance):

  • bridge/c/c_utility.cpp:

(JSC::Bindings::convertValueToNPVariant):
(JSC::Bindings::convertNPVariantToValue):

  • bridge/jni/jni_jsobject.mm:

(JavaJSObject::call):
(JavaJSObject::eval):
(JavaJSObject::getMember):
(JavaJSObject::setMember):
(JavaJSObject::removeMember):
(JavaJSObject::getSlot):
(JavaJSObject::setSlot):
(JavaJSObject::toString):
(JavaJSObject::convertValueToJObject):
(JavaJSObject::convertJObjectToValue):

  • bridge/jni/jni_objc.mm:

(JSC::Bindings::dispatchJNICall):

  • bridge/jni/jsc/JNIUtilityPrivate.cpp:

(JSC::Bindings::convertValueToJValue):

  • bridge/jni/jsc/JavaClassJSC.cpp:

(JavaClass::JavaClass):
(JavaClass::~JavaClass):

  • bridge/jni/jsc/JavaInstanceJSC.cpp:

(JavaInstance::stringValue):

  • bridge/jni/jsc/JavaMethodJSC.cpp:

(appendClassName):
(JavaMethod::signature):

  • bridge/jni/jsc/JavaStringJSC.h:

(JSC::Bindings::JavaString::JavaString):
(JSC::Bindings::JavaString::~JavaString):
(JSC::Bindings::JavaString::utf8):
(JSC::Bindings::JavaString::init):

  • bridge/jsc/BridgeJSC.cpp:

(JSC::Bindings::Instance::createRuntimeObject):
(JSC::Bindings::Instance::newRuntimeObject):

  • bridge/objc/objc_instance.mm:

(ObjcInstance::moveGlobalExceptionToExecState):
(ObjcInstance::invokeObjcMethod):
(ObjcInstance::invokeDefaultMethod):
(ObjcInstance::setValueOfUndefinedField):
(ObjcInstance::getValueOfUndefinedField):

  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcField::valueFromInstance):
(JSC::Bindings::ObjcField::setValueToInstance):

  • bridge/objc/objc_utility.mm:

(JSC::Bindings::convertValueToObjcValue):
(JSC::Bindings::convertNSStringToString):
(JSC::Bindings::convertObjcValueToValue):

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtInstance::~QtInstance):
(JSC::Bindings::QtInstance::getQtInstance):
(JSC::Bindings::QtInstance::newRuntimeObject):

  • bridge/qt/qt_pixmapruntime.cpp:

(JSC::Bindings::QtPixmapInstance::createPixmapRuntimeObject):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue):
(JSC::Bindings::QtRuntimeMetaMethod::call):
(JSC::Bindings::QtRuntimeConnectionMethod::call):

  • bridge/qt/qt_runtime_qt4.cpp:

(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue):
(JSC::Bindings::QtRuntimeMetaMethod::call):
(JSC::Bindings::QtRuntimeConnectionMethod::call):

  • bridge/runtime_root.cpp:

(JSC::Bindings::RootObject::gcProtect):
(JSC::Bindings::RootObject::gcUnprotect):

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::createImageBuffer):

  • html/HTMLImageLoader.cpp:

(WebCore::HTMLImageLoader::notifyFinished):

  • plugins/PluginView.cpp:

(WebCore::PluginView::start):
(WebCore::PluginView::stop):
(WebCore::PluginView::performRequest):
(WebCore::PluginView::npObject):
(WebCore::PluginView::privateBrowsingStateChanged):

  • plugins/blackberry/PluginViewBlackBerry.cpp:

(WebCore::PluginView::dispatchNPEvent):
(WebCore::PluginView::setNPWindowIfNeeded):
(WebCore::PluginView::platformStart):
(WebCore::PluginView::getWindowInfo):

  • plugins/efl/PluginViewEfl.cpp:

(WebCore::PluginView::dispatchNPEvent):

  • plugins/gtk/PluginViewGtk.cpp:

(WebCore::PluginView::dispatchNPEvent):
(WebCore::PluginView::handleKeyboardEvent):
(WebCore::PluginView::handleMouseEvent):
(WebCore::PluginView::setNPWindowIfNeeded):
(WebCore::PluginView::platformStart):

  • plugins/mac/PluginViewMac.mm:

(WebCore::PluginView::setNPWindowIfNeeded):
(WebCore::PluginView::dispatchNPEvent):

  • plugins/qt/PluginViewQt.cpp:

(WebCore::PluginView::dispatchNPEvent):
(WebCore::PluginView::setNPWindowIfNeeded):
(WebCore::PluginView::platformStart):

  • plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::dispatchNPEvent):
(WebCore::PluginView::handleKeyboardEvent):
(WebCore::PluginView::handleMouseEvent):
(WebCore::PluginView::setNPWindowRect):

  • testing/js/WebCoreTestSupport.cpp:

(WebCoreTestSupport::injectInternalsObject):
(WebCoreTestSupport::resetInternalsObject):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::dropProtection):

Source/WebKit/blackberry:

Changed all sites that used JSLock to instead use the new JSLockHolder
and pass in the correct JS context that the code is about to interact with that
needs protection. Also added a couple JSLocks to places that didn't already
have it that needed it.

  • Api/BlackBerryGlobal.cpp:

(BlackBerry::WebKit::clearMemoryCaches):

  • WebCoreSupport/ClientExtension.cpp:
  • WebCoreSupport/PagePopupBlackBerry.cpp:

(WebCore::PagePopupBlackBerry::installDomFunction):

  • WebKitSupport/DumpRenderTreeSupport.cpp:

(DumpRenderTreeSupport::computedStyleIncludingVisitedInfo):

Source/WebKit/efl:

Changed all sites that used JSLock to instead use the new JSLockHolder
and pass in the correct JS context that the code is about to interact with that
needs protection. Also added a couple JSLocks to places that didn't already
have it that needed it.

  • ewk/ewk_frame.cpp:

(ewk_frame_script_execute):

  • ewk/ewk_view.cpp:

(ewk_view_js_object_add):

Source/WebKit/gtk:

Changed all sites that used JSLock to instead use the new JSLockHolder
and pass in the correct JS context that the code is about to interact with that
needs protection. Also added a couple JSLocks to places that didn't already
have it that needed it.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::gcCountJavascriptObjects):

Source/WebKit/mac:

Changed all sites that used JSLock to instead use the new JSLockHolder
and pass in the correct JS context that the code is about to interact with that
needs protection. Also added a couple JSLocks to places that didn't already
have it that needed it.

  • DOM/WebDOMOperations.mm:

(JSC):

  • Misc/WebCoreStatistics.mm:

(+[WebCoreStatistics javaScriptObjectsCount]):
(+[WebCoreStatistics javaScriptGlobalObjectsCount]):
(+[WebCoreStatistics javaScriptProtectedObjectsCount]):
(+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
(+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
(+[WebCoreStatistics javaScriptObjectTypeCounts]):
(+[WebCoreStatistics shouldPrintExceptions]):
(+[WebCoreStatistics setShouldPrintExceptions:]):
(+[WebCoreStatistics memoryStatistics]):
(+[WebCoreStatistics javaScriptReferencedObjectsCount]):

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::evaluate):
(WebKit::NetscapePluginInstanceProxy::invoke):
(WebKit::NetscapePluginInstanceProxy::invokeDefault):
(WebKit::NetscapePluginInstanceProxy::construct):
(WebKit::NetscapePluginInstanceProxy::getProperty):
(WebKit::NetscapePluginInstanceProxy::setProperty):
(WebKit::NetscapePluginInstanceProxy::removeProperty):
(WebKit::NetscapePluginInstanceProxy::hasMethod):
(WebKit::NetscapePluginInstanceProxy::enumerate):
(WebKit::NetscapePluginInstanceProxy::addValueToArray):
(WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):

  • Plugins/WebNetscapePluginStream.mm:

(WebNetscapePluginStream::wantsAllStreams):

  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView sendEvent:isDrawRect:]):
(-[WebNetscapePluginView privateBrowsingModeDidChange]):
(-[WebNetscapePluginView setWindowIfNecessary]):
(-[WebNetscapePluginView createPluginScriptableObject]):
(-[WebNetscapePluginView getFormValue:]):
(-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
(-[WebNetscapePluginView webFrame:didFinishLoadWithReason:]):
(-[WebNetscapePluginView loadPluginRequest:]):
(-[WebNetscapePluginView _printedPluginBitmap]):

  • Plugins/WebPluginController.mm:

(+[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
(-[WebPluginController stopOnePlugin:]):
(-[WebPluginController destroyOnePlugin:]):
(-[WebPluginController startAllPlugins]):
(-[WebPluginController addPlugin:]):

  • WebView/WebFrame.mm:

(-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
(-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):

  • WebView/WebScriptDebugDelegate.mm:

(-[WebScriptCallFrame scopeChain]):
(-[WebScriptCallFrame evaluateWebScript:]):

  • WebView/WebView.mm:

(+[WebView _reportException:inContext:]):
(-[WebView aeDescByEvaluatingJavaScriptFromString:]):
(-[WebView _computedStyleIncludingVisitedInfo:forElement:]):

Source/WebKit/qt:

Changed all sites that used JSLock to instead use the new JSLockHolder
and pass in the correct JS context that the code is about to interact with that
needs protection. Also added a couple JSLocks to places that didn't already
have it that needed it.

  • Api/qwebframe.cpp:

(QWebFramePrivate::addQtSenderToGlobalObject):
(QWebFrame::addToJavaScriptWindowObject):

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::injectInternalsObject):
(DumpRenderTreeSupportQt::resetInternalsObject):

Source/WebKit/win:

Changed all sites that used JSLock to instead use the new JSLockHolder
and pass in the correct JS context that the code is about to interact with that
needs protection. Also added a couple JSLocks to places that didn't already
have it that needed it.

  • WebCoreStatistics.cpp:

(WebCoreStatistics::javaScriptObjectsCount):
(WebCoreStatistics::javaScriptGlobalObjectsCount):
(WebCoreStatistics::javaScriptProtectedObjectsCount):
(WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
(WebCoreStatistics::javaScriptProtectedObjectTypeCounts):

  • WebFrame.cpp:

(WebFrame::stringByEvaluatingJavaScriptInScriptWorld):

  • WebJavaScriptCollector.cpp:

(WebJavaScriptCollector::objectCount):

  • WebView.cpp:

(WebView::stringByEvaluatingJavaScriptFromString):
(WebView::reportException):
(WebView::elementFromJS):

Source/WebKit2:

Changed all sites that used JSLock to instead use the new JSLockHolder
and pass in the correct JS context that the code is about to interact with that
needs protection. Also added a couple JSLocks to places that didn't already
have it that needed it.

  • Shared/mac/WebMemorySampler.mac.mm:

(WebKit::WebMemorySampler::sampleWebKit):

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::javaScriptObjectsCount):
(WebKit::InjectedBundle::reportException):

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::callMethod):
(WebKit::JSNPObject::callObject):
(WebKit::JSNPObject::callConstructor):
(WebKit::JSNPObject::put):
(WebKit::JSNPObject::deleteProperty):
(WebKit::JSNPObject::getOwnPropertyNames):
(WebKit::JSNPObject::propertyGetter):

  • WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::hasMethod):
(WebKit::NPJSObject::invoke):
(WebKit::NPJSObject::invokeDefault):
(WebKit::NPJSObject::hasProperty):
(WebKit::NPJSObject::getProperty):
(WebKit::NPJSObject::setProperty):
(WebKit::NPJSObject::removeProperty):
(WebKit::NPJSObject::enumerate):
(WebKit::NPJSObject::construct):

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant):
(WebKit::NPRuntimeObjectMap::evaluate):
(WebKit::NPRuntimeObjectMap::moveGlobalExceptionToExecState):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::jsWrapperForWorld):
(WebKit::WebFrame::computedStyleIncludingVisitedInfo):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::runJavaScriptInMainFrame):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::getWebCoreStatistics):

4:05 PM Changeset in webkit [121380] by tony@chromium.org
  • 18 edits
    2 adds in trunk

Split flex into flex-grow/flex-shrink/flex-basis
https://bugs.webkit.org/show_bug.cgi?id=86525

Reviewed by Ojan Vafai.

Source/WebCore:

Split flex into 3 separate properties per the spec:
http://dev.w3.org/csswg/css3-flexbox/#flex-components

Tests: css3/flexbox/flex-longhand-parsing.html

css3/flexbox/flex-property-parsing.html: Updated test results.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore): -webkit-flex is no longer enumerable.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Add new css property names and use
getCSSPropertyValuesForShorthandProperties for WebkitFlex. Also sort flex propery names.

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue): Fix indent.
(WebCore::CSSParser::parseValue): Add parsing for new properties and handle -webkit-flex: none.
(WebCore::CSSParser::parseFlex): Switch to new names (positive -> grow, negative -> shrink,
preferred size -> basis) and assign to longhand properties.

  • css/CSSParser.h:
  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty): Add new properties.

  • css/CSSPropertyNames.in: Add new properties.
  • css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder): Delete special handling of applying flex and just use shorthand handlers.

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getPropertyValue): Add new shorthand.
(WebCore::StylePropertySet::asText):

  • css/StylePropertyShorthand.cpp:

(WebCore::webkitFlexShorthand): Add new shorthand.
(WebCore::shorthandForProperty):

  • css/StylePropertyShorthand.h:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList): Add to list of properties applied by StyleBuilder.

LayoutTests:

If -webkit-flex is set to none, when the user reads the value back out, it is
now 0 0 auto. 'none' is for convenience, not an actual value.

  • css3/flexbox/flex-longhand-parsing-expected.txt:
  • css3/flexbox/flex-longhand-parsing.html: Test flex-grow, flex-shrink and flex-basis.
  • css3/flexbox/flex-property-parsing-expected.txt:
  • css3/flexbox/flex-property-parsing.html: Update results for 'none'.
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/css/getComputedStyle/resources/property-names.js: Remove -webkit-flex since it's no longer enumerable.
  • svg/css/getComputedStyle-basic-expected.txt:
3:51 PM Changeset in webkit [121379] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Make Element::elementRareData() and Element::ensureElementRareData() private
https://bugs.webkit.org/show_bug.cgi?id=90060

Reviewed by Andreas Kling.

This is a simple refactoring. Element::elementRareData() and
Element::ensureElementRareData() can be private methods.

No tests. No change in behavior.

  • dom/Element.h:

(Element):

3:16 PM Changeset in webkit [121378] by jamesr@google.com
  • 13 edits in trunk/Source/WebCore

[chromium] Delete unused includes and forward declarations from compositor code
https://bugs.webkit.org/show_bug.cgi?id=90102

Reviewed by Adrienne Walker.

  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:
  • platform/graphics/chromium/CanvasLayerTextureUpdater.cpp:
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp:
  • platform/graphics/chromium/LayerChromium.cpp:
  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:
  • platform/graphics/chromium/ShaderChromium.h:
  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp:
  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::updateTiles):

  • platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:
3:13 PM Changeset in webkit [121377] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

IndexedDB: make IDBKey immutable
https://bugs.webkit.org/show_bug.cgi?id=90016

Patch by Alec Flett <alecflett@chromium.org> on 2012-06-27
Reviewed by Tony Chang.

Make all members of IDBKey const, so that this can be considered
an immutable, and thus safe to copy and/or stop ref-counting.

No new tests, existing tests show this works.

  • Modules/indexeddb/IDBKey.cpp:

(WebCore::IDBKey::compare):

  • Modules/indexeddb/IDBKey.h:

(WebCore::IDBKey::createInvalid):
(WebCore::IDBKey::createNumber):
(WebCore::IDBKey::createString):
(WebCore::IDBKey::createDate):
(WebCore::IDBKey::createMultiEntryArray):
(WebCore::IDBKey::createArray):
(WebCore::IDBKey::date):
(WebCore::IDBKey::IDBKey):
(IDBKey):

3:00 PM Changeset in webkit [121376] by arv@chromium.org
  • 4 edits
    7 adds in trunk

[V8] Improve variable resolution order on window
https://bugs.webkit.org/show_bug.cgi?id=84247

Reviewed by Ojan Vafai.

This changes the V8 flag to turn on es52_globals and updates the layout tests to reflect the fixed behavior.

This is the second (third?) try. Last time there was a bug in the V8 code related to the split window.
I added a test that tests the failure that caused this to be rolled back last time.

Source/WebCore:

Tests: fast/dom/Window/es52-globals.html

fast/dom/Window/window-property-shadowing-onclick.html

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initContextIfNeeded):

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::initIsolate):

LayoutTests:

  • fast/dom/Window/es52-globals-expected.txt: Added.
  • fast/dom/Window/es52-globals.html: Added.
  • fast/dom/Window/window-property-shadowing-onclick-expected.txt: Added.
  • fast/dom/Window/window-property-shadowing-onclick.html: Added.
  • platform/chromium/fast/dom/Window/es52-globals-expected.txt: Added.
  • platform/chromium/fast/dom/Window/window-property-shadowing-name-expected.txt: Added.
  • platform/chromium/fast/dom/Window/window-property-shadowing-onclick-expected.txt: Added.
2:50 PM Changeset in webkit [121375] by jamesr@google.com
  • 10 edits in trunk/Source/WebCore

[chromium] Use categorized TRACE_EVENTN() macros in compositor code
https://bugs.webkit.org/show_bug.cgi?id=90100

Reviewed by Adrienne Walker.

Specify the category in all traces in the compositor. Patch generated mostly by the sed command
's/TRACE_EVENT(\(.*\), this, 0)/TRACE_EVENT0("cc", \1)/'.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::beginDrawingFrame):
(WebCore::LayerRendererChromium::finish):
(WebCore::LayerRendererChromium::swapBuffers):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::tileCheckerboardProgram):
(WebCore::LayerRendererChromium::solidColorProgram):
(WebCore::LayerRendererChromium::headsUpDisplayProgram):
(WebCore::LayerRendererChromium::renderPassProgram):
(WebCore::LayerRendererChromium::renderPassProgramAA):
(WebCore::LayerRendererChromium::renderPassMaskProgram):
(WebCore::LayerRendererChromium::renderPassMaskProgramAA):
(WebCore::LayerRendererChromium::tileProgram):
(WebCore::LayerRendererChromium::tileProgramOpaque):
(WebCore::LayerRendererChromium::tileProgramAA):
(WebCore::LayerRendererChromium::tileProgramSwizzle):
(WebCore::LayerRendererChromium::tileProgramSwizzleOpaque):
(WebCore::LayerRendererChromium::tileProgramSwizzleAA):
(WebCore::LayerRendererChromium::textureProgram):
(WebCore::LayerRendererChromium::textureProgramFlip):
(WebCore::LayerRendererChromium::textureIOSurfaceProgram):
(WebCore::LayerRendererChromium::videoYUVProgram):
(WebCore::LayerRendererChromium::videoStreamTextureProgram):

  • platform/graphics/chromium/LayerTextureSubImage.cpp:

(WebCore::LayerTextureSubImage::uploadWithTexSubImage):
(WebCore::LayerTextureSubImage::uploadWithMapTexSubImage):

  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::SkPictureCanvasLayerTextureUpdater::drawPicture):

  • platform/graphics/chromium/TextureCopier.cpp:

(WebCore::AcceleratedTextureCopier::copyTexture):

  • platform/graphics/chromium/TextureManager.cpp:

(WebCore::TextureManager::evictTexture):

  • platform/graphics/chromium/cc/CCFrameRateController.cpp:

(WebCore::CCFrameRateController::setActive):
(WebCore::CCFrameRateController::onTimerTick):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::~CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initializeLayerRenderer):
(WebCore::CCLayerTreeHost::beginCommitOnImplThread):
(WebCore::CCLayerTreeHost::didLoseContext):
(WebCore::CCLayerTreeHost::updateLayers):
(WebCore::CCLayerTreeHost::animateLayers):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::CCSingleThreadProxy):
(WebCore::CCSingleThreadProxy::~CCSingleThreadProxy):
(WebCore::CCSingleThreadProxy::compositeAndReadback):
(WebCore::CCSingleThreadProxy::stop):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::~CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::initializeContext):
(WebCore::CCThreadProxy::initializeLayerRenderer):
(WebCore::CCThreadProxy::setNeedsAnimate):
(WebCore::CCThreadProxy::setNeedsCommit):
(WebCore::CCThreadProxy::onSwapBuffersCompleteOnImplThread):
(WebCore::CCThreadProxy::setNeedsCommitOnImplThread):
(WebCore::CCThreadProxy::setNeedsForcedCommitOnImplThread):
(WebCore::CCThreadProxy::postAnimationEventsToMainThreadOnImplThread):
(WebCore::CCThreadProxy::setNeedsRedraw):
(WebCore::CCThreadProxy::setNeedsRedrawOnImplThread):
(WebCore::CCThreadProxy::stop):
(WebCore::CCThreadProxy::finishAllRenderingOnImplThread):
(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):
(WebCore::CCThreadProxy::scheduledActionCommit):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal):
(WebCore::CCThreadProxy::acquireLayerTextures):
(WebCore::CCThreadProxy::initializeImplOnImplThread):
(WebCore::CCThreadProxy::initializeContextOnImplThread):
(WebCore::CCThreadProxy::initializeLayerRendererOnImplThread):
(WebCore::CCThreadProxy::layerTreeHostClosedOnImplThread):

2:45 PM Changeset in webkit [121374] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

x86 disassembler confuses immediates with addresses
https://bugs.webkit.org/show_bug.cgi?id=90099

Reviewed by Mark Hahnenberg.

Prepend "$" to immediates to disambiguate between immediates and addresses. This is in
accordance with the gas and AT&T syntax.

  • disassembler/udis86/udis86_syn-att.c:

(gen_operand):

2:25 PM Changeset in webkit [121373] by dpranke@chromium.org
  • 3 edits in trunk/Tools

webkitpy: fix a couple of issues running under cygwin
https://bugs.webkit.org/show_bug.cgi?id=90035

Reviewed by Eric Seidel.

These were causing unit tests to fail on cygwin (apple win bot).

  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/performance_tests/perftest.py:
2:25 PM Changeset in webkit [121372] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Add a comment clarifying Options::showDisassembly versus Options::showDFGDisassembly.

Rubber stamped by Mark Hahnenberg.

  • runtime/Options.cpp:

(JSC::Options::initializeOptions):

2:24 PM Changeset in webkit [121371] by wjmaclean@chromium.org
  • 6 edits
    4 adds in trunk

[chromium] ScrollbarLayerChromium should support painting forward-track and back-track in different styles.
https://bugs.webkit.org/show_bug.cgi?id=89908

Reviewed by Adrienne Walker.

Source/WebCore:

Test: platform/chromium/compositing/scrollbars/custom-composited-different-track-parts.html

Adds support for accelerated drawing (impl thread) of scrollbars with different styles for the
forward-track and back-track parts.

  • platform/graphics/chromium/ScrollbarLayerChromium.cpp:

(WebCore::ScrollbarLayerChromium::pushPropertiesTo):
(WebCore::ScrollbarBackgroundPainter::create):
(WebCore::ScrollbarBackgroundPainter::ScrollbarBackgroundPainter):
(ScrollbarBackgroundPainter):
(WebCore::ScrollbarLayerChromium::setLayerTreeHost):
(WebCore::ScrollbarLayerChromium::createTextureUpdaterIfNeeded):
(WebCore::ScrollbarLayerChromium::update):

  • platform/graphics/chromium/ScrollbarLayerChromium.h:

(ScrollbarLayerChromium):

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:

(WebCore::CCScrollbarLayerImpl::CCScrollbarLayerImpl):
(WebCore):
(WebCore::CCScrollbarLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:

(WebCore::CCScrollbarLayerImpl::setBackTrackTextureId):
(WebCore::CCScrollbarLayerImpl::setForeTrackTextureId):
(CCScrollbarLayerImpl):

LayoutTests:

Adds support for accelerated drawing (impl thread) of scrollbars with different styles for the
forward-track and back-track parts.

  • platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.png: Added.
  • platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.txt: Added.
  • platform/chromium/compositing/scrollbars/custom-composited-different-track-parts.html: Added.
2:18 PM Changeset in webkit [121370] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

REGRESSION(r121135): It made qmltests::WebViewColorChooser::test_accept() fail
https://bugs.webkit.org/show_bug.cgi?id=89871

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-06-27
Reviewed by Simon Hausmann.

Added proper event synchronization to the test case.

  • UIProcess/API/qt/tests/qmltests/WebView/tst_colorChooser.qml:
2:14 PM Changeset in webkit [121369] by abarth@webkit.org
  • 2 edits in trunk/Tools

[Chromium] DumpRenderTree on Android should call SkUseTestFontConfigFile once available
https://bugs.webkit.org/show_bug.cgi?id=89801

Reviewed by Nate Chapin.

Let's call SkUseTestFontConfigFile now that it exists.

  • DumpRenderTree/chromium/TestShellAndroid.cpp:

(platformInit):

2:12 PM Changeset in webkit [121368] by zandobersek@gmail.com
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed GTK gardening, adding a new baseline that's required
after the Gamepad API has been turned on in r121332.

  • platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt: Added.
2:09 PM Changeset in webkit [121367] by dpranke@chromium.org
  • 2 edits in trunk/Tools

Fix typo introduced in r121363.

Unreviewed, build fix.

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._symbols_string):

2:05 PM Changeset in webkit [121366] by jsbell@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] IndexedDB: Expose WebIDBTransaction::commit() method in public API
https://bugs.webkit.org/show_bug.cgi?id=90089

Reviewed by James Robinson.

Prep work for http://webkit.org/b/89379 which requires empty transactions to
trigger a commit from the front-end.

  • public/WebIDBTransaction.h:

(WebKit::WebIDBTransaction::commit):

2:02 PM Changeset in webkit [121365] by mhahnenberg@apple.com
  • 2 edits in trunk/Tools

Moving from committers to reviewers :-)

Rubber stamped by Filip Pizlo.

  • Scripts/webkitpy/common/config/committers.py:
2:00 PM Changeset in webkit [121364] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Expose device scale factor in WebPluginContainer
https://bugs.webkit.org/show_bug.cgi?id=87874

Patch by Josh Horwich <jhorwich@chromium.org> on 2012-06-27
Reviewed by Adam Barth.

  • public/WebPluginContainer.h:

(WebPluginContainer):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::deviceScaleFactor):
(WebKit):
(WebKit::WebPluginContainerImpl::pageScaleFactor):
(WebKit::WebPluginContainerImpl::pageZoomFactor):

  • src/WebPluginContainerImpl.h:

(WebPluginContainerImpl):

1:56 PM WebKit Team edited by mhahnenberg@apple.com
Moving myself from committers to reviewers. (diff)
1:52 PM Changeset in webkit [121363] by dpranke@chromium.org
  • 8 edits in trunk/Tools

Derive ChromiumPort from WebKitPort to add support for missing symbols to skip tests
https://bugs.webkit.org/show_bug.cgi?id=89706

Reviewed by Adam Barth.

Based on the original patch by Raymond Toy.

This patch changes ChromiumPort to derive from webkit.WebKitPort
instead of base.Port. This is a long-awaited change and a
precursor to merging base.Port and webkit.WebKitPort, but is
driven by the desire to dynamically detect whether the MP3 and
AAC codecs are compiled into DRT on Chromium, for which we
wanted to re-use the existing logic in WebKit port for determine
what to skip at compile time.

Most of the changes are shuffling things around so that we don't
change any other logic and so we override the necessary methods
in WebKitPort (and try to follow the same method definition
order where possible).

Also, on the Chromium port the mp3 and aac codecs are actually
defined in a separate library, so scanning webcore isn't
sufficient. This patch generalizes the symbol lookup to handle
multiple libraries, and uses different libraries as appropriate
for Chromium.

The only functional/visible changes should be in the value
returned for skipped_layout_tests().

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort):
(ChromiumPort.init):
(ChromiumPort.driver_name):
(ChromiumPort._driver_class):
(ChromiumPort._missing_symbol_to_skipped_tests):
(ChromiumPort.skipped_layout_tests):
(ChromiumPort.setup_test_run):
(ChromiumPort._path_to_image_diff):
(ChromiumPort._convert_path):

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumPortTest.test_missing_symbol_to_skipped_tests):

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:

(ChromiumLinuxPort._modules_to_search_for_symbols):

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:

(ChromiumLinuxPort._modules_to_search_for_symbols):

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:

(ChromiumLinuxPort._modules_to_search_for_symbols):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort):
(WebKitPort.init):
(WebKitPort._symbols_string):
(WebKitPort._modules_to_search_for_symbols):

1:38 PM Changeset in webkit [121362] by zhajiang@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Wrong scale after leaving fullscreen <video>
https://bugs.webkit.org/show_bug.cgi?id=89546

Reviewed by Antonio Gomes.
Patch by Jacky Jiang <zhajiang@rim.com>

PR: 164948
When we were entering fullscreen, the current scale A was clamped to a
greater minimum scale B as we relayouted the contents during the change
of the viewport size. When leaving fullscreen, we still used that scale
B as the current scale which was incorrect.
To fix this, we can save the current scale when entering fullscreen and
restore it when leaving fullscreen.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
(BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):

  • Api/WebPage_p.h:

(WebPagePrivate):

1:31 PM Changeset in webkit [121361] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebCore

[chromium] Allow screen space rects and occluding rects to be visualized for debugging.
https://bugs.webkit.org/show_bug.cgi?id=90012

Patch by Ian Vollick <vollick@chromium.org> on 2012-06-27
Reviewed by Adrienne Walker.

No new tests. No new functionality.

  • platform/graphics/chromium/cc/CCDebugRectHistory.cpp:

(WebCore::CCDebugRectHistory::enabled):
(WebCore::CCDebugRectHistory::saveDebugRectsForCurrentFrame):
(WebCore::CCDebugRectHistory::saveScreenSpaceRects):
(WebCore):
(WebCore::CCDebugRectHistory::saveOccludingRects):

  • platform/graphics/chromium/cc/CCDebugRectHistory.h:

(WebCore):
(CCDebugRectHistory):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::showDebugRects):
(WebCore::CCHeadsUpDisplay::draw):
(WebCore::CCHeadsUpDisplay::drawDebugRects):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeSettings::CCLayerTreeSettings):
(CCLayerTreeSettings):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::drawLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(FrameData):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::::CCOcclusionTrackerBase):
(WebCore::addOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):

  • platform/graphics/chromium/cc/CCOcclusionTracker.h:

(CCOcclusionTrackerBase):
(WebCore::CCOcclusionTrackerBase::setOccludingScreenSpaceRectsContainer):

1:22 PM Changeset in webkit [121360] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[gtk] Spell checker doesn't recognize contractions (apostrophes)
https://bugs.webkit.org/show_bug.cgi?id=86118

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-06-27
Reviewed by Gustavo Noronha Silva.

Work-around a bug in Pango by trying to detect apostrophes
that create contractions. This work-around is similar to one
found in gtkspell.

  • webkit/webkitspellcheckerenchant.cpp:

(wordEndIsAContractionApostrophe): Added this helper which tries to detect
situations where a word end is both an apostrophe and followed by a alphabetic
character.
(checkSpellingOfString): When searching for the end of a word, skip over
apostrophes that appear to be part of contractions.

12:54 PM Changeset in webkit [121359] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Web Inspector [JSC]: Implement ScriptCallStack::stackTrace
https://bugs.webkit.org/show_bug.cgi?id=40118

Patch by Anthony Scian <ascian@rim.com> on 2012-06-27
Reviewed by Yong Li.

Source/JavaScriptCore:

Added member functions to expose function name, urlString, and line #.
Refactored toString to make use of these member functions to reduce
duplicated code for future maintenance.

Manually tested refactoring of toString by tracing thrown exceptions.

  • interpreter/Interpreter.h:

(StackFrame):
(JSC::StackFrame::toString):
(JSC::StackFrame::friendlySourceURL):
(JSC::StackFrame::friendlyFunctionName):
(JSC::StackFrame::friendlyLineNumber):

Source/WebCore:

Implemented stub for createScriptCallStack to call into
Interpreter and extract the current stack frames, iterate
through the frames and create the return result required.

No new tests, manually tested thrown exception and inspector
tracebacks.

  • bindings/js/ScriptCallStackFactory.cpp:

(WebCore::createScriptCallStack):

12:50 PM Changeset in webkit [121358] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Let Xcode have its own way.

  • WebCore.xcodeproj/project.pbxproj:
12:42 PM Changeset in webkit [121357] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION (Safari 5?): Pasting a line into textarea inserts two newlines
https://bugs.webkit.org/show_bug.cgi?id=49288

Reviewed by Tony Chang.

Source/WebCore:

The bug was caused by positionAvoidingPrecedingNodes getting out of a block when the insertion point is at a line break.
It caused the subsequent code to be misinformed of the insertion position and ended up not pruning the extra line break.

Fixed the bug by checking this special case and bailing out so that we don't crawl out of the enclosing block.
It's similar to checks several lines below it.

Test: editing/pasteboard/copy-paste-pre-line-content.html

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::positionAvoidingPrecedingNodes):

LayoutTests:

Add a test regerssion test for copying & pasting a line in pre into textarea twice.

  • editing/pasteboard/copy-paste-pre-line-content-expected.txt: Added.
  • editing/pasteboard/copy-paste-pre-line-content.html: Added.
11:45 AM Changeset in webkit [121356] by hclam@chromium.org
  • 4 edits in trunk/LayoutTests

[Chromium] Rebaseline svg/text/scaled-font.svg and svg/text/scaling-font-with-geometric-precision.html caused by r121343.

Not reviewed. Build fix.

  • platform/chromium-mac-snowleopard/svg/text/scaling-font-with-geometric-precision-expected.png:
  • platform/chromium-mac/svg/text/scaled-font-expected.png:
  • platform/chromium-mac/svg/text/scaling-font-with-geometric-precision-expected.png:
11:44 AM Changeset in webkit [121355] by zhajiang@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

Scale was incorrect when reloading a simple web page after initial load https://bugs.webkit.org/show_bug.cgi?id=88889

Reviewed by Antonio Gomes.
Patch by Jacky Jiang <zhajiang@rim.com>

PR: 164442
For FrameLoadTypeStandard load, the layout timer can be fired which can
call dispatchDidFirstVisuallyNonEmptyLayout() after the load Finished
state, in which case the web page will have no chance to zoom to
initial scale. We should give it a chance as well as FrameLoadTypeSame
load.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::shouldZoomToInitialScaleOnLoad):

11:28 AM Changeset in webkit [121354] by beidson@apple.com
  • 4 edits in trunk/Source/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=87513
WebBackForwardList needs an overhaul to consistently and clearly handle error conditions.

Reviewed by Darin Adler.

  • We think a null entry might somehow be getting in the list so we now try to prevent that.
  • We think a null entry might somehow be in the list so we now null check when indexing into m_entries.
  • A lot of index math - especially tracking "no current index" - was implicit or wrong.
  • Operating on a WebBackForwardList whose page has been closed is now an explicit no-op.
  • The session state data reading and writing code was fragile and needed an overhaul.
  • This includes adding a new V1 format of the session data that is easier to validate when reading back in.
  • UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::~WebBackForwardList):
(WebKit::WebBackForwardList::pageClosed):
(WebKit::WebBackForwardList::addItem):
(WebKit::WebBackForwardList::goToItem):
(WebKit::WebBackForwardList::backListCount):
(WebKit::WebBackForwardList::forwardListCount):
(WebKit::WebBackForwardList::backListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::forwardListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::clear):

  • UIProcess/WebBackForwardList.h:

(WebBackForwardList):

  • UIProcess/cf/WebBackForwardListCF.cpp:

(WebKit::createEmptySessionHistoryDictionary):
(WebKit::WebBackForwardList::createCFDictionaryRepresentation):
(WebKit::WebBackForwardList::restoreFromCFDictionaryRepresentation):
(WebKit::WebBackForwardList::restoreFromV0CFDictionaryRepresentation):
(WebKit::WebBackForwardList::restoreFromV1CFDictionaryRepresentation):
(WebKit::extractBackForwardListEntriesFromArray):

11:28 AM Changeset in webkit [121353] by ojan@chromium.org
  • 4 edits in trunk/LayoutTests

Fix some styling errors in the TestExpecations files.
There were automatically fixed when trying to make
webkit-patch rebaseline-expectations work for non-Chromium ports.

  • platform/efl/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
11:25 AM Changeset in webkit [121352] by commit-queue@webkit.org
  • 6 edits
    3 adds in trunk

[CSSRegions]Change display values that allow regions
https://bugs.webkit.org/show_bug.cgi?id=89759

Patch by Andrei Onea <onea@adobe.com> on 2012-06-27
Reviewed by Tony Chang.

Source/WebCore:

Allow only elements with display values of block, inline-block,
table-cell, table-caption and list-item to become regions, as per
CSSRegions spec: http://dev.w3.org/csswg/css3-regions .
Also added test for checking whether regions are destroyed and/or created
when changing display value.

Test: fast/regions/region-element-display-change.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):

  • rendering/style/RenderStyle.h:

LayoutTests:

Added checks for more display values, and modified results to reflect proper values that can become
regions. Also created new test for dynamically changing display values, making sure regions are
created or destroyed correctly.

  • fast/regions/region-element-display-change-expected.txt: Added.
  • fast/regions/region-element-display-change.html: Added.
  • fast/regions/region-element-display-restriction-expected.txt:
  • fast/regions/script-tests/region-element-display-change.js: Added.

(testElement):

  • fast/regions/script-tests/region-element-display-restriction.js:
11:23 AM Changeset in webkit [121351] by mikelawther@chromium.org
  • 4 edits
    4 adds
    2 deletes in trunk

CSS3 calc: blending involving expressions
https://bugs.webkit.org/show_bug.cgi?id=86160

Reviewed by Tony Chang.

Source/WebCore:

If either endpoint of a blend involves a calc expression, we create a new
expression to perform the blend calculation.

Test: css3/calc/transitions.html

css3/calc/transitions-dependent.html

  • platform/Length.cpp:

(WebCore):
(WebCore::Length::blendCalculation):

  • platform/Length.h:

(WebCore::Length::blend):
(Length):

LayoutTests:

Removed existing test as it was folded into transitions.html.

  • css3/calc/transition-start-end-with-calc-expected.txt: Removed.
  • css3/calc/transition-start-end-with-calc.html: Removed.
  • css3/calc/transitions-dependent-expected.txt: Added.
  • css3/calc/transitions-dependent.html: Added.
  • css3/calc/transitions-expected.txt: Added.
  • css3/calc/transitions.html: Added.
10:48 AM Changeset in webkit [121350] by shinyak@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Shadow] Triggers assertion in VisibleSelection::adjustSelectionToAvoidCrossingBoundaries()
https://bugs.webkit.org/show_bug.cgi?id=89918

Reviewed by Ryosuke Niwa.

This patch adds a testcase of selection from Shadow DOM to some elements outside of shadow host.
r121303, which is a patch for another issue, fixed this issue.

  • editing/shadow/breaking-editing-boundaries-2-expected.txt: Added.
  • editing/shadow/breaking-editing-boundaries-2.html: Added.
10:45 AM Changeset in webkit [121349] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Move CSSWrapShape style resolution from StyleResolver to StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=89668

Patch by Hans Muller <hmuller@adobe.com> on 2012-06-27
Reviewed by Andreas Kling.

Moved the resolution of the shapeInside and shapeOutside CSS properties
from the StyleResolver class to StyleBuilder. This is just refactoring
in preparation for fixing https://bugs.webkit.org/show_bug.cgi?id=89670.

No new tests were required.

  • css/StyleBuilder.cpp:

(WebCore):
(ApplyPropertyWrapShape):
(WebCore::ApplyPropertyWrapShape::setValue):
(WebCore::ApplyPropertyWrapShape::applyValue):
(WebCore::ApplyPropertyWrapShape::createHandler):
(WebCore::StyleBuilder::StyleBuilder):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

10:38 AM Changeset in webkit [121348] by Alexandru Chiculita
  • 4 edits
    5 adds in trunk

Blur filter causes issues when scrolling
https://bugs.webkit.org/show_bug.cgi?id=89475

Reviewed by Simon Fraser.

Source/WebCore:

This patch disables the fast scrolling when there is a fixed postioned element that
has a filter applied on its parent layer. Otherwise the scroll blitting will just
copy the outsets of the blur effect.

Test: css3/filters/blur-filter-page-scroll.html

  • page/FrameView.cpp:

(WebCore::FrameView::scrollContentsFastPath):

LayoutTests:

Checking that the fixed positioned element repaints correctly when there is a blur filter
applied on its parent layer.

  • css3/filters/blur-filter-page-scroll.html: Added.
  • platform/chromium/css3/filters/blur-filter-page-scroll-expected.png: Added.
  • platform/chromium/css3/filters/blur-filter-page-scroll-expected.txt: Added.
  • platform/chromium/TestExpectations: The new test needs to be checked on Windows.
  • platform/mac/css3/filters/blur-filter-page-scroll-expected.png: Added.
  • platform/mac/css3/filters/blur-filter-page-scroll-expected.txt: Added.
10:22 AM Changeset in webkit [121347] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r121296): New zero-size background tests asserting on Mac.
<http://webkit.org/b/90071>

Reviewed by Dan Bernstein.

Remove ASSERT(patternTransform.isInvertible()) as this is now a valid scenario.

  • platform/graphics/cg/ImageCG.cpp:

(WebCore::Image::drawPattern):

9:55 AM Changeset in webkit [121346] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt] REGRESSION(r121339): It broke the build on the Qt Windows bots
https://bugs.webkit.org/show_bug.cgi?id=90081

Buildfix for Qt 4.8 Windows. Use the former path for Qt 4.8, and the newer one for Qt 5.

Reviewed by Noam Rosenthal.

  • qmake/mkspecs/features/features.prf:
8:52 AM Changeset in webkit [121345] by sergio@webkit.org
  • 2 edits in trunk/Tools

[WK2] [GTK] WebKit2 testing bot fails to run tests due to missing files
https://bugs.webkit.org/show_bug.cgi?id=90061

Reviewed by Gustavo Noronha Silva.

Add "-no-install -no-fast-install" to the LDFLAGS in bots. With
this flag libtool tells the linker to set the rpath for the output
file to the full path of the .libs directory, instead of using a
wrapper script to set up the LD_LIBRARY_PATH. This will allow us
to directly reuse builds in the pure testing bots.

  • BuildSlaveSupport/gtk/daemontools-buildbot.conf:
8:18 AM Changeset in webkit [121344] by shinyak@chromium.org
  • 2 edits in trunk/Source/WebCore

HTMLStyleElement::removedFrom seems incorrect.
https://bugs.webkit.org/show_bug.cgi?id=89986

Reviewed by Hajime Morita.

This is a follow-up patch for Bug 88495. The Same bug as Bug 88495 seems to exist on
HTMLStyleElement::removedFrom().

No new tests, hard to write a test case.

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::removedFrom):

8:06 AM Changeset in webkit [121343] by reed@google.com
  • 2 edits in trunk/Source/WebCore

Cleanup scaling code in text-decorations for SVG InlineText. Use scale() instead of getCTM/normalizeTransform/setCTM
to use more standard pattern for scaling, and to allow for these operations to be recorded and played back later
(potentially with a different starting matrix). This effectively reverts change# 78704.
https://bugs.webkit.org/show_bug.cgi?id=89888

Reviewed by Nikolas Zimmermann.

No new tests. Current layouttests exercise this code path.

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::paintDecorationWithStyle):
(WebCore::SVGInlineTextBox::paintTextWithShadows):

7:55 AM Changeset in webkit [121342] by rjkroege@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] out-of-order assert in WebViewImpl setDeviceScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=90006

The assert in WebViewImpl::setDeviceScaleFactor should test for non-scaling
after we have set both m_DeviceScaleInCompositor and page()->deviceScaleFactor()
instead of in between.

Reviewed by James Robinson.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setDeviceScaleFactor):

7:27 AM Changeset in webkit [121341] by vestbo@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Remove redundant NDEBUG definition

Already handled in default_post.prf.

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-06-27
Reviewed by Tor Arne Vestbø.

  • WebCore.pri:
7:24 AM Changeset in webkit [121340] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] No need to save and restore TEMPLATE in a function

This was a leftover from when the logic was not in its own function scope.

QMAKE_FRAMEWORK_BUNDLE_NAME on the other hand is exported in qtLibraryTarget, which
will surprisingly affect the global scope as well, so we have to save and restore it.

Original patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-06-27

Reviewed by Tor Arne Vestbø.

  • qmake/mkspecs/features/functions.prf:
6:29 AM WebKitGTK/WebKit2Roadmap edited by mario@webkit.org
(diff)
6:05 AM Changeset in webkit [121339] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Fix lookup location for sqlite sources

Don't look in the install dir - we are unlikely to find anything there
unless we are doing a developer build.

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-06-27
Reviewed by Tor Arne Vestbø.

  • qmake/mkspecs/features/features.prf:
6:02 AM Changeset in webkit [121338] by vestbo@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[Qt] Remove redundant c++11 warning suppression code

This is already handled in default_post.

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-06-27
Reviewed by Tor Arne Vestbø.

  • Target.pri:
4:35 AM Changeset in webkit [121337] by apavlov@chromium.org
  • 3 edits
    2 adds in trunk

Unexpected end of style sheet in @font-face rule discards it rather than closes all open constructs
https://bugs.webkit.org/show_bug.cgi?id=89980

Reviewed by Antti Koivisto.

Source/WebCore:

Use the "closing_brace" at the end of font_face rather than the explicit "'}' maybe_space".

Test: fast/css/font-face-unexpected-end.html

  • css/CSSGrammar.y:

LayoutTests:

  • fast/css/font-face-unexpected-end-expected.html: Added.
  • fast/css/font-face-unexpected-end.html: Added.
4:30 AM Changeset in webkit [121336] by vestbo@webkit.org
  • 6 edits in trunk/Source

[Qt] Add missing heades to HEADERS

For JavaScriptCore there aren't any Qt specific files, so we include all
headers for easy editing in Qt Creator.

Reviewed by Simon Hausmann.

3:45 AM WebKitGTK/WebKit2Roadmap edited by mario@webkit.org
(diff)
3:21 AM Changeset in webkit [121335] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

Rename Element::rareData() to Element::elementRareData(), and Element::ensureRareData() to Element::ensureElementRareData()
https://bugs.webkit.org/show_bug.cgi?id=90050

Reviewed by Ryosuke Niwa.

Element::rareData()/Element::ensureRareData() and
Node::rareData()/Node::ensureRareData() are confusing. They are not virtual
methods. For clarification, we can rename Element::rareData() to
Element::elementRareData(), and Element::ensureRareData() to
Element::ensureElementRareData().

c.f. SVGRareData uses SVGElement::rareSVGData() and SVGElement::ensureRareSVGData().
(We might want to rename them to SVGElement::svgRareData() and
SVGElement::ensureSVGRareData() in a follow-up patch.)

No tests. No change in behavior.

  • dom/Element.cpp:

(WebCore::Element::~Element):
(WebCore::Element::elementRareData):
(WebCore::Element::ensureElementRareData):
(WebCore::Element::attributes):
(WebCore::Element::attach):
(WebCore::Element::detach):
(WebCore::Element::recalcStyle):
(WebCore::Element::shadow):
(WebCore::Element::ensureShadow):
(WebCore::Element::shadowPseudoId):
(WebCore::Element::setShadowPseudoId):
(WebCore::Element::focus):
(WebCore::Element::minimumSizeForResizing):
(WebCore::Element::setMinimumSizeForResizing):
(WebCore::Element::computedStyle):
(WebCore::Element::setStyleAffectedByEmpty):
(WebCore::Element::styleAffectedByEmpty):
(WebCore::Element::cancelFocusAppearanceUpdate):
(WebCore::Element::classList):
(WebCore::Element::optionalClassList):
(WebCore::Element::dataset):
(WebCore::Element::containsFullScreenElement):
(WebCore::Element::setContainsFullScreenElement):
(WebCore::Element::hasNamedNodeMap):
(WebCore::Element::ensureCachedHTMLCollection):
(WebCore::Element::savedLayerScrollOffset):
(WebCore::Element::setSavedLayerScrollOffset):

  • dom/Element.h:

(Element):

  • html/LabelableElement.cpp:

(WebCore::LabelableElement::labels):

2:44 AM Changeset in webkit [121334] by dominicc@chromium.org
  • 2 edits
    2 deletes in trunk/Source

[Chromium] Remove unused build scripts and empty folders for JavaScriptCore w/ gyp
https://bugs.webkit.org/show_bug.cgi?id=90029

Source/JavaScriptCore:

Reviewed by Adam Barth.

  • gyp: Removed.
  • gyp/generate-derived-sources.sh: Removed.
  • gyp/generate-dtrace-header.sh: Removed.
  • gyp/run-if-exists.sh: Removed.
  • gyp/update-info-plist.sh: Removed.

Source/WebCore:

  • gyp: Removed empty dir.
2:26 AM Changeset in webkit [121333] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r121271.
http://trac.webkit.org/changeset/121271
https://bugs.webkit.org/show_bug.cgi?id=90056

Broke a whole bunch of tests and also caused crashes in some
tests (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-27

  • editing/Editor.cpp:

(WebCore::Editor::markAndReplaceFor):

2:22 AM BuildingGtk edited by zandobersek@gmail.com
Add gudev as a dependency for building the Gtk port. (diff)
2:19 AM Changeset in webkit [121332] by zandobersek@gmail.com
  • 13 edits
    4 adds in trunk

[Gtk] Add support for the Gamepad API
https://bugs.webkit.org/show_bug.cgi?id=87503

Reviewed by Carlos Garcia Campos.

.:

Only enable the Gamepad feature on Linux as support
for other operating systems is not present.

Check for the GIO Unix and GUdev dependencies when the
Gamepad feature is enabled.

  • configure.ac:

Source/WebCore:

Add support for the Gamepad feature on the GTK port.

The support is available only on Linux, with each gamepad device being presented
through a GamepadDeviceLinux object. The implementation of this class relies on
the Linux kernel joystick API.

Gamepad devices are recognized through the GamepadsGtk class, of which implementation
is based on GUdev. This way devices are properly registered on connection as objects of
the GamepadDeviceGtk class which inherits GamepadDeviceLinux. GamepadDeviceGtk reads the
joystick data through GIO pollable streams and updates the device state accordingly. The
GamepadsGtk object is then polled for gamepads data through the sampleGamepads method.

No new tests - tests already exist but require additional testing infrastructure.

  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • bindings/gobject/GNUmakefile.am:
  • bindings/js/JSDOMBinding.h: Add the jsArray method that operates on a Vector of floats.

(WebCore):
(WebCore::jsArray):

  • platform/gtk/GamepadsGtk.cpp: Added.

(WebCore):
(GamepadDeviceGtk):
(WebCore::GamepadDeviceGtk::create):
(WebCore::GamepadDeviceGtk::GamepadDeviceGtk):
(WebCore::GamepadDeviceGtk::~GamepadDeviceGtk):
(WebCore::GamepadDeviceGtk::readCallback):
(GamepadsGtk):
(WebCore::GamepadsGtk::GamepadsGtk):
(WebCore::GamepadsGtk::~GamepadsGtk):
(WebCore::GamepadsGtk::registerDevice):
(WebCore::GamepadsGtk::unregisterDevice):
(WebCore::GamepadsGtk::updateGamepadList):
(WebCore::GamepadsGtk::onUEventCallback):
(WebCore::GamepadsGtk::isGamepadDevice):
(WebCore::sampleGamepads):

  • platform/linux/GamepadDeviceLinux.cpp: Added.

(WebCore):
(WebCore::GamepadDeviceLinux::GamepadDeviceLinux):
(WebCore::GamepadDeviceLinux::~GamepadDeviceLinux):
(WebCore::GamepadDeviceLinux::updateForEvent):
(WebCore::GamepadDeviceLinux::normalizeAxisValue):
(WebCore::GamepadDeviceLinux::normalizeButtonValue):

  • platform/linux/GamepadDeviceLinux.h: Added.

(WebCore):
(GamepadDeviceLinux):
(WebCore::GamepadDeviceLinux::connected):
(WebCore::GamepadDeviceLinux::id):
(WebCore::GamepadDeviceLinux::timestamp):
(WebCore::GamepadDeviceLinux::axesCount):
(WebCore::GamepadDeviceLinux::axesData):
(WebCore::GamepadDeviceLinux::buttonsCount):
(WebCore::GamepadDeviceLinux::buttonsData):

Source/WebKit/gtk:

Add the Gamepad feature dependencies libraries to the LIBADD
list for the libwebkitgtk library.

  • GNUmakefile.am:

Source/WebKit2:

Add the Gamepad feature dependencies libraries to the LIBADD
list for the libwebkitgtk2 library.

  • GNUmakefile.am:

Tools:

Enable the gamepad support for the GTK port.

  • Scripts/webkitperl/FeatureList.pm:
2:15 AM Changeset in webkit [121331] by rniwa@webkit.org
  • 5 edits in trunk

Fix gcc build after r121302
https://bugs.webkit.org/show_bug.cgi?id=90055

Reviewed by Mark Rowe.

Source/ThirdParty:

Assume RTTI is disabled so that gtest builds under XCode 3.2.6.

  • gtest/xcode/Config/General.xcconfig:

Tools:

Assume RTTI is always disabled so that gtest builds on XCode 3.2.6.

It appears that gcc doesn't like window.get().* inside a template so replace that by [window.get() *] instead.

  • TestWebKitAPI/Configurations/Base.xcconfig:
  • TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:

(TestWebKitAPI::AcceptsFirstMouse::runTest):

1:54 AM Changeset in webkit [121330] by haraken@chromium.org
  • 6 edits in trunk/Source/WebCore

Rename rareSVGData() to svgRareData()
https://bugs.webkit.org/show_bug.cgi?id=90051

Reviewed by Nikolas Zimmermann.

Since rareSVGData() returns SVGRareData, it would make sense to
rename rareSVGData() to svgRareData(). Similarly, we can rename
ensureRareSVGData() to ensureSVGRareData(), and hasRareSVGData()
to hasSVGRareData().

c.f. bug 90050 is trying to introduce elementRareData() and
ensureElementRareData().

No tests. No change in behavior.

  • WebCore.order:
  • dom/Node.h:

(WebCore::Node::hasSVGRareData):
(WebCore::Node::setHasSVGRareData):
(WebCore::Node::clearHasSVGRareData):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::~SVGElement):
(WebCore::SVGElement::willRecalcStyle):
(WebCore::SVGElement::svgRareData):
(WebCore::SVGElement::ensureSVGRareData):
(WebCore::SVGElement::mapInstanceToElement):
(WebCore::SVGElement::removeInstanceMapping):
(WebCore::SVGElement::instancesForElement):
(WebCore::SVGElement::setCursorElement):
(WebCore::SVGElement::cursorElementRemoved):
(WebCore::SVGElement::setCursorImageValue):
(WebCore::SVGElement::cursorImageValueRemoved):
(WebCore::SVGElement::correspondingElement):
(WebCore::SVGElement::setCorrespondingElement):
(WebCore::SVGElement::animatedSMILStyleProperties):
(WebCore::SVGElement::ensureAnimatedSMILStyleProperties):
(WebCore::SVGElement::setUseOverrideComputedStyle):
(WebCore::SVGElement::computedStyle):

  • svg/SVGElement.h:

(SVGElement):

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::instanceUpdatesBlocked):
(WebCore::SVGStyledElement::setInstanceUpdatesBlocked):
(WebCore::SVGStyledElement::hasPendingResources):
(WebCore::SVGStyledElement::setHasPendingResources):
(WebCore::SVGStyledElement::clearHasPendingResourcesIfPossible):

1:30 AM Changeset in webkit [121329] by kkristof@inf.u-szeged.hu
  • 5 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, rebaseline after r121303.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-06-27

  • platform/qt/editing/deleting/delete-br-002-expected.txt:
  • platform/qt/editing/deleting/delete-br-004-expected.txt:
  • platform/qt/editing/deleting/delete-br-005-expected.txt:
  • platform/qt/editing/deleting/delete-br-006-expected.txt:
1:27 AM Changeset in webkit [121328] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Add master.cfg unittest to help migration - pass BuildStep instances instead of BuildStep subclasses
https://bugs.webkit.org/show_bug.cgi?id=89564

Reviewed by Tony Chang.

  • BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:

(BuildStepsConstructorTest):
(BuildStepsConstructorTest.generateTests):
(BuildStepsConstructorTest.createTest):
(BuildStepsConstructorTest.createTest.doTest):

12:48 AM Changeset in webkit [121327] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

LabelableElement.cpp should include not ElementRareData.h but NodeRareData.h
https://bugs.webkit.org/show_bug.cgi?id=90047

Reviewed by Kent Tamura.

This is a simple refactoring. What LabelableElement uses is
not ElementRareData but NodeRareData.

No tests. No change in behavior.

  • html/LabelableElement.cpp:
12:28 AM Changeset in webkit [121326] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Refactor V8BindingPerIsolateData::current() and V8BindingPerIsolateData::get()
https://bugs.webkit.org/show_bug.cgi?id=90044

Reviewed by Adam Barth.

'static_cast<V8BindingPerIsolateData*>(isolate->GetData())' is duplicated
in V8BindingPerIsolateData::current() and V8BindingPerIsolateData::get().
This patch removes the duplication.

No tests. No change in behavior.

  • bindings/v8/V8Binding.h:

(WebCore::V8BindingPerIsolateData::current):

12:26 AM Changeset in webkit [121325] by zandobersek@gmail.com
  • 5 edits in trunk/LayoutTests

Unreviewed GTK gardening, updating baselines after r121303.

  • platform/gtk/editing/deleting/delete-br-002-expected.txt:
  • platform/gtk/editing/deleting/delete-br-004-expected.txt:
  • platform/gtk/editing/deleting/delete-br-005-expected.txt:
  • platform/gtk/editing/deleting/delete-br-006-expected.txt:
12:26 AM Changeset in webkit [121324] by Simon Hausmann
  • 3 edits in trunk/Source/WebKit/qt

[Qt] Fix compilation of example platform plugin with Qt 5

Reviewed by Kenneth Christiansen.

Use QLatin1String where appropriate and use the Qt 5 plugin
system with Qt 5.

  • examples/platformplugin/WebPlugin.cpp:

(SingleSelectionPopup::SingleSelectionPopup):
(MultipleItemListDelegate::MultipleItemListDelegate):
(MultipleSelectionPopup::MultipleSelectionPopup):

  • examples/platformplugin/WebPlugin.h:

(WebPlugin):

12:09 AM Changeset in webkit [121323] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit2

[Qt] Avoid use of deprecated Qt API

Reviewed by Tor Arne Vestbø.

QGuiApplication::inputPanel() has been deprecated in favour of
inputMethod().

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(WebKit::QtWebPageEventHandler::QtWebPageEventHandler):
(WebKit::QtWebPageEventHandler::~QtWebPageEventHandler):
(WebKit::setInputPanelVisible):
(WebKit::QtWebPageEventHandler::inputPanelVisibleChanged):
(WebKit::QtWebPageEventHandler::updateTextInputState):

Jun 26, 2012:

11:37 PM Changeset in webkit [121322] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-26

  • DEPS:
11:03 PM Changeset in webkit [121321] by yosin@chromium.org
  • 3 edits in trunk/Source/WebCore

[Platform] Change implementation of LocaleICU class to support more UDateFormat.
https://bugs.webkit.org/show_bug.cgi?id=89967

Reviewed by Kent Tamura.

This patch changes internal functions of LocaleICU class to process
multiple ICU date time format handles in addition to short date time
format handle.

This patch is a part of implementing input type time. I'll add time
format related ICU date time format handles.

No new tests. This patch doesn't change behavior.

  • platform/text/LocaleICU.cpp:

(WebCore::LocaleICU::initializeShortDateFormat): Changed to use openDateFormat().
(WebCore::LocaleICU::openDateFormat): Added for common usage of udt_open().
(WebCore::getDateFormatPattern): Added for common usage of udt_toPattern().
(WebCore::localizeFormat): Changed to take String parameter.
(WebCore::LocaleICU::initializeLocalizedDateFormatText): Changed to use getDateFormatPattern.
(WebCore::LocaleICU::createLabelVector): Changed to take UDateFormat parameter.
(WebCore::LocaleICU::initializeCalendar): Changed for helper functions.

  • platform/text/LocaleICU.h:

(LocaleICU):

10:40 PM Changeset in webkit [121320] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

Return correct value for css variables enabled runtime flag.
https://bugs.webkit.org/show_bug.cgi?id=90040

Reviewed by Dimitri Glazkov.

Was always returning true for the runtime flag when the compile time flag was on. That was good for testing,
but not so much for production.

  • page/Settings.h:

(WebCore::Settings::cssVariablesEnabled):

9:22 PM Changeset in webkit [121319] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

DragData::asFilenames should not push same file names to result in Windows.
https://bugs.webkit.org/show_bug.cgi?id=79861

Patch by Xueqing Huang <huangxueqing@baidu.com> on 2012-06-26
Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: platform/win/fast/forms/file/drag-and-drop-files.html

  • platform/win/DragDataWin.cpp:

(WebCore::DragData::asFilenames):

LayoutTests:

  • platform/win/fast/forms/file/drag-and-drop-files-expected.txt: Added.
  • platform/win/fast/forms/file/drag-and-drop-files.html: Added.
9:03 PM Changeset in webkit [121318] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Rebaseline after r121286 and r121290.

  • editing/deleting/merge-into-empty-block-2-expected.txt:
8:49 PM Changeset in webkit [121317] by keishi@webkit.org
  • 3 edits in trunk/LayoutTests

[Chromium] Rebaseline fast/backgrounds/size/zero.html. Caused by r121296

Unreviewed.

  • platform/chromium-mac-snowleopard/fast/backgrounds/size/zero-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/zero-expected.png:
8:44 PM Changeset in webkit [121316] by ggaren@apple.com
  • 6 edits in trunk/Source

Reduced (but did not eliminate) use of "berzerker GC"
https://bugs.webkit.org/show_bug.cgi?id=89237

Reviewed by Gavin Barraclough.

(PART 2)

../JavaScriptCore:

This part turns off "berzerker GC" and turns on incremental shrinking.

  • heap/IncrementalSweeper.cpp:

(JSC::IncrementalSweeper::doSweep): Free or shrink after sweeping to
maintain the behavior we used to get from the occasional berzerker GC,
which would run all finalizers and then free or shrink all blocks
synchronously.

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::needsSweeping): Sweep zapped blocks, too. It's always
safe to sweep a zapped block (that's the point of zapping), and it's
sometimes profitable. For example, consider this case: Block A does some
allocation (transitioning Block A from Marked to FreeListed), then GC
happens (transitioning Block A to Zapped), then all objects in Block A
are free, then the incremental sweeper visits Block A. If we skipped
Zapped blocks, we'd skip Block A, even though it would be profitable to
run its destructors and free its memory.

  • runtime/GCActivityCallback.cpp:

(JSC::DefaultGCActivityCallback::doWork): Don't sweep eagerly; we'll do
this incrementally.

../WebCore:

Don't ASSERT that RootObject's destructor runs and invalidates all
RuntimeObjects before their destructors run.

We don't guarantee this behavior because some RuntimeObjects may already
be garbage by the time RootObject's destructor runs, in which case
RootObject's weak pointers will be NULL, and RootObject will not call
invalidate() on them.

It's been theoretically possible for this ASSERT to fire for a while now.
This patch makes it fire all the time.

Luckily, we only needed the behavior guarded by this ASSERT for WebKit1
in Safari on Windows (cf. https://bugs.webkit.org/show_bug.cgi?id=61317),
to handle the way WebKit1 would unload plugin DLLs. If this ever becomes
an issue again, we can fix it by (a) not unloading plugin DLLs,
(b) migrating WebKit1 to the WebKit2 JS-plugin binding model, (c) making
the Instance pointer in a RuntimeObject an indirect pointer through
RootObject, or (c) giving RuntimeObject some sort of special way to
access a zombie weak pointer.

  • bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::destroy): ASSERT removed. Anders said so.

8:30 PM Changeset in webkit [121315] by keishi@webkit.org
  • 5 edits
    12 copies
    2 adds in trunk/LayoutTests

[Chromium] Rebaseline 4 tests in editing/deleting. Caused by r121303.

Unreviewed.

  • platform/chromium-linux-x86/editing/deleting/delete-br-002-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-br-002-expected.txt.
  • platform/chromium-linux-x86/editing/deleting/delete-br-004-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-br-004-expected.txt.
  • platform/chromium-linux-x86/editing/deleting/delete-br-005-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-br-005-expected.txt.
  • platform/chromium-linux-x86/editing/deleting/delete-br-006-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-br-006-expected.txt.
  • platform/chromium-linux/editing/deleting/delete-br-002-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-br-002-expected.txt.
  • platform/chromium-linux/editing/deleting/delete-br-004-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-br-004-expected.txt.
  • platform/chromium-linux/editing/deleting/delete-br-005-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-br-005-expected.txt.
  • platform/chromium-linux/editing/deleting/delete-br-006-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-br-006-expected.txt.
  • platform/chromium-win-xp/editing/deleting/delete-br-002-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-br-002-expected.txt.
  • platform/chromium-win-xp/editing/deleting/delete-br-004-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-br-004-expected.txt.
  • platform/chromium-win-xp/editing/deleting/delete-br-005-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-br-005-expected.txt.
  • platform/chromium-win-xp/editing/deleting/delete-br-006-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-br-006-expected.txt.
  • platform/chromium-win/editing/deleting/delete-br-002-expected.txt:
  • platform/chromium-win/editing/deleting/delete-br-004-expected.txt:
  • platform/chromium-win/editing/deleting/delete-br-005-expected.txt:
  • platform/chromium-win/editing/deleting/delete-br-006-expected.txt:
8:02 PM Changeset in webkit [121314] by commit-queue@webkit.org
  • 4 edits
    5 adds in trunk

REGRESSION(r107836): box shadow not drawn for opaque images with an opaque background
https://bugs.webkit.org/show_bug.cgi?id=89958

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-06-26
Reviewed by Simon Fraser.

Source/WebCore:

Don't attempt to draw the box shadow as part of the background if the background is
obscured.

Test: fast/box-shadow/image-box-shadow.html

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::boxShadowShouldBeAppliedToBackground):
(WebCore):

  • rendering/RenderImage.h:

(RenderImage):

LayoutTests:

  • fast/box-shadow/image-box-shadow-expected.html: Added.
  • fast/box-shadow/image-box-shadow.html: Added.
  • fast/box-shadow/resources/green-alpha.png: Added.
  • fast/box-shadow/resources/green.jpg: Added.
  • fast/box-shadow/resources/green.png: Added.
7:20 PM Changeset in webkit [121313] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix new Wunused-private-field violations that crept in
https://bugs.webkit.org/show_bug.cgi?id=90032

Reviewed by Adam Barth.

  • page/Performance.h:

(Performance):

7:11 PM Changeset in webkit [121312] by gyuyoung.kim@samsung.com
  • 12 edits in trunk/Source

Change return type in bandwidth attribute of network information API
https://bugs.webkit.org/show_bug.cgi?id=89959

Reviewed by Adam Barth.

According to network information API spec, bandwidth attribute should return double type.
But, existing implementation has used *long* and *unsigned int* types.

Source/WebCore:

No new tests. Covered by existing tests.

  • Modules/networkinfo/NetworkInfo.cpp:

(WebCore::NetworkInfo::NetworkInfo):

  • Modules/networkinfo/NetworkInfo.h:

(WebCore::NetworkInfo::create):
(WebCore::NetworkInfo::bandwidth):
(NetworkInfo):

  • Modules/networkinfo/NetworkInfoClient.h:

(NetworkInfoClient):

  • Modules/networkinfo/NetworkInfoConnection.cpp:

(WebCore::NetworkInfoConnection::bandwidth):

  • Modules/networkinfo/NetworkInfoConnection.h:

(NetworkInfoConnection):

  • testing/Internals.cpp:

(WebCore::Internals::setNetworkInformation):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit/efl:

  • WebCoreSupport/NetworkInfoClientEfl.cpp:

(WebCore::NetworkInfoClientEfl::bandwidth):

  • WebCoreSupport/NetworkInfoClientEfl.h:

(NetworkInfoClientEfl):

6:57 PM Changeset in webkit [121311] by macpherson@chromium.org
  • 2 edits
    2 adds in trunk

Be careful not to read past the end of input in CSSParser::lex() when looking for variable definitions.
https://bugs.webkit.org/show_bug.cgi?id=89949

Reviewed by Abhishek Arya.

Added repro case as fast/css/short-inline-style.html.

  • css/CSSParser.cpp:

(WebCore::CSSParser::lex):

6:49 PM Changeset in webkit [121310] by commit-queue@webkit.org
  • 15 edits in trunk/Source

[chromium] Remove WebView::graphicsContext3D getter
https://bugs.webkit.org/show_bug.cgi?id=89916

Patch by James Robinson <jamesr@chromium.org> on 2012-06-26
Reviewed by Adrienne Walker.

Source/Platform:

Remove unused getter.

  • chromium/public/WebLayerTreeView.h:

(WebLayerTreeView):

Source/WebCore:

Deletes code supporting compositor context getter.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCProxy.h:

(CCProxy):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(CCSingleThreadProxy):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:
  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

Removes WebView::graphicsContext3D getter. This getter was used to access the compositor's context, which is an
inherently dangerous operation since the compositor context may not be safe to use on the main thread and has
somewhat complicated creation / recreation semantics. A shared context is exposed
(WebView::sharedGraphicsContext3D) for callers who may want access to a context in a share group with the
compositor.

  • public/WebView.h:

(WebView):

  • src/WebLayerTreeView.cpp:
  • src/WebViewImpl.cpp:
  • src/WebViewImpl.h:

(WebViewImpl):

6:41 PM Changeset in webkit [121309] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Unexpected element sizes when mixing inline-table with box-sizing
https://bugs.webkit.org/show_bug.cgi?id=89819

Patch by Kulanthaivel Palanichamy <kulanthaivel@codeaurora.org> on 2012-06-26
Reviewed by Julien Chaffraix.

Source/WebCore:

This change handles box-sizing: border-box property for CSS tables properly.

Test: fast/box-sizing/css-table-with-box-sizing.html

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
(WebCore::RenderTable::layout):

LayoutTests:

  • fast/box-sizing/css-table-with-box-sizing-expected.txt: Added.
  • fast/box-sizing/css-table-with-box-sizing.html: Added.
6:38 PM Changeset in webkit [121308] by mhahnenberg@apple.com
  • 4 edits in trunk/Tools

Add support for preciseTime() to WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=90027

Reviewed by Darin Adler.

It would be nice to be able to use preciseTime() in WebKitTestRunner like we can in DumpRenderTree.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::preciseTime):
(WTR):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(LayoutTestController):

6:34 PM Changeset in webkit [121307] by fpizlo@apple.com
  • 6 edits
    6 adds in trunk

DFG PutByValAlias is too aggressive
https://bugs.webkit.org/show_bug.cgi?id=90026
<rdar://problem/11751830>

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

For CSE on normal arrays, we now treat PutByVal as impure. This does not appear to affect
performance by much.

For CSE on typed arrays, we fix PutByValAlias by making GetByVal speculate that the access
is within bounds. This also has the effect of making our out-of-bounds handling consistent
with WebCore.

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::byValIsPure):
(JSC::DFG::Graph::clobbersWorld):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):

LayoutTests:

Reviewed by Gavin Barraclough.

  • fast/js/dfg-put-by-val-setter-then-get-by-val-expected.txt: Added.
  • fast/js/dfg-put-by-val-setter-then-get-by-val.html: Added.
  • fast/js/dfg-uint8clampedarray-out-of-bounds-put-by-val-alias-expected.txt: Added.
  • fast/js/dfg-uint8clampedarray-out-of-bounds-put-by-val-alias.html: Added.
  • fast/js/script-tests/dfg-put-by-val-setter-then-get-by-val.js: Added.

(foo):
(for):

  • fast/js/script-tests/dfg-uint8clampedarray-out-of-bounds-put-by-val-alias.js: Added.

(foo):

6:31 PM Changeset in webkit [121306] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Optimize mappings of simple transforms in RenderGeometryMap
https://bugs.webkit.org/show_bug.cgi?id=90034

Reviewed by Dean Jackson.

For transforms that are identity or simple translations, don't
fall off the fast path in RenderGeometryMap; we can just
treat them as offsets.

Improves performance on pages with lots of translateZ(0) elements.

Remove RenderGeometryMapStep::mapPoint() and mapQuad(), which
were unused.

No new tests; optimization only, and tested by assertions.

  • rendering/RenderGeometryMap.cpp:

(WebCore::RenderGeometryMap::push):

5:41 PM Changeset in webkit [121305] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Touch adjustment does not target shadow DOM elements
https://bugs.webkit.org/show_bug.cgi?id=89556

Source/WebCore:

The position of internal shadow-DOM nodes were not being considered
when determining the snap position when TOUCH_ADJUSTMENT is enabled
for fine tuning the position of synthetic mouse events. This
restriction results in not being able to select the calendar picker
when input type=date, or to clear the search field for input
type=search.

Patch by Kevin Ellis <kevers@chromium.org> on 2012-06-26
Reviewed by Antonio Gomes.

Test: touchadjustment/nested-shadow-node.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::bestClickableNodeForTouchPoint):

LayoutTests:

Cannot open calendar picker for input type=date using a touch tap
gesture if TOUCH_ADJUSTMENT is enabled. When touch adjustment is
enabled, the position of a touch point is snapped to the center of an
element when generating synthetic mouse events. The position of shadow
nodes was not being considered when determining the snap position.
This test verifies that touch adjustment now considers shadow-DOM
when calculating the snap position.

Patch by Kevin Ellis <kevers@chromium.org> on 2012-06-26
Reviewed by Antonio Gomes.

  • touchadjustment/nested-shadow-node-expected.txt: Added.
  • touchadjustment/nested-shadow-node.html: Added.
5:06 PM Changeset in webkit [121304] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Decrease the number of conditional blocks in features.gypi
https://bugs.webkit.org/show_bug.cgi?id=90013

Reviewed by Adam Barth.

Consolidate two Android-specific and accelerated-compositing-specific
conditional blocks into other blocks which serve an identical purpose.

  • features.gypi:
5:00 PM Changeset in webkit [121303] by rniwa@webkit.org
  • 9 edits in trunk

Stop calling node() and deprecatedEditingOffset() in comparePositions
https://bugs.webkit.org/show_bug.cgi?id=54535

Reviewed by Enrica Casucci.

Source/WebCore:

Replaced deprecatedNode() and deprecatedEditingOffset() by containerNode() and computeOffsetInContainerNode()
in comparePositions().

In addition, fixed a bunch of bugs in DeleteSelectionCommand::handleSpecialCaseBRDelete revealed by this change:

  • Use node after position instead of deprecated node in determinig whether start and end positions at a br.
  • Don't set m_startsAtEmptyLine true when BR is wrapped in a block element. The only reason this code had worked

was positions like (div, offset, 0) and (br, before) in <div><br> were treated differently, which we no longer do.

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete):

  • editing/htmlediting.cpp:

(WebCore::comparePositions):

LayoutTests:

Rebaselined existing tests. There are no user-visible changes.

  • editing/inseting/font-size-clears-from-typing-style-expected.txt: No longer keeps div's around

when merging paragraphs.

  • platform/mac/editing/deleting/delete-br-002-expected.txt:
  • platform/mac/editing/deleting/delete-br-004-expected.txt:
  • platform/mac/editing/deleting/delete-br-005-expected.txt:
  • platform/mac/editing/deleting/delete-br-006-expected.txt:
4:54 PM Changeset in webkit [121302] by Lucas Forschler
  • 3 edits in trunk/Tools

Teach the Apple port how to build the test tools in build-webkit
https://bugs.webkit.org/show_bug.cgi?id=89540

Reviewed by Jon Lee & Simon Fraser.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunWebKitTests.start): pass --no-build since tools should now be in the downloaded archive (RunUnitTests.start): ditto
  • Scripts/build-webkit: add tools to the projects build list
4:43 PM Changeset in webkit [121301] by ojan@chromium.org
  • 4 edits in trunk/Tools

Only show the platform-appropriate builders for non-layout test failures in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=90025

Reviewed by Simon Fraser.

Move the chromium-specific filtering code into config.js and replace it with a method on each platform
config. Also, let the webkit test step name be webkit_tests (build.chromium.org) or layout-test (build.webkit.org).

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
4:39 PM Changeset in webkit [121300] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Use eina_file_ls() in EFL implementation of FileSystem listDirectory()
https://bugs.webkit.org/show_bug.cgi?id=89976

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-26
Reviewed by Antonio Gomes.

Rewrite EFL implementation of Filesystem listDirectory() in order to
use eina_file_ls() instead of POSIX C functions. This results in
shorter code.

No new tests, behavior has not changed.

  • platform/efl/FileSystemEfl.cpp:

(WebCore::listDirectory):

4:34 PM Changeset in webkit [121299] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

Crash at WebCore::TextIterator::handleTextBox
https://bugs.webkit.org/show_bug.cgi?id=89526
<rdar://problem/10305315>

Patch by Alice Cheng <alice_cheng@apple.com> on 2012-06-26
Reviewed by Darin Adler.

Source/WebCore:

The range used for marking becomes invalid after SpellingCorrectionCommand, due to changes in the DOM made by ReplaceSelectionCommand.
This invalid range caused marking to be incorrect, and Mail.app to crash when iterating through the invalid range. To fix this,
recalculate the range for marking after SpellingCorrectionCommand.

Test: platform/mac/editing/spelling/autocorrection-blockquote-crash.html

  • editing/AlternativeTextController.cpp:

(WebCore::AlternativeTextController::applyAlternativeTextToRange):

  • editing/Editor.cpp: (WebCore::Editor::markAndReplaceFor):
  • testing/Internals.cpp:

(WebCore):
(WebCore::Internals::hasAutocorrectedMarker):

  • testing/Internals.h: (Internals):
  • testing/Internals.idl:

LayoutTests:

  • platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt: Added.
  • platform/mac/editing/spelling/autocorrection-blockquote-crash.html: Added.
4:32 PM Changeset in webkit [121298] by rniwa@webkit.org
  • 3 edits
    1 delete in trunk/LayoutTests

Convert editing/inserting/font-size-clears-from-typing-style.html to a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=90024

Reviewed by Ojan Vafai.

Converted a script test to a dump-as-markup test because the test result can be understood much eaiser that way.

  • editing/inserting/font-size-clears-from-typing-style-expected.txt:
  • editing/inserting/font-size-clears-from-typing-style.html:
  • editing/inserting/script-tests: Removed.
  • editing/inserting/script-tests/TEMPLATE.html: Removed.
  • editing/inserting/script-tests/font-size-clears-from-typing-style.js: Removed.
4:18 PM Changeset in webkit [121297] by tsepez@chromium.org
  • 8 edits
    5 adds in trunk

[chromium] HTML5 audio/video tags - loading http content from https page doesn't trigger warning.
https://bugs.webkit.org/show_bug.cgi?id=89906

Reviewed by Nate Chapin.

This patch treats mixed CachedRawResources as affecting the display of insecure content.

Source/WebCore:

Tests: http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html

http/tests/security/mixedContent/insecure-xhr-in-main-frame.html

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::checkInsecureContent):

LayoutTests:

  • http/tests/security/mixedContent/insecure-audio-video-in-main-frame-expected.txt: Added.
  • http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html: Added.
  • http/tests/security/mixedContent/insecure-xhr-in-main-frame-expected.txt: Added.
  • http/tests/security/mixedContent/insecure-xhr-in-main-frame.html: Added.
  • http/tests/security/mixedContent/resources/frame-with-insecure-audio-video.html: Added.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
4:08 PM Changeset in webkit [121296] by commit-queue@webkit.org
  • 10 edits
    2 adds in trunk

background-size:0 shows as 1px instead of invisible
https://bugs.webkit.org/show_bug.cgi?id=86942

Patch by Joe Thomas <joethomas@motorola.com> on 2012-06-26
Reviewed by Eric Seidel.

As per the specification http://www.w3.org/TR/css3-background/#background-size, if the background image's width or height resolves to zero,
this causes the image not to be displayed. The effect should be the same as if it had been a transparent image.
This is also mentioned in http://www.w3.org/TR/2002/WD-css3-background-20020802/#background-size.

Source/WebCore:

Test: fast/backgrounds/zero-background-size.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateFillTileSize):

LayoutTests:

  • fast/backgrounds/size/zero.html:
  • fast/backgrounds/zero-background-size-expected.html: Added.
  • fast/backgrounds/zero-background-size.html: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/fast/backgrounds/size/zero-expected.png:
  • platform/mac/fast/backgrounds/size/zero-expected.txt:
  • platform/qt/TestExpectations:
4:02 PM Changeset in webkit [121295] by adamk@chromium.org
  • 3 edits in trunk/Source/WebCore

[v8] Clean up generated Dictionary-handling code
https://bugs.webkit.org/show_bug.cgi?id=89994

Reviewed by Adam Barth.

No change in behavior, so no new tests.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateParametersCheck):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::optionsObjectCallback):

4:00 PM Changeset in webkit [121294] by ojan@chromium.org
  • 4 edits in trunk/Tools

Fix failing garden-o-matic unittests
https://bugs.webkit.org/show_bug.cgi?id=90021

Reviewed by Adam Barth.

These had all just fallen out of date.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
4:00 PM Changeset in webkit [121293] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Include stdio.h when DEBUG_AUDIONODE_REFERENCES is set
https://bugs.webkit.org/show_bug.cgi?id=89997

Patch by Raymond Toy <Raymond Toy> on 2012-06-26
Reviewed by Eric Seidel.

No new tests needed for a compile issue

  • Modules/webaudio/AudioNode.cpp: Include stdio.h
3:51 PM Changeset in webkit [121292] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebCore

[Qt] Use premultiplied alpha when extracting image data in WebGL
https://bugs.webkit.org/show_bug.cgi?id=89937

Reviewed by Jocelyn Turcotte.

Perform conversion in QImage only if the image format is not ARGB32 or
ARGB32_Premultiplied. Otherwise, allow packPixels to perform the conversion if the formats
don't match, as packPixels already performs pixel-specific operations.

Covered by tests in LayoutTests/fast/canvas/webgl, e.g. webgl-composite-modes.html.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::getImageData):

3:07 PM Exposing WebKit internals for Layout Tests edited by petewil@chromium.org
(diff)
3:05 PM Exposing WebKit internals for Layout Tests edited by petewil@chromium.org
(diff)
3:04 PM Exposing WebKit internals for Layout Tests created by petewil@chromium.org
Added instructions (still needs formatting)
3:04 PM Changeset in webkit [121291] by jsbell@chromium.org
  • 13 edits in trunk/Source/WebCore

IndexedDB: Move method precondition checks to front end objects
https://bugs.webkit.org/show_bug.cgi?id=89377

Reviewed by Tony Chang.

Now that metadata exists on the front end, most of the pre-condition validation checks
done on IDB method calls from script can be moved to the front end which simplifies the
code significantly in the case of complex methods like IDBObjectStore::put().

Adds an internal "active" flag for transactions, although the behavior is not accurate
to the spec (it should only be true during event callbacks - http://webkit.org/b/89379).
The back-end methods can then be simplifed to just adding async tasks to the transaction,
and the front end methods can take care of all exception cases except for asynchronous
transaction abort which still requires plumbing back to the front end.

No functional changes - no new tests.

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::update): Migrate from IDBObjectStoreBackendImpl::put.
(WebCore::IDBCursor::advance): Add more explicit transaction-is-active check.
(WebCore::IDBCursor::continueFunction): Ditto.
(WebCore::IDBCursor::deleteFunction): Ditto.
(WebCore::IDBCursor::effectiveObjectStore): Convenience function (source may be store or index).
(WebCore):

  • Modules/indexeddb/IDBCursor.h:

(WebCore::IDBCursor::isKeyCursor): Distinguish from IDBCursorWithValue.
(IDBCursor):

  • Modules/indexeddb/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::update): Remove migrated check.

  • Modules/indexeddb/IDBCursorWithValue.h:

(IDBCursorWithValue):

  • Modules/indexeddb/IDBDatabase.cpp: Migrate checks.

(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::deleteObjectStore):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp: Replace checks with assertions.

(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):

  • Modules/indexeddb/IDBIndex.cpp: Add transaction-is-active checks.

(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::count):
(WebCore::IDBIndex::openKeyCursor):
(WebCore::IDBIndex::get):
(WebCore::IDBIndex::getKey):

  • Modules/indexeddb/IDBObjectStore.cpp: Migrate cehcks.

(WebCore::IDBObjectStore::get):
(WebCore::IDBObjectStore::add): Delegates to put(PutMode)
(WebCore::IDBObjectStore::put): Delegates to put(PutMode)
(WebCore): Adds put(PutMode) which has the unified checks migrated from
IDBObjectStoreBackendImpl::put.
(WebCore::IDBObjectStore::deleteFunction):
(WebCore::IDBObjectStore::clear):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::deleteIndex):
(WebCore::IDBObjectStore::openCursor):
(WebCore::IDBObjectStore::count):

  • Modules/indexeddb/IDBObjectStore.h: Adds put(PutMode).

(IDBObjectStore):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::getInternal): Fix trace symbol.
(WebCore::IDBObjectStoreBackendImpl::put): Remove migrated checks.
(WebCore::IDBObjectStoreBackendImpl::createIndex): Remove migrated checks.
(WebCore::IDBObjectStoreBackendImpl::deleteIndex): Remove migrated checks.

  • Modules/indexeddb/IDBTransaction.cpp: Add active flag tracking.

(WebCore::IDBTransaction::IDBTransaction):
(WebCore::IDBTransaction::abort):
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):

  • Modules/indexeddb/IDBTransaction.h:

(WebCore::IDBTransaction::isActive):
(WebCore::IDBTransaction::isReadOnly): Group IDL/non-IDL methods.
(IDBTransaction):

3:03 PM WikiStart edited by petewil@chromium.org
(diff)
2:46 PM Changeset in webkit [121290] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Fix a test after r121286.

  • editing/deleting/merge-into-empty-block-2.html:
2:35 PM Changeset in webkit [121289] by commit-queue@webkit.org
  • 23 edits
    6 deletes in trunk

Unreviewed, rolling out r121285.
http://trac.webkit.org/changeset/121285
https://bugs.webkit.org/show_bug.cgi?id=90014

"We misinterpreted 'size of the initial containing block'"
(Requested by tomz on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-26

Source/WebCore:

  • css/CSSCalculationValue.cpp:

(WebCore::CSSCalcValue::computeLengthPx):
(WebCore::CSSCalcPrimitiveValue::toCalcValue):
(WebCore::CSSCalcPrimitiveValue::computeLengthPx):
(WebCore::CSSCalcBinaryOperation::toCalcValue):
(WebCore::CSSCalcBinaryOperation::computeLengthPx):

  • css/CSSCalculationValue.h:

(CSSCalcExpressionNode):
(WebCore::CSSCalcValue::toCalcValue):
(CSSCalcValue):

  • css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::addStops):
(WebCore::positionFromValue):
(WebCore::CSSGradientValue::computeEndPoint):
(WebCore::CSSLinearGradientValue::createGradient):
(WebCore::CSSRadialGradientValue::resolveRadius):
(WebCore::CSSRadialGradientValue::createGradient):

  • css/CSSGradientValue.h:

(CSSGradientValue):
(CSSRadialGradientValue):

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::computeLength):
(WebCore::CSSPrimitiveValue::computeLengthDouble):

  • css/CSSPrimitiveValue.h:

(CSSPrimitiveValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::convertToLength):

  • css/CSSToStyleMap.cpp:

(WebCore::CSSToStyleMap::mapFillSize):
(WebCore::CSSToStyleMap::mapFillXPosition):
(WebCore::CSSToStyleMap::mapFillYPosition):
(WebCore::CSSToStyleMap::mapNinePieceImageQuad):

  • css/CSSToStyleMap.h:

(CSSToStyleMap):

  • css/MediaQueryEvaluator.cpp:

(WebCore::computeLength):
(WebCore::device_heightMediaFeatureEval):
(WebCore::device_widthMediaFeatureEval):
(WebCore::heightMediaFeatureEval):
(WebCore::widthMediaFeatureEval):

  • css/SVGCSSStyleSelector.cpp:

(WebCore::StyleResolver::applySVGProperty):

  • css/StyleBuilder.cpp:

(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::convertToLength):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyPageSize::mmLength):
(WebCore::ApplyPropertyPageSize::inchLength):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

  • css/StyleResolver.h:

(StyleResolver):

  • css/WebKitCSSMatrix.cpp:

(WebCore::WebKitCSSMatrix::setMatrixValue):

LayoutTests:

  • css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vh-border-expected.html: Removed.
  • css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vh-border.html: Removed.
  • css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmin-border-expected.html: Removed.
  • css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmin-border.html: Removed.
  • css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vw-border-expected.htm: Removed.
  • css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vw-border.html: Removed.
  • ietestcenter/css3/valuesandunits/units-000.htm:
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
2:30 PM Changeset in webkit [121288] by commit-queue@webkit.org
  • 20 edits
    2 adds in trunk/Source

[chromium] Expose rendering statistics to WebWidget.
https://bugs.webkit.org/show_bug.cgi?id=88268

Patch by Dave Tu <dtu@chromium.org> on 2012-06-26
Reviewed by James Robinson.

The WebKit side of a basic framework for exposing rendering statistics
to Chromium's --enable-benchmarking extension.

Source/Platform:

  • chromium/public/WebLayerTreeView.h:

(WebRenderingStatistics):
(WebKit):
(WebLayerTreeView):

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeHost::implFrameNumber):

  • platform/graphics/chromium/cc/CCProxy.h:

(CCProxy):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::implFrameNumber):
(WebCore):
(WebCore::CCThreadProxy::implFrameNumberOnImplThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::renderingStatistics):
(WebKit):

2:21 PM Changeset in webkit [121287] by ojan@chromium.org
  • 3 edits in trunk/Tools

Fix platform picker change handler in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=90010

Reviewed by Simon Fraser.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:

The old code never worked. This is hard to test because change handlers require
a user-initiated action and the code is changing the window's location, which would
navigate the test page.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:

Fix the CSS so it doesn't cause the tabstrip to be disconnected from the tabs on Linux
due to the large margin-bottom.

2:06 PM Changeset in webkit [121286] by rniwa@webkit.org
  • 5 edits
    4 adds
    44 deletes in trunk/LayoutTests

Convert editing/deleting/delete-3959464-fix.html, delete-at-paragraph-boundaries-001.html, merge-into-empty-block-1.html and merge-into-empty-block-2.html to dump-as-markup tests
https://bugs.webkit.org/show_bug.cgi?id=90011

Reviewed by Eric Seidel.

  • editing/deleting/delete-3959464-fix-expected.txt: Added.
  • editing/deleting/delete-3959464-fix.html:
  • editing/deleting/delete-at-paragraph-boundaries-001-expected.txt: Added.
  • editing/deleting/delete-at-paragraph-boundaries-001.html:
  • editing/deleting/merge-into-empty-block-1-expected.txt: Added.
  • editing/deleting/merge-into-empty-block-1.html:
  • editing/deleting/merge-into-empty-block-2-expected.txt: Added.
  • editing/deleting/merge-into-empty-block-2.html:
  • platform/chromium-linux/editing/deleting/delete-3959464-fix-expected.png: Removed.
  • platform/chromium-linux/editing/deleting/delete-at-paragraph-boundaries-001-expected.png: Removed.
  • platform/chromium-linux/editing/deleting/merge-into-empty-block-1-expected.png: Removed.
  • platform/chromium-linux/editing/deleting/merge-into-empty-block-2-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/deleting/delete-at-paragraph-boundaries-001-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/deleting/merge-into-empty-block-1-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/deleting/merge-into-empty-block-2-expected.png: Removed.
  • platform/chromium-mac-snowleopard/editing/deleting/merge-into-empty-block-1-expected.png: Removed.
  • platform/chromium-mac-snowleopard/editing/deleting/merge-into-empty-block-2-expected.png: Removed.
  • platform/chromium-mac/editing/deleting/delete-3959464-fix-expected.png: Removed.
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-001-expected.png: Removed.
  • platform/chromium-mac/editing/deleting/merge-into-empty-block-1-expected.png: Removed.
  • platform/chromium-mac/editing/deleting/merge-into-empty-block-2-expected.png: Removed.
  • platform/chromium-win/editing/deleting/delete-3959464-fix-expected.png: Removed.
  • platform/chromium-win/editing/deleting/delete-3959464-fix-expected.txt: Removed.
  • platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-001-expected.png: Removed.
  • platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt: Removed.
  • platform/chromium-win/editing/deleting/merge-into-empty-block-1-expected.png: Removed.
  • platform/chromium-win/editing/deleting/merge-into-empty-block-1-expected.txt: Removed.
  • platform/chromium-win/editing/deleting/merge-into-empty-block-2-expected.png: Removed.
  • platform/chromium-win/editing/deleting/merge-into-empty-block-2-expected.txt: Removed.
  • platform/gtk/editing/deleting/delete-3959464-fix-expected.txt: Removed.
  • platform/gtk/editing/deleting/delete-at-paragraph-boundaries-001-expected.png: Removed.
  • platform/gtk/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt: Removed.
  • platform/gtk/editing/deleting/merge-into-empty-block-1-expected.png: Removed.
  • platform/gtk/editing/deleting/merge-into-empty-block-1-expected.txt: Removed.
  • platform/gtk/editing/deleting/merge-into-empty-block-2-expected.png: Removed.
  • platform/gtk/editing/deleting/merge-into-empty-block-2-expected.txt: Removed.
  • platform/mac/editing/deleting/delete-3959464-fix-expected.png: Removed.
  • platform/mac/editing/deleting/delete-3959464-fix-expected.txt: Removed.
  • platform/mac/editing/deleting/delete-at-paragraph-boundaries-001-expected.png: Removed.
  • platform/mac/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt: Removed.
  • platform/mac/editing/deleting/merge-into-empty-block-1-expected.png: Removed.
  • platform/mac/editing/deleting/merge-into-empty-block-1-expected.txt: Removed.
  • platform/mac/editing/deleting/merge-into-empty-block-2-expected.png: Removed.
  • platform/mac/editing/deleting/merge-into-empty-block-2-expected.txt: Removed.
  • platform/qt/editing/deleting/delete-3959464-fix-expected.png: Removed.
  • platform/qt/editing/deleting/delete-3959464-fix-expected.txt: Removed.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-001-expected.png: Removed.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt: Removed.
  • platform/qt/editing/deleting/merge-into-empty-block-1-expected.png: Removed.
  • platform/qt/editing/deleting/merge-into-empty-block-1-expected.txt: Removed.
  • platform/qt/editing/deleting/merge-into-empty-block-2-expected.png: Removed.
  • platform/qt/editing/deleting/merge-into-empty-block-2-expected.txt: Removed.
1:23 PM Changeset in webkit [121285] by tomz@codeaurora.org
  • 23 edits
    6 adds in trunk

ietestcenter/css3/valuesandunits/units-000.htm asserts
https://bugs.webkit.org/show_bug.cgi?id=86176

Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-06-26
Reviewed by Beth Dakin.

Source/WebCore:

Modified computeLengthDouble() to handle vh, vw, and vmin units. Per the spec
(http://dev.w3.org/csswg/css3-values/#viewport-relative-lengths) viewport -percentage
lengths are "relative to the size of the initial containing block", which I read to be
the size of the parent element. Since parentStyle was not available in computeLengthDouble,
most of the changes for this patch involved "pushing down" the parentStyle pointer through
the network of computeLength methods and dependencies.

Tests: css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vh-border.html

css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmin-border.html
css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vw-border.html

  • css/CSSCalculationValue.cpp:

(WebCore::CSSCalcValue::computeLengthPx):
(WebCore::CSSCalcPrimitiveValue::toCalcValue):
(WebCore::CSSCalcPrimitiveValue::computeLengthPx):
(WebCore::CSSCalcBinaryOperation::toCalcValue):
(WebCore::CSSCalcBinaryOperation::computeLengthPx):

  • css/CSSCalculationValue.h:

(CSSCalcExpressionNode):
(WebCore::CSSCalcValue::toCalcValue):
(CSSCalcValue):

  • css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::addStops):
(WebCore::positionFromValue):
(WebCore::CSSGradientValue::computeEndPoint):
(WebCore::CSSLinearGradientValue::createGradient):
(WebCore::CSSRadialGradientValue::resolveRadius):
(WebCore::CSSRadialGradientValue::createGradient):

  • css/CSSGradientValue.h:

(CSSGradientValue):
(CSSRadialGradientValue):

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::computeLength):
(WebCore::CSSPrimitiveValue::computeLengthDouble):

  • css/CSSPrimitiveValue.h:

(CSSPrimitiveValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::convertToLength):

  • css/CSSToStyleMap.cpp:

(WebCore::CSSToStyleMap::parentStyle):
(WebCore):
(WebCore::CSSToStyleMap::mapFillSize):
(WebCore::CSSToStyleMap::mapFillXPosition):
(WebCore::CSSToStyleMap::mapFillYPosition):
(WebCore::CSSToStyleMap::mapNinePieceImageQuad):

  • css/CSSToStyleMap.h:

(CSSToStyleMap):

  • css/MediaQueryEvaluator.cpp:

(WebCore::computeLength):
(WebCore::device_heightMediaFeatureEval):
(WebCore::device_widthMediaFeatureEval):
(WebCore::heightMediaFeatureEval):
(WebCore::widthMediaFeatureEval):

  • css/SVGCSSStyleSelector.cpp:

(WebCore::StyleResolver::applySVGProperty):

  • css/StyleBuilder.cpp:

(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::convertToLength):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyPageSize::mmLength):
(WebCore::ApplyPropertyPageSize::inchLength):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

  • css/StyleResolver.h:

(WebCore::StyleResolver::parentNode):
(StyleResolver):

  • css/WebKitCSSMatrix.cpp:

(WebCore::WebKitCSSMatrix::setMatrixValue):

LayoutTests:

Adding explicit tests for viewport border length tests. Inspired by IE Test center
units-000 test which highlighted that vw, vh, and vmin were not being handled in computeLengthDouble().
Also, adjusting test_expectations and Skipped for units-000, which no longer Asserts with this
patch implemented.

  • css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vh-border-expected.html: Added.
  • css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vh-border.html: Added.
  • css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmin-border-expected.html: Added.
  • css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmin-border.html: Added.
  • css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vw-border-expected.htm: Added.
  • css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vw-border.html: Added.
  • ietestcenter/css3/valuesandunits/units-000.htm:
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
1:17 PM Changeset in webkit [121284] by jamesr@google.com
  • 11 edits
    2 copies in trunk/Source

[chromium] Add WebLayer API for scrolling
https://bugs.webkit.org/show_bug.cgi?id=89913

Reviewed by Adrienne Walker.

Source/Platform:

Adds WebScrollableLayer type to represent a layer that can be scrolled by the user. Currently WebContentLayers
are scrollable and no other layer types are, although this might change in the future.

  • chromium/public/WebContentLayer.h:

(WebKit::WebContentLayer::WebContentLayer):

  • chromium/public/WebLayer.h:

(WebLayer):

  • chromium/public/WebScrollableLayer.h:

(WebKit):
(WebScrollableLayer):
(WebKit::WebScrollableLayer::WebScrollableLayer):
(WebKit::WebScrollableLayer::~WebScrollableLayer):
(WebKit::WebScrollableLayer::operator=):

Source/WebCore:

Use new WebScrollableLayer type in ScrollingCoordinatorChromium. This file peeks "under the hood" a fair amount
since we don't have WebLayer API for scrollbar layers yet.

  • page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::ScrollingCoordinatorPrivate::setScrollLayer):
(WebCore::ScrollingCoordinatorPrivate::setHorizontalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::setVerticalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::hasScrollLayer):
(WebCore::ScrollingCoordinatorPrivate::scrollLayer):
(ScrollingCoordinatorPrivate):
(WebCore::createScrollbarLayer):
(WebCore::ScrollingCoordinator::setScrollLayer):
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setWheelEventHandlerCount):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):

Source/WebKit/chromium:

Use WebScrollableLayer type in NonCompositedContentHost.

  • WebKit.gyp:
  • src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::setScrollLayer):
(WebKit::reserveScrollbarLayers):
(WebKit::NonCompositedContentHost::setViewport):
(WebKit::NonCompositedContentHost::haveScrollLayer):
(WebKit):
(WebKit::NonCompositedContentHost::scrollLayer):

  • src/NonCompositedContentHost.h:

(WebCore):

  • src/WebContentLayer.cpp:

(WebKit::WebContentLayer::WebContentLayer):

  • src/WebLayer.cpp:

(WebKit::WebLayer::numberOfChildren):
(WebKit):
(WebKit::WebLayer::childAt):
(WebKit::WebLayer::setAlwaysReserveTextures):

  • src/WebScrollableLayer.cpp:

(WebKit):
(WebKit::WebScrollableLayer::setScrollPosition):
(WebKit::WebScrollableLayer::setScrollable):
(WebKit::WebScrollableLayer::setHaveWheelEventHandlers):
(WebKit::WebScrollableLayer::setShouldScrollOnMainThread):

1:09 PM Changeset in webkit [121283] by jamesr@google.com
  • 5 edits in trunk

Unreviewed, rolling out r120501.
http://trac.webkit.org/changeset/120501
https://bugs.webkit.org/show_bug.cgi?id=89126

[skia] Fix is too heavy-handed

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::drawNeedsCopy):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::PlatformContextSkia):

  • platform/graphics/skia/PlatformContextSkia.h:

(PlatformContextSkia):
(WebCore::PlatformContextSkia::isDeferred):
(WebCore::PlatformContextSkia::setDeferred):

12:55 PM Changeset in webkit [121282] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[BlackBerry] Add JSC statistics into about:memory
https://bugs.webkit.org/show_bug.cgi?id=89779

Patch by Yong Li <yoli@rim.com> on 2012-06-26
Reviewed by Rob Buis.

Fix non-JIT build on BlackBerry broken by r121196.

  • runtime/MemoryStatistics.cpp:

(JSC::globalMemoryStatistics):

12:52 PM Changeset in webkit [121281] by mifenton@rim.com
  • 6 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Add WebPage interface for Async spell check.
https://bugs.webkit.org/show_bug.cgi?id=89999

Reviewed by Rob Buis.

PR 124517.

Add interface for IMS async spell checking.

Reviewed Internally by Nima Ghanavatian.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::spellCheckingRequestProcessed):
(WebKit):

  • Api/WebPage.h:
  • Api/WebPageClient.h:
  • WebKitSupport/InputHandler.cpp:

(WebKit):
(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):

  • WebKitSupport/InputHandler.h:

(InputHandler):

12:42 PM Changeset in webkit [121280] by fpizlo@apple.com
  • 15 edits
    15 adds in trunk

DFG::operationNewArray is unnecessarily slow, and may use the wrong array
prototype when inlined
https://bugs.webkit.org/show_bug.cgi?id=89821

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

Fixes all array allocations to use the right structure, and hence the right prototype. Adds
inlining of new Array(...) with a non-zero number of arguments. Optimizes allocations of
empty arrays.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleConstantInternalFunction):

  • dfg/DFGCCallHelpers.h:

(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(CCallHelpers):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • runtime/JSArray.h:

(JSC):
(JSC::constructArray):

  • runtime/JSGlobalObject.h:

(JSC):
(JSC::constructArray):

LayoutTests:

Rubber stamped by Geoffrey Garen.

  • fast/js/dfg-cross-global-object-inline-new-array-expected.txt: Added.
  • fast/js/dfg-cross-global-object-inline-new-array-literal-expected.txt: Added.
  • fast/js/dfg-cross-global-object-inline-new-array-literal-with-variables-expected.txt: Added.
  • fast/js/dfg-cross-global-object-inline-new-array-literal-with-variables.html: Added.
  • fast/js/dfg-cross-global-object-inline-new-array-literal.html: Added.
  • fast/js/dfg-cross-global-object-inline-new-array-with-elements-expected.txt: Added.
  • fast/js/dfg-cross-global-object-inline-new-array-with-elements.html: Added.
  • fast/js/dfg-cross-global-object-inline-new-array-with-size-expected.txt: Added.
  • fast/js/dfg-cross-global-object-inline-new-array-with-size.html: Added.
  • fast/js/dfg-cross-global-object-inline-new-array.html: Added.
  • fast/js/script-tests/cross-global-object-inline-global-var.js:

(done):

  • fast/js/script-tests/dfg-cross-global-object-inline-new-array-literal-with-variables.js: Added.

(foo):
(done):
(doit):

  • fast/js/script-tests/dfg-cross-global-object-inline-new-array-literal.js: Added.

(foo):
(done):
(doit):

  • fast/js/script-tests/dfg-cross-global-object-inline-new-array-with-elements.js: Added.

(foo):
(done):
(doit):

  • fast/js/script-tests/dfg-cross-global-object-inline-new-array-with-size.js: Added.

(foo):
(done):
(doit):

  • fast/js/script-tests/dfg-cross-global-object-inline-new-array.js: Added.

(foo):
(done):
(doit):

12:40 PM Changeset in webkit [121279] by jchaffraix@webkit.org
  • 3 edits in trunk/Source/WebCore

Crash in FixedTableLayout::layout
https://bugs.webkit.org/show_bug.cgi?id=88676

Unreviewed typo fix, pointed out by Darin Adler.

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::layout):

  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::layout):

12:36 PM Changeset in webkit [121278] by adamk@chromium.org
  • 4 edits in trunk

MutationObserver.observe should treat a null or undefined options argument as empty
https://bugs.webkit.org/show_bug.cgi?id=89992

Reviewed by Ojan Vafai.

Source/WebCore:

The WebIDL spec was recently updated to treat null or undefined
Dictionary arguments the same as the empty dictionary. This patch
updates MutationObserver.observe to follow that spec.

Note that we still throw a SYNTAX_ERR in this case, since it's an
error not to pass one of "attributes", "childList", or "characterData"
as a key in the dictionary.

  • dom/WebKitMutationObserver.cpp:

(WebCore::WebKitMutationObserver::observe):

LayoutTests:

  • fast/mutation/observe-exceptions-expected.txt:
12:34 PM Changeset in webkit [121277] by commit-queue@webkit.org
  • 5 edits
    1 delete in trunk/Source

[chromium] The single thread proxy should not automatically tick new animations.
https://bugs.webkit.org/show_bug.cgi?id=89996

Patch by Ian Vollick <vollick@chromium.org> on 2012-06-26
Reviewed by James Robinson.

Source/WebCore:

No new tests. No change to existing functionality.

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::CCSingleThreadProxy):
(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::didAddAnimation):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(WebCore):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCSingleThreadProxyTest.cpp: Removed.
12:21 PM Changeset in webkit [121276] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Mark a layout test as timeout
https://bugs.webkit.org/show_bug.cgi?id=90003

fast/js/repeat-cached-vm-reentry.html started timing out on Mac debug and Win debug builds
between r121233:121239.

  • platform/chromium/TestExpectations:
12:16 PM Changeset in webkit [121275] by jchaffraix@webkit.org
  • 4 edits
    6 adds in trunk

Crash in FixedTableLayout::layout
https://bugs.webkit.org/show_bug.cgi?id=88676

Reviewed by Abhishek Arya.

Source/WebCore:

Tests: fast/table/auto-table-layout-colgroup-removal-crash.html

fast/table/fixed-table-layout/colgroup-removal-crash.html
fast/table/fixed-table-layout/prepend-in-fixed-table.html

The issue comes from RenderTable not properly dirtying its preferred logical
widths. As the table layout codes (both fixed and auto), recomputes their internal
structures at computePreferredLogicalWidth, the internal structure doesn't match
the table sizing and we crash.

This fix adds a work-around in FixedTableLayout::layout (which matches AutoTableLayout).
The long-term fix would be to properly fix the logic but this is a lot safer, especially
since our logic is really not bullet-proof at the moment.

  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::layout):
Added an internal structure recomputation, if we have drifted from our table's structure.
Also we need to update nEffCols if we call calcWidthArray.

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::layout):
Added a comment matching FixedTableLayout. The nEffCols is unneeded but kept for consistency
with FixedTableLayout.

LayoutTests:

  • fast/table/auto-table-layout-colgroup-removal-crash-expected.txt: Added.
  • fast/table/auto-table-layout-colgroup-removal-crash.html: Added.
  • fast/table/fixed-table-layout/colgroup-removal-crash-expected.txt: Added.
  • fast/table/fixed-table-layout/colgroup-removal-crash.html: Added.

2 cases where we remove a colgroup after having done layout.

  • fast/table/fixed-table-layout/prepend-in-fixed-table-expected.txt: Added.
  • fast/table/fixed-table-layout/prepend-in-fixed-table.html: Added.

This is a copy of fast/table/prepend-in-anonymous-table.html modified to work with
fixed table layout. This covers a bug found during testing that is fixed as part of
this broader change.

11:58 AM Changeset in webkit [121274] by jchaffraix@webkit.org
  • 1 edit
    4 copies in branches/chromium/1180

Merge 120934 - Non-fixed length margins don't work with align=center
https://bugs.webkit.org/show_bug.cgi?id=89626

Reviewed by Levi Weintraub.

Source/WebCore:

Tests: fast/block/negative-start-margin-align-center-percent.html

fast/block/positive-margin-block-child-align-center-calc.html

Calling Length::value() is a bad idea as it returns the *raw* value of
the length. For percent and calculated length this is a bad idea as they
bear not relation to the actual computed length.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeInlineDirectionMargins):
Fixed the code to use minimumValueForLength as this nicely takes care of the 'auto' case.

LayoutTests:

  • fast/block/negative-start-margin-align-center-percent-expected.html: Added.
  • fast/block/negative-start-margin-align-center-percent.html: Added.
  • fast/block/positive-margin-block-child-align-center-calc-expected.html: Added.
  • fast/block/positive-margin-block-child-align-center-calc.html: Added.

TBR=jchaffraix@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10668050

11:42 AM Changeset in webkit [121273] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[chromium] Layer chromium should need a redraw after getting its first non-empty bounds.
https://bugs.webkit.org/show_bug.cgi?id=89784

Patch by Ian Vollick <vollick@chromium.org> on 2012-06-26
Reviewed by James Robinson.

Previously, we'd only set needs redraw if the old bounds were zero,
and the new bounds were non-zero, but we should actually have
checked that the old bounds were non-empty.

Source/WebCore:

Unit test: LayerChromiumTestWithoutFixture.setBoundsTriggersSetNeedsRedrawAfterGettingNonEmptyBounds

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setBounds):

Source/WebKit/chromium:

  • tests/LayerChromiumTest.cpp:
11:39 AM Changeset in webkit [121272] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Mark a layout test as fail
https://bugs.webkit.org/show_bug.cgi?id=89998

compositing/webgl/webgl-nonpremultiplied-blend.html started failing after r121267, give it IMAGE failure.

  • platform/chromium/TestExpectations:
11:38 AM Changeset in webkit [121271] by jpu@apple.com
  • 2 edits in trunk/Source/WebCore

On Mac, autocorrection sometimes fails to take place in Safari.
https://bugs.webkit.org/show_bug.cgi?id=89982

Reviewed by Darin Adler.

Existing test was turned off due to intermittent failure, which is caused by autocorrection result depending on user data
that may be altered by previous test runs. Hopefully we can turn the test back on once we have a way to make autocorrection
behave consistently.

Basically we should check the value of shouldCheckForCorrection, not shouldShowCorrectionPanel, to determine if we should
early return in markAndReplaceFor().

  • editing/Editor.cpp:

(WebCore::Editor::markAndReplaceFor):

11:34 AM Changeset in webkit [121270] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Do early-return when author and user styles are disabled.
https://bugs.webkit.org/show_bug.cgi?id=89947

Patch by Joe Thomas <joethomas@motorola.com> on 2012-06-26
Reviewed by Andreas Kling.

  • dom/Document.cpp:

(WebCore::Document::collectActiveStylesheets):

11:27 AM Changeset in webkit [121269] by commit-queue@webkit.org
  • 5 edits in trunk/Tools

webkitpy: Make webkit-patch patches-to-review useful
https://bugs.webkit.org/show_bug.cgi?id=89470

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-06-26
Reviewed by Eric Seidel.

webkit-patch patches-to-review will now output the list of
bugs with patches pending for review that has the user on CC,
excluding patches with cq-, sorted by the age of the patch.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(BugzillaQueries.fetch_bugs_from_review_queue):

  • Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:

(MockBugzillaQueries.fetch_bugs_from_review_queue):
(MockBugzilla.init):
(MockBugzilla.authenticate):

  • Scripts/webkitpy/tool/commands/queries.py:

(PatchesToReview):
(PatchesToReview.init):
(PatchesToReview._print_report):
(PatchesToReview._generate_report):
(PatchesToReview.execute):

  • Scripts/webkitpy/tool/commands/queries_unittest.py:

(QueryCommandsTest.test_patches_to_review):

11:09 AM Changeset in webkit [121268] by commit-queue@webkit.org
  • 8 edits in trunk/Source

[chromium] Remove dead compositor-related API from GraphicsContext3DPrivate / Extensions3DChromium
https://bugs.webkit.org/show_bug.cgi?id=89933

Patch by James Robinson <jamesr@chromium.org> on 2012-06-26
Reviewed by Kenneth Russell.

Source/WebCore:

GraphicsContext3DPrivate and Extensions3DChromium had a fair amount of plumbing and boilerplate to support the
compositor's use of GraphicsContext3D. A number of extensions, etc, only make sense for a compositor context.
Since the compositor doesn't use GC3D any more, these are no longer needed.

  • platform/chromium/support/Extensions3DChromium.cpp:
  • platform/chromium/support/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::create):

  • platform/chromium/support/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):
(WebCore::GrMemoryAllocationChangedCallbackAdapter::GrMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DPrivate::grContext):

  • platform/chromium/support/GraphicsContext3DPrivate.h:

(WebCore):
(GraphicsContext3DPrivate):

  • platform/graphics/chromium/Extensions3DChromium.h:

Source/WebKit/chromium:

  • tests/Canvas2DLayerBridgeTest.cpp:

(Canvas2DLayerBridgeTest::fullLifecycleTest):

10:56 AM Changeset in webkit [121267] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Add the workaround of IOSurface-related corruption during readback on Mac OS X.
https://bugs.webkit.org/show_bug.cgi?id=89797

Patch by Yasuhiro Matsuda <mazda@chromium.org> on 2012-06-26
Reviewed by James Robinson.

No new tests. This patch doesn't change behavior.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::getFramebufferPixels):

10:48 AM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
10:01 AM Changeset in webkit [121266] by dpranke@chromium.org
  • 3 edits in trunk/Tools

nrwt: broken for chromium on vista
https://bugs.webkit.org/show_bug.cgi?id=89988

Reviewed by Tony Chang.

r121194 removed support for 'chromium-win-vista' as a separate
port, but this actually prevented the code from running on vista
at all, which is unduly harsh and broke the websocket tests on
the (non-webkit) chromium bots that are still running on vista.

It's probably good enough to pretend that vista is win7 instead;
some layout tests will still fail but at least things'll run.

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:

(ChromiumWinPort.determine_full_port_name):

  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:

(ChromiumWinTest.test_versions):

9:30 AM Changeset in webkit [121265] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Native memory snapshots crash in debug mode.
https://bugs.webkit.org/show_bug.cgi?id=89977

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-06-26
Reviewed by Yury Semikhatsky.

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::maybeDOMWrapper):

9:20 AM Changeset in webkit [121264] by shawnsingh@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Fix incorrect #ifdef WEBKIT_IMPLEMENTATION statements
https://bugs.webkit.org/show_bug.cgi?id=89931

Reviewed by James Robinson.

WEBKIT_IMPLEMENTATION is defined as either 0 or 1, so the usage of
#ifdef or #if have different behavior. There are some places in
the code that use "#ifdef WEBKIT_IMLPEMENTATION", but they should
actually be "#if WEBKIT_IMPLEMENTATION". This patch fixes those
#ifdef statements.

  • public/WebTextRun.h:

(WebTextRun):

  • public/linux/WebFontRenderStyle.h:
8:00 AM Changeset in webkit [121263] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

master.cfg cleanup: Pass CheckOutSource instance instead of class to BuildStep.addStep
https://bugs.webkit.org/show_bug.cgi?id=89215

We need it because it is deprecated and will be dropped in buildbot 0.8.7

Reviewed by Tony Chang.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(CheckOutSource.init):
(Factory.init):

7:39 AM Changeset in webkit [121262] by commit-queue@webkit.org
  • 2 edits
    12 adds in trunk/LayoutTests

[Qt] Baseline missing for 3D transforms tests.
https://bugs.webkit.org/show_bug.cgi?id=89973

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-06-26
Reviewed by Csaba Osztrogonác.

Unskip the transforms/3d/hit-testing, and skip one failing transforms/3d/point-mapping test.
Add missing baselines for all unskipped 3D transforms tests.

  • platform/qt/Skipped:
  • platform/qt/transforms/3d/hit-testing/backface-hit-test-expected.txt: Added.
  • platform/qt/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.txt: Added.
  • platform/qt/transforms/3d/point-mapping/3d-point-mapping-2-expected.txt: Added.
  • platform/qt/transforms/3d/point-mapping/3d-point-mapping-3-expected.txt: Added.
  • platform/qt/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.txt: Added.
  • platform/qt/transforms/3d/point-mapping/3d-point-mapping-deep-expected.txt: Added.
  • platform/qt/transforms/3d/point-mapping/3d-point-mapping-expected.txt: Added.
  • platform/qt/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.txt: Added.
  • platform/qt/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt: Added.
7:01 AM Changeset in webkit [121261] by Simon Hausmann
  • 4 edits
    1 add in trunk

[Qt][Win] Symbols are not exported in QtWebKit5.dll
https://bugs.webkit.org/show_bug.cgi?id=88873

Reviewed by Tor Arne Vestbø.

Source/WebKit:

  • api.pri: Remove MAKEDLL setting done now in win32/default_post.prf.

Tools:

When linking the target dll make sure to re-export the symbols from
the static libraries marked as export, with the help of a little python
script and a qmake extra compiler.

  • Scripts/generate-win32-export-forwards: Added.
  • qmake/mkspecs/features/win32/default_post.prf:
6:09 AM Changeset in webkit [121260] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Texmap] Bug fix typo about computing bytesPerLine in BitmapTextureGL.
https://bugs.webkit.org/show_bug.cgi?id=89924

"bytesPerLine == targetRect.width() / 4" is invalid.
This patch amended it into "bytesPerLine == targetRect.width() * 4".
Moreover, changed magic number 4 to bytesPerPixel.

Patch by Huang Dongsung <luxtella@company100.net> on 2012-06-26
Reviewed by Noam Rosenthal.

No new tests. Covered by existing tests.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::updateContents):

6:07 AM Changeset in webkit [121259] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Shader compiler unprepared to make ESSL output when GLES is used
https://bugs.webkit.org/show_bug.cgi?id=87718

Patch by Roland Takacs <takacs.roland@stud.u-szeged.hu> on 2012-06-26
Reviewed by Noam Rosenthal.

Defined a new member that says what type of output code must be generated
(SH_GLSL_OUTPUT, SH_ESSL_OUTPUT). It is set within the constructor.

  • platform/graphics/ANGLEWebKitBridge.cpp:

(WebCore::ANGLEWebKitBridge::ANGLEWebKitBridge):
(WebCore::ANGLEWebKitBridge::validateShaderSource):

  • platform/graphics/ANGLEWebKitBridge.h:

(ANGLEWebKitBridge):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):

5:56 AM Changeset in webkit [121258] by pdr@google.com
  • 3 edits
    2 adds in trunk

Fix bug where animations failed to start
https://bugs.webkit.org/show_bug.cgi?id=89943

Reviewed by Nikolas Zimmermann.

Source/WebCore:

The unpause code previously checked that the animations had not started
before un-setting the pause state. This meant that if an animation was
paused and unpaused before the animations started, it would remain in the
paused state. This patch simply reorders the unpause logic to fix this bug.

Test: svg/custom/animate-initial-pause-unpause.html

  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::resume):

LayoutTests:

  • svg/custom/animate-initial-pause-unpause-expected.txt: Added.
  • svg/custom/animate-initial-pause-unpause.html: Added.
5:49 AM Changeset in webkit [121257] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening of new passing tests
https://bugs.webkit.org/show_bug.cgi?id=89970

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-06-26

  • platform/efl/TestExpectations:
5:32 AM Changeset in webkit [121256] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: popover is not shown for detached DOM nodes, not referenced directly from JS
https://bugs.webkit.org/show_bug.cgi?id=89955

Reviewed by Vsevolod Vlasov.

Show object popover for all heap snapshot nodes event for those whose
canBeQueried flag is false. We didn't show popover for such objects before
as it could lead to the backend crash. In the meantime the backend shouldn't
fail on such DOM wrappers and report an error if it cannot resolve
inspected object.

  • inspector/front-end/HeapSnapshotGridNodes.js:

(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotView.prototype._getHoverAnchor):

5:17 AM Changeset in webkit [121255] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Limit session storage quota to 5MB by default
https://bugs.webkit.org/show_bug.cgi?id=89941

Patch by Jonathan Dong <Jonathan Dong> on 2012-06-26
Reviewed by Rob Buis.

Limit session storage quota to 5MB by default for BlackBerry
porting.
Internally reviewed by George Staikos.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):

  • Api/WebSettings.cpp:

(WebKit):
(BlackBerry::WebKit::WebSettings::standardSettings):
(BlackBerry::WebKit::WebSettings::sessionStorageQuota):
(BlackBerry::WebKit::WebSettings::setSessionStorageQuota):

  • Api/WebSettings.h:
5:10 AM Changeset in webkit [121254] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Simplify SharedBuffer::createWithContentsOfFile() implementation
https://bugs.webkit.org/show_bug.cgi?id=89655

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-26
Reviewed by Csaba Osztrogonác.

Simplify the implementation of SharedBuffer::createWithContentsOfFile()
in EFL port.

No new test, no behavior change.

  • platform/efl/SharedBufferEfl.cpp:

(WebCore::SharedBuffer::createWithContentsOfFile):

4:27 AM Changeset in webkit [121253] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] REGRESSION (r121163): fast/frames/iframe-access-screen-of-deleted.html crashes
https://bugs.webkit.org/show_bug.cgi?id=89964

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-06-26
Reviewed by Andreas Kling.

Added missing null pointer check.

  • platform/efl/PlatformScreenEfl.cpp:

(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):

3:36 AM Changeset in webkit [121252] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] Assert failure in fast/canvas/canvas-createImageData.html for 64bit Debug bot
https://bugs.webkit.org/show_bug.cgi?id=89647

Unreviewed, update GTK test expectations.

r121215 has fixed the assertion failure, so the test doesn't crash
anymore.

Patch by Simon Pena <Simon Pena> on 2012-06-26

  • platform/gtk/TestExpectations:
3:26 AM Changeset in webkit [121251] by kinuko@chromium.org
  • 7 edits
    2 adds in trunk

Web Inspector: Add requestMetadata command and metadataReceived event to FileSystem
https://bugs.webkit.org/show_bug.cgi?id=87856

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-06-26
Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: http/tests/inspector/filesystem/get-metadata.html

  • inspector/Inspector.json:
  • inspector/InspectorFileSystemAgent.cpp:

(WebCore):
(WebCore::InspectorFileSystemAgent::requestFileSystemRoot):
(WebCore::InspectorFileSystemAgent::requestDirectoryContent):
(WebCore::InspectorFileSystemAgent::requestMetadata):

  • inspector/InspectorFileSystemAgent.h:

(InspectorFileSystemAgent):

  • inspector/front-end/FileSystemModel.js:

(WebInspector.FileSystemModel.prototype._directoryContentReceived):
(WebInspector.FileSystemModel.prototype.requestMetadata):
(WebInspector.FileSystemModel.Entry.prototype.get isDirectory):
(WebInspector.FileSystemModel.Entry.prototype.requestMetadata):
(WebInspector.FileSystemRequestManager):
(WebInspector.FileSystemRequestManager.prototype._directoryContentReceived):
(WebInspector.FileSystemRequestManager.prototype.requestMetadata.requestAccepted):
(WebInspector.FileSystemRequestManager.prototype.requestMetadata):
(WebInspector.FileSystemRequestManager.prototype._metadataReceived):
(WebInspector.FileSystemDispatcher.prototype.directoryContentReceived):
(WebInspector.FileSystemDispatcher.prototype.metadataReceived):

LayoutTests:

  • http/tests/inspector/filesystem/filesystem-test.js:

(initialize_FileSystemTest.InspectorTest.writeFile):
(initialize_FileSystemTest.InspectorTest.dumpMetadataRequestResult):
(initialize_FileSystemTest):
(writeFile.didGetFileSystem):
(writeFile):
(writeFile.didGetWriter.writer.onwrite):
(writeFile.didGetWriter):

  • http/tests/inspector/filesystem/get-metadata-expected.txt: Added.
  • http/tests/inspector/filesystem/get-metadata.html: Added.
3:19 AM Changeset in webkit [121250] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/Source/WebCore

[Qt] GraphicsSurface: Fix tile update artifacts on Mac
https://bugs.webkit.org/show_bug.cgi?id=89887

Reviewed by Noam Rosenthal.

  • platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:

(WebCore::GraphicsSurface::platformCopyToGLTexture):

3:17 AM Changeset in webkit [121249] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/Source/WebCore

GraphicsSurface: Fix IOSurfaceLock failures on Intel video cards.
https://bugs.webkit.org/show_bug.cgi?id=89883

Reviewed by Noam Rosenthal.

Follow the documentation which says: "If locking the buffer requires a readback,
the lock will fail with an error return of kIOReturnCannotLock."
Also make sure that we use the same set of flags when locking and unlocking
for simplicity and to follow this requirement on the kIOSurfaceLockReadOnly flag.

  • platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:

(WebCore::GraphicsSurface::platformLock):
(WebCore::GraphicsSurface::platformUnlock):

3:16 AM Changeset in webkit [121248] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/Tools

Add a note about hostname completion not working well with --cc completion

Reviewed by Simon Hausmann.

Hostname completion tries to resolve anything after an @ sign which is present
in the completed list of contributor emails to CC.

  • Scripts/webkit-tools-completion.sh:
3:11 AM Changeset in webkit [121247] by Csaba Osztrogonác
  • 3 edits in trunk/Tools

Unreviewed, rolling out r121244.
http://trac.webkit.org/changeset/121244
https://bugs.webkit.org/show_bug.cgi?id=89966

skip list path is incorrect now. (Requested by Ossy on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-26

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort.baseline_search_path):
(QtPort._skipped_file_search_paths):

  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:

(QtPortTest.test_baseline_search_path):

3:06 AM Changeset in webkit [121246] by pdr@google.com
  • 3 edits
    2 adds in trunk

Fix setCurrentTime for paused animations
https://bugs.webkit.org/show_bug.cgi?id=81350

Reviewed by Nikolas Zimmermann.

Source/WebCore:

SMILTimeContainer::setElapsed was not resetting the pause time, breaking
setCurrentTime if the animation was paused.

Test: svg/custom/animate-pause-resume.html

  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::setElapsed):

LayoutTests:

This test does not use the SVG animation test framework because the framework
works by pausing animations and testing animated values at fixed times
(through calling setCurrentTime). Testing this patch requires that we run
the animation and cannot be tested with the animation test framework.

  • svg/custom/animate-pause-resume-expected.txt: Added.
  • svg/custom/animate-pause-resume.html: Added.
3:04 AM Changeset in webkit [121245] by charles.wei@torchmobile.com.cn
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Use gesture SwipeDown to exit fullscreen for both video and plugin.
https://bugs.webkit.org/show_bug.cgi?id=89960

Reviewed by Antonio Gomes.

We used to use gesture swipedown to exit fullscreen for plugin, but not fullscreen
HTML5 video; When a swipe down happens, it applies this event to all the pluginviews
in a page, even though only the one in fullscreen mode will process this.

With this patch, the SwipeDown gesture will only apply to the fullscreen elemement,
which is either a plugin, or an Video element.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::notifySwipeEvent):

2:42 AM Changeset in webkit [121244] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[Qt][NRWT] Fix baseline and skipped file search path.
https://bugs.webkit.org/show_bug.cgi?id=89882

Patch by János Badics <János Badics> on 2012-06-26
Reviewed by Csaba Osztrogonác.

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort.baseline_search_path):

  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:

(QtPortTest.test_baseline_search_path):

2:22 AM Changeset in webkit [121243] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

New fast/js/dfg-store-unexpected-value-into-argument-and-osr-exit.html fails on 32 bit
https://bugs.webkit.org/show_bug.cgi?id=89953

Reviewed by Zoltan Herczeg.

DFG 32-bit JIT was confused about the difference between a predicted type and a
proven type. This is easy to get confused about, since a local that is predicted int32
almost always means that the local must be an int32 since speculations are hoisted to
stores to locals. But that is less likely to be the case for arguments, where there is
an additional least-upper-bounding step: any store to an argument with a weird type
may force the argument to be any type.

This patch basically duplicates the functionality in DFGSpeculativeJIT64.cpp for
GetLocal: the decision of whether to load a local as an int32 (or as an array, or as
a boolean) is made based on the AbstractValue::m_type, which is a type proof, rather
than the VariableAccessData::prediction(), which is a predicted type.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

2:21 AM Changeset in webkit [121242] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

[Qt] Unreviewed typo fix after r121144.

  • Target.pri:
2:11 AM Changeset in webkit [121241] by tony@chromium.org
  • 8 edits in trunk

[Qt] Enable grid layout LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=89909

Reviewed by Csaba Osztrogonác.

Source/WebKit/qt:

These tests pass, we just need to hook up the overridePreference.

  • Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):
(QWebSettings::QWebSettings):

  • Api/qwebsettings.h: Add enum value for CSS grid layout

Tools:

These tests pass, we just need to hook up the overridePreference.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::resetSettings): Reset grid layout and regions between tests.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::overridePreference): Add WebKitCSSGridLayoutEnabled.

LayoutTests:

  • platform/qt/Skipped: Enable fast/css-grid-layout tests.
2:04 AM Changeset in webkit [121240] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: columns in heap snapshot summary view are not resizable
https://bugs.webkit.org/show_bug.cgi?id=89952

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/HeapSnapshotDataGrids.js:

(WebInspector.HeapSnapshotViewportDataGrid.prototype.onResize): overriden method
should call overriden one to make sure column resizers are added to the DataGrid.

1:25 AM Changeset in webkit [121239] by kkristof@inf.u-szeged.hu
  • 3 edits in trunk/Tools

Unreviewed, rolling out r121236.
http://trac.webkit.org/changeset/121236
https://bugs.webkit.org/show_bug.cgi?id=89956

It's broke the nrwt on qt and gtk platform (Requested by
kkristof on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-26

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort._build_driver):

  • Scripts/webkitpy/layout_tests/port/xvfbdriver.py:

(XvfbDriver._start):
(XvfbDriver._start.x_filter):
(XvfbDriver.stop):

12:59 AM Changeset in webkit [121238] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening after r120845.
Update expectations for test crashing in the GTK 64bit debug bot.

  • platform/gtk/TestExpectations: Add test to CRASHING section.
12:59 AM Changeset in webkit [121237] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Allow using <input type="color"> UI in ChromeOS.
https://bugs.webkit.org/show_bug.cgi?id=89944

Patch by Jun Mukai <mukai@chromium.org> on 2012-06-26
Reviewed by Kent Tamura.

http://crrev.com/144111 adds the UI of <input type="color"> for
ChromeOS, so now we can set its flag too.

  • features.gypi:
12:55 AM Changeset in webkit [121236] by kkristof@inf.u-szeged.hu
  • 3 edits in trunk/Tools

[NRWT] XvfbDriver should choose the next free display
https://bugs.webkit.org/show_bug.cgi?id=88414

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort._driver_class):

  • Scripts/webkitpy/layout_tests/port/xvfbdriver.py:

(XvfbDriver.init):
(XvfbDriver._start):
(XvfbDriver._start.next_free_id):
(XvfbDriver.stop):

12:55 AM Changeset in webkit [121235] by tkent@chromium.org
  • 4 edits in trunk/Source/WebCore

Refactoring: Simplify FormController interface
https://bugs.webkit.org/show_bug.cgi?id=89951

Reviewed by Kentaro Hara.

  • Remove FormController::hasStateForNewFormElements() takeStateForFormElement() can check the emptiness, and return an empty FormControlState.
  • Change the argument of takeStateForFormElement() Passing just one HTMLFormControlElementWithState object instead of two AtomicStringImpl. This is a preparation to use HTMLFormControlElementWithState::form() in FormController.

No new tests. Just a refactoring.

  • html/FormController.cpp:

(WebCore::FormController::takeStateForFormElement):

  • html/FormController.h:

(FormController):

  • html/HTMLFormControlElementWithState.cpp:

(WebCore::HTMLFormControlElementWithState::finishParsingChildren):

12:41 AM Changeset in webkit [121234] by dominicc@chromium.org
  • 11 edits in trunk

WheelEvent should inherit from MouseEvent
https://bugs.webkit.org/show_bug.cgi?id=76104

Reviewed by Kentaro Hara.

Source/WebCore:

The spec for WheelEvent is
<http://www.w3.org/TR/DOM-Level-3-Events/#webidl-events-WheelEvent>

Tests: fast/events/event-creation.html

http://samples.msdn.microsoft.com/ietestcenter/dominheritance/showdominheritancetest.htm?Prototype_WheelEvent

  • bindings/objc/PublicDOMInterfaces.h: Remove redundant MouseEvent API from WheelEvent
  • bindings/scripts/CodeGeneratorObjC.pm: MouseEvents are Events
  • dom/MouseEvent.h: Expose no-arg constructor to WheelEvent
  • dom/WheelEvent.cpp:

(WebCore::WheelEvent::WheelEvent): Call MouseEvent superconstructor
(WebCore::WheelEvent::isMouseEvent): Existing callers use this just for
moves and clicks, ie the type is exactly MouseEvent.

  • dom/WheelEvent.h: Extend MouseEvent
  • dom/WheelEvent.idl: "

LayoutTests:

  • fast/events/event-creation-expected.txt:
  • fast/events/event-creation.html: Also check WheelEvent instanceof MouseEvent as well as UIEvent, Event
12:24 AM Changeset in webkit [121233] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2][GTK] Uninitialized variable in TextCheckerGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=89948

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-26
Reviewed by Martin Robinson.

Properly initialize didInitializeState in
TextChecker::state().

  • UIProcess/gtk/TextCheckerGtk.cpp:

(WebKit::TextChecker::state):

Note: See TracTimeline for information about the timeline view.