Timeline


and

07/11/12:

23:18 Changeset [122421] by mrowe@apple.com

<http://webkit.org/b/91051> Fix the Qt Mac build after r122400.

Qt on Mac builds with a deployment target of OS X 10.5. However, it was not been setting
BUILDING_ON_LEOPARD / TARGETING_LEOPARD and thus was falling down code paths in DisplaySleepDisabler.cpp
that were specific to Snow Leopard and newer. After the removal of BUILDING_ON_LEOPARD
and TARGETING_LEOPARD it ended up falling down the correct Leopard-compatible code path,
which revealed that the code made assumptions about which headers had already been included.

  • platform/mac/DisplaySleepDisabler.cpp: Include CoreServices/CoreServices.h to pull in

a declaration of UpdateSystemActivity when targeting Leopard.

22:33 Changeset [122420] by commit-queue@webkit.org

Add dialog element feature toggle to InternalSettings
https://bugs.webkit.org/show_bug.cgi?id=90934

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-07-11
Reviewed by Hajime Morita.

.:

  • Source/autotools/symbols.filter: Added newly exported symbol.

Source/WebCore:

This enables layout tests to be written for dialog although the feature is disabled by default.

Tests: fast/dom/HTMLDialogElement/dialog-disabled.html

fast/dom/HTMLDialogElement/dialog-enabled.html

  • WebCore.exp.in: Added newly exported symbol.
  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup): Backup dialog feature flag.
(WebCore::InternalSettings::Backup::restoreTo): Restore dialog feature flag.
(WebCore::InternalSettings::setDialogElementEnabled): Added.
(WebCore):

  • testing/InternalSettings.h: Added support for dialog.

(Backup):
(InternalSettings):

  • testing/InternalSettings.idl: Added support for dialog.

LayoutTests:

  • fast/dom/HTMLDialogElement/dialog-disabled-expected.txt: Added.
  • fast/dom/HTMLDialogElement/dialog-disabled.html: Added.
  • fast/dom/HTMLDialogElement/dialog-enabled-expected.txt: Added.
  • fast/dom/HTMLDialogElement/dialog-enabled.html: Added.
  • platform/efl/TestExpectations: Skipped because ENABLE_DIALOG_ELEMENT is off by default.
  • platform/gtk/TestExpectations: Ditto.
  • platform/mac/TestExpectations: Ditto.
  • platform/qt/TestExpectations: Ditto.
22:20 Changeset [122419] by hayato@chromium.org

Unreviewed gardening.

  • platform/chromium/TestExpectations: Started TIMEOUT on Mac.
22:17 Changeset [122418] by tkent@chromium.org

Accessing width or height of a detached image input element causes crash
https://bugs.webkit.org/show_bug.cgi?id=90885

Reviewed by Kentaro Hara.

Source/WebCore:

Test: fast/forms/image/width-and-height-of-detached-input.html

  • html/ImageInputType.cpp:

(WebCore::ImageInputType::height): Add null check for m_imageLoader.
(WebCore::ImageInputType::width): ditto.

LayoutTests:

  • fast/forms/image/width-and-height-of-detached-input-expected.txt: Added.
  • fast/forms/image/width-and-height-of-detached-input.html: Added.
22:00 Changeset [122417] by mitz@apple.com

Actually commit the results for r122416.

21:58 Changeset [122416] by mitz@apple.com

Updated expected results for this test after r122408, which fixed it.

  • platform/mac/fast/multicol/table-vertical-align-expected.txt:
21:34 Changeset [122415] by hayato@chromium.org

Unreviewed gardening.
html5lib/runner.html started crashing after r122359.

  • platform/chromium/TestExpectations:
21:08 Changeset [122414] by tkent@chromium.org

Do not save state of stateless form controls
https://bugs.webkit.org/show_bug.cgi?id=90964

Reviewed by Hajime Morita.

Source/WebCore:

By Bug 89409, we started to store unmodified form control
state. However we don't need to make such state for the following
types.

  • password
  • submit
  • reset
  • button
  • keygen

Test: fast/forms/state-restore-skip-stateless.html

  • html/BaseButtonInputType.cpp:

(WebCore::BaseButtonInputType::shouldSaveAndRestoreFormControlState):
Added. Disable saving state for submit, reset, and button types.

  • html/BaseButtonInputType.h:

(BaseButtonInputType): Add shouldSaveAndRestoreFormControlState.

  • html/HTMLFormControlElementWithState.h:

(HTMLFormControlElementWithState): Make shouldSaveAndRestoreFormControlState virtual.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::shouldSaveAndRestoreFormControlState):
Added. Checks InputType::shouldSaveAndRestoreFormControlState first.

  • html/HTMLInputElement.h:

(HTMLInputElement): Override shouldSaveAndRestoreFormControlState.

  • html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::shouldSaveAndRestoreFormControlState)
Added. Disable saving state for <keygen>.:

  • html/HTMLKeygenElement.h: Override shouldSaveAndRestoreFormControlState.
  • html/InputType.cpp:

(WebCore::InputType::shouldSaveAndRestoreFormControlState):
Added. Enable saving state for all types by default.

  • html/InputType.h:

(InputType): Add shouldSaveAndRestoreFormControlState.

  • html/PasswordInputType.cpp:

(WebCore::PasswordInputType::shouldSaveAndRestoreFormControlState):
Added. Disabled saving state.
(WebCore::PasswordInputType::saveFormControlState):
Because shouldSaveAndRestoreFormControlState() returns false,
saveFormControlState should be never called.

  • html/PasswordInputType.h:

(PasswordInputType): Override shouldSaveAndRestoreFormControlState.

LayoutTests:

  • fast/forms/resources/state-restore-skip-stateless-dump.html: Added.
  • fast/forms/state-restore-skip-stateless-expected.txt: Added.
  • fast/forms/state-restore-skip-stateless.html: Added.
20:54 Changeset [122413] by noam.rosenthal@nokia.com

Compilation error with GLES2 when using gl2ext.h from ANGLE.
https://bugs.webkit.org/show_bug.cgi?id=91030

Reviewed by Kenneth Russell.

gl2ext.h defines PFNGLRENDERBUFFERSTORAGEMULTISAMPLEIMG and not
PFNGLRENDERBUFFERSTORAGEMULTISAMPLEIMGPROC. This is a bug in the original Khronos header,
but we should work around it until fixed headers are integrated.

  • platform/graphics/opengl/Extensions3DOpenGLES.h:

(Extensions3DOpenGLES):

Removed the "PROC" suffix to work around the header bug.

20:23 Changeset [122412] by mrowe@apple.com

Attempt to fix the Chromium Mac build after r122400.

  • platform/text/cf/HyphenationCF.cpp: Ensure that Chromium only compiles the body of this file if

building for a new enough version of OS X.

20:22 Changeset [122411] by commit-queue@webkit.org

[WK2][EFL] Ewk_View should provide more resource loading notifications
https://bugs.webkit.org/show_bug.cgi?id=90601

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-11
Reviewed by Antonio Gomes.

Add new "resource,request,sent", "resource,request,response",
"resource,request,failed" and "resource,request,finished" to
Ewk_View in order to notify the clients of the main resource
load state changes.

Introduce new Ewk_Url_Response type that is used to provide
information to the clients regarding the resource load
responses that are received.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/EWebKit2.h:
  • UIProcess/API/efl/ewk_url_response.cpp: Added.

(_Ewk_Url_Response):
(ewk_url_response_ref):
(ewk_url_response_unref):
(ewk_url_response_url_get):
(ewk_url_response_status_code_get):
(ewk_url_response_mime_type_get):
(ewk_url_response_new):

  • UIProcess/API/efl/ewk_url_response.h: Added.
  • UIProcess/API/efl/ewk_url_response_private.h: Added.
  • UIProcess/API/efl/ewk_view.cpp:

(_Ewk_View_Private_Data):
(ewk_view_resource_load_initiated):
(ewk_view_resource_load_response):
(ewk_view_resource_load_failed):
(ewk_view_resource_load_finished):
(ewk_view_resource_request_sent):
(ewk_view_load_provisional_started):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/ewk_view_private.h:
  • UIProcess/API/efl/ewk_view_resource_load_client.cpp:

(toEwkView):
(didInitiateLoadForResource):
(didSendRequestForResource):
(didReceiveResponseForResource):
(didFinishLoadForResource):
(didFailLoadForResource):
(ewk_view_resource_load_client_attach):

20:08 Changeset [122410] by tkent@chromium.org

[Mac] Sort project.pbxproj

  • WebCore.xcodeproj/project.pbxproj: Apply Tools/Scripts/sort-Xcode-project-file
19:49 Changeset [122409] by commit-queue@webkit.org

Build fix + remove dead code
https://bugs.webkit.org/show_bug.cgi?id=91039

Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2012-07-11
Reviewed by Filip Pizlo.

An unused variable was breaking compilation (thanks to warnings being treated as errors).

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

19:38 Changeset [122408] by mitz@apple.com

When a table row height grows because of pagination, not all cells’ heights are adjusted
https://bugs.webkit.org/show_bug.cgi?id=91043

Reviewed by Sam Weinig.

Source/WebCore:

The fix for in bug <http://webkit.org/b/83595> in <http://trac.webkit.org/r113738> made table
rows grow as necessary to fit cells that grow as a result of pagination. But it had two bad
side effects: earlier cells on the row would not grow by the same amount, and later cells on
the row would factor the existing growth into their intrinsic padding.

Test: fast/multicol/table-row-height-increase.html

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows): Now when a cell becomes taller than the row height,
the additional height needed is recorded, and the cell is shrunk back to row height. Then
after finishing the row, all cells occurring on the row (including cells spanning it but not
starting on it) are grown by the same amount.

LayoutTests:

  • fast/multicol/table-row-height-increase-expected.html: Added.
  • fast/multicol/table-row-height-increase.html: Added.
19:28 Changeset [122407] by mrowe@apple.com

Fix a logic error in the #if so that the correct code is compiled on Snow Leopard.

I introduced this in r122403 when I inverted the sense of the #if.

Source/WebKit/mac:

  • WebView/WebFullScreenController.mm:

Source/WebKit2:

  • UIProcess/mac/WKFullScreenWindowController.mm:
19:28 Changeset [122406] by ojan@chromium.org

Rebaseline after http://trac.webkit.org/changeset/122374.

  • platform/chromium-linux/css3/flexbox/repaint-rtl-column-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/flexbox/repaint-rtl-column-expected.png: Removed.
  • platform/chromium-mac/css3/flexbox/repaint-rtl-column-expected.png:
  • platform/chromium-win/css3/flexbox/repaint-rtl-column-expected.png:
19:03 Changeset [122405] by hayato@chromium.org

Unreviewed gardening.
inspector/timeline/timeline-dom-content-loaded-event.html started to fail after r122312.

  • platform/chromium/TestExpectations:
19:01 Changeset [122404] by mrowe@apple.com

<http://webkit.org/b/91024> Build against the latest SDK when targeting older OS X versions.

Reviewed by Dan Bernstein.

The deployment target is already set to the version that we're targeting, and it's that setting
which determines which functionality from the SDK is available to us.

Source/JavaScriptCore:

  • Configurations/Base.xcconfig:

Source/ThirdParty/ANGLE:

  • Configurations/Base.xcconfig:

Source/WebCore:

  • Configurations/Base.xcconfig:

Source/WebKit/mac:

  • Configurations/Base.xcconfig:

Source/WebKit2:

  • Configurations/Base.xcconfig:

Source/WTF:

  • Configurations/Base.xcconfig:

Tools:

  • DumpRenderTree/mac/Configurations/Base.xcconfig:
  • TestWebKitAPI/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/Base.xcconfig:
19:01 Changeset [122403] by mrowe@apple.com

<http://webkit.org/b/91022> WebFullScreenController and WKFullScreenWindowController shouldn't add unprefixed methods to AppKit classes

Reviewed by Dan Bernstein.

Source/WebKit/mac:

  • WebView/WebFullScreenController.mm:

(convertRectToScreen): Add a static helper method that calls through to -[NSWindow convertRectToScreen:] on OS versions where it exists
but otherwise provides a compatibility implementation of it.
(-[WebFullScreenController enterFullScreen:]): Call our new helper.

Source/WebKit2:

  • UIProcess/mac/WKFullScreenWindowController.mm:

(convertRectToScreen): Add a static helper method that calls through to -[NSWindow convertRectToScreen:] on OS versions where it exists
but otherwise provides a compatibility implementation of it.
(-[WKFullScreenWindowController enterFullScreen:]): Call our new helper.

19:00 Changeset [122402] by mrowe@apple.com

Replace definitions of BUILDING_ON / TARGETING macros with macros that will error when used.

Part of <http://webkit.org/b/91015> Remove BUILDING_ON / TARGETING macros in favor of system availability macros.

Reviewed by Anders Carlsson.

Source/WTF:

  • wtf/Platform.h:

Tools:

  • DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Remove the macros completely from here since

they're completely unused in TestNetscapePlugIn.

  • DumpRenderTree/config.h:
19:00 Changeset [122401] by mrowe@apple.com

Switch a few cases that care about the SDK over to checking MAC_OS_X_VERSION_MAX_ALLOWED so that things build.

Part of <http://webkit.org/b/91015> Remove BUILDING_ON / TARGETING macros in favor of system availability macros

Reviewed by Filip Pizlo.

Source/WebCore:

  • platform/graphics/cg/GraphicsContextCG.cpp: The SDK we're building against determines whether the constant is available.
  • platform/mac/EmptyProtocolDefinitions.h: The SDK we're building against determines whether the protocols are declared.
  • platform/mac/NSScrollerImpDetails.h: The SDK we're building against determines whether the constants and method are

available.

  • platform/mac/SharedTimerMac.mm: The SDK we're building against determines whether the function has already been declared.

Source/WTF:

  • wtf/FastMalloc.cpp:

(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary): The SDK we're building against determines how many elements
the structure is declared as having.

19:00 Changeset [122400] by mrowe@apple.com

<http://webkit.org/b/91015> Remove BUILDING_ON / TARGETING macros in favor of system availability macros

This removal was handled by a script that translates the relevant macros in to the equivalent checks
using the system availability macros.

Reviewed by Filip Pizlo.

Source/WebCore:

  • WebCore.exp.in:
  • accessibility/AccessibilityList.h:
  • accessibility/AccessibilityTable.h:
  • accessibility/mac/AXObjectCacheMac.mm:
  • editing/mac/EditorMac.mm:
  • loader/MainResourceLoader.cpp:
  • loader/MainResourceLoader.h:
  • page/AlternativeTextClient.h:
  • page/ContextMenuController.cpp:
  • page/mac/SettingsMac.mm:
  • platform/LocalizedStrings.cpp:
  • platform/MemoryPressureHandler.cpp:
  • platform/audio/mac/AudioBusMac.mm:
  • platform/graphics/Gradient.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
  • platform/graphics/ca/GraphicsLayerCA.cpp:
  • platform/graphics/ca/PlatformCALayer.h:
  • platform/graphics/ca/mac/PlatformCALayerMac.mm:
  • platform/graphics/ca/mac/TileCache.mm:
  • platform/graphics/cg/GraphicsContextCG.cpp:
  • platform/graphics/cg/ImageBufferCG.cpp:
  • platform/graphics/cg/ImageBufferDataCG.cpp:
  • platform/graphics/cg/ImageBufferDataCG.h:
  • platform/graphics/cg/ImageCG.cpp:
  • platform/graphics/cg/ImageSourceCG.cpp:
  • platform/graphics/cg/PathCG.cpp:
  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
  • platform/graphics/mac/ComplexTextController.cpp:
  • platform/graphics/mac/ComplexTextControllerCoreText.mm:
  • platform/graphics/mac/FontCacheMac.mm:
  • platform/graphics/mac/FontCustomPlatformData.cpp:
  • platform/graphics/mac/FontMac.mm:
  • platform/graphics/mac/GraphicsContextMac.mm:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  • platform/graphics/mac/SimpleFontDataMac.mm:
  • platform/graphics/mac/WebLayer.h:
  • platform/graphics/mac/WebLayer.mm:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
  • platform/mac/CursorMac.mm:
  • platform/mac/DisplaySleepDisabler.cpp:
  • platform/mac/DisplaySleepDisabler.h:
  • platform/mac/EmptyProtocolDefinitions.h:
  • platform/mac/HTMLConverter.h:
  • platform/mac/HTMLConverter.mm:
  • platform/mac/MemoryPressureHandlerMac.mm:
  • platform/mac/NSScrollerImpDetails.h:
  • platform/mac/PlatformEventFactoryMac.mm:
  • platform/mac/PopupMenuMac.mm:
  • platform/mac/ScrollAnimatorMac.mm:
  • platform/mac/ScrollElasticityController.mm:
  • platform/mac/SharedTimerMac.mm:
  • platform/mac/SuddenTermination.mm:
  • platform/mac/WebCoreFullScreenWindow.mm:
  • platform/mac/WebCoreNSCellExtras.h:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
  • platform/mac/WebFontCache.mm:
  • platform/mac/WebVideoFullscreenController.mm:
  • platform/mac/WebVideoFullscreenHUDWindowController.mm:
  • platform/network/Credential.h:
  • platform/network/ResourceHandle.h:
  • platform/network/cf/DNSCFNet.cpp:
  • platform/network/cf/ProxyServerCFNet.cpp:
  • platform/network/cf/ResourceRequest.h:
  • platform/network/cf/ResourceRequestCFNet.cpp:
  • platform/network/cf/SocketStreamHandleCFNet.cpp:
  • platform/network/mac/AuthenticationMac.mm:
  • platform/network/mac/CookieStorageMac.mm:
  • platform/network/mac/ResourceHandleMac.mm:
  • platform/network/mac/ResourceRequestMac.mm:
  • platform/network/mac/WebCoreURLResponse.mm:
  • platform/text/TextChecking.h:
  • platform/text/cf/HyphenationCF.cpp:
  • platform/text/mac/HyphenationMac.mm:
  • rendering/RenderLayerBacking.cpp:
  • rendering/RenderLayerCompositor.cpp:
  • rendering/RenderThemeMac.mm:

Source/WebKit/chromium:

  • src/mac/WebInputEventFactory.mm:

Source/WebKit/mac:

  • DefaultDelegates/WebDefaultContextMenuDelegate.mm:
  • Misc/WebKitErrors.m:
  • Misc/WebNSControlExtras.m:
  • Misc/WebNSFileManagerExtras.mm:
  • Plugins/Hosted/WebHostedNetscapePluginView.mm:
  • Plugins/WebBaseNetscapePluginView.mm:
  • Plugins/WebNetscapePluginView.mm:
  • WebCoreSupport/WebChromeClient.mm:
  • WebCoreSupport/WebEditorClient.mm:
  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebCoreSupport/WebSystemInterface.mm:
  • WebView/WebClipView.mm:
  • WebView/WebDynamicScrollBarsView.mm:
  • WebView/WebFrameView.mm:
  • WebView/WebFullScreenController.mm:
  • WebView/WebHTMLView.mm:
  • WebView/WebHTMLViewInternal.h:
  • WebView/WebPDFDocumentExtras.mm:
  • WebView/WebPreferences.mm:
  • WebView/WebResourceInternal.h:
  • WebView/WebScriptDebugDelegate.h:
  • WebView/WebView.mm:
  • WebView/WebViewPrivate.h:

Source/WebKit2:

  • Shared/DictionaryPopupInfo.cpp:
  • Shared/DictionaryPopupInfo.h:
  • Shared/mac/PasteboardTypes.mm:
  • Shared/mac/WebEventFactory.mm:
  • UIProcess/API/mac/PDFViewController.mm:
  • UIProcess/API/mac/PageClientImpl.mm:
  • UIProcess/API/mac/WKView.mm:
  • UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h:
  • UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm:
  • UIProcess/Launcher/mac/EnvironmentVariables.cpp:
  • UIProcess/Launcher/mac/EnvironmentVariables.h:
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:
  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/mac/TextCheckerMac.mm:
  • UIProcess/mac/WKFullScreenWindowController.mm:
  • UIProcess/mac/WebContextMac.mm:
  • UIProcess/mac/WebPageProxyMac.mm:
  • WebKit2Prefix.h:
  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
  • WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:
  • WebProcess/WebCoreSupport/WebEditorClient.h:
  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/mac/WebPageMac.mm:
  • WebProcess/com.apple.WebProcess.sb.in:
  • WebProcess/mac/KeychainItemShimMethods.mm:
  • WebProcess/mac/SecItemShimMethods.mm:
  • WebProcess/mac/WebProcessMac.mm:
  • WebProcess/mac/WebProcessMainMac.mm:
  • WebProcess/mac/WebProcessShim.mm:

Source/WTF:

  • wtf/Assertions.cpp:
  • wtf/FastMalloc.cpp:
  • wtf/Platform.h:
  • wtf/ThreadingPthreads.cpp:
  • wtf/unicode/icu/CollatorICU.cpp:

Tools:

  • DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
  • DumpRenderTree/mac/CheckedMalloc.cpp:
  • DumpRenderTree/mac/DumpRenderTree.mm:
  • DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:
  • DumpRenderTree/mac/TextInputController.m:
  • TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
  • WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
  • WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
18:29 Changeset [122399] by rjkroege@chromium.org

Suppress horizontal conversion of PlatformWheelEvents when hasPreciseScrollingDeltas is true
https://bugs.webkit.org/show_bug.cgi?id=89580

Source/WebCore:

WebKit GTK and Chromium Linux force vertical wheel events to
scroll horizontally when over horizontal scroll bars. This is
undesirable for touchpad scrolling with
hasPreciseScrollingDeltas() == true. Modified shouldTurnVerticalTicksIntoHorizontal
to not perform this conversion for PlatformWheelEvents with preciseScrollingDeltas.

Reviewed by Adam Barth.

Tests: fast/events/touch/gesture/touch-gesture-scroll-sideways.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::shouldTurnVerticalTicksIntoHorizontal):
(WebCore::EventHandler::handleWheelEvent):

  • page/EventHandler.h:

(EventHandler):

  • page/chromium/EventHandlerChromium.cpp:

(WebCore::EventHandler::shouldTurnVerticalTicksIntoHorizontal):

  • page/gtk/EventHandlerGtk.cpp:

(WebCore::EventHandler::shouldTurnVerticalTicksIntoHorizontal):

Tools:

WebKit GTK and Chromium Linux force vertical wheel events to
scroll horizontally when over horizontal scroll bars. This is
undesirable for touchpad scrolling with
hasPreciseScrollingDeltas() == true. Modified DumpRenderTree to
let a layout test specify this attribute so that the change's impact
on scrolling can be tested in a layout test.

Reviewed by Adam Barth.

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::handleMouseWheel):

LayoutTests:

WebKit GTK and Chromium Linux force vertical wheel events to
scroll horizontally when over horizontal scroll bars. This is
undesirable for touchpad scrolling with
hasPreciseScrollingDeltas() == true. Added a layout test showing
that change correctly suppresses this behaviour.

Reviewed by Adam Barth.

  • fast/events/touch/gesture/touch-gesture-scroll-sideways-expected.txt: Added.
  • fast/events/touch/gesture/touch-gesture-scroll-sideways.html: Added.
  • platform/chromium-linux/fast/events/touch/gesture/touch-gesture-scroll-sideways-expected.txt: Added. Note: test has intentional platform difference.
18:24 Changeset [122398] by commit-queue@webkit.org

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-11

  • DEPS:
18:22 Changeset [122397] by simon.fraser@apple.com

Fix the build by declaring -isPaginated before use.

  • MiniBrowser/mac/BrowserWindowController.m:
18:16 Changeset [122396] by hayato@chromium.org

Unreviewed gardening.
Build fix for r122373.

  • platform/chromium/support/WebCompositorSharedQuadState.cpp:

(WebKit::WebCompositorSharedQuadState::WebCompositorSharedQuadState):

17:54 Changeset [122395] by commit-queue@webkit.org

Unreviewed, rolling out r122358.
http://trac.webkit.org/changeset/122358
https://bugs.webkit.org/show_bug.cgi?id=91037

Build break on WebKit Win (Requested by hayato on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-11

Source/WebKit/chromium:

  • public/WebView.h:

(WebView):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::dragTargetDragEnter):
(WebKit):
(WebKit::WebViewImpl::dragTargetDragOver):
(WebKit::WebViewImpl::dragTargetDrop):

  • src/WebViewImpl.h:

(WebViewImpl):

Tools:

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::doDragDrop):
(EventSender::doMouseUp):
(EventSender::doMouseMove):
(EventSender::beginDragWithFiles):

17:45 Changeset [122394] by dpranke@chromium.org

nrwt: add a MessagePool abstraction that the manager will call to replace the broker
https://bugs.webkit.org/show_bug.cgi?id=90511

Reviewed by Ojan Vafai.

This change introduces the new MessagePool abstraction that will
replace the classes in manager_worker_broker. It is a minimal
interface that tries to follow the conventions in
multiprocessing.Pool and concurrency.futures ... it provides a
context manager and a run() method that sends N messages to M
workers processes (starting workers as necessary) and waits for
them all to complete, handling cleanup as necessary. The caller
is responsible for providing a handle() method to handle
messages received from the workers.

This interface basically hides all of the multiprocessing logic from
the manager class.

The initial implementation of MessagePool is a simple shim
around the existing broker classes; a subsequent change will
replace all the other classes with a much simpler
implementation.

No additional tests are provided for now; existing tests should
provide adequate coverage, and I will add new unit tests for the
MessagePool class when I replace the existing implementation.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(TestRunInterruptedException.reduce):
(Manager.init):
(Manager._run_tests):
(Manager._run_tests.instead):
(Manager.handle):
(Manager._handle_started_test):
(Manager._handle_finished_test_list):
(Manager._handle_finished_test):

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:

(get):
(_MessagePool):
(_MessagePool.init):
(_MessagePool.enter):
(_MessagePool.exit):
(_MessagePool.run):
(_MessagePool.wait):
(_MessagePool.is_done):
(_MessagePool._worker_is_done):
(_MessagePool._close):
(_MessagePool.handle_done):
(_MessagePool.handle_started_test):
(_MessagePool.handle_finished_test):
(_MessagePool.handle_finished_test_list):
(_MessagePool.handle_exception):
(_MessagePool._log_messages):
(_MessagePool._handle_worker_exception):
(_WorkerState):
(_WorkerState.for):
(_WorkerState.init):
(_WorkerState.repr):
(_get_broker):

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:

(make_broker):

17:23 Changeset [122393] by simon.fraser@apple.com

pagesPerView param is misnamed for WKPageSetPageLength()
https://bugs.webkit.org/show_bug.cgi?id=91033

Rubber-stamped by Dan Bernstein.

The name of the second parameter to WKPageSetPageLength(),
'pagesPerView', was confusing; it's a page size (normally width)
in pixels.

  • UIProcess/API/C/WKPagePrivate.h:
17:12 Changeset [122392] by fpizlo@apple.com

DFG should have fast virtual calls
https://bugs.webkit.org/show_bug.cgi?id=90924

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

Implements virtual call support in the style of the old JIT, with the
caveat that we still use the same slow path for both InternalFunction
calls and JSFunction calls. Also rationalized the way that our
CodeOrigin indices tie into exception checks (previously it was a
strange one-to-one mapping with fairly limited assertions; now it's a
one-to-many mapping for CodeOrigins to exception checks, respectively).
I also took the opportunity to clean up
CallLinkInfo::callReturnLocation, which previously was either a Call or
a NearCall. Now it's just a NearCall. As well, exceptions during slow
path call resolution are now handled by returning an exception throwing
thunk rather than returning null. And finally, I made a few things
public that were previously private-with-lots-of-friends, because I
truly despise the thought of listing each thunk generating function as
a friend of JSValue and friends.

  • bytecode/CallLinkInfo.cpp:

(JSC::CallLinkInfo::unlink):

  • bytecode/CallLinkInfo.h:

(CallLinkInfo):

  • bytecode/CodeOrigin.h:

(JSC::CodeOrigin::CodeOrigin):
(JSC::CodeOrigin::isSet):

  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::AssemblyHelpers):

  • dfg/DFGCCallHelpers.h:

(JSC::DFG::CCallHelpers::CCallHelpers):

  • dfg/DFGGPRInfo.h:

(GPRInfo):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compileFunction):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::CallBeginToken::CallBeginToken):
(JSC::DFG::CallBeginToken::~CallBeginToken):
(CallBeginToken):
(JSC::DFG::CallBeginToken::set):
(JSC::DFG::CallBeginToken::registerWithExceptionCheck):
(JSC::DFG::CallBeginToken::codeOrigin):
(JSC::DFG::CallExceptionRecord::CallExceptionRecord):
(CallExceptionRecord):
(JSC::DFG::JITCompiler::currentCodeOriginIndex):
(JITCompiler):
(JSC::DFG::JITCompiler::beginCall):
(JSC::DFG::JITCompiler::notifyCall):
(JSC::DFG::JITCompiler::prepareForExceptionCheck):
(JSC::DFG::JITCompiler::addExceptionCheck):
(JSC::DFG::JITCompiler::addFastExceptionCheck):

  • dfg/DFGOperations.cpp:
  • dfg/DFGRepatch.cpp:

(JSC::DFG::dfgLinkFor):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheck):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

  • dfg/DFGThunks.cpp:

(JSC::DFG::emitPointerValidation):
(DFG):
(JSC::DFG::throwExceptionFromCallSlowPathGenerator):
(JSC::DFG::slowPathFor):
(JSC::DFG::linkForThunkGenerator):
(JSC::DFG::linkCallThunkGenerator):
(JSC::DFG::linkConstructThunkGenerator):
(JSC::DFG::virtualForThunkGenerator):
(JSC::DFG::virtualCallThunkGenerator):
(JSC::DFG::virtualConstructThunkGenerator):

  • dfg/DFGThunks.h:

(DFG):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):
(JSC::JIT::linkFor):

  • runtime/Executable.h:

(ExecutableBase):
(JSC::ExecutableBase::offsetOfJITCodeFor):
(JSC::ExecutableBase::offsetOfNumParametersFor):

  • runtime/JSValue.h:

(JSValue):

LayoutTests:

Rubber stamped by Oliver Hunt.

This changes which piece of code appears on top of the stack at the point of a stack
overflow. As far as Oliver and I can tell, it doesn't matter, so I just rebased the
test.

  • fast/js/stack-trace-expected.txt:
17:10 Changeset [122391] by simon.fraser@apple.com

Add an option to enter paginated mode in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=91035

Reviewed by Dan Bernstein.

Add an item to the Debug menu for MiniBrowser that puts
the web view into paginated mode. For now, we only
do left-to-right pagination, with a fixed column width.

  • MiniBrowser/mac/BrowserWindowController.h:
  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController validateMenuItem:]): Update the checked
state of the menu item.
(-[BrowserWindowController isPaginated]): Return YES if paginated.
(-[BrowserWindowController togglePaginationMode:]): Toggle in
and out of pagination mode.

  • MiniBrowser/mac/MainMenu.xib: Add the debug menu item.
17:09 Changeset [122390] by abarth@webkit.org

commit-queue instances on Compute Engine are missing git-svn
https://bugs.webkit.org/show_bug.cgi?id=91034

Reviewed by Eric Seidel.

git-svn is needed to actually commit to SVN from a git working copy.

  • EWSTools/cold-boot.sh:
17:05 Changeset [122389] by shinyak@chromium.org

SVGUseElement should not use Element::ensureShadowRoot().
https://bugs.webkit.org/show_bug.cgi?id=90938

Reviewed by Hajime Morita.

We would like to remove Element::ensureShadowRoot() because we would like to stabilize the lifecycle of Shadow DOM.
This patch rewrites SVGUseElement::create() not to use Element::ensureShadowRoot(). Since our convention to create
a shadow subtree is to create a method createShadowSubtree(), I obeyed it.

No new tests. Simple refactoring.

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::create):
(WebCore::SVGUseElement::createShadowSubtree):
(WebCore):

  • svg/SVGUseElement.h:

(SVGUseElement):

16:33 Changeset [122388] by fpizlo@apple.com

Accidentally used the wrong license (3-clause instead of 2-clause) in some
files I just committed.

Rubber stamped by Oliver Hunt.

  • bytecode/Watchpoint.cpp:
  • bytecode/Watchpoint.h:
  • jit/JumpReplacementWatchpoint.cpp:
  • jit/JumpReplacementWatchpoint.h:
16:17 Changeset [122387] by dpranke@chromium.org

webkitpy: lint code in webkitpy.layout_tests.models
https://bugs.webkit.org/show_bug.cgi?id=90416

Reviewed by Ojan Vafai.

Cleaning up errors reported from lint-webkitpy.

Also, suppress the warnings about wildcard imports in pylintrc;
we have nothing particularly against them.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py:

(TestConfigurationConverter.combinations):

  • Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:

(TestConfigurationTest.test_hash.query_unknown_key):
(TestConfigurationTest.test_eq):

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(ParseError.init):
(TestExpectationLine.init):
(TestExpectationsModel.get_expectations_string):
(TestExpectationsModel):
(TestExpectationsModel.expectation_to_string):
(TestExpectationsModel.add_expectation_line):
(TestExpectationsModel._clear_expectations_for_test):
(TestExpectationsModel._remove_from_sets):
(TestExpectations.get_expectations_string):
(TestExpectations.expectation_to_string):
(TestExpectations._report_warnings):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(Base.init):
(parse_exp):
(SkippedTests.check):
(TestExpectationParserTests.test_parse_empty_string):

  • Scripts/webkitpy/layout_tests/models/test_failures.py:

(FailureTimeout.init):
(FailureCrash.init):
(FailureImageHashMismatch.init):
(FailureReftestMismatch.init):
(FailureReftestMismatchDidNotOccur.init):
(FailureReftestNoImagesGenerated.init):

  • Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:

(TestFailuresTest.test_unknown_failure_type.UnknownFailure.message):
(TestFailuresTest.test_unknown_failure_type):
(TestFailuresTest):
(TestFailuresTest.test_message_is_virtual):

  • Scripts/webkitpy/layout_tests/models/test_results.py:

(TestResult.loads):
(TestResult.has_failure_matching_types):

  • Scripts/webkitpy/pylintrc:
16:15 Changeset [122386] by abarth@webkit.org

Unreviewed. Remove empty directories.

  • http/tests/websocket/tests/resources: Removed.
  • http/tests/websocket/tests/script-tests: Removed.
  • http/tests/websocket/tests/workers: Removed.
  • http/tests/websocket/tests/workers/resources: Removed.
16:12 Changeset [122385] by fpizlo@apple.com

Watchpoints and jump replacement should be decoupled
https://bugs.webkit.org/show_bug.cgi?id=91016

Reviewed by Oliver Hunt.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • assembler/AbstractMacroAssembler.h:

(JSC):
(Label):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::appendWatchpoint):
(JSC::CodeBlock::watchpoint):
(DFGData):

  • bytecode/Watchpoint.cpp:

(JSC):

  • bytecode/Watchpoint.h:

(JSC::Watchpoint::Watchpoint):
(Watchpoint):
(JSC::Watchpoint::fire):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::speculationWatchpoint):

  • jit/JumpReplacementWatchpoint.cpp: Added.

(JSC):
(JSC::JumpReplacementWatchpoint::correctLabels):
(JSC::JumpReplacementWatchpoint::fireInternal):

  • jit/JumpReplacementWatchpoint.h: Added.

(JSC):
(JumpReplacementWatchpoint):
(JSC::JumpReplacementWatchpoint::JumpReplacementWatchpoint):
(JSC::JumpReplacementWatchpoint::setDestination):

16:11 Changeset [122384] by dpranke@chromium.org

nrwt: clean up names in worker.py
https://bugs.webkit.org/show_bug.cgi?id=90510

Reviewed by Ojan Vafai.

This is the last patch in the series of refactoring worker.py;
all this does is change some names of methods, instance
variables, and method parameters to be clearer (it also changes
some code in manager.py and manager_worker.py to be consistent).

There are no functional changes in this patch and the existing
tests should cover everything.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.init):
(Manager.prepare_lists_and_print_output):
(Manager._run_tests.worker_factory):
(Manager._run_tests):
(Manager._show_results_html_file):
(Manager.handle_finished_test_list):
(_WorkerState.init):

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:

(_Broker.post_message):
(_Broker._dispatch_message):
(AbstractWorker.init):
(AbstractWorker.run):
(AbstractWorker.yield_to_caller):
(AbstractWorker.post):
(_WorkerConnection.init):

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:

(_TestWorker.init):
(_TestWorker.start):
(_TestWorker.handle):
(_TestWorker.stop):
(_TestsMixin):
(_TestsMixin.test_name):

  • Scripts/webkitpy/layout_tests/controllers/worker.py:

(Worker.init):
(Worker.del):
(Worker.start):
(Worker.handle):
(Worker._run_test):
(Worker.stop):
(Worker._timeout):
(Worker._kill_driver):
(Worker._run_test_with_timeout):
(Worker._clean_up_after_test):
(Worker._run_test_in_another_thread.SingleTestThread.run):
(Worker._run_test_in_this_thread):
(Worker._run_single_test):

16:06 Changeset [122383] by commit-queue@webkit.org

[chromium] Move compositor quads to Platform/chromium/public
https://bugs.webkit.org/show_bug.cgi?id=90582

Patch by Alexandre Elias <aelias@google.com> on 2012-07-11
Reviewed by Adrienne Walker.

This moves CCSharedQuadState, CCDrawQuad, and all but two CC*DrawQuad
classes to the WebKit namespace, as a first step to pushing them
across the process boundary for the ubercompositor.

  • The intent is to serialize the class hierarchy using the same

mechanism as WebInputEvent. In order to do this, there are three
requirements: pure POD data, a method returning size, and a packing
pragma.

  • Private data members are fine with this kind of serializer, and a

default constructor is not needed. Because of that, we can maintain
the same encapsulation and convenient APIs (behind
WEBKIT_IMPLEMENTATION) as the original classes. To ease the
transition, the original WebCore headers still exist and typedef to
the new classes.

  • However, SharedQuadState will be serialized using the normal

IPC_STRUCT_TRAITS macro, so I made its members public. A custom
serializer (on quad lists) will maintain the pointers from quads to
SharedQuadStates.

  • I converted the Material casting mechanism to materialCast() methods

living in the derived classes. That way, the WebCompositorQuad header
doesn't need to know about all its derived classes.

  • Quad classes not yet transitioned can still be used in

non-ubercompositor mode. CCRenderPassDrawQuad and CCYUVVideoDrawQuad
are currently non-POD and I left them in their original files.

This approach is the best I've found so far, since it preserves all
WebCore-facing APIs and avoids unnecessary code duplication (new quad
types or members can be added by modifying only one place). There
also should not be an unreasonable amount of custom serializer code
required.

Source/Platform:

  • Platform.gypi:
  • chromium/public/WebCompositorQuad.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCDrawQuad.h.

(WebKit):
(WebCompositorQuad):
(WebKit::WebCompositorQuad::quadRect):
(WebKit::WebCompositorQuad::quadTransform):
(WebKit::WebCompositorQuad::layerTransform):
(WebKit::WebCompositorQuad::layerRect):
(WebKit::WebCompositorQuad::scissorRect):
(WebKit::WebCompositorQuad::opacity):
(WebKit::WebCompositorQuad::needsBlending):
(WebKit::WebCompositorQuad::isLayerAxisAlignedIntRect):
(WebKit::WebCompositorQuad::quadVisibleRect):
(WebKit::WebCompositorQuad::isDebugQuad):
(WebKit::WebCompositorQuad::material):
(WebKit::WebCompositorQuad::sharedQuadState):
(WebKit::WebCompositorQuad::setSharedQuadState):

  • chromium/public/WebCompositorSharedQuadState.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCSolidColorDrawQuad.h.

(WebKit):
(WebCompositorSharedQuadState):

  • chromium/public/WebCompositorSolidColorQuad.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCSolidColorDrawQuad.h.

(WebKit):
(WebCompositorSolidColorQuad):
(WebKit::WebCompositorSolidColorQuad::color):

  • chromium/public/WebCompositorTextureQuad.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCTextureDrawQuad.h.

(WebKit):
(WebCompositorTextureQuad):
(WebKit::WebCompositorTextureQuad::uvRect):
(WebKit::WebCompositorTextureQuad::textureId):
(WebKit::WebCompositorTextureQuad::premultipliedAlpha):
(WebKit::WebCompositorTextureQuad::flipped):

Source/WebCore:

No new tests. (No-op refactoring.)

  • WebCore.gypi:
  • platform/chromium/support/WebCompositorQuad.cpp: Added.

(WebKit):
(WebKit::WebCompositorQuad::WebCompositorQuad):
(WebKit::WebCompositorQuad::opaqueRect):
(WebKit::WebCompositorQuad::setQuadVisibleRect):
(WebKit::WebCompositorQuad::size):

  • platform/chromium/support/WebCompositorSharedQuadState.cpp: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCSharedQuadState.cpp.

(WebKit):
(WebKit::WebCompositorSharedQuadState::WebCompositorSharedQuadState):
(WebKit::WebCompositorSharedQuadState::create):
(WebKit::WebCompositorSharedQuadState::isLayerAxisAlignedIntRect):

  • platform/chromium/support/WebCompositorSolidColorQuad.cpp: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCSolidColorDrawQuad.cpp.

(WebKit):
(WebKit::WebCompositorSolidColorQuad::create):
(WebKit::WebCompositorSolidColorQuad::WebCompositorSolidColorQuad):
(WebKit::WebCompositorSolidColorQuad::materialCast):

  • platform/chromium/support/WebCompositorTextureQuad.cpp: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCTextureDrawQuad.cpp.

(WebKit):
(WebKit::WebCompositorTextureQuad::create):
(WebKit::WebCompositorTextureQuad::WebCompositorTextureQuad):
(WebKit::WebCompositorTextureQuad::setNeedsBlending):
(WebKit::WebCompositorTextureQuad::materialCast):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawQuad):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCCheckerboardDrawQuad.cpp:

(WebCore::CCCheckerboardDrawQuad::create):
(WebCore::CCCheckerboardDrawQuad::CCCheckerboardDrawQuad):
(WebCore::CCCheckerboardDrawQuad::materialCast):
(WebCore):

  • platform/graphics/chromium/cc/CCCheckerboardDrawQuad.h:

(CCCheckerboardDrawQuad):

  • platform/graphics/chromium/cc/CCDebugBorderDrawQuad.cpp:

(WebCore::CCDebugBorderDrawQuad::create):
(WebCore::CCDebugBorderDrawQuad::CCDebugBorderDrawQuad):
(WebCore::CCDebugBorderDrawQuad::materialCast):
(WebCore):

  • platform/graphics/chromium/cc/CCDebugBorderDrawQuad.h:

(CCDebugBorderDrawQuad):

  • platform/graphics/chromium/cc/CCDrawQuad.cpp: Removed.
  • platform/graphics/chromium/cc/CCDrawQuad.h:

(WebCore):

  • platform/graphics/chromium/cc/CCIOSurfaceDrawQuad.cpp:

(WebCore::CCIOSurfaceDrawQuad::create):
(WebCore::CCIOSurfaceDrawQuad::CCIOSurfaceDrawQuad):
(WebCore::CCIOSurfaceDrawQuad::materialCast):
(WebCore):

  • platform/graphics/chromium/cc/CCIOSurfaceDrawQuad.h:

(CCIOSurfaceDrawQuad):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(WebCore):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:

(WebCore::CCRenderPassDrawQuad::create):
(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):
(WebCore::CCRenderPassDrawQuad::materialCast):
(WebCore):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:

(CCRenderPassDrawQuad):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore):

  • platform/graphics/chromium/cc/CCSharedQuadState.h:

(WebCore):

  • platform/graphics/chromium/cc/CCSolidColorDrawQuad.h:

(WebCore):

  • platform/graphics/chromium/cc/CCStreamVideoDrawQuad.cpp:

(WebCore::CCStreamVideoDrawQuad::create):
(WebCore::CCStreamVideoDrawQuad::CCStreamVideoDrawQuad):
(WebCore::CCStreamVideoDrawQuad::materialCast):
(WebCore):

  • platform/graphics/chromium/cc/CCStreamVideoDrawQuad.h:

(CCStreamVideoDrawQuad):

  • platform/graphics/chromium/cc/CCTextureDrawQuad.h:

(WebCore):

  • platform/graphics/chromium/cc/CCTileDrawQuad.cpp:

(WebCore::CCTileDrawQuad::create):
(WebCore::CCTileDrawQuad::CCTileDrawQuad):
(WebCore::CCTileDrawQuad::materialCast):
(WebCore):

  • platform/graphics/chromium/cc/CCTileDrawQuad.h:

(CCTileDrawQuad):

  • platform/graphics/chromium/cc/CCYUVVideoDrawQuad.cpp:

(WebCore::CCYUVVideoDrawQuad::create):
(WebCore::CCYUVVideoDrawQuad::CCYUVVideoDrawQuad):
(WebCore::CCYUVVideoDrawQuad::materialCast):
(WebCore):

  • platform/graphics/chromium/cc/CCYUVVideoDrawQuad.h:

(CCYUVVideoDrawQuad):

Source/WebKit/chromium:

  • tests/CCLayerTestCommon.cpp:

(CCLayerTestCommon::verifyQuadsExactlyCoverRect):

  • tests/CCSolidColorLayerImplTest.cpp:

(CCLayerTestCommon::TEST):

16:01 Changeset [122382] by rjkroege@chromium.org

[chromium] [regression] Don't use ScrollByPrecisePixels on Chromium Mac.
https://bugs.webkit.org/show_bug.cgi?id=91020

Reviewed by Adam Barth.

A change in https://bugs.webkit.org/show_bug.cgi?id=87535 to
improve the operation of smooth scrolling incorrectly caused
Chromium Mac to use the wrong scroll granularity on
hasPreciseScrollingDeltas() == true wheelevent scrolls.
Exclude the change on the Chromium Mac platform.

  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::handleWheelEvent): Adjusted #ifdef to exclude Chromium
Mac from ScrollByPrecisePixels change.

15:54 Changeset [122381] by abarth@webkit.org

The commit-queue needs some extra git config to be able to commit
https://bugs.webkit.org/show_bug.cgi?id=91025

Reviewed by Eric Seidel.

In order for the commit-queue to actually commit, it needs to know the
location of the SVN server.

  • EWSTools/cold-boot.sh:
15:48 Changeset [122380] by jpu@apple.com

On Mac, autocorrection sometimes fails to take place in Safari.
https://bugs.webkit.org/show_bug.cgi?id=89982

Reviewed by Ryosuke Niwa.

We should check the value of shouldCheckForCorrection, not shouldShowCorrectionPanel, to determine if we should
early return in markAndReplaceFor(). Also, since we don't want autocorrection to happen when we only change selection,
not the content, so we shouldn't set TextCheckingTypeCorrection flag in markMisspellingsAndBadGrammar() as this function
is triggered only by selection change.

  • editing/Editor.cpp:

(WebCore::Editor::markAndReplaceFor):
(WebCore::Editor::markMisspellingsAndBadGrammar):

15:42 Changeset [122379] by scherkus@chromium.org

Merging r120939 and r121043 to 1180 branch (Chrome video controls visual update).

BUG=134726
TEST=none

15:41 Changeset [122378] by commit-queue@webkit.org

Unreviewed, rolling out r122361.
http://trac.webkit.org/changeset/122361
https://bugs.webkit.org/show_bug.cgi?id=91027

Broke Windows build and fast/forms/state-restore-broken-
state.html (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-11

  • testing/Internals.idl:
15:38 Changeset [122377] by abarth@webkit.org

Teach EWSTools how to configure SVN auth credentials
https://bugs.webkit.org/show_bug.cgi?id=91021

Reviewed by Eric Seidel.

To move the commit-queue over to Google Compute Engine, we need a way
to configure the commit-queue's credentials during the machine build
process. There doesn't seem to be a nice command line way of
configuring SVN auth credentials. I tried doing a bogus commit and
supplying the credentials that way, but that's super hacky.

The approach in this patch is to write the config file directly. The
format of these configurations files is documented in the SVN book, so
this approach doesn't see too sketchy.

  • EWSTools/configure-svn-auth.sh: Added.
15:26 Changeset [122376] by simon.fraser@apple.com

Assertion ASSERTION FAILED: enclosingIntRect(rendererMappedResult) == enclosingIntRect(FloatQuad(result).boundingBox()) when compositing in paginated mode
https://bugs.webkit.org/show_bug.cgi?id=90919

Reviewed by Antti Koivisto.

Source/WebCore:

r121124 added a fast path for geometry mapping that goes via layers
when possible. However, this broke paginated pages, which put
the root (RenderView) layer into column mode, because it failed
to check for columns on the ancestor layer.

Rather than make a risky change to convertToLayerCoords(), add a local
function canMapViaLayer(), which is like RenderLayer::canUseConvertToLayerCoords(),
but doesn't check for compositing (compositing itself is not a reason
to avoid convertToLayerCoords). Call canMapViaLayer() with the ancestorLayer
to check whether the ancestor has columns, which fixes the bug.

Test: compositing/columns/geometry-map-paginated-assert.html

  • rendering/RenderGeometryMap.cpp:

(WebCore::canMapViaLayer):
(WebCore::RenderGeometryMap::pushMappingsToAncestor):

LayoutTests:

Test with a composited element in a document which is put into paginated mode.

  • compositing/columns/geometry-map-paginated-assert-expected.txt: Added.
  • compositing/columns/geometry-map-paginated-assert.html: Added.
15:12 Changeset [122375] by ojan@chromium.org

Dedupe suffixes passed to webkit-patch rebaseline
https://bugs.webkit.org/show_bug.cgi?id=91017

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(Rebaseline._suffixes_to_update):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(test_rebaseline_multiple_builders_and_tests_command_line):

14:52 Changeset [122374] by ojan@chromium.org

Simplify css3/flexbox/repaint-rtl-column.html
https://bugs.webkit.org/show_bug.cgi?id=91011

Reviewed by Tony Chang.

This test was doing something simple in a complicated way. Also, removing
the text should make it so that more ports can fallback to the same png.

  • css3/flexbox/repaint-rtl-column-expected.txt:
  • css3/flexbox/repaint-rtl-column.html:
  • platform/chromium-linux/css3/flexbox/repaint-rtl-column-expected.png:
14:38 Changeset [122373] by danakj@chromium.org

[chromium] Rename layerRect to contentRect for rects that live in content space
https://bugs.webkit.org/show_bug.cgi?id=90843

Reviewed by Adrienne Walker.

Source/WebCore:

Dropped the layerTransform() from CCSharedQuadState, as nothing should be
using it to draw with. RenderPasses need a weird drawTransform right now
which was stored in layerTransform, so moved this to the RenderPass quad.

No new tests. No change in behaviour.

  • platform/graphics/chromium/CanvasLayerTextureUpdater.cpp:

(WebCore::CanvasLayerTextureUpdater::paintContents):

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::update):
(WebCore::ContentLayerChromium::needMoreUpdates):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::update):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::visibleContentOpaqueRegion):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::visibleContentRect):
(WebCore::LayerChromium::setVisibleContentRect):
(LayerChromium):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawRenderPassQuad):
(WebCore::LayerRendererChromium::drawTileQuad):
(WebCore::LayerRendererChromium::drawYUVVideoQuad):
(WebCore::LayerRendererChromium::drawStreamVideoQuad):
(WebCore::LayerRendererChromium::drawIOSurfaceQuad):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::updateBounds):
(WebCore::TiledLayerChromium::setNeedsDisplayRect):
(WebCore::TiledLayerChromium::invalidateContentRect):
(WebCore::TiledLayerChromium::updateTiles):
(WebCore::TiledLayerChromium::setTexturePriorities):
(WebCore::TiledLayerChromium::setTexturePrioritiesInRect):
(WebCore::TiledLayerChromium::visibleContentOpaqueRegion):
(WebCore::TiledLayerChromium::updateContentRect):
(WebCore::TiledLayerChromium::needsIdlePaint):
(WebCore::TiledLayerChromium::idlePaintRect):

  • platform/graphics/chromium/TiledLayerChromium.h:

(TiledLayerChromium):

  • platform/graphics/chromium/cc/CCDrawQuad.h:

(WebCore::CCDrawQuad::visibleContentRect):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::createSharedQuadState):
(WebCore::CCLayerImpl::appendDebugBorderQuad):
(WebCore::CCLayerImpl::visibleContentOpaqueRegion):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::visibleContentRect):
(WebCore::CCLayerImpl::setVisibleContentRect):
(CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerTilingData.cpp:

(WebCore::CCLayerTilingData::contentRectToTileIndices):
(WebCore::CCLayerTilingData::opaqueRegionInContentRect):
(WebCore::CCLayerTilingData::setBounds):

  • platform/graphics/chromium/cc/CCLayerTilingData.h:

(CCLayerTilingData):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateVisibleContentRect):
(WebCore::layerShouldBeSkipped):
(WebCore):
(WebCore::calculateVisibleAndScissorRectsInternal):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::addOcclusionBehindLayer):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:

(WebCore::CCRenderPassDrawQuad::create):
(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:

(CCRenderPassDrawQuad):
(WebCore::CCRenderPassDrawQuad::drawTransform):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::createSharedQuadState):
(WebCore::CCRenderSurface::createReplicaSharedQuadState):
(WebCore::CCRenderSurface::appendQuads):

  • platform/graphics/chromium/cc/CCSharedQuadState.cpp:

(WebCore::CCSharedQuadState::create):
(WebCore::CCSharedQuadState::CCSharedQuadState):
(WebCore::CCSharedQuadState::isLayerAxisAlignedIntRect):

  • platform/graphics/chromium/cc/CCSharedQuadState.h:

(CCSharedQuadState):
(WebCore::CCSharedQuadState::visibleContentRect):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::appendQuads):
(WebCore::CCTiledLayerImpl::visibleContentOpaqueRegion):

Source/WebKit/chromium:

  • tests/CCLayerImplTest.cpp:

(WebCore::TEST):

  • tests/CCLayerTreeHostCommonTest.cpp:
  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/CCOcclusionTrackerTest.cpp:

(WebKitTests::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect::runMyTest):

  • tests/CCQuadCullerTest.cpp:
  • tests/CCRenderSurfaceTest.cpp:
  • tests/CCSolidColorLayerImplTest.cpp:

(CCLayerTestCommon::TEST):

  • tests/CCTiledLayerImplTest.cpp:

(CCLayerTestCommon::createLayer):
(CCLayerTestCommon::TEST):
(CCLayerTestCommon::getQuads):
(CCLayerTestCommon::coverageVisibleRectIntersectsTiles):
(CCLayerTestCommon::coverageVisibleRectIntersectsBounds):

  • tests/CCTiledLayerTestCommon.cpp:

(WebKitTests::FakeLayerTextureUpdater::prepareToUpdate):
(WebKitTests::FakeTiledLayerChromium::update):

  • tests/CCTiledLayerTestCommon.h:

(FakeTiledLayerChromium):

  • tests/LayerChromiumTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:
14:20 Changeset [122372] by cfleizach@apple.com

ARIA spinbutton role incorrectly mapped to ProgressIndicatorRole
https://bugs.webkit.org/show_bug.cgi?id=77298

Reviewed by Anders Carlsson.

Source/WebCore:

  • accessibility/AccessibilityObject.cpp:

(WebCore::createARIARoleMap):

LayoutTests:

  • platform/mac/accessibility/aria-spinbutton-expected.txt:
  • platform/mac/accessibility/aria-spinbutton.html:
14:14 Changeset [122371] by commit-queue@webkit.org

[BlackBerry] UserViewportArguments are not properly respected.
https://bugs.webkit.org/show_bug.cgi?id=91005

Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-07-11
Reviewed by Rob Buis.

PR# 170088.
Move scale and zooming reset on Committed before applying
the user viewport to avoid overriding it immediately.

Internal review by Konrad Piascik, Jacky Jiang.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setLoadState):

14:11 Changeset [122370] by abarth@webkit.org

Sorry, that wasn't supposed to actually land.

14:10 Changeset [122369] by commit-queue@webkit.org

OOPS! This commit should be rejected by the precommit hook.

14:03 Changeset [122368] by kseo@webkit.org

BitmapImage::frameIsCompleteAtIndex() must return false if ImageDecoder is not initialized.
https://bugs.webkit.org/show_bug.cgi?id=90757

Patch by Huang Dongsung <luxtella@company100.net> on 2012-07-11
Reviewed by Simon Fraser.

The current code fortunately has worked so far because only
BitmapImage::startAnimation calls frameIsCompleteAtIndex, and startAnimation
cannot call frameIsCompleteAtIndex if ImageDecoder is not yet initialized.
startAnimation returns at the first line becase shouldAnimate() always return
false in this case.

if (m_frameTimer
!shouldAnimate() frameCount() <= 1)

return;

This change is needed because parallel image decoders call
BitmapImage::frameIsCompleteAtIndex in other places too.

No new tests, manually tested whether the caller exists or not that
calls BitmapImage::frameIsCompleteAtIndex() before ImageDecoder is
initialized.

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::frameIsCompleteAtIndex):

13:56 Changeset [122367] by zandobersek@gmail.com

Unreviewed GTK gardening, adding an expectation for a test failing on the
64-bit Debug builder due to libxml2 2.8.0 being used and updating the
bug handle for another test.

  • platform/gtk/TestExpectations:
13:28 Changeset [122366] by kevino@webkit.org

[wx] Unreviewed build fix. Add new directories and a new LayoutTestController method.

13:23 Changeset [122365] by kevino@webkit.org

[wx] Unreviewed build fix. Don't try to build udis86_itab.c since it's included by another file.

13:20 Changeset [122364] by commit-queue@webkit.org

[BlackBerry] Implement Date/Time picker
https://bugs.webkit.org/show_bug.cgi?id=90911

Patch by Crystal Zhang <haizhang@rim.com> on 2012-07-11
Reviewed by Rob Buis.

Source/WebKit:

Add files into make file.

  • PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

Implement HTML Date/Time picker, also should delete popup when closing popup.

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::closePagePopup):

  • WebCoreSupport/DatePickerClient.cpp: Added.

(WebCore):
(WebCore::DatePickerClient::DatePickerClient):
(WebCore::DatePickerClient::~DatePickerClient):
(WebCore::DatePickerClient::generateHTML):
(WebCore::DatePickerClient::closePopup):
(WebCore::DatePickerClient::contentSize):
(WebCore::DatePickerClient::htmlSource):
(WebCore::DatePickerClient::setValueAndClosePopup):
(WebCore::DatePickerClient::didClosePopup):
(WebCore::DatePickerClient::writeDocument):

  • WebCoreSupport/DatePickerClient.h: Added.

(WebKit):
(WebCore):
(DatePickerClient):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::openDatePopup):

13:20 Changeset [122363] by kevino@webkit.org

[wx] Unreviewed build fix. Update code to use the new constant name.

13:18 Changeset [122362] by kevino@webkit.org

[wx] Unreviewed build fix. Ignore array and sequence types for attributes as well
as functions since the CPP bindings do not yet support them.

13:16 Changeset [122361] by kevino@webkit.org

[wx] Unreviewed build fix. Use DOMStringList instead of DOMString[] for in / out type.

13:14 Changeset [122360] by danakj@chromium.org

[chromium] Minimum size used for occlusion tracking should be a setting on CCLayerTreeHost
https://bugs.webkit.org/show_bug.cgi?id=90993

Reviewed by Adrienne Walker.

Source/WebCore:

Move the default minimum size used for occlusion tracking from the
CCOcclusionTracker class into CCLayerTreeSettings. This value is then
used on both threads as the lower limit for any occlusion to be
remembered.

This allows us to use (0, 0) as the minimum size for tests, allowing all
occlusion to be tracked.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintLayerContents):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeSettings::CCLayerTreeSettings):
(CCLayerTreeSettings):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):

  • platform/graphics/chromium/cc/CCOcclusionTracker.h:

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:
13:02 Changeset [122359] by abarth@webkit.org

[Chromium] Enable LEGACY_VIEWPORT_ADAPTION
https://bugs.webkit.org/show_bug.cgi?id=90991

Reviewed by Tony Chang.

Source/WebKit/chromium:

Chromium wishes to support LEGACY_VIEWPORT_ADAPTION. I actually thought
this was enabled before, but the enable bit got lost in the shuffle.

  • features.gypi:

LayoutTests:

These tests pass now that we've enabled this feature.

  • platform/chromium/TestExpectations:
12:59 Changeset [122358] by tony@chromium.org

[chromium] Remove drag and drop API methods that are no longer used
https://bugs.webkit.org/show_bug.cgi?id=90996

Reviewed by Adam Barth.

Source/WebKit/chromium:

In r117327, we added a parameter for modifier keys to these methods.
Chromium has since switched to using the methods that require the
extra parameter so we can remove these methods.

  • public/WebView.h:

(WebView):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::dragTargetDragEnter):
(WebKit::WebViewImpl::dragTargetDragOver):

  • src/WebViewImpl.h:

(WebViewImpl):

Tools:

Migrate DRT to use the methods that take modifier keys.

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::doDragDrop):
(EventSender::doMouseUp):
(EventSender::doMouseMove):
(EventSender::beginDragWithFiles):

12:48 Changeset [122357] by commit-queue@webkit.org

Add MIPS convertibleLoadPtr and other functions
https://bugs.webkit.org/show_bug.cgi?id=90714

Patch by Chao-ying Fu <fu@mips.com> on 2012-07-11
Reviewed by Oliver Hunt.

  • assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::labelIgnoringWatchpoints):
(MIPSAssembler):
(JSC::MIPSAssembler::replaceWithLoad):
(JSC::MIPSAssembler::replaceWithAddressComputation):

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::convertibleLoadPtr):
(MacroAssemblerMIPS):

12:41 Changeset [122356] by andersca@apple.com

Add -Wtautological-compare and -Wsign-compare warning flags
https://bugs.webkit.org/show_bug.cgi?id=90994

Reviewed by Mark Rowe.

Source/JavaScriptCore:

  • Configurations/Base.xcconfig:

Source/WebCore:

  • Configurations/Base.xcconfig:

Source/WebKit/mac:

  • Configurations/Base.xcconfig:

Source/WebKit2:

  • Configurations/Base.xcconfig:

Source/WTF:

  • Configurations/Base.xcconfig:
12:29 Changeset [122355] by noam.rosenthal@nokia.com

[Qt][WK2] Test actual rendering results in API tests
https://bugs.webkit.org/show_bug.cgi?id=80609

Reviewed by Alexis Menard.

Added a very basic test to tst_QQuickWebView to make sure rendering actually occurs.

  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView):
(tst_QQuickWebView::basicRenderingSanity):

12:29 Changeset [122354] by dino@apple.com

TileCache layers have wrong border debug color
https://bugs.webkit.org/show_bug.cgi?id=90922

Reviewed by Simon Fraser.

Source/WebCore:

Commit r122152 updated the layer hierarchy when a tile
cache is being used by the view. As part of that, GraphicsLayerClient::shouldUseTileCache()
was changed to return false in some situations (the idea was that it
should only be called from the createGraphicsLayer method). However
there were two other call points: one that sets the debug colors on
borders, the other was a call that keeps the document background in sync.

Add a new method usingTileCache() that returns the current state. Also fix
a FIXME where the debug code always called into the client rather than
caching the value on the GraphicsLayer.

Test: compositing/document-background-color.html

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::GraphicsLayer):
(WebCore::GraphicsLayer::updateDebugIndicators): check the local variable when
setting the debug colors.

  • platform/graphics/GraphicsLayer.h:

(GraphicsLayer): new bool member variable m_usingTileCache.

  • platform/graphics/GraphicsLayerClient.h:

(WebCore::GraphicsLayerClient::usingTileCache): new virtual method to query if
this client is actually using the tile cache.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::GraphicsLayerCA): set the member variable m_usingTileCache
if the GraphicsLayerClient says we are.

  • rendering/RenderLayerBacking.h:

(WebCore::RenderLayerBacking::usingTileCache):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::documentBackgroundColorDidChange): call usingTileCache()
rather than shouldUseTileCache(), because the latter's value might not always reflect
the existence of a cache.

LayoutTests:

Make sure that the document background color is updated
when using a Tile Cache.

  • compositing/document-background-color-expected.html: Added.
  • compositing/document-background-color.html: Added.
11:53 Changeset [122353] by rniwa@webkit.org

Clang build fix after r122345.
Also let XCode do its own thing.

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLCollection.cpp:

(WebCore::HTMLCollectionWithArrayStorage::item):

  • html/HTMLCollection.h:

(HTMLCollectionWithArrayStorage):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::itemInArrayAfter):

  • html/HTMLFormCollection.h:

(HTMLFormCollection):

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::itemInArrayAfter):

  • html/HTMLPropertiesCollection.h:

(HTMLPropertiesCollection):

11:49 Changeset [122352] by mrowe@apple.com

Add a Mountain Lion version of libWebKitSystemInterface.a.

Source/WebKit/mac:

Reviewed by John Sullivan.

  • Configurations/DebugRelease.xcconfig: Look for the library under its expected name.

Source/WebKit2:

Reviewed by John Sullivan.

  • Configurations/DebugRelease.xcconfig: Look for the library under its expected name.

Tools:

Reviewed by John Sullivan.

  • Scripts/copy-webkitlibraries-to-product-directory: Include libWebKitSystemInterfaceMountainLion.a in the list of libraries to copy.

WebKitLibraries:

Update the WebKitSystemInterface header and binaries.

Reviewed by John Sullivan.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceMountainLion.a: Added.
  • libWebKitSystemInterfaceSnowLeopard.a:
11:45 Changeset [122351] by pdr@google.com

Add a performance test for hit testing in SVG
https://bugs.webkit.org/show_bug.cgi?id=90811

Reviewed by Ryosuke Niwa.

The shape rendering code is changing a lot and I'd like a performance test to
make sure we don't regress, and to track our improvements.

Performance results in my Linux desktop:

RESULT SVG: SvgHitTesting= 105.0 ms
median= 103.5 ms, stdev= 4.60434577329 ms, min= 101.0 ms, max= 116.0 ms

RESULT SVG: SvgHitTesting= 97.8 ms
median= 96.5 ms, stdev= 2.67581763205 ms, min= 95.0 ms, max= 102.0 ms

RESULT SVG: SvgHitTesting= 104.3 ms
median= 104.0 ms, stdev= 1.41774468788 ms, min= 102.0 ms, max= 107.0 ms

RESULT SVG: SvgHitTesting= 103.6 ms
median= 103.5 ms, stdev= 1.2 ms, min= 102.0 ms, max= 106.0 ms

  • SVG/SvgHitTesting.html: Added.
11:45 Changeset [122350] by mrowe@apple.com

<http://webkit.org/b/90835> Teach bisect-builds to work with a Safari.app that has entitlements.

Reviewed by Dan Bernstein.

  • Scripts/bisect-builds: Use safariPathFromSafariBundle to determine which binary within the application

should be invoked.

11:42 Changeset [122349] by zandobersek@gmail.com

[Gtk] fast/events/keydown-function-keys.html is failing
https://bugs.webkit.org/show_bug.cgi?id=90891

Reviewed by Martin Robinson.

Work around the context menu being shown on F10 key being pressed by
unbiding the key when running tests in DumpRenderTree. The problem
appears when using a recent version of the xkeyboard-config package.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(setDefaultsToConsistentStateValuesForTesting):

11:30 Changeset [122348] by shawnsingh@chromium.org

Unreviewed build fix, forgot to add URLTestHelpers.* when landing r122344

  • tests/URLTestHelpers.cpp: Added.

(URLTestHelpers):
(WebKit::URLTestHelpers::registerMockedURLFromBaseURL):
(WebKit::URLTestHelpers::registerMockedURLLoad):

  • tests/URLTestHelpers.h: Added.

(WebKit):
(URLTestHelpers):
(WebKit::URLTestHelpers::toKURL):

11:15 Changeset [122347] by benjamin@webkit.org

Simplify the copying of JSC ARMv7's LinkRecord
https://bugs.webkit.org/show_bug.cgi?id=90930

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-07-11
Reviewed by Filip Pizlo.

The class LinkRecord is used by value everywhere in ARMv7Assembler. The compiler uses
memmove() to move the objects.

The problem is memmove() is overkill for this object, moving the value can be done with
3 load-store. This patch adds an operator= to the class doing more efficient copying.
This reduces the link time by 19%.

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::LinkRecord::LinkRecord):
(JSC::ARMv7Assembler::LinkRecord::operator=):
(JSC::ARMv7Assembler::LinkRecord::from):
(JSC::ARMv7Assembler::LinkRecord::setFrom):
(JSC::ARMv7Assembler::LinkRecord::to):
(JSC::ARMv7Assembler::LinkRecord::type):
(JSC::ARMv7Assembler::LinkRecord::linkType):
(JSC::ARMv7Assembler::LinkRecord::setLinkType):
(JSC::ARMv7Assembler::LinkRecord::condition):

11:14 Changeset [122346] by commit-queue@webkit.org

[Gtk] allow building with css-filters
https://bugs.webkit.org/show_bug.cgi?id=90908

.:

Add support for css-filters in Source/WebCore/GNUmakefile.am
configure.ac

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-07-11
Reviewed by Eric Seidel.

  • configure.ac:

Source/WebCore:

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-07-11
Reviewed by Eric Seidel.

Add support for css-filters in Source/WebCore/GNUmakefile.am
configure.ac

No functional change, so no new tests.

  • GNUmakefile.am:
11:13 Changeset [122345] by rniwa@webkit.org

HTMLFormCollection::item and HTMLPropertiesCollection::item should share code
https://bugs.webkit.org/show_bug.cgi?id=90932

Reviewed by Anders Carlsson.

Merged HTMLFormCollection::item and HTMLPropertiesCollection::item as HTMLCollectionWithArrayStorage::item,
which can be merged into HTMLCollection::item in a follow up patch.

Also moved the call to invalidateCacheIfNeeded into HTMLCollection::updateNameCache() as done in
HTMLPropertiesCollection.

In addition, moved the early bail out for when the base element doesn't have itemscope attribute from individual
functions to updateRefElements so that HTMLCollectionWithArrayStorage::item doesn't need to have this check.

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollectionWithArrayStorage::item): Added. It's based on HTMLPropertiesCollection::item but it only
has the single loop (as supposed to nested loops) as HTMLFormCollection doesn't have multiple items per element
in the array unlike HTMLPropertiesCollection. In addition, offsetInArray (was i in HTMLPropertiesCollection::item) is
incremented in each itemAfter due to this semantic difference in each itemAfter.
(WebCore::HTMLCollection::updateNameCache):
(WebCore::HTMLCollection::hasNamedItem):
(WebCore::HTMLCollection::namedItems):

  • html/HTMLCollection.h:

(HTMLCollectionWithArrayStorage):
(WebCore::HTMLCollectionWithArrayStorage::HTMLCollectionWithArrayStorage):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::HTMLFormCollection):
(WebCore::HTMLFormCollection::calcLength): Merged numberOfFormControlElements since it was only called here.
(WebCore::HTMLFormCollection::itemAfter): Added. HTMLFormCollection has exactly one item per element in the array
so we increment the offset in each iteration. Note that when we're continuing a search, we need to increment
the offset in order to avoid returning the same item.
(WebCore::HTMLFormCollection::updateNameCache):

  • html/HTMLFormCollection.h:

(HTMLFormCollection):

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::HTMLPropertiesCollection):
(WebCore::HTMLPropertiesCollection::updateRefElements): Set m_hasItemRefElements true upfront since we never fail to
update ref elements. Bail out as soon as we cleared the m_itemRefElements when the base element doesn't have itemscope
content attribute.
(WebCore::HTMLPropertiesCollection::itemAfter): Added. We reset previousItem to null because the existing itemAfter
requires previousItem be null when we're moving to a new entry in m_itemRefElements.
(WebCore::HTMLPropertiesCollection::calcLength):
(WebCore::HTMLPropertiesCollection::cacheFirstItem):
(WebCore::HTMLPropertiesCollection::updateNameCache): Merged findProperties since this was the only caller.
(WebCore::HTMLPropertiesCollection::names):
(WebCore::HTMLPropertiesCollection::namedItem):
(WebCore::HTMLPropertiesCollection::hasNamedItem):

  • html/HTMLPropertiesCollection.h:

(HTMLPropertiesCollection): Made updateRefElements public as it's called in HTMLCollectionWithArrayStorage::item.

11:10 Changeset [122344] by shawnsingh@chromium.org

[chromium] Use WEBKIT_IMPLEMENTATION == 1 for webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=90094

Reviewed by Adrienne Walker.

This patch adds the WEBKIT_IMPLEMENTATION = 1 define to
WebKitUnitTests.gyp. To get it to compile correctly, some string
and URL code was refactored and fixed, in particular GURL usage is
replaced with KURL usage.

  • WebKit.gyp:

added WEBKIT_IMPLEMENTATION == 1 for unit test code when in shared library
added URLTestHelpers to exclusion in shared library build, because it depends on webkit_support

  • WebKit.gypi:

added URLTestHelpers.h and .cpp to the build process

  • WebKitUnitTests.gyp:

added WEBKIT_IMPLEMENTATION == 1 for unit test code when not in shared library.
note that in shared library build, RunAllTests.cpp does not have WEBKIT_IMPLEMENTATION == 1.

  • public/WebDOMMessageEvent.h:

(WebKit::WebDOMMessageEvent::WebDOMMessageEvent):

  • tests/AssociatedURLLoaderTest.cpp:
  • tests/EventListenerTest.cpp:
  • tests/FrameTestHelpers.cpp:

(WebKit::FrameTestHelpers::loadFrame):

  • tests/FrameTestHelpers.h:
  • tests/ListenerLeakTest.cpp:

(WebKit::ListenerLeakTest::RunTest):

  • tests/PopupMenuTest.cpp:
  • tests/RunAllTests.cpp:
  • tests/URLTestHelpers.cpp: Added.

(URLTestHelpers):
(WebKit::URLTestHelpers::registerMockedURLFromBaseURL):
(WebKit::URLTestHelpers::registerMockedURLLoad):

  • tests/URLTestHelpers.h: Copied from Source/WebKit/chromium/public/WebDOMMessageEvent.h.

(WebKit):
(URLTestHelpers):
(WebKit::URLTestHelpers::toKURL):

  • tests/WebFrameTest.cpp:
  • tests/WebPageNewSerializerTest.cpp:
  • tests/WebPageSerializerTest.cpp:
  • tests/WebViewTest.cpp:
11:00 Changeset [122343] by commit-queue@webkit.org

RenderView layer is marked as fixed position container in the scrolling tree if page scale != 1
https://bugs.webkit.org/show_bug.cgi?id=89216

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-07-11
Reviewed by Simon Fraser.

Render layers with CSS transforms should become containers for any fixed
positioned descendants. However, because this check is done with
RenderLayer::hasTransform(), we also end up marking the RenderLayer for the
RenderView as fixed position container if a non-identity page scale factor is
used. This is because page scale is applied as a transform for that layer.

This breaks fixed position layers, because they become fixed relative to the
RenderView layer instead of outer scroll clip layer.

The fix is to avoid marking any root layers as fixed position containers.

No new test because the scrolling tree isn't currently testable.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

10:50 Changeset [122342] by jchaffraix@webkit.org

REGRESSION (r116203): overflow sections don't have scrollbars
https://bugs.webkit.org/show_bug.cgi?id=90052

Reviewed by Simon Fraser.

This issue stems from RenderLayers with overlay scrollbars not being considered
self-painting.

After r120395 (follow-up of r116203), we ignore subtrees that have no self-painting layer for
painting. Normal scrollbars are painted by their renderer so they were properly painted. However
overlay scrollbars need to be painted by their RenderLayer as a separate phase (see bug 57057) so
they were not painted anymore. The fix is simple: make RenderLayer with overlay scrollbars
self-painting as they should have been in the first place.

Unfortunately no tests as I don't think we have a good way of testing overlay
scrollbars. Tested manually though on the super simple test case from the bug.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::shouldBeSelfPaintingLayer):
Overlay scrollbars make the layer self-painting.

(WebCore::RenderLayer::updateScrollbarsAfterLayout):
Added a call to updateSelfPaintingLayer.

(WebCore::RenderLayer::styleChanged):
Moved the call to updateSelfPaintingLayer after recomputing the scrollbars to ensure proper behavior.
Added a comment underlining the reason.

(WebCore::RenderLayer::updateSelfPaintingLayer):
Renamed as it is now called during layout too.

  • rendering/RenderLayer.h:

(RenderLayer): Updated after updateSelfPaintingLayer rename.

10:50 Changeset [122341] by wingo@igalia.com

jsc: Parse options before creating global data
https://bugs.webkit.org/show_bug.cgi?id=90975

Reviewed by Filip Pizlo.

This patch moves the options parsing in "jsc" before the creation
of the JSGlobalData, so that --useJIT=no has a chance to take
effect.

  • jsc.cpp:

(CommandLine::parseArguments): Refactor to be a class, and take
argc and argv as constructor arguments.
(jscmain): Move arg parsing before JSGlobalData creation.

10:50 Changeset [122340] by noam.rosenthal@nokia.com

[Qt] QRawWebView should notify when rendering is done, so that pixel results can be grabbed at the appropriate moment.
https://bugs.webkit.org/show_bug.cgi?id=90641

Reviewed by Jocelyn Turcotte.

Source/WebKit2:

Implement LayerTreeCoordinator::forceRepaint with logic equivalent to the one in
LayerTreeHostCA. If we flush the layers synchronously when forceRepaint is called,when
WKPageForceRepaint returns we are guaranteed to have an up-to-date image, as the visible
tiles are also synchronously updated.

  • UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp:

(WebView::WebView):
(WebView::viewNeedsDisplay):
(WebView::frameLoaded):
(WebView):
(WebView::onRepaintDone):
(WebView::finishForceRepaint):
(WebView::finishFirstLayoutForFrame):
(tst_qrawwebview::doNoBackground1):
(tst_qrawwebview::doNoBackground2):
(tst_qrawwebview::doNoBackground3):
(tst_qrawwebview::run):

The test for QRawWebView has been updated to use the WebKit2 ForcePaint API prior to
generating the pixel results. This has exposed a timing bug in the test - setting the
transparentBackground property of a page has to be done before it's created. This has
been fixed in the test.

  • WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::forceRepaint):
(WebKit::LayerTreeCoordinator::performScheduledLayerFlush):
(WebKit):

Tools:

  • MiniBrowser/qt/raw/View.h: Comment used old class name (WKView).

(View):

10:09 Changeset [122339] by allan.jensen@nokia.com

NodesFromRect doesn't work on SVG root elements.
https://bugs.webkit.org/show_bug.cgi?id=89990

Reviewed by Antonio Gomes.

Source/WebCore:

Adds support for rect-based hit-testing on the SVG root element.
This means that while rect-based hit-testing is still not supported
within SVG elements, that at least it works on SVG root elements as
it would on any other replaced element.

Test: fast/dom/nodesFromRect-svg.html

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::nodeAtPoint):

LayoutTests:

Test nodesFromRect on SVG root elements.

  • fast/dom/nodesFromRect-svg-expected.txt: Added.
  • fast/dom/nodesFromRect-svg.html: Added.
09:56 Changeset [122338] by commit-queue@webkit.org

Deleting content at the top of prettypatch emails destroys HTML formatting
https://bugs.webkit.org/show_bug.cgi?id=90700
<rdar://problem/7488232>

Patch by Alice Cheng <alice_cheng@apple.com> on 2012-07-11
Reviewed by David Kilzer.

  • PrettyPatch/PrettyPatch.rb:
09:50 Changeset [122337] by commit-queue@webkit.org

[Android] sending an extra to the DRT apk so that DRT can be run in a seperate thread
https://bugs.webkit.org/show_bug.cgi?id=90831

Patch by Min Qin <qinmin@chromium.org> on 2012-07-11
Reviewed by Adam Barth.

On android, DRT needs to run in a background thread to avoid ANR.
However, the java tests are running on UI thread by default.
We need to send an intent extra to the apk so that it can run on a sub thread.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidDriver._start_once):

09:46 Changeset [122336] by ossy@webkit.org

[Qt] Unreviewed gardening.

  • platform/qt-5.0-wk2/Skipped: Skip a new crashing test.
  • platform/qt/Skipped: Typo fix.
08:14 Changeset [122335] by ossy@webkit.org

[Qt] REGRESSION(r107171): Fix --timeout option of Qt's DRT
https://bugs.webkit.org/show_bug.cgi?id=90966

Reviewed by Ryosuke Niwa.

  • DumpRenderTree/qt/main.cpp:

(main): Don't remove the argument, because takeOptionValue() did it before.

08:08 Changeset [122334] by ossy@webkit.org

[Qt] REGRESSION(r122250): It broke USE(3D_GRAPHICS)=1 and ENABLE(WEBGL)=0 builds
https://bugs.webkit.org/show_bug.cgi?id=90943

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-11
Reviewed by Csaba Osztrogonác.

Uses proper guarding in Extensions3DOpenGLCommon and Extensions3DOpenGLES as per https://bugs.webkit.org/show_bug.cgi?id=90506.

No new tests, becasue there is no new functionality.

  • platform/graphics/opengl/Extensions3DOpenGLCommon.cpp: Use proper guarding.
  • platform/graphics/opengl/Extensions3DOpenGLES.cpp: Use proper guarding.
08:05 Changeset [122333] by commit-queue@webkit.org

[Qt] Middle clicking a scrollbar causes text to be pasted.
https://bugs.webkit.org/show_bug.cgi?id=78444

Source/WebKit/qt:

Check if the event was already accepted before handling the clipboard.

Patch by Steffen Imhof <steffen.imhof@basyskom.com> on 2012-07-11
Reviewed by Simon Hausmann.

  • Api/qwebpage.cpp:

(QWebPagePrivate::mouseReleaseEvent):

LayoutTests:

Updated the scrollbars/scrollbar-middleclick-nopaste.html test to use an
<input> field as target for onpaste events. Using <body> did not work
(at least for Qt), because the onpaste events are not fired, even if
manually middle-clicking into the body. My guess would be that they are
not sent, because the body is non-editable. The changed test should
reflect the common use-case triggering the problem better.

Patch by Steffen Imhof <steffen.imhof@basyskom.com> on 2012-07-11
Reviewed by Simon Hausmann.

  • scrollbars/scrollbar-middleclick-nopaste.html:
07:50 Changeset [122332] by pfeldman@chromium.org

Web Inspector: migrate from background images to CSS for statusbar rendering.
https://bugs.webkit.org/show_bug.cgi?id=90902

Reviewed by Vsevolod Vlasov.

Source/WebCore:

This change removes statusbar* images and uses gradients and borders to re-create original inspector look.

  • WebCore.gypi:
  • inspector/front-end/Images/statusbarBackground.png: Removed.
  • inspector/front-end/Images/statusbarBottomBackground.png: Removed.
  • inspector/front-end/Images/statusbarButtons.png: Removed.
  • inspector/front-end/Images/statusbarMenuButton.png: Removed.
  • inspector/front-end/Images/statusbarMenuButtonSelected.png: Removed.
  • inspector/front-end/StatusBarButton.js:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:

(body.drawer-visible #main-status-bar):
(body.drawer-visible #main-status-bar::after):
(.status-bar-background):
(.status-bar > div):
(.glyph):
(button.status-bar-item):
(.status-bar button.status-bar-item:active):
(select.status-bar-item):
(select.status-bar-item, select.status-bar-item:hover):
(body.detached .alternate-status-bar-buttons-bar):
(.alternate-status-bar-buttons-bar):
(.alternate-status-bar-buttons-bar .status-bar-item):
(.alternate-status-bar-buttons-bar .status-bar-item.emulate-active):
(#drawer):
(body.drawer-visible #drawer-contents):
(#drawer-status-bar):

  • inspector/front-end/inspector.html:
  • inspector/front-end/scriptsPanel.css:

(button.status-bar-item.scripts-navigator-show-hide-button):
(button.status-bar-item.scripts-navigator-show-hide-button:active):
(button.status-bar-item.scripts-debugger-show-hide-button):
(button.status-bar-item.scripts-debugger-show-hide-button:active):

Source/WebKit/chromium:

  • WebKit.gypi:
  • src/js/Images/statusbarBackgroundChromium.png: Removed.
  • src/js/Images/statusbarBottomBackgroundChromium.png: Removed.
  • src/js/Images/statusbarButtonsChromium.png: Removed.
  • src/js/Images/statusbarMenuButtonChromium.png: Removed.
  • src/js/Images/statusbarMenuButtonSelectedChromium.png: Removed.
  • src/js/devTools.css:

(.status-bar-background):

07:35 Changeset [122331] by wjmaclean@chromium.org

[Chromium] Unreviewed gardening. fast/forms/textarea/textarea-state-restore.html is flaky (timeouts frquently).
https://bugs.webkit.org/show_bug.cgi?id=90980

Marking this test as possible TIMOUT in test expectations.

  • platform/chromium/TestExpectations:
07:06 Changeset [122330] by ossy@webkit.org

[Qt] Unreviewed gardening. Skip a failing test after r122327.
https://bugs.webkit.org/show_bug.cgi?id=90979.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-07-11

  • platform/qt/Skipped:
06:48 Changeset [122329] by wjmaclean@chromium.org

Unreviewed gardening. Mark inspector/extensions/extensions-events.html as TIMEOUT on non-debug builds.
https://bugs.webkit.org/show_bug.cgi?id=86439

This test has started timing out on non-debug builds as well, adding comment to existing bug.

  • platform/chromium/TestExpectations:
06:44 Changeset [122328] by jason.liu@torchmobile.com.cn

[BlackBerry] crash in CookieDatabaseBackingStore.
https://bugs.webkit.org/show_bug.cgi?id=90270

Reviewed by George Staikos.

There is one case for this crash.

  1. A browser crashes and locks cookies' database for a while.
  2. Open a new browser when the old one doesn't finish crashing.
  3. The new one writes the cookies' database and receives a SQLITE_BUSY error in CookieDatabaseBackingStore's invokeOpen. So this database isn't opened.
  4. invokeGetCookiesWithLimit returns 0.
  5. Crash happens when using a null pointer.

Add function setBusyTimeout(1000) and a guard for cookies' pointer.
setBusyTimeout will call sqlite3_busy_timeout.

When the SQLite database is accessed for reading it is locked for writing
until the reading access is finished. Another process cannot access the database
while it is locked. The timeout time sets a limit while this process tries to access
the locked database. If the database is unlocked within the timeout time it can be
accessed, otherwise an access fails.

No new tests. This crash is hard to reproduce, and it happens only on our platform.

  • platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:

(WebCore::CookieDatabaseBackingStore::getCookiesFromDatabase):

05:30 Changeset [122327] by vsevik@chromium.org

Web Inspector: Move revisions support to UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=90888

Reviewed by Pavel Feldman.

Source/WebCore:

Moved revisions support to UISourceCode.
Revision management code is moved unchanged where possible and should be refactored later.

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModelResourceBinding.prototype._innerStyleSheetChanged): revision is now added to uiSourceCode, not resource.

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._notifyUISourceCodeContentCommitted):
Extension server is now listening for Workspace.UISourceCodeContentCommitted event instead of ResourceTreeModel.ResourceContentCommitted.

  • inspector/front-end/Resource.js:
  • inspector/front-end/ResourceTreeModel.js: ResourceTreeModel.ResourceContentCommitted renamed to Workspace.UISourceCodeContentCommitted.
  • inspector/front-end/ResourceView.js:

(WebInspector.ResourceSourceFrame): ResourceSourceFrame is not update when revisions are added anymore as resource conenten is considered immutable now

  • inspector/front-end/RevisionHistoryView.js:

(WebInspector.RevisionHistoryView.populateRevisions):
(WebInspector.RevisionHistoryView):
(WebInspector.RevisionHistoryView.showHistory):
(WebInspector.RevisionHistoryView.prototype._createUISourceCodeItem):
(WebInspector.RevisionHistoryView.prototype._revisionAdded.get if):
(WebInspector.RevisionHistoryView.prototype._revisionAdded):
(WebInspector.RevisionHistoryView.prototype._revealUISourceCode.get if):
(WebInspector.RevisionHistoryView.prototype._revealUISourceCode):
(WebInspector.RevisionHistoryView.prototype._reset):

  • inspector/front-end/ScriptSnippetModel.js: Snippets are not loaded before ResourceTreeModel.mainFrame is available anymore.

(WebInspector.ScriptSnippetModel):
(WebInspector.ScriptSnippetModel.prototype._setScriptSnippetContent):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.requestOriginalContent):
(WebInspector.UISourceCode.prototype._setContent):
(WebInspector.UISourceCode.prototype.addRevision):
(WebInspector.UISourceCode.prototype._restoreRevisionHistory):
(WebInspector.UISourceCode.prototype._clearRevisionHistory):
(WebInspector.UISourceCode.prototype.revertToOriginal):
(WebInspector.UISourceCode.prototype.revertAndClearHistory):
(WebInspector.UISourceCode.prototype.revertAndClearHistory.clearHistory):
(WebInspector.UISourceCode.prototype.commitWorkingCopy):
(WebInspector.UISourceCode.prototype.canonicalMimeType):
(WebInspector.Revision):
(WebInspector.Revision._revisionHistoryRegistry):
(WebInspector.Revision._ensureStaleRevisionsFileteredOut.persist):
(WebInspector.Revision._ensureStaleRevisionsFileteredOut):
(WebInspector.Revision.prototype.get uiSourceCode):
(WebInspector.Revision.prototype.get timestamp):
(WebInspector.Revision.prototype.get content):
(WebInspector.Revision.prototype.revertToThis):
(WebInspector.Revision.prototype.contentURL):
(WebInspector.Revision.prototype.contentType):
(WebInspector.Revision.prototype.requestContent):
(WebInspector.Revision.prototype.searchInContent):
(WebInspector.Revision.prototype._persist):

  • inspector/front-end/UserAgentSupport.js: Drive-by closure compilation fix.
  • inspector/front-end/Workspace.js:
  • inspector/front-end/inspector.js: ScriptSnippetModel is now created after ResourceTreeModel.

LayoutTests:

  • http/tests/inspector/network/network-request-revision-content-expected.txt:
  • http/tests/inspector/network/network-request-revision-content.html:
  • inspector/debugger/script-snippet-model.html:
  • inspector/styles/styles-add-new-rule.html:
  • inspector/styles/styles-history.html:
04:26 Changeset [122326] by morrita@google.com

WebCoreSupport needs objects each of which follows major WebCore objects
https://bugs.webkit.org/show_bug.cgi?id=88499

Reviewed by Alexey Proskuryakov.

Source/WebCore:

This change

  • Makes Internals rough lifetime to follow Document. Note that Internals can survive longer than Document in same case. Internals::m_document is cleared when the document destruction is notified.
  • Makes InternalSettings rough lifetime to follow the Page. This is done by making InternalSettings a supplement of the page. Now InternalSettings object is created per Page instead of per Frame.

Per-test setting clearance is done by newly introduced InternalSettings::Backup,
which recovers the modified settings and refreshes it for each time a test starts.

  • WebCore.exp.in:
  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::from):
(WebCore::InternalSettings::~InternalSettings):
(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::reset):
(WebCore::InternalSettings::settings):
(WebCore::InternalSettings::setFixedElementsLayoutRelativeToFrame):
(WebCore::InternalSettings::setFixedPositionCreatesStackingContext):
(WebCore::InternalSettings::allowRoundingHacks):
(WebCore::InternalSettings::userPreferredLanguages):
(WebCore::InternalSettings::setUserPreferredLanguages):
(WebCore::InternalSettings::setShouldDisplayTrackKind):
(WebCore::InternalSettings::shouldDisplayTrackKind):
(WebCore::InternalSettings::setPagination):

  • testing/InternalSettings.h:

(Backup):
(InternalSettings):
(WebCore::InternalSettings::page):

  • testing/InternalSettings.idl:
  • testing/Internals.cpp:

(WebCore::Internals::Internals):
(WebCore):
(WebCore::Internals::contextDocument):
(WebCore::Internals::frame):
(WebCore::Internals::settings):
(WebCore::Internals::setPagination): Replaced as an alias.
(WebCore::Internals::userPreferredLanguages): Replaced as an alias.
(WebCore::Internals::setUserPreferredLanguages): Replaced as an alias.
(WebCore::Internals::setShouldDisplayTrackKind): Replaced as an alias.
(WebCore::Internals::shouldDisplayTrackKind): Replaced as an alias.
(WebCore::Internals::emitInspectorDidBeginFrame):
(WebCore::Internals::emitInspectorDidCancelFrame):
(WebCore::Internals::allowRoundingHacks): Replaced as an alias.

  • testing/Internals.h:

(WebCore):
(Internals):

  • testing/js/WebCoreTestSupport.cpp:

(WebCoreTestSupport::injectInternalsObject):
(WebCoreTestSupport::resetInternalsObject):

  • testing/v8/WebCoreTestSupport.cpp:

(WebCoreTestSupport::injectInternalsObject):
(WebCoreTestSupport::resetInternalsObject):

Source/WebKit2:

Added exporting symbols.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
03:40 Changeset [122325] by abecsi@webkit.org

Unreviewed, rolling out r122318.
http://trac.webkit.org/changeset/122318
https://bugs.webkit.org/show_bug.cgi?id=90961

It made 11 fast/events/touch fail (Requested by bbandix on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-11

  • UIProcess/API/qt/qquickwebview.cpp:
  • UIProcess/API/qt/qquickwebview_p.h:
03:35 Changeset [122324] by ossy@webkit.org

[Qt] Unreviewed gardening.

Mark fast/js/dfg-poison-fuzz.html as slow, because its runtime is 48 secs on 32 bit in debug mode.

  • platform/qt/TestExpectations:
03:08 Changeset [122323] by ossy@webkit.org

[Qt][ARM] Unreviewed gardening, mark slow tests.

  • platform/qt-arm/TestExpectations:
02:54 Changeset [122322] by commit-queue@webkit.org

[EFL][Wk2] WebErrorsEfl.cpp needs to return non-empty errors
https://bugs.webkit.org/show_bug.cgi?id=90688

Patch by Keunsoon Lee <keunsoon.lee@samsung.com> on 2012-07-11
Reviewed by Hajime Morita.

Return meaningful error for each case.

  • WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp:

(WebKit::cancelledError): create ResourceError for "request canceled".
(WebKit::blockedError): create ResourceError for "request blocked".
(WebKit::cannotShowURLError): create ResourceError for "cannot show url".
(WebKit::interruptedForPolicyChangeError): create ResourceError for "Frame load interrupted by policy change".
(WebKit::cannotShowMIMETypeError): create ResourceError for "Cannot show mimetype".
(WebKit::fileDoesNotExistError): create ResourceError for "File does not exist".
(WebKit::pluginWillHandleLoadError): create ResourceError for "Plugin will handle load".

02:49 Changeset [122321] by abecsi@webkit.org

[Qt][WK2] Fix wheel scrolling for simple pages
https://bugs.webkit.org/show_bug.cgi?id=90793

Reviewed by Kenneth Rohde Christiansen.

Call WebPage::setFixedLayoutSize in setResizesToContentsUsingLayoutSize
instead of setting the view size manually and scheduling a relayout.
Since setFixedLayoutSize forces a relayout it also updates the scrollbars
after the visible rect is available.
This fixes scrolling with wheel events for a QML WebView loading a simple
local page which previously ended up in a state where scrolling was disabled
because the scrollbar update happened before the correct visible rect size was
available.

Add a QML test and infrastructure to QWebKitTest to cover this case.

  • UIProcess/API/qt/qwebkittest.cpp:

(QWebKitTest::wheelEvent):

  • UIProcess/API/qt/qwebkittest_p.h:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_wheelEventHandling.qml: Added.
  • UIProcess/API/qt/tests/qmltests/common/test4.html: Added.
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setResizesToContentsUsingLayoutSize):

02:44 Changeset [122320] by yosin@chromium.org

[Mac] Expose time format related functions
https://bugs.webkit.org/show_bug.cgi?id=90956

Reviewed by Kent Tamura.

This patch introduces localizedTimeFormatText, localizedShortTimeFormatText
and timeAMPMLabels for Mac within feature flag ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

See also:

ICU version: https://bugs.webkit.org/show_bug.cgi?id=89965
Win version: https://bugs.webkit.org/show_bug.cgi?id=90236

No new tests. This patch doesn't change behavior.

  • platform/text/mac/LocalizedDateMac.cpp:

(WebCore::localizedTimeFormatText): Added.
(WebCore::localizedShortTimeFormatText): Added.
(WebCore::timeAMPMLabels): Added.

02:43 Changeset [122319] by ossy@webkit.org

[Qt][ARM] Unreviewed gardening, skip more crashing tests.

  • platform/qt-arm/TestExpectations:
02:40 Changeset [122318] by abecsi@webkit.org

[Qt][WK2] ASSERT: "!m_viewportItem->isMoving()" in QtViewportHandler::flickMoveEnded()
https://bugs.webkit.org/show_bug.cgi?id=90875

Reviewed by Kenneth Rohde Christiansen.

Since MultiPointTouchArea and PinchArea use the childMouseEventFilter
method to filter touch events too, and because Flickable filters child
mouse events the canvas calls this function before propagating the touch
event to the WebView. Since Flickable does not accept touch events the
canvas tries to propagate a synthesized mouse event through the base
class childMouseEventFilter function which is accepted by Flickable and
interferes with the input events we send to Flicakble hence messes up
the internal state of the WebView.
This patch reimplements the virtual childMouseEventFilter method so that all
the mouse and touch events can be processed by WebKit before they arrive to
Flickable.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebView::childMouseEventFilter):

  • UIProcess/API/qt/qquickwebview_p.h:
02:28 Changeset [122317] by allan.jensen@nokia.com

First commit, moving myself to commiter.

Unreviewed

  • Scripts/webkitpy/common/config/committers.py:
02:27 Changeset [122316] by allan.jensen@nokia.com

[Chromium] Adding HarfBuzz-ng for Linux
https://bugs.webkit.org/show_bug.cgi?id=90362

Reviewed by Tony Chang.

Source/WebCore:

This patch adds harfbuzz-ng support for Chromium Linux port as a part of
transition from old harfbuzz. HarfBuzzFaceSkia.cpp implements harfbuzz-ng
callbacks by using Skia APIs. For now, the feature is enabled only when
WTF_USE_HARFBUZZ_NG is defined.

No new tests. No change in behavior now.

  • WebCore.gyp/WebCore.gyp: Added use_harfbuzz_ng variable and related files.
  • WebCore.gypi: Added HarfBuzzFaceSkia.cpp
  • platform/graphics/harfbuzz/FontHarfBuzz.cpp: Added USE(HARFBUZZ_NG).

(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp: Ditto.

(WebCore):
(WebCore::FontPlatformData::harfbuzzFace):

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h: Ditto.

(FontPlatformData):

  • platform/graphics/harfbuzz/ng/HarfBuzzFaceSkia.cpp: Added.

(WebCore):
(WebCore::SkiaScalarToHarfbuzzPosition):
(WebCore::SkiaGetGlyphWidthAndExtents):
(WebCore::harfbuzzGetGlyph):
(WebCore::harfbuzzGetGlyphHorizontalAdvance):
(WebCore::harfbuzzGetGlyphHorizontalOrigin):
(WebCore::harfbuzzGetGlyphExtents):
(WebCore::harfbuzzSkiaGetFontFuncs):
(WebCore::harfbuzzSkiaGetTable):
(WebCore::destroyPaint):
(WebCore::HarfBuzzFace::createFace):
(WebCore::HarfBuzzFace::createFont):
(WebCore::HarfBuzzShaper::createGlyphBufferAdvance):

  • platform/graphics/skia/GlyphPageTreeNodeSkia.cpp: Added USE(HARFBUZZ_NG).

(WebCore::substituteWithVerticalGlyphs):

Source/WebKit/chromium:

  • features.gypi: Added use_harfbuzz_ng variable. If the value is set, USE(HARFBUZZ_NG) is defined.
02:25 Changeset [122315] by ossy@webkit.org

[Qt] Unreviewed gardening after r122290.

Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-07-11

  • platform/qt/Skipped: Skip fast/forms/input-in-table-cell-no-value.html because ENABLE(INPUT_TYPE_DATE) is disabled
02:06 Changeset [122314] by commit-queue@webkit.org

[EFL] Move tests that require ENABLE_INPUT_TYPE_* to TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=90948

Unreviewed EFL gardening. Move tests that require
ENABLE_INPUT_TYPE_* to be enabled from Skipped list to
TestExpectations.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-11

  • platform/efl/Skipped:
  • platform/efl/TestExpectations:
02:04 Changeset [122313] by kinuko@chromium.org

Web Inspector: Clean up FileSystem related code
https://bugs.webkit.org/show_bug.cgi?id=90592

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-07-11
Reviewed by Vsevolod Vlasov.

Clean up FileSystem related code in Inspector as follows:

  • Clean up layout tests and add test case for error case,
  • Fix error handling on request,
  • s/GetFileSystemRootTask/FileSystemRootRequest/g
  • s/ReadDirectoryTask/DirectoryContentRequest/g
  • s/ReadFileTask/FileContentRequest/g

Source/WebCore:

Tests: http/tests/inspector/filesystem/request-directory-content.html

http/tests/inspector/filesystem/request-file-content.html
http/tests/inspector/filesystem/request-filesystem-root.html
http/tests/inspector/filesystem/request-metadata.html

  • inspector/InspectorFileSystemAgent.cpp:

(WebCore):
(WebCore::InspectorFileSystemAgent::requestFileSystemRoot): Add early error handling.
(WebCore::InspectorFileSystemAgent::requestDirectoryContent): Add early error handling.
(WebCore::InspectorFileSystemAgent::requestMetadata): Add early error handling.
(WebCore::InspectorFileSystemAgent::requestFileContent): Add early error handling.

  • inspector/InspectorFileSystemAgent.h: Remove unused forward declaration and unused header.

(WebCore):
(InspectorFileSystemAgent):

  • inspector/front-end/FileSystemModel.js:

(WebInspector.FileSystemRequestManager.prototype.requestFileSystemRoot.requestAccepted):
(WebInspector.FileSystemRequestManager.prototype.requestFileSystemRoot): Add early error handling.
(WebInspector.FileSystemRequestManager.prototype.requestDirectoryContent.requestAccepted):
(WebInspector.FileSystemRequestManager.prototype.requestDirectoryContent): Add early error handling.
(WebInspector.FileSystemRequestManager.prototype.requestMetadata.requestAccepted):
(WebInspector.FileSystemRequestManager.prototype.requestMetadata): Add early error handling.
(WebInspector.FileSystemRequestManager.prototype.requestFileContent.requestAccepted):
(WebInspector.FileSystemRequestManager.prototype.requestFileContent): Add early error handling.

LayoutTests:

  • http/tests/inspector/filesystem/filesystem-test.js:

(initialize_FileSystemTest.InspectorTest.dumpFileSystemRootRequestResult):
(initialize_FileSystemTest.InspectorTest.dumpDirectoryContentRequestResult):
(initialize_FileSystemTest.InspectorTest.dumpMetadataRequestResult):
(initialize_FileSystemTest.InspectorTest.dumpFileContentRequestResult):
(initialize_FileSystemTest):

  • http/tests/inspector/filesystem/request-directory-content-expected.txt: Renamed from LayoutTests/http/tests/inspector/filesystem/read-directory-expected.txt.
  • http/tests/inspector/filesystem/request-directory-content.html: Renamed from LayoutTests/http/tests/inspector/filesystem/read-directory.html. Changed test steps to unnamed function array. Add failcase test.
  • http/tests/inspector/filesystem/request-file-content-expected.txt: Renamed from LayoutTests/http/tests/inspector/filesystem/read-file-expected.txt.
  • http/tests/inspector/filesystem/request-file-content.html: Renamed from LayoutTests/http/tests/inspector/filesystem/read-file.html. Changed test steps to unnamed function array. Add failcase test.
  • http/tests/inspector/filesystem/request-filesystem-root-expected.txt: Renamed from LayoutTests/http/tests/inspector/filesystem/get-filesystem-expected.txt.
  • http/tests/inspector/filesystem/request-filesystem-root.html: Renamed from LayoutTests/http/tests/inspector/filesystem/get-filesystem-root.html. Changed test steps to unnamed function array. Add failcase test.
  • http/tests/inspector/filesystem/request-metadata-expected.txt: Renamed from LayoutTests/http/tests/inspector/filesystem/get-metadata-expected.txt.
  • http/tests/inspector/filesystem/request-metadata.html: Renamed from LayoutTests/http/tests/inspector/filesystem/get-metadata.html. Changed test steps to unnamed function array. Add failcase test.
01:56 Changeset [122312] by caseq@chromium.org

Web Inspector: Forward message loop instrumentation data to frontend.
https://bugs.webkit.org/show_bug.cgi?id=89584

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-07-09
Reviewed by Yury Semikhatsky.

Transmit collected message loop tasks to inspector frontend.
Now "Program" should be a top-level event on browsers that
support message loop instrumentation.
Frontend was changed so that user will not see any changes.

Source/WebCore:

  • inspector/InspectorTimelineAgent.cpp:

(TimelineRecordType):
Added new event type - "Program"
(WebCore::InspectorTimelineAgent::willProcessTask):
Begin "Program" event.
(WebCore::InspectorTimelineAgent::didProcessTask):
Finish "Program" event.
(WebCore::InspectorTimelineAgent::setHeapSizeStatistic):
Do not add counters to "Program" events.
(WebCore):
(WebCore::InspectorTimelineAgent::innerSetHeapSizeStatistic):
Renamed from "setHeapSizeStatistic"

  • inspector/InspectorTimelineAgent.h:

(InspectorTimelineAgent):

  • inspector/front-end/MemoryStatistics.js:

(WebInspector.MemoryStatistics.prototype._onRecordAdded):
Unwraps "Program" events.
(WebInspector.MemoryStatistics.prototype._innerRecordAdded):
Renamed from "_onRecordAdded"

  • inspector/front-end/TimelineFrameController.js:

(WebInspector.TimelineFrameController.prototype._addRecord):
Unwraps "Program" events.
(WebInspector.TimelineFrameController.prototype._innerAddRecord):
Renamed from "_addRecord"

  • inspector/front-end/TimelineModel.js:
  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineCategoryStrips.prototype.update.appendRecord):
Filter out "Program" category.
(WebInspector.TimelineCategoryStrips.prototype.update):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._createStatusbarButtons):
Filter out "Program" category.
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
Unwraps "Program" events.

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.categories):
Added "Program" category.
(WebInspector.TimelinePresentationModel.recordStyle):
Ditto.
(WebInspector.TimelinePresentationModel.prototype.addRecord):
Unwraps "Program" events.
(WebInspector.TimelinePresentationModel.prototype._addRecord):
Renamed from "addRecord"

LayoutTests:

  • inspector/timeline/timeline-enum-stability-expected.txt:
01:34 Changeset [122311] by ossy@webkit.org

webkit-patch land should automatically add svn:mime-type for .png files
https://bugs.webkit.org/show_bug.cgi?id=75825

Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-07-11
Reviewed by Dirk Pranke.

Refactor the png.py to avoid code duplication.

  • Scripts/webkitpy/common/checksvnconfigfile.py: Added.

(check):
(config_file_path):
(errorstr_autoprop):
(errorstr_png):

  • Scripts/webkitpy/style/checkers/png.py:

(PNGChecker.check):

  • Scripts/webkitpy/tool/commands/download.py:

(Land):

  • Scripts/webkitpy/tool/steps/init.py:
  • Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py: Added.

(AddSvnMimetypeForPng):
(AddSvnMimetypeForPng.init):
(AddSvnMimetypeForPng.run):
(AddSvnMimetypeForPng._check_pngs):

  • Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py: Added.

(MockSCMDetector):
(MockSCMDetector.init):
(MockSCMDetector.display_name):
(AddSvnMimetypeForPngTest):
(AddSvnMimetypeForPngTest.test_run):

00:46 Changeset [122310] by bashi@chromium.org

[Chromium] Adding HarfBuzz-ng for Linux
https://bugs.webkit.org/show_bug.cgi?id=90362

Reviewed by Tony Chang.

Source/WebCore:

This patch adds harfbuzz-ng support for Chromium Linux port as a part of
transition from old harfbuzz. HarfBuzzFaceSkia.cpp implements harfbuzz-ng
callbacks by using Skia APIs. For now, the feature is enabled only when
WTF_USE_HARFBUZZ_NG is defined.

No new tests. No change in behavior now.

  • WebCore.gyp/WebCore.gyp: Added use_harfbuzz_ng variable and related files.
  • WebCore.gypi: Added HarfBuzzFaceSkia.cpp
  • platform/graphics/harfbuzz/FontHarfBuzz.cpp: Added USE(HARFBUZZ_NG).

(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp: Ditto.

(WebCore):
(WebCore::FontPlatformData::harfbuzzFace):

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h: Ditto.

(FontPlatformData):

  • platform/graphics/harfbuzz/ng/HarfBuzzFaceSkia.cpp: Added.

(WebCore):
(WebCore::SkiaScalarToHarfbuzzPosition):
(WebCore::SkiaGetGlyphWidthAndExtents):
(WebCore::harfbuzzGetGlyph):
(WebCore::harfbuzzGetGlyphHorizontalAdvance):
(WebCore::harfbuzzGetGlyphHorizontalOrigin):
(WebCore::harfbuzzGetGlyphExtents):
(WebCore::harfbuzzSkiaGetFontFuncs):
(WebCore::harfbuzzSkiaGetTable):
(WebCore::destroyPaint):
(WebCore::HarfBuzzFace::createFace):
(WebCore::HarfBuzzFace::createFont):
(WebCore::HarfBuzzShaper::createGlyphBufferAdvance):

  • platform/graphics/skia/GlyphPageTreeNodeSkia.cpp: Added USE(HARFBUZZ_NG).

(WebCore::substituteWithVerticalGlyphs):

Source/WebKit/chromium:

  • features.gypi: Added use_harfbuzz_ng variable. If the value is set, USE(HARFBUZZ_NG) is defined.
00:42 Changeset [122309] by hayato@chromium.org

Unreviewed gardening.
One more fix for r122292.

  • TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
00:42 Changeset [122308] by zandobersek@gmail.com

Unreviewed GTK gardening, adding an image expectation for the
fast/forms/input-in-table-cell-no-value.html reftest, failing
after it was introduced in r122290 due to <input type='date'>
being used. The ENABLE_INPUT_TYPE_DATE feature is not enabled
on the Gtk port.

  • platform/gtk/TestExpectations:
00:27 Changeset [122307] by commit-queue@webkit.org

Unreviewed, rolling out r122301.
http://trac.webkit.org/changeset/122301
https://bugs.webkit.org/show_bug.cgi?id=90947

Android builder started to fail (Requested by hayato on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-11

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
00:22 Changeset [122306] by kbr@google.com

compositing/webgl/webgl-nonpremultiplied-blend.html is flaky on Lion
https://bugs.webkit.org/show_bug.cgi?id=82412

Reviewed by Adrienne Walker.

Source/WebCore:

When compositing premultipliedAlpha=false WebGL canvases, use a separate
blend function for the alpha channel to avoid writing alpha < 1. This
makes the behavior more consistent with all other compositing results
and avoids situations where the alpha channel is preserved on some
platforms and discarded on others.

Covered by existing tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawTextureQuad):

Use separate alpha blend function when compositing premultipliedAlpha=false WebGL canvases.

LayoutTests:

Removed Chromium Mac-specific pixel results and failure expectations.

  • platform/chromium-mac/compositing/webgl/webgl-nonpremultiplied-blend-expected.png: Removed.
  • platform/chromium/TestExpectations:

Removed expectations of failure.

00:06 Changeset [122305] by ossy@webkit.org

gc() doesn't exist in svg/animations/dynamic-modify-attributename-crash2.svg
https://bugs.webkit.org/show_bug.cgi?id=90945

Reviewed by Abhishek Arya.

  • svg/animations/dynamic-modify-attributename-crash2.svg: Include fast/js/resources/js-test-pre.js to have gc().
00:02 Changeset [122304] by hayato@chromium.org

Unreviewed gardening.

Android builder started to fail after r122292.
My best guess is that '--ant-compile' does not take an argument.

  • WebKitUnitTests.gyp:

07/10/12:

23:52 Changeset [122303] by yosin@chromium.org

[Chromium-Windows] Implement functions for localized time format information
https://bugs.webkit.org/show_bug.cgi?id=90236

Reviewed by Kent Tamura.

Source/WebCore:

This patch introduces following localized time format related
functions:

  • localizedTimeFormatText
  • localizeShortTimeFormatText()
  • timeAMPMLabels

for Windows in feature flag: ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

See also:

ICU version: https://bugs.webkit.org/show_bug.cgi?id=89965
Mac version: https://bugs.webkit.org/show_bug.cgi?id=90237

Tests: WebKit/chromium/tests/LocalWinTest.cpp

  • platform/text/LocaleWin.cpp:

(WebCore::mapCharacterToDateTimeFieldType): Added.
(WebCore::convertWindowsTimeFormatToLDML): Added.
(WebCore::LocaleWin::timeFormatText): Added.
(WebCore::LocaleWin::shortTimeFormatText): Added.
(WebCore::LocaleWin::timeAMPMLabels): Added.

  • platform/text/LocaleWin.h:

(LocaleWin): Added time format related functions and variables.

  • platform/text/LocalizedDateWin.cpp:

(WebCore::localizedTimeFormatText): Added.
(WebCore::localizedShortTimeFormatText): Added.
(WebCore::timeAMPMLabels): Added.

Source/WebKit/chromium:

This patch introduces test cases for date and time format related
functions in LocaleWin.

  • tests/LocaleWinTest.cpp:

(LocaleWinTest):
(LocaleWinTest::dateComponents): Added.
(LocaleWinTest::msForDate): Moved inside class LocaleWinTest.
(LocaleWinTest::formatDate): Added.
(LocaleWinTest::parseDate): Added.
(LocaleWinTest::dateFormatText): Added.
(LocaleWinTest::firstDayOfWeek): Added.
(LocaleWinTest::monthLabel): Added.
(LocaleWinTest::weekDayShortLabel): Added.
(LocaleWinTest::timeFormatText): Added.
(LocaleWinTest::shortTimeFormatText): Added.
(LocaleWinTest::timeAMPMLabel): Added.
(TEST_F):

23:23 Changeset [122302] by commit-queue@webkit.org

Style not updated for element with display:none becoming first/last-child
https://bugs.webkit.org/show_bug.cgi?id=90356

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-07-10
Reviewed by Kent Tamura.

Source/WebCore:

Always trigger style recalc when an element without a renderer becomes the first/last-child.

Tests: fast/css/first-child-display-change.html

fast/css/last-child-display-change.html

  • dom/Element.cpp:

(WebCore::checkForSiblingStyleChanges):

LayoutTests:

  • fast/css/first-child-display-change-expected.txt: Added.
  • fast/css/first-child-display-change-inverse-expected.txt: Added.
  • fast/css/first-child-display-change-inverse.html: Added.
  • fast/css/first-child-display-change.html: Added.
  • fast/css/last-child-display-change-expected.txt: Added.
  • fast/css/last-child-display-change-inverse-expected.txt: Added.
  • fast/css/last-child-display-change-inverse.html: Added.
  • fast/css/last-child-display-change.html: Added.
23:19 Changeset [122301] by abarth@webkit.org

[Chromium] Merge final nits to DumpRenderTree.gyp for Android
https://bugs.webkit.org/show_bug.cgi?id=90920

Reviewed by Tony Chang.

This patch contains the last few small changes to DumpRenderTree.gyp
from the chromium-android branch. After this change, this file will be
fully merged.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
23:18 Changeset [122300] by hayato@chromium.org

Unreviewed gardening.

Remove 'true' from testRunner.dumpAsText(true).
NRWT complained that an '-expected.png' file was MISSING.

  • animations/animation-shorthand-name-order.html:
23:10 Changeset [122299] by commit-queue@webkit.org

[WK2][EFL] Add Battery Status Provider
https://bugs.webkit.org/show_bug.cgi?id=90543

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-10
Reviewed by Kenneth Rohde Christiansen.

Define a battery status provider for WebKit2 EFL which
relies on WebCore::BatteryProviderEfl.

  • CMakeLists.txt: Add WebCore/Modules/battery to include

paths.

  • PlatformEfl.cmake: Add BatteryProvider class to CMake.
  • UIProcess/API/efl/BatteryProvider.cpp: Added.

(toBatteryProvider):
(startUpdatingCallback):
(stopUpdatingCallback):
(BatteryProvider::~BatteryProvider):
(BatteryProvider::create):
(BatteryProvider::BatteryProvider):
(BatteryProvider::startUpdating):
(BatteryProvider::stopUpdating):
(BatteryProvider::didChangeBatteryStatus):

  • UIProcess/API/efl/BatteryProvider.h: Added.

(BatteryProvider):

  • UIProcess/API/efl/ewk_context.cpp:

(_Ewk_Context): Add BatteryProvider to Ewk_Context.
(createDefaultEwkContext):
(ewk_context_default_get):

22:43 Changeset [122298] by shinyak@chromium.org

ShadowRoot should know its type in debug build.
https://bugs.webkit.org/show_bug.cgi?id=90933

Reviewed by Hajime Morita.

For assertion, ShadowRoot should know its type is UserAgentShadowRoot or AuthorShadowRoot.

This patch also renames ShadowRootCreationPurpose to ShadowRootType, since it is suitable
name for ShadowRoot to have.

No new tests, since it is used only for assertion.

  • dom/Element.cpp:

(WebCore::Element::ensureShadowRoot):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::create):

  • dom/ShadowRoot.h:

(ShadowRoot):
(WebCore::ShadowRoot::type):

  • html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::createShadowSubtree):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::createShadowSubtree):

  • html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::HTMLKeygenElement):

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::createShadowSubtree):

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::createShadowSubtree):

  • html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::createShadowSubtree):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::createShadowSubtree):

  • html/InputType.cpp:

(WebCore::InputType::destroyShadowSubtree): Asserts that ShadowRoot type is UserAgentShadowRoot.

  • html/shadow/TextFieldDecorationElement.cpp:

(WebCore::getDecorationRootAndDecoratedRoot):

  • svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::createShadowSubtree):

22:40 Changeset [122297] by hayato@chromium.org

Unreviewed gardening.

  • fast/css/deprecated-flexbox-auto-min-size-expected.txt: Renamed from LayoutTests/platform/chromium/fast/css/deprecated-flexbox-auto-min-size-expected.txt.
22:14 Changeset [122296] by hayato@chromium.org

12012-07-10 Hayato Ito <hayato@chromium.org>

Unreviewed gardening.

  • platform/chromium/fast/css/deprecated-flexbox-auto-min-size-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/css/deprecated-flexbox-auto-min-size-expected.txt.
21:45 Changeset [122295] by staikos@webkit.org

Add missing binding type String for IndexedDB.
https://bugs.webkit.org/show_bug.cgi?id=90351

Reviewed by Nikolas Zimmermann.

No new tests because it's already covered by IDB tests.

  • bindings/js/JSIDBAnyCustom.cpp:

(WebCore::toJS):

21:42 Changeset [122294] by commit-queue@webkit.org

[chromium] Make full texture updates explicit
https://bugs.webkit.org/show_bug.cgi?id=90507

Patch by Brian Anderson <brianderson@chromium.org> on 2012-07-10
Reviewed by Adrienne Walker.

Covered by existing tests.

  • platform/graphics/chromium/ScrollbarLayerChromium.cpp:

(WebCore::ScrollbarLayerChromium::updatePart):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::updateTiles):

  • platform/graphics/chromium/cc/CCTextureUpdater.cpp:

(WebCore::CCTextureUpdater::appendFullUpdate):
(WebCore::CCTextureUpdater::hasMoreUpdates):
(WebCore::CCTextureUpdater::update):
(WebCore::CCTextureUpdater::clear):

  • platform/graphics/chromium/cc/CCTextureUpdater.h:

(CCTextureUpdater):

21:34 Changeset [122293] by shinyak@chromium.org

Crash in nextLinePosition() due to accessing a removed root line box.
https://bugs.webkit.org/show_bug.cgi?id=90484

Reviewed by Abhishek Arya.

Source/WebCore:

When <object> element is reattached, the 'content' style is compared to the old style.
If it is not the same, a flag to recalc style is enabled. Because of this, the recalc style flag
is not cleared in updateLayoutIgnorePendingStyleSheets() in nextLinePosition(), and it causes
the second layout in isEditablePosition(p). Then 'RootInlineBox root' is invalidated, but
it's used after that.

When the content of the same <object> elements are compared, they should be the same.
However, operator== for ContentData is not implemented correctly (it compares a pointer instead of
content). So operator== does not hold for the content of the same <object> elements.

Test: editing/execCommand/crash-extend-selection-forward.html

  • rendering/style/ContentData.cpp:

(WebCore::operator==): Compares the instance of data instead of pointer.

LayoutTests:

This testcase should not be triggered in ASAN.

  • editing/execCommand/crash-extend-selection-forward-expected.txt: Added.
  • editing/execCommand/crash-extend-selection-forward.html: Added.
21:32 Changeset [122292] by abarth@webkit.org

[Chromium-Android] Add apk test targets for webkit_unit_tests and TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=90918

Reviewed by Tony Chang.

The rules are similar to what we have added for DumpRenderTree apk.
All references to gtest_target_type can be removed once we enable APK
tests on the all bots.

Source/WebKit/chromium:

  • WebKitUnitTests.gyp:

Tools:

  • TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
21:24 Changeset [122291] by jsbell@chromium.org

IndexedDB: Ensure transaction abort events are deterministic in multiprocess ports
https://bugs.webkit.org/show_bug.cgi?id=90412

Reviewed by Tony Chang.

In multi-process ports (e.g. Chromium), transaction aborts triggered on the front-end could
be initiated while a "success" event was in-flight from the back end. This would lead to
apparently flaky behavior when requests would sometimes report success and sometimes report
an error. Address this by having front-end triggered aborts do the abort steps immediately,
then send the async abort request to the back end.

No new tests - behavior in single process ports (and DRT) covered by existing
tests. Will enable currently disabled Chromium tests to be enabled (crbug.com/83226).

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::IDBRequest): Initialize a new m_requestAborted flag, used to prevent
dispatching if an in-flight request comes in after the abort.
(WebCore::IDBRequest::abort): Set flag to prevent double dispatching.
(WebCore::IDBRequest::onError): Handle aborted-then-received-event case.
(WebCore::IDBRequest::onSuccess): Ditto.
(WebCore::IDBRequest::onSuccessWithContinuation): Ditto.
(WebCore::IDBRequest::dispatchEvent): On uncaught error, trigger abort on transaction front-end.

  • Modules/indexeddb/IDBRequest.h:

(IDBRequest):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::abort): Do abort steps locally first, then notify back-end.
(WebCore::IDBTransaction::onAbort): If abort wasn't triggered locally, clean up is still necessary.

20:11 Changeset [122290] by jchaffraix@webkit.org

REGRESSION(r112113): absolutely positioned INPUT boxes with a table cell containing block have a 0px height
https://bugs.webkit.org/show_bug.cgi?id=89209

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/forms/input-in-table-cell-no-value.html

The issue comes from the layout code not properly resetting the overriden heigth between layouts.

The test case relies on a table cell as it requires a 2 pass layout. Between the 2 passes, different
code paths would be taken, leading to previous values being used to over-constrain the inner content.

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::layout):
Ensure consistent layout by resetting any overriden conditional height.

LayoutTests:

The 2 tests are very close and differ by the use of min-height. This forces some content to be visible in the expected result
but not in the original test case.

  • fast/forms/input-in-table-cell-no-value-expected.html: Added.
  • fast/forms/input-in-table-cell-no-value.html: Added.
19:26 Changeset [122289] by kbr@google.com

Add --no-build option to perf test runner
https://bugs.webkit.org/show_bug.cgi?id=90916

Reviewed by Ryosuke Niwa.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._parse_args):

Support --no-build option to perf tests, as in layout tests.

19:21 Changeset [122288] by noam.rosenthal@nokia.com

[Qt] Enable antialiasing for TextureMapper
https://bugs.webkit.org/show_bug.cgi?id=90915

Reviewed by Martin Robinson.

Enable the new antialiasing functionality for WebLayerTreeRendering.
This will make one-tile layers antialiased when using UI_SIDE_COMPOSITING.

  • UIProcess/WebLayerTreeRenderer.cpp:

(WebKit::WebLayerTreeRenderer::ensureRootLayer):

19:06 Changeset [122287] by abarth@webkit.org

EWSTools should be able to build a chromium-ews bot from scratch
https://bugs.webkit.org/show_bug.cgi?id=90912

Reviewed by Eric Seidel.

I've been using this script to kick off the build process for the
chromium-ews bots on Google Compute Engine.

  • EWSTools/GoogleComputeEngine: Added.
  • EWSTools/GoogleComputeEngine/build-chromium-ews.sh: Added.
18:47 Changeset [122286] by commit-queue@webkit.org

Input elements with type=range do not have default touch handlers.
https://bugs.webkit.org/show_bug.cgi?id=88807

Patch by Kevin Ellis <kevers@chromium.org> on 2012-07-10
Reviewed by Antonio Gomes.

Source/WebCore:

This patch adds support for touch event handling on input elements
and dragging a slider with touch start and move events. Previously,
manipulating a slider on a touch screen required generation of
synthetic mouse events.

Tests: fast/events/touch/touch-slider-no-js-touch-listener.html

fast/events/touch/touch-slider.html

  • dom/Event.cpp:

(WebCore::Event::isTouchEvent):
(WebCore):

  • dom/Event.h:

(Event):

  • dom/Touch.cpp:

(WebCore::Touch::Touch):

  • dom/Touch.h:

(WebCore::Touch::absoluteLocation):
(Touch):

  • dom/TouchEvent.cpp:

(WebCore::TouchEvent::isTouchEvent):
(WebCore):

  • dom/TouchEvent.h:

(TouchEvent):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::HTMLInputElement):
(WebCore::HTMLInputElement::~HTMLInputElement):
(WebCore::HTMLInputElement::updateType):
(WebCore::HTMLInputElement::defaultEventHandler):

  • html/HTMLInputElement.h:

(HTMLInputElement):

  • html/InputType.cpp:

(WebCore):
(WebCore::InputType::handleTouchEvent):
(WebCore::InputType::hasTouchEventHandler):

  • html/InputType.h:

(WebCore):
(ClickHandlingState):
(InputType):

  • html/RangeInputType.cpp:

(WebCore):
(WebCore::RangeInputType::handleTouchEvent):
(WebCore::RangeInputType::hasTouchEventHandler):

  • html/RangeInputType.h:

(RangeInputType):

  • html/shadow/SliderThumbElement.h:

(SliderThumbElement):

Source/WebKit/chromium:

Adds flag to enable native handling of touch events for input elements
with type=range.

  • features.gypi:

LayoutTests:

Add automated test for manipulating an input slider via touch
events.

  • fast/events/touch/script-tests/touch-slider-no-js-touch-listener.js: Added.

(checkPosition):

  • fast/events/touch/script-tests/touch-slider.js: Added.

(onTouchStart):
(onTouchEnd):
(onKeyDown):
(checkPosition):

  • fast/events/touch/touch-slider-expected.txt: Added.
  • fast/events/touch/touch-slider-no-js-touch-listener-expected.txt: Added.
  • fast/events/touch/touch-slider-no-js-touch-listener.html: Added.
  • fast/events/touch/touch-slider.html: Added.
  • platform/chromium/fast/events/touch/touch-slider-expected.txt: Added.
  • platform/chromium/fast/events/touch/touch-slider-no-js-touch-listener-expected.txt: Added.
18:26 Changeset [122285] by morrita@google.com

Merge 122082 - Heap-use-after-free in WebCore::RenderObject::destroyAndCleanupAnonymousWrappers
https://bugs.webkit.org/show_bug.cgi?id=90480

Reviewed by Kent Tamura.

Source/WebCore:

If <select> has any insertion point, the attachment phase
unpextedly creates a renderer for distributed node and added to
the renderer of the <select>, which breaks an assumption and
results the crash.

This change tighten the childShouldCreateRenderer() to forbid
child renderers even from distributed nodes.

There is an exception as always: ValidationMessage can create a
ShadowRoot to <select>, which generates usually-forbidden child
renderers. This change introduces HTMLFormControlElement::validationMessageContains()
to let these renderers in.

Test: fast/dom/shadow/insertion-point-list-menu-crash.html

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::validationMessageContains):
(WebCore):

  • html/HTMLFormControlElement.h:

(HTMLFormControlElement):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::childShouldCreateRenderer):

  • html/ValidationMessage.cpp:

(WebCore::ValidationMessage::contains):
(WebCore):

  • html/ValidationMessage.h:

(WebCore):
(ValidationMessage):

LayoutTests:

  • fast/dom/shadow/insertion-point-list-menu-crash-expected.txt: Added.
  • fast/dom/shadow/insertion-point-list-menu-crash.html: Added.

TBR=morrita@google.com
Review URL: https://chromiumcodereview.appspot.com/10694124

18:13 Changeset [122284] by adamk@chromium.org

[Chromium] REGRESSION(r121909): m_currentInputEvent never set
https://bugs.webkit.org/show_bug.cgi?id=90914

Reviewed by Abhishek Arya.

The always-null m_currentInputEvent causes a regression when
middle-clicking on a link that calls window.open('...', '_blank');
that new tab should open in the background, but instead opens in the
foreground (see code in ChromeClientImpl::getNavigationPolicy()).

Fix usage of TemporaryChange to specify a local variable name so that
m_currentInputEvent is actually set for the duration of handleInputEvent.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleInputEvent): Name the TemporaryChange instance.

18:07 Changeset [122283] by morrita@google.com

BUG=134398
Review URL: https://chromiumcodereview.appspot.com/10700153/

17:41 Changeset [122282] by commit-queue@webkit.org

Re-factoring recalcColumn in AutoTableLayout.cpp for readability
https://bugs.webkit.org/show_bug.cgi?id=89636

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-07-10
Reviewed by Julien Chaffraix.

No test case required. Code re-factoring.

  • rendering/AutoTableLayout.cpp:

Added a const integer place holder for 32760.

(WebCore::AutoTableLayout::recalcColumn):

Changes :
1) Moved the continue statement above the bool cellHasContent for an early return.
2) Replaced the constant 32760 by a placeholder.
3) Initialization of columnLayout max and min logical widths is made common for both cells having col span == 1 and span > 1.
4) Removed redundant check for cell logical width type.

17:18 Changeset [122281] by kbr@google.com

Line directive test in fast/canvas/webgl/glsl-conformance.html is incorrect
https://bugs.webkit.org/show_bug.cgi?id=90897

Reviewed by Adrienne Walker.

Removed an invalid test and adjusted the test expectations.

  • fast/canvas/webgl/glsl-conformance-expected.txt:
  • fast/canvas/webgl/glsl-conformance.html:
  • platform/chromium/TestExpectations:
17:13 FeatureFlags edited by tkent@chromium.org
Remove a comment about Hixie76 protocol for WEB_SOCkETS (diff)
16:53 Changeset [122280] by abarth@webkit.org

WebCore::Settings for Hixie76 WebSocket protocol doesn't do anything and should be removed
https://bugs.webkit.org/show_bug.cgi?id=90910

Reviewed by Eric Seidel.

Source/WebCore:

We've already removed the code that implements Hixie76 WebSockets. This
patch just removes the WebCore::Setting that used to control which
WebSocket protocol version we'd use.

I've left the WebKit-layer APIs in place, but they now don't do
anything. I'll remove all the Chromium callers shortly.

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(Settings):

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

Source/WebKit/chromium:

  • public/WebSettings.h:

(WebKit::WebSettings::setHixie76WebSocketProtocolEnabled):

  • src/WebSettingsImpl.cpp:
  • src/WebSettingsImpl.h:

(WebSettingsImpl):

  • src/WebSharedWorkerImpl.cpp:

(WebKit::WebSharedWorkerImpl::initializeLoader):

Source/WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

  • webkit/webkitwebview.cpp:

(webkit_web_view_update_settings):

Source/WebKit/mac:

  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences setHixie76WebSocketProtocolEnabled:]):
(-[WebPreferences isHixie76WebSocketProtocolEnabled]):

  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Source/WebKit/win:

  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::setHixie76WebSocketProtocolEnabled):
(WebPreferences::hixie76WebSocketProtocolEnabled):

  • WebView.cpp:

(WebView::notifyPreferencesChanged):

Source/WebKit2:

  • Shared/WebPreferencesStore.h:

(WebKit):

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetHixie76WebSocketProtocolEnabled):
(WKPreferencesGetHixie76WebSocketProtocolEnabled):

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

16:39 Changeset [122279] by commit-queue@webkit.org

Add alecflett to the list of committers
https://bugs.webkit.org/show_bug.cgi?id=90903

Patch by Alec Flett <alecflett@chromium.org> on 2012-07-10
Reviewed by Ojan Vafai.

  • Scripts/webkitpy/common/config/committers.py:
16:36 Changeset [122278] by pdr@google.com

Crash due to SVG animation element not removed from target (before reset)
https://bugs.webkit.org/show_bug.cgi?id=90750

Reviewed by Abhishek Arya.

Source/WebCore:

Previously we were not removing an animation element from
SVGDocumentExtensions::m_animatedElements which led to a crash.
This change properly removes animation elements in resetTargetElement
which both fixes this bug and will prevent others from hitting it in
the future.

Test: svg/animations/dynamic-modify-attributename-crash2.svg

  • svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::removeAllAnimationElementsFromTarget):

removeAllAnimationElementsFromTarget now adds all the animation elements
to a vector and iterates over it because the changes to resetTargetElement
would have caused us to modify the underlying hashset as we iterated. Note that
before we deleted animationElementsForTarget in removeAllAnimationElementsFromTarget
but that logic is now handled in removeAnimationElementFromTarget which is called
during resetTargetElement.

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::removedFrom):

Because of the changes in resetTargetElement, removedFrom was able to be
refactored. This patch changes removedFrom to call resetTargetElement rather
than have duplicated logic. There is a very small change in logic here:
animationAttributeChanged() is now called in removedFrom().

(WebCore::SVGSMILElement::resetTargetElement):

resetTargetElement now fully resets the target, including removing it from
m_animatedElements. This will prevent future instances of this bug.

LayoutTests:

  • svg/animations/dynamic-modify-attributename-crash2-expected.txt: Added.
  • svg/animations/dynamic-modify-attributename-crash2.svg: Added.
16:22 Changeset [122277] by dino@apple.com

Add the test files that I forgot to commit (AGAIN!) in r122271

  • animations/animation-shorthand-name-order-expected.txt: Added.
  • animations/animation-shorthand-name-order.html: Added.
16:10 Changeset [122276] by abarth@webkit.org

bugs.webkit.org has mixed content
https://bugs.webkit.org/show_bug.cgi?id=90907

Reviewed by Eric Seidel.

Now that we detect http XMLHttpRequests as mixed content, I've noticed
that we're loading committers.py over http instead of https. For
better security, we should use https.

  • committers-autocomplete.js:
16:06 Changeset [122275] by commit-queue@webkit.org

[Qt] Repaint counter for accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=90116

Patch by Helder Correia <helder.correia@nokia.com> on 2012-07-10
Reviewed by Noam Rosenthal.

No new tests, just introducing a debug feature.

For this feature to be enabled, the environment variable
QT_WEBKIT_SHOW_COMPOSITING_DEBUG_VISUALS must be set to 1. Once enabled,
both repaint counters and tile borders will be painted.

Important notes:

  • Only WebKit2 is targetted for now.
  • There is no integration with Preferences. That aproach was

taken initially but revealed complex and overkill for such a
debugging-only functionality. Thus, to disable it simply restart with
the environment variable unset or set to some other value.

A Qt-specific drawRepaintCounter() function was added to
TextureMapperGL. A QImage is used as scratch buffer to paint borders and
counters. It is then uploaded to a BitmapTexture acquired from the pool
and finally draw by TextureMapper. The actual compositing happens inside
LayerBackingStore::paintToTextureMapper(). Each LayerBackingStoreTile
now has a repaint counter which gets incremented in
LayerBackingStore::updateTile().

Source/WebCore:

  • platform/graphics/texmap/TextureMapper.h:
  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore):
(WebCore::TextureMapperGL::drawRepaintCounter):

  • platform/graphics/texmap/TextureMapperGL.h:
  • platform/graphics/texmap/TextureMapperImageBuffer.h:

Source/WebKit2:

  • UIProcess/texmap/LayerBackingStore.cpp:

(WebKit::LayerBackingStore::updateTile):
(WebKit):
(WebKit::shouldShowTileDebugVisuals):
(WebKit::LayerBackingStore::paintToTextureMapper):

  • UIProcess/texmap/LayerBackingStore.h:

(WebKit::LayerBackingStoreTile::LayerBackingStoreTile):
(LayerBackingStoreTile):
(WebKit::LayerBackingStoreTile::incrementRepaintCount):
(WebKit::LayerBackingStoreTile::repaintCount):

15:53 Changeset [122274] by gyuyoung.kim@samsung.com

[CMAKE] Add missing feature macros
https://bugs.webkit.org/show_bug.cgi?id=90890

Reviewed by Eric Seidel.

ENABLE_CSS_EXCLUSIONS, ENABLE_CSS_REGIONS, ENABLE_TEXT_AUTOSIZING macros
haven't defined in cmake feature list.

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:
15:49 Changeset [122273] by wangxianzhu@chromium.org

try

15:48 Changeset [122272] by danakj@chromium.org

[chromium] Replace use of ManagedTexture with CCScopedTexture for impl thread and remove implTextureManager from LayerRendererChromium
https://bugs.webkit.org/show_bug.cgi?id=90841

Reviewed by Adrienne Walker.

Source/WebCore:

Remove the TextureManager from LayerRendererChromium, which was the last
instance of the class in the compositor. Instead of using ManagedTexture
objects for RenderPass textures, use instances of CCScopedTexture, which
manage the lifetime of the allocated texture ids. TextureManager will be
removed entirely once all callers of memoryUseBytes() have been removed.

No new tests. No change in behaviour.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::releaseRenderPassTextures):
(WebCore):
(WebCore::LayerRendererChromium::renderPassTextureSize):
(WebCore::LayerRendererChromium::renderPassTextureFormat):
(WebCore::LayerRendererChromium::decideRenderPassAllocationsForFrame):
(WebCore::LayerRendererChromium::haveCachedResourcesForRenderPassId):
(WebCore::LayerRendererChromium::drawQuad):
(WebCore::applyFilters):
(WebCore::LayerRendererChromium::drawBackgroundFilters):
(WebCore::LayerRendererChromium::drawRenderPassQuad):
(WebCore::LayerRendererChromium::drawHeadsUpDisplay):
(WebCore::LayerRendererChromium::getFramebufferTexture):
(WebCore::LayerRendererChromium::isCurrentRenderPass):
(WebCore::LayerRendererChromium::useRenderPass):
(WebCore::LayerRendererChromium::useScopedTexture):
(WebCore::LayerRendererChromium::bindFramebufferToTexture):
(WebCore::LayerRendererChromium::initializeSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:

(WebCore):
(LayerRendererChromium):

  • platform/graphics/chromium/TrackingTextureAllocator.cpp:

(WebCore::TrackingTextureAllocator::TrackingTextureAllocator):
(WebCore::TrackingTextureAllocator::createTexture):

  • platform/graphics/chromium/TrackingTextureAllocator.h:

(WebCore::TrackingTextureAllocator::create):
(TrackingTextureAllocator):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::draw):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h:

(WebCore):
(CCHeadsUpDisplay):

  • platform/graphics/chromium/cc/CCRenderer.h:

(WebCore):
(CCRenderer):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:
15:45 Changeset [122271] by dino@apple.com

REGRESSION (r109610): Order of values in shorthand animation makes a difference
https://bugs.webkit.org/show_bug.cgi?id=84533
<rdar://problem/11831924>
<rdar://problem/11815787>

Reviewed by Simon Fraser.

Source/WebCore:

A previous revision (r109610) updated the parsing of the animation shorthand
to make sure that animation-name wouldn't clobber other styles. The side effect
of this was that we'd no longer find animation-name if it wasn't first in the
list. This commit reverts the change and fixes it in a different way, by always
parsing animation-name as the last property in the shorthand. This means that
keywords for timing functions, fill modes and iteration will match before
animation name. In other words, if you want an animation called "forwards"
you should use the longhand property, because the shorthand will first match
that against animation-fill-mode.

Test: animations/animation-shorthand-name-order.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseAnimationShorthand): make a new array of longhand
properties to check for, with name as the last entry rather than the first.
Use this array to test the properties in the shorthand.

LayoutTests:

A new test that exercises many different variants of the animation shorthand
property, putting the animation name in different spots in the list of values.

  • animations/animation-shorthand-name-order-expected.txt: Added.
  • animations/animation-shorthand-name-order.html: Added.
15:14 Changeset [122270] by commit-queue@webkit.org

[WK2] Add Vibration API support for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=90058

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-10
Reviewed by Anders Carlsson.

Add support for Vibration API to WebKit2.

  • CMakeLists.txt:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Platform/CoreIPC/MessageID.h:
  • Shared/API/c/WKBase.h:
  • Shared/APIObject.h:
  • Target.pri:
  • UIProcess/API/C/WKAPICast.h:

(WebKit):

  • UIProcess/API/C/WKVibration.cpp: Added.

(WKVibrationGetTypeID):
(WKVibrationSetProvider):

  • UIProcess/API/C/WKVibration.h: Added.
  • UIProcess/WebVibrationProvider.cpp: Added.

(WebKit):
(WebKit::WebVibrationProvider::vibrate):
(WebKit::WebVibrationProvider::cancelVibration):

  • UIProcess/WebVibrationProvider.h: Added.

(WebKit):
(WebVibrationProvider):

  • UIProcess/WebVibrationProxy.cpp: Added.

(WebKit):
(WebKit::WebVibrationProxy::create):
(WebKit::WebVibrationProxy::WebVibrationProxy):
(WebKit::WebVibrationProxy::~WebVibrationProxy):
(WebKit::WebVibrationProxy::invalidate):
(WebKit::WebVibrationProxy::initializeProvider):
(WebKit::WebVibrationProxy::didReceiveMessage):
(WebKit::WebVibrationProxy::vibrate):
(WebKit::WebVibrationProxy::cancelVibration):

  • UIProcess/WebVibrationProxy.h: Added.

(CoreIPC):
(WebKit):
(WebVibrationProxy):
(WebKit::WebVibrationProxy::clearContext):
(WebKit::WebVibrationProxy::type):

  • UIProcess/WebVibrationProxy.messages.in: Added.
  • WebProcess/WebCoreSupport/WebVibrationClient.cpp: Added.

(WebKit):
(WebKit::WebVibrationClient::vibrate):
(WebKit::WebVibrationClient::cancelVibration):
(WebKit::WebVibrationClient::vibrationDestroyed):

  • WebProcess/WebCoreSupport/WebVibrationClient.h: Added.

(WebKit):
(WebVibrationClient):
(WebKit::WebVibrationClient::WebVibrationClient):
(WebKit::WebVibrationClient::~WebVibrationClient):

15:11 Changeset [122269] by kseo@webkit.org

Fix a potential bug of BitmapImage::frameCount().
https://bugs.webkit.org/show_bug.cgi?id=90756

Patch by Huang Dongsung <luxtella@company100.net> on 2012-07-10
Reviewed by Simon Fraser.

If an ImageDecoder is not yet initialized, m_source.frameCount() returns 0. This
does not mean that the frame count is actually 0. So we must set
m_haveFrameCount to true only when m_frameCount is not 0.

The current code is okay because BitmapImage::frameCount() is never called
before the decoder is initialized. However, this no longer holds true once we
introduce parallel image decoders.

No new tests, no behavior change.

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::frameCount):

15:08 Changeset [122268] by ojan@chromium.org

Build fix. Removing unused variable from http://trac.webkit.org/changeset/122264.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeContentLogicalHeightUsing):

15:03 Changeset [122267] by rniwa@webkit.org

HTMLPropertiesCollection should share more code with HTMLCollection
https://bugs.webkit.org/show_bug.cgi?id=90842

Reviewed by Anders Carlsson.

Got rid of HTMLPropertiesCollection::m_cache, and added m_itemRefElements, m_propertyNames, m_propertyCache,
m_hasPropertyNameCache, and m_hasItemRefElements to HTMLPropertiesCollection itself. These are caches specific
to HTMLPropertiesCollection. Note that hasNameCache has been renamed to m_hasPropertyNameCache and itemRefElementPosition
has been replaced by cachedElementsArrayOffset() in HTMLCollectionCacheBase (also used in HTMLFormCollection).

Also deleted all methods on m_cache except updatePropertyCache since caches can be accessed directly from
HTMLPropertiesCollection.

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::invalidateCacheIfNeeded):
(WebCore::HTMLCollection::invalidateCache):

  • html/HTMLCollection.h:

(HTMLCollection):

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::HTMLPropertiesCollection):
(WebCore):
(WebCore::HTMLPropertiesCollection::updateRefElements):
(WebCore::HTMLPropertiesCollection::itemAfter):
(WebCore::HTMLPropertiesCollection::calcLength):
(WebCore::HTMLPropertiesCollection::cacheFirstItem):
(WebCore::HTMLPropertiesCollection::item):
(WebCore::HTMLPropertiesCollection::findProperties):
(WebCore::HTMLPropertiesCollection::updateNameCache):
(WebCore::HTMLPropertiesCollection::names):
(WebCore::HTMLPropertiesCollection::namedItem):
(WebCore::HTMLPropertiesCollection::hasNamedItem):

  • html/HTMLPropertiesCollection.h:

(HTMLPropertiesCollection):
(WebCore::HTMLPropertiesCollection::clearCache):
(WebCore::HTMLPropertiesCollection::updatePropertyCache):

15:01 Changeset [122266] by cevans@google.com

Merge 120983 - Clang build fix.

  • dom/NodeRareData.h:

TBR=rniwa@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10701129

14:58 Changeset [122265] by rafaelw@chromium.org

Unreviewed gardening. Removing duplicated line from TestExpectations.

  • platform/chromium/TestExpectations:
14:45 Changeset [122264] by ojan@chromium.org

Add support for min-height:auto and min-width:auto
https://bugs.webkit.org/show_bug.cgi?id=88437

Reviewed by Tony Chang.

Source/WebCore:

Right now auto does the same thing as min-height/min-width:0.
For flex-items it should be the same as min-content (followup patch).
http://dev.w3.org/csswg/css3-flexbox/#min-size-auto

Tests: fast/css/auto-min-size.html

fast/css/deprecated-flexbox-auto-min-size.html

  • WebCore.order:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Return 0px for the computed value of auto.

  • css/CSSParser.cpp:

(WebCore::CSSParser::validWidth):
(WebCore):
(WebCore::CSSParser::validHeight):
(WebCore::CSSParser::parseValue):

  • css/CSSParser.h:

(CSSParser):
Restructure width/height parsing to reduce code duplication and make it easier
to add auto as a valid min value.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::adjustSizeConstraints):
This code was unnecessarily checking intrinsicOrAuto since auto was previously
not an allowed value for minWidth/minHeight.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
(WebCore::RenderBox::sizesLogicalWidthToFitContent):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computeLogicalHeightUsing):
(WebCore::RenderBox::computeContentLogicalHeightUsing):
(WebCore::RenderBox::computeReplacedLogicalWidth):
(WebCore::RenderBox::computeReplacedLogicalWidthRespectingMinMaxWidth):
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeight):
(WebCore::RenderBox::computeReplacedLogicalHeightRespectingMinMaxHeight):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalHeight):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
Need to pass a SizeType to all these methods so that we know if the Length
we're working with is a min length since auto has a different meaning now
for min lengths.

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::allowedChildFlex):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computePreferredLogicalWidths):
(WebCore::RenderFlexibleBox::computeAvailableFreeSpace):
(WebCore::RenderFlexibleBox::lineBreakLength):
(WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeReplacedLogicalWidth):
(WebCore::RenderReplaced::computeReplacedLogicalHeight):

  • rendering/RenderScrollbarPart.cpp:

(WebCore::calcScrollbarThicknessUsing):
(WebCore::RenderScrollbarPart::computeScrollbarWidth):
(WebCore::RenderScrollbarPart::computeScrollbarHeight):

  • rendering/style/RenderStyle.h:

Default minHeight/minWidth to auto instead of 0px.

LayoutTests:

  • fast/css/auto-min-size-expected.txt: Added.
  • fast/css/auto-min-size.html: Added.
  • fast/css/deprecated-flexbox-auto-min-size.html: Added.
  • platform/chromium-linux/fast/css/deprecated-flexbox-auto-min-size-expected.txt: Added.
14:21 Changeset [122263] by cevans@google.com

Merge 121105
BUG=134088
Review URL: https://chromiumcodereview.appspot.com/10704139

14:21 Changeset [122262] by jsbell@chromium.org

[Chromium] IndexedDB: Need test of Typed Arrays
https://bugs.webkit.org/show_bug.cgi?id=81979

Reviewed by Tony Chang.

Verify storage of Typed Arrays (Uint8Array and friends). Checks that
these types are stored and read back with types and data intact. Also
add an index to the object store, so that key paths are evaluated
against each type on every write operation.

  • storage/indexeddb/structured-clone-expected.txt:
  • storage/indexeddb/structured-clone.html:
14:13 Changeset [122261] by wangxianzhu@chromium.org

[Chromium-Android] Fix typos in chromium_android.py in r151492
https://bugs.webkit.org/show_bug.cgi?id=90904

Reviewed by Ojan Vafai.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.setup_test_run):

13:57 Changeset [122260] by danakj@chromium.org

Merge 121450 - [chromium] Should schedule a commit when dropping contents textures
https://bugs.webkit.org/show_bug.cgi?id=90031

Patch by James Robinson <jamesr@chromium.org> on 2012-06-28
Reviewed by Adrienne Walker.

Source/WebCore:

If we're dropping contents textures on the impl thread, we need to schedule a commit to pick up new contents at
the next commit opportunity. Also adds some traces to make debugging issues like this easier.

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::commitComplete):
(WebCore::CCLayerTreeHostImpl::canDraw):
(WebCore::CCLayerTreeHostImpl::releaseContentsTextures):

  • platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::processScheduledActions):

Source/WebKit/chromium:

Adds a somewhat vacuous test unit test for committing when releasing textures.

  • tests/CCLayerTreeHostImplTest.cpp:

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10694117

13:54 Changeset [122259] by danakj@chromium.org

Merge 121076 - [chromium] LayerRendererChromium is not getting visibility messages in single threaded compositing mode.
https://bugs.webkit.org/show_bug.cgi?id=89045

Reviewed by Adrienne Walker.

Based on patch by Michal Mocny <mmocny@google.com>.

Source/WebCore:

Invariants:

1.) We never commit (paint, animate, any of it) when not visible on the main thread -except- for
compositeAndReadback, regardless of threaded vs non-threaded mode
2.) CCLayerTreeHost::m_contentsTextureManager's memory budget is only set by updateLayers() when we are going to
make a frame and is always set to a non-zero value
3.) Zero-sized allocations from the GPU process are always serviced immediately on the impl thread. Non-zero
allocations are met in the next frame, whenever we would produce that frame according to our usual frame
scheduling logic.
4.) The impl thread always knows the set of currently-allocated managed texture IDs and can delete them all
whenever it likes without needing the main thread to be responsive.

Details:

[See original commit...]

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererGpuMemoryAllocationChangedCallbackAdapter::onGpuMemoryAllocationChangedOnImpl):
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::setVisible):
(WebCore::LayerRendererChromium::setGpuMemoryAllocation):
(WebCore):
(WebCore::LayerRendererChromium::swapBuffers):
(WebCore::LayerRendererChromium::getFramebufferPixels):

  • platform/graphics/chromium/LayerRendererChromium.h:

(WebCore):
(LayerRendererChromium):

  • platform/graphics/chromium/TextureManager.cpp:

(WebCore::TextureManager::evictAndRemoveAllDeletedTextures):
(WebCore):

  • platform/graphics/chromium/TextureManager.h:

(TextureAllocator):
(TextureManager):

  • platform/graphics/chromium/TrackingTextureAllocator.cpp:

(WebCore::TrackingTextureAllocator::createTexture):
(WebCore::TrackingTextureAllocator::deleteTexture):
(WebCore):
(WebCore::TrackingTextureAllocator::deleteAllTextures):

  • platform/graphics/chromium/TrackingTextureAllocator.h:

(TrackingTextureAllocator):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initializeLayerRenderer):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::evictAllContentTextures):
(WebCore::CCLayerTreeHost::updateLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::commitComplete):
(WebCore::CCLayerTreeHostImpl::canDraw):
(WebCore::CCLayerTreeHostImpl::context):
(WebCore::CCLayerTreeHostImpl::releaseContentsTextures):
(WebCore):
(WebCore::CCLayerTreeHostImpl::setMemoryAllocationLimitBytes):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImplClient):
(WebCore::CCLayerTreeHostImpl::contentsTexturesWerePurgedSinceLastCommit):
(WebCore::CCLayerTreeHostImpl::memoryAllocationLimitBytes):
(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCProxy.h:

(CCProxy):

  • platform/graphics/chromium/cc/CCRenderer.h:

(CCRendererClient):

  • platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::beginFrameComplete):
(WebCore::CCScheduler::beginFrameAborted):
(WebCore):
(WebCore::CCScheduler::didSwapBuffersComplete):
(WebCore::CCScheduler::didLoseContext):
(WebCore::CCScheduler::didRecreateContext):
(WebCore::CCScheduler::vsyncTick):

  • platform/graphics/chromium/cc/CCScheduler.h:

(CCScheduler):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::beginFrameAborted):
(WebCore):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::setVisible):
(WebCore):
(WebCore::CCSingleThreadProxy::stop):
(WebCore::CCSingleThreadProxy::commitAndComposite):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(CCSingleThreadProxy):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::setVisible):
(WebCore):
(WebCore::CCThreadProxy::setVisibleOnImplThread):
(WebCore::CCThreadProxy::scheduledActionBeginFrame):
(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::beginFrameAbortedOnImplThread):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal):
(WebCore::CCThreadProxy::layerTreeHostClosedOnImplThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):
(BeginFrameAndCommitState):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::~CCVideoLayerImpl):
(WebCore::CCVideoLayerImpl::willDraw):
(WebCore::CCVideoLayerImpl::willDrawInternal):
(WebCore::CCVideoLayerImpl::FramePlane::allocateData):
(WebCore::CCVideoLayerImpl::FramePlane::freeData):
(WebCore::CCVideoLayerImpl::allocatePlaneData):
(WebCore::CCVideoLayerImpl::freePlaneData):
(WebCore::CCVideoLayerImpl::freeUnusedPlaneData):
(WebCore::CCVideoLayerImpl::didLoseContext):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:

(FramePlane):

Source/WebKit/chromium:

Update various test fixtures and tests to cover scheduling, visibility, and resource allocation changes.

  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/CCLayerTreeHostTest.cpp:

(CCLayerTreeHostTestAbortFrameWhenInvisible):
(WTF::CCLayerTreeHostTestAbortFrameWhenInvisible::CCLayerTreeHostTestAbortFrameWhenInvisible):
(WTF::CCLayerTreeHostTestAbortFrameWhenInvisible::beginTest):
(WTF::CCLayerTreeHostTestAbortFrameWhenInvisible::afterTest):
(WTF):
(WTF::TEST_F):
(WTF::CCLayerTreeHostTestLayerOcclusion::beginTest):
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest):
(WTF::CCLayerTreeHostTestManySurfaces::beginTest):

  • tests/CCSchedulerStateMachineTest.cpp:

(WebCore::TEST):

  • tests/CCTiledLayerTestCommon.h:
  • tests/FakeWebGraphicsContext3D.h:

(WebKit::FakeWebGraphicsContext3D::FakeWebGraphicsContext3D):
(FakeWebGraphicsContext3D):
(WebKit::FakeWebGraphicsContext3D::createTexture):

  • tests/LayerRendererChromiumTest.cpp:

(TEST_F):

  • tests/TiledLayerChromiumTest.cpp:

TBR=jamesr@google.com
Review URL: https://chromiumcodereview.appspot.com/10690121

13:54 Changeset [122258] by ojan@chromium.org

webkit-patch rebaseline doesn't work for audio/pixel tests
https://bugs.webkit.org/show_bug.cgi?id=90905

Reviewed by Adam Barth.

We just need to pass the correct suffix list to rebaseline-test-internal
and optimize-baselines. By default, pass all suffixes.

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(Rebaseline):
(Rebaseline.init):
(Rebaseline._suffixes_to_update):
(Rebaseline.execute):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(test_rebaseline_multiple_builders_and_tests_command_line):

13:47 Changeset [122257] by danakj@chromium.org

Merge 120858 - [chromium] Separate LayerRenderer initialization from updateLayers
https://bugs.webkit.org/show_bug.cgi?id=89525

Reviewed by Adrienne Walker.

Source/WebCore:

This adds an explicit call to initialize the layer renderer of a given CCLayerTreeHost instead of having it be
implicit in updateLayers(). This way the proxies can control the initialization sequence more closely and do
useful work between the two calls.

Refactor, no change in behavior. Covered by existing tests.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::compositeAndReadback):
(WebCore::CCLayerTreeHost::initializeLayerRendererIfNeeded):
(WebCore):
(WebCore::CCLayerTreeHost::updateLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::commitAndComposite):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::beginFrame):

Source/WebKit/chromium:

Update tests to call initializeLayerRendererIfNeeded() before calling updateLayers() to reflect what the proxies
do.

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestLayerOcclusion::beginTest):
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest):
(WTF::CCLayerTreeHostTestManySurfaces::beginTest):

  • tests/TiledLayerChromiumTest.cpp:

TBR=jamesr@google.com
Review URL: https://chromiumcodereview.appspot.com/10702135

13:39 Changeset [122256] by abarth@webkit.org

Remove LayoutTestController and WebKitTestRunner support for Hixie76 WebSockets
https://bugs.webkit.org/show_bug.cgi?id=90853

Reviewed by Eric Seidel.

Tools:

WebKit no longer implements the Hixie76 version of the WebSocket
protocol. We don't need to support it in our test framework.

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::overridePreference):

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::reset):
(WebPreferences::applyTo):

  • DumpRenderTree/chromium/WebPreferences.h:

(WebPreferences):

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::overridePreference):

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::resetSettings):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::overridePreference):

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

LayoutTests:

There's no need to explicitly disable the Hixie76 protocol because it
no longer exists in WebKit.

  • http/tests/websocket/tests/hybi/alert-in-event-handler.html:
  • http/tests/websocket/tests/hybi/bad-handshake-crash.html:
  • http/tests/websocket/tests/hybi/bad-sub-protocol-control-chars.html:
  • http/tests/websocket/tests/hybi/bad-sub-protocol-empty.html:
  • http/tests/websocket/tests/hybi/bad-sub-protocol-non-ascii.html:
  • http/tests/websocket/tests/hybi/binary-type.html:
  • http/tests/websocket/tests/hybi/broken-utf8.html:
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html:
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close.html:
  • http/tests/websocket/tests/hybi/client-close.html:
  • http/tests/websocket/tests/hybi/close-before-open.html:
  • http/tests/websocket/tests/hybi/close-code-and-reason.html:
  • http/tests/websocket/tests/hybi/close-event.html:
  • http/tests/websocket/tests/hybi/close-on-navigate-new-location.html:
  • http/tests/websocket/tests/hybi/close-on-unload-and-force-gc.html:
  • http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent.html:
  • http/tests/websocket/tests/hybi/close-on-unload.html:
  • http/tests/websocket/tests/hybi/close-unref-websocket.html:
  • http/tests/websocket/tests/hybi/close.html:
  • http/tests/websocket/tests/hybi/compressed-control-frame.html:
  • http/tests/websocket/tests/hybi/cross-origin.html:
  • http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff.html:
  • http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter.html:
  • http/tests/websocket/tests/hybi/deflate-frame-parameter.html:
  • http/tests/websocket/tests/hybi/echo-with-no-extension.html:
  • http/tests/websocket/tests/hybi/extensions.html:
  • http/tests/websocket/tests/hybi/fragmented-binary-frames.html:
  • http/tests/websocket/tests/hybi/fragmented-control-frame.html:
  • http/tests/websocket/tests/hybi/fragmented-frames.html:
  • http/tests/websocket/tests/hybi/frame-lengths.html:
  • http/tests/websocket/tests/hybi/handshake-challenge-randomness.html:
  • http/tests/websocket/tests/hybi/handshake-error.html:
  • http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header.html:
  • http/tests/websocket/tests/hybi/handshake-fail-by-maxlength.html:
  • http/tests/websocket/tests/hybi/handshake-fail-by-mismatch-protocol-header.html:
  • http/tests/websocket/tests/hybi/handshake-fail-by-more-accept-header.html:
  • http/tests/websocket/tests/hybi/handshake-fail-by-more-protocol-header.html:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-accept-header.html:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-connection-header.html:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-cr.html:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-upgrade-header.html:
  • http/tests/websocket/tests/hybi/handshake-fail-by-prepended-null.html:
  • http/tests/websocket/tests/hybi/handshake-fail-by-wrong-accept-header.html:
  • http/tests/websocket/tests/hybi/httponly-cookie.pl:
  • http/tests/websocket/tests/hybi/interleaved-fragments.html:
  • http/tests/websocket/tests/hybi/invalid-continuation.html:
  • http/tests/websocket/tests/hybi/invalid-encode-length.html:
  • http/tests/websocket/tests/hybi/invalid-masked-frames-from-server.html:
  • http/tests/websocket/tests/hybi/invalid-subprotocol-characters.html:
  • http/tests/websocket/tests/hybi/invalid-subprotocols.html:
  • http/tests/websocket/tests/hybi/long-control-frame.html:
  • http/tests/websocket/tests/hybi/long-invalid-header.html:
  • http/tests/websocket/tests/hybi/multiple-connections.html:
  • http/tests/websocket/tests/hybi/multiple-subprotocols.html:
  • http/tests/websocket/tests/hybi/no-subprotocol.html:
  • http/tests/websocket/tests/hybi/null-character.html:
  • http/tests/websocket/tests/hybi/pong.html:
  • http/tests/websocket/tests/hybi/receive-arraybuffer.html:
  • http/tests/websocket/tests/hybi/receive-blob.html:
  • http/tests/websocket/tests/hybi/reload-crash.html:
  • http/tests/websocket/tests/hybi/reserved-bits.html:
  • http/tests/websocket/tests/hybi/reserved-opcodes.html:
  • http/tests/websocket/tests/hybi/send-after-close-on-unload.html:
  • http/tests/websocket/tests/hybi/send-arraybuffer.html:
  • http/tests/websocket/tests/hybi/send-blob.html:
  • http/tests/websocket/tests/hybi/send-empty.html:
  • http/tests/websocket/tests/hybi/send-file-blob-fail.html:
  • http/tests/websocket/tests/hybi/send-file-blob.html:
  • http/tests/websocket/tests/hybi/send-object-tostring-check.html:
  • http/tests/websocket/tests/hybi/send-throw.html:
  • http/tests/websocket/tests/hybi/send.html:
  • http/tests/websocket/tests/hybi/server-close.html:
  • http/tests/websocket/tests/hybi/set-protocol.html:
  • http/tests/websocket/tests/hybi/simple-stress.html:
  • http/tests/websocket/tests/hybi/simple.html:
  • http/tests/websocket/tests/hybi/sub-protocol.html:
  • http/tests/websocket/tests/hybi/too-long-payload.html:
  • http/tests/websocket/tests/hybi/unicode.html:
  • http/tests/websocket/tests/hybi/unmasked-frames.html:
  • http/tests/websocket/tests/hybi/unpaired-surrogates-in-close-reason.html:
  • http/tests/websocket/tests/hybi/unpaired-surrogates-in-message.html:
  • http/tests/websocket/tests/hybi/url-attribute.html:
  • http/tests/websocket/tests/hybi/url-no-trailing-slash.html:
  • http/tests/websocket/tests/hybi/url-parsing.html:
  • http/tests/websocket/tests/hybi/url-with-credential.html:
  • http/tests/websocket/tests/hybi/url-with-empty-query.html:
  • http/tests/websocket/tests/hybi/url-with-query.html:
  • http/tests/websocket/tests/hybi/websocket-event-target.html:
  • http/tests/websocket/tests/hybi/websocket-pending-activity.html:
  • http/tests/websocket/tests/hybi/workers/close-code-and-reason.html:
  • http/tests/websocket/tests/hybi/workers/close-in-onmessage-crash.html:
  • http/tests/websocket/tests/hybi/workers/close-in-shared-worker.html:
  • http/tests/websocket/tests/hybi/workers/close-in-worker.html:
  • http/tests/websocket/tests/hybi/workers/close.html:
  • http/tests/websocket/tests/hybi/workers/multiple-subprotocols.html:
  • http/tests/websocket/tests/hybi/workers/no-onmessage-in-sync-op.html:
  • http/tests/websocket/tests/hybi/workers/no-subprotocol.html:
  • http/tests/websocket/tests/hybi/workers/receive-arraybuffer.html:
  • http/tests/websocket/tests/hybi/workers/receive-blob.html:
  • http/tests/websocket/tests/hybi/workers/send-arraybuffer.html:
  • http/tests/websocket/tests/hybi/workers/send-blob.html:
  • http/tests/websocket/tests/hybi/workers/shared-worker-simple.html:
  • http/tests/websocket/tests/hybi/workers/worker-handshake-challenge-randomness.html:
  • http/tests/websocket/tests/hybi/workers/worker-reload.html:
  • http/tests/websocket/tests/hybi/workers/worker-simple.html:
  • http/tests/websocket/tests/hybi/zero-length-text.html:
13:30 Changeset [122255] by wangxianzhu@chromium.org

[Chromium-Android] Use default font rendering styles in FontPlatformData::querySystemForRenderStyle()
https://bugs.webkit.org/show_bug.cgi?id=90826

Reviewed by Adam Barth.

Source/WebCore:

No new tests. The change to this file is refactoring only.

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:

(WebCore::FontPlatformData::querySystemForRenderStyle): Moved the "NoPreference" initialization into PlatformSupport::PlatformSupport::getRenderStyleForStrike().

Source/WebKit/chromium:

  • WebKit.gyp:
  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::getRenderStyleForStrike): Call style.setDefault() on Android or when the font is not specified.

13:23 Changeset [122254] by rafaelw@chromium.org

Unreviewed gardening. Adding the majority of the remaining indexeddb/mozilla tests which are all flaky and crashing.

  • platform/chromium/TestExpectations:
13:21 Changeset [122253] by commit-queue@webkit.org

AudioFIFO not correctly wrapping the write index on push
https://bugs.webkit.org/show_bug.cgi?id=90901

Patch by Raymond Toy <rtoy@google.com> on 2012-07-10
Reviewed by Chris Rogers.

No new tests

  • platform/audio/AudioFIFO.cpp:

(WebCore::AudioFIFO::push): Wrap the write index, not read index!

13:14 Changeset [122252] by danakj@chromium.org

[chromium] Avoid allocating render pass textures that have no content
https://bugs.webkit.org/show_bug.cgi?id=90702

Reviewed by Adrienne Walker.

Source/WebCore:

When OOM conditions are hit, textures are not allocated for some layers
which can prevent any quads from being present for a render surface.
This is used as a signal to prevent the RenderPass from allocating a
texture.

Replace the CCLayerTreeHostImpl::removePassesWithCachedTextures() method
with a general removeRenderPasses() which takes a culling control object
and will remove passes based on the inputs from the control object.

This new method is used for the old purpose of removing passes with cached
textures, as well as to remove passes that do not have any quad inputs.

Test: CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawRenderPassQuad):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore):
(WebCore::CCLayerTreeHostImpl::CullRenderPassesWithCachedTextures::shouldRemoveRenderPass):
(WebCore::CCLayerTreeHostImpl::CullRenderPassesWithNoQuads::shouldRemoveRenderPass):
(WebCore::CCLayerTreeHostImpl::removeRenderPasses):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore):
(CullRenderPassesWithCachedTextures):
(WebCore::CCLayerTreeHostImpl::CullRenderPassesWithCachedTextures::renderPassListBegin):
(WebCore::CCLayerTreeHostImpl::CullRenderPassesWithCachedTextures::renderPassListEnd):
(WebCore::CCLayerTreeHostImpl::CullRenderPassesWithCachedTextures::renderPassListNext):
(WebCore::CCLayerTreeHostImpl::CullRenderPassesWithCachedTextures::CullRenderPassesWithCachedTextures):
(CCLayerTreeHostImpl):
(CullRenderPassesWithNoQuads):
(WebCore::CCLayerTreeHostImpl::CullRenderPassesWithNoQuads::renderPassListBegin):
(WebCore::CCLayerTreeHostImpl::CullRenderPassesWithNoQuads::renderPassListEnd):
(WebCore::CCLayerTreeHostImpl::CullRenderPassesWithNoQuads::renderPassListNext):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/CCLayerTreeHostTest.cpp:

(WTF::ContentLayerChromiumWithUpdateTracking::ContentLayerChromiumWithUpdateTracking):
(CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit):
(WTF::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit):
(WTF::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit::beginTest):
(WTF::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit::didCommit):
(WTF::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit::afterTest):
(WTF):

12:56 Changeset [122251] by wangxianzhu@chromium.org

[Chromium-Android] Use setup_test_runner() instead of start_helper() to setup test environment
https://bugs.webkit.org/show_bug.cgi?id=90894

Reviewed by Adam Barth.

start_helper() is actually start_pixel_test_helper() since r115601 (bug 81729).
Should use setup_test_runner() to setup test environment for chromium-android.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.setup_test_run): Renamed from start_helper(). Added cache cleanup code.
(ChromiumAndroidPort.clean_up_test_run): Renamed from stop_helper().
(ChromiumAndroidPort._path_to_helper): Returns None as we don't have a helper now.
(ChromiumAndroidPort):
(ChromiumAndroidPort._path_to_forwarder): Original _path_to_helper().
(ChromiumAndroidPort._push_executable):
(ChromiumAndroidDriver.init):
(ChromiumAndroidDriver.cmd_line):

12:52 Changeset [122250] by commit-queue@webkit.org

Make GC3D and E3D more maintainable for GLES platforms
https://bugs.webkit.org/show_bug.cgi?id=90567

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-10
Reviewed by Rob Buis.

This patch cleans up code for WebGL on OpenGLES platforms which use
GraphicsContext3DOpenGL* and Extensions3DOpenGL*. Although
GraphicsContext3DOpenGL was already split into GraphicsContext3DOpenGL,
GraphicsContext3DOpenGLCommon, and GraphicsContext3DOpenGLES, this patch
is an attempt to refactor this code in a way that will help BlackBerry and
other teams support WebGL on mobile platforms with as little use of
"#IF USE(OPENGL_ES_2)" in common code as possible. Also included is the
separation of Extensions3DOpenGL into Extensions3DOpenGLCommon,
Extensions3DOpenGL, and Extensions3DOpenGLES as well as the introduction
of OpenGLESShims.

This patch is created in large part by Jonathan Feldstein.

No new tests: no new behaviour.

  • PlatformBlackBerry.cmake: Recognize BlackBerry as OPENGL ES, add new files to build
  • Target.pri: Add new Extensions3DOpenGL* to WebGL builds
  • platform/graphics/GraphicsContext3D.h: Add validateDepthStencil, make systemAllowsMultisamplingOnATICards a a member function.

(WebCore):

  • platform/graphics/OpenGLESShims.h: Added.
  • platform/graphics/opengl/Extensions3DOpenGL.cpp: Move code to Extensions3DOpenGLCommon where possible

(WebCore::Extensions3DOpenGL::Extensions3DOpenGL): Reflect that it is now inherits Extensions3DCommon
(WebCore::Extensions3DOpenGL::supportsExtension): Contains OpenGL specific code from supports
(WebCore):
(WebCore::Extensions3DOpenGL::getExtensions): Returns a list of extensions

  • platform/graphics/opengl/Extensions3DOpenGL.h: Remove functions now in Extensions3DOpenGLCommon

(WebCore):
(Extensions3DOpenGL):

  • platform/graphics/opengl/Extensions3DOpenGLCommon.cpp: Added.

(WebCore):
(WebCore::Extensions3DOpenGLCommon::Extensions3DOpenGLCommon):
(WebCore::Extensions3DOpenGLCommon::~Extensions3DOpenGLCommon):
(WebCore::Extensions3DOpenGLCommon::supports):
(WebCore::Extensions3DOpenGLCommon::ensureEnabled):
(WebCore::Extensions3DOpenGLCommon::isEnabled):
(WebCore::Extensions3DOpenGLCommon::getGraphicsResetStatusARB):
(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE): Existed before, but did nothing. Now does what is says it does.
(WebCore::Extensions3DOpenGLCommon::initializeAvailableExtensions): Moved from Extensions3DOpenGL::supports

  • platform/graphics/opengl/Extensions3DOpenGLCommon.h: Copied from Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.h.

(WebCore):
(Extensions3DOpenGLCommon):

  • platform/graphics/opengl/Extensions3DOpenGLES.cpp: Added.

(WebCore):
(WebCore::Extensions3DOpenGLES::Extensions3DOpenGLES):
(WebCore::Extensions3DOpenGLES::~Extensions3DOpenGLES):
(WebCore::Extensions3DOpenGLES::framebufferTexture2DMultisampleIMG):
(WebCore::Extensions3DOpenGLES::renderbufferStorageMultisampleIMG):
(WebCore::Extensions3DOpenGLES::createVertexArrayOES):
(WebCore::Extensions3DOpenGLES::deleteVertexArrayOES):
(WebCore::Extensions3DOpenGLES::isVertexArrayOES):
(WebCore::Extensions3DOpenGLES::bindVertexArrayOES):
(WebCore::Extensions3DOpenGLES::supportsExtension): Contains OpenGLES specific code from supports
(WebCore::Extensions3DOpenGLES::getExtensions):

  • platform/graphics/opengl/Extensions3DOpenGLES.h: Copied from Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.h.

(WebCore):
(Extensions3DOpenGLES):

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::validateAttributes):
(WebCore):
(WebCore::GraphicsContext3D::renderbufferStorage):
(WebCore::GraphicsContext3D::texImage2D):
(WebCore::GraphicsContext3D::systemAllowsMultisamplingOnATICards): Now a member function.
(WebCore::GraphicsContext3D::getExtensions):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::validateDepthStencil):
(WebCore::GraphicsContext3D::clear):
(WebCore::GraphicsContext3D::isTexture):
(WebCore):
(WebCore::GraphicsContext3D::lineWidth):
(WebCore::GraphicsContext3D::linkProgram):
(WebCore::GraphicsContext3D::pixelStorei):
(WebCore::GraphicsContext3D::polygonOffset):
(WebCore::GraphicsContext3D::readPixels):
(WebCore::GraphicsContext3D::deleteBuffer):

  • platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:

(WebCore::GraphicsContext3D::releaseShaderCompiler):
(WebCore::GraphicsContext3D::readPixelsAndConvertToBGRAIfNecessary):
(WebCore::GraphicsContext3D::validateAttributes):
(WebCore):
(WebCore::GraphicsContext3D::getExtensions):
(WebCore::GraphicsContext3D::systemAllowsMultisamplingOnATICards): Now a member function.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore):
(WebCore::GraphicsContext3D::releaseShaderCompiler):

12:37 Changeset [122249] by cevans@google.com

Merge 121103
BUG=134088
Review URL: https://chromiumcodereview.appspot.com/10703124

12:36 Changeset [122248] by cevans@google.com

Merge 121003
BUG=134088
Review URL: https://chromiumcodereview.appspot.com/10696159

12:21 Changeset [122247] by rafaelw@chromium.org

Unreviewed gardening. Added resource-request-content-while-loading.html to flaky wkbug 83890.

  • platform/chromium/TestExpectations:
12:17 Changeset [122246] by cevans@google.com

Merge 120979
BUG=134088
Review URL: https://chromiumcodereview.appspot.com/10695128

12:15 Changeset [122245] by cevans@google.com

Merge 120868
BUG=134088
Review URL: https://chromiumcodereview.appspot.com/10689138

12:14 Changeset [122244] by hyatt@apple.com

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=90646
<rdar://problem/11648478> 3-pass pagination slows down pagination

Improve the logical top estimate function for margin collapsing to be more accurate. In particular
make the basic case of <body><p> or <body><h1> no longer be wrong. This estimate being incorrect
is not a big deal most of the time, but when paginating it is a very big deal, since you have to
relayout everything whenever your vertical placement is wrong.

Improving the estimation exposed a bug in an existing layout test. I had to clean up the buggy
code written for negative margin-related float detection and fix an invalid layout test to
actually be correct.

Reviewed by Simon Fraser.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::marginBeforeEstimateForChild):
(WebCore):
(WebCore::RenderBlock::estimateLogicalTopPosition):
(WebCore::RenderBlock::marginValuesForChild):

  • rendering/RenderBlock.h:

(RenderBlock):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::shrinkLogicalWidthToAvoidFloats):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=90646

Fix invalid layout test exposed by my changes to logical top estimation.

Reviewed by Simon Fraser.

  • fast/block/float/previous-sibling-float-002-expected.html:
  • fast/block/float/previous-sibling-float-002.html:
12:10 Changeset [122243] by commit-queue@webkit.org

Web Inspector: Count inspector memory used to traverse DOM in native memory snapshots.
https://bugs.webkit.org/show_bug.cgi?id=90456

Inspector may take significant amount of memory when traversing DOM structure.
Take it into account and report under inspector memory.

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-07-10
Reviewed by Pavel Feldman.

  • dom/MemoryInstrumentation.h:

(MemoryInstrumentation):
(WebCore::MemoryInstrumentation::calculateContainerSize):
(WebCore::MemoryInstrumentation::reportHashMap):
(WebCore::MemoryInstrumentation::reportHashSet):
(WebCore::MemoryInstrumentation::reportVector):

  • inspector/InspectorMemoryAgent.cpp:

(MemoryBlockName):
(WebCore):
(WebCore::domTreeInfo):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):

12:09 Changeset [122242] by cevans@google.com

Merge 120617
BUG=133288
Review URL: https://chromiumcodereview.appspot.com/10690118

12:02 Changeset [122241] by cevans@google.com

Merge 120639
BUG=132396
Review URL: https://chromiumcodereview.appspot.com/10696154

11:48 Changeset [122240] by rafaelw@chromium.org

Unreviewed gardening. tables/mozilla_expected_failures/other/empty_cells.html marked as flaky.

  • platform/chromium/TestExpectations:
11:39 Changeset [122239] by kareng@chromium.org

Merge 121722 - Position replaced elements on pixel bounds
https://bugs.webkit.org/show_bug.cgi?id=90354

Reviewed by Eric Seidel.

To avoid sizing and repaint issues we should layout replaced elements on
pixel bounds. We already ensure that replaced elements are sized in full
pixels and that they are painted on pixel bounds. By also ensuring that
they are placed on pixel bounds we avoid pixel having the size be
expanded by pixel snapping and repainting/invalidation rect issues when
scrolling.

Test: fast/repaint/repaint-during-scroll-with-zoom.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):

TBR=eae@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10696152

11:35 Changeset [122238] by kareng@chromium.org

Merge 121599 - Allow non-borders to be adjusted to less than 1 when zoomed out
https://bugs.webkit.org/show_bug.cgi?id=90104

Reviewed by Eric Seidel.

Source/WebCore:

Change CSSPrimitiveValue::computeLengthDouble to allow values to be
adjusted to less than 1.0 when zoomed out. This avoids an off by one
error for floats with margins when zoomed out that can cause floats to
wrap and break pages.

The logic that prevents the value from being adjusted to less than 1 was
added to ensure that borders are still painted even when zoomed out.
By moving the logic to ApplyPropertyComputeLength::applyValue, which is
used for borders and outlines, that functionality is preserved.

Test: fast/sub-pixel/float-with-margin-in-container.html

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::computeLengthDouble):

  • css/StyleBuilder.cpp:

(WebCore::ApplyPropertyComputeLength::applyValue):

LayoutTests:

Add test ensuring that floats with margins do not wrap in fixed sized
containers and update existing results as needed.

  • fast/css/zoom-background-repeat-x.html:
  • fast/sub-pixel/float-with-margin-in-container-expected.txt: Added.
  • fast/sub-pixel/float-with-margin-in-container.html: Added.
  • platform/chromium-linux/fast/reflections/reflection-with-zoom-expected.png:
  • platform/chromium-linux/fast/transforms/bounding-rect-zoom-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-mac/fast/transforms/bounding-rect-zoom-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/chromium-win/fast/transforms/bounding-rect-zoom-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/mac/fast/transforms/bounding-rect-zoom-expected.txt:
  • platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
  • platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:

TBR=eae@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10698133

11:27 Changeset [122237] by rafaelw@chromium.org

Unreviewed gardening. platform/chromium/inspector/styles/device-metrics-fit-window.html is timing out in debug and now marked as slow.

  • platform/chromium/TestExpectations:
11:15 Changeset [122236] by rafaelw@chromium.org

Unreviewed gardening. fast/js/dfg-cross-global-object-inline-array-literal.html is racey (and thus flaky).

10:33 Changeset [122235] by rafaelw@chromium.org

Unreviewed gardening. Adding another flaky test to bug 90469 (storage tests).

  • platform/chromium/TestExpectations:
10:33 Changeset [122234] by ojan@chromium.org

Improve webkit-patch rebaseline to work for more cases
https://bugs.webkit.org/show_bug.cgi?id=90504

Reviewed by Adam Barth.

-Makes it work for the build.chromium.org bots.
-Lets you rebaseline all builders instead of just one.
-Lets you pass in the builders or tests to rebaseline.

  • Scripts/webkitpy/common/host.py:

(Host.buildbot_for_builder_name):

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:

(Builder.init):
(Builder.latest_layout_test_results):
Provide a way to get to the LayoutTestResults of the latest build.
Most of the time we only need to get the latest one and the Chromium bots
only expose the full_results.json file for the latest build.

(Builder):
(Builder._fetch_file_from_results):
(Builder.fetch_layout_test_results):
Move these functions into Builder so that Builder and Build can both
fetch layout test results.

(Build.results_zip_url):
(Build.layout_test_results):

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

(BuilderTest.test_latest_layout_test_results):
(BuildTest.test_layout_test_results):

  • Scripts/webkitpy/common/system/user.py:

(User.prompt_with_multiple_lists):
Prompt with multiple sublists, but still have a global numbering.
This lets the build.chromium.org bots be clearly separated from the
build.webkit.org bots, which helps understand the builder names.

(User):
(User._wait_on_list_response):
(User.prompt_with_list):

  • Scripts/webkitpy/common/system/user_unittest.py:

(UserTest.test_prompt_with_multiple_lists):
(UserTest.test_prompt_with_multiple_lists.run_prompt_test):
(UserTest.test_prompt_with_multiple_lists.run_prompt_test.mock_raw_input):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.is_chromium):
Provide a way to tell if a port is a Chromium port that doesn't involve string
manipulation on the port name or builder name.

  • Scripts/webkitpy/layout_tests/port/builders.py:

(builder_path_from_name):
(all_builder_names):
Memoizing here is incorrect because the test override _exact_matches,
so these can return different values. In either case, I'm pretty sure these
are not remotely hot codepaths. I manually inspected all call sites and they're
all in high-level calls (e.g. execute calls for webkit-patch commands) and not
called in a loop.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.is_chromium):

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineTest._results_url):
(AbstractParallelRebaselineCommand.init):
(Rebaseline.init):
(Rebaseline):
(Rebaseline._builders_to_pull_from):
(Rebaseline._tests_to_update):
(Rebaseline.execute):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(test_rebaseline.mock_builders_to_pull_from):
(test_rebaseline):
(test_rebaseline_command_line_flags):
(test_rebaseline_multiple_builders):
(test_rebaseline_multiple_builders.mock_builders_to_pull_from):
(test_rebaseline_multiple_builders.mock_tests_to_update):
(test_rebaseline_multiple_builders_and_tests_command_line):

  • Scripts/webkitpy/tool/mocktool.py:

(MockTool.irc):
(MockTool):
(MockTool.buildbot_for_builder_name):

10:05 Changeset [122233] by commit-queue@webkit.org

[GTK] Fix memory leaks by adopting allocation of GdkPixbuf
https://bugs.webkit.org/show_bug.cgi?id=90790

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-10
Reviewed by Carlos Garcia Campos.

Source/WebCore:

Fixed a memory leak in paintGdkPixbuf by adopting an allocation
of GdkPixbuf.

No new tests. No change in behavior.

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore::paintGdkPixbuf):

Source/WebKit/gtk:

Fixed a memory leak in WebKitFaviconDatabase by adopting an
allocation of GdkPixbuf.

  • webkit/webkitfavicondatabase.cpp:

(getIconPixbufSynchronously):

10:03 Changeset [122232] by kpiascik@rim.com

Web Inspector: Geolocation override
https://bugs.webkit.org/show_bug.cgi?id=89365

Reviewed by Yong Li.

Source/WebCore:

Added a way to override the geoloation of a client using Web
Inspector.

New tests added.

  • LayoutTests/inspector/geolocation-success.html:
  • LayoutTests/inspector/getlocation-error.html:
  • Modules/geolocation/GeolocationController.cpp:

(WebCore::GeolocationController::GeolocationController): Now store and
save the Page in m_page.
(WebCore::GeolocationController::positionChanged): Check if position
is overriden in Web Inspector.

  • Modules/geolocation/GeolocationController.h:

(GeolocationController): Add member variable m_page for Page*.

  • inspector/Inspector.json: Add new methods for setting and clearing

the GeoloationPosition and GeolocationError objects in InspectorPageAgent.

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::checkGeolocationPositionOrErrorImpl):
Add methods to check whether GeolocationPosition or GeolocationError
are set in InspectorPageAgent.

  • inspector/InspectorInstrumentation.h:

(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::checkGeolocationPositionOrError):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::InspectorPageAgent): Initialize new
member variables of GeolocationPosition and GeolocationError.
(WebCore::InspectorPageAgent::setGeolocationData): Set Position and
Error data and call appropriate GeolocaitonController methods.
(WebCore):
(WebCore::InspectorPageAgent::clearGeolocationData):
(WebCore::InspectorPageAgent::sendGeolocationError):

  • inspector/InspectorPageAgent.h:

(WebCore::InspectorPageAgent::geolocationPosition): Getter for
GeolocationPosition.
(InspectorPageAgent):

  • inspector/front-end/Settings.js: Added new settings for

GeolocationPosition and GeolocationError

  • inspector/front-end/SettingsScreen.js: Added new control for

Geolocaiton.
(WebInspector.UserAgentSettingsTab):
(WebInspector.UserAgentSettingsTab.prototype._createDeviceMetricsElement):
(WebInspector.UserAgentSettingsTab.prototype._onGeolocationOverrideCheckboxClicked):
(WebInspector.UserAgentSettingsTab.prototype._applyGeolocationUserInput):
(WebInspector.UserAgentSettingsTab.prototype._setGeolocationPosition.set if):
(WebInspector.UserAgentSettingsTab.prototype._setGeolocationPosition):
(WebInspector.UserAgentSettingsTab.prototype._createGeolocationOverrideElement.createInput):
(WebInspector.UserAgentSettingsTab.prototype._createGeolocationOverrideElement):

  • inspector/front-end/UserAgentSupport.js: New GeolocationPosition

Object added along with setting helper methods. Added new setting
changed handlers for Position and Error.
(WebInspector.UserAgentSupport.GeolocationPosition):
(WebInspector.UserAgentSupport.GeolocationPosition.prototype.toSetting):
(WebInspector.UserAgentSupport.GeolocationPosition.parseSetting):
(WebInspector.UserAgentSupport.GeolocationPosition.parseUserInput):
(WebInspector.UserAgentSupport.prototype.get _onGeolocationErrorChanged):

LayoutTests:

Added new tests for Web Inspector overriding geolocation.

  • inspector/geolocation-error-expected.txt: Added.
  • inspector/geolocation-error.html: Added.
  • inspector/geolocation-success-expected.txt: Added.
  • inspector/geolocation-success.html: Added.
09:56 Changeset [122231] by commit-queue@webkit.org

DelayNode test should cover relate attribute
https://bugs.webkit.org/show_bug.cgi?id=90876

Patch by Li Yin <li.yin@intel.com> on 2012-07-10
Reviewed by Chris Rogers.

Let the test cover attributes of DelayNode.

  • webaudio/delaynode-expected.txt:
  • webaudio/delaynode.html:
09:37 Changeset [122230] by leandrogracia@chromium.org

Unreviewed Chromium build fix for mac-release.

Fixing clang build after https://bugs.webkit.org/show_bug.cgi?id=90807

  • public/WebSurroundingText.h:

(WebKit):

09:23 Changeset [122229] by vsevik@chromium.org

Web Inspector: Refactor resource revisions before moving to UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=90855

Reviewed by Pavel Feldman.

Revisions are now persisted based on mainFrame.loaderId, not resource.loaderId which makes filtering out stale persisted revisions easier.
Restoring revisions from local storage is separated from filtering out stale persisted revisions.
Resource._clearRevisionHistory and Resource._restoreRevisions are not static anymore.
Renamed localStorage field for persisting revisions: "resource-history" -> "revision-history"

  • inspector/front-end/Resource.js:

(WebInspector.Resource):
(WebInspector.Resource.prototype.addRevision):
(WebInspector.Resource.prototype._restoreRevisionHistory):
(WebInspector.Resource.prototype._clearRevisionHistory):
(WebInspector.Resource.prototype.revertAndClearHistory.clearHistory):
(WebInspector.Resource.prototype.revertAndClearHistory):
(WebInspector.Revision):
(WebInspector.Revision._revisionHistoryRegistry):
(WebInspector.Revision._ensureStaleRevisionsFileteredOut.persist):
(WebInspector.Revision._ensureStaleRevisionsFileteredOut):
(WebInspector.Revision.prototype._persist):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype._processCachedResources):
(WebInspector.ResourceTreeModel.prototype._addFramesRecursively):

  • inspector/front-end/RevisionHistoryView.js:
  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype._revisionAdded):

09:18 Changeset [122228] by commit-queue@webkit.org

Editing: Reproducible crasher when pasting a 0x0 image into Mail
https://bugs.webkit.org/show_bug.cgi?id=90640
<rdar://problem/11141920>

Patch by Alice Cheng <alice_cheng@apple.com> on 2012-07-10
Reviewed by Brady Eidson.

Source/WebCore:

0x0 images don't get a resource representation in the WebArchive, so we need a null check

Test: TestWebKitAPI/Tests/mac/0.png

TestWebKitAPI/Tests/mac/WebViewCanPasteZeroPng.mm

  • platform/mac/PasteboardMac.mm:

(WebCore::documentFragmentWithImageResource):

Tools:

Test cases for the patch. 0x0 images don't get a resource representation in the WebArchive, so we need a null check.

  • TestWebKitAPI/Tests/mac/0.png: Added.
  • TestWebKitAPI/Tests/mac/WebViewCanPasteZeroPng.mm: Added.

(TestWebKitAPI):
(TestWebKitAPI::TEST):

09:11 Changeset [122227] by commit-queue@webkit.org

Web Inspector: Make the Tab character 4 spaces width
https://bugs.webkit.org/show_bug.cgi?id=90172

Patch by Nikita Vasilyev <me@elv1s.ru> on 2012-07-10
Reviewed by Pavel Feldman.

Do it to match most code editors' behavior.

  • inspector/front-end/inspectorCommon.css:

(body):

09:09 Changeset [122226] by eric@webkit.org

REGRESSION (r122168): Layout Test http/tests/misc/script-defer.html is failing
https://bugs.webkit.org/show_bug.cgi?id=90845

Reviewed by Alexey Proskuryakov.

Source/WebCore:

I was a bit overzealous in removing bool returns. This one still makes sense.
This just reverts the wrong part of my previous change.

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd):

  • html/parser/HTMLScriptRunner.cpp:

(WebCore::HTMLScriptRunner::executeScriptsWaitingForParsing):

  • html/parser/HTMLScriptRunner.h:

(HTMLScriptRunner):

LayoutTests:

The test should no longer flake.

  • platform/chromium/TestExpectations:
  • platform/qt/Skipped:
09:01 Changeset [122225] by leandrogracia@chromium.org

WebSurroundingText layout tests should use the same code path as the rest of the feature.
https://bugs.webkit.org/show_bug.cgi?id=90807

Reviewed by Adam Barth.

Source/WebKit/chromium:

Replace the offset-based initialize method used only by LayoutTestController
with a point-based version to follow the same code path.

  • public/WebSurroundingText.h:

(WebKit):
(WebSurroundingText):

  • src/WebSurroundingText.cpp:

(WebKit::WebSurroundingText::initialize):

Tools:

Make the textSurroundingNode method take a pair of point coordinates
instead of a node offset.

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::textSurroundingNode):

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController):

LayoutTests:

Make the textSurroundingNode method take a pair of point coordinates
instead of a node offset.

  • platform/chromium/editing/surrounding-text/surrounding-text-expected.txt:
  • platform/chromium/editing/surrounding-text/surrounding-text.html:
08:51 Changeset [122224] by commit-queue@webkit.org

Input type=range issue with events not being raised when value set in js
https://bugs.webkit.org/show_bug.cgi?id=84674

Source/WebCore:

Fix dispatching of change and click events for the input slider.
Prior to the fix, change events were not fired if the new value
matched the value at last change notification based on expected
behavior for text fields. Clicks were not fired if the thumb
element was repositioned under the cursor on mouse down.

Patch by Kevin Ellis <kevers@chromium.org> on 2012-07-10
Reviewed by Kent Tamura.

Tests: fast/events/click-range-slider.html

fast/events/onchange-range-slider.html

  • html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::setPositionFromPoint):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseReleaseEvent):

LayoutTests:

Ensure that click and change events are properly triggered for range
sliders. Prior to the fix, change events were not fired if the new
value matched the value at last change notification based on expected
behavior for text fields. Clicks were not fired if the thumb element
was positioned under the cursor on mouse down.

Patch by Kevin Ellis <kevers@chromium.org> on 2012-07-10
Reviewed by Kent Tamura.

  • fast/events/click-range-slider-expected.txt: Added.
  • fast/events/click-range-slider.html: Added.
  • fast/events/onchange-range-slider-expected.txt: Added.
  • fast/events/onchange-range-slider.html: Added.
08:30 Changeset [122223] by carlosgc@webkit.org

[GTK] Add API to clear the cache to WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=90856

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkit_web_context_clear_cache): Call
WKResourceCacheManagerClearCacheForAllOrigins() to clear all
resources currently cached.

  • UIProcess/API/gtk/WebKitWebContext.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.
07:25 Changeset [122222] by zandobersek@gmail.com

Unreviewed GTK gardening, adding a text expectation for the
fast/js/global-constructors.html test. The test is failing because
of the in-progress removal of vendor prefix from DOM MutationObservers.

  • platform/gtk/TestExpectations:
07:10 Changeset [122221] by ossy@webkit.org

[Qt] Unreviewed gardening, remove unnecessary expectations.

  • platform/qt-mac/fast/block/float/float-not-removed-from-next-sibling-expected.txt: Removed.
  • platform/qt-mac/fast/block/float/float-not-removed-from-next-sibling2-expected.txt: Removed.
  • platform/qt-mac/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Removed.
  • platform/qt-mac/fast/block/float/float-not-removed-from-next-sibling4-expected.txt: Removed.
  • platform/qt-mac/plugins/mouse-click-plugin-clears-selection-expected.txt: Removed.
  • platform/qt-mac/transforms/svg-vs-css-expected.txt: Removed.
  • platform/qt-win/Skipped:
  • platform/qt-win/fast/events/panScroll-click-hyperlink-expected.txt: Removed.
  • platform/qt/fast/css/first-line-text-decoration-expected.png: Renamed from LayoutTests/platform/qt-linux/fast/css/first-line-text-decoration-expected.png.
  • platform/qt/fast/css/first-line-text-decoration-expected.txt: Renamed from LayoutTests/platform/qt-linux/fast/css/first-line-text-decoration-expected.txt.
  • platform/qt/fast/css/first-line-text-decoration-inherited-from-parent-expected.png: Renamed from LayoutTests/platform/qt-linux/fast/css/first-line-text-decoration-inherited-from-parent-expected.png.
  • platform/qt/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt: Renamed from LayoutTests/platform/qt-linux/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt.
06:50 WebKitGTK/WebKit2Roadmap edited by carlosgc@webkit.org
(diff)
06:31 Changeset [122220] by peter@chromium.org

Unreviewed, rolling out r122207.
http://trac.webkit.org/changeset/122207
https://bugs.webkit.org/show_bug.cgi?id=90874

Broke the cr-windows bot (Requested by beverloo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-10

  • DEPS:
06:22 Changeset [122219] by ossy@webkit.org

[Qt] REGRESSION(r122175): It broke the Windows build
https://bugs.webkit.org/show_bug.cgi?id=90850

Reviewed by Noam Rosenthal.

  • qmake/mkspecs/features/features.prf: Disable USE(3D_GRAPHICS) on Windows temporarily until proper fix.
06:21 Changeset [122218] by ossy@webkit.org

[Qt][ARM] Unreviewed gardening, skip failing/crashing tests to try to make the bot green.

  • platform/qt-arm/TestExpectations:
06:05 Changeset [122217] by ossy@webkit.org

[Qt][NRWT] Enable cascaded TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=89108

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-07-10
Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort.expectations_files):

  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:

(QtPortTest._assert_expectations_files):
(QtPortTest.test_expectations_files):

06:05 WebKitEFLLayoutTest edited by ryuan.choi@samsung.com
Add information about how to run WebKitTestRunner for WebKit2/Efl. (diff)
05:23 Changeset [122216] by caseq@chromium.org

Web Inspector: [Extensions API] simplify panel size check in extensions-panel.html
https://bugs.webkit.org/show_bug.cgi?id=90799

Reviewed by Vsevolod Vlasov.

  • use window argument in Panel.onShown() to check panel window size;
  • http/tests/inspector/resources/extension-panel.html:
  • inspector/extensions/extensions-panel-expected.txt:
  • inspector/extensions/extensions-panel.html:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/wincairo/Skipped:
05:10 Changeset [122215] by kseo@webkit.org

Don't destroy the decoded data of an image if WebKit is about to render the image.
https://bugs.webkit.org/show_bug.cgi?id=90721

Patch by Huang Dongsung <luxtella@company100.net> on 2012-07-10
Reviewed by Antti Koivisto.

When the cache capacity of the MemoryCache is exceeded, the decoded data of all
the CachedImages are destroyed. Even the images inside the viewport are
destroyed. However, if the images need to be rendered again due to scoll events
or animation, they must be decoded again. As an extreme case, if there is an
animation with an image when MemoryCache is almost full, the image must be
decoded every frame. This slows down animation and needlessly consumes CPU
cycles.

Therefore, it is better to not destory the decoded data of an image if the image
is inside the viewport because there is high chance that the image needs to be
rendered again soon. This patch reduces the unnecessary repetition of image decoding
on low memory, and also relieves the memory fragmentation because it avoids reallocation
of image frames.

In addition, there is another positive side effect. Currently,
CachedImageClient::willRenderImage() is used only to determine if GIF animation needs
to be paused or not in CachedImage::shouldPauseAnimation(). This patch makes
GIF animation outside the viewort be paused.

This is also a prerequisite for parallel image decoders. Because parallel image
decoders decode an image asynchronously, clients cannot render the image at the time
when the request is made. Clients can draw the image later after receiving image
decoding complete notification. However, there is a problem because MemoryCache can
destroy the decoded data before clients actually render the image. So parallel image decoders
must prevent the decoded data from being destroyed if the image will be rendered
soon.

This patch may consume a little more memory, but furtunately the peak memory usage
is almost the same.

No new tests - no new testable functionality.

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::likelyToBeUsedSoon):
(WebCore):
(WebCore::CachedImage::shouldPauseAnimation):

  • loader/cache/CachedImage.h:

(CachedImage):

  • loader/cache/CachedResource.h:

(CachedResource):
(WebCore::CachedResource::likelyToBeUsedSoon):

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::pruneLiveResourcesToSize):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::willRenderImage):

05:06 Changeset [122214] by kkristof@inf.u-szeged.hu

[Qt] Unreviewed gardening. Skip a flakey test after r122168.
https://bugs.webkit.org/show_bug.cgi?id=90845.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-07-10

  • platform/qt/Skipped:
05:02 Changeset [122213] by commit-queue@webkit.org

[EFL] WebKit DRT and WTR fail to build due to undefined reference to WTF::MD5::*
https://bugs.webkit.org/show_bug.cgi?id=90868

Unreviewed EFL build fix.

Correct CMake configuration to have EFL's DRT and WebKitTestRunner link
WTF library. This is needed to resolve undefined reference to WTF::MD5::*.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-10

  • DumpRenderTree/efl/CMakeLists.txt:
  • WebKitTestRunner/PlatformEfl.cmake:
04:19 Changeset [122212] by tkent@chromium.org

RTL calendar picker for <input type=date> is too narrow and clipped
https://bugs.webkit.org/show_bug.cgi?id=90864

Reviewed by Kentaro Hara.

.:

  • ManualTests/forms/calendar-picker.html:
  • Add isRTL:true for the arabic setting
  • Reset the iframe size when the setting is changed.

Source/WebCore:

Tests: ManualTests/forms/calendar-picker.html

  • Resources/calendarPicker.js:

(fixWindowSize):
Checks the left edge of elemenets in RTL.
(layout): Add dir=ltr for the manual test, which re-uses the document.

03:49 Changeset [122211] by ossy@webkit.org

Re-enable declspec(dl{import,export}) for MinGW when using EXPORT_MACROS
https://bugs.webkit.org/show_bug.cgi?id=90612

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2012-07-10
Reviewed by Csaba Osztrogonác.

MinGW was switched to use auto import/export of symbols on r44184.
From my understanding of the documentation, MinGW will not auto-export symbols
unless there are no explicit declspec(dlexport) in the DLL already.

The issues that originally made us rely on the auto-import feature of MinGW
should now be resolved with the EXPORT_MACROS work. This patch re-enables them.

It also removes the GCC check for internal symbols hiding as the visibility should
already be hidden by default for both MSVC and GCC on Windows anyway.

  • wtf/ExportMacros.h:
03:20 Changeset [122210] by ossy@webkit.org

Unreviewed gardening after r122204.

  • fast/viewport/viewport-legacy-xhtmlmp-expected.txt:
03:19 Changeset [122209] by hayato@chromium.org

Unreviewed gardening
Rebaseline.

  • platform/chromium-linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
02:36 Changeset [122208] by ossy@webkit.org

REGRESSION(r122166): It made 170 tests crash on 32 bit platforms
https://bugs.webkit.org/show_bug.cgi?id=90852

Patch by Filip Pizlo <fpizlo@apple.com> on 2012-07-10
Reviewed by Zoltan Herczeg.

If we can't use the range filter, we should still make sure that the
address is remotely sane, otherwise the hashtables will assert.

  • jit/JITStubRoutine.h:

(JSC::JITStubRoutine::passesFilter):

02:32 Changeset [122207] by jochen@chromium.org

Unreviewed. Rolled DEPS.

  • DEPS:
02:18 Changeset [122206] by fpizlo@apple.com

DFG recompilation heuristics should be based on count, not rate
https://bugs.webkit.org/show_bug.cgi?id=90146

Reviewed by Oliver Hunt.

Rolling r121511 back in after fixing the DFG's interpretation of op_div
profiling, with Gavin's rubber stamp.

This removes a bunch of code that was previously trying to prevent spurious
reoptimizations if a large enough majority of executions of a code block did
not result in OSR exit. It turns out that this code was purely harmful. This
patch removes all of that logic and replaces it with a dead-simple
heuristic: if you exit more than N times (where N is an exponential function
of the number of times the code block has already been recompiled) then we
will recompile.

This appears to be a broad ~1% win on many benchmarks large and small.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::couldTakeSpecialFastCase):
(CodeBlock):
(JSC::CodeBlock::osrExitCounter):
(JSC::CodeBlock::countOSRExit):
(JSC::CodeBlock::addressOfOSRExitCounter):
(JSC::CodeBlock::offsetOfOSRExitCounter):
(JSC::CodeBlock::adjustedExitCountThreshold):
(JSC::CodeBlock::exitCountThresholdForReoptimization):
(JSC::CodeBlock::exitCountThresholdForReoptimizationFromLoop):
(JSC::CodeBlock::shouldReoptimizeNow):
(JSC::CodeBlock::shouldReoptimizeFromLoopNow):

  • bytecode/ExecutionCounter.cpp:

(JSC::ExecutionCounter::setThreshold):

  • bytecode/ExecutionCounter.h:

(ExecutionCounter):
(JSC::ExecutionCounter::clippedThreshold):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::makeDivSafe):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileBody):

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::considerAddingAsFrequentExitSiteSlow):

  • dfg/DFGOSRExitCompiler.cpp:

(JSC::DFG::OSRExitCompiler::handleExitCounts):

  • dfg/DFGOperations.cpp:
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Options.h:

(JSC):

01:46 Changeset [122205] by ossy@webkit.org

Unreviewed, rolling out r122178.
http://trac.webkit.org/changeset/122178
https://bugs.webkit.org/show_bug.cgi?id=90857

browser tests, PrerenderBrowserTest.PrerenderFavicon and other
tests, started to fail (Requested by hayato on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-10

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

  • WebCore.exp.in:
  • dom/Document.cpp:

(WebCore::Document::iconURLs):
(WebCore::Document::addIconURL):
(WebCore::Document::setUseSecureKeyboardEntryWhenActive):

  • dom/Document.h:

(Document):

  • html/HTMLLinkElement.cpp:
  • html/HTMLLinkElement.h:

(HTMLLinkElement):

  • testing/Internals.cpp:
  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit2:

  • win/WebKit2.def:

LayoutTests:

  • fast/dom/icon-url-change-expected.txt: Removed.
  • fast/dom/icon-url-change.html: Removed.
  • fast/dom/icon-url-list-expected.txt: Removed.
  • fast/dom/icon-url-list.html: Removed.
  • fast/dom/icon-url-property-expected.txt:
  • fast/dom/icon-url-property.html:
  • platform/chromium/TestExpectations:
00:55 Changeset [122204] by abarth@webkit.org

LayoutTestController.dumpConfigurationForViewport should move to Internals
https://bugs.webkit.org/show_bug.cgi?id=45652

Reviewed by Eric Seidel.

Source/WebCore:

This patch replaces LayoutTestController.dumpConfigurationForViewport
with Internals.configurationForViewport. The old
dumpConfigurationForViewport function just ended up calling WebCore
functions anyway, so there's no benefit in implementing the API in the
LayoutTestController.

As a result, these tests can now run on every port.

  • testing/Internals.cpp:

(WebCore::Internals::configurationForViewport):
(WebCore):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit/blackberry:

  • WebKitSupport/DumpRenderTreeSupport.cpp:
  • WebKitSupport/DumpRenderTreeSupport.h:

(DumpRenderTreeSupport):

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Tools:

Remove dumpConfigurationForViewport from LayoutTestController. This API
has been replaced by an API on Internals that does the same thing in a
port-agnostic way.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  • DumpRenderTree/qt/LayoutTestControllerQt.h:

(LayoutTestController):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

LayoutTests:

Update these tests to use the Internals API rather than the
LayoutTestController API. This changed the output format of the tests
slightly because the LayoutTestController API printed directly to
stdout whereas the new API just returns a string that we pipe to stdout
using alert.

This patch also cleans up some platform-specific results for these
tests that had drifted out of sync a bit. The patch also correctly
marks the legacy tests as failing on GTK instead of checking in bogus
expected results for them.

This patch unskips these tests on Chromium. Once this patch lands, I'll
go through an unskip them on the other ports as well.

  • fast/viewport/viewport-1-expected.txt:
  • fast/viewport/viewport-1.html:
  • fast/viewport/viewport-10-expected.txt:
  • fast/viewport/viewport-10.html:
  • fast/viewport/viewport-100-expected.txt:
  • fast/viewport/viewport-100.html:
  • fast/viewport/viewport-101-expected.txt:
  • fast/viewport/viewport-101.html:
  • fast/viewport/viewport-102-expected.txt:
  • fast/viewport/viewport-102.html:
  • fast/viewport/viewport-103-expected.txt:
  • fast/viewport/viewport-103.html:
  • fast/viewport/viewport-104-expected.txt:
  • fast/viewport/viewport-104.html:
  • fast/viewport/viewport-105-expected.txt:
  • fast/viewport/viewport-105.html:
  • fast/viewport/viewport-106-expected.txt:
  • fast/viewport/viewport-106.html:
  • fast/viewport/viewport-107-expected.txt:
  • fast/viewport/viewport-107.html:
  • fast/viewport/viewport-108-expected.txt:
  • fast/viewport/viewport-108.html:
  • fast/viewport/viewport-109-expected.txt:
  • fast/viewport/viewport-109.html:
  • fast/viewport/viewport-11-expected.txt:
  • fast/viewport/viewport-11.html:
  • fast/viewport/viewport-110-expected.txt:
  • fast/viewport/viewport-110.html:
  • fast/viewport/viewport-111-expected.txt:
  • fast/viewport/viewport-111.html:
  • fast/viewport/viewport-112-expected.txt:
  • fast/viewport/viewport-112.html:
  • fast/viewport/viewport-113-expected.txt:
  • fast/viewport/viewport-113.html:
  • fast/viewport/viewport-114-expected.txt:
  • fast/viewport/viewport-114.html:
  • fast/viewport/viewport-115-expected.txt:
  • fast/viewport/viewport-115.html:
  • fast/viewport/viewport-116-expected.txt:
  • fast/viewport/viewport-116.html:
  • fast/viewport/viewport-117-expected.txt:
  • fast/viewport/viewport-117.html:
  • fast/viewport/viewport-118-expected.txt:
  • fast/viewport/viewport-118.html:
  • fast/viewport/viewport-119-expected.txt:
  • fast/viewport/viewport-119.html:
  • fast/viewport/viewport-12-expected.txt:
  • fast/viewport/viewport-12.html:
  • fast/viewport/viewport-120-expected.txt:
  • fast/viewport/viewport-120.html:
  • fast/viewport/viewport-121-expected.txt:
  • fast/viewport/viewport-121.html:
  • fast/viewport/viewport-122-expected.txt:
  • fast/viewport/viewport-122.html:
  • fast/viewport/viewport-123-expected.txt:
  • fast/viewport/viewport-123.html:
  • fast/viewport/viewport-124-expected.txt:
  • fast/viewport/viewport-124.html:
  • fast/viewport/viewport-125-expected.txt:
  • fast/viewport/viewport-125.html:
  • fast/viewport/viewport-126-expected.txt: Renamed from LayoutTests/platform/gtk/fast/viewport/viewport-126-expected.txt.
  • fast/viewport/viewport-126.html:
  • fast/viewport/viewport-127-expected.txt: Renamed from LayoutTests/platform/gtk/fast/viewport/viewport-127-expected.txt.
  • fast/viewport/viewport-127.html:
  • fast/viewport/viewport-128-expected.txt:
  • fast/viewport/viewport-128.html:
  • fast/viewport/viewport-129-expected.txt:
  • fast/viewport/viewport-129.html:
  • fast/viewport/viewport-13-expected.txt:
  • fast/viewport/viewport-13.html:
  • fast/viewport/viewport-130-expected.txt:
  • fast/viewport/viewport-130.html:
  • fast/viewport/viewport-131-expected.txt:
  • fast/viewport/viewport-131.html:
  • fast/viewport/viewport-132-expected.txt:
  • fast/viewport/viewport-132.html:
  • fast/viewport/viewport-14-expected.txt:
  • fast/viewport/viewport-14.html:
  • fast/viewport/viewport-15-expected.txt:
  • fast/viewport/viewport-15.html:
  • fast/viewport/viewport-16-expected.txt:
  • fast/viewport/viewport-16.html:
  • fast/viewport/viewport-17-expected.txt:
  • fast/viewport/viewport-17.html:
  • fast/viewport/viewport-18-expected.txt:
  • fast/viewport/viewport-18.html:
  • fast/viewport/viewport-19-expected.txt:
  • fast/viewport/viewport-19.html:
  • fast/viewport/viewport-2-expected.txt:
  • fast/viewport/viewport-2.html:
  • fast/viewport/viewport-20-expected.txt:
  • fast/viewport/viewport-20.html:
  • fast/viewport/viewport-21-expected.txt:
  • fast/viewport/viewport-21.html:
  • fast/viewport/viewport-22-expected.txt:
  • fast/viewport/viewport-22.html:
  • fast/viewport/viewport-23-expected.txt:
  • fast/viewport/viewport-23.html:
  • fast/viewport/viewport-24-expected.txt:
  • fast/viewport/viewport-24.html:
  • fast/viewport/viewport-25-expected.txt:
  • fast/viewport/viewport-25.html:
  • fast/viewport/viewport-26-expected.txt:
  • fast/viewport/viewport-26.html:
  • fast/viewport/viewport-27-expected.txt:
  • fast/viewport/viewport-27.html:
  • fast/viewport/viewport-28-expected.txt:
  • fast/viewport/viewport-28.html:
  • fast/viewport/viewport-29-expected.txt:
  • fast/viewport/viewport-29.html:
  • fast/viewport/viewport-3-expected.txt:
  • fast/viewport/viewport-3.html:
  • fast/viewport/viewport-30-expected.txt:
  • fast/viewport/viewport-30.html:
  • fast/viewport/viewport-31-expected.txt:
  • fast/viewport/viewport-31.html:
  • fast/viewport/viewport-32-expected.txt:
  • fast/viewport/viewport-32.html:
  • fast/viewport/viewport-33-expected.txt:
  • fast/viewport/viewport-33.html:
  • fast/viewport/viewport-34-expected.txt:
  • fast/viewport/viewport-34.html:
  • fast/viewport/viewport-35-expected.txt:
  • fast/viewport/viewport-35.html:
  • fast/viewport/viewport-36-expected.txt:
  • fast/viewport/viewport-36.html:
  • fast/viewport/viewport-37-expected.txt:
  • fast/viewport/viewport-37.html:
  • fast/viewport/viewport-38-expected.txt:
  • fast/viewport/viewport-38.html:
  • fast/viewport/viewport-39-expected.txt:
  • fast/viewport/viewport-39.html:
  • fast/viewport/viewport-4-expected.txt:
  • fast/viewport/viewport-4.html:
  • fast/viewport/viewport-40-expected.txt:
  • fast/viewport/viewport-40.html:
  • fast/viewport/viewport-41-expected.txt:
  • fast/viewport/viewport-41.html:
  • fast/viewport/viewport-42-expected.txt:
  • fast/viewport/viewport-42.html:
  • fast/viewport/viewport-43-expected.txt:
  • fast/viewport/viewport-43.html:
  • fast/viewport/viewport-44-expected.txt:
  • fast/viewport/viewport-44.html:
  • fast/viewport/viewport-45-expected.txt:
  • fast/viewport/viewport-45.html:
  • fast/viewport/viewport-46-expected.txt:
  • fast/viewport/viewport-46.html:
  • fast/viewport/viewport-47-expected.txt:
  • fast/viewport/viewport-47.html:
  • fast/viewport/viewport-48-expected.txt:
  • fast/viewport/viewport-48.html:
  • fast/viewport/viewport-49-expected.txt:
  • fast/viewport/viewport-49.html:
  • fast/viewport/viewport-5-expected.txt:
  • fast/viewport/viewport-5.html:
  • fast/viewport/viewport-50-expected.txt:
  • fast/viewport/viewport-50.html:
  • fast/viewport/viewport-51-expected.txt:
  • fast/viewport/viewport-51.html:
  • fast/viewport/viewport-52-expected.txt:
  • fast/viewport/viewport-52.html:
  • fast/viewport/viewport-53-expected.txt:
  • fast/viewport/viewport-53.html:
  • fast/viewport/viewport-54-expected.txt:
  • fast/viewport/viewport-54.html:
  • fast/viewport/viewport-55-expected.txt:
  • fast/viewport/viewport-55.html:
  • fast/viewport/viewport-56-expected.txt:
  • fast/viewport/viewport-56.html:
  • fast/viewport/viewport-57-expected.txt:
  • fast/viewport/viewport-57.html:
  • fast/viewport/viewport-58-expected.txt:
  • fast/viewport/viewport-58.html:
  • fast/viewport/viewport-59-expected.txt:
  • fast/viewport/viewport-59.html:
  • fast/viewport/viewport-6-expected.txt:
  • fast/viewport/viewport-6.html:
  • fast/viewport/viewport-60-expected.txt:
  • fast/viewport/viewport-60.html:
  • fast/viewport/viewport-61-expected.txt:
  • fast/viewport/viewport-61.html:
  • fast/viewport/viewport-62-expected.txt:
  • fast/viewport/viewport-62.html:
  • fast/viewport/viewport-63-expected.txt:
  • fast/viewport/viewport-63.html:
  • fast/viewport/viewport-64-expected.txt:
  • fast/viewport/viewport-64.html:
  • fast/viewport/viewport-65-expected.txt: Renamed from LayoutTests/platform/gtk/fast/viewport/viewport-65-expected.txt.
  • fast/viewport/viewport-65.html:
  • fast/viewport/viewport-66-expected.txt:
  • fast/viewport/viewport-66.html:
  • fast/viewport/viewport-67-expected.txt:
  • fast/viewport/viewport-67.html:
  • fast/viewport/viewport-68-expected.txt:
  • fast/viewport/viewport-68.html:
  • fast/viewport/viewport-69-expected.txt:
  • fast/viewport/viewport-69.html:
  • fast/viewport/viewport-7-expected.txt:
  • fast/viewport/viewport-7.html:
  • fast/viewport/viewport-70-expected.txt:
  • fast/viewport/viewport-70.html:
  • fast/viewport/viewport-71-expected.txt:
  • fast/viewport/viewport-71.html:
  • fast/viewport/viewport-72-expected.txt:
  • fast/viewport/viewport-72.html:
  • fast/viewport/viewport-73-expected.txt:
  • fast/viewport/viewport-73.html:
  • fast/viewport/viewport-74-expected.txt:
  • fast/viewport/viewport-74.html:
  • fast/viewport/viewport-75-expected.txt:
  • fast/viewport/viewport-75.html:
  • fast/viewport/viewport-76-expected.txt:
  • fast/viewport/viewport-76.html:
  • fast/viewport/viewport-77-expected.txt:
  • fast/viewport/viewport-77.html:
  • fast/viewport/viewport-78-expected.txt:
  • fast/viewport/viewport-78.html:
  • fast/viewport/viewport-79-expected.txt:
  • fast/viewport/viewport-79.html:
  • fast/viewport/viewport-8-expected.txt:
  • fast/viewport/viewport-8.html:
  • fast/viewport/viewport-80-expected.txt:
  • fast/viewport/viewport-80.html:
  • fast/viewport/viewport-81-expected.txt:
  • fast/viewport/viewport-81.html:
  • fast/viewport/viewport-82-expected.txt: Renamed from LayoutTests/platform/gtk/fast/viewport/viewport-82-expected.txt.
  • fast/viewport/viewport-82.html:
  • fast/viewport/viewport-83-expected.txt:
  • fast/viewport/viewport-83.html:
  • fast/viewport/viewport-84-expected.txt: Renamed from LayoutTests/platform/efl/fast/viewport/viewport-87-expected.txt.
  • fast/viewport/viewport-84.html:
  • fast/viewport/viewport-85-expected.txt:
  • fast/viewport/viewport-85.html:
  • fast/viewport/viewport-86-expected.txt:
  • fast/viewport/viewport-86.html:
  • fast/viewport/viewport-87-expected.txt: Renamed from LayoutTests/platform/gtk/fast/viewport/viewport-87-expected.txt.
  • fast/viewport/viewport-87.html:
  • fast/viewport/viewport-88-expected.txt:
  • fast/viewport/viewport-88.html:
  • fast/viewport/viewport-9-expected.txt:
  • fast/viewport/viewport-9.html:
  • fast/viewport/viewport-90-expected.txt:
  • fast/viewport/viewport-90.html:
  • fast/viewport/viewport-91-expected.txt:
  • fast/viewport/viewport-91.html:
  • fast/viewport/viewport-legacy-handheldfriendly-expected.txt:
  • fast/viewport/viewport-legacy-handheldfriendly.html:
  • fast/viewport/viewport-legacy-mobileoptimized-2-expected.txt:
  • fast/viewport/viewport-legacy-mobileoptimized-2.html:
  • fast/viewport/viewport-legacy-mobileoptimized-3-expected.txt:
  • fast/viewport/viewport-legacy-mobileoptimized-3.html:
  • fast/viewport/viewport-legacy-mobileoptimized-expected.txt:
  • fast/viewport/viewport-legacy-mobileoptimized.html:
  • fast/viewport/viewport-legacy-ordering-1-expected.txt:
  • fast/viewport/viewport-legacy-ordering-1.html:
  • fast/viewport/viewport-legacy-ordering-2-expected.txt:
  • fast/viewport/viewport-legacy-ordering-2.html:
  • fast/viewport/viewport-legacy-ordering-3-expected.txt:
  • fast/viewport/viewport-legacy-ordering-3.html:
  • fast/viewport/viewport-legacy-ordering-4-expected.txt:
  • fast/viewport/viewport-legacy-ordering-4.html:
  • fast/viewport/viewport-legacy-ordering-5-expected.txt:
  • fast/viewport/viewport-legacy-ordering-5.html:
  • fast/viewport/viewport-legacy-ordering-6-expected.txt:
  • fast/viewport/viewport-legacy-ordering-6.html:
  • fast/viewport/viewport-legacy-ordering-7-expected.txt:
  • fast/viewport/viewport-legacy-ordering-7.html:
  • fast/viewport/viewport-legacy-ordering-8-expected.txt:
  • fast/viewport/viewport-legacy-ordering-8.html:
  • fast/viewport/viewport-legacy-ordering-9-expected.txt:
  • fast/viewport/viewport-legacy-ordering-9.html:
  • fast/viewport/viewport-legacy-xhtmlmp-misplaced-doctype-expected.txt:
  • fast/viewport/viewport-legacy-xhtmlmp-misplaced-doctype.html:
  • fast/viewport/viewport-legacy-xhtmlmp-ordering-expected.txt:
  • fast/viewport/viewport-legacy-xhtmlmp-ordering.html:
  • fast/viewport/viewport-legacy-xhtmlmp.html:
  • fast/viewport/viewport-warnings-1-expected.txt:
  • fast/viewport/viewport-warnings-1.html:
  • fast/viewport/viewport-warnings-2-expected.txt:
  • fast/viewport/viewport-warnings-2.html:
  • fast/viewport/viewport-warnings-3-expected.txt:
  • fast/viewport/viewport-warnings-3.html:
  • fast/viewport/viewport-warnings-4-expected.txt:
  • fast/viewport/viewport-warnings-4.html:
  • fast/viewport/viewport-warnings-5-expected.txt:
  • fast/viewport/viewport-warnings-5.html:
  • fast/viewport/viewport-warnings-6-expected.txt:
  • fast/viewport/viewport-warnings-6.html:
  • platform/chromium/TestExpectations:
  • platform/efl/fast/viewport/viewport-126-expected.txt: Removed.
  • platform/efl/fast/viewport/viewport-127-expected.txt: Removed.
  • platform/efl/fast/viewport/viewport-65-expected.txt: Removed.
  • platform/efl/fast/viewport/viewport-82-expected.txt: Removed.
  • platform/efl/fast/viewport/viewport-84-expected.txt: Removed.
  • platform/gtk/TestExpectations:
  • platform/gtk/fast/viewport/viewport-84-expected.txt: Removed.
  • platform/gtk/fast/viewport/viewport-legacy-handheldfriendly-expected.txt: Removed.
  • platform/gtk/fast/viewport/viewport-legacy-mobileoptimized-2-expected.txt: Removed.
  • platform/gtk/fast/viewport/viewport-legacy-mobileoptimized-3-expected.txt: Removed.
  • platform/gtk/fast/viewport/viewport-legacy-mobileoptimized-expected.txt: Removed.
  • platform/gtk/fast/viewport/viewport-legacy-ordering-5-expected.txt: Removed.
  • platform/gtk/fast/viewport/viewport-legacy-ordering-6-expected.txt: Removed.
00:49 Changeset [122203] by ossy@webkit.org

[Qt] Skipped a new failing test, because of a missing feature
(testRunner.setStorageDatabaseIdleInterval()).

Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-07-10
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
00:43 Changeset [122202] by carlosgc@webkit.org

Unreviewed. Fix GTK+ build after r122175.

  • platform/graphics/texmap/TextureMapperLayer.cpp: Include

CString.h when using cairo.

00:38 Changeset [122201] by yosin@chromium.org

[Chromium-Mac] Form related layout tests cause timeout
https://bugs.webkit.org/show_bug.cgi?id=90851

Reviewed by Kent Tamura.

This patch changed to pass a valid argument to LocaleMac
constructor.

No new tests. No more timeout in tests listed in the bug.

  • platform/text/mac/LocaleMac.mm:

(WebCore::LocaleMac::currentLocale): Changed to pass local identifier string
instead of NSLocale object.

00:31 Changeset [122200] by pfeldman@chromium.org

Merge 121859 - Web Inspector: fix search on the network panel.
https://bugs.webkit.org/show_bug.cgi?id=90557

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._highlightNthMatchedRequest):

TBR=pfeldman@chromium.org
BUG=136019
Review URL: https://chromiumcodereview.appspot.com/10689130

00:31 Changeset [122199] by abarth@webkit.org

WebSocket: Remove hixie76 protocol implementation
https://bugs.webkit.org/show_bug.cgi?id=88620

Patch by Yuta Kitamura <yutak@chromium.org> on 2012-07-10
Reviewed by Adam Barth.

Source/WebCore:

This change removes code that implements the old hixie-76 WebSocket protocol which
isn't used anymore.

No new tests are added, because the code using the current protocol should not be
affected. Tests for hixie-76 protocol are skipped (these tests will be removed
eventually).

  • Modules/websockets/ThreadableWebSocketChannel.h:
  • Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
(WebCore::ThreadableWebSocketChannelClientWrapper::didCreateWebSocketChannel):

  • Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:

(ThreadableWebSocketChannelClientWrapper):

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::WebSocket):
(WebCore::WebSocket::connect):
(WebCore::WebSocket::send):
(WebCore::WebSocket::protocol):
(WebCore::WebSocket::extensions):
(WebCore::WebSocket::binaryType):
(WebCore::WebSocket::setBinaryType):
(WebCore::WebSocket::didReceiveMessageError):
(WebCore::WebSocket::didClose):
(WebCore::WebSocket::getFramingOverhead):

  • Modules/websockets/WebSocket.h:
  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::WebSocketChannel):
(WebCore::WebSocketChannel::connect):
(WebCore::WebSocketChannel::send):
(WebCore::WebSocketChannel::fail):
(WebCore::WebSocketChannel::didCloseSocketStream):
(WebCore::WebSocketChannel::processBuffer):
(WebCore::WebSocketChannel::startClosingHandshake):
(WebCore::WebSocketChannel::enqueueTextFrame):
(WebCore::WebSocketChannel::enqueueRawFrame):
(WebCore::WebSocketChannel::enqueueBlobFrame):
(WebCore::WebSocketChannel::processOutgoingFrameQueue):
(WebCore::WebSocketChannel::abortOutgoingFrameQueue):

  • Modules/websockets/WebSocketChannel.h:

(WebSocketChannel):

  • Modules/websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::WebSocketHandshake):
(WebCore::WebSocketHandshake::clientHandshakeMessage):
(WebCore::WebSocketHandshake::clientHandshakeRequest):
(WebCore::WebSocketHandshake::readServerHandshake):
(WebCore::WebSocketHandshake::checkResponseHeaders):

  • Modules/websockets/WebSocketHandshake.h:
  • Modules/websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::WorkerContextDidInitializeTask::create):
(WebCore::WorkerThreadableWebSocketChannel::WorkerContextDidInitializeTask::WorkerContextDidInitializeTask):
(WorkerThreadableWebSocketChannel::WorkerContextDidInitializeTask):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadInitialize):

  • Modules/websockets/WorkerThreadableWebSocketChannel.h:

(WorkerThreadableWebSocketChannel):
(Peer):
(Bridge):

LayoutTests:

Skip tests under hixie76 directory in all ports, because hixie-76 protocol support is
being dropped. These tests will be removed later.

  • platform/chromium/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/Skipped:
  • platform/wk2/Skipped:
00:08 Changeset [122198] by barraclough@apple.com

Threadsafety issues in WebScriptObject
https://bugs.webkit.org/show_bug.cgi?id=90849

Reviewed by Filip Pizlo.

WebScriptObject maintains a NSMap of wrapper objects. A race condition exists
between a wrapper being retrieved from the map, and being released - if the
final release on an object is called between a call to getJSWrapper and the
subsequent retain, we may end up with a stale object reference.

We can make this safe by hoisting the removal from the map from delloc up into
release (if the retainCount is 1), and locking release against retrieval from
the map. Since release may be called from another thread, and NSMap is not
threadsafe, we'd better lock around all access to the map (this fix already
necessitates get & remove to be locked, so this just adds 'add', too).

  • bindings/objc/WebScriptObject.mm:

(WebCore::createJSWrapper):

  • lock around getJSWrapper, retain.

(-[WebScriptObject _setImp:originRootObject:rootObject:]):

  • lock around addJSWrapper.

(-[WebScriptObject release]):

  • Added; removeJSWrapper for last release, lock & synchronized vs. getJSWrapper.

(-[WebScriptObject dealloc]):

  • removeJSWrapper call hoisted into release.

07/09/12:

23:42 Changeset [122197] by commit-queue@webkit.org

[EFL] Battery status code needs refactoring to be reused in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=90760

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-09
Reviewed by Hajime Morita.

Source/WebCore:

Rename BatteryClientEfl to BatteryProviderEfl and remove dependency
on BatteryController by introducing the BatteryProviderEflClient
interface. This will allow reusing the BatteryProviderEfl class
in WebKit2.

No new tests. Already tested by batterystatus/*.

  • PlatformEfl.cmake:
  • platform/efl/BatteryProviderEfl.cpp: Renamed from Source/WebCore/platform/efl/BatteryClientEfl.cpp.

(WebCore):
(WebCore::BatteryProviderEfl::BatteryProviderEfl):
(WebCore::BatteryProviderEfl::batteryStatus):
(WebCore::BatteryProviderEfl::startUpdating):
(WebCore::BatteryProviderEfl::stopUpdating):
(WebCore::BatteryProviderEfl::setBatteryStatus):
(WebCore::BatteryProviderEfl::timerFired):
(WebCore::BatteryProviderEfl::getBatteryStatus):
(WebCore::BatteryProviderEfl::setBatteryClient):

  • platform/efl/BatteryProviderEfl.h: Copied from Source/WebCore/platform/efl/BatteryClientEfl.h.

(WebCore):
(BatteryProviderEfl):
(WebCore::BatteryProviderEfl::~BatteryProviderEfl):

  • platform/efl/BatteryProviderEflClient.h: Added.

(WebCore):
(BatteryProviderEflClient):

Source/WebKit:

Add BatteryClientEfl to PlatformEfl.cmake.

  • PlatformEfl.cmake:

Source/WebKit/efl:

Add BatteryClientEfl to WebKit, which uses BatteryProviderEfl from
WebCore internally.

  • WebCoreSupport/BatteryClientEfl.cpp: Added.

(BatteryClientEfl::BatteryClientEfl):
(BatteryClientEfl::setController):
(BatteryClientEfl::startUpdating):
(BatteryClientEfl::stopUpdating):
(BatteryClientEfl::batteryControllerDestroyed):
(BatteryClientEfl::didChangeBatteryStatus):

  • WebCoreSupport/BatteryClientEfl.h: Renamed from Source/WebCore/platform/efl/BatteryClientEfl.h.

(WebCore):
(BatteryClientEfl):
(BatteryClientEfl::~BatteryClientEfl):

  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):

23:37 WebKitIDL edited by toybabyyou@gmail.com
(diff)
23:34 Drosera edited by toybabyyou@gmail.com
(diff)
23:24 WebInspector edited by toybabyyou@gmail.com
(diff)
22:55 Changeset [122196] by hayato@chromium.org

Unreviewed gardening.
Fix a wrong fix of r122194.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::decideRenderPassAllocationsForFrame):

22:45 Changeset [122195] by commit-queue@webkit.org

Add ENABLE_DIALOG_ELEMENT and skeleton files
https://bugs.webkit.org/show_bug.cgi?id=90521

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-07-09
Reviewed by Kent Tamura.

.:

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

This adds the ENABLE_DIALOG_ELEMENT feature flag and dummy implementation files for <dialog>. In addition, a runtime feature flag is added.
The feature is diabled by default.

No new tests, as there is no behavior change.

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h: Added a runtime feature flag for dialog.

(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::dialogElementEnabled):
(WebCore::RuntimeEnabledFeatures::setDialogElementEnabled):

  • dom/ContextFeatures.cpp:

(WebCore::ContextFeatures::dialogElementEnabled):
(WebCore):

  • dom/ContextFeatures.h: Added a per-context flag for dialog so that dialog can be disabled in HTMLTagNames.in and DOMWindow.idl when the dialog runtime feature flag is off.
  • html/HTMLDialogElement.cpp: Added.

(WebCore):
(WebCore::HTMLDialogElement::HTMLDialogElement):
(WebCore::HTMLDialogElement::create):
(WebCore::HTMLDialogElement::close):
(WebCore::HTMLDialogElement::show):

  • html/HTMLDialogElement.h: Added.

(WebCore):
(HTMLDialogElement):

  • html/HTMLDialogElement.idl: Added.
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLTagNames.in:
  • page/DOMWindow.idl:

Source/WebKit/chromium:

  • features.gypi:
  • public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableDialogElement):
(WebKit):
(WebKit::WebRuntimeFeatures::isDialogElementEnabled):

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
22:22 Changeset [122194] by hayato@chromium.org

Unreviewed gardening.
Remove an assertion starting to fail on interactive_ui_tests on Chromium OS.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::decideRenderPassAllocationsForFrame):

21:56 Changeset [122193] by hayato@chromium.org

Unreviewed gardening.
Build fix after r122175

  • WebCore.gypi: Remove Source/WebCore/platform/graphics/qt/Extensions3DQt.{cpp,h}
21:35 Changeset [122192] by tkent@chromium.org

Improve the boilerplate generated by prepare-ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=89560

Reviewed by Ryosuke Niwa.

Produce the following boilerplate:

2012-06-20 Kent Tamura <tkent@chromium.org>

Need a short description (Oops!).
Need the bug URL (Oops!).

Reviewed by NOBODY (Oops!).

Additional information of the change such as approach, rationale. Please add per-function descriptions below. (Oops!).

No new tests (Oops!).

  • Scripts/prepare-ChangeLog:

(generateNewChangeLogs): Generate the updated template.

  • Scripts/webkitpy/common/checkout/changelog.py:

(ChangeLog.update_with_unreviewed_message):
Update the pattern for the beginning of the boilerplate.
(ChangeLog.set_short_description_and_bug_url):

  • Use self._changelog_indent
  • Update the pattern for the description line
  • Skip the bug boilerplate.

We substitute the specified bug URL to the description boilerplate
because we need to add it even if the bug URL boilerplate is missing.

  • Scripts/webkitpy/common/checkout/changelog_unittest.py: Update the boilerplate data.

(test_set_short_description_and_bug_url):

  • Update the description boilerplate.
  • Add a test for a case with both of the description boilerplace and the bug URL boilerplate.
  • Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:

(PrepareChangeLogTest.test_ensure_bug_url): Update the expected boilerplate.

21:34 Changeset [122191] by ddkilzer@apple.com

Improve performance of RenderInline::absoluteQuads for deeply nested inlines.
https://bugs.webkit.org/show_bug.cgi?id=90715

Patch by Kiran Muppala <cmuppala@apple.com> on 2012-07-09
Reviewed by Maciej Stachowiak.

No new tests: functionality unchanged.

  • rendering/RenderInline.cpp: Cache transformation from local to absolute coordinates using a

RenderGeometryMap and use it for subsequent mappings.
(WebCore::(anonymous namespace)::AbsoluteQuadsGeneratorContext::AbsoluteQuadsGeneratorContext):
(WebCore::(anonymous namespace)::AbsoluteQuadsGeneratorContext::operator()):

21:31 Changeset [122190] by yosin@chromium.org

[Chromium-Mac] Implement functions for localized time format information
https://bugs.webkit.org/show_bug.cgi?id=90237

Reviewed by Kent Tamura.

Source/WebCore:

This patch introduces following localized time format related
functions:

  • localizeTimeFormatText()
  • localizeShortTimeFormatText()
  • timeAMPMLabels

for Mac OSX in feature flag: ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

These function will be used by input type "time" with multiple input
fields UI.

Note: ICU version of localized time format functions are implemented
in https://bugs.webkit.org/show_bug.cgi?id=89965

Tests: WebKit/chromium/tests/LocaleMacTest.cpp

  • platform/text/mac/LocaleMac.h:

(LocaleMac): Added time format related functions and variables.

  • platform/text/mac/LocaleMac.mm:

(WebCore::createDateTimeFormatter): Added. A helper function for creating date time formatter.
(WebCore::LocaleMac::createShortDateFormatter): Changed to use createDateTimeFormatter.
(WebCore::LocaleMac::createTimeFormatter): Added.
(WebCore::LocaleMac::createShortTimeFormatter): Added.
(WebCore::LocaleMac::timeFormatText): Added.
(WebCore::LocaleMac::shortTimeFormatText): Added.
(WebCore::LocaleMac::timeAMPMLabels): Added.

Source/WebKit/chromium:

  • tests/LocaleMacTest.cpp:

(LocaleMacTest):
(LocaleMacTest::timeFormatText):
(LocaleMacTest::shortTimeFormatText):
(LocaleMacTest::timeAMPMLabel):
(TEST_F):

20:27 Changeset [122189] by achicu@adobe.com

[CSS Shaders] The FECustomFilter is not making the GL context active
https://bugs.webkit.org/show_bug.cgi?id=90840

Reviewed by Dean Jackson.

I've added a couple of makeContextCurrent() in the FECustomFilter related classes.
Also, removed the assumption that GraphicsContext3D::create() never returns 0.

No new tests, this was crashing on existing tests.

  • platform/graphics/filters/CustomFilterCompiledProgram.cpp:

(WebCore::CustomFilterCompiledProgram::CustomFilterCompiledProgram):
(WebCore::CustomFilterCompiledProgram::~CustomFilterCompiledProgram):

  • platform/graphics/filters/CustomFilterGlobalContext.cpp:

(WebCore::CustomFilterGlobalContext::prepareContextIfNeeded):

  • platform/graphics/filters/CustomFilterMesh.cpp:

(WebCore::CustomFilterMesh::CustomFilterMesh):
(WebCore::CustomFilterMesh::~CustomFilterMesh):

  • platform/graphics/filters/FECustomFilter.cpp:

(WebCore::FECustomFilter::deleteRenderBuffers):
(WebCore::FECustomFilter::platformApplySoftware):
(WebCore::FECustomFilter::initializeContext):

  • platform/graphics/filters/FECustomFilter.h:

(FECustomFilter):

20:18 Changeset [122188] by tkent@chromium.org

REGRESSION(r114862-r114886): Fix a crash by switching the input type to hidden.
https://bugs.webkit.org/show_bug.cgi?id=90774

Reviewed by Andreas Kling.

Source/WebCore:

Test: fast/forms/hidden/change-type-to-hidden-after-updating-value.html

  • dom/Element.cpp:

(WebCore::Element::setAttributeInternal):
Pass a copy of the existing Attribute object.

LayoutTests:

  • fast/forms/hidden/change-type-to-hidden-after-updating-value.html: Added.
  • fast/forms/hidden/change-type-to-hidden-after-updating-value-expected.txt: Added.
19:38 Changeset [122187] by philn@webkit.org

[GStreamer] cache video dimensions
https://bugs.webkit.org/show_bug.cgi?id=90733

Reviewed by Martin Robinson.

Invalidate the cached video dimensions whenever the video-sink sink pad caps
change and let ::naturalSize() lazily recalculate them.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::naturalSize):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideo):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(MediaPlayerPrivateGStreamer):

19:29 Changeset [122186] by hayato@chromium.org

Unreviewed gardening. Update TestExpectations.

  • platform/chromium/TestExpectations: http/tests/misc/script-defer.html started failing after r122168.
19:29 Changeset [122185] by commit-queue@webkit.org

[chromium] Merge updates and idle updates into one pass
https://bugs.webkit.org/show_bug.cgi?id=90324

Patch by Eric Penner <epenner@google.com> on 2012-07-09
Reviewed by Adrienne Walker.

Source/WebCore:

We no longer need to do painting is passes in order
to allocate memory in the right order. So this merges
updates and idle updates into one pass.

Covered by existing unit tests (some of which are
updated with this patch).

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::needMoreUpdates):

  • platform/graphics/chromium/ContentLayerChromium.h:

(ContentLayerChromium):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::needMoreUpdates):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::updateTiles):
(WebCore::TiledLayerChromium::updateLayerRect):

  • platform/graphics/chromium/TiledLayerChromium.h:

(TiledLayerChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::compositeAndReadback):
(WebCore::CCLayerTreeHost::updateLayers):
(WebCore::CCLayerTreeHost::paintMasksForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(WTF::ContentLayerChromiumWithUpdateTracking::resetPaintContentsCount):
(WTF::ContentLayerChromiumWithUpdateTracking::ContentLayerChromiumWithUpdateTracking):
(ContentLayerChromiumWithUpdateTracking):
(WTF::CCLayerTreeHostTestOpacityChange::afterTest):

  • tests/CCTiledLayerTestCommon.h:

(FakeTiledLayerChromium):

  • tests/TiledLayerChromiumTest.cpp:
19:16 Changeset [122184] by yosin@chromium.org

[Platform] Introduce LocaleMac class
https://bugs.webkit.org/show_bug.cgi?id=90248

Reviewed by Kent Tamura.

Source/WebCore:

This patch moves implementation of localized date format related
functions into LocaleMac class as of LocaleWin class for ease of
maintain and using specific locale in testing rather than system
default locale.

Tests: WebKit/chromium/tests/LocaleMacTest.cpp

  • WebCore.gyp/WebCore.gyp: Include LocaleMac.mm
  • WebCore.gypi:
  • platform/text/mac/LocaleMac.h: Replace LocaleWin to LocaleMac.
  • platform/text/mac/LocaleMac.mm:

(WebCore::LocaleMac::LocaleMac):
(WebCore::LocaleMac::~LocaleMac):
(WebCore::LocaleMac::create):
(WebCore::LocaleMac::currentLocale):
(WebCore::LocaleMac::createShortDateFormatter):
(WebCore::LocaleMac::parseDate):
(WebCore::LocaleMac::formatDate):
(WebCore::LocaleMac::dateFormatText):
(WebCore::LocaleMac::monthLabels):
(WebCore::LocaleMac::weekDayShortLabels):
(WebCore::LocaleMac::firstDayOfWeek):

  • platform/text/mac/LocalizedDateMac.cpp:

(WebCore::parseLocalizedDate):
(WebCore::formatLocalizedDate):
(WebCore::localizedDateFormatText):
(WebCore::monthLabels):
(WebCore::weekDayShortLabels):
(WebCore::firstDayOfWeek):

  • platform/text/mac/LocalizedDateMac.mm: Removed.

Source/WebKit/chromium:

This patch added tests for LocaleMac class.

  • WebKit.gypi:
  • tests/LocaleMacTest.cpp: Added.

(LocaleMacTest):
(LocaleMacTest::dateComponents):
(LocaleMacTest::msForDate):
(LocaleMacTest::formatDate):
(LocaleMacTest::parseDate):
(LocaleMacTest::dateFormatText):
(LocaleMacTest::firstDayOfWeek):
(LocaleMacTest::monthLabel):
(LocaleMacTest::weekDayShortLabel):
(TEST_F):

19:14 Changeset [122183] by dino@apple.com

Forgot to actually add these files in r122152

  • compositing/tile-cache-must-flatten-expected.html: Added.
  • compositing/tile-cache-must-flatten.html: Added.
18:50 Changeset [122182] by fpizlo@apple.com

Unreviewed, roll out http://trac.webkit.org/changeset/121511
It made in-browser V8v7 10% slower.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

  • bytecode/CodeBlock.h:

(CodeBlock):
(JSC::CodeBlock::countSpeculationSuccess):
(JSC::CodeBlock::countSpeculationFailure):
(JSC::CodeBlock::speculativeSuccessCounter):
(JSC::CodeBlock::speculativeFailCounter):
(JSC::CodeBlock::forcedOSRExitCounter):
(JSC::CodeBlock::addressOfSpeculativeSuccessCounter):
(JSC::CodeBlock::addressOfSpeculativeFailCounter):
(JSC::CodeBlock::addressOfForcedOSRExitCounter):
(JSC::CodeBlock::offsetOfSpeculativeSuccessCounter):
(JSC::CodeBlock::offsetOfSpeculativeFailCounter):
(JSC::CodeBlock::offsetOfForcedOSRExitCounter):
(JSC::CodeBlock::largeFailCountThreshold):
(JSC::CodeBlock::largeFailCountThresholdForLoop):
(JSC::CodeBlock::shouldReoptimizeNow):
(JSC::CodeBlock::shouldReoptimizeFromLoopNow):

  • bytecode/ExecutionCounter.cpp:

(JSC::ExecutionCounter::setThreshold):

  • bytecode/ExecutionCounter.h:

(ExecutionCounter):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileBody):

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::considerAddingAsFrequentExitSiteSlow):

  • dfg/DFGOSRExitCompiler.cpp:

(JSC::DFG::OSRExitCompiler::handleExitCounts):

  • dfg/DFGOperations.cpp:
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Options.h:

(JSC):

18:46 Changeset [122181] by hayato@chromium.org

Unreviewed gardening.
Update TestExpectations.

  • platform/chromium/TestExpectations: Mark fast/forms/select/select-state-restore.html as flaky on WIN DEBUG.
18:43 Changeset [122180] by danakj@chromium.org

[chromium] Create CCScopedTexture class for creating/freeing textures
https://bugs.webkit.org/show_bug.cgi?id=89485

Reviewed by Adrienne Walker.

Source/WebCore:

This class provides a standard way to create texture ids in a way that
ensures they will be freed later.

Also includes a CCTexture base class that holds textureId, size, and
format together in a struct that can be used in place of storing an
unsigned textureId in other classes.

Unit tests: CCScopedTexureTest.NewScopedTexture

CCScopedTexureTest.CreateScopedTexture
CCScopedTexureTest.ScopedTextureIsDeleted
CCScopedTexureTest.LoseScopedTexture

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCScopedTexture.cpp: Added.

(WebCore):
(WebCore::CCScopedTexture::CCScopedTexture):
(WebCore::CCScopedTexture::~CCScopedTexture):
(WebCore::CCScopedTexture::allocate):
(WebCore::CCScopedTexture::free):
(WebCore::CCScopedTexture::leak):

  • platform/graphics/chromium/cc/CCScopedTexture.h: Added.

(WebCore):
(CCScopedTexture):
(WebCore::CCScopedTexture::create):

  • platform/graphics/chromium/cc/CCTexture.cpp: Added.

(WebCore):
(WebCore::CCTexture::setDimensions):
(WebCore::CCTexture::bytes):
(WebCore::CCTexture::memorySizeBytes):

  • platform/graphics/chromium/cc/CCTexture.h: Added.

(WebCore):
(CCTexture):
(WebCore::CCTexture::CCTexture):
(WebCore::CCTexture::id):
(WebCore::CCTexture::size):
(WebCore::CCTexture::format):
(WebCore::CCTexture::setId):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCScopedTextureTest.cpp: Added.

(WebKitTests):
(WebKitTests::TEST):
(TrackingTextureAllocator):
(WebKitTests::TrackingTextureAllocator::TrackingTextureAllocator):
(WebKitTests::TrackingTextureAllocator::numTextures):

18:39 Changeset [122179] by jsbell@chromium.org

IndexedDB: deleteDatabase fails if transaction running in other database
https://bugs.webkit.org/show_bug.cgi?id=90822

Reviewed by Tony Chang.

Source/WebCore:

The IDBLevelDBBackingStore was preventing a deleteDatabase() from running
if any other database was running a transaction. Fix by just creating a scratch
LevelDBTransaction for the delete steps.

Test: storage/indexeddb/deletedatabase-transaction.html

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::deleteDatabase): Use a LevelDBTransaction
directly.

LayoutTests:

  • storage/indexeddb/deletedatabase-transaction-expected.txt: Added.
  • storage/indexeddb/deletedatabase-transaction.html: Added.
18:37 Changeset [122178] by commit-queue@webkit.org

.: Expose an export for the iconUrl list so Internals can use it
https://bugs.webkit.org/show_bug.cgi?id=88665

Patch by Pete Williamson <petewil@google.com> on 2012-07-09
Reviewed by Kent Tamura.

  • Source/autotools/symbols.filter: export iconURLs

Source/WebCore: Changed the behavior of iconURLs to always recalculate the list.
https://bugs.webkit.org/show_bug.cgi?id=88665

Patch by Pete Williamson <petewil@google.com> on 2012-07-09
Reviewed by Kent Tamura..

As it turns out, it can contain stale URLs in the case that some script
manipulates the DOM, which breaks scripts trying to reset the favicon
URL. Also added a method in Internals to allow tests to get the list of
icon

Tests: fast/dom/icon-url-change.html

fast/dom/icon-url-list.html

  • WebCore.exp.in: export Document::iconURLs on the mac for the Internals class
  • dom/Document.cpp:

(WebCore::Document::iconURLs): Changed the method to recalculate the iconURL list every time
(WebCore::Document::addIconURL): we no longer need to add to the internal list since we recalculate it
(WebCore::Document::setUseSecureKeyboardEntryWhenActive): removed extra whitespace

  • dom/Document.h:

(Document): removed the addIconURL method which is no longer used

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::iconType): exposed the icon type with an accessor
(WebCore):
(WebCore::HTMLLinkElement::iconSizes): exposed the icon sizes with an accessor

  • html/HTMLLinkElement.h:

(HTMLLinkElement): declared the icon type and size accessors

  • testing/Internals.cpp:

(WebCore::Internals::iconURLs): made a method to be used by unit tests for inspecting the icon URL list
(WebCore):

  • testing/Internals.h:

(Internals): declared the method for unit testing the icon URL list

  • testing/Internals.idl: exported the Document::iconURLs function

Source/WebKit2: Export the iconURL list to make it available to the Internals class for testing
https://bugs.webkit.org/show_bug.cgi?id=88665

Patch by Pete Williamson <petewil@google.com> on 2012-07-09
Reviewed by Kent Tamura.

  • win/WebKit2.def: export the DocumentL::iconURLs function

LayoutTests: Add some new unit tests to test the favicon changing dynamically
https://bugs.webkit.org/show_bug.cgi?id=88665

Patch by Pete Williamson <petewil@google.com> on 2012-07-09
Reviewed by Kent Tamura.

  • fast/dom/icon-url-change-expected.txt: Added.
  • fast/dom/icon-url-change.html: Added a new test for changing the favicon dynamically
  • fast/dom/icon-url-list-expected.txt: Added.
  • fast/dom/icon-url-list.html: Added a new test for multiple favicons in the HTML header
  • fast/dom/icon-url-property-expected.txt: update unit test expectations
  • fast/dom/icon-url-property.html: update and enable existing favicon test
  • platform/chromium/TestExpectations: reenable the url-property test
18:35 Changeset [122177] by rniwa@webkit.org

Gcc build fix after r122174.

  • storage/StorageAreaImpl.cpp:

(WebCore::StorageAreaImpl::decrementAccessCount):

18:25 Changeset [122176] by commit-queue@webkit.org

Editing: Autocorrection in blockquotes causes text to break out of quote
https://bugs.webkit.org/show_bug.cgi?id=90487
<rdar://problem/11769020>

Patch by Alice Cheng <alice_cheng@apple.com> on 2012-07-09
Reviewed by Enrica Casucci.

Source/WebCore:

Test: platform/mac/editing/spelling/autocorrection-blockquote-crash.html

SpellingCorrectionCommand uses ReplaceSelectionCommand to replace the misspelled word with the auto-corrected word. Specifically, ReplaceSelectionCommand does a smart copy, where it breaks out of blockquotes. Thus, the fix is to substitute ReplaceSelectionCommand with InserTextCommand.

  • editing/SpellingCorrectionCommand.cpp:

(WebCore::SpellingCorrectionCommand::doApply):

LayoutTests:

  • platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt:
  • platform/mac/editing/spelling/autocorrection-blockquote-crash.html:
18:06 Changeset [122175] by noam.rosenthal@nokia.com

90506

18:03 Changeset [122174] by commit-queue@webkit.org

Consider closing unused localStorage database after a timeout.
https://bugs.webkit.org/show_bug.cgi?id=90713

For a localStorage, if there is no active document referencing to it for certain amount of time (300 seconds),
we can close the underlying sqlite database.

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2012-07-09
Reviewed by Brady Eidson.

Source/WebCore:

Test: storage/domstorage/storage-close-database-on-idle.html

  • storage/Storage.cpp:

(WebCore::Storage::Storage): increment storageArea access count when a DOMWindow is referencing it.
(WebCore::Storage::~Storage): decrement storageArea access count when DOMWindow is done with it.

  • storage/StorageArea.h:

(StorageArea):

  • storage/StorageAreaImpl.cpp:

(WebCore::StorageAreaImpl::StorageAreaImpl):
(WebCore::StorageAreaImpl::incrementAccessCount):
(WebCore):
(WebCore::StorageAreaImpl::decrementAccessCount): schedule closeDatabaseTimer if there is no active document

referencing to this storageArea.

(WebCore::StorageAreaImpl::closeDatabaseTimerFired): close the underlying sqlite database.

  • storage/StorageAreaImpl.h:

(StorageAreaImpl):

  • storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::sync): if m_syncCloseDatabase flag is set and the database is not opened, bail out.

  • storage/StorageTracker.cpp:

(WebCore):
(WebCore::StorageTracker::StorageTracker):

  • storage/StorageTracker.h:

(WebCore::StorageTracker::storageDatabaseIdleInterval):
(WebCore::StorageTracker::setStorageDatabaseIdleInterval): set the timeout value that we will wait before closing the

database. This is currently used by DumpRenderTree only.

(StorageTracker):

Source/WebKit/mac:

  • Storage/WebStorageManager.mm:

(+[WebStorageManager setStorageDatabaseIdleInterval:]): add a new method for DumpRenderTree to set the timeout

that we will wait before closing database.

(initializeLocalStoragePath):

  • Storage/WebStorageManagerPrivate.h:

Tools:

  • DumpRenderTree/LayoutTestController.cpp: add a JS method setStorageDatabaseIdleInterval to testRunner

to set a different timeout value for closing localStorage database.

(setStorageDatabaseIdleIntervalCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setStorageDatabaseIdleInterval): add empty method.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::setStorageDatabaseIdleInterval): ditto.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::setStorageDatabaseIdleInterval): ditto.

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::setStorageDatabaseIdleInterval): ditto.

LayoutTests:

  • platform/chromium/TestExpectations: the test needs setCacheModel implementation, skip it in chromium.
  • storage/domstorage/storage-close-database-on-idle-expected.txt: Added.
  • storage/domstorage/storage-close-database-on-idle.html: Added.
  • storage/resources/storage-close-data-on-idle-switch.html: Added.
17:48 Changeset [122173] by jsbell@chromium.org

IndexedDB: A null or undefined storeNames argument to IDBDatabase::transaction() should be coerced to string
https://bugs.webkit.org/show_bug.cgi?id=90474

Reviewed by Tony Chang.

Source/WebCore:

Test: storage/indexeddb/transaction-basics.html

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::transaction):

  • Modules/indexeddb/IDBDatabase.idl:

LayoutTests:

  • storage/indexeddb/resources/transaction-basics.js:

(testInvalidMode):
(testDegenerateNames.request.onsuccess):
(testDegenerateNames.verifyDegenerateNames):
(testDegenerateNames):

  • storage/indexeddb/transaction-basics-expected.txt:
17:41 Changeset [122172] by jsbell@chromium.org

IndexedDB: Remove obsolete accessor plumbing
https://bugs.webkit.org/show_bug.cgi?id=90812

Reviewed by Tony Chang.

Source/WebCore:

No new tests - just deleting code.

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::IDBTransaction): Since backend mode() is disconnected, can no
longer assert that front-end/back-end modes match; not worth it to keeping the plumbing.

Source/WebKit/chromium:

  • public/WebIDBCursor.h: Remove direction.
  • public/WebIDBDatabase.h: Remove name, version, objectStoreNames;

(WebKit::WebIDBDatabase::metadata):

  • public/WebIDBIndex.h: Remove name, keyPath, unique, multiEntry;
  • public/WebIDBObjectStore.h: Remove name, keyPath, indexNames, autoIncrement;
  • src/IDBDatabaseBackendProxy.cpp: Remove plumbing.
  • src/IDBDatabaseBackendProxy.h: Remove plumbing.

(IDBDatabaseBackendProxy):

  • src/IDBIndexBackendProxy.cpp: Remove plumbing.
  • src/IDBIndexBackendProxy.h: Remove plumbing.

(IDBIndexBackendProxy):

  • src/IDBObjectStoreBackendProxy.cpp: Remove plumbing.
  • src/IDBObjectStoreBackendProxy.h: Remove plumbing.

(IDBObjectStoreBackendProxy):

  • src/IDBTransactionBackendProxy.cpp: Remove plumbing.
  • src/IDBTransactionBackendProxy.h: Assert stub is not used - only needed

by real IDBTransactionBackendImpl
(WebKit::IDBTransactionBackendProxy::mode):

  • src/WebIDBTransactionImpl.cpp: Remove plumbing.
  • src/WebIDBTransactionImpl.h: Remove plumbing.
17:20 Changeset [122171] by commit-queue@webkit.org

Unreviewed, rolling out r122161.
http://trac.webkit.org/changeset/122161
https://bugs.webkit.org/show_bug.cgi?id=90837

failed to compile on chromium webkit linux bot (Requested by
shawnsingh on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-09

  • WebKit.gypi:
  • WebKitUnitTests.gyp:
  • public/WebDOMMessageEvent.h:
  • tests/AssociatedURLLoaderTest.cpp:

(WebKit::AssociatedURLLoaderTest::AssociatedURLLoaderTest):
(WebKit::AssociatedURLLoaderTest::SetUp):
(WebKit::AssociatedURLLoaderTest::CheckMethodFails):
(WebKit::AssociatedURLLoaderTest::CheckHeaderFails):
(WebKit::AssociatedURLLoaderTest::CheckAccessControlHeaders):
(WebKit::TEST_F):

  • tests/EventListenerTest.cpp:
  • tests/FrameTestHelpers.cpp:

(WebKit::FrameTestHelpers::registerMockedURLLoad):
(FrameTestHelpers):
(WebKit::FrameTestHelpers::loadFrame):

  • tests/FrameTestHelpers.h:

(FrameTestHelpers):

  • tests/ListenerLeakTest.cpp:

(WebKit::ListenerLeakTest::RunTest):

  • tests/PopupMenuTest.cpp:

(WebKit::SelectPopupMenuTest::registerMockedURLLoad):
(WebKit::SelectPopupMenuTest::loadFrame):
(WebKit::TEST_F):

  • tests/RunAllTests.cpp:
  • tests/URLTestHelpers.cpp: Removed.
  • tests/URLTestHelpers.h: Removed.
  • tests/WebFrameTest.cpp:

(WebKit::WebFrameTest::registerMockedHttpURLLoad):
(WebKit::WebFrameTest::registerMockedChromeURLLoad):
(WebKit::TEST_F):

  • tests/WebPageNewSerializerTest.cpp:

(WebKit::WebPageNewSerializeTest::registerMockedURLLoad):
(WebPageNewSerializeTest):
(WebKit::WebPageNewSerializeTest::setUpCSSTestPage):
(WebKit::WebPageNewSerializeTest::loadURLInTopFrame):
(WebKit::WebPageNewSerializeTest::resourceVectorContains):
(WebKit::TEST_F):

  • tests/WebPageSerializerTest.cpp:

(WebKit::WebPageSerializerTest::registerMockedURLLoad):
(WebKit::WebPageSerializerTest::loadURLInTopFrame):
(WebKit::WebPageSerializerTest::webVectorContains):
(WebKit::TEST_F):

  • tests/WebViewTest.cpp:

(WebKit::TEST_F):
(WebKit::WebViewTest::testAutoResize):
(WebKit::WebViewTest::testTextInputType):

17:17 Changeset [122170] by danakj@chromium.org

[chromium] Remove HashMap workaround for layers with id=0 in CCDamageTracker
https://bugs.webkit.org/show_bug.cgi?id=90825

Reviewed by Adrienne Walker.

Layer ids are no longer allowed to be 0, and the behaviour is guarded
with asserts, so this workaround is not needed any longer.

  • platform/graphics/chromium/cc/CCDamageTracker.h:

(CCDamageTracker):

17:08 Changeset [122169] by scheib@chromium.org

Pointer Lock requestPointerLock rejects locking an element not in a document.
https://bugs.webkit.org/show_bug.cgi?id=90821

Reviewed by Adrienne Walker.

Source/WebCore:

Test: pointer-lock/lock-element-not-in-dom.html

  • page/PointerLockController.cpp:

(WebCore::PointerLockController::requestPointerLock):

LayoutTests:

  • pointer-lock/lock-element-not-in-dom-expected.txt: Added.
  • pointer-lock/lock-element-not-in-dom.html: Added.
16:48 Changeset [122168] by eric@webkit.org

document.write of scripts that also document.write sometimes writes async
https://bugs.webkit.org/show_bug.cgi?id=89102

Reviewed by Adam Barth.

Source/WebCore:

When a script tag is first encountered, the TreeBuilder holds the element and returns
out to the outer HTMLDocumentParser parse loop. The HTMLDocumentParser then takes
the script element and passes it to the HTMLScriptRunner for execution. However, if the
script is an "external script" the HTMLScriptRunner may have to wait for that parser
blocking script to load, and may store the script in its own m_parserBlockingScript member.

While the HTMLScriptRunner has this not-yet-loaded-script the parser is also blocked.
Because the "paused" state of the parser was held as a separate bool on the TreeBuilder
we'd have to be careful to update it to reflect the current state of this pending script
on the HTMLScriptRunner.

This patch removes this separate "paused" bool and makes the HTMLDocumentParser responsible
for the "paused" state of the parser through the isWaitingForScripts() function which
knows how to check both the TreeBuilder and the ScriptRunner for possible parser-blocking scripts.

I suspect this change may actually fix a bunch of edge cases where we were not
checking for the HTMLScriptRunner's parser blocking script and thus incorrectly ending
the parser, or not starting the pre-load scanner, etc.

As part of this change I also renamed m_haveParsingBlockingScript in HTMLScriptRunner to match
the naming style used elsewhere in the parser, as well as removed all the "bool" return values
for these parse/execute functions as they are no longer useful (or correct). The correct way
is always to check HTMLDocumentParser::isWaitingForScripts().

Test: fast/parser/cached-script-document-write.html

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::pumpTokenizerIfPossible):
(WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder):
(WebCore::HTMLDocumentParser::canTakeNextToken):
(WebCore::HTMLDocumentParser::isWaitingForScripts):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):
(WebCore::HTMLDocumentParser::notifyFinished):
(WebCore::HTMLDocumentParser::executeScriptsWaitingForStylesheets):

  • html/parser/HTMLScriptRunner.cpp:

(WebCore::HTMLScriptRunner::~HTMLScriptRunner):
(WebCore::HTMLScriptRunner::executeParsingBlockingScript):
(WebCore::HTMLScriptRunner::execute):
(WebCore::HTMLScriptRunner::hasParserBlockingScript):
(WebCore::HTMLScriptRunner::executeParsingBlockingScripts):
(WebCore::HTMLScriptRunner::executeScriptsWaitingForLoad):
(WebCore::HTMLScriptRunner::executeScriptsWaitingForParsing):
(WebCore::HTMLScriptRunner::requestParsingBlockingScript):
(WebCore::HTMLScriptRunner::runScript):

  • html/parser/HTMLScriptRunner.h:

(HTMLScriptRunner):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::takeScriptToProcess):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processTokenInForeignContent):

  • html/parser/HTMLTreeBuilder.h:

(HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::hasParserBlockingScript):

LayoutTests:

  • fast/parser/cached-script-document-write-expected.txt: Added.
  • fast/parser/cached-script-document-write.html: Added.
  • fast/parser/resources/cached-script-document-write.js: Added.
16:28 Changeset [122167] by fpizlo@apple.com

Source/JavaScriptCore: DFG may get stuck in an infinite fix point if it constant folds a mispredicted node
https://bugs.webkit.org/show_bug.cgi?id=90829
<rdar://problem/11823843>

Reviewed by Oliver Hunt.

If a node is shown to have been mispredicted during CFA, then don't allow constant
folding to make the graph even more degenerate. Instead, pull back on constant folding
and allow the normal OSR machinery to fix our profiling so that a future recompilation
doesn't see the same mistake.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGAbstractState.h:

(JSC::DFG::AbstractState::trySetConstant):
(AbstractState):

  • dfg/DFGPhase.h:

(JSC::DFG::Phase::name):
(Phase):
(JSC::DFG::runAndLog):
(DFG):
(JSC::DFG::runPhase):

LayoutTests: DFG may get stuck in an infinite fix point if it constant folds a mispredicted node
https://bugs.webkit.org/show_bug.cgi?id=90829

Reviewed by Oliver Hunt.

  • fast/js/dfg-constant-fold-misprediction-expected.txt: Added.
  • fast/js/dfg-constant-fold-misprediction.html: Added.
  • fast/js/script-tests/dfg-constant-fold-misprediction.js: Added.

(foo):

16:26 Changeset [122166] by fpizlo@apple.com

It should be possible to jettison JIT stub routines even if they are currently running
https://bugs.webkit.org/show_bug.cgi?id=90731

Reviewed by Gavin Barraclough.

This gives the GC awareness of all JIT-generated stubs for inline caches. That
means that if you want to delete a JIT-generated stub, you don't have to worry
about whether or not it is currently running: if there is a chance that it might
be, the GC will kindly defer deletion until non-running-ness is proved.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/Instruction.h:

(JSC):
(PolymorphicStubInfo):
(JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
(JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):

  • bytecode/PolymorphicPutByIdList.cpp:

(JSC::PutByIdAccess::fromStructureStubInfo):

  • bytecode/PolymorphicPutByIdList.h:

(JSC::PutByIdAccess::transition):
(JSC::PutByIdAccess::replace):
(JSC::PutByIdAccess::stubRoutine):
(PutByIdAccess):
(JSC::PolymorphicPutByIdList::currentSlowPathTarget):

  • bytecode/StructureStubInfo.h:

(JSC::StructureStubInfo::reset):

  • dfg/DFGRepatch.cpp:

(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::tryBuildGetByIDProtoList):
(JSC::DFG::emitPutReplaceStub):
(JSC::DFG::emitPutTransitionStub):
(JSC::DFG::tryCachePutByID):
(JSC::DFG::tryBuildPutByIdList):

  • heap/ConservativeRoots.cpp:

(JSC):
(DummyMarkHook):
(JSC::DummyMarkHook::mark):
(JSC::ConservativeRoots::add):
(CompositeMarkHook):
(JSC::CompositeMarkHook::CompositeMarkHook):
(JSC::CompositeMarkHook::mark):

  • heap/ConservativeRoots.h:

(JSC):
(ConservativeRoots):

  • heap/Heap.cpp:

(JSC::Heap::markRoots):
(JSC::Heap::deleteUnmarkedCompiledCode):

  • heap/Heap.h:

(JSC):
(Heap):

  • heap/JITStubRoutineSet.cpp: Added.

(JSC):
(JSC::JITStubRoutineSet::JITStubRoutineSet):
(JSC::JITStubRoutineSet::~JITStubRoutineSet):
(JSC::JITStubRoutineSet::add):
(JSC::JITStubRoutineSet::clearMarks):
(JSC::JITStubRoutineSet::markSlow):
(JSC::JITStubRoutineSet::deleteUnmarkedJettisonedStubRoutines):
(JSC::JITStubRoutineSet::traceMarkedStubRoutines):

  • heap/JITStubRoutineSet.h: Added.

(JSC):
(JITStubRoutineSet):
(JSC::JITStubRoutineSet::mark):

  • heap/MachineStackMarker.h:

(JSC):

  • interpreter/RegisterFile.cpp:

(JSC::RegisterFile::gatherConservativeRoots):

  • interpreter/RegisterFile.h:

(JSC):

  • jit/ExecutableAllocator.cpp:

(JSC::DemandExecutableAllocator::DemandExecutableAllocator):

  • jit/ExecutableAllocator.h:

(JSC):

  • jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC):
(JSC::FixedVMPoolExecutableAllocator::FixedVMPoolExecutableAllocator):

  • jit/GCAwareJITStubRoutine.cpp: Added.

(JSC):
(JSC::GCAwareJITStubRoutine::GCAwareJITStubRoutine):
(JSC::GCAwareJITStubRoutine::~GCAwareJITStubRoutine):
(JSC::GCAwareJITStubRoutine::observeZeroRefCount):
(JSC::GCAwareJITStubRoutine::deleteFromGC):
(JSC::GCAwareJITStubRoutine::markRequiredObjectsInternal):
(JSC::MarkingGCAwareJITStubRoutineWithOneObject::MarkingGCAwareJITStubRoutineWithOneObject):
(JSC::MarkingGCAwareJITStubRoutineWithOneObject::~MarkingGCAwareJITStubRoutineWithOneObject):
(JSC::MarkingGCAwareJITStubRoutineWithOneObject::markRequiredObjectsInternal):
(JSC::createJITStubRoutine):

  • jit/GCAwareJITStubRoutine.h: Added.

(JSC):
(GCAwareJITStubRoutine):
(JSC::GCAwareJITStubRoutine::markRequiredObjects):
(MarkingGCAwareJITStubRoutineWithOneObject):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):

  • jit/JITStubRoutine.cpp: Added.

(JSC):
(JSC::JITStubRoutine::~JITStubRoutine):
(JSC::JITStubRoutine::observeZeroRefCount):

  • jit/JITStubRoutine.h: Added.

(JSC):
(JITStubRoutine):
(JSC::JITStubRoutine::JITStubRoutine):
(JSC::JITStubRoutine::createSelfManagedRoutine):
(JSC::JITStubRoutine::code):
(JSC::JITStubRoutine::asCodePtr):
(JSC::JITStubRoutine::ref):
(JSC::JITStubRoutine::deref):
(JSC::JITStubRoutine::startAddress):
(JSC::JITStubRoutine::endAddress):
(JSC::JITStubRoutine::addressStep):
(JSC::JITStubRoutine::canPerformRangeFilter):
(JSC::JITStubRoutine::filteringStartAddress):
(JSC::JITStubRoutine::filteringExtentSize):
(JSC::JITStubRoutine::passesFilter):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):
(JSC::getPolymorphicAccessStructureListSlot):

16:21 Changeset [122165] by fpizlo@apple.com

fast/js/global-constructors.html is flaky and mostly useless
https://bugs.webkit.org/show_bug.cgi?id=90833

Unreviewed, skip flaky and useless test.

  • platform/mac/Skipped:
16:10 Changeset [122164] by rafaelw@chromium.org

Unreviewed gardening. Marked webgl/glsl-conformance tests failing after dependency roll in chromium.

  • platform/chromium/TestExpectations:
16:07 Changeset [122163] by rniwa@webkit.org

Microdata tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=90830

Reviewed by Antti Koivisto.

The bug was caused by SpaceSplitString's not copying on write properly.
Even if there was exactly one owner of the SpaceSplitString, we should still not modify
m_data since m_data is associated with a particular m_keyString in sharedDataMap().

The only situation in which we can safely modify m_data is when m_data's m_keyString is null
meaning that it had been unique'ed. Furthermore, this optimization had not been used for
class lists because class list's refCount is always zero as its ref and deref are forwarded
to the associated Element's ref and deref. This fix re-enables the optimization for class lists.

This behavior change is tested by existing microdata API tests. Without this patch,
some tests such as properties-collection-add-remove-property.html fail on the first run
when several tests were ran in the same WebKit instance.

  • dom/SpaceSplitString.h:

(WebCore::SpaceSplitStringData::isUnique):
(WebCore::SpaceSplitString::ensureUnique):

16:05 Changeset [122162] by commit-queue@webkit.org

[BlackBerry] PagePopupBlackBerry::closePopup() should always clear the pointer in WebPagePrivate
https://bugs.webkit.org/show_bug.cgi?id=90817

Patch by Yong Li <yoli@rim.com> on 2012-07-09
Reviewed by Rob Buis.

PR# 174085.
PagePopupBlackBerry::closePopup() should always clear the pointer in WebPagePrivate to avoid crashes.
This patch also removes unused variable m_parentPopup and its setter.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate): Remove m_parentPopup.

  • Api/WebPage_p.h:

(WebPagePrivate):

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::closePagePopup):

  • WebCoreSupport/PagePopupBlackBerry.cpp:

(WebCore::PagePopupBlackBerry::init): Remove the setParentPopup() call.
(WebCore::PagePopupBlackBerry::closePopup): Clear the reference in WebPagePrivate.

  • WebCoreSupport/SelectPopupClient.cpp:

(WebCore::SelectPopupClient::setValueAndClosePopup): Add an assert for valid m_element.

16:03 Changeset [122161] by shawnsingh@chromium.org

[chromium] Use WEBKIT_IMPLEMENTATION == 1 for webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=90094

Reviewed by Adam Barth.

This patch adds the WEBKIT_IMPLEMENTATION = 1 define to
WebKitUnitTests.gyp. To get it to compile correctly, some string
and URL code was refactored, and GURL types were replaced with KURL types.

  • WebKit.gypi:
  • WebKitUnitTests.gyp:
  • public/WebDOMMessageEvent.h:

(WebKit::WebDOMMessageEvent::WebDOMMessageEvent):

  • tests/AssociatedURLLoaderTest.cpp:
  • tests/EventListenerTest.cpp:
  • tests/FrameTestHelpers.cpp:

(WebKit::FrameTestHelpers::loadFrame):

  • tests/FrameTestHelpers.h:
  • tests/ListenerLeakTest.cpp:

(WebKit::ListenerLeakTest::RunTest):

  • tests/PopupMenuTest.cpp:
  • tests/RunAllTests.cpp:
  • tests/URLTestHelpers.cpp: Added.

(URLTestHelpers):
(WebKit::URLTestHelpers::registerMockedURLFromBaseURL):
(WebKit::URLTestHelpers::registerMockedURLLoad):

  • tests/URLTestHelpers.h: Copied from Source/WebKit/chromium/public/WebDOMMessageEvent.h.

(WebKit):
(URLTestHelpers):
(WebKit::URLTestHelpers::toKURL):

  • tests/WebFrameTest.cpp:
  • tests/WebPageNewSerializerTest.cpp:
  • tests/WebPageSerializerTest.cpp:
  • tests/WebViewTest.cpp:
15:31 Changeset [122160] by danakj@chromium.org

[chromium] Decouple RenderPass drawing from CCRenderSurface
https://bugs.webkit.org/show_bug.cgi?id=90573

Reviewed by Adrienne Walker.

Source/WebCore:

Removes the managed textures from CCRenderSurface and stores them in a
HashMap in LayerRendererChromium.

At the start of a frame, all textures for the frame are reserved, and
unneeded textures are deleted. After each quad is drawn, evicted textures
(ie temporary textures used for background filters) are deleted to keep
within memory limits. At the end of the frame, all surface contents
textures are kept reserved and thus not deleted.

We add a numeric identifier to CCRenderPass which can be used to
identify the pass across serialization in the future, and is used
in the interface to LayerRendererChromium. Also we add to the
CCRenderPass a contentsChangedSinceLastFrame() flag so that the
value does not need to be retrieved from the CCRenderSurface.

The pointer from CCRenderPass to CCRenderSurface remains for some
code in the CCLayerTreeHostImpl, and will be addressed in the future, but
the pointer is no longer used at all while drawing a frame inside
LayerRendererChromium.

Covered by existing tests, no intended change in behaviour.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::releaseRenderPassTextures):
(WebCore::LayerRendererChromium::decideRenderPassAllocationsForFrame):
(WebCore):
(WebCore::LayerRendererChromium::haveCachedResourcesForRenderPassId):
(WebCore::LayerRendererChromium::drawQuad):
(WebCore::LayerRendererChromium::drawBackgroundFilters):
(WebCore::LayerRendererChromium::drawRenderPassQuad):
(WebCore::LayerRendererChromium::finishDrawingFrame):
(WebCore::LayerRendererChromium::useRenderPass):
(WebCore::LayerRendererChromium::initializeSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::removePassesWithCachedTextures):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::create):
(WebCore::CCRenderPass::CCRenderPass):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(CCRenderPass):
(WebCore::CCRenderPass::id):
(WebCore::CCRenderPass::setFramebufferOutputRect):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:

(WebCore::CCRenderPassDrawQuad::create):
(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:

(CCRenderPassDrawQuad):
(WebCore::CCRenderPassDrawQuad::renderPassId):
(WebCore::CCRenderPassDrawQuad::contentsChangedSinceLastFrame):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::appendQuads):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore):
(CCRenderSurface):

  • platform/graphics/chromium/cc/CCRenderer.h:

(CCRenderer):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::pushTileProperties):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:

(CCTiledLayerImpl):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/LayerRendererChromiumTest.cpp:

(FakeCCRendererClient::FakeCCRendererClient):

14:34 Changeset [122159] by adamk@chromium.org

Rename WebCore::WebKitMutationObserver to WebCore::MutationObserver
https://bugs.webkit.org/show_bug.cgi?id=90810

Reviewed by Ojan Vafai.

Source/WebCore:

This is in preparation for removing the vendor prefix from the
MutationObserver constructor on Window (currently it's called
WebKitMutationObserver). Doing the WebCore-internal rename first
makes that change a much smaller one, which is especially useful
because there's ongoing discussion of when the prefix should be
removed from the web-facing API.

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • Target.pri:
  • UseJSC.cmake:
  • UseV8.cmake:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSMainThreadExecState.cpp:

(WebCore::JSMainThreadExecState::didLeaveScriptContext):

  • bindings/js/JSMutationCallbackCustom.cpp:

(WebCore::JSMutationCallback::handleEvent):

  • bindings/js/JSMutationObserverCustom.cpp: Renamed from Source/WebCore/bindings/js/JSWebKitMutationObserverCustom.cpp.

(WebCore):
(WebCore::JSMutationObserverConstructor::constructJSMutationObserver):

  • bindings/v8/V8RecursionScope.cpp:

(WebCore::V8RecursionScope::didLeaveScriptContext):

  • bindings/v8/custom/V8MutationCallbackCustom.cpp:

(WebCore::V8MutationCallback::handleEvent):

  • bindings/v8/custom/V8MutationObserverCustom.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8WebKitMutationObserverCustom.cpp.

(WebCore):
(WebCore::V8MutationObserver::constructorCallback):

  • dom/CharacterData.cpp:
  • dom/ChildListMutationScope.h:

(WebCore::ChildListMutationScope::ChildListMutationScope):

  • dom/DOMAllInOne.cpp:
  • dom/Document.h:

(WebCore::Document::hasMutationObserversOfType):

  • dom/Element.cpp:
  • dom/MutationCallback.h:

(WebCore):
(MutationCallback):

  • dom/MutationCallback.idl:
  • dom/MutationObserver.cpp: Renamed from Source/WebCore/dom/WebKitMutationObserver.cpp.

(WebCore):
(WebCore::MutationObserver::ObserverLessThan::operator()):
(WebCore::MutationObserver::create):
(WebCore::MutationObserver::MutationObserver):
(WebCore::MutationObserver::~MutationObserver):
(WebCore::MutationObserver::validateOptions):
(WebCore::MutationObserver::observe):
(WebCore::MutationObserver::takeRecords):
(WebCore::MutationObserver::disconnect):
(WebCore::MutationObserver::observationStarted):
(WebCore::MutationObserver::observationEnded):
(WebCore::activeMutationObservers):
(WebCore::MutationObserver::enqueueMutationRecord):
(WebCore::MutationObserver::setHasTransientRegistration):
(WebCore::MutationObserver::deliver):
(WebCore::MutationObserver::deliverAllMutations):

  • dom/MutationObserver.h: Renamed from Source/WebCore/dom/WebKitMutationObserver.h.

(WebCore):
(MutationObserver):

  • dom/MutationObserver.idl: Renamed from Source/WebCore/dom/WebKitMutationObserver.idl.
  • dom/MutationObserverInterestGroup.cpp:

(WebCore::MutationObserverInterestGroup::createIfNeeded):
(WebCore::MutationObserverInterestGroup::MutationObserverInterestGroup):
(WebCore::MutationObserverInterestGroup::isOldValueRequested):
(WebCore::MutationObserverInterestGroup::enqueueMutationRecord):

  • dom/MutationObserverInterestGroup.h:

(WebCore::MutationObserverInterestGroup::createForChildListMutation):
(WebCore::MutationObserverInterestGroup::createForCharacterDataMutation):
(WebCore::MutationObserverInterestGroup::createForAttributesMutation):
(MutationObserverInterestGroup):

  • dom/MutationObserverRegistration.cpp:

(WebCore::MutationObserverRegistration::create):
(WebCore::MutationObserverRegistration::MutationObserverRegistration):
(WebCore::MutationObserverRegistration::shouldReceiveMutationFrom):

  • dom/MutationObserverRegistration.h:

(MutationObserverRegistration):
(WebCore::MutationObserverRegistration::isSubtree):
(WebCore::MutationObserverRegistration::observer):
(WebCore::MutationObserverRegistration::deliveryOptions):
(WebCore::MutationObserverRegistration::mutationTypes):

  • dom/Node.cpp:

(WebCore::Node::collectMatchingObserversForMutation):
(WebCore::Node::getRegisteredMutationObserversOfType):
(WebCore::Node::registerMutationObserver):

  • dom/Node.h:

(Node):

  • dom/NodeRareData.h:
  • page/DOMWindow.idl:

Source/WebKit/chromium:

  • src/WebKit.cpp:

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::deliverAllMutationsIfNecessary):

Source/WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::deliverAllMutationsIfNecessary):

Tools:

  • DumpRenderTree/gtk/EventSender.cpp:
14:19 Changeset [122158] by scheib@chromium.org

Refactor common Pointer Lock test code to a harness.
https://bugs.webkit.org/show_bug.cgi?id=90813

Reviewed by Adrienne Walker.

  • pointer-lock/bug90391-move-then-window-open-crash-expected.txt:
  • pointer-lock/bug90391-move-then-window-open-crash.html:
  • pointer-lock/lock-already-locked-expected.txt:
  • pointer-lock/lock-already-locked.html:
  • pointer-lock/lock-fail-responses-expected.txt:
  • pointer-lock/lock-fail-responses.html:
  • pointer-lock/mouse-event-delivery-expected.txt:
  • pointer-lock/mouse-event-delivery.html:
  • pointer-lock/pointer-lock-api-expected.txt:
  • pointer-lock/pointer-lock-api.html:
  • pointer-lock/pointerlockchange-pointerlockerror-events-expected.txt:
  • pointer-lock/pointerlockchange-pointerlockerror-events.html:
  • pointer-lock/pointerlocklost-event-expected.txt:
  • pointer-lock/pointerlocklost-event.html:
  • pointer-lock/resources/pointer-lock-test-harness.js: Added.

(doNextStep.else):
(doNextStepWithUserGesture):
(eventExpected.targetHanderNode.eventHandlerName):
(eventExpected):
(expectOnlyChangeEvent):
(expectOnlyErrorEvent):
(expectNoEvents):

14:19 Changeset [122157] by cevans@google.com

Revert 116356
BUG=135658
Review URL: https://chromiumcodereview.appspot.com/10758010

14:12 Changeset [122156] by fpizlo@apple.com

Unreviewed, rolling out http://trac.webkit.org/changeset/122116 and http://trac.webkit.org/changeset/122119

  • GNUmakefile.list.am:
  • PlatformBlackBerry.cmake:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/GraphicsContext3D.h:

(WebCore):

  • platform/graphics/OpenGLESShims.h:
  • platform/graphics/cairo/GraphicsContext3DCairo.cpp:

(WebCore):

  • platform/graphics/clutter/GraphicsContext3DClutter.cpp:

(WebCore):

  • platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore):

  • platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::Extensions3DOpenGL):
(WebCore::Extensions3DOpenGL::supports):
(WebCore):
(WebCore::Extensions3DOpenGL::ensureEnabled):
(WebCore::Extensions3DOpenGL::isEnabled):
(WebCore::Extensions3DOpenGL::getGraphicsResetStatusARB):
(WebCore::Extensions3DOpenGL::getTranslatedShaderSourceANGLE):
(WebCore::Extensions3DOpenGL::copyTextureCHROMIUM):

  • platform/graphics/opengl/Extensions3DOpenGL.h:

(Extensions3DOpenGL):

  • platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
  • platform/graphics/opengl/Extensions3DOpenGLCommon.h:
  • platform/graphics/opengl/Extensions3DOpenGLES.cpp:
  • platform/graphics/opengl/Extensions3DOpenGLES.h:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::systemAllowsMultisamplingOnATICards):
(WebCore):
(WebCore::GraphicsContext3D::validateAttributes):
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::readPixels):
(WebCore::GraphicsContext3D::releaseShaderCompiler):
(WebCore::GraphicsContext3D::getExtensions):

  • platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:

(WebCore::GraphicsContext3D::readPixelsAndConvertToBGRAIfNecessary):
(WebCore::GraphicsContext3D::reshapeFBOs):
(WebCore):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore):

13:52 Changeset [122155] by rniwa@webkit.org

Build fix after r122115 and some cleanups.

  • html/HTMLCollection.h:

(HTMLCollection):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::properties):

  • html/HTMLElement.h:

(HTMLElement):

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::HTMLPropertiesCollection):

  • html/HTMLPropertiesCollection.h:

(HTMLPropertiesCollection):

13:46 Changeset [122154] by mihaip@chromium.org

Handle missing results in TestResultsServer better
https://bugs.webkit.org/show_bug.cgi?id=90816

Reviewed by Ojan Vafai.

If we can't load the results JSON, don't try to wrap it with the JSONP
callback invocation.

  • TestResultServer/handlers/testfilehandler.py:

(GetFile.get):

13:46 Changeset [122153] by commit-queue@webkit.org

[WK2] Add missing Battery Status API integration to WebContext and WebPage
https://bugs.webkit.org/show_bug.cgi?id=90784

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-09
Reviewed by Anders Carlsson.

Integrate Battery Status API to WebPage, WebContext and
properly route messages to the WebBatteryManagerProxy.
Without this, the Battery Status tests are crashing for
WebKit2.

  • UIProcess/API/C/WKContext.cpp:

(WKContextGetBatteryManager):

  • UIProcess/API/C/WKContext.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::disconnectProcess):
(WebKit::WebContext::didReceiveMessage):

  • UIProcess/WebContext.h:

(WebKit):
(WebContext):
(WebKit::WebContext::batteryManagerProxy):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveMessage):

  • WebProcess/WebCoreSupport/WebBatteryClient.cpp:

(WebKit::WebBatteryClient::setController):
(WebKit):

  • WebProcess/WebCoreSupport/WebBatteryClient.h:

(WebBatteryClient):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

13:36 Changeset [122152] by dino@apple.com

Tiled drawing means some elements can disappear behind the page
https://bugs.webkit.org/show_bug.cgi?id=88906

Reviewed by Simon Fraser.

Source/WebCore:

The compositing layers in the tile cache could become siblings
of the compositing layers for page elements. This meant that in
some 3d transforms, the elements could disappear behind the
page background (which is rendered into the tile cache) or intersect
with the tile cache tiles.

Fix this by inserting a flattening layer between the tile cache
and the page, ensuring that the cache will always be rendered
first. I was able to reuse the clipping layer for this, because
the tile cache is attached to the RenderView, so there should never
be a case where we have both a clipping layer and tiles.

The unfortunate part of this code is the temporary state variable
that wraps the call to GraphicsLayer::create. Because that method
calls back into the object, we need to make sure we don't create
another tile cache.

Also added some obvious names to the tile cache layers to
help with debugging.

Test: compositing/tile-cache-must-flatten.html

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::TileCache): give the tile host layer a name.
(WebCore::TileCache::createTileLayer):

  • platform/graphics/ca/mac/WebTileCacheLayer.mm:

(WebCore): give each tile layer a name.

  • rendering/RenderLayerBacking.cpp:

(WebCore):
(WebCore::RenderLayerBacking::shouldUseTileCache): check if we're in the middle
of creating the primary graphics layer before answering.
(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer): wrap our call to
createGraphicsLayer with a message to indicate we are making the layer that should
get a tile cache.
(WebCore::RenderLayerBacking::destroyGraphicsLayers):
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): needs to make
sure the flattening layer is in the tree.
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::updateInternalHierarchy):
(WebCore::RenderLayerBacking::updateClippingLayers):
(WebCore::RenderLayerBacking::backingStoreMemoryEstimate):

  • rendering/RenderLayerBacking.h: rename m_clippingLayer to m_containmentLayer

because it can now either be the clip or the tile cache flattener. Also
a new state property used when creating the main graphics layer.
(WebCore::RenderLayerBacking::hasClippingLayer):
(WebCore::RenderLayerBacking::clippingLayer):
(WebCore::RenderLayerBacking::parentForSublayers):
(WebCore::RenderLayerBacking::hasTileCacheFlatteningLayer):
(WebCore::RenderLayerBacking::tileCacheFlatteningLayer):
(RenderLayerBacking):

LayoutTests:

Reftest to make sure elements can't disappear behind the tile cache.

  • compositing/tile-cache-must-flatten-expected.html: Added.
  • compositing/tile-cache-must-flatten.html: Added.
13:10 Changeset [122151] by commit-queue@webkit.org

Unreviewed, rolling out r122124.
http://trac.webkit.org/changeset/122124
https://bugs.webkit.org/show_bug.cgi?id=90815

It broke NRWT on Qt (Requested by Ossy_HOME on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-09

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort._skipped_file_search_paths):

  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:

(QtPortTest._assert_skipped_path):
(QtPortTest.test_skipped_file_search_path):

12:59 Changeset [122150] by commit-queue@webkit.org

[EFL] Log significant Gamepad API-related events
https://bugs.webkit.org/show_bug.cgi?id=90595

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-09
Reviewed by Antonio Gomes.

Log significant Gamepad API-related events in
GamepadsEfl.

No new tests, no behavior change.

  • platform/efl/GamepadsEfl.cpp:

(WebCore::GamepadDeviceEfl::deviceFile):
(GamepadDeviceEfl):
(WebCore::GamepadDeviceEfl::GamepadDeviceEfl):
(WebCore::GamepadDeviceEfl::readCallback):
(WebCore::GamepadsEfl::registerDevice):
(WebCore::GamepadsEfl::unregisterDevice):

12:58 Changeset [122149] by cevans@google.com

Merge 120731
BUG=132690
Review URL: https://chromiumcodereview.appspot.com/10763008

12:57 Changeset [122148] by cevans@google.com

Merge 120731
BUG=132690
Review URL: https://chromiumcodereview.appspot.com/10750009

12:53 Changeset [122147] by zandobersek@gmail.com

[Gtk] Implement dumpFrameScrollPosition in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=89356

Reviewed by Martin Robinson.

Source/WebKit/gtk:

Add a new method for returning the WebKitDOMDocument that is loaded
in a given frame, webkit_web_frame_get_dom_document.

  • docs/webkitgtk-sections.txt:
  • webkit/webkitwebframe.cpp:

(webkit_web_frame_get_dom_document):

  • webkit/webkitwebframe.h:
  • webkit/webkitwebview.cpp: State explicitly that the document being returned

when calling webkit_web_view_get_dom_document is loaded in the main frame.
Also call the webkit_web_frame_get_dom_document on WebKitWebView's main frame
to get the document.

Tools:

Implement dumpFrameScrollPosition, acquiring the scroll position
through WebKitDOMDOMWindow of the WebKitDOMDocument loaded in the frame
whose scroll position is being dumped.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(dumpFrameScrollPosition):

LayoutTests:

Update baselines for affected tests, removing these tests from the GTK WK2 Skipped list.

  • platform/gtk-wk2/Skipped:
  • platform/gtk/css2.1/20110323/abspos-containing-block-initial-001-expected.txt:
  • platform/gtk/fast/block/positioning/rtl-fixed-positioning-expected.txt:
  • platform/gtk/fast/block/positioning/vertical-rl/fixed-positioning-expected.txt:
  • platform/gtk/fast/dom/focus-contenteditable-expected.txt:
  • platform/gtk/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt:
  • platform/gtk/fast/dom/scroll-reveal-left-overflow-expected.txt:
  • platform/gtk/fast/dom/scroll-reveal-top-overflow-expected.txt:
  • platform/gtk/fast/dynamic/anchor-lock-expected.txt:
  • platform/gtk/fast/events/autoscroll-expected.txt:
  • platform/gtk/fast/events/reveal-link-when-focused-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt:
  • platform/gtk/fast/layers/scroll-rect-to-visible-expected.txt:
  • platform/gtk/fast/multicol/scrolling-overflow-expected.txt: Added.
  • platform/gtk/fast/overflow/clip-rects-fixed-ancestor-expected.txt: Added.
  • platform/gtk/fast/overflow/overflow_hidden-expected.txt:
  • platform/gtk/fast/overflow/position-fixed-transform-clipping-expected.txt:
  • platform/gtk/fast/overflow/scrollRevealButton-expected.txt:
  • platform/gtk/fast/repaint/fixed-child-move-after-scroll-expected.txt:
  • platform/gtk/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.txt:
  • platform/gtk/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.txt:
  • platform/gtk/fast/repaint/fixed-expected.txt:
  • platform/gtk/fast/repaint/fixed-move-after-scroll-expected.txt:
  • platform/gtk/fast/repaint/fixed-tranformed-expected.txt:
  • platform/gtk/fast/repaint/repaint-during-scroll-expected.txt:
  • platform/gtk/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt:
  • platform/gtk/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
  • platform/gtk/transforms/2d/transform-fixed-container-expected.txt:
12:53 Changeset [122146] by cevans@google.com

Merge 120845
BUG=132241
Review URL: https://chromiumcodereview.appspot.com/10750008

12:52 Changeset [122145] by simon.fraser@apple.com

Reduce the amount of flashing when falling into tiled layers
https://bugs.webkit.org/show_bug.cgi?id=90808

Reviewed by Dean Jackson.

Implement +prefetchedTiles so that CATiledLayer renders more
tiles at a time, reducing the appearance of flashing.

  • platform/graphics/mac/WebTiledLayer.mm:

(+[WebTiledLayer prefetchedTiles]):

12:51 Changeset [122144] by cevans@google.com

Merge 120845
BUG=132241
Review URL: https://chromiumcodereview.appspot.com/10765006

12:42 Changeset [122143] by cevans@google.com

Merge 121491
BUG=134428
Review URL: https://chromiumcodereview.appspot.com/10762005

12:41 Changeset [122142] by cevans@google.com

Merge 121491
BUG=134428
Review URL: https://chromiumcodereview.appspot.com/10762004

12:39 Changeset [122141] by cevans@google.com

Merge 121388
BUG=134305
Review URL: https://chromiumcodereview.appspot.com/10756010

12:37 Changeset [122140] by cevans@google.com

Merge 121388
BUG=134305
Review URL: https://chromiumcodereview.appspot.com/10763005

12:36 Changeset [122139] by leandrogracia@chromium.org

SurroundingText should not advance character iterators if they are at end.
https://bugs.webkit.org/show_bug.cgi?id=90560

Reviewed by Ryosuke Niwa.

Source/WebCore:

CharacterIterator and BackwardsCharacterIterator try to advance their
internal TextIterator without checking if they already are at end.
This can cause crashes in TextIterator::advance.

Test: platform/chromium/editing/surrounding-text/surrounding-text.html

  • editing/SurroundingText.cpp:

(WebCore::SurroundingText::SurroundingText):
(WebCore::SurroundingText::rangeFromContentOffsets):

Source/WebKit/chromium:

Moving the check for null visible positions to WebCore as it makes no
sense to be in a platform-specific code.

  • src/WebSurroundingText.cpp:

(WebKit::WebSurroundingText::initialize):

LayoutTests:

Add a new test case where character iterators are already at end when
trying to advance. This was caught by Chromium's address sanitizer
here: http://code.google.com/p/chromium/issues/detail?id=135705

  • platform/chromium/editing/surrounding-text/surrounding-text-expected.txt:
  • platform/chromium/editing/surrounding-text/surrounding-text.html:
12:33 Changeset [122138] by cevans@google.com

Merge 121031
BUG=134123
Review URL: https://chromiumcodereview.appspot.com/10750006

12:31 Changeset [122137] by cevans@google.com

Merge 121031
BUG=134123
Review URL: https://chromiumcodereview.appspot.com/10757006

12:27 Changeset [122136] by commit-queue@webkit.org

[EFL] [WK2] ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key)
https://bugs.webkit.org/show_bug.cgi?id=90464

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-09
Reviewed by Daniel Bates.

HashMap has the property that 0 is the empty value for integer
keys, so do not use 0 as a key in the HashMap.

  • Platform/efl/WorkQueueEfl.cpp:

(WorkQueue::dispatchAfterDelay):

12:27 Changeset [122135] by commit-queue@webkit.org

[BlackBerry] meta viewport initial-scale doesn't factor in device pixel ratio
https://bugs.webkit.org/show_bug.cgi?id=90575

Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-07-09
Reviewed by Rob Buis.

.:

Add a manual test to verify wide content doesn't interfere
with initial-scale calculations.

Internal review from Konrad Piascik.

  • ManualTests/blackberry/meta-viewport-initial-scale-wide-content.html: Added.

Source/WebKit/blackberry:

Refactor meta viewport handling to multiply the developer
specified scale properties by the devicePixelRatio. This
required moving the setting of these values until after
the call to computeViewportAttributes.

This fixes an isssue where content wider than the meta viewport
would case a zoom-out-to-fit scenario because we misinterpreted
the specified initial-scale.

New test to verify wide content doesn't affect initial-scale:
ManualTests/blackberry/meta-viewport-initial-scale-wide-content.html

Internal review from Konrad Piascik, Arvid Nilsson.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
(BlackBerry::WebKit::WebPagePrivate::dispatchViewportPropertiesDidChange):

12:25 Changeset [122134] by commit-queue@webkit.org

[EFL] [WK2] Ecore errors from ecore_evas_screen_geometry_get()
https://bugs.webkit.org/show_bug.cgi?id=90609

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-09
Reviewed by Daniel Bates.

Do not call ecore_evas_screen_geometry_get() if ecoreEvas is null.

No new tests. This patch doesn't change behavior.

  • platform/efl/PlatformScreenEfl.cpp:

(WebCore::screenRect): Early return if Evas is null.

12:19 Changeset [122133] by cevans@google.com

Merge 121001
BUG=133418
Review URL: https://chromiumcodereview.appspot.com/10729003

12:18 Changeset [122132] by rafaelw@chromium.org

Unreviewed gardening. Update TestExpectations after filename change in r122109.

  • platform/chromium/TestExpectations:
12:17 Changeset [122131] by cevans@google.com

Merge 121001
BUG=133418
Review URL: https://chromiumcodereview.appspot.com/10764007

12:16 Changeset [122130] by achicu@adobe.com

[CSS Filters] Blur filter is not repainted correctly when applied on a parent of a fixed element
https://bugs.webkit.org/show_bug.cgi?id=90087

Reviewed by Simon Fraser.

Source/WebCore:

Added a new method, RenderLayer::hasAncestorWithFilterOutsets, to check that there's no filter with outsets (ie. blur)
applied on top level fixed positioned elements, nor any of its parent layers. In the event of a blur filter we need to
disable the fast scrolling optimization, otherwise the outsets of the filter will be carried around the page and
repainting will not work correctly.

Tests: css3/filters/blur-filter-page-scroll-parents.html

css3/filters/blur-filter-page-scroll-self.html

  • page/FrameView.cpp:

(WebCore::FrameView::scrollContentsFastPath):

  • rendering/RenderLayer.cpp:

(WebCore):
(WebCore::RenderLayer::hasAncestorWithFilterOutsets):

  • rendering/RenderLayer.h:

(RenderLayer):

LayoutTests:

Added two new tests to check that we disable fast path scrolling for fixed positioned
elements that have blur applied on them or any of the parent layers.

  • css3/filters/blur-filter-page-scroll-parents.html: Added.
  • css3/filters/blur-filter-page-scroll-self.html: Added.
  • platform/chromium/css3/filters/blur-filter-page-scroll-parents-expected.png: Added.
  • platform/chromium/css3/filters/blur-filter-page-scroll-parents-expected.txt: Added.
  • platform/chromium/css3/filters/blur-filter-page-scroll-self-expected.png: Added.
  • platform/chromium/css3/filters/blur-filter-page-scroll-self-expected.txt: Added.
  • platform/mac/css3/filters/blur-filter-page-scroll-parents-expected.png: Added.
  • platform/mac/css3/filters/blur-filter-page-scroll-parents-expected.txt: Added.
  • platform/mac/css3/filters/blur-filter-page-scroll-self-expected.png: Added.
  • platform/mac/css3/filters/blur-filter-page-scroll-self-expected.txt: Added.
  • platform/qt/Skipped: Qt needs platform results.
12:06 Changeset [122129] by cevans@google.com

Merge 120862
BUG=130595
Review URL: https://chromiumcodereview.appspot.com/10764006

12:04 Changeset [122128] by cevans@google.com

Merge 120862
BUG=130595
Review URL: https://chromiumcodereview.appspot.com/10756009

12:04 Changeset [122127] by jsbell@chromium.org

IndexedDB: Empty arrays shouldn't be valid key paths
https://bugs.webkit.org/show_bug.cgi?id=90798

Reviewed by Tony Chang.

Source/WebCore:

Other IDB implementations already enforce this although it is not yet in
the spec (see https://www.w3.org/Bugs/Public/show_bug.cgi?id=17657). If an
empty array is passed as the key path arg to IDBDatabase.createObjectStore()
or IDBObjectStore.createIndex(), a SYNTAX_ERR DOMException is now thrown.

Test: storage/indexeddb/keypath-arrays.html

storage/indexeddb/keypath-basics.html

  • Modules/indexeddb/IDBKeyPath.cpp:

(WebCore::IDBKeyPath::isValid): Test for empty array.

LayoutTests:

  • storage/indexeddb/keypath-arrays-expected.txt:
  • storage/indexeddb/keypath-basics-expected.txt:
  • storage/indexeddb/resources/keypath-arrays.js:

(openSuccess.request.onsuccess):
(openSuccess):

  • storage/indexeddb/resources/keypath-basics.js:
11:58 Changeset [122126] by cevans@google.com

Merge 120761
BUG=129936
Review URL: https://chromiumcodereview.appspot.com/10763003

11:57 Changeset [122125] by cevans@google.com

Merge 120761
BUG=129936
Review URL: https://chromiumcodereview.appspot.com/10765005

11:53 Changeset [122124] by commit-queue@webkit.org

[Qt][NRWT] Enable cascaded TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=89108

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-07-09
Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort.expectations_files):

  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:

(QtPortTest._assert_expectations_files):
(QtPortTest.test_expectations_files):

11:52 Changeset [122123] by cevans@google.com

Merge 120801
BUG=129898
Review URL: https://chromiumcodereview.appspot.com/10759003

11:50 Changeset [122122] by cevans@google.com

Merge 120801
BUG=129898
Review URL: https://chromiumcodereview.appspot.com/10770002

11:48 Changeset [122121] by cevans@google.com

Merge 121160
BUG=128151
Review URL: https://chromiumcodereview.appspot.com/10748005

11:37 Changeset [122120] by danakj@chromium.org

[chromium] Create render surfaces on main thread only for the current frame
https://bugs.webkit.org/show_bug.cgi?id=89793

Reviewed by Adrienne Walker.

Source/WebCore:

Previously we would create render surfaces for animating layers
in the main thread since these layers might have a surface on impl,
in order to assist culling. This makes it very difficult to estimate
how much texture memory is needed for RenderSurfaces on the main
thread, in order to keep contents+surface memory below our limit.

Here we stop doing this, and create RenderSurfaces on both threads
under the same conditions, so main thread has surfaces only if the
layers in its current frame demand them. While this may reduce
paint culling within an animating subtree, this seems like an edge
case and knowing the amount of surface memory needed for the frame
is important.

Animation tests in CCLayerTreeHostCommonTest used to verify that these
layers got surfaces, so now no longer do. Creation of surfaces under
other conditions is covered by other CCLayerTreeHostCommonTests.

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::subtreeShouldRenderToSeparateSurface):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostCommonTest.cpp:
11:32 Changeset [122119] by rniwa@webkit.org

Mac build fix after r122116.

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
11:25 Changeset [122118] by rniwa@webkit.org

EFL build fix after r122115.

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::create):

11:25 Changeset [122117] by mitz@apple.com

Fixed clean builds of the All target in the DumpRenderTree project.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Let Xcode know that the

DumpRenderTree Perl Support target depends on the DumpRenderTree target.

11:00 Changeset [122116] by commit-queue@webkit.org

Make GC3D and E3D more maintainable for GLES platforms
https://bugs.webkit.org/show_bug.cgi?id=90567

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-09
Reviewed by Rob Buis.

This patch cleans up code for WebGL on OpenGLES platforms which use
GraphicsContext3DOpenGL* and Extensions3DOpenGL*. Although
GraphicsContext3DOpenGL was already split into GraphicsContext3DOpenGL,
GraphicsContext3DOpenGLCommon, and GraphicsContext3DOpenGLES, this patch
is an attempt to refactor this code in a way that will help BlackBerry and
other teams support WebGL on mobile platforms with as little use of
"#IF USE(OPENGL_ES_2)" in common code as possible. Also included is the
separation of Extensions3DOpenGL into Extensions3DOpenGLCommon,
Extensions3DOpenGL, and Extensions3DOpenGLES as well as the introduction
of OpenGLESShims.

This patch is created in large part by Jonathan Feldstein.

No new tests: no new behaviour.

  • PlatformBlackBerry.cmake: Recognize BlackBerry as OPENGL ES, add new files to build
  • Target.pri: Add new Extensions3DOpenGL* to WebGL builds
  • platform/graphics/GraphicsContext3D.h: Add validateDepthStencil, make systemAllowsMultisamplingOnATICards a a member function.

(WebCore):

  • platform/graphics/OpenGLESShims.h: Added.
  • platform/graphics/opengl/Extensions3DOpenGL.cpp: Move code to Extensions3DOpenGLCommon where possible

(WebCore::Extensions3DOpenGL::Extensions3DOpenGL): Reflect that it is now inherits Extensions3DCommon
(WebCore::Extensions3DOpenGL::supportsExtension): Contains OpenGL specific code from supports
(WebCore):
(WebCore::Extensions3DOpenGL::getExtensions): Returns a list of extensions

  • platform/graphics/opengl/Extensions3DOpenGL.h: Remove functions now in Extensions3DOpenGLCommon

(WebCore):
(Extensions3DOpenGL):

  • platform/graphics/opengl/Extensions3DOpenGLCommon.cpp: Added.

(WebCore):
(WebCore::Extensions3DOpenGLCommon::Extensions3DOpenGLCommon):
(WebCore::Extensions3DOpenGLCommon::~Extensions3DOpenGLCommon):
(WebCore::Extensions3DOpenGLCommon::supports):
(WebCore::Extensions3DOpenGLCommon::ensureEnabled):
(WebCore::Extensions3DOpenGLCommon::isEnabled):
(WebCore::Extensions3DOpenGLCommon::getGraphicsResetStatusARB):
(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE): Existed before, but did nothing. Now does what is says it does.
(WebCore::Extensions3DOpenGLCommon::initializeAvailableExtensions): Moved from Extensions3DOpenGL::supports

  • platform/graphics/opengl/Extensions3DOpenGLCommon.h: Copied from Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.h.

(WebCore):
(Extensions3DOpenGLCommon):

  • platform/graphics/opengl/Extensions3DOpenGLES.cpp: Added.

(WebCore):
(WebCore::Extensions3DOpenGLES::Extensions3DOpenGLES):
(WebCore::Extensions3DOpenGLES::~Extensions3DOpenGLES):
(WebCore::Extensions3DOpenGLES::framebufferTexture2DMultisampleIMG):
(WebCore::Extensions3DOpenGLES::renderbufferStorageMultisampleIMG):
(WebCore::Extensions3DOpenGLES::createVertexArrayOES):
(WebCore::Extensions3DOpenGLES::deleteVertexArrayOES):
(WebCore::Extensions3DOpenGLES::isVertexArrayOES):
(WebCore::Extensions3DOpenGLES::bindVertexArrayOES):
(WebCore::Extensions3DOpenGLES::supportsExtension): Contains OpenGLES specific code from supports
(WebCore::Extensions3DOpenGLES::getExtensions):

  • platform/graphics/opengl/Extensions3DOpenGLES.h: Copied from Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.h.

(WebCore):
(Extensions3DOpenGLES):

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::validateAttributes):
(WebCore):
(WebCore::GraphicsContext3D::renderbufferStorage):
(WebCore::GraphicsContext3D::texImage2D):
(WebCore::GraphicsContext3D::systemAllowsMultisamplingOnATICards): Now a member function.
(WebCore::GraphicsContext3D::getExtensions):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::validateDepthStencil):
(WebCore::GraphicsContext3D::clear):
(WebCore::GraphicsContext3D::isTexture):
(WebCore):
(WebCore::GraphicsContext3D::lineWidth):
(WebCore::GraphicsContext3D::linkProgram):
(WebCore::GraphicsContext3D::pixelStorei):
(WebCore::GraphicsContext3D::polygonOffset):
(WebCore::GraphicsContext3D::readPixels):
(WebCore::GraphicsContext3D::deleteBuffer):

  • platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:

(WebCore::GraphicsContext3D::releaseShaderCompiler):
(WebCore::GraphicsContext3D::readPixelsAndConvertToBGRAIfNecessary):
(WebCore::GraphicsContext3D::validateAttributes):
(WebCore):
(WebCore::GraphicsContext3D::getExtensions):
(WebCore::GraphicsContext3D::systemAllowsMultisamplingOnATICards): Now a member function.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore):
(WebCore::GraphicsContext3D::releaseShaderCompiler):

10:40 Changeset [122115] by rniwa@webkit.org

Make HTMLCollection RefCounted
https://bugs.webkit.org/show_bug.cgi?id=90414

Reviewed by Sam Weinig.

Source/WebCore:

Make HTMLCollection ref counted and stop forwarding ref and deref to its owner (m_base)
so as to align its life time management to that of DynamicNodeList.

After this patch, each HTMLCollection is owned by JSC/V8 and m_cachedCollections in ElementRareData
and m_collection in Document merely hold raw pointers for the caching purpose. These raw pointers
are cleared when each HTMLCollection is destructed via corresponding removeCachedHTMLCollection's.

In the destructor of HTMLCollection, we use the CollectionType to decide whether base() is an element
or an document, and call the appropriate removeCachedHTMLCollection except for WindowNamedItems and
DocumentNamedItems. For those two types, we need to know the atomic string name associated with
the collection just like many DynamicNodeList to remove the cache, so we let HTMLNameCollection
directly call removeWindowNamedItemCache and removeDocumentNamedItemCache. We'll cleanup this mess in
a follow up patch using a nice class hierarchy and virtual destructors.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::getDocumentLinks):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::namedItemGetter):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::nameGetter):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::namedPropertyGetter):

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::openSearchDescriptionURL):
(WebCore):
(WebCore::Document::cachedCollection):
(WebCore::Document::removeCachedHTMLCollection):
(WebCore::Document::images):
(WebCore::Document::applets):
(WebCore::Document::embeds):
(WebCore::Document::plugins):
(WebCore::Document::objects):
(WebCore::Document::scripts):
(WebCore::Document::links):
(WebCore::Document::forms):
(WebCore::Document::anchors):
(WebCore::Document::all):
(WebCore::Document::windowNamedItems):
(WebCore::Document::documentNamedItems):
(WebCore::Document::removeWindowNamedItemCache):
(WebCore::Document::removeDocumentNamedItemCache):

  • dom/Document.h:

(Document):

  • dom/Element.cpp:

(WebCore::Element::ensureCachedHTMLCollection):
(WebCore::ElementRareData::ensureCachedHTMLCollection):
(WebCore::Element::removeCachedHTMLCollection):
(WebCore):

  • dom/Element.h:

(Element):

  • dom/ElementRareData.h:

(ElementRareData):
(WebCore::ElementRareData::cachedHTMLCollection):
(WebCore::ElementRareData::removeCachedHTMLCollection):

  • html/CollectionType.h:

(WebCore): Since WindowNamedItems is not a part of UnnamedDocumentCachedType, we shouldn't addd 1.
(WebCore::isUnnamedDocumentCachedType):
(WebCore::isNodeCollectionType):

  • html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::create):

  • html/HTMLAllCollection.h:

(HTMLAllCollection):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::create):
(WebCore::HTMLCollection::~HTMLCollection):
(WebCore::HTMLCollection::itemAfter):

  • html/HTMLCollection.h:

(WebCore::HTMLCollectionCacheBase::HTMLCollectionCacheBase):
(HTMLCollection):
(WebCore::HTMLCollection::base):

  • html/HTMLDataListElement.cpp:

(WebCore::HTMLDataListElement::options):

  • html/HTMLDataListElement.h:

(HTMLDataListElement):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::children):
(WebCore::HTMLElement::properties):

  • html/HTMLElement.h:

(HTMLElement):

  • html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::elements):

  • html/HTMLFieldSetElement.h:

(HTMLFieldSetElement):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::create):

  • html/HTMLFormCollection.h:

(HTMLFormCollection):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::elements):

  • html/HTMLFormElement.h:

(HTMLFormElement):

  • html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::imageElement):
(WebCore::HTMLMapElement::areas):

  • html/HTMLMapElement.h:

(HTMLMapElement):

  • html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::HTMLNameCollection):
(WebCore::HTMLNameCollection::~HTMLNameCollection):
(WebCore):

  • html/HTMLNameCollection.h:

(WebCore::HTMLNameCollection::create):
(HTMLNameCollection):

  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::create):

  • html/HTMLOptionsCollection.h:

(HTMLOptionsCollection):

  • html/HTMLPropertiesCollection.h:

(HTMLPropertiesCollection):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::selectedOptions):
(WebCore::HTMLSelectElement::options):

  • html/HTMLSelectElement.h:

(HTMLSelectElement):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::rows):
(WebCore::HTMLTableElement::tBodies):

  • html/HTMLTableElement.h:

(HTMLTableElement):

  • html/HTMLTableRowElement.cpp:

(WebCore::HTMLTableRowElement::insertCell):
(WebCore::HTMLTableRowElement::deleteCell):
(WebCore::HTMLTableRowElement::cells):

  • html/HTMLTableRowElement.h:

(HTMLTableRowElement):

  • html/HTMLTableRowsCollection.cpp:

(WebCore::HTMLTableRowsCollection::create):

  • html/HTMLTableRowsCollection.h:

(HTMLTableRowsCollection):

  • html/HTMLTableSectionElement.cpp:

(WebCore::HTMLTableSectionElement::insertRow):
(WebCore::HTMLTableSectionElement::deleteRow):
(WebCore::HTMLTableSectionElement::rows):

  • html/HTMLTableSectionElement.h:

(HTMLTableSectionElement):

Source/WebKit/chromium:

  • src/WebPageSerializer.cpp:

(WebCore::retrieveResourcesForFrame):

  • src/WebPageSerializerImpl.cpp:

(WebKit::WebPageSerializerImpl::collectTargetFrames):

Source/WebKit/win:

  • DOMHTMLClasses.cpp:

(DOMHTMLDocument::forms):
(DOMHTMLSelectElement::options):

10:30 Changeset [122114] by pfeldman@chromium.org

Web Inspector: unindent line ending block upon { hit.
https://bugs.webkit.org/show_bug.cgi?id=90795

Reviewed by Vsevolod Vlasov.

Added block-start / block-end markup into the highlighter.

  • inspector/front-end/SourceCSSTokenizer.js:

(WebInspector.SourceCSSTokenizer.prototype.nextToken):

  • inspector/front-end/SourceCSSTokenizer.re2js:
  • inspector/front-end/SourceJavaScriptTokenizer.js:

(WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):

  • inspector/front-end/SourceJavaScriptTokenizer.re2js:
  • inspector/front-end/TextEditor.js:

(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
(WebInspector.TextEditorMainPanel.prototype._unindentAfterBlock):

10:24 Changeset [122113] by carlosgc@webkit.org

[GTK] Add a setting to enable/disable page cache to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=90773

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_get_enable_page_cache):
(webkit_settings_set_enable_page_cache):

  • UIProcess/API/gtk/WebKitSettings.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings):

09:39 Changeset [122112] by zandobersek@gmail.com

[Gtk] Unskip the CSS Regions layout tests
https://bugs.webkit.org/show_bug.cgi?id=90771

Reviewed by Martin Robinson.

Source/WebKit/gtk:

Add a method to DumpRenderTreeSupportGtk for enabling or disabling
CSS Regions from DumpRenderTree.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::setCSSRegionsEnabled):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Tools:

Use the DumpRenderTreeSupportGtk method for enabling the CSS Regions,
calling it when resetting the defaults in DumpRenderTree or when the
settings value is overriden through the testRunner.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::overridePreference):

LayoutTests:

Unskip CSS Regions tests, updating baselines for the affected tests.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/regions/bottom-overflow-out-of-first-region-expected.png: Added.
  • platform/gtk/fast/regions/bottom-overflow-out-of-first-region-expected.txt:
  • platform/gtk/fast/regions/flow-content-basic-expected.png: Added.
  • platform/gtk/fast/regions/flow-content-basic-expected.txt:
  • platform/gtk/fast/regions/flow-content-basic-vertical-expected.png: Added.
  • platform/gtk/fast/regions/flow-content-basic-vertical-expected.txt:
  • platform/gtk/fast/regions/flow-content-basic-vertical-rl-expected.png: Added.
  • platform/gtk/fast/regions/flow-content-basic-vertical-rl-expected.txt:
  • platform/gtk/fast/regions/flows-dependency-dynamic-remove-expected.png: Added.
  • platform/gtk/fast/regions/flows-dependency-dynamic-remove-expected.txt:
  • platform/gtk/fast/regions/flows-dependency-same-flow-expected.png: Added.
  • platform/gtk/fast/regions/flows-dependency-same-flow-expected.txt:
  • platform/gtk/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Added.
  • platform/gtk/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt:
  • platform/gtk/fast/regions/overflow-in-uniform-regions-dynamic-expected.png: Added.
  • platform/gtk/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt:
  • platform/gtk/fast/regions/overflow-in-variable-width-regions-expected.png: Added.
  • platform/gtk/fast/regions/overflow-in-variable-width-regions-expected.txt:
  • platform/gtk/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png: Added.
  • platform/gtk/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt:
  • platform/gtk/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png: Added.
  • platform/gtk/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt:
  • platform/gtk/fast/regions/overflow-rtl-in-variable-width-regions-expected.png: Added.
  • platform/gtk/fast/regions/overflow-rtl-in-variable-width-regions-expected.txt:
  • platform/gtk/fast/regions/overflow-size-change-in-variable-width-regions-expected.png: Added.
  • platform/gtk/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt:
  • platform/gtk/fast/regions/overflow-size-change-with-stacking-context-expected.png: Added.
  • platform/gtk/fast/regions/overflow-size-change-with-stacking-context-expected.txt:
  • platform/gtk/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.png: Added.
  • platform/gtk/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt:
  • platform/gtk/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.png: Added.
  • platform/gtk/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.txt:
  • platform/gtk/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.png: Added.
  • platform/gtk/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.txt:
  • platform/gtk/fast/regions/percentage-margins-rtl-variable-width-regions-expected.png: Added.
  • platform/gtk/fast/regions/percentage-margins-rtl-variable-width-regions-expected.txt:
  • platform/gtk/fast/regions/percentage-margins-variable-width-regions-expected.png: Added.
  • platform/gtk/fast/regions/percentage-margins-variable-width-regions-expected.txt:
  • platform/gtk/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Added.
  • platform/gtk/fast/regions/region-overflow-auto-overflow-hidden-expected.txt:
  • platform/gtk/fast/regions/region-overflow-auto-overflow-visible-expected.png: Added.
  • platform/gtk/fast/regions/region-overflow-auto-overflow-visible-expected.txt:
  • platform/gtk/fast/regions/region-style-block-background-color-expected.png: Added.
  • platform/gtk/fast/regions/region-style-block-background-color-expected.txt:
  • platform/gtk/fast/regions/region-style-block-background-color2-expected.png: Added.
  • platform/gtk/fast/regions/region-style-block-background-color2-expected.txt:
  • platform/gtk/fast/regions/text-region-split-small-pagination-expected.png: Added.
  • platform/gtk/fast/regions/text-region-split-small-pagination-expected.txt:
  • platform/gtk/fast/regions/top-overflow-out-of-second-region-expected.png: Added.
  • platform/gtk/fast/regions/top-overflow-out-of-second-region-expected.txt:
  • platform/gtk/fast/regions/webkit-flow-double-pagination-float-push-expected.png: Added.
  • platform/gtk/fast/regions/webkit-flow-double-pagination-float-push-expected.txt:
  • platform/gtk/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Added.
  • platform/gtk/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt:
  • platform/gtk/fast/regions/webkit-flow-float-unable-to-push-expected.png: Added.
  • platform/gtk/fast/regions/webkit-flow-float-unable-to-push-expected.txt:
  • platform/gtk/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png: Added.
  • platform/gtk/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt:
  • platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png: Added.
  • platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt:
  • platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.png: Added.
  • platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt:
  • platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.png: Added.
  • platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt:
  • platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
  • platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-in-regions-expected.png:
  • platform/gtk/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
  • platform/gtk/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png:
  • platform/gtk/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
  • platform/gtk/fast/repaint/region-painting-invalidation-expected.png:
  • platform/gtk/fast/repaint/region-painting-invalidation-expected.txt:
  • platform/gtk/fast/repaint/region-painting-via-layout-expected.png:
  • platform/gtk/fast/repaint/region-painting-via-layout-expected.txt:
09:32 Changeset [122111] by commit-queue@webkit.org

[GTK] Memory leak in webkitwebnavigationaction.cpp
https://bugs.webkit.org/show_bug.cgi?id=90787

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-09
Reviewed by Martin Robinson.

Fixed a memory leak in WebKitWebNavigationAction.

  • webkit/webkitwebnavigationaction.cpp:

(webkit_web_navigation_action_finalize): Free the g_strdup()'d string.

08:39 Changeset [122110] by commit-queue@webkit.org

Unreviewed, rolling out r122107.
http://trac.webkit.org/changeset/122107
https://bugs.webkit.org/show_bug.cgi?id=90794

Build failure on Mac debug bots (Requested by falken_ on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-09

.:

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):

  • dom/ContextFeatures.cpp:
  • dom/ContextFeatures.h:
  • html/HTMLDialogElement.cpp: Removed.
  • html/HTMLDialogElement.h: Removed.
  • html/HTMLDialogElement.idl: Removed.
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLTagNames.in:
  • page/DOMWindow.idl:

Source/WebKit/chromium:

  • features.gypi:
  • public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

  • src/WebRuntimeFeatures.cpp:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
08:35 Changeset [122109] by commit-queue@webkit.org

[CSSRegions] Rename NamedFlow::getRegionsByContentNode to NamedFlow::getRegionsByContent
https://bugs.webkit.org/show_bug.cgi?id=90759

Patch by Andrei Onea <onea@adobe.com> on 2012-07-09
Reviewed by Andreas Kling.

Source/WebCore:

Renamed NamedFlow::getRegionsByContentNode to NamedFlow::getRegionsByContent as per CSS Regions spec:
http://www.w3.org/TR/css3-regions/#dom-named-flow

Tests: fast/regions/get-regions-by-content-horiz-bt.html

fast/regions/get-regions-by-content-horiz-tb.html
fast/regions/get-regions-by-content-vert-lr.html
fast/regions/get-regions-by-content-vert-rl.html
fast/regions/get-regions-by-content.html
fast/regions/get-regions-by-content2.html

  • dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::getRegionsByContent):

  • dom/WebKitNamedFlow.h:

(WebKitNamedFlow):

  • dom/WebKitNamedFlow.idl:

LayoutTests:

Renamed test files and functions from 77746: [CSSRegions]Implement NamedFlow::getRegionsByContentNode

  • fast/regions/get-regions-by-content-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-node-expected.txt.
  • fast/regions/get-regions-by-content-horiz-bt-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-node-vert-lr-expected.txt.
  • fast/regions/get-regions-by-content-horiz-bt.html: Renamed from LayoutTests/fast/regions/get-regions-by-content-node-horiz-bt.html.
  • fast/regions/get-regions-by-content-horiz-tb-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-node-horiz-tb-expected.txt.
  • fast/regions/get-regions-by-content-horiz-tb.html: Renamed from LayoutTests/fast/regions/get-regions-by-content-node-horiz-tb.html.
  • fast/regions/get-regions-by-content-vert-lr-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-node-vert-rl-expected.txt.
  • fast/regions/get-regions-by-content-vert-lr.html: Renamed from LayoutTests/fast/regions/get-regions-by-content-node-vert-lr.html.
  • fast/regions/get-regions-by-content-vert-rl-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-node-horiz-bt-expected.txt.
  • fast/regions/get-regions-by-content-vert-rl.html: Renamed from LayoutTests/fast/regions/get-regions-by-content-node-vert-rl.html.
  • fast/regions/get-regions-by-content.html: Renamed from LayoutTests/fast/regions/get-regions-by-content-node.html.
  • fast/regions/get-regions-by-content2-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-node2-expected.txt.
  • fast/regions/get-regions-by-content2.html: Renamed from LayoutTests/fast/regions/get-regions-by-content-node2.html.
08:11 Changeset [122108] by carlosgc@webkit.org

[GTK] Fix inspector detach when inspector was attached by the client
https://bugs.webkit.org/show_bug.cgi?id=90763

Reviewed by Martin Robinson.

When the inspector is detached, we are unconditionally removing it
from the inspected view, but if the inspector was attached by the
client, the parent might be another widget.

  • UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformDetach): Remove the inspector
view from its parent widget.

07:49 FeatureFlags edited by tkent@chromium.org
Add DIALOG_ELEMENT (diff)
07:42 Changeset [122107] by commit-queue@webkit.org

Add ENABLE_DIALOG_ELEMENT and skeleton files
https://bugs.webkit.org/show_bug.cgi?id=90521

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-07-09
Reviewed by Kent Tamura.

.:

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

This adds the ENABLE_DIALOG_ELEMENT feature flag and dummy implementation files for <dialog>. In addition, a runtime feature flag is added.
The feature is diabled by default.

No new tests, as there is no behavior change.

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h: Added a runtime feature flag for dialog.

(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::dialogElementEnabled):
(WebCore::RuntimeEnabledFeatures::setDialogElementEnabled):

  • dom/ContextFeatures.cpp:

(WebCore::ContextFeatures::dialogElementEnabled):
(WebCore):

  • dom/ContextFeatures.h: Added a per-context flag for dialog so that dialog can be disabled in HTMLTagNames.in and DOMWindow.idl when the dialog runtime feature flag is off.
  • html/HTMLDialogElement.cpp: Added.

(WebCore):
(WebCore::HTMLDialogElement::HTMLDialogElement):
(WebCore::HTMLDialogElement::create):
(WebCore::HTMLDialogElement::close):
(WebCore::HTMLDialogElement::show):

  • html/HTMLDialogElement.h: Added.

(WebCore):
(HTMLDialogElement):

  • html/HTMLDialogElement.idl: Added.
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLTagNames.in:
  • page/DOMWindow.idl:

Source/WebKit/chromium:

  • features.gypi:
  • public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableDialogElement):
(WebKit):
(WebKit::WebRuntimeFeatures::isDialogElementEnabled):

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
06:45 Changeset [122106] by pfeldman@chromium.org

Web Inspector: inspector does not reflect newly created text nodes from contenteditable
https://bugs.webkit.org/show_bug.cgi?id=90779

Reviewed by Vsevolod Vlasov.

Source/WebCore:

We need to report first text node as inserted, otherwise we fail to report character data modified on it.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::characterDataModified):

LayoutTests:

  • inspector/elements/insert-node-expected.txt:
  • inspector/elements/insert-node.html:
06:36 Changeset [122105] by caseq@chromium.org

REGRESSION(r121980) Layout Test inspector/timeline/timeline-frames.html started to crash.
https://bugs.webkit.org/show_bug.cgi?id=90747

Reviewed by Pavel Feldman.

Source/WebCore:

  • consider didCancelFrame() call normal if there is no pending frame, remove assertion;
  • always set empty data object for frame records;
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didCancelFrame):
(WebCore::InspectorTimelineAgent::commitFrameRecord):

LayoutTests:

  • remove CRASH expectations for timeline-frames.html
  • platform/chromium/TestExpectations:
05:33 Changeset [122104] by commit-queue@webkit.org

Web Inspector: Add FileContentView for FileSystemView
https://bugs.webkit.org/show_bug.cgi?id=90529

Adding FileContentView to Inspector.
This class provides preview of text files in FileSystem.

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-07-09
Reviewed by Vsevolod Vlasov.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/FileContentView.js: Added.
  • inspector/front-end/FileSystemView.js:

(WebInspector.FileSystemView.prototype.get visibleView):
(WebInspector.FileSystemView.EntryTreeElement.prototype.onselect):
(WebInspector.FileSystemView.EntryTreeElement.prototype._directoryContentReceived):
(WebInspector.FileSystemView.EntryTreeElement.prototype.refresh):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
05:28 Changeset [122103] by carlosgc@webkit.org

[SOUP] Use soup_cookie_jar_is_persistent() to set whether cookie is a session one or not
https://bugs.webkit.org/show_bug.cgi?id=90769

Reviewed by Gustavo Noronha Silva.

It's currently set to false, because there were no API to know
whether cookies were persistent or not. Now that we bumped libsoup
requirements, we can use soup_cookie_jar_is_persistent().

  • platform/network/soup/CookieJarSoup.cpp:

(WebCore::getRawCookies):

04:36 Changeset [122102] by commit-queue@webkit.org

[EFL] Simplify runTest function by defining default arguments.
https://bugs.webkit.org/show_bug.cgi?id=90525

Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-07-09
Reviewed by Chang Shu.

Default arguments will simplify macro RUN_TEST.
Function will only have one mandatory argument, callback test function.
Added static modifiers to callback functions.

  • tests/UnitTestUtils/EWKTestBase.h:

(EWKTestBase):

  • tests/test_ewk_view.cpp:

(ewkViewEditableGetCb):
(TEST):
(ewkViewUriGetCb):

03:52 Changeset [122101] by commit-queue@webkit.org

Web Inspector: Add text file support for FileSystemAgent::requestFileContent
https://bugs.webkit.org/show_bug.cgi?id=90439

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-07-09
Reviewed by Vsevolod Vlasov.

Source/WebCore:

  • inspector/Inspector.json:
  • inspector/InspectorFileSystemAgent.cpp:

(WebCore):
(WebCore::InspectorFileSystemAgent::requestFileContent):

  • inspector/InspectorFileSystemAgent.h:

(InspectorFileSystemAgent):

  • inspector/front-end/FileSystemModel.js:

(WebInspector.FileSystemModel.prototype.requestFileContent):
(WebInspector.FileSystemModel.File.prototype.requestFileContent):
(WebInspector.FileSystemRequestManager.prototype._fileContentReceived):
(WebInspector.FileSystemDispatcher.prototype.fileContentReceived):

LayoutTests:

  • http/tests/inspector/filesystem/read-directory-expected.txt:
  • http/tests/inspector/filesystem/read-file-expected.txt:
  • http/tests/inspector/filesystem/read-file.html:
02:33 Changeset [122100] by mitz@apple.com

Fix the Mac build when codesign_allocate is not installed at /usr/bin.

  • PluginProcess/mac/add-entitlements.sh: Let codesign(1) know where the codesign_allocate

tool is by setting the CODESIGN_ALLOCATE environment variable to its path as obtained with
xcrun.

01:53 Changeset [122099] by morrita@google.com

[Chromium] ContextFeaturesClient::isEnabled is slow
https://bugs.webkit.org/show_bug.cgi?id=90367

Reviewed by Kent Tamura.

Source/WebCore:

  • dom/ContextFeatures.h:

(WebCore::ContextFeaturesClient::urlDidChange): Added.
(WebCore::ContextFeatures::urlDidChange): Added.
(WebCore):

  • dom/Document.cpp:

(WebCore::Document::setURL): Added an urlDidChange() call.

Source/WebKit/chromium:

ContextFeaturesClientImpl::isEnabled touches a heavy part in chrome
where locks are acquired for each invocation.

This change introduces a set of caches to avoid such slow calls.
The cache class ContextFeaturesCache is implemented as a
Supplement of ScriptExecutionContext because the flag bits
depend on the domain of each Document.

  • src/ContextFeaturesClientImpl.cpp:

(ContextFeaturesCache): Added.
(Entry): Added.
(WebKit::ContextFeaturesCache::Entry::Entry):
(WebKit::ContextFeaturesCache::Entry::isEnabled):
(WebKit::ContextFeaturesCache::Entry::set):
(WebKit::ContextFeaturesCache::Entry::needsRefresh):
(WebKit::ContextFeaturesCache::entryFor):
(WebKit):
(WebKit::ContextFeaturesCache::supplementName):
(WebKit::ContextFeaturesCache::from):
(WebKit::ContextFeaturesCache::refreshAgainst):
(WebKit::ContextFeaturesClientImpl::isEnabled):
(WebKit::ContextFeaturesClientImpl::urlDidChange): Added to invoke refrshAgainst.
(WebKit::ContextFeaturesClientImpl::askIfIsEnabled):

  • src/ContextFeaturesClientImpl.h:

(ContextFeaturesClientImpl):

01:36 Changeset [122098] by vsevik@chromium.org

Unreviewed chromium inspector test fix.

  • src/js/Tests.js:

(.TestSuite.prototype.nonAnonymousUISourceCodes_):

01:14 Changeset [122097] by zandobersek@gmail.com

Unreviewed, unskipping CSS Exclusions tests for the Gtk port.
The feature is already enabled for this port and all the tests pass.

  • platform/gtk/TestExpectations:
01:08 Changeset [122096] by commit-queue@webkit.org

[CSSRegions] Implement NamedFlow::firstEmptyRegionIndex attribute
https://bugs.webkit.org/show_bug.cgi?id=90608

Patch by Andrei Onea <onea@adobe.com> on 2012-07-09
Reviewed by Andreas Kling.

Source/WebCore:

Implemented NamedFlow::firstEmptyRegionIndex as per spec: http://www.w3.org/TR/css3-regions/#dom-named-flow

Test: fast/regions/webkit-named-flow-first-empty-region-index.html

  • dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::firstEmptyRegionIndex):
(WebCore):

  • dom/WebKitNamedFlow.h:

(WebKitNamedFlow):

  • dom/WebKitNamedFlow.idl:

LayoutTests:

Added tests for NamedFlow::firstEmptyRegionIndex.

  • fast/regions/webkit-named-flow-first-empty-region-index-expected.txt: Added.
  • fast/regions/webkit-named-flow-first-empty-region-index.html: Added.
00:07 Changeset [122095] by kkristof@inf.u-szeged.hu

[Qt] Unreviewed gardening. Skip the failing test.

  • platform/qt/Skipped:

07/08/12:

23:55 Changeset [122094] by hayato@chromium.org

Unreviewed gardening.
Marking a storage/indexeddb/mozilla/key-requirements.html as flaky on WebKit Win.

  • platform/chromium/TestExpectations:
23:43 Changeset [122093] by kkristof@inf.u-szeged.hu

[Qt] Unreviewed gardening. Skip the new failing test.

  • platform/qt/Skipped:
23:36 Changeset [122092] by fpizlo@apple.com

Unreviewed, checking in platform results.

  • platform/mac/css3/filters/effect-reference-expected.txt: Added.
  • platform/mac/css3/filters/effect-reference-external-expected.txt: Added.
  • platform/mac/css3/filters/effect-reference-hw-expected.txt: Added.
  • platform/mac/css3/filters/effect-reference-ordering-expected.txt: Added.
  • platform/mac/fast/repaint/repaint-during-scroll-with-zoom-expected.txt: Added.
23:33 WebKitGTK/WebKit2Roadmap edited by carlosgc@webkit.org
(diff)
23:31 UsingGitWithWebKit edited by yosin@chromium.org
Fix "Copying file aks svn copy" secion: Change "p" to "--patch" (diff)
23:30 Changeset [122091] by yosin@chromium.org

[Platform-Mac] Derive LocaleMac.{cpp,h} and LocalizedDateMac.cpp from LocaleWin
https://bugs.webkit.org/show_bug.cgi?id=90752

Reviewed by Kent Tamura.

This patch is preparation of introducing LocaleMac class for localize date form.
This patch copies LocaleWin and LocalizedDateWin.cpp as below:

  • LocaleMac.h from LocaleWin.h
  • LocaleMac.mm from LocaliedDateMac.mm
  • LocaliedDateMac.cpp from LocalizedDateWin.cpp

Due by git, diffs are appeared as new thing. I'll do svn copy at landing time.

No new tests. This patch doesn't change behavior.

  • platform/text/mac/LocaleMac.h: Copied from platform/text/LocaleWin.h
  • platform/text/mac/LocaleMac.mm: Copied from platform/text/mac/LocalizedDateMac.mm
  • platform/text/mac/LocalizedDateMac.cpp: Copied from platform/text/LocalizedDateWin.cpp
23:30 WebKitGTK/WebKit2Roadmap edited by carlosgc@webkit.org
(diff)
23:30 WebKitGTK/WebKit2Roadmap edited by carlosgc@webkit.org
(diff)
23:19 Changeset [122090] by rniwa@webkit.org

gcc build fix after r121925.

  • runtime/JSObject.h:

(JSC::JSFinalObject::finishCreation):

23:12 Changeset [122089] by laszlo.1.gombos@nokia.com

Introduce a build flag for low quality JPEG images
https://bugs.webkit.org/show_bug.cgi?id=90748

Reviewed by Adam Barth.

Source/WebCore:

Introduce build options for no JPEG dithering (USE(LOW_QUALITY_IMAGE_NO_JPEG_DITHERING))
and no JPEG fancy upsampling (USE(LOW_QUALITY_IMAGE_NO_JPEG_FANCY_UPSAMPLING)).

No new tests as there is no change in functionality.

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(ditherMode):
(doFancyUpsampling):

Source/WTF:

Turn on the newly introduced flags for android.

  • wtf/Platform.h:
22:10 Changeset [122088] by gyuyoung.kim@samsung.com

Check returned value in BatteryStatus APIs test cases
https://bugs.webkit.org/show_bug.cgi?id=90665

Reviewed by Adam Barth.

It is good to compare with actual values to recognize what is difference.

  • batterystatus/add-listener-from-callback-expected.txt:
  • batterystatus/basic-all-types-of-events-expected.txt:
  • batterystatus/basic-operation-expected.txt:
  • batterystatus/script-tests/add-listener-from-callback.js:

(checkBatteryStatus):

  • batterystatus/script-tests/basic-all-types-of-events.js:

(checkBatteryStatus):

  • batterystatus/script-tests/basic-operation.js:
  • batterystatus/script-tests/updates.js:

(checkBatteryStatus):

  • batterystatus/updates-expected.txt:
21:59 Changeset [122087] by commit-queue@webkit.org

Unreviewed, rolling out r121968.
http://trac.webkit.org/changeset/121968
https://bugs.webkit.org/show_bug.cgi?id=90749

Caused a link error on chromium Win dbg. (Requested by hayato
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-08

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):

  • inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.MemoryBlockViewProperties._initialize):

  • platform/MemoryUsageSupport.cpp:
  • platform/MemoryUsageSupport.h:

(MemoryUsageSupport):

  • platform/chromium/MemoryUsageSupportChromium.cpp:
21:56 Changeset [122086] by mary.wu@torchmobile.com.cn

[BlackBerry] Make setForceDownload a setter method.
https://bugs.webkit.org/show_bug.cgi?id=90591

Reviewed by Rob Buis.

  • platform/network/blackberry/ResourceRequest.h:

(WebCore::ResourceRequest::setForceDownload):

21:54 Changeset [122085] by zandobersek@gmail.com

Unreviewed GTK gardening, remove a redundant baseline for the
http/tests/xmlhttprequest/send-array-buffer.html test,
required after r122074.

  • platform/gtk/http/tests/xmlhttprequest/send-array-buffer-expected.txt: Removed.
21:47 Changeset [122084] by tkent@chromium.org

Unreviewed, rolling out r122076.
http://trac.webkit.org/changeset/122076
https://bugs.webkit.org/show_bug.cgi?id=89560

Broke sheriffbot rollout

  • Scripts/prepare-ChangeLog:

(generateNewChangeLogs):

21:38 Changeset [122083] by hayato@chromium.org

Unreviewed gardening.
Marking a inspector/timeline/timeline-frames.html as a CRASH on WebKit Linux (dbg).

  • platform/chromium/TestExpectations:
21:36 Changeset [122082] by morrita@google.com

Heap-use-after-free in WebCore::RenderObject::destroyAndCleanupAnonymousWrappers
https://bugs.webkit.org/show_bug.cgi?id=90480

Reviewed by Kent Tamura.

Source/WebCore:

If <select> has any insertion point, the attachment phase
unpextedly creates a renderer for distributed node and added to
the renderer of the <select>, which breaks an assumption and
results the crash.

This change tighten the childShouldCreateRenderer() to forbid
child renderers even from distributed nodes.

There is an exception as always: ValidationMessage can create a
ShadowRoot to <select>, which generates usually-forbidden child
renderers. This change introduces HTMLFormControlElement::validationMessageContains()
to let these renderers in.

Test: fast/dom/shadow/insertion-point-list-menu-crash.html

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::validationMessageContains):
(WebCore):

  • html/HTMLFormControlElement.h:

(HTMLFormControlElement):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::childShouldCreateRenderer):

  • html/ValidationMessage.cpp:

(WebCore::ValidationMessage::contains):
(WebCore):

  • html/ValidationMessage.h:

(WebCore):
(ValidationMessage):

LayoutTests:

  • fast/dom/shadow/insertion-point-list-menu-crash-expected.txt: Added.
  • fast/dom/shadow/insertion-point-list-menu-crash.html: Added.
21:30 Changeset [122081] by kseo@webkit.org

Remove unnecessary member HTMLTreeBuilder::m_lastScriptElementStartPosition
https://bugs.webkit.org/show_bug.cgi?id=90726

Reviewed by Adam Barth.

HTMLTreeBuilder::m_lastScriptElementStartPosition is of no use. Currently,
m_lastScriptElementStartPosition is used to store the text position in
"script" start tag, and then the stored position is passed to m_scriptToProcessStartPosition
later in "script" end tag. Because HTMLTreeBuilder handles one script tag at
a time, we can store the text position directly to m_scriptToProcessStartPosition
in "script" start tag.

No behavior change, so no new tests.

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processScriptStartTag):

  • html/parser/HTMLTreeBuilder.h:

(HTMLTreeBuilder):

21:15 Changeset [122080] by hayato@chromium.org

Unreviewed gardening.
Marking a fast/multicol/column-span-parent-continuation-crash.html as a flaky.

  • platform/chromium/TestExpectations:
20:57 Changeset [122079] by pdr@google.com

Refactor RenderSVGShape to not contain fallback code
https://bugs.webkit.org/show_bug.cgi?id=90514

Reviewed by Nikolas Zimmermann.

The interaction between RenderSVGShape and {RenderSVGEllipse, RenderSVGRect}
was too coupled and it was not clear when a path existed or who controlled
falling back to path codepaths in RenderSVGShape.

This patch cleans up RenderSVGShape so that it does not track fallback state
and does not have special handling for creating a shape in strokeContains. Because
some functions of RenderSVGShape can be called without a path existing, each
of these functions has switched to using the path() function which asserts that
a path exists.

There is only one remaining use of hasPath() in RenderSVGShape which I plan
to remove in a followup patch.

This patch also cleans up RenderSVGRect and RenderSVGEllipse. These classes
now handle fallback tracking themselves and choose when to use their optimized
strokeContains codepaths.

No new tests as this is just a refactoring.

  • rendering/svg/RenderSVGEllipse.cpp:

(WebCore::RenderSVGEllipse::RenderSVGEllipse):
(WebCore::RenderSVGEllipse::createShape):
(WebCore::RenderSVGEllipse::objectBoundingBox):
(WebCore::RenderSVGEllipse::strokeBoundingBox):
(WebCore::RenderSVGEllipse::fillShape):
(WebCore::RenderSVGEllipse::strokeShape):
(WebCore::RenderSVGEllipse::shapeDependentStrokeContains):
(WebCore::RenderSVGEllipse::shapeDependentFillContains):

  • rendering/svg/RenderSVGEllipse.h:

(WebCore::RenderSVGEllipse::isEmpty):
(RenderSVGEllipse):

  • rendering/svg/RenderSVGRect.cpp:

(WebCore::RenderSVGRect::RenderSVGRect):
(WebCore::RenderSVGRect::createShape):
(WebCore::RenderSVGRect::objectBoundingBox):
(WebCore::RenderSVGRect::strokeBoundingBox):
(WebCore::RenderSVGRect::fillShape):
(WebCore::RenderSVGRect::strokeShape):
(WebCore::RenderSVGRect::shapeDependentStrokeContains):
(WebCore::RenderSVGRect::shapeDependentFillContains):

  • rendering/svg/RenderSVGRect.h:

(WebCore::RenderSVGRect::isEmpty):
(RenderSVGRect):

  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::RenderSVGShape):
(WebCore::RenderSVGShape::createShape):
(WebCore::RenderSVGShape::isEmpty):
(WebCore::RenderSVGShape::objectBoundingBox):
(WebCore::RenderSVGShape::shapeDependentStrokeContains):
(WebCore::RenderSVGShape::shapeDependentFillContains):
(WebCore::RenderSVGShape::strokeContains):
(WebCore::RenderSVGShape::layout):
(WebCore::RenderSVGShape::hasSmoothStroke):
(WebCore):

  • rendering/svg/RenderSVGShape.h:

(RenderSVGShape):

20:51 Changeset [122078] by commit-queue@webkit.org

[EFL] REGRESSION (r122035): fullscreen/exit-full-screen-iframe.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=90735

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-08
Reviewed by Antonio Gomes.

Keep a reference to the Element passed to enterFullScreenForElement() so
that we can reuse it later in exitFullScreenForElement(). This is needed
because the Element passed to exitFullScreenForElement() may be null.
This fixes the crash for the fullscreen/exit-full-screen-iframe.html
test introduced in r122035.

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::enterFullScreenForElement):
(WebCore::ChromeClientEfl::exitFullScreenForElement):

  • WebCoreSupport/ChromeClientEfl.h:

(ChromeClientEfl):

20:48 Changeset [122077] by leandrogracia@chromium.org

Update the description of LayoutTestController::textSurroundingElement
https://bugs.webkit.org/show_bug.cgi?id=90620

Reviewed by Adam Barth.

Tools:

Rename and fix the description of the method as its behaviour changed
during the review of https://bugs.webkit.org/show_bug.cgi?id=82461

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::textSurroundingNode):

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController):

LayoutTests:

Rename textSurroundingElement to match is real behaviour.

  • platform/chromium/editing/surrounding-text/surrounding-text.html:
20:38 Changeset [122076] by tkent@chromium.org

Improve the template generated by prepare-ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=89560

Reviewed by Ryosuke Niwa.

Produce the following template:

2012-06-20 Kent Tamura <tkent@chromium.org>

Need a short description (Oops!).
Need the bug URL (Oops!).

Reviewed by Ryosuke Niwa.

Additional information of the change such as approach, rationale. Please add per-function descriptions below. (Oops!).

No new tests (Oops!).

  • Scripts/prepare-ChangeLog:

(generateNewChangeLogs):

20:26 Changeset [122075] by hayato@chromium.org

Unreviewed gardening.
Marking a fast/events/display-none-on-focus-crash.html as a flaky.

  • platform/chromium/TestExpectations:
20:09 Changeset [122074] by kinuko@chromium.org

XHR.send should support ArrayBufferView
https://bugs.webkit.org/show_bug.cgi?id=90536

Source/WebCore:

XHR.send should support ArrayBufferView according to the latest draft
and also eventually deprecate ArrayBuffer.
Spec: http://dvcs.w3.org/hg/xhr/raw-file/tip/Overview.html#dom-xmlhttprequest-send

Reviewed by Kenneth Russell.

Test: http/tests/xmlhttprequest/send-array-buffer.html

http/tests/xmlhttprequest/send-data-view.html

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::send):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::sendCallback):

  • xml/XMLHttpRequest.cpp:

(WebCore):
(WebCore::XMLHttpRequest::send):

  • xml/XMLHttpRequest.h:

(XMLHttpRequest):

  • xml/XMLHttpRequest.idl:

LayoutTests:

Reviewed by Kenneth Russell.

  • http/tests/xmlhttprequest/send-array-buffer-expected.txt:
  • http/tests/xmlhttprequest/send-array-buffer.html:
  • http/tests/xmlhttprequest/send-data-view-expected.txt: Added.
  • http/tests/xmlhttprequest/send-data-view.html: Added.
19:42 Changeset [122073] by commit-queue@webkit.org

[EFL] Change notifications directory path of WebKit_INCLUDE_DIRECTORIES in the PlatformEfl.cmake
https://bugs.webkit.org/show_bug.cgi?id=90650

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-07-08
Reviewed by Laszlo Gombos.

Change directory path for including notifications of WebCore
from WebCore/notifications to WebCore/Modules/notifications

  • PlatformEfl.cmake:
19:42 Changeset [122072] by hayato@chromium.org

Unreviewed gardening.
Fix a wrong entry in r122070.

  • platform/chromium/TestExpectations: Replace dont-commit-on-blocked.html with cursor-delete.html.
19:29 Changeset [122071] by hayato@chromium.org

Unreviewed gardening.
Fix a wrong entry in r122064.

  • platform/chromium/TestExpectations:
19:22 Changeset [122070] by hayato@chromium.org

Unreviewed gardening. marking a storage/indexeddb/cursor-delete.html as a flaky crasher after r121629.

  • platform/chromium/TestExpectations:
18:52 Changeset [122069] by hayato@chromium.org

Unreviewed gardening.
Rebaseline after r121917.

  • platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-23-expected.png: Removed.
  • platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-24-expected.png: Removed.
  • platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-68-expected.png: Removed.
  • platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-69-expected.png: Removed.
  • platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-23-expected.png: Removed.
  • platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-24-expected.png: Removed.
  • platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-69-expected.png: Removed.
  • platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-23-expected.png: Removed.
  • platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-24-expected.png: Removed.
  • platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-68-expected.png: Removed.
  • platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-69-expected.png: Removed.
  • platform/chromium-linux-x86/editing/selection/3690703-2-expected.png: Removed.
  • platform/chromium-linux-x86/editing/selection/3690703-expected.png: Removed.
  • platform/chromium-linux-x86/editing/selection/3690719-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css1/formatting_model/floating_elements-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-19b-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-23-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-23-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-24-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-24-expected.txt: Copied from LayoutTests/platform/chromium-mac/css3/selectors3/html/css3-modsel-24-expected.txt.
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-64-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-68-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-68-expected.txt: Copied from LayoutTests/platform/chromium-mac/css3/selectors3/html/css3-modsel-68-expected.txt.
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-69-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-69-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-19b-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-23-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-23-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-24-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-24-expected.txt: Copied from LayoutTests/platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-24-expected.txt.
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-64-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-68-expected.txt: Copied from LayoutTests/platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-68-expected.txt.
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-69-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-69-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-19b-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-23-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-23-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-24-expected.txt: Copied from LayoutTests/platform/chromium-mac/css3/selectors3/xml/css3-modsel-24-expected.txt.
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-64-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-68-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-68-expected.txt: Copied from LayoutTests/platform/chromium-mac/css3/selectors3/xml/css3-modsel-68-expected.txt.
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-69-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-69-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/unicode-bidi-isolate-basic-expected.png:
  • platform/chromium-mac-snowleopard/css3/unicode-bidi-isolate-basic-expected.txt: Copied from LayoutTests/platform/chromium-mac/css3/unicode-bidi-isolate-basic-expected.txt.
  • platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4397952-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/selection-button-text-expected.png:
  • platform/chromium-mac-snowleopard/fast/block/float/float-avoidance-expected.png:
  • platform/chromium-mac-snowleopard/fast/block/positioning/inline-block-relposition-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/continuationCrash-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/margin-top-bottom-dynamic-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/rtl-ordering-expected.png:
  • platform/chromium-mac-snowleopard/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/001-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/basic-buttons-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/blankbuttons-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-cannot-be-nested-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-generated-content-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-positioned-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-sizes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-style-color-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-table-styles-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-text-transform-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-white-space-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/file/file-input-direction-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/file/file-input-disabled-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/file/file-input-pressed-state-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/file/input-file-re-render-expected.png:
  • platform/chromium-mac-snowleopard/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-mac/css1/formatting_model/floating_elements-expected.txt:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-19b-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-23-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-23-expected.txt: Added.
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-24-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-24-expected.txt:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-64-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-68-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-68-expected.txt:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-69-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-69-expected.txt: Added.
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-19b-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-23-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-23-expected.txt: Added.
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-24-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-64-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-68-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-69-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-69-expected.txt: Added.
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-19b-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-23-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-23-expected.txt: Added.
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-24-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-24-expected.txt:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-64-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-68-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-68-expected.txt:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-69-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-69-expected.txt: Added.
  • platform/chromium-mac/css3/unicode-bidi-isolate-basic-expected.png:
  • platform/chromium-mac/css3/unicode-bidi-isolate-basic-expected.txt:
  • platform/chromium-mac/editing/deleting/5144139-2-expected.txt: Added.
  • platform/chromium-mac/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac/editing/selection/3690703-2-expected.txt:
  • platform/chromium-mac/editing/selection/3690703-expected.png:
  • platform/chromium-mac/editing/selection/3690703-expected.txt:
  • platform/chromium-mac/editing/selection/3690719-expected.png:
  • platform/chromium-mac/editing/selection/3690719-expected.txt:
  • platform/chromium-mac/editing/selection/4397952-expected.png:
  • platform/chromium-mac/editing/selection/4397952-expected.txt:
  • platform/chromium-mac/editing/selection/selection-button-text-expected.png:
  • platform/chromium-mac/editing/selection/selection-button-text-expected.txt:
  • platform/chromium-mac/fast/block/float/float-avoidance-expected.png:
  • platform/chromium-mac/fast/block/positioning/inline-block-relposition-expected.png:
  • platform/chromium-mac/fast/block/positioning/inline-block-relposition-expected.txt: Added.
  • platform/chromium-mac/fast/css/continuationCrash-expected.png:
  • platform/chromium-mac/fast/css/continuationCrash-expected.txt:
  • platform/chromium-mac/fast/css/margin-top-bottom-dynamic-expected.png:
  • platform/chromium-mac/fast/css/margin-top-bottom-dynamic-expected.txt:
  • platform/chromium-mac/fast/css/rtl-ordering-expected.png:
  • platform/chromium-mac/fast/css/rtl-ordering-expected.txt:
  • platform/chromium-mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
  • platform/chromium-mac/fast/forms/001-expected.png:
  • platform/chromium-mac/fast/forms/001-expected.txt:
  • platform/chromium-mac/fast/forms/basic-buttons-expected.png:
  • platform/chromium-mac/fast/forms/blankbuttons-expected.png:
  • platform/chromium-mac/fast/forms/blankbuttons-expected.txt:
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-mac/fast/forms/button-cannot-be-nested-expected.png:
  • platform/chromium-mac/fast/forms/button-cannot-be-nested-expected.txt: Added.
  • platform/chromium-mac/fast/forms/button-generated-content-expected.png:
  • platform/chromium-mac/fast/forms/button-generated-content-expected.txt: Added.
  • platform/chromium-mac/fast/forms/button-positioned-expected.png:
  • platform/chromium-mac/fast/forms/button-positioned-expected.txt:
  • platform/chromium-mac/fast/forms/button-sizes-expected.png:
  • platform/chromium-mac/fast/forms/button-sizes-expected.txt:
  • platform/chromium-mac/fast/forms/button-style-color-expected.png:
  • platform/chromium-mac/fast/forms/button-style-color-expected.txt:
  • platform/chromium-mac/fast/forms/button-table-styles-expected.png:
  • platform/chromium-mac/fast/forms/button-table-styles-expected.txt:
  • platform/chromium-mac/fast/forms/button-text-transform-expected.png:
  • platform/chromium-mac/fast/forms/button-text-transform-expected.txt:
  • platform/chromium-mac/fast/forms/button-white-space-expected.png:
  • platform/chromium-mac/fast/forms/button-white-space-expected.txt: Added.
  • platform/chromium-mac/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-mac/fast/forms/control-restrict-line-height-expected.txt:
  • platform/chromium-mac/fast/forms/file/file-input-direction-expected.png:
  • platform/chromium-mac/fast/forms/file/file-input-direction-expected.txt:
  • platform/chromium-mac/fast/forms/file/file-input-disabled-expected.png:
  • platform/chromium-mac/fast/forms/file/file-input-pressed-state-expected.png:
  • platform/chromium-mac/fast/forms/file/input-file-re-render-expected.png:
  • platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.png:
  • platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.txt: Added.
  • platform/chromium-mac/fast/text/international/text-combine-image-test-expected.png:
  • platform/chromium-mac/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-mac/http/tests/navigation/javascriptlink-frames-expected.txt:
18:47 Changeset [122068] by gyuyoung.kim@samsung.com

[wx] Unreviewed. Fix notificaitons directory path after notifications move.

  • waf/build/settings.py:
18:41 Changeset [122067] by hayato@chromium.org

Unreviewed gardening.
Rebaseline after r121917.

  • platform/chromium-mac-snowleopard/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/formmove3-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/formmove3-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-button-sizes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-first-letter-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-value-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/select-baseline-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/targeted-frame-submission-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-replace-summary-child-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-replace-text-expected.png:
  • platform/chromium-mac-snowleopard/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-button-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-checkbox-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-radio-expected.png:
  • platform/chromium-mac-snowleopard/fast/selectors/064-expected.png:
  • platform/chromium-mac-snowleopard/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/append-cells2-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/remove-td-display-none-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/rowindex-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/rowindex-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-CSS-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-HTML-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-layout-across-linebreak-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-layout-across-linebreak-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-override-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-override-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/hindi-spacing-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/text-spliced-font-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/vertical-text-glyph-test-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/vertical-text-glyph-test-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/text/international/vertical-text-glyph-test-expected.txt.
  • platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
  • platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt.
  • platform/chromium-mac-snowleopard/fullscreen/full-screen-iframe-zIndex-expected.png:
  • platform/chromium-mac-snowleopard/fullscreen/full-screen-remove-ancestor-after-expected.png:
  • platform/chromium-mac-snowleopard/fullscreen/full-screen-zIndex-after-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug138725-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug26178-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug33855-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug39209-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4429-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51727-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug52505-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug52506-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug60749-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug68912-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
  • platform/chromium-mac/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-mac/fast/forms/form-element-geometry-expected.txt:
  • platform/chromium-mac/fast/forms/formmove3-expected.png:
  • platform/chromium-mac/fast/forms/formmove3-expected.txt:
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-mac/fast/forms/input-button-sizes-expected.png:
  • platform/chromium-mac/fast/forms/input-button-sizes-expected.txt:
  • platform/chromium-mac/fast/forms/input-first-letter-expected.png:
  • platform/chromium-mac/fast/forms/input-value-expected.png:
  • platform/chromium-mac/fast/forms/select-baseline-expected.png:
  • platform/chromium-mac/fast/forms/select-baseline-expected.txt: Added.
  • platform/chromium-mac/fast/forms/targeted-frame-submission-expected.png:
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-mac/fast/html/details-replace-summary-child-expected.png:
  • platform/chromium-mac/fast/html/details-replace-text-expected.png:
  • platform/chromium-mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
  • platform/chromium-mac/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-button-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-button-expected.txt:
  • platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.txt:
  • platform/chromium-mac/fast/replaced/width100percent-radio-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-radio-expected.txt:
  • platform/chromium-mac/fast/selectors/064-expected.png:
  • platform/chromium-mac/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png:
  • platform/chromium-mac/fast/table/append-cells2-expected.png:
  • platform/chromium-mac/fast/table/append-cells2-expected.txt: Added.
  • platform/chromium-mac/fast/table/remove-td-display-none-expected.png:
  • platform/chromium-mac/fast/table/remove-td-display-none-expected.txt: Added.
  • platform/chromium-mac/fast/table/rowindex-expected.png:
  • platform/chromium-mac/fast/table/rowindex-expected.txt: Added.
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-CSS-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-CSS-expected.txt:
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-HTML-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-HTML-expected.txt:
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
  • platform/chromium-mac/fast/text/international/bidi-layout-across-linebreak-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-layout-across-linebreak-expected.txt: Added.
  • platform/chromium-mac/fast/text/international/bidi-override-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-override-expected.txt: Added.
  • platform/chromium-mac/fast/text/international/hindi-spacing-expected.png:
  • platform/chromium-mac/fast/text/international/hindi-spacing-expected.txt: Added.
  • platform/chromium-mac/fast/text/international/text-spliced-font-expected.png:
  • platform/chromium-mac/fast/text/international/text-spliced-font-expected.txt:
  • platform/chromium-mac/fast/text/international/vertical-text-glyph-test-expected.png:
  • platform/chromium-mac/fast/text/international/vertical-text-glyph-test-expected.txt:
  • platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
  • platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
  • platform/chromium-mac/fullscreen/full-screen-iframe-zIndex-expected.png:
  • platform/chromium-mac/fullscreen/full-screen-remove-ancestor-after-expected.png:
  • platform/chromium-mac/fullscreen/full-screen-zIndex-after-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug138725-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug138725-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug26178-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug33855-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug39209-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug39209-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug4429-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug51727-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug51727-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug52505-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug52506-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug60749-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug60749-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug68912-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
  • platform/chromium-mac/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-mac/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
  • platform/chromium-mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
  • platform/chromium-mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
18:26 Changeset [122066] by hayato@chromium.org

Unreviewed gardening.
Rebaseline after r121917.

  • platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-mac/svg/custom/inline-svg-in-xhtml-expected.png:
18:20 Changeset [122065] by fpizlo@apple.com

https://bugs.webkit.org/show_bug.cgi?id=90722
https://bugs.webkit.org/show_bug.cgi?id=90742

Unreviewed, skip crashing tests.

  • platform/mac/Skipped:
18:11 Changeset [122064] by hayato@chromium.org

Unreviewed gardening.
https://bugs.webkit.org/show_bug.cgi?id=90741

fast/text-autosizing/simple-paragraph.html (reftest) started to fail after r121907.

  • platform/chromium/TestExpectations: Add IMAGE on Mac.
17:38 Changeset [122063] by hayato@chromium.org

Unreviewed gardening.
Add TIMEOUT for inspector/timeline/timeline-network-received-data.html.

  • platform/chromium/TestExpectations:
17:26 Changeset [122062] by hayato@chromium.org

Unreviewed gardening.
Add TIMEOUT for inspector/debugger/live-edit.html.

  • platform/chromium/TestExpectations:
16:33 Changeset [122061] by fpizlo@apple.com

inspector/profiler/heap-snapshot-comparison-*.html are crashing
https://bugs.webkit.org/show_bug.cgi?id=90722

Unreviewed, skipping another crashing inspector/profiler test and consolidating
the bugs for those tests.

  • platform/mac/Skipped:
03:00 Changeset [122060] by zherczeg@webkit.org

[Qt][ARM] Implementing missing macro assembler instructions after r121925
https://bugs.webkit.org/show_bug.cgi?id=90657

Reviewed by Csaba Osztrogonác.

Implementing convertibleLoadPtr, replaceWithLoad and
replaceWithAddressComputation.

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::replaceWithLoad):
(ARMAssembler):
(JSC::ARMAssembler::replaceWithAddressComputation):

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::convertibleLoadPtr):
(MacroAssemblerARM):

02:04 Changeset [122059] by commit-queue@webkit.org

Web Inspector: CodeGeneratorInspector.py should not generate statements with no effect
https://bugs.webkit.org/show_bug.cgi?id=90697

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-07-08
Reviewed by Vsevolod Vlasov.

Fix to remove the statements with no effect. The check for errors is added only when some valid
statements exist.

No new tests as generator related patch.

  • inspector/CodeGeneratorInspector.py:

(Generator.process_command):

07/07/12:

21:03 Changeset [122058] by commit-queue@webkit.org

[EFL][CMake] Remove non-existent include directory
https://bugs.webkit.org/show_bug.cgi?id=90605

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-07
Reviewed by Kentaro Hara.

  • PlatformEfl.cmake:
18:08 FeatureFlags edited by tkent@chromium.org
Add TEXT_AUTOSIZING (diff)
18:02 Changeset [122057] by commit-queue@webkit.org

[EFL] Fix build break when Accelerated Compositing is on.
https://bugs.webkit.org/show_bug.cgi?id=90718

Unreviewed build fix.

ewk_view_accelerated_compositing_XXX APIs are in ewk_view_private.h

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-07-07

  • WebCoreSupport/PageClientEfl.cpp:

(PageClientEfl::createEvasObjectForAcceleratedCompositing):
(PageClientEfl::acceleratedCompositingContext):

  • WebCoreSupport/PageClientEfl.h:

(PageClientEfl):

15:26 Changeset [122056] by staikos@webkit.org

Detach animation clients properly if we clear the web page pointer.
https://bugs.webkit.org/show_bug.cgi?id=90730

Reviewed by Adam Treat.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::destroyCompositor):

  • Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::~WebPageCompositorPrivate):
(WebKit):
(BlackBerry::WebKit::WebPageCompositorPrivate::detach):
(BlackBerry::WebKit::WebPageCompositorPrivate::setPage):

  • Api/WebPageCompositor_p.h:

(WebPageCompositorPrivate):

13:53 Changeset [122055] by fpizlo@apple.com

inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=90729

Unreviewed, skip crashing test.

  • platform/mac/Skipped:
12:49 Changeset [122054] by zandobersek@gmail.com

REGRESSION (r122035): fullscreen/exit-full-screen-iframe.html failing on GTK Linux 64-bit Release
https://bugs.webkit.org/show_bug.cgi?id=90719

Reviewed by Martin Robinson.

Source/WebKit/gtk:

Follow the approach of the BlackBerry port outlined in r122035, using in exitFullScreenForElement
the fullscreen element to which the reference was saved when enterFullScreenForElement was called.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::exitFullScreenForElement):

LayoutTests:

Remove the crashing test expectation for the affected test.

  • platform/gtk/TestExpectations:
01:27 Changeset [122053] by commit-queue@webkit.org

Fix build with recent clang.
https://bugs.webkit.org/show_bug.cgi?id=90712

Patch by Nuno Lopes <nlopes@apple.com> on 2012-07-07
Reviewed by Alexey Proskuryakov.

  • TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:

(DOMWindowExtensionBasic):

  • TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:

(DOMWindowExtensionNoCache):

  • TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:

(TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):

00:26 Changeset [122052] by fpizlo@apple.com

media/media-blocked-by-beforeload.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=90725

Unreviewed, skip flaky test.

  • platform/mac/Skipped:
00:22 Changeset [122051] by fpizlo@apple.com

compositing/iframes/iframe-size-from-zero.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=90724

Unreviewed, skip flaky test.

  • platform/mac/Skipped:
00:17 Changeset [122050] by fpizlo@apple.com

inspector/debugger/set-breakpoint.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=90723

Unreviewed, skip crashing test.

  • platform/mac/Skipped:
00:13 Changeset [122049] by fpizlo@apple.com

inspector/profiler/heap-snapshot-comparison-show-next.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=90722

Unreviewed, skip crashing test.

  • platform/mac/Skipped:
Note: See TracTimeline for information about the timeline view.