Timeline



Jul 14, 2012:

10:23 PM Changeset in webkit [122678] by fpizlo@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

DFG PutByVal opcodes should accept more than 3 operands
https://bugs.webkit.org/show_bug.cgi?id=91332

Reviewed by Oliver Hunt.

Turned PutByVal/PutByValAlias into var-arg nodes, so that we can give them
4 or more operands in the future.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixDoubleEdge):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::byValIsPure):
(JSC::DFG::Graph::varArgNumChildren):
(Graph):
(JSC::DFG::Graph::numChildren):
(JSC::DFG::Graph::varArgChild):
(JSC::DFG::Graph::child):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

9:02 PM Changeset in webkit [122677] by fpizlo@apple.com
  • 15 edits in trunk/Source/JavaScriptCore

Rationalize and optimize storage allocation
https://bugs.webkit.org/show_bug.cgi?id=91303

Reviewed by Oliver Hunt.

This implements a backwards bump allocator for copied space storage
allocation, shown in pseudo-code below:

pointer bump(size) {

pointer tmp = allocator->remaining;
tmp -= size;
if (tmp < 0)

fail;

allocator->remaining = tmp;
return allocator->payloadEnd - tmp - size;

}

The advantage of this allocator is that it:

  • Only requires one comparison in the common case where size is known to not be huge, and this comparison can be done by checking the sign bit of the subtraction.


  • Can be implemented even when only one register is available. This register is reused for both temporary storage during allocation and for the result.


  • Preserves the behavior that memory in a block is filled in from lowest address to highest address, which allows for a cheap reallocation fast path.


  • Is resilient against the block used for allocation being the last one in virtual memory, thereby otherwise leading to the risk of overflow in the bump pointer, despite only doing one branch.


In order to implement this allocator using the smallest possible chunk
of code, I refactored the copied space code so that all of the allocation
logic is in CopiedAllocator, and all of the state is in either
CopiedBlock or CopiedAllocator. This should make changing the allocation
fast path easier in the future.

In order to do this, I needed to add some new assembler support,
particularly for various forms of add(address, register) and negPtr().

This is performance neutral. The purpose of this change is to facilitate
further inlining of storage allocation without having to reserve
additional registers or emit too much code.

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::addPtr):
(MacroAssembler):
(JSC::MacroAssembler::negPtr):

  • assembler/MacroAssemblerARMv7.h:

(MacroAssemblerARMv7):
(JSC::MacroAssemblerARMv7::add32):

  • assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::add32):
(MacroAssemblerX86):

  • assembler/MacroAssemblerX86_64.h:

(MacroAssemblerX86_64):
(JSC::MacroAssemblerX86_64::addPtr):
(JSC::MacroAssemblerX86_64::negPtr):

  • assembler/X86Assembler.h:

(X86Assembler):
(JSC::X86Assembler::addl_mr):
(JSC::X86Assembler::addq_mr):
(JSC::X86Assembler::negq_r):

  • heap/CopiedAllocator.h:

(CopiedAllocator):
(JSC::CopiedAllocator::isValid):
(JSC::CopiedAllocator::CopiedAllocator):
(JSC::CopiedAllocator::tryAllocate):
(JSC):
(JSC::CopiedAllocator::tryReallocate):
(JSC::CopiedAllocator::forceAllocate):
(JSC::CopiedAllocator::resetCurrentBlock):
(JSC::CopiedAllocator::setCurrentBlock):
(JSC::CopiedAllocator::currentCapacity):

  • heap/CopiedBlock.h:

(CopiedBlock):
(JSC::CopiedBlock::create):
(JSC::CopiedBlock::zeroFillWilderness):
(JSC::CopiedBlock::CopiedBlock):
(JSC::CopiedBlock::payloadEnd):
(JSC):
(JSC::CopiedBlock::payloadCapacity):
(JSC::CopiedBlock::data):
(JSC::CopiedBlock::dataEnd):
(JSC::CopiedBlock::dataSize):
(JSC::CopiedBlock::wilderness):
(JSC::CopiedBlock::wildernessEnd):
(JSC::CopiedBlock::wildernessSize):
(JSC::CopiedBlock::size):

  • heap/CopiedSpace.cpp:

(JSC::CopiedSpace::tryAllocateSlowCase):
(JSC::CopiedSpace::tryAllocateOversize):
(JSC::CopiedSpace::tryReallocate):
(JSC::CopiedSpace::doneFillingBlock):
(JSC::CopiedSpace::doneCopying):

  • heap/CopiedSpace.h:

(CopiedSpace):

  • heap/CopiedSpaceInlineMethods.h:

(JSC::CopiedSpace::startedCopying):
(JSC::CopiedSpace::allocateBlockForCopyingPhase):
(JSC::CopiedSpace::allocateBlock):
(JSC::CopiedSpace::tryAllocate):
(JSC):

  • heap/MarkStack.cpp:

(JSC::SlotVisitor::startCopying):
(JSC::SlotVisitor::allocateNewSpace):
(JSC::SlotVisitor::doneCopying):

  • heap/SlotVisitor.h:

(JSC::SlotVisitor::SlotVisitor):

  • jit/JIT.h:
  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicStorage):
(JSC::JIT::emitAllocateJSArray):

7:19 PM Changeset in webkit [122676] by eric.carlson@apple.com
  • 25 edits in trunk/Source

Enable AVCF hardware video decoding
https://bugs.webkit.org/show_bug.cgi?id=90015
<rdar://problem/10770317>

Reviewed by Anders Carlsson.

Source/WebCore:

  • html/HTMLMediaElement.cpp:

(WebCore):
(WebCore::HTMLMediaElement::mediaPlayerGraphicsDeviceAdapter): New, return the client's graphics

device adapter.

  • html/HTMLMediaElement.h:
  • page/ChromeClient.h:

(WebCore::ChromeClient::graphicsDeviceAdapter): New.

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::graphicsDeviceAdapter): New, ask the media element for the graphics

device adapter.

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h: Soft-link AVCFPlayerSetDirect3DDevice

and AVCFPlayerEnableHardwareAcceleratedVideoDecoderKey.

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::MediaPlayerPrivateAVFoundationCF::createAVAssetForURL): Pass the current d3d9

device interface to the AVFWrapper.

(WebCore::AVFWrapper::createAssetForURL): If the d3d9 device implements IDirect3DDevice9Ex,

tell the AVAsset to enable hardware video decoding.

(WebCore::AVFWrapper::createPlayer): Pass the d3d9 device to the player if it implements IDirect3DDevice9Ex.

  • platform/graphics/ca/win/CACFLayerTreeHost.h:

(WebCore::CACFLayerTreeHost::graphicsDeviceAdapter): New, default implementation.

  • platform/graphics/ca/win/LegacyCACFLayerTreeHost.h:

(WebCore::LegacyCACFLayerTreeHost::graphicsDeviceAdapter): New, default implementation.

  • platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp:

(WebCore::WKCACFViewLayerTreeHost::graphicsDeviceAdapter): New.

  • platform/graphics/ca/win/WKCACFViewLayerTreeHost.h:
  • platform/win/SoftLinking.h: Define SOFT_LINK_DLL_IMPORT_OPTIONAL, SOFT_LINK_LOADED_LIBRARY,

and SOFT_LINK_VARIABLE_DLL_IMPORT_OPTIONAL.

Source/WebKit/win:

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::graphicsDeviceAdapter): New, return the view's graphics adapter.

  • WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

  • WebView.cpp:

(WebView::graphicsDeviceAdapter): New, return the layer tree host's graphics adapter.

  • WebView.h:

(WebCore):
(WebView):

Source/WebKit2:

  • DerivedSources.make: Define HAVE_AVCF if necessary.
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit):
(WebKit::WebChromeClient::graphicsDeviceAdapter): New, return the layer tree host's

graphics adapter.

  • WebProcess/WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

  • WebProcess/WebPage/LayerTreeHost.h:

(WebCore):
(LayerTreeHost):
(WebKit::LayerTreeHost::graphicsDeviceAdapter): New, default implementation.

  • WebProcess/WebPage/ca/win/LayerTreeHostCAWin.h:

(LayerTreeHostCAWin):

4:31 PM Changeset in webkit [122675] by benjamin@webkit.org
  • 6 edits
    1 add in trunk

[Mac] Do not try to update the cache model for every WebPreferences change
https://bugs.webkit.org/show_bug.cgi?id=91302

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-07-14
Reviewed by Joseph Pecoraro.

Source/WebKit/mac:

WebView was listening to any change on any WebPreferences in order to update the cache model. This is unneeded in most cases,
we can just listen to updates of the CacheModel property.

  • WebView/WebPreferences.mm:

(-[WebPreferences initWithIdentifier:]):
(-[WebPreferences _postCacheModelChangedNotification]):
(-[WebPreferences setCacheModel:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(+[WebView initialize]):
(+[WebView _cacheModelChangedNotification:]):

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: Added.

(TestWebKitAPI):
(TestWebKitAPI::TEST):

2:56 PM Changeset in webkit [122674] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix Chromium Mac build failure after r122670.

  • platform/graphics/mac/ComplexTextController.cpp:
2:45 PM Changeset in webkit [122673] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the Snow Leopard build.

  • platform/LocalizedStrings.cpp:

(WebCore::contextMenuItemTagLookUpInDictionary): Fix a typo in the condition so that Snow Leopard
continues to take the expected path.

2:38 PM Changeset in webkit [122672] by rniwa@webkit.org
  • 4 edits
    2 adds in trunk

Accessing the last item in children should be a constant time operation
https://bugs.webkit.org/show_bug.cgi?id=91320

Reviewed by Ojan Vafai.

Source/WebCore:

Traverse nodes from the last item when the target offset we're looking for is closer to the last item
than to the cached item. e.g. if the cached item was at offset 0 in the collection and length was 100,
we should not be looking for the item at offset 95 from the cached item.

Note that this trick can be only used in HTML collection that supports itemBefore and when the length
cache is available.

Also broke shouldSearchFromFirstItem into smaller logical pieces to clarify the intents.

Test: perf/htmlcollection-last-item.html

  • html/HTMLCollection.cpp:

(WebCore):
(WebCore::HTMLCollection::isLastItemCloserThanLastOrCachedItem):
(WebCore::HTMLCollection::isFirstItemCloserThanCachedItem):
(WebCore::HTMLCollection::item):

  • html/HTMLCollection.h:

(HTMLCollection):

LayoutTests:

Added an asymptotic time complexity test.

  • perf/htmlcollection-last-item-expected.txt: Added.
  • perf/htmlcollection-last-item.html: Added.
2:34 PM Changeset in webkit [122671] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the Windows build.

  • platform/network/cf/DNSCFNet.cpp: Fix the condition to take Windows in to account.
2:11 PM Changeset in webkit [122670] by mrowe@apple.com
  • 60 edits in trunk/Source/WebCore

Make it explicit which code paths iOS should use when doing checks based on OS X versions.

Rubber-stamped by David Kilzer.

  • WebCore.exp.in:
  • accessibility/AccessibilityList.h:
  • accessibility/AccessibilityTable.h:
  • accessibility/mac/AXObjectCacheMac.mm:
  • editing/mac/EditorMac.mm:
  • loader/MainResourceLoader.cpp:
  • loader/MainResourceLoader.h:
  • page/AlternativeTextClient.h:
  • page/mac/SettingsMac.mm:
  • platform/LocalizedStrings.cpp:
  • platform/MemoryPressureHandler.cpp:
  • platform/audio/mac/AudioBusMac.mm:
  • platform/graphics/Gradient.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
  • platform/graphics/ca/GraphicsLayerCA.cpp:
  • platform/graphics/ca/PlatformCALayer.h:
  • platform/graphics/ca/mac/PlatformCALayerMac.mm:
  • platform/graphics/ca/mac/TileCache.mm:
  • platform/graphics/cg/GraphicsContextCG.cpp:
  • platform/graphics/cg/ImageBufferCG.cpp:
  • platform/graphics/cg/ImageBufferDataCG.h:
  • platform/graphics/cg/ImageCG.cpp:
  • platform/graphics/cg/ImageSourceCG.cpp:
  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
  • platform/graphics/mac/ComplexTextController.cpp:
  • platform/graphics/mac/ComplexTextControllerCoreText.mm:
  • platform/graphics/mac/FontCacheMac.mm:
  • platform/graphics/mac/FontCustomPlatformData.cpp:
  • platform/graphics/mac/FontMac.mm:
  • platform/graphics/mac/GraphicsContextMac.mm:
  • platform/graphics/mac/SimpleFontDataMac.mm:
  • platform/graphics/mac/WebLayer.h:
  • platform/graphics/mac/WebLayer.mm:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
  • platform/mac/DisplaySleepDisabler.cpp:
  • platform/mac/DisplaySleepDisabler.h:
  • platform/mac/HTMLConverter.h:
  • platform/mac/HTMLConverter.mm:
  • platform/mac/MemoryPressureHandlerMac.mm:
  • platform/mac/SharedTimerMac.mm:
  • platform/mac/SuddenTermination.mm:
  • platform/mac/WebFontCache.mm:
  • platform/network/Credential.h:
  • platform/network/ResourceHandle.h:
  • platform/network/cf/DNSCFNet.cpp:
  • platform/network/cf/ProxyServerCFNet.cpp:
  • platform/network/cf/ResourceRequest.h:
  • platform/network/cf/SocketStreamHandleCFNet.cpp:
  • platform/network/mac/AuthenticationMac.mm:
  • platform/network/mac/CookieStorageMac.mm:
  • platform/network/mac/ResourceHandleMac.mm:
  • platform/network/mac/ResourceRequestMac.mm:
  • platform/network/mac/WebCoreURLResponse.mm:
  • platform/text/TextChecking.h:
  • platform/text/cf/HyphenationCF.cpp:
  • platform/text/mac/HyphenationMac.mm:
  • rendering/RenderLayerBacking.cpp:
  • rendering/RenderLayerCompositor.cpp:
12:28 PM Changeset in webkit [122669] by fpizlo@apple.com
  • 4 edits in trunk/Source/WTF

Unreviewed, build fix.

  • wtf/Assertions.cpp:
  • wtf/Platform.h:
  • wtf/unicode/icu/CollatorICU.cpp:

(WTF::Collator::userDefault):

7:09 AM Changeset in webkit [122668] by allan.jensen@nokia.com
  • 5 edits in trunk/LayoutTests

[Tests] Unskip not failing tests previously relying on LTC::nodesFromRect implementation
https://bugs.webkit.org/show_bug.cgi?id=46600

Reviewed by Ryosuke Niwa.

These tests no longer relies on LayoutTestController.nodesFromRect but on Internals, and should work
in all platforms.

  • platform/chromium/TestExpectations:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
3:53 AM Changeset in webkit [122667] by rniwa@webkit.org
  • 6 edits
    1 delete in trunk

Unreviewed, rolling out r122665.
http://trac.webkit.org/changeset/122665
https://bugs.webkit.org/show_bug.cgi?id=91321

Broke Mac builds (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-14

Source/WebKit/mac:

  • WebView/WebPreferences.mm:

(-[WebPreferences initWithIdentifier:]):
(-[WebPreferences setCacheModel:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(+[WebView initialize]):
(+[WebView _preferencesChangedNotification:]):

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: Removed.
2:50 AM Changeset in webkit [122666] by robert@webkit.org
  • 3 edits in trunk/LayoutTests

Skip test added in r122663 on Qt and GTK

Unreviewed, gardening.

Qt has 1px difference tracked under

https://bugs.webkit.org/show_bug.cgi?id=89597

Gtk has a platform-specific rendering issue with the test.

https://bugs.webkit.org/show_bug.cgi?id=91319

  • platform/gtk/TestExpectations:
  • platform/qt/Skipped:
2:03 AM Changeset in webkit [122665] by benjamin@webkit.org
  • 6 edits
    1 add in trunk

[Mac] Do not try to update the cache model for every WebPreferences change
https://bugs.webkit.org/show_bug.cgi?id=91302

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-07-13
Reviewed by Joseph Pecoraro.

Source/WebKit/mac:

WebView was listening to any change on any WebPreferences in order to update the cache model. This is unneeded in most cases,
we can just listen to updates of the CacheModel property.

  • WebView/WebPreferences.mm:

(-[WebPreferences initWithIdentifier:]):
(-[WebPreferences _postCacheModelChangedNotification]):
(-[WebPreferences setCacheModel:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(+[WebView initialize]):
(+[WebView _cacheModelChangedNotification:]):

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: Added.

(TestWebKitAPI):
(TestWebKitAPI::TEST):

1:59 AM Changeset in webkit [122664] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r122614.
http://trac.webkit.org/changeset/122614
https://bugs.webkit.org/show_bug.cgi?id=91317

Broke performance tests (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-14

  • bindings/v8/V8Binding.cpp:

(WebCore::StringCache::v8ExternalStringSlow):

1:57 AM Changeset in webkit [122663] by robert@webkit.org
  • 3 edits
    2 adds in trunk

CSS 2.1 failure: vertical-align-boxes-001 fails
https://bugs.webkit.org/show_bug.cgi?id=90626

Reviewed by Eric Seidel.

Source/WebCore:

Tests: css2.1/20110323/vertical-align-boxes-001.htm

A percentage value vertical-align is always a percentage of the actual line-height rather than
the margin box per http://www.w3.org/TR/CSS21/visudet.html#propdef-vertical-align: 'Percentages:
refer to the 'line-height' of the element itself'. Confusingly, RenderBox::lineheight() is a
shorthand into the dimensions of the margin box for replaced elements in the other vertical-align
cases, i.e. where it's the margin box that's relevant rather than the 'line-height'. So rather than patch RenderBox's
lineHeight() to somehow consider the percentage cases, just give percentage vertical-align the full computedLineHeight()
rather than lineHeight()'s margin box.

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::verticalPositionForBox):

LayoutTests:

  • css2.1/20110323/vertical-align-boxes-001-expected.html: Added.
  • css2.1/20110323/vertical-align-boxes-001.htm: Added. This patch fixes the 'percentage' case in this test so that it calculates 50% of the line-height of 60px rather than 50% of the img's margin-box of -8px.
1:09 AM Changeset in webkit [122662] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening, marking http/tests/misc/webtiming-origins.html as flaky.

  • platform/gtk/TestExpectations:
12:19 AM Changeset in webkit [122661] by zandobersek@gmail.com
  • 2 edits
    2 adds in trunk/LayoutTests

Unreviewed GTK gardening, adding an image expectation for a test introduced
in r122651. Also creating platform-specific baselines for two File API tests
that behave differently because of function overloading problems but pass otherwise,
and skipping a test for correct viewport of sites with Mobile DTD which GTK port
does not (yet) support.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/files/create-blob-url-crash-expected.txt: Added.
  • platform/gtk/fast/files/url-required-arguments-expected.txt: Added.
12:08 AM Changeset in webkit [122660] by rniwa@webkit.org
  • 11 edits
    2 adds in trunk

Iterating backwards over HTMLCollection is O(n2)
https://bugs.webkit.org/show_bug.cgi?id=91306

Reviewed by Anders Carlsson.

Source/WebCore:

Fixed the bug by introducing itemBefore that iterates nodes backwards to complement itemAfter.
Unfortunately, some HTML collections such as HTMLFormCollection and HTMLTableRowsCollection have
its own itemAfter function and writing an equivalent itemBefore is somewhat tricky. For now,
added a new boolean flag indicating whether a given HTML collection supports itemBefore or not,
and left those HTML collections that override itemAfter alone.

This also paves our way to share more code between DynamicNodeList and HTMLCollection.

Test: perf/htmlcollection-backwards-iteration.html

  • dom/DynamicNodeList.h:

(WebCore::DynamicNodeListCacheBase::DynamicNodeListCacheBase): Takes ItemBeforeSupportType.
(WebCore::DynamicNodeListCacheBase::supportsItemBefore): Added.
(DynamicNodeListCacheBase):
(WebCore::DynamicNodeListCacheBase::setItemCache): Replaced a FIXME by an assertion now that
we can.

  • html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::HTMLAllCollection): Supports itemBefore since it doesn't override
itemAfter.

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::create):
(WebCore::isAcceptableElement): Made it a static local function instead of a static member.
(WebCore::nextNode): Templatized.
(WebCore::itemBeforeOrAfter): Extracted from itemAfter and templatized.
(WebCore::HTMLCollection::itemBefore): Added.
(WebCore::HTMLCollection::itemAfter):
(WebCore::HTMLCollection::shouldSearchFromFirstItem): Added. Determines whether we should reset
the item cache to the first item. We obviously do if the cache is invalid. If the target offset
is after the cached offset, then we shouldn't go back regardless of availability of itemBefore.
Otherwise, we go back to the first item iff itemBefore is not available or the distance from
the cached offset to the target offset is greater than the target offset itself.
(WebCore::HTMLCollection::length):
(WebCore::HTMLCollection::item): Use the term "offset" to match the terminology elsewhere.
(WebCore::HTMLCollection::itemBeforeOrAfterCachedItem): Ditto. Also added the logic to iterate
nodes backwards using itemBefore. Once we're in this branch, we should always find a matching
item since the target offset was less than the cached offset, and offsets are non-negative.
If we had ever reached the end of the loop without finding an item, it indicates that the cache
has been invalid and we have some serious bug elsewhere.

  • html/HTMLCollection.h:

(WebCore::HTMLCollectionCacheBase::HTMLCollectionCacheBase):
(HTMLCollection):

  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::HTMLOptionsCollection): Supports itemBefore since it doesn't
override itemAfter.

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::HTMLFormCollection): Doesn't support itemBefore as it overrides
itemAfter.

  • html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::HTMLNameCollection): Ditto.

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::HTMLPropertiesCollection):

  • html/HTMLTableRowsCollection.cpp:

(WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection):

LayoutTests:

Add an asymptotic time complexity test.

  • perf/htmlcollection-backwards-iteration-expected.txt: Added.
  • perf/htmlcollection-backwards-iteration.html: Added.

Jul 13, 2012:

8:45 PM Changeset in webkit [122659] by dpranke@chromium.org
  • 5 edits in trunk/Tools

run-webkit-test outputs the wrong number of tests executed when some are skipped.
https://bugs.webkit.org/show_bug.cgi?id=89894

Reviewed by Ojan Vafai.

Fix the logging of the actual number of tests run so that tests
that are skipped aren't included.

Also revamp the 'expected' output so we distinguish the number
of tests found from the number of tests run (to account for
--repeat-each and --iterations).

Covered by existing tests.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.prepare_lists_and_print_output):
(Manager._log_num_workers):
(Manager.run):
(Manager._print_result_summary):

  • Scripts/webkitpy/layout_tests/models/result_summary.py:

(ResultSummary.init):
(ResultSummary.add):

  • Scripts/webkitpy/layout_tests/views/printing.py:

(Printer.print_one_line_summary):

  • Scripts/webkitpy/layout_tests/views/printing_unittest.py:

(Testprinter.test_print_one_line_summary):

8:05 PM Changeset in webkit [122658] by commit-queue@webkit.org
  • 10 edits in trunk/Source

[chromium] Add 'self-managed' option to CCPrioritizedTexture to enable render-surface and canvas use cases.
https://bugs.webkit.org/show_bug.cgi?id=91177

Patch by Eric Penner <epenner@google.com> on 2012-07-13
Reviewed by Adrienne Walker.

Source/WebCore:

This makes the render-surface memory use case generic as 'self-managed' textures,
as this use case is popping up in other places (eg. canvases). It's exactly the
same idea except we can have as many place-holders as we want at arbitrary
priorities.

This already tested by the render surface unit tests which now also use the
generic placeholder.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initializeLayerRenderer):
(WebCore::CCLayerTreeHost::updateLayers):
(WebCore::CCLayerTreeHost::setPrioritiesForSurfaces):
(WebCore):
(WebCore::CCLayerTreeHost::setPrioritiesForLayers):
(WebCore::CCLayerTreeHost::prioritizeTextures):
(WebCore::CCLayerTreeHost::calculateMemoryForRenderSurfaces):
(WebCore::CCLayerTreeHost::paintLayerContents):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCPrioritizedTexture.cpp:

(WebCore::CCPrioritizedTexture::CCPrioritizedTexture):
(WebCore::CCPrioritizedTexture::setToSelfManagedMemoryPlaceholder):

  • platform/graphics/chromium/cc/CCPrioritizedTexture.h:

(CCPrioritizedTexture):
(WebCore::CCPrioritizedTexture::setIsSelfManaged):
(WebCore::CCPrioritizedTexture::isSelfManaged):

  • platform/graphics/chromium/cc/CCPrioritizedTextureManager.cpp:

(WebCore::CCPrioritizedTextureManager::prioritizeTextures):
(WebCore::CCPrioritizedTextureManager::acquireBackingTextureIfNeeded):
(WebCore::CCPrioritizedTextureManager::destroyBacking):

  • platform/graphics/chromium/cc/CCPrioritizedTextureManager.h:

(CCPrioritizedTextureManager):
(WebCore::CCPrioritizedTextureManager::memoryForSelfManagedTextures):

Source/WebKit/chromium:

  • tests/CCPrioritizedTextureTest.cpp:

(WTF::TEST_F):

  • tests/TiledLayerChromiumTest.cpp:
7:09 PM Changeset in webkit [122657] by dpranke@chromium.org
  • 2 edits in trunk/Tools

nrwt: actually print the exception name and message for otherwise unhandled exceptions
https://bugs.webkit.org/show_bug.cgi?id=91305

Reviewed by Adam Barth.

Two more places where I was printing the stack trace but not the
exception itself :(. These two spots can't easily be
unit-tested, but I tested them by hand.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(run):
(main):

7:07 PM Changeset in webkit [122656] by tkent@chromium.org
  • 5 edits in trunk

Internals: Clean up the mock PagePopupDriver correctly.
https://bugs.webkit.org/show_bug.cgi?id=91250

Source/WebCore:

Unreviewed, a trivial testing code fix.

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::reset):
Resetting PaePopupDriver here instead of Backup::restoreTo.
Also, close the mock popup before resetting PagePopupDriver by clearing m_pagePopupDriver.

  • testing/MockPagePopupDriver.cpp:

(WebCore::MockPagePopupDriver::~MockPagePopupDriver):
Close the popup.

LayoutTests:

  • platform/chromium/TestExpectations: Remove CRASH expectation for date-apparance.html.
7:03 PM Changeset in webkit [122655] by commit-queue@webkit.org
  • 12 edits in trunk/Source

Remove Widget from screenColorProfile
https://bugs.webkit.org/show_bug.cgi?id=91300

Patch by Tony Payne <tpayne@chromium.org> on 2012-07-13
Reviewed by Adam Barth.

Source/Platform:

  • chromium/public/Platform.h:

(Platform): Updated comment to reflect that we no longer have a type param.

Source/WebCore:

Chromium, the only platform implementing screenColorProfile, does not
need the Widget, so removing for simplicity.

Covered by existing tests.

  • platform/PlatformScreen.h:

(WebCore): Updated comment to remove reference to type param that no
longer exists and removed Widget param.

  • platform/blackberry/PlatformScreenBlackBerry.cpp:

(WebCore::screenColorProfile): Removed widget param.

  • platform/chromium/PlatformScreenChromium.cpp:

(WebCore::screenColorProfile): Removed widget param.

  • platform/efl/PlatformScreenEfl.cpp:

(WebCore::screenColorProfile): Removed widget param.

  • platform/gtk/PlatformScreenGtk.cpp:

(WebCore::screenColorProfile): Removed widget param.

  • platform/image-decoders/ImageDecoder.h:

(WebCore::ImageDecoder::qcmsOutputDeviceProfile): removed param to
match screenColorProfile()'s new spec.

  • platform/mac/PlatformScreenMac.mm:

(WebCore::screenColorProfile): Removed widget param.

  • platform/qt/PlatformScreenQt.cpp:

(WebCore::screenColorProfile): Removed widget param.

  • platform/win/PlatformScreenWin.cpp:

(WebCore::screenColorProfile): Removed widget param.

6:49 PM Changeset in webkit [122654] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk/Source

Source/WebCore: [chromium] Add flushes to CCTextureUpdater::update
https://bugs.webkit.org/show_bug.cgi?id=89035

Patch by Brian Anderson <brianderson@chromium.org> on 2012-07-13
Reviewed by Adrienne Walker.

Automatic flushes are being removed from the command buffer, so
this moves the flushes into the CCTextureUpdater itself.

CCTextureUpdaterTest added to verify texture upload/flushing patterns.

  • platform/graphics/chromium/cc/CCGraphicsContext.h:

(WebCore::CCGraphicsContext::flush):
(CCGraphicsContext):

  • platform/graphics/chromium/cc/CCTextureUpdater.cpp:

(WebCore):
(WebCore::CCTextureUpdater::update): Manual flushes added here.

Source/WebKit/chromium: Add flushes to CCTextureUpdater::update
https://bugs.webkit.org/show_bug.cgi?id=89035

Patch by Brian Anderson <brianderson@chromium.org> on 2012-07-13
Reviewed by Adrienne Walker.

CCTextureUpdaterTest added to verify texture upload/flushing patterns.

  • WebKit.gypi:
  • tests/CCTextureUpdaterTest.cpp: Added.
6:08 PM Changeset in webkit [122653] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

REGRESSION: RenderInline boundingBox ignores relative position offset
https://bugs.webkit.org/show_bug.cgi?id=91168

Patch by Kiran Muppala <cmuppala@apple.com> on 2012-07-13
Reviewed by Simon Fraser.

Source/WebCore:

RenderGeometryMap, used for caching the transform to the view,
expects the first mapping pushed, to be that of the view itself.
RenderInline was instead pushing it's own offset first. Besides
the offset of the view itself was not being pushed.

Relaxed the RenderGeometryMap restriction that the first pushed
step should be of the view. It is sufficient that the view's mapping
is pushed in the first call to pushMappingsToAncestor. Modified
RenderInline to push the offset of the view also to the geometry map.

Test: fast/inline/inline-relative-offset-boundingbox.html

  • rendering/RenderGeometryMap.cpp:

(WebCore::RenderGeometryMap::pushMappingsToAncestor): Add assertion to
check if mapping to view was pushed in first invocation.
(WebCore::RenderGeometryMap::pushView): Correct assertion that checks
if the view's mapping is the first one to be applied.
(WebCore::RenderGeometryMap::stepInserted): Use isRenderView to check if
a mapping step belongs to a view instead of using mapping size.
(WebCore::RenderGeometryMap::stepRemoved): Ditto.

  • rendering/RenderInline.cpp:

(WebCore::(anonymous namespace)::AbsoluteQuadsGeneratorContext::AbsoluteQuadsGeneratorContext):
Push mappings all the way up to and including the view.

LayoutTests:

Add a regression test for boundingBox of an inline element with relative position offsets.

  • fast/inline/inline-relative-offset-boundingbox-expected.txt: Added.
  • fast/inline/inline-relative-offset-boundingbox.html: Added.
6:03 PM Changeset in webkit [122652] by wangxianzhu@chromium.org
  • 43 edits
    1 move
    1 add
    1 delete in trunk/Source

Move WebCore/platform/text/Base64 to WTF/wtf/text
https://bugs.webkit.org/show_bug.cgi?id=91162

Reviewed by Adam Barth.

Source/WebCore:

No new tests. Files moving only.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/websockets/WebSocketHandshake.cpp:

(WebCore::generateSecWebSocketKey):
(WebCore::WebSocketHandshake::getExpectedWebSocketAccept):

  • Target.pri:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • fileapi/FileReaderLoader.cpp:

(WebCore::FileReaderLoader::convertToDataURL):

  • inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::createDigest):

  • inspector/InspectorFileSystemAgent.cpp:

(WebCore):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::cachedResourceContent):
(WebCore::InspectorPageAgent::sharedBufferContent):

  • loader/archive/mhtml/MHTMLArchive.cpp:

(WebCore::MHTMLArchive::generateMHTMLData):

  • loader/archive/mhtml/MHTMLParser.cpp:

(WebCore::MHTMLParser::parseNextPart):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::btoa):
(WebCore::DOMWindow::atob):

  • page/Page.cpp:

(WebCore::Page::userStyleSheetLocationChanged):

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::toDataURL):

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::CGImageToDataURL):

  • platform/graphics/gtk/ImageBufferGtk.cpp:

(WebCore::ImageBuffer::toDataURL):

  • platform/graphics/skia/FontCustomPlatformData.cpp:

(WebCore::createUniqueFontName):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::toDataURL):
(WebCore::ImageDataToDataURL):

  • platform/graphics/win/FontCustomPlatformData.cpp:

(WebCore::createUniqueFontName):

  • platform/graphics/wince/FontCustomPlatformData.cpp:

(WebCore::createUniqueFontName):

  • platform/graphics/wince/ImageBufferWinCE.cpp:
  • platform/graphics/wx/ImageBufferWx.cpp:
  • platform/network/DataURL.cpp:

(WebCore::handleDataURL):

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::applyBasicAuthorizationHeader):

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::applyBasicAuthorizationHeader):

  • platform/network/soup/ResourceHandleSoup.cpp:
  • platform/win/SSLKeyGeneratorWin.cpp:

(WebCore::WebCore::signedPublicKeyAndChallengeString):

Source/WebKit/blackberry:

  • Api/WebKitTextCodec.cpp:

(BlackBerry::WebKit::base64DecodePolicyForWTF):
(BlackBerry::WebKit::base64Decode):
(BlackBerry::WebKit::base64EncodePolicyForWTF):
(BlackBerry::WebKit::base64Encode):

  • Api/WebSettings.cpp:

(BlackBerry::WebKit::WebSettings::setUserStyleSheetString):

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

Source/WTF:

  • GNUmakefile.list.am:
  • WTF.gypi:
  • WTF.pro:
  • WTF.vcproj/WTF.vcproj:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/text/Base64.cpp: Renamed from Source/WebCore/platform/text/Base64.cpp.

(WTF):
(WTF::base64Encode):
(WTF::base64Decode):
(WTF::base64DecodeInternal):

  • wtf/text/Base64.h: Renamed from Source/WebCore/platform/text/Base64.h.

(WTF):
(WTF::base64Encode):

5:52 PM Changeset in webkit [122651] by wangxianzhu@chromium.org
  • 5 edits
    2 adds in trunk

[Chromium] Sometimes bottom of text is truncated when page has a fractional scale
https://bugs.webkit.org/show_bug.cgi?id=88684

Reviewed by Tony Chang.

Source/WebCore:

When the page has a fractional scale, the ascent and descent part of the fonts might be fractional.
If the descent part is rounded down, the bottom of the text might be truncated when displayed
when subpixel text positioning is enabled.
To avoid that, borrow one unit from the ascent when possible.

Test: fast/text/descent-clip-in-scaled-page.html

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:

(WebCore::FontPlatformData::setupPaint): Moved NoPreference handling into querySystemForRenderStyle so that fontRenderStyle() can have actual styles without NoPreference.
(WebCore::FontPlatformData::querySystemForRenderStyle): Added NoPreference handling (moved from setupPaint)

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:

(FontPlatformData):
(WebCore::FontPlatformData::fontRenderStyle): Added to let SimpleFontDataSkia access the font render styles.

  • platform/graphics/skia/SimpleFontDataSkia.cpp:

(WebCore::SimpleFontData::platformInit):

LayoutTests:

New test case.

  • fast/text/descent-clip-in-scaled-page-expected.html: Added.
  • fast/text/descent-clip-in-scaled-page.html: Added.
5:44 PM Changeset in webkit [122650] by commit-queue@webkit.org
  • 19 edits
    1 add in trunk/Source/JavaScriptCore

OfflineASM Pretty printing and commenting enhancements.
https://bugs.webkit.org/show_bug.cgi?id=91281

Patch by Mark Lam <mark.lam@apple.com> on 2012-07-13
Reviewed by Filip Pizlo.

Added some minor pretty printing in the OfflineASM.
Also added infrastruture for adding multiple types of comments and
annotations with the ability to enable/disable them in the generated
output as desired.

  • GNUmakefile.list.am: add new file config.rb.
  • llint/LLIntOfflineAsmConfig.h: Added OFFLINE_ASM_BEGIN, OFFLINE_ASM_END, and OFFLINE_ASM_LOCAL_LABEL macros. This will allow us to redefine these for other backends later.
  • llint/LowLevelInterpreter32_64.asm: Add a small example of instruction annotations for now.
  • llint/LowLevelInterpreter64.asm: Add a small example of instruction annotations for now.
  • offlineasm/armv7.rb: Added handling of annotations.
  • offlineasm/asm.rb: Added machinery to dump the new comments and annotations. Also added some indentations to make the output a little prettier.
  • offlineasm/ast.rb: Added annotation field in class Instruction.
  • offlineasm/backends.rb:
  • offlineasm/config.rb: Added. Currently only contains commenting options. This file is meant to be a centralized place for build config values much like config.h for JavaScriptCore.
  • offlineasm/generate_offset_extractor.rb:
  • offlineasm/instructions.rb:
  • offlineasm/offsets.rb:
  • offlineasm/opt.rb:
  • offlineasm/parser.rb: Parse and record annotations.
  • offlineasm/registers.rb:
  • offlineasm/self_hash.rb:
  • offlineasm/settings.rb:
  • offlineasm/transform.rb:
  • offlineasm/x86.rb: Added handling of annotations.
5:44 PM Changeset in webkit [122649] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove an assertion after r122637.

  • dom/DynamicNodeList.h:

(WebCore::DynamicNodeListCacheBase::shouldInvalidateTypeOnAttributeChange):

5:33 PM Changeset in webkit [122648] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk

Fix for WebContext::getWebCoreStatistics() causes crash if no m_process
https://bugs.webkit.org/show_bug.cgi?id=91116

.:

Patch by Josh Hawn <jhawn@apple.com> on 2012-07-12
Reviewed by Simon Fraser.

  • Source/WebKit2/UIProcess/WebContext.cpp: WebContext::getWebCoreStatistics():

Now invalidates callback if no m_process.

Tools:

Patch by Josh Hawn <jhawn@apple.com> on 2012-07-13
Reviewed by Simon Fraser.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

Added new test file.

  • TestWebKitAPI/Tests/WebKit2/WebCoreStatisticsWithNoWebProcess.cpp: Added.

(TestWebKitAPI::wkContextGetStatisticsCallback):

Tests that callback function receives an error.

(TestWebKitAPI::TEST):

Creates a dummy web context object (no web process).
Calls WKContextGetStatistics with the web context and test callback.
The test callback should get an expected error.

5:15 PM Changeset in webkit [122647] by pierre.rossi@gmail.com
  • 3 edits in trunk/Source/WebCore

[Qt] Improve the mobile theme slightly
https://bugs.webkit.org/show_bug.cgi?id=90806

Reviewed by Kenneth Rohde Christiansen.

Improve drawing of the mobile theme's controls' background.

Ensure the focus ring never appears with the mobile theme, since it
looks bad in combination with the highlights.

No new tests. The painting code from the mobile theme is still
not covered specifically (it will when we revive pixel tests).

  • platform/qt/RenderThemeQtMobile.cpp:

(WebCore):
(WebCore::addPointToOctants): Added. This is simply a helper to avoid

doing too much duplicate work in drawControlBackground.

(WebCore::drawControlBackground): Rely on the octant logic added above

and take the opportunity to increase the granularity.

(WebCore::borderPen):
(WebCore::StylePainterMobile::findLineEdit):
(WebCore::RenderThemeQtMobile::adjustTextFieldStyle):

  • platform/qt/RenderThemeQtMobile.h:

(RenderThemeQtMobile):
(WebCore::RenderThemeQtMobile::supportsFocusRing):

4:55 PM Changeset in webkit [122646] by fpizlo@apple.com
  • 4 edits
    3 adds in trunk

ASSERTION FAILED: use.useKind() != DoubleUse
https://bugs.webkit.org/show_bug.cgi?id=91082

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

The implementation of Branch() was unwisely relying on register allocation state
to decide what speculations to perform. That's never correct.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

LayoutTests:

  • fast/js/dfg-mispredict-variable-but-prove-int-expected.txt: Added.
  • fast/js/dfg-mispredict-variable-but-prove-int.html: Added.
  • fast/js/script-tests/dfg-mispredict-variable-but-prove-int.js: Added.

(foo):

4:39 PM Changeset in webkit [122645] by dpranke@chromium.org
  • 5 edits in trunk/Tools

test-webkitpy: move printing-related code out of the runner
https://bugs.webkit.org/show_bug.cgi?id=91289

Reviewed by Ryosuke Niwa.

More refactoring ... this moves all printing-related stuff out
of runner.py and into printer.py.

No functional changes; covered by existing tests.

  • Scripts/webkitpy/test/main.py:

(Tester._run_tests):

  • Scripts/webkitpy/test/printer.py:

(Printer.init):
(Printer):
(Printer.test_name):
(Printer.print_started_test):
(Printer.print_finished_test):
(Printer.print_result):

  • Scripts/webkitpy/test/runner.py:

(Runner.init):
(Runner.all_test_names):
(Runner.run):

  • Scripts/webkitpy/test/runner_unittest.py:

(RunnerTest.test_regular):
(RunnerTest.test_verbose):
(RunnerTest.test_timing):

4:36 PM Changeset in webkit [122644] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r122640.
http://trac.webkit.org/changeset/122640
https://bugs.webkit.org/show_bug.cgi?id=91298

LLInt apparently does not expect to mark these (Requested by
olliej on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-13

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitStructures):
(JSC::CodeBlock::stronglyVisitStrongReferences):

4:36 PM Changeset in webkit [122643] by dpranke@chromium.org
  • 4 edits
    1 copy in trunk/Tools

webkitpy: split printing/logging code for test-webkitpy out into a new class
https://bugs.webkit.org/show_bug.cgi?id=91282

Reviewed by Ojan Vafai.

This patch is the first step at splitting all of the
printing/logging code out separately from the actual
test-running code.

This is just moving stuff around; no new functionality and no
new tests needed.

  • Scripts/webkitpy/test/finder_unittest.py:

(FinderTest.setUp):

  • Scripts/webkitpy/test/main.py:

(Tester.init):
(Tester._parse_args):
(Tester.run):
(Tester._run_tests):
(Tester._log_exception):

  • Scripts/webkitpy/test/main_unittest.py:

(TesterTest.test_no_tests_found):

  • Scripts/webkitpy/test/printer.py: Added.

(Printer):
(Printer.init):
(Printer.configure):
(Printer.configure.filter):
(_CaptureAndPassThroughStream):
(_CaptureAndPassThroughStream.init):
(_CaptureAndPassThroughStream.write):
(_CaptureAndPassThroughStream._message_is_from_pdb):
(_CaptureAndPassThroughStream.flush):
(_CaptureAndPassThroughStream.getvalue):

4:34 PM Changeset in webkit [122642] by jchaffraix@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove an always-failing table-wrapping check in RenderObject::addChild
https://bugs.webkit.org/show_bug.cgi?id=91286

Reviewed by Eric Seidel.

Due to the structure of the code, this test is always failing (newChild->isTableCell()
is true to get in the branch).

The changeset adding the code didn't add testing so I poundered adding the mentioned test,
which is passing. However the test would need to be blindly changed to be included in our
test harness. I would also expect this code to be exercised by other table tests anyway.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::addChild):
Removed never-reached branch. While at it, removed a 'what' comment in the same file.

4:23 PM Changeset in webkit [122641] by eae@chromium.org
  • 9 edits in trunk/Source/WebCore

Use LayoutBoxExtent for image outsets
https://bugs.webkit.org/show_bug.cgi?id=91166

Reviewed by Tony Chang.

Change RenderStyle and calling code to use LayoutBoxExtent for image
outsets and remove text direction and writing mode versions of the
outline getters from RenderStyle as LayoutBoxExtent provides the same
functionality.

No new tests, no change in functionality.

  • platform/graphics/FractionalLayoutBoxExtent.h:
  • platform/graphics/FractionalLayoutBoxExtent.cpp:

(WebCore::FractionalLayoutBoxExtent::logicalTop):
(WebCore::FractionalLayoutBoxExtent::logicalBottom):
Add logicalTop and logicalBottom methods to go with the existing
logicalLeft and logicalRight ones.

  • platform/graphics/FractionalLayoutRect.h:

(WebCore::FractionalLayoutRect::expand):
Add FractionalLayoutBoxExtent version of expand method.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::addBorderOutsetVisualOverflow):
Change implementation to use the new FractionalLayoutBoxExtent version of
borderImageOutsets and the logicalTop/Bottom/Left/Right methods.

(WebCore::clipRectForNinePieceImageStrip):
Change implementation to use the new FractionalLayoutBoxExtent version of
borderImageOutsets.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::maskClipRect):
Change implementation to use the new FractionalLayoutBoxExtent version of
borderImageOutsets and the new FractionalLayoutRect::expand method.

(WebCore::RenderBox::addVisualEffectOverflow):
Change implementation to use the new FractionalLayoutBoxExtent version of
borderImageOutsets.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintNinePieceImage):
Change implementation to use the new FractionalLayoutBoxExtent version of
borderImageOutsets and the new FractionalLayoutRect::expand method.

  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::imageOutsets):
Change getImageOutsets to return a FractionalLayoutBoxExtent object and
rename to imageOutsets to match the webkit naming convention for getters.

Remove getBorderImageHorizontalOutsets, getBorderImageVerticalOutsets,
getBorderImageInlineDirectionOutsets, getImageHorizontalOutsets,
getImageVerticalOutsets and getBorderImageBlockDirectionOutsets methods
as the same functionality is provided by FractionalLayoutBoxExtent.

4:12 PM Changeset in webkit [122640] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

LLInt fails to mark structures stored in the bytecode
https://bugs.webkit.org/show_bug.cgi?id=91296

Reviewed by Geoffrey Garen.

LLInt stores structures in the bytecode, so we need to visit the appropriate
instructions as we would if we were running in the classic interpreter.
This requires adding additional checks for the LLInt specific opcodes, and
the lint specific variants of operand ordering.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitStructures):
(JSC::CodeBlock::stronglyVisitStrongReferences):

3:57 PM Changeset in webkit [122639] by hyatt@apple.com
  • 5 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=91278
Improve block margin estimation function to account for not having a layout and for quirks mode

Reviewed by Simon Fraser.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::marginBeforeEstimateForChild):
Revise marginBeforeEstimateForChild so that it computes block margins for the grandchild before
recurring. This includes the quirks margin information as well. This ensures that the margins are
up-to-date when checked, even before the object has had its first layout.

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::setMarginStartForChild):
(WebCore::RenderBlock::setMarginEndForChild):
(WebCore::RenderBlock::setMarginBeforeForChild):
(WebCore::RenderBlock::setMarginAfterForChild):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeBlockDirectionMargins):

  • rendering/RenderBox.h:

(RenderBox):
Add consts in order to compile.

3:46 PM Changeset in webkit [122638] by staikos@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Fix crash due to unguarded use of renderer in select
popup.
https://bugs.webkit.org/show_bug.cgi?id=91287

Reviewed by Rob Buis.

No known testcase for this. Found in the wild.

  • WebCoreSupport/SelectPopupClient.cpp:

(WebCore::SelectPopupClient::setValueAndClosePopup):

3:44 PM Changeset in webkit [122637] by rniwa@webkit.org
  • 11 edits in trunk/Source/WebCore

NodeLists should not invalidate on irreleavnt attribute changes
https://bugs.webkit.org/show_bug.cgi?id=91277

Reviewed by Ojan Vafai.

Explicitely check the invalidation type and the changed attribute in NodeListNodeData::invalidateCaches
and ElementRareData::clearHTMLCollectionCaches to only invalidate node lists affected by the change.

Also merged invalidateNodeListsCacheAfterAttributeChanged and invalidateNodeListsCacheAfterChildrenChanged
as invalidateNodeListCachesInAncestors since they're almost identical after r122498.

In addition, moved shouldInvalidateNodeListForType from Document.cpp to DynamicNodeList.h and renamed it to
shouldInvalidateTypeOnAttributeChange since it needs to called in Node.cpp and ElementRareData.h.

  • dom/Attr.cpp:

(WebCore::Attr::setValue):
(WebCore::Attr::childrenChanged):

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::childrenChanged):

  • dom/Document.cpp:

(WebCore::Document::registerNodeListCache): Calls isRootedAtDocument() instead of directly comparing
the value of NodeListRootType in order to prepare for the bug 80269.
(WebCore::Document::unregisterNodeListCache): Ditto.
(WebCore): shouldInvalidateNodeListForType is moved to DynamicNodeList.h
(WebCore::Document::shouldInvalidateNodeListCaches):

  • dom/DynamicNodeList.h:

(DynamicNodeListCacheBase):
(WebCore::DynamicNodeListCacheBase::shouldInvalidateTypeOnAttributeChange): Moved from Document.cpp.

  • dom/Element.cpp:

(WebCore::Element::attributeChanged):

  • dom/ElementRareData.h:

(WebCore::ElementRareData::clearHTMLCollectionCaches): Takes const QualifiedName* to compare against
the invalidation type of HTML collections via shouldInvalidateTypeOnAttributeChange.

  • dom/Node.cpp:

(WebCore::Node::invalidateNodeListCachesInAncestors): Merged invalidateNodeListCachesInAncestors and
invalidateNodeListsCacheAfterChildrenChanged. Also pass attrName to clearHTMLCollectionCaches.
(WebCore::NodeListsNodeData::invalidateCaches): Compares attrName against the invalidation type of
node lists via shouldInvalidateTypeOnAttributeChange.
(WebCore):

  • dom/Node.h:

(Node):

  • dom/NodeRareData.h:

(WebCore::NodeRareData::ensureNodeLists): Merged NodeRareData::createNodeLists.
(WebCore::NodeRareData::clearChildNodeListCache): Moved from Node.cpp.
(NodeRareData):

  • html/HTMLCollection.h:

(HTMLCollectionCacheBase):

3:37 PM Changeset in webkit [122636] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Refactor RenderTable to use the section's iteration functions.
https://bugs.webkit.org/show_bug.cgi?id=89751

Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-07-13
Reviewed by Julien Chaffraix.

Removing anti-pattern wherever possible from RenderTable code. Also, modifying
RenderTable sections' iterations to use helper functions.

No new tests required for this change since no change in behavior is expected.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::addOverflowFromChildren):
(WebCore::RenderTable::setCellLogicalWidths):
(WebCore::RenderTable::outerBorderStart):
(WebCore::RenderTable::outerBorderEnd):
Removed anti-patterns involving iterations over RenderObjects.

(WebCore::RenderTable::outerBorderAfter):
Modified RenderTable sections' iteration to use helper functions.

3:35 PM Changeset in webkit [122635] by enrica@apple.com
  • 2 edits in trunk/Source/WebCore

Threadsafety issues in WebScriptObject
https://bugs.webkit.org/show_bug.cgi?id=90849

Reviewed by Geoff Garen.

Updated fix for this bug. The JSC API lock needs to be acquired also in JSObject.

  • bindings/objc/WebScriptObject.mm:

(-[WebScriptObject JSObject]):

3:25 PM Changeset in webkit [122634] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unskip fast/css/font-face-download-error.html
https://bugs.webkit.org/show_bug.cgi?id=91279

Unreviewed EFL gardening. Unskip passing test
fast/css/font-face-download-error.html

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-13

  • platform/efl/TestExpectations:
3:19 PM Changeset in webkit [122633] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Remove supressions for flashplayer crash
https://bugs.webkit.org/show_bug.cgi?id=91283

Reviewed by Tony Chang.

These tests don't crash any more now that I've corrected the
configuration on the bots.

  • platform/chromium/TestExpectations:
2:29 PM Changeset in webkit [122632] by simonjam@chromium.org
  • 29 edits
    38 deletes in trunk

[Navigation Timing] Imported W3C tests contain duplicates and are DOS formatted
https://bugs.webkit.org/show_bug.cgi?id=91184

Reviewed by Adam Barth.

The upstream 'html5' tests are just duplicates of the 'html' tests.

Tools:

  • Scripts/import-w3c-performance-wg-tests:

LayoutTests:

  • http/tests/w3c/webperf/approved/navigation-timing/html/test_document_readiness_exist.html: Converted to *NIX newline format.
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_navigation_attributes_exist.html:
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_navigation_redirectCount_none.html:
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_navigation_type_backforward.html:
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_navigation_type_enums.html:
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_navigation_type_reload.html:
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_no_previous_document.html:
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_performance_attributes_exist.html:
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_performance_attributes_exist_in_object.html:
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_readwrite.html:
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_attributes_exist.html:
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_attributes_order.html:
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_client_redirect.html:
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_reload.html:
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_server_redirect.html:
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect.html:
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_unique_performance_objects.html:
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_document_open-expected.txt: Removed.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_document_open.html: Removed.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_document_readiness_exist-expected.txt: Removed.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_document_readiness_exist.html: Removed.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_navigate_within_document-expected.txt: Removed.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_navigate_within_document.html: Removed.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_navigation_attributes_exist-expected.txt: Removed.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_navigation_attributes_exist.html: Removed.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_navigation_redirectCount_none-expected.txt: Removed.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_navigation_redirectCount_none.html: Removed.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_navigation_type_backforward-expected.txt: Removed.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_navigation_type_backforward.html: Removed.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_navigation_type_enums-expected.txt: Removed.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_navigation_type_enums.html: Removed.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_navigation_type_reload-expected.txt: Removed.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_navigation_type_reload.html: Removed.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_no_previous_document-expected.txt: Removed.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_no_previous_document.html: Removed.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_performance_attributes_exist-expected.txt: Removed.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_performance_attributes_exist.html: Removed.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_performance_attributes_exist_in_object-expected.txt: Removed.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_performance_attributes_exist_in_object.html: Removed.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_readwrite-expected.txt: Removed.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_readwrite.html: Removed.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_attributes_exist-expected.txt: Removed.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_attributes_exist.html: Removed.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_attributes_order-expected.txt: Removed.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_attributes_order.html: Removed.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_client_redirect-expected.txt: Removed.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_client_redirect.html: Removed.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_reload-expected.txt: Removed.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_reload.html: Removed.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_server_redirect-expected.txt: Removed.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_server_redirect.html: Removed.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_xserver_redirect-expected.txt: Removed.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_xserver_redirect.html: Removed.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_unique_performance_objects-expected.txt: Removed.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_unique_performance_objects.html: Removed.
  • http/tests/w3c/webperf/resources/blank_page_green.htm:
  • http/tests/w3c/webperf/resources/blank_page_green_with_onunload.htm:
  • http/tests/w3c/webperf/resources/blank_page_meta_redirect.htm:
  • http/tests/w3c/webperf/resources/blank_page_unload.htm:
  • http/tests/w3c/webperf/resources/blank_page_yellow.htm:
  • http/tests/w3c/webperf/resources/blank_page_yellow_with_onunload.htm:
  • http/tests/w3c/webperf/resources/pagevistestharness.js:

(pv_test):
(test_feature_exists):
(test_equals):
(add_async_result_assert):
(TabSwitch):

  • http/tests/w3c/webperf/resources/webperftestharness.js:

(test_true):

  • platform/chromium/TestExpectations:
2:16 PM Changeset in webkit [122631] by dpranke@chromium.org
  • 3 edits in trunk/Tools

webkitpy: hide yield_to_caller from callers in MessagePool :)
https://bugs.webkit.org/show_bug.cgi?id=91269

Reviewed by Adam Barth.

yield_to_caller() was an optimization/hack to allow us to run
both manager and worker in a single process/loop without
starving the manager while the worker is running tests. The
worker was required to call yield_to_caller() periodically. It
turns out that I can get equivalent responsiveness by yielding
inside the MessagePool every time the worker posts a message, and this
allows me to no longer need the worker to call the routine. Thus
I rename yield_to_caller() to _yield_to_manager() to be a little
clearer about its purpose.

Tested by existing tests.

  • Scripts/webkitpy/common/message_pool.py:

(_Worker.run):
(_Worker.post):
(_Worker._yield_to_manager):

  • Scripts/webkitpy/layout_tests/controllers/worker.py:

(Worker.handle):

2:10 PM Changeset in webkit [122630] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk

DelayNode doesn't work if delayTime.value == delayTime.maxValue
https://bugs.webkit.org/show_bug.cgi?id=90357

Patch by Raymond Toy <Raymond Toy> on 2012-07-13
Reviewed by Kenneth Russell.

Source/WebCore:

Increase delay buffer size slightly so that the read and write
pointers don't become equal when the delay and the max delay are
the same.

Tests: webaudio/delaynode-max-default-delay.html

webaudio/delaynode-max-nondefault-delay.html

  • Modules/webaudio/DelayDSPKernel.cpp:

(WebCore): Moved SmoothingTimeConstant to WebCore namespace.
(WebCore::DelayDSPKernel::DelayDSPKernel): Add some additional checks to prevent crashes; use bufferLengthForDelay to compute buffer length.
(WebCore::DelayDSPKernel::bufferLengthForDelay): New function to compute buffer length.

  • Modules/webaudio/DelayDSPKernel.h:

(DelayDSPKernel): Declare bufferLengthForDelay.

LayoutTests:

New tests to test the case when the delay node delay equals the
maximum allowed delay. Add one test for the default maximum delay
and a second test with a user-set maximum delay.

  • webaudio/delaynode-max-default-delay-expected.txt: Added.
  • webaudio/delaynode-max-default-delay.html: Added.
  • webaudio/delaynode-max-nondefault-delay-expected.txt: Added.
  • webaudio/delaynode-max-nondefault-delay.html: Added.
2:03 PM Changeset in webkit [122629] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Always aggressively preload on iOS
https://bugs.webkit.org/show_bug.cgi?id=91276

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-07-13
Reviewed by Simon Fraser.

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::preload):

1:45 PM Changeset in webkit [122628] by commit-queue@webkit.org
  • 4 edits
    4 deletes in trunk

Restructure V8Utilities::extractTransferables() with help of toV8Sequence()
https://bugs.webkit.org/show_bug.cgi?id=91208

Patch by Vineet Chaudhary <Vineet> on 2012-07-13
Reviewed by Kentaro Hara.

Source/WebCore:

We can remove the specialised check for MessagePort from V8Utilities::extractTransferables()
using toV8Sequence() as it validates the passed object for sequence type per WebIDL spec.

No new test as just refactoring.
Existing tests under fast/dom/Window/window-* fast/dom/events/*
covers tests.

  • bindings/v8/V8Utilities.cpp:

(WebCore::extractTransferables):

LayoutTests:

We can remove the specialised check for MessagePort from V8Utilities::extractTransferables()
using toV8Sequence() as it validates the passed object for sequence type per WebIDL spec.
Removing port specific expected results.

  • platform/chromium-win/fast/workers/worker-context-multi-port-expected.txt: Removed.
  • platform/chromium-win/fast/workers/worker-multi-port-expected.txt: Removed.
  • platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt: Removed.
  • platform/chromium/fast/events/constructors/message-event-constructor-expected.txt: Removed.
  • platform/chromium/fast/events/message-port-multi-expected.txt: Rebaselined.
1:40 PM Changeset in webkit [122627] by abarth@webkit.org
  • 1 edit
    1 add in trunk/Tools

EWSTools should be able to build a commit-queue instance from scratch
https://bugs.webkit.org/show_bug.cgi?id=91264

Reviewed by Eric Seidel.

I've been using this script to build commit-queue instances on Google
Compute Engine and it seems to work.

  • EWSTools/GoogleComputeEngine/build-commit-queue.sh: Added.
1:37 PM Changeset in webkit [122626] by scheib@chromium.org
  • 6 edits
    4 adds in trunk

Pointer Lock handles disconnected DOM elements
https://bugs.webkit.org/show_bug.cgi?id=77029

Reviewed by Adrienne Walker.

Source/WebCore:

Pointer Lock Controller now checks when elements or documents are
removed, and unlocks if the target element is being removed.

Tests: pointer-lock/locked-element-iframe-removed-from-dom.html

pointer-lock/locked-element-removed-from-dom.html

  • dom/Document.cpp:

(WebCore::Document::detach):

  • dom/Element.cpp:

(WebCore::Element::removedFrom):
(WebCore::Element::webkitRequestPointerLock):

  • page/PointerLockController.cpp:

(WebCore::PointerLockController::requestPointerLock):
(WebCore::PointerLockController::elementRemoved):
(WebCore):
(WebCore::PointerLockController::documentDetached):
(WebCore::PointerLockController::didLosePointerLock):
(WebCore::PointerLockController::enqueueEvent):

  • page/PointerLockController.h:

(WebCore):
(PointerLockController):

LayoutTests:

Two new tests that verify pointer lock is released when the target
is removed from the document.

  • pointer-lock/locked-element-iframe-removed-from-dom-expected.txt: Added.
  • pointer-lock/locked-element-iframe-removed-from-dom.html: Added.
  • pointer-lock/locked-element-removed-from-dom-expected.txt: Added.
  • pointer-lock/locked-element-removed-from-dom.html: Added.
1:35 PM Changeset in webkit [122625] by wjmaclean@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. storage/indexeddb/cursor-key-order.html has starting crashing on occassion.
https://bugs.webkit.org/show_bug.cgi?id=91275

Not sure how far back the crashes go, but happens with reasonably high frequency.

  • platform/chromium/TestExpectations:
1:12 PM Changeset in webkit [122624] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

[BlackBerry] Implement GCActivityCallback with platform timer
https://bugs.webkit.org/show_bug.cgi?id=90175

Patch by Yong Li <yoli@rim.com> on 2012-07-13
Reviewed by Rob Buis.

Implement GCActivityCallback and HeapTimer for BlackBerry port.

  • heap/HeapTimer.cpp:

(JSC):
(JSC::HeapTimer::HeapTimer):
(JSC::HeapTimer::~HeapTimer):
(JSC::HeapTimer::timerDidFire):
(JSC::HeapTimer::synchronize):
(JSC::HeapTimer::invalidate):
(JSC::HeapTimer::didStartVMShutdown):

  • heap/HeapTimer.h:

(HeapTimer):

  • runtime/GCActivityCallbackBlackBerry.cpp:

(JSC):
(JSC::DefaultGCActivityCallback::doWork):
(JSC::DefaultGCActivityCallback::didAllocate):
(JSC::DefaultGCActivityCallback::willCollect):
(JSC::DefaultGCActivityCallback::cancel):

12:58 PM Changeset in webkit [122623] by tony@chromium.org
  • 46 edits
    1 move in trunk/LayoutTests

Move layout checking js script into LayoutTest/resources and generalize
https://bugs.webkit.org/show_bug.cgi?id=91268

Reviewed by Ojan Vafai.

flexbox.js contains helper scripts for verifying the size and position of nodes.
I will be writing similar tests for grid, so move the js file into a location
for sharing and generalize the script.

  • css3/flexbox/align-absolute-child.html: Change include path and call.
  • css3/flexbox/auto-height-dynamic.html:
  • css3/flexbox/columns-auto-size.html:
  • css3/flexbox/flex-algorithm-min-max.html:
  • css3/flexbox/flex-algorithm-with-margins.html:
  • css3/flexbox/flex-algorithm.html:
  • css3/flexbox/flex-align-column.html:
  • css3/flexbox/flex-align-end.html:
  • css3/flexbox/flex-align-max.html:
  • css3/flexbox/flex-align-percent-height.html:
  • css3/flexbox/flex-align-stretch.html:
  • css3/flexbox/flex-align-vertical-writing-mode.html:
  • css3/flexbox/flex-align.html:
  • css3/flexbox/flex-flow-auto-margins.html:
  • css3/flexbox/flex-flow-border.html:
  • css3/flexbox/flex-flow-margins-auto-size.html:
  • css3/flexbox/flex-flow-margins.html:
  • css3/flexbox/flex-flow-orientations.html:
  • css3/flexbox/flex-flow-overflow.html:
  • css3/flexbox/flex-flow-padding.html:
  • css3/flexbox/flex-flow.html:
  • css3/flexbox/flex-item-child-overflow.html:
  • css3/flexbox/flex-item-min-size.html:
  • css3/flexbox/flex-justify-content.html:
  • css3/flexbox/flex-no-flex.html:
  • css3/flexbox/flexitem.html:
  • css3/flexbox/floated-flexbox.html:
  • css3/flexbox/line-wrapping.html:
  • css3/flexbox/multiline-align-content-horizontal-column.html:
  • css3/flexbox/multiline-align-content.html:
  • css3/flexbox/multiline-align-self.html:
  • css3/flexbox/multiline-column-auto.html:
  • css3/flexbox/multiline-justify-content.html:
  • css3/flexbox/multiline-reverse-wrap-overflow.html:
  • css3/flexbox/multiline.html:
  • css3/flexbox/nested-stretch.html:
  • css3/flexbox/orthogonal-flex-directions.html:
  • css3/flexbox/perpendicular-writing-modes-inside-flex-item.html:
  • css3/flexbox/position-absolute-child.html:
  • css3/flexbox/preferred-widths-orthogonal.html:
  • css3/flexbox/preferred-widths.html:
  • css3/flexbox/style-change.html:
  • css3/flexbox/true-centering.html:
  • css3/flexbox/writing-modes.html:
  • resources/check-layout.js: Renamed from LayoutTests/css3/flexbox/resources/flexbox.js.

(.): Rename checkFlexboxen to checkLayout that takes a CSS selector. Hide functions in a closure.

12:54 PM Changeset in webkit [122622] by dgrogan@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

IndexedDB: Re-enable indexeddb in test_shell
https://bugs.webkit.org/show_bug.cgi?id=91161

Reviewed by Tony Chang.

IDB used to be allowed to run if webView->permissionClient() was NULL,
as is the case in test_shell. This was inadvertently changed in
http://wkb.ug/90310.

We still don't have an automated test for this (http://crbug.com/113738)
Tested manually:

  • In test_shell:

1) Open an IDB page
2) Verify IDB has permission to open a DB

  • In chrome:

1) Open an IDB page
2) Verify IDB has permission to open a DB
3) Revoke IDB permissions in chrome://chrome/settings/content
4) Reload the IDB page
5) Verify IDB doesn't have permission to open a DB

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::allowIndexedDB):

12:48 PM Changeset in webkit [122621] by rniwa@webkit.org
  • 16 edits in trunk/Source/WebCore

HTMLCollection should use DynamicNodeList's invalidation model
https://bugs.webkit.org/show_bug.cgi?id=90326

Reviewed by Anders Carlsson.

Make HTMLCollection invalidated upon attribute and children changes instead of invalidating it on demand
by comparing DOM tree versions. Node that HTMLCollections owned by Document are invalidated with other
document-rooted node lists in m_listsInvalidatedAtDocument for simplicity although this mechanism is
normally used for node lists owned by a non-Document node that contains nodes outside of its subtree.
ItemProperties and FormControls are more "traditional" users of the mechanism.

Also, merged DynamicNodeList::invalidateCache and HTMLCollection::invalidateCache.

  • dom/Document.cpp:

(WebCore::Document::registerNodeListCache): Renamed. No longer takes NodeListInvalidationType or
NodeListRootType since they can be obtained from the cache base. Increment the node list counter for
InvalidateOnIdNameAttrChange when a HTMLCollection is passed in since all HTMLCollections need to be
invalidated on id or name content attribute changes due to named getters.
(WebCore::Document::unregisterNodeListCache): Ditto.
(WebCore::shouldInvalidateNodeListForType):
(WebCore::Document::shouldInvalidateNodeListCaches):
(WebCore::Document::clearNodeListCaches):

  • dom/Document.h:

(WebCore): Added InvalidateOnIdNameAttrChange, InvalidateOnHRefAttrChange, and InvalidateOnAnyAttrChange.
(Document):

  • dom/DynamicNodeList.cpp:

(WebCore::DynamicNodeListCacheBase::invalidateCache): Added. Invalidates caches of both DynamicNodeList
and HTMLCollection. We can't afford to use virtual function calls here because this function is called on
all node lists and HTML collections owned by ancestors of an element under which a node is added, removed,
or its attributes are changed.
(WebCore):

  • dom/DynamicNodeList.h:

(WebCore::DynamicNodeListCacheBase::DynamicNodeListCacheBase): Initializes member variables directly
instead of calling clearCache now that DynamicNodeListCacheBase::invalidateCache has become polymorphic.
(DynamicNodeListCacheBase): Increased the number of bits for m_invalidationType since we now have 9
invalidation types.
(WebCore::DynamicSubtreeNodeList::~DynamicSubtreeNodeList):
(WebCore::DynamicSubtreeNodeList::DynamicSubtreeNodeList):

  • dom/ElementRareData.h:

(ElementRareData):
(WebCore::ElementRareData::clearHTMLCollectionCaches): Added.
(WebCore::ElementRareData::adoptTreeScope): Added; similar to NodeRareData::adoptTreeScope.

  • dom/Node.cpp:

(WebCore::Node::invalidateNodeListsCacheAfterAttributeChanged): Clears HTML collection caches as well as
node list caches.
(WebCore::Node::invalidateNodeListsCacheAfterChildrenChanged): Ditto.

  • dom/NodeRareData.h:

(WebCore::NodeListsNodeData::adoptTreeScope):

  • dom/TreeScopeAdopter.cpp:

(WebCore::TreeScopeAdopter::moveTreeToNewScope): Calls ElementRareData's adoptTreeScope as well as
NodeRareData's.

  • html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::namedItemWithIndex):

  • html/HTMLCollection.cpp:

(WebCore::rootTypeFromCollectionType): Added. As mentioned above, treat all Document-owned HTML collection
as if rooted at document for convenience.
(WebCore::invalidationTypeExcludingIdAndNameAttributes): Added. Since all HTML collection requires
invalidation on id and name content attribute changes, which is taken care by the special logic in
Document::registerNodeListCache, exclude those two attributes from consideration.
(WebCore::HTMLCollection::HTMLCollection): Calls Document::registerNodeListCache.
(WebCore::HTMLCollection::~HTMLCollection): Calls Document::unregisterNodeListCache.
(WebCore::HTMLCollection::length):
(WebCore::HTMLCollection::item):
(WebCore::HTMLCollection::namedItem):
(WebCore::HTMLCollection::updateNameCache):

  • html/HTMLCollection.h:

(WebCore::HTMLCollectionCacheBase::HTMLCollectionCacheBase):
(HTMLCollectionCacheBase): Removed m_cacheTreeVersion and clearCache since they're no longer used.
(HTMLCollection):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::namedItem):
(WebCore::HTMLFormCollection::updateNameCache):

  • html/HTMLOptionsCollection.h:

(HTMLOptionsCollection):

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::updateNameCache):

  • html/HTMLPropertiesCollection.h:

(WebCore::HTMLPropertiesCollection::invalidateCache):

12:45 PM Changeset in webkit [122620] by zandobersek@gmail.com
  • 1 edit
    3 adds in trunk/LayoutTests

Unreviewed GTK gardening, adding a baseline required after unskipping
fast/files/workers/worker-read-blob-async.html in r122612.

  • platform/gtk/fast/files: Added.
  • platform/gtk/fast/files/workers: Added.
  • platform/gtk/fast/files/workers/worker-read-blob-async-expected.txt: Added.
12:40 PM Changeset in webkit [122619] by shawnsingh@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Remove incorrect debug assertion in LayerRendererChromium.cpp
https://bugs.webkit.org/show_bug.cgi?id=91260

Reviewed by Adrienne Walker.

ASSERT(!clipped) was being triggered after skinny almost-degenerate
quads went through anti-aliasing inflation, and then were being
transformed back from device space to local space. It turns out
this assertion is too aggressive, and we don't yet have an obvious
need to change the behavior on the clipped==true case.

No new tests needed, this patch fixes only comments and debug code.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawRenderPassQuad):

fixed a comment.

(WebCore::LayerRendererChromium::drawTileQuad):

fixed a similar comment, removed unnecessary assertion.

12:11 PM Changeset in webkit [122618] by dpranke@chromium.org
  • 2 edits in trunk/Tools

webkitpy: make worker.start() and worker.stop() optional in the messagepool
https://bugs.webkit.org/show_bug.cgi?id=91170

Reviewed by Ojan Vafai.

test-webkitpy will use messagepool workers that don't actually
have any per-worker state, so they don't need start() and stop()
methods. Now we will only call the methods if they exist; this
means that workers only need to expose a handle() method.

  • Scripts/webkitpy/common/message_pool.py:

(_Worker.terminate):
(_Worker.run):

12:10 PM Changeset in webkit [122617] by zandobersek@gmail.com
  • 3 edits
    1 add in trunk/LayoutTests

Unreviewed GTK gardening, updating baselines for the fast/backgrounds/size/zero.html
test as required after r121296.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/backgrounds/size/zero-expected.png: Added.
  • platform/gtk/fast/backgrounds/size/zero-expected.txt:
12:08 PM Changeset in webkit [122616] by pdr@google.com
  • 3 edits
    2 adds in trunk

Remove assert in localCoordinateSpaceTransform()
https://bugs.webkit.org/show_bug.cgi?id=91189

Reviewed by Nikolas Zimmermann.

Source/WebCore:

The assert in localCoordinateSpaceTransform was added to catch subclasses forgetting
to override the method but it is better to simply return the identity matrix.

This scenario can occur when we break the SVG content model, such as asking for
the CTM of a <g> element inside a <tspan>. This is undefined in the spec because
tspan is not a subclass of SVGLocatable but both Firefox and Opera
implement this by returning the identity matrix.

Test: svg/custom/invalid-ctm.svg

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::localCoordinateSpaceTransform):

LayoutTests:

  • svg/custom/invalid-ctm-expected.txt: Added.
  • svg/custom/invalid-ctm.svg: Added.
12:08 PM Changeset in webkit [122615] by dpranke@chromium.org
  • 4 edits in trunk/Tools

NRWT doesn't print exceptions
https://bugs.webkit.org/show_bug.cgi?id=91129

Reviewed by Ojan Vafai.

Although we printed exceptions in most cases, if an unexpected
exception (like a runtime error) was raised when creating a
port, we wouldn't. This patch fixes that, and also cleans up
how we were logging exceptions from the workers to be less
verbose.

Because of the corner cases where these errors are occurring,
it's difficult to write automated unit tests for them. I've
tested it quite a bit by hand, though.

  • Scripts/webkitpy/common/message_pool.py:

(_MessagePool._close):
(_MessagePool._handle_worker_exception):
(_Worker.run):
(_Worker._raise):

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._run_tests):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(main):

12:05 PM Changeset in webkit [122614] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] String wrappers should be marked Independent
https://bugs.webkit.org/show_bug.cgi?id=91251

Reviewed by Adam Barth.

Currently V8 String wrappers are not marked Independent.
By marking them Independent, they can be reclaimed by the scavenger GC.

I tried to find some cases where this change reduces memory usage,
but couldn't due to sensitive behavior of GC.

No tests. No change in behavior.

  • bindings/v8/V8Binding.cpp:

(WebCore::StringCache::v8ExternalStringSlow):

12:00 PM Changeset in webkit [122613] by dgrogan@chromium.org
  • 2 edits in trunk/LayoutTests

IndexedDB: Add unexpectedUpgradeNeededCallback to shared.js
https://bugs.webkit.org/show_bug.cgi?id=91176

Reviewed by Tony Chang.

This is just used in our layout tests. It's the simplest possible piece
I could break off of the upgradeneeded changes.

No tests because no change in behavior expected.

  • storage/indexeddb/resources/shared.js:

(unexpectedBlockedCallback):
(unexpectedUpgradeNeededCallback):

11:50 AM Changeset in webkit [122612] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening, removing timeout expectations for a few
File API tests while hoping the problems have now gone away.

  • platform/gtk/TestExpectations:
11:46 AM Changeset in webkit [122611] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

[EFL] Gardening failure cases on EFL build bot
https://bugs.webkit.org/show_bug.cgi?id=91219

Unreviewed EFL gardening. Skip the new failing tests and add
platform-specific results for fallback-content.html to get the
bot greener.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-13

  • platform/efl/TestExpectations:
  • platform/efl/fast/canvas/fallback-content-expected.txt: Added.
11:45 AM Changeset in webkit [122610] by peter@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Make the v8 i18n API dependency conditional for Android, disable strict aliasing
https://bugs.webkit.org/show_bug.cgi?id=91240

Reviewed by Adam Barth.

Disable the v8 internationalization API for Chromium Android, as it's
disabled and not always available in checkouts. Furthermore, disable
strict aliasing for the webkit_remaining target, similar to what
x11-based builds are doing (see the webcore_prerequisites target).

  • WebCore.gyp/WebCore.gyp:
11:43 AM Changeset in webkit [122609] by zandobersek@gmail.com
  • 2 edits
    8 adds in trunk/LayoutTests

Unreviewed GTK gardening, adding baselines and expectations required
after r122509 and r122528.

  • platform/gtk/TestExpectations:
  • platform/gtk/http/tests/w3c: Added.
  • platform/gtk/http/tests/w3c/webperf: Added.
  • platform/gtk/http/tests/w3c/webperf/approved: Added.
  • platform/gtk/http/tests/w3c/webperf/approved/navigation-timing: Added.
  • platform/gtk/http/tests/w3c/webperf/approved/navigation-timing/html: Added.
  • platform/gtk/http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect-expected.txt: Added.
  • platform/gtk/http/tests/w3c/webperf/approved/navigation-timing/html5: Added.
  • platform/gtk/http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_xserver_redirect-expected.txt: Added.
11:25 AM WebKit Team edited by Hugo Parente Lima
(diff)
11:15 AM Changeset in webkit [122608] by haraken@chromium.org
  • 7 edits in trunk/Source/WebCore

[CallWith=XXX] arguments should be placed at the head of method arguments
https://bugs.webkit.org/show_bug.cgi?id=91217

Reviewed by Adam Barth.

The EFL build with the ENABLE_FILE_SYSTEM flag caused a build error,
because CodeGeneratorJS.pm assumes webkitEntries(ScriptExecutionContext*, HTMLInputElement*)
but the actual signature is webkitEntries(HTMLInputElement*, ScriptExecutionContext*) (bug 91185).

Per https://trac.webkit.org/wiki/WebKitIDL#CallWith, [CallWith=XXX] arguments should be placed
at the head of the arguments. (i.e. the behavior of CodeGeneratorJS.pm is correct.)

Thus the correct fix is (1) to change the signature of webkitEntries() and webkitGetAsEntry()
so that ScriptExecutionContext* comes first and (2) to modify CodeGeneratorV8.pm to support the order.

Test: bindings/scripts/test/TestObj.idl

  • Modules/filesystem/DataTransferItemFileSystem.h: Placed ScriptExecutionContext* at the head of arguments.

(DataTransferItemFileSystem):

  • Modules/filesystem/HTMLInputElementFileSystem.cpp: Ditto.

(WebCore::HTMLInputElementFileSystem::webkitEntries):

  • Modules/filesystem/HTMLInputElementFileSystem.h: Ditto.

(HTMLInputElementFileSystem):

  • Modules/filesystem/chromium/DataTransferItemFileSystemChromium.cpp: Ditto.

(WebCore::DataTransferItemFileSystem::webkitGetAsEntry):

  • bindings/scripts/CodeGeneratorV8.pm: Modified to support the correct order.

(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateFunctionCallString):

  • bindings/scripts/test/V8/V8TestInterface.cpp: Updated run-bindings-tests results.

(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):

11:11 AM Changeset in webkit [122607] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

PrettyPatch.rb complains about missing checksum for new pixel results
https://bugs.webkit.org/show_bug.cgi?id=88368

Reviewed by Tony Chang.

When adding or removing a file, we incorrectly iterpreted not having an image
as not having a checksum.

  • PrettyPatch/PrettyPatch.rb:
  • PrettyPatch/PrettyPatch_test.rb:

I tried to fix the TempFile issue in these tests, but after a couple hours
of banging my head against this, I have no idea what's breaking.

10:57 AM Changeset in webkit [122606] by commit-queue@webkit.org
  • 4 edits in trunk

enable TestWebKitAPI/webkit_unit_tests apk on x86 android platform by adding abi support
https://bugs.webkit.org/show_bug.cgi?id=91194

Patch by Wei James <james.wei@intel.com> on 2012-07-13
Reviewed by Adam Barth.

Source/WebKit/chromium:

  • WebKitUnitTests.gyp:

Tools:

  • TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
10:55 AM Changeset in webkit [122605] by Philippe Normand
  • 2 edits in trunk/Tools

[GTK] Gardening: update API tests skipped list
https://bugs.webkit.org/show_bug.cgi?id=91224

Unreviewed gardening.

Skip "next" and "previous" tests of FindController until bug #91083
is fixed.

Patch by Simon Pena <Simon Pena> on 2012-07-13

  • gtk/run-api-tests:

(TestRunner):

10:39 AM Changeset in webkit [122604] by mary.wu@torchmobile.com.cn
  • 6 edits in trunk/Source/WebCore

[BlackBerry] Some small changes in network code
https://bugs.webkit.org/show_bug.cgi?id=90974

Reviewed by Rob Buis.

  1. Set status in NetworkJob/SocketStreamHandleBlackBerry so that

its wrapped stream can also query the stream result.

  1. pass download attribute to NetworkRequest.

RIM PR# 171555
Reviewed internally by Lyon Chen and Joe Mason.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::handleNotifyClose):

  • platform/network/blackberry/NetworkJob.h:

(WebCore::NetworkJob::status):

  • platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::platformTargetTypeForRequest):

  • platform/network/blackberry/SocketStreamHandle.h:

(WebCore::SocketStreamHandle::status):
(SocketStreamHandle):

  • platform/network/blackberry/SocketStreamHandleBlackBerry.cpp:

(WebCore::SocketStreamHandle::notifyStatusReceived):
(WebCore::SocketStreamHandle::notifyClose):

10:32 AM Changeset in webkit [122603] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Remove uiSourceCode from Resource.
https://bugs.webkit.org/show_bug.cgi?id=91201

Reviewed by Pavel Feldman.

Removed Resource._uiSourceCode field as it is not used anymore.

  • inspector/front-end/Resource.js:

(WebInspector.Resource.prototype.isHidden):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):

10:28 AM Changeset in webkit [122602] by danakj@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

webkit_unit_test CCLayerTreeHostImplTest.testRemoveRenderPasses started failing.
https://bugs.webkit.org/show_bug.cgi?id=91245

Reviewed by Adrienne Walker.

  • tests/CCLayerTreeHostImplTest.cpp:
10:25 AM Changeset in webkit [122601] by commit-queue@webkit.org
  • 9 edits in trunk

[CMake] Proper handling of ENABLE_API_TESTS build option
https://bugs.webkit.org/show_bug.cgi?id=91221

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-13
Reviewed by Rob Buis.

.:

Make the flag reusable across the ports using CMake. We are about to enable the WTF,
WebCore and WebKit 2 API's at Tools/TestWebKitAPI and other ports using CMake can get
it almost for free.

  • CMakeLists.txt:
  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/WebKit:

Build unit tests only if ENABLE_API_TESTS is set.

  • PlatformEfl.cmake:

Source/WebKit2:

Build unit tests only if ENABLE_API_TESTS is set.

  • PlatformEfl.cmake:
10:24 AM Changeset in webkit [122600] by inferno@chromium.org
  • 25 edits in trunk/Source/WebCore

Unreviewed, rolling out r122450 and r122580.
http://trac.webkit.org/changeset/122450
http://trac.webkit.org/changeset/122580
https://bugs.webkit.org/show_bug.cgi?id=91263

Caused multiple regressions on ClusterFuzz (Requested by
inferno-sec on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-13

  • bindings/js/ScriptWrappable.h:

(WebCore::ScriptWrappable::reportMemoryUsage):

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::reportMemoryUsage):

  • bindings/v8/IntrusiveDOMWrapperMap.h:

(WebCore::ChunkedTable::reportMemoryUsage):

  • bindings/v8/ScriptWrappable.h:

(WebCore::ScriptWrappable::reportMemoryUsage):

  • bindings/v8/V8Binding.cpp:

(WebCore::V8BindingPerIsolateData::reportMemoryUsage):
(WebCore::StringCache::reportMemoryUsage):

  • bindings/v8/V8DOMMap.h:
  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::InlineCSSStyleDeclaration::ensureMutablePropertySet):

  • css/StylePropertySet.cpp:
  • css/StylePropertySet.h:

(WebCore::StylePropertySet::reportMemoryUsage):

  • dom/CharacterData.cpp:

(WebCore::CharacterData::reportMemoryUsage):

  • dom/ContainerNode.h:

(WebCore::ContainerNode::reportMemoryUsage):

  • dom/Document.cpp:

(WebCore::Document::reportMemoryUsage):

  • dom/Element.cpp:

(WebCore::Element::detachAttribute):
(WebCore::Element::removeAttribute):
(WebCore::Element::attributes):
(WebCore::Element::setAttributeInternal):
(WebCore::Element::parserSetAttributes):
(WebCore::Element::hasEquivalentAttributes):
(WebCore::Element::createAttributeData):
(WebCore):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeNode):
(WebCore::Element::getAttributeNode):
(WebCore::Element::getAttributeNodeNS):
(WebCore::Element::hasAttribute):
(WebCore::Element::hasAttributeNS):
(WebCore::Element::normalizeAttributes):
(WebCore::Element::cloneAttributesFromElement):

  • dom/Element.h:

(WebCore::Element::attributeData):
(Element):
(WebCore::Element::reportMemoryUsage):
(WebCore::Element::ensureAttributeData):
(WebCore::Element::updatedAttributeData):
(WebCore::Element::ensureUpdatedAttributeData):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::attrIfExists):
(WebCore::ElementAttributeData::ensureAttr):
(WebCore::ElementAttributeData::setAttr):
(WebCore::ElementAttributeData::removeAttr):
(WebCore::ElementAttributeData::setClass):
(WebCore):
(WebCore::ElementAttributeData::ensureInlineStyle):
(WebCore::ElementAttributeData::ensureMutableInlineStyle):
(WebCore::ElementAttributeData::destroyInlineStyle):
(WebCore::ElementAttributeData::addAttribute):
(WebCore::ElementAttributeData::removeAttribute):
(WebCore::ElementAttributeData::isEquivalent):
(WebCore::ElementAttributeData::detachAttrObjectsFromElement):
(WebCore::ElementAttributeData::getAttributeItemIndexSlowCase):
(WebCore::ElementAttributeData::cloneDataFrom):
(WebCore::ElementAttributeData::clearAttributes):
(WebCore::ElementAttributeData::replaceAttribute):
(WebCore::ElementAttributeData::getAttributeNode):

  • dom/ElementAttributeData.h:

(WebCore::ElementAttributeData::create):
(ElementAttributeData):
(WebCore::ElementAttributeData::setIdForStyleResolution):
(WebCore::ElementAttributeData::setAttributeStyle):
(WebCore::ElementAttributeData::length):
(WebCore::ElementAttributeData::isEmpty):
(WebCore::ElementAttributeData::attributeItem):
(WebCore::ElementAttributeData::getAttributeItem):
(WebCore::ElementAttributeData::reportMemoryUsage):
(WebCore::ElementAttributeData::ElementAttributeData):
(WebCore::ElementAttributeData::attributeVector):
(WebCore::ElementAttributeData::clonedAttributeVector):
(WebCore::ElementAttributeData::removeAttribute):
(WebCore::ElementAttributeData::getAttributeItemIndex):

  • dom/MemoryInstrumentation.h:

(MemoryInstrumentation):
(MemoryObjectInfo):
(WebCore::MemoryObjectInfo::reportInstrumentedPointer):
(WebCore::MemoryObjectInfo::reportPointer):
(WebCore::MemoryObjectInfo::reportInstrumentedObject):
(WebCore::MemoryObjectInfo::reportObject):
(WebCore::MemoryObjectInfo::reportObjectInfo):
(WebCore::MemoryObjectInfo::reportHashMap):
(WebCore::MemoryObjectInfo::reportHashSet):
(WebCore::MemoryObjectInfo::reportListHashSet):
(WebCore::MemoryObjectInfo::reportVector):
(WebCore::MemoryObjectInfo::reportString):
(WebCore::MemoryObjectInfo::objectType):
(WebCore::MemoryObjectInfo::objectSize):
(WebCore::MemoryObjectInfo::memoryInstrumentation):

  • dom/Node.cpp:

(WebCore::Node::reportMemoryUsage):

  • dom/QualifiedName.h:

(WebCore::QualifiedName::QualifiedNameImpl::reportMemoryUsage):
(WebCore::QualifiedName::reportMemoryUsage):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::style):
(WebCore::StyledElement::classAttributeChanged):
(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::removeInlineStyleProperty):
(WebCore::StyledElement::addSubresourceAttributeURLs):

  • dom/StyledElement.h:

(WebCore::StyledElement::ensureInlineStyle):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::createHTMLElementFromSavedElement):

  • platform/TreeShared.h:

(WebCore::TreeShared::reportMemoryUsage):

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):

10:23 AM Changeset in webkit [122599] by mifenton@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Add support for attributes to define keyboard and enter key type on the Virtual Keyboard
https://bugs.webkit.org/show_bug.cgi?id=91248

Reviewed by Antonio Gomes.

PR 174733.

Add data-blackberry-virtual-keyboard-type and
data-blackberry-virtual-keyboard-enter-key to
enable configuration of the desired virtual keyboard
using element attributes.

Reviewed Internally by Gen Mak.

  • Api/WebPageClient.h:
  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::convertStringToKeyboardType):
(WebKit):
(BlackBerry::WebKit::keyboardTypeAttribute):
(BlackBerry::WebKit::convertStringToKeyboardEnterKeyType):
(BlackBerry::WebKit::keyboardEnterKeyTypeAttribute):
(BlackBerry::WebKit::InputHandler::setElementFocused):

10:19 AM Changeset in webkit [122598] by kseo@webkit.org
  • 6 edits in trunk/Source/WebCore

Remove down-casting to BitmapImage in GraphicsContext::drawImage.
https://bugs.webkit.org/show_bug.cgi?id=90755

Patch by Huang Dongsung <luxtella@company100.net> on 2012-07-13
Reviewed by Simon Fraser.

Add a BitmapImage draw method which takes RespectImageOrientationEnum enum as
the last argument for CG. Then we can remove the conditional down-casting in
GraphicsContext::drawImage.

This change is needed for parallel image decoders. Because parallel image
decoders use a Bitmap image wrapper class which extends Image (not Bitmap), the
down-casting above causes the loss of RespectImageOrientationEnum which must be
passed to BitmapImage.

No new tests, no behavior change.

  • platform/graphics/BitmapImage.cpp:
  • platform/graphics/BitmapImage.h:
  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawImage):

  • platform/graphics/Image.cpp:

(WebCore::Image::draw):
(WebCore):

  • platform/graphics/Image.h:

(Image):

10:09 AM Changeset in webkit [122597] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Make new public Ewk headers as installable
https://bugs.webkit.org/show_bug.cgi?id=91232

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-13
Reviewed by Antonio Gomes.

Make new public Ewk headers installable.

  • PlatformEfl.cmake:
10:06 AM Changeset in webkit [122596] by pdr@google.com
  • 2 edits
    2 copies in branches/chromium/1132

Merging r118589 into 1132

9:53 AM Changeset in webkit [122595] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

[WIN] Fix compilation of DFGRepatch.cpp
https://bugs.webkit.org/show_bug.cgi?id=91241

Reviewed by Geoffrey Garen.

Use intptr_t instead of uintptr_t when calling CodeLocationCommon::dataLabelPtrAtOffset(int)
to fix MSVC "unary minus operator applied to unsigned type, result still unsigned" warning.

  • dfg/DFGRepatch.cpp:

(JSC::DFG::dfgResetGetByID):
(JSC::DFG::dfgResetPutByID):

9:35 AM Changeset in webkit [122594] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Fix ARM_TRADITIONAL JIT for COMPILER(MSVC) and COMPILER(RVCT) after r121885
https://bugs.webkit.org/show_bug.cgi?id=91238

Reviewed by Zoltan Herczeg.

r121885 changed the assembler instruction only for COMPILER(GCC).
Use the same instructions for the other compilers too.

  • jit/JITStubs.cpp:

(JSC::ctiTrampoline):
(JSC::ctiTrampolineEnd):
(JSC::ctiVMThrowTrampoline):

9:22 AM Changeset in webkit [122593] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, updated chromium test expectations.
https://bugs.webkit.org/show_bug.cgi?id=91252

  • platform/chromium/TestExpectations:
9:18 AM Changeset in webkit [122592] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Also mark its evil twin as flaky.

  • platform/chromium/TestExpectations:
9:16 AM Changeset in webkit [122591] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Note this test as flaky.

  • platform/chromium/TestExpectations:
9:13 AM Changeset in webkit [122590] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, updated test expectations.
http://bugs.webkit.org/show_bug.cgi?id=91255

  • platform/chromium/TestExpectations:
9:11 AM Changeset in webkit [122589] by zhajiang@rim.com
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] resetBitmapZoomScale called while zooming preventing pinch zoom
https://bugs.webkit.org/show_bug.cgi?id=91247

Reviewed by Antonio Gomes.
Patch by Jacky Jiang <zhajiang@rim.com>

PR: 175432
On yahoo.com, the web page stopped zooming while trying to pinch as
WebPageClient::resetBitmapZoomScale(double) was being called by
WebPagePrivate::zoomToInitialScaleOnLoad() after load finished.
And also yahoo.com was keeping updating layout, which made it really
bad that zoomToInitialScaleOnLoad() was called many times when load
finished and the load type was FrameLoadTypeStandard or FrameLoadTypeSame.
As we only care about the situation that dispatchDidFirstVisuallyNonEmptyLayout()
happens after load finished, we can move the code to that method and
set a flag for WebPage layoutFinished() and zoomToInitialScaleOnLoad()
instead. In this way, we can ensure that the flag is only enabled when
dispatchDidFirstVisuallyNonEmptyLayout() is called after load finished
and get rid of calling zoomToInitialScaleOnLoad() lots of times when
keeping updating layout in such kind of situation.

Internally reviewed by Arvid Nilsson

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::layoutFinished):

  • Api/WebPage_p.h:

(BlackBerry::WebKit::WebPagePrivate::shouldZoomToInitialScaleOnLoad):
(BlackBerry::WebKit::WebPagePrivate::setShouldZoomToInitialScaleAfterLoadFinished):
(WebPagePrivate):

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDidFirstVisuallyNonEmptyLayout):

9:00 AM Changeset in webkit [122588] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium gardening, updated test expectations.
https://bugs.webkit.org/show_bug.cgi?id=91254

  • platform/chromium/TestExpectations:
8:53 AM Changeset in webkit [122587] by jpetsovits@rim.com
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Use fillBuffer() instead of a user-defined background image.
https://bugs.webkit.org/show_bug.cgi?id=91180
RIM PR 171458

Reviewed by Rob Buis.
Internally reviewed by Andrew Lo.

By using Platform::Graphics::fillBuffer() to fill the
overscroll area, we save graphics memory for the buffer
that the background image was occupying.

Also adapt checkerboard drawing as it is now done using
fillBuffer() which replaces checkerBuffer().

In the same go, use the opportunity of the WebSettings
API change to make it more consistent, renaming the
OverZoomColor setting to OverScrollColor.

  • Api/BackingStore.cpp:

(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::paintDefaultBackground):
(BlackBerry::WebKit::BackingStorePrivate::blitContents):
(BlackBerry::WebKit::BackingStorePrivate::fillWindow):

  • Api/BackingStore_p.h:

(BackingStorePrivate):

  • Api/WebSettings.cpp:

(WebKit):
(BlackBerry::WebKit::WebSettings::standardSettings):
(BlackBerry::WebKit::WebSettings::overScrollColor):
(BlackBerry::WebKit::WebSettings::setOverScrollColor):
(BlackBerry::WebKit::WebSettings::isEnableDefaultOverScrollBackground):
(BlackBerry::WebKit::WebSettings::setEnableDefaultOverScrollBackground):

  • Api/WebSettings.h:
8:51 AM Changeset in webkit [122586] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

Fix QtWebKit build with OpenGLES after GC3D/E3D refactor
https://bugs.webkit.org/show_bug.cgi?id=91156

Patch by Lauro Neto <lauro.neto@openbossa.org> on 2012-07-13
Reviewed by Noam Rosenthal.

Adds several build fixes.

  • platform/graphics/GraphicsContext3D.h:

Use E3DOpenGLES instead of previously removed E3DQt.

  • platform/graphics/OpenGLESShims.h:

Enable defines for Qt.

  • platform/graphics/opengl/Extensions3DOpenGLES.cpp:

(WebCore::Extensions3DOpenGLES::blitFramebuffer):
(WebCore):
(WebCore::Extensions3DOpenGLES::renderbufferStorageMultisample):
(WebCore::Extensions3DOpenGLES::copyTextureCHROMIUM):

Added pure virtual stubs.

(WebCore::Extensions3DOpenGLES::supportsExtension):

Remove PROC suffix. See bug #91130.

  • platform/graphics/opengl/Extensions3DOpenGLES.h:

(Extensions3DOpenGLES):

Added pure virtual stubs.

  • platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:

(WebCore::GraphicsContext3D::reshapeFBOs):

Readded missing function after removed in r122250.

(WebCore):

Use PLATFORM(BLACKBERRY) guard around port-specific include.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

Added USE(OPENGL_ES_2) guard instead of always loading the OpenGL extensions.

8:47 AM Changeset in webkit [122585] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, marked chromium test as flaky.
https://bugs.webkit.org/show_bug.cgi?id=91252

  • platform/chromium/TestExpectations:
8:36 AM Changeset in webkit [122584] by keishi@webkit.org
  • 17 edits
    6 adds in trunk

Form of FormAssociatedElement is not updated when id target changes.
https://bugs.webkit.org/show_bug.cgi?id=91042

Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/forms/update-form-attribute-element.html

This patch introduces the IdTargetObserver and IdTargetObserverRegistry class.
They can be used to be notified when the element that an id is pointing to (the id target)
changes.

  • CMakeLists.txt: Added IdTargetObserverRegistry.{h,cpp} and IdTargetObserver.{h,cpp}
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/DOMAllInOne.cpp:
  • dom/IdTargetObserver.cpp: Added. When you want notified of changes to an id target, you should create a new class that inherits this.

(WebCore):
(WebCore::IdTargetObserver::IdTargetObserver):
(WebCore::IdTargetObserver::~IdTargetObserver):

  • dom/IdTargetObserver.h: Added.

(WebCore):
(IdTargetObserver):

  • dom/IdTargetObserverRegistry.cpp: Added.

(WebCore):
(WebCore::IdTargetObserverRegistry::create):
(WebCore::IdTargetObserverRegistry::addObserver): Register an IdTargetObserver to observe an id target.
(WebCore::IdTargetObserverRegistry::removeObserver): Unregisters an IdTargetObserver from observing.
(WebCore::IdTargetObserverRegistry::notifyObserversInternal):

  • dom/IdTargetObserverRegistry.h: Added.

(WebCore):
(IdTargetObserverRegistry):
(WebCore::IdTargetObserverRegistry::IdTargetObserverRegistry):
(WebCore::IdTargetObserverRegistry::notifyObservers): Calls idTargetChanged on all observers for an id. Inlining first part of function for performance.

  • dom/TreeScope.cpp:

(WebCore::TreeScope::TreeScope):
(WebCore::TreeScope::addElementById): Calls IdTargetObserverRegistry::notifyObservers because the id target might have changed.
(WebCore::TreeScope::removeElementById): Ditto.

  • dom/TreeScope.h:

(WebCore):
(WebCore::TreeScope::idTargetObserverRegistry):
(TreeScope):

  • html/FormAssociatedElement.cpp: Observer for id targets defined by the form attribute.

(WebCore::FormAssociatedElement::didMoveToNewDocument):
(WebCore::FormAssociatedElement::insertedInto):
(WebCore::FormAssociatedElement::removedFrom):
(WebCore::FormAssociatedElement::formAttributeChanged):
(WebCore::FormAssociatedElement::resetFormAttributeTargetObserver): Creates and sets up a new FormAttributeTargetObserver.
(WebCore):
(WebCore::FormAssociatedElement::formAttributeTargetChanged):
(WebCore::FormAttributeTargetObserver::create):
(WebCore::FormAttributeTargetObserver::FormAttributeTargetObserver):
(WebCore::FormAttributeTargetObserver::idTargetChanged):

  • html/FormAssociatedElement.h:

(FormAssociatedElement):

  • html/FormController.cpp:
  • html/FormController.h:

(FormController):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::removedFrom):
(WebCore::HTMLFormElement::formElementIndexWithFormAttribute): Modified to take a range. It
scans the range and returns the index to insert the element in m_associatedElement.
(WebCore::HTMLFormElement::formElementIndex): Modified to only scan the elements in
m_associatedElement that precede and follow the form element.

  • html/HTMLFormElement.h:

(HTMLFormElement):

LayoutTests:

  • fast/forms/update-form-attribute-element-expected.txt: Added.
  • fast/forms/update-form-attribute-element.html: Added.
8:32 AM Changeset in webkit [122583] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardneing, skip failing chromium test.

  • platform/chromium/TestExpectations:
8:31 AM Changeset in webkit [122582] by rgabor@webkit.org
  • 9 edits
    1 add in trunk/Source/WebCore

Optimizing blend filter to ARM-NEON with intrinsics
https://bugs.webkit.org/show_bug.cgi?id=90949

Reviewed by Zoltan Herczeg.

The feBlend SVG filter modes can be greatly fasten up with ARM-NEON since
we are able to calculate with 2 pixels (8 channels) at the same time.
The code is written with NEON intrinsics and it doesn't affect the
general - it has the same behaviour as the original algorithm.
With this NEON optimization the calculation is ~4.5 times faster for each mode.

Existing tests cover this issue.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/filters/FEBlend.cpp:

(WebCore::FEBlend::platformApplyGeneric):
(WebCore):
(WebCore::FEBlend::platformApplySoftware):

  • platform/graphics/filters/FEBlend.h:

(FEBlend):

  • platform/graphics/filters/arm/FEBlendNEON.h: Added.

(WebCore):
(FEBlendUtilitiesNEON):
(WebCore::FEBlendUtilitiesNEON::div255): integer divison with 255
(WebCore::FEBlendUtilitiesNEON::normal): calculate normal mode blending for two pixels
(WebCore::FEBlendUtilitiesNEON::multiply): calculate multiply mode blending for two pixels
(WebCore::FEBlendUtilitiesNEON::screen): calculate screen mode blending for two pixels
(WebCore::FEBlendUtilitiesNEON::darken): calculate darken mode blending for two pixels
(WebCore::FEBlendUtilitiesNEON::lighten): calculate lighten mode blending for two pixels
(WebCore::FEBlend::platformApplyNEON):

8:15 AM Changeset in webkit [122581] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening chromium tests rebaseline.

  • platform/chromium-mac/css3/font-feature-settings-rendering-expected.txt:
8:09 AM Changeset in webkit [122580] by loislo@chromium.org
  • 17 edits in trunk/Source/WebCore

Web Inspector: native memory instrumentation: extract instrumentation methods into MemoryClassInfo
https://bugs.webkit.org/show_bug.cgi?id=91227

Reviewed by Pavel Feldman.

void Node::reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const
{

MemoryClassInfo<Node> info(memoryObjectInfo, this, MemoryInstrumentation::DOM);
info.visitBaseClass<ScriptWrappable>(this);

info.addMember(m_notInstrumentedPointer); automatically detects poniter/reference
info.addInstrumentedMember(m_next);
info.addHashSet<MemoryInstrumentation::NonClass>(m_aHash);
NonClass value_type (report only size of internal template structures)
info.addHashSet<MemoryInstrumentation::NotInstrumentedClass>(m_aHashSet); not instrumented value_type (use sizeof)
info.addHashSet<MemoryInstrumentation::InstrumentedClass>(m_aHashSet);
instrumented value_type (call visit)

}

The change is covered by existing tests for native memory snapshot.

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::reportMemoryUsage):

  • bindings/v8/IntrusiveDOMWrapperMap.h:

(WebCore::ChunkedTable::reportMemoryUsage):

  • bindings/v8/ScriptWrappable.h:

(WebCore::ScriptWrappable::reportMemoryUsage):

  • bindings/v8/V8Binding.cpp:

(WebCore::V8BindingPerIsolateData::reportMemoryUsage):
(WebCore::StringCache::reportMemoryUsage):

  • bindings/v8/V8DOMMap.h:
  • css/StylePropertySet.h:

(WebCore::StylePropertySet::reportMemoryUsage):

  • dom/CharacterData.cpp:

(WebCore::CharacterData::reportMemoryUsage):

  • dom/ContainerNode.h:

(WebCore::ContainerNode::reportMemoryUsage):

  • dom/Document.cpp:

(WebCore::Document::reportMemoryUsage):

  • dom/Element.h:

(WebCore::Element::reportMemoryUsage):

  • dom/ElementAttributeData.h:

(WebCore::ElementAttributeData::reportMemoryUsage):

  • dom/MemoryInstrumentation.h:

(MemoryInstrumentation):
(WebCore::MemoryObjectInfo::objectType):
(WebCore::MemoryObjectInfo::objectSize):
(WebCore::MemoryObjectInfo::memoryInstrumentation):
(MemoryObjectInfo):
(WebCore::MemoryObjectInfo::reportObjectInfo):
(WebCore):
(MemoryClassInfo):
(WebCore::MemoryClassInfo::MemoryClassInfo):
(WebCore::MemoryClassInfo::visitBaseClass):
(WebCore::MemoryClassInfo::reportInstrumentedPointer):
(WebCore::MemoryClassInfo::reportInstrumentedObject):
(WebCore::MemoryClassInfo::reportPointer):
(WebCore::MemoryClassInfo::reportObject):
(WebCore::MemoryClassInfo::reportHashMap):
(WebCore::MemoryClassInfo::reportHashSet):
(WebCore::MemoryClassInfo::reportListHashSet):
(WebCore::MemoryClassInfo::reportVector):
(WebCore::MemoryClassInfo::reportString):

  • dom/Node.cpp:

(WebCore::Node::reportMemoryUsage):

  • dom/QualifiedName.h:

(WebCore::QualifiedName::QualifiedNameImpl::reportMemoryUsage):
(WebCore::QualifiedName::reportMemoryUsage):

  • platform/TreeShared.h:

(WebCore::TreeShared::reportMemoryUsage):

8:05 AM Changeset in webkit [122579] by rgabor@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r122528. Skipped some new tests.
https://bugs.webkit.org/show_bug.cgi?id=91218

Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-07-13

  • platform/qt/Skipped:
8:02 AM Changeset in webkit [122578] by pfeldman@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: align scope filters
https://bugs.webkit.org/show_bug.cgi?id=91213

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/elementsPanel.css:

(.crumbs):

  • inspector/front-end/inspector.css:

(.status-bar > div):
(.scope-bar):
(.scope-bar li):
(.scope-bar li.all):

  • inspector/front-end/networkLogView.css:
7:58 AM Changeset in webkit [122577] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

[GTK] Gardening: new baseline after r122550 and rebaseline after r122556
https://bugs.webkit.org/show_bug.cgi?id=91235

Unreviewed gardening.

Add new baseline for fast/canvas/fallback-content.html added in r122550, and
rebaseline fast/regions/region-style-block-background-color2.html after r122556.

Patch by Simon Pena <Simon Pena> on 2012-07-13

  • platform/gtk/fast/canvas/fallback-content-expected.txt: Added.
  • platform/gtk/fast/regions/region-style-block-background-color2-expected.txt:
7:48 AM Changeset in webkit [122576] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed gardening: skip failing webkit unit test.

  • tests/CCLayerTreeHostImplTest.cpp:
7:41 AM Changeset in webkit [122575] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed gardening, skip failing webkit_unit_tests.

  • tests/DecimalTest.cpp:

(TEST_F):

7:30 AM Changeset in webkit [122574] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: too many hardcoded strings in InspectorBackendDispatcher.
https://bugs.webkit.org/show_bug.cgi?id=89198

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-07-13
Reviewed by Yury Semikhatsky.

Instead of generating error message string on every call (mostly for nothing),
error message is generated deeper inside the handler and only command name
is passed every time.

  • inspector/CodeGeneratorInspector.py:

(Generator.process_command):

7:00 AM Changeset in webkit [122573] by commit-queue@webkit.org
  • 7 edits
    1 add in trunk/Source

[BlackBerry] Update about:* pages
https://bugs.webkit.org/show_bug.cgi?id=91121

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-13
Reviewed by Yong Li.

Update the about:config pages, and improve the aesthetics of the about:build, about:version, about:credits, about:memory, about:config, and similar pages.

No new tests, because there is no new funtionality.

Source/WebCore:

  • platform/network/blackberry/NetworkJob.cpp: Update the aesthetics of about:* pages

Source/WebKit/blackberry:

  • WebCoreSupport/AboutData.cpp:

(WebCore):
(WebCore::writeFeatures):
(WebCore::numberToHTMLTr): Converted to template function, added bool specialization to write "true" and "false" instead of "1" and "0"
(WebCore::configPage):
(WebCore::memoryPage):

  • WebCoreSupport/AboutTemplate.html.cpp: Template for BlackBerry about:* pages.
6:53 AM Changeset in webkit [122572] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix checking for optional DeviceOrientationEvent.absolute in JSC bindings
https://bugs.webkit.org/show_bug.cgi?id=91225

Patch by Olivier Blin <Olivier Blin> on 2012-07-13
Reviewed by Steve Block.

This issue comes from r105036

  • bindings/js/JSDeviceOrientationEventCustom.cpp:

(WebCore::JSDeviceOrientationEvent::initDeviceOrientationEvent):

6:47 AM Changeset in webkit [122571] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

[GTK] Implement disk cache in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=90797

Reviewed by Xan Lopez.

  • WebProcess/gtk/WebProcessGtk.cpp:

(WebKit::getCacheDiskFreeSize): Use an ASSERT instead of an early
return since the cache feature is now always added to the session.
(WebKit::WebProcess::platformSetCacheModel): Get the cache from
the session and set the maximum cache size as computed by
calculateCacheSizes().
(WebKit::WebProcess::platformClearResourceCaches): Call
soup_cache_clear().
(WebKit::WebProcess::platformTerminate): Make sure all pending
data is saved to the disk before the web process finishes.

  • WebProcess/gtk/WebProcessMainGtk.cpp:

(WebKit::WebProcessMainGtk): Create a SoupCache feature and add it
to the default SoupSession.

6:41 AM Changeset in webkit [122570] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Fix disk cache size computation in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=91226

Reviewed by Xan Lopez.

We are passing the free disk space value in bytes to
calculateCacheSizes() which expects values in MB.

  • WebProcess/gtk/WebProcessGtk.cpp:

(WebKit::WebProcess::platformSetCacheModel):

6:20 AM EFLWebKit edited by tmpsantos@gmail.com
(diff)
6:19 AM EFLWebKitTests edited by tmpsantos@gmail.com
(diff)
5:56 AM Changeset in webkit [122569] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[CSS Regions] Fix build for bug 89000
https://bugs.webkit.org/show_bug.cgi?id=91215

Patch by Andrei Bucur <abucur@adobe.com> on 2012-07-13
Reviewed by Kentaro Hara.

Remove the unused variable m_state that was a leftover from a previous version of the patch.

Tests: No new tests, build fix.

  • dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::WebKitNamedFlow):

  • dom/WebKitNamedFlow.h:

(WebKitNamedFlow):

5:53 AM Changeset in webkit [122568] by kkristof@inf.u-szeged.hu
  • 1 edit
    1 add in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebase test after r122550.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-07-13

  • platform/qt/fast/canvas/fallback-content-expected.txt: Added.
5:52 AM EFLWebKitTests edited by tmpsantos@gmail.com
(diff)
5:51 AM EFLWebKitTests edited by tmpsantos@gmail.com
(diff)
5:51 AM EFLWebKitTests edited by tmpsantos@gmail.com
(diff)
5:49 AM EFLWebKitTests created by tmpsantos@gmail.com
5:08 AM Changeset in webkit [122567] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] WebKit2 crash when going back/forward
https://bugs.webkit.org/show_bug.cgi?id=91220

Reviewed by Xan Lopez.

For some reason when a page is loaded from the backforward list,
when the didCommitLoadForFrame callback is called for the main
frame, the callback didInitiateLoadForResource hasn't been called
yet, so we don't even have a main resource at that point. We were
assuming we always had a main resource with a response. For now we
just check whether we have a resource before trying to set the
certificate to fix the crash, but we need to figue out why this is
happening an how to properly fix it.

  • UIProcess/API/gtk/WebKitLoaderClient.cpp:

(didCommitLoadForFrame): Check whether we have a main resource
before setting the certificate.

5:03 AM Changeset in webkit [122566] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[EFL][WK2] Use eina stringsharing for Ewk_Web_Resource's url
https://bugs.webkit.org/show_bug.cgi?id=91200

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-13
Reviewed by Kenneth Rohde Christiansen.

Use eina stringsharing for Ewk_Web_Resource's url
for consistency.

  • UIProcess/API/efl/ewk_web_resource.cpp:

(_Ewk_Web_Resource):
(_Ewk_Web_Resource::_Ewk_Web_Resource):
(ewk_web_resource_unref):
(ewk_web_resource_url_get):

  • UIProcess/API/efl/ewk_web_resource.h:
4:44 AM Changeset in webkit [122565] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] WebKitWebView::mouse-target-changed is not emitted when moved to/from edtiable content
https://bugs.webkit.org/show_bug.cgi?id=91216

Reviewed by Xan Lopez.

The problem is that the function to check whether two hit test
results are equal doesn't check the editable flag.

  • UIProcess/API/gtk/WebKitHitTestResult.cpp:

(webkitHitTestResultCompare): Check also the editable flag.

4:43 AM Changeset in webkit [122564] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Add const to the parameter of getters in ewk_security_origin
https://bugs.webkit.org/show_bug.cgi?id=90954

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-07-13
Reviewed by Kentaro Hara.

Move initialization of strings for protocol and host to the ewk_security_origin_new method,
which allows to add const qualifier for ewk_security_origin_protocol_get and ewk_security_origin_host_get.
In addition, add null checks to the getters.

  • ewk/ewk_security_origin.cpp:

(ewk_security_origin_protocol_get):
(ewk_security_origin_host_get):
(ewk_security_origin_new):

  • ewk/ewk_security_origin.h:
4:32 AM BuildingQtOnLinux edited by zoltan@webkit.org
(diff)
4:31 AM BuildingQtOnLinux edited by zoltan@webkit.org
(diff)
4:24 AM Changeset in webkit [122563] by gyuyoung.kim@samsung.com
  • 7 edits in trunk/Source

[EFL] Add *explicit* keyword to constructor which has a parameter
https://bugs.webkit.org/show_bug.cgi?id=91207

Reviewed by Zoltan Herczeg.

Add *explicit* keyword to contructor which has a parameter in order to avoid implicit type conversion.

Source/WebKit/efl:

  • WebCoreSupport/EditorClientEfl.h:

(EditorClientEfl):

  • WebCoreSupport/InspectorClientEfl.h:

(InspectorClientEfl):

  • WebCoreSupport/PageClientEfl.h:

(PageClientEfl):

  • WebCoreSupport/VibrationClientEfl.h:

(VibrationClientEfl):

Source/WebKit2:

  • WebProcess/WebCoreSupport/efl/WebFrameNetworkingContext.h:

(WebFrameNetworkingContext::WebFrameNetworkingContext):

4:19 AM BuildingQtOnLinux edited by ssandela@innominds.com
Update with set up details regarding building on QtCreator. (diff)
4:16 AM Changeset in webkit [122562] by bashi@chromium.org
  • 13 edits
    3 adds in trunk

[Chromium] Fix bugs in HarfBuzzShaper
https://bugs.webkit.org/show_bug.cgi?id=90951

Reviewed by Tony Chang.

Source/WebCore:

The current implementation has following problems:

  • Cannot render RTL text if the TextRun is divided into more than two HarfBuzzRun.
  • Script handling in TextRun partitioning is incorrect.
  • Inaccurate calculation of selection rect.
  • Wrong rendering position when the first glyph of the TextRun have non-zero offsets in terms of HarfBuzz.

To fix these problems I rewrote HarfBuzzShaper class. Here is the summary:

  • Divide the whole range of TextRun first, then shape them in visual order.
  • Divide TextRun in the same way of old-harfbuzz's hb_utf16_script_run_next().
  • Prefer float than int when calculating selection.
  • Adjust the drawing point after shaping.

Added tests covers the fix except for the last problem. The last problem will be covered
by fast/text/international/complex-joining-using-gpos.html after chromium linux port switches
to use HarfBuzzShaper.

Tests: fast/text/shaping/shaping-script-order.html

fast/text/shaping/shaping-selection-rect.html

  • platform/graphics/harfbuzz/FontHarfBuzz.cpp:

(WebCore::Font::drawComplexText): Adjusts point after shaping.

  • platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:

(WebCore::HarfBuzzShaper::HarfBuzzRun::HarfBuzzRun):
(WebCore):
(WebCore::HarfBuzzShaper::HarfBuzzRun::applyShapeResult): Added.
(WebCore::HarfBuzzShaper::HarfBuzzRun::setGlyphAndAdvance): Offsets are no longer needed.
(WebCore::HarfBuzzShaper::HarfBuzzRun::xPositionForOffset): Calculates character offset based on advance.
(WebCore::normalizeCharacters): Added.
(WebCore::HarfBuzzShaper::HarfBuzzShaper):
(WebCore::HarfBuzzShaper::~HarfBuzzShaper):
(WebCore::HarfBuzzShaper::shape): Divides TextRun first, then shapes them.
(WebCore::HarfBuzzShaper::adjustStartPoint): Added.
(WebCore::HarfBuzzShaper::collectHarfBuzzRuns): Added.
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns): Added.
(WebCore::HarfBuzzShaper::setGlyphPositionsForHarfBuzzRun): Followed other changes.
(WebCore::HarfBuzzShaper::selectionRect): Use float for calculating selection.

  • platform/graphics/harfbuzz/ng/HarfBuzzShaper.h:

(HarfBuzzShaper): Holds the start index of character. Removed unnecessary variables.
(WebCore::HarfBuzzShaper::HarfBuzzRun::create): Ditto.
(HarfBuzzRun):
(WebCore::HarfBuzzShaper::HarfBuzzRun::fontData): Added.
(WebCore::HarfBuzzShaper::HarfBuzzRun::startIndex): Ditto.
(WebCore::HarfBuzzShaper::HarfBuzzRun::glyphs): Ditto.
(WebCore::HarfBuzzShaper::HarfBuzzRun::advances): Ditto.

LayoutTests:

Add tests for harfbuzz-ng shaper. I tried to use -expected.html style expectations,
but it didn't work because there are very slight difference between CoreText and HarfBuzz in
rendering result.

  • fast/text/shaping/shaping-script-order.html: Added.
  • fast/text/shaping/shaping-selection-rect.html: Added.
  • platform/chromium/TestExpectations: Need rebaseline.
  • platform/efl/TestExpectations: Skip added tests because the port doesn't use harfbuzz.
  • platform/gtk/TestExpectations: Ditto.
  • platform/mac/TestExpectations: Ditto.
  • platform/qt/TestExpectations: Ditto.
  • platform/win/Skipped: Ditto.
  • platform/wincairo/Skipped: Ditto.
  • platform/wk2/Skipped: Ditto.
4:03 AM Changeset in webkit [122561] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r122545.
http://trac.webkit.org/changeset/122545
https://bugs.webkit.org/show_bug.cgi?id=91185

We found that this was a wrong fix

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

4:01 AM Changeset in webkit [122560] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r122553.
http://trac.webkit.org/changeset/122553
https://bugs.webkit.org/show_bug.cgi?id=91198

We found that this was a wrong fix

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

3:59 AM Changeset in webkit [122559] by tkent@chromium.org
  • 9 edits in trunk/Source/WebCore

Change the timing of form state restore
https://bugs.webkit.org/show_bug.cgi?id=89962

Reviewed by Hajime Morita.

For a preparation to fix a form identification problem (Bug 91209),
restore controls states when the parsing of their owner forms is
completed. For controls without owners, their states are restored when
their parsing is completed as ever.

No new tests. This doesn't change observable behavior.

  • html/FormController.cpp:

(WebCore::ownerFormForState):
Added. This code was used in formKey(), and restoreControlState*() use it.
(WebCore::FormKeyGenerator::formKey): Use ownerFormForState(). No behavior change.
(WebCore::FormController::restoreControlStateFor):
Moved some code from HTMLFormControlElementWithState::finishParsingChildren().
The difference is we don't resotre state if this control is owned by a form.
(WebCore::FormController::restoreControlStateIn):
Restore states of associated controls. This is called from
finishParsingChildren() for <form>.

  • html/FormController.h:

(FormController):

  • Declare restoreControlStateFor() and restoreControlStateIn().
  • Make takeStateForFormElement() private.
  • html/FormAssociatedElement.cpp:

(WebCore::FormAssociatedElement::isFormControlElementWithState):
Added. The default implementation returns false.

  • html/FormAssociatedElement.h:

(FormAssociatedElement):
Added isFormControlElementWithState() for FormController::restoreControlStateIn().

  • html/HTMLFormControlElementWithState.cpp:

(WebCore::HTMLFormControlElementWithState::finishParsingChildren):
Some code was moved to FormController:restoreControlStateFor().
(WebCore::HTMLFormControlElementWithState::isFormControlElementWithState):
Added. Returns true.

  • html/HTMLFormControlElementWithState.h:

(HTMLFormControlElementWithState): Declare isFormControlElementWithState().

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::finishParsingChildren):
Added. Calls FormController::restoreControlStateIn().

  • html/HTMLFormElement.h:

(HTMLFormElement): Declare finishParsingChildren().

3:35 AM Changeset in webkit [122558] by tkent@chromium.org
  • 16 edits
    2 copies
    5 adds in trunk

Make calendar pickers testable
https://bugs.webkit.org/show_bug.cgi?id=84827

Reviewed by Hajime Morita.

Source/WebCore:

WebCore:

  • Add PagePopupDriver, an interface to open/close a PagePopup.
  • Add setPagePopupDriver() to ChromeClient in order to inject a

PagePopupDriver for testing.

Internals:
Add MockPagePopupDriver, which creates a MockPagePopup, which creates a
normal <iframe> in the top-level document, and load the popup content on
it. MockPagePopupDriver is enabled by
internals.settings.setEnableMockPagePopup(true).

Test: fast/forms/date/calendar-picker-appearance.html

  • WebCore.gypi: Add new files.
  • WebCore.xcodeproj/project.pbxproj: Add files to make this buildable.
  • page/ChromeClient.h:

(ChromeClient): Add function for PagePopupDriver.

  • loader/EmptyClients.h: Add empty implementations for PagePopupDriver functions.
  • page/PagePopupDriver.h: Added.

(PagePopupDriver):
(WebCore::PagePopupDriver::~PagePopupDriver):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::restoreTo): Reset the mock PagePopupDriver.
(WebCore::InternalSettings::setEnableMockPagePopup):
Register MockPagePopupDriver to ChromeClient.

  • testing/InternalSettings.h:

(InternalSettings): Declare setEnableMockPagePopup().

  • testing/InternalSettings.idl: ditto.
  • testing/MockPagePopupDriver.cpp: Added.

(MockPagePopup): Pseudo PagePopup implementation with the standard <iframe>.
(WebCore::MockPagePopupDriver::MockPagePopupDriver): Added.
(WebCore::MockPagePopupDriver::create): Added.
(WebCore::MockPagePopupDriver::~MockPagePopupDriver): Added.
(WebCore::MockPagePopupDriver::openPagePopup):
Added. An override of PagePopupDriver function. This creates a MockPagePopup.
(WebCore::MockPagePopupDriver::closePagePopup):
Added. An override of PagePopupDriver function. This deletes the MockPagePopup.

  • testing/MockPagePopupDriver.h:

(MockPagePopupDriver): Added.

  • testing/v8/WebCoreTestSupport.cpp:

(WebCoreTestSupport::injectPagePopupController):
Added. Production code uses per-Page context feature framework. However
MockPagePopup uses the same page as the host page. So we can't use the
framework and need to inject window.pagePopupController manually.

  • testing/v8/WebCoreTestSupport.h:

(WebCoreTestSupport): Add injectPagePopupController().

Source/WebKit/chromium:

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::ChromeClientImpl):
Initialize m_pagePopupDriver with the WebViewImpl.
(WebKit::ChromeClientImpl::openPagePopup):
Just calls PagePoupDriver::openPagePopup().
(WebKit::ChromeClientImpl::closePagePopup):
Just calls PagePoupDriver::closePagePopup().
(WebKit::ChromeClientImpl::setPagePopupDriver):

  • src/ChromeClientImpl.h:

(ChromeClientImpl): Add setPagePopupDriver

  • src/WebViewImpl.h:

(WebViewImpl):
WebViewImpl implements PagePopupDriver. openPagePopup() and
closePagePopup() override members of PagePopupDriver.

LayoutTests:

  • fast/forms/date/calendar-picker-appearance-expected.txt: Added.
  • fast/forms/date/calendar-picker-appearance.html: Added.
  • platform/chromium-mac-snowleopard/fast/forms/date/calendar-picker-appearance-expected.png: Added.
  • platform/chromium/TestExpectations:
3:21 AM Changeset in webkit [122557] by pfeldman@chromium.org
  • 6 edits in trunk

Web Inspector: mute the native looks of the selects in the console.
https://bugs.webkit.org/show_bug.cgi?id=91120

Reviewed by Vsevolod Vlasov.

This is necessary for Mac now that we don't use border images for select.

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype.get statusBarItems):
(WebInspector.ConsoleView.prototype.addContext):
(WebInspector.ConsoleView.prototype.removeContext):
(WebInspector.ConsoleView.prototype._updateIsolatedWorldSelector):
(WebInspector.ConsoleView.prototype._appendIsolatedContextOption):
(WebInspector.ConsoleView.prototype._currentEvaluationContext):
(WebInspector.ConsoleView.prototype._currentIsolatedContextId):

  • inspector/front-end/StatusBarButton.js:

(WebInspector.StatusBarComboBox):
(WebInspector.StatusBarComboBox.prototype.addOption):
(WebInspector.StatusBarComboBox.prototype.removeOption):
(WebInspector.StatusBarComboBox.prototype.removeOptions):
(WebInspector.StatusBarComboBox.prototype.selectedOption):

  • inspector/front-end/inspector.css:

(.status-bar-select-container):
(select.status-bar-item):
(.console-context):

3:01 AM Changeset in webkit [122556] by commit-queue@webkit.org
  • 28 edits
    1 copy
    1 add in trunk

[CSS Regions] Fix the lifecycle for the flow objects and their renderers
https://bugs.webkit.org/show_bug.cgi?id=89000

Patch by Andrei Bucur <abucur@adobe.com> on 2012-07-13
Reviewed by Eric Seidel.

Source/WebCore:

This patch adds the concept of a NamedFlowCollection, owned by the document, that keeps track of
all the named flows that exist in the Document. This collection contains a ListHashSet of weak references to
all the existing NamedFlows in the document. This is not a managed set because the CREATED flows are referenced from the renderer and
the NULL flows are only cached, they should be destructible.
Two named flows are considered to be equal if they have the same name.
I've changed the NamedFlow state to depend on the existence of its renderer. A flow thread that has a renderer will also have a NamedFlow object.
A flow thread without a renderer can have a NamedFlow object, but only in the NULL state. It's possible for a NamedFlow object to jump from the
NULL state to the CREATED state if it was not destroyed (e.g. it was referenced from JS). Keeping track of the NULL state flows that have listeners will be important
so when they go back to the CREATED state, the listeners would still be there.

Link to spec: http://www.w3.org/TR/2012/WD-css3-regions-20120503/

Tests: The old tests have been modified to take into account the new behavior

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/Document.cpp:

(WebCore::Document::~Document):
(WebCore):
(WebCore::Document::webkitGetFlowByName):
(WebCore::Document::namedFlows):

  • dom/Document.h:

(WebCore):
(Document):

  • dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::WebKitNamedFlow):
(WebCore::WebKitNamedFlow::~WebKitNamedFlow):
(WebCore::WebKitNamedFlow::create):
(WebCore):
(WebCore::WebKitNamedFlow::name):
(WebCore::WebKitNamedFlow::overset):
(WebCore::nodeInFlowThread):
(WebCore::WebKitNamedFlow::getRegionsByContentNode):
(WebCore::WebKitNamedFlow::getContent):
(WebCore::WebKitNamedFlow::setRenderer):

  • dom/WebKitNamedFlow.h:

(WebCore):
(WebKitNamedFlow):
(WebCore::WebKitNamedFlow::getFlowState):
(WebCore::WebKitNamedFlow::switchFlowState):

  • dom/WebKitNamedFlowCollection.cpp: Added.

(WebCore):
(WebCore::WebKitNamedFlowCollection::WebKitNamedFlowCollection):
(WebCore::WebKitNamedFlowCollection::length): An O(1) operation
(WebCore::WebKitNamedFlowCollection::item): An O(N) operation
(WebCore::WebKitNamedFlowCollection::flowByName): An O(1) operation
(WebCore::WebKitNamedFlowCollection::ensureNamedFlowInCreatedState): An O(1) operation
(WebCore::WebKitNamedFlowCollection::moveNamedFlowToNullState): An O(1) operation
(WebCore::WebKitNamedFlowCollection::discardNamedFlow): An O(1) operation
(WebCore::WebKitNamedFlowCollection::documentDestroyed):
(WebCore::WebKitNamedFlowCollection::NamedFlowHashFunctions::hash):
(WebCore::WebKitNamedFlowCollection::NamedFlowHashFunctions::equal):
(WebKitNamedFlowCollection::NamedFlowHashFunctions):
(WebCore::WebKitNamedFlowCollection::NamedFlowHashTranslator::hash):
(WebCore::WebKitNamedFlowCollection::NamedFlowHashTranslator::equal):

  • dom/WebKitNamedFlowCollection.h: Copied from Source/WebCore/dom/WebKitNamedFlow.h.

(WebCore):
(WebKitNamedFlowCollection):
(WebCore::WebKitNamedFlowCollection::create):
(WebCore::WebKitNamedFlowCollection::document):

  • rendering/FlowThreadController.cpp:

(WebCore::FlowThreadController::ensureRenderFlowThreadWithName):
(WebCore::FlowThreadController::removeFlowThread):
(WebCore):

  • rendering/FlowThreadController.h:

(FlowThreadController):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
(WebCore):
(WebCore::RenderNamedFlowThread::~RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::removeRegionFromThread):
(WebCore::RenderNamedFlowThread::unregisterNamedFlowContentNode):
(WebCore::RenderNamedFlowThread::flowThreadName):
(WebCore::RenderNamedFlowThread::willBeDestroyed):

  • rendering/RenderNamedFlowThread.h:

(RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::contentNodes):
(WebCore::RenderNamedFlowThread::canBeDestroyed):

LayoutTests:

These tests expected getFlowByName() to return a valid object even for the NULL flows. They've been modified to
reflect the new behavior.

  • fast/regions/get-regions-by-content-node2-expected.txt:
  • fast/regions/get-regions-by-content-node2.html:
  • fast/regions/webkit-named-flow-flow-added.html:
  • fast/regions/webkit-named-flow-get-content-expected.txt:
  • fast/regions/webkit-named-flow-get-content.html:
  • fast/regions/webkit-named-flow-invalid-name.html:
  • fast/regions/webkit-named-flow-modified-flow.html:
  • fast/regions/webkit-named-flow-non-existing-flow.html:
  • fast/regions/webkit-named-flow-removed-flow.html:
  • platform/chromium-win/fast/regions/region-style-block-background-color2-expected.txt:
  • platform/mac/fast/regions/region-style-block-background-color2-expected.txt:
2:38 AM Changeset in webkit [122555] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[V8Bindings] Implement generalised method to validates that the passed object is a sequence type.
https://bugs.webkit.org/show_bug.cgi?id=91056

Patch by Vineet Chaudhary <Vineet> on 2012-07-13
Reviewed by Kentaro Hara.

Currently the V8 implementation validates that the passed object is a sequence type only
for MessagePort in V8Utilities::extractTransferables().
There should be generalised method for other types too.
Spec URL: http://www.w3.org/TR/2012/WD-WebIDL-20120207/#es-sequence

No new test, Just refactoring. There should be no behavioral changes.

  • bindings/v8/V8Binding.h:

(WebCore::toV8Sequence): Added implementation of toV8Sequence().

2:20 AM Changeset in webkit [122554] by zeno.albisser@nokia.com
  • 13 edits
    4 adds in trunk

[Qt][WK2] Implement GraphicsSurface for Linux/GLX.
https://bugs.webkit.org/show_bug.cgi?id=90881

Source/WebCore:

Add a GLX based GraphicsSurface implementation for Linux.
Native X windows are being used for exchanging textures
with the UIProcess.

Reviewed by Noam Rosenthal.

  • Target.pri:
  • WebCore.pri:
  • platform/graphics/surfaces/GraphicsSurface.cpp:

(WebCore::GraphicsSurface::create):

Move creating GraphicsSurface instance into
platformCreate/platformImport functions to allow
platform specific creation based on the provided flags.

(WebCore::GraphicsSurface::GraphicsSurface):
(WebCore::GraphicsSurface::~GraphicsSurface):

Call platformDestroy when destroying a GraphicsSurface.

(WebCore):

  • platform/graphics/surfaces/GraphicsSurface.h:

Make platformCreate/platformImport functions static
to be able to call these from the static create function.
Add Destructor prototype and add GraphicsSurfacePrivate member.

(WebCore):
(GraphicsSurface):

  • platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:

(WebCore):
(WebCore::GraphicsSurface::platformCreate):
(WebCore::GraphicsSurface::platformImport):

Insert creation of GraphicsSurface instance.
This allows having a platform specific creation mechanism
for GLX.

  • platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp: Added.

(WebCore):
(OffScreenRootWindow):
(WebCore::OffScreenRootWindow::OffScreenRootWindow):
(WebCore::OffScreenRootWindow::get):
(WebCore::OffScreenRootWindow::~OffScreenRootWindow):

Add an OffScreenRootWindow singelton that is being used
as a parent for all native offscreen windows.

(GraphicsSurfacePrivate):

This class is used to manage all the X related resources
such as opening a display or creating XPixmaps etc.

(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):

Open a connection to the X server and create a
QOpenGLContext that can be used to resolve GL functions.

(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):

Properly cleanup and release all the X resources again.

(WebCore::GraphicsSurfacePrivate::createSurface):

Create a surface that is placed off screen and can be
used as a rendering target by the WebProcess.

(WebCore::GraphicsSurfacePrivate::createPixmap):

Create a GLXPixmap from the XWindow that was previously
redirected by the WebProcess. This GLXPixmap can then be
bound to a texture and being painted on screen by the
UIProcess.

(WebCore::GraphicsSurfacePrivate::makeCurrent):
(WebCore::GraphicsSurfacePrivate::swapBuffers):
(WebCore::GraphicsSurfacePrivate::display):
(WebCore::GraphicsSurfacePrivate::glxPixmap):
(WebCore::GraphicsSurfacePrivate::size):
(WebCore::GraphicsSurfacePrivate::glContext):
(WebCore::resolveGLMethods):

Initialize all the function pointers for the GL functions used.

(WebCore::GraphicsSurface::platformExport):
(WebCore::GraphicsSurface::platformGetTextureID):

Bind the GLXPixmap to a texture.

(WebCore::GraphicsSurface::platformCopyToGLTexture):

Not beeing implemented for GLX.

(WebCore::GraphicsSurface::platformCopyFromFramebuffer):

Blit origin fbo onto the GraphicsSurface's backing.

(WebCore::GraphicsSurface::platformCreate):
(WebCore::GraphicsSurface::platformImport):
(WebCore::GraphicsSurface::platformLock):
(WebCore::GraphicsSurface::platformUnlock):
(WebCore::GraphicsSurface::platformDestroy):

Source/WebKit2:

Add a GLX based GraphicsSurface implementation for Linux.

Reviewed by Noam Rosenthal.

  • Shared/ShareableSurface.cpp:

(WebKit::ShareableSurface::create):

Only create a GraphicsSurface from a ShareableSurface::Handle
in case the Handle contains a valid GraphicsSurface token.
Otherwise fall back to creating a ShareableBitmap.

  • UIProcess/LayerTreeCoordinatorProxy.cpp:

(WebKit::createLayerTileUniqueKey):

Create a unique key for a surface based on tileID and layerID.

(WebKit::LayerTreeCoordinatorProxy::updateTileForLayer):

Even when GraphicsSurface is enabled, not all ShareableSurfaces
will necessarily be backed by a GraphicsSurface. In case of
a ShareableSurface being backed by a ShareableBitmap instead,
the GraphicsSurface token will always be null.
So instead of using the GraphicsSurface token as a key for
storing surfaces in a map, we create a unique key from
layerID and tileID.

  • UIProcess/LayerTreeCoordinatorProxy.h:

(LayerTreeCoordinatorProxy):

Tools:

Enable GraphicsSurface for Linux based platforms
whenever the Xcomposite extension is available.

Reviewed by Noam Rosenthal.

  • qmake/config.tests/libXcomposite/libXcomposite.cpp: Added.

(main):

  • qmake/config.tests/libXcomposite/libXcomposite.pro: Added. Add a configure test to detect Xcomposite extension and activate GraphicsSurface on linux in case the extension is available.
  • qmake/configure.pri:
  • qmake/mkspecs/features/features.prf:
2:05 AM Changeset in webkit [122553] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

CodeGeneratorJS.pm : SetterExpression should use 'push' rather than 'unshift'
https://bugs.webkit.org/show_bug.cgi?id=91198

Patch by Dongwoo Im <dw.im@samsung.com> on 2012-07-13
Reviewed by Kentaro Hara.

'SetterExpression' should use 'push' to make arguments, rather than 'unshift'.

No new tests. Covered by existing tests.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

1:56 AM Changeset in webkit [122552] by yosin@chromium.org
  • 7 edits in trunk

REGRESSION(r119948): [Forms] Spin button Up/Down actions make value to zero for input type "number" when step mismatched
https://bugs.webkit.org/show_bug.cgi?id=91197

Reviewed by Kent Tamura.

Source/WebCore:

This patch fixes implementation of Decimal::ceiling() and floor().
They return wrong value for small fractional numbers.

The bug is occurred when:

  • Step-able input type, e.g. number, date, datetime, and so on.
  • Current value is step mismatched
  • Current value is smaller than step
  • Step up/down by spin button

because spin button up/down actions are implemented in InputType::setpUpFromRenderer
which calls Decimal::ceiling() and floor() for step mismatched case.

Tests: fast/forms/number/number-stepup-stepdown-from-renderer.html: Added test cases

WebKit/chromium/tests/DecimalTest.cpp: Added test cases

  • platform/Decimal.cpp:

(WebCore::Decimal::ceiling): Changed to return 1 for positive small fractional number.
(WebCore::Decimal::floor): Changed to return -1 for negative small fractional number.

Source/WebKit/chromium:

This patch adds test cases for Decimal::ceiling() and floor() of
positive/negative small fractional numbers.

  • tests/DecimalTest.cpp:

(TEST_F):

LayoutTests:

This patch adds new test cases.

  • fast/forms/number/number-stepup-stepdown-from-renderer-expected.txt: Updated for new test cases.
  • fast/forms/number/number-stepup-stepdown-from-renderer.html: Added new test cases.
1:23 AM Changeset in webkit [122551] by dgrogan@chromium.org
  • 2 edits in trunk/Tools

nrwt: don't choke when printing invalid utf-8 to stderr
https://bugs.webkit.org/show_bug.cgi?id=91181

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(TestResultWriter.write_stderr):

1:06 AM Changeset in webkit [122550] by dmazzoni@google.com
  • 9 edits
    2 adds in trunk

Should be possible to focus elements within canvas fallback content
https://bugs.webkit.org/show_bug.cgi?id=87898

Reviewed by Chris Fleizach.

Source/WebCore:

Patches isFocusable in dom/Node.cpp and html/HTMLFormControlElement.cpp
to make elements focusable if they're a descendent of a canvas element
if they would otherwise have been focusable but just didn't have
a renderer. Adds a bit to ElementRareData to efficiently keep track
of elements in a canvas subtree.

Test: fast/canvas/fallback-content.html

  • dom/Element.cpp:

(WebCore::Element::attach):
(WebCore::Element::detach):
(WebCore::Element::setIsInCanvasSubtree):
(WebCore):
(WebCore::Element::isInCanvasSubtree):

  • dom/Element.h:

(Element):

  • dom/ElementRareData.h:

(ElementRareData):
(WebCore::ElementRareData::ElementRareData):

  • dom/Node.cpp:

(WebCore::Node::isFocusable):

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::attach):
(WebCore):

  • html/HTMLCanvasElement.h:

(HTMLCanvasElement):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::isFocusable):

LayoutTests:

  • fast/canvas/fallback-content-expected.txt: Added.
  • fast/canvas/fallback-content.html: Added.
12:45 AM Changeset in webkit [122549] by vsevik@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed inspector test fix.

  • http/tests/inspector/network/resources/style.css: Added.

(body):

12:39 AM Changeset in webkit [122548] by dpranke@chromium.org
  • 5 edits in trunk/Tools

test-webkitpy: more class renaming cleanup
https://bugs.webkit.org/show_bug.cgi?id=91182

Reviewed by Adam Barth.

More removing of the unnecessary "Test" prefix.

  • Scripts/webkitpy/test/finder.py:

(_DirectoryTree):
(Finder.add_tree):

  • Scripts/webkitpy/test/main.py:

(Tester._run_tests):

  • Scripts/webkitpy/test/runner.py:

(Runner):

  • Scripts/webkitpy/test/runner_unittest.py:

(RunnerTest.test_regular):
(RunnerTest.test_verbose):
(RunnerTest.test_timing):

12:26 AM Changeset in webkit [122547] by Carlos Garcia Campos
  • 19 edits
    1 move
    5 adds
    1 delete in trunk/Source

[GTK] Add API to get HTTPS status to WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=91100

Reviewed by Martin Robinson.

Source/WebCore:

  • platform/network/soup/ResourceResponse.h:

(WebCore::ResourceResponse::soupMessageCertificate): Return the
certificate.
(WebCore::ResourceResponse::setSoupMessageCertificate): Set a
certificate.
(WebCore::ResourceResponse::soupMessageTLSErrors): Return the TLS
errors.
(WebCore::ResourceResponse::setSoupMessageTLSErrors): Set TLS
errors.

  • platform/network/soup/ResourceResponseSoup.cpp:

(WebCore::ResourceResponse::toSoupMessage): Set the certificate
and TLS errors to the newly created SoupMessage.
(WebCore::ResourceResponse::updateFromSoupMessage): Get the
certificate and TLS errors from the SoupMessage.

Source/WebKit2:

Add webkit_uri_response_get_https_status() to return
GTlsCertificate and GTlsCertificateFlags with information about
the SSL certificate and the possible errors with the certificate.

  • GNUmakefile.list.am: Add new files to compilation.
  • PlatformEfl.cmake: Ditto.
  • Shared/efl/PlatformCertificateInfo.h: Removed.
  • Shared/soup/PlatformCertificateInfo.cpp: Added.

(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::~PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::encode): Encode the
GTlsCertificate and GTlsCertificateFlags.
(WebKit::PlatformCertificateInfo::decode): Decode
PlatformCertificateInfo into a GTlsCertificate and GTlsCertificateFlags.

  • Shared/soup/PlatformCertificateInfo.h: Renamed from Source/WebKit2/Shared/gtk/PlatformCertificateInfo.h.

(WebKit::PlatformCertificateInfo::certificate): Return the certificate.
(WebKit::PlatformCertificateInfo::tlsErrors): Return the TLS errors

  • UIProcess/API/gtk/WebKitLoaderClient.cpp:

(didCommitLoadForFrame): Set the certificate of the current frame
to the response of the main resource.

  • UIProcess/API/gtk/WebKitURIResponse.cpp:

(webkit_uri_response_get_https_status): Return GTlsCertificate and
GTlsCertificateFlags.
(webkitURIResponseSetCertificateInfo): Update the internal
ResourceResponse with the GTlsCertificate and GTlsCertificateFlags
of the given PlatformCertificateInfo.

  • UIProcess/API/gtk/WebKitURIResponse.h:
  • UIProcess/API/gtk/WebKitURIResponsePrivate.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.
  • UIProcess/API/gtk/tests/GNUmakefile.am:
  • UIProcess/API/gtk/tests/TestMain.h:

(Test::getResourcesDir): Helper function to get the resources
directory of the WebKit2 API tests.

  • UIProcess/API/gtk/tests/TestSSL.cpp: Added.

(testSSL):
(serverCallback):
(beforeAll):
(afterAll):

  • UIProcess/API/gtk/tests/WebKitTestServer.cpp:

(WebKitTestServer::WebKitTestServer): Add support por SSL test
servers.

  • UIProcess/API/gtk/tests/WebKitTestServer.h:

(WebKitTestServer): Add ssl parameter to create a HTTPS server.

  • UIProcess/API/gtk/tests/resources/test-cert.pem: Added.
  • UIProcess/API/gtk/tests/resources/test-key.pem: Added.

Source/WTF:

Add support for GByteArray.

  • wtf/gobject/GRefPtr.cpp:

(WTF::refGPtr):
(WTF):
(WTF::derefGPtr):

  • wtf/gobject/GRefPtr.h:

(WTF):

  • wtf/gobject/GTypedefs.h:
12:20 AM Changeset in webkit [122546] by rniwa@webkit.org
  • 5 edits
    2 adds in trunk

RadioNodeList is not updated upon input type change
https://bugs.webkit.org/show_bug.cgi?id=91178

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Invalidate the radio node lists when type content attribute changes since it excludes
image type input elements.

Test: fast/forms/radionodelist-image-type.html

  • dom/Document.cpp:

(WebCore::shouldInvalidateNodeListForType):

  • dom/Document.h: Renamed InvalidateOnIdNameForAttrChange to InvalidateOnFormAttrChange

since listing all attribute name isn't useful at this point.

  • html/RadioNodeList.cpp:

(WebCore::RadioNodeList::RadioNodeList):

LayoutTests:

Add a regression test.

  • fast/forms/radionodelist-image-type-expected.txt: Added.
  • fast/forms/radionodelist-image-type.html: Added.

Jul 12, 2012:

11:50 PM Changeset in webkit [122545] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

CodeGeneratorJS.pm need to handle the attribute which has "CallWith=ScriptExecutionContext" option.
https://bugs.webkit.org/show_bug.cgi?id=91185

Patch by Dongwoo Im <dw.im@samsung.com> on 2012-07-12
Reviewed by Kentaro Hara.

When an attribute has "CallWith=ScriptExecutionContext" option, 'ScriptExecutionContext*' parameter should be the last parameter.

No new tests. Covered by existing tests.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

11:41 PM Changeset in webkit [122544] by fpizlo@apple.com
  • 12 edits
    5 adds in trunk

DFG property access stubs should use structure transition watchpoints
https://bugs.webkit.org/show_bug.cgi?id=91135

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

This adds a Watchpoint subclass that will clear a structure stub (i.e.
a property access stub) when fired. The DFG stub generation code now
uses this optimization.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/CodeBlock.cpp:

(JSC):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::resetStub):
(JSC::CodeBlock::resetStubInternal):

  • bytecode/CodeBlock.h:

(JSC):
(CodeBlock):

  • bytecode/StructureStubClearingWatchpoint.cpp: Added.

(JSC):
(JSC::StructureStubClearingWatchpoint::~StructureStubClearingWatchpoint):
(JSC::StructureStubClearingWatchpoint::push):
(JSC::StructureStubClearingWatchpoint::fireInternal):
(JSC::WatchpointsOnStructureStubInfo::~WatchpointsOnStructureStubInfo):
(JSC::WatchpointsOnStructureStubInfo::addWatchpoint):
(JSC::WatchpointsOnStructureStubInfo::ensureReferenceAndAddWatchpoint):

  • bytecode/StructureStubClearingWatchpoint.h: Added.

(JSC):
(StructureStubClearingWatchpoint):
(JSC::StructureStubClearingWatchpoint::StructureStubClearingWatchpoint):
(WatchpointsOnStructureStubInfo):
(JSC::WatchpointsOnStructureStubInfo::WatchpointsOnStructureStubInfo):
(JSC::WatchpointsOnStructureStubInfo::codeBlock):
(JSC::WatchpointsOnStructureStubInfo::stubInfo):

  • bytecode/StructureStubInfo.h:

(JSC::StructureStubInfo::reset):
(JSC::StructureStubInfo::addWatchpoint):
(StructureStubInfo):

  • dfg/DFGRepatch.cpp:

(JSC::DFG::addStructureTransitionCheck):
(DFG):
(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::emitPutTransitionStub):

  • jit/JumpReplacementWatchpoint.h:

LayoutTests:

  • fast/js/dfg-proto-stub-watchpoint-fire-expected.txt: Added.
  • fast/js/dfg-proto-stub-watchpoint-fire.html: Added.
  • fast/js/script-tests/dfg-proto-stub-watchpoint-fire.js: Added.

(A):
(B):
(foo):

10:49 PM Changeset in webkit [122543] by yosin@chromium.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r117738): [Forms] stepMismatch for input type "time" with large step value always return false.
https://bugs.webkit.org/show_bug.cgi?id=91062

Reviewed by Kent Tamura.

This patch changes value of StepRange::acceptableError to zero for
integer restricted step value.

No new tests, existing test covers (fast/forms/time/ValidityState-stepMismatch-time.html) this change although they are listed in TestExpectation file.

  • html/StepRange.cpp:

(WebCore::StepRange::acceptableError): Changed to return 0 if step value is restricted to be an integer.

10:45 PM WebKitEFLLayoutTest edited by Christophe Dumez
(diff)
10:39 PM Changeset in webkit [122542] by commit-queue@webkit.org
  • 8 edits in trunk

[WK2][EFL] Facilitate debugging of the Web Process
https://bugs.webkit.org/show_bug.cgi?id=90768

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-12
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

The EFL port now checks if the WEB_PROCESS_CMD_PREFIX
environment variable is set and uses it as prefix
when spawning the Web process if it is. This is used
for debugging purposes with prefixes such as:
"xterm -title renderer -e gdb --args".

  • UIProcess/Launcher/ProcessLauncher.h:

(LaunchOptions):

  • UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:

(WebKit::ProcessLauncher::launchProcess):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::connect):

Tools:

Add a new --webprocess-cmd-prefix argument to
run-webkit-tests script for EFL port. If provided,
the prefix will be prepended to the command used
to spawn the Web process. This can be used for
debugging purposes with prefixes such as:
"xterm -title renderer -e gdb --args".

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort.init):
(EflPort.setup_environ_for_server):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

  • WebKitTestRunner/efl/TestControllerEfl.cpp:

(WTR::TestController::platformRunUntil): Implement support for
m_noTimeout timeout value.

10:31 PM Changeset in webkit [122541] by fpizlo@apple.com
  • 8 edits
    3 adds in trunk

DFG CFA may get overzealous in loops that have code that must exit
https://bugs.webkit.org/show_bug.cgi?id=91188

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

Ensure that if the CFA assumes that an operation must exit, then it will always exit
no matter what happens after. That's necessary to preserve soundness.

Remove a broken fixup done by the DFG simplifier, where it was trying to say that the
variable-at-head was the first access in the second block in the merge, if the first
block did not read the variable. That's totally wrong, if the first block was in fact
doing a phantom read. I removed that fixup and instead hardened the rest of the
compiler.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::endBasicBlock):

  • dfg/DFGBasicBlock.h:

(JSC::DFG::BasicBlock::BasicBlock):
(BasicBlock):

  • dfg/DFGCFAPhase.cpp:

(JSC::DFG::CFAPhase::performBlockCFA):

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::mergeBlocks):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::ConstantFoldingPhase):
(JSC::DFG::ConstantFoldingPhase::run):
(ConstantFoldingPhase):
(JSC::DFG::ConstantFoldingPhase::foldConstants):
(JSC::DFG::ConstantFoldingPhase::paintUnreachableCode):

  • dfg/DFGVariableEventStream.cpp:

(JSC::DFG::VariableEventStream::reconstruct):

LayoutTests:

Reviewed by Gavin Baraclough.

  • fast/js/dfg-force-exit-then-sparse-conditional-constant-prop-in-loop-expected.txt: Added.
  • fast/js/dfg-force-exit-then-sparse-conditional-constant-prop-in-loop.html: Added.
  • fast/js/script-tests/dfg-force-exit-then-sparse-conditional-constant-prop-in-loop.js: Added.

(foo):

10:08 PM Changeset in webkit [122540] by abarth@webkit.org
  • 2 edits in trunk/Tools

Fix crash in the commit-queue. We need to initialize self.port during init.

  • Scripts/webkitpy/tool/commands/queues.py:

(CommitQueue.init):
(CommitQueue.begin_work_queue):

9:31 PM Changeset in webkit [122539] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Pass an option flag to CFStringGetHyphenationLocationBeforeIndex() that tells it to not
terminate the search at the last word boundary before the given index.

Reviewed by Adele Peterson.

No test, because the current version of Core Foundation ignores the options parameter.

  • platform/text/cf/HyphenationCF.cpp:

(WebCore::lastHyphenLocation): Changed the options parameter from 0 to 1.

7:29 PM Changeset in webkit [122538] by morrita@google.com
  • 4 edits
    2 copies in branches/chromium/1180

Merge 122432 - [Shadow DOM] <video> with <shadow> crashes
https://bugs.webkit.org/show_bug.cgi?id=91055

Reviewed by Kent Tamura.

Source/WebCore:

This is similar to Bug 90480, where an undesired renderer is created by
locating an insertion point on the shadow boundary.

This change adds a guard for such case by cheking whether the
source node of each to-be-created renderer comes from the UA shadow
tree, which is allowed to have a renderer.

Test: fast/dom/shadow/insertion-point-video-crash.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::childShouldCreateRenderer): Added a check.
(WebCore::HTMLMediaElement::mediaControls): Added const.
(WebCore::HTMLMediaElement::hasMediaControls): Added const.

  • html/HTMLMediaElement.h:

(HTMLMediaElement):

LayoutTests:

  • fast/dom/shadow/insertion-point-video-crash-expected.txt: Added.
  • fast/dom/shadow/insertion-point-video-crash.html: Added.

TBR=morrita@google.com
Review URL: https://chromiumcodereview.appspot.com/10703186

7:12 PM Changeset in webkit [122537] by eric@webkit.org
  • 4 edits
    2 adds in trunk

Incorrect behaviour calling Range setStart or setEnd with boundary in different document
https://bugs.webkit.org/show_bug.cgi?id=42517

Reviewed by Ojan Vafai.

Source/WebCore:

Added a new static inline "checkForDifferentRootContainer" to share some code
and made setStart/setEnd do the right thing in the x-document case. I removed
the bogus checks in set*After/set*Before functions, and since they just call
through to setStart/setEnd, they also now do the right thing.

Test: fast/dom/Range/set-wrong-document-err.html

  • dom/Range.cpp:

(WebCore::checkForDifferentRootContainer):
(WebCore):
(WebCore::Range::setStart):
(WebCore::Range::setEnd):
(WebCore::Range::setStartAfter):
(WebCore::Range::setEndBefore):
(WebCore::Range::setEndAfter):
(WebCore::Range::setStartBefore):

LayoutTests:

Add a new test to cover this changed behavior, and correct a FIXME in an old test
which was documenting our incorrect behavior.

  • fast/dom/Range/set-wrong-document-err-expected.txt: Added.
  • fast/dom/Range/set-wrong-document-err.html: Added.
  • fast/dom/move-nodes-across-documents.html:
7:01 PM Changeset in webkit [122536] by dpranke@chromium.org
  • 2 edits
    2 moves in trunk/Tools

test-webkitpy: rename test_finder to finder
https://bugs.webkit.org/show_bug.cgi?id=91175

Reviewed by Adam Barth.

Rename test_finder -> finder, TestFinder -> Finder to remove
some of the stutter in the names.

  • Scripts/webkitpy/test/finder.py: Renamed from Tools/Scripts/webkitpy/test/test_finder.py.
  • Scripts/webkitpy/test/finder_unittest.py: Renamed from Tools/Scripts/webkitpy/test/test_finder_unittest.py.
  • Scripts/webkitpy/test/main.py:

(Tester.init):

6:53 PM Changeset in webkit [122535] by arv@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Simplify CodeGeneratorV8 since V8OnProto is only true for DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=91165

Reviewed by Nate Chapin.

The old code was dead code since V8OnProto only ever gets set to 1 for DOMWindow.

No new tests. No change in functionality.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrSetter):

6:26 PM Changeset in webkit [122534] by abarth@webkit.org
  • 3 edits in trunk/Tools

CommitQueue is confused about what port it is using
https://bugs.webkit.org/show_bug.cgi?id=91040

Reviewed by Dirk Pranke.

On EC2, we explicitly pass --port to the commit-queue, but that
requires editing the start-queue.sh script locally on each bot. In
moving to Google Compute Engine, we're try to avoid any local edits to
the EWSTools.

Rather than passing --port to the commit-queue, this patch teaches the
CommitQueue which port its running, which is the approach we use for
the EWS bots.

Mutating tool._deprecated_port is a bit ugly, but it's what we're doing
currently for the EWS bots.

  • Scripts/webkitpy/tool/commands/queues.py:

(CommitQueue):
(CommitQueue.begin_work_queue):
(CommitQueue.run_command):

  • Scripts/webkitpy/tool/commands/queues_unittest.py:

(CommitQueueTest.test_commit_queue):
(mock_run_webkit_patch):
(test_rollout):
(test_rollout_lands):
(test_manual_reject_during_processing):

5:34 PM Changeset in webkit [122533] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix. Initialize unused const member variables to make compilers happy.

  • dom/DynamicNodeList.h:

(WebCore::DynamicNodeListCacheBase::DynamicNodeListCacheBase):

5:29 PM Changeset in webkit [122532] by kpiascik@rim.com
  • 12 edits
    4 deletes in trunk

Web Inspector: Geolocation override
https://bugs.webkit.org/show_bug.cgi?id=89365

Source/WebCore:

Reviewed by Pavel Feldman.

Reverted original patch.
Change has not been reviewed by the right people. It declares
public protocol methods and is wrong in several ways.

  • Modules/geolocation/GeolocationController.cpp:

(WebCore::GeolocationController::GeolocationController):
(WebCore::GeolocationController::positionChanged):

  • Modules/geolocation/GeolocationController.h:

(GeolocationController):

  • inspector/Inspector.json:
  • inspector/InspectorInstrumentation.cpp:

(WebCore):

  • inspector/InspectorInstrumentation.h:

(WebCore):
(InspectorInstrumentation):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::InspectorPageAgent):

  • inspector/InspectorPageAgent.h:
  • inspector/front-end/Settings.js:
  • inspector/front-end/SettingsScreen.js:

(WebInspector.UserAgentSettingsTab):
(WebInspector.UserAgentSettingsTab.prototype._createDeviceMetricsElement):

  • inspector/front-end/UserAgentSupport.js:

LayoutTests:

Reviewed by Pavel Feldman.
Change has not been reviewed by the right people. It declares
public protocol methods and is wrong in several ways.

Reverted original patch.

  • inspector/geolocation-error-expected.txt: Removed.
  • inspector/geolocation-error.html: Removed.
  • inspector/geolocation-success-expected.txt: Removed.
  • inspector/geolocation-success.html: Removed.
5:20 PM Changeset in webkit [122531] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

Move m_type and m_hasNameCache from HTMLCollectionCacheBase to DynamicNodeListCacheBase for better bit packing
https://bugs.webkit.org/show_bug.cgi?id=91164

Reviewed by Anders Carlsson.

Moved m_type and m_hasNameCache from HTMLCollection and renamed them to m_collectionType and m_isNameCacheValid.

Also renamed shouldIncludeChildren to shouldOnlyIncludeDirectChildren and negated the return value since
all HTMLCollection include children in the collection and the function was meant to tell us whether the collection
should include descendents that are not direct children of base().

In addition, renamed nextNodeOrSibling to nextNode since "or sibling" doesn't seem to add any semantic clarity.

  • dom/DynamicNodeList.h:

(WebCore::DynamicNodeListCacheBase::DynamicNodeListCacheBase):
(DynamicNodeListCacheBase):
(WebCore::DynamicNodeListCacheBase::type):
(WebCore::DynamicNodeListCacheBase::hasNameCache):
(WebCore::DynamicNodeListCacheBase::setHasNameCache):
(WebCore::DynamicNodeListCacheBase::clearCache):

  • html/HTMLCollection.cpp:

(WebCore::shouldOnlyIncludeDirectChildren):
(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::isAcceptableElement):
(WebCore::nextNode):
(WebCore::HTMLCollection::itemAfter):

  • html/HTMLCollection.h:

(WebCore::HTMLCollectionCacheBase::HTMLCollectionCacheBase):
(HTMLCollectionCacheBase):
(WebCore::HTMLCollectionCacheBase::clearCache):

5:09 PM Changeset in webkit [122530] by shinyak@chromium.org
  • 5 edits in trunk/Source/WebCore

Needs callback before AuthorShadowRoot is added.
https://bugs.webkit.org/show_bug.cgi?id=91167

Reviewed by Hajime Morita.

This is a preliminary patch for adding multiple Shadow DOM support for media elements and form elements.
They assume that UserAgentShadowRoot is the oldest, however currently a page author may try to add
AuthorShadowRoot before adding UserAgentShadowRoot.

This patch adds a callback before AuthorShadowRoot is being added, and allow us to add UserAgentShadowRoot
for those elements. See also Bug 77936, Bug 77937, Bug 90532.

  • dom/Element.h:

(WebCore::Element::willAddAuthorShadowRoot):

  • dom/ElementShadow.cpp:

(WebCore::ElementShadow::addShadowRoot):

  • dom/ElementShadow.h:

(ElementShadow):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::create):

4:38 PM Changeset in webkit [122529] by enne@google.com
  • 3 edits
    3 adds in trunk

[chromium] Root invalidations for RTL pages need to be in the right space
https://bugs.webkit.org/show_bug.cgi?id=91155

Reviewed by Kenneth Russell.

Source/WebKit/chromium:

The root layer has a translation on it when placed in the tree, so any
invalidations on this layer likewise need to be adjusted.

This adjustment is due to the fact that compositor layers all have the
origin in the upper left corner of the layer, but this is not always
the origin for graphics layers. Rather than making compositor layers
have to deal with a potential offset, we change the transform when
inserting the layer into the tree. Invalidations need to be similarly
transformed from document space into compositor layer space.

The need for this offset is due to the definition of the initial
containing block. RTL pages (pages with dir=RTL on the body) start
scrolled all the way to the right, and the origin is in the upper left
hand corner of this initial viewport. Thus on RTL pages with
horizontal overflow, the left of the document is in negative CSS
space.

  • src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::invalidateRect):

LayoutTests:

Add a test that demonstrates this problem. Before the code fix, the
test shows just a red square because the invalidation for the style
change repaints the wrong rect.

  • compositing/rtl/rtl-overflow-invalidation-expected.png: Added.
  • compositing/rtl/rtl-overflow-invalidation-expected.txt: Added.
  • compositing/rtl/rtl-overflow-invalidation.html: Added.
4:30 PM Changeset in webkit [122528] by dpranke@chromium.org
  • 6 edits
    1 copy
    98 adds in trunk

[Navigation Timing] Import the W3C Navigation Timing test suite
https://bugs.webkit.org/show_bug.cgi?id=84887

Patch by James Simonsen <simonjam@chromium.org> on 2012-07-12
Reviewed by Tony Gentilcore.

Tools:

  • Scripts/import-w3c-performance-wg-tests: Added.

LayoutTests:

  • http/tests/resources/testharness.css: Added.
  • http/tests/resources/testharness.js: Copied from LayoutTests/resources/testharness.js.
  • http/tests/resources/testharnessreport.js: Copied from LayoutTests/resources/testharnessreport.js.
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_document_open-expected.txt: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_document_open.html: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_document_readiness_exist-expected.txt: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_document_readiness_exist.html: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_navigate_within_document-expected.txt: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_navigate_within_document.html: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_navigation_attributes_exist-expected.txt: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_navigation_attributes_exist.html: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_navigation_redirectCount_none-expected.txt: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_navigation_redirectCount_none.html: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_navigation_type_backforward-expected.txt: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_navigation_type_backforward.html: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_navigation_type_enums-expected.txt: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_navigation_type_enums.html: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_navigation_type_reload-expected.txt: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_navigation_type_reload.html: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_no_previous_document-expected.txt: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_no_previous_document.html: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_performance_attributes_exist-expected.txt: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_performance_attributes_exist.html: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_performance_attributes_exist_in_object-expected.txt: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_performance_attributes_exist_in_object.html: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_readwrite-expected.txt: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_readwrite.html: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_attributes_exist-expected.txt: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_attributes_exist.html: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_attributes_order-expected.txt: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_attributes_order.html: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_client_redirect-expected.txt: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_client_redirect.html: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_reload-expected.txt: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_reload.html: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_server_redirect-expected.txt: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_server_redirect.html: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect-expected.txt: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect.html: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_unique_performance_objects-expected.txt: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html/test_unique_performance_objects.html: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_document_open-expected.txt: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_document_open.html: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_document_readiness_exist-expected.txt: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_document_readiness_exist.html: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_navigate_within_document-expected.txt: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_navigate_within_document.html: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_navigation_attributes_exist-expected.txt: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_navigation_attributes_exist.html: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_navigation_redirectCount_none-expected.txt: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_navigation_redirectCount_none.html: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_navigation_type_backforward-expected.txt: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_navigation_type_backforward.html: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_navigation_type_enums-expected.txt: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_navigation_type_enums.html: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_navigation_type_reload-expected.txt: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_navigation_type_reload.html: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_no_previous_document-expected.txt: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_no_previous_document.html: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_performance_attributes_exist-expected.txt: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_performance_attributes_exist.html: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_performance_attributes_exist_in_object-expected.txt: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_performance_attributes_exist_in_object.html: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_readwrite-expected.txt: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_readwrite.html: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_attributes_exist-expected.txt: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_attributes_exist.html: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_attributes_order-expected.txt: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_attributes_order.html: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_client_redirect-expected.txt: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_client_redirect.html: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_reload-expected.txt: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_reload.html: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_server_redirect-expected.txt: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_server_redirect.html: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_xserver_redirect-expected.txt: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_xserver_redirect.html: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_unique_performance_objects-expected.txt: Added.
  • http/tests/w3c/webperf/approved/navigation-timing/html5/test_unique_performance_objects.html: Added.
  • http/tests/w3c/webperf/resources/blank_page_green.htm: Added.
  • http/tests/w3c/webperf/resources/blank_page_green_with_onunload.htm: Added.
  • http/tests/w3c/webperf/resources/blank_page_meta_redirect.htm: Added.
  • http/tests/w3c/webperf/resources/blank_page_unload.htm: Added.
  • http/tests/w3c/webperf/resources/blank_page_yellow.htm: Added.
  • http/tests/w3c/webperf/resources/blank_page_yellow_with_onunload.htm: Added.
  • http/tests/w3c/webperf/resources/pagevistestharness.js: Added.
  • http/tests/w3c/webperf/resources/redirect.php: Added.
  • http/tests/w3c/webperf/resources/webperftestharness.js: Added.
  • platform/mac/Skipped: Skip new webperf tests.
  • platform/win/Skipped: Ditto.
  • platform/wincairo/Skipped: Ditto.
  • resources/testharness.css: Added.
  • resources/testharnessreport.js: Support async tests.
4:27 PM Changeset in webkit [122527] by abarth@webkit.org
  • 2 edits in trunk/Tools

Unreviewed. Nit: git config files use tabs, not spaces.

  • EWSTools/cold-boot.sh:
4:26 PM Changeset in webkit [122526] by kseo@webkit.org
  • 2 edits in trunk/Tools

Unreviewed. Add Dongsung Huang to the list of contributors. He
has submitted over 30 patches on texture mapper, canvas and image decoders.

  • Scripts/webkitpy/common/config/committers.py:
4:26 PM Changeset in webkit [122525] by danakj@chromium.org
  • 12 edits in trunk/Source

[chromium] Remove the RenderPass pointer from RenderPassDrawQuad
https://bugs.webkit.org/show_bug.cgi?id=91023

Reviewed by Adrienne Walker.

Source/WebCore:

Removes the RenderPass pointer and keeps only an integer id in the
quad to refer back to the RenderPass the quad reads from.

Covered by existing tests.

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::findRenderPassById):
(WebCore):
(WebCore::removeRenderPassesRecursive):
(WebCore::CCLayerTreeHostImpl::CullRenderPassesWithCachedTextures::shouldRemoveRenderPass):
(WebCore::CCLayerTreeHostImpl::CullRenderPassesWithNoQuads::shouldRemoveRenderPass):
(WebCore::CCLayerTreeHostImpl::removeRenderPasses):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(FrameData):
(CullRenderPassesWithCachedTextures):
(CullRenderPassesWithNoQuads):
(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::appendQuadsForRenderSurfaceLayer):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(WebCore):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:

(WebCore::CCRenderPassDrawQuad::create):
(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:

(CCRenderPassDrawQuad):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::appendQuads):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(CCRenderSurface):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:
4:14 PM Changeset in webkit [122524] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

Unneeded tree walking when adding or removing children due to RenderCounter / RenderQuote logic
https://bugs.webkit.org/show_bug.cgi?id=89900

Patch by Elliott Sprehn <Elliott Sprehn> on 2012-07-12
Reviewed by Eric Seidel and Abhishek Arya.

Previously we would walk the all children a renderer whenever adding
or removing a child renderer from its RenderObjectChildList to look for
RenderQuote and RenderCounter instances to update. This patch introduces
a counter in RenderView for the number of RenderQuote and RenderCounter
instances in that document so we can avoid these traversals.

No tests needed since this is just a short circuiting of logic and the existing
tests should cover it.

  • rendering/RenderCounter.cpp:

(WebCore::RenderCounter::RenderCounter): Increment instance counter.
(WebCore::RenderCounter::willBeDestroyed): Decrement instance counter.
(WebCore):
(WebCore::RenderCounter::rendererRemovedFromTree): Short circuit when counter is zero.
(WebCore::RenderCounter::rendererSubtreeAttached): Short circuit when counter is zero.

  • rendering/RenderCounter.h:

(RenderCounter):

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode): Short circuit calling into Counter and Quote code when the document is being destroyed.

  • rendering/RenderQuote.cpp:

(WebCore::RenderQuote::RenderQuote):
(WebCore::RenderQuote::willBeDestroyed):
(WebCore):
(WebCore::RenderQuote::rendererSubtreeAttached): Increment instance counter.
(WebCore::RenderQuote::rendererRemovedFromTree): Decrement instance counter.

  • rendering/RenderQuote.h:

(RenderQuote):

  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):

  • rendering/RenderView.h: Methods for managing the RenderQuote and RenderCounter counts.

(RenderView):
(WebCore::RenderView::addRenderQuote):
(WebCore::RenderView::removeRenderQuote):
(WebCore::RenderView::hasRenderQuotes):
(WebCore::RenderView::addRenderCounter):
(WebCore::RenderView::removeRenderCounter):
(WebCore::RenderView::hasRenderCounters):

4:13 PM Changeset in webkit [122523] by abarth@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] WebSettings should be sorted
https://bugs.webkit.org/show_bug.cgi?id=91157

Reviewed by Eric Seidel.

This might be my OCD, but IMHO this file would be cleaner if we listed
the settings in alphabetic order.

  • public/WebSettings.h:
  • src/WebSettingsImpl.h:

(WebSettingsImpl):
(WebKit::WebSettingsImpl::forceSoftwareCompositing):
(WebKit::WebSettingsImpl::viewportEnabled):
(WebKit::WebSettingsImpl::maxUntiledLayerSize):

4:12 PM Changeset in webkit [122522] by kseo@webkit.org
  • 2 edits in trunk/Tools

Unreviewed. Change my irc nickname to kseo.

  • Scripts/webkitpy/common/config/committers.py:
4:02 PM Changeset in webkit [122521] by wjmaclean@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. SKIP inspector/elements/edit-dom-actions.html on Win Debug
https://bugs.webkit.org/show_bug.cgi?id=60109

Since we can't use SLOW and TIMEOUT together, let's skip this test until it is fixed.

  • platform/chromium/TestExpectations:
3:58 PM Changeset in webkit [122520] by timothy@apple.com
  • 3 edits in trunk/Source/WebKit2

Make the "Inspect Element" context menu item appear in nightly builds again.

https://webkit.org/b/89323

Reviewed by Anders Carlsson.

  • Shared/API/c/WKContextMenuItem.cpp:

(compatibleContextMenuItemTag): Added. Checks for the specific version of Safari 6 that needs the
tag fixed up to match values it expects.
(WKContextMenuItemGetTag): On Mac platforms call compatibleContextMenuItemTag to fix up the tag
before returning it.

  • Shared/API/c/WKContextMenuItemTypes.h: Fix the order of the WKContextMenuItemTag enum

to be binary compatible with older versions of WebKit2.

3:43 PM Changeset in webkit [122519] by Hugo Parente Lima
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Unreviewed. Adding myself to commiters.py.

3:40 PM Changeset in webkit [122518] by rniwa@webkit.org
  • 12 edits in trunk/Source/WebCore

Merge HTMLCollectionWithArrayStorage into HTMLCollection
https://bugs.webkit.org/show_bug.cgi?id=91144

Reviewed by Anders Carlsson.

Merged HTMLCollectionWithArrayStorage::item into HTMLCollection::item and got rid of
HTMLCollectionWithArrayStorage. Also de-virtualized HTMLCollection::item and HTMLCollection::length
and merged itemInArrayAfter and itemAfter.

In addition, improved the algorithm in HTMLCollection::length to take advantage of item cache.
Instead of always computing the length from the beginning, we start the search from the cached item
so that if we're near end of the collection, we avoid significant portion of the node traversal.

Furthermore, made HTMLCollection always call setItemCache with a non-null item and HTMLCollection::item
set the length cache when it reaches the end of the collection to avoid redundant length calculations.

  • dom/DynamicNodeList.h:

(WebCore::DynamicNodeListCacheBase::setItemCache): Add a FIXME.

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::itemAfter): Regular HTMLCollection doesn't have uses elements array so
assert that offsetInArray is always 0.
(WebCore): Removed calcLength.
(WebCore::HTMLCollection::length): Rewritten. The algorithm is as follows:
When there is no item cache, we look for the first item by calling item(0). If item(0) returns null,
then it must have set the length cache so bail out. If the previous step didn't bail out, then
the item cache is valid and not null (see above), so count the number of remaining items in collection
starting at the cached item's offset + 1.
(WebCore::HTMLCollection::item): Avoid calling setItemCache with null. When the first item is null,
set the length cache instead.
(WebCore::HTMLCollection::itemAfterCachedItem): Extracted from HTMLCollectionWithArrayStorage::item.
(WebCore::HTMLCollection::namedItem): Pass in arrayOffset to itemAfter. Note this variable is never
used since only HTMLFormCollection and HTMLPropertiesCollection use array offsets but they override
this function.
(WebCore::HTMLCollection::updateNameCache): Ditto.

  • html/HTMLCollection.h:

(HTMLCollection):
(WebCore):

  • html/HTMLFormCollection.cpp: Removed calcLength(). Even though this function didn't iterate over

the collection directly, HTMLFormElement::length and HTMLFieldSetElement::length did so we're not
regressing any performance here.
(WebCore::HTMLFormCollection::HTMLFormCollection):
(WebCore::HTMLFormCollection::itemAfter):

  • html/HTMLFormCollection.h:

(HTMLFormCollection):

  • html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::itemAfter):

  • html/HTMLNameCollection.h:

(HTMLNameCollection):

  • html/HTMLPropertiesCollection.cpp: Removed calcLength().

(WebCore::HTMLPropertiesCollection::HTMLPropertiesCollection):
(WebCore::HTMLPropertiesCollection::itemAfter):
(WebCore):

  • html/HTMLPropertiesCollection.h:

(HTMLPropertiesCollection):

  • html/HTMLTableRowsCollection.cpp:

(WebCore::HTMLTableRowsCollection::itemAfter):

  • html/HTMLTableRowsCollection.h:

(HTMLTableRowsCollection):

3:35 PM Changeset in webkit [122517] by dpranke@chromium.org
  • 2 edits in trunk/Tools

webkitpy: clean up logging handlers, lint common.message_pool
https://bugs.webkit.org/show_bug.cgi?id=91152

Reviewed by Ojan Vafai.

The unix implementation of multiprocessing clones any logging
handlers from the parent process into the child; we currently
don't want this behavior in our code, so I was hand-removing the
installed handlers in the child process I knew about. After thinking
about it further, I think it was simpler and safe enough to just
remove all handlers in the child, since the message pool
propagates any message from the child back into the parent.

We can always change this in the future if it turns out to be an issue.

I'm also fixing a couple of other lint warnings while I'm at it.

  • Scripts/webkitpy/common/message_pool.py:

(_MessagePool.exit):
(_MessagePool._handle_worker_exception):
(_Worker._set_up_logging):

3:33 PM Changeset in webkit [122516] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Row size/position is wrongly calculated when table having overlapping rowspan cell and colspan cell
https://bugs.webkit.org/show_bug.cgi?id=16811

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-07-12
Reviewed by Julien Chaffraix.

Source/WebCore:

The height of a row is calculated by taking the max height of the cells contained in it. When a row contains
a rowSpan cell and if this row is not the last row of the cell, then its height is max height of other non
rowSpan cells. If the row is the last row of the rowSpan cell, then using the contraint laid by CSS2.1 spec
"For a rowSpan cell, the sum of the row heights involved must be great enough to encompass the cell spanning the rows",
the last remaining height of the rowSpan(cell height minus heights of other involved rows) is taken into consideration
while calculating the height of this row.
Currently when calculating the height of the row we are only using the height of the primary cell at position (row, col).
However when a row has colSpan cell and rowSpan, they might overlap. In such a sitution as only the primary cells height
is considered, the height of the row will be calculated worngly if the other overlapping cell has greater height.
Thus all the overlapping cell at position (row, col) must be considered while calculating the height of a row.

Test: fast/table/last-cell-of-rowspan-overlapping-colspan-cell.html

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):
Fixed function to use all the overlapping cells at position(row, col) to calculate the height/position of rows.

LayoutTests:

  • fast/table/last-cell-of-rowspan-overlapping-colspan-cell-expected.html: Added.
  • fast/table/last-cell-of-rowspan-overlapping-colspan-cell.html: Added.
3:19 PM Changeset in webkit [122515] by jsbell@chromium.org
  • 11 edits
    2 adds in trunk

IndexedDB: Enable IDBFactory.deleteDatabase() and webkitGetDatabaseNames() in Workers
https://bugs.webkit.org/show_bug.cgi?id=90310

Reviewed by Tony Chang.

Source/WebCore:

Simplify Document vs. Worker logic for IDBFactory::open() and hook up the
other two IDBFactory methods for use by workers as well.

Test: storage/indexeddb/factory-basics-workers.html

  • Modules/indexeddb/IDBFactory.cpp:

(isContextValid): Helper function consolidating checks that context is usable.
(getIndexedDBDatabasePath): Helper function for accessing group settings.
(WebCore::IDBFactory::getDatabaseNames): Simplify - just pass context through to back end.
(WebCore::IDBFactory::open): Ditto.
(WebCore::IDBFactory::deleteDatabase): Ditto.
(WebCore::IDBFactory::cmp): Whitespace.

  • Modules/indexeddb/IDBFactoryBackendImpl.cpp: Obsolete openFromWorker() removed.

(WebCore::IDBFactoryBackendImpl::getDatabaseNames): Signature updated.
(WebCore::IDBFactoryBackendImpl::deleteDatabase): Signature updated.
(WebCore::IDBFactoryBackendImpl::open): Signature updated.

  • Modules/indexeddb/IDBFactoryBackendImpl.h:

(IDBFactoryBackendImpl):

  • Modules/indexeddb/IDBFactoryBackendInterface.h: Interface methods now take both SecurityOrigin

and ScriptExecutionContext, but not Frame. In the proxy, SecurityOrigin is redundant (can be
accessed from context) but on the real back end the context is null (as Frame was previously).
(IDBFactoryBackendInterface):

  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):
(WebCore::InspectorIndexedDBAgent::requestDatabaseNamesForFrame):
(WebCore::InspectorIndexedDBAgent::requestDatabase):
(WebCore::InspectorIndexedDBAgent::requestData):

Source/WebKit/chromium:

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::allowIndexedDB): Consolidates user-prompting logic.
(WebKit::getWebFrame): Helper to dig out frame from Document, or null for Worker.
(WebKit::IDBFactoryBackendProxy::getDatabaseNames):
(WebKit):
(WebKit::IDBFactoryBackendProxy::open):
(WebKit::IDBFactoryBackendProxy::deleteDatabase):

  • src/IDBFactoryBackendProxy.h: Update method signatures to match interface.

(WebCore):
(IDBFactoryBackendProxy):

LayoutTests:

  • storage/indexeddb/factory-basics-workers-expected.txt: Added.
  • storage/indexeddb/factory-basics-workers.html: Added.
  • storage/indexeddb/resources/factory-basics.js: Allow use by Worker as well as Window.

(getDatabaseNamesSuccess1):
(openSuccess):
(getDatabaseNamesSuccess2):
(getDatabaseNamesSuccess3):

3:10 PM Rebaseline edited by ojan@chromium.org
(diff)
3:05 PM Changeset in webkit [122514] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

rebaseline fast/harness/results.html after r122505.

Unreviewed, expectations change.

  • fast/harness/results-expected.txt:
2:56 PM WikiStart edited by ojan@chromium.org
(diff)
2:55 PM Changeset in webkit [122513] by dpranke@chromium.org
  • 3 edits
    1 move in trunk/Tools

webkitpy: rename manager_worker_broker to message_pool
https://bugs.webkit.org/show_bug.cgi?id=91145

Reviewed by Ojan Vafai.

Since the MessagePool interface is more generic (and simpler)
now and will be reused by test-webkitpy, I'm renaming it and
moving it to webkitpy.common.

  • Scripts/webkitpy/common/message_pool.py: Renamed from Tools/Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py.
  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(TestRunInterruptedException.reduce):
(Manager._run_tests.worker_factory):
(Manager._run_tests):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2:46 PM Changeset in webkit [122512] by commit-queue@webkit.org
  • 2 edits
    10 adds in trunk/Source/WebKit2

[EFL] Port the test framework to WebKit 2
https://bugs.webkit.org/show_bug.cgi?id=90606

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-12
Reviewed by Kenneth Rohde Christiansen.

This port of EFL's WebKit 1 test framework uses a more gtest-ish
way of writing tests and it is based on a test fixture that loads a
page synchronously as convenience (if needed). This base fixture can be
easily extended by just inheriting from it.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp: Added.

(EWK2UnitTest):
(EWK2UnitTest::onLoadProgress):
(EWK2UnitTest::EWK2UnitTestBase::EWK2UnitTestBase):
(EWK2UnitTest::EWK2UnitTestBase::SetUp):
(EWK2UnitTest::EWK2UnitTestBase::TearDown):
(EWK2UnitTest::EWK2UnitTestBase::loadUrlSync):

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h: Added.

(EWK2UnitTest):
(EWK2UnitTestBase):
(EWK2UnitTest::EWK2UnitTestBase::setLoadProgress):
(EWK2UnitTest::EWK2UnitTestBase::webView):

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.cpp: Added.

(EWK2UnitTest):
(EWK2UnitTest::EWK2UnitTestEnvironment::EWK2UnitTestEnvironment):
(EWK2UnitTest::EWK2UnitTestEnvironment::defaultTestPageUrl):

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h: Added.

(EWK2UnitTest):
(EWK2UnitTestEnvironment):
(EWK2UnitTest::EWK2UnitTestEnvironment::useX11Window):
(EWK2UnitTest::EWK2UnitTestEnvironment::defaultWidth):
(EWK2UnitTest::EWK2UnitTestEnvironment::defaultHeight):

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestMain.cpp: Added.

(parseArguments):
(main):

  • UIProcess/API/efl/tests/resources/default_test_page.html: Added.
  • UIProcess/API/efl/tests/test_ewk2_view.cpp: Added.

(TEST_F):

2:42 PM Changeset in webkit [122511] by danakj@chromium.org
  • 4 edits in trunk/Source

[chromium] The root layer should not try create a second RenderSurface for itself
https://bugs.webkit.org/show_bug.cgi?id=91124

Reviewed by Adrienne Walker.

Source/WebCore:

Tests: CCLayerTreeHostImplTest.rootLayerDoesntCreateExtraSurface

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::subtreeShouldRenderToSeparateSurface):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:
2:42 PM Changeset in webkit [122510] by abarth@webkit.org
  • 1 delete in trunk/LayoutTests/fast/wcss

Delete another empty directory.

2:41 PM Changeset in webkit [122509] by abarth@webkit.org
  • 4 edits
    2 adds in trunk

Regression (r122359) Layout Test html5lib/runner.html is failing
https://bugs.webkit.org/show_bug.cgi?id=91047

Reviewed by Tony Chang.

Source/WebCore:

This ASSERT is bogus because doctypes can be removed from the DOM and
then re-added.

Test: fast/viewport/viewport-legacy-xhtmlmp-remove-and-add.html

  • dom/Document.cpp:

(WebCore::Document::setDocType):

LayoutTests:

Add a test that shows what happens when a doctype gets added and
removed.

  • fast/viewport/viewport-legacy-xhtmlmp-remove-and-add-expected.txt: Added.
  • fast/viewport/viewport-legacy-xhtmlmp-remove-and-add.html: Added.
  • platform/chromium/TestExpectations:
2:38 PM Changeset in webkit [122508] by ojan@chromium.org
  • 11 edits
    2 adds in trunk

Implied minimum size of flex items is min-content
https://bugs.webkit.org/show_bug.cgi?id=87546

Reviewed by Tony Chang.

Source/WebCore:

http://dev.w3.org/csswg/css3-flexbox/#min-size-auto
In the main axis direction, min-size of auto means min-content.

Test: css3/flexbox/flex-item-min-size.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
(WebCore::RenderBox::computeContentLogicalHeightUsing):
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
It turned out that these FIXMEs are all unnecessary with the changes to RenderFlexibleBox.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
(WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax):

LayoutTests:

Mostly just set min-height/min-width:0 as appropriate to keep the tests testing
what the used to be testing. I made sure that each rendering was correct before
making the changes. In a couple cases, I changed expectations where I thought
the test was still testing was it was intending to test.

  • css3/flexbox/child-overflow.html:
  • css3/flexbox/columns-auto-size.html:
  • css3/flexbox/cross-axis-scrollbar.html:
  • css3/flexbox/flex-item-min-size-expected.txt: Added.
  • css3/flexbox/flex-item-min-size.html: Added.
  • css3/flexbox/flexitem.html:
  • css3/flexbox/line-wrapping.html:
  • css3/flexbox/perpendicular-writing-modes-inside-flex-item.html:
  • css3/flexbox/repaint-rtl-column.html:
2:37 PM Changeset in webkit [122507] by kseo@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Increase the drawing performance by merging dirty rects.
https://bugs.webkit.org/show_bug.cgi?id=91075

Patch by Huang Dongsung <luxtella@company100.net> on 2012-07-12
Reviewed by Noam Rosenthal.

QWebFramePrivate calls FrameView::paintContents as many as the number of dirty
rects, so it causes too many redundant render tree traversals.
I changed it to merge dirty rects and call FrameView::paintContents only once.
The algorithm to merge rects is copied from GTK.

When parallel image decoders are in use, each image is independently repainted
when decoding is finished. This creates a lot by repaint requests. So by merging
these repaint requests, I could improve rendering performance.

For example, I tested parallel image decoders on the locally mirrored Pinterest site.
QWebFramePrivate called FrameView::paintContents 165 times after parallel image
decoders decoded all the images. It took about 120ms on my six-core Intel Xeon machine.
This patch decreases painting time from 120ms to 30ms.

  • Api/qwebframe.cpp:

(coalesceRectsIfPossible):
(QWebFramePrivate::renderRelativeCoords):

2:35 PM Changeset in webkit [122506] by commit-queue@webkit.org
  • 34 edits
    1 copy
    5 deletes in trunk/Source

[chromium] Use CCTexture/TextureAllocator and remove TextureManager
https://bugs.webkit.org/show_bug.cgi?id=91001

Patch by Eric Penner <epenner@google.com> on 2012-07-12
Reviewed by Adrienne Walker.

Source/WebCore:

Use CCTexture to clean up CCPrioritizedTexture::Backing.
Add TextureAllocator.h and remove remainder of TextureManager.h/cpp.
Minor move/refactoring of link/unlink in CCPrioritizedTexture.
Remove double initialization of the default memory limit.

Covered by existing tests (refactoring).

  • WebCore.gypi:
  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:
  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h:

(WebCore):

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:
  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:

(WebCore):

  • platform/graphics/chromium/ImageLayerChromium.cpp:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):

  • platform/graphics/chromium/ManagedTexture.cpp: Removed.
  • platform/graphics/chromium/ManagedTexture.h: Removed.
  • platform/graphics/chromium/RenderSurfaceChromium.h:

(WebCore):

  • platform/graphics/chromium/TextureAllocator.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCPriorityCalculator.h.

(WebCore):
(TextureAllocator):
(WebCore::TextureAllocator::~TextureAllocator):

  • platform/graphics/chromium/TextureManager.cpp: Removed.
  • platform/graphics/chromium/TextureManager.h: Removed.
  • platform/graphics/chromium/TiledLayerChromium.cpp:
  • platform/graphics/chromium/TrackingTextureAllocator.cpp:

(WebCore::TrackingTextureAllocator::createTexture):
(WebCore::TrackingTextureAllocator::deleteTexture):

  • platform/graphics/chromium/TrackingTextureAllocator.h:
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::prioritizeTextures):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCPrioritizedTexture.cpp:

(WebCore::CCPrioritizedTexture::CCPrioritizedTexture):
(WebCore::CCPrioritizedTexture::setDimensions):
(WebCore::CCPrioritizedTexture::textureId):
(WebCore::CCPrioritizedTexture::bindTexture):
(WebCore::CCPrioritizedTexture::framebufferTexture2D):
(WebCore::CCPrioritizedTexture::link):
(WebCore):
(WebCore::CCPrioritizedTexture::unlink):

  • platform/graphics/chromium/cc/CCPrioritizedTexture.h:

(WebCore):
(WebCore::CCPrioritizedTexture::bytes):
(CCPrioritizedTexture):
(WebCore::CCPrioritizedTexture::haveBackingTexture):
(WebCore::CCPrioritizedTexture::Backing::Backing):
(WebCore::CCPrioritizedTexture::Backing::~Backing):
(WebCore::CCPrioritizedTexture::Backing::owner):
(Backing):
(WebCore::CCPrioritizedTexture::backing):

  • platform/graphics/chromium/cc/CCPrioritizedTextureManager.cpp:

(WebCore::CCPrioritizedTextureManager::prioritizeTextures):
(WebCore::CCPrioritizedTextureManager::requestLate):
(WebCore::CCPrioritizedTextureManager::acquireBackingTextureIfNeeded):
(WebCore::CCPrioritizedTextureManager::reduceMemory):
(WebCore::CCPrioritizedTextureManager::clearAllMemory):
(WebCore::CCPrioritizedTextureManager::registerTexture):
(WebCore::CCPrioritizedTextureManager::returnBackingTexture):
(WebCore::CCPrioritizedTextureManager::createBacking):
(WebCore::CCPrioritizedTextureManager::destroyBacking):
(WebCore::CCPrioritizedTextureManager::assertInvariants):

  • platform/graphics/chromium/cc/CCPrioritizedTextureManager.h:

(CCPrioritizedTextureManager):
(WebCore::CCPrioritizedTextureManager::defaultMemoryAllocationLimit):
(WebCore::CCPrioritizedTextureManager::compareBackings):

  • platform/graphics/chromium/cc/CCPriorityCalculator.h:
  • platform/graphics/chromium/cc/CCScopedTexture.cpp:
  • platform/graphics/chromium/cc/CCScopedTexture.h:
  • platform/graphics/chromium/cc/CCTexture.h:

(WebCore::CCTexture::CCTexture):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

Source/WebKit/chromium:

Deleting old texture manager tests.

  • WebKit.gypi:
  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/CCPrioritizedTextureTest.cpp:

(WTF::CCPrioritizedTextureTest::texturesMemorySize):

  • tests/CCThreadedTest.cpp:
  • tests/CCTiledLayerTestCommon.h:
  • tests/Canvas2DLayerBridgeTest.cpp:
  • tests/TextureManagerTest.cpp: Removed.
2:22 PM Changeset in webkit [122505] by dpranke@chromium.org
  • 8 edits in trunk

nrwt crashes saving the output for a platform-specific expected test reference
https://bugs.webkit.org/show_bug.cgi?id=90872

Reviewed by Ojan Vafai.

Tools:

The expected output for a test is copied alongside the test
itself in the layout-test-results directory; in other words, for
foo/bar-expected.txt sits alongside foo/bar.html even if we're
actually using platform/mac/foo/bar-expected.txt.

Unless the test is a reftest, in which case we would copy the
output to platform/mac/foo/bar-expected.html and set a
'ref_file' parameter in results.json to indicate the path. This
can be useful in the cases where we have multiple references for
a single test or when multiple tests share the same reference.

We found a bug where we weren't creating platform/mac/foo under
the results directory, and so this wasn't actually working.
However, treating reftests differently seems like a bad thing,
so we should probably be consistent. This change puts the
-expected.html next to the test, and reworks test_result_writer
so that we create directories uniformly and consistently.

Note that we weren't catching this problem in unit tests because
the MockFileSystem creates a directory automatically if it
doesn't exist; this was done intentionally for convenience, but
is really a bug and should be fixed; see https://bugs.webkit.org/show_bug.cgi?id=91028.

I have not added additional tests here since fixing that bug
should be sufficient.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(interpret_test_failures):

  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ResultSummaryTest.test_interpret_test_failures):

  • Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(write_test_result):
(TestResultWriter._write_binary_file):
(TestResultWriter):
(TestResultWriter._write_text_file):
(TestResultWriter.write_output_files):
(TestResultWriter.write_stderr):
(TestResultWriter.write_crash_log):
(TestResultWriter.create_text_diff_and_write_result):
(TestResultWriter.write_image_diff_files):
(write_reftest):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(EndToEndTest.test_reftest_with_two_notrefs):

LayoutTests:

Remove tests for the 'ref_file' parameter in results.json
entries.

  • fast/harness/resources/results-test.js:
  • fast/harness/results.html:
2:09 PM Changeset in webkit [122504] by abarth@webkit.org
  • 1 edit
    2 deletes in trunk/LayoutTests

Unreviewed. Delete two empty directories.

  • platform/google-chrome-linux32: Removed.
  • platform/google-chrome-linux64: Removed.
2:06 PM Changeset in webkit [122503] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Let XCode have its own way.

  • WebCore.xcodeproj/project.pbxproj:
1:53 PM Changeset in webkit [122502] by jchaffraix@webkit.org
  • 3 edits
    4 adds in trunk
ASSERT(genChild->isListMarker()
genChild->style()->styleType() == FIRST_LETTER) triggered on flex-box content

https://bugs.webkit.org/show_bug.cgi?id=91003

Reviewed by Abhishek Arya.

Source/WebCore:

Tests: fast/flexbox/assert-generated-deprecated-flexbox.html

fast/flexbox/assert-generated-new-flexbox.html

The issue was that findBeforeAfterParent didn't return the right parent for the flex-box case. This would
make us update the wrong children (and not propagate the style updates properly).

  • rendering/RenderObjectChildList.cpp:

(WebCore::findBeforeAfterParent):
Added a check for flex boxes (both deprecated and new).

LayoutTests:

  • fast/flexbox/assert-generated-deprecated-flexbox-expected.txt: Added.
  • fast/flexbox/assert-generated-deprecated-flexbox.html: Added.
  • fast/flexbox/assert-generated-new-flexbox-expected.txt: Added.
  • fast/flexbox/assert-generated-new-flexbox.html: Added.
1:48 PM Changeset in webkit [122501] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Percentage width replaced element in zero percent/fixed width container block incorrectly rendered.
https://bugs.webkit.org/show_bug.cgi?id=9493

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-07-12
Reviewed by Andy Estes.

Source/WebCore:

When the width of the container is zero percent/fixed value then the width of the replaced element must also be zero.

Test: fast/css/percent-width-img-inside-zero-percent-and-fixed-container.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalWidthUsing):

When the containing block's available width is zero there can be two cases.
The containing block is floated/positioned in which case the width of the replaced child element must be its instrinsic width.
On the other hand if the width of the container is specified to be either zero percent or fixed value then the width of the
replaced elment must be zero.

LayoutTests:

  • fast/css/percent-width-img-inside-zero-percent-and-fixed-container-expected.html: Added.
  • fast/css/percent-width-img-inside-zero-percent-and-fixed-container.html: Added.
  • fast/css/resources/red-box.png: Added. Image resource file for the test case.
1:44 PM Changeset in webkit [122500] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit2

[WK2] Add missing Network Information API integration to WebContext and WebPage
https://bugs.webkit.org/show_bug.cgi?id=90781

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-12
Reviewed by Anders Carlsson.

Integrate Network Information API to WebPage, WebContext and
properly route messages to the WebNetworkInfoManagerProxy.
Without this, the Network Information tests are crashing for
WebKit2.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::disconnectProcess):
(WebKit::WebContext::didReceiveMessage):
(WebKit::WebContext::didReceiveSyncMessage):

  • UIProcess/WebContext.h:

(WebKit):
(WebContext):
(WebKit::WebContext::networkInfoManagerProxy):

  • UIProcess/WebNetworkInfoManagerProxy.cpp:

(WebKit::WebNetworkInfoManagerProxy::didReceiveSyncMessage):
(WebKit):

  • UIProcess/WebNetworkInfoManagerProxy.h:

(WebNetworkInfoManagerProxy):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveMessage):
(WebKit::WebProcessProxy::didReceiveSyncMessage):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

1:39 PM Changeset in webkit [122499] by dpranke@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

2012-07-12 Dirk Pranke <dpranke@chromium.org>

Remove chromium-mac-leopard baselines.

Rubber-stamped by Tony Chang.

Chromium no longer actively supports the Leopard (10.5) version
of Mac OS and doesn't have any bots running it, so we don't need
the baselines any more.

1:31 PM Changeset in webkit [122498] by rniwa@webkit.org
  • 20 edits in trunk/Source/WebCore

invalidateNodeListsCacheAfterAttributeChanged should dynamically figure out which attribute needs invalidation
https://bugs.webkit.org/show_bug.cgi?id=91046

Reviewed by Anders Carlsson.

Added an array of counters (m_nodeListCounts) for each set of attributes (NodeListInvalidationType) node lists care about
to Document, and made DynamicSubtreeNodeList's constructor and destructor increment and decrement these counters via
registerDynamicSubtreeNodeList and unregisterDynamicSubtreeNodeList respectively. shouldInvalidateDynamicSubtreeNodeList,
which is called by invalidateNodeListsCacheAfterAttributeChanged, then use these counters to determine whether a given
attribute change should result in node list invalidations.

Also removed m_numNodeListCaches from TreeScope because this counter has now become redundant with m_nodeListCounts.

  • dom/ChildNodeList.cpp:

(WebCore::ChildNodeList::ChildNodeList): Do not invalidate on attribute changes.

  • dom/ClassNodeList.cpp:

(WebCore::ClassNodeList::ClassNodeList): Invalidate on class attribute changes.

  • dom/Document.cpp:

(WebCore::Document::Document): Initialize m_nodeListCounts.
(WebCore::Document::~Document): Add assertions to make sure m_listsInvalidatedAtDocument, m_nodeListCounts, and
m_collections are all empty.
(WebCore::Document::registerDynamicSubtreeNodeList): This function is now called for all DynamicSubtreeNodeLists supposed
to just ones rooted at the document in order to increment the counter for each invalidation type.
(WebCore::Document::unregisterDynamicSubtreeNodeList): Ditto.
(WebCore::shouldInvalidateDynamicSubtreeNodeListForType): Checks the attribute name against NodeListInvalidationType.
(WebCore::Document::shouldInvalidateDynamicSubtreeNodeList): Returns true if the given attribute name matches the invalidation
type of the existing DynamicSubtreeNodeLists in the document. If the attribute name is not given (used when children change),
then it checks for the existence of any DynamicSubtreeNodeLists. Conceptually, this function can be written as a list of
"if" statements that checks values in m_nodeListCounts and the attribute name. We use "for" loop and switch statement instead
to share logic and detect future addition of values to NodeListInvalidationType.

  • dom/Document.h:

(Document): Moved RootType and InvalidationType from DynamicNodeListCacheBase and renamed them to NodeListRootType and
NodeListInvalidationType respectively in order to reduce the possibility of future name collisions. Also the invalidation type
now contains 6 values instead of 2.

  • dom/DynamicNodeList.cpp:

(WebCore):

  • dom/DynamicNodeList.h:

(WebCore::DynamicNodeListCacheBase::DynamicNodeListCacheBase):
(WebCore::DynamicNodeListCacheBase::shouldInvalidateOnAttributeChange):
(WebCore::DynamicNodeListCacheBase::rootType): Added.
(WebCore::DynamicNodeListCacheBase::invalidationType): Added.
(DynamicNodeListCacheBase): Uses 3 bits to store invalidation type now that the number of values have increased from 2 to 6.
(WebCore::DynamicNodeList::DynamicNodeList):
(WebCore::DynamicSubtreeNodeList::~DynamicSubtreeNodeList): Call unregisterDynamicSubtreeNodeList.
(WebCore::DynamicSubtreeNodeList::DynamicSubtreeNodeList): Call registerDynamicSubtreeNodeList.

  • dom/MicroDataItemList.cpp:

(WebCore::MicroDataItemList::MicroDataItemList): Invalidate on itemscope, itemprop, and itemtype content attribute changes.

  • dom/NameNodeList.cpp:

(WebCore::NameNodeList::NameNodeList): Invalidate on name attribute changes.

  • dom/Node.cpp:

(WebCore::Node::clearRareData):
(WebCore::Node::invalidateNodeListsCacheAfterAttributeChanged): Replaced the hard coded check list of attributes, by a call
to shouldInvalidateDynamicSubtreeNodeList.
(WebCore::Node::invalidateNodeListsCacheAfterChildrenChanged): Calls shouldInvalidateDynamicSubtreeNodeList.
(WebCore::Node::getElementsByTagName):
(WebCore::Node::getElementsByTagNameNS):
(WebCore::Node::getElementsByName):
(WebCore::Node::getElementsByClassName):
(WebCore::Node::radioNodeList):
(WebCore::NodeRareData::createNodeLists):

  • dom/NodeRareData.h:

(WebCore::NodeListsNodeData::adoptTreeScope): Unregister and register node lists in m_tagNodeListCacheNS since all node lists
need to be accounted in m_nodeListCounts.
(WebCore::NodeRareData::ensureNodeLists):
(NodeRareData):

  • dom/TagNodeList.cpp:

(WebCore::TagNodeList::TagNodeList): Do not invalidate on any attribute changes.

  • dom/TreeScope.cpp:

(WebCore::TreeScope::TreeScope): No longer initializes m_numNodeListCaches since it has been removed.

  • dom/TreeScope.h:

(TreeScope): Removed m_numNodeListCaches.

  • dom/TreeScopeAdopter.cpp:

(WebCore::TreeScopeAdopter::moveTreeToNewScope):

  • html/HTMLCollection.h:

(WebCore::HTMLCollectionCacheBase::HTMLCollectionCacheBase): Just pass in DoNotInvalidateOnAttributeChanges for now since
it's never used in HTMLCollections.

  • html/LabelableElement.cpp:

(WebCore::LabelableElement::labels):

  • html/LabelsNodeList.cpp:

(WebCore::LabelsNodeList::LabelsNodeList): Invalidate on for content attribute changes.
(WebCore::LabelsNodeList::~LabelsNodeList):

  • html/RadioNodeList.cpp:

(WebCore::RadioNodeList::RadioNodeList): Invalidate on id, name, and for content attribute changes.
(WebCore::RadioNodeList::~RadioNodeList):

1:22 PM Changeset in webkit [122497] by dpranke@chromium.org
  • 2 edits
    1 delete in trunk/Tools

nrwt: reimplement manager_worker_broker in a much simpler form
https://bugs.webkit.org/show_bug.cgi?id=90513

Reviewed by Ojan Vafai.

This is a wholesale replacement of the MessagePool() implementation
and the other classes in manager_worker_broker.py. All of the
BrokerConnection*, Broker*, etc. classes are gone, and there are now
just a MessagePool class and a _Worker class. Happiness ensues.

I'm removing manager_worker_broker_unittest.py as well; we get
nearly complete coverage from the integration tests, and will
get more coverage when test-webkitpy moves to use this as well,
so having unit tests seems like unnecessary overhead. (running
coverage numbers with test-webkitpy shows that pretty much the only
uncovered lines are lines that are only run in the child processes,
which coverage doesn't handle at the moment).

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:

(_MessagePool.init):
(_MessagePool.run):
(_MessagePool._start_workers):
(_MessagePool):
(_MessagePool.wait):
(_MessagePool._close):
(_MessagePool._handle_done):
(_MessagePool._can_pickle):
(_MessagePool._loop):
(WorkerException):
(_Message.init):
(_Message.repr):
(_Worker):
(_Worker.init):
(_Worker.terminate):
(_Worker._close):
(_Worker.run):
(_Worker.post):
(_Worker.yield_to_caller):
(_Worker._post):
(_Worker._raise):
(_Worker._set_up_logging):
(_WorkerLogHandler.init):
(_WorkerLogHandler.emit):

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py: Removed.
1:19 PM Changeset in webkit [122496] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium][Mac] r122400 broke 10.6 build
https://bugs.webkit.org/show_bug.cgi?id=91103

Patch by Robert Sesek <rsesek@chromium.org> on 2012-07-12
Reviewed by Tony Chang.

Use the right availability macros for forward-declaring methods and
defining constants.

  • src/mac/WebInputEventFactory.mm:
1:04 PM Changeset in webkit [122495] by aestes@apple.com
  • 2 edits in trunk/LayoutTests

[Mac] input-in-table-cell-no-value.html fails due to INPUT_TYPE_DATE being disabled.

  • platform/mac/TestExpectations: Mark input-in-table-cell-no-value.html

as expected to fail.

12:59 PM Changeset in webkit [122494] by barraclough@apple.com
  • 2 edits in trunk/Source/WebCore

Threadsafety issues in WebScriptObject
https://bugs.webkit.org/show_bug.cgi?id=90849

Reviewed by Filip Pizlo & Oliver Hunt.

Updated fix for this bug. Taking the JSC API lock from WebScriptObject::release
may not be safe; better to just guard the JSWrapperCache with its own spinlock.

  • bindings/objc/WebScriptObject.mm:

(WebCore::getJSWrapper):

  • Added spinlock; also retain/autorelease the returned wrapper - it is unsafe to wait for the caller to do so, due to a race condition vs release removing the wrapper from the map.

(WebCore::addJSWrapper):

  • Take the spinlock guarding the cache.

(WebCore::removeJSWrapper):

  • Take the spinlock guarding the cache.

(WebCore::removeJSWrapperIfRetainCountOne):

  • Take the spinlock guarding the cache, remove the wrapper if retainCount is one.

(WebCore::createJSWrapper):

  • Remove the API lock; this method no longer needs to retain/autorelease (this is done by getJSWrapper).

(-[WebScriptObject _setImp:originRootObject:rootObject:]):

  • Remove the API lock.

(-[WebScriptObject release]):

  • Remove the API lock, retainCount check moved into removeJSWrapperIfRetainCountOne.
12:49 PM Changeset in webkit [122493] by wjmaclean@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. Layout Test storage/indexeddb/constants.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=91133

Has started to crash occassionally on WebKitWin, cause unknown.

  • platform/chromium/TestExpectations:
12:22 PM Changeset in webkit [122492] by abarth@webkit.org
  • 1 edit
    2 deletes in trunk/LayoutTests

LayoutTests/platform/google-chrome-linux32 and google-chrome-linux64 are empty and should be removed
https://bugs.webkit.org/show_bug.cgi?id=91114

Reviewed by Tony Chang.

These directories are empty and haven't been touched in over a year.
We should remove them.

  • platform/google-chrome-linux32: Removed.
  • platform/google-chrome-linux32/README: Removed.
  • platform/google-chrome-linux64: Removed.
  • platform/google-chrome-linux64/README: Removed.
12:12 PM Changeset in webkit [122491] by mjs@apple.com
  • 2 edits in trunk/Source/WTF

Document ListHashSet iteration guarantees
https://bugs.webkit.org/show_bug.cgi?id=91106

Reviewed by Eric Seidel.

  • wtf/ListHashSet.h:

(WTF): Expand class comment to document this.

12:02 PM Changeset in webkit [122490] by wjmaclean@chromium.org
  • 2 edits
    3 copies
    1 add in trunk/LayoutTests

[chromium] Unreviewed gardening. Re-baseline expected text for fast/multicol/table-vertical-align.html

  • platform/chromium-linux-x86/fast/multicol/table-vertical-align-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/multicol/table-vertical-align-expected.txt.
  • platform/chromium-linux/fast/multicol/table-vertical-align-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/multicol/table-vertical-align-expected.txt.
  • platform/chromium-mac-snowleopard/fast/multicol/table-vertical-align-expected.txt: Added.
  • platform/chromium-win-xp/fast/multicol/table-vertical-align-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/multicol/table-vertical-align-expected.txt.
  • platform/chromium-win/fast/multicol/table-vertical-align-expected.txt:
11:46 AM Changeset in webkit [122489] by hyatt@apple.com
  • 3 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=91000
REGRESSION (r122244): Overflow elements don't shrink as much as they should.

Reviewed by Simon Fraser.

This is a fix for a a regression from https://bugs.webkit.org/show_bug.cgi?id=90646.

I incorrectly analyzed the issue with Robert Hogan's negative margin patch and fooled myself into putting back
in an incorrect minimum width check from long ago.

What should have happened in the test case I patched is that the overflow element should shrink to 0. The issue
with improving the logical top estimate in the previous patch is it made the clear delta become 0. This in turn
exposed a bug in our clearing algorithm with Robert's changes where you could need a relayout even if you didn't
actually move. This issue only occurs because the floats list is getting changed mid-layout because of negative margins.

The patch changes getClearDelta to call setChildNeedsLayout(true) on children whose widths change even when their
positions do not. In effect this dynamic addition of new floats after you have done a layout on the child already means
that you can need to lay out again despite not actually having to move.

To handle this, the code that does the relayout is now called if the child needs a relayout. This is done even if
the logical top estimate matches the final position.

No new tests required, since the test in fast/block/float is now correctly covering the issue.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::getClearDelta):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::shrinkLogicalWidthToAvoidFloats):

11:31 AM Changeset in webkit [122488] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

storage tests are flaky (crashing) on windows
https://bugs.webkit.org/show_bug.cgi?id=90469

Patch by James Weatherall <wez@chromium.org> on 2012-07-12
Reviewed by Kentaro Hara.

Add a missing check that the underlying V8 object reference in a V8 NPObject is valid, and zero the NPObject's rootObject member when disposing it, to ensure that it won't be mistakenly touched after that point.

This patch is intended to resolve flakiness in the storage tests including:

storage/indexeddb/mozilla/indexes.html
storage/indexeddb/mozilla/key-requirements-inline-and-passed.html
storage/websql/multiple-databases-garbage-collection.html

  • bindings/v8/NPV8Object.cpp:

(WebCore::disposeUnderlyingV8Object):
Zero the NPObject's underlying rootObject.
(_NPN_EvaluateHelper):
Add check that the underlying V8 object reference is valid.

11:24 AM Changeset in webkit [122487] by wjmaclean@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. inspector/elements/edit-dom-actions.html is timing out on Win Debug.
https://bugs.webkit.org/show_bug.cgi?id=60109

This test has recently started timing out on Win Debug bots. It was already slow, but has gotten much worse,
but times are also quite variable.

  • platform/chromium/TestExpectations:
11:22 AM Changeset in webkit [122486] by tony@chromium.org
  • 6 edits in trunk

[chromium] Remove drag and drop API methods that are no longer used
https://bugs.webkit.org/show_bug.cgi?id=90996

Reviewed by Adam Barth.

Source/WebKit/chromium:

In r117327, we added a parameter for modifier keys to these methods.
Chromium has since switched to using the methods that require the
extra parameter so we can remove these methods.

  • public/WebView.h:

(WebView):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::dragTargetDragEnter):
(WebKit::WebViewImpl::dragTargetDragOver):

  • src/WebViewImpl.h:

(WebViewImpl):

Tools:

Migrate DRT to use the methods that take modifier keys.

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::doDragDrop):
(EventSender::doMouseUp):
(EventSender::doMouseMove):
(EventSender::beginDragWithFiles):

11:20 AM Changeset in webkit [122485] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
11:14 AM Changeset in webkit [122484] by noam.rosenthal@nokia.com
  • 9 edits
    4 moves in trunk/Source

Move TextureMapperAnimation and texmap/LayerTransform to platform/graphics
https://bugs.webkit.org/show_bug.cgi?id=91111

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

TextureMapperAnimation and LayerTransform are not specific to TextureMapper, and we want
to use them for other purposes as well. Moving them to platform/graphics would make that
more explicit.

No new tests, moving files around.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • platform/graphics/GraphicsLayerAnimation.cpp: Renamed from Source/WebCore/platform/graphics/texmap/TextureMapperAnimation.cpp.
  • platform/graphics/GraphicsLayerAnimation.h: Renamed from Source/WebCore/platform/graphics/texmap/TextureMapperAnimation.h.
  • platform/graphics/GraphicsLayerTransform.cpp: Renamed from Source/WebCore/platform/graphics/texmap/LayerTransform.cpp.
  • platform/graphics/GraphicsLayerTransform.h: Renamed from Source/WebCore/platform/graphics/texmap/LayerTransform.h.
  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::addAnimation):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:

(GraphicsLayerTextureMapper):

  • platform/graphics/texmap/TextureMapperLayer.h:

(TextureMapperLayer):
(WebCore::TextureMapperLayer::setAnimatedTransform):
(WebCore::TextureMapperLayer::setAnimatedOpacity):

Source/WebKit2:

Include the new filenames.

  • WebProcess/WebPage/LayerTreeCoordinator/WebGraphicsLayer.h:

(WebGraphicsLayer):

11:04 AM Changeset in webkit [122483] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Delete last mention of Hixie76 in WebKit/chromium
https://bugs.webkit.org/show_bug.cgi?id=91099

Reviewed by Tony Chang.

This deprecated API is no longer used anywhere.

  • public/WebSettings.h:

(WebKit::WebSettings::setDefaultDeviceScaleFactor):

10:59 AM Changeset in webkit [122482] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Simplify UISourceCode code after moving revisions support inside it.
https://bugs.webkit.org/show_bug.cgi?id=91118

Reviewed by Pavel Feldman.

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype._setContent):
(WebInspector.UISourceCode.prototype.revertToOriginal):
(WebInspector.UISourceCode.prototype.revertAndClearHistory):
(WebInspector.UISourceCode.prototype.contentChanged):
(WebInspector.UISourceCode.prototype.commitWorkingCopy):
(WebInspector.Revision.prototype.revertToThis):

10:57 AM Changeset in webkit [122481] by ojan@chromium.org
  • 3 edits in trunk/Tools

Allow putting ranges in user.py list prompts
https://bugs.webkit.org/show_bug.cgi?id=91115

Reviewed by Adam Barth.

Ranges are inclusive and denoted by a dash. This is useful for rebaselining a whole port
since the items are listed with each port's builders being contiguous.

  • Scripts/webkitpy/common/system/user.py:

(User._wait_on_list_response):

  • Scripts/webkitpy/common/system/user_unittest.py:

(UserTest.test_prompt_with_multiple_lists.run_prompt_test):
(UserTest.test_prompt_with_multiple_lists):

10:33 AM Changeset in webkit [122480] by rjkroege@chromium.org
  • 1 edit in branches/chromium/1180/Source/WebCore/platform/ScrollAnimator.cpp

Merge 122382 - [chromium] [regression] Don't use ScrollByPrecisePixels on Chromium Mac.
https://bugs.webkit.org/show_bug.cgi?id=91020

Reviewed by Adam Barth.

A change in https://bugs.webkit.org/show_bug.cgi?id=87535 to
improve the operation of smooth scrolling incorrectly caused
Chromium Mac to use the wrong scroll granularity on
hasPreciseScrollingDeltas() == true wheelevent scrolls.
Exclude the change on the Chromium Mac platform.

  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::handleWheelEvent): Adjusted #ifdef to exclude Chromium
Mac from ScrollByPrecisePixels change.

TBR=rjkroege@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10693166

10:29 AM Changeset in webkit [122479] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r122477.
http://trac.webkit.org/changeset/122477
https://bugs.webkit.org/show_bug.cgi?id=91103

Broke Chromium Mac build

  • src/mac/WebInputEventFactory.mm:
10:21 AM Changeset in webkit [122478] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk/Source/WebKit2

[Qt][WK2] Implement web notifications support
https://bugs.webkit.org/show_bug.cgi?id=80702

Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2012-07-12
Reviewed by Noam Rosenthal.

Adding a new type of permission request for Desktop Notifications (plus required code
to register the handle for this requests).

  • UIProcess/API/qt/qwebpermissionrequest.cpp:

(QWebPermissionRequestPrivate::QWebPermissionRequestPrivate):
(QWebPermissionRequestPrivate):
(QWebPermissionRequest::create):
(QWebPermissionRequest::QWebPermissionRequest):
(QWebPermissionRequest::setAllow):

  • UIProcess/API/qt/qwebpermissionrequest_p.h:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_notification.qml: Added.
  • UIProcess/API/qt/tests/qmltests/common/notification.html: Added.
  • UIProcess/qt/QtWebPageUIClient.cpp:

(WebKit::QtWebPageUIClient::QtWebPageUIClient):
(WebKit::QtWebPageUIClient::policyForNotificationPermissionRequest):
(WebKit):

  • UIProcess/qt/QtWebPageUIClient.h:
10:11 AM Changeset in webkit [122477] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium][Mac] r122400 broke 10.6 build
https://bugs.webkit.org/show_bug.cgi?id=91103

Patch by Robert Sesek <rsesek@chromium.org> on 2012-07-12
Reviewed by Tony Chang.

Use the right availability macros for forward-declaring methods and
defining constants.

  • src/mac/WebInputEventFactory.mm:
10:10 AM Changeset in webkit [122476] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

WebPage::executeJavaScriptFunction crashes when there is an exception
https://bugs.webkit.org/show_bug.cgi?id=91098
RIM PR #149294

When there is an exception currently the code tries to get the string of
the exception via JSValueToStringCopy to pass back, but this cases a
crash inside JavaScriptCore, so change it to simply return false and not
set the return value with the exception string.

Patch by Benjamin C Meyer <bmeyer@rim.com> on 2012-07-12
Reviewed by George Staikos.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::executeJavaScriptFunction):

10:10 AM Changeset in webkit [122475] by jsbell@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

IndexedDB: Verify internal "delete pending" flag on database
https://bugs.webkit.org/show_bug.cgi?id=90995

Reviewed by Tony Chang.

Verify the behavior required by the spec that an open() following
a deleteDatabase() is delayed and returns a new database.

  • storage/indexeddb/database-deletepending-flag-expected.txt: Added.
  • storage/indexeddb/database-deletepending-flag.html: Added.
  • storage/indexeddb/resources/database-deletepending-flag.js: Added.

(test):
(openConnection.request.onsuccess.request.onsuccess):
(openConnection.request.onsuccess):
(openConnection):
(testDatabaseDelete.connection.onversionchange):
(testDatabaseDelete.deleteRequest.onblocked):
(testDatabaseDelete.deleteRequest.onsuccess):
(testDatabaseDelete.openRequest.onsuccess):
(testDatabaseDelete):

10:07 AM Changeset in webkit [122474] by allan.jensen@nokia.com
  • 2 edits in trunk/Source/WebCore

Unreviewed. Build fix for r122462.

  • platform/qt/MemoryUsageSupportQt.cpp:
10:01 AM Changeset in webkit [122473] by allan.jensen@nokia.com
  • 6 edits
    14 moves
    2 adds in trunk/LayoutTests

Move nodesFromRect tests to separate sub-directory.
https://bugs.webkit.org/show_bug.cgi?id=90986

Reviewed by Antonio Gomes.

Moving all nodesFromRect based tests to separate sub-directory will make it easier to test or skip them collectively.

  • fast/dom/nodesFromRect/nodesFromRect-basic-expected.txt: Renamed from LayoutTests/fast/dom/nodesFromRect-basic-expected.txt.
  • fast/dom/nodesFromRect/nodesFromRect-basic.html: Renamed from LayoutTests/fast/dom/nodesFromRect-basic.html.
  • fast/dom/nodesFromRect/nodesFromRect-culled-inlines-expected.txt: Renamed from LayoutTests/fast/dom/nodesFromRect-culled-inlines-expected.txt.
  • fast/dom/nodesFromRect/nodesFromRect-culled-inlines.html: Renamed from LayoutTests/fast/dom/nodesFromRect-culled-inlines.html.
  • fast/dom/nodesFromRect/nodesFromRect-inner-documents-expected.txt: Renamed from LayoutTests/fast/dom/nodesFromRect-inner-documents-expected.txt.
  • fast/dom/nodesFromRect/nodesFromRect-inner-documents.html: Renamed from LayoutTests/fast/dom/nodesFromRect-inner-documents.html.
  • fast/dom/nodesFromRect/nodesFromRect-links-and-text-expected.txt: Renamed from LayoutTests/fast/dom/nodesFromRect-links-and-text-expected.txt.
  • fast/dom/nodesFromRect/nodesFromRect-links-and-text.html: Renamed from LayoutTests/fast/dom/nodesFromRect-links-and-text.html.
  • fast/dom/nodesFromRect/nodesFromRect-svg-expected.txt: Renamed from LayoutTests/fast/dom/nodesFromRect-svg-expected.txt.
  • fast/dom/nodesFromRect/nodesFromRect-svg.html: Renamed from LayoutTests/fast/dom/nodesFromRect-svg.html.
  • fast/dom/nodesFromRect/nodesFromRect-table-expected.txt: Renamed from LayoutTests/fast/dom/nodesFromRect-table-expected.txt.
  • fast/dom/nodesFromRect/nodesFromRect-table.html: Renamed from LayoutTests/fast/dom/nodesFromRect-table.html.
  • fast/dom/nodesFromRect/resources/nodesFromRect.css: Renamed from LayoutTests/fast/dom/resources/nodesFromRect.css.
  • fast/dom/nodesFromRect/resources/nodesFromRect.js: Renamed from LayoutTests/fast/dom/resources/nodesFromRect.js.
  • media/nodesFromRect-shadowContent.html:
  • platform/chromium/TestExpectations:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
9:52 AM Changeset in webkit [122472] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Enable building APKs for TestWebKitAPI and webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=90989

Reviewed by Adam Barth.

Add dependencies on the webkit_unit_tests_apk and TestWebKitAPI_apk
targets for Android, making sure that we're generating the packages.

  • All.gyp:
9:44 AM Changeset in webkit [122471] by abarth@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed. Remove a large number of empty directories.

  • platform/chromium-win-vista: Removed.
  • platform/chromium-win-vista/canvas: Removed.
  • platform/chromium-win-vista/canvas/philip: Removed.
  • platform/chromium-win-vista/canvas/philip/tests: Removed.
  • platform/chromium-win-vista/compositing: Removed.
  • platform/chromium-win-vista/compositing/geometry: Removed.
  • platform/chromium-win-vista/compositing/overflow: Removed.
  • platform/chromium-win-vista/compositing/shadows: Removed.
  • platform/chromium-win-vista/css1: Removed.
  • platform/chromium-win-vista/css1/font_properties: Removed.
  • platform/chromium-win-vista/css1/text_properties: Removed.
  • platform/chromium-win-vista/css1/units: Removed.
  • platform/chromium-win-vista/css2.1: Removed.
  • platform/chromium-win-vista/css3: Removed.
  • platform/chromium-win-vista/css3/selectors3: Removed.
  • platform/chromium-win-vista/css3/selectors3/html: Removed.
  • platform/chromium-win-vista/css3/selectors3/xhtml: Removed.
  • platform/chromium-win-vista/css3/selectors3/xml: Removed.
  • platform/chromium-win-vista/editing: Removed.
  • platform/chromium-win-vista/editing/inserting: Removed.
  • platform/chromium-win-vista/editing/pasteboard: Removed.
  • platform/chromium-win-vista/editing/style: Removed.
  • platform/chromium-win-vista/fast: Removed.
  • platform/chromium-win-vista/fast/backgrounds: Removed.
  • platform/chromium-win-vista/fast/backgrounds/repeat: Removed.
  • platform/chromium-win-vista/fast/backgrounds/size: Removed.
  • platform/chromium-win-vista/fast/block: Removed.
  • platform/chromium-win-vista/fast/block/positioning: Removed.
  • platform/chromium-win-vista/fast/box-shadow: Removed.
  • platform/chromium-win-vista/fast/canvas: Removed.
  • platform/chromium-win-vista/fast/canvas/webgl: Removed.
  • platform/chromium-win-vista/fast/compact: Removed.
  • platform/chromium-win-vista/fast/css: Removed.
  • platform/chromium-win-vista/fast/dom: Removed.
  • platform/chromium-win-vista/fast/dom/Document: Removed.
  • platform/chromium-win-vista/fast/dom/HTMLAnchorElement: Removed.
  • platform/chromium-win-vista/fast/dom/HTMLMeterElement: Removed.
  • platform/chromium-win-vista/fast/dom/HTMLProgressElement: Removed.
  • platform/chromium-win-vista/fast/forms: Removed.
  • platform/chromium-win-vista/fast/inline: Removed.
  • platform/chromium-win-vista/fast/inline-block: Removed.
  • platform/chromium-win-vista/fast/js: Removed.
  • platform/chromium-win-vista/fast/media: Removed.
  • platform/chromium-win-vista/fast/multicol: Removed.
  • platform/chromium-win-vista/fast/multicol/vertical-rl: Removed.
  • platform/chromium-win-vista/fast/parser: Removed.
  • platform/chromium-win-vista/fast/repaint: Removed.
  • platform/chromium-win-vista/fast/replaced: Removed.
  • platform/chromium-win-vista/fast/sub-pixel: Removed.
  • platform/chromium-win-vista/fast/sub-pixel/selection: Removed.
  • platform/chromium-win-vista/fast/table: Removed.
  • platform/chromium-win-vista/fast/text: Removed.
  • platform/chromium-win-vista/fast/text/international: Removed.
  • platform/chromium-win-vista/fast/text/whitespace: Removed.
  • platform/chromium-win-vista/fast/writing-mode: Removed.
  • platform/chromium-win-vista/http: Removed.
  • platform/chromium-win-vista/http/tests: Removed.
  • platform/chromium-win-vista/http/tests/appcache: Removed.
  • platform/chromium-win-vista/http/tests/loading: Removed.
  • platform/chromium-win-vista/http/tests/media: Removed.
  • platform/chromium-win-vista/http/tests/misc: Removed.
  • platform/chromium-win-vista/http/tests/multipart: Removed.
  • platform/chromium-win-vista/http/tests/security: Removed.
  • platform/chromium-win-vista/http/tests/security/aboutBlank: Removed.
  • platform/chromium-win-vista/media: Removed.
  • platform/chromium-win-vista/platform: Removed.
  • platform/chromium-win-vista/platform/chromium: Removed.
  • platform/chromium-win-vista/platform/chromium/compositing: Removed.
  • platform/chromium-win-vista/platform/chromium/fast: Removed.
  • platform/chromium-win-vista/platform/chromium/fast/text: Removed.
  • platform/chromium-win-vista/platform/chromium/virtual: Removed.
  • platform/chromium-win-vista/platform/chromium/virtual/gpu: Removed.
  • platform/chromium-win-vista/platform/chromium/virtual/gpu/fast: Removed.
  • platform/chromium-win-vista/platform/chromium/virtual/gpu/fast/canvas: Removed.
  • platform/chromium-win-vista/svg: Removed.
  • platform/chromium-win-vista/svg/W3C-I18N: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1-SE: Removed.
  • platform/chromium-win-vista/svg/as-image: Removed.
  • platform/chromium-win-vista/svg/as-object: Removed.
  • platform/chromium-win-vista/svg/batik: Removed.
  • platform/chromium-win-vista/svg/batik/paints: Removed.
  • platform/chromium-win-vista/svg/batik/text: Removed.
  • platform/chromium-win-vista/svg/carto.net: Removed.
  • platform/chromium-win-vista/svg/css: Removed.
  • platform/chromium-win-vista/svg/custom: Removed.
  • platform/chromium-win-vista/svg/dynamic-updates: Removed.
  • platform/chromium-win-vista/svg/filters: Removed.
  • platform/chromium-win-vista/svg/hixie: Removed.
  • platform/chromium-win-vista/svg/hixie/intrinsic: Removed.
  • platform/chromium-win-vista/svg/in-html: Removed.
  • platform/chromium-win-vista/svg/stroke: Removed.
  • platform/chromium-win-vista/svg/text: Removed.
  • platform/chromium-win-vista/svg/zoom: Removed.
  • platform/chromium-win-vista/svg/zoom/page: Removed.
  • platform/chromium-win-vista/tables: Removed.
  • platform/chromium-win-vista/tables/mozilla: Removed.
  • platform/chromium-win-vista/tables/mozilla/bugs: Removed.
  • platform/chromium-win-vista/tables/mozilla/marvin: Removed.
  • platform/chromium-win-vista/tables/mozilla_expected_failures: Removed.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/bugs: Removed.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/core: Removed.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/marvin: Removed.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/other: Removed.
  • platform/chromium-win-vista/transforms: Removed.
  • platform/chromium-win-vista/transforms/2d: Removed.
9:37 AM Changeset in webkit [122470] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Remove resources panel edited resources search support.
https://bugs.webkit.org/show_bug.cgi?id=91101

Reviewed by Pavel Feldman.

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.performSearch.callback):
(WebInspector.ResourcesPanel.prototype.performSearch):

9:35 AM Changeset in webkit [122469] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] WebPage::touchEvent() should use Platform::TouchEvent's toString() for debugging.
https://bugs.webkit.org/show_bug.cgi?id=91002

Patch by Pawel Chomicki <pchomicki@rim.com> on 2012-07-12
Reviewed by Antonio Gomes.
Reviewed internally by Genevieve Mak.

Updated DEBUG_TOUCH_EVENTS section of touchEvent method to utilize
Platform::TouchEvent's toString method.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::touchEvent):

9:17 AM Changeset in webkit [122468] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed r122460 inspector closure compilation fix follow up.

  • inspector/front-end/RevisionHistoryView.js:

(WebInspector.RevisionHistoryView):

9:01 AM Changeset in webkit [122467] by commit-queue@webkit.org
  • 5 edits in trunk

[GTK] Implement disableImageLoading in DRT
https://bugs.webkit.org/show_bug.cgi?id=87973

Patch by Arnaud Renevier <arno@renevier.net> on 2012-07-12
Reviewed by Martin Robinson.

Tools:

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::disableImageLoading):

LayoutTests:

Add TEXT expectation to favicon-loads-with-icon-loading-override.html
which was only working by accident.

  • platform/gtk/TestExpectations:
8:59 AM Changeset in webkit [122466] by loislo@chromium.org
  • 9 edits in trunk/Source/WebCore

Web Inspector: fix native memory instrumentation code for the bindings instrumentation.
https://bugs.webkit.org/show_bug.cgi?id=91096

The instrumented class has to have instrumentation method which reports class size and type and
the member objects and pointers.

Sample:
void Node::reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const
{

memoryObjectInfo->reportObjectInfo(this, MemoryInstrumentation::DOM); report object size and type.
TreeShared<Node, ContainerNode>::reportMemoryUsage(memoryObjectInfo);
call base class instrumentation.
ScriptWrappable::reportMemoryUsage(memoryObjectInfo); call base class instrumentation.
memoryObjectInfo->reportPointer(m_document, MemoryInstrumentation::DOM);
report uninstrumented pointer.
memoryObjectInfo->reportInstrumentedPointer(m_next); report instrumented pointer.
memoryObjectInfo->reportInstrumentedObject(m_anObject);
report instrumented object.

}

Reviewed by Pavel Feldman.

Existing tests for native memory instrumentation.

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::reportMemoryUsage):

  • bindings/v8/DOMDataStore.h:

(WebCore):
(DOMDataStore):

  • bindings/v8/IntrusiveDOMWrapperMap.h:

(WebCore::ChunkedTable::reportMemoryUsage):

  • bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::collectBindingMemoryInfo):

  • bindings/v8/V8Binding.cpp:

(WebCore::V8BindingPerIsolateData::reportMemoryUsage):
(WebCore::StringCache::reportMemoryUsage):

  • bindings/v8/V8Binding.h:

(WebCore):
(StringCache):
(V8BindingPerIsolateData):

  • bindings/v8/V8DOMMap.h:

(WebCore):
(AbstractWeakReferenceMap):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore):

8:54 AM Changeset in webkit [122465] by pfeldman@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: beautify find bar looks, simplify search update routines.
https://bugs.webkit.org/show_bug.cgi?id=91087

Reviewed by Vsevolod Vlasov.

This change updates the looks to the one on the screenshots and simplifies match count update routines.

  • inspector/front-end/SearchController.js:

(WebInspector.SearchController.onMatchesMouseDown):
(WebInspector.SearchController):
(WebInspector.SearchController.prototype.activePanelChanged.performPanelSearch):
(WebInspector.SearchController.prototype.activePanelChanged):
(WebInspector.SearchController.prototype._updateSearchNavigationButtonState):
(WebInspector.SearchController.prototype._updateSearchMatchesCountAndCurrentMatchIndex):
(WebInspector.SearchController.prototype._onKeyDown):
(WebInspector.SearchController.prototype._onInput):
(WebInspector.SearchController.prototype._onNextButtonSearch):
(WebInspector.SearchController.prototype._onPrevButtonSearch):
(WebInspector.SearchController.prototype._performSearch):

  • inspector/front-end/inspector.css:

(#search):
(#search:focus):
(.toolbar-search-navigation-controls):
(.toolbar-search-navigation):
(.toolbar-search-navigation.enabled:hover):
(.toolbar-search-navigation.enabled, .toolbar-search-navigation.enabled:active):
(.toolbar-search):
(.toolbar-search-control):
(.search-results-matches):
(.inspector-footer):

8:52 AM Changeset in webkit [122464] by abarth@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

Parse the viewport meta tag like iOS
https://bugs.webkit.org/show_bug.cgi?id=72722

Reviewed by Alexey Proskuryakov.

Our parsing appears to match iOS already. This patch simply adds tests
that show that we agree on these cases.

  • fast/viewport/viewport-133-expected.txt: Added.
  • fast/viewport/viewport-133.html: Added.
  • fast/viewport/viewport-134-expected.txt: Added.
  • fast/viewport/viewport-134.html: Added.
8:38 AM Changeset in webkit [122463] by jsbell@chromium.org
  • 15 edits
    3 adds in trunk

IndexedDB: ASSERT hit calling open from callback in Worker
https://bugs.webkit.org/show_bug.cgi?id=90832

Reviewed by Kentaro Hara.

Source/WebCore:

GroupSettings are used to provide the backing store path in some
ports. Accessing those settings from a Worker was added, but the
access referenced thread startup data that is cleared before the
run loop, so an IDBFactory.open() call executed asynchronously
would dereference a null pointer. Plumb the settings startup
data into the context itself, like all of the other properties.

Test: storage/indexeddb/open-twice-workers.html

  • Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::open):

  • workers/DedicatedWorkerContext.cpp:

(WebCore::DedicatedWorkerContext::DedicatedWorkerContext):

  • workers/DedicatedWorkerContext.h:

(WebCore::DedicatedWorkerContext::create):
(DedicatedWorkerContext):

  • workers/DedicatedWorkerThread.cpp:

(WebCore::DedicatedWorkerThread::createWorkerContext):

  • workers/DedicatedWorkerThread.h:

(DedicatedWorkerThread):

  • workers/SharedWorkerContext.cpp:

(WebCore::SharedWorkerContext::SharedWorkerContext):

  • workers/SharedWorkerContext.h:

(WebCore::SharedWorkerContext::create):
(SharedWorkerContext):

  • workers/SharedWorkerThread.cpp:

(WebCore::SharedWorkerThread::createWorkerContext):

  • workers/SharedWorkerThread.h:

(SharedWorkerThread):

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::WorkerContext):

  • workers/WorkerContext.h:

(WebCore::WorkerContext::groupSettings):
(WorkerContext):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::workerThread):

  • workers/WorkerThread.h:

(WorkerThread):

LayoutTests:

Call IDBFactory.open() twice from a worker - once from the initial worker
script evaluation, and once in a callback after the worker thread data
has been purged.

  • storage/indexeddb/open-twice-workers-expected.txt: Added.
  • storage/indexeddb/open-twice-workers.html: Added.
  • storage/indexeddb/resources/open-twice.js: Added.

(test):
(openAnother):

8:34 AM Changeset in webkit [122462] by allan.jensen@nokia.com
  • 6 edits
    1 add in trunk/Source

[Qt] Implement MemoryUsageSupport
https://bugs.webkit.org/show_bug.cgi?id=91094

Reviewed by Adam Barth.

Source/JavaScriptCore:

Compile in MemoryStatistics so we can make use of the interface.

  • Target.pri:

Source/WebCore:

Implements Qt versions of the memory-usage functions using the information we have available
from the various memory systems used in WebKit.

Also gets rid of a redundant indirection in V8GCController.

  • Target.pri:
  • bindings/v8/V8GCController.cpp:

(WebCore::V8GCController::gcEpilogue):
(WebCore::V8GCController::checkMemoryUsage):

  • platform/qt/MemoryUsageSupportQt.cpp: Added.

(WebCore::mallocMemoryUsage):
(WebCore::memoryUsageKB):
(WebCore::actualMemoryUsageKB):
(WebCore::MemoryUsageSupport::memoryUsageMB):
(WebCore::MemoryUsageSupport::actualMemoryUsageMB):
(WebCore::MemoryUsageSupport::lowMemoryUsageMB):
(WebCore::MemoryUsageSupport::highMemoryUsageMB):
(WebCore::MemoryUsageSupport::highUsageDeltaMB):
(WebCore::MemoryUsageSupport::processMemorySizesInBytes):

  • platform/qt/PlatformSupport.h:

(PlatformSupport):

8:30 AM Changeset in webkit [122461] by leandrogracia@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Remove unrequired API in WebSurroundingText.
https://bugs.webkit.org/show_bug.cgi?id=91067

Reviewed by Adam Barth.

Remove the unused first initialize method from WebSurroundingText.
Now both Chromium and LayoutTestController use the second method.

  • public/WebSurroundingText.h:

(WebSurroundingText):

  • src/WebSurroundingText.cpp:
8:22 AM Changeset in webkit [122460] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Revision history view should be updated when uiSourceCodes are removed or replaced.
https://bugs.webkit.org/show_bug.cgi?id=91095

Reviewed by Pavel Feldman.

RevisionHistoryView is now reset in WorkspaceReset event handler.
UISourceCodes are now removed from RevisionHistoryView when uiSourceCode is removed or replace.

  • inspector/front-end/RevisionHistoryView.js:

(WebInspector.RevisionHistoryView):
(WebInspector.RevisionHistoryView.prototype._clearHistory):
(WebInspector.RevisionHistoryView.prototype._uiSourceCodeRemoved):
(WebInspector.RevisionHistoryView.prototype._uiSourceCodeReplaced):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._reset):

8:01 AM Changeset in webkit [122459] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

InspectorFileSystemAgent.cpp have to include File.h explicitly
https://bugs.webkit.org/show_bug.cgi?id=91078

Patch by Dongwoo Im <dw.im@samsung.com> on 2012-07-12
Reviewed by Vsevolod Vlasov.

Make sure the InspectorFileSystemAgent.cpp include the File.h by including explicitly.

No new tests. Covered by existing tests.

  • inspector/InspectorFileSystemAgent.cpp: Include File.h
8:00 AM Changeset in webkit [122458] by Csaba Osztrogonác
  • 1566 edits in trunk/LayoutTests

[Qt] platform/qt/css3 tests needs update after rebaseline
https://bugs.webkit.org/show_bug.cgi?id=91086

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2012-07-12
Reviewed by Csaba Osztrogonác.

  • platform/qt-5.0/Skipped:
  • platform/qt/css3/css3-modsel-33-expected.png:
  • platform/qt/css3/css3-modsel-33-expected.txt:
  • platform/qt/css3/css3-modsel-35-expected.png:
  • platform/qt/css3/css3-modsel-35-expected.txt:
  • platform/qt/css3/css3-modsel-36-expected.png:
  • platform/qt/css3/css3-modsel-36-expected.txt:
  • platform/qt/css3/css3-modsel-37-expected.png:
  • platform/qt/css3/css3-modsel-37-expected.txt:
  • platform/qt/css3/filters/effect-brightness-expected.png:
  • platform/qt/css3/filters/effect-brightness-expected.txt:
  • platform/qt/css3/filters/effect-combined-expected.png:
  • platform/qt/css3/filters/effect-combined-expected.txt:
  • platform/qt/css3/filters/effect-combined-hw-expected.png:
  • platform/qt/css3/filters/effect-combined-hw-expected.txt:
  • platform/qt/css3/filters/effect-contrast-expected.png:
  • platform/qt/css3/filters/effect-contrast-expected.txt:
  • platform/qt/css3/filters/effect-drop-shadow-expected.png:
  • platform/qt/css3/filters/effect-drop-shadow-expected.txt:
  • platform/qt/css3/filters/effect-drop-shadow-hw-expected.png:
  • platform/qt/css3/filters/effect-drop-shadow-hw-expected.txt:
  • platform/qt/css3/filters/effect-grayscale-expected.png:
  • platform/qt/css3/filters/effect-grayscale-expected.txt:
  • platform/qt/css3/filters/effect-grayscale-hw-expected.png:
  • platform/qt/css3/filters/effect-grayscale-hw-expected.txt:
  • platform/qt/css3/filters/effect-hue-rotate-expected.png:
  • platform/qt/css3/filters/effect-hue-rotate-expected.txt:
  • platform/qt/css3/filters/effect-hue-rotate-hw-expected.png:
  • platform/qt/css3/filters/effect-hue-rotate-hw-expected.txt:
  • platform/qt/css3/filters/effect-invert-expected.png:
  • platform/qt/css3/filters/effect-invert-expected.txt:
  • platform/qt/css3/filters/effect-invert-hw-expected.png:
  • platform/qt/css3/filters/effect-invert-hw-expected.txt:
  • platform/qt/css3/filters/effect-opacity-expected.png:
  • platform/qt/css3/filters/effect-opacity-expected.txt:
  • platform/qt/css3/filters/effect-opacity-hw-expected.png:
  • platform/qt/css3/filters/effect-opacity-hw-expected.txt:
  • platform/qt/css3/filters/effect-saturate-expected.png:
  • platform/qt/css3/filters/effect-saturate-expected.txt:
  • platform/qt/css3/filters/effect-saturate-hw-expected.png:
  • platform/qt/css3/filters/effect-saturate-hw-expected.txt:
  • platform/qt/css3/filters/effect-sepia-expected.png:
  • platform/qt/css3/filters/effect-sepia-expected.txt:
  • platform/qt/css3/filters/effect-sepia-hw-expected.png:
  • platform/qt/css3/filters/effect-sepia-hw-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-1-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-1-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-10-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-10-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-11-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-11-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-13-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-13-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-14-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-14-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-144-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-144-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-148-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-148-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-149-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-149-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-149b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-149b-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-14b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-14b-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-14c-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-14c-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-14d-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-14d-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-14e-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-14e-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-15-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-15-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-150-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-150-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-151-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-151-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-152-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-152-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-154-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-154-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-155-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-155-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-155a-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-155a-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-155b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-155b-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-155c-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-155c-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-155d-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-155d-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-156-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-156-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-156b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-156b-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-156c-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-156c-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-157-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-157-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-158-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-158-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-159-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-159-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-15b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-15b-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-16-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-16-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-160-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-160-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-161-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-161-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-166-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-166-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-166a-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-166a-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-167-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-167-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-167a-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-167a-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-168-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-168-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-168a-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-168a-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-169-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-169-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-169a-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-169a-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-17-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-17-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-170-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-170-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-170a-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-170a-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-170b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-170b-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-170c-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-170c-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-170d-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-170d-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-175a-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-175a-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-175b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-175b-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-175c-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-175c-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-176-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-176-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-177a-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-177a-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-177b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-177b-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-178-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-178-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-179-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-179-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-179a-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-179a-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-18-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-18-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-180a-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-180a-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-181-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-181-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-183-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-183-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-184a-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-184a-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-184b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-184b-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-184c-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-184c-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-184d-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-184d-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-184e-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-184e-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-184f-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-184f-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-18a-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-18a-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-18b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-18b-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-18c-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-18c-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-19-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-19-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-19b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-19b-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-2-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-2-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-20-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-20-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-21-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-21-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-21b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-21b-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-22-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-22-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-23-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-23-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-24-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-24-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-25-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-25-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-27-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-27-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-27a-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-27a-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-27b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-27b-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-28-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-28-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-28b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-28b-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-29-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-29-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-29b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-29b-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-30-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-30-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-31-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-31-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-32-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-32-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-33-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-33-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-34-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-34-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-35-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-35-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-36-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-36-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-37-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-37-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-38-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-38-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-39-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-39-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-39a-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-39a-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-39b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-39b-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-39c-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-39c-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-3a-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-3a-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-4-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-4-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-41-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-41-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-41a-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-41a-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-42-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-42-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-42a-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-42a-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-43-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-43-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-43b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-43b-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-44-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-44-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-44b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-44b-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-44c-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-44c-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-44d-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-44d-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-45-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-45-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-45b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-45b-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-45c-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-45c-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-46-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-46-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-46b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-46b-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-5-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-5-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-54-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-54-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-55-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-55-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-56-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-56-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-59-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-59-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-6-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-6-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-60-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-60-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-61-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-61-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-62-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-62-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-63-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-63-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-64-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-64-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-65-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-65-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-66-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-66-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-66b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-66b-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-67-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-67-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-68-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-68-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-69-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-69-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-7-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-7-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-70-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-70-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-72-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-72-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-72b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-72b-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-73-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-73-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-73b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-73b-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-74-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-74-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-74b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-74b-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-75-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-75-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-75b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-75b-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-76-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-76-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-76b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-76b-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-77-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-77-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-77b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-77b-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-78-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-78-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-78b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-78b-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-79-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-79-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-7b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-7b-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-8-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-8-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-80-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-80-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-81-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-81-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-81b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-81b-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-82-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-82-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-82b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-82b-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-83-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-83-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-86-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-86-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-87-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-87-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-87b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-87b-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-88-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-88-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-88b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-88b-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-89-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-89-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-9-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-9-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-90-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-90-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-90b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-90b-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-d1-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-d1-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-d1b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-d1b-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-d2-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-d2-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-d4-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-d4-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-1-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-1-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-10-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-10-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-100-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-100-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-100b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-100b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-101-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-101-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-101b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-101b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-102-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-102-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-102b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-102b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-103-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-103-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-103b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-103b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-104-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-104-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-104b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-104b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-105-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-105-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-105b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-105b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-106-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-106-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-106b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-106b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-107-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-107-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-107b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-107b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-108-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-108-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-108b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-108b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-109-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-109-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-109b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-109b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-11-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-11-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-110-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-110-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-110b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-110b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-111-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-111-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-111b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-111b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-112-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-112-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-112b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-112b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-113-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-113-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-113b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-113b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-114-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-114-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-114b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-114b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-115-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-115-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-115b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-115b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-116-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-116-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-116b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-116b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-117-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-117-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-117b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-117b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-118-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-118-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-119-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-119-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-120-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-120-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-121-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-121-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-122-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-122-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-123-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-123-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-123b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-123b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-124-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-124-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-124b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-124b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-125-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-125-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-125b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-125b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-126-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-126-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-126b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-126b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-127-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-127-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-127b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-127b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-128-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-128-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-128b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-128b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-129-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-129-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-129b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-129b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-13-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-13-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-130-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-130-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-130b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-130b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-131-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-131-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-131b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-131b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-132-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-132-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-132b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-132b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-133-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-133-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-133b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-133b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-134-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-134-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-134b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-134b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-135-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-135-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-135b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-135b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-136-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-136-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-136b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-136b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-137-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-137-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-137b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-137b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-138-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-138-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-138b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-138b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-139-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-139-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-139b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-139b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-14-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-14-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-140-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-140-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-140b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-140b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-141-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-141-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-141b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-141b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-142-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-142-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-142b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-142b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-143-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-143-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-143b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-143b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-144-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-144-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-145a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-145a-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-145b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-145b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-146a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-146a-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-146b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-146b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-147a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-147a-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-147b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-147b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-148-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-148-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-149-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-149-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-149b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-149b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-14b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-14b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-14c-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-14c-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-14d-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-14d-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-14e-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-14e-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-15-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-15-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-150-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-150-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-151-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-151-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-152-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-152-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-153-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-153-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-154-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-154-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-155-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-155-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-155a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-155a-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-155b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-155b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-155c-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-155c-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-155d-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-155d-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-156-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-156-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-156b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-156b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-156c-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-156c-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-157-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-157-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-158-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-158-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-159-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-159-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-15b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-15b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-15c-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-15c-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-16-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-16-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-160-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-160-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-161-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-161-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-166-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-166-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-166a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-166a-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-167-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-167-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-167a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-167a-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-168-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-168-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-168a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-168a-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-169-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-169-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-169a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-169a-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-17-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-17-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-170-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-170-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-170a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-170a-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-170b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-170b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-170c-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-170c-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-170d-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-170d-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-171-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-171-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-172a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-172a-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-172b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-172b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-173a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-173a-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-173b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-173b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-174a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-174a-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-174b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-174b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-175a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-175a-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-175b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-175b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-175c-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-175c-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-176-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-176-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-177a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-177a-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-177b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-177b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-178-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-178-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-179-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-179-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-179a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-179a-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-18-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-18-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-180a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-180a-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-181-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-181-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-182-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-182-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-183-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-183-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-184a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-184a-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-184b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-184b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-184c-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-184c-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-184d-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-184d-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-184e-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-184e-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-184f-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-184f-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-18a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-18a-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-18b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-18b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-18c-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-18c-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-19-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-19-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-19b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-19b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-2-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-2-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-20-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-20-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-21-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-21-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-21b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-21b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-22-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-22-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-23-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-23-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-24-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-25-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-25-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-27-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-27-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-27a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-27a-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-27b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-27b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-28-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-28-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-28b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-28b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-29-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-29-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-29b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-29b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-3-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-3-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-30-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-30-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-31-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-31-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-32-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-32-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-33-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-33-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-34-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-34-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-35-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-35-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-36-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-36-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-37-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-37-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-38-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-38-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-39-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-39-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-39a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-39a-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-39b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-39b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-39c-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-39c-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-3a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-3a-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-4-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-4-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-41-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-41-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-41a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-41a-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-42-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-42-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-42a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-42a-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-43-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-43-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-43b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-43b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-44-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-44-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-44b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-44b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-44c-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-44c-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-44d-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-44d-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-45-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-45-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-45b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-45b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-45c-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-45c-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-46-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-46-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-46b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-46b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-47-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-47-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-48-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-48-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-49-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-49-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-5-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-5-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-50-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-50-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-51-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-51-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-52-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-52-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-53-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-53-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-54-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-54-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-55-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-55-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-56-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-56-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-57-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-57-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-57b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-57b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-59-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-59-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-6-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-6-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-60-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-60-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-61-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-61-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-62-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-62-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-63-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-63-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-64-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-64-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-65-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-65-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-66-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-66-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-66b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-66b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-67-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-67-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-68-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-69-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-69-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-7-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-7-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-70-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-70-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-72-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-72-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-72b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-72b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-73-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-73-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-73b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-73b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-74-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-74-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-74b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-74b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-75-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-75-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-75b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-75b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-76-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-76-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-76b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-76b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-77-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-77-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-77b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-77b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-78-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-78-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-78b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-78b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-79-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-79-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-7b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-7b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-8-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-8-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-80-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-80-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-81-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-81-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-81b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-81b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-82-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-82-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-82b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-82b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-83-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-83-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-86-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-86-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-87-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-87-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-87b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-87b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-88-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-88-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-88b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-88b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-89-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-89-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-9-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-9-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-90-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-90-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-90b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-90b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-91-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-91-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-92-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-92-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-93-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-93-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-94-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-94-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-94b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-94b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-95-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-95-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-96-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-96-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-96b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-96b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-97-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-97-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-97b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-97b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-98-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-98-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-98b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-98b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-99-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-99-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-99b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-99b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-d1-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-d1-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-d1b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-d1b-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-d2-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-d2-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-d3-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-d3-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-d4-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-d4-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-1-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-1-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-10-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-10-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-100-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-100-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-100b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-100b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-101-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-101-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-101b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-101b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-102-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-102-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-102b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-102b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-103-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-103-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-103b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-103b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-104-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-104-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-104b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-104b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-105-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-105-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-105b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-105b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-106-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-106-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-106b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-106b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-107-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-107-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-107b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-107b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-108-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-108-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-108b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-108b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-109-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-109-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-109b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-109b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-11-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-11-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-110-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-110-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-110b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-110b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-111-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-111-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-111b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-111b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-112-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-112-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-112b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-112b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-113-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-113-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-113b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-113b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-114-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-114-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-114b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-114b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-115-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-115-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-115b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-115b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-116-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-116-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-116b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-116b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-117-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-117-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-117b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-117b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-118-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-118-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-119-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-119-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-120-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-120-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-121-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-121-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-122-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-122-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-123-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-123-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-123b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-123b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-124-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-124-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-124b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-124b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-125-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-125-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-125b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-125b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-126-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-126-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-126b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-126b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-127-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-127-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-127b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-127b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-128-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-128-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-128b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-128b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-129-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-129-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-129b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-129b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-13-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-13-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-130-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-130-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-130b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-130b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-131-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-131-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-131b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-131b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-132-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-132-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-132b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-132b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-133-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-133-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-133b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-133b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-134-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-134-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-134b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-134b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-135-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-135-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-135b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-135b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-136-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-136-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-136b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-136b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-137-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-137-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-137b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-137b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-138-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-138-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-138b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-138b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-139-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-139-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-139b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-139b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-14-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-14-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-140-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-140-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-140b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-140b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-141-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-141-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-141b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-141b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-142-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-142-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-142b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-142b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-143-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-143-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-143b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-143b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-144-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-144-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-145a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-145a-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-145b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-145b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-146a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-146a-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-146b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-146b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-147a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-147a-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-147b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-147b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-149-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-149-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-149b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-149b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-14b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-14b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-14c-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-14c-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-14d-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-14d-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-14e-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-14e-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-15-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-15-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-150-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-150-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-151-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-151-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-152-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-152-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-153-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-153-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-154-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-154-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-155-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-155-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-155a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-155a-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-155b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-155b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-155c-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-155c-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-155d-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-155d-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-156-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-156-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-156b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-156b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-156c-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-156c-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-157-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-157-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-158-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-158-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-159-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-159-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-15b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-15b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-15c-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-15c-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-16-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-16-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-160-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-160-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-161-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-161-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-166-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-166-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-166a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-166a-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-167-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-167-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-167a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-167a-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-168-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-168-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-168a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-168a-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-169-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-169-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-169a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-169a-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-17-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-17-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-170-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-170-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-170a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-170a-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-170b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-170b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-170c-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-170c-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-170d-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-170d-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-171-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-171-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-172a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-172a-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-172b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-172b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-173a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-173a-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-173b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-173b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-174a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-174a-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-174b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-174b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-175a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-175a-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-175b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-175b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-175c-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-175c-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-176-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-176-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-177a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-177a-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-177b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-177b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-178-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-178-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-179-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-179-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-179a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-179a-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-18-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-18-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-180a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-180a-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-181-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-181-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-182-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-182-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-183-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-183-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-184a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-184a-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-184b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-184b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-184c-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-184c-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-184d-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-184d-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-184e-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-184e-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-184f-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-184f-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-18a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-18a-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-18b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-18b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-18c-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-18c-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-19-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-19-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-19b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-19b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-2-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-2-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-20-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-20-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-21-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-21-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-21b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-21b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-22-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-22-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-23-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-23-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-24-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-24-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-25-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-25-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-27-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-27-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-27a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-27a-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-27b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-27b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-28-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-28-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-28b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-28b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-29-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-29-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-29b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-29b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-3-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-3-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-30-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-30-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-31-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-31-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-32-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-32-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-33-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-33-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-34-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-34-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-35-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-35-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-36-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-36-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-37-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-37-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-38-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-38-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-39-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-39-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-39a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-39a-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-39b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-39b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-39c-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-39c-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-3a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-3a-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-4-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-4-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-41-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-41-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-41a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-41a-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-42-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-42-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-42a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-42a-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-43-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-43-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-43b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-43b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-44-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-44-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-44b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-44b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-44c-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-44c-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-44d-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-44d-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-45-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-45-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-45b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-45b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-45c-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-45c-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-46-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-46-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-46b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-46b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-47-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-47-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-48-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-48-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-49-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-49-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-5-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-5-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-50-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-50-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-51-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-51-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-52-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-52-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-53-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-53-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-54-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-54-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-55-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-55-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-56-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-56-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-57-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-57-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-57b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-57b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-59-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-59-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-6-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-6-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-60-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-60-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-61-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-61-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-62-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-62-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-63-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-63-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-64-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-64-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-65-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-65-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-66-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-66-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-66b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-66b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-67-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-67-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-68-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-68-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-69-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-69-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-7-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-7-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-70-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-70-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-72-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-72-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-72b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-72b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-73-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-73-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-73b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-73b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-74-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-74-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-74b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-74b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-75-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-75-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-75b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-75b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-76-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-76-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-76b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-76b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-77-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-77-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-77b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-77b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-78-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-78-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-78b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-78b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-79-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-79-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-7b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-7b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-8-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-8-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-80-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-80-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-81-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-81-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-81b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-81b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-82-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-82-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-82b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-82b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-83-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-83-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-86-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-86-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-87-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-87-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-87b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-87b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-88-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-88-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-88b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-88b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-89-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-89-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-9-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-9-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-90-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-90-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-90b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-90b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-91-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-91-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-92-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-92-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-93-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-93-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-94-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-94-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-94b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-94b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-95-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-95-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-96-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-96-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-96b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-96b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-97-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-97-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-97b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-97b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-98-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-98-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-98b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-98b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-99-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-99-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-99b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-99b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-d1-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-d1-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-d1b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-d1b-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-d2-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-d2-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-d3-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-d3-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-d4-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-d4-expected.txt:
7:24 AM Changeset in webkit [122457] by Csaba Osztrogonác
  • 457 edits
    1 copy
    32 adds in trunk/LayoutTests

[Qt] platform/qt/css2.1/20110323 tests needs update after rebaseline
https://bugs.webkit.org/show_bug.cgi?id=91084

Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-07-12
Reviewed by Csaba Osztrogonác.

  • platform/qt-5.0/Skipped:
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-001-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-001-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-002-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-002-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-003-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-003-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-004-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-004-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-005-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-005-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-006-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-006-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-007-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-007-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-008-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-008-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-009-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-009-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-010-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-010-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-011-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-011-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-012-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-012-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-001-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-001-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-002-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-002-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-003-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-003-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-004-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-004-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-005-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-005-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-006-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-006-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-007-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-007-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-008-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-008-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-009-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-009-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-010-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-010-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-011-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-011-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-012-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-012-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-001-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-001-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-002-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-002-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-003-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-003-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-004-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-004-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-005-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-005-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-006-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-006-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-007-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-007-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-008-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-008-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-009-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-009-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-010-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-010-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-011-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-011-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-012-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-012-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-013-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-013-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-014-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-014-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-015-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-015-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-016-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-016-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-017-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-017-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-018-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-018-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-019-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-019-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-020-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-020-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-021-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-021-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-022-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-022-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-023-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-023-expected.txt:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-024-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-024-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-height-001-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-001-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-height-002-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-002-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-height-003-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-003-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-height-004-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-004-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-height-005-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-005-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-height-007-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-007-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-height-008-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-008-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-height-009-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-009-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-height-010-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-010-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-height-011-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-011-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-height-012-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-012-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-height-014-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-014-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-height-016-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-016-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-height-017-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-017-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-height-018-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-018-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-height-019-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-019-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-height-021-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-021-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-height-022-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-022-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-height-023-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-023-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-height-024-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-024-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-height-025-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-025-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-height-026-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-026-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-height-028-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-028-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-height-029-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-029-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-height-030-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-030-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-height-031-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-031-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-height-032-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-032-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-height-033-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-033-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-height-035-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-035-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-height-036-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-036-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-width-001-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-001-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-width-006-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-006-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-width-008-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-008-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-width-013-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-013-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-width-015-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-015-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-width-020-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-020-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-width-022-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-022-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-width-027-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-027-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-width-029-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-029-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-width-034-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-034-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-width-036-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-036-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-width-041-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-041-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-width-043-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-043-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-width-048-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-048-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-width-050-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-050-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-width-055-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-055-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-width-057-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-057-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-width-062-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-062-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-width-064-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-064-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-width-069-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-069-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-width-071-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-071-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-width-076-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-076-expected.txt:
  • platform/qt/css2.1/20110323/background-intrinsic-001-expected.png:
  • platform/qt/css2.1/20110323/background-intrinsic-001-expected.txt:
  • platform/qt/css2.1/20110323/background-intrinsic-002-expected.png:
  • platform/qt/css2.1/20110323/background-intrinsic-002-expected.txt:
  • platform/qt/css2.1/20110323/background-intrinsic-003-expected.png:
  • platform/qt/css2.1/20110323/background-intrinsic-003-expected.txt:
  • platform/qt/css2.1/20110323/background-intrinsic-004-expected.png:
  • platform/qt/css2.1/20110323/background-intrinsic-004-expected.txt:
  • platform/qt/css2.1/20110323/background-intrinsic-005-expected.png:
  • platform/qt/css2.1/20110323/background-intrinsic-005-expected.txt:
  • platform/qt/css2.1/20110323/background-intrinsic-006-expected.png:
  • platform/qt/css2.1/20110323/background-intrinsic-006-expected.txt:
  • platform/qt/css2.1/20110323/background-intrinsic-007-expected.png:
  • platform/qt/css2.1/20110323/background-intrinsic-007-expected.txt:
  • platform/qt/css2.1/20110323/background-intrinsic-008-expected.png:
  • platform/qt/css2.1/20110323/background-intrinsic-008-expected.txt:
  • platform/qt/css2.1/20110323/background-intrinsic-009-expected.png:
  • platform/qt/css2.1/20110323/background-intrinsic-009-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-height-001-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-height-001-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-height-002-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-height-002-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-height-003-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-height-003-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-height-004-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-height-004-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-height-005-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-height-005-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-height-006-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-height-006-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-height-007-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-height-007-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-height-008-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-height-008-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-height-009-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-height-009-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-height-010-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-height-010-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-height-011-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-height-011-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-height-012-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-height-012-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-height-013-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-height-013-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-height-014-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-height-014-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-height-015-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-height-015-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-height-016-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-height-016-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-width-001-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-width-001-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-width-002-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-width-002-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-width-003-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-width-003-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-width-004-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-width-004-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-width-005-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-width-005-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-width-006-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-width-006-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-width-007-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-width-007-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-width-008-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-width-008-expected.txt:
  • platform/qt/css2.1/20110323/block-replaced-height-001-expected.png:
  • platform/qt/css2.1/20110323/block-replaced-height-001-expected.txt:
  • platform/qt/css2.1/20110323/block-replaced-height-002-expected.png:
  • platform/qt/css2.1/20110323/block-replaced-height-002-expected.txt:
  • platform/qt/css2.1/20110323/block-replaced-height-003-expected.png:
  • platform/qt/css2.1/20110323/block-replaced-height-003-expected.txt:
  • platform/qt/css2.1/20110323/block-replaced-height-004-expected.png:
  • platform/qt/css2.1/20110323/block-replaced-height-004-expected.txt:
  • platform/qt/css2.1/20110323/block-replaced-height-005-expected.png:
  • platform/qt/css2.1/20110323/block-replaced-height-005-expected.txt:
  • platform/qt/css2.1/20110323/block-replaced-height-007-expected.png:
  • platform/qt/css2.1/20110323/block-replaced-height-007-expected.txt:
  • platform/qt/css2.1/20110323/block-replaced-width-001-expected.png:
  • platform/qt/css2.1/20110323/block-replaced-width-001-expected.txt:
  • platform/qt/css2.1/20110323/block-replaced-width-006-expected.png:
  • platform/qt/css2.1/20110323/block-replaced-width-006-expected.txt:
  • platform/qt/css2.1/20110323/border-collapse-offset-002-expected.png:
  • platform/qt/css2.1/20110323/border-collapse-offset-002-expected.txt:
  • platform/qt/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/qt/css2.1/20110323/border-conflict-style-079-expected.txt:
  • platform/qt/css2.1/20110323/border-conflict-style-088-expected.png: Added.
  • platform/qt/css2.1/20110323/border-conflict-style-088-expected.txt:
  • platform/qt/css2.1/20110323/border-spacing-applies-to-015-expected.png: Added.
  • platform/qt/css2.1/20110323/border-spacing-applies-to-015-expected.txt:
  • platform/qt/css2.1/20110323/c543-txt-decor-000-expected.png:
  • platform/qt/css2.1/20110323/c543-txt-decor-000-expected.txt:
  • platform/qt/css2.1/20110323/dynamic-top-change-001-expected.png: Added.
  • platform/qt/css2.1/20110323/dynamic-top-change-001-expected.txt:
  • platform/qt/css2.1/20110323/dynamic-top-change-002-expected.png: Added.
  • platform/qt/css2.1/20110323/dynamic-top-change-002-expected.txt:
  • platform/qt/css2.1/20110323/dynamic-top-change-003-expected.png: Added.
  • platform/qt/css2.1/20110323/dynamic-top-change-003-expected.txt:
  • platform/qt/css2.1/20110323/dynamic-top-change-004-expected.png: Added.
  • platform/qt/css2.1/20110323/dynamic-top-change-004-expected.txt:
  • platform/qt/css2.1/20110323/empty-inline-001-expected.png: Copied from LayoutTests/platform/qt/css2.1/20110323/absolute-replaced-height-036-expected.png.
  • platform/qt/css2.1/20110323/empty-inline-001-expected.txt:
  • platform/qt/css2.1/20110323/empty-inline-002-expected.png: Added.
  • platform/qt/css2.1/20110323/empty-inline-002-expected.txt:
  • platform/qt/css2.1/20110323/empty-inline-003-expected.png: Added.
  • platform/qt/css2.1/20110323/empty-inline-003-expected.txt:
  • platform/qt/css2.1/20110323/float-non-replaced-height-001-expected.png:
  • platform/qt/css2.1/20110323/float-non-replaced-height-001-expected.txt:
  • platform/qt/css2.1/20110323/float-non-replaced-width-001-expected.png:
  • platform/qt/css2.1/20110323/float-non-replaced-width-001-expected.txt:
  • platform/qt/css2.1/20110323/float-non-replaced-width-002-expected.png:
  • platform/qt/css2.1/20110323/float-non-replaced-width-002-expected.txt:
  • platform/qt/css2.1/20110323/float-non-replaced-width-003-expected.png:
  • platform/qt/css2.1/20110323/float-non-replaced-width-003-expected.txt:
  • platform/qt/css2.1/20110323/float-non-replaced-width-004-expected.png:
  • platform/qt/css2.1/20110323/float-non-replaced-width-004-expected.txt:
  • platform/qt/css2.1/20110323/float-non-replaced-width-005-expected.png:
  • platform/qt/css2.1/20110323/float-non-replaced-width-005-expected.txt:
  • platform/qt/css2.1/20110323/float-non-replaced-width-006-expected.png:
  • platform/qt/css2.1/20110323/float-non-replaced-width-006-expected.txt:
  • platform/qt/css2.1/20110323/float-non-replaced-width-007-expected.png:
  • platform/qt/css2.1/20110323/float-non-replaced-width-007-expected.txt:
  • platform/qt/css2.1/20110323/float-non-replaced-width-008-expected.png:
  • platform/qt/css2.1/20110323/float-non-replaced-width-008-expected.txt:
  • platform/qt/css2.1/20110323/float-non-replaced-width-009-expected.png:
  • platform/qt/css2.1/20110323/float-non-replaced-width-009-expected.txt:
  • platform/qt/css2.1/20110323/float-non-replaced-width-010-expected.png:
  • platform/qt/css2.1/20110323/float-non-replaced-width-010-expected.txt:
  • platform/qt/css2.1/20110323/float-non-replaced-width-011-expected.png:
  • platform/qt/css2.1/20110323/float-non-replaced-width-011-expected.txt:
  • platform/qt/css2.1/20110323/float-non-replaced-width-012-expected.png:
  • platform/qt/css2.1/20110323/float-non-replaced-width-012-expected.txt:
  • platform/qt/css2.1/20110323/float-replaced-height-001-expected.png:
  • platform/qt/css2.1/20110323/float-replaced-height-001-expected.txt:
  • platform/qt/css2.1/20110323/float-replaced-height-002-expected.png:
  • platform/qt/css2.1/20110323/float-replaced-height-002-expected.txt:
  • platform/qt/css2.1/20110323/float-replaced-height-003-expected.png:
  • platform/qt/css2.1/20110323/float-replaced-height-003-expected.txt:
  • platform/qt/css2.1/20110323/float-replaced-height-004-expected.png:
  • platform/qt/css2.1/20110323/float-replaced-height-004-expected.txt:
  • platform/qt/css2.1/20110323/float-replaced-height-005-expected.png:
  • platform/qt/css2.1/20110323/float-replaced-height-005-expected.txt:
  • platform/qt/css2.1/20110323/float-replaced-height-007-expected.png:
  • platform/qt/css2.1/20110323/float-replaced-height-007-expected.txt:
  • platform/qt/css2.1/20110323/float-replaced-width-001-expected.png:
  • platform/qt/css2.1/20110323/float-replaced-width-001-expected.txt:
  • platform/qt/css2.1/20110323/float-replaced-width-002-expected.png:
  • platform/qt/css2.1/20110323/float-replaced-width-002-expected.txt:
  • platform/qt/css2.1/20110323/float-replaced-width-003-expected.png:
  • platform/qt/css2.1/20110323/float-replaced-width-003-expected.txt:
  • platform/qt/css2.1/20110323/float-replaced-width-004-expected.png:
  • platform/qt/css2.1/20110323/float-replaced-width-004-expected.txt:
  • platform/qt/css2.1/20110323/float-replaced-width-005-expected.png:
  • platform/qt/css2.1/20110323/float-replaced-width-005-expected.txt:
  • platform/qt/css2.1/20110323/float-replaced-width-006-expected.png:
  • platform/qt/css2.1/20110323/float-replaced-width-006-expected.txt:
  • platform/qt/css2.1/20110323/float-replaced-width-011-expected.png:
  • platform/qt/css2.1/20110323/float-replaced-width-011-expected.txt:
  • platform/qt/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/qt/css2.1/20110323/floating-replaced-height-008-expected.txt:
  • platform/qt/css2.1/20110323/height-width-inline-table-001-expected.png: Added.
  • platform/qt/css2.1/20110323/height-width-inline-table-001-expected.txt:
  • platform/qt/css2.1/20110323/height-width-table-001-expected.png: Added.
  • platform/qt/css2.1/20110323/height-width-table-001-expected.txt:
  • platform/qt/css2.1/20110323/inline-block-non-replaced-height-001-expected.png:
  • platform/qt/css2.1/20110323/inline-block-non-replaced-height-001-expected.txt:
  • platform/qt/css2.1/20110323/inline-block-non-replaced-height-002-expected.png:
  • platform/qt/css2.1/20110323/inline-block-non-replaced-height-002-expected.txt:
  • platform/qt/css2.1/20110323/inline-block-non-replaced-width-001-expected.png:
  • platform/qt/css2.1/20110323/inline-block-non-replaced-width-001-expected.txt:
  • platform/qt/css2.1/20110323/inline-block-non-replaced-width-002-expected.png:
  • platform/qt/css2.1/20110323/inline-block-non-replaced-width-002-expected.txt:
  • platform/qt/css2.1/20110323/inline-block-non-replaced-width-003-expected.png:
  • platform/qt/css2.1/20110323/inline-block-non-replaced-width-003-expected.txt:
  • platform/qt/css2.1/20110323/inline-block-non-replaced-width-004-expected.png:
  • platform/qt/css2.1/20110323/inline-block-non-replaced-width-004-expected.txt:
  • platform/qt/css2.1/20110323/inline-block-replaced-height-001-expected.png:
  • platform/qt/css2.1/20110323/inline-block-replaced-height-001-expected.txt:
  • platform/qt/css2.1/20110323/inline-block-replaced-height-002-expected.png:
  • platform/qt/css2.1/20110323/inline-block-replaced-height-002-expected.txt:
  • platform/qt/css2.1/20110323/inline-block-replaced-height-003-expected.png:
  • platform/qt/css2.1/20110323/inline-block-replaced-height-003-expected.txt:
  • platform/qt/css2.1/20110323/inline-block-replaced-height-004-expected.png:
  • platform/qt/css2.1/20110323/inline-block-replaced-height-004-expected.txt:
  • platform/qt/css2.1/20110323/inline-block-replaced-height-005-expected.png:
  • platform/qt/css2.1/20110323/inline-block-replaced-height-005-expected.txt:
  • platform/qt/css2.1/20110323/inline-block-replaced-height-007-expected.png:
  • platform/qt/css2.1/20110323/inline-block-replaced-height-007-expected.txt:
  • platform/qt/css2.1/20110323/inline-block-replaced-height-008-expected.png: Added.
  • platform/qt/css2.1/20110323/inline-block-replaced-height-008-expected.txt:
  • platform/qt/css2.1/20110323/inline-block-replaced-width-001-expected.png:
  • platform/qt/css2.1/20110323/inline-block-replaced-width-001-expected.txt:
  • platform/qt/css2.1/20110323/inline-block-replaced-width-006-expected.png:
  • platform/qt/css2.1/20110323/inline-block-replaced-width-006-expected.txt:
  • platform/qt/css2.1/20110323/inline-non-replaced-width-001-expected.png:
  • platform/qt/css2.1/20110323/inline-non-replaced-width-001-expected.txt:
  • platform/qt/css2.1/20110323/inline-non-replaced-width-002-expected.png:
  • platform/qt/css2.1/20110323/inline-non-replaced-width-002-expected.txt:
  • platform/qt/css2.1/20110323/inline-replaced-height-001-expected.png:
  • platform/qt/css2.1/20110323/inline-replaced-height-001-expected.txt:
  • platform/qt/css2.1/20110323/inline-replaced-height-002-expected.png:
  • platform/qt/css2.1/20110323/inline-replaced-height-002-expected.txt:
  • platform/qt/css2.1/20110323/inline-replaced-height-003-expected.png:
  • platform/qt/css2.1/20110323/inline-replaced-height-003-expected.txt:
  • platform/qt/css2.1/20110323/inline-replaced-height-004-expected.png:
  • platform/qt/css2.1/20110323/inline-replaced-height-004-expected.txt:
  • platform/qt/css2.1/20110323/inline-replaced-height-005-expected.png:
  • platform/qt/css2.1/20110323/inline-replaced-height-005-expected.txt:
  • platform/qt/css2.1/20110323/inline-replaced-height-007-expected.png:
  • platform/qt/css2.1/20110323/inline-replaced-height-007-expected.txt:
  • platform/qt/css2.1/20110323/inline-replaced-height-008-expected.png: Added.
  • platform/qt/css2.1/20110323/inline-replaced-height-008-expected.txt:
  • platform/qt/css2.1/20110323/inline-replaced-width-001-expected.png:
  • platform/qt/css2.1/20110323/inline-replaced-width-001-expected.txt:
  • platform/qt/css2.1/20110323/inline-replaced-width-006-expected.png:
  • platform/qt/css2.1/20110323/inline-replaced-width-006-expected.txt:
  • platform/qt/css2.1/20110323/inline-replaced-width-011-expected.png:
  • platform/qt/css2.1/20110323/inline-replaced-width-011-expected.txt:
  • platform/qt/css2.1/20110323/inline-replaced-width-012-expected.png:
  • platform/qt/css2.1/20110323/inline-replaced-width-012-expected.txt:
  • platform/qt/css2.1/20110323/inline-replaced-width-013-expected.png:
  • platform/qt/css2.1/20110323/inline-replaced-width-013-expected.txt:
  • platform/qt/css2.1/20110323/inline-replaced-width-014-expected.png:
  • platform/qt/css2.1/20110323/inline-replaced-width-014-expected.txt:
  • platform/qt/css2.1/20110323/inline-replaced-width-015-expected.png:
  • platform/qt/css2.1/20110323/inline-replaced-width-015-expected.txt:
  • platform/qt/css2.1/20110323/margin-applies-to-001-expected.png: Added.
  • platform/qt/css2.1/20110323/margin-applies-to-001-expected.txt:
  • platform/qt/css2.1/20110323/margin-applies-to-002-expected.png: Added.
  • platform/qt/css2.1/20110323/margin-applies-to-002-expected.txt:
  • platform/qt/css2.1/20110323/margin-applies-to-003-expected.png: Added.
  • platform/qt/css2.1/20110323/margin-applies-to-003-expected.txt:
  • platform/qt/css2.1/20110323/margin-applies-to-004-expected.png: Added.
  • platform/qt/css2.1/20110323/margin-applies-to-004-expected.txt:
  • platform/qt/css2.1/20110323/margin-applies-to-005-expected.png: Added.
  • platform/qt/css2.1/20110323/margin-applies-to-005-expected.txt:
  • platform/qt/css2.1/20110323/margin-applies-to-006-expected.png: Added.
  • platform/qt/css2.1/20110323/margin-applies-to-006-expected.txt:
  • platform/qt/css2.1/20110323/margin-applies-to-007-expected.png: Added.
  • platform/qt/css2.1/20110323/margin-applies-to-007-expected.txt:
  • platform/qt/css2.1/20110323/margin-applies-to-008-expected.png: Added.
  • platform/qt/css2.1/20110323/margin-applies-to-008-expected.txt:
  • platform/qt/css2.1/20110323/margin-applies-to-009-expected.png: Added.
  • platform/qt/css2.1/20110323/margin-applies-to-009-expected.txt:
  • platform/qt/css2.1/20110323/margin-applies-to-010-expected.png: Added.
  • platform/qt/css2.1/20110323/margin-applies-to-010-expected.txt:
  • platform/qt/css2.1/20110323/margin-applies-to-012-expected.png: Added.
  • platform/qt/css2.1/20110323/margin-applies-to-012-expected.txt:
  • platform/qt/css2.1/20110323/margin-applies-to-013-expected.png: Added.
  • platform/qt/css2.1/20110323/margin-applies-to-013-expected.txt:
  • platform/qt/css2.1/20110323/margin-applies-to-014-expected.png: Added.
  • platform/qt/css2.1/20110323/margin-applies-to-014-expected.txt:
  • platform/qt/css2.1/20110323/margin-applies-to-015-expected.png: Added.
  • platform/qt/css2.1/20110323/margin-applies-to-015-expected.txt:
  • platform/qt/css2.1/20110323/outline-color-applies-to-008-expected.png:
  • platform/qt/css2.1/20110323/outline-color-applies-to-008-expected.txt:
  • platform/qt/css2.1/20110323/replaced-elements-001-expected.png:
  • platform/qt/css2.1/20110323/replaced-elements-001-expected.txt:
  • platform/qt/css2.1/20110323/replaced-intrinsic-001-expected.png:
  • platform/qt/css2.1/20110323/replaced-intrinsic-001-expected.txt:
  • platform/qt/css2.1/20110323/replaced-intrinsic-002-expected.png:
  • platform/qt/css2.1/20110323/replaced-intrinsic-002-expected.txt:
  • platform/qt/css2.1/20110323/replaced-intrinsic-003-expected.png:
  • platform/qt/css2.1/20110323/replaced-intrinsic-003-expected.txt:
  • platform/qt/css2.1/20110323/replaced-intrinsic-004-expected.png:
  • platform/qt/css2.1/20110323/replaced-intrinsic-004-expected.txt:
  • platform/qt/css2.1/20110323/replaced-intrinsic-005-expected.png:
  • platform/qt/css2.1/20110323/replaced-intrinsic-005-expected.txt:
  • platform/qt/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png:
  • platform/qt/css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt:
  • platform/qt/css2.1/20110323/replaced-min-max-001-expected.png:
  • platform/qt/css2.1/20110323/replaced-min-max-001-expected.txt:
  • platform/qt/css2.1/20110323/table-caption-001-expected.png: Added.
  • platform/qt/css2.1/20110323/table-caption-001-expected.txt:
  • platform/qt/css2.1/20110323/table-caption-002-expected.png: Added.
  • platform/qt/css2.1/20110323/table-caption-002-expected.txt:
  • platform/qt/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Added.
  • platform/qt/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt:
  • platform/qt/css2.1/20110323/table-caption-margins-001-expected.png: Added.
  • platform/qt/css2.1/20110323/table-caption-margins-001-expected.txt:
  • platform/qt/css2.1/20110323/table-caption-optional-001-expected.png: Added.
  • platform/qt/css2.1/20110323/table-caption-optional-001-expected.txt:
  • platform/qt/css2.1/20110323/table-caption-optional-002-expected.png: Added.
  • platform/qt/css2.1/20110323/table-caption-optional-002-expected.txt:
  • platform/qt/css2.1/20110323/width-non-replaced-inline-001-expected.png:
  • platform/qt/css2.1/20110323/width-non-replaced-inline-001-expected.txt:
  • platform/qt/css2.1/20110323/width-replaced-element-001-expected.png:
  • platform/qt/css2.1/20110323/width-replaced-element-001-expected.txt:
7:19 AM Changeset in webkit [122456] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/LayoutTests

[EFL] Gardening after r122408 and r122414
https://bugs.webkit.org/show_bug.cgi?id=91069

Unreviewed gardening. Add new baseline for state-restore-skip-stateless.html
after r122414 and update expected results for table-vertical-align.html after
r122408.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-12

  • platform/efl/fast/forms/state-restore-skip-stateless-expected.txt:
  • platform/efl/fast/multicol/table-vertical-align-expected.png:
  • platform/efl/fast/multicol/table-vertical-align-expected.txt:
7:13 AM Changeset in webkit [122455] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] Gardening: rebaseline after r122414
https://bugs.webkit.org/show_bug.cgi?id=91064

Unreviewed gardening.

Added the right -expected results for the
fast/forms/state-restore-skip-stateless.html test after
r122414

Patch by Simon Pena <Simon Pena> on 2012-07-12

  • platform/gtk/fast/forms/state-restore-skip-stateless-expected.txt:
7:06 AM Changeset in webkit [122454] by vsevik@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: [Regression] Stale revisions should be removed on navigation.
https://bugs.webkit.org/show_bug.cgi?id=91080

Reviewed by Pavel Feldman.

Moved all the code responsible for script mapping resetting to Workspace.
Stale revisions are removed in Workspace._reset now.

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel):

  • inspector/front-end/StylesPanel.js:

(WebInspector.StylesUISourceCodeProvider):
(WebInspector.StylesUISourceCodeProvider.prototype._populate):
(WebInspector.StylesUISourceCodeProvider.prototype.reset):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype._restoreRevisionHistory):

  • inspector/front-end/Workspace.js:

(WebInspector.Workspace):
(WebInspector.Workspace.prototype._reset):

6:44 AM Changeset in webkit [122453] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Browser crashes running BatteryStatus tests.
https://bugs.webkit.org/show_bug.cgi?id=91065

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-12
Reviewed by Kentaro Hara.

clientInfo was incorrectly casted to BatteryProviderEfl in helper
function. This patch fixes the issue.

  • UIProcess/API/efl/BatteryProvider.cpp:

(toBatteryProvider):

6:39 AM Changeset in webkit [122452] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebKit2

[EFL] [WK2] regression(r122411) Crashes in Ewk_View
https://bugs.webkit.org/show_bug.cgi?id=91068

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-12
Reviewed by Kentaro Hara.

Avoid using calloc() to allocate memory for structures
and use new operator instead. calloc() causes unwanted
behavior when allocing a structure which contains
non-pointer types (e.g. a HashMap) and leads to
crashes.

  • UIProcess/API/efl/ewk_context.cpp:

(_Ewk_Context::_Ewk_Context):

  • UIProcess/API/efl/ewk_intent.cpp:

(_Ewk_Intent):
(_Ewk_Intent::_Ewk_Intent):
(ewk_intent_unref):
(ewk_intent_new):

  • UIProcess/API/efl/ewk_intent_service.cpp:

(_Ewk_Intent_Service):
(_Ewk_Intent_Service::_Ewk_Intent_Service):
(ewk_intent_service_unref):
(ewk_intent_service_new):

  • UIProcess/API/efl/ewk_navigation_policy_decision.cpp:

(_Ewk_Navigation_Policy_Decision):
(_Ewk_Navigation_Policy_Decision::_Ewk_Navigation_Policy_Decision):
(ewk_navigation_policy_decision_free):
(ewk_navigation_policy_decision_new):

  • UIProcess/API/efl/ewk_url_request.cpp:

(_Ewk_Url_Request):
(_Ewk_Url_Request::_Ewk_Url_Request):
(ewk_url_request_unref):
(ewk_url_request_new):

  • UIProcess/API/efl/ewk_url_response.cpp:

(_Ewk_Url_Response):
(_Ewk_Url_Response::_Ewk_Url_Response):
(ewk_url_response_unref):
(ewk_url_response_new):

  • UIProcess/API/efl/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(_ewk_view_priv_del):

  • UIProcess/API/efl/ewk_web_error.cpp:

(_Ewk_Web_Error):
(_Ewk_Web_Error::_Ewk_Web_Error):
(ewk_web_error_free):
(ewk_web_error_new):

  • UIProcess/API/efl/ewk_web_resource.cpp:

(_Ewk_Web_Resource):
(_Ewk_Web_Resource::_Ewk_Web_Resource):
(ewk_web_resource_unref):
(ewk_web_resource_new):

6:32 AM Changeset in webkit [122451] by Csaba Osztrogonác
  • 110 edits in trunk/LayoutTests

[Qt] [Part 1] platform/qt/css1 tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=90809

Batch of expected result files reviewed. It comprises
/LayoutTests/platform/qt/css1/box_properties directory.

Patch by Luciano Wolf <Luciano Miguel Wolf> on 2012-07-12
Reviewed by Csaba Osztrogonác.

  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt/css1/box_properties/acid_test-expected.png:
  • platform/qt/css1/box_properties/acid_test-expected.txt:
  • platform/qt/css1/box_properties/border-expected.png:
  • platform/qt/css1/box_properties/border-expected.txt:
  • platform/qt/css1/box_properties/border_bottom-expected.png:
  • platform/qt/css1/box_properties/border_bottom-expected.txt:
  • platform/qt/css1/box_properties/border_bottom_inline-expected.png:
  • platform/qt/css1/box_properties/border_bottom_inline-expected.txt:
  • platform/qt/css1/box_properties/border_bottom_width-expected.png:
  • platform/qt/css1/box_properties/border_bottom_width-expected.txt:
  • platform/qt/css1/box_properties/border_bottom_width_inline-expected.png:
  • platform/qt/css1/box_properties/border_bottom_width_inline-expected.txt:
  • platform/qt/css1/box_properties/border_color-expected.png:
  • platform/qt/css1/box_properties/border_color-expected.txt:
  • platform/qt/css1/box_properties/border_color_inline-expected.png:
  • platform/qt/css1/box_properties/border_color_inline-expected.txt:
  • platform/qt/css1/box_properties/border_inline-expected.png:
  • platform/qt/css1/box_properties/border_inline-expected.txt:
  • platform/qt/css1/box_properties/border_left-expected.png:
  • platform/qt/css1/box_properties/border_left-expected.txt:
  • platform/qt/css1/box_properties/border_left_inline-expected.png:
  • platform/qt/css1/box_properties/border_left_inline-expected.txt:
  • platform/qt/css1/box_properties/border_left_width-expected.png:
  • platform/qt/css1/box_properties/border_left_width-expected.txt:
  • platform/qt/css1/box_properties/border_left_width_inline-expected.png:
  • platform/qt/css1/box_properties/border_left_width_inline-expected.txt:
  • platform/qt/css1/box_properties/border_right-expected.png:
  • platform/qt/css1/box_properties/border_right-expected.txt:
  • platform/qt/css1/box_properties/border_right_inline-expected.png:
  • platform/qt/css1/box_properties/border_right_inline-expected.txt:
  • platform/qt/css1/box_properties/border_right_width-expected.png:
  • platform/qt/css1/box_properties/border_right_width-expected.txt:
  • platform/qt/css1/box_properties/border_right_width_inline-expected.png:
  • platform/qt/css1/box_properties/border_right_width_inline-expected.txt:
  • platform/qt/css1/box_properties/border_style-expected.png:
  • platform/qt/css1/box_properties/border_style-expected.txt:
  • platform/qt/css1/box_properties/border_style_inline-expected.png:
  • platform/qt/css1/box_properties/border_style_inline-expected.txt:
  • platform/qt/css1/box_properties/border_top-expected.png:
  • platform/qt/css1/box_properties/border_top-expected.txt:
  • platform/qt/css1/box_properties/border_top_inline-expected.png:
  • platform/qt/css1/box_properties/border_top_inline-expected.txt:
  • platform/qt/css1/box_properties/border_top_width-expected.png:
  • platform/qt/css1/box_properties/border_top_width-expected.txt:
  • platform/qt/css1/box_properties/border_top_width_inline-expected.png:
  • platform/qt/css1/box_properties/border_top_width_inline-expected.txt:
  • platform/qt/css1/box_properties/border_width-expected.png:
  • platform/qt/css1/box_properties/border_width-expected.txt:
  • platform/qt/css1/box_properties/border_width_inline-expected.png:
  • platform/qt/css1/box_properties/border_width_inline-expected.txt:
  • platform/qt/css1/box_properties/clear-expected.png:
  • platform/qt/css1/box_properties/clear-expected.txt:
  • platform/qt/css1/box_properties/clear_float-expected.png:
  • platform/qt/css1/box_properties/clear_float-expected.txt:
  • platform/qt/css1/box_properties/float-expected.png:
  • platform/qt/css1/box_properties/float-expected.txt:
  • platform/qt/css1/box_properties/float_elements_in_series-expected.png:
  • platform/qt/css1/box_properties/float_elements_in_series-expected.txt:
  • platform/qt/css1/box_properties/float_margin-expected.png:
  • platform/qt/css1/box_properties/float_margin-expected.txt:
  • platform/qt/css1/box_properties/float_on_text_elements-expected.png:
  • platform/qt/css1/box_properties/float_on_text_elements-expected.txt:
  • platform/qt/css1/box_properties/height-expected.png:
  • platform/qt/css1/box_properties/height-expected.txt:
  • platform/qt/css1/box_properties/margin-expected.png:
  • platform/qt/css1/box_properties/margin-expected.txt:
  • platform/qt/css1/box_properties/margin_bottom-expected.png:
  • platform/qt/css1/box_properties/margin_bottom-expected.txt:
  • platform/qt/css1/box_properties/margin_bottom_inline-expected.png:
  • platform/qt/css1/box_properties/margin_bottom_inline-expected.txt:
  • platform/qt/css1/box_properties/margin_inline-expected.png:
  • platform/qt/css1/box_properties/margin_inline-expected.txt:
  • platform/qt/css1/box_properties/margin_left-expected.png:
  • platform/qt/css1/box_properties/margin_left-expected.txt:
  • platform/qt/css1/box_properties/margin_left_inline-expected.png:
  • platform/qt/css1/box_properties/margin_left_inline-expected.txt:
  • platform/qt/css1/box_properties/margin_right-expected.png:
  • platform/qt/css1/box_properties/margin_right-expected.txt:
  • platform/qt/css1/box_properties/margin_right_inline-expected.png:
  • platform/qt/css1/box_properties/margin_right_inline-expected.txt:
  • platform/qt/css1/box_properties/margin_top-expected.png:
  • platform/qt/css1/box_properties/margin_top-expected.txt:
  • platform/qt/css1/box_properties/margin_top_inline-expected.png:
  • platform/qt/css1/box_properties/margin_top_inline-expected.txt:
  • platform/qt/css1/box_properties/padding-expected.png:
  • platform/qt/css1/box_properties/padding-expected.txt:
  • platform/qt/css1/box_properties/padding_bottom-expected.png:
  • platform/qt/css1/box_properties/padding_bottom-expected.txt:
  • platform/qt/css1/box_properties/padding_bottom_inline-expected.png:
  • platform/qt/css1/box_properties/padding_bottom_inline-expected.txt:
  • platform/qt/css1/box_properties/padding_inline-expected.png:
  • platform/qt/css1/box_properties/padding_inline-expected.txt:
  • platform/qt/css1/box_properties/padding_left-expected.png:
  • platform/qt/css1/box_properties/padding_left-expected.txt:
  • platform/qt/css1/box_properties/padding_left_inline-expected.png:
  • platform/qt/css1/box_properties/padding_left_inline-expected.txt:
  • platform/qt/css1/box_properties/padding_right-expected.png:
  • platform/qt/css1/box_properties/padding_right-expected.txt:
  • platform/qt/css1/box_properties/padding_right_inline-expected.png:
  • platform/qt/css1/box_properties/padding_right_inline-expected.txt:
  • platform/qt/css1/box_properties/padding_top-expected.png:
  • platform/qt/css1/box_properties/padding_top-expected.txt:
  • platform/qt/css1/box_properties/padding_top_inline-expected.png:
  • platform/qt/css1/box_properties/padding_top_inline-expected.txt:
  • platform/qt/css1/box_properties/width-expected.png:
  • platform/qt/css1/box_properties/width-expected.txt:
5:50 AM Changeset in webkit [122450] by kling@webkit.org
  • 12 edits in trunk/Source/WebCore

Make ElementAttributeData a variable-sized object to reduce memory use.
<http://webkit.org/b/88240>

Reviewed by Antti "Obi-Wan" Koivisto.

Take advantage of the fact that we know at ElementAttributeData construction time how many attributes
it needs to accomodate and allocate exactly as much space as needed instead of using a Vector.
For elements that never have their attribute list mutated (the vast majority), this saves a lot of
memory and removes the indirection to Vector<Attribute>'s heap-allocated storage.

Introduced a mutability flag to ElementAttributeData and sprinkled assertions all over to make sure
that nothing tries to mutate an element with a raw attribute array.

When an Element's attribute(s) are mutated, we reconstruct the ElementAttributeData, this time using
a Vector as backing instead. This is triggered when calling Element::mutableAttributeData().

This reduces memory consumption by 3.2MB when viewing the full HTML5 spec at <http://whatwg.org/c/>.
That is a ~35% reduction in DOM attribute memory use.

Furthermore, that page ends up promoting 27% of the elements to mutable attribute storage due to dynamic
adding of "class" attributes. For more static pages, savings are even greater.

Also did away with ElementAttributeData::removeAttribute(name) and do separate index lookup where
needed. Not a big deal but avoids double lookup of attributes when removing them.

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::InlineCSSStyleDeclaration::ensureMutablePropertySet):

Call ensureInlineStyle() on the element so we know we have a StylePropertySet to work with.
May cause the creation (and replacement) of a new underlying StylePropertySet on the Element's
attribute data.

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::adoptCSSOMWrapperFrom):

Added. Allows switching the underlying StylePropertySet object while retaining CSSOM wrapper
identity (web facing behavior.)

  • dom/Element.cpp:

(WebCore::Element::detachAttribute):
(WebCore::Element::removeAttribute):
(WebCore::Element::attributes):
(WebCore::Element::setAttributeInternal):
(WebCore::Element::parserSetAttributes):
(WebCore::Element::hasEquivalentAttributes):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeNode):
(WebCore::Element::getAttributeNode):
(WebCore::Element::getAttributeNodeNS):
(WebCore::Element::hasAttribute):
(WebCore::Element::hasAttributeNS):
(WebCore::Element::normalizeAttributes):
(WebCore::Element::cloneAttributesFromElement):
(WebCore::Element::createMutableAttributeData):

  • dom/Element.h:

(WebCore::Element::attributeData):
(Element):
(WebCore::Element::updatedAttributeData):
(WebCore::Element::ensureAttributeData):
(WebCore::Element::ensureUpdatedAttributeData):
(WebCore::Element::mutableAttributeData):
(WebCore):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::createImmutable):
(WebCore):
(WebCore::ElementAttributeData::ElementAttributeData):
(WebCore::ElementAttributeData::~ElementAttributeData):
(WebCore::ElementAttributeData::attrIfExists):
(WebCore::ElementAttributeData::ensureAttr):
(WebCore::ElementAttributeData::setAttr):
(WebCore::ElementAttributeData::removeAttr):
(WebCore::ElementAttributeData::ensureInlineStyle):
(WebCore::ElementAttributeData::ensureMutableInlineStyle):
(WebCore::ElementAttributeData::destroyInlineStyle):
(WebCore::ElementAttributeData::addAttribute):
(WebCore::ElementAttributeData::removeAttribute):
(WebCore::ElementAttributeData::isEquivalent):
(WebCore::ElementAttributeData::detachAttrObjectsFromElement):
(WebCore::ElementAttributeData::getAttributeItemIndexSlowCase):
(WebCore::ElementAttributeData::cloneDataFrom):
(WebCore::ElementAttributeData::clearAttributes):
(WebCore::ElementAttributeData::replaceAttribute):
(WebCore::ElementAttributeData::getAttributeNode):

  • dom/ElementAttributeData.h:

(WebCore::ElementAttributeData::create):
(ElementAttributeData):
(WebCore::ElementAttributeData::setClass):
(WebCore::ElementAttributeData::setIdForStyleResolution):
(WebCore::ElementAttributeData::inlineStyle):
(WebCore::ElementAttributeData::setAttributeStyle):
(WebCore::ElementAttributeData::reportMemoryUsage):
(WebCore::ElementAttributeData::isMutable):
(WebCore::ElementAttributeData::makeMutable):
(WebCore::ElementAttributeData::length):
(WebCore):
(WebCore::ElementAttributeData::isEmpty):
(WebCore::ElementAttributeData::array):
(WebCore::ElementAttributeData::removeAttribute):
(WebCore::ElementAttributeData::getAttributeItem):
(WebCore::ElementAttributeData::getAttributeItemIndex):
(WebCore::ElementAttributeData::attributeItem):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::style):
(WebCore::StyledElement::classAttributeChanged):
(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::removeInlineStyleProperty):
(WebCore::StyledElement::addSubresourceAttributeURLs):

  • dom/StyledElement.h:

(WebCore::StyledElement::ensureInlineStyle):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::createHTMLElementFromSavedElement):

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):

5:26 AM Changeset in webkit [122449] by fmalita@chromium.org
  • 10 edits
    2 adds in trunk

Incorrect handling of chained pending resources in SVGUseElement
https://bugs.webkit.org/show_bug.cgi?id=89686

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Currently SVGUseElement builds the shadow tree when the target first
becomes available. This is normally OK, but if the target itself (or
one of its children) is a <use> element with pending resources, then
the shadow expansion only captures the current state of the tree and
never gets updated when the pending resource becomes available.

In order to support arbitrary <use>-on-<use> constructs, this patch
tracks nested <use> dependencies and rebuilds the dependent trees
whenever the target gets updated.

Tests: svg/custom/use-nested-expected.svg

svg/custom/use-nested.svg

  • svg/SVGElement.cpp:

(WebCore::SVGElement::removedFrom): removedFrom needs to be called up the inheritance chain
before invoking removeAllElementReferencesForTarget. Otherwise we could end up finding the
element being removed as a valid target in SVGUseElement::buildInstanceTree because its
InDocument flag is not cleared yet.

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::~SVGUseElement):
(WebCore::SVGUseElement::clearResourceReferences):
(WebCore::SVGUseElement::buildPendingResource):
(WebCore::SVGUseElement::buildShadowAndInstanceTree):
(WebCore::SVGUseElement::buildInstanceTree):

  • svg/SVGUseElement.h:

(SVGUseElement):
Track <use> -> <use> dependencies using SVGDocumentExtensions'
m_elementDependencies framework and ensure dependent trees are rebuilt
when the target itself gets rebuilt.

LayoutTests:

Added reftest to verify that nested/indirect <use> constructs are
handled correctly WRT pending resource tracking.

Also updated the svg/hixie/error/017-expected.txt to match the current
results. Per comments in SVGUseElement::buildShadowAndInstanceTree, the
new behavior is correct: <use> cycles are to be ignored.

  • platform/chromium-win/svg/hixie/error/017-expected.txt:
  • platform/efl/svg/hixie/error/017-expected.txt:
  • platform/gtk/svg/hixie/error/017-expected.txt:
  • platform/mac/svg/hixie/error/017-expected.txt:
  • platform/qt/svg/hixie/error/017-expected.txt:
  • svg/custom/use-nested-expected.svg: Added.
  • svg/custom/use-nested.svg: Added.
5:05 AM Changeset in webkit [122448] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening, fixing a typo in test's filename in TestExpectations.

  • platform/gtk/TestExpectations:
4:54 AM Changeset in webkit [122447] by morrita@google.com
  • 4 edits in trunk/Source/WebCore

Typo: ParentTranversalDetails should be ParentTraversalDetails
https://bugs.webkit.org/show_bug.cgi?id=91059

Reviewed by Andreas Kling.

Did a bare rename from ParentTranversalDetails to ParentTraversalDetails

No new tests, just a rename.

  • dom/ComposedShadowTreeWalker.cpp:

(WebCore::ComposedShadowTreeWalker::ParentTraversalDetails::didTraverseInsertionPoint):
(WebCore::ComposedShadowTreeWalker::ParentTraversalDetails::didTraverseShadowRoot):
(WebCore::ComposedShadowTreeWalker::ParentTraversalDetails::didFindNode):
(WebCore::ComposedShadowTreeWalker::findParent):
(WebCore::ComposedShadowTreeWalker::traverseNodeEscapingFallbackContents):
(WebCore::ComposedShadowTreeWalker::traverseParent):
(WebCore::ComposedShadowTreeWalker::traverseParentInCurrentTree):
(WebCore::ComposedShadowTreeWalker::traverseParentBackToYoungerShadowRootOrHost):

  • dom/ComposedShadowTreeWalker.h:

(WebCore::ComposedShadowTreeWalker::ParentTraversalDetails::ParentTraversalDetails):
(ComposedShadowTreeWalker):

  • dom/NodeRenderingContext.h:

(NodeRenderingContext):

4:41 AM Changeset in webkit [122446] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Failure to dispatch didFinishLoadForFrame if font load fails synchronously
https://bugs.webkit.org/show_bug.cgi?id=91018

Reviewed by Enrica Casucci.

New font loads may be triggered by layout after the document load is complete but before we have dispatched
didFinishLoading for the frame. If the load fails synchronously we might fail to ever invoke
FrameLoader::checkLoadComplete and so fail to dispatch didFinishLoading.

Make sure this doesn't happen by calling FrameLoader::checkLoadComplete explicitly after triggering font loads.

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::beginLoadTimerFired):

4:26 AM Changeset in webkit [122445] by gyuyoung.kim@samsung.com
  • 12 edits
    3 moves
    1 add in trunk/Source/WebCore

Register protocol handler files should be in Modules/protocolhandler
https://bugs.webkit.org/show_bug.cgi?id=90766

Reviewed by Hajime Morita.

The register protocol handler files are now self-contained. This patch is moved to the Modules.

No new tests. Covered by existing tests.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • Modules/protocolhandler/NavigatorRegisterProtocolHandler.cpp: Renamed from Source/WebCore/page/NavigatorRegisterProtocolHandler.cpp.

(WebCore):
(WebCore::initProtocolHandlerWhitelist):
(WebCore::verifyCustomHandlerURL):
(WebCore::isProtocolWhitelisted):
(WebCore::verifyProtocolHandlerScheme):
(WebCore::NavigatorRegisterProtocolHandler::NavigatorRegisterProtocolHandler):
(WebCore::NavigatorRegisterProtocolHandler::~NavigatorRegisterProtocolHandler):
(WebCore::NavigatorRegisterProtocolHandler::registerProtocolHandler):
(WebCore::customHandlersStateString):
(WebCore::NavigatorRegisterProtocolHandler::isProtocolHandlerRegistered):
(WebCore::NavigatorRegisterProtocolHandler::unregisterProtocolHandler):

  • Modules/protocolhandler/NavigatorRegisterProtocolHandler.h: Renamed from Source/WebCore/page/NavigatorRegisterProtocolHandler.h.

(WebCore):
(NavigatorRegisterProtocolHandler):

  • Modules/protocolhandler/NavigatorRegisterProtocolHandler.idl: Renamed from Source/WebCore/page/NavigatorRegisterProtocolHandler.idl.
  • Target.pri:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.vcproj/copyForwardingHeaders.cmd:
  • WebCore.xcodeproj/project.pbxproj:
4:18 AM Changeset in webkit [122444] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[BlackBerry] Cannot use digest proxy auth and NTLM auth at the same time
https://bugs.webkit.org/show_bug.cgi?id=91054

Patch by Jonathan Dong <Jonathan Dong> on 2012-07-12
Reviewed by George Staikos.

Source/WebCore:

Added an interface function syncProxyCredential() in class
PageClientBlackBerry, which is responsible to notify WebPageClient
to synchronize proxy credential to the chrome process.

Internally reviewed by Jason Liu <jason.liu@torchmobile.com.cn>

No new tests since there's no functional change.

  • platform/blackberry/PageClientBlackBerry.h:
  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::storeCredentials): Remember the accepted proxy
credential and notify webpage client to synchronize it.

Source/WebKit/blackberry:

Implemented interface function syncProxyCredential() derived
from class PageClientBlackBerry.

Internally reviewed by Jason Liu <jason.liu@torchmobile.com.cn>

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::syncProxyCredential):
(WebKit):

  • Api/WebPageClient.h:
  • Api/WebPage_p.h:

(WebPagePrivate):

4:16 AM Changeset in webkit [122443] by kkristof@inf.u-szeged.hu
  • 2 edits
    1 move in trunk/LayoutTests

[Qt] Unreviewed gardening.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-07-12

  • platform/qt/Skipped:
  • platform/qt/fast/forms/state-restore-skip-stateless-expected.txt: Renamed from LayoutTests/platform/qt/fast/forms/state-restore-.
3:56 AM Changeset in webkit [122442] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip new failing test.

  • platform/qt/Skipped:
3:44 AM Changeset in webkit [122441] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[GTK] Rebaseline after 122416 and r122408
https://bugs.webkit.org/show_bug.cgi?id=91066

Unreviewed gardening.

Rebaseline fast/multicol/table-vertical-align.html
after r122416 (which updated results missing after the fix
from r122408)

Patch by Simon Pena <Simon Pena> on 2012-07-12

  • platform/gtk/fast/multicol/table-vertical-align-expected.png:
  • platform/gtk/fast/multicol/table-vertical-align-expected.txt:
3:29 AM Changeset in webkit [122440] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt] Internal symbols are exported on Linux
https://bugs.webkit.org/show_bug.cgi?id=90981

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-07-12
Reviewed by Jocelyn Turcotte.

I should've re-enabled ELF symbol visibility when removing the symbol map in
r106650.

  • qmake/mkspecs/features/default_post.prf:
3:08 AM Changeset in webkit [122439] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

[GTK] Gardening: rebaseline after r122414
https://bugs.webkit.org/show_bug.cgi?id=91064

Unreviewed gardening. Add new baseline after r122414
for fast/forms/state-restore-skip-stateless.html

Patch by Simon Pena <Simon Pena> on 2012-07-12

  • platform/gtk/fast/forms/state-restore-skip-stateless-expected.txt: Added.
3:04 AM Changeset in webkit [122438] by abecsi@webkit.org
  • 4 edits in trunk/Source/WebKit2

[Qt][WK2] ASSERT: "!m_viewportItem->isMoving()" in QtViewportHandler::flickMoveEnded()
https://bugs.webkit.org/show_bug.cgi?id=90875

Reviewed by Kenneth Rohde Christiansen.

Since MultiPointTouchArea and PinchArea use the childMouseEventFilter
method to filter touch events and because Flickable filters child mouse
events the canvas calls this function before propagating the touch event
to the WebView. Since Flickable does not accept touch events the canvas
tries to propagate a synthesized mouse event through the base class
childMouseEventFilter function which is accepted by Flickable and
interferes with the input events we send to Flicakble hence messes up
the internal state of the WebView.
This patch reimplements the virtual childMouseEventFilter method so that all
the mouse and touch events can be processed by WebKit before they arrive to
Flickable.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebView::childMouseEventFilter):

  • UIProcess/API/qt/qquickwebview_p.h:
3:04 AM Changeset in webkit [122437] by caseq@chromium.org
  • 4 edits in trunk/LayoutTests

Layout Test inspector/timeline/timeline-dom-content-loaded-event.html is failing
https://bugs.webkit.org/show_bug.cgi?id=90984

Reviewed by Vsevolod Vlasov.

  • remove test flakiness by only outputting result when page completed reload;
  • inspector/timeline/timeline-dom-content-loaded-event-expected.txt:
  • inspector/timeline/timeline-dom-content-loaded-event.html:
3:02 AM Changeset in webkit [122436] by vsevik@chromium.org
  • 4 edits in trunk/LayoutTests

REGRESSION(r122327): It made http/tests/inspector/network/network-request-revision-content.html fail on Lion, Qt
https://bugs.webkit.org/show_bug.cgi?id=90979

Reviewed by Pavel Feldman.

  • http/tests/inspector/network/network-request-revision-content-expected.txt:
  • http/tests/inspector/network/network-request-revision-content.html:
  • platform/qt/Skipped:
2:46 AM Changeset in webkit [122435] by commit-queue@webkit.org
  • 5 edits in trunk

[IndexedDB] upperOpen set to true in lowerBound()/lowerOpen set to true in upperBound()
https://bugs.webkit.org/show_bug.cgi?id=90867

Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-07-12
Reviewed by Tony Chang.

Source/WebCore:

In the latest W3C spec upperOpen/lowerOpen are set to true in lowerBound()/upperBound(), which
we should keep aligned with.

No new tests - updated storage/indexeddb/keyrange.html to match new behavior.

  • Modules/indexeddb/IDBKeyRange.cpp:

(WebCore::IDBKeyRange::lowerBound):
(WebCore::IDBKeyRange::upperBound):

LayoutTests:

  • storage/indexeddb/keyrange-expected.txt:
  • storage/indexeddb/resources/keyrange.js:

(checkLowerBoundKeyRange):
(checkUpperBoundKeyRange):

2:37 AM Changeset in webkit [122434] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip the new failing test.

  • platform/qt/Skipped:
2:31 AM Changeset in webkit [122433] by kkristof@inf.u-szeged.hu
  • 1 edit
    1 add in trunk/LayoutTests

[Qt] Unreviewed gardening. Added new platform specific expected after r122414.
https://bugs.webkit.org/show_bug.cgi?id=91060.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-07-12

  • platform/qt/fast/forms/state-restore-skip-stateless-expected.txt: Added after r122414.
2:11 AM Changeset in webkit [122432] by morrita@google.com
  • 4 edits
    2 adds in trunk

[Shadow DOM] <video> with <shadow> crashes
https://bugs.webkit.org/show_bug.cgi?id=91055

Reviewed by Kent Tamura.

Source/WebCore:

This is similar to Bug 90480, where an undesired renderer is created by
locating an insertion point on the shadow boundary.

This change adds a guard for such case by cheking whether the
source node of each to-be-created renderer comes from the UA shadow
tree, which is allowed to have a renderer.

Test: fast/dom/shadow/insertion-point-video-crash.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::childShouldCreateRenderer): Added a check.
(WebCore::HTMLMediaElement::mediaControls): Added const.
(WebCore::HTMLMediaElement::hasMediaControls): Added const.

  • html/HTMLMediaElement.h:

(HTMLMediaElement):

LayoutTests:

  • fast/dom/shadow/insertion-point-video-crash-expected.txt: Added.
  • fast/dom/shadow/insertion-point-video-crash.html: Added.
2:07 AM Changeset in webkit [122431] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip new failing test introduced in r122399

  • platform/qt/Skipped:
2:00 AM Changeset in webkit [122430] by yosin@chromium.org
  • 3 edits in trunk/Source/WebCore

REGRESSION(r122184): LocaleMac::currentLocale should use current locale rather than newly create locale object.
https://bugs.webkit.org/show_bug.cgi?id=91057

Reviewed by Kent Tamura.

This patch changes NSLocale object of LocaleMac::m_locale variable to
current NSLocale object rather than newly created NSLocale object from
locale identifier.

No new tests. We don't have way to change system preferences from
test scripts and restoring them. To test this patch, we need to do so.

  • platform/text/mac/LocaleMac.h:

(LocaleMac): Added a constructor which takes NSLocale object.

  • platform/text/mac/LocaleMac.mm:

(WebCore::LocaleMac::LocaleMac): Added a constructor which takes NSLocale object.
(WebCore::LocaleMac::currentLocale): Changed to construct LocaleMac object from NSLocale object rather than locale identifier.

1:57 AM Changeset in webkit [122429] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

Unreviewed. Fix GTK+ debug build after r122425.

  • WebProcess/Cookies/soup/WebKitSoupCookieJarSqlite.cpp:

(webkitSoupCookieJarSqliteNew):

1:38 AM Changeset in webkit [122428] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

[WK2] Performance issue in FindController::findString
https://bugs.webkit.org/show_bug.cgi?id=78132

Patch by Sergio Villar Senin <svillar@igalia.com> on 2012-07-12
Reviewed by Anders Carlsson.

FindController should not unmark all text matches by default. It
will be done only if the string is not found or if
markAllTextMatches() is called. This will allow clients to look
for the next/previous without having to unmark() + mark() all the
text matches for every single search operation.

  • UIProcess/API/gtk/WebKitFindController.cpp:

(webKitFindControllerPerform):
(webkit_find_controller_search_next):
(webkit_find_controller_search_previous):

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::updateFindUIAfterPageScroll):
(WebKit::FindController::findString):

1:38 AM Changeset in webkit [122427] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

Typo in path in generate-webkitversion.pl
https://bugs.webkit.org/show_bug.cgi?id=90883

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-07-12
Reviewed by Mark Rowe.

Correct default path to version config file. In practice it wasn't a problem because only the Qt
build system seems to use the script right now and passes the path to the version file as a
command line parameter.

  • scripts/generate-webkitversion.pl:
1:35 AM Changeset in webkit [122426] by commit-queue@webkit.org
  • 6 edits
    6 adds in trunk/Source/WebKit2

[WK2][EFL] Add policy client to Ewk_View
https://bugs.webkit.org/show_bug.cgi?id=90953

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-12
Reviewed by Kenneth Rohde Christiansen.

Emit new "policy,decision,navigation" and "policy,decision,new,window"
on the Ewk_View when policy decisions should be taken by the client.

A new Ewk_Navigation_Policy_Decision type is introduced to provide
information about the navigation request and make a decision.
By default, the navigation request is accepted.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/EWebKit2.h:
  • UIProcess/API/efl/ewk_navigation_policy_decision.cpp: Added.

(_Ewk_Navigation_Policy_Decision):
(ewk_navigation_policy_decision_free):
(ewk_navigation_policy_navigation_type_get):
(ewk_navigation_policy_mouse_button_get):
(ewk_navigation_policy_modifiers_get):
(ewk_navigation_policy_frame_name_get):
(ewk_navigation_policy_request_get):
(ewk_navigation_policy_decision_accept):
(ewk_navigation_policy_decision_reject):
(ewk_navigation_policy_decision_download):
(ewk_navigation_policy_decision_new):

  • UIProcess/API/efl/ewk_navigation_policy_decision.h: Added.
  • UIProcess/API/efl/ewk_navigation_policy_decision_private.h: Added.
  • UIProcess/API/efl/ewk_private.h: Added.
  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_base_add):
(ewk_view_navigation_policy_decision):
(ewk_view_new_window_policy_decision):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/ewk_view_policy_client.cpp: Added.

(toEwkView):
(decidePolicyForNavigationAction):
(decidePolicyForNewWindowAction):
(ewk_view_policy_client_attach):

  • UIProcess/API/efl/ewk_view_policy_client_private.h: Added.
  • UIProcess/API/efl/ewk_view_private.h:
1:28 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
(diff)
1:28 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
Persistent cookies done! (diff)
1:12 AM Changeset in webkit [122425] by Carlos Garcia Campos
  • 14 edits
    1 copy
    4 adds in trunk/Source

[GTK] Add webkit_cookie_manager_set_persistent_storage() to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=83016

Reviewed by Martin Robinson.

Source/WebCore:

  • platform/network/soup/CookieStorageSoup.cpp:

(WebCore::soupCookiesChanged): Do not notify about changes in
other cookie jars than the current one.

Source/WebKit2:

Add a custom implementation of SoupCookieJarSqlite based on
libsoup code but using WebCore SQLite classes. SoupCookieJarSqlite
is part of libsoup-gnome, it's not a lot of code and it doesn't
change often, so it's better to simply have our own implementation
instead of making this important feature depend on an optional
dependency. There are plans to move the implementation to libsoup,
if that eventually happens we will remove our code to use libsoup
directly.

  • GNUmakefile.am: Add new dirs to include path.
  • GNUmakefile.list.am: Add new files to compilation.
  • PlatformEfl.cmake: Ditto.
  • Shared/soup/SoupCookiePersistentStorageType.h: Added.
  • UIProcess/API/gtk/WebKitCookieManager.cpp:

(webkit_cookie_manager_set_persistent_storage): Set a persistent
storage for cookies.

  • UIProcess/API/gtk/WebKitCookieManager.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols
  • UIProcess/API/gtk/tests/TestCookieManager.cpp:

(testCookieManagerPersistentStorage):
(serverCallback):
(beforeAll):
(afterAll):

  • UIProcess/WebCookieManagerProxy.h:

(WebCookieManagerProxy): Add setCookiePersistentStorage() method
when using soup.

  • UIProcess/soup/WebCookieManagerProxySoup.cpp: Added.

(WebKit::WebCookieManagerProxy::setCookiePersistentStorage): Send
SetCookiePersistentStorage message to the web process.

  • WebProcess/Cookies/WebCookieManager.h:

(WebCookieManager): Add setCookiePersistentStorage() method when
using soup.

  • WebProcess/Cookies/WebCookieManager.messages.in: Add

SetCookiePersistentStorage message when using soup.

  • WebProcess/Cookies/soup/WebCookieManagerSoup.cpp:

(WebKit::WebCookieManager::setCookiePersistentStorage): Create a
new cookie jar for the given filename and storage type and add it
to the soup session.

  • WebProcess/Cookies/soup/WebKitSoupCookieJarSqlite.cpp: Added.

(webkitSoupCookieJarSqliteOpenDatabase): Open SQLite database.
(webkitSoupCookieJarSqliteCreateTable): Create moz_cookies if it
doesn't exist.
(webkitSoupCookieJarSqliteLoad): Load the initial set of cookies
from the database.
(webkitSoupCookieJarSqliteInsertCookie): Insert a new cookie into
the database.
(webkitSoupCookieJarSqliteDeleteCookie): Delete an exising cookie
from the database.
(webkitSoupCookieJarSqliteChanged): Insert/delete cookies
depending on the change.
(webkitSoupCookieJarSqliteFinalize):
(webkit_soup_cookie_jar_sqlite_init):
(webkit_soup_cookie_jar_sqlite_class_init):
(webkitSoupCookieJarSqliteNew):

  • WebProcess/Cookies/soup/WebKitSoupCookieJarSqlite.h: Added.
1:10 AM Changeset in webkit [122424] by pdr@google.com
  • 7 edits in trunk/Source/WebCore

Refactor RenderSVGShape bounding box code
https://bugs.webkit.org/show_bug.cgi?id=90655

Reviewed by Nikolas Zimmermann.

RenderSVGShape::objectBoundingBox worked differently than RenderSVGShape::strokeBoundingBox by
not caching the object bounding box and instead computing it on each call. For consistency and
performance objectBoundingBox has been refactored to return a cached value.

createShape has been renamed updateShapeFromElement for understandability. updateShapeFromElement
now updates the internal state of the shape (bounding boxes, etc) from the associated element.
RenderSVGShape::inflateWithStrokeAndMarkerBounds has been merged into
RenderSVGShape::calculateStrokeBoundingBox which is called from updateShapeFromElement.

After this change all bounding box computation is now handled in updateShapeFromElement. Because
subclasses override updateShapeFromElement it will be easy for them to have custom bounding box
code there (as will happen for RenderSVGPath in a followup patch).

strokeBoundingBox and objectBoundingBox are now able to return their cached values immediately
in RenderSVGRect and RenderSVGEllipse instead of checking their fallback state on each call.

Additionally, to save space RenderSVGEllipse and RenderSVGRect now use the m_fillBoundingBox and
m_strokeBoundingBox of RenderSVGShape instead of having their own.

This patch also removes setStrokeAndMarkerBoundingBox that was previously dead code.

No new tests, just a refactoring.

  • rendering/svg/RenderSVGEllipse.cpp:

(WebCore::RenderSVGEllipse::updateShapeFromElement):
(WebCore):
(WebCore::RenderSVGEllipse::fillShape):
(WebCore::RenderSVGEllipse::strokeShape):
(WebCore::RenderSVGEllipse::shapeDependentStrokeContains):

  • rendering/svg/RenderSVGEllipse.h:

(RenderSVGEllipse):
(WebCore::RenderSVGEllipse::isEmpty):

  • rendering/svg/RenderSVGRect.cpp:

(WebCore::RenderSVGRect::updateShapeFromElement):
(WebCore):
(WebCore::RenderSVGRect::fillShape):
(WebCore::RenderSVGRect::strokeShape):
(WebCore::RenderSVGRect::shapeDependentStrokeContains):
(WebCore::RenderSVGRect::shapeDependentFillContains):

  • rendering/svg/RenderSVGRect.h:

(RenderSVGRect):
(WebCore::RenderSVGRect::isEmpty):

  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::updateShapeFromElement):
(WebCore):
(WebCore::RenderSVGShape::layout):
(WebCore::RenderSVGShape::calculateObjectBoundingBox):
(WebCore::RenderSVGShape::calculateStrokeBoundingBox):
(WebCore::RenderSVGShape::updateRepaintBoundingBox):

  • rendering/svg/RenderSVGShape.h:

(RenderSVGShape):
(WebCore::RenderSVGShape::objectBoundingBox):
(WebCore::RenderSVGShape::strokeBoundingBox):

12:53 AM Changeset in webkit [122423] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

Remove dead code after r122392.
https://bugs.webkit.org/show_bug.cgi?id=91049

Reviewed by Filip Pizlo.

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

12:31 AM Changeset in webkit [122422] by tkent@chromium.org
  • 3 edits
    3 adds in trunk

Do not save the form state signature if nothing is saved
https://bugs.webkit.org/show_bug.cgi?id=91050

Reviewed by Hajime Morita.

Source/WebCore:

This change will reduce the size of HistoyItem.

Test: fast/forms/state-restore-empty-state.html

  • html/FormController.cpp:

(WebCore::FormController::formElementsState):
If stateVector has only the signature string, clear it.

LayoutTests:

  • fast/forms/resources/state-restore-empty-state-1.html: Added.
  • fast/forms/state-restore-empty-state-expected.txt: Added.
  • fast/forms/state-restore-empty-state.html: Added.

Jul 11, 2012:

11:18 PM Changeset in webkit [122421] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

<http://webkit.org/b/91051> Fix the Qt Mac build after r122400.

Qt on Mac builds with a deployment target of OS X 10.5. However, it was not been setting
BUILDING_ON_LEOPARD / TARGETING_LEOPARD and thus was falling down code paths in DisplaySleepDisabler.cpp
that were specific to Snow Leopard and newer. After the removal of BUILDING_ON_LEOPARD
and TARGETING_LEOPARD it ended up falling down the correct Leopard-compatible code path,
which revealed that the code made assumptions about which headers had already been included.

  • platform/mac/DisplaySleepDisabler.cpp: Include CoreServices/CoreServices.h to pull in

a declaration of UpdateSystemActivity when targeting Leopard.

10:33 PM Changeset in webkit [122420] by commit-queue@webkit.org
  • 12 edits
    5 adds in trunk

Add dialog element feature toggle to InternalSettings
https://bugs.webkit.org/show_bug.cgi?id=90934

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-07-11
Reviewed by Hajime Morita.

.:

  • Source/autotools/symbols.filter: Added newly exported symbol.

Source/WebCore:

This enables layout tests to be written for dialog although the feature is disabled by default.

Tests: fast/dom/HTMLDialogElement/dialog-disabled.html

fast/dom/HTMLDialogElement/dialog-enabled.html

  • WebCore.exp.in: Added newly exported symbol.
  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup): Backup dialog feature flag.
(WebCore::InternalSettings::Backup::restoreTo): Restore dialog feature flag.
(WebCore::InternalSettings::setDialogElementEnabled): Added.
(WebCore):

  • testing/InternalSettings.h: Added support for dialog.

(Backup):
(InternalSettings):

  • testing/InternalSettings.idl: Added support for dialog.

LayoutTests:

  • fast/dom/HTMLDialogElement/dialog-disabled-expected.txt: Added.
  • fast/dom/HTMLDialogElement/dialog-disabled.html: Added.
  • fast/dom/HTMLDialogElement/dialog-enabled-expected.txt: Added.
  • fast/dom/HTMLDialogElement/dialog-enabled.html: Added.
  • platform/efl/TestExpectations: Skipped because ENABLE_DIALOG_ELEMENT is off by default.
  • platform/gtk/TestExpectations: Ditto.
  • platform/mac/TestExpectations: Ditto.
  • platform/qt/TestExpectations: Ditto.
10:20 PM Changeset in webkit [122419] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium/TestExpectations: Started TIMEOUT on Mac.
10:17 PM Changeset in webkit [122418] by tkent@chromium.org
  • 3 edits
    3 adds in trunk

Accessing width or height of a detached image input element causes crash
https://bugs.webkit.org/show_bug.cgi?id=90885

Reviewed by Kentaro Hara.

Source/WebCore:

Test: fast/forms/image/width-and-height-of-detached-input.html

  • html/ImageInputType.cpp:

(WebCore::ImageInputType::height): Add null check for m_imageLoader.
(WebCore::ImageInputType::width): ditto.

LayoutTests:

  • fast/forms/image/width-and-height-of-detached-input-expected.txt: Added.
  • fast/forms/image/width-and-height-of-detached-input.html: Added.
10:00 PM Changeset in webkit [122417] by mitz@apple.com
  • 1 edit in trunk/LayoutTests/platform/mac/fast/multicol/table-vertical-align-expected.txt

Actually commit the results for r122416.

9:58 PM Changeset in webkit [122416] by mitz@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

Updated expected results for this test after r122408, which fixed it.

  • platform/mac/fast/multicol/table-vertical-align-expected.txt:
9:34 PM Changeset in webkit [122415] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.
html5lib/runner.html started crashing after r122359.

  • platform/chromium/TestExpectations:
9:08 PM Changeset in webkit [122414] by tkent@chromium.org
  • 13 edits
    3 adds in trunk

Do not save state of stateless form controls
https://bugs.webkit.org/show_bug.cgi?id=90964

Reviewed by Hajime Morita.

Source/WebCore:

By Bug 89409, we started to store unmodified form control
state. However we don't need to make such state for the following
types.

  • password
  • submit
  • reset
  • button
  • keygen

Test: fast/forms/state-restore-skip-stateless.html

  • html/BaseButtonInputType.cpp:

(WebCore::BaseButtonInputType::shouldSaveAndRestoreFormControlState):
Added. Disable saving state for submit, reset, and button types.

  • html/BaseButtonInputType.h:

(BaseButtonInputType): Add shouldSaveAndRestoreFormControlState.

  • html/HTMLFormControlElementWithState.h:

(HTMLFormControlElementWithState): Make shouldSaveAndRestoreFormControlState virtual.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::shouldSaveAndRestoreFormControlState):
Added. Checks InputType::shouldSaveAndRestoreFormControlState first.

  • html/HTMLInputElement.h:

(HTMLInputElement): Override shouldSaveAndRestoreFormControlState.

  • html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::shouldSaveAndRestoreFormControlState)
Added. Disable saving state for <keygen>.:

  • html/HTMLKeygenElement.h: Override shouldSaveAndRestoreFormControlState.
  • html/InputType.cpp:

(WebCore::InputType::shouldSaveAndRestoreFormControlState):
Added. Enable saving state for all types by default.

  • html/InputType.h:

(InputType): Add shouldSaveAndRestoreFormControlState.

  • html/PasswordInputType.cpp:

(WebCore::PasswordInputType::shouldSaveAndRestoreFormControlState):
Added. Disabled saving state.
(WebCore::PasswordInputType::saveFormControlState):
Because shouldSaveAndRestoreFormControlState() returns false,
saveFormControlState should be never called.

  • html/PasswordInputType.h:

(PasswordInputType): Override shouldSaveAndRestoreFormControlState.

LayoutTests:

  • fast/forms/resources/state-restore-skip-stateless-dump.html: Added.
  • fast/forms/state-restore-skip-stateless-expected.txt: Added.
  • fast/forms/state-restore-skip-stateless.html: Added.
8:54 PM Changeset in webkit [122413] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebCore

Compilation error with GLES2 when using gl2ext.h from ANGLE.
https://bugs.webkit.org/show_bug.cgi?id=91030

Reviewed by Kenneth Russell.

gl2ext.h defines PFNGLRENDERBUFFERSTORAGEMULTISAMPLEIMG and not
PFNGLRENDERBUFFERSTORAGEMULTISAMPLEIMGPROC. This is a bug in the original Khronos header,
but we should work around it until fixed headers are integrated.

  • platform/graphics/opengl/Extensions3DOpenGLES.h:

(Extensions3DOpenGLES):

Removed the "PROC" suffix to work around the header bug.

8:23 PM Changeset in webkit [122412] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Attempt to fix the Chromium Mac build after r122400.

  • platform/text/cf/HyphenationCF.cpp: Ensure that Chromium only compiles the body of this file if

building for a new enough version of OS X.

8:22 PM Changeset in webkit [122411] by commit-queue@webkit.org
  • 7 edits
    3 adds in trunk/Source/WebKit2

[WK2][EFL] Ewk_View should provide more resource loading notifications
https://bugs.webkit.org/show_bug.cgi?id=90601

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-11
Reviewed by Antonio Gomes.

Add new "resource,request,sent", "resource,request,response",
"resource,request,failed" and "resource,request,finished" to
Ewk_View in order to notify the clients of the main resource
load state changes.

Introduce new Ewk_Url_Response type that is used to provide
information to the clients regarding the resource load
responses that are received.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/EWebKit2.h:
  • UIProcess/API/efl/ewk_url_response.cpp: Added.

(_Ewk_Url_Response):
(ewk_url_response_ref):
(ewk_url_response_unref):
(ewk_url_response_url_get):
(ewk_url_response_status_code_get):
(ewk_url_response_mime_type_get):
(ewk_url_response_new):

  • UIProcess/API/efl/ewk_url_response.h: Added.
  • UIProcess/API/efl/ewk_url_response_private.h: Added.
  • UIProcess/API/efl/ewk_view.cpp:

(_Ewk_View_Private_Data):
(ewk_view_resource_load_initiated):
(ewk_view_resource_load_response):
(ewk_view_resource_load_failed):
(ewk_view_resource_load_finished):
(ewk_view_resource_request_sent):
(ewk_view_load_provisional_started):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/ewk_view_private.h:
  • UIProcess/API/efl/ewk_view_resource_load_client.cpp:

(toEwkView):
(didInitiateLoadForResource):
(didSendRequestForResource):
(didReceiveResponseForResource):
(didFinishLoadForResource):
(didFailLoadForResource):
(ewk_view_resource_load_client_attach):

8:08 PM Changeset in webkit [122410] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

[Mac] Sort project.pbxproj

  • WebCore.xcodeproj/project.pbxproj: Apply Tools/Scripts/sort-Xcode-project-file
7:49 PM Changeset in webkit [122409] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Build fix + remove dead code
https://bugs.webkit.org/show_bug.cgi?id=91039

Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2012-07-11
Reviewed by Filip Pizlo.

An unused variable was breaking compilation (thanks to warnings being treated as errors).

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

7:38 PM Changeset in webkit [122408] by mitz@apple.com
  • 3 edits
    2 adds in trunk

When a table row height grows because of pagination, not all cells’ heights are adjusted
https://bugs.webkit.org/show_bug.cgi?id=91043

Reviewed by Sam Weinig.

Source/WebCore:

The fix for in bug <http://webkit.org/b/83595> in <http://trac.webkit.org/r113738> made table
rows grow as necessary to fit cells that grow as a result of pagination. But it had two bad
side effects: earlier cells on the row would not grow by the same amount, and later cells on
the row would factor the existing growth into their intrinsic padding.

Test: fast/multicol/table-row-height-increase.html

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows): Now when a cell becomes taller than the row height,
the additional height needed is recorded, and the cell is shrunk back to row height. Then
after finishing the row, all cells occurring on the row (including cells spanning it but not
starting on it) are grown by the same amount.

LayoutTests:

  • fast/multicol/table-row-height-increase-expected.html: Added.
  • fast/multicol/table-row-height-increase.html: Added.
7:28 PM Changeset in webkit [122407] by mrowe@apple.com
  • 4 edits in trunk/Source

Fix a logic error in the #if so that the correct code is compiled on Snow Leopard.

I introduced this in r122403 when I inverted the sense of the #if.

Source/WebKit/mac:

  • WebView/WebFullScreenController.mm:

Source/WebKit2:

  • UIProcess/mac/WKFullScreenWindowController.mm:
7:28 PM Changeset in webkit [122406] by ojan@chromium.org
  • 3 edits
    2 deletes in trunk/LayoutTests

Rebaseline after http://trac.webkit.org/changeset/122374.

  • platform/chromium-linux/css3/flexbox/repaint-rtl-column-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/flexbox/repaint-rtl-column-expected.png: Removed.
  • platform/chromium-mac/css3/flexbox/repaint-rtl-column-expected.png:
  • platform/chromium-win/css3/flexbox/repaint-rtl-column-expected.png:
7:03 PM Changeset in webkit [122405] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.
inspector/timeline/timeline-dom-content-loaded-event.html started to fail after r122312.

  • platform/chromium/TestExpectations:
7:01 PM Changeset in webkit [122404] by mrowe@apple.com
  • 18 edits in trunk

<http://webkit.org/b/91024> Build against the latest SDK when targeting older OS X versions.

Reviewed by Dan Bernstein.

The deployment target is already set to the version that we're targeting, and it's that setting
which determines which functionality from the SDK is available to us.

Source/JavaScriptCore:

  • Configurations/Base.xcconfig:

Source/ThirdParty/ANGLE:

  • Configurations/Base.xcconfig:

Source/WebCore:

  • Configurations/Base.xcconfig:

Source/WebKit/mac:

  • Configurations/Base.xcconfig:

Source/WebKit2:

  • Configurations/Base.xcconfig:

Source/WTF:

  • Configurations/Base.xcconfig:

Tools:

  • DumpRenderTree/mac/Configurations/Base.xcconfig:
  • TestWebKitAPI/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/Base.xcconfig:
7:01 PM Changeset in webkit [122403] by mrowe@apple.com
  • 4 edits in trunk/Source

<http://webkit.org/b/91022> WebFullScreenController and WKFullScreenWindowController shouldn't add unprefixed methods to AppKit classes

Reviewed by Dan Bernstein.

Source/WebKit/mac:

  • WebView/WebFullScreenController.mm:

(convertRectToScreen): Add a static helper method that calls through to -[NSWindow convertRectToScreen:] on OS versions where it exists
but otherwise provides a compatibility implementation of it.
(-[WebFullScreenController enterFullScreen:]): Call our new helper.

Source/WebKit2:

  • UIProcess/mac/WKFullScreenWindowController.mm:

(convertRectToScreen): Add a static helper method that calls through to -[NSWindow convertRectToScreen:] on OS versions where it exists
but otherwise provides a compatibility implementation of it.
(-[WKFullScreenWindowController enterFullScreen:]): Call our new helper.

7:00 PM Changeset in webkit [122402] by mrowe@apple.com
  • 5 edits in trunk

Replace definitions of BUILDING_ON / TARGETING macros with macros that will error when used.

Part of <http://webkit.org/b/91015> Remove BUILDING_ON / TARGETING macros in favor of system availability macros.

Reviewed by Anders Carlsson.

Source/WTF:

  • wtf/Platform.h:

Tools:

  • DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Remove the macros completely from here since

they're completely unused in TestNetscapePlugIn.

  • DumpRenderTree/config.h:
7:00 PM Changeset in webkit [122401] by mrowe@apple.com
  • 7 edits in trunk/Source

Switch a few cases that care about the SDK over to checking MAC_OS_X_VERSION_MAX_ALLOWED so that things build.

Part of <http://webkit.org/b/91015> Remove BUILDING_ON / TARGETING macros in favor of system availability macros

Reviewed by Filip Pizlo.

Source/WebCore:

  • platform/graphics/cg/GraphicsContextCG.cpp: The SDK we're building against determines whether the constant is available.
  • platform/mac/EmptyProtocolDefinitions.h: The SDK we're building against determines whether the protocols are declared.
  • platform/mac/NSScrollerImpDetails.h: The SDK we're building against determines whether the constants and method are

available.

  • platform/mac/SharedTimerMac.mm: The SDK we're building against determines whether the function has already been declared.

Source/WTF:

  • wtf/FastMalloc.cpp:

(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary): The SDK we're building against determines how many elements
the structure is declared as having.

7:00 PM Changeset in webkit [122400] by mrowe@apple.com
  • 158 edits in trunk

<http://webkit.org/b/91015> Remove BUILDING_ON / TARGETING macros in favor of system availability macros

This removal was handled by a script that translates the relevant macros in to the equivalent checks
using the system availability macros.

Reviewed by Filip Pizlo.

Source/WebCore:

  • WebCore.exp.in:
  • accessibility/AccessibilityList.h:
  • accessibility/AccessibilityTable.h:
  • accessibility/mac/AXObjectCacheMac.mm:
  • editing/mac/EditorMac.mm:
  • loader/MainResourceLoader.cpp:
  • loader/MainResourceLoader.h:
  • page/AlternativeTextClient.h:
  • page/ContextMenuController.cpp:
  • page/mac/SettingsMac.mm:
  • platform/LocalizedStrings.cpp:
  • platform/MemoryPressureHandler.cpp:
  • platform/audio/mac/AudioBusMac.mm:
  • platform/graphics/Gradient.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
  • platform/graphics/ca/GraphicsLayerCA.cpp:
  • platform/graphics/ca/PlatformCALayer.h:
  • platform/graphics/ca/mac/PlatformCALayerMac.mm:
  • platform/graphics/ca/mac/TileCache.mm:
  • platform/graphics/cg/GraphicsContextCG.cpp:
  • platform/graphics/cg/ImageBufferCG.cpp:
  • platform/graphics/cg/ImageBufferDataCG.cpp:
  • platform/graphics/cg/ImageBufferDataCG.h:
  • platform/graphics/cg/ImageCG.cpp:
  • platform/graphics/cg/ImageSourceCG.cpp:
  • platform/graphics/cg/PathCG.cpp:
  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
  • platform/graphics/mac/ComplexTextController.cpp:
  • platform/graphics/mac/ComplexTextControllerCoreText.mm:
  • platform/graphics/mac/FontCacheMac.mm:
  • platform/graphics/mac/FontCustomPlatformData.cpp:
  • platform/graphics/mac/FontMac.mm:
  • platform/graphics/mac/GraphicsContextMac.mm:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  • platform/graphics/mac/SimpleFontDataMac.mm:
  • platform/graphics/mac/WebLayer.h:
  • platform/graphics/mac/WebLayer.mm:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
  • platform/mac/CursorMac.mm:
  • platform/mac/DisplaySleepDisabler.cpp:
  • platform/mac/DisplaySleepDisabler.h:
  • platform/mac/EmptyProtocolDefinitions.h:
  • platform/mac/HTMLConverter.h:
  • platform/mac/HTMLConverter.mm:
  • platform/mac/MemoryPressureHandlerMac.mm:
  • platform/mac/NSScrollerImpDetails.h:
  • platform/mac/PlatformEventFactoryMac.mm:
  • platform/mac/PopupMenuMac.mm:
  • platform/mac/ScrollAnimatorMac.mm:
  • platform/mac/ScrollElasticityController.mm:
  • platform/mac/SharedTimerMac.mm:
  • platform/mac/SuddenTermination.mm:
  • platform/mac/WebCoreFullScreenWindow.mm:
  • platform/mac/WebCoreNSCellExtras.h:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
  • platform/mac/WebFontCache.mm:
  • platform/mac/WebVideoFullscreenController.mm:
  • platform/mac/WebVideoFullscreenHUDWindowController.mm:
  • platform/network/Credential.h:
  • platform/network/ResourceHandle.h:
  • platform/network/cf/DNSCFNet.cpp:
  • platform/network/cf/ProxyServerCFNet.cpp:
  • platform/network/cf/ResourceRequest.h:
  • platform/network/cf/ResourceRequestCFNet.cpp:
  • platform/network/cf/SocketStreamHandleCFNet.cpp:
  • platform/network/mac/AuthenticationMac.mm:
  • platform/network/mac/CookieStorageMac.mm:
  • platform/network/mac/ResourceHandleMac.mm:
  • platform/network/mac/ResourceRequestMac.mm:
  • platform/network/mac/WebCoreURLResponse.mm:
  • platform/text/TextChecking.h:
  • platform/text/cf/HyphenationCF.cpp:
  • platform/text/mac/HyphenationMac.mm:
  • rendering/RenderLayerBacking.cpp:
  • rendering/RenderLayerCompositor.cpp:
  • rendering/RenderThemeMac.mm:

Source/WebKit/chromium:

  • src/mac/WebInputEventFactory.mm:

Source/WebKit/mac:

  • DefaultDelegates/WebDefaultContextMenuDelegate.mm:
  • Misc/WebKitErrors.m:
  • Misc/WebNSControlExtras.m:
  • Misc/WebNSFileManagerExtras.mm:
  • Plugins/Hosted/WebHostedNetscapePluginView.mm:
  • Plugins/WebBaseNetscapePluginView.mm:
  • Plugins/WebNetscapePluginView.mm:
  • WebCoreSupport/WebChromeClient.mm:
  • WebCoreSupport/WebEditorClient.mm:
  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebCoreSupport/WebSystemInterface.mm:
  • WebView/WebClipView.mm:
  • WebView/WebDynamicScrollBarsView.mm:
  • WebView/WebFrameView.mm:
  • WebView/WebFullScreenController.mm:
  • WebView/WebHTMLView.mm:
  • WebView/WebHTMLViewInternal.h:
  • WebView/WebPDFDocumentExtras.mm:
  • WebView/WebPreferences.mm:
  • WebView/WebResourceInternal.h:
  • WebView/WebScriptDebugDelegate.h:
  • WebView/WebView.mm:
  • WebView/WebViewPrivate.h:

Source/WebKit2:

  • Shared/DictionaryPopupInfo.cpp:
  • Shared/DictionaryPopupInfo.h:
  • Shared/mac/PasteboardTypes.mm:
  • Shared/mac/WebEventFactory.mm:
  • UIProcess/API/mac/PDFViewController.mm:
  • UIProcess/API/mac/PageClientImpl.mm:
  • UIProcess/API/mac/WKView.mm:
  • UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h:
  • UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm:
  • UIProcess/Launcher/mac/EnvironmentVariables.cpp:
  • UIProcess/Launcher/mac/EnvironmentVariables.h:
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:
  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/mac/TextCheckerMac.mm:
  • UIProcess/mac/WKFullScreenWindowController.mm:
  • UIProcess/mac/WebContextMac.mm:
  • UIProcess/mac/WebPageProxyMac.mm:
  • WebKit2Prefix.h:
  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
  • WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:
  • WebProcess/WebCoreSupport/WebEditorClient.h:
  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/mac/WebPageMac.mm:
  • WebProcess/com.apple.WebProcess.sb.in:
  • WebProcess/mac/KeychainItemShimMethods.mm:
  • WebProcess/mac/SecItemShimMethods.mm:
  • WebProcess/mac/WebProcessMac.mm:
  • WebProcess/mac/WebProcessMainMac.mm:
  • WebProcess/mac/WebProcessShim.mm:

Source/WTF:

  • wtf/Assertions.cpp:
  • wtf/FastMalloc.cpp:
  • wtf/Platform.h:
  • wtf/ThreadingPthreads.cpp:
  • wtf/unicode/icu/CollatorICU.cpp:

Tools:

  • DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
  • DumpRenderTree/mac/CheckedMalloc.cpp:
  • DumpRenderTree/mac/DumpRenderTree.mm:
  • DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:
  • DumpRenderTree/mac/TextInputController.m:
  • TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
  • WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
  • WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
6:29 PM Changeset in webkit [122399] by rjkroege@chromium.org
  • 8 edits
    5 adds in trunk

Suppress horizontal conversion of PlatformWheelEvents when hasPreciseScrollingDeltas is true
https://bugs.webkit.org/show_bug.cgi?id=89580

Source/WebCore:

WebKit GTK and Chromium Linux force vertical wheel events to
scroll horizontally when over horizontal scroll bars. This is
undesirable for touchpad scrolling with
hasPreciseScrollingDeltas() == true. Modified shouldTurnVerticalTicksIntoHorizontal
to not perform this conversion for PlatformWheelEvents with preciseScrollingDeltas.

Reviewed by Adam Barth.

Tests: fast/events/touch/gesture/touch-gesture-scroll-sideways.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::shouldTurnVerticalTicksIntoHorizontal):
(WebCore::EventHandler::handleWheelEvent):

  • page/EventHandler.h:

(EventHandler):

  • page/chromium/EventHandlerChromium.cpp:

(WebCore::EventHandler::shouldTurnVerticalTicksIntoHorizontal):

  • page/gtk/EventHandlerGtk.cpp:

(WebCore::EventHandler::shouldTurnVerticalTicksIntoHorizontal):

Tools:

WebKit GTK and Chromium Linux force vertical wheel events to
scroll horizontally when over horizontal scroll bars. This is
undesirable for touchpad scrolling with
hasPreciseScrollingDeltas() == true. Modified DumpRenderTree to
let a layout test specify this attribute so that the change's impact
on scrolling can be tested in a layout test.

Reviewed by Adam Barth.

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::handleMouseWheel):

LayoutTests:

WebKit GTK and Chromium Linux force vertical wheel events to
scroll horizontally when over horizontal scroll bars. This is
undesirable for touchpad scrolling with
hasPreciseScrollingDeltas() == true. Added a layout test showing
that change correctly suppresses this behaviour.

Reviewed by Adam Barth.

  • fast/events/touch/gesture/touch-gesture-scroll-sideways-expected.txt: Added.
  • fast/events/touch/gesture/touch-gesture-scroll-sideways.html: Added.
  • platform/chromium-linux/fast/events/touch/gesture/touch-gesture-scroll-sideways-expected.txt: Added. Note: test has intentional platform difference.
6:24 PM Changeset in webkit [122398] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-11

  • DEPS:
6:22 PM Changeset in webkit [122397] by Simon Fraser
  • 2 edits in trunk/Tools

Fix the build by declaring -isPaginated before use.

  • MiniBrowser/mac/BrowserWindowController.m:
6:16 PM Changeset in webkit [122396] by hayato@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed gardening.
Build fix for r122373.

  • platform/chromium/support/WebCompositorSharedQuadState.cpp:

(WebKit::WebCompositorSharedQuadState::WebCompositorSharedQuadState):

5:54 PM Changeset in webkit [122395] by commit-queue@webkit.org
  • 6 edits in trunk

Unreviewed, rolling out r122358.
http://trac.webkit.org/changeset/122358
https://bugs.webkit.org/show_bug.cgi?id=91037

Build break on WebKit Win (Requested by hayato on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-11

Source/WebKit/chromium:

  • public/WebView.h:

(WebView):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::dragTargetDragEnter):
(WebKit):
(WebKit::WebViewImpl::dragTargetDragOver):
(WebKit::WebViewImpl::dragTargetDrop):

  • src/WebViewImpl.h:

(WebViewImpl):

Tools:

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::doDragDrop):
(EventSender::doMouseUp):
(EventSender::doMouseMove):
(EventSender::beginDragWithFiles):

5:45 PM Changeset in webkit [122394] by dpranke@chromium.org
  • 4 edits in trunk/Tools

nrwt: add a MessagePool abstraction that the manager will call to replace the broker
https://bugs.webkit.org/show_bug.cgi?id=90511

Reviewed by Ojan Vafai.

This change introduces the new MessagePool abstraction that will
replace the classes in manager_worker_broker. It is a minimal
interface that tries to follow the conventions in
multiprocessing.Pool and concurrency.futures ... it provides a
context manager and a run() method that sends N messages to M
workers processes (starting workers as necessary) and waits for
them all to complete, handling cleanup as necessary. The caller
is responsible for providing a handle() method to handle
messages received from the workers.

This interface basically hides all of the multiprocessing logic from
the manager class.

The initial implementation of MessagePool is a simple shim
around the existing broker classes; a subsequent change will
replace all the other classes with a much simpler
implementation.

No additional tests are provided for now; existing tests should
provide adequate coverage, and I will add new unit tests for the
MessagePool class when I replace the existing implementation.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(TestRunInterruptedException.reduce):
(Manager.init):
(Manager._run_tests):
(Manager._run_tests.instead):
(Manager.handle):
(Manager._handle_started_test):
(Manager._handle_finished_test_list):
(Manager._handle_finished_test):

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:

(get):
(_MessagePool):
(_MessagePool.init):
(_MessagePool.enter):
(_MessagePool.exit):
(_MessagePool.run):
(_MessagePool.wait):
(_MessagePool.is_done):
(_MessagePool._worker_is_done):
(_MessagePool._close):
(_MessagePool.handle_done):
(_MessagePool.handle_started_test):
(_MessagePool.handle_finished_test):
(_MessagePool.handle_finished_test_list):
(_MessagePool.handle_exception):
(_MessagePool._log_messages):
(_MessagePool._handle_worker_exception):
(_WorkerState):
(_WorkerState.for):
(_WorkerState.init):
(_WorkerState.repr):
(_get_broker):

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:

(make_broker):

5:23 PM Changeset in webkit [122393] by Simon Fraser
  • 2 edits in trunk/Source/WebKit2

pagesPerView param is misnamed for WKPageSetPageLength()
https://bugs.webkit.org/show_bug.cgi?id=91033

Rubber-stamped by Dan Bernstein.

The name of the second parameter to WKPageSetPageLength(),
'pagesPerView', was confusing; it's a page size (normally width)
in pixels.

  • UIProcess/API/C/WKPagePrivate.h:
5:12 PM Changeset in webkit [122392] by fpizlo@apple.com
  • 21 edits in trunk

DFG should have fast virtual calls
https://bugs.webkit.org/show_bug.cgi?id=90924

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

Implements virtual call support in the style of the old JIT, with the
caveat that we still use the same slow path for both InternalFunction
calls and JSFunction calls. Also rationalized the way that our
CodeOrigin indices tie into exception checks (previously it was a
strange one-to-one mapping with fairly limited assertions; now it's a
one-to-many mapping for CodeOrigins to exception checks, respectively).
I also took the opportunity to clean up
CallLinkInfo::callReturnLocation, which previously was either a Call or
a NearCall. Now it's just a NearCall. As well, exceptions during slow
path call resolution are now handled by returning an exception throwing
thunk rather than returning null. And finally, I made a few things
public that were previously private-with-lots-of-friends, because I
truly despise the thought of listing each thunk generating function as
a friend of JSValue and friends.

  • bytecode/CallLinkInfo.cpp:

(JSC::CallLinkInfo::unlink):

  • bytecode/CallLinkInfo.h:

(CallLinkInfo):

  • bytecode/CodeOrigin.h:

(JSC::CodeOrigin::CodeOrigin):
(JSC::CodeOrigin::isSet):

  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::AssemblyHelpers):

  • dfg/DFGCCallHelpers.h:

(JSC::DFG::CCallHelpers::CCallHelpers):

  • dfg/DFGGPRInfo.h:

(GPRInfo):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compileFunction):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::CallBeginToken::CallBeginToken):
(JSC::DFG::CallBeginToken::~CallBeginToken):
(CallBeginToken):
(JSC::DFG::CallBeginToken::set):
(JSC::DFG::CallBeginToken::registerWithExceptionCheck):
(JSC::DFG::CallBeginToken::codeOrigin):
(JSC::DFG::CallExceptionRecord::CallExceptionRecord):
(CallExceptionRecord):
(JSC::DFG::JITCompiler::currentCodeOriginIndex):
(JITCompiler):
(JSC::DFG::JITCompiler::beginCall):
(JSC::DFG::JITCompiler::notifyCall):
(JSC::DFG::JITCompiler::prepareForExceptionCheck):
(JSC::DFG::JITCompiler::addExceptionCheck):
(JSC::DFG::JITCompiler::addFastExceptionCheck):

  • dfg/DFGOperations.cpp:
  • dfg/DFGRepatch.cpp:

(JSC::DFG::dfgLinkFor):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheck):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

  • dfg/DFGThunks.cpp:

(JSC::DFG::emitPointerValidation):
(DFG):
(JSC::DFG::throwExceptionFromCallSlowPathGenerator):
(JSC::DFG::slowPathFor):
(JSC::DFG::linkForThunkGenerator):
(JSC::DFG::linkCallThunkGenerator):
(JSC::DFG::linkConstructThunkGenerator):
(JSC::DFG::virtualForThunkGenerator):
(JSC::DFG::virtualCallThunkGenerator):
(JSC::DFG::virtualConstructThunkGenerator):

  • dfg/DFGThunks.h:

(DFG):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):
(JSC::JIT::linkFor):

  • runtime/Executable.h:

(ExecutableBase):
(JSC::ExecutableBase::offsetOfJITCodeFor):
(JSC::ExecutableBase::offsetOfNumParametersFor):

  • runtime/JSValue.h:

(JSValue):

LayoutTests:

Rubber stamped by Oliver Hunt.

This changes which piece of code appears on top of the stack at the point of a stack
overflow. As far as Oliver and I can tell, it doesn't matter, so I just rebased the
test.

  • fast/js/stack-trace-expected.txt:
5:10 PM Changeset in webkit [122391] by Simon Fraser
  • 4 edits in trunk/Tools

Add an option to enter paginated mode in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=91035

Reviewed by Dan Bernstein.

Add an item to the Debug menu for MiniBrowser that puts
the web view into paginated mode. For now, we only
do left-to-right pagination, with a fixed column width.

  • MiniBrowser/mac/BrowserWindowController.h:
  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController validateMenuItem:]): Update the checked
state of the menu item.
(-[BrowserWindowController isPaginated]): Return YES if paginated.
(-[BrowserWindowController togglePaginationMode:]): Toggle in
and out of pagination mode.

  • MiniBrowser/mac/MainMenu.xib: Add the debug menu item.
5:09 PM Changeset in webkit [122390] by abarth@webkit.org
  • 2 edits in trunk/Tools

commit-queue instances on Compute Engine are missing git-svn
https://bugs.webkit.org/show_bug.cgi?id=91034

Reviewed by Eric Seidel.

git-svn is needed to actually commit to SVN from a git working copy.

  • EWSTools/cold-boot.sh:
5:05 PM Changeset in webkit [122389] by shinyak@chromium.org
  • 3 edits in trunk/Source/WebCore

SVGUseElement should not use Element::ensureShadowRoot().
https://bugs.webkit.org/show_bug.cgi?id=90938

Reviewed by Hajime Morita.

We would like to remove Element::ensureShadowRoot() because we would like to stabilize the lifecycle of Shadow DOM.
This patch rewrites SVGUseElement::create() not to use Element::ensureShadowRoot(). Since our convention to create
a shadow subtree is to create a method createShadowSubtree(), I obeyed it.

No new tests. Simple refactoring.

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::create):
(WebCore::SVGUseElement::createShadowSubtree):
(WebCore):

  • svg/SVGUseElement.h:

(SVGUseElement):

4:33 PM Changeset in webkit [122388] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Accidentally used the wrong license (3-clause instead of 2-clause) in some
files I just committed.

Rubber stamped by Oliver Hunt.

  • bytecode/Watchpoint.cpp:
  • bytecode/Watchpoint.h:
  • jit/JumpReplacementWatchpoint.cpp:
  • jit/JumpReplacementWatchpoint.h:
4:17 PM Changeset in webkit [122387] by dpranke@chromium.org
  • 9 edits in trunk/Tools

webkitpy: lint code in webkitpy.layout_tests.models
https://bugs.webkit.org/show_bug.cgi?id=90416

Reviewed by Ojan Vafai.

Cleaning up errors reported from lint-webkitpy.

Also, suppress the warnings about wildcard imports in pylintrc;
we have nothing particularly against them.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py:

(TestConfigurationConverter.combinations):

  • Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:

(TestConfigurationTest.test_hash.query_unknown_key):
(TestConfigurationTest.test_eq):

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(ParseError.init):
(TestExpectationLine.init):
(TestExpectationsModel.get_expectations_string):
(TestExpectationsModel):
(TestExpectationsModel.expectation_to_string):
(TestExpectationsModel.add_expectation_line):
(TestExpectationsModel._clear_expectations_for_test):
(TestExpectationsModel._remove_from_sets):
(TestExpectations.get_expectations_string):
(TestExpectations.expectation_to_string):
(TestExpectations._report_warnings):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(Base.init):
(parse_exp):
(SkippedTests.check):
(TestExpectationParserTests.test_parse_empty_string):

  • Scripts/webkitpy/layout_tests/models/test_failures.py:

(FailureTimeout.init):
(FailureCrash.init):
(FailureImageHashMismatch.init):
(FailureReftestMismatch.init):
(FailureReftestMismatchDidNotOccur.init):
(FailureReftestNoImagesGenerated.init):

  • Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:

(TestFailuresTest.test_unknown_failure_type.UnknownFailure.message):
(TestFailuresTest.test_unknown_failure_type):
(TestFailuresTest):
(TestFailuresTest.test_message_is_virtual):

  • Scripts/webkitpy/layout_tests/models/test_results.py:

(TestResult.loads):
(TestResult.has_failure_matching_types):

  • Scripts/webkitpy/pylintrc:
4:15 PM Changeset in webkit [122386] by abarth@webkit.org
  • 1 edit
    3 deletes in trunk/LayoutTests

Unreviewed. Remove empty directories.

  • http/tests/websocket/tests/resources: Removed.
  • http/tests/websocket/tests/script-tests: Removed.
  • http/tests/websocket/tests/workers: Removed.
  • http/tests/websocket/tests/workers/resources: Removed.
4:12 PM Changeset in webkit [122385] by fpizlo@apple.com
  • 11 edits
    2 adds in trunk/Source/JavaScriptCore

Watchpoints and jump replacement should be decoupled
https://bugs.webkit.org/show_bug.cgi?id=91016

Reviewed by Oliver Hunt.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • assembler/AbstractMacroAssembler.h:

(JSC):
(Label):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::appendWatchpoint):
(JSC::CodeBlock::watchpoint):
(DFGData):

  • bytecode/Watchpoint.cpp:

(JSC):

  • bytecode/Watchpoint.h:

(JSC::Watchpoint::Watchpoint):
(Watchpoint):
(JSC::Watchpoint::fire):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::speculationWatchpoint):

  • jit/JumpReplacementWatchpoint.cpp: Added.

(JSC):
(JSC::JumpReplacementWatchpoint::correctLabels):
(JSC::JumpReplacementWatchpoint::fireInternal):

  • jit/JumpReplacementWatchpoint.h: Added.

(JSC):
(JumpReplacementWatchpoint):
(JSC::JumpReplacementWatchpoint::JumpReplacementWatchpoint):
(JSC::JumpReplacementWatchpoint::setDestination):

4:11 PM Changeset in webkit [122384] by dpranke@chromium.org
  • 5 edits in trunk/Tools

nrwt: clean up names in worker.py
https://bugs.webkit.org/show_bug.cgi?id=90510

Reviewed by Ojan Vafai.

This is the last patch in the series of refactoring worker.py;
all this does is change some names of methods, instance
variables, and method parameters to be clearer (it also changes
some code in manager.py and manager_worker.py to be consistent).

There are no functional changes in this patch and the existing
tests should cover everything.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.init):
(Manager.prepare_lists_and_print_output):
(Manager._run_tests.worker_factory):
(Manager._run_tests):
(Manager._show_results_html_file):
(Manager.handle_finished_test_list):
(_WorkerState.init):

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:

(_Broker.post_message):
(_Broker._dispatch_message):
(AbstractWorker.init):
(AbstractWorker.run):
(AbstractWorker.yield_to_caller):
(AbstractWorker.post):
(_WorkerConnection.init):

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:

(_TestWorker.init):
(_TestWorker.start):
(_TestWorker.handle):
(_TestWorker.stop):
(_TestsMixin):
(_TestsMixin.test_name):

  • Scripts/webkitpy/layout_tests/controllers/worker.py:

(Worker.init):
(Worker.del):
(Worker.start):
(Worker.handle):
(Worker._run_test):
(Worker.stop):
(Worker._timeout):
(Worker._kill_driver):
(Worker._run_test_with_timeout):
(Worker._clean_up_after_test):
(Worker._run_test_in_another_thread.SingleTestThread.run):
(Worker._run_test_in_this_thread):
(Worker._run_single_test):

4:06 PM Changeset in webkit [122383] by commit-queue@webkit.org
  • 27 edits
    9 copies
    8 moves
    1 add
    1 delete in trunk/Source

[chromium] Move compositor quads to Platform/chromium/public
https://bugs.webkit.org/show_bug.cgi?id=90582

Patch by Alexandre Elias <aelias@google.com> on 2012-07-11
Reviewed by Adrienne Walker.

This moves CCSharedQuadState, CCDrawQuad, and all but two CC*DrawQuad
classes to the WebKit namespace, as a first step to pushing them
across the process boundary for the ubercompositor.

  • The intent is to serialize the class hierarchy using the same

mechanism as WebInputEvent. In order to do this, there are three
requirements: pure POD data, a method returning size, and a packing
pragma.

  • Private data members are fine with this kind of serializer, and a

default constructor is not needed. Because of that, we can maintain
the same encapsulation and convenient APIs (behind
WEBKIT_IMPLEMENTATION) as the original classes. To ease the
transition, the original WebCore headers still exist and typedef to
the new classes.

  • However, SharedQuadState will be serialized using the normal

IPC_STRUCT_TRAITS macro, so I made its members public. A custom
serializer (on quad lists) will maintain the pointers from quads to
SharedQuadStates.

  • I converted the Material casting mechanism to materialCast() methods

living in the derived classes. That way, the WebCompositorQuad header
doesn't need to know about all its derived classes.

  • Quad classes not yet transitioned can still be used in

non-ubercompositor mode. CCRenderPassDrawQuad and CCYUVVideoDrawQuad
are currently non-POD and I left them in their original files.

This approach is the best I've found so far, since it preserves all
WebCore-facing APIs and avoids unnecessary code duplication (new quad
types or members can be added by modifying only one place). There
also should not be an unreasonable amount of custom serializer code
required.

Source/Platform:

  • Platform.gypi:
  • chromium/public/WebCompositorQuad.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCDrawQuad.h.

(WebKit):
(WebCompositorQuad):
(WebKit::WebCompositorQuad::quadRect):
(WebKit::WebCompositorQuad::quadTransform):
(WebKit::WebCompositorQuad::layerTransform):
(WebKit::WebCompositorQuad::layerRect):
(WebKit::WebCompositorQuad::scissorRect):
(WebKit::WebCompositorQuad::opacity):
(WebKit::WebCompositorQuad::needsBlending):
(WebKit::WebCompositorQuad::isLayerAxisAlignedIntRect):
(WebKit::WebCompositorQuad::quadVisibleRect):
(WebKit::WebCompositorQuad::isDebugQuad):
(WebKit::WebCompositorQuad::material):
(WebKit::WebCompositorQuad::sharedQuadState):
(WebKit::WebCompositorQuad::setSharedQuadState):

  • chromium/public/WebCompositorSharedQuadState.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCSolidColorDrawQuad.h.

(WebKit):
(WebCompositorSharedQuadState):

  • chromium/public/WebCompositorSolidColorQuad.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCSolidColorDrawQuad.h.

(WebKit):
(WebCompositorSolidColorQuad):
(WebKit::WebCompositorSolidColorQuad::color):

  • chromium/public/WebCompositorTextureQuad.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCTextureDrawQuad.h.

(WebKit):
(WebCompositorTextureQuad):
(WebKit::WebCompositorTextureQuad::uvRect):
(WebKit::WebCompositorTextureQuad::textureId):
(WebKit::WebCompositorTextureQuad::premultipliedAlpha):
(WebKit::WebCompositorTextureQuad::flipped):

Source/WebCore:

No new tests. (No-op refactoring.)

  • WebCore.gypi:
  • platform/chromium/support/WebCompositorQuad.cpp: Added.

(WebKit):
(WebKit::WebCompositorQuad::WebCompositorQuad):
(WebKit::WebCompositorQuad::opaqueRect):
(WebKit::WebCompositorQuad::setQuadVisibleRect):
(WebKit::WebCompositorQuad::size):

  • platform/chromium/support/WebCompositorSharedQuadState.cpp: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCSharedQuadState.cpp.

(WebKit):
(WebKit::WebCompositorSharedQuadState::WebCompositorSharedQuadState):
(WebKit::WebCompositorSharedQuadState::create):
(WebKit::WebCompositorSharedQuadState::isLayerAxisAlignedIntRect):

  • platform/chromium/support/WebCompositorSolidColorQuad.cpp: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCSolidColorDrawQuad.cpp.

(WebKit):
(WebKit::WebCompositorSolidColorQuad::create):
(WebKit::WebCompositorSolidColorQuad::WebCompositorSolidColorQuad):
(WebKit::WebCompositorSolidColorQuad::materialCast):

  • platform/chromium/support/WebCompositorTextureQuad.cpp: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCTextureDrawQuad.cpp.

(WebKit):
(WebKit::WebCompositorTextureQuad::create):
(WebKit::WebCompositorTextureQuad::WebCompositorTextureQuad):
(WebKit::WebCompositorTextureQuad::setNeedsBlending):
(WebKit::WebCompositorTextureQuad::materialCast):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawQuad):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCCheckerboardDrawQuad.cpp:

(WebCore::CCCheckerboardDrawQuad::create):
(WebCore::CCCheckerboardDrawQuad::CCCheckerboardDrawQuad):
(WebCore::CCCheckerboardDrawQuad::materialCast):
(WebCore):

  • platform/graphics/chromium/cc/CCCheckerboardDrawQuad.h:

(CCCheckerboardDrawQuad):

  • platform/graphics/chromium/cc/CCDebugBorderDrawQuad.cpp:

(WebCore::CCDebugBorderDrawQuad::create):
(WebCore::CCDebugBorderDrawQuad::CCDebugBorderDrawQuad):
(WebCore::CCDebugBorderDrawQuad::materialCast):
(WebCore):

  • platform/graphics/chromium/cc/CCDebugBorderDrawQuad.h:

(CCDebugBorderDrawQuad):

  • platform/graphics/chromium/cc/CCDrawQuad.cpp: Removed.
  • platform/graphics/chromium/cc/CCDrawQuad.h:

(WebCore):

  • platform/graphics/chromium/cc/CCIOSurfaceDrawQuad.cpp:

(WebCore::CCIOSurfaceDrawQuad::create):
(WebCore::CCIOSurfaceDrawQuad::CCIOSurfaceDrawQuad):
(WebCore::CCIOSurfaceDrawQuad::materialCast):
(WebCore):

  • platform/graphics/chromium/cc/CCIOSurfaceDrawQuad.h:

(CCIOSurfaceDrawQuad):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(WebCore):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:

(WebCore::CCRenderPassDrawQuad::create):
(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):
(WebCore::CCRenderPassDrawQuad::materialCast):
(WebCore):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:

(CCRenderPassDrawQuad):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore):

  • platform/graphics/chromium/cc/CCSharedQuadState.h:

(WebCore):

  • platform/graphics/chromium/cc/CCSolidColorDrawQuad.h:

(WebCore):

  • platform/graphics/chromium/cc/CCStreamVideoDrawQuad.cpp:

(WebCore::CCStreamVideoDrawQuad::create):
(WebCore::CCStreamVideoDrawQuad::CCStreamVideoDrawQuad):
(WebCore::CCStreamVideoDrawQuad::materialCast):
(WebCore):

  • platform/graphics/chromium/cc/CCStreamVideoDrawQuad.h:

(CCStreamVideoDrawQuad):

  • platform/graphics/chromium/cc/CCTextureDrawQuad.h:

(WebCore):

  • platform/graphics/chromium/cc/CCTileDrawQuad.cpp:

(WebCore::CCTileDrawQuad::create):
(WebCore::CCTileDrawQuad::CCTileDrawQuad):
(WebCore::CCTileDrawQuad::materialCast):
(WebCore):

  • platform/graphics/chromium/cc/CCTileDrawQuad.h:

(CCTileDrawQuad):

  • platform/graphics/chromium/cc/CCYUVVideoDrawQuad.cpp:

(WebCore::CCYUVVideoDrawQuad::create):
(WebCore::CCYUVVideoDrawQuad::CCYUVVideoDrawQuad):
(WebCore::CCYUVVideoDrawQuad::materialCast):
(WebCore):

  • platform/graphics/chromium/cc/CCYUVVideoDrawQuad.h:

(CCYUVVideoDrawQuad):

Source/WebKit/chromium:

  • tests/CCLayerTestCommon.cpp:

(CCLayerTestCommon::verifyQuadsExactlyCoverRect):

  • tests/CCSolidColorLayerImplTest.cpp:

(CCLayerTestCommon::TEST):

4:01 PM Changeset in webkit [122382] by rjkroege@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] [regression] Don't use ScrollByPrecisePixels on Chromium Mac.
https://bugs.webkit.org/show_bug.cgi?id=91020

Reviewed by Adam Barth.

A change in https://bugs.webkit.org/show_bug.cgi?id=87535 to
improve the operation of smooth scrolling incorrectly caused
Chromium Mac to use the wrong scroll granularity on
hasPreciseScrollingDeltas() == true wheelevent scrolls.
Exclude the change on the Chromium Mac platform.

  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::handleWheelEvent): Adjusted #ifdef to exclude Chromium
Mac from ScrollByPrecisePixels change.

3:54 PM Changeset in webkit [122381] by abarth@webkit.org
  • 2 edits in trunk/Tools

The commit-queue needs some extra git config to be able to commit
https://bugs.webkit.org/show_bug.cgi?id=91025

Reviewed by Eric Seidel.

In order for the commit-queue to actually commit, it needs to know the
location of the SVN server.

  • EWSTools/cold-boot.sh:
3:48 PM Changeset in webkit [122380] by jpu@apple.com
  • 2 edits in trunk/Source/WebCore

On Mac, autocorrection sometimes fails to take place in Safari.
https://bugs.webkit.org/show_bug.cgi?id=89982

Reviewed by Ryosuke Niwa.

We should check the value of shouldCheckForCorrection, not shouldShowCorrectionPanel, to determine if we should
early return in markAndReplaceFor(). Also, since we don't want autocorrection to happen when we only change selection,
not the content, so we shouldn't set TextCheckingTypeCorrection flag in markMisspellingsAndBadGrammar() as this function
is triggered only by selection change.

  • editing/Editor.cpp:

(WebCore::Editor::markAndReplaceFor):
(WebCore::Editor::markMisspellingsAndBadGrammar):

3:42 PM Changeset in webkit [122379] by scherkus@chromium.org
  • 3 edits in branches/chromium/1180/Source/WebCore

Merging r120939 and r121043 to 1180 branch (Chrome video controls visual update).

BUG=134726
TEST=none

3:41 PM Changeset in webkit [122378] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r122361.
http://trac.webkit.org/changeset/122361
https://bugs.webkit.org/show_bug.cgi?id=91027

Broke Windows build and fast/forms/state-restore-broken-
state.html (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-11

  • testing/Internals.idl:
3:38 PM Changeset in webkit [122377] by abarth@webkit.org
  • 1 edit
    1 add in trunk/Tools

Teach EWSTools how to configure SVN auth credentials
https://bugs.webkit.org/show_bug.cgi?id=91021

Reviewed by Eric Seidel.

To move the commit-queue over to Google Compute Engine, we need a way
to configure the commit-queue's credentials during the machine build
process. There doesn't seem to be a nice command line way of
configuring SVN auth credentials. I tried doing a bogus commit and
supplying the credentials that way, but that's super hacky.

The approach in this patch is to write the config file directly. The
format of these configurations files is documented in the SVN book, so
this approach doesn't see too sketchy.

  • EWSTools/configure-svn-auth.sh: Added.
3:26 PM Changeset in webkit [122376] by Simon Fraser
  • 3 edits
    3 adds in trunk

Assertion ASSERTION FAILED: enclosingIntRect(rendererMappedResult) == enclosingIntRect(FloatQuad(result).boundingBox()) when compositing in paginated mode
https://bugs.webkit.org/show_bug.cgi?id=90919

Reviewed by Antti Koivisto.

Source/WebCore:

r121124 added a fast path for geometry mapping that goes via layers
when possible. However, this broke paginated pages, which put
the root (RenderView) layer into column mode, because it failed
to check for columns on the ancestor layer.

Rather than make a risky change to convertToLayerCoords(), add a local
function canMapViaLayer(), which is like RenderLayer::canUseConvertToLayerCoords(),
but doesn't check for compositing (compositing itself is not a reason
to avoid convertToLayerCoords). Call canMapViaLayer() with the ancestorLayer
to check whether the ancestor has columns, which fixes the bug.

Test: compositing/columns/geometry-map-paginated-assert.html

  • rendering/RenderGeometryMap.cpp:

(WebCore::canMapViaLayer):
(WebCore::RenderGeometryMap::pushMappingsToAncestor):

LayoutTests:

Test with a composited element in a document which is put into paginated mode.

  • compositing/columns/geometry-map-paginated-assert-expected.txt: Added.
  • compositing/columns/geometry-map-paginated-assert.html: Added.
3:12 PM Changeset in webkit [122375] by ojan@chromium.org
  • 3 edits in trunk/Tools

Dedupe suffixes passed to webkit-patch rebaseline
https://bugs.webkit.org/show_bug.cgi?id=91017

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(Rebaseline._suffixes_to_update):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(test_rebaseline_multiple_builders_and_tests_command_line):

2:52 PM Changeset in webkit [122374] by ojan@chromium.org
  • 4 edits in trunk/LayoutTests

Simplify css3/flexbox/repaint-rtl-column.html
https://bugs.webkit.org/show_bug.cgi?id=91011

Reviewed by Tony Chang.

This test was doing something simple in a complicated way. Also, removing
the text should make it so that more ports can fallback to the same png.

  • css3/flexbox/repaint-rtl-column-expected.txt:
  • css3/flexbox/repaint-rtl-column.html:
  • platform/chromium-linux/css3/flexbox/repaint-rtl-column-expected.png:
2:38 PM Changeset in webkit [122373] by danakj@chromium.org
  • 36 edits in trunk/Source

[chromium] Rename layerRect to contentRect for rects that live in content space
https://bugs.webkit.org/show_bug.cgi?id=90843

Reviewed by Adrienne Walker.

Source/WebCore:

Dropped the layerTransform() from CCSharedQuadState, as nothing should be
using it to draw with. RenderPasses need a weird drawTransform right now
which was stored in layerTransform, so moved this to the RenderPass quad.

No new tests. No change in behaviour.

  • platform/graphics/chromium/CanvasLayerTextureUpdater.cpp:

(WebCore::CanvasLayerTextureUpdater::paintContents):

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::update):
(WebCore::ContentLayerChromium::needMoreUpdates):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::update):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::visibleContentOpaqueRegion):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::visibleContentRect):
(WebCore::LayerChromium::setVisibleContentRect):
(LayerChromium):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawRenderPassQuad):
(WebCore::LayerRendererChromium::drawTileQuad):
(WebCore::LayerRendererChromium::drawYUVVideoQuad):
(WebCore::LayerRendererChromium::drawStreamVideoQuad):
(WebCore::LayerRendererChromium::drawIOSurfaceQuad):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::updateBounds):
(WebCore::TiledLayerChromium::setNeedsDisplayRect):
(WebCore::TiledLayerChromium::invalidateContentRect):
(WebCore::TiledLayerChromium::updateTiles):
(WebCore::TiledLayerChromium::setTexturePriorities):
(WebCore::TiledLayerChromium::setTexturePrioritiesInRect):
(WebCore::TiledLayerChromium::visibleContentOpaqueRegion):
(WebCore::TiledLayerChromium::updateContentRect):
(WebCore::TiledLayerChromium::needsIdlePaint):
(WebCore::TiledLayerChromium::idlePaintRect):

  • platform/graphics/chromium/TiledLayerChromium.h:

(TiledLayerChromium):

  • platform/graphics/chromium/cc/CCDrawQuad.h:

(WebCore::CCDrawQuad::visibleContentRect):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::createSharedQuadState):
(WebCore::CCLayerImpl::appendDebugBorderQuad):
(WebCore::CCLayerImpl::visibleContentOpaqueRegion):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::visibleContentRect):
(WebCore::CCLayerImpl::setVisibleContentRect):
(CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerTilingData.cpp:

(WebCore::CCLayerTilingData::contentRectToTileIndices):
(WebCore::CCLayerTilingData::opaqueRegionInContentRect):
(WebCore::CCLayerTilingData::setBounds):

  • platform/graphics/chromium/cc/CCLayerTilingData.h:

(CCLayerTilingData):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateVisibleContentRect):
(WebCore::layerShouldBeSkipped):
(WebCore):
(WebCore::calculateVisibleAndScissorRectsInternal):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::addOcclusionBehindLayer):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:

(WebCore::CCRenderPassDrawQuad::create):
(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:

(CCRenderPassDrawQuad):
(WebCore::CCRenderPassDrawQuad::drawTransform):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::createSharedQuadState):
(WebCore::CCRenderSurface::createReplicaSharedQuadState):
(WebCore::CCRenderSurface::appendQuads):

  • platform/graphics/chromium/cc/CCSharedQuadState.cpp:

(WebCore::CCSharedQuadState::create):
(WebCore::CCSharedQuadState::CCSharedQuadState):
(WebCore::CCSharedQuadState::isLayerAxisAlignedIntRect):

  • platform/graphics/chromium/cc/CCSharedQuadState.h:

(CCSharedQuadState):
(WebCore::CCSharedQuadState::visibleContentRect):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::appendQuads):
(WebCore::CCTiledLayerImpl::visibleContentOpaqueRegion):

Source/WebKit/chromium:

  • tests/CCLayerImplTest.cpp:

(WebCore::TEST):

  • tests/CCLayerTreeHostCommonTest.cpp:
  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/CCOcclusionTrackerTest.cpp:

(WebKitTests::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect::runMyTest):

  • tests/CCQuadCullerTest.cpp:
  • tests/CCRenderSurfaceTest.cpp:
  • tests/CCSolidColorLayerImplTest.cpp:

(CCLayerTestCommon::TEST):

  • tests/CCTiledLayerImplTest.cpp:

(CCLayerTestCommon::createLayer):
(CCLayerTestCommon::TEST):
(CCLayerTestCommon::getQuads):
(CCLayerTestCommon::coverageVisibleRectIntersectsTiles):
(CCLayerTestCommon::coverageVisibleRectIntersectsBounds):

  • tests/CCTiledLayerTestCommon.cpp:

(WebKitTests::FakeLayerTextureUpdater::prepareToUpdate):
(WebKitTests::FakeTiledLayerChromium::update):

  • tests/CCTiledLayerTestCommon.h:

(FakeTiledLayerChromium):

  • tests/LayerChromiumTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:
2:20 PM Changeset in webkit [122372] by Chris Fleizach
  • 5 edits in trunk

ARIA spinbutton role incorrectly mapped to ProgressIndicatorRole
https://bugs.webkit.org/show_bug.cgi?id=77298

Reviewed by Anders Carlsson.

Source/WebCore:

  • accessibility/AccessibilityObject.cpp:

(WebCore::createARIARoleMap):

LayoutTests:

  • platform/mac/accessibility/aria-spinbutton-expected.txt:
  • platform/mac/accessibility/aria-spinbutton.html:
2:14 PM Changeset in webkit [122371] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] UserViewportArguments are not properly respected.
https://bugs.webkit.org/show_bug.cgi?id=91005

Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-07-11
Reviewed by Rob Buis.

PR# 170088.
Move scale and zooming reset on Committed before applying
the user viewport to avoid overriding it immediately.

Internal review by Konrad Piascik, Jacky Jiang.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setLoadState):

2:11 PM Changeset in webkit [122370] by abarth@webkit.org
  • 1 delete in trunk/Tools/EWSTools/bogus

Sorry, that wasn't supposed to actually land.

2:10 PM Changeset in webkit [122369] by commit-queue@webkit.org
  • 1 add in trunk/Tools/EWSTools/bogus

OOPS! This commit should be rejected by the precommit hook.

2:03 PM Changeset in webkit [122368] by kseo@webkit.org
  • 2 edits in trunk/Source/WebCore

BitmapImage::frameIsCompleteAtIndex() must return false if ImageDecoder is not initialized.
https://bugs.webkit.org/show_bug.cgi?id=90757

Patch by Huang Dongsung <luxtella@company100.net> on 2012-07-11
Reviewed by Simon Fraser.

The current code fortunately has worked so far because only
BitmapImage::startAnimation calls frameIsCompleteAtIndex, and startAnimation
cannot call frameIsCompleteAtIndex if ImageDecoder is not yet initialized.
startAnimation returns at the first line becase shouldAnimate() always return
false in this case.

if (m_frameTimer
!shouldAnimate() frameCount() <= 1)

return;

This change is needed because parallel image decoders call
BitmapImage::frameIsCompleteAtIndex in other places too.

No new tests, manually tested whether the caller exists or not that
calls BitmapImage::frameIsCompleteAtIndex() before ImageDecoder is
initialized.

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::frameIsCompleteAtIndex):

1:56 PM Changeset in webkit [122367] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening, adding an expectation for a test failing on the
64-bit Debug builder due to libxml2 2.8.0 being used and updating the
bug handle for another test.

  • platform/gtk/TestExpectations:
1:28 PM Changeset in webkit [122366] by kevino@webkit.org
  • 3 edits in trunk/Tools

[wx] Unreviewed build fix. Add new directories and a new LayoutTestController method.

1:23 PM Changeset in webkit [122365] by kevino@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[wx] Unreviewed build fix. Don't try to build udis86_itab.c since it's included by another file.

1:20 PM Changeset in webkit [122364] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk/Source/WebKit

[BlackBerry] Implement Date/Time picker
https://bugs.webkit.org/show_bug.cgi?id=90911

Patch by Crystal Zhang <haizhang@rim.com> on 2012-07-11
Reviewed by Rob Buis.

Source/WebKit:

Add files into make file.

  • PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

Implement HTML Date/Time picker, also should delete popup when closing popup.

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::closePagePopup):

  • WebCoreSupport/DatePickerClient.cpp: Added.

(WebCore):
(WebCore::DatePickerClient::DatePickerClient):
(WebCore::DatePickerClient::~DatePickerClient):
(WebCore::DatePickerClient::generateHTML):
(WebCore::DatePickerClient::closePopup):
(WebCore::DatePickerClient::contentSize):
(WebCore::DatePickerClient::htmlSource):
(WebCore::DatePickerClient::setValueAndClosePopup):
(WebCore::DatePickerClient::didClosePopup):
(WebCore::DatePickerClient::writeDocument):

  • WebCoreSupport/DatePickerClient.h: Added.

(WebKit):
(WebCore):
(DatePickerClient):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::openDatePopup):

1:20 PM Changeset in webkit [122363] by kevino@webkit.org
  • 2 edits in trunk/Source/WebCore

[wx] Unreviewed build fix. Update code to use the new constant name.

1:18 PM Changeset in webkit [122362] by kevino@webkit.org
  • 2 edits in trunk/Source/WebCore

[wx] Unreviewed build fix. Ignore array and sequence types for attributes as well
as functions since the CPP bindings do not yet support them.

1:16 PM Changeset in webkit [122361] by kevino@webkit.org
  • 2 edits in trunk/Source/WebCore

[wx] Unreviewed build fix. Use DOMStringList instead of DOMString[] for in / out type.

1:14 PM Changeset in webkit [122360] by danakj@chromium.org
  • 7 edits in trunk/Source

[chromium] Minimum size used for occlusion tracking should be a setting on CCLayerTreeHost
https://bugs.webkit.org/show_bug.cgi?id=90993

Reviewed by Adrienne Walker.

Source/WebCore:

Move the default minimum size used for occlusion tracking from the
CCOcclusionTracker class into CCLayerTreeSettings. This value is then
used on both threads as the lower limit for any occlusion to be
remembered.

This allows us to use (0, 0) as the minimum size for tests, allowing all
occlusion to be tracked.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintLayerContents):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeSettings::CCLayerTreeSettings):
(CCLayerTreeSettings):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):

  • platform/graphics/chromium/cc/CCOcclusionTracker.h:

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:
1:02 PM Changeset in webkit [122359] by abarth@webkit.org
  • 4 edits in trunk

[Chromium] Enable LEGACY_VIEWPORT_ADAPTION
https://bugs.webkit.org/show_bug.cgi?id=90991

Reviewed by Tony Chang.

Source/WebKit/chromium:

Chromium wishes to support LEGACY_VIEWPORT_ADAPTION. I actually thought
this was enabled before, but the enable bit got lost in the shuffle.

  • features.gypi:

LayoutTests:

These tests pass now that we've enabled this feature.

  • platform/chromium/TestExpectations:
12:59 PM Changeset in webkit [122358] by tony@chromium.org
  • 6 edits in trunk

[chromium] Remove drag and drop API methods that are no longer used
https://bugs.webkit.org/show_bug.cgi?id=90996

Reviewed by Adam Barth.

Source/WebKit/chromium:

In r117327, we added a parameter for modifier keys to these methods.
Chromium has since switched to using the methods that require the
extra parameter so we can remove these methods.

  • public/WebView.h:

(WebView):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::dragTargetDragEnter):
(WebKit::WebViewImpl::dragTargetDragOver):

  • src/WebViewImpl.h:

(WebViewImpl):

Tools:

Migrate DRT to use the methods that take modifier keys.

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::doDragDrop):
(EventSender::doMouseUp):
(EventSender::doMouseMove):
(EventSender::beginDragWithFiles):

12:48 PM Changeset in webkit [122357] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Add MIPS convertibleLoadPtr and other functions
https://bugs.webkit.org/show_bug.cgi?id=90714

Patch by Chao-ying Fu <fu@mips.com> on 2012-07-11
Reviewed by Oliver Hunt.

  • assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::labelIgnoringWatchpoints):
(MIPSAssembler):
(JSC::MIPSAssembler::replaceWithLoad):
(JSC::MIPSAssembler::replaceWithAddressComputation):

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::convertibleLoadPtr):
(MacroAssemblerMIPS):

12:41 PM Changeset in webkit [122356] by andersca@apple.com
  • 10 edits in trunk/Source

Add -Wtautological-compare and -Wsign-compare warning flags
https://bugs.webkit.org/show_bug.cgi?id=90994

Reviewed by Mark Rowe.

Source/JavaScriptCore:

  • Configurations/Base.xcconfig:

Source/WebCore:

  • Configurations/Base.xcconfig:

Source/WebKit/mac:

  • Configurations/Base.xcconfig:

Source/WebKit2:

  • Configurations/Base.xcconfig:

Source/WTF:

  • Configurations/Base.xcconfig:
12:29 PM Changeset in webkit [122355] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Test actual rendering results in API tests
https://bugs.webkit.org/show_bug.cgi?id=80609

Reviewed by Alexis Menard.

Added a very basic test to tst_QQuickWebView to make sure rendering actually occurs.

  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView):
(tst_QQuickWebView::basicRenderingSanity):

12:29 PM Changeset in webkit [122354] by dino@apple.com
  • 8 edits
    2 adds in trunk

TileCache layers have wrong border debug color
https://bugs.webkit.org/show_bug.cgi?id=90922

Reviewed by Simon Fraser.

Source/WebCore:

Commit r122152 updated the layer hierarchy when a tile
cache is being used by the view. As part of that, GraphicsLayerClient::shouldUseTileCache()
was changed to return false in some situations (the idea was that it
should only be called from the createGraphicsLayer method). However
there were two other call points: one that sets the debug colors on
borders, the other was a call that keeps the document background in sync.

Add a new method usingTileCache() that returns the current state. Also fix
a FIXME where the debug code always called into the client rather than
caching the value on the GraphicsLayer.

Test: compositing/document-background-color.html

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::GraphicsLayer):
(WebCore::GraphicsLayer::updateDebugIndicators): check the local variable when
setting the debug colors.

  • platform/graphics/GraphicsLayer.h:

(GraphicsLayer): new bool member variable m_usingTileCache.

  • platform/graphics/GraphicsLayerClient.h:

(WebCore::GraphicsLayerClient::usingTileCache): new virtual method to query if
this client is actually using the tile cache.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::GraphicsLayerCA): set the member variable m_usingTileCache
if the GraphicsLayerClient says we are.

  • rendering/RenderLayerBacking.h:

(WebCore::RenderLayerBacking::usingTileCache):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::documentBackgroundColorDidChange): call usingTileCache()
rather than shouldUseTileCache(), because the latter's value might not always reflect
the existence of a cache.

LayoutTests:

Make sure that the document background color is updated
when using a Tile Cache.

  • compositing/document-background-color-expected.html: Added.
  • compositing/document-background-color.html: Added.
11:53 AM Changeset in webkit [122353] by rniwa@webkit.org
  • 8 edits in trunk/Source/WebCore

Clang build fix after r122345.
Also let XCode do its own thing.

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLCollection.cpp:

(WebCore::HTMLCollectionWithArrayStorage::item):

  • html/HTMLCollection.h:

(HTMLCollectionWithArrayStorage):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::itemInArrayAfter):

  • html/HTMLFormCollection.h:

(HTMLFormCollection):

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::itemInArrayAfter):

  • html/HTMLPropertiesCollection.h:

(HTMLPropertiesCollection):

11:49 AM Changeset in webkit [122352] by mrowe@apple.com
  • 10 edits
    1 add in trunk

Add a Mountain Lion version of libWebKitSystemInterface.a.

Source/WebKit/mac:

Reviewed by John Sullivan.

  • Configurations/DebugRelease.xcconfig: Look for the library under its expected name.

Source/WebKit2:

Reviewed by John Sullivan.

  • Configurations/DebugRelease.xcconfig: Look for the library under its expected name.

Tools:

Reviewed by John Sullivan.

  • Scripts/copy-webkitlibraries-to-product-directory: Include libWebKitSystemInterfaceMountainLion.a in the list of libraries to copy.

WebKitLibraries:

Update the WebKitSystemInterface header and binaries.

Reviewed by John Sullivan.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceMountainLion.a: Added.
  • libWebKitSystemInterfaceSnowLeopard.a:
11:45 AM Changeset in webkit [122351] by pdr@google.com
  • 1 edit
    1 add in trunk/PerformanceTests

Add a performance test for hit testing in SVG
https://bugs.webkit.org/show_bug.cgi?id=90811

Reviewed by Ryosuke Niwa.

The shape rendering code is changing a lot and I'd like a performance test to
make sure we don't regress, and to track our improvements.

Performance results in my Linux desktop:

RESULT SVG: SvgHitTesting= 105.0 ms
median= 103.5 ms, stdev= 4.60434577329 ms, min= 101.0 ms, max= 116.0 ms

RESULT SVG: SvgHitTesting= 97.8 ms
median= 96.5 ms, stdev= 2.67581763205 ms, min= 95.0 ms, max= 102.0 ms

RESULT SVG: SvgHitTesting= 104.3 ms
median= 104.0 ms, stdev= 1.41774468788 ms, min= 102.0 ms, max= 107.0 ms

RESULT SVG: SvgHitTesting= 103.6 ms
median= 103.5 ms, stdev= 1.2 ms, min= 102.0 ms, max= 106.0 ms

  • SVG/SvgHitTesting.html: Added.
11:45 AM Changeset in webkit [122350] by mrowe@apple.com
  • 2 edits in trunk/Tools

<http://webkit.org/b/90835> Teach bisect-builds to work with a Safari.app that has entitlements.

Reviewed by Dan Bernstein.

  • Scripts/bisect-builds: Use safariPathFromSafariBundle to determine which binary within the application

should be invoked.

11:42 AM Changeset in webkit [122349] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

[Gtk] fast/events/keydown-function-keys.html is failing
https://bugs.webkit.org/show_bug.cgi?id=90891

Reviewed by Martin Robinson.

Work around the context menu being shown on F10 key being pressed by
unbiding the key when running tests in DumpRenderTree. The problem
appears when using a recent version of the xkeyboard-config package.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(setDefaultsToConsistentStateValuesForTesting):

11:30 AM Changeset in webkit [122348] by shawnsingh@chromium.org
  • 1 edit
    2 adds in trunk/Source/WebKit/chromium

Unreviewed build fix, forgot to add URLTestHelpers.* when landing r122344

  • tests/URLTestHelpers.cpp: Added.

(URLTestHelpers):
(WebKit::URLTestHelpers::registerMockedURLFromBaseURL):
(WebKit::URLTestHelpers::registerMockedURLLoad):

  • tests/URLTestHelpers.h: Added.

(WebKit):
(URLTestHelpers):
(WebKit::URLTestHelpers::toKURL):

11:15 AM Changeset in webkit [122347] by benjamin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Simplify the copying of JSC ARMv7's LinkRecord
https://bugs.webkit.org/show_bug.cgi?id=90930

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-07-11
Reviewed by Filip Pizlo.

The class LinkRecord is used by value everywhere in ARMv7Assembler. The compiler uses
memmove() to move the objects.

The problem is memmove() is overkill for this object, moving the value can be done with
3 load-store. This patch adds an operator= to the class doing more efficient copying.
This reduces the link time by 19%.

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::LinkRecord::LinkRecord):
(JSC::ARMv7Assembler::LinkRecord::operator=):
(JSC::ARMv7Assembler::LinkRecord::from):
(JSC::ARMv7Assembler::LinkRecord::setFrom):
(JSC::ARMv7Assembler::LinkRecord::to):
(JSC::ARMv7Assembler::LinkRecord::type):
(JSC::ARMv7Assembler::LinkRecord::linkType):
(JSC::ARMv7Assembler::LinkRecord::setLinkType):
(JSC::ARMv7Assembler::LinkRecord::condition):

11:14 AM Changeset in webkit [122346] by commit-queue@webkit.org
  • 4 edits in trunk

[Gtk] allow building with css-filters
https://bugs.webkit.org/show_bug.cgi?id=90908

.:

Add support for css-filters in Source/WebCore/GNUmakefile.am
configure.ac

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-07-11
Reviewed by Eric Seidel.

  • configure.ac:

Source/WebCore:

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-07-11
Reviewed by Eric Seidel.

Add support for css-filters in Source/WebCore/GNUmakefile.am
configure.ac

No functional change, so no new tests.

  • GNUmakefile.am:
11:13 AM Changeset in webkit [122345] by rniwa@webkit.org
  • 7 edits in trunk/Source/WebCore

HTMLFormCollection::item and HTMLPropertiesCollection::item should share code
https://bugs.webkit.org/show_bug.cgi?id=90932

Reviewed by Anders Carlsson.

Merged HTMLFormCollection::item and HTMLPropertiesCollection::item as HTMLCollectionWithArrayStorage::item,
which can be merged into HTMLCollection::item in a follow up patch.

Also moved the call to invalidateCacheIfNeeded into HTMLCollection::updateNameCache() as done in
HTMLPropertiesCollection.

In addition, moved the early bail out for when the base element doesn't have itemscope attribute from individual
functions to updateRefElements so that HTMLCollectionWithArrayStorage::item doesn't need to have this check.

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollectionWithArrayStorage::item): Added. It's based on HTMLPropertiesCollection::item but it only
has the single loop (as supposed to nested loops) as HTMLFormCollection doesn't have multiple items per element
in the array unlike HTMLPropertiesCollection. In addition, offsetInArray (was i in HTMLPropertiesCollection::item) is
incremented in each itemAfter due to this semantic difference in each itemAfter.
(WebCore::HTMLCollection::updateNameCache):
(WebCore::HTMLCollection::hasNamedItem):
(WebCore::HTMLCollection::namedItems):

  • html/HTMLCollection.h:

(HTMLCollectionWithArrayStorage):
(WebCore::HTMLCollectionWithArrayStorage::HTMLCollectionWithArrayStorage):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::HTMLFormCollection):
(WebCore::HTMLFormCollection::calcLength): Merged numberOfFormControlElements since it was only called here.
(WebCore::HTMLFormCollection::itemAfter): Added. HTMLFormCollection has exactly one item per element in the array
so we increment the offset in each iteration. Note that when we're continuing a search, we need to increment
the offset in order to avoid returning the same item.
(WebCore::HTMLFormCollection::updateNameCache):

  • html/HTMLFormCollection.h:

(HTMLFormCollection):

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::HTMLPropertiesCollection):
(WebCore::HTMLPropertiesCollection::updateRefElements): Set m_hasItemRefElements true upfront since we never fail to
update ref elements. Bail out as soon as we cleared the m_itemRefElements when the base element doesn't have itemscope
content attribute.
(WebCore::HTMLPropertiesCollection::itemAfter): Added. We reset previousItem to null because the existing itemAfter
requires previousItem be null when we're moving to a new entry in m_itemRefElements.
(WebCore::HTMLPropertiesCollection::calcLength):
(WebCore::HTMLPropertiesCollection::cacheFirstItem):
(WebCore::HTMLPropertiesCollection::updateNameCache): Merged findProperties since this was the only caller.
(WebCore::HTMLPropertiesCollection::names):
(WebCore::HTMLPropertiesCollection::namedItem):
(WebCore::HTMLPropertiesCollection::hasNamedItem):

  • html/HTMLPropertiesCollection.h:

(HTMLPropertiesCollection): Made updateRefElements public as it's called in HTMLCollectionWithArrayStorage::item.

11:10 AM Changeset in webkit [122344] by shawnsingh@chromium.org
  • 16 edits in trunk/Source/WebKit/chromium

[chromium] Use WEBKIT_IMPLEMENTATION == 1 for webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=90094

Reviewed by Adrienne Walker.

This patch adds the WEBKIT_IMPLEMENTATION = 1 define to
WebKitUnitTests.gyp. To get it to compile correctly, some string
and URL code was refactored and fixed, in particular GURL usage is
replaced with KURL usage.

  • WebKit.gyp:

added WEBKIT_IMPLEMENTATION == 1 for unit test code when in shared library
added URLTestHelpers to exclusion in shared library build, because it depends on webkit_support

  • WebKit.gypi:

added URLTestHelpers.h and .cpp to the build process

  • WebKitUnitTests.gyp:

added WEBKIT_IMPLEMENTATION == 1 for unit test code when not in shared library.
note that in shared library build, RunAllTests.cpp does not have WEBKIT_IMPLEMENTATION == 1.

  • public/WebDOMMessageEvent.h:

(WebKit::WebDOMMessageEvent::WebDOMMessageEvent):

  • tests/AssociatedURLLoaderTest.cpp:
  • tests/EventListenerTest.cpp:
  • tests/FrameTestHelpers.cpp:

(WebKit::FrameTestHelpers::loadFrame):

  • tests/FrameTestHelpers.h:
  • tests/ListenerLeakTest.cpp:

(WebKit::ListenerLeakTest::RunTest):

  • tests/PopupMenuTest.cpp:
  • tests/RunAllTests.cpp:
  • tests/URLTestHelpers.cpp: Added.

(URLTestHelpers):
(WebKit::URLTestHelpers::registerMockedURLFromBaseURL):
(WebKit::URLTestHelpers::registerMockedURLLoad):

  • tests/URLTestHelpers.h: Copied from Source/WebKit/chromium/public/WebDOMMessageEvent.h.

(WebKit):
(URLTestHelpers):
(WebKit::URLTestHelpers::toKURL):

  • tests/WebFrameTest.cpp:
  • tests/WebPageNewSerializerTest.cpp:
  • tests/WebPageSerializerTest.cpp:
  • tests/WebViewTest.cpp:
11:00 AM Changeset in webkit [122343] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

RenderView layer is marked as fixed position container in the scrolling tree if page scale != 1
https://bugs.webkit.org/show_bug.cgi?id=89216

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-07-11
Reviewed by Simon Fraser.

Render layers with CSS transforms should become containers for any fixed
positioned descendants. However, because this check is done with
RenderLayer::hasTransform(), we also end up marking the RenderLayer for the
RenderView as fixed position container if a non-identity page scale factor is
used. This is because page scale is applied as a transform for that layer.

This breaks fixed position layers, because they become fixed relative to the
RenderView layer instead of outer scroll clip layer.

The fix is to avoid marking any root layers as fixed position containers.

No new test because the scrolling tree isn't currently testable.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

10:50 AM Changeset in webkit [122342] by jchaffraix@webkit.org
  • 3 edits in trunk/Source/WebCore

REGRESSION (r116203): overflow sections don't have scrollbars
https://bugs.webkit.org/show_bug.cgi?id=90052

Reviewed by Simon Fraser.

This issue stems from RenderLayers with overlay scrollbars not being considered
self-painting.

After r120395 (follow-up of r116203), we ignore subtrees that have no self-painting layer for
painting. Normal scrollbars are painted by their renderer so they were properly painted. However
overlay scrollbars need to be painted by their RenderLayer as a separate phase (see bug 57057) so
they were not painted anymore. The fix is simple: make RenderLayer with overlay scrollbars
self-painting as they should have been in the first place.

Unfortunately no tests as I don't think we have a good way of testing overlay
scrollbars. Tested manually though on the super simple test case from the bug.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::shouldBeSelfPaintingLayer):
Overlay scrollbars make the layer self-painting.

(WebCore::RenderLayer::updateScrollbarsAfterLayout):
Added a call to updateSelfPaintingLayer.

(WebCore::RenderLayer::styleChanged):
Moved the call to updateSelfPaintingLayer after recomputing the scrollbars to ensure proper behavior.
Added a comment underlining the reason.

(WebCore::RenderLayer::updateSelfPaintingLayer):
Renamed as it is now called during layout too.

  • rendering/RenderLayer.h:

(RenderLayer): Updated after updateSelfPaintingLayer rename.

10:50 AM Changeset in webkit [122341] by wingo@igalia.com
  • 2 edits in trunk/Source/JavaScriptCore

jsc: Parse options before creating global data
https://bugs.webkit.org/show_bug.cgi?id=90975

Reviewed by Filip Pizlo.

This patch moves the options parsing in "jsc" before the creation
of the JSGlobalData, so that --useJIT=no has a chance to take
effect.

  • jsc.cpp:

(CommandLine::parseArguments): Refactor to be a class, and take
argc and argv as constructor arguments.
(jscmain): Move arg parsing before JSGlobalData creation.

10:50 AM Changeset in webkit [122340] by noam.rosenthal@nokia.com
  • 6 edits in trunk

[Qt] QRawWebView should notify when rendering is done, so that pixel results can be grabbed at the appropriate moment.
https://bugs.webkit.org/show_bug.cgi?id=90641

Reviewed by Jocelyn Turcotte.

Source/WebKit2:

Implement LayerTreeCoordinator::forceRepaint with logic equivalent to the one in
LayerTreeHostCA. If we flush the layers synchronously when forceRepaint is called,when
WKPageForceRepaint returns we are guaranteed to have an up-to-date image, as the visible
tiles are also synchronously updated.

  • UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp:

(WebView::WebView):
(WebView::viewNeedsDisplay):
(WebView::frameLoaded):
(WebView):
(WebView::onRepaintDone):
(WebView::finishForceRepaint):
(WebView::finishFirstLayoutForFrame):
(tst_qrawwebview::doNoBackground1):
(tst_qrawwebview::doNoBackground2):
(tst_qrawwebview::doNoBackground3):
(tst_qrawwebview::run):

The test for QRawWebView has been updated to use the WebKit2 ForcePaint API prior to
generating the pixel results. This has exposed a timing bug in the test - setting the
transparentBackground property of a page has to be done before it's created. This has
been fixed in the test.

  • WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::forceRepaint):
(WebKit::LayerTreeCoordinator::performScheduledLayerFlush):
(WebKit):

Tools:

  • MiniBrowser/qt/raw/View.h: Comment used old class name (WKView).

(View):

10:09 AM Changeset in webkit [122339] by allan.jensen@nokia.com
  • 3 edits
    2 adds in trunk

NodesFromRect doesn't work on SVG root elements.
https://bugs.webkit.org/show_bug.cgi?id=89990

Reviewed by Antonio Gomes.

Source/WebCore:

Adds support for rect-based hit-testing on the SVG root element.
This means that while rect-based hit-testing is still not supported
within SVG elements, that at least it works on SVG root elements as
it would on any other replaced element.

Test: fast/dom/nodesFromRect-svg.html

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::nodeAtPoint):

LayoutTests:

Test nodesFromRect on SVG root elements.

  • fast/dom/nodesFromRect-svg-expected.txt: Added.
  • fast/dom/nodesFromRect-svg.html: Added.
9:56 AM Changeset in webkit [122338] by commit-queue@webkit.org
  • 2 edits in trunk/Websites/bugs.webkit.org

Deleting content at the top of prettypatch emails destroys HTML formatting
https://bugs.webkit.org/show_bug.cgi?id=90700
<rdar://problem/7488232>

Patch by Alice Cheng <alice_cheng@apple.com> on 2012-07-11
Reviewed by David Kilzer.

  • PrettyPatch/PrettyPatch.rb:
9:50 AM Changeset in webkit [122337] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Android] sending an extra to the DRT apk so that DRT can be run in a seperate thread
https://bugs.webkit.org/show_bug.cgi?id=90831

Patch by Min Qin <qinmin@chromium.org> on 2012-07-11
Reviewed by Adam Barth.

On android, DRT needs to run in a background thread to avoid ANR.
However, the java tests are running on UI thread by default.
We need to send an intent extra to the apk so that it can run on a sub thread.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidDriver._start_once):

9:46 AM Changeset in webkit [122336] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-5.0-wk2/Skipped: Skip a new crashing test.
  • platform/qt/Skipped: Typo fix.
8:14 AM Changeset in webkit [122335] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt] REGRESSION(r107171): Fix --timeout option of Qt's DRT
https://bugs.webkit.org/show_bug.cgi?id=90966

Reviewed by Ryosuke Niwa.

  • DumpRenderTree/qt/main.cpp:

(main): Don't remove the argument, because takeOptionValue() did it before.

8:08 AM Changeset in webkit [122334] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebCore

[Qt] REGRESSION(r122250): It broke USE(3D_GRAPHICS)=1 and ENABLE(WEBGL)=0 builds
https://bugs.webkit.org/show_bug.cgi?id=90943

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-11
Reviewed by Csaba Osztrogonác.

Uses proper guarding in Extensions3DOpenGLCommon and Extensions3DOpenGLES as per https://bugs.webkit.org/show_bug.cgi?id=90506.

No new tests, becasue there is no new functionality.

  • platform/graphics/opengl/Extensions3DOpenGLCommon.cpp: Use proper guarding.
  • platform/graphics/opengl/Extensions3DOpenGLES.cpp: Use proper guarding.
8:05 AM Changeset in webkit [122333] by commit-queue@webkit.org
  • 4 edits in trunk

[Qt] Middle clicking a scrollbar causes text to be pasted.
https://bugs.webkit.org/show_bug.cgi?id=78444

Source/WebKit/qt:

Check if the event was already accepted before handling the clipboard.

Patch by Steffen Imhof <steffen.imhof@basyskom.com> on 2012-07-11
Reviewed by Simon Hausmann.

  • Api/qwebpage.cpp:

(QWebPagePrivate::mouseReleaseEvent):

LayoutTests:

Updated the scrollbars/scrollbar-middleclick-nopaste.html test to use an
<input> field as target for onpaste events. Using <body> did not work
(at least for Qt), because the onpaste events are not fired, even if
manually middle-clicking into the body. My guess would be that they are
not sent, because the body is non-editable. The changed test should
reflect the common use-case triggering the problem better.

Patch by Steffen Imhof <steffen.imhof@basyskom.com> on 2012-07-11
Reviewed by Simon Hausmann.

  • scrollbars/scrollbar-middleclick-nopaste.html:
7:50 AM Changeset in webkit [122332] by pfeldman@chromium.org
  • 10 edits
    10 deletes in trunk/Source

Web Inspector: migrate from background images to CSS for statusbar rendering.
https://bugs.webkit.org/show_bug.cgi?id=90902

Reviewed by Vsevolod Vlasov.

Source/WebCore:

This change removes statusbar* images and uses gradients and borders to re-create original inspector look.

  • WebCore.gypi:
  • inspector/front-end/Images/statusbarBackground.png: Removed.
  • inspector/front-end/Images/statusbarBottomBackground.png: Removed.
  • inspector/front-end/Images/statusbarButtons.png: Removed.
  • inspector/front-end/Images/statusbarMenuButton.png: Removed.
  • inspector/front-end/Images/statusbarMenuButtonSelected.png: Removed.
  • inspector/front-end/StatusBarButton.js:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:

(body.drawer-visible #main-status-bar):
(body.drawer-visible #main-status-bar::after):
(.status-bar-background):
(.status-bar > div):
(.glyph):
(button.status-bar-item):
(.status-bar button.status-bar-item:active):
(select.status-bar-item):
(select.status-bar-item, select.status-bar-item:hover):
(body.detached .alternate-status-bar-buttons-bar):
(.alternate-status-bar-buttons-bar):
(.alternate-status-bar-buttons-bar .status-bar-item):
(.alternate-status-bar-buttons-bar .status-bar-item.emulate-active):
(#drawer):
(body.drawer-visible #drawer-contents):
(#drawer-status-bar):

  • inspector/front-end/inspector.html:
  • inspector/front-end/scriptsPanel.css:

(button.status-bar-item.scripts-navigator-show-hide-button):
(button.status-bar-item.scripts-navigator-show-hide-button:active):
(button.status-bar-item.scripts-debugger-show-hide-button):
(button.status-bar-item.scripts-debugger-show-hide-button:active):

Source/WebKit/chromium:

  • WebKit.gypi:
  • src/js/Images/statusbarBackgroundChromium.png: Removed.
  • src/js/Images/statusbarBottomBackgroundChromium.png: Removed.
  • src/js/Images/statusbarButtonsChromium.png: Removed.
  • src/js/Images/statusbarMenuButtonChromium.png: Removed.
  • src/js/Images/statusbarMenuButtonSelectedChromium.png: Removed.
  • src/js/devTools.css:

(.status-bar-background):

7:35 AM Changeset in webkit [122331] by wjmaclean@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening. fast/forms/textarea/textarea-state-restore.html is flaky (timeouts frquently).
https://bugs.webkit.org/show_bug.cgi?id=90980

Marking this test as possible TIMOUT in test expectations.

  • platform/chromium/TestExpectations:
7:06 AM Changeset in webkit [122330] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip a failing test after r122327.
https://bugs.webkit.org/show_bug.cgi?id=90979.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-07-11

  • platform/qt/Skipped:
6:48 AM Changeset in webkit [122329] by wjmaclean@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Mark inspector/extensions/extensions-events.html as TIMEOUT on non-debug builds.
https://bugs.webkit.org/show_bug.cgi?id=86439

This test has started timing out on non-debug builds as well, adding comment to existing bug.

  • platform/chromium/TestExpectations:
6:44 AM Changeset in webkit [122328] by jason.liu@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] crash in CookieDatabaseBackingStore.
https://bugs.webkit.org/show_bug.cgi?id=90270

Reviewed by George Staikos.

There is one case for this crash.

  1. A browser crashes and locks cookies' database for a while.
  2. Open a new browser when the old one doesn't finish crashing.
  3. The new one writes the cookies' database and receives a SQLITE_BUSY error in CookieDatabaseBackingStore's invokeOpen. So this database isn't opened.
  4. invokeGetCookiesWithLimit returns 0.
  5. Crash happens when using a null pointer.

Add function setBusyTimeout(1000) and a guard for cookies' pointer.
setBusyTimeout will call sqlite3_busy_timeout.

When the SQLite database is accessed for reading it is locked for writing
until the reading access is finished. Another process cannot access the database
while it is locked. The timeout time sets a limit while this process tries to access
the locked database. If the database is unlocked within the timeout time it can be
accessed, otherwise an access fails.

No new tests. This crash is hard to reproduce, and it happens only on our platform.

  • platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:

(WebCore::CookieDatabaseBackingStore::getCookiesFromDatabase):

5:30 AM Changeset in webkit [122327] by vsevik@chromium.org
  • 18 edits in trunk

Web Inspector: Move revisions support to UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=90888

Reviewed by Pavel Feldman.

Source/WebCore:

Moved revisions support to UISourceCode.
Revision management code is moved unchanged where possible and should be refactored later.

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModelResourceBinding.prototype._innerStyleSheetChanged): revision is now added to uiSourceCode, not resource.

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._notifyUISourceCodeContentCommitted):
Extension server is now listening for Workspace.UISourceCodeContentCommitted event instead of ResourceTreeModel.ResourceContentCommitted.

  • inspector/front-end/Resource.js:
  • inspector/front-end/ResourceTreeModel.js: ResourceTreeModel.ResourceContentCommitted renamed to Workspace.UISourceCodeContentCommitted.
  • inspector/front-end/ResourceView.js:

(WebInspector.ResourceSourceFrame): ResourceSourceFrame is not update when revisions are added anymore as resource conenten is considered immutable now

  • inspector/front-end/RevisionHistoryView.js:

(WebInspector.RevisionHistoryView.populateRevisions):
(WebInspector.RevisionHistoryView):
(WebInspector.RevisionHistoryView.showHistory):
(WebInspector.RevisionHistoryView.prototype._createUISourceCodeItem):
(WebInspector.RevisionHistoryView.prototype._revisionAdded.get if):
(WebInspector.RevisionHistoryView.prototype._revisionAdded):
(WebInspector.RevisionHistoryView.prototype._revealUISourceCode.get if):
(WebInspector.RevisionHistoryView.prototype._revealUISourceCode):
(WebInspector.RevisionHistoryView.prototype._reset):

  • inspector/front-end/ScriptSnippetModel.js: Snippets are not loaded before ResourceTreeModel.mainFrame is available anymore.

(WebInspector.ScriptSnippetModel):
(WebInspector.ScriptSnippetModel.prototype._setScriptSnippetContent):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.requestOriginalContent):
(WebInspector.UISourceCode.prototype._setContent):
(WebInspector.UISourceCode.prototype.addRevision):
(WebInspector.UISourceCode.prototype._restoreRevisionHistory):
(WebInspector.UISourceCode.prototype._clearRevisionHistory):
(WebInspector.UISourceCode.prototype.revertToOriginal):
(WebInspector.UISourceCode.prototype.revertAndClearHistory):
(WebInspector.UISourceCode.prototype.revertAndClearHistory.clearHistory):
(WebInspector.UISourceCode.prototype.commitWorkingCopy):
(WebInspector.UISourceCode.prototype.canonicalMimeType):
(WebInspector.Revision):
(WebInspector.Revision._revisionHistoryRegistry):
(WebInspector.Revision._ensureStaleRevisionsFileteredOut.persist):
(WebInspector.Revision._ensureStaleRevisionsFileteredOut):
(WebInspector.Revision.prototype.get uiSourceCode):
(WebInspector.Revision.prototype.get timestamp):
(WebInspector.Revision.prototype.get content):
(WebInspector.Revision.prototype.revertToThis):
(WebInspector.Revision.prototype.contentURL):
(WebInspector.Revision.prototype.contentType):
(WebInspector.Revision.prototype.requestContent):
(WebInspector.Revision.prototype.searchInContent):
(WebInspector.Revision.prototype._persist):

  • inspector/front-end/UserAgentSupport.js: Drive-by closure compilation fix.
  • inspector/front-end/Workspace.js:
  • inspector/front-end/inspector.js: ScriptSnippetModel is now created after ResourceTreeModel.

LayoutTests:

  • http/tests/inspector/network/network-request-revision-content-expected.txt:
  • http/tests/inspector/network/network-request-revision-content.html:
  • inspector/debugger/script-snippet-model.html:
  • inspector/styles/styles-add-new-rule.html:
  • inspector/styles/styles-history.html:
4:26 AM Changeset in webkit [122326] by morrita@google.com
  • 13 edits in trunk/Source

WebCoreSupport needs objects each of which follows major WebCore objects
https://bugs.webkit.org/show_bug.cgi?id=88499

Reviewed by Alexey Proskuryakov.

Source/WebCore:

This change

  • Makes Internals rough lifetime to follow Document. Note that Internals can survive longer than Document in same case. Internals::m_document is cleared when the document destruction is notified.
  • Makes InternalSettings rough lifetime to follow the Page. This is done by making InternalSettings a supplement of the page. Now InternalSettings object is created per Page instead of per Frame.

Per-test setting clearance is done by newly introduced InternalSettings::Backup,
which recovers the modified settings and refreshes it for each time a test starts.

  • WebCore.exp.in:
  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::from):
(WebCore::InternalSettings::~InternalSettings):
(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::reset):
(WebCore::InternalSettings::settings):
(WebCore::InternalSettings::setFixedElementsLayoutRelativeToFrame):
(WebCore::InternalSettings::setFixedPositionCreatesStackingContext):
(WebCore::InternalSettings::allowRoundingHacks):
(WebCore::InternalSettings::userPreferredLanguages):
(WebCore::InternalSettings::setUserPreferredLanguages):
(WebCore::InternalSettings::setShouldDisplayTrackKind):
(WebCore::InternalSettings::shouldDisplayTrackKind):
(WebCore::InternalSettings::setPagination):

  • testing/InternalSettings.h:

(Backup):
(InternalSettings):
(WebCore::InternalSettings::page):

  • testing/InternalSettings.idl:
  • testing/Internals.cpp:

(WebCore::Internals::Internals):
(WebCore):
(WebCore::Internals::contextDocument):
(WebCore::Internals::frame):
(WebCore::Internals::settings):
(WebCore::Internals::setPagination): Replaced as an alias.
(WebCore::Internals::userPreferredLanguages): Replaced as an alias.
(WebCore::Internals::setUserPreferredLanguages): Replaced as an alias.
(WebCore::Internals::setShouldDisplayTrackKind): Replaced as an alias.
(WebCore::Internals::shouldDisplayTrackKind): Replaced as an alias.
(WebCore::Internals::emitInspectorDidBeginFrame):
(WebCore::Internals::emitInspectorDidCancelFrame):
(WebCore::Internals::allowRoundingHacks): Replaced as an alias.

  • testing/Internals.h:

(WebCore):
(Internals):

  • testing/js/WebCoreTestSupport.cpp:

(WebCoreTestSupport::injectInternalsObject):
(WebCoreTestSupport::resetInternalsObject):

  • testing/v8/WebCoreTestSupport.cpp:

(WebCoreTestSupport::injectInternalsObject):
(WebCoreTestSupport::resetInternalsObject):

Source/WebKit2:

Added exporting symbols.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
3:40 AM Changeset in webkit [122325] by abecsi@webkit.org
  • 3 edits in trunk/Source/WebKit2

Unreviewed, rolling out r122318.
http://trac.webkit.org/changeset/122318
https://bugs.webkit.org/show_bug.cgi?id=90961

It made 11 fast/events/touch fail (Requested by bbandix on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-11

  • UIProcess/API/qt/qquickwebview.cpp:
  • UIProcess/API/qt/qquickwebview_p.h:
3:35 AM Changeset in webkit [122324] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

Mark fast/js/dfg-poison-fuzz.html as slow, because its runtime is 48 secs on 32 bit in debug mode.

  • platform/qt/TestExpectations:
3:08 AM Changeset in webkit [122323] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][ARM] Unreviewed gardening, mark slow tests.

  • platform/qt-arm/TestExpectations:
2:54 AM Changeset in webkit [122322] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][Wk2] WebErrorsEfl.cpp needs to return non-empty errors
https://bugs.webkit.org/show_bug.cgi?id=90688

Patch by Keunsoon Lee <keunsoon.lee@samsung.com> on 2012-07-11
Reviewed by Hajime Morita.

Return meaningful error for each case.

  • WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp:

(WebKit::cancelledError): create ResourceError for "request canceled".
(WebKit::blockedError): create ResourceError for "request blocked".
(WebKit::cannotShowURLError): create ResourceError for "cannot show url".
(WebKit::interruptedForPolicyChangeError): create ResourceError for "Frame load interrupted by policy change".
(WebKit::cannotShowMIMETypeError): create ResourceError for "Cannot show mimetype".
(WebKit::fileDoesNotExistError): create ResourceError for "File does not exist".
(WebKit::pluginWillHandleLoadError): create ResourceError for "Plugin will handle load".

2:49 AM Changeset in webkit [122321] by abecsi@webkit.org
  • 4 edits
    2 adds in trunk/Source/WebKit2

[Qt][WK2] Fix wheel scrolling for simple pages
https://bugs.webkit.org/show_bug.cgi?id=90793

Reviewed by Kenneth Rohde Christiansen.

Call WebPage::setFixedLayoutSize in setResizesToContentsUsingLayoutSize
instead of setting the view size manually and scheduling a relayout.
Since setFixedLayoutSize forces a relayout it also updates the scrollbars
after the visible rect is available.
This fixes scrolling with wheel events for a QML WebView loading a simple
local page which previously ended up in a state where scrolling was disabled
because the scrollbar update happened before the correct visible rect size was
available.

Add a QML test and infrastructure to QWebKitTest to cover this case.

  • UIProcess/API/qt/qwebkittest.cpp:

(QWebKitTest::wheelEvent):

  • UIProcess/API/qt/qwebkittest_p.h:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_wheelEventHandling.qml: Added.
  • UIProcess/API/qt/tests/qmltests/common/test4.html: Added.
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setResizesToContentsUsingLayoutSize):

2:44 AM Changeset in webkit [122320] by yosin@chromium.org
  • 2 edits in trunk/Source/WebCore

[Mac] Expose time format related functions
https://bugs.webkit.org/show_bug.cgi?id=90956

Reviewed by Kent Tamura.

This patch introduces localizedTimeFormatText, localizedShortTimeFormatText
and timeAMPMLabels for Mac within feature flag ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

See also:

ICU version: https://bugs.webkit.org/show_bug.cgi?id=89965
Win version: https://bugs.webkit.org/show_bug.cgi?id=90236

No new tests. This patch doesn't change behavior.

  • platform/text/mac/LocalizedDateMac.cpp:

(WebCore::localizedTimeFormatText): Added.
(WebCore::localizedShortTimeFormatText): Added.
(WebCore::timeAMPMLabels): Added.

2:43 AM Changeset in webkit [122319] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][ARM] Unreviewed gardening, skip more crashing tests.

  • platform/qt-arm/TestExpectations:
2:40 AM Changeset in webkit [122318] by abecsi@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] ASSERT: "!m_viewportItem->isMoving()" in QtViewportHandler::flickMoveEnded()
https://bugs.webkit.org/show_bug.cgi?id=90875

Reviewed by Kenneth Rohde Christiansen.

Since MultiPointTouchArea and PinchArea use the childMouseEventFilter
method to filter touch events too, and because Flickable filters child
mouse events the canvas calls this function before propagating the touch
event to the WebView. Since Flickable does not accept touch events the
canvas tries to propagate a synthesized mouse event through the base
class childMouseEventFilter function which is accepted by Flickable and
interferes with the input events we send to Flicakble hence messes up
the internal state of the WebView.
This patch reimplements the virtual childMouseEventFilter method so that all
the mouse and touch events can be processed by WebKit before they arrive to
Flickable.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebView::childMouseEventFilter):

  • UIProcess/API/qt/qquickwebview_p.h:
2:28 AM Changeset in webkit [122317] by allan.jensen@nokia.com
  • 2 edits in trunk/Tools

First commit, moving myself to commiter.

Unreviewed

  • Scripts/webkitpy/common/config/committers.py:
2:27 AM Changeset in webkit [122316] by allan.jensen@nokia.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

[Chromium] Adding HarfBuzz-ng for Linux
https://bugs.webkit.org/show_bug.cgi?id=90362

Reviewed by Tony Chang.

Source/WebCore:

This patch adds harfbuzz-ng support for Chromium Linux port as a part of
transition from old harfbuzz. HarfBuzzFaceSkia.cpp implements harfbuzz-ng
callbacks by using Skia APIs. For now, the feature is enabled only when
WTF_USE_HARFBUZZ_NG is defined.

No new tests. No change in behavior now.

  • WebCore.gyp/WebCore.gyp: Added use_harfbuzz_ng variable and related files.
  • WebCore.gypi: Added HarfBuzzFaceSkia.cpp
  • platform/graphics/harfbuzz/FontHarfBuzz.cpp: Added USE(HARFBUZZ_NG).

(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp: Ditto.

(WebCore):
(WebCore::FontPlatformData::harfbuzzFace):

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h: Ditto.

(FontPlatformData):

  • platform/graphics/harfbuzz/ng/HarfBuzzFaceSkia.cpp: Added.

(WebCore):
(WebCore::SkiaScalarToHarfbuzzPosition):
(WebCore::SkiaGetGlyphWidthAndExtents):
(WebCore::harfbuzzGetGlyph):
(WebCore::harfbuzzGetGlyphHorizontalAdvance):
(WebCore::harfbuzzGetGlyphHorizontalOrigin):
(WebCore::harfbuzzGetGlyphExtents):
(WebCore::harfbuzzSkiaGetFontFuncs):
(WebCore::harfbuzzSkiaGetTable):
(WebCore::destroyPaint):
(WebCore::HarfBuzzFace::createFace):
(WebCore::HarfBuzzFace::createFont):
(WebCore::HarfBuzzShaper::createGlyphBufferAdvance):

  • platform/graphics/skia/GlyphPageTreeNodeSkia.cpp: Added USE(HARFBUZZ_NG).

(WebCore::substituteWithVerticalGlyphs):

Source/WebKit/chromium:

  • features.gypi: Added use_harfbuzz_ng variable. If the value is set, USE(HARFBUZZ_NG) is defined.
2:25 AM Changeset in webkit [122315] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r122290.

Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-07-11

  • platform/qt/Skipped: Skip fast/forms/input-in-table-cell-no-value.html because ENABLE(INPUT_TYPE_DATE) is disabled
2:06 AM Changeset in webkit [122314] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Move tests that require ENABLE_INPUT_TYPE_* to TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=90948

Unreviewed EFL gardening. Move tests that require
ENABLE_INPUT_TYPE_* to be enabled from Skipped list to
TestExpectations.

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-11

  • platform/efl/Skipped:
  • platform/efl/TestExpectations:
2:04 AM Changeset in webkit [122313] by kinuko@chromium.org
  • 6 edits
    2 moves
    6 adds
    6 deletes in trunk

Web Inspector: Clean up FileSystem related code
https://bugs.webkit.org/show_bug.cgi?id=90592

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-07-11
Reviewed by Vsevolod Vlasov.

Clean up FileSystem related code in Inspector as follows:

  • Clean up layout tests and add test case for error case,
  • Fix error handling on request,
  • s/GetFileSystemRootTask/FileSystemRootRequest/g
  • s/ReadDirectoryTask/DirectoryContentRequest/g
  • s/ReadFileTask/FileContentRequest/g

Source/WebCore:

Tests: http/tests/inspector/filesystem/request-directory-content.html

http/tests/inspector/filesystem/request-file-content.html
http/tests/inspector/filesystem/request-filesystem-root.html
http/tests/inspector/filesystem/request-metadata.html

  • inspector/InspectorFileSystemAgent.cpp:

(WebCore):
(WebCore::InspectorFileSystemAgent::requestFileSystemRoot): Add early error handling.
(WebCore::InspectorFileSystemAgent::requestDirectoryContent): Add early error handling.
(WebCore::InspectorFileSystemAgent::requestMetadata): Add early error handling.
(WebCore::InspectorFileSystemAgent::requestFileContent): Add early error handling.

  • inspector/InspectorFileSystemAgent.h: Remove unused forward declaration and unused header.

(WebCore):
(InspectorFileSystemAgent):

  • inspector/front-end/FileSystemModel.js:

(WebInspector.FileSystemRequestManager.prototype.requestFileSystemRoot.requestAccepted):
(WebInspector.FileSystemRequestManager.prototype.requestFileSystemRoot): Add early error handling.
(WebInspector.FileSystemRequestManager.prototype.requestDirectoryContent.requestAccepted):
(WebInspector.FileSystemRequestManager.prototype.requestDirectoryContent): Add early error handling.
(WebInspector.FileSystemRequestManager.prototype.requestMetadata.requestAccepted):
(WebInspector.FileSystemRequestManager.prototype.requestMetadata): Add early error handling.
(WebInspector.FileSystemRequestManager.prototype.requestFileContent.requestAccepted):
(WebInspector.FileSystemRequestManager.prototype.requestFileContent): Add early error handling.

LayoutTests:

  • http/tests/inspector/filesystem/filesystem-test.js:

(initialize_FileSystemTest.InspectorTest.dumpFileSystemRootRequestResult):
(initialize_FileSystemTest.InspectorTest.dumpDirectoryContentRequestResult):
(initialize_FileSystemTest.InspectorTest.dumpMetadataRequestResult):
(initialize_FileSystemTest.InspectorTest.dumpFileContentRequestResult):
(initialize_FileSystemTest):

  • http/tests/inspector/filesystem/request-directory-content-expected.txt: Renamed from LayoutTests/http/tests/inspector/filesystem/read-directory-expected.txt.
  • http/tests/inspector/filesystem/request-directory-content.html: Renamed from LayoutTests/http/tests/inspector/filesystem/read-directory.html. Changed test steps to unnamed function array. Add failcase test.
  • http/tests/inspector/filesystem/request-file-content-expected.txt: Renamed from LayoutTests/http/tests/inspector/filesystem/read-file-expected.txt.
  • http/tests/inspector/filesystem/request-file-content.html: Renamed from LayoutTests/http/tests/inspector/filesystem/read-file.html. Changed test steps to unnamed function array. Add failcase test.
  • http/tests/inspector/filesystem/request-filesystem-root-expected.txt: Renamed from LayoutTests/http/tests/inspector/filesystem/get-filesystem-expected.txt.
  • http/tests/inspector/filesystem/request-filesystem-root.html: Renamed from LayoutTests/http/tests/inspector/filesystem/get-filesystem-root.html. Changed test steps to unnamed function array. Add failcase test.
  • http/tests/inspector/filesystem/request-metadata-expected.txt: Renamed from LayoutTests/http/tests/inspector/filesystem/get-metadata-expected.txt.
  • http/tests/inspector/filesystem/request-metadata.html: Renamed from LayoutTests/http/tests/inspector/filesystem/get-metadata.html. Changed test steps to unnamed function array. Add failcase test.
1:56 AM Changeset in webkit [122312] by caseq@chromium.org
  • 11 edits
    2 adds in trunk

Web Inspector: Forward message loop instrumentation data to frontend.
https://bugs.webkit.org/show_bug.cgi?id=89584

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-07-09
Reviewed by Yury Semikhatsky.

Transmit collected message loop tasks to inspector frontend.
Now "Program" should be a top-level event on browsers that
support message loop instrumentation.
Frontend was changed so that user will not see any changes.

Source/WebCore:

  • inspector/InspectorTimelineAgent.cpp:

(TimelineRecordType):
Added new event type - "Program"
(WebCore::InspectorTimelineAgent::willProcessTask):
Begin "Program" event.
(WebCore::InspectorTimelineAgent::didProcessTask):
Finish "Program" event.
(WebCore::InspectorTimelineAgent::setHeapSizeStatistic):
Do not add counters to "Program" events.
(WebCore):
(WebCore::InspectorTimelineAgent::innerSetHeapSizeStatistic):
Renamed from "setHeapSizeStatistic"

  • inspector/InspectorTimelineAgent.h:

(InspectorTimelineAgent):

  • inspector/front-end/MemoryStatistics.js:

(WebInspector.MemoryStatistics.prototype._onRecordAdded):
Unwraps "Program" events.
(WebInspector.MemoryStatistics.prototype._innerRecordAdded):
Renamed from "_onRecordAdded"

  • inspector/front-end/TimelineFrameController.js:

(WebInspector.TimelineFrameController.prototype._addRecord):
Unwraps "Program" events.
(WebInspector.TimelineFrameController.prototype._innerAddRecord):
Renamed from "_addRecord"

  • inspector/front-end/TimelineModel.js:
  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineCategoryStrips.prototype.update.appendRecord):
Filter out "Program" category.
(WebInspector.TimelineCategoryStrips.prototype.update):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._createStatusbarButtons):
Filter out "Program" category.
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
Unwraps "Program" events.

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.categories):
Added "Program" category.
(WebInspector.TimelinePresentationModel.recordStyle):
Ditto.
(WebInspector.TimelinePresentationModel.prototype.addRecord):
Unwraps "Program" events.
(WebInspector.TimelinePresentationModel.prototype._addRecord):
Renamed from "addRecord"

LayoutTests:

  • inspector/timeline/timeline-enum-stability-expected.txt:
1:34 AM Changeset in webkit [122311] by Csaba Osztrogonác
  • 4 edits
    3 adds in trunk/Tools

webkit-patch land should automatically add svn:mime-type for .png files
https://bugs.webkit.org/show_bug.cgi?id=75825

Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-07-11
Reviewed by Dirk Pranke.

Refactor the png.py to avoid code duplication.

  • Scripts/webkitpy/common/checksvnconfigfile.py: Added.

(check):
(config_file_path):
(errorstr_autoprop):
(errorstr_png):

  • Scripts/webkitpy/style/checkers/png.py:

(PNGChecker.check):

  • Scripts/webkitpy/tool/commands/download.py:

(Land):

  • Scripts/webkitpy/tool/steps/init.py:
  • Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py: Added.

(AddSvnMimetypeForPng):
(AddSvnMimetypeForPng.init):
(AddSvnMimetypeForPng.run):
(AddSvnMimetypeForPng._check_pngs):

  • Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py: Added.

(MockSCMDetector):
(MockSCMDetector.init):
(MockSCMDetector.display_name):
(AddSvnMimetypeForPngTest):
(AddSvnMimetypeForPngTest.test_run):

12:46 AM Changeset in webkit [122310] by bashi@chromium.org
  • 9 edits
    1 add in trunk/Source

[Chromium] Adding HarfBuzz-ng for Linux
https://bugs.webkit.org/show_bug.cgi?id=90362

Reviewed by Tony Chang.

Source/WebCore:

This patch adds harfbuzz-ng support for Chromium Linux port as a part of
transition from old harfbuzz. HarfBuzzFaceSkia.cpp implements harfbuzz-ng
callbacks by using Skia APIs. For now, the feature is enabled only when
WTF_USE_HARFBUZZ_NG is defined.

No new tests. No change in behavior now.

  • WebCore.gyp/WebCore.gyp: Added use_harfbuzz_ng variable and related files.
  • WebCore.gypi: Added HarfBuzzFaceSkia.cpp
  • platform/graphics/harfbuzz/FontHarfBuzz.cpp: Added USE(HARFBUZZ_NG).

(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp: Ditto.

(WebCore):
(WebCore::FontPlatformData::harfbuzzFace):

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h: Ditto.

(FontPlatformData):

  • platform/graphics/harfbuzz/ng/HarfBuzzFaceSkia.cpp: Added.

(WebCore):
(WebCore::SkiaScalarToHarfbuzzPosition):
(WebCore::SkiaGetGlyphWidthAndExtents):
(WebCore::harfbuzzGetGlyph):
(WebCore::harfbuzzGetGlyphHorizontalAdvance):
(WebCore::harfbuzzGetGlyphHorizontalOrigin):
(WebCore::harfbuzzGetGlyphExtents):
(WebCore::harfbuzzSkiaGetFontFuncs):
(WebCore::harfbuzzSkiaGetTable):
(WebCore::destroyPaint):
(WebCore::HarfBuzzFace::createFace):
(WebCore::HarfBuzzFace::createFont):
(WebCore::HarfBuzzShaper::createGlyphBufferAdvance):

  • platform/graphics/skia/GlyphPageTreeNodeSkia.cpp: Added USE(HARFBUZZ_NG).

(WebCore::substituteWithVerticalGlyphs):

Source/WebKit/chromium:

  • features.gypi: Added use_harfbuzz_ng variable. If the value is set, USE(HARFBUZZ_NG) is defined.
12:42 AM Changeset in webkit [122309] by hayato@chromium.org
  • 2 edits in trunk/Tools

Unreviewed gardening.
One more fix for r122292.

  • TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
12:42 AM Changeset in webkit [122308] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening, adding an image expectation for the
fast/forms/input-in-table-cell-no-value.html reftest, failing
after it was introduced in r122290 due to <input type='date'>
being used. The ENABLE_INPUT_TYPE_DATE feature is not enabled
on the Gtk port.

  • platform/gtk/TestExpectations:
12:27 AM Changeset in webkit [122307] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r122301.
http://trac.webkit.org/changeset/122301
https://bugs.webkit.org/show_bug.cgi?id=90947

Android builder started to fail (Requested by hayato on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-11

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
12:22 AM Changeset in webkit [122306] by kbr@google.com
  • 4 edits
    1 delete in trunk

compositing/webgl/webgl-nonpremultiplied-blend.html is flaky on Lion
https://bugs.webkit.org/show_bug.cgi?id=82412

Reviewed by Adrienne Walker.

Source/WebCore:

When compositing premultipliedAlpha=false WebGL canvases, use a separate
blend function for the alpha channel to avoid writing alpha < 1. This
makes the behavior more consistent with all other compositing results
and avoids situations where the alpha channel is preserved on some
platforms and discarded on others.

Covered by existing tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawTextureQuad):

Use separate alpha blend function when compositing premultipliedAlpha=false WebGL canvases.

LayoutTests:

Removed Chromium Mac-specific pixel results and failure expectations.

  • platform/chromium-mac/compositing/webgl/webgl-nonpremultiplied-blend-expected.png: Removed.
  • platform/chromium/TestExpectations:

Removed expectations of failure.

12:06 AM Changeset in webkit [122305] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

gc() doesn't exist in svg/animations/dynamic-modify-attributename-crash2.svg
https://bugs.webkit.org/show_bug.cgi?id=90945

Reviewed by Abhishek Arya.

  • svg/animations/dynamic-modify-attributename-crash2.svg: Include fast/js/resources/js-test-pre.js to have gc().
12:02 AM Changeset in webkit [122304] by hayato@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed gardening.

Android builder started to fail after r122292.
My best guess is that '--ant-compile' does not take an argument.

  • WebKitUnitTests.gyp:

Jul 10, 2012:

11:52 PM Changeset in webkit [122303] by yosin@chromium.org
  • 6 edits in trunk/Source

[Chromium-Windows] Implement functions for localized time format information
https://bugs.webkit.org/show_bug.cgi?id=90236

Reviewed by Kent Tamura.

Source/WebCore:

This patch introduces following localized time format related
functions:

  • localizedTimeFormatText
  • localizeShortTimeFormatText()
  • timeAMPMLabels

for Windows in feature flag: ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

See also:

ICU version: https://bugs.webkit.org/show_bug.cgi?id=89965
Mac version: https://bugs.webkit.org/show_bug.cgi?id=90237

Tests: WebKit/chromium/tests/LocalWinTest.cpp

  • platform/text/LocaleWin.cpp:

(WebCore::mapCharacterToDateTimeFieldType): Added.
(WebCore::convertWindowsTimeFormatToLDML): Added.
(WebCore::LocaleWin::timeFormatText): Added.
(WebCore::LocaleWin::shortTimeFormatText): Added.
(WebCore::LocaleWin::timeAMPMLabels): Added.

  • platform/text/LocaleWin.h:

(LocaleWin): Added time format related functions and variables.

  • platform/text/LocalizedDateWin.cpp:

(WebCore::localizedTimeFormatText): Added.
(WebCore::localizedShortTimeFormatText): Added.
(WebCore::timeAMPMLabels): Added.

Source/WebKit/chromium:

This patch introduces test cases for date and time format related
functions in LocaleWin.

  • tests/LocaleWinTest.cpp:

(LocaleWinTest):
(LocaleWinTest::dateComponents): Added.
(LocaleWinTest::msForDate): Moved inside class LocaleWinTest.
(LocaleWinTest::formatDate): Added.
(LocaleWinTest::parseDate): Added.
(LocaleWinTest::dateFormatText): Added.
(LocaleWinTest::firstDayOfWeek): Added.
(LocaleWinTest::monthLabel): Added.
(LocaleWinTest::weekDayShortLabel): Added.
(LocaleWinTest::timeFormatText): Added.
(LocaleWinTest::shortTimeFormatText): Added.
(LocaleWinTest::timeAMPMLabel): Added.
(TEST_F):

11:23 PM Changeset in webkit [122302] by commit-queue@webkit.org
  • 3 edits
    8 adds in trunk

Style not updated for element with display:none becoming first/last-child
https://bugs.webkit.org/show_bug.cgi?id=90356

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-07-10
Reviewed by Kent Tamura.

Source/WebCore:

Always trigger style recalc when an element without a renderer becomes the first/last-child.

Tests: fast/css/first-child-display-change.html

fast/css/last-child-display-change.html

  • dom/Element.cpp:

(WebCore::checkForSiblingStyleChanges):

LayoutTests:

  • fast/css/first-child-display-change-expected.txt: Added.
  • fast/css/first-child-display-change-inverse-expected.txt: Added.
  • fast/css/first-child-display-change-inverse.html: Added.
  • fast/css/first-child-display-change.html: Added.
  • fast/css/last-child-display-change-expected.txt: Added.
  • fast/css/last-child-display-change-inverse-expected.txt: Added.
  • fast/css/last-child-display-change-inverse.html: Added.
  • fast/css/last-child-display-change.html: Added.
11:19 PM Changeset in webkit [122301] by abarth@webkit.org
  • 2 edits in trunk/Tools

[Chromium] Merge final nits to DumpRenderTree.gyp for Android
https://bugs.webkit.org/show_bug.cgi?id=90920

Reviewed by Tony Chang.

This patch contains the last few small changes to DumpRenderTree.gyp
from the chromium-android branch. After this change, this file will be
fully merged.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
11:18 PM Changeset in webkit [122300] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

Remove 'true' from testRunner.dumpAsText(true).
NRWT complained that an '-expected.png' file was MISSING.

  • animations/animation-shorthand-name-order.html:
11:10 PM Changeset in webkit [122299] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk/Source/WebKit2

[WK2][EFL] Add Battery Status Provider
https://bugs.webkit.org/show_bug.cgi?id=90543

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-10
Reviewed by Kenneth Rohde Christiansen.

Define a battery status provider for WebKit2 EFL which
relies on WebCore::BatteryProviderEfl.

  • CMakeLists.txt: Add WebCore/Modules/battery to include

paths.

  • PlatformEfl.cmake: Add BatteryProvider class to CMake.
  • UIProcess/API/efl/BatteryProvider.cpp: Added.

(toBatteryProvider):
(startUpdatingCallback):
(stopUpdatingCallback):
(BatteryProvider::~BatteryProvider):
(BatteryProvider::create):
(BatteryProvider::BatteryProvider):
(BatteryProvider::startUpdating):
(BatteryProvider::stopUpdating):
(BatteryProvider::didChangeBatteryStatus):

  • UIProcess/API/efl/BatteryProvider.h: Added.

(BatteryProvider):

  • UIProcess/API/efl/ewk_context.cpp:

(_Ewk_Context): Add BatteryProvider to Ewk_Context.
(createDefaultEwkContext):
(ewk_context_default_get):

10:43 PM Changeset in webkit [122298] by shinyak@chromium.org
  • 14 edits in trunk/Source/WebCore

ShadowRoot should know its type in debug build.
https://bugs.webkit.org/show_bug.cgi?id=90933

Reviewed by Hajime Morita.

For assertion, ShadowRoot should know its type is UserAgentShadowRoot or AuthorShadowRoot.

This patch also renames ShadowRootCreationPurpose to ShadowRootType, since it is suitable
name for ShadowRoot to have.

No new tests, since it is used only for assertion.

  • dom/Element.cpp:

(WebCore::Element::ensureShadowRoot):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::create):

  • dom/ShadowRoot.h:

(ShadowRoot):
(WebCore::ShadowRoot::type):

  • html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::createShadowSubtree):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::createShadowSubtree):

  • html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::HTMLKeygenElement):

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::createShadowSubtree):

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::createShadowSubtree):

  • html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::createShadowSubtree):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::createShadowSubtree):

  • html/InputType.cpp:

(WebCore::InputType::destroyShadowSubtree): Asserts that ShadowRoot type is UserAgentShadowRoot.

  • html/shadow/TextFieldDecorationElement.cpp:

(WebCore::getDecorationRootAndDecoratedRoot):

  • svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::createShadowSubtree):

10:40 PM Changeset in webkit [122297] by hayato@chromium.org
  • 1 edit
    1 move in trunk/LayoutTests

Unreviewed gardening.

  • fast/css/deprecated-flexbox-auto-min-size-expected.txt: Renamed from LayoutTests/platform/chromium/fast/css/deprecated-flexbox-auto-min-size-expected.txt.
10:14 PM Changeset in webkit [122296] by hayato@chromium.org
  • 1 edit
    1 move in trunk/LayoutTests

12012-07-10 Hayato Ito <hayato@chromium.org>

Unreviewed gardening.

  • platform/chromium/fast/css/deprecated-flexbox-auto-min-size-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/css/deprecated-flexbox-auto-min-size-expected.txt.
9:45 PM Changeset in webkit [122295] by staikos@webkit.org
  • 2 edits in trunk/Source/WebCore

Add missing binding type String for IndexedDB.
https://bugs.webkit.org/show_bug.cgi?id=90351

Reviewed by Nikolas Zimmermann.

No new tests because it's already covered by IDB tests.

  • bindings/js/JSIDBAnyCustom.cpp:

(WebCore::toJS):

9:42 PM Changeset in webkit [122294] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[chromium] Make full texture updates explicit
https://bugs.webkit.org/show_bug.cgi?id=90507

Patch by Brian Anderson <brianderson@chromium.org> on 2012-07-10
Reviewed by Adrienne Walker.

Covered by existing tests.

  • platform/graphics/chromium/ScrollbarLayerChromium.cpp:

(WebCore::ScrollbarLayerChromium::updatePart):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::updateTiles):

  • platform/graphics/chromium/cc/CCTextureUpdater.cpp:

(WebCore::CCTextureUpdater::appendFullUpdate):
(WebCore::CCTextureUpdater::hasMoreUpdates):
(WebCore::CCTextureUpdater::update):
(WebCore::CCTextureUpdater::clear):

  • platform/graphics/chromium/cc/CCTextureUpdater.h:

(CCTextureUpdater):

9:34 PM Changeset in webkit [122293] by shinyak@chromium.org
  • 3 edits
    2 adds in trunk

Crash in nextLinePosition() due to accessing a removed root line box.
https://bugs.webkit.org/show_bug.cgi?id=90484

Reviewed by Abhishek Arya.

Source/WebCore:

When <object> element is reattached, the 'content' style is compared to the old style.
If it is not the same, a flag to recalc style is enabled. Because of this, the recalc style flag
is not cleared in updateLayoutIgnorePendingStyleSheets() in nextLinePosition(), and it causes
the second layout in isEditablePosition(p). Then 'RootInlineBox root' is invalidated, but
it's used after that.

When the content of the same <object> elements are compared, they should be the same.
However, operator== for ContentData is not implemented correctly (it compares a pointer instead of
content). So operator== does not hold for the content of the same <object> elements.

Test: editing/execCommand/crash-extend-selection-forward.html

  • rendering/style/ContentData.cpp:

(WebCore::operator==): Compares the instance of data instead of pointer.

LayoutTests:

This testcase should not be triggered in ASAN.

  • editing/execCommand/crash-extend-selection-forward-expected.txt: Added.
  • editing/execCommand/crash-extend-selection-forward.html: Added.
9:32 PM Changeset in webkit [122292] by abarth@webkit.org
  • 4 edits in trunk

[Chromium-Android] Add apk test targets for webkit_unit_tests and TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=90918

Reviewed by Tony Chang.

The rules are similar to what we have added for DumpRenderTree apk.
All references to gtest_target_type can be removed once we enable APK
tests on the all bots.

Source/WebKit/chromium:

  • WebKitUnitTests.gyp:

Tools:

  • TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
9:24 PM Changeset in webkit [122291] by jsbell@chromium.org
  • 4 edits in trunk/Source/WebCore

IndexedDB: Ensure transaction abort events are deterministic in multiprocess ports
https://bugs.webkit.org/show_bug.cgi?id=90412

Reviewed by Tony Chang.

In multi-process ports (e.g. Chromium), transaction aborts triggered on the front-end could
be initiated while a "success" event was in-flight from the back end. This would lead to
apparently flaky behavior when requests would sometimes report success and sometimes report
an error. Address this by having front-end triggered aborts do the abort steps immediately,
then send the async abort request to the back end.

No new tests - behavior in single process ports (and DRT) covered by existing
tests. Will enable currently disabled Chromium tests to be enabled (crbug.com/83226).

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::IDBRequest): Initialize a new m_requestAborted flag, used to prevent
dispatching if an in-flight request comes in after the abort.
(WebCore::IDBRequest::abort): Set flag to prevent double dispatching.
(WebCore::IDBRequest::onError): Handle aborted-then-received-event case.
(WebCore::IDBRequest::onSuccess): Ditto.
(WebCore::IDBRequest::onSuccessWithContinuation): Ditto.
(WebCore::IDBRequest::dispatchEvent): On uncaught error, trigger abort on transaction front-end.

  • Modules/indexeddb/IDBRequest.h:

(IDBRequest):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::abort): Do abort steps locally first, then notify back-end.
(WebCore::IDBTransaction::onAbort): If abort wasn't triggered locally, clean up is still necessary.

8:11 PM Changeset in webkit [122290] by jchaffraix@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION(r112113): absolutely positioned INPUT boxes with a table cell containing block have a 0px height
https://bugs.webkit.org/show_bug.cgi?id=89209

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/forms/input-in-table-cell-no-value.html

The issue comes from the layout code not properly resetting the overriden heigth between layouts.

The test case relies on a table cell as it requires a 2 pass layout. Between the 2 passes, different
code paths would be taken, leading to previous values being used to over-constrain the inner content.

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::layout):
Ensure consistent layout by resetting any overriden conditional height.

LayoutTests:

The 2 tests are very close and differ by the use of min-height. This forces some content to be visible in the expected result
but not in the original test case.

  • fast/forms/input-in-table-cell-no-value-expected.html: Added.
  • fast/forms/input-in-table-cell-no-value.html: Added.
7:26 PM Changeset in webkit [122289] by kbr@google.com
  • 2 edits in trunk/Tools

Add --no-build option to perf test runner
https://bugs.webkit.org/show_bug.cgi?id=90916

Reviewed by Ryosuke Niwa.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._parse_args):

Support --no-build option to perf tests, as in layout tests.

7:21 PM Changeset in webkit [122288] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebKit2

[Qt] Enable antialiasing for TextureMapper
https://bugs.webkit.org/show_bug.cgi?id=90915

Reviewed by Martin Robinson.

Enable the new antialiasing functionality for WebLayerTreeRendering.
This will make one-tile layers antialiased when using UI_SIDE_COMPOSITING.

  • UIProcess/WebLayerTreeRenderer.cpp:

(WebKit::WebLayerTreeRenderer::ensureRootLayer):

7:06 PM Changeset in webkit [122287] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/Tools

EWSTools should be able to build a chromium-ews bot from scratch
https://bugs.webkit.org/show_bug.cgi?id=90912

Reviewed by Eric Seidel.

I've been using this script to kick off the build process for the
chromium-ews bots on Google Compute Engine.

  • EWSTools/GoogleComputeEngine: Added.
  • EWSTools/GoogleComputeEngine/build-chromium-ews.sh: Added.
6:47 PM Changeset in webkit [122286] by commit-queue@webkit.org
  • 17 edits
    8 adds in trunk

Input elements with type=range do not have default touch handlers.
https://bugs.webkit.org/show_bug.cgi?id=88807

Patch by Kevin Ellis <kevers@chromium.org> on 2012-07-10
Reviewed by Antonio Gomes.

Source/WebCore:

This patch adds support for touch event handling on input elements
and dragging a slider with touch start and move events. Previously,
manipulating a slider on a touch screen required generation of
synthetic mouse events.

Tests: fast/events/touch/touch-slider-no-js-touch-listener.html

fast/events/touch/touch-slider.html

  • dom/Event.cpp:

(WebCore::Event::isTouchEvent):
(WebCore):

  • dom/Event.h:

(Event):

  • dom/Touch.cpp:

(WebCore::Touch::Touch):

  • dom/Touch.h:

(WebCore::Touch::absoluteLocation):
(Touch):

  • dom/TouchEvent.cpp:

(WebCore::TouchEvent::isTouchEvent):
(WebCore):

  • dom/TouchEvent.h:

(TouchEvent):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::HTMLInputElement):
(WebCore::HTMLInputElement::~HTMLInputElement):
(WebCore::HTMLInputElement::updateType):
(WebCore::HTMLInputElement::defaultEventHandler):

  • html/HTMLInputElement.h:

(HTMLInputElement):

  • html/InputType.cpp:

(WebCore):
(WebCore::InputType::handleTouchEvent):
(WebCore::InputType::hasTouchEventHandler):

  • html/InputType.h:

(WebCore):
(ClickHandlingState):
(InputType):

  • html/RangeInputType.cpp:

(WebCore):
(WebCore::RangeInputType::handleTouchEvent):
(WebCore::RangeInputType::hasTouchEventHandler):

  • html/RangeInputType.h:

(RangeInputType):

  • html/shadow/SliderThumbElement.h:

(SliderThumbElement):

Source/WebKit/chromium:

Adds flag to enable native handling of touch events for input elements
with type=range.

  • features.gypi:

LayoutTests:

Add automated test for manipulating an input slider via touch
events.

  • fast/events/touch/script-tests/touch-slider-no-js-touch-listener.js: Added.

(checkPosition):

  • fast/events/touch/script-tests/touch-slider.js: Added.

(onTouchStart):
(onTouchEnd):
(onKeyDown):
(checkPosition):

  • fast/events/touch/touch-slider-expected.txt: Added.
  • fast/events/touch/touch-slider-no-js-touch-listener-expected.txt: Added.
  • fast/events/touch/touch-slider-no-js-touch-listener.html: Added.
  • fast/events/touch/touch-slider.html: Added.
  • platform/chromium/fast/events/touch/touch-slider-expected.txt: Added.
  • platform/chromium/fast/events/touch/touch-slider-no-js-touch-listener-expected.txt: Added.
6:26 PM Changeset in webkit [122285] by morrita@google.com
  • 7 edits
    2 copies in branches/chromium/1180

Merge 122082 - Heap-use-after-free in WebCore::RenderObject::destroyAndCleanupAnonymousWrappers
https://bugs.webkit.org/show_bug.cgi?id=90480

Reviewed by Kent Tamura.

Source/WebCore:

If <select> has any insertion point, the attachment phase
unpextedly creates a renderer for distributed node and added to
the renderer of the <select>, which breaks an assumption and
results the crash.

This change tighten the childShouldCreateRenderer() to forbid
child renderers even from distributed nodes.

There is an exception as always: ValidationMessage can create a
ShadowRoot to <select>, which generates usually-forbidden child
renderers. This change introduces HTMLFormControlElement::validationMessageContains()
to let these renderers in.

Test: fast/dom/shadow/insertion-point-list-menu-crash.html

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::validationMessageContains):
(WebCore):

  • html/HTMLFormControlElement.h:

(HTMLFormControlElement):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::childShouldCreateRenderer):

  • html/ValidationMessage.cpp:

(WebCore::ValidationMessage::contains):
(WebCore):

  • html/ValidationMessage.h:

(WebCore):
(ValidationMessage):

LayoutTests:

  • fast/dom/shadow/insertion-point-list-menu-crash-expected.txt: Added.
  • fast/dom/shadow/insertion-point-list-menu-crash.html: Added.

TBR=morrita@google.com
Review URL: https://chromiumcodereview.appspot.com/10694124

6:13 PM Changeset in webkit [122284] by adamk@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] REGRESSION(r121909): m_currentInputEvent never set
https://bugs.webkit.org/show_bug.cgi?id=90914

Reviewed by Abhishek Arya.

The always-null m_currentInputEvent causes a regression when
middle-clicking on a link that calls window.open('...', '_blank');
that new tab should open in the background, but instead opens in the
foreground (see code in ChromeClientImpl::getNavigationPolicy()).

Fix usage of TemporaryChange to specify a local variable name so that
m_currentInputEvent is actually set for the duration of handleInputEvent.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleInputEvent): Name the TemporaryChange instance.

6:07 PM Changeset in webkit [122283] by morrita@google.com
  • 1 edit in branches/chromium/1180/Source/WebKit/chromium/src/ContextFeaturesClientImpl.cpp

BUG=134398
Review URL: https://chromiumcodereview.appspot.com/10700153/

5:41 PM Changeset in webkit [122282] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Re-factoring recalcColumn in AutoTableLayout.cpp for readability
https://bugs.webkit.org/show_bug.cgi?id=89636

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-07-10
Reviewed by Julien Chaffraix.

No test case required. Code re-factoring.

  • rendering/AutoTableLayout.cpp:

Added a const integer place holder for 32760.

(WebCore::AutoTableLayout::recalcColumn):

Changes :
1) Moved the continue statement above the bool cellHasContent for an early return.
2) Replaced the constant 32760 by a placeholder.
3) Initialization of columnLayout max and min logical widths is made common for both cells having col span == 1 and span > 1.
4) Removed redundant check for cell logical width type.

5:18 PM Changeset in webkit [122281] by kbr@google.com
  • 4 edits in trunk/LayoutTests

Line directive test in fast/canvas/webgl/glsl-conformance.html is incorrect
https://bugs.webkit.org/show_bug.cgi?id=90897

Reviewed by Adrienne Walker.

Removed an invalid test and adjusted the test expectations.

  • fast/canvas/webgl/glsl-conformance-expected.txt:
  • fast/canvas/webgl/glsl-conformance.html:
  • platform/chromium/TestExpectations:
5:13 PM FeatureFlags edited by tkent@chromium.org
Remove a comment about Hixie76 protocol for WEB_SOCkETS (diff)
4:53 PM Changeset in webkit [122280] by abarth@webkit.org
  • 29 edits in trunk/Source

WebCore::Settings for Hixie76 WebSocket protocol doesn't do anything and should be removed
https://bugs.webkit.org/show_bug.cgi?id=90910

Reviewed by Eric Seidel.

Source/WebCore:

We've already removed the code that implements Hixie76 WebSockets. This
patch just removes the WebCore::Setting that used to control which
WebSocket protocol version we'd use.

I've left the WebKit-layer APIs in place, but they now don't do
anything. I'll remove all the Chromium callers shortly.

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(Settings):

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

Source/WebKit/chromium:

  • public/WebSettings.h:

(WebKit::WebSettings::setHixie76WebSocketProtocolEnabled):

  • src/WebSettingsImpl.cpp:
  • src/WebSettingsImpl.h:

(WebSettingsImpl):

  • src/WebSharedWorkerImpl.cpp:

(WebKit::WebSharedWorkerImpl::initializeLoader):

Source/WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

  • webkit/webkitwebview.cpp:

(webkit_web_view_update_settings):

Source/WebKit/mac:

  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences setHixie76WebSocketProtocolEnabled:]):
(-[WebPreferences isHixie76WebSocketProtocolEnabled]):

  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Source/WebKit/win:

  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::setHixie76WebSocketProtocolEnabled):
(WebPreferences::hixie76WebSocketProtocolEnabled):

  • WebView.cpp:

(WebView::notifyPreferencesChanged):

Source/WebKit2:

  • Shared/WebPreferencesStore.h:

(WebKit):

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetHixie76WebSocketProtocolEnabled):
(WKPreferencesGetHixie76WebSocketProtocolEnabled):

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

4:39 PM Changeset in webkit [122279] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Add alecflett to the list of committers
https://bugs.webkit.org/show_bug.cgi?id=90903

Patch by Alec Flett <alecflett@chromium.org> on 2012-07-10
Reviewed by Ojan Vafai.

  • Scripts/webkitpy/common/config/committers.py:
4:36 PM Changeset in webkit [122278] by pdr@google.com
  • 4 edits
    2 adds in trunk

Crash due to SVG animation element not removed from target (before reset)
https://bugs.webkit.org/show_bug.cgi?id=90750

Reviewed by Abhishek Arya.

Source/WebCore:

Previously we were not removing an animation element from
SVGDocumentExtensions::m_animatedElements which led to a crash.
This change properly removes animation elements in resetTargetElement
which both fixes this bug and will prevent others from hitting it in
the future.

Test: svg/animations/dynamic-modify-attributename-crash2.svg

  • svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::removeAllAnimationElementsFromTarget):

removeAllAnimationElementsFromTarget now adds all the animation elements
to a vector and iterates over it because the changes to resetTargetElement
would have caused us to modify the underlying hashset as we iterated. Note that
before we deleted animationElementsForTarget in removeAllAnimationElementsFromTarget
but that logic is now handled in removeAnimationElementFromTarget which is called
during resetTargetElement.

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::removedFrom):

Because of the changes in resetTargetElement, removedFrom was able to be
refactored. This patch changes removedFrom to call resetTargetElement rather
than have duplicated logic. There is a very small change in logic here:
animationAttributeChanged() is now called in removedFrom().

(WebCore::SVGSMILElement::resetTargetElement):

resetTargetElement now fully resets the target, including removing it from
m_animatedElements. This will prevent future instances of this bug.

LayoutTests:

  • svg/animations/dynamic-modify-attributename-crash2-expected.txt: Added.
  • svg/animations/dynamic-modify-attributename-crash2.svg: Added.
4:22 PM Changeset in webkit [122277] by dino@apple.com
  • 2 adds in trunk/LayoutTests/animations

Add the test files that I forgot to commit (AGAIN!) in r122271

  • animations/animation-shorthand-name-order-expected.txt: Added.
  • animations/animation-shorthand-name-order.html: Added.
4:10 PM Changeset in webkit [122276] by abarth@webkit.org
  • 2 edits in trunk/Websites/bugs.webkit.org

bugs.webkit.org has mixed content
https://bugs.webkit.org/show_bug.cgi?id=90907

Reviewed by Eric Seidel.

Now that we detect http XMLHttpRequests as mixed content, I've noticed
that we're loading committers.py over http instead of https. For
better security, we should use https.

  • committers-autocomplete.js:
4:06 PM Changeset in webkit [122275] by commit-queue@webkit.org
  • 8 edits in trunk/Source

[Qt] Repaint counter for accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=90116

Patch by Helder Correia <Helder Correia> on 2012-07-10
Reviewed by Noam Rosenthal.

No new tests, just introducing a debug feature.

For this feature to be enabled, the environment variable
QT_WEBKIT_SHOW_COMPOSITING_DEBUG_VISUALS must be set to 1. Once enabled,
both repaint counters and tile borders will be painted.

Important notes:

  • Only WebKit2 is targetted for now.
  • There is no integration with Preferences. That aproach was

taken initially but revealed complex and overkill for such a
debugging-only functionality. Thus, to disable it simply restart with
the environment variable unset or set to some other value.

A Qt-specific drawRepaintCounter() function was added to
TextureMapperGL. A QImage is used as scratch buffer to paint borders and
counters. It is then uploaded to a BitmapTexture acquired from the pool
and finally draw by TextureMapper. The actual compositing happens inside
LayerBackingStore::paintToTextureMapper(). Each LayerBackingStoreTile
now has a repaint counter which gets incremented in
LayerBackingStore::updateTile().

Source/WebCore:

  • platform/graphics/texmap/TextureMapper.h:
  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore):
(WebCore::TextureMapperGL::drawRepaintCounter):

  • platform/graphics/texmap/TextureMapperGL.h:
  • platform/graphics/texmap/TextureMapperImageBuffer.h:

Source/WebKit2:

  • UIProcess/texmap/LayerBackingStore.cpp:

(WebKit::LayerBackingStore::updateTile):
(WebKit):
(WebKit::shouldShowTileDebugVisuals):
(WebKit::LayerBackingStore::paintToTextureMapper):

  • UIProcess/texmap/LayerBackingStore.h:

(WebKit::LayerBackingStoreTile::LayerBackingStoreTile):
(LayerBackingStoreTile):
(WebKit::LayerBackingStoreTile::incrementRepaintCount):
(WebKit::LayerBackingStoreTile::repaintCount):

3:53 PM Changeset in webkit [122274] by gyuyoung.kim@samsung.com
  • 3 edits in trunk

[CMAKE] Add missing feature macros
https://bugs.webkit.org/show_bug.cgi?id=90890

Reviewed by Eric Seidel.

ENABLE_CSS_EXCLUSIONS, ENABLE_CSS_REGIONS, ENABLE_TEXT_AUTOSIZING macros
haven't defined in cmake feature list.

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:
3:49 PM Changeset in webkit [122273] by wangxianzhu@chromium.org
  • 2 edits in trunk/Tools

try

3:48 PM Changeset in webkit [122272] by danakj@chromium.org
  • 10 edits in trunk/Source

[chromium] Replace use of ManagedTexture with CCScopedTexture for impl thread and remove implTextureManager from LayerRendererChromium
https://bugs.webkit.org/show_bug.cgi?id=90841

Reviewed by Adrienne Walker.

Source/WebCore:

Remove the TextureManager from LayerRendererChromium, which was the last
instance of the class in the compositor. Instead of using ManagedTexture
objects for RenderPass textures, use instances of CCScopedTexture, which
manage the lifetime of the allocated texture ids. TextureManager will be
removed entirely once all callers of memoryUseBytes() have been removed.

No new tests. No change in behaviour.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::releaseRenderPassTextures):
(WebCore):
(WebCore::LayerRendererChromium::renderPassTextureSize):
(WebCore::LayerRendererChromium::renderPassTextureFormat):
(WebCore::LayerRendererChromium::decideRenderPassAllocationsForFrame):
(WebCore::LayerRendererChromium::haveCachedResourcesForRenderPassId):
(WebCore::LayerRendererChromium::drawQuad):
(WebCore::applyFilters):
(WebCore::LayerRendererChromium::drawBackgroundFilters):
(WebCore::LayerRendererChromium::drawRenderPassQuad):
(WebCore::LayerRendererChromium::drawHeadsUpDisplay):
(WebCore::LayerRendererChromium::getFramebufferTexture):
(WebCore::LayerRendererChromium::isCurrentRenderPass):
(WebCore::LayerRendererChromium::useRenderPass):
(WebCore::LayerRendererChromium::useScopedTexture):
(WebCore::LayerRendererChromium::bindFramebufferToTexture):
(WebCore::LayerRendererChromium::initializeSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:

(WebCore):
(LayerRendererChromium):

  • platform/graphics/chromium/TrackingTextureAllocator.cpp:

(WebCore::TrackingTextureAllocator::TrackingTextureAllocator):
(WebCore::TrackingTextureAllocator::createTexture):

  • platform/graphics/chromium/TrackingTextureAllocator.h:

(WebCore::TrackingTextureAllocator::create):
(TrackingTextureAllocator):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::draw):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h:

(WebCore):
(CCHeadsUpDisplay):

  • platform/graphics/chromium/cc/CCRenderer.h:

(WebCore):
(CCRenderer):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:
3:45 PM Changeset in webkit [122271] by dino@apple.com
  • 3 edits in trunk

REGRESSION (r109610): Order of values in shorthand animation makes a difference
https://bugs.webkit.org/show_bug.cgi?id=84533
<rdar://problem/11831924>
<rdar://problem/11815787>

Reviewed by Simon Fraser.

Source/WebCore:

A previous revision (r109610) updated the parsing of the animation shorthand
to make sure that animation-name wouldn't clobber other styles. The side effect
of this was that we'd no longer find animation-name if it wasn't first in the
list. This commit reverts the change and fixes it in a different way, by always
parsing animation-name as the last property in the shorthand. This means that
keywords for timing functions, fill modes and iteration will match before
animation name. In other words, if you want an animation called "forwards"
you should use the longhand property, because the shorthand will first match
that against animation-fill-mode.

Test: animations/animation-shorthand-name-order.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseAnimationShorthand): make a new array of longhand
properties to check for, with name as the last entry rather than the first.
Use this array to test the properties in the shorthand.

LayoutTests:

A new test that exercises many different variants of the animation shorthand
property, putting the animation name in different spots in the list of values.

  • animations/animation-shorthand-name-order-expected.txt: Added.
  • animations/animation-shorthand-name-order.html: Added.
3:14 PM Changeset in webkit [122270] by commit-queue@webkit.org
  • 9 edits
    9 adds in trunk/Source/WebKit2

[WK2] Add Vibration API support for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=90058

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-10
Reviewed by Anders Carlsson.

Add support for Vibration API to WebKit2.

  • CMakeLists.txt:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Platform/CoreIPC/MessageID.h:
  • Shared/API/c/WKBase.h:
  • Shared/APIObject.h:
  • Target.pri:
  • UIProcess/API/C/WKAPICast.h:

(WebKit):

  • UIProcess/API/C/WKVibration.cpp: Added.

(WKVibrationGetTypeID):
(WKVibrationSetProvider):

  • UIProcess/API/C/WKVibration.h: Added.
  • UIProcess/WebVibrationProvider.cpp: Added.

(WebKit):
(WebKit::WebVibrationProvider::vibrate):
(WebKit::WebVibrationProvider::cancelVibration):

  • UIProcess/WebVibrationProvider.h: Added.

(WebKit):
(WebVibrationProvider):

  • UIProcess/WebVibrationProxy.cpp: Added.

(WebKit):
(WebKit::WebVibrationProxy::create):
(WebKit::WebVibrationProxy::WebVibrationProxy):
(WebKit::WebVibrationProxy::~WebVibrationProxy):
(WebKit::WebVibrationProxy::invalidate):
(WebKit::WebVibrationProxy::initializeProvider):
(WebKit::WebVibrationProxy::didReceiveMessage):
(WebKit::WebVibrationProxy::vibrate):
(WebKit::WebVibrationProxy::cancelVibration):

  • UIProcess/WebVibrationProxy.h: Added.

(CoreIPC):
(WebKit):
(WebVibrationProxy):
(WebKit::WebVibrationProxy::clearContext):
(WebKit::WebVibrationProxy::type):

  • UIProcess/WebVibrationProxy.messages.in: Added.
  • WebProcess/WebCoreSupport/WebVibrationClient.cpp: Added.

(WebKit):
(WebKit::WebVibrationClient::vibrate):
(WebKit::WebVibrationClient::cancelVibration):
(WebKit::WebVibrationClient::vibrationDestroyed):

  • WebProcess/WebCoreSupport/WebVibrationClient.h: Added.

(WebKit):
(WebVibrationClient):
(WebKit::WebVibrationClient::WebVibrationClient):
(WebKit::WebVibrationClient::~WebVibrationClient):

3:11 PM Changeset in webkit [122269] by kseo@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix a potential bug of BitmapImage::frameCount().
https://bugs.webkit.org/show_bug.cgi?id=90756

Patch by Huang Dongsung <luxtella@company100.net> on 2012-07-10
Reviewed by Simon Fraser.

If an ImageDecoder is not yet initialized, m_source.frameCount() returns 0. This
does not mean that the frame count is actually 0. So we must set
m_haveFrameCount to true only when m_frameCount is not 0.

The current code is okay because BitmapImage::frameCount() is never called
before the decoder is initialized. However, this no longer holds true once we
introduce parallel image decoders.

No new tests, no behavior change.

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::frameCount):

3:08 PM Changeset in webkit [122268] by ojan@chromium.org
  • 2 edits in trunk/Source/WebCore

Build fix. Removing unused variable from http://trac.webkit.org/changeset/122264.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeContentLogicalHeightUsing):

3:03 PM Changeset in webkit [122267] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

HTMLPropertiesCollection should share more code with HTMLCollection
https://bugs.webkit.org/show_bug.cgi?id=90842

Reviewed by Anders Carlsson.

Got rid of HTMLPropertiesCollection::m_cache, and added m_itemRefElements, m_propertyNames, m_propertyCache,
m_hasPropertyNameCache, and m_hasItemRefElements to HTMLPropertiesCollection itself. These are caches specific
to HTMLPropertiesCollection. Note that hasNameCache has been renamed to m_hasPropertyNameCache and itemRefElementPosition
has been replaced by cachedElementsArrayOffset() in HTMLCollectionCacheBase (also used in HTMLFormCollection).

Also deleted all methods on m_cache except updatePropertyCache since caches can be accessed directly from
HTMLPropertiesCollection.

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::invalidateCacheIfNeeded):
(WebCore::HTMLCollection::invalidateCache):

  • html/HTMLCollection.h:

(HTMLCollection):

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::HTMLPropertiesCollection):
(WebCore):
(WebCore::HTMLPropertiesCollection::updateRefElements):
(WebCore::HTMLPropertiesCollection::itemAfter):
(WebCore::HTMLPropertiesCollection::calcLength):
(WebCore::HTMLPropertiesCollection::cacheFirstItem):
(WebCore::HTMLPropertiesCollection::item):
(WebCore::HTMLPropertiesCollection::findProperties):
(WebCore::HTMLPropertiesCollection::updateNameCache):
(WebCore::HTMLPropertiesCollection::names):
(WebCore::HTMLPropertiesCollection::namedItem):
(WebCore::HTMLPropertiesCollection::hasNamedItem):

  • html/HTMLPropertiesCollection.h:

(HTMLPropertiesCollection):
(WebCore::HTMLPropertiesCollection::clearCache):
(WebCore::HTMLPropertiesCollection::updatePropertyCache):

3:01 PM Changeset in webkit [122266] by cevans@google.com
  • 1 edit in branches/chromium/1180/Source/WebCore/dom/NodeRareData.h

Merge 120983 - Clang build fix.

  • dom/NodeRareData.h:

TBR=rniwa@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10701129

2:58 PM Changeset in webkit [122265] by rafaelw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Removing duplicated line from TestExpectations.

  • platform/chromium/TestExpectations:
2:45 PM Changeset in webkit [122264] by ojan@chromium.org
  • 14 edits
    4 adds in trunk

Add support for min-height:auto and min-width:auto
https://bugs.webkit.org/show_bug.cgi?id=88437

Reviewed by Tony Chang.

Source/WebCore:

Right now auto does the same thing as min-height/min-width:0.
For flex-items it should be the same as min-content (followup patch).
http://dev.w3.org/csswg/css3-flexbox/#min-size-auto

Tests: fast/css/auto-min-size.html

fast/css/deprecated-flexbox-auto-min-size.html

  • WebCore.order:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Return 0px for the computed value of auto.

  • css/CSSParser.cpp:

(WebCore::CSSParser::validWidth):
(WebCore):
(WebCore::CSSParser::validHeight):
(WebCore::CSSParser::parseValue):

  • css/CSSParser.h:

(CSSParser):
Restructure width/height parsing to reduce code duplication and make it easier
to add auto as a valid min value.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::adjustSizeConstraints):
This code was unnecessarily checking intrinsicOrAuto since auto was previously
not an allowed value for minWidth/minHeight.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
(WebCore::RenderBox::sizesLogicalWidthToFitContent):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computeLogicalHeightUsing):
(WebCore::RenderBox::computeContentLogicalHeightUsing):
(WebCore::RenderBox::computeReplacedLogicalWidth):
(WebCore::RenderBox::computeReplacedLogicalWidthRespectingMinMaxWidth):
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeight):
(WebCore::RenderBox::computeReplacedLogicalHeightRespectingMinMaxHeight):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalHeight):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
Need to pass a SizeType to all these methods so that we know if the Length
we're working with is a min length since auto has a different meaning now
for min lengths.

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::allowedChildFlex):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computePreferredLogicalWidths):
(WebCore::RenderFlexibleBox::computeAvailableFreeSpace):
(WebCore::RenderFlexibleBox::lineBreakLength):
(WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeReplacedLogicalWidth):
(WebCore::RenderReplaced::computeReplacedLogicalHeight):

  • rendering/RenderScrollbarPart.cpp:

(WebCore::calcScrollbarThicknessUsing):
(WebCore::RenderScrollbarPart::computeScrollbarWidth):
(WebCore::RenderScrollbarPart::computeScrollbarHeight):

  • rendering/style/RenderStyle.h:

Default minHeight/minWidth to auto instead of 0px.

LayoutTests:

  • fast/css/auto-min-size-expected.txt: Added.
  • fast/css/auto-min-size.html: Added.
  • fast/css/deprecated-flexbox-auto-min-size.html: Added.
  • platform/chromium-linux/fast/css/deprecated-flexbox-auto-min-size-expected.txt: Added.
2:21 PM Changeset in webkit [122263] by cevans@google.com
  • 1 edit in branches/chromium/1180/Source/WebCore/dom/NodeRareData.h

Merge 121105
BUG=134088
Review URL: https://chromiumcodereview.appspot.com/10704139

2:21 PM Changeset in webkit [122262] by jsbell@chromium.org
  • 3 edits in trunk/LayoutTests

[Chromium] IndexedDB: Need test of Typed Arrays
https://bugs.webkit.org/show_bug.cgi?id=81979

Reviewed by Tony Chang.

Verify storage of Typed Arrays (Uint8Array and friends). Checks that
these types are stored and read back with types and data intact. Also
add an index to the object store, so that key paths are evaluated
against each type on every write operation.

  • storage/indexeddb/structured-clone-expected.txt:
  • storage/indexeddb/structured-clone.html:
2:13 PM Changeset in webkit [122261] by wangxianzhu@chromium.org
  • 2 edits in trunk/Tools

[Chromium-Android] Fix typos in chromium_android.py in r151492
https://bugs.webkit.org/show_bug.cgi?id=90904

Reviewed by Ojan Vafai.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.setup_test_run):

1:57 PM Changeset in webkit [122260] by danakj@chromium.org
  • 2 edits in branches/chromium/1180/Source/WebCore/platform/graphics/chromium/cc

Merge 121450 - [chromium] Should schedule a commit when dropping contents textures
https://bugs.webkit.org/show_bug.cgi?id=90031

Patch by James Robinson <jamesr@chromium.org> on 2012-06-28
Reviewed by Adrienne Walker.

Source/WebCore:

If we're dropping contents textures on the impl thread, we need to schedule a commit to pick up new contents at
the next commit opportunity. Also adds some traces to make debugging issues like this easier.

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::commitComplete):
(WebCore::CCLayerTreeHostImpl::canDraw):
(WebCore::CCLayerTreeHostImpl::releaseContentsTextures):

  • platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::processScheduledActions):

Source/WebKit/chromium:

Adds a somewhat vacuous test unit test for committing when releasing textures.

  • tests/CCLayerTreeHostImplTest.cpp:

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10694117

1:54 PM Changeset in webkit [122259] by danakj@chromium.org
  • 29 edits in branches/chromium/1180/Source

Merge 121076 - [chromium] LayerRendererChromium is not getting visibility messages in single threaded compositing mode.
https://bugs.webkit.org/show_bug.cgi?id=89045

Reviewed by Adrienne Walker.

Based on patch by Michal Mocny <mmocny@google.com>.

Source/WebCore:

Invariants:

1.) We never commit (paint, animate, any of it) when not visible on the main thread -except- for
compositeAndReadback, regardless of threaded vs non-threaded mode
2.) CCLayerTreeHost::m_contentsTextureManager's memory budget is only set by updateLayers() when we are going to
make a frame and is always set to a non-zero value
3.) Zero-sized allocations from the GPU process are always serviced immediately on the impl thread. Non-zero
allocations are met in the next frame, whenever we would produce that frame according to our usual frame
scheduling logic.
4.) The impl thread always knows the set of currently-allocated managed texture IDs and can delete them all
whenever it likes without needing the main thread to be responsive.

Details:

[See original commit...]

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererGpuMemoryAllocationChangedCallbackAdapter::onGpuMemoryAllocationChangedOnImpl):
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::setVisible):
(WebCore::LayerRendererChromium::setGpuMemoryAllocation):
(WebCore):
(WebCore::LayerRendererChromium::swapBuffers):
(WebCore::LayerRendererChromium::getFramebufferPixels):

  • platform/graphics/chromium/LayerRendererChromium.h:

(WebCore):
(LayerRendererChromium):

  • platform/graphics/chromium/TextureManager.cpp:

(WebCore::TextureManager::evictAndRemoveAllDeletedTextures):
(WebCore):

  • platform/graphics/chromium/TextureManager.h:

(TextureAllocator):
(TextureManager):

  • platform/graphics/chromium/TrackingTextureAllocator.cpp:

(WebCore::TrackingTextureAllocator::createTexture):
(WebCore::TrackingTextureAllocator::deleteTexture):
(WebCore):
(WebCore::TrackingTextureAllocator::deleteAllTextures):

  • platform/graphics/chromium/TrackingTextureAllocator.h:

(TrackingTextureAllocator):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initializeLayerRenderer):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::evictAllContentTextures):
(WebCore::CCLayerTreeHost::updateLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::commitComplete):
(WebCore::CCLayerTreeHostImpl::canDraw):
(WebCore::CCLayerTreeHostImpl::context):
(WebCore::CCLayerTreeHostImpl::releaseContentsTextures):
(WebCore):
(WebCore::CCLayerTreeHostImpl::setMemoryAllocationLimitBytes):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImplClient):
(WebCore::CCLayerTreeHostImpl::contentsTexturesWerePurgedSinceLastCommit):
(WebCore::CCLayerTreeHostImpl::memoryAllocationLimitBytes):
(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCProxy.h:

(CCProxy):

  • platform/graphics/chromium/cc/CCRenderer.h:

(CCRendererClient):

  • platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::beginFrameComplete):
(WebCore::CCScheduler::beginFrameAborted):
(WebCore):
(WebCore::CCScheduler::didSwapBuffersComplete):
(WebCore::CCScheduler::didLoseContext):
(WebCore::CCScheduler::didRecreateContext):
(WebCore::CCScheduler::vsyncTick):

  • platform/graphics/chromium/cc/CCScheduler.h:

(CCScheduler):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::beginFrameAborted):
(WebCore):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::setVisible):
(WebCore):
(WebCore::CCSingleThreadProxy::stop):
(WebCore::CCSingleThreadProxy::commitAndComposite):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(CCSingleThreadProxy):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::setVisible):
(WebCore):
(WebCore::CCThreadProxy::setVisibleOnImplThread):
(WebCore::CCThreadProxy::scheduledActionBeginFrame):
(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::beginFrameAbortedOnImplThread):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal):
(WebCore::CCThreadProxy::layerTreeHostClosedOnImplThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):
(BeginFrameAndCommitState):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::~CCVideoLayerImpl):
(WebCore::CCVideoLayerImpl::willDraw):
(WebCore::CCVideoLayerImpl::willDrawInternal):
(WebCore::CCVideoLayerImpl::FramePlane::allocateData):
(WebCore::CCVideoLayerImpl::FramePlane::freeData):
(WebCore::CCVideoLayerImpl::allocatePlaneData):
(WebCore::CCVideoLayerImpl::freePlaneData):
(WebCore::CCVideoLayerImpl::freeUnusedPlaneData):
(WebCore::CCVideoLayerImpl::didLoseContext):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:

(FramePlane):

Source/WebKit/chromium:

Update various test fixtures and tests to cover scheduling, visibility, and resource allocation changes.

  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/CCLayerTreeHostTest.cpp:

(CCLayerTreeHostTestAbortFrameWhenInvisible):
(WTF::CCLayerTreeHostTestAbortFrameWhenInvisible::CCLayerTreeHostTestAbortFrameWhenInvisible):
(WTF::CCLayerTreeHostTestAbortFrameWhenInvisible::beginTest):
(WTF::CCLayerTreeHostTestAbortFrameWhenInvisible::afterTest):
(WTF):
(WTF::TEST_F):
(WTF::CCLayerTreeHostTestLayerOcclusion::beginTest):
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest):
(WTF::CCLayerTreeHostTestManySurfaces::beginTest):

  • tests/CCSchedulerStateMachineTest.cpp:

(WebCore::TEST):

  • tests/CCTiledLayerTestCommon.h:
  • tests/FakeWebGraphicsContext3D.h:

(WebKit::FakeWebGraphicsContext3D::FakeWebGraphicsContext3D):
(FakeWebGraphicsContext3D):
(WebKit::FakeWebGraphicsContext3D::createTexture):

  • tests/LayerRendererChromiumTest.cpp:

(TEST_F):

  • tests/TiledLayerChromiumTest.cpp:

TBR=jamesr@google.com
Review URL: https://chromiumcodereview.appspot.com/10690121

1:54 PM Changeset in webkit [122258] by ojan@chromium.org
  • 3 edits in trunk/Tools

webkit-patch rebaseline doesn't work for audio/pixel tests
https://bugs.webkit.org/show_bug.cgi?id=90905

Reviewed by Adam Barth.

We just need to pass the correct suffix list to rebaseline-test-internal
and optimize-baselines. By default, pass all suffixes.

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(Rebaseline):
(Rebaseline.init):
(Rebaseline._suffixes_to_update):
(Rebaseline.execute):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(test_rebaseline_multiple_builders_and_tests_command_line):

1:47 PM Changeset in webkit [122257] by danakj@chromium.org
  • 6 edits in branches/chromium/1180/Source

Merge 120858 - [chromium] Separate LayerRenderer initialization from updateLayers
https://bugs.webkit.org/show_bug.cgi?id=89525

Reviewed by Adrienne Walker.

Source/WebCore:

This adds an explicit call to initialize the layer renderer of a given CCLayerTreeHost instead of having it be
implicit in updateLayers(). This way the proxies can control the initialization sequence more closely and do
useful work between the two calls.

Refactor, no change in behavior. Covered by existing tests.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::compositeAndReadback):
(WebCore::CCLayerTreeHost::initializeLayerRendererIfNeeded):
(WebCore):
(WebCore::CCLayerTreeHost::updateLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::commitAndComposite):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::beginFrame):

Source/WebKit/chromium:

Update tests to call initializeLayerRendererIfNeeded() before calling updateLayers() to reflect what the proxies
do.

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestLayerOcclusion::beginTest):
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest):
(WTF::CCLayerTreeHostTestManySurfaces::beginTest):

  • tests/TiledLayerChromiumTest.cpp:

TBR=jamesr@google.com
Review URL: https://chromiumcodereview.appspot.com/10702135

1:39 PM Changeset in webkit [122256] by abarth@webkit.org
  • 119 edits in trunk

Remove LayoutTestController and WebKitTestRunner support for Hixie76 WebSockets
https://bugs.webkit.org/show_bug.cgi?id=90853

Reviewed by Eric Seidel.

Tools:

WebKit no longer implements the Hixie76 version of the WebSocket
protocol. We don't need to support it in our test framework.

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::overridePreference):

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::reset):
(WebPreferences::applyTo):

  • DumpRenderTree/chromium/WebPreferences.h:

(WebPreferences):

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::overridePreference):

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::resetSettings):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::overridePreference):

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

LayoutTests:

There's no need to explicitly disable the Hixie76 protocol because it
no longer exists in WebKit.

  • http/tests/websocket/tests/hybi/alert-in-event-handler.html:
  • http/tests/websocket/tests/hybi/bad-handshake-crash.html:
  • http/tests/websocket/tests/hybi/bad-sub-protocol-control-chars.html:
  • http/tests/websocket/tests/hybi/bad-sub-protocol-empty.html:
  • http/tests/websocket/tests/hybi/bad-sub-protocol-non-ascii.html:
  • http/tests/websocket/tests/hybi/binary-type.html:
  • http/tests/websocket/tests/hybi/broken-utf8.html:
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html:
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close.html:
  • http/tests/websocket/tests/hybi/client-close.html:
  • http/tests/websocket/tests/hybi/close-before-open.html:
  • http/tests/websocket/tests/hybi/close-code-and-reason.html:
  • http/tests/websocket/tests/hybi/close-event.html:
  • http/tests/websocket/tests/hybi/close-on-navigate-new-location.html:
  • http/tests/websocket/tests/hybi/close-on-unload-and-force-gc.html:
  • http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent.html:
  • http/tests/websocket/tests/hybi/close-on-unload.html:
  • http/tests/websocket/tests/hybi/close-unref-websocket.html:
  • http/tests/websocket/tests/hybi/close.html:
  • http/tests/websocket/tests/hybi/compressed-control-frame.html:
  • http/tests/websocket/tests/hybi/cross-origin.html:
  • http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff.html:
  • http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter.html:
  • http/tests/websocket/tests/hybi/deflate-frame-parameter.html:
  • http/tests/websocket/tests/hybi/echo-with-no-extension.html:
  • http/tests/websocket/tests/hybi/extensions.html:
  • http/tests/websocket/tests/hybi/fragmented-binary-frames.html:
  • http/tests/websocket/tests/hybi/fragmented-control-frame.html:
  • http/tests/websocket/tests/hybi/fragmented-frames.html:
  • http/tests/websocket/tests/hybi/frame-lengths.html:
  • http/tests/websocket/tests/hybi/handshake-challenge-randomness.html:
  • http/tests/websocket/tests/hybi/handshake-error.html:
  • http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header.html:
  • http/tests/websocket/tests/hybi/handshake-fail-by-maxlength.html:
  • http/tests/websocket/tests/hybi/handshake-fail-by-mismatch-protocol-header.html:
  • http/tests/websocket/tests/hybi/handshake-fail-by-more-accept-header.html:
  • http/tests/websocket/tests/hybi/handshake-fail-by-more-protocol-header.html:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-accept-header.html:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-connection-header.html:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-cr.html:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-upgrade-header.html:
  • http/tests/websocket/tests/hybi/handshake-fail-by-prepended-null.html:
  • http/tests/websocket/tests/hybi/handshake-fail-by-wrong-accept-header.html:
  • http/tests/websocket/tests/hybi/httponly-cookie.pl:
  • http/tests/websocket/tests/hybi/interleaved-fragments.html:
  • http/tests/websocket/tests/hybi/invalid-continuation.html:
  • http/tests/websocket/tests/hybi/invalid-encode-length.html:
  • http/tests/websocket/tests/hybi/invalid-masked-frames-from-server.html:
  • http/tests/websocket/tests/hybi/invalid-subprotocol-characters.html:
  • http/tests/websocket/tests/hybi/invalid-subprotocols.html:
  • http/tests/websocket/tests/hybi/long-control-frame.html:
  • http/tests/websocket/tests/hybi/long-invalid-header.html:
  • http/tests/websocket/tests/hybi/multiple-connections.html:
  • http/tests/websocket/tests/hybi/multiple-subprotocols.html:
  • http/tests/websocket/tests/hybi/no-subprotocol.html:
  • http/tests/websocket/tests/hybi/null-character.html:
  • http/tests/websocket/tests/hybi/pong.html:
  • http/tests/websocket/tests/hybi/receive-arraybuffer.html:
  • http/tests/websocket/tests/hybi/receive-blob.html:
  • http/tests/websocket/tests/hybi/reload-crash.html:
  • http/tests/websocket/tests/hybi/reserved-bits.html:
  • http/tests/websocket/tests/hybi/reserved-opcodes.html:
  • http/tests/websocket/tests/hybi/send-after-close-on-unload.html:
  • http/tests/websocket/tests/hybi/send-arraybuffer.html:
  • http/tests/websocket/tests/hybi/send-blob.html:
  • http/tests/websocket/tests/hybi/send-empty.html:
  • http/tests/websocket/tests/hybi/send-file-blob-fail.html:
  • http/tests/websocket/tests/hybi/send-file-blob.html:
  • http/tests/websocket/tests/hybi/send-object-tostring-check.html:
  • http/tests/websocket/tests/hybi/send-throw.html:
  • http/tests/websocket/tests/hybi/send.html:
  • http/tests/websocket/tests/hybi/server-close.html:
  • http/tests/websocket/tests/hybi/set-protocol.html:
  • http/tests/websocket/tests/hybi/simple-stress.html:
  • http/tests/websocket/tests/hybi/simple.html:
  • http/tests/websocket/tests/hybi/sub-protocol.html:
  • http/tests/websocket/tests/hybi/too-long-payload.html:
  • http/tests/websocket/tests/hybi/unicode.html:
  • http/tests/websocket/tests/hybi/unmasked-frames.html:
  • http/tests/websocket/tests/hybi/unpaired-surrogates-in-close-reason.html:
  • http/tests/websocket/tests/hybi/unpaired-surrogates-in-message.html:
  • http/tests/websocket/tests/hybi/url-attribute.html:
  • http/tests/websocket/tests/hybi/url-no-trailing-slash.html:
  • http/tests/websocket/tests/hybi/url-parsing.html:
  • http/tests/websocket/tests/hybi/url-with-credential.html:
  • http/tests/websocket/tests/hybi/url-with-empty-query.html:
  • http/tests/websocket/tests/hybi/url-with-query.html:
  • http/tests/websocket/tests/hybi/websocket-event-target.html:
  • http/tests/websocket/tests/hybi/websocket-pending-activity.html:
  • http/tests/websocket/tests/hybi/workers/close-code-and-reason.html:
  • http/tests/websocket/tests/hybi/workers/close-in-onmessage-crash.html:
  • http/tests/websocket/tests/hybi/workers/close-in-shared-worker.html:
  • http/tests/websocket/tests/hybi/workers/close-in-worker.html:
  • http/tests/websocket/tests/hybi/workers/close.html:
  • http/tests/websocket/tests/hybi/workers/multiple-subprotocols.html:
  • http/tests/websocket/tests/hybi/workers/no-onmessage-in-sync-op.html:
  • http/tests/websocket/tests/hybi/workers/no-subprotocol.html:
  • http/tests/websocket/tests/hybi/workers/receive-arraybuffer.html:
  • http/tests/websocket/tests/hybi/workers/receive-blob.html:
  • http/tests/websocket/tests/hybi/workers/send-arraybuffer.html:
  • http/tests/websocket/tests/hybi/workers/send-blob.html:
  • http/tests/websocket/tests/hybi/workers/shared-worker-simple.html:
  • http/tests/websocket/tests/hybi/workers/worker-handshake-challenge-randomness.html:
  • http/tests/websocket/tests/hybi/workers/worker-reload.html:
  • http/tests/websocket/tests/hybi/workers/worker-simple.html:
  • http/tests/websocket/tests/hybi/zero-length-text.html:
1:30 PM Changeset in webkit [122255] by wangxianzhu@chromium.org
  • 5 edits in trunk/Source

[Chromium-Android] Use default font rendering styles in FontPlatformData::querySystemForRenderStyle()
https://bugs.webkit.org/show_bug.cgi?id=90826

Reviewed by Adam Barth.

Source/WebCore:

No new tests. The change to this file is refactoring only.

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:

(WebCore::FontPlatformData::querySystemForRenderStyle): Moved the "NoPreference" initialization into PlatformSupport::PlatformSupport::getRenderStyleForStrike().

Source/WebKit/chromium:

  • WebKit.gyp:
  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::getRenderStyleForStrike): Call style.setDefault() on Android or when the font is not specified.

1:23 PM Changeset in webkit [122254] by rafaelw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Adding the majority of the remaining indexeddb/mozilla tests which are all flaky and crashing.

  • platform/chromium/TestExpectations:
1:21 PM Changeset in webkit [122253] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

AudioFIFO not correctly wrapping the write index on push
https://bugs.webkit.org/show_bug.cgi?id=90901

Patch by Raymond Toy <Raymond Toy> on 2012-07-10
Reviewed by Chris Rogers.

No new tests

  • platform/audio/AudioFIFO.cpp:

(WebCore::AudioFIFO::push): Wrap the write index, not read index!

1:14 PM Changeset in webkit [122252] by danakj@chromium.org
  • 7 edits in trunk/Source

[chromium] Avoid allocating render pass textures that have no content
https://bugs.webkit.org/show_bug.cgi?id=90702

Reviewed by Adrienne Walker.

Source/WebCore:

When OOM conditions are hit, textures are not allocated for some layers
which can prevent any quads from being present for a render surface.
This is used as a signal to prevent the RenderPass from allocating a
texture.

Replace the CCLayerTreeHostImpl::removePassesWithCachedTextures() method
with a general removeRenderPasses() which takes a culling control object
and will remove passes based on the inputs from the control object.

This new method is used for the old purpose of removing passes with cached
textures, as well as to remove passes that do not have any quad inputs.

Test: CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawRenderPassQuad):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore):
(WebCore::CCLayerTreeHostImpl::CullRenderPassesWithCachedTextures::shouldRemoveRenderPass):
(WebCore::CCLayerTreeHostImpl::CullRenderPassesWithNoQuads::shouldRemoveRenderPass):
(WebCore::CCLayerTreeHostImpl::removeRenderPasses):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore):
(CullRenderPassesWithCachedTextures):
(WebCore::CCLayerTreeHostImpl::CullRenderPassesWithCachedTextures::renderPassListBegin):
(WebCore::CCLayerTreeHostImpl::CullRenderPassesWithCachedTextures::renderPassListEnd):
(WebCore::CCLayerTreeHostImpl::CullRenderPassesWithCachedTextures::renderPassListNext):
(WebCore::CCLayerTreeHostImpl::CullRenderPassesWithCachedTextures::CullRenderPassesWithCachedTextures):
(CCLayerTreeHostImpl):
(CullRenderPassesWithNoQuads):
(WebCore::CCLayerTreeHostImpl::CullRenderPassesWithNoQuads::renderPassListBegin):
(WebCore::CCLayerTreeHostImpl::CullRenderPassesWithNoQuads::renderPassListEnd):
(WebCore::CCLayerTreeHostImpl::CullRenderPassesWithNoQuads::renderPassListNext):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/CCLayerTreeHostTest.cpp:

(WTF::ContentLayerChromiumWithUpdateTracking::ContentLayerChromiumWithUpdateTracking):
(CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit):
(WTF::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit):
(WTF::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit::beginTest):
(WTF::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit::didCommit):
(WTF::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit::afterTest):
(WTF):

12:56 PM Changeset in webkit [122251] by wangxianzhu@chromium.org
  • 2 edits in trunk/Tools

[Chromium-Android] Use setup_test_runner() instead of start_helper() to setup test environment
https://bugs.webkit.org/show_bug.cgi?id=90894

Reviewed by Adam Barth.

start_helper() is actually start_pixel_test_helper() since r115601 (bug 81729).
Should use setup_test_runner() to setup test environment for chromium-android.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.setup_test_run): Renamed from start_helper(). Added cache cleanup code.
(ChromiumAndroidPort.clean_up_test_run): Renamed from stop_helper().
(ChromiumAndroidPort._path_to_helper): Returns None as we don't have a helper now.
(ChromiumAndroidPort):
(ChromiumAndroidPort._path_to_forwarder): Original _path_to_helper().
(ChromiumAndroidPort._push_executable):
(ChromiumAndroidDriver.init):
(ChromiumAndroidDriver.cmd_line):

12:52 PM Changeset in webkit [122250] by commit-queue@webkit.org
  • 21 edits in trunk/Source/WebCore

Make GC3D and E3D more maintainable for GLES platforms
https://bugs.webkit.org/show_bug.cgi?id=90567

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-10
Reviewed by Rob Buis.

This patch cleans up code for WebGL on OpenGLES platforms which use
GraphicsContext3DOpenGL* and Extensions3DOpenGL*. Although
GraphicsContext3DOpenGL was already split into GraphicsContext3DOpenGL,
GraphicsContext3DOpenGLCommon, and GraphicsContext3DOpenGLES, this patch
is an attempt to refactor this code in a way that will help BlackBerry and
other teams support WebGL on mobile platforms with as little use of
"#IF USE(OPENGL_ES_2)" in common code as possible. Also included is the
separation of Extensions3DOpenGL into Extensions3DOpenGLCommon,
Extensions3DOpenGL, and Extensions3DOpenGLES as well as the introduction
of OpenGLESShims.

This patch is created in large part by Jonathan Feldstein.

No new tests: no new behaviour.

  • PlatformBlackBerry.cmake: Recognize BlackBerry as OPENGL ES, add new files to build
  • Target.pri: Add new Extensions3DOpenGL* to WebGL builds
  • platform/graphics/GraphicsContext3D.h: Add validateDepthStencil, make systemAllowsMultisamplingOnATICards a a member function.

(WebCore):

  • platform/graphics/OpenGLESShims.h: Added.
  • platform/graphics/opengl/Extensions3DOpenGL.cpp: Move code to Extensions3DOpenGLCommon where possible

(WebCore::Extensions3DOpenGL::Extensions3DOpenGL): Reflect that it is now inherits Extensions3DCommon
(WebCore::Extensions3DOpenGL::supportsExtension): Contains OpenGL specific code from supports
(WebCore):
(WebCore::Extensions3DOpenGL::getExtensions): Returns a list of extensions

  • platform/graphics/opengl/Extensions3DOpenGL.h: Remove functions now in Extensions3DOpenGLCommon

(WebCore):
(Extensions3DOpenGL):

  • platform/graphics/opengl/Extensions3DOpenGLCommon.cpp: Added.

(WebCore):
(WebCore::Extensions3DOpenGLCommon::Extensions3DOpenGLCommon):
(WebCore::Extensions3DOpenGLCommon::~Extensions3DOpenGLCommon):
(WebCore::Extensions3DOpenGLCommon::supports):
(WebCore::Extensions3DOpenGLCommon::ensureEnabled):
(WebCore::Extensions3DOpenGLCommon::isEnabled):
(WebCore::Extensions3DOpenGLCommon::getGraphicsResetStatusARB):
(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE): Existed before, but did nothing. Now does what is says it does.
(WebCore::Extensions3DOpenGLCommon::initializeAvailableExtensions): Moved from Extensions3DOpenGL::supports

  • platform/graphics/opengl/Extensions3DOpenGLCommon.h: Copied from Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.h.

(WebCore):
(Extensions3DOpenGLCommon):

  • platform/graphics/opengl/Extensions3DOpenGLES.cpp: Added.

(WebCore):
(WebCore::Extensions3DOpenGLES::Extensions3DOpenGLES):
(WebCore::Extensions3DOpenGLES::~Extensions3DOpenGLES):
(WebCore::Extensions3DOpenGLES::framebufferTexture2DMultisampleIMG):
(WebCore::Extensions3DOpenGLES::renderbufferStorageMultisampleIMG):
(WebCore::Extensions3DOpenGLES::createVertexArrayOES):
(WebCore::Extensions3DOpenGLES::deleteVertexArrayOES):
(WebCore::Extensions3DOpenGLES::isVertexArrayOES):
(WebCore::Extensions3DOpenGLES::bindVertexArrayOES):
(WebCore::Extensions3DOpenGLES::supportsExtension): Contains OpenGLES specific code from supports
(WebCore::Extensions3DOpenGLES::getExtensions):

  • platform/graphics/opengl/Extensions3DOpenGLES.h: Copied from Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.h.

(WebCore):
(Extensions3DOpenGLES):

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::validateAttributes):
(WebCore):
(WebCore::GraphicsContext3D::renderbufferStorage):
(WebCore::GraphicsContext3D::texImage2D):
(WebCore::GraphicsContext3D::systemAllowsMultisamplingOnATICards): Now a member function.
(WebCore::GraphicsContext3D::getExtensions):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::validateDepthStencil):
(WebCore::GraphicsContext3D::clear):
(WebCore::GraphicsContext3D::isTexture):
(WebCore):
(WebCore::GraphicsContext3D::lineWidth):
(WebCore::GraphicsContext3D::linkProgram):
(WebCore::GraphicsContext3D::pixelStorei):
(WebCore::GraphicsContext3D::polygonOffset):
(WebCore::GraphicsContext3D::readPixels):
(WebCore::GraphicsContext3D::deleteBuffer):

  • platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:

(WebCore::GraphicsContext3D::releaseShaderCompiler):
(WebCore::GraphicsContext3D::readPixelsAndConvertToBGRAIfNecessary):
(WebCore::GraphicsContext3D::validateAttributes):
(WebCore):
(WebCore::GraphicsContext3D::getExtensions):
(WebCore::GraphicsContext3D::systemAllowsMultisamplingOnATICards): Now a member function.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore):
(WebCore::GraphicsContext3D::releaseShaderCompiler):

12:37 PM Changeset in webkit [122249] by cevans@google.com
  • 1 edit in branches/chromium/1180/Source/WebCore/dom/NodeRareData.h

Merge 121103
BUG=134088
Review URL: https://chromiumcodereview.appspot.com/10703124

12:36 PM Changeset in webkit [122248] by cevans@google.com
  • 11 edits
    2 copies in branches/chromium/1180

Merge 121003
BUG=134088
Review URL: https://chromiumcodereview.appspot.com/10696159

12:21 PM Changeset in webkit [122247] by rafaelw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Added resource-request-content-while-loading.html to flaky wkbug 83890.

  • platform/chromium/TestExpectations:
12:17 PM Changeset in webkit [122246] by cevans@google.com
  • 19 edits in branches/chromium/1180/Source/WebCore

Merge 120979
BUG=134088
Review URL: https://chromiumcodereview.appspot.com/10695128

12:15 PM Changeset in webkit [122245] by cevans@google.com
  • 5 edits in branches/chromium/1180/Source/WebCore/dom

Merge 120868
BUG=134088
Review URL: https://chromiumcodereview.appspot.com/10689138

12:14 PM Changeset in webkit [122244] by hyatt@apple.com
  • 7 edits in trunk

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=90646
<rdar://problem/11648478> 3-pass pagination slows down pagination

Improve the logical top estimate function for margin collapsing to be more accurate. In particular
make the basic case of <body><p> or <body><h1> no longer be wrong. This estimate being incorrect
is not a big deal most of the time, but when paginating it is a very big deal, since you have to
relayout everything whenever your vertical placement is wrong.

Improving the estimation exposed a bug in an existing layout test. I had to clean up the buggy
code written for negative margin-related float detection and fix an invalid layout test to
actually be correct.

Reviewed by Simon Fraser.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::marginBeforeEstimateForChild):
(WebCore):
(WebCore::RenderBlock::estimateLogicalTopPosition):
(WebCore::RenderBlock::marginValuesForChild):

  • rendering/RenderBlock.h:

(RenderBlock):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::shrinkLogicalWidthToAvoidFloats):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=90646

Fix invalid layout test exposed by my changes to logical top estimation.

Reviewed by Simon Fraser.

  • fast/block/float/previous-sibling-float-002-expected.html:
  • fast/block/float/previous-sibling-float-002.html:
12:10 PM Changeset in webkit [122243] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Count inspector memory used to traverse DOM in native memory snapshots.
https://bugs.webkit.org/show_bug.cgi?id=90456

Inspector may take significant amount of memory when traversing DOM structure.
Take it into account and report under inspector memory.

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-07-10
Reviewed by Pavel Feldman.

  • dom/MemoryInstrumentation.h:

(MemoryInstrumentation):
(WebCore::MemoryInstrumentation::calculateContainerSize):
(WebCore::MemoryInstrumentation::reportHashMap):
(WebCore::MemoryInstrumentation::reportHashSet):
(WebCore::MemoryInstrumentation::reportVector):

  • inspector/InspectorMemoryAgent.cpp:

(MemoryBlockName):
(WebCore):
(WebCore::domTreeInfo):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):

12:09 PM Changeset in webkit [122242] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1180

Merge 120617
BUG=133288
Review URL: https://chromiumcodereview.appspot.com/10690118

12:02 PM Changeset in webkit [122241] by cevans@google.com
  • 10 edits
    8 deletes in branches/chromium/1180

Merge 120639
BUG=132396
Review URL: https://chromiumcodereview.appspot.com/10696154

11:48 AM Changeset in webkit [122240] by rafaelw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. tables/mozilla_expected_failures/other/empty_cells.html marked as flaky.

  • platform/chromium/TestExpectations:
11:39 AM Changeset in webkit [122239] by kareng@chromium.org
  • 7 edits
    3 copies in branches/chromium/1180

Merge 121722 - Position replaced elements on pixel bounds
https://bugs.webkit.org/show_bug.cgi?id=90354

Reviewed by Eric Seidel.

To avoid sizing and repaint issues we should layout replaced elements on
pixel bounds. We already ensure that replaced elements are sized in full
pixels and that they are painted on pixel bounds. By also ensuring that
they are placed on pixel bounds we avoid pixel having the size be
expanded by pixel snapping and repainting/invalidation rect issues when
scrolling.

Test: fast/repaint/repaint-during-scroll-with-zoom.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):

TBR=eae@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10696152

11:35 AM Changeset in webkit [122238] by kareng@chromium.org
  • 17 edits
    2 copies in branches/chromium/1180

Merge 121599 - Allow non-borders to be adjusted to less than 1 when zoomed out
https://bugs.webkit.org/show_bug.cgi?id=90104

Reviewed by Eric Seidel.

Source/WebCore:

Change CSSPrimitiveValue::computeLengthDouble to allow values to be
adjusted to less than 1.0 when zoomed out. This avoids an off by one
error for floats with margins when zoomed out that can cause floats to
wrap and break pages.

The logic that prevents the value from being adjusted to less than 1 was
added to ensure that borders are still painted even when zoomed out.
By moving the logic to ApplyPropertyComputeLength::applyValue, which is
used for borders and outlines, that functionality is preserved.

Test: fast/sub-pixel/float-with-margin-in-container.html

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::computeLengthDouble):

  • css/StyleBuilder.cpp:

(WebCore::ApplyPropertyComputeLength::applyValue):

LayoutTests:

Add test ensuring that floats with margins do not wrap in fixed sized
containers and update existing results as needed.

  • fast/css/zoom-background-repeat-x.html:
  • fast/sub-pixel/float-with-margin-in-container-expected.txt: Added.
  • fast/sub-pixel/float-with-margin-in-container.html: Added.
  • platform/chromium-linux/fast/reflections/reflection-with-zoom-expected.png:
  • platform/chromium-linux/fast/transforms/bounding-rect-zoom-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-mac/fast/transforms/bounding-rect-zoom-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/chromium-win/fast/transforms/bounding-rect-zoom-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/mac/fast/transforms/bounding-rect-zoom-expected.txt:
  • platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
  • platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:

TBR=eae@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10698133

11:27 AM Changeset in webkit [122237] by rafaelw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. platform/chromium/inspector/styles/device-metrics-fit-window.html is timing out in debug and now marked as slow.

  • platform/chromium/TestExpectations:
11:15 AM Changeset in webkit [122236] by rafaelw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. fast/js/dfg-cross-global-object-inline-array-literal.html is racey (and thus flaky).

10:33 AM Changeset in webkit [122235] by rafaelw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Adding another flaky test to bug 90469 (storage tests).

  • platform/chromium/TestExpectations:
10:33 AM Changeset in webkit [122234] by ojan@chromium.org
  • 13 edits in trunk/Tools

Improve webkit-patch rebaseline to work for more cases
https://bugs.webkit.org/show_bug.cgi?id=90504

Reviewed by Adam Barth.

-Makes it work for the build.chromium.org bots.
-Lets you rebaseline all builders instead of just one.
-Lets you pass in the builders or tests to rebaseline.

  • Scripts/webkitpy/common/host.py:

(Host.buildbot_for_builder_name):

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:

(Builder.init):
(Builder.latest_layout_test_results):
Provide a way to get to the LayoutTestResults of the latest build.
Most of the time we only need to get the latest one and the Chromium bots
only expose the full_results.json file for the latest build.

(Builder):
(Builder._fetch_file_from_results):
(Builder.fetch_layout_test_results):
Move these functions into Builder so that Builder and Build can both
fetch layout test results.

(Build.results_zip_url):
(Build.layout_test_results):

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

(BuilderTest.test_latest_layout_test_results):
(BuildTest.test_layout_test_results):

  • Scripts/webkitpy/common/system/user.py:

(User.prompt_with_multiple_lists):
Prompt with multiple sublists, but still have a global numbering.
This lets the build.chromium.org bots be clearly separated from the
build.webkit.org bots, which helps understand the builder names.

(User):
(User._wait_on_list_response):
(User.prompt_with_list):

  • Scripts/webkitpy/common/system/user_unittest.py:

(UserTest.test_prompt_with_multiple_lists):
(UserTest.test_prompt_with_multiple_lists.run_prompt_test):
(UserTest.test_prompt_with_multiple_lists.run_prompt_test.mock_raw_input):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.is_chromium):
Provide a way to tell if a port is a Chromium port that doesn't involve string
manipulation on the port name or builder name.

  • Scripts/webkitpy/layout_tests/port/builders.py:

(builder_path_from_name):
(all_builder_names):
Memoizing here is incorrect because the test override _exact_matches,
so these can return different values. In either case, I'm pretty sure these
are not remotely hot codepaths. I manually inspected all call sites and they're
all in high-level calls (e.g. execute calls for webkit-patch commands) and not
called in a loop.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.is_chromium):

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineTest._results_url):
(AbstractParallelRebaselineCommand.init):
(Rebaseline.init):
(Rebaseline):
(Rebaseline._builders_to_pull_from):
(Rebaseline._tests_to_update):
(Rebaseline.execute):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(test_rebaseline.mock_builders_to_pull_from):
(test_rebaseline):
(test_rebaseline_command_line_flags):
(test_rebaseline_multiple_builders):
(test_rebaseline_multiple_builders.mock_builders_to_pull_from):
(test_rebaseline_multiple_builders.mock_tests_to_update):
(test_rebaseline_multiple_builders_and_tests_command_line):

  • Scripts/webkitpy/tool/mocktool.py:

(MockTool.irc):
(MockTool):
(MockTool.buildbot_for_builder_name):

10:05 AM Changeset in webkit [122233] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[GTK] Fix memory leaks by adopting allocation of GdkPixbuf
https://bugs.webkit.org/show_bug.cgi?id=90790

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-10
Reviewed by Carlos Garcia Campos.

Source/WebCore:

Fixed a memory leak in paintGdkPixbuf by adopting an allocation
of GdkPixbuf.

No new tests. No change in behavior.

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore::paintGdkPixbuf):

Source/WebKit/gtk:

Fixed a memory leak in WebKitFaviconDatabase by adopting an
allocation of GdkPixbuf.

  • webkit/webkitfavicondatabase.cpp:

(getIconPixbufSynchronously):

10:03 AM Changeset in webkit [122232] by kpiascik@rim.com
  • 12 edits
    4 adds in trunk

Web Inspector: Geolocation override
https://bugs.webkit.org/show_bug.cgi?id=89365

Reviewed by Yong Li.

Source/WebCore:

Added a way to override the geoloation of a client using Web
Inspector.

New tests added.

  • LayoutTests/inspector/geolocation-success.html:
  • LayoutTests/inspector/getlocation-error.html:
  • Modules/geolocation/GeolocationController.cpp:

(WebCore::GeolocationController::GeolocationController): Now store and
save the Page in m_page.
(WebCore::GeolocationController::positionChanged): Check if position
is overriden in Web Inspector.

  • Modules/geolocation/GeolocationController.h:

(GeolocationController): Add member variable m_page for Page*.

  • inspector/Inspector.json: Add new methods for setting and clearing

the GeoloationPosition and GeolocationError objects in InspectorPageAgent.

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::checkGeolocationPositionOrErrorImpl):
Add methods to check whether GeolocationPosition or GeolocationError
are set in InspectorPageAgent.

  • inspector/InspectorInstrumentation.h:

(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::checkGeolocationPositionOrError):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::InspectorPageAgent): Initialize new
member variables of GeolocationPosition and GeolocationError.
(WebCore::InspectorPageAgent::setGeolocationData): Set Position and
Error data and call appropriate GeolocaitonController methods.
(WebCore):
(WebCore::InspectorPageAgent::clearGeolocationData):
(WebCore::InspectorPageAgent::sendGeolocationError):

  • inspector/InspectorPageAgent.h:

(WebCore::InspectorPageAgent::geolocationPosition): Getter for
GeolocationPosition.
(InspectorPageAgent):

  • inspector/front-end/Settings.js: Added new settings for

GeolocationPosition and GeolocationError

  • inspector/front-end/SettingsScreen.js: Added new control for

Geolocaiton.
(WebInspector.UserAgentSettingsTab):
(WebInspector.UserAgentSettingsTab.prototype._createDeviceMetricsElement):
(WebInspector.UserAgentSettingsTab.prototype._onGeolocationOverrideCheckboxClicked):
(WebInspector.UserAgentSettingsTab.prototype._applyGeolocationUserInput):
(WebInspector.UserAgentSettingsTab.prototype._setGeolocationPosition.set if):
(WebInspector.UserAgentSettingsTab.prototype._setGeolocationPosition):
(WebInspector.UserAgentSettingsTab.prototype._createGeolocationOverrideElement.createInput):
(WebInspector.UserAgentSettingsTab.prototype._createGeolocationOverrideElement):

  • inspector/front-end/UserAgentSupport.js: New GeolocationPosition

Object added along with setting helper methods. Added new setting
changed handlers for Position and Error.
(WebInspector.UserAgentSupport.GeolocationPosition):
(WebInspector.UserAgentSupport.GeolocationPosition.prototype.toSetting):
(WebInspector.UserAgentSupport.GeolocationPosition.parseSetting):
(WebInspector.UserAgentSupport.GeolocationPosition.parseUserInput):
(WebInspector.UserAgentSupport.prototype.get _onGeolocationErrorChanged):

LayoutTests:

Added new tests for Web Inspector overriding geolocation.

  • inspector/geolocation-error-expected.txt: Added.
  • inspector/geolocation-error.html: Added.
  • inspector/geolocation-success-expected.txt: Added.
  • inspector/geolocation-success.html: Added.
9:56 AM Changeset in webkit [122231] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

DelayNode test should cover relate attribute
https://bugs.webkit.org/show_bug.cgi?id=90876

Patch by Li Yin <li.yin@intel.com> on 2012-07-10
Reviewed by Chris Rogers.

Let the test cover attributes of DelayNode.

  • webaudio/delaynode-expected.txt:
  • webaudio/delaynode.html:
9:37 AM Changeset in webkit [122230] by leandrogracia@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed Chromium build fix for mac-release.

Fixing clang build after https://bugs.webkit.org/show_bug.cgi?id=90807

  • public/WebSurroundingText.h:

(WebKit):

9:23 AM Changeset in webkit [122229] by vsevik@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Refactor resource revisions before moving to UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=90855

Reviewed by Pavel Feldman.

Revisions are now persisted based on mainFrame.loaderId, not resource.loaderId which makes filtering out stale persisted revisions easier.
Restoring revisions from local storage is separated from filtering out stale persisted revisions.
Resource._clearRevisionHistory and Resource._restoreRevisions are not static anymore.
Renamed localStorage field for persisting revisions: "resource-history" -> "revision-history"

  • inspector/front-end/Resource.js:

(WebInspector.Resource):
(WebInspector.Resource.prototype.addRevision):
(WebInspector.Resource.prototype._restoreRevisionHistory):
(WebInspector.Resource.prototype._clearRevisionHistory):
(WebInspector.Resource.prototype.revertAndClearHistory.clearHistory):
(WebInspector.Resource.prototype.revertAndClearHistory):
(WebInspector.Revision):
(WebInspector.Revision._revisionHistoryRegistry):
(WebInspector.Revision._ensureStaleRevisionsFileteredOut.persist):
(WebInspector.Revision._ensureStaleRevisionsFileteredOut):
(WebInspector.Revision.prototype._persist):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype._processCachedResources):
(WebInspector.ResourceTreeModel.prototype._addFramesRecursively):

  • inspector/front-end/RevisionHistoryView.js:
  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype._revisionAdded):

9:18 AM Changeset in webkit [122228] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Editing: Reproducible crasher when pasting a 0x0 image into Mail
https://bugs.webkit.org/show_bug.cgi?id=90640
<rdar://problem/11141920>

Patch by Alice Cheng <alice_cheng@apple.com> on 2012-07-10
Reviewed by Brady Eidson.

Source/WebCore:

0x0 images don't get a resource representation in the WebArchive, so we need a null check

Test: TestWebKitAPI/Tests/mac/0.png

TestWebKitAPI/Tests/mac/WebViewCanPasteZeroPng.mm

  • platform/mac/PasteboardMac.mm:

(WebCore::documentFragmentWithImageResource):

Tools:

Test cases for the patch. 0x0 images don't get a resource representation in the WebArchive, so we need a null check.

  • TestWebKitAPI/Tests/mac/0.png: Added.
  • TestWebKitAPI/Tests/mac/WebViewCanPasteZeroPng.mm: Added.

(TestWebKitAPI):
(TestWebKitAPI::TEST):

9:11 AM Changeset in webkit [122227] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Make the Tab character 4 spaces width
https://bugs.webkit.org/show_bug.cgi?id=90172

Patch by Nikita Vasilyev <me@elv1s.ru> on 2012-07-10
Reviewed by Pavel Feldman.

Do it to match most code editors' behavior.

  • inspector/front-end/inspectorCommon.css:

(body):

9:09 AM Changeset in webkit [122226] by eric@webkit.org
  • 7 edits in trunk

REGRESSION (r122168): Layout Test http/tests/misc/script-defer.html is failing
https://bugs.webkit.org/show_bug.cgi?id=90845

Reviewed by Alexey Proskuryakov.

Source/WebCore:

I was a bit overzealous in removing bool returns. This one still makes sense.
This just reverts the wrong part of my previous change.

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd):

  • html/parser/HTMLScriptRunner.cpp:

(WebCore::HTMLScriptRunner::executeScriptsWaitingForParsing):

  • html/parser/HTMLScriptRunner.h:

(HTMLScriptRunner):

LayoutTests:

The test should no longer flake.

  • platform/chromium/TestExpectations:
  • platform/qt/Skipped:
9:01 AM Changeset in webkit [122225] by leandrogracia@chromium.org
  • 9 edits in trunk

WebSurroundingText layout tests should use the same code path as the rest of the feature.
https://bugs.webkit.org/show_bug.cgi?id=90807

Reviewed by Adam Barth.

Source/WebKit/chromium:

Replace the offset-based initialize method used only by LayoutTestController
with a point-based version to follow the same code path.

  • public/WebSurroundingText.h:

(WebKit):
(WebSurroundingText):

  • src/WebSurroundingText.cpp:

(WebKit::WebSurroundingText::initialize):

Tools:

Make the textSurroundingNode method take a pair of point coordinates
instead of a node offset.

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::textSurroundingNode):

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController):

LayoutTests:

Make the textSurroundingNode method take a pair of point coordinates
instead of a node offset.

  • platform/chromium/editing/surrounding-text/surrounding-text-expected.txt:
  • platform/chromium/editing/surrounding-text/surrounding-text.html:
8:51 AM Changeset in webkit [122224] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk

Input type=range issue with events not being raised when value set in js
https://bugs.webkit.org/show_bug.cgi?id=84674

Source/WebCore:

Fix dispatching of change and click events for the input slider.
Prior to the fix, change events were not fired if the new value
matched the value at last change notification based on expected
behavior for text fields. Clicks were not fired if the thumb
element was repositioned under the cursor on mouse down.

Patch by Kevin Ellis <kevers@chromium.org> on 2012-07-10
Reviewed by Kent Tamura.

Tests: fast/events/click-range-slider.html

fast/events/onchange-range-slider.html

  • html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::setPositionFromPoint):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseReleaseEvent):

LayoutTests:

Ensure that click and change events are properly triggered for range
sliders. Prior to the fix, change events were not fired if the new
value matched the value at last change notification based on expected
behavior for text fields. Clicks were not fired if the thumb element
was positioned under the cursor on mouse down.

Patch by Kevin Ellis <kevers@chromium.org> on 2012-07-10
Reviewed by Kent Tamura.

  • fast/events/click-range-slider-expected.txt: Added.
  • fast/events/click-range-slider.html: Added.
  • fast/events/onchange-range-slider-expected.txt: Added.
  • fast/events/onchange-range-slider.html: Added.
8:30 AM Changeset in webkit [122223] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

[GTK] Add API to clear the cache to WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=90856

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkit_web_context_clear_cache): Call
WKResourceCacheManagerClearCacheForAllOrigins() to clear all
resources currently cached.

  • UIProcess/API/gtk/WebKitWebContext.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.
7:25 AM Changeset in webkit [122222] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening, adding a text expectation for the
fast/js/global-constructors.html test. The test is failing because
of the in-progress removal of vendor prefix from DOM MutationObservers.

  • platform/gtk/TestExpectations:
7:10 AM Changeset in webkit [122221] by Csaba Osztrogonác
  • 2 edits
    4 moves
    7 deletes in trunk/LayoutTests

[Qt] Unreviewed gardening, remove unnecessary expectations.

  • platform/qt-mac/fast/block/float/float-not-removed-from-next-sibling-expected.txt: Removed.
  • platform/qt-mac/fast/block/float/float-not-removed-from-next-sibling2-expected.txt: Removed.
  • platform/qt-mac/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Removed.
  • platform/qt-mac/fast/block/float/float-not-removed-from-next-sibling4-expected.txt: Removed.
  • platform/qt-mac/plugins/mouse-click-plugin-clears-selection-expected.txt: Removed.
  • platform/qt-mac/transforms/svg-vs-css-expected.txt: Removed.
  • platform/qt-win/Skipped:
  • platform/qt-win/fast/events/panScroll-click-hyperlink-expected.txt: Removed.
  • platform/qt/fast/css/first-line-text-decoration-expected.png: Renamed from LayoutTests/platform/qt-linux/fast/css/first-line-text-decoration-expected.png.
  • platform/qt/fast/css/first-line-text-decoration-expected.txt: Renamed from LayoutTests/platform/qt-linux/fast/css/first-line-text-decoration-expected.txt.
  • platform/qt/fast/css/first-line-text-decoration-inherited-from-parent-expected.png: Renamed from LayoutTests/platform/qt-linux/fast/css/first-line-text-decoration-inherited-from-parent-expected.png.
  • platform/qt/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt: Renamed from LayoutTests/platform/qt-linux/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt.
6:50 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
(diff)
6:31 AM Changeset in webkit [122220] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r122207.
http://trac.webkit.org/changeset/122207
https://bugs.webkit.org/show_bug.cgi?id=90874

Broke the cr-windows bot (Requested by beverloo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-10

  • DEPS:
6:22 AM Changeset in webkit [122219] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt] REGRESSION(r122175): It broke the Windows build
https://bugs.webkit.org/show_bug.cgi?id=90850

Reviewed by Noam Rosenthal.

  • qmake/mkspecs/features/features.prf: Disable USE(3D_GRAPHICS) on Windows temporarily until proper fix.
6:21 AM Changeset in webkit [122218] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][ARM] Unreviewed gardening, skip failing/crashing tests to try to make the bot green.

  • platform/qt-arm/TestExpectations:
6:05 AM Changeset in webkit [122217] by Csaba Osztrogonác
  • 3 edits
    8 adds in trunk

[Qt][NRWT] Enable cascaded TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=89108

Patch by János Badics <János Badics> on 2012-07-10
Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort.expectations_files):

  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:

(QtPortTest._assert_expectations_files):
(QtPortTest.test_expectations_files):

6:05 AM WebKitEFLLayoutTest edited by ryuan.choi@samsung.com
Add information about how to run WebKitTestRunner for WebKit2/Efl. (diff)
5:23 AM Changeset in webkit [122216] by caseq@chromium.org
  • 7 edits in trunk/LayoutTests

Web Inspector: [Extensions API] simplify panel size check in extensions-panel.html
https://bugs.webkit.org/show_bug.cgi?id=90799

Reviewed by Vsevolod Vlasov.

  • use window argument in Panel.onShown() to check panel window size;
  • http/tests/inspector/resources/extension-panel.html:
  • inspector/extensions/extensions-panel-expected.txt:
  • inspector/extensions/extensions-panel.html:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/wincairo/Skipped:
5:10 AM Changeset in webkit [122215] by kseo@webkit.org
  • 6 edits in trunk/Source/WebCore

Don't destroy the decoded data of an image if WebKit is about to render the image.
https://bugs.webkit.org/show_bug.cgi?id=90721

Patch by Huang Dongsung <luxtella@company100.net> on 2012-07-10
Reviewed by Antti Koivisto.

When the cache capacity of the MemoryCache is exceeded, the decoded data of all
the CachedImages are destroyed. Even the images inside the viewport are
destroyed. However, if the images need to be rendered again due to scoll events
or animation, they must be decoded again. As an extreme case, if there is an
animation with an image when MemoryCache is almost full, the image must be
decoded every frame. This slows down animation and needlessly consumes CPU
cycles.

Therefore, it is better to not destory the decoded data of an image if the image
is inside the viewport because there is high chance that the image needs to be
rendered again soon. This patch reduces the unnecessary repetition of image decoding
on low memory, and also relieves the memory fragmentation because it avoids reallocation
of image frames.

In addition, there is another positive side effect. Currently,
CachedImageClient::willRenderImage() is used only to determine if GIF animation needs
to be paused or not in CachedImage::shouldPauseAnimation(). This patch makes
GIF animation outside the viewort be paused.

This is also a prerequisite for parallel image decoders. Because parallel image
decoders decode an image asynchronously, clients cannot render the image at the time
when the request is made. Clients can draw the image later after receiving image
decoding complete notification. However, there is a problem because MemoryCache can
destroy the decoded data before clients actually render the image. So parallel image decoders
must prevent the decoded data from being destroyed if the image will be rendered
soon.

This patch may consume a little more memory, but furtunately the peak memory usage
is almost the same.

No new tests - no new testable functionality.

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::likelyToBeUsedSoon):
(WebCore):
(WebCore::CachedImage::shouldPauseAnimation):

  • loader/cache/CachedImage.h:

(CachedImage):

  • loader/cache/CachedResource.h:

(CachedResource):
(WebCore::CachedResource::likelyToBeUsedSoon):

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::pruneLiveResourcesToSize):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::willRenderImage):

5:06 AM Changeset in webkit [122214] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip a flakey test after r122168.
https://bugs.webkit.org/show_bug.cgi?id=90845.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-07-10

  • platform/qt/Skipped:
5:02 AM Changeset in webkit [122213] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[EFL] WebKit DRT and WTR fail to build due to undefined reference to WTF::MD5::*
https://bugs.webkit.org/show_bug.cgi?id=90868

Unreviewed EFL build fix.

Correct CMake configuration to have EFL's DRT and WebKitTestRunner link
WTF library. This is needed to resolve undefined reference to WTF::MD5::*.

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-10

  • DumpRenderTree/efl/CMakeLists.txt:
  • WebKitTestRunner/PlatformEfl.cmake:
4:19 AM Changeset in webkit [122212] by tkent@chromium.org
  • 4 edits in trunk

RTL calendar picker for <input type=date> is too narrow and clipped
https://bugs.webkit.org/show_bug.cgi?id=90864

Reviewed by Kentaro Hara.

.:

  • ManualTests/forms/calendar-picker.html:
  • Add isRTL:true for the arabic setting
  • Reset the iframe size when the setting is changed.

Source/WebCore:

Tests: ManualTests/forms/calendar-picker.html

  • Resources/calendarPicker.js:

(fixWindowSize):
Checks the left edge of elemenets in RTL.
(layout): Add dir=ltr for the manual test, which re-uses the document.

3:49 AM Changeset in webkit [122211] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WTF

Re-enable declspec(dl{import,export}) for MinGW when using EXPORT_MACROS
https://bugs.webkit.org/show_bug.cgi?id=90612

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2012-07-10
Reviewed by Csaba Osztrogonác.

MinGW was switched to use auto import/export of symbols on r44184.
From my understanding of the documentation, MinGW will not auto-export symbols
unless there are no explicit declspec(dlexport) in the DLL already.

The issues that originally made us rely on the auto-import feature of MinGW
should now be resolved with the EXPORT_MACROS work. This patch re-enables them.

It also removes the GCC check for internal symbols hiding as the visibility should
already be hidden by default for both MSVC and GCC on Windows anyway.

  • wtf/ExportMacros.h:
3:20 AM Changeset in webkit [122210] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed gardening after r122204.

  • fast/viewport/viewport-legacy-xhtmlmp-expected.txt:
3:19 AM Changeset in webkit [122209] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening
Rebaseline.

  • platform/chromium-linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
2:36 AM Changeset in webkit [122208] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r122166): It made 170 tests crash on 32 bit platforms
https://bugs.webkit.org/show_bug.cgi?id=90852

Patch by Filip Pizlo <fpizlo@apple.com> on 2012-07-10
Reviewed by Zoltan Herczeg.

If we can't use the range filter, we should still make sure that the
address is remotely sane, otherwise the hashtables will assert.

  • jit/JITStubRoutine.h:

(JSC::JITStubRoutine::passesFilter):

2:32 AM Changeset in webkit [122207] by jochen@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
2:18 AM Changeset in webkit [122206] by fpizlo@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

DFG recompilation heuristics should be based on count, not rate
https://bugs.webkit.org/show_bug.cgi?id=90146

Reviewed by Oliver Hunt.

Rolling r121511 back in after fixing the DFG's interpretation of op_div
profiling, with Gavin's rubber stamp.

This removes a bunch of code that was previously trying to prevent spurious
reoptimizations if a large enough majority of executions of a code block did
not result in OSR exit. It turns out that this code was purely harmful. This
patch removes all of that logic and replaces it with a dead-simple
heuristic: if you exit more than N times (where N is an exponential function
of the number of times the code block has already been recompiled) then we
will recompile.

This appears to be a broad ~1% win on many benchmarks large and small.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::couldTakeSpecialFastCase):
(CodeBlock):
(JSC::CodeBlock::osrExitCounter):
(JSC::CodeBlock::countOSRExit):
(JSC::CodeBlock::addressOfOSRExitCounter):
(JSC::CodeBlock::offsetOfOSRExitCounter):
(JSC::CodeBlock::adjustedExitCountThreshold):
(JSC::CodeBlock::exitCountThresholdForReoptimization):
(JSC::CodeBlock::exitCountThresholdForReoptimizationFromLoop):
(JSC::CodeBlock::shouldReoptimizeNow):
(JSC::CodeBlock::shouldReoptimizeFromLoopNow):

  • bytecode/ExecutionCounter.cpp:

(JSC::ExecutionCounter::setThreshold):

  • bytecode/ExecutionCounter.h:

(ExecutionCounter):
(JSC::ExecutionCounter::clippedThreshold):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::makeDivSafe):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileBody):

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::considerAddingAsFrequentExitSiteSlow):

  • dfg/DFGOSRExitCompiler.cpp:

(JSC::DFG::OSRExitCompiler::handleExitCounts):

  • dfg/DFGOperations.cpp:
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Options.h:

(JSC):

1:46 AM Changeset in webkit [122205] by Csaba Osztrogonác
  • 17 edits
    4 deletes in trunk

Unreviewed, rolling out r122178.
http://trac.webkit.org/changeset/122178
https://bugs.webkit.org/show_bug.cgi?id=90857

browser tests, PrerenderBrowserTest.PrerenderFavicon and other
tests, started to fail (Requested by hayato on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-10

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

  • WebCore.exp.in:
  • dom/Document.cpp:

(WebCore::Document::iconURLs):
(WebCore::Document::addIconURL):
(WebCore::Document::setUseSecureKeyboardEntryWhenActive):

  • dom/Document.h:

(Document):

  • html/HTMLLinkElement.cpp:
  • html/HTMLLinkElement.h:

(HTMLLinkElement):

  • testing/Internals.cpp:
  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit2:

  • win/WebKit2.def:

LayoutTests:

  • fast/dom/icon-url-change-expected.txt: Removed.
  • fast/dom/icon-url-change.html: Removed.
  • fast/dom/icon-url-list-expected.txt: Removed.
  • fast/dom/icon-url-list.html: Removed.
  • fast/dom/icon-url-property-expected.txt:
  • fast/dom/icon-url-property.html:
  • platform/chromium/TestExpectations:
12:55 AM Changeset in webkit [122204] by abarth@webkit.org
  • 321 edits
    6 moves
    12 deletes in trunk

LayoutTestController.dumpConfigurationForViewport should move to Internals
https://bugs.webkit.org/show_bug.cgi?id=45652

Reviewed by Eric Seidel.

Source/WebCore:

This patch replaces LayoutTestController.dumpConfigurationForViewport
with Internals.configurationForViewport. The old
dumpConfigurationForViewport function just ended up calling WebCore
functions anyway, so there's no benefit in implementing the API in the
LayoutTestController.

As a result, these tests can now run on every port.

  • testing/Internals.cpp:

(WebCore::Internals::configurationForViewport):
(WebCore):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit/blackberry:

  • WebKitSupport/DumpRenderTreeSupport.cpp:
  • WebKitSupport/DumpRenderTreeSupport.h:

(DumpRenderTreeSupport):

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Tools:

Remove dumpConfigurationForViewport from LayoutTestController. This API
has been replaced by an API on Internals that does the same thing in a
port-agnostic way.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  • DumpRenderTree/qt/LayoutTestControllerQt.h:

(LayoutTestController):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

LayoutTests:

Update these tests to use the Internals API rather than the
LayoutTestController API. This changed the output format of the tests
slightly because the LayoutTestController API printed directly to
stdout whereas the new API just returns a string that we pipe to stdout
using alert.

This patch also cleans up some platform-specific results for these
tests that had drifted out of sync a bit. The patch also correctly
marks the legacy tests as failing on GTK instead of checking in bogus
expected results for them.

This patch unskips these tests on Chromium. Once this patch lands, I'll
go through an unskip them on the other ports as well.

  • fast/viewport/viewport-1-expected.txt:
  • fast/viewport/viewport-1.html:
  • fast/viewport/viewport-10-expected.txt:
  • fast/viewport/viewport-10.html:
  • fast/viewport/viewport-100-expected.txt:
  • fast/viewport/viewport-100.html:
  • fast/viewport/viewport-101-expected.txt:
  • fast/viewport/viewport-101.html:
  • fast/viewport/viewport-102-expected.txt:
  • fast/viewport/viewport-102.html:
  • fast/viewport/viewport-103-expected.txt:
  • fast/viewport/viewport-103.html:
  • fast/viewport/viewport-104-expected.txt:
  • fast/viewport/viewport-104.html:
  • fast/viewport/viewport-105-expected.txt:
  • fast/viewport/viewport-105.html:
  • fast/viewport/viewport-106-expected.txt:
  • fast/viewport/viewport-106.html:
  • fast/viewport/viewport-107-expected.txt:
  • fast/viewport/viewport-107.html:
  • fast/viewport/viewport-108-expected.txt:
  • fast/viewport/viewport-108.html:
  • fast/viewport/viewport-109-expected.txt:
  • fast/viewport/viewport-109.html:
  • fast/viewport/viewport-11-expected.txt:
  • fast/viewport/viewport-11.html:
  • fast/viewport/viewport-110-expected.txt:
  • fast/viewport/viewport-110.html:
  • fast/viewport/viewport-111-expected.txt:
  • fast/viewport/viewport-111.html:
  • fast/viewport/viewport-112-expected.txt:
  • fast/viewport/viewport-112.html:
  • fast/viewport/viewport-113-expected.txt:
  • fast/viewport/viewport-113.html:
  • fast/viewport/viewport-114-expected.txt:
  • fast/viewport/viewport-114.html:
  • fast/viewport/viewport-115-expected.txt:
  • fast/viewport/viewport-115.html:
  • fast/viewport/viewport-116-expected.txt:
  • fast/viewport/viewport-116.html:
  • fast/viewport/viewport-117-expected.txt:
  • fast/viewport/viewport-117.html:
  • fast/viewport/viewport-118-expected.txt:
  • fast/viewport/viewport-118.html:
  • fast/viewport/viewport-119-expected.txt:
  • fast/viewport/viewport-119.html:
  • fast/viewport/viewport-12-expected.txt:
  • fast/viewport/viewport-12.html:
  • fast/viewport/viewport-120-expected.txt:
  • fast/viewport/viewport-120.html:
  • fast/viewport/viewport-121-expected.txt:
  • fast/viewport/viewport-121.html:
  • fast/viewport/viewport-122-expected.txt:
  • fast/viewport/viewport-122.html:
  • fast/viewport/viewport-123-expected.txt:
  • fast/viewport/viewport-123.html:
  • fast/viewport/viewport-124-expected.txt:
  • fast/viewport/viewport-124.html:
  • fast/viewport/viewport-125-expected.txt:
  • fast/viewport/viewport-125.html:
  • fast/viewport/viewport-126-expected.txt: Renamed from LayoutTests/platform/gtk/fast/viewport/viewport-126-expected.txt.
  • fast/viewport/viewport-126.html:
  • fast/viewport/viewport-127-expected.txt: Renamed from LayoutTests/platform/gtk/fast/viewport/viewport-127-expected.txt.
  • fast/viewport/viewport-127.html:
  • fast/viewport/viewport-128-expected.txt:
  • fast/viewport/viewport-128.html:
  • fast/viewport/viewport-129-expected.txt:
  • fast/viewport/viewport-129.html:
  • fast/viewport/viewport-13-expected.txt:
  • fast/viewport/viewport-13.html:
  • fast/viewport/viewport-130-expected.txt:
  • fast/viewport/viewport-130.html:
  • fast/viewport/viewport-131-expected.txt:
  • fast/viewport/viewport-131.html:
  • fast/viewport/viewport-132-expected.txt:
  • fast/viewport/viewport-132.html:
  • fast/viewport/viewport-14-expected.txt:
  • fast/viewport/viewport-14.html:
  • fast/viewport/viewport-15-expected.txt:
  • fast/viewport/viewport-15.html:
  • fast/viewport/viewport-16-expected.txt:
  • fast/viewport/viewport-16.html:
  • fast/viewport/viewport-17-expected.txt:
  • fast/viewport/viewport-17.html:
  • fast/viewport/viewport-18-expected.txt:
  • fast/viewport/viewport-18.html:
  • fast/viewport/viewport-19-expected.txt:
  • fast/viewport/viewport-19.html:
  • fast/viewport/viewport-2-expected.txt:
  • fast/viewport/viewport-2.html:
  • fast/viewport/viewport-20-expected.txt:
  • fast/viewport/viewport-20.html:
  • fast/viewport/viewport-21-expected.txt:
  • fast/viewport/viewport-21.html:
  • fast/viewport/viewport-22-expected.txt:
  • fast/viewport/viewport-22.html:
  • fast/viewport/viewport-23-expected.txt:
  • fast/viewport/viewport-23.html:
  • fast/viewport/viewport-24-expected.txt:
  • fast/viewport/viewport-24.html:
  • fast/viewport/viewport-25-expected.txt:
  • fast/viewport/viewport-25.html:
  • fast/viewport/viewport-26-expected.txt:
  • fast/viewport/viewport-26.html:
  • fast/viewport/viewport-27-expected.txt:
  • fast/viewport/viewport-27.html:
  • fast/viewport/viewport-28-expected.txt:
  • fast/viewport/viewport-28.html:
  • fast/viewport/viewport-29-expected.txt:
  • fast/viewport/viewport-29.html:
  • fast/viewport/viewport-3-expected.txt:
  • fast/viewport/viewport-3.html:
  • fast/viewport/viewport-30-expected.txt:
  • fast/viewport/viewport-30.html:
  • fast/viewport/viewport-31-expected.txt:
  • fast/viewport/viewport-31.html:
  • fast/viewport/viewport-32-expected.txt:
  • fast/viewport/viewport-32.html:
  • fast/viewport/viewport-33-expected.txt:
  • fast/viewport/viewport-33.html:
  • fast/viewport/viewport-34-expected.txt:
  • fast/viewport/viewport-34.html:
  • fast/viewport/viewport-35-expected.txt:
  • fast/viewport/viewport-35.html:
  • fast/viewport/viewport-36-expected.txt:
  • fast/viewport/viewport-36.html:
  • fast/viewport/viewport-37-expected.txt:
  • fast/viewport/viewport-37.html:
  • fast/viewport/viewport-38-expected.txt:
  • fast/viewport/viewport-38.html:
  • fast/viewport/viewport-39-expected.txt:
  • fast/viewport/viewport-39.html:
  • fast/viewport/viewport-4-expected.txt:
  • fast/viewport/viewport-4.html:
  • fast/viewport/viewport-40-expected.txt:
  • fast/viewport/viewport-40.html:
  • fast/viewport/viewport-41-expected.txt:
  • fast/viewport/viewport-41.html:
  • fast/viewport/viewport-42-expected.txt:
  • fast/viewport/viewport-42.html:
  • fast/viewport/viewport-43-expected.txt:
  • fast/viewport/viewport-43.html:
  • fast/viewport/viewport-44-expected.txt:
  • fast/viewport/viewport-44.html:
  • fast/viewport/viewport-45-expected.txt:
  • fast/viewport/viewport-45.html:
  • fast/viewport/viewport-46-expected.txt:
  • fast/viewport/viewport-46.html:
  • fast/viewport/viewport-47-expected.txt:
  • fast/viewport/viewport-47.html:
  • fast/viewport/viewport-48-expected.txt:
  • fast/viewport/viewport-48.html:
  • fast/viewport/viewport-49-expected.txt:
  • fast/viewport/viewport-49.html:
  • fast/viewport/viewport-5-expected.txt:
  • fast/viewport/viewport-5.html:
  • fast/viewport/viewport-50-expected.txt:
  • fast/viewport/viewport-50.html:
  • fast/viewport/viewport-51-expected.txt:
  • fast/viewport/viewport-51.html:
  • fast/viewport/viewport-52-expected.txt:
  • fast/viewport/viewport-52.html:
  • fast/viewport/viewport-53-expected.txt:
  • fast/viewport/viewport-53.html:
  • fast/viewport/viewport-54-expected.txt:
  • fast/viewport/viewport-54.html:
  • fast/viewport/viewport-55-expected.txt:
  • fast/viewport/viewport-55.html:
  • fast/viewport/viewport-56-expected.txt:
  • fast/viewport/viewport-56.html:
  • fast/viewport/viewport-57-expected.txt:
  • fast/viewport/viewport-57.html:
  • fast/viewport/viewport-58-expected.txt:
  • fast/viewport/viewport-58.html:
  • fast/viewport/viewport-59-expected.txt:
  • fast/viewport/viewport-59.html:
  • fast/viewport/viewport-6-expected.txt:
  • fast/viewport/viewport-6.html:
  • fast/viewport/viewport-60-expected.txt:
  • fast/viewport/viewport-60.html:
  • fast/viewport/viewport-61-expected.txt:
  • fast/viewport/viewport-61.html:
  • fast/viewport/viewport-62-expected.txt:
  • fast/viewport/viewport-62.html:
  • fast/viewport/viewport-63-expected.txt:
  • fast/viewport/viewport-63.html:
  • fast/viewport/viewport-64-expected.txt:
  • fast/viewport/viewport-64.html:
  • fast/viewport/viewport-65-expected.txt: Renamed from LayoutTests/platform/gtk/fast/viewport/viewport-65-expected.txt.
  • fast/viewport/viewport-65.html:
  • fast/viewport/viewport-66-expected.txt:
  • fast/viewport/viewport-66.html:
  • fast/viewport/viewport-67-expected.txt:
  • fast/viewport/viewport-67.html:
  • fast/viewport/viewport-68-expected.txt:
  • fast/viewport/viewport-68.html:
  • fast/viewport/viewport-69-expected.txt:
  • fast/viewport/viewport-69.html:
  • fast/viewport/viewport-7-expected.txt:
  • fast/viewport/viewport-7.html:
  • fast/viewport/viewport-70-expected.txt:
  • fast/viewport/viewport-70.html:
  • fast/viewport/viewport-71-expected.txt:
  • fast/viewport/viewport-71.html:
  • fast/viewport/viewport-72-expected.txt:
  • fast/viewport/viewport-72.html:
  • fast/viewport/viewport-73-expected.txt:
  • fast/viewport/viewport-73.html:
  • fast/viewport/viewport-74-expected.txt:
  • fast/viewport/viewport-74.html:
  • fast/viewport/viewport-75-expected.txt:
  • fast/viewport/viewport-75.html:
  • fast/viewport/viewport-76-expected.txt:
  • fast/viewport/viewport-76.html:
  • fast/viewport/viewport-77-expected.txt:
  • fast/viewport/viewport-77.html:
  • fast/viewport/viewport-78-expected.txt:
  • fast/viewport/viewport-78.html:
  • fast/viewport/viewport-79-expected.txt:
  • fast/viewport/viewport-79.html:
  • fast/viewport/viewport-8-expected.txt:
  • fast/viewport/viewport-8.html:
  • fast/viewport/viewport-80-expected.txt:
  • fast/viewport/viewport-80.html:
  • fast/viewport/viewport-81-expected.txt:
  • fast/viewport/viewport-81.html:
  • fast/viewport/viewport-82-expected.txt: Renamed from LayoutTests/platform/gtk/fast/viewport/viewport-82-expected.txt.
  • fast/viewport/viewport-82.html:
  • fast/viewport/viewport-83-expected.txt:
  • fast/viewport/viewport-83.html:
  • fast/viewport/viewport-84-expected.txt: Renamed from LayoutTests/platform/efl/fast/viewport/viewport-87-expected.txt.
  • fast/viewport/viewport-84.html:
  • fast/viewport/viewport-85-expected.txt:
  • fast/viewport/viewport-85.html:
  • fast/viewport/viewport-86-expected.txt:
  • fast/viewport/viewport-86.html:
  • fast/viewport/viewport-87-expected.txt: Renamed from LayoutTests/platform/gtk/fast/viewport/viewport-87-expected.txt.
  • fast/viewport/viewport-87.html:
  • fast/viewport/viewport-88-expected.txt:
  • fast/viewport/viewport-88.html:
  • fast/viewport/viewport-9-expected.txt:
  • fast/viewport/viewport-9.html:
  • fast/viewport/viewport-90-expected.txt:
  • fast/viewport/viewport-90.html:
  • fast/viewport/viewport-91-expected.txt:
  • fast/viewport/viewport-91.html:
  • fast/viewport/viewport-legacy-handheldfriendly-expected.txt:
  • fast/viewport/viewport-legacy-handheldfriendly.html:
  • fast/viewport/viewport-legacy-mobileoptimized-2-expected.txt:
  • fast/viewport/viewport-legacy-mobileoptimized-2.html:
  • fast/viewport/viewport-legacy-mobileoptimized-3-expected.txt:
  • fast/viewport/viewport-legacy-mobileoptimized-3.html:
  • fast/viewport/viewport-legacy-mobileoptimized-expected.txt:
  • fast/viewport/viewport-legacy-mobileoptimized.html:
  • fast/viewport/viewport-legacy-ordering-1-expected.txt:
  • fast/viewport/viewport-legacy-ordering-1.html:
  • fast/viewport/viewport-legacy-ordering-2-expected.txt:
  • fast/viewport/viewport-legacy-ordering-2.html:
  • fast/viewport/viewport-legacy-ordering-3-expected.txt:
  • fast/viewport/viewport-legacy-ordering-3.html:
  • fast/viewport/viewport-legacy-ordering-4-expected.txt:
  • fast/viewport/viewport-legacy-ordering-4.html:
  • fast/viewport/viewport-legacy-ordering-5-expected.txt:
  • fast/viewport/viewport-legacy-ordering-5.html:
  • fast/viewport/viewport-legacy-ordering-6-expected.txt:
  • fast/viewport/viewport-legacy-ordering-6.html:
  • fast/viewport/viewport-legacy-ordering-7-expected.txt:
  • fast/viewport/viewport-legacy-ordering-7.html:
  • fast/viewport/viewport-legacy-ordering-8-expected.txt:
  • fast/viewport/viewport-legacy-ordering-8.html:
  • fast/viewport/viewport-legacy-ordering-9-expected.txt:
  • fast/viewport/viewport-legacy-ordering-9.html:
  • fast/viewport/viewport-legacy-xhtmlmp-misplaced-doctype-expected.txt:
  • fast/viewport/viewport-legacy-xhtmlmp-misplaced-doctype.html:
  • fast/viewport/viewport-legacy-xhtmlmp-ordering-expected.txt:
  • fast/viewport/viewport-legacy-xhtmlmp-ordering.html:
  • fast/viewport/viewport-legacy-xhtmlmp.html:
  • fast/viewport/viewport-warnings-1-expected.txt:
  • fast/viewport/viewport-warnings-1.html:
  • fast/viewport/viewport-warnings-2-expected.txt:
  • fast/viewport/viewport-warnings-2.html:
  • fast/viewport/viewport-warnings-3-expected.txt:
  • fast/viewport/viewport-warnings-3.html:
  • fast/viewport/viewport-warnings-4-expected.txt:
  • fast/viewport/viewport-warnings-4.html:
  • fast/viewport/viewport-warnings-5-expected.txt:
  • fast/viewport/viewport-warnings-5.html:
  • fast/viewport/viewport-warnings-6-expected.txt:
  • fast/viewport/viewport-warnings-6.html:
  • platform/chromium/TestExpectations:
  • platform/efl/fast/viewport/viewport-126-expected.txt: Removed.
  • platform/efl/fast/viewport/viewport-127-expected.txt: Removed.
  • platform/efl/fast/viewport/viewport-65-expected.txt: Removed.
  • platform/efl/fast/viewport/viewport-82-expected.txt: Removed.
  • platform/efl/fast/viewport/viewport-84-expected.txt: Removed.
  • platform/gtk/TestExpectations:
  • platform/gtk/fast/viewport/viewport-84-expected.txt: Removed.
  • platform/gtk/fast/viewport/viewport-legacy-handheldfriendly-expected.txt: Removed.
  • platform/gtk/fast/viewport/viewport-legacy-mobileoptimized-2-expected.txt: Removed.
  • platform/gtk/fast/viewport/viewport-legacy-mobileoptimized-3-expected.txt: Removed.
  • platform/gtk/fast/viewport/viewport-legacy-mobileoptimized-expected.txt: Removed.
  • platform/gtk/fast/viewport/viewport-legacy-ordering-5-expected.txt: Removed.
  • platform/gtk/fast/viewport/viewport-legacy-ordering-6-expected.txt: Removed.
12:49 AM Changeset in webkit [122203] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Skipped a new failing test, because of a missing feature
(testRunner.setStorageDatabaseIdleInterval()).

Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-07-10
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
12:43 AM Changeset in webkit [122202] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix GTK+ build after r122175.

  • platform/graphics/texmap/TextureMapperLayer.cpp: Include

CString.h when using cairo.