Timeline



Jul 27, 2012:

11:55 PM Changeset in webkit [123957] by pkasting@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Disable failing test.
https://bugs.webkit.org/show_bug.cgi?id=92318

Unreviewed, making bots happier.

  • tests/WebViewTest.cpp:
11:55 PM Changeset in webkit [123956] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[WebGL] Align contents of drawbuffer-test.html layout test with the one in the WebGL conformance suite.
https://bugs.webkit.org/show_bug.cgi?id=92375

Patch by Nayan Kumar K <nayankk@motorola.com> on 2012-07-27
Reviewed by Kenneth Russell.

  • fast/canvas/webgl/drawingbuffer-test-expected.txt:
  • fast/canvas/webgl/drawingbuffer-test.html:
11:16 PM Changeset in webkit [123955] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Chromium rebaseline after r123285.
https://bugs.webkit.org/show_bug.cgi?id=90624

Unreviewed, rebaselining.

  • platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.png:
11:11 PM Changeset in webkit [123954] by msaboff@apple.com
  • 2 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=92573
Mac Lion: http/tests/misc/submit-post-keygen.html fails on buildbots

  • platform/mac-lion/Skipped:
11:00 PM Changeset in webkit [123953] by commit-queue@webkit.org
  • 8 edits in trunk

[EFL] Support for HTML media capture
https://bugs.webkit.org/show_bug.cgi?id=91842

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-07-27
Reviewed by Ryosuke Niwa.

.:

Add HTML media capture feature, and enable that on the Efl port.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Tools:

Add HTML media capture feature to the feature list.
In addition, enable that on the Efl port.

  • Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Remove file-input-capture.html from skipped list.

  • platform/efl/Skipped:
10:48 PM Changeset in webkit [123952] by commit-queue@webkit.org
  • 16 edits
    2 deletes in trunk/Source/WebCore

Unreviewed, rolling out r123908.
http://trac.webkit.org/changeset/123908
https://bugs.webkit.org/show_bug.cgi?id=92572

Broke Chromium Linux compile (Requested by pkasting on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-27

  • WebCore.gypi:
  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSValueKeywords.in:
  • css/mediaControls.css:
  • css/mediaControlsChromiumAndroid.css:

(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):

  • html/shadow/MediaControlElements.cpp:

(WebCore):

  • html/shadow/MediaControlElements.h:

(WebCore):

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlChromiumEnclosureElement::create):
(WebCore):
(WebCore::MediaControlChromiumEnclosureElement::shadowPseudoId):
(WebCore::MediaControls::create):
(WebCore::MediaControlRootElementChromium::create):

  • html/shadow/MediaControlRootElementChromium.h:

(MediaControlChromiumEnclosureElement):
(MediaControlRootElementChromium):

  • html/shadow/MediaControlRootElementChromiumAndroid.cpp: Removed.
  • html/shadow/MediaControlRootElementChromiumAndroid.h: Removed.
  • platform/ThemeTypes.h:
  • rendering/RenderMediaControlsChromium.cpp:

(WebCore::RenderMediaControlsChromium::paintMediaControlsPart):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paint):

  • rendering/RenderTheme.h:
  • rendering/RenderThemeChromiumAndroid.cpp:
  • rendering/RenderThemeChromiumAndroid.h:
10:12 PM Changeset in webkit [123951] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Mark three tests as flakily timing out.
https://bugs.webkit.org/show_bug.cgi?id=92570

Unreviewed, Chromium test expectations update.

  • platform/chromium/TestExpectations:
9:30 PM Changeset in webkit [123950] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[BlackBerry] Use new LocaleHandler.
https://bugs.webkit.org/show_bug.cgi?id=92548

Patch by Eli Fidler <efidler@rim.com> on 2012-07-27
Reviewed by Yong Li.

RIM PR 128381

  • platform/blackberry/LocalizedStringsBlackBerry.cpp:

(WebCore::platformLanguage):

  • platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::ResourceRequest::initializePlatformRequest):

  • platform/text/blackberry/TextBreakIteratorInternalICUBlackBerry.cpp:

(WebCore::currentSearchLocaleID):
(WebCore::currentTextBreakLocaleID):

9:29 PM Changeset in webkit [123949] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Fix broken script reference after test move.
https://bugs.webkit.org/show_bug.cgi?id=92111

Unreviewed, fixing bad test move.

  • platform/win/fast/events/panScroll-click-hyperlink.html:
9:20 PM Changeset in webkit [123948] by pkasting@chromium.org
  • 1 edit
    8 adds in trunk/LayoutTests

Chromium rebaselines after r123912.
https://bugs.webkit.org/show_bug.cgi?id=92327

Unreviewed, rebaselining.

  • platform/chromium-linux-x86/fast/hidpi: Added.
  • platform/chromium-linux-x86/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
  • platform/chromium-win-xp/fast/hidpi: Added.
  • platform/chromium-win-xp/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
  • platform/chromium-win/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
9:12 PM Changeset in webkit [123947] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Chromium rebaseline after r123706.
https://bugs.webkit.org/show_bug.cgi?id=92236

Unreviewed, rebaselining.

  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.png:
8:19 PM Changeset in webkit [123946] by pkasting@chromium.org
  • 1 edit
    10 adds in trunk/LayoutTests

Chromium rebaselines after r123790.
https://bugs.webkit.org/show_bug.cgi?id=92059

Unreviewed, rebaselining.

  • platform/chromium-linux-x86/css3/filters/effect-brightness-clamping-expected.txt: Added.
  • platform/chromium-linux-x86/css3/filters/effect-brightness-clamping-hw-expected.txt: Added.
  • platform/chromium-linux/css3/filters/effect-brightness-clamping-expected.txt: Added.
  • platform/chromium-linux/css3/filters/effect-brightness-clamping-hw-expected.txt: Added.
  • platform/chromium-win-xp/css3: Added.
  • platform/chromium-win-xp/css3/filters: Added.
  • platform/chromium-win-xp/css3/filters/effect-brightness-clamping-expected.txt: Added.
  • platform/chromium-win-xp/css3/filters/effect-brightness-clamping-hw-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-brightness-clamping-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-brightness-clamping-hw-expected.txt: Added.
6:23 PM Changeset in webkit [123945] by commit-queue@webkit.org
  • 32 edits in trunk/Source/WebCore

Change constructor with explicit constructor in WebCore/Modules
https://bugs.webkit.org/show_bug.cgi?id=92529

Patch by Gyuyoung Kim <gyuyoung.kim@samsung.com> on 2012-07-27
Reviewed by Kentaro Hara.

As a step to let *explicit* keyword add to constructors which have a parameter,
*explicit* keyword is added to Source/WebCore/Modules in order to avoid implicit
type conversion.

No new tests. Covered by existing tests.

  • Modules/filesystem/LocalFileSystem.h:

(WebCore::LocalFileSystem::LocalFileSystem):

  • Modules/filesystem/Metadata.h:

(WebCore::Metadata::Metadata):

  • Modules/filesystem/SyncCallbackHelper.h:

(WebCore::SyncCallbackHelper::SuccessCallbackImpl::SuccessCallbackImpl):
(WebCore::SyncCallbackHelper::ErrorCallbackImpl::ErrorCallbackImpl):

  • Modules/mediastream/IceCandidate.h:

(IceCandidate):

  • Modules/mediastream/NavigatorUserMediaError.h:

(WebCore::NavigatorUserMediaError::NavigatorUserMediaError):

  • Modules/mediastream/SessionDescription.h:

(SessionDescription):

  • Modules/mediastream/UserMediaController.h:

(UserMediaController):

  • Modules/notifications/NotificationController.h:

(NotificationController):

  • Modules/speech/SpeechRecognition.h:

(SpeechRecognition):

  • Modules/speech/SpeechRecognitionController.h:

(SpeechRecognitionController):

  • Modules/speech/SpeechRecognitionEvent.h:

(SpeechRecognitionEvent):

  • Modules/speech/SpeechRecognitionResultList.h:

(SpeechRecognitionResultList):

  • Modules/vibration/Vibration.h:

(Vibration):

  • Modules/webaudio/AudioBuffer.h:

(AudioBuffer):

  • Modules/webaudio/AudioContext.h:

(AudioContext):

  • Modules/webaudio/AudioNodeInput.h:

(AudioNodeInput):

  • Modules/webaudio/AudioSummingJunction.h:

(AudioSummingJunction):

  • Modules/webaudio/BiquadDSPKernel.h:

(WebCore::BiquadDSPKernel::BiquadDSPKernel):

  • Modules/webaudio/DefaultAudioDestinationNode.h:

(DefaultAudioDestinationNode):

  • Modules/webaudio/DelayDSPKernel.h:

(DelayDSPKernel):

  • Modules/webaudio/OfflineAudioCompletionEvent.h:

(OfflineAudioCompletionEvent):

  • Modules/webaudio/WaveShaperDSPKernel.h:

(WebCore::WaveShaperDSPKernel::WaveShaperDSPKernel):

  • Modules/webaudio/WaveShaperNode.h:

(WaveShaperNode):

  • Modules/webaudio/WaveTable.h:

(WaveTable):

  • Modules/webdatabase/DatabaseAuthorizer.h:

(DatabaseAuthorizer):

  • Modules/webdatabase/DatabaseTask.h:

(Database::DatabaseTransactionTask):

  • Modules/webdatabase/DatabaseTracker.h:

(DatabaseTracker):

  • Modules/webdatabase/SQLCallbackWrapper.h:

(WebCore::SQLCallbackWrapper::SafeReleaseTask::SafeReleaseTask):

  • Modules/webdatabase/SQLException.h:

(WebCore::SQLException::SQLException):

  • Modules/websockets/WebSocket.h:
  • Modules/websockets/WebSocketExtensionProcessor.h:

(WebCore::WebSocketExtensionProcessor::WebSocketExtensionProcessor):

6:21 PM Changeset in webkit [123944] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[V8] Optimize Element::getAttributeNS() by replacing String with AtomicString
https://bugs.webkit.org/show_bug.cgi?id=90276

Patch by Kentaro Hara <haraken@chromium.org> on 2012-07-27
Reviewed by Adam Barth.

In r121439, we changed the argument type of Element::getAttribute()
from String to AtomicString for optimization. This patch changes the
argument type of Element::getAttributeNS() from String to AtomicString.

Actually this change affects V8 performance only.

[JSC without the patch]
The binding code converts a given JavaScript string to a String
-> the String is passed to getAttributeNS()
-> the String is converted to an AtomicString when it is passed to
QualifiedName() constructor.

[JSC with the patch]
The binding code converts a given JavaScript string to a String
-> the String is converted to an AtomicString when it is passed to
getAttributeNS()
-> the AtomicString is passed to QualifiedName() constructor.

[V8 without the patch]
The binding code retrieves a cached external String for a given
JavaScript string
-> the String is passed to getAttributeNS()
-> the String is converted to AtomicString when it is passed to
QualifiedName() constructor.

[V8 with the patch]
The binding code retrieves a cached external AtomicString for a given
JavaScript string
-> the AtomicString is passed to getAttributeNS()
-> the AtomicString is passed to QualifiedName() constructor.

In this way, in JSC, the change affects where a String is converted to
an AtomicString. On the other hand, in V8, (since the AtomicString is already
cached,) we can skip the conversion step.

Performance test: https://bugs.webkit.org/attachment.cgi?id=150158

getAttributeNS (Chromium/Linux):
577.80ms => 454.60ms

  • dom/Element.cpp:

(WebCore::Element::getAttributeNS):

  • dom/Element.h:

(Element):

6:02 PM Changeset in webkit [123943] by commit-queue@webkit.org
  • 12 edits in trunk/Source

Unreviewed, rolling out r123679.
http://trac.webkit.org/changeset/123679
https://bugs.webkit.org/show_bug.cgi?id=92565

Slowed down HTML parsing by 3.6% (Requested by abarth on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-27

Source/WebCore:

  • html/FTPDirectoryDocument.cpp:

(WebCore::FTPDirectoryDocumentParser::append):

  • html/parser/HTMLEntityParser.cpp:

(WebCore::HTMLEntityParser::consumeNamedEntity):

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::stripLeadingAndTrailingHTMLSpaces):

  • html/parser/HTMLSourceTracker.cpp:

(WebCore::HTMLSourceTracker::sourceForToken):

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::script):

  • platform/text/SegmentedString.cpp:

(WebCore::SegmentedString::SegmentedString):
(WebCore::SegmentedString::operator=):
(WebCore::SegmentedString::clear):
(WebCore::SegmentedString::append):
(WebCore::SegmentedString::prepend):
(WebCore::SegmentedString::advanceSubstring):
(WebCore::SegmentedString::advance):
(WebCore::SegmentedString::advanceSlowCase):
(WebCore::SegmentedString::advanceAndUpdateLineNumberSlowCase):

  • platform/text/SegmentedString.h:

(WebCore::SegmentedSubstring::SegmentedSubstring):
(WebCore::SegmentedSubstring::clear):
(WebCore::SegmentedSubstring::appendTo):
(SegmentedSubstring):
(WebCore::SegmentedString::SegmentedString):
(WebCore::SegmentedString::push):
(WebCore::SegmentedString::isEmpty):
(WebCore::SegmentedString::lookAhead):
(WebCore::SegmentedString::lookAheadIgnoringCase):
(WebCore::SegmentedString::advance):
(WebCore::SegmentedString::advanceAndASSERT):
(WebCore::SegmentedString::advanceAndASSERTIgnoringCase):
(WebCore::SegmentedString::advancePastNewlineAndUpdateLineNumber):
(SegmentedString):
(WebCore::SegmentedString::advancePastNonNewline):
(WebCore::SegmentedString::advanceAndUpdateLineNumber):
(WebCore::SegmentedString::operator*):
(WebCore::SegmentedString::operator->):
(WebCore::SegmentedString::current):
(WebCore::SegmentedString::equalsLiterally):
(WebCore::SegmentedString::equalsIgnoringCase):
(WebCore::SegmentedString::lookAheadInline):
(WebCore::SegmentedString::lookAheadSlowCase):

  • xml/parser/CharacterReferenceParserInlineMethods.h:

(WebCore::consumeCharacterReference):

  • xml/parser/MarkupTokenizerBase.h:

(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::nextInputCharacter):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::peek):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::advance):

Source/WTF:

  • wtf/text/WTFString.h:
5:41 PM Changeset in webkit [123942] by jer.noble@apple.com
  • 4 edits in trunk/Source/WebCore

Reset the set of "seen" plugins when the main frame load is committed.
https://bugs.webkit.org/show_bug.cgi?id=92564

Reviewed by Anders Carlsson.

Because the Page object is re-used across navigation and reload, reset the list
of seen plugins when the main frame load commits. This gives a good baseline to
compare against the number of pages loaded.

No new tests; the "seen" plugin list is for diagnostic purposes only.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::dispatchDidCommitLoad):

  • page/Page.cpp:

(WebCore::Page::resetSeenPlugins):

  • page/Page.h:
5:34 PM Changeset in webkit [123941] by dpranke@chromium.org
  • 3 edits in trunk/Tools

"webkit-patch rebaseline <test>" fails with exit_code 1
https://bugs.webkit.org/show_bug.cgi?id=91560

Reviewed by Adam Barth.

webkit-patch rebaseline-json crashes in an svn checkout if it
tries to add files and there are no files to add; arguably
svn.add() should be robust against this, but rebaseline-json
shouldn't be calling it, either. This patch fixes the latter and
adds better debugging info to garden-o-matic so we can see what
caused the crash.

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(AbstractParallelRebaselineCommand._rebaseline):

  • Scripts/webkitpy/tool/servers/gardeningserver.py:

(GardeningHTTPRequestHandler.rebaselineall):
(GardeningHTTPRequestHandler.rebaselineall.error_handler):
(GardeningHTTPRequestHandler):

5:32 PM Changeset in webkit [123940] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

execCommand copies the backgroung-color of the enclosing element to the element being edited.
https://bugs.webkit.org/show_bug.cgi?id=91783

Patch by Sukolsak Sakshuwong <sukolsak@google.com> on 2012-07-27
Reviewed by Ryosuke Niwa.

Source/WebCore:

InsertListCommand and some other edit commands remove redundant
style properties after their DOM modification by using
StylePropertySet::removeEquivalentProperties. However, this method
does not remove redundant background-color properties such as
"background-color: white" and "background-color: #fff" because
it compares them using cssText and thus treats them as different.
Add code to convert background colors to RGBA and then compare them.

Test: editing/style/redundant-background-color.html

  • editing/EditingStyle.cpp:

(WebCore::getRGBABackgroundColor):
(WebCore):
(WebCore::getPropertiesNotIn):

LayoutTests:

This tests to make sure that WebKit removes redundant "background-color"
property after execCommand.

  • editing/style/redundant-background-color-expected.txt: Added.
  • editing/style/redundant-background-color.html: Added.
5:30 PM Changeset in webkit [123939] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Return 0 when network is offline
https://bugs.webkit.org/show_bug.cgi?id=92454

Patch by Gyuyoung Kim <gyuyoung.kim@samsung.com> on 2012-07-27
Reviewed by Kenneth Rohde Christiansen.

Network Info latest spec says 0 is returned when network is offline.
r123769 modified to return infinity value when network is offiline.

  • platform/efl/NetworkInfoProviderEfl.cpp:

(WebCore::NetworkInfoProviderEfl::bandwidth):

5:08 PM Changeset in webkit [123938] by rniwa@webkit.org
  • 5 edits in trunk

Unreviewed perf-o-matic build fix for dashboard image generation.
Also, only show Parser/html5-full-render on the dashboard by default
so that it won't take forever to load it.

  • Websites/webkit-perf.appspot.com/controller.py:

(schedule_runs_update):
(RunsChartHandler.post):

  • Websites/webkit-perf.appspot.com/models.py:

(Runs.chart_params):
(DashboardImage.get_image):

  • Websites/webkit-perf.appspot.com/models_unittest.py:

(RunsTest.test_chart_params_with_value):

4:51 PM Changeset in webkit [123937] by commit-queue@webkit.org
  • 13 edits in trunk

Change navigator.webkitGamepads[] to navigator.webkitGetGamepads()
https://bugs.webkit.org/show_bug.cgi?id=92533

Patch by Scott Graham <scottmg@chromium.org> on 2012-07-27
Reviewed by Adam Barth.

Source/WebCore:

Per discussion on public-webapps. Pages that enumerate navigator were
causing background resources to be created to poll hardware
unintentionally. By changing to an explicit function call, this is
avoided (and the API becomes more clear too). This change updates the
implementation to match the current ED spec.

  • Modules/gamepad/NavigatorGamepad.cpp:

(WebCore::NavigatorGamepad::webkitGetGamepads):

  • Modules/gamepad/NavigatorGamepad.h:

(NavigatorGamepad):

  • Modules/gamepad/NavigatorGamepad.idl:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setWebkitGetGamepadsEnabled):
(WebCore::RuntimeEnabledFeatures::webkitGetGamepadsEnabled):

Source/WebKit/chromium:

Renames for updated access point.

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableGamepad):
(WebKit::WebRuntimeFeatures::isGamepadEnabled):

LayoutTests:

Updates for renamed access point.

  • gamepad/gamepad-api-expected.txt:
  • gamepad/gamepad-api.html:
  • gamepad/gamepad-polling-access-expected.txt:
  • gamepad/gamepad-polling-access.html:
  • platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
4:44 PM Changeset in webkit [123936] by beidson@apple.com
  • 14 edits
    3 adds in trunk

Plugins should not be allowed to override standard properties/attributes in non-standard worlds
<rdar://problem/11975252> and https://bugs.webkit.org/show_bug.cgi?id=92519

Reviewed by Anders Carlsson.

Source/WebCore:

Change the 3 plugin-owning element's custom bindings to prefer built-in properties if they exist.
When they do they don't give the plugin a chance to override.

Test: plugins/npruntime/overrides-all-properties.html

Add plugin custom functions to prefer built-in properties over plugin scriptable object properties:

  • bindings/js/JSPluginElementFunctions.h:

(WebCore::pluginElementCustomGetOwnPropertySlot):
(WebCore::pluginElementCustomGetOwnPropertyDescriptor):

Use those new custom functions for getting properties:

  • bindings/js/JSHTMLAppletElementCustom.cpp:

(WebCore::JSHTMLAppletElement::getOwnPropertySlotDelegate):
(WebCore::JSHTMLAppletElement::getOwnPropertyDescriptorDelegate):

  • bindings/js/JSHTMLEmbedElementCustom.cpp:

(WebCore::JSHTMLEmbedElement::getOwnPropertySlotDelegate):
(WebCore::JSHTMLEmbedElement::getOwnPropertyDescriptorDelegate):

  • bindings/js/JSHTMLObjectElementCustom.cpp:

(WebCore::JSHTMLObjectElement::getOwnPropertySlotDelegate):
(WebCore::JSHTMLObjectElement::getOwnPropertyDescriptorDelegate):

Tools:

Add a test plugin which overrides all properties it is asked about:

  • DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableObjectOverridesAllProperties.cpp: Added.

(PluginScriptableObjectOverridesAllProperties):
(PluginScriptableObjectOverridesAllProperties::PluginScriptableObjectOverridesAllProperties):
(PluginObject):
(PluginScriptableObjectOverridesAllProperties::PluginObject::PluginObject):
(PluginScriptableObjectOverridesAllProperties::PluginObject::~PluginObject):
(PluginScriptableObjectOverridesAllProperties::PluginObject::hasProperty):
(PluginScriptableObjectOverridesAllProperties::PluginObject::getProperty):
(PluginScriptableObjectOverridesAllProperties::NPP_GetValue):

Expose NPN_MemAlloc to the test plugin:

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:

(PluginTest::NPN_MemAlloc):

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h:

(PluginTest):

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:

LayoutTests:

  • plugins/npruntime/overrides-all-properties-expected.txt: Added.
  • plugins/npruntime/overrides-all-properties.html: Added.
  • platform/chromium/TestExpectations: Test behaves different in V8, so skip on chromium
4:32 PM Changeset in webkit [123935] by commit-queue@webkit.org
  • 14 edits
    3 adds in trunk

use createUninitialized when creating TypedArray from another array
https://bugs.webkit.org/show_bug.cgi?id=92518

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-07-27
Reviewed by Kenneth Russell.

PerformanceTests:

  • Bindings/typed-array-construct-from-array.html: Added.

Source/WebCore:

When creating a Typed Array from another array, we fill it with values
from the source array. So, we can create it uninitialized. This is
make constructor about 35% faster when constructed with another typed
array.

Test: fast/canvas/webgl/array-constructor.html

  • bindings/js/JSArrayBufferViewHelper.h:

(WebCore::constructArrayBufferViewWithTypedArrayArgument):
(WebCore::constructArrayBufferView):

Source/WTF:

Expose a createUninitialized static method on TypedArray classes.

  • wtf/Float32Array.h:

(Float32Array):
(WTF::Float32Array::createUninitialized):
(WTF):

  • wtf/Float64Array.h:

(Float64Array):
(WTF::Float64Array::createUninitialized):
(WTF):

  • wtf/Int16Array.h:

(Int16Array):
(WTF::Int16Array::createUninitialized):
(WTF):

  • wtf/Int32Array.h:

(Int32Array):
(WTF::Int32Array::createUninitialized):
(WTF):

  • wtf/Int8Array.h:

(Int8Array):
(WTF::Int8Array::createUninitialized):
(WTF):

  • wtf/Uint16Array.h:

(Uint16Array):
(WTF::Uint16Array::createUninitialized):
(WTF):

  • wtf/Uint32Array.h:

(Uint32Array):
(WTF::Uint32Array::createUninitialized):
(WTF):

  • wtf/Uint8Array.h:

(Uint8Array):
(WTF::Uint8Array::createUninitialized):
(WTF):

  • wtf/Uint8ClampedArray.h:

(Uint8ClampedArray):

LayoutTests:

Add test to check that constructing a Typed Array with nan values does
not result in random values.

  • fast/canvas/webgl/array-constructor-expected.txt: Added.
  • fast/canvas/webgl/array-constructor.html: Added.
4:29 PM Changeset in webkit [123934] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[BlackBerry] Adapt to change in the FontInfo platform API.
https://bugs.webkit.org/show_bug.cgi?id=92547

Patch by Eli Fidler <efidler@rim.com> on 2012-07-27
Reviewed by Yong Li

RIM PR 161263

Source/WebCore:

  • page/blackberry/SettingsBlackBerry.cpp:

(WebCore::Settings::initializeDefaultFontFamilies):

Source/WebKit/blackberry:

  • Api/WebSettings.cpp:

(BlackBerry::WebKit::WebSettings::standardSettings):

4:12 PM Changeset in webkit [123933] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Assertion hit in ewk_cookie_manager.cpp
https://bugs.webkit.org/show_bug.cgi?id=92544

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-27
Reviewed by Kenneth Rohde Christiansen.

Removed wrong assertion in ewk_cookie_manager.cpp
and replace it by an if check. The assertion was
sometimes hit by our unit tests.

  • UIProcess/API/efl/ewk_cookie_manager.cpp:

(cookiesDidChange):

4:02 PM Changeset in webkit [123932] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Fix color matrix filter computation so that filters that don't need clamping are correctly detected as such
https://bugs.webkit.org/show_bug.cgi?id=92452

Patch by Antoine Labour <piman@chromium.org> on 2012-07-27
Reviewed by Stephen White.

Because of precision issues, some filters were returning true to
matrixNeedsClamping when they can return false. This fixes it.

No new tests in this CL, a follow-up change refactors the code to add
several tests.

  • platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:
3:59 PM Changeset in webkit [123931] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Split functionality of MarkedAllocator::m_currentBlock
https://bugs.webkit.org/show_bug.cgi?id=92550

Reviewed by Filip Pizlo.

MarkedAllocator::m_currentBlock serves two purposes right now; it indicates the block that is currently
being used for allocation and the beginning of the list of blocks that need to be swept. We should split
these two functionalities into two separate fields.

  • heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::tryAllocateHelper): Use m_blocksToSweep instead of m_currentBlock as the
initializer/reference of the loop. Only change m_currentBlock when we know what the result will be.
(JSC::MarkedAllocator::addBlock): When we add a new block we know that both m_blocksToSweep and
m_currentBlock are null. In order to preserve the invariant that m_currentBlock <= m_blocksToSweep,
we assign both of them to point to the new block.
(JSC::MarkedAllocator::removeBlock): We need a separate check to see if the block we're removing is
m_blocksToSweep and if so, advance it to the next block in the list.

  • heap/MarkedAllocator.h:

(MarkedAllocator): Initialize m_blocksToSweep.
(JSC::MarkedAllocator::MarkedAllocator):
(JSC::MarkedAllocator::reset): We set m_blocksToSweep to be the head of our list. This function is called
at the end of a collection, so all of the blocks in our allocator need to be swept. We need to sweep a
block before we can start allocating, so m_currentBlock is set to null. We also set the freeList to
the empty FreeList to emphasize the fact that we can't start allocating until we do some sweeping.

3:58 PM Changeset in webkit [123930] by jer.noble@apple.com
  • 8 edits in trunk/Source/WebCore

Add diagnostic logging for plugins-per-page.
https://bugs.webkit.org/show_bug.cgi?id=92538

Reviewed by Anders Carlsson.

Add some diagnostic logging for whether a page has seen a plugin, and
whether a page has seen a plugin of a specific type.

Move the diagnostic logging out of the elemements themselves:

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::updateWidget):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateWidget):

Instead, log when the plugin is requested, thereby catching plugins which are
rejected because, e.g., Java is disabled or not installed:

  • loader/SubframeLoader.cpp:

(WebCore::logPluginRequest):
(WebCore::SubframeLoader::requestObject):
(WebCore::SubframeLoader::createJavaAppletWidget):

Add new diagnostic key values:

  • page/DiagnosticLoggingKeys.cpp:

(WebCore::DiagnosticLoggingKeys::pageContainsPluginKey):
(WebCore::DiagnosticLoggingKeys::pageContainsAtLeastOnePluginKey):

  • page/DiagnosticLoggingKeys.h:

Add a map of plugin types seen per-page for diagnostic purposes:

  • page/Page.cpp:

(WebCore::Page::hasSeenAnyPlugin):
(WebCore::Page::hasSeenPlugin):
(WebCore::Page::sawPlugin):

  • page/Page.h:
3:46 PM Changeset in webkit [123929] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[WINCE] Use macros from ICU instead of defining the same functionality again
https://bugs.webkit.org/show_bug.cgi?id=92530

Patch by Patrick Gansterer <Patrick Gansterer> on 2012-07-27
Reviewed by Ryosuke Niwa.

Replace isHighSurrogate() with U16_IS_LEAD(), isLowSurrogate() with
U16_IS_TRAIL() and surrogateToUcs4() with U16_GET_SUPPLEMENTARY().

Source/WebCore:

  • html/FTPDirectoryDocument.cpp:

(WebCore::processFileDateString):

  • loader/archive/mhtml/MHTMLArchive.cpp:

(WebCore::MHTMLArchive::generateMHTMLData):

  • platform/graphics/wince/FontWinCE.cpp:

(WebCore::generateComponents):

Source/WTF:

  • wtf/unicode/wince/UnicodeWinCE.h:
3:41 PM Changeset in webkit [123928] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Build warning in CSSPrimitiveValueMappings.h when CSS_STICKY_POSITION is disabled
https://bugs.webkit.org/show_bug.cgi?id=92523

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-27
Reviewed by Simon Fraser.

Move #ifdef in CSSPrimitiveValueMappings.h to silent compilation warning
when CSS_STICKY_POSITION is disabled.

No new tests, no behavior change.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

3:37 PM Changeset in webkit [123927] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

DragController should ascertain dragClient to be non-null
https://bugs.webkit.org/show_bug.cgi?id=92474

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-07-27
Reviewed by Tony Chang.

The DragController must always ensure a valid dragClient object. Hence
adding the ASSERT to assure that.

No new tests. Added assertion for PageClient.dragClient.

  • page/DragController.cpp:

(WebCore::DragController::DragController):

3:30 PM Changeset in webkit [123926] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[chromium] Clean up LayerRendererChromium::drawTexturedQuad
https://bugs.webkit.org/show_bug.cgi?id=91823

Patch by Adrienne Walker <enne@google.com> on 2012-07-27
Reviewed by James Robinson.

LayerRendererChromium::drawTexturedQuad has been around forever and
over time has developed several problems:

  • Confusingly named relative to drawTextureQuad
  • All but one callers identically manipulate the transform matrix
  • Lots of optional parameters that only few functions use

This patch breaks up drawTexturedQuad into setShaderOpacity (for
optional opacity values sent to the shader), setShaderFloatQuad (the
full FloatQuad used by AA shaders), and drawQuadGeometry (actually
draw the geometry, and wrap the transform logic that was duplicated
everywhere).

No new tests; no change in functionality.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawCheckerboardQuad):
(WebCore::LayerRendererChromium::drawBackgroundFilters):
(WebCore::LayerRendererChromium::drawRenderPassQuad):
(WebCore::LayerRendererChromium::drawSolidColorQuad):
(WebCore::LayerRendererChromium::drawTileQuad):
(WebCore::LayerRendererChromium::drawYUVVideoQuad):
(WebCore::LayerRendererChromium::drawStreamVideoQuad):
(WebCore::LayerRendererChromium::drawTextureQuad):
(WebCore::LayerRendererChromium::drawIOSurfaceQuad):
(WebCore::LayerRendererChromium::drawHeadsUpDisplay):
(WebCore::LayerRendererChromium::setShaderFloatQuad):
(WebCore::LayerRendererChromium::setShaderOpacity):
(WebCore::LayerRendererChromium::drawQuadGeometry):
(WebCore::LayerRendererChromium::copyTextureToFramebuffer):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

3:20 PM Changeset in webkit [123925] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WTF

[Qt] Fix build after r123917
https://bugs.webkit.org/show_bug.cgi?id=92555

Unreviewed.

  • wtf/GregorianDateTime.h: Needs string.h for memset().
3:10 PM Changeset in webkit [123924] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

"webkit-patch upload" should strip colors from patch if necessary
https://bugs.webkit.org/show_bug.cgi?id=92306

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-07-27
Reviewed by Adam Barth.

  • Scripts/webkitpy/common/checkout/scm/git.py: Explicity remove colors from diff.
3:07 PM Changeset in webkit [123923] by caio.oliveira@openbossa.org
  • 26 edits
    2 deletes in trunk/LayoutTests

[Qt] Remaining rebaselines after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92552

Unreviewed.

Unskip a bunch of tests, organize the remaining skips. The mentions to bug 85203 were
removed now. A last batch of WK1 results were associated with the bug 91610.

  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0-wk2/fullscreen/full-screen-placeholder-expected.txt:
  • platform/qt-5.0/Skipped:
  • platform/qt/editing/input/caret-at-the-edge-of-input-expected.txt:
  • platform/qt/editing/input/reveal-caret-of-multiline-input-expected.txt:
  • platform/qt/http/tests/cache/cancel-during-revalidation-succeeded-expected.txt: Removed.
  • platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
  • platform/qt/http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt: Removed.
  • platform/qt/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-3-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-4-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-stretch-1-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-stretch-2-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-stretch-3-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-stretch-4-expected.txt:
  • platform/qt/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
  • platform/qt/svg/text/select-x-list-1-expected.txt:
  • platform/qt/svg/text/select-x-list-2-expected.txt:
  • platform/qt/svg/text/select-x-list-3-expected.txt:
  • platform/qt/svg/text/select-x-list-4-expected.txt:
  • platform/qt/svg/text/select-x-list-with-tspans-1-expected.txt:
  • platform/qt/svg/text/select-x-list-with-tspans-2-expected.txt:
  • platform/qt/svg/text/select-x-list-with-tspans-3-expected.txt:
  • platform/qt/svg/text/select-x-list-with-tspans-4-expected.txt:
  • platform/qt/svg/text/selection-doubleclick-expected.txt:
3:07 PM Changeset in webkit [123922] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-536.26-branch

Merged r116357. <rdar://problem/11942044>

3:04 PM Changeset in webkit [123921] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] CCLayerTreeHost placeholder scissor should be deviceViewportSize instead of viewportSize
https://bugs.webkit.org/show_bug.cgi?id=92469

Patch by Shawn Singh <shawnsingh@chromium.org> on 2012-07-27
Reviewed by Adrienne Walker.

We were accidentally using viewportSize instead of
deviceViewportSize in a particular place in code. Recent
refactoring to use tighter scissor rects exposed this problem.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::updateLayers):

2:56 PM Changeset in webkit [123920] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

clean-pending-commit throws exception when encountering Ossy
https://bugs.webkit.org/show_bug.cgi?id=92534

Patch by Eric Seidel <eric@webkit.org> on 2012-07-27
Reviewed by Adam Barth.

Mark a couple strings as unicode so that reviewers with unicode names do not cause
clean-pending-commit to barf.

  • Scripts/webkitpy/tool/commands/upload.py:

(CleanPendingCommit._flags_to_clear_on_patch):
(CleanPendingCommit.execute):
(AssignToCommitter._assign_bug_to_last_patch_attacher):

2:49 PM Changeset in webkit [123919] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Search cancel button is hard to activate with a tap gesture even if touch adjustment is enabled.
https://bugs.webkit.org/show_bug.cgi?id=91894

Patch by Kevin Ellis <kevers@chromium.org> on 2012-07-27
Reviewed by Antonio Gomes.

Source/WebCore:

Update check for determining if a node responds to tap gestures.
Previously, the cancel button was being discarded as a candidate for
touch adjustment if the touch area clipped the text input region
because the candidate pruning process failed to account for the cancel
button having a default mouse handler. Possibly an interim fix,
depending on resolution to 92093.

Test: touchadjustment/search-cancel.html

  • page/TouchAdjustment.cpp:

(TouchAdjustment):
(WebCore::TouchAdjustment::nodeRespondsToTapGesture):

LayoutTests:

Add test for touch adjustment in the vicinity of a search cancel button.
Prior to the patch, the cancel button was pruned as a candidate if the
touch area clipped the input field.

  • touchadjustment/search-cancel-expected.txt: Added.
  • touchadjustment/search-cancel.html: Added.
2:48 PM Changeset in webkit [123918] by dpranke@chromium.org
  • 1 edit
    1 add in trunk/Tools

chromium win compile broken after removing webkit.py
https://bugs.webkit.org/show_bug.cgi?id=92549

Unreviewed, build fix.

It turns out that this file is listed in the chromium downstream
'browser_tests.isolate' file, and so deleting it broke gyp.
Adding a stub file back in until we can remove the entry from
the file.

  • Scripts/webkitpy/layout_tests/port/webkit.py: Added.
2:40 PM Changeset in webkit [123917] by Patrick Gansterer
  • 2 edits in trunk/Source/WTF

MinGW build fails because of missing header in GregorianDateTime.h
https://bugs.webkit.org/show_bug.cgi?id=92531

Patch by Paweł Forysiuk <tuxator@o2.pl> on 2012-07-27

  • wtf/GregorianDateTime.h: Include time.h
2:10 PM CommitterTips edited by peter@chromium.org
Clarify that new committers should manually commit the change to … (diff)
2:04 PM Changeset in webkit [123916] by dpranke@chromium.org
  • 13 edits
    2 deletes in trunk/Tools

nrwt: remove 'webkit.py' and the 'WebKitPort'
https://bugs.webkit.org/show_bug.cgi?id=92450

Reviewed by Ryosuke Niwa.

This patch finishes the work of merging WebKitPort into Port.
Now Port is way too big :).

This is all cutting and pasting; no new functionality and
no changes in the tests.

  • Scripts/webkitpy/layout_tests/port/apple.py:

(ApplePort):
(ApplePort.init):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.skipped_layout_tests):
(Port):
(Port._port_flag_for_scripts):
(Port._arguments_for_configuration):
(Port._run_script):
(Port._build_driver):
(Port._build_driver_flags):
(Port._tests_for_other_platforms):
(Port._runtime_feature_list):
(Port.nm_command):
(Port._modules_to_search_for_symbols):
(Port._symbols_string):
(Port._missing_feature_to_skipped_tests):
(Port._missing_symbol_to_skipped_tests):
(Port._has_test_in_directories):
(Port._skipped_tests_for_unsupported_features):
(Port._wk2_port_name):
(Port._skipped_file_search_paths):

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort):

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:
  • Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:

(ChromiumPortTestCase.test_check_build):

  • Scripts/webkitpy/layout_tests/port/driver_unittest.py:
  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort):
(EflPort.init):

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort):
(GtkPort.setup_environ_for_server):

  • Scripts/webkitpy/layout_tests/port/port_testcase.py:

(TestWebKitPort):
(TestWebKitPort.init):
(TestWebKitPort.all_test_configurations):
(TestWebKitPort._symbols_string):
(TestWebKitPort._tests_for_other_platforms):
(TestWebKitPort._tests_for_disabled_features):
(PortTestCase):
(PortTestCase.test_diff_image):
(PortTestCase.test_path_to_test_expectations_file):
(PortTestCase.test_skipped_directories_for_symbols):
(test_skipped_directories_for_features):
(test_skipped_directories_for_features_no_matching_tests_in_test_list):
(test_skipped_tests_for_unsupported_features_empty_test_list):
(test_skipped_layout_tests):
(test_skipped_file_search_paths):
(test_root_option):
(test_test_expectations):
(test_build_driver):
(_assert_config_file_for_platform):
(test_linux_distro_detection):
(test_apache_config_file_name_for_platform):
(test_path_to_apache_config_file):

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort):
(QtPort.init):
(QtPort.setup_environ_for_server):

  • Scripts/webkitpy/layout_tests/port/webkit.py: Removed.
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Removed.
  • Scripts/webkitpy/tool/servers/rebaselineserver.py:

(get_test_baselines.AllPlatformsPort):
(get_test_baselines.AllPlatformsPort.init):

  • Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:

(get_test_config.TestMacPort):

1:48 PM Changeset in webkit [123915] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Don't use an NSUserDefault for disabling the web process sandbox
https://bugs.webkit.org/show_bug.cgi?id=92542
<rdar://problem/11976060>

Reviewed by Mark Rowe.

The user default was really helpful during WebKit2 bringup, but we no longer need to pay the IPC cost of initializing NSUserDefaults at startup,
so get rid of the preference and use a good old #ifdef instead.

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::initializeSandbox):

1:43 PM Changeset in webkit [123914] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk

Animated SVGs do not clear previous frame completely in hidpi mode.
https://bugs.webkit.org/show_bug.cgi?id=92395

Patch by Varun Jain <varunjain@chromium.org> on 2012-07-27
Reviewed by Darin Adler.

Source/WebCore:

The rect thats is cleared in subsequent frames needed to be scaled with device scale.

Test: svg/as-image/animated-svg-repaints-completely-in-hidpi.html

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawSVGToImageBuffer):

LayoutTests:

  • platform/chromium/TestExpectations:
  • platform/mac/svg/as-image/animated-svg-repaints-completely-in-hidpi-expected.png: Added.
  • platform/mac/svg/as-image/animated-svg-repaints-completely-in-hidpi-expected.txt: Added.
  • svg/as-image/animated-svg-repaints-completely-in-hidpi.html: Added.
  • svg/as-image/resources/animated-rect-fixed-size-3.svg: Added.
1:41 PM Changeset in webkit [123913] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Fix COMPILE_ASSERT for InlineFlowBox growing
https://bugs.webkit.org/show_bug.cgi?id=92541

Patch by Scott Graham <scottmg@chromium.org> on 2012-07-27
Reviewed by Dan Bernstein.

Use unsigned instead of bool to keep size small on Windows.

No new tests.

  • rendering/InlineFlowBox.h:

(InlineFlowBox):

1:33 PM Changeset in webkit [123912] by Beth Dakin
  • 13 edits
    3 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=92327
-webkit-background-clip:text is blurry in WebKit 1 apps when
deviceScaleFactor > 1
-and corresponding-
<rdar://problem/11683788>

Reviewed by Simon Fraser.

Source/WebCore:

The bug here is that the code to make createCompatibleBuffer() HiDPI-savvy
assumed that the deviceScaleFactor would always be baked into the CTM of the
GraphicsContext. But that is NOT the case in WebKit 1.

createCompatibleBuffer() is used for clip text and gradients.

Now getCTM() takes a parameter indicating whether the result should definitely
include the device scale, or if it should possibly included the device scale,
which is the option that matches old behavior.

  • platform/graphics/GraphicsContext.h:

(GraphicsContext):

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::getCTM):

  • platform/graphics/openvg/GraphicsContextOpenVG.cpp:

(WebCore::GraphicsContext::getCTM):

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::getCTM):

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::getCTM):

  • platform/graphics/wince/GraphicsContextWinCE.cpp:

(WebCore::GraphicsContext::getCTM):

  • platform/graphics/wx/GraphicsContextWx.cpp:

(WebCore::GraphicsContext::getCTM):

Actually use the new parameter in the CG implementation. Use CG API to get a
matrix that definitely includes the device scale when that is required.

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::getCTM):

Remove some symbol cruft that doesn't seem to require a replacement.

  • WebCore.exp.in:

Use DefinitelyIncludeDeviceScale when getting the CTM in the buggy spot.

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::createCompatibleBuffer):

The ImageBuffer for gradients is created using createCompatibleBuffer(), and since
createCompatibleBuffer() now uses getCTM(DefinitelyIncludeDeviceScale) to
determine appropriate sizing, drawPattern() should use that same matrix to
determine pattern sizing.

  • platform/graphics/GeneratorGeneratedImage.cpp:

(WebCore::GeneratorGeneratedImage::drawPattern):

LayoutTests:

  • fast/hidpi/gradient-with-scaled-ancestor.html: Added.
  • platform/mac/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
  • platform/mac/fast/hidpi/gradient-with-scaled-ancestor-expected.txt: Added.
1:10 PM Changeset in webkit [123911] by commit-queue@webkit.org
  • 10 edits in trunk

[WK2][WTR] LayoutTestController.deliverWebIntent() needs to be implemented
https://bugs.webkit.org/show_bug.cgi?id=92228

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-27
Reviewed by Anders Carlsson.

Source/WebKit2:

Add C API to create a WKIntentData and to deliver
it to a frame. This is needed by WebKitTestRunner
to implement LayoutTestController.deliverWebIntent().

  • UIProcess/API/C/WKIntentData.cpp:

(WKIntentDataCreate):

  • UIProcess/API/C/WKIntentData.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageDeliverIntentToFrame):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/WebPage/WebPage.h:

(WebPage): Make deliverIntentToFrame() public so that it can
be used by WKBundlePage.

Tools:

Implement LayoutTestController.deliverWebIntent() to
allow test cases to deliver a Web intent and test this
functionality.

This functionality is needed by:

  • webintents/web-intents-delivery.html
  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::deliverWebIntent):
(WTR):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(LayoutTestController):

12:49 PM Changeset in webkit [123910] by bweinstein@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Add Mac results for fast/table/table-row-outline-paint.html.

  • platform/mac/fast/table/table-row-outline-paint-expected.txt: Added.
12:46 PM Changeset in webkit [123909] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Source/WebCore: flex-wrap: wrap not wrapping for % sized items in column flow
https://bugs.webkit.org/show_bug.cgi?id=92324

Patch by Tony Chang <tony@chromium.org> on 2012-07-27
Reviewed by Ojan Vafai.

We were using trying to use the value of contentLogicalHeight() before having called computeLogicalHeight()
in a few places. Fix this in mainAxisContentExtent() rather than at the callers.

Test: css3/flexbox/percentage-heights.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::mainAxisContentExtent):
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild): If we haven't called computeLogicalHeight, we try to compute
the height based on the fixed flexbox value. min/max don't matter here since percent values are only based on height/width.

  • rendering/RenderFlexibleBox.h: Drop const because computeContentLogicalHeightUsing is not const. I can

try making computeContentLogicalHeightUsing const in a follow up change (might be non-trivial).

Source/WebKit2: Show the unavailable plug-in indicator for Java applets as well
https://bugs.webkit.org/show_bug.cgi?id=92521

Patch by Anders Carlsson <andersca@apple.com> on 2012-07-27
Reviewed by Sam Weinig.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::unavailablePluginButtonClicked):
This can now be called on applet elements as well.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createJavaAppletWidget):
Get the MIME type from the applet element.

LayoutTests: flex-wrap: wrap not wrapping for % sized items in column flow
https://bugs.webkit.org/show_bug.cgi?id=92324

Patch by Tony Chang <tony@chromium.org> on 2012-07-27
Reviewed by Ojan Vafai.

Test cases for column flow with percentage heights. There are three
test cases for the three callers of mainAxisContentExtent() that were
broken by this.

  • css3/flexbox/percentage-heights-expected.txt: Added.
  • css3/flexbox/percentage-heights.html: Added.
12:38 PM Changeset in webkit [123908] by commit-queue@webkit.org
  • 16 edits
    2 adds in trunk/Source/WebCore

Add an overlay play button to media controls on android
https://bugs.webkit.org/show_bug.cgi?id=92132

Patch by Min Qin <qinmin@chromium.org> on 2012-07-27
Reviewed by Adam Barth.

This change adds an overlay play button to the media controls for android.
No tests for now as this setting is not being used by other port.
Will add a test and adjust all the test expectations when we upstream the layout tests for android.

  • WebCore.gypi:
  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSValueKeywords.in:
  • css/mediaControls.css:

(audio::-webkit-media-controls-overlay-play-button, video::-webkit-media-controls-overlay-play-button):

  • css/mediaControlsChromiumAndroid.css:

(audio::-webkit-media-controls-overlay-enclosure):
(video::-webkit-media-controls-overlay-enclosure):
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
(video::-webkit-media-controls-overlay-play-button):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlOverlayPlayButtonElement::MediaControlOverlayPlayButtonElement):
(WebCore):
(WebCore::MediaControlOverlayPlayButtonElement::create):
(WebCore::MediaControlOverlayPlayButtonElement::defaultEventHandler):
(WebCore::MediaControlOverlayPlayButtonElement::updateDisplayType):
(WebCore::MediaControlOverlayPlayButtonElement::shadowPseudoId):

  • html/shadow/MediaControlElements.h:

(MediaControlOverlayPlayButtonElement):
(WebCore):

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlPanelEnclosureElement::MediaControlPanelEnclosureElement):
(WebCore::MediaControlPanelEnclosureElement::create):
(WebCore):
(WebCore::MediaControlPanelEnclosureElement::shadowPseudoId):
(WebCore::MediaControlRootElementChromium::create):
(WebCore::MediaControlRootElementChromium::initializeControls):

  • html/shadow/MediaControlRootElementChromium.h:

(MediaControlChromiumEnclosureElement):
(WebCore):
(MediaControlPanelEnclosureElement):
(MediaControlRootElementChromium):

  • html/shadow/MediaControlRootElementChromiumAndroid.cpp: Added.

(WebCore):
(WebCore::MediaControlOverlayEnclosureElement::MediaControlOverlayEnclosureElement):
(WebCore::MediaControlOverlayEnclosureElement::create):
(WebCore::MediaControlOverlayEnclosureElement::shadowPseudoId):
(WebCore::MediaControlRootElementChromiumAndroid::MediaControlRootElementChromiumAndroid):
(WebCore::MediaControls::create):
(WebCore::MediaControlRootElementChromiumAndroid::create):
(WebCore::MediaControlRootElementChromiumAndroid::setMediaController):
(WebCore::MediaControlRootElementChromiumAndroid::playbackStarted):
(WebCore::MediaControlRootElementChromiumAndroid::playbackStopped):

  • html/shadow/MediaControlRootElementChromiumAndroid.h: Added.

(WebCore):
(MediaControlOverlayEnclosureElement):
(MediaControlRootElementChromiumAndroid):

  • platform/ThemeTypes.h:
  • rendering/RenderMediaControlsChromium.cpp:

(WebCore::paintMediaOverlayPlayButton):
(WebCore):
(WebCore::RenderMediaControlsChromium::paintMediaControlsPart):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paint):

  • rendering/RenderTheme.h:

(WebCore::RenderTheme::paintMediaOverlayPlayButton):

  • rendering/RenderThemeChromiumAndroid.cpp:

(WebCore::RenderThemeChromiumAndroid::paintMediaOverlayPlayButton):
(WebCore):

  • rendering/RenderThemeChromiumAndroid.h:
12:30 PM Changeset in webkit [123907] by andersca@apple.com
  • 9 edits in trunk/Source

Show the unavailable plug-in indicator for Java applets as well
https://bugs.webkit.org/show_bug.cgi?id=92521

Reviewed by Sam Weinig.

Source/WebCore:

Now that <applet> behaves more like <embed> and <object>, make sure that we show the unavailable plug-in indicator
and call the correct error callbacks if we fail to instantiate the plug-in.

  • WebCore.exp.in:

Export a symbol needed by WebKit2.

  • html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::HTMLAppletElement):
Set the correct service type.

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::createJavaAppletWidget):
Enable the unavailable plug-in indicator if we fail to create the java applet widget.

Source/WebKit/mac:

Check if the Java plug-in is blocked before trying to instantiate it.

  • WebCoreSupport/WebFrameLoaderClient.mm:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::unavailablePluginButtonClicked):
This can now be called on applet elements as well.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createJavaAppletWidget):
Get the MIME type from the applet element.

12:30 PM Changeset in webkit [123906] by jer.noble@apple.com
  • 4 edits in trunk

Unreviewed build fix.

Source/WTF:

Use MathExtras.h and the non std:: versions of isnan and signbit.

  • wtf/MediaTime.cpp:

(WTF::MediaTime::createWithFloat):
(WTF::MediaTime::createWithDouble):

Tools:

Wrap MSVC-specific fixes is a COMPILER() check, not a PLATFORM() check.

  • TestWebKitAPI/Tests/WTF/MediaTime.cpp:
12:29 PM Changeset in webkit [123905] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Increase inline storage for JSFinalObjects by one
https://bugs.webkit.org/show_bug.cgi?id=92526

Reviewed by Geoffrey Garen.

Now that we've removed the inheritorID from objects, we can increase our inline storage for JSFinalObjects on
64-bit platforms by 1.

  • llint/LowLevelInterpreter.asm: Change the constant.
  • runtime/PropertyOffset.h: Change the constant.

(JSC):

12:25 PM Changeset in webkit [123904] by mitz@apple.com
  • 5 edits
    2 adds in trunk

Hit testing near a column break can return a result from an adjacent column when there is leading
https://bugs.webkit.org/show_bug.cgi?id=92524

Reviewed by Anders Carlsson.

Source/WebCore:

The fix for <http://webkit.org/b/92311> relied on the existence of a pagination strut for
detecting that a line was at the beginning of a new column. However, when a line naturally
falls at the beginning of a column, there is no pagination strut, and the check failed.

Test: fast/multicol/hit-test-end-of-column-with-line-height.html

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::InlineFlowBox): Added initializer for new member variable.
(InlineFlowBox): Added m_isFirstAfterPageBreak member variable.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::positionForPointWithInlineChildren): Changed the test for whether a
line was at the beginning of a column from relying on a pagination strut to checking
isFirstAfterPageBreak(). Also refined the hit test itself to include the leading above such
a line.
(WebCore::RenderBlock::adjustLinePositionForPagination): Added calls to
setIsFirstAfterPageBreak() to first reset this flag, then set it to true if necessary.

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::isFirstAfterPageBreak): Added this accessor.
(WebCore::RootInlineBox::setIsFirstAfterPageBreak): Ditto.

LayoutTests:

  • fast/multicol/hit-test-end-of-column-with-line-height-expected.txt: Added.
  • fast/multicol/hit-test-end-of-column-with-line-height.html: Added.
12:03 PM Changeset in webkit [123903] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] Fix build warning in WebEventConversion.cpp
https://bugs.webkit.org/show_bug.cgi?id=92517

Patch by Gyuyoung Kim <gyuyoung.kim@samsung.com> on 2012-07-27
Reviewed by Darin Adler.

There is a build warning related to comparison between signed and unsigned integer expressions.

  • Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformTouchEvent::WebKit2PlatformTouchEvent):

12:02 PM Changeset in webkit [123902] by commit-queue@webkit.org
  • 3 edits in trunk/Source

Web Inspector: Allow front_end to be loaded into an iframe
https://bugs.webkit.org/show_bug.cgi?id=92437

Patch by John J. Barton <johnjbarton@johnjbarton.com> on 2012-07-27
Reviewed by Pavel Feldman.

This change only affects 'embedders' of the inspector/front_end. No change of function for WebKit ports.

  • inspector/front-end/ExtensionAPI.js:

Replace window.top with window.parent two places. When WebInspector is loaded as the main window content,
then extension iframes have window.top === window.parent; when WebInspector is loaded as an iframe, then
extensions are iframes in iframes and we need to use a relative address window.parent.
(injectedExtensionAPI.ExtensionViewImpl.dispatchShowEvent):
(injectedExtensionAPI.ExtensionViewImpl):
(injectedExtensionAPI.ExtensionServerClient):
WebKit/chromium/scripts/generate_devtools_extension_api.py:
The current number of frames is used in a dynamically created identifier. Again we replace 'top' by
window.parent.

11:54 AM Changeset in webkit [123901] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: InspectorPageAgent should ascertain document to be non-null in updateViewMetrics()
https://bugs.webkit.org/show_bug.cgi?id=92476

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-07-27
Reviewed by Pavel Feldman.

InspectorPageAgent should check for document object being null. As pages created with blank URL might
not have the document object, this causes a crash.

No new tests as added null check.

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::updateViewMetrics):

11:42 AM Changeset in webkit [123900] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Chromium-Android] NRWT better handling of DRT deadlocks and crashes
https://bugs.webkit.org/show_bug.cgi?id=92299

Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2012-07-27
Reviewed by Dirk Pranke.

  1. Changed the deadlock detector thread target from a method of driver to a function to avoid its reference to the current driver (see the bug for the problem of the reference.
  2. Let the deadlock detector thread exit early when the normal_startup_event is set to avoid it from blocking the main thread when the main thread is exiting.
  3. Extracted common loop until timeout logic into ChromiumAndroidDriver._loop_with_timeout().
  4. Use the "for i in range(n)" style suggested by dpranke in https://bugs.webkit.org/show_bug.cgi?id=89124 in several functions.
  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.init):
(ChromiumAndroidPort._run_adb_command): Reduced the verbose output.
(ChromiumAndroidDriver.init):
(ChromiumAndroidDriver._loop_with_timeout): Extracted common loop until timeout logic here.
(ChromiumAndroidDriver._all_pipes_created):
(ChromiumAndroidDriver._remove_all_pipes):
(ChromiumAndroidDriver._start): Changed the retry loop style.
(ChromiumAndroidDriver._start_once): Changed the loop style and code related to deadlock detector.
(ChromiumAndroidDriver._start_once.deadlock_detector): Moved the original ChromiumAndroidDriver._deadlock_detector() here.
(ChromiumAndroidDriver.stop): Changed the loop style.

11:38 AM Changeset in webkit [123899] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

CSP directives containing invalid characters should log an error.
https://bugs.webkit.org/show_bug.cgi?id=92487

Patch by Mike West <mkwst@chromium.org> on 2012-07-27
Reviewed by Adam Barth.

Source/WebCore:

Unknown directive names are currently logged, but we exit the directive
parser early without logging if we hit an invalid character inside a
directive. script-src: ..., for example, was ignored without letting
the developer know what happened. This patch changes that behavior,
logging the whole name (in this case script-src:) as an unknown
directive.

Test: http/tests/security/contentSecurityPolicy/directive-parsing-04.html

  • page/ContentSecurityPolicy.cpp:

(WebCore::CSPDirectiveList::parseDirective):

LayoutTests:

  • http/tests/security/contentSecurityPolicy/directive-parsing-03-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/directive-parsing-04-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/directive-parsing-04.html: Added.

Adding a test specifically for script-src: ... which bit me, and
updating test #3, which now has a better error message.

11:26 AM Changeset in webkit [123898] by dpranke@chromium.org
  • 4 edits in trunk/Tools

nrwt: move collect_tests(), parse_expectations() into manager
https://bugs.webkit.org/show_bug.cgi?id=92423

Reviewed by Ojan Vafai.

This is the first in a series of patches refactoring
run_webkit_tests.py and manager.py to make them more
maintainable; all this patch does is move a couple of functions
into manager.run_tests() so manager's public interface is
simple.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._collect_tests):
(Manager._parse_expectations):
(Manager._split_into_chunks_if_necessary):
(Manager.run):
(read_test_files):

  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ManagerTest.test_http_locking):
(ManagerTest.test_perf_locking):
(ManagerTest.integration_test_needs_servers.get_manager_with_tests):
(ManagerTest.test_look_for_new_crash_logs.get_manager_with_tests):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(run):

11:25 AM Changeset in webkit [123897] by commit-queue@webkit.org
  • 1 edit
    5 adds in trunk/PerformanceTests

Add more Russian replay performance tests
https://bugs.webkit.org/show_bug.cgi?id=92462

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2012-07-27
Reviewed by Tony Chang.

Add more Russian sites as suggested by loislo.

  • Replay/Russian/lenta.ru.replay: Added.
  • Replay/Russian/www.ixbt.com.replay: Added.
  • Replay/Russian/www.kp.ru.replay: Added.
  • Replay/Russian/www.liveinternet.ru.replay: Added.
  • Replay/Russian/www.pravda.ru.replay: Added.
11:25 AM Changeset in webkit [123896] by commit-queue@webkit.org
  • 404 edits
    2 copies
    1 move
    10 adds
    23 deletes in trunk/LayoutTests

[Qt] platform/qt/svg/custom tests needs update after font change.
https://bugs.webkit.org/show_bug.cgi?id=91090.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-07-27
Reviewed by Zoltan Herczeg.

  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0-wk2/svg/custom/altglyph-expected.png: Removed.
  • platform/qt-5.0-wk2/svg/custom/altglyph-expected.txt: Removed.
  • platform/qt-5.0-wk2/svg/custom/font-face-simple-expected.png: Removed.
  • platform/qt-5.0-wk2/svg/custom/font-face-simple-expected.txt: Removed.
  • platform/qt-5.0-wk2/svg/custom/inline-svg-in-xhtml-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/inline-svg-in-xhtml-expected.txt: Copied from LayoutTests/platform/qt/svg/custom/inline-svg-in-xhtml-expected.txt.
  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/svg/custom/glyph-selection-arabic-forms-expected.png: Removed.
  • platform/qt-5.0/svg/custom/glyph-selection-arabic-forms-expected.txt: Removed.
  • platform/qt-5.0/svg/custom/glyph-selection-bidi-mirror-expected.png: Removed.
  • platform/qt-5.0/svg/custom/glyph-selection-bidi-mirror-expected.txt: Removed.
  • platform/qt-5.0/svg/custom/glyph-selection-non-bmp-expected.txt: Removed.
  • platform/qt-5.0/svg/custom/glyph-transformation-with-hkern-expected.png: Removed.
  • platform/qt-5.0/svg/custom/glyph-transformation-with-hkern-expected.txt: Removed.
  • platform/qt-5.0/svg/custom/preserve-aspect-ratio-syntax-expected.png: Removed.
  • platform/qt-5.0/svg/custom/preserve-aspect-ratio-syntax-expected.txt: Removed.
  • platform/qt-5.0/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png: Removed.
  • platform/qt-5.0/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt: Removed.
  • platform/qt-5.0/svg/custom/svg-features-expected.txt: Removed.
  • platform/qt-5.0/svg/custom/svg-fonts-in-html-expected.png: Removed.
  • platform/qt-5.0/svg/custom/svg-fonts-in-html-expected.txt: Removed.
  • platform/qt-5.0/svg/custom/svg-fonts-in-text-controls-expected.txt: Removed.
  • platform/qt-5.0/svg/custom/svg-fonts-segmented-expected.png: Removed.
  • platform/qt-5.0/svg/custom/svg-fonts-segmented-expected.txt: Removed.
  • platform/qt-5.0/svg/custom/text-linking-expected.png: Removed.
  • platform/qt-5.0/svg/custom/text-linking-expected.txt: Removed.
  • platform/qt/svg/custom/SVGMatrix-interface-expected.png:
  • platform/qt/svg/custom/SVGMatrix-interface-expected.txt:
  • platform/qt/svg/custom/SVGPoint-matrixTransform-expected.png:
  • platform/qt/svg/custom/SVGPoint-matrixTransform-expected.txt:
  • platform/qt/svg/custom/absolute-sized-content-with-resources-expected.png:
  • platform/qt/svg/custom/absolute-sized-content-with-resources-expected.txt:
  • platform/qt/svg/custom/absolute-sized-svg-in-xhtml-expected.png:
  • platform/qt/svg/custom/absolute-sized-svg-in-xhtml-expected.txt:
  • platform/qt/svg/custom/alignment-baseline-modes-expected.png:
  • platform/qt/svg/custom/alignment-baseline-modes-expected.txt:
  • platform/qt/svg/custom/altglyph-expected.png:
  • platform/qt/svg/custom/altglyph-expected.txt:
  • platform/qt/svg/custom/baseval-animval-equality-expected.png:
  • platform/qt/svg/custom/baseval-animval-equality-expected.txt:
  • platform/qt/svg/custom/broken-internal-references-expected.txt:
  • platform/qt/svg/custom/bug45331-expected.png: Added.
  • platform/qt/svg/custom/bug45331-expected.txt: Added.
  • platform/qt/svg/custom/bug86119-expected.txt:
  • platform/qt/svg/custom/circle-move-invalidation-expected.png:
  • platform/qt/svg/custom/circle-move-invalidation-expected.txt:
  • platform/qt/svg/custom/clip-path-referencing-use-expected.png:
  • platform/qt/svg/custom/clip-path-referencing-use-expected.txt:
  • platform/qt/svg/custom/clip-path-referencing-use2-expected.png:
  • platform/qt/svg/custom/clip-path-referencing-use2-expected.txt:
  • platform/qt/svg/custom/clone-element-with-animated-svg-properties-expected.png:
  • platform/qt/svg/custom/clone-element-with-animated-svg-properties-expected.txt:
  • platform/qt/svg/custom/container-opacity-clip-viewBox-expected.png:
  • platform/qt/svg/custom/container-opacity-clip-viewBox-expected.txt:
  • platform/qt/svg/custom/coords-relative-units-transforms-expected.png:
  • platform/qt/svg/custom/coords-relative-units-transforms-expected.txt:
  • platform/qt/svg/custom/createImageElement2-expected.png: Added.
  • platform/qt/svg/custom/createImageElement2-expected.txt:
  • platform/qt/svg/custom/dominant-baseline-hanging-expected.png:
  • platform/qt/svg/custom/dominant-baseline-hanging-expected.txt:
  • platform/qt/svg/custom/dominant-baseline-modes-expected.png:
  • platform/qt/svg/custom/dominant-baseline-modes-expected.txt:
  • platform/qt/svg/custom/dynamic-svg-document-creation-expected.png:
  • platform/qt/svg/custom/dynamic-svg-document-creation-expected.txt:
  • platform/qt/svg/custom/embedding-external-svgs-expected.png:
  • platform/qt/svg/custom/embedding-external-svgs-expected.txt:
  • platform/qt/svg/custom/empty-clip-path-expected.png:
  • platform/qt/svg/custom/empty-clip-path-expected.txt:
  • platform/qt/svg/custom/empty-mask-expected.png: Added.
  • platform/qt/svg/custom/empty-mask-expected.txt:
  • platform/qt/svg/custom/external-paintserver-reference-expected.png:
  • platform/qt/svg/custom/external-paintserver-reference-expected.txt:
  • platform/qt/svg/custom/fill-SVGPaint-interface-expected.png:
  • platform/qt/svg/custom/fill-SVGPaint-interface-expected.txt:
  • platform/qt/svg/custom/fill-fallback-expected.png:
  • platform/qt/svg/custom/fill-fallback-expected.txt:
  • platform/qt/svg/custom/focus-ring-expected.png:
  • platform/qt/svg/custom/focus-ring-expected.txt:
  • platform/qt/svg/custom/font-face-cascade-order-expected.png:
  • platform/qt/svg/custom/font-face-cascade-order-expected.txt:
  • platform/qt/svg/custom/font-face-simple-expected.png:
  • platform/qt/svg/custom/font-face-simple-expected.txt:
  • platform/qt/svg/custom/foreign-object-skew-expected.png:
  • platform/qt/svg/custom/foreign-object-skew-expected.txt:
  • platform/qt/svg/custom/foreignObject-crash-on-hover-expected.png:
  • platform/qt/svg/custom/foreignObject-crash-on-hover-expected.txt:
  • platform/qt/svg/custom/getPresentationAttribute-expected.png:
  • platform/qt/svg/custom/getPresentationAttribute-expected.txt:
  • platform/qt/svg/custom/getTransformToElement-expected.png:
  • platform/qt/svg/custom/getTransformToElement-expected.txt:
  • platform/qt/svg/custom/getscreenctm-in-mixed-content-expected.png:
  • platform/qt/svg/custom/getscreenctm-in-mixed-content-expected.txt:
  • platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-expected.png:
  • platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt:
  • platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png:
  • platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt:
  • platform/qt/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png:
  • platform/qt/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt:
  • platform/qt/svg/custom/getsvgdocument-expected.png:
  • platform/qt/svg/custom/getsvgdocument-expected.txt:
  • platform/qt/svg/custom/glyph-selection-arabic-forms-expected.png: Added.
  • platform/qt/svg/custom/glyph-selection-arabic-forms-expected.txt:
  • platform/qt/svg/custom/glyph-selection-bidi-mirror-expected.png: Copied from LayoutTests/platform/qt-5.0/svg/custom/glyph-selection-non-bmp-expected.png.
  • platform/qt/svg/custom/glyph-selection-bidi-mirror-expected.txt:
  • platform/qt/svg/custom/glyph-selection-non-bmp-expected.png: Renamed from LayoutTests/platform/qt-5.0/svg/custom/glyph-selection-non-bmp-expected.png.
  • platform/qt/svg/custom/glyph-selection-non-bmp-expected.txt:
  • platform/qt/svg/custom/glyph-transformation-with-hkern-expected.png:
  • platform/qt/svg/custom/glyph-transformation-with-hkern-expected.txt:
  • platform/qt/svg/custom/gradient-cycle-detection-expected.png:
  • platform/qt/svg/custom/gradient-cycle-detection-expected.txt:
  • platform/qt/svg/custom/gradient-deep-referencing-expected.png:
  • platform/qt/svg/custom/gradient-deep-referencing-expected.txt:
  • platform/qt/svg/custom/gradient-with-1d-boundingbox-expected.png: Added.
  • platform/qt/svg/custom/gradient-with-1d-boundingbox-expected.txt:
  • platform/qt/svg/custom/hit-test-path-expected.png:
  • platform/qt/svg/custom/hit-test-path-expected.txt:
  • platform/qt/svg/custom/hit-test-path-stroke-expected.png:
  • platform/qt/svg/custom/hit-test-path-stroke-expected.txt:
  • platform/qt/svg/custom/hit-test-unclosed-subpaths-expected.png:
  • platform/qt/svg/custom/hit-test-unclosed-subpaths-expected.txt:
  • platform/qt/svg/custom/image-parent-translation-expected.png:
  • platform/qt/svg/custom/image-parent-translation-expected.txt:
  • platform/qt/svg/custom/image-rescale-clip-expected.png:
  • platform/qt/svg/custom/image-rescale-clip-expected.txt:
  • platform/qt/svg/custom/image-rescale-scroll-expected.png:
  • platform/qt/svg/custom/image-rescale-scroll-expected.txt:
  • platform/qt/svg/custom/image-small-width-height-expected.png:
  • platform/qt/svg/custom/image-small-width-height-expected.txt:
  • platform/qt/svg/custom/image-with-transform-clip-filter-expected.png:
  • platform/qt/svg/custom/image-with-transform-clip-filter-expected.txt:
  • platform/qt/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/qt/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/qt/svg/custom/invalid-css-expected.png:
  • platform/qt/svg/custom/invalid-css-expected.txt:
  • platform/qt/svg/custom/invalid-fill-expected.png:
  • platform/qt/svg/custom/invalid-fill-expected.txt:
  • platform/qt/svg/custom/invalid-fill-hex-expected.png:
  • platform/qt/svg/custom/invalid-fill-hex-expected.txt:
  • platform/qt/svg/custom/invalid-lengthlist-expected.png:
  • platform/qt/svg/custom/invalid-lengthlist-expected.txt:
  • platform/qt/svg/custom/invalid-stroke-hex-expected.png: Added.
  • platform/qt/svg/custom/invalid-stroke-hex-expected.txt:
  • platform/qt/svg/custom/invalid-uri-stroke-expected.png: Added.
  • platform/qt/svg/custom/invalid-uri-stroke-expected.txt:
  • platform/qt/svg/custom/invisible-text-after-scrolling-expected.png:
  • platform/qt/svg/custom/invisible-text-after-scrolling-expected.txt:
  • platform/qt/svg/custom/js-late-clipPath-and-object-creation-expected.png:
  • platform/qt/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
  • platform/qt/svg/custom/js-late-clipPath-creation-expected.png:
  • platform/qt/svg/custom/js-late-clipPath-creation-expected.txt:
  • platform/qt/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/qt/svg/custom/js-late-gradient-and-object-creation-expected.txt:
  • platform/qt/svg/custom/js-late-gradient-creation-expected.png:
  • platform/qt/svg/custom/js-late-gradient-creation-expected.txt:
  • platform/qt/svg/custom/js-update-stop-linked-gradient-expected.png:
  • platform/qt/svg/custom/js-update-stop-linked-gradient-expected.txt:
  • platform/qt/svg/custom/linking-a-03-b-preserveAspectRatio-expected.png:
  • platform/qt/svg/custom/linking-a-03-b-preserveAspectRatio-expected.txt:
  • platform/qt/svg/custom/linking-a-03-b-transform-expected.png:
  • platform/qt/svg/custom/linking-a-03-b-transform-expected.txt:
  • platform/qt/svg/custom/linking-a-03-b-viewBox-expected.png:
  • platform/qt/svg/custom/linking-a-03-b-viewBox-expected.txt:
  • platform/qt/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/qt/svg/custom/linking-a-03-b-viewBox-transform-expected.txt:
  • platform/qt/svg/custom/linking-a-03-b-viewTarget-expected.png:
  • platform/qt/svg/custom/linking-a-03-b-viewTarget-expected.txt:
  • platform/qt/svg/custom/linking-a-03-b-zoomAndPan-expected.png:
  • platform/qt/svg/custom/linking-a-03-b-zoomAndPan-expected.txt:
  • platform/qt/svg/custom/linking-base-external-reference-expected.png:
  • platform/qt/svg/custom/linking-base-external-reference-expected.txt:
  • platform/qt/svg/custom/linking-uri-01-b-expected.png:
  • platform/qt/svg/custom/linking-uri-01-b-expected.txt:
  • platform/qt/svg/custom/marker-default-width-height-expected.png:
  • platform/qt/svg/custom/marker-default-width-height-expected.txt:
  • platform/qt/svg/custom/marker-overflow-clip-expected.png:
  • platform/qt/svg/custom/marker-overflow-clip-expected.txt:
  • platform/qt/svg/custom/mouse-move-on-svg-container-expected.png:
  • platform/qt/svg/custom/mouse-move-on-svg-container-expected.txt:
  • platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
  • platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
  • platform/qt/svg/custom/mouse-move-on-svg-root-expected.png:
  • platform/qt/svg/custom/mouse-move-on-svg-root-expected.txt:
  • platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
  • platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
  • platform/qt/svg/custom/no-inherited-dashed-stroke-expected.png:
  • platform/qt/svg/custom/no-inherited-dashed-stroke-expected.txt:
  • platform/qt/svg/custom/non-opaque-filters-expected.png:
  • platform/qt/svg/custom/non-opaque-filters-expected.txt:
  • platform/qt/svg/custom/object-no-size-attributes-expected.png:
  • platform/qt/svg/custom/object-no-size-attributes-expected.txt:
  • platform/qt/svg/custom/object-sizing-expected.png:
  • platform/qt/svg/custom/object-sizing-expected.txt:
  • platform/qt/svg/custom/object-sizing-explicit-height-expected.png:
  • platform/qt/svg/custom/object-sizing-explicit-height-expected.txt:
  • platform/qt/svg/custom/object-sizing-explicit-width-expected.png:
  • platform/qt/svg/custom/object-sizing-explicit-width-expected.txt:
  • platform/qt/svg/custom/object-sizing-explicit-width-height-expected.png:
  • platform/qt/svg/custom/object-sizing-explicit-width-height-expected.txt:
  • platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png:
  • platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt:
  • platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-expected.png:
  • platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt:
  • platform/qt/svg/custom/object-sizing-no-width-height-expected.png:
  • platform/qt/svg/custom/object-sizing-no-width-height-expected.txt:
  • platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png:
  • platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt:
  • platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png:
  • platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt:
  • platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt:
  • platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt:
  • platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png:
  • platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt:
  • platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-expected.png:
  • platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt:
  • platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt:
  • platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png:
  • platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt:
  • platform/qt/svg/custom/path-textPath-simulation-expected.png:
  • platform/qt/svg/custom/path-textPath-simulation-expected.txt:
  • platform/qt/svg/custom/pattern-cycle-detection-expected.png:
  • platform/qt/svg/custom/pattern-cycle-detection-expected.txt:
  • platform/qt/svg/custom/pattern-deep-referencing-expected.png:
  • platform/qt/svg/custom/pattern-deep-referencing-expected.txt:
  • platform/qt/svg/custom/pattern-incorrect-tiling-expected.png:
  • platform/qt/svg/custom/pattern-incorrect-tiling-expected.txt:
  • platform/qt/svg/custom/pattern-rotate-expected.png:
  • platform/qt/svg/custom/pattern-rotate-expected.txt:
  • platform/qt/svg/custom/pattern-rotate-gaps-expected.png:
  • platform/qt/svg/custom/pattern-rotate-gaps-expected.txt:
  • platform/qt/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png:
  • platform/qt/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt:
  • platform/qt/svg/custom/pattern-with-transformation-expected.png:
  • platform/qt/svg/custom/pattern-with-transformation-expected.txt:
  • platform/qt/svg/custom/percentage-of-html-parent-expected.png:
  • platform/qt/svg/custom/percentage-of-html-parent-expected.txt:
  • platform/qt/svg/custom/pointer-events-image-css-transform-expected.png:
  • platform/qt/svg/custom/pointer-events-image-css-transform-expected.txt:
  • platform/qt/svg/custom/pointer-events-image-expected.png:
  • platform/qt/svg/custom/pointer-events-image-expected.txt:
  • platform/qt/svg/custom/pointer-events-path-expected.png:
  • platform/qt/svg/custom/pointer-events-path-expected.txt:
  • platform/qt/svg/custom/pointer-events-text-css-transform-expected.png:
  • platform/qt/svg/custom/pointer-events-text-css-transform-expected.txt:
  • platform/qt/svg/custom/pointer-events-text-expected.png:
  • platform/qt/svg/custom/pointer-events-text-expected.txt:
  • platform/qt/svg/custom/preserve-aspect-ratio-syntax-expected.png:
  • platform/qt/svg/custom/preserve-aspect-ratio-syntax-expected.txt:
  • platform/qt/svg/custom/recursive-clippath-expected.png:
  • platform/qt/svg/custom/recursive-clippath-expected.txt:
  • platform/qt/svg/custom/recursive-filter-expected.png:
  • platform/qt/svg/custom/recursive-filter-expected.txt:
  • platform/qt/svg/custom/recursive-gradient-expected.png:
  • platform/qt/svg/custom/recursive-gradient-expected.txt:
  • platform/qt/svg/custom/recursive-mask-expected.png:
  • platform/qt/svg/custom/recursive-mask-expected.txt:
  • platform/qt/svg/custom/recursive-pattern-expected.png:
  • platform/qt/svg/custom/recursive-pattern-expected.txt:
  • platform/qt/svg/custom/relative-sized-content-expected.png: Added.
  • platform/qt/svg/custom/relative-sized-content-expected.txt:
  • platform/qt/svg/custom/relative-sized-content-with-resources-expected.png:
  • platform/qt/svg/custom/relative-sized-content-with-resources-expected.txt:
  • platform/qt/svg/custom/relative-sized-deep-shadow-tree-content-expected.png:
  • platform/qt/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
  • platform/qt/svg/custom/relative-sized-image-expected.png:
  • platform/qt/svg/custom/relative-sized-image-expected.txt:
  • platform/qt/svg/custom/relative-sized-inner-svg-expected.png:
  • platform/qt/svg/custom/relative-sized-inner-svg-expected.txt:
  • platform/qt/svg/custom/relative-sized-shadow-tree-content-expected.png:
  • platform/qt/svg/custom/relative-sized-shadow-tree-content-expected.txt:
  • platform/qt/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.png:
  • platform/qt/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
  • platform/qt/svg/custom/relative-sized-use-on-symbol-expected.png:
  • platform/qt/svg/custom/relative-sized-use-on-symbol-expected.txt:
  • platform/qt/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png:
  • platform/qt/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
  • platform/qt/svg/custom/rootmost-svg-xy-attrs-expected.png:
  • platform/qt/svg/custom/rootmost-svg-xy-attrs-expected.txt:
  • platform/qt/svg/custom/scroll-hit-test-expected.png:
  • platform/qt/svg/custom/scroll-hit-test-expected.txt:
  • platform/qt/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/qt/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
  • platform/qt/svg/custom/second-inline-text-expected.png:
  • platform/qt/svg/custom/second-inline-text-expected.txt:
  • platform/qt/svg/custom/shape-rendering-expected.png:
  • platform/qt/svg/custom/shape-rendering-expected.txt:
  • platform/qt/svg/custom/shapes-supporting-markers-expected.png:
  • platform/qt/svg/custom/shapes-supporting-markers-expected.txt:
  • platform/qt/svg/custom/simple-text-double-shadow-expected.png:
  • platform/qt/svg/custom/simple-text-double-shadow-expected.txt:
  • platform/qt/svg/custom/simpleCDF-expected.png:
  • platform/qt/svg/custom/simpleCDF-expected.txt:
  • platform/qt/svg/custom/stroke-fallback-expected.png:
  • platform/qt/svg/custom/stroke-fallback-expected.txt:
  • platform/qt/svg/custom/stroke-width-large-expected.png:
  • platform/qt/svg/custom/stroke-width-large-expected.txt:
  • platform/qt/svg/custom/stroked-pattern-expected.png:
  • platform/qt/svg/custom/stroked-pattern-expected.txt:
  • platform/qt/svg/custom/style-attribute-font-size-expected.png:
  • platform/qt/svg/custom/style-attribute-font-size-expected.txt:
  • platform/qt/svg/custom/svg-curve-with-relative-cordinates-expected.png:
  • platform/qt/svg/custom/svg-curve-with-relative-cordinates-expected.txt:
  • platform/qt/svg/custom/svg-features-expected.txt:
  • platform/qt/svg/custom/svg-float-border-padding-expected.png:
  • platform/qt/svg/custom/svg-float-border-padding-expected.txt:
  • platform/qt/svg/custom/svg-fonts-in-html-expected.png:
  • platform/qt/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/qt/svg/custom/svg-fonts-in-text-controls-expected.txt:
  • platform/qt/svg/custom/svg-fonts-segmented-expected.png:
  • platform/qt/svg/custom/svg-fonts-segmented-expected.txt:
  • platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.png:
  • platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
  • platform/qt/svg/custom/svg-fonts-word-spacing-expected.png:
  • platform/qt/svg/custom/svg-fonts-word-spacing-expected.txt:
  • platform/qt/svg/custom/svg-overflow-types-expected.png:
  • platform/qt/svg/custom/svg-overflow-types-expected.txt:
  • platform/qt/svg/custom/text-clip-expected.png:
  • platform/qt/svg/custom/text-clip-expected.txt:
  • platform/qt/svg/custom/text-ctm-expected.png:
  • platform/qt/svg/custom/text-ctm-expected.txt:
  • platform/qt/svg/custom/text-decoration-visibility-expected.png:
  • platform/qt/svg/custom/text-decoration-visibility-expected.txt:
  • platform/qt/svg/custom/text-dom-01-f-expected.png:
  • platform/qt/svg/custom/text-dom-01-f-expected.txt:
  • platform/qt/svg/custom/text-filter-expected.png:
  • platform/qt/svg/custom/text-filter-expected.txt:
  • platform/qt/svg/custom/text-hit-test-expected.png:
  • platform/qt/svg/custom/text-hit-test-expected.txt:
  • platform/qt/svg/custom/text-image-opacity-expected.png:
  • platform/qt/svg/custom/text-image-opacity-expected.txt:
  • platform/qt/svg/custom/text-letter-spacing-expected.png:
  • platform/qt/svg/custom/text-letter-spacing-expected.txt:
  • platform/qt/svg/custom/text-linking-expected.png:
  • platform/qt/svg/custom/text-linking-expected.txt:
  • platform/qt/svg/custom/text-repaint-including-stroke-expected.png:
  • platform/qt/svg/custom/text-repaint-including-stroke-expected.txt:
  • platform/qt/svg/custom/text-rotated-gradient-expected.png:
  • platform/qt/svg/custom/text-rotated-gradient-expected.txt:
  • platform/qt/svg/custom/text-rotation-expected.png:
  • platform/qt/svg/custom/text-rotation-expected.txt:
  • platform/qt/svg/custom/text-tref-03-b-change-href-dom-expected.png:
  • platform/qt/svg/custom/text-tref-03-b-change-href-dom-expected.txt:
  • platform/qt/svg/custom/text-tref-03-b-change-href-expected.png:
  • platform/qt/svg/custom/text-tref-03-b-change-href-expected.txt:
  • platform/qt/svg/custom/text-tref-03-b-referenced-element-removal-expected.png:
  • platform/qt/svg/custom/text-tref-03-b-referenced-element-removal-expected.txt:
  • platform/qt/svg/custom/text-tref-03-b-tref-removal-expected.png:
  • platform/qt/svg/custom/text-tref-03-b-tref-removal-expected.txt:
  • platform/qt/svg/custom/text-whitespace-handling-expected.png:
  • platform/qt/svg/custom/text-whitespace-handling-expected.txt:
  • platform/qt/svg/custom/text-x-dx-lists-expected.png:
  • platform/qt/svg/custom/text-x-dx-lists-expected.txt:
  • platform/qt/svg/custom/text-x-dy-lists-expected.png:
  • platform/qt/svg/custom/text-x-dy-lists-expected.txt:
  • platform/qt/svg/custom/text-x-override-in-tspan-child-expected.png:
  • platform/qt/svg/custom/text-x-override-in-tspan-child-expected.txt:
  • platform/qt/svg/custom/text-xy-updates-SVGList-expected.png:
  • platform/qt/svg/custom/text-xy-updates-SVGList-expected.txt:
  • platform/qt/svg/custom/text-xy-updates-expected.png:
  • platform/qt/svg/custom/text-xy-updates-expected.txt:
  • platform/qt/svg/custom/tref-own-content-removal-expected.png:
  • platform/qt/svg/custom/tref-own-content-removal-expected.txt:
  • platform/qt/svg/custom/tref-update-expected.png:
  • platform/qt/svg/custom/tref-update-expected.txt:
  • platform/qt/svg/custom/use-clipped-hit-expected.png:
  • platform/qt/svg/custom/use-clipped-hit-expected.txt:
  • platform/qt/svg/custom/use-detach-expected.png:
  • platform/qt/svg/custom/use-detach-expected.txt:
  • platform/qt/svg/custom/use-dynamic-append-expected.png:
  • platform/qt/svg/custom/use-dynamic-append-expected.txt:
  • platform/qt/svg/custom/use-elementInstance-event-target-expected.png:
  • platform/qt/svg/custom/use-elementInstance-event-target-expected.txt:
  • platform/qt/svg/custom/use-elementInstance-methods-expected.png:
  • platform/qt/svg/custom/use-elementInstance-methods-expected.txt:
  • platform/qt/svg/custom/use-event-handler-on-referenced-element-expected.png:
  • platform/qt/svg/custom/use-event-handler-on-referenced-element-expected.txt:
  • platform/qt/svg/custom/use-event-handler-on-use-element-expected.png:
  • platform/qt/svg/custom/use-event-handler-on-use-element-expected.txt:
  • platform/qt/svg/custom/use-events-crash-expected.png:
  • platform/qt/svg/custom/use-events-crash-expected.txt:
  • platform/qt/svg/custom/use-instanceRoot-modifications-expected.png:
  • platform/qt/svg/custom/use-instanceRoot-modifications-expected.txt:
  • platform/qt/svg/custom/use-modify-container-in-target-expected.png:
  • platform/qt/svg/custom/use-modify-container-in-target-expected.txt:
  • platform/qt/svg/custom/use-modify-target-container-expected.png:
  • platform/qt/svg/custom/use-modify-target-container-expected.txt:
  • platform/qt/svg/custom/use-modify-target-symbol-expected.png:
  • platform/qt/svg/custom/use-modify-target-symbol-expected.txt:
  • platform/qt/svg/custom/use-on-disallowed-foreign-object-1-expected.png:
  • platform/qt/svg/custom/use-on-disallowed-foreign-object-1-expected.txt:
  • platform/qt/svg/custom/use-on-disallowed-foreign-object-2-expected.png:
  • platform/qt/svg/custom/use-on-disallowed-foreign-object-2-expected.txt:
  • platform/qt/svg/custom/use-on-disallowed-foreign-object-3-expected.png:
  • platform/qt/svg/custom/use-on-disallowed-foreign-object-3-expected.txt:
  • platform/qt/svg/custom/use-on-disallowed-foreign-object-4-expected.png:
  • platform/qt/svg/custom/use-on-disallowed-foreign-object-4-expected.txt:
  • platform/qt/svg/custom/use-on-disallowed-foreign-object-5-expected.png:
  • platform/qt/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
  • platform/qt/svg/custom/use-on-disallowed-foreign-object-6-expected.png:
  • platform/qt/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
  • platform/qt/svg/custom/use-on-g-containing-symbol-expected.png:
  • platform/qt/svg/custom/use-on-g-containing-symbol-expected.txt:
  • platform/qt/svg/custom/use-on-g-containing-use-expected.png:
  • platform/qt/svg/custom/use-on-g-containing-use-expected.txt:
  • platform/qt/svg/custom/use-on-g-expected.png:
  • platform/qt/svg/custom/use-on-g-expected.txt:
  • platform/qt/svg/custom/use-on-non-svg-namespaced-element-expected.png:
  • platform/qt/svg/custom/use-on-non-svg-namespaced-element-expected.txt:
  • platform/qt/svg/custom/use-on-rect-expected.png:
  • platform/qt/svg/custom/use-on-rect-expected.txt:
  • platform/qt/svg/custom/use-on-symbol-expected.png:
  • platform/qt/svg/custom/use-on-symbol-expected.txt:
  • platform/qt/svg/custom/use-on-text-expected.png:
  • platform/qt/svg/custom/use-on-text-expected.txt:
  • platform/qt/svg/custom/use-on-use-expected.png:
  • platform/qt/svg/custom/use-on-use-expected.txt:
  • platform/qt/svg/custom/use-property-changes-through-dom-expected.png:
  • platform/qt/svg/custom/use-property-changes-through-dom-expected.txt:
  • platform/qt/svg/custom/use-property-changes-through-svg-dom-expected.png:
  • platform/qt/svg/custom/use-property-changes-through-svg-dom-expected.txt:
  • platform/qt/svg/custom/use-recursion-1-expected.png:
  • platform/qt/svg/custom/use-recursion-1-expected.txt:
  • platform/qt/svg/custom/use-recursion-2-expected.png:
  • platform/qt/svg/custom/use-recursion-2-expected.txt:
  • platform/qt/svg/custom/use-recursion-3-expected.png:
  • platform/qt/svg/custom/use-recursion-3-expected.txt:
  • platform/qt/svg/custom/use-recursion-4-expected.png:
  • platform/qt/svg/custom/use-recursion-4-expected.txt:
  • platform/qt/svg/custom/use-referencing-nonexisting-symbol-expected.png:
  • platform/qt/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
  • platform/qt/svg/custom/use-setAttribute-crash-expected.png:
  • platform/qt/svg/custom/use-setAttribute-crash-expected.txt:
  • platform/qt/svg/custom/use-transform-expected.png:
  • platform/qt/svg/custom/use-transform-expected.txt:
  • platform/qt/svg/custom/viewbox-syntax-expected.png:
  • platform/qt/svg/custom/viewbox-syntax-expected.txt:
  • platform/qt/svg/custom/viewport-em-expected.png:
  • platform/qt/svg/custom/viewport-em-expected.txt:
11:23 AM Changeset in webkit [123895] by dpranke@chromium.org
  • 10 edits in trunk/Tools

nrwt: print filtered stderr after a crash correctly
https://bugs.webkit.org/show_bug.cgi?id=92428

Reviewed by Adam Barth.

Some ports will run the stderr output from DRT/WTR through a
filter after a crash in order to print a more useful stack
trace; while that gets written to the crash log correctly, we
don't log it to the debug output properly. This change fixes
that and makes it clearer that we're logging stderr, not the
crash log.

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner._handle_error):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port._get_crash_log):

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort._get_crash_log):

  • Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:

(ChromiumAndroidPortTest.test_get_crash_log):

  • Scripts/webkitpy/layout_tests/port/driver.py:

(Driver.run_test):

  • Scripts/webkitpy/layout_tests/port/gtk.py:
  • Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort._get_crash_log):

  • Scripts/webkitpy/layout_tests/port/port_testcase.py:

(PortTestCase.test_get_crash_log):

11:22 AM Changeset in webkit [123894] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebCore

[Texmap] Performance regression in texture uploads after r121223
https://bugs.webkit.org/show_bug.cgi?id=91897

Reviewed by Jocelyn Turcotte.

Rolling out r121223, with some conflict fixes.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::swizzleBGRAToRGBA):
(WebCore):
(WebCore::driverSupportsBGRASwizzling):
(WebCore::BitmapTextureGL::didReset):
(WebCore::BitmapTextureGL::updateContents):

11:21 AM Changeset in webkit [123893] by dpranke@chromium.org
  • 10 edits
    3 adds in trunk/Tools

nrwt: move image diffing code to a separate module
https://bugs.webkit.org/show_bug.cgi?id=92447

Reviewed by Ryosuke Niwa.

This patch moves the code to talk to ImageDiff into its own
module, and adds more tests for it. In addition, the patch
modifies diff_image() so that we don't automatically stop
ImageDiff after a single invocation, and thus subsequent
diffs may be slightly faster. (Note that the chromium ports
don't use any of this code; that is not changed by this patch).

The main motivation for this change is to move more "generic"
code out of the port/* classes, and in particular to move more
code out of webkit.py so that we can eventually eliminate it by
merging it into base.py.

This patch also splits MockServerProcess out from driver_unittest.py
so that it can be re-used.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.init):
(Port.diff_image):
(Port.clean_up_test_run):

  • Scripts/webkitpy/layout_tests/port/driver.py:

(Driver.init):
(Driver._start):

  • Scripts/webkitpy/layout_tests/port/driver_unittest.py:

(DriverTest.test_stop_cleans_up_properly):
(DriverTest.test_two_starts_cleans_up_properly):
(DriverTest.test_start_actually_starts):

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort.clean_up_test_run):

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort.clean_up_test_run):

  • Scripts/webkitpy/layout_tests/port/image_diff.py: Added.

(ImageDiffer):
(ImageDiffer.init):
(ImageDiffer.diff_image):
(ImageDiffer._start):
(ImageDiffer._read):
(ImageDiffer.stop):

  • Scripts/webkitpy/layout_tests/port/image_diff_unittest.py: Added.

(for):
(FakePort):
(FakePort.init):
(FakePort._path_to_image_diff):
(FakePort.setup_environ_for_server):
(TestImageDiffer):
(TestImageDiffer.test_diff_image):

  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:

(MockDRTPortTest.test_diff_image):

  • Scripts/webkitpy/layout_tests/port/port_testcase.py:

(PortTestCase.test_diff_imagemissing_both):
(PortTestCase.test_diff_image):
(PortTestCase.test_diff_image.make_proc):

  • Scripts/webkitpy/layout_tests/port/server_process.py:

(ServerProcess._start):

  • Scripts/webkitpy/layout_tests/port/server_process_mock.py: Added.

(MockServerProcess):
(MockServerProcess.init):
(MockServerProcess.write):
(MockServerProcess.has_crashed):
(MockServerProcess.read_stdout_line):
(MockServerProcess.read_stdout):
(MockServerProcess.pop_all_buffered_stderr):
(MockServerProcess.read_either_stdout_or_stderr_line):
(MockServerProcess.start):
(MockServerProcess.stop):
(MockServerProcess.kill):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._build_driver_flags):
(WebKitPort._symbols_string):

11:17 AM Changeset in webkit [123892] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Activate committer bit granted April 6th so I can garden.
https://bugs.webkit.org/show_bug.cgi?id=92500

Patch by Tom Hudson <hudson@google.com> on 2012-07-27
Reviewed by Jochen Eisinger.

  • Scripts/webkitpy/common/config/committers.py:
11:13 AM Changeset in webkit [123891] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Should support onbeforeunload event and show confirmation dialog
https://bugs.webkit.org/show_bug.cgi?id=92510

Patch by Yong Li <yoli@rim.com> on 2012-07-27
Reviewed by Antonio Gomes.

RIM PR# 155878.

  1. Export dispatchBeforeUnloadEvent() so client can call it before going to close the page.
  2. Forward runBeforeUnloadConfirmPanel() call to client so it can show a dialog.
  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::dispatchBeforeUnloadEvent):
(WebKit):

  • Api/WebPage.h:
  • Api/WebPageClient.h:
  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::canRunBeforeUnloadConfirmPanel):
(WebCore::ChromeClientBlackBerry::runBeforeUnloadConfirmPanel):

11:04 AM Changeset in webkit [123890] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Update NetworkJob::sendRequestWithCredentials to use new getProxyAddress API
https://bugs.webkit.org/show_bug.cgi?id=92457

Patch by Joe Mason <jmason@rim.com> on 2012-07-27
Reviewed by Yong Li.

getProxyAddress now returns "host:port", and getProxyPort is gone. Update NetworkJob to use
the new interface.

RIM PR: 176166
Internally reviewed by Jonathan Dong <Jonathan Dong>

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::sendRequestWithCredentials):

10:59 AM Changeset in webkit [123889] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Improve touch adjustment for targetting small controls.
https://bugs.webkit.org/show_bug.cgi?id=92293

Patch by Kevin Ellis <kevers@chromium.org> on 2012-07-27
Reviewed by Antonio Gomes.

Source/WebCore:

Modifies the touch adjustment algorithm to better discriminate small targets without introducing
a bias towards shorter links. The revised scoring algorihtm uses a normalized distance to
center-line score and a normalized overlap score. The better of the two scores is used for
determining the best candidate for target adjustment. The center-line score works well
for discriminating elements with partial overlaps, where relying solely on percent overlap
could bias towards the smaller element. Conversely, a high percentage in overlap provides a
strong measure of confidence in a candidate target. An additonal tie-break algorithm is
introduced to minimize the adjustment distance if two equally suitable candidates are found.

Test: touchadjustment/small-target-test.html

  • page/TouchAdjustment.cpp:

(TouchAdjustment):
(WebCore::TouchAdjustment::nodeRespondsToTapGesture):
(WebCore::TouchAdjustment::hybridDistanceFunction):
(WebCore::TouchAdjustment::findNodeWithLowestDistanceMetric):
(WebCore::findBestClickableCandidate):

LayoutTests:

Adds a test for cases that were problematic for the touch adjustment algorithm. Each example
in the test involves a small control immediately adjacent to a larger control. When the touch
area is significantly larger than the small control, it was possible for the touch element to
completely overlap the control yet select an adjacent element with a partial overlap.

  • touchadjustment/small-target-test-expected.txt: Added.
  • touchadjustment/small-target-test.html: Added.
10:56 AM Changeset in webkit [123888] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[chromium] Calendar for input type=date should be larger on devices that support touch input.
https://bugs.webkit.org/show_bug.cgi?id=92424

Patch by Kevin Ellis <kevers@chromium.org> on 2012-07-27
Reviewed by Kent Tamura.

Source/WebCore:

Adds touch specific CSS rules to enlarge entries in the calendar on
screens that support touch input.

Manually tested with touch support enabled/disabled.

  • Resources/calendarPicker.css:

(@media (pointer:coarse)):

  • html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::contentSize):

Source/WebKit/chromium:

Plumbs the deviceSupportsTouch setting through to the popup page so
that the Calendar popup can be enlarged on screens that support touch
input.

  • src/WebPagePopupImpl.cpp:

(WebKit::WebPagePopupImpl::initPage):

10:50 AM Changeset in webkit [123887] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[EFL] Add missing baselines for fast/table/table-row-outline-paint.html
https://bugs.webkit.org/show_bug.cgi?id=92509

Unreviewed EFL gardening, add missing results for
fast/table/table-row-outline-paint.html after r123793.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-27

  • platform/efl/fast/table/table-row-outline-paint-expected.png: Added.
  • platform/efl/fast/table/table-row-outline-paint-expected.txt: Added.
10:48 AM Changeset in webkit [123886] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Lose a timer in prerender-remove-after-stop.html
https://bugs.webkit.org/show_bug.cgi?id=92425

Patch by Gavin Peters <gavinp@chromium.org> on 2012-07-27
Reviewed by Nate Chapin.

japhet suggested that the timer wasn't needed, and testing revealed that the test works without it. I've tested that if the bug is reintroduced
that it crashes, and of course it doesn't crash with the fix. So bye-bye setTimeout!

  • fast/dom/HTMLLinkElement/prerender-remove-after-stop.html:
10:39 AM Changeset in webkit [123885] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Switch InputHandler malloc use to fastMalloc for cases that should never fail
https://bugs.webkit.org/show_bug.cgi?id=92508

Patch by Mike Fenton <mifenton@rim.com> on 2012-07-27
Reviewed by Yong Li.

Replace common uses of malloc with fastMalloc rather
than trying to recover gracefully. If we are truly
out of memory, crash before corruption occurs.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::spannableTextInRange):
(BlackBerry::WebKit::InputHandler::extractedTextRequest):

10:39 AM Changeset in webkit [123884] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

WebKit should expose @title as label (AXTitle or AXDescription) sometimes instead of AXHelp, according to the ARIA text alt computation
https://bugs.webkit.org/show_bug.cgi?id=91911

Reviewed by Darin Adler.

Update comments around code to explain rationale.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::helpText):
(WebCore::AccessibilityRenderObject::accessibilityDescription):

10:34 AM Changeset in webkit [123883] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Regression(r123858): Default navigation policy decision was switched to "reject"
https://bugs.webkit.org/show_bug.cgi?id=92507

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-27
Reviewed by Kentaro Hara.

After r92466, the default navigation policy is to reject the request if the
client does not make a decision explicitly. The default policy should be
to accept. This broke ewk_view unit tests.

  • ewk/ewk_view.cpp:

(ewk_view_navigation_policy_decision):

10:24 AM Changeset in webkit [123882] by commit-queue@webkit.org
  • 15 edits
    7 adds in trunk/Source/WebKit2

[EFL][WK2] Add download client for Ewk_Context
https://bugs.webkit.org/show_bug.cgi?id=91345

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-27
Reviewed by Kenneth Rohde Christiansen.

Add download client for Ewk_Context so that
information about downloads can be reported
to the client application via Ewk_View signals.

The client application needs to listen for
"download,request" signal on the view and set
the download path for the download in the
callback in order to accept it. If the signal
is ignored or if the download path is not set
the download will fail.

A new Ewk_Download_Job type is introduced to provide
information relative to a download to the client
and to allow the client to interact with it (e.g.
set its download path, cancel it, ...).

  • PlatformEfl.cmake:
  • UIProcess/API/efl/EWebKit2.h:
  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::handleDownloadRequest):
(WebKit):

  • UIProcess/API/efl/PageClientImpl.h:

(PageClientImpl):

  • UIProcess/API/efl/ewk_context.cpp:

(_Ewk_Context):
(_Ewk_Context::_Ewk_Context):
(_Ewk_Context::~_Ewk_Context):
(ewk_context_download_job_add):
(ewk_context_download_job_get):
(ewk_context_download_job_remove):

  • UIProcess/API/efl/ewk_context_download_client.cpp: Added.

(toEwkContext):
(decideDestinationWithSuggestedFilename):
(didReceiveResponse):
(didCreateDestination):
(didReceiveData):
(didFail):
(didCancel):
(didFinish):
(ewk_context_download_client_attach):

  • UIProcess/API/efl/ewk_context_download_client_private.h: Added.
  • UIProcess/API/efl/ewk_context_private.h:
  • UIProcess/API/efl/ewk_download_job.cpp: Added.

(_Ewk_Download_Job):
(_Ewk_Download_Job::_Ewk_Download_Job):
(_Ewk_Download_Job::~_Ewk_Download_Job):
(ewk_download_job_ref):
(ewk_download_job_unref):
(ewk_download_job_id_get):
(ewk_download_job_view_get):
(ewk_download_job_state_get):
(ewk_download_job_request_get):
(ewk_download_job_response_get):
(ewk_download_job_destination_get):
(ewk_download_job_destination_set):
(ewk_download_job_suggested_filename_get):
(ewk_download_job_cancel):
(ewk_download_job_estimated_progress_get):
(ewk_download_job_elapsed_time_get):
(ewk_download_job_response_set):
(ewk_download_job_suggested_filename_set):
(ewk_download_job_received_data):
(ewk_download_job_state_set):
(ewk_download_job_new):

  • UIProcess/API/efl/ewk_download_job.h: Added.
  • UIProcess/API/efl/ewk_download_job_private.h: Added.

(WebKit):

  • UIProcess/API/efl/ewk_url_response.cpp:

(ewk_url_response_content_length_get): Add a function to
retrieve the content length of a URL response.

  • UIProcess/API/efl/ewk_url_response.h:
  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_download_job_cancelled):
(ewk_view_download_job_requested):
(ewk_view_download_job_failed):
(ewk_view_download_job_finished):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/ewk_view_private.h:
  • UIProcess/API/efl/tests/resources/test.pdf: Added.
  • UIProcess/API/efl/tests/test_ewk2_download_job.cpp: Added. This tests

the download functionality.
(DownloadTestData):
(fileExists):
(serverCallback):
(on_download_requested):
(on_download_cancelled):
(on_download_failed):
(on_download_finished):
(TEST_F):

  • UIProcess/PageClient.h:

(PageClient):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit):
(WebKit::WebPageProxy::handleDownloadRequest):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

10:19 AM Changeset in webkit [123881] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Add runtime flag to enable/disable JS memory information
https://bugs.webkit.org/show_bug.cgi?id=92479

Patch by Zoltan Horvath <zoltan@webkit.org> on 2012-07-27
Reviewed by Simon Hausmann.

We need console.memory JS object to be accessible because of the memory consumption
measurements of the performance tests, so I added a toggle to InternalSettings.

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::setMemoryInfoEnabled):
(WebCore):

  • testing/InternalSettings.h:

(InternalSettings):

  • testing/InternalSettings.idl:
10:17 AM Changeset in webkit [123880] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Microdata: Remove toJs() and toV8Object() custom methods from JSHTMLElementCustom.cpp and V8HTMLElementCustom.cpp respectively.
https://bugs.webkit.org/show_bug.cgi?id=92482

Patch by Arko Saha <arko@motorola.com> on 2012-07-27
Reviewed by Kentaro Hara.

Removed custom methods toJS() and toV8Object(). We should use toJS() method defined in
JSMicroDataItemValueCustom.cpp and toV8() method defined in V8MicroDataItemValueCustom.cpp
in place of custom toJs() and toV8Object().

Existing tests :

fast/dom/MicroData/itemvalue-reflects-data-attr-on-object-element.html
fast/dom/MicroData/itemvalue-reflects-href-attr.html
fast/dom/MicroData/itemvalue-reflects-src-attribute-on-img-element.html
fast/dom/MicroData/itemvalue-reflects-the-content-attr-on-meta-element.html
fast/dom/MicroData/itemvalue-reflects-the-src-attr.html
fast/dom/MicroData/itemvalue-returns-element-itself.html
fast/dom/MicroData/itemvalue-returns-null.html
fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-001.html
fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-002.html

  • bindings/js/JSHTMLElementCustom.cpp:

(WebCore):

  • bindings/v8/custom/V8HTMLElementCustom.cpp:

(WebCore):
(WebCore::V8HTMLElement::itemValueAccessorGetter):

10:14 AM Changeset in webkit [123879] by commit-queue@webkit.org
  • 3 edits in trunk/Source

Source/WebKit: [EFL] WebKit API unit tests needs a timeout
https://bugs.webkit.org/show_bug.cgi?id=92496

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-27
Reviewed by Antonio Gomes.

Added the same timeout value that we have for WebKit2.

  • PlatformEfl.cmake:

Source/WTF: Support a rational time class for use by media elements.
https://bugs.webkit.org/show_bug.cgi?id=88787

Patch by Jer Noble <jer.noble@apple.com> on 2012-07-27
Reviewed by Eric Carlson.

Add a new MediaTime class which implements rational math operations.

Add common constructors and assignment operators:

  • wtf/MediaTime.cpp: Added.

(WTF::MediaTime::MediaTime):
(WTF::MediaTime::~MediaTime):
(WTF::MediaTime::operator=):

Add common math operators:

  • wtf/MediaTime.cpp:

(WTF::MediaTime::operator+):
(WTF::MediaTime::operator-):
(WTF::MediaTime::operator<):
(WTF::MediaTime::operator>):
(WTF::MediaTime::operator==):
(WTF::MediaTime::operator>=):
(WTF::MediaTime::operator<=):

Add functions to check the MeiaTime time type flags:

  • wtf/MediaTime.h:

(WTF::MediaTime::isValid):
(WTF::MediaTime::isInvalid):
(WTF::MediaTime::hasBeenRounde):
(WTF::MediaTime::isPositiveInfinite):
(WTF::MediaTime::isNegativeInfinite):
(WTF::MediaTime::isIndefinite):

Add constants for commonly used MediaTime values:
(WTF::MediaTime::zeroTime):
(WTF::MediaTime::invalidTime):
(WTF::MediaTime::positiveInfiniteTime):
(WTF::MediaTime::negativeInfiniteTime):
(WTF::MediaTime::indefiniteTime):

Add explicit conversion functions to convert to and from floating point values.

  • wtf/MediaTime.cpp:

(WTF::MediaTime::createWithFloat):
(WTF::MediaTime::createWithDouble):
(WTF::MediaTime::toFloat):
(WTF::MediaTime::toDouble):

Add some useful exported functions:

  • wtf/MediaTime.cpp:

(WTF::MediaTime::compare): Master function for the comparison operators above.
(WTF::MediaTime::setTimeScale): Rescale the time value to a new time scale.
(WTF::abs): Return an absolute value for the current MediaTime.

Static utility functions to implement the above:

  • wtf/MediaTime.cpp:

(WTF::greatestCommonDivisor):
(WTF::leastCommonMultiple):
(WTF::signum):

Windows-only implementations of isinf and signbit:

  • wtf/MediaTime.cpp:

(std::isinf):
(std::signbit):

Add the new class to platform build files:

  • GNUmakefile.list.am:
  • WTF.gypi:
  • WTF.pro:
  • WTF.vcproj/WTF.vcproj:
  • WTF.xcodeproj/project.pbxproj:
9:31 AM Changeset in webkit [123878] by jer.noble@apple.com
  • 14 edits
    3 adds in trunk

Support a rational time class for use by media elements.
https://bugs.webkit.org/show_bug.cgi?id=88787

Source/JavaScriptCore:

Re-export WTF::MediaTime from JavaScriptCore.

Reviewed by Eric Carlson.

Source/WTF:

Reviewed by Eric Carlson.

Add a new MediaTime class which implements rational math operations.

Add common constructors and assignment operators:

  • wtf/MediaTime.cpp: Added.

(WTF::MediaTime::MediaTime):
(WTF::MediaTime::~MediaTime):
(WTF::MediaTime::operator=):

Add common math operators:

  • wtf/MediaTime.cpp:

(WTF::MediaTime::operator+):
(WTF::MediaTime::operator-):
(WTF::MediaTime::operator<):
(WTF::MediaTime::operator>):
(WTF::MediaTime::operator==):
(WTF::MediaTime::operator>=):
(WTF::MediaTime::operator<=):

Add functions to check the MeiaTime time type flags:

  • wtf/MediaTime.h:

(WTF::MediaTime::isValid):
(WTF::MediaTime::isInvalid):
(WTF::MediaTime::hasBeenRounde):
(WTF::MediaTime::isPositiveInfinite):
(WTF::MediaTime::isNegativeInfinite):
(WTF::MediaTime::isIndefinite):

Add constants for commonly used MediaTime values:
(WTF::MediaTime::zeroTime):
(WTF::MediaTime::invalidTime):
(WTF::MediaTime::positiveInfiniteTime):
(WTF::MediaTime::negativeInfiniteTime):
(WTF::MediaTime::indefiniteTime):

Add explicit conversion functions to convert to and from floating point values.

  • wtf/MediaTime.cpp:

(WTF::MediaTime::createWithFloat):
(WTF::MediaTime::createWithDouble):
(WTF::MediaTime::toFloat):
(WTF::MediaTime::toDouble):

Add some useful exported functions:

  • wtf/MediaTime.cpp:

(WTF::MediaTime::compare): Master function for the comparison operators above.
(WTF::MediaTime::setTimeScale): Rescale the time value to a new time scale.
(WTF::abs): Return an absolute value for the current MediaTime.

Static utility functions to implement the above:

  • wtf/MediaTime.cpp:

(WTF::greatestCommonDivisor):
(WTF::leastCommonMultiple):
(WTF::signum):

Windows-only implementations of isinf and signbit:

  • wtf/MediaTime.cpp:

(std::isinf):
(std::signbit):

Add the new class to platform build files:

  • GNUmakefile.list.am:
  • WTF.gypi:
  • WTF.pro:
  • WTF.vcproj/WTF.vcproj:
  • WTF.xcodeproj/project.pbxproj:

Tools:

Add unit tests for the WTF::MediaTime class.

Reviewed by Eric Carlson.

  • TestWebKitAPI/GNUmakefile.am:
  • TestWebKitAPI/TestWebKitAPI.gypi:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/MediaTime.cpp: Added.
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:

(WTF::operator<<):
(TestWebKitAPI):
(TestWebKitAPI::TEST):

9:22 AM Changeset in webkit [123877] by kbalazs@webkit.org
  • 2 edits in trunk/Tools

[NRWT] should have a way to restrict pixel tests for individual directories
https://bugs.webkit.org/show_bug.cgi?id=91754

Unreviewed attempt to fix the chaos I introduced.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::processLine):

7:15 AM Changeset in webkit [123876] by zherczeg@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Gardening after r123786. It made 5 fast/animation tests fail
https://bugs.webkit.org/show_bug.cgi?id=92490

Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-07-27
Rubber stamped by Zoltan Herczeg.

  • platform/qt-5.0-wk2/Skipped:
7:14 AM Changeset in webkit [123875] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

set WTF_USE_LOCKFREE_THREADSAFEREFCOUNTED for chromium android
https://bugs.webkit.org/show_bug.cgi?id=91746

Patch by Wei James <james.wei@intel.com> on 2012-07-27
Reviewed by Adam Barth.

This patch is part of efforts to enable web audio for chromium android.
Web audio component needs to use atomicIncrement and atomicDecrement,
which are enabled by this MACRO.

As mentioned in https://bugs.webkit.org/show_bug.cgi?id=89428#c19, make
this patch standalone.

  • wtf/Atomics.h:

(WTF):

7:04 AM Changeset in webkit [123874] by commit-queue@webkit.org
  • 61 edits in trunk/LayoutTests

[EFL] Rebaseline after harfbuzz-ng complex font support is enabled
https://bugs.webkit.org/show_bug.cgi?id=92120

Unreviewed, EFL rebaselining.

Now that we have complex font support using harfbuzz, we need a couple of new expected results.

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-07-27

  • platform/efl/TestExpectations:
  • platform/efl/fast/dom/52776-expected.png:
  • platform/efl/fast/dom/52776-expected.txt:
  • platform/efl/fast/text/atsui-kerning-and-ligatures-expected.png:
  • platform/efl/fast/text/atsui-kerning-and-ligatures-expected.txt:
  • platform/efl/fast/text/atsui-multiple-renderers-expected.png:
  • platform/efl/fast/text/atsui-multiple-renderers-expected.txt:
  • platform/efl/fast/text/atsui-negative-spacing-features-expected.png:
  • platform/efl/fast/text/atsui-negative-spacing-features-expected.txt:
  • platform/efl/fast/text/atsui-partial-selection-expected.png:
  • platform/efl/fast/text/atsui-partial-selection-expected.txt:
  • platform/efl/fast/text/atsui-pointtooffset-calls-cg-expected.png:
  • platform/efl/fast/text/atsui-pointtooffset-calls-cg-expected.txt:
  • platform/efl/fast/text/atsui-rtl-override-selection-expected.png:
  • platform/efl/fast/text/atsui-rtl-override-selection-expected.txt:
  • platform/efl/fast/text/atsui-small-caps-punctuation-size-expected.png:
  • platform/efl/fast/text/atsui-small-caps-punctuation-size-expected.txt:
  • platform/efl/fast/text/atsui-spacing-features-expected.png:
  • platform/efl/fast/text/atsui-spacing-features-expected.txt:
  • platform/efl/fast/text/cg-vs-atsui-expected.png:
  • platform/efl/fast/text/cg-vs-atsui-expected.txt:
  • platform/efl/fast/text/complex-preferred-logical-widths-expected.png:
  • platform/efl/fast/text/complex-preferred-logical-widths-expected.txt:
  • platform/efl/fast/text/justify-ideograph-leading-expansion-expected.png:
  • platform/efl/fast/text/justify-ideograph-leading-expansion-expected.txt:
  • platform/efl/fast/text/midword-break-before-surrogate-pair-2-expected.png:
  • platform/efl/fast/text/midword-break-before-surrogate-pair-2-expected.txt:
  • platform/efl/fast/text/should-use-atsui-expected.png:
  • platform/efl/fast/text/should-use-atsui-expected.txt:
  • platform/efl/fast/text/stroking-decorations-expected.png:
  • platform/efl/fast/text/stroking-decorations-expected.txt:
  • platform/efl/fast/text/stroking-expected.png:
  • platform/efl/fast/text/stroking-expected.txt:
  • platform/efl/fast/text/wide-zero-width-space-expected.png:
  • platform/efl/fast/text/wide-zero-width-space-expected.txt:
  • platform/efl/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt:
  • platform/efl/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt:
  • platform/efl/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt:
  • platform/efl/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt:
  • platform/efl/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt:
  • platform/efl/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-direction-ltr-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-direction-rtl-expected.txt:
  • platform/efl/transforms/2d/hindi-rotated-expected.png:
  • platform/efl/transforms/2d/hindi-rotated-expected.txt:
6:56 AM Changeset in webkit [123873] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

REGRESSION(r123856): Breaks the build when disabling inspector
https://bugs.webkit.org/show_bug.cgi?id=92493

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-27
Reviewed by Kentaro Hara.

  • bindings/js/ScriptGCEvent.h:

(WebCore):

  • bindings/v8/ScriptGCEvent.h:

(WebCore):

6:45 AM Changeset in webkit [123872] by commit-queue@webkit.org
  • 8 edits
    1 copy in trunk

[WK2][EFL] Add an ACCELERATED_COMPOSITING implementation for Efl WebKit2
https://bugs.webkit.org/show_bug.cgi?id=91581

Patch by YoungTaeck Song <youngtaeck.song@samsung.com> on 2012-07-27
Reviewed by Noam Rosenthal.

Source/WebKit2:

This patch is a subset of Efl's UI_SIDE_COMPOSITING implementation.
When enter accelerated compositing mode, create evas_gl, evas_gl_context, and evas_gl_surface.

  • PlatformEfl.cmake:
  • Shared/LayerTreeContext.h:

(LayerTreeContext):

  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::viewSize):
(WebKit::PageClientImpl::enterAcceleratedCompositingMode):
(WebKit::PageClientImpl::exitAcceleratedCompositingMode):

  • UIProcess/API/efl/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::_Ewk_View_Private_Data):
(ewk_view_size_get):
(ewk_view_create_gl_surface):
(ewk_view_enter_accelerated_compositing_mode):
(ewk_view_exit_accelerated_compositing_mode):
(_ewk_view_smart_calculate):

  • UIProcess/API/efl/ewk_view_private.h:

Tools:

Add a MiniBrowser's option for selecting evas engine.

  • MiniBrowser/efl/main.c:

(browserCreate):
(main):

6:41 AM Changeset in webkit [123871] by kbalazs@webkit.org
  • 14 edits in trunk/Tools

Unreviewed, rolling out r123869.
http://trac.webkit.org/changeset/123869
https://bugs.webkit.org/show_bug.cgi?id=92501

"it did not fix anything but made things even worst"
(Requested by kbalazs on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-27

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::open):
(WebCore::DumpRenderTree::processLine):
(WebCore::DumpRenderTree::setDumpPixelsForAllTests):
(WebCore::DumpRenderTree::dump):

  • DumpRenderTree/qt/DumpRenderTreeQt.h:

(DumpRenderTree):

  • DumpRenderTree/qt/main.cpp:

(main):

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner._should_fetch_expected_checksum):
(SingleTestRunner._overwrite_baselines):
(SingleTestRunner._compare_output):

  • Scripts/webkitpy/layout_tests/controllers/worker.py:

(Worker._update_test_input):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.supports_switching_pixel_tests_per_test):
(Port):
(Port._supports_switching_pixel_tests_per_test):
(Port.should_run_as_pixel_test):
(Port._should_run_as_pixel_test):

  • Scripts/webkitpy/layout_tests/port/driver.py:

(Driver.cmd_line):
(Driver._command_from_driver_input):

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort.check_sys_deps):
(QtPort):
(QtPort._supports_switching_pixel_tests_per_test):
(QtPort._should_run_as_pixel_test):
(QtPort._default_pixel_test_directories):

  • Scripts/webkitpy/layout_tests/port/test.py:

(TestPort.supports_switching_pixel_tests_per_test):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(_set_up_derived_options):
(parse_args):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_run_singly_actually_runs_tests):
(MainTest.test_pixel_test_directories):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestController::runTest):

  • WebKitTestRunner/TestController.h:

(TestController):

6:39 AM Changeset in webkit [123870] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[EFL][WK2] Add API to Ewk_Cookie_Manager to watch for cookie changes
https://bugs.webkit.org/show_bug.cgi?id=92484

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-27
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Make use of soup/CookieStorageSoup.cpp for EFL port instead
of defining empty implementations for cookie storage
functions.

No new tests, no behavior change.

  • PlatformEfl.cmake:
  • platform/efl/TemporaryLinkStubs.cpp:

Source/WebKit2:

Add API tp Ewk_Cookie_Manager so that the client can watch
for cookie changes.

  • UIProcess/API/efl/ewk_cookie_manager.cpp:
  • UIProcess/API/efl/ewk_cookie_manager.h:
  • UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp: Add unit tests

for cookie changes watching.

6:11 AM Changeset in webkit [123869] by kbalazs@webkit.org
  • 14 edits in trunk/Tools

[NRWT] should have a way to restrict pixel tests for individual directories
https://bugs.webkit.org/show_bug.cgi?id=91754

Reviewed by Zoltan Herczeg.

Rollout r123729 because it made Qt debug bots crasy.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::open):
(WebCore::DumpRenderTree::processLine):
(WebCore::DumpRenderTree::setDumpPixels):
(WebCore::DumpRenderTree::dump):

  • DumpRenderTree/qt/DumpRenderTreeQt.h:

(DumpRenderTree):

  • DumpRenderTree/qt/main.cpp:

(main):

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner._should_fetch_expected_checksum):
(SingleTestRunner._overwrite_baselines):
(SingleTestRunner._compare_output):

  • Scripts/webkitpy/layout_tests/controllers/worker.py:

(Worker._update_test_input):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.lookup_virtual_test_args):

  • Scripts/webkitpy/layout_tests/port/driver.py:

(Driver.cmd_line):
(Driver._command_from_driver_input):

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort.check_sys_deps):

  • Scripts/webkitpy/layout_tests/port/test.py:

(TestPort.virtual_test_suites):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(_set_up_derived_options):
(parse_args):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_run_singly_actually_runs_tests):
(MainTest.test_missing_and_unexpected_results):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestController::runTest):

  • WebKitTestRunner/TestController.h:

(TestController):

5:51 AM Changeset in webkit [123868] by zherczeg@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Gardening after r123786. It made 3 fast/animation tests fail
https://bugs.webkit.org/show_bug.cgi?id=92490

Patch by János Badics <János Badics> on 2012-07-27
Rubber stamped by Zoltan Herczeg.

  • platform/qt/Skipped:
5:27 AM Changeset in webkit [123867] by keishi@webkit.org
  • 4 edits in trunk/Source/WebCore

Replace ColorChooserClient::elementRectRelativeToWindow with elementRectRelativeToRootView
https://bugs.webkit.org/show_bug.cgi?id=92488

Reviewed by Kent Tamura.

Changing ColorChooserClient interface to return element rectangle that is relative to root view instead of window.

No new tests. Method is not used yet.

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::elementRectRelativeToRootView): Replaced elementRectRelativeToWindow. Returns element rectangle relative to root view.

  • html/ColorInputType.h:

(ColorInputType):

  • platform/ColorChooserClient.h:

(ColorChooserClient):

5:25 AM EFLWebKit edited by dominik.rottsches@intel.com
ragel (diff)
4:52 AM Changeset in webkit [123866] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Stop using C API to interact with the page in Ewk_View
https://bugs.webkit.org/show_bug.cgi?id=92463

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-27
Reviewed by Simon Hausmann.

Stop using C API to interact with the PageProxy in Ewk_View
and use the PageProxy object directly. This avoids useless
converting to WK type using toAPI() all the time.

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_base_add):
(ewk_view_uri_update):
(ewk_view_uri_set):
(ewk_view_reload):
(ewk_view_reload_bypass_cache):
(ewk_view_stop):
(ewk_view_load_progress_get):
(ewk_view_device_pixel_ratio_set):
(ewk_view_theme_get):
(ewk_view_cursor_set):
(ewk_view_back):
(ewk_view_forward):
(ewk_view_intent_deliver):
(ewk_view_back_possible):
(ewk_view_forward_possible):
(ewk_view_setting_encoding_custom_get):
(ewk_view_setting_encoding_custom_set):

4:42 AM Changeset in webkit [123865] by abarth@webkit.org
  • 3 edits in trunk/Tools

webkit.review.bot should run clean-review-queue and clean-pending-commit periodically
https://bugs.webkit.org/show_bug.cgi?id=92472

Reviewed by Eric Seidel.

We need to run these command periodically to keep cruft from
accumulating in bugs.webkit.org. Rather than running them manually, we
should just have a bot run them. This patch has the style-queue run the
commands, which admittedly is a bit odd but it doesn't seem worthwhile
to create another bot specifically for this purposes.

  • Scripts/webkitpy/tool/commands/queues.py:

(AbstractReviewQueue):
(StyleQueue.begin_work_queue):
(StyleQueue):
(StyleQueue.clean_bugzilla):

  • Scripts/webkitpy/tool/commands/queues_unittest.py:

(StyleQueueTest.test_style_queue_with_style_exception):
(test_style_queue_with_watch_list_exception):

4:32 AM Changeset in webkit [123864] by commit-queue@webkit.org
  • 15 edits
    3 adds
    1 delete in trunk

[Cairo] Add complex font drawing using HarfbuzzNG
https://bugs.webkit.org/show_bug.cgi?id=91864

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-07-27
Reviewed by Simon Hausmann and Martin Robinson.

.:

Configuring Freetype backend to use HarfBuzz by default.

  • Source/cmake/FindHarfBuzz.cmake: Added pkgconfig based discovery of HarfBuzz.
  • Source/cmake/OptionsEfl.cmake: Adding Harfbuzz configuration.

Source/WebCore:

Adding Harfbuzz support to EFL by implementing it with the help of cairo and cairo-ft.
Reusing Chromium's Harfbuzz-NG support.

No new tests, complex font support is covered by existing tests.

  • CMakeLists.txt: Adding new cairo based implementations, removing emtpy FontEfl.cpp
  • WebCore.gypi: Removing FontEfl.cpp
  • platform/graphics/cairo/FontCairoHarfbuzzNG.cpp: Added. New implementation that implements cairo & harfbuzz-ng based complex font drawing.

(WebCore):
(WebCore::Font::drawComplexText):
(WebCore::Font::drawEmphasisMarksForComplexText):
(WebCore::Font::canReturnFallbackFontsForComplexText):
(WebCore::Font::canExpandAroundIdeographsInComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):

  • platform/graphics/efl/FontEfl.cpp: Removed.
  • platform/graphics/freetype/FontPlatformData.h: Adding a getter that retrieves a harfbuzz face.

(FontPlatformData):

  • platform/graphics/freetype/FontPlatformDataFreeType.cpp: Adding a getter that retrieves a harfbuzz face.

(WebCore::FontPlatformData::operator=):
(WebCore::FontPlatformData::FontPlatformData):
(WebCore):
(WebCore::FontPlatformData::harfbuzzFace):

  • platform/graphics/harfbuzz/ng/HarfBuzzNGFaceCairo.cpp: Added. Cairo-freetype based approach to get complex font metrics.

(WebCore):
(CairoFtFaceLocker):
(WebCore::CairoFtFaceLocker::CairoFtFaceLocker):
(WebCore::CairoFtFaceLocker::lock):
(WebCore::CairoFtFaceLocker::~CairoFtFaceLocker):
(WebCore::floatToHarfBuzzPosition):
(WebCore::doubleToHarfBuzzPosition):
(WebCore::CairoGetGlyphWidthAndExtents):
(WebCore::harfbuzzGetGlyph):
(WebCore::harfbuzzGetGlyphHorizontalAdvance):
(WebCore::harfbuzzGetGlyphHorizontalOrigin):
(WebCore::harfbuzzGetGlyphExtents):
(WebCore::harfbuzzCairoTextGetFontFuncs):
(WebCore::harfbuzzCairoGetTable):
(WebCore::HarfBuzzNGFace::createFace):
(WebCore::HarfBuzzNGFace::createFont):
(WebCore::HarfBuzzShaper::createGlyphBufferAdvance):

Source/WebKit:

Adding includes for harfbuzz folders.

  • CMakeLists.txt:

Source/WebKit2:

Adding includes for harfbuzz folders.

  • CMakeLists.txt:

Tools:

Bringing Harfbuzz support to EFL with this patch, so we need HarfBuzz in the pulled in jhbuild dependencies.

  • WebKitTestRunner/CMakeLists.txt: Adding additional header include directories.
  • efl/jhbuild.modules: Adding source for HarfBuzz release version 0.9.0.
4:12 AM Changeset in webkit [123863] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] Add more Ewk_View unit tests
https://bugs.webkit.org/show_bug.cgi?id=92407

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-27
Reviewed by Kenneth Rohde Christiansen.

Add more unit tests for WebKit2 Ewk_View API.
In particular, navigation, HTML loading and
device pixel ratio functions are now tested.

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:

(EWK2UnitTest::EWK2UnitTestBase::SetUp): Call ewk_init() instead
of duplicating initialization code.
(EWK2UnitTest::EWK2UnitTestBase::TearDown): call ewk_shutdown().
(TitleChangedData):
(EWK2UnitTest):
(EWK2UnitTest::onTitleChanged):
(EWK2UnitTest::EWK2UnitTestBase::waitUntilTitleChangedTo): Add convenience
method to wait until the view main frame title changes to a given value.

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:

(EWK2UnitTestBase):

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):
(serverCallbackNavigation):

4:09 AM Changeset in webkit [123862] by commit-queue@webkit.org
  • 114 edits
    1 copy
    46 adds
    9 deletes in trunk/LayoutTests

[Qt] platform/qt/editing/pasteboard tests needs update after font change.
https://bugs.webkit.org/show_bug.cgi?id=91399.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-07-27
Reviewed by Csaba Osztrogonác.

  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0-wk2/editing/pasteboard/4806874-expected.txt: Added.
  • platform/qt-5.0-wk2/editing/pasteboard/4944770-1-expected.png: Removed.
  • platform/qt-5.0-wk2/editing/pasteboard/4944770-1-expected.txt: Removed.
  • platform/qt-5.0-wk2/editing/pasteboard/4944770-2-expected.png: Removed.
  • platform/qt-5.0-wk2/editing/pasteboard/4944770-2-expected.txt: Removed.
  • platform/qt-5.0-wk2/editing/pasteboard/input-field-1-expected.txt: Copied from LayoutTests/platform/qt/editing/pasteboard/input-field-1-expected.txt.
  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/editing/pasteboard/4944770-1-expected.png: Removed.
  • platform/qt-5.0/editing/pasteboard/4944770-1-expected.txt: Removed.
  • platform/qt-5.0/editing/pasteboard/4944770-2-expected.png: Removed.
  • platform/qt-5.0/editing/pasteboard/4944770-2-expected.txt: Removed.
  • platform/qt-5.0/editing/pasteboard/paste-text-at-tabspan-003-expected.txt: Removed.
  • platform/qt/editing/pasteboard/3976872-expected.png: Added.
  • platform/qt/editing/pasteboard/3976872-expected.txt:
  • platform/qt/editing/pasteboard/4076267-2-expected.png:
  • platform/qt/editing/pasteboard/4076267-2-expected.txt:
  • platform/qt/editing/pasteboard/4076267-3-expected.png:
  • platform/qt/editing/pasteboard/4076267-3-expected.txt:
  • platform/qt/editing/pasteboard/4076267-expected.png:
  • platform/qt/editing/pasteboard/4076267-expected.txt:
  • platform/qt/editing/pasteboard/4242293-expected.png: Added.
  • platform/qt/editing/pasteboard/4242293-expected.txt:
  • platform/qt/editing/pasteboard/4631972-expected.png: Added.
  • platform/qt/editing/pasteboard/4631972-expected.txt:
  • platform/qt/editing/pasteboard/4641033-expected.png:
  • platform/qt/editing/pasteboard/4641033-expected.txt:
  • platform/qt/editing/pasteboard/4806874-expected.png:
  • platform/qt/editing/pasteboard/4806874-expected.txt:
  • platform/qt/editing/pasteboard/4944770-1-expected.png:
  • platform/qt/editing/pasteboard/4944770-1-expected.txt:
  • platform/qt/editing/pasteboard/4944770-2-expected.png:
  • platform/qt/editing/pasteboard/4944770-2-expected.txt:
  • platform/qt/editing/pasteboard/4989774-expected.png: Added.
  • platform/qt/editing/pasteboard/4989774-expected.txt:
  • platform/qt/editing/pasteboard/5006779-expected.png: Added.
  • platform/qt/editing/pasteboard/5006779-expected.txt:
  • platform/qt/editing/pasteboard/5028447-expected.png: Added.
  • platform/qt/editing/pasteboard/5028447-expected.txt:
  • platform/qt/editing/pasteboard/5032095-expected.png: Added.
  • platform/qt/editing/pasteboard/5032095-expected.txt:
  • platform/qt/editing/pasteboard/5071074-2-expected.png: Added.
  • platform/qt/editing/pasteboard/5071074-2-expected.txt:
  • platform/qt/editing/pasteboard/5071074-expected.png: Added.
  • platform/qt/editing/pasteboard/5071074-expected.txt:
  • platform/qt/editing/pasteboard/5075944-expected.png: Added.
  • platform/qt/editing/pasteboard/5075944-expected.txt:
  • platform/qt/editing/pasteboard/5134759-expected.png: Added.
  • platform/qt/editing/pasteboard/5134759-expected.txt:
  • platform/qt/editing/pasteboard/5156401-1-expected.png: Added.
  • platform/qt/editing/pasteboard/5156401-1-expected.txt:
  • platform/qt/editing/pasteboard/5247341-expected.png: Added.
  • platform/qt/editing/pasteboard/5247341-expected.txt:
  • platform/qt/editing/pasteboard/5387578-expected.png:
  • platform/qt/editing/pasteboard/5387578-expected.txt:
  • platform/qt/editing/pasteboard/5478250-expected.png:
  • platform/qt/editing/pasteboard/5478250-expected.txt:
  • platform/qt/editing/pasteboard/5601583-1-expected.png: Added.
  • platform/qt/editing/pasteboard/5601583-1-expected.txt:
  • platform/qt/editing/pasteboard/5780697-2-expected.txt:
  • platform/qt/editing/pasteboard/7955-expected.png: Added.
  • platform/qt/editing/pasteboard/7955-expected.txt:
  • platform/qt/editing/pasteboard/8145-1-expected.png: Added.
  • platform/qt/editing/pasteboard/8145-1-expected.txt:
  • platform/qt/editing/pasteboard/8145-2-expected.png: Added.
  • platform/qt/editing/pasteboard/8145-2-expected.txt:
  • platform/qt/editing/pasteboard/8145-3-expected.png:
  • platform/qt/editing/pasteboard/8145-3-expected.txt:
  • platform/qt/editing/pasteboard/bad-placeholder-expected.png:
  • platform/qt/editing/pasteboard/bad-placeholder-expected.txt:
  • platform/qt/editing/pasteboard/block-wrappers-necessary-expected.txt:
  • platform/qt/editing/pasteboard/cut-text-001-expected.png:
  • platform/qt/editing/pasteboard/cut-text-001-expected.txt:
  • platform/qt/editing/pasteboard/displaced-generic-placeholder-expected.png: Added.
  • platform/qt/editing/pasteboard/displaced-generic-placeholder-expected.txt:
  • platform/qt/editing/pasteboard/displaced-placeholder-expected.png: Added.
  • platform/qt/editing/pasteboard/displaced-placeholder-expected.txt:
  • platform/qt/editing/pasteboard/emacs-cntl-y-001-expected.png: Added.
  • platform/qt/editing/pasteboard/emacs-cntl-y-001-expected.txt:
  • platform/qt/editing/pasteboard/innerText-inline-table-expected.png:
  • platform/qt/editing/pasteboard/innerText-inline-table-expected.txt:
  • platform/qt/editing/pasteboard/input-field-1-expected.png:
  • platform/qt/editing/pasteboard/input-field-1-expected.txt:
  • platform/qt/editing/pasteboard/merge-after-delete-1-expected.png: Added.
  • platform/qt/editing/pasteboard/merge-after-delete-1-expected.txt:
  • platform/qt/editing/pasteboard/merge-after-delete-2-expected.png: Added.
  • platform/qt/editing/pasteboard/merge-after-delete-2-expected.txt:
  • platform/qt/editing/pasteboard/merge-after-delete-expected.png: Added.
  • platform/qt/editing/pasteboard/merge-after-delete-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/qt/editing/pasteboard/merge-end-blockquote-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-borders-expected.png:
  • platform/qt/editing/pasteboard/merge-end-borders-expected.txt:
  • platform/qt/editing/pasteboard/merge-start-blockquote-expected.png: Added.
  • platform/qt/editing/pasteboard/merge-start-blockquote-expected.txt:
  • platform/qt/editing/pasteboard/merge-start-list-expected.png: Added.
  • platform/qt/editing/pasteboard/merge-start-list-expected.txt:
  • platform/qt/editing/pasteboard/paste-4035648-fix-expected.png: Added.
  • platform/qt/editing/pasteboard/paste-4035648-fix-expected.txt:
  • platform/qt/editing/pasteboard/paste-4038267-fix-expected.png: Added.
  • platform/qt/editing/pasteboard/paste-4038267-fix-expected.txt:
  • platform/qt/editing/pasteboard/paste-blockquote-after-blockquote-expected.png: Added.
  • platform/qt/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt:
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.png: Added.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-001-expected.png: Added.
  • platform/qt/editing/pasteboard/paste-line-endings-001-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-002-expected.png: Added.
  • platform/qt/editing/pasteboard/paste-line-endings-002-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-003-expected.png: Added.
  • platform/qt/editing/pasteboard/paste-line-endings-003-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-004-expected.png: Added.
  • platform/qt/editing/pasteboard/paste-line-endings-004-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-005-expected.png: Added.
  • platform/qt/editing/pasteboard/paste-line-endings-005-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-006-expected.png: Added.
  • platform/qt/editing/pasteboard/paste-line-endings-006-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-007-expected.png:
  • platform/qt/editing/pasteboard/paste-line-endings-007-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-008-expected.png:
  • platform/qt/editing/pasteboard/paste-line-endings-008-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-009-expected.png:
  • platform/qt/editing/pasteboard/paste-line-endings-009-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-010-expected.png:
  • platform/qt/editing/pasteboard/paste-line-endings-010-expected.txt:
  • platform/qt/editing/pasteboard/paste-match-style-001-expected.png:
  • platform/qt/editing/pasteboard/paste-match-style-001-expected.txt:
  • platform/qt/editing/pasteboard/paste-match-style-002-expected.png: Added.
  • platform/qt/editing/pasteboard/paste-match-style-002-expected.txt:
  • platform/qt/editing/pasteboard/paste-table-003-expected.png:
  • platform/qt/editing/pasteboard/paste-table-003-expected.txt:
  • platform/qt/editing/pasteboard/paste-table-cells-expected.png:
  • platform/qt/editing/pasteboard/paste-table-cells-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-004-expected.png:
  • platform/qt/editing/pasteboard/paste-text-004-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-005-expected.png:
  • platform/qt/editing/pasteboard/paste-text-005-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-006-expected.png: Added.
  • platform/qt/editing/pasteboard/paste-text-006-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-007-expected.png: Added.
  • platform/qt/editing/pasteboard/paste-text-007-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-008-expected.png:
  • platform/qt/editing/pasteboard/paste-text-008-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-009-expected.png:
  • platform/qt/editing/pasteboard/paste-text-009-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-013-expected.png: Added.
  • platform/qt/editing/pasteboard/paste-text-013-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-014-expected.png:
  • platform/qt/editing/pasteboard/paste-text-014-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-016-expected.png: Added.
  • platform/qt/editing/pasteboard/paste-text-016-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-019-expected.png:
  • platform/qt/editing/pasteboard/paste-text-019-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-at-tabspan-003-expected.png:
  • platform/qt/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
  • platform/qt/editing/pasteboard/pasting-object-expected.png:
  • platform/qt/editing/pasteboard/pasting-object-expected.txt:
  • platform/qt/editing/pasteboard/quirks-mode-br-1-expected.png: Added.
  • platform/qt/editing/pasteboard/quirks-mode-br-1-expected.txt:
  • platform/qt/editing/pasteboard/smart-paste-004-expected.txt: Added.
  • platform/qt/editing/pasteboard/smart-paste-007-expected.png:
  • platform/qt/editing/pasteboard/smart-paste-007-expected.txt:
  • platform/qt/editing/pasteboard/styled-element-markup-expected.png: Added.
  • platform/qt/editing/pasteboard/styled-element-markup-expected.txt:
  • platform/qt/editing/pasteboard/undoable-fragment-removes-expected.png: Added.
  • platform/qt/editing/pasteboard/undoable-fragment-removes-expected.txt:
  • platform/qt/editing/pasteboard/unrendered-br-expected.png: Added.
  • platform/qt/editing/pasteboard/unrendered-br-expected.txt:
4:04 AM Changeset in webkit [123861] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
3:47 AM Changeset in webkit [123860] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Keyboard events miss key location data.
https://bugs.webkit.org/show_bug.cgi?id=92235

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-07-27
Reviewed by Simon Hausmann.

EFL WK2 did not initialize WebKeyboardEvent::m_isKeypad field.
This caused failure of fast/events/keydown-numpad-keys.html test.

  • Shared/efl/WebEventFactory.cpp: WebKeyboardEvent::m_isKeypad is initialized.

(WebKit::WebEventFactory::createWebKeyboardEvent):

3:44 AM Changeset in webkit [123859] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Tools

[WK2][EFL][WTR] TestNetscapePlugin is required.
https://bugs.webkit.org/show_bug.cgi?id=88756

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-07-27
Reviewed by Simon Hausmann.

libTestNetscapePlugin.so should be required for DRT/WTR/EFL.

  • CMakeLists.txt:
  • DumpRenderTree/TestNetscapePlugin/CMakeList.txt:
2:55 AM Changeset in webkit [123858] by gyuyoung.kim@samsung.com
  • 6 edits in trunk/Source

[EFL] Fix wrong return value in EWK_VIEW_XXX macro.
https://bugs.webkit.org/show_bug.cgi?id=92466

Reviewed by Simon Hausmann.

There are wrong return values in EWK_VIEW_XXX macros. The wrong return values
should be fixed. In addition, API description is also modified according to returned
value change.

Source/WebKit/efl:

  • ewk/ewk_view.cpp:

(ewk_view_setting_minimum_timer_interval_get):
(ewk_view_navigation_policy_decision):
(ewk_view_page_rect_get):
(ewk_view_setting_enable_xss_auditor_get):

  • ewk/ewk_view.h:

Source/WebKit2:

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_uri_set):
(ewk_view_load_progress_get):
(ewk_view_device_pixel_ratio_get):

  • UIProcess/API/efl/ewk_view.h:
2:41 AM Changeset in webkit [123857] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening, adding a text failure expectation for an accessibility
test that started failing after r123767.

  • platform/gtk/TestExpectations:
2:37 AM Changeset in webkit [123856] by abarth@webkit.org
  • 12 edits
    1 copy in trunk/Source

Add a Setting to expose quantized, rate-limited MemoryInfo values
https://bugs.webkit.org/show_bug.cgi?id=80444

Reviewed by Eric Seidel.

We do not currently expose real MemoryInfo objects to the web unless
the user opts in because we're worried that this memory information
could be used in side-channel attacks.

We've gotten feedback from a number of web app developers that this
information is very useful in tracking the performance of their
applications. These developers use the setting in their testing labs
and regression harnesses to catch memory leaks and regressiosn early in
their development cycle.

Some of these developers have experimented with enabling this feature
within their enterprise and have found the memory data from the field
extremely useful in tracking down memory issues that slip through their
testing.

Based on this experience, they've asked whether we can enable this
functionality on a wider scale so they catch even more problems
including problems that don't manifest within their enterprise.
Because we're still worried about side-channel attacks, we don't want
to expose the raw data, so we've talked with these folks in more detail
to understand what information they find most valuable.

This patch is the result of those discussions. In particular, this
patch adds an option to expose quantized and rate-limited memory
information to web pages. Web pages can only learn new data every 20
minutes, which helps mitigate attacks where the attacker compares two
or readings to extract side-channel information. The patch also only
reports 100 distinct memory values, which (combined with the rate
limts) makes it difficult for attackers to learn about small changes in
memory use.

  • page/MemoryInfo.cpp:

(WebCore):
(HeapSizeCache):
(WebCore::HeapSizeCache::HeapSizeCache):
(WebCore::HeapSizeCache::getCachedHeapSize):
(WebCore::HeapSizeCache::maybeUpdate):
(WebCore::HeapSizeCache::update):
(WebCore::HeapSizeCache::quantize):
(WebCore::MemoryInfo::MemoryInfo):

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setQuantizedMemoryInfoEnabled):
(WebCore::Settings::quantizedMemoryInfoEnabled):
(Settings):

2:36 AM Changeset in webkit [123855] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Fix issues in visiblePositionForWindowPoint (offscreen points / iframes).
https://bugs.webkit.org/show_bug.cgi?id=79117

Fix two issues in WebFrameImpl::visiblePositionForWindowPoint.

1) If the point is off-screen, the visiblePosition is clipped to the screen.

  • The fix is to add HitTestRequest::IgnoreClipping.

2) The result is incorrect if the point is within an iframe.

  • This is because we are calling convertFromContainingWindow twice: once in windowToContents, and then explicitly as well.
  • This patch removes the explicit call to convertFromContainingWindow.

Patch by Oli Lan <olilan@chromium.org> on 2012-07-27
Reviewed by Adam Barth.

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::visiblePositionForWindowPoint):

2:32 AM Changeset in webkit [123854] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
2:26 AM Changeset in webkit [123853] by vsevik@chromium.org
  • 4 edits in trunk

Source/WebCore: Web Inspector: Move formatting support from JavaScriptSource to UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=92373

Reviewed by Pavel Feldman.

Moved formatting support from JavaScriptSource to UISourceCode.
Extracted Formatter interface from ScriptFormatter and created IdentityFormatter
implememntation and Formatter.createFormatter(contentType) formatter factory.
Introduced virtual formattedChanged() method on UISourceCode.

  • inspector/front-end/JavaScriptSource.js:

(WebInspector.JavaScriptSource):
(WebInspector.JavaScriptSource.prototype.uiLocationToRawLocation):
(WebInspector.JavaScriptSource.prototype.breakpointStorageId):
(WebInspector.JavaScriptSource.prototype.searchInContent):
(WebInspector.JavaScriptSource.prototype.formattedChanged):

  • inspector/front-end/ScriptFormatter.js:

(WebInspector.Formatter):
(WebInspector.Formatter.createFormatter):
(WebInspector.Formatter.locationToPosition):
(WebInspector.Formatter.positionToLocation):
(WebInspector.Formatter.prototype.formatContent):
(WebInspector.ScriptFormatter):
(WebInspector.IdentityFormatter):
(WebInspector.IdentityFormatter.prototype.formatContent):
(WebInspector.FormatterSourceMappingImpl.prototype.originalToFormatted):
(WebInspector.FormatterSourceMappingImpl.prototype.formattedToOriginal):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.requestContent):
(WebInspector.UISourceCode.prototype._fireContentAvailable):
(WebInspector.UISourceCode.prototype.uiLocationToRawLocation):
(WebInspector.UISourceCode.prototype.overrideLocation):
(WebInspector.UISourceCode.prototype.togglingFormatter):
(WebInspector.UISourceCode.prototype.formatted):
(WebInspector.UISourceCode.prototype.setFormatted.if):
(WebInspector.UISourceCode.prototype.setFormatted.didGetContent.formattedChanged):
(WebInspector.UISourceCode.prototype.setFormatted.didGetContent):
(WebInspector.UISourceCode.prototype.setFormatted):
(WebInspector.UISourceCode.prototype.createFormatter):
(WebInspector.UISourceCode.prototype.formattedChanged):

Source/WebKit2: [EFL][WK2] Add unit tests for Ewk_View form client
https://bugs.webkit.org/show_bug.cgi?id=92468

Reviewed by Simon Hausmann.

Add unit test for form client functionality in
Ewk_View.

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(onFormAboutToBeSubmitted):
(TEST_F):

LayoutTests: Web Inspector: Move formatting support from JavaScriptSource to UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=92373

Reviewed by Pavel Feldman.

  • inspector/debugger/script-formatter.html:
1:50 AM Changeset in webkit [123852] by vsevik@chromium.org
  • 6 edits in trunk

Web Inspector: Move formatting support from JavaScriptSource to UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=92373

Reviewed by Pavel Feldman.

Source/WebCore:

Moved formatting support from JavaScriptSource to UISourceCode.
Extracted Formatter interface from ScriptFormatter and created IdentityFormatter
implememntation and Formatter.createFormatter(contentType) formatter factory.
Introduced virtual formattedChanged() method on UISourceCode.

  • inspector/front-end/JavaScriptSource.js:

(WebInspector.JavaScriptSource):
(WebInspector.JavaScriptSource.prototype.uiLocationToRawLocation):
(WebInspector.JavaScriptSource.prototype.breakpointStorageId):
(WebInspector.JavaScriptSource.prototype.searchInContent):
(WebInspector.JavaScriptSource.prototype.formattedChanged):

  • inspector/front-end/ScriptFormatter.js:

(WebInspector.Formatter):
(WebInspector.Formatter.createFormatter):
(WebInspector.Formatter.locationToPosition):
(WebInspector.Formatter.positionToLocation):
(WebInspector.Formatter.prototype.formatContent):
(WebInspector.ScriptFormatter):
(WebInspector.IdentityFormatter):
(WebInspector.IdentityFormatter.prototype.formatContent):
(WebInspector.FormatterSourceMappingImpl.prototype.originalToFormatted):
(WebInspector.FormatterSourceMappingImpl.prototype.formattedToOriginal):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.requestContent):
(WebInspector.UISourceCode.prototype._fireContentAvailable):
(WebInspector.UISourceCode.prototype.uiLocationToRawLocation):
(WebInspector.UISourceCode.prototype.overrideLocation):
(WebInspector.UISourceCode.prototype.togglingFormatter):
(WebInspector.UISourceCode.prototype.formatted):
(WebInspector.UISourceCode.prototype.setFormatted.if):
(WebInspector.UISourceCode.prototype.setFormatted.didGetContent.formattedChanged):
(WebInspector.UISourceCode.prototype.setFormatted.didGetContent):
(WebInspector.UISourceCode.prototype.setFormatted):
(WebInspector.UISourceCode.prototype.createFormatter):
(WebInspector.UISourceCode.prototype.formattedChanged):

LayoutTests:

  • inspector/debugger/script-formatter.html:
1:41 AM Changeset in webkit [123851] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Memory leaks in EFL DRT
https://bugs.webkit.org/show_bug.cgi?id=92347

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-27
Reviewed by Simon Hausmann.

Fix a memory leak in EFL's DRT code by adopting an allocation
of JSString created with JSStringCreateWithUTF8CString.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::onWindowObjectCleared):

1:34 AM Changeset in webkit [123850] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Page object should ascertain EditorClient to be non-null
https://bugs.webkit.org/show_bug.cgi?id=92458

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-07-27
Reviewed by Ryosuke Niwa.

The EditorClient should always be available in Page object. Added the assertion to ascertain this.

No new tests. Added assertion to make sure EditorClient always exist.

  • page/Page.cpp:

(WebCore::Page::Page):

1:28 AM Changeset in webkit [123849] by zherczeg@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

[Qt] Unreviewed, rebaseline for tests introduced in r123790

Patch by János Badics <János Badics> on 2012-07-27
Rubber stamped by Zoltan Herczeg.

  • platform/qt/css3/filters/effect-brightness-clamping-expected.png: Added.
  • platform/qt/css3/filters/effect-brightness-clamping-expected.txt: Added.
  • platform/qt/css3/filters/effect-brightness-clamping-hw-expected.png: Added.
  • platform/qt/css3/filters/effect-brightness-clamping-hw-expected.txt: Added.
1:25 AM Changeset in webkit [123848] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebCore

Gather the duplicated timer code into CachedResource.
https://bugs.webkit.org/show_bug.cgi?id=92332

Patch by Huang Dongsung <luxtella@company100.net> on 2012-07-27
Reviewed by Nate Chapin.

Internal review by Jae Hyun Park.

When all clients are removed, CachedImage, CachedScript and CachedCSSStyleSheet
start the timer to destroy decoded data. Those three classes have their own
timer.
Changed CachedCSSStyleSheet::didAddClient to call super class method in order to
stop the timer. This change does not have any side effect because
CachedResource::didAddClient only stops the timer in this case.

No new tests - no new testable functionality.

  • loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
(WebCore::CachedCSSStyleSheet::didAddClient):

  • loader/cache/CachedCSSStyleSheet.h:

(CachedCSSStyleSheet):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::CachedImage):
(WebCore::CachedImage::didAddClient):
(WebCore::CachedImage::allClientsRemoved):

  • loader/cache/CachedImage.h:

(CachedImage):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::didAddClient):
(WebCore::CachedResource::removeClient):
(WebCore::CachedResource::destroyDecodedDataIfNeeded):
(WebCore):
(WebCore::CachedResource::decodedDataDeletionTimerFired):

  • loader/cache/CachedResource.h:

(CachedResource):

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::CachedScript):

  • loader/cache/CachedScript.h:

(CachedScript):

12:56 AM Changeset in webkit [123847] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/efl

[EFL] Change prototype of run_open_panel
https://bugs.webkit.org/show_bug.cgi?id=91956

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-07-27
Reviewed by Kentaro Hara.

In order to support all of the file chooser attributes,
change the types of parameters in run_open_panel method.
i.e., change "Eina_Bool allows_multiple_files, Eina_List *accept_types"
to "Ewk_File_Chooser *file_chooser"
In addition, Efl can support the capture attribute for HTML media capture.

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::runOpenPanel):

  • ewk/ewk_view.cpp:

(ewk_view_run_open_panel):

  • ewk/ewk_view.h:
  • ewk/ewk_view_private.h:
12:51 AM Changeset in webkit [123846] by abarth@webkit.org
  • 2 edits in trunk/Websites/webkit.org

Writing a blog post for new reviewers doesn't add value to the blog
https://bugs.webkit.org/show_bug.cgi?id=92305

Reviewed by Eric Seidel.

Now that we have Peter posting weekly updates to the blog, having an
announcement on the blog for each reviewer is more noise than signal.

  • coding/commit-review-policy.html:
12:48 AM Changeset in webkit [123845] by abarth@webkit.org
  • 4 edits in trunk/Tools

Simplify ExpectedFailures
https://bugs.webkit.org/show_bug.cgi?id=92216

Reviewed by Eric Seidel.

This patch simplifies the ExpectedFailures class we use to remember
which tests are currently failing on the bots. When we wrote this code
originally, we weren't entirely sure how it would work. Now that we
understand it more clearly, we can write the code more clearly.

  • Scripts/webkitpy/tool/bot/expectedfailures.py:

(_has_failures):
(_is_trustworthy):
(ExpectedFailures.init):
(ExpectedFailures.failures_were_expected):
(ExpectedFailures.unexpected_failures_observed):
(ExpectedFailures.update):

  • Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:

(ExpectedFailuresTest._assert_can_trust):
(ExpectedFailuresTest.test_failures_were_expected):
(ExpectedFailuresTest.test_unexpected_failures_observed):
(ExpectedFailuresTest.test_unexpected_failures_observed_when_tree_is_hosed):

  • Scripts/webkitpy/tool/bot/patchanalysistask.py:

(PatchAnalysisTask._test):
(PatchAnalysisTask._build_and_test_without_patch):
(PatchAnalysisTask._test_patch):

12:44 AM Changeset in webkit [123844] by danakj@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Don't add a HUD layer when there is no rootLayer
https://bugs.webkit.org/show_bug.cgi?id=92442

Reviewed by Adrienne Walker.

When the compositor is shutting down in threaded mode, it does a commit
without a root layer. We should not try stick the hud layer onto the
null root layer.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::willCommit):

12:30 AM Changeset in webkit [123843] by commit-queue@webkit.org
  • 31 edits
    3 adds in trunk

IndexedDB: inject index keys on cursor/objectstore/index get success handlers
https://bugs.webkit.org/show_bug.cgi?id=91123

Patch by Alec Flett <alecflett@chromium.org> on 2012-07-27
Reviewed by Tony Chang.

Source/WebCore:

Move key-injection into the frontend, by injecting the key into
the value on get rather than set for autoincremented keys. This
gives a potential performance win by avoiding an IPC call to the
V8 utility process on chromium, and generally cleans up the key
management.

Note that this duplicates the logic of generateIndexKeys into the
frontend until that method can be expunged from the backend. This
will be cleaned up in a later patch.

In order to account for both old data (which has the duplicate
primary key already injected and serialized) and any new data, an
assertion was removed from IDBBindingUtilities.

This also includes some minor refactoring such as the deprecation
of IDBCursorBackendInterface::update in favor of a direct call to
IDBObjectStoreBackendImpl::put, and removal of the now-defunct
IDBBackingStore::getObjectViaIndex.

Tests: storage/indexdb/index-duplicate-keypaths.html

  • Modules/indexeddb/IDBBackingStore.h:

(IDBBackingStore):

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::update):
(WebCore::IDBCursor::setValueReady):

  • Modules/indexeddb/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::update):

  • Modules/indexeddb/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::getInternal):

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:
  • Modules/indexeddb/IDBLevelDBBackingStore.h:

(IDBLevelDBBackingStore):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::generateIndexKeysForValue):
(WebCore):
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):

  • Modules/indexeddb/IDBObjectStore.h:

(IDBObjectStore):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::putWithIndexKeys):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::putInternal):

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::onSuccess):

  • bindings/v8/IDBBindingUtilities.cpp:

(WebCore):

Source/WebKit/chromium:

Remove method no longer used.

  • tests/IDBFakeBackingStore.h:

LayoutTests:

One new test to make sure that indexes with the same keypath as an
autoIncrement'ed objectStore still index their values. Also minor
tweaks to tests to make it easier to figure out which key is being
updated.

  • storage/indexeddb/index-duplicate-keypaths-expected.txt: Added.
  • storage/indexeddb/index-duplicate-keypaths.html: Added.
  • storage/indexeddb/mozilla/autoincrement-indexes-expected.txt:
  • storage/indexeddb/mozilla/resources/autoincrement-indexes.js:
  • storage/indexeddb/resources/index-duplicate-keypaths.js: Added.
12:27 AM Changeset in webkit [123842] by tony@chromium.org
  • 4 edits
    2 adds in trunk

changing -webkit-order should change the paint order of flex items
https://bugs.webkit.org/show_bug.cgi?id=92041

Reviewed by Ojan Vafai.

Source/WebCore:

Override paintChildren and use the flex order iterator to determine the order to paint the children.

Test: css3/flexbox/order-painting.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock): Save a reference to the order iterator.
(WebCore::RenderFlexibleBox::paintChildren):

  • rendering/RenderFlexibleBox.h:

(RenderFlexibleBox): Hold a reference to the order iterator so we don't have to recreate it at paint time.

Also mark all the virtual methods with OVERRIDE.

LayoutTests:

Use a ref test since this is testing paint behavior.

  • css3/flexbox/order-painting-expected.html: Added.
  • css3/flexbox/order-painting.html: Added.
12:10 AM Changeset in webkit [123841] by Csaba Osztrogonác
  • 7 edits in trunk

[Qt][WK2] REGRESSION(r119127): resetting window.internals settings between tests doesn't work properly
https://bugs.webkit.org/show_bug.cgi?id=88064

Reviewed by Zoltan Herczeg.

Source/WebKit/qt:

Add missing DumpRenderTreeSupportQt::resetInternalsObject(JSContextRef context) function.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::resetInternalsObject):

  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

Use resetInternalsObject() instead of injectInternalsObject().

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::resetAfterTest):

LayoutTests:

  • platform/qt-5.0-wk2/Skipped: Unskip now passing tests.

Jul 26, 2012:

11:35 PM Changeset in webkit [123840] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r123820.
http://trac.webkit.org/changeset/123820
https://bugs.webkit.org/show_bug.cgi?id=92465

It made all tests crash on all port (Requested by Ossy_home on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-26

  • dom/EventNames.cpp:

(WebCore):

11:21 PM Changeset in webkit [123839] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Qt build fix after r123788. Fixed the typo.

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::handleElementAttributes):

10:53 PM Changeset in webkit [123838] by hbono@chromium.org
  • 2 edits in trunk/Source/WebCore

[Qt] Build fix for Qt after r123811
https://bugs.webkit.org/show_bug.cgi?id=92460

Reviewed by Ryosuke Niwa.

This change explicitly converts from AtomicString to String to avoid ambiguities
when compiling HTMLAppletWidget.cpp on Qt.

No new tests because it is a build fix.

  • html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::updateWidget):

9:32 PM Changeset in webkit [123837] by mikelawther@chromium.org
  • 4 edits
    2 adds in trunk

Make transitions work between different Length types
https://bugs.webkit.org/show_bug.cgi?id=92220

Reviewed by Simon Fraser.

Source/WebCore:

Use the existing CSS calc machinery for blending between two calculations
to blend between two Lengths of differing types.

Test: transitions/mixed-type.html

  • platform/Length.cpp:

(WebCore::Length::blendMixedTypes):

  • platform/Length.h:

(WebCore::Length::blend):
(Length):

LayoutTests:

  • transitions/mixed-type-expected.txt: Added.
  • transitions/mixed-type.html: Added.
9:07 PM Changeset in webkit [123836] by yosin@chromium.org
  • 1 edit
    16 moves in trunk/LayoutTests

[Tests] Rename fast/forms/{number,time}/*-validity-state-* to *-validity-*
https://bugs.webkit.org/show_bug.cgi?id=92449

Reviewed by Kent Tamura.

This patch renames test files in fast/forms/{number,time} for matching
with IDL attribute names.

  • fast/forms/number/number-validity-rangeoverflow-expected.txt: Copied from LayoutTests/fast/forms/number/number-validitystate-range-overflow-expected.txt.
  • fast/forms/number/number-validity-rangeoverflow.html: Copied from LayoutTests/fast/forms/number/number-validitystate-range-overflow.html.
  • fast/forms/number/number-validity-rangeunderflow-expected.txt: Copied from LayoutTests/fast/forms/number/number-validity-state-range-underflow-expected.txt.
  • fast/forms/number/number-validity-rangeunderflow.html: Copied from LayoutTests/fast/forms/number/number-validity-state-range-underflow.html.
  • fast/forms/number/number-validity-state-range-underflow-expected.txt: Removed.
  • fast/forms/number/number-validity-state-range-underflow.html: Removed.
  • fast/forms/number/number-validity-state-step-mismatch-expected.txt: Removed.
  • fast/forms/number/number-validity-state-step-mismatch.html: Removed.
  • fast/forms/number/number-validity-state-type-mismatch-expected.txt: Removed.
  • fast/forms/number/number-validity-state-type-mismatch.html: Removed.
  • fast/forms/number/number-validity-stepmismatch-expected.txt: Copied from LayoutTests/fast/forms/number/number-validity-state-step-mismatch-expected.txt.
  • fast/forms/number/number-validity-stepmismatch.html: Copied from LayoutTests/fast/forms/number/number-validity-state-step-mismatch.html.
  • fast/forms/number/number-validity-typemismatch-expected.txt: Copied from LayoutTests/fast/forms/number/number-validity-state-type-mismatch-expected.txt.
  • fast/forms/number/number-validity-typemismatch.html: Copied from LayoutTests/fast/forms/number/number-validity-state-type-mismatch.html.
  • fast/forms/number/number-validitystate-range-overflow-expected.txt: Removed.
  • fast/forms/number/number-validitystate-range-overflow.html: Removed.
  • fast/forms/time/time-validity-rangeoverflow-expected.txt: Copied from LayoutTests/fast/forms/time/time-validity-state-range-overflow-expected.txt.
  • fast/forms/time/time-validity-rangeoverflow.html: Copied from LayoutTests/fast/forms/time/time-validity-state-range-overflow.html.
  • fast/forms/time/time-validity-rangeunderflow-expected.txt: Copied from LayoutTests/fast/forms/time/time-validity-state-range-underflow-expected.txt.
  • fast/forms/time/time-validity-rangeunderflow.html: Copied from LayoutTests/fast/forms/time/time-validity-state-range-underflow.html.
  • fast/forms/time/time-validity-state-range-overflow-expected.txt: Removed.
  • fast/forms/time/time-validity-state-range-overflow.html: Removed.
  • fast/forms/time/time-validity-state-range-underflow-expected.txt: Removed.
  • fast/forms/time/time-validity-state-range-underflow.html: Removed.
  • fast/forms/time/time-validity-state-step-mismatch-expected.txt: Removed.
  • fast/forms/time/time-validity-state-step-mismatch.html: Removed.
  • fast/forms/time/time-validity-state-type-mismatch-expected.txt: Removed.
  • fast/forms/time/time-validity-state-type-mismatch.html: Removed.
  • fast/forms/time/time-validity-stepmismatch-expected.txt: Copied from LayoutTests/fast/forms/time/time-validity-state-step-mismatch-expected.txt.
  • fast/forms/time/time-validity-stepmismatch.html: Copied from LayoutTests/fast/forms/time/time-validity-state-step-mismatch.html.
  • fast/forms/time/time-validity-typemismatch-expected.txt: Copied from LayoutTests/fast/forms/time/time-validity-state-type-mismatch-expected.txt.
  • fast/forms/time/time-validity-typemismatch.html: Copied from LayoutTests/fast/forms/time/time-validity-state-type-mismatch.html.
8:48 PM Changeset in webkit [123835] by mitz@apple.com
  • 3 edits
    2 adds in trunk

Blocks with reverse column progression don’t have layout overflow for overflowing columns
https://bugs.webkit.org/show_bug.cgi?id=92440

Reviewed by Sam Weinig.

Source/WebCore:

Test: fast/multicol/progression-reverse-overflow.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::addLayoutOverflow): If column progression is reversed, then allow
layout overflow to go in the opposite direction than it would normally be allowed to go.
For example, in a block with writing-mode: horizontal-tb, direction: ltr and
column-progression: reverse, columns overflow to the left, so layout overflow would go on
the left.

LayoutTests:

  • fast/multicol/progression-reverse-overflow-expected.html: Added.
  • fast/multicol/progression-reverse-overflow.html: Added.
8:24 PM Changeset in webkit [123834] by mitz@apple.com
  • 3 edits in trunk

When Safari 6 is launched via the WebKit Xcode workspace, it does not link against the built frameworks
https://bugs.webkit.org/show_bug.cgi?id=92331

Reviewed by Mark Rowe.

Changed references to the Safari executable to the SafariForWebKitDevelopment binary.

  • WebKit.xcworkspace/xcshareddata/xcschemes/All Source (target WebProcess).xcscheme:
  • WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:
8:21 PM Changeset in webkit [123833] by keishi@webkit.org
  • 4 edits
    3 adds in trunk

Implement ColorSuggestionPicker page popup
https://bugs.webkit.org/show_bug.cgi?id=92109

Reviewed by Kent Tamura.

.:

  • ManualTests/forms/color-suggestion-picker.html: Added. Tests colorSuggestionPicker.{js,css}

Source/WebCore:

Implements ColorSuggestionPicker page popup. This will be used in
certain ports as the datalist UI for <input type=color>.

No new tests because there is no way to open the popup yet.

  • Resources/colorSuggestionPicker.css: Added.

(body):
(#main):
(.color-swatch):
(.color-swatch:hover):
(.color-swatch-container):
(.other-color):

  • Resources/colorSuggestionPicker.js: Added.

(getScrollbarWidth):When there are more than 20 colors we need to
increase the window width to accommodate the scroll bar.
(createElement):
(handleMessage):
(initialize):
(handleArgumentsTimeout):
(validateArguments):
(submitValue): Calls setValueAndClosePopup with a numValue of 0.
(handleCancel): Calls setValueAndClosePopup with a numValue of -1.
(chooseOtherColor): Calls setValueAndClosePopup with a numValue of -2.
(ColorPicker):
(ColorPicker.prototype._layout): Lays out the color swatches in a 5x4
grid.
(ColorPicker.prototype._handleSwatchClick):

  • WebCore.gyp/WebCore.gyp: Added ColorSuggestionPicker action.
  • make-file-arrays.py:

(main): Windows gets confused when "&&" is in the command, so we will replace " AND " with " && " internally.

7:49 PM Changeset in webkit [123832] by ryuan.choi@samsung.com
  • 2 edits in trunk/Tools

[EFL] Remove forwarding headers from MiniBrowser/Efl.
https://bugs.webkit.org/show_bug.cgi?id=91627

Reviewed by Kentaro Hara.

  • MiniBrowser/efl/CMakeLists.txt: Remove unnecessary forwarding headers.
7:41 PM Changeset in webkit [123831] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Highlight the element under mouse on web inspector
https://bugs.webkit.org/show_bug.cgi?id=91592

Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-07-26
Reviewed by Kentaro Hara.

Implement highlighting the nodes when using the web inspector.

  • WebCoreSupport/InspectorClientEfl.cpp:

(WebCore::InspectorClientEfl::highlight):
(WebCore::InspectorClientEfl::hideHighlight):
(WebCore::InspectorClientEfl::invalidateView):
(WebCore):

  • WebCoreSupport/InspectorClientEfl.h:

(InspectorClientEfl):

  • ewk/ewk_paint_context.cpp:

(ewk_paint_context_paint_contents):

7:30 PM Changeset in webkit [123830] by commit-queue@webkit.org
  • 8 edits
    1 add in trunk/Source/WebCore

De-virtualize WrapShape classes
https://bugs.webkit.org/show_bug.cgi?id=90998

Patch by Anish Bhayani <anish.bhayani@gmail.com> on 2012-07-26
Reviewed by Andreas Kling.

The destructor for WrapShapes classes did not need to use a virtual
pointer. WrapShapes.cpp is created to cast the WrapShape destructor
to the subclass type saving memory and avoiding virtual calls.

There are existing tests that cover the validity of shapes. The
added changes merely change the destructor of the shape objects
which is also tested by LayoutTests/fast/exclusions.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/style/WrapShapes.cpp: Added.

(WebCore):
(WebCore::WrapShape::destroy):

  • rendering/style/WrapShapes.h:

(WebCore::WrapShape::deref):
(WrapShape):
(WebCore::WrapShape::type):
(WebCore::WrapShape::setType):
(WrapShapeRectangle):
(WebCore::WrapShapeRectangle::WrapShapeRectangle):
(WebCore::WrapShapeCircle::WrapShapeCircle):
(WebCore::WrapShapeEllipse::WrapShapeEllipse):
(WebCore::WrapShapePolygon::WrapShapePolygon):
(WrapShapePolygon):

6:48 PM Changeset in webkit [123829] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebCore

Unreviewed, rolling out r123808.
http://trac.webkit.org/changeset/123808
https://bugs.webkit.org/show_bug.cgi?id=92443

Broke Apple Mac debug tests ASSERTION FAILED: !hasClients()
(Requested by msaboff_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-26

  • loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
(WebCore::CachedCSSStyleSheet::didAddClient):
(WebCore::CachedCSSStyleSheet::allClientsRemoved):
(WebCore::CachedCSSStyleSheet::decodedDataDeletionTimerFired):
(WebCore):

  • loader/cache/CachedCSSStyleSheet.h:

(CachedCSSStyleSheet):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::CachedImage):
(WebCore::CachedImage::decodedDataDeletionTimerFired):
(WebCore):
(WebCore::CachedImage::didAddClient):
(WebCore::CachedImage::allClientsRemoved):

  • loader/cache/CachedImage.h:

(CachedImage):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::didAddClient):
(WebCore::CachedResource::removeClient):

  • loader/cache/CachedResource.h:

(CachedResource):

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::CachedScript):
(WebCore::CachedScript::didAddClient):
(WebCore):
(WebCore::CachedScript::allClientsRemoved):
(WebCore::CachedScript::decodedDataDeletionTimerFired):

  • loader/cache/CachedScript.h:

(CachedScript):

6:41 PM Changeset in webkit [123828] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Remove some unreachable code in ClipboardChromium.cpp
https://bugs.webkit.org/show_bug.cgi?id=92427

Reviewed by Adam Barth.

convertURIListToURL does the same thing (implementation in ClipboardUtilitiesChromium.*).

No new tests, just deleting unused code.

  • platform/chromium/ClipboardChromium.cpp:

(WebCore::ClipboardChromium::getData):

6:28 PM Changeset in webkit [123827] by commit-queue@webkit.org
  • 15 edits
    2 adds in trunk

Implement undoscope attribute.
https://bugs.webkit.org/show_bug.cgi?id=88793

Patch by Sukolsak Sakshuwong <sukolsak@google.com> on 2012-07-26
Reviewed by Ryosuke Niwa.

Source/WebCore:

undoscope attribute support as specified at
http://dvcs.w3.org/hg/undomanager/raw-file/tip/undomanager.html

Test: editing/undomanager/undoscope-attribute.html

  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • dom/Document.cpp:

(WebCore::Document::~Document):

  • dom/Element.cpp:

(WebCore):
(WebCore::Element::undoScope):
(WebCore::Element::setUndoScope):
(WebCore::Element::undoManager):
(WebCore::Element::disconnectUndoManager):
(WebCore::Element::disconnectUndoManagersInSubtree):

  • dom/Element.h:

(Element):

  • dom/Element.idl:
  • dom/ElementRareData.h:

(ElementRareData):

  • editing/UndoManager.cpp:

(WebCore::UndoManager::disconnect):
(WebCore::UndoManager::transact):
(WebCore::UndoManager::undo):
(WebCore::UndoManager::redo):
(WebCore::UndoManager::clearUndo):
(WebCore):
(WebCore::UndoManager::clearRedo):
(WebCore::UndoManager::clearUndoRedo):
(WebCore::UndoManager::isConnected):

  • editing/UndoManager.h:

(WebCore):
(UndoManager):
(WebCore::UndoManager::length):

  • editing/UndoManager.idl:
  • html/HTMLAttributeNames.in:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseAttribute):
(WebCore::HTMLElement::setContentEditable):

LayoutTests:

  • editing/undomanager/undoscope-attribute-expected.txt: Added.
  • editing/undomanager/undoscope-attribute.html: Added.
6:27 PM Changeset in webkit [123826] by yosin@chromium.org
  • 14 edits in trunk

[Forms] Introduce runtime feature flags for input type datetime, datetimelocal, month, time, week
https://bugs.webkit.org/show_bug.cgi?id=92339

Reviewed by Kent Tamura.

Source/WebCore:

To detect compilation errors and test failure earlier, I would like
build and run tests for input type datetime, datetime-local, month,
time and week with runtime feature flags to avoid behavior changes
other than test shell.

This patch adds runtime features for input types, datetime, datetime-local,
month, time and week and integrates them into InputType::createInputTypeFactoryMap
to follow runtime feature flags.

At this time, these runtime features are enabled by default for all
ports define ENABLE_INPUT_TYPE_XXX except for Chromium port other than
Android. I'll remove these #if after I update Chromium browser for
disabling them for non-Android.

No new tests. Enabling disabled tests (fast/forms/datetime, fast/forms/dattimelocal,
fast/forms/month, fast/forms/time, fast/forms/week)

  • bindings/generic/RuntimeEnabledFeatures.cpp: Added initializations of

variables for runtime features of input types.

  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::inputTypeDateTimeEnabled): Added.
(WebCore::RuntimeEnabledFeatures::setInputTypeDateTimeEnabled): Added.
(WebCore::RuntimeEnabledFeatures::inputTypeDateTimeLocalEnabled): Added.
(WebCore::RuntimeEnabledFeatures::setInputTypeDateTimeLocalEnabled): Added.
(WebCore::RuntimeEnabledFeatures::inputTypeMonthEnabled): Added.
(WebCore::RuntimeEnabledFeatures::setInputTypeMonthEnabled): Added.
(WebCore::RuntimeEnabledFeatures::inputTypeTimeEnabled): Added.
(WebCore::RuntimeEnabledFeatures::setInputTypeTimeEnabled): Added.
(WebCore::RuntimeEnabledFeatures::inputTypeWeekEnabled): Added.
(WebCore::RuntimeEnabledFeatures::setInputTypeWeekEnabled): Added.

  • html/InputType.cpp:

(WebCore::createInputTypeFactoryMap): Register input types datetime,
datetime-local, month, time and week if corresponding runtime feature
flag is enabled.

  • html/InputType.h: Changed indentation to force building *InputType.cpp for

making Chromium-win bots to be happy.

Source/WebKit/chromium:

To detect compilation errors and test failure earlier, I would like
build and run tests for input type datetime, datetime-local, month,
time and week with runtime feature flags to avoid behavior changes
on chromium browser.

This patch adds query and change functions for runtime features of
input type datetime, datetime-local, month, time and week to WebRuntimeFeatures
class for exposing DRT and chromium browser expermental flags.

  • features.gypi: Turn on ENABLE_INPUT_TYPE_DATETIME, ENABLE_INPUT_TYPE_DATETIMELOCAL,

ENABLE_INPUT_TYPE_MONTH, ENABLE_INPUT_TYPE_TIME, and ENABLE_INPUT_TYPE_WEEK for all OS.

  • public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableInputTypeDateTime): Added.
(WebKit::WebRuntimeFeatures::isInputTypeDateTimeEnabled): Added.
(WebKit::WebRuntimeFeatures::enableInputTypeDateTimeLocal): Added.
(WebKit::WebRuntimeFeatures::isInputTypeDateTimeLocalEnabled): Added.
(WebKit::WebRuntimeFeatures::enableInputTypeMonth): Added.
(WebKit::WebRuntimeFeatures::isInputTypeMonthEnabled): Added.
(WebKit::WebRuntimeFeatures::enableInputTypeTime): Added.
(WebKit::WebRuntimeFeatures::isInputTypeTimeEnabled): Added.
(WebKit::WebRuntimeFeatures::enableInputTypeWeek): Added.
(WebKit::WebRuntimeFeatures::isInputTypeWeekEnabled): Added.

Tools:

This patch enables runtime features for input type datetime, datetime-local,
month, time and week for Chromium DRT.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell): Call enableInputType{DateTime,DateTimeLocal,Month,Time,Week}.

LayoutTests:

This patch enables tests for input type datetime, datetime-local,
month, time and week for Chromium ports.

  • platform/chromium/TestExpectations: Removed disabled directives for

input type datetime, datetime-local, month, time and week.

  • platform/chromium/fast/forms/datalist/input-list-expected.txt: Updated

expecations for input type datetime, datetime-local, month, time and week
to null for IDL list attribute. So far, these expectations specified
HTMLDataListElement for input type "text" as unsupported input types.

6:07 PM Changeset in webkit [123825] by wangxianzhu@chromium.org
  • 3 edits in trunk/Source/WebCore

[Chromium-Android] Don't overlay scrollbars in layout test mode
https://bugs.webkit.org/show_bug.cgi?id=92419

Reviewed by Adam Barth.

No new tests. This fixes failures of existing tests, e.g. css1/box_properties/border.html and many others.

  • platform/chromium/ScrollbarThemeChromiumAndroid.cpp:

(WebCore::ScrollbarThemeChromiumAndroid::usesOverlayScrollbars): Returns false in layout test mode.
(WebCore):
(WebCore::ScrollbarThemeChromiumAndroid::hasThumb): Returns false in layout test mode (to match pixel test expectations).

  • platform/chromium/ScrollbarThemeChromiumAndroid.h:

(ScrollbarThemeChromiumAndroid):

6:00 PM Changeset in webkit [123824] by bweinstein@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed rebaseline after r123790.

  • platform/mac/css3/filters/effect-brightness-clamping-expected.txt: Added.
  • platform/mac/css3/filters/effect-brightness-clamping-hw-expected.txt: Added.
5:52 PM Changeset in webkit [123823] by jpfau@apple.com
  • 6 edits
    1 add in trunk

Reloading substitute-data/alternate html string for unreachableURL will add an item to the back-forward-history for each reload
https://bugs.webkit.org/show_bug.cgi?id=84041

Reviewed by Brady Eidson.

Source/WebCore:

Previously, loadAlternateHTMLString:baseURL:forUnreachableURL: would insert a new history item, regardless of
the load type of the original frame load. This could cause navigation to a broken website to make back and
forward navigation difficult to use. This change ensures that a reload type makes it through all the way.

Added API test 'mac/BackForwardList.mm'.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::load): Prevent m_loadType from being overwritten early and check if it's a reload.

  • loader/HistoryController.cpp:

(WebCore::HistoryController::updateForCommit): Amend check when committing the provisional item for a reload.
(WebCore::HistoryController::isReloadTypeWithProvisionalItem): Check that a reload type has a provisional item.
(WebCore):

  • loader/HistoryController.h:

(HistoryController): Add prototype for isReloadTypeWithProvisionalItem.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/BackForwardList.mm: Added.

(-[BackForwardListTest webView:didFinishLoadForFrame:]):
(-[BackForwardListTest webView:didFailProvisionalLoadWithError:forFrame:]):
(TestWebKitAPI):
(TestWebKitAPI::TEST):

5:48 PM Changeset in webkit [123822] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

[Chromium] Regression: Global-buffer-overflow in WebCore::mediaControlElementType
https://bugs.webkit.org/show_bug.cgi?id=91333

Patch by Silvia Pfeiffer <silviapf@chromium.org> on 2012-07-26
Reviewed by Eric Seidel.

Source/WebCore:

MediaControlChromiumEnclosureElement now is a subclass of MediaControlElement, which
fixes the broken cast detected in the bug.
The displayType() of MediaControlChromiumEnclosureElement is set to 'MediaControlsPanel',
since the Panel element is sufficiently close in functionality to the Enclosure element.
By reusing this type, we do not need to introduce a Chromium-specific constant into
the generally used MediaControlElementType.

Test: accessibility/media-controls.html

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlChromiumEnclosureElement::MediaControlChromiumEnclosureElement):
Subclass MediaControlChromiumEnclosureElement from MediaControlElement.
(WebCore::MediaControlChromiumEnclosureElement::displayType):
Give the enclosure the MediaPanels type.

  • html/shadow/MediaControlRootElementChromium.h:

Add the MediaControlElement.h header file.
(MediaControlChromiumEnclosureElement):
Subclass MediaControlChromiumEnclosureElement from MediaControlElement.

LayoutTests:

This new test assures that the creation of a audio element with controls does not
break when accessibility is turned on.

  • accessibility/media-controls-expected.txt: Added.
  • accessibility/media-controls.html: Added.
5:41 PM Changeset in webkit [123821] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[GTK] avoid unneeded object creation when calling Vector::append
https://bugs.webkit.org/show_bug.cgi?id=88805

Patch by Arnaud Renevier <arno@renevier.net> on 2012-07-26
Reviewed by Alexey Proskuryakov.

No new tests: no change in functionality.

  • platform/gtk/ContextMenuGtk.cpp:

(WebCore::contextMenuItemVector):

  • platform/gtk/KeyBindingTranslator.h:

(WebCore::KeyBindingTranslator::addPendingEditorCommand):

5:34 PM Changeset in webkit [123820] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Initialize the Event Names' strings from read only memory
https://bugs.webkit.org/show_bug.cgi?id=92435

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-07-26
Reviewed by Anders Carlsson.

Similarily to r123689, we can initialize the event names' strings from memory without copying the data.
This saves us memory and initialization time.

  • dom/EventNames.cpp:

(WebCore):

5:25 PM Changeset in webkit [123819] by commit-queue@webkit.org
  • 20 edits
    2 adds in trunk

constructing TypedArray from another TypedArray is slow
https://bugs.webkit.org/show_bug.cgi?id=90838

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-07-26
Reviewed by Kenneth Russell.

PerformanceTests:

  • Bindings/typed-array-construct-from-same-type.html: Added.
  • Bindings/typed-array-construct-from-typed.html: Added.

Source/WebCore:

When constructing a typed array from an array like element, try to
determine if the argument is a typed array. If so, cast the argument
to a typed array, and read each element with .item() method. That
avoid reading the value as a JSValue, and speedups construction by
approximatively 3x (even 30x if TypedArrays are both the same type).

In order to achieve that, we use virtual getType method. We can use
this information to cast the TypedArray to the actual type, and then
read the values from the source.

Introduce constructArrayBufferViewWithTypedArrayArgument template
function which returns a new typed array if first argument is a typed
array, or 0 otherwise.

This patch also replaces previous is<Type>Array() calls with new
getType method.

  • bindings/js/JSArrayBufferViewHelper.h:

(WebCore::constructArrayBufferViewWithTypedArrayArgument):
(WebCore):
(WebCore::constructArrayBufferView):

  • bindings/v8/SerializedScriptValue.cpp:
  • html/canvas/DataView.h:

(DataView):
(WebCore::DataView::getType):

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::readPixels):
(WebCore::WebGLRenderingContext::validateTexFuncData):

  • page/Crypto.cpp:

Source/WTF:

Introduce virtual method getType on ArrayBufferView. It returns the actual
type of the view. This method replaces previous is<Type>Array() methods.

  • wtf/ArrayBufferView.h:
  • wtf/Float32Array.h:

(WTF::Float32Array::getType):
(Float32Array):

  • wtf/Float64Array.h:

(WTF::Float64Array::getType):
(Float64Array):

  • wtf/Int16Array.h:

(WTF::Int16Array::getType):
(Int16Array):

  • wtf/Int32Array.h:

(WTF::Int32Array::getType):
(Int32Array):

  • wtf/Int8Array.h:

(WTF::Int8Array::getType):
(Int8Array):

  • wtf/IntegralTypedArrayBase.h:
  • wtf/TypedArrayBase.h:

(TypedArrayBase):
(WTF::TypedArrayBase::item):

  • wtf/Uint16Array.h:

(WTF::Uint16Array::getType):
(Uint16Array):

  • wtf/Uint32Array.h:

(WTF::Uint32Array::getType):
(Uint32Array):

  • wtf/Uint8Array.h:

(WTF::Uint8Array::getType):
(Uint8Array):

  • wtf/Uint8ClampedArray.h:

(WTF::Uint8ClampedArray::getType):
(Uint8ClampedArray):

5:22 PM Changeset in webkit [123818] by commit-queue@webkit.org
  • 6 edits
    4 deletes in trunk

Added binding and updated chromium tests.

[CSS Filters] Add V8 binding for WebKitCSSFilterValue
https://bugs.webkit.org/show_bug.cgi?id=92391

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-07-26
Reviewed by Adam Barth.

Source/WebCore:

No new tests. This fixes test cases in:

platform/chromium/css3/filters/custom/custom-filter-property-computed-style-expected.txt
platform/chromium/css3/filters/custom/custom-filter-property-parsing-expected.txt
platform/chromium/css3/filters/filter-property-computed-style-expected.txt
platform/chromium/css3/filters/filter-property-parsing-expected.txt

  • bindings/v8/custom/V8CSSValueCustom.cpp:

(WebCore::toV8):

LayoutTests:

  • platform/chromium-linux/css3/filters/custom/custom-filter-property-computed-style-expected.txt:

Removed. The chromium-linux expectations are (and were) exactly the same as the chromium expectations.

  • platform/chromium-linux/css3/filters/custom/custom-filter-property-parsing-invalid-expected.txt:

Removed. Ditto.

  • platform/chromium-linux/css3/filters/custom/custom-filter-property-parsing-expected.txt:

Removed. Ditto.

  • platform/chromium/css3/filters/custom/custom-filter-property-computed-style-expected.txt:

Many test cases are now expected to pass instead of fail.

  • platform/chromium/css3/filters/custom/custom-filter-property-parsing-expected.txt:

Ditto.

  • platform/chromium/css3/filters/filter-property-computed-style-expected.txt:

Removed. We can use the platform-independent results now.

  • platform/chromium/css3/filters/filter-property-parsing-expected.txt:

Many test cases are now expected to pass instead of fail.

5:11 PM Changeset in webkit [123817] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JSObject::reallocateStorageIfNecessary is neither used nor defined
https://bugs.webkit.org/show_bug.cgi?id=92417

Reviewed by Mark Rowe.

  • runtime/JSObject.h:

(JSObject):

5:05 PM Changeset in webkit [123816] by nayankk@motorola.com
  • 6 edits in trunk

[WebGL] Initial size of canvas can be larger than MAX_VIEWPORT_DIMS.
https://bugs.webkit.org/show_bug.cgi?id=91976

Reviewed by Kenneth Russell.

From section 2.2 of the spec the WebGL implementation says initial size of
the canvas can be larger than MAX_VIEWPORT_DIMS. With the current WebGL
implementation, we get error when initial size if greater than MAX_VIEWPORT_DIMS.
This change limits the width and height of drawingbuffer to MAX_VIEWPORT_DIMS
when given initial size exceeds it.

Source/WebCore:

Added tests to LayoutTests/fast/canvas/webgl/drawingbuffer-test.html

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::WebGLRenderingContext):
(WebCore::WebGLRenderingContext::initializeNewContext):
(WebCore::WebGLRenderingContext::markContextChanged):

LayoutTests:

  • fast/canvas/webgl/drawingbuffer-test-expected.txt:
  • fast/canvas/webgl/drawingbuffer-test.html:
5:01 PM Changeset in webkit [123815] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove synchronous spellchecking code
https://bugs.webkit.org/show_bug.cgi?id=92415

Removing synchronous spellchecking code path.

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-07-26
Reviewed by Rob Buis.

Internally reviewed by Mike Fenton.

  • Api/WebPageClient.h:
  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::checkSpellingOfString):

4:55 PM Changeset in webkit [123814] by enne@google.com
  • 5 edits in trunk/Source/WebCore

[chromium] When computing surface content scale, use top level device scale
https://bugs.webkit.org/show_bug.cgi?id=92328

Reviewed by Kenneth Russell.

Previously, surface scale was calculated with layer->contentsScale(),
however this value is 1 for any layer that is not ContentLayerChromium
because of layer->needsContentsScale(). This would cause any surface
created with a non-content owner layer to look fuzzy on a high DPI
device. Fix by using the top level device scale.

Additionally, remove contentsScale from CCLayerImpl as it is no longer
used.

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsInternal):
(WebCore::CCLayerTreeHostCommon::calculateDrawTransforms):

4:27 PM Changeset in webkit [123813] by mhahnenberg@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

Allocate Structures in a separate part of the Heap
https://bugs.webkit.org/show_bug.cgi?id=92420

Reviewed by Filip Pizlo.

To fix our issue with destruction/finalization of Structures before their objects, we can move Structures to a separate
part of the Heap that will be swept after all other objects. This first patch will just be separating Structures
out into their own separate MarkedAllocator. Everything else will behave identically.

  • heap/Heap.h: New function to allocate Structures in the Heap.

(Heap):
(JSC):
(JSC::Heap::allocateStructure):

  • heap/MarkedAllocator.cpp: Pass whether or not we're allocated Structures to the MarkedBlock.

(JSC::MarkedAllocator::allocateBlock):

  • heap/MarkedAllocator.h: Add tracking for whether or not we're allocating only Structures.

(JSC::MarkedAllocator::onlyContainsStructures):
(MarkedAllocator):
(JSC::MarkedAllocator::MarkedAllocator):
(JSC::MarkedAllocator::init):

  • heap/MarkedBlock.cpp: Add tracking for whether or not we're allocating only Structures. We need this to be able to

distinguish the various MarkedBlock types in MarkedSpace::allocatorFor(MarkedBlock*).
(JSC::MarkedBlock::create):
(JSC::MarkedBlock::MarkedBlock):

  • heap/MarkedBlock.h:

(MarkedBlock):
(JSC::MarkedBlock::onlyContainsStructures):
(JSC):

  • heap/MarkedSpace.cpp: Include the new Structure allocator in all the places that all the other allocators are used/modified.

(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::resetAllocators):
(JSC::MarkedSpace::canonicalizeCellLivenessData):
(JSC::MarkedSpace::isPagedOut):

  • heap/MarkedSpace.h: Add new MarkedAllocator just for Structures.

(MarkedSpace):
(JSC::MarkedSpace::allocatorFor):
(JSC::MarkedSpace::allocateStructure):
(JSC):
(JSC::MarkedSpace::forEachBlock):

  • runtime/Structure.h: Move all of the functions that call allocateCell<Structure> down below the explicit template specialization

for allocateCell<Structure>. The new inline specialization for allocateCell directly calls the allocateStructure() function in the
Heap.
(Structure):
(JSC::Structure):
(JSC):
(JSC::Structure::create):
(JSC::Structure::createStructure):

4:10 PM Changeset in webkit [123812] by atwilson@chromium.org
  • 1 edit
    1 move
    2 adds in trunk/LayoutTests

Unreviewed chromium expectations update for table-row-outline-paint.html from r123793.

  • platform/chromium-mac/fast/table/table-row-outline-paint-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-outline-paint-expected.png: Added.
  • platform/chromium/fast/table/table-row-outline-paint-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/table/table-row-outline-paint-expected.txt.
4:08 PM Changeset in webkit [123811] by andersca@apple.com
  • 15 edits in trunk/Source/WebCore

HTMLAppletElement should inherit from HTMLPlugInImageElement
https://bugs.webkit.org/show_bug.cgi?id=92320

Reviewed by Eric Seidel.

In order to simplify the class hierarchy and eventually merge HTMLPlugInImageElement and HMTLPlugInElement,
make HTMLAppletElement inherit from HTMLPlugInImageElement. While this does mean that HTMLAppletElement will grow by
a couple of words, in practice it won't matter.

Also, make RenderApplet inherit from RenderEmbeddedObject and move the plug-in instantiation to HTMLAppletElement which matches
both HTMLEmbedElement and HTMLObjectElement.

  • html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::HTMLAppletElement):
(WebCore::HTMLAppletElement::create):
(WebCore::HTMLAppletElement::parseAttribute):
(WebCore::HTMLAppletElement::rendererIsNeeded):
(WebCore::HTMLAppletElement::createRenderer):
(WebCore):
(WebCore::HTMLAppletElement::renderWidgetForJSBindings):
(WebCore::HTMLAppletElement::updateWidget):

  • html/HTMLAppletElement.h:

(HTMLAppletElement):

  • html/HTMLTagNames.in:
  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::createJavaAppletWidget):

  • loader/SubframeLoader.h:

(SubframeLoader):

  • page/FrameView.cpp:

(WebCore::FrameView::updateWidget):

  • rendering/RenderApplet.cpp:

(WebCore::RenderApplet::RenderApplet):

  • rendering/RenderApplet.h:

(RenderApplet):

  • rendering/RenderEmbeddedObject.h:

(WebCore::toRenderEmbeddedObject):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::shouldBeNormalFlowOnly):
(WebCore::RenderLayer::shouldBeSelfPaintingLayer):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForPlugin):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::setStyle):

  • rendering/RenderObject.h:
4:06 PM Changeset in webkit [123810] by commit-queue@webkit.org
  • 19 edits
    4 deletes in trunk

Unreviewed, rolling out r123799.
http://trac.webkit.org/changeset/123799
https://bugs.webkit.org/show_bug.cgi?id=92431

broke the Apple Mac build (Requested by bweinstein on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-26

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • dom/EventNames.h:

(WebCore):

  • dom/GestureEvent.cpp: Removed.
  • dom/GestureEvent.h: Removed.
  • dom/Node.cpp:
  • dom/Node.h:

(WebCore):
(Node):

  • page/EventHandler.cpp:

(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleGestureEvent):

  • page/EventHandler.h:

Source/WebKit/chromium:

  • src/WebInputEventConversion.cpp:

(WebKit):

  • src/WebInputEventConversion.h:

(WebKit):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::handleEvent):

  • src/WebPluginContainerImpl.h:

(WebPluginContainerImpl):

Tools:

  • DumpRenderTree/chromium/TestWebPlugin.cpp:
  • DumpRenderTree/chromium/TestWebPlugin.h:

(TestWebPlugin::acceptsInputEvents):
(TestWebPlugin::handleInputEvent):

LayoutTests:

  • platform/chromium/plugins/gesture-events-expected.txt: Removed.
  • platform/chromium/plugins/gesture-events.html: Removed.
4:05 PM Changeset in webkit [123809] by commit-queue@webkit.org
  • 11 edits in trunk/Source

[BlackBerry] Support async spellcheck for the blackberry port
https://bugs.webkit.org/show_bug.cgi?id=92160

Source/WebCore:

Set USE_UNIFIED_TEXT_CHECKING for PLATFORM(BLACKBERRY) to use the
asynchronous spellchecking code path.

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-07-26
Reviewed by Rob Buis.

Internally reviewed by Mike Fenton.

  • platform/text/TextChecking.h:

(WebCore):

Source/WebKit/blackberry:

PR124517
Implementing support for async spellcheck.

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-07-26
Reviewed by Rob Buis.

Internally reviewed by Mike Fenton.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::spellCheckingRequestCancelled):
(WebKit):
(BlackBerry::WebKit::WebPage::spellCheckingRequestProcessed):
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):

  • Api/WebPage.h:
  • Api/WebSettings.cpp:

(WebKit):
(BlackBerry::WebKit::WebSettings::standardSettings):
(BlackBerry::WebKit::WebSettings::isAsynchronousSpellCheckingEnabled):
(BlackBerry::WebKit::WebSettings::setAsynchronousSpellCheckingEnabled):

  • Api/WebSettings.h:
  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore):
(WebCore::EditorClientBlackBerry::requestCheckingOfString):
(WebCore::EditorClientBlackBerry::checkTextOfParagraph):

  • WebCoreSupport/EditorClientBlackBerry.h:

(EditorClientBlackBerry):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::requestCheckingOfString):
(BlackBerry::WebKit::InputHandler::convertTransactionIdToSequenceId):
(WebKit):
(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
(BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
(BlackBerry::WebKit::InputHandler::getSpellChecker):

  • WebKitSupport/InputHandler.h:

(WebCore):
(InputHandler):

4:03 PM Changeset in webkit [123808] by kseo@webkit.org
  • 9 edits in trunk/Source/WebCore

Gather the duplicated timer code into CachedResource.
https://bugs.webkit.org/show_bug.cgi?id=92332

Patch by Huang Dongsung <luxtella@company100.net> on 2012-07-26
Reviewed by Nate Chapin.

Internal review by Jae Hyun Park.

When all clients are removed, CachedImage, CachedScript and CachedCSSStyleSheet
start the timer to destroy decoded data. Those three classes have their own
timer.
Changed CachedCSSStyleSheet::didAddClient to call super class method in order to
stop the timer. This change does not have any side effect because
CachedResource::didAddClient only stops the timer in this case.

No new tests - no new testable functionality.

  • loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
(WebCore::CachedCSSStyleSheet::didAddClient):

  • loader/cache/CachedCSSStyleSheet.h:

(CachedCSSStyleSheet):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::CachedImage):
(WebCore::CachedImage::didAddClient):
(WebCore::CachedImage::allClientsRemoved):

  • loader/cache/CachedImage.h:

(CachedImage):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::didAddClient):
(WebCore::CachedResource::removeClient):
(WebCore::CachedResource::destroyDecodedDataIfNeeded):
(WebCore):
(WebCore::CachedResource::decodedDataDeletionTimerFired):

  • loader/cache/CachedResource.h:

(CachedResource):

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::CachedScript):

  • loader/cache/CachedScript.h:

(CachedScript):

4:01 PM Changeset in webkit [123807] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JSArray has methods that are neither used nor defined
https://bugs.webkit.org/show_bug.cgi?id=92416

Reviewed by Simon Fraser.

  • runtime/JSArray.h:

(JSArray):

4:00 PM Changeset in webkit [123806] by piman@chromium.org
  • 2 edits
    6 adds in trunk/LayoutTests

Unreviewed, rebaseline for tests introduced in r123790

  • platform/chromium-mac/css3/filters/effect-brightness-clamping-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-brightness-clamping-expected.txt: Added.
  • platform/chromium-mac/css3/filters/effect-brightness-clamping-hw-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-brightness-clamping-hw-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-brightness-clamping-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-brightness-clamping-hw-expected.png: Added.
  • platform/chromium/TestExpectations:
4:00 PM Changeset in webkit [123805] by dpranke@chromium.org
  • 2 edits in trunk/Tools

nrwt: pass --verbose twice on the bots to ensure getting the debug output for now
https://bugs.webkit.org/show_bug.cgi?id=92172

Reviewed by Tony Chang.

Right now new-run-webkit-tests --verbose prints out too much
information (it's like --verbose + debugging). I plan to fix
this in bug 88702, and also clean up and simplify all of the
--print options, but in preparation for these changes I need to
pass --verbose twice to get the same level of output
temporarily (for compatibility).

  • Scripts/run-webkit-tests:
3:41 PM Changeset in webkit [123804] by benjamin@webkit.org
  • 4 edits in trunk/Source/WebCore

Use the constant count of Tags/Attributes names instead of getting the size when obtaining the tags/attributes
https://bugs.webkit.org/show_bug.cgi?id=92411

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-07-26
Reviewed by Julien Chaffraix.

Since r123582, the number of tags and attributes per "namespace" is exposed in a constant in the header file.
This makes it possible to access this value through two ways:
1) The constant.
2) The first parameter of the tags/attributes getter function.

Having two ways to access the value is error prone. This patches changes the code to have all accesses done
through the constant.

  • dom/make_names.pl:

(printNamesHeaderFile):
(printNamesCppFile):
Change the code generator to not provide the size in the getter function.

  • html/HTMLObjectElement.cpp:

(WebCore::isRecognizedTagName):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::adjustSVGTagNameCase):
(WebCore):
(WebCore::adjustAttributes):
(WebCore::adjustSVGAttributes):
(WebCore::adjustMathMLAttributes):
(WebCore::adjustForeignAttributes):

3:40 PM Changeset in webkit [123803] by igor.o@sisa.samsung.com
  • 2 edits
    5 deletes in trunk/LayoutTests

[Qt] Reskip fast/table WK2 added results
https://bugs.webkit.org/show_bug.cgi?id=91621

Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader>
Reviewed by Noam Rosenthal.

This patch reverts the added WK2 layout test results from r123229 "[Qt]
Added/updated missing fast/table results after rebaseline". As discussed with
Caio, these expectations are actually caused by an erroneous input-text and
text-area default size diff between WK1 and WK2 (handled in bug 91990). These
tests were reskipped and reassigned to proper bugs.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0-wk2/fast/table/colspanMinWidth-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/table/colspanMinWidth-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/table/spanOverlapRepaint-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/table/text-field-baseline-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/table/text-field-baseline-expected.txt: Removed.
3:31 PM Changeset in webkit [123802] by annacc@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Removing http/tests/media/media-source/video-media-source-add-and-remove-ids.html from TestExpectations

Unreviewed gardening.

Recent chromium patch fixes this problem:
http://src.chromium.org/viewvc/chrome?view=rev&revision=148473

  • platform/chromium/TestExpectations:
3:22 PM Changeset in webkit [123801] by igor.o@sisa.samsung.com
  • 2 edits
    5 deletes in trunk/LayoutTests

[Qt] Reskip fast/text WK2 added results
https://bugs.webkit.org/show_bug.cgi?id=91570

Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader>
Unreviewed gardening.

This patch reverts the added WK2 layout test results from r123144 "[Qt]
Added/updated missing fast/text results after rebaseline". As discussed with
Caio, these expectations are actually caused by an erroneous input-text and
text-area default size diff between WK1 and WK2 (handled in bug 91990). These
tests were reskipped and reassigned to proper bugs.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0-wk2/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/text/textIteratorNilRenderer-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/text/textIteratorNilRenderer-expected.txt: Removed.
  • platform/qt-5.0/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png: Removed.
3:15 PM Changeset in webkit [123800] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

Support constructor-type static readonly attribute for CodeGenerator.
https://bugs.webkit.org/show_bug.cgi?id=92413.

Patch by Chang Shu <cshu@webkit.org> on 2012-07-26
Reviewed by Adam Barth.

Added support for constructor-type static readonly attribute for CodeGenerator.
This is achieved by putting the attribute entry in the table where static properties
belong to but leave the implementation same as a non-static constructor-type attribute.

Tested by running run-bindings-tests.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::jsTestInterfaceConstructorSupplementalStaticReadOnlyAttr):
(WebCore::jsTestInterfaceConstructorSupplementalStaticAttr):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):
(WebCore::jsTestObjConstructorStaticReadOnlyLongAttr):
(WebCore::jsTestObjConstructorStaticStringAttr):
(WebCore::jsTestObjConstructorTestSubObj):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

3:10 PM Changeset in webkit [123799] by commit-queue@webkit.org
  • 19 edits
    4 adds in trunk

Propagate gesture events to plugins.
https://bugs.webkit.org/show_bug.cgi?id=92281

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-07-26
Reviewed by Adam Barth.

Source/WebCore:

Propagate gesture events to plugins. This change does not expose the gesture events
to JavaScript, since there is no spec for that at the moment. Exposing gesture events
to JavaScript will be done separately, once there is a spec for it.

Test: platform/chromium/plugins/gesture-events.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • dom/EventNames.h:

(WebCore):
(WebCore::EventNames::isGestureEventType):
(EventNames):

  • dom/GestureEvent.cpp: Added.

(WebCore):
(WebCore::GestureEvent::create):
(WebCore::GestureEvent::initGestureEvent):
(WebCore::GestureEvent::interfaceName):
(WebCore::GestureEvent::GestureEvent):
(WebCore::GestureEventDispatchMediator::GestureEventDispatchMediator):
(WebCore::GestureEventDispatchMediator::event):
(WebCore::GestureEventDispatchMediator::dispatchEvent):

  • dom/GestureEvent.h: Added.

(WebCore):
(GestureEvent):
(WebCore::GestureEvent::~GestureEvent):
(WebCore::GestureEvent::deltaX):
(WebCore::GestureEvent::deltaY):
(WebCore::GestureEvent::GestureEvent):
(GestureEventDispatchMediator):
(WebCore::GestureEventDispatchMediator::create):

  • dom/Node.cpp:

(WebCore):
(WebCore::Node::dispatchGestureEvent):

  • dom/Node.h:

(WebCore):
(Node):

  • page/EventHandler.cpp:

(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleGestureEvent):

  • page/EventHandler.h:

Source/WebKit/chromium:

Propagate gesture events to plugins.

  • src/WebInputEventConversion.cpp:

(WebKit):
(WebKit::WebGestureEventBuilder::WebGestureEventBuilder):

  • src/WebInputEventConversion.h:

(WebCore):
(WebKit):
(WebGestureEventBuilder):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::handleEvent):

  • src/WebPluginContainerImpl.h:

(WebCore):
(WebPluginContainerImpl):

Tools:

Update TestWebPlugin to receive events, and output logs for the events.

  • DumpRenderTree/chromium/TestWebPlugin.cpp:

(TestWebPlugin::handleInputEvent):

  • DumpRenderTree/chromium/TestWebPlugin.h:

(TestWebPlugin::acceptsInputEvents):
(TestWebPlugin):

LayoutTests:

Added a layout test to show that the plugins receive the gesture events correctly.

  • platform/chromium/plugins/gesture-events-expected.txt: Added.
  • platform/chromium/plugins/gesture-events.html: Added.
3:07 PM Changeset in webkit [123798] by gavinp@chromium.org
  • 3 edits
    3 adds in trunk

Guard Prerenderer against inserting prerenders into detached documents.
https://bugs.webkit.org/show_bug.cgi?id=92401

Reviewed by Adam Barth.

Source/WebCore:

If the document is detached, we should not launch a prerender.

Test: fast/dom/HTMLLinkElement/prerender-insert-after-stop.html

  • loader/Prerenderer.cpp:

(WebCore::Prerenderer::render):

LayoutTests:

If the document is detached, we should just not launch a prerender.

  • fast/dom/HTMLLinkElement/prerender-insert-after-stop-expected.txt: Added.
  • fast/dom/HTMLLinkElement/prerender-insert-after-stop.html: Added.
  • fast/dom/HTMLLinkElement/resources/empty2.html: Added.
3:03 PM Changeset in webkit [123797] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Improve the logs in Selection Handler.
https://bugs.webkit.org/show_bug.cgi?id=92405

Reviewed by Rob Buis.

Clean up selection logging, fix priority and style
of helper function.

Reviewed Internally by Nima Ghanavatian.

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::cancelSelection):
(BlackBerry::WebKit::SelectionHandler::shouldUpdateSelectionOrCaretForPoint):
(BlackBerry::WebKit::SelectionHandler::setCaretPosition):
(BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
(BlackBerry::WebKit::SelectionHandler::setSelection):
(BlackBerry::WebKit::SelectionHandler::selectObject):
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
(BlackBerry::WebKit::SelectionHandler::caretPositionChanged):

2:46 PM Changeset in webkit [123796] by zeno.albisser@nokia.com
  • 6 edits in trunk/Source

Unreviewed Qt buildfix after r123786.

Qt-minimal builds with ENABLE_REQUEST_ANIMATION_FRAME=0.
Therefore adding #ifdefs to allow for that configuration.

Source/WebKit/qt:

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore):

  • WebCoreSupport/ChromeClientQt.h:

(ChromeClientQt):

Source/WebKit2:

  • WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.cpp:

(WebKit):

  • WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

2:37 PM Changeset in webkit [123795] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium expectations change to fix lint err.

  • platform/chromium/TestExpectations:
2:23 PM Changeset in webkit [123794] by commit-queue@webkit.org
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r123525.
http://trac.webkit.org/changeset/123525
https://bugs.webkit.org/show_bug.cgi?id=92421

it needed to be rolled out after r123779 too (Requested by
jchaffraix on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-26

Source/WebCore:

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::insertChildNode):

LayoutTests:

  • fast/table/crash-table-section-layoutRows-expected.txt: Removed.
  • fast/table/crash-table-section-layoutRows.html: Removed.
2:18 PM Changeset in webkit [123793] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Outline is always painted on the first table row regardless of the row it's set on
https://bugs.webkit.org/show_bug.cgi?id=92389

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-07-26
Reviewed by Eric Seidel.

Source/WebCore:

The outlines of all the rows are drawn on the row instead of their respective rows.
The paint offset for the outlines does not take the row location into account.

Test: fast/table/table-row-outline-paint.html

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::paintOutlineForRowIfNeeded):
The row's location is taken into account for calculating the correct paint offset
for its outline.

LayoutTests:

  • fast/table/table-row-outline-paint.html: Added.
  • platform/chromium-linux/fast/table/table-row-outline-paint-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-outline-paint-expected.txt: Added. Paint phase issue.
2:16 PM Changeset in webkit [123792] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium expectations change to mark inspector tests as SLOW.

  • platform/chromium/TestExpectations:
2:00 PM Changeset in webkit [123791] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-536.26-branch

Merged r116325. <rdar://problem/11942095>

1:54 PM Changeset in webkit [123790] by piman@chromium.org
  • 3 edits
    6 adds in trunk

[chromium] Combine color matrix filters and apply them in a single pass.
https://bugs.webkit.org/show_bug.cgi?id=92059

Reviewed by Stephen White.

Sequential color matrix filters can easily be combined, by simply
multiplying the color matrices and applying it in a single pass. This
helps dramatically with performance (bandwidth savings by avoiding extra
copy & clear, also saves fragment shader processing).

Covered by css3/filters layout tests, added effect-brightness-clamping
and effect-brightness-clamping-hw.

  • platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:

(WebCore::CCRenderSurfaceFilters::apply):

1:52 PM Changeset in webkit [123789] by eae@chromium.org
  • 5 edits
    2 adds
    2 deletes in trunk/LayoutTests

Unreviewed chromium mac/win rebaseline post r123782.

  • css2.1/t080301-c411-vt-mrgn-00-b-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
  • platform/efl/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt: Removed.
  • platform/gtk/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt: Removed.
1:23 PM Changeset in webkit [123788] by rniwa@webkit.org
  • 8 edits in trunk

Href attribute with javascript protocol is stripped when content is pasted into a XML doucment
https://bugs.webkit.org/show_bug.cgi?id=92310

Reviewed by Adam Barth.

Source/WebCore:

The bug was caused by setAttributeNS's stripping attributes for which isAttributeToRemove
return true instead of setting an empty string. Changing this in setAttributeNS is problematic
because it will trigger a logic, in HTMLAnchorElement for example, to resolve the URL.

Fixed the bug by making XML parsers call parserSetAttributes instead of setAttributeNS.
After this patch, handleNamespaceAttributes and handleElementAttributes simply fills up a Vector
with which startElementNs (or parseStartElement in Qt) calls parserSetAttributes.

  • dom/Element.cpp:

(WebCore::Element::parserSetAttributes): Sets emptyAtom instead of nullAtom as nullAtom can be
turned into "null".
(WebCore::Element::parseAttributeName): Extracted from setAttributeNS.
(WebCore::Element::setAttributeNS): No longer takes FragmentScriptingPermission.

  • dom/Element.h:

(Element):

  • editing/markup.cpp:

(WebCore::completeURLs): Don't resolve URLs when it's empty since empty attribute has a canonical
meaning in some cases. e.g. <frame src=""></iframe>

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::handleNamespaceAttributes): Renamed from handleElementNamespaces. Call
parserSetAttributes even when exiting early to be maintain the same behavior.
(WebCore::handleElementAttributes):
(WebCore::XMLDocumentParser::startElementNs):

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::handleNamespaceAttributes): Use XMLNSNames::xmlnsNamespaceURI. Call parserSetAttributes
even when exiting early to be maintain the same behavior.
(WebCore::handleElementAttributes):
(WebCore::XMLDocumentParser::parseStartElement):

LayoutTests:

Rebaseline a test that catches this bug.

  • editing/pasteboard/paste-noscript-xhtml-expected.txt:
1:19 PM Changeset in webkit [123787] by mifenton@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Add timing logs to SelectionHandler.
https://bugs.webkit.org/show_bug.cgi?id=92404

Reviewed by Rob Buis.

Add selection timing logs.

Reviewed Internally by Nima Ghanavatian.

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::setSelection):
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):

  • WebKitSupport/SelectionHandler.h:

(SelectionHandler):

1:15 PM Changeset in webkit [123786] by zeno.albisser@nokia.com
  • 11 edits in trunk/Source

[Qt] requestAnimationFrame should only trigger when a new frame can be displayed.
https://bugs.webkit.org/show_bug.cgi?id=88638

Source/WebKit/qt:

Disable REQUEST_ANIMATION_FRAME_TIMER for the Qt port and tie
the servicing of scripted animations to the renderNextFrame call for WK2.
For WK1 we rely on the RefreshAnimation that is based on QAbstractAnimation.

Reviewed by Jocelyn Turcotte.

  • WebCoreSupport/ChromeClientQt.cpp:

(RefreshAnimation):

Add a RefreshAnimation that is based on QAbstractAnimation
and drives the servicing of the scripted animations for WK1.

(WebCore::RefreshAnimation::RefreshAnimation):
(WebCore::RefreshAnimation::duration):
(WebCore::RefreshAnimation::scheduleAnimation):

Set m_animationScheduled to true and start the animation
timer in case it is not running yet.

(WebCore::RefreshAnimation::updateCurrentTime):

Call serviceScriptedAnimations if m_animationScheduled is true.
If this is not the case, the animation timer can be stopped,
because no animation needs to be scheduled anymore.

(WebCore):
(WebCore::ChromeClientQt::scheduleAnimation):

Create and start the RefreshAnimation instance with the
first call to scheduleAnimation.

  • WebCoreSupport/ChromeClientQt.h:

(WebCore):
(ChromeClientQt):

Source/WebKit2:

Disable REQUEST_ANIMATION_FRAME_TIMER for the Qt port and tie
the servicing of scripted animations to layer syncing for WK2.
For WK1 we rely on the RefreshAnimation that is based on QAbstractAnimation.

Reviewed by Jocelyn Turcotte.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit):
(WebKit::WebChromeClient::scheduleAnimation):

  • WebProcess/WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

  • WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::performScheduledLayerFlush):
(WebKit::LayerTreeCoordinator::scheduleAnimation):
(WebKit):

  • WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

  • WebProcess/WebPage/LayerTreeHost.h:

(LayerTreeHost):

Source/WTF:

Disable REQUEST_ANIMATION_FRAME_TIMER for the Qt port and tie
the servicing of scripted animations to layer syncing for WK2.
For WK1 we rely on the RefreshAnimation that is based on QAbstractAnimation.

Reviewed by Jocelyn Turcotte.

  • wtf/Platform.h:
1:10 PM Changeset in webkit [123785] by mitz@apple.com
  • 3 edits
    2 adds in trunk

<svg> element with no intrinsic size and max-width gets sized incorrectly
https://bugs.webkit.org/show_bug.cgi?id=92410

Reviewed by Dean Jackson.

Source/WebCore:

Test: svg/css/max-width-2.html

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeReplacedLogicalWidth): The rule for computing the width for
elements whose computed width and height are both auto and which have no intrinsic size, but
have an intrinsic ratio was applied only to elements with a content renderer (such as <img>
with an SVG source). Removed the requirement to have a content renderer, so that it will
apply to all elements including <svg>.

LayoutTests:

  • svg/css/max-width-2-expected.html: Added.
  • svg/css/max-width-2.html: Added.
1:02 PM Changeset in webkit [123784] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] InputHandler failure logs should be logAlways and critical.
https://bugs.webkit.org/show_bug.cgi?id=92403

Reviewed by Rob Buis.

Update Log level for failures and fix mask in log.

Reviewed Internally by Nima Ghanavatian.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::convertStringToWchar):
(BlackBerry::WebKit::convertStringToWcharVector):
(BlackBerry::WebKit::convertSpannableStringToString):
(BlackBerry::WebKit::InputHandler::spannableTextInRange):
(BlackBerry::WebKit::InputHandler::setTextAttributes):

12:56 PM Changeset in webkit [123783] by tony@chromium.org
  • 7 edits in trunk

Regression: r123696 made css3/flexbox tests failing
https://bugs.webkit.org/show_bug.cgi?id=92352

Reviewed by Levi Weintraub.

Source/WebCore:

Use roundedLayoutUnit so ports without subpixel layout still pass existing tests.

Covered by css3/flexbox/flex-algorithm-min-max.html which should pass again.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::resolveFlexibleLengths):

LayoutTests:

Skip css3/flexbox/flex-rounding.html on ports that don't enable subpixel layout.

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
12:54 PM Changeset in webkit [123782] by eae@chromium.org
  • 20 edits
    2 adds in trunk

Source/WebCore: Contained div with right 0 sometimes overlaps parent div
https://bugs.webkit.org/show_bug.cgi?id=91521

Reviewed by Levi Weintraub.

Due to unnecessary rounding in clientLogicalWidth and clientLogicalHeight
we lost precision when computing the width and position of render boxes.
Change clientLogicalWidth/Height to return values with subpixel precision
to avoid this.

Test: fast/sub-pixel/position-right-aligns-with-container.html

  • rendering/RenderBox.h:

(WebCore::RenderBox::clientLogicalWidth):
(WebCore::RenderBox::clientLogicalHeight):
Remove unnecessary rounding.

Source/WebKit2: Add a ChromeClient method to send diagnostic logging messages from WebCore to the client.
https://bugs.webkit.org/show_bug.cgi?id=92340

Reviewed by Anders Carlsson.

Pipe the ChromeClient logDiagnosticMessage() function through WebKit2 to a new bundle class
InjectedBundlePageDiagnosticLoggingClient, to be implemented by the client.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageSetDiagnosticLoggingClient): Added.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp: Added.

(WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessage):

  • WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.h: Added.

(InjectedBundlePageDiagnosticLoggingClient):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::logDiagnosticMessage):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::initializeInjectedBundleDiagnosticLoggingClient):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::injectedBundleDiagnosticLoggingClient):

Add a convenience class to retrieve the diagnostic message keys:

  • WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp: Added.

(WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessage):

  • WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.h: Added.

(InjectedBundlePageDiagnosticLoggingClient):

Add the InjectedBundlePageDiagnosticLoggingClient.cpp,h files.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • win/WebKit2.vcproj:
  • WebKit2.xcodeproj/project.pbxproj:

Tools: [nrwt] get rid of --skip-pixel-test-if-no-baseline
https://bugs.webkit.org/show_bug.cgi?id=92377

Reviewed by Adam Barth.

Remove the option and all code paths that handled it.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.should_run_as_pixel_test):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(_set_up_derived_options):
(parse_args):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_repeat_each):

LayoutTests: Contained div with right 0 sometimes overlaps parent div
https://bugs.webkit.org/show_bug.cgi?id=91521

Reviewed by Levi Weintraub.

Add test for elements positioned based on the right edge and update two
existing tests that where affected by the rounding.

  • fast/sub-pixel/position-right-aligns-with-container-expected.html: Added.
  • fast/sub-pixel/position-right-aligns-with-container.html: Added.
  • platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-win/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/mac-lion/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/mac/Skipped:
  • platform/qt-4.8/Skipped:
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt/Skipped:
  • platform/win-wk2/Skipped:
  • platform/win-xp/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:

Mark new subpixel test as skipped on platforms that do not enable
subpixel layout.

12:10 PM Changeset in webkit [123781] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Build broken when svg is disabled.
https://bugs.webkit.org/show_bug.cgi?id=92393.

Patch by Chang Shu <cshu@webkit.org> on 2012-07-26
Reviewed by Laszlo Gombos.

Need to surpress unused parameters warning.

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::buildReferenceFilter):

12:01 PM Changeset in webkit [123780] by jer.noble@apple.com
  • 4 edits in trunk/Source/WebCore

Add diagnostic messages when media and plugins load or fail to load.
https://bugs.webkit.org/show_bug.cgi?id=92341

Reviewed by Anders Carlsson.

Send diagnostic messages when a media or plugin element loads or fails to load. Include in
the trace the media engine description, error code, or plugin mime type.

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::updateWidget): Send a diagnostic message.

  • html/HTMLMediaElement.cpp:

(WebCore::stringForNetworkState): Added convenience function to stringify network states.
(WebCore::HTMLMediaElement::mediaLoadingFailed): Send a diagnostic message.
(WebCore::HTMLMediaElement::setReadyState): Send a diagnostic message.

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateWidget): Send a diagnostic message.

11:50 AM Changeset in webkit [123779] by commit-queue@webkit.org
  • 13 edits
    1 move
    2 adds
    12 deletes in trunk

Unreviewed, rolling out r123159, r123165, r123168, r123492,
and r123650.
http://trac.webkit.org/changeset/123159
http://trac.webkit.org/changeset/123165
http://trac.webkit.org/changeset/123168
http://trac.webkit.org/changeset/123492
http://trac.webkit.org/changeset/123650
https://bugs.webkit.org/show_bug.cgi?id=92406

allowing inline-table anonymous wrappers is a bad idea due to
tons of corner cases that should be properly handled
(Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-26

Source/WebCore:

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::addChildIgnoringContinuation):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::createAnonymousWithParentRenderer):

LayoutTests:

  • css2.1/20110323/inline-table-002b-expected.htm: Removed.
  • css2.1/20110323/inline-table-002b.html: Removed.
  • fast/dynamic/insert-before-table-part-in-continuation-expected.txt: Removed.
  • fast/table/inline-block-generates-table-wrapper-expected.html: Removed.
  • fast/table/inline-block-generates-table-wrapper.html: Removed.
  • fast/table/inline-table-in-continuation-expected.html: Removed.
  • fast/table/inline-table-in-continuation.html: Removed.
  • fast/table/inline-table-with-caption-expected.html: Removed.
  • fast/table/inline-table-with-caption.html: Removed.
  • platform/chromium-linux/fast/dynamic/insert-before-table-part-in-continuation-expected.png:
  • platform/chromium-mac-snowleopard/fast/dynamic/insert-before-table-part-in-continuation-expected.png:
  • platform/chromium-mac/fast/dynamic/insert-before-table-part-in-continuation-expected.png:
  • platform/chromium-win/fast/dynamic/insert-before-table-part-in-continuation-expected.png:
  • platform/chromium-win/fast/dynamic/insert-before-table-part-in-continuation-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug3037-1-expected.txt:
  • platform/efl/fast/dynamic/insert-before-table-part-in-continuation-expected.txt: Added.
  • platform/efl/tables/mozilla/bugs/bug3037-1-expected.txt: Renamed from LayoutTests/tables/mozilla/bugs/bug3037-1-expected.txt.
  • platform/gtk/fast/dynamic/insert-before-table-part-in-continuation-expected.txt: Added.
  • platform/gtk/tables/mozilla/bugs/bug3037-1-expected.txt:
  • platform/mac-wk2/fast/dynamic/insert-before-table-part-in-continuation-expected.txt: Removed.
  • platform/mac-wk2/mathml/msub-anonymous-child-render-crash-expected.txt: Removed.
  • platform/mac-wk2/tables/mozilla/bugs/bug3037-1-expected.txt: Removed.
  • platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug3037-1-expected.txt:
11:45 AM Changeset in webkit [123778] by jer.noble@apple.com
  • 20 edits
    4 adds in trunk/Source

Add a ChromeClient method to send diagnostic logging messages from WebCore to the client.
https://bugs.webkit.org/show_bug.cgi?id=92340

Reviewed by Anders Carlsson.

Source/WebCore:

Add a new ChromeClient menthod, to be implemented by WebKit and WebKit2, which sends
a diagnostic logging message up to the client.

  • page/ChromeClient.h:

(WebCore::ChromeClient::logDiagnosticMessage):

  • page/ChromeClient.h:

(WebCore::ChromeClient::logDiagnosticMessage):
(ChromeClient):

  • page/DiagnosticLoggingKeys.cpp: Added.

(WebCore::DiagnosticLoggingKeys::mediaLoadedKey):
(WebCore::DiagnosticLoggingKeys::mediaLoadingFailedKey):
(WebCore::DiagnosticLoggingKeys::pluginLoadedKey):
(WebCore::DiagnosticLoggingKeys::pluginLoadingFailedKey):
(WebCore::DiagnosticLoggingKeys::passKey):
(WebCore::DiagnosticLoggingKeys::failKey):
(WebCore::DiagnosticLoggingKeys::noopKey):

  • page/DiagnosticLoggingKeys.h: Added.

(DiagnosticLoggingKeys):

Add the new files DiagnosticLoggingKeys.cpp,h to the project:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit2:

Pipe the ChromeClient logDiagnosticMessage() function through WebKit2 to a new bundle class
InjectedBundlePageDiagnosticLoggingClient, to be implemented by the client.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageSetDiagnosticLoggingClient): Added.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp: Added.

(WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessage):

  • WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.h: Added.

(InjectedBundlePageDiagnosticLoggingClient):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::logDiagnosticMessage):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::initializeInjectedBundleDiagnosticLoggingClient):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::injectedBundleDiagnosticLoggingClient):

Add a convenience class to retrieve the diagnostic message keys:

  • WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp: Added.

(WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessage):

  • WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.h: Added.

(InjectedBundlePageDiagnosticLoggingClient):

Add the InjectedBundlePageDiagnosticLoggingClient.cpp,h files.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • win/WebKit2.vcproj:
  • WebKit2.xcodeproj/project.pbxproj:
11:27 AM Changeset in webkit [123777] by reed@google.com
  • 2 edits in trunk/LayoutTests

expectations change for skia rev. 4771
https://bugs.webkit.org/show_bug.cgi?id=92402

Reviewed by NOBODY : expectations change only

  • platform/chromium/TestExpectations:
11:26 AM Changeset in webkit [123776] by kbalazs@webkit.org
  • 4 edits in trunk/Tools

[nrwt] get rid of --skip-pixel-test-if-no-baseline
https://bugs.webkit.org/show_bug.cgi?id=92377

Reviewed by Adam Barth.

Remove the option and all code paths that handled it.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.should_run_as_pixel_test):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(_set_up_derived_options):
(parse_args):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_repeat_each):

11:26 AM Changeset in webkit [123775] by jer.noble@apple.com
  • 13 edits in trunk/Source

Add setting to enable and disable diagnostic logging.
https://bugs.webkit.org/show_bug.cgi?id=92337

Reviewed by Anders Carlsson.

Source/WebCore:

Add a new entry in Settings, defaulting to false.

  • page/Settings.cpp:

(WebCore::Settings::Settings): Default the new setting to false.

  • page/Settings.h:

(WebCore::Settings::setDiagnosticLoggingEnabled): Simple accessor.
(WebCore::Settings::diagnosticLoggingEnabled): Ditto.

Source/WebKit/mac:

Add a WebKit WebPreferences API to set set the WebCore diagnosticLoggingEnabled setting.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]): Register the default value to false.
(-[WebPreferences diagnosticLoggingEnabled]): Simple userDefaults accessor.
(-[WebPreferences setDiagnosticLoggingEnabled:]): Ditto.

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]): Ensure this preference is propagated to Settings

whenever the preferences change.

Source/WebKit2:

Add a WebKit2 WKPreferences API to set set the WebCore diagnosticLoggingEnabled setting.

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetDiagnosticLoggingEnabled):
(WKPreferencesGetDiagnosticLoggingEnabled):

  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Ensure this preference is propagated to Settings

whenever the preferences change.

11:18 AM Changeset in webkit [123774] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Regression(r123731): Linking errors due to efreet functions
https://bugs.webkit.org/show_bug.cgi?id=92378

Unreviewed build fix.

The library list created by PlatformEfl.cmake was being erased by a
SET called after including the platform specific file. Luckily the
dependencies were fulfilled by other targets until efreet was add.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-26

  • CMakeLists.txt:
11:16 AM Changeset in webkit [123773] by commit-queue@webkit.org
  • 16 edits
    4 adds in trunk

Add FastMalloc statistics in window.internals
https://bugs.webkit.org/show_bug.cgi?id=91274

Patch by Olivier Blin <Olivier Blin> on 2012-07-26
Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/harness/fastmallocstatistics-object.html

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.vcproj/WebCoreTestSupport.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • testing/FastMallocStatistics.h: Added.

(WebCore):
(FastMallocStatistics):
(WebCore::FastMallocStatistics::create):
(WebCore::FastMallocStatistics::reservedVMBytes):
(WebCore::FastMallocStatistics::committedVMBytes):
(WebCore::FastMallocStatistics::freeListBytes):
(WebCore::FastMallocStatistics::FastMallocStatistics):

  • testing/FastMallocStatistics.idl: Added.
  • testing/Internals.cpp:

(WebCore::Internals::fastMallocStatistics):
(WebCore):

  • testing/Internals.h:

(WebCore):
(Internals):

  • testing/Internals.idl:

Tools:

  • GNUmakefile.am:

LayoutTests:

  • fast/harness/fastmallocstatistics-object-expected.txt: Added.
  • fast/harness/fastmallocstatistics-object.html: Added.
11:02 AM Changeset in webkit [123772] by enne@google.com
  • 21 edits in trunk

Source/WebCore: [chromium] Remove redundant surface origin transforms
https://bugs.webkit.org/show_bug.cgi?id=91815

Reviewed by Stephen White.

Bug 91417 changed draw transforms to become equivalent to origin
transforms for surfaces. This change removes them as they are no
longer needed for anything.

No new tests. Just a refactoring.

  • platform/graphics/chromium/RenderSurfaceChromium.h:

(RenderSurfaceChromium):

  • platform/graphics/chromium/cc/CCDamageTracker.cpp:

(WebCore::CCDamageTracker::extendDamageForRenderSurface):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::computeScrollCompensationMatrixForChildren):
(WebCore::calculateDrawTransformsInternal):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::::leaveToRenderTarget):
(WebCore::::unoccludedContributingSurfaceContentRect):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:

(WebCore::CCRenderPassDrawQuad::create):
(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:

(CCRenderPassDrawQuad):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::createSharedQuadState):
(WebCore::CCRenderSurface::createReplicaSharedQuadState):
(WebCore::CCRenderSurface::appendQuads):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(CCRenderSurface):

Source/WebKit2: [EFL][WK2] Compilation warning in EWK2UnitTestServer.cpp
https://bugs.webkit.org/show_bug.cgi?id=92387

Reviewed by Kenneth Rohde Christiansen.

Fix compilation warning in EWK2UnitTestServer.cpp.

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.cpp:

(EWK2UnitTestServer::EWK2UnitTestServer):

LayoutTests: [Qt] css3/filters, editing/undo, fast/block/lineboxcontain, fast/js and tables/layering tests need update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=92292

Reviewed by Alexis Menard.

  • platform/qt-5.0/Skipped:
  • platform/qt/css3/filters/effect-blur-expected.txt:
  • platform/qt/css3/filters/effect-blur-hw-expected.txt:
  • platform/qt/css3/filters/regions-expanding-expected.txt:
  • platform/qt/editing/undo/5378473-expected.txt:
  • platform/qt/editing/undo/undo-misspellings-expected.txt:
  • platform/qt/fast/block/lineboxcontain/inline-box-expected.png:
  • platform/qt/fast/block/lineboxcontain/inline-box-expected.txt:
  • platform/qt/fast/block/lineboxcontain/inline-box-vertical-expected.png:
  • platform/qt/fast/block/lineboxcontain/inline-box-vertical-expected.txt:
  • platform/qt/fast/block/lineboxcontain/inline-replaced-expected.png:
  • platform/qt/fast/block/lineboxcontain/inline-replaced-expected.txt:
  • platform/qt/fast/block/lineboxcontain/none-expected.png:
  • platform/qt/fast/block/lineboxcontain/none-expected.txt:
  • platform/qt/fast/block/lineboxcontain/parsing-invalid-expected.png:
  • platform/qt/fast/block/lineboxcontain/parsing-invalid-expected.txt:
  • platform/qt/fast/block/lineboxcontain/replaced-expected.png:
  • platform/qt/fast/block/lineboxcontain/replaced-expected.txt:
10:59 AM Changeset in webkit [123771] by enne@google.com
  • 13 edits in trunk/Source

[chromium] Remove redundant surface origin transforms
https://bugs.webkit.org/show_bug.cgi?id=91815

Reviewed by Stephen White.

Source/WebCore:

Bug 91417 changed draw transforms to become equivalent to origin
transforms for surfaces. This change removes them as they are no
longer needed for anything.

No new tests. Just a refactoring.

  • platform/graphics/chromium/RenderSurfaceChromium.h:

(RenderSurfaceChromium):

  • platform/graphics/chromium/cc/CCDamageTracker.cpp:

(WebCore::CCDamageTracker::extendDamageForRenderSurface):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::computeScrollCompensationMatrixForChildren):
(WebCore::calculateDrawTransformsInternal):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::::leaveToRenderTarget):
(WebCore::::unoccludedContributingSurfaceContentRect):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:

(WebCore::CCRenderPassDrawQuad::create):
(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:

(CCRenderPassDrawQuad):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::createSharedQuadState):
(WebCore::CCRenderSurface::createReplicaSharedQuadState):
(WebCore::CCRenderSurface::appendQuads):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(CCRenderSurface):

Source/WebKit/chromium:

Clean up use of origin transforms in tests. Where possible, test
against the equivalent draw transform.

  • tests/CCLayerTreeHostCommonTest.cpp:
  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/CCRenderSurfaceTest.cpp:
10:55 AM Changeset in webkit [123770] by caseq@chromium.org
  • 10 edits in trunk/Source/WebCore

Web Inspector: simplify handling of status bar items
https://bugs.webkit.org/show_bug.cgi?id=92143

Reviewed by Pavel Feldman.

  • split status bars into "global" (always in the bottom) and "panel"

(on top of the drawer when drawer is shown)

  • use "inner" status bar section in global status bar to display either

panel status bar items or drawer view items (depending on drawer visibility)

  • let panels/views manage their counters as part of their status bar

items, not through special interface members;

  • get rid of absolute positioning in the status bars where possible;
  • inspector/front-end/AdvancedSearchController.js:

(WebInspector.SearchView.prototype.get statusBarItems):

  • inspector/front-end/Drawer.js:

(WebInspector.Drawer):
(WebInspector.Drawer.prototype.show.animationFinished):
(WebInspector.Drawer.prototype.show):
(WebInspector.Drawer.prototype.hide.animationFinished):
(WebInspector.Drawer.prototype.hide):
(WebInspector.Drawer.prototype._startStatusBarDragging):

  • inspector/front-end/Panel.js:

(WebInspector.Panel.prototype.wasShown):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype.get statusBarItems):
(WebInspector.TimelinePanel.prototype.willHide):

  • inspector/front-end/elementsPanel.css:

(.crumbs):

  • inspector/front-end/inspector.css:

(#main):
(body.drawer-visible #main-panels):
(.status-bar):
(.status-bar-item):
(#panel-status-bar-placeholder):
(body.drawer-visible #panel-status-bar-placeholder):
(#panel-status-bar-resizer):
(#panel-status-bar):
(#panel-status-bar > div):
(#error-warning-count):
(#drawer):
(#drawer-contents):
(.status-bar-items):
(.drawer-header):
(#inner-status-bar):
(.search-status-bar-item):
(.search-status-bar-message):
(.search-status-bar-progress):
(body:not(.platform-mac) .search-status-bar-progress):
(body.platform-mac .search-status-bar-progress):
(.search-status-bar-stop-button-item):
(.search-status-bar-stop-button .glyph):
(.search-results-status-bar-message):

  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

(WebInspector._createGlobalStatusBarItems):
(WebInspector.showViewInDrawer):
(WebInspector._closePreviousDrawerView):

  • inspector/front-end/timelinePanel.css:

(.timeline-records-counter):

10:47 AM Changeset in webkit [123769] by commit-queue@webkit.org
  • 11 edits
    1 copy
    3 adds in trunk/Source

[EFL][WK2] Implement Network Information provider
https://bugs.webkit.org/show_bug.cgi?id=92343

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-26
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Moved Network Information provider code from WebKit1
to WebCore so that it can be shared with WebKit2.

No new tests, no behavior change.

  • PlatformEfl.cmake:
  • platform/efl/NetworkInfoProviderEfl.cpp: Copied from Source/WebKit/efl/WebCoreSupport/NetworkInfoClientEfl.cpp.

(WebCore):
(WebCore::NetworkInfoProviderEfl::NetworkInfoProviderEfl):
(WebCore::NetworkInfoProviderEfl::startUpdating):
(WebCore::NetworkInfoProviderEfl::stopUpdating):
(WebCore::NetworkInfoProviderEfl::bandwidth):

  • platform/efl/NetworkInfoProviderEfl.h: Added.

(WebCore):
(NetworkInfoProviderEfl):

Source/WebKit:

WebKit EFL not longer needs to link against EEZE
library since the Network Information provider
was moved to WebCore.

  • CMakeLists.txt:
  • PlatformEfl.cmake:

Source/WebKit/efl:

Make NetworkInfoClientEfl use NetworkInfoProviderEfl
from WebCore to avoid code duplication with WebKit2.

  • WebCoreSupport/NetworkInfoClientEfl.cpp:

(WebCore::NetworkInfoClientEfl::startUpdating):
(WebCore::NetworkInfoClientEfl::stopUpdating):
(WebCore::NetworkInfoClientEfl::bandwidth):
(WebCore::NetworkInfoClientEfl::metered):
(WebCore):

  • WebCoreSupport/NetworkInfoClientEfl.h:

(WebCore):
(NetworkInfoClientEfl):

Source/WebKit2:

Add Network Information provider for WebKit2 EFL
by using NetworkInfoProviderEfl class from
WebCore.

  • CMakeLists.txt:
  • PlatformEfl.cmake:
  • UIProcess/API/efl/NetworkInfoProvider.cpp: Added.

(toNetworkInfoProvider):
(startUpdatingCallback):
(stopUpdatingCallback):
(getBandwidthCallback):
(isMeteredCallback):
(NetworkInfoProvider::create):
(NetworkInfoProvider::NetworkInfoProvider):
(NetworkInfoProvider::~NetworkInfoProvider):
(NetworkInfoProvider::bandwidth):
(NetworkInfoProvider::metered):
(NetworkInfoProvider::startUpdating):
(NetworkInfoProvider::stopUpdating):

  • UIProcess/API/efl/NetworkInfoProvider.h: Added.

(NetworkInfoProvider):

10:25 AM Changeset in webkit [123768] by pfeldman@chromium.org
  • 14 edits
    1 add in trunk/Source/WebCore

Web Inspector: SASS source mapping straw man (behind experiment)
https://bugs.webkit.org/show_bug.cgi?id=92265

Reviewed by Vsevolod Vlasov.

This change introduces SASS mapping support (behind the experiment).

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype.resourceBinding):
(WebInspector.CSSStyleModel.prototype.setSourceMapping):
(WebInspector.CSSStyleModel.prototype.resetSourceMappings):
(WebInspector.CSSStyleModel.prototype._rawLocationToUILocation):
(WebInspector.CSSLocation):
(WebInspector.CSSRule):
(WebInspector.CSSRule.prototype.get isRegular):
(WebInspector.CSSRule.prototype.uiLocation):

  • inspector/front-end/ContentProviders.js:

(WebInspector.StaticContentProvider.prototype.contentType):

  • inspector/front-end/SASSSourceMapping.js: Added.

(WebInspector.SASSSourceMapping):
(WebInspector.SASSSourceMapping.prototype._populate):
(WebInspector.SASSSourceMapping.prototype._resourceAdded.didRequestContent):
(WebInspector.SASSSourceMapping.prototype._resourceAdded):
(rawLocationToUILocation):
(uiLocationToRawLocation):
(uiSourceCodes):
(reset):
(WebInspector.SASSSource):
(WebInspector.SASSSource.prototype.isEditable):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._createSourceFrame):

  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/StylesPanel.js:

(WebInspector.StylesUISourceCodeProvider):
(WebInspector.StylesUISourceCodeProvider.prototype.rawLocationToUILocation):
(WebInspector.StylesUISourceCodeProvider.prototype.uiLocationToRawLocation):
(WebInspector.StylesUISourceCodeProvider.prototype._resourceAdded):
(WebInspector.StylesUISourceCodeProvider.prototype.reset):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertyTreeElement.prototype):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UILocation.prototype.uiLocationToRawLocation):
(WebInspector.UILocation.prototype.url):

  • inspector/front-end/Workspace.js:

(WebInspector.Workspace):

  • inspector/front-end/inspector.html:
10:23 AM Changeset in webkit [123767] by Chris Fleizach
  • 3 edits
    2 adds in trunk

WebKit should expose @title as label (AXTitle or AXDescription) sometimes instead of AXHelp, according to the ARIA text alt computation
https://bugs.webkit.org/show_bug.cgi?id=91911

Reviewed by Anders Carlsson.

Source/WebCore:

The ARIA spec states that the title attribute should be used as the last resort for a description of an element. WebKit needs to honor that.

Test: platform/mac/accessibility/title-attribute-used-as-last-resort.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::helpText):
(WebCore::AccessibilityRenderObject::accessibilityDescription):

LayoutTests:

  • platform/mac/accessibility/title-attribute-used-as-last-resort-expected.txt: Added.
  • platform/mac/accessibility/title-attribute-used-as-last-resort.html: Added.
9:59 AM Changeset in webkit [123766] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Compilation warning in EWK2UnitTestServer.cpp
https://bugs.webkit.org/show_bug.cgi?id=92387

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-26
Reviewed by Kenneth Rohde Christiansen.

Fix compilation warning in EWK2UnitTestServer.cpp.

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.cpp:

(EWK2UnitTestServer::EWK2UnitTestServer):

9:54 AM Changeset in webkit [123765] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed r123761 follow-up, inspector closure compilation fix.

  • inspector/front-end/Script.js:

(WebInspector.Script.Location.prototype.uiLocation):

  • inspector/front-end/ScriptSnippetModel.js:
9:50 AM Changeset in webkit [123764] by Patrick Gansterer
  • 3 edits in trunk/Source/WebCore

Cleanup GraphicsContext::(getWindowsContext|releaseWindowsContext)
https://bugs.webkit.org/show_bug.cgi?id=92113

Reviewed by Simon Hausmann.

Cleanup the definition of the two methods across different ports and
replace the calls to them with LocalWindowsContext where possible.

  • platform/graphics/GraphicsContext.h:

(GraphicsContext):

  • platform/win/ScrollbarThemeWin.cpp:

(WebCore::ScrollbarThemeWin::paintThumb):

9:45 AM Changeset in webkit [123763] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Fix after r123733.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-07-26

  • platform/qt/Skipped:
9:44 AM Changeset in webkit [123762] by commit-queue@webkit.org
  • 2 edits
    54 deletes in trunk/LayoutTests

[Qt] Reskip fast/forms WK2 added results
https://bugs.webkit.org/show_bug.cgi?id=91504

Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2012-07-26
Reviewed by Alexis Menard.

This patch reverts the added WK2 layout test results from r123156 "[Qt]
Added/updated missing fast/forms results after rebaseline". As discussed with
Caio, almost all of these additions were due to an erroneous input-text and
text-area default size diff between WK1 and WK2 (handled in bug 91990), and a
few ones that are still failing independent of font changes (handled in bug
91610). These tests were reskipped and reassigned to proper bugs.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0-wk2/fast/forms/basic-inputs-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/forms/basic-inputs-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/basic-textareas-quirks-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/forms/basic-textareas-quirks-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/control-restrict-line-height-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/forms/control-restrict-line-height-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/encoding-test-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/fieldset-align-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/forms/fieldset-align-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/input-appearance-bkcolor-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/input-appearance-default-bkcolor-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/forms/input-appearance-default-bkcolor-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/input-appearance-disabled-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/forms/input-appearance-disabled-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/input-appearance-focus-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/forms/input-appearance-focus-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/input-appearance-preventDefault-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/input-appearance-readonly-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/forms/input-appearance-readonly-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/input-appearance-selection-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/forms/input-appearance-selection-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/input-appearance-visibility-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/input-baseline-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/forms/input-baseline-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/input-double-click-selection-gap-bug-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/forms/input-double-click-selection-gap-bug-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/input-placeholder-visibility-1-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/input-placeholder-visibility-3-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/input-readonly-dimmed-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/input-readonly-empty-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/input-spaces-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/input-text-click-inside-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/input-text-double-click-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/input-text-option-delete-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/input-text-self-emptying-click-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/input-text-word-wrap-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/input-width-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/placeholder-position-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/forms/placeholder-position-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/search-cancel-button-style-sharing-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/search-display-none-cancel-button-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/search-rtl-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/forms/search-rtl-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/search-vertical-alignment-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/forms/search-vertical-alignment-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/text-style-color-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/forms/text-style-color-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/textarea-placeholder-pseudo-style-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/forms/textarea-placeholder-pseudo-style-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/textarea-placeholder-visibility-1-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/textarea-placeholder-visibility-2-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/textfield-focus-ring-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/textfield-outline-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/textfield-overflow-expected.txt: Removed.
9:42 AM Changeset in webkit [123761] by vsevik@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Introduce generic LiveLocation, make Script.Location inherit it.
https://bugs.webkit.org/show_bug.cgi?id=92388

Reviewed by Pavel Feldman.

Introduced abstract LiveLocation implemented by Script.Location.

  • inspector/front-end/Script.js:

(WebInspector.Script.Location):
(WebInspector.Script.Location.prototype.uiLocation):
(WebInspector.Script.Location.prototype.dispose):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.LiveLocation):
(WebInspector.LiveLocation.prototype.update):
(WebInspector.LiveLocation.prototype.rawLocation):
(WebInspector.LiveLocation.prototype.uiLocation):
(WebInspector.LiveLocation.prototype.dispose):

  • inspector/front-end/inspector.html:
9:40 AM Changeset in webkit [123760] by rafael.lobo@openbossa.org
  • 3 edits
    2 deletes in trunk/LayoutTests

[Qt] platform/qt/tables/mozilla tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91242

Reviewed by Alexis Menard.

Some leftovers were removed from qt-5.0-wk1 and wk2. If some of them
fail on qt-5.0-wk2, then they should be skipped again, but creating
proper bug reports for them.

  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/tables/mozilla/bugs/bug3037-1-expected.png: Removed.
  • platform/qt-5.0/tables/mozilla/bugs/bug3037-1-expected.txt: Removed.
9:34 AM Changeset in webkit [123759] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] readPixels on FBOs are limited to canvas size on SGX platforms
https://bugs.webkit.org/show_bug.cgi?id=92301

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-26
Reviewed by Rob Buis.

This fixes fast/canvas/webgl/uninitialized-test.html on BlackBerry, no new tests.

  • platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:

(WebCore::GraphicsContext3D::readPixels):
(WebCore::GraphicsContext3D::readPixelsAndConvertToBGRAIfNecessary):

9:26 AM Changeset in webkit [123758] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: reduce auto refresh rate of the live native memory diagram
https://bugs.webkit.org/show_bug.cgi?id=92372

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-07-26
Reviewed by Pavel Feldman.

  • inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.NativeMemoryBarChart.prototype.wasShown):

9:23 AM Changeset in webkit [123757] by zecke@webkit.org
  • 2 edits in trunk/Tools

buildbot: Remove the configuration of hfreyther*
https://bugs.webkit.org/show_bug.cgi?id=91849

Reviewed by Adam Roben.

The machine running these configs was decommissioned and
there is no replacement at this point. Remove them from the
configuration.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Remove hfreyther* from

the config. The Qt Linux SH4 and Qt Linux MIPS schedulers are orphaned, remove
them too.

9:22 AM Changeset in webkit [123756] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Refactor BackingStorePrivate::BackingStorePrivate::clearAndUpdateTileOfNotRenderedRegion() to avoid touching tile frontbuffer
https://bugs.webkit.org/show_bug.cgi?id=92095

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-07-26
Reviewed by George Staikos.

PR: 141439
Specifically, we want to avoid changing the rendered region of the
front buffer without proper synchronization.

The method is trying to force checkerboard to appear on screen because
an area was invalidated but the render job was dropped, so the tile
contents are now invalid.

Unfortunately it did this in a way which is not thread safe. Fixed by
making it thread safe, in a way that minimizes memory bandwidth usage.

Instead of using the customary sequence of copy-back, modify and swap,
we send a synchronous message to the compositing thread to avoid the
copy-back step and save memory bandwidth. The trade-off is that the
WebKit thread might wait a little longer for the compositing thread
than it would from a waitForCurrentMessage() call.

The way we synchronize this is rather expensive for the WebKit thread,
and this method is called rather carelessly, so add various early
returns to avoid doing it redundantly.

Internally reviewed by Jakob Petsovits and Adam Treat.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::indexOfTile):
(BlackBerry::WebKit::BackingStorePrivate::clearAndUpdateTileOfNotRenderedRegion):

  • Api/BackingStore_p.h:

(BackingStorePrivate):

9:17 AM Changeset in webkit [123755] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: add GC button to the profiles panel toolbar.
https://bugs.webkit.org/show_bug.cgi?id=92369

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-07-26
Reviewed by Pavel Feldman.

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype.get statusBarItems):
(WebInspector.ProfilesPanel.prototype._garbageCollectButtonClicked):

  • inspector/front-end/profilesPanel.css:

(.garbage-collect-status-bar-item .glyph):

9:15 AM Changeset in webkit [123754] by allan.jensen@nokia.com
  • 10 edits in trunk/Source/WebCore

Move region from HitTestResult to HitTestPoint.
https://bugs.webkit.org/show_bug.cgi?id=92367

Reviewed by Antonio Gomes.

Moves the region to HitTestPoint where it makes more sense, and use this
change to simplify hit-testing a new region in RenderFlowThread.

No new functionality. No new tests.

  • rendering/HitTestResult.cpp:

(WebCore::HitTestPoint::HitTestPoint):
(WebCore::HitTestPoint::operator=):
(WebCore::HitTestResult::HitTestResult):
(WebCore::HitTestResult::operator=):

  • rendering/HitTestResult.h:

(HitTestPoint):
(WebCore::HitTestPoint::region):
(HitTestResult):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::nodeAtPoint):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::nodeAtPoint):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::hitTestRegion):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTestLayer):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::nodeAtPoint):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::nodeAtPoint):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::nodeAtPoint):

9:12 AM Changeset in webkit [123753] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: ExtensionView constructor shouldn't take parent argument
https://bugs.webkit.org/show_bug.cgi?id=92326

Patch by Jan Keromnes <janx@linux.com> on 2012-07-26
Reviewed by Pavel Feldman.

ExtensionView's constructor took a parent element parameter and auto-
showed itself in the constructor. This didn't allow lazy showing and
was confusing because it didn't work like a classic View object. Fixed.

No new tests needed: Refactoring with no behavior changes.

  • inspector/front-end/ExtensionPanel.js:

(WebInspector.ExtensionPanel):
(WebInspector.ExtensionSidebarPane.prototype.setPage):

  • inspector/front-end/ExtensionView.js:

(WebInspector.ExtensionView):

9:04 AM Changeset in webkit [123752] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/Source/WebKit2

[EFL][WK2] Add unit tests for Ewk_Context
https://bugs.webkit.org/show_bug.cgi?id=92005

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-26
Reviewed by Antonio Gomes.

Add unit tests for WebKit2 Ewk_Context.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/ewk_url_scheme_request.cpp:

(ewk_url_scheme_request_finish):

  • UIProcess/API/efl/ewk_url_scheme_request.h: Mark content_data

argument as const.

  • UIProcess/API/efl/tests/test_ewk2_context.cpp: Added.

(TEST_F):
(schemeRequestCallback):

9:00 AM Changeset in webkit [123751] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Refactor BackingStorePrivate::render() to avoid touching tile frontbuffer
https://bugs.webkit.org/show_bug.cgi?id=91989

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-07-26
Reviewed by George Staikos.

PR: 141439
Specifically, we want to avoid changing the rendered region of the
front buffer. The code only touched the front buffer rendered region
if the tile was not committed.

Instead of immediately marking the tile as committed, and clearing the
front buffer's rendered region to make it appear as checkerboard, we
leave the front buffer alone and only mark the tile as committed once
the front buffer has valid content. Un-committed tiles will also be
rendered as checkerboard, so leaving it uncommitted is equivalent to
clearing the front buffer rendered region here.

In addition to the main change, some related changes follow naturally.

The copyPreviousContentsToBackSurfaceOfTile() call only makes sense if
the tile is committed, and the front buffer has valid content.
Otherwise, clearing the back buffer is equivalent. The code has been
updated to this effect.

Since copyPreviousContentsToBackSurfaceOfTile() always sets the
rendered region to the union of the front and back buffer regions,
there is no point in the "backBufferIsValid" check. It has been turned
into an ASSERT instead, just to make sure.

Internally reviewed by Jakob Petsovits.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::render):

8:51 AM Changeset in webkit [123750] by commit-queue@webkit.org
  • 39 edits in trunk/LayoutTests

[Qt] editing/selection tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=92186

Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2012-07-26
Reviewed by Alexis Menard.

After the rebaseline from changeset 121971 - [Qt] DumpRenderTree does not use
'monospace' font when directed, editing/selection tests directory needs to be
updated.

It is important to notice some Qt WK2 layout tests are still failing, some
requires more investigation (handled in bug 91610) and others have a known cause
(input text and text areas differ in WK2 - bug 91990).

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0-wk2/editing/selection/select-box-expected.png:
  • platform/qt-5.0-wk2/editing/selection/select-box-expected.txt:
  • platform/qt-5.0-wk2/editing/selection/select-element-paragraph-boundary-expected.png:
  • platform/qt-5.0-wk2/editing/selection/select-element-paragraph-boundary-expected.txt:
  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/editing/selection/editable-html-element-expected.txt:
  • platform/qt-5.0/editing/selection/extend-by-word-001-expected.txt:
  • platform/qt-5.0/editing/selection/select-box-expected.png:
  • platform/qt-5.0/editing/selection/select-box-expected.txt:
  • platform/qt-5.0/editing/selection/select-element-paragraph-boundary-expected.png:
  • platform/qt-5.0/editing/selection/select-element-paragraph-boundary-expected.txt:
  • platform/qt-5.0/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
  • platform/qt-5.0/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
  • platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
  • platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
  • platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
  • platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
  • platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
  • platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
  • platform/qt-5.0/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
  • platform/qt-5.0/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
  • platform/qt/editing/selection/5825350-1-expected.txt:
  • platform/qt/editing/selection/5825350-2-expected.txt:
  • platform/qt/editing/selection/drag-start-event-client-x-y-expected.txt:
  • platform/qt/editing/selection/fake-doubleclick-expected.png:
  • platform/qt/editing/selection/fake-doubleclick-expected.txt:
  • platform/qt/editing/selection/hit-test-on-text-with-line-height-expected.txt:
  • platform/qt/editing/selection/unrendered-001-expected.png:
  • platform/qt/editing/selection/unrendered-001-expected.txt:
  • platform/qt/editing/selection/unrendered-002-expected.png:
  • platform/qt/editing/selection/unrendered-002-expected.txt:
  • platform/qt/editing/selection/unrendered-003-expected.png:
  • platform/qt/editing/selection/unrendered-003-expected.txt:
  • platform/qt/editing/selection/unrendered-004-expected.png:
  • platform/qt/editing/selection/unrendered-004-expected.txt:
  • platform/qt/editing/selection/unrendered-005-expected.png:
  • platform/qt/editing/selection/unrendered-005-expected.txt:
8:25 AM Changeset in webkit [123749] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[WebGL] ANGLEWebKitBridge should support ESSL platforms
https://bugs.webkit.org/show_bug.cgi?id=92295

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-26
Reviewed by Rob Buis.

This tells ANGLEWebKitBridge to output ESSL code for the BlackBerry
platform. This eliminates the need for a previous hack. In addition,
some (GLSL) ANGLE output that could not be compiled (for example,
glsl-mat4-to-mat3.html) now compiles.

  • platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):

  • platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:

(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):

8:21 AM Changeset in webkit [123748] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: replace "textInput" keyboard event listener breakpoint with "input"
https://bugs.webkit.org/show_bug.cgi?id=92384

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/BreakpointsSidebarPane.js:

(WebInspector.EventListenerBreakpointsSidebarPane):

8:10 AM Changeset in webkit [123747] by jer.noble@apple.com
  • 11 edits in trunk/Source/WebCore

Add a MediaPlayer API to retrieve the description of the current media engine.
https://bugs.webkit.org/show_bug.cgi?id=92336

Reviewed by Eric Carlson.

Add a utility function which retrieves, for diagnostic purposes, a brief description
of the current media engine. Stubs have been added for each of the MediaPlayerPrivate
subclasses which return the name of the class.

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::engineDescription):

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::engineDescription):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

(WebCore::MediaPlayerPrivateAVFoundation::engineDescription):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:

(WebCore::MediaPlayerPrivate::engineDescription):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(WebCore::MediaPlayerPrivateGStreamer::engineDescription):

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:

(WebCore::MediaPlayerPrivateQTKit::engineDescription):

  • platform/graphics/qt/MediaPlayerPrivateQt.h:

(WebCore::MediaPlayerPrivateQt::engineDescription):

  • platform/graphics/wince/MediaPlayerPrivateWinCE.h:

(WebCore::MediaPlayerPrivate::engineDescription):

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::engineDescription):

8:08 AM Changeset in webkit [123746] by pfeldman@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: Edits of styles declared after invalid selector are not applied
https://bugs.webkit.org/show_bug.cgi?id=92382

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Now popping selectorless rules as well.

Test: inspector/styles/styles-edit-property-after-invalid-rule.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::createStyleRule):

LayoutTests:

Additional information of the change such as approach, rationale.

  • inspector/styles/styles-edit-property-after-invalid-rule-expected.txt: Added.
  • inspector/styles/styles-edit-property-after-invalid-rule.html: Added.
7:54 AM Changeset in webkit [123745] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[WebGL] GraphicsContext3D::readPixels has extraneous code from GraphicsContext3D::readPixelsIMG
https://bugs.webkit.org/show_bug.cgi?id=92302

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-26
Reviewed by Noam Rosenthal.

This undoes a mistake from https://bugs.webkit.org/show_bug.cgi?id=90567.

No new tests, because it introduces no new functionality, but it makes the WebGL aquarium demo
run quite a bit smoother on SGX :)

  • platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:

(WebCore::GraphicsContext3D::readPixels):

7:49 AM Changeset in webkit [123744] by yurys@chromium.org
  • 6 edits in trunk/Source

Unreviewed. Revert r123740 as it breaks AppleMac compilation.

Source/WebCore:

  • WebCore.exp.in:
  • inspector/InspectorMemoryAgent.cpp:

(WebCore):

Source/WTF:

  • wtf/text/StringImpl.cpp:
  • wtf/text/StringImpl.h:
7:40 AM Changeset in webkit [123743] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix AppleMac compilation after r123740.

  • WebCore.exp.in: Added missing symbol.
6:28 AM Changeset in webkit [123742] by commit-queue@webkit.org
  • 6 edits
    5 adds in trunk/Source/WebKit2

[EFL][WK2] Add form client for Ewk_View
https://bugs.webkit.org/show_bug.cgi?id=92358

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-26
Reviewed by Kenneth Rohde Christiansen.

Implement a form client for EFL port in order to
send a "form,request,new" signal on the Ewk_View
whenever a form will be submitted.

The Ewk_Form_Submission_Request type is
introduced to provide the client with information
about the form (e.g. text fields contained in the
form) and to submit it.

This is typically used to store login information
that can be used later to pre-fill the form.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/EWebKit2.h:
  • UIProcess/API/efl/ewk_form_submission_request.cpp: Added.

(_Ewk_Form_Submission_Request):
(_Ewk_Form_Submission_Request::_Ewk_Form_Submission_Request):
(_Ewk_Form_Submission_Request::~_Ewk_Form_Submission_Request):
(ewk_form_submission_request_ref):
(ewk_form_submission_request_unref):
(ewk_form_submission_request_field_names_get):
(ewk_form_submission_request_field_value_get):
(ewk_form_submission_request_submit):
(ewk_form_submission_request_new):

  • UIProcess/API/efl/ewk_form_submission_request.h: Added.
  • UIProcess/API/efl/ewk_form_submission_request_private.h: Added.
  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_base_add):
(ewk_view_form_submission_request_new):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/ewk_view_form_client.cpp: Added.

(willSubmitForm):
(ewk_view_form_client_attach):

  • UIProcess/API/efl/ewk_view_form_client_private.h: Added.
  • UIProcess/API/efl/ewk_view_private.h:
6:20 AM Changeset in webkit [123741] by kkristof@inf.u-szeged.hu
  • 1 edit
    5 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Added Qt5 specific expected results after r123670.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-07-26

  • platform/qt-5.0/tables/mozilla/bugs/bug3037-1-expected.png: Added after r123670.
  • platform/qt-5.0/tables/mozilla/bugs/bug3037-1-expected.txt: Added after r123670.
6:17 AM Changeset in webkit [123740] by yurys@chromium.org
  • 5 edits in trunk/Source

Web Inspector: move StringImpl size calculation to StringImpl
https://bugs.webkit.org/show_bug.cgi?id=92359

Reviewed by Pavel Feldman.

Moved stringSize(StringImpl*) implementation from InspectorMemoryAgent to
StringImpl::sizeInBytes();

Source/WebCore:

  • inspector/InspectorMemoryAgent.cpp:

(WebCore):

Source/WTF:

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::sizeInBytes):
(WTF):

  • wtf/text/StringImpl.h:

(StringImpl):

6:03 AM Changeset in webkit [123739] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening after r123696
https://bugs.webkit.org/show_bug.cgi?id=92361

Unreviewed gardening. r123696 made css3/flexbox tests failing on EFL and QT.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-07-26

  • platform/efl/TestExpectations:
5:43 AM Changeset in webkit [123738] by kbalazs@webkit.org
  • 2 edits in trunk/Tools

Unreviewed speculative Mac buildfix after r123729 - 2nd attempt.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::runTest):

5:38 AM Changeset in webkit [123737] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening, adding text failure expectations for two
CSS3 Flexbox tests introduced in r123696.

  • platform/gtk/TestExpectations:
5:32 AM Changeset in webkit [123736] by kbalazs@webkit.org
  • 2 edits in trunk/Tools

Unreviewed speculative buildfix after r123729.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::runTest): Fix sign errors.

5:29 AM Changeset in webkit [123735] by zherczeg@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[Qt][ARM]ARMAssembler needs buildfix afert r123417
https://bugs.webkit.org/show_bug.cgi?id=92086

Reviewed by Csaba Osztrogonác.

The ARM implementation of this should be optimized code path
is covered by a non-optimized code path. This patch fixes this,
and adds a new function which returns with the offset range.

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::readPointer):
(ARMAssembler):
(JSC::ARMAssembler::repatchInt32):
(JSC::ARMAssembler::repatchCompact):

  • assembler/MacroAssemblerARM.h:

(MacroAssemblerARM):
(JSC::MacroAssemblerARM::isCompactPtrAlignedAddressOffset):
(JSC::MacroAssemblerARM::load32WithCompactAddressOffsetPatch):

5:26 AM WikiStart edited by kseo@webkit.org
(diff)
5:21 AM Changeset in webkit [123734] by charles.wei@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

Remove redundant include of PageGroup.h in FrameLoader.cpp
https://bugs.webkit.org/show_bug.cgi?id=92357

Reviewed by Kentaro Hara.

No new tests, just remove redundant include file.

  • loader/FrameLoader.cpp:
5:11 AM Changeset in webkit [123733] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip a failing tests.
https://bugs.webkit.org/show_bug.cgi?id=92355.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-07-26

  • platform/qt/Skipped:
5:10 AM Changeset in webkit [123732] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] WebPage::handleEditingKeyboardEvent does not check whether the node allows editing.
https://bugs.webkit.org/show_bug.cgi?id=92364

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-07-26
Reviewed by Kenneth Rohde Christiansen.

Added a check whether the input node allows editing. If editing is not allowed
text input event will not be emitted.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::handleEditingKeyboardEvent):

5:01 AM Changeset in webkit [123731] by commit-queue@webkit.org
  • 13 edits in trunk

[EFL] EFL port should use XDG paths
https://bugs.webkit.org/show_bug.cgi?id=91719

Patch by Zoltan Nyul <zoltan.nyul@intel.com> on 2012-07-26
Reviewed by Kenneth Rohde Christiansen.

.:

Efreet library added.

  • Source/cmake/FindEFL.cmake:

Source/WebKit:

Add efreet library to get the xdg paths.

  • PlatformEfl.cmake:

Source/WebKit/efl:

Using xdg paths instead of home/.webkit directory for application
cache, web-database and local-storage.

  • ewk/ewk_main.cpp:

(_ewk_init_body):

Source/WebKit2:

Setting xdg paths for application cache, web-database and local-storage.

  • PlatformEfl.cmake:
  • UIProcess/efl/WebContextEfl.cpp:

(WebKit::WebContext::applicationCacheDirectory):
(WebKit::WebContext::platformDefaultDatabaseDirectory):
(WebKit::WebContext::platformDefaultLocalStorageDirectory):

Tools:

The appcache/localstorage/webdatabase path should be set in the
ewk_main.cpp instead of the DumpRenderTree, and the XDG_DATA_HOME and
XDG_CACHE_HOME should be set to different directory for each processes
for the layout-tests.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::initialize):

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort.setup_environ_for_server):

  • efl/jhbuild.modules:
4:52 AM Changeset in webkit [123730] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

2% of all samples running grid demo show up in StyleResolver::canShareStyleWithElement, 20% of those due to getAttribute instead of fastGetAttribute
https://bugs.webkit.org/show_bug.cgi?id=92257

Reviewed by Andreas Kling.

This check was added 7 years ago by hyatt in:
http://trac.webkit.org/changeset/10984
And then later made slow after triggering an ASSERT added:
http://trac.webkit.org/changeset/97670

SVG uses a "type" attribute (and it is animatable), but only when
used on filter elements:
http://www.w3.org/TR/SVG/attindex.html
In any case, this does not apply here, and is certainly not what
this check was originally intended for.

I've moved the check to canShareStyleWithControl
as it is only needed when the elements in question are both input elements.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

4:40 AM Changeset in webkit [123729] by kbalazs@webkit.org
  • 14 edits in trunk/Tools

[NRWT] should have a way to restrict pixel tests for individual directories
https://bugs.webkit.org/show_bug.cgi?id=91754

Reviewed by Dirk Pranke.

Added --pixel-test-directories option to nrwt. It implies --pixel-tests.
If the platform supports this option only tests from these directories will
be executed as pixel tests. Furthermore, platforms can have a default set of
pixel test directories. To support the feature the test harness have to be
able to inform the driver whether to dump pixels for each tests. For this
purpose I changed WTR and the Qt DRT to handle a --pixel-test argument from
the standard output and made NRWT use this argument with these drivers.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::open):
(WebCore::DumpRenderTree::processLine):
(WebCore::DumpRenderTree::setDumpPixelsForAllTests):
(WebCore::DumpRenderTree::dump):

  • DumpRenderTree/qt/DumpRenderTreeQt.h:

(DumpRenderTree):

  • DumpRenderTree/qt/main.cpp:

(main):
Handle the --pixel-test argument.

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner._should_fetch_expected_checksum):
(SingleTestRunner._overwrite_baselines):
(SingleTestRunner._compare_output):

  • Scripts/webkitpy/layout_tests/controllers/worker.py:

(Worker._update_test_input):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.supports_switching_pixel_tests_per_test): Ports can override this to inform
the harness that --pixel-test argument is supported. True for WTR, otherwise calls
private version that can be overridden by the actual platform. Only true with WTR
and Qt DRT currently. This supposed to exist only temporary until there are ports
that doesn't support the feature in their DRT's.
(Port):
(Port._supports_switching_pixel_tests_per_test):
(Port.should_run_as_pixel_test):
(Port._should_run_as_pixel_test): Ports can override this to define their
default set of pixel tests directories.

  • Scripts/webkitpy/layout_tests/port/driver.py:

(Driver.cmd_line): Don't pass --pixel-tests if the platform supports per test
--pixel-test.
(Driver._command_from_driver_input): Pass --pixel-test if it is supported and pixel
tests are enabled.

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort.check_sys_deps):
(QtPort):
(QtPort._supports_switching_pixel_tests_per_test):
(QtPort._should_run_as_pixel_test):
(QtPort._default_pixel_test_directories): Only compositing will be our default pixel
test directory for the time being.

  • Scripts/webkitpy/layout_tests/port/test.py:

(TestPort.supports_switching_pixel_tests_per_test):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(_set_up_derived_options):
(parse_args):
Handle the --pixel-test-directory option. It expect a directory below LayoutTests
and can be specified multiple times. Added fixme's that we should improve how we
handle these arguments.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_run_singly_actually_runs_tests):
(MainTest.test_pixel_test_directories):
Added an integration test for the feature.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestController::runTest):

  • WebKitTestRunner/TestController.h:

(TestController):
Handle the --pixel-test argument.

4:38 AM Changeset in webkit [123728] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Gardening after r123634
https://bugs.webkit.org/show_bug.cgi?id=92351

Unreviewed gardening.

Newly added inspector tests failing on EFL port due to missing Geolocation support (bug 82140).
Moved Geolocation tests to TestExpectations from Skipped.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-07-26

  • platform/efl/Skipped:
  • platform/efl/TestExpectations:
4:32 AM Changeset in webkit [123727] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL] [WK2] Memory leak in ewk_view_resource_load_client.cpp
https://bugs.webkit.org/show_bug.cgi?id=92099

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-26
Reviewed by Kentaro Hara.

Fix a memory leak by clearing the loadingResources HashMap on exit.

  • UIProcess/API/efl/ewk_view.cpp:

(_Ewk_View_Private_Data::~_Ewk_View_Private_Data):
(_ewk_view_priv_loading_resources_clear):
(ewk_view_load_provisional_started):

3:42 AM Changeset in webkit [123726] by yurys@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: add memory reporting routine to StyleResolver
https://bugs.webkit.org/show_bug.cgi?id=92259

Reviewed by Vsevolod Vlasov.

SyleResolver::reportMemoryUsage is added for estimating StyleResolver
memory footprint.

  • css/StyleResolver.cpp:

(RuleData):
(RuleSet):
(RuleSetSelectorPair):
(WebCore::StyleResolver::Features::reportMemoryUsage):
(WebCore):
(WebCore::StyleResolver::collectMatchingRulesForList):

  • css/StyleResolver.h:

(Features):
(StyleResolver):

  • dom/Document.cpp:

(WebCore::Document::reportMemoryUsage):

  • dom/MemoryInstrumentation.h:

(MemoryInstrumentation):
(WebCore::MemoryClassInfo::addInstrumentedHashSet):
(WebCore::MemoryClassInfo::addInstrumentedVector):
(WebCore::MemoryInstrumentation::addHashMap):
(WebCore):
(WebCore::MemoryInstrumentation::addInstrumentedCollection):

3:35 AM Changeset in webkit [123725] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Source/WebKit2

[DRT] LTC:: pageNumberForElementById() could be moved to Internals
https://bugs.webkit.org/show_bug.cgi?id=92091

Reviewed by Kentaro Hara.

Missing a symbol filter for Mac win port.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
3:34 AM Changeset in webkit [123724] by tommyw@google.com
  • 25 edits
    13 deletes in trunk

MediaStream API: Remove DeprecatedPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=92106

Reviewed by Adam Barth.

Source/WebCore:

Since we are getting ready to add an updated PeerConnection
the old DeprecatedPeerConnection will have to go.

No new tests, and old tests converted to use PeerConnection00.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/mediastream/DOMWindowMediaStream.idl:
  • Modules/mediastream/DeprecatedPeerConnection.cpp: Removed.
  • Modules/mediastream/DeprecatedPeerConnection.h: Removed.
  • Modules/mediastream/DeprecatedPeerConnection.idl: Removed.
  • Modules/mediastream/SignalingCallback.h: Removed.
  • Modules/mediastream/SignalingCallback.idl: Removed.
  • PlatformBlackBerry.cmake:
  • PlatformEfl.cmake:
  • UseJSC.cmake:
  • WebCore.gypi:
  • bindings/generic/RuntimeEnabledFeatures.h:
  • bindings/js/JSDeprecatedPeerConnectionCustom.cpp: Removed.
  • dom/EventTargetFactory.in:
  • platform/mediastream/DeprecatedPeerConnectionHandler.h: Removed.
  • platform/mediastream/DeprecatedPeerConnectionHandlerClient.h: Removed.
  • platform/mediastream/blackberry/DeprecatedPeerConnectionHandler.cpp: Removed.
  • platform/mediastream/chromium/DeprecatedPeerConnectionHandler.cpp: Removed.
  • platform/mediastream/chromium/DeprecatedPeerConnectionHandlerInternal.cpp: Removed.
  • platform/mediastream/chromium/DeprecatedPeerConnectionHandlerInternal.h: Removed.
  • platform/mediastream/gstreamer/DeprecatedPeerConnectionHandler.cpp: Removed.

LayoutTests:

Changed all usages of DeprecatedPeerConnection to PeerConnection00.

  • fast/dom/call-a-constructor-as-a-function-expected.txt:
  • fast/dom/call-a-constructor-as-a-function.html:
  • fast/mediastream/peerconnection-addstream-expected.txt:
  • fast/mediastream/peerconnection-argument-types-expected.txt:
  • fast/mediastream/peerconnection-eventlistener-optional-argument.html:
  • fast/mediastream/peerconnection-mediastreamlist.html:
  • fast/mediastream/peerconnection-removestream-expected.txt:
  • fast/mediastream/script-tests/peerconnection-addstream.js:
  • fast/mediastream/script-tests/peerconnection-argument-types.js:
  • fast/mediastream/script-tests/peerconnection-removestream.js:
  • platform/chromium/fast/dom/call-a-constructor-as-a-function-expected.txt:
  • platform/gtk/fast/dom/call-a-constructor-as-a-function-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
  • platform/win/fast/dom/call-a-constructor-as-a-function-expected.txt:
3:07 AM Changeset in webkit [123723] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Regression(r123604): webintents/web-intents-obj-constructor.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=92349

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-26
Reviewed by Kentaro Hara.

Fix crash occurring after r123604, which replaced strdup()
usage with eina_stringshare_add(). Unfortunately, the DRT
was not updated accordingly to use eina_stringshare_del()
instead of free() on the values returned by Ewk_Intent
getters and it was causing
webintents/web-intents-obj-constructor.html to crash.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::onFrameIntentNew):

2:49 AM Changeset in webkit [123722] by commit-queue@webkit.org
  • 15 edits
    26 adds in trunk

Source/WebCore: CSP 1.1: Implement the Content Security Policy script interface.
https://bugs.webkit.org/show_bug.cgi?id=91707

Patch by Mike West <mkwst@chromium.org> on 2012-07-26
Reviewed by Adam Barth.

The CSP 1.1 editor's draft defines a script interface that gives
developers the ability to query a document regarding the restrictions
set by it's currently active content security policy[1]. This patch
exposes that API in terms of a new DOMSecurityPolicy object.

Data for the API is gathered from the existing ContentSecurityPolicy
object on the containing document. CSP's various methods have been
extended with a reportingStatus parameter which, unsurprisingly,
determines whether a violation report should be sent for blocked
resources. This allows us to reuse the same codepaths by simply using
ContentSecurityPolicy::SuppressReport when querying on behalf of the
API, and ContentSecurityPolicy::SendReport when checking resources a
page wants to load.

This feature is gated on the CSP_NEXT flag, which is currently disabled
for all ports other than Chromium.

[1]: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#script-interfaces--experimental

Tests: http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowconnectionto.html

http/tests/security/contentSecurityPolicy/1.1/securitypolicy-alloweval.html
http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowfontfrom.html
http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowframefrom.html
http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowimagefrom.html
http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowmediafrom.html
http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowobjectfrom.html
http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowscriptfrom.html
http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowstylefrom.html
http/tests/security/contentSecurityPolicy/1.1/securitypolicy-isactive.html
http/tests/security/contentSecurityPolicy/1.1/securitypolicy-reporturi.html

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • bindings/gobject/GNUmakefile.am:
  • WebCore.xcodeproj/project.pbxproj:

We added a new object, so let's tell _everyone!_

  • dom/Document.cpp:

(WebCore::Document::securityPolicy):

Expose the SecurityPolicy object via Document, gated on CSP_NEXT.

(WebCore):

  • dom/Document.h:

(WebCore):
(Document):

  • dom/Document.idl:

Adding the SecurityPolicy object to the document, gated on CSP_NEXT.

  • page/ContentSecurityPolicy.cpp:

(CSPDirectiveList):
(WebCore::CSPDirectiveList::checkInline):
(WebCore::CSPDirectiveList::checkNonce):
(WebCore::CSPDirectiveList::checkSource):

Extracting the core checks out into separate methods.

(WebCore::CSPDirectiveList::checkEvalAndReportViolation):

Use checkEval.

(WebCore::CSPDirectiveList::checkNonceAndReportViolation):

Use checkNonce.

(WebCore::CSPDirectiveList::checkInlineAndReportViolation):

Use checkInline.

(WebCore::CSPDirectiveList::checkSourceAndReportViolation):

Use checkSource.

(WebCore::CSPDirectiveList::allowJavaScriptURLs):
(WebCore::CSPDirectiveList::allowInlineEventHandlers):
(WebCore::CSPDirectiveList::allowInlineScript):
(WebCore::CSPDirectiveList::allowInlineStyle):
(WebCore::CSPDirectiveList::allowEval):
(WebCore::CSPDirectiveList::allowScriptFromSource):
(WebCore::CSPDirectiveList::allowObjectFromSource):
(WebCore::CSPDirectiveList::allowChildFrameFromSource):
(WebCore::CSPDirectiveList::allowImageFromSource):
(WebCore::CSPDirectiveList::allowStyleFromSource):
(WebCore::CSPDirectiveList::allowFontFromSource):
(WebCore::CSPDirectiveList::allowMediaFromSource):
(WebCore::CSPDirectiveList::allowConnectToSource):

These methods now branch on reportingStatus: if SendReoport,
they call checkXAndReportViolation, otherwise, they call checkX.

(WebCore::CSPDirectiveList::gatherReportURIs):

New method that gathers the violation report URIs into a DOMStringList.

(WebCore::isAllowedByAllWithCallStack):
(WebCore::isAllowedByAllWithContext):
(WebCore::isAllowedByAllWithURL):

These now pass reportingStatus through to the various allowX methods.

(WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
(WebCore::ContentSecurityPolicy::allowInlineEventHandlers):
(WebCore::ContentSecurityPolicy::allowInlineScript):
(WebCore::ContentSecurityPolicy::allowInlineStyle):
(WebCore::ContentSecurityPolicy::allowEval):
(WebCore::ContentSecurityPolicy::allowScriptFromSource):
(WebCore::ContentSecurityPolicy::allowObjectFromSource):
(WebCore::ContentSecurityPolicy::allowChildFrameFromSource):
(WebCore::ContentSecurityPolicy::allowImageFromSource):
(WebCore::ContentSecurityPolicy::allowStyleFromSource):
(WebCore::ContentSecurityPolicy::allowFontFromSource):
(WebCore::ContentSecurityPolicy::allowMediaFromSource):
(WebCore::ContentSecurityPolicy::allowConnectToSource):

These accept a new reportingStatus parameter, which is passed through
to the CSPDirectiveList methods.

(WebCore::ContentSecurityPolicy::isActive):

New method that returns true if policy is active.

(WebCore::ContentSecurityPolicy::gatherReportURIs):

New method that returns a DOMStringList of violation report URIs.

  • page/ContentSecurityPolicy.h:

(WebCore):

  • page/DOMSecurityPolicy.cpp: Added.

(WebCore::DOMSecurityPolicy::DOMSecurityPolicy):
(WebCore):
(WebCore::DOMSecurityPolicy::~DOMSecurityPolicy):
(WebCore::DOMSecurityPolicy::isActive):
(WebCore::DOMSecurityPolicy::reportURIs):
(WebCore::DOMSecurityPolicy::allowsInlineScript):
(WebCore::DOMSecurityPolicy::allowsInlineStyle):
(WebCore::DOMSecurityPolicy::allowsEval):
(WebCore::DOMSecurityPolicy::allowsConnectionTo):
(WebCore::DOMSecurityPolicy::allowsFontFrom):
(WebCore::DOMSecurityPolicy::allowsFrameFrom):
(WebCore::DOMSecurityPolicy::allowsImageFrom):
(WebCore::DOMSecurityPolicy::allowsMediaFrom):
(WebCore::DOMSecurityPolicy::allowsObjectFrom):
(WebCore::DOMSecurityPolicy::allowsScriptFrom):
(WebCore::DOMSecurityPolicy::allowsStyleFrom):

  • page/DOMSecurityPolicy.h: Added.

(WebCore):
(DOMSecurityPolicy):
(WebCore::DOMSecurityPolicy::create):

  • page/DOMSecurityPolicy.idl: Added.

LayoutTests: Implement the experimental Content Security Policy script interface.
https://bugs.webkit.org/show_bug.cgi?id=91707

Patch by Mike West <mkwst@chromium.org> on 2012-07-26
Reviewed by Adam Barth.

  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowconnectionto-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowconnectionto.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-alloweval-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-alloweval.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowfontfrom-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowfontfrom.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowframefrom-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowframefrom.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowimagefrom-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowimagefrom.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowmediafrom-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowmediafrom.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowobjectfrom-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowobjectfrom.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowscriptfrom-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowscriptfrom.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowstylefrom-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowstylefrom.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-isactive-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-isactive.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-reporturi-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-reporturi.html: Added.
  • http/tests/security/contentSecurityPolicy/resources/securitypolicy-tests-base.js: Added.

(log):
(injectPolicy):

2:46 AM Changeset in webkit [123721] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix build break on mac win port by r123716.

  • platform/KURL.h:

(KURL):

2:36 AM Changeset in webkit [123720] by kkristof@inf.u-szeged.hu
  • 2 edits
    7 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Added Qt5 specific expected results and png.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-07-26

  • platform/qt-5.0-wk2/fast/block/float/overhanging-tall-block-expected.png: Added after r123551.
  • platform/qt-5.0-wk2/fast/block/float/overhanging-tall-block-expected.txt: Added after r123551.
  • platform/qt-5.0-wk2/platform/qt/plugins/application-plugin-plugins-disabled-expected.png: Added after r123514.
  • platform/qt-5.0-wk2/platform/qt/plugins/application-plugin-plugins-disabled-expected.txt: Update after r123514.
  • platform/qt-5.0/css2.1/t0805-c5519-brdr-r-01-e-expected.png: Added after r123631.
  • platform/qt-5.0/css2.1/t0805-c5519-brdr-r-01-e-expected.txt: Added after r123631.
  • platform/qt-5.0/css2.1/t0905-c5525-fltblck-00-d-ag-expected.png: Added after r123631.
  • platform/qt-5.0/css2.1/t0905-c5525-fltblck-00-d-ag-expected.txt: Added after r123631.
2:32 AM Changeset in webkit [123719] by vsevik@chromium.org
  • 17 edits
    4 deletes in trunk

Unreviewed, rolling out r123715.
http://trac.webkit.org/changeset/123715
https://bugs.webkit.org/show_bug.cgi?id=92356

Breaks compilation on multiple platforms (Requested by vsevik
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-26

Source/WebCore:

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::didReceiveData):
(WebCore::InspectorResourceAgent::getResponseBody):

  • inspector/InspectorResourceAgent.h:

(InspectorResourceAgent):

  • inspector/NetworkResourcesData.cpp:

(WebCore::NetworkResourcesData::ResourceData::ResourceData):
(WebCore::NetworkResourcesData::ResourceData::setContent):
(WebCore::NetworkResourcesData::ResourceData::dataLength):
(WebCore::NetworkResourcesData::ResourceData::appendData):
(WebCore::NetworkResourcesData::ResourceData::decodeDataToContent):
(WebCore::NetworkResourcesData::setResourceContent):
(WebCore::NetworkResourcesData::maybeAddResourceData):
(WebCore::NetworkResourcesData::maybeDecodeDataToContent):
(WebCore::NetworkResourcesData::setResourcesDataSizeLimits):
(WebCore::NetworkResourcesData::ensureFreeSpace):

  • inspector/NetworkResourcesData.h:

(ResourceData):
(WebCore::NetworkResourcesData::ResourceData::cachedResource):
(NetworkResourcesData):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::~CachedResource):
(WebCore::CachedResource::removeClient):
(WebCore::CachedResource::deleteIfPossible):

  • loader/cache/CachedResource.h:

(CachedResource):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::garbageCollectDocumentResourcesTimerFired):
(WebCore::CachedResourceLoader::clearPreloads):

  • loader/cache/CachedResourceLoader.h:

(CachedResourceLoader):

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::evict):

  • testing/InternalSettings.cpp:
  • testing/Internals.cpp:
  • testing/Internals.h:

(Internals):

LayoutTests:

  • http/tests/inspector/network/cached-resource-destroyed-moved-to-storage-expected.txt: Removed.
  • http/tests/inspector/network/cached-resource-destroyed-moved-to-storage.html: Removed.
  • http/tests/inspector/network/cached-resource-destroyed-too-big-discarded-expected.txt: Removed.
  • http/tests/inspector/network/cached-resource-destroyed-too-big-discarded.html: Removed.
2:28 AM Changeset in webkit [123718] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit/win

[Mac] Fix build break on Apple win bot after r123711
https://bugs.webkit.org/show_bug.cgi?id=92354

Reviewed by Adam Barth.

Missing return value.

  • WebFrame.cpp:

(WebFrame::pageNumberForElementById):

2:09 AM Changeset in webkit [123717] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip the failing tests.

  • platform/qt/Skipped:
1:55 AM Changeset in webkit [123716] by gyuyoung.kim@samsung.com
  • 22 edits in trunk/Source/WebCore

Add *explicit* keyword to constructors in WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=92238

Reviewed by Kentaro Hara.

As a step to let *explicit* keyword add to constructors which have a parameter,
*explicit* keyword is added to Source/WebCore/platform in order to avoid implicit
type conversion.

Some files in platform directory can't use explicit keyword because of build breaks.

No new tests. Covered by existing tests.

  • platform/AutodrainedPool.h:

(AutodrainedPool):

  • platform/ContentType.h:

(ContentType):

  • platform/ContextMenu.h:

(ContextMenu):

  • platform/ContextMenuItem.h:

(ContextMenuItem):

  • platform/Cursor.h:

(WebCore::SharedCursor::SharedCursor):
(Cursor):

  • platform/KURL.h:

(WebCore::KURL::KURL):
(KURL):

  • platform/KURLGooglePrivate.h:

(KURLGooglePrivate):

  • platform/PODRedBlackTree.h:

(WebCore::PODRedBlackTree::PODRedBlackTree):

  • platform/Pasteboard.h:

(Pasteboard):

  • platform/PlatformEvent.h:

(WebCore::PlatformEvent::PlatformEvent):

  • platform/PlatformKeyboardEvent.h:

(PlatformKeyboardEvent):

  • platform/PlatformMouseEvent.h:

(PlatformMouseEvent):

  • platform/PlatformPasteboard.h:

(PlatformPasteboard):

  • platform/PlatformTouchEvent.h:

(PlatformTouchEvent):

  • platform/PlatformWheelEvent.h:

(PlatformWheelEvent):

  • platform/RunLoop.h:

(TimerBase):

  • platform/ScrollAnimator.h:

(ScrollAnimator):

  • platform/ScrollAnimatorNone.h:

(ScrollAnimatorNone):

  • platform/SharedBuffer.h:

(SharedBuffer):

  • platform/WheelFlingPlatformGestureCurve.h:

(WheelFlingPlatformGestureCurve):

  • platform/Widget.h:

(Widget):

1:48 AM Changeset in webkit [123715] by vsevik@chromium.org
  • 17 edits
    4 adds in trunk

Web Inspector: Resource agent's reference to cached resources should be weak.
https://bugs.webkit.org/show_bug.cgi?id=92108

Reviewed by Pavel Feldman.

Source/WebCore:

NetworkResourcesData now stores a raw pointer to CachedResource.
CachedResource now notifies InspectorInstrumentation that it will be destroyed.
InspectorInstrumentation stores a set of InstrumentingAgents and broadcasts willDestroyCachedResource event to all available resourceAgents.
Destroyed resources content is saved to NetworkResourcesData.
Changed content size variables type in NetworkResourcesData from int to size_t.

Tests: http/tests/inspector/network/cached-resource-destroyed-moved-to-storage.html

http/tests/inspector/network/cached-resource-destroyed-too-big-discarded.html

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::willDestroyCachedResourceImpl):
(WebCore::InspectorInstrumentation::registerInstrumentingAgents):
(WebCore::InspectorInstrumentation::unregisterInstrumentingAgents):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willDestroyCachedResource):
(WebCore):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::didReceiveData):
(WebCore::InspectorResourceAgent::willDestroyCachedResource):
(WebCore):
(WebCore::InspectorResourceAgent::getResponseBody):

  • inspector/InspectorResourceAgent.h:

(InspectorResourceAgent):

  • inspector/NetworkResourcesData.cpp:

(WebCore::NetworkResourcesData::ResourceData::ResourceData):
(WebCore::NetworkResourcesData::ResourceData::setContent):
(WebCore::NetworkResourcesData::ResourceData::dataLength):
(WebCore::NetworkResourcesData::ResourceData::appendData):
(WebCore::NetworkResourcesData::ResourceData::decodeDataToContent):
(WebCore::NetworkResourcesData::setResourceContent):
(WebCore::NetworkResourcesData::maybeAddResourceData):
(WebCore::NetworkResourcesData::maybeDecodeDataToContent):
(WebCore::NetworkResourcesData::removeCachedResource):
(WebCore):
(WebCore::NetworkResourcesData::setResourcesDataSizeLimits):
(WebCore::NetworkResourcesData::ensureFreeSpace):

  • inspector/NetworkResourcesData.h:

(ResourceData):
(WebCore::NetworkResourcesData::ResourceData::base64Encoded):
(WebCore::NetworkResourcesData::ResourceData::cachedResource):
(NetworkResourcesData):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::~CachedResource):
(WebCore::CachedResource::removeClient):
(WebCore::CachedResource::deleteIfPossible):

  • loader/cache/CachedResource.h:

(CachedResource):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::garbageCollectDocumentResourcesTimerFired):
(WebCore::CachedResourceLoader::garbageCollectDocumentResources):
(WebCore::CachedResourceLoader::clearPreloads):

  • loader/cache/CachedResourceLoader.h:

(CachedResourceLoader):

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::evict):

  • testing/InternalSettings.cpp:
  • testing/Internals.cpp:

(WebCore::Internals::garbageCollectDocumentResources):
(WebCore):

  • testing/Internals.h:

(Internals):

LayoutTests:

  • http/tests/inspector/network/cached-resource-destroyed-moved-to-storage-expected.txt: Added.
  • http/tests/inspector/network/cached-resource-destroyed-moved-to-storage.html: Added.
  • http/tests/inspector/network/cached-resource-destroyed-too-big-discarded-expected.txt: Added.
  • http/tests/inspector/network/cached-resource-destroyed-too-big-discarded.html: Added.
1:32 AM Changeset in webkit [123714] by macpherson@chromium.org
  • 2 edits
    2 adds in trunk

Fix null ptr deref in CSSParser::storeVariableDeclaration().
https://bugs.webkit.org/show_bug.cgi?id=92333

Reviewed by Andreas Kling.

Fix null pointer deref that occurs if the CSSParserValue couldn't be converted to a CSSValue.

Test fast/css/variables/variable-unparseable-value-crash.html added.

  • css/CSSParser.cpp:

(WebCore::CSSParser::storeVariableDeclaration):

1:11 AM Changeset in webkit [123713] by shinyak@chromium.org
  • 14 edits
    48 adds in trunk

Source/WebCore: Add UserAgentShadowDOM to FormControlElement just before adding AuthorShadowDOM
https://bugs.webkit.org/show_bug.cgi?id=90866

Reviewed by Hajime Morita.

It ensures that UserAgentShadowDOM is the oldest ShadowDOM.

To show ValidationMessage, WebKit adds a Shadow DOM to some of FormControlElements.
ValidationMessage assumes that the added Shadow DOM is the oldest, however, there was a case
that a page author might add a Shadow DOM before ValidationMessage adds a Shadow DOM.
It will break the assumption that the Shadow DOM added by ValidationMessage is the oldest.
So we have prohibited a page author adding a Shadow DOM to FormControlElement.

To add UserAgentShadowDOM, we use a callback which is called before a page author adding a Shadow DOM.
It adds a UserAgentShadowDOM if it does not exist, so we can ensure that UserAgentShadowDOM is the oldest.

Tests: fast/dom/shadow/input-with-validation-without-shadow.html

fast/dom/shadow/input-with-validation.html
fast/dom/shadow/shadowdom-for-button-complex-shadow.html
fast/dom/shadow/shadowdom-for-button-only-shadow.html
fast/dom/shadow/shadowdom-for-button-without-shadow.html
fast/dom/shadow/shadowdom-for-fieldset-complex-shadow.html
fast/dom/shadow/shadowdom-for-fieldset-only-shadow.html
fast/dom/shadow/shadowdom-for-fieldset-without-shadow.html
fast/dom/shadow/shadowdom-for-form-associated-element-useragent.html
fast/dom/shadow/shadowdom-for-keygen-complex-shadow.html
fast/dom/shadow/shadowdom-for-keygen-only-shadow.html
fast/dom/shadow/shadowdom-for-keygen-without-shadow.html
fast/dom/shadow/shadowdom-for-object-complex-shadow.html
fast/dom/shadow/shadowdom-for-object-only-shadow.html
fast/dom/shadow/shadowdom-for-object-without-shadow.html
fast/dom/shadow/shadowdom-for-output-complex-shadow.html
fast/dom/shadow/shadowdom-for-output-only-shadow.html
fast/dom/shadow/shadowdom-for-output-without-shadow.html
fast/dom/shadow/shadowdom-for-select-complex-shadow.html
fast/dom/shadow/shadowdom-for-select-only-shadow.html
fast/dom/shadow/shadowdom-for-select-without-shadow.html
fast/dom/shadow/shadowdom-for-textarea-complex-shadow.html
fast/dom/shadow/shadowdom-for-textarea-only-shadow.html
fast/dom/shadow/shadowdom-for-textarea-without-shadow.html

  • dom/ShadowRoot.cpp:

(WebCore::allowsAuthorShadowRoot):

  • html/FormAssociatedElement.cpp:

(WebCore::FormAssociatedElement::ensureUserAgentShadowRoot): Ensures the existence of a UserAgentShadowRoot.
If it does not exist, we create it with empty content.
(WebCore):

  • html/FormAssociatedElement.h:

(FormAssociatedElement):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::willAddAuthorShadowRoot):
(WebCore):

  • html/HTMLFormControlElement.h:

(HTMLFormControlElement):

  • html/ValidationMessage.cpp:

(WebCore::adjustBubblePosition): When AuthroShadowRoot does not a shadow element, ValidationMessage
does not have a renderer. So we have to check the existence of renderer.
(WebCore::ValidationMessage::buildBubbleTree):

LayoutTests: Add UserAgentShadowDOM to FormControlElement just before ading UserShadowDOM
https://bugs.webkit.org/show_bug.cgi?id=90866

Reviewed by Hajime Morita.

Added a lot of tests of ShadowDOM for replaced elements. They don't crash,
but many of them are not rendered correctly. Please see Bug 82313,
which is a meta bug of Shadow DOM for replaced elements.

  • fast/dom/shadow/input-with-validation-expected.html: Added.
  • fast/dom/shadow/input-with-validation-without-shadow-expected.html: Added.
  • fast/dom/shadow/input-with-validation-without-shadow.html: Added.
  • fast/dom/shadow/input-with-validation.html: Added.
  • fast/dom/shadow/shadow-disable-expected.txt:
  • fast/dom/shadow/shadow-disable.html:
  • fast/dom/shadow/shadowdom-for-button-complex-shadow-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-button-complex-shadow.html: Added.
  • fast/dom/shadow/shadowdom-for-button-only-shadow-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-button-only-shadow.html: Added.
  • fast/dom/shadow/shadowdom-for-button-without-shadow-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-button-without-shadow.html: Added.
  • fast/dom/shadow/shadowdom-for-fieldset-complex-shadow-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-fieldset-complex-shadow.html: Added.
  • fast/dom/shadow/shadowdom-for-fieldset-only-shadow-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-fieldset-only-shadow.html: Added.
  • fast/dom/shadow/shadowdom-for-fieldset-without-shadow-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-fieldset-without-shadow.html: Added.
  • fast/dom/shadow/shadowdom-for-form-associated-element-useragent-expected.txt: Added.
  • fast/dom/shadow/shadowdom-for-form-associated-element-useragent.html: Added.
  • fast/dom/shadow/shadowdom-for-keygen-complex-shadow-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-keygen-complex-shadow.html: Added.
  • fast/dom/shadow/shadowdom-for-keygen-only-shadow-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-keygen-only-shadow.html: Added.
  • fast/dom/shadow/shadowdom-for-keygen-without-shadow-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-keygen-without-shadow.html: Added.
  • fast/dom/shadow/shadowdom-for-object-complex-shadow-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-object-complex-shadow.html: Added.
  • fast/dom/shadow/shadowdom-for-object-only-shadow-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-object-only-shadow.html: Added.
  • fast/dom/shadow/shadowdom-for-object-without-shadow-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-object-without-shadow.html: Added.
  • fast/dom/shadow/shadowdom-for-output-complex-shadow-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-output-complex-shadow.html: Added.
  • fast/dom/shadow/shadowdom-for-output-only-shadow-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-output-only-shadow.html: Added.
  • fast/dom/shadow/shadowdom-for-output-without-shadow-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-output-without-shadow.html: Added.
  • fast/dom/shadow/shadowdom-for-select-complex-shadow-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-select-complex-shadow.html: Added.
  • fast/dom/shadow/shadowdom-for-select-only-shadow-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-select-only-shadow.html: Added.
  • fast/dom/shadow/shadowdom-for-select-without-shadow-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-select-without-shadow.html: Added.
  • fast/dom/shadow/shadowdom-for-textarea-complex-shadow-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-textarea-complex-shadow.html: Added.
  • fast/dom/shadow/shadowdom-for-textarea-only-shadow-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-textarea-only-shadow.html: Added.
  • fast/dom/shadow/shadowdom-for-textarea-without-shadow-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-textarea-without-shadow.html: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/qt/Skipped:
  • platform/wincairo/Skipped:
12:48 AM Changeset in webkit [123712] by abarth@webkit.org
  • 2 edits in trunk/Tools

Unreviewed attempt to fix the chromium-win build.

  • DumpRenderTree/chromium/TestRunner/TestRunner.cpp:
12:06 AM Changeset in webkit [123711] by Kaustubh Atrawalkar
  • 37 edits in trunk

.: [DRT] LTC:: pageNumberForElementById() could be moved to Internals.
https://bugs.webkit.org/show_bug.cgi?id=92091

Reviewed by Adam Barth.

Exporting Internals::pageNumber symbols for the Gtk build.

  • Source/autotools/symbols.filter:

Source/WebCore: [DRT] LTC:: pageNumberForElementById() could be moved to Internals
https://bugs.webkit.org/show_bug.cgi?id=92091

Reviewed by Adam Barth.

Move the pageNumberForElementById from LayoutTestCotroller to Internals and
remove the old platform specific implementations as it exclusively tests WebCore functionality.

Covered by existing test cases.

  • testing/Internals.cpp:

(WebCore::Internals::counterValue):
(WebCore):
(WebCore::Internals::pageNumber):

  • testing/Internals.h:

(Internals):
(WebCore::Internals::pageNumber):

  • testing/Internals.idl:

Source/WebKit/efl: [DRT] LTC:: pageNumberForElementById() could be moved to Internals
https://bugs.webkit.org/show_bug.cgi?id=92091

Reviewed by Adam Barth.

Move the pageNumberForElementById from LayoutTestCotroller to Internals and
remove the old platform specific implementations as it exclusively tests WebCore functionality.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

Source/WebKit/gtk: [DRT] LTC:: pageNumberForElementById() could be moved to Internals
https://bugs.webkit.org/show_bug.cgi?id=92091

Reviewed by Adam Barth.

Move the pageNumberForElementById from LayoutTestCotroller to Internals and
remove the old platform specific implementations as it exclusively tests WebCore functionality.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Source/WebKit/qt: [DRT] LTC:: pageNumberForElementById() could be moved to Internals
https://bugs.webkit.org/show_bug.cgi?id=92091

Reviewed by Adam Barth.

Move the pageNumberForElementById from LayoutTestCotroller to Internals and
remove the old platform specific implementations as it exclusively tests WebCore functionality.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Source/WebKit/win: [DRT] LTC:: pageNumberForElementById() could be moved to Internals
https://bugs.webkit.org/show_bug.cgi?id=92091

Reviewed by Adam Barth.

Moved the pageNumberForElementById from LayoutTestCotroller to Internals and
remove the old platform specific implementations as it exclusively tests WebCore functionality.

  • WebFrame.cpp: Added comment for removing the function. Removed implementation.

Tools: [DRT] LTC:: pageNumberForElementById() could be moved to Internals
https://bugs.webkit.org/show_bug.cgi?id=92091

Reviewed by Adam Barth.

Move the pageNumberForElementById from LayoutTestCotroller to Internals and
remove the old platform specific implementations as it exclusively tests WebCore functionality.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::setPrinting):

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  • DumpRenderTree/qt/LayoutTestControllerQt.h:

(LayoutTestController):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(LayoutTestController):

LayoutTests: [DRT] LTC:: pageNumberForElementById() could be moved to Internals
https://bugs.webkit.org/show_bug.cgi?id=92091

Reviewed by Adam Barth.

Move the pageNumberForElementById from LayoutTestCotroller to Internals and
remove the old platform specific implementations as it exclusively tests WebCore functionality.

  • printing/pageNumerForElementById-expected.txt:
  • printing/resources/paged-media-test-utils.js:

(pageNumberForElementShouldBe):

  • printing/return-from-printing-mode.html:
  • printing/script-tests/pageNumerForElementById.js:

Jul 25, 2012:

11:37 PM Changeset in webkit [123710] by dgrogan@chromium.org
  • 6 edits in trunk/Source/WebKit/chromium

IndexedDB: WebKit API interfaces for "upgradeneeded" methods and events
https://bugs.webkit.org/show_bug.cgi?id=92203

Reviewed by Adam Barth.

This is the beginning of our typical three-sided-patch process.

  • public/WebIDBCallbacks.h:

(WebKit::WebIDBCallbacks::onBlocked):
(WebKit::WebIDBCallbacks::onUpgradeNeeded):

  • public/WebIDBDatabaseCallbacks.h:

(WebKit::WebIDBDatabaseCallbacks::onVersionChange):

  • public/WebIDBFactory.h:

(WebIDBFactory):
(WebKit::WebIDBFactory::open):

  • src/WebIDBFactoryImpl.cpp:

(WebKit::WebIDBFactoryImpl::open):
(WebKit):

  • src/WebIDBFactoryImpl.h:

(WebIDBFactoryImpl):

11:30 PM Changeset in webkit [123709] by commit-queue@webkit.org
  • 2 edits in trunk/Source/Platform

Upstream declaration of WebGraphicsContext3D::createStreamTextureCHROMIUM() for android
https://bugs.webkit.org/show_bug.cgi?id=92308

Patch by Min Qin <qinmin@chromium.org> on 2012-07-25
Reviewed by Adam Barth.

For android, we need 2 calls to create and destroy the stream texture.
This change adds the interface for these 2 calls.
The actual implementation will be in webgraphicscontext3d_in_process_impl and webgraphicscontext3d_command_buffer_impl.

  • chromium/public/WebGraphicsContext3D.h:

(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::createStreamTextureCHROMIUM):
(WebKit::WebGraphicsContext3D::destroyStreamTextureCHROMIUM):

11:06 PM Changeset in webkit [123708] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix for 32-bit after r123682

  • runtime/JSObject.h: Need to pad out JSObjects on 32-bit so that they're the correct size since

we only removed one 4-byte word and we need to be 8-byte aligned.
(JSObject):

9:02 PM Changeset in webkit [123707] by tkent@chromium.org
  • 1 edit in branches/chromium/1180/Source/WebKit/chromium/src/WebPagePopupImpl.cpp

Merge 123619 - [chromium] Calendar picker popup displays at wrong scale when deviceScaleFactor != 1.
https://bugs.webkit.org/show_bug.cgi?id=92177

Manually tested at deviceScaleFactor = 1 and 2.

Patch by Kevin Ellis <kevers@chromium.org> on 2012-07-25
Reviewed by Kent Tamura.

The device scale factor was not being set for the calendar popup.
As a result, the popup was rendered too small on hidpi displays.
This patch sets the device scale factor for any page popup.

  • src/WebPagePopupImpl.cpp:

(WebKit::WebPagePopupImpl::initPage):

TBR=tkent@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10829030

8:26 PM Changeset in webkit [123706] by morrita@google.com
  • 7 edits in trunk

[Chromium][Win] <progress> animation on RTL direction is reverse
https://bugs.webkit.org/show_bug.cgi?id=92236

Reviewed by Kent Tamura.

Source/WebCore:

This change modfies the way to handle RTL progress bar painting.
Originally it computes the flipped coordinates. This change uses transformation for the flip.
DirectionFlippingScope handles it.

  • rendering/RenderThemeChromiumLinux.cpp:

(WebCore::RenderThemeChromiumLinux::paintProgressBar): Applied DirectionFlippingScope

  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::determinateProgressValueRectFor):

  • Deleted RTL handling in favor of DirectionFlippingScope

(WebCore::RenderThemeChromiumSkia::DirectionFlippingScope::DirectionFlippingScope):
(WebCore):
(WebCore::RenderThemeChromiumSkia::DirectionFlippingScope::~DirectionFlippingScope):

  • rendering/RenderThemeChromiumSkia.h:

(RenderThemeChromiumSkia):
(DirectionFlippingScope): Added.

  • rendering/RenderThemeChromiumWin.cpp:

(WebCore):
(WebCore::RenderThemeChromiumWin::paintProgressBar): Applied DirectionFlippingScope

LayoutTests:

Updated the expectation file which went slightly different.

  • platform/chromium-linux/fast/dom/HTMLProgressElement/progress-element-expected.png:
8:24 PM Changeset in webkit [123705] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=92260
Repalce "int" with "long" from WebCore/*.idls

Patch by Vineet Chaudhary <Vineet> on 2012-07-25
Reviewed by Adam Barth.

As per the WebIDL spec IDL shouldn't have int attributes but long instead.
Repalced attributes types int with long from WebCore/*.idls.

No new tests. TestObj.idl already covers this.
There should be no behavioural changes.

  • dom/Touch.idl: Repalce int with long.
  • dom/WebKitNamedFlow.idl: Ditto.
  • html/canvas/ArrayBuffer.idl: Ditto.
  • html/canvas/WebGLActiveInfo.idl: Ditto.
  • html/canvas/WebGLShaderPrecisionFormat.idl: Ditto.
  • page/WebKitAnimation.idl: Ditto.
8:10 PM Changeset in webkit [123704] by shinyak@chromium.org
  • 3 edits
    4 adds in trunk

The elements in ShadowDOM of meter or progress should not be modifiable.
https://bugs.webkit.org/show_bug.cgi?id=92199

Reviewed by Hajime Morita.

Source/WebCore:

A user can set -webkit-user-modify: read-write to the elements in Shadow DOM in a meter or progress element.
This might cause a undesired crash like Bug 65738. They should be unmodifiable.

We add default css values to elements in ShadowDOM of meter or progress to prohibit editing them.

Tests: fast/html/meter-user-modify.html

fast/html/progress-user-modify.html

  • css/html.css:

Added -webkit-user-modify: read-only !important; for these elements so that they won't be
changed by a user.
(meter::-webkit-meter-bar):
(meter::-webkit-meter-optimum-value):
(meter::-webkit-meter-suboptimum-value):
(meter::-webkit-meter-even-less-good-value):
(progress::-webkit-progress-bar):
(progress::-webkit-progress-value):

LayoutTests:

  • fast/html/meter-user-modify.html: Added.
  • fast/html/meter-user-modify-expected.txt: Added.
  • fast/html/progress-user-modify.html: Added.
  • fast/html/progress-user-modify-expected.txt: Added.
8:02 PM Changeset in webkit [123703] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

[EFL][WK2] Implement the inspector for WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=92213

Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-07-25
Reviewed by Ryosuke Niwa.

Partial Implementation of WebInspectorProxyEfl for WebkitTestRunner.
And Web Inspector resources installation.

  • PlatformEfl.cmake:
  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::WebInspectorProxy):

  • UIProcess/WebInspectorProxy.h:

(WebInspectorProxy):

  • UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):
(WebKit::WebInspectorProxy::platformDidClose):
(WebKit::WebInspectorProxy::inspectorPageURL):
(WebKit::WebInspectorProxy::inspectorBaseURL):

7:52 PM Changeset in webkit [123702] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[BlackBerry] GraphicsContext3D::paintToCanvas should not swap 0th and 2nd components of color
https://bugs.webkit.org/show_bug.cgi?id=92314

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-25
Reviewed by Rob Buis.

No new tests, because it corrects existing functionality, but it makes BlackBerry
pass canvas-text.html and others.

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:

(WebCore::GraphicsContext3D::paintToCanvas):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):

7:46 PM Changeset in webkit [123701] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] GraphicsContext3D::reshapeFBOs does not report when bound FBOs should be restored
https://bugs.webkit.org/show_bug.cgi?id=92304

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-25
Reviewed by Rob Buis.

No new tests, because it corrects existing functionality, but it makes BlackBerry
pass framebuffer-bindings-unaffected-on-resize.html.

  • platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:

(WebCore::GraphicsContext3D::reshapeFBOs):

7:36 PM Changeset in webkit [123700] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] readPixels should set alpha to 255 instead of 0 when alpha is disabled
https://bugs.webkit.org/show_bug.cgi?id=92303

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-25
Reviewed by Rob Buis.

No new tests, because it corrects existing functionality, but it makes BlackBerry
pass context-attributes-alpha-depth-stencil-antialias.html.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::readPixels):

7:32 PM Changeset in webkit [123699] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[WebGL] fast/canvas/webgl/framebuffer-object-attachment.html fails on certain platforms
https://bugs.webkit.org/show_bug.cgi?id=92296

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-25
Reviewed by Rob Buis.

No new tests, because it introduces no new functionality, only fixes the above mentioned test.

  • html/canvas/WebGLFramebuffer.cpp:

(WebCore::WebGLFramebuffer::checkStatus):

7:30 PM Changeset in webkit [123698] by commit-queue@webkit.org
  • 8 edits in trunk

IndexedDB: IDBTransaction::abort() should throw DOMException
https://bugs.webkit.org/show_bug.cgi?id=92069

Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-07-25
Reviewed by Kentaro Hara.

Source/WebCore:

Keep aligned with the W3C spec.
http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#widl-IDBTransaction-abort-void

Test: storage/indexeddb/transaction-abort.html.

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::abort):
(WebCore):

  • Modules/indexeddb/IDBTransaction.h:

(IDBTransaction):

  • Modules/indexeddb/IDBTransaction.idl:

LayoutTests:

Add the exception test for IDBTransaction::abort().

  • storage/indexeddb/resources/transaction-abort.js:

(transactionAborted):

  • storage/indexeddb/transaction-abort-expected.txt:
7:28 PM Changeset in webkit [123697] by commit-queue@webkit.org
  • 1 edit
    9 adds in trunk/LayoutTests

[BlackBerry] Update fast/canvas/webgl expectations
https://bugs.webkit.org/show_bug.cgi?id=92309

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-25
Reviewed by Rob Buis.

Add the css-webkit-canvas-* files, because we render them correctly.

There is nothing we can do about running out of memory on draw-elements-out-of-bounds,
so make that expected.

Our output for framebuffer-object-attachement-expected.txt is valid.

  • platform/blackberry/fast/canvas/webgl/css-webkit-canvas-expected.png: Added.
  • platform/blackberry/fast/canvas/webgl/css-webkit-canvas-expected.txt: Added.
  • platform/blackberry/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png: Added.
  • platform/blackberry/fast/canvas/webgl/css-webkit-canvas-repaint-expected.txt: Added.
  • platform/blackberry/fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt: Added.
  • platform/blackberry/fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Added.
7:24 PM Changeset in webkit [123696] by tony@chromium.org
  • 3 edits
    2 adds in trunk

flexitems can overflow the flexbox due to rounding
https://bugs.webkit.org/show_bug.cgi?id=92163

Reviewed by Levi Weintraub.

Source/WebCore:

Don't round flex item sizes and use LayoutPoint for the location of flex items.

Test: css3/flexbox/flex-rounding.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::resolveFlexibleLengths):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::layoutColumnReverse):

LayoutTests:

Tests for dividing space in non-integral amounts.

  • css3/flexbox/flex-rounding-expected.txt: Added.
  • css3/flexbox/flex-rounding.html: Added.
7:19 PM Changeset in webkit [123695] by abarth@webkit.org
  • 3 edits
    2 adds in trunk/Tools

TestRunner.a should contain a TestRunner object
https://bugs.webkit.org/show_bug.cgi?id=92313

Reviewed by Kent Tamura.

This patch adds a stub implementation of TestRunner, which is the new
home for our implementation of window.testRunner. A future patch will
migrate functions from LayoutTestController to TestRunner.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/TestRunner/TestRunner.cpp: Added.
  • DumpRenderTree/chromium/TestRunner/TestRunner.h: Added.
7:16 PM Changeset in webkit [123694] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[BlackBerry] Integrate certmgr with CredentialBackingStore
https://bugs.webkit.org/show_bug.cgi?id=92183

Patch by Jonathan Dong <Jonathan Dong> on 2012-07-25
Reviewed by George Staikos.

Integrated BlackBerry::Platform::CertMgrWrapper with
CredentialBackingStore, when certmgr is ready we save
the password in certmgr and retrieve it from certmgr.

RIM PR: 171991
Internally reviewed by Joe Mason <jmason@rim.com>.

No new tests since there's no functional change.

  • platform/network/blackberry/CredentialBackingStore.cpp:

(WebCore::hashCredentialInfo):
(WebCore):
(WebCore::CredentialBackingStore::CredentialBackingStore):
(WebCore::CredentialBackingStore::open):
(WebCore::CredentialBackingStore::addLogin):
(WebCore::CredentialBackingStore::updateLogin):
(WebCore::CredentialBackingStore::getLogin):

  • platform/network/blackberry/CredentialBackingStore.h:

(CredentialBackingStore):

7:14 PM Changeset in webkit [123693] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Support RTSP in browser
https://bugs.webkit.org/show_bug.cgi?id=92233

Patch by Jonathan Dong <Jonathan Dong> on 2012-07-25
Reviewed by Rob Buis.

Handle URL scheme "rtsp://" before creating the DocumentLoader
and send the request to webkit. As we don't have any application
which can deal with rtsp invocation for now, we need to create
a media document to wrap the rtsp url within a video tag which
makes it load as a normal video clip.

RIM PR: 169669
Internally reviewed by Charles Wei <charles.wei@torchmobile.com.cn>.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::createDocumentLoader):

7:05 PM Changeset in webkit [123692] by yosin@chromium.org
  • 4 edits in trunk/LayoutTests

[Tests] Re-factor fast/forms/number/number-spinbutton-change-and-input-events.html
https://bugs.webkit.org/show_bug.cgi?id=92206

Reviewed by Kent Tamura.

For ease of maintenance and improving test coverage with low cost, I
would like to make a test script of number-spinbutton-change-and-inputs.html
sharable with other input types which have spin button.

This patch moves JavaScript codes from test HTML file to shared JavaScript
file, common-spinbutton-change-and-input-events.html with parametrized
entry point for specifying input type.

  • fast/forms/number/number-spinbutton-change-and-input-events-expected.txt: Changed "numnber" to "number", and "numberInput" to "testInput".
  • fast/forms/number/number-spinbutton-change-and-input-events.html: Removed JavaScript code.
  • fast/forms/resources/common-spinbutton-change-and-input-events.js: Removed HTML code. Made entry point. Changed to support testing without maximum value.
6:36 PM Changeset in webkit [123691] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r121420): Performance regression of form state saving for pages with multiple forms
https://bugs.webkit.org/show_bug.cgi?id=91804

Reviewed by Hajime Morita.

The complexity of FormKeyGenerator::formKey() was O(N) where N is the
number form elements with an identical action URL, and formKey() is
called for every form. So, it's O(N2). A page in www.reddit.com
contains hundreds of form elements with action="#". So FormController::
formElementsState() took a few seconds on a slow machine.

In order to avoid O(N2) operation, storing a map from form signatures
to next index numbers, instead of storing existing formKey strings.

No new tests. Just a performance improvement.

Note: This is a re-landing of r123191. We rolled it out because of
suspicion of a performance regression. However it was innocent.

  • html/FormController.cpp:

(FormKeyGenerator): Remove m_existingKeys. Add a map from a form
signature string to the next index number.
(WebCore::formSignature): Returns a signature string for a form, without
an index number. This is like "actionURL [name1 name2 ]"
(WebCore::FormKeyGenerator::formKey):
Creates a formKey string by concatenating a formSignature and #n. N is
obtained from m_formSignatureToNextIndexMap in O(1).
(WebCore::FormKeyGenerator::willDeleteForm):
Remove the code for m_existingKeys.

6:22 PM Changeset in webkit [123690] by fpizlo@apple.com
  • 7 edits
    1 add in trunk/Source/JavaScriptCore

JSC GC object copying APIs should allow for greater flexibility
https://bugs.webkit.org/show_bug.cgi?id=92316

Reviewed by Mark Hahnenberg.

It's now the case that visitChildren() methods can directly pin and allocate in new space during copying.
They can also do the copying and marking themselves. This new API is only used for JSObjects for now.

(JSC::SlotVisitor::allocateNewSpaceSlow):
(JSC::SlotVisitor::allocateNewSpaceOrPin):
(JSC):
(JSC::SlotVisitor::copyAndAppend):

  • heap/MarkStack.h:

(MarkStack):
(JSC::MarkStack::appendUnbarrieredValue):
(JSC):

  • heap/SlotVisitor.h:
  • heap/SlotVisitorInlineMethods.h: Added.

(JSC):
(JSC::SlotVisitor::checkIfShouldCopyAndPinOtherwise):
(JSC::SlotVisitor::allocateNewSpace):

  • runtime/JSObject.cpp:

(JSC::JSObject::visitOutOfLineStorage):
(JSC):
(JSC::JSObject::visitChildren):
(JSC::JSFinalObject::visitChildren):

  • runtime/JSObject.h:

(JSObject):

6:05 PM Changeset in webkit [123689] by benjamin@webkit.org
  • 9 edits in trunk/Source

Initialize QualifiedName's strings from the read only data segment
https://bugs.webkit.org/show_bug.cgi?id=92226

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-07-25
Reviewed by Anders Carlsson.

Source/WebCore:

Modify the initialization of static QualifiedName to initialize the AtomicString
with the data from the read only memory.

Overall, HTMLNames::init() gets 10% faster.

  • dom/QualifiedName.cpp:

(WebCore::QualifiedName::QualifiedName):

  • dom/QualifiedName.h:

(QualifiedName):
Remove the useless constructor taking a char* and get rid of the init() function.
The AtomicString representing the name should be constructed by the caller of QualifiedName.

Because the init() code is relatively large and is only executed once, it is important to
keep the AtomicString construction separate. The function createQualifiedName() was added
to improve the cache use. The short version let us reduce the code one more instruction per
call.

  • dom/make_names.pl:

(printQualifiedNameMaker):
(printShortQualifiedNameMaker):
(printNamesCppFile):
(printDefinitions):

Source/WTF:

Add constructors for StringImpl and AtomicString to be able to create
the strings from the literal in read only memory.

  • wtf/text/AtomicString.cpp:

(HashTranslatorCharBuffer):
(WTF::LCharBufferFromLiteralDataTranslator::hash):
(LCharBufferFromLiteralDataTranslator):
(WTF::LCharBufferFromLiteralDataTranslator::equal):
(WTF::LCharBufferFromLiteralDataTranslator::translate):
(WTF::AtomicString::addFromLiteralData):

  • wtf/text/AtomicString.h:

(WTF::AtomicString::AtomicString):
(AtomicString):

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::createFromLiteral):

  • wtf/text/StringImpl.h:

(WTF):
(StringImpl):
(WTF::StringImpl::createFromLiteral):

6:01 PM Changeset in webkit [123688] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/win

Changes to the WebFrame API cause dependent apps to crash.
https://bugs.webkit.org/show_bug.cgi?id=91656
<rdar://problem/11904605>

Patch by Roger Fong <roger_fong@apple.com> on 2012-07-25
Reviewed by Jon Honeycutt.

Changes to the WebFrame API cause certain apps to crash because of inconsistencies in the COM interface.
The resumeAnimations and suspendAnimations are removed, which are still needed.
The counterValueByElementId method was also removed, although is not needed there.
However, for all of these methods, no method stubs were added where appropriate after removal.

  • Interfaces/IWebFramePrivate.idl:

Added resumeAnimations() and suspendAnimations() methods back in. Added unused method stub for counterValueByElementId method.

  • WebFrame.cpp:

(WebFrame::resumeAnimations):
Added this method back in.
(WebFrame::suspendAnimations):
Added this method back in.

  • WebFrame.h:

(Re)added methods and unused method stubs.

6:01 PM Changeset in webkit [123687] by yosin@chromium.org
  • 9 edits in trunk/Source/WebCore

[Forms] Move HTMLInputElement::updateInnerTextValue to InputType class
https://bugs.webkit.org/show_bug.cgi?id=92230

Reviewed by Kent Tamura.

This patch moves implementaion of HTMLInputElement::updateInnerTextValue()
into input type classes, removes updateInnerTextValue() from HTMLInputElement,
and updates call site of updateInnerTextValue().

No new tests. This patch doesn't change behavior.

  • html/DateInputType.cpp:

(WebCore::DateInputType::handleBlurEvent): Updated call site of updateInnerTextValue().

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateType): Updated call site of updateInnerTextValue().
(WebCore::HTMLInputElement::parseAttribute): Updated call site of updateInnerTextValue().
(WebCore::HTMLInputElement::copyNonAttributePropertiesFromElement): Updated call site of updateInnerTextValue().
(WebCore::HTMLInputElement::setSuggestedValue): Updated call site of updateInnerTextValue().

  • html/HTMLInputElement.h:

(HTMLInputElement): Removed updateInnerTextValue().

  • html/InputType.cpp:

(WebCore::InputType::updateInnerTextValue): Added default implementaion.

  • html/InputType.h:

(InputType): Added declaration of updateInnerTextValue().

  • html/NumberInputType.cpp:

(WebCore::NumberInputType::handleBlurEvent): Updated call site of updateInnerTextValue().

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::setValue): Updated call site of updateInnerTextValue().
(WebCore::TextFieldInputType::updateInnerTextValue): Moved implementaion from HTMLInputElement.

  • html/TextFieldInputType.h:

(TextFieldInputType): Added declaration of updateInnerTextValue().

5:57 PM Changeset in webkit [123686] by danakj@chromium.org
  • 4 edits in trunk/Source/WebCore

[chromium] Move ephemeral data for a single frame in LayerRendererChromium into a structure with a scoped lifetime equal to the frame
https://bugs.webkit.org/show_bug.cgi?id=92294

Reviewed by Adrienne Walker.

The LayerRendererChromium class has a number of member variables that are used
while drawing a single frame. Because they are member variables, their lifetimes
are not clear, and some are even updated between frames, which is not needed.

This change creates a LRC::DrawingFrame structure that holds the data used
while drawing the current frame, and an instance of this structure is held
and passed around to functions in LayerRendererChromium, moving all of the
data out from being member variables on the class to being function
arguments on the relevant methods.

The projection and window matrices are a part of this frame data, and are not
used externally, so they are removed from the CCRenderer interface and included
within the DrawingFrame structure.

Covered by existing tests, no change in behaviour intended.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::viewportChanged):
(WebCore::LayerRendererChromium::clearFramebuffer):
(WebCore::LayerRendererChromium::drawFrame):
(WebCore::LayerRendererChromium::drawRenderPass):
(WebCore::LayerRendererChromium::drawQuad):
(WebCore::LayerRendererChromium::drawCheckerboardQuad):
(WebCore::LayerRendererChromium::drawDebugBorderQuad):
(WebCore::LayerRendererChromium::drawBackgroundFilters):
(WebCore::LayerRendererChromium::drawRenderPassQuad):
(WebCore::LayerRendererChromium::drawSolidColorQuad):
(WebCore::LayerRendererChromium::drawTileQuad):
(WebCore::LayerRendererChromium::drawYUVVideoQuad):
(WebCore::LayerRendererChromium::drawStreamVideoQuad):
(WebCore::LayerRendererChromium::drawTextureQuad):
(WebCore::LayerRendererChromium::drawIOSurfaceQuad):
(WebCore::LayerRendererChromium::finishDrawingFrame):
(WebCore::LayerRendererChromium::drawTexturedQuad):
(WebCore::LayerRendererChromium::copyTextureToFramebuffer):
(WebCore::LayerRendererChromium::isCurrentRenderPass):
(WebCore::LayerRendererChromium::useRenderPass):
(WebCore::LayerRendererChromium::useScopedTexture):
(WebCore::LayerRendererChromium::bindFramebufferToTexture):
(WebCore::LayerRendererChromium::setScissorToRect):
(WebCore::LayerRendererChromium::setDrawFramebufferRect):

  • platform/graphics/chromium/LayerRendererChromium.h:

(DrawingFrame):
(WebCore::LayerRendererChromium::DrawingFrame::DrawingFrame):
(LayerRendererChromium):

  • platform/graphics/chromium/cc/CCRenderer.h:

(CCRenderer):

5:53 PM Changeset in webkit [123685] by enne@google.com
  • 8 edits in trunk/Source

[chromium] Make all compositor screen space transforms operate on content rects
https://bugs.webkit.org/show_bug.cgi?id=91807

Reviewed by Kenneth Russell.

Source/WebCore:

Previously, surface screen space transforms operated on surface
content space but layer screen space transforms operated on layer
space. For the purpose of consistency, unify these two so that they
both operate on content space.

No tests, because no change in behavior expected. Just a refactoring.

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):

  • platform/graphics/chromium/cc/CCDebugRectHistory.cpp:

(WebCore::CCDebugRectHistory::savePaintRects):
(WebCore::CCDebugRectHistory::savePropertyChangedRects):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsInternal):
(WebCore::CCLayerTreeHostCommon::findLayerThatIsHitByPoint):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::::markOccludedBehindLayer):
(WebCore::::occluded):
(WebCore::::unoccludedContentRect):

Source/WebKit/chromium:

Update tests that deal with screen space transforms to reflect this change.

  • tests/CCLayerTreeHostCommonTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:
5:30 PM Changeset in webkit [123684] by mitz@apple.com
  • 3 edits
    4 adds in trunk

Hit testing in one column or in the gap between cloumns along the block axis can return a result from the wrong column
https://bugs.webkit.org/show_bug.cgi?id=92311

Reviewed by Anders Carlsson.

Source/WebCore:

Tests: fast/multicol/hit-test-end-of-column.html

fast/multicol/hit-test-gap-block-axis.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::positionForPointWithInlineChildren): To prevent hits after the last
line on a given column from returning the next line in the next column, added a check if
the hit occurred within the pagination strut of a line. Covered by the first test.
(WebCore::RenderBlock::adjustPointToColumnContents): Added clamp-to-column logic for the
block-axis case. This prevents hits near the bottom of the top half of the gap from bleeding
into the top of the next column. Covered by the second test.

LayoutTests:

  • fast/multicol/hit-test-end-of-column-expected.txt: Added.
  • fast/multicol/hit-test-end-of-column.html: Added.
  • fast/multicol/hit-test-gap-block-axis-expected.txt: Added.
  • fast/multicol/hit-test-gap-block-axis.html: Added.
5:24 PM Changeset in webkit [123683] by dgrogan@chromium.org
  • 4 edits in trunk/Source/WebCore

IndexedDB: Make db.version return an integer if appropriate
https://bugs.webkit.org/show_bug.cgi?id=92195

Reviewed by Tony Chang.

Make use of the existing IDBAny mechanism to return an integer if
integer versions have been used.

No new tests - no change in behavior expected.

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::version):
(WebCore):

  • Modules/indexeddb/IDBDatabase.h:

(IDBDatabase):

  • Modules/indexeddb/IDBDatabase.idl:
5:12 PM Changeset in webkit [123682] by mhahnenberg@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Remove JSObject::m_inheritorID
https://bugs.webkit.org/show_bug.cgi?id=88378

Reviewed by Filip Pizlo.

This is rarely used, and not performance critical (the commonly accessed copy is cached on JSFunction),
and most objects don't need an inheritorID (this value is only used if the object is used as a prototype).
Instead use a private named value in the object's property storage.

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::emitAllocateBasicJSObject): No need m_inheritorID to initialize!

  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicJSObject): No need m_inheritorID to initialize!

  • llint/LowLevelInterpreter.asm: No need m_inheritorID to initialize!
  • runtime/JSGlobalData.h:

(JSGlobalData): Added private name 'm_inheritorIDKey'.

  • runtime/JSGlobalThis.cpp:

(JSC::JSGlobalThis::setUnwrappedObject): resetInheritorID is now passed a JSGlobalData&.

  • runtime/JSObject.cpp:

(JSC::JSObject::visitChildren): No m_inheritorID to be marked.
(JSC::JSFinalObject::visitChildren): No m_inheritorID to be marked.
(JSC::JSObject::createInheritorID): Store the newly created inheritorID in the property map. Make sure
it's got the DontEnum attribute!!

  • runtime/JSObject.h:

(JSObject):
(JSC::JSObject::resetInheritorID): Remove the inheritorID from property storage.
(JSC):
(JSC::JSObject::inheritorID): Read the inheritorID from property storage.

5:05 PM Changeset in webkit [123681] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Chromium] Fix infinite loop issue for chromium android layout test
https://bugs.webkit.org/show_bug.cgi?id=92197

Patch by Wei James <james.wei@intel.com> on 2012-07-25
Reviewed by Adam Barth.

The change brought in by r123530 will cause infinite loop when running
Chromium Android Layout Test.
Revert the change for this line only.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort._build_path):

4:48 PM Changeset in webkit [123680] by atwilson@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed chromium change to disable failing WebViewTest.AutoResizeInBetweenSizes.
https://bugs.webkit.org/show_bug.cgi?id=92318

  • tests/WebViewTest.cpp:
4:42 PM Changeset in webkit [123679] by msaboff@apple.com
  • 12 edits in trunk/Source

Convert HTML parser to handle 8-bit resources without converting to UChar*
https://bugs.webkit.org/show_bug.cgi?id=90321

Reviewed by Geoffrey Garen.

Source/WebCore:

No new tests, no new functionality therefore covered by existing tests.

Changed the parsing of HTML to handle 8-bit strings without converting the
whole string to 16-bits. Primary change was to use the appropriate
character pointer type (LChar* or UChar*) depending on the source string.
This access is abstracted in SegmentedSubstring by getCurrentChar{8,16} and
incrementAndGetCurrentChar{8,16} methods. In SegmentedString, the advance()
and advanceAndUpdateLineNumber() methods have been refactored into a
state machine managed pair of function pointers. The possible functions
have not only the 8 and 16 bitness factored out, they also have the
"exclude line numbers" logic factored out for advanceAndUpdateLineNumber().
This provides a net speed-up even with the 8/16 bit testing.
Other changes involve using String methods to access and compare with the
source data.

  • html/FTPDirectoryDocument.cpp:

(WebCore::FTPDirectoryDocumentParser::append): Changed to use currentChar()
instead of SegmentedString '*' operator.

  • html/parser/HTMLEntityParser.cpp: Changed to use currentChar() instead of

SegmentedString '*' operator.

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::stripLeadingAndTrailingHTMLSpaces): Added 8-bit fast path.

  • html/parser/HTMLSourceTracker.cpp:

(WebCore::HTMLSourceTracker::sourceForToken): Changed to use currentChar() instead of
SegmentedString '*' operator.

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::script): Updated to use new String::dataSize() method.

  • platform/text/SegmentedString.cpp:

(WebCore::SegmentedString::SegmentedString):
(WebCore::SegmentedString::operator=):
(WebCore::SegmentedString::clear):
(WebCore::SegmentedString::append):
(WebCore::SegmentedString::prepend):
(WebCore::SegmentedString::advanceSubstring):
(WebCore::SegmentedString::advance): Changed to be a wrapper that invokes current
advance function.
(WebCore::SegmentedString::advance8): Fast path advance function for 8 bit data.
(WebCore::SegmentedString::advance16): Fast path advance function for 16 bit data.
(WebCore::SegmentedString::advanceAndUpdateLineNumber8IncludeLineNumbers): Fast
path advanceAndUpdateLineNumber for 8 bit data when we need to update the line number.
(WebCore::SegmentedString::advanceAndUpdateLineNumber16IncludeLineNumbers): Fast
path advanceAndUpdateLineNumber for 16 bit data when we need to update the line number.
(WebCore::SegmentedString::advanceSlowCase): Slow case advance function for both
8 and 16 bit advance.
(WebCore::SegmentedString::advanceAndUpdateLineNumberSlowCase): Slow case
advanceAndUpdateLineNumber function for both 8 and 16 bit data.
(WebCore::SegmentedString::advanceEmpty): Advance function when input has been exhausted.

  • platform/text/SegmentedString.h:

(WebCore::SegmentedSubstring::SegmentedSubstring):
(WebCore::SegmentedSubstring::clear):
(SegmentedSubstring):
(WebCore::SegmentedSubstring::is8Bit): New getter.
(WebCore::SegmentedSubstring::appendTo):
(WebCore::SegmentedSubstring::getCurrentChar8): New getter for the 8 bit case.
(WebCore::SegmentedSubstring::getCurrentChar16): New getter for the 16 bit case.
(WebCore::SegmentedSubstring::incrementAndGetCurrentChar8): New wrapper functions
that pre-increments the 8 bit pointer and returns the next character.
(WebCore::SegmentedSubstring::incrementAndGetCurrentChar16): New wrapper functions
that pre-increments the 16 bit pointer and returns the next character.
(WebCore::SegmentedSubstring::currentSubString):
(WebCore::SegmentedSubstring::getCurrentChar):
(WebCore::SegmentedSubstring::incrementAndGetCurrentChar):
(WebCore::SegmentedString::SegmentedString):
(WebCore::SegmentedString::push):
(WebCore::SegmentedString::isEmpty):
(WebCore::SegmentedString::lookAhead):
(WebCore::SegmentedString::lookAheadIgnoringCase):
(WebCore::SegmentedString::advance):
(WebCore::SegmentedString::advanceAndUpdateLineNumber):
(WebCore::SegmentedString::advanceAndASSERT):
(WebCore::SegmentedString::advanceAndASSERTIgnoringCase):
(WebCore::SegmentedString::advancePastNonNewline):
(WebCore::SegmentedString::advancePastNewlineAndUpdateLineNumber):
(WebCore::SegmentedString::currentChar):
(WebCore::SegmentedString::setSlowCase): Set advance function pointers to slow case
functions.
(WebCore::SegmentedString::decrementAndCheckLength): Decrement substring length and
change to slow case functions when only one character left.
(WebCore::SegmentedString::setAdvanceFunctionPointers): Select appropriate advance
functions based on current substring.
(WebCore::SegmentedString::lookAheadInline): Changed to use String::startsWith().
(WebCore::SegmentedString::lookAheadSlowCase):

  • xml/parser/CharacterReferenceParserInlineMethods.h:

(WebCore::consumeCharacterReference): Changed to use currentChar() instead of
SegmentedString '*' operator.

  • xml/parser/MarkupTokenizerBase.h:

(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::nextInputCharacter):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::peek): Changed to use
currentChar() instead of SegmentedString '*' operator.
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::advance):

Source/WTF:

  • wtf/text/WTFString.h:

(WTF::String::dataSize): New method to return the number of bytes
the string requires. This replaces a harcoded calculation based on
length and sizeof(UChar).

4:41 PM Changeset in webkit [123678] by rniwa@webkit.org
  • 3 edits
    1 move
    2 deletes in trunk/LayoutTests

Improve the output of editing/pasteboard/paste-noscript-xhtml.xhtml
https://bugs.webkit.org/show_bug.cgi?id=92307

Reviewed by Tony Chang.

Use dump-as-markup to improve the readability of output, and removed replaced the call to sayHello in iframe's src
content attribute by a call to alert("hello") so that reference error doesn't show up on the result, and moved
the resource from editing/resources to editing/pasteboard/resources as it's not used elsewhere.

  • editing/pasteboard/paste-noscript-xhtml-expected.txt:
  • editing/pasteboard/paste-noscript-xhtml.xhtml:
  • editing/pasteboard/resources/paste-noscript-content.html: Copied from LayoutTests/editing/resources/htmlcontent.html.
  • editing/resources/htmlcontent.html: Removed.
  • platform/chromium-mac/editing/pasteboard/paste-noscript-xhtml-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-noscript-xhtml-expected.txt: Removed.
4:39 PM Changeset in webkit [123677] by kareng@chromium.org
  • 8 edits in branches/chromium/1180/Source/WebCore

Merge 123495 - Files from drag and file <input> should use getMIMETypeForExtension to determine content type.
https://bugs.webkit.org/show_bug.cgi?id=91702

Reviewed by Jian Li.

Awhile back, we changed File to only use getWellKnownMIMETypeForExtension to prevent web
pages from being able to detect what applications a user has installed indirectly through
the MIME types. However, some sites like YouTube's drag and drop uploader use MIME types
that aren't in WebKit's internal list, so we relax the restriction for Files that originate
from an user action.

  • fileapi/File.cpp:

(WebCore::getContentTypeFromFileName):
(WebCore::createBlobDataForFile):
(WebCore::createBlobDataForFileWithName):
(WebCore::createBlobDataForFileWithMetadata):
(WebCore::File::createWithRelativePath):
(WebCore::File::File):

  • fileapi/File.h:

(File):
(WebCore::File::create):
(WebCore::File::createWithName):

  • html/FileInputType.cpp:

(WebCore::FileInputType::createFileList):

  • platform/chromium/ChromiumDataObject.cpp:

(WebCore::ChromiumDataObject::addFilename):

  • platform/gtk/ClipboardGtk.cpp:

(WebCore::ClipboardGtk::files):

  • platform/mac/ClipboardMac.mm:

(WebCore::ClipboardMac::files):

  • platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::files):

  • platform/win/ClipboardWin.cpp:

(WebCore::ClipboardWin::files):

TBR=dcheng@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10821032

4:32 PM Changeset in webkit [123676] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] fix double->float warnings in CCLayerTreeHostCommonTest.cpp
https://bugs.webkit.org/show_bug.cgi?id=92271

Patch by Scott Graham <scottmg@chromium.org> on 2012-07-25
Reviewed by Adrienne Walker.

Fix compile warnings on Windows.

  • tests/CCLayerTreeHostCommonTest.cpp:
4:29 PM Changeset in webkit [123675] by rniwa@webkit.org
  • 23 edits in trunk/Source/WebCore

Unreviewed, rolling out r123625 and r123672.
http://trac.webkit.org/changeset/123625
http://trac.webkit.org/changeset/123672
https://bugs.webkit.org/show_bug.cgi?id=92315

Broke Windows and gcc builds (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-25

  • platform/AutodrainedPool.h:

(AutodrainedPool):

  • platform/ContentType.h:

(ContentType):

  • platform/ContextMenu.h:

(ContextMenu):

  • platform/ContextMenuItem.h:

(ContextMenuItem):

  • platform/Cursor.h:

(WebCore::SharedCursor::SharedCursor):
(Cursor):

  • platform/KURL.h:

(WebCore::KURL::KURL):
(KURL):

  • platform/KURLGooglePrivate.h:

(KURLGooglePrivate):

  • platform/PODRedBlackTree.h:

(WebCore::PODRedBlackTree::PODRedBlackTree):

  • platform/Pasteboard.h:

(Pasteboard):

  • platform/PlatformEvent.h:

(WebCore::PlatformEvent::PlatformEvent):

  • platform/PlatformKeyboardEvent.h:

(PlatformKeyboardEvent):

  • platform/PlatformMouseEvent.h:

(PlatformMouseEvent):

  • platform/PlatformPasteboard.h:

(PlatformPasteboard):

  • platform/PlatformTouchEvent.h:

(PlatformTouchEvent):

  • platform/PlatformWheelEvent.h:

(PlatformWheelEvent):

  • platform/RunLoop.h:

(TimerBase):

  • platform/ScrollAnimator.h:

(ScrollAnimator):

  • platform/ScrollAnimatorNone.h:

(ScrollAnimatorNone):

  • platform/SharedBuffer.h:

(SharedBuffer):

  • platform/WheelFlingPlatformGestureCurve.h:

(WheelFlingPlatformGestureCurve):

  • platform/Widget.h:

(Widget):

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::doUpdateResourceRequest):

4:16 PM Changeset in webkit [123674] by psolanki@apple.com
  • 6 edits in trunk/Source/WebKit/mac

Remove catchesDelegateExceptions from WebViewData and related accessor methods
https://bugs.webkit.org/show_bug.cgi?id=90898

Reviewed by Darin Adler.

Remove catchesDelegateException ivar from WebViewData and all its accesor methods from
WebView. All uses of this flag in WebKit set it to YES and no one calls
_setCatchesDelegateExceptions with NO.

  • WebCoreSupport/WebDragClient.mm:

(WebDragClient::startDrag):

  • WebView/WebDelegateImplementationCaching.mm:

(CallDelegate):
(CallDelegateReturningFloat):
(CallDelegateReturningBoolean):
(CallResourceLoadDelegateReturningBoolean):
(CallFormDelegate):
(CallFormDelegateReturningBoolean):

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _policyDelegateForwarder]):
(-[WebView _UIDelegateForwarder]):
(-[WebView _editingDelegateForwarder]):
(-[_WebSafeForwarder initWithTarget:defaultTarget:]):
(-[_WebSafeForwarder forwardInvocation:]):

  • WebView/WebViewData.h:
  • WebView/WebViewPrivate.h:
4:14 PM Changeset in webkit [123673] by jpetsovits@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Rephrase suspend/resume condition to guard against crashes
https://bugs.webkit.org/show_bug.cgi?id=92300
PR 182125

Reviewed by George Staikos.

When the compositor is removed from a WebPage, it might
already have unset its context, and issuing a call to
BackingStore::buffer() would therefore cause a crash.
Just guarding buffer() from this crash isn't fully
correct, because then we wouldn't suspend rendering
for a compositor that had been previously enabled.

Instead, change the condition to suspend/resume in
WebPagePrivate::setCompositor() to focus on the
object that delivers us the buffer. If we can't
listen to the context or buffer being set, better
just take the compositor object itself to determine
whether we have something valid or not... and hope
that they give us a valid context & buffer in all
situations when we can actually be rendering.

Also check compositor->context() in buffer() to be
non-zero before accessing the context's buffer,
because more defensive coding can't hurt here.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::buffer):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setCompositor):

4:04 PM Changeset in webkit [123672] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Windows build fix attempt after r123625.

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::doUpdateResourceRequest):

3:59 PM Changeset in webkit [123671] by kseo@webkit.org
  • 3 edits in trunk/Source/WebCore

Read tag names and attributes from the saved tokens in HTMLTreeBuilder::resetInsertionModeAppropriately.
https://bugs.webkit.org/show_bug.cgi?id=92240

Reviewed by Adam Barth.

This is a follow-up patch for r123577. Added ItemType enum to HTMLStackItem to handle
the context element case.

No new tests, covered by existing tests.

  • html/parser/HTMLStackItem.h:

(WebCore::HTMLStackItem::create):
(WebCore::HTMLStackItem::HTMLStackItem):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):

3:41 PM Changeset in webkit [123670] by rafael.lobo@openbossa.org
  • 51 edits in trunk/LayoutTests

[Qt] platform/qt/tables/mozilla tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91242

Unreviewed gardening.

  • platform/qt-5.0/Skipped:
  • platform/qt/tables/mozilla/bugs/adforce_imgis_com-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug102145-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug102145-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug102145-3-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug102145-4-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug10269-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug10296-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug103533-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1067-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1067-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug106795-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug11321-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug133948-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug154780-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug15933-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1818-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1818-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1818-4-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug219693-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug219693-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug221784-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug221784-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug22513-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug23072-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug23994-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug25074-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug25367-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug26553-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug3037-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug3037-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug32447-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug3309-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug34538-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug45350-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug53690-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug53690-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug55789-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug56201-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug56405-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug641-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug641-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug8361-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug88524-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug9072-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug92647-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug97383-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug98196-expected.txt:
  • platform/qt/tables/mozilla/marvin/tfoot_char-expected.png:
  • platform/qt/tables/mozilla/marvin/tfoot_char-expected.txt:
3:27 PM Changeset in webkit [123669] by Lucas Forschler
  • 4 edits in branches/safari-536.26-branch/Source

Versioning.

3:19 PM Changeset in webkit [123668] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium/mac] Remove mac_bundle_resources section from WebCore.gyp
https://bugs.webkit.org/show_bug.cgi?id=92207

Reviewed by Tony Chang.

It's no longer needed after http://crrev.com/148290 and
http://crrev.com/148187.

  • WebCore.gyp/WebCore.gyp:
3:15 PM Changeset in webkit [123667] by caio.oliveira@openbossa.org
  • 11 edits in trunk/Source

Source/JavaScriptCore: Create a specialized pair for use in HashMap iterators
https://bugs.webkit.org/show_bug.cgi?id=92137

Reviewed by Ryosuke Niwa.

Update a couple of sites that relied on the fact that "contents" of iterators were
std::pairs.

  • profiler/Profile.cpp:

(JSC): This code kept a vector of the pairs that were the "contents" of the iterators. This
is changed to use a KeyValuePair. We make use HashCount's ValueType (which represents only
the key) to get the proper key parameter for KeyValuePair.

  • tools/ProfileTreeNode.h:

(ProfileTreeNode): Use HashMap::ValueType to declare the type of the contents of the hash
instead of declaring it manually. This will make use of the new KeyValuePair.

Source/WebKit2: Create a specialized struct for use in HashMap iterators
https://bugs.webkit.org/show_bug.cgi?id=92137

Reviewed by Ryosuke Niwa.

  • Platform/CoreIPC/ArgumentCoders.h: Add encode/decode for KeyValuePair.

Source/WTF: Create a specialized pair for use in HashMap iterators
https://bugs.webkit.org/show_bug.cgi?id=92137

Reviewed by Ryosuke Niwa.

The type used for internal storage in HashMap is exposed in its interface as iterator
"contents". Currently HashMap uses std::pair<>, which this patch replaces with
KeyValuePair.

Having this specialized structure will allow us to customize the members to be called
key/value, improving readability in code using HashMap iterators. They are still called
first/second to separate this change from the mechanical change of updating callsites.

  • wtf/HashIterators.h:

(HashTableConstKeysIterator):
(HashTableConstValuesIterator):
(HashTableKeysIterator):
(HashTableValuesIterator):
Use KeyValuePair instead of std::pair when defining the iterators.

  • wtf/HashMap.h:

(WTF):
(WTF::KeyValuePairKeyExtractor::extract):
(HashMap):
Remove PairFirstExtractor. Add and use the KeyValuePair corresponding extractor.

(WTF::HashMapValueTraits::isEmptyValue): Use KeyValuePairHashTraits for HashMaps.
(WTF::HashMapTranslator::translate):
(WTF::HashMapTranslatorAdapter::translate):
The traits of the mapped value is now called ValueTraits instead of SecondTraits.

  • wtf/HashTable.h:

(WTF::hashTableSwap): Add specialization for swapping KeyValuePairs.
(WTF): Remove now unneeded specialization for std::pairs.

  • wtf/HashTraits.h:

(KeyValuePair):
(WTF::KeyValuePair::KeyValuePair):
(WTF):
Specialized pair. In the future difference from pair should be the member names.

(KeyValuePairHashTraits):
(WTF::KeyValuePairHashTraits::emptyValue):
(WTF::KeyValuePairHashTraits::constructDeletedValue):
(WTF::KeyValuePairHashTraits::isDeletedValue):
These traits are analogous to PairHashTraits but for KeyValuePair.

  • wtf/RefPtrHashMap.h: Use KeyValuePairHashTraits.
3:07 PM Changeset in webkit [123666] by danakj@chromium.org
  • 12 edits in trunk/Source

[chromium] Move WebFilterOperations from RenderPassDrawQuad to RenderPass
https://bugs.webkit.org/show_bug.cgi?id=91885

Reviewed by Adrienne Walker.

Source/WebCore:

We move the filter operations to CCRenderPass to avoid having
variable-length data in a WebCompositorQuad in order to serialize,
and also to avoid requiring a virtual destructor for the quad
classes.

The drawFrame method now takes a CCRenderPassIdHashMap in order
to connect RenderPass quads to their source RenderPass.

Covered by existing tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::decideRenderPassAllocationsForFrame):
(WebCore::LayerRendererChromium::drawFrame):
(WebCore::LayerRendererChromium::beginDrawingFrame):
(WebCore::LayerRendererChromium::drawBackgroundFilters):
(WebCore::LayerRendererChromium::drawRenderPassQuad):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::drawLayers):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(WebCore::CCRenderPass::filters):
(WebCore::CCRenderPass::setFilters):
(CCRenderPass):
(WebCore::CCRenderPass::backgroundFilters):
(WebCore::CCRenderPass::setBackgroundFilters):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:

(WebCore::CCRenderPassDrawQuad::create):
(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:

(CCRenderPassDrawQuad):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::appendQuads):

  • platform/graphics/chromium/cc/CCRenderer.h:

(CCRenderer):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/LayerRendererChromiumTest.cpp:

(FakeCCRendererClient::FakeCCRendererClient):
(FakeCCRendererClient::rootRenderPass):
(FakeCCRendererClient::renderPassesInDrawOrder):
(FakeCCRendererClient::renderPasses):
(FakeCCRendererClient):
(TEST_F):
(TEST):

2:48 PM WebKit Team edited by jochen@chromium.org
moved myself from committers to reviewers (diff)
2:47 PM Changeset in webkit [123665] by reed@google.com
  • 2 edits in trunk/Source/WebCore

fix test in beginLayerClippedToImage to check for immutability if we're going to do a shallow-copy
https://bugs.webkit.org/show_bug.cgi?id=92276

Reviewed by Stephen White.

PlatformContextSkia::beginLayerClippedToImage

This function wants to apply the provided ImageBuffer as a clip. Skia does not support this natively yet,
so the code makes a "copy" of that imageBuffer, to be applied later. The old code, wanting to avoid a
deep copy if possible, checked for the presence of a SkPixelRef. If it found one, it made a shallow copy.
This is flawed, since the contents of a pixelref are not guaranteed to be immutable. The new code checks
against this attribute: if the bitmap is "immutable" then we can make a shallow-copy, else we make a
deep copy.

No new tests. Existing svg layouttests work w/ or w/out this change, but at the next Skia deps roll, we see
failures w/o this change. The change is more "correct", though the problem case does not exhibit itself until
Skia rev. 4722 or later lands.

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::beginLayerClippedToImage):

2:41 PM Changeset in webkit [123664] by abarth@webkit.org
  • 2 edits in trunk/Tools

Jochen is our a newest reviewer!

  • Scripts/webkitpy/common/config/committers.py:
2:39 PM Changeset in webkit [123663] by commit-queue@webkit.org
  • 124 edits
    16 adds in trunk/LayoutTests

[Qt] fast/block/margin-collapse tests need update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=92274

Patch by Luciano Wolf <Luciano Miguel Wolf> on 2012-07-25
Reviewed by Alexis Menard.

  • platform/qt-5.0/Skipped:
  • platform/qt/fast/block/margin-collapse/001-expected.png:
  • platform/qt/fast/block/margin-collapse/001-expected.txt:
  • platform/qt/fast/block/margin-collapse/002-expected.png:
  • platform/qt/fast/block/margin-collapse/002-expected.txt:
  • platform/qt/fast/block/margin-collapse/003-expected.png:
  • platform/qt/fast/block/margin-collapse/003-expected.txt:
  • platform/qt/fast/block/margin-collapse/004-expected.png:
  • platform/qt/fast/block/margin-collapse/004-expected.txt:
  • platform/qt/fast/block/margin-collapse/005-expected.png:
  • platform/qt/fast/block/margin-collapse/005-expected.txt:
  • platform/qt/fast/block/margin-collapse/006-expected.png:
  • platform/qt/fast/block/margin-collapse/006-expected.txt:
  • platform/qt/fast/block/margin-collapse/010-expected.png:
  • platform/qt/fast/block/margin-collapse/010-expected.txt:
  • platform/qt/fast/block/margin-collapse/011-expected.png:
  • platform/qt/fast/block/margin-collapse/011-expected.txt:
  • platform/qt/fast/block/margin-collapse/012-expected.png:
  • platform/qt/fast/block/margin-collapse/012-expected.txt:
  • platform/qt/fast/block/margin-collapse/015-expected.png:
  • platform/qt/fast/block/margin-collapse/015-expected.txt:
  • platform/qt/fast/block/margin-collapse/016-expected.png:
  • platform/qt/fast/block/margin-collapse/016-expected.txt:
  • platform/qt/fast/block/margin-collapse/017-expected.png:
  • platform/qt/fast/block/margin-collapse/017-expected.txt:
  • platform/qt/fast/block/margin-collapse/018-expected.png:
  • platform/qt/fast/block/margin-collapse/018-expected.txt:
  • platform/qt/fast/block/margin-collapse/019-expected.png:
  • platform/qt/fast/block/margin-collapse/019-expected.txt:
  • platform/qt/fast/block/margin-collapse/020-expected.png:
  • platform/qt/fast/block/margin-collapse/020-expected.txt:
  • platform/qt/fast/block/margin-collapse/021-expected.png:
  • platform/qt/fast/block/margin-collapse/021-expected.txt:
  • platform/qt/fast/block/margin-collapse/022-expected.png:
  • platform/qt/fast/block/margin-collapse/022-expected.txt:
  • platform/qt/fast/block/margin-collapse/025-expected.png:
  • platform/qt/fast/block/margin-collapse/025-expected.txt:
  • platform/qt/fast/block/margin-collapse/026-expected.png:
  • platform/qt/fast/block/margin-collapse/026-expected.txt:
  • platform/qt/fast/block/margin-collapse/027-expected.png:
  • platform/qt/fast/block/margin-collapse/027-expected.txt:
  • platform/qt/fast/block/margin-collapse/028-expected.png:
  • platform/qt/fast/block/margin-collapse/028-expected.txt:
  • platform/qt/fast/block/margin-collapse/029-expected.png:
  • platform/qt/fast/block/margin-collapse/029-expected.txt:
  • platform/qt/fast/block/margin-collapse/030-expected.png:
  • platform/qt/fast/block/margin-collapse/030-expected.txt:
  • platform/qt/fast/block/margin-collapse/031-expected.png:
  • platform/qt/fast/block/margin-collapse/031-expected.txt:
  • platform/qt/fast/block/margin-collapse/032-expected.png:
  • platform/qt/fast/block/margin-collapse/032-expected.txt:
  • platform/qt/fast/block/margin-collapse/033-expected.png:
  • platform/qt/fast/block/margin-collapse/033-expected.txt:
  • platform/qt/fast/block/margin-collapse/034-expected.png:
  • platform/qt/fast/block/margin-collapse/034-expected.txt:
  • platform/qt/fast/block/margin-collapse/035-expected.png:
  • platform/qt/fast/block/margin-collapse/035-expected.txt:
  • platform/qt/fast/block/margin-collapse/037-expected.png:
  • platform/qt/fast/block/margin-collapse/037-expected.txt:
  • platform/qt/fast/block/margin-collapse/038-expected.png:
  • platform/qt/fast/block/margin-collapse/038-expected.txt:
  • platform/qt/fast/block/margin-collapse/039-expected.png:
  • platform/qt/fast/block/margin-collapse/039-expected.txt:
  • platform/qt/fast/block/margin-collapse/040-expected.png:
  • platform/qt/fast/block/margin-collapse/040-expected.txt:
  • platform/qt/fast/block/margin-collapse/041-expected.png:
  • platform/qt/fast/block/margin-collapse/041-expected.txt:
  • platform/qt/fast/block/margin-collapse/042-expected.png:
  • platform/qt/fast/block/margin-collapse/042-expected.txt:
  • platform/qt/fast/block/margin-collapse/043-expected.png:
  • platform/qt/fast/block/margin-collapse/043-expected.txt:
  • platform/qt/fast/block/margin-collapse/044-expected.png:
  • platform/qt/fast/block/margin-collapse/044-expected.txt:
  • platform/qt/fast/block/margin-collapse/045-expected.png:
  • platform/qt/fast/block/margin-collapse/045-expected.txt:
  • platform/qt/fast/block/margin-collapse/055-expected.png:
  • platform/qt/fast/block/margin-collapse/055-expected.txt:
  • platform/qt/fast/block/margin-collapse/056-expected.png:
  • platform/qt/fast/block/margin-collapse/056-expected.txt:
  • platform/qt/fast/block/margin-collapse/057-expected.png:
  • platform/qt/fast/block/margin-collapse/057-expected.txt:
  • platform/qt/fast/block/margin-collapse/058-expected.png:
  • platform/qt/fast/block/margin-collapse/058-expected.txt:
  • platform/qt/fast/block/margin-collapse/059-expected.png:
  • platform/qt/fast/block/margin-collapse/059-expected.txt:
  • platform/qt/fast/block/margin-collapse/062-expected.png:
  • platform/qt/fast/block/margin-collapse/062-expected.txt:
  • platform/qt/fast/block/margin-collapse/063-expected.png:
  • platform/qt/fast/block/margin-collapse/063-expected.txt:
  • platform/qt/fast/block/margin-collapse/100-expected.png:
  • platform/qt/fast/block/margin-collapse/100-expected.txt:
  • platform/qt/fast/block/margin-collapse/101-expected.png:
  • platform/qt/fast/block/margin-collapse/101-expected.txt:
  • platform/qt/fast/block/margin-collapse/102-expected.png:
  • platform/qt/fast/block/margin-collapse/102-expected.txt:
  • platform/qt/fast/block/margin-collapse/103-expected.png:
  • platform/qt/fast/block/margin-collapse/103-expected.txt:
  • platform/qt/fast/block/margin-collapse/104-expected.png:
  • platform/qt/fast/block/margin-collapse/104-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/001-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/001-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/002-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/002-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/003-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/003-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/004-expected.png:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/004-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/005-expected.png:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/005-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/006-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/006-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/010-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/010-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/011-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/011-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/012-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/012-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/015-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/015-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/016-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/016-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/017-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/017-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/018-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/018-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/019-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/019-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/020-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/020-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/021-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/021-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/022-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/022-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/025-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
  • platform/qt/fast/block/margin-collapse/empty-clear-blocks-expected.png:
  • platform/qt/fast/block/margin-collapse/empty-clear-blocks-expected.txt:
  • platform/qt/fast/block/margin-collapse/negative-margins-expected.png:
  • platform/qt/fast/block/margin-collapse/negative-margins-expected.txt:
2:33 PM Changeset in webkit [123662] by commit-queue@webkit.org
  • 5 edits in trunk

It is invalid when both numberOfInputChannels and numberOfOutputChannels to be zero in JavaScriptAudioNode.
https://bugs.webkit.org/show_bug.cgi?id=91364

Patch by Li Yin <li.yin@intel.com> on 2012-07-25
Reviewed by Kenneth Russell.

Source/WebCore:

Spec: http://www.w3.org/TR/webaudio/#JavaScriptAudioNode-section
It is invalid for both numberOfInputChannels and numberOfOutputChannels to be zero.

Test: webaudio/javascriptaudionode.html

  • Modules/webaudio/JavaScriptAudioNode.cpp:

(WebCore::JavaScriptAudioNode::create):

LayoutTests:

Add tests for (numberOfInputChannels, numberOfOutputChannels) to be (0, 0),(0, 1),(0, 2),(1, 0) and (2, 0).

  • webaudio/javascriptaudionode-expected.txt:
  • webaudio/javascriptaudionode.html:
2:28 PM Changeset in webkit [123661] by jochen@chromium.org
  • 9 edits in trunk/Tools

[chromium] don't use webkit_support methods directly from test runners but through the test delegate
https://bugs.webkit.org/show_bug.cgi?id=92256

Reviewed by Adam Barth.

This will allow for the content_shell to provide its own implementation
for setting the Gamepad data instead.

  • DumpRenderTree/chromium/TestRunner/GamepadController.cpp:

(GamepadController::setDelegate):
(GamepadController::reset):
(GamepadController::connect):
(GamepadController::disconnect):
(GamepadController::setId):
(GamepadController::setButtonCount):
(GamepadController::setButtonData):
(GamepadController::setAxisCount):
(GamepadController::setAxisData):

  • DumpRenderTree/chromium/TestRunner/GamepadController.h:

(GamepadController):

  • DumpRenderTree/chromium/TestRunner/TestDelegate.h:

(WebKit):
(TestDelegate):

  • DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:

(TestInterfaces::Internal):
(TestInterfaces::Internal::~Internal):
(TestInterfaces::Internal::setDelegate):
(TestInterfaces::setDelegate):

  • DumpRenderTree/chromium/TestRunner/TestInterfaces.h:

(TestInterfaces):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::createMainWindow):
(TestShell::~TestShell):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::setGamepadData):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

2:25 PM Changeset in webkit [123660] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Update about:config lists
https://bugs.webkit.org/show_bug.cgi?id=92118

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-25
Reviewed by Rob Buis.

Remove features from list that have either been removed from WebKit
or that have been moved from one list to another.

  • WebCoreSupport/AboutDataEnableFeatures.in:
  • WebCoreSupport/AboutDataHaveFeatures.in:
  • WebCoreSupport/AboutDataUseFeatures.in:
2:19 PM Changeset in webkit [123659] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium expectations change.

  • platform/chromium/TestExpectations:
2:13 PM Changeset in webkit [123658] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Crash when calling PluginView::pluginFocusOrWindowFocusChanged when the web page is null
https://bugs.webkit.org/show_bug.cgi?id=92289
<rdar://problem/11785352>

Reviewed by Andreas Kling.

Plug-in views that outlive their containing web page for various reasons (such as being protected from
destruction) need to null check the web page.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::pluginFocusOrWindowFocusChanged):
(WebKit::PluginView::setComplexTextInputState):

2:08 PM Changeset in webkit [123657] by commit-queue@webkit.org
  • 17 edits
    3 deletes in trunk/LayoutTests

[Qt] fast/borders rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92146

Patch by Luciano Wolf <Luciano Miguel Wolf> on 2012-07-25
Reviewed by Csaba Osztrogonác.

Updated patch started by Alexis. This one removes old expected results
found inside qt-5.0 directory and updates Skipped files as well.

  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/fast/borders/bidi-002-expected.txt: Removed.
  • platform/qt-5.0/fast/borders/bidi-009a-expected.txt: Removed.
  • platform/qt-5.0/fast/borders/bidi-012-expected.txt: Removed.
  • platform/qt/fast/borders/border-image-slice-constrained-expected.txt:
  • platform/qt/fast/borders/borderRadiusArcs01-expected.txt:
  • platform/qt/fast/borders/borderRadiusDouble01-expected.txt:
  • platform/qt/fast/borders/borderRadiusDouble02-expected.txt:
  • platform/qt/fast/borders/borderRadiusDouble03-expected.txt:
  • platform/qt/fast/borders/borderRadiusGroove01-expected.txt:
  • platform/qt/fast/borders/borderRadiusGroove02-expected.txt:
  • platform/qt/fast/borders/borderRadiusInset01-expected.txt:
  • platform/qt/fast/borders/borderRadiusOutset01-expected.txt:
  • platform/qt/fast/borders/borderRadiusRidge01-expected.txt:
  • platform/qt/fast/borders/borderRadiusSolid01-expected.txt:
  • platform/qt/fast/borders/borderRadiusSolid02-expected.txt:
  • platform/qt/fast/borders/borderRadiusSolid03-expected.txt:
  • platform/qt/fast/borders/borderRadiusSolid04-expected.txt:
  • platform/qt/fast/borders/table-borders-expected.txt:
1:59 PM Changeset in webkit [123656] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium expectations change.

  • platform/chromium/TestExpectations:
1:52 PM Changeset in webkit [123655] by rniwa@webkit.org
  • 1 edit
    60 adds in trunk/PerformanceTests

Import more replay performance tests from Mozilla's Tp5 test suite
https://bugs.webkit.org/show_bug.cgi?id=92229

Reviewed by Andreas Kling.

Add more replay tests based on Mozilla's Tp5 test suite [1]. Unfortunately,
we cannot import all URLs because some of them are not archived on archive.org
and others do not replay well on web-page-replay. Nonethless, we're still adding
60+ URLs in this patch.

[1] http://people.mozilla.org/~jmaher/tp5.manifest

  • Replay/Chinese: Added.
  • Replay/Chinese/chinaz.com.replay: Added.
  • Replay/Chinese/www.163.com.replay: Added.
  • Replay/Chinese/www.alipay.com.replay: Added.
  • Replay/Chinese/www.baidu.com.replay: Added.
  • Replay/Chinese/www.csdn.net.replay: Added.
  • Replay/Chinese/www.douban.com.replay: Added.
  • Replay/Chinese/www.hao123.com.replay: Added.
  • Replay/Chinese/www.xinhuanet.com.replay: Added.
  • Replay/Chinese/www.xunlei.com.replay: Added.
  • Replay/Chinese/www.youku.com.replay: Added.
  • Replay/English: Added.
  • Replay/English/beatonna.livejournal.com.replay: Added.
  • Replay/English/cakewrecks.blogspot.com.replay: Added.
  • Replay/English/chemistry.about.com.replay: Added.
  • Replay/English/digg.com.replay: Added.
  • Replay/English/en.wikipedia.org-rorschach_test.replay: Added.
  • Replay/English/icanhascheezburger.com.replay: Added.
  • Replay/English/imgur.com-gallery.replay: Added.
  • Replay/English/online.wsj.com.replay: Added.
  • Replay/English/stockoverflow.com-best-comment.replay: Added.
  • Replay/English/www.alibaba.com.replay: Added.
  • Replay/English/www.amazon.com-kindle.replay: Added.
  • Replay/English/www.apple.com.replay: Added.
  • Replay/English/www.cnet.com.replay: Added.
  • Replay/English/www.dailymotion.com.replay: Added.
  • Replay/English/www.ehow.com-prevent-fire.replay: Added.
  • Replay/English/www.filestube.com-amy-adams.replay: Added.
  • Replay/English/www.foxnews.replay: Added.
  • Replay/English/www.huffingtonpost.com.replay: Added.
  • Replay/English/www.imdb.com-twilight.replay: Added.
  • Replay/English/www.mozilla.com-all-order.replay: Added.
  • Replay/English/www.php.net.replay: Added.
  • Replay/English/www.reddit.com.replay: Added.
  • Replay/English/www.telegraph.co.uk.replay: Added.
  • Replay/English/www.w3.org-htmlcss.replay: Added.
  • Replay/English/www.w3schools.com-html.replay: Added.
  • Replay/English/www.youtube.com-music.replay: Added.
  • Replay/French: Added.
  • Replay/French/www.orange.fr.replay: Added.
  • Replay/German: Added.
  • Replay/Italian: Added.
  • Replay/Italian/www.repubblica.it.replay: Added.
  • Replay/Japanese/entameblog.seesaa.net.replay: Added.
  • Replay/Japanese/www.hatena.ne.jp.replay: Added.
  • Replay/Japanese/www.nicovideo.jp.replay: Added.
  • Replay/Korean: Added.
  • Replay/Korean/www.naver.com.replay: Added.
  • Replay/Persian: Added.
  • Replay/Persian/blogfa.com.replay: Added.
  • Replay/Polish: Added.
  • Replay/Polish/www.wp.pl.replay: Added.
  • Replay/Portuguese: Added.
  • Replay/Portuguese/www.uol.com.br.replay: Added.
  • Replay/Russian: Added.
  • Replay/Russian/vkontakte.ru-help.replay: Added.
  • Replay/Russian/www.rambler.ru.replay: Added.
  • Replay/Russian/www.ucoz.ru.replay: Added.
  • Replay/Russian/www.yandex.ru.replay: Added.
  • Replay/Spanish: Added.
  • Replay/Spanish/www.taringa.net.replay: Added.
1:47 PM Changeset in webkit [123654] by shawnsingh@chromium.org
  • 10 edits in trunk/Source

[chromium] Refactor CCLayerTreeHostCommon: move root layer special case initialization into internal code.
https://bugs.webkit.org/show_bug.cgi?id=88953

Reviewed by Adrienne Walker.

Source/WebCore:

This is part 1 of trying to reduce the root layer special
case. This tries to reduce the special-ness of the root layer from
the perspective of outside code.

After this patch, code that uses calcDrawTransforms() no longer
needs to initialize the root layer's surface, and no longer needs
to manually append the root layer to the renderSurfaceLayerList.

Unit tests were also updated (much cleaner!) to account for this change.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::updateLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore):
(WebCore::setupRootLayerAndSurfaceForRecursion):
(WebCore::CCLayerTreeHostCommon::calculateDrawTransforms):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:

(CCLayerTreeHostCommon):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):

Source/WebKit/chromium:

Unit tests updated to account for the new less-special root layer setup.

  • most test cases just needed to remove root->renderSurface()->setContentBounds(), createRenderSurface(), and renderSurfaceLayerList.append().
  • some test cases originally relied on setting some awkward unconventional bounds of the rootLayer that were different than the rootLayer's renderSurface. these tests are updated.
  • a few minor cleanups otherwise.
  • tests/CCDamageTrackerTest.cpp:

(WebKitTests::executeCalculateDrawTransformsAndVisibility):

  • tests/CCLayerIteratorTest.cpp:
  • tests/CCLayerTreeHostCommonTest.cpp:
  • tests/CCOcclusionTrackerTest.cpp:

(WebKitTests::CCOcclusionTrackerTest::calcDrawEtc):

1:44 PM Changeset in webkit [123653] by commit-queue@webkit.org
  • 10 edits in trunk/Source

FileSystem should provide a way to delete filesystem.
https://bugs.webkit.org/show_bug.cgi?id=91861

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-07-25
Reviewed by Adam Barth.

Source/WebCore:

We will add a test when we wire-up the feature to Inspector.

  • Modules/filesystem/LocalFileSystem.cpp: Add deleteFileSystem

(WebCore::deleteFileSystem):
(WebCore):
(WebCore::LocalFileSystem::deleteFileSystem):

  • Modules/filesystem/LocalFileSystem.h:

(LocalFileSystem):

  • platform/AsyncFileSystem.cpp: Add deleteFileSystem

(WebCore):
(WebCore::AsyncFileSystem::deleteFileSystem):

  • platform/AsyncFileSystem.h:

(AsyncFileSystem):

  • platform/blackberry/AsyncFileSystemBlackBerry.cpp: Add deleteFileSystem

(WebCore::AsyncFileSystem::deleteFileSystem):
(WebCore):

  • platform/gtk/AsyncFileSystemGtk.cpp: Add deleteFileSystem

(WebCore::AsyncFileSystem::deleteFileSystem):
(WebCore):

Source/WebKit/chromium:

  • public/WebFrameClient.h:

(WebFrameClient):
(WebKit::WebFrameClient::deleteFileSystem):

  • src/LocalFileSystemChromium.cpp: Add deleteFileSystem

(WebCore::deleteFileSystemNotAllowed):
(WebCore):
(WebCore::LocalFileSystem::deleteFileSystem):

1:34 PM Changeset in webkit [123652] by commit-queue@webkit.org
  • 19 edits
    4 copies in trunk

[WK2][WTR] LayoutTestController.sendWebIntentResponse() needs to be implemented
https://bugs.webkit.org/show_bug.cgi?id=92227

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-25
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add new InjectedBundleIntentRequest class to wrap WebCore's
IntentRequest and use it in InjectedBundle's
didReceiveIntentForFrame callback. The WebKitTestRunner needs
to be able to reply to a Web intent request in order to
implement LayoutTestController.sendWebIntentResponse(). As
a consequence, passing a WebIntentData type in not enough.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Shared/API/c/WKBase.h:
  • Shared/APIObject.h:
  • Shared/IntentData.cpp:

(WebKit::IntentData::IntentData):
(WebKit):

  • Shared/IntentData.h:

(WebCore):
(WebKit::IntentData::IntentData):
(IntentData):

  • Target.pri:
  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:

(WebKit):

  • WebProcess/InjectedBundle/API/c/WKBundleIntentRequest.cpp: Copied from Source/WebKit2/Shared/IntentData.cpp.

(WKBundleIntentRequestGetTypeID):
(WKBundleIntentRequestCopyIntent):
(WKBundleIntentRequestPostResult):
(WKBundleIntentRequestPostFailure):

  • WebProcess/InjectedBundle/API/c/WKBundleIntentRequest.h: Copied from Source/WebKit2/Shared/IntentData.h.
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundleIntentRequest.cpp: Copied from Source/WebKit2/Shared/IntentData.cpp.

(WebKit):
(WebKit::InjectedBundleIntentRequest::create):
(WebKit::InjectedBundleIntentRequest::InjectedBundleIntentRequest):
(WebKit::InjectedBundleIntentRequest::postResult):
(WebKit::InjectedBundleIntentRequest::postFailure):
(WebKit::InjectedBundleIntentRequest::intent):

  • WebProcess/InjectedBundle/InjectedBundleIntentRequest.h: Copied from Source/WebKit2/Shared/IntentData.h.

(WebCore):
(WebKit):
(InjectedBundleIntentRequest):
(WebKit::InjectedBundleIntentRequest::type):

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::didReceiveIntentForFrame):

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:

(WebKit):
(InjectedBundlePageLoaderClient):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchIntent):

Tools:

Implement LayoutTestController.sendWebIntentResponse() so
that a test case can reply to a Web intent request and
test this functionality.

In order to support this functionality, we need to keep
a pointer to the current intent request in
InjectedBundlePage::didReceiveIntentForFrame() so that
we can reuse it later in
LayoutTestController::sendWebIntentResponse().

The following tests need this functionality:

  • webintents/web-intents-failure.html
  • webintents/web-intents-reply.html
  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::didReceiveIntentForFrame):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

(InjectedBundlePage):
(WTR::InjectedBundlePage::currentIntentRequest):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::sendWebIntentResponse):
(WTR):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(LayoutTestController):

1:19 PM Changeset in webkit [123651] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Add more jsdocs to InjectedScriptSource.js
https://bugs.webkit.org/show_bug.cgi?id=92255

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-07-25
Reviewed by Pavel Feldman.

  • inspector/InjectedScriptSource.js:
1:15 PM Changeset in webkit [123650] by msaboff@apple.com
  • 2 edits in trunk/LayoutTests

r123492 Changed output of msub-anonymous-child-render-crash.html LayoutTest
https://bugs.webkit.org/show_bug.cgi?id=92284

Rubber-stamped by Beth Dakin.

Rebaselined test output.

  • mathml/msub-anonymous-child-render-crash-expected.txt:

r123492 changed the way inline-tables are rendered.

1:06 PM Changeset in webkit [123649] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Crash when a web page is closed with outstanding scrolling thread barriers
https://bugs.webkit.org/show_bug.cgi?id=92280
<rdar://problem/11630200>

Reviewed by Andreas Kling.

There was a check in forceRepaintAsync to handle the drawing area going away before the block had
been invoked, but this check needs to be done earlier (as the FIXME suggested).
Move this check to dispatchAfterEnsuringUpdatedScrollPosition instead.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::forceRepaintAsync):
(WebKit::TiledCoreAnimationDrawingArea::dispatchAfterEnsuringUpdatedScrollPosition):

1:06 PM Changeset in webkit [123648] by Lucas Forschler
  • 1 copy in branches/safari-536.26-branch

New branch.

1:05 PM Changeset in webkit [123647] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][WK2][WTR] Alt, Shift and Ctrl keys are not handled by EventSenderProxy.
https://bugs.webkit.org/show_bug.cgi?id=92241

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-07-25
Reviewed by Kenneth Rohde Christiansen.

Alt, Shift and Ctrl keys were not handled by EventSenderProxy.
It caused failure of fast/events/keydown-leftright-keys.html test.

  • WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Added handling of Alt, Shift and Ctrl keys.

(WTR::keyName):

12:52 PM Changeset in webkit [123646] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium expectations change to mark tests as slow.

  • platform/chromium/TestExpectations:
12:50 PM Changeset in webkit [123645] by alokp@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] WebViewBenchmarkSupport::paint API does not work with recording canvas
https://bugs.webkit.org/show_bug.cgi?id=92008

Reviewed by Darin Fisher.

Moved the ownership of canvas to WebViewBenchmarkSupport::PaintClient.

  • public/WebViewBenchmarkSupport.h:

(PaintClient):
(WebKit::WebViewBenchmarkSupport::PaintClient::willPaint):
(WebKit::WebViewBenchmarkSupport::PaintClient::didPaint):

  • src/WebViewBenchmarkSupportImpl.cpp:

(WebKit::WebViewBenchmarkSupportImpl::paintLayer):
(WebKit::WebViewBenchmarkSupportImpl::softwarePaint):

12:46 PM Changeset in webkit [123644] by danakj@chromium.org
  • 19 edits
    2 moves
    2 adds in trunk/Source

[chromium] Turn the debug HUD into a layer so that it can be drawn as a WebCompositorQuad
https://bugs.webkit.org/show_bug.cgi?id=92182

Reviewed by Adrienne Walker.

Source/WebCore:

By changing the HUD into a quad, we are able to create a HUD and pass
it to the host compositor, allowing the HUD to be used for renderers
under Ubercompositor.

This also removes the special drawing code for the HUD from
LayerRendererChromium, allowing us to move finishDrawingFrame
into LayerRendererChromium as a private method and remove it
from the CCRenderer interface.

Finally, we can remove the CCFontAtlas transport code from CCProxy
and its implementations as the atlas can be synced to impl thread
through the usual layer commit mechanism.

The debug HUD is not covered by tests.

  • WebCore.gypi:
  • platform/graphics/chromium/HeadsUpDisplayLayerChromium.cpp: Added.

(WebCore):
(WebCore::HeadsUpDisplayLayerChromium::create):
(WebCore::HeadsUpDisplayLayerChromium::HeadsUpDisplayLayerChromium):
(WebCore::HeadsUpDisplayLayerChromium::~HeadsUpDisplayLayerChromium):
(WebCore::HeadsUpDisplayLayerChromium::createCCLayerImpl):

  • platform/graphics/chromium/HeadsUpDisplayLayerChromium.h: Added.

(WebCore):
(HeadsUpDisplayLayerChromium):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawFrame):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

  • platform/graphics/chromium/cc/CCDebugRectHistory.cpp:

(WebCore::CCDebugRectHistory::savePropertyChangedRects):

  • platform/graphics/chromium/cc/CCDebugRectHistory.h:
  • platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.cpp: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp.

(WebCore):
(WebCore::CCHeadsUpDisplayLayerImpl::CCHeadsUpDisplayLayerImpl):
(WebCore::CCHeadsUpDisplayLayerImpl::~CCHeadsUpDisplayLayerImpl):
(WebCore::CCHeadsUpDisplayLayerImpl::willDraw):
(WebCore::CCHeadsUpDisplayLayerImpl::appendQuads):
(WebCore::CCHeadsUpDisplayLayerImpl::didDraw):
(WebCore::CCHeadsUpDisplayLayerImpl::didLoseContext):
(WebCore::CCHeadsUpDisplayLayerImpl::drawHudContents):
(WebCore::CCHeadsUpDisplayLayerImpl::drawFPSCounter):
(WebCore::CCHeadsUpDisplayLayerImpl::drawFPSCounterText):
(WebCore::CCHeadsUpDisplayLayerImpl::drawDebugRects):

  • platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.h: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCHeadsUpDisplay.h.

(WebCore):
(CCHeadsUpDisplayLayerImpl):
(WebCore::CCHeadsUpDisplayLayerImpl::create):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::layerIsAlwaysDamaged):
This flag is used to mark the HUD as always damaged, so that it is
continually drawn on the impl thread. It is also used as a hint by
the CCDebugRectHistory class to not include the layer in the display
of damage, since always damaged is not interesting damage.
(CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::create):
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::willCommit):
(WebCore::CCLayerTreeHost::didCommit):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeSettings):
(WebCore::CCLayerTreeSettings::showDebugInfo):
(WebCore::CCLayerTreeSettings::showDebugRects):
(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::drawLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore):
(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCProxy.h:

(CCProxy):

  • platform/graphics/chromium/cc/CCRenderer.h:

(CCRenderer):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:
  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

  • tests/LayerRendererChromiumTest.cpp:

(TEST):

12:10 PM Changeset in webkit [123643] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[EFL][WK2] Fix timeout issues when debugging WebProcess.
https://bugs.webkit.org/show_bug.cgi?id=92245

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-25
Reviewed by Dirk Pranke.

Fix timeout issues when debugging the WebProcess
under valgrind or gdb.

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort.default_timeout_ms):

  • WebKitTestRunner/efl/TestControllerEfl.cpp:

(WTR::TestController::platformInitialize):

11:52 AM Changeset in webkit [123642] by wangxianzhu@chromium.org
  • 2 edits in trunk/Tools

[Chromium-Android] NRWT driver should not restart between reftests
https://bugs.webkit.org/show_bug.cgi?id=92267

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidDriver.start): Resets self._pixel_tests when the pixel_tests parameter changes.

11:49 AM Changeset in webkit [123641] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: follow up to r123612, fixing CSS value suggest.

Not reviewed, minor JS fix.

  • inspector/front-end/CSSCompletions.js:

(WebInspector.CSSCompletions):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertyTreeElement.prototype):

11:48 AM Changeset in webkit [123640] by bweinstein@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Add Mac results for media/controls-styling-strict.html.

Rubber-stamped by Michael Saboff.

  • platform/mac/media/controls-styling-strict-expected.txt: Added.
11:19 AM Changeset in webkit [123639] by msaboff@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r123624.

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::clearGeolocationOverride):
Changed ASSERT_UNUSED() to UNUSED_PARAM().

11:16 AM Changeset in webkit [123638] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web inspector auto-completes "optimizequality" but then complains
https://bugs.webkit.org/show_bug.cgi?id=92262

Reviewed by Timothy Hatcher.

Fixed optimizeSpeed, optimizeLegibility, geometricPrecision.

  • inspector/front-end/CSSKeywordCompletions.js:
11:15 AM Changeset in webkit [123637] by Beth Dakin
  • 3 edits
    2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=89114
REGRESSION (r112919): Setting scrollTop after setting display from none to block
fails
-and corresponding-
<rdar://problem/11656050>

Reviewed by Simon Fraser.

Source/WebCore:

ScrollAnimatorMac::immediateScrollTo() and ScrollAnimatorMac::immediateScrollBy()
both have an optimization in place so that they do not call
notifyPositionChanged() if the new scroll offset matches the ScrollAnimator's
cached m_currentPosX and m_currentPosY. So revision 112919 caused troubled with
this optimization because it allowed RenderLayers to restore a scrollOffset from
the Element if there is one cached there. This caused the RenderLayer to have a
scrollOffset that is improperly out-of-synch with the ScrollAnimator's
currentPosition (which will just be 0,0 since it is being re-created like the
RenderLayer). This fix makes sure they are in synch by calling
setCurrentPosition() on the ScrollAnimator when the cached position is non-zero.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):

LayoutTests:

  • fast/overflow/setting-scrollTop-after-hide-show-expected.txt: Added.
  • fast/overflow/setting-scrollTop-after-hide-show.html: Added.
11:14 AM Changeset in webkit [123636] by kling@webkit.org
  • 27 edits in trunk

Make ElementAttributeData a variable-sized object to reduce memory use.
<http://webkit.org/b/88240>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Take advantage of the fact that we know at ElementAttributeData construction time how many attributes
it needs to accomodate and allocate exactly as much space as needed instead of using a Vector.
For elements that never have their attribute list mutated (the vast majority), this saves a lot of
memory and removes the indirection to Vector<Attribute>'s heap-allocated storage.

Introduced a mutability flag to ElementAttributeData and sprinkled assertions all over to make sure
that nothing tries to mutate an element with a raw attribute array.

When an Element's attribute(s) are mutated, we reconstruct the ElementAttributeData, this time using
a Vector as backing instead. This is triggered when calling Element::mutableAttributeData().

This reduces memory consumption by 3.2MB when viewing the full HTML5 spec at <http://whatwg.org/c/>.
That is a ~35% reduction in DOM attribute memory use.

Furthermore, that page ends up promoting 27% of the elements to mutable attribute storage due to dynamic
adding of "class" attributes. For more static pages, savings are even greater.

Also did away with ElementAttributeData::removeAttribute(name) and do separate index lookup where
needed. Not a big deal but avoids double lookup of attributes when removing them.

  • dom/Element.cpp:

(WebCore::Element::detachAttribute):
(WebCore::Element::removeAttribute):
(WebCore::Element::attributes):
(WebCore::Element::setAttributeInternal):
(WebCore::Element::parserSetAttributes):
(WebCore::Element::hasEquivalentAttributes):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeNode):
(WebCore::Element::getAttributeNode):
(WebCore::Element::getAttributeNodeNS):
(WebCore::Element::hasAttribute):
(WebCore::Element::hasAttributeNS):
(WebCore::Element::cloneAttributesFromElement):

Sprinkle const on ElementAttributeData* pointers.
Switch to using mutableAttributeData() in code paths that modify attributes.

(WebCore::Element::normalizeAttributes):

Cleaner iteration over attributes, I removed ElementAttributeData::attributeVector() since that
was just incurring a bunch of extra Vector copying. Since ElementAttributeData already exposes
length() and attributeItem(index), use those to iterate directly over the attributes.

(WebCore::Element::createMutableAttributeData):

Added, converts existing ElementAttributeData to a mutable object. Otherwise creates a new
ElementAttributeData (mutable and empty.)

  • dom/Element.h:

(WebCore::Element::attributeData):
(WebCore::Element::updatedAttributeData):
(WebCore::Element::ensureAttributeData):
(WebCore::Element::ensureUpdatedAttributeData):

Made all of these return "const ElementAttributeData*" to ensure at compile-time that nothing
attempts to modify an ElementAttributeData that may be immutable.

ensureUpdatedAttributeData() is still const, despite possibly calling mutableAttributeData().
The goal of having methods be const is to prevent conversion from one ElementAttributeData
object to another, so that pointers remain intact and no unnecessary work gets done.

(WebCore::Element::mutableAttributeData):

Added, returns a guaranteed mutable ElementAttributeData* pointer.

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::createImmutable):

Creates a new ElementAttributeData tailored to fit the provided Vector<Attribute>.

(WebCore::ElementAttributeData::ElementAttributeData):

Moved constructors out-of-line, getting too complex for header files.

ElementAttributeData(const Vector<Attribute>&) creates an immutable ElementAttributeData
containing the provided attributes in an array tacked onto the end of the object.

(WebCore::ElementAttributeData::~ElementAttributeData):

Free the attribute vector if mutable.
For immutable objects, manually invoke destructor on each Attribute object,
since these won't be destroyed automatically by ~ElementAttributeData.

(WebCore::ElementAttributeData::attrIfExists):

(WebCore::ElementAttributeData::ensureAttr):
(WebCore::ElementAttributeData::setAttr):
(WebCore::ElementAttributeData::removeAttr):

Make these const, as they should always have been- they don't affect the ElementAttributeData,
only the global DOM Attr <-> ElementAttributeData mappings.

(WebCore::ElementAttributeData::ensureInlineStyle):
(WebCore::ElementAttributeData::ensureMutableInlineStyle):

Sprinkle ASSERT(isMutable()). This doesn't mean that all Elements with inline styles automatically
have mutable attribute data. There's still inlineStyle() for that, which may return null.
These are only for use where you need a valid StylePropertySet*, even if there is no inline style
attribute, e.g in editing code that wants to add style.

(WebCore::ElementAttributeData::updateInlineStyleAvoidingMutation):
(WebCore::ElementAttributeData::destroyInlineStyle):

Make these const. While destroyInlineStyle() doesn't sound very const-y, immutable objects that
contain a style attribute will have a valid inlineStyle() with that style data. This is just
an interface for ~StyledElement to destroy the style object.
It'd be nice to do that in ~ElementAttributeData(), but we need a StyledElement* pointer to
clean up properly and we don't store one in this class.

(WebCore::ElementAttributeData::addAttribute):
(WebCore::ElementAttributeData::removeAttribute):
(WebCore::ElementAttributeData::clearAttributes):
(WebCore::ElementAttributeData::replaceAttribute):

Sprinkle ASSERT(isMutable()).
Always go straight for m_mutableAttributeVector since we know that's the storage being used.

(WebCore::ElementAttributeData::isEquivalent):
(WebCore::ElementAttributeData::detachAttrObjectsFromElement):
(WebCore::ElementAttributeData::getAttributeItemIndexSlowCase):
(WebCore::ElementAttributeData::removeAttribute):
(WebCore::ElementAttributeData::getAttributeItem):
(WebCore::ElementAttributeData::getAttributeItemIndex):

Use length() and attributeItem(index) to iterate over the attributes.

(WebCore::ElementAttributeData::cloneDataFrom):

Sprinkle ASSERT(isMutable()). Added a FIXME that cloning elements could create immutable
attribute data. I'm not sure this optimization is worthwhile, as cloning elements is already
a semi-rare occurrence.

Updated code to handle both immutable and mutable source objects. This could

(WebCore::ElementAttributeData::getAttributeNode):

Const correctness.

  • dom/ElementAttributeData.h:

(ElementAttributeData):

Turn attribute storage into what's effectively union { OwnPtr<Vector<Attribute>>; Attribute[]; }
The new m_isMutable bit determines which union member should be used for access.

(WebCore::ElementAttributeData::create):
(WebCore::ElementAttributeData::createImmutable):

Added createImmutable(const Vector<Attribute>&) as a complement to create().

(WebCore::ElementAttributeData::setClass):
(WebCore::ElementAttributeData::setIdForStyleResolution):
(WebCore::ElementAttributeData::inlineStyle):
(WebCore::ElementAttributeData::setAttributeStyle):

Make these const, and their data member counterparts 'mutable'.
An immutable ElementAttributeData object still has m_classNames, m_idForStyleResolution,
m_inlineStyleDecl and m_attributeStyle.

(WebCore::ElementAttributeData::reportMemoryUsage):

Updated for isMutable().

(WebCore::ElementAttributeData::makeMutable):

Returns a mutable clone of itself.

(WebCore::ElementAttributeData::isEmpty):
(WebCore::ElementAttributeData::length):
(WebCore::ElementAttributeData::attributeItem):

Check isMutable() to know how to access attribute storage.

  • dom/StyledElement.cpp:

(WebCore::StyledElement::style):
(WebCore::StyledElement::setInlineStyleProperty):

Simplify by using StyledElement::ensureInlineStyle().

(WebCore::StyledElement::classAttributeChanged):

Use mutableAttributeData() if the attribute is being removed completely.
In other cases, tiptoe around without causing the attribute data to go mutable.

(WebCore::StyledElement::removeInlineStyleProperty):

Use mutableAttributeData() if/when actually removing something.

(WebCore::StyledElement::addSubresourceAttributeURLs):

Const correctness.

  • dom/StyledElement.h:

(WebCore::StyledElement::ensureInlineStyle):

This now implies conversion to mutable attribute data. Used by codepaths that add/remove
properties, so conversion is inevitable.

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement):
(WebCore::HTMLConstructionSite::createHTMLElementFromSavedElement):

  • svg/properties/SVGAnimatedPropertyMacros.h:

(WebCore::SVGSynchronizableAnimatedProperty::synchronize):

Use mutableAttributeData() as appropriate.

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):

Const correctness.

LayoutTests:

Extended this test to cover the case where setAttributeNode() returns a lazily serialized value.

  • fast/dom/attr-style-too-lazy-expected.txt:
  • fast/dom/attr-style-too-lazy.html:
11:12 AM Changeset in webkit [123635] by atwilson@chromium.org
  • 12 edits in trunk/Source

Unreviewed, rolling out r123560.
http://trac.webkit.org/changeset/123560
https://bugs.webkit.org/show_bug.cgi?id=90321

Breaks chromium valgrind tests.

Source/WebCore:

  • html/FTPDirectoryDocument.cpp:

(WebCore::FTPDirectoryDocumentParser::append):

  • html/parser/HTMLEntityParser.cpp:

(WebCore::HTMLEntityParser::consumeNamedEntity):

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::stripLeadingAndTrailingHTMLSpaces):

  • html/parser/HTMLSourceTracker.cpp:

(WebCore::HTMLSourceTracker::sourceForToken):

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::script):

  • platform/text/SegmentedString.cpp:

(WebCore::SegmentedString::SegmentedString):
(WebCore::SegmentedString::operator=):
(WebCore::SegmentedString::clear):
(WebCore::SegmentedString::append):
(WebCore::SegmentedString::prepend):
(WebCore::SegmentedString::advanceSubstring):
(WebCore::SegmentedString::advance):
(WebCore::SegmentedString::advanceSlowCase):
(WebCore::SegmentedString::advanceAndUpdateLineNumberSlowCase):

  • platform/text/SegmentedString.h:

(WebCore::SegmentedSubstring::SegmentedSubstring):
(WebCore::SegmentedSubstring::clear):
(WebCore::SegmentedSubstring::appendTo):
(SegmentedSubstring):
(WebCore::SegmentedString::SegmentedString):
(WebCore::SegmentedString::push):
(WebCore::SegmentedString::isEmpty):
(WebCore::SegmentedString::lookAhead):
(WebCore::SegmentedString::lookAheadIgnoringCase):
(WebCore::SegmentedString::advance):
(WebCore::SegmentedString::advanceAndASSERT):
(WebCore::SegmentedString::advanceAndASSERTIgnoringCase):
(WebCore::SegmentedString::advancePastNewlineAndUpdateLineNumber):
(SegmentedString):
(WebCore::SegmentedString::advancePastNonNewline):
(WebCore::SegmentedString::advanceAndUpdateLineNumber):
(WebCore::SegmentedString::operator*):
(WebCore::SegmentedString::operator->):
(WebCore::SegmentedString::current):
(WebCore::SegmentedString::equalsLiterally):
(WebCore::SegmentedString::equalsIgnoringCase):
(WebCore::SegmentedString::lookAheadInline):
(WebCore::SegmentedString::lookAheadSlowCase):

  • xml/parser/CharacterReferenceParserInlineMethods.h:

(WebCore::consumeCharacterReference):

  • xml/parser/MarkupTokenizerBase.h:

(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::nextInputCharacter):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::peek):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::advance):

Source/WTF:

  • wtf/text/WTFString.h:
10:50 AM Changeset in webkit [123634] by kpiascik@rim.com
  • 14 edits
    6 adds in trunk

Web Inspector: Geolocation override
https://bugs.webkit.org/show_bug.cgi?id=89365

Reviewed by Pavel Feldman.

Source/WebCore:

Re-added the m_page member variable for GeolocationController since
it's now being used by InspectorInstrumentaiton.

Added a way to override the GeolocationPosition and GeolocationError
using Web Inspector. Curretnly only PositionError can be set.

This will be hidden behind the experiments flag for now.

Tests: inspector/geolocation-error.html

inspector/geolocation-success.html
inspector/geolocation-watchPosition.html

  • English.lproj/localizedStrings.js:
  • Modules/geolocation/GeolocationController.cpp:

(WebCore::GeolocationController::GeolocationController):
(WebCore::GeolocationController::positionChanged):

  • Modules/geolocation/GeolocationController.h:

(GeolocationController):

  • inspector/Inspector.json:
  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::overrideGeolocationPositionImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::overrideGeolocationPosition):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::setGeolocationOverride):
(WebCore):
(WebCore::InspectorPageAgent::clearGeolocationOverride):
(WebCore::InspectorPageAgent::canOverrideGeolocation):
(WebCore::InspectorPageAgent::overrideGeolocationPosition):

  • inspector/InspectorPageAgent.h:
  • inspector/front-end/Settings.js:
  • inspector/front-end/SettingsScreen.js:

(WebInspector.UserAgentSettingsTab):
(WebInspector.UserAgentSettingsTab.prototype._createDeviceMetricsElement):
(WebInspector.UserAgentSettingsTab.prototype._onGeolocationOverrideCheckboxClicked):
(WebInspector.UserAgentSettingsTab.prototype._applyGeolocationUserInput):
(WebInspector.UserAgentSettingsTab.prototype._setGeolocationPosition.set if):
(WebInspector.UserAgentSettingsTab.prototype._setGeolocationPosition):
(WebInspector.UserAgentSettingsTab.prototype._createGeolocationOverrideElement.createInput):
(WebInspector.UserAgentSettingsTab.prototype._createGeolocationOverrideElement):

  • inspector/front-end/UserAgentSupport.js:

(WebInspector.UserAgentSupport.GeolocationPosition):
(WebInspector.UserAgentSupport.GeolocationPosition.prototype.toSetting):
(WebInspector.UserAgentSupport.GeolocationPosition.parseSetting):
(WebInspector.UserAgentSupport.GeolocationPosition.parseUserInput):
(WebInspector.UserAgentSupport.GeolocationPosition.clearGeolocationOverride):

  • inspector/front-end/inspector.js:

(WebInspector.doLoadedDone):

LayoutTests:

Added new tests.

  • inspector/geolocation-error-expected.txt: Added.
  • inspector/geolocation-error.html: Added.
  • inspector/geolocation-success-expected.txt: Added.
  • inspector/geolocation-success.html: Added.
  • inspector/geolocation-watchPosition-expected.txt: Added.
  • inspector/geolocation-watchPosition.html: Added.
10:43 AM Changeset in webkit [123633] by shawnsingh@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Build fix for clang builds after r123628
https://bugs.webkit.org/show_bug.cgi?id=92266

Reviewed by Adrienne Walker.

An un-used variable was causing build failures for clang builds
after the refactoring in r123628. It is correct to simply remove
this value.

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsInternal):

10:41 AM Changeset in webkit [123632] by hans@chromium.org
  • 2 edits in trunk/Source/WebCore

Speech JavaScript API: extract function from SpeechRecognitionResult::emma()
https://bugs.webkit.org/show_bug.cgi?id=92232

Reviewed by Adam Barth.

Extract code for creating emma-qualified names to a helper function.

Just a refactoring; covered by the existing test.

  • Modules/speech/SpeechRecognitionResult.cpp:

(WebCore::emmaQualifiedName):
(WebCore):
(WebCore::SpeechRecognitionResult::emma):

10:39 AM Changeset in webkit [123631] by caio.oliveira@openbossa.org
  • 152 edits
    20 deletes in trunk/LayoutTests

[Qt] css2.1/t* tests needs rebaseline after new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91999

Unreviewed.

  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/css2.1/t0805-c5519-brdr-r-01-e-expected.png: Removed.
  • platform/qt-5.0/css2.1/t0805-c5519-brdr-r-01-e-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0905-c414-flt-02-c-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0905-c414-flt-03-c-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0905-c414-flt-04-c-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0905-c414-flt-fit-01-d-g-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0905-c5525-fltblck-00-d-ag-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0905-c5525-fltblck-01-d-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0905-c5525-flthw-00-c-g-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0905-c5525-fltwrap-00-b-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0905-c5526-flthw-00-c-g-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t090501-c414-flt-01-b-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t090501-c414-flt-03-b-g-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t090501-c414-flt-ln-01-d-g-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t090501-c5525-flt-l-00-b-g-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t090501-c5525-flt-r-00-b-g-expected.txt: Removed.
  • platform/qt/css2.1/t010403-shand-border-00-c-expected.png:
  • platform/qt/css2.1/t010403-shand-border-00-c-expected.txt:
  • platform/qt/css2.1/t010403-shand-font-00-b-expected.png:
  • platform/qt/css2.1/t010403-shand-font-00-b-expected.txt:
  • platform/qt/css2.1/t010403-shand-font-01-b-expected.png:
  • platform/qt/css2.1/t010403-shand-font-01-b-expected.txt:
  • platform/qt/css2.1/t010403-shand-font-02-b-expected.png:
  • platform/qt/css2.1/t010403-shand-font-02-b-expected.txt:
  • platform/qt/css2.1/t010403-shand-font-03-b-expected.png:
  • platform/qt/css2.1/t010403-shand-font-03-b-expected.txt:
  • platform/qt/css2.1/t050201-c12-grouping-00-b-expected.png:
  • platform/qt/css2.1/t050201-c12-grouping-00-b-expected.txt:
  • platform/qt/css2.1/t0505-c16-descendant-00-e-expected.png:
  • platform/qt/css2.1/t0505-c16-descendant-00-e-expected.txt:
  • platform/qt/css2.1/t0505-c16-descendant-01-e-expected.png:
  • platform/qt/css2.1/t0505-c16-descendant-01-e-expected.txt:
  • platform/qt/css2.1/t0505-c16-descendant-02-e-expected.png:
  • platform/qt/css2.1/t0505-c16-descendant-02-e-expected.txt:
  • platform/qt/css2.1/t050803-c14-classes-00-e-expected.png:
  • platform/qt/css2.1/t050803-c14-classes-00-e-expected.txt:
  • platform/qt/css2.1/t0509-c15-ids-00-a-expected.png:
  • platform/qt/css2.1/t0509-c15-ids-00-a-expected.txt:
  • platform/qt/css2.1/t0509-c15-ids-01-e-expected.png:
  • platform/qt/css2.1/t0509-c15-ids-01-e-expected.txt:
  • platform/qt/css2.1/t0509-id-sel-syntax-01-f-expected.png:
  • platform/qt/css2.1/t0509-id-sel-syntax-01-f-expected.txt:
  • platform/qt/css2.1/t0509-id-sel-syntax-02-b-expected.png:
  • platform/qt/css2.1/t0509-id-sel-syntax-02-b-expected.txt:
  • platform/qt/css2.1/t0510-c25-pseudo-elmnt-00-c-expected.png:
  • platform/qt/css2.1/t0510-c25-pseudo-elmnt-00-c-expected.txt:
  • platform/qt/css2.1/t0511-c21-pseud-anch-00-e-i-expected.png:
  • platform/qt/css2.1/t0511-c21-pseud-anch-00-e-i-expected.txt:
  • platform/qt/css2.1/t0511-c21-pseud-link-00-e-expected.png:
  • platform/qt/css2.1/t0511-c21-pseud-link-00-e-expected.txt:
  • platform/qt/css2.1/t0511-c21-pseud-link-01-e-expected.png:
  • platform/qt/css2.1/t0511-c21-pseud-link-01-e-expected.txt:
  • platform/qt/css2.1/t0511-c21-pseud-link-02-e-expected.png:
  • platform/qt/css2.1/t0511-c21-pseud-link-02-e-expected.txt:
  • platform/qt/css2.1/t0511-c21-pseud-link-03-e-expected.png:
  • platform/qt/css2.1/t0511-c21-pseud-link-03-e-expected.txt:
  • platform/qt/css2.1/t051103-c21-activ-ln-00-e-i-expected.png:
  • platform/qt/css2.1/t051103-c21-activ-ln-00-e-i-expected.txt:
  • platform/qt/css2.1/t051103-c21-focus-ln-00-e-i-expected.png:
  • platform/qt/css2.1/t051103-c21-focus-ln-00-e-i-expected.txt:
  • platform/qt/css2.1/t051103-c21-hover-ln-00-e-i-expected.png:
  • platform/qt/css2.1/t051103-c21-hover-ln-00-e-i-expected.txt:
  • platform/qt/css2.1/t051103-dom-hover-01-c-io-expected.png:
  • platform/qt/css2.1/t051103-dom-hover-01-c-io-expected.txt:
  • platform/qt/css2.1/t051103-dom-hover-02-c-io-expected.png:
  • platform/qt/css2.1/t051103-dom-hover-02-c-io-expected.txt:
  • platform/qt/css2.1/t051202-c24-first-lttr-00-b-expected.png:
  • platform/qt/css2.1/t051202-c24-first-lttr-00-b-expected.txt:
  • platform/qt/css2.1/t051202-c26-psudo-nest-00-c-expected.png:
  • platform/qt/css2.1/t051202-c26-psudo-nest-00-c-expected.txt:
  • platform/qt/css2.1/t0602-c13-inh-underlin-00-e-expected.png:
  • platform/qt/css2.1/t0602-c13-inh-underlin-00-e-expected.txt:
  • platform/qt/css2.1/t0602-c13-inheritance-00-e-expected.png:
  • platform/qt/css2.1/t0602-c13-inheritance-00-e-expected.txt:
  • platform/qt/css2.1/t0602-inherit-bdr-pad-b-00-expected.png:
  • platform/qt/css2.1/t0602-inherit-bdr-pad-b-00-expected.txt:
  • platform/qt/css2.1/t0603-c11-import-00-b-expected.png:
  • platform/qt/css2.1/t0603-c11-import-00-b-expected.txt:
  • platform/qt/css2.1/t060401-c32-cascading-00-b-expected.png:
  • platform/qt/css2.1/t060401-c32-cascading-00-b-expected.txt:
  • platform/qt/css2.1/t060402-c31-important-00-b-expected.png:
  • platform/qt/css2.1/t060402-c31-important-00-b-expected.txt:
  • platform/qt/css2.1/t060403-c21-pseu-cls-00-e-i-expected.png:
  • platform/qt/css2.1/t060403-c21-pseu-cls-00-e-i-expected.txt:
  • platform/qt/css2.1/t060403-c21-pseu-id-00-e-i-expected.png:
  • platform/qt/css2.1/t060403-c21-pseu-id-00-e-i-expected.txt:
  • platform/qt/css2.1/t09-c5526c-display-00-e-expected.png:
  • platform/qt/css2.1/t09-c5526c-display-00-e-expected.txt:
  • platform/qt/css2.1/t090402-c42-ibx-pad-00-d-ag-expected.png:
  • platform/qt/css2.1/t090402-c42-ibx-pad-00-d-ag-expected.txt:
  • platform/qt/css2.1/t0905-c414-flt-00-d-expected.png:
  • platform/qt/css2.1/t0905-c414-flt-00-d-expected.txt:
  • platform/qt/css2.1/t0905-c414-flt-01-d-g-expected.png:
  • platform/qt/css2.1/t0905-c414-flt-01-d-g-expected.txt:
  • platform/qt/css2.1/t0905-c414-flt-02-c-expected.png:
  • platform/qt/css2.1/t0905-c414-flt-02-c-expected.txt:
  • platform/qt/css2.1/t0905-c414-flt-03-c-expected.png:
  • platform/qt/css2.1/t0905-c414-flt-03-c-expected.txt:
  • platform/qt/css2.1/t0905-c414-flt-04-c-expected.png:
  • platform/qt/css2.1/t0905-c414-flt-04-c-expected.txt:
  • platform/qt/css2.1/t0905-c414-flt-fit-00-d-expected.png:
  • platform/qt/css2.1/t0905-c414-flt-fit-00-d-expected.txt:
  • platform/qt/css2.1/t0905-c414-flt-fit-01-d-g-expected.png:
  • platform/qt/css2.1/t0905-c414-flt-fit-01-d-g-expected.txt:
  • platform/qt/css2.1/t0905-c414-flt-wrap-00-e-expected.png:
  • platform/qt/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:
  • platform/qt/css2.1/t0905-c414-flt-wrap-01-d-g-expected.png:
  • platform/qt/css2.1/t0905-c414-flt-wrap-01-d-g-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltblck-00-d-ag-expected.png:
  • platform/qt/css2.1/t0905-c5525-fltblck-00-d-ag-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltblck-01-d-expected.png:
  • platform/qt/css2.1/t0905-c5525-fltblck-01-d-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltclr-00-c-ag-expected.png:
  • platform/qt/css2.1/t0905-c5525-fltclr-00-c-ag-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
  • platform/qt/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • platform/qt/css2.1/t0905-c5525-flthw-00-c-g-expected.png:
  • platform/qt/css2.1/t0905-c5525-flthw-00-c-g-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltinln-00-c-ag-expected.png:
  • platform/qt/css2.1/t0905-c5525-fltinln-00-c-ag-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.png:
  • platform/qt/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltmult-00-d-g-expected.png:
  • platform/qt/css2.1/t0905-c5525-fltmult-00-d-g-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/qt/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltwidth-01-c-g-expected.png:
  • platform/qt/css2.1/t0905-c5525-fltwidth-01-c-g-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltwidth-02-c-g-expected.png:
  • platform/qt/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltwidth-03-c-g-expected.png:
  • platform/qt/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltwrap-00-b-expected.png:
  • platform/qt/css2.1/t0905-c5525-fltwrap-00-b-expected.txt:
  • platform/qt/css2.1/t0905-c5526-fltclr-00-c-ag-expected.png:
  • platform/qt/css2.1/t0905-c5526-fltclr-00-c-ag-expected.txt:
  • platform/qt/css2.1/t0905-c5526-flthw-00-c-g-expected.png:
  • platform/qt/css2.1/t0905-c5526-flthw-00-c-g-expected.txt:
  • platform/qt/css2.1/t090501-c414-flt-00-d-expected.png:
  • platform/qt/css2.1/t090501-c414-flt-00-d-expected.txt:
  • platform/qt/css2.1/t090501-c414-flt-01-b-expected.png:
  • platform/qt/css2.1/t090501-c414-flt-01-b-expected.txt:
  • platform/qt/css2.1/t090501-c414-flt-02-d-g-expected.png:
  • platform/qt/css2.1/t090501-c414-flt-02-d-g-expected.txt:
  • platform/qt/css2.1/t090501-c414-flt-03-b-g-expected.png:
  • platform/qt/css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • platform/qt/css2.1/t090501-c414-flt-ln-00-d-expected.png:
  • platform/qt/css2.1/t090501-c414-flt-ln-00-d-expected.txt:
  • platform/qt/css2.1/t090501-c414-flt-ln-01-d-g-expected.png:
  • platform/qt/css2.1/t090501-c414-flt-ln-01-d-g-expected.txt:
  • platform/qt/css2.1/t090501-c414-flt-ln-02-d-expected.png:
  • platform/qt/css2.1/t090501-c414-flt-ln-02-d-expected.txt:
  • platform/qt/css2.1/t090501-c414-flt-ln-03-d-expected.png:
  • platform/qt/css2.1/t090501-c414-flt-ln-03-d-expected.txt:
  • platform/qt/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/qt/css2.1/t090501-c5525-flt-l-00-b-g-expected.txt:
  • platform/qt/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/qt/css2.1/t090501-c5525-flt-r-00-b-g-expected.txt:
  • platform/qt/css2.1/t1503-c522-font-family-00-b-expected.png:
  • platform/qt/css2.1/t1503-c522-font-family-00-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-03-b-expected.png:
  • platform/qt/css2.1/t1508-c527-font-03-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-06-b-expected.png:
  • platform/qt/css2.1/t1508-c527-font-06-b-expected.txt:
10:22 AM Changeset in webkit [123630] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Chinese IM receives incorrect/duplicated key events in text fields in webpages in Safari.
https://bugs.webkit.org/show_bug.cgi?id=89048
<rdar://problem/11786384>

Reviewed by Andreas Kling.

Cannot test text input from UI process side.

Stop relying on IPC to handle key events in order. There are too many complications
where out of order delivery is performed. Instead, queue the events at UI process
side.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::handleKeyboardEvent): (WebKit::WebPageProxy::didReceiveEvent):
10:21 AM Changeset in webkit [123629] by zhajiang@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] clock_gettime() in BackingStore.cpp should use CLOCK_MONOTONIC
https://bugs.webkit.org/show_bug.cgi?id=91898

Reviewed by Yong Li.
Patch by Jacky Jiang <zhajiang@rim.com>

Let pthread condition variable in BackingStore.cpp use monotonic clock
to fix a regression caused by r123266.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):

10:07 AM Changeset in webkit [123628] by enne@google.com
  • 19 edits in trunk/Source

[chromium] Unify compositor quadTransform/drawTransform/originTransform
https://bugs.webkit.org/show_bug.cgi?id=91417

Reviewed by Kenneth Russell.

Source/WebCore:

drawTransform used to operate on centered layer rects. To unify quad
transforms, draw transforms, and origin transforms, make draw
transforms operate on content rects with the origin in the top left.

This essentially eliminates the need for surface origin transforms,
which will be eliminated in a future patch.

Also, remove the unused CCLayerImpl::getDrawRect function.

No-op refactoring. Tested by existing tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawRenderPassQuad):

  • platform/graphics/chromium/RenderSurfaceChromium.cpp:

(WebCore::RenderSurfaceChromium::drawableContentRect):

  • platform/graphics/chromium/cc/CCDamageTracker.cpp:

(WebCore::CCDamageTracker::extendDamageForLayer):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::createSharedQuadState):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerSorter.cpp:

(WebCore::CCLayerSorter::LayerShape::LayerShape):
(WebCore::CCLayerSorter::createGraphNodes):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateVisibleContentRect):
(WebCore::calculateDrawTransformsInternal):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::::markOccludedBehindLayer):
(WebCore::::occluded):
(WebCore::::unoccludedContentRect):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::appendQuadsToFillScreen):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::drawableContentRect):

Source/WebKit/chromium:

Clean up tests to refer to the new draw transform semantics.

  • tests/CCDamageTrackerTest.cpp:

(WebKitTests::createTestTreeWithOneSurface):
(WebKitTests::createTestTreeWithTwoSurfaces):
(WebKitTests::TEST_F):

  • tests/CCLayerSorterTest.cpp:
  • tests/CCLayerTreeHostCommonTest.cpp:
  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::commitCompleteOnCCThread):

  • tests/CCQuadCullerTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:
9:52 AM Changeset in webkit [123627] by tommyw@google.com
  • 22 edits
    2 copies
    3 adds in trunk

MediaStream API: Update MediaStreamTrack to match the specification
https://bugs.webkit.org/show_bug.cgi?id=90180

Reviewed by Adam Barth.

Source/Platform:

  • chromium/public/WebMediaStreamDescriptor.h:

(WebMediaStreamDescriptor):

  • chromium/public/WebMediaStreamSource.h:

(WebMediaStreamSource):

Source/WebCore:

MediaStreamTracks are now required to show the status of the underlying source,
and trigger events when that status changes.

Test: fast/mediastream/MediaStreamTrack.html

  • GNUmakefile.list.am:
  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::addTrack):

  • Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::create):
(WebCore::MediaStreamTrack::MediaStreamTrack):
(WebCore::MediaStreamTrack::~MediaStreamTrack):
(WebCore::MediaStreamTrack::setEnabled):
(WebCore::MediaStreamTrack::readyState):
(WebCore):
(WebCore::MediaStreamTrack::sourceChangedState):
(WebCore::MediaStreamTrack::stop):
(WebCore::MediaStreamTrack::interfaceName):
(WebCore::MediaStreamTrack::scriptExecutionContext):
(WebCore::MediaStreamTrack::eventTargetData):
(WebCore::MediaStreamTrack::ensureEventTargetData):

  • Modules/mediastream/MediaStreamTrack.h:
  • Modules/mediastream/MediaStreamTrack.idl:
  • WebCore.gypi:
  • dom/EventNames.h:

(WebCore):

  • dom/EventTargetFactory.in:
  • platform/chromium/support/WebMediaStreamDescriptor.cpp:
  • platform/chromium/support/WebMediaStreamSource.cpp:

(WebKit::WebMediaStreamSource::setReadyState):
(WebKit):
(WebKit::WebMediaStreamSource::readyState):

  • platform/mediastream/MediaStreamSource.cpp: Copied from Source/WebCore/platform/mediastream/MediaStreamSource.h.

(WebCore):
(WebCore::MediaStreamSource::create):
(WebCore::MediaStreamSource::MediaStreamSource):
(WebCore::MediaStreamSource::setReadyState):
(WebCore::MediaStreamSource::addObserver):
(WebCore::MediaStreamSource::removeObserver):

  • platform/mediastream/MediaStreamSource.h:

(Observer):
(WebCore::MediaStreamSource::Observer::~Observer):
(MediaStreamSource):
(WebCore::MediaStreamSource::readyState):

  • platform/mediastream/chromium/MediaStreamCenterChromium.cpp:

(WebCore::MediaStreamCenterChromium::queryMediaStreamSources):
(WebCore::MediaStreamCenterChromium::didCreateMediaStream):

Tools:

Adding a Mock WebMediaStreamCenter to enable better LayoutTests.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:

(MockWebKitPlatformSupport::createMediaStreamCenter):

  • DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp: Added.

(WebKit):
(WebKit::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
(WebKit::MockWebMediaStreamCenter::queryMediaStreamSources):
(WebKit::MockWebMediaStreamCenter::didEnableMediaStreamTrack):
(WebKit::MockWebMediaStreamCenter::didDisableMediaStreamTrack):
(WebKit::MockWebMediaStreamCenter::didStopLocalMediaStream):
(WebKit::MockWebMediaStreamCenter::didCreateMediaStream):
(WebKit::MockWebMediaStreamCenter::constructSDP):

  • DumpRenderTree/chromium/MockWebMediaStreamCenter.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp.

(WebKit):
(MockWebMediaStreamCenter):
(WebKit::MockWebMediaStreamCenter::MockWebMediaStreamCenter):

LayoutTests:

  • fast/mediastream/MediaStreamTrack-expected.txt: Added.
  • fast/mediastream/MediaStreamTrack.html: Added.
9:45 AM Changeset in webkit [123626] by allan.jensen@nokia.com
  • 4 edits in trunk/Source/WebCore

Incorrect rounding in ceiledLayoutUnit and roundedLayoutUnit.
https://bugs.webkit.org/show_bug.cgi?id=91061

Reviewed by Adam Barth.

The two functions are currently both returning the flooredLayoutUnit when subpixel
layout is enabled. This patch changes them to return the correct fractional rounded
value.

  • platform/FractionalLayoutUnit.h:

(WebCore::FractionalLayoutUnit::fromFloatCeil):
(FractionalLayoutUnit):
(WebCore::FractionalLayoutUnit::fromFloatRound):

  • rendering/LayoutTypes.h:

(WebCore::roundedLayoutUnit):
(WebCore::ceiledLayoutUnit):

  • rendering/RenderBlock.cpp:

(WebCore::updatePreferredWidth):

9:34 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
(diff)
9:13 AM Changeset in webkit [123625] by gyuyoung.kim@samsung.com
  • 22 edits in trunk/Source/WebCore

Add *explicit* keyword to constructors in WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=92238

Reviewed by Kentaro Hara.

As a step to let *explicit* keyword add to constructors which have a parameter,
*explicit* keyword is added to Source/WebCore/platform in order to avoid implicit
type conversion.

Some files in platform directory can't use explicit keyword because of build breaks.

No new tests. Covered by existing tests.

  • platform/AutodrainedPool.h:

(AutodrainedPool):

  • platform/ContentType.h:

(ContentType):

  • platform/ContextMenu.h:

(ContextMenu):

  • platform/ContextMenuItem.h:

(ContextMenuItem):

  • platform/Cursor.h:

(WebCore::SharedCursor::SharedCursor):
(Cursor):

  • platform/KURL.h:

(WebCore::KURL::KURL):
(KURL):

  • platform/KURLGooglePrivate.h:

(KURLGooglePrivate):

  • platform/PODRedBlackTree.h:

(WebCore::PODRedBlackTree::PODRedBlackTree):

  • platform/Pasteboard.h:

(Pasteboard):

  • platform/PlatformEvent.h:

(WebCore::PlatformEvent::PlatformEvent):

  • platform/PlatformKeyboardEvent.h:

(PlatformKeyboardEvent):

  • platform/PlatformMouseEvent.h:

(PlatformMouseEvent):

  • platform/PlatformPasteboard.h:

(PlatformPasteboard):

  • platform/PlatformTouchEvent.h:

(PlatformTouchEvent):

  • platform/PlatformWheelEvent.h:

(PlatformWheelEvent):

  • platform/RunLoop.h:

(TimerBase):

  • platform/ScrollAnimator.h:

(ScrollAnimator):

  • platform/ScrollAnimatorNone.h:

(ScrollAnimatorNone):

  • platform/SharedBuffer.h:

(SharedBuffer):

  • platform/WheelFlingPlatformGestureCurve.h:

(WheelFlingPlatformGestureCurve):

  • platform/Widget.h:

(Widget):

9:09 AM Changeset in webkit [123624] by allan.jensen@nokia.com
  • 12 edits
    4 adds in trunk

NodesFromRect and area-based hit-testing can not handle CSS transforms.
https://bugs.webkit.org/show_bug.cgi?id=85792

Reviewed by Eric Seidel.

Source/WebCore:

To support the combination of CSS transforms and rect based hit testing,
we need to test against the transformed rect, instead of the original rect.

This patch makes HitTestPoint store the exact transformed FloatPoint and
FloatQuad, and modifies the intersection methods so that they will use a
new FloatQuad based intersection when transforms requires it.

Tests: fast/dom/nodesFromRect/nodesFromRect-rotate.html

fast/dom/nodesFromRect/nodesFromRect-scale.html

  • platform/graphics/FloatQuad.cpp:

(WebCore::determinant):
(WebCore::rightMostCornerToVector):
(WebCore::FloatQuad::intersectsRect):
(WebCore::FloatQuad::isCounterclockwise):

  • platform/graphics/FloatQuad.h:

(FloatQuad):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestPoint::HitTestPoint):
(WebCore::HitTestPoint::operator=):
(WebCore::HitTestPoint::move):
(WebCore::HitTestPoint::intersectsRect):
(WebCore::HitTestPoint::intersects):

  • rendering/HitTestResult.h:

(HitTestPoint):
(WebCore::HitTestPoint::isRectilinear):
(WebCore::HitTestPoint::transformedPoint):
(WebCore::HitTestPoint::transformedRect):

  • rendering/HitTestingTransformState.cpp:

(WebCore::HitTestingTransformState::flattenWithTransform):
(WebCore::HitTestingTransformState::mappedArea):
(WebCore::HitTestingTransformState::boundsOfMappedArea):

  • rendering/HitTestingTransformState.h:

(WebCore::HitTestingTransformState::create):
(WebCore::HitTestingTransformState::HitTestingTransformState):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::hitTestRegion):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTest):
(WebCore::RenderLayer::createLocalTransformState):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestChildLayerColumns):

  • rendering/RenderLayer.h:
  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::nodeAtFloatPoint):

LayoutTests:

Adds nodesFromRect tests that tests the API under the CSS transforms
scale and rotate.

  • fast/dom/nodesFromRect/nodesFromRect-rotate-expected.txt: Added.
  • fast/dom/nodesFromRect/nodesFromRect-rotate.html: Added.
  • fast/dom/nodesFromRect/nodesFromRect-scale-expected.txt: Added.
  • fast/dom/nodesFromRect/nodesFromRect-scale.html: Added.
8:51 AM Changeset in webkit [123623] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Add HTMLStackItem.h to project files
https://bugs.webkit.org/show_bug.cgi?id=92221

Patch by Kwang Yul Seo <skyul@company100.net> on 2012-07-25
Reviewed by Adam Barth.

Added HTMLStackItem.h introduced in r123399 to project files.

Project file changes only, no change in behavior thus no new tests.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
8:40 AM Changeset in webkit [123622] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Add "SelectAll" to WebPage
https://bugs.webkit.org/show_bug.cgi?id=92246

Patch by Andy Chen <andchen@rim.com> on 2012-07-25
Reviewed by Antonio Gomes.

Add "Select All" editor command to WebPage.
Internally reviewed by Mike Fenton.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::selectAll):
(WebKit):

  • Api/WebPage.h:
  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::selectAll):
(WebKit):

  • WebKitSupport/InputHandler.h:
8:14 AM Changeset in webkit [123621] by commit-queue@webkit.org
  • 3 edits
    3 deletes in trunk

Unreviewed, rolling out r123606.
http://trac.webkit.org/changeset/123606
https://bugs.webkit.org/show_bug.cgi?id=92247

broke Windows build of Chromium (Requested by tomhudson on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-25

.:

  • ManualTests/forms/color-suggestion-picker.html: Removed.

Source/WebCore:

  • Resources/colorSuggestionPicker.css: Removed.
  • Resources/colorSuggestionPicker.js: Removed.
  • WebCore.gyp/WebCore.gyp:
8:14 AM Changeset in webkit [123620] by caio.oliveira@openbossa.org
  • 176 edits
    57 adds
    7 deletes in trunk/LayoutTests

[Qt] css2.1/t1* tests needs rebaseline after new testfonts
https://bugs.webkit.org/show_bug.cgi?id=92250

Unreviewed.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t1202-counter-03-b-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t1202-counter-04-b-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t1202-counters-03-b-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t1205-c566-list-stl-01-c-g-expected.txt: Removed.
  • platform/qt/css2.1/t1001-abs-pos-cb-01-b-expected.png:
  • platform/qt/css2.1/t1001-abs-pos-cb-01-b-expected.txt:
  • platform/qt/css2.1/t1001-abs-pos-cb-02-b-expected.png:
  • platform/qt/css2.1/t1001-abs-pos-cb-02-b-expected.txt:
  • platform/qt/css2.1/t1001-abs-pos-cb-03-b-expected.png:
  • platform/qt/css2.1/t1001-abs-pos-cb-03-b-expected.txt:
  • platform/qt/css2.1/t1001-abs-pos-cb-04-b-expected.png:
  • platform/qt/css2.1/t1001-abs-pos-cb-04-b-expected.txt:
  • platform/qt/css2.1/t1001-abs-pos-cb-05-b-expected.png:
  • platform/qt/css2.1/t1001-abs-pos-cb-05-b-expected.txt:
  • platform/qt/css2.1/t1001-abs-pos-cb-06-b-expected.png:
  • platform/qt/css2.1/t1001-abs-pos-cb-06-b-expected.txt:
  • platform/qt/css2.1/t1001-abs-pos-cb-07-b-expected.png:
  • platform/qt/css2.1/t1001-abs-pos-cb-07-b-expected.txt:
  • platform/qt/css2.1/t1001-abs-pos-cb-08-b-expected.png:
  • platform/qt/css2.1/t1001-abs-pos-cb-08-b-expected.txt:
  • platform/qt/css2.1/t1001-abs-pos-cb-09-b-expected.png:
  • platform/qt/css2.1/t1001-abs-pos-cb-09-b-expected.txt:
  • platform/qt/css2.1/t1002-c5523-width-00-b-g-expected.png:
  • platform/qt/css2.1/t1002-c5523-width-00-b-g-expected.txt:
  • platform/qt/css2.1/t1002-c5523-width-01-b-g-expected.png:
  • platform/qt/css2.1/t1002-c5523-width-01-b-g-expected.txt:
  • platform/qt/css2.1/t1002-c5523-width-02-b-g-expected.png:
  • platform/qt/css2.1/t1002-c5523-width-02-b-g-expected.txt:
  • platform/qt/css2.1/t100303-c412-blockw-00-d-ag-expected.png:
  • platform/qt/css2.1/t100303-c412-blockw-00-d-ag-expected.txt:
  • platform/qt/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.png:
  • platform/qt/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.txt:
  • platform/qt/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.png:
  • platform/qt/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.txt:
  • platform/qt/css2.1/t1004-c43-rpl-bbx-00-d-ag-expected.png:
  • platform/qt/css2.1/t1004-c43-rpl-bbx-00-d-ag-expected.txt:
  • platform/qt/css2.1/t1004-c5524-width-00-b-g-expected.png:
  • platform/qt/css2.1/t1004-c5524-width-00-b-g-expected.txt:
  • platform/qt/css2.1/t1005-c5524-width-00-b-g-expected.png:
  • platform/qt/css2.1/t1005-c5524-width-00-b-g-expected.txt:
  • platform/qt/css2.1/t1005-c5524-width-01-b-g-expected.png:
  • platform/qt/css2.1/t1005-c5524-width-01-b-g-expected.txt:
  • platform/qt/css2.1/t1008-c44-ln-box-00-d-ag-expected.png:
  • platform/qt/css2.1/t1008-c44-ln-box-00-d-ag-expected.txt:
  • platform/qt/css2.1/t1008-c44-ln-box-01-d-ag-expected.png:
  • platform/qt/css2.1/t1008-c44-ln-box-01-d-ag-expected.txt:
  • platform/qt/css2.1/t1008-c44-ln-box-03-d-ag-expected.png:
  • platform/qt/css2.1/t1008-c44-ln-box-03-d-ag-expected.txt:
  • platform/qt/css2.1/t100801-c42-ibx-ht-00-d-a-expected.png:
  • platform/qt/css2.1/t100801-c42-ibx-ht-00-d-a-expected.txt:
  • platform/qt/css2.1/t100801-c544-valgn-00-a-ag-expected.png:
  • platform/qt/css2.1/t100801-c544-valgn-00-a-ag-expected.txt:
  • platform/qt/css2.1/t100801-c544-valgn-02-d-agi-expected.png:
  • platform/qt/css2.1/t100801-c544-valgn-02-d-agi-expected.txt:
  • platform/qt/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/qt/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
  • platform/qt/css2.1/t100801-c544-valgn-04-d-agi-expected.png:
  • platform/qt/css2.1/t100801-c544-valgn-04-d-agi-expected.txt:
  • platform/qt/css2.1/t100801-c548-leadin-00-d-a-expected.png:
  • platform/qt/css2.1/t100801-c548-leadin-00-d-a-expected.txt:
  • platform/qt/css2.1/t100801-c548-ln-ht-00-c-a-expected.png:
  • platform/qt/css2.1/t100801-c548-ln-ht-00-c-a-expected.txt:
  • platform/qt/css2.1/t100801-c548-ln-ht-01-b-ag-expected.png: Removed.
  • platform/qt/css2.1/t100801-c548-ln-ht-01-b-ag-expected.txt: Removed.
  • platform/qt/css2.1/t100801-c548-ln-ht-03-d-ag-expected.png:
  • platform/qt/css2.1/t100801-c548-ln-ht-03-d-ag-expected.txt:
  • platform/qt/css2.1/t100801-c548-ln-ht-04-d-ag-expected.png:
  • platform/qt/css2.1/t100801-c548-ln-ht-04-d-ag-expected.txt:
  • platform/qt/css2.1/t1202-counter-00-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counter-00-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-01-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counter-01-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-02-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counter-02-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-03-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counter-03-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-04-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counter-04-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-05-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counter-05-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-06-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counter-06-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-07-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counter-07-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-08-b-expected.png:
  • platform/qt/css2.1/t1202-counter-08-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-11-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counter-11-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-12-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counter-12-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-13-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counter-13-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-14-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counter-14-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-16-f-expected.png: Added.
  • platform/qt/css2.1/t1202-counter-16-f-expected.txt:
  • platform/qt/css2.1/t1202-counters-00-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counters-00-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-01-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counters-01-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-02-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counters-02-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-03-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counters-03-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-05-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counters-05-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-06-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counters-06-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-07-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counters-07-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-08-b-expected.png:
  • platform/qt/css2.1/t1202-counters-08-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-11-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counters-11-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-12-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counters-12-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-13-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counters-13-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-14-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counters-14-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-16-c-expected.png: Added.
  • platform/qt/css2.1/t1202-counters-16-c-expected.txt:
  • platform/qt/css2.1/t1202-counters-17-d-expected.png: Added.
  • platform/qt/css2.1/t1202-counters-17-d-expected.txt:
  • platform/qt/css2.1/t1202-counters-18-f-expected.png: Added.
  • platform/qt/css2.1/t1202-counters-18-f-expected.txt:
  • platform/qt/css2.1/t1204-implied-00-b-expected.png:
  • platform/qt/css2.1/t1204-implied-00-b-expected.txt:
  • platform/qt/css2.1/t1204-implied-01-c-expected.png:
  • platform/qt/css2.1/t1204-implied-01-c-expected.txt:
  • platform/qt/css2.1/t1204-implied-02-d-expected.png:
  • platform/qt/css2.1/t1204-implied-02-d-expected.txt:
  • platform/qt/css2.1/t1204-multiple-00-c-expected.png:
  • platform/qt/css2.1/t1204-multiple-00-c-expected.txt:
  • platform/qt/css2.1/t1204-multiple-01-c-expected.png:
  • platform/qt/css2.1/t1204-multiple-01-c-expected.txt:
  • platform/qt/css2.1/t1204-order-00-c-expected.png:
  • platform/qt/css2.1/t1204-order-00-c-expected.txt:
  • platform/qt/css2.1/t1204-order-01-d-expected.png:
  • platform/qt/css2.1/t1204-order-01-d-expected.txt:
  • platform/qt/css2.1/t1204-root-e-expected.png:
  • platform/qt/css2.1/t1204-root-e-expected.txt:
  • platform/qt/css2.1/t120401-scope-00-b-expected.png:
  • platform/qt/css2.1/t120401-scope-00-b-expected.txt:
  • platform/qt/css2.1/t120401-scope-01-c-expected.png:
  • platform/qt/css2.1/t120401-scope-01-c-expected.txt:
  • platform/qt/css2.1/t120401-scope-02-c-expected.png:
  • platform/qt/css2.1/t120401-scope-02-c-expected.txt:
  • platform/qt/css2.1/t120401-scope-03-c-expected.png:
  • platform/qt/css2.1/t120401-scope-03-c-expected.txt:
  • platform/qt/css2.1/t120401-scope-04-d-expected.png:
  • platform/qt/css2.1/t120401-scope-04-d-expected.txt:
  • platform/qt/css2.1/t120403-content-none-00-c-expected.png:
  • platform/qt/css2.1/t120403-content-none-00-c-expected.txt:
  • platform/qt/css2.1/t120403-display-none-00-c-expected.png:
  • platform/qt/css2.1/t120403-display-none-00-c-expected.txt:
  • platform/qt/css2.1/t120403-visibility-00-c-expected.png:
  • platform/qt/css2.1/t120403-visibility-00-c-expected.txt:
  • platform/qt/css2.1/t1205-c561-list-displ-00-b-expected.png: Added.
  • platform/qt/css2.1/t1205-c561-list-displ-00-b-expected.txt:
  • platform/qt/css2.1/t1205-c563-list-type-00-b-expected.png: Added.
  • platform/qt/css2.1/t1205-c563-list-type-00-b-expected.txt:
  • platform/qt/css2.1/t1205-c563-list-type-01-b-expected.png: Added.
  • platform/qt/css2.1/t1205-c563-list-type-01-b-expected.txt:
  • platform/qt/css2.1/t1205-c564-list-img-00-b-g-expected.png: Added.
  • platform/qt/css2.1/t1205-c564-list-img-00-b-g-expected.txt:
  • platform/qt/css2.1/t1205-c565-list-pos-00-b-expected.png: Added.
  • platform/qt/css2.1/t1205-c565-list-pos-00-b-expected.txt:
  • platform/qt/css2.1/t1205-c566-list-stl-00-e-ag-expected.png: Added.
  • platform/qt/css2.1/t1205-c566-list-stl-00-e-ag-expected.txt:
  • platform/qt/css2.1/t1205-c566-list-stl-01-c-g-expected.png: Added.
  • platform/qt/css2.1/t1205-c566-list-stl-01-c-g-expected.txt:
  • platform/qt/css2.1/t1401-c531-color-00-a-expected.png:
  • platform/qt/css2.1/t1401-c531-color-00-a-expected.txt:
  • platform/qt/css2.1/t1402-c45-bg-canvas-00-b-expected.png:
  • platform/qt/css2.1/t1402-c45-bg-canvas-00-b-expected.txt:
  • platform/qt/css2.1/t140201-c532-bgcolor-00-a-expected.png: Added.
  • platform/qt/css2.1/t140201-c532-bgcolor-00-a-expected.txt:
  • platform/qt/css2.1/t140201-c532-bgcolor-01-b-expected.png: Added.
  • platform/qt/css2.1/t140201-c532-bgcolor-01-b-expected.txt:
  • platform/qt/css2.1/t140201-c533-bgimage-00-a-expected.png: Added.
  • platform/qt/css2.1/t140201-c533-bgimage-00-a-expected.txt:
  • platform/qt/css2.1/t140201-c533-bgimage-01-b-g-expected.png: Added.
  • platform/qt/css2.1/t140201-c533-bgimage-01-b-g-expected.txt:
  • platform/qt/css2.1/t140201-c534-bgre-00-b-ag-expected.png: Added.
  • platform/qt/css2.1/t140201-c534-bgre-00-b-ag-expected.txt:
  • platform/qt/css2.1/t140201-c534-bgre-01-b-ag-expected.png:
  • platform/qt/css2.1/t140201-c534-bgre-01-b-ag-expected.txt:
  • platform/qt/css2.1/t140201-c535-bg-fixd-00-b-g-expected.png: Added.
  • platform/qt/css2.1/t140201-c535-bg-fixd-00-b-g-expected.txt:
  • platform/qt/css2.1/t140201-c536-bgpos-00-b-ag-expected.png: Added.
  • platform/qt/css2.1/t140201-c536-bgpos-00-b-ag-expected.txt:
  • platform/qt/css2.1/t140201-c536-bgpos-01-b-ag-expected.png:
  • platform/qt/css2.1/t140201-c536-bgpos-01-b-ag-expected.txt:
  • platform/qt/css2.1/t140201-c537-bgfxps-00-c-ag-expected.png:
  • platform/qt/css2.1/t140201-c537-bgfxps-00-c-ag-expected.txt:
  • platform/qt/css2.1/t1504-c523-font-style-00-b-expected.png: Added.
  • platform/qt/css2.1/t1504-c523-font-style-00-b-expected.txt:
  • platform/qt/css2.1/t1505-c524-font-var-00-b-expected.png:
  • platform/qt/css2.1/t1505-c524-font-var-00-b-expected.txt:
  • platform/qt/css2.1/t1506-c525-font-wt-00-b-expected.png: Added.
  • platform/qt/css2.1/t1506-c525-font-wt-00-b-expected.txt:
  • platform/qt/css2.1/t1507-c526-font-sz-00-b-expected.png: Added.
  • platform/qt/css2.1/t1507-c526-font-sz-00-b-expected.txt:
  • platform/qt/css2.1/t1507-c526-font-sz-01-b-a-expected.png: Added.
  • platform/qt/css2.1/t1507-c526-font-sz-01-b-a-expected.txt:
  • platform/qt/css2.1/t1507-c526-font-sz-02-b-a-expected.png: Added.
  • platform/qt/css2.1/t1507-c526-font-sz-02-b-a-expected.txt:
  • platform/qt/css2.1/t1507-c526-font-sz-03-f-a-expected.png: Added.
  • platform/qt/css2.1/t1507-c526-font-sz-03-f-a-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-00-b-expected.png: Added.
  • platform/qt/css2.1/t1508-c527-font-00-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-01-b-expected.png: Added.
  • platform/qt/css2.1/t1508-c527-font-01-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-02-b-expected.png: Added.
  • platform/qt/css2.1/t1508-c527-font-02-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-04-b-expected.png: Added.
  • platform/qt/css2.1/t1508-c527-font-04-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-05-b-expected.png: Added.
  • platform/qt/css2.1/t1508-c527-font-05-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-07-b-expected.png: Added.
  • platform/qt/css2.1/t1508-c527-font-07-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-08-b-expected.png: Added.
  • platform/qt/css2.1/t1508-c527-font-08-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-09-b-expected.png: Added.
  • platform/qt/css2.1/t1508-c527-font-09-b-expected.txt: Added.
  • platform/qt/css2.1/t1508-c527-font-10-c-expected.png: Added.
  • platform/qt/css2.1/t1508-c527-font-10-c-expected.txt:
  • platform/qt/css2.1/t1601-c547-indent-01-d-expected.png:
  • platform/qt/css2.1/t1601-c547-indent-01-d-expected.txt:
  • platform/qt/css2.1/t1602-c546-txt-align-00-b-expected.png:
  • platform/qt/css2.1/t1602-c546-txt-align-00-b-expected.txt:
  • platform/qt/css2.1/t1604-c541-word-sp-01-b-a-expected.png:
  • platform/qt/css2.1/t1604-c541-word-sp-01-b-a-expected.txt:
  • platform/qt/css2.1/t1606-c562-white-sp-00-b-ag-expected.png:
  • platform/qt/css2.1/t1606-c562-white-sp-00-b-ag-expected.txt:
8:09 AM Changeset in webkit [123619] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Calendar picker popup displays at wrong scale when deviceScaleFactor != 1.
https://bugs.webkit.org/show_bug.cgi?id=92177

Manually tested at deviceScaleFactor = 1 and 2.

Patch by Kevin Ellis <kevers@chromium.org> on 2012-07-25
Reviewed by Kent Tamura.

The device scale factor was not being set for the calendar popup.
As a result, the popup was rendered too small on hidpi displays.
This patch sets the device scale factor for any page popup.

  • src/WebPagePopupImpl.cpp:

(WebKit::WebPagePopupImpl::initPage):

8:05 AM Changeset in webkit [123618] by pfeldman@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: disabling property should remove "overriden" decoration from overriden UA shorthand.
https://bugs.webkit.org/show_bug.cgi?id=92253

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Bug fix with a test and more compilation markup.

Test: inspector/styles/styles-disable-then-enable-overriden-ua.html

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.prototype.update):
(WebInspector.StylePropertyTreeElement):
(WebInspector.StylePropertyTreeElement.prototype):

LayoutTests:

  • inspector/styles/styles-disable-then-enable-overriden-ua-expected.txt: Added.
  • inspector/styles/styles-disable-then-enable-overriden-ua.html: Added.
7:59 AM Changeset in webkit [123617] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Don't touch a tile buffer while it's still on its way to the GPU
https://bugs.webkit.org/show_bug.cgi?id=91992

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-07-25
Reviewed by Adam Treat.

PR: 141439
The copyPreviousContentsToBackSurfaceOfTile() call will also modify
buffer contents, move it after the blit generation condvar to make sure
we've waited for the buffer to become available first.

This is done as part of some general BackingStorePrivate::render()
cleanup in PR 141439.

Internally reviewed by Jakob Petsovits.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::render):

7:55 AM Changeset in webkit [123616] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Improve ObjectPropertiesSection UI by adding a tooltip for the value.
https://bugs.webkit.org/show_bug.cgi?id=92225

Reviewed by Pavel Feldman.

Added tooltip with property value description on the property's valueElement.

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.prototype.update):

7:12 AM Changeset in webkit [123615] by caio.oliveira@openbossa.org
  • 63 edits
    55 adds
    1 delete in trunk/LayoutTests

[Qt] css2.1/t040* rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92248

Unreviewed.

  • platform/qt-5.0/Skipped:
  • platform/qt/css2.1/t040102-keywords-00-b-expected.png: Added.
  • platform/qt/css2.1/t040102-keywords-00-b-expected.txt:
  • platform/qt/css2.1/t040102-keywords-01-b-expected.png: Added.
  • platform/qt/css2.1/t040102-keywords-01-b-expected.txt:
  • platform/qt/css2.1/t040103-case-00-b-expected.png: Added.
  • platform/qt/css2.1/t040103-case-00-b-expected.txt:
  • platform/qt/css2.1/t040103-case-01-c-expected.png: Added.
  • platform/qt/css2.1/t040103-case-01-c-expected.txt:
  • platform/qt/css2.1/t040103-escapes-00-b-expected.png: Added.
  • platform/qt/css2.1/t040103-escapes-00-b-expected.txt:
  • platform/qt/css2.1/t040103-escapes-01-b-expected.png:
  • platform/qt/css2.1/t040103-escapes-01-b-expected.txt:
  • platform/qt/css2.1/t040103-escapes-02-d-expected.png: Added.
  • platform/qt/css2.1/t040103-escapes-02-d-expected.txt:
  • platform/qt/css2.1/t040103-escapes-03-b-expected.png: Added.
  • platform/qt/css2.1/t040103-escapes-03-b-expected.txt:
  • platform/qt/css2.1/t040103-escapes-04-b-expected.png: Added.
  • platform/qt/css2.1/t040103-escapes-04-b-expected.txt:
  • platform/qt/css2.1/t040103-escapes-05-c-expected.png: Added.
  • platform/qt/css2.1/t040103-escapes-05-c-expected.txt:
  • platform/qt/css2.1/t040103-escapes-06-b-expected.png: Added.
  • platform/qt/css2.1/t040103-escapes-06-b-expected.txt:
  • platform/qt/css2.1/t040103-escapes-07-b-expected.png: Added.
  • platform/qt/css2.1/t040103-escapes-07-b-expected.txt:
  • platform/qt/css2.1/t040103-escapes-08-b-expected.png: Added.
  • platform/qt/css2.1/t040103-escapes-08-b-expected.txt:
  • platform/qt/css2.1/t040103-ident-00-c-expected.png: Added.
  • platform/qt/css2.1/t040103-ident-00-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-01-c-expected.png: Added.
  • platform/qt/css2.1/t040103-ident-01-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-02-c-expected.png: Added.
  • platform/qt/css2.1/t040103-ident-02-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-03-c-expected.txt: Removed.
  • platform/qt/css2.1/t040103-ident-04-c-expected.png: Added.
  • platform/qt/css2.1/t040103-ident-04-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-05-c-expected.png: Added.
  • platform/qt/css2.1/t040103-ident-05-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-06-c-expected.png: Added.
  • platform/qt/css2.1/t040103-ident-06-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-07-c-expected.png: Added.
  • platform/qt/css2.1/t040103-ident-07-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-08-c-expected.png: Added.
  • platform/qt/css2.1/t040103-ident-08-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-09-c-expected.png: Added.
  • platform/qt/css2.1/t040103-ident-09-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-10-c-expected.png: Added.
  • platform/qt/css2.1/t040103-ident-10-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-11-c-expected.png: Added.
  • platform/qt/css2.1/t040103-ident-11-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-12-c-expected.png: Added.
  • platform/qt/css2.1/t040103-ident-12-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-13-c-expected.png: Added.
  • platform/qt/css2.1/t040103-ident-13-c-expected.txt:
  • platform/qt/css2.1/t040105-atkeyw-00-b-expected.png: Added.
  • platform/qt/css2.1/t040105-atkeyw-00-b-expected.txt:
  • platform/qt/css2.1/t040105-atkeyw-01-b-expected.png: Added.
  • platform/qt/css2.1/t040105-atkeyw-01-b-expected.txt:
  • platform/qt/css2.1/t040105-atkeyw-02-b-expected.png: Added.
  • platform/qt/css2.1/t040105-atkeyw-02-b-expected.txt:
  • platform/qt/css2.1/t040105-atrule-00-b-expected.png: Added.
  • platform/qt/css2.1/t040105-atrule-00-b-expected.txt:
  • platform/qt/css2.1/t040105-atrule-01-b-expected.png: Added.
  • platform/qt/css2.1/t040105-atrule-01-b-expected.txt:
  • platform/qt/css2.1/t040105-atrule-02-b-expected.png: Added.
  • platform/qt/css2.1/t040105-atrule-02-b-expected.txt:
  • platform/qt/css2.1/t040105-atrule-03-b-expected.png: Added.
  • platform/qt/css2.1/t040105-atrule-03-b-expected.txt:
  • platform/qt/css2.1/t040105-atrule-04-b-expected.png: Added.
  • platform/qt/css2.1/t040105-atrule-04-b-expected.txt:
  • platform/qt/css2.1/t040105-import-00-b-expected.png: Added.
  • platform/qt/css2.1/t040105-import-00-b-expected.txt:
  • platform/qt/css2.1/t040105-import-01-b-expected.png: Added.
  • platform/qt/css2.1/t040105-import-01-b-expected.txt:
  • platform/qt/css2.1/t040105-import-10-b-expected.png:
  • platform/qt/css2.1/t040105-import-10-b-expected.txt:
  • platform/qt/css2.1/t040109-c17-comments-00-b-expected.png: Added.
  • platform/qt/css2.1/t040109-c17-comments-00-b-expected.txt:
  • platform/qt/css2.1/t040109-c17-comments-01-b-expected.png: Added.
  • platform/qt/css2.1/t040109-c17-comments-01-b-expected.txt:
  • platform/qt/css2.1/t0402-c71-fwd-parsing-00-f-expected.png: Added.
  • platform/qt/css2.1/t0402-c71-fwd-parsing-00-f-expected.txt:
  • platform/qt/css2.1/t0402-c71-fwd-parsing-01-f-expected.png: Added.
  • platform/qt/css2.1/t0402-c71-fwd-parsing-01-f-expected.txt:
  • platform/qt/css2.1/t0402-c71-fwd-parsing-02-f-expected.png: Added.
  • platform/qt/css2.1/t0402-c71-fwd-parsing-02-f-expected.txt:
  • platform/qt/css2.1/t0402-c71-fwd-parsing-03-f-expected.png: Added.
  • platform/qt/css2.1/t0402-c71-fwd-parsing-03-f-expected.txt:
  • platform/qt/css2.1/t0402-c71-fwd-parsing-04-f-expected.png: Added.
  • platform/qt/css2.1/t0402-c71-fwd-parsing-04-f-expected.txt:
  • platform/qt/css2.1/t0402-syntax-01-f-expected.png: Added.
  • platform/qt/css2.1/t0402-syntax-01-f-expected.txt:
  • platform/qt/css2.1/t0402-syntax-02-f-expected.png: Added.
  • platform/qt/css2.1/t0402-syntax-02-f-expected.txt:
  • platform/qt/css2.1/t0402-syntax-03-f-expected.png: Added.
  • platform/qt/css2.1/t0402-syntax-03-f-expected.txt:
  • platform/qt/css2.1/t0402-syntax-04-f-expected.png: Added.
  • platform/qt/css2.1/t0402-syntax-04-f-expected.txt:
  • platform/qt/css2.1/t0402-syntax-05-f-expected.png: Added.
  • platform/qt/css2.1/t0402-syntax-05-f-expected.txt:
  • platform/qt/css2.1/t0402-syntax-06-f-expected.png: Added.
  • platform/qt/css2.1/t0402-syntax-06-f-expected.txt:
  • platform/qt/css2.1/t040302-c61-ex-len-00-b-a-expected.png: Added.
  • platform/qt/css2.1/t040302-c61-ex-len-00-b-a-expected.txt:
  • platform/qt/css2.1/t040302-c61-phys-len-00-b-expected.png: Added.
  • platform/qt/css2.1/t040302-c61-phys-len-00-b-expected.txt:
  • platform/qt/css2.1/t040302-c61-rel-len-00-b-ag-expected.png: Added.
  • platform/qt/css2.1/t040302-c61-rel-len-00-b-ag-expected.txt:
  • platform/qt/css2.1/t040303-c62-percent-00-b-ag-expected.png:
  • platform/qt/css2.1/t040303-c62-percent-00-b-ag-expected.txt:
  • platform/qt/css2.1/t040304-c64-uri-00-a-g-expected.png: Added.
  • platform/qt/css2.1/t040304-c64-uri-00-a-g-expected.txt:
  • platform/qt/css2.1/t040306-c63-color-00-b-ag-expected.png: Added.
  • platform/qt/css2.1/t040306-c63-color-00-b-ag-expected.txt:
  • platform/qt/css2.1/t040306-syntax-01-f-expected.png: Added.
  • platform/qt/css2.1/t040306-syntax-01-f-expected.txt:
  • platform/qt/css2.1/t040307-syntax-01-b-expected.png: Added.
  • platform/qt/css2.1/t040307-syntax-01-b-expected.txt:
6:58 AM Changeset in webkit [123614] by kkristof@inf.u-szeged.hu
  • 6 edits in trunk/Tools

[NRWT] Rename baseline_search_path() to default_baseline_search_path()
https://bugs.webkit.org/show_bug.cgi?id=92122

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.baseline_version_dir):
(Port.baseline_search_path):
(Port):
(Port.default_baseline_search_path):
(Port.expected_baselines):

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_additional_platform_directory):

  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.default_baseline_search_path):

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort.default_baseline_search_path):

  • Scripts/webkitpy/layout_tests/port/win.py:

(WinPort.default_baseline_search_path):

6:52 AM Changeset in webkit [123613] by caio.oliveira@openbossa.org
  • 3 edits
    1 delete in trunk/LayoutTests

[Qt] Fix rebaseline for two tests in svg/hixie
https://bugs.webkit.org/show_bug.cgi?id=92244

Reviewed by Alexis Menard.

  • platform/qt-5.0/svg/hixie/intrinsic/003-expected.txt: Removed.
  • platform/qt/svg/hixie/error/017-expected.txt:
  • platform/qt/svg/hixie/intrinsic/003-expected.png:
6:48 AM Changeset in webkit [123612] by pfeldman@chromium.org
  • 18 edits
    2 adds in trunk

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=91931

Reviewed by Vsevolod Vlasov.

  • Synthetic shorthand values are now only returned for source-less styles
  • CSSAgents reports longhands along with the property names in getSupportedCSSProperties
  • StylesSidebarPane now has two paths: for source-enabled styles and for CSSOM-based ones (UA styles)
  • CSSStyleModel uses style metainfo as a source of shorthand / longhand relationship now

Test: inspector/styles/styles-overriden-properties.html

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getSupportedCSSProperties):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::styleWithProperties):

  • inspector/front-end/CSSCompletions.js:

(WebInspector.CSSCompletions):
(WebInspector.CSSCompletions.requestCSSNameCompletions):
(WebInspector.CSSCompletions.prototype._closest):
(WebInspector.CSSCompletions.prototype.longhands):
(WebInspector.CSSCompletions.prototype.shorthands):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleDeclaration):
(WebInspector.CSSStyleDeclaration.prototype.longhandProperties):
(WebInspector.CSSStyleDeclaration.prototype.shorthandValue):
(WebInspector.CSSStyleDeclaration.prototype.newBlankProperty):
(WebInspector.CSSProperty):
(WebInspector.CSSProperty.parsePayload):

  • inspector/front-end/SourceCSSTokenizer.js:

(WebInspector.SourceCSSTokenizer):

  • inspector/front-end/SourceCSSTokenizer.re2js:
  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.prototype.isPropertyOverloaded):
(WebInspector.StylePropertiesSection.prototype.update):
(WebInspector.StylePropertiesSection.prototype.onpopulate):
(WebInspector.StylePropertyTreeElement.prototype):

LayoutTests: Web Inspector: Redundant Style Declarations Missing in Styles Section
https://bugs.webkit.org/show_bug.cgi?id=91931

Reviewed by Vsevolod Vlasov.

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.dumpStyleTreeItem):

  • inspector/elements/elements-panel-styles-expected.txt:
  • inspector/styles/force-pseudo-state-expected.txt:
  • inspector/styles/inject-stylesheet-expected.txt:
  • inspector/styles/lazy-computed-style-expected.txt:
  • inspector/styles/styles-overriden-properties-expected.txt: Added.
  • inspector/styles/styles-overriden-properties.html: Added.
  • inspector/styles/styles-update-from-js-expected.txt:
  • platform/chromium/inspector/styles/inject-stylesheet-expected.txt: Removed.
6:31 AM Changeset in webkit [123611] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Skip 2 more tests because of minor 32/64 bit differences.
6:18 AM Changeset in webkit [123610] by jpetsovits@rim.com
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] notifyContentRendered() call missing in two spots
https://bugs.webkit.org/show_bug.cgi?id=92153
RIM PR 173340

Reviewed by Antonio Gomes.

In dispatchDidFirstVisualLayout() and repaint() in
immediate mode, we render but don't notify the
WebPageClient that the content was modified.

In the long run, we should probably keep track of
the modified reason from within render() itself
and use this to automatically notify the client
from within blitContents() and/or invalidateWindow(),
depending on the rendering path. That's somewhat of
a medium-size undertaking though; for now, adding
the call directly to the renderVisibleContents()
call sites will do.

This patch also adds a blitVisibleContents() to
dispatchDidFirstVisualLayout() where it was
inexplicably missing, probably on account of
old code that was never updated.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::repaint):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDidFirstVisuallyNonEmptyLayout):

6:00 AM Changeset in webkit [123609] by alexis.menard@openbossa.org
  • 27 edits
    2 adds in trunk/LayoutTests

[Qt] svg/dom, svg/filters, svg/foreignObject rebaseline after new test fonts.
https://bugs.webkit.org/show_bug.cgi?id=92243

Unreviewed gardening.

These tests have been skipped because monospace fonts weren't properly used by
layout tests. After r121971, the test results are normal again.

  • platform/qt-5.0/Skipped:
  • platform/qt/svg/dom/SVGPathSegList-cloning-expected.png:
  • platform/qt/svg/dom/SVGPathSegList-cloning-expected.txt:
  • platform/qt/svg/dom/SVGPathSegList-segment-modification-expected.png:
  • platform/qt/svg/dom/SVGPathSegList-segment-modification-expected.txt:
  • platform/qt/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png:
  • platform/qt/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.txt:
  • platform/qt/svg/filters/feColorMatrix-values-expected.txt:
  • platform/qt/svg/filters/feComposite-expected.png: Added.
  • platform/qt/svg/filters/feComposite-expected.txt:
  • platform/qt/svg/filters/filter-on-filter-for-text-expected.png:
  • platform/qt/svg/filters/filter-on-filter-for-text-expected.txt:
  • platform/qt/svg/filters/filter-on-tspan-expected.png:
  • platform/qt/svg/filters/filter-on-tspan-expected.txt:
  • platform/qt/svg/filters/filter-width-update-expected.png:
  • platform/qt/svg/filters/filter-width-update-expected.txt:
  • platform/qt/svg/filters/sourceAlpha-expected.png: Added.
  • platform/qt/svg/filters/sourceAlpha-expected.txt:
  • platform/qt/svg/foreignObject/fO-parent-display-changes-expected.txt:
  • platform/qt/svg/foreignObject/fO-parent-display-none-expected.txt:
  • platform/qt/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt:
  • platform/qt/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt:
  • platform/qt/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt:
  • platform/qt/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.png:
  • platform/qt/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.txt:
  • platform/qt/svg/foreignObject/svg-document-as-direct-child-expected.txt:
  • platform/qt/svg/foreignObject/svg-document-in-html-document-expected.png:
  • platform/qt/svg/foreignObject/svg-document-in-html-document-expected.txt:
5:32 AM Changeset in webkit [123608] by alexis.menard@openbossa.org
  • 69 edits
    2 adds in trunk/LayoutTests

[Qt] svg/hixie rebaseline after new test fonts.
https://bugs.webkit.org/show_bug.cgi?id=92242

Unreviewed gardening.

These tests have been skipped because monospace fonts weren't properly used by
layout tests. After r121971, the test results are normal again.

  • platform/qt-5.0/Skipped:
  • platform/qt/svg/hixie/dynamic/002-expected.txt:
  • platform/qt/svg/hixie/error/002-expected.txt:
  • platform/qt/svg/hixie/error/003-expected.png:
  • platform/qt/svg/hixie/error/003-expected.txt:
  • platform/qt/svg/hixie/error/010-expected.png:
  • platform/qt/svg/hixie/error/010-expected.txt:
  • platform/qt/svg/hixie/error/011-expected.png:
  • platform/qt/svg/hixie/error/011-expected.txt:
  • platform/qt/svg/hixie/error/013-expected.png:
  • platform/qt/svg/hixie/error/013-expected.txt:
  • platform/qt/svg/hixie/error/017-expected.png:
  • platform/qt/svg/hixie/error/017-expected.txt:
  • platform/qt/svg/hixie/intrinsic/001-expected.png:
  • platform/qt/svg/hixie/intrinsic/001-expected.txt:
  • platform/qt/svg/hixie/intrinsic/002-expected.png:
  • platform/qt/svg/hixie/intrinsic/002-expected.txt:
  • platform/qt/svg/hixie/intrinsic/003-expected.png:
  • platform/qt/svg/hixie/intrinsic/003-expected.txt:
  • platform/qt/svg/hixie/links/002-expected.png:
  • platform/qt/svg/hixie/links/002-expected.txt:
  • platform/qt/svg/hixie/mixed/003-expected.png:
  • platform/qt/svg/hixie/mixed/003-expected.txt:
  • platform/qt/svg/hixie/mixed/004-expected.txt: Added.
  • platform/qt/svg/hixie/mixed/005-expected.txt: Added.
  • platform/qt/svg/hixie/mixed/006-expected.png:
  • platform/qt/svg/hixie/mixed/006-expected.txt:
  • platform/qt/svg/hixie/mixed/007-expected.txt:
  • platform/qt/svg/hixie/mixed/008-expected.png:
  • platform/qt/svg/hixie/mixed/008-expected.txt:
  • platform/qt/svg/hixie/mixed/009-expected.png:
  • platform/qt/svg/hixie/mixed/009-expected.txt:
  • platform/qt/svg/hixie/mixed/010-expected.png:
  • platform/qt/svg/hixie/mixed/010-expected.txt:
  • platform/qt/svg/hixie/mixed/011-expected.png:
  • platform/qt/svg/hixie/mixed/011-expected.txt:
  • platform/qt/svg/hixie/perf/001-expected.txt:
  • platform/qt/svg/hixie/perf/002-expected.txt:
  • platform/qt/svg/hixie/perf/003-expected.png:
  • platform/qt/svg/hixie/perf/003-expected.txt:
  • platform/qt/svg/hixie/perf/004-expected.png:
  • platform/qt/svg/hixie/perf/004-expected.txt:
  • platform/qt/svg/hixie/perf/005-expected.png:
  • platform/qt/svg/hixie/perf/005-expected.txt:
  • platform/qt/svg/hixie/perf/006-expected.png:
  • platform/qt/svg/hixie/perf/006-expected.txt:
  • platform/qt/svg/hixie/perf/007-expected.png:
  • platform/qt/svg/hixie/perf/007-expected.txt:
  • platform/qt/svg/hixie/processing-model/003-expected.png:
  • platform/qt/svg/hixie/processing-model/003-expected.txt:
  • platform/qt/svg/hixie/processing-model/004-expected.png:
  • platform/qt/svg/hixie/processing-model/004-expected.txt:
  • platform/qt/svg/hixie/rendering-model/003-expected.png:
  • platform/qt/svg/hixie/rendering-model/003-expected.txt:
  • platform/qt/svg/hixie/rendering-model/004-expected.png:
  • platform/qt/svg/hixie/rendering-model/004-expected.txt:
  • platform/qt/svg/hixie/text/002-expected.png:
  • platform/qt/svg/hixie/text/002-expected.txt:
  • platform/qt/svg/hixie/text/003-expected.png:
  • platform/qt/svg/hixie/text/003-expected.txt:
  • platform/qt/svg/hixie/text/003a-expected.png:
  • platform/qt/svg/hixie/text/003a-expected.txt:
  • platform/qt/svg/hixie/text/003b-expected.png:
  • platform/qt/svg/hixie/text/003b-expected.txt:
  • platform/qt/svg/hixie/viewbox/002-expected.txt:
  • platform/qt/svg/hixie/viewbox/003-expected.txt:
  • platform/qt/svg/hixie/viewbox/preserveAspectRatio/001-expected.png:
  • platform/qt/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
  • platform/qt/svg/hixie/viewbox/preserveAspectRatio/002-expected.png:
  • platform/qt/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt:
5:28 AM Changeset in webkit [123607] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-4.8/Skipped: Unskip now passing tests. (bug85203)
  • platform/qt/Skipped: Skip new tests without expected files.
4:57 AM Changeset in webkit [123606] by keishi@webkit.org
  • 3 edits
    3 adds in trunk

Implement ColorSuggestionPicker page popup
https://bugs.webkit.org/show_bug.cgi?id=92109

Reviewed by Kent Tamura.

.:

  • ManualTests/forms/color-suggestion-picker.html: Added. Tests colorSuggestionPicker.{js,css}

Source/WebCore:

Implements ColorSuggestionPicker page popup. This will be used in
certain ports as the datalist UI for <input type=color>.

No new tests because there is no way to open the popup yet.

  • Resources/colorSuggestionPicker.css: Added.

(body):
(#main):
(.color-swatch):
(.color-swatch:hover):
(.color-swatch-container):
(.other-color):

  • Resources/colorSuggestionPicker.js: Added.

(getScrollbarWidth):When there are more than 20 colors we need to
increase the window width to accommodate the scroll bar.
(createElement):
(handleMessage):
(initialize):
(handleArgumentsTimeout):
(validateArguments):
(submitValue): Calls setValueAndClosePopup with a numValue of 0.
(handleCancel): Calls setValueAndClosePopup with a numValue of -1.
(chooseOtherColor): Calls setValueAndClosePopup with a numValue of -2.
(ColorPicker):
(ColorPicker.prototype._layout): Lays out the color swatches in a 5x4
grid.
(ColorPicker.prototype._handleSwatchClick):

  • WebCore.gyp/WebCore.gyp:
4:54 AM Changeset in webkit [123605] by allan.jensen@nokia.com
  • 2 edits in trunk/Source/WebCore

Fix arithmetic composite filter for auto-vectorization
https://bugs.webkit.org/show_bug.cgi?id=92123

Reviewed by Nikolas Zimmermann.

Since only clamping of the result prevents GCC from auto-vectorizing the inner loop, this patch
adds a faster version of the inner loop to handle cases where clamping is unnecessary,

  • platform/graphics/filters/FEComposite.cpp:

(WebCore::computeArithmeticPixelsUnclamped):
(WebCore::arithmeticSoftware):

4:46 AM Changeset in webkit [123604] by gyuyoung.kim@samsung.com
  • 19 edits in trunk

[EFL] Use eina_stringshare_add instead of strdup.
https://bugs.webkit.org/show_bug.cgi?id=92072

Reviewed by Kentaro Hara.

Eina of EFL libraries supports a string functionality that replaces strdup. So, EFL port needs
to replace strdup with eina_stringshare_add function.

Source/WebKit/efl:

In addition, some API descriptions need to be modified according to ewk APIs's parameter and
return type change.

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::runJavaScriptPrompt):

  • ewk/ewk_cookies.cpp:

(ewk_cookies_get_all):
(ewk_cookies_cookie_free):

  • ewk/ewk_cookies.h:
  • ewk/ewk_frame.cpp:

(ewk_frame_script_execute):
(ewk_frame_selection_get):
(ewk_frame_resources_location_get):
(ewk_frame_plain_text_get):

  • ewk/ewk_frame.h:
  • ewk/ewk_intent.cpp:

(ewk_intent_suggestions_get):
(ewk_intent_extra_get):
(ewk_intent_extra_names_get):

  • ewk/ewk_intent.h:
  • ewk/ewk_js.cpp:

(ewk_js_variant_to_npvariant):
(ewk_js_object_new):

  • ewk/ewk_view.cpp:

(_ewk_view_smart_run_javascript_prompt):
(ewk_view_selection_get):
(ewk_view_run_javascript_prompt):
(ewk_view_run_open_panel):

  • ewk/ewk_view.h:
  • ewk/ewk_view_private.h:

Source/WebKit2:

  • UIProcess/API/efl/ewk_intent.cpp:

(ewk_intent_suggestions_get):
(ewk_intent_extra_get):

  • UIProcess/API/efl/ewk_intent.h:

Tools:

DumpRenderTree also needs to be modified according to ewk APIs's parameter change.

  • DumpRenderTree/efl/DumpRenderTree.cpp:

(dumpFramesAsText):

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::onFrameIntentNew):

  • DumpRenderTree/efl/DumpRenderTreeView.cpp:

(onJavaScriptPrompt):

4:28 AM Changeset in webkit [123603] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

[EFL] Rebaseline for changed mathml dump after r123492
https://bugs.webkit.org/show_bug.cgi?id=92234

Unreviewed, EFL rebaseline.

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-07-25

  • platform/efl/mathml/msub-anonymous-child-render-crash-expected.txt: Added.
4:15 AM Changeset in webkit [123602] by allan.jensen@nokia.com
  • 2 edits in trunk/Source/WebCore

Fix blend filter for autovectorizing
https://bugs.webkit.org/show_bug.cgi?id=91398

Reviewed by Nikolas Zimmermann.

Get rid of wrapper classes, and use functions directly as template argument.

  • platform/graphics/filters/FEBlend.cpp:

(WebCore::feBlendNormal):
(WebCore::feBlendMultiply):
(WebCore::feBlendScreen):
(WebCore::feBlendDarken):
(WebCore::feBlendLighten):
(WebCore::feBlendUnknown):
(WebCore::platformApply):
(WebCore::FEBlend::platformApplyGeneric):

4:03 AM Changeset in webkit [123601] by keishi@webkit.org
  • 5 edits in trunk/Source/WebCore

Add methods to ColorChooserClient so the color chooser can show suggestions
https://bugs.webkit.org/show_bug.cgi?id=92114

Reviewed by Kent Tamura.

Added methods to ColorChooserClient so the color chooser can ask the
client for suggestions and current color.

No new tests. The methods are not used yet.

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::currentColor): Returns what color the color
chooser should display.
(WebCore):
(WebCore::ColorInputType::shouldShowSuggestions): Returns if the UI for
suggestions should be shown.
(WebCore::ColorInputType::suggestions): Returns a list of colors to be
suggested to the user.

  • html/ColorInputType.h:

(ColorInputType):

  • html/HTMLInputElement.h:

(HTMLInputElement): Made dataList() public.

  • platform/ColorChooserClient.h:

(ColorChooserClient):

3:35 AM Changeset in webkit [123600] by haraken@chromium.org
  • 11 edits in trunk/Source/WebCore

Replace int with long in test IDL files
https://bugs.webkit.org/show_bug.cgi?id=92181

Reviewed by Adam Barth.

int is not a valid type in WebIDL. It should be long.
We should replace int with long in bindings/scripts/test/*.idl.
This is a follow-up patch for r123550.

Test: bindings/scripts/test/TestObj.idl

  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:

(WebDOMTestObj::readOnlyLongAttr):
(WebDOMTestObj::Attr):
(WebDOMTestObj::setAttr):
(WebDOMTestObj::voidMethodWithArgs):
(WebDOMTestObj::Method):
(WebDOMTestObj::MethodWithArgs):
(WebDOMTestObj::objMethodWithArgs):

  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
(webkit_dom_test_obj_void_method_with_args):
(webkit_dom_test_obj_method):
(webkit_dom_test_obj_method_with_args):
(webkit_dom_test_obj_obj_method_with_args):
(webkit_dom_test_obj_get_read_only_long_attr):
(webkit_dom_test_obj_get_attr):
(webkit_dom_test_obj_set_attr):
(webkit_dom_test_obj_get_strawberry):
(webkit_dom_test_obj_set_strawberry):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):
(WebCore::jsTestObjReadOnlyLongAttr):
(WebCore::jsTestObjConstructorStaticReadOnlyLongAttr):
(WebCore::jsTestObjAttr):
(WebCore::setJSTestObjAttr):
(WebCore::setJSTestObjStrawberry):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethod):
(WebCore::jsTestObjPrototypeFunctionMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodReturningSequence):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj readOnlyLongAttr]):
(-[DOMTestObj Attr]):
(-[DOMTestObj setAttr:]):
(-[DOMTestObj voidMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj Method]):
(-[DOMTestObj MethodWithArgs:strArg:objArg:]):
(-[DOMTestObj objMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj customMethodWithArgs:strArg:objArg:]):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::readOnlyLongAttrAttrGetter):
(WebCore::TestObjV8Internal::staticReadOnlyLongAttrAttrGetter):
(WebCore::TestObjV8Internal::AttrAttrGetter):
(WebCore::TestObjV8Internal::AttrAttrSetter):
(WebCore::TestObjV8Internal::strawberryAttrSetter):
(WebCore::TestObjV8Internal::voidMethodWithArgsCallback):
(WebCore::TestObjV8Internal::MethodCallback):
(WebCore::TestObjV8Internal::MethodWithArgsCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodReturningSequenceCallback):
(WebCore::TestObjV8Internal::overloadedMethod2Callback):
(WebCore::TestObjV8Internal::overloadedMethod4Callback):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):

3:26 AM Changeset in webkit [123599] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[WTR][EFL] Wheel events are not emitted
https://bugs.webkit.org/show_bug.cgi?id=92094

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-07-25
Reviewed by Csaba Osztrogonác.

Wheel events are not emitted, therefore, layout tests that use mouseScrollBy method are failing.

  • WebKitTestRunner/efl/EventSenderProxyEfl.cpp:

(WTR::dispatchMouseScrollByEvent):
(WTR::EventSenderProxy::mouseScrollBy):

  • WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::focus):

3:09 AM Changeset in webkit [123598] by shinyak@chromium.org
  • 3 edits
    2 adds in trunk

A validation bubble should not be modifiable.
https://bugs.webkit.org/show_bug.cgi?id=92217

Reviewed by Kent Tamura.

Source/WebCore:

A user can set -webkit-user-modify: read-write to validation message elements.
This might cause a undesired crash like Bug 65738. They should be unmodifiable.

Test: fast/forms/validation-user-modify.html

  • css/html.css:

Added -webkit-user-modify: read-only !important; for these elements so that they won't be
changed by a user.
(::-webkit-validation-bubble):
(::-webkit-validation-bubble-message):
(::-webkit-validation-bubble-text-block):
(::-webkit-validation-bubble-heading):
(::-webkit-validation-bubble-arrow):
(::-webkit-validation-bubble-arrow-clipper):

LayoutTests:

  • fast/forms/validation-message-user-modify-expected.txt: Added.
  • fast/forms/validation-message-user-modify.html: Added.
3:00 AM Changeset in webkit [123597] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk/Source/WebKit

[EFL] Add File Chooser API
https://bugs.webkit.org/show_bug.cgi?id=91957

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-07-25
Reviewed by Hajime Morita.

Source/WebKit:

Add ewk_file_chooser source and header.

  • PlatformEfl.cmake:

Source/WebKit/efl:

Add APIs for file chooser. These APIs allow an application(like a browser) queries informations
about multiple files allowed, directory upload allowed, accept mimetypes list,
accept file extentions list, selected files list and capture to support HTML media capture.

  • ewk/EWebKit.h:
  • ewk/ewk_file_chooser.cpp: Added.

(_Ewk_File_Chooser):
(ewk_file_chooser_allows_multiple_files_get):
(ewk_file_chooser_allows_directory_upload_get):
(ewk_file_chooser_accept_mimetypes_get):
(ewk_file_chooser_accept_file_extentions_get):
(ewk_file_chooser_selected_files_get):
(ewk_file_chooser_capture_get):
(ewk_file_chooser_new):
(ewk_file_chooser_free):

  • ewk/ewk_file_chooser.h: Added.
  • ewk/ewk_file_chooser_private.h: Added.

(WebCore):

2:54 AM Changeset in webkit [123596] by Csaba Osztrogonác
  • 3 edits
    15 adds in trunk/LayoutTests

[Qt] Unreviewed gardening, update Qt5 specific test results.

  • platform/qt-5.0-wk1/fast/text/whitespace/028-expected.png: Added.
  • platform/qt-5.0-wk1/fast/text/whitespace/028-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/text/whitespace/028-expected.png: Added.
  • platform/qt-5.0-wk2/fast/text/whitespace/028-expected.txt: Added.
  • platform/qt-5.0/css2.1/t0805-c5519-brdr-r-01-e-expected.png: Added.
  • platform/qt-5.0/css2.1/t0805-c5519-brdr-r-01-e-expected.txt: Added.
  • platform/qt-5.0/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/qt-5.0/svg/as-image/img-preserveAspectRatio-support-1-expected.txt:
  • platform/qt-5.0/svg/as-object/object-box-sizing-no-width-height-expected.png: Added.
  • platform/qt-5.0/svg/as-object/object-box-sizing-no-width-height-expected.txt: Added.
  • platform/qt-5.0/svg/batik/text/longTextOnPath-expected.png: Added.
  • platform/qt-5.0/svg/batik/text/longTextOnPath-expected.txt: Added.
  • platform/qt-5.0/svg/carto.net/tabgroup-expected.png: Added.
  • platform/qt-5.0/svg/carto.net/tabgroup-expected.txt: Added.
2:43 AM Changeset in webkit [123595] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-07-25

  • platform/qt/Skipped:
2:30 AM Changeset in webkit [123594] by zandobersek@gmail.com
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed GTK gardening, updating one mathml test baseline after r123492.

  • platform/gtk/mathml/msub-anonymous-child-render-crash-expected.txt: Added.
2:16 AM Changeset in webkit [123593] by ryuan.choi@samsung.com
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] Add ewk_view_cursor_set to change cursor.
https://bugs.webkit.org/show_bug.cgi?id=89140

Reviewed by Hajime Morita.

Implement ewk_view_cursor_set to support cursor changes.

  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::setCursor): Called ewk_view_cursor_set.

  • UIProcess/API/efl/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::~_Ewk_View_Private_Data):
(_ewk_view_priv_new): Check whether ecore_x can be used.
(_ewk_view_smart_add):
Change order of initialization to use base structure in _ewk_view_priv_new.
(ewk_view_cursor_set): Added to set cursor.

  • UIProcess/API/efl/ewk_view_private.h:
2:05 AM Changeset in webkit [123592] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-07-25

  • platform/qt/Skipped:
2:03 AM Changeset in webkit [123591] by ryuan.choi@samsung.com
  • 6 edits
    1 add in trunk/Source/WebKit2

[EFL][WK2] Update uri when the active URI is changed while loading.
https://bugs.webkit.org/show_bug.cgi?id=92001

Reviewed by Hajime Morita.

For now, ewk_view_uri_get just return the last uri of setter.
This patch updates the uri of ewk_view when it is changed while loading.

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_uri_update):
Added to check whether current active URI has changed and send uri,changed
signal if it has changed.
(ewk_view_uri_set):
Called ewk_view_uri_update to make sure the active uri is updated when the
load operation is started.
(ewk_view_reload): Ditto.
(ewk_view_reload_bypass_cache): Ditto.
(ewk_view_load_finished): Ditto.
(ewk_view_load_provisional_redirect): Ditto.
(ewk_view_load_provisional_started): Ditto.
(ewk_view_html_string_load): Ditto.

  • UIProcess/API/efl/ewk_view.h: Updated comment for uri,changed signal.
  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.cpp:

(EWK2UnitTest::EWK2UnitTestEnvironment::urlForResource):
Added to get url of custom resource for test.

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h:
  • UIProcess/API/efl/tests/resources/redirect_uri_to_default.html:

Added to test ewk_view_uri_get when the page is redirected.

  • UIProcess/API/efl/tests/test_ewk2_view.cpp: Ditto.

(onLoadFinishedForRedirection):
(TEST_F): Added new test case whether ewk_view_uri_get returns correct uri when
the page is redirected.

2:00 AM Changeset in webkit [123590] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WTF

[Qt] There are parallel GC related crashes regularly
https://bugs.webkit.org/show_bug.cgi?id=90957

Rubber-stamped by Zoltan Herczeg.

  • wtf/Platform.h: Disable parallel GC temporarily on Qt until proper fix.
1:55 AM EFLWebKit edited by dominik.rottsches@intel.com
harfbuzz dependency (diff)
1:42 AM Changeset in webkit [123589] by morrita@google.com
  • 2 edits in trunk/Source/WebKit/chromium

Another unreviewed win build fix against r123569.

  • tests/IDBAbortOnCorruptTest.cpp:
1:35 AM Changeset in webkit [123588] by zeno.albisser@nokia.com
  • 2 edits in trunk/Source/WebCore

[Qt][WK2] Disable CopyToTexture for GraphicsSurfaceMac.
https://bugs.webkit.org/show_bug.cgi?id=92159

Disable CopyToTexture feature for GraphicsSurface on Mac.
While this is actually working, it is currently used for Tiles
that are single buffered, and therefore requires a call to glFlush.
This call blocks the GPU for about 40ms which would make smooth animations impossible.

Reviewed by Noam Rosenthal.

  • platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:

(WebCore::GraphicsSurface::platformCreate):
(WebCore::GraphicsSurface::platformImport):

1:30 AM Changeset in webkit [123587] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

[EFL][WK2] Add ewk_main.{cpp,h} to EFL WK2
https://bugs.webkit.org/show_bug.cgi?id=92101

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-07-25
Reviewed by Kenneth Rohde Christiansen.

Added a centralized place for general initialization in UI process for EFL WK2.

Source/WebKit2:

  • PlatformEfl.cmake:
  • UIProcess/API/efl/EWebKit2.h:
  • UIProcess/API/efl/ewk_main.cpp: Added.

(ewk_init): General initialization.
(ewk_shutdown): General freeing.
(_ewk_init_body): An aux function.

  • UIProcess/API/efl/ewk_main.h: Added.

Tools:

  • MiniBrowser/efl/main.c: Added using of newly added ewk_init() and ewk_shutdown() functions.

(main):

  • WebKitTestRunner/efl/main.cpp: Ditto.

(main):

1:18 AM Changeset in webkit [123586] by bashi@chromium.org
  • 7 edits in trunk/Source/WebCore

[Chromium] Fix up includes in HarfBuzzNGFace.h
https://bugs.webkit.org/show_bug.cgi?id=92127

Reviewed by Hajime Morita.

Move constructors of FontPlatformData from headers to corresponding cpp files
so that we can use forward declaration for HarfBuzzNGFace instead of including HarfBuzzNGFace.h.
This way we can include hb.h in HarfBuzzNGFace.h.

No new tests. No changes in behavior.

  • platform/graphics/FontPlatformData.cpp:

(WebCore::FontPlatformData::FontPlatformData): Moved from header file.
(WebCore):

  • platform/graphics/FontPlatformData.h:

(WebCore):
(FontPlatformData): Moved to cpp file.

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm: Include HarfBuzzNGFace.h
  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:

(WebCore::FontPlatformData::FontPlatformData): Moved from header file.
(WebCore):

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:

(WebCore):
(FontPlatformData): Moved to cpp file.

  • platform/graphics/harfbuzz/ng/HarfBuzzNGFace.h: Include hb.h.
1:00 AM Changeset in webkit [123585] by morrita@google.com
  • 3 edits in trunk/Source/WebKit/chromium

Unreviewed win build fix against r123569.

  • tests/IDBAbortOnCorruptTest.cpp:
  • tests/IDBDatabaseBackendTest.cpp:
12:42 AM Changeset in webkit [123584] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r123505): Date.getYear() returns the same as Date.getFullYear()
https://bugs.webkit.org/show_bug.cgi?id=92218

Reviewed by Csaba Osztrogonác.

  • runtime/DatePrototype.cpp:

(JSC::dateProtoFuncGetYear): Added the missing offset of 1900 to the return value.

12:32 AM Changeset in webkit [123583] by zandobersek@gmail.com
  • 2 edits
    1 add
    6 deletes in trunk/LayoutTests

fast/events/panScroll-click-hyperlink.html test should be put in platform/win
https://bugs.webkit.org/show_bug.cgi?id=92111

Reviewed by Daniel Bates.

Move the test into platform/win directory where other pan scrolling tests reside,
and remove other ports' baselines as they just indicated that pan scrolling is not
supported on those platforms. chromium-win and qt-win platforms still pass the test
but should cope with the default baseline just fine.

  • platform/chromium-linux/fast/events/panScroll-click-hyperlink-expected.txt: Removed.
  • platform/chromium-win/fast/events/panScroll-click-hyperlink-expected.txt: Removed.
  • platform/efl/fast/events/panScroll-click-hyperlink-expected.txt: Removed.
  • platform/gtk/TestExpectations:
  • platform/mac/fast/events/panScroll-click-hyperlink-expected.txt: Removed.
  • platform/qt/fast/events/panScroll-click-hyperlink-expected.txt: Removed.
  • platform/win/fast/events/panScroll-click-hyperlink.html: Renamed from LayoutTests/fast/events/panScroll-click-hyperlink.html.
12:22 AM Changeset in webkit [123582] by benjamin@webkit.org
  • 7 edits
    1 add in trunk

QualifiedName's HashSet should be big enough to hold at least all the static names
https://bugs.webkit.org/show_bug.cgi?id=91891

Patch by Benjamin Poulain <bpoulain@apple.com> && Joseph Pecoraro <Joseph Pecoraro> on 2012-07-24
Reviewed by Darin Adler.

Source/WebCore:

QualifiedName's table has a standard size of 64 buckets. When initializing WebKit,
we create 850 static QualifiedName for the standard names (HTMLNames, SVGNames etc).

The small base size forces us to grow and rehash the table several time on startup.

This patch solves the issue by defining the initial table size to the minimum size that
can hold all the static QualifiedName.

  • dom/QualifiedName.cpp:

(QualifiedNameHashTraits):

  • dom/make_names.pl:

(printNamesHeaderFile):

Source/WTF:

Add a static struct to compute the HashTable capacity for any given size at compile time.
This allow us to create HashTraits giving the minimumSize without hardcoding the values.

  • wtf/HashTable.h:

(OneifyLowBits):
(UpperPowerOfTwoBound):
(HashTableCapacityForSize): Compute the HashTable capacity at compile time.

Tools:

Add a test for WTF::hashTableCapacityForSize.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/HashSet.cpp: Added.

(InitialCapacityTestHashTraits):
(TestWebKitAPI::testInitialCapacity):
(TestWebKitAPI::generateTestCapacityUpToSize):
(TestWebKitAPI::TEST):

Jul 24, 2012:

11:52 PM Changeset in webkit [123581] by kseo@webkit.org
  • 9 edits in trunk/Source/WebCore

Remove anonymous namespace and make functions static.
https://bugs.webkit.org/show_bug.cgi?id=92214

Reviewed by Adam Barth.

Mark functions as static instead of enclosing them in anonymous namespaces.
One exception to this rule is when a function is passed as a template argument.
In this case, the function must have an external linkage.

No functional change. Covered by existing tests.

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::hasImpliedEndTag):
(WebCore::causesFosterParenting):
(WebCore::isAllWhitespace):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore):
(WebCore::tokenizerStateForContextElement):

  • html/parser/HTMLElementStack.cpp:

(WebCore::isNumberedHeaderElement):
(WebCore::isRootNode):
(WebCore):

  • html/parser/HTMLEntityParser.cpp:

(WebCore::isAlphaNumeric):

  • html/parser/HTMLEntitySearch.cpp:

(WebCore::halfway):

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore):

  • html/parser/HTMLTokenizer.cpp:

(WebCore::toLowerCase):
(WebCore::vectorEqualsString):
(WebCore::isEndTagBufferingState):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore):
(WebCore::uninitializedPositionValue1):
(WebCore::isAllWhitespace):
(WebCore::isAllWhitespaceOrReplacementCharacters):
(WebCore::isNumberedHeaderTag):
(WebCore::isCaptionColOrColgroupTag):
(WebCore::isTableCellContextTag):
(WebCore::isTableBodyContextTag):
(WebCore::isSpecialNode):
(WebCore::isNonAnchorNonNobrFormattingTag):
(WebCore::isNonAnchorFormattingTag):
(WebCore::isFormattingTag):
(WebCore::closestFormAncestor):
(WebCore::mapLoweredLocalNameToName):
(WebCore::adjustSVGTagNameCase):
(WebCore::adjustAttributes):
(WebCore::adjustSVGAttributes):
(WebCore::adjustMathMLAttributes):
(WebCore::addNamesWithPrefix):
(WebCore::adjustForeignAttributes):

11:40 PM Changeset in webkit [123580] by abarth@webkit.org
  • 3 edits in trunk/Tools

The EWS bots get flaky when we hit the failure limit
https://bugs.webkit.org/show_bug.cgi?id=92212

Reviewed by Eric Seidel.

Previously we were missing some failure types, which means we didn't
notice that the bots were hitting the failure limit.

  • Scripts/webkitpy/common/net/layouttestresults.py:

(LayoutTestResults.failing_test_results):

  • Scripts/webkitpy/common/net/layouttestresults_unittest.py:

(LayoutTestResultsTest.test_results_from_string):
(LayoutTestResultsTest.test_tests_matching_failure_types):

11:01 PM Changeset in webkit [123579] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed r123494 follow-up: fixed inspector undock icon.

  • inspector/front-end/Images/statusbarButtonGlyphs.png:
10:53 PM Changeset in webkit [123578] by yosin@chromium.org
  • 1 edit
    1 copy in trunk/LayoutTests

[Tests] Copy fast/forms/number/number-spinbutton-change-and-input-events.html to fast/forms/js/resources
https://bugs.webkit.org/show_bug.cgi?id=92209

Reviewed by Kent Tamura.

This patch copies test file fast/forms/number/number-spinbutton-change-and-input-events.html
to JavaScript code directory fast/forms/resources as common-spinbutton-change-and-input-events.js
for sharing code with other input types.

This patch is preparation of re-factoring.

  • fast/forms/resources/common-spinbutton-change-and-input-events.js: Copied from LayoutTests/fast/forms/number/number-spinbutton-change-and-input-events.html.
10:47 PM Changeset in webkit [123577] by kseo@webkit.org
  • 8 edits in trunk/Source/WebCore

Read tag names and attributes from the saved tokens where possible.
https://bugs.webkit.org/show_bug.cgi?id=92079

Reviewed by Adam Barth.

Read tag names and attributes from the saved tokens, not from the DOM.
Also added convenient methods such as hasLocalName, hasTagName, localName,
isElementNode and isDocumentFragmentNode to HTMLStackItem class.

No new tests, covered by existing tests.

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLNames::hasImpliedEndTag):
(WebCore::HTMLNames::causesFosterParenting):
(WebCore::HTMLConstructionSite::generateImpliedEndTagsWithExclusion):
(WebCore::HTMLConstructionSite::generateImpliedEndTags):
(WebCore::HTMLConstructionSite::shouldFosterParent):

  • html/parser/HTMLConstructionSite.h:

(WebCore::HTMLConstructionSite::currentStackItem):

  • html/parser/HTMLElementStack.cpp:

(WebCore::HTMLNames::isNumberedHeaderElement):
(WebCore::HTMLNames::isRootNode):
(WebCore::HTMLNames::isScopeMarker):
(WebCore::HTMLNames::isListItemScopeMarker):
(WebCore::HTMLNames::isTableScopeMarker):
(WebCore::HTMLNames::isTableBodyScopeMarker):
(WebCore::HTMLNames::isTableRowScopeMarker):
(WebCore::HTMLNames::isForeignContentScopeMarker):
(WebCore::HTMLNames::isButtonScopeMarker):
(WebCore::HTMLNames::isSelectScopeMarker):
(WebCore::HTMLElementStack::ElementRecord::replaceElement):
(WebCore::HTMLElementStack::popUntilNumberedHeaderElementPopped):
(WebCore::HTMLElementStack::popUntilTableScopeMarker):
(WebCore::HTMLElementStack::popUntilTableBodyScopeMarker):
(WebCore::HTMLElementStack::popUntilTableRowScopeMarker):
(WebCore::HTMLElementStack::isMathMLTextIntegrationPoint):
(WebCore::HTMLElementStack::isHTMLIntegrationPoint):
(WebCore::HTMLElementStack::popUntilForeignContentScopeMarker):
(WebCore::HTMLElementStack::pushRootNode):
(WebCore::HTMLElementStack::oneBelowTop):
(WebCore::HTMLElementStack::topmost):
(WebCore):
(WebCore::inScopeCommon):
(WebCore::HTMLElementStack::hasNumberedHeaderElementInScope):
(WebCore::HTMLElementStack::inScope):

  • html/parser/HTMLElementStack.h:

(WebCore::HTMLElementStack::topStackItem):
(HTMLElementStack):
(WebCore::isInHTMLNamespace):

  • html/parser/HTMLStackItem.h:

(WebCore::HTMLStackItem::isDocumentFragmentNode):
(WebCore::HTMLStackItem::isElementNode):
(HTMLStackItem):
(WebCore::HTMLStackItem::hasLocalName):
(WebCore::HTMLStackItem::hasTagName):
(WebCore::HTMLStackItem::HTMLStackItem):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore):
(WebCore::HTMLTreeBuilder::constructTreeFromAtomicToken):
(WebCore::HTMLTreeBuilder::processFakeEndTag):
(WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
(WebCore::HTMLTreeBuilder::furthestBlockForFormattingElement):
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
(WebCore::HTMLTreeBuilder::processEndTagForInTableBody):
(WebCore::HTMLTreeBuilder::processEndTagForInCell):
(WebCore::HTMLTreeBuilder::processEndTagForInBody):
(WebCore::HTMLTreeBuilder::processCaptionEndTagForInCaption):
(WebCore::HTMLTreeBuilder::processTrEndTagForInRow):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processCharacterBuffer):
(WebCore::HTMLTreeBuilder::processEndOfFile):
(WebCore::HTMLTreeBuilder::shouldProcessTokenInForeignContent):
(WebCore::HTMLTreeBuilder::processTokenInForeignContent):

  • html/parser/HTMLTreeBuilder.h:
10:28 PM Changeset in webkit [123576] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-24

  • DEPS:
10:18 PM Changeset in webkit [123575] by yosin@chromium.org
  • 4 edits
    2 moves in trunk/LayoutTests

[Tests] Rename fast/number/number-events.html to number-spinbutton-change-and-input-events.html
https://bugs.webkit.org/show_bug.cgi?id=92208

Reviewed by Kent Tamura.

This patch renames fast/forms/number/number-events.html to number-spinbutton-change-and-input-events.html
to make file name explains what test will be done.

  • fast/forms/number/number-events-expected.txt: Removed.
  • fast/forms/number/number-events.html: Removed.
  • fast/forms/number/number-spinbutton-change-and-input-events-expected.txt: Copied from LayoutTests/fast/forms/number/number-events-expected.txt.
  • fast/forms/number/number-spinbutton-change-and-input-events.html: Copied from LayoutTests/fast/forms/number/number-events.html.
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
10:04 PM Changeset in webkit [123574] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Move renderingStats from WebView to WebWidget.
https://bugs.webkit.org/show_bug.cgi?id=92184

Patch by Dave Tu <dtu@chromium.org> on 2012-07-24
Reviewed by Adam Barth.

We are going to add some rendering stats that work in non-composited mode, so the renderingStats() method should be moved from WebView to WebWidget.

  • public/WebView.h:

(WebKit):
(WebView):

  • public/WebWidget.h:

(WebKit):
(WebWidget):
(WebKit::WebWidget::renderingStats):

  • src/WebViewImpl.h:

(WebViewImpl):

10:00 PM Changeset in webkit [123573] by yosin@chromium.org
  • 4 edits
    2 deletes in trunk/LayoutTests

[Tests] Remove duplicated fast/forms/number/number-spinbutton-events.html
https://bugs.webkit.org/show_bug.cgi?id=92205

Reviewed by Kent Tamura.

This patch removes fast/forms/number/number-spinbutton-events.html
because fast/forms/number/number-events.html covers and checked more.

r108955 is an evidence of coverage.

  • fast/forms/number/number-spinbutton-events-expected.txt: Removed.
  • fast/forms/number/number-spinbutton-events.html: Removed.
  • platform/efl/Skipped:
  • platform/qt-arm/TestExpectations:
  • platform/win/Skipped:
9:51 PM Changeset in webkit [123572] by hbono@chromium.org
  • 12 edits
    2 adds in trunk

Avoid moving child objects multiple times when vertical scrollbar are shown at the left side.
https://bugs.webkit.org/show_bug.cgi?id=91756

Reviewed by Tony Chang.

Source/WebCore:

My r123067 moves the top-left origin of an RTL element right when its vertical
scrollbar is shown at its left side. (That is, r123067 moves all child objects
in the RTL element right.) This change also increases RenderBox::clientLeft()
at the same time, i.e. it also moves child objects right. Furthermore, my r109512
moves positioned objects in an RTL element right at the same time. This makes
WebKit move objects in an RTL element up to three times by the scrollbar width.
(Moving an absolute object right increases the scrollWidth value and it causes
this bug.) This change removes unnecessary code that moves objects right in my
r109512 and RenderBox::clientLeft().

Test: scrollbars/rtl/div-absolute.html

fast/block/float/026.html
fast/block/float/028.html
fast/overflow/unreachable-overflow-rtl-bug.html

  • dom/Element.cpp:

(WebCore::Element::clientLeft): Increase clientLeft value by the width of a vertical scrollbar as written in the CSSOM specification.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addOverflowFromPositionedObjects): Removed unnecessary code.
(WebCore::RenderBlock::determineLogicalLeftPositionForChild): Removed unnecessary code.

  • rendering/RenderBox.h:

(WebCore::RenderBox::clientLeft): Removed unnecessary code.

LayoutTests:

This change adds a test that compares CSSOM properties of an RTL element which
includes positioned objects with the CSSOM properties of an LTR one. This change
also uses clientLeft properties in offsetX-offsetY.html to remove a hard-coded
value in the test and adds rebaselined results for Windows.

  • fast/events/offsetX-offsetY.html: Replaced a hard-coded value 'borderLeft' with clientLeft.
  • platform/chromium-linux/fast/block/float/026-expected.png:
  • platform/chromium-linux/fast/block/float/028-expected.png:
  • platform/chromium-win/fast/block/float/026-expected.png:
  • platform/chromium-win/fast/block/float/028-expected.png:
  • platform/chromium-win/fast/overflow/unreachable-overflow-rtl-bug-expected.png:
  • platform/chromium-win/fast/overflow/unreachable-overflow-rtl-bug-expected.txt:
  • scrollbars/rtl/div-absolute-expected.txt: Added.
  • scrollbars/rtl/div-absolute.html: Added.
9:42 PM Changeset in webkit [123571] by mitz@apple.com
  • 3 edits
    2 adds in trunk

RenderBlock::positionForPoint can fail when the block or its children have a vertical writing mode
https://bugs.webkit.org/show_bug.cgi?id=92202

Reviewed by Beth Dakin.

Source/WebCore:

Test: fast/writing-mode/positionForPoint.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::positionForPoint): Fixed two issues, each of which are covered by
one of the sub-tests in the new regression test: (1) changed to compare children’s logical
bounds against pointInLogicalContents, i.e. compare childern’s horizontal bounds to the
point’s horizontal component; and (2) changed to use logicalTopForChild and
logicalHeightForChild, which account for this block’s writing mode, instead of logicalTop
and logicalBottom, which are based on the child’s writing mode.

LayoutTests:

  • fast/writing-mode/positionForPoint-expected.txt: Added.
  • fast/writing-mode/positionForPoint.html: Added.
9:13 PM Changeset in webkit [123570] by morrita@google.com
  • 3 edits
    2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=89179
Rendering LI having Shadow DOM seems weird

Reviewed by Dimitri Glazkov.

Source/WebCore:

This incorrect rendering happend because HTMLLIElement::attach()
wasn't aware of composed shadow subtree. This change makes it
aware of that using ComposedShadowTreeParentWalker.

Test: fast/dom/shadow/shadow-and-list-elements.html

  • html/HTMLLIElement.cpp:

(WebCore::HTMLLIElement::attach):

LayoutTests:

  • fast/dom/shadow/shadow-and-list-elements-expected.html: Added.
  • fast/dom/shadow/shadow-and-list-elements.html: Added.
8:25 PM Changeset in webkit [123569] by commit-queue@webkit.org
  • 9 edits in trunk/Source

IndexedDB: fix #include dependencies so IDBRequest isn't an include root
https://bugs.webkit.org/show_bug.cgi?id=92167

Patch by Alec Flett <alecflett@chromium.org> on 2012-07-24
Reviewed by Tony Chang.

Source/WebCore:

Remove implicit dependencies due to using IDBRequest.h, and fix all
places that break as a result.

  • Modules/indexeddb/IDBCallbacks.h:

(WebCore):

  • Modules/indexeddb/IDBObjectStore.cpp:
  • Modules/indexeddb/IDBRequest.h:
  • inspector/InspectorIndexedDBAgent.cpp:

Source/WebKit/chromium:

Remove implicit dependencies due to using IDBRequest.h, and fix all
places that break as a result.

  • src/IDBCallbacksProxy.cpp:
  • src/WebIDBDatabaseImpl.cpp:
  • src/WebIDBTransactionImpl.cpp:
7:35 PM Changeset in webkit [123568] by keishi@webkit.org
  • 4 edits
    1 add in trunk/Source/WebCore

Move PagePopupClient helper functions so they can be shared
https://bugs.webkit.org/show_bug.cgi?id=92096

Reviewed by Kent Tamura.

Move PagePopupClient helper functions to a separate file,
so they can be shared with new PagePopupClients.

No new tests. Covered by fast/forms/date/calendar-picker-appearance.html

  • WebCore.gypi: Added PagePopupClient.cpp
  • html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::writeDocument): Modified to use PagePopupClient.

  • page/PagePopupClient.cpp: Added.

(WebCore):
(WebCore::PagePopupClient::addJavaScriptString):
(WebCore::PagePopupClient::addProperty):

  • page/PagePopupClient.h:

(WebCore::PagePopupClient::addString):

7:31 PM Changeset in webkit [123567] by jer.noble@apple.com
  • 3 edits
    2 adds in trunk

setting playbackRate on a MediaController doesn't change the playbackRate for slaved media
https://bugs.webkit.org/show_bug.cgi?id=92035

Reviewed by Darin Adler.

Source/WebCore:

Allow updatePlaybackRate() to change the MediaPlayer rate when the media element has a
current media controller.

Test: media/media-controller-playbackrate.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updatePlaybackRate):

LayoutTests:

  • media/media-controller-playbackrate-expected.txt: Added.
  • media/media-controller-playbackrate.html: Added.
7:13 PM Changeset in webkit [123566] by alexis.menard@openbossa.org
  • 25 edits
    3 adds in trunk/LayoutTests

[Qt] svg/as-border-image, svg/as-image, svg/as-object, svg/css rebaseline after new test fonts.
https://bugs.webkit.org/show_bug.cgi?id=92193

Unreviewed gardening.

These tests have been skipped because monospace fonts weren't properly used by
layout tests. After r121971, the test results are normal again.

  • platform/qt-5.0/Skipped:
  • platform/qt/svg/as-border-image/svg-as-border-image-2-expected.png:
  • platform/qt/svg/as-border-image/svg-as-border-image-2-expected.txt:
  • platform/qt/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/qt/svg/as-border-image/svg-as-border-image-expected.txt:
  • platform/qt/svg/as-image/animated-svg-as-image-expected.png: Added.
  • platform/qt/svg/as-image/animated-svg-as-image-expected.txt:
  • platform/qt/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png: Added.
  • platform/qt/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt:
  • platform/qt/svg/as-image/animated-svg-as-image-same-image-expected.png: Added.
  • platform/qt/svg/as-image/animated-svg-as-image-same-image-expected.txt:
  • platform/qt/svg/as-image/image-respects-pageScaleFactor-expected.png:
  • platform/qt/svg/as-image/image-respects-pageScaleFactor-expected.txt:
  • platform/qt/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/qt/svg/as-image/img-preserveAspectRatio-support-1-expected.txt:
  • platform/qt/svg/as-image/img-preserveAspectRatio-support-2-expected.png:
  • platform/qt/svg/as-image/img-preserveAspectRatio-support-2-expected.txt:
  • platform/qt/svg/as-image/same-image-two-instances-expected.txt:
  • platform/qt/svg/as-image/svg-image-change-content-size-expected.png:
  • platform/qt/svg/as-image/svg-image-change-content-size-expected.txt:
  • platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt:
  • platform/qt/svg/css/composite-shadow-text-expected.png:
  • platform/qt/svg/css/composite-shadow-text-expected.txt:
  • platform/qt/svg/css/css-box-min-width-expected.png:
  • platform/qt/svg/css/css-box-min-width-expected.txt:
  • platform/qt/svg/css/text-shadow-multiple-expected.png:
  • platform/qt/svg/css/text-shadow-multiple-expected.txt:
7:08 PM Changeset in webkit [123565] by hayato@chromium.org
  • 3 edits in trunk/Source/WebCore

Rename FocusScope to FocusNavigationScope.
https://bugs.webkit.org/show_bug.cgi?id=92062

Reviewed by Dimitri Glazkov.

FocusNavagationScope is better name than FocusScope since the
class is only used for controlling focus navigation.

No new tests - no functional changes.

  • page/FocusController.cpp:

(WebCore::FocusNavigationScope::FocusNavigationScope):
(WebCore::FocusNavigationScope::rootNode):
(WebCore::FocusNavigationScope::owner):
(WebCore::FocusNavigationScope::focusNavigationScopeOf):
(WebCore::FocusNavigationScope::focusNavigationScopeOwnedByShadowHost):
(WebCore::FocusNavigationScope::focusNavigationScopeOwnedByIFrame):
(WebCore::FocusController::findFocusableNodeDecendingDownIntoFrameDocument):
(WebCore::FocusController::advanceFocusInDocumentOrder):
(WebCore::FocusController::findFocusableNodeAcrossFocusScope):
(WebCore::FocusController::findFocusableNodeRecursively):
(WebCore::FocusController::findFocusableNode):
(WebCore::FocusController::nextFocusableNode):
(WebCore::FocusController::previousFocusableNode):

  • page/FocusController.h:

(FocusNavigationScope):
(FocusController):

6:57 PM Changeset in webkit [123564] by caio.oliveira@openbossa.org
  • 220 edits
    7 deletes in trunk/LayoutTests

[Qt] css2.1/t080* rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92191

Unreviewed.

  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/css2.1/t0805-c5518-brdr-t-01-e-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0805-c5519-brdr-r-00-a-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0805-c5519-brdr-r-01-e-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0805-c5520-brdr-b-01-e-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0805-c5521-brdr-l-00-a-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0805-c5521-brdr-l-01-e-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt: Removed.
  • platform/qt/css2.1/t0801-c412-hz-box-00-b-a-expected.png:
  • platform/qt/css2.1/t0801-c412-hz-box-00-b-a-expected.txt:
  • platform/qt/css2.1/t0803-c5501-imrgn-t-00-b-ag-expected.png:
  • platform/qt/css2.1/t0803-c5501-imrgn-t-00-b-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5501-mrgn-t-00-b-a-expected.png:
  • platform/qt/css2.1/t0803-c5501-mrgn-t-00-b-a-expected.txt:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-00-b-ag-expected.png:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-00-b-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-01-b-ag-expected.png:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-01-b-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-02-b-a-expected.png:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-02-b-a-expected.txt:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-03-b-a-expected.png:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-03-b-a-expected.txt:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-04-b-ag-expected.png:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-04-b-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-05-b-ag-expected.png:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-05-b-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-06-b-ag-expected.png:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-06-b-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5502-mrgn-r-00-c-ag-expected.png:
  • platform/qt/css2.1/t0803-c5502-mrgn-r-00-c-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5502-mrgn-r-01-c-a-expected.png:
  • platform/qt/css2.1/t0803-c5502-mrgn-r-01-c-a-expected.txt:
  • platform/qt/css2.1/t0803-c5502-mrgn-r-02-c-expected.png:
  • platform/qt/css2.1/t0803-c5502-mrgn-r-02-c-expected.txt:
  • platform/qt/css2.1/t0803-c5502-mrgn-r-03-c-expected.png:
  • platform/qt/css2.1/t0803-c5502-mrgn-r-03-c-expected.txt:
  • platform/qt/css2.1/t0803-c5503-imrgn-b-00-b-a-expected.png:
  • platform/qt/css2.1/t0803-c5503-imrgn-b-00-b-a-expected.txt:
  • platform/qt/css2.1/t0803-c5503-mrgn-b-00-b-a-expected.png:
  • platform/qt/css2.1/t0803-c5503-mrgn-b-00-b-a-expected.txt:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-00-b-ag-expected.png:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-00-b-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-01-b-ag-expected.png:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-01-b-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-02-b-ag-expected.png:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-02-b-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-03-b-a-expected.png:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-03-b-a-expected.txt:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-04-b-ag-expected.png:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-04-b-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-05-b-ag-expected.png:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-05-b-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-06-b-ag-expected.png:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-06-b-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5504-mrgn-l-00-c-ag-expected.png:
  • platform/qt/css2.1/t0803-c5504-mrgn-l-00-c-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5504-mrgn-l-01-c-a-expected.png:
  • platform/qt/css2.1/t0803-c5504-mrgn-l-01-c-a-expected.txt:
  • platform/qt/css2.1/t0803-c5504-mrgn-l-02-c-expected.png:
  • platform/qt/css2.1/t0803-c5504-mrgn-l-02-c-expected.txt:
  • platform/qt/css2.1/t0803-c5504-mrgn-l-03-c-expected.png:
  • platform/qt/css2.1/t0803-c5504-mrgn-l-03-c-expected.txt:
  • platform/qt/css2.1/t0803-c5505-imrgn-00-a-ag-expected.png:
  • platform/qt/css2.1/t0803-c5505-imrgn-00-a-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5505-mrgn-00-b-ag-expected.png:
  • platform/qt/css2.1/t0803-c5505-mrgn-00-b-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5505-mrgn-01-e-a-expected.png:
  • platform/qt/css2.1/t0803-c5505-mrgn-01-e-a-expected.txt:
  • platform/qt/css2.1/t0803-c5505-mrgn-02-c-expected.png:
  • platform/qt/css2.1/t0803-c5505-mrgn-02-c-expected.txt:
  • platform/qt/css2.1/t0803-c5505-mrgn-03-c-ag-expected.png:
  • platform/qt/css2.1/t0803-c5505-mrgn-03-c-ag-expected.txt:
  • platform/qt/css2.1/t080301-c411-vt-mrgn-00-b-expected.png:
  • platform/qt/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
  • platform/qt/css2.1/t0804-c5506-ipadn-t-00-b-a-expected.png:
  • platform/qt/css2.1/t0804-c5506-ipadn-t-00-b-a-expected.txt:
  • platform/qt/css2.1/t0804-c5506-ipadn-t-01-b-a-expected.png:
  • platform/qt/css2.1/t0804-c5506-ipadn-t-01-b-a-expected.txt:
  • platform/qt/css2.1/t0804-c5506-ipadn-t-02-b-a-expected.png:
  • platform/qt/css2.1/t0804-c5506-ipadn-t-02-b-a-expected.txt:
  • platform/qt/css2.1/t0804-c5506-padn-t-00-b-a-expected.png:
  • platform/qt/css2.1/t0804-c5506-padn-t-00-b-a-expected.txt:
  • platform/qt/css2.1/t0804-c5507-ipadn-r-00-b-ag-expected.png:
  • platform/qt/css2.1/t0804-c5507-ipadn-r-00-b-ag-expected.txt:
  • platform/qt/css2.1/t0804-c5507-ipadn-r-01-b-ag-expected.png:
  • platform/qt/css2.1/t0804-c5507-ipadn-r-01-b-ag-expected.txt:
  • platform/qt/css2.1/t0804-c5507-ipadn-r-02-b-ag-expected.png:
  • platform/qt/css2.1/t0804-c5507-ipadn-r-02-b-ag-expected.txt:
  • platform/qt/css2.1/t0804-c5507-ipadn-r-03-b-a-expected.png:
  • platform/qt/css2.1/t0804-c5507-ipadn-r-03-b-a-expected.txt:
  • platform/qt/css2.1/t0804-c5507-ipadn-r-04-b-ag-expected.png:
  • platform/qt/css2.1/t0804-c5507-ipadn-r-04-b-ag-expected.txt:
  • platform/qt/css2.1/t0804-c5507-padn-r-00-c-ag-expected.png:
  • platform/qt/css2.1/t0804-c5507-padn-r-00-c-ag-expected.txt:
  • platform/qt/css2.1/t0804-c5507-padn-r-01-c-a-expected.png:
  • platform/qt/css2.1/t0804-c5507-padn-r-01-c-a-expected.txt:
  • platform/qt/css2.1/t0804-c5507-padn-r-02-f-expected.png:
  • platform/qt/css2.1/t0804-c5507-padn-r-02-f-expected.txt:
  • platform/qt/css2.1/t0804-c5507-padn-r-03-f-expected.png:
  • platform/qt/css2.1/t0804-c5507-padn-r-03-f-expected.txt:
  • platform/qt/css2.1/t0804-c5508-ipadn-b-00-b-a-expected.png:
  • platform/qt/css2.1/t0804-c5508-ipadn-b-00-b-a-expected.txt:
  • platform/qt/css2.1/t0804-c5508-ipadn-b-01-f-a-expected.png:
  • platform/qt/css2.1/t0804-c5508-ipadn-b-01-f-a-expected.txt:
  • platform/qt/css2.1/t0804-c5508-ipadn-b-02-b-a-expected.png:
  • platform/qt/css2.1/t0804-c5508-ipadn-b-02-b-a-expected.txt:
  • platform/qt/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.png:
  • platform/qt/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt:
  • platform/qt/css2.1/t0804-c5509-ipadn-l-00-b-ag-expected.png:
  • platform/qt/css2.1/t0804-c5509-ipadn-l-00-b-ag-expected.txt:
  • platform/qt/css2.1/t0804-c5509-ipadn-l-01-b-ag-expected.png:
  • platform/qt/css2.1/t0804-c5509-ipadn-l-01-b-ag-expected.txt:
  • platform/qt/css2.1/t0804-c5509-ipadn-l-02-b-ag-expected.png:
  • platform/qt/css2.1/t0804-c5509-ipadn-l-02-b-ag-expected.txt:
  • platform/qt/css2.1/t0804-c5509-ipadn-l-03-b-a-expected.png:
  • platform/qt/css2.1/t0804-c5509-ipadn-l-03-b-a-expected.txt:
  • platform/qt/css2.1/t0804-c5509-ipadn-l-04-f-ag-expected.png:
  • platform/qt/css2.1/t0804-c5509-ipadn-l-04-f-ag-expected.txt:
  • platform/qt/css2.1/t0804-c5509-padn-l-00-b-ag-expected.png:
  • platform/qt/css2.1/t0804-c5509-padn-l-00-b-ag-expected.txt:
  • platform/qt/css2.1/t0804-c5509-padn-l-01-b-a-expected.png:
  • platform/qt/css2.1/t0804-c5509-padn-l-01-b-a-expected.txt:
  • platform/qt/css2.1/t0804-c5509-padn-l-02-f-expected.png:
  • platform/qt/css2.1/t0804-c5509-padn-l-02-f-expected.txt:
  • platform/qt/css2.1/t0804-c5509-padn-l-03-f-g-expected.png:
  • platform/qt/css2.1/t0804-c5509-padn-l-03-f-g-expected.txt:
  • platform/qt/css2.1/t0804-c5510-ipadn-00-b-ag-expected.png:
  • platform/qt/css2.1/t0804-c5510-ipadn-00-b-ag-expected.txt:
  • platform/qt/css2.1/t0804-c5510-padn-00-b-ag-expected.png:
  • platform/qt/css2.1/t0804-c5510-padn-00-b-ag-expected.txt:
  • platform/qt/css2.1/t0804-c5510-padn-01-e-a-expected.png:
  • platform/qt/css2.1/t0804-c5510-padn-01-e-a-expected.txt:
  • platform/qt/css2.1/t0804-c5510-padn-02-f-expected.png:
  • platform/qt/css2.1/t0804-c5510-padn-02-f-expected.txt:
  • platform/qt/css2.1/t0805-c5511-brdr-tw-00-b-expected.png:
  • platform/qt/css2.1/t0805-c5511-brdr-tw-00-b-expected.txt:
  • platform/qt/css2.1/t0805-c5511-brdr-tw-01-b-g-expected.png:
  • platform/qt/css2.1/t0805-c5511-brdr-tw-01-b-g-expected.txt:
  • platform/qt/css2.1/t0805-c5511-brdr-tw-02-b-expected.png:
  • platform/qt/css2.1/t0805-c5511-brdr-tw-02-b-expected.txt:
  • platform/qt/css2.1/t0805-c5511-brdr-tw-03-b-expected.png:
  • platform/qt/css2.1/t0805-c5511-brdr-tw-03-b-expected.txt:
  • platform/qt/css2.1/t0805-c5511-ibrdr-tw-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5511-ibrdr-tw-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5512-brdr-rw-00-b-expected.png:
  • platform/qt/css2.1/t0805-c5512-brdr-rw-00-b-expected.txt:
  • platform/qt/css2.1/t0805-c5512-brdr-rw-01-b-g-expected.png:
  • platform/qt/css2.1/t0805-c5512-brdr-rw-01-b-g-expected.txt:
  • platform/qt/css2.1/t0805-c5512-brdr-rw-02-b-expected.png:
  • platform/qt/css2.1/t0805-c5512-brdr-rw-02-b-expected.txt:
  • platform/qt/css2.1/t0805-c5512-brdr-rw-03-b-expected.png:
  • platform/qt/css2.1/t0805-c5512-brdr-rw-03-b-expected.txt:
  • platform/qt/css2.1/t0805-c5512-ibrdr-rw-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5512-ibrdr-rw-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5513-brdr-bw-00-b-expected.png:
  • platform/qt/css2.1/t0805-c5513-brdr-bw-00-b-expected.txt:
  • platform/qt/css2.1/t0805-c5513-brdr-bw-01-b-g-expected.png:
  • platform/qt/css2.1/t0805-c5513-brdr-bw-01-b-g-expected.txt:
  • platform/qt/css2.1/t0805-c5513-brdr-bw-02-b-expected.png:
  • platform/qt/css2.1/t0805-c5513-brdr-bw-02-b-expected.txt:
  • platform/qt/css2.1/t0805-c5513-brdr-bw-03-b-expected.png:
  • platform/qt/css2.1/t0805-c5513-brdr-bw-03-b-expected.txt:
  • platform/qt/css2.1/t0805-c5513-ibrdr-bw-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5513-ibrdr-bw-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5514-brdr-lw-00-b-expected.png:
  • platform/qt/css2.1/t0805-c5514-brdr-lw-00-b-expected.txt:
  • platform/qt/css2.1/t0805-c5514-brdr-lw-01-b-g-expected.png:
  • platform/qt/css2.1/t0805-c5514-brdr-lw-01-b-g-expected.txt:
  • platform/qt/css2.1/t0805-c5514-brdr-lw-02-b-expected.png:
  • platform/qt/css2.1/t0805-c5514-brdr-lw-02-b-expected.txt:
  • platform/qt/css2.1/t0805-c5514-brdr-lw-03-b-expected.png:
  • platform/qt/css2.1/t0805-c5514-brdr-lw-03-b-expected.txt:
  • platform/qt/css2.1/t0805-c5514-ibrdr-lw-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5514-ibrdr-lw-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5515-brdr-w-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5515-brdr-w-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5515-brdr-w-01-b-g-expected.png:
  • platform/qt/css2.1/t0805-c5515-brdr-w-01-b-g-expected.txt:
  • platform/qt/css2.1/t0805-c5515-brdr-w-02-b-expected.png:
  • platform/qt/css2.1/t0805-c5515-brdr-w-02-b-expected.txt:
  • platform/qt/css2.1/t0805-c5515-ibrdr-00-b-expected.png:
  • platform/qt/css2.1/t0805-c5515-ibrdr-00-b-expected.txt:
  • platform/qt/css2.1/t0805-c5516-brdr-c-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5516-brdr-c-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5516-ibrdr-c-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5516-ibrdr-c-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5517-brdr-s-00-c-expected.png:
  • platform/qt/css2.1/t0805-c5517-brdr-s-00-c-expected.txt:
  • platform/qt/css2.1/t0805-c5517-ibrdr-s-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5517-ibrdr-s-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5518-brdr-t-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5518-brdr-t-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5518-brdr-t-01-e-expected.png:
  • platform/qt/css2.1/t0805-c5518-brdr-t-01-e-expected.txt:
  • platform/qt/css2.1/t0805-c5518-ibrdr-t-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5518-ibrdr-t-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5519-brdr-r-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5519-brdr-r-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5519-brdr-r-01-e-expected.png:
  • platform/qt/css2.1/t0805-c5519-brdr-r-01-e-expected.txt:
  • platform/qt/css2.1/t0805-c5519-brdr-r-02-e-expected.png:
  • platform/qt/css2.1/t0805-c5519-brdr-r-02-e-expected.txt:
  • platform/qt/css2.1/t0805-c5519-ibrdr-r-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5519-ibrdr-r-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5520-brdr-b-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5520-brdr-b-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
  • platform/qt/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • platform/qt/css2.1/t0805-c5520-ibrdr-b-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5520-ibrdr-b-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5521-brdr-l-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5521-brdr-l-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5521-brdr-l-01-e-expected.png:
  • platform/qt/css2.1/t0805-c5521-brdr-l-01-e-expected.txt:
  • platform/qt/css2.1/t0805-c5521-brdr-l-02-e-expected.png:
  • platform/qt/css2.1/t0805-c5521-brdr-l-02-e-expected.txt:
  • platform/qt/css2.1/t0805-c5521-ibrdr-l-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5522-brdr-00-b-expected.png:
  • platform/qt/css2.1/t0805-c5522-brdr-00-b-expected.txt:
  • platform/qt/css2.1/t0805-c5522-brdr-01-b-g-expected.png:
  • platform/qt/css2.1/t0805-c5522-brdr-01-b-g-expected.txt:
  • platform/qt/css2.1/t0805-c5522-brdr-02-e-expected.png:
  • platform/qt/css2.1/t0805-c5522-brdr-02-e-expected.txt:
  • platform/qt/css2.1/t0805-c5522-ibrdr-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5522-ibrdr-00-a-expected.txt:
6:45 PM Changeset in webkit [123563] by yosin@chromium.org
  • 5 edits in trunk/LayoutTests

[Tests] Re-factor some tests in fast/forms/number for sharing with other input types
https://bugs.webkit.org/show_bug.cgi?id=92081

Reviewed by Kent Tamura.

This patch moves JavaScript code from test HTML files into JavaScript
files for sharing JavaScript code with other input types.

  • fast/forms/number/number-change-type-on-focus.html: Removed JavaScript code and changed to load JavaScript code from fast/forms/resources/common-change-type-on-focus.js.
  • fast/forms/number/number-losing-renderer-on-click.html: Removed JavaScript code and changed to load JavaScript code from fast/forms/resources/common-losing-renderer-on-click.js.
  • fast/forms/resources/common-change-type-on-focus.js: Remove HTML markup text.
  • fast/forms/resources/common-losing-renderer-on-click.js: Remove HTML markup text.
6:23 PM Changeset in webkit [123562] by rakuco@webkit.org
  • 2 edits in trunk/Tools

[EFL] Unreviewed build fix.

  • WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Include unistd.h

for usleep(3).

6:14 PM Changeset in webkit [123561] by caio.oliveira@openbossa.org
  • 160 edits
    42 adds in trunk/LayoutTests

[Qt] css2.1/t170602* rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92188

Unreviewed.

  • platform/qt-5.0/Skipped:
  • platform/qt/css2.1/t170602-bdr-conflct-w-00-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-00-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-01-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-01-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-02-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-02-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-03-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-03-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-04-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-04-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-05-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-05-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-06-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-06-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-07-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-07-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-08-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-08-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-09-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-09-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-10-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-10-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-11-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-11-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-12-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-12-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-13-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-13-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-14-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-14-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-15-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-15-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-16-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-16-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-17-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-17-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-18-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-18-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-19-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-19-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-20-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-20-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-21-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-21-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-22-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-22-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-23-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-23-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-24-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-24-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-25-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-25-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-26-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-26-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-27-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-27-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-28-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-28-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-29-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-29-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-30-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-30-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-31-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-31-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-32-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-32-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-33-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-33-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-34-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-34-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-35-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-35-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-36-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-36-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-37-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-37-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-38-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-38-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-39-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-39-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-40-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-40-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-41-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-41-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-42-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-42-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-43-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-43-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-44-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-44-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-45-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-45-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-46-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-46-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-47-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-47-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-48-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-48-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-49-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-49-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-50-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-50-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-51-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-51-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-52-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-52-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-53-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-53-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-54-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-54-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-55-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-55-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-56-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-56-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-57-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-57-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-58-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-58-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-59-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-59-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-60-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-60-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-61-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-61-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-62-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-62-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-63-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-63-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-64-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-64-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-65-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-65-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-66-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-66-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-67-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-67-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-68-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-68-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-69-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-69-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-70-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-70-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-71-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-71-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-72-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-72-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-73-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-73-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-74-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-74-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-75-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-75-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-76-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-76-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-77-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-77-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-78-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-78-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-79-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-79-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-80-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-80-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-81-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-81-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-82-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-82-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-83-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-83-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-84-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-84-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-85-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-85-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-86-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-86-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-87-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-87-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-88-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-88-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-89-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-89-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-90-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-90-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-91-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-91-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-92-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-92-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-93-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-93-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-94-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-94-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-95-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-95-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-96-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-96-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-97-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-97-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-98-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-98-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-99-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-99-d-expected.txt:
6:11 PM Changeset in webkit [123560] by msaboff@apple.com
  • 12 edits in trunk/Source

Convert HTML parser to handle 8-bit resources without converting to UChar*
https://bugs.webkit.org/show_bug.cgi?id=90321

Reviewed by Geoffrey Garen.

Source/WebCore:

No new tests, no new functionality therefore covered by existing tests.

Changed the parsing of HTML to handle 8-bit strings without converting the
whole string to 16-bits. Primary change was to use the appropriate
character pointer type (LChar* or UChar*) depending on the source string.
This access is abstracted in SegmentedSubstring by getCurrentChar{8,16} and
incrementAndGetCurrentChar{8,16} methods. In SegmentedString, the advance()
and advanceAndUpdateLineNumber() methods have been refactored into a
state machine managed pair of function pointers. The possible functions
have not only the 8 and 16 bitness factored out, they also have the
"exclude line numbers" logic factored out for advanceAndUpdateLineNumber().
This provides a net speed-up even with the 8/16 bit testing.
Other changes involve using String methods to access and compare with the
source data.

  • html/FTPDirectoryDocument.cpp:

(WebCore::FTPDirectoryDocumentParser::append): Changed to use currentChar()
instead of SegmentedString '*' operator.

  • html/parser/HTMLEntityParser.cpp: Changed to use currentChar() instead of

SegmentedString '*' operator.

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::stripLeadingAndTrailingHTMLSpaces): Added 8-bit fast path.

  • html/parser/HTMLSourceTracker.cpp:

(WebCore::HTMLSourceTracker::sourceForToken): Changed to use currentChar() instead of
SegmentedString '*' operator.

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::script): Updated to use new String::dataSize() method.

  • platform/text/SegmentedString.cpp:

(WebCore::SegmentedString::SegmentedString):
(WebCore::SegmentedString::operator=):
(WebCore::SegmentedString::clear):
(WebCore::SegmentedString::append):
(WebCore::SegmentedString::prepend):
(WebCore::SegmentedString::advanceSubstring):
(WebCore::SegmentedString::advance): Changed to be a wrapper that invokes current
advance function.
(WebCore::SegmentedString::advance8): Fast path advance function for 8 bit data.
(WebCore::SegmentedString::advance16): Fast path advance function for 16 bit data.
(WebCore::SegmentedString::advanceAndUpdateLineNumber8IncludeLineNumbers): Fast
path advanceAndUpdateLineNumber for 8 bit data when we need to update the line number.
(WebCore::SegmentedString::advanceAndUpdateLineNumber16IncludeLineNumbers): Fast
path advanceAndUpdateLineNumber for 16 bit data when we need to update the line number.
(WebCore::SegmentedString::advanceSlowCase): Slow case advance function for both
8 and 16 bit advance.
(WebCore::SegmentedString::advanceAndUpdateLineNumberSlowCase): Slow case
advanceAndUpdateLineNumber function for both 8 and 16 bit data.
(WebCore::SegmentedString::advanceEmpty): Advance function when input has been exhausted.

  • platform/text/SegmentedString.h:

(WebCore::SegmentedSubstring::SegmentedSubstring):
(WebCore::SegmentedSubstring::clear):
(SegmentedSubstring):
(WebCore::SegmentedSubstring::is8Bit): New getter.
(WebCore::SegmentedSubstring::appendTo):
(WebCore::SegmentedSubstring::getCurrentChar8): New getter for the 8 bit case.
(WebCore::SegmentedSubstring::getCurrentChar16): New getter for the 16 bit case.
(WebCore::SegmentedSubstring::incrementAndGetCurrentChar8): New wrapper functions
that pre-increments the 8 bit pointer and returns the next character.
(WebCore::SegmentedSubstring::incrementAndGetCurrentChar16): New wrapper functions
that pre-increments the 16 bit pointer and returns the next character.
(WebCore::SegmentedSubstring::currentSubString):
(WebCore::SegmentedSubstring::getCurrentChar):
(WebCore::SegmentedSubstring::incrementAndGetCurrentChar):
(WebCore::SegmentedString::SegmentedString):
(WebCore::SegmentedString::push):
(WebCore::SegmentedString::isEmpty):
(WebCore::SegmentedString::lookAhead):
(WebCore::SegmentedString::lookAheadIgnoringCase):
(WebCore::SegmentedString::advance):
(WebCore::SegmentedString::advanceAndUpdateLineNumber):
(WebCore::SegmentedString::advanceAndASSERT):
(WebCore::SegmentedString::advanceAndASSERTIgnoringCase):
(WebCore::SegmentedString::advancePastNonNewline):
(WebCore::SegmentedString::advancePastNewlineAndUpdateLineNumber):
(WebCore::SegmentedString::currentChar):
(WebCore::SegmentedString::setSlowCase): Set advance function pointers to slow case
functions.
(WebCore::SegmentedString::decrementAndCheckLength): Decrement substring length and
change to slow case functions when only one character left.
(WebCore::SegmentedString::setAdvanceFunctionPointers): Select appropriate advance
functions based on current substring.
(WebCore::SegmentedString::lookAheadInline): Changed to use String::startsWith().
(WebCore::SegmentedString::lookAheadSlowCase):

  • xml/parser/CharacterReferenceParserInlineMethods.h:

(WebCore::consumeCharacterReference): Changed to use currentChar() instead of
SegmentedString '*' operator.

  • xml/parser/MarkupTokenizerBase.h:

(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::nextInputCharacter):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::peek): Changed to use
currentChar() instead of SegmentedString '*' operator.
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::advance):

Source/WTF:

  • wtf/text/WTFString.h:

(WTF::String::dataSize): New method to return the number of bytes
the string requires. This replaces a harcoded calculation based on
length and sizeof(UChar).

6:07 PM Changeset in webkit [123559] by weinig@apple.com
  • 2 edits in trunk/Source/WTF

Add per-HashTable stats
https://bugs.webkit.org/show_bug.cgi?id=92185

Reviewed by Anders Carlsson.

Add per-HashTable stats, so we can look at the effectiveness of an individual HashTable.

  • wtf/HashTable.h:

(WTF::HashTable::Stats::Stats):
Add a HashTable::Stats to hold the stats.

(WTF::HashTable::Stats::recordCollisionAtCount):
(WTF::HashTable::Stats::dumpStats):
Add versions of recordCollisionAtCount and dumpStats for per-HashTable version.

(WTF::HashTable):
Keep the stats, if enabled, in an OwnPtr, to not blow JSCell max size restrictions.

(WTF::lookup):
(WTF::lookupForWriting):
(WTF::fullLookupForWriting):
(WTF::add):
(WTF::reinsert):
(WTF::remove):
(WTF::rehash):
Keep track of the stats as the table is used.

5:48 PM Changeset in webkit [123558] by zmo@google.com
  • 1 edit
    55 adds in trunk/LayoutTests

Gardening stuff, rebaseline.

Unreviewed.

  • platform/chromium-mac/fast/hidpi: Added.
  • platform/chromium-mac/fast/hidpi/broken-image-icon-hidpi-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/broken-image-with-size-hidpi-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/clip-text-in-hidpi-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/device-scale-factor-paint-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/focus-rings-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/image-set-as-background-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/image-set-background-dynamic-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/image-set-background-repeat-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/image-set-background-repeat-without-size-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/image-set-border-image-comparison-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/image-set-border-image-dynamic-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/image-set-border-image-simple-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/image-set-in-content-dynamic-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/image-set-out-of-order-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/image-set-simple-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/image-set-without-specified-width-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/resize-corner-hidpi-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/video-controls-in-hidpi-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/video-controls-in-hidpi-expected.txt: Added.
  • platform/chromium-win/fast/hidpi: Added.
  • platform/chromium-win/fast/hidpi/broken-image-icon-hidpi-expected.png: Added.
  • platform/chromium-win/fast/hidpi/broken-image-icon-hidpi-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/broken-image-with-size-hidpi-expected.png: Added.
  • platform/chromium-win/fast/hidpi/broken-image-with-size-hidpi-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/clip-text-in-hidpi-expected.png: Added.
  • platform/chromium-win/fast/hidpi/clip-text-in-hidpi-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/device-scale-factor-paint-expected.png: Added.
  • platform/chromium-win/fast/hidpi/focus-rings-expected.png: Added.
  • platform/chromium-win/fast/hidpi/image-set-as-background-expected.png: Added.
  • platform/chromium-win/fast/hidpi/image-set-as-background-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/image-set-background-dynamic-expected.png: Added.
  • platform/chromium-win/fast/hidpi/image-set-background-dynamic-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/image-set-background-repeat-expected.png: Added.
  • platform/chromium-win/fast/hidpi/image-set-background-repeat-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/image-set-background-repeat-without-size-expected.png: Added.
  • platform/chromium-win/fast/hidpi/image-set-background-repeat-without-size-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/image-set-border-image-comparison-expected.png: Added.
  • platform/chromium-win/fast/hidpi/image-set-border-image-comparison-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/image-set-border-image-dynamic-expected.png: Added.
  • platform/chromium-win/fast/hidpi/image-set-border-image-dynamic-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/image-set-border-image-simple-expected.png: Added.
  • platform/chromium-win/fast/hidpi/image-set-border-image-simple-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/image-set-in-content-dynamic-expected.png: Added.
  • platform/chromium-win/fast/hidpi/image-set-in-content-dynamic-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/image-set-out-of-order-expected.png: Added.
  • platform/chromium-win/fast/hidpi/image-set-out-of-order-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/image-set-simple-expected.png: Added.
  • platform/chromium-win/fast/hidpi/image-set-simple-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/image-set-without-specified-width-expected.png: Added.
  • platform/chromium-win/fast/hidpi/image-set-without-specified-width-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/resize-corner-hidpi-expected.png: Added.
  • platform/chromium-win/fast/hidpi/resize-corner-hidpi-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/video-controls-in-hidpi-expected.png: Added.
  • platform/chromium-win/fast/hidpi/video-controls-in-hidpi-expected.txt: Added.
5:46 PM Changeset in webkit [123557] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

WKContextGetGlobalStatistics() assigns wrong value to wkFrameCount in WKContextStatistics
https://bugs.webkit.org/show_bug.cgi?id=92173

Patch by Jae Hyun Park <jae.park@company100.net> on 2012-07-24
Reviewed by John Sullivan.

In WKContextGetGlobalStatistics(), wkViewCount in WebContext::Statistics
is assigned to wkFrameCount in WKContextStatistics.
wkFrameCount in WebContext:Statistics should be assigned to wkFrameCount in WKContextStatistics.

  • UIProcess/API/C/WKContext.cpp:

(WKContextGetGlobalStatistics):

5:37 PM Changeset in webkit [123556] by kbr@google.com
  • 7 edits
    2 adds in trunk

[chromium] Hint garbage collector to run if page uses Canvas contexts
https://bugs.webkit.org/show_bug.cgi?id=76225

Reviewed by Kentaro Hara.

Source/WebCore:

Upon creating a canvas context, set a hint in the current isolate
indicating that a full GC should be done upon the next page
navigation.

This improves Chrome's robustness on some WebGL stress tests which
simulate real-world behavior by repeatedly navigating among
several samples. More general measures are being investigated, but
this change makes V8 behave the same as JSC on these stress tests.
JSC doesn't currently use generational garbage collection, so it
has more opportunities to discover unreferenced canvas contexts.

Test: fast/canvas/webgl/context-creation-and-destruction.html

  • bindings/v8/V8Binding.cpp:

(WebCore::V8BindingPerIsolateData::V8BindingPerIsolateData):

Initialize per-isolate low memory hint.

  • bindings/v8/V8Binding.h:

(V8BindingPerIsolateData):
(WebCore::V8BindingPerIsolateData::setLowMemoryNotificationHint):

Set a per-isolate hint to signal a low memory condition upon the next page navigation.

(WebCore::V8BindingPerIsolateData::clearLowMemoryNotificationHint):

Clear the previously set hint.

(WebCore::V8BindingPerIsolateData::isLowMemoryNotificationHint):

Get the previously set hint.

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::hintForGCIfNecessary):

If necessary, send V8 a hint that it should GC.

(WebCore):
(WebCore::V8Proxy::clearForClose):
(WebCore::V8Proxy::clearForNavigation):

Call hintForGCIfNecessary.

  • bindings/v8/V8Proxy.h:

(V8Proxy):

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::getContextCallback):

Set a hint that we should GC upon the next page navigation.

LayoutTests:

This test doesn't directly exercise this code path yet, but it
needs to work regardless and also needs to be expanded.

  • fast/canvas/webgl/context-creation-and-destruction-expected.txt: Added.
  • fast/canvas/webgl/context-creation-and-destruction.html: Added.
5:28 PM Changeset in webkit [123555] by alexis.menard@openbossa.org
  • 18 edits
    3 adds in trunk/LayoutTests

[Qt] svg/as-background-image rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92180

Unreviewed gardening.

These tests have been skipped because monospace fonts weren't properly used by
layout tests. After r121971, the test results are normal again.

  • platform/qt-5.0/Skipped:
  • platform/qt/svg/as-background-image/animated-svg-as-background-expected.png: Added.
  • platform/qt/svg/as-background-image/animated-svg-as-background-expected.txt:
  • platform/qt/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
  • platform/qt/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt:
  • platform/qt/svg/as-background-image/svg-as-background-1-expected.txt:
  • platform/qt/svg/as-background-image/svg-as-background-2-expected.txt:
  • platform/qt/svg/as-background-image/svg-as-background-3-expected.txt:
  • platform/qt/svg/as-background-image/svg-as-background-4-expected.png: Added.
  • platform/qt/svg/as-background-image/svg-as-background-4-expected.txt:
  • platform/qt/svg/as-background-image/svg-as-background-5-expected.png: Added.
  • platform/qt/svg/as-background-image/svg-as-background-5-expected.txt:
  • platform/qt/svg/as-background-image/svg-as-background-6-expected.txt:
  • platform/qt/svg/as-background-image/svg-as-background-expected.txt:
  • platform/qt/svg/as-background-image/svg-as-background-with-relative-size-expected.txt:
  • platform/qt/svg/as-background-image/svg-as-background-with-viewBox-expected.txt:
  • platform/qt/svg/as-background-image/svg-as-tiled-background-expected.txt:
  • platform/qt/svg/as-background-image/svg-background-partial-redraw-expected.png:
  • platform/qt/svg/as-background-image/svg-background-partial-redraw-expected.txt:
  • platform/qt/svg/as-background-image/svg-width-100p-as-background-expected.txt:
5:27 PM Changeset in webkit [123554] by abarth@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

[Chromium] Support scrolling and zooming to focused input elements
https://bugs.webkit.org/show_bug.cgi?id=91661

Reviewed by Darin Fisher.

This patch introduces saveScrollAndScaleState and
restoreScrollAndScaleState, which can be used to save and restore the
scroll and scale state of the WebView, respectively. These functions
will be used by Chromium on Android to save the scale and scrolls state
before zoom into a text field so that we can "undo" the zoom if the
user didn't mean to zoom into the text field.

I wanted to write unit tests for these functions, but it wasn't clear
to me how to write the test because startPageScaleAnimation appears to
complete asynchronously.

  • public/WebView.h:

(WebView):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::saveScrollAndScaleState):
(WebKit):
(WebKit::WebViewImpl::restoreScrollAndScaleState):
(WebKit::WebViewImpl::resetSavedScrollAndScaleState):
(WebKit::WebViewImpl::didCommitLoad):

  • src/WebViewImpl.h:

(WebViewImpl):

5:25 PM Changeset in webkit [123553] by commit-queue@webkit.org
  • 34 edits in trunk/Source

[chromium] Add time spent painting to GPU benchmarking renderingStats() API.
https://bugs.webkit.org/show_bug.cgi?id=90019

Patch by Dave Tu <dtu@chromium.org> on 2012-07-24
Reviewed by Adrienne Walker.

Source/Platform:

  • chromium/public/WebRenderingStats.h:

(WebRenderingStats):
(WebKit::WebRenderingStats::WebRenderingStats):

Source/WebCore:

  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:

(WebCore::BitmapCanvasLayerTextureUpdater::prepareToUpdate):

  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h:

(BitmapCanvasLayerTextureUpdater):

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::prepareRect):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::prepareToUpdate):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::paintContentsRect):

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:

(Texture):
(BitmapSkPictureCanvasLayerTextureUpdater):

  • platform/graphics/chromium/CanvasLayerTextureUpdater.cpp:

(WebCore::CanvasLayerTextureUpdater::paintContents):

  • platform/graphics/chromium/CanvasLayerTextureUpdater.h:

(CanvasLayerTextureUpdater):

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::update):

  • platform/graphics/chromium/ContentLayerChromium.h:

(ContentLayerChromium):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::update):

  • platform/graphics/chromium/ImageLayerChromium.h:

(ImageLayerChromium):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore):
(WebCore::LayerChromium::update):

  • platform/graphics/chromium/LayerTextureUpdater.h:

(WebCore):
(WebCore::LayerTextureUpdater::Texture::prepareRect):
(WebCore::LayerTextureUpdater::prepareToUpdate):

  • platform/graphics/chromium/ScrollbarLayerChromium.cpp:

(WebCore::ScrollbarLayerChromium::updatePart):
(WebCore::ScrollbarLayerChromium::update):

  • platform/graphics/chromium/ScrollbarLayerChromium.h:

(ScrollbarLayerChromium):

  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::SkPictureCanvasLayerTextureUpdater::prepareToUpdate):

  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h:

(SkPictureCanvasLayerTextureUpdater):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::updateTiles):
(WebCore::TiledLayerChromium::updateContentRect):

  • platform/graphics/chromium/TiledLayerChromium.h:

(TiledLayerChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::updateAnimations):
(WebCore::CCLayerTreeHost::renderingStats):
(WebCore::CCLayerTreeHost::paintMasksForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore):
(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCRenderingStats.h:

(CCRenderingStats):
(WebCore::CCRenderingStats::CCRenderingStats):

Source/WebKit/chromium:

  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::renderingStats):

  • tests/CCLayerTreeHostTest.cpp:
  • tests/CCTiledLayerTestCommon.cpp:

(WebKitTests::FakeLayerTextureUpdater::Texture::prepareRect):
(WebKitTests::FakeTiledLayerChromium::update):

  • tests/CCTiledLayerTestCommon.h:

(Texture):
(FakeTiledLayerChromium):

  • tests/Canvas2DLayerBridgeTest.cpp:
  • tests/ContentLayerChromiumTest.cpp:

(WebKit::TEST):

  • tests/TiledLayerChromiumTest.cpp:
5:16 PM Changeset in webkit [123552] by caio.oliveira@openbossa.org
  • 131 edits
    41 copies
    8 adds in trunk/LayoutTests

[Qt] fast/block/positioning rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92174

Unreviewed.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt/fast/block/positioning/003-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/004-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/005-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/006-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/007-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/008-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/009-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/010-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/011-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/012-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/013-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/014-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/015-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/016-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/017-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/018-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/019-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/020-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/021-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/022-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/023-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/024-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/025-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/026-expected.png: Added.
  • platform/qt/fast/block/positioning/027-expected.png: Added.
  • platform/qt/fast/block/positioning/028-expected.png: Added.
  • platform/qt/fast/block/positioning/029-expected.png: Added.
  • platform/qt/fast/block/positioning/030-expected.png: Added.
  • platform/qt/fast/block/positioning/031-expected.png: Added.
  • platform/qt/fast/block/positioning/032-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/033-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/034-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/035-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/036-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/037-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/038-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/039-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/040-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/041-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/042-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/043-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/044-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/045-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/046-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/047-expected.png:
  • platform/qt/fast/block/positioning/047-expected.txt:
  • platform/qt/fast/block/positioning/048-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/050-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/052-expected.txt:
  • platform/qt/fast/block/positioning/053-expected.png:
  • platform/qt/fast/block/positioning/053-expected.txt:
  • platform/qt/fast/block/positioning/054-expected.txt:
  • platform/qt/fast/block/positioning/055-expected.png:
  • platform/qt/fast/block/positioning/055-expected.txt:
  • platform/qt/fast/block/positioning/057-expected.png:
  • platform/qt/fast/block/positioning/057-expected.txt:
  • platform/qt/fast/block/positioning/058-expected.png:
  • platform/qt/fast/block/positioning/058-expected.txt:
  • platform/qt/fast/block/positioning/059-expected.png:
  • platform/qt/fast/block/positioning/059-expected.txt:
  • platform/qt/fast/block/positioning/060-expected.png:
  • platform/qt/fast/block/positioning/060-expected.txt:
  • platform/qt/fast/block/positioning/061-expected.txt:
  • platform/qt/fast/block/positioning/062-expected.png: Added.
  • platform/qt/fast/block/positioning/abs-inside-inline-rel-expected.png:
  • platform/qt/fast/block/positioning/abs-inside-inline-rel-expected.txt:
  • platform/qt/fast/block/positioning/absolute-in-inline-ltr-3-expected.png:
  • platform/qt/fast/block/positioning/absolute-in-inline-ltr-3-expected.txt:
  • platform/qt/fast/block/positioning/absolute-in-inline-short-ltr-expected.png:
  • platform/qt/fast/block/positioning/absolute-in-inline-short-ltr-expected.txt:
  • platform/qt/fast/block/positioning/absolute-in-inline-short-rtl-expected.png:
  • platform/qt/fast/block/positioning/absolute-in-inline-short-rtl-expected.txt:
  • platform/qt/fast/block/positioning/absolute-length-of-neg-666666-expected.png:
  • platform/qt/fast/block/positioning/absolute-length-of-neg-666666-expected.txt:
  • platform/qt/fast/block/positioning/absolute-position-direction-expected.png:
  • platform/qt/fast/block/positioning/absolute-position-direction-expected.txt:
  • platform/qt/fast/block/positioning/absolute-positioned-overconstrained-expected.png:
  • platform/qt/fast/block/positioning/absolute-positioned-overconstrained-expected.txt:
  • platform/qt/fast/block/positioning/absolute-positioning-no-scrollbar-expected.png: Added.
  • platform/qt/fast/block/positioning/absolute-positioning-no-scrollbar-expected.txt:
  • platform/qt/fast/block/positioning/absolute-with-html-border-quirks-expected.png:
  • platform/qt/fast/block/positioning/absolute-with-html-border-quirks-expected.txt:
  • platform/qt/fast/block/positioning/absolute-with-html-border-strict-expected.png:
  • platform/qt/fast/block/positioning/absolute-with-html-border-strict-expected.txt:
  • platform/qt/fast/block/positioning/auto-height-with-top-and-bottom-expected.png:
  • platform/qt/fast/block/positioning/auto-height-with-top-and-bottom-expected.txt:
  • platform/qt/fast/block/positioning/auto/001-expected.png:
  • platform/qt/fast/block/positioning/auto/001-expected.txt:
  • platform/qt/fast/block/positioning/auto/002-expected.png:
  • platform/qt/fast/block/positioning/auto/002-expected.txt:
  • platform/qt/fast/block/positioning/auto/003-expected.png:
  • platform/qt/fast/block/positioning/auto/003-expected.txt:
  • platform/qt/fast/block/positioning/auto/004-expected.png:
  • platform/qt/fast/block/positioning/auto/004-expected.txt:
  • platform/qt/fast/block/positioning/auto/005-expected.png:
  • platform/qt/fast/block/positioning/auto/005-expected.txt:
  • platform/qt/fast/block/positioning/auto/006-expected.png:
  • platform/qt/fast/block/positioning/auto/006-expected.txt:
  • platform/qt/fast/block/positioning/auto/007-expected.png:
  • platform/qt/fast/block/positioning/auto/007-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-lr/001-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-lr/001-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-lr/002-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-lr/002-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-lr/003-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-lr/003-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-lr/004-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-lr/004-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-lr/005-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-lr/005-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-lr/006-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-lr/006-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-lr/007-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-lr/007-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-rl/001-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-rl/001-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-rl/002-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-rl/002-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-rl/003-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-rl/003-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-rl/004-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-rl/004-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-rl/005-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-rl/005-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-rl/006-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-rl/006-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-rl/007-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-rl/007-expected.txt:
  • platform/qt/fast/block/positioning/child-of-absolute-with-auto-height-expected.png:
  • platform/qt/fast/block/positioning/child-of-absolute-with-auto-height-expected.txt:
  • platform/qt/fast/block/positioning/differing-writing-modes-expected.png:
  • platform/qt/fast/block/positioning/differing-writing-modes-expected.txt:
  • platform/qt/fast/block/positioning/differing-writing-modes-replaced-expected.png:
  • platform/qt/fast/block/positioning/differing-writing-modes-replaced-expected.txt:
  • platform/qt/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.png:
  • platform/qt/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.txt:
  • platform/qt/fast/block/positioning/height-change-expected.png:
  • platform/qt/fast/block/positioning/height-change-expected.txt:
  • platform/qt/fast/block/positioning/hiding-inside-relpositioned-inline-expected.png:
  • platform/qt/fast/block/positioning/hiding-inside-relpositioned-inline-expected.txt:
  • platform/qt/fast/block/positioning/inline-block-relposition-expected.png:
  • platform/qt/fast/block/positioning/inline-block-relposition-expected.txt:
  • platform/qt/fast/block/positioning/leftmargin-topmargin-expected.png:
  • platform/qt/fast/block/positioning/leftmargin-topmargin-expected.txt:
  • platform/qt/fast/block/positioning/negative-right-pos-expected.png:
  • platform/qt/fast/block/positioning/negative-right-pos-expected.txt:
  • platform/qt/fast/block/positioning/padding-percent-expected.png:
  • platform/qt/fast/block/positioning/padding-percent-expected.txt:
  • platform/qt/fast/block/positioning/pref-width-change-expected.txt:
  • platform/qt/fast/block/positioning/relative-overconstrained-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/relative-overflow-block-expected.png:
  • platform/qt/fast/block/positioning/relative-overflow-block-expected.txt:
  • platform/qt/fast/block/positioning/relative-overflow-replaced-expected.png:
  • platform/qt/fast/block/positioning/relative-overflow-replaced-expected.txt:
  • platform/qt/fast/block/positioning/relative-overflow-replaced-float-expected.png:
  • platform/qt/fast/block/positioning/relative-overflow-replaced-float-expected.txt:
  • platform/qt/fast/block/positioning/relayout-on-position-change-expected.png:
  • platform/qt/fast/block/positioning/relayout-on-position-change-expected.txt:
  • platform/qt/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/qt/fast/block/positioning/rtl-fixed-positioning-expected.png:
  • platform/qt/fast/block/positioning/rtl-static-positioning-expected.png:
  • platform/qt/fast/block/positioning/rtl-static-positioning-expected.txt:
  • platform/qt/fast/block/positioning/rtl-static-positioning-inline-block-expected.png:
  • platform/qt/fast/block/positioning/rtl-static-positioning-inline-block-expected.txt:
  • platform/qt/fast/block/positioning/static-distance-with-positioned-ancestor-expected.png:
  • platform/qt/fast/block/positioning/static-distance-with-positioned-ancestor-expected.txt:
  • platform/qt/fast/block/positioning/table-cell-static-position-expected.png:
  • platform/qt/fast/block/positioning/table-cell-static-position-expected.txt:
  • platform/qt/fast/block/positioning/trailing-space-test-expected.png:
  • platform/qt/fast/block/positioning/trailing-space-test-expected.txt:
  • platform/qt/fast/block/positioning/vertical-lr/001-expected.png:
  • platform/qt/fast/block/positioning/vertical-lr/001-expected.txt:
  • platform/qt/fast/block/positioning/vertical-rl/001-expected.png:
  • platform/qt/fast/block/positioning/vertical-rl/001-expected.txt:
  • platform/qt/fast/block/positioning/vertical-rl/fixed-positioning-expected.png:
  • platform/qt/fast/block/positioning/window-height-change-expected.png:
  • platform/qt/fast/block/positioning/window-height-change-expected.txt:
4:58 PM Changeset in webkit [123551] by commit-queue@webkit.org
  • 130 edits
    1 add in trunk/LayoutTests

[Qt] fast/block/float needs rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92150

Patch by Luciano Wolf <Luciano Miguel Wolf> on 2012-07-24
Reviewed by Alexis Menard.

  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt/fast/block/float/001-expected.txt:
  • platform/qt/fast/block/float/002-expected.png:
  • platform/qt/fast/block/float/002-expected.txt:
  • platform/qt/fast/block/float/003-expected.png:
  • platform/qt/fast/block/float/003-expected.txt:
  • platform/qt/fast/block/float/004-expected.png:
  • platform/qt/fast/block/float/004-expected.txt:
  • platform/qt/fast/block/float/005-expected.png:
  • platform/qt/fast/block/float/005-expected.txt:
  • platform/qt/fast/block/float/006-expected.png:
  • platform/qt/fast/block/float/006-expected.txt:
  • platform/qt/fast/block/float/007-expected.png:
  • platform/qt/fast/block/float/007-expected.txt:
  • platform/qt/fast/block/float/010-expected.png:
  • platform/qt/fast/block/float/010-expected.txt:
  • platform/qt/fast/block/float/011-expected.png:
  • platform/qt/fast/block/float/011-expected.txt:
  • platform/qt/fast/block/float/012-expected.png:
  • platform/qt/fast/block/float/012-expected.txt:
  • platform/qt/fast/block/float/013-expected.png:
  • platform/qt/fast/block/float/013-expected.txt:
  • platform/qt/fast/block/float/014-expected.png:
  • platform/qt/fast/block/float/014-expected.txt:
  • platform/qt/fast/block/float/015-expected.png:
  • platform/qt/fast/block/float/015-expected.txt:
  • platform/qt/fast/block/float/016-expected.png:
  • platform/qt/fast/block/float/016-expected.txt:
  • platform/qt/fast/block/float/017-expected.png:
  • platform/qt/fast/block/float/017-expected.txt:
  • platform/qt/fast/block/float/018-expected.png:
  • platform/qt/fast/block/float/018-expected.txt:
  • platform/qt/fast/block/float/020-expected.png:
  • platform/qt/fast/block/float/020-expected.txt:
  • platform/qt/fast/block/float/021-expected.png:
  • platform/qt/fast/block/float/021-expected.txt:
  • platform/qt/fast/block/float/022-expected.png:
  • platform/qt/fast/block/float/022-expected.txt:
  • platform/qt/fast/block/float/023-expected.png:
  • platform/qt/fast/block/float/023-expected.txt:
  • platform/qt/fast/block/float/024-expected.png:
  • platform/qt/fast/block/float/024-expected.txt:
  • platform/qt/fast/block/float/025-expected.png:
  • platform/qt/fast/block/float/025-expected.txt:
  • platform/qt/fast/block/float/027-expected.png:
  • platform/qt/fast/block/float/027-expected.txt:
  • platform/qt/fast/block/float/029-expected.png:
  • platform/qt/fast/block/float/029-expected.txt:
  • platform/qt/fast/block/float/030-expected.png:
  • platform/qt/fast/block/float/030-expected.txt:
  • platform/qt/fast/block/float/031-expected.png:
  • platform/qt/fast/block/float/031-expected.txt:
  • platform/qt/fast/block/float/032-expected.png:
  • platform/qt/fast/block/float/032-expected.txt:
  • platform/qt/fast/block/float/avoidance-percent-width-compat-expected.png: Added.
  • platform/qt/fast/block/float/avoidance-percent-width-compat-expected.txt:
  • platform/qt/fast/block/float/avoidance-percent-width-strict-expected.png:
  • platform/qt/fast/block/float/avoidance-percent-width-strict-expected.txt:
  • platform/qt/fast/block/float/avoiding-float-centered-expected.png:
  • platform/qt/fast/block/float/avoiding-float-centered-expected.txt:
  • platform/qt/fast/block/float/br-with-clear-expected.txt:
  • platform/qt/fast/block/float/centered-float-avoidance-complexity-expected.png:
  • platform/qt/fast/block/float/centered-float-avoidance-complexity-expected.txt:
  • platform/qt/fast/block/float/clamped-right-float-expected.png:
  • platform/qt/fast/block/float/clamped-right-float-expected.txt:
  • platform/qt/fast/block/float/clear-element-too-wide-for-containing-block-expected.png:
  • platform/qt/fast/block/float/clear-element-too-wide-for-containing-block-expected.txt:
  • platform/qt/fast/block/float/dynamic-unfloat-pref-width-expected.png:
  • platform/qt/fast/block/float/dynamic-unfloat-pref-width-expected.txt:
  • platform/qt/fast/block/float/editable-text-overlapping-float-expected.png:
  • platform/qt/fast/block/float/editable-text-overlapping-float-expected.txt:
  • platform/qt/fast/block/float/fit_line_below_floats-expected.png:
  • platform/qt/fast/block/float/fit_line_below_floats-expected.txt:
  • platform/qt/fast/block/float/float-avoidance-expected.png:
  • platform/qt/fast/block/float/float-avoidance-expected.txt:
  • platform/qt/fast/block/float/float-in-float-hit-testing-expected.png:
  • platform/qt/fast/block/float/float-in-float-hit-testing-expected.txt:
  • platform/qt/fast/block/float/float-in-float-painting-expected.png:
  • platform/qt/fast/block/float/float-in-float-painting-expected.txt:
  • platform/qt/fast/block/float/floats-and-text-indent-expected.png:
  • platform/qt/fast/block/float/floats-and-text-indent-expected.txt:
  • platform/qt/fast/block/float/floats-and-text-indent-rl-expected.png:
  • platform/qt/fast/block/float/floats-and-text-indent-rl-expected.txt:
  • platform/qt/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.txt:
  • platform/qt/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.txt:
  • platform/qt/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.txt:
  • platform/qt/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.txt:
  • platform/qt/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.txt:
  • platform/qt/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.txt:
  • platform/qt/fast/block/float/intruding-painted-twice-expected.png:
  • platform/qt/fast/block/float/intruding-painted-twice-expected.txt:
  • platform/qt/fast/block/float/marquee-shrink-to-avoid-floats-expected.png:
  • platform/qt/fast/block/float/marquee-shrink-to-avoid-floats-expected.txt:
  • platform/qt/fast/block/float/multiple-float-positioning-expected.png:
  • platform/qt/fast/block/float/multiple-float-positioning-expected.txt:
  • platform/qt/fast/block/float/nested-clearance-expected.png:
  • platform/qt/fast/block/float/nested-clearance-expected.txt:
  • platform/qt/fast/block/float/nestedAnonymousBlocks-expected.png:
  • platform/qt/fast/block/float/nestedAnonymousBlocks-expected.txt:
  • platform/qt/fast/block/float/nestedAnonymousBlocks2-expected.png:
  • platform/qt/fast/block/float/nestedAnonymousBlocks2-expected.txt:
  • platform/qt/fast/block/float/nopaint-after-layer-destruction-expected.png:
  • platform/qt/fast/block/float/nopaint-after-layer-destruction-expected.txt:
  • platform/qt/fast/block/float/nopaint-after-layer-destruction2-expected.png:
  • platform/qt/fast/block/float/nopaint-after-layer-destruction2-expected.txt:
  • platform/qt/fast/block/float/overhanging-after-height-decrease-expected.png:
  • platform/qt/fast/block/float/overhanging-after-height-decrease-expected.txt:
  • platform/qt/fast/block/float/overhanging-float-add-in-static-position-block-expected.txt:
  • platform/qt/fast/block/float/overhanging-float-add-in-static-position-block2-expected.txt:
  • platform/qt/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.txt:
  • platform/qt/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.txt:
  • platform/qt/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.png:
  • platform/qt/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.txt:
  • platform/qt/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.png:
  • platform/qt/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.txt:
  • platform/qt/fast/block/float/overhanging-tall-block-expected.txt:
  • platform/qt/fast/block/float/overlapping-floats-with-overflow-hidden-expected.png:
  • platform/qt/fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt:
  • platform/qt/fast/block/float/shrink-to-avoid-float-complexity-expected.png:
  • platform/qt/fast/block/float/shrink-to-avoid-float-complexity-expected.txt:
  • platform/qt/fast/block/float/shrink-to-fit-width-expected.png:
  • platform/qt/fast/block/float/shrink-to-fit-width-expected.txt:
  • platform/qt/fast/block/float/table-relayout-expected.png:
  • platform/qt/fast/block/float/table-relayout-expected.txt:
  • platform/qt/fast/block/float/vertical-move-relayout-expected.png:
  • platform/qt/fast/block/float/vertical-move-relayout-expected.txt:
  • platform/qt/fast/block/float/width-update-after-clear-expected.png:
  • platform/qt/fast/block/float/width-update-after-clear-expected.txt:
4:51 PM Changeset in webkit [123550] by jianli@chromium.org
  • 6 edits in trunk/Source/WebCore

[V8] Correct WebIDL type should be used in the testing IDL file
https://bugs.webkit.org/show_bug.cgi?id=92168

Reviewed by Kentaro Hara.

Updated bindings test.

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_strict_function):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionStrictFunction):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::enabledAtRuntimeMethod1Callback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod2Callback):
(WebCore::TestObjV8Internal::enabledPerContextMethod1Callback):
(WebCore::TestObjV8Internal::enabledPerContextMethod2Callback):
(WebCore::TestObjV8Internal::strictFunctionCallback):

4:38 PM Changeset in webkit [123549] by tkent@chromium.org
  • 1 edit in branches/chromium/1180/Source/WebCore/html/shadow/TextFieldDecorationElement.cpp

Merge 123187 - [Chromium] Fix an assertion failure in TextFieldDecorationElement::hostInput()
https://bugs.webkit.org/show_bug.cgi?id=91824

Reviewed by Hajime Morita.

No new tests. This code is used only in Chromium browser.

  • html/shadow/TextFieldDecorationElement.cpp:

(WebCore::TextFieldDecorationElement::hostInput):
Use shadowHost(), and allow to return 0.
(WebCore::TextFieldDecorationElement::defaultEventHandler):
Check 0.

TBR=tkent@chromium.org
BUG=crbug.com/136145
Review URL: https://chromiumcodereview.appspot.com/10809092

4:34 PM Changeset in webkit [123548] by tkent@chromium.org
  • 3 edits in branches/chromium/1180/Source/WebCore

Merge 123180 - Introduce Node::shadowHost()
https://bugs.webkit.org/show_bug.cgi?id=91814

Reviewed by Hajime Morita.

Introduce Node::shadowHost(), which return the host element, or 0.
Node::shadowAncestorNode() is used to obtain a shadow host. However it
is confusing because it returns 'this' if this is not in a shadow tree.

Replaces one callsite of shadowAncestorNode() with shadowHost().

No behavior change.

  • dom/Node.cpp:

(WebCore::Node::shadowHost): Added.

  • dom/Node.h:

(Node): Declare shadowHost(), and add a comment to shadowAncestorNode().

  • html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::hostInput):
Replace shadowAncestorNode() with shaodwHost().

TBR=tkent@chromium.org
BUG=crbug.com/136145
Review URL: https://chromiumcodereview.appspot.com/10823003

4:12 PM Changeset in webkit [123547] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r123191.
http://trac.webkit.org/changeset/123191
https://bugs.webkit.org/show_bug.cgi?id=91804

It might cause another performance regression.
http://code.google.com/p/chromium/issues/detail?id=138410

  • html/FormController.cpp:

(FormKeyGenerator):
(WebCore::createKey):
(WebCore::FormKeyGenerator::formKey):
(WebCore::FormKeyGenerator::willDeleteForm):

3:55 PM Changeset in webkit [123546] by commit-queue@webkit.org
  • 12 edits in trunk/Source/WebCore

[JSBinding] Merging jsUnsignedLongArrayToVector() to toNativeArray() using traits.
https://bugs.webkit.org/show_bug.cgi?id=90381

Patch by Vineet Chaudhary <Vineet> on 2012-07-24
Reviewed by Kentaro Hara.

We can remove jsUnsignedLongArrayToVector() implementaion
merging it to current and toNativeArray() traits.

Tests: TestObj.idl
There should be no behavoiral changes as just refactoring.

  • Modules/vibration/NavigatorVibration.idl: Use sequence<T> as method param than T[]
  • bindings/js/JSDOMBinding.cpp: Moved toJSSequence() to header file.
  • bindings/js/JSDOMBinding.h:

(WebCore::toJSSequence): Moved toJSSequence() to header file.
(WebCore::jsArray): Renamed Traits to JSValueTraits
(WebCore::toNativeArray): Using traits.

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue):

  • bindings/js/JSMessagePortCustom.cpp:

(WebCore::fillMessagePortArray):

  • bindings/scripts/CodeGeneratorJS.pm: Removed unsigned long[] specific binding code.

(AddIncludesForType):
(GenerateParametersCheckExpression):
(JSValueToNative):
(NativeToJSValue):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateParametersCheckExpression): Added check sequence<T> check for overloaded methods.

  • bindings/scripts/test/JS/JSTestObj.cpp: Rebased binding test.

(WebCore::jsTestObjPrototypeFunctionOverloadedMethod10):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod):
(WebCore::jsTestObjPrototypeFunctionMethodWithUnsignedLongSequence):

  • bindings/scripts/test/JS/JSTestObj.h: Rebased binding test.
  • bindings/scripts/test/TestObj.idl: Added test for sequence<T> as method parameter.
  • bindings/scripts/test/V8/V8TestObj.cpp: Rebased binding test.

(WebCore::TestObjV8Internal::overloadedMethod10Callback):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::overloadedMethodCallback):

3:54 PM Changeset in webkit [123545] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[EFL][WK2] Add unit tests for custom text encoding setting
https://bugs.webkit.org/show_bug.cgi?id=91983

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-24
Reviewed by Dirk Pranke.

Add unit tests for get and set custom text encoding methods. Also, fix
a style nit for r123177.

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_setting_encoding_custom_set): Fix a style nit - add newline
before return.

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

3:51 PM Changeset in webkit [123544] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit2

WinCairo build fix attempt.

  • win/WebKit2CFLite.def:
3:34 PM Changeset in webkit [123543] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit2

Windows build fix attempt.

3:34 PM Changeset in webkit [123542] by kseo@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove an invalid assertion introduced in r123536. Unreviewed.

  • xml/parser/MarkupTokenBase.h:

(WebCore::AtomicMarkupTokenBase::clearExternalCharacters):

3:33 PM Changeset in webkit [123541] by zmo@google.com
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r123504.
http://trac.webkit.org/changeset/123504
https://bugs.webkit.org/show_bug.cgi?id=92169

broke a bunch of text-related tests in chromium mac debug
(Requested by zhenyao on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-24

  • platform/text/cf/StringCF.cpp:

(WTF::String::createCFString):

  • platform/text/cf/StringImplCF.cpp:

(WTF::StringImpl::createCFString):

3:26 PM Changeset in webkit [123540] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium expectations change stop ignoring fast/hidpi changes.

  • platform/chromium/TestExpectations:
3:22 PM Changeset in webkit [123539] by simonjam@chromium.org
  • 3 edits
    2 copies in branches/chromium/1180

Merge 123121 - Regression(120096): Protect the element used by ImageLoader until the end of notifyFinished().
https://bugs.webkit.org/show_bug.cgi?id=90471

Reviewed by Brady Eidson.

Source/WebCore:

Test: http/tests/security/video-poster-cross-origin-crash.html

  • html/HTMLImageLoader.cpp:

(WebCore::HTMLImageLoader::notifyFinished): Hang on to the element until we're done.

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::setImage): No behavior change.
(WebCore):
(WebCore::ImageLoader::setImageWithoutConsideringPendingLoadEvent): Split off from old setImage, minus calling updatedHasPendingLoadEvent().
(WebCore::ImageLoader::notifyFinished): Invoke updatedHasPendingLoadEvent when done with cross origin errors.

  • loader/ImageLoader.h:

(ImageLoader):

LayoutTests:

  • http/tests/security/video-poster-cross-origin-crash-expected.txt: Added.
  • http/tests/security/video-poster-cross-origin-crash.html: Added. From fuzzer.

TBR=simonjam@chromium.org

3:20 PM Changeset in webkit [123538] by dpranke@chromium.org
  • 4 edits
    1 copy in trunk/Tools

make test-webkitpy at least kinda work in parallel on win32
https://bugs.webkit.org/show_bug.cgi?id=91700

Reviewed by Adam Barth.

This change makes the hoop-jumping we have to do to make running
new-run-webkit-tests in parallel on win32 generic so that we can
re-use it for test-webkitpy as well.

  • Scripts/new-run-webkit-tests:
  • Scripts/test-webkitpy:
  • Scripts/webkitpy/common/multiprocessing_bootstrap.py: Copied from Tools/Scripts/new-run-webkit-tests.

(run):

  • Scripts/webkitpy/test/main.py:

(main):
(Tester._log_exception):

3:19 PM Changeset in webkit [123537] by kseo@webkit.org
  • 4 edits in trunk/Source/WebCore

Ensure Noah's ark without reading the DOM tree.
https://bugs.webkit.org/show_bug.cgi?id=92065

Reviewed by Adam Barth.

Technically we shouldn't read attributes back from the DOM. If JavaScript changes
the attributes values, we could get a slightly wrong output here.

Read attributes from tokens saved in the active formatting element list.

No new tests, covered by existing tests.

  • html/parser/HTMLFormattingElementList.cpp:

(WebCore::attributeCount):
(WebCore::HTMLFormattingElementList::append):
(WebCore::HTMLFormattingElementList::tryToEnsureNoahsArkConditionQuickly):
(WebCore::HTMLFormattingElementList::ensureNoahsArkCondition):

  • html/parser/HTMLFormattingElementList.h:

(HTMLFormattingElementList):

  • html/parser/HTMLStackItem.h:

(WebCore::HTMLStackItem::localName):
(HTMLStackItem):

3:12 PM Changeset in webkit [123536] by kseo@webkit.org
  • 3 edits in trunk/Source/WebCore

Clear the external characters pointer of an AtomicHTMLToken before the raw token is cleared.
https://bugs.webkit.org/show_bug.cgi?id=92056

Reviewed by Adam Barth.

AtomicHTMLToken keeps a pointer to the HTMLToken's buffer instead of copying the
characters for performance. Clear the external characters pointer before the raw token
is cleared to make sure that we won't have a dangling pointer.

No new tests - no functional changes.

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::constructTreeFromToken):

  • xml/parser/MarkupTokenBase.h:

(WebCore::AtomicMarkupTokenBase::clearExternalCharacters):
(AtomicMarkupTokenBase):

3:08 PM Changeset in webkit [123535] by jianli@chromium.org
  • 12 edits in trunk/Source

Add per-context setting for html notifications
https://bugs.webkit.org/show_bug.cgi?id=91295

Reviewed by Adam Barth.

Source/WebCore:

Added a new per-context setting to control the enabling of html notifications.
For chromium port, we're going to disable html notifications for web
pages, but still keep it enabled for extensions.

Also enhance V8 code generator to support V8EnabledPerContext attribute
for methods.

Updated the binding tests.

  • Modules/notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::document): Expose document for being used by installPerContextProperties.
(WebCore):

  • Modules/notifications/NotificationCenter.h:

(NotificationCenter):

  • Modules/notifications/NotificationCenter.idl: Add V8EnabledPerContext attribute.
  • bindings/scripts/CodeGeneratorV8.pm: V8EnabledPerContext now supports methods.

(GenerateHeader):
(IsStandardFunction):
(GenerateNonStandardFunction):
(GenerateImplementation):
(GenerateToV8Converters):
(GetContextEnableFunction):

  • bindings/scripts/test/TestObj.idl: Add test case for V8EnabledPerContext methods.
  • bindings/scripts/test/V8/V8TestObj.cpp: Update test result.

(WebCore::TestObjV8Internal::enabledAtContextMethod1Callback):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::enabledAtContextMethod2Callback):
(WebCore::V8TestObj::installPerContextProperties):
(WebCore::V8TestObj::wrapSlow):

  • dom/ContextFeatures.cpp: Add a new per-context feature.

(WebCore::ContextFeatures::htmlNotificationsEnabled):
(WebCore):

  • dom/ContextFeatures.h: Add a new per-context feature.

Source/WebKit/chromium:

Add new per-context feature for chromium port.

  • public/WebPermissionClient.h:

(WebPermissionClient):
(WebKit::WebPermissionClient::allowHTMLNotifications):

  • src/ContextFeaturesClientImpl.cpp:

(WebKit::ContextFeaturesClientImpl::askIfIsEnabled):

3:07 PM Changeset in webkit [123534] by inferno@chromium.org
  • 1 edit in branches/chromium/1180/Source/WebCore/html/shadow/TextFieldDecorationElement.cpp

Revert 123529 - Merge 123187 - [Chromium] Fix an assertion failure in TextFieldDecorationElement::hostInput()
https://bugs.webkit.org/show_bug.cgi?id=91824
BUG=136145
Review URL: https://chromiumcodereview.appspot.com/10818041

TBR=inferno@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10819007

3:07 PM Changeset in webkit [123533] by zmo@google.com
  • 23 edits
    5 deletes in trunk

Unreviewed, rolling out r123499.
http://trac.webkit.org/changeset/123499
https://bugs.webkit.org/show_bug.cgi?id=92161

Android fails to compile (Requested by zhenyao on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-24

Source/Platform:

  • chromium/public/WebMediaStreamDescriptor.h:

(WebMediaStreamDescriptor):

  • chromium/public/WebMediaStreamSource.h:

(WebMediaStreamSource):

Source/WebCore:

  • GNUmakefile.list.am:
  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::addTrack):

  • Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::create):
(WebCore::MediaStreamTrack::MediaStreamTrack):
(WebCore::MediaStreamTrack::~MediaStreamTrack):
(WebCore::MediaStreamTrack::setEnabled):

  • Modules/mediastream/MediaStreamTrack.h:

(MediaStreamTrack):

  • Modules/mediastream/MediaStreamTrack.idl:
  • WebCore.gypi:
  • dom/EventNames.h:

(WebCore):

  • dom/EventTargetFactory.in:
  • platform/chromium/support/WebMediaStreamDescriptor.cpp:

(WebKit):
(WebKit::WebMediaStreamDescriptor::sources):

  • platform/chromium/support/WebMediaStreamSource.cpp:
  • platform/mediastream/MediaStreamSource.cpp: Removed.
  • platform/mediastream/MediaStreamSource.h:

(WebCore::MediaStreamSource::create):
(WebCore::MediaStreamSource::muted):
(WebCore::MediaStreamSource::setMuted):
(WebCore::MediaStreamSource::MediaStreamSource):
(MediaStreamSource):

  • platform/mediastream/chromium/MediaStreamCenterChromium.cpp:

(WebCore::MediaStreamCenterChromium::queryMediaStreamSources):
(WebCore::MediaStreamCenterChromium::didCreateMediaStream):

Source/WebKit/chromium:

  • src/AssertMatchingEnums.cpp:

Tools:

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:

(MockWebKitPlatformSupport::createMediaStreamCenter):

  • DumpRenderTree/chromium/MockWebKitPlatformSupport.h:

(MockWebKitPlatformSupport):

  • DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp: Removed.
  • DumpRenderTree/chromium/MockWebMediaStreamCenter.h: Removed.

LayoutTests:

  • fast/mediastream/MediaStreamTrack-expected.txt: Removed.
  • fast/mediastream/MediaStreamTrack.html: Removed.
3:01 PM Changeset in webkit [123532] by atwilson@chromium.org
  • 1 edit
    20 adds in trunk/LayoutTests

Unreviewed chromium expectations update from r123490.

  • platform/chromium-mac-snowleopard/fast/hidpi/broken-image-icon-hidpi-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/broken-image-with-size-hidpi-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/clip-text-in-hidpi-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/device-scale-factor-paint-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/focus-rings-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-as-background-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-background-dynamic-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-background-repeat-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-background-repeat-without-size-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-border-image-comparison-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-border-image-dynamic-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-border-image-simple-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-in-content-dynamic-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-out-of-order-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-simple-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-without-specified-width-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/resize-corner-hidpi-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/video-controls-in-hidpi-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/video-controls-in-hidpi-expected.txt: Added.
2:48 PM Changeset in webkit [123531] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/1180

Merge 122918 - Fix an assertion failure in CalendarPickerElement::hostInput().
https://bugs.webkit.org/show_bug.cgi?id=91568
BUG=137671
Review URL: https://chromiumcodereview.appspot.com/10795098

2:44 PM Changeset in webkit [123530] by dpranke@chromium.org
  • 11 edits in trunk/Tools

nrwt: never finds binaries in the 'out' dir on chromium win
https://bugs.webkit.org/show_bug.cgi?id=91890

Reviewed by Tony Chang.

Attempt to fix this bug yet again; it turns out that --root and
--build-directory don't have the same meaning (--root should
include the configuration, --build-directory should not).

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port._build_path):

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort._static_build_path):
(ChromiumPort.default_results_directory):
(ChromiumPort._build_path):
(ChromiumPort):
(ChromiumPort._build_path_with_configuration):
(ChromiumPort._build_path_with_configuration.does):
(ChromiumPort._path_to_image_diff):

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort._build_path):
(ChromiumAndroidPort):
(ChromiumAndroidPort._build_path_with_configuration):
(ChromiumAndroidPort._path_to_driver):
(ChromiumAndroidPort._path_to_forwarder):
(ChromiumAndroidPort._push_executable):
(ChromiumAndroidPort._push_fonts):

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:

(ChromiumLinuxPort._determine_driver_path_statically):
(ChromiumLinuxPort._modules_to_search_for_symbols):
(ChromiumLinuxPort._path_to_driver):

  • Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:

(ChromiumLinuxPortTest.test_build_path):

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:

(ChromiumMacPort._modules_to_search_for_symbols):
(ChromiumMacPort._path_to_driver):
(ChromiumMacPort._path_to_helper):

  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:

(ChromiumMacPortTest.test_build_path):

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:

(ChromiumWinPort._path_to_driver):
(ChromiumWinPort._path_to_helper):
(ChromiumWinPort._path_to_image_diff):

  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:

(ChromiumWinTest.test_build_path):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

2:37 PM Changeset in webkit [123529] by inferno@chromium.org
  • 1 edit in branches/chromium/1180/Source/WebCore/html/shadow/TextFieldDecorationElement.cpp

Merge 123187 - [Chromium] Fix an assertion failure in TextFieldDecorationElement::hostInput()
https://bugs.webkit.org/show_bug.cgi?id=91824
BUG=136145
Review URL: https://chromiumcodereview.appspot.com/10818041

2:35 PM Changeset in webkit [123528] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/1180

Merge 123128 - Crash in WebCore::StyleResolver::collectMatchingRulesForList
https://bugs.webkit.org/show_bug.cgi?id=90803
BUG=136235
Review URL: https://chromiumcodereview.appspot.com/10809085

2:26 PM Changeset in webkit [123527] by caio.oliveira@openbossa.org
  • 60 edits
    11 deletes in trunk/LayoutTests

[Qt] svg/batik rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92162

Unreviewed.

  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/svg/batik/text/smallFonts-expected.png: Removed.
  • platform/qt-5.0/svg/batik/text/smallFonts-expected.txt: Removed.
  • platform/qt-5.0/svg/batik/text/textAnchor-expected.png: Removed.
  • platform/qt-5.0/svg/batik/text/textAnchor-expected.txt: Removed.
  • platform/qt-5.0/svg/batik/text/textEffect-expected.png: Removed.
  • platform/qt-5.0/svg/batik/text/textEffect-expected.txt: Removed.
  • platform/qt-5.0/svg/batik/text/textEffect3-expected.png: Removed.
  • platform/qt-5.0/svg/batik/text/textEffect3-expected.txt: Removed.
  • platform/qt-5.0/svg/batik/text/textPosition-expected.txt: Removed.
  • platform/qt-5.0/svg/batik/text/textPosition2-expected.png: Removed.
  • platform/qt-5.0/svg/batik/text/textPosition2-expected.txt: Removed.
  • platform/qt/svg/batik/filters/filterRegions-expected.png:
  • platform/qt/svg/batik/filters/filterRegions-expected.txt:
  • platform/qt/svg/batik/masking/maskRegions-expected.png:
  • platform/qt/svg/batik/masking/maskRegions-expected.txt:
  • platform/qt/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
  • platform/qt/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
  • platform/qt/svg/batik/paints/patternRegionA-expected.png:
  • platform/qt/svg/batik/paints/patternRegionA-expected.txt:
  • platform/qt/svg/batik/paints/patternRegions-expected.png:
  • platform/qt/svg/batik/paints/patternRegions-expected.txt:
  • platform/qt/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/qt/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
  • platform/qt/svg/batik/text/longTextOnPath-expected.png:
  • platform/qt/svg/batik/text/longTextOnPath-expected.txt:
  • platform/qt/svg/batik/text/smallFonts-expected.png:
  • platform/qt/svg/batik/text/smallFonts-expected.txt:
  • platform/qt/svg/batik/text/textAnchor-expected.png:
  • platform/qt/svg/batik/text/textAnchor-expected.txt:
  • platform/qt/svg/batik/text/textAnchor2-expected.png:
  • platform/qt/svg/batik/text/textAnchor2-expected.txt:
  • platform/qt/svg/batik/text/textAnchor3-expected.png:
  • platform/qt/svg/batik/text/textAnchor3-expected.txt:
  • platform/qt/svg/batik/text/textDecoration-expected.png:
  • platform/qt/svg/batik/text/textDecoration-expected.txt:
  • platform/qt/svg/batik/text/textDecoration2-expected.png:
  • platform/qt/svg/batik/text/textDecoration2-expected.txt:
  • platform/qt/svg/batik/text/textEffect-expected.png:
  • platform/qt/svg/batik/text/textEffect-expected.txt:
  • platform/qt/svg/batik/text/textEffect2-expected.png:
  • platform/qt/svg/batik/text/textEffect2-expected.txt:
  • platform/qt/svg/batik/text/textEffect3-expected.png:
  • platform/qt/svg/batik/text/textEffect3-expected.txt:
  • platform/qt/svg/batik/text/textFeatures-expected.png:
  • platform/qt/svg/batik/text/textFeatures-expected.txt:
  • platform/qt/svg/batik/text/textGlyphOrientationHorizontal-expected.png:
  • platform/qt/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
  • platform/qt/svg/batik/text/textLayout2-expected.png:
  • platform/qt/svg/batik/text/textLayout2-expected.txt:
  • platform/qt/svg/batik/text/textLength-expected.png:
  • platform/qt/svg/batik/text/textLength-expected.txt:
  • platform/qt/svg/batik/text/textOnPath-expected.png:
  • platform/qt/svg/batik/text/textOnPath-expected.txt:
  • platform/qt/svg/batik/text/textOnPath2-expected.png:
  • platform/qt/svg/batik/text/textOnPath2-expected.txt:
  • platform/qt/svg/batik/text/textOnPath3-expected.png:
  • platform/qt/svg/batik/text/textOnPath3-expected.txt:
  • platform/qt/svg/batik/text/textPCDATA-expected.png:
  • platform/qt/svg/batik/text/textPCDATA-expected.txt:
  • platform/qt/svg/batik/text/textPosition-expected.png:
  • platform/qt/svg/batik/text/textPosition-expected.txt:
  • platform/qt/svg/batik/text/textPosition2-expected.png:
  • platform/qt/svg/batik/text/textPosition2-expected.txt:
  • platform/qt/svg/batik/text/textProperties-expected.png:
  • platform/qt/svg/batik/text/textProperties-expected.txt:
  • platform/qt/svg/batik/text/textProperties2-expected.png:
  • platform/qt/svg/batik/text/textProperties2-expected.txt:
  • platform/qt/svg/batik/text/verticalTextOnPath-expected.png:
  • platform/qt/svg/batik/text/verticalTextOnPath-expected.txt:
2:09 PM Changeset in webkit [123526] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Do not call settings setters twice on page construction
https://bugs.webkit.org/show_bug.cgi?id=92157

Reviewed by Yong Li.

The WebPagePrivate init method sets some settings value that were
already set in didChangeSettings.
Also call didChangeSettings explicitly from init, before that we are
not calling it since the delegate is not set yet.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

1:59 PM Changeset in webkit [123525] by jchaffraix@webkit.org
  • 3 edits
    2 adds in trunk

Crash in RenderTableSection::layoutRows
https://bugs.webkit.org/show_bug.cgi?id=92145

Reviewed by Abhishek Arya.

Source/WebCore:

The crash came from the insertChildNode logic being confused and choosing the wrong
renderer for insertion. This is because after r123159, table anonymous wrappers can
be created as 'inline-table' and wouldn't pass the isAnonymousBlock() check.

This change also aligns the ancestor iteration with RenderBlock::addChildToAnonymousColumnBlocks.

Test: fast/table/crash-table-section-layoutRows.html

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::insertChildNode):
Changed the code to always get the right child. There is no justification to not
walking up to the |owner|'s direct child in all cases.

LayoutTests:

  • fast/table/crash-table-section-layoutRows-expected.txt: Added.
  • fast/table/crash-table-section-layoutRows.html: Added.
1:53 PM Changeset in webkit [123524] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

Make RenderBlock::paintChildren virtual so sub classes can change the paint order
https://bugs.webkit.org/show_bug.cgi?id=92042

Reviewed by Ojan Vafai.

The flexbox spec says that the order property should change the paint order of flex children.
To make that possible, make paintChildren virtual so RenderFlexibleBox can override it.

No new tests, this is just a refactoring.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintContents): Move some code out of paintChildren into paintContents.
(WebCore::RenderBlock::paintChildren): Make virtual and just have it be a simple for loop.
(WebCore::RenderBlock::paintChild): Move code out of paintChildren so subclasses can reuse.

  • rendering/RenderBlock.h:

(RenderBlock): Make paintChildren virtual and protected so sub classes can call paintChild.

1:46 PM Changeset in webkit [123523] by caio.oliveira@openbossa.org
  • 16 edits
    4 deletes in trunk/LayoutTests

[Qt] svg/clip-path rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92158

Unreviewed.

Create a separate bug to track two tests that had wrong expected results before
the font change.

  • platform/qt-5.0/Skipped:
  • platform/qt/svg/clip-path/clip-path-pixelation-expected.png:
  • platform/qt/svg/clip-path/clip-path-pixelation-expected.txt:
  • platform/qt/svg/clip-path/clip-path-text-and-shape-expected.png:
  • platform/qt/svg/clip-path/clip-path-text-and-shape-expected.txt:
  • platform/qt/svg/clip-path/clip-path-text-and-stroke-expected.png:
  • platform/qt/svg/clip-path/clip-path-text-and-stroke-expected.txt:
  • platform/qt/svg/clip-path/clip-path-text-expected.png:
  • platform/qt/svg/clip-path/clip-path-text-expected.txt:
  • platform/qt/svg/clip-path/clip-path-tspan-and-stroke-expected.png:
  • platform/qt/svg/clip-path/clip-path-tspan-and-stroke-expected.txt:
  • platform/qt/svg/clip-path/clip-path-with-text-clipped-expected.png:
  • platform/qt/svg/clip-path/clip-path-with-text-clipped-expected.txt:
  • platform/qt/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png:
  • platform/qt/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt:
  • platform/qt/svg/clip-path/deep-nested-clip-in-mask-expected.png: Removed.
  • platform/qt/svg/clip-path/deep-nested-clip-in-mask-expected.txt: Removed.
  • platform/qt/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png: Removed.
  • platform/qt/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt: Removed.
1:44 PM Changeset in webkit [123522] by annacc@chromium.org
  • 18 edits
    7 adds in trunk/Source/WebCore

Create SourceBuffer and SourceBufferList objects
https://bugs.webkit.org/show_bug.cgi?id=91771

Reviewed by Eric Carlson.

SourceBuffer and SourceBufferList objects are needed in order to
implement the new object-oriented MediaSource API:
http://dvcs.w3.org/hg/html-media/raw-file/tip/media-source/media-source.html

No new tests - will be able to test after landing BUGWK91775

Adding new files to build files:

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.vcproj/copyForwardingHeaders.cmd:
  • WebCore.xcodeproj/project.pbxproj:

New objects:

  • Modules/mediasource/SourceBuffer.cpp: Added.
  • Modules/mediasource/SourceBuffer.h: Added.
  • Modules/mediasource/SourceBuffer.idl: Added.
  • Modules/mediasource/SourceBufferList.cpp: Added.
  • Modules/mediasource/SourceBufferList.h: Added.
  • Modules/mediasource/SourceBufferList.idl: Added.

New events:

  • dom/EventNames.h:

(WebCore):

  • dom/EventTarget.h:

(WebCore):

  • dom/EventTargetFactory.in:

Object constructors:

  • page/DOMWindow.idl:
1:33 PM Changeset in webkit [123521] by zmo@google.com
  • 36 edits
    8 deletes in trunk/LayoutTests

Rebaseline - gardening stuff.

Unreviewed.

  • fast/canvas/webgl/framebuffer-object-attachment-expected.txt:
  • fast/canvas/webgl/framebuffer-object-attachment.html:
  • fast/canvas/webgl/resources/webgl-test-utils.js:

(WebGLTestUtils):

  • platform/chromium-linux-x86/css3/selectors3/html: Removed.
  • platform/chromium-linux-x86/css3/selectors3/xhtml: Removed.
  • platform/chromium-linux-x86/css3/selectors3/xml: Removed.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/core: Removed.
  • platform/chromium-linux/compositing/overflow/theme-affects-visual-overflow-expected.png:
  • platform/chromium-linux/css1/box_properties/acid_test-expected.png:
  • platform/chromium-linux/css2.1/t09-c5526c-display-00-e-expected.png:
  • platform/chromium-linux/css3/selectors3/html/css3-modsel-25-expected.png:
  • platform/chromium-linux/css3/selectors3/html/css3-modsel-70-expected.png:
  • platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-25-expected.png:
  • platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-70-expected.png:
  • platform/chromium-linux/css3/selectors3/xml/css3-modsel-25-expected.png:
  • platform/chromium-linux/css3/selectors3/xml/css3-modsel-70-expected.png:
  • platform/chromium-linux/fast/block/basic/011-expected.png:
  • platform/chromium-linux/fast/block/margin-collapse/103-expected.png:
  • platform/chromium-linux/fast/css/non-standard-checkbox-size-expected.png:
  • platform/chromium-linux/fast/forms/001-expected.png:
  • platform/chromium-linux/fast/forms/basic-inputs-expected.png:
  • platform/chromium-linux/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-linux/fast/forms/file/file-input-disabled-expected.png:
  • platform/chromium-linux/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-linux/fast/forms/formmove-expected.png:
  • platform/chromium-linux/fast/forms/formmove2-expected.png:
  • platform/chromium-linux/fast/forms/indeterminate-expected.png:
  • platform/chromium-linux/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-linux/fast/forms/input-value-expected.png:
  • platform/chromium-linux/fast/inline/positionedLifetime-expected.png:
  • platform/chromium-linux/fast/parser/bad-xml-slash-expected.png:
  • platform/chromium-linux/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-linux/fast/replaced/width100percent-checkbox-expected.png:
  • platform/chromium-linux/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-linux/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions2-expected.png:
  • platform/chromium-mac-snowleopard/fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Removed.
  • platform/chromium-win-xp/fast/text/whitespace/normal-after-nowrap-breaking-expected.png: Removed.
  • platform/mac-snowleopard/fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Removed.
  • platform/mac/fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Removed.
1:32 PM Changeset in webkit [123520] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Add a bounding box member in WebGestureEvent
https://bugs.webkit.org/show_bug.cgi?id=92144

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-07-24
Reviewed by Adam Barth.

The new |boundingBox| member will be used to store the touch region for a WebGestureEvent.
This will be useful for gesture target fuzzing across multiple different gesture types
(tap, long press, scroll, etc.)

  • public/WebInputEvent.h:

(WebGestureEvent):

  • src/WebInputEvent.cpp:

(SameSizeAsWebGestureEvent):

1:29 PM Changeset in webkit [123519] by commit-queue@webkit.org
  • 55 edits in trunk/LayoutTests

[Qt] fast/block/basic needs rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92149

Patch by Luciano Wolf <Luciano Miguel Wolf> on 2012-07-24
Reviewed by Alexis Menard.

  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt/fast/block/basic/001-expected.png:
  • platform/qt/fast/block/basic/001-expected.txt:
  • platform/qt/fast/block/basic/002-expected.png:
  • platform/qt/fast/block/basic/002-expected.txt:
  • platform/qt/fast/block/basic/003-expected.png:
  • platform/qt/fast/block/basic/003-expected.txt:
  • platform/qt/fast/block/basic/004-expected.png:
  • platform/qt/fast/block/basic/004-expected.txt:
  • platform/qt/fast/block/basic/005-expected.png:
  • platform/qt/fast/block/basic/005-expected.txt:
  • platform/qt/fast/block/basic/006-expected.png:
  • platform/qt/fast/block/basic/006-expected.txt:
  • platform/qt/fast/block/basic/007-expected.png:
  • platform/qt/fast/block/basic/007-expected.txt:
  • platform/qt/fast/block/basic/008-expected.png:
  • platform/qt/fast/block/basic/008-expected.txt:
  • platform/qt/fast/block/basic/009-expected.png:
  • platform/qt/fast/block/basic/009-expected.txt:
  • platform/qt/fast/block/basic/010-expected.png:
  • platform/qt/fast/block/basic/010-expected.txt:
  • platform/qt/fast/block/basic/011-expected.png:
  • platform/qt/fast/block/basic/011-expected.txt:
  • platform/qt/fast/block/basic/012-expected.png:
  • platform/qt/fast/block/basic/012-expected.txt:
  • platform/qt/fast/block/basic/013-expected.png:
  • platform/qt/fast/block/basic/013-expected.txt:
  • platform/qt/fast/block/basic/014-expected.png:
  • platform/qt/fast/block/basic/014-expected.txt:
  • platform/qt/fast/block/basic/015-expected.png:
  • platform/qt/fast/block/basic/015-expected.txt:
  • platform/qt/fast/block/basic/016-expected.png:
  • platform/qt/fast/block/basic/016-expected.txt:
  • platform/qt/fast/block/basic/018-expected.png:
  • platform/qt/fast/block/basic/018-expected.txt:
  • platform/qt/fast/block/basic/019-expected.png:
  • platform/qt/fast/block/basic/019-expected.txt:
  • platform/qt/fast/block/basic/020-expected.txt:
  • platform/qt/fast/block/basic/021-expected.png:
  • platform/qt/fast/block/basic/021-expected.txt:
  • platform/qt/fast/block/basic/adding-near-anonymous-block-expected.png:
  • platform/qt/fast/block/basic/adding-near-anonymous-block-expected.txt:
  • platform/qt/fast/block/basic/minheight-expected.png:
  • platform/qt/fast/block/basic/minheight-expected.txt:
  • platform/qt/fast/block/basic/percent-height-inside-anonymous-block-expected.png:
  • platform/qt/fast/block/basic/percent-height-inside-anonymous-block-expected.txt:
  • platform/qt/fast/block/basic/quirk-height-expected.png:
  • platform/qt/fast/block/basic/quirk-height-expected.txt:
  • platform/qt/fast/block/basic/truncation-rtl-expected.png:
  • platform/qt/fast/block/basic/truncation-rtl-expected.txt:
  • platform/qt/fast/block/basic/white-space-pre-wraps-expected.png:
  • platform/qt/fast/block/basic/white-space-pre-wraps-expected.txt:
1:22 PM Changeset in webkit [123518] by thakis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium/mac] Add cursor resource pngs to the pak file.
https://bugs.webkit.org/show_bug.cgi?id=92148

Reviewed by Tony Chang.

Once https://chromiumcodereview.appspot.com/10817031/ has landed, they can be
removed from WebCore.gyp's mac_bundle_resources. Part of http://crbug.com/137588

  • WebKit.grd:
1:20 PM Changeset in webkit [123517] by caio.oliveira@openbossa.org
  • 19 edits
    2 deletes in trunk/LayoutTests

[Qt] svg/carto.net rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92152

Unreviewed.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/svg/carto.net/window-expected.png: Removed.
  • platform/qt-5.0/svg/carto.net/window-expected.txt: Removed.
  • platform/qt/svg/carto.net/button-expected.png:
  • platform/qt/svg/carto.net/button-expected.txt:
  • platform/qt/svg/carto.net/colourpicker-expected.png:
  • platform/qt/svg/carto.net/colourpicker-expected.txt:
  • platform/qt/svg/carto.net/scrollbar-expected.png:
  • platform/qt/svg/carto.net/scrollbar-expected.txt:
  • platform/qt/svg/carto.net/selectionlist-expected.png:
  • platform/qt/svg/carto.net/selectionlist-expected.txt:
  • platform/qt/svg/carto.net/slider-expected.png:
  • platform/qt/svg/carto.net/slider-expected.txt:
  • platform/qt/svg/carto.net/tabgroup-expected.png:
  • platform/qt/svg/carto.net/tabgroup-expected.txt:
  • platform/qt/svg/carto.net/textbox-expected.png:
  • platform/qt/svg/carto.net/textbox-expected.txt:
  • platform/qt/svg/carto.net/window-expected.png:
  • platform/qt/svg/carto.net/window-expected.txt:
1:17 PM Changeset in webkit [123516] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/Source/WebKit2

[Qt] Make sure that an AC sync is triggered when the canvas contents is updated.
https://bugs.webkit.org/show_bug.cgi?id=92128

Reviewed by Kenneth Rohde Christiansen.

This would cause missed frames when animating an accelerated 2D canvas without
touching the document.

  • WebProcess/WebPage/LayerTreeCoordinator/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::setContentsNeedsDisplay):

1:15 PM Changeset in webkit [123515] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

[Mac WK2] Improve text input logging
https://bugs.webkit.org/show_bug.cgi?id=92147

Reviewed by Andreas Kling.

  • UIProcess/API/mac/WKView.mm:

(-[WKView insertText:replacementRange:]):
(-[WKView keyUp:]):
(-[WKView keyDown:]):
(-[WKView flagsChanged:]):
(-[WKView _executeSavedKeypressCommands]):
(-[WKView _notifyInputContextAboutDiscardedComposition]):
(-[WKView _interpretKeyEvent:savingCommandsTo:WebCore::]):
(-[WKView _updateSecureInputState]):

1:11 PM Changeset in webkit [123514] by commit-queue@webkit.org
  • 20 edits
    3 adds in trunk/LayoutTests

[Qt] platform, plugins and printing need rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92016

Patch by Luciano Wolf <Luciano Miguel Wolf> on 2012-07-24
Reviewed by Alexis Menard.

Updating skipped tests inside platform, plugins and printing. The following tests
remain skipped:
/platform/qt/plugins/qt-qwidget-plugin.html (bug #92141)
/plugins/netscape-dom-access.html (already skipped inside qt/Skipped)

  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt/platform/qt/fast/forms/button-line-break-expected.png:
  • platform/qt/platform/qt/fast/forms/button-line-break-expected.txt:
  • platform/qt/platform/qt/plugins/application-plugin-plugins-disabled-expected.png: Added.
  • platform/qt/platform/qt/plugins/application-plugin-plugins-disabled-expected.txt: Added.
  • platform/qt/platform/qt/plugins/qt-qwidget-plugin-expected.png: Added.
  • platform/qt/platform/qt/plugins/qt-qwidget-plugin-expected.txt:
  • platform/qt/plugins/iframe-plugin-bgcolor-expected.txt:
  • platform/qt/plugins/mouse-click-plugin-clears-selection-expected.txt:
  • platform/qt/printing/compositing-layer-printing-expected.png:
  • platform/qt/printing/compositing-layer-printing-expected.txt:
  • platform/qt/printing/iframe-print-expected.png:
  • platform/qt/printing/iframe-print-expected.txt:
  • platform/qt/printing/media-queries-print-expected.png:
  • platform/qt/printing/media-queries-print-expected.txt:
  • platform/qt/printing/page-rule-in-media-query-expected.png:
  • platform/qt/printing/page-rule-in-media-query-expected.txt:
  • platform/qt/printing/simultaneous-position-float-change-expected.txt:
  • platform/qt/printing/width-overflow-expected.png:
  • platform/qt/printing/width-overflow-expected.txt:
1:04 PM Changeset in webkit [123513] by jchaffraix@webkit.org
  • 3 edits
    2 copies in branches/chromium/1180

Merge 123062 - Crash in RenderTableSection::addCell.
http://webkit.org/b/89496

Reviewed by Abhishek Arya.

Source/WebCore:

The issue comes from RenderBox::splitAnonymousBoxesAroundChild that would move sections
across tables but didn't force the table to do a synchronous section recalc. This opened
the way for race conditions where we would query the table column structure while it's dirty
(this is not uncommon but as usually the table's column representation is always bigger or
more split than a section's, it's usually harmless).

The fix is to force a synchronous section recalc.

Test: fast/table/split-table-no-section-update-crash.html

  • rendering/RenderBox.cpp:

(WebCore::markBoxForRelayoutAfterSplit):
Changed to call forceSectionsRecalc ie force a section recalc.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::recalcSections):
Added missing ASSERT for unneeded calls.

  • rendering/RenderTable.h:

(WebCore::RenderTable::forceSectionsRecalc):
Added this helper function.

LayoutTests:

The test is still pretty complex as it involves lots of generated content. It should
be possible to get a smaller test case based on the conditions for the crash. However
this test is a pretty good stress test so I decided against creating a more simple test
case.

  • fast/table/split-table-no-section-update-crash-expected.txt: Added.
  • fast/table/split-table-no-section-update-crash.html: Added.

TBR=jchaffraix@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10809080

12:59 PM Changeset in webkit [123512] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

Throttle calls to request the virtual keyboard be shown.
https://bugs.webkit.org/show_bug.cgi?id=92138

Reviewed by Rob Buis.

PR 178465.

Do not request keyboard visibility change when
we are actively processing an input event.

Reviewed Internally by Gen Mak.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::focusedNodeChanged):

12:48 PM Changeset in webkit [123511] by leandrogracia@chromium.org
  • 2 edits in trunk/Source/Platform

[Chromium] Enable conversion between WebFloatRect and gfx::RectF.
https://bugs.webkit.org/show_bug.cgi?id=92117

Reviewed by Adam Barth.

Introduce WebFloatRect <--> gfx::RectF conversion as we already do with WebRect <--> gfx::Rect.

  • chromium/public/WebFloatRect.h:

(WebKit::WebFloatRect::WebFloatRect):
(WebFloatRect):
(WebKit::WebFloatRect::operator=):
(WebKit::WebFloatRect::operator gfx::RectF):

12:47 PM Changeset in webkit [123510] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

REGRESSION(r123417): It made tests assert/crash on 32 bit
https://bugs.webkit.org/show_bug.cgi?id=92088

Reviewed by Mark Hahnenberg.

The pointer arithmetic was wrong, because negative numbers are hard to think about.

  • dfg/DFGRepatch.cpp:

(JSC::DFG::emitPutTransitionStub):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage):

12:45 PM Changeset in webkit [123509] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Provide more useful output when an injected bundle cannot be loaded
https://bugs.webkit.org/show_bug.cgi?id=92136

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-24
Reviewed by Kenneth Rohde Christiansen.

Call eina_error_get() in case an injected bundle cannot be
loaded in order to print more information about the error.

  • WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp:

(WebKit::InjectedBundle::load):

12:40 PM Changeset in webkit [123508] by fmalita@chromium.org
  • 1 edit
    2 copies in branches/chromium/1180

Merge 122755 - SVGAnimationElement::currentValuesForValuesAnimation crash
https://bugs.webkit.org/show_bug.cgi?id=91326

Reviewed by Simon Fraser.

SVGSMILElement::progress() assumes that seekToIntervalCorrespondingToTime() always
lands inside a defined interval, but one can force arbitrary time offsets using
setCurrentTime(). This patch adds logic for handling non-interval time offsets
gracefully.

Source/WebCore:

Test: svg/animations/smil-setcurrenttime-crash.svg

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::progress):

LayoutTests:

  • svg/animations/smil-setcurrenttime-crash-expected.txt: Added.
  • svg/animations/smil-setcurrenttime-crash.svg: Added.

TBR=fmalita@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10802091

12:40 PM Changeset in webkit [123507] by peter@chromium.org
  • 4 edits in trunk/Tools

Android-chromium layout tests failing with GPU related crash
https://bugs.webkit.org/show_bug.cgi?id=92126

Reviewed by Adam Barth.

Remove support for the "--enable-hardware-gpu" flag from run_webkit_tests,
as it's not being used by any port anymore, and neither is being passed
on to the test runner. Instead, append the flag directly to DRT for the
Chromium Android port, which does rely on this functionality.

The ChromiumAndroidUnitTest tests didn't catch this as the property was
set to True, but it's unable to detect whether they'll actually be used.
No occurrances of "--enable-hardware-gpu" exist in either Tools/Scripts/
or Tools/BuildSlaveSupport/, so nothing upstream seems to rely on the flag.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.init):

  • Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:

(ChromiumAndroidPortTest.test_attributes):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

12:32 PM Changeset in webkit [123506] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WTR][EFL] Multiple mouse clicks are not emitted in EventSenderProxyEfl
https://bugs.webkit.org/show_bug.cgi?id=92107

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-07-24
Reviewed by Kenneth Rohde Christiansen.

Fixes mouse click events in EventSenderProxyEfl.

  • WebKitTestRunner/efl/EventSenderProxyEfl.cpp:

(WTR::dispatchMouseDownEvent):
(WTR::EventSenderProxy::dispatchEvent):

12:25 PM Changeset in webkit [123505] by Patrick Gansterer
  • 10 edits in trunk/Source

Store the full year in GregorianDateTime
https://bugs.webkit.org/show_bug.cgi?id=92067

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Use the full year instead of the offset from year 1900
for the year member variable of GregorianDateTime.

  • runtime/DateConstructor.cpp:

(JSC::constructDate):
(JSC::dateUTC):

  • runtime/DateConversion.cpp:

(JSC::formatDate):
(JSC::formatDateUTCVariant):

  • runtime/DatePrototype.cpp:

(JSC::formatLocaleDate):
(JSC::fillStructuresUsingDateArgs):
(JSC::dateProtoFuncToISOString):
(JSC::dateProtoFuncGetFullYear):
(JSC::dateProtoFuncGetUTCFullYear):
(JSC::dateProtoFuncSetYear):

  • runtime/JSDateMath.cpp:

(JSC::gregorianDateTimeToMS):
(JSC::msToGregorianDateTime):

Source/WebCore:

Use the full year instead of the offset from year 1900
for the year member variable of GregorianDateTime.

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue):

  • bridge/qt/qt_runtime_qt4.cpp:

(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue):

Source/WTF:

Use the full year instead of the offset from year 1900
for the year member variable of GregorianDateTime.

  • wtf/GregorianDateTime.h:

(WTF::GregorianDateTime::operator tm):

12:12 PM Changeset in webkit [123504] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

Do not perform 8 to 16bits characters conversion when converting a WTFString to NSString/CFString
https://bugs.webkit.org/show_bug.cgi?id=90720

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-07-24
Reviewed by Geoffrey Garen.

In most String to CFString conversion, we should be able to use the "NoCopy" constructor and have
a relatively cheap conversion from WTF::String to CFString.

When the String is 8 bits, it was converted to 16 bits by getData16SlowCase() because of the call
to String::characters().

This patch adds a path for creating a CFString from a 8bits string using CFStringCreateWithBytes.

This is covered by existing tests.

  • platform/text/cf/StringCF.cpp:

(WTF::String::createCFString): CFSTR() create static CFString, it is unecessary to retain it.

  • platform/text/cf/StringImplCF.cpp:

(WTF::StringImpl::createCFString): The logic to avoid the StringWrapperCFAllocator has also been simplified.
The allocator creation is now closer to where it is useful.

12:03 PM Changeset in webkit [123503] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

[WIN] Build fix after r123417.

11:55 AM Changeset in webkit [123502] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Re-skip failing tests for Qt 4.8 platform
https://bugs.webkit.org/show_bug.cgi?id=92119

Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2012-07-24
Reviewed by Alexis Menard.

The following tests, after unskipping, are now passing on Qt-5.0 build bot
variations, but still failing for Qt-4.8 ones:

Regressions: Unexpected text diff mismatch : (1)

http/tests/misc/acid3.html = TEXT

Regressions: Unexpected image mismatch : (2)

fast/css/tab-size.html = IMAGE
fast/text/international/bdi-dir-default-to-auto.html = IMAGE

This patch adds these to Skipped list of qt-4.8 platform.

  • platform/qt-4.8/Skipped: Added 3 layout tests.
11:43 AM Changeset in webkit [123501] by kareng@chromium.org
  • 1 edit in branches/chromium/1180/Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzFaceCoreText.cpp

Merge 121510 - [Chromium] CTFontCopyTable of MacOSX10.5 SDK doesn't work for layout tables
https://bugs.webkit.org/show_bug.cgi?id=90235

Reviewed by Kent Tamura.

Use CGFontCopyTableForTag instead.

No new tests. css3/font-feature-settings-rendering.html should pass. I'll rebase expectations once bots get the result.

  • platform/graphics/harfbuzz/ng/HarfBuzzFaceCoreText.cpp:

(WebCore::harfbuzzCoreTextGetTable):

TBR=bashi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10815078

11:42 AM Changeset in webkit [123500] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] String wrappers should be marked Independent
https://bugs.webkit.org/show_bug.cgi?id=91251

Reviewed by Adam Barth.

Currently V8 String wrappers are not marked Independent.
By marking them Independent, they can be reclaimed by the scavenger GC.
Although I couldn't find a case where this change reduces memory usage,
this change would be important for upcoming changes in string conversion
between V8 and WebKit (https://bugs.webkit.org/show_bug.cgi?id=91850).

'm_lastStringImpl = 0' in StringCache::remove() is important.
Look at the following code:

static void cachedStringCallback(v8::Persistent<v8::Value> wrapper, void* parameter)
{

...;
stringCache()->remove(stringImpl);
wrapper.Dispose();

}

void StringCache::remove(StringImpl* stringImpl)
{

...
if (m_lastStringImpl.get() == stringImpl)

m_lastStringImpl = 0;

}

v8::Local<v8::String> v8ExternalString(StringImpl* stringImpl, v8::Isolate* isolate)
{

if (m_lastStringImpl.get() == stringImpl) {

return v8::Local<v8::String>::New(m_lastV8String); m_lastV8String points to a wrapper object that was accessed most recently.

}
return v8ExternalStringSlow(stringImpl, isolate);

}

Without 'm_lastStringImpl = 0', already disposed m_lastV8String can be used
in v8ExternalString(). This was a cause of the crashes of r122614.

Tests: At the initial commit of this patch (r122614),

the following tests had been broken due to missing 'm_lastStringImpl = 0'.
fast/workers/worker-location.html
Dromaeo/cssquery-jquery.html
Dromaeo/jslib-event-jquery.html
Dromaeo/jslib-style-jquery.html
Dromaeo/jslib-style-prototype.html

  • bindings/v8/V8Binding.cpp:

(WebCore::StringCache::remove):
(WebCore::StringCache::v8ExternalStringSlow):

11:33 AM Changeset in webkit [123499] by tommyw@google.com
  • 22 edits
    2 copies
    3 adds in trunk

MediaStream API: Update MediaStreamTrack to match the specification
https://bugs.webkit.org/show_bug.cgi?id=90180

Reviewed by Adam Barth.

Source/Platform:

  • chromium/public/WebMediaStreamDescriptor.h:

(WebMediaStreamDescriptor):

  • chromium/public/WebMediaStreamSource.h:

(WebMediaStreamSource):

Source/WebCore:

MediaStreamTracks are now required to show the status of the underlying source,
and trigger events when that status changes.

Test: fast/mediastream/MediaStreamTrack.html

  • GNUmakefile.list.am:
  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::addTrack):

  • Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::create):
(WebCore::MediaStreamTrack::MediaStreamTrack):
(WebCore::MediaStreamTrack::~MediaStreamTrack):
(WebCore::MediaStreamTrack::setEnabled):
(WebCore::MediaStreamTrack::readyState):
(WebCore):
(WebCore::MediaStreamTrack::sourceChangedState):
(WebCore::MediaStreamTrack::stop):
(WebCore::MediaStreamTrack::interfaceName):
(WebCore::MediaStreamTrack::scriptExecutionContext):
(WebCore::MediaStreamTrack::eventTargetData):
(WebCore::MediaStreamTrack::ensureEventTargetData):

  • Modules/mediastream/MediaStreamTrack.h:
  • Modules/mediastream/MediaStreamTrack.idl:
  • WebCore.gypi:
  • dom/EventNames.h:

(WebCore):

  • dom/EventTargetFactory.in:
  • platform/chromium/support/WebMediaStreamDescriptor.cpp:
  • platform/chromium/support/WebMediaStreamSource.cpp:

(WebKit::WebMediaStreamSource::setReadyState):
(WebKit):
(WebKit::WebMediaStreamSource::readyState):

  • platform/mediastream/MediaStreamSource.cpp: Copied from Source/WebCore/platform/mediastream/MediaStreamSource.h.

(WebCore):
(WebCore::MediaStreamSource::create):
(WebCore::MediaStreamSource::MediaStreamSource):
(WebCore::MediaStreamSource::setReadyState):
(WebCore::MediaStreamSource::addObserver):
(WebCore::MediaStreamSource::removeObserver):

  • platform/mediastream/MediaStreamSource.h:

(Observer):
(WebCore::MediaStreamSource::Observer::~Observer):
(MediaStreamSource):
(WebCore::MediaStreamSource::readyState):

  • platform/mediastream/chromium/MediaStreamCenterChromium.cpp:

(WebCore::MediaStreamCenterChromium::queryMediaStreamSources):
(WebCore::MediaStreamCenterChromium::didCreateMediaStream):

Tools:

Adding a Mock WebMediaStreamCenter to enable better LayoutTests.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:

(MockWebKitPlatformSupport::createMediaStreamCenter):

  • DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp: Added.

(WebKit):
(WebKit::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
(WebKit::MockWebMediaStreamCenter::queryMediaStreamSources):
(WebKit::MockWebMediaStreamCenter::didEnableMediaStreamTrack):
(WebKit::MockWebMediaStreamCenter::didDisableMediaStreamTrack):
(WebKit::MockWebMediaStreamCenter::didStopLocalMediaStream):
(WebKit::MockWebMediaStreamCenter::didCreateMediaStream):
(WebKit::MockWebMediaStreamCenter::constructSDP):

  • DumpRenderTree/chromium/MockWebMediaStreamCenter.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp.

(WebKit):
(MockWebMediaStreamCenter):
(WebKit::MockWebMediaStreamCenter::MockWebMediaStreamCenter):

LayoutTests:

  • fast/mediastream/MediaStreamTrack-expected.txt: Added.
  • fast/mediastream/MediaStreamTrack.html: Added.
11:30 AM Changeset in webkit [123498] by rniwa@webkit.org
  • 4 edits in trunk/Tools

Fix regressions in replay performance tests
https://bugs.webkit.org/show_bug.cgi?id=92052

Reviewed by Dirk Pranke.

Fix regression that accumulated over time to make replay tests work again.

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::willSendRequest): Use the main document URL in the request since the main frame's
URL hadn't been updated yet When requesting a new URL on the main frame.

  • Scripts/webkitpy/performance_tests/perftest.py:

(ReplayServer.wait_until_ready): Waiting for 6 seconds (3 tries) seems enough.
(ReplayPerfTest.prepare): Pass self._archive_path to run_signle as that is the current contract.
(ReplayPerfTest.run_single): Use the archive path to generate -expected.png path.

  • Scripts/webkitpy/performance_tests/perftest_unittest.py:

(TestReplayPerfTest.test_run_single):
(TestReplayPerfTest.test_prepare):
(TestReplayPerfTest.test_prepare_calls_run_single.run_single):
(TestReplayPerfTest):

11:25 AM Changeset in webkit [123497] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed expectations change for chromium to address lint error from r90190.

  • platform/chromium/TestExpectations:
11:23 AM Changeset in webkit [123496] by tony@chromium.org
  • 5 edits in trunk/Source/WebCore

Use native (non-cygwin) binaries for perl, gperf, and bison in Chromium
https://bugs.webkit.org/show_bug.cgi?id=91667

Patch by Scott Graham <scottmg@chromium.org> on 2012-07-24
Reviewed by Tony Chang.

Using native tools instead of cygwin version improves build time
performance by roughly 50% (on top of previous cl-instead-of-gcc
change).

Also, use - instead of / for cl flags, otherwise preprocessing fails
very slowly (due to retry loop). And, replace \ with / in gperf
command line. Without this, gperf emits the filename literally in
#line directives which causes VS to error with "unescaped \ in
string". Bizarrely, building ColorData.cpp with those \ in place
causes the IDE to exit with no error message, which was the cause of
the previous canary failures.