Timeline



Sep 15, 2012:

11:20 PM Changeset in webkit [128705] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Following the Butterfly refactoring, the comment for lastArraySize was not updated
https://bugs.webkit.org/show_bug.cgi?id=96877

Reviewed by Sam Weinig.

  • runtime/JSObject.cpp:

(JSC):

11:08 PM Changeset in webkit [128704] by mark.lam@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Fixed JSLock to use the platform abstraction for Mutex instead of
depending on pthreads.
https://bugs.webkit.org/show_bug.cgi?id=96858.

Reviewed by Filip Pizlo.

This fixes a synchronization problem on the Windows port and makes
it more reliable when running the layout tests.

  • runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

  • runtime/JSLock.cpp:

(JSC):
(JSC::GlobalJSLock::GlobalJSLock):
(JSC::GlobalJSLock::~GlobalJSLock):
(JSC::GlobalJSLock::initialize):

  • runtime/JSLock.h:

(GlobalJSLock):
(JSLock):

10:17 PM Changeset in webkit [128703] by commit-queue@webkit.org
  • 12 edits
    10 adds in trunk

Source/WebCore: Pause inspector when inline scripts are blocked by Content Security Policy.
https://bugs.webkit.org/show_bug.cgi?id=93865

Patch by Mike West <mkwst@chromium.org> on 2012-09-15
Reviewed by Pavel Feldman.

When Content Security Policy blocks an inline script that's been
injected after the document is parsed, a fairly unhelpful console
warning is generated; it points at line 1, regardless of where the error
occurred. This patch adjusts CSP to not only warn on the console, but
also to notify the inspector that it should pause execution if the
developer has toggled "Break on Exceptions". Developers will have a
better chance of tracking down the error, as they'll have a complete
call stack to work with.

Tests: inspector/debugger/debugger-pause-on-blocked-event-handler.html

inspector/debugger/debugger-pause-on-blocked-script-injection.html
inspector/debugger/debugger-pause-on-blocked-script-url.html

  • English.lproj/localizedStrings.js:

Adding localizable string for the new friendly pause message.

  • inspector/Inspector.json:

Add CSPViolation as a recognized reason for pausing execution.

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::scriptExecutionBlockedByCSP):

Teach the InspectorDebuggerAgent about script blocking. If pause on
exceptions is enabled, call 'InspectorDebuggerAgent::breakProgram',
and pass in an error object with a description that points to CSP
as the culprit.

(WebCore):

  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::scriptExecutionBlockedByCSPImpl):

Wire 'InspectorInstrumentation::scriptExecutionBlockedByCSP' to
the InspectorDebuggerAgent backend.

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::scriptExecutionBlockedByCSP):

The public interface that should be kicked whenever CSP blocks
script execution.

(WebCore):

  • inspector/front-end/DebuggerModel.js:

Add CSPViolation as a recognized reason for pausing execution.

  • inspector/front-end/ScriptsPanel.js:

Add a friendly call stack status message for CSP violations.

  • page/ContentSecurityPolicy.cpp:

(CSPDirectiveList):
(WebCore::CSPDirectiveList::checkNonceAndReportViolation):

If script is blocked because the nonce doesn't match, report the
blocked script to the inspector.

(WebCore::CSPDirectiveList::checkInlineAndReportViolation):

If inline script is blocked, report the blocked script to the
inspector. This requires adding a bool parameter to differentiate
blocking inline script from inline style.

(WebCore::CSPDirectiveList::allowJavaScriptURLs):

Tell 'checkInlineAndReportViolation' that we're dealing with script.

(WebCore::CSPDirectiveList::allowInlineEventHandlers):

Tell 'checkInlineAndReportViolation' that we're dealing with script.

(WebCore::CSPDirectiveList::allowInlineScript):

Tell 'checkInlineAndReportViolation' that we're dealing with script.

(WebCore::CSPDirectiveList::allowInlineStyle):

Tell 'checkInlineAndReportViolation' that we're not dealing with script.

(WebCore::ContentSecurityPolicy::reportBlockedScriptExecutionToInspector):

Public interface for the various CSP* classes to poke the inspector.

(WebCore):

  • page/ContentSecurityPolicy.h:

LayoutTests: Break on inline scripts blocked by CSP.
https://bugs.webkit.org/show_bug.cgi?id=93865

Patch by Mike West <mkwst@chromium.org> on 2012-09-15
Reviewed by Pavel Feldman.

  • inspector/debugger/debugger-pause-on-blocked-event-handler-expected.txt: Added.
  • inspector/debugger/debugger-pause-on-blocked-event-handler.html: Added.
  • inspector/debugger/debugger-pause-on-blocked-script-injection-expected.txt: Added.
  • inspector/debugger/debugger-pause-on-blocked-script-injection.html: Added.
  • inspector/debugger/debugger-pause-on-blocked-script-url-expected.txt: Added.
  • inspector/debugger/debugger-pause-on-blocked-script-url.html: Added.
  • inspector/debugger/resources/pause-on-blocked-by-csp.js: Added.

(test.setStatus):
(test.step1):
(test.step2):
(test):

  • inspector/debugger/resources/pause-on-blocked-event-handler.js: Added.

(testAction):

  • inspector/debugger/resources/pause-on-blocked-script-injection.js: Added.

(testAction):

  • inspector/debugger/resources/pause-on-blocked-script-url.js: Added.

(testAction):

10:03 PM Changeset in webkit [128702] by fmalita@chromium.org
  • 3 edits
    2 adds in trunk

<use> not working when the SVG doc is embedded as <object> data
https://bugs.webkit.org/show_bug.cgi?id=96816

Reviewed by Dirk Schulze.

Source/WebCore:

Updated SVGURIReference::isExternalURIReference() to correctly classify fragment-only URIs.
Also, since the fragment-only test is cheap, it should be the first thing to try.

Test: svg/custom/object-data-href.html

  • svg/SVGURIReference.h:

(WebCore::SVGURIReference::isExternalURIReference):

LayoutTests:

  • svg/custom/object-data-href-expected.html: Added.
  • svg/custom/object-data-href.html: Added.
9:34 PM Changeset in webkit [128701] by benjamin@webkit.org
  • 9 edits in trunk/Source

Fix the build with WTF URL
https://bugs.webkit.org/show_bug.cgi?id=96875

Reviewed by Adam Barth.

Source/WebCore:

Fix reportMemoryUsage, the implementation was only partial.

  • WebCore.exp.in: Export two more symbols as needed by API tests.
  • platform/KURLWTFURL.cpp:

(WebCore::KURL::string): emptyString() return a reference,
it makes more sense than nullAtom() here.

  • platform/KURLWTFURLImpl.h:

(WebCore::KURLWTFURLImpl::reportMemoryUsage):

Source/WTF:

Add support for MemoryInstrumentation to WTF's URL classes.

  • wtf/url/api/ParsedURL.cpp:

(WTF::ParsedURL::reportMemoryUsage):

  • wtf/url/api/ParsedURL.h:

(ParsedURL):

  • wtf/url/api/URLString.cpp:

(WTF::URLString::reportMemoryUsage):

  • wtf/url/api/URLString.h:

(URLString):

9:24 PM Changeset in webkit [128700] by krit@webkit.org
  • 11 edits
    1 add in trunk/Source/WebCore

Add ClipPathOperation for -webkit-clip-path organization
https://bugs.webkit.org/show_bug.cgi?id=95619

Reviewed by Dean Jackson.

This patch adds a new class ClipPathOperation to manage the values of the
-webkit-clip-path property. ClipPathOperation stores a Path object for clipping and is
a preparation for IRI references of the SVG 'clipPath' element.

The structure of ClipPathOperation is simular to FilterOperation.

ClipPathOperation will be extended to support IRI references directly in a second patch.

No new tests. The changes just affect the backend.

  • GNUmakefile.list.am: Added new ClipPathOperation class.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • css/CSSComputedStyleDeclaration.cpp: Use ClipPathOperation instead of BasicShape.

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Ditto.

  • css/StyleBuilder.cpp: Ditto.

(WebCore):
(WebCore::ApplyPropertyClipPath::setValue):
(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyClipPath::createHandler):

  • rendering/ClipPathOperation.h: Added. New handler for property values (BasicShape, references).

(WebCore):
(ClipPathOperation):
(WebCore::ClipPathOperation::~ClipPathOperation):
(WebCore::ClipPathOperation::operator!=):
(WebCore::ClipPathOperation::getOperationType): Return the operation type.
(WebCore::ClipPathOperation::isSameType): Helper function for =operator.
(WebCore::ClipPathOperation::ClipPathOperation):
(ShapeClipPathOperation): Inheriting class for managing BasicShapes.
(WebCore::ShapeClipPathOperation::create):
(WebCore::ShapeClipPathOperation::basicShape):
(WebCore::ShapeClipPathOperation::windRule):
(WebCore::ShapeClipPathOperation::path):
(WebCore::ShapeClipPathOperation::operator==):
(WebCore::ShapeClipPathOperation::ShapeClipPathOperation):

  • rendering/RenderLayer.cpp: Use ClipPathOperation to apply clipping.

(WebCore::RenderLayer::paintLayerContents):

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleRareNonInheritedData.h:

(StyleRareNonInheritedData):

  • rendering/svg/SVGRenderingContext.cpp: Ditto.

(WebCore::SVGRenderingContext::prepareToRenderSVGContent):

7:36 PM Changeset in webkit [128699] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Structure check hoisting fails to consider the possibility of conflicting checks on the source of the first assignment to the hoisted variable
https://bugs.webkit.org/show_bug.cgi?id=96872

Reviewed by Oliver Hunt.

This does a few related things:

  • It turns off the use of ForceOSRExit for sure-to-fail CheckStructures, because I noticed that this would sometimes happen for a ForwardCheckStructure. The problem is that ForceOSRExit exits backwards, not forwards. Since the code that led to those ForceOSRExit's being inserted was written out of paranoia rather than need, I removed it. Specifically, I removed the m_isValid = false code for CheckStructure/StructureTransitionWatchpoint in AbstractState.


  • If a structure check causes a structure set to go empty, we don't want a PutStructure to revive the set. It should instead be smart enough to realize that an empty set implies that the code can't execute. This was the only "bug" that the use of m_isValid = false was preventing.


  • Finally, the main change: structure check hoisting looks at the source of the SetLocals on structure-check-hoistable variables and ensures that the source is not checked with a conflicting structure. This is O(n2) but it does not show up at all in performance tests.


The first two parts of this change were auxiliary bugs that were revealed by
the structure check hoister doing bad things.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::execute):

  • dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):

4:31 PM Changeset in webkit [128698] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

WinCairo build fix due to missing symbols for setImagesEnabled and setStorageBlockingPolicy
https://bugs.webkit.org/show_bug.cgi?id=96866

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-09-15
Reviewed by Kentaro Hara.

Adding missing symbol defines in the def file to fix the build break
for WinCairo

  • win/WebKit2CFLite.def:
4:16 PM Changeset in webkit [128697] by kling@webkit.org
  • 6 edits
    2 adds in trunk

REGRESSION(r127438): Google Docs to renders text too small.
<http://webkit.org/b/96554>

Reviewed by Antti Koivisto.

Source/WebCore:

Don't remove the inline StylePropertySet from ElementAttributeData in ~StyledElement.
This behavior broke sharing of ElementAttributeData between elements with inline style,
since destroying one element would effectively disable the inline style from all other
elements that shared the same attribute data.

What we actually want in ~StyledElement is to detach from any CSSOM wrapper that may
have been instantiated. Added ElementAttributeData::detachCSSOMWrapperIfNeeded for this
purpose and call that instead.

Test: fast/dom/shared-inline-style-after-node-removal.html

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::detachCSSOMWrapperIfNeeded):
(WebCore::ElementAttributeData::destroyInlineStyle):

  • dom/ElementAttributeData.h:

(ElementAttributeData):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::~StyledElement):
(WebCore::StyledElement::styleAttributeChanged):

  • dom/StyledElement.h:

(StyledElement):

LayoutTests:

Add a test that an element that shared its inline style with another element works as expected
after the other element is destroyed.

  • fast/dom/shared-inline-style-after-node-removal-expected.txt: Added.
  • fast/dom/shared-inline-style-after-node-removal.html: Added.
3:59 PM Changeset in webkit [128696] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Include missing header files in the tarball
https://bugs.webkit.org/show_bug.cgi?id=96860

Patch by Kalev Lember <kalevlember@gmail.com> on 2012-09-15
Reviewed by Kentaro Hara.

Build fix; dist two additional headers that are needed for building on
Windows platform.

  • GNUmakefile.list.am:
3:48 PM Changeset in webkit [128695] by rakuco@webkit.org
  • 2 edits in trunk/Source/WTF

llint: Implement LOCAL_LABEL_STRING for the BSD platforms.
https://bugs.webkit.org/show_bug.cgi?id=96870

Patch by Raphael Kubo da Costa <rakuco@FreeBSD.org> on 2012-09-15
Reviewed by Filip Pizlo.

  • wtf/InlineASM.h: Extend the definition of LOCAL_LABEL_STRING

currently used for OS(LINUX) to the BSDs, since they also normally
use GNU as, and clang/llvm seems to parse that syntax just fine as
well.

3:48 PM Changeset in webkit [128694] by msaboff@apple.com
  • 3 edits in trunk/Source/WebCore

Add 8 bit handling to SpaceSplitString
https://bugs.webkit.org/show_bug.cgi?id=96823

Reviewed by Sam Weinig.

Added templated functions based on character type to handle 8 and 16 bit string data.

  • dom/SpaceSplitString.cpp:

(WebCore::hasNonASCIIOrUpper):
(WebCore::SpaceSplitStringData::createVector):

  • dom/SpaceSplitString.h:

(SpaceSplitStringData):

3:26 PM Changeset in webkit [128693] by mitz@apple.com
  • 6 edits
    2 adds in trunk

REGRESSION (r125578): The monospace code path in RenderText::widthFromCache disagrees with Font::width on word spacing
https://bugs.webkit.org/show_bug.cgi?id=96869

Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/text/word-space-monospace.html
This also fixes fast/css/word-spacing-characters.html

  • rendering/RenderText.cpp:

(WebCore::RenderText::widthFromCache): Made the conditions for adding word spacing match the
ones in WidthIterator.

LayoutTests:

  • fast/text/word-space-monospace-expected.html: Added.
  • fast/text/word-space-monospace.html: Added.
  • platform/mac/TestExpectations: Removed fast/css/word-spacing-characters.html.
  • platform/mac/fast/css/word-space-extra-expected.png: Updated.
  • platform/mac/fast/css/word-space-extra-expected.txt: Updated.
12:20 PM Changeset in webkit [128692] by mitz@apple.com
  • 7 edits in trunk

REGRESSION (r125578): Word spacing not applied to newline and tab characters that are treated as spaces
https://bugs.webkit.org/show_bug.cgi?id=96865

Reviewed by Sam Weinig.

Source/WebCore:

Fixes fast/css/word-space-extra.html.

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::advanceInternal): Changed back to apply word spacing to all characters
that are treated as spaces, except for tab characters when there are tab stops.

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::adjustGlyphsAndAdvances): Ditto.

LayoutTests:

  • fast/text/atsui-negative-spacing-features.html: Reverted changes made in r128691, now that

both code paths handle newlines correctly.

  • fast/text/atsui-spacing-features.html: Ditto.
  • platform/mac/TestExpectations: Removed fast/css/word-space-extra.html.
9:27 AM Changeset in webkit [128691] by mitz@apple.com
  • 6 edits in trunk

REGRESSION (r125578): The Mac complex text code path disagrees with the fast path on word spacing
https://bugs.webkit.org/show_bug.cgi?id=96857

Reviewed by Anders Carlsson.

Source/WebCore:

Fixes the following tests when run with run-webkit-tests --complex-text:
css2.1/20110323/c541-word-sp-001.htm
css2.1/20110323/word-spacing-remove-space-002.htm
css2.1/20110323/word-spacing-remove-space-003.htm
css2.1/20110323/word-spacing-remove-space-004.htm
css2.1/20110323/word-spacing-remove-space-005.htm
css2.1/20110323/word-spacing-remove-space-006.htm

Fixes fast/css/word-spacing-characters-complex-text.html

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::adjustGlyphsAndAdvances): Made the conditions for adding
word spacing match the ones in WidthIterator again.

LayoutTests:

  • fast/text/atsui-negative-spacing-features.html: Removed some newlines from this test,

because now that the complex text code path matches the fast path, it too suffers from a bug
where word spacing is not added at a newline.

  • fast/text/atsui-spacing-features.html: Ditto.
  • platform/mac/TestExpectations: Removed fast/css/word-spacing-characters-complex-text.html.
8:15 AM Changeset in webkit [128690] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit2

[EFL][WK2] Provide implementation for PageClientImpl::processDidCrash()
https://bugs.webkit.org/show_bug.cgi?id=96197

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-09-15
Reviewed by Gyuyoung Kim.

WebKit2 EFL does not have an implementation for PageClientImpl::processDidCrash().
So when WebProcess has crashed, UI process does nothing and is left alone as it is.

This patch checks if loading was ongoing, if so, set the load progress as 1.
Then send a signal callback "webprocess,crashed" for an application to handle it.
If the application does not handle the crash event, show an Eina Log warning message
with a url at web process exit and load an error page.

  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::processDidCrash):

  • UIProcess/API/efl/ewk_private.h:
  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_webprocess_crashed):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/ewk_view_private.h:
2:02 AM Changeset in webkit [128689] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update test expectation

  • platform/chromium/TestExpectations:

Don't run an inspector test on Mac.

2:00 AM Changeset in webkit [128688] by pierre.rossi@gmail.com
  • 6 edits in trunk/Source

[Qt] QDoc fixes for Qt 5 documentation
https://bugs.webkit.org/show_bug.cgi?id=96796

Reviewed by Simon Hausmann.

Source/WebKit/qt:

Produce fewer warnings and a better documentation.
Having two QML modules providing a WebView component is a bit too much for poor old qdoc to
cope with (or would require a lot of painful disambiguation by hand). Since the plan is to have
QDeclarativeWebView living in the qtquick1 module, we can already take it out of the
documentation generation for now.

  • declarative/qdeclarativewebview.cpp: s/qmlclass/qmltype/ out of principle
  • docs/qtwebkit.qdocconf: Remove the \i alias that caused a warning. Use *.h as headers suffix, not sources.

Also remove QDeclarativeWebView from the documentation.

Source/WebKit2:

Fixup miscellaneous qdoc commands syntax.

  • UIProcess/API/qt/qquickwebview.cpp:
  • UIProcess/API/qt/qwebloadrequest.cpp:
1:55 AM Changeset in webkit [128687] by tkent@chromium.org
  • 13 edits in trunk/Source/WebCore

Unreviewed, rolling out r128669.
http://trac.webkit.org/changeset/128669
https://bugs.webkit.org/show_bug.cgi?id=96637

Broke http/tests/workers/text-encoding.html on Chromium Linux (dbg)

  • bindings/v8/DOMData.cpp:

(WebCore::DOMData::getCurrentStore):

  • bindings/v8/ScopedPersistent.h:
  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::resetIsolatedWorlds):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::currentWorldContext):

  • bindings/v8/V8Binding.cpp:

(WebCore::perContextDataForCurrentWorld):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::setIsolatedWorldField):
(WebCore::V8DOMWindowShell::enteredIsolatedWorldContext):
(WebCore::V8DOMWindowShell::destroyIsolatedShell):
(WebCore):
(WebCore::isolatedContextWeakCallback):
(WebCore::V8DOMWindowShell::disposeContext):
(WebCore::V8DOMWindowShell::initializeIfNeeded):
(WebCore::V8DOMWindowShell::setIsolatedWorldSecurityOrigin):

  • bindings/v8/V8DOMWindowShell.h:

(V8DOMWindowShell):
(WebCore::V8DOMWindowShell::getEntered):

  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getCachedWrapper):

  • bindings/v8/WorldContextHandle.cpp:

(WebCore::WorldContextHandle::WorldContextHandle):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8SVGDocumentCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:

(WebCore::V8XMLHttpRequest::constructorCallback):

1:23 AM Changeset in webkit [128686] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed weekend gardening. Skip 4 new failing tests to paint the bot green.

  • platform/qt-5.0-wk2/Skipped:
1:01 AM Changeset in webkit [128685] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed weekend gardening. Skip 2 new tests, because
TestRunner::overridePreference() does not support the 'WebKitDisplayImagesKey' preference

  • platform/qt/Skipped:
12:01 AM Changeset in webkit [128684] by mrowe@apple.com
  • 2 edits in trunk/Source/WTF

Roll out r128682 since it broke the Mac release builds.

Sep 14, 2012:

11:14 PM Changeset in webkit [128683] by gyuyoung.kim@samsung.com
  • 19 edits in trunk/Source/WebKit2

Add *explicit* keyword to constructors to WebKit2/UIProcess
https://bugs.webkit.org/show_bug.cgi?id=96732

Reviewed by Kentaro Hara.

As a step of *explicit* cleanup for constructors which have only one parameter,
*explicit* is added to WebKit2/UIProcess in order to avoid implicit type conversion.

  • UIProcess/Authentication/AuthenticationDecisionListener.h:

(AuthenticationDecisionListener):

  • UIProcess/Authentication/WebCredential.h:

(WebCredential):

  • UIProcess/Authentication/WebProtectionSpace.h:

(WebProtectionSpace):

  • UIProcess/GenericCallback.h:

(WebKit::CallbackBase::CallbackBase):

  • UIProcess/InspectorServer/WebSocketServer.h:
  • UIProcess/ResponsivenessTimer.h:

(ResponsivenessTimer):

  • UIProcess/WebApplicationCacheManagerProxy.h:

(WebApplicationCacheManagerProxy):

  • UIProcess/WebBackForwardList.h:

(WebBackForwardList):

  • UIProcess/WebContextUserMessageCoders.h:

(WebKit::WebContextUserMessageEncoder::WebContextUserMessageEncoder):

  • UIProcess/WebFullScreenManagerProxy.h:

(WebFullScreenManagerProxy):

  • UIProcess/WebGrammarDetail.h:

(WebGrammarDetail):

  • UIProcess/WebInspectorProxy.h:

(WebInspectorProxy):

  • UIProcess/WebKeyValueStorageManagerProxy.h:

(WebKeyValueStorageManagerProxy):

  • UIProcess/WebMediaCacheManagerProxy.h:

(WebMediaCacheManagerProxy):

  • UIProcess/WebNavigationData.h:

(WebNavigationData):

  • UIProcess/WebOpenPanelResultListenerProxy.h:

(WebOpenPanelResultListenerProxy):

  • UIProcess/WebPopupMenuProxy.h:

(WebKit::WebPopupMenuProxy::WebPopupMenuProxy):

  • UIProcess/WebPreferences.h:

(WebPreferences):

9:36 PM Changeset in webkit [128682] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

WTFString::show doesn't dump non-ASCII characters in a readable manner
https://bugs.webkit.org/show_bug.cgi?id=96749

Patch by Glenn Adams <glenn@skynav.com> on 2012-09-14
Reviewed by Benjamin Poulain.

Dump non-ASCII characters in a useful form for debugging.

  • wtf/text/WTFString.cpp:

(asciiDebug):
Dump non-ASCII characters (i.e., UTF-16 code elements) as well as non-printable ASCII characters
using \uXXXX format.

9:18 PM Changeset in webkit [128681] by jamesr@google.com
  • 1 edit
    9 moves
    16 deletes in trunk/LayoutTests

Unreviewed gardening - more position:fixed stacking context rebaselines.

  • fast/block/positioning/016-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/block/positioning/016-expected.txt.
  • fast/block/positioning/025-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/block/positioning/025-expected.txt.
  • platform/chromium-linux/compositing/geometry/fixed-position-composited-switch-expected.txt: Removed.
  • platform/chromium-linux/fast/block/positioning/fixed-position-stacking-context-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-composited-switch-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/block/positioning/016-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/block/positioning/025-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/block/positioning/fixed-position-stacking-context-expected.txt: Removed.
  • platform/chromium-mac/compositing/geometry/fixed-position-composited-switch-expected.txt: Removed.
  • platform/chromium-mac/fast/block/positioning/016-expected.txt: Removed.
  • platform/chromium-mac/fast/block/positioning/025-expected.txt: Removed.
  • platform/chromium-mac/fast/block/positioning/fixed-position-stacking-context-expected.txt: Removed.
  • platform/chromium-win/fast/block/positioning/016-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/block/positioning/016-expected.png.
  • platform/chromium-win/fast/block/positioning/025-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/block/positioning/025-expected.png.
  • platform/chromium-win/fast/block/positioning/fixed-position-stacking-context-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/block/positioning/fixed-position-stacking-context-expected.png.
  • platform/chromium/compositing/geometry/fixed-position-composited-switch-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/compositing/geometry/fixed-position-composited-switch-expected.txt.
  • platform/chromium/fast/block/positioning/016-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/block/positioning/016-expected.txt.
  • platform/chromium/fast/block/positioning/025-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/block/positioning/025-expected.txt.
  • platform/chromium/fast/block/positioning/fixed-position-stacking-context-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/block/positioning/fixed-position-stacking-context-expected.txt.
  • platform/efl/fast/block/positioning/016-expected.txt: Removed.
  • platform/efl/fast/block/positioning/025-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/016-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/025-expected.txt: Removed.
  • platform/qt/fast/block/positioning/016-expected.txt: Removed.
  • platform/qt/fast/block/positioning/025-expected.txt: Removed.
8:29 PM Changeset in webkit [128680] by fpizlo@apple.com
  • 9 edits
    1 delete in trunk/Source/JavaScriptCore

All of the things in SparseArrayValueMap should be out-of-line
https://bugs.webkit.org/show_bug.cgi?id=96854

Reviewed by Andy Estes.

Those inline methods were buying us nothing.

  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/JSArray.cpp:
  • runtime/JSGlobalData.cpp:
  • runtime/JSObject.cpp:
  • runtime/RegExpMatchesArray.cpp:
  • runtime/SparseArrayValueMap.cpp:

(JSC::SparseArrayValueMap::SparseArrayValueMap):
(JSC):
(JSC::SparseArrayValueMap::~SparseArrayValueMap):
(JSC::SparseArrayValueMap::finishCreation):
(JSC::SparseArrayValueMap::create):
(JSC::SparseArrayValueMap::destroy):
(JSC::SparseArrayValueMap::createStructure):
(JSC::SparseArrayValueMap::add):
(JSC::SparseArrayValueMap::putEntry):
(JSC::SparseArrayValueMap::putDirect):
(JSC::SparseArrayEntry::get):
(JSC::SparseArrayEntry::getNonSparseMode):
(JSC::SparseArrayValueMap::visitChildren):

  • runtime/SparseArrayValueMapInlineMethods.h: Removed.
6:43 PM Changeset in webkit [128679] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebCore

Unreviewed, rolling out r128673.
http://trac.webkit.org/changeset/128673
https://bugs.webkit.org/show_bug.cgi?id=96847

Makes plugins/document-open.html crash (Requested by jamesr_
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-14

  • dom/ContainerNode.cpp:

(WebCore):
(WebCore::ContainerNode::insertBeforeCommon):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::removeBetween):
(WebCore::ContainerNode::removeChildren):
(WebCore::ContainerNode::appendChild):
(WebCore::ContainerNode::parserAddChild):
(WebCore::dispatchChildInsertionEvents):
(WebCore::dispatchChildRemovalEvents):

  • dom/ContainerNode.h:
  • dom/ContainerNodeAlgorithms.h:

(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoTree):
(WebCore::ChildNodeInsertionNotifier::notify):
(WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromTree):

  • dom/Document.cpp:

(WebCore::Document::dispatchWindowEvent):
(WebCore::Document::dispatchWindowLoadEvent):

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEvent):

  • dom/EventTarget.cpp:

(WebCore):
(WebCore::forbidEventDispatch):
(WebCore::allowEventDispatch):
(WebCore::eventDispatchForbidden):
(WebCore::EventTarget::fireEventListeners):

  • dom/EventTarget.h:

(WebCore):
(WebCore::forbidEventDispatch):
(WebCore::allowEventDispatch):

  • dom/Node.cpp:

(WebCore::Node::dispatchSubtreeModifiedEvent):
(WebCore::Node::dispatchFocusInEvent):
(WebCore::Node::dispatchFocusOutEvent):
(WebCore::Node::dispatchDOMActivateEvent):

  • dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::dispatchRegionLayoutUpdateEvent):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadInternal):

6:38 PM Changeset in webkit [128678] by Beth Dakin
  • 3 edits in trunk/Source/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=96846
Tests failing on WK2 bots after giving fixed positioning its own
stacking context

Reviewed by Geoffrey Garen.

Tests are failing because I checked in updated results that expect
fixed positioning to create a stacking context. However,
WebKitTestRunner does not enable ScrollingCoordinator, so the code
that I added to enable stacking contexts for fixedPos is never
actually running. This patch moves that code to a place where it will
run for the testing tools, which matches the patch for WK1.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::updatePreferences):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):

6:24 PM Changeset in webkit [128677] by jchaffraix@webkit.org
  • 24 edits
    7 deletes in trunk

Revert r127457 and following fixes due to several hit-testing regressions
https://bugs.webkit.org/show_bug.cgi?id=96830

Reviewed by Antonio Gomes.

.:

This change reverts r127457, r127863 and r128505.

  • Source/autotools/symbols.filter:

Source/WebCore:

This change reverts r127457, r127863 and r128505.

  • WebCore.exp.in:
  • WebCore.order:
  • dom/Document.cpp:

(WebCore::Document::nodesFromRect):

  • dom/Document.h:

(Document):

  • page/EventHandler.cpp:

(WebCore::EventHandler::hitTestResultAtPoint):

  • rendering/HitTestRequest.h:
  • rendering/HitTestResult.cpp:

(WebCore::HitTestLocation::HitTestLocation):

  • rendering/HitTestResult.h:

(HitTestLocation):

  • rendering/RenderFrameBase.cpp:
  • rendering/RenderFrameBase.h:

(RenderFrameBase):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTest):

  • testing/Internals.cpp:

(WebCore::Internals::nodesFromRect):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit/chromium:

This change reverts r127457, r127863 and r128505.

  • src/ContextMenuClientImpl.cpp:

(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

Source/WebKit2:

This change reverts r127457, r127863 and r128505.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

This change reverts r127457, r127863 and r128505. As the tests relies on the extended API
after r127457, we cannot keep them.

  • fast/dom/nodesFromRect/nodesFromRect-child-frame-content-expected.txt: Removed.
  • fast/dom/nodesFromRect/nodesFromRect-child-frame-content.html: Removed.
  • fast/dom/nodesFromRect/resources/child-frame.html: Removed.
  • fast/dom/nodesFromRect/resources/nodesFromRect.js:

(check):
(checkShadowContent):

  • touchadjustment/iframe-boundary-expected.txt: Removed.
  • touchadjustment/iframe-boundary.html: Removed.
  • touchadjustment/resources/inner-content-page.html: Removed.
  • touchadjustment/resources/inner-navigation-frame.html: Removed.
6:22 PM Changeset in webkit [128676] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Skip image load tests that requires queueReload in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=96832

Tests added in reivison 128645.

Patch by Bo Liu <boliu@chromium.org> on 2012-09-14
Reviewed by Adam Barth.

  • platform/wk2/Skipped:
5:43 PM Changeset in webkit [128675] by dpranke@chromium.org
  • 7 edits in trunk/Tools

nrwt: --additional-platform-dir is broken on chromium ports
https://bugs.webkit.org/show_bug.cgi?id=96840

Reviewed by Ojan Vafai.

Looks like I broke this when cleaning things up as part of
adding ML support. Fixing and adding a test.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.default_baseline_search_path):

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.default_baseline_search_path):

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:

(ChromiumLinuxPort.default_baseline_search_path):

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:

(ChromiumMacPort.init):

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:

(ChromiumWinPort.setup_environ_for_server):

  • Scripts/webkitpy/layout_tests/port/port_testcase.py:

(test_check_build):
(test_additional_platform_directory):

5:08 PM Changeset in webkit [128674] by jsbell@chromium.org
  • 7 edits in trunk

IndexedDB: Calling close() during upgradeneeded handler should fire error at open request
https://bugs.webkit.org/show_bug.cgi?id=96807

Reviewed by Tony Chang.

Source/WebCore:

Per spec, if the database connection is closed before the success event fires, the request
should have an error event of type AbortError fired at it.

Test: storage/indexeddb/intversion-close-in-upgradeneeded.html

  • Modules/indexeddb/IDBDatabase.h:

(WebCore::IDBDatabase::isClosePending): Expose this state so an in-flight success can be morphed.

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::close): Fire the appropriate error at connections that are mid-opening.

  • Modules/indexeddb/IDBOpenDBRequest.cpp:

(WebCore::IDBOpenDBRequest::onSuccess): If the connection was closed before the success is enqueued -
which can happen in multi-process ports with asynchronous messaging - convert the success to an error.

LayoutTests:

Update the test to match the spec behavior.

  • storage/indexeddb/intversion-close-in-upgradeneeded-expected.txt:
  • storage/indexeddb/resources/intversion-close-in-upgradeneeded.js:

(deleteSuccess):
(upgradeNeeded.transaction.oncomplete):
(upgradeNeeded):
(openError):

5:04 PM Changeset in webkit [128673] by rniwa@webkit.org
  • 11 edits in trunk/Source/WebCore

Turn forbidEventDispatch and allowEventDispatch into a RAII object
https://bugs.webkit.org/show_bug.cgi?id=96717

Reviewed by Abhishek Arya.

Replaced forbidEventDispatch and allowEventDispatch by AssertNoEventDispatch.

  • dom/ContainerNode.cpp:

(WebCore):
(WebCore::ContainerNode::insertBeforeCommon):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::removeBetween):
(WebCore::ContainerNode::removeChildren):
(WebCore::ContainerNode::appendChild):
(WebCore::ContainerNode::parserAddChild):
(WebCore::dispatchChildInsertionEvents):
(WebCore::dispatchChildRemovalEvents):

  • dom/ContainerNode.h:

(AssertNoEventDispatch):
(WebCore::AssertNoEventDispatch::AssertNoEventDispatch):
(WebCore::AssertNoEventDispatch::~AssertNoEventDispatch):
(WebCore::AssertNoEventDispatch::isEventDispatchForbidden):
(WebCore):

  • dom/ContainerNodeAlgorithms.h:

(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoTree):
(WebCore::ChildNodeInsertionNotifier::notify):
(WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromTree):

  • dom/Document.cpp:

(WebCore::Document::dispatchWindowEvent):
(WebCore::Document::dispatchWindowLoadEvent):

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEvent):

  • dom/EventTarget.cpp:

(WebCore):
(WebCore::EventTarget::fireEventListeners):

  • dom/EventTarget.h:

(WebCore):

  • dom/Node.cpp:

(WebCore::Node::dispatchSubtreeModifiedEvent):
(WebCore::Node::dispatchFocusInEvent):
(WebCore::Node::dispatchFocusOutEvent):
(WebCore::Node::dispatchDOMActivateEvent):

  • dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::dispatchRegionLayoutUpdateEvent):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadInternal):

4:41 PM Changeset in webkit [128672] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Mark svg/carto.net/selectionlist.svg as flaky because it depends on svg/carto.net/button.svg
running first in order to pass.

  • platform/chromium/TestExpectations:
4:37 PM Changeset in webkit [128671] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

The cr-linux-ews thinks http/tests/cache/post-redirect-get.php and http/tests/cache/post-with-cached-subresources.php are MISSING results
https://bugs.webkit.org/show_bug.cgi?id=95215

Reviewed by Adam Barth.

Apparently, marking these as missing did not fix the EWS problem,
so remove them from TestExpectations.

  • platform/chromium/TestExpectations:
4:33 PM Changeset in webkit [128670] by commit-queue@webkit.org
  • 24 edits in trunk

JSC should throw a more descriptive exception when blocking 'eval' via CSP.
https://bugs.webkit.org/show_bug.cgi?id=94331

Patch by Mike West <mkwst@chromium.org> on 2012-09-14
Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Unless explicitly whitelisted, the 'script-src' Content Security Policy
directive blocks 'eval' and 'eval'-like constructs such as
'new Function()'. When 'eval' is encountered in code, an 'EvalError' is
thrown, but the associated message is poor: "Eval is disabled" doesn't
give developers enough information about why their code isn't behaving
as expected.

This patch adds an 'errorMessage' parameter to the JavaScriptCore method
used to disable 'eval'; ContentSecurityPolicy has the opportunity to
pass in a more detailed and descriptive error that contains more context
for the developer.

  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):

Drop the hard-coded "Eval is disabled" error message in favor of
reading the error message off the global object.

  • runtime/FunctionConstructor.cpp:

(JSC::FunctionConstructor::getCallData):

Drop the hard-coded "Function constructor is disabled" error message
in favor of reading the error message off the global object.

  • runtime/JSGlobalObject.h:

(JSGlobalObject):
(JSC::JSGlobalObject::evalEnabled):

Making this accessor method const.

(JSC::JSGlobalObject::evalDisabledErrorMessage):

Accessor for the error message set via 'setEvalDisabled'.

(JSC::JSGlobalObject::setEvalEnabled):

Adding an 'errorMessage' parameter which is stored on the global
object, and used when exceptions are thrown.

Source/WebCore:

Unless explicitly whitelisted, the 'script-src' Content Security Policy
directive blocks 'eval' and 'eval'-like constructs such as
'new Function()'. When 'eval' is encountered in code, an 'EvalError' is
thrown, but the associated message is poor: "Eval is disabled" doesn't
give developers enough information about why their code isn't behaving
as expected.

This patch adds an 'errorMessage' parameter to the JavaScriptCore method
used to disable 'eval'; ContentSecurityPolicy has the opportunity to
pass in a more detailed and descriptive error that contains more context
for the developer.

The new error message is tested by adjusting existing tests; nothing new
is required.

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::initScript):

Read the error message off the document's ContentSecurityPolicy.

(WebCore::ScriptController::disableEval):

  • bindings/js/ScriptController.h:

(ScriptController):

Pipe the error message through to JSGlobalObject when disabling eval

  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::disableEval):

  • bindings/js/WorkerScriptController.h:

(WorkerScriptController):

Pipe the error message through to JSGlobalObject when disabling eval

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::disableEval):

  • bindings/v8/ScriptController.h:

(ScriptController):

  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::disableEval):

  • bindings/v8/WorkerScriptController.h:

(WorkerScriptController):

Placeholder for V8 piping to be built in webk.it/94332.

  • dom/Document.cpp:

(WebCore::Document::disableEval):

  • dom/Document.h:

(Document):

  • dom/ScriptExecutionContext.h:

(ScriptExecutionContext):

Pipe the error message through to the ScriptController when
disabling eval.

  • page/ContentSecurityPolicy.cpp:

(WebCore::CSPDirectiveList::evalDisabledErrorMessage):

Accessor for the error message that ought be displayed to developers
when 'eval' used while disabled for a specific directive list.

(WebCore::CSPDirectiveList::setEvalDisabledErrorMessage):

Mutator for the error message that ought be displayed to developers
when 'eval' used while disabled for a specific directive list.

(CSPDirectiveList):
(WebCore::CSPDirectiveList::create):

Upon creation of a CSPDirectiveList, set the error message if the
directive list disables 'eval'.

(WebCore::ContentSecurityPolicy::didReceiveHeader):

Pass the error message into ScriptExecutionContext::disableEval.

(WebCore::ContentSecurityPolicy::evalDisabledErrorMessage):

Public accessor for the policy's error message; walks the list of
directive lists and returns the first error message found.

(WebCore):

  • page/ContentSecurityPolicy.h:
  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::disableEval):

  • workers/WorkerContext.h:

(WorkerContext):

Pipe the error message through to the ScriptController when
disabling eval.

LayoutTests:

  • http/tests/security/contentSecurityPolicy/eval-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/eval-blocked-in-about-blank-iframe-expected.txt:
  • http/tests/security/contentSecurityPolicy/function-constructor-blocked-expected.txt:
4:25 PM Changeset in webkit [128669] by commit-queue@webkit.org
  • 13 edits in trunk/Source/WebCore

Remove V8DOMWindowShell::getEntered
https://bugs.webkit.org/show_bug.cgi?id=96637

Patch by Dan Carney <dcarney@google.com> on 2012-09-14
Reviewed by Adam Barth.

V8DOMWindowShell::getEntered was refactored so that the window shell
no longer has to be kept alive by a v8 context but rather a smaller
object.

No new tests. No change in functionality.

  • bindings/v8/DOMData.cpp:

(WebCore::DOMData::getCurrentStore):

  • bindings/v8/ScopedPersistent.h:

(WebCore::ScopedPersistent::leakHandle):
(ScopedPersistent):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::resetIsolatedWorlds):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::currentWorldContext):

  • bindings/v8/V8Binding.cpp:

(WebCore::perContextDataForCurrentWorld):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::setIsolatedWorldField):
(WebCore::V8DOMWindowShell::toIsolatedContextData):
(WebCore::isolatedContextWeakCallback):
(WebCore::V8DOMWindowShell::disposeContext):
(WebCore::V8DOMWindowShell::clearIsolatedShell):
(WebCore):
(WebCore::V8DOMWindowShell::initializeIfNeeded):
(WebCore::V8DOMWindowShell::setIsolatedWorldSecurityOrigin):

  • bindings/v8/V8DOMWindowShell.h:

(V8DOMWindowShell):
(IsolatedContextData):
(WebCore::V8DOMWindowShell::IsolatedContextData::create):
(WebCore::V8DOMWindowShell::IsolatedContextData::world):
(WebCore::V8DOMWindowShell::IsolatedContextData::perContextData):
(WebCore::V8DOMWindowShell::IsolatedContextData::setSecurityOrigin):
(WebCore::V8DOMWindowShell::IsolatedContextData::securityOrigin):
(WebCore::V8DOMWindowShell::IsolatedContextData::IsolatedContextData):
(WebCore::V8DOMWindowShell::enteredIsolatedContext):
(WebCore::V8DOMWindowShell::enteredIsolatedContextData):

  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getCachedWrapper):

  • bindings/v8/WorldContextHandle.cpp:

(WebCore::WorldContextHandle::WorldContextHandle):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8SVGDocumentCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:

(WebCore::V8XMLHttpRequest::constructorCallback):

4:19 PM Changeset in webkit [128668] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Mark compositing/geometry/fixed-position-transform-composited-page-scale.html flaky
as it's flaky on all the Chromium bots.

  • platform/chromium/TestExpectations:
4:13 PM Changeset in webkit [128667] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

bbc homepage crashes immediately
https://bugs.webkit.org/show_bug.cgi?id=96812
<rdar://problem/12081386>

Reviewed by Oliver Hunt.

If you use the old storage pointer to write to space you thought was newly allocated,
you're going to have a bad time.

  • runtime/JSArray.cpp:

(JSC::JSArray::unshiftCount):

4:11 PM Changeset in webkit [128666] by Michelangelo De Simone
  • 3 edits
    12 adds in trunk

[CSS Shaders] u_textureSize uniform should be set to the size of the texture.
https://bugs.webkit.org/show_bug.cgi?id=95914

Reviewed by Dean Jackson.

Source/WebCore:

This adds support for the following shader uniform variables:

uniform vec2 u_textureSize
uniform vec4 u_meshBox
uniform vec2 u_tileSize
uniform vec2 u_meshSize

The relevant section of the specification is:
http://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#shader-uniform-variables

Tests: css3/filters/custom/custom-filter-u-mesh-box.html

css3/filters/custom/custom-filter-u-mesh-size.html
css3/filters/custom/custom-filter-u-texture-size.html
css3/filters/custom/custom-filter-u-tile-size.html

  • platform/graphics/filters/FECustomFilter.cpp:

(WebCore::FECustomFilter::bindProgramAndBuffers):

LayoutTests:

Tests for the following uniform variables:

uniform vec2 u_textureSize
uniform vec4 u_meshBox
uniform vec2 u_tileSize
uniform vec2 u_meshSize

The relevant section of the specification is:
http://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#shader-uniform-variables

  • css3/filters/custom/custom-filter-u-mesh-box-expected.html: Added.
  • css3/filters/custom/custom-filter-u-mesh-box.html: Added.
  • css3/filters/custom/custom-filter-u-mesh-size-expected.html: Added.
  • css3/filters/custom/custom-filter-u-mesh-size.html: Added.
  • css3/filters/custom/custom-filter-u-texture-size-expected.html: Added.
  • css3/filters/custom/custom-filter-u-texture-size.html: Added.
  • css3/filters/custom/custom-filter-u-tile-size-expected.html: Added.
  • css3/filters/custom/custom-filter-u-tile-size.html: Added.
  • css3/filters/resources/u-mesh-box-is-unit-square.fs: Added.
  • css3/filters/resources/u-mesh-size.fs: Added.
  • css3/filters/resources/u-texture-size.fs: Added.
  • css3/filters/resources/u-tile-size.fs: Added.
4:06 PM Changeset in webkit [128665] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed.


A small improvement to this flaky test: use a correct URL, so that the test fails
quickly and understandably instead of timing out. This code path didn't use to be
taken before, so the URL was always wrong.

  • fast/loader/resources/submit-form-while-parsing-subframe.html:
3:49 PM Changeset in webkit [128664] by Stephanie Lewis
  • 2 edits in trunk/LayoutTests

new fast/loader tests from r128645 fail on Mac-wk2.
https://bugs.webkit.org/show_bug.cgi?id=96832.

Unreviewed.

Update TestExpectations

  • platform/mac-wk2/TestExpectations:
3:49 PM Changeset in webkit [128663] by ojan@chromium.org
  • 11 edits in trunk/Source

Provide a runtime setting to disable position:sticky
https://bugs.webkit.org/show_bug.cgi?id=96827

Reviewed by James Robinson.

Source/WebCore:

Have it be on by default so that only ports that both enable
the define and don't want it on by default need to do something special.

  • css/CSSParser.cpp:

(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
(WebCore::isValidKeywordPropertyAndValue):

  • css/CSSParserMode.h:

(CSSParserContext):

  • dom/Document.cpp:

(WebCore::Document::cssStickyPositionEnabled):
(WebCore):

  • dom/Document.h:

(Document):

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(Settings):
(WebCore::Settings::setCSSStickyPositionEnabled):
(WebCore::Settings::cssStickyPositionEnabled):

Source/WebKit/chromium:

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setCSSStickyPositionEnabled):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

3:48 PM Changeset in webkit [128662] by Stephanie Lewis
  • 2 edits in trunk/Tools

mac-future ignores previous platform TestExpectations.
https://bugs.webkit.org/show_bug.cgi?id=96718.

Reviewed by Dirk Pranke.

TestExpectations match an expectation's configuraton against a list of configurations that are
valid for that port. That list does not contain mac-future so none of the expectations can be
applied.

  • Scripts/webkitpy/layout_tests/port/apple.py:

(ApplePort._generate_all_test_configurations):

3:47 PM Changeset in webkit [128661] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Add expectations for tests that depend on other tests running before them.
Filed a bug for each with information on which test it depends on.

  • platform/chromium/TestExpectations:
3:26 PM Changeset in webkit [128660] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Fix builds with CSS_IMAGE_RESOLUTION enabled after r128656.

  • css/StyleBuilder.cpp:

(WebCore::ApplyPropertyImageResolution::applyInheritValue):
(WebCore::ApplyPropertyImageResolution::applyInitialValue):

3:21 PM Changeset in webkit [128659] by jamesr@google.com
  • 1 edit
    1 copy
    4 moves
    19 adds in trunk/LayoutTests

Unreviewed gardening.

Update fixpos layout test results. Chromium currently doesn't set the fixpos-forms-stacking-context setting in
DumpRenderTree.

  • fast/block/positioning/016-expected.png: Copied from LayoutTests/platform/efl/fast/block/positioning/016-expected.png.
  • fast/block/positioning/025-expected.png: Renamed from LayoutTests/platform/efl/fast/block/positioning/025-expected.png.
  • platform/chromium-linux-x86/compositing/geometry/fixed-position-composited-switch-expected.txt: Added.
  • platform/chromium-linux-x86/fast/block/positioning/016-expected.txt: Added.
  • platform/chromium-linux-x86/fast/block/positioning/025-expected.txt: Added.
  • platform/chromium-linux-x86/fast/block/positioning/fixed-position-stacking-context-expected.txt: Added.
  • platform/chromium-linux/compositing/geometry/fixed-position-composited-switch-expected.txt: Added.
  • platform/chromium-linux/fast/block/positioning/016-expected.png: Renamed from LayoutTests/platform/gtk/fast/block/positioning/016-expected.png.
  • platform/chromium-linux/fast/block/positioning/016-expected.txt: Added.
  • platform/chromium-linux/fast/block/positioning/025-expected.png: Renamed from LayoutTests/platform/gtk/fast/block/positioning/025-expected.png.
  • platform/chromium-linux/fast/block/positioning/025-expected.txt: Added.
  • platform/chromium-linux/fast/block/positioning/fixed-position-stacking-context-expected.png: Renamed from LayoutTests/platform/efl/fast/block/positioning/016-expected.png.
  • platform/chromium-linux/fast/block/positioning/fixed-position-stacking-context-expected.txt: Added.
  • platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-composited-switch-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/block/positioning/016-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/block/positioning/025-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/block/positioning/fixed-position-stacking-context-expected.txt: Added.
  • platform/chromium-mac/compositing/geometry/fixed-position-composited-switch-expected.txt: Added.
  • platform/chromium-mac/fast/block/positioning/016-expected.png: Added.
  • platform/chromium-mac/fast/block/positioning/016-expected.txt: Added.
  • platform/chromium-mac/fast/block/positioning/025-expected.png: Added.
  • platform/chromium-mac/fast/block/positioning/025-expected.txt: Added.
  • platform/chromium-mac/fast/block/positioning/fixed-position-stacking-context-expected.png: Added.
  • platform/chromium-mac/fast/block/positioning/fixed-position-stacking-context-expected.txt: Added.
3:04 PM Changeset in webkit [128658] by abarth@webkit.org
  • 40 edits in trunk

Remove webkitPostMessage
https://bugs.webkit.org/show_bug.cgi?id=96577

Reviewed by Ojan Vafai.

.:

Add ENABLE_LEGACY_VENDOR_PREFIXES flag.

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

Add ENABLE_LEGACY_VENDOR_PREFIXES flag.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

webkitPostMessage works the same as postMessage. The spec and the
implementation have been stable for a while. We should no longer be
exposing this vendor-prefixed API.

This patch places the webkitPostMessage API behind an ENABLE flag.
We're going to try removing this API in the Chromium port. If we don't
run into trouble, we'll remove it in all the other ports as well.

This topic has been discussed on webkit-dev in
http://lists.webkit.org/pipermail/webkit-dev/2012-April/020237.html and
http://lists.webkit.org/pipermail/webkit-dev/2012-September/022189.html

This patch introduces the ENABLE(LEGACY_VENDOR_PREFIXES) flag. Rather
than having a flag for each vendor-prefixed API we're experimenting
with removing, we'll add vendor prefixed APIs to this ENABLE when we
want to try removing them. If we succeed, we'll just delete the APIs.
If we fail, we'll remove them from the ENABLE. That way we avoid the
churn of adding and removing many ENABLE macros.

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • GNUmakefile.features.am:
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore):

  • bindings/js/JSDedicatedWorkerContextCustom.cpp:

(WebCore):

  • bindings/js/JSMessagePortCustom.cpp:

(WebCore):

  • bindings/js/JSWorkerCustom.cpp:

(WebCore):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore):

  • bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:

(WebCore):

  • bindings/v8/custom/V8MessagePortCustom.cpp:

(WebCore):

  • bindings/v8/custom/V8WorkerCustom.cpp:

(WebCore):

  • dom/MessagePort.idl:
  • page/DOMWindow.idl:
  • workers/DedicatedWorkerContext.idl:
  • workers/Worker.idl:

Source/WebKit/chromium:

Add ENABLE_LEGACY_VENDOR_PREFIXES flag.

  • features.gypi:

Source/WebKit/mac:

Add ENABLE_LEGACY_VENDOR_PREFIXES flag.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Add ENABLE_LEGACY_VENDOR_PREFIXES flag.

  • Configurations/FeatureDefines.xcconfig:

Tools:

Add ENABLE_LEGACY_VENDOR_PREFIXES flag.

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:

LayoutTests:

Update tests to rely only upon the unprefixed API.

  • fast/canvas/webgl/script-tests/arraybuffer-transfer-of-control.js:

(wrapSend):
(wrapFailSend):

  • fast/dom/Window/post-message-crash.html:
  • fast/dom/Window/window-postmessage-args-expected.txt:
  • fast/dom/Window/window-postmessage-args.html:
  • fast/events/message-port.html:
  • fast/events/resources/message-port-multi.js:
  • fast/workers/resources/worker-call.js:
  • fast/workers/worker-call-expected.txt:
2:57 PM Changeset in webkit [128657] by ap@apple.com
  • 2 edits in trunk/Source/WTF

Minimize collisions when hashing pairs
https://bugs.webkit.org/show_bug.cgi?id=96022

Build fix (with newer clang?)

  • wtf/HashFunctions.h: (WTF::pairIntHash): Be explicit about casting from 64 bit to 32 bit.
2:52 PM Changeset in webkit [128656] by Simon Fraser
  • 6 edits
    2 adds in trunk

REGRESSION: transition doesn’t always override transition-property
https://bugs.webkit.org/show_bug.cgi?id=96658

Reviewed by Dean Jackson.

Source/WebCore:

Setting the animation property on an Animation in CSSToStyleMap::mapAnimationProperty()
is special because we have to call setAnimationMode(Animation::AnimateAll) as well
as setting the property to CSSPropertyInvalid if it's for the initial state
of the transition-property property.

In order to fix this via StyleBuilder PropertyHandlers, we have to know,
in ApplyPropertyAnimation::applyInitialValue(), which property is getting applied.
This requires passing the CSSPropertyID down through all of the "apply" methods.

Do some unrelated cleanup in CSSParser::parseTransitionShorthand(); the existing code
was not safe with respect to adding new properties to the shorthand.

Test: transitions/longhand-vs-shorthand-initial.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseTransitionShorthand):

  • css/StyleBuilder.cpp:

(WebCore::ApplyPropertyExpanding::applyInheritValue):
(WebCore::ApplyPropertyExpanding::applyInitialValue):
(WebCore::ApplyPropertyExpanding::applyValue):
(WebCore::ApplyPropertyDefaultBase::applyInheritValue):
(WebCore::ApplyPropertyDefaultBase::applyInitialValue):
(WebCore::ApplyPropertyDefaultBase::applyValue):
(WebCore::ApplyPropertyDefault::applyValue):
(WebCore::ApplyPropertyNumber::applyValue):
(WebCore::ApplyPropertyStyleImage::applyValue):
(WebCore::ApplyPropertyAuto::applyInheritValue):
(WebCore::ApplyPropertyAuto::applyInitialValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::applyInheritValue):
(WebCore::ApplyPropertyClip::applyInitialValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyColor::applyInheritValue):
(WebCore::ApplyPropertyColor::applyInitialValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyDirection::applyValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyFillLayer::applyInheritValue):
(WebCore::ApplyPropertyFillLayer::applyInitialValue):
(WebCore::ApplyPropertyFillLayer::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFont::applyInheritValue):
(WebCore::ApplyPropertyFont::applyInitialValue):
(WebCore::ApplyPropertyFont::applyValue):
(WebCore::ApplyPropertyFontSize::applyInheritValue):
(WebCore::ApplyPropertyFontSize::applyInitialValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyInheritValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyInitialValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyBorderImage::applyValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInheritValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInitialValue):
(WebCore::ApplyPropertyBorderImageModifier::applyValue):
(WebCore::ApplyPropertyBorderImageSource::applyValue):
(WebCore::ApplyPropertyCounter::emptyFunction):
(WebCore::ApplyPropertyCounter::applyInheritValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCursor::applyInheritValue):
(WebCore::ApplyPropertyCursor::applyInitialValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyTextAlign::applyValue):
(WebCore::ApplyPropertyTextDecoration::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyPageSize::applyInheritValue):
(WebCore::ApplyPropertyPageSize::applyInitialValue):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyAnimation::applyInheritValue):
(WebCore::ApplyPropertyAnimation::applyInitialValue): If the property is
CSSPropertyWebkitTransitionProperty, call setAnimationMode(Animation::AnimateAll).
(WebCore::ApplyPropertyAnimation::applyValue):
(WebCore::ApplyPropertyOutlineStyle::applyInheritValue):
(WebCore::ApplyPropertyOutlineStyle::applyInitialValue):
(WebCore::ApplyPropertyOutlineStyle::applyValue):
(WebCore::ApplyPropertyResize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyAspectRatio::applyInheritValue):
(WebCore::ApplyPropertyAspectRatio::applyInitialValue):
(WebCore::ApplyPropertyAspectRatio::applyValue):
(WebCore::ApplyPropertyZoom::applyInheritValue):
(WebCore::ApplyPropertyZoom::applyInitialValue):
(WebCore::ApplyPropertyZoom::applyValue):
(WebCore::ApplyPropertyDisplay::applyInheritValue):
(WebCore::ApplyPropertyDisplay::applyInitialValue):
(WebCore::ApplyPropertyDisplay::applyValue):
(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyWrapShape::applyValue):
(WebCore::ApplyPropertyImageResolution::applyInheritValue):
(WebCore::ApplyPropertyImageResolution::applyInitialValue):
(WebCore::ApplyPropertyImageResolution::applyValue):

  • css/StyleBuilder.h:

(PropertyHandler):
(WebCore::PropertyHandler::applyInheritValue):
(WebCore::PropertyHandler::applyInitialValue):
(WebCore::PropertyHandler::applyValue):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList): Pass in the property ID.

LayoutTests:

Test with longhand transition-property rule, followed by shorthand
with missing property value. This test should pass, and not assert.

  • transitions/longhand-vs-shorthand-initial-expected.txt: Added.
  • transitions/longhand-vs-shorthand-initial.html: Added.
2:43 PM Changeset in webkit [128655] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Support constructor-type attribute in idls other than DOMWindow.
https://bugs.webkit.org/show_bug.cgi?id=96821

Patch by Chang Shu <cshu@webkit.org> on 2012-09-14
Reviewed by Kentaro Hara.

In CodeGeneratorJS.pm, we should not assume only DOMWindow uses Constructor
attribute. So for other interfaces, we should pass castedThis->globalObject()
instead of castedThis.

Test: bindings/scripts/test/JS/JSTestObj.idl

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjConstructorTestSubObj):
(WebCore::jsTestObjConditionalAttr4Constructor):
(WebCore::jsTestObjConditionalAttr5Constructor):
(WebCore::jsTestObjConditionalAttr6Constructor):

2:34 PM Changeset in webkit [128654] by tsepez@chromium.org
  • 5 edits
    2 adds in trunk

ImageLoader can't be cleared when video element poster attribute removed.
https://bugs.webkit.org/show_bug.cgi?id=96301

Reviewed by Abhishek Arya.

Source/WebCore:

Same problem as in https://bugs.webkit.org/show_bug.cgi?id=90801. We can't
clear the image loader when the src attribute is cleared, because we might be
inside a handler called on top of an image loader event dispatch. Instead we
will rely on the OwnPtr relationship between the Element and the Image Loader
to limit the lifetime of the loader to that of the element.

Test: fast/dom/beforeload/clear-video-poster-in-beforeload-listener.html

  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::parseAttribute):
Remove permature clearing of m_imageLoader.

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::parseAttribute):
Remove permature clearing of m_imageLoader.

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parseAttribute):
Remove permature clearing of m_imageLoader.

LayoutTests:

Added test case.

  • fast/dom/beforeload/clear-video-poster-in-beforeload-listener-expected.txt: Added.
  • fast/dom/beforeload/clear-video-poster-in-beforeload-listener.html: Added.
2:30 PM Changeset in webkit [128653] by jpfau@apple.com
  • 28 edits
    25 adds in trunk

Allow third-party storage blocking setting to change while a page is loaded
https://bugs.webkit.org/show_bug.cgi?id=95790

Reviewed by Brady Eidson.

.:

Update exported symbols.

  • Source/autotools/symbols.filter:

Source/WebCore:

Pipe through changes to the storage blocking policy to each document and plugin.

Tests: http/tests/security/storage-blocking-loosened-local-storage.html

http/tests/security/storage-blocking-loosened-plugin.html
http/tests/security/storage-blocking-loosened-private-browsing-plugin.html
http/tests/security/storage-blocking-loosened-shared-worker.html
http/tests/security/storage-blocking-loosened-websql.html
http/tests/security/storage-blocking-strengthened-local-storage.html
http/tests/security/storage-blocking-strengthened-plugin.html
http/tests/security/storage-blocking-strengthened-private-browsing-plugin.html
http/tests/security/storage-blocking-strengthened-shared-worker.html
http/tests/security/storage-blocking-strengthened-websql.html

  • WebCore.exp.in:
  • dom/Document.cpp: Pipe changes through to the Document's SecurityOrigin.

(WebCore::Document::storageBlockingStateDidChange):
(WebCore):

  • dom/Document.h:

(Document):

  • page/DOMWindow.cpp: Check to make sure access is allowed before returning a cached storage area.

(WebCore::DOMWindow::sessionStorage):
(WebCore::DOMWindow::localStorage):

  • page/Page.cpp:

(WebCore::Page::collectPluginViews): Refactored out into a function.
(WebCore):
(WebCore::Page::storageBlockingStateChanged): Pipe changes through to each PluginView.
(WebCore::Page::privateBrowsingStateChanged):

  • page/Page.h:

(Page):

  • page/Settings.cpp:

(WebCore::Settings::setStorageBlockingPolicy): Tell Pages about changes to the storage blocking policy.
(WebCore):

  • page/Settings.h:

(Settings):

  • plugins/PluginViewBase.h:

(WebCore::PluginViewBase::storageBlockingStateChanged):

Source/WebKit2:

Inform plugins about changes to the storage blocking policy by way of the private browsing feature.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::storageBlockingStateChanged):
(WebKit):

  • PluginProcess/PluginControllerProxy.h:

(PluginControllerProxy):

  • PluginProcess/PluginControllerProxy.messages.in: Add WK2 message for storageBlockingStateChanged.
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::storageBlockingStateChanged):
(WebKit):
(WebKit::NetscapePlugin::privateBrowsingStateChanged):
(WebKit::NetscapePlugin::updateNPNPrivateMode): Set plugin's private browsing if either private browsing or storage blocking is enabled.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

(NetscapePlugin):

  • WebProcess/Plugins/PDF/BuiltInPDFView.h:

(BuiltInPDFView):

  • WebProcess/Plugins/PDF/BuiltInPDFView.mm: Treat storageBlockingStateChanged as a no-op.

(WebKit::BuiltInPDFView::storageBlockingStateChanged):
(WebKit):

  • WebProcess/Plugins/Plugin.h: Add pure virtual storageBlockingStateChanged method.

(Plugin):

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::storageBlockingStateChanged):
(WebKit):

  • WebProcess/Plugins/PluginProxy.h:

(PluginProxy):

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::storageBlockingStateChanged):
(WebKit):

  • WebProcess/Plugins/PluginView.h:

(PluginView):

  • win/WebKit2.def:

LayoutTests:

Tested combinations of loosening and strengthening the storage blocking policy on various types of storage.

  • http/tests/security/resources/iframe-for-storage-blocking-changed-local-storage.html: Added.
  • http/tests/security/resources/iframe-for-storage-blocking-changed-shared-worker.html: Added.
  • http/tests/security/resources/iframe-for-storage-blocking-changed-websql.html: Added.
  • http/tests/security/storage-blocking-loosened-local-storage-expected.txt: Added.
  • http/tests/security/storage-blocking-loosened-local-storage.html: Added.
  • http/tests/security/storage-blocking-loosened-plugin-expected.txt: Added.
  • http/tests/security/storage-blocking-loosened-plugin.html: Added.
  • http/tests/security/storage-blocking-loosened-private-browsing-plugin-expected.txt: Added.
  • http/tests/security/storage-blocking-loosened-private-browsing-plugin.html: Added.
  • http/tests/security/storage-blocking-loosened-shared-worker-expected.txt: Added.
  • http/tests/security/storage-blocking-loosened-shared-worker.html: Added.
  • http/tests/security/storage-blocking-loosened-websql-expected.txt: Added.
  • http/tests/security/storage-blocking-loosened-websql.html: Added.
  • http/tests/security/storage-blocking-strengthened-local-storage-expected.txt: Added.
  • http/tests/security/storage-blocking-strengthened-local-storage.html: Added.
  • http/tests/security/storage-blocking-strengthened-plugin-expected.txt: Added.
  • http/tests/security/storage-blocking-strengthened-plugin.html: Added.
  • http/tests/security/storage-blocking-strengthened-private-browsing-plugin-expected.txt: Added.
  • http/tests/security/storage-blocking-strengthened-private-browsing-plugin.html: Added.
  • http/tests/security/storage-blocking-strengthened-shared-worker-expected.txt: Added.
  • http/tests/security/storage-blocking-strengthened-shared-worker.html: Added.
  • http/tests/security/storage-blocking-strengthened-websql-expected.txt: Added.
  • http/tests/security/storage-blocking-strengthened-websql.html: Added.
  • platform/chromium/TestExpectations: Skip shared worker and plugin tests.
  • platform/mac-wk2/http/tests/security/storage-blocking-strengthened-plugin-expected.txt: Added.
  • platform/mac-wk2/http/tests/security/storage-blocking-strengthened-private-browsing-plugin-expected.txt: Added.
2:24 PM Changeset in webkit [128652] by Beth Dakin
  • 12 edits
    6 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=96688
Put position:fixed elements in their own layers and allow them to
create a stacking context
-and corresponding-
<rdar://problem/11467961>

Reviewed by Simon Fraser.

Source/WebKit/mac:

Enable these settings in WK1 too for consistency.

  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:

Soon we want pages with fixed positioned elements to be able to be
scrolled by the ScrollingCoordinator. As a part of that work, we have
to composite fixed position elements, and we have to allow those
elements to create a stacking context.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):

LayoutTests:

A few test result differences. These first three tests actually
render differently now.

  • platform/mac/fast/block/positioning/016-expected.png:
  • platform/mac/fast/block/positioning/016-expected.txt:
  • platform/mac/fast/block/positioning/025-expected.png:
  • platform/mac/fast/block/positioning/025-expected.txt:
  • platform/mac/fast/block/positioning/fixed-position-stacking-context-expected.png: Added.
  • platform/mac/fast/block/positioning/fixed-position-stacking-context-expected.txt: Added.

These tests just have different layer trees.

  • platform/mac/compositing/geometry/fixed-position-composited-switch-expected.txt: Added.
  • platform/mac/compositing/rtl: Added.
  • platform/mac/compositing/rtl/rtl-fixed-expected.txt: Added.
  • platform/mac/compositing/rtl/rtl-fixed-overflow-expected.txt: Added.
2:09 PM Changeset in webkit [128651] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Prevent workers from calling back into other worlds
https://bugs.webkit.org/show_bug.cgi?id=96790

Patch by Dan Carney <dcarney@google.com> on 2012-09-14
Reviewed by Adam Barth.

Added a few sanity checks to ensure callbacks are always using the correct world.

No new tests. No new change in functionality.

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::getEventListener):

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

  • bindings/v8/WorldContextHandle.cpp:

(WebCore::WorldContextHandle::WorldContextHandle):
(WebCore::WorldContextHandle::adjustedContext):

  • bindings/v8/WorldContextHandle.h:
2:00 PM Changeset in webkit [128650] by danakj@chromium.org
  • 13 edits in trunk/Source

Minimize collisions when hashing pairs
https://bugs.webkit.org/show_bug.cgi?id=96022

Reviewed by Adrienne Walker.

Source/WebCore:

Use WTF::pairIntHash() to hash pairs of integers.

  • dom/Document.cpp:

(WebCore::ImmutableAttributeDataCacheKey::hash):

  • dom/StyledElement.cpp:

(WebCore::computePresentationAttributeCacheHash):

  • platform/graphics/Gradient.cpp:

(WebCore::Gradient::hash):

  • platform/graphics/IntPointHash.h:

(WTF::IntPointHash::hash):

  • platform/graphics/IntRectHash.h:
  • platform/graphics/IntSizeHash.h:
  • platform/graphics/blackberry/LayerTileIndex.h:
  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::SubimageCacheHash::hash):

Source/WebKit/blackberry:

Use WTF::pairIntHash() to hash a pair of integers.

  • WebKitSupport/TileIndexHash.h:

Source/WTF:

The current hash function for pairs has poor performance as it does a
nice hash function on 64 bits, but then just drops the top 32 bits. The
hash method for pairs tries to use Thomas Wang's 64 bit Mix Function,
but this requires not dropping any bits in order to retain the
characteristics mentioned by Thomas.

A better method of hashing sets of 32-bit integers is to use
multiplication in 64 bits with random integers. This method is a
provably almost-universal hash function. Testing shows that this
method decreases the time required, when compared with the current
method, by more than 20% due to better hashing characteristics.

  • wtf/HashFunctions.h:

(WTF):
(WTF::pairIntHash):
Implments the hashing method for a pair of unsigned integers.

(WTF::PairHash::hash):
Use pairIntHash() on the hash results of each object in the pair.

(WTF::IntPairHash::hash):
Implement an integer-specific PairHash class that does not need to
hash each object in the pair. It uses pairIntHash on the two
integers in the pair directly.

(WTF::IntPairHash::equal):
(IntPairHash):

1:51 PM Changeset in webkit [128649] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

Use performance.webkitNow in PerfTestRunner
https://bugs.webkit.org/show_bug.cgi?id=92826

Reviewed by Eric Seidel.

Use performance.webkitNow with Date.now as a fallback for more accurate time measurements.

  • resources/runner.js:

(PerfTestRunner._runner):
(PerfTestRunner._perSecondRunnerIterator):

1:39 PM Changeset in webkit [128648] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-14

  • DEPS:
1:18 PM Changeset in webkit [128647] by rwlbuis@webkit.org
  • 5 edits in trunk/Source/WebCore

[BlackBerry] Use StringBuilder more in BlackBerry RSS classes
https://bugs.webkit.org/show_bug.cgi?id=96820

Reviewed by Antonio Gomes.

Use append/appendLiteral where possible.

  • platform/MIMETypeRegistry.cpp:

(WebCore::mimeTypeAssociationMap):

  • platform/network/blackberry/rss/RSSAtomParser.cpp:

(WebCore::RSSAtomParser::parseContent):
(WebCore::RSSAtomParser::parseAuthor):

  • platform/network/blackberry/rss/RSSGenerator.cpp:

(WebCore::RSSGenerator::generateHtml):

  • platform/network/blackberry/rss/RSSParserBase.cpp:

(WebCore::textFromXMLAttr):
(WebCore::textFromXMLNode):

1:08 PM Changeset in webkit [128646] by Alexandru Chiculita
  • 3 edits in trunk/Source/WebCore

[CSS Shaders] Enable anti-aliasing on the FECustomFilter
https://bugs.webkit.org/show_bug.cgi?id=96668

Reviewed by Dean Jackson.

Added multisample frame buffer for the FECustomFilter. It will try to allocate a multisample framebuffer
with a maximum sample count of 4. At the end it will blit the samples back to the original frame buffer,
so that we can read the pixels back.

This patch uses extensions GL_ANGLE_framebuffer_multisample, GL_ANGLE_framebuffer_blit
and GL_OES_rgb8_rgba8.

No new tests, multisampling is not working in Chromium DRT and has not pixel effect on WebKit Mac.

  • platform/graphics/filters/FECustomFilter.cpp:

(WebCore::FECustomFilter::FECustomFilter):
(WebCore::FECustomFilter::deleteRenderBuffers):
(WebCore):
(WebCore::FECustomFilter::deleteMultisampleRenderBuffers):
(WebCore::FECustomFilter::drawFilterMesh):
(WebCore::FECustomFilter::createMultisampleBuffer):
(WebCore::FECustomFilter::resolveMultisampleBuffer):
(WebCore::FECustomFilter::canUseMultisampleBuffers):
(WebCore::FECustomFilter::resizeMultisampleBuffers):
(WebCore::FECustomFilter::resizeContext):

  • platform/graphics/filters/FECustomFilter.h:
1:04 PM Changeset in webkit [128645] by commit-queue@webkit.org
  • 24 edits
    4 adds in trunk

Add in-place reload behavior to ImagesEnabled setting
https://bugs.webkit.org/show_bug.cgi?id=95478

.:

Patch by Bo Liu <boliu@chromium.org> on 2012-09-14
Reviewed by Adam Barth.

Export WebCore::Settings::setImagesEnabled symbol.

  • Source/autotools/symbols.filter:

Source/WebCore:

Patch by Bo Liu <boliu@chromium.org> on 2012-09-14
Reviewed by Adam Barth.

Store ImagesEnabled setting in CachedResourceLoader similar to
AutoLoadImages. Move FrameLoaderClient::allowImage to after a
CachedImage has been created and store the cache for reload if it is
blocked.

Make sure when image loads are deferred by either ImagesEnabled or
LoadImagesAutomatically, onload is not called.

Added ImagesEnabled to InternalSettings for layout tests.

Tests: fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html

fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html

  • WebCore.exp.in:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::didBeginDocument):

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequest):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::load):

  • loader/cache/CachedImage.h:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::didAddClient):

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::stillNeedsLoad):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
(WebCore::CachedResourceLoader::setAutoLoadImages):
(WebCore):
(WebCore::CachedResourceLoader::setImagesEnabled):
(WebCore::CachedResourceLoader::shouldDeferImageLoad):
(WebCore::CachedResourceLoader::reloadImagesIfNotDeferred):

  • loader/cache/CachedResourceLoader.h:

(CachedResourceLoader):
(WebCore::CachedResourceLoader::imagesEnabled):

  • page/Settings.cpp:

(WebCore::setImageLoadingSettings):
(WebCore::Settings::Settings):
(WebCore::Settings::setLoadsImagesAutomatically):
(WebCore::Settings::imageLoadingSettingsTimerFired):
(WebCore::Settings::setImagesEnabled):

  • page/Settings.h:

(Settings):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::setImagesEnabled):
(WebCore):

  • testing/InternalSettings.h:

(InternalSettings):

  • testing/InternalSettings.idl:

Source/WebKit2:

Patch by Bo Liu <boliu@chromium.org> on 2012-09-14
Reviewed by Adam Barth.

Export WebCore::Settings::setImagesEnabled symbol.

  • win/WebKit2.def:

LayoutTests:

Add tests to check autoLoadImages and imagesEnabled can block
images and can reload them in place when setting is set to unblock.

image-permissions tests are updated to reflect that onerror will no
longer be called when images are blocked.

Patch by Bo Liu <boliu@chromium.org> on 2012-09-14
Reviewed by Adam Barth.

  • fast/loader/display-image-unset-can-block-image-and-can-reload-in-place-expected.txt: Added.
  • fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html: Added.
  • fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place-expected.txt: Added.
  • fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html: Added.
  • platform/chromium/http/tests/permissionclient/image-permissions-expected.txt:
  • platform/chromium/permissionclient/image-permissions-expected.txt:
  • platform/chromium/permissionclient/image-permissions.html:
  • platform/chromium/permissionclient/resources/image.html:
1:01 PM Changeset in webkit [128644] by eae@chromium.org
  • 5 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=96226
REGRESSION (r128006): Three spatial navigation tests are failing

Reviewed by Ryosuke Niwa.

Source/WebCore:

Fix spatial navigation regression by reverting parts of r128006.
Specifically the change to remove the overridden boundingBox
method in ContainerNode.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::getUpperLeftCorner):
(WebCore):
(WebCore::ContainerNode::getLowerRightCorner):
(WebCore::ContainerNode::boundingBox):

  • dom/ContainerNode.h:

(ContainerNode):

LayoutTests:

Remove spatial navigation tests from Skipped list.

  • platform/mac/Skipped:
1:00 PM Changeset in webkit [128643] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] add touch area to gestureTapDown data
https://bugs.webkit.org/show_bug.cgi?id=96806

Patch by Rick Byers <rbyers@chromium.org> on 2012-09-14
Reviewed by Adam Barth.

Add width/height for GestureTapDown as for GestureTap/LongPress so that
we can eventually do fuzzing on it.

  • public/WebInputEvent.h:
  • src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

12:49 PM Changeset in webkit [128642] by jamesr@google.com
  • 161 edits in trunk

Unreviewed, rolling out r128627.
http://trac.webkit.org/changeset/128627
https://bugs.webkit.org/show_bug.cgi?id=96575

Breaks indexeddb content_browsertests in chromium

Source/WebCore:

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::IDBDatabase):
(WebCore::IDBDatabase::setVersion):

  • Modules/indexeddb/IDBDatabase.h:

(IDBDatabase):

LayoutTests:

  • http/tests/inspector/indexeddb/database-data-expected.txt:
  • http/tests/inspector/indexeddb/database-structure-expected.txt:
  • http/tests/inspector/indexeddb/resources-panel-expected.txt:
  • storage/indexeddb/create-and-remove-object-store-expected.txt:
  • storage/indexeddb/create-object-store-options-expected.txt:
  • storage/indexeddb/createObjectStore-name-argument-required-expected.txt:
  • storage/indexeddb/createObjectStore-null-name-expected.txt:
  • storage/indexeddb/cursor-added-bug-expected.txt:
  • storage/indexeddb/cursor-advance-expected.txt:
  • storage/indexeddb/cursor-continue-dir-expected.txt:
  • storage/indexeddb/cursor-continue-expected.txt:
  • storage/indexeddb/cursor-continue-validity-expected.txt:
  • storage/indexeddb/cursor-delete-expected.txt:
  • storage/indexeddb/cursor-inconsistency-expected.txt:
  • storage/indexeddb/cursor-index-delete-expected.txt:
  • storage/indexeddb/cursor-key-order-expected.txt:
  • storage/indexeddb/cursor-overloads-expected.txt:
  • storage/indexeddb/cursor-prev-no-duplicate-expected.txt:
  • storage/indexeddb/cursor-primary-key-order-expected.txt:
  • storage/indexeddb/cursor-reverse-bug-expected.txt:
  • storage/indexeddb/cursor-skip-deleted-expected.txt:
  • storage/indexeddb/cursor-update-expected.txt:
  • storage/indexeddb/cursor-update-value-argument-required-expected.txt:
  • storage/indexeddb/cursor-value-expected.txt:
  • storage/indexeddb/data-corruption-expected.txt:
  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/database-close-expected.txt:
  • storage/indexeddb/database-closepending-flag-expected.txt:
  • storage/indexeddb/database-deletepending-flag-expected.txt:
  • storage/indexeddb/delete-closed-database-object-expected.txt:
  • storage/indexeddb/delete-range-expected.txt:
  • storage/indexeddb/deleteIndex-expected.txt:
  • storage/indexeddb/deleteObjectStore-name-argument-required-expected.txt:
  • storage/indexeddb/deleteObjectStore-null-name-expected.txt:
  • storage/indexeddb/deleted-objects-expected.txt:
  • storage/indexeddb/deletedatabase-transaction-expected.txt:
  • storage/indexeddb/duplicates-expected.txt:
  • storage/indexeddb/error-causes-abort-by-default-expected.txt:
  • storage/indexeddb/exception-in-event-aborts-expected.txt:
  • storage/indexeddb/exceptions-expected.txt:
  • storage/indexeddb/factory-deletedatabase-expected.txt:
  • storage/indexeddb/factory-deletedatabase-interactions-expected.txt:
  • storage/indexeddb/get-keyrange-expected.txt:
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics-workers-expected.txt:
  • storage/indexeddb/index-count-expected.txt:
  • storage/indexeddb/index-cursor-expected.txt:
  • storage/indexeddb/index-duplicate-keypaths-expected.txt:
  • storage/indexeddb/index-get-key-argument-required-expected.txt:
  • storage/indexeddb/index-multientry-expected.txt:
  • storage/indexeddb/index-population-expected.txt:
  • storage/indexeddb/index-unique-expected.txt:
  • storage/indexeddb/intversion-and-setversion-expected.txt:
  • storage/indexeddb/intversion-invalid-setversion-has-no-side-effects-expected.txt:
  • storage/indexeddb/intversion-long-queue-expected.txt:
  • storage/indexeddb/invalid-keys-expected.txt:
  • storage/indexeddb/key-generator-expected.txt:
  • storage/indexeddb/key-sort-order-across-types-expected.txt:
  • storage/indexeddb/key-sort-order-date-expected.txt:
  • storage/indexeddb/key-type-array-expected.txt:
  • storage/indexeddb/key-type-infinity-expected.txt:
  • storage/indexeddb/keypath-arrays-expected.txt:
  • storage/indexeddb/keypath-basics-expected.txt:
  • storage/indexeddb/keypath-edges-expected.txt:
  • storage/indexeddb/keypath-fetch-key-expected.txt:
  • storage/indexeddb/keypath-intrinsic-properties-expected.txt:
  • storage/indexeddb/lazy-index-population-expected.txt:
  • storage/indexeddb/legacy-constants-expected.txt:
  • storage/indexeddb/list-ordering-expected.txt:
  • storage/indexeddb/metadata-expected.txt:
  • storage/indexeddb/mozilla/add-twice-failure-expected.txt:
  • storage/indexeddb/mozilla/autoincrement-indexes-expected.txt:
  • storage/indexeddb/mozilla/bad-keypath-expected.txt:
  • storage/indexeddb/mozilla/clear-expected.txt:
  • storage/indexeddb/mozilla/create-index-unique-expected.txt:
  • storage/indexeddb/mozilla/create-index-with-integer-keys-expected.txt:
  • storage/indexeddb/mozilla/create-objectstore-basics-expected.txt:
  • storage/indexeddb/mozilla/create-objectstore-null-name-expected.txt:
  • storage/indexeddb/mozilla/cursor-mutation-expected.txt:
  • storage/indexeddb/mozilla/cursor-mutation-objectstore-only-expected.txt:
  • storage/indexeddb/mozilla/cursor-update-updates-indexes-expected.txt:
  • storage/indexeddb/mozilla/cursors-expected.txt:
  • storage/indexeddb/mozilla/delete-result-expected.txt:
  • storage/indexeddb/mozilla/event-source-expected.txt:
  • storage/indexeddb/mozilla/global-data-expected.txt:
  • storage/indexeddb/mozilla/index-prev-no-duplicate-expected.txt:
  • storage/indexeddb/mozilla/indexes-expected.txt:
  • storage/indexeddb/mozilla/key-requirements-delete-null-key-expected.txt:
  • storage/indexeddb/mozilla/key-requirements-expected.txt:
  • storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt:
  • storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt:
  • storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt:
  • storage/indexeddb/mozilla/object-cursors-expected.txt:
  • storage/indexeddb/mozilla/object-identity-expected.txt:
  • storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put-expected.txt:
  • storage/indexeddb/mozilla/object-store-remove-values-expected.txt:
  • storage/indexeddb/mozilla/objectstorenames-expected.txt:
  • storage/indexeddb/mozilla/odd-result-order-expected.txt:
  • storage/indexeddb/mozilla/put-get-values-expected.txt:
  • storage/indexeddb/mozilla/readonly-transactions-expected.txt:
  • storage/indexeddb/mozilla/readwrite-transactions-expected.txt:
  • storage/indexeddb/mozilla/readyState-expected.txt:
  • storage/indexeddb/mozilla/remove-index-expected.txt:
  • storage/indexeddb/mozilla/remove-objectstore-expected.txt:
  • storage/indexeddb/mozilla/versionchange-abort-expected.txt:
  • storage/indexeddb/mozilla/versionchange-expected.txt:
  • storage/indexeddb/mutating-cursor-expected.txt:
  • storage/indexeddb/noblobs-expected.txt:
  • storage/indexeddb/objectStore-required-arguments-expected.txt:
  • storage/indexeddb/objectstore-autoincrement-expected.txt:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics-workers-expected.txt:
  • storage/indexeddb/objectstore-clear-expected.txt:
  • storage/indexeddb/objectstore-count-expected.txt:
  • storage/indexeddb/objectstore-cursor-expected.txt:
  • storage/indexeddb/objectstore-removeobjectstore-expected.txt:
  • storage/indexeddb/odd-strings-expected.txt:
  • storage/indexeddb/open-close-version-expected.txt:
  • storage/indexeddb/open-cursor-expected.txt:
  • storage/indexeddb/open-during-transaction-expected.txt:
  • storage/indexeddb/opencursor-key-expected.txt:
  • storage/indexeddb/pending-activity-expected.txt:
  • storage/indexeddb/pending-activity-workers-expected.txt:
  • storage/indexeddb/pending-version-change-on-exit-expected.txt:
  • storage/indexeddb/persistence-expected.txt:
  • storage/indexeddb/prefetch-bugfix-108071-expected.txt:
  • storage/indexeddb/queued-commands-expected.txt:
  • storage/indexeddb/readonly-expected.txt:
  • storage/indexeddb/readonly-properties-expected.txt:
  • storage/indexeddb/request-continue-abort-expected.txt:
  • storage/indexeddb/request-event-propagation-expected.txt:
  • storage/indexeddb/setVersion-null-expected.txt:
  • storage/indexeddb/set_version_blocked-expected.txt:
  • storage/indexeddb/set_version_queue-expected.txt:
  • storage/indexeddb/structured-clone-expected.txt:
  • storage/indexeddb/three-setversion-calls-expected.txt:
  • storage/indexeddb/transaction-abort-expected.txt:
  • storage/indexeddb/transaction-active-flag-expected.txt:
  • storage/indexeddb/transaction-after-close-expected.txt:
  • storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-complete-with-js-recursion-cross-frame-expected.txt:
  • storage/indexeddb/transaction-complete-with-js-recursion-expected.txt:
  • storage/indexeddb/transaction-complete-workers-expected.txt:
  • storage/indexeddb/transaction-crash-on-abort-expected.txt:
  • storage/indexeddb/transaction-error-expected.txt:
  • storage/indexeddb/transaction-event-propagation-expected.txt:
  • storage/indexeddb/transaction-read-only-expected.txt:
  • storage/indexeddb/transaction-rollback-expected.txt:
  • storage/indexeddb/transaction-storeNames-required-expected.txt:
  • storage/indexeddb/tutorial-expected.txt:
  • storage/indexeddb/two-version-changes-expected.txt:
  • storage/indexeddb/value-undefined-expected.txt:
  • storage/indexeddb/values-odd-types-expected.txt:
  • storage/indexeddb/version-change-abort-expected.txt:
  • storage/indexeddb/version-change-exclusive-expected.txt:
  • storage/indexeddb/versionchangerequest-activedomobject-expected.txt:
12:31 PM Changeset in webkit [128641] by Alexandru Chiculita
  • 4 edits in trunk/Source/WebCore

[CSS Shaders] Refactor FECustomFilter to make it usable from platform dependent implementations
https://bugs.webkit.org/show_bug.cgi?id=96801

Reviewed by Dean Jackson.

I've refactored the FECustomFilter to allow FECustomFilterSkia.cpp to use the rendering part
from outside.

Also removed the Texture class as it is not available on some platforms.

The changes for Skia will land in a different patch:
https://bugs.webkit.org/show_bug.cgi?id=96579

No new tests, the existing custom filters tests should already cover this.

  • platform/graphics/filters/CustomFilterGlobalContext.cpp:

(WebCore::CustomFilterGlobalContext::prepareContextIfNeeded):

  • platform/graphics/filters/FECustomFilter.cpp:

(WebCore::FECustomFilter::FECustomFilter):
(WebCore::FECustomFilter::deleteRenderBuffers):
(WebCore::FECustomFilter::drawFilterMesh):
(WebCore):
(WebCore::FECustomFilter::prepareForDrawing):
(WebCore::FECustomFilter::programNeedsInputTexture):
(WebCore::FECustomFilter::applyShader):
(WebCore::FECustomFilter::initializeContext):
(WebCore::FECustomFilter::ensureInputTexture):
(WebCore::FECustomFilter::uploadInputTexture):
(WebCore::FECustomFilter::ensureFrameBuffer):
(WebCore::FECustomFilter::resizeContextIfNeeded):
(WebCore::FECustomFilter::resizeContext):
(WebCore::FECustomFilter::bindProgramAndBuffers):

  • platform/graphics/filters/FECustomFilter.h:

(FECustomFilter):

12:22 PM Changeset in webkit [128640] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Comment out bug URL. This fixes a lint warning.

  • platform/qt/Skipped:
12:19 PM Changeset in webkit [128639] by ojan@chromium.org
  • 2 edits
    58 adds in trunk/LayoutTests

Update all the MISSING lines in chromium's TestExpectations.
If the test always passed, removed the line. In some cases, they just needed
obvious rebaselines. In others, they haven't reported MISSING in the past
500 runs on the bots, so removed that expectation.

  • platform/chromium-linux-x86/fast/overflow/paged-x-div-with-column-gap-expected.txt: Added.
  • platform/chromium-linux-x86/fast/overflow/paged-x-with-column-gap-expected.txt: Added.
  • platform/chromium-linux/css3/masking/clip-path-circle-expected.png: Added.
  • platform/chromium-linux/css3/masking/clip-path-circle-filter-expected.png: Added.
  • platform/chromium-linux/css3/masking/clip-path-circle-overflow-expected.png: Added.
  • platform/chromium-linux/css3/masking/clip-path-circle-overflow-hidden-expected.png: Added.
  • platform/chromium-linux/css3/masking/clip-path-circle-relative-overflow-expected.png: Added.
  • platform/chromium-linux/css3/masking/clip-path-ellipse-expected.png: Added.
  • platform/chromium-linux/css3/masking/clip-path-polygon-evenodd-expected.png: Added.
  • platform/chromium-linux/css3/masking/clip-path-polygon-expected.png: Added.
  • platform/chromium-linux/css3/masking/clip-path-polygon-nonzero-expected.png: Added.
  • platform/chromium-linux/css3/masking/clip-path-rectangle-expected.png: Added.
  • platform/chromium-linux/fast/overflow/paged-x-div-with-column-gap-expected.png: Added.
  • platform/chromium-linux/fast/overflow/paged-x-div-with-column-gap-expected.txt: Added.
  • platform/chromium-linux/fast/overflow/paged-x-with-column-gap-expected.png: Added.
  • platform/chromium-linux/fast/overflow/paged-x-with-column-gap-expected.txt: Added.
  • platform/chromium-linux/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/frames/iframe-scaling-with-scroll-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/overflow/paged-x-div-with-column-gap-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/overflow/paged-x-with-column-gap-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.png: Added.
  • platform/chromium-mac/css3/masking/clip-path-circle-expected.png: Added.
  • platform/chromium-mac/css3/masking/clip-path-circle-filter-expected.png: Added.
  • platform/chromium-mac/css3/masking/clip-path-circle-overflow-expected.png: Added.
  • platform/chromium-mac/css3/masking/clip-path-circle-overflow-hidden-expected.png: Added.
  • platform/chromium-mac/css3/masking/clip-path-circle-relative-overflow-expected.png: Added.
  • platform/chromium-mac/css3/masking/clip-path-ellipse-expected.png: Added.
  • platform/chromium-mac/css3/masking/clip-path-polygon-evenodd-expected.png: Added.
  • platform/chromium-mac/css3/masking/clip-path-polygon-expected.png: Added.
  • platform/chromium-mac/css3/masking/clip-path-polygon-nonzero-expected.png: Added.
  • platform/chromium-mac/css3/masking/clip-path-rectangle-expected.png: Added.
  • platform/chromium-mac/fast/frames/iframe-scaling-with-scroll-expected.png: Added.
  • platform/chromium-mac/fast/overflow/paged-x-div-with-column-gap-expected.png: Added.
  • platform/chromium-mac/fast/overflow/paged-x-with-column-gap-expected.png: Added.
  • platform/chromium-win-xp/fast/overflow/paged-x-div-with-column-gap-expected.txt: Added.
  • platform/chromium-win-xp/fast/overflow/paged-x-with-column-gap-expected.txt: Added.
  • platform/chromium-win/css3/masking/clip-path-circle-expected.png: Added.
  • platform/chromium-win/css3/masking/clip-path-circle-filter-expected.png: Added.
  • platform/chromium-win/css3/masking/clip-path-circle-overflow-expected.png: Added.
  • platform/chromium-win/css3/masking/clip-path-circle-overflow-hidden-expected.png: Added.
  • platform/chromium-win/css3/masking/clip-path-circle-relative-overflow-expected.png: Added.
  • platform/chromium-win/css3/masking/clip-path-ellipse-expected.png: Added.
  • platform/chromium-win/css3/masking/clip-path-polygon-evenodd-expected.png: Added.
  • platform/chromium-win/css3/masking/clip-path-polygon-expected.png: Added.
  • platform/chromium-win/css3/masking/clip-path-polygon-nonzero-expected.png: Added.
  • platform/chromium-win/css3/masking/clip-path-rectangle-expected.png: Added.
  • platform/chromium-win/fast/frames/iframe-scaling-with-scroll-expected.png: Added.
  • platform/chromium-win/fast/overflow/paged-x-div-with-column-gap-expected.png: Added.
  • platform/chromium-win/fast/overflow/paged-x-div-with-column-gap-expected.txt: Added.
  • platform/chromium-win/fast/overflow/paged-x-with-column-gap-expected.png: Added.
  • platform/chromium-win/fast/overflow/paged-x-with-column-gap-expected.txt: Added.
  • platform/chromium-win/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.png: Added.
  • platform/chromium-win/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt: Added.
  • platform/chromium/TestExpectations:
  • platform/chromium/perf/nested-combined-selectors-expected.txt: Added.
12:08 PM Changeset in webkit [128638] by ap@apple.com
  • 2 edits in trunk/Tools

[WK2] webarchive/loading/javascript-url-iframe-crash.html fails
https://bugs.webkit.org/show_bug.cgi?id=96817

Reviewed by Kenneth Rohde Christiansen.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): This callback got overlooked when adding logging elsewhere.
12:04 PM Changeset in webkit [128637] by ap@apple.com
  • 13 edits in trunk/Source/WebCore

REGRESSION(r126717): It made inspector/styles/media-queries.html fail/flakey
https://bugs.webkit.org/show_bug.cgi?id=95070

Roll out r126717, and another change that depends on it.
r126717: Remove parent pointer from StyleSheetContents and StyleRuleImport
r127123: Cache and share parsed imported stylesheets

  • css/CSSImportRule.cpp:
  • css/CSSImportRule.h:
  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::willMutateRules): (WebCore::CSSStyleSheet::reattachChildRuleCSSOMWrappers): (WebCore::CSSStyleSheet::insertRule): (WebCore::CSSStyleSheet::ownerDocument):
  • css/CSSStyleSheet.h: (WebCore::CSSStyleSheet::clearOwnerRule):
  • css/StyleRuleImport.cpp: (WebCore::StyleRuleImport::StyleRuleImport): (WebCore::StyleRuleImport::~StyleRuleImport): (WebCore::StyleRuleImport::setCSSStyleSheet): (WebCore::StyleRuleImport::isLoading): (WebCore::StyleRuleImport::requestStyleSheet):
  • css/StyleRuleImport.h: (WebCore::StyleRuleImport::parentStyleSheet): (WebCore::StyleRuleImport::setParentStyleSheet): (WebCore::StyleRuleImport::clearParentStyleSheet): (ImportedStyleSheetClient): (WebCore::StyleRuleImport::ImportedStyleSheetClient::ImportedStyleSheetClient): (WebCore::StyleRuleImport::ImportedStyleSheetClient::~ImportedStyleSheetClient): (WebCore::StyleRuleImport::ImportedStyleSheetClient::setCSSStyleSheet):
  • css/StyleSheetContents.cpp: (WebCore::StyleSheetContents::StyleSheetContents): (WebCore::StyleSheetContents::isCacheable): (WebCore::StyleSheetContents::parserAppendRule): (WebCore::StyleSheetContents::clearRules): (WebCore::StyleSheetContents::wrapperInsertRule): (WebCore::StyleSheetContents::wrapperDeleteRule): (WebCore::StyleSheetContents::parseAuthorStyleSheet): (WebCore::StyleSheetContents::parseStringAtLine): (WebCore::StyleSheetContents::checkLoaded): (WebCore::StyleSheetContents::notifyLoadedSheet): (WebCore::StyleSheetContents::startLoadingDynamicSheet): (WebCore::StyleSheetContents::rootStyleSheet): (WebCore::StyleSheetContents::singleOwnerNode): (WebCore::StyleSheetContents::singleOwnerDocument): (WebCore::StyleSheetContents::parentStyleSheet):
  • css/StyleSheetContents.h: (WebCore::StyleSheetContents::create): (StyleSheetContents): (WebCore::StyleSheetContents::ownerRule): (WebCore::StyleSheetContents::clearOwnerRule):
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::parseStyleSheet):
  • dom/StyleElement.cpp: (WebCore::StyleElement::createSheet):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::setCSSStyleSheet):
  • loader/cache/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::saveParsedStyleSheet):
11:53 AM Changeset in webkit [128636] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL] RefPtr<Evas_Object> unit tests fails
https://bugs.webkit.org/show_bug.cgi?id=96809

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-14
Reviewed by Kenneth Rohde Christiansen.

Added missing return.

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:

(EWK2UnitTest::EWK2UnitTestBase::canvas):

11:52 AM Changeset in webkit [128635] by ojan@chromium.org
  • 2 edits
    3 copies
    1 move
    1 add in trunk/LayoutTests

Complete forgotten rebaseline. See https://bugs.webkit.org/show_bug.cgi?id=96751.
The results all look like they pass.

  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt.
  • platform/chromium-win-xp/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt.
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt.
11:48 AM Changeset in webkit [128634] by ojan@chromium.org
  • 4 edits
    6 adds
    1 delete in trunk/LayoutTests

Complete some forgotten rebaselines. See https://bugs.webkit.org/show_bug.cgi?id=94916.
All the differences were anti-aliasing/form-controls.

  • platform/chromium-linux/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
  • platform/chromium-linux/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png: Added.
  • platform/chromium-linux/fast/forms/datalist/input-appearance-range-with-transform-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/datalist/input-appearance-range-with-transform-expected.png: Added.
  • platform/chromium-win-xp/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png: Removed.
  • platform/chromium-win/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
  • platform/chromium-win/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png: Added.
  • platform/chromium-win/fast/forms/datalist/input-appearance-range-with-transform-expected.png: Added.
  • platform/chromium/TestExpectations:
11:42 AM Changeset in webkit [128633] by ojan@chromium.org
  • 3 edits in trunk/Source/WebCore

Simplify some code in RenderBox::computePercentageLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=96704

Reviewed by Tony Chang.

This is strictly code cleanup. No behavior change.
Also removed some comments that were what comments and/or were
getting stale.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::skipContainingBlockForPercentHeightCalculation):
(WebCore):
(WebCore::RenderBox::computePercentageLogicalHeight):

  • rendering/RenderBox.h:

(RenderBox):

11:26 AM Changeset in webkit [128632] by peter@chromium.org
  • 2 edits in trunk/Tools

[Chromium] Build fix for DumpRenderTree following r128628
https://bugs.webkit.org/show_bug.cgi?id=96808

Reviewed by Tony Chang.

When building DumpRenderTree from the Chromium project, a compile error
shows up because including the header ForwardIOStreamsAndroid.h cannot
be located. TestWebKitAPI does this correctly.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
11:20 AM Changeset in webkit [128631] by danakj@chromium.org
  • 3 edits in trunk/Tools

Change cc-bugs@google.com watchlist to cc-bugs@chromium.org
https://bugs.webkit.org/show_bug.cgi?id=96805

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/common/config/committers.py:
  • Scripts/webkitpy/common/config/watchlist:
10:59 AM Changeset in webkit [128630] by danakj@chromium.org
  • 3 edits
    1 add in trunk/Source/Platform

[chromium] Add the ubercomp WebDelegatedRendererLayer
https://bugs.webkit.org/show_bug.cgi?id=94145

Reviewed by Adrienne Walker.

Expose a WebDelegatedRendererLayer to allow the browser compositor to
embed such a layer in its tree. This layer will be connected to IPC
machinery in the compositor that is yet TBD which will give a set of
RenderPasses with DrawQuads to the impl copy of the layer.

  • Platform.gypi:
  • chromium/public/WebCompositorSupport.h:

(WebKit):
(WebKit::WebCompositorSupport::createDelegatedRendererLayer):
(WebCompositorSupport):

  • chromium/public/WebDelegatedRendererLayer.h: Added.

(WebKit):
(WebDelegatedRendererLayer):
(WebKit::WebDelegatedRendererLayer::~WebDelegatedRendererLayer):

10:54 AM Changeset in webkit [128629] by tkent@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, a workaround for a mysterious crash on Apple Windows port.
https://bugs.webkit.org/show_bug.cgi?id=96636

  • testing/InternalSettings.cpp:

Touch RuntimeEnabledFeatures::langAttributeAwareFormControlUIEnabled only if
ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS)
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setLangAttributeAwareFormControlUIEnabled):

  • testing/InternalSettings.h:

(Backup):

10:37 AM Changeset in webkit [128628] by peter@chromium.org
  • 7 edits
    1 copy
    1 add in trunk

[Chromium] Support the --{in,out,err}-fifo arguments on TestWebKitAPI and webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=96687

Reviewed by Tony Chang.

Android's DumpRenderTree currently supports these arguments, implemented
as part of TestShellAndroid:
http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp?rev=128496

They're used by the layout test runner to get the STDOUT and STDERR while
a layout test run is in process, which is a safer alternative to parsing
all the logcat output manually. The implementation can be seen here:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py?rev=128496#L590

This patch generalizes parsing of and applying the effects of these arguments
so that they can be used for TestWebKitAPI and webkit_unit_tests as well.
After this patch, this will make it possible to pull out the output-reading
code from Android's layout test port and generalize it so it can be re-used
in the new test-runner for the other two test suites.

This has no effect when compiling and running these tests as part of Chromium
code, which has a much more advanced test-runner that does parse complete log
output, but also directly depends on code licensed under Apache 2.

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/ForwardIOStreamsAndroid.cpp: Added.

(WebKit):
(WebKit::maybeInitIOStreamForwardingForAndroid):

  • tests/ForwardIOStreamsAndroid.h: Added.

(WebKit):

  • tests/RunAllTests.cpp:

(main):

Tools:

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • DumpRenderTree/chromium/TestShellAndroid.cpp:

(platformInit):

  • TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
10:28 AM Changeset in webkit [128627] by dgrogan@chromium.org
  • 161 edits in trunk

IndexedDB: Print console warning about setVersion
https://bugs.webkit.org/show_bug.cgi?id=96575

Reviewed by Tony Chang.

Source/WebCore:

setVersion has been out of the spec for almost a year but there are
still a lot of users.

We show the warning once per database object as an approximation for
once per page.

No new tests, but 150-something rebaselines.

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::IDBDatabase):
(WebCore::IDBDatabase::setVersion):

  • Modules/indexeddb/IDBDatabase.h:

(IDBDatabase):

LayoutTests:

  • http/tests/inspector/indexeddb/database-data-expected.txt:
  • http/tests/inspector/indexeddb/database-structure-expected.txt:
  • http/tests/inspector/indexeddb/resources-panel-expected.txt:
  • storage/indexeddb/create-and-remove-object-store-expected.txt:
  • storage/indexeddb/create-object-store-options-expected.txt:
  • storage/indexeddb/createObjectStore-name-argument-required-expected.txt:
  • storage/indexeddb/createObjectStore-null-name-expected.txt:
  • storage/indexeddb/cursor-added-bug-expected.txt:
  • storage/indexeddb/cursor-advance-expected.txt:
  • storage/indexeddb/cursor-continue-dir-expected.txt:
  • storage/indexeddb/cursor-continue-expected.txt:
  • storage/indexeddb/cursor-continue-validity-expected.txt:
  • storage/indexeddb/cursor-delete-expected.txt:
  • storage/indexeddb/cursor-inconsistency-expected.txt:
  • storage/indexeddb/cursor-index-delete-expected.txt:
  • storage/indexeddb/cursor-key-order-expected.txt:
  • storage/indexeddb/cursor-overloads-expected.txt:
  • storage/indexeddb/cursor-prev-no-duplicate-expected.txt:
  • storage/indexeddb/cursor-primary-key-order-expected.txt:
  • storage/indexeddb/cursor-reverse-bug-expected.txt:
  • storage/indexeddb/cursor-skip-deleted-expected.txt:
  • storage/indexeddb/cursor-update-expected.txt:
  • storage/indexeddb/cursor-update-value-argument-required-expected.txt:
  • storage/indexeddb/cursor-value-expected.txt:
  • storage/indexeddb/data-corruption-expected.txt:
  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/database-close-expected.txt:
  • storage/indexeddb/database-closepending-flag-expected.txt:
  • storage/indexeddb/database-deletepending-flag-expected.txt:
  • storage/indexeddb/delete-closed-database-object-expected.txt:
  • storage/indexeddb/delete-range-expected.txt:
  • storage/indexeddb/deleteIndex-expected.txt:
  • storage/indexeddb/deleteObjectStore-name-argument-required-expected.txt:
  • storage/indexeddb/deleteObjectStore-null-name-expected.txt:
  • storage/indexeddb/deleted-objects-expected.txt:
  • storage/indexeddb/deletedatabase-transaction-expected.txt:
  • storage/indexeddb/duplicates-expected.txt:
  • storage/indexeddb/error-causes-abort-by-default-expected.txt:
  • storage/indexeddb/exception-in-event-aborts-expected.txt:
  • storage/indexeddb/exceptions-expected.txt:
  • storage/indexeddb/factory-deletedatabase-expected.txt:
  • storage/indexeddb/factory-deletedatabase-interactions-expected.txt:
  • storage/indexeddb/get-keyrange-expected.txt:
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics-workers-expected.txt:
  • storage/indexeddb/index-count-expected.txt:
  • storage/indexeddb/index-cursor-expected.txt:
  • storage/indexeddb/index-duplicate-keypaths-expected.txt:
  • storage/indexeddb/index-get-key-argument-required-expected.txt:
  • storage/indexeddb/index-multientry-expected.txt:
  • storage/indexeddb/index-population-expected.txt:
  • storage/indexeddb/index-unique-expected.txt:
  • storage/indexeddb/intversion-and-setversion-expected.txt:
  • storage/indexeddb/intversion-invalid-setversion-has-no-side-effects-expected.txt:
  • storage/indexeddb/intversion-long-queue-expected.txt:
  • storage/indexeddb/invalid-keys-expected.txt:
  • storage/indexeddb/key-generator-expected.txt:
  • storage/indexeddb/key-sort-order-across-types-expected.txt:
  • storage/indexeddb/key-sort-order-date-expected.txt:
  • storage/indexeddb/key-type-array-expected.txt:
  • storage/indexeddb/key-type-infinity-expected.txt:
  • storage/indexeddb/keypath-arrays-expected.txt:
  • storage/indexeddb/keypath-basics-expected.txt:
  • storage/indexeddb/keypath-edges-expected.txt:
  • storage/indexeddb/keypath-fetch-key-expected.txt:
  • storage/indexeddb/keypath-intrinsic-properties-expected.txt:
  • storage/indexeddb/lazy-index-population-expected.txt:
  • storage/indexeddb/legacy-constants-expected.txt:
  • storage/indexeddb/list-ordering-expected.txt:
  • storage/indexeddb/metadata-expected.txt:
  • storage/indexeddb/mozilla/add-twice-failure-expected.txt:
  • storage/indexeddb/mozilla/autoincrement-indexes-expected.txt:
  • storage/indexeddb/mozilla/bad-keypath-expected.txt:
  • storage/indexeddb/mozilla/clear-expected.txt:
  • storage/indexeddb/mozilla/create-index-unique-expected.txt:
  • storage/indexeddb/mozilla/create-index-with-integer-keys-expected.txt:
  • storage/indexeddb/mozilla/create-objectstore-basics-expected.txt:
  • storage/indexeddb/mozilla/create-objectstore-null-name-expected.txt:
  • storage/indexeddb/mozilla/cursor-mutation-expected.txt:
  • storage/indexeddb/mozilla/cursor-mutation-objectstore-only-expected.txt:
  • storage/indexeddb/mozilla/cursor-update-updates-indexes-expected.txt:
  • storage/indexeddb/mozilla/cursors-expected.txt:
  • storage/indexeddb/mozilla/delete-result-expected.txt:
  • storage/indexeddb/mozilla/event-source-expected.txt:
  • storage/indexeddb/mozilla/global-data-expected.txt:
  • storage/indexeddb/mozilla/index-prev-no-duplicate-expected.txt:
  • storage/indexeddb/mozilla/indexes-expected.txt:
  • storage/indexeddb/mozilla/key-requirements-delete-null-key-expected.txt:
  • storage/indexeddb/mozilla/key-requirements-expected.txt:
  • storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt:
  • storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt:
  • storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt:
  • storage/indexeddb/mozilla/object-cursors-expected.txt:
  • storage/indexeddb/mozilla/object-identity-expected.txt:
  • storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put-expected.txt:
  • storage/indexeddb/mozilla/object-store-remove-values-expected.txt:
  • storage/indexeddb/mozilla/objectstorenames-expected.txt:
  • storage/indexeddb/mozilla/odd-result-order-expected.txt:
  • storage/indexeddb/mozilla/put-get-values-expected.txt:
  • storage/indexeddb/mozilla/readonly-transactions-expected.txt:
  • storage/indexeddb/mozilla/readwrite-transactions-expected.txt:
  • storage/indexeddb/mozilla/readyState-expected.txt:
  • storage/indexeddb/mozilla/remove-index-expected.txt:
  • storage/indexeddb/mozilla/remove-objectstore-expected.txt:
  • storage/indexeddb/mozilla/versionchange-abort-expected.txt:
  • storage/indexeddb/mozilla/versionchange-expected.txt:
  • storage/indexeddb/mutating-cursor-expected.txt:
  • storage/indexeddb/noblobs-expected.txt:
  • storage/indexeddb/objectStore-required-arguments-expected.txt:
  • storage/indexeddb/objectstore-autoincrement-expected.txt:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics-workers-expected.txt:
  • storage/indexeddb/objectstore-clear-expected.txt:
  • storage/indexeddb/objectstore-count-expected.txt:
  • storage/indexeddb/objectstore-cursor-expected.txt:
  • storage/indexeddb/objectstore-removeobjectstore-expected.txt:
  • storage/indexeddb/odd-strings-expected.txt:
  • storage/indexeddb/open-close-version-expected.txt:
  • storage/indexeddb/open-cursor-expected.txt:
  • storage/indexeddb/open-during-transaction-expected.txt:
  • storage/indexeddb/opencursor-key-expected.txt:
  • storage/indexeddb/pending-activity-expected.txt:
  • storage/indexeddb/pending-activity-workers-expected.txt:
  • storage/indexeddb/pending-version-change-on-exit-expected.txt:
  • storage/indexeddb/persistence-expected.txt:
  • storage/indexeddb/prefetch-bugfix-108071-expected.txt:
  • storage/indexeddb/queued-commands-expected.txt:
  • storage/indexeddb/readonly-expected.txt:
  • storage/indexeddb/readonly-properties-expected.txt:
  • storage/indexeddb/request-continue-abort-expected.txt:
  • storage/indexeddb/request-event-propagation-expected.txt:
  • storage/indexeddb/setVersion-null-expected.txt:
  • storage/indexeddb/set_version_blocked-expected.txt:
  • storage/indexeddb/set_version_queue-expected.txt:
  • storage/indexeddb/structured-clone-expected.txt:
  • storage/indexeddb/three-setversion-calls-expected.txt:
  • storage/indexeddb/transaction-abort-expected.txt:
  • storage/indexeddb/transaction-active-flag-expected.txt:
  • storage/indexeddb/transaction-after-close-expected.txt:
  • storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-complete-with-js-recursion-cross-frame-expected.txt:
  • storage/indexeddb/transaction-complete-with-js-recursion-expected.txt:
  • storage/indexeddb/transaction-complete-workers-expected.txt:
  • storage/indexeddb/transaction-crash-on-abort-expected.txt:
  • storage/indexeddb/transaction-error-expected.txt:
  • storage/indexeddb/transaction-event-propagation-expected.txt:
  • storage/indexeddb/transaction-read-only-expected.txt:
  • storage/indexeddb/transaction-rollback-expected.txt:
  • storage/indexeddb/transaction-storeNames-required-expected.txt:
  • storage/indexeddb/tutorial-expected.txt:
  • storage/indexeddb/two-version-changes-expected.txt:
  • storage/indexeddb/value-undefined-expected.txt:
  • storage/indexeddb/values-odd-types-expected.txt:
  • storage/indexeddb/version-change-abort-expected.txt:
  • storage/indexeddb/version-change-exclusive-expected.txt:
  • storage/indexeddb/versionchangerequest-activedomobject-expected.txt:
10:17 AM Changeset in webkit [128626] by Michelangelo De Simone
  • 18 edits
    1 copy
    3 adds in trunk

Use arrays in shaders
https://bugs.webkit.org/show_bug.cgi?id=95223

Reviewed by Dean Jackson.

Source/WebCore:

Custom Filters' support for array() is introduced. Values within
the array() function will be passed as uniforms to shaders.

Values within array() are comma-separated; the specification will be
updated accordingly: https://www.w3.org/Bugs/Public/show_bug.cgi?id=18839

Test: css3/filters/custom/custom-filter-array.html

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForCustomFilterArrayParameter):
(WebCore):
(WebCore::valueForCustomFilterParameter):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

  • css/StyleResolver.h:

(StyleResolver):

  • platform/graphics/filters/CustomFilterArrayParameter.h: Container for array()

parameter values.
(WebCore):
(CustomFilterArrayParameter):
(WebCore::CustomFilterArrayParameter::create):
(WebCore::CustomFilterArrayParameter::size):
(WebCore::CustomFilterArrayParameter::valueAt):
(WebCore::CustomFilterArrayParameter::addValue):
(WebCore::CustomFilterArrayParameter::blend):
(WebCore::CustomFilterArrayParameter::operator==):
(WebCore::CustomFilterArrayParameter::CustomFilterArrayParameter):

  • platform/graphics/filters/CustomFilterParameter.h:
  • platform/graphics/filters/FECustomFilter.cpp:

(WebCore::FECustomFilter::bindProgramArrayParameters):
(WebCore):
(WebCore::FECustomFilter::bindProgramParameters):

  • platform/graphics/filters/FECustomFilter.h:

(WebCore):
(FECustomFilter):

LayoutTests:

New tests have been added for checking the correctness of array()
within shaders.

  • css3/filters/custom/custom-filter-array-expected.html: Added.
  • css3/filters/custom/custom-filter-array.html: Added.
  • css3/filters/custom/custom-filter-property-computed-style-expected.txt:
  • css3/filters/custom/custom-filter-property-parsing-invalid-expected.txt:
  • css3/filters/resources/fragment-color.fs: Added.
  • css3/filters/script-tests/custom-filter-property-computed-style.js:
  • css3/filters/script-tests/custom-filter-property-parsing-invalid.js:
  • platform/chromium/css3/filters/custom/custom-filter-property-computed-style-expected.txt:
10:09 AM Changeset in webkit [128625] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

Always send mouse events on pages that don't scroll even if there
is no mouse move listener attatched.
PR #208228
https://bugs.webkit.org/show_bug.cgi?id=96800

Patch by Genevieve Mak <gmak@rim.com> on 2012-09-14
Reviewed by Antonio Gomes.

Reviewed Internally By Antonio Gomes.

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):

10:05 AM Changeset in webkit [128624] by zoltan@webkit.org
  • 3 edits in trunk/Tools

check-webkit-style should not warn in case of NONCOPYABLE and FAST_ALLOCATED macros
https://bugs.webkit.org/show_bug.cgi?id=96656

Reviewed by Adam Barth.

We should allow to use WTF_MAKE_NONCOPYABLE(ClassName) and WTF_MAKE_FAST_ALLOCATED
macros in 1 line.

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_style.definitions):
(check_style): Add rule.

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(WebKitStyleTest.test_line_breaking): Add unittest.

9:59 AM Changeset in webkit [128623] by commit-queue@webkit.org
  • 16 edits in trunk

WebKitTestRunner needs layoutTestController.dumpDatabaseCallbacks
https://bugs.webkit.org/show_bug.cgi?id=57570

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-14
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add new didExceedDatabaseQuota callback to WKBundlePageUIClient
and call it from WebChromeClient::exceededDatabaseQuota().
This is needed by WebKitTestRunner to dump information about
database callbacks.

  • Shared/APIClientTraits.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setDatabaseQuota): Call WebDatabaseManager::setQuotaForOrigin()
with "file0" instead of "file:///" as origin identifier. WebDatabaseManager expects
a database identifier, not a string representation of the security origin. "file
0" is
the string that is used as databaseIdentifier of local files. This bug was causing the
database quota not to be set. The test cases would therefore fail due to the quota being
0 instead of the value explicitly set.

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::didExceedDatabaseQuota):
(WebKit):

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:

(InjectedBundlePageUIClient):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::exceededDatabaseQuota):

Tools:

Implement testRunner.dumpDatabaseCallbacks in WebKitTestRunner
and dump the information expected by the test cases.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting): Explicitly set the default
database quota.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::securityOriginToStr): New convenience function to convert
a security origin to the string expected in test results.
(WTR):
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::didExceedDatabaseQuota):
(WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota): Minor
refactoring to share code with didExceedDatabaseQuota.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

(InjectedBundlePage):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::TestRunner):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(WTR::TestRunner::dumpDatabaseCallbacks):
(WTR::TestRunner::shouldDumpDatabaseCallbacks):
(TestRunner):

LayoutTests:

Unskip several test cases which require implementation of
testRunner.dumpDatabaseCallbacks in WebKitTestRunner.

  • platform/wk2/Skipped:
9:58 AM Changeset in webkit [128622] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Update the minimum zoom scale when focusing an input field.
https://bugs.webkit.org/show_bug.cgi?id=96789

Reviewed by Antonio Gomes.

PR 188751.

Increase the minimum font fix and base it on mm instead of pixels.

Reviewed Internally by Gen Mak.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):

9:55 AM Changeset in webkit [128621] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening of the WK2 Debug Bot failing tests
https://bugs.webkit.org/show_bug.cgi?id=96795

Unreviewed EFL gardening.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-14

  • platform/efl-wk2/TestExpectations:
9:30 AM Changeset in webkit [128620] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] [WK2] Unreviewed gardening.

Added a bunch of tests failing in the WK2 tests bot to the Skipped
list with the proper links to each bug.

  • platform/gtk-wk2/Skipped:
9:27 AM Changeset in webkit [128619] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Set force_static_libs_as_shared early enough to be caught by configure

Rubber-stamped by Simon Hausmann.

9:21 AM Changeset in webkit [128618] by vestbo@webkit.org
  • 6 edits in trunk

[Qt] Remove old cruft from the qmake build system

Rubber-stamped by Simon Hausmann.

8:58 AM Changeset in webkit [128617] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Enable force_static_libs_as_shared for development

Not enabled for buildbots or production-builds (part of Qt5)

Reviewed by Simon Hausmann.

8:58 AM Changeset in webkit [128616] by vestbo@webkit.org
  • 11 edits in trunk

[Qt] Make force_static_libs_as_shared work on Mac OS

We had to move a few LIBS += around that were in the wrong place,
and not caught when everything was just linked into the final
QtWebKit library.

Reviewed by Simon Hausmann.

8:55 AM Changeset in webkit [128615] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Gesture events sent to wrong node when page is scrolled
https://bugs.webkit.org/show_bug.cgi?id=96788

Patch by Rick Byers <rbyers@chromium.org> on 2012-09-14
Reviewed by Antonio Gomes.

Source/WebCore:

Adjust the co-ordinate space correctly when doing hit testing for
gesture events (as for all other event handling code here).

Test: platform/chromium/plugins/gesture-events-scrolled.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):

LayoutTests:

Add layout test based on gesture-events.html which tests the case when
the document is scrolled (so that client co-ordinates don't equal page
co-ordinates).

  • platform/chromium/plugins/gesture-events-scrolled-expected.txt: Added.
  • platform/chromium/plugins/gesture-events-scrolled.html: Added.
8:47 AM Changeset in webkit [128614] by Simon Hausmann
  • 2 edits in trunk/Tools

[Qt] Fix handling of debug/release/debug_and_release/build_all

We now pick up the defaults from Qt, in default_pre (CONFIG already
contains the appropriate values for debug and release). We then let
the command line arguments to qmake, or the project files themselves,
override the configuration, and finally we sanitize the configuration
in default_post.

Patch by Tor Arne Vestbø <tor.arne.vestbo@nokia.com> on 2012-09-14
Reviewed by Simon Hausmann.

  • Source/api.pri:
8:38 AM Changeset in webkit [128613] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL][WK2] Unskip test cases that are now passing
https://bugs.webkit.org/show_bug.cgi?id=96762

Unreviewed EFL gardening, unskip now passing tests.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-14

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
8:18 AM Changeset in webkit [128612] by commit-queue@webkit.org
  • 12 edits in trunk

WebKitTestRunner needs layoutTestController.setStopProvisionalFrameLoads
https://bugs.webkit.org/show_bug.cgi?id=42691

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-14
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add WKBundleFrame private API to stop loading of a frame.
This is needed by WebKitTestRunner to implement
testrunner.setStopProvisionalFrameLoads.

Original patch by Alexey Proskuryakov.

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameStopLoading):

  • WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::stopLoading):
(WebKit):

  • WebProcess/WebPage/WebFrame.h:

(WebFrame):

Tools:

Add implementation for testrunner.setStopProvisionalFrameLoads()
in WebKitTestRunner.

Original patch by Alexey Proskuryakov.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::TestRunner):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):
(WTR::TestRunner::setStopProvisionalFrameLoads):
(WTR::TestRunner::shouldStopProvisionalFrameLoads):

LayoutTests:

Unskip fast/loader/stop-provisional-loads.html now that WebKitTestRunner
implements testrunner.setStopProvisionalFrameLoads().

  • platform/wk2/Skipped:
7:55 AM Changeset in webkit [128611] by Simon Hausmann
  • 2 edits in trunk/Source/JavaScriptCore

Fix interpreter build
https://bugs.webkit.org/show_bug.cgi?id=96617

Patch by Kevin Funk <kevin.funk@kdab.com> on 2012-09-14
Reviewed by Simon Hausmann.

Make compile.

  • interpreter/Interpreter.cpp:
7:30 AM Changeset in webkit [128610] by kenneth@webkit.org
  • 3 edits
    1 add in trunk/Source/WebKit2

[EFL] Add unit test for RefPtr<Evas_Object>
https://bugs.webkit.org/show_bug.cgi?id=96776

Reviewed by Simon Hausmann.

Basic testing of the new EFL specific RefPtr type.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:

(EWK2UnitTest::EWK2UnitTestBase::backingStore):
(EWK2UnitTest::EWK2UnitTestBase::canvas):

Add some new accessors for Ecore_Evas and Evas*.

  • UIProcess/API/efl/tests/test_ewk2_refptr_evas_object.cpp: Added.

(TEST_F):

7:08 AM Changeset in webkit [128609] by loislo@chromium.org
  • 7 edits in trunk/Source/WTF

Web Inspector: NMI: convert template versions of String*::reportMemoryUsage functions to normal functions.
https://bugs.webkit.org/show_bug.cgi?id=96759

Reviewed by Yury Semikhatsky.

Now when MemoryInstrumentation.h is a part of WTF we can move reportMemoryUsage functions to cpp file.

  • wtf/text/AtomicString.cpp:

(WTF::AtomicString::reportMemoryUsage):
(WTF):

  • wtf/text/AtomicString.h:

(WTF):
(AtomicString):

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::reportMemoryUsage):
(WTF):

  • wtf/text/StringImpl.h:

(WTF):
(StringImpl):

  • wtf/text/WTFString.cpp:

(WTF::String::reportMemoryUsage):
(WTF):

  • wtf/text/WTFString.h:

(WTF):
(String):

7:02 AM Changeset in webkit [128608] by vestbo@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Move .mm file to OBJECTIVE_SOURCES

Reviewed by Simon Hausmann.

  • Target.pri:
7:01 AM Changeset in webkit [128607] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[EFL] Attempt to create a theme for 0 sized element leads to assertion hit
https://bugs.webkit.org/show_bug.cgi?id=96743

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-14
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

RenderThemeEfl was not supposed to be created for the elements with '0' size and had an assertion
on that causing crash in debug mode.

Test: fast/forms/range/slider-zero-size-crash.html

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::ThemePartCacheEntry::create):

LayoutTests:

RenderThemeEfl was not supposed to be created for the elements with '0' size and had an assertion
on that causing crash in debug mode.

  • fast/forms/range/slider-zero-size-crash-expected.txt: Added.
  • fast/forms/range/slider-zero-size-crash.html: Added.
6:41 AM Changeset in webkit [128606] by vestbo@webkit.org
  • 8 edits in trunk

[Qt] Fix handling of debug/release/debug_and_release/build_all

We now pick up the defaults from Qt, in default_pre (CONFIG already
contains the appropriate values for debug and release). We then let
the command line arguments to qmake, or the project files themselves,
override the configuration, and finally we sanitize the configuration
in default_post.

Reviewed by Simon Hausmann.

6:37 AM Changeset in webkit [128605] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening of failing tests
https://bugs.webkit.org/show_bug.cgi?id=96646

Unreviewed EFL gardening of flaky tests on wk1.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-14

  • platform/efl-wk1/TestExpectations:
6:27 AM Changeset in webkit [128604] by commit-queue@webkit.org
  • 14 edits in trunk

WebKitTestRunner needs layoutTestController.setTabKeyCyclesThroughElements
https://bugs.webkit.org/show_bug.cgi?id=42687

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-14
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Implement testRunner.setTabKeyCyclesThroughElements for
WebKitTestRunner.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetTabKeyCyclesThroughElements):

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setTabKeyCyclesThroughElements):
(WebKit):

  • WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

Tools:

Implement testRunner.setTabKeyCyclesThroughElements for
WebKitTestRunner.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setTabKeyCyclesThroughElements):
(WTR):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

LayoutTests:

fast/events/keypress-insert-tab.html is passing now on wk2. So, unskip
in common skipped files and re-skip it on efl-wk1 until WK82864 is fixed.

  • platform/efl-wk1/TestExpectations:
  • platform/efl/Skipped:
  • platform/wk2/Skipped:
6:27 AM Changeset in webkit [128603] by tonikitoo@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove the ability to schedule a zoom about point call.
https://bugs.webkit.org/show_bug.cgi?id=96696

[FullScreen] entering/leaving fullscreen results in temporary glitches on the screen (Part I)
PR #180866

Reviewed by Rob Buis.
Patch by Antonio Gomes <agomes@rim.com>

Internally reviewed by Jacky Hajiang and Arvid Nilsson.

Patch replaces the async call to zoomAboutPoint (via scheduling it with a one-shot-0-timer).
Instead, at its single call site, we inline most of the previous scheduleZoomAboutPoint code,
and in the end call zoomAboutPoint directly.

Change was estimulated by Arvid's comment on PRzilla: "There is no longer any reason to have
"zoom about point" be async.. That was a hack I did for BB6, back when we were doing everything
on the WK read and needed manual time slicing betwren rendering and user interaction."

The bigger goal though is to be able to remove screen glitches while entering/leaving
fullscreen mode: since we could accurately use the count-based suspend/resume backing
store mechanism to prevent it.

  • Api/WebPage.cpp:

(WebKit):
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):

  • Api/WebPage_p.h:

(WebPagePrivate):

6:19 AM Changeset in webkit [128602] by commit-queue@webkit.org
  • 5 edits in trunk

EventSendingController::keyDown does not support non-array modifier arguments
https://bugs.webkit.org/show_bug.cgi?id=96727

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-14
Reviewed by Kenneth Rohde Christiansen.

Tools:

Add support for handling a string as modifier argument to
EventSendingController::keyDown.

  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::parseModifierArray):

LayoutTests:

Unskip passing test fast/forms/legend-access-key.html

  • platform/efl-wk2/TestExpectations:
  • platform/gtk-wk2/Skipped:
6:10 AM Changeset in webkit [128601] by vsevik@chromium.org
  • 1 edit
    1 move in trunk/LayoutTests

Unreviewed skipping failing test.

  • http/tests/inspector/network/network-xhr-replay.html_disabled: Renamed from LayoutTests/http/tests/inspector/network/network-xhr-replay.html.
6:09 AM Changeset in webkit [128600] by commit-queue@webkit.org
  • 5 edits in trunk

WebKitTestRunner needs layoutTestController.setCustomPolicyDelegate
https://bugs.webkit.org/show_bug.cgi?id=42546

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-14
Reviewed by Kenneth Rohde Christiansen.

Tools:

Exported TestRunner::setCustomPolicyDelegate() method.
Allowed Policy Delegate dumping even if we're not in 'waitUntilDone' mode.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::decidePolicyForNavigationAction):

LayoutTests:

Unskipped corresponding test cases. Distributed those which still not passing to appropriate groups in Skipped file.

  • platform/wk2/Skipped:
6:08 AM Changeset in webkit [128599] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[BlackBerry] Switching from Slogger to Slogger2 requires changes in CMakeList of
webkit in order to include libraries of slog2
https://bugs.webkit.org/show_bug.cgi?id=96391

Patch by Parth Patel <parpatel@rim.com> on 2012-09-14
Reviewed by Yong Li.

Changes in Cmake files of JavaScriptCore of webkit to include slog2 libs in build
files of webkit in response to switching from Slogger to Slogger2.

  • shell/PlatformBlackBerry.cmake:
6:07 AM Changeset in webkit [128598] by caseq@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: reuse WebInspector.ProgressIndicator in Audits panel
https://bugs.webkit.org/show_bug.cgi?id=96755

Reviewed by Alexander Pavlov.

  • remove AuditProgressMonitor, use WebInspector.ProgressIndicator instead;
  • add annotations for a bunch of audit methods;
  • simplify control flow -- remove callbacks where possible.
  • English.lproj/localizedStrings.js:
  • inspector/front-end/AuditLauncherView.js:

(WebInspector.AuditLauncherView):
(WebInspector.AuditLauncherView.prototype._setAuditRunning):
(WebInspector.AuditLauncherView.prototype._launchButtonClicked.onAuditStarted):
(WebInspector.AuditLauncherView.prototype._launchButtonClicked):
(WebInspector.AuditLauncherView.prototype._createLauncherUI):
(WebInspector.AuditLauncherView.prototype._updateResourceProgress):
(WebInspector.AuditLauncherView.prototype._updateButton):

  • inspector/front-end/AuditRules.js:

(WebInspector.AuditRules.GzipRule.prototype.doRun):
(WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun):
(WebInspector.AuditRules.MinimizeDnsLookupsRule.prototype.doRun):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.documentLoaded):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
(WebInspector.AuditRules.CacheControlRule.prototype.doRun):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun.externalStylesheetsReceived):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun.inlineStylesReceived):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun.onDocumentAvailable):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.cssBeforeInlineReceived):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.lateStylesReceived):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.onDocumentAvailable):
(WebInspector.AuditRules.CSSRuleBase.prototype.doRun.sheetsCallback):
(WebInspector.AuditRules.CSSRuleBase.prototype._visitStyleSheet.sheetCallback):
(WebInspector.AuditRules.CSSRuleBase.prototype._visitStyleSheet):
(WebInspector.AuditRules.CookieRuleBase.prototype.doRun.resultCallback):
(WebInspector.AuditRules.CookieRuleBase.prototype.doRun):

  • inspector/front-end/AuditsPanel.js:

(WebInspector.AuditsPanel):
(WebInspector.AuditsPanel.prototype._executeAudit.ruleResultReadyCallback):
(WebInspector.AuditsPanel.prototype._executeAudit):
(WebInspector.AuditsPanel.prototype._auditFinishedCallback):
(WebInspector.AuditsPanel.prototype.initiateAudit.else.onReload):
(WebInspector.AuditsPanel.prototype.initiateAudit):
(WebInspector.AuditCategory.prototype.run):
(WebInspector.AuditRule.prototype.run):
(WebInspector.AuditRule.prototype.doRun):

  • inspector/front-end/ProgressBar.js:

(WebInspector.Progress.prototype.worked):
(WebInspector.ProgressIndicator):
(WebInspector.ProgressIndicator.prototype.cancel):
(WebInspector.ProgressIndicator.prototype.setWorked):
(WebInspector.ProgressIndicator.prototype.worked):
(WebInspector.SubProgress.prototype.setWorked):
(WebInspector.SubProgress.prototype.worked):

  • inspector/front-end/auditsPanel.css:

(.audit-launcher-view .progress-bar-container):
(.audit-launcher-view .progress-bar-container .progress-bar-stop-button):

5:45 AM Changeset in webkit [128597] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed inspector ui polish.

  • inspector/front-end/inspector.css:

(#floating-status-bar-resizer):

5:43 AM Changeset in webkit [128596] by zandobersek@gmail.com
  • 7 edits in trunk

[GTK] Clear application cache between tests in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=96543

Reviewed by Philippe Normand.

Source/WebKit/gtk:

Add a method to the DumpRenderTreeSupportGtk class that upon calling
clears the application cache and vacuums the database file.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::clearApplicationCache):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Tools:

Call the new DumpRenderTreeSupportGtk method to clear application cache
after each test in DumpRenderTree.

Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
as well. It's now being set in XvfbDriver._start so that each driver is assigned
a cache directory that's constructed out of the driver's name and its worker
number. These directories are located in the layout tests results directory.
At least on the builders this ensures a driver-specific empty cache directory
with each test run.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(runTest):

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort.setup_environ_for_server):

  • Scripts/webkitpy/layout_tests/port/xvfbdriver.py:

(XvfbDriver._start):

5:42 AM Changeset in webkit [128595] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Get rid of setting values to innerHTML in inspector front-end.
https://bugs.webkit.org/show_bug.cgi?id=96758

Reviewed by Alexander Pavlov.

Removed innerHTML from WebGLProfileView.

  • inspector/front-end/WebGLProfileView.js:

(WebInspector.WebGLProfileView.prototype._showTraceLog):

5:40 AM Changeset in webkit [128594] by tkent@chromium.org
  • 10 edits
    2 adds in trunk

Make time input lang attribute aware for testing
https://bugs.webkit.org/show_bug.cgi?id=96728

Patch by Keishi Hattori <keishi@webkit.org> on 2012-09-14
Reviewed by Kent Tamura.

Source/WebCore:

This patch implements partial lang attribute support for input type=time
that turns on only when enabled through InternalSettings.

Test: fast/forms/time-multiple-fields/time-multiple-fields-localization.html

  • dom/Document.cpp:

(WebCore::Document::getLocalizer): Returns a localizer for a given locale. Localizers are cached for repeated use.
(WebCore):

  • dom/Document.h:

(WebCore):
(Document):

  • html/TimeInputType.cpp:

(WebCore::TimeInputType::updateInnerTextValue): Use the locale for the input element.

  • html/shadow/DateTimeEditElement.cpp:

(DateTimeEditBuilder):
(WebCore::DateTimeEditBuilder::DateTimeEditBuilder):
(WebCore::DateTimeEditBuilder::visitField):
(WebCore::DateTimeEditElement::layout):
(WebCore::DateTimeEditElement::setValueAsDate):
(WebCore::DateTimeEditElement::setEmptyValue):

  • html/shadow/DateTimeEditElement.h:

(WebCore):
(DateTimeEditElement):

Source/WebKit/chromium:

  • tests/LocalizedDateICUTest.cpp:

(LocalizedDateICUTest::localizedDateFormatText):
(LocalizedDateICUTest::localizedShortDateFormatText):

LayoutTests:

  • fast/forms/resources/common.js:

(getUserAgentShadowTextContent): Used to get the text inside an input element.

  • fast/forms/time-multiple-fields/time-multiple-fields-localization.html: Added.
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt: Added.
  • platform/chromium/TestExpectations:
5:34 AM Changeset in webkit [128593] by tkent@chromium.org
  • 13 edits in trunk/Source/WebCore

Unreviewed, rolling out r128566.
http://trac.webkit.org/changeset/128566
https://bugs.webkit.org/show_bug.cgi?id=96760

Assertion failure in http/tests/websocket/tests/hybi/workers
/close-code-and-reason.html (Requested by tkent1 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-14

  • bindings/v8/DOMData.cpp:

(WebCore::DOMData::getCurrentStore):

  • bindings/v8/ScopedPersistent.h:
  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::resetIsolatedWorlds):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::currentWorldContext):

  • bindings/v8/V8Binding.cpp:

(WebCore::perContextDataForCurrentWorld):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::setIsolatedWorldField):
(WebCore::V8DOMWindowShell::enteredIsolatedWorldContext):
(WebCore::V8DOMWindowShell::destroyIsolatedShell):
(WebCore):
(WebCore::isolatedContextWeakCallback):
(WebCore::V8DOMWindowShell::disposeContext):
(WebCore::V8DOMWindowShell::initializeIfNeeded):
(WebCore::V8DOMWindowShell::setIsolatedWorldSecurityOrigin):

  • bindings/v8/V8DOMWindowShell.h:

(V8DOMWindowShell):
(WebCore::V8DOMWindowShell::getEntered):

  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getCachedWrapper):

  • bindings/v8/WorldContextHandle.cpp:

(WebCore::WorldContextHandle::WorldContextHandle):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8SVGDocumentCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:

(WebCore::V8XMLHttpRequest::constructorCallback):

5:19 AM Changeset in webkit [128592] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Fix front end closure compilation errors.
https://bugs.webkit.org/show_bug.cgi?id=96753

Reviewed by Alexander Pavlov.

Closure compilation fix.
Also fixed wrong parameters passed to JavaScriptSource constructor from CompilerScriptMapping.

  • inspector/front-end/CompilerScriptMapping.js:
  • inspector/front-end/Resource.js:
5:06 AM Changeset in webkit [128591] by yosin@chromium.org
  • 3 edits in trunk/LayoutTests

REGRESSION(r128575): fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back.html is failed on Chromium-Win
https://bugs.webkit.org/show_bug.cgi?id=96754

Reviewed by Kent Tamura.

The root cause of this failure is Chromium-Win port has a second field
event if step=60 due by Windows platform API.

This patch changes test sample to have a second field to get rid of
such difference.

  • fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back-expected.txt: Updates expectation.
  • fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back.html: Changed to add "step=1" to

test sample and to add a second field value to expectation.

5:05 AM Changeset in webkit [128590] by commit-queue@webkit.org
  • 8 edits
    3 adds in trunk/Source/WebCore

Web Inspector: Display Named Flows in the "CSS Named Flows" drawer
https://bugs.webkit.org/show_bug.cgi?id=90871

Patch by Andrei Poenaru <poenaru@adobe.com> on 2012-09-14
Reviewed by Alexander Pavlov.

Implemented CSS Regions support in WebInspector as a drawer. (feature is under an experimental flag)

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/CSSNamedFlowCollectionsView.js: Added.

(WebInspector.CSSNamedFlowCollectionsView):
(WebInspector.CSSNamedFlowCollectionsView.prototype.showInDrawer):
(WebInspector.CSSNamedFlowCollectionsView.prototype.reset):
(WebInspector.CSSNamedFlowCollectionsView.prototype._setDocument):
(WebInspector.CSSNamedFlowCollectionsView.prototype._documentUpdated):
(WebInspector.CSSNamedFlowCollectionsView.prototype._setSidebarHasContent):
(WebInspector.CSSNamedFlowCollectionsView.prototype._appendNamedFlow):
(WebInspector.CSSNamedFlowCollectionsView.prototype._removeNamedFlow):
(WebInspector.CSSNamedFlowCollectionsView.prototype._updateNamedFlow):
(WebInspector.CSSNamedFlowCollectionsView.prototype._resetNamedFlows):
(WebInspector.CSSNamedFlowCollectionsView.prototype._namedFlowCreated):
(WebInspector.CSSNamedFlowCollectionsView.prototype._namedFlowRemoved):
(WebInspector.CSSNamedFlowCollectionsView.prototype._regionLayoutUpdated):
(WebInspector.CSSNamedFlowCollectionsView.prototype._hashNamedFlow):
(WebInspector.CSSNamedFlowCollectionsView.prototype._showNamedFlow):
(WebInspector.CSSNamedFlowCollectionsView.prototype._selectNamedFlowInSidebar):
(WebInspector.CSSNamedFlowCollectionsView.prototype._selectedNodeChanged):
(WebInspector.CSSNamedFlowCollectionsView.prototype._showNamedFlowForNode):
(WebInspector.CSSNamedFlowCollectionsView.prototype.wasShown):
(WebInspector.CSSNamedFlowCollectionsView.prototype.willHide):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype._contextMenuEventFired.set get var):
(WebInspector.ElementsPanel.prototype._showNamedFlowCollections):

  • inspector/front-end/Images/namedFlowOverflow.png: Added.
  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/cssNamedFlows.css: Added.

(.css-named-flow-collections-view .split-view-sidebar-left):
(.css-named-flow-collections-view .tabbed-pane-header):
(.css-named-flow-collections-view .info):
(.css-named-flow-collections-view .split-view-sidebar-left .sidebar-content):
(.css-named-flow-collections-view .split-view-sidebar-left .selection):
(.css-named-flow-collections-view .split-view-contents .title):
(.css-named-flow-collections-view .split-view-sidebar-left .named-flow-overflow::before):

4:57 AM Changeset in webkit [128589] by yosin@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed fix for build break on Chromium-Linux Debug build.

  • html/DateTimeFieldsState.cpp: Initialize DateTimeFieldStates::emptyValue.
  • html/DateTimeFieldsState.h: Remove initialization of public static member variable emptyValue.
4:49 AM Changeset in webkit [128588] by tkent@chromium.org
  • 5 edits
    1 add in trunk/Source/WebCore

Create Localizer factory method for LocaleNone
https://bugs.webkit.org/show_bug.cgi?id=96745

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-09-14
Reviewed by Kent Tamura.

This patch introduces Localizer class and LocaleNone class which
prodices a constructor of Localizer class for ports which don't use
LocaleICU, LocaleMac nor LocaleWin.

No new tests. This patch doesn't change behavior.

  • CMakeLists.txt: Added platform/text/LocaleNone.cpp and platform/text/Localizer.cpp.
  • GNUmakefile.list.am: Added platform/text/LocaleNone.cpp and platform/text/Localizer.{cpp,h}
  • Target.pri: Added platform/text/LocaleNone.cpp and platform/text/Localizer.cpp
  • WebCore.vcproj/WebCore.vcproj: Added platform/text/LocaleNone.cpp and platform/text/Localizer.{cpp,h}
  • platform/text/LocaleNone.cpp: Added.

(WebCore::Localizer::create):
(WebCore::LocaleNone::~LocaleNone):
(WebCore::LocaleNone::initializeLocalizerData):

4:42 AM Changeset in webkit [128587] by Simon Hausmann
  • 2 edits in trunk/Tools

[Qt] Fix linking on Windows

Reviewed by Tor Arne Vestbø.

When compiling code _after_ QtWebKit.dll, we need to make sure that the QWEBKIT_EXPORT
macro turns into an import macro, which means QT_MAKEDLL should only be set _up until_
the QtWebKit.dll creation in the build process and be off afterwards. This is done in
win32/default_post.prf using a !contains(QT, webkit): DEFINES += QT_MAKEDLL.

r128450 sanitized the values of QT and PKGCONFIG to only contain the dependencies we
want for QtWebKit.dll, but unfortunately that code was applied to any binary built also
after the module. Therefore QT did never contain webkit anymore and we always passed
QT_MAKEDLL to DEFINES, resulting in QWEBKIT_EXPORT to _not_ turn into an import macro.

This patch introduces a creating_module configuration that is used to
scope the qt/pkgconfig sanitization.

  • qmake/mkspecs/features/default_post.prf:
4:24 AM Changeset in webkit [128586] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed r128580 follow up: fixed qt minimal compilation.

  • loader/DocumentThreadableLoader.cpp:
4:22 AM Changeset in webkit [128585] by commit-queue@webkit.org
  • 4 edits in trunk

[WK2][WKTR] TestRunner is not dumping some frame load callbacks information
https://bugs.webkit.org/show_bug.cgi?id=96740

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-14
Reviewed by Kenneth Rohde Christiansen.

Tools:

Dump information expected by the test cases about the following
frame load callbacks:
"didDisplayInsecureContentForFrame"
"didRunInsecureContentForFrame"
"didDetectXSSForFrame"

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Print a URL
as expected by test results by calling pathSuitableForTestResult() instead
of printing raw URL.
(WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
(WTR::InjectedBundlePage::didRunInsecureContentForFrame):
(WTR::InjectedBundlePage::didDetectXSSForFrame):

LayoutTests:

Unskip test cases which were failing due to missing
frame load callbacks information dumping with
WebKitTestRunner.

  • platform/wk2/Skipped:
4:17 AM Changeset in webkit [128584] by keishi@webkit.org
  • 16 edits in trunk/Source

Refactor time format related methods on LocaleWin/Mac/ICU so that they override Localizer methods
https://bugs.webkit.org/show_bug.cgi?id=96726

Reviewed by Kent Tamura.

Source/WebCore:

Refactoring time format related methods on LocaleWin/Mac/ICU so that
they override Localizer methods. We can call them from the Localizer
from now on.

No new tests. No behavior change. Covered by existing tests.

  • platform/text/LocaleICU.cpp:

(WebCore::LocaleICU::initializeDateTimeFormat): m_timeAMPMLabels is no longer a OwnPtr so we account for that.
(WebCore::LocaleICU::timeFormat): Removing Text from end of function
name because *FormatText() shoud return human readable text like "Day/Month/Year".
(WebCore::LocaleICU::shortTimeFormat):
(WebCore::LocaleICU::timeAMPMLabels):

  • platform/text/LocaleICU.h:

(LocaleICU):

  • platform/text/LocaleWin.cpp:

(WebCore::LocaleWin::timeFormat):
(WebCore::LocaleWin::shortTimeFormat):
(WebCore::LocaleWin::timeAMPMLabels):

  • platform/text/LocaleWin.h:

(LocaleWin):

  • platform/text/LocalizedDateICU.cpp:

(WebCore::localizedTimeFormatText):
(WebCore::localizedShortTimeFormatText):

  • platform/text/LocalizedDateWin.cpp:

(WebCore::localizedTimeFormatText):
(WebCore::localizedShortTimeFormatText):

  • platform/text/Localizer.cpp:

(WebCore):
(WebCore::Localizer::timeFormat):
(WebCore::Localizer::shortTimeFormat):
(WebCore::Localizer::timeAMPMLabels):

  • platform/text/Localizer.h:

(Localizer): We unified some of the member variables like m_timeAMPMLabels into this class.

  • platform/text/mac/LocaleMac.h:

(LocaleMac):

  • platform/text/mac/LocaleMac.mm:

(WebCore::LocaleMac::timeFormat):
(WebCore::LocaleMac::shortTimeFormat):

  • platform/text/mac/LocalizedDateMac.cpp:

(WebCore::localizedTimeFormatText):
(WebCore::localizedShortTimeFormatText):

Source/WebKit/chromium:

  • tests/LocaleMacTest.cpp:

(LocaleMacTest::timeFormat):
(LocaleMacTest::shortTimeFormat):
(TEST_F):

  • tests/LocaleWinTest.cpp:

(LocaleWinTest::timeFormat):
(LocaleWinTest::shortTimeFormat):
(TEST_F):

  • tests/LocalizedDateICUTest.cpp:

(LocalizedDateICUTest::localizedDateFormatText):
(LocalizedDateICUTest::localizedShortDateFormatText):

4:11 AM Changeset in webkit [128583] by keishi@webkit.org
  • 12 edits in trunk

Add runtime flag that enables lang attribute for form controls in LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=96636

Reviewed by Kent Tamura.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

Lang attribute support for form controls will be incomplete and just for LayoutTests.

No new tests. No behavior change.

  • WebCore.exp.in:
  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::langAttributeAwareFormControlUIEnabled):
(WebCore::RuntimeEnabledFeatures::setLangAttributeAwareFormControlUIEnabled):
(RuntimeEnabledFeatures):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setLangAttributeAwareFormControlUIEnabled):
(WebCore):

  • testing/InternalSettings.h:

(Backup):
(InternalSettings):

  • testing/InternalSettings.idl:

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
3:59 AM Changeset in webkit [128582] by keishi@webkit.org
  • 4 edits in trunk/Source

LocaleMac should fallback to defaultLanguage for an invalid locale
https://bugs.webkit.org/show_bug.cgi?id=96744

Reviewed by Kent Tamura.

Source/WebCore:

There is no way to tell if a locale identifier is valid or not in Cocoa
so we look if we have a matching language in the list of
ISOLanguageCodes given by NSLocale.

Covered in LocaleMacTest.invalidLocale.

  • platform/text/mac/LocaleMac.mm:

(WebCore):
(WebCore::LocaleMac::LocaleMac):
(WebCore::LocaleMac::create):

Source/WebKit/chromium:

  • tests/LocaleMacTest.cpp:

(TEST_F):

3:58 AM Changeset in webkit [128581] by peter@chromium.org
  • 3 edits in trunk/Tools

The runtime/unsigned category should be valid in the cpp style-checker.
https://bugs.webkit.org/show_bug.cgi?id=96748

Reviewed by Csaba Osztrogonác.

This is causing the webkitpy tests to fail because it's not listed in the
category array. Furthermore, change an "int" to "long" because it's
throwing a double error in one of the earlier asserts.

  • Scripts/webkitpy/style/checkers/cpp.py:

(CppChecker):

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(WebKitStyleTest.test_names):

3:41 AM Changeset in webkit [128580] by vsevik@chromium.org
  • 16 edits
    2 adds in trunk

Web Inspector: Add ability to replay XHR in network panel.
https://bugs.webkit.org/show_bug.cgi?id=95187

Reviewed by Yury Semikhatsky.

Source/WebCore:

Patch based on Pavel Chadnov's patch.
This patch implements Replay XHR feature in web inspector.
XMLHttpRequest's ThreadableLoaderClient is now used to map XMLHttpRequest object to ResourceLoader request identifiers.
Before initiating load all XHR parameters are now sent to inspector.
XMLHttpRequest parameters are stored in inspector's network request cache in XHRReplayData class.
When XHR replay is requested, a new XMLHttpRequest is created based on stored data.

Test: http/tests/inspector/network/network-xhr-replay.html

  • inspector/Inspector.json:
  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::didFinishXHRLoading):

  • inspector/InspectorConsoleAgent.h:

(InspectorConsoleAgent):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::documentThreadableLoaderStartedLoadingForClientImpl):
(WebCore::InspectorInstrumentation::willLoadXHRImpl):
(WebCore::InspectorInstrumentation::didFailXHRLoadingImpl):
(WebCore::InspectorInstrumentation::didFinishXHRLoadingImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::documentThreadableLoaderStartedLoadingForClient):
(WebCore::InspectorInstrumentation::willLoadXHR):
(WebCore::InspectorInstrumentation::didFailXHRLoading):
(WebCore::InspectorInstrumentation::didFinishXHRLoading):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
(WebCore::InspectorResourceAgent::documentThreadableLoaderStartedLoadingForClient):
(WebCore):
(WebCore::InspectorResourceAgent::willLoadXHR):
(WebCore::InspectorResourceAgent::didFailXHRLoading):
(WebCore::InspectorResourceAgent::didFinishXHRLoading):
(WebCore::InspectorResourceAgent::replayXHR):

  • inspector/InspectorResourceAgent.h:

(WebCore):
(InspectorResourceAgent):

  • inspector/NetworkResourcesData.cpp:

(WebCore::XHRReplayData::create):
(WebCore):
(WebCore::XHRReplayData::addHeader):
(WebCore::XHRReplayData::XHRReplayData):
(WebCore::NetworkResourcesData::xhrReplayData):
(WebCore::NetworkResourcesData::setXHRReplayData):
(WebCore::NetworkResourcesData::reuseXHRReplayData):
(WebCore::NetworkResourcesData::clear):

  • inspector/NetworkResourcesData.h:

(XHRReplayData):
(WebCore::XHRReplayData::method):
(WebCore::XHRReplayData::url):
(WebCore::XHRReplayData::async):
(WebCore::XHRReplayData::formData):
(WebCore::XHRReplayData::headers):
(WebCore::XHRReplayData::includeCredentials):
(WebCore):
(WebCore::NetworkResourcesData::ResourceData::xhrReplayData):
(WebCore::NetworkResourcesData::ResourceData::setXHRReplayData):
(ResourceData):
(NetworkResourcesData):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._contextMenu):
(WebInspector.NetworkLogView.prototype._replayXHR):

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::loadRequest): added documentThreadableLoaderStartedLoadingForClient instrumentation
so that inspector could map XMLHttpRequest to ResourceLoader's identifiers.

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::loader): DocumentThreadableLoader uses CachedResource::loader() to get ResourceLoader identifier.
(CachedResource):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::sendFromInspector): Added a method for sending XMLHttpRequests based on request body stored in inspector.
(WebCore):
(WebCore::XMLHttpRequest::createRequest): Replaced will/didLoadXHRSynchonously instrumentations with willLoadXHR instrumentation.
(WebCore::XMLHttpRequest::internalAbort): Added didFailXHRLoadingInstrumentation
(WebCore::XMLHttpRequest::didFinishLoading): Added didFinishXHRLoading instrumentation

  • xml/XMLHttpRequest.h:

(XMLHttpRequest):

LayoutTests:

Added XHR replay test.

  • http/tests/inspector/network/network-xhr-replay-expected.txt: Added.
  • http/tests/inspector/network/network-xhr-replay.html: Added.
3:40 AM Changeset in webkit [128579] by Csaba Osztrogonác
  • 2 edits in trunk/PerformanceTests

Unreviewed, rolling out r128562.
http://trac.webkit.org/changeset/128562
https://bugs.webkit.org/show_bug.cgi?id=96747

It broke perf tests on Qt and Chromium (Requested by Ossy on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-14

  • resources/runner.js:

(PerfTestRunner._runner):
(PerfTestRunner._perSecondRunnerIterator):

3:22 AM Changeset in webkit [128578] by anilsson@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Add renderTreeAsText API to WebPage
https://bugs.webkit.org/show_bug.cgi?id=96629

Reviewed by Antonio Gomes.

This will be used for automated testing.

PR #198595

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::renderTreeAsText):
(WebKit):

  • Api/WebPage.h:
3:15 AM Changeset in webkit [128577] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[WK2] Move globalhistory tests to their correct section in Skipped list
https://bugs.webkit.org/show_bug.cgi?id=96738

Unreviewed gardening.

Move 2 globalhistory tests to their correct section in WK2
Skipped list.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-14

  • platform/wk2/Skipped:
3:10 AM Changeset in webkit [128576] by loislo@chromium.org
  • 2 edits in trunk/Source/WTF

Web Inspector: NMI: remove current traits helper class because it is customizing the instrumentation at a wrong place and is not necessary at the moment.
https://bugs.webkit.org/show_bug.cgi?id=96737

Reviewed by Yury Semikhatsky.

  • wtf/MemoryInstrumentation.h:

(MemoryInstrumentation):
WTF::MemoryInstrumentationTraits): removed
(WTF::MemoryInstrumentation::OwningTraits::addInstrumentedObject): direct call inserted
(WTF::MemoryInstrumentation::OwningTraits::addObject):direct call inserted

3:09 AM Changeset in webkit [128575] by yosin@chromium.org
  • 15 edits
    2 adds in trunk

[Forms] multiple fields time input UI should save/restore its value even if it has an empty field.
https://bugs.webkit.org/show_bug.cgi?id=96714

Reviewed by Kent Tamura.

Source/WebCore:

This patch changes multiple fields time input UI to save/restore value
of fields rather than time value. For this change, storage format of
input type "time" is also changed.

Before this patch, if user populates time fiels partially, all fields
are reset to initial value after back/forward navigation.

After this patch, partially populated fields are preserved after
back/forward navigation.

Fields of DateTimeEditElement are represented as 9 elements of
string vector in FormControlState regardless actual fields in
DateTimeEditElement for ease of restoring/saving.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. Existing test fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back.html
convers this change.

  • WebCore.gypi: Chagned to add DateTimeFieldsState.{cpp.h}
  • html/DateTimeFieldsState.cpp: Added.

(WebCore::getNumberFromFormControlState): Extracts unsigned integer or empty value from FormControlState.
(WebCore::getAMPMFromFormControlState): Extracts AM/PM value or empty value from FormControlState.
(WebCore::DateTimeFieldsState::DateTimeFieldsState): Initializes fields with empty value.
(WebCore::DateTimeFieldsState::restoreFormControlState): Makes DateTimeFieldsState instance from FormControlState.
(WebCore::DateTimeFieldsState::saveFormControlState): Makes FormControlState from DateTimeFieldsState.

  • html/DateTimeFieldsState.h: Added.

(DateTimeFieldsState):
(WebCore::DateTimeFieldsState::ampm): Returns AM/PM field value.
(WebCore::DateTimeFieldsState::dayOfMonth): Returns day of month field value.
(WebCore::DateTimeFieldsState::hour): Reutrns hour field value.
(WebCore::DateTimeFieldsState::millisecond): Returns millisecond field value.
(WebCore::DateTimeFieldsState::minute): Returns minute field value.
(WebCore::DateTimeFieldsState::month): Returns month field value.
(WebCore::DateTimeFieldsState::second): Returns second field value.
(WebCore::DateTimeFieldsState::weekOfYear): Returns week of year field.
(WebCore::DateTimeFieldsState::year): Returns year field value.
(WebCore::DateTimeFieldsState::hasAMPM): Returns true if AM/PM field has value.
(WebCore::DateTimeFieldsState::hasDayOfMonth): Returns true if day of month field has value.
(WebCore::DateTimeFieldsState::hasHour): Returns true if hour field has value.
(WebCore::DateTimeFieldsState::hasMillisecond): Returns true if millisecond field has value.
(WebCore::DateTimeFieldsState::hasMinute): Returns true if minute field has value.
(WebCore::DateTimeFieldsState::hasMonth): Returns true if month field has value.
(WebCore::DateTimeFieldsState::hasSecond): Returns true if second field has value.
(WebCore::DateTimeFieldsState::hasWeekOfYear): Returns true if week of year field has value.
(WebCore::DateTimeFieldsState::hasYear): Returns true if year field has value.
(WebCore::DateTimeFieldsState::setAMPM): Sets AM/PM field.
(WebCore::DateTimeFieldsState::setDayOfMonth): Sets day of month field.
(WebCore::DateTimeFieldsState::setHour): Sets hour field.
(WebCore::DateTimeFieldsState::setMillisecond): Sets millisecond field.
(WebCore::DateTimeFieldsState::setMinute): Sets minute field.
(WebCore::DateTimeFieldsState::setMonth): Sets month field.
(WebCore::DateTimeFieldsState::setSecond): Set second field.
(WebCore::DateTimeFieldsState::setWeekOfYear): Sets week of year field.
(WebCore::DateTimeFieldsState::setYear): Sets year field.

  • html/FormController.cpp:

(WebCore::formStateSignature): Increment version number to 8 for incompatible change of FormControlState.

  • html/TimeInputType.cpp:

(WebCore::TimeInputType::restoreFormControlState): Added to call DateTimeFieldsState::restoreFormControlState().
(WebCore::TimeInputType::saveFormControlState): Added to call DateTimeFieldsState::saveFormControlState().

  • html/TimeInputType.h:

(TimeInputType): Added declarations for restoreFormControlState() and saveFormControlState().

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditElement::setValueAsDateTimeFieldsState): Added to set fields from DateTimeFieldsState.
(WebCore::DateTimeEditElement::valueAsDateTimeFieldsState): Added to make DateTimeFieldsState from fields.

  • html/shadow/DateTimeEditElement.h:

(DateTimeEditElement): Added declarations for setValueAsDateTimeFieldsState() and valueAsDateTimeFieldsState().

  • html/shadow/DateTimeFieldElement.h:

(DateTimeFieldElement): Added declarations for populateDateTimeFieldsState() and setValueAsDateTimeFieldsState().

  • html/shadow/DateTimeFieldElements.cpp:

(WebCore::DateTimeAMPMFieldElement::populateDateTimeFieldsState): Added to set AM/PM value to DateTimeFieldsState.
(WebCore::DateTimeAMPMFieldElement::setValueAsDateTimeFieldsState): Added to set field value from DateTimeFieldsState.
(WebCore::DateTimeHourFieldElement::populateDateTimeFieldsState): Added to set hour value to DateTimeFieldsState.
(WebCore::DateTimeHourFieldElement::setValueAsDateTimeFieldsState): Added to set field value from DateTimeFieldsState.
(WebCore::DateTimeMillisecondFieldElement::populateDateTimeFieldsState): Added to set millisecond value to DateTimeFieldsState.
(WebCore::DateTimeMillisecondFieldElement::setValueAsDateTimeFieldsState): Added to set field value from DateTimeFieldsState.
(WebCore::DateTimeMinuteFieldElement::populateDateTimeFieldsState): Added to set minute value to DateTimeFieldsState.
(WebCore::DateTimeMinuteFieldElement::setValueAsDateTimeFieldsState): Added to set field value from DateTimeFieldsState.
(WebCore::DateTimeSecondFieldElement::populateDateTimeFieldsState): Added to set second value to DateTimeFieldsState.
(WebCore::DateTimeSecondFieldElement::setValueAsDateTimeFieldsState): Added to set field value from DateTimeFieldsState.

  • html/shadow/DateTimeFieldElements.h:

(DateTimeAMPMFieldElement): Added declarations of populateDateTimeFieldsState() and setValueAsDateTimeFieldsState().
(DateTimeHourFieldElement): ditto.
(DateTimeMillisecondFieldElement): ditto.
(DateTimeMinuteFieldElement): ditto.
(DateTimeSecondFieldElement): ditto.

  • html/shadow/DateTimeNumericFieldElement.h:

(DateTimeNumericFieldElement): Extend accessibility of maximum() and setEmptyValue() to protected.

  • html/shadow/DateTimeSymbolicFieldElement.h:

(DateTimeSymbolicFieldElement): Extend accessibility of hasValue(), setEmptyValue() and valueAsInteger() to protected.

LayoutTests:

This patch changes time-multiple-fields-preserve-value-after-history-back.html
to check partial value is saved and restored rather than resetting value.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

  • fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back-expected.txt: Updated for new expectation.
  • fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back.html: Changed to check partially populated fields of input element.
2:37 AM Changeset in webkit [128574] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r128568.
http://trac.webkit.org/changeset/128568
https://bugs.webkit.org/show_bug.cgi?id=96739

It broke 3 tests everywhere (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-14

  • bindings/js/JSDictionary.h:

(WebCore::JSDictionary::tryGetPropertyAndResult):

2:27 AM Changeset in webkit [128573] by kenneth@webkit.org
  • 12 edits
    2 moves in trunk

Evas_Object* is a ref'ed structure, so tread it as such
https://bugs.webkit.org/show_bug.cgi?id=96659

Source/WebCore:

Reviewed by Adam Barth.

Replace OwnPtr<Evas_Object> with RefPtr.

  • PlatformEfl.cmake:
  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::ThemePartCacheEntry::create):
(WebCore::RenderThemeEfl::loadTheme):
(WebCore::RenderThemeEfl::applyPartDescriptionsFrom):

  • platform/efl/RenderThemeEfl.h:

(RenderThemeEfl):
(ThemePartCacheEntry):

Source/WebKit/efl:

Reviewed by Adam Barth.

Replace OwnPtr<Evas_Object> with RefPtr.

  • tests/UnitTestUtils/EWKTestView.cpp:

(EWKUnitTests::EWKTestView::init):

  • tests/UnitTestUtils/EWKTestView.h:

(EWKTestView):

Source/WTF:

Reviewed by Gyuyoung Kim.

Remove OwnPtr support for Evas_Object* and add support for it
with RefPtr instead (the latter moved from WebCore).

  • wtf/PlatformEfl.cmake:
  • wtf/efl/OwnPtrEfl.cpp:
  • wtf/efl/RefPtrEfl.cpp: Renamed from Source/WebCore/platform/efl/RefPtrEfl.cpp.

(WTF):
(WTF::refIfNotNull):
(WTF::derefIfNotNull):

  • wtf/efl/RefPtrEfl.h: Renamed from Source/WebCore/platform/efl/RefPtrEfl.h.

(WTF):

Tools:

Reviewed by Adam Barth.

Replace OwnPtr<Evas_Object> with RefPtr.

  • DumpRenderTree/efl/ImageDiff.cpp:

(calculateDifference):
(printImageDifferences):
(readImageFromStdin):
(main):

2:12 AM Changeset in webkit [128572] by zoltan@webkit.org
  • 106 edits in trunk/Source/WebCore

Extend the coverage of the Custom Allocation Framework in WebCore
https://bugs.webkit.org/show_bug.cgi?id=96512

Reviewed by Eric Seidel.

Add WTF_MAKE_FAST_ALLOCATED macro to the following class/struct declarations because these
or their child classes are instantiated by operator new.

Covered by existing tests.

  • Modules/websockets/WebSocketDeflateFramer.cpp:

(WebSocketExtensionDeflateFrame):

  • Modules/websockets/WebSocketDeflateFramer.h:

(DeflateResultHolder):
(InflateResultHolder):

  • Modules/websockets/WebSocketDeflater.h:

(WebSocketDeflater):
(WebSocketInflater):

  • Modules/websockets/WebSocketHandshake.h:

(WebSocketHandshake):

  • bindings/js/ScriptDebugServer.h:

(Task):

  • css/CSSCalculationValue.cpp:

(CSSCalcPrimitiveValue):

  • css/CSSParserMode.h:

(CSSParserContext):

  • css/CSSValuePool.h:

(CSSValuePool):

  • css/StyleBuilder.h:

(StyleBuilder):

  • css/StylePropertyShorthand.h:

(StylePropertyShorthand):

  • css/StyleResolver.cpp:

(RuleSet):

  • css/StyleRule.h:

(StyleRuleBase):
(StyleRule):

  • css/StyleRuleImport.h:

(StyleRuleImport):

  • css/WebKitCSSKeyframeRule.h:

(StyleKeyframe):

  • dom/CheckedRadioButtons.cpp:

(RadioButtonGroup):

  • dom/ContextFeatures.h:

(ContextFeaturesClient):

  • dom/DOMImplementation.h:

(DOMImplementation):
(XMLMIMETypeRegExp):

  • dom/Document.cpp:

(ImmutableAttributeDataCacheKey):

  • dom/ElementShadow.h:

(ElementShadow):

  • dom/GenericEventQueue.h:

(GenericEventQueue):

  • dom/IdTargetObserverRegistry.h:

(IdTargetObserverRegistry):

  • dom/NamedNodeMap.h:

(NamedNodeMap):

  • dom/ScopedEventQueue.h:

(ScopedEventQueue):

  • dom/StyledElement.cpp:

(PresentationAttributeCacheEntry):
(PresentationAttributeCacheCleaner):

  • editing/EditingStyle.cpp:

(HTMLElementEquivalent):

  • editing/SpellChecker.h:

(SpellChecker):

  • fileapi/ThreadableBlobRegistry.cpp:

(BlobRegistryContext):

  • html/FormAssociatedElement.cpp:

(FormAttributeTargetObserver):

  • html/FormController.h:

(FormController):

  • html/HTMLInputElement.cpp:

(ListAttributeTargetObserver):

  • html/PublicURLManager.h:

(PublicURLManager):

  • html/StepRange.h:

(StepDescription):

  • html/ValidationMessage.h:

(ValidationMessage):

  • html/canvas/WebGLExtension.h:

(WebGLExtension):

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebGLRenderingContextLostCallback):
(WebGLRenderingContextErrorMessageCallback):

  • html/parser/HTMLElementStack.h:

(ElementRecord):

  • html/parser/HTMLMetaCharsetParser.h:

(HTMLMetaCharsetParser):

  • inspector/DOMEditor.h:

(DOMEditor):

  • inspector/InjectedScriptHost.h:

(InspectableObject):

  • inspector/InjectedScriptManager.h:

(InjectedScriptManager):

  • inspector/InspectorCSSAgent.cpp:

(SelectorProfile):

  • inspector/InspectorCounters.h:

(ThreadLocalInspectorCounters):

  • inspector/InspectorDOMAgent.cpp:

(RevalidateStyleAttributeTask):

  • inspector/InspectorFrontendClientLocal.cpp:

(InspectorBackendDispatchTask):

  • inspector/InspectorHistory.h:

(InspectorHistory):
(Action):

  • inspector/InspectorOverlay.h:

(HighlightConfig):
(InspectorOverlay):

  • inspector/InspectorState.h:

(InspectorState):

  • inspector/InspectorStyleSheet.cpp:

(ParsedStyleSheet):

  • inspector/InspectorWorkerAgent.cpp:

(InspectorWorkerAgent::WorkerFrontendChannel):

  • inspector/NetworkResourcesData.h:

(NetworkResourcesData):
(ResourceData):

  • inspector/WorkerInspectorController.cpp:
  • loader/EmptyClients.h:

(EmptyChromeClient):

  • loader/ResourceLoadScheduler.h:

(ResourceLoadScheduler):
(HostInformation):

  • loader/icon/IconDatabase.cpp:

(DefaultIconDatabaseClient):
(ClientWorkItem):

  • page/ContentSecurityPolicy.cpp:

(CSPDirectiveList):

  • page/ContentSecurityPolicy.h:

(ContentSecurityPolicy):

  • page/FrameActionScheduler.h:

(FrameActionScheduler):

  • page/MemoryInfo.cpp:

(HeapSizeCache):

  • platform/CalculationValue.h:

(CalcExpressionNode):

  • platform/Cursor.h:

(Cursor):

  • platform/Decimal.h:

(Decimal):

  • platform/Length.cpp:

(CalculationValueHandleMap):

  • platform/MemoryPressureHandler.h:

(MemoryPressureHandler):

  • platform/PlatformKeyboardEvent.h:

(PlatformKeyboardEvent):

  • platform/ScrollAnimator.h:

(ScrollAnimator):

  • platform/graphics/GlyphPageTreeNode.h:

(GlyphPageTreeNode):

  • platform/graphics/GraphicsContext.h:

(GraphicsContextStateSaver):

  • platform/graphics/GraphicsLayer.h:

(AnimationValue):

  • platform/graphics/IntRect.h:

(IntRect):

  • platform/graphics/ShadowBlur.cpp:

(ScratchBuffer):

  • platform/graphics/TextRun.h:

(TextRun):

  • platform/graphics/TiledBackingStoreBackend.h:

(TiledBackingStoreBackend):

  • platform/graphics/WidthIterator.h:

(WidthIterator):

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(StreamingClient):

  • platform/graphics/opengl/Extensions3DOpenGL.h:

(Extensions3DOpenGL):

  • platform/graphics/texmap/TextureMapper.h:

(TextureMapper):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(TextureMapperGLData):

  • platform/graphics/texmap/TextureMapperImageBuffer.h:

(TextureMapperImageBuffer):

  • platform/graphics/texmap/TextureMapperLayer.h:

(TextureMapperLayer):

  • platform/image-decoders/bmp/BMPImageReader.h:

(BMPImageReader):

  • platform/image-decoders/gif/GIFImageReader.h:

(GIFFrameReader):
(GIFImageReader):

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(JPEGImageReader):

  • platform/image-decoders/png/PNGImageDecoder.cpp:

(PNGImageReader):

  • platform/network/BlobRegistryImpl.h:

(BlobRegistryImpl):

  • platform/network/ResourceResponseBase.h:

(CrossThreadResourceResponseDataBase):

  • platform/text/TextCodecICU.h:

(ICUConverterWrapper):

  • rendering/FlowThreadController.h:

(FlowThreadController):

  • rendering/RenderBoxRegionInfo.h:

(RenderBoxRegionInfo):

  • rendering/RenderLayer.h:

(ClipRects):
(ClipRectsCache):

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

  • rendering/WrapShapeInfo.h:

(WrapShapeInfo):

  • rendering/style/NinePieceImage.h:

(NinePieceImageData):

  • rendering/svg/RenderSVGResourceFilter.h:

(FilterData):

  • rendering/svg/RenderSVGResourceGradient.h:

(GradientData):

  • rendering/svg/RenderSVGResourcePattern.h:

(PatternData):

  • rendering/svg/SVGResources.h:

(ClipperFilterMaskerData):
(MarkerData):
(FillStrokeData):

  • svg/SVGAngle.h:

(SVGAngle):

  • svg/SVGLength.h:

(SVGLength):

  • svg/SVGPreserveAspectRatio.h:

(SVGPreserveAspectRatio):

  • svg/graphics/SVGImageCache.h:

(SVGImageCache):

  • svg/properties/SVGPropertyInfo.h:

(SVGPropertyInfo):

  • workers/WorkerEventQueue.h:

(WorkerEventQueue):

  • xml/parser/MarkupTokenBase.h:

(DoctypeDataBase):

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(PendingCallbacks):
(OffsetBuffer):

  • xml/parser/XMLToken.h:

(XMLDeclarationData):

2:02 AM Changeset in webkit [128571] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [WebGL] Refactoring: move the proxy wrapping method up to the base class
https://bugs.webkit.org/show_bug.cgi?id=96515

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-14
Reviewed by Vsevolod Vlasov.

Move the proxyObject() method up from WebGLRenderingContextResource to the Resource class, so that it could be reused later for wrapping a 2D context.

  • inspector/InjectedScriptWebGLModuleSource.js:

(.):

1:42 AM Changeset in webkit [128570] by commit-queue@webkit.org
  • 45 edits in trunk/Source/WebCore

Fix unused parameter compile warnings in WebCore.
https://bugs.webkit.org/show_bug.cgi?id=96712

Patch by Kangil Han <kangil.han@samsung.com> on 2012-09-14
Reviewed by Ryosuke Niwa.

Fixed unused parameter compile warning messages(-Wunused-parameter) during EFL build.
There are two kinds of stuff related to this warnings.
First one is that the parameter value has not been used anywhere inside the function.
Other one is that usability of parameter value is depended on option, i.e. ACCESSIBILITY.

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::setEnhancedUserInterfaceAccessibility):
(WebCore::AXObjectCache::postNotification):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::setGeolocationOverride):

  • loader/FrameLoaderClient.h:

(WebCore::FrameLoaderClient::registerIntentService):

  • page/Frame.cpp:

(WebCore::Frame::layerTreeAsText):

  • page/FrameView.cpp:

(WebCore::FrameView::setScrollingPerformanceLoggingEnabled):

  • page/efl/EventHandlerEfl.cpp:

(WebCore::EventHandler::tabsToAllFormControls):
(WebCore::EventHandler::passMouseDownEventToWidget):

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::scrollLayerForFrameView):

  • platform/RuntimeApplicationChecks.cpp:

(WebCore::mainBundleIsEqualTo):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::platformSetScrollOrigin):

  • platform/cairo/WidgetBackingStoreCairo.cpp:

(WebCore::createSurfaceForBackingStore):

  • platform/efl/ContextMenuEfl.cpp:

(WebCore::platformMenuDescription):

  • platform/efl/ContextMenuItemEfl.cpp:

(WebCore::ContextMenuItem::ContextMenuItem):

  • platform/efl/DragDataEfl.cpp:

(WebCore::DragData::asFilenames):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):

  • platform/efl/GamepadsEfl.cpp:

(WebCore::GamepadsEfl::onGamePadChange):

  • platform/efl/LocalizedStringsEfl.cpp:

(WebCore::imageTitle):
(WebCore::localizedMediaControlElementString):
(WebCore::localizedMediaControlElementHelpText):
(WebCore::localizedMediaTimeDescription):

  • platform/efl/PasteboardEfl.cpp:

(WebCore::Pasteboard::writeSelection):
(WebCore::Pasteboard::writeImage):
(WebCore::Pasteboard::documentFragment):

  • platform/efl/PlatformScreenEfl.cpp:

(WebCore::screenRect):

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::adjustSliderTrackStyle):
(WebCore::RenderThemeEfl::systemFont):
(WebCore::RenderThemeEfl::paintMediaSliderThumb):
(WebCore::RenderThemeEfl::paintMediaVolumeSliderContainer):
(WebCore::RenderThemeEfl::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeEfl::paintMediaVolumeSliderThumb):
(WebCore::RenderThemeEfl::paintMediaCurrentTime):

  • platform/efl/ScrollbarEfl.cpp:

(scrollbarEflEdjeMessage):

  • platform/efl/ScrollbarThemeEfl.cpp:

(WebCore::ScrollbarThemeEfl::scrollbarThickness):
(WebCore::ScrollbarThemeEfl::registerScrollbar):
(WebCore::ScrollbarThemeEfl::unregisterScrollbar):

  • platform/efl/TemporaryLinkStubs.cpp:

(WebCore::signedPublicKeyAndChallengeString):

  • platform/efl/WidgetEfl.cpp:

(WebCore::Widget::setFocus):
(WebCore::Widget::paint):

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::setPlatformTextDrawingMode):

  • platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::orientationAtIndex):

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::supportsType):

  • platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:

(WebCore::Font::drawComplexText):

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::adjustFocusRingLineWidth):
(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::setPlatformFillColor):
(WebCore::GraphicsContext::setPlatformStrokeColor):
(WebCore::GraphicsContext::setURLForRect):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::fillRoundedRect):

  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:

(WebCore::GraphicsContextPlatformPrivate::syncContext):

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBufferData::ImageBufferData):

  • platform/graphics/cairo/ImageCairo.cpp:

(WebCore::Image::drawPattern):

  • platform/graphics/efl/IconEfl.cpp:

(WebCore::Icon::createIconForFiles):
(WebCore::Icon::paint):

  • platform/graphics/freetype/FontCacheFreeType.cpp:

(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getTraitsInFamily):

  • platform/graphics/gstreamer/GStreamerGWorld.cpp:

(WebCore::gstGWorldSyncMessageCallback):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(webkitVideoSinkMarshalVoidAndMiniObject):

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcUriHandlerInit):
(webKitWebSrcNeedDataCb):
(webKitWebSrcEnoughDataCb):
(webKitWebSrcSeekDataCb):
(StreamingClient::didReceiveData):

  • platform/graphics/harfbuzz/ng/HarfBuzzNGFaceCairo.cpp:

(WebCore::harfbuzzGetGlyph):
(WebCore::harfbuzzGetGlyphHorizontalAdvance):
(WebCore::harfbuzzGetGlyphHorizontalOrigin):
(WebCore::harfbuzzGetGlyphExtents):
(WebCore::harfbuzzCairoGetTable):

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::readColorProfile):
(WebCore::init_source):
(WebCore::fill_input_buffer):

  • platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageDecoder::rowAvailable):

  • platform/network/soup/CookieStorageSoup.cpp:

(WebCore::setCookieStoragePrivateBrowsingEnabled):

  • platform/network/soup/DNSSoup.cpp:

(WebCore::resolvedCallback):

  • platform/network/soup/ProxyResolverSoup.cpp:

(soup_proxy_resolver_wk_init):
(soupProxyResolverWkGetProxyURIAsync):
(soupProxyResolverWkGetProxyURISync):

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::sendRequestCallback):
(WebCore::addFormElementsToSoupMessage):
(WebCore::requestStartedCallback):
(WebCore::closeCallback):
(WebCore::readCallback):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustRepaintRect):

1:36 AM Changeset in webkit [128569] by vsevik@chromium.org
  • 36 edits in trunk/LayoutTests

Web Inspector: [Tests] Extract a common method for sending XHRs from tests.
https://bugs.webkit.org/show_bug.cgi?id=96662

Reviewed by Alexander Pavlov.

Extracted InspectorTest.makeXHR() methods to simplify tests.

  • http/tests/inspector/appcache/appcache-swap-expected.txt:
  • http/tests/inspector/appcache/appcache-swap.html:
  • http/tests/inspector/console-xhr-logging-async-expected.txt:
  • http/tests/inspector/console-xhr-logging-async.html:
  • http/tests/inspector/console-xhr-logging.html:
  • http/tests/inspector/network-test.js:

(xhrLoadedCallback):
(initialize_NetworkTest.InspectorTest.makeSimpleXHR):
(initialize_NetworkTest.InspectorTest.makeSimpleXHRWithPayload):
(initialize_NetworkTest.InspectorTest.makeXHR.innerCallback):
(initialize_NetworkTest.InspectorTest.makeXHR):
(doSimpleXHR):
(doSimpleXHRWithPayload):
(doXHR):
(makeXHR):

  • http/tests/inspector/network/async-xhr-json-mime-type-expected.txt:
  • http/tests/inspector/network/async-xhr-json-mime-type.html:
  • http/tests/inspector/network/network-clear-cache.html-disabled:
  • http/tests/inspector/network/network-clear-cookies.html-disabled:
  • http/tests/inspector/network/network-content-replacement-xhr-expected.txt:
  • http/tests/inspector/network/network-content-replacement-xhr.html:
  • http/tests/inspector/network/network-cyrillic-xhr-expected.txt:
  • http/tests/inspector/network/network-cyrillic-xhr.html:
  • http/tests/inspector/network/network-disable-cache-xhrs-expected.txt:
  • http/tests/inspector/network/network-disable-cache-xhrs.html:
  • http/tests/inspector/network/network-disabling-check-no-memory-leak-expected.txt:
  • http/tests/inspector/network/network-disabling-check-no-memory-leak.html:
  • http/tests/inspector/network/network-empty-xhr-expected.txt:
  • http/tests/inspector/network/network-empty-xhr.html:
  • http/tests/inspector/network/network-sidebar-width-expected.txt:
  • http/tests/inspector/network/network-sidebar-width.html:
  • http/tests/inspector/network/network-size-sync.html:
  • http/tests/inspector/network/network-xhr-async-double-expected.txt:
  • http/tests/inspector/network/network-xhr-async-double.html:
  • http/tests/inspector/network/network-xhr-async-expected.txt:
  • http/tests/inspector/network/network-xhr-async.html:
  • http/tests/inspector/network/network-xhr-same-url-as-main-resource-expected.txt:
  • http/tests/inspector/network/network-xhr-same-url-as-main-resource.html:
  • http/tests/inspector/network/network-xhr-sync-expected.txt:
  • http/tests/inspector/network/network-xhr-sync.html:
  • http/tests/inspector/resource-tree/resource-tree-no-xhrs-expected.txt:
  • http/tests/inspector/resource-tree/resource-tree-no-xhrs.html:
  • platform/chromium/http/tests/inspector/console-xhr-logging-async-expected.txt:
  • platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt:
1:27 AM Changeset in webkit [128568] by charles.wei@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

Need to clear exception in JSDictionary for operations that might have.
https://bugs.webkit.org/show_bug.cgi?id=96614

Reviewed by Kentaro Hara.

Clear the exception if failed to convert the value inside the JSDictionary.
Otherwise, it might impact the following operations on the dictionary.

No new tests, the existing test at LayoutTest/storage/indexeddb/tutorial.html should work for JSC binding.

  • bindings/js/JSDictionary.h:

(WebCore::JSDictionary::tryGetPropertyAndResult):

1:09 AM Changeset in webkit [128567] by g.czajkowski@samsung.com
  • 5 edits in trunk/Source

Add method to get the list of all available dictionaries
https://bugs.webkit.org/show_bug.cgi?id=96518

Reviewed by Carlos Garcia Campos.

Source/WebCore:

There is lack of the method in the TextCheckerEnchant class to get
the list of all available/installed dictionaries. To set the
dictionaries the client has to 'guess/hard code' the names of
dictionaries that are not obvious and depend on OS configuration
and installed packages. The list can be used by WebKit's GTK and
EFL API for instance:
webkit_web_context_set_spell_checking_languages(),
ewk_text_checker_setting_spell_checking_languages_set()
to set dictionaries used by Enchant.

To avoid names conflict a new one has been introduced for former
getSpellCheckingLanguages. It has been changed to loadedSpellCheckingLanguages
as it gets the current (in use) dictionaries. Additionally the 'get' prefix
has been removed according to WebKit coding style.

  • platform/text/enchant/TextCheckerEnchant.cpp:

(TextCheckerEnchant::loadedSpellCheckingLanguages):
Changed name from getSpellCheckingLanguages and added const modifier.

(TextCheckerEnchant::availableSpellCheckingLanguages):
A newly added method to get available/installed dictionaries.
Its output can be used as input for updateSpellCheckingLanguages().

  • platform/text/enchant/TextCheckerEnchant.h:

(TextCheckerEnchant):

Source/WebKit2:

  • UIProcess/API/gtk/WebKitTextChecker.cpp:

(WebKitTextChecker::getSpellCheckingLanguages):
Update the method name that is called inside getSpellCheckingLanguages.
This replace doesn't affect any on API changes.

12:51 AM Changeset in webkit [128566] by commit-queue@webkit.org
  • 13 edits in trunk/Source/WebCore

Remove V8DOMWindowShell::getEntered
https://bugs.webkit.org/show_bug.cgi?id=96637

Patch by Dan Carney <dcarney@google.com> on 2012-09-14
Reviewed by Adam Barth.

V8DOMWindowShell::getEntered was refactored so that the window shell
no longer has to be kept alive by a v8 context but rather a smaller
object.

No new tests. No change in functionality.

  • bindings/v8/DOMData.cpp:

(WebCore::DOMData::getCurrentStore):

  • bindings/v8/ScopedPersistent.h:

(WebCore::ScopedPersistent::leakHandle):
(ScopedPersistent):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::resetIsolatedWorlds):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::currentWorldContext):

  • bindings/v8/V8Binding.cpp:

(WebCore::perContextDataForCurrentWorld):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::setIsolatedWorldField):
(WebCore::V8DOMWindowShell::toIsolatedContextData):
(WebCore::isolatedContextWeakCallback):
(WebCore::V8DOMWindowShell::disposeContext):
(WebCore::V8DOMWindowShell::clearIsolatedShell):
(WebCore):
(WebCore::V8DOMWindowShell::initializeIfNeeded):
(WebCore::V8DOMWindowShell::setIsolatedWorldSecurityOrigin):

  • bindings/v8/V8DOMWindowShell.h:

(V8DOMWindowShell):
(IsolatedContextData):
(WebCore::V8DOMWindowShell::IsolatedContextData::create):
(WebCore::V8DOMWindowShell::IsolatedContextData::world):
(WebCore::V8DOMWindowShell::IsolatedContextData::perContextData):
(WebCore::V8DOMWindowShell::IsolatedContextData::setSecurityOrigin):
(WebCore::V8DOMWindowShell::IsolatedContextData::securityOrigin):
(WebCore::V8DOMWindowShell::IsolatedContextData::IsolatedContextData):
(WebCore::V8DOMWindowShell::enteredIsolatedContext):
(WebCore::V8DOMWindowShell::enteredIsolatedContextData):

  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getCachedWrapper):

  • bindings/v8/WorldContextHandle.cpp:

(WebCore::WorldContextHandle::WorldContextHandle):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8SVGDocumentCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:

(WebCore::V8XMLHttpRequest::constructorCallback):

12:12 AM Changeset in webkit [128565] by gyuyoung.kim@samsung.com
  • 12 edits
    2 moves in trunk

Unreviewed, rolling out r128507.
http://trac.webkit.org/changeset/128507
https://bugs.webkit.org/show_bug.cgi?id=96659

Source/WebCore:

Revert. r128507 makes too many crashes in EFL layout test bots.

  • PlatformEfl.cmake:
  • platform/efl/RefPtrEfl.cpp: Renamed from Source/WTF/wtf/efl/RefPtrEfl.cpp.

(WTF):
(WTF::refIfNotNull):
(WTF::derefIfNotNull):

  • platform/efl/RefPtrEfl.h: Renamed from Source/WTF/wtf/efl/RefPtrEfl.h.

(WTF):

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::ThemePartCacheEntry::create):
(WebCore::RenderThemeEfl::loadTheme):
(WebCore::RenderThemeEfl::applyPartDescriptionsFrom):

  • platform/efl/RenderThemeEfl.h:

(RenderThemeEfl):
(ThemePartCacheEntry):

Source/WebKit/efl:

Revert. r128507 makes too many crashes in EFL layout test bots.

  • tests/UnitTestUtils/EWKTestView.cpp:

(EWKUnitTests::EWKTestView::init):

  • tests/UnitTestUtils/EWKTestView.h:

(EWKTestView):

Source/WTF:

Revert. r128507 makes too many crash in EFL layout test bots.

  • wtf/PlatformEfl.cmake:
  • wtf/efl/OwnPtrEfl.cpp:

(WTF::deleteOwnedPtr):
(WTF):

Tools:

Revert. r128507 makes too many crashes in EFL layout test bots.

  • DumpRenderTree/efl/ImageDiff.cpp:

(calculateDifference):
(printImageDifferences):
(readImageFromStdin):
(main):

12:09 AM QtWebKitBuildBots edited by Csaba Osztrogonác
update bots (diff)
12:09 AM Changeset in webkit [128564] by Patrick Gansterer
  • 6 edits in trunk/Source/WebCore

Reuse floating point formatting of TextStream in [SVG]RenderTreeAsText.cpp
https://bugs.webkit.org/show_bug.cgi?id=96264

Reviewed by Benjamin Poulain.

RenderTreeAsText uses the same format for streaming out floats as TextStream
does. Replace formatNumberRespectingIntegers() with a new overload to the
operator<< to reuse the special cases for numbers which take advantage of
StringBuilder::appendNumber() and avoid a temporary StringImpl.

  • platform/text/TextStream.cpp:

(WebCore::hasFractions):
(WebCore::TextStream::operator<<):

  • platform/text/TextStream.h:
  • rendering/RenderTreeAsText.cpp:

(WebCore::operator<<):

  • rendering/RenderTreeAsText.h:
  • rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::operator<<):

12:06 AM Changeset in webkit [128563] by mhahnenberg@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Remove the Zapped BlockState
https://bugs.webkit.org/show_bug.cgi?id=96708

Reviewed by Geoffrey Garen.

The Zapped block state is rather confusing. It indicates that a block is in one of two different states that we
can't tell the difference between:

1) I have run all destructors of things that are zapped, and I have not allocated any more objects. This block

is ready for reclaiming if you so choose.

2) I have run all the destructors of things that are zapped, but I have allocated more stuff since then, so it

is not safe to reclaim this block.

This state adds a lot of complexity to our state transition model for MarkedBlocks. We should get rid of it.
We can replace this state by making sure mark bits represent all of the liveness information we need when running
our conservative stack scan. Instead of zapping the free list when canonicalizing cell liveness data prior to
a conservative scan, we can instead mark all objects in the block except for those in the free list. This should
incur no performance penalty since we're doing it on a very small O(1) number of blocks at the beginning of the collection.

For the time being we still need to use zapping to determine whether we have run an object's destructor or not.

  • heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::tryAllocateHelper): Renaming stuff.

  • heap/MarkedAllocator.h: Renamed zapFreeList to canonicalizeCellLivenessData to match.

(MarkedAllocator):
(JSC::MarkedAllocator::canonicalizeCellLivenessData): Same as old zapFreeList, but just call canonicalize instead.

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::specializedSweep): Remove the check for Zapped block stuff. Also change the block state to Marked
instead of Zapped if we're not producing a FreeList since that's the only other state that really makes any sense.
(JSC::MarkedBlock::sweepHelper): Remove Zapped related code.
(SetAllMarksFunctor): Functor to set all the mark bits in the block since there's not a simple function to call on
the Bitmap itself.
(JSC::SetAllMarksFunctor::operator()):
(JSC):
(JSC::MarkedBlock::canonicalizeCellLivenessData): Remove all the stuff for Zapped. For FreeListed, set all the mark bits
and then clear the ones for the objects in the FreeList. This ensures that only the things that were in the FreeList
are considered to be dead by the conservative scan, just like if we were to have zapped the FreeList like before.

  • heap/MarkedBlock.h:

(MarkedBlock):
(JSC::MarkedBlock::clearMarked): Add function to clear individual mark bits, since we need that functionality now.
(JSC):
(JSC::MarkedBlock::isLive): Remove code for Zapped stuff. Marked handles all interesting cases now.
(JSC::MarkedBlock::forEachCell): Add new iterator function that iterates over all cells in the block, regardless of
whether they're live or a dead.

  • heap/MarkedSpace.cpp:

(JSC::MarkedSpace::canonicalizeCellLivenessData): Change to call the renamed canonicalize function.

12:03 AM Changeset in webkit [128562] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

Use performance.webkitNow in PerfTestRunner
https://bugs.webkit.org/show_bug.cgi?id=92826

Reviewed by Eric Seidel.

Use performance.webkitNow with Date.now as a fallback for more acurate time measurements.

  • resources/runner.js:

(PerfTestRunner._runner):
(PerfTestRunner._perSecondRunnerIterator):

Sep 13, 2012:

11:45 PM Changeset in webkit [128561] by Csaba Osztrogonác
  • 1 edit
    1 delete in trunk/LayoutTests

[Qt] Unreviewed gardening, remove an unnecessary expected file.

  • platform/qt/fast/events/keyevent-iframe-removed-crash-expected.txt: Removed.
11:29 PM Changeset in webkit [128560] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Remove a lot of C'ism from Ewk_Tiled_Matrix
https://bugs.webkit.org/show_bug.cgi?id=96638

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-13
Reviewed by Gyuyoung Kim.

Remove a lot of C'ism from Ewk_Tiled_Matrix and
fix the code so that it follows coding style.

  • ewk/ewk_tiled_matrix.cpp:

(_Ewk_Tile_Matrix):
(ewk_tile_matrix_entry_get):
(_ewk_tile_matrix_cell_free):
(_ewk_tile_matrix_tile_free):
(ewk_tile_matrix_zoom_level_set):
(ewk_tile_matrix_entry_new):
(ewk_tile_matrix_invalidate):
(ewk_tile_matrix_free):
(ewk_tile_matrix_resize):
(ewk_tile_matrix_size_get):
(ewk_tile_matrix_unused_cache_get):
(ewk_tile_matrix_tile_exact_get):
(ewk_tile_matrix_tile_exact_exists):
(ewk_tile_matrix_tile_new):
(ewk_tile_matrix_tile_put):
(ewk_tile_matrix_tile_updates_clear):
(_ewk_tile_matrix_slicer_setup):
(ewk_tile_matrix_update):
(ewk_tile_matrix_updates_process):
(ewk_tile_matrix_updates_clear):
(ewk_tile_matrix_dbg):
(ewk_tile_matrix_freeze):
(ewk_tile_matrix_thaw):

  • ewk/ewk_tiled_matrix_private.h:
11:17 PM Changeset in webkit [128559] by commit-queue@webkit.org
  • 10 edits in trunk/Source

Unreviewed, rolling out r128552.
http://trac.webkit.org/changeset/128552
https://bugs.webkit.org/show_bug.cgi?id=96729

Still breaks the test on chromium linux debug. It's quite
annoying. (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-13

Source/WebCore:

  • WebCore.exp.in:
  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::removeChildren):

  • dom/Document.cpp:

(WebCore::Document::recalcStyle):

  • dom/Element.cpp:

(WebCore::Element::attach):
(WebCore::Element::detach):

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passMouseDownEventToWidget):

  • rendering/RenderWidget.cpp:

(WebCore):
(WebCore::widgetNewParentMap):
(WebCore::RenderWidget::suspendWidgetHierarchyUpdates):
(WebCore::RenderWidget::resumeWidgetHierarchyUpdates):
(WebCore::moveWidgetToParentSoon):

  • rendering/RenderWidget.h:

(RenderWidget):

Source/WebKit/mac:

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _invalidateGStatesForTree]):

10:53 PM Changeset in webkit [128558] by commit-queue@webkit.org
  • 17 edits in trunk

Make compile with both OS(WINCE) and PLATFORM(QT) support
https://bugs.webkit.org/show_bug.cgi?id=95536

Patch by Kevin Funk <kevin.funk@kdab.com> on 2012-09-13
Reviewed by Simon Hausmann.

Source/JavaScriptCore:

Do not link against advapi32 on wince

  • jsc.pro:

Source/WebCore:

  • WebCore.pri:

Set defines for the WinCE platform build

  • platform/graphics/BitmapImage.cpp:

Use default implementation in BitmapImage::reportMemoryUsage() when Qt support available

  • platform/graphics/GraphicsContext.cpp:

Same as above: use default implementation

  • platform/win/ClipboardUtilitiesWin.cpp:

Remove unnecessary include

Source/WTF:

Fixes for Windows CE.

  • WTF.pri:

Also include path for mt19937ar.c

  • wtf/unicode/icu/CollatorICU.cpp:

Fix undeclared strdup() on CE7

  • wtf/Platform.h:

Tools:

Fix wince support in qmake files

  • Tools.pro:
  • qmake/mkspecs/features/configure.prf:
  • qmake/mkspecs/features/default_post.prf:
  • qmake/mkspecs/features/features.prf:
  • qmake/mkspecs/features/functions.prf:
10:51 PM Changeset in webkit [128557] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Fix for WTF fails to compile in thumb mode when llint is enabled.
https://bugs.webkit.org/show_bug.cgi?id=96400

Patch by Byungseon Shin <xingri@gmail.com> on 2012-09-13
Reviewed by Filip Pizlo.

When using "+m" with Armv7 cross compiler assume offset range between +/- 4095
(the largest possible offset range).
However, ldrex/strex can only use offset range of 0~1020, so "+m" needed to be changed to "+Q".
Ref. http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54480

  • wtf/Atomics.h:

(WTF::weakCompareAndSwap):

10:50 PM Changeset in webkit [128556] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

Create Localizer factory method for LocaleWin
https://bugs.webkit.org/show_bug.cgi?id=96667

Reviewed by Kent Tamura.

Preparing to use Localizer instead of LocaleMac/Win/ICU.

No new tests. No behavior change.

  • platform/text/LocaleWin.cpp:

(WebCore):
(WebCore::extractLanguageCode): Extract the language code from a locale.
(WebCore::LCIDFromLocaleInternal): Returns LCID for a given locale. Returns 0 when locale is invalid.
(WebCore::LCIDFromLocale): Returns LCID for a given locale. Returns default language LCID when locale is invalid.
(WebCore::Localizer::create):
(WebCore::LocaleWin::currentLocale):

10:30 PM Changeset in webkit [128555] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] qt-5.0-wk2 Skipped file can be updated after bug #73917 got fixed
https://bugs.webkit.org/show_bug.cgi?id=96675

Patch by Luciano Wolf <Luciano Miguel Wolf> on 2012-09-13
Reviewed by Simon Hausmann.

Update Skipped list after userAgent proper support.

  • platform/qt-5.0-wk2/Skipped:
10:10 PM Changeset in webkit [128554] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update

  • platform/chromium/TestExpectations:

Fix an error in the previous change.

10:08 PM Changeset in webkit [128553] by commit-queue@webkit.org
  • 23 edits
    5 copies in trunk

[WK2] Add color picker API support for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=95058

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-09-13
Reviewed by Gyuyoung Kim.

Source/WebKit2:

Add support for color picker API to WebKit2.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Shared/API/c/WKBase.h:
  • Shared/APIClientTraits.cpp:

(WebKit):

  • Shared/APIClientTraits.h:
  • Shared/APIObject.h:
  • Target.pri:
  • UIProcess/API/C/WKAPICast.h:

(WebKit):

  • UIProcess/API/C/WKColorPickerResultListener.cpp: Added.

(WKColorPickerResultListenerGetTypeID):
(WKColorPickerResultListenerColorSet):

  • UIProcess/API/C/WKColorPickerResultListener.h: Added.
  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/gtk/WebKitUIClient.cpp:

(attachUIClientToView):

  • UIProcess/WebColorChooserProxy.cpp: Added.

(WebKit):
(WebKit::WebColorChooserProxy::WebColorChooserProxy):
(WebKit::WebColorChooserProxy::~WebColorChooserProxy):
(WebKit::WebColorChooserProxy::endChooser):
(WebKit::WebColorChooserProxy::setSelectedColor):

  • UIProcess/WebColorChooserProxy.h:

(WebColorChooserProxy):
(WebKit::WebColorChooserProxy::create):

  • UIProcess/WebColorPickerResultListenerProxy.cpp: Added.

(WebKit):
(WebKit::WebColorPickerResultListenerProxy::WebColorPickerResultListenerProxy):
(WebKit::WebColorPickerResultListenerProxy::~WebColorPickerResultListenerProxy):
(WebKit::WebColorPickerResultListenerProxy::invalidate):
(WebKit::WebColorPickerResultListenerProxy::setColor):

  • UIProcess/WebColorPickerResultListenerProxy.h: Added.

(WebKit):
(WebColorPickerResultListenerProxy):
(WebKit::WebColorPickerResultListenerProxy::create):
(WebKit::WebColorPickerResultListenerProxy::type):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::showColorChooser):
(WebKit::WebPageProxy::didEndColorChooser):
(WebKit::WebPageProxy::processDidCrash):

  • UIProcess/WebPageProxy.h:

(WebKit):
(WebPageProxy):

  • UIProcess/WebUIClient.cpp:

(WebKit):
(WebKit::WebUIClient::showColorPicker):
(WebKit::WebUIClient::hideColorPicker):

  • UIProcess/WebUIClient.h:

(WebKit):
(WebUIClient):

  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:

Tools:

Initialization code for color picker callbacks in UI client.

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):

  • MiniBrowser/win/BrowserView.cpp:

(BrowserView::create):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):

10:00 PM Changeset in webkit [128552] by rniwa@webkit.org
  • 10 edits in trunk/Source

suspend/resumeWidgetHierarchyUpdates should be a RAII object
https://bugs.webkit.org/show_bug.cgi?id=96706

Reviewed by Simon Fraser.

Source/WebCore:

Replaced suspendWidgetHierarchyUpdates and resumeWidgetHierarchyUpdates by WidgetHierarchyUpdatesSuspensionScope.

  • WebCore.exp.in: Export new symbols.
  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::removeChildren):

  • dom/Document.cpp:

(WebCore::Document::recalcStyle):

  • dom/Element.cpp:

(WebCore::Element::attach):
(WebCore::Element::detach):

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passMouseDownEventToWidget):

  • rendering/RenderWidget.cpp:

(WebCore):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::widgetNewParentMap):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::moveWidgets):
(WebCore::moveWidgetToParentSoon):

  • rendering/RenderWidget.h:

(WidgetHierarchyUpdatesSuspensionScope):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::WidgetHierarchyUpdatesSuspensionScope):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::~WidgetHierarchyUpdatesSuspensionScope):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::isSuspended):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::scheduleWidgetToMove):
(WebCore):
(RenderWidget):

Source/WebKit/mac:

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _invalidateGStatesForTree]):

9:55 PM Changeset in webkit [128551] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update
https://bugs.webkit.org/show_bug.cgi?id=96725

  • platform/chromium/TestExpectations:

http/tests/media/media-source/video-media-source-state-changes.html is flaky

8:50 PM Changeset in webkit [128550] by yutak@chromium.org
  • 2 edits in trunk/Tools

Upgrade yutak to reviewer
https://bugs.webkit.org/show_bug.cgi?id=96721

Reviewed by Kent Tamura.

  • Scripts/webkitpy/common/config/committers.py:
8:39 PM Changeset in webkit [128549] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update
https://bugs.webkit.org/show_bug.cgi?id=93589

  • platform/chromium/TestExpectations:

script-change-externalResourcesRequired-while-loading.svg is flaky on all platforms.

8:30 PM WebKit Team edited by yutak@chromium.org
Move myself to reviewers list (diff)
8:24 PM Changeset in webkit [128548] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Unreviewed, rolling out r128543.
http://trac.webkit.org/changeset/128543
https://bugs.webkit.org/show_bug.cgi?id=96722

Caused LocaleWinTest.localizedNumberRoundTrip to fail
(Requested by keishi on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-13

Source/WebCore:

  • platform/text/LocaleWin.cpp:

(WebCore::determineCurrentLCID):
(WebCore):
(WebCore::LocaleWin::currentLocale):

Source/WebKit/chromium:

  • tests/LocaleWinTest.cpp:

(testNumberIsReversible):
(testNumbers):
(TEST_F):

8:20 PM Changeset in webkit [128547] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation udpate.
https://bugs.webkit.org/show_bug.cgi?id=96720

  • platform/chromium/TestExpectations:

time-multiple-fields-preserve-value-after-history-back.html is flaky.

7:29 PM Changeset in webkit [128546] by commit-queue@webkit.org
  • 10 edits in trunk/Source

Unreviewed, rolling out r128531.
http://trac.webkit.org/changeset/128531
https://bugs.webkit.org/show_bug.cgi?id=96719

plugins/document-open.html crash on Chromium-Linux (Requested
by tkent1 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-13

Source/WebCore:

  • WebCore.exp.in:
  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::removeChildren):

  • dom/Document.cpp:

(WebCore::Document::recalcStyle):

  • dom/Element.cpp:

(WebCore::Element::attach):
(WebCore::Element::detach):

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passMouseDownEventToWidget):

  • rendering/RenderWidget.cpp:

(WebCore):
(WebCore::widgetNewParentMap):
(WebCore::RenderWidget::suspendWidgetHierarchyUpdates):
(WebCore::RenderWidget::resumeWidgetHierarchyUpdates):
(WebCore::moveWidgetToParentSoon):

  • rendering/RenderWidget.h:

(RenderWidget):

Source/WebKit/mac:

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _invalidateGStatesForTree]):

7:19 PM Changeset in webkit [128545] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Make the style checker report usage of "unsigned int"
https://bugs.webkit.org/show_bug.cgi?id=96693

Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2012-09-13
Reviewed by Dirk Pranke.

Add a rule to check for uses of unsigned int, as the updated coding style recomends.

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_language):

7:17 PM Changeset in webkit [128544] by ggaren@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Refactored the DFG to make fewer assumptions about variable capture
https://bugs.webkit.org/show_bug.cgi?id=96680

Reviewed by Gavin Barraclough.

A variable capture optimization patch I'm working on broke DFG
correctness and the arguments simplification optimization phase, so I've
refactored both to make fewer assumptions about variable capture.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::isCaptured): This is the new One True Way to find out
if a variable was captured. This gives us a single point of maintenance
as we chagne capture behavior.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::clobberCapturedVars): Don't assume that captured
variables have any particular location. Instead, ask the One True Function.

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):
(JSC::DFG::ArgumentsSimplificationPhase::observeProperArgumentsUse):
(JSC::DFG::ArgumentsSimplificationPhase::isOKToOptimize): Mechanical
changes to separate being captured from being 'arguments'. What used
to be

if (captured)

if (arguments)

x

y

is now

if (arguments)

x
y

else if (captured)

y

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::flushDirect):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile): Use the One True Function.

7:02 PM Changeset in webkit [128543] by keishi@webkit.org
  • 4 edits in trunk/Source

Create Localizer factory method for LocaleWin
https://bugs.webkit.org/show_bug.cgi?id=96667

Reviewed by Kent Tamura.

Source/WebCore:

Preparing to use Localizer instead of LocaleMac/Win/ICU.

No new tests. Covered in LocaleWinTest.cpp.

  • platform/text/LocaleWin.cpp:

(WebCore):
(WebCore::extractLanguageCode): Extract the language code from a locale.
(WebCore::LCIDFromLocaleInternal): Returns LCID for a given locale. Returns 0 when locale is invalid.
(WebCore::LCIDFromLocale): Returns LCID for a given locale. Returns default language LCID when locale is invalid.
(WebCore::Localizer::create):
(WebCore::LocaleWin::currentLocale):

Source/WebKit/chromium:

  • tests/LocaleWinTest.cpp:

(testNumberIsReversible):
(testNumbers):

6:50 PM Changeset in webkit [128542] by benjamin@webkit.org
  • 22 edits
    2 deletes in trunk/Source

Improve the SourceProvider hierarchy
https://bugs.webkit.org/show_bug.cgi?id=95635

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-13
Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

SourceProvider was designed to have subclasses magically handling the data without
decoding all of it. The virtual methods length() and getRange() were based
on these assumptions.

In practice, the magic was in our head, there is no implementation that takes
advantage of that.

SourceProvider is modified to adopt WebCore's ScriptSourceProvider::source() and base
everything on it.
The code using SourceProvider is also simplified.

  • interpreter/Interpreter.cpp:

(JSC::appendSourceToError): Keep a reference to the string instead of querying it for
each time it is used.

  • parser/Lexer.cpp:

(JSC::::setCode):
(JSC::::sourceCode):

  • parser/Parser.h:

(JSC::parse):

  • parser/SourceCode.h:

(JSC::SourceCode::SourceCode):
(JSC::SourceCode::subExpression):

  • parser/SourceProvider.h:

(SourceProvider):
(JSC::SourceProvider::getRange):

Source/WebCore:

Get rid of ScriptSourceProvider and StringSourceProvider, they have been made
useless by JavaScript updates.

On x86_64, this reduces the binary size by 6kb.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/CachedScriptSourceProvider.h:

(WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::updateCurrentStatementPosition):
(WebCore::ScriptDebugServer::dispatchDidParseSource):
(WebCore::ScriptDebugServer::dispatchFailedToParseSource):

  • bindings/js/ScriptSourceCode.h:

(WebCore::ScriptSourceCode::ScriptSourceCode):
(ScriptSourceCode):

  • bindings/js/ScriptSourceProvider.h: Removed.
  • bindings/js/StringSourceProvider.h: Removed.
  • bindings/js/WorkerScriptController.cpp:
  • bindings/objc/WebScriptObject.mm:
  • bridge/NP_jsobject.cpp:
  • bridge/jni/jni_jsobject.mm:

Source/WebKit/mac:

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: Fix a #include abuse.
  • WebView/WebScriptDebugger.mm:

(toNSString): We can now use the (faster) implicit conversion
from String to NSString.

6:44 PM Changeset in webkit [128541] by fpizlo@apple.com
  • 4 edits
    3 adds in trunk

DFG: Dead GetButterfly's shouldn't be subject to CSE
https://bugs.webkit.org/show_bug.cgi?id=96707
<rdar://problem/12296311>

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

There were a number of cases of this that creeped into the CSE: it would
match something even though it was dead.

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::checkArrayElimination):
(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::getScopeChainLoadElimination):
(JSC::DFG::CSEPhase::getLocalLoadElimination):

LayoutTests:

Reviewed by Oliver Hunt.

  • fast/js/dfg-dead-redundant-get-array-length-expected.txt: Added.
  • fast/js/dfg-dead-redundant-get-array-length.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-dead-redundant-get-array-length.js: Added.

(foo):

6:37 PM Changeset in webkit [128540] by ojan@chromium.org
  • 27 edits
    1 copy
    2 moves
    1 add
    3 deletes in trunk/LayoutTests

Test rebaselines after http://trac.webkit.org/changeset/128517.

  • fast/table/height-percent-test-expected.txt:
  • platform/chromium-mac-snowleopard/fast/table/height-percent-test-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/core/cell_heights-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug19526-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/chromium-mac/fast/table/height-percent-test-expected.png:
  • platform/chromium-mac/tables/mozilla/core/cell_heights-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug19526-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
  • platform/chromium-win/fast/table/height-percent-test-expected.png:
  • platform/chromium-win/tables/mozilla/core/cell_heights-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug19526-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/efl/fast/table/height-percent-test-expected.txt: Removed.
  • platform/gtk/TestExpectations:
  • platform/gtk/fast/table/height-percent-test-expected.txt: Removed.
  • platform/gtk/tables/mozilla/core/cell_heights-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug19526-expected.txt: Removed.
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
  • platform/mac/TestExpectations:
  • platform/mac/tables/mozilla/core/cell_heights-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug19526-expected.txt:
  • platform/qt/TestExpectations:
  • platform/qt/fast/table/height-percent-test-expected.txt: Renamed from LayoutTests/platform/mac/fast/table/height-percent-test-expected.txt.
  • platform/qt/tables/mozilla/core/cell_heights-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug19526-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
  • platform/win-future/fast/table/height-percent-test-expected.txt: Copied from LayoutTests/fast/table/height-percent-test-expected.txt.
  • tables/mozilla_expected_failures/bugs/bug19526-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/bugs/bug19526-expected.txt.
6:35 PM Changeset in webkit [128539] by mrowe@apple.com
  • 5 edits in trunk/Source/ThirdParty/ANGLE

<rdar://problem/12255720> Fix the build with newer Clang

Reviewed by Sam Weinig.

Clang generates a warning about the inclusion of trailing commas on the final enum item as it's apparently
a C++11 extension. Remove them.

  • src/compiler/BaseTypes.h:
  • src/compiler/ExtensionBehavior.h:
  • src/compiler/ParseHelper.cpp:

(TParseContext::parseVectorFields):

  • src/compiler/intermediate.h:
6:30 PM Changeset in webkit [128538] by ojan@chromium.org
  • 2 edits
    3 deletes in trunk/LayoutTests

Rebaseline fast/css/percentage-height-auto-sized-body-quirks.html after
http://trac.webkit.org/changeset/128517. The results are now consistent
across platforms.

  • platform/efl/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt: Removed.
  • platform/gtk/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt: Removed.
  • platform/mac/TestExpectations:
  • platform/qt/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt: Removed.
6:15 PM Changeset in webkit [128537] by commit-queue@webkit.org
  • 4 edits
    1 copy in trunk/Source/WebKit2

[EFL][WK2] Implement missing initializeLogChannel function
https://bugs.webkit.org/show_bug.cgi?id=96478

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-09-13
Reviewed by Gyuyoung Kim.

Implemented log channel initialization function for EFL platform in WebKit2.

  • Platform/Logging.cpp:

(WebKit):

  • Platform/Logging.h:

(WebKit):

  • Platform/efl/LoggingEfl.cpp: Added.

(WebKit):
(WebKit::initializeLogChannel): Channel is initialized if its name is found in WEBKIT_DEBUG.

  • PlatformEfl.cmake:
5:52 PM Changeset in webkit [128536] by pdr@google.com
  • 2 edits in trunk/Tools

Add gender-neutral form of webkit-patch land-cowboy
https://bugs.webkit.org/show_bug.cgi?id=96709

Reviewed by Adam Barth.

Add webkit-patch land-cowhand, the confident and courageous form of webkit-patch for everyone.

  • Scripts/webkitpy/tool/commands/download.py:

(LandCowhand):

5:43 PM Changeset in webkit [128535] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Remove some parameters in browserCreate()
https://bugs.webkit.org/show_bug.cgi?id=96499

Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-09-13
Reviewed by Kenneth Rohde Christiansen.

There are too many parameters in browserCreate(). Lots of it seems like settings from command line argument.
And I have moved some parameters into User_Arguments.

  • EWebLauncher/main.c:

(_User_Arguments):
(_ELauncher):
(on_key_down):
(browserCreate):
(findThemePath):
(parseUserArguments):
(main):

5:43 PM Changeset in webkit [128534] by oliver@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

Make global const initialisation explicit in the bytecode
https://bugs.webkit.org/show_bug.cgi?id=96711

Reviewed by Gavin Barraclough.

Added op_init_global_const to make initialisation of global const
fields explicit. This will help us keep correct semantics in the
upcoming variable resolution refactoring.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):

  • bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitInitGlobalConst):
(JSC):

  • bytecompiler/BytecodeGenerator.h:

(BytecodeGenerator):

  • bytecompiler/NodesCodegen.cpp:

(JSC::ConstDeclNode::emitCodeSingle):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
5:28 PM Changeset in webkit [128533] by jsbell@chromium.org
  • 31 edits in trunk/Source

IndexedDB: Consolidate two-phase connection to avoid race conditions
https://bugs.webkit.org/show_bug.cgi?id=90411

Reviewed by Tony Chang.

Source/WebCore:

Previously, IDB connections were opened by having the front-end (1) call through to
a back-end open() method, eventually receive a success message with a back-end object
handle, and (2) call into the back-end object to register front-end callbacks. This left
the back-end's notion of an open connection in a limbo state between these two calls.
In multi-process ports, a crash of the front-end process could leave the back-end wedged
waiting for this second call (e.g. can't delete until all connections are closed).

Simplify this by having the front-end pass through the callbacks into the back-end
during the initial open() call, which eliminates the limbo state.

No new tests - no functional changes. Chromium port's webkit_unit_tests updated.

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::create):
(WebCore::IDBDatabase::IDBDatabase): Db-callbacks is available at creation time.
(WebCore::IDBDatabase::~IDBDatabase):

  • Modules/indexeddb/IDBDatabase.h:

(IDBDatabase):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::create): Need to track db-callbacks as well.
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::databaseCallbacks):
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::PendingOpenCall):
(IDBDatabaseBackendImpl::PendingOpenCall):
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::create): Ditto.
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::databaseCallbacks):
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::PendingOpenWithVersionCall):
(IDBDatabaseBackendImpl::PendingOpenWithVersionCall):
(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::connectionCount): Don't need to count limbo connections any more.
(WebCore::IDBDatabaseBackendImpl::processPendingCalls): Pass through db-callbacks.
(WebCore::IDBDatabaseBackendImpl::openConnection): No more limbo connections (yay!).
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction): Pass through db-callbacks.
(WebCore::IDBDatabaseBackendImpl::openConnectionWithVersion): Ditto.
(WebCore::IDBDatabaseBackendImpl::deleteDatabase): Style.
(WebCore::IDBDatabaseBackendImpl::close): Resolve FIXME about connectionCount.

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBDatabaseBackendInterface.h:

(IDBDatabaseBackendInterface):

  • Modules/indexeddb/IDBDatabaseCallbacksImpl.cpp:

(WebCore::IDBDatabaseCallbacksImpl::create):
(WebCore::IDBDatabaseCallbacksImpl::IDBDatabaseCallbacksImpl):
(WebCore::IDBDatabaseCallbacksImpl::connect):

  • Modules/indexeddb/IDBDatabaseCallbacksImpl.h:

(IDBDatabaseCallbacksImpl):

  • Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::open): Mint the db-callbacks here...

  • Modules/indexeddb/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::open): ...passed through to here...

  • Modules/indexeddb/IDBFactoryBackendImpl.h:

(IDBFactoryBackendImpl):

  • Modules/indexeddb/IDBFactoryBackendInterface.h:

(IDBFactoryBackendInterface):

  • Modules/indexeddb/IDBOpenDBRequest.cpp:

(WebCore::IDBOpenDBRequest::create): ...all the way to here...
(WebCore::IDBOpenDBRequest::IDBOpenDBRequest):
(WebCore::IDBOpenDBRequest::onUpgradeNeeded): ...and finally hooked up here.
(WebCore::IDBOpenDBRequest::onSuccess): (or here, if no upgrade needed).

  • Modules/indexeddb/IDBOpenDBRequest.h:

(WebCore):
(IDBOpenDBRequest):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::onAbort): Tweak event/notification ordering; the
notifying the database that the transaction is finished may unblock closing,
which fires more events, and the delivery matters. Previously the close would
be blocked by the transaction which gave the desired order.
(WebCore::IDBTransaction::onComplete): Ditto.

  • inspector/InspectorIndexedDBAgent.cpp: New hookup logic.

(WebCore):

Source/WebKit/chromium:

API plumbing for simplified single-phase connection opening, and tests updated
to exercise the new APIs.

  • public/WebIDBDatabase.h:

(WebIDBDatabase): Just a FIXME to remove the old second-phase hookup API.

  • public/WebIDBFactory.h:

(WebKit):
(WebIDBFactory):
(WebKit::WebIDBFactory::open): New overload that takes db-callbacks.

  • src/IDBCallbacksProxy.cpp: The db-callbacks plumbing is needed earlier.

(WebKit::IDBCallbacksProxy::onSuccess):
(WebKit::IDBCallbacksProxy::onUpgradeNeeded):
(WebKit):
(WebKit::IDBCallbacksProxy::setDatabaseCallbacks): Needs to hold on to
the db-callbacks and hook it up when the onSuccess callback comes through.

  • src/IDBCallbacksProxy.h:

(WebKit):
(IDBCallbacksProxy):

  • src/IDBDatabaseBackendProxy.cpp:
  • src/IDBDatabaseBackendProxy.h:

(IDBDatabaseBackendProxy):

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::open):

  • src/IDBFactoryBackendProxy.h:

(IDBFactoryBackendProxy):

  • src/WebIDBDatabaseImpl.cpp:

(WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl):
(WebKit::WebIDBDatabaseImpl::close):

  • src/WebIDBDatabaseImpl.h:

(WebIDBDatabaseImpl):

  • src/WebIDBFactoryImpl.cpp:

(WebKit::WebIDBFactoryImpl::open):

  • src/WebIDBFactoryImpl.h:

(WebIDBFactoryImpl):

  • tests/IDBAbortOnCorruptTest.cpp:

(FakeIDBDatabaseCallbacks):
(WebCore::FakeIDBDatabaseCallbacks::create):
(WebCore::FakeIDBDatabaseCallbacks::~FakeIDBDatabaseCallbacks):
(WebCore::FakeIDBDatabaseCallbacks::FakeIDBDatabaseCallbacks):
(WebCore):
(WebCore::TEST): Updated connection sequence.

  • tests/IDBDatabaseBackendTest.cpp: Ditto.
5:26 PM Changeset in webkit [128532] by ap@apple.com
  • 3 edits in trunk/LayoutTests/platform

https://bugs.webkit.org/show_bug.cgi?id=93654
REGRESSION(r125126): It made fast/events/keyevent-iframe-removed-crash.html assert

Unskipped tests that should not assert any more (there were more than the one in
bug title). Re-attributed some remaining failures that were tracked together with that.

  • platform/gtk/TestExpectations:
  • platform/mac/Skipped:
  • platform/qt/TestExpectations:
5:20 PM Changeset in webkit [128531] by rniwa@webkit.org
  • 10 edits in trunk/Source

suspend/resumeWidgetHierarchyUpdates should be a RAII object
https://bugs.webkit.org/show_bug.cgi?id=96706

Reviewed by Simon Fraser.

Source/WebCore:

Replaced suspendWidgetHierarchyUpdates and resumeWidgetHierarchyUpdates by WidgetHierarchyUpdatesSuspensionScope.

  • WebCore.exp.in: Export new symbols.
  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::removeChildren):

  • dom/Document.cpp:

(WebCore::Document::recalcStyle):

  • dom/Element.cpp:

(WebCore::Element::attach):
(WebCore::Element::detach):

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passMouseDownEventToWidget):

  • rendering/RenderWidget.cpp:

(WebCore):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::widgetNewParentMap):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::moveWidgets):
(WebCore::moveWidgetToParentSoon):

  • rendering/RenderWidget.h:

(WidgetHierarchyUpdatesSuspensionScope):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::WidgetHierarchyUpdatesSuspensionScope):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::~WidgetHierarchyUpdatesSuspensionScope):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::isSuspended):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::scheduleWidgetToMove):
(WebCore):
(RenderWidget):

Source/WebKit/mac:

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _invalidateGStatesForTree]):

5:11 PM Changeset in webkit [128530] by ojan@chromium.org
  • 5 edits in trunk/LayoutTests

Remove lines for fast/table/bad-replaced-sizing-preferred-logical-widths.html
fixed in http://trac.webkit.org/changeset/128528.

  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
5:02 PM Changeset in webkit [128529] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Lots of repaints in the top left tile on this site
https://bugs.webkit.org/show_bug.cgi?id=96698

Reviewed by Anders Carlsson.

When given a rect outside of the current tile coverage rect,
TileCache::setNeedsDisplayInRect() would try to invalidate the
top left tile. This would normally be a no-op, except when repaint
counters are visible, in which case it would invalidate the counter
area.

Fix by doing an early return if the intersection between the repaint
rect and the tile coverage rect is empty.

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::setNeedsDisplayInRect):

4:53 PM Changeset in webkit [128528] by jamesr@google.com
  • 2 edits
    1 delete in trunk/LayoutTests

Unreviewed gardening for r128516/r128517:

remove the now-unnecessary cr-mac expectations for fast/writing-mode test.
fix baseline for fast/table/bad-replaced-sizing-preferred-logical-widths.html

  • platform/chromium-mac/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt: Removed.
4:48 PM Changeset in webkit [128527] by mrowe@apple.com
  • 4 edits in trunk/Source

<rdar://problem/12283706> WebKit looks for some files on the system even when building against an SDK.

Reviewed by David Kilzer.

If an SDK is being used, pass it through to our custom invocations of the preprocessor.

Source/WebCore:

  • DerivedSources.make:

Source/WebKit2:

  • DerivedSources.make:
4:29 PM Changeset in webkit [128526] by jamesr@google.com
  • 2 edits in trunk/Source/WebKit/chromium

PlatformGestureCurveTest compile fix pt 2

  • tests/PlatformGestureCurveTest.cpp:
4:18 PM Changeset in webkit [128525] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit/win

[WinCairo] Unreviewed build fix.

  • WebCookieManagerCurl.cpp: Remove unused 'using WebCore'

declaration that prevented the build from completing.

4:12 PM Changeset in webkit [128524] by tsepez@chromium.org
  • 3 edits
    2 adds in trunk

Source/WebCore: ASSERT(!eventDispatchForbidden()) fires when removed plugin re-inserted as part of readyStateChange.
https://bugs.webkit.org/show_bug.cgi?id=93639

Reviewed by Ryosuke Niwa.

Removing a plugin causes a detach which can cancel the last remaining load on a page,
resulting in a readyStateChange event during a time when things are inconsisent. Defer
the detach which triggers this chain of events until after the node is fully removed
from the document's elementsById map.

Test: plugins/plugin-remove-readystatechange.html

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::removeChildren):

LayoutTests: ASSERT(!eventDispatchForbidden()) firest when removed plugin re-inserted as part of readyStateChange.
https://bugs.webkit.org/show_bug.cgi?id=93639

Reviewed by Ryosuke Niwa.

Add a new testcase to cover this issue. Test passes if assert doesn't fire in debug builds.

  • plugins/plugin-remove-readystatechange-expected.txt: Added.
  • plugins/plugin-remove-readystatechange.html: Added.
4:09 PM Changeset in webkit [128523] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WinCairo] Unreviewed build fix for export declarations.

New entries were added to the standard Windows export definition
file, but were not added to the WinCairo version, breaking the build.

  • win/WebKit2CFLite.def: Incoproate changes from WebKit2.def file.
4:07 PM Changeset in webkit [128522] by jamesr@google.com
  • 2 edits in trunk/Source/WebKit/chromium

Fix compile warning/error on windows - literal that isn't exactly representable as a float needs "f" suffix.

  • tests/PlatformGestureCurveTest.cpp:
4:04 PM Changeset in webkit [128521] by timothy_horton@apple.com
  • 14 edits in trunk/Source

Add optional debug logging when we fall into/out of threaded scrolling
https://bugs.webkit.org/show_bug.cgi?id=93898
<rdar://problem/12089098>

Reviewed by Simon Fraser.

Add logging when we enter and exit the threaded scrolling mode, and logs the reasons we
fall into main-thread scrolling.

The logging output looks like this:

SCROLLING: Switching to main-thread scrolling mode. Time: 15843.554718 Reason(s): viewport-constrained objects
SCROLLING: Switching to threaded scrolling mode. Time: 15844.550866
SCROLLING: Switching to main-thread scrolling mode. Time: 15845.551214 Reason(s): viewport-constrained objects
SCROLLING: Switching to threaded scrolling mode. Time: 15846.552619
SCROLLING: Switching to main-thread scrolling mode. Time: 15847.553587 Reason(s): viewport-constrained objects
SCROLLING: Switching to threaded scrolling mode. Time: 15848.554084

No new tests, as this is just debugging logging.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::updateShouldUpdateScrollLayerPositionOnMainThread):
Construct a bitfield describing the reasons we fall into main-thread scrolling mode.

  • page/scrolling/ScrollingCoordinatorNone.cpp:

(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):

  • page/scrolling/ScrollingTreeNode.cpp:

(WebCore::ScrollingTreeNode::ScrollingTreeNode):

  • page/scrolling/ScrollingTreeNode.h:

(WebCore::ScrollingTreeNode::shouldUpdateScrollLayerPositionOnMainThread):

  • page/scrolling/ScrollingTreeState.cpp:

(WebCore::ScrollingTreeState::ScrollingTreeState):
(WebCore::ScrollingTreeState::setShouldUpdateScrollLayerPositionOnMainThread):

  • page/scrolling/ScrollingTreeState.h:

(WebCore::ScrollingTreeState::shouldUpdateScrollLayerPositionOnMainThread):

  • page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):
Use the reasons bitfield instead of a boolean.

  • page/scrolling/ScrollingCoordinator.h:

(ScrollingCoordinator):
Add MainThreadScrollingReasons enum, with the current reasons that we might fallback to main-thread scrolling.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::scrollingPerformanceLoggingEnabled):
Fix a typo (scrollingPeformanceLoggingEnabled -> scrollingPerformanceLoggingEnabled).

  • page/scrolling/mac/ScrollingTreeNodeMac.mm:

(WebCore::ScrollingTreeNodeMac::update):
(WebCore::ScrollingTreeNodeMac::setScrollPosition):
(WebCore::logThreadedScrollingMode):
Pretty-print the scrolling mode and shouldUpdateScrollLayerPositionOnMainThreadReason.

Update the scrolling tree's scrollingPerformanceLoggingEnabled preference
before the early-return if we don't have layer debugging borders on.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):

4:01 PM Changeset in webkit [128520] by jsbell@chromium.org
  • 12 edits in trunk/Source/WebCore

[V8] Binding: Generate batched attribute/const/callback struct names can collide
https://bugs.webkit.org/show_bug.cgi?id=96700

Reviewed by Kentaro Hara.

The V8 binding code generator spits out static arrays for batched configuration of
consts, attributes, and callbacks. Prior to this patch, it would spit them out
in the WebCore namespace with names like <BaseType>Callbacks which could collide with
other code. This change renames them from <BaseType><Suffix> to V8<BaseType><Suffix>.

Tests: Rebaselined the binding/scripts/test/V8/* results. No functional changes.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateImplementation):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(Float64ArrayV8Internal):
(WebCore):
(WebCore::ConfigureV8Float64ArrayTemplate):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(TestActiveDOMObjectV8Internal):
(WebCore):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(TestCustomNamedGetterV8Internal):
(WebCore):
(WebCore::ConfigureV8TestCustomNamedGetterTemplate):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(TestEventConstructorV8Internal):
(WebCore):
(WebCore::ConfigureV8TestEventConstructorTemplate):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(TestEventTargetV8Internal):
(WebCore):
(WebCore::ConfigureV8TestEventTargetTemplate):

  • bindings/scripts/test/V8/V8TestException.cpp:

(TestExceptionV8Internal):
(WebCore):
(WebCore::ConfigureV8TestExceptionTemplate):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(TestInterfaceV8Internal):
(WebCore):
(WebCore::ConfigureV8TestInterfaceTemplate):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(TestMediaQueryListListenerV8Internal):
(WebCore):
(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(TestObjV8Internal):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(TestSerializedScriptValueInterfaceV8Internal):
(WebCore):
(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):

3:58 PM Changeset in webkit [128519] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebCore

[EFL] Improve string manipulation in EflKeyboardUtilities.cpp
https://bugs.webkit.org/show_bug.cgi?id=96598

Reviewed by Benjamin Poulain.

Uses ASCIILiteral for static strings as recommended by
http://trac.webkit.org/wiki/EfficientStrings and uses HexNumber to remove
String::format.

No behavior change. Just a refactoring.

  • platform/efl/EflKeyboardUtilities.cpp:

(WebCore::addCharactersToKeyMap):
(WebCore::createKeyMap):
(WebCore::createWindowsKeyMap):

3:58 PM Changeset in webkit [128518] by mark.lam@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Adding myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
3:56 PM Changeset in webkit [128517] by ojan@chromium.org
  • 18 edits
    2 adds in trunk

percentage heights in quirks mode with auto-sized body are computed incorrectly
https://bugs.webkit.org/show_bug.cgi?id=96426

Reviewed by Tony Chang.

Source/WebCore:

In quirks mode, for the body element, we need to keep walking up to the html element
if the body's height is auto. Also, we need to subtract the body/html elements
margin/border/padding so that we properly get the body's content height.

This behavior matches IE9, FF and Opera.

None of this applies to standards mode since we don't walk up the
containingBlock chain for auto-sized elements.

Test: fast/css/percentage-height-auto-sized-body-quirks.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePercentageLogicalHeight):

LayoutTests:

  • fast/css/percentage-height-auto-sized-body-quirks-expected.txt: Added.
  • fast/css/percentage-height-auto-sized-body-quirks.html: Added.

Verified that this matches IE9, FF15 and Opera12.

  • fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt:
  • platform/chromium-linux/fast/table/height-percent-test-expected.png:
  • platform/chromium-linux/tables/mozilla/core/cell_heights-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug19526-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/chromium-win/tables/mozilla/core/cell_heights-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug19526-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
  • platform/mac/fast/table/height-percent-test-expected.txt:

Verified that all the changes match FF15.

3:52 PM Changeset in webkit [128516] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

fast/table/bad-replaced-sizing-preferred-logical-widths.html is failing on Mac, Chromium-Mac, GTK, EFL
https://bugs.webkit.org/show_bug.cgi?id=96594

Reviewed by Tony Chang.

Remove the text so that this test gets metrics the same across platforms.

  • fast/table/bad-replaced-sizing-preferred-logical-widths.html:
3:50 PM Changeset in webkit [128515] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Fix lint error in my last TestExpectations patch - whoops!

  • platform/chromium/TestExpectations:
3:32 PM Changeset in webkit [128514] by enne@google.com
  • 3 edits
    4 adds in trunk

Hide all ancestors of the full screen element when going full screen
https://bugs.webkit.org/show_bug.cgi?id=96332

Reviewed by James Robinson.

Source/WebCore:

Since fixed position elements can now sometimes become stacking
contexts, explicitly set position: static on full-screen ancestors so
that there are no stacking context ancestors that could cause the full
screen element to become incorrectly sorted.

Test: fullscreen/full-screen-fixed-pos-parent.html

  • css/fullscreen.css:

(:-webkit-full-screen-ancestor:not(iframe)):

LayoutTests:

This test has an all red image that (without this patch) incorrectly
sorts on top of the full screen element. With this patch, the all
green full screen element appears on top.

  • fullscreen/full-screen-fixed-pos-parent-expected.png: Added.
  • fullscreen/full-screen-fixed-pos-parent-expected.txt: Added.
  • fullscreen/full-screen-fixed-pos-parent.html: Added.
  • fullscreen/resources/green.html: Added.
3:19 PM Changeset in webkit [128513] by abarth@webkit.org
  • 4 edits
    2 adds in trunk

REGRESSION(r125126): It made fast/events/keyevent-iframe-removed-crash.html assert
https://bugs.webkit.org/show_bug.cgi?id=93654

Reviewed by Eric Seidel.

Source/WebCore:

When wrapping a Document, we need to ensure that the global object for
the wrapper actually exists before trying to create the wrapper. In
other cases in the DOM, we always touch the global object before trying
to wrap a given DOM object. For Document, however,
HTMLFrameElement.contentDocument is a rare way to get at a DOM object
for a global object without first touching the Window object.

Rather than writing custom bindings for
HTMLFrameElement.contentDocument, this patch just makes toJS for
Document ensure that toJS for DOMWindow has been called first. The V8
bindings have some similar code.

Test: fast/dom/content-document-prototype.html

  • bindings/js/JSDocumentCustom.cpp:

(WebCore::toJS):

LayoutTests:

  • fast/dom/content-document-prototype-expected.txt: Added.
  • fast/dom/content-document-prototype.html: Added.
    • Check that HTMLFrameElement.contentDocument ends up with the right prototype chain. This is a tricky case because not only the prototype chain of the property different from the holder, we never actually touch the DOMWindow in this test case so the prototype chain leads to a global object that doesn't even exist yet!
  • fast/events/keyevent-iframe-removed-crash.html:
    • Add a call to gc() so that this test will ASSERT reliabily if we cause a similar problem in the future.
3:13 PM Changeset in webkit [128512] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix build.

  • platform/graphics/Latin1TextIterator.h:

(WebCore::Latin1TextIterator::Latin1TextIterator):
(Latin1TextIterator):
m_endCharacter is an unused private member variable, so just remove it to appease newer versions of clang.

2:51 PM Changeset in webkit [128511] by rniwa@webkit.org
  • 3 edits in trunk/Tools

run-perf-tests output cryptic error when the config file is missing.
https://bugs.webkit.org/show_bug.cgi?id=96453

Reviewed by Tony Chang.

Add a special error message when a configuration file is missing.

Also update the help message of --source-json-path to signify the fact it specifies
the configuration file on performance tests bots.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._parse_args):
(PerfTestsRunner._generate_and_show_results):
(PerfTestsRunner._merge_slave_config_json):

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(_test_run_with_json_output): Make upload to fail by default and assert the result
in the function so that we can return logs instead.
(_test_run_with_json_output.mock_upload_json):
(test_run_with_json_output):
(test_run_with_description):
(test_run_respects_no_results):
(test_run_with_slave_config_json):
(test_run_with_bad_slave_config_json):
(test_run_with_multiple_repositories):

2:29 PM Changeset in webkit [128510] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening - upstream some skia_test_expectations.txt entries.

  • platform/chromium/TestExpectations:
2:21 PM Changeset in webkit [128509] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Cleanup AboutDataEnableFeatures.in
https://bugs.webkit.org/show_bug.cgi?id=96695

Reviewed by Antonio Gomes.

Remove unused features.

  • WebCoreSupport/AboutDataEnableFeatures.in:
2:21 PM Changeset in webkit [128508] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Typo in RenderStyle::isFlippedLinesWritingMode(), small refactoring possible
https://bugs.webkit.org/show_bug.cgi?id=96679

Patch by Hans Muller <hmuller@adobe.com> on 2012-09-13
Reviewed by Darin Adler.

Fixed a typo in the comment for RenderStyle::isFlippedLinesWritingMode() and refactored the
three RendersStyle::isXXXWritingMode() inlines to use the inlines defined in WritingMode.h.
Moved the comments to WritingMode.h

No new tests needed.

  • platform/text/WritingMode.h:

(WebCore):

  • rendering/style/RenderStyle.h:
2:19 PM Changeset in webkit [128507] by kenneth@webkit.org
  • 12 edits
    2 moves in trunk

Evas_Object* is a ref'ed structure, so tread it as such
https://bugs.webkit.org/show_bug.cgi?id=96659

Reviewed by Adam Barth.

Source/WebCore:

Replace OwnPtr<Evas_Object> with RefPtr.

  • PlatformEfl.cmake:
  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::ThemePartCacheEntry::create):
(WebCore::RenderThemeEfl::loadTheme):
(WebCore::RenderThemeEfl::applyPartDescriptionsFrom):

  • platform/efl/RenderThemeEfl.h:

(RenderThemeEfl):
(ThemePartCacheEntry):

Source/WebKit/efl:

Replace OwnPtr<Evas_Object> with RefPtr.

  • tests/UnitTestUtils/EWKTestView.cpp:

(EWKUnitTests::EWKTestView::init):

  • tests/UnitTestUtils/EWKTestView.h:

(EWKTestView):

Source/WTF:

Remove OwnPtr support for Evas_Object* and add support for it
with RefPtr instead (the latter moved from WebCore).

  • wtf/PlatformEfl.cmake:
  • wtf/efl/OwnPtrEfl.cpp:
  • wtf/efl/RefPtrEfl.cpp: Renamed from Source/WebCore/platform/efl/RefPtrEfl.cpp.

(WTF):
(WTF::refIfNotNull):
(WTF::derefIfNotNull):

  • wtf/efl/RefPtrEfl.h: Renamed from Source/WebCore/platform/efl/RefPtrEfl.h.

(WTF):

Tools:

Replace OwnPtr<Evas_Object> with RefPtr.

  • DumpRenderTree/efl/ImageDiff.cpp:

(calculateDifference):
(printImageDifferences):
(readImageFromStdin):
(main):

2:07 PM Changeset in webkit [128506] by rniwa@webkit.org
  • 2 edits in trunk/Websites/webkit.org

Another typo fix. Apparently, I "fixed" the wrong line in the previous commit.

  • coding/coding-style.html:
2:05 PM Changeset in webkit [128505] by jchaffraix@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] REGRESSION(r127457): Context menu on textarea is displayed in the wrong place
https://bugs.webkit.org/show_bug.cgi?id=96593

Reviewed by Adam Barth.

After r127457, the HitTestResult stored in ContextMenuController is in window coordinates.
Trying to convert it again to window coordinates will result in adding the containing frame's
position twice, thus the wrong placing.

Chromium Mac wasn't impacted by the regression and I manually checked that the fix doesn't impact Mac.

Unfortunately, no test as I don't think we have a way of testing context menu position.

  • src/ContextMenuClientImpl.cpp:

(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

2:03 PM Changeset in webkit [128504] by msaboff@apple.com
  • 12 edits
    1 copy in trunk/Source

Added 8 bit path to WidthIterator::advance()
https://bugs.webkit.org/show_bug.cgi?id=96590

Reviewed by Geoffrey Garen.

Source/WebCore:

Added 8 bit path to advance() by adding a templatized advanceInternal private
method and added a simple 8 bit Latin-1 TextIterator. Updated SurrogatePairAwareTextIterator
by making both consume() and advance() inlined and adding consumeSlowCase() for
surrogate handling. These changes are a performance progression on the Layout tests.

No new tests because of no behavior changes.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/Latin1TextIterator.h: Copied from Source/WebCore/platform/graphics/SurrogatePairAwareTextIterator.h.

(Latin1TextIterator):
(WebCore::Latin1TextIterator::Latin1TextIterator):
(WebCore::Latin1TextIterator::consume):
(WebCore::Latin1TextIterator::advance):
(WebCore::Latin1TextIterator::characters):

  • platform/graphics/SurrogatePairAwareTextIterator.cpp:

(WebCore::SurrogatePairAwareTextIterator::consumeSlowCase):

  • platform/graphics/SurrogatePairAwareTextIterator.h:

(WebCore::SurrogatePairAwareTextIterator::consume):
(SurrogatePairAwareTextIterator):
(WebCore::SurrogatePairAwareTextIterator::advance):

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::advanceInternal):
(WebCore::WidthIterator::advance):

  • platform/graphics/WidthIterator.h:

(WidthIterator):

Source/WTF:

Added new character constant for Hiragana Letter Small A.

  • wtf/unicode/CharacterNames.h:

(Unicode):

1:49 PM Changeset in webkit [128503] by rniwa@webkit.org
  • 2 edits in trunk/Websites/webkit.org

Fix a typo per Darin's comment.

  • coding/coding-style.html:
1:43 PM Changeset in webkit [128502] by rwlbuis@webkit.org
  • 2 edits
    2 moves in trunk/Source/WebKit/blackberry

[BlackBerry] Rename InspectorOverlay in blackberry/WebKitSupport
https://bugs.webkit.org/show_bug.cgi?id=96689

Reviewed by Antonio Gomes.

Rename to InspectorClientBlackBerry to avoid include problems.

  • WebCoreSupport/InspectorClientBlackBerry.h:
  • WebKitSupport/InspectorOverlayBlackBerry.cpp: Renamed from Source/WebKit/blackberry/WebKitSupport/InspectorOverlay.cpp.

(WebKit):
(BlackBerry::WebKit::InspectorOverlay::create):
(BlackBerry::WebKit::InspectorOverlay::InspectorOverlay):
(BlackBerry::WebKit::InspectorOverlay::notifySyncRequired):
(BlackBerry::WebKit::InspectorOverlay::paintContents):
(BlackBerry::WebKit::InspectorOverlay::showDebugBorders):
(BlackBerry::WebKit::InspectorOverlay::showRepaintCounter):
(BlackBerry::WebKit::InspectorOverlay::~InspectorOverlay):
(BlackBerry::WebKit::InspectorOverlay::clear):
(BlackBerry::WebKit::InspectorOverlay::update):

  • WebKitSupport/InspectorOverlayBlackBerry.h: Renamed from Source/WebKit/blackberry/WebKitSupport/InspectorOverlay.h.

(WebCore):
(WebKit):
(InspectorOverlay):
(InspectorOverlayClient):
(BlackBerry::WebKit::InspectorOverlay::setClient):
(BlackBerry::WebKit::InspectorOverlay::notifyAnimationStarted):

1:26 PM Changeset in webkit [128501] by rjkroege@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] alter fling animation parameters.
https://bugs.webkit.org/show_bug.cgi?id=96666

Reviewed by Adrienne Walker.

Corrected the test to be non-fragile in the presence of altered fling
curve parameters.

  • tests/PlatformGestureCurveTest.cpp:
1:23 PM Changeset in webkit [128500] by commit-queue@webkit.org
  • 17 edits in trunk/LayoutTests

Text Autosizing: Add explanations to tests.
https://bugs.webkit.org/show_bug.cgi?id=96673

Patch by John Mellor <johnme@chromium.org> on 2012-09-13
Reviewed by Julien Chaffraix.

Replaces some of the lorem ipsum filler text in Text Autosizing tests
with explanations of why the result is expected (and other minor tweaks
to tests).

  • fast/text-autosizing/font-scale-factor-expected.html:
  • fast/text-autosizing/font-scale-factor.html:
  • fast/text-autosizing/narrow-iframe-expected.html:
  • fast/text-autosizing/narrow-iframe-flattened-expected.html:
  • fast/text-autosizing/narrow-iframe-flattened.html:
  • fast/text-autosizing/narrow-iframe.html:
  • fast/text-autosizing/nested-em-line-height-expected.html:
  • fast/text-autosizing/nested-em-line-height.html:
  • fast/text-autosizing/simple-paragraph-expected.html:
  • fast/text-autosizing/simple-paragraph.html:
  • fast/text-autosizing/span-child-expected.html:
  • fast/text-autosizing/span-child.html:
  • fast/text-autosizing/various-font-sizes-expected.html:
  • fast/text-autosizing/various-font-sizes.html:
  • fast/text-autosizing/wide-block-expected.html:
  • fast/text-autosizing/wide-block.html:
1:17 PM Changeset in webkit [128499] by rniwa@webkit.org
  • 2 edits in trunk/Websites/webkit.org

Add a style guide rule for signed and unsigned int
https://bugs.webkit.org/show_bug.cgi?id=96682

Reviewed by Geoffrey Garen.

Add a rule per http://lists.webkit.org/pipermail/webkit-dev/2012-September/022199.html.

  • coding/coding-style.html:
1:08 PM Changeset in webkit [128498] by mhahnenberg@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Rename forEachCell to forEachLiveCell
https://bugs.webkit.org/show_bug.cgi?id=96685

Reviewed by Oliver Hunt.

forEachCell actually only iterates over live cells. We should rename it to
reflect what it actually does. This is also helpful because we want to add a new
forEachCell that actually does iterate each and every cell in a MarkedBlock
regardless of whether or not it is live.

  • debugger/Debugger.cpp:

(JSC::Debugger::recompileAllJSFunctions):

  • heap/Heap.cpp:

(JSC::Heap::globalObjectCount):
(JSC::Heap::objectTypeCounts):

  • heap/MarkedBlock.h:

(MarkedBlock):
(JSC::MarkedBlock::forEachLiveCell):

  • heap/MarkedSpace.h:

(MarkedSpace):
(JSC::MarkedSpace::forEachLiveCell):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::releaseExecutableMemory):

1:02 PM Changeset in webkit [128497] by yoli@rim.com
  • 2 edits in trunk/Source/WebCore

[BlackBerry] ResourceRequest string optimizations
https://bugs.webkit.org/show_bug.cgi?id=96661

Reviewed by Rob Buis.

RIM PR# 207965.
Call PlatformRequest's method to add the Accept-Language header.

No new tests as no functional change.

  • platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::ResourceRequest::initializePlatformRequest):

12:57 PM Changeset in webkit [128496] by commit-queue@webkit.org
  • 31 edits in trunk/Source

Unreviewed, rolling out r128489.
http://trac.webkit.org/changeset/128489
https://bugs.webkit.org/show_bug.cgi?id=96686

Does not compile on windows (Requested by jamesr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-13

Source/WebCore:

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::create):
(WebCore::IDBDatabase::IDBDatabase):
(WebCore::IDBDatabase::~IDBDatabase):
(WebCore::IDBDatabase::registerFrontendCallbacks):
(WebCore):

  • Modules/indexeddb/IDBDatabase.h:

(IDBDatabase):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::create):
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::PendingOpenCall):
(IDBDatabaseBackendImpl::PendingOpenCall):
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::create):
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::PendingOpenWithVersionCall):
(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::connectionCount):
(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::registerFrontendCallbacks):
(WebCore):
(WebCore::IDBDatabaseBackendImpl::openConnection):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):
(WebCore::IDBDatabaseBackendImpl::openConnectionWithVersion):
(WebCore::IDBDatabaseBackendImpl::deleteDatabase):
(WebCore::IDBDatabaseBackendImpl::close):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBDatabaseBackendInterface.h:

(IDBDatabaseBackendInterface):

  • Modules/indexeddb/IDBDatabaseCallbacksImpl.cpp:

(WebCore::IDBDatabaseCallbacksImpl::create):
(WebCore::IDBDatabaseCallbacksImpl::IDBDatabaseCallbacksImpl):
(WebCore::IDBDatabaseCallbacksImpl::unregisterDatabase):

  • Modules/indexeddb/IDBDatabaseCallbacksImpl.h:

(IDBDatabaseCallbacksImpl):

  • Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::open):

  • Modules/indexeddb/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::open):

  • Modules/indexeddb/IDBFactoryBackendImpl.h:

(IDBFactoryBackendImpl):

  • Modules/indexeddb/IDBFactoryBackendInterface.h:

(IDBFactoryBackendInterface):

  • Modules/indexeddb/IDBOpenDBRequest.cpp:

(WebCore::IDBOpenDBRequest::create):
(WebCore::IDBOpenDBRequest::IDBOpenDBRequest):
(WebCore::IDBOpenDBRequest::onUpgradeNeeded):
(WebCore::IDBOpenDBRequest::onSuccess):

  • Modules/indexeddb/IDBOpenDBRequest.h:

(IDBOpenDBRequest):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):

  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):

Source/WebKit/chromium:

  • public/WebIDBDatabase.h:
  • public/WebIDBFactory.h:

(WebIDBFactory):

  • src/IDBCallbacksProxy.cpp:

(WebKit::IDBCallbacksProxy::onSuccess):
(WebKit::IDBCallbacksProxy::onUpgradeNeeded):

  • src/IDBCallbacksProxy.h:

(WebKit):
(IDBCallbacksProxy):

  • src/IDBDatabaseBackendProxy.cpp:

(WebKit::IDBDatabaseBackendProxy::registerFrontendCallbacks):
(WebKit):

  • src/IDBDatabaseBackendProxy.h:

(IDBDatabaseBackendProxy):

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::open):

  • src/IDBFactoryBackendProxy.h:

(IDBFactoryBackendProxy):

  • src/WebIDBDatabaseImpl.cpp:

(WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl):
(WebKit::WebIDBDatabaseImpl::close):
(WebKit::WebIDBDatabaseImpl::open):
(WebKit):

  • src/WebIDBDatabaseImpl.h:

(WebIDBDatabaseImpl):

  • src/WebIDBFactoryImpl.cpp:

(WebKit::WebIDBFactoryImpl::open):

  • src/WebIDBFactoryImpl.h:

(WebIDBFactoryImpl):

  • tests/IDBAbortOnCorruptTest.cpp:

(WebCore::TEST):

  • tests/IDBDatabaseBackendTest.cpp:
12:52 PM Changeset in webkit [128495] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

One more unreviewed trivial fix after r128399.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Fix URLs of the SVN mirror server.
12:49 PM Changeset in webkit [128494] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

Refactor duplicate code into RenderFlexibleBox::mainAxisContentExtent
https://bugs.webkit.org/show_bug.cgi?id=96676

Reviewed by Eric Seidel.

There was computeAvailableFreeSpace() and lineBreakLength() shared some very similar code.
Merge this code into mainAxisContentExtent().

No new tests, this is just a refactor.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::mainAxisContentExtent): Take contentLogicalHeight as a parameter,
which is needed when determining the logical height.
(WebCore::RenderFlexibleBox::computeAvailableFreeSpace): Use mainAxisContentExtent() and inline.
(WebCore::RenderFlexibleBox::computeNextFlexLine): Use mainAxisContentExtent().

  • rendering/RenderFlexibleBox.h:
12:46 PM Changeset in webkit [128493] by Csaba Osztrogonác
  • 1 edit
    1 move in trunk/Tools

Unreviewed trivial fix after r128399.

  • BuildSlaveSupport/wait-for-SVN-server.py: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py.

(getLatestSVNRevision):
(waitForSVNRevision):

12:32 PM WebKitGTK/1.10.x edited by dsd@laptop.org
(diff)
12:26 PM Changeset in webkit [128492] by commit-queue@webkit.org
  • 6 edits in trunk/Source

Add new accelerated compositing for overflow scroll setting.
https://bugs.webkit.org/show_bug.cgi?id=95885

Patch by Glenn Hartmann <hartmanng@chromium.org> on 2012-09-13
Reviewed by James Robinson.

wkb.ug/91117 introduces RenderLayer::usesCompositedScrolling(), which
currently returns true if we're overflow scrolling and the element has
been styled with '-webkit-overflow-scrolling: touch'. If this is true,
we get promoted to a composited layer, the associated RenderLayerBacking
gets special scrolling layers and in response to RenderLayer::scrollTo()
we no longer have to invalidate everything to get the scrolled content
in the right spot, thereby avoiding very expensive repaints. It's
unfortunate that we require -webkit-overflow-scrolling: touch, though.
It would be nice if RenderLayer::usesCompositedScrolling() returned true
if the page would continue to behave correctly. This is what
wkb.ug/94743 is intended to do. Unfortunately, when we become a
composited layer, we switch from subpixel to grayscale anti-aliasing. We
only want to auto-opt into composited scrolling if we don't mind the
change in anti-aliasing, so we need a flag to enable/disable this
feature.

Source/WebCore:

No new tests -- no change in behaviour.

  • page/Settings.h:

(WebCore::Settings::setAcceleratedCompositingForOverflowScrollEnabled):
(WebCore::Settings::acceleratedCompositingForOverflowScrollEnabled):
(Settings):

Source/WebKit/chromium:

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setAcceleratedCompositingForOverflowScrollEnabled):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

12:26 PM Changeset in webkit [128491] by commit-queue@webkit.org
  • 9 edits in trunk

[WK2][WTR] WebKitTestRunner needs testRunner.callShouldCloseOnWebView
https://bugs.webkit.org/show_bug.cgi?id=96366

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-13
Reviewed by Anders Carlsson.

Source/WebKit2:

Implement testRunner.callShouldCloseOnWebView for WebKitTestRunner
by calling shouldClose() on the FrameLoader.

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameCallShouldCloseOnWebView):

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h:

Tools:

Implement testRunner.callShouldCloseOnWebView for WebKitTestRunner
by calling shouldClose() on the FrameLoader.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::callShouldCloseOnWebView):
(WTR):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

LayoutTests:

Unskip passing test fast/events/onbeforeunload-focused-iframe.html

  • platform/wk2/Skipped:
12:21 PM Changeset in webkit [128490] by zandobersek@gmail.com
  • 6 edits in trunk

Unreviewed, rolling out r128453.
http://trac.webkit.org/changeset/128453
https://bugs.webkit.org/show_bug.cgi?id=96681

Having tests use the same appcache directory leads to timeouts
(Requested by zdobersek on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-13

Source/WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::clearMemoryCache):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Tools:

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(runTest):

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort.setup_environ_for_server):

12:19 PM Changeset in webkit [128489] by jsbell@chromium.org
  • 31 edits in trunk/Source

IndexedDB: Consolidate two-phase connection to avoid race conditions
https://bugs.webkit.org/show_bug.cgi?id=90411

Reviewed by Tony Chang.

Source/WebCore:

Previously, IDB connections were opened by having the front-end (1) call through to
a back-end open() method, eventually receive a success message with a back-end object
handle, and (2) call into the back-end object to register front-end callbacks. This left
the back-end's notion of an open connection in a limbo state between these two calls.
In multi-process ports, a crash of the front-end process could leave the back-end wedged
waiting for this second call (e.g. can't delete until all connections are closed).

Simplify this by having the front-end pass through the callbacks into the back-end
during the initial open() call, which eliminates the limbo state.

No new tests - no functional changes. Chromium port's webkit_unit_tests updated.

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::create):
(WebCore::IDBDatabase::IDBDatabase): Db-callbacks is available at creation time.
(WebCore::IDBDatabase::~IDBDatabase):

  • Modules/indexeddb/IDBDatabase.h:

(IDBDatabase):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::create): Need to track db-callbacks as well.
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::databaseCallbacks):
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::PendingOpenCall):
(IDBDatabaseBackendImpl::PendingOpenCall):
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::create): Ditto.
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::databaseCallbacks):
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::PendingOpenWithVersionCall):
(IDBDatabaseBackendImpl::PendingOpenWithVersionCall):
(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::connectionCount): Don't need to count limbo connections any more.
(WebCore::IDBDatabaseBackendImpl::processPendingCalls): Pass through db-callbacks.
(WebCore::IDBDatabaseBackendImpl::openConnection): No more limbo connections (yay!).
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction): Pass through db-callbacks.
(WebCore::IDBDatabaseBackendImpl::openConnectionWithVersion): Ditto.
(WebCore::IDBDatabaseBackendImpl::deleteDatabase): Style.
(WebCore::IDBDatabaseBackendImpl::close): Resolve FIXME about connectionCount.

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBDatabaseBackendInterface.h:

(IDBDatabaseBackendInterface):

  • Modules/indexeddb/IDBDatabaseCallbacksImpl.cpp:

(WebCore::IDBDatabaseCallbacksImpl::create):
(WebCore::IDBDatabaseCallbacksImpl::IDBDatabaseCallbacksImpl):
(WebCore::IDBDatabaseCallbacksImpl::connect):

  • Modules/indexeddb/IDBDatabaseCallbacksImpl.h:

(IDBDatabaseCallbacksImpl):

  • Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::open): Mint the db-callbacks here...

  • Modules/indexeddb/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::open): ...passed through to here...

  • Modules/indexeddb/IDBFactoryBackendImpl.h:

(IDBFactoryBackendImpl):

  • Modules/indexeddb/IDBFactoryBackendInterface.h:

(IDBFactoryBackendInterface):

  • Modules/indexeddb/IDBOpenDBRequest.cpp:

(WebCore::IDBOpenDBRequest::create): ...all the way to here...
(WebCore::IDBOpenDBRequest::IDBOpenDBRequest):
(WebCore::IDBOpenDBRequest::onUpgradeNeeded): ...and finally hooked up here.
(WebCore::IDBOpenDBRequest::onSuccess): (or here, if no upgrade needed).

  • Modules/indexeddb/IDBOpenDBRequest.h:

(WebCore):
(IDBOpenDBRequest):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::onAbort): Tweak event/notification ordering; the
notifying the database that the transaction is finished may unblock closing,
which fires more events, and the delivery matters. Previously the close would
be blocked by the transaction which gave the desired order.
(WebCore::IDBTransaction::onComplete): Ditto.

  • inspector/InspectorIndexedDBAgent.cpp: New hookup logic.

(WebCore):

Source/WebKit/chromium:

API plumbing for simplified single-phase connection opening, and tests updated
to exercise the new APIs.

  • public/WebIDBDatabase.h:

(WebIDBDatabase): Just a FIXME to remove the old second-phase hookup API.

  • public/WebIDBFactory.h:

(WebKit):
(WebIDBFactory):
(WebKit::WebIDBFactory::open): New overload that takes db-callbacks.

  • src/IDBCallbacksProxy.cpp: The db-callbacks plumbing is needed earlier.

(WebKit::IDBCallbacksProxy::onSuccess):
(WebKit::IDBCallbacksProxy::onUpgradeNeeded):
(WebKit):
(WebKit::IDBCallbacksProxy::setDatabaseCallbacks): Needs to hold on to
the db-callbacks and hook it up when the onSuccess callback comes through.

  • src/IDBCallbacksProxy.h:

(WebKit):
(IDBCallbacksProxy):

  • src/IDBDatabaseBackendProxy.cpp:
  • src/IDBDatabaseBackendProxy.h:

(IDBDatabaseBackendProxy):

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::open):

  • src/IDBFactoryBackendProxy.h:

(IDBFactoryBackendProxy):

  • src/WebIDBDatabaseImpl.cpp:

(WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl):
(WebKit::WebIDBDatabaseImpl::close):

  • src/WebIDBDatabaseImpl.h:

(WebIDBDatabaseImpl):

  • src/WebIDBFactoryImpl.cpp:

(WebKit::WebIDBFactoryImpl::open):

  • src/WebIDBFactoryImpl.h:

(WebIDBFactoryImpl):

  • tests/IDBAbortOnCorruptTest.cpp:

(FakeIDBDatabaseCallbacks):
(WebCore::FakeIDBDatabaseCallbacks::create):
(WebCore::FakeIDBDatabaseCallbacks::~FakeIDBDatabaseCallbacks):
(WebCore::FakeIDBDatabaseCallbacks::FakeIDBDatabaseCallbacks):
(WebCore):
(WebCore::TEST): Updated connection sequence.

  • tests/IDBDatabaseBackendTest.cpp: Ditto.
12:06 PM Changeset in webkit [128488] by jamesr@google.com
  • 2 edits in trunk/Tools

[chromium] Temporarily remove Android Builder (dbg) from garden-o-matic view
https://bugs.webkit.org/show_bug.cgi?id=96678

Reviewed by Dirk Pranke.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:

(.):

12:03 PM WebKitGTK/1.10.x edited by dsd@laptop.org
(diff)
11:41 AM Changeset in webkit [128487] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-13

  • DEPS:
11:39 AM Changeset in webkit [128486] by tony@chromium.org
  • 6 edits in trunk

Flexitem margins should be based on content width, not width
https://bugs.webkit.org/show_bug.cgi?id=96674

Reviewed by Ojan Vafai.

Source/WebCore:

Margins should be based on content width. Also remove some calls to
mainAxisContentExtent() when we can use contentLogicalWidth instead.

Tests: css3/flexbox/percent-margins.html has a new testcase.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computeMainAxisExtentForChild): Use contentLogicalWidth instead of
passing in the maximum value (only used in the width case).
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild): Don't pass in mainAxisContentExtent.
(WebCore::RenderFlexibleBox::computeChildMarginValue): Use contentLogicalWidth and simplify the code.
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes): Remove unnecessary mainAxisContentExtent() call.
(WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax): Remove unnecessary flexboxAvailableContentExtent.
(WebCore::RenderFlexibleBox::computeNextFlexLine): Remove unnecessary mainAxisContentExtent() call.
(WebCore::RenderFlexibleBox::resolveFlexibleLengths): Remove unnecessary mainAxisContentExtent() call.

  • rendering/RenderFlexibleBox.h: Remove unnecessary params.

LayoutTests:

Add a test case where contentWidth != width.

  • css3/flexbox/percent-margins-expected.txt:
  • css3/flexbox/percent-margins.html:
11:33 AM Changeset in webkit [128485] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[EFL] Assertion reached on RenderThemeEFL when setting a theme to an invalid path
https://bugs.webkit.org/show_bug.cgi?id=96649

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-09-13
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Keep the consistence by restoring the reference to the old theme path
when the new one cannot be loaded.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::setThemePath):

Source/WebKit2:

Updated the alternative test theme file. It is basically
the default theme with extra padding on the button widget as
specified by the comments on the test case.

  • UIProcess/API/efl/tests/resources/big_button_theme.edj:
11:16 AM Changeset in webkit [128484] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

Unreviewed, warning fix left over from r128456 (bug 96645)

Patch by Antonio Gomes <agomes@rim.com> on 2012-09-13

  • Api/InRegionScroller.cpp:

(WebKit):

11:16 AM Changeset in webkit [128483] by rjkroege@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] alter fling animation parameters.
https://bugs.webkit.org/show_bug.cgi?id=96666

Reviewed by Adrienne Walker.

Adjusted configuration parameters for fling animation to have a longer
tail and more similarity between touchpad and touchscreen.

Covered by existing tests.

  • platform/TouchFlingPlatformGestureCurve.cpp:

(WebCore::TouchFlingPlatformGestureCurve::createForTouchPad):
(WebCore::TouchFlingPlatformGestureCurve::createForTouchScreen):

11:05 AM Changeset in webkit [128482] by jsbell@chromium.org
  • 6 edits in trunk

IndexedDB: Properties of IDBKeyRange should default to undefined
https://bugs.webkit.org/show_bug.cgi?id=96401

Reviewed by Adam Barth.

Source/WebCore:

Per the IndexedDB spec, properties of IDBKeyRange should be |undefined| if
not set (i.e. range.upper if created with lowerBound(), and vice versa), rather
than null.

Test: storage/indexeddb/keyrange.html

  • bindings/v8/custom/V8IDBKeyCustom.cpp:

(WebCore::toV8): Since IDBKeyRange is the only place where possibly-null
keys are returned to script, change the JS value from null to undefined.
And call v8Undefined(). It's faster.

  • bindings/js/custom/JSIDBKeyCustom.cpp:

(WebCore::toJS): Ditto.

LayoutTests:

Update test expectations.

  • storage/indexeddb/keyrange-expected.txt:
  • storage/indexeddb/resources/keyrange.js:

(checkLowerBoundKeyRange):
(checkUpperBoundKeyRange):

11:03 AM Changeset in webkit [128481] by rwlbuis@webkit.org
  • 2 edits in trunk/Tools

Unreviewed changes to watchlist.

  • Add myself to BlackBerry bugs
  • Scripts/webkitpy/common/config/watchlist:
10:50 AM Changeset in webkit [128480] by schenney@chromium.org
  • 2 edits in trunk/Tools

Add an SVG entry to the watchlist

Unreviewed config change.

  • Scripts/webkitpy/common/config/watchlist:
  • Created a new SVG watchlist label covering WebCore/svg and WebCore/rendering/svg
  • Added myself and pdr as watchers
10:29 AM Changeset in webkit [128479] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

Continue to send mouse move events to a non-scrollable page
even if they are not consumed.
PR #207024
https://bugs.webkit.org/show_bug.cgi?id=96655

Patch by Genevieve Mak <gmak@rim.com> on 2012-09-13
Reviewed by Antonio Gomes.

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::isMainFrameScrollable):
(WebKit):
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):

10:22 AM Changeset in webkit [128478] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Refactor paint overflow clipping
https://bugs.webkit.org/show_bug.cgi?id=96625

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-09-13
Reviewed by Simon Fraser.

The same logic for applying overflow clipping based on the cached size of a
RenderBox has been duplicated to four different places. Consolidate them to a
single RenderBox utility function.

This is in preparation for https://bugs.webkit.org/show_bug.cgi?id=96087.

No new functionality; covered by existing tests.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::applyCachedClipAndScrollOffsetForRepaint):
(WebCore):
(WebCore::RenderBox::computeRectForRepaint):

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::clippedOverflowRectForRepaint):
(WebCore::RenderInline::computeRectForRepaint):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::computeRectForRepaint):

10:03 AM Changeset in webkit [128477] by zhajiang@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Missing conditions in InRegionScrollerPrivate::canScrollRenderBox
https://bugs.webkit.org/show_bug.cgi?id=96660

Reviewed by Antonio Gomes.
Patch by Jacky Jiang <zhajiang@rim.com>

PR: 207884
According to RenderBox::canBeScrolledAndHasScrollableArea(), we should
bail out early in InRegionScrollerPrivate::canScrollRenderBox() if the
RenderBox's scroll height equals the client height and the scroll width
equals the client width. Otherwise, we will miss the conditions.

  • Api/InRegionScroller.cpp:

(BlackBerry::WebKit::InRegionScrollerPrivate::canScrollRenderBox):

9:37 AM Changeset in webkit [128476] by Simon Hausmann
  • 2 edits in trunk/Source/WebCore

Another prospective Qt/Windows build fix: Add missing CString.h include.

  • platform/qt/UserAgentQt.cpp:
9:33 AM Changeset in webkit [128475] by Dimitri Glazkov
  • 5 edits in trunk/Source/WebCore

Stop shuttling PseudoId from StyleResolver to SelectorChecker.
https://bugs.webkit.org/show_bug.cgi?id=96431

Reviewed by Eric Seidel.

SelectorChecker retained extra state to store the PseudoId value of the element. It was sad, because we needed to explicitly maintain its integrity. Instead, we now just make it part of StyleResolver and feed to SelectorChecker as part of SelectorCheckingContext.

No new tests, refactoring only. Covered by existing tests.

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::SelectorChecker): Removed state initializer.
(WebCore::SelectorChecker::checkSelector): Changed to look into context, rather than own member.

  • css/SelectorChecker.h:

(WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext): Added pseudoStyle as parameter.
(SelectorCheckingContext): Added pseudoStyle as member.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList): Changed to look at own member, rather than m_checker.

  • css/StyleResolver.h:

(StyleResolver): Added new member.

9:24 AM Changeset in webkit [128474] by Simon Hausmann
  • 2 edits in trunk/Source/WebCore

Unreviewed prospective Qt/MSVC build fix.

  • platform/qt/UserAgentQt.cpp:

(WebCore::UserAgentQt::standardUserAgent): Try to make the conversion from the 8-bit
String to a QLatin1String successful.

9:18 AM Changeset in webkit [128473] by kbalazs@webkit.org
  • 6 edits in trunk/Source/WebKit2

[WK2] LayerTreeCoordinator should release unused UpdatedAtlases
https://bugs.webkit.org/show_bug.cgi?id=95072

Reviewed by Jocelyn Turcotte.

Release graphic buffers that haven't been used for a while in order to save memory.
This way we can give back memory to the system when no user interaction happens
after a period of time, for example when we are in the background.

  • Shared/ShareableBitmap.h:
  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::beginContentUpdate):
(WebKit):
(WebKit::LayerTreeCoordinator::scheduleReleaseInactiveAtlases):
(WebKit::LayerTreeCoordinator::releaseInactiveAtlasesTimerFired):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

  • WebProcess/WebPage/UpdateAtlas.cpp:

(WebKit::UpdateAtlas::UpdateAtlas):
(WebKit::UpdateAtlas::didSwapBuffers):
Don't call buildLayoutIfNeeded here. It's enought to call it in beginPaintingOnAvailableBuffer
and this way we can track whether this atlas is used with m_areaAllocator.
(WebKit::UpdateAtlas::beginPaintingOnAvailableBuffer):

  • WebProcess/WebPage/UpdateAtlas.h:

(WebKit::UpdateAtlas::addTimeInactive):
(WebKit::UpdateAtlas::isInactive):
(WebKit::UpdateAtlas::isInUse):
(UpdateAtlas):

9:07 AM Changeset in webkit [128472] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

[Qt][WK2] fast/forms/access-key-for-all-elements.html fails
https://bugs.webkit.org/show_bug.cgi?id=73917

Patch by Lauro Neto <lauro.neto@openbossa.org> on 2012-09-13
Reviewed by Simon Hausmann.

Access-key tests were failing due to hardcoded Mac OS X in the
Qt WK2 user agent string. This commit moves the WK1 implementation
to a shared one to be used by both versions.

Source/WebCore:

Adds the shared user agent implementation.

  • Target.pri:
  • platform/qt/UserAgentQt.cpp: Added.

(WebCore):
(WebCore::UserAgentQt::standardUserAgent):

  • platform/qt/UserAgentQt.h: Added.

(WebCore):
(UserAgentQt):

Source/WebKit/qt:

Change QWebPage to use the shared user agent implementation.

  • Api/qwebpage.cpp:

(QWebPage::userAgentForUrl):

Source/WebKit2:

Use the shared implementation instead of hardcoding the user agent.

  • UIProcess/qt/WebPageProxyQt.cpp:

(WebKit::WebPageProxy::standardUserAgent):

LayoutTests:

Unskip now passing tests.

  • platform/qt-5.0-wk2/Skipped:
9:01 AM Changeset in webkit [128471] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Page Popup for Month is non-functional.
https://bugs.webkit.org/show_bug.cgi?id=96651

Patch by Jessica Cao <jecao@rim.com> on 2012-09-13
Reviewed by Rob Buis.

Hook up support for Month popup.

  • WebCoreSupport/DatePickerClient.cpp:

(WebCore::DatePickerClient::generateHTML):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::openDatePopup):

8:59 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
8:49 AM WebKitGTK/1.10.x edited by Philippe Normand
(diff)
8:31 AM Changeset in webkit [128470] by commit-queue@webkit.org
  • 2 edits in trunk

[CMake] Remove some redundant warning flags and enable a few more warnings.
https://bugs.webkit.org/show_bug.cgi?id=96654

Patch by Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> on 2012-09-13
Reviewed by Kenneth Rohde Christiansen.

  • Source/cmake/WebKitHelpers.cmake: Remove a few warning flags

which are already enabled by -Wall and -Wextra, remove -W which
looks useless and also enable a few more warnings by removing
their -Wno-foo counterparts which were present.

8:27 AM Changeset in webkit [128469] by kenneth@webkit.org
  • 3 edits in trunk/Source/WebCore

[EFL] Use RefPtr for storing cairo_surface_t
https://bugs.webkit.org/show_bug.cgi?id=96647

Reviewed by Simon Hausmann.

Refactoring, covered by existing tests.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::createSurfaceForBackingStore):
(WebCore::RenderThemeEfl::ThemePartCacheEntry::create):
(WebCore::RenderThemeEfl::ThemePartCacheEntry::reuse):
(WebCore::RenderThemeEfl::paintThemePart):

  • platform/efl/RenderThemeEfl.h:

(WebCore::RenderThemeEfl::ThemePartCacheEntry::surface):
(ThemePartCacheEntry):

8:22 AM Changeset in webkit [128468] by allan.jensen@nokia.com
  • 9 edits in trunk/Source/WebCore

Move updateHoverActiveState to Document.
https://bugs.webkit.org/show_bug.cgi?id=95858

Reviewed by Antonio Gomes.

RenderLayer::updateHoverActiveState contains the logic that updates hover and active states based on
hit-tests, but hover and active states are document states, and does have any relation to layers other
than documents having atleast one layer.

By moving the function it will be in the same place as other active/hover state maintainace, and we avoid
excessive updates of the state from hit-testing flow threads.

  • dom/Document.cpp:

(WebCore::commonAncestor):
(WebCore::Document::updateHoverActiveState):

  • dom/Document.h:

(Document):

  • page/EventHandler.cpp:

(WebCore::EventHandler::sendContextMenuEventForKey):

  • rendering/RenderFrameBase.cpp:

(WebCore::RenderFrameBase::nodeAtPoint):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTest):

  • rendering/RenderLayer.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::hitTest):

  • rendering/RenderView.h:

(RenderView):

8:16 AM Changeset in webkit [128467] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK2] Gardening after r128393
https://bugs.webkit.org/show_bug.cgi?id=96640

Unreviewed gardening.

Corrected expectations for the following files:
fast/dom/HTMLAnchorElement/anchor-nodownload-set.html
fast/dom/HTMLAnchorElement/anchor-download.html

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-13

  • platform/efl-wk2/TestExpectations:
8:15 AM Changeset in webkit [128466] by Simon Hausmann
  • 2 edits in trunk/Tools

[Qt] Make WebKit2 work on Windows with Qt 5
https://bugs.webkit.org/show_bug.cgi?id=76776

Reviewed by Tor Arne Vestbø.

WebKit2 should compile with Qt on Windows now, so enable it. This patch in fact corrects
the check to disable WebKit when we don't have USE_3D_GRAPHICS available, because we need
that for the GL TextureMapper (it's only built when that feature is set).

  • qmake/mkspecs/features/configure.prf:
8:10 AM Changeset in webkit [128465] by vestbo@webkit.org
  • 4 edits
    1 add in trunk

[Qt] Ensure that QT is finalized before loading qt_module.prf

As qt_module.prf does dependency tracking based on the content of the
QT variable. The intermediate WebKit modules modify the variable in
their .pri files, so we have to ensure we've loaded all the modules
before loading qt_module.

Reviewed by Tor Arne Vestbø.
Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-09-13

8:09 AM Changeset in webkit [128464] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/efl

[EFL] Remove a lot of C'ism from Ewk_Tiled_Backing_Store
https://bugs.webkit.org/show_bug.cgi?id=96631

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-13
Reviewed by Kenneth Rohde Christiansen.

Remove a lot of C'ism from Ewk_Tiled_Backing_Store and
fix coding style.

  • ewk/ewk_tiled_backing_store.cpp:

(_Ewk_Tiled_Backing_Store_Item):
(_Ewk_Tiled_Backing_Store_Data):
(_ewk_tiled_backing_store_updates_process):
(_ewk_tiled_backing_store_flush):
(_ewk_tiled_backing_store_tile_new):
(_ewk_tiled_backing_store_item_resize):
(_ewk_tiled_backing_store_tile_associate):
(_ewk_tiled_backing_store_tile_dissociate):
(_ewk_tiled_backing_store_tile_dissociate_all):
(_ewk_tiled_backing_store_pre_render_request_add):
(_ewk_tiled_backing_store_pre_render_request_del):
(_ewk_tiled_backing_store_pre_render_request_first):
(_ewk_tiled_backing_store_pre_render_request_clear):
(_ewk_tiled_backing_store_pre_render_request_process_single):
(_ewk_tiled_backing_store_item_process_idler_start):
(_ewk_tiled_backing_store_disable_render):
(_ewk_tiled_backing_store_enable_render):
(_ewk_tiled_backing_store_item_fill):
(_ewk_tiled_backing_store_item_add):
(_ewk_tiled_backing_store_item_smooth_scale_set):
(_ewk_tiled_backing_store_changed):
(_ewk_tiled_backing_store_view_cols_end_del):
(_ewk_tiled_backing_store_view_cols_end_add):
(_ewk_tiled_backing_store_view_row_del):
(_ewk_tiled_backing_store_view_rows_range_del):
(_ewk_tiled_backing_store_view_rows_all_del):
(_ewk_tiled_backing_store_smart_member_del):
(_ewk_tiled_backing_store_smart_member_add):
(_ewk_tiled_backing_store_mem_dbg):
(_ewk_tiled_backing_store_sig_usr):
(_ewk_tiled_backing_store_smart_add):
(_ewk_tiled_backing_store_smart_del):
(_ewk_tiled_backing_store_smart_show):
(_ewk_tiled_backing_store_smart_hide):
(_ewk_tiled_backing_store_recalc_renderers):
(_ewk_tiled_backing_store_smart_calculate_size):
(_ewk_tiled_backing_store_view_dbg):
(_ewk_tiled_backing_store_view_wrap_up):
(_ewk_tiled_backing_store_view_wrap_down):
(_ewk_tiled_backing_store_view_wrap_left):
(_ewk_tiled_backing_store_view_wrap_right):
(_ewk_tiled_backing_store_view_refill):
(_ewk_tiled_backing_store_view_pos_apply):
(_ewk_tiled_backing_store_smart_calculate_offset_force):
(_ewk_tiled_backing_store_smart_calculate_offset):
(_ewk_tiled_backing_store_smart_calculate_pos):
(_ewk_tiled_backing_store_fill_renderers):
(_ewk_tiled_backing_store_smart_calculate):
(ewk_tiled_backing_store_render_cb_set):
(ewk_tiled_backing_store_tile_unused_cache_get):
(_ewk_tiled_backing_store_scroll_full_offset_set_internal):
(ewk_tiled_backing_store_scroll_full_offset_set):
(ewk_tiled_backing_store_scroll_full_offset_add):
(_ewk_tiled_backing_store_zoom_set_internal):
(ewk_tiled_backing_store_zoom_set):
(ewk_tiled_backing_store_zoom_weak_set):
(ewk_tiled_backing_store_fix_offsets):
(ewk_tiled_backing_store_zoom_weak_smooth_scale_set):
(ewk_tiled_backing_store_alpha_set):
(ewk_tiled_backing_store_update):
(ewk_tiled_backing_store_updates_process_pre_set):
(ewk_tiled_backing_store_updates_process_post_set):
(ewk_tiled_backing_store_disabled_update_set):
(ewk_tiled_backing_store_flush):
(ewk_tiled_backing_store_pre_render_tile_add):
(ewk_tiled_backing_store_pre_render_spiral_queue):
(ewk_tiled_backing_store_pre_render_region):
(ewk_tiled_backing_store_pre_render_relative_radius):
(ewk_tiled_backing_store_pre_render_cancel):
(ewk_tiled_backing_store_disable_render):
(ewk_tiled_backing_store_enable_render):

  • ewk/ewk_tiled_backing_store_private.h:

(_Ewk_Tile_Stats):
(_Ewk_Tile):

  • ewk/ewk_view_tiled.cpp:

(_ewk_view_tiled_render_cb):
(_ewk_view_tiled_smart_backing_store_add):

8:05 AM Changeset in webkit [128463] by loislo@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed fix for: REGRESSION(r128451): It broke inspector/profiler/memory-instrumentation-cached-images.html
https://bugs.webkit.org/show_bug.cgi?id=96653

  • inspector/profiler/memory-instrumentation-cached-images.html:
  • inspector/profiler/memory-instrumentation-cached-images-expected.txt:
8:03 AM Changeset in webkit [128462] by allan.jensen@nokia.com
  • 3 edits
    3 adds in trunk

REGRESSION: hit test doesn't take iframe scroll position into account
https://bugs.webkit.org/show_bug.cgi?id=96541

Source/WebCore:

Reviewed by Antonio Gomes.

Convert the coordinate correctly by taking scroll position plus frame
borders and padding into account.

Test: fast/events/touch/touch-inside-iframe-scrolled.html

  • rendering/RenderFrameBase.cpp:

(WebCore::RenderFrameBase::nodeAtPoint):

LayoutTests:

Reviewed by Antonio Gomes.
Test written by Rick Byers.

Test that scroll position is taken into account in hit testing.

  • fast/events/touch/resources/touch-inside-iframe-scrolled2.html: Added.
  • fast/events/touch/touch-inside-iframe-scrolled-expected.txt: Added.
  • fast/events/touch/touch-inside-iframe-scrolled.html: Added.
8:03 AM Changeset in webkit [128461] by Simon Hausmann
  • 2 edits
    1 move in trunk/Tools

[Qt] Fix build of Qt WTR/MiniBrowser with MSVC and nmake
https://bugs.webkit.org/show_bug.cgi?id=96633

Reviewed by Csaba Osztrogonác.

WTR and MiniBrowser both have DRT in their include path (for the shared font stuff). Batch
builds with MSVC and nmake result in nmake picking up main.cpp from the wrong directory.
It's the usual problem and the usual solution is to rename one of the conflicting files.
This patch chooses to rename DRT instead of WTR and MBR.

Fixed include order at the same time to match style guide.

  • DumpRenderTree/qt/DumpRenderTree.pro:
  • DumpRenderTree/qt/DumpRenderTreeMain.cpp: Renamed from Tools/DumpRenderTree/qt/main.cpp.

(messageHandler):
(isOption):
(takeOptionValue):
(printUsage):
(main):

7:59 AM Changeset in webkit [128460] by kenneth@webkit.org
  • 2 edits in trunk/Tools

The Script run-launcher should support -2 in combination with --efl
https://bugs.webkit.org/show_bug.cgi?id=96639

Reviewed by Simon Hausmann.

Support running the MiniBrowser then supplied -2 as argument.

  • Scripts/run-launcher:
7:58 AM Changeset in webkit [128459] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit2

[Qt] Fix build of WTR and the QML2 plugin on Windows
https://bugs.webkit.org/show_bug.cgi?id=96652

Reviewed by Tor Arne Vestbø.

Some components that we build such as WTR or the QML2 plugin include
WebKit2 header files as well as WebKit2's config.h. Only the include
paths of WebKit2 are required for that at the moment (WEBKIT +=
webkit2). Only on Windows WebKit2's config.h also includes
WebCore/config.h, which in turn requires to have WebCore/platform in
your include search path. That in turn means that any component that
wants to use WebKit2 headers also needs the WebCore headers, but only
one Windows. It turns out that for the Qt build we don't need it, so
skip it in our configuration and make the include path requirement
the same across all the platforms we build.

  • config.h:
7:56 AM Changeset in webkit [128458] by rakuco@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, add my Intel email address to the list.

  • Scripts/webkitpy/common/config/committers.py:
7:42 AM Changeset in webkit [128457] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] REGRESSION(r128245): It made zillion API tests fail
https://bugs.webkit.org/show_bug.cgi?id=96531

Reviewed by Jocelyn Turcotte.

Preferences have to be updated after the drawing area was created
for compositing mode to be set.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

7:29 AM Changeset in webkit [128456] by tonikitoo@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] ASSERT failure in InRegionScrollableArea::InRegionScrollableArea
https://bugs.webkit.org/show_bug.cgi?id=96645
PR #207307

Reviewed by George Staikos.
Patch by Antonio Gomes <agomes@rim.com>

We use canScrollRenderBox to promote the layer as scrollable instead
of RenderBox::canScrollAndHasScrollableArea (see comment above the former).
We should assert against the former as well.

  • Api/InRegionScroller.cpp:

(BlackBerry::WebKit::InRegionScrollerPrivate::canScrollRenderBox):

  • Api/InRegionScroller_p.h:

(WebCore):
(InRegionScrollerPrivate):

  • WebKitSupport/InRegionScrollableArea.cpp:

(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

7:21 AM Changeset in webkit [128455] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Don't overwrite LIBS_PRIVATE when sanitizing LIBS

Reviewed by Ossy.

  • qmake/mkspecs/features/default_post.prf:
7:15 AM Changeset in webkit [128454] by kenneth@webkit.org
  • 7 edits in trunk

[EFL][DRT] Implement LayoutTestController::layerTreeAsText
https://bugs.webkit.org/show_bug.cgi?id=82294

Reviewed by Gyuyoung Kim.

Source/WebKit/efl:

Add a support method for getting layerTreeAsText.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::layerTreeAsText):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Implement layerTreeAsText using the DumpRenderTreeSupportEfl method.

  • DumpRenderTree/efl/TestRunnerEfl.cpp:

(TestRunner::layerTreeAsText):

LayoutTests:

The tests are no longer failing because of missing layerTreeAsText
but due to accelerated compositing not being enabled.

  • platform/efl/TestExpectations:
7:03 AM Changeset in webkit [128453] by zandobersek@gmail.com
  • 6 edits in trunk

[GTK] Clear application cache between tests in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=96543

Reviewed by Philippe Normand.

Source/WebKit/gtk:

Add a method to the DumpRenderTreeSupportGtk class that upon calling
clears the application cache and vacuums the database file.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::clearApplicationCache):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Tools:

Call the new DumpRenderTreeSupportGtk method to clear application cache
after each test.

Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
as well. Currently it points to a subdirectory in the layout tests results
directory. At least on the builders this ensures an empty cache directory
with each test run.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(runTest):

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort.setup_environ_for_server):

6:46 AM Changeset in webkit [128452] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Specifying a few slow tests on the debug configuration that pass
when given sufficient time to do so.

Branching expectations for three spellcheck test failures, on release
configuration they time out while on the debug configuration they
have enough time to fail.

  • platform/gtk/TestExpectations:
6:22 AM Changeset in webkit [128451] by loislo@chromium.org
  • 23 edits
    2 copies in trunk/Source/WebCore

Web Inspector: NMI: remove the dependency of platform sources from WebCore header introduced by NMI instrumentation.
https://bugs.webkit.org/show_bug.cgi?id=96367

Reviewed by Yury Semikhatsky.

the target is to move 'platform' specific instrumentation code
from WebCoreMemoryInstrumentation into the new PlatformMemoryInstrumentation.

Drive by fix: New type DOM.Image was introduced.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/WebCoreMemoryInstrumentation.cpp:

(WebCore):

  • dom/WebCoreMemoryInstrumentation.h:

(WebCoreMemoryTypes):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore):

  • platform/KURL.cpp:
  • platform/KURLGoogle.cpp:
  • platform/PlatformMemoryInstrumentation.cpp: Copied from Source/WebCore/platform/graphics/GeneratedImage.cpp.

(WebCore):

  • platform/PlatformMemoryInstrumentation.h: Copied from Source/WebCore/platform/graphics/GeneratedImage.cpp.

(WebCore):
(PlatformMemoryTypes):

  • platform/SharedBuffer.cpp:
  • platform/TreeShared.h:

(WebCore::TreeShared::reportMemoryUsage):

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::reportMemoryUsage):

  • platform/graphics/CrossfadeGeneratedImage.cpp:

(WebCore::CrossfadeGeneratedImage::reportMemoryUsage):

  • platform/graphics/GeneratedImage.cpp:

(WebCore::GeneratedImage::reportMemoryUsage):

  • platform/graphics/GeneratorGeneratedImage.cpp:

(WebCore::GeneratorGeneratedImage::reportMemoryUsage):

  • platform/graphics/GeneratorGeneratedImage.h:
  • platform/graphics/Image.cpp:

(WebCore::Image::reportMemoryUsage):

  • platform/network/FormData.cpp:

(WebCore::FormData::reportMemoryUsage):

  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::reportMemoryUsage):

  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::reportMemoryUsage):

5:39 AM Changeset in webkit [128450] by vestbo@webkit.org
  • 5 edits in trunk

[Qt] Make sure LIBS, PKGCONFIG, and QT, do not affect QtWebKit's prl file

Unless it's actually a dependency of the public QtWebKit API.

We could replace every occurance of LIBS, PKGCONFIG, and QT, in the pri
files with their _PRIVATE equivivalent, but that's likely to break when
someone adds a new QT/LIBS/PKGCONFIG += foo line somewhere. Instead we
clean up the variables in default_post.

This means that the CONFIG -= explicitlib in linkAgainstLibrary() is no
longer needed, as it was a workaround for the intermediate libraries ending
up in the prl file. And, since CONFIG -= staticlib was there to support
the explicitlib option, we can remove that too (as well as the exception
for gprof, since it would be empty). If gprof needs tweaks to always link
statically they should go in gprof.prf.

Reviewed by Simon Hausmann.

5:37 AM Changeset in webkit [128449] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Fix UIProcess build with Qt on Windows
https://bugs.webkit.org/show_bug.cgi?id=96635

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-09-13
Reviewed by Csaba Osztrogonác.

Enabling setShouldCloseConnectionOnProcessTermination on the connection
is something that is only implemented in ConnectionUnix, not
ConnectionWin.cpp, where appears to be built-in functionality.

  • UIProcess/WebConnectionToWebProcess.cpp:

(WebKit::WebConnectionToWebProcess::WebConnectionToWebProcess):

5:12 AM Changeset in webkit [128448] by loislo@chromium.org
  • 16 edits in trunk/Source

Web Inspector: NMI: instrument KURL directly.
https://bugs.webkit.org/show_bug.cgi?id=96624

Reviewed by Yury Semikhatsky.

I replaced traits based instrumentation of KURL with reportMemoryUsage functions.
CString* were also instrumented.

Drive by fix: Instrumentation code in QualifiedName was moved to cpp.

Source/WebCore:

  • bindings/v8/V8DOMMap.h:
  • dom/Attribute.h:
  • dom/QualifiedName.cpp:

(WebCore::QualifiedName::reportMemoryUsage):
(WebCore):
(WebCore::QualifiedName::QualifiedNameImpl::reportMemoryUsage):

  • dom/QualifiedName.h:

(QualifiedNameImpl):
(QualifiedName):

  • dom/WebCoreMemoryInstrumentation.cpp:
  • dom/WebCoreMemoryInstrumentation.h:

(WebCore):

  • platform/KURL.cpp:

(WebCore::KURL::reportMemoryUsage):
(WebCore):

  • platform/KURL.h:

(KURL):

  • platform/KURLGoogle.cpp:

(WebCore::KURLGooglePrivate::reportMemoryUsage):

  • platform/KURLGooglePrivate.h:

(KURLGooglePrivate):

  • platform/KURLWTFURLImpl.h:

(KURLWTFURLImpl):
(WebCore::KURLWTFURLImpl::reportMemoryUsage):

Source/WebKit/chromium:

  • tests/MemoryInstrumentationTest.cpp:

(WebCore):
(InstrumentedOwner):
(WebCore::InstrumentedOwner::InstrumentedOwner):
(WebCore::InstrumentedOwner::reportMemoryUsage):
(WebCore::TEST):

Source/WTF:

  • wtf/text/CString.h:

(CStringBuffer):
(WTF::CStringBuffer::reportMemoryUsage):
(CString):
(WTF::CString::reportMemoryUsage):

5:11 AM Changeset in webkit [128447] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] "Infinite" loop in AccessibilityUIElementGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=96632

Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2012-09-13
Reviewed by Carlos Garcia Campos.

Fix this by using atk_object_get_n_accessible_children instead of
calling getChildren() from childCount.

  • WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp:

(WTR::AccessibilityUIElement::childrenCount): Avoid the infinite
loop by using atk_object_get_n_accessible_children().

5:08 AM Changeset in webkit [128446] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/LayoutTests

[EFL] Gardening after r128375, r128431
https://bugs.webkit.org/show_bug.cgi?id=96630

Unreviewed gardening.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-13

  • platform/efl/TestExpectations: Unskip fast/overflow/overflow-height-float-not-removed-crash.html.
  • platform/efl/fast/table/height-percent-test-vertical-expected.png: Rebase.
  • platform/efl/fast/table/height-percent-test-vertical-expected.txt: Ditto.
  • platform/efl/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt: Added. Rebase.
5:01 AM Changeset in webkit [128445] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt][WK2] New fast/forms/number/number-spinbutton-click-in-iframe.html fails
https://bugs.webkit.org/show_bug.cgi?id=96634

Unreviewed gardening.

  • platform/qt-5.0-wk2/Skipped: skip the failing test.
4:16 AM Changeset in webkit [128444] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Unskip a now passing test, and add a missing URL.
  • platform/qt/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt: Updated.
4:13 AM Changeset in webkit [128443] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebaseline after 128433. It hasn't been updated correctly in the previous revision.

  • platform/qt/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt:
4:04 AM Changeset in webkit [128442] by tkent@chromium.org
  • 17 edits in trunk/Source/WebCore

Update binding test expectation for http://trac.webkit.org/changeset/128400
https://bugs.webkit.org/show_bug.cgi?id=91933

  • bindings/scripts/test/JS/JSFloat64Array.cpp:

(WebCore::JSFloat64Array::getOwnPropertySlotByIndex):
(WebCore::JSFloat64Array::putByIndex):

  • bindings/scripts/test/JS/JSFloat64Array.h:

(JSFloat64Array):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.h:

(JSTestActiveDOMObject):

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore::JSTestCustomNamedGetter::getOwnPropertySlotByIndex):
(WebCore):

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.h:

(JSTestCustomNamedGetter):

  • bindings/scripts/test/JS/JSTestEventConstructor.h:

(JSTestEventConstructor):

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::JSTestEventTarget::getOwnPropertySlotByIndex):

  • bindings/scripts/test/JS/JSTestEventTarget.h:

(JSTestEventTarget):

  • bindings/scripts/test/JS/JSTestException.h:

(JSTestException):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterface::putByIndex):
(WebCore):

  • bindings/scripts/test/JS/JSTestInterface.h:

(JSTestInterface):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h:

(JSTestMediaQueryListListener):

  • bindings/scripts/test/JS/JSTestNamedConstructor.h:

(JSTestNamedConstructor):

  • bindings/scripts/test/JS/JSTestNode.h:

(JSTestNode):

  • bindings/scripts/test/JS/JSTestObj.h:

(JSTestObj):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(JSTestSerializedScriptValueInterface):

3:41 AM Changeset in webkit [128441] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update
https://bugs.webkit.org/show_bug.cgi?id=96628

  • platform/chromium/TestExpectations:

calculate-order.html is flaky on Lion.

3:39 AM Changeset in webkit [128440] by vestbo@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Fix qdoc executable preparation

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-09-13
Reviewed by Tor Arne Vestbø.

  • docs/docs.pri:
3:37 AM Changeset in webkit [128439] by vestbo@webkit.org
  • 2 edits in trunk

[Qt] Fllow rename of qt_module_config.prf to qt_module.prf

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-09-13
Reviewed by Tor Arne Vestbø.

  • Source/api.pri:
3:33 AM Changeset in webkit [128438] by vestbo@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Fix build against namespaced Qt

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-09-13
Reviewed by Tor Arne Vestbø.

  • UIProcess/qt/PageViewportControllerClientQt.h:
3:29 AM Changeset in webkit [128437] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update

  • platform/chromium/TestExpectations:

sandboxed-iframe-navigation-parent.html is slow on Lion too.

3:11 AM Changeset in webkit [128436] by commit-queue@webkit.org
  • 12 edits
    2 moves
    12 adds in trunk

[EFL][Qt][WK2] Implement shared undo controller for EFL and Qt port.
https://bugs.webkit.org/show_bug.cgi?id=92504

Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2012-09-13
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

EFL port needs an undo controller similiar to one from Qt port. Instead of
duplicating the code existing class was renamed and moved to UIProcess
directory.

  • PlatformEfl.cmake:
  • Target.pri:
  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::registerEditCommand):
(WebKit::PageClientImpl::clearAllEditCommands):
(WebKit::PageClientImpl::canUndoRedo):
(WebKit::PageClientImpl::executeUndoRedo):

  • UIProcess/API/efl/PageClientImpl.h:

(PageClientImpl):

  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

  • UIProcess/DefaultUndoController.cpp: Renamed from Source/WebKit2/UIProcess/qt/QtWebUndoController.cpp.

(WebKit):
(WebKit::DefaultUndoController::registerEditCommand):
(WebKit::DefaultUndoController::clearAllEditCommands):
(WebKit::DefaultUndoController::canUndoRedo):
(WebKit::DefaultUndoController::executeUndoRedo):

  • UIProcess/DefaultUndoController.h: Renamed from Source/WebKit2/UIProcess/qt/QtWebUndoController.h.

(WebKit):
(DefaultUndoController):

  • UIProcess/qt/QtPageClient.cpp:

(WebKit::QtPageClient::initialize):

  • UIProcess/qt/QtPageClient.h:

(WebKit):
(QtPageClient):

LayoutTests:

Unskip the editing/undo category now that the tests are passing. Also add
missing expected results.

  • platform/efl-wk1/TestExpectations:
  • platform/efl-wk2/TestExpectations:
  • platform/efl/Skipped:
  • platform/efl/editing/undo/4063751-expected.txt: Added.
  • platform/efl/editing/undo/5378473-expected.txt: Added.
  • platform/efl/editing/undo/redo-typing-001-expected.txt: Added.
  • platform/efl/editing/undo/undo-combined-delete-boundary-expected.txt: Added.
  • platform/efl/editing/undo/undo-combined-delete-expected.txt: Added.
  • platform/efl/editing/undo/undo-delete-boundary-expected.txt: Added.
  • platform/efl/editing/undo/undo-delete-expected.txt: Added.
  • platform/efl/editing/undo/undo-forward-delete-boundary-expected.txt: Added.
  • platform/efl/editing/undo/undo-forward-delete-expected.txt: Added.
  • platform/efl/editing/undo/undo-misspellings-expected.txt: Added.
  • platform/efl/editing/undo/undo-typing-001-expected.txt: Added.
3:00 AM Changeset in webkit [128435] by Simon Hausmann
  • 2 edits in trunk/Tools

[Qt][Win] Enable USE(3D_GRAPHICS)
https://bugs.webkit.org/show_bug.cgi?id=90879

Reviewed by Kenneth Rohde Christiansen.

Enable it on Windows as well as on QNX (bug fixed).

  • qmake/mkspecs/features/features.prf:
2:32 AM Changeset in webkit [128434] by yosin@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

[Tests] We should have tests for preserving/resetting values of input type "time" after browser navigation
https://bugs.webkit.org/show_bug.cgi?id=96595

Reviewed by Kent Tamura.

This patch adds two tests for preserving/resetting values input type
"time" with multiple fields input UI after page reload, backward and
forward browser navigation.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

  • fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back-expected.txt: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back.html: Added for checking value is preserved after history backward and forward navigation.
  • fast/forms/time-multiple-fields/time-multiple-fields-reset-value-after-reload-expected.txt: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-reset-preserve-value-after-reload.html: Added for checking values are resetted after page reload.
2:24 AM Changeset in webkit [128433] by kadam@inf.u-szeged.hu
  • 2 edits
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip a failing test. Added platform specific expectations after r128375.

  • platform/qt/Skipped: After r128400.
  • platform/qt/fast/table/height-percent-test-vertical-expected.txt: Added r128375.
  • platform/qt/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt: Added r128375..
2:13 AM Changeset in webkit [128432] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Gardening after r128270, r128400, r128389, r128393, r128274
https://bugs.webkit.org/show_bug.cgi?id=96613

Unreviewed gardening.

Adding failing test to TestExpectations.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-13

  • platform/efl-wk1/TestExpectations:
  • platform/efl/TestExpectations:
2:11 AM Changeset in webkit [128431] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] REGRESSION (r128274): fast/overflow/overflow-height-float-not-removed-crash.html
https://bugs.webkit.org/show_bug.cgi?id=96619

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-13
Reviewed by Kenneth Rohde Christiansen.

ThemePartCacheEntry::create() can return '0' if creation fails, this was not checked
while Theme Part cache populating. A NULL pointer was dereferenced then causing crash.

Test: fast/overflow/overflow-height-float-not-removed-crash.html.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::getThemePartFromCache):

1:54 AM Changeset in webkit [128430] by commit-queue@webkit.org
  • 5 edits in trunk

[Qt] The ANGLE build on Windows breaks with GnuWin32's flex because it is too old
https://bugs.webkit.org/show_bug.cgi?id=96359

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-09-13
Reviewed by Tor Arne Vestbø.

GnuWin32's flex is 2.5.4 and that is too old for ANGLE's preprocessor
lexer. The only viable alternative I could find on Windows that provides
binaries is the winflexbison distribution (http://sourceforge.net/projects/winflexbison/),
so let's use that one instead.

Source/ThirdParty/ANGLE:

  • DerivedSources.pri:

Tools:

  • Scripts/webkitdirs.pm:

(checkRequiredSystemConfig):

  • qmake/mkspecs/features/default_pre.prf:
1:50 AM Changeset in webkit [128429] by Simon Hausmann
  • 2 edits in trunk

[Qt] syncqt isn't re-run when WebKit1.pro changes and we're building with --no-webkit2
https://bugs.webkit.org/show_bug.cgi?id=96545

Reviewed by Tor Arne Vestbø.

Do the QMAKE_INTERNAL_INCLUDED_FILES trick separately for WebKit1.pro and WebKit2/Target.pri,
depending on build?(webkit1) and build?(webkit2), as discussed earlier.

  • Source/api.pri:
1:43 AM Changeset in webkit [128428] by loislo@chromium.org
  • 7 edits in trunk/Source

[Qt][Win] REGRESSION(r128400): It broke the build
https://bugs.webkit.org/show_bug.cgi?id=96617

Patch by Filip Pizlo <fpizlo@apple.com> on 2012-09-13
Reviewed by Simon Hausmann.

Source/JavaScriptCore:

Changed "JSC::Array" to "JSC::ArrayClass" because it's not used often enough
for the brevity to be beneficial, and because "Array" causes too much namespace
pollution.

  • runtime/IndexingType.h:

(JSC):

  • runtime/JSArray.cpp:

(JSC::JSArray::pop):
(JSC::JSArray::push):
(JSC::JSArray::sortNumeric):
(JSC::JSArray::sort):
(JSC::JSArray::fillArgList):
(JSC::JSArray::copyToArguments):
(JSC::JSArray::compactForSorting):

  • runtime/JSObject.cpp:

(JSC::JSObject::getOwnPropertySlotByIndex):
(JSC::JSObject::putByIndex):
(JSC::JSObject::ensureArrayStorageExistsAndEnterDictionaryIndexingMode):
(JSC::JSObject::deletePropertyByIndex):
(JSC::JSObject::getOwnPropertyNames):
(JSC::JSObject::putByIndexBeyondVectorLength):
(JSC::JSObject::putDirectIndexBeyondVectorLength):
(JSC::JSObject::getNewVectorLength):
(JSC::JSObject::getOwnPropertyDescriptor):

  • runtime/JSObject.h:

(JSC::JSObject::getArrayLength):
(JSC::JSObject::getVectorLength):
(JSC::JSObject::canGetIndexQuickly):
(JSC::JSObject::canSetIndexQuickly):
(JSC::JSObject::inSparseIndexingMode):
(JSC::JSObject::ensureArrayStorage):

Source/WebCore:

  • bridge/runtime_array.h:

(JSC::RuntimeArray::createStructure):

1:41 AM Changeset in webkit [128427] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: CSS domain sends events while it is not enabled
https://bugs.webkit.org/show_bug.cgi?id=96615

Reviewed by Yury Semikhatsky.

The CSS agent is put into and removed from the instrumenting agents set upon enable() and disable(), respectively.

Tests will be shortly landed as a part of the new pure protocol testing harness.

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::setFrontend):
(WebCore::InspectorCSSAgent::clearFrontend):
(WebCore::InspectorCSSAgent::reset):
(WebCore):
(WebCore::InspectorCSSAgent::resetNonPersistentData):
(WebCore::InspectorCSSAgent::enable):
(WebCore::InspectorCSSAgent::disable):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

1:41 AM Changeset in webkit [128426] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r128409.
http://trac.webkit.org/changeset/128409
https://bugs.webkit.org/show_bug.cgi?id=96622

It broke Chromium browser_tests (Requested by tkent on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-13

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::scopeStringMatches):
(WebKit::WebFrameImpl::shouldScopeMatches):

1:40 AM Changeset in webkit [128425] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Testing whether indexing type is ArrayWithArrayStorage should not compare against ArrayWithArrayStorage
https://bugs.webkit.org/show_bug.cgi?id=96611

Reviewed by Gavin Barraclough.

  • dfg/DFGRepatch.cpp:

(JSC::DFG::tryCacheGetByID):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArray):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::privateCompilePatchGetArrayLength):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::privateCompilePatchGetArrayLength):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
1:38 AM Changeset in webkit [128424] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/Tools

[Qt] Add configuration for production builds
https://bugs.webkit.org/show_bug.cgi?id=96607

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-09-13
Reviewed by Kenneth Rohde Christiansen.

Add configuration tweaks for production builds, to ease memory pressure with the GNU toolchain
and enable all-in-one-files optimizations.

  • qmake/mkspecs/features/production_build.prf: Added.
1:37 AM Changeset in webkit [128423] by yosin@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

[Tests] We should have test for clicking spin button in iframe.
https://bugs.webkit.org/show_bug.cgi?id=96612

Reviewed by Kent Tamura.

This patch adds two tests for clicking spin button in iframe for
input type "number" and input type "time" with multiple fields UI.

These tests are added for catching regression caused by r127876.

  • fast/forms/number/number-spinbutton-click-in-iframe-expected.txt: Added.
  • fast/forms/number/number-spinbutton-click-in-iframe.html: Added.
  • fast/forms/resources/common-spinbutton-click-in-iframe.js: Added.

(getSpinButton): Extracts spin button in shadow DOM tree.
(mouseClick): Simulates mouse click.
(mouseMoveTo): Simulates mouse pointer move.
(runIFrameLoaded): Checking spin button clicked.
(testClickSpinButtonInIFrame): Creates and populates iframe.

  • fast/forms/time-multiple-fields/time-multiple-fields-spinbutton-click-in-iframe-expected.txt: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-spinbutton-click-in-iframe.html: Added.
1:31 AM Changeset in webkit [128422] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt] GStreamer detection does not work when cross-compiling
https://bugs.webkit.org/show_bug.cgi?id=96608

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-09-13
Reviewed by Kenneth Rohde Christiansen.

When cross-compiling it is not safe to just use system(pkg-config),
because there is a high probability that it will find packages in the
host system instead of in the target one. Instead use qmake's new
packagesExist() function that takes care of this delicate aspect of
cross compilation by setting PKG_CONFIG_SYSROOT_DIR and
PKG_CONFIG_LIBDIR accordingly.

  • qmake/mkspecs/features/features.prf:
1:29 AM Changeset in webkit [128421] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WK2][WTR] More efficient string handling in InjectedBundlePage
https://bugs.webkit.org/show_bug.cgi?id=96609

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-13
Reviewed by Kenneth Rohde Christiansen.

Update StringBuilder usage in InjectedBundlePage to follow
the latest recommandations for efficient string handling:
http://trac.webkit.org/wiki/EfficientStrings

This involves using appendLiteral() or appendNumber()
instead of append() whenever possible.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::dumpPath):
(WTR::rangeToStr):
(WTR::styleDecToStr):
(WTR::frameToStr):
(WTR::dumpResourceURL):
(WTR):
(WTR::dumpFrameDescriptionSuitableForTestResult):
(WTR::dumpRequestDescriptionSuitableForTestResult):
(WTR::dumpResponseDescriptionSuitableForTestResult):
(WTR::dumpErrorDescriptionSuitableForTestResult):
(WTR::InjectedBundlePage::didReceiveIntentForFrame):
(WTR::InjectedBundlePage::registerIntentServiceForFrame):
(WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
(WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
(WTR::InjectedBundlePage::didCommitLoadForFrame):
(WTR::InjectedBundlePage::didFinishProgress):
(WTR::dumpFrameScrollPosition):
(WTR::dumpFrameText):
(WTR::dumpDescendantFramesText):
(WTR::InjectedBundlePage::didFinishLoadForFrame):
(WTR::InjectedBundlePage::didReceiveTitleForFrame):
(WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
(WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
(WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
(WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
(WTR::InjectedBundlePage::willSendRequestForFrame):
(WTR::InjectedBundlePage::didReceiveResponseForResource):
(WTR::InjectedBundlePage::didFinishLoadForResource):
(WTR::InjectedBundlePage::didFailLoadForResource):
(WTR::InjectedBundlePage::shouldCacheResponse):
(WTR::InjectedBundlePage::decidePolicyForNavigationAction):
(WTR::InjectedBundlePage::willAddMessageToConsole):
(WTR::InjectedBundlePage::willSetStatusbarText):
(WTR::InjectedBundlePage::willRunJavaScriptAlert):
(WTR::InjectedBundlePage::willRunJavaScriptConfirm):
(WTR::InjectedBundlePage::willRunJavaScriptPrompt):
(WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
(WTR::InjectedBundlePage::shouldBeginEditing):
(WTR::InjectedBundlePage::shouldEndEditing):
(WTR::InjectedBundlePage::shouldInsertNode):
(WTR::InjectedBundlePage::shouldInsertText):
(WTR::InjectedBundlePage::shouldDeleteRange):
(WTR::InjectedBundlePage::shouldChangeSelectedRange):
(WTR::InjectedBundlePage::shouldApplyStyle):
(WTR::InjectedBundlePage::didBeginEditing):
(WTR::InjectedBundlePage::didEndEditing):
(WTR::InjectedBundlePage::didChange):
(WTR::InjectedBundlePage::didChangeSelection):
(WTR::InjectedBundlePage::supportsFullScreen):
(WTR::InjectedBundlePage::enterFullScreenForElement):
(WTR::InjectedBundlePage::exitFullScreenForElement):
(WTR::InjectedBundlePage::beganEnterFullScreen):
(WTR::InjectedBundlePage::beganExitFullScreen):
(WTR::InjectedBundlePage::closeFullScreen):
(WTR::dumpBackForwardListItem):
(WTR::InjectedBundlePage::dumpBackForwardList):

1:19 AM Changeset in webkit [128420] by zandobersek@gmail.com
  • 3 edits
    2 adds in trunk/LayoutTests

Unreviewed GTK gardening.

Rebaselining two tests after r128375.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/table/height-percent-test-vertical-expected.png: Added.
  • platform/gtk/fast/table/height-percent-test-vertical-expected.txt:
  • platform/gtk/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt: Added.
1:14 AM Changeset in webkit [128419] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt][WK2] Memory leaks in Qt's TestRunner
https://bugs.webkit.org/show_bug.cgi?id=96603

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-13
Reviewed by Csaba Osztrogonác.

Fix memory leaks in Qt's TestRunner code by adopting WKString
created with WKStringCreateWithUTF8CString().

  • WebKitTestRunner/qt/TestControllerQt.cpp:

(WTR::TestController::initializeInjectedBundlePath):
(WTR::TestController::initializeTestPluginDirectory):

1:11 AM Changeset in webkit [128418] by loislo@chromium.org
  • 59 edits in trunk/Source

Web Inspector: NMI: migrate core instrumentation code to WTF namespace
https://bugs.webkit.org/show_bug.cgi?id=96511

Reviewed by Yury Semikhatsky.

After moving core NMI code to WTF namespace I removed forward declarations
of MemoryObjectInfo and MemoryInstrumentation from WebCore headers and add
forward declaration into wtf/Forward.h

Source/WebCore:

  • bindings/v8/DOMDataStore.h:

(WebCore):

  • bindings/v8/ScriptProfiler.h:

(WebCore):

  • bindings/v8/V8DOMMap.h:

(WebCore):

  • bindings/v8/V8PerIsolateData.h:

(WebCore):

  • bindings/v8/V8ValueCache.h:

(WebCore):

  • css/CSSProperty.h:
  • css/CSSRule.h:

(WebCore):

  • css/CSSSelectorList.h:

(WebCore):

  • css/CSSStyleDeclaration.h:

(WebCore):

  • css/CSSStyleSheet.h:

(WebCore):

  • css/CSSValue.h:
  • css/MediaList.h:

(WebCore):

  • css/MediaQuery.h:
  • css/MediaQueryExp.h:
  • css/StylePropertySet.h:

(WebCore):

  • css/StyleResolver.h:
  • css/StyleRule.h:

(WebCore):

  • css/StyleRuleImport.h:

(WebCore):

  • css/StyleSheetContents.h:

(WebCore):

  • css/WebKitCSSKeyframeRule.h:
  • css/WebKitCSSKeyframesRule.h:

(WebCore):

  • css/WebKitCSSMixFunctionValue.h:
  • dom/DocumentEventQueue.h:

(WebCore):

  • dom/ElementAttributeData.h:

(WebCore):

  • dom/Event.h:

(WebCore):

  • dom/Node.h:

(WebCore):

  • dom/WebCoreMemoryInstrumentation.cpp:

(WTF):
(WTF::WebCore::KURL):

  • dom/WebCoreMemoryInstrumentation.h:

(WebCore):
(WTF):

  • inspector/MemoryInstrumentationImpl.h:
  • loader/DocumentLoader.h:

(WebCore):

  • loader/FrameLoader.h:

(WebCore):

  • loader/ResourceLoader.h:

(WebCore):

  • loader/SubstituteData.h:
  • loader/cache/CachedCSSStyleSheet.h:

(WebCore):

  • loader/cache/CachedRawResource.h:

(WebCore):

  • loader/cache/CachedResource.h:

(WebCore):

  • loader/cache/CachedResourceHandle.h:
  • loader/cache/CachedResourceLoader.h:

(WebCore):

  • loader/cache/CachedScript.h:

(WebCore):

  • loader/cache/CachedShader.h:
  • loader/cache/CachedXSLStyleSheet.h:

(WebCore):

  • loader/cache/MemoryCache.h:

(WebCore):

  • page/Frame.h:

(WebCore):

  • platform/SharedBuffer.h:
  • platform/graphics/CrossfadeGeneratedImage.h:

(WebCore):

  • platform/graphics/Image.h:

(WebCore):

  • platform/network/FormData.h:

(WebCore):

  • platform/network/ResourceRequestBase.h:
  • platform/network/ResourceResponseBase.h:
  • rendering/style/RenderStyle.h:

(WebCore):

  • rendering/style/StyleRareInheritedData.h:

(WebCore):

  • rendering/style/StyleRareNonInheritedData.h:

(WebCore):

Source/WTF:

  • wtf/Forward.h:

(WTF):

  • wtf/MemoryInstrumentation.h:
1:07 AM Changeset in webkit [128417] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Removing expectation for fast/canvas/canvas-css-crazy.html, the test
was fixed in r128411.

Marking fast/events/popup-blocking-timers.html as slow and adding a
timeout expectation for touchadjustment/iframe-boundary.html.

  • platform/gtk/TestExpectations:
12:51 AM Changeset in webkit [128416] by commit-queue@webkit.org
  • 12 edits
    28 adds in trunk

[CSSRegions][CSSOM] Implement Element.getRegionFlowRanges
https://bugs.webkit.org/show_bug.cgi?id=78493

Patch by Raul Hudea <rhudea@adobe.com> on 2012-09-13
Reviewed by David Hyatt.

Source/WebCore:

Implement the getRegionFlowRanges function from the CSS Regions spec. It is implemented by iterating over
the content nodes and figuring out which nodes have boundingBox intersecting the region box and figuring out
the start and end positions.

Tests: fast/regions/get-region-flow-ranges-absolute-pos.html

fast/regions/get-region-flow-ranges-content-nodes.html
fast/regions/get-region-flow-ranges-display-none.html
fast/regions/get-region-flow-ranges-empty-regions.html
fast/regions/get-region-flow-ranges-fixed-pos.html
fast/regions/get-region-flow-ranges-horiz-bt.html
fast/regions/get-region-flow-ranges-inline-only.html
fast/regions/get-region-flow-ranges-text-vert-lr.html
fast/regions/get-region-flow-ranges-text.html
fast/regions/get-region-flow-ranges-vert-lr.html
fast/regions/get-region-flow-ranges-vert-rl.html
fast/regions/get-region-flow-ranges-writing-modes-rl-rb-lr.html
fast/regions/get-region-flow-ranges-writing-modes-tb-rl-lr.html
fast/regions/get-region-flow-ranges.html

  • dom/Element.cpp:

(WebCore::Element::webkitGetRegionFlowRanges):
(WebCore):

  • dom/Element.h:
  • dom/Element.idl: added the webkitGetRegionFlowRanges method
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats): Use the logicalTopOfFlowThreadContentRect instead of offsetFromLogicalTopOfFirstPage (renamed)
(WebCore::RenderBlock::hasNextPage): Use the logicalTopOfFlowThreadContentRect instead of offsetFromLogicalTopOfFirstPage (renamed)
(WebCore::RenderBlock::offsetFromLogicalTopOfFirstPage): Added a slower path which works without LayoutState
(WebCore::RenderBlock::clampToStartAndEndRegions): Use the logicalTopOfFlowThreadContentRect instead of offsetFromLogicalTopOfFirstPage (renamed)

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::shrinkLogicalWidthToAvoidFloats): Use the logicalTopOfFlowThreadContentRect instead of offsetFromLogicalTopOfFirstPage (renamed)
(WebCore::RenderBox::containingBlockAvailableLineWidthInRegion): Use the logicalTopOfFlowThreadContentRect instead of offsetFromLogicalTopOfFirstPage (renamed)
(WebCore::computeInlineStaticDistance): Use the logicalTopOfFlowThreadContentRect instead of offsetFromLogicalTopOfFirstPage (renamed)

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::isContainedInNodes):
(WebCore):
(WebCore::boxIntersectsRegion):
(WebCore::RenderNamedFlowThread::getRanges): returns a vector of Ranges that contains Node that are part of a region

  • rendering/RenderNamedFlowThread.h:

(RenderNamedFlowThread):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::logicalTopOfFlowThreadContentRect): Returns the logical top of a rectangle inside the flow thread content
(WebCore):
(WebCore::RenderRegion::logicalBottomOfFlowThreadContentRect): Returns the logical bottom of a rectangle inside the flow thread content
(WebCore::RenderRegion::getRanges): proxy the getRanges call to its named flow thread

  • rendering/RenderRegion.h:

(RenderRegion):
(WebCore::RenderRegion::logicalTopForFlowThreadContent): Renamed from offsetFromLogicalTopOfFirstPage
(WebCore::RenderRegion::logicalBottomForFlowThreadContent): Returns the logical bottom of the FlowThreadContent rect

LayoutTests:

Add tests for getRegionFlowRanges call.

  • fast/regions/get-region-flow-ranges-absolute-pos-expected.txt: Added.
  • fast/regions/get-region-flow-ranges-absolute-pos.html: Added.
  • fast/regions/get-region-flow-ranges-content-nodes-expected.txt: Added.
  • fast/regions/get-region-flow-ranges-content-nodes.html: Added.
  • fast/regions/get-region-flow-ranges-display-none-expected.txt: Added.
  • fast/regions/get-region-flow-ranges-display-none.html: Added.
  • fast/regions/get-region-flow-ranges-empty-regions-expected.txt: Added.
  • fast/regions/get-region-flow-ranges-empty-regions.html: Added.
  • fast/regions/get-region-flow-ranges-expected.txt: Added.
  • fast/regions/get-region-flow-ranges-fixed-pos-expected.txt: Added.
  • fast/regions/get-region-flow-ranges-fixed-pos.html: Added.
  • fast/regions/get-region-flow-ranges-horiz-bt-expected.txt: Added.
  • fast/regions/get-region-flow-ranges-horiz-bt.html: Added.
  • fast/regions/get-region-flow-ranges-inline-only-expected.txt: Added.
  • fast/regions/get-region-flow-ranges-inline-only.html: Added.
  • fast/regions/get-region-flow-ranges-text-expected.txt: Added.
  • fast/regions/get-region-flow-ranges-text-vert-lr-expected.txt: Added.
  • fast/regions/get-region-flow-ranges-text-vert-lr.html: Added.
  • fast/regions/get-region-flow-ranges-text.html: Added.
  • fast/regions/get-region-flow-ranges-vert-lr-expected.txt: Added.
  • fast/regions/get-region-flow-ranges-vert-lr.html: Added.
  • fast/regions/get-region-flow-ranges-vert-rl-expected.txt: Added.
  • fast/regions/get-region-flow-ranges-vert-rl.html: Added.
  • fast/regions/get-region-flow-ranges-writing-modes-rl-rb-lr-expected.txt: Added.
  • fast/regions/get-region-flow-ranges-writing-modes-rl-rb-lr.html: Added.
  • fast/regions/get-region-flow-ranges-writing-modes-tb-rl-lr-expected.txt: Added.
  • fast/regions/get-region-flow-ranges-writing-modes-tb-rl-lr.html: Added.
  • fast/regions/get-region-flow-ranges.html: Added.
  • fast/regions/resources/helper.js:

(getName):
(getRangeAt):
(compareArrays):

12:47 AM Changeset in webkit [128415] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Check if WorkerContext is terminated in WebWorkerClientImple::openFileSystem call.
https://bugs.webkit.org/show_bug.cgi?id=96601

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-09-13
Reviewed by Kent Tamura.

m_webFrame might be already deleted after terminateWorkerContext call.
This patch ensure it be NULL and change to avoid using it.

Test: fast/filesystem/workers/detached-frame-crash.html

  • src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::terminateWorkerContext):
(WebKit::WebWorkerClientImpl::openFileSystem):

12:37 AM Changeset in webkit [128414] by zandobersek@gmail.com
  • 5 edits in trunk

[GTK][NRWT] Lower timeout value to 6 seconds (12 for debug configuration)
https://bugs.webkit.org/show_bug.cgi?id=96506

Reviewed by Dirk Pranke.

Tools:

Lower the timeout value to 6 seconds for release configuration and 12 seconds
for debug configuration. These are the same values the Chromium port uses.

Currently the value is lowered only for the DumpRenderTree, WebKitTestRunner (and
the layout tests under WebKit2 generally) requires more attention and gardening
than what the current effort produces.

The unit test is updated as well to test these changes.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort.default_timeout_ms):

  • Scripts/webkitpy/layout_tests/port/gtk_unittest.py:

(GtkPortTest.test_default_timeout_ms):
(GtkPortTest.assertLinesEqual):

LayoutTests:

Create a new section for slow tests. Tests listed here pass (or at least
work as expected or reliably) but require more than 6 or 12 seconds to run.

More tests are added into the timeout section. These are primarily tests
that used to take half a minute to run just to be interrupted by the watchdog
in DumpRenderTree and were then reported as text mismatch failures. Now they
will be timing out which is (arguably) a more proper way for them to fail.

  • platform/gtk/TestExpectations:
12:35 AM Changeset in webkit [128413] by commit-queue@webkit.org
  • 24 edits in trunk/Source/WebKit2

[EFL][WK2] Make _ref() functions return the object
https://bugs.webkit.org/show_bug.cgi?id=96604

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-13
Reviewed by Gyuyoung Kim.

Make _ref() functions return the ref'd object to
make them more convenient to use. Also fix their
usage to make use of the newly returned value.

This change is consistent with eina_stringshare_ref()
in EFL and g_object_ref() in glib.

  • UIProcess/API/efl/ewk_back_forward_list.cpp:

(createEinaList):

  • UIProcess/API/efl/ewk_back_forward_list_item.cpp:

(ewk_back_forward_list_item_ref):

  • UIProcess/API/efl/ewk_back_forward_list_item.h:
  • UIProcess/API/efl/ewk_context.cpp:

(ewk_context_download_job_add):

  • UIProcess/API/efl/ewk_download_job.cpp:

(ewk_download_job_ref):
(ewk_download_job_response_set):

  • UIProcess/API/efl/ewk_download_job.h:
  • UIProcess/API/efl/ewk_form_submission_request.cpp:

(ewk_form_submission_request_ref):

  • UIProcess/API/efl/ewk_form_submission_request.h:
  • UIProcess/API/efl/ewk_intent.cpp:

(ewk_intent_ref):

  • UIProcess/API/efl/ewk_intent.h:
  • UIProcess/API/efl/ewk_intent_service.cpp:

(ewk_intent_service_ref):

  • UIProcess/API/efl/ewk_intent_service.h:
  • UIProcess/API/efl/ewk_navigation_policy_decision.cpp:

(ewk_navigation_policy_decision_ref):

  • UIProcess/API/efl/ewk_navigation_policy_decision.h:
  • UIProcess/API/efl/ewk_url_request.cpp:

(ewk_url_request_ref):

  • UIProcess/API/efl/ewk_url_request.h:
  • UIProcess/API/efl/ewk_url_response.cpp:

(ewk_url_response_ref):

  • UIProcess/API/efl/ewk_url_response.h:
  • UIProcess/API/efl/ewk_url_scheme_request.cpp:

(ewk_url_scheme_request_ref):

  • UIProcess/API/efl/ewk_url_scheme_request.h:
  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_resource_load_initiated):

  • UIProcess/API/efl/ewk_web_resource.cpp:

(ewk_web_resource_ref):

  • UIProcess/API/efl/ewk_web_resource.h:
12:21 AM EFLWebKitCodingStyle edited by Christophe Dumez
(diff)
12:19 AM Changeset in webkit [128412] by Stephanie Lewis
  • 2 edits in trunk/LayoutTests

fast/table/bad-replaced-sizing-preferred-logical-widths.html is failing on Mac, Chromium-Mac, GTK, EFL.
https://bugs.webkit.org/show_bug.cgi?id=96594.

Unreviewed.

Update TestExpectations.

  • platform/mac/TestExpectations:
12:16 AM Changeset in webkit [128411] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

new test fast/canvas/canvas-css-crazy.html fails on Mac
https://bugs.webkit.org/show_bug.cgi?id=96582

Reviewed by Csaba Osztrogonác.

We represent 0 pointers with null, not undefined.

Test: fast/canvas/canvas-css-crazy.html

  • bindings/js/JSCanvasRenderingContextCustom.cpp:

(WebCore::toJS):

Sep 12, 2012:

11:59 PM Changeset in webkit [128410] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update
https://bugs.webkit.org/show_bug.cgi?id=96308

  • platform/chromium-mac/fast/table/height-percent-test-vertical-expected.png:

Rebaseline for http://trac.webkit.org/changeset/128375.

11:59 PM Changeset in webkit [128409] by leandrogracia@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Fix cases where find-in-page doesn't send a final update
https://bugs.webkit.org/show_bug.cgi?id=96402

Fix some issues in the WebKit implementation that prevented to send a final
reportFindInPageMatchCount message.

Reviewed by Adam Barth.

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::scopeStringMatches):
(WebKit::WebFrameImpl::shouldScopeMatches):

11:55 PM Changeset in webkit [128408] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Removing crash expectations for accessibility tests that were added in
r128342. The offending commit was reverted in r128353.

Adding text mismatch expectations for two tests that probably require
rebaselining, failing since r128375.

Adding failure expectations for other regressions:

  • fast/canvas/canvas-css-crazy.html after r128374
  • fast/table/bad-replaced-sizing-preferred-logical-widths.html after r128389
  • fast/js/primitive-property-access-edge-cases.html after r128400
  • platform/gtk/TestExpectations:
11:46 PM Changeset in webkit [128407] by apavlov@chromium.org
  • 5 edits in trunk

Web Inspector: [Styles] Styles not updated when there is a heavy stream of DOM updates
https://bugs.webkit.org/show_bug.cgi?id=96482

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Update the Styles pane even if there is a pending rebuild update for the same current node.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._rebuildUpdate):

LayoutTests:

  • inspector/styles/force-pseudo-state.html:
  • inspector/styles/force-pseudo-state-expected.txt:
11:44 PM Changeset in webkit [128406] by Stephanie Lewis
  • 2 edits in trunk/LayoutTests

css3/filters/custom/filter-fallback-to-software.html fails.
https://bugs.webkit.org/show_bug.cgi?id=94372.

Unreviewed.

Update TestExpectations.

  • platform/mac-wk2/TestExpectations:
10:54 PM Changeset in webkit [128405] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

AX: svg:image not accessible
https://bugs.webkit.org/show_bug.cgi?id=96341

Unreviewed.

Build fix for non-SVG ports.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

10:50 PM Changeset in webkit [128404] by yosin@chromium.org
  • 9 edits
    4 adds in trunk

New time input needs accessibility
https://bugs.webkit.org/show_bug.cgi?id=96032

Reviewed by Chris Fleizach.

Source/WebCore:

This patch adds accessibility support into multiple fields time input
UI by setting "role" HTML attribute of DateTimeFieldElement to "spinbutton"
and changing ARIA attributes to post value change notification.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

Tests: fast/forms/time-multiple-fields/time-multiple-fields-ax-aria-attributes.html

fast/forms/time-multiple-fields/time-multiple-fields-ax-value-changed-notification.html

  • html/shadow/DateTimeFieldElement.cpp:

(WebCore::DateTimeFieldElement::DateTimeFieldElement): Changed to set
"role" HTML attribute to "spinbutton".
(WebCore::DateTimeFieldElement::initialize): Changed to set new
parameter axHelpText to aria-help attribute and set aria-valuemax and
aria-valuemin attributes.
(WebCore::DateTimeFieldElement::updateVisibleValue): Changed to set
aria-valuetext and aria-valuenow attributes.

  • html/shadow/DateTimeFieldElement.h:

(DateTimeFieldElement): Changed to add new parameter axHelpText to initialize().

  • html/shadow/DateTimeFieldElements.cpp:

(WebCore::DateTimeAMPMFieldElement::create): Changed to add new argument.
(WebCore::DateTimeHourFieldElement::create): ditto.
(WebCore::DateTimeMillisecondFieldElement::create): ditto.
(WebCore::DateTimeMinuteFieldElement::create): ditto.
(WebCore::DateTimeSecondFieldElement::create): ditto.

  • html/shadow/DateTimeNumericFieldElement.cpp:

(WebCore::DateTimeNumericFieldElement::maximum): Added for DateTimeFieldElement::initialize().
(WebCore::DateTimeNumericFieldElement::minimum): ditto.

  • html/shadow/DateTimeNumericFieldElement.h:

(DateTimeNumericFieldElement): Added maximum() and minimum() declarations.

  • html/shadow/DateTimeSymbolicFieldElement.cpp:

(WebCore::DateTimeSymbolicFieldElement::maximum): Added for DateTimeFieldElement::initialize().
(WebCore::DateTimeSymbolicFieldElement::minimum): ditto.

  • html/shadow/DateTimeSymbolicFieldElement.h:

(DateTimeSymbolicFieldElement): Added maximum() and minimum() declarations.

LayoutTests:

This patch adds two tests for checking accessibility functionalities
in multiple fields time input UI.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

  • fast/forms/time-multiple-fields/time-multiple-fields-ax-aria-attributes-expected.txt: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-ax-aria-attributes.html: Added to check ARIA attributes used in multiple fields time input UI.
  • fast/forms/time-multiple-fields/time-multiple-fields-ax-value-changed-notification-expected.txt: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-ax-value-changed-notification.html: Added to check accessibility notification supports in multiple fields time input UI.
10:09 PM Changeset in webkit [128403] by commit-queue@webkit.org
  • 46 edits in trunk

Unreviewed, rolling out r127876.
http://trac.webkit.org/changeset/127876
https://bugs.webkit.org/show_bug.cgi?id=96600

mouse click doesn't work for spin button if spin button in
iframe (Requested by yosin on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-12

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

  • WebCore.exp.in:
  • WebCore.order:
  • dom/Document.cpp:

(WebCore::Document::nodesFromRect):

  • dom/Document.h:

(Document):

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::createContextMenu):

  • page/DragController.cpp:

(WebCore::DragController::canProcessDrag):
(WebCore::DragController::startDrag):

  • page/EventHandler.cpp:

(WebCore::EventHandler::updateAutoscrollRenderer):
(WebCore::EventHandler::hitTestResultAtPoint):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::bestClickableNodeForTouchPoint):
(WebCore::EventHandler::bestContextMenuNodeForTouchPoint):
(WebCore::EventHandler::bestZoomableAreaForTouchPoint):
(WebCore::EventHandler::handleTouchEvent):

  • page/EventHandler.h:

(EventHandler):

  • page/FocusController.cpp:

(WebCore::updateFocusCandidateIfNeeded):

  • page/Frame.cpp:

(WebCore::Frame::visiblePositionForPoint):
(WebCore::Frame::documentAtPoint):

  • page/TouchDisambiguation.cpp:

(WebCore::findGoodTouchTargets):

  • rendering/HitTestRequest.h:
  • testing/Internals.cpp:

(WebCore::Internals::nodesFromRect):

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::contextNode):
(BlackBerry::WebKit::WebPagePrivate::nodeForZoomUnderPoint):
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
(BlackBerry::WebKit::WebPage::nodeAtPoint):

  • WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::getNodesFromRect):
(BlackBerry::WebKit::FatFingers::getRelevantInfoFromPoint):

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):

Source/WebKit/chromium:

  • src/ContextMenuClientImpl.cpp:

(WebKit::selectMisspelledWord):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::characterIndexForPoint):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::isRectTopmost):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleMouseUp):
(WebKit::WebViewImpl::computeBlockBounds):

Source/WebKit/efl:

  • ewk/ewk_frame.cpp:

(ewk_frame_hit_test_new):

Source/WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::actionDictionary):

  • WebView/WebHTMLView.mm:

(-[WebHTMLView elementAtPoint:allowShadowContent:]):

Source/WebKit/qt:

  • Api/qwebframe.cpp:

(QWebFrame::hitTestContent):

  • Api/qwebpage.cpp:

(QWebPagePrivate::handleSoftwareInputPanel):
(QWebPagePrivate::TouchAdjuster::findCandidatePointForTouch):
(QWebPage::updatePositionDependentActions):

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):

Source/WebKit/win:

  • WebActionPropertyBag.cpp:

(WebActionPropertyBag::Read):

  • WebView.cpp:

(WebView::handleContextMenuEvent):
(WebView::elementAtPoint):

Source/WebKit/wx:

  • WebFrame.cpp:

(WebKit::WebFrame::HitTest):

Source/WebKit2:

  • WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp:

(WebKit::InjectedBundleNavigationAction::InjectedBundleNavigationAction):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::handleContextMenuEvent):
(WebKit::WebPage::highlightPotentialActivation):
(WebKit::WebPage::findZoomableAreaForPoint):

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::characterIndexForPoint):
(WebKit::WebPage::performDictionaryLookupAtLocation):
(WebKit::WebPage::shouldDelayWindowOrderingEvent):
(WebKit::WebPage::acceptsFirstMouse):

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
9:50 PM FeatureFlags edited by tkent@chromium.org
OVERFLOW_SCROLLING -> ACCELERATED_OVERFLOW_SCROLLING (diff)
9:33 PM Changeset in webkit [128402] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update
https://bugs.webkit.org/show_bug.cgi?id=96308

  • platform/chromium-win/fast/table/height-percent-test-vertical-expected.png:

Rebaseline for http://trac.webkit.org/changeset/128375.

9:21 PM Changeset in webkit [128401] by mitz@apple.com
  • 2 edits in trunk/Source/WTF

Removed a reference to a file that doesn’t participate in any target.

  • WTF.xcodeproj/project.pbxproj: Removed the reference to

CONTRIBUTORS.pthreads-win32.

9:18 PM Changeset in webkit [128400] by fpizlo@apple.com
  • 104 edits
    14 adds
    1 delete in trunk

JSC should have property butterflies
https://bugs.webkit.org/show_bug.cgi?id=91933

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

This changes the JSC object model. Previously, all objects had fast lookup for
named properties. Integer indexed properties were only fast if you used a
JSArray. With this change, all objects have fast indexed properties. This is
accomplished without any space overhead by using a bidirectional object layout,
aka butterflies. Each JSObject has a m_butterfly pointer where previously it
had a m_outOfLineStorage pointer. To the left of the location pointed to by
m_butterfly, we place all named out-of-line properties. To the right, we place
all indexed properties along with indexing meta-data. Though, some indexing
meta-data is placed in the 8-byte word immediately left of the pointed-to
location; this is in anticipation of the indexing meta-data being small enough
in the common case that m_butterfly always points to the first indexed
property.

This is performance neutral, except on tests that use indexed properties on
plain objects, where the speed-up is in excess of an order of magnitude.

One notable aspect of what this change brings is that it allows indexing
storage to morph over time. Currently this is only used to allow all non-array
objects to start out without any indexed storage. But it could be used for
some kinds of array type inference in the future.

  • API/JSCallbackObject.h:

(JSCallbackObject):

  • API/JSCallbackObjectFunctions.h:

(JSC::::getOwnPropertySlotByIndex):
(JSC):
(JSC::::getOwnNonIndexPropertyNames):

  • API/JSObjectRef.cpp:
  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/ArrayProfile.h:

(JSC):
(JSC::arrayModeFromStructure):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitDirectPutById):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGAdjacencyList.h:

(JSC::DFG::AdjacencyList::AdjacencyList):
(AdjacencyList):

  • dfg/DFGArrayMode.cpp:

(JSC::DFG::fromObserved):
(JSC::DFG::modeAlreadyChecked):
(JSC::DFG::modeToString):

  • dfg/DFGArrayMode.h:

(DFG):
(JSC::DFG::modeUsesButterfly):
(JSC::DFG::modeIsJSArray):
(JSC::DFG::isInBoundsAccess):
(JSC::DFG::modeSupportsLength):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleGetByOffset):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::addNode):
(FixupPhase):
(JSC::DFG::FixupPhase::checkArray):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::byValIsPure):

  • dfg/DFGNode.h:

(JSC::DFG::Node::Node):
(Node):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOperations.cpp:

(JSC::DFG::putByVal):

  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGRepatch.cpp:

(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::emitPutReplaceStub):
(JSC::DFG::emitPutTransitionStub):
(JSC::DFG::tryBuildPutByIdList):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArray):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
(JSC::DFG::SpeculativeJIT::compileGetArrayLength):
(JSC::DFG::SpeculativeJIT::compileAllocatePropertyStorage):
(JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):
(JSC::DFG::SpeculativeJIT::emitAllocateBasicJSObject):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):

  • heap/CopiedSpace.h:

(CopiedSpace):

  • jit/JIT.h:
  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicJSObject):
(JSC::JIT::emitAllocateBasicStorage):
(JSC::JIT::emitAllocateJSArray):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_new_array):
(JSC::JIT::emitSlow_op_new_array):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::privateCompilePatchGetArrayLength):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::privateCompilePatchGetArrayLength):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jsc.cpp:
  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/Arguments.cpp:

(JSC::Arguments::deletePropertyByIndex):
(JSC::Arguments::defineOwnProperty):

  • runtime/ArrayConstructor.cpp:
  • runtime/ArrayConventions.h: Added.

(JSC):
(JSC::isDenseEnoughForVector):
(JSC::indexingHeaderForArray):
(JSC::baseIndexingHeaderForArray):

  • runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::create):
(JSC):
(JSC::ArrayPrototype::ArrayPrototype):
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncForEach):
(JSC::arrayProtoFuncSome):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):

  • runtime/ArrayPrototype.h:

(ArrayPrototype):
(JSC::ArrayPrototype::createStructure):

  • runtime/ArrayStorage.h: Added.

(JSC):
(ArrayStorage):
(JSC::ArrayStorage::ArrayStorage):
(JSC::ArrayStorage::from):
(JSC::ArrayStorage::butterfly):
(JSC::ArrayStorage::indexingHeader):
(JSC::ArrayStorage::length):
(JSC::ArrayStorage::setLength):
(JSC::ArrayStorage::vectorLength):
(JSC::ArrayStorage::setVectorLength):
(JSC::ArrayStorage::copyHeaderFromDuringGC):
(JSC::ArrayStorage::inSparseMode):
(JSC::ArrayStorage::lengthOffset):
(JSC::ArrayStorage::vectorLengthOffset):
(JSC::ArrayStorage::numValuesInVectorOffset):
(JSC::ArrayStorage::vectorOffset):
(JSC::ArrayStorage::indexBiasOffset):
(JSC::ArrayStorage::sparseMapOffset):
(JSC::ArrayStorage::sizeFor):

  • runtime/Butterfly.h: Added.

(JSC):
(Butterfly):
(JSC::Butterfly::Butterfly):
(JSC::Butterfly::totalSize):
(JSC::Butterfly::fromBase):
(JSC::Butterfly::offsetOfIndexingHeader):
(JSC::Butterfly::offsetOfPublicLength):
(JSC::Butterfly::offsetOfVectorLength):
(JSC::Butterfly::indexingHeader):
(JSC::Butterfly::propertyStorage):
(JSC::Butterfly::indexingPayload):
(JSC::Butterfly::arrayStorage):
(JSC::Butterfly::offsetOfPropertyStorage):
(JSC::Butterfly::indexOfPropertyStorage):
(JSC::Butterfly::base):

  • runtime/ButterflyInlineMethods.h: Added.

(JSC):
(JSC::Butterfly::createUninitialized):
(JSC::Butterfly::create):
(JSC::Butterfly::createUninitializedDuringCollection):
(JSC::Butterfly::base):
(JSC::Butterfly::growPropertyStorage):
(JSC::Butterfly::growArrayRight):
(JSC::Butterfly::resizeArray):
(JSC::Butterfly::unshift):
(JSC::Butterfly::shift):

  • runtime/ClassInfo.h:

(MethodTable):
(JSC):

  • runtime/IndexingHeader.h: Added.

(JSC):
(IndexingHeader):
(JSC::IndexingHeader::offsetOfIndexingHeader):
(JSC::IndexingHeader::offsetOfPublicLength):
(JSC::IndexingHeader::offsetOfVectorLength):
(JSC::IndexingHeader::IndexingHeader):
(JSC::IndexingHeader::vectorLength):
(JSC::IndexingHeader::setVectorLength):
(JSC::IndexingHeader::publicLength):
(JSC::IndexingHeader::setPublicLength):
(JSC::IndexingHeader::from):
(JSC::IndexingHeader::fromEndOf):
(JSC::IndexingHeader::propertyStorage):
(JSC::IndexingHeader::arrayStorage):
(JSC::IndexingHeader::butterfly):

  • runtime/IndexingHeaderInlineMethods.h: Added.

(JSC):
(JSC::IndexingHeader::preCapacity):
(JSC::IndexingHeader::indexingPayloadSizeInBytes):

  • runtime/IndexingType.h: Added.

(JSC):
(JSC::hasIndexingHeader):

  • runtime/JSActivation.cpp:

(JSC::JSActivation::JSActivation):
(JSC::JSActivation::visitChildren):
(JSC::JSActivation::getOwnNonIndexPropertyNames):

  • runtime/JSActivation.h:

(JSActivation):
(JSC::JSActivation::tearOff):

  • runtime/JSArray.cpp:

(JSC):
(JSC::createArrayButterflyInDictionaryIndexingMode):
(JSC::JSArray::setLengthWritable):
(JSC::JSArray::defineOwnProperty):
(JSC::JSArray::getOwnPropertySlot):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::put):
(JSC::JSArray::deleteProperty):
(JSC::JSArray::getOwnNonIndexPropertyNames):
(JSC::JSArray::unshiftCountSlowCase):
(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::push):
(JSC::JSArray::shiftCount):
(JSC::JSArray::unshiftCount):
(JSC::JSArray::sortNumeric):
(JSC::JSArray::sort):
(JSC::JSArray::fillArgList):
(JSC::JSArray::copyToArguments):
(JSC::JSArray::compactForSorting):

  • runtime/JSArray.h:

(JSC):
(JSArray):
(JSC::JSArray::JSArray):
(JSC::JSArray::length):
(JSC::JSArray::createStructure):
(JSC::JSArray::isLengthWritable):
(JSC::createArrayButterfly):
(JSC::JSArray::create):
(JSC::JSArray::tryCreateUninitialized):

  • runtime/JSBoundFunction.cpp:

(JSC::boundFunctionCall):
(JSC::boundFunctionConstruct):
(JSC::JSBoundFunction::finishCreation):

  • runtime/JSCell.cpp:

(JSC::JSCell::getOwnNonIndexPropertyNames):
(JSC):

  • runtime/JSCell.h:

(JSCell):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::getOwnPropertyDescriptor):
(JSC::JSFunction::getOwnNonIndexPropertyNames):
(JSC::JSFunction::defineOwnProperty):

  • runtime/JSFunction.h:

(JSFunction):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

(JSGlobalData):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

  • runtime/JSONObject.cpp:

(JSC::Stringifier::Holder::appendNextProperty):
(JSC::Walker::walk):

  • runtime/JSObject.cpp:

(JSC):
(JSC::JSObject::visitButterfly):
(JSC::JSObject::visitChildren):
(JSC::JSFinalObject::visitChildren):
(JSC::JSObject::getOwnPropertySlotByIndex):
(JSC::JSObject::put):
(JSC::JSObject::putByIndex):
(JSC::JSObject::enterDictionaryIndexingModeWhenArrayStorageAlreadyExists):
(JSC::JSObject::enterDictionaryIndexingMode):
(JSC::JSObject::createArrayStorage):
(JSC::JSObject::createInitialArrayStorage):
(JSC::JSObject::ensureArrayStorageExistsAndEnterDictionaryIndexingMode):
(JSC::JSObject::putDirectAccessor):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::deletePropertyByIndex):
(JSC::JSObject::getOwnPropertyNames):
(JSC::JSObject::getOwnNonIndexPropertyNames):
(JSC::JSObject::preventExtensions):
(JSC::JSObject::fillGetterPropertySlot):
(JSC::JSObject::putIndexedDescriptor):
(JSC::JSObject::defineOwnIndexedProperty):
(JSC::JSObject::allocateSparseIndexMap):
(JSC::JSObject::deallocateSparseIndexMap):
(JSC::JSObject::putByIndexBeyondVectorLengthWithArrayStorage):
(JSC::JSObject::putByIndexBeyondVectorLength):
(JSC::JSObject::putDirectIndexBeyondVectorLengthWithArrayStorage):
(JSC::JSObject::putDirectIndexBeyondVectorLength):
(JSC::JSObject::getNewVectorLength):
(JSC::JSObject::increaseVectorLength):
(JSC::JSObject::checkIndexingConsistency):
(JSC::JSObject::growOutOfLineStorage):
(JSC::JSObject::getOwnPropertyDescriptor):
(JSC::putDescriptor):
(JSC::JSObject::putDirectMayBeIndex):
(JSC::JSObject::defineOwnNonIndexProperty):
(JSC::JSObject::defineOwnProperty):
(JSC::JSObject::getOwnPropertySlotSlow):

  • runtime/JSObject.h:

(JSC::JSObject::getArrayLength):
(JSObject):
(JSC::JSObject::getVectorLength):
(JSC::JSObject::putDirectIndex):
(JSC::JSObject::canGetIndexQuickly):
(JSC::JSObject::getIndexQuickly):
(JSC::JSObject::canSetIndexQuickly):
(JSC::JSObject::setIndexQuickly):
(JSC::JSObject::initializeIndex):
(JSC::JSObject::completeInitialization):
(JSC::JSObject::inSparseIndexingMode):
(JSC::JSObject::butterfly):
(JSC::JSObject::outOfLineStorage):
(JSC::JSObject::offsetForLocation):
(JSC::JSObject::indexingShouldBeSparse):
(JSC::JSObject::butterflyOffset):
(JSC::JSObject::butterflyAddress):
(JSC::JSObject::arrayStorage):
(JSC::JSObject::arrayStorageOrZero):
(JSC::JSObject::ensureArrayStorage):
(JSC::JSObject::checkIndexingConsistency):
(JSC::JSNonFinalObject::JSNonFinalObject):
(JSC):
(JSC::JSObject::setButterfly):
(JSC::JSObject::setButterflyWithoutChangingStructure):
(JSC::JSObject::JSObject):
(JSC::JSObject::inlineGetOwnPropertySlot):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::setStructureAndReallocateStorageIfNecessary):
(JSC::JSObject::putDirectWithoutTransition):
(JSC::offsetInButterfly):
(JSC::offsetRelativeToPatchedStorage):
(JSC::indexRelativeToBase):
(JSC::offsetRelativeToBase):

  • runtime/JSPropertyNameIterator.cpp:

(JSC::JSPropertyNameIterator::create):

  • runtime/JSSymbolTableObject.cpp:

(JSC::JSSymbolTableObject::getOwnNonIndexPropertyNames):

  • runtime/JSSymbolTableObject.h:

(JSSymbolTableObject):

  • runtime/JSTypeInfo.h:

(JSC):
(JSC::TypeInfo::interceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero):
(JSC::TypeInfo::overridesGetPropertyNames):

  • runtime/LiteralParser.cpp:

(JSC::::parse):

  • runtime/ObjectConstructor.cpp:
  • runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::ObjectPrototype):
(JSC):

  • runtime/ObjectPrototype.h:

(ObjectPrototype):

  • runtime/PropertyOffset.h:

(JSC::offsetInOutOfLineStorage):

  • runtime/PropertyStorage.h: Added.

(JSC):

  • runtime/PutDirectIndexMode.h: Added.

(JSC):

  • runtime/RegExpMatchesArray.cpp:

(JSC::RegExpMatchesArray::RegExpMatchesArray):
(JSC):
(JSC::RegExpMatchesArray::create):
(JSC::RegExpMatchesArray::finishCreation):

  • runtime/RegExpMatchesArray.h:

(RegExpMatchesArray):
(JSC::RegExpMatchesArray::createStructure):

  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::getOwnNonIndexPropertyNames):

  • runtime/RegExpObject.h:

(RegExpObject):

  • runtime/Reject.h: Added.

(JSC):
(JSC::reject):

  • runtime/SparseArrayValueMap.cpp: Added.

(JSC):

  • runtime/SparseArrayValueMap.h: Added.

(JSC):
(SparseArrayEntry):
(JSC::SparseArrayEntry::SparseArrayEntry):
(SparseArrayValueMap):
(JSC::SparseArrayValueMap::sparseMode):
(JSC::SparseArrayValueMap::setSparseMode):
(JSC::SparseArrayValueMap::lengthIsReadOnly):
(JSC::SparseArrayValueMap::setLengthIsReadOnly):
(JSC::SparseArrayValueMap::find):
(JSC::SparseArrayValueMap::remove):
(JSC::SparseArrayValueMap::notFound):
(JSC::SparseArrayValueMap::isEmpty):
(JSC::SparseArrayValueMap::contains):
(JSC::SparseArrayValueMap::size):
(JSC::SparseArrayValueMap::begin):
(JSC::SparseArrayValueMap::end):

  • runtime/SparseArrayValueMapInlineMethods.h: Added.

(JSC):
(JSC::SparseArrayValueMap::SparseArrayValueMap):
(JSC::SparseArrayValueMap::~SparseArrayValueMap):
(JSC::SparseArrayValueMap::finishCreation):
(JSC::SparseArrayValueMap::create):
(JSC::SparseArrayValueMap::destroy):
(JSC::SparseArrayValueMap::createStructure):
(JSC::SparseArrayValueMap::add):
(JSC::SparseArrayValueMap::putEntry):
(JSC::SparseArrayValueMap::putDirect):
(JSC::SparseArrayEntry::get):
(JSC::SparseArrayEntry::getNonSparseMode):
(JSC::SparseArrayValueMap::visitChildren):

  • runtime/StorageBarrier.h: Removed.
  • runtime/StringObject.cpp:

(JSC::StringObject::putByIndex):
(JSC):
(JSC::StringObject::deletePropertyByIndex):

  • runtime/StringObject.h:

(StringObject):

  • runtime/StringPrototype.cpp:
  • runtime/Structure.cpp:

(JSC::Structure::Structure):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::nonPropertyTransition):
(JSC):

  • runtime/Structure.h:

(Structure):
(JSC::Structure::indexingType):
(JSC::Structure::indexingTypeIncludingHistory):
(JSC::Structure::indexingTypeOffset):
(JSC::Structure::create):

  • runtime/StructureTransitionTable.h:

(JSC):
(JSC::toAttributes):
(JSC::newIndexingType):
(JSC::StructureTransitionTable::Hash::hash):

  • tests/mozilla/js1_6/Array/regress-304828.js:

Source/WebCore:

Teach the DOM that to intercept get/put on indexed properties, you now have
to override getOwnPropertySlotByIndex and putByIndex.

No new tests because no new behavior. One test was rebased because indexed
property iteration order now matches other engines (indexed properties always
come first).

  • bindings/js/ArrayValue.cpp:

(WebCore::ArrayValue::get):

  • bindings/js/JSBlobCustom.cpp:

(WebCore::JSBlobConstructor::constructJSBlob):

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:

(WebCore::JSCanvasRenderingContext2D::setWebkitLineDash):

  • bindings/js/JSDOMStringListCustom.cpp:

(WebCore::toDOMStringList):

  • bindings/js/JSDOMStringMapCustom.cpp:

(WebCore::JSDOMStringMap::deletePropertyByIndex):
(WebCore):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):
(WebCore):
(WebCore::JSDOMWindow::putByIndex):
(WebCore::JSDOMWindow::deletePropertyByIndex):

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::getOwnPropertySlotByIndex):
(WebCore):
(WebCore::JSDOMWindowShell::putByIndex):
(WebCore::JSDOMWindowShell::deletePropertyByIndex):

  • bindings/js/JSDOMWindowShell.h:

(JSDOMWindowShell):

  • bindings/js/JSHistoryCustom.cpp:

(WebCore::JSHistory::deletePropertyByIndex):
(WebCore):

  • bindings/js/JSInspectorFrontendHostCustom.cpp:

(WebCore::populateContextMenuItems):

  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::deletePropertyByIndex):
(WebCore):

  • bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::deletePropertyByIndex):
(WebCore):

  • bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocketConstructor::constructJSWebSocket):

  • bindings/js/ScriptValue.cpp:

(WebCore::jsToInspectorValue):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::serialize):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::RuntimeArray):

  • bridge/runtime_array.h:

(JSC::RuntimeArray::createStructure):
(RuntimeArray):

LayoutTests:

Modify the JSON test to indicate that iterating over properties now returns
indexed properties first. This is a behavior change that makes us more
compliant with other implementations.

Also check in new expected file for the edge cases of indexed property access
with prototype accessors. This changeset introduces a known regression in that
department, which is tracked here: https://bugs.webkit.org/show_bug.cgi?id=96596

  • fast/js/resources/JSON-stringify.js:
  • platform/mac/fast/js/primitive-property-access-edge-cases-expected.txt: Added.
9:18 PM Changeset in webkit [128399] by Csaba Osztrogonác
  • 4 edits
    1 add in trunk/Tools

Add SVN mirror handling feature to build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=85887

Reviewed by Dirk Pranke.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Add SVN mirrors for Qt buildslaves hosted in Szeged.
  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(ConfigureBuild.init): Add SVNMirror property to be able to watch which slaves use which mirror on build.webkit.org.
(ConfigureBuild.start):
(CheckOutSource.init): Set baseURL to the SVNMirror or the default http://svn.webkit.org/repository/webkit/
(WaitForSVNServer): Add new buildstep for waiting the SVNMirror to be in sync with http://svn.webkit.org/repository/webkit/
(Factory.init):
(BuildFactory.init):
(TestFactory.init):
(BuildAndTestFactory.init):
(BuildAndPerfTestFactory.init):
(BuildAndPerfTestWebKit2Factory.init):
(DownloadAndPerfTestFactory.init):
(DownloadAndPerfTestWebKit2Factory.init):
(loadBuilderConfig): Use kwargs instead of args to be able to add the optional SVNMirror factory argument.

  • BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:

(SVNMirrorTest):
(SVNMirrorTest.setUp): Load config.json once at startup.
(SVNMirrorTest.get_SVNMirrorFromConfig): Get the SVNMirror from config.json for a given buildslave.
(SVNMirrorTest.test_CheckOutSource): Compare CheckOutSource.baseURL with SVNMirror in config.json for all builders

  • BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py: Added.

(getLatestSVNRevision): Get the latest SVN revison from the given server.
(waitForSVNRevision): Wait until the given SVN revision is committed to the given server. It doesn't wait if the

SVN revision is empty (force build triggered without revision) or the server is unavailable.

8:22 PM Changeset in webkit [128398] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update
https://bugs.webkit.org/show_bug.cgi?id=96594

  • platform/chromium/TestExpectations:

fast/table/bad-replaced-sizing-preferred-logical-widths.html fails on Mac.

8:00 PM Changeset in webkit [128397] by dgrogan@chromium.org
  • 2 edits in trunk/LayoutTests

Fix indexeddb/basics-shared-workers-expected.txt
https://bugs.webkit.org/show_bug.cgi?id=96591

Reviewed by Kent Tamura.

Needed to pass IndexedDBLayoutTest.BasicTests in content_browsertests
after 128370.

  • storage/indexeddb/basics-shared-workers-expected.txt:
7:20 PM Changeset in webkit [128396] by Stephanie Lewis
  • 2 edits in trunk/LayoutTests

fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks.html fails on Mac.
https://bugs.webkit.org/show_bug.cgi?id=96583

Unreviewed.

Update TestExpectations

  • platform/mac/TestExpectations:
7:13 PM Changeset in webkit [128395] by commit-queue@webkit.org
  • 4 edits in trunk

[WK2][WTR] Set waitUntilDone watchdog timer value equal to WK1.
https://bugs.webkit.org/show_bug.cgi?id=81606

Patch by Kangil Han <kangil.han@samsung.com> on 2012-09-12
Reviewed by Tim Horton.

Tools:

6 seconds is harsh for some jquery test cases.
Therefore, adjust the value to match DumpRenderTree.

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR):

LayoutTests:

Unskip jQuery tests which will now consistently pass due to the increased waitUntilDone timeout.

  • platform/wk2/Skipped:
6:02 PM Changeset in webkit [128394] by tkent@chromium.org
  • 10 edits
    1 add in trunk/Source/WebCore

Introduce ValidationMessageClient
https://bugs.webkit.org/show_bug.cgi?id=96238

Reviewed by Hajime Morita.

ValidationMessageClient interface is responsible to operate validation
message UI for interactive form validation. If a Page object has a
ValidtionMessageClient, ValidationMessae class uses
ValidtionMessageClient instead of Shadow DOM.

No new tests because of no behavior changes.

  • GNUmakefile.list.am: Add ValidtionMessageClient.h.
  • Target.pri: ditto.
  • WebCore.gypi: ditto.
  • WebCore.xcodeproj/project.pbxproj: ditto.
  • html/ValidationMessage.cpp:

(WebCore::ValidationMessage::~ValidationMessage):
Hide a validation message via ValidationMessageClient if it is available.
(WebCore::ValidationMessage::validationMessageClient):
A helper function to get Page::validationMessageClient.
(WebCore::ValidationMessage::updateValidationMessage):
Adding title attribute is not neeeded if ValidationMessageClient is
used. It shoudl be handled in a ValidtionMessageClient implementation.
(WebCore::ValidationMessage::setMessage):
Show a validation message via ValidationMessageClient if it is available.
(WebCore::ValidationMessage::setMessageDOMAndStartTimer):
Add an assertion that ValidationMessageClient should not be available.
(WebCore::ValidationMessage::buildBubbleTree): ditto.
(WebCore::ValidationMessage::requestToHideMessage):
Hide a validation message via ValidationMessageClient if it is available.
(WebCore::ValidationMessage::shadowTreeContains):
Always returns false if ValidationMessageClient is available, it means no Shadow DOM.
(WebCore::ValidationMessage::deleteBubbleTree):
Add an assertion that ValidationMessageClient should not be available.
(WebCore::ValidationMessage::isVisible):
Ask ValidationMessageClient for visibility if it is available.

  • html/ValidationMessage.h:

(WebCore): Add a comment.
(ValidationMessage): Add validtionMessageClient member function.

  • page/Page.cpp:

(WebCore::Page::Page): Initialize m_validationMessageClient.
(WebCore::Page::PageClients::PageClients):
Initialize validationMessageClient member with 0.
So, existing code makes Page::m_validationMessageClient 0.

  • page/Page.h:

(PageClients): Add validationMessageClient member.
(WebCore::Page::validationMessageClient):
Added. Accessor for m_validationMessageClient.
(Page): Add m_validationMessageClient.

  • page/Settings.h:

(Settings): Updated the comment for setInteractiveFormValidationEnabled.

  • page/ValidationMessageClient.h: Added.
5:56 PM Changeset in webkit [128393] by commit-queue@webkit.org
  • 12 edits in trunk

[EFL] Support download attribute feature
https://bugs.webkit.org/show_bug.cgi?id=96462

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-09-12
Reviewed by Gyuyoung Kim.

.:

  • Source/cmake/OptionsEfl.cmake: Enable DOWNLOAD_ATTRIBUTE feature.

Source/WebKit/efl:

Add suggested_name field on _Ewk_Download and set it on startDownload
to get suggested name passed as a download attribute.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::download):
(WebCore::FrameLoaderClientEfl::startDownload):

  • ewk/ewk_view.h:

Tools:

Enable DOWNLOAD_ATTRIBUTE feature for EFL port,
and add "download,request" callback to the DumpRenderTree for EFL.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onDownloadRequest):

  • DumpRenderTree/efl/DumpRenderTreeChrome.h:

(DumpRenderTreeChrome):

  • Scripts/webkitperl/FeatureList.pm:

LayoutTests:

  • platform/efl/Skipped: Unskip test cases related to download attributes.
  • platform/efl-wk2/TestExpectations: Add test cases related to download attributes because they are still failed for WK2
5:52 PM Changeset in webkit [128392] by Stephanie Lewis
  • 2 edits in trunk/LayoutTests

css3/filters/custom/filter-fallback-to-software.html fails on Debug WK2.
https://bugs.webkit.org/show_bug.cgi?id=94372.

Unreviewed.

  • platform/mac-wk2/TestExpectations:
5:49 PM Changeset in webkit [128391] by Stephanie Lewis
  • 2 edits in trunk/Tools

Reduce parallism on the wk2 testers.
https://bugs.webkit.org/show_bug.cgi?id=95906

Reviewed by Dirk Pranke.

The wk2 testers on Mountain Lion are getting stuck and timing out. The problem appears to be due to
resource contention. Reducing the number of processes alleviates the issue.

Starting by reducing 25%.

  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.default_child_processes):

5:43 PM Changeset in webkit [128390] by dimich@chromium.org
  • 6 edits in trunk/Source/WebCore

[V8] OOM in Workers due to external memory retention.
https://bugs.webkit.org/show_bug.cgi?id=96459

Reviewed by David Levin.

Added memory checks to the locations in Workers code that are about to invoke the next JS block.

  • bindings/v8/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute):

  • bindings/v8/V8GCController.cpp:

(WebCore):
(WebCore::workingSetEstimateMBMutex): Added a Mutex-protected accessors to a static caching WS estimate.
(WebCore::V8GCController::gcEpilogue):
(WebCore::V8GCController::checkMemoryUsage):

  • bindings/v8/V8GCController.h:

(V8GCController):

  • bindings/v8/V8WorkerContextEventListener.cpp:

(WebCore::V8WorkerContextEventListener::callListenerFunction):

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::evaluate):

5:30 PM Changeset in webkit [128389] by jchaffraix@webkit.org
  • 4 edits
    4 adds in trunk

REGRESSION(r122501): replaced elements with percent width are wrongly size when inserted inside an auto-table layout
https://bugs.webkit.org/show_bug.cgi?id=95892

Reviewed by Ojan Vafai.

Source/WebCore:

r122501 exposed an issue in how preferred logical widths are computed on replaced objects. The code relies on the
logical width computation methods. Unfortunately the previous code relies on the layout information, which may not
be up-to-date during preferred logical width computation.

Test: fast/table/bad-replaced-sizing-preferred-logical-widths.html

fast/replaced/vertical-writing-mode-max-logical-width.html

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeMaxPreferredLogicalWidth):
Added this helper method. The main difference with the old code is that it handles the percent logical width
properly before calling the old code path. This is not totally right but before forking the whole code, it's
better to have more evidence that forking preferred logical widths and logical width computation is the way to go.

(WebCore::RenderReplaced::computePreferredLogicalWidths):
Changed to call computeMaxPreferredLogicalWidth. Also fixed an existing bug in vertical-writing modes where we would
add the wrong paddings and borders.

  • rendering/RenderReplaced.h:

(RenderReplaced): Added computeMaxPreferredLogicalWidth.

LayoutTests:

  • fast/replaced/vertical-writing-mode-max-logical-width-replaced-expected.txt: Added.
  • fast/replaced/vertical-writing-mode-max-logical-width-replaced.html: Added.
  • fast/table/bad-replaced-sizing-preferred-logical-widths-expected.txt: Added.
  • fast/table/bad-replaced-sizing-preferred-logical-widths.html: Added.
  • fast/table/resources/iframe.html: Added.
5:18 PM Changeset in webkit [128388] by beidson@apple.com
  • 7 edits
    3 adds in trunk

Assert in NetscapePlugin::destroy() with async plugin init
<rdar://problem/12277595> and https://bugs.webkit.org/show_bug.cgi?id=96576

Reviewed by Anders Carlsson.

Source/WebKit2:

Most of the NPN_* API calls have a plug-in protector during the calls.
NPN_Invoke and NPN_InvokeDefault do not.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_Invoke): Protect the plug-in during this call.
(WebKit::NPN_InvokeDefault): Ditto.

Tools:

Expose NPN_Invoke to plug-in tests:

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:

(PluginTest::NPN_Invoke):

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h:

(PluginTest):

Add a test that uses NPN_Invoke on the window object from inside NPP_New to remove the plug-in element:

  • DumpRenderTree/TestNetscapePlugIn/Tests/InvokeDestroysPluginWithinNPP_New.cpp: Added.

(InvokeDestroysPluginWithinNPP_New):
(InvokeDestroysPluginWithinNPP_New::InvokeDestroysPluginWithinNPP_New):
(InvokeDestroysPluginWithinNPP_New::NPP_New):

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

LayoutTests:

  • platform/mac-wk2/plugins/destroy-during-async-npp-new-expected.txt: Added.
  • platform/mac-wk2/plugins/destroy-during-async-npp-new.html: Added.
5:17 PM Changeset in webkit [128387] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[CSS Shaders] Cached validated programs are destroyed and recreated when there is only one custom filter animating
https://bugs.webkit.org/show_bug.cgi?id=96563

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-09-12
Reviewed by Dean Jackson.

Before this patch, in FilterEffectRenderer::build, we would first clear the old effects and
then create the new effects.

Suppose we have one FECustomFilter animating on the page. This FECustomFilter holds the last
reference to the cached validated program. Before this patch, we would first destroy the old
FECustomFilter, which would destroy its cached validated program. Then, we would create the
new FECustomFilter and have to recreate the validated program.

This patch makes FilterEffectRenderer::build keep the old effects around until we're
done creating the new effects. This way, we won't recreate validated programs.

No new tests. We can't test this because the validated program cache is not exposed to web
pages.

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::build):

5:13 PM Changeset in webkit [128386] by dpranke@chromium.org
  • 2 edits in trunk/Tools

refactor TestExpectations tokenization slightly in preparation for the new syntax
https://bugs.webkit.org/show_bug.cgi?id=96564

Reviewed by Ojan Vafai.

This change changes how we will tokenize/lex the
TestExpectations files, in preparation for supporting both the
old syntax and the new one. This change by itself should be a
no-op.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationParser._tokenize_line):
(TestExpectationParser):
(TestExpectationParser._tokenize_line_using_old_format):
(TestExpectationParser._tokenize_line_using_new_format):

5:09 PM Changeset in webkit [128385] by dpranke@chromium.org
  • 5 edits
    2 deletes in trunk/Tools

remove unused testexpectations editing code from webkitpy, garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=96562

Reviewed by Adam Barth.

This code was prototyped but never fully realized. Removing
until it reanimates :).

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
  • Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py: Removed.
  • Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py: Removed.
  • Scripts/webkitpy/tool/servers/gardeningserver.py:

(BuildCoverageExtrapolator.extrapolate_test_configurations):
(GardeningHTTPRequestHandler._run_webkit_patch):
(GardeningHTTPRequestHandler.ping):

  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:

(BuildCoverageExtrapolatorTest.test_extrapolate):
(GardeningServerTest.test_rebaseline_new_port):

5:04 PM Changeset in webkit [128384] by jamesr@google.com
  • 2 edits
    1 add in trunk/LayoutTests

Rebaseline chromium-mac pixel results for 128375

  • platform/chromium-mac-snowleopard/fast/table/height-percent-test-vertical-expected.png:
  • platform/chromium-mac/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt: Added.
4:48 PM Changeset in webkit [128383] by tony@chromium.org
  • 3 edits
    2 adds in trunk

flex item sized incorrectly in a column flexbox with height set via top/bottom
https://bugs.webkit.org/show_bug.cgi?id=94855

Reviewed by Ojan Vafai.

Source/WebCore:

Stop using computeContentLogicalHeight() to get the height of the flexbox and
use computeLogicalHeight directly. This properly takes into account out of flow
positioning.

We can actually refactor some of this into common code, but I want to do that as
a separate pass.

Test: css3/flexbox/columns-height-set-via-top-bottom.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::repositionLogicalHeightDependentFlexItems): Fix out of date comment.
(WebCore::RenderFlexibleBox::mainAxisContentExtent): Use computeLogicalHeight instead of computeContentLogicalHeight.
This code actually never gets used-- I'll try to remove in a follow up.
(WebCore::RenderFlexibleBox::computeAvailableFreeSpace): Use computeLogicalHeight instead of computeContentLogicalHeight.
(WebCore::RenderFlexibleBox::lineBreakLength): Use computeLogicalHeight instead of computeContentLogicalHeight.

LayoutTests:

Test where the height of a column flexbox is set via top and bottom.

  • css3/flexbox/columns-height-set-via-top-bottom-expected.txt: Added.
  • css3/flexbox/columns-height-set-via-top-bottom.html: Added.
4:44 PM Changeset in webkit [128382] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

[V8] V8DOMWrapper::perContextData has no callers and can be removed
https://bugs.webkit.org/show_bug.cgi?id=96574

Reviewed by Kentaro Hara.

  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getCachedWrapper):

4:36 PM Changeset in webkit [128381] by Lucas Forschler
  • 2 edits in trunk/Tools

Remove unused bot, apple-xserve-1.
https://bugs.webkit.org/show_bug.cgi?id=96570

Reviewed by Stephanie Lewis.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
4:33 PM Changeset in webkit [128380] by Alexandru Chiculita
  • 13 edits
    2 adds in trunk

[CSS Shaders] Implement transform parameter animations for CSS Custom Filters
https://bugs.webkit.org/show_bug.cgi?id=94980

Reviewed by Dean Jackson.

Based on patch from Joshua Netterfield <jnetterfield@rim.com>.

Source/WebCore:

According to Section 39.2 of Filter Effects 1.0 Editor's draft
(https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html), animations
of transforms should be handled following the CSS3 transform interpolation
rules. This patch implements this functionality.

Test: css3/filters/custom/custom-filter-transforms-animation.html

  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc):
(WebCore):

  • platform/graphics/filters/CustomFilterNumberParameter.h:

(WebCore::CustomFilterNumberParameter::blend):

  • platform/graphics/filters/CustomFilterOperation.cpp:

(WebCore::blendCustomFilterParameters):
(WebCore::CustomFilterOperation::blend):

  • platform/graphics/filters/CustomFilterOperation.h:

(WebCore):
(WebCore::CustomFilterOperation::blendingNeedsRendererSize): Some filters need the box size, so that they could compute
Transforms. Right now only the CustomFilterOperation needs that, but I've implemented using this generic function.
(CustomFilterOperation):

  • platform/graphics/filters/CustomFilterParameter.h:

(CustomFilterParameter):

  • platform/graphics/filters/CustomFilterTransformParameter.h:

(CustomFilterTransformParameter):
(WebCore::CustomFilterTransformParameter::blend):

  • platform/graphics/filters/FilterOperation.h:

(WebCore::FilterOperation::FilterOperation::blend):
(FilterOperation):
(WebCore::FilterOperation::FilterOperation::blendingNeedsRendererSize):

  • platform/graphics/transforms/TransformOperations.cpp: Extracted the blending functions from CSSPropertyAnimation.cpp

so that they could be reused from other classes.
(WebCore::TransformOperations::blendByMatchingOperations):
(WebCore):
(WebCore::TransformOperations::blendByUsingMatrixInterpolation): Used when the TransformOperations do not match.
(WebCore::TransformOperations::blend): Uses when the caller doesn't know whether the TransformOperations match or not.

  • platform/graphics/transforms/TransformOperations.h:

(TransformOperations):

LayoutTests:

Added test transform animations in css3/filters/custom/custom-filter-transform-animation.html.

  • animations/resources/animation-test-helpers.js:

(customFilterParameterMatch): Extracted the parameter matching from filterParametersMatch and added function parameters matching.
This should work for all functions that have number parameters, ie. arrays, mat4 functions.

(filterParametersMatch):

  • css3/filters/custom/custom-filter-transforms-animation-expected.txt: Added.
  • css3/filters/custom/custom-filter-transforms-animation.html: Added.
  • css3/filters/resources/custom-filter-parser.js: Fixed function parsing.

(TokenStream.prototype.skip):

4:20 PM Changeset in webkit [128379] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebCore

IndexedDB: Use ScriptValue instead of SerializedScriptValue when possible
https://bugs.webkit.org/show_bug.cgi?id=94023

Patch by Alec Flett <alecflett@chromium.org> on 2012-09-12
Reviewed by Kentaro Hara.

Transition the put/add/update methods to accept direct ScriptValue
objects rather than SerializedScriptValues, to eliminate lots of
redundant deserialization/serialization steps while storing
values.

Also see https://bugs.webkit.org/show_bug.cgi?id=95409 for
followup get/openCursor work, following this.

No new tests, this is a performance refactor of core IDB
functionality. Most existing tests cover correctness. Tests that
might fail include:

storage/indexeddb/objectstore-basics.html
storage/indexeddb/keypath-basics.html
storage/indexeddb/index-basics.html

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::update):

  • Modules/indexeddb/IDBCursor.h:

(IDBCursor):

  • Modules/indexeddb/IDBCursor.idl:
  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::generateIndexKeysForValue):
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(WebCore):

  • Modules/indexeddb/IDBObjectStore.h:

(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(IDBObjectStore):

  • Modules/indexeddb/IDBObjectStore.idl:
  • bindings/v8/IDBBindingUtilities.cpp:

(WebCore):
(WebCore::createIDBKeyFromScriptValueAndKeyPath):
(WebCore::deserializeIDBValue):
(WebCore::canInjectIDBKeyIntoScriptValue):

  • bindings/v8/IDBBindingUtilities.h:

(WebCore):

4:17 PM Changeset in webkit [128378] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

[chromium] Remove unused WebGestureEvent fields
https://bugs.webkit.org/show_bug.cgi?id=95496

Patch by Rick Byers <rbyers@chromium.org> on 2012-09-12
Reviewed by Adam Barth.

Remove the no-longer used fields from WebGestureEvent, now that
chromium has been updated to use the per-event-type fields instead.
This depends on crrev.com/156346 in chromium.

  • public/WebInputEvent.h:

(WebKit::WebGestureEvent::WebGestureEvent):

  • public/android/WebInputEventFactory.h:
  • src/WebInputEvent.cpp:

(SameSizeAsWebGestureEvent):

  • src/android/WebInputEventFactory.cpp:

(WebKit):
(WebKit::WebInputEventFactory::gestureEvent):

4:11 PM TestExpectations edited by dpranke@chromium.org
more editing, cleanup for the new syntax. (diff)
4:10 PM Changeset in webkit [128377] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r128351.
http://trac.webkit.org/changeset/128351
https://bugs.webkit.org/show_bug.cgi?id=96573

Broke FindInPage browser_tests (Requested by jamesr_ on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-12

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::scopeStringMatches):
(WebKit::WebFrameImpl::cancelPendingScopingEffort):
(WebKit::WebFrameImpl::setFindEndstateFocusAndSelection):
(WebKit::WebFrameImpl::shouldScopeMatches):

3:56 PM Changeset in webkit [128376] by Chris Fleizach
  • 3 edits
    2 adds in trunk

AX: svg:image not accessible
https://bugs.webkit.org/show_bug.cgi?id=96341

Reviewed by Adele Peterson.

Source/WebCore:

Test: accessibility/svg-image.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

LayoutTests:

  • accessibility/svg-image.html: Added.
  • platform/mac/accessibility/svg-image-expected.txt: Added.
3:54 PM Changeset in webkit [128375] by ojan@chromium.org
  • 5 edits
    4 adds in trunk

percentage widths rendered wrong in vertical writing mode with orthogonal parent
https://bugs.webkit.org/show_bug.cgi?id=96308

Reviewed by Tony Chang.

Source/WebCore:

When the containingBlock is in a perpendicular writing-mode, we need to use
it's logicalWidth as the availableHeight for computing percentage values.

Tests: fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks.html

fast/writing-mode/percentage-height-orthogonal-writing-modes.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::availableLogicalHeightUsing):
Added some FIXMEs for perpendicular writing mode cases.

LayoutTests:

  • fast/writing-mode/percentage-height-orthogonal-writing-modes-expected.txt: Added.
  • fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt: Added.
  • fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks.html: Added.
  • fast/writing-mode/percentage-height-orthogonal-writing-modes.html: Added.
3:50 PM TestExpectations edited by dpranke@chromium.org
add docs for the new syntax (diff)
3:43 PM Changeset in webkit [128374] by abarth@webkit.org
  • 7 edits
    3 adds in trunk

[v8] document.getCSSCanvasContext doesn't need to be custom
https://bugs.webkit.org/show_bug.cgi?id=96560

Reviewed by Eric Seidel.

Source/WebCore:

Instead of having a special case for toV8(CanvasRenderingContext*)
inlined into this custom function, we should just make the toV8
function itself custom.

Test: fast/canvas/canvas-css-crazy.html

  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/v8/custom/V8DocumentCustom.cpp:
  • dom/Document.idl:
  • html/canvas/CanvasRenderingContext.idl:

LayoutTests:

Test that document.getCSSCanvasContext returns null for a bogus canvas type.

  • fast/canvas/canvas-css-crazy-expected.txt: Added.
  • fast/canvas/canvas-css-crazy.html: Added.
3:40 PM Changeset in webkit [128373] by eric@webkit.org
  • 3 edits in trunk

HTML parser fails to propertly close 4 identical nested formatting elements
https://bugs.webkit.org/show_bug.cgi?id=96385

Reviewed by Adam Barth.

Add missing Adoption agency step 4.a to fix one of our two outlying Adoption Agency bugs.
This is the same step that Opera was missing (must have been recently added to the spec).

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):

3:36 PM Changeset in webkit [128372] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Source/WebCore: [GTK] Protect RedirectedXCompositeWindow with USE(GLX) when building the clutter AC backend
https://bugs.webkit.org/show_bug.cgi?id=96165

Patch by Siraj Razick <siraj.razick@collabora.co.uk> on 2012-09-12
Reviewed by Martin Robinson.

RedirectedXCompositeWindow.cpp and RedirectedXCompositeWindow.h files requies openGL specific
headers to compile so when we build webkit clutter AC backend these files failed to compile,
This patch protects these two files with USE(GLX) when building webkit with Clutter AC backend.

No new tests since this is a build fix

  • platform/gtk/RedirectedXCompositeWindow.cpp:
  • platform/gtk/RedirectedXCompositeWindow.h:

protects both the files with USE(GLX)

Source/WebKit/gtk: [GTK] Update AcceleratedCompositingContextClutter to match AcceleratedCompositingContext.h API update
https://bugs.webkit.org/show_bug.cgi?id=96165

Patch by Siraj Razick <siraj.razick@collabora.co.uk> on 2012-09-12
Reviewed by Martin Robinson.

Due to the refactoring done in bug #90085 AcceleratedCompositingContext API changed, as a result
AcceleratedCompositingContextClutter doesn't compile anymore. This patch is to update the
AcceleratedCompositingContextClutter implementations to match the API update, and Make webkit
AC backend compile again.

  • WebCoreSupport/AcceleratedCompositingContextClutter.cpp:

(WebKit::AcceleratedCompositingContext::AcceleratedCompositingContext):
(WebKit::AcceleratedCompositingContext::~AcceleratedCompositingContext):
(WebKit::AcceleratedCompositingContext::setRootCompositingLayer):
(WebKit::AcceleratedCompositingContext::setNonCompositedContentsNeedDisplay):
(WebKit::flushAndRenderLayersCallback):
(WebKit::AcceleratedCompositingContext::scheduleLayerFlush):
(WebKit::AcceleratedCompositingContext::flushPendingLayerChanges):
(WebKit::AcceleratedCompositingContext::flushAndRenderLayers):

3:29 PM Changeset in webkit [128371] by ojan@chromium.org
  • 4 edits in trunk/Source/WebCore

RenderBox::computeLogicalClientHeight is incorrectly named
https://bugs.webkit.org/show_bug.cgi?id=94288

Reviewed by Tony Chang.

Just renamed a couple methods to make it more clear what they return.
No behavior changes.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalHeightUsing):
(WebCore::RenderBox::computeContentLogicalHeight):
(WebCore::RenderBox::computeContentAndScrollbarLogicalHeightUsing):
(WebCore::RenderBox::availableLogicalHeightUsing):

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::mainAxisContentExtent):
(WebCore::RenderFlexibleBox::computeMainAxisExtentForChild):
(WebCore::RenderFlexibleBox::computeAvailableFreeSpace):
(WebCore::RenderFlexibleBox::lineBreakLength):

3:22 PM Changeset in webkit [128370] by jsbell@chromium.org
  • 9 edits in trunk

IndexedDB: The |source| property of IDBFactory.open() request should be null
https://bugs.webkit.org/show_bug.cgi?id=96551

Reviewed by Tony Chang.

Source/WebCore:

Per the IDB spec, the source property of the IDBOpenDBRequest returned by IDBFactory.open()
should be set to null. We were setting it to the IDBFactory object instead.

Tests: storage/indexeddb/basics.html

storage/indexeddb/basics-workers.html
storage/indexeddb/mozilla/event-source.html
storage/indexeddb/readonly.html

  • Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::open):

LayoutTests:

Already tested for in several places, so just update expectations/assertions.

  • storage/indexeddb/basics-expected.txt:
  • storage/indexeddb/basics-workers-expected.txt:
  • storage/indexeddb/mozilla/event-source-expected.txt:
  • storage/indexeddb/mozilla/resources/event-source.js: Updated assertion.

(openSuccess):

  • storage/indexeddb/readonly-expected.txt:
  • storage/indexeddb/resources/basics.js: Updated assertion.

(test):
(openCallback):

3:20 PM Changeset in webkit [128369] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Refactor Opcodes to distinguish between core and extension opcodes.
https://bugs.webkit.org/show_bug.cgi?id=96466.

Patch by Mark Lam <mark.lam@apple.com> on 2012-09-12
Reviewed by Filip Pizlo.

  • bytecode/Opcode.h:

(JSC): Added FOR_EACH_CORE_OPCODE_ID() macro.

  • llint/LowLevelInterpreter.h:

(JSC): Auto-generate llint opcode aliases using the

FOR_EACH_CORE_OPCODE_ID() macro.

3:19 PM Changeset in webkit [128368] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Unreviewed, rolling out r128353.
http://trac.webkit.org/changeset/128353
https://bugs.webkit.org/show_bug.cgi?id=96565

Re-land change that broke tests on Chromium. Tests are now
disabled, will rebaseline after this rolls. (Requested by
dmazzoni on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-12

Source/WebCore:

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::canHaveChildren):
(WebCore):
(WebCore::AccessibilityNodeObject::accessibilityIsIgnored):
(WebCore::AccessibilityNodeObject::isWebArea):
(WebCore::AccessibilityNodeObject::isImageButton):
(WebCore::AccessibilityNodeObject::isAnchor):
(WebCore::AccessibilityNodeObject::isNativeTextControl):
(WebCore::AccessibilityNodeObject::isSearchField):
(WebCore::AccessibilityNodeObject::isNativeImage):
(WebCore::AccessibilityNodeObject::isImage):
(WebCore::AccessibilityNodeObject::isPasswordField):
(WebCore::AccessibilityNodeObject::isInputImage):
(WebCore::AccessibilityNodeObject::isProgressIndicator):
(WebCore::AccessibilityNodeObject::isSlider):
(WebCore::AccessibilityNodeObject::isMenuRelated):
(WebCore::AccessibilityNodeObject::isMenu):
(WebCore::AccessibilityNodeObject::isMenuBar):
(WebCore::AccessibilityNodeObject::isMenuButton):
(WebCore::AccessibilityNodeObject::isMenuItem):
(WebCore::AccessibilityNodeObject::isNativeCheckboxOrRadio):
(WebCore::AccessibilityNodeObject::isEnabled):
(WebCore::AccessibilityNodeObject::isIndeterminate):
(WebCore::AccessibilityNodeObject::isPressed):
(WebCore::AccessibilityNodeObject::isChecked):
(WebCore::AccessibilityNodeObject::isHovered):
(WebCore::AccessibilityNodeObject::isMultiSelectable):
(WebCore::AccessibilityNodeObject::isReadOnly):
(WebCore::AccessibilityNodeObject::isRequired):
(WebCore::AccessibilityNodeObject::headingLevel):
(WebCore::AccessibilityNodeObject::valueDescription):
(WebCore::AccessibilityNodeObject::isARIARange):
(WebCore::AccessibilityNodeObject::valueForRange):
(WebCore::AccessibilityNodeObject::maxValueForRange):
(WebCore::AccessibilityNodeObject::minValueForRange):
(WebCore::AccessibilityNodeObject::stepValueForRange):
(WebCore::AccessibilityNodeObject::isHeading):
(WebCore::AccessibilityNodeObject::isLink):
(WebCore::AccessibilityNodeObject::isControl):
(WebCore::AccessibilityNodeObject::isFieldset):
(WebCore::AccessibilityNodeObject::isGroup):
(WebCore::AccessibilityNodeObject::selectedRadioButton):
(WebCore::AccessibilityNodeObject::selectedTabItem):
(WebCore::AccessibilityNodeObject::checkboxOrRadioValue):
(WebCore::AccessibilityNodeObject::anchorElement):
(WebCore::AccessibilityNodeObject::actionElement):
(WebCore::AccessibilityNodeObject::mouseButtonListener):
(WebCore::AccessibilityNodeObject::isDescendantOfBarrenParent):
(WebCore::AccessibilityNodeObject::alterSliderValue):
(WebCore::AccessibilityNodeObject::increment):
(WebCore::AccessibilityNodeObject::decrement):
(WebCore::AccessibilityNodeObject::changeValueByStep):
(WebCore::AccessibilityNodeObject::changeValueByPercent):
(WebCore::AccessibilityNodeObject::isGenericFocusableElement):
(WebCore::AccessibilityNodeObject::labelForElement):
(WebCore::AccessibilityNodeObject::ariaAccessibilityDescription):
(WebCore::siblingWithAriaRole):
(WebCore::AccessibilityNodeObject::menuElementForMenuButton):
(WebCore::AccessibilityNodeObject::menuForMenuButton):
(WebCore::AccessibilityNodeObject::menuItemElementForMenu):
(WebCore::AccessibilityNodeObject::menuButtonForMenu):
(WebCore::AccessibilityNodeObject::accessibilityDescription):
(WebCore::AccessibilityNodeObject::helpText):
(WebCore::AccessibilityNodeObject::hierarchicalLevel):
(WebCore::AccessibilityNodeObject::textUnderElement):
(WebCore::AccessibilityNodeObject::title):
(WebCore::AccessibilityNodeObject::text):
(WebCore::AccessibilityNodeObject::stringValue):
(WebCore::accessibleNameForNode):
(WebCore::AccessibilityNodeObject::accessibilityDescriptionForElements):
(WebCore::AccessibilityNodeObject::elementsFromAttribute):
(WebCore::AccessibilityNodeObject::ariaLabeledByElements):
(WebCore::AccessibilityNodeObject::ariaLabeledByAttribute):
(WebCore::AccessibilityNodeObject::canSetFocusAttribute):

  • accessibility/AccessibilityNodeObject.h:

(AccessibilityNodeObject):
(WebCore::AccessibilityNodeObject::node):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::parentObject):
(WebCore::AccessibilityRenderObject::isReadOnly):
(WebCore::AccessibilityRenderObject::helpText):
(WebCore::AccessibilityRenderObject::accessibilityDescription):
(WebCore::AccessibilityRenderObject::text):
(WebCore::AccessibilityRenderObject::contentChanged):
(WebCore):
(WebCore::AccessibilityRenderObject::canHaveChildren):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

LayoutTests:

  • accessibility/canvas-fallback-content-2-expected.txt: Added.
  • accessibility/canvas-fallback-content-2.html: Added.
3:13 PM Changeset in webkit [128367] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] We attempt to rebase documentation even if it's not present
https://bugs.webkit.org/show_bug.cgi?id=96553

Patch by Xan Lopez <xlopez@igalia.com> on 2012-09-12
Reviewed by Martin Robinson.

Do not make the documentation rebase step fatal. This allows make
install to succeed when there's no documentation generated.

  • gtk/generate-gtkdoc:
3:12 PM Changeset in webkit [128366] by ojan@chromium.org
  • 3 edits in trunk/LayoutTests

Update some stale expectations.

  • platform/chromium/TestExpectations:

Update to match what the bots are actually seeing.

  • platform/gtk/TestExpectations:

Remove tests that no longer exist.

2:58 PM Changeset in webkit [128365] by Stephanie Lewis
  • 2 edits in trunk/LayoutTests

fast/events/dispatch-message-string-data.html fails on mac wk2
https://bugs.webkit.org/show_bug.cgi?id=96552

Unreviewed.

Add to TestExpectations.

  • platform/mac-wk2/TestExpectations:
2:49 PM Changeset in webkit [128364] by kenneth@webkit.org
  • 2 edits in trunk/Tools

Respect WEBKITOUTPUTDIR when running EFL tests
https://bugs.webkit.org/show_bug.cgi?id=96528

Reviewed by Dirk Pranke.

Expose user set WEBKITOUTPUTDIR to the web process.

  • Scripts/webkitpy/layout_tests/port/driver.py:

(Driver._start): Add WEBKITOUTPUTDIR to the environment
of the web process and its potential jhbuild wrapper.

2:40 PM Changeset in webkit [128363] by msaboff@apple.com
  • 4 edits in trunk/Source

Element::classAttributeChanged should use characters8/16 to find first non-whitespace
https://bugs.webkit.org/show_bug.cgi?id=96446

Reviewed by Benjamin Poulain.

Source/WebCore:

Made two new static templated methods to handle 8 or 16 bit class names.

No functional change, so no new tests.

  • dom/Element.cpp:

(WebCore::classStringHasClassName):
(WebCore::Element::classAttributeChanged):

Source/WTF:

Added bit size related string accessors to AtomicString to support change.

  • wtf/text/AtomicString.h:

(AtomicString):
(WTF::AtomicString::is8Bit):
(WTF::AtomicString::characters8):
(WTF::AtomicString::characters16):

2:37 PM Changeset in webkit [128362] by dpranke@chromium.org
  • 2 edits in trunk/Tools

webkitdirs: fix uname version handling for cygwin
https://bugs.webkit.org/show_bug.cgi?id=96436

Reviewed by Jon Honeycutt.

Newer versions of cygwin embed an additional version string
inside parentheses, so you get "1.7.16(0.249/5/3)" instead of "1.7.16".
Update the code to handle that.

  • Scripts/webkitdirs.pm:

(setupAppleWinEnv):

2:36 PM Changeset in webkit [128361] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

[V8] V8DOMWrapper::constructorForType is unnecessary now that we can get V8PerContextData from the v8::Context
https://bugs.webkit.org/show_bug.cgi?id=96556

Patch by Adam Barth <abarth@chromium.org> on 2012-09-12
Reviewed by Eric Seidel.

These functions no longer serve a purpose now that we can get the
V8PerContextData directly from the context. Previously we had to find
the Frame in order to find the per-context data.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateConstructorGetter):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::installDOMWindow):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::instantiateV8Object):

  • bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):

  • bindings/v8/V8PerContextData.cpp:

(WebCore::V8PerContextData::from):

  • bindings/v8/V8PerContextData.h:

(V8PerContextData):

  • Changed this function to accept an arbitrary context rather than requiring the caller to use the current context.
2:33 PM Changeset in webkit [128360] by leviw@chromium.org
  • 3 edits in trunk/LayoutTests

More unreviewed gardening after r128346.

  • platform/chromium-win-xp/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
2:21 PM Changeset in webkit [128359] by eric@webkit.org
  • 4 edits
    2 adds in trunk/LayoutTests

Sync html5lib tests with latest sources (and sort the tests alphabetically in runner.html)
https://bugs.webkit.org/show_bug.cgi?id=96544

Reviewed by Adam Barth.

  • html5lib/resources/adoption01.dat:
  • html5lib/resources/domjs-unsafe.dat: Added.
  • html5lib/resources/scripted/ark.dat: Added.
  • html5lib/runner.html:
2:04 PM Changeset in webkit [128358] by enne@google.com
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Fix search tickmarks not disappearing when compositing is enabled
https://bugs.webkit.org/show_bug.cgi?id=96536

Reviewed by James Robinson.

view->invalidateRect() on the root frame just invalidates the
contents, since WebViewImpl doesn't know anything about scrollbar
layers. This causes an "InvalidateAll" to not actually invalidate the
scrollbars.

To fix this, make WebFrameImpl explicitly invalidate the
scrollbars when required.

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::invalidateArea):

1:57 PM Changeset in webkit [128357] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Widen CRASH expectations for fast/replaced/border-radius-clip.html

Unreviewed gardening.

  • platform/chromium/TestExpectations:
1:40 PM Changeset in webkit [128356] by leviw@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed gardening. Updated test expectations following r128346.

  • platform/chromium-linux/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
1:35 PM Changeset in webkit [128355] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

Mark seek-to-end-after-duration-change.html as flaky.

  • platform/chromium/TestExpectations:
1:33 PM Changeset in webkit [128354] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

Mark some new hidpi tests as failing after r128348.

  • platform/chromium/TestExpectations:
1:13 PM Changeset in webkit [128353] by commit-queue@webkit.org
  • 6 edits
    2 deletes in trunk

Unreviewed, rolling out r128318 and r128332.
http://trac.webkit.org/changeset/128318
http://trac.webkit.org/changeset/128332
https://bugs.webkit.org/show_bug.cgi?id=96547

Caused accessibility test failures on snow leopard (Requested
by jamesr_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-12

Source/WebCore:

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::accessibilityIsIgnored):
(WebCore::AccessibilityNodeObject::canSetFocusAttribute):

  • accessibility/AccessibilityNodeObject.h:

(AccessibilityNodeObject):
(WebCore::AccessibilityNodeObject::node):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore):
(WebCore::AccessibilityRenderObject::isWebArea):
(WebCore::AccessibilityRenderObject::isImageButton):
(WebCore::AccessibilityRenderObject::isAnchor):
(WebCore::AccessibilityRenderObject::isNativeTextControl):
(WebCore::AccessibilityRenderObject::isSearchField):
(WebCore::AccessibilityRenderObject::isNativeImage):
(WebCore::AccessibilityRenderObject::isImage):
(WebCore::AccessibilityRenderObject::isPasswordField):
(WebCore::AccessibilityRenderObject::isInputImage):
(WebCore::AccessibilityRenderObject::isProgressIndicator):
(WebCore::AccessibilityRenderObject::isSlider):
(WebCore::AccessibilityRenderObject::isMenuRelated):
(WebCore::AccessibilityRenderObject::isMenu):
(WebCore::AccessibilityRenderObject::isMenuBar):
(WebCore::AccessibilityRenderObject::isMenuButton):
(WebCore::AccessibilityRenderObject::isMenuItem):
(WebCore::AccessibilityRenderObject::isPressed):
(WebCore::AccessibilityRenderObject::isIndeterminate):
(WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio):
(WebCore::AccessibilityRenderObject::isChecked):
(WebCore::AccessibilityRenderObject::isHovered):
(WebCore::AccessibilityRenderObject::isMultiSelectable):
(WebCore::AccessibilityRenderObject::isReadOnly):
(WebCore::AccessibilityRenderObject::headingLevel):
(WebCore::AccessibilityRenderObject::isHeading):
(WebCore::AccessibilityRenderObject::isLink):
(WebCore::AccessibilityRenderObject::isControl):
(WebCore::AccessibilityRenderObject::isFieldset):
(WebCore::AccessibilityRenderObject::isGroup):
(WebCore::AccessibilityRenderObject::selectedRadioButton):
(WebCore::AccessibilityRenderObject::selectedTabItem):
(WebCore::AccessibilityRenderObject::actionElement):
(WebCore::AccessibilityRenderObject::mouseButtonListener):
(WebCore::AccessibilityRenderObject::alterSliderValue):
(WebCore::AccessibilityRenderObject::increment):
(WebCore::AccessibilityRenderObject::decrement):
(WebCore::siblingWithAriaRole):
(WebCore::AccessibilityRenderObject::menuElementForMenuButton):
(WebCore::AccessibilityRenderObject::menuForMenuButton):
(WebCore::AccessibilityRenderObject::menuItemElementForMenu):
(WebCore::AccessibilityRenderObject::menuButtonForMenu):
(WebCore::AccessibilityRenderObject::hierarchicalLevel):
(WebCore::AccessibilityRenderObject::checkboxOrRadioValue):
(WebCore::AccessibilityRenderObject::valueDescription):
(WebCore::AccessibilityRenderObject::stepValueForRange):
(WebCore::AccessibilityRenderObject::isARIARange):
(WebCore::AccessibilityRenderObject::valueForRange):
(WebCore::AccessibilityRenderObject::maxValueForRange):
(WebCore::AccessibilityRenderObject::minValueForRange):
(WebCore::accessibleNameForNode):
(WebCore::AccessibilityRenderObject::accessibilityDescriptionForElements):
(WebCore::AccessibilityRenderObject::elementsFromAttribute):
(WebCore::AccessibilityRenderObject::ariaLabeledByElements):
(WebCore::AccessibilityRenderObject::ariaLabeledByAttribute):
(WebCore::labelForElement):
(WebCore::AccessibilityRenderObject::title):
(WebCore::AccessibilityRenderObject::ariaAccessibilityDescription):
(WebCore::AccessibilityRenderObject::accessibilityDescription):
(WebCore::AccessibilityRenderObject::isDescendantOfBarrenParent):
(WebCore::AccessibilityRenderObject::text):
(WebCore::AccessibilityRenderObject::isRequired):
(WebCore::AccessibilityRenderObject::changeValueByStep):
(WebCore::AccessibilityRenderObject::changeValueByPercent):
(WebCore::AccessibilityRenderObject::isEnabled):
(WebCore::AccessibilityRenderObject::isGenericFocusableElement):
(WebCore::AccessibilityRenderObject::canHaveChildren):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

LayoutTests:

  • accessibility/canvas-fallback-content-2-expected.txt: Removed.
  • accessibility/canvas-fallback-content-2.html: Removed.
1:05 PM Changeset in webkit [128352] by ap@apple.com
  • 5 edits in trunk/Source/WebKit2

<rdar://problem/12275537> REGRESSION(r127384): Non-existent directories are no longer created for sandbox paths
https://bugs.webkit.org/show_bug.cgi?id=96442

Reviewed by Darin Adler.

  • Shared/SandboxExtension.h: (WebKit::SandboxExtension::createHandleForReadWriteDirectory):
  • Shared/mac/SandboxExtensionMac.mm: (WebKit::SandboxExtension::createHandleForReadWriteDirectory): Added a function for read-write configuration directories. It matches appendReadwriteSandboxDirectory() function behavior from WebProcessMac.mm.
  • UIProcess/WebContext.cpp: (WebKit::WebContext::createNewWebProcess):
  • UIProcess/mac/WebContextMac.mm: (WebKit::WebContext::platformInitializeWebProcess): Use the new function for directories that need to be created if they don't exist.
1:02 PM Changeset in webkit [128351] by leandrogracia@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Fix cases where find-in-page doesn't send a final update
https://bugs.webkit.org/show_bug.cgi?id=96402

Fix some issues in the WebKit implementation that prevented to send a final
reportFindInPageMatchCount message. Also, fix a buggy reset of the active match
when calling the stopFinding method.

Reviewed by Adam Barth.

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::scopeStringMatches):
(WebKit::WebFrameImpl::cancelPendingScopingEffort):
(WebKit::WebFrameImpl::setFindEndstateFocusAndSelection):
(WebKit::WebFrameImpl::shouldScopeMatches):

12:41 PM Changeset in webkit [128350] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Compilation error in RenderThemeEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=96540

Unreviewed build fix.

Fix compilation error in RenderThemeEfl.cpp when building
in debug mode.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-12

  • platform/efl/RenderThemeEfl.h:

(WebCore::RenderThemeEfl::canvas):
(WebCore::RenderThemeEfl::edje):

12:41 PM WebKit Team edited by dinu.s.jacob@intel.com
Adding myself to committers list (diff)
12:25 PM Changeset in webkit [128349] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Regression(r128338): Broke Windows build
https://bugs.webkit.org/show_bug.cgi?id=96537

Unreviewed build fix.

Fix Apple-Win build by allocating array dynamically
since its size is not constant.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-12

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::stringArrayToJS):

12:23 PM Changeset in webkit [128348] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

[chromium] Add a virtual test suite for fast/hidpi
https://bugs.webkit.org/show_bug.cgi?id=90192

Patch by Alex Sakhartchouk <alexst@chromium.org> on 2012-09-12
Reviewed by Dirk Pranke.

Tools:

Add a virtual test suite to make sure the pixel tests in fast/hidpi give the same result
on the hardware accelerated path as the software path.

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::applyTo):

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.virtual_test_suites):

LayoutTests:

Making sure the new virtual tests have matching expectations to non-gpu ones

  • platform/chromium/TestExpectations:
  • platform/chromium/virtual/gpu/fast/hidpi/README.txt: Added.
12:21 PM Changeset in webkit [128347] by commit-queue@webkit.org
  • 19 edits in trunk

Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING
https://bugs.webkit.org/show_bug.cgi?id=96251

Patch by Sami Kyostila <skyostil@google.com> on 2012-09-12
Reviewed by Simon Fraser.

Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING to better describe
the feature it controls.

.:

  • Source/cmakeconfig.h.cmake:

Source/WebCore:

No tests because of no change in runtime behavior.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSValueKeywords.in:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::usesCompositedScrolling):

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h:

(StyleRareInheritedData):

Source/WebKit/blackberry:

  • WebCoreSupport/AboutDataEnableFeatures.in:

Source/WebKit/chromium:

  • features.gypi:

LayoutTests:

  • platform/chromium/TestExpectations:
12:17 PM Changeset in webkit [128346] by leviw@chromium.org
  • 19 edits
    3 adds in trunk

Inline repainting can be off-by-one with sub-pixel enabled
https://bugs.webkit.org/show_bug.cgi?id=95882

Reviewed by Eric Seidel.

Source/WebCore:

With sub-pixel layout enabled, context accumulated from containing renderers is used to properly
pixel snap. Selection repaint rects are stored outside the affected renderers, and are handed to
the embedder without the context to correctly determine the snapped values. This can result in
repaint areas smaller than what's needed.

This could be fixed three ways:

  • by changing selection repaint rects to an IntRect and pixel snapping the values before storing them outside the render tree. This is the narrowest solution.
  • by adapting layout to store pixel snapping hints along with the size/location of the renderer. This is the best possible solution, as it would help solve a lot of pixel snapping issues and reduce complexity of handling. I eventually intend on implementing this.
  • by reverting repaintUsingContainer to IntRects and using pixel snapping when possible, and enclosingIntRect where we lack context.

This implements the last solution, as it's the least invasive, but can potentially fix numerous
sub-pixel repaint issues.

Test: fast/sub-pixel/selection/selection-rect-in-sub-pixel-table.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutRunsAndFloats):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::repaintIncludingNonCompositingDescendants):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::repaintUsingContainer):
(WebCore::RenderObject::repaint):
(WebCore::RenderObject::repaintRectangle):
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):

  • rendering/RenderObject.h:

(RenderObject):

  • rendering/RenderSelectionInfo.h:

(WebCore::RenderSelectionInfo::repaint):
(WebCore::RenderBlockSelectionInfo::repaint):

LayoutTests:

Test that we properly repaint selection gaps inside tables with sub-pixel offsets.

  • fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt: Added.
  • fast/sub-pixel/selection/selection-rect-in-sub-pixel-table.html: Added.
  • platform/chromium-mac/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.png: Added.
  • platform/chromium/TestExpectations:
  • platform/mac-lion/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/mac/Skipped:
  • platform/qt-4.8/Skipped:
  • platform/qt/Skipped:
  • platform/win-wk2/Skipped:
  • platform/win-xp/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
12:02 PM Changeset in webkit [128345] by msaboff@apple.com
  • 2 edits in trunk/Source/WebCore

Build fixed for http://trac.webkit.org/changeset/128243

Unreviewed build fix.

Change UnicodeString::extract for gcc based on ICU fix described in
http://bugs.icu-project.org/trac/ticket/8197.

  • icu/unicode/unistr.h:

(UnicodeString::extract):

11:49 AM Changeset in webkit [128344] by commit-queue@webkit.org
  • 13 edits in trunk/Source

[chromium] Evict textures through the texture manager instead of the resource provider
https://bugs.webkit.org/show_bug.cgi?id=96463

Patch by Christopher Cameron <ccameron@chromium.org> on 2012-09-12
Reviewed by James Robinson.

Source/WebCore:

When deleting contents textures' resources on the impl thread, do the
deletion through the CCPrioritizedTextureManager instead of the
CCResourceProvider.

This requires traversing the backings list on the impl thread while
the main thread is running, so remove the one remaining traversal of
the backings list by the main thread. This traversal happens when
unlinking textures that were evicted by the impl thread, so explicitly
send the list of evicted backings from the impl thread to the main thread.

Unify all resource deletion paths in the CCPrioritizedTextureManager.
Always perform the sequence of eviction (deleting the GL resource) and
then destruction of evicted backings (deleting the objects). Also,
use the same function (evictBackingsToReduceMemory) to reduce memory
consumption both during commit and when done by the impl thread in response
to a request by the GPU memory manager.

Note that destroying only some of the resources at a time during texture
eviction (as opposed all resources) is still not supported because the
texture upload queues cannot be only-partially invalidated yet.

Updated tests to take this behavior into account.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::reduceContentsTexturesMemoryOnImplThread):
(WebCore):
(WebCore::CCLayerTreeHost::getEvictedContentTexturesBackings):
(WebCore::CCLayerTreeHost::unlinkEvictedContentTexturesBackings):
(WebCore::CCLayerTreeHost::deleteEvictedContentTexturesBackings):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::releaseContentsTextures):
(WebCore::CCLayerTreeHostImpl::setContentsTexturesPurged):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImplClient):
(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCPrioritizedTextureManager.cpp:

(WebCore::CCPrioritizedTextureManager::~CCPrioritizedTextureManager):
(WebCore::CCPrioritizedTextureManager::acquireBackingTextureIfNeeded):
(WebCore::CCPrioritizedTextureManager::evictBackingsToReduceMemory):
(WebCore::CCPrioritizedTextureManager::reduceMemory):
(WebCore::CCPrioritizedTextureManager::clearAllMemory):
(WebCore::CCPrioritizedTextureManager::reduceMemoryOnImplThread):
(WebCore::CCPrioritizedTextureManager::getEvictedBackings):
(WebCore::CCPrioritizedTextureManager::unlinkEvictedBackings):
(WebCore):
(WebCore::CCPrioritizedTextureManager::deleteEvictedBackings):
(WebCore::CCPrioritizedTextureManager::evictBackingResource):

  • platform/graphics/chromium/cc/CCPrioritizedTextureManager.h:

(CCPrioritizedTextureManager):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::releaseContentsTexturesOnImplThread):
(WebCore):
(WebCore::CCSingleThreadProxy::commitAndComposite):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::releaseContentsTexturesOnImplThread):
(WebCore):
(WebCore::CCThreadProxy::scheduledActionBeginFrame):
(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
(WebCore::CCThreadProxy::layerTreeHostClosedOnImplThread):
(WebCore::CCThreadProxy::recreateContextOnImplThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(BeginFrameAndCommitState):
(CCThreadProxy):

Source/WebKit/chromium:

Update layer tree host impl test to include the extra interface functions
added to CCLayerTreeHostImplClient.

  • tests/CCLayerTreeHostImplTest.cpp:
11:24 AM Changeset in webkit [128343] by adamk@chromium.org
  • 2 edits in trunk/Tools

[chromium] Add content_browsertests to the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=96535

Reviewed by Ojan Vafai.

  • TestResultServer/static-dashboards/dashboard_base.js:
11:23 AM Changeset in webkit [128342] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding crash or other failure expectations for plenty of accessibility
tests as required after r128318.

  • platform/gtk/TestExpectations:
11:23 AM Changeset in webkit [128341] by mifenton@rim.com
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Add custom messages for input type validation.
https://bugs.webkit.org/show_bug.cgi?id=96533

Reviewed by Antonio Gomes.

PR 179148.

Add validation messages for Email, MultipleEmail and Url.

Reviewed Internally by Nima Ghanavatian.

  • platform/blackberry/LocalizedStringsBlackBerry.cpp:

(WebCore::validationMessageTypeMismatchForEmailText):
(WebCore::validationMessageTypeMismatchForMultipleEmailText):
(WebCore::validationMessageTypeMismatchForURLText):

11:11 AM Changeset in webkit [128340] by msaboff@apple.com
  • 2 edits in trunk/Source/WTF

Build fixed for http://trac.webkit.org/changeset/128243

Unreviewed build fix.

Removed temporarily added function signature.

  • icu/unicode/unistr.h:

(UnicodeString::extract):

10:46 AM Changeset in webkit [128339] by msaboff@apple.com
  • 2 edits in trunk/Source/WTF

Build fixed for http://trac.webkit.org/changeset/128243

Unreviewed build fix.

Change UnicodeString::extract for gcc based on ICU fix described in
http://bugs.icu-project.org/trac/ticket/8197.

  • icu/unicode/unistr.h:

(UnicodeString::extract):

10:42 AM Changeset in webkit [128338] by commit-queue@webkit.org
  • 11 edits in trunk

[WK2][WKTR] TestRunner needs to implement originsWithApplicationCache
https://bugs.webkit.org/show_bug.cgi?id=96496

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-12
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add Bundle C API to retrieve security origins with
an application cache. This is needed by WebKitTestRunner
to support originsWithApplicationCache.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleCopyOriginsWithApplicationCache):

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::originsWithApplicationCache):
(WebKit):

  • WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

Tools:

Add implementation for originsWithApplicationCache to
WebKitTestRunner.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::stringArrayToJS):
(WTR):
(WTR::TestRunner::originsWithApplicationCache):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

LayoutTests:

Unskip http/tests/appcache/origins-with-appcache.html now that
WebKitTestRunner implements originsWithApplicationCache.

  • platform/wk2/Skipped:
10:39 AM Changeset in webkit [128337] by pilgrim@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Remove unused notifyFormStateChanged function in PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=96527

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

10:32 AM Changeset in webkit [128336] by commit-queue@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

[CSS Exclusions] Test incremental layout
https://bugs.webkit.org/show_bug.cgi?id=91879

Patch by Bear Travis <betravis@adobe.com> on 2012-09-12
Reviewed by Julien Chaffraix.

Adding tests to make sure that text and shape can be set dynamically, and that
content will still layout while respecting shape-inside.

  • fast/exclusions/shape-inside/shape-inside-dynamic-shape-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-dynamic-shape.html: Added.
  • fast/exclusions/shape-inside/shape-inside-dynamic-text-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-dynamic-text.html: Added.
10:25 AM Changeset in webkit [128335] by mihnea@adobe.com
  • 2 edits in trunk/Source/WebCore

[CSSRegions]Shrink RenderFlowThread size by using bit flags
https://bugs.webkit.org/show_bug.cgi?id=96503

Reviewed by Andreas Kling.

Use bit fields instead of full bool.

No new functionality, just refactoring. Functionality covered by existing tests in fast/regions.

  • rendering/RenderFlowThread.h:
10:23 AM Changeset in webkit [128334] by commit-queue@webkit.org
  • 9 edits
    8 adds in trunk

[CSS Shaders] Remove direct texture access via u_texture
https://bugs.webkit.org/show_bug.cgi?id=93871

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-09-12
Reviewed by Dean Jackson.

Source/WebCore:

Remove the author-accessible "u_texture" sampler, which referenced the DOM element texture.

Additionally, reject shaders with author-defined sampler uniforms. When we implement texture
parameters, we will allow shaders whose samplers are bound to valid textures. We must not
allow OpenGL to give unbound samplers a default value of 0 because that references the DOM
element texture, which should be inaccessible to the author's shader code.

Test: css3/filters/custom/custom-filter-no-element-texture-access.html

  • platform/graphics/ANGLEWebKitBridge.cpp:

(WebCore::getValidationResultValue):

Add a file-static function to easily query the integer values that ANGLE exposes about
the last validation result. The new getUniforms method and the existing
validateShaderSource method now both use getValidationResultValue.

(WebCore):
(WebCore::ANGLEWebKitBridge::validateShaderSource):

Use the new getValidationResultValue function instead of ANGLE's ShGetInfo function.

(WebCore::ANGLEWebKitBridge::getUniforms):

Add a new public method to ANGLEWebKitBridge which gets the info about all of the
uniforms in the last validated vertex shader or fragment shader. Uniform info includes
name, type, and size.

  • platform/graphics/ANGLEWebKitBridge.h:

(ANGLEShaderSymbol):
(WebCore::ANGLEShaderSymbol::isSampler):

Returns true if the symbol's data type is a GLSL sampler (e.g. sampler2D, samplerCube).

(WebCore):
(ANGLEWebKitBridge):

  • platform/graphics/filters/CustomFilterCompiledProgram.cpp:

(WebCore::CustomFilterCompiledProgram::CustomFilterCompiledProgram):

Take in an additional programType constructor parameter.

(WebCore::CustomFilterCompiledProgram::initializeParameterLocations):

Remove the author-accessible DOM element texture sampler "u_texture". Only find the
location of the internal DOM element texture sampler "css_u_texture" if the author is
using the CSS mix function.

  • platform/graphics/filters/CustomFilterCompiledProgram.h:
  • platform/graphics/filters/CustomFilterProgramInfo.h:

(CustomFilterProgramInfo):
(WebCore::CustomFilterProgramInfo::programType):

Add the new CustomFilterProgramType enum. In CustomFilterProgramInfo, we plan to replace
mixSettings.enabled with a programType. See:
https://bugs.webkit.org/show_bug.cgi?id=96448

  • platform/graphics/filters/CustomFilterValidatedProgram.cpp:

Reject all shaders that have sampler uniforms defined.

(WebCore::CustomFilterValidatedProgram::CustomFilterValidatedProgram):
(WebCore::CustomFilterValidatedProgram::compiledProgram):

  • platform/graphics/filters/FECustomFilter.cpp:

(WebCore::FECustomFilter::bindProgramAndBuffers):

Add an assert to verify that the DOM element texture is bound only if the author is
using the CSS mix function.

LayoutTests:

Add tests to verify that the "u_texture" sampler is no longer accessible to author shader
code because it was removed. These tests also verify that shaders with unbound samplers do
not execute.

Add tests to verify that the internal "css_u_texture" sampler is not accessible to author
shader code. These tests check that this is true whether or not the author is using the CSS
mix function and whether or not the author attempts to define css_u_texture is his or her
shader.

  • css3/filters/custom/custom-filter-no-element-texture-access-expected.html: Added.
  • css3/filters/custom/custom-filter-no-element-texture-access.html: Added.
  • css3/filters/resources/sample-defined-css-u-texture-mix.fs: Added.
  • css3/filters/resources/sample-defined-css-u-texture.fs: Added.
  • css3/filters/resources/sample-u-texture-mix.fs: Added.
  • css3/filters/resources/sample-u-texture.fs: Added.
  • css3/filters/resources/sample-undefined-css-u-texture-mix.fs: Added.
  • css3/filters/resources/sample-undefined-css-u-texture.fs: Added.
10:20 AM Changeset in webkit [128333] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Fix Qt/Windows build with Python3
https://bugs.webkit.org/show_bug.cgi?id=96473

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-09-12
Reviewed by Csaba Osztrogonác.

In Python 3 print is a real function, so we must use parentheses around
the function parameters. This is backwards compatible with Python 2.

  • Scripts/generate-win32-export-forwards:
9:57 AM Changeset in webkit [128332] by dmazzoni@google.com
  • 2 edits in trunk/Source/WebCore

Assert hit in is multiSelectable()
https://bugs.webkit.org/show_bug.cgi?id=96530

Reviewed by Chris Fleizach.

Fix crash if element isn't a select element.

This bug slipped through in a refactoring change (bug 96323).
Covered by existing tests.

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::isMultiSelectable):

9:54 AM Changeset in webkit [128331] by morrita@google.com
  • 6 edits in trunk/Source/WebCore

[Scoped Style] NodeRareData::m_numberOfScopedHTMLStyleChildren could be replaced with a node flag.
https://bugs.webkit.org/show_bug.cgi?id=96450

Reviewed by Dimitri Glazkov.

This change gets rid of NodeRareData::m_numberOfScopedHTMLStyleChildren
by replacing it with a Node flag called HasScopedHTMLStyleChildFlag.
Instead of tracking the number of certain node, this chagne compute the number
when necessary.

Now we no longer need to hit rareData() for each hasScopedHTMLStyleChild() call.
Note that because such a re-counting occurs only when the scoped <style> elements
leave the tree, the performance impact is negligible.

No new tests. Covered by existing tests.

  • dom/Node.cpp:

(WebCore):

  • dom/Node.h:

(WebCore::Node::hasScopedHTMLStyleChild):
(WebCore::Node::setHasScopedHTMLStyleChild):
(Node):

  • dom/NodeRareData.h:

(WebCore::NodeRareData::NodeRareData):
(NodeRareData):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::isRegisteredAsScoped):
(WebCore):
(WebCore::Node::registerScopedHTMLStyleChild):
(WebCore::Node::unregisterScopedHTMLStyleChild):
(WebCore::Node::numberOfScopedHTMLStyleChildren):
(WebCore::HTMLStyleElement::unregisterWithScopingNode):

  • html/HTMLStyleElement.h:

(HTMLStyleElement):

9:51 AM Changeset in webkit [128330] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.10

Merge r128195 - [GTK] WebKitGtk+ crashes with non-UTF8 HTTP header names
https://bugs.webkit.org/show_bug.cgi?id=96284

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Non UTF-8 characters sent as part of a HTTP header name were
causing crashes as String::fromUTF8() was returning NULL for
them. Use String::fromUTF8WithLatin1Fallback() instead.

Test: http/tests/misc/non-utf8-header-name.php

  • platform/network/soup/ResourceResponseSoup.cpp:

(WebCore::ResourceResponse::updateFromSoupMessage):

LayoutTests:

Added a new test to make sure that WebKitGtk+ does not crash when
a non-UTF8 character is sent as part of a HTTP header name.

  • http/tests/misc/non-utf8-header-name-expected.txt: Added.
  • http/tests/misc/non-utf8-header-name.php: Added.
9:50 AM Changeset in webkit [128329] by Dimitri Glazkov
  • 5 edits in trunk/Source/WebCore

Remove transient state regarding uknown pseudoelements from SelectorChecker.
https://bugs.webkit.org/show_bug.cgi?id=96425

Reviewed by Eric Seidel.

The fact that an unknown pseudoelement was found when checking selector was stored as extra state on SelectorChecker. That's bad,
because this state is at odds with the lifecycle of the instance and had to be explicitly reset prior to each checking. To address
this, I made checkSelector report the value as its result (by-ref parameter, actually).

No new tests, refactoring only. Covered by existing tests.

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::SelectorChecker): Removed the now-unneded state initialization.
(WebCore::SelectorChecker::checkSelector): Changed to take extra parameter.
(WebCore):
(WebCore::SelectorChecker::checkOneSelector): Ditto.

  • css/SelectorChecker.h:

(SelectorChecker): Changed decls accordingly.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver): Added state to StyleResolver.
(WebCore::StyleResolver::collectMatchingRulesForList): Changed to use own state, rather than StyleChecker's state.

  • css/StyleResolver.h:

(StyleResolver): Moved state here from StyleChecker.

9:50 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
9:43 AM Changeset in webkit [128328] by Simon Hausmann
  • 2 edits in trunk/Tools

Unreviewed trivial build fix for Qt/Windows

As pointed out by Kevin, we should inject the "set PATH=..." statement
to add the GnuWin32 directory only if that directory actually exists.

  • qmake/mkspecs/features/default_post.prf:
9:41 AM Changeset in webkit [128327] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] [WK2] Memory leaks in TestControllerEfl
https://bugs.webkit.org/show_bug.cgi?id=96525

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-12
Reviewed by Kenneth Rohde Christiansen.

Fix memory leaks in EFL's TestRunner code by adopting an allocation
of WKString created with WKStringCreateWithUTF8CString().

  • WebKitTestRunner/efl/TestControllerEfl.cpp:

(WTR::TestController::initializeInjectedBundlePath):
(WTR::TestController::initializeTestPluginDirectory):

9:38 AM Changeset in webkit [128326] by commit-queue@webkit.org
  • 23 edits in trunk

[WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
https://bugs.webkit.org/show_bug.cgi?id=96374

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-12
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add Bundle C API to reset the application cache quota
for a given origin.

Add new reachedApplicationCacheOriginQuota callback
to WKBundlePageUIClient which is called from
WebChromeClient::reachedApplicationCacheOriginQuota().

Those are needed by WebKitTestRunner to dump
information about the application cache callbacks
if instructed to.

  • Shared/APIClientTraits.cpp:

(WebKit):

  • Shared/APIClientTraits.h:
  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetApplicationCacheOriginQuota):
(WKBundleResetApplicationCacheOriginQuota):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::resetApplicationCacheOriginQuota):
(WebKit):

  • WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::didReachApplicationCacheOriginQuota):
(WebKit):

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:

(WebKit):
(InjectedBundlePageUIClient):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::reachedApplicationCacheOriginQuota):

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

Tools:

Implement support for dumpApplicationCacheDelegateCallbacks
and disallowIncreaseForApplicationCacheQuota in
WebKitTestRunner and properly dump the information
expected by the tests.

If the application cache quota is reached for a given
security origin, WebKitTestRunner will reset the quota
to its default value, unless intructed not to via
disallowIncreaseForApplicationCacheQuota().

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
(WTR):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

(InjectedBundlePage):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::TestRunner):
(WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
(WTR):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
(TestRunner):
(WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
(WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):

LayoutTests:

Unskip test cases that are passing now that WebKitTestRunner
implements dumpApplicationCacheDelegateCallbacks and
disallowIncreaseForApplicationCacheQuota.

  • platform/efl-wk1/TestExpectations:
  • platform/efl/Skipped:
  • platform/wk2/Skipped:
9:30 AM Changeset in webkit [128325] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

[CSSRegions]Use RefPtr's instead of weak references on DOMNamedFlowCollection
https://bugs.webkit.org/show_bug.cgi?id=95311

Patch by Andrei Onea <onea@adobe.com> on 2012-09-12
Reviewed by Andreas Kling.

Source/WebCore:

Currently, DOMNamedFlowCollection holds a collection of raw pointers to WebKitNamedFlow.
This causes a crash when there is a JS instance of a NamedFlowCollection snapshot taken
before the NamedFlow is deleted, since the memory previously occupied by the NamedFlow
can be accessed. Because of this, we need to use RefPtr's for the snapshot, so that such
dangling references extend the lifetime of the NamedFlow objects.

Test: fast/regions/webkit-named-flow-collection-crash.html

  • dom/DOMNamedFlowCollection.cpp:

(WebCore::DOMNamedFlowCollection::DOMNamedFlowCollection):
(WebCore::DOMNamedFlowCollection::item):
(WebCore::DOMNamedFlowCollection::namedItem):
(WebCore):
(WebCore::DOMNamedFlowCollection::DOMNamedFlowHashFunctions::hash):
(WebCore::DOMNamedFlowCollection::DOMNamedFlowHashFunctions::equal):
(DOMNamedFlowCollection::DOMNamedFlowHashFunctions):
(WebCore::DOMNamedFlowCollection::DOMNamedFlowHashTranslator::hash):
(WebCore::DOMNamedFlowCollection::DOMNamedFlowHashTranslator::equal):
Create new internal ListHashSet for RefPtr<WebKitNamedFlow>.

  • dom/DOMNamedFlowCollection.h:

(WebCore::DOMNamedFlowCollection::create):
(DOMNamedFlowCollection):

  • dom/NamedFlowCollection.cpp:

(WebCore::NamedFlowCollection::createCSSOMSnapshot):
(WebCore):
(WebCore::NamedFlowCollection::NamedFlowHashFunctions::hash):
(WebCore::NamedFlowCollection::NamedFlowHashFunctions::equal):
(NamedFlowCollection::NamedFlowHashFunctions):
(WebCore::NamedFlowCollection::NamedFlowHashTranslator::hash):
(WebCore::NamedFlowCollection::NamedFlowHashTranslator::equal):
Move back the definitions for NamedFlowHashFunctions and NamedFlowHashTranslator
to the .cpp file.

  • dom/NamedFlowCollection.h:

(NamedFlowCollection):

LayoutTests:

Added test for crash which occurs when there is a raw pointer to a NamedFlow
(in a NamedFlowCollection) which has been freed.

  • fast/regions/webkit-named-flow-collection-crash-expected.txt: Added.
  • fast/regions/webkit-named-flow-collection-crash.html: Added.
9:25 AM Changeset in webkit [128324] by jochen@chromium.org
  • 2 edits in trunk/Tools

[chromium] remove deprecated and unused sets import from chromium_android driver
https://bugs.webkit.org/show_bug.cgi?id=96485

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:
9:16 AM Changeset in webkit [128323] by morrita@google.com
  • 13 edits in trunk

[Shadow DOM] Unpolished elements should reject author shadows
https://bugs.webkit.org/show_bug.cgi?id=96404

Reviewed by Dimitri Glazkov.

Source/WebCore:

Gave areAuthorShadowsAllowed() overrides for these replaced elements
which aren't author shadow ready.

No new tests. Covered by existing tests.

  • html/HTMLCanvasElement.h: Did areAuthorShadowsAllowed() overrride.
  • html/HTMLFieldSetElement.h: Did areAuthorShadowsAllowed() overrride.
  • html/HTMLFrameElementBase.h: Did areAuthorShadowsAllowed() overrride.
  • html/HTMLMediaElement.h: Did areAuthorShadowsAllowed() overrride.
  • html/HTMLPlugInElement.h: Did areAuthorShadowsAllowed() overrride.
  • html/HTMLSelectElement.h: Did areAuthorShadowsAllowed() overrride.

LayoutTests:

  • Added setAuthorShadowDOMForAnyElementEnabled() calls to make tests works.
  • UPdated shadow-disable.html to capture the disabled elements.
  • fast/dom/shadow/shadow-disable-expected.txt:
  • fast/dom/shadow/shadow-disable.html:
  • fast/dom/shadow/shadowdom-for-fieldset-without-shadow.html:
  • fast/dom/shadow/shadowdom-for-form-associated-element-useragent.html:
  • fast/dom/shadow/shadowdom-for-media.html:
  • platform/chromium/TestExpectations:
9:11 AM Changeset in webkit [128322] by pilgrim@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Remove unused allowScriptDespiteSettings function from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=96526

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

9:06 AM Changeset in webkit [128321] by zandobersek@gmail.com
  • 3 edits in trunk/Tools

Flakiness dashboard doesn't recognize new Chromium Android test builder
https://bugs.webkit.org/show_bug.cgi?id=96523

Reviewed by Ojan Vafai.

Properly return 'ANDROID' as the Chromium platform for Android builders.

  • TestResultServer/static-dashboards/flakiness_dashboard.js:

(chromiumPlatform):

  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

(test):

9:03 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
9:03 AM Changeset in webkit [128320] by Carlos Garcia Campos
  • 5 edits in releases/WebKitGTK/webkit-1.10/Source/WebCore

Merge r128298 - [GStreamer] Audio device not closed after playing sound
https://bugs.webkit.org/show_bug.cgi?id=89122

Reviewed by Martin Robinson.

Set the GStreamer pipeline to NULL instead of PAUSED on EOS. This
allows the audio-sink to release its connection to the audio
device. This is done only if the Media element is not
looping. To make the MediaPlayerPrivate layer aware of that
information the MediaPlayerClient interface was updated with a new
method mediaPlayerIsLooping, implemented by the HTMLMediaElement.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerIsLooping): Implementation of
MediaPlayerClient::mediaPlayerLoop, proxies to ::loop();

  • html/HTMLMediaElement.h:

(HTMLMediaElement):

  • platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaPlayerIsLooping): New method allowing
the MediaPlayer and its backend to know if a playback loop is
requested by the client.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::playbackPosition): Report
seek time or media duration if EOS was reached. These early
returns are needed because the position query doesn't work on a
NULL pipeline.
(WebCore::MediaPlayerPrivateGStreamer::changePipelineState):
Refactored to use an early return.
(WebCore::MediaPlayerPrivateGStreamer::prepareToPlay): Reset the
seeking flag.
(WebCore::MediaPlayerPrivateGStreamer::play): reset m_isEndReached.
(WebCore::MediaPlayerPrivateGStreamer::pause): Don't pause on EOS.
(WebCore::MediaPlayerPrivateGStreamer::seek): Refactor, call
currentTime() after we're sure playbin is valid and no error occured.
(WebCore::MediaPlayerPrivateGStreamer::paused): Fake paused state
on EOS.

9:02 AM Changeset in webkit [128319] by Carlos Garcia Campos
  • 6 edits in releases/WebKitGTK/webkit-1.10/Source/WebCore

Merge r126441 - Replace access ot HTMLMediaElement from MediaPlayerPrivateBlackBerry with methods in MediaPlayerClient - updated with notes from initial reviews. https://bugs.webkit.org/show_bug.cgi?id=84291

Reviewed by Eric Carlson.

Code standard compliance - no functional change, so no new tests required.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerExitFullscreen): (WebCore): (WebCore::HTMLMediaElement::mediaPlayerIsVideo): (WebCore::HTMLMediaElement::mediaPlayerContentBoxRect): (WebCore::HTMLMediaElement::mediaPlayerSetSize): (WebCore::HTMLMediaElement::mediaPlayerPause): (WebCore::HTMLMediaElement::mediaPlayerPlay): (WebCore::HTMLMediaElement::mediaPlayerIsPaused): (WebCore::HTMLMediaElement::mediaPlayerHostWindow): (WebCore::HTMLMediaElement::mediaPlayerWindowClipRect):
  • html/HTMLMediaElement.h: (HTMLMediaElement):
  • platform/graphics/MediaPlayer.h: (WebCore): (WebCore::MediaPlayerClient::mediaPlayerExitFullscreen): (WebCore::MediaPlayerClient::mediaPlayerIsVideo): (WebCore::MediaPlayerClient::mediaPlayerContentBoxRect): (WebCore::MediaPlayerClient::mediaPlayerSetSize): (WebCore::MediaPlayerClient::mediaPlayerPause): (WebCore::MediaPlayerClient::mediaPlayerPlay): (WebCore::MediaPlayerClient::mediaPlayerIsPaused): (WebCore::MediaPlayerClient::mediaPlayerHostWindow): (WebCore::MediaPlayerClient::mediaPlayerWindowClipRect):
  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp: (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::load): (WebCore::MediaPlayerPrivate::paint): (WebCore::MediaPlayerPrivate::resizeSourceDimensions): (WebCore::MediaPlayerPrivate::updateStates): (WebCore::MediaPlayerPrivate::onPauseStateChanged): (WebCore::MediaPlayerPrivate::onPlayNotified): (WebCore::MediaPlayerPrivate::onPauseNotified): (WebCore::MediaPlayerPrivate::onAuthenticationNeeded): (WebCore::MediaPlayerPrivate::showErrorDialog): (WebCore::MediaPlayerPrivate::platformWindow): (WebCore::MediaPlayerPrivate::isElementPaused): (WebCore::MediaPlayerPrivate::isTabVisible):
  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h: (MediaPlayerPrivate):

Patch by John Griggs <jgriggs@rim.com> on 2012-08-23

8:49 AM Changeset in webkit [128318] by dmazzoni@google.com
  • 6 edits
    2 adds in trunk

AX: Refactor most AccessibilityRenderObject code into AccessibilityNodeObject
https://bugs.webkit.org/show_bug.cgi?id=96323

Reviewed by Chris Fleizach.

Source/WebCore:

This patch is large, but it's at least 75% cut-and-paste.

All it does is move the implementation of a large chunk of
AccessibilityRenderObject methods to AccessibilityNodeObject
instead. This allows them to operate on elements without
renderers, such as those in canvas fallback content. It also
moves us towards the goal where AccessibilityRenderObject
only has code that's specific to renderers and not just nodes.

Half of the methods cut and paste with essentially no changes.
Some required just tiny changes to access an attribute via the
element (e.g. HTMLSelectElement) rather than its associated
renderer (e.g. RenderMenuList). A few were a little trickier,
as the behavior needs to be slightly different when there's a
renderer. In those last cases, as much of the code as possible is
in AccessibilityNodeObject and AccessibilityRenderObject overrides
it as necessary.

Test: accessibility/canvas-fallback-content-2.html

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::canHaveChildren):
(WebCore):
(WebCore::AccessibilityNodeObject::accessibilityIsIgnored):
(WebCore::AccessibilityNodeObject::isWebArea):
(WebCore::AccessibilityNodeObject::isImageButton):
(WebCore::AccessibilityNodeObject::isAnchor):
(WebCore::AccessibilityNodeObject::isNativeTextControl):
(WebCore::AccessibilityNodeObject::isSearchField):
(WebCore::AccessibilityNodeObject::isNativeImage):
(WebCore::AccessibilityNodeObject::isImage):
(WebCore::AccessibilityNodeObject::isPasswordField):
(WebCore::AccessibilityNodeObject::isInputImage):
(WebCore::AccessibilityNodeObject::isProgressIndicator):
(WebCore::AccessibilityNodeObject::isSlider):
(WebCore::AccessibilityNodeObject::isMenuRelated):
(WebCore::AccessibilityNodeObject::isMenu):
(WebCore::AccessibilityNodeObject::isMenuBar):
(WebCore::AccessibilityNodeObject::isMenuButton):
(WebCore::AccessibilityNodeObject::isMenuItem):
(WebCore::AccessibilityNodeObject::isNativeCheckboxOrRadio):
(WebCore::AccessibilityNodeObject::isEnabled):
(WebCore::AccessibilityNodeObject::isIndeterminate):
(WebCore::AccessibilityNodeObject::isPressed):
(WebCore::AccessibilityNodeObject::isChecked):
(WebCore::AccessibilityNodeObject::isHovered):
(WebCore::AccessibilityNodeObject::isMultiSelectable):
(WebCore::AccessibilityNodeObject::isReadOnly):
(WebCore::AccessibilityNodeObject::isRequired):
(WebCore::AccessibilityNodeObject::headingLevel):
(WebCore::AccessibilityNodeObject::valueDescription):
(WebCore::AccessibilityNodeObject::isARIARange):
(WebCore::AccessibilityNodeObject::valueForRange):
(WebCore::AccessibilityNodeObject::maxValueForRange):
(WebCore::AccessibilityNodeObject::minValueForRange):
(WebCore::AccessibilityNodeObject::stepValueForRange):
(WebCore::AccessibilityNodeObject::isHeading):
(WebCore::AccessibilityNodeObject::isLink):
(WebCore::AccessibilityNodeObject::isControl):
(WebCore::AccessibilityNodeObject::isFieldset):
(WebCore::AccessibilityNodeObject::isGroup):
(WebCore::AccessibilityNodeObject::selectedRadioButton):
(WebCore::AccessibilityNodeObject::selectedTabItem):
(WebCore::AccessibilityNodeObject::checkboxOrRadioValue):
(WebCore::AccessibilityNodeObject::anchorElement):
(WebCore::AccessibilityNodeObject::actionElement):
(WebCore::AccessibilityNodeObject::mouseButtonListener):
(WebCore::AccessibilityNodeObject::isDescendantOfBarrenParent):
(WebCore::AccessibilityNodeObject::alterSliderValue):
(WebCore::AccessibilityNodeObject::increment):
(WebCore::AccessibilityNodeObject::decrement):
(WebCore::AccessibilityNodeObject::changeValueByStep):
(WebCore::AccessibilityNodeObject::changeValueByPercent):
(WebCore::AccessibilityNodeObject::isGenericFocusableElement):
(WebCore::AccessibilityNodeObject::labelForElement):
(WebCore::AccessibilityNodeObject::ariaAccessibilityDescription):
(WebCore::siblingWithAriaRole):
(WebCore::AccessibilityNodeObject::menuElementForMenuButton):
(WebCore::AccessibilityNodeObject::menuForMenuButton):
(WebCore::AccessibilityNodeObject::menuItemElementForMenu):
(WebCore::AccessibilityNodeObject::menuButtonForMenu):
(WebCore::AccessibilityNodeObject::accessibilityDescription):
(WebCore::AccessibilityNodeObject::helpText):
(WebCore::AccessibilityNodeObject::hierarchicalLevel):
(WebCore::AccessibilityNodeObject::textUnderElement):
(WebCore::AccessibilityNodeObject::title):
(WebCore::AccessibilityNodeObject::text):
(WebCore::AccessibilityNodeObject::stringValue):
(WebCore::accessibleNameForNode):
(WebCore::AccessibilityNodeObject::accessibilityDescriptionForElements):
(WebCore::AccessibilityNodeObject::elementsFromAttribute):
(WebCore::AccessibilityNodeObject::ariaLabeledByElements):
(WebCore::AccessibilityNodeObject::ariaLabeledByAttribute):
(WebCore::AccessibilityNodeObject::canSetFocusAttribute):

  • accessibility/AccessibilityNodeObject.h:

(AccessibilityNodeObject):
(WebCore::AccessibilityNodeObject::node):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::parentObject):
(WebCore):
(WebCore::AccessibilityRenderObject::isReadOnly):
(WebCore::AccessibilityRenderObject::helpText):
(WebCore::AccessibilityRenderObject::accessibilityDescription):
(WebCore::AccessibilityRenderObject::text):
(WebCore::AccessibilityRenderObject::contentChanged):
(WebCore::AccessibilityRenderObject::canHaveChildren):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):
(WebCore::AccessibilityRenderObject::setRenderObject):

LayoutTests:

New test that compares accessibility attributes of lots of elements
inside and outside of canvas fallback content, to make sure they're
the same. Designed to be cross-platform because it just asserts the
attributes are the same in both contexts, rather than expecting specific
values.

  • accessibility/canvas-fallback-content-2-expected.txt: Added.
  • accessibility/canvas-fallback-content-2.html: Added.
8:47 AM Changeset in webkit [128317] by commit-queue@webkit.org
  • 3 edits
    28 adds in trunk

Text Autosizing: Don't autosize text in constrained height elements.
https://bugs.webkit.org/show_bug.cgi?id=96143

Patch by John Mellor <johnme@chromium.org> on 2012-09-12
Reviewed by Julien Chaffraix.

Source/WebCore:

Autosizing text within constained height elements usually goes badly,
as the autosized text will wrap onto more lines, hence it will become
taller and often overflow its container, breaking the page's layout.

This patch disables autosizing for blocks with a fixed height ancestor
(or which are fixed height themselves), unless the lowest such ancestor
(or one of the ancestors in between it and the text block) has
overflow-y:auto/scroll, in which case the height isn't really fixed.

Tests: fast/text-autosizing/constrained-and-overflow-auto-ancestor.html

fast/text-autosizing/constrained-and-overflow-hidden-ancestor.html
fast/text-autosizing/constrained-and-overflow-paged-x-ancestor.html
fast/text-autosizing/constrained-and-overflow-scroll-ancestor.html
fast/text-autosizing/constrained-height-ancestor.html
fast/text-autosizing/constrained-maxheight-ancestor.html
fast/text-autosizing/constrained-maxheight.html
fast/text-autosizing/constrained-percent-maxheight.html
fast/text-autosizing/constrained-percent-of-viewport-maxheight.html
fast/text-autosizing/constrained-then-overflow-ancestors.html
fast/text-autosizing/constrained-then-overflow-then-positioned-ancestors.html
fast/text-autosizing/constrained-then-position-absolute-ancestors.html
fast/text-autosizing/constrained-then-position-fixed-ancestors.html
fast/text-autosizing/constrained-within-overflow-ancestor.html

  • rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::processBox):

Skips boxes for which contentHeightIsConstrained returns true.

(WebCore::TextAutosizer::contentHeightIsConstrained):

Walks up the render tree until it finds either a constrained height
or overflow-y:auto/scroll ancestor.

LayoutTests:

Added tests with various kinds, orders and nestings of constrained
height, overflow-y and positioned elements.

  • fast/text-autosizing/constrained-and-overflow-auto-ancestor-expected.html: Added.
  • fast/text-autosizing/constrained-and-overflow-auto-ancestor.html: Added.
  • fast/text-autosizing/constrained-and-overflow-hidden-ancestor-expected.html: Added.
  • fast/text-autosizing/constrained-and-overflow-hidden-ancestor.html: Added.
  • fast/text-autosizing/constrained-and-overflow-paged-x-ancestor-expected.html: Added.
  • fast/text-autosizing/constrained-and-overflow-paged-x-ancestor.html: Added.
  • fast/text-autosizing/constrained-and-overflow-scroll-ancestor-expected.html: Added.
  • fast/text-autosizing/constrained-and-overflow-scroll-ancestor.html: Added.
  • fast/text-autosizing/constrained-height-ancestor-expected.html: Added.
  • fast/text-autosizing/constrained-height-ancestor.html: Added.
  • fast/text-autosizing/constrained-maxheight-ancestor-expected.html: Added.
  • fast/text-autosizing/constrained-maxheight-ancestor.html: Added.
  • fast/text-autosizing/constrained-maxheight-expected.html: Added.
  • fast/text-autosizing/constrained-maxheight.html: Added.
  • fast/text-autosizing/constrained-percent-maxheight-expected.html: Added.
  • fast/text-autosizing/constrained-percent-maxheight.html: Added.
  • fast/text-autosizing/constrained-percent-of-viewport-maxheight-expected.html: Added.
  • fast/text-autosizing/constrained-percent-of-viewport-maxheight.html: Added.
  • fast/text-autosizing/constrained-then-overflow-ancestors-expected.html: Added.
  • fast/text-autosizing/constrained-then-overflow-ancestors.html: Added.
  • fast/text-autosizing/constrained-then-overflow-then-positioned-ancestors-expected.html: Added.
  • fast/text-autosizing/constrained-then-overflow-then-positioned-ancestors.html: Added.
  • fast/text-autosizing/constrained-then-position-absolute-ancestors-expected.html: Added.
  • fast/text-autosizing/constrained-then-position-absolute-ancestors.html: Added.
  • fast/text-autosizing/constrained-then-position-fixed-ancestors-expected.html: Added.
  • fast/text-autosizing/constrained-then-position-fixed-ancestors.html: Added.
  • fast/text-autosizing/constrained-within-overflow-ancestor-expected.html: Added.
  • fast/text-autosizing/constrained-within-overflow-ancestor.html: Added.
8:44 AM Changeset in webkit [128316] by pilgrim@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Remove unused getProcessMemorySize from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=96520

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

8:36 AM Changeset in webkit [128315] by commit-queue@webkit.org
  • 6 edits in trunk/Source

[Qt] Segmentation fault when closing QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=95003

Patch by Roland Takacs <rtakacs@inf.u-szeged.hu> on 2012-09-12
Reviewed by Simon Hausmann.

Source/WebCore:

Defined a new QObject* variable.
If WebKit1 is used, it points to the QGLWidget that was
created in 'createPlatformGraphicsContext3DFromWidget'.
If WebKit2 is used, it points to the QWindow that was
created in GraphicsContext3DPrivate's constructor.
It is neccessary for deallocating them.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):

  • platform/qt/QWebPageClient.h:

(QWebPageClient):

Source/WebKit/qt:

Defined a new QObject* variable that points to the QGLWidget that was created
in 'createPlatformGraphicsContext3DFromWidget'.
It is neccessary for deallocating it.

  • WebCoreSupport/PageClientQt.cpp:

(createPlatformGraphicsContext3DFromWidget):
(WebCore::PageClientQWidget::createPlatformGraphicsContext3D):
(WebCore::PageClientQGraphicsWidget::createPlatformGraphicsContext3D):

  • WebCoreSupport/PageClientQt.h:

(PageClientQWidget):
(PageClientQGraphicsWidget):

8:34 AM Changeset in webkit [128314] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Mark new test fast/filesystem/workers/detached-frame-crash.html
as flakily crashing in cr-win & cr-linux debug builds.

Unreviewed gardening.

  • platform/chromium/TestExpectations:
8:32 AM Changeset in webkit [128313] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebCore

[EFL] Fix build break when netscape-plugin-api is enebled after r126971
https://bugs.webkit.org/show_bug.cgi?id=96513

Unreviewed build fix.

  • plugins/efl/PluginViewEfl.cpp:

(WebCore::PluginView::platformGetValue):

8:21 AM Changeset in webkit [128312] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[BlackBerry] Use own instance of CertMgrWrapper in BlackBerry CredentialBackingStore.
https://bugs.webkit.org/show_bug.cgi?id=96457
Internal PR: 205769

Internally reviewed by George Staikos, Jonathan Dong.
Patch by Lianghui Chen <liachen@rim.com> on 2012-09-12
Reviewed by George Staikos.

CertMgrWrapper in BlackBerry platform layer has been changed from
singleton to normal class, every user of it need to create its own
instance now.

No new tests for platform specific interface change.

  • platform/network/blackberry/CredentialBackingStore.cpp:

(WebCore::CredentialBackingStore::CredentialBackingStore):
(WebCore::CredentialBackingStore::~CredentialBackingStore):
(WebCore::CredentialBackingStore::addLogin):
(WebCore::CredentialBackingStore::updateLogin):
(WebCore::CredentialBackingStore::getLogin):
(WebCore::CredentialBackingStore::certMgrWrapper):
(WebCore):

  • platform/network/blackberry/CredentialBackingStore.h:

(Platform):
(CredentialBackingStore):

8:08 AM Changeset in webkit [128311] by kenneth@webkit.org
  • 3 edits in trunk/Source/WebCore

[EFL] Avoid manual memory management in RenderThemeEfl
https://bugs.webkit.org/show_bug.cgi?id=96501

Reviewed by Simon Hausmann.

Use OwnPtr as it works for Evas_Object and Evas_Ecore objects.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::ThemePartCacheEntry::ThemePartCacheEntry):
(WebCore::RenderThemeEfl::ThemePartCacheEntry::~ThemePartCacheEntry):
(WebCore::RenderThemeEfl::ThemePartCacheEntry::create):
(WebCore::RenderThemeEfl::ThemePartCacheEntry::reuse):
(WebCore::RenderThemeEfl::paintThemePart):
(WebCore::RenderThemeEfl::setColorFromThemeClass):
(WebCore::RenderThemeEfl::themePath):
(WebCore::RenderThemeEfl::loadTheme):
(WebCore::RenderThemeEfl::applyPartDescriptionsFrom):
(WebCore::RenderThemeEfl::RenderThemeEfl):
(WebCore::RenderThemeEfl::~RenderThemeEfl):
(WebCore::RenderThemeEfl::emitMediaButtonSignal):

  • platform/efl/RenderThemeEfl.h:

(WebCore::RenderThemeEfl::canvas):
(WebCore::RenderThemeEfl::edje):
(RenderThemeEfl):
(WebCore::RenderThemeEfl::ThemePartCacheEntry::canvas):
(WebCore::RenderThemeEfl::ThemePartCacheEntry::edje):
(ThemePartCacheEntry):

8:04 AM Changeset in webkit [128310] by zandobersek@gmail.com
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed GTK gardening.

Adding baseline for an accessibility test introduced in r128227.

Adding a text mismatch failure expectation for fast/events/popup-blocking-timers.html
that started failing after the test was refactored in r128270.

  • platform/gtk/TestExpectations:
  • platform/gtk/accessibility/img-fallsback-to-title-expected.txt: Added.
7:50 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
(diff)
7:36 AM Changeset in webkit [128309] by fmalita@chromium.org
  • 3 edits
    2 adds in trunk

getScreenCTM returns different values depending on zoom
https://bugs.webkit.org/show_bug.cgi?id=96361

Reviewed by Dirk Schulze.

Source/WebCore:

SVGSVGElement::localCoordinateSpaceTransform() needs to adjust for the
zoom level (which is already factored into CSS coordinates) at the
SVG/HTML boundary.

Test: svg/zoom/page/zoom-get-screen-ctm.html

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::localCoordinateSpaceTransform):

LayoutTests:

  • svg/zoom/page/zoom-get-screen-ctm-expected.txt: Added.
  • svg/zoom/page/zoom-get-screen-ctm.html: Added.
7:35 AM Changeset in webkit [128308] by commit-queue@webkit.org
  • 5 edits in trunk

[Qt] Build on Windows requires bison/flex in PATH
https://bugs.webkit.org/show_bug.cgi?id=96358

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-09-12
Reviewed by Tor Arne Vestbø.

Source/ThirdParty/ANGLE:

Use MAKEFILE_NOOP_COMMAND instead of the \n\t trick to generate a dummy command. Otherwise
the PATH prepend trick will break because it generates a command line along the lines of
(set PATH="...") && with just that trailing ampersand pair.

  • DerivedSources.pri:

Tools:

The build requires flex, bison, etc. and they need to be in the PATH when building. On Mac OS X
and Linux that is rarely a problem given how easily available the tools are. On Windows however
a separate installation of various GNU tools is required as the operating system doesn't come with
them. To make the development more convenient, Qt 5 provides a copy of the most essential tools in
the gnuwin32 directory of the qt5.git top-level repository.

This patch tries to detect the presence of those tools and prepends them to the PATH if found.

This is required in preparation for the elimination of qt5/qtwebkit.pri, which currently expands
PATH before calling build-webkit. It it also required for the upcoming introduction of win_flex
as dependency over flex, which can be done with less hassle when qt5's gnuwin32 directory has been
updated with the new tool.

  • Scripts/webkitdirs.pm:

(checkRequiredSystemConfig):

  • qmake/mkspecs/features/default_post.prf:
7:26 AM Changeset in webkit [128307] by commit-queue@webkit.org
  • 3 edits in trunk

[Qt] Drastically shorten length of commandline needed for JS bindings generator
https://bugs.webkit.org/show_bug.cgi?id=96266

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-09-12
Reviewed by Tor Arne Vestbø.

The generate-bindings script supports the SOURCE_ROOT environment variable for IDL include file
lookups, which allows specifying relative include search directories.

  • DerivedSources.pri:
7:14 AM Changeset in webkit [128306] by allan.jensen@nokia.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. These tests should have been unskipped when fixed.
https://bugs.webkit.org/show_bug.cgi?id=93246

  • platform/qt/Skipped:
7:11 AM Changeset in webkit [128305] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Update build-jsc after r128174

Reviewed by Ossy.

  • Scripts/build-jsc:
7:10 AM Changeset in webkit [128304] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Teach addStrictSubdirOrderBetween to handle more than two targets

By hard-coding the names of the targets we defined we ended up just
redefining the previous target when using addStrictSubdirOrderBetween
more than once in a single project file.

We now embed the two base targets into the target names.

Reviewed by Simon Hausmann.

6:51 AM Changeset in webkit [128303] by Patrick Gansterer
  • 5 edits in trunk/Source/WebCore

Remove last call to numberToString() from WebCore code
https://bugs.webkit.org/show_bug.cgi?id=96484

Reviewed by Kentaro Hara.

Replace WTF::numberToString() with String::numberToStringECMAScript() to remove duplicated
code. Using the new function allows us to improve and/or remove numberToString() without
changing all caller sides later. Also remove an unneeded strlen() in the touched code.

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::setNamedHiddenReference):

  • bindings/v8/V8DependentRetained.h:

(WebCore::V8DependentRetained::createPropertyName):

  • bindings/v8/V8HiddenPropertyName.cpp:

(WebCore::V8HiddenPropertyName::hiddenReferenceName):

  • bindings/v8/V8HiddenPropertyName.h:

(V8HiddenPropertyName):

6:17 AM Changeset in webkit [128302] by zandobersek@gmail.com
  • 3 edits
    2 adds in trunk

Unreviewed, rolling out r128221.
http://trac.webkit.org/changeset/128221
https://bugs.webkit.org/show_bug.cgi?id=96504

The rollout was incorrect. (Requested by zdobersek on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-12

Source/WebCore:

  • platform/network/soup/ResourceResponseSoup.cpp:

(WebCore::ResourceResponse::updateFromSoupMessage):

LayoutTests:

  • http/tests/misc/non-utf8-header-name-expected.txt: Added.
  • http/tests/misc/non-utf8-header-name.php: Added.
6:16 AM Changeset in webkit [128301] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed. Touch two files for fixing broken compile dependency on Apple Windows Debug bot.

  • css/StyleResolver.cpp:
  • loader/FrameLoader.cpp:
5:56 AM WebKitGTK/1.10.x edited by Philippe Normand
(diff)
5:50 AM Changeset in webkit [128300] by loislo@chromium.org
  • 12 edits in trunk/Source

Web Inspector: NMI move String* instrumentation to wtf.
https://bugs.webkit.org/show_bug.cgi?id=96405

Reviewed by Yury Semikhatsky.

This instrumentation is solving the problem with substrings and removes traits based code which is hard to upstream.

Source/WebCore:

  • dom/WebCoreMemoryInstrumentation.cpp:

(WebCore):

  • dom/WebCoreMemoryInstrumentation.h:

(WebCore):

Source/WebKit/chromium:

Tested by webkit_unit_tests.

  • tests/MemoryInstrumentationTest.cpp:

(WebCore::TEST):

Source/WTF:

Tested by webkit_unit_tests.

  • wtf/text/AtomicString.h:

(AtomicString):
(WTF::AtomicString::reportMemoryUsage):

  • wtf/text/StringImpl.h:

(StringImpl):
(WTF::StringImpl::reportMemoryUsage):

  • wtf/text/WTFString.h:

(String):
(WTF::String::reportMemoryUsage):

5:43 AM Changeset in webkit [128299] by commit-queue@webkit.org
  • 5 edits in trunk

Depend on {base,net} GYP targets rather than {base,net}_java.
https://bugs.webkit.org/show_bug.cgi?id=95690

Patch by Philippe Liard <pliard@google.com> on 2012-09-12
Reviewed by Adam Barth.

Source/WebKit/chromium:

{base,net}_java became 'private' targets on the Chromium side that
clients should not depend on (see
https://chromiumcodereview.appspot.com/10913083/).
This also adds the missing 'chromium_net.jar' to |input_jars_paths|
that was magically included in Chrome for Android downstream but not
upstream. It's needed to register JNI for 'net' in webkit_unit_tests.

  • WebKitUnitTests.gyp:

Tools:

{base,net}_java became 'private' targets on the Chromium side that
clients should not depend on (see
https://chromiumcodereview.appspot.com/10913083/).
This removes a bunch of trailing white spaces additionally in
TestWebkitAPI.gyp (which includes non-trailing white space changes).

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
5:33 AM WebKitGTK/WebKit2Roadmap edited by mario@webkit.org
(diff)
5:33 AM Changeset in webkit [128298] by Philippe Normand
  • 5 edits in trunk/Source/WebCore

[GStreamer] Audio device not closed after playing sound
https://bugs.webkit.org/show_bug.cgi?id=89122

Reviewed by Martin Robinson.

Set the GStreamer pipeline to NULL instead of PAUSED on EOS. This
allows the audio-sink to release its connection to the audio
device. This is done only if the Media element is not
looping. To make the MediaPlayerPrivate layer aware of that
information the MediaPlayerClient interface was updated with a new
method mediaPlayerIsLooping, implemented by the HTMLMediaElement.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerIsLooping): Implementation of
MediaPlayerClient::mediaPlayerLoop, proxies to ::loop();

  • html/HTMLMediaElement.h:

(HTMLMediaElement):

  • platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaPlayerIsLooping): New method allowing
the MediaPlayer and its backend to know if a playback loop is
requested by the client.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::playbackPosition): Report
seek time or media duration if EOS was reached. These early
returns are needed because the position query doesn't work on a
NULL pipeline.
(WebCore::MediaPlayerPrivateGStreamer::changePipelineState):
Refactored to use an early return.
(WebCore::MediaPlayerPrivateGStreamer::prepareToPlay): Reset the
seeking flag.
(WebCore::MediaPlayerPrivateGStreamer::play): reset m_isEndReached.
(WebCore::MediaPlayerPrivateGStreamer::pause): Don't pause on EOS.
(WebCore::MediaPlayerPrivateGStreamer::seek): Refactor, call
currentTime() after we're sure playbin is valid and no error occured.
(WebCore::MediaPlayerPrivateGStreamer::paused): Fake paused state
on EOS.

5:32 AM Changeset in webkit [128297] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt] Fix the build with ENABLE_NETSCAPE_PLUGIN_API=0
https://bugs.webkit.org/show_bug.cgi?id=96494

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-09-12
Reviewed by Tor Arne Vestbø.

WK2's ENABLE_PLUGIN_PROCESS uses the NPAPI functions unconditionally, so disable the
plugin process feature if we don't have NPAPI.

  • qmake/mkspecs/features/features.prf:
5:15 AM Changeset in webkit [128296] by loislo@chromium.org
  • 21 edits in trunk

Unreviewed, rolling out r128280.
http://trac.webkit.org/changeset/128280
https://bugs.webkit.org/show_bug.cgi?id=96498

it broke compilation on windows debug bot (Requested by loislo
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-12

Source/WebKit2:

  • Shared/APIClientTraits.cpp:

(WebKit):

  • Shared/APIClientTraits.h:
  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetApplicationCacheOriginQuota):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:
  • WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:

(WebKit):
(InjectedBundlePageUIClient):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::reachedApplicationCacheOriginQuota):

Tools:

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

(InjectedBundlePage):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::TestRunner):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

LayoutTests:

  • platform/efl-wk1/TestExpectations:
  • platform/efl/Skipped:
  • platform/wk2/Skipped:
5:13 AM Changeset in webkit [128295] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt] Make it possible to build with "make release" and "make debug" on Windows
https://bugs.webkit.org/show_bug.cgi?id=96488

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-09-12
Reviewed by Tor Arne Vestbø.

A "make debug" is passed through recursively and currently it aborts at Makefile.DerivedSources
because there are no such targets. We want the generated sources to be independent from release
or debug build configurations, so it is sufficient to provide fake debug and release targets that
redirect to the same general-purpose target (first) of creating the derived sources.

  • qmake/mkspecs/features/default_post.prf:
5:10 AM Changeset in webkit [128294] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Build on X11 with GraphicsSurface but without NPAPI is broken
https://bugs.webkit.org/show_bug.cgi?id=96495

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-09-12
Reviewed by Kenneth Rohde Christiansen.

When enabling NPAPI we link against XRender on X11. The other component that needs Xrender
is GraphicsSurface. So when building without NPAPI we need to make sure that we link in Xrender.

This patch cleans up the GraphicsSurface related linkage required on Mac OS X and X11 by wrapping
it in use?(graphics_surface) instead of 3D_GRAPHICS. It is not neccesary to perform the have?(XCOMPOSITE)
check anymore because it's already done in features.prf before enabling use_graphics_surface in the
first place.

  • WebCore.pri:
5:07 AM Changeset in webkit [128293] by commit-queue@webkit.org
  • 12 edits in trunk

Web Inspector: Protocol Extension: Add "regionLayoutUpdate" event
https://bugs.webkit.org/show_bug.cgi?id=93443

Patch by Andrei Poenaru <poenaru@adobe.com> on 2012-09-12
Reviewed by Alexander Pavlov.

Source/WebCore:

Added "regionLayoutUpdate" event to the protocol.

Removed "getFlowByName" from protocol.

The front-end keeps in sync the requested Named Flow Collections.

Modified existing test: inspector/styles/protocol-css-regions-commands.html

  • dom/NamedFlowCollection.cpp:

(WebCore::NamedFlowCollection::ensureFlowWithName):
(WebCore::NamedFlowCollection::discardNamedFlow):

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(UpdateRegionLayoutTask):
(WebCore):
(WebCore::UpdateRegionLayoutTask::UpdateRegionLayoutTask):
(WebCore::UpdateRegionLayoutTask::scheduleFor):
(WebCore::UpdateRegionLayoutTask::unschedule):
(WebCore::UpdateRegionLayoutTask::reset):
(WebCore::UpdateRegionLayoutTask::onTimer):
(WebCore::InspectorCSSAgent::reset):
(WebCore::InspectorCSSAgent::didCreateNamedFlow):
(WebCore::InspectorCSSAgent::willRemoveNamedFlow):
(WebCore::InspectorCSSAgent::didUpdateRegionLayout):
(WebCore::InspectorCSSAgent::regionLayoutUpdated):
(WebCore::InspectorCSSAgent::getNamedFlowCollection):
(WebCore::InspectorCSSAgent::documentNodeWithRequestedFlowsId):

  • inspector/InspectorCSSAgent.h:

(WebCore):
(InspectorCSSAgent):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didCreateNamedFlowImpl):
(WebCore::InspectorInstrumentation::willRemoveNamedFlowImpl):
(WebCore::InspectorInstrumentation::didUpdateRegionLayoutImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCreateNamedFlow):
(WebCore::InspectorInstrumentation::willRemoveNamedFlow):
(WebCore):
(WebCore::InspectorInstrumentation::didUpdateRegionLayout):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync.callback):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync.callback):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved):
(WebInspector.CSSStyleModel.prototype._regionLayoutUpdated):
(WebInspector.CSSStyleModel.prototype._resetNamedFlowCollections):
(WebInspector.CSSDispatcher.prototype.namedFlowCreated):
(WebInspector.CSSDispatcher.prototype.namedFlowRemoved):
(WebInspector.CSSDispatcher.prototype.regionLayoutUpdated):
(WebInspector.NamedFlow):
(WebInspector.NamedFlowCollection):
(WebInspector.NamedFlowCollection.prototype._appendNamedFlow):
(WebInspector.NamedFlowCollection.prototype._removeNamedFlow):
(WebInspector.NamedFlowCollection.prototype.flowByName):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEvent):

LayoutTests:

Validate "regionLayoutUpdate" event.

  • inspector/styles/protocol-css-regions-commands-expected.txt:
  • inspector/styles/protocol-css-regions-commands.html:
5:06 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
(diff)
5:05 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
(diff)
4:52 AM Changeset in webkit [128292] by kenneth@webkit.org
  • 2 edits in trunk/Tools

[EFL] Make DumpRenderTree smarter at finding the fonts
http://webkit.org/b/96281

Reviewed by Gyuyoung Kim.

Respect WEBKITOUTPUTDIR and expand the font dir from it.
Use CString consistently.

  • DumpRenderTree/efl/FontManagement.cpp:

(buildPath):
(getCoreFontFiles):
(addFontDirectory):
(addFontFiles):
(getCustomBuildDir):
(getPlatformFontsPath):
(addFontsToEnvironment):

4:36 AM Changeset in webkit [128291] by apavlov@chromium.org
  • 10 edits in trunk

Web Inspector: [Elements] Sidebar panes not updated on style changes due to "class" attribute modifications
https://bugs.webkit.org/show_bug.cgi?id=95722

Reviewed by Vsevolod Vlasov.

Source/WebCore:

The DOMAgent StyleInvalidated event has been removed in favor of the StylesSidebarPane explicitly listening on the
AttrModified/AttrRemoved events that result in those same updates.

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype._attributeModified):
(WebInspector.DOMAgent.prototype._loadNodeAttributes):
(WebInspector.DOMAgent.prototype._childNodeRemoved):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype.updateSelection): Drive-by: avoid a costly synchronous layout during DOM tree updates.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane):
(WebInspector.StylesSidebarPane.prototype._attributeChanged):
(WebInspector.StylesSidebarPane.prototype._canAffectCurrentStyles):

LayoutTests:

  • inspector/elements/edit-style-attribute.html: Renamed events on which to listen.
  • inspector/styles/override-screen-size.html: Drive-by: fixed race condition that was resulting in this test's failures.
  • inspector/styles/styles-update-from-js-expected.txt:
  • inspector/styles/styles-update-from-js.html: Added test cases for style updates on ancestor and sibling attributes' changes.
4:34 AM Changeset in webkit [128290] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Build with ENABLE_REQUEST_ANIMATION_FRAME=0 is broken
https://bugs.webkit.org/show_bug.cgi?id=96491

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-09-12
Reviewed by Csaba Osztrogonác.

In the IDL file, don't just check for the define, also check if it's set to 1 before enabling the
RAF APIs. It's done like this with all the other feature defines in IDL files.

  • page/DOMWindow.idl:
3:20 AM Changeset in webkit [128289] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[EFL][WK2] WorkQueue::dispatchAfterDelay() doesn't work properly.
https://bugs.webkit.org/show_bug.cgi?id=91179

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-09-12
Reviewed by Gyuyoung Kim.

When UI Process is crashed and WebProcess's ecore main loop is very
busy or lockup also, watchdocCallback() function in the
ChildProcess.cpp doesn't triggered. And this is because of that
WorkQueue::dispatchAfterDelay() function uses ecore timer for getting
timer event.

For removing the dependency between the dispatchAfterDelay() and ecore
main loop, new timer event mechanism is added to WorkQueue main loop.

  • Platform/WorkQueue.h:

(TimerWorkItem):
(WorkQueue::TimerWorkItem::dispatch):
(WorkQueue::TimerWorkItem::expireTime):
(WorkQueue::TimerWorkItem::expired):
(WorkQueue):

  • Platform/efl/WorkQueueEfl.cpp:

(WorkQueue::TimerWorkItem::create):
(WorkQueue::TimerWorkItem::TimerWorkItem):
(WorkQueue::performFileDescriptorWork):
(WorkQueue::getCurrentTime):
(WorkQueue::getNextTimeOut):
(WorkQueue::performTimerWork):
(WorkQueue::workQueueThread):
(WorkQueue::dispatchAfterDelay):

3:17 AM Changeset in webkit [128288] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening, skip a new failing test to paint the bot green.

  • platform/qt-5.0-wk2/Skipped:
3:15 AM Changeset in webkit [128287] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: InspectorBackend.loadFromJSONIfNeeded should take the JSON url as argument
https://bugs.webkit.org/show_bug.cgi?id=96472

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-09-12
Reviewed by Yury Semikhatsky.

The method loadFromJSONIfNeeded need to take the jsonUrl as argument
as this will be called from the Inspector Protocol Test Harness
residing in a different location.

No new tests as code refactoring done.

  • inspector/front-end/InspectorBackend.js:

(InspectorBackendClass.prototype.loadFromJSONIfNeeded):

  • inspector/front-end/inspector.js:
2:58 AM Changeset in webkit [128286] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-1.10/Source/WebCore

Merge r128074 - [GTK][a11y] editing/pasteboard/paste-blockquote-into-blockquote-4.html crashes
https://bugs.webkit.org/show_bug.cgi?id=96199

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-10
Reviewed by Martin Robinson.

Added sanity check to correct erroneous assumption that there will
always be a child object.

No new tests as the bug crashes two existing Layout Tests which should
no longer crash as a result of this fix.

  • accessibility/gtk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

2:58 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
2:57 AM Changeset in webkit [128285] by vsevik@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: XMLHttpRequest instrumentation methods used by timeline should have better names.
https://bugs.webkit.org/show_bug.cgi?id=96486

Reviewed by Alexander Pavlov.

Renamed instrumentation methods.

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::willDispatchXHRReadyStateChangeEventImpl):
(WebCore::InspectorInstrumentation::didDispatchXHRReadyStateChangeEventImpl):
(WebCore::InspectorInstrumentation::willDispatchXHRLoadEventImpl):
(WebCore::InspectorInstrumentation::didDispatchXHRLoadEventImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willDispatchXHRReadyStateChangeEvent):
(WebCore::InspectorInstrumentation::didDispatchXHRReadyStateChangeEvent):
(WebCore::InspectorInstrumentation::willDispatchXHRLoadEvent):
(WebCore::InspectorInstrumentation::didDispatchXHRLoadEvent):

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::willDispatchXHRReadyStateChangeEvent):
(WebCore::InspectorTimelineAgent::didDispatchXHRReadyStateChangeEvent):
(WebCore::InspectorTimelineAgent::willDispatchXHRLoadEvent):
(WebCore::InspectorTimelineAgent::didDispatchXHRLoadEvent):

  • inspector/InspectorTimelineAgent.h:

(InspectorTimelineAgent):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::callReadyStateChangeListener):

2:46 AM Changeset in webkit [128284] by commit-queue@webkit.org
  • 12 edits in trunk/Source

Unreviewed, rolling out r128279.
http://trac.webkit.org/changeset/128279
https://bugs.webkit.org/show_bug.cgi?id=96487

"Snow Leopard compilation broken" (Requested by yurys on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-12

Source/WebCore:

  • dom/WebCoreMemoryInstrumentation.cpp:

(WebCore):
(WebCore::String):
(WebCore::StringImpl):
(WebCore::AtomicString):

  • dom/WebCoreMemoryInstrumentation.h:

(WebCore):

  • inspector/MemoryInstrumentationImpl.cpp:

(WebCore::MemoryInstrumentationImpl::countObjectSize):

  • platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::reportMemoryUsage):

Source/WebKit/chromium:

  • tests/MemoryInstrumentationTest.cpp:

(WebCore::InstrumentedUndefined::reportMemoryUsage):
(WebCore::TEST):

Source/WTF:

  • wtf/MemoryInstrumentation.h:

(GenericMemoryTypes):
(WebCore):
(WebCore::MemoryInstrumentation::addRootObject):
(WebCore::MemoryObjectInfo::reportObjectInfo):
(WebCore::MemoryClassInfo::MemoryClassInfo):

  • wtf/text/AtomicString.h:

(AtomicString):

  • wtf/text/StringImpl.h:
  • wtf/text/WTFString.h:
2:45 AM Changeset in webkit [128283] by yurys@chromium.org
  • 4 edits in trunk/Source

Web Inspector: Persistent handle referenced from ScriptWrappable is double counted
https://bugs.webkit.org/show_bug.cgi?id=96483

Reviewed by Alexander Pavlov.

Source/WebCore:

  • bindings/v8/ScriptWrappable.h:

(WebCore::ScriptWrappable::reportMemoryUsage): the handle is a part of an
array where all such handles are allocated and should not be counted here
second time. In order to make the clang plugin that validate memory instrumentation
happy we report it here as weak pointer (no-op).

Source/WTF:

  • wtf/MemoryInstrumentation.h:

(WebCore::MemoryClassInfo::addWeakPointer): this method is expected to be
used on fields that are pointers to objects which are parts of bigger memory
blocks (field of another object, element in an array, object allocated in a
memory arena etc.). We don't want to count such objects' memory separately
from their owners but in order to be able to validates the memory instrumentation
with clang plugin we need to make sure all fields in instrumented objects
are reported.
(MemoryClassInfo):

2:38 AM Changeset in webkit [128282] by abecsi@webkit.org
  • 3 edits in trunk/Source/WebKit/qt

[Qt] Add module identifier directive to the qmldir files
https://bugs.webkit.org/show_bug.cgi?id=96406

Reviewed by Simon Hausmann.

Qt5 QML modules need to be identified. Type registrations are only permitted
into the namespace identified in the qmldir file's module identifier directive.
Additionally this also facilitates the protection against external registrations.
This patch suppresses a warning when importing the QtWebKit module.

  • declarative/experimental/qmldir:
  • declarative/qmldir:
2:32 AM Changeset in webkit [128281] by caseq@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Implement search and filtering on Timeline panel
https://bugs.webkit.org/show_bug.cgi?id=95445

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-09-12
Reviewed by Yury Semikhatsky.

Implemented textual search/filtering on Timeline panel.
Fixed "revealRecordAt" - now it scans all records in window,
now only visible ones.

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineWindowFilter):
Extracted from TimelineOverviewPane class.

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype.revealRecordAt):
Used DFS to scan records.
(WebInspector.TimelinePanel.prototype._revealRecord):
Extracted common code.
(WebInspector.TimelineSearchFilter):
Implemented search and filtration.

2:17 AM Changeset in webkit [128280] by commit-queue@webkit.org
  • 21 edits in trunk

[WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
https://bugs.webkit.org/show_bug.cgi?id=96374

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-12
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add Bundle C API to reset the application cache quota
for a given origin.

Add new reachedApplicationCacheOriginQuota callback
to WKBundlePageUIClient which is called from
WebChromeClient::reachedApplicationCacheOriginQuota().

Those are needed by WebKitTestRunner to dump
information about the application cache callbacks
if instructed to.

  • Shared/APIClientTraits.cpp:

(WebKit):

  • Shared/APIClientTraits.h:
  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetApplicationCacheOriginQuota):
(WKBundleResetApplicationCacheOriginQuota):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::resetApplicationCacheOriginQuota):
(WebKit):

  • WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::didReachApplicationCacheOriginQuota):
(WebKit):

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:

(WebKit):
(InjectedBundlePageUIClient):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::reachedApplicationCacheOriginQuota):

Tools:

Implement support for dumpApplicationCacheDelegateCallbacks
and disallowIncreaseForApplicationCacheQuota in
WebKitTestRunner and properly dump the information
expected by the tests.

If the application cache quota is reached for a given
security origin, WebKitTestRunner will reset the quota
to its default value, unless intructed not to via
disallowIncreaseForApplicationCacheQuota().

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
(WTR):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

(InjectedBundlePage):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::TestRunner):
(WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
(WTR):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
(TestRunner):
(WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
(WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):

LayoutTests:

Unskip test cases that are passing now that WebKitTestRunner
implements dumpApplicationCacheDelegateCallbacks and
disallowIncreaseForApplicationCacheQuota.

  • platform/efl-wk1/TestExpectations:
  • platform/efl/Skipped:
  • platform/wk2/Skipped:
2:13 AM Changeset in webkit [128279] by loislo@chromium.org
  • 12 edits in trunk/Source

Web Inspector: NMI move String* instrumentation to wtf.
https://bugs.webkit.org/show_bug.cgi?id=96405

Reviewed by Yury Semikhatsky.

This instrumentation is solving the problem with substrings and removes traits based code which is hard to upstream.

Source/WebCore:

  • dom/WebCoreMemoryInstrumentation.cpp:

(WebCore):

  • dom/WebCoreMemoryInstrumentation.h:

(WebCore):

  • dom/WebCoreMemoryInstrumentation.cpp:

(WebCore):

  • dom/WebCoreMemoryInstrumentation.h:

(WebCore):

  • inspector/MemoryInstrumentationImpl.cpp:

(WebCore::MemoryInstrumentationImpl::countObjectSize):

  • platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::reportMemoryUsage):

Source/WebKit/chromium:

Tested by webkit_unit_tests.

  • tests/MemoryInstrumentationTest.cpp:

(WebCore::InstrumentedUndefined::reportMemoryUsage):
(WebCore::TEST):

Source/WTF:

Tested by webkit_unit_tests.

  • wtf/MemoryInstrumentation.h:

(WebCore):
(WebCore::MemoryInstrumentation::addRootObject):
(WebCore::MemoryObjectInfo::reportObjectInfo):
(WebCore::MemoryClassInfo::MemoryClassInfo):

  • wtf/text/AtomicString.h:

(AtomicString):
(WTF::AtomicString::reportMemoryUsage):

  • wtf/text/StringImpl.h:

(StringImpl):
(WTF::StringImpl::reportMemoryUsage):

  • wtf/text/WTFString.h:

(String):
(WTF::String::reportMemoryUsage):

2:10 AM Changeset in webkit [128278] by commit-queue@webkit.org
  • 11 edits in trunk

[WK2] [WTR] WebKitTestRunner needs TestRunner.workerThreadCount
https://bugs.webkit.org/show_bug.cgi?id=96388

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-12
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Added WKBundleGetWorkerThreadCount() function to Injected Bundle private API.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleGetWorkerThreadCount):

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::workerThreadCount): Returns count of worker threads.
(WebKit):

  • WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

Tools:

Exported TestRunner.workerThreadCount as readonly attribute.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp: Added workerThreadCount() method implementation.

(WTR::TestRunner::workerThreadCount): Returns count of worker threads.
(WTR):

  • WebKitTestRunner/InjectedBundle/TestRunner.h: Added workerThreadCount() method.

(TestRunner):

LayoutTests:

Unskipped corresponding tests.

  • platform/wk2/Skipped:
1:56 AM QtWebKitBuildBots edited by kadam@inf.u-szeged.hu
(diff)
1:54 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
1:54 AM QtWebKitBuildBots edited by kadam@inf.u-szeged.hu
(diff)
1:54 AM Changeset in webkit [128277] by Carlos Garcia Campos
  • 25 edits in releases/WebKitGTK/webkit-1.10/Source/JavaScriptCore

Merge r126715 - Array type checks and storage accesses should be uniformly represented and available to CSE
https://bugs.webkit.org/show_bug.cgi?id=95013

Reviewed by Oliver Hunt.

This uniformly breaks up all array accesses into up to three parts:

1) The type check, using a newly introduced CheckArray node, in addition to possibly

a CheckStructure node. We were already inserting the CheckStructure prior to this
patch. The CheckArray node will be automatically eliminated if the thing it was
checking for had already been checked for, either intentionally (a CheckStructure
inserted based on the array profile of this access) or accidentally (some checks,
typically a CheckStructure, inserted for some unrelated operations). The
CheckArray node may not be inserted if the array type is non-specific (Generic or
ForceExit).

2) The storage load using GetIndexedPropertyStorage. Previously, this only worked for

GetByVal. Now it works for all array accesses. The storage load may not be
inserted if the mode of array access does not permit CSE of storage loads (like
non-specific modes or Arguments).

3) The access itself: one of GetByVal, PutByVal, PutByValAlias, ArrayPush, ArrayPop,

GetArrayLength, StringCharAt, or StringCharCodeAt.

This means that the type check can be subjected to CSE even if the CFA isn't smart
enough to reason about it (yet!). It also means that the storage load can always be
subjected to CSE; previously CSE on storage load only worked for array loads and not
other forms of access. Finally, it removes the bizarre behavior that
GetIndexedPropertyStorage previously had: previously, it was responsible for the type
check in some cases, but not others; this made reasoning about the CFA really
confusing.

This change also disables late refinement of array mode, since I decided that
supporting that feature is both confusing and likely unprofitable. The array modes are
now locked in in the first fixup run after prediction propagation. Of course,
refinements from Generic to something else would not have been a problem; we could
reenable those if we thought we really needed to.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):

  • dfg/DFGArrayMode.cpp:

(JSC::DFG::fromStructure):
(DFG):
(JSC::DFG::refineArrayMode):

  • dfg/DFGArrayMode.h:

(DFG):
(JSC::DFG::modeIsJSArray):
(JSC::DFG::lengthNeedsStorage):
(JSC::DFG::modeIsSpecific):
(JSC::DFG::modeSupportsLength):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::getArrayMode):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::getArrayModeAndEmitChecks):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::mergeBlocks):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::CSEPhase):
(JSC::DFG::CSEPhase::checkStructureElimination):
(CSEPhase):
(JSC::DFG::CSEPhase::checkArrayElimination):
(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
(JSC::DFG::performCSE):

  • dfg/DFGCSEPhase.h:

(DFG):

  • dfg/DFGCommon.h:
  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::checkArray):
(FixupPhase):
(JSC::DFG::FixupPhase::blessArrayOperation):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::Graph):
(DFG):
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::collectGarbage):

  • dfg/DFGGraph.h:

(Graph):
(JSC::DFG::Graph::vote):
(JSC::DFG::Graph::substitute):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasArrayMode):
(JSC::DFG::Node::setArrayMode):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOperations.cpp:
  • dfg/DFGPhase.h:

(DFG):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::mergeDefaultFlags):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArray):
(JSC::DFG::SpeculativeJIT::useChildren):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
(JSC::DFG::SpeculativeJIT::compileGetArrayLength):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):

1:52 AM Changeset in webkit [128276] by Carlos Garcia Campos
  • 7 edits in releases/WebKitGTK/webkit-1.10/Source/JavaScriptCore

Merge r126692 - op_call should have ArrayProfiling for the benefit of array intrinsics
https://bugs.webkit.org/show_bug.cgi?id=95014

Reviewed by Sam Weinig.

This is a performance-neutral change that just adds the profiling but does not
use it, yet. If in the future we wanted to make this kind of profiling cheaper
we could move it into specialized thunks for the relevant array intrinsics, but
I figure that if this much simpler change gives us what we need without any
discernable performance penalty then that's for the best.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCall):

  • jit/JITCall.cpp:

(JSC::JIT::compileOpCall):

  • jit/JITCall32_64.cpp:

(JSC::JIT::compileOpCall):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
1:50 AM QtWebKitGardening edited by kadam@inf.u-szeged.hu
(diff)
1:44 AM Shadowproblem_example.jpg attached to QtWebKitGardening by kadam@inf.u-szeged.hu
1:44 AM draganddrop_example.jpg attached to QtWebKitGardening by kadam@inf.u-szeged.hu
1:44 AM Mutation_example.jpg attached to QtWebKitGardening by kadam@inf.u-szeged.hu
1:44 AM rebaseline_example2.jpg attached to QtWebKitGardening by kadam@inf.u-szeged.hu
1:44 AM rebaseline_example.jpg attached to QtWebKitGardening by kadam@inf.u-szeged.hu
1:43 AM QtWebKitGardening edited by kadam@inf.u-szeged.hu
(diff)
1:18 AM Changeset in webkit [128275] by kenneth@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed EFL build fix.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::themePath):

12:55 AM Changeset in webkit [128274] by kenneth@webkit.org
  • 3 edits in trunk/Source/WebCore

[EFL] Clean up the RenderTheme Edje caching
https://bugs.webkit.org/show_bug.cgi?id=96016

Reviewed by Gyuyoung Kim.

Refactor the Edje parts caching to be easier to understand and use
proper C++ constructs.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore):
(WebCore::toEdjeGroup):

Converts the enum to the given edje group name.

(WebCore::setSourceGroupForEdjeObject):

Basically a wrapper around evas_object_file_set, but handles
errors, which was done slightly differently all over.

(WebCore::RenderThemeEfl::ThemePartCacheEntry::ThemePartCacheEntry):
(WebCore::RenderThemeEfl::ThemePartCacheEntry::~ThemePartCacheEntry):

(WebCore::createCairoSurfaceFor):
(WebCore::isFormElementTooLargeToDisplay):

Methods used when creating ThemePartCacheEntry'es.

(WebCore::RenderThemeEfl::ThemePartCacheEntry::create):
(WebCore::RenderThemeEfl::ThemePartCacheEntry::reuse):

New methods for creating and reusing an cache entry. If you do
not supply a new size, the original size will be used, and it is
thus more effective.

(WebCore::RenderThemeEfl::getThemePartFromCache):

New method for requesting a theme part. If it doesn't exist
it will additinally be loaded and added to the cache.

(WebCore::RenderThemeEfl::flushThemePartCache):

Remove the entire cache and free the assets.

(WebCore::RenderThemeEfl::paintThemePart):
(WebCore::RenderThemeEfl::themePath):
(WebCore::RenderThemeEfl::loadTheme):
(WebCore::RenderThemeEfl::applyPartDescriptionsFrom):
(WebCore::RenderThemeEfl::~RenderThemeEfl):
(WebCore::RenderThemeEfl::emitMediaButtonSignal):

  • platform/efl/RenderThemeEfl.h:

(RenderThemeEfl):
(ThemePartCacheEntry):

12:53 AM Changeset in webkit [128273] by jochen@chromium.org
  • 6 edits
    2 adds in trunk

Source/WebKit/chromium: [chromium] consumable user gesture count off for input events
https://bugs.webkit.org/show_bug.cgi?id=96373

Reviewed by Adam Barth.

Don't create a UserGestureIndicator in the chromium layer, as it will
already be created by webcore's event handler. Creating multiple
UserGestureIndicator objects for the same object would allow to execute
multiple user-gesture-gated actions per user gesture such as opening a
new window.

  • public/WebInputEvent.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleInputEvent):

Tools: [chromium] Consume a user gesture when creating a new view.
https://bugs.webkit.org/show_bug.cgi?id=96373

Reviewed by Adam Barth.

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createView):

LayoutTests: [chromium] Only allow one user-gesture gated action per user action.
https://bugs.webkit.org/show_bug.cgi?id=96373

Reviewed by Adam Barth.

  • platform/chromium/fast/events/popup-allowed-from-gesture-only-once-expected.txt: Added.
  • platform/chromium/fast/events/popup-allowed-from-gesture-only-once.html: Added.
12:39 AM Changeset in webkit [128272] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WK2][WTR] Some of TestRunner special options are not reset before testing
https://bugs.webkit.org/show_bug.cgi?id=96384

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-12
Reviewed by Kenneth Rohde Christiansen.

Now values of the following special options are reset:
void setAcceptsEditing(in boolean value);
void setCloseRemainingWindowsWhenComplete(in boolean value);
void setXSSAuditorEnabled(in boolean value);
void setAllowFileAccessFromFileURLs(in boolean value);
void setPluginsEnabled(in boolean value);
void setPopupBlockingEnabled(in boolean value);

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

12:35 AM Changeset in webkit [128271] by Darin Adler
  • 3 edits in trunk/Source/WebKit2

Make NetscapePlugin::m_timers use HashMap<OwnPtr> instead of deleteAllValues
https://bugs.webkit.org/show_bug.cgi?id=96469

Reviewed by Dan Bernstein.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::scheduleTimer): Call release rather than leakPtr when
entering a timer into the map.
(WebKit::NetscapePlugin::unscheduleTimer): Take an existing timer from the map
with the take function rather than the roundabout code needed before.
(WebKit::NetscapePlugin::destroy): Remove now-unneeded call to deleteAllValues.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h: Change the value type for

TimerMap to OwnPtr<Timer> rather than Timer*.

12:29 AM Changeset in webkit [128270] by jochen@chromium.org
  • 3 edits in trunk/LayoutTests

Change fast/events/popup-blocking-timers.html to generate a user action for each popup
https://bugs.webkit.org/show_bug.cgi?id=96475

Reviewed by Adam Barth.

The chromium port only allows one user gesture gated action per user
gesture.

  • fast/events/popup-blocking-timers-expected.txt:
  • fast/events/popup-blocking-timers.html:
12:02 AM Changeset in webkit [128269] by aelias@chromium.org
  • 4 edits in trunk/Source

[chromium] Flip Y and swizzle inside compositeAndReadback implementation
https://bugs.webkit.org/show_bug.cgi?id=96458

Reviewed by James Robinson.

Currently, compositeAndReadback API assumes a GL-style texture
and is converted to the normal software format in WebViewImpl.
For the software implementation, this API would result in two
redundant conversions. This patch makes the conversion inside
CCRendererGL instead. I rolled my own for loop as I didn't find the
appropriate function within raw Skia.

No new tests (covered by existing layout tests).

Source/WebCore:

  • platform/graphics/chromium/cc/CCRendererGL.cpp:

(WebCore::CCRendererGL::getFramebufferPixels):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::doPixelReadbackToCanvas):

Sep 11, 2012:

11:46 PM Changeset in webkit [128268] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2012-09-11 Geoffrey Garen <ggaren@apple.com>

Second step to fixing the Windows build: Add new symbols.

11:40 PM Changeset in webkit [128267] by ggaren@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Mac build fix: Commit a file I forgot.

  • WebView/WebScriptDebugDelegate.mm:

(-[WebScriptCallFrame functionName]):

11:27 PM Changeset in webkit [128266] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2012-09-11 Geoffrey Garen <ggaren@apple.com>

First step to fixing the Windows build: Remove old symbols.

11:14 PM Changeset in webkit [128265] by ggaren@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Don't allocate a backing store just for a function's name
https://bugs.webkit.org/show_bug.cgi?id=96468

Reviewed by Oliver Hunt.

Treat function.name like function.length etc., and use a custom getter.
This saves space in closures.

  • debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::functionName):

  • debugger/DebuggerCallFrame.h:

(DebuggerCallFrame): Updated for interface change.

  • runtime/Executable.h:

(JSC::JSFunction::JSFunction): Do a little inlining.

  • runtime/JSFunction.cpp:

(JSC::JSFunction::finishCreation): Gone now. That's the point of the patch.

(JSC::JSFunction::name):
(JSC::JSFunction::displayName):
(JSC::JSFunction::nameGetter):
(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::getOwnPropertyDescriptor):
(JSC::JSFunction::getOwnPropertyNames):
(JSC::JSFunction::put):
(JSC::JSFunction::deleteProperty):
(JSC::JSFunction::defineOwnProperty): Added custom accessors for .name
just like .length and others.

  • runtime/JSFunction.h:

(JSC::JSFunction::create):
(JSFunction): Updated for interface changes.

10:52 PM Changeset in webkit [128264] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update

Assign new bug for fast/text/international/vertical-text-*.html

  • platform/chromium/TestExpectations:
10:02 PM Changeset in webkit [128263] by commit-queue@webkit.org
  • 3 edits
    5 adds in trunk

WebFrameImpl::client() needs NULL check in WebWorkerClientImpl::openFileSystem
https://bugs.webkit.org/show_bug.cgi?id=96354

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-09-11
Reviewed by Kent Tamura.

Ensure non-NULL before using WebFrameImpl::client().

Source/WebKit/chromium:

Test: fast/filesystem/workers/detached-frame-crash.html

  • src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::openFileSystem):

LayoutTests:

  • fast/filesystem/workers/detached-frame-crash-expected.txt: Added.
  • fast/filesystem/workers/detached-frame-crash.html: Added.
  • fast/filesystem/workers/resources/detached-frame-crash-frame.html: Added.
  • fast/filesystem/workers/resources/detached-frame-crash-worker.js: Added.
9:26 PM Changeset in webkit [128262] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

IncrementalSweeper should not sweep/free Zapped blocks
https://bugs.webkit.org/show_bug.cgi?id=96464

Reviewed by Filip Pizlo.

This is not beneficial in terms of performance because there isn't any way a block can emerge
in the Zapped state from a call to Heap::collect() unless we run an eager sweep on it, in which
case we've already run all the destructors we possibly can. This also causes bugs since we don't
take zapped-ness into account when determining whether or not a block is empty to free it. The
incremental sweeper can then accidentally free blocks that it thinks are empty but are in fact
zapped with still-live objects in them.

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::needsSweeping): It is only valid to sweep a block if it is in the Marked state.

9:24 PM Changeset in webkit [128261] by ryuan.choi@samsung.com
  • 9 edits in trunk

[CMAKE] Supply feature defines to CodeGeneratorTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=96273

Reviewed by Gyuyoung Kim.

.:

  • Source/cmake/WebKitFeatures.cmake: Generated FEATURE_DEFINES_WITH_SPACE_SEPARATOR.

Source/WebCore:

  • CMakeLists.txt: Extracted FEATURE_DEFINES with space separator to share.
  • PlatformBlackBerry.cmake: Ditto.
  • UseJSC.cmake: Ditto.
  • UseV8.cmake: Ditto.

Tools:

Passed FEATURE_DEFINES_WITH_SPACE_SEPARATOR to CodeGeneratorTestRunner
in order to distinguish compile time options such as ENABLE(TOUCH_EVENTS).

  • WebKitTestRunner/CMakeLists.txt:
9:08 PM Changeset in webkit [128260] by ggaren@apple.com
  • 15 edits in trunk/Source/JavaScriptCore

JSActivation should inline allocate its registers, and eliminate
'arguments' registers in the common case
https://bugs.webkit.org/show_bug.cgi?id=96427

Reviewed by Filip Pizlo.

This cuts the size class for simple closures down to 64 bytes.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator): Set the usesNonStrictEval
flag, which is new. Use a more specific test for whether a function
uses 'arguments', so we can avoid allocating, initializing, and tearing
off those registers in the common case. Distinguish between capturing
arguments and not, so we can avoid allocating space for arguments in
the torn-off object.

We can make this even more general in the future, with some bytecode
generator refactoring.

(JSC::BytecodeGenerator::resolve): Updated for new interface.

  • bytecompiler/BytecodeGenerator.h:

(BytecodeGenerator):
(JSC::BytecodeGenerator::symbolTable): Updated some types.

  • heap/Heap.cpp:

(JSC::Heap::isValidAllocation): Allow large allocations, now that they
are both supported and used.

  • heap/Heap.h:

(Heap): Added a new form of allocateCell that specifies the full size
of the allocation, to allow for extra space on the end.

  • interpreter/CallFrame.h:

(JSC::ExecState::argumentOffset):
(JSC::ExecState::argumentOffsetIncludingThis):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::unwindCallFrame): Refactored this code to be more
specific about tearing off 'arguments' vs activations. This is something
I forgot in my last patch, and it is required now that we can have
acitvations without 'arguments' registers.

  • runtime/Arguments.h:

(JSC::Arguments::setRegisters): No need for setRegisters anymore because
the activation object's storage doesn't change.

  • runtime/JSActivation.cpp:

(JSC::JSActivation::JSActivation): Initialize our storage manually because
it's not declared to the C++ compiler.

(JSC::JSActivation::visitChildren): No copyAndAppend because our storage
is not out-of-line anymore.

(JSC::JSActivation::symbolTableGet):
(JSC::JSActivation::symbolTablePut):
(JSC::JSActivation::getOwnPropertyNames):
(JSC::JSActivation::symbolTablePutWithAttributes):
(JSC::JSActivation::getOwnPropertySlot):
(JSC::JSActivation::getOwnPropertyDescriptor):
(JSC::JSActivation::argumentsGetter): Refactored isTornOff() testing to
avoid using a data member and to avoid hard-coding any offset assumptions.

  • runtime/JSActivation.h:

(JSC):
(JSActivation):
(JSC::JSActivation::create):
(JSC::JSActivation::isDynamicScope):
(JSC::JSActivation::captureStart):
(JSC::JSActivation::storageSize):
(JSC::JSActivation::storageSizeInBytes):
(JSC::JSActivation::registerOffset):
(JSC::JSActivation::tearOff):
(JSC::JSActivation::isTornOff):
(JSC::JSActivation::storage):
(JSC::JSActivation::allocationSize):
(JSC::JSActivation::isValid): New helper functions for doing the math
on our inline storage. Note that in the "AllOfTheThings" tear-off case,
the number of things is not known at compile time, so we store the
number in the argument count register. We can't just copy the raw contents
of the register beacuse we need a value that is safe for precise marking,
and the value in the register file has an invalid tag.

  • runtime/JSCell.h:

(JSC::allocateCell): New function for allocating with extra storage
on the end.

  • runtime/JSSymbolTableObject.h:

(JSC::JSSymbolTableObject::JSSymbolTableObject):
(JSC::JSSymbolTableObject::finishCreation):

  • runtime/JSVariableObject.h:

(JSC::JSVariableObject::JSVariableObject):
(JSVariableObject): Make it easier for subclasses to use their symbol
tables during construction, by passing the table as a constructor argument.

  • runtime/SymbolTable.h:

(JSC::SharedSymbolTable::usesNonStrictEval):
(JSC::SharedSymbolTable::setUsesNonStrictEval):
(SharedSymbolTable):
(JSC::SharedSymbolTable::captureMode):
(JSC::SharedSymbolTable::setCaptureMode):
(JSC::SharedSymbolTable::captureStart):
(JSC::SharedSymbolTable::setCaptureStart):
(JSC::SharedSymbolTable::captureEnd):
(JSC::SharedSymbolTable::setCaptureEnd):
(JSC::SharedSymbolTable::parameterCountIncludingThis):
(JSC::SharedSymbolTable::setParameterCountIncludingThis):
(JSC::SharedSymbolTable::SharedSymbolTable): Added data members to more
precisely describe what kind of capture is in play, and to avoid having
data members in the activation. We expect N activations per symbol table,
so this can be a big savings in heavy closure usage.

8:36 PM Changeset in webkit [128259] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix build break with LLINT on 32bit machine after r128219
https://bugs.webkit.org/show_bug.cgi?id=96461

Unreviewed build fix.

  • llint/LowLevelInterpreter32_64.asm: Fixed typo.
8:35 PM Changeset in webkit [128258] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium/mac] Fix "Class WebCoreTextFieldCell is implemented in both Chromium Framework and /System/Library/Frameworks/WebKit.framework" warning
https://bugs.webkit.org/show_bug.cgi?id=96460

Reviewed by Kent Tamura.

This was added incorrectly in http://trac.webkit.org/changeset/116721

  • WebCore.gyp/WebCore.gyp:
7:24 PM Changeset in webkit [128257] by keishi@webkit.org
  • 4 edits in trunk/Source

Create Localizer factory method for LocaleICU
https://bugs.webkit.org/show_bug.cgi?id=96363

Reviewed by Kent Tamura.

Source/WebCore:

Preparing to use Localizer instead of LocaleMac/Win/ICU

No new tests. Covered in unit test tests/LocalizedNumberICUTest.cpp

  • platform/text/LocaleICU.cpp:

(WebCore::Localizer::create):
(WebCore):

Source/WebKit/chromium:

  • tests/LocalizedNumberICUTest.cpp:

(testNumberIsReversible):
(testDecimalSeparator):

6:57 PM Changeset in webkit [128256] by msaboff@apple.com
  • 1 edit
    1 add in trunk/Source/WebCore

Build fixed for http://trac.webkit.org/changeset/128243

Unreviewed build fix.

Added missing include file needed by 96422 for C++ ICU APIs.

  • icu/unicode/chariter.h: Added.
6:46 PM Changeset in webkit [128255] by msaboff@apple.com
  • 1 edit
    7 adds in trunk/Source/WebCore

Build fixed for http://trac.webkit.org/changeset/128243

Unreviewed build fix.

Added missing include file needed by 96422 for C++ ICU APIs.

  • icu/unicode/bytestream.h: Added.
  • icu/unicode/rep.h: Added.
  • icu/unicode/std_string.h: Added.
  • icu/unicode/strenum.h: Added.
  • icu/unicode/stringpiece.h: Added.
  • icu/unicode/unistr.h: Added.
  • icu/unicode/uobject.h: Added.
6:42 PM Changeset in webkit [128254] by tkent@chromium.org
  • 5 edits in trunk/Source/WebCore

Refactor ValidationMessage class
https://bugs.webkit.org/show_bug.cgi?id=96365

Reviewed by Hajime Morita.

  • Move some code from HTMLFormControlElement to ValidationMessage
  • ValidationMessage class holds an element pointer as

HTMLFormControlElement, not FormAssociatedElement.

No new tests because of no behavior changes.

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::updateVisibleValidationMessage):
Moved some code to ValidationMessage::updateValidationMessage().
(WebCore::HTMLFormControlElement::setNeedsValidityCheck):
Ask ValidationMessage whether it is visible or not.

  • html/HTMLFormControlElement.h:

(HTMLFormControlElement): Removed visibleValidationMessage().

  • html/ValidationMessage.cpp:

(WebCore::ValidationMessage::ValidationMessage):
Change the argument type: FormAssociatedElement -> HTMLFormControlElement
(WebCore::ValidationMessage::create): ditto.
(WebCore::ValidationMessage::updateValidationMessage):
Added. Moved some code from
HTMLFormControlElement::updateVisibleValidationMessage().
(WebCore::ValidationMessage::buildBubbleTree): toHTMLElement() is not needed.
(WebCore::ValidationMessage::deleteBubbleTree): ditto.
(WebCore::ValidationMessage::isVisible): Added.

  • html/ValidationMessage.h:

(ValidationMessage):

  • Change some instance of FormAssociatedElement to HTMLFormControlElement
  • Remove message().
  • Added updateValidationMessage() and isVisible()
  • Made setMessage() private.
6:35 PM Changeset in webkit [128253] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[chromium] Make prioritized texture manager not touch backings array on the main thread
https://bugs.webkit.org/show_bug.cgi?id=96114

Patch by Christopher Cameron <ccameron@chromium.org> on 2012-09-11
Reviewed by James Robinson.

Take a snapshot of the textures' priorities from the main thread,
and save it in their backings for access by the impl thread.
Update functions that access the sorted backings array to use the
snapshotted values instead of the values that the main thread may
have computed for the next frame.

Make the main thread not touch the m_backings array. Split
prioritizeTextures into a updateBackingsPriorities function.
In places where the main thread would have touched m_backings,
set a flag specifying that m_backings needs to be re-sorted
before any function that requires it be sorted by priority be
executed.

Update the two functions that require sorted order (acquireBacking
and reduceMemory) to sort the backings array (if needed) before
traversing it.

Updated tests to set correct thread during asserts. Add a test to
verify that requestLate is correctly incorporated into the backing
sorting.

Source/WebCore:

  • platform/graphics/chromium/cc/CCPrioritizedTextureManager.cpp:

(WebCore::CCPrioritizedTextureManager::CCPrioritizedTextureManager):
(WebCore::CCPrioritizedTextureManager::prioritizeTextures):
(WebCore):
(WebCore::CCPrioritizedTextureManager::prioritizeBackings):
(WebCore::CCPrioritizedTextureManager::requestLate):
(WebCore::CCPrioritizedTextureManager::acquireBackingTextureIfNeeded):
(WebCore::CCPrioritizedTextureManager::reduceMemory):
(WebCore::CCPrioritizedTextureManager::returnBackingTexture):
(WebCore::CCPrioritizedTextureManager::destroyBacking):
(WebCore::CCPrioritizedTextureManager::assertInvariants):

  • platform/graphics/chromium/cc/CCPrioritizedTextureManager.h:

(CCPrioritizedTextureManager):

Source/WebKit/chromium:

  • tests/CCPrioritizedTextureTest.cpp:

(WTF::CCPrioritizedTextureTest::validateTexture):

6:25 PM Changeset in webkit [128252] by msaboff@apple.com
  • 1 edit
    7 adds in trunk/Source/WTF

Build fixed for http://trac.webkit.org/changeset/128243

Unreviewed build fix.

Added missing include file needed by 96422 for C++ ICU APIs.

  • icu/unicode/bytestream.h: Added.
  • icu/unicode/rep.h: Added.
  • icu/unicode/std_string.h: Added.
  • icu/unicode/strenum.h: Added.
  • icu/unicode/stringpiece.h: Added.
  • icu/unicode/unistr.h: Added.
  • icu/unicode/uobject.h: Added.
6:01 PM Changeset in webkit [128251] by abarth@webkit.org
  • 13 edits in trunk/Source/WebCore

Update bindings test results after http://trac.webkit.org/changeset/128242

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::V8Float64Array::wrapSlow):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::wrapSlow):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::wrapSlow):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::wrapSlow):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::V8TestEventTarget::wrapSlow):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::wrapSlow):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::wrapSlow):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::wrapSlow):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::wrapSlow):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::wrapSlow):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::wrapSlow):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):

5:53 PM Changeset in webkit [128250] by msaboff@apple.com
  • 4 edits
    4 adds in trunk/Source

Build fixed for http://trac.webkit.org/changeset/128243

Rubber stamped by Stephanie Lewis.

Added missing include file needed by 96422.

  • icu/unicode/unorm2.h: Added.
5:41 PM Changeset in webkit [128249] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk/Source/WebCore

Add new JSDependentRetained that allows keeping a JSObject alive as long as another is alive
https://bugs.webkit.org/show_bug.cgi?id=96034

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-09-11
Reviewed by Geoffrey Garen.

Add new JSDependentRetained (with the same API as V8DependentRetained) that allows keeping
a JSObject alive as long as another is alive. This is useful for keeping callbacks on
wrappers without keeping strong references into the JS heap in C++ which can result in
cycles that create memory leaks.

No new tests needed, this will be used to fix MutationObservers and UndoManager which will have tests.

  • GNUmakefile.list.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDependentRetained.h: Added.

(WebCore):
(JSDependentRetained):
(WebCore::JSDependentRetained::JSDependentRetained):
(WebCore::JSDependentRetained::~JSDependentRetained):
(WebCore::JSDependentRetained::get): Get the JSObject value.
(WebCore::JSDependentRetained::isEmpty): Check if the value is still alive.
(WebCore::JSDependentRetained::retain): Sets the owner of the object, should only be used once.
(WebCore::JSDependentRetained::release):

  • bindings/v8/V8DependentRetained.h:

(WebCore::V8DependentRetained::V8DependentRetained):
(WebCore::V8DependentRetained::retain): Added this method so the API for JSC and V8 are identical.

5:35 PM Changeset in webkit [128248] by commit-queue@webkit.org
  • 13 edits in trunk/Source/WebCore

Add 'any' type to V8 bindings as a synonym for DOMObject
https://bugs.webkit.org/show_bug.cgi?id=96429

Patch by Alec Flett <alecflett@chromium.org> on 2012-09-11
Reviewed by Kentaro Hara.

Adds support for 'any' as a synonym to DOMObject.

Test: TestObj.idl has an attribute 'anyAttribute'.

  • bindings/scripts/CodeGeneratorJS.pm:

(AddIncludesForType):
(JSValueToNative):
(NativeToJSValue):

  • bindings/scripts/CodeGeneratorV8.pm:

(GetNativeType):
(JSValueToNative):
(GetV8HeaderName):

  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:

(WebDOMTestObj::anyAttribute):
(WebDOMTestObj::setAnyAttribute):

  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
(webkit_dom_test_obj_get_any_attribute):
(webkit_dom_test_obj_set_any_attribute):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):
(WebCore::jsTestObjCachedAttribute1):
(WebCore::jsTestObjCachedAttribute2):
(WebCore::jsTestObjAnyAttribute):
(WebCore::setJSTestObjAnyAttribute):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj anyAttribute]):
(-[DOMTestObj setAnyAttribute:]):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::cachedAttribute1AttrGetter):
(WebCore::TestObjV8Internal::cachedAttribute2AttrGetter):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::anyAttributeAttrGetter):
(WebCore::TestObjV8Internal::anyAttributeAttrSetter):
(WebCore):

5:25 PM Changeset in webkit [128247] by msaboff@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for http://trac.webkit.org/changeset/128244

Some compilers don't like 0 for operator[](unsigned). Changed to 0u.

  • bindings/js/JSDOMBinding.h:

(WebCore::jsStringWithCache):

5:09 PM Changeset in webkit [128246] by msaboff@apple.com
  • 4 edits
    4 adds in trunk/Source

Build fixed for http://trac.webkit.org/changeset/128243

Rubber stamped by Stephanie Lewis.

Added missing include file needed by 96422.

  • icu/unicode/ptypes.h: Added.
5:00 PM Changeset in webkit [128245] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

Accelerated compositing should always be forced when using the tiled drawing area
https://bugs.webkit.org/show_bug.cgi?id=96449

Reviewed by Andy Estes.

There's code in WebPage::updatePreferences that will turn off accelerated compositing unless accelerated drawing is enabled.
This should only be done in the non-tiled model, so move the code to DrawingAreaImpl::updatePreferences.

  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::updatePreferences):
This now takes a WebPreferencesStore.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::updatePreferences):
Move code here from WebPage::updatePreferences.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
Pass the WebPreferencesStore to DrawingArea::updatePreferences.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
Remove call to updatePreferences, it's going to be called by the WebPage object later.

(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):
This now takes a WebPreferencesStore.

4:53 PM Changeset in webkit [128244] by msaboff@apple.com
  • 2 edits in trunk/Source/WebCore

jsStringWithCache shouldn't call StringImpl::characters() for single character strings
https://bugs.webkit.org/show_bug.cgi?id=96439

Reviewed by Geoffrey Garen.

Replaced StringImpl->characters()[0] with operator[] access which is character size aware.
Also fixed the other FIXME so we now use SmallStrings to retunr the single character string.

No functional change, so no new tests.

  • bindings/js/JSDOMBinding.h:

(WebCore::jsStringWithCache):

4:50 PM Changeset in webkit [128243] by msaboff@apple.com
  • 93 edits
    9 adds in trunk/Source

Update ICU header files to more recent version
https://bugs.webkit.org/show_bug.cgi?id=96422

Reviewed by Geoff Garen.

Updated ICU header files to 4.6.1. Modifications made as part of the merge are:
platform.h - Changed ifndef / define / endif for U_HAVE_UINT8_T, U_HAVE_UINT16_T, U_HAVE_UINT32_T,

U_HAVE_UINT64_T, U_IS_BIG_ENDIAN and U_ENABLE_TRACING to match the existing platform.h

putil.h (line 132) - Changes defined(U_WINDOWS) to defined(WIN32)
defined(OS2) to match existing putil.h

ustring.h (line 945) - Wrapped macro argument cs with { (const UChar *)cs } to match existing ustring.h
utypes.h (line 545) - Changed defined(U_WINDOWS) to defined(WIN32) to match existing utypes.h

Source/JavaScriptCore:

  • icu/unicode/localpointer.h: Added.
  • icu/unicode/parseerr.h:
  • icu/unicode/platform.h:
  • icu/unicode/putil.h:
  • icu/unicode/uchar.h:
  • icu/unicode/ucnv.h:
  • icu/unicode/ucnv_err.h:
  • icu/unicode/ucol.h:
  • icu/unicode/uconfig.h:
  • icu/unicode/uenum.h:
  • icu/unicode/uiter.h:
  • icu/unicode/uloc.h:
  • icu/unicode/umachine.h:
  • icu/unicode/unorm.h:
  • icu/unicode/urename.h:
  • icu/unicode/uscript.h:
  • icu/unicode/uset.h:
  • icu/unicode/ustring.h:
  • icu/unicode/utf.h:
  • icu/unicode/utf16.h:
  • icu/unicode/utf8.h:
  • icu/unicode/utypes.h:
  • icu/unicode/uvernum.h: Added.
  • icu/unicode/uversion.h:

Source/WebCore:

Updated include files without any function change so no new tests.

  • icu/unicode/localpointer.h: Added.
  • icu/unicode/parseerr.h:
  • icu/unicode/platform.h:
  • icu/unicode/putil.h:
  • icu/unicode/ubrk.h:
  • icu/unicode/uchar.h:
  • icu/unicode/ucnv.h:
  • icu/unicode/ucnv_err.h:
  • icu/unicode/ucol.h:
  • icu/unicode/ucoleitr.h:
  • icu/unicode/uconfig.h:
  • icu/unicode/ucsdet.h:
  • icu/unicode/uenum.h:
  • icu/unicode/uidna.h:
  • icu/unicode/uiter.h:
  • icu/unicode/uloc.h:
  • icu/unicode/umachine.h:
  • icu/unicode/unorm.h:
  • icu/unicode/urename.h:
  • icu/unicode/uscript.h:
  • icu/unicode/usearch.h:
  • icu/unicode/uset.h:
  • icu/unicode/ushape.h:
  • icu/unicode/ustring.h:
  • icu/unicode/utext.h: Added.
  • icu/unicode/utf.h:
  • icu/unicode/utf16.h:
  • icu/unicode/utf8.h:
  • icu/unicode/utypes.h:
  • icu/unicode/uvernum.h: Added.
  • icu/unicode/uversion.h:

Source/WebKit/mac:

  • icu/unicode/localpointer.h: Added.
  • icu/unicode/parseerr.h:
  • icu/unicode/platform.h:
  • icu/unicode/putil.h:
  • icu/unicode/uchar.h:
  • icu/unicode/uconfig.h:
  • icu/unicode/uidna.h:
  • icu/unicode/uiter.h:
  • icu/unicode/umachine.h:
  • icu/unicode/unorm.h:
  • icu/unicode/urename.h:
  • icu/unicode/uscript.h:
  • icu/unicode/ustring.h:
  • icu/unicode/utf.h:
  • icu/unicode/utf16.h:
  • icu/unicode/utf8.h:
  • icu/unicode/utypes.h:
  • icu/unicode/uvernum.h: Added.
  • icu/unicode/uversion.h:

Source/WTF:

  • icu/unicode/localpointer.h: Added.
  • icu/unicode/parseerr.h:
  • icu/unicode/platform.h:
  • icu/unicode/putil.h:
  • icu/unicode/uchar.h:
  • icu/unicode/ucnv.h:
  • icu/unicode/ucnv_err.h:
  • icu/unicode/ucol.h:
  • icu/unicode/uconfig.h:
  • icu/unicode/uenum.h:
  • icu/unicode/uiter.h:
  • icu/unicode/uloc.h:
  • icu/unicode/umachine.h:
  • icu/unicode/unorm.h:
  • icu/unicode/urename.h:
  • icu/unicode/uscript.h:
  • icu/unicode/uset.h:
  • icu/unicode/ustring.h:
  • icu/unicode/utf.h:
  • icu/unicode/utf16.h:
  • icu/unicode/utf8.h:
  • icu/unicode/utypes.h:
  • icu/unicode/uvernum.h: Added.
  • icu/unicode/uversion.h:
4:49 PM Changeset in webkit [128242] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[V8] 8% regression in dom_perf
https://bugs.webkit.org/show_bug.cgi?id=96433

Patch by Adam Barth <abarth@chromium.org> on 2012-09-11
Reviewed by Kentaro Hara.

This code used to have a fast path to find the V8PerContextData for DOM
nodes. I tried a bunch of variations, but nothing I can come up with is
as fast as the old fast path, so I've added back the fast path.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateToV8Converters):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::instantiateV8Object):

  • bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):

4:42 PM Changeset in webkit [128241] by psolanki@apple.com
  • 2 edits in trunk/Source/WTF

Add ObjcRuntimeExtras.h to the Xcode project file
https://bugs.webkit.org/show_bug.cgi?id=96419

Reviewed by Alexey Proskuryakov.

  • WTF.xcodeproj/project.pbxproj:
4:31 PM Changeset in webkit [128240] by Stephanie Lewis
  • 2 edits in trunk/LayoutTests

Skip spatial-navigation tests on mac-wk2 because they are all failing.
https://bugs.webkit.org/show_bug.cgi?id=96438.

Unreviewed.

  • platform/mac-wk2/TestExpectations:
4:26 PM Changeset in webkit [128239] by kling@webkit.org
  • 5 edits in trunk/Source/WebCore

ElementAttributeData: Use subclasses to manage varying object layouts.
<http://webkit.org/b/94465>

Reviewed by Antti Koivisto.

Add two ElementAttributeData subclasses:

  • MutableElementAttributeData
  • ImmutableElementAttributeData

The ElementAttributeData::m_isMutable bit determines which subclass to cast to when accessing
the attribute storage. Added mutableAttributeVector() and immutableAttributeArray() helpers
to ElementAttributeData (with appropriate assertions.)

This patch removes one step of indirection in the mutable case, since the Vector<Attribute> is no
longer heap-allocated, but part of MutableElementAttributeData.

Added a WTF::deleteOwnedPtr(ElementAttributeData*) specialization so that the appropriate subclass
destructor is called for these objects.

  • WebCore.exp.in:
  • dom/Element.cpp:

(WebCore::Element::createMutableAttributeData):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::createImmutable):
(WebCore::ElementAttributeData::create):
(WebCore::ElementAttributeData::ElementAttributeData):
(WebCore::MutableElementAttributeData::MutableElementAttributeData):
(WebCore::ImmutableElementAttributeData::ImmutableElementAttributeData):
(WebCore::ImmutableElementAttributeData::~ImmutableElementAttributeData):
(WebCore::ElementAttributeData::makeMutableCopy):
(WebCore::ElementAttributeData::addAttribute):
(WebCore::ElementAttributeData::removeAttribute):
(WebCore::ElementAttributeData::reportMemoryUsage):
(WebCore::ElementAttributeData::cloneDataFrom):
(WebCore::ElementAttributeData::clearAttributes):

  • dom/ElementAttributeData.h:

(ElementAttributeData):
(WebCore::ElementAttributeData::isMutable):
(ImmutableElementAttributeData):
(MutableElementAttributeData):
(WebCore::MutableElementAttributeData::MutableElementAttributeData):
(WebCore::ElementAttributeData::immutableAttributeArray):
(WebCore::ElementAttributeData::mutableAttributeVector):
(WebCore::ElementAttributeData::length):
(WebCore::ElementAttributeData::attributeItem):

4:20 PM Changeset in webkit [128238] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

Pass the logical height and logical top into RenderBox::computeLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=96432

Reviewed by Ojan Vafai.

This allows us to call RenderBox::computeLogicalHeight without first having to call
setLogicalHeight() and setLogicalTop(). Previously, computeLogicalHeight would depend
on these values.

No new tests, this is just a refactor.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::updateLogicalHeight): Pass logicalHeight and logicalTop as params.
(WebCore::RenderBox::computeLogicalHeight): Use passed in values instead of calling logicalHeight/logicalTop.
(WebCore::RenderBox::computePositionedLogicalHeight): Pass the logicalHeight into computePositionedLogicalHeightUsing.
(WebCore::RenderBox::computePositionedLogicalHeightUsing): Pass in the logicalHeight as a parameter.

  • rendering/RenderBox.h:

(RenderBox): Update computePositionedLogicalHeightUsing and computeLogicalHeight.

4:18 PM Changeset in webkit [128237] by jsbell@chromium.org
  • 2 edits in trunk/Source/WebCore

IndexedDB: Optimize key decode and comparison operations
https://bugs.webkit.org/show_bug.cgi?id=96037

Reviewed by Tony Chang.

Eliminate memory allocations in code identified as CPU bottlenecks in IDB profiling.

No new tests - just performance work.

  • Modules/indexeddb/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::extractEncodedIDBKey): Avoid incremental allocations.
(WebCore::IDBLevelDBCoding::compareEncodedIDBKeys): Rename confusing variables p and q.
(IDBLevelDBCoding):
(WebCore::IDBLevelDBCoding::compare): Rename from decodeAndCompare, and add specializations
for frequently encountered types (e.g. object/index data) that can be compared without a
full decode.

4:17 PM Changeset in webkit [128236] by beidson@apple.com
  • 6 edits in trunk/Source/WebKit2

Get rid of the PluginProcessShim for 64-bit plug-ins
<rdar://problem/12068560> and https://bugs.webkit.org/show_bug.cgi?id=96415

Reviewed by Anders Carlsson.

  • PluginProcess/PluginProcess.h:

(PluginProcess):

  • PluginProcess/mac/PluginProcessMac.mm:

(WebKit::getCurrentEventButtonState):
(WebKit):
(WebKit::beginModal): Moved from the shim, to be shared with shimmed processes.
(WebKit::endModal): Ditto.
(WebKit::replacedRunModalForWindow): Only used by Cocoa overrides.
(WebKit::PluginProcess::initializeShim):
(WebKit::PluginProcess::initializeCocoaOverrides):

  • PluginProcess/mac/PluginProcessMainMac.mm:

(WebKit::PluginProcessMain): Only call initializeShim for 32-bit processes, always call initializeCocoaOverrides

  • PluginProcess/mac/PluginProcessShim.h:

(PluginProcessShimCallbacks):

  • PluginProcess/mac/PluginProcessShim.mm:

(WebKit):
(WebKit::shimModalDialog): Call beginModal/endModal from the shim callbacks.
(WebKit::shimAlert): Ditto.
(WebKit::WebKitPluginProcessShimInitialize): Don't do the Cocoa overrides as they are now handled outside the shim.

4:08 PM Changeset in webkit [128235] by adamk@chromium.org
  • 5 edits
    7 deletes in trunk

Unreviewed, rolling out r128075
https://bugs.webkit.org/show_bug.cgi?id=96435

Source/WebCore:

Broke chromium content_browsertests and included flaky layout tests

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
(WebCore::MediaControlRootElementChromium::reset):
(WebCore::MediaControlRootElementChromium::playbackStarted):
(WebCore::MediaControlRootElementChromium::playbackProgressed):
(WebCore::MediaControlRootElementChromium::playbackStopped):
(WebCore::MediaControlRootElementChromium::updateTimeDisplay):

  • html/shadow/MediaControlRootElementChromium.h:

(MediaControlPanelEnclosureElement):
(MediaControlRootElementChromium):

LayoutTests:

  • platform/chromium-mac/platform/chromium/media/controls-video-sizes-expected.png: Removed.
  • platform/chromium/TestExpectations:
  • platform/chromium/media/controls-audio-sizes-expected.txt: Removed.
  • platform/chromium/media/controls-audio-sizes.html: Removed.
  • platform/chromium/media/controls-video-sizes-expected.txt: Removed.
  • platform/chromium/media/controls-video-sizes-padding-expected.txt: Removed.
  • platform/chromium/media/controls-video-sizes-padding.html: Removed.
  • platform/chromium/media/controls-video-sizes.html: Removed.
4:06 PM Changeset in webkit [128234] by mlilek@apple.com
  • 10 edits in trunk/Source

OS X port should compile with newer versions of clang
https://bugs.webkit.org/show_bug.cgi?id=96434

Source/JavaScriptCore:

m_identIsVarDecl is unused - remove it.

Reviewed by Anders Carlsson.

  • parser/NodeConstructors.h:

(JSC::ForInNode::ForInNode):

  • parser/Nodes.h:

(ForInNode):

Source/WebCore:

Reviewed by Anders Carlsson.

Guard m_hasTouchEventHandler behind ENABLE(TOUCH_EVENTS).

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::HTMLInputElement):

  • html/HTMLInputElement.h:

(HTMLInputElement):

Fix uninitialized variable.

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::createLinearSRGBColorSpace):

Source/WebKit/mac:

m_isTerminated is unused in the Hosted flavor of NetscapePluginStream.

Reviewed by Anders Carlsson.

  • Plugins/Hosted/HostedNetscapePluginStream.h:

(HostedNetscapePluginStream):

  • Plugins/Hosted/HostedNetscapePluginStream.mm:

(WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream):

4:04 PM Changeset in webkit [128233] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

Suppress image failures for gradient-with-scaled-ancestor.html due to
scrollbar diffs.

  • platform/chromium/TestExpectations:
3:47 PM Changeset in webkit [128232] by dpranke@chromium.org
  • 2 edits in trunk/Tools

[chromium] rename webkit_resources
https://bugs.webkit.org/show_bug.cgi?id=95874

Reviewed by James Robinson.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3:32 PM Changeset in webkit [128231] by commit-queue@webkit.org
  • 9 edits in trunk

[Gtk] allow building with css-shaders
https://bugs.webkit.org/show_bug.cgi?id=95603

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-09-11
Reviewed by Martin Robinson.

.:

if unstable features and accelerated compositing are turned on, and
acceleration backend is opengl, then build CSS Shaders and CSS
Filters.

  • configure.ac:

Source/WebCore:

Add support for css filters and shaders in GNUmakefile.am and include
Texture.cpp, Texture.h, TilingData.cpp and TilingData.h in
webcore_sources

No functional change, so no new tests.

  • GNUmakefile.am:
  • GNUmakefile.list.am:

Source/WebKit/gtk:

Add enable-css-shaders property to WebKit WebSettings, and connects it
to WebCore settings setCSSCustomFilterEnabled.

  • webkit/webkitwebsettings.cpp:

(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):

  • webkit/webkitwebsettingsprivate.h:
  • webkit/webkitwebview.cpp:

(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):

3:25 PM Changeset in webkit [128230] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] add a way to overscroll non-overflown content
https://bugs.webkit.org/show_bug.cgi?id=96331
PR #195305

Patch by Antonio Gomes <agomes@rim.com> on 2012-09-11
Reviewed by Yong Li.

Check -webkit-overflow-scrolling value for '-blackberry-touch' instead
of checking a custom HTML5 attribute.

No behavioural change. Mostly a rework of r128142.

  • Api/InRegionScroller.cpp:

(BlackBerry::WebKit::canScrollRenderBox):

3:25 PM Changeset in webkit [128229] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Update some expectations to reference specific bugs.

  • platform/chromium/TestExpectations:
3:02 PM Changeset in webkit [128228] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

Remove StyleResolver::setStyle, because it's no longer used.
https://bugs.webkit.org/show_bug.cgi?id=96423

Reviewed by Eric Seidel.

No new tests, simple refactoring.

  • css/StyleResolver.h: Removed unused function.
3:00 PM Changeset in webkit [128227] by Chris Fleizach
  • 3 edits
    2 adds in trunk

AX: title attribute is not exposed as the AXDescription on AXImage when there is no other fallback content
https://bugs.webkit.org/show_bug.cgi?id=96412

Reviewed by Jon Honeycutt.

Source/WebCore:

Ensure that if an image has a title attribute, but no alt attribute, it will fallback to use the title attribute
for the descriptive text.

Test: accessibility/img-fallsback-to-title.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityDescription):

LayoutTests:

  • accessibility/img-fallsback-to-title.html: Added.
  • platform/mac/accessibility/img-fallsback-to-title-expected.txt: Added.
2:29 PM Changeset in webkit [128226] by rwlbuis@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] make pickers/dialogs use appendLiteral
https://bugs.webkit.org/show_bug.cgi?id=96424

Reviewed by Antonio Gomes.

PR 204032

Other pickers were updated in r128204.

  • WebCoreSupport/ColorPickerClient.cpp:

(WebCore::ColorPickerClient::generateHTML):

  • WebCoreSupport/PagePopupBlackBerry.cpp:

(WebCore::PagePopupBlackBerry::generateHTML):

2:10 PM Changeset in webkit [128225] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Clean up functions in RenderLayerBacking.h/.cpp
https://bugs.webkit.org/show_bug.cgi?id=96370

Patch by Rik Cabanier <cabanier@adobe.com> on 2012-09-11
Reviewed by Simon Fraser.

Remove 'layer' from function names in RenderLayerBacking

No new test. No change in functionality.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
(WebCore::RenderLayerBacking::updateOpacity):
(WebCore::RenderLayerBacking::updateTransform):
(WebCore::RenderLayerBacking::updateFilters):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::startTransition):

  • rendering/RenderLayerBacking.h:

(RenderLayerBacking):

2:03 PM Changeset in webkit [128224] by jochen@chromium.org
  • 2 edits in trunk/Tools

[chromium] don't include content shell builders in the garden-o-matic view
https://bugs.webkit.org/show_bug.cgi?id=96418

Reviewed by James Robinson.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1:54 PM Changeset in webkit [128223] by senorblanco@chromium.org
  • 6 edits
    1 add in trunk

Source/WebCore: [skia] Switch FEComponentTransfer filter to use skia's SkColorFilter
https://bugs.webkit.org/show_bug.cgi?id=95238

Reviewed by Dirk Schulze.

Covered by existing tests in svg/, such as svg/custom/feComponentTransfer-Discrete.svg.

  • WebCore.gypi:
  • platform/graphics/filters/FEComponentTransfer.cpp:

(WebCore::FEComponentTransfer::platformApplySoftware):
Add a check for the skia implementation.
(WebCore::FEComponentTransfer::getValues):

  • platform/graphics/filters/FEComponentTransfer.h:

Factor out the retrieval of LUT values into its own function, so we
can call it from the Skia implementation.

  • platform/graphics/filters/skia/FEComponentTransferSkia.cpp: Added.

(WebCore::FEComponentTransfer::platformApplySkia):

LayoutTests: [chromium] Mark some tests as needing a rebaseline due to SVG filters change.
https://bugs.webkit.org/show_bug.cgi?id=95238

Reviewed by Dirk Schulze.

  • platform/chromium/TestExpectations:
1:36 PM Changeset in webkit [128222] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Crash on a long press gesture when touch adjustment is enabled.
https://bugs.webkit.org/show_bug.cgi?id=96313

Patch by Kevin Ellis <kevers@chromium.org> on 2012-09-11
Reviewed by Antonio Gomes.

Source/WebCore:

Fix to ensure that a long-press on a shadow-DOM element does not
trigger a crash in TouchAdjustment::providesContextMenuItems.
Prior to the patch, a null-pointer exception was trigger because
of a null renderer in the check.

Test: touchadjustment/context-menu-shadow-node.html

  • page/TouchAdjustment.cpp:

(WebCore::TouchAdjustment::providesContextMenuItems):

LayoutTests:

Add test to ensure that a long-press on a shadow DOM element does
not trigger a crash when determining if an element provides a context
menu.

  • touchadjustment/context-menu-shadow-node-expected.txt: Added.
  • touchadjustment/context-menu-shadow-node.html: Added.
1:34 PM Changeset in webkit [128221] by zandobersek@gmail.com
  • 3 edits
    2 deletes in trunk

Unreviewed, manually rolling out r128175.
The patch is causing crashes in debug builds.
http://trac.webkit.org/changeset/128175
https://bugs.webkit.org/show_bug.cgi?id=96284

Source/WebCore:

  • platform/network/soup/ResourceResponseSoup.cpp:

(WebCore::ResourceResponse::updateFromSoupMessage):

LayoutTests:

  • http/tests/misc/non-utf8-header-name-expected.txt: Removed.
  • http/tests/misc/non-utf8-header-name.php: Removed.
1:14 PM Changeset in webkit [128220] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r128212.
http://trac.webkit.org/changeset/128212
https://bugs.webkit.org/show_bug.cgi?id=96037

Assertion fails on linux 64

  • Modules/indexeddb/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::extractEncodedIDBKey):
(WebCore::IDBLevelDBCoding::compareEncodedIDBKeys):
(IDBLevelDBCoding):
(WebCore::IDBLevelDBCoding::compare):

1:00 PM Changeset in webkit [128219] by fpizlo@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

LLInt should optimize and profile array length accesses
https://bugs.webkit.org/show_bug.cgi?id=96417

Reviewed by Oliver Hunt.

This fixes the following hole in our array profiling strategy, where the array
is large (more than 1000 elements):

for (var i = 0; i < array.length; ++i) ...

The peeled use of array.length (in the array prologue) will execute only once
before DFG optimization kicks in from the loop's OSR point. Since it executed
only once, it executed in the LLInt. And prior to this patch, the LLInt did
not profile array.length accesses - so the DFG will assume, based on the lack
of profiling, that the access is in fact not an access to the JSArray length
property. That could then impede our ability to hoist the array structure
check, and may make us pessimistic in other ways as well, since the generic
GetById used for the array length access will be viewed as a side-effecting
operation.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printGetByIdCacheStatus):
(JSC::CodeBlock::finalizeUnconditionally):

  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFromLLInt):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
12:17 PM Changeset in webkit [128218] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-11

  • DEPS:
12:17 PM Changeset in webkit [128217] by jsbell@chromium.org
  • 6 edits in trunk/Source

IndexedDB: IDBObjectStore.count() is slow
https://bugs.webkit.org/show_bug.cgi?id=96033

Reviewed by Tony Chang.

Avoid decoding record values when performing count() iteration, and factor out common code
used for initializing object store and index cursors. Also, remove unused indexDataId()
methods (which date back to the SQLite backing store), and rename some p's and q's.

No new tests - no functional changes. Covered by existing test:

LayoutTests/storage/indexeddb/objectstore-count.html

  • Modules/indexeddb/IDBBackingStore.h: Expose new (internal) ObjectStoreKeyCursor

(IDBBackingStore):

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore): Factor out common CursorOptions initialization code. The objectStoreCursorOptions()
function is needed for this patch. The indexCursorOptions() function is not, but eliminates
duplicated code and is a nearly identical refactor.
(WebCore::IDBLevelDBBackingStore::openObjectStoreCursor): Refactor.
(WebCore::IDBLevelDBBackingStore::openObjectStoreKeyCursor): Implement.
(WebCore::IDBLevelDBBackingStore::openIndexKeyCursor): Refactor.
(WebCore::IDBLevelDBBackingStore::openIndexCursor): Ditto.

  • Modules/indexeddb/IDBLevelDBBackingStore.h:

(IDBLevelDBBackingStore):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::countInternal): Use ObjectStoreKeyCursor for iteration.

12:14 PM Changeset in webkit [128216] by adamk@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

Unreviewed chromium gardening.

Remove bogus rebaseline added in r128105, and remove "flaky"
expectation (since tests seems non-flaky).

  • platform/chromium-win-xp/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Removed.
  • platform/chromium/TestExpectations:
12:05 PM Changeset in webkit [128215] by ojan@chromium.org
  • 2 edits in trunk/Source/WebCore

Refactor computePercentageLogicalHeight to simplify the logic a bit
https://bugs.webkit.org/show_bug.cgi?id=96329

Reviewed by Tony Chang.

This makes it clear that the value we're computing as we go is the availableHeight.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePercentageLogicalHeight):

12:04 PM Changeset in webkit [128214] by adamk@chromium.org
  • 2 edits
    2 deletes in trunk/LayoutTests

Unreviewed chromium gardening.

Mark compositing/overflow/overflow-scaled-descendant-overflapping as
failing on cr-mac after r127789 and remove bad rebaselines.

  • platform/chromium-mac-snowleopard/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Removed.
  • platform/chromium-mac/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Removed.
  • platform/chromium/TestExpectations:
11:50 AM Changeset in webkit [128213] by adamk@chromium.org
  • 3 edits in trunk/Tools

Garden-o-matic should ignore a wider variety of warnings in buildbot json
https://bugs.webkit.org/show_bug.cgi?id=96411

Reviewed by Adam Barth.

Previously only the exact string "warning" was treated as a warning
result. This patch treats any string with "warning" as a substring
as a warning (e.g., "warnings", as seen on the cr-win buildbots).

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:

(.):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
11:42 AM Changeset in webkit [128212] by jsbell@chromium.org
  • 2 edits in trunk/Source/WebCore

IndexedDB: Optimize key decode and comparison operations
https://bugs.webkit.org/show_bug.cgi?id=96037

Reviewed by Tony Chang.

Eliminate memory allocations in code identified as CPU bottlenecks in IDB profiling.

No new tests - just performance work.

  • Modules/indexeddb/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::extractEncodedIDBKey): Avoid incremental allocations.
(WebCore::IDBLevelDBCoding::compareEncodedIDBKeys): Rename confusing variables p and q.
(IDBLevelDBCoding):
(WebCore::IDBLevelDBCoding::compare): Rename from decodeAndCompare, and add specializations
for frequently encountered types (e.g. object/index data) that can be compared without a
full decode.

11:32 AM Changeset in webkit [128211] by kpiascik@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Fix history navigation for error pages.
https://bugs.webkit.org/show_bug.cgi?id=96410

Reviewed by Rob Buis.

Fix how history navigation handles restoring view state when navigating between error pages.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::FrameLoaderClientBlackBerry):
(WebCore::FrameLoaderClientBlackBerry::saveViewStateToItem):
(WebCore::FrameLoaderClientBlackBerry::restoreViewState):

  • WebCoreSupport/FrameLoaderClientBlackBerry.h:

(FrameLoaderClientBlackBerry):

11:31 AM Changeset in webkit [128210] by commit-queue@webkit.org
  • 14 edits in trunk

Restore original value of mock scrollbars enabled in InternalSettings
https://bugs.webkit.org/show_bug.cgi?id=87680

Patch by Marcelo Lira <marcelo.lira@openbossa.org> on 2012-09-11
Reviewed by Adam Barth.

Added backup support for mock scrollbars state in
InternalSettings::Backup, and removed support for these
from Qt's DumpRenderTree.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):

  • testing/InternalSettings.h:

(Backup):

Source/WebKit/qt:

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Source/WebKit2:

  • win/WebKit2.def:

Tools:

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::resetSettings):

  • DumpRenderTree/qt/TestRunnerQt.cpp:

(TestRunner::setFrameFlatteningEnabled):

  • DumpRenderTree/qt/TestRunnerQt.h:

(TestRunner):

11:13 AM Changeset in webkit [128209] by dino@apple.com
  • 2 edits
    2 adds in trunk/Source/ThirdParty/ANGLE

[Apple] Install plist for Apple Open Source build system
https://bugs.webkit.org/show_bug.cgi?id=96345

Reviewed by Mark Rowe.

Apple's build system requires a couple of files that describe where
the 3rd party Open Source library came from, and what license it
uses. These files are copied into /usr/local when the project is
being installed.

  • ANGLE.plist: Added.
  • ANGLE.txt: Added.
  • ANGLE.xcodeproj/project.pbxproj:
11:12 AM Changeset in webkit [128208] by commit-queue@webkit.org
  • 35 edits in trunk

Improve console error messages when 'document.domain' blocks cross-origin script access.
https://bugs.webkit.org/show_bug.cgi?id=96247

Patch by Mike West <mkwst@chromium.org> on 2012-09-11
Reviewed by Adam Barth.

Source/WebCore:

Setting 'document.domain' can produce counterintuitive "cross-origin"
error messages for script access in cases where the property isn't set
to the same value in both the accessor and accessee. This patch adds a
bit more context to the error message to make it clear that both sides
must set the property, and that the values must match.

This shouldn't change any externally visible behavior other than the
error warnings. It's covered by changes to existing tests.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::crossDomainAccessErrorMessage):

Adding checks for 'document.domain'-related errors, and adding an
ASSERT that crossDomainAccessErrorMessage is called in cases where
the accessing frame is actually denied access to the frame being
accessed.

LayoutTests:

  • http/tests/security/cross-frame-access-callback-explicit-domain-DENY-expected.txt:
  • http/tests/security/cross-frame-access-child-explicit-domain-expected.txt:
  • http/tests/security/cross-frame-access-parent-explicit-domain-expected.txt:
  • http/tests/security/cross-frame-access-protocol-expected.txt:
  • http/tests/security/cross-frame-access-protocol-explicit-domain-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt:
  • http/tests/security/view-source-no-javascript-url-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt:
  • platform/chromium/http/tests/security/inactive-document-with-empty-security-origin-expected.txt:
  • platform/chromium/http/tests/security/window-named-proto-expected.txt:

Updating error message.

11:00 AM Changeset in webkit [128207] by kerz@chromium.org
  • 2 edits in branches/chromium/1229/Source/WebCore/bindings/v8

fix for chromium 143937

10:50 AM Changeset in webkit [128206] by mitz@apple.com
  • 2 edits in trunk/Tools

Fixed a bug where kill-old-processes failed to kill clang++.

Rubber-stamped by Alexey Proskuryakov.

  • BuildSlaveSupport/kill-old-processes: Escape the + signs in "clang++"

where it is passed as a regular expression to killall.

10:42 AM Changeset in webkit [128205] by beidson@apple.com
  • 6 edits in trunk/Source/WebKit2

We should wait longer before killing the PluginProcess.
<rdar://problem/12067728> and https://bugs.webkit.org/show_bug.cgi?id=96407

Reviewed by Anders Carlsson.

Currently we kill the PluginProcess 15 seconds after the last plug-in is destroyed.
This is short enough that most users will have the process killed many times during browsing sessions,
which is painful because relaunching the process is I/O and kernel intensive.

In an ideal world we could keep it around forever until the system tells us resources are running low.

In reality we do want to kill it occasionally to get a clean slate from any plug-in leaks.

A reasonable balance for now is to set a minimum lifetime of 30 minutes on the plug-in process and to
extend the termination timer from 15 seconds to 10 minutes.

  • PluginProcess/PluginProcess.cpp:

(WebKit::PluginProcess::PluginProcess):
(WebKit::PluginProcess::initializePluginProcess):
(WebKit::PluginProcess::setMinimumLifetime):
(WebKit):
(WebKit::PluginProcess::minimumLifetimeTimerFired):

  • PluginProcess/PluginProcess.h:

(PluginProcess):

  • Shared/Plugins/PluginProcessCreationParameters.cpp:

(WebKit::PluginProcessCreationParameters::encode):
(WebKit::PluginProcessCreationParameters::decode):

  • Shared/Plugins/PluginProcessCreationParameters.h:

(PluginProcessCreationParameters):

  • UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit):
(WebKit::PluginProcessProxy::didFinishLaunching):

10:40 AM Changeset in webkit [128204] by commit-queue@webkit.org
  • 11 edits in trunk/Source

Deploy StringBuilder::appendNumber() and StringBuilder::appendLiteral() in more places
https://bugs.webkit.org/show_bug.cgi?id=96344

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-09-11
Reviewed by Benjamin Poulain.

Use StringBuilder::appendNumber() instead of String::number(). Also deploy
StringBuilder::appendLiteral() instead of String::append() in the surrounding code.

Source/WebCore:

  • css/CSSAspectRatioValue.cpp:

(WebCore::CSSAspectRatioValue::customCssText):

  • platform/graphics/gpu/LoopBlinnPathProcessor.cpp:

(WebCore):

  • svg/SVGPointList.cpp:

(WebCore::SVGPointList::valueAsString):

Source/WebKit/blackberry:

  • WebCoreSupport/DatePickerClient.cpp:

(WebCore::DatePickerClient::generateHTML):

  • WebCoreSupport/SelectPopupClient.cpp:

(WebCore::SelectPopupClient::generateHTML):

Source/WebKit2:

  • Shared/WebMemorySampler.cpp:

(WebKit::WebMemorySampler::appendCurrentMemoryUsageToFile):

  • UIProcess/InspectorServer/WebSocketServerConnection.cpp:

(WebKit::WebSocketServerConnection::sendHTTPResponseHeader):

  • UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp:

(WebKit::WebInspectorServer::inspectorUrlForPageID):
(WebKit::WebInspectorServer::buildPageList):

10:39 AM Changeset in webkit [128203] by enne@google.com
  • 2 edits in trunk/Source/WTF

Clang doesn't optimize away undefined OwnPtr copy constructor
https://bugs.webkit.org/show_bug.cgi?id=74625

Reviewed by Anders Carlsson.

Original patch by Anders Carlsson, with a minor edit.

The publicly declared-but-not-defined copy constructor is a compiler
optimization-dependent landmine. Clang often fails to optimize the use
of this function out, leading to internal linkage errors for the missing
definition. gcc doesn't have this problem and optimizes that function
out, leading to code that inconsistently fails to link across platforms.

As a partial fix for this problem, on any compiler that supports C++11
move semantics, replace the bogus copy constructor with the move
constructors. In the future, if all compilers support this, then the
copy constructor can be removed.

This still leaves other compilers that don't support move semantics
like Visual Studio vulnerable to linking inconsistencies.

  • wtf/OwnPtr.h:

(OwnPtr):
(WTF):
(WTF::::OwnPtr):
(WTF::=):

10:29 AM Changeset in webkit [128202] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix speling error in comment.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::isTransparentSilverlightBackgroundValue):

10:21 AM Changeset in webkit [128201] by tony@chromium.org
  • 32 edits in trunk/Source/WebCore

Rename computeLogicalHeight to updateLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=96305

Reviewed by Ojan Vafai.

computeLogicalHeight changes the value of 4 member variables of the
render box, so give it a name that makes it more clear that it is
updating member variables.

No new tests, this is just a refactor.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeInitialRegionRangeForBlock):
(WebCore::RenderBlock::checkForPaginationLogicalHeightChange):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::updateLogicalHeight):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
(WebCore::RenderBox::availableLogicalHeightUsing):

  • rendering/RenderBox.h:

(RenderBox):
(WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::layout):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::updateLogicalHeight):

  • rendering/RenderFlowThread.h:
  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutBlock):

  • rendering/RenderHTMLCanvas.cpp:

(WebCore::RenderHTMLCanvas::canvasSizeChanged):

  • rendering/RenderIFrame.cpp:

(WebCore::RenderIFrame::updateLogicalHeight):
(WebCore::RenderIFrame::layoutSeamlessly):
(WebCore::RenderIFrame::layout):

  • rendering/RenderIFrame.h:

(RenderIFrame):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::imageDimensionsChanged):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::updateLogicalHeight):

  • rendering/RenderListBox.h:

(RenderListBox):

  • rendering/RenderMeter.cpp:

(WebCore::RenderMeter::updateLogicalHeight):

  • rendering/RenderMeter.h:

(RenderMeter):

  • rendering/RenderMultiColumnBlock.cpp:

(WebCore::RenderMultiColumnBlock::checkForPaginationLogicalHeightChange):

  • rendering/RenderMultiColumnFlowThread.h:
  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::updateLogicalHeight):

  • rendering/RenderMultiColumnSet.h:

(RenderMultiColumnSet):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::layout):

  • rendering/RenderSearchField.cpp:

(WebCore::RenderSearchField::computeControlHeight):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::updateLogicalHeight):

  • rendering/RenderTextControl.h:

(RenderTextControl):

  • rendering/RenderView.cpp:

(WebCore::RenderView::updateLogicalHeight):

  • rendering/RenderView.h:
  • rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::updateLogicalHeight):

  • rendering/svg/RenderSVGForeignObject.h:

(RenderSVGForeignObject):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::layout):

10:21 AM Changeset in webkit [128200] by zhajiang@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] InRegion scrollable area dangling pointers were accessed in UI thread
https://bugs.webkit.org/show_bug.cgi?id=96318

Reviewed by Antonio Gomes.
Patch by Jacky Jiang <zhajiang@rim.com>

PR: 204066
Dangling pointers were accessed in UI thread, as the actual InRegion
scrollable areas of WebKit side had been destroyed before that in
WebKit thread after UI thread set scrolling to false.
Notify the client side to clear InRegion scrollable areas before we
destroy them in WebKit side.

Internally reviewed by Gen Mak and George Staikos.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::notifyInRegionScrollStopped):
(BlackBerry::WebKit::WebPagePrivate::setScrollOriginPoint):

  • Api/WebPageClient.h:
9:59 AM Changeset in webkit [128199] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Fix double call to scrollBegin() when handling scroll gesture
https://bugs.webkit.org/show_bug.cgi?id=95322

Patch by Iain Merrick <husky@chromium.org> on 2012-09-11
Reviewed by James Robinson.

WebCompositorInputHandlerImpl::handleGestureFling() calls scrollBegin() on its
client, then if the result is ScrollStarted, it creates a PlatformGestureCurve
object to handle the fling animation. This patch adds a matching scrollEnd()
before the animation starts.

Now using strict mocks in WebCompositorInputHandlerImplTest, which turns all
unexpected calls into test failures. This ensures that scrollBegin / scrollEnd
happen exactly when we want and at no other times.

  • src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):

  • tests/WebCompositorInputHandlerImplTest.cpp:

(WebCompositorInputHandlerImplTest):
(WebKit::TEST_F):

9:52 AM Changeset in webkit [128198] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Suppress keyboard requests while processing spell checking suggestions.
https://bugs.webkit.org/show_bug.cgi?id=96394

Reviewed by Rob Buis.

Suppress the VKB notification when the touch event
is a spell checking request.

PR 192925.

Reviewed Internally by Gen Mak.

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):

9:48 AM Changeset in webkit [128197] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Colour Dialog popup request should return proper state.
https://bugs.webkit.org/show_bug.cgi?id=96392

Reviewed by Rob Buis.

Return proper state from openColorPopup dependent on
whether the popup actually opened.

Reviewed Internally by Chris Hutten-Czapski

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::openColorPopup):

9:44 AM WebKitGTK/1.10.x edited by sergio@webkit.org
(diff)
9:44 AM Changeset in webkit [128196] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Fix FilterTypeZoom to properly call canvas->restore()
https://bugs.webkit.org/show_bug.cgi?id=96082

Patch by Zach Kuznia <zork@chromium.org> on 2012-09-11
Reviewed by Adrienne Walker.

Source/Platform:

Fix zoom filter to properly indicate that it affects pixels.

  • chromium/src/WebFilterOperations.cpp:

(WebKit::WebFilterOperations::hasFilterThatMovesPixels):
(WebKit::WebFilterOperations::hasFilterThatAffectsOpacity):

Source/WebCore:

Fix zoom filter to properly call canvas->restore()

  • platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:

(WebCore::CCRenderSurfaceFilters::apply):

9:42 AM Changeset in webkit [128195] by sergio@webkit.org
  • 3 edits
    2 adds in trunk

[GTK] WebKitGtk+ crashes with non-UTF8 HTTP header names
https://bugs.webkit.org/show_bug.cgi?id=96284

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Non UTF-8 characters sent as part of a HTTP header name were
causing crashes as String::fromUTF8() was returning NULL for
them. Use String::fromUTF8WithLatin1Fallback() instead.

Test: http/tests/misc/non-utf8-header-name.php

  • platform/network/soup/ResourceResponseSoup.cpp:

(WebCore::ResourceResponse::updateFromSoupMessage):

LayoutTests:

Added a new test to make sure that WebKitGtk+ does not crash when
a non-UTF8 character is sent as part of a HTTP header name.

  • http/tests/misc/non-utf8-header-name-expected.txt: Added.
  • http/tests/misc/non-utf8-header-name.php: Added.
9:40 AM Changeset in webkit [128194] by peter@chromium.org
  • 3 edits in trunk/Tools

Make sure that md5sum is not setup on non-Chromium Android platforms.
https://bugs.webkit.org/show_bug.cgi?id=96393

Patch by Philippe Liard <pliard@google.com> on 2012-09-11
Reviewed by Adam Barth.

Previously md5sum was setup in ChromiumAndroidDriver's constructor
which is also invoked on non-Chromium Android platforms. The following patch
moves this logic to _startup_test() which is guaranteed to be invoked
only on Android.

This also updates the prompt unit test in chromium_android_unittest.py.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidDriver.init):
(ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
(ChromiumAndroidDriver._setup_test):

9:08 AM Changeset in webkit [128193] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening, skip new failing tests to paint the bot green.

  • platform/qt-5.0-wk2/Skipped:
9:03 AM WebInspector edited by nvineeth@gmail.com
remove spam links. (diff)
8:42 AM Changeset in webkit [128192] by commit-queue@webkit.org
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r128175.
http://trac.webkit.org/changeset/128175
https://bugs.webkit.org/show_bug.cgi?id=96395

broke hunders of tests for EFL and GTK (Requested by rakuco on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-11

Source/WebCore:

  • platform/network/soup/ResourceResponseSoup.cpp:

(WebCore::ResourceResponse::updateFromSoupMessage):

LayoutTests:

  • http/tests/misc/non-utf8-header-name-expected.txt: Removed.
  • http/tests/misc/non-utf8-header-name.php: Removed.
8:33 AM Changeset in webkit [128191] by rakuco@webkit.org
  • 24 edits
    8 adds
    1 delete in trunk

[EFL] Rewrite the EFL-related Find modules
https://bugs.webkit.org/show_bug.cgi?id=95237

Reviewed by Kenneth Rohde Christiansen.

.:

FindEFL.cmake had several problems which caused unnecessary trouble
when building the EFL port under some setups:

o It looked for some modules (such as ecore) more than once for no
reason, which led to people adding libraries and include paths in
different ways across the build system.

o It depended on pkg-config being present for the searches to
succeed.

o It obtained the library definitions from pkg-config, so
${FOO_LIBRARIES} would be set to something like "foo;bar" which
expanded to "-lfoo -lbar" to the linker. If a wrong -L<path> was
passed before that, the wrong library installation would end up
being picked up.

o Due to the problem above, we also needed to set the LINK_FLAGS
property for each target with the value of ${FOO_LDFLAGS}, which was
also obtained from pkg-config and sort of compensated the fact that
the libraries did not use absolute paths and added the required -L
paths. This also included dependencies for these libraries, so we
ended up including libraries indirectly, which is bad.

We have now replaced that file with a set of Find-modules which are
much more granular, each of them responsible for looking for a
single library and its components and setting library and include
locations the right way (with FIND_PATH() and FIND_LIBRARY()), so
that all the problems above are fixed.

  • Source/cmake/EFLHelpers.cmake: Added.
  • Source/cmake/FindEDBus.cmake: Added.
  • Source/cmake/FindEFL.cmake: Removed.
  • Source/cmake/FindEcore.cmake: Added.
  • Source/cmake/FindEdje.cmake: Added.
  • Source/cmake/FindEeze.cmake: Added.
  • Source/cmake/FindEfreet.cmake: Added.
  • Source/cmake/FindEina.cmake: Added.
  • Source/cmake/FindEvas.cmake: Added.
  • Source/cmake/OptionsEfl.cmake:

Source/JavaScriptCore:

  • CMakeLists.txt: Stop setting the LINK_FLAGS property.
  • PlatformEfl.cmake: Ditto.
  • shell/PlatformEfl.cmake: Ditto.

Source/WebCore:

  • CMakeLists.txt: Stop setting the LINK_FLAGS property now that no

port sets WebCore_LINK_FLAGS.

  • PlatformEfl.cmake: Add libraries and include directories for

each Enlightenment Foundation Library used by the port.

Source/WebKit:

  • PlatformEfl.cmake: Stop setting the LINK_FLAGS property and add

libraries and include directories for each Enlightenment
Foundation Library used by the port.

Source/WebKit2:

  • CMakeLists.txt: Stop setting the LINK_FLAGS property.
  • PlatformEfl.cmake: Add libraries and include directories for

each Enlightenment Foundation Library used by the port.

Source/WTF:

  • CMakeLists.txt: Stop setting the LINK_FLAGS property.
  • PlatformEfl.cmake: Add libraries and include directories for

each Enlightenment Foundation Library used by the port.

Tools:

  • DumpRenderTree/efl/CMakeLists.txt: Stop setting the LINK_FLAGS

property and include all the Enlightenment Foundation Libraries
required by the target.

  • EWebLauncher/CMakeLists.txt: Ditto.
  • MiniBrowser/efl/CMakeLists.txt: Ditto.
  • TestWebKitAPI/PlatformEfl.cmake: Add missing include directories

now that they are not added implicitly.

  • WebKitTestRunner/CMakeLists.txt: Stop setting the LINK_FLAGS

property.

  • WebKitTestRunner/PlatformEfl.cmake: Stop setting the LINK_FLAGS

property and include all the Enlightenment Foundation Libraries
required by the target.

8:23 AM Changeset in webkit [128190] by commit-queue@webkit.org
  • 9 edits in trunk

[WK2][WKTR] TestRunner needs to implement setApplicationCacheOriginQuota
https://bugs.webkit.org/show_bug.cgi?id=96379

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-11
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add Bundle C API to set the application cache quota for a
given security origin. This is needed by WebKitTestRunner
to implement setApplicationCacheOriginQuota().

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetApplicationCacheOriginQuota):

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setApplicationCacheOriginQuota):
(WebKit):

  • WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

Tools:

Add implementation for setApplicationCacheOriginQuota
to WebKitTestRunner.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setApplicationCacheOriginQuota):
(WTR):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

8:12 AM Changeset in webkit [128189] by commit-queue@webkit.org
  • 4 edits in trunk

[Qt] [WK2] editing/inserting/typing-tab-designmode tests are failing
https://bugs.webkit.org/show_bug.cgi?id=91988

Patch by Luciano Wolf <Luciano Miguel Wolf> on 2012-09-11
Reviewed by Kenneth Rohde Christiansen.

Tools:

Regular key events generated by Qt for the tab key fill both
keyCode and keyText, so we should do the same for our fake events.

  • WebKitTestRunner/qt/EventSenderProxyQt.cpp:

(WTR::EventSenderProxy::keyDown):

LayoutTests:

Unskip related tests.

  • platform/qt-5.0-wk2/Skipped:
8:08 AM Changeset in webkit [128188] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Take account for single words that exceed our client character limit
https://bugs.webkit.org/show_bug.cgi?id=96389

Fix to the processing of long single-line text using getRangeForSpellCheckWithFineGranularity.
This was failing if a single word was longer than our maximum allowed limit.

Internally reviewed by Mike Fenton.

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-09-11
Reviewed by Rob Buis.

  • WebKitSupport/InputHandler.cpp:

(WebKit):
(BlackBerry::WebKit::InputHandler::getRangeForSpellCheckWithFineGranularity):

8:04 AM Changeset in webkit [128187] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

[Qt] Unreviewed, rolling out 128054, because it broke the Windows build.

  • DerivedSources.pri:
7:49 AM Changeset in webkit [128186] by commit-queue@webkit.org
  • 12 edits in trunk

[WK2][WTR] WebKitTestRunner needs testRunner.setSpatialNavigationEnabled
https://bugs.webkit.org/show_bug.cgi?id=96269

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-11
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Added a new setter for spacial navigation enabling to Injected Bundle private API.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetSpatialNavigationEnabled):

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setSpatialNavigationEnabled):
(WebKit):

  • WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

Tools:

Exported missing testRunner.setSpatialNavigationEnabled() method.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setSpatialNavigationEnabled):
(WTR):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

LayoutTests:

Unskipped fast/spatial-navigation tests. Put those which still fail to an appropriate group.

  • platform/wk2/Skipped:
7:47 AM Changeset in webkit [128185] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Fix the build with libwebp

Rubber-stamped by Tor Arne Vestbø

The use-flag is called WEBP not LIBWEBP, so use that when appending -lwebp.

  • WebCore.pri:
7:34 AM Changeset in webkit [128184] by caseq@chromium.org
  • 12 edits in trunk

Web Inspector: visualize layout root in Timeline
https://bugs.webkit.org/show_bug.cgi?id=96279

Reviewed by Pavel Feldman.

  • pass layout root to InspectorTimelineAgent::didLayout
  • show rectangles of the layout root upon hover over the Layout record;
  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didLayoutImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didLayout):

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didLayout):

  • inspector/InspectorTimelineAgent.h:

(WebCore):
(InspectorTimelineAgent):

  • inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createPaintData):
(WebCore::TimelineRecordFactory::addRectData):
(WebCore):

  • inspector/TimelineRecordFactory.h:

(TimelineRecordFactory):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._mouseMove):

  • page/FrameView.cpp:

(WebCore::FrameView::layout):

7:30 AM Changeset in webkit [128183] by anilsson@rim.com
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] SelectionHandler drops caret change notifications
https://bugs.webkit.org/show_bug.cgi?id=96378

Reviewed by Antonio Gomes.

The selection handler deliberately drops caret change notifications
while the input handler is processing changes, to avoid displaying
intermediate state during a complex change.

However, this meant that the client was never informed of the final
caret position.

Fixed by notifying client about caret change after processing ends, if
one or more caret change notifications were dropped during processing.

PR #205073

Reviewed internally by Mike Fenton.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::setProcessingChange):
(WebKit):

  • WebKitSupport/InputHandler.h:

(InputHandler):

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::SelectionHandler):
(BlackBerry::WebKit::SelectionHandler::inputHandlerDidFinishProcessingChange):
(WebKit):
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
(BlackBerry::WebKit::SelectionHandler::notifyCaretPositionChangedIfNeeded):

  • WebKitSupport/SelectionHandler.h:

(SelectionHandler):

7:18 AM Changeset in webkit [128182] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Blackberry] use ReadOnlyLatin1String to save a deep copy
https://bugs.webkit.org/show_bug.cgi?id=96364

Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-09-11
Reviewed by Yong Li.
Internally reviewed by Yong li.

  • platform/network/blackberry/NetworkManager.cpp:

(WebCore::NetworkManager::startJob):

7:10 AM Changeset in webkit [128181] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk

Tools: Support LayoutTests on non-rooted devices for Chromium Android.
https://bugs.webkit.org/show_bug.cgi?id=95346

Patch by Philippe Liard <pliard@chromium.org> on 2012-09-11
Reviewed by Dirk Pranke.

We were requiring root permissions to sync resource files with the
device by comparing host and device files' timestamp after we
synchronized the device and host clocks.
We now rely on md5sum provided by Chromium to handle data files
synchronization.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort._check_driver_build_up_to_date):

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidDriver.init):
(ChromiumAndroidDriver._setup_test):
(ChromiumAndroidDriver._push_executable):
(ChromiumAndroidDriver._push_test_resources):
(ChromiumAndroidDriver._read_prompt):

LayoutTests: Support LayoutTests on non-rooted Android devices.
https://bugs.webkit.org/show_bug.cgi?id=95346

Patch by Philippe Liard <pliard@chromium.org> on 2012-09-11
Reviewed by Dirk Pranke.

http/tests/cache/resources/subresource-test.js was assuming that the
client and server clocks are the same which is no longer true since we
are getting rid of host/device clock synchronization.

  • http/tests/cache/resources/cache-simulator.cgi:
  • http/tests/cache/resources/current-time.cgi: Added.
  • http/tests/cache/resources/subresource-test.js:

(getServerDate):
(nextTest):
(testComplete):
(runTests):

7:04 AM Changeset in webkit [128180] by Simon Hausmann
  • 2 edits in trunk/Tools

[Qt] Fix output paths on Windows

Reviewed by Tor Arne Vestbø.

BUILD_ROOT_RELATIVE_TO_OUT_PWD was calculated incorrectly Windows, resulting in an incorrect
DESTDIR transformation at the end of default_post.prf. The calculation should be baased no qmake
paths, which can use drive letters but always use forward slashes. So the use of QMAKE_DIR_SEP is
incorrect here and instead for the calculation we should use forward slashes.

  • qmake/mkspecs/features/default_pre.prf:
6:55 AM Changeset in webkit [128179] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Fix passing of defines from the build system

We explicitly have to pass -DENABLE_FOO=0 for every single feature
that's not explicitly enabled in WEBKIT_CONFIG, since Platform.h
will add it's own defaults if the features are not defined.

At some point we might want to run a configure-test to inspect what
Platform.h will do, so we can sync up the build system's view of
the feature-defines with the compile-time situation.

Reviewed by Simon Hausmann.

6:51 AM Changeset in webkit [128178] by Simon Hausmann
  • 2 edits in trunk

[Qt] In-source builds are broken

Reviewed by Tor Arne Vestbø.

The Tools sub-directory contains a Makefile checked into SVN. For in-source builds let's not try to
overwrite it but instead generate a dedicated Makefile.Tools.

  • Makefile:
  • WebKit.pro:
6:49 AM Changeset in webkit [128177] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebKit2

[Qt][WK2] Page loading status API lacks a status for intentionally stopped loading
https://bugs.webkit.org/show_bug.cgi?id=83062

Patch by Marcelo Lira <marcelo.lira@openbossa.org> on 2012-09-11
Reviewed by Tor Arne Vestbø.

When the loading of a page is intentionally interrupted, the loading
status is set to the new state LoadStoppedStatus. This reflects
reality more accurately because the page was not fully loaded
(a LoadSucceededStatus), and it wasn't an unexpected error
(a LoadFailedStatus).

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::loadDidStop):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

  • UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadUrl.qml:
  • UIProcess/API/qt/tests/qmltests/common/TestWebView.qml:
  • UIProcess/qt/QtWebPageLoadClient.cpp:

(WebKit::QtWebPageLoadClient::dispatchLoadStopped):
(WebKit):
(WebKit::QtWebPageLoadClient::dispatchLoadFailed):

  • UIProcess/qt/QtWebPageLoadClient.h:

(QtWebPageLoadClient):

6:21 AM Changeset in webkit [128176] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Fix --qt option to build-webkit

Reviewed by Ossy.

  • Scripts/webkitdirs.pm:

(buildQMakeProjects):

6:12 AM WebKitGTK/1.10.x edited by sergio@webkit.org
(diff)
6:11 AM Changeset in webkit [128175] by sergio@webkit.org
  • 3 edits
    2 adds in trunk

[GTK] WebKitGtk+ crashes with non-UTF8 HTTP header names
https://bugs.webkit.org/show_bug.cgi?id=96284

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Non UTF-8 characters sent as part of a HTTP header name were
causing crashes as String::fromUTF8() was returning NULL for
them. Use String::fromUTF8WithLatin1Fallback() instead.

Test: http/tests/misc/non-utf8-header-name.php

  • platform/network/soup/ResourceResponseSoup.cpp:

(WebCore::ResourceResponse::updateFromSoupMessage):

LayoutTests:

Added a new test to make sure that WebKitGtk+ does not crash when
a non-UTF8 character is sent as part of a HTTP header name.

  • http/tests/misc/non-utf8-header-name-expected.txt: Added.
  • http/tests/misc/non-utf8-header-name.php: Added.
6:08 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
6:08 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
6:06 AM Changeset in webkit [128174] by vestbo@webkit.org
  • 42 edits
    3 adds
    2 deletes in trunk

[Qt] Add a configure step to the Qt build system

This allows building the Qt port using just 'qmake WebKit.pro'. Using
the build-webkit script is still supported, and will add slightly more
logic to the build, such as detecting the need for clean or incremental
builds.

Internally, the build system now uses a new variable, WEBKIT_CONFIG, for
all things related to configuring the build, such as use/have/enable flags,
and these are translated to defines in default_post. Project files should
no longer check contains(DEFINES,...) to detect features, but use the new
enable?(), use?(), and have?() functions. The no_webkit1 and no_webkit2
options have been translated into WEBKIT_CONFIG options as well, and can
be checked using build?().

Reviewed by Simon Hausmann.

5:32 AM Changeset in webkit [128173] by commit-queue@webkit.org
  • 11 edits in trunk

[WK2][WKTR] TestRunner needs to implement clearApplicationCacheForOrigin
https://bugs.webkit.org/show_bug.cgi?id=96372

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-11
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add Bundle C API to clear the application cache for a
given origin. This is needed by WebKitTestRunner to
implement clearApplicationCacheForOrigin().

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleClearApplicationCacheForOrigin):

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::clearApplicationCacheForOrigin):
(WebKit):

  • WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

Tools:

Implement clearApplicationCacheForOrigin() in WebKitTestRunner.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::clearApplicationCacheForOrigin):
(WTR):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

LayoutTests:

Refresh Skipped list now that clearApplicationCacheForOrigin
is implemented in TestRunner. Some tests were also marked as
failing due to clearAllApplicationCaches() being missing
despite the fact that it is already implemented.

  • platform/wk2/Skipped:
4:59 AM Changeset in webkit [128172] by rakuco@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[EFL] Unreviewed build fix after r128065.

  • CMakeLists.txt: Link against WTF for FastMalloc symbols, which

are needed when building with SYSTEM_MALLOC off.

4:54 AM Changeset in webkit [128171] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Remove no-op TreeElement.prototype.didChange method
https://bugs.webkit.org/show_bug.cgi?id=96376

Reviewed by Yury Semikhatsky.

  • inspector/front-end/treeoutline.js:

(TreeElement.prototype.set title):
(TreeElement.prototype.set tooltip):
(TreeElement.prototype.set hasChildren):

4:37 AM WebKitGTK/1.10.x edited by sergio@webkit.org
(diff)
4:26 AM Changeset in webkit [128170] by peter@chromium.org
  • 2 edits in trunk/Tools

Don't ignore .pak files when making an archive for Android
https://bugs.webkit.org/show_bug.cgi?id=96375

Reviewed by Jochen Eisinger.

The .pak files do need to be pushed to the device, which is currently
preventing the layout test runner from correctly pushing all files.

  • BuildSlaveSupport/built-product-archive:

(archiveBuiltProduct):

4:21 AM Changeset in webkit [128169] by commit-queue@webkit.org
  • 12 edits in trunk

[WK2][WTR] WebKitTestRunner needs layoutTestController.setMinimumTimerInterval
https://bugs.webkit.org/show_bug.cgi?id=96256

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-11
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Added new setter for minimum DOM timer interval to InjectedBundle private API.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetMinimumTimerInterval):

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setMinimumTimerInterval):
(WebKit):

  • WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

Tools:

Exported TestRunner::setMinimumTimerInterval() method.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setMinimumTimerInterval):
(WTR):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

LayoutTests:

Unskipped corresponding fast/dom/ tests.

  • platform/wk2/Skipped:
3:50 AM Changeset in webkit [128168] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
3:34 AM Changeset in webkit [128167] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] New fast/canvas/canvas-lineDash.html introduced in r128116 fails.
https://bugs.webkit.org/show_bug.cgi?id=96360

Patch by Szilard Ledan <Szilárd LEDÁN> on 2012-09-11
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
3:29 AM Changeset in webkit [128166] by tommyw@google.com
  • 13 edits
    2 adds in trunk

MediaStream API: add RTCPeerConnection::onnegotiationneeded
https://bugs.webkit.org/show_bug.cgi?id=96097

Reviewed by Adam Barth.

Source/Platform:

  • chromium/public/WebRTCPeerConnectionHandlerClient.h:

(WebRTCPeerConnectionHandlerClient):

Source/WebCore:

This patch adds the last callback to RTCPeerConnection: onnegotiationneeded.
This is called whenever the state in the RTCPeerConnection changes and that
change needs to be sent to the other side.

Test: fast/mediastream/RTCPeerConnection-onnegotiationneeded.html

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::negotiationNeeded):
(WebCore):

  • Modules/mediastream/RTCPeerConnection.h:

(RTCPeerConnection):

  • Modules/mediastream/RTCPeerConnection.idl:
  • dom/EventNames.h:

(WebCore):

  • platform/mediastream/RTCPeerConnectionHandlerClient.h:

(RTCPeerConnectionHandlerClient):

  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:

(WebCore::RTCPeerConnectionHandlerChromium::negotiationNeeded):
(WebCore):

  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:

(RTCPeerConnectionHandlerChromium):

Tools:

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(MockWebRTCPeerConnectionHandler::addStream):
(MockWebRTCPeerConnectionHandler::removeStream):

LayoutTests:

  • fast/mediastream/RTCPeerConnection-onnegotiationneeded-expected.txt: Added.
  • fast/mediastream/RTCPeerConnection-onnegotiationneeded.html: Added.
3:11 AM Changeset in webkit [128165] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Sort an Xcode project file.

  • WebCore.xcodeproj/project.pbxproj:
3:10 AM Changeset in webkit [128164] by peter@chromium.org
  • 4 edits in trunk/Tools

Recognize the "--chromium-android" argument in run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=96369

Reviewed by Jochen Eisinger.

Chromium for the Android platform cannot determine the platform based on
the host itself, so we'll use the --chromium-android argument as the build
master passes to run-webkit-tests. Make sure the layout test runner
can pick the right port when doing so.

  • Scripts/run-webkit-tests:
  • Scripts/webkitpy/layout_tests/port/factory.py:

(port_options):

3:06 AM Changeset in webkit [128163] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[WK2][EFL] Fix compile warnings when enable tiled backing store
https://bugs.webkit.org/show_bug.cgi?id=95342

Patch by Kangil Han <kangil.han@samsung.com> on 2012-09-11
Reviewed by Gyuyoung Kim.

Fixed compile time warning messages when enable tiled backing store.

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_accelerated_compositing_mode_enter): Fixed invalid use of 'EINA_SAFETY_ON_NULL_RETURN_VAL' since it used '!' ahead of evasGl value so it is always null.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::setChildren): Replaced 'int' i with 'unsigned' because its comparing value is 'size_t'.

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::renderNextFrame): Replaced 'int' i with 'unsigned' because its comparing value is 'size_t'.
(WebKit::LayerTreeCoordinator::beginContentUpdate): Replaced 'int' i with 'unsigned' because its comparing value is 'size_t'.

2:57 AM Changeset in webkit [128162] by Simon Hausmann
  • 2 edits in trunk/Tools

[QT] Fix build with newer qmake from Qt 5

Rubber-stamped by Tor Arne Vestbø.

Support for "qmake -query QMAKE_MKSPECS" was removed from qmake. Replace
it with the use of QT_HOST_DATA/mkspecs.
Based on patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>.

  • Scripts/webkitdirs.pm:

(builtDylibPathForName):
(qtMakeCommand):

2:54 AM Changeset in webkit [128161] by vestbo@webkit.org
  • 1 edit
    1 delete in trunk/Tools

[Qt] Remove Qt 4 syncqt, no longer needed

Reviewed by Simon Hausmann.

  • qmake/syncqt-4.8: Removed.
2:49 AM EFLWebKit edited by kenneth@webkit.org
(diff)
2:36 AM Changeset in webkit [128160] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] WKEinaSharedString needs a function to adopt eina stringshare.
https://bugs.webkit.org/show_bug.cgi?id=96201

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-09-11
Reviewed by Kenneth Rohde Christiansen.

WKEinaSharedString needs a to adopt eina stringshare directly.

With this adopt function, an instance that is directly created with
eina_stringshare_add() can be easily handled by WKEinaSharedString
without calling eina_stringshare_del() for preventing memory leak.

  • UIProcess/API/cpp/efl/WKEinaSharedString.cpp:

(WKEinaSharedString::adopt):

  • UIProcess/API/cpp/efl/WKEinaSharedString.h:
  • UIProcess/API/efl/tests/test_ewk2_eina_shared_string.cpp:

(TEST_F):

2:35 AM Changeset in webkit [128159] by commit-queue@webkit.org
  • 32 edits
    2 deletes in trunk/Source/WebCore

Removed V8IsolatedContext
https://bugs.webkit.org/show_bug.cgi?id=95735

Patch by Dan Carney <dcarney@google.com> on 2012-09-11
Reviewed by Adam Barth.

Remove V8IsolatedContext and merge functionality into V8DOMWindowShell.
This brings the V8 isolated world model into closer alignment with
that of JSC.

No new tests. No change in functionality.

  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateImplementation):

  • bindings/scripts/test/V8/V8Float64Array.cpp:
  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:
  • bindings/scripts/test/V8/V8TestEventTarget.cpp:
  • bindings/scripts/test/V8/V8TestException.cpp:
  • bindings/scripts/test/V8/V8TestInterface.cpp:
  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
  • bindings/scripts/test/V8/V8TestNode.cpp:
  • bindings/scripts/test/V8/V8TestObj.cpp:
  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
  • bindings/v8/DOMData.cpp:

(WebCore::DOMData::getCurrentStore):

  • bindings/v8/DOMWrapperWorld.cpp:

(WebCore::DOMWrapperWorld::ensureIsolatedWorld):

  • bindings/v8/DOMWrapperWorld.h:

(DOMWrapperWorld):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::ScriptController):
(WebCore::ScriptController::resetIsolatedWorlds):
(WebCore::ScriptController::ensureIsolatedWorldContext):
(WebCore::ScriptController::existingWindowShellInternal):
(WebCore):
(WebCore::ScriptController::windowShell):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::setIsolatedWorldSecurityOrigin):
(WebCore::ScriptController::currentWorldContext):
(WebCore::ScriptController::evaluateInWorld):
(WebCore::ScriptController::collectIsolatedContexts):

  • bindings/v8/ScriptController.h:

(WebCore):
(ScriptController):
(WebCore::ScriptController::existingWindowShell):

  • bindings/v8/SharedPersistent.h:

(WebCore):
(WebCore::SharedPersistent::create):
(WebCore::SharedPersistent::get):
(WebCore::SharedPersistent::SharedPersistent):
(SharedPersistent):

  • bindings/v8/V8Binding.cpp:

(WebCore::perContextDataForCurrentWorld):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::setIsolatedWorldField):
(WebCore::V8DOMWindowShell::enteredIsolatedWorldContext):
(WebCore):
(WebCore::setInjectedScriptContextDebugId):
(WebCore::V8DOMWindowShell::create):
(WebCore::V8DOMWindowShell::V8DOMWindowShell):
(WebCore::V8DOMWindowShell::destroyIsolatedShell):
(WebCore::isolatedContextWeakCallback):
(WebCore::V8DOMWindowShell::disposeContext):
(WebCore::V8DOMWindowShell::initializeIfNeeded):
(WebCore::V8DOMWindowShell::createContext):
(WebCore::V8DOMWindowShell::installDOMWindow):
(WebCore::V8DOMWindowShell::updateDocumentWrapper):
(WebCore::V8DOMWindowShell::updateDocumentProperty):
(WebCore::V8DOMWindowShell::clearDocumentProperty):
(WebCore::V8DOMWindowShell::setSecurityToken):
(WebCore::V8DOMWindowShell::updateDocument):
(WebCore::V8DOMWindowShell::namedItemAdded):
(WebCore::V8DOMWindowShell::namedItemRemoved):
(WebCore::V8DOMWindowShell::updateSecurityOrigin):
(WebCore::V8DOMWindowShell::setIsolatedWorldSecurityOrigin):

  • bindings/v8/V8DOMWindowShell.h:

(V8DOMWindowShell):
(WebCore::V8DOMWindowShell::world):
(WebCore::V8DOMWindowShell::isolatedWorldSecurityOrigin):
(WebCore::V8DOMWindowShell::getEntered):

  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getCachedWrapper):

  • bindings/v8/V8IsolatedContext.cpp: Removed.
  • bindings/v8/V8IsolatedContext.h: Removed.
  • bindings/v8/V8LazyEventListener.cpp:
  • bindings/v8/WorldContextHandle.cpp:

(WebCore::WorldContextHandle::WorldContextHandle):
(WebCore::WorldContextHandle::adjustedContext):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8SVGDocumentCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:

(WebCore::V8XMLHttpRequest::constructorCallback):

2:31 AM WebInspector edited by mtjohnwoods@gmail.com
(diff)
2:18 AM Changeset in webkit [128158] by abecsi@webkit.org
  • 15 edits in trunk

[Qt][WK2] Fix the build with recent Qt5
https://bugs.webkit.org/show_bug.cgi?id=96283

Reviewed by Simon Hausmann.

We should not use deprecated Qt API because doing that results
in build failure since all the deprecated API was disabled
in qtbase (https://codereview.qt-project.org/#change,24890).

Source/WebKit/qt:

  • tests/qgraphicswebview/tst_qgraphicswebview.cpp:

(tst_QGraphicsWebView::widgetsRenderingThroughCache):
(tst_QGraphicsWebView::setPalette):
(tst_QGraphicsWebView::compareCanvasToImage):

  • tests/qobjectbridge/tst_qobjectbridge.cpp:

(tst_QObjectBridge::ownership):

  • tests/qwebframe/tst_qwebframe.cpp:

(tst_QWebFrame::popupFocus):
(tst_QWebFrame::inputFieldFocus):
(tst_QWebFrame::evaluateWillCauseRepaint):

  • tests/qwebpage/tst_qwebpage.cpp:

(Navigation):
(PluginCounterPage):

  • tests/qwebview/tst_qwebview.cpp:

(tst_QWebView::reusePage):
(tst_QWebView::focusInputTypes):
(tst_QWebView::setPalette):
(tst_QWebView::renderingAfterMaxAndBack):

Source/WebKit2:

  • UIProcess/API/qt/qwebnavigationhistory.cpp:

(QWebNavigationListModel::roleNames):
(QWebNavigationListModel::reset):

  • UIProcess/API/qt/qwebnavigationhistory_p.h:
  • UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp:

(WebView::load):

  • UIProcess/qt/WebPopupMenuProxyQt.cpp:

(PopupMenuItemModel):
(WebKit::PopupMenuItemModel::PopupMenuItemModel):
(WebKit::PopupMenuItemModel::roleNames):
(WebKit):

Tools:

  • DumpRenderTree/qt/main.cpp:

(main):

  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::notify):

  • MiniBrowser/qt/raw/View.cpp:

(View::exposeEvent):
(main):

2:16 AM Changeset in webkit [128157] by commit-queue@webkit.org
  • 12 edits in trunk

WTR needs an implementation of applicationCacheDiskUsageForOrigin
https://bugs.webkit.org/show_bug.cgi?id=87188

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-11
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add Bundle private C API to retrieve the application cache
usage for a specific security origin. This is needed by
WebKitTestRunner.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleGetAppCacheUsageForOrigin):

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::appCacheUsageForOrigin):
(WebKit):

  • WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

Tools:

Add implementation for applicationCacheDiskUsageForOrigin()
in WebKitTestRunner.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp: