Timeline



Oct 5, 2012:

11:46 PM Changeset in webkit [130576] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding reftest failure expectations for a couple of tests that
were introduced in r130557 and r130570.

  • platform/gtk/TestExpectations:
11:20 PM Changeset in webkit [130575] by tkent@chromium.org
  • 65 edits
    19 adds in trunk/LayoutTests

[Chromium] Rebaseline for recent INPUT_MULTIPLE_FIELDS_UI changes

  • platform/chromium-linux-x86/fast/forms/date/calendar-picker-appearance-expected.png:
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png: Added.
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png: Added.
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png: Added.
  • platform/chromium-linux/fast/forms/date/calendar-picker-appearance-expected.png:
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
  • platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/date/calendar-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-rtl-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac/fast/forms/date/calendar-picker-appearance-expected.png:
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-win-xp/fast/forms/date/calendar-picker-appearance-expected.png:
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png: Added.
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png: Added.
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png: Added.
  • platform/chromium-win/fast/forms/date/calendar-picker-appearance-expected.png:
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
  • platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium/TestExpectations:
7:08 PM Changeset in webkit [130574] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

[V8] toV8(Node*, ...) does more work than needed (6% faster on dom-traverse)
https://bugs.webkit.org/show_bug.cgi?id=98567

Reviewed by Kentaro Hara.

This patch introduces toV8Fast for Node*. This function works a
differently from the existing toV8 function in two ways:

1) It uses the inline wrapper cache in Node to determine if we're

executing in the main world. This is faster both in the case when
isolated worlds exist because we don't need to retrieve any state
for the current context.

2) It doesn't attempt to inline the hash table lookup used to find the

wrapper in the isolated world. There isn't a big need to inline this
code since performance in the isolated world case is dominated by
the hash table lookup.

Because of these two changes, toV8Fast is small enough to inline into
each attribute getter profitably. Over time, I would like to convert
all the performance critical uses of toV8(Node*) to toV8Fast. At that
point, we can delete toV8 and rename toV8Slow to toV8.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateNormalAttrGetter):

6:28 PM Changeset in webkit [130573] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

[mac] REGRESSION (r122215): Animated GIF outside the viewport doesn't play when scrolled into view.
https://bugs.webkit.org/show_bug.cgi?id=94874

Patch by Huang Dongsung <luxtella@company100.net> on 2012-10-05
Reviewed by Simon Fraser.

Rollback previous patch because this patch caused two problems.

  1. GIF animation is occasionally paused when tiled scrolling is enabled.
  2. This change regressed Apple's Membuster benchmark by ~20% (80MB.)
  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::shouldPauseAnimation):

  • loader/cache/CachedImage.h:

(CachedImage):

  • loader/cache/CachedResource.h:
  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::pruneLiveResourcesToSize):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::willRenderImage):

6:23 PM Changeset in webkit [130572] by Simon Fraser
  • 2 edits in trunk/Tools

Attempt to fix the SnowLeopard build to making the implementation of
-isPaginated come before its use.

  • MiniBrowser/mac/WK1BrowserWindowController.m:

(-[WK1BrowserWindowController reload:]):
(-[WK1BrowserWindowController forceRepaint:]):
(-[WK1BrowserWindowController goBack:]):
(-[WK1BrowserWindowController goForward:]):
(-[WK1BrowserWindowController isPaginated]):

6:09 PM Changeset in webkit [130571] by Simon Fraser
  • 6 edits
    3 copies
    1 add in trunk/Tools

Provide a way to run WebKit1
https://bugs.webkit.org/show_bug.cgi?id=98568

Reviewed by Tim Horton.

Make it possible to create both WebKit1 and WebKit2 windows in MiniBrowser.

Turn BrowserWindowController into a base class; subclassed by
WK1BrowserWindowController and WK2BrowserWindowController, each of
which implement the BrowserController protocol.

Use Command-N to get a WebKit1 window, and Command-Option-N to
get a WK2 window. Also add "Open Location" to focus the URL bar,
and code to add an http:// if missing.

Hook up window title callbacks; append " [WK1/2]" to window title
as appropriate.

  • MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
  • MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate newWindow:]):
(-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):

  • MiniBrowser/mac/BrowserWindowController.h:
  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController initWithWindow:]):
(-[BrowserWindowController windowDidLoad]):
(-[BrowserWindowController openLocation:]):
(-[BrowserWindowController loadURLString:]):
(-[BrowserWindowController applicationTerminating]):
(-[BrowserWindowController addProtocolIfNecessary:]):

  • MiniBrowser/mac/MainMenu.xib:
  • MiniBrowser/mac/WK1BrowserWindowController.h: Copied from Tools/MiniBrowser/mac/BrowserWindowController.h.

(WebView):

  • MiniBrowser/mac/WK1BrowserWindowController.m: Added.

(-[WK1BrowserWindowController awakeFromNib]):
(-[WK1BrowserWindowController dealloc]):
(-[WK1BrowserWindowController loadURLString:]):
(-[WK1BrowserWindowController fetch:]):
(-[WK1BrowserWindowController showHideWebView:]):
(-[WK1BrowserWindowController removeReinsertWebView:]):
(-[WK1BrowserWindowController validateMenuItem:]):
(-[WK1BrowserWindowController reload:]):
(-[WK1BrowserWindowController forceRepaint:]):
(-[WK1BrowserWindowController goBack:]):
(-[WK1BrowserWindowController goForward:]):
(-[WK1BrowserWindowController validateUserInterfaceItem:]):
(-[WK1BrowserWindowController validateToolbar]):
(-[WK1BrowserWindowController windowShouldClose:]):
(-[WK1BrowserWindowController windowWillClose:]):
(-[WK1BrowserWindowController applicationTerminating]):
(-[WK1BrowserWindowController currentZoomFactor]):
(-[WK1BrowserWindowController canZoomIn]):
(-[WK1BrowserWindowController zoomIn:]):
(-[WK1BrowserWindowController canZoomOut]):
(-[WK1BrowserWindowController zoomOut:]):
(-[WK1BrowserWindowController canResetZoom]):
(-[WK1BrowserWindowController resetZoom:]):
(-[WK1BrowserWindowController toggleZoomMode:]):
(-[WK1BrowserWindowController isPaginated]):
(-[WK1BrowserWindowController togglePaginationMode:]):
(-[WK1BrowserWindowController find:]):
(-[WK1BrowserWindowController dumpSourceToConsole:]):
(-[WK1BrowserWindowController webView:didStartProvisionalLoadForFrame:]):
(-[WK1BrowserWindowController webView:didReceiveTitle:forFrame:]):

  • MiniBrowser/mac/WK2BrowserWindowController.h: Copied from Tools/MiniBrowser/mac/BrowserWindowController.h.
  • MiniBrowser/mac/WK2BrowserWindowController.m: Copied from Tools/MiniBrowser/mac/BrowserWindowController.m.

(-[WK2BrowserWindowController initWithContext:pageGroup:]):
(-[WK2BrowserWindowController dealloc]):
(-[WK2BrowserWindowController fetch:]):
(-[WK2BrowserWindowController showHideWebView:]):
(-[WK2BrowserWindowController removeReinsertWebView:]):
(-[WK2BrowserWindowController validateMenuItem:]):
(-[WK2BrowserWindowController reload:]):
(-[WK2BrowserWindowController forceRepaint:]):
(-[WK2BrowserWindowController goBack:]):
(-[WK2BrowserWindowController goForward:]):
(-[WK2BrowserWindowController validateUserInterfaceItem:]):
(-[WK2BrowserWindowController validateToolbar]):
(-[WK2BrowserWindowController windowShouldClose:]):
(-[WK2BrowserWindowController windowWillClose:]):
(-[WK2BrowserWindowController applicationTerminating]):
(-[WK2BrowserWindowController currentZoomFactor]):
(-[WK2BrowserWindowController setCurrentZoomFactor:]):
(-[WK2BrowserWindowController canZoomIn]):
(-[WK2BrowserWindowController zoomIn:]):
(-[WK2BrowserWindowController canZoomOut]):
(-[WK2BrowserWindowController zoomOut:]):
(-[WK2BrowserWindowController canResetZoom]):
(-[WK2BrowserWindowController resetZoom:]):
(-[WK2BrowserWindowController toggleZoomMode:]):
(-[WK2BrowserWindowController isPaginated]):
(-[WK2BrowserWindowController togglePaginationMode:]):
(-[WK2BrowserWindowController dumpSourceToConsole:]):
(didStartProvisionalLoadForFrame):
(didReceiveServerRedirectForProvisionalLoadForFrame):
(didFailProvisionalLoadWithErrorForFrame):
(didCommitLoadForFrame):
(didFinishDocumentLoadForFrame):
(didFinishLoadForFrame):
(didFailLoadWithErrorForFrame):
(didSameDocumentNavigationForFrame):
(didReceiveTitleForFrame):
(didFirstLayoutForFrame):
(didFirstVisuallyNonEmptyLayoutForFrame):
(didRemoveFrameFromHierarchy):
(didDisplayInsecureContentForFrame):
(didRunInsecureContentForFrame):
(didDetectXSSForFrame):
(didStartProgress):
(didChangeProgress):
(didFinishProgress):
(didBecomeUnresponsive):
(didBecomeResponsive):
(processDidExit):
(didChangeBackForwardList):
(decidePolicyForNavigationAction):
(decidePolicyForNewWindowAction):
(decidePolicyForResponse):
(createNewPage):
(showPage):
(closePage):
(runJavaScriptAlert):
(runJavaScriptConfirm):
(runJavaScriptPrompt):
(setStatusText):
(mouseDidMoveOverElement):
(getWindowFrame):
(setWindowFrame):
(runBeforeUnloadConfirmPanel):
(runOpenPanel):
(-[WK2BrowserWindowController awakeFromNib]):
(-[WK2BrowserWindowController didStartProgress]):
(-[WK2BrowserWindowController didChangeProgress:]):
(-[WK2BrowserWindowController didFinishProgress]):
(-[WK2BrowserWindowController updateProvisionalURLForFrame:]):
(-[WK2BrowserWindowController didStartProvisionalLoadForFrame:]):
(-[WK2BrowserWindowController didReceiveServerRedirectForProvisionalLoadForFrame:]):
(-[WK2BrowserWindowController didFailProvisionalLoadWithErrorForFrame:]):
(-[WK2BrowserWindowController didFailLoadWithErrorForFrame:]):
(-[WK2BrowserWindowController didSameDocumentNavigationForFrame:]):
(-[WK2BrowserWindowController didCommitLoadForFrame:]):
(-[WK2BrowserWindowController loadURLString:]):
(-[WK2BrowserWindowController performFindPanelAction:]):
(-[WK2BrowserWindowController find:]):

5:38 PM Changeset in webkit [130570] by wangxianzhu@chromium.org
  • 5 edits
    2 adds in trunk

OpenTypeVerticalData issue with DroidSansFallback.ttf on chromium-android and chromium-linux
https://bugs.webkit.org/show_bug.cgi?id=97824

Reviewed by Tony Chang.

Source/WebCore:

The issue occurred when a font that contains vert GSUB table but doesn't have
a DFLT script and the first script doesn't have vert feature. Added logic to
handle the case.

Test: fast/writing-mode/vertical-subst-font-vert-no-dflt.html

  • platform/graphics/opentype/OpenTypeVerticalData.cpp:

(FeatureList):
(WebCore::OpenType::FeatureList::findFeature): Added to find the matching feature in FeatureList.
(WebCore::OpenType::GSUBTable::feature): Added logic to handle the case of no DFLT script and no vert feature under the first script.

LayoutTests:

Ref test for the change. The punctuations in the vertical text are expected to
be substituted with the corresponding vertical forms.

  • fast/writing-mode/vertical-subst-font-vert-no-dflt-expected.html: Added.
  • fast/writing-mode/vertical-subst-font-vert-no-dflt.html: Added.
  • platform/mac/TestExpectations: Added the new test as it fails on Mac because of https://bugs.webkit.org/show_bug.cgi?id=98560.
4:57 PM Changeset in webkit [130569] by tony@chromium.org
  • 10 edits
    2 adds
    23 deletes in trunk

Form controls should always be horizontal
https://bugs.webkit.org/show_bug.cgi?id=98563

Reviewed by Ojan Vafai.

Source/WebCore:

Fix a regression where we didn't force form controls to be horizontal.

Tests: fast/dom/HTMLMeterElement/meter-writing-mode.html

fast/dom/HTMLProgressElement/progress-writing-mode.html
fast/table/colspanMinWidth-vertical.html

  • css/html.css:

(input, textarea, keygen, select, button, isindex, meter, progress):

LayoutTests:

Convert fast/dom/HTMLMeterElement/meter-writing-mode.html and
fast/dom/HTMLProgressElement/progress-writing-mode.html to be ref tests.
Also rebaseline fast/table/colspanMinWidth-vertical.html and mark the
test as needing a rebaseline on platforms other than Chromium Linux.

  • fast/dom/HTMLMeterElement/meter-writing-mode-expected.html: Added.
  • fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
  • fast/dom/HTMLProgressElement/progress-writing-mode-expected.html: Added.
  • fast/dom/HTMLProgressElement/progress-writing-mode-expected.png: Removed.
  • fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
  • platform/chromium-linux/fast/table/colspanMinWidth-vertical-expected.png:
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
  • platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png: Removed.
  • platform/efl/TestExpectations:
  • platform/efl/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
  • platform/efl/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
  • platform/efl/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
  • platform/gtk/TestExpectations:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
  • platform/gtk/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
  • platform/mac/TestExpectations:
  • platform/mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
  • platform/mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
  • platform/mac/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png: Removed.
  • platform/mac/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
  • platform/qt-5.0/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
  • platform/qt/TestExpectations:
  • platform/qt/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
  • platform/qt/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
4:42 PM Changeset in webkit [130568] by commit-queue@webkit.org
  • 12 edits in trunk

[WK2][WTR] WebKitTestRunner needs testRunner.setSerializeHTTPLoads
https://bugs.webkit.org/show_bug.cgi?id=98524

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-05
Reviewed by Alexey Proskuryakov.

Source/WebKit2:

Add implementation for testRunner.setSerializeHTTPLoads in
WebKitTestRunner.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetSerialLoadingEnabled):

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setSerialLoadingEnabled):
(WebKit):

  • WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

Tools:

Add implementation for testRunner.setSerializeHTTPLoads in
WebKitTestRunner.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setSerializeHTTPLoads):
(WTR):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

LayoutTests:

Unskip tests that are now passing.

  • platform/wk2/TestExpectations:
4:28 PM Changeset in webkit [130567] by commit-queue@webkit.org
  • 30 edits
    1 delete in trunk

Unreviewed, rolling out r130556 and r130564.
http://trac.webkit.org/changeset/130556
http://trac.webkit.org/changeset/130564
https://bugs.webkit.org/show_bug.cgi?id=98572

The patch wasn't reviewed by a reviewer and it is breaking
Chromium Windows (Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-05

Source/WebCore:

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • css/mediaControls.css:

(video::-webkit-media-text-track-container):
(video::-webkit-media-text-track-past-nodes):
(video::-webkit-media-text-track-future-nodes):
(video::-webkit-media-text-track-display):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::attach):
(WebCore::HTMLMediaElement::userIsInterestedInThisLanguage):
(WebCore::HTMLMediaElement::userIsInterestedInThisTrackKind):
(WebCore::HTMLMediaElement::setClosedCaptionsVisible):
(WebCore::HTMLMediaElement::updateClosedCaptionsControls):

  • html/HTMLMediaElement.h:

(HTMLMediaElement):

  • html/shadow/MediaControlElements.cpp:

(WebCore):
(WebCore::MediaControlTextTrackContainerElement::updateSizes):

  • html/shadow/MediaControlElements.h:

(MediaControlTextTrackContainerElement):

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::updateTextTrackDisplay):

  • html/shadow/MediaControlRootElement.h:

(MediaControlRootElement):

  • html/shadow/MediaControls.h:

(MediaControls):

  • html/track/TextTrack.cpp:

(WebCore::TextTrack::TextTrack):
(WebCore::TextTrack::isValidKindKeyword):
(WebCore::TextTrack::setKind):
(WebCore::TextTrack::setMode):
(WebCore::TextTrack::mode):

  • html/track/TextTrack.h:

(WebCore::TextTrack::create):
(WebCore::TextTrack::kind):
(TextTrack):
(WebCore::TextTrack::label):
(WebCore::TextTrack::setLabel):
(WebCore::TextTrack::language):
(WebCore::TextTrack::setLanguage):

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCueBox::TextTrackCueBox):
(WebCore::TextTrackCueBox::shadowPseudoId):
(WebCore):
(WebCore::TextTrackCue::updateDisplayTree):

  • html/track/TextTrackCue.h:

(TextTrackCueBox):
(TextTrackCue):

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
  • rendering/CaptionPreferencesChangedListener.h: Removed.
  • rendering/RenderTheme.h:

(WebCore):
(RenderTheme):

  • rendering/RenderThemeMac.h:

(RenderThemeMac):

  • rendering/RenderThemeMac.mm:

(WebCore):
(WebCore::RenderThemeMac::RenderThemeMac):
(WebCore::RenderThemeMac::~RenderThemeMac):

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

WebKitLibraries:

  • WebKitSystemInterface.h:

LayoutTests:

  • media/track/track-cue-rendering-expected.txt:
  • media/track/track-cue-rendering.html:
  • platform/chromium/TestExpectations:
3:59 PM Changeset in webkit [130566] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Set the current working directory to TMPDIR when entering the sandbox in the plug-in process.
Based on a patch by Ivan Krstić.

Reviewed by Anders Carlsson.

  • WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm:

(enterSandbox):

3:56 PM Changeset in webkit [130565] by timothy_horton@apple.com
  • 9 edits in trunk/Source

[cg] GraphicsContextCG should ask CG whether the shadow offset workaround is required
https://bugs.webkit.org/show_bug.cgi?id=98565
<rdar://problem/12436468>

Reviewed by Simon Fraser.

On Mountain Lion and above, CG can tell us whether we need to work around incorrect
shadow offsets. Prior to Mountain Lion, we should assume we need to apply the workaround.

No new tests, as this requires an obscure configuration to test.

  • WebCore.exp.in:
  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::applyShadowOffsetWorkaroundIfNeeded):
(WebCore::GraphicsContext::setPlatformShadow):

  • platform/mac/WebCoreSystemInterface.h: Add wkCGContextDrawsWithCorrectShadowOffsets.
  • platform/mac/WebCoreSystemInterface.mm: Add wkCGContextDrawsWithCorrectShadowOffsets.

Add wkCGContextDrawsWithCorrectShadowOffsets.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

3:53 PM Changeset in webkit [130564] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix the build.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::captionsWindowColor):

3:30 PM Changeset in webkit [130563] by timothy_horton@apple.com
  • 5 edits in trunk/WebKitLibraries

Update WebKitSystemInterface libraries and header.

Reviewed by Simon Fraser.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceMountainLion.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
3:30 PM Changeset in webkit [130562] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

TestResultsServer does not display sync_integration_tests results
https://bugs.webkit.org/show_bug.cgi?id=98551

Patch by Richard Larocque <rlarocque@chromium.org> on 2012-10-05
Reviewed by Ojan Vafai.

Allow builders whose name contains "Sync" to pass through the
isChromiumWebkitDepsTestRunner filter.

The test expectations in flakiness_dashboard_unittests.js have been
updated to match the new behaviour.

  • TestResultServer/static-dashboards/builders.js:

(isChromiumDepsGTestRunner):

3:13 PM Changeset in webkit [130561] by jchaffraix@webkit.org
  • 2 edits
    8 adds
    4 deletes in trunk/LayoutTests

Unreviewed Chromium gardening.

  • platform/chromium/TestExpectations:

Updated a wrong bug info and rebaselined 2 tests:
fast/reflections/inline-crash.html and fast/backgrounds/solid-color-context-restore.html

  • fast/backgrounds/solid-color-context-restore-expected.txt: Added.
  • fast/reflections/inline-crash-expected.txt: Added.
  • platform/chromium-linux/fast/backgrounds/solid-color-context-restore-expected.png: Added.
  • platform/chromium-linux/fast/reflections/inline-crash-expected.png: Added.
  • platform/chromium-win/fast/backgrounds/solid-color-context-restore-expected.png: Added.
  • platform/chromium-win/fast/backgrounds/solid-color-context-restore-expected.txt: Added.
  • platform/chromium-win/fast/reflections/inline-crash-expected.png: Added.
  • platform/chromium-win/fast/reflections/inline-crash-expected.txt: Added.
  • platform/efl/fast/backgrounds/solid-color-context-restore-expected.txt: Removed.
  • platform/efl/fast/reflections/inline-crash-expected.txt: Removed.
  • platform/gtk/fast/backgrounds/solid-color-context-restore-expected.txt: Removed.
  • platform/gtk/fast/reflections/inline-crash-expected.txt: Removed.
3:09 PM Changeset in webkit [130560] by eric@webkit.org
  • 4 edits in trunk/Source/WebCore

Remove needless virtual calls and inline RenderStyle::logical* to make table layout faster
https://bugs.webkit.org/show_bug.cgi?id=98550

Reviewed by Andreas Kling.

This shaved another 5% (100ms) off of the runtime of resizecol.html microbenchmark:
http://www.robohornet.org/tests/resizecol.html

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::recalcColumn):

  • rendering/style/RenderStyle.cpp:
  • rendering/style/RenderStyle.h:
3:08 PM Changeset in webkit [130559] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Tests in webkitpy involving child processes are flaky.
Skipping run_webkit_tests_integrationtest.py.
https://bugs.webkit.org/show_bug.cgi?id=98559

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_verbose_in_child_processes):

3:05 PM Changeset in webkit [130558] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Only define SK_SUPPORT_HINTING_SCALE_FACTOR when building for chromeOS
https://bugs.webkit.org/show_bug.cgi?id=98526

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-10-05
Reviewed by Stephen White.

This is causing some problems with picture serialization between chrome
and the mainline skia tools. (Once this change lands and is gardened in,
I will make the corresponding change in chromium/skia/skia.gyp)

  • features.gypi:
3:01 PM Changeset in webkit [130557] by commit-queue@webkit.org
  • 1 edit
    2 moves
    8 adds in trunk/LayoutTests

[CSS Exclusions] Add shape-inside tests for rounded rectangles
https://bugs.webkit.org/show_bug.cgi?id=96669

Patch by Bear Travis <betravis@adobe.com> on 2012-10-05
Reviewed by Levi Weintraub.

Adding multiple rounded rectangle tests. The more complex tests use float "sandbags"
to simulate the shape-inside area in the test expectations.
(See http://www.alistapart.com/articles/sandbags/)
In general, each line has its own pair of left and right floats (both lineHeight tall),
to position the text and appropriately limit its width. In the simple, 0 corner radius
cases, these floats can be merged because they all have the same width on the left and
right.

  • fast/exclusions/resources/rounded-rectangle.js: Contains functionality for generating

a shape-inside, simulating one, and generating content that should roughly fill the
shape-inside.
(xFromEllipseCenter): The x distance from the center of an ellipse, based on its y
distance from center.
(xInset): The inset of a rounded rectangle from its bounding box.
(generateString): Generate a string that roughly fills a shape-inside's content area.
(simulateShape): Create floats to simulate a shape-inside area.
(simulateShapeOutline): Create an outline for the rounded rectangle shape-inside.
(generateSimulatedShapeElement): Simulate a shape-inside and appropriately fill it
with content.
(generateShapeElement): Create a shape-inside and fill it with content.

  • fast/exclusions/shape-inside/shape-inside-rounded-rectangle-001-expected.html:

Renamed from LayoutTests/fast/exclusions/shape-inside/shape-inside-rounded-rectangle-expected.html.

  • fast/exclusions/shape-inside/shape-inside-rounded-rectangle-001.html:

Renamed from LayoutTests/fast/exclusions/shape-inside/shape-inside-rounded-rectangle.html.

  • fast/exclusions/shape-inside/shape-inside-rounded-rectangle-002-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-rounded-rectangle-002.html: Added.
  • fast/exclusions/shape-inside/shape-inside-rounded-rectangle-003-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-rounded-rectangle-003.html: Added.
  • fast/exclusions/shape-inside/shape-inside-rounded-rectangle-004-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-rounded-rectangle-004.html: Added.
2:57 PM Changeset in webkit [130556] by jer.noble@apple.com
  • 30 edits
    1 add in trunk

Allow ports to override text track rendering style
https://bugs.webkit.org/show_bug.cgi?id=97800
<rdar://problem/12044964>

Patch by Eric Carlson <eric.carlson@apple.com> on 2012-10-04
Reviewed by Silvia Pfeiffer.

Source/WebCore:

  • WebCore.exp.in: Export new WebkitSystemInterface functions.
  • WebCore.xcodeproj/project.pbxproj: Add CaptionPreferencesChangedListener.h.
  • css/mediaControls.css: Rearrange the caption CSS so it is possible to style the cue window,

background, and text independently.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_disableCaptions with theme->userPrefersCaptions().
(WebCore::HTMLMediaElement::attach): Register for caption preferences change callbacks.
(WebCore::HTMLMediaElement::detach): Unregister for caption preferences change callbacks.
(WebCore::HTMLMediaElement::userPrefersCaptions): Return theme->userPrefersCaptions().
(WebCore::HTMLMediaElement::userIsInterestedInThisTrackKind): Consider userPrefersCaptions().
(WebCore::HTMLMediaElement::setClosedCaptionsVisible): Move the code that marks all tracks as

un-configured to markCaptionAndSubtitleTracksAsUnconfigured so it can be reused.

(WebCore::HTMLMediaElement::captionPreferencesChanged): New, force a reevaluation of all text tracks.
(WebCore::HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured): New, code moved from

setClosedCaptionsVisible

  • html/HTMLMediaElement.h: Inherit from CaptionPreferencesChangedListener.
  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::userCaptionPreferencesChanged): New, if theme

has a captions style sheet override, inject it into the current page group, otherwise
remove injected sheet.

(WebCore::MediaControlTextTrackContainerElement::updateSizes): Get rid of unnecessary member

variable. Get caption font scale from theme instead of hard coding.

  • html/shadow/MediaControlElements.h:
  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::userCaptionPreferencesChanged): New.
(WebCore::MediaControlRootElement::updateTextTrackDisplay):

  • html/shadow/MediaControlRootElement.h: Add userCaptionPreferencesChanged, minor cleanup.
  • html/shadow/MediaControls.h:

(WebCore::MediaControls::userCaptionPreferencesChanged): New.

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCueBox::TextTrackCueBox): Set the shadow pseudo id.
(WebCore::TextTrackCueBox::textTrackCueBoxShadowPseudoId): New, class method to return the

shadow pseudo id so it can be used elsewhere.

(WebCore::TextTrackCueBox::shadowPseudoId): Call textTrackCueBoxShadowPseudoId.
(WebCore::TextTrackCue::pastNodesShadowPseudoId): New, class method to return the

shadow pseudo id so it can be used elsewhere.

(WebCore::TextTrackCue::futureNodesShadowPseudoId): Ditto.
(WebCore::TextTrackCue::updateDisplayTree):

  • html/track/TextTrackCue.h:
  • platform/mac/WebCoreSystemInterface.h: Updated.
  • platform/mac/WebCoreSystemInterface.mm: Ditto.
  • rendering/CaptionPreferencesChangedListener.h: Added.
  • rendering/RenderTheme.h:

(WebCore::RenderTheme::userPrefersCaptions): New, default do-nothing implementation.
(WebCore::RenderTheme::userHasCaptionPreferences): Ditto.
(WebCore::RenderTheme::captionFontSizeScale): Ditto.
(WebCore::RenderTheme::captionsStyleSheetOverride): Ditto.
(WebCore::RenderTheme::registerForCaptionPreferencesChangedCallbacks): Ditto.
(WebCore::RenderTheme::unregisterForCaptionPreferencesChangedCallbacks): Ditto.

  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm:

(WebCore::userCaptionPreferencesChangedNotificationCallback): New, receives preference changed notifications.
(WebCore::RenderThemeMac::RenderThemeMac): Initialize m_listeningForCaptionPreferenceNotifications.
(WebCore::RenderThemeMac::~RenderThemeMac): Unregister for notifications if necessary.
(WebCore::RenderThemeMac::userHasCaptionPreferences): New, passthrough to WKSI function.
(WebCore::RenderThemeMac::userPrefersCaptions): Ditto.
(WebCore::RenderThemeMac::captionsWindowColor): Return Color with user's caption window color preference.
(WebCore::RenderThemeMac::captionsBackgroundColor): Return Color with user's caption

background color preference.

(WebCore::RenderThemeMac::captionsTextColor): Return Color with user's caption text color preference.
(WebCore::RenderThemeMac::captionsEdgeColorForTextColor): Return Color for text edge effect.
(WebCore::RenderThemeMac::cssPropertyWithTextEdgeColor): Return String with CSS to set a text-shadow

or webkit-text-stroke property.

(WebCore::RenderThemeMac::cssColorProperty): Return a String with css to set a property

with a color value.

(WebCore::RenderThemeMac::captionsTextEdgeStyle): Return a String with css to style caption

text with the user's preferred text edge stye.

(WebCore::RenderThemeMac::captionsDefaultFont): Return a String with css to style caption

text with the user's preferred font.

(WebCore::RenderThemeMac::captionsStyleSheetOverride): Return a String with css to style captions

with the user's preferred style.

(WebCore::RenderThemeMac::captionFontSizeScale): Return the user's preferred caption font scale.
(WebCore::RenderThemeMac::captionPreferencesChanged): Notify listeners of caption preference change.
(WebCore::RenderThemeMac::registerForCaptionPreferencesChangedCallbacks): Add a caption preferences

changes listener.

(WebCore::RenderThemeMac::unregisterForCaptionPreferencesChangedCallbacks): Remove a caption preferences

changes listener.

Source/WebKit/mac:

Add WCSI support for new WKSI caption functions.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Initialize new WKSI function pointers.

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Initialize new WKSI function pointers.

WebKitLibraries:

Update WKSI header with SPI for getting the user caption appearance preferences.

  • WebKitSystemInterface.h:

LayoutTests:

  • media/track/track-cue-rendering-expected.txt: Update results for caption css changes.
  • media/track/track-cue-rendering.html:
  • platform/chromium/TestExpectations: Skip tests that need to be rebaselined.
2:54 PM Changeset in webkit [130555] by commit-queue@webkit.org
  • 6 edits
    4 adds in trunk

Inline continuations create :after generated content on style recalcs
https://bugs.webkit.org/show_bug.cgi?id=93170

Patch by Takashi Sakamoto <tasak@google.com> on 2012-10-05
Reviewed by Abhishek Arya.

Source/WebCore:

The bug is caused by RenderInline::styleDidChange's setContinuation(0).
RenderObjectChildList uses continuation to know whether the given
renderer should have AFTER render object or not.
However, setContinuation(0) makes RenderObjectChildList to
misunderstand that all continuations are last continuation.
To avoid the misunderstanding, added a new flag to class
RenderObejctChildList to enable/disable updating :after content (and
also :before content).

Tests: fast/css-generated-content/after-with-inline-continuation.html

fast/css-generated-content/dynamic-apply-after-for-inline.html

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::styleDidChange):
Disable upating :after content for continuations which are not
the last one during setStyle just after setContinuation(0).
The setStyle invokes RenderInline::styleDidChange and also invokes
updateBeforeAfterContent via the styleDidChange. This means,
the last continuation's updateBeforeAfterContent is also invoked
after setContinuation(0). We have to update :after for the last
continuation.

  • rendering/RenderObjectChildList.cpp:

(WebCore):
(WebCore::RenderObjectChildList::updateBeforeAfterContent):
If s_updateBeforeAfterContent is false, quickly exit
updateBeforeAfterContent.

  • rendering/RenderObjectChildList.h:

(RenderObjectChildList):
Added a new flag s_enableUpdateBeforeAfterContent to enable/disable
updating :before or :after content.

LayoutTests:

  • fast/css-generated-content/after-with-inline-continuation-expected.html: Added.
  • fast/css-generated-content/after-with-inline-continuation.html: Added.
  • fast/css-generated-content/dynamic-apply-after-for-inline-expected.html: Added.
  • fast/css-generated-content/dynamic-apply-after-for-inline.html: Added.
  • http/tests/misc/acid3-expected.txt:

The acid3-expected.txt has the duplicate RenderBlock (positioned).
Two 'layer at(638, 18) size 20x20, ... text run at (0,0) width 20: "X"'
exist. So did reset-results for acid3-expected.txt.

2:51 PM Changeset in webkit [130554] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

Don't assume that TileCache layers are opaque
https://bugs.webkit.org/show_bug.cgi?id=98555

Reviewed by Dean Jackson.

TileCache previously set all its tile CALayers as opaque.
However, we will need non-opaque tile caches when we use this
tile cache for tiled layers, so add a member function to
control tile opacity.

RenderLayerBacking already calls m_graphicsLayer->setContentsOpaque()
using the FrameView's notion of opaqueness, so this change will
cause the main tile cache to be non-opaque if external forces have
set the FrameView to be non-opaque.

Also tweak the layer border widths on tiled layers.

  • platform/graphics/ca/mac/TileCache.h:

(TileCache):
(WebCore::TileCache::tilesAreOpaque):

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::TileCache):
(WebCore::TileCache::setTilesOpaque):
(WebCore::TileCache::createTileLayer):

  • platform/graphics/ca/mac/WebTileCacheLayer.mm:

(-[WebTileCacheLayer setOpaque:]):
(-[WebTileCacheLayer isOpaque]):
(-[WebTileCacheLayer setBorderWidth:]):

2:39 PM Changeset in webkit [130553] by tony@chromium.org
  • 5 edits in trunk

Fix margin box ascent computation in flexbox
https://bugs.webkit.org/show_bug.cgi?id=98540

Reviewed by Ojan Vafai.

Source/WebCore:

The margin box ascent doesn't depend on the margin below the box.

Tests: css3/flexbox/flex-align.html: Fixed a test case and removed a FIXME.

css3/flexbox/flex-align-vertical-writing-mode.html: Similar test case.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::marginBoxAscentForChild):

LayoutTests:

Remove a FIXME and update the results.

  • css3/flexbox/flex-align-vertical-writing-mode.html:
  • css3/flexbox/flex-align.html:
2:38 PM Changeset in webkit [130552] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed.

Disable WebFrameTest.DivScrollIntoEditableTest. The test depends on
some code that is conditionally compiled and therefore fails in some
configurations.

  • tests/WebFrameTest.cpp:
2:22 PM Changeset in webkit [130551] by wjmaclean@chromium.org
  • 4 edits
    1 move
    14 adds
    2 deletes in trunk

[chromium] Enhance support for transforms in LinkHighlight.
https://bugs.webkit.org/show_bug.cgi?id=94355

Reviewed by Adrienne Walker.

Improved handling of transformed highlight targets, where the transform goes beyond simple translation.

Source/WebKit/chromium:

  • src/LinkHighlight.cpp:

(WebKit::convertTargetSpaceQuadToCompositedLayer): Converts target space quad to composited layer coordinates.
(WebKit):
(WebKit::addQuadToPath): Supports adding non-rectilinear quads to Path.
(WebKit::LinkHighlight::computeHighlightLayerPathAndPosition): Updated to deal with target's quadlist, transform individual quads according to transforms.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::bestTouchLinkNode):

LayoutTests:

  • platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-multi-line.html: Added.
  • platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated-div.html: Added.
  • platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated-link.html: Added.
  • platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledX.html: Added.
  • platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledY.html: Added.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-ZIndex-expected.png: Removed.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-ZIndex-expected.txt: Removed.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-multi-line-expected.png: Added.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-multi-line-expected.txt: Added.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated-div-expected.png: Added.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated-div-expected.txt: Added.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated-link-expected.png: Added.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated-link-expected.txt: Added.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledX-expected.png: Added.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledX-expected.txt: Added.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledY-expected.png: Added.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledY-expected.txt: Added.
2:13 PM Changeset in webkit [130550] by jchaffraix@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed build fix after r130545.

  • tests/WebFrameTest.cpp:

Avoid a warning about truncating the double constant on Windows. While touching the variable, changed
it to be proper camelCase.

2:12 PM Changeset in webkit [130549] by ojan@chromium.org
  • 5 edits
    2 adds in trunk

Deprecated flexboxes subtract scrollbar width/height twice
https://bugs.webkit.org/show_bug.cgi?id=98552

Reviewed by Tony Chang.

Source/WebCore:

This is a regression from http://trac.webkit.org/changeset/119507.
The problem is that contentHeight subtracts the scrollbar and
RenderDeprecatedFlexbox subtracts the scrollbar.

-Make it so that we only access override sizes if one has been set.
I think this makes the calling code more clear.
-If we don't have one set, grab the height/width - borderAndPadding.
-Add a FIXME to change this all back to being borderbox sizes.
There's something trick with making table padding/border work right for that
though (noted in the original patch).

Test: fast/flexbox/flexing-overflow-scroll-item.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::overrideLogicalContentWidth):
(WebCore::RenderBox::overrideLogicalContentHeight):
(WebCore::RenderBox::availableLogicalHeightUsing):

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::contentWidthForChild):
(WebCore):
(WebCore::contentHeightForChild):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
(WebCore::RenderDeprecatedFlexibleBox::allowedChildFlex):

LayoutTests:

  • fast/flexbox/flexing-overflow-scroll-item-expected.txt: Added.
  • fast/flexbox/flexing-overflow-scroll-item.html: Added.
1:47 PM Changeset in webkit [130548] by eric@webkit.org
  • 3 edits in trunk/Source/WebCore

Make tables which don't use col/row span much faster to layout
https://bugs.webkit.org/show_bug.cgi?id=98221

Reviewed by Julien Chaffraix.

My sense is that most tables on webpages do not use colspan/rowspan
so I stole another bit from RenderTableCell::m_column to avoid
having to re-parse the colSpan/rowSpan attributes for every cell
when doing table layout.
This made these symbols disappear from biggrid.html/redraw.html (dglazkov's spreadsheets benchmarks)
as well as moved our robohornet/resizecol.html number from an average of 3221ms to 2608ms (~20%!).

I removed m_hasHTMLTableCellElement (from http://trac.webkit.org/changeset/97691)
since it was attempting to do the same sort of optimization.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::RenderTableCell):
(WebCore::RenderTableCell::parseColSpanFromDOM):
(WebCore::RenderTableCell::parseRowSpanFromDOM):
(WebCore::RenderTableCell::layout):

  • rendering/RenderTableCell.h:

(WebCore::RenderTableCell::colSpan):
(WebCore::RenderTableCell::rowSpan):
(RenderTableCell):

1:45 PM Changeset in webkit [130547] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk/Source

Source/WebCore: Allow EventHandler to handle longpress gestures, including longpress selection on Android.
https://bugs.webkit.org/show_bug.cgi?id=98173

Patch by Oli Lan <olilan@chromium.org> on 2012-10-05
Reviewed by Ryosuke Niwa.

Adds handling for GestureLongPress to EventHandler::handleGestureEvent, with a new
handleGestureLongPress method. On Android, this method selects the closest word
if the gesture event was over non-link text.

This is tested via a new chromium test WebViewTest.LongPressSelection.

  • page/EventHandler.cpp:

(WebCore::EventHandler::selectClosestWordFromHitTestResult):
(WebCore::EventHandler::selectClosestWordFromMouseEvent):
(WebCore):
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleGestureLongPress):

  • page/EventHandler.h:

(EventHandler):

Source/WebKit/chromium: Allow EventHandler to handle longpress gestures, including longpress selection on Android.
https://bugs.webkit.org/show_bug.cgi?id=98173

Patch by Oli Lan <olilan@chromium.org> on 2012-10-05
Reviewed by Ryosuke Niwa.

This patch changes the longpress gesture handling code in WebViewImpl to call EventHandler::handleGestureEvent.
The WebCore part of this patch adds longpress handling to that method, including the long press selection behaviour
required for Android. This means that a long press gesture performed on word (that is not part of a link)
selects the word, without generating a context menu event.

A new test, WebViewTest.LongPressSelection has been added to test this.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):
(WebViewImpl):

  • tests/WebViewTest.cpp:
  • tests/data/longpress_selection.html: Added.
1:33 PM Changeset in webkit [130546] by rniwa@webkit.org
  • 5 edits
    22 deletes in trunk/LayoutTests

GTK+ and Qt rebaselines after r130532.

  • platform/chromium-linux-x86/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
  • platform/chromium-linux-x86/editing/pasteboard/paste-text-002-expected.txt: Removed.
  • platform/chromium-linux-x86/editing/pasteboard/paste-text-003-expected.txt: Removed.
  • platform/chromium-linux/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-text-002-expected.txt: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-text-003-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-002-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-003-expected.txt: Removed.
  • platform/chromium-win-xp/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
  • platform/chromium-win-xp/editing/pasteboard/paste-text-002-expected.txt: Removed.
  • platform/chromium-win-xp/editing/pasteboard/paste-text-003-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-002-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-003-expected.txt: Removed.
  • platform/chromium/svg/custom/delete-text-crash-expected.txt: Removed.
  • platform/chromium/svg/custom/delete-text-innerText-crash-expected.txt: Removed.
  • platform/gtk/editing/deleting/delete-block-merge-contents-001-expected.txt:
  • platform/gtk/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/merge-end-blockquote-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-002-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-text-003-expected.txt: Removed.
  • platform/qt/editing/deleting/delete-block-merge-contents-001-expected.txt:
  • platform/qt/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
  • platform/qt/editing/pasteboard/merge-end-blockquote-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-002-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-text-003-expected.txt: Removed.
1:30 PM Changeset in webkit [130545] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk/Source/WebKit/chromium

[chromium] Support zooming focused node for mobile devices
https://bugs.webkit.org/show_bug.cgi?id=97958

Patch by Yusuf Ozuysal <yusufo@google.com> on 2012-10-05
Reviewed by Adam Barth.

This unforks the Android version of scrollFocusedNodeIntoRect().A new setting
autoZoomFocusedNodeToLegibleScale was added to turn it on, since not all
platforms with ENABLE(GESTURE_EVENTS) want this.

Test: WebFrameTest.DivScrollIntoEditableTest

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setAutoZoomFocusedNodeToLegibleScale):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):
(WebKit::WebSettingsImpl::autoZoomFocusedNodeToLegibleScale):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::scrollFocusedNodeIntoRect):

  • tests/WebFrameTest.cpp:
  • tests/data/get_scale_for_zoom_into_editable_test.html: Added.
1:25 PM Changeset in webkit [130544] by rniwa@webkit.org
  • 10 edits
    11 adds in trunk/LayoutTests

Chromium and Mac rebaselines after r130532.

  • platform/chromium-linux-x86/editing/pasteboard/interchange-newline-1-expected.txt: Added.
  • platform/chromium-linux-x86/editing/pasteboard/paste-text-002-expected.txt: Added.
  • platform/chromium-linux-x86/editing/pasteboard/paste-text-003-expected.txt: Added.
  • platform/chromium-linux/editing/pasteboard/interchange-newline-1-expected.txt: Added.
  • platform/chromium-linux/editing/pasteboard/paste-text-002-expected.txt: Added.
  • platform/chromium-linux/editing/pasteboard/paste-text-003-expected.txt: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-002-expected.txt:
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-003-expected.txt:
  • platform/chromium-win-xp/editing/pasteboard/interchange-newline-1-expected.txt: Added.
  • platform/chromium-win-xp/editing/pasteboard/paste-text-002-expected.txt: Added.
  • platform/chromium-win-xp/editing/pasteboard/paste-text-003-expected.txt: Added.
  • platform/chromium-win/editing/deleting/delete-block-merge-contents-001-expected.txt:
  • platform/chromium-win/editing/pasteboard/interchange-newline-1-expected.txt:
  • platform/chromium-win/editing/pasteboard/merge-end-blockquote-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-text-002-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-text-003-expected.txt:
  • platform/chromium/svg/custom/delete-text-crash-expected.txt: Added.
  • platform/chromium/svg/custom/delete-text-innerText-crash-expected.txt: Added.
  • svg/custom/delete-text-crash-expected.txt:
  • svg/custom/delete-text-innerText-crash-expected.txt:
12:55 PM Changeset in webkit [130543] by zandobersek@gmail.com
  • 5 edits in trunk

[Gtk] fast/xsl/xslt-missing-namespace-in-xslt.xml is failing on the 64-bit Debug builder
https://bugs.webkit.org/show_bug.cgi?id=91009

Reviewed by Martin Robinson.

Tools:

Include libxml2 into the jhbuild module. Version 2.8.0 introduces
a more correct (but not completely correct) behavior in the
fast/xsl/xslt-missing-namespace-in-xslt.html test.

  • gtk/jhbuild.modules:

LayoutTests:

Update the test's baselines. The output now properly shows the error.

  • platform/gtk/fast/xsl/xslt-missing-namespace-in-xslt-expected.png:
  • platform/gtk/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt:
12:46 PM Changeset in webkit [130542] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Fix lint error in TestExpectations from previous change.

Unreviewed.

  • platform/chromium/TestExpectations:
12:19 PM Changeset in webkit [130541] by commit-queue@webkit.org
  • 3 edits
    1 add
    15 deletes in trunk

<marquee> element forces itself to be at least 1em high, regardless of 'height' declaration
https://bugs.webkit.org/show_bug.cgi?id=18098

Patch by Tab Atkins <jackalmage@gmail.com> on 2012-10-05
Reviewed by Eric Seidel.

This restriction originally existed to match IE, but IE changed some time ago to be normal instead.
We're the last browser, afaict, to still enforce this de-facto restriction.
This patch makes <marquee> instead act like a normal element.

Tests: fast/css/MarqueeLayoutTest.html (rewritten from the older, bad version)

  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::updateMarqueeStyle):

12:18 PM Changeset in webkit [130540] by dpranke@chromium.org
  • 2 edits
    6 adds in trunk/LayoutTests

[chromium] tests failing after r130443.
https://bugs.webkit.org/show_bug.cgi?id=98545

Unreviewed, expectations change.

[chromium] fast/text/international/text-spliced-font.html and
fast/writing-mode/Kusa-Makura-background-canvas.html are failing on
the Mac after r130443 and we're not quite sure why ...

  • platform/chromium-linux/fast/text/vertical-rl-rtl-linebreak-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/vertical-rl-rtl-linebreak-expected.png: Added.
  • platform/chromium-mac/fast/text/vertical-rl-rtl-linebreak-expected.png: Added.
  • platform/chromium-mac/fast/text/vertical-rl-rtl-linebreak-expected.txt: Added.
  • platform/chromium-win/fast/text/vertical-rl-rtl-linebreak-expected.png: Added.
  • platform/chromium-win/fast/text/vertical-rl-rtl-linebreak-expected.txt: Added.
  • platform/chromium/TestExpectations:
12:05 PM Changeset in webkit [130539] by wjmaclean@chromium.org
  • 6 edits
    2 copies
    4 adds in trunk

[chromium] Modify gesture highlight behaviour. Cancel on GestureLongPress and animate on GestureTapCancel.
https://bugs.webkit.org/show_bug.cgi?id=97355

Reviewed by Adrienne Walker.

This patch revises the behaviour of GestureTapDown highlighting so that the highlight should disappear if
interrupted by GestureTap, and animate away if interrupted by GestureTapCancel.

Source/WebKit/chromium:

  • src/LinkHighlight.cpp:

(WebKit::LinkHighlight::LinkHighlight):
(WebKit::LinkHighlight::startHighlightAnimationIfNeeded):

  • src/LinkHighlight.h:

(LinkHighlight):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):
(WebKit::WebViewImpl::enableTouchHighlight):

LayoutTests:

  • platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-cancel.html: removed extra testRunner.display().
  • platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-cancel2.html: Added.
  • platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-longPress.html: Added.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-cancel2-expected.png: Added.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-cancel2-expected.txt: Added.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-longPress-expected.png: Added.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-longPress-expected.txt: Added.
12:01 PM Changeset in webkit [130538] by rwlbuis@webkit.org
  • 6 edits in trunk

[BlackBerry] Implement TestRunner.setMockDeviceOrientation
https://bugs.webkit.org/show_bug.cgi?id=98542

Reviewed by Antonio Gomes.

PR 120681

Source/WebKit/blackberry:

Provide framework for mock device motion.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

  • WebKitSupport/DumpRenderTreeSupport.cpp:

(toDeviceOrientationClientMock):
(DumpRenderTreeSupport::setMockDeviceOrientation):

  • WebKitSupport/DumpRenderTreeSupport.h:

(DumpRenderTreeSupport):

Tools:

This fixes tests in fast/dom/DeviceOrientation.

  • DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:

(TestRunner::setMockDeviceOrientation):

11:50 AM Changeset in webkit [130537] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Fix regression in proxy auth
https://bugs.webkit.org/show_bug.cgi?id=98533

Patch by Joe Mason <jmason@rim.com> on 2012-10-05
Reviewed by Yong Li.

The proxy auth dialog gets the proxy address from
BlackBerry::Platform::Settings::proxyAddress, which returns
"host:port", but we try to parse it with a KURL, which expects
"scheme://host:port". Since this is an http proxy, add http:// to the
url to get it to parse.

PR 220567.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::sendRequestWithCredentials):

11:41 AM Changeset in webkit [130536] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

REGRESSION (r129478-r129480): http/tests/loading/text-content-type-with-binary-extension.html failing on Apple MountainLion Debug WK2 (Tests)
https://bugs.webkit.org/show_bug.cgi?id=98527

Unreviewed gardening after r129479.

  • platform/mac-wk2/TestExpectations:
11:35 AM Changeset in webkit [130535] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Removing failure expectation for fast/text/vertical-rl-rtl-linebreak.html
since the test only needed platform-specific baselines (which were added
in r130524).

  • platform/gtk/TestExpectations:
11:34 AM Changeset in webkit [130534] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

No autorelease pool in place, causing buildup of autoreleased objects.
https://bugs.webkit.org/show_bug.cgi?id=98522
<rdar://problem/11647950>

Reviewed by Alexey Proskuryakov.

Wrap each timer callback in an AutodrainPool, ensuring an autorelease
pool is present during calls from C/C++ into ObjC.

  • platform/cf/RunLoopTimerCF.cpp:

(WebCore::timerFired):

11:32 AM Changeset in webkit [130533] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Have perf test assert worst order of magnitude
https://bugs.webkit.org/show_bug.cgi?id=98535

Reviewed by Tony Chang.

Really we only care if tests get order of magnitude slower.
Assert that tests are at least a certain magnitude.
Hopefully this will reduce flakiness some.

  • resources/magnitude-perf.js:

(Magnitude._run):

11:26 AM Changeset in webkit [130532] by rniwa@webkit.org
  • 8 edits
    2 adds in trunk

Deleting across multiple paragraphs can change the style of surrounding text
https://bugs.webkit.org/show_bug.cgi?id=97266

Reviewed by Levi Weintraub.

Source/WebCore:

Preserve editing styles from CSS rules in wrappingStyleForSerialization as well as inline styles
even when we're not annotating. We don't want to preserve all styles because it's against
the user expectation to keep borders, etc... when merging paragraphs. We also don't want to copy
styles from a mail blockquote because that's not a style the user has applied. See the comment
in EditingStyle::wrappingStyleForSerialization.

Test: editing/deleting/merge-paragraph-with-style-from-rule.html

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::mergeInlineAndImplicitStyleOfElement):
(WebCore::EditingStyle::wrappingStyleForSerialization):

LayoutTests:

Added a regression test and rebaselined tests.

  • editing/deleting/delete-before-block-image-2-expected.txt:
  • editing/deleting/merge-paragraph-from-p-with-style-expected.txt:
  • editing/deleting/merge-paragraph-from-p-with-style.html: We changed the behavior. The editing style of p

is now preserved when merging paragraphs.

  • editing/deleting/merge-paragraph-with-style-from-rule-expected.txt: Added.
  • editing/deleting/merge-paragraph-with-style-from-rule.html: Added.
  • platform/mac/editing/deleting/delete-block-merge-contents-001-expected.txt:
  • platform/mac/editing/pasteboard/merge-end-blockquote-expected.txt:
11:18 AM Changeset in webkit [130531] by mitz@apple.com
  • 3 edits in trunk/Source/WebCore

Reversing a GlyphBuffer needlessly queries its size multiple times
https://bugs.webkit.org/show_bug.cgi?id=98530

Reviewed by Simon Fraser.

No new tests because there is no change in behavior.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::getGlyphsAndAdvancesForSimpleText): Replaced the condition
(i < glyphBuffer.size() / 2) with the equivalent test (i < end).

  • platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore::Font::getGlyphsAndAdvancesForComplexText): Ditto.

11:09 AM Changeset in webkit [130530] by pilgrim@chromium.org
  • 42 edits in trunk/Source/WebKit/chromium

[Chromium] Update some more #includes for Platform/ directory
https://bugs.webkit.org/show_bug.cgi?id=98534

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

  • src/WebFormElement.cpp:
  • src/WebFrameImpl.cpp:
  • src/WebGeolocationClientMock.cpp:
  • src/WebGeolocationError.cpp:
  • src/WebGeolocationPermissionRequest.cpp:
  • src/WebHistoryItem.cpp:
  • src/WebHitTestResult.cpp:
  • src/WebIDBTransactionImpl.h:
  • src/WebIconLoadingCompletionImpl.h:
  • src/WebImageDecoder.cpp:
  • src/WebImageSkia.cpp:
  • src/WebInputElement.cpp:
  • src/WebKit.cpp:
  • src/WebLabelElement.cpp:
  • src/WebMediaStreamRegistry.cpp:
  • src/WebNode.cpp:
  • src/WebNotification.cpp:
  • src/WebOptionElement.cpp:
  • src/WebPageSerializer.cpp:
  • src/WebPageSerializerImpl.cpp:
  • src/WebPageSerializerImpl.h:
  • src/WebPluginListBuilderImpl.cpp:
  • src/WebPluginLoadObserver.h:
  • src/WebPopupMenuImpl.cpp:
  • src/WebPopupMenuImpl.h:
  • src/WebRange.cpp:
  • src/WebRegularExpression.cpp:
  • src/WebScriptController.cpp:
  • src/WebSecurityOrigin.cpp:
  • src/WebSecurityPolicy.cpp:
  • src/WebSelectElement.cpp:
  • src/WebSerializedScriptValue.cpp:
  • src/WebSessionDescriptionDescriptor.cpp:
  • src/WebSettingsImpl.cpp:
  • src/WebSocketImpl.cpp:
  • src/WebSocketImpl.h:
  • src/WebStorageEventDispatcherImpl.cpp:
  • src/WebSurroundingText.cpp:
  • src/WebURLLoadTiming.cpp:
  • src/WorkerAsyncFileWriterChromium.cpp:
  • src/WorkerFileSystemCallbacksBridge.cpp:
11:08 AM Changeset in webkit [130529] by jchaffraix@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

Unreviewed rebaseline after r130355.

r130447 forgot to update the Snow Leopard pixel baselines. The only differences are due to a different font used.

  • platform/chromium-mac-snowleopard/fast/clip/overflow-border-radius-combinations-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/clip/overflow-border-radius-fixed-position-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/clip/overflow-border-radius-transformed-expected.png: Added.
11:03 AM Changeset in webkit [130528] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Add expected result accidentally left out of http://trac.webkit.org/changeset/130337.

  • perf/adding-radio-buttons-expected.txt:
10:57 AM Changeset in webkit [130527] by kpiascik@rim.com
  • 1 edit
    1 delete in trunk/Source/WebKit/blackberry

[BlackBerry] Remove unnecessary html file.
https://bugs.webkit.org/show_bug.cgi?id=98531

Reviewed by Yong Li.

We now just use Source/WebCore/inspector/front-end/inspector.html
instead.

  • WebCoreSupport/inspectorBB.html: Removed.
10:56 AM Changeset in webkit [130526] by kareng@chromium.org
  • 1 edit in branches/chromium/1271/Source/WebCore/rendering/RenderLayer.cpp

Merge 130322 - [Sub-pixel layout] incorrect rendering when painting sub-layers as their own root
https://bugs.webkit.org/show_bug.cgi?id=97484

Reviewed by Eric Seidel.

When in compositing mode, layer painting can be triggered through the backing store. When this
happens, a non-top-level RenderLayer is called to paint as its own root. Normally, we attempt to preserve
the proper sub-pixel accumulation through layers to their children, but since we're not
starting with the top-level layer, we haven't properly accumulated one, and convertToLayerCoords,
another source of correctly getting the sub-pixel offset for a layer, also avoids crawling
past the listed root layer.

When painting a root layer, we're aligned to the surface we're painting to, so we round our
offset to avoid moving objects around.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayerContents):

TBR=leviw@chromium.org
Review URL: https://codereview.chromium.org/11031075

10:54 AM Changeset in webkit [130525] by Martin Robinson
  • 25 edits
    3 adds in trunk

[GTK] Add support for creating EGL contexts
https://bugs.webkit.org/show_bug.cgi?id=77921

Patch by José Dapena Paz <jdapena@igalia.com> on 2012-10-05
Reviewed by Martin Robinson.

This patch adds support for EGL, using OpenGL and OpenGL ES 2. Both
options are set up on compile time, with the configure options
--enable-egl and --enable-gles2.

The implementation only adds support for EGL on top of X11, to
isolate the changes to the minimum. More changes should come
later to enable EGL for other targets (as Wayland).

.:

  • GNUmakefile.am:
  • configure.ac: new configure options --enable-egl and --enable-gles2.

Source/WebCore:

No new tests required, as existing WebGL and AC tests should cover
the cases.

  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • platform/graphics/GraphicsContext3D.h:

(GraphicsContext3D):

  • platform/graphics/OpenGLESShims.h:
  • platform/graphics/cairo/GLContext.cpp:

(WebCore):
(WebCore::GLContext::sharedX11Display):
(WebCore::GLContext::cleanupSharedX11Display):
(WebCore::activeContextList):
(WebCore::GLContext::addActiveContext):
(WebCore::GLContext::removeActiveContext):
(WebCore::GLContext::cleanupActiveContextsAtExit):
(WebCore::GLContext::createContextForWindow):
(WebCore::GLContext::createOffscreenContext):

  • platform/graphics/cairo/GLContext.h:

(GLContext):

  • platform/graphics/cairo/GraphicsContext3DCairo.cpp:

(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::isGLES2Compliant):

  • platform/graphics/cairo/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):

  • platform/graphics/clutter/GraphicsContext3DClutter.cpp:
  • platform/graphics/efl/GraphicsContext3DEfl.cpp:
  • platform/graphics/egl/GLContextEGL.cpp: Added.

(WebCore):
(WebCore::sharedEGLDisplay):
(WebCore::getEGLConfig):
(WebCore::GLContextEGL::createWindowContext):
(WebCore::GLContextEGL::createPbufferContext):
(WebCore::GLContextEGL::createPixmapContext):
(WebCore::GLContextEGL::createContext):
(WebCore::GLContextEGL::GLContextEGL):
(WebCore::GLContextEGL::~GLContextEGL):
(WebCore::GLContextEGL::canRenderToDefaultFramebuffer):
(WebCore::GLContextEGL::defaultFrameBufferSize):
(WebCore::GLContextEGL::makeContextCurrent):
(WebCore::GLContextEGL::swapBuffers):
(WebCore::GLContextEGL::waitNative):
(WebCore::GLContextEGL::platformContext):

  • platform/graphics/egl/GLContextEGL.h: Added.

(WebCore):
(GLContextEGL):

  • platform/graphics/glx/GLContextGLX.cpp:

(WebCore::GLContextGLX::createWindowContext):
(WebCore::GLContextGLX::createPbufferContext):
(WebCore::GLContextGLX::createPixmapContext):
(WebCore::GLContextGLX::createContext):
(WebCore::GLContextGLX::~GLContextGLX):
(WebCore::GLContextGLX::defaultFrameBufferSize):
(WebCore::GLContextGLX::makeContextCurrent):
(WebCore::GLContextGLX::swapBuffers):
(WebCore):
(WebCore::GLContextGLX::waitNative):

  • platform/graphics/glx/GLContextGLX.h:

(GLContextGLX):

  • platform/graphics/mac/GraphicsContext3DMac.mm:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::releaseShaderCompiler):
(WebCore):

  • platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:

(WebCore::GraphicsContext3D::readPixels):
(WebCore::GraphicsContext3D::reshapeFBOs):
(WebCore::GraphicsContext3D::renderbufferStorage):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:
  • platform/graphics/texmap/TextureMapper.h:
  • platform/gtk/RedirectedXCompositeWindow.cpp:

(WebCore::RedirectedXCompositeWindow::RedirectedXCompositeWindow):
(WebCore::RedirectedXCompositeWindow::~RedirectedXCompositeWindow):
(WebCore::RedirectedXCompositeWindow::resize):

  • platform/gtk/RedirectedXCompositeWindow.h:

Source/WebKit2:

  • WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
10:53 AM Changeset in webkit [130524] by zandobersek@gmail.com
  • 1 edit
    4 adds in trunk/LayoutTests

Unreviewed GTK gardening.

Adding platform-specific baselines after r130443 and r130489.

  • platform/gtk/fast/repaint/box-shadow-inset-repaint-expected.png: Added.
  • platform/gtk/fast/repaint/box-shadow-inset-repaint-expected.txt: Added.
  • platform/gtk/fast/text/vertical-rl-rtl-linebreak-expected.png: Added.
  • platform/gtk/fast/text/vertical-rl-rtl-linebreak-expected.txt: Added.
10:53 AM Changeset in webkit [130523] by jonlee@apple.com
  • 13 edits in trunk/Source

Add a setting to enable plugin snapshotting
https://bugs.webkit.org/show_bug.cgi?id=98319
<rdar://problem/12426480>

Reviewed by Brady Eidson.

Source/WebCore:

Add a new bit for this preference.

  • page/Settings.cpp:

(WebCore::Settings::Settings): Preference is false by default.

  • page/Settings.h: Added m_plugInSnapshottingEnabled bit.

(WebCore::Settings::setPlugInSnapshottingEnabled): Set the bit.
(WebCore::Settings::plugInSnapshottingEnabled): Return the bit.

Source/WebKit/mac:

Expose plugInSnapshottingEnabled preference to WebKit clients.

  • WebView/WebPreferenceKeysPrivate.h: Add WebKitPlugInSnapshottingEnabled key.
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]): Setting is turned off by default.
(-[WebPreferences plugInSnapshottingEnabled]):
(-[WebPreferences setPlugInSnapshottingEnabled:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]): Update settings based on preference.

Source/WebKit2:

Expose plugInSnapshottingEnabled preference to WebKit clients.

  • Shared/WebPreferencesStore.h:

(WebKit):

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetPlugInSnapshottingEnabled):
(WKPreferencesGetPlugInSnapshottingEnabled):

  • UIProcess/API/C/WKPreferences.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Update preference based on store.

10:39 AM Changeset in webkit [130522] by commit-queue@webkit.org
  • 4 edits in trunk

[WK2][WKTR] Implement UIClient focus callbacks in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=98256

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-05
Reviewed by Kenneth Rohde Christiansen.

Tools:

Implement UIClient's focus callbacks for the main page in
WebKitTestRunner.

  • WebKitTestRunner/TestController.cpp:

(WTR::focus):
(WTR::TestController::initialize):

LayoutTests:

Unskip fast/dom/Window/mozilla-focus-blur.html now that
WebKitTestRunner implements UIClient's focus callbacks.

  • platform/efl-wk2/TestExpectations:
10:38 AM Changeset in webkit [130521] by rniwa@webkit.org
  • 1 edit
    2 deletes in trunk/LayoutTests

Remove wrong expectations added in r130452.

  • platform/chromium-win-xp/editing/pasteboard/5006779-expected.png: Removed.
  • platform/chromium-win-xp/editing/pasteboard/5006779-expected.txt: Removed.
10:35 AM Changeset in webkit [130520] by mhahnenberg@apple.com
  • 15 edits
    2 adds in trunk

JSC should have a way to gather and log Heap memory use and pause times
https://bugs.webkit.org/show_bug.cgi?id=98431

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

In order to improve our infrastructure for benchmark-driven development, we should
have a centralized method of gathering and logging various statistics about the state
of the JS heap. This would allow us to create and to use other tools to analyze the
output of the VM after running various workloads.

The first two statistics that might be interesting is memory use by JSC and GC pause
times. We can control whether this recording happens through the use of the Options
class, allowing us to either use environment variables or command line flags.

(JSC::Heap::collect): If we finish a collection and are still over our set GC heap size,
we end the program immediately and report an error. Also added recording of pause times.

  • heap/Heap.h:

(Heap):
(JSC::Heap::shouldCollect): When we set a specific GC heap size through Options, we
ignore all other heuristics on when we should collect and instead only ask if we're
greater than the amount specified in the Option value. This allows us to view time/memory
tradeoffs more clearly.

  • heap/HeapStatistics.cpp: Added.

(JSC):
(JSC::HeapStatistics::initialize):
(JSC::HeapStatistics::recordGCPauseTime):
(JSC::HeapStatistics::logStatistics):
(JSC::HeapStatistics::exitWithFailure):
(JSC::HeapStatistics::reportSuccess):
(JSC::HeapStatistics::parseMemoryAmount):
(StorageStatistics):
(JSC::StorageStatistics::StorageStatistics):
(JSC::StorageStatistics::operator()):
(JSC::StorageStatistics::objectWithOutOfLineStorageCount):
(JSC::StorageStatistics::objectCount):
(JSC::StorageStatistics::storageSize):
(JSC::StorageStatistics::storageCapacity):
(JSC::HeapStatistics::showObjectStatistics): Moved the old showHeapStatistics (renamed to showObjectStatistics)
to try to start collecting our various memory statistics gathering/reporting mechanisms scattered throughout the
codebase into one place.

  • heap/HeapStatistics.h: Added.

(JSC):
(HeapStatistics):

  • jsc.cpp:

(main):

  • runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce): We need to initialize our data structures for recording
statistics if necessary.

  • runtime/Options.cpp: Add new Options for the various types of statistics we'll be gathering.

(JSC::parse):
(JSC):
(JSC::Options::initialize): Initialize the various new options using environment variables.
(JSC::Options::dumpOption):

  • runtime/Options.h:

(JSC):

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm:

(main): Added a check as to whether we should dump our JSC Heap statistics on exit.

9:51 AM Changeset in webkit [130519] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Plugins are completely broken with a custom device pixel ratio
https://bugs.webkit.org/show_bug.cgi?id=98518

Reviewed by Kenneth Rohde Christiansen.

Implement painting with scale factor in ShareableBitmap.
The backing store of the plugin are still overscaled in MiniBrowser
with this patch but this is only the effect of the fake device scale
factor defined in qml (1.5). We should probably remove it on desktop.

  • Shared/qt/ShareableBitmapQt.cpp:

(WebKit::ShareableBitmap::paint):

9:37 AM Changeset in webkit [130518] by vsevik@chromium.org
  • 5 edits in trunk/Source/WebCore

Unreviewed inspector front-end closure compilaiton fixes.

  • inspector/InjectedScriptCanvasModuleSource.js:
  • inspector/InjectedScriptExterns.js:

(InjectedScriptHost.prototype.getInternalProperties):

  • inspector/front-end/DockController.js:
  • inspector/front-end/externs.js:

(InspectorFrontendHostAPI.prototype.requestSetDockSide):

9:30 AM Changeset in webkit [130517] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][WK2] Fix mktemp() compilation warning in Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=98493

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-05
Reviewed by Kenneth Rohde Christiansen.

Fix wrong mktemp usage causing a compilation warning
in MiniBrowser.

  • MiniBrowser/efl/main.c:

(on_download_request):

9:28 AM Changeset in webkit [130516] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

Replace uses of prefixed properties with unprefixed versions in the UA stylesheets
https://bugs.webkit.org/show_bug.cgi?id=98453

Patch by Tab Atkins <jackalmage@gmail.com> on 2012-10-05
Reviewed by Ojan Vafai.

Switched 'border-radius' and 'box-shadow' to their unprefixed version in the UA stylesheets.

No new tests, because the unprefixed properties have the same behavior as the prefixed.

  • css/fullscreenQuickTime.css:

(video:-webkit-full-screen::-webkit-media-controls-panel):

  • css/html.css:

(keygen, select):
(select[size][multiple]):
(select[size="1"]):
(::-webkit-validation-bubble-message):

  • css/themeBlackBerry.css:

(input, textarea):

  • css/themeChromiumAndroid.css:

(select[size][multiple]):

  • css/themeQtNoListboxes.css:

(select[size][multiple]):

  • css/themeWin.css:

(select[size="1"]):

  • css/view-source.css:

(.webkit-html-message-bubble):

9:16 AM Changeset in webkit [130515] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WK2][WKTR] Avoid duplication of UIClient callbacks for main page and other pages
https://bugs.webkit.org/show_bug.cgi?id=98503

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-05
Reviewed by Kenneth Rohde Christiansen.

Avoid the need for duplicating UIClient callbacks for main page
and other pages by passing the view as clientInfo
for those callbacks.

Previously, callbacks for the main page were passed the
TestController as clientInfo while the callbacks for other pages
were passed the PlatformWebView as clientInfo. This was error prone
and leads to useless code duplication.

  • WebKitTestRunner/TestController.cpp:

(WTR::getWindowFrame):
(WTR::setWindowFrame):
(WTR::runBeforeUnloadConfirmPanel):
(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):
(WTR::TestController::decidePolicyForNotificationPermissionRequest):

9:16 AM Changeset in webkit [130514] by abarth@webkit.org
  • 1 edit
    2 copies in branches/chromium/1271

Merge 130313 - Crash when calling document.open during unload
https://bugs.webkit.org/show_bug.cgi?id=98287

Reviewed by Nate Chapin.

Source/WebCore:

Calling document.open results in us nulling out m_documentLoader. This
code doesn't properly handle that case and crashes.

Test: fast/parser/document-open-in-unload.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::commitProvisionalLoad):

LayoutTests:

Test that we don't crash when calling document.open during the unload event.

  • fast/parser/document-open-in-unload-expected.txt: Added.
  • fast/parser/document-open-in-unload.html: Added.

TBR=abarth@webkit.org
Review URL: https://codereview.chromium.org/11026067

9:15 AM Changeset in webkit [130513] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[chromium] Only inflate the height of rows in a popup menu when a touch device is detected.
https://bugs.webkit.org/show_bug.cgi?id=98515

Patch by Kevin Ellis <kevers@chromium.org> on 2012-10-05
Reviewed by Adam Barth.

Enforces a minimum row height for popup menus when a touch device is
detected. In a previous patch (r127597), the sizing of popup was
consolidated for touch and non-touch. Based on user feedback, reverting
to the old behavior for non-touch and only adding padding for touch
devices seems like a much safer strategy. This patch is not a direct
revert of r127567 since the padding previously used for touch is a bit
excessive.

Covered by existing tests.

  • platform/chromium/PopupListBox.cpp:

(WebCore::PopupListBox::getRowHeight):

  • platform/chromium/PopupMenuChromium.cpp:

(WebCore):

  • platform/chromium/PopupMenuChromium.h:

(WebCore::PopupMenuChromium::optionRowHeightForTouch):
(WebCore::PopupMenuChromium::setOptionRowHeightForTouch):
(PopupMenuChromium):

9:13 AM Changeset in webkit [130512] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL] Unskip fullscreen unit tests for EwkView
https://bugs.webkit.org/show_bug.cgi?id=98509

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-05
Reviewed by Kenneth Rohde Christiansen.

Update 2 fullscreen unit tests for EwkView so that
they don't require a call to ecore_evas_fullscreen_set()
to succeed. ecore_evas_fullscreen_set() does not
seem to work in Xvfb and causes the tests to hang.
With this update, we can now run those tests again.

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

9:00 AM Changeset in webkit [130511] by apavlov@chromium.org
  • 6 edits
    2 adds in trunk

Web Inspector: [Styles] Unable to edit properties in broken stylesheets
https://bugs.webkit.org/show_bug.cgi?id=98246

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Pop source data for invalid rules off the stack whenever we have consecutive CSSParser::markRuleHeaderStart() invocations.

Test: inspector/styles/parse-stylesheet-errors.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::popRuleData):
(WebCore::CSSParser::markRuleHeaderStart):
(WebCore::CSSParser::markRuleBodyStart):

  • css/CSSParser.h:

(CSSParser):

LayoutTests:

A small refactoring to share the CSS style data dumping code among tests.

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest):

  • inspector/styles/parse-stylesheet-errors-expected.txt: Added.
  • inspector/styles/parse-stylesheet-errors.html: Added.
  • inspector/styles/styles-new-API.html:
8:55 AM Changeset in webkit [130510] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

[Mac] REGRESSION (r130411-r130414): fast/images/repaint-subrect-grid.html failing on Apple MountainLion Debug WK2 (Tests)
https://bugs.webkit.org/show_bug.cgi?id=98523

Unreviewed gardening after r130414.

  • platform/mac/TestExpectations:
8:46 AM Changeset in webkit [130509] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Test /webkit2/WebKitPrintOperation/print-errors gives runtime critical warnings
https://bugs.webkit.org/show_bug.cgi?id=98497

Reviewed by Martin Robinson.

The problem is that GTK+ tries to write in the IO channel that has
already been closed.

  • WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:

(WebKit::WebPrintOperationGtk::print): Finish the surface when
printing fails because printing data is invalid.

8:31 AM Changeset in webkit [130508] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Test /webkit2/WebKitWebResource/response fails
https://bugs.webkit.org/show_bug.cgi?id=98511

Reviewed by Martin Robinson.

Do not consider the favicon as a resource for the web resources
unit tests.

  • UIProcess/API/gtk/tests/TestResources.cpp:
8:26 AM Changeset in webkit [130507] by Carlos Garcia Campos
  • 9 edits in trunk/Source/WebKit2

REGRESSION (r129989 - r130019): [WK2] TestResources test is failing
https://bugs.webkit.org/show_bug.cgi?id=98342

Reviewed by Martin Robinson.

Return 404 error in unit tests using a HTTP server for paths not
handled by the test. This way all tests should return now a 404
for /favicon.ico.

  • UIProcess/API/gtk/tests/TestBackForwardList.cpp:

(serverCallback):

  • UIProcess/API/gtk/tests/TestCookieManager.cpp:

(serverCallback):

  • UIProcess/API/gtk/tests/TestLoaderClient.cpp:

(serverCallback):

  • UIProcess/API/gtk/tests/TestResources.cpp:

(serverCallback):

  • UIProcess/API/gtk/tests/TestSSL.cpp:

(serverCallback):

  • UIProcess/API/gtk/tests/TestWebKitPolicyClient.cpp:

(serverCallback):

  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(serverCallback):

  • UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:

(serverCallback):

8:22 AM Changeset in webkit [130506] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[WK2][SOUP] Assertion hit in WebKit::DownloadManager::downloadFinished() when download fails
https://bugs.webkit.org/show_bug.cgi?id=97565

Reviewed by Gustavo Noronha Silva.

Make sure to notify the downlaod client that the response has been
received when the newly created download has already been added to
the DownloadManager downloads map.

  • WebProcess/Downloads/soup/DownloadSoup.cpp:

(WebKit::DownloadClient::DownloadClient): Initialize
m_handleResponseLaterID.
(WebKit::DownloadClient::~DownloadClient): Remove the source for
the delayed response notification if it hasn't been triggered.
(WebKit::DownloadClient::didReceiveData): If response hasn't been
handled yet, remove the source for the delayed response
notification and handle the resource before start writing the data
received to the output stream.
(WebKit::DownloadClient::handleResponse): Call
didReceiveResponse() with the delayed response.
(WebKit::DownloadClient::handleResponseLaterCallback): Call
handleResponse().
(WebKit::DownloadClient::handleResponseLater): Schedule an idle
callback to handle the response later, to make sure the download
has been added to the downloads map.
(WebKit::Download::startWithHandle): Call handleResponseLater()
with the given response to handle the response when the download
has been added to the downloads map.

8:21 AM Changeset in webkit [130505] by Csaba Osztrogonác
  • 8 edits
    1 add in trunk/LayoutTests

[Qt] Updates expected test results for the expanded coverage in testfonts
https://bugs.webkit.org/show_bug.cgi?id=98425

Unreviewed gardening after r130502.

  • platform/qt/css2.1/t0805-c5519-brdr-r-01-e-expected.png:
  • platform/qt/css2.1/t0805-c5519-brdr-r-01-e-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltblck-00-d-ag-expected.png:
  • platform/qt/css2.1/t0905-c5525-fltblck-00-d-ag-expected.txt:
  • platform/qt/fast/images/icon-decoding-expected.png: Added.
  • platform/qt/fast/images/icon-decoding-expected.txt:
  • platform/qt/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
  • platform/qt/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
7:42 AM Changeset in webkit [130504] by commit-queue@webkit.org
  • 8 edits
    3 adds in trunk

[chromium] Allow dragging into plugins.
https://bugs.webkit.org/show_bug.cgi?id=98277

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-10-05
Reviewed by Tony Chang.

Source/WebKit/chromium:

Allow plugins to receive drag events. This will make it possible to
perform drag-n-drop into browser plugins (and other plugins if desired).

  • public/WebDragStatus.h: Added.

(WebKit):

  • public/WebPlugin.h:

(WebKit):
(WebPlugin):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::handleMouseEvent):
(WebKit::WebPluginContainerImpl::handleDragEvent):
(WebKit):

  • src/WebPluginContainerImpl.h:

(WebPluginContainerImpl):

Tools:

Update the TestWebPlugin to receive drag events and print them out.

  • DumpRenderTree/chromium/TestWebPlugin.cpp:

(TestWebPlugin::handleDragStatusUpdate):

  • DumpRenderTree/chromium/TestWebPlugin.h:

(TestWebPlugin):

LayoutTests:

Add test to make sure that plugins receive the drag events correctly.

  • platform/chromium/plugins/drag-events-expected.txt: Added.
  • platform/chromium/plugins/drag-events.html: Added.
7:33 AM Changeset in webkit [130503] by rwlbuis@webkit.org
  • 4 edits in trunk

[BlackBerry] Sync up CMake files
https://bugs.webkit.org/show_bug.cgi?id=98442

Reviewed by Gyuyoung Kim.

.:

Amongst others some internal paths changed.

  • Source/cmake/OptionsBlackBerry.cmake:

Source/WebKit:

Amongst others use InspectorOverlayBlackBerry.

  • PlatformBlackBerry.cmake:
7:31 AM Changeset in webkit [130502] by Csaba Osztrogonác
  • 16 edits
    6 deletes in trunk/LayoutTests

[Qt] Updates expected test results for the expanded coverage in testfonts
https://bugs.webkit.org/show_bug.cgi?id=98425

Patch by Marcelo Lira <marcelo.lira@openbossa.org> on 2012-10-05
Reviewed by Csaba Osztrogonác.

The Qt testfonts repository was expanded with the croscore set of
fonts, which provides a great number of new glyphs (e.g. hebrew
characters).

See the comments in the testfonts commit for detailed information:
https://gitorious.org/qtwebkit/testfonts/commit/f11a54548121ee9fb0688dc6f32acdbfec5d2d2f/diffs

  • platform/qt-5.0/css2.1/t0905-c5525-fltblck-00-d-ag-expected.png: Removed.
  • platform/qt-5.0/css2.1/t0905-c5525-fltblck-00-d-ag-expected.txt: Removed.
  • platform/qt-5.0/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt: Removed.
  • platform/qt-5.0/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt: Removed.
  • platform/qt-5.0/fast/forms/search-rtl-expected.png: Removed.
  • platform/qt-5.0/fast/forms/search-rtl-expected.txt: Removed.
  • platform/qt/css2.1/t0805-c5519-brdr-r-01-e-expected.png:
  • platform/qt/css2.1/t0805-c5519-brdr-r-01-e-expected.txt:
  • platform/qt/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
  • platform/qt/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
  • platform/qt/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
  • platform/qt/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
  • platform/qt/fast/borders/bidi-012-expected.txt:
  • platform/qt/fast/forms/listbox-bidi-align-expected.png:
  • platform/qt/fast/forms/listbox-bidi-align-expected.txt:
  • platform/qt/fast/forms/search-rtl-expected.png:
  • platform/qt/fast/forms/search-rtl-expected.txt:
  • platform/qt/fast/text/atsui-small-caps-punctuation-size-expected.txt:
  • platform/qt/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
  • platform/qt/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
  • platform/qt/fast/text/large-text-composed-char-expected.png:
  • platform/qt/svg/custom/glyph-selection-bidi-mirror-expected.png:
  • platform/qt/svg/custom/glyph-selection-bidi-mirror-expected.txt:
7:29 AM Changeset in webkit [130501] by tonikitoo@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Find a proper fix for the WebPagePrivate::enqueueRenderingOfClippedContentOfScrollableNodeAfterInRegionScrolling hack
https://bugs.webkit.org/show_bug.cgi?id=98517
PR #137382

Reviewed by Yong Li.
Patch by Antonio Gomes <agomes@rim.com>

We've generalized composited in-region scrolling, originally only applicable
to block elements, to inner frames (see PR #197093). Past that, we no longer
need to force repaints of offscreen areas when we finish scrolling, since translating
the Layer takes care of properly invalidating it. Thus, remove this method.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::notifyInRegionScrollStopped):

  • Api/WebPage_p.h:

(WebPagePrivate):

7:19 AM Changeset in webkit [130500] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Update default input support style for single line inputs.
https://bugs.webkit.org/show_bug.cgi?id=98510

Reviewed by Antonio Gomes.

PR 219588.

Update style calculations to eliminate automatic changes
by default on single line input fields.

Reviewed Internally by Gen Mak.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::inputStyle):

6:59 AM Changeset in webkit [130499] by kadam@inf.u-szeged.hu
  • 3 edits
    1 add in trunk/LayoutTests

Unreviewed Qt gardening.

The ICO decoder shouldn't be broken since it is the WebKit decoder.

Patch by Allan Sandfeld Jensen <allan.jensen@digia.com> on 2012-10-05

  • platform/qt/TestExpectations:
6:42 AM Changeset in webkit [130498] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, update an expected file for newer Qt5.

  • platform/qt/fast/text/atsui-small-caps-punctuation-size-expected.png:
  • platform/qt/fast/text/atsui-small-caps-punctuation-size-expected.txt:
5:47 AM Changeset in webkit [130497] by rgabor@webkit.org
  • 2 edits in trunk/Source/WebCore

Add ARM-NEON support to VectorMath in WebAudio
https://bugs.webkit.org/show_bug.cgi?id=98131

Reviewed by Zoltan Herczeg.

Speed up vector operations in WebAudio with NEON intrinsics.

  • platform/audio/VectorMath.cpp:

(WebCore::VectorMath::vsma):
(WebCore::VectorMath::vsmul):
(WebCore::VectorMath::vadd):
(WebCore::VectorMath::vmul):
(WebCore::VectorMath::zvmul):
(WebCore::VectorMath::vsvesq):
(WebCore::VectorMath::vmaxmgv):

5:36 AM Changeset in webkit [130496] by Simon Hausmann
  • 6 edits
    4 moves
    4 deletes in trunk/Source

Unreviewed, rolling out r130495.
http://trac.webkit.org/changeset/130495
https://bugs.webkit.org/show_bug.cgi?id=98268

Source/WebCore:

Made WK2 tests crash.

  • Target.pri:
  • platform/qt/QStyleFacade.cpp: Removed.
  • platform/qt/QStyleFacade.h: Removed.

Source/WebKit:

Made WK2 tests crash....

  • WebKit1.pro:

Source/WebKit/qt:

Made WK2 tests crash.

  • WebCoreSupport/InitWebCoreQt.cpp:

(WebCore::initializeWebCoreQt):

  • WebCoreSupport/QStyleFacadeImp.cpp: Removed.
  • WebCoreSupport/QStyleFacadeImp.h: Removed.
  • WebCoreSupport/RenderThemeQStyle.cpp: Renamed from Source/WebCore/platform/qt/RenderThemeQStyle.cpp.

(WebCore):
(WebCore::initStyleOption):
(WebCore::RenderThemeQStyle::getStylePainter):
(WebCore::StylePainterQStyle::StylePainterQStyle):
(WebCore::StylePainterQStyle::init):
(WebCore::RenderThemeQStyle::create):
(WebCore::RenderThemeQStyle::RenderThemeQStyle):
(WebCore::RenderThemeQStyle::~RenderThemeQStyle):
(WebCore::RenderThemeQStyle::fallbackStyle):
(WebCore::RenderThemeQStyle::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQStyle::qStyle):
(WebCore::RenderThemeQStyle::findFrameLineWidth):
(WebCore::RenderThemeQStyle::inflateButtonRect):
(WebCore::RenderThemeQStyle::computeSizeBasedOnStyle):
(WebCore::RenderThemeQStyle::adjustButtonStyle):
(WebCore::RenderThemeQStyle::setButtonPadding):
(WebCore::RenderThemeQStyle::paintButton):
(WebCore::RenderThemeQStyle::paintTextField):
(WebCore::RenderThemeQStyle::adjustTextAreaStyle):
(WebCore::RenderThemeQStyle::paintTextArea):
(WebCore::RenderThemeQStyle::setPopupPadding):
(WebCore::RenderThemeQStyle::colorPalette):
(WebCore::RenderThemeQStyle::paintMenuList):
(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
(WebCore::RenderThemeQStyle::paintMenuListButton):
(WebCore::RenderThemeQStyle::animationDurationForProgressBar):
(WebCore::RenderThemeQStyle::paintProgressBar):
(WebCore::RenderThemeQStyle::paintSliderTrack):
(WebCore::RenderThemeQStyle::adjustSliderTrackStyle):
(WebCore::RenderThemeQStyle::paintSliderThumb):
(WebCore::RenderThemeQStyle::adjustSliderThumbStyle):
(WebCore::RenderThemeQStyle::paintSearchField):
(WebCore::RenderThemeQStyle::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldDecoration):
(WebCore::RenderThemeQStyle::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeQStyle::paintInnerSpinButton):
(WebCore::RenderThemeQStyle::initializeCommonQStyleOptions):
(WebCore::RenderThemeQStyle::adjustSliderThumbSize):

  • WebCoreSupport/RenderThemeQStyle.h: Renamed from Source/WebCore/platform/qt/RenderThemeQStyle.h.

(WebCore):
(RenderThemeQStyle):
(StylePainterQStyle):
(WebCore::StylePainterQStyle::isValid):
(WebCore::StylePainterQStyle::drawPrimitive):
(WebCore::StylePainterQStyle::drawControl):
(WebCore::StylePainterQStyle::drawComplexControl):

  • WebCoreSupport/ScrollbarThemeQStyle.cpp: Renamed from Source/WebCore/platform/qt/ScrollbarThemeQStyle.cpp.

(WebCore):
(WebCore::ScrollbarThemeQStyle::~ScrollbarThemeQStyle):
(WebCore::scPart):
(WebCore::scrollbarPart):
(WebCore::styleOptionSlider):
(WebCore::ScrollbarThemeQStyle::paint):
(WebCore::ScrollbarThemeQStyle::hitTest):
(WebCore::ScrollbarThemeQStyle::shouldCenterOnThumb):
(WebCore::ScrollbarThemeQStyle::invalidatePart):
(WebCore::ScrollbarThemeQStyle::scrollbarThickness):
(WebCore::ScrollbarThemeQStyle::thumbPosition):
(WebCore::ScrollbarThemeQStyle::thumbLength):
(WebCore::ScrollbarThemeQStyle::trackPosition):
(WebCore::ScrollbarThemeQStyle::trackLength):
(WebCore::ScrollbarThemeQStyle::paintScrollCorner):
(WebCore::ScrollbarThemeQStyle::style):

  • WebCoreSupport/ScrollbarThemeQStyle.h: Renamed from Source/WebCore/platform/qt/ScrollbarThemeQStyle.h.

(WebCore):
(ScrollbarThemeQStyle):

4:43 AM Changeset in webkit [130495] by Simon Hausmann
  • 6 edits
    4 moves
    4 adds in trunk/Source

[Qt] Make RenderThemeQStyle/ScrollbarThemeQStyle compile without QStyle/QtWidgets
https://bugs.webkit.org/show_bug.cgi?id=98268

Reviewed by Tor Arne Vestbø.

Source/WebCore:

Extracted QStyle/QWidget related code into a QWebStyle class that implements the QStyleFacade interface.

QStyleFacade is a pure interface that lives in WebCore/platform/qt
(next to RenderThemeQStyle and ScrollbarThemeQStyle) and provides a
minimal interface of what we need to draw with QStyle as well as basic
hit testing and metric retrieval. It also provides a
QStyleFacadeOption class that aggregates common meta-data for
rendering primitives, such as direction, rectangle, state (sunken,
enabled, etc.) or palette. It also provides some more slider/scrollbar
specific fields in a slider sub-structure.

RenderThemeQStyle/ScrollbarThemeQStyle used to instantiate specific QStyleOption sub-classes and populate
them with state information from render objects, before calling straight to QStyle. Most of the common code
was encapsulated in StylePainterQStyle.

The new RenderThemeQStyle/ScrolllbarThemeQStyle uses common code in
StylePainterQStyle to populate state into QStyleFacadeOption before
calling into QStyleFacade.

The style facade is then implemented by QStyleFacadeImp, which extracts
meta-data from QStyleFacadeOption arguments, populates style
primitive specific QStyleOption objects and then calls on QStyle.

RenderThemeQStyle/ScrollbarThemeQStyle can only use interface methods
from QStyleFacade. QStyleFacadeImp on the other hand will live in the
separate QtWebKitWidgets library in the future and therefore cannot use
any WebCore types.

  • Target.pri:
  • platform/qt/QStyleFacade.cpp: Added.

(WebCore):
(WebCore::QStyleFacade::styleForPage):

  • platform/qt/QStyleFacade.h: Added.

(WebCore):
(QStyleFacade):
(WebCore::QStyleFacade::~QStyleFacade):
(WebCore::QStyleFacadeOption::QStyleFacadeOption):
(QStyleFacadeOption):

  • platform/qt/RenderThemeQStyle.cpp: Renamed from Source/WebKit/qt/WebCoreSupport/RenderThemeQStyle.cpp.

(WebCore):
(WebCore::RenderThemeQStyle::getStylePainter):
(WebCore::StylePainterQStyle::StylePainterQStyle):
(WebCore::StylePainterQStyle::init):
(WebCore::RenderThemeQStyle::create):
(WebCore::RenderThemeQStyle::setStyleFactoryFunction):
(WebCore::RenderThemeQStyle::styleFactory):
(WebCore::RenderThemeQStyle::RenderThemeQStyle):
(WebCore::RenderThemeQStyle::~RenderThemeQStyle):
(WebCore::RenderThemeQStyle::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQStyle::inflateButtonRect):
(WebCore::RenderThemeQStyle::computeSizeBasedOnStyle):
(WebCore::RenderThemeQStyle::adjustButtonStyle):
(WebCore::RenderThemeQStyle::setButtonPadding):
(WebCore::RenderThemeQStyle::paintButton):
(WebCore::RenderThemeQStyle::paintTextField):
(WebCore::RenderThemeQStyle::adjustTextAreaStyle):
(WebCore::RenderThemeQStyle::paintTextArea):
(WebCore::RenderThemeQStyle::setPopupPadding):
(WebCore::RenderThemeQStyle::colorPalette):
(WebCore::RenderThemeQStyle::paintMenuList):
(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
(WebCore::RenderThemeQStyle::paintMenuListButton):
(WebCore::RenderThemeQStyle::animationDurationForProgressBar):
(WebCore::RenderThemeQStyle::paintProgressBar):
(WebCore::RenderThemeQStyle::paintSliderTrack):
(WebCore::RenderThemeQStyle::adjustSliderTrackStyle):
(WebCore::RenderThemeQStyle::paintSliderThumb):
(WebCore::RenderThemeQStyle::adjustSliderThumbStyle):
(WebCore::RenderThemeQStyle::paintSearchField):
(WebCore::RenderThemeQStyle::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldDecoration):
(WebCore::RenderThemeQStyle::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeQStyle::paintInnerSpinButton):
(WebCore::RenderThemeQStyle::initializeCommonQStyleOptions):
(WebCore::RenderThemeQStyle::adjustSliderThumbSize):

  • platform/qt/RenderThemeQStyle.h: Renamed from Source/WebKit/qt/WebCoreSupport/RenderThemeQStyle.h.

(WebCore):
(RenderThemeQStyle):
(WebCore::RenderThemeQStyle::qStyle):
(StylePainterQStyle):
(WebCore::StylePainterQStyle::isValid):
(WebCore::StylePainterQStyle::paintButton):
(WebCore::StylePainterQStyle::paintTextField):
(WebCore::StylePainterQStyle::paintComboBox):
(WebCore::StylePainterQStyle::paintComboBoxArrow):
(WebCore::StylePainterQStyle::paintSliderTrack):
(WebCore::StylePainterQStyle::paintSliderThumb):
(WebCore::StylePainterQStyle::paintInnerSpinButton):
(WebCore::StylePainterQStyle::paintProgressBar):
(WebCore::StylePainterQStyle::paintScrollCorner):
(WebCore::StylePainterQStyle::paintScrollBar):

  • platform/qt/ScrollbarThemeQStyle.cpp: Renamed from Source/WebKit/qt/WebCoreSupport/ScrollbarThemeQStyle.cpp.

(WebCore):
(WebCore::ScrollbarThemeQStyle::ScrollbarThemeQStyle):
(WebCore::ScrollbarThemeQStyle::~ScrollbarThemeQStyle):
(WebCore::scPart):
(WebCore::scrollbarPart):
(WebCore::initSliderStyleOption):
(WebCore::ScrollbarThemeQStyle::paint):
(WebCore::ScrollbarThemeQStyle::hitTest):
(WebCore::ScrollbarThemeQStyle::shouldCenterOnThumb):
(WebCore::ScrollbarThemeQStyle::invalidatePart):
(WebCore::ScrollbarThemeQStyle::scrollbarThickness):
(WebCore::ScrollbarThemeQStyle::thumbPosition):
(WebCore::ScrollbarThemeQStyle::thumbLength):
(WebCore::ScrollbarThemeQStyle::trackPosition):
(WebCore::ScrollbarThemeQStyle::trackLength):
(WebCore::ScrollbarThemeQStyle::paintScrollCorner):

  • platform/qt/ScrollbarThemeQStyle.h: Renamed from Source/WebKit/qt/WebCoreSupport/ScrollbarThemeQStyle.h.

(WebCore):
(ScrollbarThemeQStyle):
(WebCore::ScrollbarThemeQStyle::qStyle):

Source/WebKit:

  • WebKit1.pro: Add new files to the build.

Source/WebKit/qt:

Extracted QStyle/QWidget related code into a QWebStyle class that implements the QStyleFacade interface.

QStyleFacade is a pure interface that lives in WebCore/platform/qt
(next to RenderThemeQStyle and ScrollbarThemeQStyle) and provides a
minimal interface of what we need to draw with QStyle as well as basic
hit testing and metric retrieval. It also provides a
QStyleFacadeOption class that aggregates common meta-data for
rendering primitives, such as direction, rectangle, state (sunken,
enabled, etc.) or palette. It also provides some more slider/scrollbar
specific fields in a slider sub-structure.

RenderThemeQStyle/ScrollbarThemeQStyle used to instantiate specific QStyleOption sub-classes and populate
them with state information from render objects, before calling straight to QStyle. Most of the common code
was encapsulated in StylePainterQStyle.

The new RenderThemeQStyle/ScrolllbarThemeQStyle uses common code in
StylePainterQStyle to populate state into QStyleFacadeOption before
calling into QStyleFacade.

The style facade is then implemented by QStyleFacadeImp, which extracts
meta-data from QStyleFacadeOption arguments, populates style
primitive specific QStyleOption objects and then calls on QStyle.

RenderThemeQStyle/ScrollbarThemeQStyle can only use interface methods
from QStyleFacade. QStyleFacadeImp on the other hand will live in the
separate QtWebKitWidgets library in the future and therefore cannot use
any WebCore types.

  • WebCoreSupport/InitWebCoreQt.cpp:

(WebCore::initializeWebCoreQt):

  • WebCoreSupport/QStyleFacadeImp.cpp: Added.

(WebKit):
(WebKit::convertToQStyleState):
(WebKit::convertToQStyleSubControl):
(WebKit::initGenericStyleOption):
(WebKit::initSpecificStyleOption):
(MappedStyleOption):
(WebKit::MappedStyleOption::MappedStyleOption):
(WebKit::convertPixelMetric):
(WebKit::convertToQStyleFacadeSubControl):
(WebKit::QStyleFacadeImp::QStyleFacadeImp):
(WebKit::QStyleFacadeImp::~QStyleFacadeImp):
(WebKit::QStyleFacadeImp::buttonSubElementRect):
(WebKit::QStyleFacadeImp::findFrameLineWidth):
(WebKit::QStyleFacadeImp::simplePixelMetric):
(WebKit::QStyleFacadeImp::buttonMargin):
(WebKit::QStyleFacadeImp::sliderLength):
(WebKit::QStyleFacadeImp::sliderThickness):
(WebKit::QStyleFacadeImp::progressBarChunkWidth):
(WebKit::QStyleFacadeImp::getButtonMetrics):
(WebKit::QStyleFacadeImp::sizeFromContents):
(WebKit::QStyleFacadeImp::paintButton):
(WebKit::QStyleFacadeImp::paintTextField):
(WebKit::QStyleFacadeImp::paintComboBox):
(WebKit::QStyleFacadeImp::paintComboBoxArrow):
(WebKit::QStyleFacadeImp::paintSliderTrack):
(WebKit::QStyleFacadeImp::paintSliderThumb):
(WebKit::QStyleFacadeImp::paintInnerSpinButton):
(WebKit::QStyleFacadeImp::paintProgressBar):
(WebKit::QStyleFacadeImp::scrollBarExtent):
(WebKit::QStyleFacadeImp::scrollBarMiddleClickAbsolutePositionStyleHint):
(WebKit::QStyleFacadeImp::paintScrollCorner):
(WebKit::QStyleFacadeImp::hitTestScrollBar):
(WebKit::QStyleFacadeImp::scrollBarSubControlRect):
(WebKit::QStyleFacadeImp::paintScrollBar):
(WebKit::QStyleFacadeImp::widgetForPainter):
(WebKit::QStyleFacadeImp::style):

  • WebCoreSupport/QStyleFacadeImp.h: Added.

(WebCore):
(WebKit):
(QStyleFacadeImp):
(WebKit::QStyleFacadeImp::create):
(WebKit::QStyleFacadeImp::isValid):

4:33 AM Changeset in webkit [130494] by commit-queue@webkit.org
  • 16 edits
    3 moves in trunk

[EFL][WK2] Remove "web" word from ewk_web_error APIs
https://bugs.webkit.org/show_bug.cgi?id=97886

Patch by Jongseok Yang <js45.yang@samsung.com> on 2012-10-05
Reviewed by Gyuyoung Kim.

Remove "web" word from ewk_web_error APIs.
"web" word was redundant because "ewk" means "EFL WebKit" and WK APIs for error does not have "web" word.

Source/WebKit2:

  • PlatformEfl.cmake:
  • UIProcess/API/efl/EWebKit2.h:
  • UIProcess/API/efl/ewk_context_download_client.cpp:

(didFail):

  • UIProcess/API/efl/ewk_cookie_manager.cpp:

(getAcceptPolicyCallback):
(getHostnamesWithCookiesCallback):

  • UIProcess/API/efl/ewk_cookie_manager.h:
  • UIProcess/API/efl/ewk_download_job_private.h:
  • UIProcess/API/efl/ewk_error.cpp: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_web_error.cpp.

(_Ewk_Error):
(_Ewk_Error::_Ewk_Error):
(_Ewk_Error::~_Ewk_Error):
(ewk_error_free):
(ewk_error_type_get):
(ewk_error_url_get):
(ewk_error_code_get):
(ewk_error_description_get):
(ewk_error_cancellation_get):
(ewk_error_new):

  • UIProcess/API/efl/ewk_error.h: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_web_error.h.
  • UIProcess/API/efl/ewk_error_private.h: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_web_error_private.h.
  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_resource_load_failed):
(ewk_view_download_job_failed):
(ewk_view_load_error):
(ewk_view_load_provisional_failed):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/ewk_view_loader_client.cpp:

(didFailLoadWithErrorForFrame):
(didFailProvisionalLoadWithErrorForFrame):

  • UIProcess/API/efl/ewk_view_private.h:
  • UIProcess/API/efl/ewk_view_resource_load_client.cpp:

(didFailLoadForResource):

  • UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:

(getAcceptPolicyCallback):
(getHostnamesWithCookiesCallback):

  • UIProcess/API/efl/tests/test_ewk2_download_job.cpp:

(on_download_failed):

Tools:

  • MiniBrowser/efl/main.c:

(on_error):

4:30 AM Changeset in webkit [130493] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[WK2][GTK] WebPageAccessibilityObject leaking
https://bugs.webkit.org/show_bug.cgi?id=98502

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-05
Reviewed by Carlos Garcia Campos.

Use GRefPtr on the accessibility object to fix the leak.

  • WebProcess/WebPage/WebPage.h:

(WebPage):

  • WebProcess/WebPage/gtk/WebPageGtk.cpp:

(WebKit::WebPage::platformInitialize):
(WebKit::WebPage::updateAccessibilityTree):

3:59 AM Changeset in webkit [130492] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] Add API to count the matching text
https://bugs.webkit.org/show_bug.cgi?id=97873

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-10-05
Reviewed by Gyuyoung Kim.

Add an API, ewk_view_text_matches_count(), to count the matched text in the document.
This API does not highlight the matched text in the document unlike ewk_view_text_find().

ewk_view_text_find() finds the matching text and but also update the UI view,
but some applications may not want to affect the view, and just want to know the count.

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_text_matches_count):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

3:23 AM Changeset in webkit [130491] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WTF

[GTK] Add support for GBytes in GRefPtr
https://bugs.webkit.org/show_bug.cgi?id=98489

Patch by Simon Pena <Simon Pena> on 2012-10-05
Reviewed by Carlos Garcia Campos.

Adding support for GBytes in GRefPtr makes it easier
for them to be used when adding GResources support,
and is more consistent with the rest of the port.

This calls g_bytes_ref and g_bytes_unref in the implementation
of the refPtr and derefPtr template functions, in case the GLib
version is met. Otherwise, it does nothing.

  • wtf/gobject/GRefPtr.cpp: Implement templates for ref and deref.

(WTF::refGPtr):
(WTF):
(WTF::derefGPtr):

  • wtf/gobject/GRefPtr.h:

(WTF):

  • wtf/gobject/GTypedefs.h: Define the GBytes datatype.
2:19 AM Changeset in webkit [130490] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2][GTK][EFL] standard_output returned by g_spawn_sync must be freed
https://bugs.webkit.org/show_bug.cgi?id=98384

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-05
Reviewed by Gyuyoung Kim.

Free the standard_output returned by g_spawn_sync() to avoid
a memory leak.

  • UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:

(WebKit::PluginProcessProxy::scanPlugin):

2:09 AM Changeset in webkit [130489] by commit-queue@webkit.org
  • 6 edits
    5 adds in trunk

Incomplete repaint of boxes with inset box-shadow and padding when resized
https://bugs.webkit.org/show_bug.cgi?id=59863

Patch by Andrei Bucur <abucur@adobe.com> on 2012-10-05
Reviewed by Simon Fraser.

Source/WebCore:

The patch extends the repaint rectangle to include the inset shadow extent for renderers that resize and need to be repainted. The rectangle computations are also better fragmented and easier to read.

New Test: fast/repaint/box-shadow-inset-repaint.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::repaintAfterLayoutIfNeeded):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::getShadowInsetExtent):
(WebCore):

  • rendering/style/RenderStyle.h:

LayoutTests:

The patch adds a new pixel test and expected PNG results for mac and chromium-mac. The test fails on Chromium Linux EWS (and maybe others)
so I've added a rule in the TestExpectations file.

  • platform/chromium/TestExpectations:
  • fast/repaint/box-shadow-inset-repaint.html: Added.
  • platform/chromium-mac/fast/repaint/box-shadow-inset-repaint-expected.png: Added.
  • platform/mac/fast/repaint/box-shadow-inset-repaint-expected.png: Added.
  • platform/mac/fast/repaint/box-shadow-inset-repaint-expected.txt: Added.
2:00 AM Changeset in webkit [130488] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Remove dead code
https://bugs.webkit.org/show_bug.cgi?id=98491

Patch by Simon Hausmann <simon.hausmann@digia.com> on 2012-10-05
Reviewed by Jocelyn Turcotte.

This code was added long time ago for a Symbian related project and is
not needed anymore.

  • Api/qwebframe.cpp:
1:49 AM Changeset in webkit [130487] by zandobersek@gmail.com
  • 10 edits
    1 delete in trunk/LayoutTests

Unreviewed GTK gardening.

Updating platform-specific baselines after r130411.
Removing platform-specific baselines for CSS compositing tests
and skipping these tests entirely as the feature is not yet enabled
on the GTK port.

  • platform/gtk/TestExpectations:
  • platform/gtk/css3/compositing: Removed.
  • platform/gtk/css3/compositing/blend-mode-property-expected.txt: Removed.
  • platform/gtk/css3/compositing/blend-mode-property-parsing-expected.txt: Removed.
  • platform/gtk/editing/deleting/delete-block-merge-contents-020-expected.txt:
  • platform/gtk/editing/execCommand/paste-1-expected.txt:
  • platform/gtk/editing/pasteboard/8145-3-expected.txt:
  • platform/gtk/editing/pasteboard/paste-line-endings-007-expected.txt:
  • platform/gtk/editing/pasteboard/paste-match-style-001-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-009-expected.txt:
  • platform/gtk/editing/pasteboard/smart-paste-007-expected.txt:
  • platform/gtk/editing/pasteboard/unrendered-br-expected.txt:
1:33 AM Changeset in webkit [130486] by Csaba Osztrogonác
  • 3 edits
    1 move
    1 add in trunk

[Qt] Enable CSS compositing by default
https://bugs.webkit.org/show_bug.cgi?id=98490

Reviewed by Simon Hausmann.

Tools:

  • qmake/mkspecs/features/features.pri:

LayoutTests:

  • platform/qt/css3/compositing/should-have-compositing-layer-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/css3/compositing/should-have-compositing-layer-expected.txt.
1:17 AM Changeset in webkit [130485] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update
https://bugs.webkit.org/show_bug.cgi?id=98481

r130477 affects month-multiple-fields tests too.

  • platform/chromium/TestExpectations:
1:15 AM Changeset in webkit [130484] by vsevik@chromium.org
  • 3 edits in branches/chromium/1229/Source/WebCore/inspector/front-end

Merge 124886 - Web Inspector: Do not disable network tracking while profiling cpu.
https://bugs.webkit.org/show_bug.cgi?id=93359

Reviewed by Yury Semikhatsky.

Removed network tracking enabling/disabling machinery.

  • inspector/front-end/CPUProfileView.js:

(WebInspector.CPUProfileType.prototype.buttonClicked):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkManager.get this):
(WebInspector.NetworkManager.get NetworkAgent):
(WebInspector.NetworkManager):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel):

TBR=vsevik@chromium.org
BUG=153748
Review URL: https://codereview.chromium.org/11068016

1:12 AM Changeset in webkit [130483] by Csaba Osztrogonác
  • 4 edits in trunk

Unreviewed, rolling out r130466.
http://trac.webkit.org/changeset/130466
https://bugs.webkit.org/show_bug.cgi?id=98495

It made 12 tests crash on Qt-WK2 (Requested by Ossy on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-05

Tools:

  • WebKitTestRunner/TestController.cpp:

(WTR::focus):
(WTR::TestController::initialize):

LayoutTests:

  • platform/efl-wk2/TestExpectations:
1:11 AM Changeset in webkit [130482] by vsevik@chromium.org
  • 1 edit in branches/chromium/1229/Source/WebCore/inspector/front-end/inspector.css

Merge 125255 - Web Inspector: Search matches count view is flaky.
https://bugs.webkit.org/show_bug.cgi?id=93451

Patch by Sam D <dsam2912@gmail.com> on 2012-08-10
Reviewed by Pavel Feldman.

Modified css properties for aligning search panel.

No new tests.UI change.

  • inspector/front-end/inspector.css:

(.search-results-matches):

TBR=commit-queue@webkit.org
BUG=153753
Review URL: https://codereview.chromium.org/11029044

1:09 AM Changeset in webkit [130481] by Csaba Osztrogonác
  • 4 edits in trunk/Source/WTF

Unreviewed, rolling out r130478.
http://trac.webkit.org/changeset/130478
https://bugs.webkit.org/show_bug.cgi?id=98494

It broke the Qt build (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-05

  • wtf/gobject/GRefPtr.cpp:
  • wtf/gobject/GRefPtr.h:

(WTF):

  • wtf/gobject/GTypedefs.h:
12:58 AM Changeset in webkit [130480] by tkent@chromium.org
  • 2 edits
    14 adds in trunk/LayoutTests

Add appearance tests for input[type=date] with multiple fields
https://bugs.webkit.org/show_bug.cgi?id=98479

Reviewed by Kentaro Hara.

  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.txt: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic.html: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.txt: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes.html: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.txt: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements.html: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.txt: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-style.html: Added.
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png: Added.
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png: Added.
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png: Added.
  • platform/chromium/TestExpectations:
12:46 AM Changeset in webkit [130479] by commit-queue@webkit.org
  • 7 edits
    3 moves in trunk/Source/WebKit2

[EFL][WK2] Remove "web" word from ewk_resource APIs
https://bugs.webkit.org/show_bug.cgi?id=97887

Patch by Jongseok Yang <js45.yang@samsung.com> on 2012-10-05
Reviewed by Gyuyoung Kim.

Remove "web" word from ewk_web_resource APIs.
"web" word was redundant because "ewk" means "EFL WebKit" and enough to understand the meaning with ewk_resource_XXX.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/EWebKit2.h:
  • UIProcess/API/efl/ewk_resource.cpp: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_web_resource.cpp.

(_Ewk_Resource):
(_Ewk_Resource::_Ewk_Resource):
(_Ewk_Resource::~_Ewk_Resource):
(ewk_resource_ref):
(ewk_resource_unref):
(ewk_resource_url_get):
(ewk_resource_new):
(ewk_resource_main_resource_get):

  • UIProcess/API/efl/ewk_resource.h: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_web_resource.h.
  • UIProcess/API/efl/ewk_resource_private.h: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_web_resource_private.h.
  • UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_priv_loading_resources_clear):
(ewk_view_resource_load_initiated):
(ewk_view_resource_load_response):
(ewk_view_resource_load_failed):
(ewk_view_resource_load_finished):
(ewk_view_resource_request_sent):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/ewk_view_private.h:
  • UIProcess/API/efl/ewk_view_resource_load_client.cpp:

(didInitiateLoadForResource):

12:40 AM Changeset in webkit [130478] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WTF

[GTK] Add support for GBytes in GRefPtr
https://bugs.webkit.org/show_bug.cgi?id=98489

Patch by Simon Pena <Simon Pena> on 2012-10-05
Reviewed by Carlos Garcia Campos.

Adding support for GBytes in GRefPtr makes it easier
for them to be used when adding GResources support,
and is more consistent with the rest of the port.

This calls g_bytes_ref and g_bytes_unref in the implementation
of the refPtr and derefPtr template functions.

  • wtf/gobject/GRefPtr.cpp: Implement templates for ref and deref.

(WTF::refGPtr):
(WTF):
(WTF::derefGPtr):

  • wtf/gobject/GRefPtr.h:

(WTF):

  • wtf/gobject/GTypedefs.h: Define the GBytes datatype.
12:35 AM Changeset in webkit [130477] by tkent@chromium.org
  • 11 edits in trunk

Fix sub-field width to the maximum width of a placeholder and the maximum value
https://bugs.webkit.org/show_bug.cgi?id=98481

Reviewed by Hajime Morita.

Source/WebCore:

We can't assume a placeholder text is shorter than the width of
digits. The placeholder string for the year field of
input[type=week] is "----", but input[type=date] will have a
localized string for it.

We should set the 'width' CSS property to the maximum of the
placeholder width and the maximum value width in order to prevent
the field width from growing/narrowing.

Before this patch, we secured four digits space for a year field,
and allowed the field to grow its width when a larger year is
set. After this patch, we don't allow it to grow because the
'width' property is set to the maximum width.

Update week-multiple-fields-appearance-basic.html, and the
following tests are affected.

  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes.html
  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements.html
  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-style.html
  • html/shadow/DateTimeNumericFieldElement.cpp:

(WebCore::DateTimeNumericFieldElement::DateTimeNumericFieldElement):
Enable customStyleForRenderer.
(WebCore::DateTimeNumericFieldElement::customStyleForRenderer):
Added. The code is similar to DateTimeSymbolicFieldElement::customStyleForRenderer().
(WebCore::DateTimeNumericFieldElement::formatValue):
Made a function with the code in value(). This is used in
customStyleForRenderer() and value().
(WebCore::DateTimeNumericFieldElement::value): Use formatValue().

  • html/shadow/DateTimeNumericFieldElement.h:

(DateTimeNumericFieldElement): Declare new functions.

LayoutTests:

Update a test and test expectations.

  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.txt:
  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic.html:
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
  • platform/chromium/TestExpectations:
12:27 AM Changeset in webkit [130476] by tkent@chromium.org
  • 5 edits in trunk/Source/WebCore

Improve spelling and performance of Localizer.cpp
https://bugs.webkit.org/show_bug.cgi?id=98485

Reviewed by Kentaro Hara.

Some improvements pointed in webkit.org/b/98229#c5.

No new tests because of no behavior change.

  • platform/text/Localizer.h:

(Localizer):

  • Rename dateTimeFormatWithSecond to dateTimeFormatWithSeconds
  • Rename dateTimeFormatWithoutSecond to dateTimeFormatWithoutSeconds
  • Add data members: m_dateTimeFormatWithSeconds and m_dateTimeFormatWithoutSeconds.
  • platform/text/Localizer.cpp:

(WebCore::Localizer::timeFormat): Check isNull instead of isEmpty
(WebCore::Localizer::shortTimeFormat): Ditto.
(WebCore::Localizer::dateTimeFormatWithSeconds):

  • Renamed.
  • Cache the concatenation result to a data member.

(WebCore::Localizer::dateTimeFormatWithoutSeconds): Ditto.

  • html/DateTimeInputType.cpp:

(WebCore::DateTimeInputType::setupLayoutParameters): Follow the renaming.

  • html/DateTimeLocalInputType.cpp:

(WebCore::DateTimeLocalInputType::setupLayoutParameters): Ditto.

12:21 AM Changeset in webkit [130475] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK2][WTR] Unskip parser-tests-110.html test case.
https://bugs.webkit.org/show_bug.cgi?id=98484

Unreviewed EFL gardening.

fast/encoding/parser-tests-110.html test case has been passed consistently.

Patch by Kangil Han <kangil.han@samsung.com> on 2012-10-05

  • platform/efl-wk2/TestExpectations:
12:19 AM Changeset in webkit [130474] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Gardening, skip some failing test.

Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-10-05
Reviewed by Csaba Osztrogonác.

  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt/TestExpectations:
12:16 AM Changeset in webkit [130473] by commit-queue@webkit.org
  • 6 edits in trunk

[EFL] Fix window resizing / moving in WK1 and WKTR
https://bugs.webkit.org/show_bug.cgi?id=98486

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-05
Reviewed by Gyuyoung Kim.

Source/WebKit/efl:

Fix ChromeClientEfl::windowRect() code to use
ecore_evas_request_geometry_get() instead of
evas_object_geometry_get() and therefore avoid
returning incorrect values when the engine has
not processed a call to ecore_evas_move_resize()
yet. This fixes a couple of layout tests.

The code was also refactored a bit for
consistency with the WebKit2 EFL implementation.

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::windowRect):
(WebCore::ChromeClientEfl::setWindowRect):

Tools:

Fix PlatformWebView::windowFrame() and
PlatformWebView::setWindowFrame() in EFL's WKTR so
that it resizes / moves the window, not the view.

The new code matches the implementation in EwkView's
UIClient.

  • WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

(WTR::PlatformWebView::windowFrame):
(WTR::PlatformWebView::setWindowFrame):

LayoutTests:

Unskip 2 window resizing / moving tests now that
the implementation for those has been fixed in
WebKit1 EFL.

  • platform/efl-wk1/TestExpectations:

Oct 4, 2012:

11:58 PM Changeset in webkit [130472] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][WK2] Fix destination path when download with suggested filename on the Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=98334

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-10-04
Reviewed by Gyuyoung Kim.

Add callback functions for download requests to Minibrowser to set the destination path for download.
Set the destination path with suggested file name as (destination folder) + (suggested file name).
The 'destination folder' should be a specific folder user selected, but is set to '/tmp' for now.

Additionally, for printing out the download status,
use the info macro and set the verbose variable to 1 to enable it.

  • MiniBrowser/efl/main.c:

(on_download_request):
(on_download_finished):
(on_download_failed):
(browserCreate):

11:57 PM Changeset in webkit [130471] by bashi@chromium.org
  • 10 edits
    2 adds in trunk/Source

[WebSocket] ExtensionParser should have its own file
https://bugs.webkit.org/show_bug.cgi?id=98475

Reviewed by Yuta Kitamura.

Source/WebCore:

Factor out ExtensionParser from WebSocketExtensionDispatcher and rename it as WebSocketExtensionParser.
WebSocketExtensionParser has its own file.

No changes in behavior. Added a test case for parsing Sec-WebSocket-Extensions field as a chromium unit test.

  • CMakeLists.txt: Added WebSocketExtensionParser.
  • GNUmakefile.list.am: Ditto.
  • Modules/websockets/WebSocketExtensionDispatcher.cpp:

(WebCore::WebSocketExtensionDispatcher::processHeaderValue):
Use WebSocketExtensionParser::parseExtension() to parser extension header value.

  • Modules/websockets/WebSocketExtensionParser.cpp: Added.

(WebCore):
(WebCore::WebSocketExtensionParser::finished): Moved from ExtensionParser.
(WebCore::WebSocketExtensionParser::parsedSuccessfully): Ditto.
(WebCore::isSeparator): Ditto.
(WebCore::WebSocketExtensionParser::skipSpaces): Ditto.
(WebCore::WebSocketExtensionParser::consumeToken): Ditto.
(WebCore::WebSocketExtensionParser::consumeQuotedString): Ditto.
(WebCore::WebSocketExtensionParser::consumeQuotedStringOrToken): Ditto.
(WebCore::WebSocketExtensionParser::consumeCharacter): Ditto.
(WebCore::WebSocketExtensionParser::parseExtension): Moved from WebSocketExtensionDispatcher.

  • Modules/websockets/WebSocketExtensionParser.h: Added.

(WebCore):
(WebSocketExtensionParser):
(WebCore::WebSocketExtensionParser::WebSocketExtensionParser):
(WebCore::WebSocketExtensionParser::currentToken):

  • Target.pri: Added WebSocketExtensionParser.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.

Source/WebKit/chromium:

Add a test for parsing Sec-WebSocket-Extensions field.

  • tests/WebSocketExtensionDispatcherTest.cpp:

(WebCore):
(WebCore::TEST_F):

11:55 PM Changeset in webkit [130470] by ryuan.choi@samsung.com
  • 7 edits in trunk/Source/WebKit2

[EFL][WK2] ewk_web_error_free is not a public API
https://bugs.webkit.org/show_bug.cgi?id=98482

Reviewed by Gyuyoung Kim.

Because Ewk_Web_Error is just passed as a parameter of callback function
and maintained internally, ewk_web_error_free should not be a public API.

This patch moves ewk_web_error_free from public header to private header.

  • UIProcess/API/efl/ewk_context_download_client.cpp:
  • UIProcess/API/efl/ewk_view_loader_client.cpp:
  • UIProcess/API/efl/ewk_view_resource_load_client.cpp:
  • UIProcess/API/efl/ewk_web_error.cpp:
  • UIProcess/API/efl/ewk_web_error.h:
  • UIProcess/API/efl/ewk_web_error_private.h:
11:41 PM Changeset in webkit [130469] by commit-queue@webkit.org
  • 9 edits in trunk

<input> size attribute should throw INDEX_SIZE_ERR when set to 0
https://bugs.webkit.org/show_bug.cgi?id=61675

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-10-04
Reviewed by Kent Tamura.

Source/WebCore:

According to the spec, the size IDL attribute of input elements is limited
to only non-negative numbers greater than zero. It should throw INDEX_SIZE_ERR
exception when set to 0. New behavior matches both Firefox and IE.
Spec: http://www.w3.org/TR/html5/common-input-element-attributes.html#the-size-attribute

Test: fast/dom/HTMLInputElement/input-size-attribute.html

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setSize):

  • html/HTMLInputElement.h:

(HTMLInputElement):

  • html/HTMLInputElement.idl:

LayoutTests:

Added test case to verify that input.size throws INDEX_SIZE_ERR when set to 0.

Updated fast/forms/number/number-size.html to reflect new behavior.

  • fast/dom/HTMLInputElement/input-size-attribute-expected.txt:
  • fast/dom/HTMLInputElement/input-size-attribute.html:
  • fast/forms/number/number-size.html:
  • fast/forms/number/number-size-expected.txt:
11:39 PM Changeset in webkit [130468] by bashi@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Improve SocketStreamHandle::send() stability
https://bugs.webkit.org/show_bug.cgi?id=98459

Reviewed by Yuta Kitamura.

Avoid null dereference in SocketStreamHandleInternal::send().
No changes in behavior.

  • src/SocketStreamHandle.cpp:

(WebCore::SocketStreamHandleInternal::send):

11:24 PM Changeset in webkit [130467] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix font for date/time input types.
https://bugs.webkit.org/show_bug.cgi?id=98478

Reviewed by Kentaro Hara.

input[type=date] should use monospace font if
ENABLE_INPUT_MULTIPLE_FIELDS_UI && ENABLE_INPUT_TYPE_DATE.

For other date/time types, they should use monospace font only
if their types are enabled. input[type="foo"] matches input
element with type="foo" even if the foo type is not supported.

The input[type=date] change is covered by
fast/forms/date/calendar-picker-appearance.html,
platform/chromium/fast/forms/date/date-suggestion-picker-appearance*.html

  • css/html.css:

(input[type="date"]):
(input[type="datetime"]):
(input[type="datetime-local"]):
(input[type="month"]):
(input[type="time"]):

11:22 PM Changeset in webkit [130466] by commit-queue@webkit.org
  • 4 edits in trunk

[WK2][WKTR] Implement UIClient focus callbacks in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=98256

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-04
Reviewed by Kenneth Rohde Christiansen.

Tools:

Implement UIClient's focus callbacks in WebKitTestRunner.

  • WebKitTestRunner/TestController.cpp:

(WTR::focus):
(WTR::TestController::initialize):

LayoutTests:

Unskip fast/dom/Window/mozilla-focus-blur.html now that
WebKitTestRunner implements UIClient's focus callbacks.

  • platform/efl-wk2/TestExpectations:
11:15 PM Changeset in webkit [130465] by morrita@google.com
  • 9 edits
    4 adds in trunk/Source/WebCore

[Refactoring] Some classes in StyleResolver.cpp/h could have its own file.
https://bugs.webkit.org/show_bug.cgi?id=98469

Reviewed by Dimitri Glazkov.

This change extracts RuleData, RuleSet, RuleFeature and Featurs class
to its own file: RuleSet.h/cpp and RuleFeature.h/cpp

RuleFeature class is moved fro StyleResolver inner class to plain WebCore class.
Feaures class is renamed to RuleFeatureSet to avoid possible name conflict.

No new tests. Just splitting file and doing simple rename.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSAllInOne.cpp:
  • css/RuleFeature.cpp: Added.

(WebCore):
(WebCore::RuleFeatureSet::add):
(WebCore::RuleFeatureSet::clear):
(WebCore::RuleFeatureSet::reportMemoryUsage):

  • css/RuleFeature.h: Added.

(WebCore):
(RuleFeature):
(WebCore::RuleFeature::RuleFeature):
(RuleFeatureSet):
(WebCore::RuleFeatureSet::RuleFeatureSet):

  • css/RuleSet.cpp: Added.

(WebCore):
(WebCore::isSelectorMatchingHTMLBasedOnRuleHash):
(WebCore::selectorListContainsUncommonAttributeSelector):
(WebCore::isCommonAttributeSelectorAttribute):
(WebCore::containsUncommonAttributeSelector):
(WebCore::RuleData::RuleData):
(WebCore::RuleData::reportMemoryUsage):
(WebCore::reportAtomRuleMap):
(WebCore::RuleSet::reportMemoryUsage):
(WebCore::RuleSet::RuleSetSelectorPair::reportMemoryUsage):
(WebCore::collectFeaturesFromSelector):
(WebCore::collectFeaturesFromRuleData):
(WebCore::RuleSet::addToRuleSet):
(WebCore::RuleSet::addRule):
(WebCore::RuleSet::addPageRule):
(WebCore::RuleSet::addRegionRule):
(WebCore::RuleSet::addRulesFromSheet):
(WebCore::RuleSet::addStyleRule):
(WebCore::shrinkMapVectorsToFit):
(WebCore::RuleSet::shrinkToFit):

  • css/RuleSet.h: Added.

(WebCore):
(RuleData):
(WebCore::RuleData::position):
(WebCore::RuleData::rule):
(WebCore::RuleData::selector):
(WebCore::RuleData::selectorIndex):
(WebCore::RuleData::hasFastCheckableSelector):
(WebCore::RuleData::hasMultipartSelector):
(WebCore::RuleData::hasRightmostSelectorMatchingHTMLBasedOnRuleHash):
(WebCore::RuleData::containsUncommonAttributeSelector):
(WebCore::RuleData::specificity):
(WebCore::RuleData::linkMatchType):
(WebCore::RuleData::hasDocumentSecurityOrigin):
(WebCore::RuleData::isInRegionRule):
(WebCore::RuleData::descendantSelectorIdentifierHashes):
(SameSizeAsRuleData):
(RuleSet):
(WebCore::RuleSet::create):
(WebCore::RuleSet::disableAutoShrinkToFit):
(WebCore::RuleSet::features):
(WebCore::RuleSet::idRules):
(WebCore::RuleSet::classRules):
(WebCore::RuleSet::tagRules):
(WebCore::RuleSet::shadowPseudoElementRules):
(WebCore::RuleSet::linkPseudoClassRules):
(WebCore::RuleSet::focusPseudoClassRules):
(WebCore::RuleSet::universalRules):
(WebCore::RuleSet::pageRules):
(WebCore::RuleSet::RuleSetSelectorPair::RuleSetSelectorPair):
(RuleSetSelectorPair):
(WebCore::RuleSet::RuleSet):

  • css/StyleResolver.cpp:

(WebCore):
(WebCore::makeRuleSet):
(WebCore::StyleResolver::collectMatchingRulesForList):

  • css/StyleResolver.h:

(StyleResolver):

11:11 PM Changeset in webkit [130464] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/Source/WebKit2

[EFL][WK2] Implement window frame callbacks in UIClient
https://bugs.webkit.org/show_bug.cgi?id=98280

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-04
Reviewed by Kenneth Rohde Christiansen.

Implement callbacks to set and query window geometry
in EwkView's UIClient.

  • UIProcess/API/efl/ewk_view_ui_client.cpp:

(getWindowFrame):
(setWindowFrame):
(ewk_view_ui_client_attach):

  • UIProcess/API/efl/tests/resources/window_move_resize.html: Added.
  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(windowMoveResizeTimedOut):
(TEST_F): Add corresponding unit test.

11:02 PM Changeset in webkit [130463] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

FeatureObserver should distinguish between legacy HTML and text notifications
https://bugs.webkit.org/show_bug.cgi?id=98441

Reviewed by Tony Chang.

We might be able to drop support for legacy HTML notifications before
we can drop support for legacy text notifications. We should measure
and find out.

  • Modules/notifications/NotificationCenter.idl:
  • page/FeatureObserver.h:
10:00 PM Changeset in webkit [130462] by dpranke@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Chromium DEPS roll r160281:160322

Unreviewed.

  • DEPS:
9:59 PM Changeset in webkit [130461] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Removing the unused member variable m_wasMalformed from HTMLFormElement class and its related code frgment.
https://bugs.webkit.org/show_bug.cgi?id=98444

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-10-04
Reviewed by Eric Seidel.

The member variable m_wasMalformed of HTMLFormElement class was used to determine if the <form> tag was malformed or not.
This information was used elsewhere to decide if bottom margins have to be included for such a <form>.
However currently this member variable is not being set by any code following code refactoring in HTML parser class.

Code cleanup patch. No new tests required.

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::HTMLFormElement):

Removed m_wasMalformed initialization.

  • html/HTMLFormElement.h:

(HTMLFormElement):

Removed m_wasMalformed variable.
Removed m_wasMalformed variable's setter and getter functions.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):

Removed code fragment using/dependent on m_wasMalformed.

9:56 PM Changeset in webkit [130460] by commit-queue@webkit.org
  • 16 edits in trunk

Turn Compositing on by default in WebKit build
https://bugs.webkit.org/show_bug.cgi?id=98315

Patch by Rik Cabanier <cabanier@adobe.com> on 2012-10-04
Reviewed by Simon Fraser.

enable -webkit-blend-mode on trunk.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No new tests. Existing blending test were updated.

  • Configurations/FeatureDefines.xcconfig:
  • css/CSSPropertyNames.in:
  • css/CSSValueKeywords.in:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:

LayoutTests:

  • css3/compositing/blend-mode-property-expected.txt:
  • css3/compositing/blend-mode-property-parsing-expected.txt:
  • css3/compositing/script-tests/blend-mode-property.js:

(testblendmode):

  • css3/compositing/should-have-compositing-layer-expected.txt:
  • platform/chromium/TestExpectations:
9:47 PM Changeset in webkit [130459] by hayato@chromium.org
  • 4 edits
    1 add in trunk

[Refactoring] Introduce a traversal strategy in SelectorChecker
https://bugs.webkit.org/show_bug.cgi?id=97298

Reviewed by Antti Koivisto.

PerformanceTests:

Introduces querySelector() performance tests to check SelectorChecker performance.

  • CSS/PseudoClassSelectors.html: Added.

Source/WebCore:

We extract DOM traversal code from SelectorChecker so that we can use another traversal strategy.
Another traversal strategy will be introduced in Bug 96990.

Since this code path is very hot, we were very careful not to regress performance.
We will use template specialization to change the traversal implementation.

We confirmed that this patch does not regress SelectorCheckerPerformance. I have checked the performance of
the added test in my Linux Box using run-perf-tests.

The performance of the added test before using this patch was:

RESULT CSS: PseudoClassSelectors= 3399.68308031 runs/s
median= 3404.48685564 runs/s, stdev= 37.3480114449 runs/s, min= 3272.64871114 runs/s, max= 3438.72385184 runs/s

When we used this patch, the performance was:

RESULT CSS: PseudoClassSelectors= 3367.74473886 runs/s
median= 3367.12072755 runs/s, stdev= 14.1464547639 runs/s, min= 3348.55881171 runs/s, max= 3395.98212857 runs/s

Test: PerformanceTests/CSS/PseudoClass-Selectors.html

  • css/SelectorChecker.cpp:

(WebCore):
(WebCore::SelectorChecker::checkSelector): Make this a template method to accept another Context type.
Another Context type will be introduced in coming patch.
(WebCore::SelectorChecker::checkOneSelector):
(WebCore::SelectorChecker::DOMTraversalStrategy::isFirstChild):
(WebCore::SelectorChecker::DOMTraversalStrategy::isLastChild):
(WebCore::SelectorChecker::DOMTraversalStrategy::isFirstOfType):
(WebCore::SelectorChecker::DOMTraversalStrategy::isLastOfType):
(WebCore::SelectorChecker::DOMTraversalStrategy::countElementsBefore):
(WebCore::SelectorChecker::DOMTraversalStrategy::countElementsOfTypeBefore):
(WebCore::SelectorChecker::DOMTraversalStrategy::countElementsAfter):
(WebCore::SelectorChecker::DOMTraversalStrategy::countElementsOfTypeAfter):

  • css/SelectorChecker.h:

(WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext):
(SelectorCheckingContext):
(SelectorChecker):
(DOMTraversalStrategy): Extracted the DOM traversal code from SelectorChecker. Another traversal code
will be introduced the coming patch.

9:44 PM Changeset in webkit [130458] by tkent@chromium.org
  • 4 edits in trunk/LayoutTests

Update some picker tests for input[type=date]
https://bugs.webkit.org/show_bug.cgi?id=98390

Follow up of r130433. We still need offsetTop access.

  • fast/forms/date/calendar-picker-common.js:

(openPicker):

  • fast/forms/resources/suggestion-picker-common.js:

(openPicker):

  • platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html:

Remove unnecessary width style.

9:37 PM Changeset in webkit [130457] by tony@chromium.org
  • 19 edits
    1 add in trunk/LayoutTests

Convert some flexbox tests to run in mozilla
https://bugs.webkit.org/show_bug.cgi?id=98464

Reviewed by Ojan Vafai.

Move properties with a small number of values into resources/flexbox.css
and start using it in some flexbox tests.

  • css3/flexbox/align-absolute-child.html:
  • css3/flexbox/align-baseline-expected.html:
  • css3/flexbox/align-baseline.html:
  • css3/flexbox/anonymous-block-merge-crash.html:
  • css3/flexbox/anonymous-block.html:
  • css3/flexbox/auto-height-dynamic.html:
  • css3/flexbox/auto-margins.html:
  • css3/flexbox/box-sizing-min-max-sizes.html:
  • css3/flexbox/box-sizing.html:
  • css3/flexbox/child-overflow-expected.html:
  • css3/flexbox/child-overflow.html:
  • css3/flexbox/columns-auto-size.html:
  • css3/flexbox/columns-height-set-via-top-bottom.html:
  • css3/flexbox/content-height-with-scrollbars.html:
  • css3/flexbox/cross-axis-scrollbar.html:
  • css3/flexbox/flex-algorithm-min-max.html:
  • css3/flexbox/flex-algorithm-with-margins.html:
  • css3/flexbox/flex-algorithm.html:
  • css3/flexbox/resources/flexbox.css: Added.
9:22 PM Changeset in webkit [130456] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

SVGAttributeHashTranslator does not need to copy QualifiedName in the common case
https://bugs.webkit.org/show_bug.cgi?id=98473

Reviewed by Adam Barth.

I tested this using instruments on a test case which modified SVG attributes in a loop.
I believe pdr has some perf-tests in this area, but they weren't needed here. A simple sample showed this as a huge win,
since we're no longer creating a QualifiedName (and thus adding it to the hash) on each QualifiedName-based lookup in SVG.

  • svg/SVGElement.h:

(WebCore::SVGAttributeHashTranslator::hash):
(WebCore::SVGAttributeHashTranslator::equal):

9:14 PM Changeset in webkit [130455] by aelias@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Scale plugin container by frameScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=98468

Reviewed by Adam Barth.

Plugin containers (for invalid plugins) weren't taking into account
frameScaleFactor, looking cut off when that was non-1.

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::paint):

8:56 PM Changeset in webkit [130454] by jchaffraix@webkit.org
  • 5 edits in trunk/Source/WebCore

Split the intrinsic padding update code out of RenderTableSection::layoutRows
https://bugs.webkit.org/show_bug.cgi?id=98454

Reviewed by Eric Seidel.

RenderTableSection::layoutRows is very long and it's difficult to see what's
going on. This change moves the intrinsic padding update code into RenderTableCell
for clarity. While at it, cleaned up a bit the code (renaming variables, functions).

Change covered by existing table tests.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::computeIntrinsicPadding):
Added this new function that does the update. Removed the 'default' case, replaced by
the explicit label BASELINE_MIDDLE.

  • rendering/RenderTableCell.h:

(WebCore::RenderTableCell::setIntrinsicPaddingBefore):
(WebCore::RenderTableCell::setIntrinsicPaddingAfter):
(WebCore::RenderTableCell::setIntrinsicPadding):
Moved those setters to the private section as we want other classes
to use computeIntrinsicPadding.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):
Replaced the code with a call to RenderTableCell::computeIntrinsicPadding.
Also moved 2 variables in the loop per our coding style.

  • rendering/RenderTableSection.h:

(WebCore::RenderTableSection::rowBaseline):
Renamed to match our coding style.

8:18 PM Changeset in webkit [130453] by Simon Fraser
  • 2 edits in trunk/Source/WebKit2

Fix the Qt build by removing an errant paste at the top of the file.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
7:55 PM Changeset in webkit [130452] by dpranke@chromium.org
  • 2 edits
    2 copies
    1 move
    1 add in trunk/LayoutTests

Update chromium baselines for 5006779.html and paint-subrect-grid.html.

Unreviewed, rebaselining.

Updates after r130425 and r130411.

  • platform/chromium-linux/fast/images/paint-subrect-grid-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/images/paint-subrect-grid-expected.png.
  • platform/chromium-win-xp/editing/pasteboard/5006779-expected.png: Added.
  • platform/chromium-win-xp/editing/pasteboard/5006779-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/pasteboard/5006779-expected.txt.
  • platform/chromium-win/editing/pasteboard/5006779-expected.txt:
  • platform/chromium/fast/images/paint-subrect-grid-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/images/paint-subrect-grid-expected.png.
7:47 PM Changeset in webkit [130451] by hclam@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewd. Chromium DEPS roll. Update to r160281.

  • DEPS:
7:37 PM Changeset in webkit [130450] by ryuan.choi@samsung.com
  • 6 edits
    2 adds in trunk

[EFL][WK2] Add APIs to get/set the frame flattening.
https://bugs.webkit.org/show_bug.cgi?id=95982

Reviewed by Gyuyoung Kim.

Source/WebKit2:

Added new APIs and test case to support frame flattening.

  • UIProcess/API/efl/ewk_settings.cpp:

(ewk_settings_enable_frame_flattening_set):
(ewk_settings_enable_frame_flattening_get):

  • UIProcess/API/efl/ewk_settings.h:
  • UIProcess/API/efl/tests/resources/frame_flattening_test.html: Added.
  • UIProcess/API/efl/tests/resources/frame_flattening_test_subframe.html: Added.
  • UIProcess/API/efl/tests/test_ewk2_settings.cpp:

(TEST_F):

Tools:

  • MiniBrowser/efl/main.c: Added frame flattening option to test.

(browserCreate):
(main):

7:31 PM Changeset in webkit [130449] by Nate Chapin
  • 2 edits in trunk/Source/WebCore

Crash in EventHandler::mouseMoved().
https://bugs.webkit.org/show_bug.cgi?id=98460

Reviewed by Abhishek Arya.

No new tests, this fixes fast/events/mouse-moved-remove-frame-crash.html.

  • page/EventHandler.cpp:

(WebCore::EventHandler::mouseMoved):

7:30 PM Changeset in webkit [130448] by pilgrim@chromium.org
  • 41 edits in trunk/Source/WebKit/chromium

[Chromium] Update some #includes for Platform directory
https://bugs.webkit.org/show_bug.cgi?id=98440

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

  • src/ApplicationCacheHost.cpp:
  • src/AssociatedURLLoader.h:
  • src/AsyncFileWriterChromium.cpp:
  • src/AudioDestinationChromium.h:
  • src/AutofillPopupMenuClient.cpp:
  • src/ChromeClientImpl.cpp:
  • src/ContextMenuClientImpl.cpp:
  • src/DeliveredIntentClientImpl.h:
  • src/DragClientImpl.cpp:
  • src/DragScrollTimer.h:
  • src/FrameLoaderClientImpl.cpp:
  • src/InspectorClientImpl.cpp:
  • src/InspectorClientImpl.h:
  • src/InspectorFrontendClientImpl.cpp:
  • src/NotificationPresenterImpl.cpp:
  • src/PageWidgetDelegate.h:
  • src/SocketStreamHandle.cpp:
  • src/SocketStreamHandleInternal.h:
  • src/SpeechInputClientImpl.cpp:
  • src/StorageAreaProxy.cpp:
  • src/StorageNamespaceProxy.cpp:
  • src/UserMediaClientImpl.cpp:
  • src/WebAccessibilityObject.cpp:
  • src/WebAnimationControllerImpl.cpp:
  • src/WebCommon.cpp:
  • src/WebDOMEventListenerPrivate.h:
  • src/WebDOMMessageEvent.cpp:
  • src/WebDOMStringList.cpp:
  • src/WebDataSourceImpl.cpp:
  • src/WebDatabase.cpp:
  • src/WebDevToolsAgentImpl.cpp:
  • src/WebDevToolsAgentImpl.h:
  • src/WebDocument.cpp:
  • src/WebDocumentType.cpp:
  • src/WebDragData.cpp:
  • src/WebElement.cpp:
  • src/WebEntities.cpp:
  • src/WebFileChooserCompletionImpl.h:
  • src/WebFileSystemCallbacksImpl.cpp:
  • src/WebFontImpl.cpp:
7:26 PM Changeset in webkit [130447] by noel.gordon@gmail.com
  • 53 edits in trunk/LayoutTests

[chromium] Unreviewed. Rebaseline mac/win results after r130355
https://bugs.webkit.org/show_bug.cgi?id=98472

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-10-04

  • platform/chromium-mac-snowleopard/fast/clip/overflow-border-radius-combinations-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/clip/overflow-border-radius-fixed-position-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/clip/overflow-border-radius-transformed-expected.png: Added.
  • platform/chromium-mac-snowleopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-mac-snowleopard/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-after-reload-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-strict-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-styling-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-styling-strict-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-without-preload-expected.png:
  • platform/chromium-mac-snowleopard/media/track/track-cue-rendering-horizontal-expected.png:
  • platform/chromium-mac-snowleopard/media/track/track-cue-rendering-vertical-expected.png:
  • platform/chromium-mac-snowleopard/media/video-controls-rendering-expected.png:
  • platform/chromium-mac-snowleopard/media/video-display-toggle-expected.png:
  • platform/chromium-mac-snowleopard/media/video-no-audio-expected.png:
  • platform/chromium-mac-snowleopard/media/video-playing-and-pause-expected.png:
  • platform/chromium-mac/fast/clip/overflow-border-radius-combinations-expected.png:
  • platform/chromium-mac/fast/clip/overflow-border-radius-fixed-position-expected.png:
  • platform/chromium-mac/fast/clip/overflow-border-radius-transformed-expected.png:
  • platform/chromium-mac/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-mac/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac/media/audio-repaint-expected.png:
  • platform/chromium-mac/media/controls-after-reload-expected.png:
  • platform/chromium-mac/media/controls-strict-expected.png:
  • platform/chromium-mac/media/controls-styling-expected.png:
  • platform/chromium-mac/media/controls-styling-strict-expected.png:
  • platform/chromium-mac/media/controls-without-preload-expected.png:
  • platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.png:
  • platform/chromium-mac/media/track/track-cue-rendering-vertical-expected.png:
  • platform/chromium-mac/media/video-controls-rendering-expected.png:
  • platform/chromium-mac/media/video-display-toggle-expected.png:
  • platform/chromium-mac/media/video-no-audio-expected.png:
  • platform/chromium-mac/media/video-playing-and-pause-expected.png:
  • platform/chromium-mac/media/video-zoom-controls-expected.png:
  • platform/chromium-win-xp/media/track/track-cue-rendering-vertical-expected.png:
  • platform/chromium-win/fast/clip/overflow-border-radius-combinations-expected.png:
  • platform/chromium-win/fast/clip/overflow-border-radius-fixed-position-expected.png:
  • platform/chromium-win/fast/clip/overflow-border-radius-transformed-expected.png:
  • platform/chromium-win/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-win/media/audio-controls-rendering-expected.png:
  • platform/chromium-win/media/audio-repaint-expected.png:
  • platform/chromium-win/media/controls-after-reload-expected.png:
  • platform/chromium-win/media/controls-strict-expected.png:
  • platform/chromium-win/media/controls-styling-expected.png:
  • platform/chromium-win/media/controls-styling-strict-expected.png:
  • platform/chromium-win/media/controls-without-preload-expected.png:
  • platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.png:
  • platform/chromium-win/media/track/track-cue-rendering-vertical-expected.png:
  • platform/chromium-win/media/video-controls-rendering-expected.png:
  • platform/chromium-win/media/video-display-toggle-expected.png:
  • platform/chromium-win/media/video-no-audio-expected.png:
  • platform/chromium-win/media/video-playing-and-pause-expected.png:
  • platform/chromium-win/media/video-zoom-controls-expected.png:
  • platform/chromium/TestExpectations:
7:18 PM Changeset in webkit [130446] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

[V8] NotificationCenter leaks because it uses buggy custom bindings
https://bugs.webkit.org/show_bug.cgi?id=98445

Reviewed by Tony Chang.

There's no reason to use custom bindings here. All they do is cause leaks..

  • Modules/notifications/NotificationCenter.idl:
  • bindings/v8/custom/V8NotificationCenterCustom.cpp:
7:16 PM Changeset in webkit [130445] by keishi@webkit.org
  • 4 edits
    2 copies in branches/chromium/1271

Merge 130008 - REGRESSION(r127727): Calendar picker is ignoring step
https://bugs.webkit.org/show_bug.cgi?id=97893

Reviewed by Kent Tamura.

Source/WebCore:

There were two mistakes:

  • An if-statement to check step attribute validity was wrong, and
  • DateTiemChooserParameters.step was milleseconds when it should be number of days.

This will be changing the DateTimeChooserParameters.step to milliseconds so we can handle steps for other input types in the future.

Test: fast/forms/date/calendar-picker-appearance-with-step.html

  • Resources/pagepopups/calendarPicker.js:

(CalendarPicker):

  • html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::openPopup): If statement was wrong.

LayoutTests:

  • fast/forms/date/calendar-picker-appearance-with-step-expected.txt: Added.
  • fast/forms/date/calendar-picker-appearance-with-step.html: Added.

TBR=keishi@webkit.org

7:04 PM Changeset in webkit [130444] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk

Selector specificity categories "overflow" into higher categories
https://bugs.webkit.org/show_bug.cgi?id=98295

Patch by Tab Atkins <jackalmage@gmail.com> on 2012-10-04
Reviewed by Eric Seidel.

This patch adds per-component overflow guards for CSS selector specificity.
Previously, we didn't guard against overflow.
Since we stored each component as a byte mapped into a single unsigned int for the whole specificity,
256 of a particular simple selector was equivalent to 1 of the next-higher-group selector.
This violated the Selectors specification,
which requires the components to be compared lexicographically.

Tests: /fast/selectors/specificity-overflow.html

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::specificity):

7:03 PM Changeset in webkit [130443] by enrica@apple.com
  • 8 edits
    2 adds in trunk

Font::glyphDataAndPageForCharacter doesn't account for text orientation when using systemFallback on a cold cache.
https://bugs.webkit.org/show_bug.cgi?id=98452.

Reviewed by Dan Bernstein.

Source/WebCore:

The text orientation was considered only when there is a cache hit.
This change moves the logic to handle text orientation to a separate
inline function that is called also when the glyph is added to the cache.

Test: fast/text/vertical-rl-rtl-linebreak.html

  • platform/graphics/FontFastPath.cpp:

(WebCore::applyTextOrientationForCharacter): Added.
(WebCore::Font::glyphDataAndPageForCharacter): Modified to use the new function in
both cases of cold and warm cache.

LayoutTests:

The new test adds platform specific results for Mac, since it uses system fallback fonts.
I've added the expected failure for all the other platforms.

  • fast/text/vertical-rl-rtl-linebreak.html: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/fast/text/vertical-rl-rtl-linebreak-expected.txt: Added.
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
6:57 PM FeatureFlags edited by tkent@chromium.org
Remove LEGACY_WEBKIT_BLOB_BUILDER. Add INPUT_TYPE_DATE_LEGACY_UI (diff)
6:02 PM Changeset in webkit [130442] by adamk@chromium.org
  • 3 edits
    2 adds in trunk

MutationRecord attributeName should be null for non attribute changes
https://bugs.webkit.org/show_bug.cgi?id=98438

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/mutation/mutation-record-nullity.html

  • dom/MutationRecord.idl:

LayoutTests:

  • fast/mutation/mutation-record-nullity-expected.txt: Added.
  • fast/mutation/mutation-record-nullity.html: Added.
5:54 PM Changeset in webkit [130441] by Simon Fraser
  • 2 edits in trunk/Source/WebKit2

TiledCoreAnimationDrawingArea.mm should not include RenderLayerCompositor.h
https://bugs.webkit.org/show_bug.cgi?id=98471

Reviewed by Dean Jackson.

Remove #import of <WebCore/RenderLayerCompositor.h> from this file.
It is not required.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
5:46 PM Changeset in webkit [130440] by rniwa@webkit.org
  • 6 edits
    1 delete in trunk/LayoutTests

More Qt rebaselines after r130411.

  • platform/qt/editing/deleting/delete-block-merge-contents-020-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-021-expected.txt:
  • platform/qt/editing/pasteboard/5006779-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-007-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-008-expected.txt:
  • platform/qt/editing/pasteboard/smart-paste-004-expected.txt: Removed.
5:43 PM Changeset in webkit [130439] by Simon Fraser
  • 58 edits in trunk/Source

Final part of "sync" to "flush" renaming
https://bugs.webkit.org/show_bug.cgi?id=98430

Reviewed by Tim Horton.

Change method names on GraphicsLayer and GraphicsLayerClient that
refer to "sync" to use the term "flush" instead, to be consistent
with the rest of the code.

Source/WebCore:

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::flushCompositingState):
(WebCore::GraphicsLayer::flushCompositingStateForThisLayerOnly):

  • platform/graphics/GraphicsLayerClient.h:

(GraphicsLayerClient):

  • platform/graphics/blackberry/GraphicsLayerBlackBerry.h:

(WebCore::GraphicsLayerBlackBerry::notifyFlushRequired):

  • platform/graphics/blackberry/LayerWebKitThread.cpp:

(WebCore::LayerWebKitThread::setNeedsCommit):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::flushCompositingState):
(WebCore::GraphicsLayerCA::flushCompositingStateForThisLayerOnly):
(WebCore::GraphicsLayerCA::platformCALayerDidCreateTiles):
(WebCore::GraphicsLayerCA::positionForCloneRootLayer):
(WebCore::GraphicsLayerCA::noteLayerPropertyChanged):

  • platform/graphics/ca/GraphicsLayerCA.h:

(GraphicsLayerCA):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::notifyChange):
(WebCore::GraphicsLayerTextureMapper::flushCompositingStateForThisLayerOnly):
(WebCore::GraphicsLayerTextureMapper::flushCompositingState):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:

(GraphicsLayerTextureMapper):

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::flushCompositingState):
(WebCore::TextureMapperLayer::flushCompositingStateSelf):

  • platform/graphics/texmap/TextureMapperLayer.h:

(TextureMapperLayer):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::notifyFlushRequired):

  • rendering/RenderLayerBacking.h:

(RenderLayerBacking):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::flushPendingLayerChanges):

  • rendering/RenderLayerCompositor.h:

(WebCore::RenderLayerCompositor::notifyFlushRequired):

Source/WebKit/blackberry:

  • Api/WebOverlay.cpp:

(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::notifyFlushRequired):

  • Api/WebOverlay_p.h:

(WebOverlayPrivateWebKitThread):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::notifyFlushRequired):

  • Api/WebPage_p.h:

(WebPagePrivate):

  • WebKitSupport/DefaultTapHighlight.cpp:

(BlackBerry::WebKit::DefaultTapHighlight::notifyFlushRequired):

  • WebKitSupport/DefaultTapHighlight.h:

(DefaultTapHighlight):

  • WebKitSupport/InspectorOverlayBlackBerry.cpp:

(BlackBerry::WebKit::InspectorOverlay::notifyFlushRequired):

  • WebKitSupport/InspectorOverlayBlackBerry.h:

(InspectorOverlay):

  • WebKitSupport/SelectionOverlay.cpp:

(BlackBerry::WebKit::SelectionOverlay::notifyFlushRequired):

  • WebKitSupport/SelectionOverlay.h:

(SelectionOverlay):

Source/WebKit/efl:

  • WebCoreSupport/AcceleratedCompositingContextEfl.cpp:

(WebCore::AcceleratedCompositingContext::syncLayersNow):
(WebCore::AcceleratedCompositingContext::attachRootGraphicsLayer):

Source/WebKit/gtk:

  • WebCoreSupport/AcceleratedCompositingContext.h:

(AcceleratedCompositingContext):

  • WebCoreSupport/AcceleratedCompositingContextCairo.cpp:

(WebKit::AcceleratedCompositingContext::attachRootGraphicsLayer):
(WebKit::AcceleratedCompositingContext::resizeRootLayer):
(WebKit::AcceleratedCompositingContext::syncLayersNow):
(WebKit::AcceleratedCompositingContext::notifyFlushRequired):

  • WebCoreSupport/AcceleratedCompositingContextClutter.cpp:

(WebKit::AcceleratedCompositingContext::flushPendingLayerChanges):
(WebKit::AcceleratedCompositingContext::notifyFlushRequired):

  • WebCoreSupport/AcceleratedCompositingContextGL.cpp:

(WebKit::AcceleratedCompositingContext::flushPendingLayerChanges):
(WebKit::AcceleratedCompositingContext::notifyFlushRequired):

Source/WebKit/mac:

  • WebView/WebView.mm:

Source/WebKit/qt:

  • WebCoreSupport/PageClientQt.cpp:

(WebCore::TextureMapperLayerClientQt::syncRootLayer):

Source/WebKit/win:

  • WebView.cpp:

(WebView::notifyFlushRequired):
(WebView::flushPendingGraphicsLayerChanges):

  • WebView.h:

Source/WebKit2:

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::paintToCurrentGLContext):
(WebKit::LayerTreeRenderer::flushLayerChanges):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:

(WebKit::LayerTreeRenderer::notifyFlushRequired):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::didChangeLayerState):
(WebCore::CoordinatedGraphicsLayer::didChangeAnimatedProperties):
(WebCore::CoordinatedGraphicsLayer::didChangeChildren):
(WebCore::CoordinatedGraphicsLayer::didChangeFilters):
(WebCore::CoordinatedGraphicsLayer::setContentsNeedsDisplay):
(WebCore::CoordinatedGraphicsLayer::setContentsToCanvas):
(WebCore::CoordinatedGraphicsLayer::flushCompositingState):
(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:

(CoordinatedGraphicsLayer):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):
(WebKit::LayerTreeCoordinator::notifyFlushRequired):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

  • WebProcess/WebPage/ca/LayerTreeHostCA.cpp:

(WebKit::LayerTreeHostCA::notifyFlushRequired):
(WebKit::LayerTreeHostCA::flushPendingLayerChanges):

  • WebProcess/WebPage/ca/LayerTreeHostCA.h:

(LayerTreeHostCA):

  • WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::notifyFlushRequired):
(WebKit::LayerTreeHostGtk::flushPendingLayerChanges):

  • WebProcess/WebPage/gtk/LayerTreeHostGtk.h:

(LayerTreeHostGtk):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::notifyFlushRequired):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):

5:41 PM Changeset in webkit [130438] by rniwa@webkit.org
  • 22 edits in trunk/LayoutTests

GTK+ rebaselines after r130411.

  • platform/gtk/editing/deleting/delete-block-merge-contents-018-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-019-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-020-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-021-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-022-expected.txt:
  • platform/gtk/editing/deleting/merge-no-br-expected.txt:
  • platform/gtk/editing/execCommand/find-after-replace-expected.txt:
  • platform/gtk/editing/execCommand/paste-2-expected.txt:
  • platform/gtk/editing/pasteboard/4944770-2-expected.txt:
  • platform/gtk/editing/pasteboard/5006779-expected.txt:
  • platform/gtk/editing/pasteboard/5028447-expected.txt:
  • platform/gtk/editing/pasteboard/drag-drop-modifies-page-expected.txt:
  • platform/gtk/editing/pasteboard/merge-end-borders-expected.txt:
  • platform/gtk/editing/pasteboard/paste-line-endings-008-expected.txt:
  • platform/gtk/editing/pasteboard/paste-line-endings-009-expected.txt:
  • platform/gtk/editing/pasteboard/paste-line-endings-010-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-008-expected.txt:
  • platform/gtk/editing/pasteboard/paste-xml-expected.txt:
  • platform/gtk/editing/pasteboard/smart-drag-drop-expected.txt:
  • platform/gtk/editing/pasteboard/subframe-dragndrop-1-expected.txt:
  • platform/gtk/fast/lists/drag-into-marker-expected.txt:
5:35 PM Changeset in webkit [130437] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

1ex should equal .5em when the font has no x-height metric
https://bugs.webkit.org/show_bug.cgi?id=80360

Patch by Tab Atkins <tabatkins@google.com> on 2012-10-04
Reviewed by Eric Seidel.

Source/WebCore:

Updated FontMetrics and CSSPrimitiveValue to have/use an explicit "hasXHeight" flag to determine how to size an 'ex' unit.

Updated a few of the platform font files to set the flag properly.

Patch cleanup by David Barr <davidbarr@chromium.org>.

Test: fast/css/ex-unit-with-no-x-height.html

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::computeLengthDouble):

  • platform/graphics/FontMetrics.h:

(WebCore::FontMetrics::FontMetrics):
(WebCore::FontMetrics::setXHeight):
(FontMetrics):
(WebCore::FontMetrics::hasXHeight):
(WebCore::FontMetrics::setHasXHeight):
(WebCore::FontMetrics::reset):

  • platform/graphics/skia/SimpleFontDataSkia.cpp:

(WebCore::SimpleFontData::platformInit):

LayoutTests:

If a font has no x-height metric, 1ex should equal .5em.

Test layout tweaked by David Barr <davidbarr@chromium.org>.

  • fast/css/ex-unit-with-no-x-height-expected.txt: Added.
  • fast/css/ex-unit-with-no-x-height.html: Added.
5:34 PM Changeset in webkit [130436] by dpranke@chromium.org
  • 2 edits in trunk/Source/WTF

Unreviewed, rolling out r130419.
http://trac.webkit.org/changeset/130419
https://bugs.webkit.org/show_bug.cgi?id=98406

broke editing/pasteboard/data-transfer-items.html on chromium

  • wtf/HashTraits.h:
4:52 PM Changeset in webkit [130435] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] New test introduced in r129346 inspector-protocol/css-getSupportedCSSProperties.html fails
https://bugs.webkit.org/show_bug.cgi?id=97451

Patch by Tullio Lucena <tullio.lucena@openbossa.org> on 2012-10-04
Reviewed by Kenneth Rohde Christiansen.

Unskipping this test that is passing.

  • platform/qt/TestExpectations:
4:51 PM Changeset in webkit [130434] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Implement PageClientImpl::isViewVisible()
https://bugs.webkit.org/show_bug.cgi?id=98249

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-04
Reviewed by Kenneth Rohde Christiansen.

Implement PageClientImpl::isViewVisible() for EFL port
by calling evas_object_visible_get() on the view.

  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::isViewVisible):

4:50 PM Changeset in webkit [130433] by tkent@chromium.org
  • 12 edits in trunk/LayoutTests

Update some picker tests for input[type=date]
https://bugs.webkit.org/show_bug.cgi?id=98390

Reviewed by Daniel Bates.

r130375 changed a behavior. A key bind to open a calendar picker
or a suggestion picker was changed from "Down" to "Alt + Down". We
need to update tests which open pickers for input[type=date].

  • fast/forms/date/calendar-picker-appearance-expected.txt:
  • fast/forms/date/calendar-picker-appearance-pre-100.html:

Use openPicker() in calendar-picker-common.js.

  • fast/forms/date/calendar-picker-appearance.html: Ditto.
  • fast/forms/date/calendar-picker-common.js:

(openPicker): Specify Alt modifier.
(sendKey): Add ctrlKey and altKey flags.

  • fast/forms/date/calendar-picker-with-step.html:

Use openPicker() in calendar-picker-common.js.

  • platform/chromium/TestExpectations:
  • platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html:

Use openPicker() in suggestion-picker-common.js

  • platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar.html:

Ditto.

  • platform/chromium/fast/forms/date/date-suggestion-picker-appearance.html:

Ditto.

  • platform/chromium/fast/forms/date/date-suggestion-picker-key-operations-expected.txt:
  • platform/chromium/fast/forms/date/date-suggestion-picker-key-operations.html:

Use openPicker() and sendKey() in suggestion-picker-common.js.
Increase the internal timeout because it was too short on my machine.

3:54 PM Changeset in webkit [130432] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Improve initial empty process tracking
https://bugs.webkit.org/show_bug.cgi?id=98458

Reviewed by Sam Weinig.

  • UIProcess/WebContext.cpp: (WebKit::WebContext::disconnectProcess): Unset m_haveInitialEmptyProcess if we no longer do.
3:52 PM Changeset in webkit [130431] by Lucas Forschler
  • 1 copy in tags/Safari-534.58.1

New Tag.

3:45 PM Changeset in webkit [130430] by hclam@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed. Chromium rebaselines.

Rebaseline pixel results after r130412.

  • platform/chromium-mac-snowleopard/scrollbars/listbox-scrollbar-combinations-expected.png:
  • platform/chromium-mac/scrollbars/listbox-scrollbar-combinations-expected.png:
3:40 PM Changeset in webkit [130429] by rniwa@webkit.org
  • 4 edits in trunk

Source/WebCore: Build fix after r130411. Add the right offset.
Also use RefPtr instead of a raw pointer for next and previous pointers.

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::mergeTextNodesAroundPosition):

LayoutTests: Another rebaseline needed after r130411.

  • platform/mac/editing/pasteboard/5006779-expected.txt:
3:38 PM Changeset in webkit [130428] by alecflett@chromium.org
  • 30 edits in trunk/Source

IndexedDB: promote objectstore/index backend ids to the frontend
https://bugs.webkit.org/show_bug.cgi?id=97834

Reviewed by Tony Chang.

Source/WebCore:

Expose int64-based database/objectStore/index ids to the renderer,
step 1 of 2. Support both styles of createObjectStore and
createIndex: those that take an explicit id, and those that take
-1, meaning to autogenerate an id on the backend. In part 2, after
the chromium side lands, support for the autogenerated ids will be
removed. (See https://bugs.webkit.org/show_bug.cgi?id=98085)

This is a part of larger refactoring work to ultimately make the interface
between the frontend and the backend simpler.

No new tests, extensive ASSERTs and existing tests cover correctness.

  • Modules/indexeddb/IDBBackingStore.h:

(IDBBackingStore):

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::createObjectStore):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::openInternal):
(WebCore::IDBDatabaseBackendImpl::metadata):
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore):
(WebCore::IDBDatabaseBackendImpl::createObjectStoreInternal):
(WebCore::IDBDatabaseBackendImpl::loadObjectStores):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBDatabaseBackendInterface.h:

(IDBDatabaseBackendInterface):

  • Modules/indexeddb/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::metadata):

  • Modules/indexeddb/IDBIndexBackendImpl.h:

(WebCore::IDBIndexBackendImpl::create):
(IDBIndexBackendImpl):

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore):
(WebCore::getMaxObjectStoreId):
(WebCore::IDBLevelDBBackingStore::getIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::deleteDatabase):
(WebCore::IDBLevelDBBackingStore::getObjectStores):
(WebCore::setMaxObjectStoreId):
(WebCore::IDBLevelDBBackingStore::createObjectStore):
(WebCore::getMaxIndexId):
(WebCore::setMaxIndexId):
(WebCore::IDBLevelDBBackingStore::createIndex):

  • Modules/indexeddb/IDBLevelDBBackingStore.h:

(IDBLevelDBBackingStore):

  • Modules/indexeddb/IDBMetadata.h:

(WebCore::IDBDatabaseMetadata::IDBDatabaseMetadata):
(IDBDatabaseMetadata):
(WebCore::IDBObjectStoreMetadata::IDBObjectStoreMetadata):
(IDBObjectStoreMetadata):
(WebCore::IDBIndexMetadata::IDBIndexMetadata):
(IDBIndexMetadata):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::createIndex):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl):
(WebCore::IDBObjectStoreBackendImpl::metadata):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::createIndexInternal):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(WebCore::IDBObjectStoreBackendImpl::create):
(IDBObjectStoreBackendImpl):

  • Modules/indexeddb/IDBObjectStoreBackendInterface.h:

Source/WebKit/chromium:

Support for marshalling additional IDBMetadata and new calls to
createObjectStore/createIndex.

  • public/WebIDBDatabase.h:

(WebKit::WebIDBDatabase::createObjectStore):

  • public/WebIDBMetadata.h:

(ObjectStore):
(Index):

  • public/WebIDBObjectStore.h:

(WebKit::WebIDBObjectStore::createIndex):

  • src/IDBDatabaseBackendProxy.cpp:

(WebKit::IDBDatabaseBackendProxy::createObjectStore):
(WebKit):

  • src/IDBDatabaseBackendProxy.h:

(IDBDatabaseBackendProxy):

  • src/IDBObjectStoreBackendProxy.cpp:

(WebKit::IDBObjectStoreBackendProxy::createIndex):
(WebKit):

  • src/IDBObjectStoreBackendProxy.h:

(IDBObjectStoreBackendProxy):

  • src/WebIDBDatabaseImpl.cpp:

(WebKit::WebIDBDatabaseImpl::createObjectStore):
(WebKit):

  • src/WebIDBDatabaseImpl.h:

(WebIDBDatabaseImpl):

  • src/WebIDBMetadata.cpp:

(WebKit::WebIDBMetadata::WebIDBMetadata):
(WebKit::WebIDBMetadata::operator IDBDatabaseMetadata):

  • src/WebIDBObjectStoreImpl.cpp:

(WebKit::WebIDBObjectStoreImpl::createIndex):
(WebKit):

  • src/WebIDBObjectStoreImpl.h:

(WebIDBObjectStoreImpl):

3:32 PM Changeset in webkit [130427] by commit-queue@webkit.org
  • 6 edits in trunk

[EFL] Add libxml 2.8.0 to jhbuild
https://bugs.webkit.org/show_bug.cgi?id=98418

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-04
Reviewed by Laszlo Gombos.

.:

Bump dependency for libxml to 2.8.0 to match
jhbuild.

  • Source/cmake/OptionsEfl.cmake:

Tools:

Add libxml 2.8.0 to EFL's jhbuild for consistency.

  • efl/jhbuild.modules:

LayoutTests:

Unskip fast/xsl/xslt-missing-namespace-in-xslt.xml
since it passes with libxml 2.8.0 and we now depend
on that version.

  • platform/efl/TestExpectations:
3:30 PM Changeset in webkit [130426] by tony@chromium.org
  • 5 edits
    1 copy
    1 move
    9 adds in trunk/LayoutTests

Unreviewed gardening. Landing render tree results for css3/flexbox/flexbox-baseline.html.
https://bugs.webkit.org/show_bug.cgi?id=98306

This pixel test was added in r130405.

  • platform/chromium-mac-snowleopard/css3/flexbox/flexbox-baseline-expected.png: Added.
  • platform/chromium-mac/css3/flexbox/flexbox-baseline-expected.png: Added.
  • platform/chromium-mac/css3/flexbox/flexbox-baseline-expected.txt: Added.
  • platform/chromium-win/css3/flexbox/flexbox-baseline-expected.png: Added.
  • platform/chromium-win/css3/flexbox/flexbox-baseline-expected.txt: Copied from LayoutTests/platform/chromium-linux/css3/flexbox/flexbox-baseline-expected.txt.
  • platform/chromium/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/gtk/css3/flexbox/flexbox-baseline-expected.txt: Added.
  • platform/mac/TestExpectations:
  • platform/mac/css3/flexbox/flexbox-baseline-expected.txt: Added.
  • platform/qt/TestExpectations:
  • platform/qt/css3/flexbox/flexbox-baseline-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css3/flexbox/flexbox-baseline-expected.txt.
3:23 PM Changeset in webkit [130425] by hclam@chromium.org
  • 1 edit
    1 copy
    1 move in trunk/LayoutTests

Unreviewed. Chromium rebaselines.

  • platform/chromium-mac/fast/images/paint-subrect-grid-expected.png: Copied from LayoutTests/platform/chromium/fast/images/paint-subrect-grid-expected.png.
  • platform/chromium-win/fast/images/paint-subrect-grid-expected.png: Renamed from LayoutTests/platform/chromium/fast/images/paint-subrect-grid-expected.png.
1:27 PM Changeset in webkit [130424] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Crash in Safari at com.apple.JavaScriptCore: WTF::StringImpl::is8Bit const + 12
https://bugs.webkit.org/show_bug.cgi?id=98433

Reviewed by Jessie Berlin.

The problem is due to a String with a null StringImpl (i.e. a null string).
Added a length check before the is8Bit() check since length() checks for a null StringImpl. Changed the
characters16() call to characters() since it can handle a null StringImpl as well.

  • API/JSValueRef.cpp:

(JSValueMakeFromJSONString):

1:18 PM Changeset in webkit [130423] by rniwa@webkit.org
  • 34 edits
    1 add
    1 delete in trunk/LayoutTests

Chromium rebaselines after r130411.

  • platform/chromium-linux-x86/editing/pasteboard/paste-xml-expected.txt:
  • platform/chromium-linux/editing/pasteboard/4944770-2-expected.txt:
  • platform/chromium-linux/editing/pasteboard/paste-xml-expected.txt:
  • platform/chromium-linux/editing/pasteboard/smart-drag-drop-expected.txt:
  • platform/chromium-linux/editing/pasteboard/subframe-dragndrop-1-expected.txt:
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-008-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-xml-expected.txt: Added.
  • platform/chromium-mac/editing/pasteboard/paste-xml-expected.txt:
  • platform/chromium-win-xp/editing/pasteboard/paste-xml-expected.txt:
  • platform/chromium-win/editing/deleting/delete-block-merge-contents-018-expected.txt:
  • platform/chromium-win/editing/deleting/delete-block-merge-contents-019-expected.txt:
  • platform/chromium-win/editing/deleting/delete-block-merge-contents-020-expected.txt:
  • platform/chromium-win/editing/deleting/delete-block-merge-contents-021-expected.txt:
  • platform/chromium-win/editing/deleting/delete-block-merge-contents-022-expected.txt:
  • platform/chromium-win/editing/deleting/merge-no-br-expected.txt:
  • platform/chromium-win/editing/execCommand/find-after-replace-expected.txt:
  • platform/chromium-win/editing/execCommand/paste-1-expected.txt:
  • platform/chromium-win/editing/execCommand/paste-2-expected.txt:
  • platform/chromium-win/editing/pasteboard/4944770-2-expected.txt:
  • platform/chromium-win/editing/pasteboard/5028447-expected.txt:
  • platform/chromium-win/editing/pasteboard/8145-3-expected.txt:
  • platform/chromium-win/editing/pasteboard/drag-drop-modifies-page-expected.txt:
  • platform/chromium-win/editing/pasteboard/merge-end-borders-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-line-endings-007-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-line-endings-008-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-line-endings-009-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-line-endings-010-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-match-style-001-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-text-008-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-text-009-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-xml-expected.txt:
  • platform/chromium-win/editing/pasteboard/smart-paste-007-expected.txt:
  • platform/chromium-win/editing/pasteboard/subframe-dragndrop-1-expected.txt:
  • platform/chromium-win/editing/pasteboard/unrendered-br-expected.txt:
  • platform/chromium-win/fast/lists/drag-into-marker-expected.txt:
1:09 PM Changeset in webkit [130422] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Layout broken after cloning and re-inserting a table with a misplaced <form>
https://bugs.webkit.org/show_bug.cgi?id=86746

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-10-04
Reviewed by Julien Chaffraix.

Source/WebCore:

There is a concept of demotion for a <form> contained in a table. A <form> is demoted if its immediate parent
is either a <table>, table sections (tbody, etc) or a table row (tr). A renderer for such a <form> is created only
if its display is one of the table display types (TABLE, INLINE_TABLE, TABLE_FOOTER_GROUP, etc).
However when a <table> containing a demoted <form> is cloned, the <form> does not retain its demotion state and
results in the table getting improperly rendered.

Test: fast/table/form-with-non-table-display-inside-table-elements.html

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::copyNonAttributePropertiesFromElement):

Extended the virtual function for HTMLFormElement class specific implementation.
The function is used to copy any necessary state information(member variables) associated with
the <form> element being cloned to the current node.
For HTMLFormElement node the member variable can be classified into five groups based on the
information they hold:

1) Variables containing information regarding <form> subtree and elements associated with it.

These get updated as and when an element is added to the <form> subtree.

2) Variables containing <form> submit state information.
3) Flag to hold information if reset() has been called.
4) Flag(m_wasDemoted) that indicates whether the form is demoted or not, based on which it needs to

be handled differently during creation of its renderer.
This information is currently being updated only during the HTML tree construction phase.

5) Flag(m_wasMalformed) to hold information if the <form> is malformed or not.

Variables of group (1) will be updated as and when elements are added to the <form> subtree. Whereas,
(2) and (3) hold instance specific information, thus copying them is not required. Also (5) is currently not
being used(not set by any code).

On the other hand, (4) is required to be copied during cloning as this information cannot be accessed
during the cloning process.

(WebCore):

  • html/HTMLFormElement.h: Added copyNonAttributePropertiesFromElement() declaration.

LayoutTests:

  • fast/table/form-with-non-table-display-inside-table-elements-expected.txt: Added.
  • fast/table/form-with-non-table-display-inside-table-elements.html: Added.
1:01 PM Changeset in webkit [130421] by rniwa@webkit.org
  • 20 edits in trunk/LayoutTests

Qt rebaseline after r130411.

  • platform/qt/editing/deleting/delete-block-merge-contents-018-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-019-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-022-expected.txt:
  • platform/qt/editing/deleting/merge-no-br-expected.txt:
  • platform/qt/editing/execCommand/find-after-replace-expected.txt:
  • platform/qt/editing/execCommand/paste-1-expected.txt:
  • platform/qt/editing/execCommand/paste-2-expected.txt:
  • platform/qt/editing/pasteboard/4944770-2-expected.txt:
  • platform/qt/editing/pasteboard/5006779-expected.txt:
  • platform/qt/editing/pasteboard/5028447-expected.txt:
  • platform/qt/editing/pasteboard/8145-3-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-borders-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-009-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-010-expected.txt:
  • platform/qt/editing/pasteboard/paste-match-style-001-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-008-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-009-expected.txt:
  • platform/qt/editing/pasteboard/smart-paste-007-expected.txt:
  • platform/qt/editing/pasteboard/unrendered-br-expected.txt:
12:57 PM Changeset in webkit [130420] by Lucas Forschler
  • 1 copy in tags/Safari-537.13

New Tag.

12:49 PM Changeset in webkit [130419] by kling@webkit.org
  • 2 edits in trunk/Source/WTF

Lower minimum table size of WTF::HashTable to reduce memory usage.
<http://webkit.org/b/98406>
<rdar://problem/12432140>

Reviewed by Anders Carlsson.

Lower the default minimumTableSize for WTF hash tables from 64 to 8 entries.
This reduces WebProcess memory consumption by ~16MB on Membuster3 (a 6% progression!)

No significant movement on PLT or JSC benchmarks on my machine. If there's a perf regression somewhere
from this, we can tweak individual tables to have a larger minimumTableSize.

  • wtf/HashTraits.h:
12:34 PM Changeset in webkit [130418] by benjamin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Use copyLCharsFromUCharSource() for IdentifierLCharFromUCharTranslator translation
https://bugs.webkit.org/show_bug.cgi?id=98335

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-10-04
Reviewed by Michael Saboff.

Michael Saboff added an optimized version of UChar->LChar conversion in r125846.
Use this function in JSC::Identifier.

  • runtime/Identifier.cpp:

(JSC::IdentifierLCharFromUCharTranslator::translate):

12:31 PM Changeset in webkit [130417] by dino@apple.com
  • 13 edits in trunk

Attribute and Uniform variable names need translation in shader
https://bugs.webkit.org/show_bug.cgi?id=70989

Reviewed by Tim Horton (and Darin Adler).

Source/WebCore:

WebGL specifies some maximum lengths for variable names (attributes
and uniforms). Also, some GL drivers have issues with long names. For
that reason, ANGLE has an option to rewrite the shader, translating
long names into short names. Turning this on helps shaders compile,
but we need to keep a mapping between the original names and the
translated names, so that we bind to the right location from user code
(which won't ever see the translated source).

This provided an opportunity to clean up some other bits of code:
CSS Filters examined the uniform names after a compilation; It can
now use the variable name map. I also added a typedef for the
HashMaps that keep the shader, the source code and the variable name
mappings.

I also opened a followup bug to make sure these tables are deleted
when the associated shaders (or linked programs) go away:
https://bugs.webkit.org/show_bug.cgi?id=98204

Covered by existing tests (with some enhancements):

  • fast/canvas/webgl/attrib-location-length-limits.html:
  • fast/canvas/webgl/uniform-location-length-limits.html:
  • platform/graphics/ANGLEWebKitBridge.cpp:

(WebCore::getSymbolInfo): Extracts all the information on symbols (either attributes
or uniforms) from the newly compiled shader.
(WebCore):
(WebCore::ANGLEWebKitBridge::compileShaderSource): New method name.

  • platform/graphics/ANGLEWebKitBridge.h:

(WebCore::getUniforms): Deleted this method.
(WebCore::ANGLEShaderSymbol::isSampler): Make sure the symbol is a uniform.
(ANGLEWebKitBridge):

  • platform/graphics/GraphicsContext3D.h:

(WebCore::GraphicsContext3D::SymbolInfo::SymbolInfo): A new object that
holds the size, type and translated name of a symbol from a WebGL shader.
(ShaderSourceEntry):
(WebCore::GraphicsContext3D::ShaderSourceEntry::ShaderSourceEntry): Now keeps track
of the translated source code and symbol mappings.
(WebCore::GraphicsContext3D::ShaderSourceEntry::symbolMap): Helper function to
get the member variable corresponding to the type of symbol you're asking fo.

  • platform/graphics/filters/CustomFilterValidatedProgram.cpp:

(WebCore::CustomFilterValidatedProgram::CustomFilterValidatedProgram): Calls new method
name which also produces a set of symbols to examine.

  • platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:

(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE): We now can pass
in some extra compile options to do translation of long symbol names. Also fill the
map of translated symbol names.

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::mappedSymbolName): Returns the mapped name for
a shader symbol if it was translated during compilation.
(WebCore):
(WebCore::GraphicsContext3D::getAttribLocation):
(WebCore::GraphicsContext3D::getShaderiv):
(WebCore::GraphicsContext3D::getShaderInfoLog):
(WebCore::GraphicsContext3D::getShaderSource):
(WebCore::GraphicsContext3D::getUniformLocation):

LayoutTests:

Added subtests to exercise variables that are well under the limits but
not long enough to produce an error. This way we now test all three options:
under the limit, at the limit, over the limit.

Also, the tests are unskipped on Mac.

  • fast/canvas/webgl/attrib-location-length-limits-expected.txt:
  • fast/canvas/webgl/attrib-location-length-limits.html:
  • fast/canvas/webgl/uniform-location-length-limits-expected.txt:
  • fast/canvas/webgl/uniform-location-length-limits.html:
  • platform/mac/TestExpectations:
12:10 PM Changeset in webkit [130416] by benjamin@webkit.org
  • 31 edits
    2 adds in trunk

[WK2] Support all attributes of GeolocationPosition
https://bugs.webkit.org/show_bug.cgi?id=98212

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-10-03
Reviewed by Sam Weinig.

Source/WebKit/mac:

Add an internal constructor for the sake of testing.
A similar API is used on iOS.

  • WebView/WebGeolocationPosition.mm:

(-[WebGeolocationPosition initWithGeolocationPosition:]):

Source/WebKit2:

Add complete support for GeolocationPosition.

  • Shared/WebGeolocationPosition.cpp:

(WebKit::WebGeolocationPosition::WebGeolocationPosition):
(WebKit::WebGeolocationPosition::Data::encode):
(WebKit::WebGeolocationPosition::Data::decode):

  • Shared/WebGeolocationPosition.h:

(Data):
(WebKit::WebGeolocationPosition::create):
(WebKit::WebGeolocationPosition::canProvideAltitude):
(WebKit::WebGeolocationPosition::altitude):
(WebGeolocationPosition):
(WebKit::WebGeolocationPosition::canProvideAltitudeAccuracy):
(WebKit::WebGeolocationPosition::altitudeAccuracy):
(WebKit::WebGeolocationPosition::canProvideHeading):
(WebKit::WebGeolocationPosition::heading):
(WebKit::WebGeolocationPosition::canProvideSpeed):
(WebKit::WebGeolocationPosition::speed):
WebGeolocationPosition mirror the attributes of WebCore::GeolocationPosition.

  • UIProcess/API/C/WKGeolocationPosition.cpp:

(WKGeolocationPositionCreate):
(WKGeolocationPositionCreate_b):
Add a new API exposing all the arguments.

  • UIProcess/API/C/WKGeolocationPosition.h:
  • WebProcess/Geolocation/WebGeolocationManager.cpp:

(WebKit::WebGeolocationManager::didChangePosition):

Tools:

Expand WebKitTestRunner and DumpRenderTree to test all the attributes
of GeolocationPosition.

  • DumpRenderTree/TestRunner.cpp:

(setMockGeolocationPositionCallback):

  • DumpRenderTree/TestRunner.h:

(TestRunner):

  • DumpRenderTree/efl/TestRunnerEfl.cpp:

(TestRunner::setMockGeolocationPosition):

  • DumpRenderTree/gtk/TestRunnerGtk.cpp:

(TestRunner::setMockGeolocationPosition):

  • DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::setMockGeolocationPosition):

  • DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::setMockGeolocationPosition):

  • DumpRenderTree/wx/TestRunnerWx.cpp:

(TestRunner::setMockGeolocationPosition):

  • WebKitTestRunner/GeolocationProviderMock.cpp:

(WTR::GeolocationProviderMock::setPosition):

  • WebKitTestRunner/GeolocationProviderMock.h:

(GeolocationProviderMock):

  • WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:

(_platformTypeVariableDeclaration):
Use a proper constructor for the JSValueRef, it is an opaque type, we are not supposed
to build the pointer outself.
This is necessary to support optional JSValueRef properly.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::setMockGeolocationPosition):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setMockGeolocationPosition):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::setMockGeolocationPosition):

  • WebKitTestRunner/TestController.h:

(TestController):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

LayoutTests:

Add a new test for the exposed attributes. It is disabled everywhere else than
Mac because of the missing DRT features.

  • fast/dom/Geolocation/coordinates-interface-attributes-expected.txt: Added.
  • fast/dom/Geolocation/coordinates-interface-attributes.html: Added.
  • platform/chromium/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/qt/TestExpectations:
11:58 AM Changeset in webkit [130415] by rakuco@webkit.org
  • 3 edits in trunk/Tools

Make the Xvfb driver recognize `X' as a valid X server binary.
https://bugs.webkit.org/show_bug.cgi?id=98434

Reviewed by Dirk Pranke.

The X server binary can also be called `X', so account for that
possibility in the _next_free_display regexp.

Additionally, make the regular expression require at least one
space character after the `ps comm' part.

  • Scripts/webkitpy/layout_tests/port/xvfbdriver.py:

(XvfbDriver._next_free_display):

  • Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:

(XvfbDriverTest.test_next_free_display):

11:50 AM Changeset in webkit [130414] by rakuco@webkit.org
  • 2 edits in trunk/Tools

webkitpy: Accept WEBKITOUTPUTDIR in Port._setup_environ_for_server.
https://bugs.webkit.org/show_bug.cgi?id=98436

Reviewed by Dirk Pranke.

The Xvfb driver (ab)uses Port._setup_environ_for_server() to set
the environment for the server process, and the WEBKITOUTPUTDIR
environment variable was not being passed through, causing the
build directory to be wrongfully set to WebKitBuild/ all the time.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.to.setup_environ_for_server):

11:49 AM Changeset in webkit [130413] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

After r130344, OpaqueJSString() creates a empty string which should be a null string
https://bugs.webkit.org/show_bug.cgi?id=98417

Reviewed by Alexey Proskuryakov.

Removed the setting of enclosed string to an empty string from default constructor.
Before changeset r130344, the semantic was the default constructor produced a null
string.

  • API/OpaqueJSString.h:

(OpaqueJSString::OpaqueJSString):

11:40 AM Changeset in webkit [130412] by hclam@chromium.org
  • 6 edits
    11 adds in trunk

[skia] Drawing a subrect of bitmap image is misaligned
https://bugs.webkit.org/show_bug.cgi?id=95121

Reviewed by Stephen White.

Source/WebCore:

When drawing a subrect of BitmapImage and the subrect is not aligned
to integer boundaries, skia expands it to the closest enclosing integer
rectangle. This creates prominent rendering artifacts when an image
is used as background and its sub-regions are invalidated frequently.

This patch fixes the problem by doing alignment to integer boundaries
and clipping for both cases of RESAMPLE_AWESOME and RESAMPLE_LINEAR.

A clip rect is applied to the canvas using original destination
rectangle, while source and destination rectangles are enlarged
appropriately to ensure source rectangle is aligned.

This patch also fixes a closely related problem. In RESAMPLE_AWESOME
resampling mode the previous algorithm applies different approximated
scale factor for each scaled image fragment. This caused the stitched
image to look ugly.

Scale factor is approximated using entire image size, this gives a
more accurate approximation because of greater denominator and a
consistent scale factor across all fragments.

Changes in Skia enable caching of the scaled image and return the
scaled fragment because scale factor is now consistent for all
fragments.

Tests: fast/images/paint-subrect-grid.html

fast/images/paint-subrect.html
fast/images/repaint-subrect-grid.html

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::computeResamplingMode): Use float for width and height.
(WebCore):
(WebCore::areBoundariesIntegerAligned):
(WebCore::computeBitmapDrawRects):
(WebCore::extractScaledImageFragment):
(WebCore::drawResampledBitmap): New algorithm for drawing scaled image fragment.
(WebCore::paintSkBitmap):
(WebCore::Image::drawPattern):
(WebCore::BitmapImage::draw): Use SkRect instead of SkIRect.
(WebCore::BitmapImageSingleFrameSkia::draw):

  • platform/graphics/skia/NativeImageSkia.cpp:

Changing the algorithm for extracting a scaled image fragment.
A fragment is now identified by (scaledImageSize, scaledImageSubset).
(WebCore::NativeImageSkia::hasResizedBitmap):
(WebCore::NativeImageSkia::resizedBitmap):
(WebCore::NativeImageSkia::shouldCacheResampling):
(WebCore::NativeImageSkia::CachedImageInfo::CachedImageInfo):
(WebCore):
(WebCore::NativeImageSkia::CachedImageInfo::isEqual):
(WebCore::NativeImageSkia::CachedImageInfo::set):
(WebCore::NativeImageSkia::CachedImageInfo::rectInSubset):

  • platform/graphics/skia/NativeImageSkia.h:

(NativeImageSkia):
(CachedImageInfo):

LayoutTests:

3 new tests added.

  • fast/images/paint-subrect.html

This test enlarges a 2x1 image in a canvas for easy verification.
2/3 of the image is used as source rectangle to exercise the code path
for partial pixel addressing.

Pixel test result should have 1/3 blue on the left and 2/3 green on the
right with gradient according to interpolation settings.

  • fast/images/paint-subrect-grid.html

Draws a 11x11 image into a canvas in 8 fragments with partial pixels.
Canvas should look just like a single image enlarged.

  • fast/images/repaint-subrect-grid.html

Scale a 31x31 image to 55x55. A blue square moves across the scaled
image such that the image is partially invalidated. After the animation
the image should look the same.

  • fast/images/paint-subrect-expected.txt: Added.
  • fast/images/paint-subrect-grid-expected.txt: Added.
  • fast/images/paint-subrect-grid.html: Added.
  • fast/images/paint-subrect.html: Added.
  • fast/images/repaint-subrect-grid-expected.html: Added.
  • fast/images/repaint-subrect-grid.html: Added.
  • fast/images/resources/grid-large.png: Added.
  • fast/images/resources/grid-small.png: Added.
  • platform/chromium/TestExpectations: Added image failure expectations.
  • platform/chromium/fast/images/paint-subrect-expected.png: Added.
  • platform/chromium/fast/images/paint-subrect-grid-expected.png: Added.
  • platform/chromium/fast/images/repaint-subrect-grid-expected.png: Added.
11:36 AM Changeset in webkit [130411] by rniwa@webkit.org
  • 60 edits in trunk

ReplaceSelectionCommand should merge text nodes
https://bugs.webkit.org/show_bug.cgi?id=98188

Reviewed by Levi Weintraub.

Source/WebCore:

Added mergeTextNodesAroundPosition to ReplaceSelectionCommand to merge text nodes after the replace in
completeHTMLReplacement. Also fixed a bunch of bugs in other classes and functions to make this work.

This behavior change is tested by existing tests.

  • editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::doApply): When splitting a text node, place the insertionPosition
at the end of the first half. Leaving it at the beginning of the second half confuses the rest of the code in
the function. However, the logic to handle the "insignificant" white spaces needs the position at the start of
the second half. So keep this position.

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::doApply): Update visibleStart after inserting a paragraph separator so that
the logic to cleanup the nested div checks the right condition (right beneath it starting with a long comment).
(WebCore::ReplaceSelectionCommand::addSpacesForSmartReplace): Insert a space for smart paste at the appropriate
offset instead of at the end of endNode. Also update the layout before obtaining startDownstream as we may have
modified the DOM by inserting a space for endNode. Finally, a non-breaking space should be treated like a space
isCharacterSmartReplaceExempt for the purpose of smart replace. e.g. if we're inserting "world" after
"hello&nbsp;", we shouldn't be inserting another space between "hello" and "world".
(WebCore::ReplaceSelectionCommand::completeHTMLReplacement):
(WebCore::ReplaceSelectionCommand::mergeTextNodesAroundPosition): Added. Merge text nodes around position, and
adjust position and positionOnlyToBeUpdated accordingly. We need to call updatePositionForNodeRemoval when
positions were before or after the text node.

  • editing/ReplaceSelectionCommand.h:

(ReplaceSelectionCommand):

LayoutTests:

Rebaselined tests.

  • editing/deleting/merge-paragraphs-with-transparent-background-expected.txt:
  • editing/deleting/paste-with-transparent-background-color-expected.txt:
  • editing/execCommand/outdent-selection-expected.txt:
  • editing/execCommand/remove-list-items-expected.txt:
  • editing/inserting/insert-3907422-fix-expected.txt:
  • editing/pasteboard/avoid-copying-body-with-background-expected.txt:
  • editing/pasteboard/block-wrappers-necessary-expected.txt:
  • editing/pasteboard/drag-drop-list-expected.txt:
  • editing/pasteboard/merge-end-5-expected.txt:
  • editing/pasteboard/paste-before-tab-span-expected.txt:
  • editing/pasteboard/paste-into-table-cell-expected.txt:
  • editing/pasteboard/paste-text-001-expected.txt:
  • editing/pasteboard/paste-text-002-expected.txt:
  • editing/pasteboard/paste-text-003-expected.txt:
  • editing/pasteboard/paste-text-010-expected.txt:
  • editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
  • editing/pasteboard/paste-unrendered-select-expected.txt:
  • editing/pasteboard/smart-paste-001-expected.txt:
  • editing/pasteboard/smart-paste-002-expected.txt:
  • editing/pasteboard/smart-paste-003-expected.txt:
  • editing/pasteboard/smart-paste-004-expected.txt:
  • editing/pasteboard/smart-paste-005-expected.txt:
  • editing/pasteboard/smart-paste-006-expected.txt:
  • fast/events/ondragenter-expected.txt:
  • fast/lists/drag-into-marker.html:
  • platform/mac/editing/deleting/delete-block-merge-contents-018-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-019-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-020-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-021-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-022-expected.txt:
  • platform/mac/editing/deleting/merge-no-br-expected.txt:
  • platform/mac/editing/execCommand/find-after-replace-expected.txt:
  • platform/mac/editing/execCommand/paste-1-expected.txt:
  • platform/mac/editing/execCommand/paste-2-expected.txt:
  • platform/mac/editing/pasteboard/4944770-2-expected.txt:
  • platform/mac/editing/pasteboard/5006779-expected.txt:
  • platform/mac/editing/pasteboard/5028447-expected.txt:
  • platform/mac/editing/pasteboard/8145-3-expected.txt:
  • platform/mac/editing/pasteboard/drag-drop-modifies-page-expected.txt:
  • platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
  • platform/mac/editing/pasteboard/merge-end-borders-expected.txt:
  • platform/mac/editing/pasteboard/paste-line-endings-007-expected.txt:
  • platform/mac/editing/pasteboard/paste-line-endings-008-expected.txt:
  • platform/mac/editing/pasteboard/paste-line-endings-009-expected.txt:
  • platform/mac/editing/pasteboard/paste-line-endings-010-expected.txt:
  • platform/mac/editing/pasteboard/paste-match-style-001-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-004-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-005-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-008-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-009-expected.txt:
  • platform/mac/editing/pasteboard/smart-drag-drop-expected.txt:
  • platform/mac/editing/pasteboard/smart-paste-007-expected.txt:
  • platform/mac/editing/pasteboard/smart-paste-008-expected.txt:
  • platform/mac/editing/pasteboard/subframe-dragndrop-1-expected.txt:
  • platform/mac/editing/pasteboard/unrendered-br-expected.txt:
10:51 AM Changeset in webkit [130410] by tony@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed, fix flexbox-baseline.html to test the new behavior after r130409.

  • css3/flexbox/flexbox-baseline.html:
  • platform/chromium-linux/css3/flexbox/flexbox-baseline-expected.png:
  • platform/chromium-linux/css3/flexbox/flexbox-baseline-expected.txt:
10:46 AM Changeset in webkit [130409] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

Fix <input type="month"> tests
https://bugs.webkit.org/show_bug.cgi?id=98426

Reviewed by Ojan Vafai.

The month picker uses flexbox and assumes that it will be aligned with
the last line box. This looks visually correct. I will follow up on
www-style to see what the expected behavior is.

Tests: fast/forms/month-multiple-fields tests cover this.

  • rendering/RenderFlexibleBox.cpp:
  • rendering/RenderFlexibleBox.h:
10:29 AM Changeset in webkit [130408] by tony@chromium.org
  • 6 edits in trunk/LayoutTests

Unreviewed, fixing expected results for a test that needs a new baseline.

  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
10:24 AM Changeset in webkit [130407] by commit-queue@webkit.org
  • 6 edits
    2 deletes in trunk

Unreviewed, rolling out r130396.
http://trac.webkit.org/changeset/130396
https://bugs.webkit.org/show_bug.cgi?id=98421

This patch is causing crashes on 4 tests on Lion Debug and
Mountain Lion Debug (Requested by jernoble on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-04

Source/WebCore:

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::calculateCompositedBounds):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):

  • rendering/RenderLayerCompositor.h:
  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):

  • testing/InternalSettings.h:

(Backup):

LayoutTests:

  • compositing/layer-creation/fixed-position-absolute-descendant-expected.txt: Removed.
  • compositing/layer-creation/fixed-position-absolute-descendant.html: Removed.
10:21 AM Changeset in webkit [130406] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Fix r140403 by skipping the right test.

  • platform/efl/TestExpectations:
9:47 AM Changeset in webkit [130405] by tony@chromium.org
  • 10 edits
    3 adds in trunk

inline-flex baseline is sometimes wrong
https://bugs.webkit.org/show_bug.cgi?id=96188

Reviewed by Ojan Vafai.

Source/WebCore:

Implement the necessary methods to get the proper baseline alignment of flexbox.
We were falling back to the inline-block behavior.

Test: css3/flexbox/flexbox-baseline.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::RenderFlexibleBox):
(WebCore::RenderFlexibleBox::baselinePosition): Used to get the baseline of the box.
Mostly just the first line box baseline.
(WebCore):
(WebCore::RenderFlexibleBox::lastLineBoxBaseline): This is used for getting the baseline when in an inline-block.
We actually don't want the last line, but the flexbox's baseline.
(WebCore::RenderFlexibleBox::firstLineBoxBaseline): Compute the baseline according to the rules in the spec.
(WebCore::RenderFlexibleBox::repositionLogicalHeightDependentFlexItems): Keep track of the number of children on the
first line so we don't have to re-compute this when getting the baseline.
(WebCore::RenderFlexibleBox::crossAxisExtentForChild): Make const.
(WebCore::RenderFlexibleBox::mainAxisExtentForChild): Make const.
(WebCore::RenderFlexibleBox::hasAutoMarginsInCrossAxis): Make const.

  • rendering/RenderFlexibleBox.h: Add a size_t to keep track of how many children are in the first line.

LayoutTests:

Add a new pixel test and mark the test as failing so we can get pixel results from the bots.

  • css3/flexbox/flexbox-baseline.html: Added.
  • platform/chromium-linux/css3/flexbox/flexbox-baseline-expected.png: Added.
  • platform/chromium-linux/css3/flexbox/flexbox-baseline-expected.txt: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
9:45 AM Changeset in webkit [130404] by msaboff@apple.com
  • 3 edits in trunk/Source/WTF

String::remove will convert an 8 bit string to a 16 bit string
https://bugs.webkit.org/show_bug.cgi?id=98299

Reviewed by Benjamin Poulain.

Added an 8 bit path to remove(). Added a private templated helper removeInternal.

  • wtf/text/WTFString.cpp:

(WTF::String::removeInternal):
(WTF::String::remove):

  • wtf/text/WTFString.h:

(String):

9:39 AM Changeset in webkit [130403] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Temporarily skip fast/xsl/xslt-missing-namespace-in-xslt.html.

As bug 91009 shows, libxml 2.8.0 makes us produce a different test
result. Unskip the test for now until we add that version to
jhbuild.

  • platform/efl/TestExpectations:
9:37 AM Changeset in webkit [130402] by wangxianzhu@chromium.org
  • 3 edits
    3 adds in trunk

[Chromium] Should set unitsPerEm in SimpleFontDataSkia.cpp
https://bugs.webkit.org/show_bug.cgi?id=98100

Reviewed by Stephen White.

Source/WebCore:

At least on chromium-linux and chromium-android, unitsPerEm was not set
according to the information in the font, causing at least problems in
OpenTypeVerticalData when calculating vertical advance.

Test: fast/writing-mode/vertical-font-vmtx-units-per-em.html

  • platform/graphics/skia/SimpleFontDataSkia.cpp:

(WebCore::SimpleFontData::platformInit):

LayoutTests:

  • fast/writing-mode/resources/DroidSansFallback-reduced.ttf: Added.
  • fast/writing-mode/vertical-font-vmtx-units-per-em-expected.txt: Added.
  • fast/writing-mode/vertical-font-vmtx-units-per-em.html: Added.
9:24 AM Changeset in webkit [130401] by rakuco@webkit.org
  • 2 edits
    1 delete in trunk/LayoutTests

[EFL] Revert some wrong baselines added in r130387.

Thanks to Christophe Dumez and Mikhail Pozdnyakov for the help.

  • platform/efl/compositing/visibility/visibility-simple-video-layer-expected.txt: Removed.
  • platform/efl/fullscreen/parent-flow-inline-with-block-child-expected.txt:
9:16 AM Changeset in webkit [130400] by Simon Fraser
  • 50 edits in trunk/Source

Standardize on "flush" terminology for compositing layer flushing/syncing
https://bugs.webkit.org/show_bug.cgi?id=98321

Reviewed by Simon Fraser.

Rename compositing-related methods that refer to "syncing" to instead
refer to "flushing".

Source/WebCore:

  • WebCore.exp.in:
  • loader/EmptyClients.h:

(WebCore::EmptyChromeClient::scheduleCompositingLayerFlush):

  • page/ChromeClient.h:

(ChromeClient):

  • page/FrameView.cpp:

(WebCore::FrameView::flushCompositingStateForThisFrame):
(WebCore::FrameView::flushCompositingStateIncludingSubframes):
(WebCore::FrameView::paintContents):

  • page/FrameView.h:

(FrameView):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::scheduleLayerFlush):
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):

Source/WebKit/blackberry:

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::scheduleCompositingLayerFlush):

  • WebCoreSupport/ChromeClientBlackBerry.h:

(ChromeClientBlackBerry):

Source/WebKit/chromium:

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::scheduleCompositingLayerFlush):

  • src/ChromeClientImpl.h:

(ChromeClientImpl):

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::scheduleCompositingLayerFlush):

  • WebCoreSupport/ChromeClientEfl.h:

(ChromeClientEfl):

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::scheduleCompositingLayerFlush):

  • WebCoreSupport/ChromeClientGtk.h:

(ChromeClient):

Source/WebKit/mac:

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::scheduleCompositingLayerFlush):

  • WebView/WebView.mm:

(-[WebView _flushCompositingChanges]):
(LayerFlushController::flushLayers):
(-[WebView _scheduleCompositingLayerFlush]):

  • WebView/WebViewInternal.h:

Source/WebKit/qt:

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::scheduleCompositingLayerFlush):

  • WebCoreSupport/ChromeClientQt.h:

(ChromeClientQt):

  • WebCoreSupport/PageClientQt.cpp:

(WebCore::PageClientQGraphicsWidget::syncLayers):

Source/WebKit/win:

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::scheduleCompositingLayerFlush):

  • WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

  • WebView.cpp:

(WebView::flushPendingGraphicsLayerChanges):

Source/WebKit/wince:

  • WebCoreSupport/ChromeClientWinCE.cpp:

(WebKit::ChromeClientWinCE::scheduleCompositingLayerFlush):

  • WebCoreSupport/ChromeClientWinCE.h:

(ChromeClientWinCE):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::scheduleCompositingLayerFlush):

  • WebProcess/WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

  • WebProcess/WebPage/DrawingArea.h:

(DrawingArea):

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::scheduleCompositingLayerFlush):

  • WebProcess/WebPage/DrawingAreaImpl.h:

(DrawingAreaImpl):

  • WebProcess/WebPage/ca/LayerTreeHostCA.cpp:

(WebKit::LayerTreeHostCA::flushPendingLayerChanges):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::scheduleCompositingLayerFlush):
(WebKit::TiledCoreAnimationDrawingArea::didInstallPageOverlay):
(WebKit::TiledCoreAnimationDrawingArea::didUninstallPageOverlay):
(WebKit::TiledCoreAnimationDrawingArea::setPageOverlayNeedsDisplay):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):

9:13 AM Changeset in webkit [130399] by Csaba Osztrogonác
  • 3 edits in trunk/Source/JavaScriptCore

[Qt] Add missing LLInt dependencies to the build system
https://bugs.webkit.org/show_bug.cgi?id=98394

Reviewed by Geoffrey Garen.

  • DerivedSources.pri:
  • LLIntOffsetsExtractor.pro:
9:12 AM Changeset in webkit [130398] by commit-queue@webkit.org
  • 16 edits
    4 adds in trunk

Web Inspector: expose object internal properties such as PrimitiveValue or BoundThis
https://bugs.webkit.org/show_bug.cgi?id=94397

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-10-04
Reviewed by Yury Semikhatsky.

Source/WebCore:

Internal property access is built from Injected Script to V8 debug API. JSC binding
has a stub imlpementation. Protocol is updated to explicitly reflect internal properties.

Test: inspector-protocol/runtime-getProperties.html

  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::getInternalProperties):
(WebCore):

  • bindings/v8/DebuggerScript.js:
  • bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::getInternalProperties):
(WebCore):

  • bindings/v8/ScriptDebugServer.h:

(ScriptDebugServer):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::getInternalPropertiesCallback):
(WebCore):

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::getInternalProperties):
(WebCore):

  • inspector/InjectedScript.h:

(InjectedScript):

  • inspector/InjectedScriptHost.idl:
  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::getProperties):

  • inspector/InspectorRuntimeAgent.h:

(InspectorRuntimeAgent):

LayoutTests:

A test is added to support new feature. Old test is updated because line number changed.

  • inspector-protocol/runtime-getProperties-expected.txt: Added.
  • inspector-protocol/runtime-getProperties.html: Added.
  • inspector/console/command-line-api-expected.txt:
9:08 AM Changeset in webkit [130397] by kpiascik@rim.com
  • 2 edits in trunk/Source/WebKit

[BlackBerry] Update how we compile inspector front-end javascript.
https://bugs.webkit.org/show_bug.cgi?id=98413

Reviewed by Rob Buis.

No longer cat all JavaScript together, instead use the lazy init and
only append our custom changes script to the end of inspectorBB.html.

  • PlatformBlackBerry.cmake:
8:57 AM Changeset in webkit [130396] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Fixed position visibility check does not consider descendants
https://bugs.webkit.org/show_bug.cgi?id=98144

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-10-04
Reviewed by Simon Fraser.

Source/WebCore:

The check against creating composition layers for invisible fixed positioned
elements is too aggressive in that it does not consider descendants of the
fixed positioned element that may be visible even though the element itself is
out of view.

Fix the problem by calculating the true composited bounds of the fixed
element instead of just using the size of the fixed layer. Because calculating
the true bounds may be expensive, it is only done if the fixed layer itself is
invisible.

Test: compositing/layer-creation/fixed-position-absolute-descendant.html

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::calculateCompositedBounds):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):

  • rendering/RenderLayerCompositor.h:

LayoutTests:

Added a test for the fixed position layer visibility check.

  • compositing/layer-creation/fixed-position-absolute-descendant-expected.txt: Added.
  • compositing/layer-creation/fixed-position-absolute-descendant.html: Added.
8:52 AM Changeset in webkit [130395] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk

[EFL][WK2] Add setting to allow file access from file:// URLs
https://bugs.webkit.org/show_bug.cgi?id=98121

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-04
Reviewed by Laszlo Gombos.

Source/WebKit2:

Add Ewk setting to set / query permission to access
files from file:// URLs.

  • UIProcess/API/efl/ewk_settings.cpp:

(ewk_settings_file_access_from_file_urls_allowed_set):
(ewk_settings_file_access_from_file_urls_allowed_get):

  • UIProcess/API/efl/ewk_settings.h:
  • UIProcess/API/efl/tests/resources/local_file_access.html: Added.
  • UIProcess/API/efl/tests/test_ewk2_settings.cpp:

(TEST_F): Add unit tests for new ewk setting.

Tools:

Allow file access from file:// URLs by default in Minibrowser
to facilitate testing.

  • MiniBrowser/efl/main.c:

(browserCreate):

8:47 AM Changeset in webkit [130394] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r130385. Skip some failing test.

  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt/http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect-expected.txt:
8:32 AM Changeset in webkit [130393] by vsevik@chromium.org
  • 11 edits in trunk

Web Inspector: When uiSourceCode content has diverged from VM script, call frames should be shown in temporary script based uiSourceCodes.
https://bugs.webkit.org/show_bug.cgi?id=98385

Reviewed by Pavel Feldman.

Source/WebCore:

When javaScriptSource diverges from VM, ResourceScriptMapping now switches debugging
to temporary VM scripts based uiSourceCode with isDivergedReplacement property set.
Added hasDivergedFromVM and isDivergingFromVM properties to JavaScriptSource.
JavaScriptSourceFrame and ScriptSnippetsModel are updated to process breakpoint changes correctly.

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype.restoreBreakpoints):
(WebInspector.BreakpointManager.prototype._uiSourceCodeRemoved):

  • inspector/front-end/JavaScriptSource.js:

(WebInspector.JavaScriptSource.prototype.workingCopyCommitted):
(WebInspector.JavaScriptSource.prototype.workingCopyChanged):
(WebInspector.JavaScriptSource.prototype.fireHasDivergedFromVMChanged):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.commitEditing):
(WebInspector.JavaScriptSourceFrame.prototype._hasDivergedFromVM):
(WebInspector.JavaScriptSourceFrame.prototype.onTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype._getBreakpointDecorations):
(WebInspector.JavaScriptSourceFrame.prototype._muteBreakpointsWhileEditing):
(WebInspector.JavaScriptSourceFrame.prototype._didEditContent):
(WebInspector.JavaScriptSourceFrame.prototype._restoreBreakpointsAfterEditing):
(WebInspector.JavaScriptSourceFrame.prototype._addBreakpointDecoration):

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype._hasDivergedFromVMChanged):
(WebInspector.ResourceScriptMapping.prototype._bindUISourceCodeToScripts):
(WebInspector.ResourceScriptMapping.prototype._getOrCreateTemporaryUISourceCode):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
(WebInspector.ScriptSnippetModel.prototype._restoreBreakpoints):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._revealExecutionLine):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.formatted):

LayoutTests:

  • inspector/debugger/dynamic-script-tag-expected.txt:
  • inspector/debugger/resource-script-mapping-expected.txt:
8:31 AM Changeset in webkit [130392] by tonikitoo@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Exiting fullscreen does not set the correct scroll position (Part II)
https://bugs.webkit.org/show_bug.cgi?id=97917
PR #212920

Reviewed by Yong Li.
Patch by Antonio Gomes <agomes@rim.com>
Internally reviewed by Jacky Jiang.

Inform the client of transform change so that we avoid
getting stuck on overscroll.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setViewportSize):

7:56 AM Changeset in webkit [130391] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Scripts panel should not automatically switch to snippet evaluation when previously evaluated snippet is edited.
https://bugs.webkit.org/show_bug.cgi?id=98402

Reviewed by Pavel Feldman.

Scripts panel does not automatically switch to snippet evaluation when
one edits previously evaluated snippet.

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._revealExecutionLine):

7:45 AM Changeset in webkit [130390] by commit-queue@webkit.org
  • 5 edits in trunk

[EFL] Run unit tests with Xvfb
https://bugs.webkit.org/show_bug.cgi?id=98389

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-04
Reviewed by Laszlo Gombos.

Source/WebKit2:

  • UIProcess/API/efl/ewk_main.cpp:

(ewk_init): Call ecore_evas_shutdown() instead of
edje_shutdown() when ecore_x_init() fails.
(ewk_shutdown): Remove extra call to edje_shutdown().

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F): Temporarily disable fullscreen unit tests
until we get them working with Xvfb.

Tools:

Run EFL unit tests with Xvfb, similarly to GTK port.

  • Scripts/run-efl-tests:
6:42 AM Changeset in webkit [130389] by kbalazs@webkit.org
  • 9 edits in trunk

.: Don't allow to disable compositing in forced compositing mode
https://bugs.webkit.org/show_bug.cgi?id=98048

Reviewed by Jocelyn Turcotte.

Export Settings::setAcceleratedCompositingEnabled because it has been deinlined.

  • Source/autotools/symbols.filter:

Source/WebCore: Don't allow to disable compositing in forced compositing mode
https://bugs.webkit.org/show_bug.cgi?id=98048

Reviewed by Jocelyn Turcotte.

Make forced compositing mode imply accelerated compositing. This will
avoid unexpected situations for platforms that don't want to support
the non-accelerated rendering path.

Covered by existing tests.

  • WebCore.exp.in: Export Settings::setAcceleratedCompositingEnabled

because it has been deinlined.

  • page/Settings.cpp:

(WebCore::Settings::setAcceleratedCompositingEnabled):
(WebCore::Settings::setForceCompositingMode):
(WebCore):

  • page/Settings.h:

(Settings):
(WebCore::Settings::forceCompositingMode): Make it const as a side fix.

Source/WebKit2: Don't allow compositing to be disabled in forced compositing mode
https://bugs.webkit.org/show_bug.cgi?id=98048

Reviewed by Jocelyn Turcotte.

Export Settings::setAcceleratedCompositingEnabled because it has been deinlined.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
6:20 AM Changeset in webkit [130388] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r130385. Skip a failing test.
https://bugs.webkit.org/show_bug.cgi?id=62741

  • platform/qt/TestExpectations:
5:31 AM Changeset in webkit [130387] by rakuco@webkit.org
  • 46 edits
    8 adds in trunk/LayoutTests

[EFL] Pixel test rebaselines to enable pixel testing on the bots, part 6.

  • platform/efl/compositing/reflections/animation-inside-reflection-expected.png:
  • platform/efl/compositing/visibility/visibility-image-layers-expected.png: Added.
  • platform/efl/compositing/visibility/visibility-simple-video-layer-expected.png: Added.
  • platform/efl/compositing/visibility/visibility-simple-video-layer-expected.txt: Added.
  • platform/efl/fast/forms/datalist/update-range-with-datalist-expected.png: Added.
  • platform/efl/fast/selectors/unqualified-hover-strict-expected.png:
  • platform/efl/fast/selectors/unqualified-hover-strict-expected.txt:
  • platform/efl/fast/xsl/xslt-missing-namespace-in-xslt-expected.png:
  • platform/efl/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt:
  • platform/efl/fullscreen/full-screen-stacking-context-expected.png:
  • platform/efl/fullscreen/full-screen-zIndex-after-expected.png:
  • platform/efl/fullscreen/parent-flow-inline-with-block-child-expected.png:
  • platform/efl/fullscreen/parent-flow-inline-with-block-child-expected.txt:
  • platform/efl/http/tests/local/file-url-sent-as-referer-expected.png:
  • platform/efl/http/tests/misc/frame-access-during-load-expected.png:
  • platform/efl/http/tests/misc/iframe404-expected.png:
  • platform/efl/http/tests/misc/slow-loading-image-in-pattern-expected.png:
  • platform/efl/http/tests/uri/css-href-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.png:
  • platform/efl/svg/filters/big-sized-filter-expected.png:
  • platform/efl/svg/filters/feColorMatrix-saturate-expected.png: Added.
  • platform/efl/svg/filters/feDropShadow-expected.png: Added.
  • platform/efl/svg/filters/feGaussianBlur-expected.png:
  • platform/efl/svg/filters/feImage-reference-svg-primitive-expected.png: Added.
  • platform/efl/svg/filters/filterRes1-expected.png:
  • platform/efl/svg/filters/filterRes3-expected.png:
  • platform/efl/svg/filters/shadow-on-rect-with-filter-expected.png:
  • platform/efl/svg/repaint/inner-svg-change-viewBox-contract-expected.png: Added.
5:24 AM Changeset in webkit [130386] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[GTK] Enable inspector by default in GtkLauncher/MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=98333

Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2012-10-04
Reviewed by Xan Lopez.

Both MiniBrowser and GtkLauncher are tools for testing, so in
the end every time we want to test the inspector we have to
manually enable enable the “developer extras” setting when using
them. It make sense to have this setting enabled by default.

  • GtkLauncher/main.c:

(main):

  • MiniBrowser/gtk/main.c:

(main):

5:23 AM Changeset in webkit [130385] by kadam@inf.u-szeged.hu
  • 5 edits
    7 adds in trunk/LayoutTests

[Qt] Reviewing old bugs in Qt TestExpectations. Unskip now passing test.

  • platform/qt-5.0-wk1/TestExpectations:
  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/qt/editing/pasteboard/smart-paste-008-expected.txt:
  • platform/qt/http/tests/w3c/webperf/approved/navigation-timing/html/test_performance_attributes_exist_in_object-expected.txt: Added.
  • platform/qt/http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect-expected.txt: Added.
5:18 AM Changeset in webkit [130384] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Mark perf/show-hide-table-rows.html as flaky.

  • platform/chromium/TestExpectations:
4:06 AM Changeset in webkit [130383] by commit-queue@webkit.org
  • 17 edits in trunk

Change RTCPeerConnection GetStats to use Date timestamp format
https://bugs.webkit.org/show_bug.cgi?id=98263

Patch by Harald Alvestrand <hta@google.com> on 2012-10-04
Reviewed by Yury Semikhatsky.

Source/Platform:

  • chromium/public/WebRTCStatsResponse.h:

(WebRTCStatsResponse):

Source/WebCore:

Tested by extension to RTCPeerConnection-stats test.

  • Modules/mediastream/RTCStatsElement.cpp:

(WebCore::RTCStatsElement::create):
(WebCore::RTCStatsElement::RTCStatsElement):

  • Modules/mediastream/RTCStatsElement.h: long -> double

(RTCStatsElement):
(WebCore::RTCStatsElement::timestamp):

  • Modules/mediastream/RTCStatsElement.idl: long -> Date
  • Modules/mediastream/RTCStatsReport.cpp:

(WebCore::RTCStatsReport::addElement):

  • Modules/mediastream/RTCStatsReport.h:

(RTCStatsReport):

  • Modules/mediastream/RTCStatsResponse.cpp:

(WebCore::RTCStatsResponse::addElement):

  • Modules/mediastream/RTCStatsResponse.h:

(RTCStatsResponse):

  • platform/chromium/support/WebRTCStatsResponse.cpp:

(WebKit::WebRTCStatsResponse::addElement):

  • platform/mediastream/RTCStatsResponseBase.h:

(RTCStatsResponseBase):

Tools:

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(MockWebRTCPeerConnectionHandler::getStats):

LayoutTests:

  • fast/mediastream/RTCPeerConnection-stats-expected.txt:
  • fast/mediastream/RTCPeerConnection-stats.html:
3:43 AM Changeset in webkit [130382] by jocelyn.turcotte@digia.com
  • 4 edits in trunk/Source/WebKit2

[Qt] Fix the tst_QQuickWebView::scrollRequest auto test
https://bugs.webkit.org/show_bug.cgi?id=98045

Reviewed by Simon Hausmann.

Relying on QQuickWebViewPrivate::setNeedsDisplay can cause a false positive
emission of the loadVisuallyCommitted signal since this method is also
called when a layer is deleted or when the root layer changes.

Move the signal emission to QQuickWebViewPrivate::didRenderFrame which
is called only after a DidRenderFrame message has been received from the
web process.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::setNeedsDisplay):
(QQuickWebViewPrivate::didRenderFrame):

  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

  • UIProcess/qt/QtPageClient.cpp:

(WebKit::QtPageClient::didRenderFrame):

3:18 AM Changeset in webkit [130381] by dpranke@chromium.org
  • 4 edits in trunk/Tools

[NRWT] --skipped option is ignored when --test-list is used
https://bugs.webkit.org/show_bug.cgi?id=98260

Reviewed by Ojan Vafai.

Adds a --skipped=always flag that will skip any tests listed in
TestExpectations even if they're listed explicitly on the
command line.

This is most useful if you are using --test-list to specify a
long list of files but you still want to skip some of them
depending on what's in TestExpectations.

  • Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:

(LayoutTestFinder.skip_tests):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_skipped_flag):

3:08 AM Changeset in webkit [130380] by commit-queue@webkit.org
  • 17 edits in trunk

Unreviewed, rolling out r130377.
http://trac.webkit.org/changeset/130377
https://bugs.webkit.org/show_bug.cgi?id=98392

Chromium Win compilation is broken (Requested by yurys on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-04

Source/Platform:

  • chromium/public/WebRTCStatsResponse.h:

(WebRTCStatsResponse):

Source/WebCore:

  • Modules/mediastream/RTCStatsElement.cpp:

(WebCore::RTCStatsElement::create):
(WebCore::RTCStatsElement::RTCStatsElement):

  • Modules/mediastream/RTCStatsElement.h:

(RTCStatsElement):
(WebCore::RTCStatsElement::timestamp):

  • Modules/mediastream/RTCStatsElement.idl:
  • Modules/mediastream/RTCStatsReport.cpp:

(WebCore::RTCStatsReport::addElement):

  • Modules/mediastream/RTCStatsReport.h:

(RTCStatsReport):

  • Modules/mediastream/RTCStatsResponse.cpp:

(WebCore::RTCStatsResponse::addElement):

  • Modules/mediastream/RTCStatsResponse.h:

(RTCStatsResponse):

  • platform/chromium/support/WebRTCStatsResponse.cpp:

(WebKit::WebRTCStatsResponse::addElement):

  • platform/mediastream/RTCStatsResponseBase.h:

(RTCStatsResponseBase):

Tools:

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(MockWebRTCPeerConnectionHandler::getStats):

LayoutTests:

  • fast/mediastream/RTCPeerConnection-stats-expected.txt:
  • fast/mediastream/RTCPeerConnection-stats.html:
2:51 AM Changeset in webkit [130379] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

Some picker test for input[type=date] are failing
https://bugs.webkit.org/show_bug.cgi?id=98390

  • platform/chromium/TestExpectations:
2:24 AM Changeset in webkit [130378] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Fix an error in TestExpectations.

  • platform/chromium/TestExpectations:
2:14 AM Changeset in webkit [130377] by commit-queue@webkit.org
  • 17 edits in trunk

Change RTCPeerConnection GetStats to use Date timestamp format
https://bugs.webkit.org/show_bug.cgi?id=98263

Patch by Harald Alvestrand <hta@google.com> on 2012-10-04
Reviewed by Adam Barth.

Source/Platform:

  • chromium/public/WebRTCStatsResponse.h:

(WebRTCStatsResponse):

Source/WebCore:

Tested by extension to RTCPeerConnection-stats test.

  • Modules/mediastream/RTCStatsElement.cpp:

(WebCore::RTCStatsElement::create):
(WebCore::RTCStatsElement::RTCStatsElement):

  • Modules/mediastream/RTCStatsElement.h: long -> double

(RTCStatsElement):
(WebCore::RTCStatsElement::timestamp):

  • Modules/mediastream/RTCStatsElement.idl: long -> Date
  • Modules/mediastream/RTCStatsReport.cpp:

(WebCore::RTCStatsReport::addElement):

  • Modules/mediastream/RTCStatsReport.h:

(RTCStatsReport):

  • Modules/mediastream/RTCStatsResponse.cpp:

(WebCore::RTCStatsResponse::addElement):

  • Modules/mediastream/RTCStatsResponse.h:

(RTCStatsResponse):

  • platform/chromium/support/WebRTCStatsResponse.cpp:

(WebKit::WebRTCStatsResponse::addElement):

  • platform/mediastream/RTCStatsResponseBase.h:

(RTCStatsResponseBase):

Tools:

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(MockWebRTCPeerConnectionHandler::getStats):

LayoutTests:

  • fast/mediastream/RTCPeerConnection-stats-expected.txt:
  • fast/mediastream/RTCPeerConnection-stats.html:
2:01 AM Changeset in webkit [130376] by tkent@chromium.org
  • 2 edits
    17 deletes in trunk/LayoutTests

Update tests for input[type=date] with the multiple fields UI
https://bugs.webkit.org/show_bug.cgi?id=98386

Reviewed by Hajime Morita.

Remove some tests for input[type=date. They depends on the old UI, which
we don't use any more.
Mark some tests fail. We need to update their results later.

  • fast/forms/date/date-appearance.html: Removed.
  • fast/forms/date/date-fixed-placeholder-expected.txt: Removed.
  • fast/forms/date/date-fixed-placeholder.html: Removed.
  • fast/forms/date/date-input-visible-strings-expected.txt: Removed.
  • fast/forms/date/date-input-visible-strings.html: Removed.
  • fast/forms/date/input-date-commit-valid-only-expected.txt: Removed.
  • fast/forms/date/input-date-commit-valid-only.html: Removed.
  • platform/chromium-linux/fast/forms/date/date-appearance-expected.png: Removed.
  • platform/chromium-linux/fast/forms/date/date-appearance-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/date/date-input-visible-strings-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-expected.png: Removed.
  • platform/chromium-mac/fast/forms/date/date-appearance-expected.png: Removed.
  • platform/chromium-mac/fast/forms/date/date-appearance-expected.txt: Removed.
  • platform/chromium-win/fast/forms/date/date-appearance-expected.png: Removed.
  • platform/chromium-win/fast/forms/date/date-appearance-expected.txt: Removed.
  • platform/chromium-win/fast/forms/date/date-input-visible-strings-expected.txt: Removed.
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/forms/date/date-input-visible-strings-expected.txt: Removed.
1:59 AM Changeset in webkit [130375] by tkent@chromium.org
  • 5 edits in trunk/Source

[Chromium] Enable the multiple fields UI for input[type=date]
https://bugs.webkit.org/show_bug.cgi?id=98351

Reviewed by Hajime Morita.

Source/WebCore:

Touch files related to ENABLE_INPUT_TYPE_DATE_LEGACY_UI to avoid build
issues.

No new tests. Many tests will be landed shortly.

  • html/DateInputType.cpp:
  • html/DateInputType.h:

Source/WebKit/chromium:

  • features.gypi:

Disable ENABLE_INPUT_TYPE_DATE_LEGACY_UI.

1:58 AM Changeset in webkit [130374] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] webintents/web-intents-failure.html is failing
https://bugs.webkit.org/show_bug.cgi?id=98349

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-04
Reviewed by Gyuyoung Kim.

After r130344, OpaqueJSString().string() returns
an empty string instead of a null one. Therefore,
we need to update the check in
DumpRenderTreeSupportEfl::sendWebIntentResponse().

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::sendWebIntentResponse):

1:50 AM Changeset in webkit [130373] by commit-queue@webkit.org
  • 11 edits in trunk/Source

Regression(r130363): Broke unit tests
https://bugs.webkit.org/show_bug.cgi?id=98341

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-04
Reviewed by Gyuyoung Kim.

Source/WebKit/efl:

Fix WebKitEFL unit tests to use X11 as
well.

  • tests/UnitTestUtils/EWKTestBase.cpp:

(EWKUnitTests::EWKTestBase::SetUp):

  • tests/UnitTestUtils/EWKTestEnvironment.h:

(EWKTestEnvironment):

  • tests/UnitTestUtils/EWKTestView.cpp:

(EWKUnitTests::EWKTestView::init):

  • tests/UnitTestUtils/EWKTestView.h:

(EWKTestView):

Source/WebKit2:

Fix WebKit2 EFL to use X11 as well.

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:

(EWK2UnitTest::EWK2UnitTestBase::SetUp):

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.cpp:

(EWK2UnitTest::EWK2UnitTestEnvironment::EWK2UnitTestEnvironment):

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h:

(EWK2UnitTestEnvironment):

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestMain.cpp:

(main):

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(checkFullScreenProperty):

1:46 AM Changeset in webkit [130372] by rakuco@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, remove unused $legacyWebKitBlobBuilderSupport variable after r130343.

  • Scripts/webkitperl/FeatureList.pm:
1:09 AM Changeset in webkit [130371] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] css2.1/20110323/text-indent-intrinsic-00* fail
https://bugs.webkit.org/show_bug.cgi?id=91772

Patch by Tullio Lucena <tullio.lucena@openbossa.org> on 2012-10-04
Reviewed by Yuta Kitamura.

Unskip some tests that are passing.

  • platform/qt/TestExpectations:
12:59 AM Changeset in webkit [130370] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding proper bug modifiers for accessibility failures that don't yet have one.

  • platform/gtk/TestExpectations:
12:49 AM Changeset in webkit [130369] by tkent@chromium.org
  • 15 edits in trunk/Source

Add code for input[type=date] with the multiple fields UI
https://bugs.webkit.org/show_bug.cgi?id=98340

Reviewed by Hajime Morita.

Source/WebCore:

The new code is available if !ENABLE(INPUT_TYPE_DATE_LEGACY_UI). At this
moment, there are no platforms enabling the new code. We're going to
enable it soon on desktop Chromium, and add tests. Then we're going to
remove the code for ENABLE(INPUT_TYPE_DATE_LEGACY_UI).

ENABLE(INPUT_TYPE_DATE_LEGACY_UI) means the current UI; input[type=date]
is represetnted as a kind of text field, and it has code to invoke a
calendar picker.
ENABLE(CALENDAR_PICKER) was used wrongly. It meant calendar picker
support + text field UI of input[type=date]. Now it means only calendar
picker support.

  • html/DateInputType.h:

(WebCore): If ENABLE(INPUT_MULTIPLE_FIELDS_UI) &&
!ENABLE(INPUT_TYPE_DATE_LEGACY_UI), change the base class to the class
for multiple fields UI.
(DateInputType): Wrap the code for text fields behavior and calendar
picker UI with ENABLE(INPUT_TYPE_DATE_LEGACY_UI). Add functions for
ENABLE(INPUT_MULTIPLE_FIELDS_UI)

  • html/DateInputType.cpp:

(WebCore::DateInputType::DateInputType):
Change the flag name; CALENDAR_PICKER -> INPUT_TYPE_DATE_LEGACY_UI
(WebCore): ditto.
(WebCore::DateInputType::formatDateTimeFieldsState):
A callback for multiple fields UI. This constructs a string value from
each of values of multiple fields.
Note that we don't need to do +1 to month().
(WebCore::DateInputType::setupLayoutParameters):
A callback for multiple fields UI. Passes information to build UI.

  • html/BaseMultipleFieldsDateAndTimeInputType.h:

(BaseMultipleFieldsDateAndTimeInputType):
Add m_pickerIndicatorIsAlwaysVisible member, wrap some members with flags.

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::BaseMultipleFieldsDateAndTimeInputType):
Initialize m_pickerIndicatorIsAlwaysVisible.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree):
If a type supports calendar picker, we should always show the picker
indicator. We introduce m_pickerIndicatorIsAlwaysVisible flag, and ask
RenderTheme for support status of each of types.
Add a local variable 'document' to avoid multiple element()->document().
(WebCore::BaseMultipleFieldsDateAndTimeInputType::updatePickerIndicatorVisibility):

  • If m_pickerIndicatorIsAlwaysVisible, don't hide the picker indicator element.
  • Wrap the code with appropriate flags.
  • rendering/RenderTheme.h:

(WebCore::RenderTheme::supportsCalendarPicker): Added.

  • rendering/RenderThemeChromiumMac.h: Override supportsCalendarPicker.
  • rendering/RenderThemeChromiumMac.mm:

(WebCore::RenderThemeChromiumMac::supportsCalendarPicker):
Added. Delegate to RenderThemeChromiumCommon.

  • rendering/RenderThemeChromiumSkia.h: Override supportsCalendarPicker.
  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::supportsCalendarPicker):
Added. Delegate to RenderThemeChromiumCommon.

  • rendering/RenderThemeChromiumCommon.h:

(RenderThemeChromiumCommon): Declare supportsCalendarPicker.

  • rendering/RenderThemeChromiumCommon.cpp:

(WebCore::RenderThemeChromiumCommon::supportsCalendarPicker):
Returns true if the type is "date."

  • html/DateTimeFieldsState.h:

(DateTimeFieldsState): Add a comment for the m_month field.

Source/WebKit/chromium:

  • features.gypi: Add ENABLE_INPUT_TYPE_DATE_LEGACY_UI=1 for non-Android.
12:27 AM Changeset in webkit [130368] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

Removed duplicate entries introduced by r130355

  • platform/chromium/TestExpectations:
12:12 AM Changeset in webkit [130367] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening, skip new crashing tests to paint the bot green.

  • platform/qt-5.0-wk2/TestExpectations:

Oct 3, 2012:

11:29 PM Changeset in webkit [130366] by pdr@google.com
  • 4 edits
    1 add in trunk

Force GC between PageLoad tests.
https://bugs.webkit.org/show_bug.cgi?id=98203

Reviewed by Ryosuke Niwa.

Previously, our PageLoad PerfTests had multi-modal distributions,
typically with a small cluster at 1-2x the median. This turned out
to be caused by not garbage collecting between tests!

This patch adds a new file, force-gc.html, and loads this file between
PageLoad tests to force a GC. I manually verified that this cleans up
our perf test outliers.

PerformanceTests:

  • resources/force-gc.html: Added.

Tools:

  • Scripts/webkitpy/performance_tests/perftest.py:

(PageLoadingPerfTest.init):
(PageLoadingPerfTest):
(PageLoadingPerfTest.run_single):

This function now loads two pages: one to force a gc and
then the test to run.

  • Scripts/webkitpy/performance_tests/perftest_unittest.py:

Modified several existing tests to show that the force-gc file
is loaded.

(MockPort):
(MockPort.init):
(MockPort.perf_tests_dir):
(TestPageLoadingPerfTest.MockDriver.init):
(TestPageLoadingPerfTest.MockDriver.run_test):
(TestPageLoadingPerfTest.test_run):
(TestPageLoadingPerfTest.test_run_with_bad_output):
(TestReplayPerfTest.ReplayTestPort):
(TestReplayPerfTest.ReplayTestPort.init):
(TestReplayPerfTest.test_run_single.run_test):
(TestReplayPerfTest.test_run_single):
(TestReplayPerfTest.test_run_single_fails_when_output_has_error):
(TestPerfTestFactory.test_regular_test):
(TestPerfTestFactory.test_inspector_test):
(TestPerfTestFactory.test_page_loading_test):

11:21 PM Changeset in webkit [130365] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

[Refactoring] Tidy NDEBUG optioning in RefCountedBase.
https://bugs.webkit.org/show_bug.cgi?id=98252

Patch by Kangil Han <kangil.han@samsung.com> on 2012-10-03
Reviewed by Benjamin Poulain.

Fixed incomplete implementation for NDEBUG option.
Additionally, adopted CHECK_REF_COUNTED_LIFECYCLE definition to suppress abusing NDEBUG option.

  • wtf/RefCounted.h:

(WTF):
(WTF::RefCountedBase::ref):
(WTF::RefCountedBase::hasOneRef):
(WTF::RefCountedBase::refCount):
(WTF::RefCountedBase::turnOffVerifier):
(WTF::RefCountedBase::relaxAdoptionRequirement):
(WTF::RefCountedBase::RefCountedBase):
(WTF::RefCountedBase::~RefCountedBase):
(WTF::RefCountedBase::derefBase):
(RefCountedBase):
(WTF::adopted):
(WTF::RefCountedBase::setMutexForVerifier):
(WTF::RefCountedBase::setDispatchQueueForVerifier):

10:46 PM Changeset in webkit [130364] by ryuan.choi@samsung.com
  • 6 edits
    2 adds in trunk

[EFL] Default.edj should be generated although ENABLE_WEBKIT disabled.
https://bugs.webkit.org/show_bug.cgi?id=97753

Reviewed by Laszlo Gombos.

default.edj is used in both webkit/efl and webkit2/efl.
However, it has been generated only when ENABLE_WEBKIT is enabled.

This patch separates the script which generates default.edj
from source/webkit/platformefl.cmake.

.:

  • Source/CMakeLists.txt:
  • Source/PlatformEfl.cmake: Added to generate custom target for default theme.
  • Source/cmake/OptionsEfl.cmake:

Moved directory generation from WebKit/PlatformEfl.cmake
because THEME_BINARY_DIR is used for both Default Theme and control theme in Tools.

Source/WebKit:

  • PlatformEfl.cmake: Extracted codes which is related to default.edj.

Source/WebKit/efl:

  • DefaultTheme/CMakeLists.txt:

Extracted from Source/WebKit/PlatformEfl.cmake and sanitized.

10:42 PM Changeset in webkit [130363] by commit-queue@webkit.org
  • 8 edits in trunk

[EFL] Enable use of X11 in DumpRenderTree / WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=98231

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-03
Reviewed by Gyuyoung Kim.

Source/WebKit/efl:

Initialize ecore_x library in ewk_main since it is used by
WebKitEFL.

  • ewk/ewk_main.cpp:

(ewk_init):
(ewk_shutdown):

Source/WebKit2:

Initialize ecore_x library in ewk_main instead of
WebKitTestRunner since WebKit is using ecore_x
not WebKitTestRunner itself.

  • UIProcess/API/efl/ewk_main.cpp:

(ewk_init):
(ewk_shutdown):

Tools:

Enable use of X11 in DumpRenderTree / WebKitTestRunner.
Call ecore_evas_new() instead of ecore_evas_buffer_new()
in EFL's DumpRenderTree and WebKitTestRunner.
It is safe to do this now that we are using XvfbDriver
for the layout tests.

  • DumpRenderTree/efl/DumpRenderTree.cpp:

(parseCommandLineOptions):
(initEcoreEvas):

  • WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

(WTR::initEcoreEvas):

  • WebKitTestRunner/efl/main.cpp:

(main):

9:32 PM Changeset in webkit [130362] by tkent@chromium.org
  • 14 edits
    2 adds in trunk

DateTimeYearFieldElement should respect min/max values specified by page authors
https://bugs.webkit.org/show_bug.cgi?id=98227

Reviewed by Hajime Morita.

Source/WebCore:

Before this patch, we always set 1 to the minimum limit and 275760 to
the maximum limit for a year field, and a user can specify any year
regardless of min/max attributes. Such wide range is unnecessary for
normal applications and we should provide a way to limit the range.

Test: fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events.html

  • html/shadow/DateTimeFieldElements.h:

To add four constructor arguments, introduce Parameters struct.
Actually, we add the followings;

  • minimum year in UI
  • maximum year in UI
  • min attribute is specified
  • max attribute is specified

(Parameters):
(WebCore::DateTimeYearFieldElement::Parameters::Parameters):
(DateTimeYearFieldElement):

  • html/shadow/DateTimeFieldElements.cpp:

(WebCore::DateTimeYearFieldElement::DateTimeYearFieldElement): ditto.
(WebCore::DateTimeYearFieldElement::create): ditto.
(WebCore::DateTimeYearFieldElement::clampValueForHardLimits):
Override DateTimeNumericFieldElement::clampValueForHardLimits.
By this, we allow to set out-of-range year values.
(WebCore::currentFullYear): A helper to get the current year.
(WebCore::DateTimeYearFieldElement::defaultValueForStepDown):
If the field has no value and step down operation occurs,

  • the field has the current year if the max attribute is not specified.
  • the field has the maximum value otherwise.

(WebCore::DateTimeYearFieldElement::defaultValueForStepUp): Similar change.

  • html/shadow/DateTimeNumericFieldElement.h:

(DateTimeNumericFieldElement): Declare clampValueForHardLimits.

  • html/shadow/DateTimeNumericFieldElement.cpp:

(WebCore::DateTimeNumericFieldElement::clampValueForHardLimits):
(WebCore::DateTimeNumericFieldElement::setValueAsInteger):
Call clampValueForHardLimits instead of clampValue in order to
distinguish limits for UI and limits for internal value update.

  • html/shadow/DateTimeEditElement.h:

(LayoutParameters): Add minimumYear and maximumYear members.
(WebCore::DateTimeEditElement::LayoutParameters::LayoutParameters):
Initialize minimumYear and maximumYear.
(WebCore::DateTimeEditElement::LayoutParameters::undefinedYear):
Represents 'undefined' value for minimumYear and maximumYear.

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditBuilder::visitField):
Preparas DateTimeYearField::Parameters and pass it to the DateTimeYearField factory.

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::fullYear):
A helper to get a year value from an attribute value string.

  • html/BaseMultipleFieldsDateAndTimeInputType.h:

(BaseMultipleFieldsDateAndTimeInputType): Add fullYear().

  • html/DateTimeInputType.cpp:

(WebCore::DateTimeInputType::setupLayoutParameters):
Set LayoutParameters::minimumYear and maximumYear.

  • html/DateTimeLocalInputType.cpp:

(WebCore::DateTimeLocalInputType::setupLayoutParameters): ditto.

  • html/MonthInputType.cpp:

(WebCore::MonthInputType::setupLayoutParameters): ditto.

  • html/WeekInputType.cpp:

(WebCore::WeekInputType::setupLayoutParameters): ditto.

LayoutTests:

  • fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt: Added.
  • fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events.html: Added.
9:28 PM Changeset in webkit [130361] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2012-10-03 Geoffrey Garen <ggaren@apple.com>

Next step toward fixing Windows: add new symbol.

9:12 PM Changeset in webkit [130360] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2012-10-03 Geoffrey Garen <ggaren@apple.com>

First step toward fixing Windows: remove old symbol.

9:03 PM Changeset in webkit [130359] by ggaren@apple.com
  • 15 edits in trunk/Source/JavaScriptCore

Removed the assumption that "final" objects have a fixed number of inline slots
https://bugs.webkit.org/show_bug.cgi?id=98332

Reviewed by Filip Pizlo.

This is a step toward object size inference.

I replaced the inline storage capacity constant with a data member per
structure, set the the maximum supported value for the constant to 100,
then fixed what broke. (Note that even though this patch increases the
theoretical maximum inline capacity, it doesn't change any actual inline
capacity.)

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::compileGetDirectOffset): These functions just get a rename:
the constant they need is the first out of line offset along the offset
number line, which is not necessarily the same thing (and is, in this
patch, never the same thing) as the inline capacity of any given object.

(JSC::JIT::emit_op_get_by_pname):

  • jit/JITPropertyAccess32_64.cpp: This function changes functionality,

since it needs to convert from the abstract offset number line to an
actual offset in memory, and it can't assume that inline and out-of-line
offsets are contiguous on the number line.

(JSC::JIT::compileGetDirectOffset): Updated for rename.

(JSC::JIT::emit_op_get_by_pname): Same as emit_op_get_by_pname above.

  • llint/LowLevelInterpreter.asm: Updated to mirror changes in PropertyOffset.h,

since we duplicate values from there.

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm: Just like the JIT, most things are just

renames, and get_by_pname changes to do more math. I also standardized
offset calculations to use a hard-coded "-2", to match the JIT. This
isn't really better, but it makes global search and replace easier,
should we choose to refactor this code not to hard-code constants.

I also renamed loadPropertyAtVariableOffsetKnownNotFinal to
loadPropertyAtVariableOffsetKnownNotInline in order to sever the assumption
that inline capacity is tied to object type, and I changed the 64bit LLInt
to use this -- not using this previously seems to have been an oversight.

  • runtime/JSObject.cpp:

(JSC::JSObject::visitChildren):
(JSC::JSFinalObject::visitChildren):

  • runtime/JSObject.h:

(JSC::JSObject::offsetForLocation):
(JSNonFinalObject):
(JSC::JSFinalObject::createStructure):
(JSFinalObject):
(JSC::JSFinalObject::finishCreation): Updated for above changes.

  • runtime/JSPropertyNameIterator.h:

(JSPropertyNameIterator):
(JSC::JSPropertyNameIterator::finishCreation): Store the inline capacity
of our object, since it's not a constant.

(JSC::JSPropertyNameIterator::getOffset): Removed. This function was
wrong. Luckily, it was also unused, since the C++ interpreter is gone.

  • runtime/PropertyMapHashTable.h:

(PropertyTable): Use a helper function instead of hard-coding assumptions
about object types.

(JSC::PropertyTable::nextOffset):

  • runtime/PropertyOffset.h:

(JSC):
(JSC::checkOffset):
(JSC::validateOffset):
(JSC::isInlineOffset):
(JSC::numberOfSlotsForLastOffset):
(JSC::propertyOffsetFor): Refactored these functions to take inline capacity
as an argument, since it's not fixed at compile time anymore.

  • runtime/Structure.cpp:

(JSC::Structure::Structure):
(JSC::Structure::flattenDictionaryStructure):
(JSC::Structure::putSpecificValue):

  • runtime/Structure.h:

(Structure):
(JSC::Structure::outOfLineCapacity):
(JSC::Structure::hasInlineStorage):
(JSC::Structure::inlineCapacity):
(JSC::Structure::inlineSize):
(JSC::Structure::firstValidOffset):
(JSC::Structure::lastValidOffset):
(JSC::Structure::create): Removed some hard-coded assumptions about inline
capacity and object type, and replaced with more liberal use of helper functions.

8:42 PM Changeset in webkit [130358] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix parse error in vcproj file.

  • WebCore.vcproj/WebCore.vcproj:
8:36 PM Changeset in webkit [130357] by keishi@webkit.org
  • 20 edits in trunk/Source

Implement localizeValue for TimeInputType
https://bugs.webkit.org/show_bug.cgi?id=98237

Reviewed by Kent Tamura.

Source/WebCore:

We want to localize time values for the suggestion picker.
DateTimeStringBuilder parses a format and creates a formatted string.

Added chromium unit test LocaleMacTest.formatTime

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::shouldHaveSecondField): Moved from LayoutParameters because we want to use it inside localizeValue.
(WebCore):

  • html/BaseMultipleFieldsDateAndTimeInputType.h:

(BaseMultipleFieldsDateAndTimeInputType):

  • html/DateTimeInputType.cpp:

(WebCore::DateTimeInputType::setupLayoutParameters):

  • html/DateTimeLocalInputType.cpp:

(WebCore::DateTimeLocalInputType::setupLayoutParameters):

  • html/TimeInputType.cpp:

(WebCore::TimeInputType::localizeValue):
(WebCore):
(WebCore::TimeInputType::setupLayoutParameters):

  • html/TimeInputType.h:

(TimeInputType):

  • html/shadow/DateTimeEditElement.cpp:

(WebCore):

  • html/shadow/DateTimeEditElement.h:

(WebCore::DateTimeEditElement::LayoutParameters::LayoutParameters):

  • platform/text/LocaleICU.cpp:

(WebCore::LocaleICU::formatDateTime): Calls Localizer::formatDateTime if the date component is not a date.

  • platform/text/LocaleICU.h:

(LocaleICU):

  • platform/text/LocaleWin.cpp:

(WebCore::LocaleWin::formatDateTime): Calls Localizer::formatDateTime if the date component is not a date.

  • platform/text/LocaleWin.h:

(LocaleWin):

  • platform/text/LocaleNone.cpp:

(LocaleNone):
(WebCore::LocaleNone::formatDateTime):

  • platform/text/Localizer.cpp:

(DateTimeStringBuilder):
(WebCore):
(WebCore::DateTimeStringBuilder::DateTimeStringBuilder): Takes a
Localizer pointer. This is used inside the Localizer so the Localizer
will out live the DateTimeStringBuilder.
(WebCore::DateTimeStringBuilder::build): Builds a localized string for the given format.
(WebCore::DateTimeStringBuilder::zeroPadString):
(WebCore::DateTimeStringBuilder::appendNumber): Appends a number with left zero padding to match width.
(WebCore::DateTimeStringBuilder::visitField):
(WebCore::DateTimeStringBuilder::visitLiteral):
(WebCore::DateTimeStringBuilder::toString): Returns the localized string.
(WebCore::Localizer::formatDateTime):

  • platform/text/Localizer.h:
  • platform/text/mac/LocaleMac.h:

(LocaleMac):

  • platform/text/mac/LocaleMac.mm:

(WebCore::LocaleMac::formatDateTime): Calls Localizer::formatDateTime if the date component is not a date.

Source/WebKit/chromium:

  • tests/LocaleMacTest.cpp:

(LocaleMacTest::timeComponents):
(LocaleMacTest):
(LocaleMacTest::formatTime): Tests formatDateTime() for time.
(TEST_F):

7:53 PM Changeset in webkit [130356] by dpranke@chromium.org
  • 10 edits in trunk/Tools

run-webkit-tests tests on win32 after r127302
https://bugs.webkit.org/show_bug.cgi?id=98323

Reviewed by Eric Seidel.

run-webkit-tests tests on win32 after r127302
https://bugs.webkit.org/show_bug.cgi?id=98323

Reviewed by Eric Seidel.

Looks like when we converted the json-building logic to use scm
to try and get the svn revision, we missed a win32-ism and
didn't check to make sure had initialized the scm subsystem.

This change fixes that and renames _initialize_scm to be a public method.

  • Scripts/webkitpy/common/host.py:

(Host.initialize_scm):

  • Scripts/webkitpy/common/host_mock.py:

(MockHost.init):
(MockHost.initialize_scm):

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(summarize_results):

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

(JSONResultsGeneratorBase.get_json):
(JSONResultsGeneratorBase._get_result_char):
(JSONResultsGeneratorBase._get_svn_revision):

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner.init):

  • Scripts/webkitpy/style/checkers/test_expectations.py:

(TestExpectationsChecker.init):

  • Scripts/webkitpy/style/main.py:

(CheckWebKitStyle.main):

  • Scripts/webkitpy/tool/main.py:

(WebKitPatch.handle_global_options):

  • Scripts/webkitpy/tool/servers/rebaselineserver.py:

(get_test_baselines):

7:17 PM Changeset in webkit [130355] by commit-queue@webkit.org
  • 22 edits in trunk

Chromium needs support for border radius clipping
https://bugs.webkit.org/show_bug.cgi?id=69866

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-10-03
Reviewed by Stephen White.

Source/WebCore:

Changes to make this suitably efficient have already landed upstream in skia:
http://code.google.com/p/skia/source/detail?r=2924

Covered by existing tests.

  • rendering/RenderLayer.cpp:

LayoutTests:

  • platform/chromium-linux/fast/clip/overflow-border-radius-combinations-expected.png:
  • platform/chromium-linux/fast/clip/overflow-border-radius-fixed-position-expected.png:
  • platform/chromium-linux/fast/clip/overflow-border-radius-transformed-expected.png:
  • platform/chromium-linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-linux/media/audio-controls-rendering-expected.png:
  • platform/chromium-linux/media/audio-repaint-expected.png:
  • platform/chromium-linux/media/controls-after-reload-expected.png:
  • platform/chromium-linux/media/controls-strict-expected.png:
  • platform/chromium-linux/media/controls-styling-expected.png:
  • platform/chromium-linux/media/controls-styling-strict-expected.png:
  • platform/chromium-linux/media/controls-without-preload-expected.png:
  • platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.png:
  • platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.png:
  • platform/chromium-linux/media/video-controls-rendering-expected.png:
  • platform/chromium-linux/media/video-display-toggle-expected.png:
  • platform/chromium-linux/media/video-no-audio-expected.png:
  • platform/chromium-linux/media/video-playing-and-pause-expected.png:
  • platform/chromium-linux/media/video-zoom-controls-expected.png:
  • platform/chromium/TestExpectations:
6:53 PM Changeset in webkit [130354] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Simplify attribute access in Element::computeInheritedLanguage
https://bugs.webkit.org/show_bug.cgi?id=98327

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-10-03
Reviewed by Andreas Kling.

  • dom/Element.cpp:

(WebCore::Element::computeInheritedLanguage):
By using Element::fastGetAttribute(), we check for the existence of attributeData twice
and do a bunch of useless operation on AtomicString.

By using ElementAttributeData directly, we can cut it to the two important branch.

6:50 PM Changeset in webkit [130353] by commit-queue@webkit.org
  • 13 edits in trunk/Source

Fix unused parameter compile warnings.
https://bugs.webkit.org/show_bug.cgi?id=98243

Patch by Kangil Han <kangil.han@samsung.com> on 2012-10-03
Reviewed by Alexey Proskuryakov.

Source/WebCore:

Fixed unused parameter compile warning by removing parameter names and adding UNUSED_PARAM usage.

  • plugins/PluginDebug.cpp:

(WebCore::prettyNameForNPPVariable):

  • plugins/npapi.cpp:

(NPN_MemFlush):
(NPN_RequestRead):
(NPN_GetJavaPeer):

Source/WebKit/efl:

Fixed unused parameter compile warning by removing page parameter name and UNUSED_PARAM usage.

  • WebCoreSupport/PlatformStrategiesEfl.cpp:

(PlatformStrategiesEfl::getPluginInfo):

Source/WebKit2:

Fixed unused parameter compile warnings by removing parameter names, adding UNUSED_PARAM usage and commenting out.

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::createPluginInternal):

  • PluginProcess/unix/PluginProcessUnix.cpp:

(WebKit::PluginProcess::platformInitialize):

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::getOwnPropertyNames):

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_RequestRead):
(WebKit::NPN_NewStream):
(WebKit::NPN_Write):
(WebKit::NPN_MemFlush):
(WebKit::NPN_ReloadPlugins):
(WebKit::NPN_GetJavaPeer):
(WebKit::NPN_InvalidateRegion):
(WebKit::NPN_ForceRedraw):

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::contentsScaleFactorChanged):

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePlugin::platformPostInitializeWindowed):

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::contentsScaleFactorChanged):

5:52 PM Changeset in webkit [130352] by Simon Fraser
  • 3 edits in trunk/Websites/bugs.webkit.org

Make the status bubble iframe big enough to show all the bubbles
https://bugs.webkit.org/show_bug.cgi?id=98329

Reviewed by Eric Seidel.

Make the status bubble iframe big enough.

  • template/en/custom/attachment/edit.html.tmpl:
  • template/en/custom/attachment/list.html.tmpl:
5:50 PM Changeset in webkit [130351] by dpranke@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll chromium to r160008

Unreviewed, deps roll.

  • DEPS:
5:37 PM Changeset in webkit [130350] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

Measure the usage of WebSQLDatabase
https://bugs.webkit.org/show_bug.cgi?id=98330

Reviewed by Ojan Vafai.

WebKit is the only engine that implements WebSQLDatabase. This patch
causes us to measure its usage so we can see how quickly web sites move
to IndexedDB.

  • Modules/webdatabase/DOMWindowWebDatabase.idl:
  • page/FeatureObserver.h:
5:14 PM Changeset in webkit [130349] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

[GTK] Make inspector directly useable in GtkLauncher/MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=98310

Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2012-10-03
Reviewed by Martin Robinson.

Make MiniBrowser/GtkLauncher define the path to the inspector
resources by setting the WEBKIT_INSPECTOR_PATH environment
variable pointing to the copy of the inspector resources in
the build directory. If the environment variable is already
defined, its value is not overwritten. The path is derived
from the WEBKIT_EXEC_PATH macro defined in the makefiles.

  • GNUmakefile.am:
  • GtkLauncher/main.c:

(main):

  • MiniBrowser/gtk/main.c:

(main):

4:58 PM Changeset in webkit [130348] by Martin Robinson
  • 3 edits in trunk/Source/WebCore

[soup] WebKit crashes when doing a http request
https://bugs.webkit.org/show_bug.cgi?id=98055

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-10-03
Reviewed by Martin Robinson.

On i386, (d->m_firstRequest.timeoutInterval() * 1000) results in 0 if
timeoutInterval() is INT_MAX. So, set default timeout to 0 to avoid
calling soup_add_timeout with a 0 value.

Also, if resource handle is deleted before "request-started" signal is
emitted, soupMessage handle points to a deleted object, and a crash
occurs. So, reset soupMessage handle data in
cleanupSoupRequestOperation so it won't happen anymore.

Lastly, if timeout occurs before request is completed, handle is
deleted, and crash occurs in sendRequestCallback due to an early
destroyed handle. To avoid that, call handle->cancel in
requestTimeoutCallback. There is no need to call
cleanupSoupRequestOperation anymore since handle->cancel will trigger
sendRequestCallback, and as handle is deleted,
cleanupSoupRequestOperation will be called automatically.

No new tests yet, tests will be added with the patch in bug 74802.

  • platform/network/ResourceRequestBase.cpp:

(WebCore):

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::cleanupSoupRequestOperation):
(WebCore::ResourceHandle::platformSetDefersLoading):
(WebCore::requestTimeoutCallback):

4:54 PM Changeset in webkit [130347] by andersca@apple.com
  • 26 edits in trunk/Source/WebKit2

Plugins are killed after 45 seconds if showing keychain "Allow/Deny" dialog
https://bugs.webkit.org/show_bug.cgi?id=85138
<rdar://problem/11406430>

Reviewed by Andreas Kling.

Remove the watchdog that would kill a plug-in if we've been waiting for a sync reply from it for more than 45 seconds.
It's unlikely that someone is going to wait 45 seconds for Safari to recover from a plug-in hang, and the timeout is
causing problems with plug-ins (see the bugzilla bug for more information).

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::Connection):
(CoreIPC::Connection::waitForSyncReply):

  • Platform/CoreIPC/Connection.h:

(Client):
(Connection):

  • PluginProcess/PluginProcess.cpp:
  • PluginProcess/PluginProcess.h:

(PluginProcess):

  • PluginProcess/WebProcessConnection.cpp:
  • PluginProcess/WebProcessConnection.h:

(WebProcessConnection):

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

(WebProcessCreationParameters):

  • UIProcess/Plugins/PluginProcessManager.cpp:
  • UIProcess/Plugins/PluginProcessManager.h:

(PluginProcessManager):

  • UIProcess/Plugins/PluginProcessProxy.cpp:
  • UIProcess/Plugins/PluginProcessProxy.h:

(PluginProcessProxy):

  • UIProcess/WebConnectionToWebProcess.cpp:
  • UIProcess/WebConnectionToWebProcess.h:

(WebConnectionToWebProcess):

  • UIProcess/WebProcessProxy.cpp:
  • UIProcess/WebProcessProxy.h:

(WebProcessProxy):

  • UIProcess/WebProcessProxy.messages.in:
  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess):

  • WebProcess/Plugins/PluginProcessConnection.cpp:

(WebKit::PluginProcessConnection::PluginProcessConnection):

  • WebProcess/Plugins/PluginProcessConnection.h:

(PluginProcessConnection):

  • WebProcess/WebConnectionToUIProcess.cpp:
  • WebProcess/WebConnectionToUIProcess.h:

(WebConnectionToUIProcess):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::runJavaScriptAlert):
(WebKit::WebChromeClient::runJavaScriptConfirm):
(WebKit::WebChromeClient::runJavaScriptPrompt):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initializeWebProcess):

  • WebProcess/WebProcess.h:

(WebProcess):

4:52 PM Changeset in webkit [130346] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, remove 2 tests that were moved in http://trac.webkit.org/changeset/130150.

http/tests/inspector-enabled/contentSecurityPolicy-blocks-setInterval.html and
http/tests/inspector-enabled/contentSecurityPolicy-blocks-setTimeout.html were
refactored away.

  • platform/qt/TestExpectations:
4:48 PM Changeset in webkit [130345] by eae@chromium.org
  • 7 edits in trunk/LayoutTests

Unreviewed chromium/win rebaseline for r130329.

  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
4:40 PM Changeset in webkit [130344] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

OpaqueJSString doesn't optimally handle 8 bit strings
https://bugs.webkit.org/show_bug.cgi?id=98300

Reviewed by Geoffrey Garen.

Change OpaqueJSString to store and manage a String instead of a UChar buffer.
The member string is a copy of any string used during creation.

  • API/OpaqueJSString.cpp:

(OpaqueJSString::create):
(OpaqueJSString::identifier):

  • API/OpaqueJSString.h:

(OpaqueJSString::characters):
(OpaqueJSString::length):
(OpaqueJSString::string):
(OpaqueJSString::OpaqueJSString):
(OpaqueJSString):

4:38 PM Changeset in webkit [130343] by abarth@webkit.org
  • 23 edits
    3 deletes in trunk

Remove support for ENABLE(LEGACY_WEBKIT_BLOB_BUILDER)
https://bugs.webkit.org/show_bug.cgi?id=98301

Reviewed by Eric Seidel.

Source/WebCore:

According to anonymous usage statistics, the APIs guarded by
ENABLE(LEGACY_WEBKIT_BLOB_BUILDER) are used on approximately 0.006% of
web pages. Given that this feature is only enabled in GTK and Chromium,
it seems likely that we should remove it.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.features.am:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • fileapi/WebKitBlobBuilder.idl: Removed.
  • page/DOMWindow.idl:

Source/WebKit/chromium:

  • features.gypi:
4:36 PM Changeset in webkit [130342] by Beth Dakin
  • 6 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=98313
ScrollingStateNode should keep a Vector of children instead of child
pointers

Reviewed by Simon Fraser.

This patch re-names ScrollingStateNode::cloneNode() to
ScrollingStateNode::cloneAndResetNode(). The new function resets the
change properties of the current node after cloning it, and it also
takes care of cloning children, which the old function did not do.

m_firstChild and m_nextSibling are gone. Use the m_children Vector
instead.

  • page/scrolling/ScrollingStateNode.cpp:

(WebCore::ScrollingStateNode::cloneAndResetChildNodes):
(WebCore::ScrollingStateNode::appendChild):

  • page/scrolling/ScrollingStateNode.h:

(ScrollingStateNode):
(WebCore::ScrollingStateNode::parent):
(WebCore::ScrollingStateNode::setParent):

Reset the change properties and clone children in cloneAndResetNode()

  • page/scrolling/ScrollingStateScrollingNode.cpp:

(WebCore::ScrollingStateScrollingNode::cloneAndResetNode):

  • page/scrolling/ScrollingStateScrollingNode.h:

Yay, this function can be vastly simplified now that we don't have
those messy child and sibling pointers.

  • page/scrolling/ScrollingStateTree.cpp:

(WebCore::ScrollingStateTree::commit):

4:28 PM Changeset in webkit [130341] by jchaffraix@webkit.org
  • 1 edit
    1 add in trunk/PerformanceTests

Add a performance test for subtree detaching
https://bugs.webkit.org/show_bug.cgi?id=98281

Reviewed by Eric Seidel.

The new test tries to stress detaching on a heavy subtree (2 levels deep but with 1,000 nodes per level).
We set display: none on the root and measure the time it takes to update the tree. Note that we will also
measure the time taken by recalcStyle and relayout but I don't think we can avoid that.

  • Layout/subtree-detaching.html: Added.
4:27 PM Changeset in webkit [130340] by eae@chromium.org
  • 10 edits in trunk/LayoutTests

Unreviewed chromium/mac rebaseline for r130329.

  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
4:26 PM Changeset in webkit [130339] by ojan@chromium.org
  • 4 edits in trunk/Source/WebCore

Replace uses of -webkit-box-sizing with box-sizing
https://bugs.webkit.org/show_bug.cgi?id=98312

Reviewed by Tony Chang.

No need to use the prefixed version when the unprefixed works the same.
No new tests since there's no change in behavior..

  • css/html.css:
4:13 PM Changeset in webkit [130338] by jsbell@chromium.org
  • 2 edits in trunk/Source/WebCore

IndexedDB: Don't do full commit for empty transactions
https://bugs.webkit.org/show_bug.cgi?id=89239

Reviewed by Tony Chang.

Don't bother creating a leveldb write batch if there's nothing in the transaction
to commit. Note that a read-only transaction may still have index cleanup so may
not be an empty transaction.

This cuts the Lookup2 benchmark in http://reyesr.github.com/html5-storage-benchmark/
from 70s to 2s.

Covered by existing tests, e.g. storage/indexeddb/transaction-basics.html

  • platform/leveldb/LevelDBTransaction.cpp:

(WebCore::LevelDBTransaction::commit):

3:59 PM Changeset in webkit [130337] by ojan@chromium.org
  • 6 edits in trunk/LayoutTests

Simplify the magnitude-perf test harness
https://bugs.webkit.org/show_bug.cgi?id=98305

Reviewed by Ryosuke Niwa.

-Remove the chromium.Interval stuff. This API no longer exists.
-Reduce the number of iterations to 8.
-Start magnitude at 1 instead of 0.
-Remove all the iterationsPerRun junk. This complexity was not achieving the goal of
reducing flakiness.

With these changes, the perf tests are not flaky for me locally.
I ran all the perf tests with --iterations=100 and had no failures,
All the complexity was increasing flakiness.

This also reduces the runtime of the tests by >2x.

  • perf/adding-radio-buttons.html:

This test is clearly linear. It should never have been marked constant.
The patch that landed it was fixing an n2 behavior.

  • perf/array-binary-search.html:

Search for the first item in the array so that the search is always actually log n.

  • perf/nested-combined-selectors.html:

Now that we run fewer iterations, we don't need to artificially limit this test.

  • resources/magnitude-perf.js:

(Magnitude.run):
(Magnitude._run):
(Magnitude._rSquared):
(Magnitude._logIterationInfo):
(Magnitude._bigOGuess):
(Magnitude._runIteration):
(Magnitude):

3:44 PM Changeset in webkit [130336] by adamk@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove bogus FIXME from Document.idl
https://bugs.webkit.org/show_bug.cgi?id=98302

Reviewed by Adam Barth.

The FIXME claimed that document.body throwing an exception was not
specced, but in fact it is:
http://www.whatwg.org/specs/web-apps/current-work/multipage/dom.html#dom-document-body

  • dom/Document.idl:
3:41 PM Changeset in webkit [130335] by jsbell@chromium.org
  • 3 edits in trunk/Source/WebCore

IndexedDB: Memory leak when deleting object stores with indexes
https://bugs.webkit.org/show_bug.cgi?id=98292

Reviewed by Tony Chang.

Reference cycles between IDBObjectStore and IDBIndex instances are explicitly
broken when the transaction completes (and the spec allows traversal to fail).
Deleted stores need to have the reference cycle broken too.

Caught by running valgrind over: storage/indexeddb/keypath-basics.html

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::objectStoreDeleted): Add store to set.
(WebCore::IDBTransaction::dispatchEvent): Notify stores in set.

  • Modules/indexeddb/IDBTransaction.h: Add set of deleted stores.
3:41 PM Changeset in webkit [130334] by jsbell@chromium.org
  • 3 edits in trunk/LayoutTests

[Chromium] storage/indexeddb tests sometimes timeout
https://bugs.webkit.org/show_bug.cgi?id=65862

Reviewed by Ojan Vafai.

storage/indexeddb/index-cursor.html was taking up to 26 seconds on some debug configurations
due to the large amount of output. Tweak the test to reduce the spam. On my test box this
drops the runtime of this single test from 7s to 2s.

  • storage/indexeddb/index-cursor-expected.txt:
  • storage/indexeddb/resources/index-cursor.js:

(cursorIteration):

3:36 PM Changeset in webkit [130333] by abarth@webkit.org
  • 5 edits
    1 delete in trunk/Source/WebCore

CSSNamespace.h is empty and should be deleted
https://bugs.webkit.org/show_bug.cgi?id=98304

Reviewed by Eric Seidel.

There's no reason to have this file in the repository.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSNamespace.h: Removed.
3:33 PM Changeset in webkit [130332] by commit-queue@webkit.org
  • 2 edits in trunk/Source/Platform

Adding total pixels painted and rasterized stats.
https://bugs.webkit.org/show_bug.cgi?id=98269

Patch by Glenn Hartmann <hartmanng@chromium.org> on 2012-10-03
Reviewed by James Robinson.

  • chromium/public/WebRenderingStats.h:

(WebRenderingStats):
(WebKit::WebRenderingStats::WebRenderingStats):
(WebKit::WebRenderingStats::enumerateFields):

3:29 PM Changeset in webkit [130331] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Build failure with css filters enabled and accelerated compositing disabled
https://bugs.webkit.org/show_bug.cgi?id=95908

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-10-03
Reviewed by Tony Chang.

Do not try to setBackingNeedsRepaint when building without accelerated
compositing.

Also, allow painting with filter (paintsWithFilters returns true if
renderer has filter) when accelerated compositing is not enabled.

No functional change, so no new tests.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::styleChanged):

3:16 PM Changeset in webkit [130330] by rakuco@webkit.org
  • 43 edits
    4 adds in trunk/LayoutTests

[EFL] Pixel test rebaselines to enable pixel testing on the bots, part 5.

Finally finish rebaselining fast/.

  • platform/efl/fast/repaint/transform-repaint-descendants-expected.png:
  • platform/efl/fast/replaced/absolute-image-sizing-expected.png:
  • platform/efl/fast/replaced/width100percent-image-expected.png:
  • platform/efl/fast/replaced/width100percent-textfield-expected.png:
  • platform/efl/fast/ruby/ruby-block-style-not-updated-expected.png: Added.
  • platform/efl/fast/ruby/ruby-block-style-not-updated-with-before-after-content-expected.png: Added.
  • platform/efl/fast/ruby/ruby-inline-style-not-updated-expected.png: Added.
  • platform/efl/fast/ruby/ruby-inline-style-not-updated-with-before-after-content-expected.png: Added.
  • platform/efl/fast/ruby/ruby-inline-table-expected.png:
  • platform/efl/fast/runin/001-expected.png:
  • platform/efl/fast/runin/generated-expected.png:
  • platform/efl/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.png:
  • platform/efl/fast/table/floatingTablePaintBackground-expected.png:
  • platform/efl/fast/table/form-with-table-style-expected.png:
  • platform/efl/fast/text/backslash-to-yen-sign-euc-expected.png:
  • platform/efl/fast/text/emphasis-avoid-ruby-expected.png:
  • platform/efl/fast/text/emphasis-combined-text-expected.png:
  • platform/efl/fast/text/emphasis-overlap-expected.png:
  • platform/efl/fast/text/large-text-composed-char-expected.png:
  • platform/efl/fast/text/whitespace/002-expected.png:
  • platform/efl/fast/text/whitespace/003-expected.png:
  • platform/efl/fast/text/whitespace/004-expected.png:
  • platform/efl/fast/text/whitespace/005-expected.png:
  • platform/efl/fast/text/whitespace/006-expected.png:
  • platform/efl/fast/text/whitespace/007-expected.png:
  • platform/efl/fast/text/whitespace/008-expected.png:
  • platform/efl/fast/text/whitespace/009-expected.png:
  • platform/efl/fast/text/whitespace/010-expected.png:
  • platform/efl/fast/text/whitespace/011-expected.png:
  • platform/efl/fast/text/whitespace/012-expected.png:
  • platform/efl/fast/text/whitespace/013-expected.png:
  • platform/efl/fast/text/whitespace/014-expected.png:
  • platform/efl/fast/text/whitespace/015-expected.png:
  • platform/efl/fast/text/whitespace/016-expected.png:
  • platform/efl/fast/text/whitespace/018-expected.png:
  • platform/efl/fast/text/whitespace/020-expected.png:
  • platform/efl/fast/text/whitespace/021-expected.png:
  • platform/efl/fast/text/whitespace/025-expected.png:
  • platform/efl/fast/text/whitespace/027-expected.png:
  • platform/efl/fast/text/whitespace/030-expected.png:
  • platform/efl/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
  • platform/efl/fast/text/whitespace/pre-break-word-expected.png:
  • platform/efl/fast/text/whitespace/pre-wrap-last-char-expected.png:
  • platform/efl/fast/text/whitespace/pre-wrap-line-test-expected.png:
  • platform/efl/fast/text/whitespace/pre-wrap-overflow-selection-expected.png:
  • platform/efl/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png:
3:07 PM Changeset in webkit [130329] by eae@chromium.org
  • 20 edits
    3 adds in trunk

Round image sizes when zooming
https://bugs.webkit.org/show_bug.cgi?id=98205

Reviewed by Eric Seidel.

Source/WebCore:

We currently floor image sizes when zooming which can result in
images being rendered at one pixel less than the actual size.
This is especially likely to happen for very large images.

Test: fast/sub-pixel/zoomed-image-tiles.html

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::imageSizeForRenderer):

LayoutTests:

Add test for zoomed large image tiles.

  • fast/images/zoomed-img-size.html:
  • fast/sub-pixel/zoomed-image-tiles-expected.html: Added.
  • fast/sub-pixel/zoomed-image-tiles.html: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
  • platform/chromium/fast/images/zoomed-img-size-expected.txt: Added.
  • platform/gtk/TestExpectations:
  • platform/mac-lion/TestExpectations:
  • platform/mac-snowleopard/TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt-4.8/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win-wk2/TestExpectations:
  • platform/win-xp/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
  • platform/wk2/TestExpectations:
3:05 PM Changeset in webkit [130328] by rakuco@webkit.org
  • 38 edits
    3 adds in trunk/LayoutTests

[EFL] Pixel test rebaselines to enable pixel testing on the bots, part 5.

  • platform/efl/fast/repaint/list-marker-2-expected.png:
  • platform/efl/fast/repaint/list-marker-expected.png:
  • platform/efl/fast/repaint/make-children-non-inline-expected.png:
  • platform/efl/fast/repaint/opacity-change-on-overflow-float-expected.png:
  • platform/efl/fast/repaint/outline-child-repaint-expected.png:
  • platform/efl/fast/repaint/outline-inset-expected.png:
  • platform/efl/fast/repaint/outline-repaint-glitch-expected.png:
  • platform/efl/fast/repaint/outline-shrinking-expected.png:
  • platform/efl/fast/repaint/overflow-delete-line-expected.png:
  • platform/efl/fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
  • platform/efl/fast/repaint/overflow-outline-repaint-expected.png:
  • platform/efl/fast/repaint/overflow-scroll-body-appear-expected.png:
  • platform/efl/fast/repaint/overflow-scroll-delete-expected.png:
  • platform/efl/fast/repaint/reflection-redraw-expected.png:
  • platform/efl/fast/repaint/repaint-resized-overflow-expected.png:
  • platform/efl/fast/repaint/scale-page-shrink-expected.png:
  • platform/efl/fast/repaint/scroll-inside-table-cell-expected.png:
  • platform/efl/fast/repaint/selected-replaced-expected.png:
  • platform/efl/fast/repaint/selection-after-remove-expected.png:
  • platform/efl/fast/repaint/selection-gap-overflow-scroll-2-expected.png:
  • platform/efl/fast/repaint/selection-gap-overflow-scroll-expected.png:
  • platform/efl/fast/repaint/selection-rl-expected.png:
  • platform/efl/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/efl/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/efl/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/efl/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/efl/fast/repaint/stacked-diacritics-expected.png:
  • platform/efl/fast/repaint/static-to-positioned-expected.png:
  • platform/efl/fast/repaint/table-cell-collapsed-border-expected.png:
  • platform/efl/fast/repaint/table-cell-move-expected.png:
  • platform/efl/fast/repaint/table-collapsed-border-expected.png:
  • platform/efl/fast/repaint/table-extra-bottom-grow-expected.png:
  • platform/efl/fast/repaint/text-append-dirty-lines-expected.png:
  • platform/efl/fast/repaint/text-emphasis-v-expected.png: Added.
  • platform/efl/fast/repaint/text-selection-rect-in-overflow-2-expected.png:
  • platform/efl/fast/repaint/text-selection-rect-in-overflow-expected.png:
  • platform/efl/fast/repaint/text-shadow-expected.png:
  • platform/efl/fast/repaint/text-shadow-horizontal-expected.png:
  • platform/efl/fast/repaint/textarea-set-disabled-expected.png: Added.
  • platform/efl/fast/repaint/transform-relative-position-expected.png:
2:52 PM Changeset in webkit [130327] by Hugo Parente Lima
  • 7 edits in trunk/Source

[WK2] PageViewportController.cpp is supposed to be a generic WebKit2 file but only works with Qt port.
https://bugs.webkit.org/show_bug.cgi?id=98186

Reviewed by Noam Rosenthal.

Source/WebCore:

Remove the implicit conversion from WebCore::FloatSize to QSize.

  • platform/graphics/FloatSize.h:

(FloatSize):

Source/WebKit2:

Remove the dependece of WebCore::FloatSize to QSize implicit conversion.

  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPagePrivate::updateSize):

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewLegacyPrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::updateViewportSize):

  • UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::didRenderFrame):
(WebKit::PageViewportController::pageDidRequestScroll):
(WebKit::PageViewportController::syncVisibleContents):
(WebKit::PageViewportController::viewportSizeInContentsCoordinates):
(WebKit):

  • UIProcess/PageViewportController.h:

(PageViewportController):

2:51 PM Changeset in webkit [130326] by rakuco@webkit.org
  • 31 edits in trunk/LayoutTests

[EFL] Pixel test rebaselines to enable pixel testing on the bots, part 4.

  • platform/efl/fast/repaint/bugzilla-7235-expected.png:
  • platform/efl/fast/repaint/change-transform-expected.png:
  • platform/efl/fast/repaint/clipped-relative-expected.png:
  • platform/efl/fast/repaint/containing-block-position-change-expected.png:
  • platform/efl/fast/repaint/control-clip-expected.png:
  • platform/efl/fast/repaint/dynamic-table-vertical-alignment-change-expected.png:
  • platform/efl/fast/repaint/fixed-move-after-keyboard-scroll-expected.png:
  • platform/efl/fast/repaint/fixed-table-cell-expected.png:
  • platform/efl/fast/repaint/flexible-box-overflow-expected.png:
  • platform/efl/fast/repaint/flexible-box-overflow-horizontal-expected.png:
  • platform/efl/fast/repaint/float-move-during-layout-expected.png:
  • platform/efl/fast/repaint/focus-layers-expected.png:
  • platform/efl/fast/repaint/inline-block-overflow-expected.png:
  • platform/efl/fast/repaint/layer-child-outline-expected.png:
  • platform/efl/fast/repaint/layer-outline-expected.png:
  • platform/efl/fast/repaint/layer-outline-horizontal-expected.png:
  • platform/efl/fast/repaint/layout-state-scrolloffset-expected.png:
  • platform/efl/fast/repaint/layout-state-scrolloffset2-expected.png:
  • platform/efl/fast/repaint/layout-state-scrolloffset3-expected.png:
  • platform/efl/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/efl/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/efl/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/efl/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/efl/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/efl/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/efl/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/efl/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/efl/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/efl/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/efl/fast/repaint/line-overflow-expected.png:
2:45 PM Changeset in webkit [130325] by benjamin@webkit.org
  • 7 edits in trunk

Fix Geolocation/window-close-crash.html and harden WebKitTestRunner for Geolocation
https://bugs.webkit.org/show_bug.cgi?id=97608

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-10-03
Reviewed by Sam Weinig.

Tools:

The test fast/dom/Geolocation/window-close-crash.html was crashing because
handleGeolocationPermissionRequest() was executed on the wrong pointer. Depending on how
the page was created, the void* clientInfo can either be a PlatformWebView or
a TestController.

Using the global TestController fixes the issue.

  • WebKitTestRunner/GeolocationProviderMock.cpp:

(WTR::GeolocationProviderMock::setPosition):
(WTR::GeolocationProviderMock::setPositionUnavailableError):
To be reliable, the test fast/dom/Geolocation/maximum-age.html needs the setting the position
to clear the error and vice versa.
This is the same behavior as GeolocationClientMock and MockGeolocationProvider of WebKit1.

(WTR::GeolocationProviderMock::sendPositionIfNeeded):
(WTR::GeolocationProviderMock::sendErrorIfNeeded):
Some tests expect the position/error cant be sent multiple time,
just keep the position after sending.

  • WebKitTestRunner/TestController.cpp:

(WTR::decidePolicyForGeolocationPermissionRequest):
(WTR::TestController::decidePolicyForGeolocationPermissionRequestIfPossible):

  • WebKitTestRunner/TestController.h:

Let's play as if we did not know what is in GeolocationPermissionRequestManagerProxy like a real
client would have to do.

LayoutTests:

  • platform/wk2/TestExpectations:

Unskip fast/dom/Geolocation/window-close-crash.html.

  • platform/mac-wk2/TestExpectations:

Unskip fast/dom/Geolocation/maximum-age.html.

2:40 PM Changeset in webkit [130324] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Try to fix the Qt WebKit2 failures.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::DrawingAreaImpl):
Always force compositing if USE(COORDINATED_GRAPHICS) is true.

2:32 PM Changeset in webkit [130323] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

REGRESSION(r130160): It made 3 tests crash
https://bugs.webkit.org/show_bug.cgi?id=98158

Unreviewed testExpectations update.

  • platform/qt/TestExpectations: Removed expectations from tests that were crashing due to this bug.
2:29 PM Changeset in webkit [130322] by leviw@chromium.org
  • 2 edits in trunk/Source/WebCore

[Sub-pixel layout] incorrect rendering when painting sub-layers as their own root
https://bugs.webkit.org/show_bug.cgi?id=97484

Reviewed by Eric Seidel.

When in compositing mode, layer painting can be triggered through the backing store. When this
happens, a non-top-level RenderLayer is called to paint as its own root. Normally, we attempt to preserve
the proper sub-pixel accumulation through layers to their children, but since we're not
starting with the top-level layer, we haven't properly accumulated one, and convertToLayerCoords,
another source of correctly getting the sub-pixel offset for a layer, also avoids crawling
past the listed root layer.

When painting a root layer, we're aligned to the surface we're painting to, so we round our
offset to avoid moving objects around.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayerContents):

2:22 PM Changeset in webkit [130321] by commit-queue@webkit.org
  • 13 edits in trunk/Source

[chromium] Expose settings value to conditionally enable pinch-zoom scaling in the Chromium compositor. The
flag defaults to disabled, so this change should be a no-op for scaling/scrolling behaviour.
https://bugs.webkit.org/show_bug.cgi?id=93292

Patch by Jeff Timanus <twiz@chromium.org> on 2012-10-03
Reviewed by James Robinson.

Source/Platform:

  • chromium/public/WebCompositor.h:

(WebCompositor):

  • chromium/public/WebCompositorSupport.h:

(WebKit::WebCompositorSupport::setPageScalePinchZoomEnabled):

Source/WebCore:

Tests: Existing page-scale layout tests.

  • page/Frame.cpp:

(WebCore::Frame::frameScaleFactor):

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setApplyPageScaleFactorInCompositor):
(WebCore::Settings::applyPageScaleFactorInCompositor):
(Settings):

Source/WebKit/chromium:

  • public/WebSettings.h:
  • src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::NonCompositedContentHost):

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setApplyPageScaleFactorInCompositor):
(WebKit):
(WebKit::WebSettingsImpl::applyPageScaleFactorInCompositor):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setPageScaleFactor):
(WebKit::WebViewImpl::applyScrollAndScale):

2:11 PM Changeset in webkit [130320] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

.: [BlackBerry] Implementing the NetworkInfo API for BB port
https://bugs.webkit.org/show_bug.cgi?id=98273

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-10-03
Reviewed by Rob Buis.

Adding references to new classes added to support BlackBerry's
NetworkInfo implementation.

  • Source/cmake/OptionsBlackBerry.cmake:

Source/WebKit: [BlackBerry] Implementing the NetworkInfo API for BB port
https://bugs.webkit.org/show_bug.cgi?id=98273

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-10-03
Reviewed by Rob Buis.

Adding new classes to support NetworkInfo API in the
BlackBerry Port.

  • PlatformBlackBerry.cmake:

Source/WebKit/blackberry: [BlackBerry] Implementing the NetworkInfo API for BB port
https://bugs.webkit.org/show_bug.cgi?id=98273

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-10-03
Reviewed by Rob Buis.

Adding new class NetworkInfoClientBlackBerry to implement
NetworkInfoClient for the BlackBerry port.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

  • WebCoreSupport/NetworkInfoClientBlackBerry.cpp: Added.

(WebCore):
(WebCore::NetworkInfoClientBlackBerry::NetworkInfoClientBlackBerry):
(WebCore::NetworkInfoClientBlackBerry::startUpdating):
(WebCore::NetworkInfoClientBlackBerry::stopUpdating):
(WebCore::NetworkInfoClientBlackBerry::bandwidth):
(WebCore::NetworkInfoClientBlackBerry::metered):
(WebCore::NetworkInfoClientBlackBerry::onCurrentNetworkChange):
(WebCore::NetworkInfoClientBlackBerry::onCurrentCellularTypeChange):

  • WebCoreSupport/NetworkInfoClientBlackBerry.h: Added.

(WebKit):
(WebCore):
(NetworkInfoClientBlackBerry):
(WebCore::NetworkInfoClientBlackBerry::~NetworkInfoClientBlackBerry):

Tools: [BlackBerry] Implementing the NetworkInfo API for BB port
https://bugs.webkit.org/show_bug.cgi?id=98273

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-10-03
Reviewed by Rob Buis.

Enabling NetworkInfo API for the BlackBerry port.

  • Scripts/webkitperl/FeatureList.pm:
2:00 PM Changeset in webkit [130319] by schenney@chromium.org
  • 10 edits
    4 adds in trunk

Font data is purged while fonts are still using it
https://bugs.webkit.org/show_bug.cgi?id=93640

Reviewed by Eric Seidel.

Source/WebCore:

Move the handling of custom font pruning from Document to FontFallbackList.
The previous inplementation allowed fonts to be removed before all their
clients were done. This change moves handling of custom font purging to the
FontFallbackList class, which is the shared object that is only removed
when all clients of a font are done with it. This fixes a crash in Angry
Birds due to a seamless iframe and some failing tests in fast/frames/seamless.

The specific element that causes problems is:
<iframe id="ingame_frame0" name="ingame_frame0" frameborder="0" seamless="true"

src="http://chrome.angrybirds.com/ingame_graphic.html"
onload="this.style.opacity = 1; parent.adLoaded();" scrolling="no"
style="opacity: 1; -webkit-transition: opacity 1s ease-in-out 0s;
position: absolute; border: 0px; width: 312px; height: 320px; z-index:
300; overflow: hidden; visibility: visible;"></iframe>

The source document uses the same font as the embedding document.

Tests: fast/frames/seamless/seamless-custom-font-pruning-crash.html

fast/frames/seamless/seamless-nested-crash.html

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData): Remove code to register the font with the document.

  • css/CSSSegmentedFontFace.cpp:

(WebCore::CSSSegmentedFontFace::getFontData): Remove code to register the font with the document.

  • dom/Document.cpp:

(WebCore::Document::~Document): Remove code that records and purges custom fonts.
(WebCore):
(WebCore::Document::reportMemoryUsage): Remove reference to non-existent objects.

  • dom/Document.h:

(WebCore):
(Document): Remove method declarations for custom font handling.

  • platform/graphics/FontFallbackList.h:

(FontFallbackList): Moved some code around and made non-copyable.
(WebCore::FontFallbackList::setGlyphPageZero): Moved.
(WebCore::FontFallbackList::setGlyphPages): Moved.

  • platform/graphics/GlyphPageTreeNode.cpp:

(WebCore::GlyphPageTreeNode::pruneFontData): Removed unnecessary null check.

  • platform/graphics/SegmentedFontData.cpp:

(WebCore::SegmentedFontData::~SegmentedFontData): Added code to prune the Glyph pages when this is deleted.

  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::~SimpleFontData): Added code to prune the Glyph pages when this is deleted.

LayoutTests:

Tests for font purging. The seamless-custom-font-pruning-crash test
was only failing in Chromium Asan, while the seamless-nested-crash
case was only failing in Asan DumpRenderTree.

  • fast/frames/seamless/seamless-custom-font-pruning-crash-expected.txt: Added.
  • fast/frames/seamless/seamless-custom-font-pruning-crash.html: Added.
  • fast/frames/seamless/seamless-nested-crash-expected.txt: Added.
  • fast/frames/seamless/seamless-nested-crash.html: Added.
2:00 PM Changeset in webkit [130318] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Use the XPC service by default on newer systems
https://bugs.webkit.org/show_bug.cgi?id=98297
<rdar://problem/12424641>

Reviewed by Sam Weinig.

  • UIProcess/mac/WebProcessProxyMac.mm:

(WebKit::shouldUseXPC):
Return false for older systems.

(WebKit::WebProcessProxy::platformConnect):
Call shouldUseXPC().

1:17 PM Changeset in webkit [130317] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Fix some style violations in perparation for changing this code.

  • resources/magnitude-perf.js:

(Magnitude.run):
(Magnitude._logIterationInfo):
(Magnitude._runIteration):

1:09 PM Changeset in webkit [130316] by aestes@apple.com
  • 11 edits
    1 add in trunk/Source/WebKit2

[WebKit2] Add the ability to send messages to the WebPageGroupProxy
https://bugs.webkit.org/show_bug.cgi?id=98233

Reviewed by Anders Carlsson.

Add a WebPageGroupProxy.messages.in, implement a stub message receiver
in WebPageGroupProxy, and teach WebProcess how to route messages to the
appropriate WebPageGroupProxy.

  • CMakeLists.txt: Tell a build system about added files.
  • DerivedSources.make: Ditto.
  • DerivedSources.pri: Ditto.
  • GNUmakefile.list.am: Ditto.
  • WebKit2.xcodeproj/project.pbxproj: Ditto.
  • win/WebKit2.vcproj: Ditto.
  • Platform/CoreIPC/MessageID.h: Add MessageClassWebPageGroupProxy.
  • WebProcess/WebPage/WebPageGroupProxy.cpp:

(WebKit::WebPageGroupProxy::didReceiveMessage): Stub out the method
that will receive messages.
(WebKit::WebPageGroupProxy::didReceiveWebPageGroupProxyMessage): Stub
out a method that will exist in WebPageGroupProxyMessageReceiver.cpp
once WebPageGroupProxy.messages.in contains messages.

  • WebProcess/WebPage/WebPageGroupProxy.h:
  • WebProcess/WebPage/WebPageGroupProxy.messages.in: Added.
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didReceiveMessage): Route messages to the
WebPageGroupProxy matching destinationID if the message is of class
MessageClassWebPageGroupProxy.

1:03 PM Changeset in webkit [130315] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Array.splice should be fast when it is used to remove elements other than the very first
https://bugs.webkit.org/show_bug.cgi?id=98236

Reviewed by Michael Saboff.

Applied the same technique that was used to optimize the unshift case of splice in
http://trac.webkit.org/changeset/129676. This is a >20x speed-up on programs that
use splice for element removal.

  • runtime/ArrayPrototype.cpp:

(JSC::shift):

  • runtime/JSArray.cpp:

(JSC::JSArray::shiftCount):

  • runtime/JSArray.h:

(JSArray):

1:00 PM Changeset in webkit [130314] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Mark platform/chromium/virtual/gpu/fast/canvas/getPutImageDataPairTest.html as slow on Mac Lion Release
https://bugs.webkit.org/show_bug.cgi?id=79679

Unreviewed, expectations change.

  • platform/chromium/TestExpectations:
12:34 PM Changeset in webkit [130313] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

Crash when calling document.open during unload
https://bugs.webkit.org/show_bug.cgi?id=98287

Reviewed by Nate Chapin.

Source/WebCore:

Calling document.open results in us nulling out m_documentLoader. This
code doesn't properly handle that case and crashes.

Test: fast/parser/document-open-in-unload.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::commitProvisionalLoad):

LayoutTests:

Test that we don't crash when calling document.open during the unload event.

  • fast/parser/document-open-in-unload-expected.txt: Added.
  • fast/parser/document-open-in-unload.html: Added.
12:33 PM Changeset in webkit [130312] by andersca@apple.com
  • 2 edits in trunk/Tools

Exception thrown when running accessibility/container-node-delete-causes-crash.html test
https://bugs.webkit.org/show_bug.cgi?id=98291

Reviewed by Andreas Kling.

The accessibility/container-node-delete-causes-crash.html test will cause a full accessibility tree
to be created by trying to look up an element with a non-existent ID. This caused an exception to be thrown
when trying to access the children of an element that didn't have any children. Fix this by adding
BEGIN_AX_OBJC_EXCEPTIONS/END_AX_OBJC_EXCEPTIONS around the call to get the children.

  • DumpRenderTree/mac/AccessibilityControllerMac.mm:

(findAccessibleObjectById):

12:17 PM Changeset in webkit [130311] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Element::computeInheritedLanguage: evaluate the while() condition after fetching the string
https://bugs.webkit.org/show_bug.cgi?id=98220

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-10-03
Reviewed by Andreas Kling.

  • dom/Element.cpp:

(WebCore::Element::computeInheritedLanguage):
The condition is never false on the first execution. Move the condition to the
end of the loop for fun and profit.

12:16 PM Changeset in webkit [130310] by ojan@chromium.org
  • 2 edits in trunk/Tools

Make partytime work when loading garden-o-matic from trac.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=98283

Reviewed by Adam Barth.

CSP was blocking the reqest for partytime.gif because 'self' wasn't on the img-src directive.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
12:02 PM Changeset in webkit [130309] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Adding sys.platform check to skip a failing assert on the Apple Windows platform.
https://bugs.webkit.org/show_bug.cgi?id=98288

  • Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:

(ChromiumAndroidDriverTest.test_command_from_driver_input):

11:31 AM Changeset in webkit [130308] by hans@chromium.org
  • 13 edits in trunk

Speech JavaScript API: Add SpeechRecognition.interimResults attribute
https://bugs.webkit.org/show_bug.cgi?id=98279

Reviewed by Adam Barth.

Source/WebCore:

Add the interimResults attribute and pass it to the embedder. It was
added to the spec draft in
http://dvcs.w3.org/hg/speech-api/rev/d25fea0d029c

Tested in fast/speech/scripted/basics.html

  • Modules/speech/SpeechRecognition.cpp:

(WebCore::SpeechRecognition::start):
(WebCore::SpeechRecognition::SpeechRecognition):

  • Modules/speech/SpeechRecognition.h:

(WebCore::SpeechRecognition::interimResults):
(WebCore::SpeechRecognition::setInterimResults):

  • Modules/speech/SpeechRecognition.idl:
  • Modules/speech/SpeechRecognitionClient.h:

(SpeechRecognitionClient):

  • Modules/speech/SpeechRecognitionController.h:

(WebCore::SpeechRecognitionController::start):

Source/WebKit/chromium:

Plumb interimResults through to Chromium.

  • public/WebSpeechRecognitionParams.h:

(WebKit::WebSpeechRecognitionParams::WebSpeechRecognitionParams):
(WebKit::WebSpeechRecognitionParams::interimResults):
(WebSpeechRecognitionParams):

  • src/SpeechRecognitionClientProxy.cpp:

(WebKit::SpeechRecognitionClientProxy::start):

  • src/SpeechRecognitionClientProxy.h:

(SpeechRecognitionClientProxy):

LayoutTests:

Update test to check for the interimResults attribute.

  • fast/speech/scripted/basics-expected.txt:
  • fast/speech/scripted/basics.html:
11:23 AM Changeset in webkit [130307] by hans@chromium.org
  • 14 edits in trunk

Speech JavaScript API: Remove resultdeleted event
https://bugs.webkit.org/show_bug.cgi?id=98272

Reviewed by Adam Barth.

Source/WebCore:

Remove the resultdeleted event. This was never used, and was removed
from the spec draft in
http://dvcs.w3.org/hg/speech-api/rev/f9d53ab8b449

The fast/speech/scripted/basics.html test is updated to reflect this.

  • Modules/speech/SpeechRecognition.cpp:
  • Modules/speech/SpeechRecognition.h:

(SpeechRecognition):

  • Modules/speech/SpeechRecognition.idl:
  • Modules/speech/SpeechRecognitionEvent.cpp:
  • Modules/speech/SpeechRecognitionEvent.h:

(SpeechRecognitionEvent):

  • dom/EventNames.h:

(WebCore):

Source/WebKit/chromium:

Remove didDeleteResult. This was never used, and has been removed from
the spec draft.

  • public/WebSpeechRecognizerClient.h:
  • src/SpeechRecognitionClientProxy.cpp:
  • src/SpeechRecognitionClientProxy.h:

(SpeechRecognitionClientProxy):

LayoutTests:

Update layout test not to check for onresultdeleted event handler.

  • fast/speech/scripted/basics-expected.txt:
  • fast/speech/scripted/basics.html:
11:15 AM Changeset in webkit [130306] by ojan@chromium.org
  • 3 edits in trunk/Tools

Get rid of warning about non-existant platform name when loading garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=98282

Reviewed by Adam Barth.

If you loaded without a platform query parameter we'd return "null" as the platform name
instead of null.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
11:01 AM Changeset in webkit [130305] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviwed gardening -- adjusted expectations for tiny-layer-rotated.html

  • platform/chromium/TestExpectations:
10:55 AM Changeset in webkit [130304] by caseq@chromium.org
  • 1 edit
    8 adds in trunk/LayoutTests

Unreviewed gardening -- added expectations for 3 time-suggestion-picker-appearance tests.

  • platform/chromium-linux/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-expected.png: Added.
  • platform/chromium-linux/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-rtl-expected.png: Added.
  • platform/chromium-linux/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
  • platform/chromium-win/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-expected.png: Added.
  • platform/chromium-win/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-rtl-expected.png: Added.
  • platform/chromium-win/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
10:51 AM Changeset in webkit [130303] by mhahnenberg@apple.com
  • 62 edits
    2 adds in trunk/Source

Delayed structure sweep can leak structures without bound
https://bugs.webkit.org/show_bug.cgi?id=96546

Reviewed by Geoffrey Garen.

This patch gets rid of the separate Structure allocator in the MarkedSpace and adds two new destructor-only
allocators. We now have separate allocators for our three types of objects: those objects with no destructors,
those objects with destructors and with immortal structures, and those objects with destructors that don't have
immortal structures. All of the objects of the third type (destructors without immortal structures) now
inherit from a new class named JSDestructibleObject (which in turn is a subclass of JSNonFinalObject), which stores
the ClassInfo for these classes at a fixed offset for safe retrieval during sweeping/destruction.

Source/JavaScriptCore:

  • API/JSCallbackConstructor.cpp: Use JSDestructibleObject for JSCallbackConstructor.

(JSC):
(JSC::JSCallbackConstructor::JSCallbackConstructor):

  • API/JSCallbackConstructor.h:

(JSCallbackConstructor):

  • API/JSCallbackObject.cpp: Inherit from JSDestructibleObject for normal JSCallbackObjects and use a finalizer for

JSCallbackObject<JSGlobalObject>, since JSGlobalObject also uses a finalizer.
(JSC):
(JSC::::create): We need to move the create function for JSCallbackObject<JSGlobalObject> out of line so we can add
the finalizer for it. We don't want to add the finalizer is something like finishCreation in case somebody decides
to subclass this. We use this same technique for many other subclasses of JSGlobalObject.
(JSC::::createStructure):

  • API/JSCallbackObject.h:

(JSCallbackObject):
(JSC):

  • API/JSClassRef.cpp: Change all the JSCallbackObject<JSNonFinalObject> to use JSDestructibleObject instead.

(OpaqueJSClass::prototype):

  • API/JSObjectRef.cpp: Ditto.

(JSObjectMake):
(JSObjectGetPrivate):
(JSObjectSetPrivate):
(JSObjectGetPrivateProperty):
(JSObjectSetPrivateProperty):
(JSObjectDeletePrivateProperty):

  • API/JSValueRef.cpp: Ditto.

(JSValueIsObjectOfClass):

  • API/JSWeakObjectMapRefPrivate.cpp: Ditto.
  • JSCTypedArrayStubs.h:

(JSC):

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • dfg/DFGSpeculativeJIT.h: Use the proper allocator type when doing inline allocation in the DFG.

(JSC::DFG::SpeculativeJIT::emitAllocateBasicJSObject):
(JSC::DFG::SpeculativeJIT::emitAllocateJSFinalObject):

  • heap/Heap.cpp:

(JSC):

  • heap/Heap.h: Add accessors for the various types of allocators now. Also remove the isSafeToSweepStructures function

since it's always safe to sweep Structures now.
(JSC::Heap::allocatorForObjectWithNormalDestructor):
(JSC::Heap::allocatorForObjectWithImmortalStructureDestructor):
(Heap):
(JSC::Heap::allocateWithNormalDestructor):
(JSC):
(JSC::Heap::allocateWithImmortalStructureDestructor):

  • heap/IncrementalSweeper.cpp: Remove all the logic to detect when it's safe to sweep Structures from the

IncrementalSweeper since it's always safe to sweep Structures now.
(JSC::IncrementalSweeper::IncrementalSweeper):
(JSC::IncrementalSweeper::sweepNextBlock):
(JSC::IncrementalSweeper::startSweeping):
(JSC::IncrementalSweeper::willFinishSweeping):
(JSC):

  • heap/IncrementalSweeper.h:

(IncrementalSweeper):

  • heap/MarkedAllocator.cpp: Remove the logic that was preventing us from sweeping Structures if it wasn't safe. Add

tracking of the specific destructor type of allocator.
(JSC::MarkedAllocator::tryAllocateHelper):
(JSC::MarkedAllocator::allocateBlock):

  • heap/MarkedAllocator.h:

(JSC::MarkedAllocator::destructorType):
(MarkedAllocator):
(JSC::MarkedAllocator::MarkedAllocator):
(JSC::MarkedAllocator::init):

  • heap/MarkedBlock.cpp: Add all the destructor type stuff to MarkedBlocks so that we do the right thing when sweeping.

We also use the stored destructor type to determine the right thing to do in all JSCell::classInfo() calls.
(JSC::MarkedBlock::create):
(JSC::MarkedBlock::MarkedBlock):
(JSC):
(JSC::MarkedBlock::specializedSweep):
(JSC::MarkedBlock::sweep):
(JSC::MarkedBlock::sweepHelper):

  • heap/MarkedBlock.h:

(JSC):
(JSC::MarkedBlock::allocator):
(JSC::MarkedBlock::destructorType):

  • heap/MarkedSpace.cpp: Add the new destructor allocators to MarkedSpace.

(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::resetAllocators):
(JSC::MarkedSpace::canonicalizeCellLivenessData):
(JSC::MarkedSpace::isPagedOut):
(JSC::MarkedSpace::freeBlock):

  • heap/MarkedSpace.h:

(MarkedSpace):
(JSC::MarkedSpace::immortalStructureDestructorAllocatorFor):
(JSC::MarkedSpace::normalDestructorAllocatorFor):
(JSC::MarkedSpace::allocateWithImmortalStructureDestructor):
(JSC::MarkedSpace::allocateWithNormalDestructor):
(JSC::MarkedSpace::forEachBlock):

  • heap/SlotVisitor.cpp: Add include because the symbol was needed in an inlined function.
  • jit/JIT.h: Make sure we use the correct allocator when doing inline allocations in the baseline JIT.
  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicJSObject):
(JSC::JIT::emitAllocateJSFinalObject):
(JSC::JIT::emitAllocateJSArray):

  • jsc.cpp:

(GlobalObject::create): Add finalizer here since JSGlobalObject needs to use a finalizer instead of inheriting from
JSDestructibleObject.

  • runtime/Arguments.cpp: Inherit from JSDestructibleObject.

(JSC):

  • runtime/Arguments.h:

(Arguments):
(JSC::Arguments::Arguments):

  • runtime/ErrorPrototype.cpp: Added an assert to make sure we have a trivial destructor.

(JSC):

  • runtime/Executable.h: Indicate that all of the Executable* classes have immortal Structures.

(JSC):

  • runtime/InternalFunction.cpp: Inherit from JSDestructibleObject.

(JSC):
(JSC::InternalFunction::InternalFunction):

  • runtime/InternalFunction.h:

(InternalFunction):

  • runtime/JSCell.h: Added two static bools, needsDestruction and hasImmortalStructure, that classes can override

to indicate at compile time which part of the heap they should be allocated in.
(JSC::allocateCell): Use the appropriate allocator depending on the destructor type.

  • runtime/JSDestructibleObject.h: Added. New class that stores the ClassInfo of any subclass so that it can be

accessed safely when the object is being destroyed.
(JSC):
(JSDestructibleObject):
(JSC::JSDestructibleObject::classInfo):
(JSC::JSDestructibleObject::JSDestructibleObject):
(JSC::JSCell::classInfo): Checks the current MarkedBlock to see where it should get the ClassInfo from so that it's always safe.

  • runtime/JSGlobalObject.cpp: JSGlobalObject now uses a finalizer instead of a destructor so that it can avoid forcing all

of its relatives in the inheritance hierarchy (e.g. JSScope) to use destructors as well.
(JSC::JSGlobalObject::reset):

  • runtime/JSGlobalObject.h:

(JSGlobalObject):
(JSC::JSGlobalObject::createRareDataIfNeeded): Since we always create a finalizer now, we don't have to worry about adding one
for the m_rareData field when it's created.
(JSC::JSGlobalObject::create):
(JSC):

  • runtime/JSGlobalThis.h: Inherit from JSDestructibleObject.

(JSGlobalThis):
(JSC::JSGlobalThis::JSGlobalThis):

  • runtime/JSPropertyNameIterator.h: Has an immortal Structure.

(JSC):

  • runtime/JSScope.cpp:

(JSC):

  • runtime/JSString.h: Has an immortal Structure.

(JSC):

  • runtime/JSWrapperObject.h: Inherit from JSDestructibleObject.

(JSWrapperObject):
(JSC::JSWrapperObject::JSWrapperObject):

  • runtime/MathObject.cpp: Cleaning up some of the inheritance stuff.

(JSC):

  • runtime/NameInstance.h: Inherit from JSDestructibleObject.

(NameInstance):

  • runtime/RegExp.h: Has immortal Structure.

(JSC):

  • runtime/RegExpObject.cpp: Inheritance cleanup.

(JSC):

  • runtime/SparseArrayValueMap.h: Has immortal Structure.

(JSC):

  • runtime/Structure.h: Has immortal Structure.

(JSC):

  • runtime/StructureChain.h: Ditto.

(JSC):

  • runtime/SymbolTable.h: Ditto.

(SharedSymbolTable):
(JSC):

Source/WebCore:

No new tests.

  • ForwardingHeaders/runtime/JSDestructableObject.h: Added.
  • bindings/js/JSDOMWrapper.h: Inherits from JSDestructibleObject.

(JSDOMWrapper):
(WebCore::JSDOMWrapper::JSDOMWrapper):

  • bindings/scripts/CodeGeneratorJS.pm: Add finalizers to anything that inherits from JSGlobalObject,

e.g. JSDOMWindow and JSWorkerContexts. For those classes we also need to define needsDestruction as true.
(GenerateHeader):

  • bridge/objc/objc_runtime.h: Inherit from JSDestructibleObject.

(ObjcFallbackObjectImp):

  • bridge/objc/objc_runtime.mm:

(Bindings):
(JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):

  • bridge/runtime_array.cpp: Use a finalizer so that JSArray isn't forced to inherit from JSDestructibleObject.

(JSC):
(JSC::RuntimeArray::destroy):

  • bridge/runtime_array.h:

(JSC::RuntimeArray::create):
(JSC):

  • bridge/runtime_object.cpp: Inherit from JSDestructibleObject.

(Bindings):
(JSC::Bindings::RuntimeObject::RuntimeObject):

  • bridge/runtime_object.h:

(RuntimeObject):

10:47 AM Changeset in webkit [130302] by andersca@apple.com
  • 17 edits in trunk/Source

Change most GraphicsLayer::create calls to use the version that takes a GraphicsLayerFactory
https://bugs.webkit.org/show_bug.cgi?id=98217

Reviewed by Andreas Kling.

Source/WebCore:

  • WebCore.exp.in:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::createGraphicsLayer):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
(WebCore::RenderLayerCompositor::ensureRootLayer):

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::overlayLayer):

Source/WebKit/chromium:

  • src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::NonCompositedContentHost):

Source/WebKit/gtk:

  • WebCoreSupport/AcceleratedCompositingContextGL.cpp:

(WebKit::AcceleratedCompositingContext::initialize):

Source/WebKit/win:

  • WebView.cpp:

(WebView::setAcceleratedCompositing):

Source/WebKit2:

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::createPageOverlayLayer):

  • WebProcess/WebPage/ca/LayerTreeHostCA.cpp:

(WebKit::LayerTreeHostCA::initialize):
(WebKit::LayerTreeHostCA::createPageOverlayLayer):

  • WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::initialize):
(WebKit::LayerTreeHostGtk::createPageOverlayLayer):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):

10:42 AM Changeset in webkit [130301] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Change the reversed expected and actual parameter in WebKit1 unit tests
https://bugs.webkit.org/show_bug.cgi?id=98276

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-10-03
Reviewed by Laszlo Gombos.

Expected value should be at first and actual value be followed in ASSERT_STREQ().

  • tests/test_ewk_view.cpp:

(TEST_F):

10:02 AM Changeset in webkit [130300] by rakuco@webkit.org
  • 59 edits
    2 adds in trunk/LayoutTests

[EFL] Pixel test rebaselines to enable pixel testing on the bots, part 3.

  • platform/efl/fast/media/mq-js-media-except-03-expected.png:
  • platform/efl/fast/media/mq-js-stylesheet-media-01-expected.png:
  • platform/efl/fast/media/mq-js-stylesheet-media-02-expected.png:
  • platform/efl/fast/media/mq-js-stylesheet-media-03-expected.png:
  • platform/efl/fast/media/mq-js-stylesheet-media-04-expected.png:
  • platform/efl/fast/media/mq-orientation-expected.png:
  • platform/efl/fast/media/mq-relative-constraints-02-expected.png:
  • platform/efl/fast/media/mq-relative-constraints-03-expected.png:
  • platform/efl/fast/media/mq-relative-constraints-04-expected.png:
  • platform/efl/fast/media/mq-relative-constraints-05-expected.png:
  • platform/efl/fast/media/mq-relative-constraints-06-expected.png:
  • platform/efl/fast/media/mq-relative-constraints-07-expected.png:
  • platform/efl/fast/media/mq-relative-constraints-08-expected.png:
  • platform/efl/fast/media/mq-relative-constraints-09-expected.png:
  • platform/efl/fast/media/mq-transition-expected.png:
  • platform/efl/fast/media/mq-width-absolute-01-expected.png:
  • platform/efl/fast/media/mq-width-absolute-02-expected.png:
  • platform/efl/fast/media/mq-width-absolute-03-expected.png:
  • platform/efl/fast/media/mq-width-absolute-04-expected.png:
  • platform/efl/fast/media/viewport-media-query-expected.png:
  • platform/efl/fast/overflow/001-expected.png:
  • platform/efl/fast/overflow/002-expected.png:
  • platform/efl/fast/overflow/003-expected.png:
  • platform/efl/fast/overflow/004-expected.png:
  • platform/efl/fast/overflow/006-expected.png:
  • platform/efl/fast/overflow/007-expected.png:
  • platform/efl/fast/overflow/border-radius-clipping-expected.png:
  • platform/efl/fast/overflow/clip-rects-fixed-ancestor-expected.png:
  • platform/efl/fast/overflow/dynamic-hidden-expected.png:
  • platform/efl/fast/overflow/float-in-relpositioned-expected.png:
  • platform/efl/fast/overflow/hit-test-overflow-controls-expected.png:
  • platform/efl/fast/overflow/image-selection-highlight-expected.png:
  • platform/efl/fast/overflow/line-clamp-expected.png:
  • platform/efl/fast/overflow/overflow-auto-table-expected.png:
  • platform/efl/fast/overflow/overflow-focus-ring-expected.png:
  • platform/efl/fast/overflow/overflow-rtl-expected.png:
  • platform/efl/fast/overflow/overflow-rtl-inline-scrollbar-expected.png:
  • platform/efl/fast/overflow/overflow-rtl-vertical-expected.png:
  • platform/efl/fast/overflow/overflow-text-hit-testing-expected.png:
  • platform/efl/fast/overflow/overflow-with-local-background-attachment-expected.png:
  • platform/efl/fast/overflow/scrollbar-position-update-expected.png:
  • platform/efl/fast/overflow/table-overflow-float-expected.png:
  • platform/efl/fast/overflow/unreachable-overflow-rtl-bug-expected.png:
  • platform/efl/fast/reflections/inline-crash-expected.png:
  • platform/efl/fast/reflections/opacity-reflection-transform-expected.png:
  • platform/efl/fast/reflections/reflection-nesting-expected.png:
  • platform/efl/fast/reflections/reflection-with-zoom-expected.png:
  • platform/efl/fast/repaint/add-table-overpaint-expected.png: Added.
  • platform/efl/fast/repaint/background-scaling-expected.png: Added.
  • platform/efl/fast/repaint/backgroundSizeRepaint-expected.png:
  • platform/efl/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
  • platform/efl/fast/repaint/border-radius-repaint-expected.png:
  • platform/efl/fast/repaint/border-repaint-glitch-expected.png:
  • platform/efl/fast/repaint/box-shadow-h-expected.png:
  • platform/efl/fast/repaint/box-shadow-v-expected.png:
  • platform/efl/fast/repaint/bugzilla-3509-expected.png:
  • platform/efl/fast/repaint/bugzilla-5699-expected.png:
  • platform/efl/fast/repaint/bugzilla-6278-expected.png:
  • platform/efl/fast/repaint/bugzilla-6388-expected.png:
  • platform/efl/fast/repaint/bugzilla-6473-expected.png:
10:01 AM Changeset in webkit [130299] by jsbell@chromium.org
  • 2 edits in trunk/Source/WebCore

IndexedDB: Optimize encodeString/decodeString
https://bugs.webkit.org/show_bug.cgi?id=97794

Reviewed by Tony Chang.

Optimize string encoding/decoding, which showed up as a CPU hot spot during profiling.
The backing store uses big-endian ordering of 16-bit code unit strings, so a memcopy
isn't sufficient, but the code used StringBuilder::append() character-by-character
and custom byte-swapping which was slow.

Ran a test w/ DumpRenderTree (to avoid multiprocess overhead) taking a 10k character string
and putting it 20k times and getting it 20k times. On my test box, mean time before the
patch was 8.2s, mean time after the patch was 4.6s.

Tested by Chromium's webkit_unit_tests --gtest_filter='IDBLevelDBCodingTest.*String*'

  • Modules/indexeddb/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::encodeString):
(WebCore::IDBLevelDBCoding::decodeString):

9:50 AM Changeset in webkit [130298] by rakuco@webkit.org
  • 90 edits
    4 adds in trunk/LayoutTests

[EFL] Pixel test rebaselines to enable pixel testing on the bots, part 2.

  • platform/efl/fast/css3-text-decoration: Added.
  • platform/efl/fast/css3-text-decoration/repaint: Added.
  • platform/efl/fast/css3-text-decoration/repaint/repaint-text-decoration-line-expected.png: Added.
  • platform/efl/fast/doctypes/001-expected.png:
  • platform/efl/fast/doctypes/002-expected.png:
  • platform/efl/fast/doctypes/003-expected.png:
  • platform/efl/fast/doctypes/004-expected.png:
  • platform/efl/fast/dynamic/create-renderer-for-whitespace-only-text-expected.png:
  • platform/efl/fast/fast-mobile-scrolling/fixed-position-element-expected.png:
  • platform/efl/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.png:
  • platform/efl/fast/flexbox/002-expected.png:
  • platform/efl/fast/flexbox/003-expected.png:
  • platform/efl/fast/flexbox/004-expected.png:
  • platform/efl/fast/flexbox/005-expected.png:
  • platform/efl/fast/flexbox/006-expected.png:
  • platform/efl/fast/flexbox/007-expected.png:
  • platform/efl/fast/flexbox/008-expected.png:
  • platform/efl/fast/flexbox/009-expected.png:
  • platform/efl/fast/flexbox/010-expected.png:
  • platform/efl/fast/flexbox/011-expected.png:
  • platform/efl/fast/flexbox/012-expected.png:
  • platform/efl/fast/flexbox/016-expected.png:
  • platform/efl/fast/flexbox/017-expected.png:
  • platform/efl/fast/flexbox/018-expected.png:
  • platform/efl/fast/flexbox/019-expected.png:
  • platform/efl/fast/flexbox/020-expected.png:
  • platform/efl/fast/flexbox/021-expected.png:
  • platform/efl/fast/flexbox/022-expected.png:
  • platform/efl/fast/flexbox/023-expected.png:
  • platform/efl/fast/flexbox/024-expected.png:
  • platform/efl/fast/forms/file/file-input-pressed-state-expected.png:
  • platform/efl/fast/forms/input-align-expected.png:
  • platform/efl/fast/forms/input-text-double-click-expected.png:
  • platform/efl/fast/gradients/css3-color-stop-units-expected.png:
  • platform/efl/fast/gradients/css3-color-stops-expected.png:
  • platform/efl/fast/gradients/css3-linear-angle-gradients-expected.png:
  • platform/efl/fast/gradients/css3-linear-right-angle-gradients-expected.png:
  • platform/efl/fast/gradients/css3-radial-gradients-expected.png:
  • platform/efl/fast/gradients/css3-radial-gradients2-expected.png:
  • platform/efl/fast/gradients/css3-repeating-linear-gradients-expected.png:
  • platform/efl/fast/gradients/css3-repeating-radial-gradients-expected.png:
  • platform/efl/fast/gradients/gradient-after-transparent-border-expected.png:
  • platform/efl/fast/html/font-weight-bold-for-b-and-strong-expected.png: Added.
  • platform/efl/fast/images/image-map-anchor-children-expected.png:
  • platform/efl/fast/images/imagemap-case-expected.png:
  • platform/efl/fast/images/imagemap-circle-focus-ring-expected.png:
  • platform/efl/fast/images/imagemap-focus-ring-expected.png:
  • platform/efl/fast/images/imagemap-focus-ring-outline-color-expected.png:
  • platform/efl/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png:
  • platform/efl/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png:
  • platform/efl/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/efl/fast/images/imagemap-polygon-focus-ring-expected.png:
  • platform/efl/fast/inline-block/002-expected.png:
  • platform/efl/fast/inline-block/003-expected.png:
  • platform/efl/fast/inline-block/006-expected.png:
  • platform/efl/fast/inline-block/14498-positionForCoordinates-expected.png:
  • platform/efl/fast/inline-block/overflow-clip-expected.png:
  • platform/efl/fast/inline-block/tricky-baseline-expected.png:
  • platform/efl/fast/inline/001-expected.png:
  • platform/efl/fast/inline/25277-2-expected.png:
  • platform/efl/fast/inline/25277-expected.png:
  • platform/efl/fast/inline/br-text-decoration-expected.png:
  • platform/efl/fast/inline/continuation-outlines-expected.png:
  • platform/efl/fast/inline/drawStyledEmptyInlines-expected.png:
  • platform/efl/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
  • platform/efl/fast/inline/emptyInlinesWithinLists-expected.png:
  • platform/efl/fast/inline/inline-borders-with-bidi-override-expected.png:
  • platform/efl/fast/inline/inline-continuation-borders-expected.png:
  • platform/efl/fast/inline/inline-focus-ring-expected.png:
  • platform/efl/fast/inline/inline-padding-disables-text-quirk-expected.png:
  • platform/efl/fast/inline/inline-text-quirk-bpm-expected.png:
  • platform/efl/fast/inline/inline-wrap-with-parent-padding-expected.png:
  • platform/efl/fast/inline/vertical-align-text-bottom-expected.png:
  • platform/efl/fast/innerHTML/002-expected.png:
  • platform/efl/fast/innerHTML/003-expected.png:
  • platform/efl/fast/innerHTML/006-expected.png:
  • platform/efl/fast/invalid/002-expected.png:
  • platform/efl/fast/invalid/014-expected.png:
  • platform/efl/fast/invalid/016-expected.png:
  • platform/efl/fast/invalid/021-expected.png:
  • platform/efl/fast/invalid/table-inside-stray-table-content-expected.png:
  • platform/efl/fast/layers/inline-dirty-z-order-lists-expected.png:
  • platform/efl/fast/layers/layer-visibility-expected.png:
  • platform/efl/fast/layers/layer-visibility-sublayer-expected.png:
  • platform/efl/fast/layers/normal-flow-hit-test-expected.png:
  • platform/efl/fast/layers/opacity-outline-expected.png:
  • platform/efl/fast/layers/opacity-transforms-expected.png:
  • platform/efl/fast/layers/remove-only-this-layer-update-expected.png:
  • platform/efl/fast/layers/scroll-rect-to-visible-expected.png:
  • platform/efl/fast/media/mq-animation-expected.png:
  • platform/efl/fast/media/mq-aspect-ratio-expected.png:
  • platform/efl/fast/media/mq-js-media-except-01-expected.png:
  • platform/efl/fast/media/mq-js-media-except-02-expected.png:
9:33 AM Changeset in webkit [130297] by rakuco@webkit.org
  • 136 edits
    6 adds in trunk/LayoutTests

[EFL] Update more pixel expectations in preparation for running pixel tests on the bots.

  • platform/efl/css3/flexbox/repaint-rtl-column-expected.png:
  • platform/efl/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/efl/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/efl/fast/block/float/float-not-removed-from-next-sibling4-expected.png:
  • platform/efl/fast/body-propagation/background-color/003-declarative-expected.png:
  • platform/efl/fast/body-propagation/background-color/003-expected.png:
  • platform/efl/fast/body-propagation/background-color/003-xhtml-expected.png:
  • platform/efl/fast/body-propagation/background-color/004-declarative-expected.png:
  • platform/efl/fast/body-propagation/background-color/004-expected.png:
  • platform/efl/fast/body-propagation/background-color/004-xhtml-expected.png:
  • platform/efl/fast/body-propagation/background-color/006-declarative-expected.png:
  • platform/efl/fast/body-propagation/background-color/006-expected.png:
  • platform/efl/fast/body-propagation/background-color/006-xhtml-expected.png:
  • platform/efl/fast/body-propagation/background-color/007-declarative-expected.png:
  • platform/efl/fast/body-propagation/background-color/007-expected.png:
  • platform/efl/fast/body-propagation/background-color/007-xhtml-expected.png:
  • platform/efl/fast/body-propagation/background-image/003-declarative-expected.png:
  • platform/efl/fast/body-propagation/background-image/003-expected.png:
  • platform/efl/fast/body-propagation/background-image/003-xhtml-expected.png:
  • platform/efl/fast/body-propagation/background-image/004-declarative-expected.png:
  • platform/efl/fast/body-propagation/background-image/004-expected.png:
  • platform/efl/fast/body-propagation/background-image/004-xhtml-expected.png:
  • platform/efl/fast/body-propagation/background-image/006-declarative-expected.png:
  • platform/efl/fast/body-propagation/background-image/006-expected.png:
  • platform/efl/fast/body-propagation/background-image/006-xhtml-expected.png:
  • platform/efl/fast/body-propagation/background-image/007-declarative-expected.png:
  • platform/efl/fast/body-propagation/background-image/007-expected.png:
  • platform/efl/fast/body-propagation/background-image/007-xhtml-expected.png:
  • platform/efl/fast/body-propagation/background-image/009-expected.png:
  • platform/efl/fast/body-propagation/background-image/009-xhtml-expected.png:
  • platform/efl/fast/body-propagation/background-image/010-expected.png:
  • platform/efl/fast/body-propagation/background-image/010-xhtml-expected.png:
  • platform/efl/fast/body-propagation/overflow/001-expected.png:
  • platform/efl/fast/body-propagation/overflow/001-xhtml-expected.png:
  • platform/efl/fast/body-propagation/overflow/002-expected.png:
  • platform/efl/fast/body-propagation/overflow/002-xhtml-expected.png:
  • platform/efl/fast/body-propagation/overflow/003-declarative-expected.png:
  • platform/efl/fast/body-propagation/overflow/003-expected.png:
  • platform/efl/fast/body-propagation/overflow/003-xhtml-expected.png:
  • platform/efl/fast/body-propagation/overflow/004-declarative-expected.png:
  • platform/efl/fast/body-propagation/overflow/004-expected.png:
  • platform/efl/fast/body-propagation/overflow/004-xhtml-expected.png:
  • platform/efl/fast/body-propagation/overflow/005-declarative-expected.png:
  • platform/efl/fast/body-propagation/overflow/005-expected.png:
  • platform/efl/fast/body-propagation/overflow/005-xhtml-expected.png:
  • platform/efl/fast/body-propagation/overflow/006-declarative-expected.png:
  • platform/efl/fast/body-propagation/overflow/006-expected.png:
  • platform/efl/fast/body-propagation/overflow/006-xhtml-expected.png:
  • platform/efl/fast/body-propagation/overflow/007-declarative-expected.png:
  • platform/efl/fast/body-propagation/overflow/007-expected.png:
  • platform/efl/fast/body-propagation/overflow/007-xhtml-expected.png:
  • platform/efl/fast/borders/bidi-002-expected.png:
  • platform/efl/fast/borders/bidi-009a-expected.png: Added.
  • platform/efl/fast/borders/bidi-012-expected.png:
  • platform/efl/fast/borders/border-color-inherit-expected.png:
  • platform/efl/fast/borders/border-image-01-expected.png:
  • platform/efl/fast/borders/border-image-border-radius-expected.png:
  • platform/efl/fast/borders/border-image-longhand-expected.png:
  • platform/efl/fast/borders/border-image-massive-scale-expected.png:
  • platform/efl/fast/borders/border-image-outset-expected.png: Added.
  • platform/efl/fast/borders/border-image-outset-in-shorthand-expected.png: Added.
  • platform/efl/fast/borders/border-image-repeat-expected.png:
  • platform/efl/fast/borders/border-image-rotate-transform-expected.png:
  • platform/efl/fast/borders/border-image-scale-transform-expected.png:
  • platform/efl/fast/borders/border-image-scaled-expected.png:
  • platform/efl/fast/borders/border-image-scrambled-expected.png:
  • platform/efl/fast/borders/border-image-side-reduction-expected.png: Added.
  • platform/efl/fast/borders/border-image-slices-expected.png:
  • platform/efl/fast/borders/border-image-source-expected.png:
  • platform/efl/fast/borders/border-radius-complex-inner-expected.png:
  • platform/efl/fast/borders/border-radius-constraints-expected.png:
  • platform/efl/fast/borders/border-radius-huge-assert-expected.png:
  • platform/efl/fast/borders/border-radius-inset-outset-expected.png:
  • platform/efl/fast/borders/border-radius-split-inline-expected.png:
  • platform/efl/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/efl/fast/borders/different-color-borders-expected.png:
  • platform/efl/fast/borders/mixed-border-styles-expected.png:
  • platform/efl/fast/borders/mixed-border-styles-radius-expected.png:
  • platform/efl/fast/borders/mixed-border-styles-radius2-expected.png:
  • platform/efl/fast/borders/outline-alpha-block-expected.png:
  • platform/efl/fast/borders/outline-alpha-inline-expected.png:
  • platform/efl/fast/borders/rtl-border-01-expected.png:
  • platform/efl/fast/borders/rtl-border-02-expected.png:
  • platform/efl/fast/borders/rtl-border-03-expected.png:
  • platform/efl/fast/borders/rtl-border-04-expected.png:
  • platform/efl/fast/borders/rtl-border-05-expected.png:
  • platform/efl/fast/canvas/arc360-expected.png:
  • platform/efl/fast/canvas/canvas-before-css-expected.png:
  • platform/efl/fast/canvas/canvas-composite-expected.png:
  • platform/efl/fast/canvas/canvas-composite-transformclip-expected.png:
  • platform/efl/fast/canvas/canvas-incremental-repaint-expected.png:
  • platform/efl/fast/canvas/canvas-transforms-during-path-expected.png:
  • platform/efl/fast/canvas/canvas-zoom-expected.png:
  • platform/efl/fast/canvas/check-stale-putImageData-expected.png: Added.
  • platform/efl/fast/canvas/drawImage-with-globalAlpha-expected.png:
  • platform/efl/fast/canvas/fillrect-gradient-zero-stops-expected.png:
  • platform/efl/fast/canvas/fillrect_gradient-expected.png:
  • platform/efl/fast/canvas/image-object-in-canvas-expected.png:
  • platform/efl/fast/canvas/patternfill-repeat-expected.png:
  • platform/efl/fast/canvas/quadraticCurveTo-expected.png:
  • platform/efl/fast/canvas/setWidthResetAfterForcedRender-expected.png:
  • platform/efl/fast/canvas/shadow-offset-1-expected.png:
  • platform/efl/fast/canvas/shadow-offset-2-expected.png:
  • platform/efl/fast/canvas/shadow-offset-3-expected.png:
  • platform/efl/fast/canvas/shadow-offset-4-expected.png:
  • platform/efl/fast/canvas/shadow-offset-5-expected.png:
  • platform/efl/fast/canvas/shadow-offset-6-expected.png:
  • platform/efl/fast/canvas/shadow-offset-7-expected.png:
  • platform/efl/fast/canvas/zero-size-fill-rect-expected.png:
  • platform/efl/fast/clip/004-expected.png:
  • platform/efl/fast/clip/005-expected.png:
  • platform/efl/fast/clip/006-expected.png:
  • platform/efl/fast/clip/007-expected.png:
  • platform/efl/fast/clip/009-expected.png:
  • platform/efl/fast/clip/010-expected.png:
  • platform/efl/fast/clip/013-expected.png:
  • platform/efl/fast/clip/014-expected.png:
  • platform/efl/fast/clip/nestedTransparencyClip-expected.png:
  • platform/efl/fast/clip/outline-overflowClip-expected.png:
  • platform/efl/fast/clip/overflow-border-radius-combinations-expected.png:
  • platform/efl/fast/clip/overflow-border-radius-composited-expected.png:
  • platform/efl/fast/clip/overflow-border-radius-fixed-position-expected.png:
  • platform/efl/fast/clip/overflow-border-radius-transformed-expected.png:
  • platform/efl/fast/compact/001-expected.png:
  • platform/efl/fast/compact/002-expected.png:
  • platform/efl/fast/css-generated-content/007-expected.png:
  • platform/efl/fast/css-generated-content/012-expected.png:
  • platform/efl/fast/css-generated-content/016-expected.png:
  • platform/efl/fast/css-generated-content/after-order-expected.png:
  • platform/efl/fast/css-generated-content/before-with-first-letter-expected.png:
  • platform/efl/fast/css-generated-content/beforeAfter-interdocument-expected.png:
  • platform/efl/fast/css-generated-content/hover-style-change-expected.png:
  • platform/efl/fast/css-generated-content/table-before-after-child-add-expected.png:
  • platform/efl/fast/css-generated-content/table-cell-before-after-child-add-expected.png:
  • platform/efl/fast/css-generated-content/table-row-before-after-child-add-expected.png:
  • platform/efl/fast/css-generated-content/table-table-before-after-child-add-expected.png:
  • platform/efl/fast/css-generated-content/wbr-with-before-content-expected.png:
  • platform/efl/fast/css/percent-top-value-with-relative-position-expected.png:
  • platform/efl/media/controls-layout-direction-expected.png:
  • platform/efl/printing/page-rule-in-media-query-expected.png:
  • platform/efl/transitions/suspend-transform-transition-expected.png: Added.
9:19 AM Changeset in webkit [130296] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Skip media/event-queue-crash.html so that its console message does not cause next test to flake.

  • platform/chromium/TestExpectations:
9:18 AM Changeset in webkit [130295] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] [WK2] Unused variable in webkitWebViewLoadChanged
https://bugs.webkit.org/show_bug.cgi?id=98271

Patch by Alberto Garcia <agarcia@igalia.com> on 2012-10-03
Reviewed by Martin Robinson.

Use the priv variable to directly access private attributes
instead of dereferencing webView->priv all the time.
Fixes -Wunused-variable.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewLoadChanged):

8:49 AM Changeset in webkit [130294] by Csaba Osztrogonác
  • 1 edit
    17 adds in trunk/LayoutTests

[Qt] Unreviewed gardening, add expected files for new passing tests.

  • platform/qt/css3/masking/clip-path-circle-expected.png: Added.
  • platform/qt/css3/masking/clip-path-circle-filter-expected.png: Added.
  • platform/qt/css3/masking/clip-path-circle-overflow-expected.png: Added.
  • platform/qt/css3/masking/clip-path-circle-overflow-hidden-expected.png: Added.
  • platform/qt/css3/masking/clip-path-circle-relative-overflow-expected.png: Added.
  • platform/qt/css3/masking/clip-path-ellipse-expected.png: Added.
  • platform/qt/css3/masking/clip-path-polygon-evenodd-expected.png: Added.
  • platform/qt/css3/masking/clip-path-polygon-expected.png: Added.
  • platform/qt/css3/masking/clip-path-polygon-nonzero-expected.png: Added.
  • platform/qt/css3/masking/clip-path-rectangle-expected.png: Added.
  • platform/qt/fast/canvas/canvas-render-layer-expected.png: Added.
  • platform/qt/fast/overflow/paged-x-div-expected.png: Added.
  • platform/qt/fast/overflow/paged-x-div-with-column-gap-expected.png: Added.
  • platform/qt/fast/overflow/paged-x-on-root-expected.png: Added.
  • platform/qt/fast/overflow/paged-x-with-column-gap-expected.png: Added.
  • platform/qt/fast/overflow/paged-y-div-expected.png: Added.
  • platform/qt/fast/overflow/paged-y-on-root-expected.png: Added.
8:42 AM Changeset in webkit [130293] by keishi@webkit.org
  • 16 edits
    1 copy
    14 adds in trunk

Implement DataList UI for input type time on chromium
https://bugs.webkit.org/show_bug.cgi?id=98240

Reviewed by Kent Tamura.

Source/WebCore:

This adds datalist UI for input type time. We add the picker indicator to
BaseMultipleFieldsDateAndTimeInputType. We enclose the dateTimeEdit element
and picker indicator inside a new div element so we can position the picker
indicator in the same place as input type=date.

Tests: platform/chromium/fast/forms/time/time-suggestion-picker-appearance-rtl.html

platform/chromium/fast/forms/time/time-suggestion-picker-appearance-with-scroll-bar.html
platform/chromium/fast/forms/time/time-suggestion-picker-appearance.html
platform/chromium/fast/forms/time/time-suggestion-picker-key-operations.html
platform/chromium/fast/forms/time/time-suggestion-picker-mouse-operations.html

  • css/html.css:

(input::-webkit-date-and-time-container):

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::BaseMultipleFieldsDateAndTimeInputType):
(WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree): Creates a picker indicator.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::handleKeydownEvent): Open the picker on Alt+Down.
(WebCore):
(WebCore::BaseMultipleFieldsDateAndTimeInputType::listAttributeTargetChanged): Updates picker visibility.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::updatePickerIndicatorVisibility): In the future, DateInputType can override
this so the picker indicator is always visible.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::hidePickerIndicator):
(WebCore::BaseMultipleFieldsDateAndTimeInputType::showPickerIndicator):

  • html/BaseMultipleFieldsDateAndTimeInputType.h:

(WebCore):
(BaseMultipleFieldsDateAndTimeInputType):

  • html/shadow/DateTimeFieldElement.cpp:

(WebCore::DateTimeFieldElement::defaultKeyboardEventHandler): Ignore Alt+down because it should trigger the picker to open.

  • rendering/RenderThemeChromiumCommon.cpp:

(WebCore::RenderThemeChromiumCommon::supportsDataListUI): Add time to the list.

LayoutTests:

  • fast/forms/number/number-spinbutton-click-in-iframe.html:
  • fast/forms/resources/common-spinbutton-click-in-iframe.js:

(getSpinButton): This broke because of the change to shadow DOM structure.

  • fast/forms/resources/common.js:

(traverseNextNode):
(getElementByPseudoId): This finds a descendant node with a matching pseudo id.

  • fast/forms/resources/suggestion-picker-common.js: Added.

(highlightedEntry):
(openPicker):
(sendKey):

  • fast/forms/time-multiple-fields/time-multiple-fields-focus-style.html:
  • fast/forms/time-multiple-fields/time-multiple-fields-spinbutton-click-in-iframe.html:
  • platform/chromium-mac/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-expected.png: Added.
  • platform/chromium-mac/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-rtl-expected.png: Added.
  • platform/chromium-mac/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/forms/datalist/input-list-expected.txt:
  • platform/chromium/fast/forms/date/date-suggestion-picker-mouse-operations-expected.txt:
  • platform/chromium/fast/forms/date/date-suggestion-picker-mouse-operations.html:
  • platform/chromium/fast/forms/date/date-suggestion-picker-mouse-operations.html:
  • platform/chromium/fast/forms/time/time-suggestion-picker-appearance-expected.txt: Added.
  • platform/chromium/fast/forms/time/time-suggestion-picker-appearance-rtl-expected.txt: Added.
  • platform/chromium/fast/forms/time/time-suggestion-picker-appearance-rtl.html: Added.
  • platform/chromium/fast/forms/time/time-suggestion-picker-appearance-with-scroll-bar-expected.txt: Added.
  • platform/chromium/fast/forms/time/time-suggestion-picker-appearance-with-scroll-bar.html: Added.
  • platform/chromium/fast/forms/time/time-suggestion-picker-appearance.html: Added.
  • platform/chromium/fast/forms/time/time-suggestion-picker-key-operations-expected.txt: Added.
  • platform/chromium/fast/forms/time/time-suggestion-picker-key-operations.html: Added.
  • platform/chromium/fast/forms/time/time-suggestion-picker-mouse-operations-expected.txt: Added.
  • platform/chromium/fast/forms/time/time-suggestion-picker-mouse-operations.html: Added.
8:39 AM Changeset in webkit [130292] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Give CSSValueList backing vector an inline capacity.
<http://webkit.org/b/98266>
<rdar://problem/12421425>

Reviewed by Anders Carlsson.

Set an inline capacity of 4 on the CSSValue vector backing CSSValueList. This avoids an extra heap allocation
in the common case, and reduces total memory use across the board, since the majority of CSSValueLists have
at least 1 item, and the Vector will bump from 0 to 16 capacity on the first append.

394kB progression on Membuster3.

  • css/CSSValueList.h:

(CSSValueList):

8:36 AM Changeset in webkit [130291] by Csaba Osztrogonác
  • 37 edits
    28 adds in trunk/LayoutTests

[Qt] Enable mock scrollbars
https://bugs.webkit.org/show_bug.cgi?id=98011

Unreviewed gardening, update expected files after enabling mock scrollbars. (r130283)

  • platform/qt-5.0-wk2/compositing/columns/composited-in-paginated-expected.txt:
  • platform/qt-5.0-wk2/compositing/direct-image-compositing-expected.png:
  • platform/qt-5.0-wk2/compositing/direct-image-compositing-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/geometry/fixed-in-composited-expected.png:
  • platform/qt-5.0-wk2/compositing/geometry/fixed-in-composited-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/geometry/video-fixed-scrolling-expected.png:
  • platform/qt-5.0-wk2/compositing/geometry/video-fixed-scrolling-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/become-composited-nested-iframes-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/become-overlapped-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/composited-parent-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe2-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe3-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/enter-compositing-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/iframe-copy-on-scroll-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/iframes/iframe-copy-on-scroll-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/iframe-in-composited-layer-expected.png:
  • platform/qt-5.0-wk2/compositing/iframes/iframe-in-composited-layer-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/iframe-resize-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/overlapped-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/overlapped-nested-iframes-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/resizer-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/scrolling-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-and-transform-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-and-transform-expected.txt:
  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-out-of-view-expected.txt:
  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-under-transform-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-under-transform-expected.txt:
  • platform/qt-5.0-wk2/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/masks/masked-ancestor-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/masks/masked-ancestor-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/masks/multiple-masks-expected.png:
  • platform/qt-5.0-wk2/compositing/masks/multiple-masks-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/masks/simple-composited-mask-expected.png:
  • platform/qt-5.0-wk2/compositing/masks/simple-composited-mask-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/overflow/content-gains-scrollbars-expected.txt:
  • platform/qt-5.0-wk2/compositing/overflow/overflow-scroll-expected.png:
  • platform/qt-5.0-wk2/compositing/overflow/overflow-scroll-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/overflow/overflow-scrollbar-layers-expected.txt:
  • platform/qt-5.0-wk2/compositing/overflow/scroll-ancestor-update-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/overflow/scroll-ancestor-update-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/overflow/scrollbar-painting-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/overflow/scrollbar-painting-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/repaint/newly-composited-on-scroll-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/repaint/newly-composited-on-scroll-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-absolute-overflow-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-absolute-overflow-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-scrolled-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
  • platform/qt-5.0-wk2/compositing/self-painting-layers-expected.png:
  • platform/qt-5.0-wk2/compositing/self-painting-layers-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/tiled-layers-hidpi-expected.txt:
8:20 AM Changeset in webkit [130290] by rakuco@webkit.org
  • 78 edits
    1 add in trunk/LayoutTests

[EFL] Rebaseline pixel expectations for scrollbars/ and tables/mozilla_expected_failures/.

  • platform/efl/scrollbars/scrollbars-on-positioned-content-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug1010-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug101759-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug1128-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug11331-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug1164-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug11945-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug1262-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug14007-1-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug14489-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug17826-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug18770-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug19526-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug21518-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug22122-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug24880-1-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug25707-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug27993-2-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3105-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-1-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-10-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-15-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-18-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-7-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-8-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug32205-4-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug33784-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug42043-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug4294-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug45621-expected.png: Added.
  • platform/efl/tables/mozilla_expected_failures/bugs/bug46268-4-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug47163-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug51000-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug56024-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug61042-1-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug61042-2-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug65372-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug67915-2-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug7113-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug73629-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug8499-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug9879-1-expected.png:
  • platform/efl/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
  • platform/efl/tables/mozilla_expected_failures/core/backgrounds-expected.png:
  • platform/efl/tables/mozilla_expected_failures/core/col_span2-expected.png:
  • platform/efl/tables/mozilla_expected_failures/core/cols1-expected.png:
  • platform/efl/tables/mozilla_expected_failures/core/columns-expected.png:
  • platform/efl/tables/mozilla_expected_failures/core/conflicts-expected.png:
  • platform/efl/tables/mozilla_expected_failures/dom/appendCells1-expected.png:
  • platform/efl/tables/mozilla_expected_failures/dom/appendCellsRebuild1-expected.png:
  • platform/efl/tables/mozilla_expected_failures/dom/appendCol1-expected.png:
  • platform/efl/tables/mozilla_expected_failures/dom/appendColGroup1-expected.png:
  • platform/efl/tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.png:
  • platform/efl/tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_frame_above-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_frame_below-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_frame_hsides-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_frame_void-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/tables_cellspacing_pct-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_colgroup_width_px-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_above-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_below-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_border-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_box-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_hsides-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_lhs-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_rhs-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_vsides-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_table_rules_all-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_table_rules_cols-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_table_rules_rows-expected.png:
  • platform/efl/tables/mozilla_expected_failures/other/empty_cells-expected.png:
7:51 AM Changeset in webkit [130289] by loislo@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: NMI: instrument NativeImageSkia.
https://bugs.webkit.org/show_bug.cgi?id=96277

Reviewed by Yury Semikhatsky.

  • platform/graphics/skia/NativeImageSkia.cpp:

(WebCore::NativeImageSkia::reportMemoryUsage):
(WebCore::reportMemoryUsage):

7:46 AM Changeset in webkit [130288] by pfeldman@chromium.org
  • 16 edits
    1 add in trunk/Source/WebCore

Web Inspector: remember the last dock option so that user could toggle between dock to bottom and right
https://bugs.webkit.org/show_bug.cgi?id=98255

Reviewed by Vsevolod Vlasov.

  • Introduced DockController.js that covers the dock mechanics
  • Removed dock orientation from the settings
  • Storing the last dock option to present it as default
  • Simplified the multi-option status bar button
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/DockController.js: Added.

(WebInspector.DockController):
(WebInspector.DockController.prototype.get element):
(WebInspector.DockController.prototype.setDocked.set if):
(WebInspector.DockController.prototype.setDocked):
(WebInspector.DockController.prototype.setDockingUnavailable):
(WebInspector.DockController.prototype._updateUI.get states):
(WebInspector.DockController.prototype._updateUI):
(WebInspector.DockController.prototype._decorateButtonForTargetState):
(WebInspector.DockController.prototype._createDockOptions):
(WebInspector.DockController.prototype._toggleDockState):
(WebInspector.DockController.prototype.isCompactMode):
(WebInspector.DockController.prototype.setCompactMode):

  • inspector/front-end/InspectorFrontendAPI.js:

(InspectorFrontendAPI.setAttachedWindow):

  • inspector/front-end/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.requestAttachWindow):
(.WebInspector.InspectorFrontendHostStub.prototype.requestDetachWindow):

  • inspector/front-end/Settings.js:
  • inspector/front-end/SettingsScreen.js:

(WebInspector.GenericSettingsTab):

  • inspector/front-end/StatusBarButton.js:

(WebInspector.StatusBarButton):

  • inspector/front-end/Toolbar.js:

(WebInspector.Toolbar):
(WebInspector.Toolbar.prototype.setCompactMode):
(WebInspector.Toolbar.prototype._toolbarDragStart):
(WebInspector.Toolbar.prototype._toolbarDrag):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/externs.js:

(WebInspector.toggleSearchingForNode):

  • inspector/front-end/inspector.css:

(body.undocked.platform-mac-snowleopard #toolbar):
(body.undocked.platform-mac-snowleopard #toolbar-dropdown):

  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

(WebInspector._createGlobalStatusBarItems):
(windowLoaded):
(WebInspector.setDockingUnavailable):

  • inspector/front-end/inspectorCommon.css:

(body.dock-to-right:not(.undocked)):
(body.dock-to-right.inactive:not(.undocked)):

7:37 AM Changeset in webkit [130287] by vsevik@chromium.org
  • 7 edits
    1 add in trunk

Web Inspector: UISourceCode commitWorkingCopy should not fail when original script had syntax error.
https://bugs.webkit.org/show_bug.cgi?id=97272

Reviewed by Pavel Feldman.

This patch is based on patch by John J. Barton.

Source/WebCore:

  • inspector/front-end/JavaScriptSource.js:

(WebInspector.JavaScriptSource.prototype.workingCopyCommitted): added rawLocation null check.

LayoutTests:

  • http/tests/inspector/live-edit-test.js:

(initialize_LiveEditTest.InspectorTest.replaceInSource):
(initialize_LiveEditTest):

  • inspector/debugger/live-edit-expected.txt:
  • inspector/debugger/live-edit.html:
  • inspector/debugger/resources/edit-me-syntax-error.js: Added.

(syntaxError):

  • platform/chromium/TestExpectations: re-enabled the test.
7:34 AM Changeset in webkit [130286] by Csaba Osztrogonác
  • 1171 edits
    67 adds
    20 deletes in trunk/LayoutTests

[Qt] Enable mock scrollbars
https://bugs.webkit.org/show_bug.cgi?id=98011

Unreviewed gardening, update expected files after enabling mock scrollbars.

  • platform/qt-5.0-wk2/fast/text/large-text-composed-char-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/text/large-text-composed-char-expected.txt: Removed.
  • platform/qt-5.0/fast/forms/form-element-geometry-expected.png: Removed.
  • platform/qt-5.0/fast/forms/form-element-geometry-expected.txt: Removed.
  • platform/qt-5.0/fast/forms/listbox-bidi-align-expected.txt: Removed.
  • platform/qt-5.0/fast/forms/textarea-align-expected.png: Removed.
  • platform/qt-5.0/fast/forms/textarea-align-expected.txt: Removed.
  • platform/qt-5.0/fast/forms/textarea-setinnerhtml-expected.png: Removed.
  • platform/qt-5.0/fast/forms/textarea-setinnerhtml-expected.txt: Removed.
  • platform/qt-5.0/fast/table/003-expected.png: Removed.
  • platform/qt-5.0/fast/table/003-expected.txt: Removed.
  • platform/qt-5.0/fast/table/border-collapsing/004-expected.txt: Removed.
  • platform/qt-5.0/fast/text/backslash-to-yen-sign-euc-expected.txt: Removed.
  • platform/qt-5.0/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt: Removed.
  • platform/qt-5.0/fast/text/large-text-composed-char-expected.png: Removed.
  • platform/qt-5.0/fast/text/large-text-composed-char-expected.txt: Removed.
  • platform/qt-5.0/fast/text/softHyphen-expected.txt: Removed.
  • platform/qt-5.0/fast/text/text-letter-spacing-expected.txt: Removed.
  • platform/qt-5.0/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Removed.
  • platform/qt-5.0/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Removed.
  • platform/qt/compositing/overflow/clipping-ancestor-with-accelerated-scrolling-ancestor-expected.txt: Added.
  • platform/qt/compositing/overflow/nested-scrolling-expected.txt: Added.
  • platform/qt/compositing/overflow/overflow-clip-with-accelerated-scrolling-ancestor-expected.txt: Added.
  • platform/qt/compositing/overflow/remove-overflow-crash2-expected.txt: Added.
  • platform/qt/css1/basic/comments-expected.png:
  • platform/qt/css1/basic/comments-expected.txt:
  • platform/qt/css1/basic/containment-expected.png:
  • platform/qt/css1/basic/containment-expected.txt:
  • platform/qt/css1/basic/id_as_selector-expected.png:
  • platform/qt/css1/basic/id_as_selector-expected.txt:
  • platform/qt/css1/basic/inheritance-expected.png:
  • platform/qt/css1/basic/inheritance-expected.txt:
  • platform/qt/css1/box_properties/border-expected.png:
  • platform/qt/css1/box_properties/border-expected.txt:
  • platform/qt/css1/box_properties/border_bottom-expected.png:
  • platform/qt/css1/box_properties/border_bottom-expected.txt:
  • platform/qt/css1/box_properties/border_bottom_width-expected.png:
  • platform/qt/css1/box_properties/border_bottom_width-expected.txt:
  • platform/qt/css1/box_properties/border_left-expected.png:
  • platform/qt/css1/box_properties/border_left-expected.txt:
  • platform/qt/css1/box_properties/border_left_width-expected.png:
  • platform/qt/css1/box_properties/border_left_width-expected.txt:
  • platform/qt/css1/box_properties/border_right_inline-expected.png:
  • platform/qt/css1/box_properties/border_right_inline-expected.txt:
  • platform/qt/css1/box_properties/border_right_width-expected.png:
  • platform/qt/css1/box_properties/border_right_width-expected.txt:
  • platform/qt/css1/box_properties/border_style-expected.png:
  • platform/qt/css1/box_properties/border_style-expected.txt:
  • platform/qt/css1/box_properties/border_top-expected.png:
  • platform/qt/css1/box_properties/border_top-expected.txt:
  • platform/qt/css1/box_properties/border_top_width-expected.png:
  • platform/qt/css1/box_properties/border_top_width-expected.txt:
  • platform/qt/css1/box_properties/border_width-expected.png:
  • platform/qt/css1/box_properties/border_width-expected.txt:
  • platform/qt/css1/box_properties/clear-expected.png:
  • platform/qt/css1/box_properties/clear-expected.txt:
  • platform/qt/css1/box_properties/clear_float-expected.png:
  • platform/qt/css1/box_properties/clear_float-expected.txt:
  • platform/qt/css1/box_properties/float_elements_in_series-expected.png:
  • platform/qt/css1/box_properties/float_elements_in_series-expected.txt:
  • platform/qt/css1/box_properties/float_margin-expected.png:
  • platform/qt/css1/box_properties/float_margin-expected.txt:
  • platform/qt/css1/box_properties/float_on_text_elements-expected.png:
  • platform/qt/css1/box_properties/float_on_text_elements-expected.txt:
  • platform/qt/css1/box_properties/height-expected.png:
  • platform/qt/css1/box_properties/height-expected.txt:
  • platform/qt/css1/box_properties/margin-expected.png:
  • platform/qt/css1/box_properties/margin-expected.txt:
  • platform/qt/css1/box_properties/margin_bottom-expected.png:
  • platform/qt/css1/box_properties/margin_bottom-expected.txt:
  • platform/qt/css1/box_properties/margin_inline-expected.png:
  • platform/qt/css1/box_properties/margin_inline-expected.txt:
  • platform/qt/css1/box_properties/margin_left-expected.png:
  • platform/qt/css1/box_properties/margin_left-expected.txt:
  • platform/qt/css1/box_properties/margin_right-expected.png:
  • platform/qt/css1/box_properties/margin_right-expected.txt:
  • platform/qt/css1/box_properties/margin_top-expected.png:
  • platform/qt/css1/box_properties/margin_top-expected.txt:
  • platform/qt/css1/box_properties/padding-expected.png:
  • platform/qt/css1/box_properties/padding-expected.txt:
  • platform/qt/css1/box_properties/padding_bottom-expected.png:
  • platform/qt/css1/box_properties/padding_bottom-expected.txt:
  • platform/qt/css1/box_properties/padding_inline-expected.png:
  • platform/qt/css1/box_properties/padding_inline-expected.txt:
  • platform/qt/css1/box_properties/padding_left-expected.png:
  • platform/qt/css1/box_properties/padding_left-expected.txt:
  • platform/qt/css1/box_properties/padding_right-expected.png:
  • platform/qt/css1/box_properties/padding_right-expected.txt:
  • platform/qt/css1/box_properties/padding_top-expected.png:
  • platform/qt/css1/box_properties/padding_top-expected.txt:
  • platform/qt/css1/box_properties/width-expected.png:
  • platform/qt/css1/box_properties/width-expected.txt:
  • platform/qt/css1/cascade/cascade_order-expected.png:
  • platform/qt/css1/cascade/cascade_order-expected.txt:
  • platform/qt/css1/classification/display-expected.png:
  • platform/qt/css1/classification/display-expected.txt:
  • platform/qt/css1/classification/list_style_type-expected.png:
  • platform/qt/css1/classification/list_style_type-expected.txt:
  • platform/qt/css1/classification/white_space-expected.png:
  • platform/qt/css1/classification/white_space-expected.txt:
  • platform/qt/css1/color_and_background/background-expected.png:
  • platform/qt/css1/color_and_background/background-expected.txt:
  • platform/qt/css1/color_and_background/background_attachment-expected.png:
  • platform/qt/css1/color_and_background/background_attachment-expected.txt:
  • platform/qt/css1/color_and_background/background_position-expected.png:
  • platform/qt/css1/color_and_background/background_position-expected.txt:
  • platform/qt/css1/color_and_background/background_repeat-expected.png:
  • platform/qt/css1/color_and_background/background_repeat-expected.txt:
  • platform/qt/css1/conformance/forward_compatible_parsing-expected.png:
  • platform/qt/css1/conformance/forward_compatible_parsing-expected.txt:
  • platform/qt/css1/font_properties/font-expected.png:
  • platform/qt/css1/font_properties/font-expected.txt:
  • platform/qt/css1/font_properties/font_family-expected.png:
  • platform/qt/css1/font_properties/font_family-expected.txt:
  • platform/qt/css1/font_properties/font_size-expected.png:
  • platform/qt/css1/font_properties/font_size-expected.txt:
  • platform/qt/css1/font_properties/font_weight-expected.png:
  • platform/qt/css1/font_properties/font_weight-expected.txt:
  • platform/qt/css1/formatting_model/height_of_lines-expected.png:
  • platform/qt/css1/formatting_model/height_of_lines-expected.txt:
  • platform/qt/css1/formatting_model/horizontal_formatting-expected.png:
  • platform/qt/css1/formatting_model/horizontal_formatting-expected.txt:
  • platform/qt/css1/formatting_model/inline_elements-expected.png:
  • platform/qt/css1/formatting_model/inline_elements-expected.txt:
  • platform/qt/css1/formatting_model/replaced_elements-expected.png:
  • platform/qt/css1/formatting_model/replaced_elements-expected.txt:
  • platform/qt/css1/formatting_model/vertical_formatting-expected.png:
  • platform/qt/css1/formatting_model/vertical_formatting-expected.txt:
  • platform/qt/css1/pseudo/anchor-expected.png:
  • platform/qt/css1/pseudo/anchor-expected.txt:
  • platform/qt/css1/pseudo/firstletter-expected.png:
  • platform/qt/css1/pseudo/firstletter-expected.txt:
  • platform/qt/css1/pseudo/firstline-expected.png:
  • platform/qt/css1/pseudo/firstline-expected.txt:
  • platform/qt/css1/pseudo/multiple_pseudo_elements-expected.png:
  • platform/qt/css1/pseudo/multiple_pseudo_elements-expected.txt:
  • platform/qt/css1/text_properties/letter_spacing-expected.png:
  • platform/qt/css1/text_properties/letter_spacing-expected.txt:
  • platform/qt/css1/text_properties/line_height-expected.png:
  • platform/qt/css1/text_properties/line_height-expected.txt:
  • platform/qt/css1/text_properties/text_decoration-expected.png:
  • platform/qt/css1/text_properties/text_decoration-expected.txt:
  • platform/qt/css1/text_properties/text_indent-expected.png:
  • platform/qt/css1/text_properties/text_indent-expected.txt:
  • platform/qt/css1/text_properties/text_transform-expected.png:
  • platform/qt/css1/text_properties/text_transform-expected.txt:
  • platform/qt/css1/text_properties/vertical_align-expected.png:
  • platform/qt/css1/text_properties/vertical_align-expected.txt:
  • platform/qt/css1/text_properties/word_spacing-expected.png:
  • platform/qt/css1/text_properties/word_spacing-expected.txt:
  • platform/qt/css1/units/color_units-expected.png:
  • platform/qt/css1/units/color_units-expected.txt:
  • platform/qt/css1/units/length_units-expected.png:
  • platform/qt/css1/units/length_units-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-height-007-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-height-014-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-height-021-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-height-028-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-height-035-expected.txt:
  • platform/qt/css2.1/20110323/abspos-containing-block-initial-001-expected.png: Added.
  • platform/qt/css2.1/20110323/abspos-containing-block-initial-001-expected.txt:
  • platform/qt/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Added.
  • platform/qt/css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Added.
  • platform/qt/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png:
  • platform/qt/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt:
  • platform/qt/css2.1/20110323/abspos-replaced-width-margin-000-expected.png:
  • platform/qt/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-height-002-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-height-002-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-height-004-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-height-004-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-height-006-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-height-006-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-height-008-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-height-008-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-height-010-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-height-010-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-height-012-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-height-012-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-height-014-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-height-014-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-height-016-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-height-016-expected.txt:
  • platform/qt/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png:
  • platform/qt/css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt:
  • platform/qt/css2.1/t0803-c5502-mrgn-r-02-c-expected.png:
  • platform/qt/css2.1/t0803-c5502-mrgn-r-02-c-expected.txt:
  • platform/qt/css2.1/t0803-c5505-mrgn-02-c-expected.png:
  • platform/qt/css2.1/t0803-c5505-mrgn-02-c-expected.txt:
  • platform/qt/css2.1/t080301-c411-vt-mrgn-00-b-expected.png:
  • platform/qt/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltclr-00-c-ag-expected.png:
  • platform/qt/css2.1/t0905-c5525-fltclr-00-c-ag-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.png:
  • platform/qt/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/qt/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/qt/css2.1/t0905-c5526-fltclr-00-c-ag-expected.png:
  • platform/qt/css2.1/t0905-c5526-fltclr-00-c-ag-expected.txt:
  • platform/qt/css2.1/t1002-c5523-width-02-b-g-expected.png:
  • platform/qt/css2.1/t1002-c5523-width-02-b-g-expected.txt:
  • platform/qt/css2.1/t1202-counters-08-b-expected.png:
  • platform/qt/css2.1/t1202-counters-08-b-expected.txt:
  • platform/qt/css2.1/t140201-c535-bg-fixd-00-b-g-expected.png:
  • platform/qt/css2.1/t140201-c535-bg-fixd-00-b-g-expected.txt:
  • platform/qt/css2.1/t140201-c537-bgfxps-00-c-ag-expected.png:
  • platform/qt/css2.1/t140201-c537-bgfxps-00-c-ag-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-07-b-expected.png:
  • platform/qt/css2.1/t1508-c527-font-07-b-expected.txt:
  • platform/qt/css3/masking/clip-path-circle-expected.txt: Added.
  • platform/qt/css3/masking/clip-path-circle-filter-expected.txt: Added.
  • platform/qt/css3/masking/clip-path-circle-overflow-expected.txt: Added.
  • platform/qt/css3/masking/clip-path-circle-overflow-hidden-expected.txt: Added.
  • platform/qt/css3/masking/clip-path-circle-relative-overflow-expected.txt: Added.
  • platform/qt/css3/masking/clip-path-ellipse-expected.txt: Added.
  • platform/qt/css3/masking/clip-path-polygon-evenodd-expected.txt: Added.
  • platform/qt/css3/masking/clip-path-polygon-expected.txt: Added.
  • platform/qt/css3/masking/clip-path-polygon-nonzero-expected.txt: Added.
  • platform/qt/css3/masking/clip-path-rectangle-expected.txt: Added.
  • platform/qt/editing/deleting/delete-after-span-ws-001-expected.png:
  • platform/qt/editing/deleting/delete-after-span-ws-001-expected.txt:
  • platform/qt/editing/deleting/delete-after-span-ws-002-expected.png:
  • platform/qt/editing/deleting/delete-after-span-ws-002-expected.txt:
  • platform/qt/editing/deleting/delete-after-span-ws-003-expected.png:
  • platform/qt/editing/deleting/delete-after-span-ws-003-expected.txt:
  • platform/qt/editing/deleting/delete-line-end-ws-001-expected.png:
  • platform/qt/editing/deleting/delete-line-end-ws-001-expected.txt:
  • platform/qt/editing/deleting/delete-line-end-ws-002-expected.png:
  • platform/qt/editing/deleting/delete-line-end-ws-002-expected.txt:
  • platform/qt/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
  • platform/qt/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt:
  • platform/qt/editing/input/reveal-caret-of-multiline-input-expected.png:
  • platform/qt/editing/input/reveal-caret-of-multiline-input-expected.txt:
  • platform/qt/editing/inserting/4960120-1-expected.png:
  • platform/qt/editing/inserting/4960120-1-expected.txt:
  • platform/qt/editing/inserting/insert-div-023-expected.png:
  • platform/qt/editing/inserting/insert-div-023-expected.txt:
  • platform/qt/editing/selection/focus_editable_html-expected.png:
  • platform/qt/editing/selection/focus_editable_html-expected.txt:
  • platform/qt/editing/selection/iframe-expected.png:
  • platform/qt/editing/selection/iframe-expected.txt:
  • platform/qt/editing/selection/select-all-001-expected.png:
  • platform/qt/editing/selection/select-all-001-expected.txt:
  • platform/qt/editing/selection/select-all-002-expected.png:
  • platform/qt/editing/selection/select-all-002-expected.txt:
  • platform/qt/editing/selection/select-all-003-expected.png:
  • platform/qt/editing/selection/select-all-003-expected.txt:
  • platform/qt/editing/selection/select-all-004-expected.png:
  • platform/qt/editing/selection/select-all-004-expected.txt:
  • platform/qt/editing/selection/unrendered-001-expected.png:
  • platform/qt/editing/selection/unrendered-001-expected.txt:
  • platform/qt/editing/selection/unrendered-002-expected.png:
  • platform/qt/editing/selection/unrendered-002-expected.txt:
  • platform/qt/editing/selection/unrendered-003-expected.png:
  • platform/qt/editing/selection/unrendered-003-expected.txt:
  • platform/qt/editing/selection/unrendered-004-expected.png:
  • platform/qt/editing/selection/unrendered-004-expected.txt:
  • platform/qt/editing/selection/unrendered-005-expected.png:
  • platform/qt/editing/selection/unrendered-005-expected.txt:
  • platform/qt/fast/backgrounds/background-inherit-color-bug-expected.png:
  • platform/qt/fast/backgrounds/background-inherit-color-bug-expected.txt:
  • platform/qt/fast/backgrounds/background-leakage-transforms-expected.png:
  • platform/qt/fast/backgrounds/background-leakage-transforms-expected.txt:
  • platform/qt/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/qt/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.txt:
  • platform/qt/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/qt/fast/backgrounds/size/backgroundSize15-expected.txt:
  • platform/qt/fast/block/basic/016-expected.png:
  • platform/qt/fast/block/basic/016-expected.txt:
  • platform/qt/fast/block/basic/truncation-rtl-expected.png:
  • platform/qt/fast/block/basic/truncation-rtl-expected.txt:
  • platform/qt/fast/block/float/008-expected.png:
  • platform/qt/fast/block/float/008-expected.txt: Added.
  • platform/qt/fast/block/float/013-expected.png:
  • platform/qt/fast/block/float/013-expected.txt:
  • platform/qt/fast/block/float/019-expected.png:
  • platform/qt/fast/block/float/019-expected.txt: Added.
  • platform/qt/fast/block/float/021-expected.png:
  • platform/qt/fast/block/float/021-expected.txt:
  • platform/qt/fast/block/float/025-expected.png:
  • platform/qt/fast/block/float/025-expected.txt:
  • platform/qt/fast/block/float/027-expected.png:
  • platform/qt/fast/block/float/027-expected.txt:
  • platform/qt/fast/block/float/032-expected.png:
  • platform/qt/fast/block/float/032-expected.txt:
  • platform/qt/fast/block/float/033-expected.png:
  • platform/qt/fast/block/float/033-expected.txt:
  • platform/qt/fast/block/float/035-expected.png:
  • platform/qt/fast/block/float/035-expected.txt: Added.
  • platform/qt/fast/block/float/avoidance-percent-width-strict-expected.png:
  • platform/qt/fast/block/float/avoidance-percent-width-strict-expected.txt:
  • platform/qt/fast/block/float/br-with-clear-2-expected.png:
  • platform/qt/fast/block/float/br-with-clear-2-expected.txt:
  • platform/qt/fast/block/float/centered-float-avoidance-complexity-expected.png:
  • platform/qt/fast/block/float/centered-float-avoidance-complexity-expected.txt:
  • platform/qt/fast/block/float/float-avoidance-expected.png:
  • platform/qt/fast/block/float/float-avoidance-expected.txt:
  • platform/qt/fast/block/float/nested-clearance-expected.png:
  • platform/qt/fast/block/float/nested-clearance-expected.txt:
  • platform/qt/fast/block/float/overhanging-tall-block-expected.png:
  • platform/qt/fast/block/float/overhanging-tall-block-expected.txt:
  • platform/qt/fast/block/float/relative-painted-twice-expected.png:
  • platform/qt/fast/block/float/relative-painted-twice-expected.txt: Added.
  • platform/qt/fast/block/float/shrink-to-avoid-float-complexity-expected.png:
  • platform/qt/fast/block/float/shrink-to-avoid-float-complexity-expected.txt:
  • platform/qt/fast/block/lineboxcontain/parsing-invalid-expected.png:
  • platform/qt/fast/block/lineboxcontain/parsing-invalid-expected.txt:
  • platform/qt/fast/block/margin-collapse/103-expected.png:
  • platform/qt/fast/block/margin-collapse/103-expected.txt:
  • platform/qt/fast/block/margin-collapse/104-expected.png:
  • platform/qt/fast/block/margin-collapse/104-expected.txt:
  • platform/qt/fast/block/margin-collapse/empty-clear-blocks-expected.png:
  • platform/qt/fast/block/margin-collapse/empty-clear-blocks-expected.txt:
  • platform/qt/fast/block/positioning/047-expected.png:
  • platform/qt/fast/block/positioning/047-expected.txt:
  • platform/qt/fast/block/positioning/051-expected.png:
  • platform/qt/fast/block/positioning/051-expected.txt:
  • platform/qt/fast/block/positioning/055-expected.png:
  • platform/qt/fast/block/positioning/055-expected.txt:
  • platform/qt/fast/block/positioning/auto/007-expected.png:
  • platform/qt/fast/block/positioning/auto/007-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-lr/005-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-lr/005-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-lr/007-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-lr/007-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-rl/005-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-rl/005-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-rl/007-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-rl/007-expected.txt:
  • platform/qt/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.png:
  • platform/qt/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.txt:
  • platform/qt/fast/block/positioning/negative-rel-position-expected.png:
  • platform/qt/fast/block/positioning/negative-rel-position-expected.txt: Added.
  • platform/qt/fast/block/positioning/relative-overflow-block-expected.png:
  • platform/qt/fast/block/positioning/relative-overflow-block-expected.txt:
  • platform/qt/fast/block/positioning/relative-overflow-replaced-expected.png:
  • platform/qt/fast/block/positioning/relative-overflow-replaced-expected.txt:
  • platform/qt/fast/block/positioning/relative-overflow-replaced-float-expected.png:
  • platform/qt/fast/block/positioning/relative-overflow-replaced-float-expected.txt:
  • platform/qt/fast/body-propagation/overflow/001-expected.png:
  • platform/qt/fast/body-propagation/overflow/001-expected.txt:
  • platform/qt/fast/body-propagation/overflow/001-xhtml-expected.png:
  • platform/qt/fast/body-propagation/overflow/001-xhtml-expected.txt:
  • platform/qt/fast/body-propagation/overflow/002-expected.png:
  • platform/qt/fast/body-propagation/overflow/002-expected.txt:
  • platform/qt/fast/body-propagation/overflow/002-xhtml-expected.png:
  • platform/qt/fast/body-propagation/overflow/002-xhtml-expected.txt:
  • platform/qt/fast/body-propagation/overflow/003-declarative-expected.png:
  • platform/qt/fast/body-propagation/overflow/003-declarative-expected.txt:
  • platform/qt/fast/body-propagation/overflow/003-expected.png:
  • platform/qt/fast/body-propagation/overflow/003-expected.txt:
  • platform/qt/fast/body-propagation/overflow/003-xhtml-expected.png:
  • platform/qt/fast/body-propagation/overflow/003-xhtml-expected.txt:
  • platform/qt/fast/body-propagation/overflow/004-declarative-expected.png:
  • platform/qt/fast/body-propagation/overflow/004-declarative-expected.txt:
  • platform/qt/fast/body-propagation/overflow/004-expected.png:
  • platform/qt/fast/body-propagation/overflow/004-expected.txt:
  • platform/qt/fast/body-propagation/overflow/004-xhtml-expected.png:
  • platform/qt/fast/body-propagation/overflow/004-xhtml-expected.txt:
  • platform/qt/fast/body-propagation/overflow/005-declarative-expected.png:
  • platform/qt/fast/body-propagation/overflow/005-declarative-expected.txt:
  • platform/qt/fast/body-propagation/overflow/005-expected.png:
  • platform/qt/fast/body-propagation/overflow/005-expected.txt:
  • platform/qt/fast/body-propagation/overflow/005-xhtml-expected.png:
  • platform/qt/fast/body-propagation/overflow/005-xhtml-expected.txt:
  • platform/qt/fast/body-propagation/overflow/006-declarative-expected.png:
  • platform/qt/fast/body-propagation/overflow/006-declarative-expected.txt:
  • platform/qt/fast/body-propagation/overflow/006-expected.png:
  • platform/qt/fast/body-propagation/overflow/006-expected.txt:
  • platform/qt/fast/body-propagation/overflow/006-xhtml-expected.png:
  • platform/qt/fast/body-propagation/overflow/006-xhtml-expected.txt:
  • platform/qt/fast/body-propagation/overflow/007-declarative-expected.png:
  • platform/qt/fast/body-propagation/overflow/007-declarative-expected.txt:
  • platform/qt/fast/body-propagation/overflow/007-expected.png:
  • platform/qt/fast/body-propagation/overflow/007-expected.txt:
  • platform/qt/fast/body-propagation/overflow/007-xhtml-expected.png:
  • platform/qt/fast/body-propagation/overflow/007-xhtml-expected.txt:
  • platform/qt/fast/borders/border-image-massive-scale-expected.png:
  • platform/qt/fast/borders/border-image-massive-scale-expected.txt:
  • platform/qt/fast/borders/border-image-rotate-transform-expected.png:
  • platform/qt/fast/borders/border-image-rotate-transform-expected.txt:
  • platform/qt/fast/borders/border-image-scale-transform-expected.png:
  • platform/qt/fast/borders/border-image-scale-transform-expected.txt:
  • platform/qt/fast/borders/border-image-scaled-expected.png:
  • platform/qt/fast/borders/border-image-scaled-expected.txt:
  • platform/qt/fast/borders/inline-mask-overlay-image-expected.png:
  • platform/qt/fast/borders/inline-mask-overlay-image-expected.txt:
  • platform/qt/fast/borders/rtl-border-01-expected.png:
  • platform/qt/fast/borders/rtl-border-01-expected.txt:
  • platform/qt/fast/borders/rtl-border-02-expected.png:
  • platform/qt/fast/borders/rtl-border-02-expected.txt:
  • platform/qt/fast/borders/rtl-border-03-expected.png:
  • platform/qt/fast/borders/rtl-border-03-expected.txt:
  • platform/qt/fast/box-shadow/basic-shadows-expected.png:
  • platform/qt/fast/box-shadow/basic-shadows-expected.txt:
  • platform/qt/fast/box-sizing/box-sizing-expected.png:
  • platform/qt/fast/box-sizing/box-sizing-expected.txt:
  • platform/qt/fast/canvas/canvas-bg-expected.png:
  • platform/qt/fast/canvas/canvas-bg-expected.txt: Added.
  • platform/qt/fast/canvas/canvas-render-layer-expected.txt: Added.
  • platform/qt/fast/clip/014-expected.png:
  • platform/qt/fast/clip/014-expected.txt:
  • platform/qt/fast/css-generated-content/014-expected.png:
  • platform/qt/fast/css-generated-content/014-expected.txt:
  • platform/qt/fast/css-generated-content/table-parts-before-and-after-expected.png:
  • platform/qt/fast/css-generated-content/table-parts-before-and-after-expected.txt: Added.
  • platform/qt/fast/css/005-expected.png:
  • platform/qt/fast/css/005-expected.txt:
  • platform/qt/fast/css/MarqueeLayoutTest-expected.png:
  • platform/qt/fast/css/MarqueeLayoutTest-expected.txt:
  • platform/qt/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/qt/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt:
  • platform/qt/fast/css/bidi-override-in-anonymous-block-expected.png:
  • platform/qt/fast/css/bidi-override-in-anonymous-block-expected.txt:
  • platform/qt/fast/css/border-height-expected.png:
  • platform/qt/fast/css/border-height-expected.txt:
  • platform/qt/fast/css/clip-text-in-scaled-div-expected.png:
  • platform/qt/fast/css/clip-text-in-scaled-div-expected.txt:
  • platform/qt/fast/css/color-correction-backgrounds-and-text-expected.png:
  • platform/qt/fast/css/color-correction-backgrounds-and-text-expected.txt:
  • platform/qt/fast/css/empty-pseudo-class-expected.png:
  • platform/qt/fast/css/empty-pseudo-class-expected.txt:
  • platform/qt/fast/css/first-child-pseudo-class-expected.png:
  • platform/qt/fast/css/first-child-pseudo-class-expected.txt:
  • platform/qt/fast/css/first-of-type-pseudo-class-expected.png:
  • platform/qt/fast/css/first-of-type-pseudo-class-expected.txt:
  • platform/qt/fast/css/font_property_normal-expected.png:
  • platform/qt/fast/css/font_property_normal-expected.txt:
  • platform/qt/fast/css/hsl-color-expected.png:
  • platform/qt/fast/css/hsl-color-expected.txt:
  • platform/qt/fast/css/last-child-pseudo-class-expected.png:
  • platform/qt/fast/css/last-child-pseudo-class-expected.txt:
  • platform/qt/fast/css/last-of-type-pseudo-class-expected.png:
  • platform/qt/fast/css/last-of-type-pseudo-class-expected.txt:
  • platform/qt/fast/css/line-height-overflow-expected.png:
  • platform/qt/fast/css/line-height-overflow-expected.txt:
  • platform/qt/fast/css/nested-floating-relative-position-percentages-expected.png:
  • platform/qt/fast/css/nested-floating-relative-position-percentages-expected.txt:
  • platform/qt/fast/css/nested-rounded-corners-expected.png: Added.
  • platform/qt/fast/css/nested-rounded-corners-expected.txt: Added.
  • platform/qt/fast/css/only-child-pseudo-class-expected.png:
  • platform/qt/fast/css/only-child-pseudo-class-expected.txt:
  • platform/qt/fast/css/only-of-type-pseudo-class-expected.png:
  • platform/qt/fast/css/only-of-type-pseudo-class-expected.txt:
  • platform/qt/fast/css/positioned-overflow-scroll-expected.png:
  • platform/qt/fast/css/positioned-overflow-scroll-expected.txt:
  • platform/qt/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png:
  • platform/qt/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.txt:
  • platform/qt/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png:
  • platform/qt/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.txt:
  • platform/qt/fast/css/relative-positioned-block-with-inline-ancestor-expected.png:
  • platform/qt/fast/css/relative-positioned-block-with-inline-ancestor-expected.txt:
  • platform/qt/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png:
  • platform/qt/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.txt:
  • platform/qt/fast/css/resize-corner-tracking-expected.png:
  • platform/qt/fast/css/resize-corner-tracking-expected.txt:
  • platform/qt/fast/css/shadow-multiple-expected.png:
  • platform/qt/fast/css/shadow-multiple-expected.txt:
  • platform/qt/fast/css/text-transform-select-expected.png:
  • platform/qt/fast/css/text-transform-select-expected.txt:
  • platform/qt/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
  • platform/qt/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
  • platform/qt/fast/dom/clone-node-dynamic-style-expected.png:
  • platform/qt/fast/dom/clone-node-dynamic-style-expected.txt:
  • platform/qt/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png:
  • platform/qt/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt:
  • platform/qt/fast/dom/scroll-reveal-left-overflow-expected.png:
  • platform/qt/fast/dom/scroll-reveal-left-overflow-expected.txt:
  • platform/qt/fast/dom/scroll-reveal-top-overflow-expected.png:
  • platform/qt/fast/dom/scroll-reveal-top-overflow-expected.txt:
  • platform/qt/fast/dom/vertical-scrollbar-in-rtl-expected.txt:
  • platform/qt/fast/dynamic/008-expected.png:
  • platform/qt/fast/dynamic/008-expected.txt:
  • platform/qt/fast/dynamic/anchor-lock-expected.png:
  • platform/qt/fast/dynamic/anchor-lock-expected.txt:
  • platform/qt/fast/dynamic/insert-before-table-part-in-continuation-expected.png:
  • platform/qt/fast/dynamic/insert-before-table-part-in-continuation-expected.txt:
  • platform/qt/fast/encoding/utf-16-big-endian-expected.png:
  • platform/qt/fast/encoding/utf-16-big-endian-expected.txt:
  • platform/qt/fast/encoding/utf-16-little-endian-expected.png:
  • platform/qt/fast/encoding/utf-16-little-endian-expected.txt:
  • platform/qt/fast/events/pointer-events-2-expected.png:
  • platform/qt/fast/events/pointer-events-2-expected.txt:
  • platform/qt/fast/events/resize-events-expected.png:
  • platform/qt/fast/events/resize-events-expected.txt:
  • platform/qt/fast/events/reveal-link-when-focused-expected.png:
  • platform/qt/fast/events/reveal-link-when-focused-expected.txt:
  • platform/qt/fast/flexbox/009-expected.png:
  • platform/qt/fast/flexbox/009-expected.txt:
  • platform/qt/fast/flexbox/016-expected.png:
  • platform/qt/fast/flexbox/016-expected.txt:
  • platform/qt/fast/flexbox/flex-hang-expected.png:
  • platform/qt/fast/flexbox/flex-hang-expected.txt:
  • platform/qt/fast/forms/HTMLOptionElement_label05-expected.png: Added.
  • platform/qt/fast/forms/HTMLOptionElement_label05-expected.txt:
  • platform/qt/fast/forms/basic-textareas-quirks-expected.png:
  • platform/qt/fast/forms/basic-textareas-quirks-expected.txt:
  • platform/qt/fast/forms/button-default-title-expected.png: Added.
  • platform/qt/fast/forms/button-default-title-expected.txt:
  • platform/qt/fast/forms/button-table-styles-expected.png:
  • platform/qt/fast/forms/button-table-styles-expected.txt:
  • platform/qt/fast/forms/disabled-select-change-index-expected.png:
  • platform/qt/fast/forms/disabled-select-change-index-expected.txt:
  • platform/qt/fast/forms/fieldset-align-expected.png:
  • platform/qt/fast/forms/fieldset-align-expected.txt:
  • platform/qt/fast/forms/file/file-input-direction-expected.png:
  • platform/qt/fast/forms/file/file-input-direction-expected.txt:
  • platform/qt/fast/forms/form-element-geometry-expected.png:
  • platform/qt/fast/forms/form-element-geometry-expected.txt:
  • platform/qt/fast/forms/form-hides-table-expected.png:
  • platform/qt/fast/forms/form-hides-table-expected.txt:
  • platform/qt/fast/forms/hidden-listbox-expected.png: Added.
  • platform/qt/fast/forms/hidden-listbox-expected.txt:
  • platform/qt/fast/forms/input-appearance-selection-expected.png:
  • platform/qt/fast/forms/input-appearance-selection-expected.txt:
  • platform/qt/fast/forms/listbox-bidi-align-expected.png:
  • platform/qt/fast/forms/listbox-bidi-align-expected.txt:
  • platform/qt/fast/forms/listbox-scrollbar-incremental-load-expected.png: Added.
  • platform/qt/fast/forms/listbox-scrollbar-incremental-load-expected.txt:
  • platform/qt/fast/forms/number/number-appearance-rtl-expected.png:
  • platform/qt/fast/forms/number/number-appearance-rtl-expected.txt:
  • platform/qt/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/qt/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/qt/fast/forms/number/number-appearance-spinbutton-layer-expected.png:
  • platform/qt/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
  • platform/qt/fast/forms/option-strip-whitespace-expected.png: Added.
  • platform/qt/fast/forms/option-strip-whitespace-expected.txt:
  • platform/qt/fast/forms/placeholder-position-expected.png:
  • platform/qt/fast/forms/placeholder-position-expected.txt:
  • platform/qt/fast/forms/select-block-background-expected.png: Added.
  • platform/qt/fast/forms/select-block-background-expected.txt:
  • platform/qt/fast/forms/select-change-listbox-size-expected.png: Added.
  • platform/qt/fast/forms/select-change-listbox-size-expected.txt:
  • platform/qt/fast/forms/select-change-popup-to-listbox-expected.png: Added.
  • platform/qt/fast/forms/select-change-popup-to-listbox-expected.txt:
  • platform/qt/fast/forms/select-initial-position-expected.png: Added.
  • platform/qt/fast/forms/select-initial-position-expected.txt:
  • platform/qt/fast/forms/select-item-background-clip-expected.png: Added.
  • platform/qt/fast/forms/select-item-background-clip-expected.txt:
  • platform/qt/fast/forms/select-list-box-with-height-expected.png: Added.
  • platform/qt/fast/forms/select-list-box-with-height-expected.txt:
  • platform/qt/fast/forms/select-listbox-multiple-no-focusring-expected.png:
  • platform/qt/fast/forms/select-listbox-multiple-no-focusring-expected.txt:
  • platform/qt/fast/forms/select-overflow-scroll-expected.png:
  • platform/qt/fast/forms/select-overflow-scroll-expected.txt:
  • platform/qt/fast/forms/select-overflow-scroll-inherited-expected.png:
  • platform/qt/fast/forms/select-overflow-scroll-inherited-expected.txt:
  • platform/qt/fast/forms/textarea-align-expected.png:
  • platform/qt/fast/forms/textarea-align-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.png:
  • platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-visibility-1-expected.png:
  • platform/qt/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-visibility-2-expected.png:
  • platform/qt/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/qt/fast/forms/textarea-setinnerhtml-expected.png:
  • platform/qt/fast/forms/textarea-setinnerhtml-expected.txt:
  • platform/qt/fast/frames/calculate-fixed-expected.png: Added.
  • platform/qt/fast/frames/calculate-fixed-expected.txt:
  • platform/qt/fast/frames/calculate-order-expected.png: Added.
  • platform/qt/fast/frames/calculate-order-expected.txt:
  • platform/qt/fast/frames/calculate-percentage-expected.png: Added.
  • platform/qt/fast/frames/calculate-percentage-expected.txt:
  • platform/qt/fast/frames/calculate-relative-expected.png: Added.
  • platform/qt/fast/frames/calculate-relative-expected.txt:
  • platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.png:
  • platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.txt:
  • platform/qt/fast/frames/flattening/frameset-flattening-grid-expected.png:
  • platform/qt/fast/frames/flattening/frameset-flattening-grid-expected.txt:
  • platform/qt/fast/frames/flattening/frameset-flattening-simple-expected.png:
  • platform/qt/fast/frames/flattening/frameset-flattening-simple-expected.txt:
  • platform/qt/fast/frames/flattening/frameset-flattening-subframe-resize-expected.png:
  • platform/qt/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt:
  • platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.png:
  • platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
  • platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.png:
  • platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt:
  • platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-expected.png:
  • platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt:
  • platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.png:
  • platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt:
  • platform/qt/fast/frames/frame-scrolling-attribute-expected.png:
  • platform/qt/fast/frames/frame-scrolling-attribute-expected.txt:
  • platform/qt/fast/frames/iframe-scaling-with-scroll-expected.png: Added.
  • platform/qt/fast/frames/iframe-scaling-with-scroll-expected.txt: Added.
  • platform/qt/fast/frames/iframe-scrolling-attribute-expected.png:
  • platform/qt/fast/frames/iframe-scrolling-attribute-expected.txt:
  • platform/qt/fast/frames/inline-object-inside-frameset-expected.png:
  • platform/qt/fast/frames/inline-object-inside-frameset-expected.txt:
  • platform/qt/fast/frames/invalid-expected.png: Added.
  • platform/qt/fast/frames/invalid-expected.txt:
  • platform/qt/fast/frames/take-focus-from-iframe-expected.png:
  • platform/qt/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/qt/fast/frames/valid-expected.png: Added.
  • platform/qt/fast/frames/valid-expected.txt:
  • platform/qt/fast/gradients/background-clipped-expected.png:
  • platform/qt/fast/gradients/background-clipped-expected.txt: Added.
  • platform/qt/fast/html/details-position-expected.png:
  • platform/qt/fast/html/details-position-expected.txt:
  • platform/qt/fast/html/details-writing-mode-expected.png:
  • platform/qt/fast/html/details-writing-mode-expected.txt:
  • platform/qt/fast/images/gif-large-checkerboard-expected.png:
  • platform/qt/fast/images/gif-large-checkerboard-expected.txt: Added.
  • platform/qt/fast/images/gray-scale-jpeg-with-color-profile-expected.png:
  • platform/qt/fast/images/gray-scale-jpeg-with-color-profile-expected.txt:
  • platform/qt/fast/inline-block/tricky-baseline-expected.png:
  • platform/qt/fast/inline-block/tricky-baseline-expected.txt:
  • platform/qt/fast/inline/inline-borders-with-bidi-override-expected.png:
  • platform/qt/fast/inline/inline-borders-with-bidi-override-expected.txt:
  • platform/qt/fast/inline/inline-continuation-borders-expected.png:
  • platform/qt/fast/inline/inline-continuation-borders-expected.txt:
  • platform/qt/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.png:
  • platform/qt/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt:
  • platform/qt/fast/inline/long-wrapped-line-expected.png:
  • platform/qt/fast/inline/long-wrapped-line-expected.txt:
  • platform/qt/fast/layers/overflow-scroll-auto-switch-expected.png:
  • platform/qt/fast/layers/overflow-scroll-auto-switch-expected.txt:
  • platform/qt/fast/layers/scroll-rect-to-visible-expected.png:
  • platform/qt/fast/layers/scroll-rect-to-visible-expected.txt:
  • platform/qt/fast/line-grid/line-grid-inside-columns-expected.png:
  • platform/qt/fast/line-grid/line-grid-inside-columns-expected.txt:
  • platform/qt/fast/lists/001-expected.png:
  • platform/qt/fast/lists/001-expected.txt:
  • platform/qt/fast/lists/001-vertical-expected.png:
  • platform/qt/fast/lists/001-vertical-expected.txt:
  • platform/qt/fast/lists/008-expected.png:
  • platform/qt/fast/lists/008-expected.txt:
  • platform/qt/fast/lists/008-vertical-expected.png:
  • platform/qt/fast/lists/008-vertical-expected.txt:
  • platform/qt/fast/lists/li-br-expected.png:
  • platform/qt/fast/lists/li-br-expected.txt:
  • platform/qt/fast/lists/ol-start-parsing-expected.png:
  • platform/qt/fast/lists/ol-start-parsing-expected.txt:
  • platform/qt/fast/lists/olstart-expected.png:
  • platform/qt/fast/lists/olstart-expected.txt:
  • platform/qt/fast/media/mq-relative-constraints-02-expected.png:
  • platform/qt/fast/media/mq-relative-constraints-02-expected.txt:
  • platform/qt/fast/media/mq-relative-constraints-03-expected.png:
  • platform/qt/fast/media/mq-relative-constraints-03-expected.txt:
  • platform/qt/fast/media/mq-relative-constraints-04-expected.png:
  • platform/qt/fast/media/mq-relative-constraints-04-expected.txt:
  • platform/qt/fast/media/mq-relative-constraints-05-expected.png:
  • platform/qt/fast/media/mq-relative-constraints-05-expected.txt:
  • platform/qt/fast/media/mq-relative-constraints-06-expected.png:
  • platform/qt/fast/media/mq-relative-constraints-06-expected.txt:
  • platform/qt/fast/media/mq-relative-constraints-07-expected.png:
  • platform/qt/fast/media/mq-relative-constraints-07-expected.txt:
  • platform/qt/fast/media/mq-relative-constraints-08-expected.png:
  • platform/qt/fast/media/mq-relative-constraints-08-expected.txt:
  • platform/qt/fast/media/mq-relative-constraints-09-expected.png:
  • platform/qt/fast/media/mq-relative-constraints-09-expected.txt:
  • platform/qt/fast/media/mq-width-absolute-01-expected.png:
  • platform/qt/fast/media/mq-width-absolute-01-expected.txt:
  • platform/qt/fast/media/mq-width-absolute-02-expected.png:
  • platform/qt/fast/media/mq-width-absolute-02-expected.txt:
  • platform/qt/fast/media/mq-width-absolute-03-expected.png:
  • platform/qt/fast/media/mq-width-absolute-03-expected.txt:
  • platform/qt/fast/media/mq-width-absolute-04-expected.png:
  • platform/qt/fast/media/mq-width-absolute-04-expected.txt:
  • platform/qt/fast/multicol/block-axis-horizontal-tb-expected.png:
  • platform/qt/fast/multicol/block-axis-horizontal-tb-expected.txt:
  • platform/qt/fast/multicol/client-rects-expected.png:
  • platform/qt/fast/multicol/client-rects-expected.txt:
  • platform/qt/fast/multicol/column-break-with-balancing-expected.png:
  • platform/qt/fast/multicol/column-break-with-balancing-expected.txt:
  • platform/qt/fast/multicol/column-rules-stacking-expected.png:
  • platform/qt/fast/multicol/column-rules-stacking-expected.txt:
  • platform/qt/fast/multicol/columns-shorthand-parsing-expected.png:
  • platform/qt/fast/multicol/columns-shorthand-parsing-expected.txt:
  • platform/qt/fast/multicol/float-multicol-expected.png:
  • platform/qt/fast/multicol/float-multicol-expected.txt:
  • platform/qt/fast/multicol/float-paginate-complex-expected.png:
  • platform/qt/fast/multicol/float-paginate-complex-expected.txt:
  • platform/qt/fast/multicol/float-paginate-expected.png:
  • platform/qt/fast/multicol/float-paginate-expected.txt:
  • platform/qt/fast/multicol/layers-in-multicol-expected.png:
  • platform/qt/fast/multicol/layers-in-multicol-expected.txt:
  • platform/qt/fast/multicol/layers-split-across-columns-expected.png:
  • platform/qt/fast/multicol/layers-split-across-columns-expected.txt:
  • platform/qt/fast/multicol/paginate-block-replaced-expected.png:
  • platform/qt/fast/multicol/paginate-block-replaced-expected.txt:
  • platform/qt/fast/multicol/pagination-h-horizontal-bt-expected.png:
  • platform/qt/fast/multicol/pagination-h-horizontal-bt-expected.txt:
  • platform/qt/fast/multicol/pagination-h-horizontal-tb-expected.png:
  • platform/qt/fast/multicol/pagination-h-horizontal-tb-expected.txt:
  • platform/qt/fast/multicol/pagination-h-vertical-lr-expected.png:
  • platform/qt/fast/multicol/pagination-h-vertical-lr-expected.txt:
  • platform/qt/fast/multicol/pagination-h-vertical-rl-expected.png:
  • platform/qt/fast/multicol/pagination-h-vertical-rl-expected.txt:
  • platform/qt/fast/multicol/pagination-v-horizontal-bt-expected.png:
  • platform/qt/fast/multicol/pagination-v-horizontal-bt-expected.txt:
  • platform/qt/fast/multicol/pagination-v-horizontal-tb-expected.png:
  • platform/qt/fast/multicol/pagination-v-horizontal-tb-expected.txt:
  • platform/qt/fast/multicol/pagination-v-vertical-lr-expected.png:
  • platform/qt/fast/multicol/pagination-v-vertical-lr-expected.txt:
  • platform/qt/fast/multicol/pagination-v-vertical-rl-expected.png:
  • platform/qt/fast/multicol/pagination-v-vertical-rl-expected.txt:
  • platform/qt/fast/multicol/positioned-with-constrained-height-expected.png:
  • platform/qt/fast/multicol/positioned-with-constrained-height-expected.txt:
  • platform/qt/fast/multicol/progression-reverse-expected.png:
  • platform/qt/fast/multicol/progression-reverse-expected.txt:
  • platform/qt/fast/multicol/scrolling-overflow-expected.png:
  • platform/qt/fast/multicol/scrolling-overflow-expected.txt:
  • platform/qt/fast/multicol/span/anonymous-style-inheritance-expected.png:
  • platform/qt/fast/multicol/span/anonymous-style-inheritance-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
  • platform/qt/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/qt/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-expected.png:
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/qt/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/qt/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
  • platform/qt/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/qt/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/qt/fast/multicol/span/span-margin-collapsing-expected.png:
  • platform/qt/fast/multicol/span/span-margin-collapsing-expected.txt:
  • platform/qt/fast/multicol/table-vertical-align-expected.png:
  • platform/qt/fast/multicol/table-vertical-align-expected.txt:
  • platform/qt/fast/multicol/vertical-lr/column-break-with-balancing-expected.png:
  • platform/qt/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt:
  • platform/qt/fast/multicol/vertical-lr/float-multicol-expected.png:
  • platform/qt/fast/multicol/vertical-lr/float-multicol-expected.txt:
  • platform/qt/fast/multicol/vertical-lr/float-paginate-complex-expected.png:
  • platform/qt/fast/multicol/vertical-lr/float-paginate-complex-expected.txt:
  • platform/qt/fast/multicol/vertical-lr/float-paginate-expected.png:
  • platform/qt/fast/multicol/vertical-lr/float-paginate-expected.txt:
  • platform/qt/fast/multicol/vertical-lr/nested-columns-expected.png:
  • platform/qt/fast/multicol/vertical-lr/nested-columns-expected.txt:
  • platform/qt/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png:
  • platform/qt/fast/multicol/vertical-lr/unsplittable-inline-block-expected.txt:
  • platform/qt/fast/multicol/vertical-rl/column-break-with-balancing-expected.png:
  • platform/qt/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt:
  • platform/qt/fast/multicol/vertical-rl/float-multicol-expected.png:
  • platform/qt/fast/multicol/vertical-rl/float-multicol-expected.txt:
  • platform/qt/fast/multicol/vertical-rl/float-paginate-complex-expected.png:
  • platform/qt/fast/multicol/vertical-rl/float-paginate-complex-expected.txt:
  • platform/qt/fast/multicol/vertical-rl/float-paginate-expected.png:
  • platform/qt/fast/multicol/vertical-rl/float-paginate-expected.txt:
  • platform/qt/fast/multicol/vertical-rl/nested-columns-expected.png:
  • platform/qt/fast/multicol/vertical-rl/nested-columns-expected.txt:
  • platform/qt/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png:
  • platform/qt/fast/multicol/vertical-rl/unsplittable-inline-block-expected.txt:
  • platform/qt/fast/overflow/002-expected.png:
  • platform/qt/fast/overflow/002-expected.txt:
  • platform/qt/fast/overflow/006-expected.png:
  • platform/qt/fast/overflow/006-expected.txt:
  • platform/qt/fast/overflow/007-expected.png:
  • platform/qt/fast/overflow/007-expected.txt:
  • platform/qt/fast/overflow/008-expected.png:
  • platform/qt/fast/overflow/008-expected.txt:
  • platform/qt/fast/overflow/childFocusRingClip-expected.png:
  • platform/qt/fast/overflow/childFocusRingClip-expected.txt:
  • platform/qt/fast/overflow/float-in-relpositioned-expected.png:
  • platform/qt/fast/overflow/float-in-relpositioned-expected.txt:
  • platform/qt/fast/overflow/hidden-scrollbar-resize-expected.txt:
  • platform/qt/fast/overflow/hit-test-overflow-controls-expected.png:
  • platform/qt/fast/overflow/hit-test-overflow-controls-expected.txt:
  • platform/qt/fast/overflow/image-selection-highlight-expected.png:
  • platform/qt/fast/overflow/image-selection-highlight-expected.txt:
  • platform/qt/fast/overflow/overflow-auto-position-absolute-expected.png:
  • platform/qt/fast/overflow/overflow-auto-position-absolute-expected.txt:
  • platform/qt/fast/overflow/overflow-auto-table-expected.png:
  • platform/qt/fast/overflow/overflow-auto-table-expected.txt:
  • platform/qt/fast/overflow/overflow-float-stacking-expected.txt:
  • platform/qt/fast/overflow/overflow-rtl-vertical-expected.png:
  • platform/qt/fast/overflow/overflow-rtl-vertical-expected.txt:
  • platform/qt/fast/overflow/overflow-stacking-expected.png:
  • platform/qt/fast/overflow/overflow-stacking-expected.txt:
  • platform/qt/fast/overflow/overflow-update-transform-expected.png:
  • platform/qt/fast/overflow/overflow-update-transform-expected.txt: Added.
  • platform/qt/fast/overflow/overflow-with-local-background-attachment-expected.png:
  • platform/qt/fast/overflow/overflow-with-local-background-attachment-expected.txt:
  • platform/qt/fast/overflow/paged-x-div-expected.txt: Added.
  • platform/qt/fast/overflow/paged-x-div-with-column-gap-expected.txt: Added.
  • platform/qt/fast/overflow/paged-x-on-root-expected.txt: Added.
  • platform/qt/fast/overflow/paged-x-with-column-gap-expected.txt: Added.
  • platform/qt/fast/overflow/paged-y-div-expected.txt: Added.
  • platform/qt/fast/overflow/paged-y-on-root-expected.txt: Added.
  • platform/qt/fast/overflow/position-fixed-transform-clipping-expected.png:
  • platform/qt/fast/overflow/position-fixed-transform-clipping-expected.txt:
  • platform/qt/fast/overflow/scrollbar-position-update-expected.png:
  • platform/qt/fast/overflow/scrollbar-position-update-expected.txt:
  • platform/qt/fast/overflow/table-overflow-float-expected.png:
  • platform/qt/fast/overflow/table-overflow-float-expected.txt:
  • platform/qt/fast/overflow/unreachable-overflow-rtl-bug-expected.png:
  • platform/qt/fast/overflow/unreachable-overflow-rtl-bug-expected.txt:
  • platform/qt/fast/parser/entity-comment-in-textarea-expected.png:
  • platform/qt/fast/parser/entity-comment-in-textarea-expected.txt:
  • platform/qt/fast/parser/open-comment-in-textarea-expected.png:
  • platform/qt/fast/parser/open-comment-in-textarea-expected.txt:
  • platform/qt/fast/reflections/reflection-direction-expected.png:
  • platform/qt/fast/reflections/reflection-direction-expected.txt:
  • platform/qt/fast/repaint/dynamic-table-vertical-alignment-change-expected.png:
  • platform/qt/fast/repaint/dynamic-table-vertical-alignment-change-expected.txt:
  • platform/qt/fast/repaint/fixed-child-move-after-scroll-expected.png:
  • platform/qt/fast/repaint/fixed-child-move-after-scroll-expected.txt:
  • platform/qt/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png:
  • platform/qt/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.txt:
  • platform/qt/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png:
  • platform/qt/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.txt:
  • platform/qt/fast/repaint/fixed-move-after-keyboard-scroll-expected.png:
  • platform/qt/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
  • platform/qt/fast/repaint/fixed-move-after-scroll-expected.png:
  • platform/qt/fast/repaint/fixed-move-after-scroll-expected.txt:
  • platform/qt/fast/repaint/fixed-tranformed-expected.png:
  • platform/qt/fast/repaint/fixed-tranformed-expected.txt:
  • platform/qt/fast/repaint/layout-state-only-positioned-expected.png:
  • platform/qt/fast/repaint/layout-state-only-positioned-expected.txt:
  • platform/qt/fast/repaint/overflow-scroll-body-appear-expected.png:
  • platform/qt/fast/repaint/overflow-scroll-body-appear-expected.txt:
  • platform/qt/fast/repaint/overflow-scroll-delete-expected.png:
  • platform/qt/fast/repaint/overflow-scroll-delete-expected.txt:
  • platform/qt/fast/repaint/repaint-during-scroll-expected.png:
  • platform/qt/fast/repaint/repaint-during-scroll-expected.txt:
  • platform/qt/fast/repaint/select-option-background-color-expected.png:
  • platform/qt/fast/repaint/select-option-background-color-expected.txt:
  • platform/qt/fast/repaint/selection-gap-overflow-scroll-2-expected.png:
  • platform/qt/fast/repaint/selection-gap-overflow-scroll-2-expected.txt:
  • platform/qt/fast/repaint/transform-absolute-in-positioned-container-expected.png:
  • platform/qt/fast/repaint/transform-absolute-in-positioned-container-expected.txt:
  • platform/qt/fast/replaced/005-expected.png:
  • platform/qt/fast/replaced/005-expected.txt:
  • platform/qt/fast/replaced/border-radius-clip-expected.png:
  • platform/qt/fast/replaced/border-radius-clip-expected.txt:
  • platform/qt/fast/replaced/replaced-breaking-expected.png:
  • platform/qt/fast/replaced/replaced-breaking-expected.txt:
  • platform/qt/fast/replaced/width100percent-image-expected.png:
  • platform/qt/fast/replaced/width100percent-image-expected.txt:
  • platform/qt/fast/replaced/width100percent-searchfield-expected.png:
  • platform/qt/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/qt/fast/replaced/width100percent-textfield-expected.png:
  • platform/qt/fast/replaced/width100percent-textfield-expected.txt:
  • platform/qt/fast/selectors/166-expected.png:
  • platform/qt/fast/selectors/166-expected.txt:
  • platform/qt/fast/spatial-navigation/snav-multiple-select-focusring-expected.png:
  • platform/qt/fast/spatial-navigation/snav-multiple-select-focusring-expected.txt:
  • platform/qt/fast/table/003-expected.png:
  • platform/qt/fast/table/003-expected.txt:
  • platform/qt/fast/table/023-expected.png:
  • platform/qt/fast/table/023-expected.txt:
  • platform/qt/fast/table/027-vertical-expected.png:
  • platform/qt/fast/table/027-vertical-expected.txt:
  • platform/qt/fast/table/034-expected.png:
  • platform/qt/fast/table/034-expected.txt:
  • platform/qt/fast/table/038-vertical-expected.png:
  • platform/qt/fast/table/038-vertical-expected.txt:
  • platform/qt/fast/table/040-expected.png:
  • platform/qt/fast/table/040-expected.txt:
  • platform/qt/fast/table/040-vertical-expected.png:
  • platform/qt/fast/table/040-vertical-expected.txt:
  • platform/qt/fast/table/border-collapsing/002-vertical-expected.png:
  • platform/qt/fast/table/border-collapsing/002-vertical-expected.txt:
  • platform/qt/fast/table/border-collapsing/004-expected.png:
  • platform/qt/fast/table/border-collapsing/004-expected.txt:
  • platform/qt/fast/table/border-collapsing/004-vertical-expected.png:
  • platform/qt/fast/table/border-collapsing/004-vertical-expected.txt:
  • platform/qt/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.png:
  • platform/qt/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.txt:
  • platform/qt/fast/table/edge-offsets-expected.png:
  • platform/qt/fast/table/edge-offsets-expected.txt:
  • platform/qt/fast/table/empty-cells-expected.png:
  • platform/qt/fast/table/empty-cells-expected.txt:
  • platform/qt/fast/table/frame-and-rules-expected.png:
  • platform/qt/fast/table/frame-and-rules-expected.txt:
  • platform/qt/fast/table/height-percent-test-expected.png: Added.
  • platform/qt/fast/table/height-percent-test-expected.txt:
  • platform/qt/fast/table/height-percent-test-vertical-expected.png:
  • platform/qt/fast/table/height-percent-test-vertical-expected.txt:
  • platform/qt/fast/table/overflowHidden-expected.png:
  • platform/qt/fast/table/overflowHidden-expected.txt:
  • platform/qt/fast/table/prepend-in-anonymous-table-expected.png:
  • platform/qt/fast/table/prepend-in-anonymous-table-expected.txt:
  • platform/qt/fast/table/table-display-types-vertical-expected.png:
  • platform/qt/fast/table/table-display-types-vertical-expected.txt:
  • platform/qt/fast/table/wide-colspan-expected.png:
  • platform/qt/fast/table/wide-colspan-expected.txt: Added.
  • platform/qt/fast/table/wide-column-expected.png:
  • platform/qt/fast/table/wide-column-expected.txt: Added.
  • platform/qt/fast/text/backslash-to-yen-sign-euc-expected.png:
  • platform/qt/fast/text/backslash-to-yen-sign-euc-expected.txt:
  • platform/qt/fast/text/hyphenate-limit-lines-expected.png:
  • platform/qt/fast/text/hyphenate-limit-lines-expected.txt:
  • platform/qt/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
  • platform/qt/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
  • platform/qt/fast/text/large-text-composed-char-expected.png:
  • platform/qt/fast/text/large-text-composed-char-expected.txt:
  • platform/qt/fast/text/softHyphen-expected.png:
  • platform/qt/fast/text/softHyphen-expected.txt:
  • platform/qt/fast/text/text-letter-spacing-expected.png:
  • platform/qt/fast/text/text-letter-spacing-expected.txt:
  • platform/qt/fast/text/updateNewFont-expected.png: Added.
  • platform/qt/fast/text/updateNewFont-expected.txt:
  • platform/qt/fast/text/wbr-expected.png:
  • platform/qt/fast/text/wbr-expected.txt:
  • platform/qt/fast/text/word-break-expected.png:
  • platform/qt/fast/text/word-break-expected.txt:
  • platform/qt/fast/transforms/rotated-transform-affects-scrolling-1-expected.png:
  • platform/qt/fast/transforms/rotated-transform-affects-scrolling-1-expected.txt:
  • platform/qt/fast/transforms/rotated-transform-affects-scrolling-2-expected.png:
  • platform/qt/fast/transforms/rotated-transform-affects-scrolling-2-expected.txt:
  • platform/qt/fast/writing-mode/border-radius-clipping-vertical-lr-expected.png:
  • platform/qt/fast/writing-mode/border-radius-clipping-vertical-lr-expected.txt:
  • platform/qt/fast/writing-mode/box-shadow-vertical-lr-expected.png:
  • platform/qt/fast/writing-mode/box-shadow-vertical-lr-expected.txt:
  • platform/qt/fast/writing-mode/box-shadow-vertical-rl-expected.png:
  • platform/qt/fast/writing-mode/box-shadow-vertical-rl-expected.txt:
  • platform/qt/fast/writing-mode/fieldsets-expected.png:
  • platform/qt/fast/writing-mode/fieldsets-expected.txt:
  • platform/qt/fast/writing-mode/table-percent-width-quirk-expected.png:
  • platform/qt/fast/writing-mode/table-percent-width-quirk-expected.txt:
  • platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png:
  • platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt:
  • platform/qt/http/tests/navigation/error404-subframeload-expected.png:
  • platform/qt/http/tests/navigation/error404-subframeload-expected.txt:
  • platform/qt/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/qt/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.txt:
  • platform/qt/printing/width-overflow-expected.txt:
  • platform/qt/scrollbars/scrollbars-on-positioned-content-expected.png:
  • platform/qt/scrollbars/scrollbars-on-positioned-content-expected.txt:
  • platform/qt/svg/as-image/image-respects-pageScaleFactor-expected.png:
  • platform/qt/svg/as-image/image-respects-pageScaleFactor-expected.txt:
  • platform/qt/svg/custom/altglyph-expected.png:
  • platform/qt/svg/custom/altglyph-expected.txt:
  • platform/qt/svg/custom/clip-mask-negative-scale-expected.txt: Added.
  • platform/qt/svg/custom/external-paintserver-reference-expected.png:
  • platform/qt/svg/custom/external-paintserver-reference-expected.txt:
  • platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-expected.png:
  • platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt:
  • platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png:
  • platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt:
  • platform/qt/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png:
  • platform/qt/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt:
  • platform/qt/svg/custom/invisible-text-after-scrolling-expected.png:
  • platform/qt/svg/custom/invisible-text-after-scrolling-expected.txt:
  • platform/qt/svg/custom/linking-base-external-reference-expected.png:
  • platform/qt/svg/custom/linking-base-external-reference-expected.txt:
  • platform/qt/svg/custom/object-sizing-no-width-height-expected.png:
  • platform/qt/svg/custom/object-sizing-no-width-height-expected.txt:
  • platform/qt/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/qt/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
  • platform/qt/svg/custom/svg-fonts-in-text-controls-expected.txt:
  • platform/qt/svg/custom/text-xy-updates-SVGList-expected.png:
  • platform/qt/svg/custom/text-xy-updates-SVGList-expected.txt:
  • platform/qt/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png:
  • platform/qt/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.txt:
  • platform/qt/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png:
  • platform/qt/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.txt:
  • platform/qt/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png:
  • platform/qt/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.txt:
  • platform/qt/svg/in-html/circle-expected.png:
  • platform/qt/svg/in-html/circle-expected.txt:
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png:
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.txt: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png:
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.txt: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png:
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.txt: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png:
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.txt: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png:
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt:
  • platform/qt/svg/text/kerning-expected.png:
  • platform/qt/svg/text/kerning-expected.txt:
  • platform/qt/svg/text/multichar-glyph-expected.png:
  • platform/qt/svg/text/multichar-glyph-expected.txt:
  • platform/qt/svg/wicd/rightsizing-grid-expected.png:
  • platform/qt/svg/wicd/rightsizing-grid-expected.txt:
  • platform/qt/svg/wicd/test-rightsizing-b-expected.png:
  • platform/qt/svg/wicd/test-rightsizing-b-expected.txt:
  • platform/qt/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/qt/svg/wicd/test-scalable-background-image1-expected.txt:
  • platform/qt/svg/zoom/page/absolute-sized-document-scrollbars-expected.png:
  • platform/qt/svg/zoom/page/absolute-sized-document-scrollbars-expected.txt:
  • platform/qt/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
  • platform/qt/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
  • platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
  • platform/qt/svg/zoom/page/zoom-svg-float-border-padding-expected.txt:
  • platform/qt/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
  • platform/qt/svg/zoom/text/zoom-svg-float-border-padding-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug101674-expected.png:
  • platform/qt/tables/mozilla/bugs/bug101674-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug10269-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug10269-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1055-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1055-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug113235-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug113235-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug113235-3-expected.png:
  • platform/qt/tables/mozilla/bugs/bug113235-3-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug11944-expected.png:
  • platform/qt/tables/mozilla/bugs/bug11944-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug120364-expected.png:
  • platform/qt/tables/mozilla/bugs/bug120364-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1302-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1302-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug131020-expected.png:
  • platform/qt/tables/mozilla/bugs/bug131020-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug131020_iframe-expected.png:
  • platform/qt/tables/mozilla/bugs/bug131020_iframe-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug137388-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug137388-2-expected.txt: Added.
  • platform/qt/tables/mozilla/bugs/bug149275-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug149275-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug16252-expected.png:
  • platform/qt/tables/mozilla/bugs/bug16252-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug194024-expected.png:
  • platform/qt/tables/mozilla/bugs/bug194024-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug22019-expected.png:
  • platform/qt/tables/mozilla/bugs/bug22019-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug23151-expected.png:
  • platform/qt/tables/mozilla/bugs/bug23151-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2479-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2479-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2479-4-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug27038-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug27038-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug29314-expected.png:
  • platform/qt/tables/mozilla/bugs/bug29314-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2947-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2947-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug30559-expected.png:
  • platform/qt/tables/mozilla/bugs/bug30559-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug32205-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug32205-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug38916-expected.png:
  • platform/qt/tables/mozilla/bugs/bug38916-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug3977-expected.png:
  • platform/qt/tables/mozilla/bugs/bug3977-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug43039-expected.png:
  • platform/qt/tables/mozilla/bugs/bug43039-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug43854-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug43854-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug44505-expected.png:
  • platform/qt/tables/mozilla/bugs/bug44505-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug46480-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug46480-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug46480-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug46480-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug50695-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug50695-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug56405-expected.png:
  • platform/qt/tables/mozilla/bugs/bug56405-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug5797-expected.png:
  • platform/qt/tables/mozilla/bugs/bug5797-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug5835-expected.png:
  • platform/qt/tables/mozilla/bugs/bug5835-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug625-expected.png:
  • platform/qt/tables/mozilla/bugs/bug625-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug650-expected.png:
  • platform/qt/tables/mozilla/bugs/bug650-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug67915-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug67915-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug7112-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug7112-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug7112-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug7112-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug73321-expected.png:
  • platform/qt/tables/mozilla/bugs/bug73321-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug92143-expected.png:
  • platform/qt/tables/mozilla/bugs/bug92143-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug96334-expected.png:
  • platform/qt/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug96343-expected.png:
  • platform/qt/tables/mozilla/bugs/bug96343-expected.txt:
  • platform/qt/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
  • platform/qt/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:
  • platform/qt/tables/mozilla/core/bloomberg-expected.png:
  • platform/qt/tables/mozilla/core/bloomberg-expected.txt:
  • platform/qt/tables/mozilla/core/captions-expected.png:
  • platform/qt/tables/mozilla/core/captions-expected.txt:
  • platform/qt/tables/mozilla/core/cell_heights-expected.png:
  • platform/qt/tables/mozilla/core/cell_heights-expected.txt:
  • platform/qt/tables/mozilla/core/col_span-expected.png:
  • platform/qt/tables/mozilla/core/col_span-expected.txt:
  • platform/qt/tables/mozilla/core/col_widths_auto_fix-expected.png:
  • platform/qt/tables/mozilla/core/col_widths_auto_fix-expected.txt:
  • platform/qt/tables/mozilla/core/col_widths_fix_fixPer-expected.png:
  • platform/qt/tables/mozilla/core/col_widths_fix_fixPer-expected.txt:
  • platform/qt/tables/mozilla/core/nested1-expected.png:
  • platform/qt/tables/mozilla/core/nested1-expected.txt:
  • platform/qt/tables/mozilla/core/one_row-expected.png:
  • platform/qt/tables/mozilla/core/one_row-expected.txt:
  • platform/qt/tables/mozilla/core/row_span-expected.png:
  • platform/qt/tables/mozilla/core/row_span-expected.txt:
  • platform/qt/tables/mozilla/marvin/backgr_index-expected.png:
  • platform/qt/tables/mozilla/marvin/backgr_index-expected.txt:
  • platform/qt/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
  • platform/qt/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
  • platform/qt/tables/mozilla/marvin/backgr_position-table-expected.png:
  • platform/qt/tables/mozilla/marvin/backgr_position-table-expected.txt:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-cell-expected.png:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-expected.png:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-expected.txt:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_table_bgcolor_name-expected.png:
  • platform/qt/tables/mozilla/marvin/x_table_bgcolor_name-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.png:
  • platform/qt/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_td_bgcolor_name-expected.png:
  • platform/qt/tables/mozilla/marvin/x_td_bgcolor_name-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_td_bgcolor_rgb-expected.png:
  • platform/qt/tables/mozilla/marvin/x_td_bgcolor_rgb-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_td_height-expected.png:
  • platform/qt/tables/mozilla/marvin/x_td_height-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_td_nowrap-expected.png:
  • platform/qt/tables/mozilla/marvin/x_td_nowrap-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_th_bgcolor_name-expected.png:
  • platform/qt/tables/mozilla/marvin/x_th_bgcolor_name-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_th_bgcolor_rgb-expected.png:
  • platform/qt/tables/mozilla/marvin/x_th_bgcolor_rgb-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_th_height-expected.png:
  • platform/qt/tables/mozilla/marvin/x_th_height-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_th_nowrap-expected.png:
  • platform/qt/tables/mozilla/marvin/x_th_nowrap-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_tr_bgcolor_name-expected.png:
  • platform/qt/tables/mozilla/marvin/x_tr_bgcolor_name-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.png:
  • platform/qt/tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.txt:
  • platform/qt/tables/mozilla/other/cell_widths-expected.png:
  • platform/qt/tables/mozilla/other/cell_widths-expected.txt:
  • platform/qt/tables/mozilla/other/nestedTables-expected.png:
  • platform/qt/tables/mozilla/other/nestedTables-expected.txt:
  • platform/qt/tables/mozilla/other/test3-expected.png:
  • platform/qt/tables/mozilla/other/test3-expected.txt:
  • platform/qt/tables/mozilla/other/test6-expected.png:
  • platform/qt/tables/mozilla/other/test6-expected.txt:
  • platform/qt/tables/mozilla/other/wa_table_thtd_rowspan-expected.png:
  • platform/qt/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
  • platform/qt/tables/mozilla/other/wa_table_tr_align-expected.png:
  • platform/qt/tables/mozilla/other/wa_table_tr_align-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug10140-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug101759-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug101759-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug10216-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug10216-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug1055-2-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug106966-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug14007-1-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug14007-1-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug19526-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug19526-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug220653-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug22122-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug22122-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug32205-1-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug67915-2-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug67915-2-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug7243-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug7243-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug80762-2-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug91057-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/core/backgrounds-expected.png:
  • platform/qt/tables/mozilla_expected_failures/core/backgrounds-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/core/captions1-expected.png:
  • platform/qt/tables/mozilla_expected_failures/core/captions1-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/core/captions2-expected.png:
  • platform/qt/tables/mozilla_expected_failures/core/captions2-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/core/captions3-expected.png:
  • platform/qt/tables/mozilla_expected_failures/core/captions3-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/core/col_span2-expected.png:
  • platform/qt/tables/mozilla_expected_failures/core/col_span2-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/core/columns-expected.png:
  • platform/qt/tables/mozilla_expected_failures/core/columns-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/core/conflicts-expected.png:
  • platform/qt/tables/mozilla_expected_failures/core/conflicts-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/core/standards1-expected.png:
  • platform/qt/tables/mozilla_expected_failures/core/standards1-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/other/empty_cells-expected.png:
  • platform/qt/tables/mozilla_expected_failures/other/empty_cells-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/qt/tables/mozilla_expected_failures/other/test4-expected.txt:
  • platform/qt/transforms/2d/transform-fixed-container-expected.png:
  • platform/qt/transforms/2d/transform-fixed-container-expected.txt:
  • platform/qt/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png: Added.
  • platform/qt/transforms/3d/point-mapping/3d-point-mapping-deep-expected.txt:
  • platform/qt/transforms/3d/point-mapping/3d-point-mapping-expected.png:
  • platform/qt/transforms/3d/point-mapping/3d-point-mapping-expected.txt:
  • platform/qt/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
  • platform/qt/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt:
7:32 AM Changeset in webkit [130285] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Implement focus/unfocus in UIClient
https://bugs.webkit.org/show_bug.cgi?id=98253

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-03
Reviewed by Gyuyoung Kim.

Implement focus-related functionality in
WebKitEFL's UIClient.

  • UIProcess/API/efl/ewk_view_ui_client.cpp:

(focus):
(unfocus):
(takeFocus):
(ewk_view_ui_client_attach):

7:29 AM Changeset in webkit [130284] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: After "Edit as HTML", any click outside box should stop editing
https://bugs.webkit.org/show_bug.cgi?id=98258

Reviewed by Vsevolod Vlasov.

Make the DOM tree OL span the entire height of its container in the Elements panel to catch mouse events.

  • inspector/front-end/elementsPanel.css:

(#elements-content > ol):

7:09 AM Changeset in webkit [130283] by Csaba Osztrogonác
  • 6 edits in trunk

[Qt] Enable mock scrollbars
https://bugs.webkit.org/show_bug.cgi?id=98011

Patch by Balazs Kelemen <kbalazs@webkit.org> on 2012-10-03
Reviewed by Csaba Osztrogonác.

Source/WebKit/qt:

Added helper to enable mock scrollbars.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::enableMockScrollbars):

  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

Enable mock scrollbars for the Qt port. This patch will require a huge rebaseline.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::DumpRenderTree):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

6:54 AM Changeset in webkit [130282] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] [WK2] Add favicon support to the MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=98063

Patch by Alberto Garcia <agarcia@igalia.com> on 2012-10-03
Reviewed by Carlos Garcia Campos.

Set the icon in the URI text entry using the favicon property of
the WebKitWebView.

  • MiniBrowser/gtk/BrowserWindow.c:

(_BrowserWindow):
(updateUriEntryIcon):
(uriEntryTextChanged):
(faviconChanged):
(browserWindowFinalize):
(browser_window_init):
(browserWindowConstructed):

6:13 AM Changeset in webkit [130281] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk/Source/WebCore

[EFL] Skeleton code of File system API.
https://bugs.webkit.org/show_bug.cgi?id=91187

Patch by Dongwoo Joshua Im <dw.im@samsung.com> on 2012-10-03
Reviewed by Gyuyoung Kim.

Add skeleton code of File System API on EFL port.
Implementation patches will be created later.

No new tests because this is just skeleton code.

  • CMakeLists.txt: Add new files which created by other patches in Modules/filesystem/ directory.
  • PlatformEfl.cmake: Add AsyncFileSystemEfl.cpp.
  • platform/AsyncFileSystem.cpp:

(WebCore):

  • platform/efl/AsyncFileSystemEfl.cpp: Added.
  • platform/efl/AsyncFileSystemEfl.h: Added.
6:09 AM Changeset in webkit [130280] by rakuco@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

[EFL] Update pixel expectations for some css2.1 tests.

  • platform/efl/css2.1/20110323/c543-txt-decor-000-expected.png: Added.
  • platform/efl/css2.1/20110323/replaced-elements-001-expected.png:
6:06 AM Changeset in webkit [130279] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

[GTK] WebKitWebView doesn't emit notify:favicon when it changes in some cases in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=98153

Reviewed by Martin Robinson.

The main problem is that it relies on icon-ready signal to be
emitted by the favicon database, but that signal is only emitted
when the icon is loaded from the network or imported from the
database, but not when the icon is already in memory. The way to
detect if a web page doesn't have a favicon or it's unknown it's
also incorrectly done and the wrong error is returned for pages
not having a favicon.

  • UIProcess/API/gtk/WebKitFaviconDatabase.cpp:

(GetFaviconSurfaceAsyncData): Add a GError field.
(getIconSurfaceSynchronously): Add a GError parameter and fill it
accordingly. Use imageForPageURL() instead of
nativeImageForPageURL() because the latter always returns NULL for
empty images, so it's not possible to know whether it's an empty
image or not. If the image is empty is because the web page is
known by the database and it doesn't have a favicon.
(processPendingIconsForURI): Pass the data error to
getIconSurfaceSynchronously(). Don't set the icon if the request
has been cancelled.
(webkitFaviconDatabaseGetFavicon): Pass NULL as error to
getIconSurfaceSynchronously().
(setErrorForAsyncResult): Fill also error for
WEBKIT_FAVICON_DATABASE_ERROR_FAVICON_UNKNOWN.
(webkit_favicon_database_get_favicon): If we get NULL as icon in
the first place, check the error code returned by
getIconSurfaceSynchronously() and return early if the page doesn't
have a favicon. Remove the cancelled signal to avoid race
conditions.
(webkit_favicon_database_get_favicon_finish): Errors are processed
before now, so simply propagate the error if any or return the
favicon.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(_WebKitWebViewPrivate): Keep a reference of the favicon.
(webkitWebViewCancelFaviconRequest): Cancel any async operation to
get the favicon.
(webkitWebViewUpdateFavicon): Check if favicon has changed and
save it emitting also notify::favicon signal.
(iconReadyCallback): Only update the favicon if we don't have one
already.
(webkitWebViewFinalize): Call webkitWebViewCancelFaviconRequest().
(getFaviconReadyCallback): Update the favicon.
(webkitWebViewRequestFavicon): Request a new favicon.
(webkitWebViewLoadChanged): Try to get the favicon when the load
has been committed and the URI is the final one.
(webkit_web_view_get_favicon): Return the cached favicon.

  • UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp:

(serverCallback):
(testSetDirectory):
(testGetFavicon):
(testWebViewFavicon):

5:55 AM Changeset in webkit [130278] by kling@webkit.org
  • 4 edits in trunk/Source/WebCore

Shrink ElementRareData by moving bool flags to NodeRareData.
<http://webkit.org/b/98225>

Reviewed by Antti Koivisto.

Move all bool flags from ElementRareData to the bitfield in its base class NodeRareData.
This shrinks ElementRareData by 8 bytes (on 64-bit) and saves a whopping 58kB on Membuster3.
Also removed some double raredata hash lookups.

  • dom/Element.cpp:

(WebCore::Element::detach):
(WebCore::Element::recalcStyle):
(WebCore::Element::ensureShadow):
(WebCore::Element::setStyleAffectedByEmpty):
(WebCore::Element::styleAffectedByEmpty):
(WebCore::Element::setIsInCanvasSubtree):
(WebCore::Element::isInCanvasSubtree):
(WebCore::Element::containsFullScreenElement):
(WebCore::Element::setContainsFullScreenElement):

  • dom/ElementRareData.h:

(ElementRareData):
(WebCore::ElementRareData::ElementRareData):

  • dom/NodeRareData.h:

(WebCore::NodeRareData::styleAffectedByEmpty):
(WebCore::NodeRareData::setStyleAffectedByEmpty):
(WebCore::NodeRareData::isInCanvasSubtree):
(WebCore::NodeRareData::setIsInCanvasSubtree):
(NodeRareData):
(WebCore::NodeRareData::containsFullScreenElement):
(WebCore::NodeRareData::setContainsFullScreenElement):

5:16 AM Changeset in webkit [130277] by commit-queue@webkit.org
  • 5 edits in trunk

getComputedStyle perspective-origin is based on the wrong bounding box
https://bugs.webkit.org/show_bug.cgi?id=98027

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-10-03
Reviewed by Simon Fraser.

Source/WebCore:

perspective-origin for ComputedStyleDeclaration is currently calculated using the
wrong bounding box (sizingBox() which ends up as the contentbox).

Start using borderbox for ComputedStyleDeclaration perspective-origin, similar to
what transform-origin already does.

Test: fast/css/getComputedStyle/getComputedStyle-origin-percentage.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Add test for perspective-origin calculation into existing transform-origin test.

  • transforms/2d/computed-style-origin-expected.txt:
  • transforms/2d/computed-style-origin.html:
4:53 AM Changeset in webkit [130276] by commit-queue@webkit.org
  • 2 edits in trunk/Websites/bugs.webkit.org

ruby1.9 fails in PrettyPatch.rb with invalid byte sequence in UTF-8
https://bugs.webkit.org/show_bug.cgi?id=91212

Patch by Simon Pena <Simon Pena> on 2012-10-03
Reviewed by Hajime Morita.

ruby1.9 changed the way it handles encoding, so the gsub method used
when normalizing line ending complains of invalid byte sequence in UTF-8.
This patch uses the "encode" string method for versions of Ruby >= 1.9
to provide the encoding conversion (keeping the current implementation in
Ruby 1.8).

  • PrettyPatch/PrettyPatch.rb: Use the "encode" string method for encoding

conversion when the Ruby version is >= 1.9.

4:30 AM Changeset in webkit [130275] by caseq@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed test rebaseline.

  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac/fast/css/text-overflow-input-expected.png:
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
4:04 AM Changeset in webkit [130274] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Build fix for WinCE after r130160.

  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::glyphDataAndPageForCharacter):

3:15 AM Changeset in webkit [130273] by dominik.rottsches@intel.com
  • 7 edits in trunk/LayoutTests

[EFL] Gardening after r130186 and r130231

Unreviewed, EFL gardening.

r130186 introduces usage of Xvfb which allows us to unskip a few X11 dependent cases.
r130231 introduces caching for the Harfbuzz font path, which caused regressions on Harfbuzz NG + Freetype,
see bug 98247. Temporarily going to skip those failures until I check Kenichi's patch.

  • platform/efl-wk1/TestExpectations: DRT disables X11 usage, skip a few tests here only for Wk1.
  • platform/efl-wk2/TestExpectations: Unskip a couple of X11 dependent cases. (r130186)
  • platform/efl/TestExpectations: Temporarily mark a few complex font text as failed (r130231)
  • platform/efl/fast/text/atsui-multiple-renderers-expected.png: Rebaseline incorrect result.
  • platform/efl/fast/text/atsui-spacing-features-expected.png: Rebaseline incorrect result.
  • platform/efl/fast/text/wide-zero-width-space-expected.png: Rebaseline incorrect result.
3:12 AM Changeset in webkit [130272] by yurys@chromium.org
  • 5 edits in trunk/Source/WTF

Remove MemoryInstrumentation::addCollectionElements
https://bugs.webkit.org/show_bug.cgi?id=98245

Reviewed by Vsevolod Vlasov.

Removed MemoryInstrumentation::addCollectionElements and switched all call sites
to reportSequenceMemoryUsage.

Drive-by fix: removed some unused methods on MemoryInstrumentation.

  • wtf/MemoryInstrumentation.h:
  • wtf/MemoryInstrumentationHashSet.h:

(WTF::reportMemoryUsage):

  • wtf/MemoryInstrumentationSequence.h:

(WTF::SequenceMemoryInstrumentationTraits::reportMemoryUsage):

  • wtf/MemoryInstrumentationVector.h:

(WTF::reportMemoryUsage):

2:52 AM Changeset in webkit [130271] by commit-queue@webkit.org
  • 4 edits in trunk

[Qt][DRT] Add support for overriding the "WebKitDisplayImagesKey" preference.
https://bugs.webkit.org/show_bug.cgi?id=98200

Patch by Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> on 2012-10-03
Reviewed by Csaba Osztrogonác.

Tools:

  • DumpRenderTree/qt/TestRunnerQt.cpp:

(TestRunner::overridePreference):

LayoutTests:

  • platform/qt/TestExpectations: Unskip a few tests that depended

on this feature.

2:52 AM Changeset in webkit [130270] by tommyw@google.com
  • 9 edits in trunk/Source

MediaStream API: RTCPeerConnection should send down its handler via the FrameLoaderClient directly after creation.
https://bugs.webkit.org/show_bug.cgi?id=98149

Reviewed by Adam Barth.

Source/WebCore:

The chromium implementation needs to know which Frame created a PeerConnection so
that the right housekeeping can take place correctly.

Not testable in DRT, but have verified the change manually and with our pyautotests.

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::RTCPeerConnection):

  • loader/FrameLoaderClient.h:

(WebCore):
(FrameLoaderClient):
(WebCore::FrameLoaderClient::dispatchWillStartUsingPeerConnectionHandler):

  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:

(WebCore::RTCPeerConnectionHandlerChromium::toWebRTCPeerConnectionHandler):
(WebCore):
(WebCore::RTCPeerConnectionHandlerChromium::RTCPeerConnectionHandlerChromium):
(WebCore::RTCPeerConnectionHandlerChromium::initialize):

  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:

(RTCPeerConnectionHandlerChromium):

Source/WebKit/chromium:

Adding willStartUsingPeerConnectionHandler to the WebFrameClient.

  • public/WebFrameClient.h:

(WebKit):
(WebFrameClient):
(WebKit::WebFrameClient::willStartUsingPeerConnectionHandler):

  • src/FrameLoaderClientImpl.cpp:

(WebKit):
(WebKit::FrameLoaderClientImpl::dispatchWillStartUsingPeerConnectionHandler):

  • src/FrameLoaderClientImpl.h:

(FrameLoaderClientImpl):

2:50 AM Changeset in webkit [130269] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Profiles: taking heap snapshot causes error message in console.
https://bugs.webkit.org/show_bug.cgi?id=97890

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-10-03
Reviewed by Yury Semikhatsky.

Actual problem is that proxy loader is closed twice.

"_snapshotReceived" should never try to close receiver,
because it is a callback fired by close.

Also minor glitches fixed:

  • taking snapshot shows "Loading..." status first,

and then "Saving xxx%";

  • after all chunks are sent "Parsing" status is set and

then is replaced with "Saving 100%";

  • removed dead code in proxy;
  • proxy was ignoring callback parameter;
  • "Loading %d\%" is not localized.
  • English.lproj/localizedStrings.js: Added missing "Loading %d%" string.
  • inspector/front-end/HeapSnapshotProxy.js: Removed dead code.

(WebInspector.HeapSnapshotLoaderProxy):
(WebInspector.HeapSnapshotLoaderProxy.prototype.write): Make this method
interface-conformant.

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapProfileHeader): Fixed update-status and
finish-transfer logic.

2:48 AM Changeset in webkit [130268] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/Source/WebKit/chromium

WebImage::framesFromData should skip corrupted frames
https://bugs.webkit.org/show_bug.cgi?id=98214

Patch by Peter Kotwicz <pkotwicz@google.com> on 2012-10-03
Reviewed by Adam Barth.

WebImage::framesFromData() should only return bitmaps for valid frames
of a .ico file.

  • src/WebImageSkia.cpp:

(WebKit::WebImage::framesFromData):

  • tests/WebImageTest.cpp:

(WebKit::TEST):
(WebKit):

  • tests/data/valid_header_missing_bitmap.ico: Added.
2:45 AM Changeset in webkit [130267] by jochen@chromium.org
  • 6 edits
    4 adds in trunk

Make sure that user gestures can't be consumed twice
https://bugs.webkit.org/show_bug.cgi?id=97483

Reviewed by Adam Barth.

Source/WebCore:

Instead of a simple counter, use a ref counted token to track how many
user gestures happened and where consumed. When creating a timer that
is supposed to forward the user gesture, take a reference to this token
and reinstantiate the UserGestureIndicator with that token when the
timer is triggered.

Tests: platform/chromium/fast/events/popup-forwarded-gesture-blocked.html

platform/chromium/fast/events/popup-forwarded-gesture.html

  • dom/UserGestureIndicator.cpp:

(WebCore):
(WebCore::UserGestureIndicator::UserGestureIndicator):
(WebCore::UserGestureIndicator::~UserGestureIndicator):
(WebCore::UserGestureIndicator::processingUserGesture):
(WebCore::UserGestureIndicator::consumeUserGesture):
(WebCore::UserGestureIndicator::currentToken):

  • dom/UserGestureIndicator.h:

(Token):
(WebCore::UserGestureIndicator::Token::~Token):
(UserGestureIndicator):

  • page/DOMTimer.cpp:

(WebCore::DOMTimer::DOMTimer):
(WebCore::DOMTimer::fired):

  • page/DOMTimer.h:

(DOMTimer):

LayoutTests:

  • platform/chromium/fast/events/popup-forwarded-gesture-blocked-expected.txt: Added.
  • platform/chromium/fast/events/popup-forwarded-gesture-blocked.html: Added.
  • platform/chromium/fast/events/popup-forwarded-gesture-expected.txt: Added.
  • platform/chromium/fast/events/popup-forwarded-gesture.html: Added.
2:30 AM WebKit Team edited by rakuco@webkit.org
Update my affiliation again (diff)
2:23 AM Changeset in webkit [130266] by dmazzoni@google.com
  • 5 edits
    2 adds in trunk

AX: Heap-use-after-free when deleting a ContainerNode with an AX object
https://bugs.webkit.org/show_bug.cgi?id=98073

Reviewed by Hajime Morita.

Source/WebCore:

Calls axObjectCache()->remove(this) in ~ContainerNode so that the AX tree
doesn't try to access the container node while walking up the parent chain
from one of the container node's children.

Test: accessibility/container-node-delete-causes-crash.html

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::~ContainerNode):

  • dom/Node.cpp:

(WebCore::Node::~Node):

  • dom/Node.h:

(WebCore::Node::document):
(WebCore::Node::documentInternal):

LayoutTests:

Adds test for heap-use-after-free when container node with AX object is deleted.

  • accessibility/container-node-delete-causes-crash-expected.txt: Added.
  • accessibility/container-node-delete-causes-crash.html: Added.
2:03 AM Changeset in webkit [130265] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Tools

[Qt][WRT] Fix build error with MSVC on Windows.
https://bugs.webkit.org/show_bug.cgi?id=97697

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-10-03
Reviewed by Simon Hausmann.

WTR build is failing when WebKit directory is located on a longer path.
This seems to caused by source files that has the same name in
WTR and DRT directories. The solution is removing referencies
from Target.pri to DRT directory and adding an alternate version of
the required files to WTR. Those files simply include the real ones from DRT.

  • WebKitTestRunner/InjectedBundle/Target.pri:
  • WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Added.
  • WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Added.
1:54 AM Changeset in webkit [130264] by vsevik@chromium.org
  • 4 edits in trunk

Web Inspector: SourceURL should be taken from debugger agent when possible.
https://bugs.webkit.org/show_bug.cgi?id=98239

Reviewed by Yury Semikhatsky.

Source/WebCore:

Removed a check that sourceURL coming from js engine is the same as the one parsed by debugger agent.
Alwys use the one from debugger agent now.

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::didParseSource):

LayoutTests:

Unskipped test.

  • platform/chromium/TestExpectations:
1:50 AM Changeset in webkit [130263] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed. Touch FrameView.cpp file for fixing mac bot compilation.

  • page/FrameView.cpp:

(WebCore):

1:43 AM Changeset in webkit [130262] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WK2][WKTR] TestRunner.setAlwaysAcceptCookies() causes flakiness
https://bugs.webkit.org/show_bug.cgi?id=98238

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-03
Reviewed by Csaba Osztrogonác.

Reset AlwaysAcceptCookies setting between tests to avoid
flakiness due to TestRunner.setAlwaysAcceptCookies().

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

1:33 AM Changeset in webkit [130261] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: "Load profile..." context menu item has to be shown only for left column with the list of profiles.
https://bugs.webkit.org/show_bug.cgi?id=98163

Reviewed by Yury Semikhatsky.

The text was changed to "Load Heap Snapshot..."
Also I changed "Save profile..." to "Save Heap Snapshot..." because other profiles don't support Save/Load operations yet.
The Load context menu item will appear only when the user clicked in sidebar the tree empty space or a profile.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype._handleContextMenuEvent):
(WebInspector.ProfileSidebarTreeElement.prototype.handleContextMenuEvent):

1:01 AM Changeset in webkit [130260] by commit-queue@webkit.org
  • 21 edits
    3 copies in trunk

Add data passing to the GetStats interface of RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=98003

Patch by Harald Alvestrand <hta@google.com> on 2012-10-03
Reviewed by Adam Barth.

Source/Platform:

  • Platform.gypi:
  • chromium/public/WebRTCStatsRequest.h:

(WebKit):
(WebRTCStatsRequest):

  • chromium/public/WebRTCStatsResponse.h: Added.

(WebCore):
(WebKit):
(WebRTCStatsResponse):
(WebKit::WebRTCStatsResponse::WebRTCStatsResponse):
(WebKit::WebRTCStatsResponse::~WebRTCStatsResponse):
(WebKit::WebRTCStatsResponse::operator=):

Source/WebCore:

Added an RTCStatsResponseBase interface to platform, and let the
RTCStatsRequestImpl class produce an implementation of it that's returned
to WebCore.

Tested by extension of the RTCPeerConnection-stats.html test.

  • Modules/mediastream/RTCStatsElement.cpp:

(WebCore::RTCStatsElement::addStatistic):
(WebCore):

  • Modules/mediastream/RTCStatsElement.h:

(RTCStatsElement):

  • Modules/mediastream/RTCStatsReport.cpp:

(WebCore):
(WebCore::RTCStatsReport::addElement):
(WebCore::RTCStatsReport::addStatistic):

  • Modules/mediastream/RTCStatsReport.h:

(RTCStatsReport):

  • Modules/mediastream/RTCStatsRequestImpl.cpp:

(WebCore::RTCStatsRequestImpl::createResponse):
(WebCore):
(WebCore::RTCStatsRequestImpl::requestSucceeded):

  • Modules/mediastream/RTCStatsRequestImpl.h:

(RTCStatsRequestImpl):

  • Modules/mediastream/RTCStatsResponse.cpp:

(WebCore::RTCStatsResponse::create):
(WebCore::RTCStatsResponse::addReport):
(WebCore):
(WebCore::RTCStatsResponse::addElement):
(WebCore::RTCStatsResponse::addStatistic):

  • Modules/mediastream/RTCStatsResponse.h:

(RTCStatsResponse):

  • WebCore.gypi:
  • platform/chromium/support/WebRTCStatsRequest.cpp:

(WebKit::WebRTCStatsRequest::response):
(WebKit):
(WebKit::WebRTCStatsRequest::requestSucceeded):

  • platform/chromium/support/WebRTCStatsResponse.cpp: Added.

(WebKit):
(WebKit::WebRTCStatsResponse::WebRTCStatsResponse):
(WebKit::WebRTCStatsResponse::assign):
(WebKit::WebRTCStatsResponse::reset):
(WebKit::WebRTCStatsResponse::operator WTF::PassRefPtr<WebCore::RTCStatsResponseBase>):
(WebKit::WebRTCStatsResponse::addReport):
(WebKit::WebRTCStatsResponse::addElement):
(WebKit::WebRTCStatsResponse::addStatistic):

  • platform/mediastream/RTCStatsRequest.h:

(WebCore):
(RTCStatsRequest):

  • platform/mediastream/RTCStatsResponseBase.h: Added.

(WebCore):
(RTCStatsResponseBase):
(WebCore::RTCStatsResponseBase::~RTCStatsResponseBase):

Tools:

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(RTCStatsRequestSucceededTask::RTCStatsRequestSucceededTask):
(MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
(MockWebRTCPeerConnectionHandler::addStream):
(MockWebRTCPeerConnectionHandler::removeStream):
(MockWebRTCPeerConnectionHandler::getStats):

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:

(MockWebRTCPeerConnectionHandler):

LayoutTests:

  • fast/mediastream/RTCPeerConnection-stats-expected.txt:
  • fast/mediastream/RTCPeerConnection-stats.html:
12:56 AM Changeset in webkit [130259] by Carlos Garcia Campos
  • 31 edits in trunk/Source

[GTK] Add API to get the web view that initiated a custom URI request to WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=97895

Reviewed by Martin Robinson.

Source/WebCore:

  • platform/network/NetworkingContext.h:

(NetworkingContext): Add initiatingPageID().

  • platform/network/ResourceHandle.h:

(ResourceHandle): Add static method
getSoupRequestInitiaingPageID().

  • platform/network/ResourceHandleInternal.h:

(ResourceHandleInternal): Add initiatingPageID().

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::ResourceHandleInternal::initiatingPageID): Get the
initiating page ID of the resource handle networking context.
(WebCore::setSoupRequestInitiaingPageID): Helper function to
attach a page ID to a SoupRequest.
(WebCore::startHTTPRequest): Call setSoupRequestInitiaingPageID()
to attch the initiating page ID to the SoupRequest.
(WebCore::startNonHTTPRequest): Ditto.
(WebCore::ResourceHandle::getSoupRequestInitiaingPageID): Static
method to get the page ID attached to a SoupRequest.

Source/WebKit/efl:

  • WebCoreSupport/FrameNetworkingContextEfl.cpp:

(WebCore::FrameNetworkingContextEfl::initiatingPageID): Stub
implementation.

  • WebCoreSupport/FrameNetworkingContextEfl.h:

(FrameNetworkingContextEfl): Added.

Source/WebKit/gtk:

  • WebCoreSupport/FrameNetworkingContextGtk.cpp:

(WebKit::FrameNetworkingContextGtk::initiatingPageID): Stub
implementation.

  • WebCoreSupport/FrameNetworkingContextGtk.h:

(FrameNetworkingContextGtk): Added.

Source/WebKit2:

The message DidReceiveURIRequest is now sent to the page that
initiated the request that forwards the mesassage to the
WebSoupRequestManagerProxy.

  • UIProcess/API/C/soup/WKSoupRequestManager.h: Update

didReceiveURIRequest callback to receive the initiating page ID.

  • UIProcess/API/efl/ewk_context_request_manager_client.cpp:

(didReceiveURIRequest): Update the callback API change.

  • UIProcess/API/gtk/WebKitRequestManagerClient.cpp:

(didReceiveURIRequest): Pass the initiating page to the
WebKitURISchemeRequest constructor.

  • UIProcess/API/gtk/WebKitURISchemeRequest.cpp:

(_WebKitURISchemeRequestPrivate): Keep a reference to the
WebPageProxy that initiatesd the request.
(webkitURISchemeRequestCreate): Save the initiating page.
(webkit_uri_scheme_request_get_web_view): Return the view widget
of the initiating WebPageProxy.

  • UIProcess/API/gtk/WebKitURISchemeRequest.h:
  • UIProcess/API/gtk/WebKitURISchemeRequestPrivate.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.
  • UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveURIRequest): Forward the request
to the soup request manager proxy.

  • UIProcess/WebPageProxy.h:

(WebPageProxy): Add didReceiveURIRequest().

  • UIProcess/WebPageProxy.messages.in: Add DidReceiveURIRequest

message.

  • UIProcess/soup/WebSoupRequestManagerClient.cpp:

(WebKit::WebSoupRequestManagerClient::didReceiveURIRequest):
Pass the inititing page to the client callback.

  • UIProcess/soup/WebSoupRequestManagerClient.h:

(WebSoupRequestManagerClient):

  • UIProcess/soup/WebSoupRequestManagerProxy.cpp:

(WebKit::WebSoupRequestManagerProxy::didReceiveURIRequest): Pass
the inititing page to the client.

  • UIProcess/soup/WebSoupRequestManagerProxy.h:

(WebSoupRequestManagerProxy):

  • UIProcess/soup/WebSoupRequestManagerProxy.messages.in: Remove

DidReceiveURIRequest message.

  • WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:

(WebKit::WebFrameNetworkingContext::WebFrameNetworkingContext):
Save the pageID of the WebFrame.
(WebKit::WebFrameNetworkingContext::initiatingPageID): Return the
inititing page ID.

  • WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:
  • WebProcess/soup/WebSoupRequestManager.cpp:

(WebKit::WebSoupRequestManager::send): Send DidReceiveURIRequest
message to the WebPage that initiated the request.

12:47 AM QtWebKitBuildBots edited by kkristof@inf.u-szeged.hu
(diff)
12:31 AM Changeset in webkit [130258] by vsevik@chromium.org
  • 2 edits in branches/chromium/1271/Source/WebCore/inspector/front-end

Merge 129775 - Web Inspector: [REGRESSION] Breakpoints are not always shown in breakpoints sidebar pane.
https://bugs.webkit.org/show_bug.cgi?id=97783

Reviewed by Pavel Feldman.

BreakpointSidebarPane now explicitly adds all breakpoints that are available at the moment of its creation.

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype._filteredBreakpointLocations):
(WebInspector.BreakpointManager.prototype.breakpointLocationsForUISourceCode):
(WebInspector.BreakpointManager.prototype.allBreakpointLocations):

  • inspector/front-end/BreakpointsSidebarPane.js:

(WebInspector.JavaScriptBreakpointsSidebarPane):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointAdded):

TBR=vsevik@chromium.org
BUG=152684
Review URL: https://codereview.chromium.org/11048015

Oct 2, 2012:

11:57 PM Changeset in webkit [130257] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix for the GTK port after r130207.
Use proper file separators for new entries.

  • GNUmakefile.list.am:
11:31 PM Changeset in webkit [130256] by tkent@chromium.org
  • 4 edits in trunk/Source/WebCore

Introduce DateComponents::minimumYear and maximumYear
https://bugs.webkit.org/show_bug.cgi?id=98230

Reviewed by Kentaro Hara.

Share same difinitions in DateComponents.cpp and DateTimeFieldElements.cpp.

No new tests. This doesn't change any bahevior.

  • platform/DateComponents.h:

(WebCore::DateComponents::minimumYear): Moved from DateComponents.cpp.
(WebCore::DateComponents::maximumYear): ditto.

  • platform/DateComponents.cpp:

(WebCore): Move out static minimumYear and maximumYear.
(WebCore::DateComponents::parseYear): Use DateCompnents::minimumYear and/or maximumYear.
(WebCore::withinHTMLDateLimits): ditto.
(WebCore::DateComponents::parseWeek): ditto.
(WebCore::DateComponents::setMonthsSinceEpoch): ditto.
(WebCore::DateComponents::setMillisecondsSinceEpochForWeek): ditto.

  • html/shadow/DateTimeFieldElements.cpp:

(WebCore): Remove minimumYear and maximumYear.
(WebCore::DateTimeYearFieldElement::DateTimeYearFieldElement):
Use DateComponents::minimumYear and maximumYear.

11:28 PM Changeset in webkit [130255] by arko@motorola.com
  • 3 edits
    2 adds in trunk

Microdata: itemprop names must not override builtin properties.
https://bugs.webkit.org/show_bug.cgi?id=98025

Reviewed by Kentaro Hara.

Source/WebCore:

We should look in the prototype for functions before assuming it as
an item's name. Return false if the prototype of the object has a
property (function) with propertyName.
Named properties Spec: http://dev.w3.org/2006/webapi/WebIDL/#idl-named-properties
Named property visibility algorithm:
http://dev.w3.org/2006/webapi/WebIDL/#indexed-and-named-properties
...

  1. If the result of calling the HasProperty? internal method on

prototype with property name P is true, then return false.
...
Also [OverrideBuiltins] is not declared for any of the properties,
hence no overriding is allowed in this case.

Test: fast/dom/MicroData/itemprop-names-override-builtin-properties.html

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):

LayoutTests:

Added test case to verify that itemprop names must not override builtin properties.

  • fast/dom/MicroData/itemprop-names-override-builtin-properties-expected.txt: Added.
  • fast/dom/MicroData/itemprop-names-override-builtin-properties.html: Added.
11:24 PM Changeset in webkit [130254] by keishi@webkit.org
  • 5 edits in trunk

REGRESSION (r129738): Suggestion picker label is placed in the wrong location
https://bugs.webkit.org/show_bug.cgi?id=98094

Reviewed by Kent Tamura.

Source/WebCore:

We needed to reverse padding-left/right when rtl.

No new tests. Covered by date-suggestion-picker-appearance.html.

  • Resources/pagepopups/suggestionPicker.css:

(.suggestion-list-entry .label):
(.rtl .suggestion-list-entry .label):

LayoutTests:

  • platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png:
  • platform/chromium/TestExpectations:
11:15 PM Changeset in webkit [130253] by yurys@chromium.org
  • 14 edits
    2 copies in trunk/Source

Provide memory instrumentation for HashCountedSet
https://bugs.webkit.org/show_bug.cgi?id=98138

Reviewed by Pavel Feldman.

Source/WebCore:

Replaced addHashCountedSet calls with addMember that now automatically
detects HashCountedSet and calls appropriate routine.

  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::reportBaseClassMemoryUsage):

  • loader/cache/CachedResource.cpp:

Source/WebKit/chromium:

Added unit test for HashCountedSet memory instrumentation.

  • tests/MemoryInstrumentationTest.cpp:

Source/WTF:

Added memory instrumentation for HashCountedSet.

Extracted common routines for collecting memory info for an iterable sequence.

  • GNUmakefile.list.am:
  • WTF.gypi:
  • WTF.pro:
  • WTF.vcproj/WTF.vcproj:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/MemoryInstrumentation.h:

(WTF):

  • wtf/MemoryInstrumentationHashCountedSet.h: Copied from Source/WTF/wtf/MemoryInstrumentationHashSet.h.

(WTF):
(WTF::reportMemoryUsage):

  • wtf/MemoryInstrumentationHashMap.h:

(WTF::reportMemoryUsage):

  • wtf/MemoryInstrumentationHashSet.h:
  • wtf/MemoryInstrumentationSequence.h: Copied from Source/WTF/wtf/MemoryInstrumentationHashMap.h.

(WTF):
(WTF::SequenceMemoryInstrumentationTraits::reportMemoryUsage):
(WTF::reportSequenceMemoryUsage):

11:04 PM Changeset in webkit [130252] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Buildfix after r130235.

Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-10-02
Reviewed by Csaba Osztrogonác.

systemAllowsMultisamplingOnATICards was deleted from GraphicsContext3D,
but function body remained in GraphicsContext3DOpenGLES. Delete method body.

  • platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
11:00 PM Changeset in webkit [130251] by joone.hur@intel.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed, GTK+,Efl debug build fix after r130225.

This patch allows to include the static xErrorString variable when LOG_DISABLED is 0.

  • PluginProcess/unix/PluginProcessMainUnix.cpp:

(WebKit):

10:52 PM Changeset in webkit [130250] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix assertion failures on Chromium Debug bots for datetime/datetime-local input types.

  • html/shadow/DateTimeFieldElements.cpp:

If a placeholder stirng is empty, use a sequence of "-".
(WebCore::DateTimeDayFieldElement::create):
(WebCore::DateTimeMonthFieldElement::create):
(WebCore::DateTimeYearFieldElement::create):

10:26 PM Changeset in webkit [130249] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=98134
[Refactoring] StyleResolver::matchScopedAuthorRules() could be simpler.

Reviewed by Dimitri Glazkov.

matchScopedAuthorRules() did have some optimization which only
makes sense for heavily nested shadow tree. However, we don't see
such type of usage of Shadow DOM and this looks premature
optimization. This change unified its triple for loop into one,
which makes the code much simpler.

No new tests. Covered by existing tests.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::matchScopedAuthorRules):

10:12 PM Changeset in webkit [130248] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix a typo and add some \n's to make Mark happy.

Rubber-stamped by Mark "logging must be fast" Rowe.

  • WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:

(WebKit::InjectedBundle::load):

9:54 PM Changeset in webkit [130247] by tkent@chromium.org
  • 5 edits in trunk/Source/WebCore

Introduce Localizer::dateTimeFormatWithSecond and dateTimeFormatWithoutSecond
https://bugs.webkit.org/show_bug.cgi?id=98229

Reviewed by Kentaro Hara.

Unify identical code in DateTimeInputType and DateTimeLocalInputType as
Localizer member functions.
They still have some common code. We'll address it later.

No new tests. This doesn't change any behavior.

  • platform/text/Localizer.h:

(Localizer): Add dateTimeFormatWithSecond and dateTimeFormatWithoutSecond.

  • platform/text/Localizer.cpp:

(WebCore::Localizer::dateTimeFormatWithSecond):
Implemented. Just concatenating dateFormat, a space, and timeFormat.
(WebCore::Localizer::dateTimeFormatWithoutSecond):
Implemented. Just concatenating dateFormat, a space, and shortTimeFormat.

  • html/DateTimeInputType.cpp:

(WebCore::DateTimeInputType::setupLayoutParameters):
Use dateTimeFormatWithSecond and dateTimeFormatWithoutSecond.

  • html/DateTimeLocalInputType.cpp:

(WebCore::DateTimeLocalInputType::setupLayoutParameters): ditto.

9:30 PM Changeset in webkit [130246] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Refactoring: DateTimeEditBuilder had better hold LayoutParameters
https://bugs.webkit.org/show_bug.cgi?id=98228

Reviewed by Kentaro Hara.

Stop copying multiple members of LayoutParameters in DateTimeEditBuilder
constructor. This change improves code size and runtime cost.

No new tests. This doesn't change user-visible behavior.

  • html/shadow/DateTimeEditElement.cpp:

(DateTimeEditBuilder): Add a comment about lifetime of objects.
(WebCore::DateTimeEditBuilder::stepRange):
Added. A helper to access m_parameters.stepRange.
(WebCore::DateTimeEditBuilder::DateTimeEditBuilder):
Remove m_stepRange, m_localizer, m_placeholderFor* members.
Add m_parameters.
(WebCore::DateTimeEditBuilder::needMillisecondField):
Use stepRange() instead of m_stepRange.
(WebCore::DateTimeEditBuilder::visitField):
Use m_parameters.placeholderFor*.
(WebCore::DateTimeEditBuilder::shouldMillisecondFieldReadOnly):
Use stepRange() instead of m_stepRange.
(WebCore::DateTimeEditBuilder::shouldMinuteFieldReadOnly): ditto.
(WebCore::DateTimeEditBuilder::shouldSecondFieldReadOnly): ditto.

9:12 PM Changeset in webkit [130245] by weinig@apple.com
  • 3 edits
    1 move
    4 adds in trunk/Source/WebKit2

Add Objective-C API for the InjectedBundle
https://bugs.webkit.org/show_bug.cgi?id=98222

Reviewed by Anders Carlsson.

Add skeleton of the Objective-C API for the InjectedBundle.

  • WebKit2.xcodeproj/project.pbxproj:

Add new API files.

  • WebProcess/InjectedBundle/API/mac: Added.
  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h: Added.
  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm: Added.

(-[WKWebProcessPlugIn _initWithPrincipalClassInstance:injectedBundle:]):
Initialization method for the WKWebProcessPlugIn object. This object will act as the WKBundleRef
object does in the C-SPI.
(+[WKWebProcessPlugIn _shared]):
Access the shared instance.

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInInternal.h: Added.
  • WebProcess/InjectedBundle/InjectedBundle.h:

Store an NSBundle rather than a CFBundleRef as the platform bundle.

  • WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp: Removed.
  • WebProcess/InjectedBundle/mac/InjectedBundleMac.mm: Copied from Source/WebKit2/WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp.

(WebKit::InjectedBundle::load):
If a principal class is provided and no WKBundleInitialize function is present in the bundle, use the principal class
as the initialization point. The principal class must conform to the WKWebProcessPlugIn protocol and if a
webProcessPlugInInitialize: method is present, it is called.

6:38 PM Changeset in webkit [130244] by tkent@chromium.org
  • 3 edits in trunk/Source/WebCore

Implement LocaleICU::dateFormat
https://bugs.webkit.org/show_bug.cgi?id=98118

Reviewed by Hajime Morita.

http://trac.webkit.org/changeset/130127 introduced
Localizer::dateFormat, and this is its implementation for LocaleICU
classs. The code is going to be used when
ENABLE_INPUT_MULTIPLE_FIELDS_UI is enabled.

No new tests. The function is not used yet.

  • platform/text/LocaleICU.cpp:

(WebCore::LocaleICU::dateFormat):
Implemented. Note that m_shortDateFormat is a UDateFormat object, which
knows various format information.

  • platform/text/LocaleICU.h:

(LocaleICU): Add m_dateFormat to cache the format string.

6:25 PM Changeset in webkit [130243] by tkent@chromium.org
  • 3 edits in trunk/Source/WebCore

[Mac][Chromium-Mac] Implement LocaleMac::dateFormat
https://bugs.webkit.org/show_bug.cgi?id=98116

Reviewed by Hajime Morita.

http://trac.webkit.org/changeset/130127 introduced
Localizer::dateFormat, and this is its implementation for LocaleICU
classs. The code is going to be used when
ENABLE_INPUT_MULTIPLE_FIELDS_UI is enabled.

No new tests. The function is not used yet.

  • platform/text/mac/LocaleMac.h:

(LocaleMac): Declare m_dateFormat.

  • platform/text/mac/LocaleMac.mm:

(WebCore::LocaleMac::dateFormat): Implemented.

6:17 PM Changeset in webkit [130242] by tkent@chromium.org
  • 5 edits in trunk/Source

[Chromium-Win] Implement LocaleWin::dateFormat
https://bugs.webkit.org/show_bug.cgi?id=98117

Reviewed by Kentaro Hara.

Source/WebCore:

http://trac.webkit.org/changeset/130127 introduced
Localizer::dateFormat, and this is its implementation for LocaleICU
classs. The code is going to be used when
ENABLE_INPUT_MULTIPLE_FIELDS_UI is enabled.

Tests: Added a new test to WebKit/chromium/tests/LocaleWinTest.cpp.

  • platform/text/LocaleWin.cpp:

(WebCore::parseDateFormat):
Fix a continuous apostrophes parsing bug; "abc'def" produced "abcdef"
(WebCore::appendAsLDMLLiteral):
A helper function to make a literal string for LDML.
(WebCore::convertWindowsDateFormatToLDML):
Creates an LDML format from a parsed date format tokens.
(WebCore::LocaleWin::dateFormat):
Implemented. This uses convertWindowsDateFormatToLDML.
(WebCore::LocaleWin::dateFormat):
Added for testing. The source windows format is specified as a function
argument.

  • platform/text/LocaleWin.h:

(LocaleWin): Declare m_dateFormat and dateFormat().

Source/WebKit/chromium:

  • tests/LocaleWinTest.cpp:

(TEST_F): Add tests for LocaleWin::dateFormat.

6:09 PM Changeset in webkit [130241] by ojan@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Fix spelling of isNVIDIA override in Extensions3DChromium
https://bugs.webkit.org/show_bug.cgi?id=98219

Patch by Ian Vollick <vollick@chromium.org> on 2012-10-02
Reviewed by Dean Jackson.

The override in Extensions3dChromium should have been spelled isNVIDIA, not isNVidia.

No new tests. No change in functionality.

  • platform/graphics/chromium/Extensions3DChromium.h:

(WebCore::Extensions3DChromium::isNVIDIA):

5:42 PM Changeset in webkit [130240] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

Fixed a crash when the localization option is not passed to the web process.

Reviewed by Sam Weinig.

  • PluginProcess/mac/PluginProcessMainMac.mm:

(WebKit::PluginProcessMain): Changed to not call WKSetDefaultLocalization
with the empty string.

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain): Ditto.

5:34 PM Changeset in webkit [130239] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix the Snow Leopard build.

  • platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
5:31 PM Changeset in webkit [130238] by jsbell@chromium.org
  • 10 edits
    1 add in trunk/Source

Add htons/htonl definitions and implementations
https://bugs.webkit.org/show_bug.cgi?id=98054

Reviewed by Darin Adler.

Source/WebCore:

Update users of htons and friends to use new wtf/ByteOrder.h header.

No new tests - just refactoring.

  • platform/graphics/WOFFFileFormat.cpp:
  • platform/graphics/chromium/VDMXParser.cpp:

Source/WTF:

For parsing or serializing binary data, byte order matters. The canonical htons/htonl/
ntohs/ntohl functions are not present everywhere, so implementations are proliferating in
parsers. Expose a new WTF header (wtf/ByteOrder.h) that includes the standard
implementations on UNIX-like OSs and provides basic inlined implementations on Windows.

  • GNUmakefile.list.am:
  • WTF.gypi:
  • WTF.pro:
  • WTF.vcproj/WTF.vcproj:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/ByteOrder.h: Added.

(WTF::wswap32): Inline functions so arguments are only evaluated once.
(WTF::bswap32):
(WTF::bswap16):
(ntohs): Inline functions on OS(WINDOWS) to match macros on OS(UNIX)
(htons):
(ntohl):
(htonl):

  • wtf/CMakeLists.txt:
5:24 PM Changeset in webkit [130237] by Simon Fraser
  • 7 edits
    7 copies in trunk

Source/JavaScriptCore: == Rolled over to ChangeLog-2012-10-02 ==

Source/WebCore: == Rolled over to ChangeLog-2012-10-02 ==

Source/WebKit/chromium: == Rolled over to ChangeLog-2012-10-02 ==

Source/WebKit/mac: == Rolled over to ChangeLog-2012-10-02 ==

Source/WebKit2: == Rolled over to ChangeLog-2012-10-02 ==

Tools: == Rolled over to ChangeLog-2012-10-02 ==

LayoutTests: == Rolled over to ChangeLog-2012-10-02 ==

5:22 PM Changeset in webkit [130236] by Simon Fraser
  • 6 edits in trunk/Source/WebCore

Make TiledBacking slightly less aware of scrolling
https://bugs.webkit.org/show_bug.cgi?id=98216

Reviewed by Anders Carlsson.

TiledBacking shouldn't really care about there being scrollbars;
recast this in terms of "tile coverage", described by a bitfield
that has flags for coverage optimized for horizontal and vertical
scrolling. This allows for additional tile coverage behaviors later.

  • page/FrameView.cpp:

(WebCore::FrameView::performPostLayoutTasks):

  • platform/graphics/TiledBacking.h:
  • platform/graphics/ca/mac/TileCache.h:
  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::TileCache): Initialize m_isInWindow to false to
be more conservative. It gets explicitly set by the only caller now, so this is
not a behavior change.
(WebCore::TileCache::setIsInWindow):
(WebCore::TileCache::setTileCoverage):
(WebCore::TileCache::tileCoverageRect):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::RenderLayerBacking):

5:01 PM Changeset in webkit [130235] by dino@apple.com
  • 10 edits in trunk/Source/WebCore

Expose some GPU Information
https://bugs.webkit.org/show_bug.cgi?id=97813

Reviewed by Sam Weinig and Ken Russell and Tim Horton.

Currently there are a few places in the WebGL code (and elsewhere, like CSS filters)
where we do some feature detection by examining the GPU vendor and its capabilities.
This patch puts this detection into our shared Extensions3D object.

  • platform/graphics/Extensions3D.h: Adds the new methods for detecting vendor and features.
  • platform/graphics/GraphicsContext3D.h:

(GraphicsContext3D): No longer needs function to detect multisampling on ATI.

  • platform/graphics/chromium/Extensions3DChromium.h: Stub implementations of all

the new methods. Chromium does its detection elsewhere.
(WebCore::Extensions3DChromium::isNVIDIA):
(WebCore::Extensions3DChromium::isAMD):
(WebCore::Extensions3DChromium::isIntel):
(WebCore::Extensions3DChromium::vendor):
(Extensions3DChromium):
(WebCore::Extensions3DChromium::maySupportMultisampling):
(WebCore::Extensions3DChromium::requiresBuiltInFunctionEmulation):

  • platform/graphics/filters/FECustomFilter.cpp:

(WebCore::FECustomFilter::createMultisampleBuffer): Add test for system multisampling to
custom filter code.

  • platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore::DrawingBuffer::create): Add test for system multisampling to drawing buffer's
creation code.

  • platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:

(WebCore::Extensions3DOpenGLCommon::Extensions3DOpenGLCommon): Detects all the features
as the object is created.
(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE): Can now simply ask
itself if it needs to turn on built-in function translation.

  • platform/graphics/opengl/Extensions3DOpenGLCommon.h:

(Extensions3DOpenGLCommon):
(WebCore::Extensions3DOpenGLCommon::isNVIDIA):
(WebCore::Extensions3DOpenGLCommon::isAMD):
(WebCore::Extensions3DOpenGLCommon::isIntel):
(WebCore::Extensions3DOpenGLCommon::vendor):
(WebCore::Extensions3DOpenGLCommon::maySupportMultisampling):
(WebCore::Extensions3DOpenGLCommon::requiresBuiltInFunctionEmulation):

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::validateAttributes): Ask the extension object instead of
testing directly.

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::validateDepthStencil): Ask the extension object instead
of testing directly.

4:49 PM Changeset in webkit [130234] by dbates@webkit.org
  • 2 edits in trunk/Tools

Define watch list "webkitperl", "SVNScripts", and "XSS" to watch for changes
to Tools/Scripts/{VCSUtils.pm, webkitdirs.pm, webkitperl}, Tools/Scripts/svn-*
scripts, and files whose name contains the word "XSS", respectively. Subscribe
myself to these lists.

  • Scripts/webkitpy/common/config/watchlist:
4:47 PM Changeset in webkit [130233] by ojan@chromium.org
  • 139 edits in trunk/LayoutTests

Test rebaselines now that the Chromium Lion bot has been upgraded to 10.7.5.
All the differences are anti-aliasing in gradients.

4:40 PM Changeset in webkit [130232] by ap@apple.com
  • 3 edits in trunk/Source/WebKit2

<rdar://problem/12407920> Need to keep track of messages posted to injected bundle before creating a page
https://bugs.webkit.org/show_bug.cgi?id=98210

Reviewed by Anders Carlsson.

Restore the pending message functionality, but only for shared process mode, and
under a different name.

  • UIProcess/WebContext.cpp: (WebKit::WebContext::setProcessModel): (WebKit::WebContext::createNewWebProcess): (WebKit::WebContext::postMessageToInjectedBundle):
  • UIProcess/WebContext.h:
4:40 PM Changeset in webkit [130231] by bashi@chromium.org
  • 8 edits in trunk/Source/WebCore

[Chromium] Introduce caches for HarfBuzzShaper
https://bugs.webkit.org/show_bug.cgi?id=97993

Reviewed by Tony Chang.

  • Implement canRenderCombiningCharacterSequence() for ports which use

HarfBuzzShaper. This function caches the result and will improve the
performance of HarfBuzzShaper::collectHarfBuzzRuns.

  • Add a HashMap to HarfBuzzNGFace. It is used as a cache that holds

glyph indexes of codepoints. It reduces the number of
SkPaint::textToGlyphs() calls.

This patch makes the intl2 page cycler 4.4% faster on my machine.

No new tests. No changes in behavior.

  • platform/graphics/SimpleFontData.h:

(SimpleFontData): Enabled canRenderCombiningCharacterSequence() if USE(HARFBUZZ_NG) is enabled.

  • platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore):
(WebCore::SimpleFontData::canRenderCombiningCharacterSequence): Added.

  • platform/graphics/harfbuzz/ng/HarfBuzzNGFace.cpp:

(WebCore):
(FaceCacheEntry): Added.
(WebCore::HarfBuzzNGFace::HarfBuzzNGFace):
Lookup the cache entry in harfBuzzFaceCache. Create the entry if there is no entry in the cache.
Increment the ref count of the entry and set cache entry values to member variables.
(WebCore::HarfBuzzNGFace::~HarfBuzzNGFace):
Decrement the ref count of the cache entry. Remove the entry if no one refers the cache.

  • platform/graphics/harfbuzz/ng/HarfBuzzNGFace.h:

(HarfBuzzNGFace):

  • platform/graphics/harfbuzz/ng/HarfBuzzNGFaceSkia.cpp:

(HarfBuzzFontData): Added. Used as |userData| of harfbuzz callback functions.
(WebCore):
(WebCore::SkiaGetGlyphWidthAndExtents):
(WebCore::harfbuzzGetGlyph):
Look up the glyphChache first. If the cache entry doesn't exist, call
SkPaint::textToGlyphs() to get glyph index and store it to the cache.
(WebCore::harfbuzzGetGlyphHorizontalAdvance):
(WebCore::harfbuzzGetGlyphExtents):
(WebCore::destroyHarfBuzzFontData): Added.
(WebCore::HarfBuzzNGFace::createFont):
Create HarfBuzzFontData and pass it to harfbuzz.

  • platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:

(WebCore::HarfBuzzShaper::HarfBuzzRun::applyShapeResult):
Don't initialize m_glyphToCharacterIndexes here.
(WebCore::HarfBuzzShaper::collectHarfBuzzRuns):
Use SimpleFontData::canRenderCombiningCharacterSequence() instead of
fontDataForCombiningCharacterSequence().
(WebCore::HarfBuzzShaper::setGlyphPositionsForHarfBuzzRun):
Set glyphToCharacterIndexes of the current HarfBuzzRun.

  • platform/graphics/skia/SimpleFontDataSkia.cpp:

(WebCore):
(WebCore::SimpleFontData::canRenderCombiningCharacterSequence): Added.

4:24 PM Changeset in webkit [130230] by abarth@webkit.org
  • 1 delete in branches/chromium/wpotest

This test branch is no longer needed.

4:23 PM Changeset in webkit [130229] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=98182
REGRESSION (r130091): Scroll wheel no longer scrolls within div

Reviewed by Simon Fraser.

Forgot to initialize m_nonFastScrollableRegion in this copy
constructor.

  • page/scrolling/ScrollingStateScrollingNode.cpp:

(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):

4:22 PM Changeset in webkit [130228] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r128400): ASSERT (crash in release) @ app.asana.com
https://bugs.webkit.org/show_bug.cgi?id=98175

Reviewed by Oliver Hunt.

It's bad karma to create a new structure while stealing another structure's property table
while leaving the m_offset unset. Eventually someone will then steal your property table, and
then you won't know how many properties you have anymore.

  • runtime/Structure.cpp:

(JSC::Structure::nonPropertyTransition):

4:21 PM Changeset in webkit [130227] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Skipping flaky test fast/text/international/float-as-only-child-of-isolate-crash.html is flaky on Windows.
https://bugs.webkit.org/show_bug.cgi?id=98209

  • platform/win/TestExpectations:
4:14 PM Changeset in webkit [130226] by Nate Chapin
  • 4 edits
    4 adds in trunk

Source/WebCore: iframes with scrolling=no can't scroll to anchors
https://bugs.webkit.org/show_bug.cgi?id=96539

Reviewed by Antonio Gomes.

This appears to have regressed in r106730. This patch matches Firefox's behavior.

Test: fast/dom/HTMLAnchorElement/anchor-in-noscroll-iframe.html

  • page/EventHandler.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollRectToVisible): Currently scrolls are always forbidden

if scrollbars are explicitly disabled. This adds an exception for scrolls that
are not user-initiated and are not autoscrolls.

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=96539.

Reviewed by Antonio Gomes.

  • fast/dom/HTMLAnchorElement/anchor-in-noscroll-iframe-expected.txt: Added.
  • fast/dom/HTMLAnchorElement/anchor-in-noscroll-iframe.html: Added.
  • fast/dom/HTMLAnchorElement/resources: Added.
  • fast/dom/HTMLAnchorElement/resources/iframe-with-anchor.html: Added.
4:13 PM Changeset in webkit [130225] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unix plugin process: xErrorString does not need to be defined in release builds
https://bugs.webkit.org/show_bug.cgi?id=98174

Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2012-10-02
Reviewed by Alexey Proskuryakov.

The static xErrorString variable is used only for logging purposes,
so it causes a warning when doing relese builds (or, in general,
when logging is enabled). This disables building in the string
when LOG_DISABLED is defined.

Also, made the more constant by changing the "const char*" type
to "const char[]".

  • PluginProcess/unix/PluginProcessMainUnix.cpp:

(WebKit):

4:02 PM Changeset in webkit [130224] by Simon Fraser
  • 5 edits in trunk/Source/WebCore

Restore the virtual purity of TileBacking
https://bugs.webkit.org/show_bug.cgi?id=98208

Reviewed by Anders Carlsson.

Remove the data member on TileBacking, make the logging methods
virtual, and move the implememtation to TileCache.

  • platform/graphics/TiledBacking.h:
  • platform/graphics/ca/mac/TileCache.h:
  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::TileCache):

  • platform/graphics/ca/mac/WebTileLayer.mm:

(-[WebTileLayer drawInContext:]): Have to cast to call the public
method on the base class.

3:59 PM Changeset in webkit [130223] by roger_fong@apple.com
  • 2 edits in trunk/Tools

executive_unittest.py fails on Apple Windows bots but not when run locally.
https://bugs.webkit.org/show_bug.cgi?id=98196

Reviewed by Eric Seidel.

Making the test more flexible to check for cygwin and allow different outputs from process.wait().

  • Scripts/webkitpy/common/system/executive_unittest.py:

(ExecutiveTest.serial_test_kill_process):

3:45 PM Changeset in webkit [130222] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Fix crash in WebGeolocationManager constructor.

Defer adding the location manager until there actually is a connection.

  • WebProcess/Geolocation/WebGeolocationManager.cpp:

(WebKit::WebGeolocationManager::WebGeolocationManager):
(WebKit::WebGeolocationManager::registerWebPage):

  • WebProcess/Geolocation/WebGeolocationManager.h:

(WebGeolocationManager):

3:37 PM Changeset in webkit [130221] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Ignore failing line of SpacebarScrolling API test on Windows.
https://bugs.webkit.org/show_bug.cgi?id=84961

Reviewed by Anders Carlsson.

Test is failing because of https://bugs.webkit.org/show_bug.cgi?id=97946.
Ignoring the line that fails on Windows for now until the larger problem at hand is fixed.

  • TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:

(TestWebKitAPI::TEST):

3:29 PM Changeset in webkit [130220] by tony@chromium.org
  • 4 edits in trunk/Tools

check-webkit-style can't handle qt-arm, qt-win, qt-mac, qt-5.0, qt-5.0-wk1 and qt-5.0-wk2 TestExpecatations
https://bugs.webkit.org/show_bug.cgi?id=98140

Reviewed by Eric Seidel.

Fix a bug where we were always using the host OS rather than using what was passed in as part of the
port name on Qt.

There's also a bug with being able to test for qt-5.0 expectations files when on a system with
Qt 4.8 installed. I'm not sure how to solve that, so for now, stop emitting a style warning about
not checking a file.

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort._search_paths): Use passed in OS.

  • Scripts/webkitpy/style/checkers/test_expectations.py:

(TestExpectationsChecker.check): Don't warn if we don't know about the TestExpectations file.

  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py:

(TestExpectationsTestCase.test_determine_port_from_expectations_path): Added a test case for the OS fix.
Add a commented out test for the version case.

3:25 PM Changeset in webkit [130219] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix build.

  • WebProcess/Geolocation/WebGeolocationManager.cpp:

(WebKit::WebGeolocationManager::WebGeolocationManager):

3:20 PM Changeset in webkit [130218] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Comment additions after r130109

Rubber stamped by Geoffrey Garen.

Updated comments to how array storage works.

  • runtime/ArrayStorage.h:
  • runtime/JSArray.cpp:
3:11 PM Changeset in webkit [130217] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix infinite recursion inside WebProcess constructor
https://bugs.webkit.org/show_bug.cgi?id=98206

Reviewed by Brian Weinstein.

Don't call WebProcess::shared from the WebGeolocationManager constructor since it is invoked from the WebProcess constructor.

  • WebProcess/Geolocation/WebGeolocationManager.cpp:

(WebKit::WebGeolocationManager::WebGeolocationManager):

3:09 PM Changeset in webkit [130216] by Hugo Parente Lima
  • 7 edits in trunk/Source/WebKit2

[WK2] Move some tiled backing store/viewport functions from Qt to generic WebKit2 sources
https://bugs.webkit.org/show_bug.cgi?id=98199

Reviewed by Noam Rosenthal.

Move commitPageTransitionViewport from Qt to WebKit2.

  • UIProcess/WebPageProxy.cpp:

(WebKit):
(WebKit::WebPageProxy::commitPageTransitionViewport):

  • UIProcess/qt/WebPageProxyQt.cpp:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit):
(WebKit::WebPage::commitPageTransitionViewport):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/qt/WebPageQt.cpp:
3:04 PM Changeset in webkit [130215] by andersca@apple.com
  • 7 edits in trunk/Source

Build fixes.

Source/WebKit/mac:

  • Plugins/Hosted/NetscapePluginHostManager.mm:

(WebKit::NetscapePluginHostManager::spawnPluginHost):
(WebKit::NetscapePluginHostManager::didCreateWindow):

  • Plugins/Hosted/NetscapePluginHostProxy.h:

(NetscapePluginHostProxy):

  • Plugins/Hosted/NetscapePluginHostProxy.mm:

(WebKit::NetscapePluginHostProxy::didEnterFullscreen):
(WebKit::NetscapePluginHostProxy::didExitFullscreen):
(WebKit::NetscapePluginHostProxy::applicationDidBecomeActive):
(WebKit::NetscapePluginHostProxy::endModal):
(WebKit):
(WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
(WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess):
(WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess):

Source/WebKit2:

  • PluginProcess/mac/PluginProcessMac.mm:

(WebKit::beginModal):

  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::PluginProcessProxy::getPluginProcessSerialNumber):
(WebKit::PluginProcessProxy::makePluginProcessTheFrontProcess):
(WebKit::PluginProcessProxy::makeUIProcessTheFrontProcess):
(WebKit::PluginProcessProxy::exitFullscreen):

2:49 PM Changeset in webkit [130214] by ap@apple.com
  • 7 edits in trunk/Source/WebKit2

<rdar://problem/12407139> WebKit2 should provide API that returns all pages in the same process as a given page
https://bugs.webkit.org/show_bug.cgi?id=98193

Reviewed by Sam Weinig.

  • UIProcess/API/C/WKPage.cpp: (WKPageCopyRelatedPages):
  • UIProcess/API/C/WKPagePrivate.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::relatedPages):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::pages):
  • UIProcess/WebProcessProxy.h: Added. This should work once a process has crashed, too.
2:37 PM Changeset in webkit [130213] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Add more flaky tests.

  • platform/chromium/TestExpectations:
2:24 PM Changeset in webkit [130212] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Block freeing thread should sleep indefinitely when there's no work to do
https://bugs.webkit.org/show_bug.cgi?id=98084

Reviewed by Geoffrey Garen.

Currently the block freeing thread wakes up once a second to check if there are any blocks
for it to release back to the OS. This is wasteful. We should change it to sleep when it
realizes there are no more blocks to free. Any thread that returns a block to the BlockAllocator
should then notify the block freeing thread that there is more work to do now.

  • heap/BlockAllocator.cpp:

(JSC::BlockAllocator::BlockAllocator):
(JSC::BlockAllocator::blockFreeingThreadMain):

  • heap/BlockAllocator.h:

(BlockAllocator):
(JSC::BlockAllocator::deallocate):

2:10 PM Changeset in webkit [130211] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip one more failing test.

  • platform/qt/TestExpectations:
2:09 PM Changeset in webkit [130210] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

Remove the last bits of MSYS support from webkitperl.
https://bugs.webkit.org/show_bug.cgi?id=98195

Patch by Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> on 2012-10-02
Reviewed by Eric Seidel.

No ports currently need MinGW/MSYS support, so remove the last
hackish bits related to it from our Perl code.

  • Scripts/commit-log-editor:

(createCommitMessage):

  • Scripts/old-run-webkit-tests:
  • Scripts/webkitdirs.pm:

(isAnyWindows):
(isWindows):

2:07 PM Changeset in webkit [130209] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip a failing test.

  • platform/qt/TestExpectations:
2:04 PM Changeset in webkit [130208] by andersca@apple.com
  • 9 edits in trunk/Source/WebKit2

Allow LayerTreeHost subclasses to return a custom GraphicsLayerFactory
https://bugs.webkit.org/show_bug.cgi?id=98179

Reviewed by Andreas Kling.

Implement ChromeClient::graphicsLayerFactory and have it call the DrawingArea's graphicsLayerFactory which
for DrawingAreaImpl then calls down to the layer tree host. Make LayerTreeCoordinator implement GraphicsLayerFactory and
make it create CoordinatedGraphicsLayers.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::graphicsLayerFactory):
(WebKit):

  • WebProcess/WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::createGraphicsLayer):
(WebKit):
(WebKit::LayerTreeCoordinator::graphicsLayerFactory):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

  • WebProcess/WebPage/DrawingArea.h:

(WebCore):
(WebKit::DrawingArea::graphicsLayerFactory):

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::graphicsLayerFactory):
(WebKit):

  • WebProcess/WebPage/DrawingAreaImpl.h:

(DrawingAreaImpl):

  • WebProcess/WebPage/LayerTreeHost.h:

(WebCore):
(WebKit::LayerTreeHost::graphicsLayerFactory):
(LayerTreeHost):

2:02 PM Changeset in webkit [130207] by andersca@apple.com
  • 14 edits
    3 copies in trunk/Source/WebKit2

Attempt to simplify IPC message dispatching logic in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=98097

Reviewed by Sam Weinig.

Move the Connection::MessageReceiver class to its own header file. Add a MessageReceiverMap helper class
that will be used for dispatching messages based on message class (and eventually destination ID).

Convert AuthenticationManager and WebGeolocationManager over to this new mechanism.

  • CMakeLists.txt:
  • GNUmakefile.list.am:

Add new files.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::dispatchMessage):
Check with the message receiver map first before calling Connection::Client::didReceiveMessage.

  • Platform/CoreIPC/Connection.h:

(CoreIPC::Connection::addMessageReceiver):
Call through to the message receiver map.

  • Platform/CoreIPC/MessageID.h:

(CoreIPC::MessageID::messageClass):
Rename MessageClassReserved to MessageClassInvalid.

(MessageID):

  • Platform/CoreIPC/MessageReceiver.h:

Move MessageReceiver from Connection.h to its own file.

  • Platform/CoreIPC/MessageReceiverMap.cpp:

New helper class.

(CoreIPC::MessageReceiverMap::addMessageReceiver):
Add the receiver to the map of receivers.

(CoreIPC::MessageReceiverMap::dispatchMessage):
Check if we have any registered receivers for this message class.

  • Platform/CoreIPC/MessageReceiverMap.h:

New file.

  • Target.pri:

Add new files.

  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

  • WebProcess/Authentication/AuthenticationManager.cpp:

(WebKit::AuthenticationManager::AuthenticationManager):

  • WebProcess/Authentication/AuthenticationManager.h:

(AuthenticationManager):
Register the authentication manager as a message receiver.

  • WebProcess/Geolocation/WebGeolocationManager.cpp:

(WebKit::WebGeolocationManager::WebGeolocationManager):

  • WebProcess/Geolocation/WebGeolocationManager.h:

(WebGeolocationManager):
Register the geolocation manager as a message receiver.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didReceiveMessage):
Remove checks for authentication manager and geolocation manager messages.

  • win/WebKit2.vcproj:

Add new files.

1:49 PM Changeset in webkit [130206] by ojan@chromium.org
  • 2 edits in trunk/Source/WebCore

isMainThread() should only be called by NoEventDispatchAssertion in debug builds
https://bugs.webkit.org/show_bug.cgi?id=98191

This fixes a performance regression and matches the original code from
before the refactor in http://trac.webkit.org/changeset/130077.

  • dom/ContainerNode.h:

(WebCore::NoEventDispatchAssertion::NoEventDispatchAssertion):
(WebCore::NoEventDispatchAssertion::~NoEventDispatchAssertion):

1:45 PM Changeset in webkit [130205] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Add some more flaky tests.

  • platform/chromium/TestExpectations:
1:42 PM Changeset in webkit [130204] by yoli@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Prevent window.close() from closing pages that are not opened by JS
https://bugs.webkit.org/show_bug.cgi?id=98190

Reviewed by Antonio Gomes.

RIM PR# 217812.
Only pages opened by JS can be closed by JS.

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::closeWindowSoon):

1:35 PM Changeset in webkit [130203] by arv@chromium.org
  • 4 edits
    2 adds in trunk

createHTMLDocument() should not create a title element if the title argument is left out
https://bugs.webkit.org/show_bug.cgi?id=96694

Reviewed by Darin Adler.

In case the argument is not passed to createHTMLDocument we use a null string and check
for that before creating a title element.

Source/WebCore:

Test: fast/dom/DOMImplementation/createHTMLDocument-optional-title.html

  • dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createHTMLDocument):

  • dom/DOMImplementation.idl:

LayoutTests:

  • fast/dom/DOMImplementation/createHTMLDocument-optional-title-expected.txt: Added.
  • fast/dom/DOMImplementation/createHTMLDocument-optional-title.html: Added.
1:28 PM Changeset in webkit [130202] by commit-queue@webkit.org
  • 4 edits
    1 delete in trunk

Remove MSYS-related changes to the http testing infrastructure.
https://bugs.webkit.org/show_bug.cgi?id=98183

Patch by Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> on 2012-10-02
Reviewed by Eric Seidel.

In the process of removing the cruft that has accumulated in our
Apache configuration code, we can basically revert r77161 which
added some MSYS (mingw)-specific code to old-run-webkit-tests,
since it is not being used by any port anymore.

Tools:

  • Scripts/run-webkit-httpd: Remove isMsys()-dependent hacks.
  • Scripts/webkitperl/httpd.pm:

(getHTTPDPath): Remove isMsys() code path.
(getDefaultConfigForTestDirectory): Revert isMsys() hacks.
(getHTTPDConfigPathForTestDirectory): Do not point to the noew
removed apache2-msys-httpd.conf.
(convertMsysPath): Removed.

LayoutTests:

  • http/conf/apache2-msys-httpd.conf: Removed.
1:19 PM Changeset in webkit [130201] by rakuco@webkit.org
  • 3 edits in trunk/LayoutTests

Remove cases of testRunner.disableImageLoading() from the layout tests.
https://bugs.webkit.org/show_bug.cgi?id=98187

Reviewed by Simon Fraser.

According to the discussion started in [1], it does not make much
sense to keep disableLoadingImages() around when
overridePreferences("WebKitDisplayImagesKey", 0) achieves the same
effect.

There were only two cases of disableLoadingImages() in the tests;
one of the tests is disabled and the other is currently skipped by
all ports, so there should be no regressions, such as problems
with ports that may implement testRunner.disableLoadingImages()
but not overridePreferences("WebKitDisplayImagesKey").

[1] http://lists.webkit.org/pipermail/webkit-dev/2012-September/022323.html

  • http/tests/misc/favicon-loads-with-icon-loading-override.html:
  • http/tests/misc/favicon-loads-with-images-disabled.html:
1:11 PM Changeset in webkit [130200] by jochen@chromium.org
  • 5 edits
    12 adds
    2 deletes in trunk/LayoutTests

Split popup-blocking-timers.html into individual tests
https://bugs.webkit.org/show_bug.cgi?id=96480

Reviewed by Daniel Bates.

That should avoid failures from the log messages coming in in the wrong order.

  • fast/events/popup-blocking-timers-expected.txt: Removed.
  • fast/events/popup-blocking-timers.html: Removed.
  • fast/events/popup-blocking-timers1-expected.txt: Added.
  • fast/events/popup-blocking-timers1.html: Added.
  • fast/events/popup-blocking-timers2-expected.txt: Added.
  • fast/events/popup-blocking-timers2.html: Added.
  • fast/events/popup-blocking-timers3-expected.txt: Added.
  • fast/events/popup-blocking-timers3.html: Added.
  • fast/events/popup-blocking-timers4-expected.txt: Added.
  • fast/events/popup-blocking-timers4.html: Added.
  • fast/events/popup-blocking-timers5-expected.txt: Added.
  • fast/events/popup-blocking-timers5.html: Added.
  • fast/events/popup-blocking-timers6-expected.txt: Added.
  • fast/events/popup-blocking-timers6.html: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/qt-5.0-wk2/TestExpectations:
1:09 PM Changeset in webkit [130199] by dgrogan@chromium.org
  • 3 edits
    3 adds in trunk

IndexedDB: Don't wedge if page reloads with pending upgradeneeded
https://bugs.webkit.org/show_bug.cgi?id=98091

Reviewed by Tony Chang.

Source/WebCore:

Test: storage/indexeddb/dont-wedge.html

  • Modules/indexeddb/IDBOpenDBRequest.cpp:

(WebCore::IDBOpenDBRequest::onUpgradeNeeded):
This got the same treatment as IDBRequest::onSuccess(Transaction).
Explicitly tell the backend objects that they are going away so that
m_runningVersionChangeTransaction is cleared and connectionCount()
decreases.

LayoutTests:

dont-wedge.js was derived from
transaction-coordination-across-databases.js.

This would have passed in DRT without this patch, but not in
content_shell.

  • storage/indexeddb/dont-wedge-expected.txt: Added.
  • storage/indexeddb/dont-wedge.html: Added.
  • storage/indexeddb/resources/dont-wedge.js: Added.

(test):
(deleteDatabase1.request.onblocked):
(deleteDatabase1):
(deleteDatabase2):
(isAfterReload):
(reload):
(openDatabase1.request.onupgradeneeded):
(openDatabase1.request.onsuccess):
(openDatabase1):

12:49 PM Changeset in webkit [130198] by dgrogan@chromium.org
  • 5 edits in trunk

http/tests/inspector/indexeddb/database-structure.html start to crash after r124675
https://bugs.webkit.org/show_bug.cgi?id=93225

Reviewed by Tony Chang.

Source/WebCore:

Tests - the disabled indexeddb inspector tests are re-enabled.

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::close):
Detect re-entrancy and bail.

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(IDBDatabaseBackendImpl):

LayoutTests:

  • platform/chromium/TestExpectations:
12:35 PM Changeset in webkit [130197] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

[chromium] Make sure the touch-points in the touch-events have the correct state.
https://bugs.webkit.org/show_bug.cgi?id=98110

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-10-02
Reviewed by Adam Barth.

Source/WebKit/chromium:

It is necessary for the WebTouchPoints in the reconstructed WebTouchEvent
to have the correct state. Without this change, the states were always
unknown.

  • src/WebInputEventConversion.cpp:

(WebKit::toWebTouchPointState):
(WebKit):
(WebKit::addTouchPoints):
(WebKit::WebTouchEventBuilder::WebTouchEventBuilder):

Tools:

TestWebPlugin can now be configured to print out some details about
events. For now, details for only touch events are printed. This is
used to verify that touch-points in the touch-events are properly
set.

  • DumpRenderTree/chromium/TestWebPlugin.cpp:

(pointState):
(printTouchList):
(printEventDetails):
(TestWebPlugin::TestWebPlugin):
(TestWebPlugin::handleInputEvent):

  • DumpRenderTree/chromium/TestWebPlugin.h:

(TestWebPlugin):

LayoutTests:

  • platform/chromium/plugins/touch-events-details-expected.txt: Added.
  • platform/chromium/plugins/touch-events-details.html: Added.
12:31 PM Changeset in webkit [130196] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Programs/WebKit2APITests/TestCookieManager fails
https://bugs.webkit.org/show_bug.cgi?id=98176

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2012-10-02
Reviewed by Martin Robinson.

The problem is that the soup server has a g_assert_not_reached()
for unknown paths, but know /favicon.icon might be requested.

  • UIProcess/API/gtk/tests/TestCookieManager.cpp:

(serverCallback): Ignore unknown paths.

12:28 PM Changeset in webkit [130195] by roger_fong@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed. Adding Windows specific test results. Accelerated 2D canvas not enabled on Windows.

  • platform/win/fast/canvas/canvas-render-layer-expected.txt: Added.
12:22 PM Changeset in webkit [130194] by mkwst@chromium.org
  • 2 edits in trunk/LayoutTests

[Win] Unreviewed gardening. Skipping broken tests on Windows.
https://bugs.webkit.org/show_bug.cgi?id=98169

http/tests/inspector/csp-injected-content-warning-contains-stacktrace.html
and http/tests/inspector/csp-inline-warning-contains-stacktrace.html started
failing on Apple Win 7 Release (Tests) in r130150
<http://trac.webkit.org/changeset/130150>.

http://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r130150%20(28375)/results.html

Will be fixed in webkit.org/b/98169

  • platform/win/TestExpectations:
12:16 PM Changeset in webkit [130193] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Update some expectations to green the tree.

  • platform/chromium/TestExpectations:
11:53 AM Changeset in webkit [130192] by zandobersek@gmail.com
  • 3 edits in trunk/Tools

[XvfbDriver] First tests in each worker occasionally crash
https://bugs.webkit.org/show_bug.cgi?id=96203

Reviewed by Dirk Pranke.

Often in debug builds, the first tests in each worker crash because they
can't yet open the Xvfb display assigned to them. This indicates Xvfb hasn't
yet been set up.

To avoid this, the execution should halt for a small amount of time before tests
are run so the Xvfb process has enough time to get ready. At the moment this is
done right after the Xvfb process is spawned and the execution halts for one
second. That value is overriden to zero when testing to not prolong the testing time.

  • Scripts/webkitpy/layout_tests/port/xvfbdriver.py:

(XvfbDriver.init):
(XvfbDriver._start):

  • Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:

(XvfbDriverTest.make_driver):

11:51 AM Changeset in webkit [130191] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

WebDocument doesn't export document language to outside users.
https://bugs.webkit.org/show_bug.cgi?id=98066

Patch by Brian White <bcwhite@chromium.org> on 2012-10-02
Reviewed by Adam Barth.

Chromium uses the document language to offer translation. It's been doing
its own detection of this property but it would be better to get it from
existing extraction code.

  • public/WebDocument.h:

(WebDocument):

  • src/WebDocument.cpp:

(WebKit::WebDocument::contentLanguage):
(WebKit):

11:41 AM Changeset in webkit [130190] by msaboff@apple.com
  • 8 edits in trunk/Source

HTMLConstructionSite::insertTextNode isn't optimized for 8 bit strings
https://bugs.webkit.org/show_bug.cgi?id=97740

Reviewed by Darin Adler.

Source/WebCore:

Changed parserAppendData to take a string instead of a UChar*. Also added an optional offset
argument to handle string+offset. The actual string append now uses the appropriate string
size.

  • dom/CharacterData.cpp:

(WebCore::CharacterData::parserAppendData):

  • dom/CharacterData.h:

(CharacterData):

  • dom/Text.cpp:

(WebCore::Text::createWithLengthLimit):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertTextNode):

Source/WTF:

Added an append method that takes an LChar source. Made both the UChar and LChar versions optimally handle
the appendee and appendend string bitness.

  • wtf/text/WTFString.cpp:

(WTF::String::append):

  • wtf/text/WTFString.h:

(String):

11:09 AM Changeset in webkit [130189] by ojan@chromium.org
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r130103 and r130125.
http://trac.webkit.org/changeset/130103
http://trac.webkit.org/changeset/130125
https://bugs.webkit.org/show_bug.cgi?id=97974

Causes performance regressions on Dromaeo dom modify tests.

  • bindings/v8/IntrusiveDOMWrapperMap.h:

(WebCore):
(ChunkedTable):
(WebCore::ChunkedTable::ChunkedTable):
(WebCore::ChunkedTable::add):
(WebCore::ChunkedTable::remove):
(WebCore::ChunkedTable::clear):
(WebCore::ChunkedTable::visit):
(WebCore::ChunkedTable::reportMemoryUsage):
(WebCore::ChunkedTable::Chunk::Chunk):
(Chunk):
(WebCore::ChunkedTable::clearEntries):
(WebCore::ChunkedTable::visitEntries):
(WebCore::IntrusiveDOMWrapperMap::IntrusiveDOMWrapperMap):
(WebCore::IntrusiveDOMWrapperMap::get):
(WebCore::IntrusiveDOMWrapperMap::set):
(WebCore::IntrusiveDOMWrapperMap::contains):
(WebCore::IntrusiveDOMWrapperMap::visit):
(WebCore::IntrusiveDOMWrapperMap::removeIfPresent):
(IntrusiveDOMWrapperMap):
(WebCore::IntrusiveDOMWrapperMap::clear):
(ChunkedTableTraits):
(WebCore::IntrusiveDOMWrapperMap::ChunkedTableTraits::move):
(WebCore::IntrusiveDOMWrapperMap::ChunkedTableTraits::clear):
(WebCore::IntrusiveDOMWrapperMap::ChunkedTableTraits::visit):

  • bindings/v8/ScriptWrappable.h:

(WebCore::ScriptWrappable::ScriptWrappable):
(WebCore::ScriptWrappable::wrapper):
(WebCore::ScriptWrappable::setWrapper):
(WebCore::ScriptWrappable::clearWrapper):
(WebCore::ScriptWrappable::reportMemoryUsage):
(ScriptWrappable):

  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getCachedWrapper):

11:03 AM Changeset in webkit [130188] by commit-queue@webkit.org
  • 5 edits in trunk/LayoutTests

[Qt] Missing expected results for rounded dotted borders tests
https://bugs.webkit.org/show_bug.cgi?id=98170

Patch by Marcelo Lira <marcelo.lira@openbossa.org> on 2012-10-02
Reviewed by Csaba Osztrogonác.

  • platform/qt/css2.1/t170602-bdr-conflct-w-45-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-46-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-47-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-48-d-expected.png:
10:55 AM Changeset in webkit [130187] by loislo@chromium.org
  • 15 edits
    1 add in trunk/Source

Web Inspector: NMI: switch to non intrusive instrumentation of ParsedURL.
https://bugs.webkit.org/show_bug.cgi?id=98150

Reviewed by Yury Semikhatsky.

Source/WebCore:

Style changes.

  • platform/KURLWTFURLImpl.h:

(WebCore::KURLWTFURLImpl::reportMemoryUsage):

Source/WTF:

Memory instrumentation for ParsedURL was extracted into separate header MemoryInstrumentationParsedURL.h

Drive by fix: unnecessary include was removed from String*.cpp files.

  • GNUmakefile.list.am:
  • WTF.gypi:
  • WTF.pro:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/MemoryInstrumentation.h:

(WTF):

  • wtf/MemoryInstrumentationParsedURL.h: Added.

(WTF):
(WTF::reportMemoryUsage):

  • wtf/text/AtomicString.cpp:
  • wtf/text/StringImpl.cpp:
  • wtf/text/WTFString.cpp:
  • wtf/url/api/ParsedURL.cpp:
  • wtf/url/api/ParsedURL.h:
  • wtf/url/api/URLString.cpp:
  • wtf/url/api/URLString.h:
10:53 AM Changeset in webkit [130186] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[EFL] Use XvfbDriver for layout tests
https://bugs.webkit.org/show_bug.cgi?id=98162

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-02
Reviewed by Kenneth Rohde Christiansen.

Use XvfbDriver for layout tests on EFL port.

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort._driver_class):

  • Scripts/webkitpy/layout_tests/port/xvfbdriver.py:

(XvfbDriver._start): Set DUMPRENDERTREE_TEMP and LOCAL_RESOURCE_ROOT
environment variables in XvfbDriver as those are needed for
TestRunner::pathToLocalResource().

10:51 AM Changeset in webkit [130185] by andersca@apple.com
  • 7 edits in trunk/Source/WebCore

Add new GraphicsLayer::create overload to all ports
https://bugs.webkit.org/show_bug.cgi?id=98082

Reviewed by Andreas Kling.

Add the GraphicsLayer::create variant that takes a factory to all ports.

  • platform/graphics/GraphicsLayer.cpp:

(WebCore):
(WebCore::GraphicsLayer::setGraphicsLayerFactory):

  • platform/graphics/GraphicsLayer.h:

(GraphicsLayer):
Rename the GraphicsLayerFactory function typedef to GraphicsLayerFactoryCallback to avoid collisions.

  • platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:

(WebCore::GraphicsLayer::create):
(WebCore):

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayer::create):
(WebCore):

  • platform/graphics/clutter/GraphicsLayerClutter.cpp:

(WebCore::GraphicsLayer::create):
(WebCore):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayer::create):
(WebCore):

10:15 AM DOMInJavaScript edited by abarth@webkit.org
(diff)
10:15 AM DeprecatingFeatures edited by mjs@apple.com
(diff)
10:09 AM Changeset in webkit [130184] by roger_fong@apple.com
  • 3 edits in trunk/LayoutTests

Remove erroneously added svn:executable property from some test files.

  • platform/win/fast/text/international/float-as-only-child-of-isolate-crash-expected.png: Removed property svn:executable.
  • platform/win/fast/text/international/float-as-only-child-of-isolate-crash-expected.txt: Removed property svn:executable.
10:00 AM Changeset in webkit [130183] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

[Gtk] Several tests launch g_object_ref/unref assertion messages
https://bugs.webkit.org/show_bug.cgi?id=95062

Reviewed by Martin Robinson.

Only increase and decrease reference count of the accessibility
UI element if it actually exists.

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::~AccessibilityUIElement):

9:57 AM Changeset in webkit [130182] by rakuco@webkit.org
  • 6 edits in trunk/LayoutTests

Remove comments from the Apache config files to start avoiding useless duplication.
https://bugs.webkit.org/show_bug.cgi?id=98152

Reviewed by Laszlo Gombos.

This is the first step towards getting rid of the multiple, almost
identical Apache httpd.conf files we have in the tree.

Before anything else, remove the default comments from them to
reduce the diff in later commits.

  • http/conf/apache2-debian-httpd.conf:
  • http/conf/apache2-httpd.conf:
  • http/conf/apache2-msys-httpd.conf:
  • http/conf/cygwin-httpd.conf:
  • http/conf/fedora-httpd.conf:
9:52 AM Changeset in webkit [130181] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

Build fix after r130135. Dromaeo tests only report single memory value,
and computeStatistics should report variance as 0 in such cases.

  • resources/runner.js:
9:49 AM Changeset in webkit [130180] by commit-queue@webkit.org
  • 2 edits in trunk/Source/Platform

[chromium] Add field to WebRenderingStats to track if we have impl-thread scrolled
https://bugs.webkit.org/show_bug.cgi?id=97919

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-10-02
Reviewed by James Robinson.

Add two new members |numImplThreadScrolls| and |numMainThreadScrolls| to track
the total number of times we have impl-thread scrolled and main-thread scrolled,
respectively.

  • chromium/public/WebRenderingStats.h:

(WebRenderingStats):
(WebKit::WebRenderingStats::WebRenderingStats):
(WebKit::WebRenderingStats::enumerateFields):

9:49 AM Changeset in webkit [130179] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[chromium] running layout tests on mountainlion should use chromium TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=98119

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-10-02
Reviewed by Adam Barth.

Some basic support for mountainlion has already been committed but it failed to refer
to the chromium TestExpectations.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort):

  • Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:

(ChromiumPortTestCase.test_all_test_configurations):

9:45 AM Changeset in webkit [130178] by vangelis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Remove call to FinishAllRendering when in force-compositing-mode.
https://bugs.webkit.org/show_bug.cgi?id=98111

It's not needed and makes the renderer synchronously wait for a glFinish
to happen in the gpu process.

Reviewed by James Robinson.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):

9:28 AM Changeset in webkit [130177] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk

[Shadow] ShadowRoot should know whether <shadow> in its treescope
https://bugs.webkit.org/show_bug.cgi?id=97184

Patch by Takashi Sakamoto <tasak@google.com> on 2012-10-02
Reviewed by Dimitri Glazkov.

Source/WebCore:

To quickly know whether some shadow dom subtree has any shadow element
or not, added hasShadowRootInsertionPoint, registerShadowElement and
unregisterShadowElement to class ShadowRoot. The register method or
unregister method is used when a shadow element is inserted into
document or removed from document. hasShadowInsertionPoint returns true
if any shadow element is still registered with the given shadow root.
Otherwise returns false. To test hasShadowInsertionPoint, added
hasShadowInsertionPoint to Internals.

Test: fast/dom/shadow/has-shadow-insertion-point.html

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::ShadowRoot):
Initializes number of shadow elements.

  • dom/ShadowRoot.h:

(WebCore::ShadowRoot::registerShadowElement):
Increases number of shadow elements in shadow dom subtree by 1.
(WebCore::ShadowRoot::unregisterShadowElement):
Decreases number of shadow elements in shadow dom subtree by 1.
(WebCore::ShadowRoot::hasShadowInsertionPoint):
If number of shadow elements in shadow dom subtree is not equal to 0,
returns true. Otherwise, returns false.

  • html/shadow/HTMLShadowElement.cpp:

(WebCore::HTMLShadowElement::HTMLShadowElement):
(WebCore::HTMLShadowElement::insertedInto):
If a shadow element is inserted into document, register the shadow
element with its shadow root.
(WebCore::HTMLShadowElement::removedFrom):

If a shadow element is removed from document, unregister the shadow

element with its shadow root.

  • html/shadow/HTMLShadowElement.h:

Added a new member variable which has information about whether
this shadow element has been already registered with its shadow root
or not.

  • testing/Internals.cpp:

(WebCore::Internals::hasShadowInsertionPoint):
Added a new testing method which returns whether the given shadow
root has any shadow element or not.

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

LayoutTests:

  • fast/dom/shadow/has-shadow-insertion-point-expected.txt: Added.
  • fast/dom/shadow/has-shadow-insertion-point.html: Added.
9:22 AM Changeset in webkit [130176] by rakuco@webkit.org
  • 2 edits in trunk/Tools

webkitpy: Stop listening on port 8081 when using Apache.
https://bugs.webkit.org/show_bug.cgi?id=98155

Reviewed by Eric Seidel.

No test currently uses this port, and the lighttpd configuration
does not open it.

This helps the efforts of bringing some consistency to the Apache
configuration at the moment by opening the same ports in the
webkitpy side and in the httpd.conf side (the idea is to remove
the httpd.conf side later), and also makes the behavior consistent
across the two servers we currently support.

  • Scripts/webkitpy/layout_tests/servers/apache_http_server.py:

(LayoutTestApacheHttpd.init):

9:05 AM WebKitEFLLayoutTest edited by Christophe Dumez
(diff)
8:59 AM Changeset in webkit [130175] by commit-queue@webkit.org
  • 9 edits
    2 copies in trunk/Source/WebKit

Source/WebKit: [EFL] Add file EWKTestEnvironment.cpp to build system.
https://bugs.webkit.org/show_bug.cgi?id=94925

Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-10-02
Reviewed by Gyuyoung Kim.

Change is related to modifications in wk1 unit tests.

  • PlatformEfl.cmake:

Source/WebKit/efl: [EFL][UT] Refactoring an implementation of testing framework for wk1.
https://bugs.webkit.org/show_bug.cgi?id=94925

Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-10-02
Reviewed by Gyuyoung Kim.

The reason of changing, was to adjust current implementation to use gtest features
related to cleaning (SetUp, TearDown), cleaning code in terms of useless methods
and lastly to make framework easier to use.

  • tests/UnitTestUtils/EWKTestBase.cpp:

(EWKUnitTests::EWKTestBase::EWKTestBase):
(EWKUnitTests::EWKTestBase::webView): Returns current webview.
(EWKUnitTests::EWKTestBase::SetUp):
Before test is started, SetUp is called.
Used this to initialize test view.
(EWKUnitTests::EWKTestBase::onLoadFinished):
(EWKUnitTests::EWKTestBase::waitUntilLoadFinished): It waits till test page will be properly loaded.
(EWKUnitTests::EWKTestBase::loadUrl): Starts loading test page.

  • tests/UnitTestUtils/EWKTestBase.h:
  • tests/UnitTestUtils/EWKTestEnvironment.cpp:

Used to have global SetUp and TearDown.
Global SetUp starts initialization of webkit wherease
global TearDown shuts it down. Generally we would like to have
only one initialization of webkit while tests are executed.
(EWKUnitTests):
(EWKUnitTests::EWKTestEnvironment::EWKTestEnvironment):
(EWKUnitTests::EWKTestEnvironment::SetUp): Starts initialization of webkit.
(EWKUnitTests::EWKTestEnvironment::TearDown): Shuts down of webkit.

  • tests/UnitTestUtils/EWKTestEnvironment.h:

(EWKUnitTests):
(EWKTestEnvironment):
(EWKUnitTests::EWKTestEnvironment::useX11Window):

  • tests/UnitTestUtils/EWKTestView.cpp:

(EWKUnitTests::EWKTestView::EWKTestView):
(EWKUnitTests::EWKTestView::init): Starts initialization of test view.

  • tests/UnitTestUtils/EWKTestView.h:

(EWKTestView):

  • tests/test_ewk_view.cpp: adjusted current unit tests to new implementation.

(TEST_F):

  • tests/test_runner.cpp: entry point of all tests.

(parseCustomArguments):
(main):

8:45 AM Changeset in webkit [130174] by vsevik@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, rolling out r130167 and r130171.
http://trac.webkit.org/changeset/130167
http://trac.webkit.org/changeset/130171
https://bugs.webkit.org/show_bug.cgi?id=98165

Breaks test (Requested by vsevik on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-02

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • platform/qt/TestExpectations:
8:43 AM Changeset in webkit [130173] by michael.bruning@digia.com
  • 2 edits in trunk/LayoutTests

[Qt][WK2] inspector/extensions/extensions-network.html times out
https://bugs.webkit.org/show_bug.cgi?id=98136

Unreviewed gardening.

WebInspectorProxy::platformCreateInspectorPage() is not implemented for
the Qt 5.0 WK2 port.

  • platform/qt-5.0-wk2/TestExpectations:
8:22 AM Changeset in webkit [130172] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Regression] DevToolsExtensionTest.TestContentScriptIsPresent fails
https://bugs.webkit.org/show_bug.cgi?id=98161

Reviewed by Pavel Feldman.

Content scripts should be also added by NetworkUISourceCodeProvider. This patch fixes that.

  • inspector/front-end/NetworkUISourceCodeProvider.js:

(WebInspector.NetworkUISourceCodeProvider.prototype._parsedScriptSource):

8:04 AM Changeset in webkit [130171] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip one more failing test.

  • platform/qt/TestExpectations:
7:53 AM Changeset in webkit [130170] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip new crashing tests to paint the bots green.

  • platform/qt/TestExpectations:
7:51 AM Changeset in webkit [130169] by Hugo Parente Lima
  • 2 edits in trunk/Source/WebKit2

[WK2] PageViewportControllerClient.h uses WebCore class without declaring them
https://bugs.webkit.org/show_bug.cgi?id=98070

Reviewed by Kenneth Rohde Christiansen.

This patch just add forward declarations for code correctness.

  • UIProcess/PageViewportControllerClient.h:

(WebCore):

7:37 AM Changeset in webkit [130168] by jocelyn.turcotte@digia.com
  • 4 edits in trunk/Source/WebKit2

Fix tst_QQuickWebView::scrollRequest after r130029
https://bugs.webkit.org/show_bug.cgi?id=98045

Reviewed by Simon Hausmann.

The test needs to show the window and wait for the loadVisuallyCommitted()
signal like did in the QML API auto tests.

  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::scrollRequest):

  • UIProcess/API/qt/tests/util.cpp:

(waitForViewportReady):

  • UIProcess/API/qt/tests/util.h:
7:23 AM Changeset in webkit [130167] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed inspector test fix.

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

7:05 AM Changeset in webkit [130166] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Use correct gtest macro for testing true/false
https://bugs.webkit.org/show_bug.cgi?id=98142

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-10-02
Reviewed by Laszlo Gombos.

Using EXPECT_EQ(true/false, ...) makes clang trip when it tries to convert
true/false to a pointer. Tests should use EXPECT_TRUE/FALSE instead.

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(showPopupMenu):
(TEST_F):

6:36 AM Changeset in webkit [130165] by Patrick Gansterer
  • 4 edits in trunk/Source/WebCore

[WINCE] Remove FontPlatformData::averageCharWidth()
https://bugs.webkit.org/show_bug.cgi?id=97883

Reviewed by Andreas Kling.

Use SimpleFontData::avgCharWidth() instead to remove duplicated code.

  • platform/graphics/wince/FontPlatformData.cpp:

(WebCore::FixedSizeFontData::create):

  • platform/graphics/wince/FontPlatformData.h:

(FontPlatformData):

  • platform/graphics/wince/GraphicsContextWinCE.cpp:

(WebCore::GraphicsContext::drawText):

6:32 AM Changeset in webkit [130164] by caseq@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed. Removed erroneously added custom expectation.

  • platform/chromium-win/inspector/console/command-line-api-expected.txt: Removed.
6:30 AM Changeset in webkit [130163] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[WK2] REGRESSION(r128623): It made layout tests extremely slow
https://bugs.webkit.org/show_bug.cgi?id=96862

Reviewed by Simon Hausmann.

Disable calling the extremely slow WKBundleSetDatabaseQuota() between tests until proper fix.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

6:21 AM Changeset in webkit [130162] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed: Rebaselined failing inspector test.

  • inspector/console/command-line-api-expected.txt:
6:14 AM Changeset in webkit [130161] by caseq@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed test rebaseline.

  • platform/chromium-win/inspector/console/command-line-api-expected.txt: Added.
6:03 AM Changeset in webkit [130160] by schenney@chromium.org
  • 45 edits in trunk/Source/WebCore

Refactor WebCore::FontData handling to clarify pointer ownership
https://bugs.webkit.org/show_bug.cgi?id=95866

Reviewed by Eric Seidel.

Re-commit for a rolled-out original, now with Chromium Windows build fix.

This patch makes all FontData and derived classes ref-counted in all
code paths that lead to caching or other retention of a
pointer. The goal is to avert crashes and memory leaks, and to bring
the code more in line with current WebKit practices.

Specifically, this patch allows us to use ref pointers for all the
FontData stored in FontFallbackList objects. The FontFallbackList can
then own custom font data and manage its lifetime (forthcoming patch).
Currently Document owns custom font data and does an end run around
FontFallbackList in deleting glyph pages and custom font data, leaving
FontFallbackList with invalid pointers.

All FontData derived classes have been switched to use static create
methods with private constructors.

All caches that hold FontData now use RefPtrs.

All methods that construct new font data now return PassRefPtr, with the
exception of code only used to generate temporary data for text run layout.

All methods that handle FontData in a call stack that passes through
FontFallbackList::fontDataAt return PassRefPtr.

Performance tested with both WebKit Perf-o-matic, which showed
performance changes in the noise, and Chrome's page cycling tests with
the acid3 benchmark set, which showed no performance difference at all.

No new tests as this is refactoring code only and has no impact on functionality.

  • css/CSSFontFace.cpp:

(WebCore::CSSFontFace::getFontData):

  • css/CSSFontFace.h:

(CSSFontFace):

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):

  • css/CSSFontFaceSource.h:

(CSSFontFaceSource):

  • css/CSSFontSelector.cpp:

(WebCore::fontDataForGenericFamily):
(WebCore::CSSFontSelector::getFontData):

  • css/CSSFontSelector.h:
  • css/CSSSegmentedFontFace.cpp:

(WebCore::appendFontDataWithInvalidUnicodeRangeIfLoading):
(WebCore::CSSSegmentedFontFace::getFontData):

  • css/CSSSegmentedFontFace.h:

(CSSSegmentedFontFace):

  • dom/Document.cpp:

(WebCore::Document::registerCustomFont):

  • dom/Document.h:

(Document):

  • platform/graphics/Font.h:

(WebCore):

  • platform/graphics/FontCache.cpp:

(WebCore):
(WebCore::FontCache::getCachedFontData):
(WebCore::FontCache::getNonRetainedLastResortFallbackFont):
(WebCore::FontCache::releaseFontData):
(WebCore::FontCache::purgeInactiveFontData):
(WebCore::FontCache::getFontData):

  • platform/graphics/FontCache.h:

(FontCache):

  • platform/graphics/FontData.h:
  • platform/graphics/FontFallbackList.cpp:

(WebCore::FontFallbackList::releaseFontData):
(WebCore::FontFallbackList::fontDataAt):
(WebCore::FontFallbackList::setPlatformFont):

  • platform/graphics/FontFallbackList.h:

(FontFallbackList):

  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::glyphDataAndPageForCharacter):

  • platform/graphics/FontSelector.h:

(FontSelector):

  • platform/graphics/GlyphPageTreeNode.cpp:

(WebCore::GlyphPageTreeNode::initializePage):

  • platform/graphics/SegmentedFontData.cpp:

(WebCore::SegmentedFontData::fontDataForCharacter):

  • platform/graphics/SegmentedFontData.h:

(WebCore::FontDataRange::FontDataRange):
(WebCore::FontDataRange::fontData):
(FontDataRange):
(WebCore::SegmentedFontData::create):
(SegmentedFontData):
(WebCore::SegmentedFontData::SegmentedFontData):

  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::verticalRightOrientationFontData):
(WebCore::SimpleFontData::uprightOrientationFontData):
(WebCore::SimpleFontData::brokenIdeographFontData):

  • platform/graphics/SimpleFontData.h:

(WebCore::SimpleFontData::create):
(SimpleFontData):
(WebCore::SimpleFontData::variantFontData):
(DerivedFontData):

  • platform/graphics/chromium/FontCacheAndroid.cpp:

(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/chromium/FontCacheChromiumWin.cpp:

(WebCore::FontCache::fontDataFromDescriptionAndLogFont):
(GetLastResortFallbackFontProcData):
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:

(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):

  • platform/graphics/freetype/FontCacheFreeType.cpp:

(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):

  • platform/graphics/mac/ComplexTextControllerCoreText.mm:

(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore::Font::fontDataForCombiningCharacterSequence):

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):

  • platform/graphics/pango/FontCachePango.cpp:

(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/pango/SimpleFontDataPango.cpp:

(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):

  • platform/graphics/qt/FontCacheQt.cpp:

(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/qt/SimpleFontDataQt.cpp:

(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):

  • platform/graphics/skia/FontCacheSkia.cpp:

(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/skia/SimpleFontDataSkia.cpp:

(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):

  • platform/graphics/win/FontCacheWin.cpp:

(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::fontDataFromDescriptionAndLogFont):
(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/win/SimpleFontDataWin.cpp:

(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):

  • platform/graphics/wince/FontCacheWinCE.cpp:

(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/wince/SimpleFontDataWinCE.cpp:

(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):

  • platform/graphics/wx/FontCacheWx.cpp:

(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/wx/SimpleFontDataWx.cpp:

(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):

5:52 AM Changeset in webkit [130159] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] Value not returned warning with geolocation disabled
https://bugs.webkit.org/show_bug.cgi?id=98148

Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2012-10-02
Reviewed by Xan Lopez.

With geolocation disabled in the build, return a sensible value from
DumpRenderTreeSupportGtk::numberOfPendingGeolocationPermissionRequests.
This also avoids a compiler warning.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::numberOfPendingGeolocationPermissionRequests):

5:46 AM Changeset in webkit [130158] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[XMLHttpRequest] overrideMimeType(mime) does not update the response's "Content-Type" header
https://bugs.webkit.org/show_bug.cgi?id=98137

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-02
Reviewed by Kentaro Hara.

Source/WebCore:

According to the XMLHttpRequest specification, overrideMimeType(mime) sets the
"Content-Type" header for the response to mime. However, with the current
implementation, calling overrideMimeType(mime) does not affect the value
returned by client.getResponseHeader("Content-Type"). This patch makes sure
the response's "Content-Type" header is properly updated with the override
MIME type.

Test: http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-content-type-header.html

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::didReceiveResponse):

LayoutTests:

Add layout test to check that calling overrideMimeType(mime) properly
sets the response's "Content-Type" header to mime.

  • http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-content-type-header-expected.txt: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-content-type-header.html: Added.
5:41 AM Changeset in webkit [130157] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.
Remove entry for bidi-layout-across-linebreak.html, reinstated meter-optimiums.html as flaky on Mac.

  • platform/chromium/TestExpectations:
5:34 AM Changeset in webkit [130156] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed inspector test fix on JSC.
https://bugs.webkit.org/show_bug.cgi?id=98145

  • inspector/debugger/script-snippet-model.html:
5:13 AM Changeset in webkit [130155] by vsevik@chromium.org
  • 19 edits in trunk

Web Inspector: Move UISourceCode creation out from ResourceScriptMapping.
https://bugs.webkit.org/show_bug.cgi?id=97680

Reviewed by Pavel Feldman.

Source/WebCore:

UISourceCodes for scripts having sourceURL are now created by NetworkUISourceCodeProvider.
UISourceCodes for anonymous, dynamic and concatenated scripts are now created on demand only.
All UISourceCodes created by ResourceScriptMapping are now "temporary".
Temporary UISourceCodes are not stored in workspace and removed when a normal UISourceCode with the same url is available.
UISourceCodeReplaced event was replaced with TemporaryUISourceCodeAdded/Removed events.

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager):
(WebInspector.BreakpointManager.prototype._uiSourceCodeRemoved):
(WebInspector.BreakpointManager.Breakpoint.prototype.remove):

  • inspector/front-end/NavigatorView.js:
  • inspector/front-end/NetworkUISourceCodeProvider.js:

(WebInspector.NetworkUISourceCodeProvider):
(WebInspector.NetworkUISourceCodeProvider.prototype._parsedScriptSource):

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype._workspaceUISourceCodeForScript):
(WebInspector.ResourceScriptMapping.prototype.uiLocationToRawLocation):
(WebInspector.ResourceScriptMapping.prototype.addScript):
(WebInspector.ResourceScriptMapping.prototype._deleteTemporaryUISourceCodeForScripts):
(WebInspector.ResourceScriptMapping.prototype._bindUISourceCodeToScripts):
(WebInspector.ResourceScriptMapping.prototype._isDynamicScript):
(WebInspector.ResourceScriptMapping.prototype._getOrCreateTemporaryUISourceCode):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAddedToWorkspace):
(WebInspector.ResourceScriptMapping.prototype._scriptsForUISourceCode):
(WebInspector.ResourceScriptMapping.prototype._reset):

  • inspector/front-end/RevisionHistoryView.js:

(WebInspector.RevisionHistoryView):

  • inspector/front-end/ScriptsNavigator.js:
  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel):

  • inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer.prototype.removeUISourceCode.get if):
(WebInspector.TabbedEditorContainer.prototype.removeUISourceCode):

  • inspector/front-end/UISourceCode.js:
  • inspector/front-end/Workspace.js:

(WebInspector.Project.prototype.addTemporaryUISourceCode):
(WebInspector.Project.prototype.removeTemporaryUISourceCode):

LayoutTests:

  • http/tests/inspector/workspace-test.js:

(initialize_WorkspaceTest.InspectorTest.createWorkspace):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceTemporaryUISourceCodeAddedEvent.temporaryUISourceCodeAdded):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceTemporaryUISourceCodeAddedEvent):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceTemporaryUISourceCodeRemovedEvent.temporaryUISourceCodeRemoved):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceTemporaryUISourceCodeRemovedEvent):

  • inspector/debugger/breakpoint-manager-expected.txt:
  • inspector/debugger/breakpoint-manager.html:
  • inspector/debugger/dynamic-script-tag-expected.txt:
  • inspector/debugger/resource-script-mapping.html:
  • inspector/debugger/scripts-panel-expected.txt:
  • inspector/debugger/scripts-panel.html:
5:09 AM Changeset in webkit [130154] by pfeldman@chromium.org
  • 10 edits in trunk/Source/WebCore

Web Inspector: fix front-end compilation
https://bugs.webkit.org/show_bug.cgi?id=98135

Reviewed by Vsevolod Vlasov.

Fixing front-end compilation errors.

  • inspector/InjectedScriptCanvasModuleSource.js:

(.):

  • inspector/InjectedScriptSource.js:

(.):

  • inspector/front-end/DOMExtension.js:

(Element.prototype.pruneEmptyTextNodes):

  • inspector/front-end/DatabaseQueryView.js:
  • inspector/front-end/ExtensionAPI.js:
  • inspector/front-end/JavaScriptSource.js:

(WebInspector.JavaScriptSource.prototype.workingCopyCommitted):

  • inspector/front-end/RuntimeModel.js:
  • inspector/front-end/StylesSidebarPane.js:
  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.SuggestBox.prototype._updateItems):

  • inspector/front-end/treeoutline.js:

(TreeElement.prototype.expandRecursively):

4:44 AM Changeset in webkit [130153] by zandobersek@gmail.com
  • 20 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Rebaselining MathML tests as required after r129695 and r130097.
Adding a missing baseline expectation for accessibility/svg-bounds.html.
The baseline will be added soon-ish.

  • platform/gtk/TestExpectations:
  • platform/gtk/mathml/presentation/attributes-expected.png:
  • platform/gtk/mathml/presentation/attributes-expected.txt:
  • platform/gtk/mathml/presentation/fractions-expected.png:
  • platform/gtk/mathml/presentation/fractions-expected.txt:
  • platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.png:
  • platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/gtk/mathml/presentation/mo-stretch-expected.png:
  • platform/gtk/mathml/presentation/mo-stretch-expected.txt:
  • platform/gtk/mathml/presentation/over-expected.png:
  • platform/gtk/mathml/presentation/over-expected.txt:
  • platform/gtk/mathml/presentation/roots-expected.png:
  • platform/gtk/mathml/presentation/roots-expected.txt:
  • platform/gtk/mathml/presentation/row-alignment-expected.png:
  • platform/gtk/mathml/presentation/row-alignment-expected.txt:
  • platform/gtk/mathml/presentation/subsup-expected.png:
  • platform/gtk/mathml/presentation/subsup-expected.txt:
  • platform/gtk/mathml/presentation/tables-expected.png:
  • platform/gtk/mathml/presentation/tables-expected.txt:
4:41 AM Changeset in webkit [130152] by jochen@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] ASSERT that the embedder has set a default locale
https://bugs.webkit.org/show_bug.cgi?id=98001

Reviewed by Adam Barth.

The callsites assume that the default language is always defined, e.g.
Document::getCachedLocalizer. Add an ASSERT() statement so an embedder
doesn't have to guess what they did wrong.

  • platform/chromium/LanguageChromium.cpp:

(WebCore::platformLanguage):

4:33 AM Changeset in webkit [130151] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Fix JavaScriptSource error found by compiler
https://bugs.webkit.org/show_bug.cgi?id=98143

Reviewed by Pavel Feldman.

  • inspector/front-end/JavaScriptSource.js:

(WebInspector.JavaScriptSource.prototype.workingCopyCommitted):

4:29 AM Changeset in webkit [130150] by mkwst@chromium.org
  • 9 edits
    14 adds
    4 deletes in trunk

Add call stacks to Content Security Policy checks when relevant.
https://bugs.webkit.org/show_bug.cgi?id=94433

Reviewed by Adam Barth.

Source/WebCore:

Previously, we generated stack traces only for eval-related CSP
violations. As it turns out, we can call createScriptCallStack from
practically anywhere. This patch takes advantage of that to generate
stack traces whenever a warning is logged to the console. If we're in
a JavaScript stack, brilliant: we get a detailed warning. If not, the
stack trace is empty, and we don't pass it into the console logging
method.

This has the advantage of giving us good developer-facing logging for
any and all violations that result from script-based injection of
resources. Yay!

Tests: http/tests/inspector/csp-injected-content-warning-contains-stacktrace.html

http/tests/inspector/csp-inline-warning-contains-stacktrace.html
http/tests/inspector/csp-setInterval-warning-contains-stacktrace.html
http/tests/inspector/csp-setTimeout-warning-contains-stacktrace.html

  • bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::create):

Replacing the generated stack trace with the current script state,
which will enable us to generate the stack trace inside
ContentSecurityPolicy::reportViolation if it's relevant.

  • bindings/v8/ScriptCallStackFactory.cpp:

(WebCore::createScriptCallStackForConsole):
(WebCore):

  • bindings/v8/ScriptCallStackFactory.h:

(WebCore):

Adding a dummy interface to createScriptCallStackForConsole that
allows ScriptState to be passed in, which matches JSC's interface.

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::WindowSetTimeoutImpl):

  • bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::SetTimeoutOrInterval):

Dropping stack trace from call to ContentSecurityPolicy::allowEval.

  • page/ContentSecurityPolicy.cpp:

(CSPDirectiveList):
(WebCore::CSPDirectiveList::reportViolation):
(WebCore::CSPDirectiveList::checkEvalAndReportViolation):
(WebCore::CSPDirectiveList::allowEval):

Piping script state through from CSPDirectiveList::allowEval rather
than a full stack trace.

(WebCore):
(WebCore::isAllowedByAll):
(WebCore::isAllowedByAllWithState):
(WebCore::ContentSecurityPolicy::allowEval):
(WebCore::ContentSecurityPolicy::reportViolation):
(WebCore::ContentSecurityPolicy::logToConsole):

Piping script state through from ContentSecurityPolicy::allowEval
rather than a full stack trace. Now, we can simply generate the
stack trace just before logging it, and only pass it into
addConsoleMessage if it's non-empty.

  • page/ContentSecurityPolicy.h:

(JSC):
(WebCore):

Including 'ScriptState.h' to normalize V8 and JSC's JS state objects.

LayoutTests:

  • http/tests/inspector-enabled/contentSecurityPolicy-blocks-setInterval-expected.txt: Removed.
  • http/tests/inspector-enabled/contentSecurityPolicy-blocks-setInterval.html: Removed.
  • http/tests/inspector-enabled/contentSecurityPolicy-blocks-setTimeout-expected.txt: Removed.
  • http/tests/inspector-enabled/contentSecurityPolicy-blocks-setTimeout.html: Removed.

Moved these tests to http/test/inspector, and rewrote them for consistency.

  • http/tests/inspector/csp-injected-content-warning-contains-stacktrace-expected.txt: Added.
  • http/tests/inspector/csp-injected-content-warning-contains-stacktrace.html: Added.
  • http/tests/inspector/csp-inline-warning-contains-stacktrace-expected.txt: Added.
  • http/tests/inspector/csp-inline-warning-contains-stacktrace.html: Added.
  • http/tests/inspector/csp-setInterval-contains-stacktrace-expected.txt: Added.
  • http/tests/inspector/csp-setInterval-warning-contains-stacktrace.html: Added.
  • http/tests/inspector/csp-setTimeout-warning-contains-stacktrace-expected.txt: Added.
  • http/tests/inspector/csp-setTimeout-warning-contains-stacktrace.html: Added.
  • http/tests/inspector/resources/csp-inline-test.js: Added.

(thisTest):

  • http/tests/inspector/resources/csp-test.js: Added.

(test.addMessage):
(test):

Two new tests for the functionality.

  • platform/chromium/http/tests/inspector/csp-injected-content-warning-contains-stacktrace-expected.txt: Added.
  • platform/chromium/http/tests/inspector/csp-inline-warning-contains-stacktrace-expected.txt: Added.
  • platform/chromium/http/tests/inspector/csp-setInterval-contains-stacktrace-expected.txt: Added.
  • platform/chromium/http/tests/inspector/csp-setTimeout-warning-contains-stacktrace-expected.txt: Added.

The stacktrace looks slightly different under JSC than V8.

4:02 AM Changeset in webkit [130149] by pfeldman@chromium.org
  • 151 edits in trunk/Source/WebCore

Web Inspector: migrate from WebInspector.Foo.prototype.proto = to proto: syntax
https://bugs.webkit.org/show_bug.cgi?id=98127

Reviewed by Vsevolod Vlasov.

Converted with the regex matcher.

  • inspector/InjectedScriptCanvasModuleSource.js:

(.):

  • inspector/compile-front-end.py:
  • inspector/front-end/AdvancedSearchController.js:

(WebInspector.SearchView.prototype._onAction):
(WebInspector.FileBasedSearchResultsPane.prototype._createContentSpan):

  • inspector/front-end/ApplicationCacheItemsView.js:
  • inspector/front-end/ApplicationCacheModel.js:

(WebInspector.ApplicationCacheModel.prototype._networkStateUpdated):

  • inspector/front-end/AuditCategories.js:

(WebInspector.AuditCategories.PagePerformance.prototype.initialize):
(WebInspector.AuditCategories.NetworkUtilization.prototype.initialize):

  • inspector/front-end/AuditLauncherView.js:

(WebInspector.AuditLauncherView.prototype._updateButton):

  • inspector/front-end/AuditResultView.js:

(WebInspector.AuditCategoryResultPane.prototype._appendResult):

  • inspector/front-end/AuditRules.js:

(WebInspector.AuditRules.GzipRule.prototype._shouldCompress):
(WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun):
(WebInspector.AuditRules.MinimizeDnsLookupsRule.prototype.doRun):
(WebInspector.AuditRules.ParallelizeDownloadRule.prototype.doRun):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
(WebInspector.AuditRules.CacheControlRule.prototype.isCacheableResource):
(WebInspector.AuditRules.BrowserCacheControlRule.prototype._oneYearExpirationCheck):
(WebInspector.AuditRules.ProxyCacheControlRule.prototype._setCookieCacheableCheck):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun):
(WebInspector.AuditRules.CSSRuleBase.prototype.visitProperty):
(WebInspector.AuditRules.VendorPrefixedCSSProperties.prototype.visitProperty):
(WebInspector.AuditRules.CookieRuleBase.prototype._callbackForResourceCookiePairs):
(WebInspector.AuditRules.CookieSizeRule.prototype.processCookies):
(WebInspector.AuditRules.StaticCookielessRule.prototype._collectorCallback):

  • inspector/front-end/AuditsPanel.js:

(WebInspector.AuditsPanel.prototype._clearButtonClicked):
(WebInspector.AuditsSidebarTreeElement.prototype.refresh):
(WebInspector.AuditResultSidebarTreeElement.prototype.get selectable):

  • inspector/front-end/BottomUpProfileDataGridTree.js:

(WebInspector.BottomUpProfileDataGridNode.prototype._willHaveChildren):

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype._uiLocationRemoved):

  • inspector/front-end/BreakpointsSidebarPane.js:

(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.reset):
(WebInspector.XHRBreakpointsSidebarPane.prototype.set _restoreBreakpoints):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype.set _restoreBreakpoints):

  • inspector/front-end/CPUProfileView.js:

(WebInspector.CPUProfileView.prototype._assignParentsInProfile):
(WebInspector.CPUProfileType.prototype.createProfile):
(WebInspector.CPUProfileHeader.prototype.createView):

  • inspector/front-end/CSSNamedFlowCollectionsView.js:

(WebInspector.CSSNamedFlowCollectionsView.prototype.willHide):
(WebInspector.FlowTreeElement.prototype.setOverset):

  • inspector/front-end/CSSNamedFlowView.js:

(WebInspector.CSSNamedFlowView.prototype._update):

  • inspector/front-end/CSSSelectorProfileView.js:

(WebInspector.CSSSelectorDataGridNode.prototype.createCell):
(WebInspector.CSSSelectorProfileType.prototype.createTemporaryProfile):
(WebInspector.CSSProfileHeader.prototype.createView):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel.prototype._rawLocationToUILocation):

  • inspector/front-end/CallStackSidebarPane.js:

(WebInspector.CallStackSidebarPane.prototype._keyDown):
(WebInspector.CallStackSidebarPane.Placard.prototype._restartFrame):

  • inspector/front-end/CanvasProfileView.js:

(WebInspector.CanvasProfileView.prototype._onTraceLogItemClick):
(WebInspector.CanvasProfileType.prototype.createProfile):
(WebInspector.CanvasProfileHeader.prototype.createView):

  • inspector/front-end/CodeMirrorTextEditor.js:

(WebInspector.CodeMirrorTextEditor.prototype._toRange):

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype.clone):

  • inspector/front-end/ConsoleModel.js:

(WebInspector.ConsoleModel.prototype._messageRepeatCountUpdated):

  • inspector/front-end/ConsolePanel.js:

(WebInspector.ConsolePanel.prototype._consoleCleared):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._dumpMemory):
(WebInspector.ConsoleCommandResult.prototype.toMessageElement):

  • inspector/front-end/ContentProviders.js:

(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent):
(WebInspector.CompilerSourceMappingContentProvider.prototype.searchInContent):
(WebInspector.StaticContentProvider.prototype.searchInContent):

  • inspector/front-end/ContextMenu.js:

(WebInspector.ContextSubMenuItem.prototype._buildDescriptor):
(WebInspector.ContextMenu.prototype.appendApplicableItems):

  • inspector/front-end/CookieItemsView.js:

(WebInspector.CookieItemsView.prototype._contextMenu):
(WebInspector.SimpleCookiesTable.prototype.setCookies):

  • inspector/front-end/CookiesTable.js:

(WebInspector.CookiesTable.prototype._onDeleteFromGrid):

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype.redo):

  • inspector/front-end/DOMBreakpointsSidebarPane.js:

(WebInspector.DOMBreakpointsSidebarPane.prototype.set restoreBreakpoints):

  • inspector/front-end/DOMStorage.js:

(WebInspector.DOMStorageModel.prototype.storages):

  • inspector/front-end/DOMStorageItemsView.js:

(WebInspector.DOMStorageItemsView.prototype._deleteCallback):

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGridNode.prototype.restorePosition):
(WebInspector.CreationDataGridNode.prototype.makeNormal):

  • inspector/front-end/Database.js:

(WebInspector.DatabaseModel.prototype._addDatabase):

  • inspector/front-end/DatabaseQueryView.js:

(WebInspector.DatabaseQueryView.prototype._appendQueryResult):

  • inspector/front-end/DatabaseTableView.js:

(WebInspector.DatabaseTableView.prototype._refreshButtonClicked):

  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.prototype.callStackModified):

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.DefaultTextEditor.prototype.willHide):
(WebInspector.TextEditorGutterPanel.prototype.removeDecoration):
(WebInspector.TextEditorMainPanel.prototype._collectLinesFromDiv):

  • inspector/front-end/Dialog.js:

(WebInspector.DialogDelegate.prototype.willHide):

  • inspector/front-end/DirectoryContentView.js:

(WebInspector.DirectoryContentView.prototype._sort):
(WebInspector.DirectoryContentView.Node.prototype._metadataReceived):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.appendApplicableItems):

  • inspector/front-end/ElementsPanelDescriptor.js:

(WebInspector.ElementsPanelDescriptor.prototype.appendApplicableItems):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype._selectNodeAfterEdit):
(WebInspector.ElementsTreeOutline.PseudoStateDecorator.prototype.decorateAncestor):

  • inspector/front-end/EmptyView.js:
  • inspector/front-end/EventListenersSidebarPane.js:

(WebInspector.EventListenersSidebarPane.prototype):

  • inspector/front-end/ExtensionAPI.js:

(injectedExtensionAPI.PanelWithSidebarImpl.prototype.createSidebarPane):
(injectedExtensionAPI.ExtensionPanelImpl.prototype.show):

  • inspector/front-end/ExtensionPanel.js:

(WebInspector.ExtensionPanel.prototype.jumpToPreviousSearchResult):
(WebInspector.ExtensionSidebarPane.prototype._setObject):

  • inspector/front-end/ExtensionView.js:

(WebInspector.ExtensionView.prototype._onLoad):
(WebInspector.ExtensionNotifierView.prototype.willHide):

  • inspector/front-end/FileContentView.js:

(WebInspector.FileContentView.prototype.refresh):

  • inspector/front-end/FileManager.js:

(WebInspector.FileManager.prototype.appendedToURL):

  • inspector/front-end/FileSystemModel.js:

(WebInspector.FileSystemModel.prototype._removeFileSystem):
(WebInspector.FileSystemModel.Directory.prototype.requestDirectoryContent):
(WebInspector.FileSystemModel.File.prototype.requestFileContent):

  • inspector/front-end/FileSystemView.js:

(WebInspector.FileSystemView.prototype._delete):
(WebInspector.FileSystemView.EntryTreeElement.prototype._deletionCompleted):

  • inspector/front-end/FilteredItemSelectionDialog.js:

(WebInspector.FilteredItemSelectionDialog.prototype._itemElementInViewport):
(WebInspector.JavaScriptOutlineDialog.prototype.rewriteQuery):
(WebInspector.OpenResourceDialog.prototype.rewriteQuery):

  • inspector/front-end/FontView.js:

(WebInspector.FontView.prototype.updateFontPreviewSize):

  • inspector/front-end/GoToLineDialog.js:

(WebInspector.GoToLineDialog.prototype.onEnter):

  • inspector/front-end/HandlerRegistry.js:

(WebInspector.HandlerRegistry.prototype._appendHrefItems):

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotEdgesProvider.prototype.sort):
(WebInspector.HeapSnapshotNodesProvider.prototype.sort):

  • inspector/front-end/HeapSnapshotDataGrids.js:

(WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingLeave):
(WebInspector.HeapSnapshotViewportDataGrid.prototype._onScroll):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype.sortingChanged):
(WebInspector.HeapSnapshotDiffDataGrid.prototype._populateChildren):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype.highlightObjectByHeapSnapshotId):

  • inspector/front-end/HeapSnapshotGridNodes.js:

(WebInspector.HeapSnapshotGridNode.prototype.sort):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.shortenWindowURL):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):
(WebInspector.HeapSnapshotInstanceNode.prototype.get isDeletedNode):
(WebInspector.HeapSnapshotConstructorNode.prototype.get _shallowSizePercent):
(WebInspector.HeapSnapshotDiffNode.prototype.get data):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._emptyData):

  • inspector/front-end/HeapSnapshotProxy.js:

(WebInspector.HeapSnapshotWorkerWrapper.prototype.terminate):
(WebInspector.HeapSnapshotRealWorker.prototype.terminate):
(WebInspector.HeapSnapshotFakeWorker.prototype._postMessageFromWorker):
(WebInspector.HeapSnapshotWorker.prototype._postMessage):
(WebInspector.HeapSnapshotLoaderProxy.prototype.close):
(WebInspector.HeapSnapshotProxy.prototype.get uid):
(WebInspector.HeapSnapshotProviderProxy.prototype.sortAndRewind):

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotView.prototype._updateFilterOptions):
(WebInspector.HeapSnapshotProfileType.prototype.createProfile):
(WebInspector.HeapProfileHeader.prototype._createFileReader):

  • inspector/front-end/HelpScreen.js:

(WebInspector.HelpScreen.prototype._onBlur):

  • inspector/front-end/ImageView.js:

(WebInspector.ImageView.prototype._openInNewTab):

  • inspector/front-end/IndexedDBModel.js:

(WebInspector.IndexedDBModel.prototype._requestData):

  • inspector/front-end/IndexedDBViews.js:

(WebInspector.IDBDataView.prototype.clear):
(WebInspector.IDBDataGridNode.prototype._formatValue):

  • inspector/front-end/InspectorFrontendHostStub.js:

(.WebInspector.ClipboardAccessDeniedScreen):

  • inspector/front-end/InspectorView.js:

(WebInspector.InspectorView.prototype.showPanelForAnchorNavigation):

  • inspector/front-end/JavaScriptSource.js:

(WebInspector.JavaScriptSource.prototype.workingCopyCommitted):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype._continueToLine):

  • inspector/front-end/Linkifier.js:

(WebInspector.Linkifier.DefaultFormatter.prototype.formatLiveAnchor):

  • inspector/front-end/MemoryStatistics.js:

(WebInspector.SwatchCheckbox.prototype._toggleCheckbox):

  • inspector/front-end/MetricsSidebarPane.js:

(WebInspector.MetricsSidebarPane.prototype.editingCommitted):

  • inspector/front-end/NativeBreakpointsSidebarPane.js:

(WebInspector.NativeBreakpointsSidebarPane.prototype._reset):

  • inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.NativeMemorySnapshotView.prototype.get profile):
(WebInspector.NativeMemoryProfileType.prototype.createProfile):
(WebInspector.NativeMemoryProfileHeader.prototype.createView):
(WebInspector.NativeMemoryPieChart.prototype._clear):
(WebInspector.NativeMemoryBarChart.prototype._updateView):

  • inspector/front-end/NavigatorView.js:

(WebInspector.NavigatorView.prototype.handleContextMenu):
(WebInspector.NavigatorTreeOutline.prototype.searchFinished):
(WebInspector.BaseNavigatorTreeElement.prototype.matchesSearchText):
(WebInspector.NavigatorFolderTreeElement.prototype.onattach):
(WebInspector.NavigatorSourceTreeElement.prototype._handleContextMenuEvent):

  • inspector/front-end/NetworkItemView.js:

(WebInspector.NetworkItemView.prototype.set request):
(WebInspector.RequestContentView.prototype.highlightLine):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkManager.prototype._userAgentSettingChanged):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._highlightNode):
(WebInspector.NetworkPanel.prototype.appendApplicableItems):
(WebInspector.NetworkTimeCalculator.prototype._upperBound):
(WebInspector.NetworkTransferTimeCalculator.prototype._upperBound):
(WebInspector.NetworkTransferDurationCalculator.prototype._upperBound):
(WebInspector.NetworkDataGridNode.prototype._refreshLabelPositions):
(WebInspector.NetworkDataGridNode.RequestPropertyComparator):

  • inspector/front-end/NetworkPanelDescriptor.js:

(WebInspector.NetworkPanelDescriptor.prototype.appendApplicableItems):

  • inspector/front-end/NetworkRequest.js:

(WebInspector.NetworkRequest.prototype._pushFrame):

  • inspector/front-end/ObjectPopoverHelper.js:

(WebInspector.ObjectPopoverHelper.prototype._updateHTMLId):

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertiesSection.prototype.updateProperties):
(WebInspector.ObjectPropertyTreeElement.prototype.applyExpression):
(WebInspector.FunctionScopeMainTreeElement.prototype.onpopulate):
(WebInspector.ScopeTreeElement.prototype.onpopulate):
(WebInspector.ArrayGroupingTreeElement.prototype.onattach):

  • inspector/front-end/Panel.js:

(WebInspector.Panel.prototype.unregisterShortcut):

  • inspector/front-end/PanelEnablerView.js:

(WebInspector.PanelEnablerView.prototype.get alwaysEnabled):

  • inspector/front-end/ProfileDataGridTree.js:

(WebInspector.ProfileDataGridNode.prototype._merge):

  • inspector/front-end/ProfileLauncherView.js:

(WebInspector.ProfileLauncherView.prototype.profileFinished):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype.appendApplicableItems):
(WebInspector.ProfileSidebarTreeElement.prototype.handleContextMenuEvent):
(WebInspector.ProfileGroupSidebarTreeElement.prototype.onselect):
(WebInspector.ProfilesSidebarTreeElement.prototype.get selectable):

  • inspector/front-end/ProgressIndicator.js:

(WebInspector.ProgressIndicator.prototype.worked):

  • inspector/front-end/PropertiesSection.js:
  • inspector/front-end/PropertiesSidebarPane.js:

(WebInspector.PropertiesSidebarPane.prototype.update):

  • inspector/front-end/RequestCookiesView.js:

(WebInspector.RequestCookiesView.prototype._refreshCookies):

  • inspector/front-end/RequestHTMLView.js:

(WebInspector.RequestHTMLView.prototype._createIFrame):

  • inspector/front-end/RequestHeadersView.js:

(WebInspector.RequestHeadersView.prototype._createHeadersToggleButton):

  • inspector/front-end/RequestJSONView.js:

(WebInspector.RequestJSONView.parseJSON.WebInspector.RequestJSONView.prototype._initialize):

  • inspector/front-end/RequestPreviewView.js:

(WebInspector.RequestPreviewView.prototype._createPreviewView):

  • inspector/front-end/RequestResponseView.js:

(WebInspector.RequestResponseView.prototype.contentLoaded):

  • inspector/front-end/RequestTimingView.js:

(WebInspector.RequestTimingView.prototype._refresh):
(WebInspector.RequestTimingView.createTimingTable):

  • inspector/front-end/RequestView.js:

(WebInspector.RequestView.prototype.hasContent):

  • inspector/front-end/Resource.js:

(WebInspector.Resource.prototype.isHidden):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype._createResourceFromFramePayload):

  • inspector/front-end/ResourceView.js:

(WebInspector.ResourceView.prototype.hasContent):
(WebInspector.ResourceSourceFrame.prototype.populateTextAreaContextMenu):

  • inspector/front-end/ResourceWebSocketFrameView.js:
  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype._onmouseout):
(WebInspector.BaseStorageTreeElement.prototype.get searchMatchesCount):
(WebInspector.StorageCategoryTreeElement.prototype.set oncollapse):
(WebInspector.FrameTreeElement.prototype._insertInPresentationOrder):
(WebInspector.FrameResourceTreeElement.prototype.sourceView):
(WebInspector.DatabaseTreeElement.prototype._updateChildren):
(WebInspector.DatabaseTableTreeElement.prototype.onselect):
(WebInspector.IndexedDBTreeElement.prototype._idbDatabaseTreeElement):
(WebInspector.FileSystemListTreeElement.prototype._refreshFileSystem):
(WebInspector.IDBDatabaseTreeElement.prototype.clear):
(WebInspector.IDBObjectStoreTreeElement.prototype.clear):
(WebInspector.IDBIndexTreeElement.prototype.clear):
(WebInspector.DOMStorageTreeElement.prototype.onselect):
(WebInspector.CookieTreeElement.prototype.onselect):
(WebInspector.ApplicationCacheManifestTreeElement.prototype.onselect):
(WebInspector.ApplicationCacheFrameTreeElement.prototype.onselect):
(WebInspector.FileSystemTreeElement.prototype.clear):
(WebInspector.StorageCategoryView.prototype.setText):

  • inspector/front-end/RevisionHistoryView.js:

(WebInspector.RevisionHistoryView.prototype._reset):
(WebInspector.RevisionHistoryTreeElement.prototype.allowRevert):

  • inspector/front-end/RuntimeModel.js:

(WebInspector.RuntimeModel.prototype._reportCompletions):
(WebInspector.FrameExecutionContextList.prototype.get displayName):

  • inspector/front-end/ScopeChainSidebarPane.js:

(WebInspector.ScopeChainSidebarPane.prototype.update):
(WebInspector.ScopeVariableTreeElement.prototype.get propertyPath):

  • inspector/front-end/Script.js:

(WebInspector.Script.Location.prototype.dispose):

  • inspector/front-end/ScriptFormatterWorker.js:

(HTMLScriptFormatter.prototype.styleSheetEnded):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype._projectDidReset):
(WebInspector.SnippetJavaScriptSource.prototype.workingCopyChanged):

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator.prototype.reset):
(WebInspector.SnippetsNavigatorView.prototype._snippetCreationRequested):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.showGoToSourceDialog):

  • inspector/front-end/ScriptsPanelDescriptor.js:

(WebInspector.ScriptsPanelDescriptor.prototype.appendApplicableItems):

  • inspector/front-end/ScriptsSearchScope.js:

(WebInspector.ScriptsSearchScope.prototype._sortedUISourceCodes):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen.prototype.willHide):
(WebInspector.SettingsTab.prototype._createCustomSetting):
(WebInspector.GenericSettingsTab.prototype._javaScriptDisabledChanged):
(WebInspector.UserAgentSettingsTab.prototype._createDeviceOrientationOverrideElement):
(WebInspector.ExperimentsSettingsTab.prototype._createExperimentCheckbox):

  • inspector/front-end/ShowMoreDataGridNode.js:

(WebInspector.ShowMoreDataGridNode.prototype.dispose):

  • inspector/front-end/SidebarPane.js:

(WebInspector.SidebarPane.prototype._onTitleKeyDown):

  • inspector/front-end/SidebarTreeElement.js:

(WebInspector.SidebarSectionTreeElement.prototype.onreveal):
(WebInspector.SidebarTreeElement.prototype.onreveal):

  • inspector/front-end/SnippetJavaScriptSourceFrame.js:

(WebInspector.SnippetJavaScriptSourceFrame.prototype._runButtonClicked):

  • inspector/front-end/SnippetStorage.js:

(WebInspector.Snippet.prototype.serializeToObject):

  • inspector/front-end/SourceCSSTokenizer.js:

(WebInspector.SourceCSSTokenizer.prototype.nextToken):

  • inspector/front-end/SourceCSSTokenizer.re2js:
  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype._commitEditing):
(WebInspector.TextEditorDelegateForSourceFrame.prototype.createLink):

  • inspector/front-end/SourceHTMLTokenizer.js:

(WebInspector.SourceHTMLTokenizer.prototype.nextToken):

  • inspector/front-end/SourceHTMLTokenizer.re2js:
  • inspector/front-end/SourceJavaScriptTokenizer.js:

(WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):

  • inspector/front-end/SourceJavaScriptTokenizer.re2js:
  • inspector/front-end/Spectrum.js:

(WebInspector.Spectrum.prototype._onKeyDown):

  • inspector/front-end/SplitView.js:

(WebInspector.SplitView.prototype.set elementsToRestoreScrollPositionsFor):

  • inspector/front-end/StatusBarButton.js:

(WebInspector.StatusBarButton.prototype._showOptions):

  • inspector/front-end/StyleSheetOutlineDialog.js:

(WebInspector.StyleSheetOutlineDialog.prototype.rewriteQuery):

  • inspector/front-end/StyleSource.js:

(WebInspector.StyleSource.prototype._clearIncrementalUpdateTimer):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype.willHide):
(WebInspector.ComputedStyleSidebarPane.prototype.expand):
(WebInspector.StylePropertiesSection.prototype.editingSelectorCancelled):
(WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):
(WebInspector.BlankStylePropertiesSection.prototype.makeNormal):
(WebInspector.StylePropertyTreeElement.prototype):

  • inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer.prototype.currentFile):
(WebInspector.TabbedEditorContainer.HistoryItem.prototype.serializeToObject):
(WebInspector.TabbedEditorContainer.History.prototype.set _serializeToObject):

  • inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPane.prototype._insertBefore):

  • inspector/front-end/TextEditorModel.js:

(WebInspector.TextEditorModel.endsWithBracketRegex.):

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPromptWithHistory.prototype.defaultKeyHandler):

  • inspector/front-end/TimelineManager.js:

(WebInspector.TimelineManager.prototype._stopped):

  • inspector/front-end/TimelineModel.js:

(WebInspector.TimelineModel.prototype.recordOffsetInSeconds):

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane.prototype._scheduleRefresh):
(WebInspector.TimelineOverviewWindow.prototype._zoom):
(WebInspector.TimelineFrameOverview.prototype.getWindowTimes):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype.performSearch):

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.prototype.isVisible):
(WebInspector.TimelineCategory.prototype.set hidden):

  • inspector/front-end/TopDownProfileDataGridTree.js:

(WebInspector.TopDownProfileDataGridNode.prototype._exclude):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.setSourceMapping):

  • inspector/front-end/UISourceCodeFrame.js:

(WebInspector.UISourceCodeFrame.prototype.populateTextAreaContextMenu):

  • inspector/front-end/View.js:

(WebInspector.View.prototype.focus):

  • inspector/front-end/WatchExpressionsSidebarPane.js:

(WebInspector.WatchExpressionsSidebarPane.prototype._refreshButtonClicked):
(WebInspector.WatchExpressionsSection.prototype._updateHoveredElement):
(WebInspector.WatchExpressionTreeElement.prototype.applyExpression):

  • inspector/front-end/WorkerManager.js:

(WebInspector.WorkerManager.prototype._disconnectedFromWorker):
(WebInspector.WorkerTerminatedScreen.prototype.willHide):

  • inspector/front-end/WorkersSidebarPane.js:

(WebInspector.WorkersSidebarPane.prototype._autoattachToWorkersClicked):

  • inspector/front-end/Workspace.js:

(WebInspector.Workspace.prototype.uiSourceCodes):

3:27 AM Changeset in webkit [130148] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed r130146 follow-up, added method was not called.

  • inspector/front-end/JavaScriptSource.js:

(WebInspector.JavaScriptSource.prototype.workingCopyCommitted):

3:21 AM Changeset in webkit [130147] by yosin@chromium.org
  • 9 edits
    6 adds in trunk

[Forms] Multiple fields datetime/datetime-local input UI
https://bugs.webkit.org/show_bug.cgi?id=97997

Reviewed by Kent Tamura.

Source/WebCore:

This patch introduces multiple fields "datetime" and "datetime-local"
input UI in DRT. We'll enable these features once we add tests.

No new tests. To reduce size of this patch, other patches add tests
for multiple fields datetime/datetime-local input UI.

Note: Actual outputs of four tests

  • fast/forms/datetime/datetime-input-visible-string.html
  • fast/forms/datetime/datetime-stepup-stepdown-from-renderer.html
  • fast/forms/datetimelocal/datetimelocal-input-visible-string.html
  • fast/forms/datetimelocal/datetimelocal-stepup-stepdown-from-renderer.html

are different.

  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • css/html.css:

(input::-webkit-datetime-edit-day-field): Added for field appearance.
(input::-webkit-datetime-edit-day-field:focus): Added to remove focus ring.

  • html/DateTimeInputType.cpp:

(WebCore::DateTimeInputType::formatDateTimeFieldsState): Added to format numeric value to string value as specified in HTML5 specification.
(WebCore::DateTimeInputType::setupLayoutParameters): Added to set layout of multiple fields.

  • html/DateTimeInputType.h: Changed to include BaseMultipleFieldsDateAndTimeInputType.h and introduce BaseDateTimeInputType typedef.

(WebCore::DateTimeInputType::DateTimeInputType): Changed base class name to BaseDateTimeInputType.
(DateTimeInputType): Changed to add declarations for formatDateTimeFieldsState() and setupLayoutParameters().

  • html/DateTimeLocalInputType.cpp:

(WebCore::DateTimeLocalInputType::formatDateTimeFieldsState): Added to format numeric value to string value as specified in HTML5 specification.
(WebCore::DateTimeLocalInputType::setupLayoutParameters): Added to set layout of multiple fields.

  • html/DateTimeLocalInputType.h: Changed to include BaseMultipleFieldsDateAndTimeInputType.h and introduce BaseDateTimeLocalInputType typedef.

(WebCore::DateTimeLocalInputType::DateTimeLocalInputType): Changed base class name to BaseDateTimeLocalInputType.
(DateTimeLocalInputType): Changed to add declarations for formatDateTimeFieldsState() and setupLayoutParameters().

  • html/shadow/DateTimeEditElement.cpp:

(DateTimeEditBuilder): Changed to add member variable m_placeholderForDay.
(WebCore::DateTimeEditBuilder::DateTimeEditBuilder): Changed to initialize m_placeholderForDay.
(WebCore::DateTimeEditBuilder::visitField): Changed to support week field.

  • html/shadow/DateTimeEditElement.h:

(LayoutParameters): Changed to add placeholderForDay member variable.

LayoutTests:

This patch adds Chromium port specific expectations for "datetime" and
"datetime-local" input type tests for multiple fields datetime input UI.

  • platform/chromium/fast/forms/datetime/datetime-input-visible-string-expected.txt: Added. Multiple fields datetime input UI doesn't have selection.
  • platform/chromium/fast/forms/datetime/datetime-stepup-stepdown-from-renderer-expected.txt: Added. On multiple fields datetime input UI, step down/up decrement/increment a field rather than whole value.
  • platform/chromium/fast/forms/datetimelocal/datetimelocal-input-visible-string-expected.txt: Added. Multiple fields datetime-local input UI doesn't have selection.
  • platform/chromium/fast/forms/datetimelocal/datetimelocal-stepup-stepdown-from-renderer-expected.txt: Added. On multiple fields datetime-local input UI, step down/up decrement/increment a field rather than whole value.
3:18 AM Changeset in webkit [130146] by vsevik@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: [Regression] Breakpoints restored from storage are not set in debugger.
https://bugs.webkit.org/show_bug.cgi?id=98132

Reviewed by Pavel Feldman.

Added hasDivergedFromVM attribute to UISourceCode for breakpoint
manager to know if breakpoints should be set in the debugger.

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.hasDivergedFromVM):
(WebInspector.BreakpointManager.Breakpoint.prototype._updateBreakpoint):

  • inspector/front-end/JavaScriptSource.js:

(WebInspector.JavaScriptSource.prototype.workingCopyCommitted):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):

3:12 AM Changeset in webkit [130145] by zandobersek@gmail.com
  • 3 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Rebaselining fast/canvas/canvas-render-layer.html after r130056.
Changing one calendar picker expectation after r130113.
Marking fast/css/sticky/sticky-writing-mode-vertical-rl.html as flaky.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/canvas/canvas-render-layer-expected.txt:
2:43 AM Changeset in webkit [130144] by loislo@chromium.org
  • 21 edits
    1 add in trunk/Source

Web Inspector: NMI make String* instrumentation non intrusive
https://bugs.webkit.org/show_bug.cgi?id=97964

Reviewed by Yury Semikhatsky.

Source/WebCore:

MemoryInstrumentationString.h include was added.

  • dom/WebCoreMemoryInstrumentation.h:

Source/WebKit/chromium:

The expectations were fixed because old instrumentation had wrong detector for BufferInternal type of storage.

  • tests/MemoryInstrumentationTest.cpp:

(WebCore::TEST):

Source/WTF:

MemoryInstrumentationString.h was added.
Intrusive instrumentation was removed.

  • GNUmakefile.list.am:
  • WTF.gypi:
  • WTF.pro:
  • WTF.vcproj/WTF.vcproj:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/MemoryInstrumentation.h:

(WTF):

  • wtf/MemoryInstrumentationString.h: Added.

(WTF):
(WTF::reportMemoryUsage):

  • wtf/text/AtomicString.cpp:

(WTF):

  • wtf/text/AtomicString.h:

(AtomicString):

  • wtf/text/CString.h:

(WTF::CStringBuffer::length):

  • wtf/text/StringImpl.cpp:
  • wtf/text/StringImpl.h:

(WTF::StringImpl::usesInternalBuffer):
(WTF::StringImpl::baseString):
(StringImpl):

2:35 AM Changeset in webkit [130143] by vsevik@chromium.org
  • 4 edits in trunk

Web Inspector: inspector/debugger/script-snippet-model.html fails
https://bugs.webkit.org/show_bug.cgi?id=98129

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype._runScript):
(WebInspector.ScriptSnippetModel.prototype._printRunScriptResult):

LayoutTests:

  • inspector/debugger/script-snippet-model.html:
2:29 AM Changeset in webkit [130142] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove anonymous namespace from StyleBuilder.cpp for better debugging experience
https://bugs.webkit.org/show_bug.cgi?id=98124

Reviewed by Alexander Pavlov.

  • css/StyleBuilder.cpp: removed anonymous namespace.

(WebCore):

2:29 AM Changeset in webkit [130141] by jochen@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Use correct gtest macros for tests for true/false

Unreviewed build-fix.

Using EXPECT_EQ(true, ...) makes clang trip when it tries to convert
true to a pointer. Tests should use EXPECT_TRUE instead.

  • tests/WebFrameTest.cpp:
1:59 AM Changeset in webkit [130140] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: CSS property names autocomplete: Suggest most used rather than alphabeticaly first
https://bugs.webkit.org/show_bug.cgi?id=96763

Patch by Nikita Vasilyev <me@elv1s.ru> on 2012-10-02
Reviewed by Alexander Pavlov.

Implement selection of non-first item in WebInspector.TextPrompt.SuggestBox.

  • inspector/front-end/CSSCompletions.js:

(WebInspector.CSSCompletions.Weight): Collect most used CSS property names. Rarely used properties are not presented.
(WebInspector.CSSCompletions.prototype.firstStartsWith): Remove unused function.
(WebInspector.CSSCompletions.prototype.mostUsedOf):

  • inspector/front-end/StylesSidebarPane.js:
  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.prototype.pageDownKeyPressed):
(WebInspector.TextPrompt.SuggestBox): Introduce _length and _selectedIndex to remove unnecessary DOM traversals.

Simplify canShowForSingleItem logic.

(WebInspector.TextPrompt.SuggestBox.prototype._selectClosest): _onPreviousItem and _onNextItem had some logic

duplication so I replaced them with this method.

(WebInspector.TextPrompt.SuggestBox.prototype.updateSuggestions):
(WebInspector.TextPrompt.SuggestBox.prototype._updateItems):
(WebInspector.TextPrompt.SuggestBox.prototype._selectItem):
(WebInspector.TextPrompt.SuggestBox.prototype._completionsReady):
(WebInspector.TextPrompt.SuggestBox.prototype.upKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.downKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.pageUpKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.pageDownKeyPressed):

1:36 AM Changeset in webkit [130139] by keishi@webkit.org
  • 3 edits
    2 adds in trunk

Web Inspector: Modifications in a shadow tree don't update the Elements panel.
https://bugs.webkit.org/show_bug.cgi?id=97056

Reviewed by Pavel Feldman.

Source/WebCore:

Send characterDataModified event for shadow dom nodes too so they update the elements panel.

Test: inspector/elements/shadow-dom-modify-chardata.html

  • dom/CharacterData.cpp:

(WebCore::CharacterData::dispatchModifiedEvent):

LayoutTests:

  • inspector/elements/shadow-dom-modify-chardata-expected.txt: Added.
  • inspector/elements/shadow-dom-modify-chardata.html: Added.
1:28 AM Changeset in webkit [130138] by vsevik@chromium.org
  • 9 edits in trunk

Web Inspector: Provide a way to distinguish scripts having sourceURL from standalone scripts.
https://bugs.webkit.org/show_bug.cgi?id=97231

Reviewed by Pavel Feldman.

Source/WebCore:

DebuggerAgent now scans scripts for sourceURL comment and provides
hasSourceURL flag for each non-inline script with such a comment.

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::dispatchDidParseSource):

  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::didParseSource):

  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.prototype._parsedScriptSource):
(WebInspector.DebuggerDispatcher.prototype.scriptParsed):

  • inspector/front-end/Script.js:

(WebInspector.Script):

LayoutTests:

  • inspector/debugger/source-url-comment-expected.txt:
  • inspector/debugger/source-url-comment.html:
1:25 AM Changeset in webkit [130137] by caseq@chromium.org
  • 21 edits
    1 delete in trunk/Source

Unreviewed, rolling out r130129.
http://trac.webkit.org/changeset/130129
https://bugs.webkit.org/show_bug.cgi?id=98125

broke 4 webkit_unit_tests
(MemoryInstrumentationTest.hashMapWith*) (Requested by caseq
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-02

Source/WebCore:

  • dom/WebCoreMemoryInstrumentation.h:
  • platform/KURL.cpp:
  • platform/KURLGoogle.cpp:
  • platform/PlatformMemoryInstrumentation.h:

Source/WebKit/chromium:

  • tests/MemoryInstrumentationTest.cpp:

Source/WTF:

  • GNUmakefile.list.am:
  • WTF.gypi:
  • WTF.pro:
  • WTF.vcproj/WTF.vcproj:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/MemoryInstrumentation.h:

(WTF):

  • wtf/MemoryInstrumentationString.h: Removed.
  • wtf/text/AtomicString.cpp:

(WTF::AtomicString::reportMemoryUsage):
(WTF):

  • wtf/text/AtomicString.h:

(AtomicString):

  • wtf/text/CString.h:

(WTF::CStringBuffer::length):
(CStringBuffer):
(WTF::CStringBuffer::reportMemoryUsage):
(CString):
(WTF::CString::reportMemoryUsage):

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::reportMemoryUsage):
(WTF):

  • wtf/text/StringImpl.h:

(StringImpl):

  • wtf/text/WTFString.cpp:

(WTF::String::reportMemoryUsage):
(WTF):

  • wtf/text/WTFString.h:

(String):

1:20 AM Changeset in webkit [130136] by pfeldman@chromium.org
  • 9 edits in trunk/Source/WebCore

Web Inspector: move runScript into the snippets model
https://bugs.webkit.org/show_bug.cgi?id=98122

Reviewed by Vsevolod Vlasov.

  • Moves runScript into the SnippetsModel
  • Drive-by: annotates more RuntimeModel methods
  • common, sdk, ui, components, elements, network, resources, network, scripts, console, timeline, workers, tests modules now compile with no errors in dedicated compilation mode.
  • inspector/compile-front-end.py:
  • inspector/front-end/ConsoleView.js:
  • inspector/front-end/DatabaseQueryView.js:
  • inspector/front-end/RuntimeModel.js:

(WebInspector.RuntimeModel.prototype.completionsForTextPrompt):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype.evaluateScriptSnippet.compileCallback):
(WebInspector.ScriptSnippetModel.prototype.evaluateScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype._runScript):

  • inspector/front-end/StylesSidebarPane.js:
  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.complete):

  • inspector/front-end/externs.js:
1:10 AM Changeset in webkit [130135] by pdr@google.com
  • 9 edits in trunk

Fix PerfTest standard deviation calculation.
https://bugs.webkit.org/show_bug.cgi?id=98115

Reviewed by Ryosuke Niwa.

Previously our standard deviation calculation was incorrect. This patch
updates perftest.py's algorithm to calculate the sample standard deviation
(with Bessel's correction) using Knuth's online algorithm:
http://en.wikipedia.org/wiki/Algorithms_for_calculating_variance#Online_algorithm
An existing test has been modified to prove our new results.

This patch also updates runner.js to use Bessel's correction in
its sample standard deviation calculation, which is more accurate
for small sample sizes.

Additionally, runner.js has been modified to not calculate
the 'sum' statistic, which was not very useful.

PerformanceTests:

  • resources/runner.js:

(PerfTestRunner.computeStatistics):

Tools:

  • Scripts/webkitpy/performance_tests/perftest.py:

The unused variable valueSum has also been removed.

(PageLoadingPerfTest.run):

  • Scripts/webkitpy/performance_tests/perftest_unittest.py:

This test calculates the stdev of {2000, 3000, ..., 20000} which
was hand-calculated using a spreadsheet.

(TestPageLoadingPerfTest.test_run):

LayoutTests:

  • fast/harness/perftests/perf-runner-compute-statistics-expected.txt:
  • fast/harness/perftests/perf-runner-compute-statistics.html:
  • fast/harness/perftests/runs-per-second-log-expected.txt:
1:10 AM Changeset in webkit [130134] by yosin@chromium.org
  • 3 edits in trunk/Source/WebCore

[Forms] Adding DateTimeDayFieldElement for multiple fields "date", "datetime", "datetime-local" input UI
https://bugs.webkit.org/show_bug.cgi?id=97998

Reviewed by Kent Tamura.

This patch introduces DateTimeDayFieldElement class for implementing
multiple fields "date", "datetime", and "datetime-local" input UI.

No new tests. This patch doesn't change behavior.

  • html/shadow/DateTimeFieldElements.cpp:

(WebCore::DateTimeDayFieldElement::DateTimeDayFieldElement): Added.
(WebCore::DateTimeDayFieldElement::create): Added.
(WebCore::DateTimeDayFieldElement::populateDateTimeFieldsState): Added.
(WebCore::DateTimeDayFieldElement::setValueAsDate): Added.
(WebCore::DateTimeDayFieldElement::setValueAsDateTimeFieldsState): Added.

  • html/shadow/DateTimeFieldElements.h:

(DateTimeDayFieldElement): Added.

1:09 AM Changeset in webkit [130133] by caseq@chromium.org
  • 7 edits
    2 copies
    1 move
    15 adds
    4 deletes in trunk/LayoutTests

Unreviewed gardening -- rebaselined canvas-render-layer and 4 week-multiple-fields-appearance tests.

  • platform/chromium-linux/fast/canvas/canvas-render-layer-expected.png: Removed.
  • platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-render-layer-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/canvas/canvas-render-layer-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-render-layer-expected.txt.
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png: Added.
  • platform/chromium-mac/fast/canvas/canvas-render-layer-expected.png:
  • platform/chromium-mac/fast/canvas/canvas-render-layer-expected.txt:
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png: Added.
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png: Added.
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-render-layer-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-render-layer-expected.txt: Removed.
  • platform/chromium-win-xp/fast/canvas/canvas-render-layer-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-render-layer-expected.txt.
  • platform/chromium-win/fast/canvas/canvas-render-layer-expected.png:
  • platform/chromium-win/fast/canvas/canvas-render-layer-expected.txt:
  • platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png: Added.
  • platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png: Added.
  • platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-render-layer-expected.png:
  • platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-render-layer-expected.txt: Removed.
  • platform/chromium/platform/chromium/virtual/gpu/fast/canvas/canvas-render-layer-expected.txt: Renamed from LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-render-layer-expected.txt.
1:03 AM Changeset in webkit [130132] by yosin@chromium.org
  • 2 edits in trunk/Source/WebCore

LocalzeNone::dateFormat() should have right date format.
https://bugs.webkit.org/show_bug.cgi?id=98123

Reviewed by Kent Tamura.

This patch changes date format in LocaleNone for multiple fields
date/datetime/datetime-local input UI.

No new tests. Other patch for ports which use LocaleNone and multiple
fields date/time input UI will have tests.

  • platform/text/LocaleNone.cpp:

(WebCore::LocaleNone::dateFormat): Changed month specifier to "MM".

1:00 AM Changeset in webkit [130131] by vsevik@chromium.org
  • 1 edit
    2 copies in branches/chromium/1271

Merge 129648 - Web Inspector: [REGRESSION] Revision support problems: revert and apply original content cause exceptions
https://bugs.webkit.org/show_bug.cgi?id=97669

Reviewed by Pavel Feldman.

Source/WebCore:

Added missed callback parameters.

Test: inspector/uisourcecode-revisions.html

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.revertToOriginal):
(WebInspector.UISourceCode.prototype.revertAndClearHistory):

LayoutTests:

  • inspector/uisourcecode-revisions-expected.txt: Added.
  • inspector/uisourcecode-revisions.html: Added.

TBR=vsevik@chromium.org
BUG=152433
Review URL: https://codereview.chromium.org/11039015

12:48 AM Changeset in webkit [130130] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: move cookies model out of the items view (into sdk component).
https://bugs.webkit.org/show_bug.cgi?id=98022

Reviewed by Yury Semikhatsky.

Otherwise Audits require code that belongs to the resources component.

  • inspector/front-end/CookieItemsView.js:
  • inspector/front-end/CookieParser.js:

(WebInspector.Cookies.getCookiesAsync):
(WebInspector.Cookies.buildCookiesFromString):
(WebInspector.Cookies.cookieMatchesResourceURL):
(WebInspector.Cookies.cookieDomainMatchesResourceDomain):

12:44 AM Changeset in webkit [130129] by loislo@chromium.org
  • 21 edits
    1 add in trunk/Source

Web Inspector: NMI make String* instrumentation non intrusive
https://bugs.webkit.org/show_bug.cgi?id=97964

Reviewed by Yury Semikhatsky.

Source/WebCore:

MemoryInstrumentationString.h include was added.

  • dom/WebCoreMemoryInstrumentation.h:

Source/WebKit/chromium:

The expectations were fixed because old instrumentation had wrong detector for BufferInternal type of storage.

  • tests/MemoryInstrumentationTest.cpp:

(WebCore::TEST):

Source/WTF:

MemoryInstrumentationString.h was added.
Intrusive instrumentation was removed.

  • GNUmakefile.list.am:
  • WTF.gypi:
  • WTF.pro:
  • WTF.vcproj/WTF.vcproj:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/MemoryInstrumentation.h:

(WTF):

  • wtf/MemoryInstrumentationString.h: Added.

(WTF):
(WTF::reportMemoryUsage):

  • wtf/text/AtomicString.cpp:

(WTF):

  • wtf/text/AtomicString.h:

(AtomicString):

  • wtf/text/CString.h:

(WTF::CStringBuffer::length):

  • wtf/text/StringImpl.cpp:
  • wtf/text/StringImpl.h:

(WTF::StringImpl::usesInternalBuffer):
(WTF::StringImpl::baseString):
(StringImpl):

12:17 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
12:05 AM Changeset in webkit [130128] by beidson@apple.com
  • 30 edits in trunk/Source

Remove the Safari 2 -> Safari 3 icon database import code.
https://bugs.webkit.org/show_bug.cgi?id=98113

Reviewed by Maciej Stachowiak.

Source/WebCore:

Remove notions of "importing an old database format" from the IconDatabase.

No new tests - Feature removed, and no previous tests covered it.

  • loader/icon/IconDatabase.cpp:

(DefaultIconDatabaseClient):
(WebCore::IconDatabase::IconDatabase):
(WebCore):
(WebCore::IconDatabase::iconDatabaseSyncThread):

  • loader/icon/IconDatabase.h:

(IconDatabase):

  • loader/icon/IconDatabaseBase.h:
  • loader/icon/IconDatabaseClient.h:
  • WebCore.exp.in:

Source/WebKit/blackberry:

Nuke the performImport() IconDatabaseClient method.

  • WebCoreSupport/IconDatabaseClientBlackBerry.cpp:
  • WebCoreSupport/IconDatabaseClientBlackBerry.h:

(IconDatabaseClientBlackBerry):

Source/WebKit/efl:

Nuke the performImport() IconDatabaseClient method.

  • WebCoreSupport/IconDatabaseClientEfl.cpp:
  • WebCoreSupport/IconDatabaseClientEfl.h:

Source/WebKit/gtk:

Nuke the performImport() IconDatabaseClient method.

  • webkit/webkitfavicondatabase.cpp:

(IconDatabaseClientGtk):

Source/WebKit/mac:

Nuke the performImport() IconDatabaseClient method, as well as the supporting methods.

  • Misc/WebIconDatabase.mm:
  • Misc/WebIconDatabaseInternal.h:
  • Misc/WebIconDatabasePrivate.h:
  • WebCoreSupport/WebIconDatabaseClient.h:
  • WebCoreSupport/WebIconDatabaseClient.mm:
  • WebKit.exp:

Source/WebKit/qt:

Nuke the performImport() IconDatabaseClient method.

  • WebCoreSupport/IconDatabaseClientQt.cpp:
  • WebCoreSupport/IconDatabaseClientQt.h:

(IconDatabaseClientQt):

Source/WebKit/win:

Nuke the performImport() IconDatabaseClient method.

  • WebIconDatabase.cpp:
  • WebIconDatabase.h:

(WebIconDatabase):

Source/WebKit2:

Nuke the performImport() IconDatabaseClient method.

  • UIProcess/WebIconDatabase.cpp:

(WebKit):

  • UIProcess/WebIconDatabase.h:

(WebIconDatabase):

Oct 1, 2012:

11:48 PM Changeset in webkit [130127] by yosin@chromium.org
  • 9 edits in trunk/Source/WebCore

Adding Localizer::dateFormat() for multiple fields date/datetime input UI
https://bugs.webkit.org/show_bug.cgi?id=98109

Reviewed by Kent Tamura.

This patch introduces Localizer::dateFormat() function for multiple
fields date/datetime/datetime-local input UI inside ENABLE_INPUT_MULTIPLE_FIELDS_UI.

We'll have platform specific implementations in LocaleICU, LocaleMac,
and LocaleWin.

No new tests. Other patches will add tests for this change.

  • platform/text/LocaleICU.cpp:

(WebCore::LocaleICU::dateFormat): Added a stub.

  • platform/text/LocaleICU.h:

(LocaleICU): Changed to add a declaration of dateFormat().

  • platform/text/LocaleNone.cpp:

(LocaleNone): Changed to add a declaration of dateFormat().
(WebCore::LocaleNone::dateFormat): Added.

  • platform/text/LocaleWin.cpp:

(WebCore::LocaleWin::dateFormat): Added.

  • platform/text/LocaleWin.h:

(LocaleWin): Changed to add a declaration of dateFormat().

  • platform/text/Localizer.h: Updates Unicode TR35 URI in a comment.

(Localizer): Changed to add a declaration of dateFormat().

  • platform/text/mac/LocaleMac.h:

(LocaleMac): Changed to add a declaration of dateFormat().

  • platform/text/mac/LocaleMac.mm:

(WebCore::LocaleMac::dateFormat): Added a stub.

11:42 PM Changeset in webkit [130126] by yosin@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

REGRESSION(r130116): Need to update DateTimeFormatTest
https://bugs.webkit.org/show_bug.cgi?id=98120

Reviewed by Kent Tamura.

This patch updates test cases for week of month and week of year type
specifiers in DateTimeFormat class. This tests should be updated
within r130116.

  • tests/DateTimeFormatTest.cpp:

(TEST_F): Changed test cases for changes of enum field value changes.

11:32 PM Changeset in webkit [130125] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix ASSERT introduced in
http://trac.webkit.org/changeset/130103. It turns out this case can
occur. This patch causes us to handle it the same way we did
previously.

  • bindings/v8/IntrusiveDOMWrapperMap.h:

(WebCore::IntrusiveDOMWrapperMap::removeIfPresent):

11:22 PM Changeset in webkit [130124] by shinyak@chromium.org
  • 2 edits in trunk/Source/WebCore

[Refactoring] DOMSelection should not use shadowAncestorNode
https://bugs.webkit.org/show_bug.cgi?id=97872

Reviewed by Ryosuke Niwa.

Since Node::shadowAncestorNode is deprecated, it should not be used.
Here, we should use TreeScope::ancestorInThisScope instead.

No new tests, covered by existing test.

  • page/DOMSelection.cpp:

(WebCore::selectionShadowAncestor):

11:20 PM Changeset in webkit [130123] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebCore

ScrollView::setScrollPosition is overridden by FrameView, but is not virtual
https://bugs.webkit.org/show_bug.cgi?id=98064

Reviewed by Simon Fraser.

Virtualize ScrollView::setScrollPosition, and override it in FrameView.

No new tests, this causes subtle behavior differences in currently-untestable code.

  • page/FrameView.h:

(FrameView):

  • platform/ScrollView.h:

(ScrollView):

11:17 PM Changeset in webkit [130122] by Dave Barton
  • 1 edit in trunk/Source/WebCore/ChangeLog

Restore WebCore/ChangeLog lines deleted in r130097
https://bugs.webkit.org/show_bug.cgi?id=98112

Reviewed by Eric Seidel.

11:15 PM Changeset in webkit [130121] by shinyak@chromium.org
  • 2 edits in trunk/Source/WebCore

TreeScope should not use node->shadowAncetorNode()
https://bugs.webkit.org/show_bug.cgi?id=97869

Reviewed by Ryosuke Niwa.

TreeScope uses shadowAncestorNode(), but we should use shadowHost() here. shadowAncestorNode() is deprecated.

No new tests, simple refactoring.

  • dom/TreeScope.cpp:

(WebCore::TreeScope::ancestorInThisScope):

11:10 PM Changeset in webkit [130120] by aestes@apple.com
  • 2 edits in branches/safari-534.58-branch/Source/WebCore

Update Localizable.strings by running update-webkit-localizable-strings.

  • English.lproj/Localizable.strings:
11:10 PM Changeset in webkit [130119] by pfeldman@chromium.org
  • 11 edits in trunk

Web Inspector: move completions calculation into RuntimeModel (part 1)
https://bugs.webkit.org/show_bug.cgi?id=98053

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • moves current execution context state into runtime model
  • moves completionsForTextPrompt and its private helpers into runtime model
  • makes text prompt use generic expression stop characters by default
  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._frameChanged):
(WebInspector.ConsoleView.prototype._appendContextOption):
(WebInspector.ConsoleView.prototype._contextChanged):

  • inspector/front-end/DatabaseQueryView.js:

(WebInspector.DatabaseQueryView):

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyPrompt):

  • inspector/front-end/RuntimeModel.js:

(WebInspector.RuntimeModel.prototype.setCurrentExecutionContext):
(WebInspector.RuntimeModel.prototype.currentExecutionContext):
(WebInspector.RuntimeModel.prototype._executionContextCreated):
(WebInspector.RuntimeModel.prototype.evaluate.evalCallback):
(WebInspector.RuntimeModel.prototype.evaluate):
(WebInspector.RuntimeModel.prototype.completionsForTextPrompt):
(WebInspector.RuntimeModel.prototype._completionsForExpression.evaluated.getCompletions):
(WebInspector.RuntimeModel.prototype._completionsForExpression.evaluated):
(WebInspector.RuntimeModel.prototype._completionsForExpression.receivedPropertyNamesFromEval):
(WebInspector.RuntimeModel.prototype._completionsForExpression.receivedPropertyNames):
(WebInspector.RuntimeModel.prototype._completionsForExpression):
(WebInspector.RuntimeModel.prototype._reportCompletions):

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt):

  • inspector/front-end/WatchExpressionsSidebarPane.js:

(WebInspector.WatchExpressionsSection.prototype.update):

LayoutTests:

  • http/tests/inspector/console-cd-completions.html:
  • http/tests/inspector/network/network-initiator-from-console.html:
  • inspector/debugger/debugger-completions-on-call-frame.html:
9:57 PM Changeset in webkit [130118] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

PerfTestRunner: Move all functions into the closure and always use double quotation for string literals
https://bugs.webkit.org/show_bug.cgi?id=98093

Reviewed by Ojan Vafai.

Move all methods of PerfTestRunner into the closure that defines it.
Also always use double quotations for string literals for consistency.

  • resources/runner.js:
9:42 PM Changeset in webkit [130117] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

The static function 'deleteFileSystem' in the LocalFileSystem.cpp should have another name.
https://bugs.webkit.org/show_bug.cgi?id=98106

Patch by Dongwoo Joshua Im <dw.im@samsung.com> on 2012-10-01
Reviewed by Yuta Kitamura.

A build error occurs because there are two functions which have same name in the LocalFileSystem.cpp file.
One is member function of the class, and the other is a static function which is called by the member function.
So, I've tried to change the name of the static function from 'deleteFileSystem' to 'performDeleteFileSystem'.

No new functionality, no new test.

  • Modules/filesystem/LocalFileSystem.cpp:

(WebCore::performDeleteFileSystem): The name of function is changed from 'deleteFileSystem'.
(WebCore::LocalFileSystem::requestFileSystem):
(WebCore::LocalFileSystem::deleteFileSystem):

9:22 PM Changeset in webkit [130116] by yosin@chromium.org
  • 4 edits in trunk/Source/WebCore

Week specifiers defined in DateTimeFormat class are wrong.
https://bugs.webkit.org/show_bug.cgi?id=98104

Reviewed by Kent Tamura.

This patch changes week of year and week of month format specifiers
defined in DateTimeFormat class to match with Unicode technical
standard 35, LDML, Locale Data Markup Language, (http://www.unicode.org/reports/tr35/).

No new tests. Following existing tests cover this change:

  • fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic.html
  • fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes.html
  • fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements.html
  • fast/forms/month-multiple-fields/month-multiple-fields-appearance-style.html
  • html/WeekInputType.cpp:

(WebCore::WeekInputType::setupLayoutParameters): Changed to use 'w' instead of 'W'.

  • platform/text/DateTimeFormat.cpp: Changed elements in lowerCaseToFieldTypeMap and upperCaseToFieldTypeMap.
  • platform/text/DateTimeFormat.h: Changed FieldTypeWeekOfMonth to 'W' and FieldTypeWeekOfYear to 'w'.
8:47 PM Changeset in webkit [130115] by jpetsovits@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove unused hasPendingScrollOrZoomEvent() interface.
https://bugs.webkit.org/show_bug.cgi?id=98107
RIM PR 173292

Reviewed by George Staikos.

This method is not referenced anywhere anymore,
so we should stop requiring it from WebPageClient
implementations.

  • Api/WebPageClient.h:
8:11 PM Changeset in webkit [130114] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Add other <string> typed tokens to YYDEBUG token output
https://bugs.webkit.org/show_bug.cgi?id=98102

Patch by Glenn Adams <glenn@skynav.com> on 2012-10-01
Reviewed by Simon Fraser.

Add other <string> typed tokens to YYPRINT macro expansion. Minor cleanup of cast.

No new tests. For CSS lexer/parser debug usage only.

  • css/CSSGrammar.y:

Add other <string> typed tokens to YYPRINT macro expansion.
Change C-type cast to function-call style cast (per darin).

7:37 PM Changeset in webkit [130113] by keishi@webkit.org
  • 9 edits
    2 moves in trunk

Calendar picker should use zero as default step base
https://bugs.webkit.org/show_bug.cgi?id=97976

Reviewed by Kent Tamura.

.:

  • ManualTests/forms/calendar-picker.html: Added stepBase parameters.

Source/WebCore:

Calendar picker should be using zero as default step base for input type=date.
The spec says to use zero unless specified otherwise.
Since input type=week has another default step base, I am adding step base
to DateTimeChooserParameters.

Test: fast/forms/date/calendar-picker-with-step.html

  • Resources/pagepopups/calendarPicker.js:

(handleArgumentsTimeout):
(CalendarPicker):
(CalendarPicker.prototype.stepMismatch): Use the new this.stepBase.

  • html/shadow/PickerIndicatorElement.cpp:

(WebCore::PickerIndicatorElement::openPopup): Gets step base from step range.

  • platform/DateTimeChooser.h:

(DateTimeChooserParameters): Added stepBase.

Source/WebKit/chromium:

  • src/DateTimeChooserImpl.cpp:

(WebKit::DateTimeChooserImpl::writeDocument): stepBase needs 11 digits of precision when setting maximum possible date.

LayoutTests:

  • fast/forms/date/calendar-picker-with-step-expected.txt: Renamed from LayoutTests/fast/forms/date/calendar-picker-appearance-with-step-expected.txt.
  • fast/forms/date/calendar-picker-with-step.html: Renamed from LayoutTests/fast/forms/date/calendar-picker-appearance-with-step.html. Renamed because this does not test apeparance.
7:07 PM Changeset in webkit [130112] by roger_fong@apple.com
  • 1 edit
    1 add
    1 delete in trunk/LayoutTests

Unreviewed. Fix expected result name.

  • platform/win/fast/text/international/float-as-only-child-of-isolate-crash-expected.txt: Added.
  • platform/win/fast/text/international/float-as-only-child-of-isolate-crash-expected.txt.txt: Removed.
6:55 PM Changeset in webkit [130111] by keishi@webkit.org
  • 6 edits
    3 adds in trunk/LayoutTests

Add more tests for calendar picker
https://bugs.webkit.org/show_bug.cgi?id=98034

Reviewed by Kent Tamura.

This adds basic tests for all key bindings and simple mouse operations.

  • fast/forms/date/calendar-picker-common.js: Added.

(currentMonth): Returns month that the picker is currently showing.
(selectedDate):
(openPicker): Opens the calendar picker and updates popupWindow.
(sendKey):

  • fast/forms/date/calendar-picker-key-operations-expected.txt:
  • fast/forms/date/calendar-picker-key-operations.html:
  • fast/forms/date/calendar-picker-mouse-operations-expected.txt: Added.
  • fast/forms/date/calendar-picker-mouse-operations.html: Added.
  • fast/forms/resources/common.js:

(cumulativeOffset):
(hoverOverElement):
(clickElement):

  • platform/chromium/fast/forms/date/date-suggestion-picker-mouse-operations.html:
  • platform/gtk/TestExpectations: Added calendar-picker-mouse-operations.html.
6:51 PM Changeset in webkit [130110] by tony@chromium.org
  • 7 edits
    2 adds in trunk

flexbox does wrong baseline item alignment in columns
https://bugs.webkit.org/show_bug.cgi?id=97948

Reviewed by Ojan Vafai.

Source/WebCore:

For columns, baseline alignment should just be flex-start. We were previously
moving the logical left edge by the ascent.

Test: css3/flexbox/align-baseline.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::alignmentForChild): Map baseline to flex-start for orthogonal children.
(WebCore::RenderFlexibleBox::alignChildren): Add FIXME for bug in baseline alignment.

  • rendering/RenderFlexibleBox.h:

LayoutTests:

Update test cases with new baseline alignment for column.

  • css3/flexbox/align-baseline-expected.html: Added.
  • css3/flexbox/align-baseline.html: Added.
  • css3/flexbox/flex-align-baseline-expected.txt:
  • css3/flexbox/flex-align-baseline.html:
  • css3/flexbox/multiline-align-self.html:
6:21 PM Changeset in webkit [130109] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JSArray::unshiftCountSlowCase needs to clear array slots when adding space to end of array
https://bugs.webkit.org/show_bug.cgi?id=98101

Reviewed by Filip Pizlo.

Cleared new array entries when adding to end due to shifting contents to lower memory. Also
checnaged the order of moving array contents and metadata in the shift left case to avoid
clobbering the metadata with array contents. Optimized the to only make a memmove if the
count is non-zero.

  • runtime/JSArray.cpp:

(JSC::JSArray::unshiftCountSlowCase):
(JSC::JSArray::unshiftCount):

6:14 PM Changeset in webkit [130108] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[Gtk] crash when accelerated composition is turned off
https://bugs.webkit.org/show_bug.cgi?id=98099

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-10-01
Reviewed by Martin Robinson.

frame->view()->updateLayoutAndStyleIfNeededRecursive() may reset root
compositing layer in flushAndRenderLayers. So, we check if compositing
is enabled afterwards, and return if it is not.

This bug is handled by LayoutTests/compositing/toggle-compositing.html

  • WebCoreSupport/AcceleratedCompositingContextGL.cpp:

(WebKit::AcceleratedCompositingContext::flushAndRenderLayers):

6:03 PM Changeset in webkit [130107] by yosin@chromium.org
  • 8 edits
    14 adds in trunk/LayoutTests

Adding appearance tests for multiple fields week input UI
https://bugs.webkit.org/show_bug.cgi?id=98006

Reviewed by Kent Tamura.

This patch adds tests for multiple fields week input UI and disables
these tests on ports which don't enable both ENABLE_INPUT_TYPE_WEEK
and ENABLE_INPUT_MULTIPLE_FIELDS_UI.

Note: We need to do rebaseline tests to update images for Chromium-Mac
and Chromium-Win.

Note: This patch affects ports which enable both ENABLE_INPUT_TYPE_WEEK
and ENABLE_INPUT_MULTIPLE_FIELDS_UI.

  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.txt: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic.html: Added for checking basic appearance.
  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.txt: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes.html: Added for checking appearance of applying CSS pseudo classes, e.g. :enabled, :invalid, and so on.
  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.txt: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements.html: Added for checking appearance of applying CSS pseudo elements, e.g. :after, :before, and so on.
  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.txt: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-style.html: Added for checking appearance of applying CSS styles
  • platform/chromium-android/TestExpectations: Changed to disable tests for multiple fields week input UI.
  • platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png: Added.
  • platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png: Added.
  • platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png: Added.
  • platform/chromium/TestExpectations: Changed to disable tests for multiple fields week input UI of Mac and Win for rebaseline.
  • platform/efl/TestExpectations: Changed to disable tests for multiple fields week input UI.
  • platform/gtk/TestExpectations: ditto
  • platform/mac/TestExpectations: ditto
  • platform/qt/TestExpectations: ditto
  • platform/win/TestExpectations: ditto
5:55 PM Changeset in webkit [130106] by keishi@webkit.org
  • 5 edits
    2 moves in trunk/Source/WebCore

Rename CalendarPickerElement to PickerIndicatorElement
https://bugs.webkit.org/show_bug.cgi?id=98096

Reviewed by Kent Tamura.

Renaming CalendarPickerElement to PickerIndicatorElement because we want to use it for other input types like time, week, month, datetime.

No new tests. Just a rename.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • html/DateInputType.cpp:

(WebCore::DateInputType::createShadowSubtree):

  • html/DateInputType.h:

(WebCore):
(DateInputType):

  • html/shadow/PickerIndicatorElement.cpp: Renamed from Source/WebCore/html/shadow/CalendarPickerElement.cpp.

(WebCore):
(WebCore::PickerIndicatorElement::PickerIndicatorElement):
(WebCore::PickerIndicatorElement::create):
(WebCore::PickerIndicatorElement::~PickerIndicatorElement):
(WebCore::PickerIndicatorElement::createRenderer):
(WebCore::PickerIndicatorElement::hostInput):
(WebCore::PickerIndicatorElement::defaultEventHandler):
(WebCore::PickerIndicatorElement::willRespondToMouseClickEvents):
(WebCore::PickerIndicatorElement::didChooseValue):
(WebCore::PickerIndicatorElement::didEndChooser):
(WebCore::PickerIndicatorElement::openPopup):
(WebCore::PickerIndicatorElement::closePopup):
(WebCore::PickerIndicatorElement::detach):

  • html/shadow/PickerIndicatorElement.h: Renamed from Source/WebCore/html/shadow/CalendarPickerElement.h.

(WebCore):
(PickerIndicatorElement):

5:36 PM WebKitGTK/1.10.x edited by Martin Robinson
(diff)
5:28 PM Changeset in webkit [130105] by ojan@chromium.org
  • 45 edits in trunk/Source/WebCore

Unreviewed, rolling out r130079.
http://trac.webkit.org/changeset/130079
https://bugs.webkit.org/show_bug.cgi?id=95866

Broke the chomium windows compile.

  • css/CSSFontFace.cpp:

(WebCore::CSSFontFace::getFontData):

  • css/CSSFontFace.h:

(CSSFontFace):

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):

  • css/CSSFontFaceSource.h:

(CSSFontFaceSource):

  • css/CSSFontSelector.cpp:

(WebCore::fontDataForGenericFamily):
(WebCore::CSSFontSelector::getFontData):

  • css/CSSFontSelector.h:
  • css/CSSSegmentedFontFace.cpp:

(WebCore::appendFontDataWithInvalidUnicodeRangeIfLoading):
(WebCore::CSSSegmentedFontFace::getFontData):

  • css/CSSSegmentedFontFace.h:

(CSSSegmentedFontFace):

  • dom/Document.cpp:

(WebCore::Document::registerCustomFont):

  • dom/Document.h:

(Document):

  • platform/graphics/Font.h:

(WebCore):

  • platform/graphics/FontCache.cpp:

(WebCore):
(WebCore::FontCache::getCachedFontData):
(WebCore::FontCache::getNonRetainedLastResortFallbackFont):
(WebCore::FontCache::releaseFontData):
(WebCore::FontCache::purgeInactiveFontData):
(WebCore::FontCache::getFontData):

  • platform/graphics/FontCache.h:

(FontCache):

  • platform/graphics/FontData.h:
  • platform/graphics/FontFallbackList.cpp:

(WebCore::FontFallbackList::releaseFontData):
(WebCore::FontFallbackList::fontDataAt):
(WebCore::FontFallbackList::setPlatformFont):

  • platform/graphics/FontFallbackList.h:

(FontFallbackList):

  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::glyphDataAndPageForCharacter):

  • platform/graphics/FontSelector.h:

(FontSelector):

  • platform/graphics/GlyphPageTreeNode.cpp:

(WebCore::GlyphPageTreeNode::initializePage):

  • platform/graphics/SegmentedFontData.cpp:

(WebCore::SegmentedFontData::fontDataForCharacter):

  • platform/graphics/SegmentedFontData.h:

(WebCore::FontDataRange::FontDataRange):
(WebCore::FontDataRange::fontData):
(FontDataRange):
(SegmentedFontData):

  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::verticalRightOrientationFontData):
(WebCore::SimpleFontData::uprightOrientationFontData):
(WebCore::SimpleFontData::brokenIdeographFontData):

  • platform/graphics/SimpleFontData.h:

(SimpleFontData):
(WebCore::SimpleFontData::variantFontData):
(DerivedFontData):

  • platform/graphics/chromium/FontCacheAndroid.cpp:

(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/chromium/FontCacheChromiumWin.cpp:

(WebCore::FontCache::fontDataFromDescriptionAndLogFont):
(GetLastResortFallbackFontProcData):
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:

(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):

  • platform/graphics/freetype/FontCacheFreeType.cpp:

(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):

  • platform/graphics/mac/ComplexTextControllerCoreText.mm:

(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore::Font::fontDataForCombiningCharacterSequence):

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):

  • platform/graphics/pango/FontCachePango.cpp:

(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/pango/SimpleFontDataPango.cpp:

(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):

  • platform/graphics/qt/FontCacheQt.cpp:

(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/qt/SimpleFontDataQt.cpp:

(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):

  • platform/graphics/skia/FontCacheSkia.cpp:

(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/skia/SimpleFontDataSkia.cpp:

(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):

  • platform/graphics/win/FontCacheWin.cpp:

(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::fontDataFromDescriptionAndLogFont):
(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/win/SimpleFontDataWin.cpp:

(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):

  • platform/graphics/wince/FontCacheWinCE.cpp:
  • platform/graphics/wince/SimpleFontDataWinCE.cpp:

(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):

  • platform/graphics/wx/FontCacheWx.cpp:

(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/wx/SimpleFontDataWx.cpp:

(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):

5:26 PM Changeset in webkit [130104] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

Speculative GTK build fix after http://trac.webkit.org/changeset/130091

  • GNUmakefile.list.am:
5:16 PM Changeset in webkit [130103] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

[V8] ScriptWrappable should hold the wrapper handle directly (Dromaeo/dom-traverse gets 4% faster)
https://bugs.webkit.org/show_bug.cgi?id=97974

Reviewed by Kentaro Hara.

Previously, we stored a pointer to a handle to a wrapper in Node. That
is an extra layer of indirection that slows down finding the wrapper
for the node. A handle is just a pointer, so we might as we just store
the handle in the Node directly. That speeds up dom-traverse by about 4%.

We were using the extra layer of indirection in IntrusiveDOMWrapperMap
to make removal more efficient. Rather than using a chunked table, we
now use a HashSet, which also lets us remove elements quickly.

  • bindings/v8/IntrusiveDOMWrapperMap.h:

(WebCore::IntrusiveDOMWrapperMap::IntrusiveDOMWrapperMap):
(WebCore::IntrusiveDOMWrapperMap::get):
(WebCore::IntrusiveDOMWrapperMap::set):
(WebCore::IntrusiveDOMWrapperMap::contains):
(WebCore::IntrusiveDOMWrapperMap::visit):
(WebCore::IntrusiveDOMWrapperMap::removeIfPresent):
(WebCore::IntrusiveDOMWrapperMap::clear):

  • bindings/v8/ScriptWrappable.h:

(WebCore::ScriptWrappable::ScriptWrappable):
(WebCore::ScriptWrappable::wrapper):
(WebCore::ScriptWrappable::setWrapper):
(WebCore::ScriptWrappable::disposeWrapper):
(WebCore::ScriptWrappable::reportMemoryUsage):
(ScriptWrappable):

  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getCachedWrapper):

5:14 PM Changeset in webkit [130102] by fpizlo@apple.com
  • 7 edits
    3 adds in trunk

Address a FIXME in JSArray::sort
https://bugs.webkit.org/show_bug.cgi?id=98080
<rdar://problem/12407844>

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Get rid of fast sorting of sparse maps. I don't know that it's broken but I do know that we don't
have coverage for it. Then also address the FIXME in JSArray::sort regarding side-effecting
compare functions.

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncSort):

  • runtime/JSArray.cpp:

(JSC::JSArray::sortNumeric):
(JSC::JSArray::sort):
(JSC::JSArray::compactForSorting):

  • runtime/JSArray.h:

(JSArray):

  • runtime/JSObject.h:

(JSC::JSObject::hasSparseMap):
(JSObject):

LayoutTests:

  • fast/js/jsc-test-list:
  • fast/js/script-tests/sort-with-side-effecting-comparisons.js: Added.
  • fast/js/sort-with-side-effecting-comparisons-expected.txt: Added.
  • fast/js/sort-with-side-effecting-comparisons.html: Added.
5:14 PM Changeset in webkit [130101] by ojan@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r130062.
http://trac.webkit.org/changeset/130062
https://bugs.webkit.org/show_bug.cgi?id=98001

Causes a ton of gtest failures on the chromium bots.

  • platform/chromium/LanguageChromium.cpp:

(WebCore::platformLanguage):

5:12 PM Changeset in webkit [130100] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Skipping flaky test on Windows: inspector/debugger/dynamic-script-tag.html.
https://bugs.webkit.org/show_bug.cgi?id=98095

  • platform/win/TestExpectations:
4:48 PM Changeset in webkit [130099] by rniwa@webkit.org
  • 7 edits in trunk

Encapsulate private properties in PerfTestRunner better
https://bugs.webkit.org/show_bug.cgi?id=97833

Reviewed by Ojan Vafai.

PerformanceTests:

This patch moves "private" methods and properties of PerfTestRunner into a closure so that they're
inaccssible from outside. Also catch exceptions from test.run, test.done, and other runner code
to ensure we call notifyDone() even if we broke tests. Otherwise DRT will timeout and we end up
waiting for 10 minutes per each broken test on bots.

  • resources/runner.js:

(PerfTestRunner.gc):
(logInDocument): Extracted from PerfTestRunner.log.
(PerfTestRunner.log): Moved.
(logFatalError): Added.
(start): Renamed from PerfTestRunner._start.
(scheduleNextRun): Extracted from PerfTestRunner._runLoop. Also catch any exceptions that happen
in the runner and ignoreWarmUpAndLog so that we don't end up timing out. We call logFatalError in
such cases, which in turn ensures notifyDone() is called.
(ignoreWarmUpAndLog): Renamed from PerfTestRunner._ignoreWarmUpAndLog.
(finish): Extracted from PerfTestRunner._runLoop.
(PerfTestRunner.measureTime): Moved. The initialization of runCount is moved into start().
(measureTimeOnce): Renamed from PerfTestRunner._measureTimeOnce.
(PerfTestRunner.runPerSecond): Moved. Ditto about runCount.
(measureRunsPerSecondOnce): Renamed from PerfTestRunner._measureRunsPerSecondOnce.
(callRunAndMeasureTime): Renamed from PerfTestRunner._perSecondRunnerIterator.

LayoutTests:

Override PerfTestRunner.now instead of PerfTestRunner._perSecondRunnerIterator since the latter
is no longer exposed.

  • fast/harness/perftests/runs-per-second-iterations-expected.txt:
  • fast/harness/perftests/runs-per-second-iterations.html: Increase the runtime of the last 4 runs

since test.timeToRun is no longer supported by PerfTestRunner.

  • fast/harness/perftests/runs-per-second-log-expected.txt:
  • fast/harness/perftests/runs-per-second-log.html: Avoid use numbers that contain primes other

than 2 and 5 as runs because they cause rouding errors in PerfTestRunner.measureRunsPerSecondOnce
and make the output dependent on the underlying floating number implementation.

4:43 PM Changeset in webkit [130098] by roger_fong@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed. Rolling out changes from http://trac.webkit.org/changeset/119130.
Tests match older results.

  • platform/win/fast/text/international/float-as-only-child-of-isolate-crash-expected.png: Added.
  • platform/win/fast/text/international/float-as-only-child-of-isolate-crash-expected.txt.txt: Added.
4:20 PM Changeset in webkit [130097] by Dave Barton
  • 24 edits in trunk

[MathML] Baseline wrong for fractions or munder/mover with padding
https://bugs.webkit.org/show_bug.cgi?id=97990

Reviewed by Eric Seidel.

Source/WebCore:

We include any border or padding in our baseline computation. We also take this opportunity
to quit adding extra left & right padding to numerators and denominators, making our output
tighter and also more compatible with Firefox and TeX, since we are rebaselining some
fraction pixel tests now anyway.

Tests added to LayoutTests/mathml/presentation/{over,row-alignment}.xhtml

  • rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::fixChildStyle):
(WebCore::RenderMathMLFraction::paint):
(WebCore::RenderMathMLFraction::firstLineBoxBaseline):

  • rendering/mathml/RenderMathMLUnderOver.cpp:

(WebCore::RenderMathMLUnderOver::firstLineBoxBaseline):

LayoutTests:

We handle any border and padding correctly, and quit adding extra left and right padding
to numerators and denominators.

  • mathml/presentation/over.xhtml:
  • mathml/presentation/row-alignment.xhtml:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/mathml/presentation/attributes-expected.png:
  • platform/mac/mathml/presentation/attributes-expected.txt:
  • platform/mac/mathml/presentation/fractions-expected.png:
  • platform/mac/mathml/presentation/fractions-expected.txt:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/mac/mathml/presentation/mo-stretch-expected.png:
  • platform/mac/mathml/presentation/mo-stretch-expected.txt:
  • platform/mac/mathml/presentation/over-expected.png:
  • platform/mac/mathml/presentation/over-expected.txt:
  • platform/mac/mathml/presentation/roots-expected.png:
  • platform/mac/mathml/presentation/roots-expected.txt:
  • platform/mac/mathml/presentation/row-align