Timeline



Oct 24, 2012:

11:54 PM Changeset in webkit [132453] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip a new failing test.

  • platform/qt/TestExpectations:
11:47 PM Changeset in webkit [132452] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Minimize CSS rulesets for multiple-fields input
https://bugs.webkit.org/show_bug.cgi?id=100198

Reviewed by Kentaro Hara.

  • Unify rulesets for input::-webkit-datetime-edit-*-field. input::-webkit-datetime-edit-*-field had identical ruleset.
  • Move some rulesets near to related rulesets. Move -webkit-datetime-edit-*-field:focus nearby the new unified ruleset. Move input::-webkit-datetime-edit-second-field[readonly] nearby

input::-webkit-datetime-edit-minute-field[readonly].

No new tests. This shouldn't make any behavior change.

  • css/html.css:

(input::-webkit-datetime-edit-year-field):
(input::-webkit-datetime-edit-year-field:focus):
(input::-webkit-datetime-edit-second-field[readonly]):

11:42 PM Changeset in webkit [132451] by tkent@chromium.org
  • 3 edits
    2 adds in trunk

REGRESSION(r132291): Crash in BaseMultipleFieldsDateAndTimeInputType
https://bugs.webkit.org/show_bug.cgi?id=100326

Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/forms/time-multiple-fields/time-multiple-fields-change-type.html

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::destroyShadowSubtree):
We need to disconnect m_spinButtonElement before destructing the UA shadow tree.

LayoutTests:

  • fast/forms/time-multiple-fields/time-multiple-fields-change-type-expected.txt: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-change-type.html: Added.
11:38 PM Changeset in webkit [132450] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed: updating chromium TestExpectations for the roll.

  • platform/chromium/TestExpectations:
11:32 PM Changeset in webkit [132449] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed: updating chromium TestExpectations for the roll.

  • platform/chromium/TestExpectations:
11:31 PM Changeset in webkit [132448] by commit-queue@webkit.org
  • 2 edits in trunk/Source/Platform

[chromium] Add textureWidth() and textureHeight() to WebVideoFrame
https://bugs.webkit.org/show_bug.cgi?id=100042

Patch by John Sheu <sheu@google.com> on 2012-10-24
Reviewed by James Robinson.

It might be the case that the visible portion of a video frame isn't the
entire texture size, e.g. for cropping. We'll need accessors in
WebVideoFrame to be able to query both the underlying texture dimensions
and the subrect which is supposed to be visible.

This is presently a no-op change. Once Chromium changes are in, I will
remove the superseded parts of the WebVideoFrame interface.

  • chromium/public/WebVideoFrame.h:

(WebKit::WebVideoFrame::visibleRect);
(WebKit::WebVideoFrame::textureSize);

11:06 PM Changeset in webkit [132447] by abarth@webkit.org
  • 6 edits
    2 deletes in trunk/Source/WebCore

[V8] DOMData is no longer needed
https://bugs.webkit.org/show_bug.cgi?id=100313

Reviewed by Eric Seidel.

This class serves no purpose anymore and can be deleted.

  • WebCore.gypi:
  • bindings/v8/DOMData.cpp: Removed.
  • bindings/v8/DOMData.h: Removed.
  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::current):

  • bindings/v8/DOMDataStore.h:

(WebCore):
(DOMDataStore):

  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::neuterBinding):

  • bindings/v8/V8DOMMap.cpp:

(WebCore::getDOMNodeMap):
(WebCore::getActiveDOMNodeMap):
(WebCore::getDOMObjectMap):
(WebCore::getActiveDOMObjectMap):
(WebCore::removeAllDOMObjects):
(WebCore::visitActiveDOMNodes):
(WebCore::visitDOMObjects):
(WebCore::visitActiveDOMObjects):

11:03 PM Changeset in webkit [132446] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed: platform/chromium/TestExpectations lint.

  • platform/chromium/TestExpectations:
10:24 PM Changeset in webkit [132445] by yuqiang.xian@intel.com
  • 5 edits in trunk/Source/JavaScriptCore

Refactor LLInt64 to distinguish the pointer operations from the 64-bit integer operations
https://bugs.webkit.org/show_bug.cgi?id=100321

Reviewed by Filip Pizlo.

We have refactored the MacroAssembler and JIT compilers to distinguish
the pointer operations from the 64-bit integer operations (see bug #99154).
Now we want to do the similar work for LLInt, and the goal is same as
the one mentioned in 99154.

This is the first part of the modification: in the offline assembler,
adding the support of the "<foo>q" instructions which will be used for
64-bit integer operations.

  • llint/LowLevelInterpreter.cpp:

(JSC::CLoop::execute):

  • offlineasm/cloop.rb:
  • offlineasm/instructions.rb:
  • offlineasm/x86.rb:
10:13 PM Changeset in webkit [132444] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Sort an Xcode project file.

  • WebCore.xcodeproj/project.pbxproj: Sorted.
8:41 PM Changeset in webkit [132443] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] ASSERT(!needsOneShotDrawingSynchronization()) failed in commitRootLayerIfNeeded()
https://bugs.webkit.org/show_bug.cgi?id=100214

Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2012-10-24
Reviewed by Rob Buis.

ViewportSize has been changed before committing root layer, it asserts
that it needs relayout and render if needed before committing if it
Needs One Shot Drawing Synchronization.
This patch calls requestLayoutIfNeeded() when resumeScreenAndBackingStoreUpdates().

Fix a coding style in the BackingStore.cpp as well.

Reviewed internally by Arvid Nilsson.
PR #230253

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::resumeScreenAndBackingStoreUpdates):

8:07 PM Changeset in webkit [132442] by commit-queue@webkit.org
  • 6 edits
    15 deletes in trunk/LayoutTests

Rebaseline some sputnik unicode failed cases.
https://bugs.webkit.org/show_bug.cgi?id=99976

Unreviewed rebaseline.

According to BUG 93103, seems these four test cases have different results after libicu 4.6 version.
As Ubuntu 12.04 installs 4.8 and mac has same result with windows, expected results on BUG 93103 could replace common result file except chromium-mac-snowleopard.

Patch by Kangil Han <kangil.han@samsung.com> on 2012-10-24

  • platform/chromium/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt: Removed.
  • platform/chromium/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Removed.
  • platform/chromium/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Removed.
  • platform/chromium/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Removed.
  • platform/efl/TestExpectations:
  • platform/gtk/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Removed.
  • platform/gtk/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Removed.
  • platform/gtk/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Removed.
  • platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt: Removed.
  • platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Removed.
  • platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Removed.
  • platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Removed.
  • platform/mac/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt: Removed.
  • platform/mac/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Removed.
  • platform/mac/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Removed.
  • platform/mac/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Removed.
  • sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt:
  • sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt:
  • sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt:
  • sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt:
8:07 PM Changeset in webkit [132441] by abarth@webkit.org
  • 19 edits
    1 add in trunk/Source/WebCore

[V8] AbstractWeakReferenceMap is unnecessarily general and complex
https://bugs.webkit.org/show_bug.cgi?id=100175

Reviewed by Eric Seidel.

Before this patch, AbstractWeakReferenceMap served two masters:

1) DOM wrappers
2) NPV8 function templates

These two uses cases pushed AbstractWeakReferenceMap to be more general
and complex that needed. This patch separates these two uses cases into
two separate classes. V8NPTemplateMap is all of 40 lines of code. It's
not worth complicating the DOM wrapper code path to share that tiny
amount of code.

The other thing this patch does is store a pointer to the DOM wrapper
map as the weak callback context object. That means we no longer need
to search through all the wrapper maps in order to find the map that
contains this particular DOM wrapper.

  • WebCore.gypi:
  • bindings/v8/DOMData.cpp:
  • bindings/v8/DOMData.h:

(DOMData):

  • bindings/v8/DOMDataStore.cpp:
    • Delete all these complicated weak callback functions. The weak callback functions are now an order of magnitude simpler and declared as private member functions on the wrapper map.
  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::domNodeMap):
(WebCore::DOMDataStore::activeDomNodeMap):
(DOMDataStore):

  • We now have a consistent type to use for all these wrapper maps. Both the hash map and the intrusive map derive from DOMWrapperMap (with a single template parameter).
  • bindings/v8/DOMWrapperMap.h: Added.

(WebCore):
(DOMWrapperVisitor):

  • The visitor is no longer an inner class. It's just a top-level class that does the same thing.

(DOMWrapperMap):

  • The abstract interface for DOMWrapperMap has about half as many functions as the old AbstractWeakReferenceMap because the two use cases are disentangled.

(WebCore::DOMWrapperMap::~DOMWrapperMap):
(DOMWrapperHashMap):

  • This is a concrete instance of DOMWrapperMap that uses a hash map.

(WebCore::DOMWrapperHashMap::DOMWrapperHashMap):
(WebCore::DOMWrapperHashMap::remove):
(WebCore::DOMWrapperHashMap::defaultWeakCallback):

  • Notice that the context parameter now points to the hashmap itself rather than to the native object. Now that we don't need to handle the NPAPI case, we can recover the native object from the wrapper using toNative. The assert in set() ensures that this always works.
  • bindings/v8/DOMWrapperWorld.h:
  • bindings/v8/IntrusiveDOMWrapperMap.h:
    • These classes are now simplified because they need to implement fewer functions.

(WebCore::DOMNodeWrapperMap::weakCallback):

  • For this weak callback, we still use the native object as the context parameter. We could also recover the native object from the wrapper, which means this context parameter is available to do other work.
  • bindings/v8/ScopedDOMDataStore.cpp:

(WebCore::ScopedDOMDataStore::ScopedDOMDataStore):

  • This code no longer needs to have knowledge of which weak callbacks these objects use.

(WebCore::ScopedDOMDataStore::~ScopedDOMDataStore):

  • We need to clear the maps before deleting them because there are still JavaScript objects that have references to the map in their weak callback parameter. Previously, we handled this case because we would search all the wrapper maps and fail to find the wrapper.
  • bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::visitExternalArrays):

  • bindings/v8/StaticDOMDataStore.cpp:
    • This code no longer needs to have knowledge of which weak callback these maps use.
  • bindings/v8/StaticDOMDataStore.h:

(StaticDOMDataStore):

  • bindings/v8/V8DOMMap.cpp:

(WebCore::getDOMNodeMap):
(WebCore::getActiveDOMNodeMap):
(WebCore::removeAllDOMObjects):

  • Rather than using some complicated visitor pattern, we can now just call clear() directly on the maps to remove all the objects.

(WebCore::visitActiveDOMNodes):
(WebCore::visitDOMObjects):
(WebCore::visitActiveDOMObjects):

  • bindings/v8/V8DOMMap.h:

(WebCore):

  • Delete the old versions of these classes.

(DOMDataStoreHandle):

  • Style nit: one-argument constructors should be marked explicit.
  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::domWrapperType):

  • I moved this logic into WrapperTypeInfo.h to avoid a circular header dependency.
  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getCachedWrapper):

  • bindings/v8/V8GCController.cpp:
    • EnsureWeakDOMNodeVisitor is no longer used (or needed since we no longer clear the weak callbacks in V8GCController).
  • bindings/v8/V8NPObject.cpp:

(V8NPTemplateMap):

  • staticTemplateMap is no longer an instance of WeakReferenceMap. Instead, this patch just implements the functionality we need here directly.

(WebCore::V8NPTemplateMap::get):
(WebCore::V8NPTemplateMap::set):
(WebCore::V8NPTemplateMap::sharedInstance):
(WebCore::V8NPTemplateMap::weakCallback):
(WebCore::V8NPTemplateMap::dispose):
(WebCore::npObjectGetProperty):
(WebCore):
(WebCore::staticNPObjectMap):
(WebCore::weakNPObjectCallback):

  • DOMWrapperMap no longer exposes a "forget" function. Instead, we just use the more basic "remove" and "Dispose" operations to do the same thing. This is possible now because we no longer have "removeIfPossible" to support searching all the wrapper maps for the one that has the right wrapper.

(WebCore::createV8ObjectForNPObject):

  • DOMWrapperMap No longer has a "contains" function. Instead, we use get, which actually makes this code more efficient because we only do one hash map lookup.

(WebCore::forgetV8ObjectForNPObject):

  • The changes here are a combination of the two sorts of changes above.
  • bindings/v8/WrapperTypeInfo.h:

(WebCore::toNative):
(WebCore::toWrapperTypeInfo):

  • The patch moves these functions into this header to avoid a circular header dependency.
7:01 PM Changeset in webkit [132440] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Geolocation is segfaulting
https://bugs.webkit.org/show_bug.cgi?id=100305

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-10-24
Reviewed by Rob Buis.

We weren't wrapping the Geolocation object in a RefPtr when we call setIsAllowed in
GeolocationClientBlackBerry::onPermission.

This patch also removes all references of the Geolocation object in WebPageClientImpl.
One RefPtr<Geolocation> is used to store the reference of the WebCore object on our port.

We don't need a mapping between origin -> context of Geolocation because in our port,
one WebPage.cpp contains one GeolocationController only.

  • Api/WebPageClient.h:
  • WebCoreSupport/GeolocationClientBlackBerry.cpp:

(frameOrigin):
(GeolocationClientBlackBerry::requestPermission):
(GeolocationClientBlackBerry::cancelPermissionRequest):
(GeolocationClientBlackBerry::onPermission):

  • WebCoreSupport/GeolocationClientBlackBerry.h:

(GeolocationClientBlackBerry):

6:44 PM Changeset in webkit [132439] by dpranke@chromium.org
  • 3 edits in trunk/Tools

nrwt: fix a couple of minor crashing issues under cygwin
https://bugs.webkit.org/show_bug.cgi?id=100309

Reviewed by Ojan Vafai.

Cygwin was crashing on a null object reference and then
an oserror in kill().

  • Scripts/webkitpy/common/system/executive.py:

(Executive.kill_process):

  • Scripts/webkitpy/layout_tests/port/server_process.py:

(ServerProcess.stop):

6:26 PM Changeset in webkit [132438] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[cairo] unneeded FloatRect object creation in BitmapImage::draw
https://bugs.webkit.org/show_bug.cgi?id=100298

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-10-24
Reviewed by Martin Robinson.

Do not copy FloatRect arguments src and dst to local variables.
Instead, use src and dst directly.

No new tests. No change in behavior.

  • platform/graphics/cairo/BitmapImageCairo.cpp:

(WebCore::BitmapImage::draw):

6:02 PM Changeset in webkit [132437] by Lucas Forschler
  • 4 edits in trunk/Source

Versioning.

5:50 PM Changeset in webkit [132436] by Simon Fraser
  • 1 edit
    4 adds in trunk/LayoutTests

Add two more tiled scrolling tests
https://bugs.webkit.org/show_bug.cgi?id=100314

Reviewed by Beth Dakin.

Two new tests for TileCache tile coverage after scrolling.

  • platform/mac/tiled-drawing/tile-coverage-after-scroll-expected.txt: Added.
  • platform/mac/tiled-drawing/tile-coverage-after-scroll.html: Added.
  • platform/mac/tiled-drawing/tile-coverage-scroll-to-bottom-expected.txt: Added.
  • platform/mac/tiled-drawing/tile-coverage-scroll-to-bottom.html: Added.
5:49 PM Changeset in webkit [132435] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[SOUP] Provide logging for SocketStreamHandleSoup
https://bugs.webkit.org/show_bug.cgi?id=100215

Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-10-24
Reviewed by Alexey Proskuryakov.

Add logging to SocketStreamHandleSoup to facilitate debugging.

  • platform/network/soup/SocketStreamHandleSoup.cpp:

(WebCore::SocketStreamHandle::SocketStreamHandle):
(WebCore::SocketStreamHandle::~SocketStreamHandle):
(WebCore::SocketStreamHandle::platformSend):
(WebCore::SocketStreamHandle::platformClose):

5:47 PM Changeset in webkit [132434] by Beth Dakin
  • 2 edits in trunk/LayoutTests

Updated results for https://bugs.webkit.org/show_bug.cgi?id=100312
I checked in results that relied on some local changes in WK2.

  • platform/mac/tiled-drawing/tile-coverage-slow-scrolling-expected.txt:
5:42 PM Changeset in webkit [132433] by thakis@chromium.org
  • 6 edits in trunk/Source/WebCore

Pass on exif orientation from ImageSource when using the open-source image decoders
https://bugs.webkit.org/show_bug.cgi?id=100164

Reviewed by Eric Seidel.

The orientation is honored always for image documents, and optionally
for <img> elements if shouldRespectImageOrientation is set (off by
default). However, the feature needs port-specific modifications to
GraphicsContext (without this, webcore will use the rotated bounds but
draw the image as if it hadn't be rotated, resulting in squished
pixels), and most ports don't implement these yet -- so put
turning this on for image documents behind a port-specific #ifdef.

No observable behavior change. Once it's hooked up, it will be tested
by fast/images/exif-orientation.html.

  • platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::size):
(WebCore::ImageSource::frameSizeAtIndex):
(WebCore::ImageSource::orientationAtIndex):

  • platform/graphics/chromium/DeferredImageDecoder.cpp:

(WebCore::DeferredImageDecoder::orientation):
(WebCore):

  • platform/graphics/chromium/DeferredImageDecoder.h:

(DeferredImageDecoder):

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::readImageOrientation):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::shouldRespectImageOrientation):

5:36 PM Changeset in webkit [132432] by Simon Fraser
  • 3 edits in trunk/LayoutTests

Skip tiled drawing tests for WK1
https://bugs.webkit.org/show_bug.cgi?id=100312

Reviewed by Beth Dakin.

Skip platform/mac/tiled-drawing tests in the main TestExpections file,
but re-enable it in the WK2 TestExpections file.

  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
5:33 PM Changeset in webkit [132431] by dpranke@chromium.org
  • 3 edits
    2 copies
    2 adds in trunk/LayoutTests

Unreviewed, update chromium-mac-mountainlion baselines.

  • platform/chromium-mac-lion/media/track/track-cue-rendering-horizontal-expected.png: Copied from LayoutTests/platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.png.
  • platform/chromium-mac-lion/media/track/track-cue-rendering-horizontal-expected.txt: Copied from LayoutTests/platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.txt.
  • platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.png:
  • platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.txt:
5:25 PM Changeset in webkit [132430] by Lucas Forschler
  • 1 copy in tags/Safari-537.16

New Tag.

5:24 PM Changeset in webkit [132429] by dpranke@chromium.org
  • 2 edits
    3 deletes in trunk/LayoutTests

Unreviewed, expectations and baseline cleanup.

Remove some old baselines for a test that was converted to a reftest,
and remove entries for tests no longer failing on Chromium Mac ML.

  • platform/chromium-mac-lion/fast/forms/date/date-reset-value-expected.png: Removed.
  • platform/chromium-mac-mountainlion/TestExpectations:
  • platform/chromium-mac-snowleopard/fast/forms/date/date-reset-value-expected.png: Removed.
  • platform/chromium-mac/fast/forms/date/date-reset-value-expected.png: Removed.
5:24 PM Changeset in webkit [132428] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

DFG compileBlahBlahByVal methods for Contiguous and ArrayStorage have only one caller and should be removed
https://bugs.webkit.org/show_bug.cgi?id=100311

Reviewed by Mark Hahnenberg.

Just trying to simplify things before I make them more complicated again.

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::temporaryRegisterForPutByVal):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(DFG):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(DFG):
(JSC::DFG::SpeculativeJIT::compile):

5:19 PM Changeset in webkit [132427] by Beth Dakin
  • 5 edits
    2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=100169
We should make TileCache tiles the size of the tile coverage rect
when we can't do fast scrolling
-and-
<rdar://problem/12505021>

Reviewed by Simon Fraser.

Source/WebCore:

Some websites that don't do fast scrolling still scroll slower than
they do with tiled drawing disabled.
https://bugs.webkit.org/show_bug.cgi?id=99768 addressed some of this
performance problem, but there is still more ground to make up. This
patch addresses the remaining issue by making tiles the size of the
window when we can't do fast scrolling.

The constructor and create function no longer take a size parameter.
That's all fully controlled within TileCache now. m_tileSize is no
longer const.

  • platform/graphics/ca/mac/TileCache.h:

Store the current default size as constants so that we can access it
in both the constructor and adjustTileSizeForCoverageRect().

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::TileCache):

This new function will set m_tileSize to the size of the tile
coverage rect if the tile coverage is limited to the visible area.
Otherwise, the tiles are set to be the default size.
(WebCore::TileCache::adjustTileSizeForCoverageRect):

Call adjustTileSizeForCoverageRect().
(WebCore::TileCache::revalidateTiles):

No need to send in a size anymore.

  • platform/graphics/ca/mac/WebTileCacheLayer.h:

(WebCore):

LayoutTests:

New test.

  • platform/mac/tiled-drawing/tile-coverage-slow-scrolling-expected.txt: Added.
  • platform/mac/tiled-drawing/tile-coverage-slow-scrolling.html: Added.
4:59 PM Changeset in webkit [132426] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

Make it a compile error to send a sync message as async (and vice versa)
https://bugs.webkit.org/show_bug.cgi?id=100285

Reviewed by Sam Weinig.

Add an "isSync" boolean to each generated message struct and add compile asserts to the message senders.

  • Platform/CoreIPC/Connection.h:

(CoreIPC::Connection::send):
(CoreIPC::Connection::sendSync):

  • Platform/CoreIPC/MessageSender.h:

(CoreIPC::MessageSender::send):
(CoreIPC::MessageSender::sendSync):

  • Scripts/webkit2/messages.py:

(message_to_struct_declaration):

  • Scripts/webkit2/messages_unittest.py:
  • UIProcess/WebProcessProxy.h:

(WebKit::WebProcessProxy::send):
(WebKit::WebProcessProxy::sendSync):

4:55 PM Changeset in webkit [132425] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

Disable auto termination of WebKit2 processes on mac
https://bugs.webkit.org/show_bug.cgi?id=100176

Patch by Kiran Muppala <cmuppala@apple.com> on 2012-10-24
Reviewed by Alexey Proskuryakov.

Disable WebKit2 auto termination by taking corresponding assertion
until UI process is enhanced to determine when it is safe to enable it.

  • NetworkProcess/mac/NetworkProcessMainMac.mm:

(WebKit::NetworkProcessMain):

  • PluginProcess/mac/PluginProcessMainMac.mm:

(WebKit::PluginProcessMain):

  • SharedWorkerProcess/mac/SharedWorkerProcessMainMac.mm:

(WebKit::SharedWorkerProcessMain):

  • WebProcess/mac/WebProcessInitialization.mm:

(WebKit::InitializeWebProcess):

4:49 PM Changeset in webkit [132424] by Dave Barton
  • 4 edits in trunk

MathML tests trigger font cache assertions in debug bots
https://bugs.webkit.org/show_bug.cgi?id=100268

Reviewed by Eric Seidel.

Source/WebCore:

Add a FontCachePurgePreventer to fix this.

Tested by existing tests.

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::updateFromElement):

LayoutTests:

  • platform/chromium/TestExpectations:
4:46 PM Changeset in webkit [132423] by dpranke@chromium.org
  • 6 edits in trunk/Tools

nrwt: truncate meter lines properly on windows
https://bugs.webkit.org/show_bug.cgi?id=100062

Reviewed by Tony Chang.

This change adds the code to figure out the terminal width
on windows (it was already there for Unixen) and moves it
to a platform-specific object.

  • Scripts/webkitpy/common/system/platforminfo.py:

(PlatformInfo.terminal_width):

  • Scripts/webkitpy/common/system/platforminfo_mock.py:

(MockPlatformInfo.total_bytes_memory):
(MockPlatformInfo):
(MockPlatformInfo.terminal_width):

  • Scripts/webkitpy/layout_tests/views/metered_stream.py:

(MeteredStream.init):
(MeteredStream.number_of_columns):
(MeteredStream.flush):

  • Scripts/webkitpy/layout_tests/views/printing.py:

(Printer.init):
(Printer._test_status_line):

4:40 PM Changeset in webkit [132422] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Update main frame scroll position immediately for programmatic scrolls
https://bugs.webkit.org/show_bug.cgi?id=98074

Reviewed by Simon Fraser.

Immediately update the main frame scroll position after a programmatic scroll,
so that performing a scrollBy or scrollTo will be instantly reflected in
all of the scroll offset accessors.

No new tests; this will be tested by many scrolling tests once WebKitTestRunner
can use threaded scrolling.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::requestScrollPositionUpdate):

4:26 PM Changeset in webkit [132421] by mihaip@chromium.org
  • 8 edits in trunk/Source

[Chromium] Allow pushState and related history APIs to be disabled per context
https://bugs.webkit.org/show_bug.cgi?id=99780

Reviewed by Adam Barth.

Source/WebCore:

Chrome Apps do not support the history API (or navigation in general).
Since pushState is generally feature detected, it's cleanest to disable
it via a V8 per-context feature, so that applications can have the
appropriate fallback behavior (other history APIs are re-mapped to throw
exceptions, since history.back() and the link are not feature detected).

  • dom/ContextFeatures.cpp:

(WebCore::ContextFeatures::pushStateEnabled):
(WebCore):

  • dom/ContextFeatures.h:
  • dom/Document.cpp:

(WebCore::Document::enqueuePopstateEvent):

  • page/History.idl:

Source/WebKit/chromium:

Add pushState context feature.

  • public/WebPermissionClient.h:

(WebPermissionClient):
(WebKit::WebPermissionClient::allowPushState):

  • src/ContextFeaturesClientImpl.cpp:

(WebKit::ContextFeaturesClientImpl::askIfIsEnabled):

4:24 PM Changeset in webkit [132420] by tommyw@google.com
  • 4 edits
    2 adds in trunk

Source/WebCore: MediaStream API: Make sure all events are dispatched asynchronously
https://bugs.webkit.org/show_bug.cgi?id=100286

Reviewed by Adam Barth.

This is necessary to safeguard against if the UA uses synchronous UA->WebKit calls,
and the web application calls methods on the RTCPeerConnection in the event callbacks.

Test: fast/mediastream/RTCPeerConnection-events.html
Also tested by the chromium webrtc fuzz tests.

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::negotiationNeeded):
(WebCore::RTCPeerConnection::didGenerateIceCandidate):
(WebCore::RTCPeerConnection::didAddRemoteStream):
(WebCore::RTCPeerConnection::didRemoveRemoteStream):
(WebCore::RTCPeerConnection::didAddRemoteDataChannel):
(WebCore::RTCPeerConnection::changeReadyState):
(WebCore::RTCPeerConnection::changeIceState):
(WebCore):
(WebCore::RTCPeerConnection::scheduleDispatchEvent):
(WebCore::RTCPeerConnection::scheduledEventTimerFired):

  • Modules/mediastream/RTCPeerConnection.h:

(RTCPeerConnection):

LayoutTests: MediaStream API: Make sure all RTCPeerConnection events are dispatched asynchronously
https://bugs.webkit.org/show_bug.cgi?id=100286

Reviewed by Adam Barth.

RTCPeerConnection::close is the only function that dispatches an event directly so only test that.

  • fast/mediastream/RTCPeerConnection-events-expected.txt: Added.
  • fast/mediastream/RTCPeerConnection-events.html: Added.
4:19 PM Changeset in webkit [132419] by pilgrim@chromium.org
  • 13 edits
    2 copies in trunk/Source

[Chromium] Remove screen-related functions from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=97474

Reviewed by Adam Barth.

Screen-related functions like screenHorizontalDPI that
used to be on PlatformSupport are now accessed through a new
PlatformPageClient attached to Widget in WebCore-land, which is
implemented by ChromeClientImpl in WebKit-land, which proxies
calls to WebWidgetClient, which is actually implemented in
Chromium-land.

Source/Platform:

  • Platform.gypi:
  • chromium/public/WebScreenInfo.h: Added.

(WebKit):
(WebScreenInfo):
(WebKit::WebScreenInfo::WebScreenInfo):

Source/WebCore:

  • WebCore.gypi:
  • platform/Widget.h:
  • platform/chromium/PageClientChromium.h: Copied from Source/WebCore/platform/chromium/PlatformWidget.h.

(PageClientChromium):

  • platform/chromium/PlatformScreenChromium.cpp:

(WebCore::toPlatformPageClient):
(WebCore):
(WebCore::screenHorizontalDPI):
(WebCore::screenVerticalDPI):
(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
(WebCore::screenIsMonochrome):
(WebCore::screenRect):
(WebCore::screenAvailableRect):

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

Source/WebKit/chromium:

  • public/WebScreenInfo.h:
  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::screenInfo):
(WebKit):

  • src/ChromeClientImpl.h:

(WebKit):
(WebKit::ChromeClientImpl::platformPageClient):
(ChromeClientImpl):

  • src/PlatformSupport.cpp:

(WebCore):

  • src/WebPagePopupImpl.cpp:
4:18 PM Changeset in webkit [132418] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Chromium revision 163873 also made
platform/chromium/virtual/gpu/fast/canvas/canvas-incremental-repaint.html slow.

  • platform/chromium/TestExpectations:
4:17 PM Changeset in webkit [132417] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

[V8] WorkerContextExecutionProxy doesn't need to track events
https://bugs.webkit.org/show_bug.cgi?id=100295

Reviewed by Eric Seidel.

This code was added when this code was originally upstreamed as part of
the Chromium port. There doesn't appear to be any reason why
WorkerContextExecutionProxy needs to keep a Vector of raw event
pointers. Those points are likely to become dangling, making the rest
of what this code does very sketchy.

  • bindings/v8/V8WorkerContextEventListener.cpp:

(WebCore::V8WorkerContextEventListener::callListenerFunction):

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::dispose):

  • bindings/v8/WorkerContextExecutionProxy.h:

(WebCore::WorkerContextExecutionState::WorkerContextExecutionState):
(WorkerContextExecutionProxy):

4:01 PM Changeset in webkit [132416] by commit-queue@webkit.org
  • 6 edits
    4 adds in trunk

[CSS Shaders] The mesh should be specified using <column, row> order
https://bugs.webkit.org/show_bug.cgi?id=96285

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-10-24
Reviewed by Dean Jackson.

Source/WebCore:

Change StyleResolver and CSSComputedStyleDeclaration to handle the mesh parameters in
column, row order.

Test: css3/filters/custom/custom-filter-mesh-column-row-order.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::valueForFilter):

Append the number of columns before the number of rows in the meshParameters
CSSValueList.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::createCustomFilterOperation):

Store the second mesh parameter in meshRows instead of meshColumns.

LayoutTests:

Add a test verifying that WebKit interprets the CSS mesh values in column, row order.
Update existing tests for u_meshSize and u_tileSize to expect column, row order.

  • css3/filters/custom/custom-filter-mesh-column-row-order-expected.html: Added.
  • css3/filters/custom/custom-filter-mesh-column-row-order.html: Added.
  • css3/filters/resources/checkerboard.vs: Added.
  • css3/filters/resources/u-mesh-size.fs:
  • css3/filters/resources/u-tile-size.fs:
  • css3/filters/resources/varying-mix-color.fs: Added.
4:00 PM Changeset in webkit [132415] by dpranke@chromium.org
  • 2 edits in trunk/Tools

tweak debug logging in webkit-patch optimize-baselines
https://bugs.webkit.org/show_bug.cgi?id=100294

Reviewed by Ojan Vafai.

This changes the logging to print out the baselines found
(and their checksums) even when we don't do anything.

  • Scripts/webkitpy/common/checkout/baselineoptimizer.py:

(BaselineOptimizer.optimize):

3:49 PM Changeset in webkit [132414] by commit-queue@webkit.org
  • 2 edits in trunk

[BlackBerry] change CMAKE_<CCXX|C>_FLAGS_<RELEASE|DEBUG> from enviroment flags
https://bugs.webkit.org/show_bug.cgi?id=100256

Patch by Michael Carmody <mcarmody@rim.com> on 2012-10-24
Reviewed by Rob Buis.

This allow override of compile flags without having to edit CMake files.

  • Source/cmake/OptionsBlackBerry.cmake:
3:45 PM Changeset in webkit [132413] by tony@chromium.org
  • 2 edits
    1 move
    1 add in trunk/LayoutTests

[chromium] Unreviewed, land pixel results on Win/Mac for a new repaint test.

  • platform/chromium-mac/css3/flexbox/repaint-during-resize-no-flex-expected.png: Added.
  • platform/chromium-win/css3/flexbox/repaint-during-resize-no-flex-expected.png: Renamed from LayoutTests/platform/chromium-linux/css3/flexbox/repaint-during-resize-no-flex-expected.png.
  • platform/chromium/TestExpectations:
3:40 PM Changeset in webkit [132412] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

loaderRunLoop() should use synchronization instead of while loop
https://bugs.webkit.org/show_bug.cgi?id=55402

Patch by Jae Hyun Park <jae.park@company100.net> on 2012-10-24
Reviewed by Alexey Proskuryakov.

Originally, loaderRunLoop() sleeps until a thread has started and set
the loaderRunLoopObject static variable. This patch uses
ThreadCondition to synchronize instead of a while loop.

No new tests (No behavior change).

  • platform/network/cf/LoaderRunLoopCF.cpp:

(WebCore::runLoaderThread):
(WebCore::loaderRunLoop):

  • platform/network/cf/LoaderRunLoopCF.h:

(WebCore):

3:36 PM Changeset in webkit [132411] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

Incorrect keycodes for numpad /, -, +, .
https://bugs.webkit.org/show_bug.cgi?id=99188

Patch by Sailesh Agrawal <sail@chromium.org> on 2012-10-24
Reviewed by Tony Chang.

Source/WebCore:

In r57951 we switched to mapping keys by character code.
This regressed the numpad keys which no longer match the Windows virtual key codes.
This CL fixes this by never mapping numpad keys by character code.

Test: platform/mac/fast/events/numpad-keycode-mapping.html

  • platform/mac/PlatformEventFactoryMac.mm:

(WebCore::windowsKeyCodeForKeyEvent):

Source/WebKit/chromium:

In r57951 we switched to mapping keys by character code.
This regressed the numpad keys which no longer match the Windows virtual key codes.
This CL fixes this by never mapping numpad keys by character code.

  • src/mac/WebInputEventFactory.mm: Disallow mapping numpad keys by character code.

(WebKit::windowsKeyCodeForKeyEvent):

  • tests/WebInputEventFactoryTestMac.mm: Test to verify that all numpad keys are correctly mapped.

(TEST):

Tools:

Add key mappings for all numpad keys.

  • DumpRenderTree/mac/EventSendingController.mm:

(KeyMappingEntry):
(-[EventSendingController keyDown:withModifiers:withLocation:]): Added all numpad keys.

LayoutTests:

Added test to map numpad keys to windows virtual keycodes. This test is for the Mac port only. DumpRenderTree in the chromium-mac port doesn't use Mac keycodes so this can't be tested on that platform.

  • platform/mac/fast/events/numpad-keycode-mapping-expected.txt: Added.
  • platform/mac/fast/events/numpad-keycode-mapping.html: Added.
3:04 PM Changeset in webkit [132410] by dpranke@chromium.org
  • 7 edits in trunk/Tools

webkitpy: clean up references to Skipped files
https://bugs.webkit.org/show_bug.cgi?id=100045

Reviewed by Ojan Vafai.

Since they are no longer used or needed ...

  • Scripts/webkitpy/layout_tests/port/apple.py:

(ApplePort._generate_all_test_configurations):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.skipped_layout_tests):
(Port.expectations_files):
(Port._wk2_port_name):

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort):

  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:

(MacTest.test_default_timeout_ms):

  • Scripts/webkitpy/layout_tests/port/port_testcase.py:

(test_expectations_files):
(test_expectations_files.platform_dirs):

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort.init):

3:01 PM Changeset in webkit [132409] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Null-check the RenderView in ocument::windowScreenDidChange to fix a crash when saving PDFs
https://bugs.webkit.org/show_bug.cgi?id=100141
<rdar://problem/12559147>

Reviewed by Tim Horton.

For PDF documents the RenderView is null, so null-check it to avoid a crash
when saving PDFs.

  • dom/Document.cpp:

(WebCore::Document::windowScreenDidChange):

3:00 PM Changeset in webkit [132408] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Marking the software compositing version of
compositing/tiling/backface-preserve-3d-tiled.html as failing as well.

  • platform/chromium/TestExpectations:
2:58 PM Changeset in webkit [132407] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Marking 2 more mathml tests as flaky crashers on debug.

  • platform/chromium/TestExpectations:
2:54 PM Changeset in webkit [132406] by tdanderson@chromium.org
  • 6 edits
    2 adds in trunk

Handle two-finger tap gestures in the same way as long-press gestures
https://bugs.webkit.org/show_bug.cgi?id=99947

Reviewed by Adam Barth.

Source/WebCore:

Currently a long-press gesture is used to dispatch a context menu (for platforms
defining CONTEXT_MENUS) or to select text (for Android). Additionally, for platforms
defining TOUCH_ADJUSTMENT, gesture target fuzzing is performed on the location and
touch area of the long-press gesture.

This CL will cause two-finger tap gestures to be handled in the same way as long-press
gestures. The location and touch area of a two-finger tap gesture will correspond to
the location and touch area of the first finger down; the location/area of the second
finger will be ignored.

Test: touchadjustment/touch-links-two-finger-tap.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureLongPress):
(WebCore):
(WebCore::EventHandler::handleGestureForTextSelectionOrContextMenu):
(WebCore::EventHandler::handleGestureTwoFingerTap):
(WebCore::EventHandler::adjustGesturePosition):

  • page/EventHandler.h:

(EventHandler):

Source/WebKit/chromium:

Set the area of a two-finger tap gesture to be the area of the enclosing
rectangle for the first finger down.

  • src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

LayoutTests:

New layout test for dispatching context menus on a two-finger tap
gesture when touch adjustment is enabled.

  • touchadjustment/touch-links-two-finger-tap-expected.txt: Added.
  • touchadjustment/touch-links-two-finger-tap.html: Added.
2:51 PM Changeset in webkit [132405] by commit-queue@webkit.org
  • 30 edits in trunk/Source/WebKit2

[EFL][WK2] Get rid of Ewk_View private C API (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=100230

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-24
Reviewed by Kenneth Rohde Christiansen.

Remove part of the Ewk_View private C API and replace
it by C++ methods in EwkViewImpl class. Eventually,
all the private C functions will be removed but it
will be done in several patches.

  • UIProcess/API/C/efl/WKView.cpp:

(WKViewGetPage):

  • UIProcess/API/efl/EwkViewImpl.cpp:

(_ewk_view_commit):
(_ewk_view_preedit_changed):
(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::smartData):
(EwkViewImpl::fromEvasObject):
(EwkViewImpl::wkPage):
(EwkViewImpl::setCursor):
(EwkViewImpl::redrawRegion):
(EwkViewImpl::informDownloadJobCancelled):
(EwkViewImpl::informDownloadJobFailed):
(EwkViewImpl::informDownloadJobFinished):
(EwkViewImpl::informDownloadJobRequested):
(EwkViewImpl::informNewFormSubmissionRequest):
(EwkViewImpl::enterFullScreen):
(EwkViewImpl::exitFullScreen):
(EwkViewImpl::setImageData):
(EwkViewImpl::informLoadError):
(EwkViewImpl::informLoadFinished):
(EwkViewImpl::informLoadProgress):
(EwkViewImpl::informProvisionalLoadFailed):
(EwkViewImpl::informLoadCommitted):
(EwkViewImpl::informProvisionalLoadRedirect):
(EwkViewImpl::informProvisionalLoadStarted):
(EwkViewImpl::informNavigationPolicyDecision):
(EwkViewImpl::informNewWindowPolicyDecision):
(EwkViewImpl::informResourceLoadStarted):
(EwkViewImpl::informResourceLoadResponse):
(EwkViewImpl::informResourceLoadFailed):
(EwkViewImpl::informResourceLoadFinished):
(EwkViewImpl::informResourceRequestSent):
(EwkViewImpl::informTitleChange):
(EwkViewImpl::informTooltipTextChange):
(EwkViewImpl::informTextFound):
(EwkViewImpl::size):
(EwkViewImpl::informIconChange):
(EwkViewImpl::informIntentRequest):
(EwkViewImpl::informIntentServiceRegistration):
(EwkViewImpl::createGLSurface):
(EwkViewImpl::enterAcceleratedCompositingMode):
(EwkViewImpl::exitAcceleratedCompositingMode):
(EwkViewImpl::requestColorPicker):
(EwkViewImpl::dismissColorPicker):
(EwkViewImpl::informBackForwardListChange):

  • UIProcess/API/efl/EwkViewImpl.h:

(WebCore):
(EwkViewImpl):
(EwkViewImpl::view):
(EwkViewImpl::page):

  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::PageClientImpl):
(WebKit::PageClientImpl::viewImpl):
(WebKit):
(WebKit::PageClientImpl::createDrawingAreaProxy):
(WebKit::PageClientImpl::setViewNeedsDisplay):
(WebKit::PageClientImpl::viewSize):
(WebKit::PageClientImpl::isViewFocused):
(WebKit::PageClientImpl::isViewVisible):
(WebKit::PageClientImpl::processDidCrash):
(WebKit::PageClientImpl::didRelaunchProcess):
(WebKit::PageClientImpl::toolTipChanged):
(WebKit::PageClientImpl::setCursor):
(WebKit::PageClientImpl::createPopupMenuProxy):
(WebKit::PageClientImpl::enterAcceleratedCompositingMode):
(WebKit::PageClientImpl::exitAcceleratedCompositingMode):
(WebKit::PageClientImpl::updateTextInputState):
(WebKit::PageClientImpl::handleDownloadRequest):
(WebKit::PageClientImpl::didChangeContentsSize):

  • UIProcess/API/efl/PageClientImpl.h:

(WebKit::PageClientImpl::create):
(PageClientImpl):

  • UIProcess/API/efl/PageViewportControllerClientEfl.cpp:

(WebKit::PageViewportControllerClientEfl::PageViewportControllerClientEfl):
(WebKit::PageViewportControllerClientEfl::drawingArea):
(WebKit::PageViewportControllerClientEfl::updateViewportSize):
(WebKit::PageViewportControllerClientEfl::didChangeContentsSize):
(WebKit::PageViewportControllerClientEfl::didChangeVisibleContents):

  • UIProcess/API/efl/PageViewportControllerClientEfl.h:

(WebKit::PageViewportControllerClientEfl::create):
(PageViewportControllerClientEfl):

  • UIProcess/API/efl/ewk_download_job.cpp:

(Ewk_Download_Job::Ewk_Download_Job):
(Ewk_Download_Job::viewImpl):

  • UIProcess/API/efl/ewk_download_job_private.h:

(Ewk_Download_Job::create):
(Ewk_Download_Job):

  • UIProcess/API/efl/ewk_view.cpp:

(pageViewMap):
(addToPageViewMap):
(removeFromPageViewMap):
(_ewk_view_on_favicon_changed):
(_ewk_view_smart_focus_in):
(_ewk_view_smart_focus_out):
(mapToWebContent):
(_ewk_view_smart_mouse_wheel):
(_ewk_view_smart_mouse_down):
(_ewk_view_smart_mouse_up):
(_ewk_view_smart_mouse_move):
(_ewk_view_smart_key_down):
(_ewk_view_smart_key_up):
(_ewk_view_on_show):
(_ewk_view_on_hide):
(_ewk_view_impl_del):
(_ewk_view_smart_del):
(_ewk_view_smart_calculate):
(_ewk_view_smart_color_set):
(_ewk_view_initialize):
(_ewk_view_add_with_smart):
(ewk_view_context_get):
(ewk_view_url_update):
(ewk_view_url_set):
(ewk_view_url_get):
(ewk_view_icon_url_get):
(ewk_view_reload):
(ewk_view_reload_bypass_cache):
(ewk_view_stop):
(ewk_view_settings_get):
(ewk_view_title_get):
(ewk_view_text_input_state_update):
(ewk_view_load_progress_get):
(ewk_view_scale_set):
(ewk_view_scale_get):
(ewk_view_device_pixel_ratio_set):
(ewk_view_device_pixel_ratio_get):
(ewk_view_theme_set):
(ewk_view_theme_get):
(ewk_view_back):
(ewk_view_forward):
(ewk_view_intent_deliver):
(ewk_view_back_possible):
(ewk_view_forward_possible):
(ewk_view_back_forward_list_get):
(ewk_view_html_string_load):
(ewk_view_setting_encoding_custom_get):
(ewk_view_setting_encoding_custom_set):
(ewk_view_page_create):
(ewk_view_text_find):
(ewk_view_text_find_highlight_clear):
(ewk_view_text_matches_count):
(ewk_view_contents_size_changed):
(ewk_view_popup_menu_request):
(ewk_view_popup_menu_close):
(ewk_view_popup_menu_select):
(ewk_view_mouse_events_enabled_set):
(ewk_view_mouse_events_enabled_get):
(ewk_view_webprocess_crashed):
(ewk_view_color_picker_color_set):
(ewk_view_feed_touch_event):
(ewk_view_touch_events_enabled_set):
(ewk_view_touch_events_enabled_get):
(ewk_view_inspector_show):
(ewk_view_inspector_close):

  • UIProcess/API/efl/ewk_view_private.h:
  • UIProcess/cairo/BackingStoreCairo.cpp:

(WebKit::BackingStore::incorporateUpdate):

  • UIProcess/efl/DownloadManagerEfl.cpp:

(WebKit::DownloadManagerEfl::decideDestinationWithSuggestedFilename):
(WebKit::DownloadManagerEfl::didFail):
(WebKit::DownloadManagerEfl::didCancel):
(WebKit::DownloadManagerEfl::didFinish):
(WebKit::DownloadManagerEfl::registerDownload):

  • UIProcess/efl/DownloadManagerEfl.h:

(DownloadManagerEfl):

  • UIProcess/efl/FindClientEfl.cpp:

(WebKit::FindClientEfl::didFindString):
(WebKit::FindClientEfl::didFailToFindString):
(WebKit::FindClientEfl::FindClientEfl):

  • UIProcess/efl/FindClientEfl.h:

(WebKit::FindClientEfl::create):
(FindClientEfl):

  • UIProcess/efl/FormClientEfl.cpp:

(WebKit::FormClientEfl::willSubmitForm):
(WebKit::FormClientEfl::FormClientEfl):

  • UIProcess/efl/FormClientEfl.h:

(WebKit::FormClientEfl::create):
(FormClientEfl):

  • UIProcess/efl/PageLoadClientEfl.cpp:

(WebKit::PageLoadClientEfl::didReceiveTitleForFrame):
(WebKit::PageLoadClientEfl::didReceiveIntentForFrame):
(WebKit::PageLoadClientEfl::registerIntentServiceForFrame):
(WebKit::PageLoadClientEfl::didChangeProgress):
(WebKit::PageLoadClientEfl::didFinishLoadForFrame):
(WebKit::PageLoadClientEfl::didFailLoadWithErrorForFrame):
(WebKit::PageLoadClientEfl::didStartProvisionalLoadForFrame):
(WebKit::PageLoadClientEfl::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::PageLoadClientEfl::didFailProvisionalLoadWithErrorForFrame):
(WebKit::PageLoadClientEfl::didCommitLoadForFrame):
(WebKit::PageLoadClientEfl::didChangeBackForwardList):
(WebKit::PageLoadClientEfl::didSameDocumentNavigationForFrame):
(WebKit::PageLoadClientEfl::PageLoadClientEfl):

  • UIProcess/efl/PageLoadClientEfl.h:

(WebKit::PageLoadClientEfl::create):
(PageLoadClientEfl):
(WebKit::PageLoadClientEfl::viewImpl):

  • UIProcess/efl/PagePolicyClientEfl.cpp:

(WebKit::PagePolicyClientEfl::decidePolicyForNavigationAction):
(WebKit::PagePolicyClientEfl::decidePolicyForNewWindowAction):
(WebKit::PagePolicyClientEfl::PagePolicyClientEfl):

  • UIProcess/efl/PagePolicyClientEfl.h:

(WebKit::PagePolicyClientEfl::create):
(PagePolicyClientEfl):

  • UIProcess/efl/PageUIClientEfl.cpp:

(WebKit::PageUIClientEfl::closePage):
(WebKit::PageUIClientEfl::createNewPage):
(WebKit::PageUIClientEfl::runJavaScriptAlert):
(WebKit::PageUIClientEfl::runJavaScriptConfirm):
(WebKit::PageUIClientEfl::runJavaScriptPrompt):
(WebKit::PageUIClientEfl::showColorPicker):
(WebKit::PageUIClientEfl::hideColorPicker):
(WebKit::PageUIClientEfl::exceededDatabaseQuota):
(WebKit::PageUIClientEfl::focus):
(WebKit::PageUIClientEfl::unfocus):
(WebKit::PageUIClientEfl::takeFocus):
(WebKit::PageUIClientEfl::getWindowFrame):
(WebKit::PageUIClientEfl::setWindowFrame):
(WebKit::PageUIClientEfl::PageUIClientEfl):

  • UIProcess/efl/PageUIClientEfl.h:

(WebKit::PageUIClientEfl::create):
(PageUIClientEfl):

  • UIProcess/efl/ResourceLoadClientEfl.cpp:

(WebKit::ResourceLoadClientEfl::didInitiateLoadForResource):
(WebKit::ResourceLoadClientEfl::didSendRequestForResource):
(WebKit::ResourceLoadClientEfl::didReceiveResponseForResource):
(WebKit::ResourceLoadClientEfl::didFinishLoadForResource):
(WebKit::ResourceLoadClientEfl::didFailLoadForResource):
(WebKit::ResourceLoadClientEfl::ResourceLoadClientEfl):
(WebKit::ResourceLoadClientEfl::~ResourceLoadClientEfl):

  • UIProcess/efl/ResourceLoadClientEfl.h:

(WebKit::ResourceLoadClientEfl::create):
(ResourceLoadClientEfl):

  • UIProcess/efl/WebFullScreenManagerProxyEfl.cpp:

(WebKit::WebFullScreenManagerProxy::enterFullScreen):
(WebKit::WebFullScreenManagerProxy::exitFullScreen):

  • UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

  • UIProcess/efl/WebPageProxyEfl.cpp:

(WebKit::WebPageProxy::viewWidget):

2:48 PM Changeset in webkit [132404] by Chris Fleizach
  • 4 edits
    2 adds in trunk

AX:When aria-label is used, the text under an element is still appearing as the AXTitle
https://bugs.webkit.org/show_bug.cgi?id=98167

Reviewed by Beth Dakin.

Source/WebCore:

According to WAI-ARIA text computation, the presence of aria-label and alternative text
should override the visible text within an element.

Test: platform/mac/accessibility/aria-label-overrides-visible-text.html

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityTitle]):

LayoutTests:

  • platform/mac/accessibility/aria-label-overrides-visible-text-expected.txt: Added.
  • platform/mac/accessibility/aria-label-overrides-visible-text.html: Added.
  • platform/mac/accessibility/aria-labelledby-overrides-aria-label-expected.txt:
2:41 PM Changeset in webkit [132403] by commit-queue@webkit.org
  • 15 edits
    2 deletes in trunk

Unreviewed, rolling out r132303 and r132312.
http://trac.webkit.org/changeset/132303
http://trac.webkit.org/changeset/132312
https://bugs.webkit.org/show_bug.cgi?id=100287

Triggering crashes on many popular websites (Requested by
leviw|gardening on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-24

Source/WebCore:

  • css/CSSGrammar.y.in:
  • css/CSSParser.cpp:

(WebCore::CSSParser::detectAtToken):

  • css/CSSParser.h:
  • css/CSSPropertySourceData.h:
  • css/RuleSet.cpp:

(WebCore::RuleData::RuleData):
(WebCore::RuleSet::addRule):
(WebCore::RuleSet::addRegionRule):
(WebCore::RuleSet::addRulesFromSheet):
(WebCore::RuleSet::addStyleRule):

  • css/RuleSet.h:

(RuleData):
(RuleSet):

  • css/StyleResolver.cpp:

(WebCore::makeRuleSet):
(WebCore::StyleResolver::appendAuthorStyleSheets):
(WebCore::StyleResolver::matchScopedAuthorRules):
(WebCore::StyleResolver::locateSharedStyle):

  • css/StyleResolver.h:

(StyleResolver):

  • css/StyleRule.cpp:

(WebCore::StyleRuleBase::reportMemoryUsage):
(WebCore::StyleRuleBase::destroy):
(WebCore::StyleRuleBase::copy):
(WebCore::StyleRuleBase::createCSSOMWrapper):

  • css/StyleRule.h:
  • css/StyleScopeResolver.cpp:

(WebCore::StyleScopeResolver::reportMemoryUsage):

  • css/StyleScopeResolver.h:

(WebCore):
(StyleScopeResolver):

  • css/StyleSheetContents.cpp:

(WebCore::childRulesHaveFailedOrCanceledSubresources):

LayoutTests:

  • fast/dom/shadow/athost-atrules-expected.txt: Removed.
  • fast/dom/shadow/athost-atrules.html: Removed.
2:37 PM Changeset in webkit [132402] by timothy@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Fix a crash seen during the Inspector tests on the WebKit1 bots.

Reviewed by Filip Pizlo.

  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorFrontendClient::bringToFront): Use the window from the WebView since m_windowController's window
is not the same when the Inspector is docked.

2:36 PM Changeset in webkit [132401] by jsbell@chromium.org
  • 9 edits
    3 adds in trunk

IndexedDB: Cursor property value identities should be preserved
https://bugs.webkit.org/show_bug.cgi?id=100051

Reviewed by Tony Chang.

Source/WebCore:

Some W3C test submissions point out that subsequent accesses to cursor properties should
yield the same value until the cursor advances. We handled this with custom binding code for
IDBCursor.value but not IDBCursor.key or IDBCursor.primaryKey. The custom value code is
being removed in webkit.org/b/100034 in favor of returning ScriptValue and the same fix can
be applied to key/primaryKey.

Test: storage/indexeddb/cursor-properties.html

  • Modules/indexeddb/IDBCursor.cpp: Compute/store/serve up ScriptValues instead of IDBKeys

(WebCore::IDBCursor::key):
(WebCore::IDBCursor::primaryKey):
(WebCore::IDBCursor::setValueReady):

  • Modules/indexeddb/IDBCursor.h:

(IDBCursor):
(WebCore::IDBCursor::idbPrimaryKey): Expose this for callers that need access to the IDBKey

  • Modules/indexeddb/IDBCursor.idl:
  • Modules/indexeddb/IDBObjectStore.cpp: ... like this one.

(WebCore):

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::dispatchEvent): Pass along script context, for the conversion.

  • bindings/v8/IDBBindingUtilities.cpp:

(WebCore::idbKeyToScriptValue): New method for explicit conversion.
(WebCore):

  • bindings/v8/IDBBindingUtilities.h:

(WebCore):

LayoutTests:

Add tests to verify identity/read-only/mutability of cursor properties.

  • storage/indexeddb/cursor-properties-expected.txt: Added.
  • storage/indexeddb/cursor-properties.html: Added.
  • storage/indexeddb/resources/cursor-properties.js: Added.

(test.request.onsuccess):
(test):
(onUpgradeNeeded):
(onOpenSuccess.request.onsuccess):
(onOpenSuccess):
(checkProperty):

2:34 PM Changeset in webkit [132400] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Updating slow expectations for two tests following a Chromium
change. See https://bugs.webkit.org/show_bug.cgi?id=100287

  • platform/chromium/TestExpectations:
2:08 PM Changeset in webkit [132399] by ericu@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

https://bugs.webkit.org/show_bug.cgi?id=99202
[Chromium] shift-click fails to spawn new window with target=_blank

Reviewed by Adam Barth

No new tests in WebKit-land--see
https://codereview.chromium.org/11235048/ for tests that I'll submit
once this lands.

  • src/ChromeClientImpl.cpp:

Change currentEventShouldCauseBackgroundTab to updatePolicyForEvent; we
were looking up the right policy, then throwing it away if it wasn't
forcing a background tab.
(WebKit::ChromeClientImpl::updatePolicyForEvent):
(WebKit::ChromeClientImpl::getNavigationPolicy):

2:07 PM Changeset in webkit [132398] by fischman@chromium.org
  • 5 edits in trunk/Source/WebCore

call to setNeedsLayout during RenderVideo::paintReplaced
https://bugs.webkit.org/show_bug.cgi?id=100265

Reviewed by Eric Carlson.

Removed unnecessary call and added new defensive guards to catch erroneous setNeedsLayout() calls
during paints earlier (so the offending calls are in the emitted stacktrace).

No new tests - new defensive checks are triggered by existing tests.

  • page/FrameView.cpp:

(WebCore::FrameView::paintContents): forbid setNeedsLayout() during painting

  • rendering/RenderObject.cpp:

(WebCore):
(WebCore::RenderObject::SetLayoutNeededForbiddenScope::SetLayoutNeededForbiddenScope):
(WebCore::RenderObject::SetLayoutNeededForbiddenScope::~SetLayoutNeededForbiddenScope):

  • rendering/RenderObject.h:

(RenderObject):
(SetLayoutNeededForbiddenScope): added helper class for forbidding setNeedsLayout() in a scope.

  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::paintReplaced): drop the offending & unnecessary call to updatePlayer().

2:02 PM Changeset in webkit [132397] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

[V8] ActiveDOMObjectEpilogueVisitor is unnecessary and can be deleted
https://bugs.webkit.org/show_bug.cgi?id=100208

Reviewed by Eric Seidel.

Rather than clearing and re-establishing the weak callback for
ActiveDOMObjects during every GC, this patch puts all the
ActiveDOMObjects with pending activity into an object group with a live
object, causing them not to be garbage collected.

In addition to simplifying this code, this patch makes the patch in
https://bugs.webkit.org/show_bug.cgi?id=100175 much easier because
V8GCController no longer needs to know how to configure the weak
callbacks for these objects.

  • bindings/v8/V8GCController.cpp:

(WebCore::ActiveDOMObjectPrologueVisitor::ActiveDOMObjectPrologueVisitor):
(ActiveDOMObjectPrologueVisitor):
(WebCore::ActiveDOMObjectPrologueVisitor::visitDOMWrapper):
(WebCore::V8GCController::majorGCPrologue):
(WebCore::V8GCController::majorGCEpilogue):

  • bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::V8PerIsolateData):

  • bindings/v8/V8PerIsolateData.h:

(WebCore::V8PerIsolateData::liveRoot):
(V8PerIsolateData):

1:49 PM Changeset in webkit [132396] by beidson@apple.com
  • 26 edits
    1 add in trunk/Source

Add a strategy for loader customization.
https://bugs.webkit.org/show_bug.cgi?id=100278

Reviewed by Alexey Proskuryakov.

Source/WebCore:

It's empty for now and does nothing, just like the goggles.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/PlatformStrategies.h:

(WebCore::PlatformStrategies::loaderStrategy):
(PlatformStrategies):
(WebCore::PlatformStrategies::PlatformStrategies):

Source/WebKit/efl:

  • WebCoreSupport/PlatformStrategiesEfl.cpp:

(PlatformStrategiesEfl::createLoaderStrategy):

  • WebCoreSupport/PlatformStrategiesEfl.h:

(PlatformStrategiesEfl):

Source/WebKit/gtk:

  • WebCoreSupport/PlatformStrategiesGtk.cpp:

(PlatformStrategiesGtk::createLoaderStrategy):

  • WebCoreSupport/PlatformStrategiesGtk.h:

(PlatformStrategiesGtk):

Source/WebKit/mac:

  • WebCoreSupport/WebPlatformStrategies.h:

(WebPlatformStrategies):

  • WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::createLoaderStrategy):

Source/WebKit/qt:

  • WebCoreSupport/PlatformStrategiesQt.cpp:

(PlatformStrategiesQt::createLoaderStrategy):

  • WebCoreSupport/PlatformStrategiesQt.h:

(PlatformStrategiesQt):

Source/WebKit/win:

  • WebCoreSupport/WebPlatformStrategies.cpp:

(WebPlatformStrategies::createLoaderStrategy):

  • WebCoreSupport/WebPlatformStrategies.h:

(WebPlatformStrategies):

Source/WebKit/wince:

  • WebCoreSupport/PlatformStrategiesWinCE.cpp:

(PlatformStrategiesWinCE::createLoaderStrategy):

  • WebCoreSupport/PlatformStrategiesWinCE.h:

(PlatformStrategiesWinCE):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::createLoaderStrategy):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:

(WebPlatformStrategies):

1:46 PM Changeset in webkit [132395] by tony@chromium.org
  • 4 edits
    3 adds in trunk

Setting width of a flexitem causes the adjacent flex item to be displayed poorly.
https://bugs.webkit.org/show_bug.cgi?id=99925

Reviewed by Ojan Vafai.

Source/WebCore:

Make sure that we always repaint when moving a child. This is similar to what RenderDeprecatedFlexibleBox does.

Test: css3/flexbox/repaint-during-resize-no-flex.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::setFlowAwareLocationForChild): Move logic for repaining into the helper method
for setting the location of a child.
(WebCore::RenderFlexibleBox::layoutColumnReverse): Remove code for repaint since it's now in setFlowAwareLocationForChild.
(WebCore::RenderFlexibleBox::adjustAlignmentForChild): Remove code for repaint since it's now in setFlowAwareLocationForChild.

LayoutTests:

Add a repaint test. The render tree should be cross platform, but due to
slight color differences in the grey overlay, the png can't be shared.

  • css3/flexbox/repaint-during-resize-no-flex-expected.txt: Added.
  • css3/flexbox/repaint-during-resize-no-flex.html: Added.
  • platform/chromium-linux/css3/flexbox/repaint-during-resize-no-flex-expected.png: Added.
  • platform/chromium/TestExpectations:
1:36 PM Changeset in webkit [132394] by Simon Fraser
  • 4 edits
    3 adds in trunk

Fix CALayer hiearchy when combining tiling with preserve-3d
https://bugs.webkit.org/show_bug.cgi?id=100205

Reviewed by Dean Jackson.

Source/WebCore:

When an element has "transform-style: preserve-3d", its GraphicsLayerCA has a
m_structuralLayer which is a CATransformLayer. The primary CALayer which contains rendered
content becomes a sublayer of the CATransformLayer. If the element has backface-visibility:hidden,
it is the primary layer that is set to be single-sided.

In r131940 we started to use TileCaches in place of CATiledLayer. TileCaches work via
"customSublayers" returned from the PlatformCALayer, where the custom sublayer is
the tile cache container layer. However, the custom sublayers were being added as
children of the structural (CATransformLayer) layer, not of the primary (CALayer) layer,
thus they were not affected by the doubleSided property.

This change cleans up the confusing code in GraphicsLayerCA::updateSublayerList()
by maintaining two vectors of PlatformCALayers, one for sublayers of the structural
layer, and one for sublayers of the primary layer. It adds custom sublayers to
the latter list, so now the tile cache container layer becomes a sublayer of
the primary layer, so is affected by that layer's doubleSided property.

Test: compositing/tiling/backface-preserve-3d-tiled.html

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::updateSublayerList):

LayoutTests:

Pixel test that tests backface-visibility on a tile cache layer. Mark the test as
failing on Chromium.

  • compositing/tiling/backface-preserve-3d-tiled-expected.png: Added.
  • compositing/tiling/backface-preserve-3d-tiled-expected.txt: Added.
  • compositing/tiling/backface-preserve-3d-tiled.html: Added.
  • platform/chromium/TestExpectations:
1:33 PM Changeset in webkit [132393] by zmo@google.com
  • 6 edits in trunk/Source/WebCore

Update mozilla's CheckedInt.h to the latest version
https://bugs.webkit.org/show_bug.cgi?id=100177

Reviewed by Kenneth Russell.

  • html/canvas/CheckedInt.h: Sync with mozilla's copy with minumum modifications.

(detail):
(IsSupportedPass2):
(IsSupported):
(UnsignedType):
(IsSigned):
(TwiceBiggerType):
(PositionOfSignBit):
(MinValue):
(MaxValue):
(WebCore::detail::HasSignBit):
(WebCore::detail::BinaryComplement):
(WebCore::detail::IsInRange):
(WebCore::detail::IsAddValid):
(WebCore::detail::IsSubValid):
(WebCore::detail::IsMulValid):
(WebCore::detail::IsDivValid):
(WebCore::detail::OppositeIfSignedImpl::run):
(WebCore::detail::OppositeIfSigned):
(WebCore):
(CheckedInt):
(WebCore::CheckedInt::CheckedInt):
(WebCore::CheckedInt::value):
(WebCore::CheckedInt::isValid):
(WebCore::CheckedInt::operator -):
(WebCore::CheckedInt::operator ==):
(WebCore::CheckedInt::operator++):
(WebCore::CheckedInt::operator--):
(CastToCheckedIntImpl):
(WebCore::detail::CastToCheckedIntImpl::run):
(WebCore::castToCheckedInt):
(WebCore::operator ==):

  • html/canvas/DataView.cpp: change valid() to isValid().

(WebCore::DataView::create):

  • html/canvas/WebGLBuffer.cpp: Ditto.

(WebCore::WebGLBuffer::associateBufferDataImpl):
(WebCore::WebGLBuffer::associateBufferSubDataImpl):

  • html/canvas/WebGLRenderingContext.cpp: Ditto.

(WebCore):
(WebCore::WebGLRenderingContext::drawArrays):

  • platform/graphics/GraphicsContext3D.cpp: Ditto.

(WebCore::GraphicsContext3D::computeImageSizeInBytes):

1:33 PM Changeset in webkit [132392] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebKit2

Coordinated Graphics: Enable threaded/IPC animations
https://bugs.webkit.org/show_bug.cgi?id=93146

Reviewed by Caio Marcelo de Oliveira Filho.

In some cases there are pending changes in the layers, but no actual changes to the frame.
In that case we should unlock the animations.

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):

1:31 PM Changeset in webkit [132391] by zhajiang@rim.com
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry][Fullscreen] Roll out changes to fullscreen which rely on viewport size change [Part II]
https://bugs.webkit.org/show_bug.cgi?id=100259

Reviewed by Rob Buis.
Patch by Jacky Jiang <zhajiang@rim.com>.

PR: 219666
Revert "[BlackBerry] [FullScreen] entering/leaving fullscreen results in temporary glitches on the screen"
This rolls out r128772.
The patches relies on the viewport size change of the client side to
resume the screen and backing store updates. However, some client
sides don't need or wish to resize the WebKit viewport at all which
will result in upexpected screen and backing store suspensions.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):

  • Api/WebPage_p.h:

(WebPagePrivate):

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::enterFullScreenForElement):
(WebCore::ChromeClientBlackBerry::exitFullScreenForElement):

1:30 PM Changeset in webkit [132390] by zhajiang@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry][Fullscreen] Roll out changes to fullscreen which rely on viewport size change
https://bugs.webkit.org/show_bug.cgi?id=100259

Reviewed by Rob Buis.
Patch by Jacky Jiang <zhajiang@rim.com>.

PR: 219666
Roll out r130392 and r129909.
The patches rely on the viewport size change of the client side to
update the scale and scroll position of the video. However, some client
sides don't need or wish to resize the WebKit viewport at all.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
(BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
(BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):

  • Api/WebPage_p.h:

(WebPagePrivate):

1:20 PM Changeset in webkit [132389] by noam.rosenthal@nokia.com
  • 5 edits in trunk/Source

[Qt-on-Mac] GraphicsSurfaces should not create a global IOSurface handle
https://bugs.webkit.org/show_bug.cgi?id=89885

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Use mach_port instead of global tokens for IOSurfaces.
Global IOSurfaces are accessible from other processes using their handle, while mach_ports
can only be shared directly via IPC.

Tested by existing WebGL tests.

  • platform/graphics/surfaces/GraphicsSurfaceToken.h:

(GraphicsSurfaceToken):

  • platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:

(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):

Source/WebKit2:

Use mach_port instead of global tokens for IOSurfaces.
Global IOSurfaces are accessible from other processes, while mach_ports can only be shared
directly via IPC.

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

1:18 PM Changeset in webkit [132388] by commit-queue@webkit.org
  • 6 edits in trunk

image-set doesn't round-trip properly with cssText
https://bugs.webkit.org/show_bug.cgi?id=99725

Patch by Rick Byers <rbyers@chromium.org> on 2012-10-24
Reviewed by Beth Dakin.

Source/WebCore:

Fix serialization of -webkit-image-set rules to use the same format as
is used for parsing.

Test: fast/css/image-set-setting.html

  • css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::customCssText):

  • css/CSSValueList.h:

(WebCore::CSSValueList::item): Add const overload

LayoutTests:

Update image-set-setting test to expect the css text to round-trip properly.

  • fast/css/image-set-setting-expected.txt:
  • fast/css/script-tests/image-set-setting.js:

(testComputedStyle):
(testImageSetRule):

1:15 PM Changeset in webkit [132387] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

BlackBerry fix for webgl-depth-texture.html
https://bugs.webkit.org/show_bug.cgi?id=100258

Patch by Jonathan Feldstein <jfeldstein@rim.com> on 2012-10-24
Reviewed by Yong Li.

Removed a platform specific define that is unnecessary.

  • platform/graphics/GraphicsContext3D.cpp:

(WebCore::GraphicsContext3D::computeFormatAndTypeParameters):

12:31 PM Changeset in webkit [132386] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

Add per destination ID message receivers
https://bugs.webkit.org/show_bug.cgi?id=100276

Reviewed by Andreas Kling.

Extend MessageReceiverMap to handle adding message receivers for a given destinationID/receiver name pair.
Use this to make every WebPage object a message receiver.

  • Platform/CoreIPC/MessageReceiverMap.cpp:

(CoreIPC::MessageReceiverMap::addMessageReceiver):
(CoreIPC):
(CoreIPC::MessageReceiverMap::removeMessageReceiver):
(CoreIPC::MessageReceiverMap::invalidate):
(CoreIPC::MessageReceiverMap::dispatchMessage):
(CoreIPC::MessageReceiverMap::dispatchSyncMessage):

  • Platform/CoreIPC/MessageReceiverMap.h:

(MessageReceiverMap):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::~WebPage):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::addMessageReceiver):
(WebKit):
(WebKit::WebProcess::removeMessageReceiver):
(WebKit::WebProcess::didReceiveSyncMessage):
(WebKit::WebProcess::didReceiveMessage):

  • WebProcess/WebProcess.h:

(WebProcess):

12:31 PM Changeset in webkit [132385] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/Source/WebKit/chromium

Create skia_webkit.gyp to improve rebaselining.
https://bugs.webkit.org/show_bug.cgi?id=99759

Patch by Ben Wagner <bungeman@chromium.org> on 2012-10-24
Reviewed by Dirk Pranke.

This allows for code suppressions to be lifted atomically with new baselines.

  • skia_webkit.gyp: Added.
12:30 PM Changeset in webkit [132384] by thakis@chromium.org
  • 5 edits in trunk/Source/WebCore

Honor image orientation in GraphicsContextSkia
https://bugs.webkit.org/show_bug.cgi?id=100179

Reviewed by Stephen White.

Also fix a bug in ImageOrientation.h: Some of the values were
switched. They now match the description in the exif spec at
http://www.exif.org/Exif2-2.PDF page 18, and the notes at
http://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/EXIF.html and
the picture at http://www.80sidea.com/archives/2316.

They showed up correctly in Safari because the orientation transform
was done after flipping Y. Let the flipping happen later. I verified
that flipping transformation order and fixing the exif enum cancelled
each other out, so this has no effect on the apple port.

Not hooked up yet, so no observable difference.

  • platform/graphics/BitmapImage.h:
  • platform/graphics/ImageOrientation.h:

(WebCore::ImageOrientation::usesWidthAsHeight):
(WebCore::ImageOrientation::fromEXIFValue):

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawNativeImage):

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::paintSkBitmap):
(WebCore::BitmapImage::draw):
(WebCore):

12:17 PM Changeset in webkit [132383] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Fixed Windows path for SharedWorkerStrategy.h - it's in workers/, not platform/.

  • WebCore.vcproj/WebCore.vcproj:
12:10 PM Changeset in webkit [132382] by zandobersek@gmail.com
  • 3 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Rebaselining two Video Track tests after r132349.

  • platform/gtk/media/track/track-cue-rendering-horizontal-expected.txt:
  • platform/gtk/media/track/track-cue-rendering-vertical-expected.txt:
12:02 PM Changeset in webkit [132381] by Chris Fleizach
  • 3 edits
    2 moves
    2 deletes in trunk

AX: WebKit exposes abstract ARIA role range as AXSlider; should be generic AXGroup
https://bugs.webkit.org/show_bug.cgi?id=100204

Reviewed by Beth Dakin.

Source/WebCore:

Remove the "range" role as a valid ARIA role.

Test: platform/mac/accessibility/aria-slider-value.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::createARIARoleMap):

LayoutTests:

Remove the aria-range.html test because the same functionality is covered in aria-slider.html
Rename aria-range-value to aria-slider-value and use the non-abstract role slider instead (and
move that to the general accessibility platform).

  • accessibility/aria-slider-value-expected.txt: Copied from LayoutTests/platform/mac/accessibility/aria-range-value-expected.txt.
  • accessibility/aria-slider-value.html: Copied from LayoutTests/platform/mac/accessibility/aria-range-value.html.
  • platform/mac/accessibility/aria-range-expected.txt: Removed.
  • platform/mac/accessibility/aria-range-value-expected.txt: Removed.
  • platform/mac/accessibility/aria-range-value.html: Removed.
  • platform/mac/accessibility/aria-range.html: Removed.
12:00 PM Changeset in webkit [132380] by timothy@apple.com
  • 4 edits in trunk/Source

Make the Inspector WKView/WebView become the first responder when bringToFront is called.

https://bugs.webkit.org/show_bug.cgi?id=100209

Reviewed by Joseph Pecoraro.

Source/WebKit/mac:

  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorFrontendClient::bringToFront): Make the Inspector WebView become the first responder.

Source/WebKit2:

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformBringToFront): Make the Inspector WKView become the first responder.

11:48 AM Changeset in webkit [132379] by zoltan@webkit.org
  • 1 edit
    2 moves
    3 adds in trunk/PerformanceTests

Turn PageLoad tests into simple performancetests, commit #1
https://bugs.webkit.org/show_bug.cgi?id=99899

Reviewed by Ryosuke Niwa.

We cannot provide an elegant way to measure the memory consumption of the PageLoad tests, but we can turn them into simple
performance tests and measure their memory footprint and performance that way. This change moves and renames the related files
to their new location and adds html/js wrappers for them.

This is the #1 commit of the whole patch.

  • PageLoad/svg/files/az-lizard_benji_park_01.svg: Removed.
  • PageLoad/svg/files/bamboo_01.svg: Removed.
  • SVG/AzLizardBenjiPark.html: Added.
  • SVG/Bamboo.html: Added.
  • SVG/resources: Added.
  • SVG/resources/AzLizardBenjiPark.svg: Copied from PerformanceTests/PageLoad/svg/files/az-lizard_benji_park_01.svg.
  • SVG/resources/Bamboo.svg: Copied from PerformanceTests/PageLoad/svg/files/bamboo_01.svg.
11:28 AM Changeset in webkit [132378] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Marking fast/media/w3c/test_media_queries.html as slow on
Chromium debug bots following r132352. It may still timeout...

  • platform/chromium/TestExpectations:
11:13 AM Changeset in webkit [132377] by fmalita@chromium.org
  • 8 edits in trunk

[Chromium] SVG repaint issues
https://bugs.webkit.org/show_bug.cgi?id=99874

Reviewed by Levi Weintraub.

Source/WebCore:

RenderSVGRoot::paintReplaced() converts the container offsets to a relative transform,
but in doing so it ends up accumulating subpixel rounding deltas twice: first for
adjustedPaintOffset and second in localToParentTransform(). If coordinates are on
half-pixel boundaries, the 2x rounding delta yields a full pixel drift and we end up
painting at the wrong location.

This can be avoided by using localToBorderBoxTransform() directly, which (unlike
localToParentTransform()) doesn't perform rounding.

No new tests: existing pixel results cover this change after rebaseline.

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::paintReplaced):

LayoutTests:

  • platform/chromium-linux/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-linux/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png:
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png:
  • platform/chromium/TestExpectations:
11:10 AM Changeset in webkit [132376] by danakj@chromium.org
  • 3 edits
    4 adds in trunk/LayoutTests

Layout tests to verify scaled composited layers have crisp text
https://bugs.webkit.org/show_bug.cgi?id=96940

Reviewed by Adrienne Walker.

Chromium bug: crbug.com/149943

  • compositing/text-on-scaled-layer-expected.html: Added.
  • compositing/text-on-scaled-layer.html: Added.
  • compositing/text-on-scaled-surface-expected.html: Added.
  • compositing/text-on-scaled-surface.html: Added.
  • platform/chromium/TestExpectations:
  • platform/mac/TestExpectations:
11:08 AM Changeset in webkit [132375] by leviw@chromium.org
  • 2 edits in trunk/Source/WebCore

Fixing the Chromium build after typo in r132367.

  • WebCore.gypi:
11:02 AM Changeset in webkit [132374] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Respect image orientation in image dragging code
https://bugs.webkit.org/show_bug.cgi?id=100200

Reviewed by Tony Chang.

Based on the corresponding code in DragImageMac.mm. The image
rotation code isn't hooked up yet, so no observable effect for now.

  • platform/chromium/DragImageChromiumSkia.cpp:

(WebCore::createDragImageFromImage):

11:00 AM Changeset in webkit [132373] by msaboff@apple.com
  • 2 edits in trunk/Source/WebCore

Code cleanup after r132165
https://bugs.webkit.org/show_bug.cgi?id=100135

Reviewed by Geoffrey Garen.

Fixed up some unneccesary and inefficient constructs in MarkupTokenBase.h.

Code clean up without functional changes, therefore no new tests.

  • xml/parser/MarkupTokenBase.h:

(WebCore::MarkupTokenBase::beginEndTag): Changed argument to be const Vector<LChar, 32>&.
(WebCore::MarkupTokenBase::appendToCharacter): Changed argument to be const Vector<LChar, 32>&.
(WebCore::MarkupTokenBase::appendToName): Elimintated inline.
(WebCore::MarkupTokenBase::name): Elimintated inline.
(WebCore::MarkupTokenBase::nameString): Elimintated inline.

10:56 AM Changeset in webkit [132372] by leviw@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

Unreveiewed gardening. Fixing linter, marking 2 mathml tests as flaky crashers on debug,
and adding passing Lion expectations for a third mathml test.

  • platform/chromium/TestExpectations:
  • platform/chromium-mac-lion/mathml/presentation/fenced-expected.png: Modified.
10:55 AM Changeset in webkit [132371] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Crash when trying to write exception message to null console
https://bugs.webkit.org/show_bug.cgi?id=99658

Patch by Toni Barzic <tbarzic@chromium.org> on 2012-10-24
Reviewed by Adam Barth.

Source/WebCore:

DOMWindow::console may return NULL, so we should do a NULL check before adding message to it.
This may happen e.g. if a worker throws an exception just as the document is being replaced in the view.
The exception task could be processes after current window in the frame changes, and console in the document window is nulled.

Test: fast/workers/worker-exception-during-navigation.html

  • dom/Document.cpp:

(WebCore::Document::addMessage):

LayoutTests:

The test creates bunch of workers that throw an exception as soon as they are loaded and then tries to change the current document.
The test passes if there is no crash.
Unfortuantely, the test is inherently flaky and may produce some false positive results (but should never fail if there is no bug).

  • fast/workers/resources/worker-exception.js: Added.
  • fast/workers/worker-exception-during-navigation-expected.txt: Added.
  • fast/workers/worker-exception-during-navigation.html: Added.
10:44 AM Changeset in webkit [132370] by jochen@chromium.org
  • 4 edits in trunk/Tools

[chromium] Use include paths relative to Source/ in the TestRunner's public API
https://bugs.webkit.org/show_bug.cgi?id=100079

Reviewed by Adam Barth.

For a inside-chromium build, we usually don't add the WebKit API paths
as include paths, so including files by name only does not work.

Eventually we might want to move to a model where all includes are
relative to Source/, so we're using that here already now.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • DumpRenderTree/chromium/TestRunner/public/WebEventSender.h:
  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
10:36 AM Changeset in webkit [132369] by ojan@chromium.org
  • 4 edits in trunk/Tools

Show an error when there are no completed builds in the past 20 runs
https://bugs.webkit.org/show_bug.cgi?id=100266

Reviewed by Dimitri Glazkov.

Right now we get a cryptic JS error in the console when loading the gtk port. This at least gives an error in
the notification stream. We should probably tweak this UI to make it so we can make
errors in the notification stream stick out (e.g. make the text red).

We should also consider making the number of runs to load dynamic (e.g. if 20 runs don't work,
try 40).

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
10:29 AM Changeset in webkit [132368] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Incorrect conditional use of LogFTP
https://bugs.webkit.org/show_bug.cgi?id=100260

Patch by Cosmin Truta <ctruta@rim.com> on 2012-10-24
Reviewed by Alexey Proskuryakov.

Use LogFTP if !LOG_DISABLED, to allow toggling ASSERTIONS_DISABLED_DEFAULT
without breaking the build.

  • html/FTPDirectoryDocument.cpp:

(WebCore::FTPDirectoryDocument::FTPDirectoryDocument):

10:28 AM Changeset in webkit [132367] by ap@apple.com
  • 28 edits
    1 add in trunk/Source

Add a strategy for shared workers
https://bugs.webkit.org/show_bug.cgi?id=100165

Reviewed by Brady Eidson.

10:22 AM Changeset in webkit [132366] by weinig@apple.com
  • 12 edits in trunk/Source/WebKit2

Move a few more WebProcess sub-objects to be MessageReceivers
https://bugs.webkit.org/show_bug.cgi?id=100186

Reviewed by Anders Carlsson.

  • WebProcess/Battery/WebBatteryManager.cpp:

(WebKit::WebBatteryManager::WebBatteryManager):

  • WebProcess/Battery/WebBatteryManager.h:

(WebBatteryManager):

  • WebProcess/IconDatabase/WebIconDatabaseProxy.cpp:

(WebKit::WebIconDatabaseProxy::WebIconDatabaseProxy):
(WebKit):

  • WebProcess/IconDatabase/WebIconDatabaseProxy.h:

(WebIconDatabaseProxy):

  • WebProcess/NetworkInfo/WebNetworkInfoManager.cpp:

(WebKit::WebNetworkInfoManager::WebNetworkInfoManager):

  • WebProcess/NetworkInfo/WebNetworkInfoManager.h:

(WebNetworkInfoManager):

  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::WebNotificationManager):

  • WebProcess/Notifications/WebNotificationManager.h:

(WebNotificationManager):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didReceiveMessage):

  • WebProcess/soup/WebSoupRequestManager.cpp:

(WebKit::WebSoupRequestManager::WebSoupRequestManager):

  • WebProcess/soup/WebSoupRequestManager.h:

(WebSoupRequestManager):

10:20 AM Changeset in webkit [132365] by Dave Barton
  • 4 edits in trunk

[MathML] Timeouts on linux after r132264
https://bugs.webkit.org/show_bug.cgi?id=100202

Reviewed by Eric Seidel.

Source/WebCore:

When building a stretched operator, such as a large parenthesis or bracket, we need to
check that the extension glyph's height is > 0, to avoid an infinite loop. The 0 height
can occur if the glyph is missing on the host system.

Tested by existing tests.

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::updateFromElement):

LayoutTests:

The failing tests no longer timeout.

  • platform/chromium/TestExpectations:
10:02 AM Changeset in webkit [132364] by vollick@chromium.org
  • 4 edits in trunk/Tools

[chromium] Explicitly disable accelerated animations in DRT
https://bugs.webkit.org/show_bug.cgi?id=100241

Reviewed by Adrienne Walker.

Disable accelerated animations by default in DRT.

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::setAcceleratedAnimationEnabled):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell):

9:43 AM Changeset in webkit [132363] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] Typos in user-visible strings: "coordintate"
https://bugs.webkit.org/show_bug.cgi?id=100252

Patch by Priit Laes <plaes@plaes.org> on 2012-10-24
Reviewed by Martin Robinson.

s/coordintate/coordinate

  • webkit/webkithittestresult.cpp:

(webkit_hit_test_result_class_init):

9:39 AM WebKitGTK/1.10.x edited by Martin Robinson
(diff)
9:23 AM Changeset in webkit [132362] by zoltan@webkit.org
  • 2 edits in trunk/PerformanceTests

REGRESSION(r131982): Skip SVG/SvgNestedUse.html performancetest since it is crashing
https://bugs.webkit.org/show_bug.cgi?id=100262

Unreviewed.

Skip until proper fix.

  • Skipped: Add SVG/SvgNestedUse.html
9:18 AM Changeset in webkit [132361] by andersca@apple.com
  • 128 edits in trunk/Source/WebKit2

encode should take an ArgumentEncoder reference
https://bugs.webkit.org/show_bug.cgi?id=100183

Reviewed by Jessie Berlin.

  • Platform/CoreIPC/ArgumentCoder.h:

(CoreIPC::ArgumentCoder::encode):

  • Platform/CoreIPC/Arguments.h:

(CoreIPC::Arguments0::encode):
(CoreIPC::Arguments1::encode):
(CoreIPC::Arguments2::encode):
(CoreIPC::Arguments3::encode):
(CoreIPC::Arguments4::encode):
(CoreIPC::Arguments5::encode):
(CoreIPC::Arguments6::encode):
(CoreIPC::Arguments7::encode):
(CoreIPC::Arguments8::encode):
(CoreIPC::Arguments10::encode):

  • Platform/CoreIPC/Attachment.cpp:

(CoreIPC::Attachment::encode):

  • Platform/CoreIPC/Attachment.h:

(Attachment):

  • Platform/CoreIPC/DataReference.cpp:

(CoreIPC::DataReference::encode):

  • Platform/CoreIPC/DataReference.h:

(DataReference):

  • Platform/CoreIPC/StringReference.cpp:

(CoreIPC::StringReference::encode):

  • Platform/CoreIPC/StringReference.h:

(StringReference):

  • Platform/CoreIPC/mac/MachPort.h:

(CoreIPC::MachPort::encode):

  • Platform/SharedMemory.h:

(Handle):

  • Platform/mac/SharedMemoryMac.cpp:

(WebKit::SharedMemory::Handle::encode):

  • PluginProcess/PluginCreationParameters.cpp:

(WebKit::PluginCreationParameters::encode):

  • PluginProcess/PluginCreationParameters.h:

(PluginCreationParameters):

  • Shared/DictionaryPopupInfo.cpp:

(WebKit::DictionaryPopupInfo::encode):

  • Shared/DictionaryPopupInfo.h:

(DictionaryPopupInfo):

  • Shared/EditorState.cpp:

(WebKit::EditorState::encode):

  • Shared/EditorState.h:

(EditorState):

  • Shared/FontInfo.cpp:

(WebKit::FontInfo::encode):

  • Shared/FontInfo.h:

(FontInfo):

  • Shared/LayerTreeContext.h:

(LayerTreeContext):

  • Shared/Network/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode):

  • Shared/Network/NetworkProcessCreationParameters.h:

(NetworkProcessCreationParameters):

  • Shared/OriginAndDatabases.cpp:

(WebKit::OriginAndDatabases::encode):

  • Shared/OriginAndDatabases.h:

(OriginAndDatabases):

  • Shared/PlatformPopupMenuData.cpp:

(WebKit::PlatformPopupMenuData::encode):

  • Shared/PlatformPopupMenuData.h:

(PlatformPopupMenuData):

  • Shared/Plugins/NPIdentifierData.cpp:

(WebKit::NPIdentifierData::encode):

  • Shared/Plugins/NPIdentifierData.h:

(NPIdentifierData):

  • Shared/Plugins/NPVariantData.cpp:

(WebKit::NPVariantData::encode):

  • Shared/Plugins/NPVariantData.h:

(NPVariantData):

  • Shared/Plugins/PluginProcessCreationParameters.cpp:

(WebKit::PluginProcessCreationParameters::encode):

  • Shared/Plugins/PluginProcessCreationParameters.h:

(PluginProcessCreationParameters):

  • Shared/PrintInfo.cpp:

(WebKit::PrintInfo::encode):

  • Shared/PrintInfo.h:

(PrintInfo):

  • Shared/SandboxExtension.h:

(Handle):
(HandleArray):

  • Shared/SecurityOriginData.cpp:

(WebKit::SecurityOriginData::encode):

  • Shared/SecurityOriginData.h:

(SecurityOriginData):

  • Shared/SessionState.cpp:

(WebKit::SessionState::encode):

  • Shared/SessionState.h:

(SessionState):

  • Shared/ShareableBitmap.cpp:

(WebKit::ShareableBitmap::Handle::encode):

  • Shared/ShareableBitmap.h:

(Handle):

  • Shared/SharedWorkerProcessCreationParameters.cpp:

(WebKit::SharedWorkerProcessCreationParameters::encode):

  • Shared/SharedWorkerProcessCreationParameters.h:

(SharedWorkerProcessCreationParameters):

  • Shared/StatisticsData.cpp:

(WebKit::StatisticsData::encode):

  • Shared/StatisticsData.h:

(StatisticsData):

  • Shared/StringPairVector.h:

(WebKit::StringPairVector::encode):

  • Shared/UpdateInfo.cpp:

(WebKit::UpdateInfo::encode):

  • Shared/UpdateInfo.h:

(UpdateInfo):

  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):

  • Shared/WebContextMenuItemData.cpp:

(WebKit::WebContextMenuItemData::encode):

  • Shared/WebContextMenuItemData.h:

(WebContextMenuItemData):

  • Shared/WebEvent.cpp:

(WebKit::WebEvent::encode):

  • Shared/WebEvent.h:

(WebEvent):
(WebMouseEvent):
(WebWheelEvent):
(WebKeyboardEvent):
(WebGestureEvent):
(WebPlatformTouchPoint):
(WebTouchEvent):

  • Shared/WebGeolocationPosition.cpp:

(WebKit::WebGeolocationPosition::Data::encode):

  • Shared/WebGeolocationPosition.h:

(Data):

  • Shared/WebGestureEvent.cpp:

(WebKit::WebGestureEvent::encode):

  • Shared/WebHitTestResult.cpp:

(WebKit::WebHitTestResult::Data::encode):

  • Shared/WebHitTestResult.h:

(Data):

  • Shared/WebKeyboardEvent.cpp:

(WebKit::WebKeyboardEvent::encode):

  • Shared/WebMouseEvent.cpp:

(WebKit::WebMouseEvent::encode):

  • Shared/WebNavigationDataStore.h:

(WebKit::WebNavigationDataStore::encode):

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):

  • Shared/WebPageCreationParameters.h:

(WebPageCreationParameters):

  • Shared/WebPageGroupData.cpp:

(WebKit::WebPageGroupData::encode):

  • Shared/WebPageGroupData.h:

(WebPageGroupData):

  • Shared/WebPopupItem.cpp:

(WebKit::WebPopupItem::encode):

  • Shared/WebPopupItem.h:
  • Shared/WebPreferencesStore.cpp:

(WebKit::WebPreferencesStore::encode):

  • Shared/WebPreferencesStore.h:

(WebPreferencesStore):

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):

  • Shared/WebProcessCreationParameters.h:

(WebProcessCreationParameters):

  • Shared/WebWheelEvent.cpp:

(WebKit::WebWheelEvent::encode):

  • Shared/mac/AttributedString.h:

(AttributedString):

  • Shared/mac/AttributedString.mm:

(WebKit::AttributedString::encode):

  • Shared/mac/ColorSpaceData.h:

(ColorSpaceData):

  • Shared/mac/ColorSpaceData.mm:

(WebKit::ColorSpaceData::encode):

  • Shared/mac/LayerTreeContextMac.mm:

(WebKit::LayerTreeContext::encode):

  • Shared/mac/PlatformCertificateInfo.h:

(PlatformCertificateInfo):

  • Shared/mac/PlatformCertificateInfo.mm:

(WebKit::PlatformCertificateInfo::encode):

  • Shared/mac/SandboxExtensionMac.mm:

(WebKit::SandboxExtension::Handle::encode):
(WebKit::SandboxExtension::HandleArray::encode):

  • Shared/mac/SecItemRequestData.cpp:

(WebKit::SecItemRequestData::encode):

  • Shared/mac/SecItemRequestData.h:
  • Shared/mac/SecItemResponseData.cpp:

(WebKit::SecItemResponseData::encode):

  • Shared/mac/SecItemResponseData.h:

(SecItemResponseData):

  • Shared/mac/SecKeychainItemRequestData.cpp:

(WebKit::SecKeychainItemRequestData::encode):

  • Shared/mac/SecKeychainItemRequestData.h:
  • Shared/mac/SecKeychainItemResponseData.cpp:

(WebKit::SecKeychainItemResponseData::encode):

  • Shared/mac/SecKeychainItemResponseData.h:

(SecKeychainItemResponseData):

  • UIProcess/WebContextUserMessageCoders.h:

(WebKit::WebContextUserMessageEncoder::encode):

  • WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:

(WebKit::InjectedBundleUserMessageEncoder::encode):

  • WebProcess/Plugins/Plugin.cpp:

(WebKit::Plugin::Parameters::encode):

  • WebProcess/Plugins/Plugin.h:

(Parameters):

8:30 AM Changeset in webkit [132360] by commit-queue@webkit.org
  • 6 edits
    2 moves in trunk/Source/WebKit

[BlackBerry] Rename GeolocationControllerClientBlackBerry to GeolocationClientBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=100250

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-10-24
Reviewed by Rob Buis.

Source/WebKit:

Rename GeolocationControllerClientBlackBerry to GeolocationClientBlackBerry
to prevent confusion.

PR 230196

  • PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

Rename GeolocationControllerClientBlackBerry to GeolocationClientBlackBerry
to prevent confusion.
PR 230196

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

  • Api/WebPage_p.h:

(WebCore):

  • WebCoreSupport/ChromeClientBlackBerry.cpp:
  • WebCoreSupport/GeolocationClientBlackBerry.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/GeolocationControllerClientBlackBerry.cpp.

(frameOrigin):
(GeolocationClientBlackBerry::GeolocationClientBlackBerry):
(GeolocationClientBlackBerry::geolocationDestroyed):
(GeolocationClientBlackBerry::startUpdating):
(GeolocationClientBlackBerry::stopUpdating):
(GeolocationClientBlackBerry::lastPosition):
(GeolocationClientBlackBerry::requestPermission):
(GeolocationClientBlackBerry::cancelPermissionRequest):
(GeolocationClientBlackBerry::onLocationUpdate):
(GeolocationClientBlackBerry::onLocationError):
(GeolocationClientBlackBerry::onPermission):
(GeolocationClientBlackBerry::setEnableHighAccuracy):

  • WebCoreSupport/GeolocationClientBlackBerry.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/GeolocationControllerClientBlackBerry.h.

(WebKit):
(WebCore):
(GeolocationClientBlackBerry):
(WebCore::GeolocationClientBlackBerry::tracker):

8:28 AM Changeset in webkit [132359] by jocelyn.turcotte@digia.com
  • 6 edits in trunk

[Qt] Move the QQuickWebViewExperimental pointer to QQuickWebViewPrivate
https://bugs.webkit.org/show_bug.cgi?id=100253

Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

We'll need to avoid placing data in QQuickWebView to preserve
its binary compatibility once it's public.
Also make the QQuickWebViewExperimental constructor private.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewExperimental::QQuickWebViewExperimental):
(QQuickWebView::QQuickWebView):
(QQuickWebView::experimental):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

Tools:

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::WrapperWindow::handleStatusChanged):
Use QQuickWebView::experimental rather than creating a new instance.

8:28 AM Changeset in webkit [132358] by commit-queue@webkit.org
  • 6 edits in trunk/Source

[BlackBerry] Extending existing ThreadUnsafe singletons in webkit to
Generic ThreadUnsafe Singleton
https://bugs.webkit.org/show_bug.cgi?id=100145

Patch by Parth Patel <parpatel@rim.com> on 2012-10-24
Reviewed by Rob Buis.

Extending the singletons to generic singleton and changing
getInstance() in IconDatabaseClientBlackBerry to instance()
to match the generic singleton template.

Reviewed Internally by Yong Li.

Source/WebCore:

Tests are not modified and added as there was no behavioural change.

  • platform/blackberry/SharedTimerBlackBerry.cpp:

(SharedTimerBlackBerry):
(WebCore):

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::initializeIconDataBase):

  • WebCoreSupport/IconDatabaseClientBlackBerry.cpp:

(WebCore):

  • WebCoreSupport/IconDatabaseClientBlackBerry.h:

(IconDatabaseClientBlackBerry):

8:08 AM Changeset in webkit [132357] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: NMI add instrumentation for ResourceBuffer. It gives us 10mb on gmail
https://bugs.webkit.org/show_bug.cgi?id=100254

Reviewed by Yury Semikhatsky.

  • loader/ResourceBuffer.cpp:

(WebCore::ResourceBuffer::reportMemoryUsage):
(WebCore):

  • loader/ResourceBuffer.h:

(ResourceBuffer):

8:04 AM Changeset in webkit [132356] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

Allow ports to override text track rendering style
https://bugs.webkit.org/show_bug.cgi?id=97800
<rdar://problem/12044964>

Unreviewed Build fix.

CGFloat is already a float in a 32-bit build so narrowPrecisionToFloat() is unnecessary

  • page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::captionFontSizeScale):

7:51 AM Changeset in webkit [132355] by commit-queue@webkit.org
  • 2 edits in trunk

[GTK] ./configure output for CSS Shaders is broken
https://bugs.webkit.org/show_bug.cgi?id=100217

Patch by Priit Laes <plaes@plaes.org> on 2012-10-24
Reviewed by Martin Robinson.

Reformat CSS Filters / Shaders check to clean configure output.

  • configure.ac:
7:42 AM Changeset in webkit [132354] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

[EFL][WK2] Ewk_Settings refactoring
https://bugs.webkit.org/show_bug.cgi?id=100233

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-24
Reviewed by Kenneth Rohde Christiansen.

Ewk_Settings private implementation is now C++ class which allows direct internal
access to WebKit::WebPreferences.

  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::EwkViewImpl):

  • UIProcess/API/efl/ewk_settings.cpp:

(Ewk_Settings::preferences):
(ewk_settings_fullscreen_enabled_set):
(ewk_settings_fullscreen_enabled_get):
(ewk_settings_javascript_enabled_set):
(ewk_settings_javascript_enabled_get):
(ewk_settings_loads_images_automatically_set):
(ewk_settings_loads_images_automatically_get):
(ewk_settings_developer_extras_enabled_set):
(ewk_settings_developer_extras_enabled_get):
(ewk_settings_file_access_from_file_urls_allowed_set):
(ewk_settings_file_access_from_file_urls_allowed_get):
(ewk_settings_frame_flattening_enabled_set):
(ewk_settings_frame_flattening_enabled_get):
(ewk_settings_dns_prefetching_enabled_set):
(ewk_settings_dns_prefetching_enabled_get):

  • UIProcess/API/efl/ewk_settings_private.h:

(WebKit):
(Ewk_Settings):
(Ewk_Settings::Ewk_Settings):

  • UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_initialize):

7:41 AM Changeset in webkit [132353] by dominik.rottsches@intel.com
  • 3 edits in trunk/Source/WebKit2

[EFL][AC] Fix build break when AC is enabled
https://bugs.webkit.org/show_bug.cgi?id=100245

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-24
Reviewed by Kenneth Rohde Christiansen.

Fix build break after r132337.

  • UIProcess/API/efl/EwkViewImpl.h:
  • UIProcess/API/efl/ewk_view.cpp:
7:38 AM Changeset in webkit [132352] by commit-queue@webkit.org
  • 3 edits
    5 copies
    6 adds in trunk/LayoutTests

CSS3 Media Queries - add resolution tests to W3C test suite
https://bugs.webkit.org/show_bug.cgi?id=100231

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-10-24
Reviewed by Kenneth Rohde Christiansen.

Resolution media feature was implemented, therefore,
W3C tests are added back to the test suite.

  • fast/media/w3c/test_media_queries-expected.txt:
  • fast/media/w3c/test_media_queries.html:

Created platform specific expectations for the platforms that have RESOLUTION_MEDIA_QUERY disabled.

  • platform/blackberry/fast/media/w3c/test_media_queries-expected.txt: Added.
  • platform/chromium/fast/media/w3c/test_media_queries-expected.txt: Added.
  • platform/gtk/fast/media/w3c/test_media_queries-expected.txt: Added.
  • platform/mac/fast/media/w3c/test_media_queries-expected.txt: Added.
  • platform/win/fast/media/w3c/test_media_queries-expected.txt: Added.
7:34 AM Changeset in webkit [132351] by dominik.rottsches@intel.com
  • 3 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

  • platform/efl-wk1/TestExpectations: Marking shadow-dom failures after r132303
  • platform/efl-wk2/TestExpectations: Marking focus failure after r132342 and drag-select failure between r132333-r132343.
7:33 AM Changeset in webkit [132350] by commit-queue@webkit.org
  • 8 edits in trunk

[EFL] run-webkit-tests writes garbage on stderr when running on Xvfb
https://bugs.webkit.org/show_bug.cgi?id=100243

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-10-24
Reviewed by Kenneth Rohde Christiansen.

.:

Search for X11 development libraries (and thus Xext), necessary to
disable the X extensions error reporting.

  • Source/cmake/OptionsEfl.cmake:

Source/WebKit2:

These errors generate noise on the reports and in some cases, like when
running perf tests, makes the test fail. By using Xext, we can add a
dummy handler to ignore these errors.

  • PlatformEfl.cmake:
  • WebProcess/efl/WebProcessMainEfl.cpp:

(dummyExtensionErrorHandler):
(WebKit::WebProcessMainEfl):

Tools:

These errors generate noise on the reports and in some cases, like when
running perf tests, makes the test fail. By using Xext, we can add a
dummy handler to ignore these errors.

We could have added this handler on the top level EWK API, but that
would be intrusive and could override handlers defined by the user.

  • WebKitTestRunner/PlatformEfl.cmake:
  • WebKitTestRunner/efl/main.cpp:

(dummyExtensionErrorHandler):
(main):

7:24 AM Changeset in webkit [132349] by eric.carlson@apple.com
  • 25 edits
    3 adds in trunk

Allow ports to override text track rendering style
https://bugs.webkit.org/show_bug.cgi?id=97800
<rdar://problem/12044964>

Reviewed by Maciej Stachowiak.

Source/WebCore:

  • WebCore.exp.in: Export new WebkitSystemInterface functions.
  • WebCore.xcodeproj/project.pbxproj: Add CaptionUserPreferences.h, CaptionUserPreferencesMac.mm,

and CaptionUserPreferencesMac.h.

  • css/mediaControls.css: Rearrange the caption CSS so it is possible to style the cue window,

background, and text independently.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_disableCaptions with theme->userPrefersCaptions().
(WebCore::HTMLMediaElement::attach): Register for caption preferences change callbacks.
(WebCore::HTMLMediaElement::detach): Unregister for caption preferences change callbacks.
(WebCore::HTMLMediaElement::userPrefersCaptions): Return theme->userPrefersCaptions().
(WebCore::HTMLMediaElement::userIsInterestedInThisTrackKind): Consider userPrefersCaptions().
(WebCore::HTMLMediaElement::setClosedCaptionsVisible): Move the code that marks all tracks as

un-configured to markCaptionAndSubtitleTracksAsUnconfigured so it can be reused.

(WebCore::HTMLMediaElement::captionPreferencesChanged): New, force a reevaluation of all text tracks.
(WebCore::HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured): New, code moved from

setClosedCaptionsVisible

  • html/HTMLMediaElement.h: Inherit from CaptionPreferencesChangedListener.
  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateSizes): Get rid of unnecessary member

variable. Get caption font scale from theme instead of hard coding.

  • html/shadow/MediaControlElements.h:
  • html/track/TextTrack.cpp:

(WebCore::TextTrack::TextTrack): Change attributes from String to AtomicString.
(WebCore::TextTrack::isValidKindKeyword): Ditto.
(WebCore::TextTrack::setKind): Ditto.
(WebCore::TextTrack::setMode): Ditto.
(WebCore::TextTrack::mode): Ditto.

  • html/track/TextTrack.h:

(WebCore::TextTrack::create): Ditto.
(WebCore::TextTrack::kind): Ditto.
(WebCore::TextTrack::label): Ditto.
(WebCore::TextTrack::setLabel): Ditto.
(WebCore::TextTrack::language): Ditto.
(WebCore::TextTrack::setLanguage): Ditto.

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCueBox::TextTrackCueBox): Set the shadow pseudo id.
(WebCore::TextTrackCueBox::textTrackCueBoxShadowPseudoId): New, class method to return the

shadow pseudo id so it can be used elsewhere.

(WebCore::TextTrackCueBox::shadowPseudoId): Call textTrackCueBoxShadowPseudoId.
(WebCore::TextTrackCue::pastNodesShadowPseudoId): New, class method to return the

shadow pseudo id so it can be used elsewhere.

(WebCore::TextTrackCue::futureNodesShadowPseudoId): Ditto.
(WebCore::TextTrackCue::updateDisplayTree):

  • html/track/TextTrackCue.h:
  • page/CaptionUserPreferences.h: Added.
  • page/CaptionUserPreferencesMac.h: Added.
  • page/CaptionUserPreferencesMac.mm: Added.

(WebCore::userCaptionPreferencesChangedNotificationCallback):
(WebCore::CaptionUserPreferencesMac::CaptionUserPreferencesMac):
(WebCore::CaptionUserPreferencesMac::~CaptionUserPreferencesMac):
(WebCore::CaptionUserPreferencesMac::userHasCaptionPreferences): New, passthrough to WKSI function.
(WebCore::CaptionUserPreferencesMac::userPrefersCaptions): Ditto.
(WebCore::CaptionUserPreferencesMac::captionsWindowColor): Return Color with user's caption window color preference.
(WebCore::CaptionUserPreferencesMac::captionsBackgroundColor): Return Color with user's caption

background color preference.

(WebCore::CaptionUserPreferencesMac::captionsTextColor): Return Color with user's caption text color preference.
(WebCore::CaptionUserPreferencesMac::captionsEdgeColorForTextColor): Return Color for text edge effect.
(WebCore::CaptionUserPreferencesMac::cssPropertyWithTextEdgeColor): Return String with CSS to set a text-shadow

or webkit-text-stroke property.

(WebCore::CaptionUserPreferencesMac::cssColorProperty): Return a String with css to set a property

with a color value.

(WebCore::CaptionUserPreferencesMac::captionsTextEdgeStyle): Return a String with css to style caption

text with the user's preferred text edge stye.

(WebCore::CaptionUserPreferencesMac::captionsDefaultFont): Return a String with css to style caption

text with the user's preferred font.

(WebCore::CaptionUserPreferencesMac::captionsStyleSheetOverride): Return a String with css to style captions

with the user's preferred style.

(WebCore::CaptionUserPreferencesMac::captionFontSizeScale): Return the user's preferred caption font scale.
(WebCore::CaptionUserPreferencesMac::captionPreferencesChanged): Notify listeners of caption preference change.
(WebCore::CaptionUserPreferencesMac::registerForCaptionPreferencesChangedCallbacks): Add a caption preferences

changes listener.

(WebCore::CaptionUserPreferencesMac::unregisterForCaptionPreferencesChangedCallbacks): Remove a caption preferences

changes listener.

(WebCore::CaptionUserPreferencesMac::updateCaptionStyleSheetOveride): New, if theme has a captions style sheet override,

inject it into the current page group, otherwise remove injected sheet.

  • page/PageGroup.cpp:

(WebCore::PageGroup::captionPreferences):
(WebCore::PageGroup::registerForCaptionPreferencesChangedCallbacks): New, passthrough to platform specific function

of the same name.

(WebCore::PageGroup::unregisterForCaptionPreferencesChangedCallbacks): Ditto.
(WebCore::PageGroup::userPrefersCaptions): Ditto.
(WebCore::PageGroup::userHasCaptionPreferences): Ditto.
(WebCore::PageGroup::captionFontSizeScale): Ditto.

  • page/PageGroup.h:
  • platform/mac/WebCoreSystemInterface.h: Updated.
  • platform/mac/WebCoreSystemInterface.mm: Ditto.

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Initialize new WKSI function pointers.

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Initialize new WKSI function pointers.

WebKitLibraries:

Update WKSI header with SPI for getting the user caption appearance preferences.

  • WebKitSystemInterface.h:

LayoutTests:

  • media/track/track-cue-rendering-expected.txt: Update results for caption css changes.
  • media/track/track-cue-rendering.html:
  • platform/chromium/TestExpectations: Skip tests that need to be rebaselined.
7:19 AM Changeset in webkit [132348] by vsevik@chromium.org
  • 20 edits
    1 add in trunk

Web Inspector: Introduce workspace provider as a content providing backend for project.
https://bugs.webkit.org/show_bug.cgi?id=100244

Reviewed by Pavel Feldman.

Source/WebCore:

Introduced WorkspaceProvider interface as a content providing backend for project.
Added NetworkWorkspaceProvider as a network based (default) implementation.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/CompilerScriptMapping.js:

(WebInspector.CompilerScriptMapping):

  • inspector/front-end/DebuggerScriptMapping.js:

(WebInspector.DebuggerScriptMapping):

  • inspector/front-end/NetworkUISourceCodeProvider.js:

(WebInspector.NetworkUISourceCodeProvider):
(WebInspector.NetworkUISourceCodeProvider.prototype._parsedScriptSource):
(WebInspector.NetworkUISourceCodeProvider.prototype._resourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._addFile):

  • inspector/front-end/NetworkWorkspaceProvider.js: Added.

(WebInspector.NetworkWorkspaceProvider):
(WebInspector.NetworkWorkspaceProvider.prototype.requestFileContent):
(WebInspector.NetworkWorkspaceProvider.prototype.setFileContent):
(WebInspector.NetworkWorkspaceProvider.prototype.searchInFileContent):
(WebInspector.NetworkWorkspaceProvider.prototype.addFile):
(WebInspector.NetworkWorkspaceProvider.prototype.removeFile):
(WebInspector.NetworkWorkspaceProvider.prototype.reset):

  • inspector/front-end/SASSSourceMapping.js:

(WebInspector.SASSSourceMapping):
(_bindUISourceCode):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel):
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/Workspace.js:

(WebInspector.FileDescriptor):
(WebInspector.WorkspaceProvider):
(WebInspector.WorkspaceProvider.prototype.requestFileContent):
(WebInspector.WorkspaceProvider.prototype.searchInFileContent):
(WebInspector.WorkspaceProvider.prototype.addEventListener):
(WebInspector.WorkspaceProvider.prototype.removeEventListener):
(WebInspector.Project):
(WebInspector.Project.prototype.reset):
(WebInspector.Project.prototype._fileAdded):
(WebInspector.Project.prototype._fileRemoved):
(WebInspector.Project.prototype.requestFileContent):
(WebInspector.Project.prototype.searchInFileContent):
(WebInspector.Workspace):
(WebInspector.Workspace.prototype.addProject):
(WebInspector.Workspace.prototype.project):

  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

LayoutTests:

  • http/tests/inspector/compiler-script-mapping.html:
  • http/tests/inspector/workspace-test.js:

(initialize_WorkspaceTest.InspectorTest.createWorkspace):
(initialize_WorkspaceTest.InspectorTest.addMockUISourceCodeToWorkspace):

  • inspector/debugger/network-uisourcecode-provider.html:
  • inspector/debugger/script-snippet-model.html:
  • inspector/debugger/scripts-panel.html:
  • inspector/uisourcecode-revisions.html:
6:54 AM Changeset in webkit [132347] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Styles pane: Don't select whole value when I select just a part
https://bugs.webkit.org/show_bug.cgi?id=100242

Patch by Nikita Vasilyev <me@elv1s.ru> on 2012-10-24
Reviewed by Alexander Pavlov.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.prototype._handleEmptySpaceClick):
(WebInspector.StylePropertyTreeElement.prototype):

6:44 AM Changeset in webkit [132346] by vsevik@chromium.org
  • 14 edits in trunk

Web Inspector: UiSourceCode should rely on the workspace as a content provider.
https://bugs.webkit.org/show_bug.cgi?id=100216

Reviewed by Pavel Feldman.

Source/WebCore:

Workspace is now passed to UISourceCode to be used as a content provider.
Content providers are now stored in the workspace/project.
Next step would be to move content providers to workspace providers.

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.breakpointStorageId):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.contentType):
(WebInspector.UISourceCode.prototype.requestContent):
(WebInspector.UISourceCode.prototype.requestOriginalContent):
(WebInspector.UISourceCode.prototype._commitContent):
(WebInspector.UISourceCode.prototype.searchInContent):

  • inspector/front-end/Workspace.js:

(WebInspector.WorkspaceController.prototype._mainFrameNavigated):
(WebInspector.Project):
(WebInspector.Project.prototype.addUISourceCode):
(WebInspector.Project.prototype.removeUISourceCode):
(WebInspector.Project.prototype.uiSourceCodes):
(WebInspector.Project.prototype.requestFileContent):
(WebInspector.Project.prototype.searchInFileContent):
(WebInspector.Workspace):
(WebInspector.Workspace.prototype.addTemporaryUISourceCode):
(WebInspector.Workspace.prototype.removeTemporaryUISourceCode):
(WebInspector.Workspace.prototype.reset):

LayoutTests:

  • http/tests/inspector/compiler-script-mapping.html:
  • inspector/debugger/breakpoint-manager.html:
  • inspector/debugger/script-formatter-search.html:
  • inspector/debugger/scripts-file-selector.html:
  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/scripts-sorting.html:
  • inspector/debugger/ui-source-code-display-name.html:
  • inspector/debugger/ui-source-code.html:
  • inspector/uisourcecode-revisions.html:
6:41 AM Changeset in webkit [132345] by allan.jensen@digia.com
  • 7 edits in trunk/Source

[Qt] Expose useful WebCore::Settings
https://bugs.webkit.org/show_bug.cgi?id=100239

Reviewed by Kenneth Rohde Christiansen.

Expose the two settings CaretBrowsingEnabled and NotificationsEnabled.

Source/WebKit/qt:

  • Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):
(QWebSettings::QWebSettings):

  • Api/qwebsettings.h:

Source/WebKit2:

  • UIProcess/API/qt/qwebpreferences.cpp:

(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferences::caretBrowsingEnabled):
(QWebPreferences::setCaretBrowsingEnabled):
(QWebPreferences::notificationsEnabled):
(QWebPreferences::setNotificationsEnabled):

  • UIProcess/API/qt/qwebpreferences_p.h:
  • UIProcess/API/qt/qwebpreferences_p_p.h:
6:34 AM Changeset in webkit [132344] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

Unreviewed. Fix the GTK+ build.

  • TestWebKitAPI/GNUmakefile.am: Add GTK_FLAGS to

libTestWebKitAPIMain and webcore cflags to TestGtk.

6:18 AM Changeset in webkit [132343] by zeno.albisser@digia.com
  • 8 edits
    2 adds in trunk

Implement GraphicsSurface for Windows.
https://bugs.webkit.org/show_bug.cgi?id=98147

Source/WebCore:

Reviewed by Kenneth Rohde Christiansen.

  • Target.pri:

Include GraphicsSurfaceWin.cpp in SOURCES on Windows.

  • platform/graphics/surfaces/GraphicsSurface.h:

Add typedef for PlatformGraphicsSurface on Windows.

  • platform/graphics/surfaces/GraphicsSurfaceToken.h:

Add typedef for BufferHandle on Windows.

(GraphicsSurfaceToken):

  • platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp: Added.

The GraphicsSurface implementation on Windows relies on the
availability of ANGLE and the EGL_ANGLE_query_surface_pointer extension.
For Qt this requirements are implicitly satisfied, when Qt is built
on Windows and QT_CONFIG contains OpenGLES2.
The GraphicsSurface then renders a given texture onto an offscreen
pixel buffer surface, queries the surface pointer using the
EGL_ANGLE_query_surface_pointer extension, and transmits the received
surface pointer (share handle) over IPC.
On the UIProcess side, the surface pointer can then be resolved
using eglCreatePbufferFromClientBuffer.

(WebCore):
(WebCore::loadShader):

Initialize the shaders needed for drawing onto the GraphicsSurface.

(GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):

In case of the instance being on the WebProcess side,
create an EGLContext that shares the texture objects with the provided
share context. Also create two pixel buffer surfaces, one as front- and
one as backbuffer.
Query the surface pointers for the pixel buffer surfaces and initialize
the GraphicsSurfaceToken that can be passed over IPC later.

(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):

Release all aquired resources and destroy the pixel buffer surfaces.
Also close the EGL-Display connection.

(WebCore::GraphicsSurfacePrivate::copyFromTexture):

Make the belonging context current on the back buffer surface
and use drawTexture() to draw the provided texture onto the GraphicsSurface.

(WebCore::GraphicsSurfacePrivate::makeCurrent):

Save the previously current context, then make the context belonging
to the GraphicsSurface current.

(WebCore::GraphicsSurfacePrivate::doneCurrent):

Restore the context that was current before calling makeCurrent().

(WebCore::GraphicsSurfacePrivate::swapBuffers):

Swap front and back buffer surfaces and handles.

(WebCore::GraphicsSurfacePrivate::token):
(WebCore::GraphicsSurfacePrivate::frontBufferTextureID):

This function is meant to be called from the UIProcess side.
If no front buffer surface has been created before for the current
front buffer handle, one will be created.
Then eglBindTexImage will be used to actually bind the current
front buffer surface to a texture as a source for drawing.

(WebCore::GraphicsSurfacePrivate::initialFrontBufferShareHandle):
(WebCore::GraphicsSurfacePrivate::frontBufferShareHandle):
(WebCore::GraphicsSurfacePrivate::backBufferShareHandle):
(WebCore::GraphicsSurfacePrivate::releaseFrontBufferTexture):

Free the resources related to the front buffer surface.
On the UIProcess side we never actually bind the back buffer.

(WebCore::GraphicsSurfacePrivate::initializeShaderProgram):

Initialize and link the shader programs necessary for drawing
onto the GraphicsSurface.

(WebCore::GraphicsSurfacePrivate::createSurfaceFromShareHandle):

Creates a single pixel buffer surface from a share Handle.
This function will be called on the UIProcess side,
for the front buffer handle, whenever the buffers have been swapped.

(WebCore::GraphicsSurfacePrivate::drawTexture):

The WebProcess uses this function to draw a given
texture onto the GraphicsSurface's back buffer.

(WebCore::GraphicsSurface::platformExport):
(WebCore::GraphicsSurface::platformGetTextureID):
(WebCore::GraphicsSurface::platformCopyToGLTexture):
(WebCore::GraphicsSurface::platformCopyFromTexture):
(WebCore::GraphicsSurface::platformPaintToTextureMapper):

Uses TextureMapperGL::drawTexture() to draw the front buffer texture
to the TextureMapper on the UIProcess side.

(WebCore::GraphicsSurface::platformFrontBuffer):
(WebCore::GraphicsSurface::platformSwapBuffers):
(WebCore::GraphicsSurface::platformCreate):
(WebCore::GraphicsSurface::platformImport):
(WebCore::GraphicsSurface::platformLock):
(WebCore::GraphicsSurface::platformUnlock):
(WebCore::GraphicsSurface::platformDestroy):

Source/WebKit2:

Add encode and decode implementation for GraphicsSurfaceToken on Windows.

Reviewed by Kenneth Rohde Christiansen.

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

Tools:

Reviewed by Kenneth Rohde Christiansen.

  • qmake/mkspecs/features/features.prf:

Activate GraphicsSurface on windows in case opengles2 (ANGLE)
is available in QT_CONFIG.

5:38 AM Changeset in webkit [132342] by rakuco@webkit.org
  • 2 edits in trunk/Tools

[EFL][WK2] fast/repaint/delete-into-nested-block.html and fast/repaint/4776765.html are flaky
https://bugs.webkit.org/show_bug.cgi?id=100010

Reviewed by Kenneth Rohde Christiansen.

Force the main view to receive focus even if Evas already
considers it to be focused.

It might happen that a different frame is focused by a page and
the focus change notification does not reach Evas. When another
test is run, the main frame is then not considered to be focused
by WebCore, and things such as focus rings are not drawn as
expected.

  • WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

(WTR::PlatformWebView::focus):

5:31 AM Changeset in webkit [132341] by rakuco@webkit.org
  • 10 edits
    13 adds in trunk/LayoutTests

[EFL] Hopefully finish rebaselining after r131941 and r131991.

  • platform/efl/compositing/clip-change-expected.png: Added.
  • platform/efl/compositing/geometry/foreground-offset-change-expected.png: Added.
  • platform/efl/compositing/iframes/fixed-position-iframe-expected.png: Added.
  • platform/efl/compositing/iframes/iframe-content-flipping-expected.png:
  • platform/efl/compositing/iframes/repaint-after-losing-scrollbars-expected.png: Added.
  • platform/efl/compositing/iframes/scroll-fixed-transformed-element-expected.png: Added.
  • platform/efl/compositing/iframes/scroll-grandchild-iframe-expected.png: Added.
  • platform/efl/compositing/overflow/repaint-after-losing-scrollbars-expected.png:
  • platform/efl/compositing/repaint/newly-composited-on-scroll-expected.png:
  • platform/efl/compositing/repaint/newly-composited-repaint-rect-expected.png:
  • platform/efl/compositing/repaint/shrink-layer-expected.png: Added.
  • platform/efl/compositing/repaint/transform-style-change-expected.png: Added.
  • platform/efl/compositing/rtl: Added.
  • platform/efl/compositing/rtl/rtl-overflow-invalidation-expected.png: Added.
  • platform/efl/compositing/video-page-visibility-expected.png:
  • platform/efl/css3/flexbox/repaint-expected.png:
  • platform/efl/fast/canvas/canvas-as-image-incremental-repaint-expected.png: Added.
  • platform/efl/fast/canvas/canvas-composite-fill-repaint-expected.png:
  • platform/efl/fast/canvas/canvas-incremental-repaint-2-expected.png: Added.
  • platform/efl/fast/canvas/canvas-incremental-repaint-expected.png: Added.
  • platform/efl/fast/canvas/canvas-resize-after-paint-without-layout-expected.png:
  • platform/efl/fast/canvas/setWidthResetAfterForcedRender-expected.png:
5:17 AM Changeset in webkit [132340] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding crash expectations for tests that started crashing after r132286.

  • platform/gtk/TestExpectations:
5:16 AM Changeset in webkit [132339] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] ASSERTION FAILED: edje(): could not paint native HTML part due to missing theme
https://bugs.webkit.org/show_bug.cgi?id=100227

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-24
Reviewed by Kenneth Rohde Christiansen.

Browser crashes on loading any page due to missing theme after
the web process has crashed and recovered.

This patch reset the theme when the web process is recovered to
avoid a crash.

  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::didRelaunchProcess):

5:05 AM Changeset in webkit [132338] by rakuco@webkit.org
  • 9 edits
    1 delete in trunk

Unreviewed, rolling out r132333.
http://trac.webkit.org/changeset/132333
https://bugs.webkit.org/show_bug.cgi?id=100234

Crashes many tests on the EFL-WK2 bot. (Requested by rakuco on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-24

Source/WebKit2:

  • Target.pri:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::updateTextCheckerState):

Tools:

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

  • WebKitTestRunner/efl/TestControllerEfl.cpp:

(WTR::TestController::platformInitializeContext):

LayoutTests:

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/efl/editing/spelling/inline_spelling_markers-expected.txt: Removed.
  • platform/efl/editing/spelling/spelling-expected.txt: Removed.
5:02 AM Changeset in webkit [132337] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk/Source/WebKit2

[EFL][WK2] Move Ewk_View_Private_Data out of ewk_view.cpp
https://bugs.webkit.org/show_bug.cgi?id=100228

Patch by Christophe Dumez <Christophe Dumez> and Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-24
Reviewed by Gyuyoung Kim.

Move Ewk_View_Private_Data out of ewk_view.cpp and
rename it to EwkViewImpl. This is a first step towards
getting rid of C'ism in Ewk_View.

In a future, we will make EwkViewImpl a proper C++
class and get rid of the private ewk_view C API so
that WebKit code interacts with EwkViewImpl instead
of Evas_Object.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/EwkViewImpl.cpp: Added.

(_ewk_view_commit):
(_ewk_view_preedit_changed):
(_ewk_view_imf_context_destroy):
(_ewk_view_imf_context_create):
(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::~EwkViewImpl):

  • UIProcess/API/efl/EwkViewImpl.h: Added.

(WebKit):
(EwkViewImpl):

  • UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_priv_del):
(_ewk_view_smart_add):

  • UIProcess/API/efl/ewk_view.h:
4:57 AM Changeset in webkit [132336] by ryuan.choi@samsung.com
  • 3 edits in trunk/Source/WebKit2

[EFL][WK2] Crash when passing NULL instead of ewk_view instance
https://bugs.webkit.org/show_bug.cgi?id=100078

Reviewed by Gyuyoung Kim.

Although applications should pass valid ewk_view to call ewk_view_XXX,
ewk_view_XXX should not be crashed.

  • UIProcess/API/efl/ewk_view.cpp:

Checked null and early exited from EWK_VIEW_TYPE_CHECK if error occured.

  • UIProcess/API/efl/tests/test_ewk2_view.cpp: Added test case.

(TEST_F):

4:45 AM Changeset in webkit [132335] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Fix build break - undefined reference to 'gtk_init'
https://bugs.webkit.org/show_bug.cgi?id=100221

Unreviewed build fix.

GTK_LIBS is needed for TestWTF.

Patch by Dongwoo Joshua Im <dw.im@samsung.com> on 2012-10-24

  • TestWebKitAPI/GNUmakefile.am:
4:02 AM Changeset in webkit [132334] by commit-queue@webkit.org
  • 3 edits
    4 moves in trunk/Source/WebKit2

[EFL][WK2] Make find and form clients C++ classes
https://bugs.webkit.org/show_bug.cgi?id=100199

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-24
Reviewed by Kenneth Rohde Christiansen.

Make form and find client C++ classes to move away
from C'ism in WK2 EFL port. The new classes have been
moved up to UIProcess/efl instead of UIProcess/API/efl
since it is not part of the public API.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/ewk_view.cpp:

(Ewk_View_Private_Data):
(_ewk_view_initialize):

  • UIProcess/efl/FindClientEfl.cpp: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_view_find_client.cpp.

(WebKit):
(WebKit::toFindClientEfl):
(WebKit::FindClientEfl::didFindString):
(WebKit::FindClientEfl::didFailToFindString):
(WebKit::FindClientEfl::FindClientEfl):

  • UIProcess/efl/FindClientEfl.h: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_view_find_client_private.h.

(WebKit):
(FindClientEfl):
(WebKit::FindClientEfl::create):

  • UIProcess/efl/FormClientEfl.cpp: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_view_form_client.cpp.

(WebKit):
(WebKit::toFormClientEfl):
(WebKit::FormClientEfl::willSubmitForm):
(WebKit::FormClientEfl::FormClientEfl):

  • UIProcess/efl/FormClientEfl.h: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_view_form_client_private.h.

(WebKit):
(FormClientEfl):
(WebKit::FormClientEfl::create):

3:58 AM Changeset in webkit [132333] by g.czajkowski@samsung.com
  • 9 edits
    3 adds in trunk

Source/WebKit2: [EFL] WebKitTestRunner needs to turn on 'setContinuousSpellCheckingEnabled'
https://bugs.webkit.org/show_bug.cgi?id=93611

Reviewed by Hajime Morita.

When WebKitTestRunner turns on the spelling feature with the resetStateToConsistentValues() method,
it happens that the WebProcess is still not launched (although it is already created).
In this case, isValid() method returns false.

This fix sends a message to the WebProcess messages queue, and the message
will be handled once the WebProcess is ready.

  • Target.pri:

Adds missing files to compile spellcheking feature for WebKit2-Qt
to use WebKit C API from WKTextChecker.h.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::updateTextCheckerState):
Uses canSendMessage() method instead of isValid() to check whether the message to
the WebProcess can be sent.

Tools: WebKitTestRunner needs to turn on 'setContinuousSpellCheckingEnabled'
https://bugs.webkit.org/show_bug.cgi?id=93611

Reviewed by Hajime Morita.

WebKitTestRunner enables spelling feature to pass the layout tests from editing/spelling.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):
Enables spelling by WebKit2 C API.

  • WebKitTestRunner/efl/TestControllerEfl.cpp:

(WTR::TestController::platformInitializeContext):
Attaches WKTextChecker's client and sets default language for WebKit2-EFL port.

LayoutTests: [EFL] WebKitTestRunner needs to turn on 'setContinuousSpellCheckingEnabled'
https://bugs.webkit.org/show_bug.cgi?id=93611

Reviewed by Hajime Morita.

Unskip the spelling tests from efl-wk2/TestExpectations to run them for WebKit2-EFL.
Add new baselines for two spelling tests.

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/efl/editing/spelling/inline_spelling_markers-expected.txt: Added.
  • platform/efl/editing/spelling/spelling-expected.txt: Added.
3:43 AM WebKitEFLLayoutTest edited by jussi.kukkonen@intel.com
mention PLUGIN_PROCESS_COMMAND_PREFIX (diff)
2:33 AM Changeset in webkit [132332] by tkent@chromium.org
  • 3 edits in trunk/LayoutTests

[Chromium] Test expectation update

  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium/TestExpectations:
2:16 AM Changeset in webkit [132331] by yurys@chromium.org
  • 14 edits
    1 add in trunk

Web Inspector: provide memory instrumentation for ListHashSet
https://bugs.webkit.org/show_bug.cgi?id=97786

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Switched existing usages of addListHashSet to the generic instrumentation mechanism
as it should work just just fine now that there is a memory instrumentation of
ListHashSet.

  • dom/DocumentEventQueue.cpp:
  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::reportMemoryUsage):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::reportMemoryUsage):

Source/WebKit/chromium:

Added a test for ListHashSet memory instrumentation.

  • tests/MemoryInstrumentationTest.cpp:

(WebCore::TEST):
(WebCore):

Source/WTF:

Added memory instrumentation for ListHashSet.

  • GNUmakefile.list.am:
  • WTF.gypi:
  • WTF.pro:
  • WTF.vcproj/WTF.vcproj:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/HashSet.h:

(WTF):

  • wtf/ListHashSet.h:

(ListHashSet):
(ListHashSetNodeAllocator): changed visibility of inPool method to public
(WTF::ListHashSetNodeAllocator::pool):
(WTF::ListHashSetNodeAllocator::pastPool):
(WTF::::sizeInBytes): added a method that returns size of the set in bytes including
all its internals but not the content elements.
(WTF):

  • wtf/MemoryInstrumentation.h: removed onsolete method. All clients were updated to

use generic addMember instead.
(MemoryInstrumentation):
(WTF::MemoryClassInfo::addPrivateBuffer):

  • wtf/MemoryInstrumentationHashSet.h:
  • wtf/MemoryInstrumentationListHashSet.h: Copied from Source/WTF/wtf/MemoryInstrumentationHashSet.h.

(WTF):
(WTF::reportMemoryUsage):

2:09 AM Changeset in webkit [132330] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update

  • platform/chromium/TestExpectations:
    • exif-orientation-css.html is ImageOnlyFailure.
    • Still need rebaseline for calendar-picker-appearance-step.html on Windows?
1:35 AM Changeset in webkit [132329] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2][AC] Black screen in web inspector window with AC on
https://bugs.webkit.org/show_bug.cgi?id=100168

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-10-24
Reviewed by Kenneth Rohde Christiansen.

When ACCELERATED_COMPOSITING flag is turned on, and using X11,
pass "opengl_x11" engine name to ecore_evas_new when creating a
web inspector window. It is guaranteed to be available, because
we wouldn't be able to create a main window if it wasn't.

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

1:12 AM Changeset in webkit [132328] by mario@webkit.org
  • 4 edits in trunk

[WK2] [GTK] TestWebKitAccessibility is not being run
https://bugs.webkit.org/show_bug.cgi?id=100102

Reviewed by Carlos Garcia Campos.

.:

Moved check for at-spi2 after the definition of enable_webkit2,
since it's only needed for WebKit2GTK API tests.

  • configure.ac: Moved the check for at-spi2 down in the file.

Tools:

Removed wrong early return in _start_accessibility_daemons().

  • Scripts/run-gtk-tests:

(TestRunner._lookup_atspi2_binary): Removed wrong line.

12:55 AM Changeset in webkit [132327] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Skip tests that depend on disabling accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=99167

Rubber-stamped by Simon Hausmann.

Skip those tests because we don't support the non-accelerated
rendering path.

  • platform/qt-5.0-wk2/TestExpectations:
12:54 AM Changeset in webkit [132326] by commit-queue@webkit.org
  • 4 edits
    2 adds
    2 deletes in trunk/Source/WebKit2

[EFL][WK2] Make History client a C++ class
https://bugs.webkit.org/show_bug.cgi?id=100104

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-24
Reviewed by Kenneth Rohde Christiansen.

Created ContextHistoryClientEfl class to encapsulate history client code for EFL.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/ewk_context.cpp:

(Ewk_Context::Ewk_Context):
(ewk_context_history_callbacks_set):

  • UIProcess/API/efl/ewk_context_history_client.cpp: Removed.
  • UIProcess/API/efl/ewk_context_history_client_private.h: Removed.
  • UIProcess/API/efl/ewk_context_private.h:

(WebKit):
(Ewk_Context):

  • UIProcess/efl/ContextHistoryClientEfl.cpp: Added.

(WebKit):
(WebKit::toContextHistoryClientEfl):
(WebKit::ContextHistoryClientEfl::didNavigateWithNavigationData):
(WebKit::ContextHistoryClientEfl::didPerformClientRedirect):
(WebKit::ContextHistoryClientEfl::didPerformServerRedirect):
(WebKit::ContextHistoryClientEfl::didUpdateHistoryTitle):
(WebKit::ContextHistoryClientEfl::populateVisitedLinks):
(WebKit::ContextHistoryClientEfl::ContextHistoryClientEfl):
(WebKit::ContextHistoryClientEfl::setCallbacks):

  • UIProcess/efl/ContextHistoryClientEfl.h: Added.

(WebKit):
(ContextHistoryClientEfl):
(WebKit::ContextHistoryClientEfl::create):

12:52 AM Changeset in webkit [132325] by tkent@chromium.org
  • 97 edits
    12 adds
    4 deletes in trunk/LayoutTests

[Chromium] Rebaseline for r132310.

  • platform/chromium/TestExpectations:
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png: Removed.
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png: Removed.
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png:
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-win-xp/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-win-xp/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png: Removed.
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png:
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
12:48 AM Changeset in webkit [132324] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

Skipping a test because of r132303. Now ENABLE(SHADOW_DOM) is disabled on Qt.

Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-10-24

  • platform/qt/TestExpectations:
12:40 AM Changeset in webkit [132323] by Carlos Garcia Campos
  • 17 edits in trunk/Source/WebKit2

[GTK] Add API to get the WebKitWebView associated to a WebKitDownload to WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=99836

Reviewed by Martin Robinson.

Add webkit_download_get_web_view() to get the WebKitWebView that
initiated the download and webkit_web_view_download_uri() to start
a new download associated to a WebKitWebView.

  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::handleDownloadRequest): Call
webkitWebViewBaseHandleDownloadRequest().

  • UIProcess/API/gtk/PageClientImpl.h:

(PageClientImpl): Add handleDownloadRequest().

  • UIProcess/API/gtk/WebKitDownload.cpp:

(webkitDownloadSetWebView): Set the WebKitWebView associated to
the download.
(webkit_download_get_web_view): Public method to get the
WebKitWebView associated to the download.

  • UIProcess/API/gtk/WebKitDownload.h:
  • UIProcess/API/gtk/WebKitDownloadPrivate.h:
  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkit_web_context_download_uri): Use the new helper
webkitWebContextStartDownload().
(webkitWebContextStartDownload): Helper function to start a new
download that is also used by WebKitWebView.

  • UIProcess/API/gtk/WebKitWebContextPrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewHandleDownloadRequest): Call
webkitDownloadSetWebView() to associate the download with the
WebKitWebView.
(webkitWebViewConstructed): Set a download request handler.
(webkit_web_view_download_uri): Public method to start a new
download associated to the web view.

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseSetDownloadRequestHandler): Set a function
pointer to be called when a new download is request for the web
view.
(webkitWebViewBaseHandleDownloadRequest): Call the download
request handler if any.

  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
  • UIProcess/API/gtk/tests/TestDownloads.cpp:

(testDownloadLocalFile):
(testDownloadLocalFileError):
(testDownloadRemoteFile):
(testDownloadRemoteFileError):
(testWebViewDownloadURI):
(testPolicyResponseDownload):
(beforeAll):

  • UIProcess/PageClient.h:

(PageClient):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

12:39 AM Changeset in webkit [132322] by charles.wei@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Credentials not re-used for a redirected request to the same domain
https://bugs.webkit.org/show_bug.cgi?id=100193

Reviewed by George Staikos.

We should store the credentials in the redirection response handler, if the request is challenged.
Because the redirect response suggests the authentication succeeds.

Test: http://browsertest01.rim.net/authbasic

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::handleRedirect):

12:34 AM Changeset in webkit [132321] by apavlov@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Implement CSS reload upon related SASS resource saving
https://bugs.webkit.org/show_bug.cgi?id=98024

Reviewed by Vsevolod Vlasov.

SASS-generated debug info in CSS is parsed to find out which SASS files contributed to this stylesheet.
Upon SASS file save in the Sources panel, all affected external CSS stylesheets are reloaded to update
the page styles (presuming that SASS is running in the "watch" mode during the development cycle).

  • English.lproj/localizedStrings.js:
  • inspector/front-end/SASSSourceMapping.js:

(WebInspector.SASSSourceMapping):
(WebInspector.SASSSourceMapping.prototype._fileSaveFinished.callback):
(WebInspector.SASSSourceMapping.prototype._reloadCSS):
(_bindUISourceCode):
(_addCSSURLforSASSURL):

  • inspector/front-end/Settings.js:
  • inspector/front-end/SettingsScreen.js:

(WebInspector.GenericSettingsTab):

12:33 AM Changeset in webkit [132320] by noel.gordon@gmail.com
  • 8 edits in trunk

Source/WebKit/chromium: [chromium] Plumb DRT WebkitShouldRespectImageOrientation through to page settings
https://bugs.webkit.org/show_bug.cgi?id=100197

Reviewed by Kent Tamura.

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setShouldRespectImageOrientation): set the WebCore page
setting for shouldRespectImageOrientation.
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

Tools: [chromium] Plumb DRT WebkitShouldRespectImageOrientation through to page settings
https://bugs.webkit.org/show_bug.cgi?id=100197

Reviewed by Kent Tamura.

fast/images/exif-orientation.html and fast/images/exif-orientation-css.html require a DRT
WebkitShouldRespectImageOrientation preference. Add the chromium implementation for this
preference and plumb it through to page settings.

  • DumpRenderTree/chromium/DRTTestRunner.cpp:

(DRTTestRunner::overridePreference): Update the tests WebkitShouldRespectImageOrientation
setting in DRT prefs.

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::reset): Disable the preference before and after each test.
(WebPreferences::applyTo): Apply the preference to the page settings of each test.

  • DumpRenderTree/chromium/WebPreferences.h:

(WebPreferences):

12:31 AM Changeset in webkit [132319] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unskip fast/events/tabindex-focus-blur-all.html.
https://bugs.webkit.org/show_bug.cgi?id=100206

Unreviewed, EFL gardening.

The bug webkit.org/b/100065 is fixed and the test is passing now.

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-10-24

  • platform/efl-wk1/TestExpectations:
12:21 AM Changeset in webkit [132318] by zandobersek@gmail.com
  • 2 edits
    4 adds in trunk/LayoutTests

Unreviewed GTK gardening.
Marking fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html
as flaky after r132143.
Adding baselines for tvo SVG Transforms tests required after r132121.

  • platform/gtk/TestExpectations:
  • platform/gtk/svg/transforms/svg-css-transforms-clip-path-expected.png: Added.
  • platform/gtk/svg/transforms/svg-css-transforms-clip-path-expected.txt: Added.
  • platform/gtk/svg/transforms/svg-css-transforms-expected.png: Added.
  • platform/gtk/svg/transforms/svg-css-transforms-expected.txt: Added.

Oct 23, 2012:

11:48 PM WebKit Team edited by kihong.kwon@samsung.com
(diff)
11:44 PM Changeset in webkit [132317] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] TestWebKitAPI/TestWebKit2 and TestWebKitAPI/TestGtk link to the installed libs
https://bugs.webkit.org/show_bug.cgi?id=100134

Reviewed by Martin Robinson.

Do not share the LDADD variable among TestWTF, TestWebKit2 and
TestGtk.

  • TestWebKitAPI/GNUmakefile.am:
11:43 PM Changeset in webkit [132316] by zoltan@webkit.org
  • 2 edits in trunk/PerformanceTests

Store the loaded file locally in measurePageLoadTime
https://bugs.webkit.org/show_bug.cgi?id=100172

Reviewed by Csaba Osztrogonác.

Store the loaded file as a local variable instead of attaching it to the test object.
Handle chunkSize inside test.run.

  • resources/runner.js:

(.):

11:35 PM Changeset in webkit [132315] by yurys@chromium.org
  • 4 edits in trunk/Source/WebCore

Memory instrumentation: don't count agent-specific front-ends separately
https://bugs.webkit.org/show_bug.cgi?id=100087

Reviewed by Alexander Pavlov.

Pointers to domain-specific inspector front-end interfaces are reported as
weak pointers instead of members to avoid double-counting.

Test by comparing set of reported instrumented objects with the set of objects
allocated by tcmalloc.

  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::reportMemoryUsage):

  • inspector/InspectorDOMStorageResource.cpp:

(WebCore::InspectorDOMStorageResource::reportMemoryUsage):

  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::reportMemoryUsage):

11:27 PM Changeset in webkit [132314] by Dave Barton
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Some linux MathML tests are timing out - see webkit.org/b/100202.

  • platform/chromium/TestExpectations:
11:23 PM Changeset in webkit [132313] by kihong.kwon@samsung.com
  • 2 edits in trunk/Tools

Unreviewed. Adding myself as committer.

  • Scripts/webkitpy/common/config/committers.py:
11:16 PM Changeset in webkit [132312] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebCore

Regression(r132303) Broke debug build when SHADOW_DOM is enabled but STYLE_SCOPED is disabled
https://bugs.webkit.org/show_bug.cgi?id=100203

Unreviewed Build fix.

Fix compilation error in StyleResolver.h when SHADOW_DOM flag is
set and STYLE_SCOPED is not.

No new tests, no behavior change.

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-23

  • css/StyleResolver.h:

(WebCore::StyleResolver::ensureScopeResolver):

10:27 PM Changeset in webkit [132311] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove specialized hash traits for GlyphPages.
<http://webkit.org/b/100185>

Reviewed by Dan Bernstein.

Now that the default minimum table size has been lowered for all tables, there's no need
for this specialization anymore.

  • platform/graphics/FontFallbackList.h:

(FontFallbackList):

10:22 PM Changeset in webkit [132310] by tkent@chromium.org
  • 5 edits in trunk

Multiple fields input UI: Don't use CSS properties for physical direction
https://bugs.webkit.org/show_bug.cgi?id=100195

Reviewed by Kentaro Hara.

Source/WebCore:

CSS declarations such as "padding: 0 0 0 1px;" "margin-left: 0.2em;" are
not direction-neutral, and makes unexpected appearance in RTL. We should
use -webkit-padding-start or -webkit-margin-start.

No new tests. Covered by date-multiple-fields-appearance-l10n.html and
month-multiple-fields-appearance-l10n.html

  • css/html.css:

(input[type="date"]): Use padding:0 and -webkit-padding-start:1px;
(input[type="datetime"]): Ditto.
(input[type="datetime-local"]): Ditto.
(input[type="month"]): Ditto.
(input[type="time"]): Ditto.
(input[type="week"]): Ditto.
(input[type="week"]::-webkit-inner-spin-button):
Use -webkit-margin-start. Also use an integral pixel size instead of
avoid a fractional relative size to avoid subpixel layout rounding.

LayoutTests:

  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png:
10:13 PM Changeset in webkit [132309] by mitz@apple.com
  • 7 edits in trunk

Source/WebKit/mac: WebKit/mac part of <rdar://problem/2966974> [mac] Kerning and ligatures are not enabled by default
https://bugs.webkit.org/show_bug.cgi?id=100188

Reviewed by Sam Weinig.

  • WebView/WebView.mm:

(+[WebView initialize]): Added a local variable to hold the standard user defaults. Added
code to register a value of YES for the WebKitKerningAndLigaturesEnabledByDefault user
default. Changed to refer to that default key by name.

Source/WebKit2: WebKit2 part of <rdar://problem/2966974> [mac] Kerning and ligatures are not enabled by default
https://bugs.webkit.org/show_bug.cgi?id=100188

Reviewed by Sam Weinig.

  • UIProcess/mac/WebContextMac.mm:

(WebKit::registerUserDefaultsIfNeeded): Added. Registers a value of YES for the
WebKitKerningAndLigaturesEnabledByDefault user default if it has not been registered yet.
(WebKit::WebContext::platformInitializeWebProcess): Added a call to
registerUserDefaultsIfNeeded, and changed to refer to the defaults key by name.

Tools: Tools changes for <rdar://problem/2966974> [mac] Kerning and ligatures are not enabled by default
https://bugs.webkit.org/show_bug.cgi?id=100188

Reviewed by Sam Weinig.

Disable kerning and ligatures by default when running the tests.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues): Set a value of NO for the
WebKitKerningAndLigaturesEnabledByDefault user default.

  • WebKitTestRunner/mac/main.mm:

(main): Register a value of NO for the WebKitKerningAndLigaturesEnabledByDefault user
default.

10:12 PM Changeset in webkit [132308] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

The font cache evicts inactive font data too aggressively when not under memory pressure
https://bugs.webkit.org/show_bug.cgi?id=100194

Reviewed by Sam Weinig.

Increasing the number of inactive font data objects the cache may hold increases the hit
rate, leading to improved page load performance. When memory pressure is detected,
MemoryPressureHandler evicts all inactive objects, regardless of the limits we are
increasing here.

  • platform/graphics/FontCache.cpp:

(WebCore): Increased the maximum number of inactive font data objects in the cache from 50
to 225, and the number of objects to evict once the limit is met from 20 to 25.

10:10 PM Changeset in webkit [132307] by kling@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

CodeBlock: Give m_putToBaseOperations an inline capacity.
<http://webkit.org/b/100190>
<rdar://problem/12562466>

Reviewed by Oliver Hunt.

Since the CodeBlock constructor always inserts a single PutToBaseOperation, but there's no
guarantee that more will follow, give the m_putToBaseOperations vector an inline capacity of 1.
There are 4009 of these Vectors on Membuster3, and only 126 of them have more than a single entry.

This change yields a 1.90MB reduction in memory usage.

  • bytecode/CodeBlock.h:

(CodeBlock):

9:56 PM Changeset in webkit [132306] by tkent@chromium.org
  • 68 edits
    10 adds in trunk/LayoutTests

[Chromium] Rebaseline for r132291
https://bugs.webkit.org/show_bug.cgi?id=100088

  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png: Added.
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png:
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png:
  • platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png:
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
  • platform/chromium-win-xp/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-win-xp/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png: Added.
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png: Added.
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png:
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
9:50 PM Changeset in webkit [132305] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed nightly gardening, skip new failing tests.

  • platform/qt/TestExpectations:
9:45 PM Changeset in webkit [132304] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Remove duplicate platform/mac entries
https://bugs.webkit.org/show_bug.cgi?id=100167

Reviewed by Dirk Pranke.

We intentionally don't run platform/mac tests in Chromium. Remove lines
that duplicate the directory WontFix.

  • platform/chromium/TestExpectations:
9:37 PM Changeset in webkit [132303] by tasak@google.com
  • 15 edits
    2 adds in trunk

[Shadow DOM] Needs @host rule for ShadowDOM styling
https://bugs.webkit.org/show_bug.cgi?id=88606

Reviewed by Hajime Morita.

Source/WebCore:

Implemented @host-@rules according to the shadow dom spec:
http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#host-at-rule
The design doc is:
https://docs.google.com/document/d/1P2yorchF8lci2sccr-mVSRf2dtvjKeiuyQWzCB2bEA8/edit

Test: fast/dom/shadow/athost-atrules.html

  • css/CSSGrammar.y.in:

Added rules for parsing @host @-rules.

  • css/CSSParser.cpp:

(WebCore::CSSParser::detectAtToken):
Added a new token "@host".
(WebCore::CSSParser::createHostRule):
Added a new method to create an @host @-rule, which is invoked from
(WebCore):

  • css/CSSParser.h:

Added a declaration of the above new method: createHostRule.

  • css/CSSPropertySourceData.h:

Added HOST_RULE to enum Type.

  • css/RuleSet.cpp:

(WebCore::RuleData::RuleData):
Modified multiple bool arguments into one argument. Now it
uses combinations of values from enum AddRuleFlags.
(WebCore::RuleSet::addRule):
(WebCore::RuleSet::addRegionRule):
(WebCore::RuleSet::addStyleRule):
Updated according to the RuleData's change.
Modified to Invoke increaseSpecificity if the given rule is @host
@-rule.
(WebCore::RuleSet::addRulesFromSheet):
Invoked addHostRule if the given rule is @host @-rule.

  • css/RuleSet.h:

(RuleData):
(WebCore::RuleData::increaseSpecificity):
Added a new method to increase selector's specificity. This method is
used to make @host @-rules' specificity larger than normal author
rules' specificity.
(RuleSet):

  • css/StyleResolver.cpp:

(WebCore::makeRuleSet):
(WebCore::StyleResolver::addHostRule):
A wrapper method to invoke StyleScopeResolver::addHostRule. The method
is used to make only StyleResolver know an implementation detail about
class StyleScopeResolver.
(WebCore::StyleResolver::appendAuthorStylesheets):
Updated according to the RuleData's change.
(WebCore::StyleResolver::styleSharingCandidateMatchesHostRules):
A new method to find matched host rules when an element is given.
This method invokes
StyleScopeResolver::styleSharingCandidateMatchesHostRules to find
matched host rules.
(WebCore):
(WebCore::StyleResolver::matchHostRules):
A new method to find matched host rules when an element is given.
This method invokes StyleScopeResolver::matchHostRules to find
matched host rules.
(WebCore::StyleResolver::matchScopedAuthorRules):
Modified to invoke matchHostRules.
(WebCore::StyleResolver::locateSharedStyle):
Disable sibling style cache if the given element is a shadow host and
any @host @-rules are applied to the element.

  • css/StyleResolver.h:

(WebCore::StyleResolver::ensureScopeResolver):
If no scopeResolver is created, create and return the instance.
If created, just return the instance.
(StyleResolver):

  • css/StyleRule.cpp:

(WebCore::StyleRuleBase::reportMemoryUsage):
(WebCore::StyleRuleBase::destroy):
(WebCore::StyleRuleBase::copy):
(WebCore::StyleRuleBase::createCSSOMWrapper):
(WebCore::StyleRuleHost::StyleRuleHost):
Implemented class StyleRuleHost. The class is almost the same as
StyleRuleBlock except type.
(WebCore):

  • css/StyleRule.h:

(WebCore::StyleRuleBase::isHostRule):
(StyleRuleHost):
(WebCore::StyleRuleHost::create):
(WebCore::StyleRuleHost::copy):
(WebCore):

  • css/StyleScopeResolver.cpp:

(WebCore::StyleScopeResolver::ensureAtHostRuleSetFor):
A new method to create a new RuleSet for the given shadow root.
(WebCore):
(WebCore::StyleScopeResolver::atHostRuleSetFor):
A new private inline method to obtain @host @-rules declared in
the given shadow root.
(WebCore::StyleScopeResolver::addHostRule):
Added a new method to register @host @-rules with shadow roots.
(WebCore::StyleScopeResolver::styleSharingCandidateMatchesHostRules):
A new method to find whether any @host @-rules are applied to
the given host element.
(WebCore::StyleScopeResolver::matchHostRules):
A new method to find matched rules for the given host element.
(WebCore::StyleScopeResolver::reportMemoryUsage):

  • css/StyleScopeResolver.h:

(WebCore):
(StyleScopeResolver):

  • css/StyleSheetContents.cpp:

(WebCore::childRulesHaveFailedOrCanceledSubresources):

LayoutTests:

  • fast/dom/shadow/athost-atrules-expected.txt: Added.
  • fast/dom/shadow/athost-atrules.html: Added.
9:33 PM Changeset in webkit [132302] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

REGRESSION(r130643): ASSERTION FAILED: result.iterator != end() below PluginDatabase::add
<http://webkit.org/b/100065>

Reviewed by Anders Carlsson.

Restore the pre-r130643 hash table size for PluginDatabase to prevent these easily reproducible
collisions. This will need a proper fix at some point.

  • plugins/PluginDatabase.h:
  • plugins/PluginPackage.h:

(PluginPackageHashTraits):

9:31 PM Changeset in webkit [132301] by Csaba Osztrogonác
  • 24 edits
    2 adds in trunk

Allow tests to run with a tile cache, and optionally dump the tile cache via layerTreeAsText()
https://bugs.webkit.org/show_bug.cgi?id=100159

Patch by Simon Fraser <Simon Fraser> on 2012-10-23
Reviewed by Tim Horton.

Source/WebCore:

Add a LAYER_TREE_INCLUDES_PAGE_TILE_CACHE flag for layerTreeAsText(), and plumb it
through to GraphicsLayerCA, which dumps the TiledBacking tile coverage rect.

Test: platform/mac/tiled-drawing/use-tiled-drawing.html

  • page/Frame.h:
  • platform/graphics/GraphicsLayer.cpp:

(showGraphicsLayerTree):

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::tiledBacking):

  • platform/graphics/TiledBacking.h:
  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::tiledBacking):
(WebCore::GraphicsLayerCA::dumpAdditionalProperties):

  • platform/graphics/ca/GraphicsLayerCA.h:

(GraphicsLayerCA):

  • platform/graphics/ca/mac/TileCache.h:

(WebCore::TileCache::tileCoverageRect):
(TileCache):

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::computeTileCoverageRect):
(WebCore::TileCache::revalidateTiles):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::layerTreeAsText):

  • testing/Internals.cpp:

(WebCore::Internals::layerTreeAsText):

  • testing/Internals.h:
  • testing/Internals.idl:

Tools:

Make WebKitTestRunner use a WKView with a tile cache for tests run in a directory
whose path includes "tiled-drawing". It does this by passing around a WKDictionary
of options, and if the current PlatformWebView doesn't support those options, it will
create a new one.

  • WebKitTestRunner/PlatformWebView.h:

(PlatformWebView): Add a WKDictionaryRef options dictionary argument.
(WTR::PlatformWebView::viewSupportsOptions): Returns true if the view
supports the options in the WKDictionaryRef.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize): Call createWebViewWithOptions() with
no options in the normal case.
(WTR::TestController::createWebViewWithOptions): Moved code into this fuction
so we can call it in two places.
(WTR::TestController::ensureViewSupportsOptions): If the current view
doesn't support the given options, throw it away and makea new one that does.

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::shouldUseTiledDrawing): Return true if the directory contains "tiled-drawing".
(WTR::updateTiledDrawingForCurrentTest): Tell the TestController to check whether
the view supports the given options. No-op for non-Mac platforms.
(WTR::TestInvocation::invoke): Call updateTiledDrawingForCurrentTest().

  • WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

(WTR::PlatformWebView::PlatformWebView): New constructor parameter.

  • WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:

(WTR::PlatformWebView::PlatformWebView): New constructor parameter.

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:useTiledDrawing:]):
(-[TestRunnerWKView _shouldUseTiledDrawingArea]): Subclass the WKView so we can return
a custom value from this method.
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::viewSupportsOptions):

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::PlatformWebView): New constructor parameter.

  • WebKitTestRunner/win/PlatformWebViewWin.cpp:

(WTR::PlatformWebView::PlatformWebView): New constructor parameter.

LayoutTests:

A new test that dumps tile cache data for a large page.

  • platform/mac/tiled-drawing/use-tiled-drawing-expected.txt: Added.
  • platform/mac/tiled-drawing/use-tiled-drawing.html: Added.
9:21 PM Changeset in webkit [132300] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit

[Texmap][EFL] Add AcceleratedCompositingContextEfl to the build system.
https://bugs.webkit.org/show_bug.cgi?id=88630

Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2012-10-23
Reviewed by Gyuyoung Kim.

Source/WebKit:

  • PlatformEfl.cmake: Add the AcceleratedCompositingContextEfl.cpp file

and INCLUDE paths for TEXTURE_MAPPER_GL.

Source/WebKit/efl:

  • WebCoreSupport/AcceleratedCompositingContextEfl.cpp: Modify the #include file.
9:15 PM Changeset in webkit [132299] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Flush pending GraphicsLayer changes when reattaching compositing layers if necessary
https://bugs.webkit.org/show_bug.cgi?id=100187
<rdar://problem/12546770>

Reviewed by Dan Bernstein.

Fix a regression from r131940. That revision changed RenderLayerCompositor::flushPendingLayerChanges()
to bail if the root layer is unattached, which indicates that we're in the page cache, or in a
background tab. However, that dropped the layer flush on the floor, so that any subsequent changes
to GraphicsLayerCAs would just pile up and never get flushed. This was most evident on pages
that require frequent flushing, such as those running animated GIFs.

Fix by setting a flag in flushPendingLayerChanges() if we're unattached. Consult the flag
when re-attaching the root layer, and if it's set, flush the GraphicsLayers.

Not testable because we can't test detaching and re-adding web views in DRT/WTR.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::RenderLayerCompositor): Initialize m_shouldFlushOnReattach to false.
(WebCore::RenderLayerCompositor::flushPendingLayerChanges): If the root layer attachment
is RootLayerUnattached, set the m_shouldFlushOnReattach flag before returning.
(WebCore::RenderLayerCompositor::attachRootLayer): If m_shouldFlushOnReattach, flush the layers,
saying that we're the flush root.

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor): Add m_shouldFlushOnReattach flag.

9:12 PM Changeset in webkit [132298] by Csaba Osztrogonác
  • 24 edits
    2 deletes in trunk

Unreviewed, rolling out r132276.
http://trac.webkit.org/changeset/132276
https://bugs.webkit.org/show_bug.cgi?id=100189

It broke the Qt-WK2 build intentionally (Requested by
Ossy_night on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-23

Source/WebCore:

  • page/Frame.h:
  • platform/graphics/GraphicsLayer.cpp:

(showGraphicsLayerTree):

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::tiledBacking):

  • platform/graphics/TiledBacking.h:
  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::tiledBacking):
(WebCore::GraphicsLayerCA::dumpAdditionalProperties):

  • platform/graphics/ca/GraphicsLayerCA.h:

(GraphicsLayerCA):

  • platform/graphics/ca/mac/TileCache.h:
  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::tileCoverageRect):
(WebCore::TileCache::revalidateTiles):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::layerTreeAsText):

  • testing/Internals.cpp:

(WebCore::Internals::layerTreeAsText):

  • testing/Internals.h:
  • testing/Internals.idl:

Tools:

  • WebKitTestRunner/PlatformWebView.h:

(PlatformWebView):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

  • WebKitTestRunner/TestController.h:

(TestController):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR):
(WTR::TestInvocation::invoke):

  • WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

(WTR::PlatformWebView::PlatformWebView):

  • WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:

(WTR::PlatformWebView::PlatformWebView):

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::PlatformWebView):

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::PlatformWebView):

  • WebKitTestRunner/win/PlatformWebViewWin.cpp:

(WTR::PlatformWebView::PlatformWebView):

LayoutTests:

  • platform/mac/tiled-drawing/use-tiled-drawing-expected.txt: Removed.
  • platform/mac/tiled-drawing/use-tiled-drawing.html: Removed.
9:09 PM Changeset in webkit [132297] by noel.gordon@gmail.com
  • 3 edits in trunk/LayoutTests

exif-orientation tests should use dumpAsText(true)
https://bugs.webkit.org/show_bug.cgi?id=100076

Reviewed by Eric Seidel.

  • fast/images/exif-orientation-css.html: Use dumpAsText(true).
  • fast/images/exif-orientation.html: ditto.
9:01 PM Changeset in webkit [132296] by noam.rosenthal@nokia.com
  • 3 edits in trunk/Source/WebKit2

Coordinated Graphics: Enable threaded/IPC animations
https://bugs.webkit.org/show_bug.cgi?id=93146

Unreviewed build fix, some function names changed between review and landing.

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(CoreIPC::encodeTimingFunction):
(CoreIPC::decodeTimingFunction):
(CoreIPC::::encode):

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:

(WebCore):

8:21 PM Changeset in webkit [132295] by pdr@google.com
  • 2 edits in trunk/Source/WebCore

Add extra check for data() in PageSerializer.
https://bugs.webkit.org/show_bug.cgi?id=99102

Reviewed by Eric Seidel.

The image returned from imageForRenderer() does not contain the raw SVG data
so this patch adds a check for image->image()->data() before writing SVG
in PageSerializer::addImageToResources.

Covered by existing test WebPageNewSerializeTest.SVGImageDontCrash.

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::addImageToResources):

7:53 PM Changeset in webkit [132294] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Stop using NSHomeDirectory() to get the home directory, it doesn't always return what we want
https://bugs.webkit.org/show_bug.cgi?id=100180

Reviewed by Anders Carlsson.

NSHomeDirectory() doesn't return the real home directory if the host process
is App Sandboxed, so drop down and use getpwuid_r instead.

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::appendReadwriteSandboxDirectory):
There is no reason anymore to try to create the directory.

(WebKit::WebProcess::initializeSandbox):
Switch to getpwuid_r.

7:49 PM Changeset in webkit [132293] by commit-queue@webkit.org
  • 1 edit
    26 adds in trunk/LayoutTests

[EFL] Unreviewed EFL gardening.
https://bugs.webkit.org/show_bug.cgi?id=100125

Added pixel baselines for editing/pasteboard.

Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2012-10-23

  • platform/efl/editing/pasteboard: 26 new pixel baselines.
7:16 PM Changeset in webkit [132292] by tkent@chromium.org
  • 4 edits in trunk/Source/WebCore

Move appendAsLDMLLiteral in LocaleWin.cpp to a common place
https://bugs.webkit.org/show_bug.cgi?id=100129

Reviewed by Kentaro Hara.

We're going to use appendAsLDMLLiteral in other code, and it is
related to DateTimeFormat class. So we move it to DateTimeFormat
class as quoteAndAppendLiteral.

No new tests because of no behavior change.

  • platform/text/DateTimeFormat.cpp:

(WebCore::DateTimeFormat::quoteAndAppendLiteral):
Moved from LocaleWin.cpp

  • platform/text/DateTimeFormat.h:

Declare StringBuilder by wtf/Forward.h. It also declares String.
(DateTimeFormat): Declare quoteAndAppendLiteral.

  • platform/text/LocaleWin.cpp:

(WebCore): Move appendLDMLLiteral to DateTimeFormat.
(WebCore::convertWindowsDateFormatToLDML):
Follow the moving.

7:12 PM Changeset in webkit [132291] by tkent@chromium.org
  • 10 edits in trunk

REGRESSION(r131421): Text baseline is not aligned in some locales
https://bugs.webkit.org/show_bug.cgi?id=100088

Reviewed by Hajime Morita.

Source/WebCore:

Before this patch, the element with ::-webkit-datetime-edit had
-webkit-align-items:center. It was incorrect at all because it
ignores baselines of each of inner fields. We need to change it to
-webkit-align-items:baseline, or stop using -webkit-flex.

However -webkit-align-items:baseline doesn't work because a spin
button element in the element doesn't have the baseline. If we
specified -webkit-align-items:baseline, the spin button would
shift up.

So, we change the element structure for multiple fields input
elements. Before this patch, the structure was:

input

|

  • ::-webkit-date-and-time-container (flex cotainer) |
::-webkit-datetime-edit (has flexibility in date-and-time-container, also this is a flex container)
|::-webkit-datetime-edit-foo

| | :
| |

|::-webkit-date-time-edit-gap (has flexibility in datetime-edit)

| - ::-webkit-inne-spin-button

  • ::-webkit-calendar-picker-indicator

After the patch, the structure will be:

input

|

  • ::-webkit-date-and-time-container (flexible box) |
::-webkit-datetime-edit (has flexibility in date-and-time-container)
|::-webkit-datetime-edit-foo

| | :
| |
|

::-webkit-inne-spin-button

  • ::-webkit-calendar-picker-indicator

Because the spin button owner is date-and-time-container, we don't
need to make the datetime-edit element a flex container.

Also, we had rounding error by subpixel layout. To avoid it, we
stop using fractional paddings.

In order to implement this, we need to change the SpinButtonOwner
interface provider from DateTimeEditElement to
BaseMultipleFieldsDateAndTimeInputType.

No new tests. Covered by month-multiple-fields-appearance-l10n.html.

  • css/html.css:

(input::-webkit-datetime-edit): Stop making this a flex
container. Inner fields in this use the single baseline.
(input::-webkit-datetime-edit-ampm-field):
Don't use fractional paddings to avoid rounding erros of subpixel
layout. Use integral margin instead to avoid overwrap of focus
ring and background-color of the field.
(input::-webkit-datetime-edit-day-field): Ditto.
(input::-webkit-datetime-edit-hour-field): Ditto.
(input::-webkit-datetime-edit-millisecond-field): Ditto.
(input::-webkit-datetime-edit-minute-field): Ditto.
(input::-webkit-datetime-edit-month-field): Ditto.
(input::-webkit-datetime-edit-second-field): Ditto.
(input::-webkit-datetime-edit-week-field): Ditto.
(input::-webkit-datetime-edit-year-field): Ditto.
(input::-webkit-date-and-time-container): Ditto.

  • html/BaseMultipleFieldsDateAndTimeInputType.h:

(BaseMultipleFieldsDateAndTimeInputType): Overrides
SpinButtonOwner functions, and add m_spinButtonElement.

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::focusAndSelectSpinButtonOwner):
Just delegate to DateTimeEditElement::focusIfNoFocus.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::shouldSpinButtonRespondToMouseEvents):
Moved from DateTimeEditElement::shouldSpinButtonRespondToMouseEvents.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::shouldSpinButtonRespondToWheelEvents):
Moved from DateTimeEditElement::shouldSpinButtonRespondToWheelEvents.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::spinButtonStepDown):
Delegate to DateTimeEditElement::stepDown.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::spinButtonStepUp):
Delegate to DateTimeEditElement::stepUp.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::BaseMultipleFieldsDateAndTimeInputType):
Initialize m_spinButtonElement.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::~BaseMultipleFieldsDateAndTimeInputType):
Reset SpinButtonOwner for m_spinButtonElement like the old code of ~DateTimeEditElement.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree):
Put a SpinButtonElement between the DateTimeEditElement and the PickerIndicatorElement.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::forwardEvent):
Take care of SpinButtonElement.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::disabledAttributeChanged):
Release capture of SpinButtonElement. This corresponds to the old
code of DateTimeEditElement::updateUIState.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::readonlyAttributeChanged): Ditto.

  • html/TextFieldInputType.h:

Make SpinButtonElement::SpinButtonOwner protected to allow overriding.

  • html/shadow/DateTimeEditElement.h:

(DateTimeEditElement): Remove SpniButtonOwner implementation,
m_spinButton, and rename some functions.

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditElement::DateTimeEditElement):
Remove m_spinButton.
(WebCore::DateTimeEditElement::~DateTimeEditElement): Ditto.
(WebCore::DateTimeEditElement::focusIfNoFocus):
Renamed from focusAndSelectSpinButtonOwner. This is called
BaseMultipleFieldsDateAndTimeInputType::focusAndSelectSpinButtonOwner.
(WebCore::DateTimeEditElement::layout):
Remove creation code for -webkit-datetime-edit-gap and SpinButtonElement.
(WebCore::DateTimeEditElement::defaultEventHandler):
Move the code for m_spinButton to
BaseMultipleFieldsDateAndTimeInputType::forwardEvent.
(WebCore::DateTimeEditElement::hasFocusedField): A helper for
BaseMultipleFieldsDateAndTimeInputType::shouldSpinButtonRespondToWheelEvents.
(WebCore::DateTimeEditElement::stepDown): A helper for
BaseMultipleFieldsDateAndTimeInputType::spinButtonStepDown.
(WebCore::DateTimeEditElement::stepUp): A helper for
BaseMultipleFieldsDateAndTimeInputType::spinButtonStepUp.
(WebCore::DateTimeEditElement::updateUIState): Move the code to
BaseMultipleFieldsDateAndTimeInputType::disabledAttributeChanged
and readonlyAttributeChanged.

LayoutTests:

Add a pixel image which has notable changes.
Input elements in other tests have slightly small height and
slightly narrow width.

  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium/TestExpectations:
6:57 PM Changeset in webkit [132290] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Web page renders at the wrong zoom level after viewport changes
https://bugs.webkit.org/show_bug.cgi?id=100096

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-10-23
Reviewed by Rob Buis.

Notify the client of the zoom level change before resuming screen updates.
Otherwise, the user interface thread may blit the content at the wrong
zoom level in some cases. This can also prevent potential flickering.

Reviewed internally by Arvid Nilsson.

PR #225741

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
(BlackBerry::WebKit::WebPagePrivate::zoomBlock):

6:48 PM Changeset in webkit [132289] by Martin Robinson
  • 4 edits
    1 add
    1 delete in trunk

POTFILES.in/.skip need updates for translators
https://bugs.webkit.org/show_bug.cgi?id=67580

Reviewed by Xan Lopez.

.:

Now process POTFILES.in during configuration.

  • configure.ac:

Source/WebKit/gtk/po:

Move POTFILES to POTFILES.in to satisfy intltools-update and also update
the list of files with translations. Since the way the path is calculated
is different now, we also need to change the gettext invocation in
GNUmakefile.am.

  • GNUmakefile.am:
  • POTFILES: Removed.
  • POTFILES.in: Added.
6:13 PM Changeset in webkit [132288] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

Shrink immutable ElementAttributeData and StylePropertySet by one pointer each.
<http://webkit.org/b/100123>

Reviewed by Anders Carlsson.

Remove one pointer of unintentional padding in the immutable versions of these objects.
583kB progression on Membuster3.

  • css/StylePropertySet.cpp:

(WebCore::immutableStylePropertySetSize):

  • dom/ElementAttributeData.cpp:

(WebCore::immutableElementAttributeDataSize):

6:10 PM Changeset in webkit [132287] by Nate Chapin
  • 2 edits in trunk/Source/WebCore

Crash in WebCore::SubresourceLoader::willSendRequest.
https://bugs.webkit.org/show_bug.cgi?id=100147

Reviewed by Abhishek Arya.

No new tests. There is a test case that should cover this, but it doesn't
work correctly on many platforms due to its use of testRunner.addURLToRedirect().
See http/tests/loading/cross-origin-XHR-willLoadRequest.html.
Tested manually on http://www.nick.co.uk/shows/spongebob

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequest):

6:08 PM Changeset in webkit [132286] by Martin Robinson
  • 20 edits
    2 adds
    2 deletes in trunk

[GTK][Soup] Implement the default authentication dialog via WebCoreSupport
https://bugs.webkit.org/show_bug.cgi?id=99351

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Instead of connecting to the SoupSession::authenticate signal in the API layer
via a SoupSessionFeature, route the message through the typical WebCore authentication
mechanism. This is a step on the path to having full-blown support for authentication
in the API allowing for custom authentication dialogs and behavior in clients.

No new tests. This should not change behavior.

  • GNUmakefile.list.am: Add the new implementation file for the AuthenticationChallenge.
  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::didReceiveAuthenticationChallenge): Include GTK+ here as well.

  • platform/gtk/GtkAuthenticationDialog.cpp: Instead of carrying a raw pointer to a SoupAuth

carry a GRefPtr which will allow the dialog to be used even after the AuthenticationChallenge
is destroyed.

  • platform/gtk/GtkAuthenticationDialog.h: ditto.
  • platform/network/ResourceHandle.h: Add a didReceiveAuthenticationChallenge method.
  • platform/network/ResourceHandleInternal.h:

(ResourceHandleInternal): Remove the getter for the initiating page ID.

  • platform/network/soup/AuthenticationChallenge.h: Added an implementation of AuthenticationChallenge

that takes a bit of data from the handle including SoupMessage, SoupAuth, and SoupSession.

  • platform/network/soup/AuthenticationChallengeSoup.cpp: Added. Ditto.
  • platform/network/soup/ResourceError.h:

(ResourceError): Added a factory for authentication errors.

  • platform/network/soup/ResourceErrorSoup.cpp: Ditto.
  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::setSoupRequestInitiaingPageID): Just get the page directly from the NetworkingContext.
(WebCore::createSoupMessageForHandleAndRequest): Always set the "handle" data on the message.
It's always used now.
(WebCore::ResourceHandle::start): Get the initiating page ID directly from the NetworkingContext.
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Added this method which routes
the authentication challenge to the client.
(WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential): Added a stub for this method.
(WebCore::ResourceHandle::loadResourceSynchronously): Don't pass the session to the loader.
(WebCore::authenicateCallback): Added.
(WebCore::ResourceHandle::defaultSession): Connect the authenticate callback.

Source/WebKit/gtk:

Instead of using a custom SoupSessionFeature to show the authentication dialog,
show it using the corresponding WebCore message.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
Show the dialog when we need to authenticate. Also, so not show the dialog
if we are in DRT mode.

  • webkit/webkitglobals.cpp:

(webkitInit): No longer install our SoupFeature.

Source/WebKit2:

Instead of using a custom SoupSessionFeature to show the authentication
dialog, show it using the corresponding WebCore message.

  • GNUmakefile.list.am: Removed the SoupSessionFeature files.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit): Only use the default dispatchDidReceiveAuthenticationChallenge
for non-GTK+ ports.

  • WebProcess/WebCoreSupport/gtk/WebFrameLoaderClientGtk.cpp: Added.

(WebKit::WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): Added
a GTK+-specific implementation that shows the GtkAuthenticationDialog.

  • WebProcess/gtk/WebAuthDialog.cpp: Removed.
  • WebProcess/gtk/WebAuthDialog.h: Removed.
  • WebProcess/gtk/WebProcessMainGtk.cpp:

(WebKit::WebProcessMainGtk): Don't install the custom session feature.

Tools:

We no longer need to turn off the soup authentication dialog soup feature,
because it's not installed.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(setDefaultsToConsistentStateValuesForTesting): Don't turn off the feature any longer.

5:58 PM Changeset in webkit [132285] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

[V8] Simplify GCEpilogueVisitor along the same lines as GCPrologueVisitor
https://bugs.webkit.org/show_bug.cgi?id=100157

Reviewed by Eric Seidel.

This patch removes the traits template parameter from GCEpilogueVisitor
and makes it mirror GCPrologueVisitor again.

  • bindings/v8/V8GCController.cpp:

(WebCore):
(ActiveDOMObjectEpilogueVisitor):
(WebCore::ActiveDOMObjectEpilogueVisitor::ActiveDOMObjectEpilogueVisitor):
(WebCore::ActiveDOMObjectEpilogueVisitor::visitDOMWrapper):
(WebCore::V8GCController::majorGCEpilogue):

5:51 PM Changeset in webkit [132284] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Remove deprecatedSend
https://bugs.webkit.org/show_bug.cgi?id=100127

Reviewed by Andreas Kling.

deprecatedSend is no longer used anywhere, remove it.

  • Platform/CoreIPC/Connection.h:

(Connection):

  • UIProcess/WebProcessProxy.h:

(WebProcessProxy):

5:26 PM Changeset in webkit [132283] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Context menu generated from touch gestures on textareas has
context of the cursor position instead of the position where the event occurs.
https://bugs.webkit.org/show_bug.cgi?id=99520

Patch by Varun Jain <varunjain@chromium.org> on 2012-10-23
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Send a synthetic mouse down event for context menu-summoning-gesture events so
that textareas can correctly set cursors before receiving the context menu event.

Test: fast/events/touch/gesture/right-click-gestures-set-cursor-at-correct-position.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleGestureTwoFingerTap):
(WebCore):
(WebCore::EventHandler::sendContextMenuEventForGesture):

  • page/EventHandler.h:

(EventHandler):

Source/WebKit/chromium:

Send a synthetic mouse down event for context menu-summoning-gesture events so
that textareas can correctly set cursors before receiving the context menu event.
Also in this change, WebInputEvent::GestureTwoFingerTap now follows the same
code path as WebInputEvent::GestureLongPress, hence fixing this bug for both gestures.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):

LayoutTests:

Send a synthetic mouse down event for context menu-summoning-gesture events so that
textareas can correctly set cursors before receiving the context menu event.

  • fast/events/touch/gesture/right-click-gestures-set-cursor-at-correct-position.html: Added.
  • platform/chromium/fast/events/touch/gesture/right-click-gestures-set-cursor-at-correct-position-expected.txt: Added.
4:44 PM Changeset in webkit [132282] by aestes@apple.com
  • 12 edits in trunk/Source

[WebKit2 API] Add properties to get textRects from a WKDOMRange or WKDOMNode
https://bugs.webkit.org/show_bug.cgi?id=100162

Reviewed by Sam Weinig.

Source/WebCore:

  • WebCore.exp.in: Exported symbols needed by WebKit2.
  • bindings/objc/DOM.mm:

(-[DOMNode textRects]): Moved some logic into Node::textRects()
(everything but the call to updateLayoutIgnorePendingStylesheets()).

  • dom/Node.cpp:

(WebCore::Node::textRects):

  • dom/Node.h:

Source/WebKit2:

  • WebProcess/InjectedBundle/API/mac/WKDOMInternals.h:
  • WebProcess/InjectedBundle/API/mac/WKDOMInternals.mm:

(WebKit::toNSArray): Added a helper function to convert a Vector of IntRects to an NSArray.

  • WebProcess/InjectedBundle/API/mac/WKDOMNode.h:
  • WebProcess/InjectedBundle/API/mac/WKDOMNode.mm:

(-[WKDOMNode textRects]):

  • WebProcess/InjectedBundle/API/mac/WKDOMRange.h:
  • WebProcess/InjectedBundle/API/mac/WKDOMRange.mm:

(-[WKDOMRange textRects]):

4:41 PM Changeset in webkit [132281] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

[V8] Remove unused function from DOM wrapper visitor
https://bugs.webkit.org/show_bug.cgi?id=100163

Reviewed by Eric Seidel.

No one overrides these virtual functions. They were added in
http://trac.webkit.org/changeset/73491, but we don't use them in the GC
controller anymore.

  • bindings/v8/V8DOMMap.h:

(WebCore::WeakReferenceMap::visit):

4:15 PM Changeset in webkit [132280] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Clear m_mediaSource reference when the MediaSource is closed
https://bugs.webkit.org/show_bug.cgi?id=100047

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-10-23
Reviewed by Eric Carlson.

The m_mediaSource object shouldn't be accessed after the object
transitions to closed so this change simply clears the reference
when that transition happens.

No new tests because the change isn't visible to JavaScript.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadResource): Removed a closed transition that is actually dead code.
(WebCore::HTMLMediaElement::setSourceState): Clear the m_mediaSource reference on closed transition.

4:10 PM Changeset in webkit [132279] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Cache TouchDown HitTestResult to avoid calling RenderLayer::hitTest unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=99649

Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-10-23
Reviewed by George Staikos.

Random latency before scroll starts on sites like http://pintrest.com
Internal PR225398

The chief problem here is the all the hit testing that we do for
touch events and simulated mouse events. If the render tree is dirty
hit tests can take a long time in Document::recalcStyle(). Masking
the flags that force style recalculations will make them fast, at the
expense that they might be happening on stale data.

Since we are only using these hit tests to look for event handlers -
we're not actually modifying anything, it is better to skip the
Document::recalcStyle() and save ourselves tons of time.

  • Api/InRegionScroller.cpp:

(BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPage::touchEvent):
(BlackBerry::WebKit::WebPagePrivate::setScrollOriginPoint):
(BlackBerry::WebKit::WebPagePrivate::postponeDocumentStyleRecalc):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::resumeDocumentStyleRecalc):
(BlackBerry::WebKit::WebPagePrivate::hitTestResult):
(BlackBerry::WebKit::WebPagePrivate::clearCachedHitTestResult):

  • Api/WebPage_p.h:

(WebPagePrivate):

  • WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::findBestPoint):
(BlackBerry::WebKit::FatFingers::getRelevantInfoFromCachedHitTest):

  • WebKitSupport/FatFingers.h:
  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):

3:55 PM Rebaseline edited by dpranke@chromium.org
update to new TestExpectations syntax (diff)
3:46 PM Changeset in webkit [132278] by leviw@chromium.org
  • 1 edit
    47 adds in trunk/LayoutTests

The rest of the baselines have landed! Should green the Mac bots for MathML after r132264.

  • platform/chromium-mac-lion/mathml: Added.
  • platform/chromium-mac-lion/mathml/presentation: Added.
  • platform/chromium-mac-lion/mathml/presentation/attributes-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/fenced-mi-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/fractions-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/fractions-vertical-alignment-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/mo-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/mo-stretch-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/mroot-pref-width-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/over-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/roots-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/row-alignment-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/row-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/style-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/sub-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/subsup-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/subsup-expected.txt: Added.
  • platform/chromium-mac-lion/mathml/presentation/sup-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/tables-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/tokenElements-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/under-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/underover-expected.png: Added.
  • platform/chromium-mac-lion/mathml/xHeight-expected.png: Added.
  • platform/chromium-mac/mathml: Added.
  • platform/chromium-mac/mathml/presentation: Added.
  • platform/chromium-mac/mathml/presentation/attributes-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/fenced-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/fenced-mi-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/fractions-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/fractions-vertical-alignment-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/mo-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/mo-stretch-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/mroot-pref-width-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/over-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/roots-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/row-alignment-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/row-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/style-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/sub-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/subsup-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/subsup-expected.txt: Added.
  • platform/chromium-mac/mathml/presentation/sup-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/tables-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/tokenElements-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/under-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/underover-expected.png: Added.
  • platform/chromium-mac/mathml/xHeight-expected.png: Added.
3:36 PM Changeset in webkit [132277] by leviw@chromium.org
  • 1 edit
    44 adds in trunk/LayoutTests

Unreviewed gardening. Updating expectations after r132264.

  • platform/chromium-mac-snowleopard/mathml: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/attributes-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/attributes-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/fenced-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/fenced-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/fenced-mi-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/fenced-mi-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/fractions-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/fractions-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/fractions-vertical-alignment-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/fractions-vertical-alignment-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/mo-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/mo-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/mo-stretch-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/mo-stretch-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/mroot-pref-width-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/mroot-pref-width-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/over-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/over-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/roots-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/roots-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/row-alignment-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/row-alignment-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/row-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/row-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/style-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/style-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/sub-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/sub-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/subsup-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/subsup-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/sup-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/sup-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/tables-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/tables-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/tokenElements-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/tokenElements-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/under-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/under-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/underover-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/underover-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/xHeight-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/xHeight-expected.txt: Added.
3:22 PM Changeset in webkit [132276] by Simon Fraser
  • 24 edits
    3 adds in trunk

Allow tests to run with a tile cache, and optionally dump the tile cache via layerTreeAsText()
https://bugs.webkit.org/show_bug.cgi?id=100159

Reviewed by Tim Horton.

Source/WebCore:

Add a LAYER_TREE_INCLUDES_PAGE_TILE_CACHE flag for layerTreeAsText(), and plumb it
through to GraphicsLayerCA, which dumps the TiledBacking tile coverage rect.

Test: platform/mac/tiled-drawing/use-tiled-drawing.html

  • page/Frame.h:
  • platform/graphics/GraphicsLayer.cpp:

(showGraphicsLayerTree):

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::tiledBacking):

  • platform/graphics/TiledBacking.h:
  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::tiledBacking):
(WebCore::GraphicsLayerCA::dumpAdditionalProperties):

  • platform/graphics/ca/GraphicsLayerCA.h:

(GraphicsLayerCA):

  • platform/graphics/ca/mac/TileCache.h:

(WebCore::TileCache::tileCoverageRect):
(TileCache):

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::computeTileCoverageRect):
(WebCore::TileCache::revalidateTiles):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::layerTreeAsText):

  • testing/Internals.cpp:

(WebCore::Internals::layerTreeAsText):

  • testing/Internals.h:
  • testing/Internals.idl:

Tools:

Make WebKitTestRunner use a WKView with a tile cache for tests run in a directory
whose path includes "tiled-drawing". It does this by passing around a WKDictionary
of options, and if the current PlatformWebView doesn't support those options, it will
create a new one.

  • WebKitTestRunner/PlatformWebView.h:

(PlatformWebView): Add a WKDictionaryRef options dictionary argument.
(WTR::PlatformWebView::viewSupportsOptions): Returns true if the view
supports the options in the WKDictionaryRef.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize): Call createWebViewWithOptions() with
no options in the normal case.
(WTR::TestController::createWebViewWithOptions): Moved code into this fuction
so we can call it in two places.
(WTR::TestController::ensureViewSupportsOptions): If the current view
doesn't support the given options, throw it away and makea new one that does.

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::shouldUseTiledDrawing): Return true if the directory contains "tiled-drawing".
(WTR::updateTiledDrawingForCurrentTest): Tell the TestController to check whether
the view supports the given options. No-op for non-Mac platforms.
(WTR::TestInvocation::invoke): Call updateTiledDrawingForCurrentTest().

  • WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

(WTR::PlatformWebView::PlatformWebView): New constructor parameter.

  • WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:

(WTR::PlatformWebView::PlatformWebView): New constructor parameter.

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:useTiledDrawing:]):
(-[TestRunnerWKView _shouldUseTiledDrawingArea]): Subclass the WKView so we can return
a custom value from this method.
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::viewSupportsOptions):

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::PlatformWebView): New constructor parameter.

  • WebKitTestRunner/win/PlatformWebViewWin.cpp:

(WTR::PlatformWebView::PlatformWebView): New constructor parameter.

LayoutTests:

A new test that dumps tile cache data for a large page.

  • platform/mac/tiled-drawing/use-tiled-drawing-expected.txt: Added.
  • platform/mac/tiled-drawing/use-tiled-drawing.html: Added.
3:19 PM Changeset in webkit [132275] by noam.rosenthal@nokia.com
  • 20 edits in trunk/Source

Coordinated Graphics: Enable threaded/IPC animations
https://bugs.webkit.org/show_bug.cgi?id=93146

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Add enablers to TextureMapper and GraphicsLayerAnimation so that they could be used
across processes with IPC. Added some public accessors to GraphicsLayerAnimation,
and allowed a GraphicsLayerTextureMapper to receive a full list of animations.

Covered by existing animation and compositing tests.

  • platform/graphics/GraphicsLayerAnimation.cpp:

(WebCore::GraphicsLayerAnimation::GraphicsLayerAnimation):

Initialize the animation with the startTime instead of the offset.

(WebCore::GraphicsLayerAnimations::getActiveAnimations):

  • platform/graphics/GraphicsLayerAnimation.h:

(WebCore::GraphicsLayerAnimation::setState):

Allow setting the pause time as well.

(WebCore::GraphicsLayerAnimation::boxSize):
(WebCore::GraphicsLayerAnimation::startTime):
(WebCore::GraphicsLayerAnimation::pauseTime):
(WebCore::GraphicsLayerAnimation::animation):
(WebCore::GraphicsLayerAnimation::keyframes):
(WebCore::GraphicsLayerAnimation::listsMatch):
(WebCore::GraphicsLayerAnimations::size):
(WebCore::GraphicsLayerAnimations::animations):

Add public accessors to GraphicsLayerAnimation properties.

(GraphicsLayerAnimation):
(GraphicsLayerAnimations):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::addAnimation):
(WebCore::GraphicsLayerTextureMapper::setAnimations):

Allow replacing the entire list of animations.

(WebCore):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:

(GraphicsLayerTextureMapper):

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::applyAnimationsRecursively):
(WebCore):

  • platform/graphics/texmap/TextureMapperLayer.h:

(TextureMapperLayer):

Source/WebKit2:

Re-enable UI-process animations for Coordinated-Graphics/TextureMapper.

  • Added an argument coder for GraphicsLayerAnimations.
  • Allow LayerTreeCoordinator to manage the animations per layer with the proxy, as opposed to applying the animation values in the web process as before.
  • LayerTreeRenderer now calls updateViewport() after painting when an animation is active.

To overcome the problem we've had in the past with synchronizing UI-side and web-side
animations, we now lock the animations in the UI process when a frame starts rendering,
and unlock it when the frame finishes rendering, or if after the layout there is no visible
changes pending on the screen.

  • Scripts/webkit2/messages.py:

(headers_for_type):

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(CoreIPC):
(CoreIPC::encodeTimingFunction):
(CoreIPC::decodeTimingFunction):
(CoreIPC::::encode):
(CoreIPC::::decode):

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:

(WebCore):

Added argument coders for GraphicsLayerAnimations.

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:

(WebKit::LayerTreeCoordinatorProxy::setLayerAnimations):
(WebKit::LayerTreeCoordinatorProxy::setAnimationsLocked):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h:

(LayerTreeCoordinatorProxy):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.messages.in:

Added an option to sync the layer's animations, and also to lock/unlock animations.

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::LayerTreeRenderer):
(WebKit::LayerTreeRenderer::paintToCurrentGLContext):

Sync animations if they're not locked, and call updateViewport() if we have animations.

(WebKit::LayerTreeRenderer::flushLayerChanges):
(WebKit::LayerTreeRenderer::setLayerAnimations):
(WebKit::LayerTreeRenderer::setAnimationsLocked):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:

(LayerTreeRenderer):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::didChangeAnimations):
(WebCore::CoordinatedGraphicsLayer::setShouldUpdateVisibleRect):
(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::syncLayerState):
(WebCore::CoordinatedGraphicsLayer::syncAnimations):
(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):
(WebCore::CoordinatedGraphicsLayer::addAnimation):
(WebCore::CoordinatedGraphicsLayer::pauseAnimation):
(WebCore::CoordinatedGraphicsLayer::removeAnimation):
(WebCore::CoordinatedGraphicsLayer::animationStartedTimerFired):
(WebCore):

Pass the animation info to the UI process instead of applying it in the web process.

(WebCore::CoordinatedGraphicsLayer::hasPendingVisibleChanges):

Compute whether a layer tree might have sync issues or flickers if rendered while
background animations are ongoing.

(WebCore::CoordinatedGraphicsLayer::computeTransformedVisibleRect):
(WebCore::CoordinatedGraphicsLayer::selfOrAncestorHaveNonAffineTransforms):

Don't allow progressive tiling for layers with animations.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:

(WebCore):
(CoordinatedGraphicsLayerClient):
(CoordinatedGraphicsLayer):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::lockAnimations):
(WebKit):
(WebKit::LayerTreeCoordinator::unlockAnimations):
(WebKit::LayerTreeCoordinator::performScheduledLayerFlush):
(WebKit::LayerTreeCoordinator::setLayerAnimations):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

3:11 PM Changeset in webkit [132274] by crogers@google.com
  • 7 edits
    2 moves in trunk

Change setTargetValueAtTime() to setTargetAtTime()
https://bugs.webkit.org/show_bug.cgi?id=100153

Reviewed by Adam Barth.

Source/WebCore:

The AudioParam method name has changed due to Web Audio API spec review.
Keep legacy support for the old name.

Test: webaudio/audioparam-setTargetAtTime.html

  • Modules/webaudio/AudioParam.h:

(WebCore::AudioParam::setTargetAtTime):

  • Modules/webaudio/AudioParam.idl:
  • Modules/webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::setTargetAtTime):
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl):

  • Modules/webaudio/AudioParamTimeline.h:

(AudioParamTimeline):

LayoutTests:

  • webaudio/audioparam-setTargetAtTime-expected.txt: Renamed from LayoutTests/webaudio/audioparam-setTargetValueAtTime-expected.txt.
  • webaudio/audioparam-setTargetAtTime.html: Renamed from LayoutTests/webaudio/audioparam-setTargetValueAtTime.html.
  • webaudio/resources/audioparam-testing.js:
3:03 PM Changeset in webkit [132273] by zoltan@webkit.org
  • 3 edits in trunk/PerformanceTests

Add measurePageLoadTime function to PerfTestRunner
https://bugs.webkit.org/show_bug.cgi?id=100029

Reviewed by Ryosuke Niwa.

Adopt chunk based loading logic from html5-full-render.html into measurePageLoadTime function,
this is needed to measure the performance and the memory consumption of the PageLoadTests as
we do it for all other performancetests.

  • Parser/html5-full-render.html: Move the behavior to runner.js.
  • resources/runner.js:

(.): Add measurePageLoadTime function.

3:02 PM Changeset in webkit [132272] by benjamin@webkit.org
  • 6 edits in trunk/Source/WebCore

[Mac] Remove extraneous conversion to String->NSString
https://bugs.webkit.org/show_bug.cgi?id=100044

Reviewed by Darin Adler.

Improve some unfortunate use of String->NSString.

  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postPlatformNotification): The variable macNotification is ultimately
needed as NSString, and all its value are or can be NSString.
Convert the last 3 char* values to NSString literal and use NSString* all the way.

  • loader/mac/LoaderNSURLExtras.h:
  • loader/mac/LoaderNSURLExtras.mm:

(suggestedFilenameWithMIMEType):
We converted the String to NSString to pass to suggestedFilenameWithMIMEType. There is no need
for the string to be a NSSTring there, we can leave it in its original type.

The case checking for a nil MIMEType was dead code because the implicit conversion never returns nil.

  • platform/mac/DragImageMac.mm:

(WebCore::createDragImageForLink):
Use String's nsStringNilIfEmpty().

  • platform/mac/HTMLConverter.mm:

(-[WebHTMLConverter _addAttachmentForElement:URL:needsParagraph:usePlaceholder:]):
Fix the coding style. Do the conversion to NSString only when needed.

2:49 PM Changeset in webkit [132271] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

[Win] Popup menus positioning needs to take multiple monitors into account.
https://bugs.webkit.org/show_bug.cgi?id=100158

Reviewed by Timothy Horton.

Add screen.x() to repositioning check to account for position of current monitor.

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::calculatePositionAndSize):

2:45 PM Changeset in webkit [132270] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[CSS Shaders] Set FilterOperations on GraphicsLayer after the program of CSS Shaders is loaded.
https://bugs.webkit.org/show_bug.cgi?id=99908

Patch by Huang Dongsung <luxtella@company100.net> on 2012-10-23
Reviewed by Dean Jackson.

CSS Shaders can not render anything until the program is loaded. If there is
partial loaded shaders program, whole FilterOperations chain can not render
anything. It occurs a flash. So We have to wait until the program is loaded, to
prevent a flash as RenderLayerBacking::updateImageContents() waits until an
image is fully loaded.

No new tests, CSS Shaders on Accelerated Compositing are not activated yet.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateFilters):

2:40 PM Changeset in webkit [132269] by commit-queue@webkit.org
  • 9 edits
    6 adds
    20 deletes in trunk

Generated should not be supported for things with a shadow
https://bugs.webkit.org/show_bug.cgi?id=98836

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-10-23
Reviewed by Dimitri Glazkov.

Source/WebCore:

As far as CSS is concerned inputs and things with shadow content inside
shouldn't support pseudo elements like :before, :after or :first-letter.
Neither Gecko or Presto supports it, and we only accidentally supported
it.

Until the spec tells us what to do we should disable support. This is
also neccesary because the new generated content implementation doesn't
support shadows.

Test: fast/forms/pseudo-elements.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetter):

  • rendering/RenderListBox.h: Added missing canHaveGeneratedChildren() that returns false.
  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::updateBeforeAfterContent):

LayoutTests:

Change all pseudos on <input> tests to be ref tests and clean up the tests.
They now make sure we don't support generated content on things with a shadow.
Also added another test for the other form control types to ensure they don't
support pseudos either.

  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.html: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements.html:
  • fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.html: Added.
  • fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements.html:
  • fast/forms/pseudo-elements-expected.html: Added.
  • fast/forms/pseudo-elements.html: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.html: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html:
  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.html: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements.html:
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
2:34 PM Changeset in webkit [132268] by commit-queue@webkit.org
  • 5 edits in trunk

[CSS Shaders] Implement overlay, color-dodge, color-burn, hard-light, soft-light blend modes.
https://bugs.webkit.org/show_bug.cgi?id=98504

Patch by Huang Dongsung <luxtella@company100.net> on 2012-10-23
Reviewed by Dean Jackson.

Source/WebCore:

Add expressions for the aforementioned blend modes. The expressions are lifted
directly from the CSS Compositing and Blending spec [1]. WebKit adds these
blending expressions to the author's shader.

[1]: https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#blendingnormal

Test: css3/filters/custom/custom-filter-blend-modes.html

  • platform/graphics/filters/CustomFilterValidatedProgram.cpp:

(WebCore::CustomFilterValidatedProgram::rewriteMixFragmentShader):
(WebCore::CustomFilterValidatedProgram::blendFunctionString):

LayoutTests:

Update the test for the aforementioned blend modes.

  • css3/filters/custom/custom-filter-blend-modes-expected.html:
  • css3/filters/custom/custom-filter-blend-modes.html:
2:31 PM Changeset in webkit [132267] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

[CSS Shaders] Implement all composite operators except destination and lighter.
https://bugs.webkit.org/show_bug.cgi?id=97859

Patch by Huang Dongsung <luxtella@company100.net> on 2012-10-23
Reviewed by Dean Jackson.

Source/WebCore:

Add expressions for all composite operators except destination and
lighter. The expressions are lifted directly from the CSS Compositing
and Blending spec [1]. WebKit adds these compositing expressions to the
author's shader.

[1]: https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#advancedcompositing

Test: css3/filters/custom/custom-filter-composite-operators.html

  • platform/graphics/filters/CustomFilterCompiledProgram.cpp:

(WebCore::CustomFilterCompiledProgram::initializeParameterLocations):

Remove ASSERTION checking if glGetUniformLocation returns negative,
because ASSERTION can fail with clear and copy composite operations.
Clear and copy composite operations do not need "css_u_texture"
representing the DOM element texture. If the driver compiler is
smart, "css_u_texture" is not regarded as an active uniform, so
glGetuniformLocation returns -1. glGetAttribLocation ditto.

  • platform/graphics/filters/CustomFilterValidatedProgram.cpp:

(WebCore::CustomFilterValidatedProgram::compiledProgram):

Move the above ASSERTION in CustomFilterCompiledProgram to here.
ASSERTION checks if m_samplerLocation is not -1 when the author
shader needs an input texture.

(WebCore::CustomFilterValidatedProgram::needsInputTexture):
(WebCore):
(WebCore::CustomFilterValidatedProgram::compositeFunctionString):

  • platform/graphics/filters/CustomFilterValidatedProgram.h:

(CustomFilterValidatedProgram):

LayoutTests:

Add test to check that the DOM element texture composites correctly with the css_MixColor
variable from the author's shader for each composite operator.

  • css3/filters/custom/custom-filter-composite-operators-expected.png: Added.
  • css3/filters/custom/custom-filter-composite-operators-expected.txt: Added.
  • css3/filters/custom/custom-filter-composite-operators.html: Added.
2:24 PM Changeset in webkit [132266] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

[CSS Shaders] Changing the blend mode in CSS doesn't update the custom filter rendering
https://bugs.webkit.org/show_bug.cgi?id=99887

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-10-23
Reviewed by Dirk Schulze.

Source/WebCore:

Before this patch, WebKit would not recompute an element's style when just its custom filter
blend mode changed.

For example, suppose an element initially has the style:
-webkit-filter: custom(none mix(url(shader.fs) multiply source-atop));

Then, we change the blend mode from "multiply" to "normal":
-webkit-filter: custom(none mix(url(shader.fs) normal source-atop));

WebKit now detects this change and recomputes the style.

CustomFilterProgram now has an equals operator that considers the program type and the mix
settings. The mix settings contain the blend mode.

Test: css3/filters/custom/custom-filter-change-blend-mode.html

  • platform/graphics/filters/CustomFilterProgram.cpp:

(WebCore::CustomFilterProgram::operator==):

Previously, the equals operator was pure virtual in CustomFilterProgram. Now,
CustomFilterProgram implements it and compares the program type and mix settings, if
appropriate.

(WebCore):

  • platform/graphics/filters/CustomFilterProgram.h:
  • platform/graphics/filters/CustomFilterProgramInfo.cpp:

(WebCore::CustomFilterProgramInfo::hash):

Refactor a repeated condition into a boolean to improve readability.

(WebCore::CustomFilterProgramInfo::operator==):

Refactor repeated conditions to improve readability. Reorder the conditions so the less
expensive ones occur first.

  • rendering/style/StyleCustomFilterProgram.h:

(WebCore::StyleCustomFilterProgram::operator==):

Call the base class's equals operator.

LayoutTests:

Add a test that resolves a custom filter's style with the "multiply" blend mode and then
changes the blend mode to "normal". The test makes sure not to change any other parameters
besides the blend mode, since the other parameters can trigger style recalculations on their
own.

  • css3/filters/custom/custom-filter-change-blend-mode-expected.html: Added.
  • css3/filters/custom/custom-filter-change-blend-mode.html: Added.
2:21 PM Changeset in webkit [132265] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

[WebGL] conformance/textures/texture-size.html is failing on Apple Mountain Lion
https://bugs.webkit.org/show_bug.cgi?id=94041

Reviewed by Dean Jackson.

When binding a texture to GL_TEXTURE_2D when GL_ACTIVE_TEXTURE is 0, we set m_boundTexture0 to the texture unit.
However when we delete the texture, we need to be setting m_boundTexture0 to 0.
Otherwise when we draw to the screen we bind m_boundTexture0 in the prepareTexture() method and since the associated texture
has already been deleted we end up in an error state.

Tested using Khronos WebGL conformance suite:
conformance/textures/texture-size.html

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::deleteTexture):

2:14 PM Changeset in webkit [132264] by Dave Barton
  • 55 edits in trunk

[MathML] Symbol font uses greek letters for roman ones on linux and Windows
https://bugs.webkit.org/show_bug.cgi?id=99921

Reviewed by Eric Seidel.

Source/WebCore:

For parts of stretched parentheses and brackets, mathml.css currently uses the Symbol font,
which on linux and Windows has greek letters at roman code points. To fix this, we switch
to the STIXSizeOneSym font when available. However, this can cause vertical gaps between
glyph parts, because of hard-coded constants in RenderMathMLOperator.cpp. We eliminate all
these constants. We also shift glyphs upward by 1px and truncate them to avoid the gaps.

Tested by existing tests, and one test added to LayoutTests/mathml/presentation/mo.xhtml.

  • css/mathml.css:

(math, mfenced > *):

  • Set font-family for mn, mi, etc.

(mo, mfenced):

  • Set font-family for mo and anonymous operators, including extension glyphs for stretched operators like parentheses and brackets.

(math):

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore):

  • Change 0x23d0 to 0x23aa for STIX & Cambria Math fonts.

(WebCore::RenderMathMLOperator::glyphHeightForCharacter):
(WebCore::RenderMathMLOperator::updateFromElement):
(WebCore::RenderMathMLOperator::createStackableStyle):

  • Eliminate unused lineHeight and topRelative parameters, and the hard-coded font size of 14.

(WebCore::RenderMathMLOperator::createGlyph):

  • Eliminate unused lineHeight and topRelative parameters.
  • rendering/mathml/RenderMathMLOperator.h:

(RenderMathMLOperator):

Tools:

Enable the STIXSizeOneSym font for testing.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(allowedFontFamilySet):

  • WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:

(WTR::allowedFontFamilySet):

LayoutTests:

  • mathml/presentation/mo.xhtml:
  • platform/chromium/TestExpectations:
  • platform/chromium/mathml/presentation/attributes-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/attributes-expected.txt:
  • platform/chromium/mathml/presentation/fenced-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/fenced-expected.txt:
  • platform/chromium/mathml/presentation/fenced-mi-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/fenced-mi-expected.txt:
  • platform/chromium/mathml/presentation/fractions-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/fractions-expected.txt:
  • platform/chromium/mathml/presentation/fractions-vertical-alignment-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/chromium/mathml/presentation/mo-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/mo-expected.txt:
  • platform/chromium/mathml/presentation/mo-stretch-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/mo-stretch-expected.txt:
  • platform/chromium/mathml/presentation/mroot-pref-width-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/mroot-pref-width-expected.txt:
  • platform/chromium/mathml/presentation/over-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/over-expected.txt:
  • platform/chromium/mathml/presentation/roots-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/roots-expected.txt:
  • platform/chromium/mathml/presentation/row-alignment-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/row-alignment-expected.txt:
  • platform/chromium/mathml/presentation/row-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/row-expected.txt:
  • platform/chromium/mathml/presentation/style-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/style-expected.txt:
  • platform/chromium/mathml/presentation/sub-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/sub-expected.txt:
  • platform/chromium/mathml/presentation/subsup-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/subsup-expected.txt:
  • platform/chromium/mathml/presentation/sup-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/sup-expected.txt:
  • platform/chromium/mathml/presentation/tables-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/tables-expected.txt:
  • platform/chromium/mathml/presentation/tokenElements-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/tokenElements-expected.txt:
  • platform/chromium/mathml/presentation/under-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/under-expected.txt:
  • platform/chromium/mathml/presentation/underover-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/underover-expected.txt:
  • platform/chromium/mathml/xHeight-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/xHeight-expected.txt:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
2:11 PM Changeset in webkit [132263] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Properly skipping http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout*
tests, as was the author's intention.

  • platform/chromium/TestExpectations:
2:09 PM Changeset in webkit [132262] by tony@chromium.org
  • 2 edits in trunk/Tools

[chromium] Chromium window build system does not rebuild correctly when enabling/disabling a feature
https://bugs.webkit.org/show_bug.cgi?id=38926

Reviewed by Eric Seidel.

Remove hack for clobbering build when features.gypi changes. Now that
Chromium requires VS2010 or newer, this bug has gone away.

  • Scripts/update-webkit:
2:09 PM Changeset in webkit [132261] by benjamin@webkit.org
  • 5 edits in trunk/Source

WTFURL: Implement KURL::setPort()
https://bugs.webkit.org/show_bug.cgi?id=99898

Reviewed by Adam Barth.

Source/WebCore:

  • platform/KURLWTFURL.cpp:

(WebCore::KURL::setPort):

Source/WTF:

Add an efficient implementation for remplacing the port component
in an URL. This will be the base for replacing other components
efficiently.

The testing is covered by fast/dom/HTMLAnchorElement/set-href-attribute-port.html

  • wtf/url/api/ParsedURL.cpp:

(WTF::generateNewSpecWithPort):
(WTF::replacePortWithString):
(WTF::ParsedURL::replacePort):

  • wtf/url/api/ParsedURL.h:

(ParsedURL):

2:05 PM Changeset in webkit [132260] by thakis@chromium.org
  • 5 edits in trunk/Source/WebCore

In the open-source jpeg decoder, read image orientation from the exif data
https://bugs.webkit.org/show_bug.cgi?id=100144

Reviewed by Eric Seidel.

This will be used to implement the shouldRespectImageOrientation
setting (see bug 19688). Currently this isn't hooked up anywhere, so
it has no observable effect for now.

Once it's hooked up, it will be tested by
fast/images/exif-orientation.html

  • platform/graphics/BitmapImage.h:
  • platform/image-decoders/ImageDecoder.h:

(WebCore::ImageDecoder::orientation):
(ImageDecoder):

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::readUint16):
(WebCore):
(WebCore::readUint32):
(WebCore::checkExifHeader):
(WebCore::readImageOrientation):
(WebCore::JPEGImageReader::JPEGImageReader):
(WebCore::JPEGImageReader::decode):

  • platform/image-decoders/jpeg/JPEGImageDecoder.h:

(WebCore::JPEGImageDecoder::setOrientation):

2:02 PM Changeset in webkit [132259] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

Fix thread safety issue in AudioParamTimeline
https://bugs.webkit.org/show_bug.cgi?id=100154

Reviewed by Kenneth Russell.

Add appropriate locking in AudioParamTimeline::valueForContextTime()

  • Modules/webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::valueForContextTime):

1:25 PM Changeset in webkit [132258] by alecflett@chromium.org
  • 14 edits in trunk/Source

IndexedDB: refactor backend to use IDB*Metadata
https://bugs.webkit.org/show_bug.cgi?id=100055

Reviewed by Tony Chang.

Source/WebCore:

This further encapsulates the static data in
IDBObjectStoreBackendImpl and IDBIndexBackendImp into their
respective IDB*Metadata structs, in preparation for
https://bugs.webkit.org/show_bug.cgi?id=99774.

No new tests as this is purely a refactor.

  • Modules/indexeddb/IDBBackingStore.h:

(IDBBackingStore):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::loadObjectStores):

  • Modules/indexeddb/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::IDBIndexBackendImpl):
(WebCore::IDBIndexBackendImpl::metadata):

  • Modules/indexeddb/IDBIndexBackendImpl.h:

(WebCore::IDBIndexBackendImpl::create):
(WebCore::IDBIndexBackendImpl::id):
(WebCore::IDBIndexBackendImpl::setId):
(WebCore::IDBIndexBackendImpl::hasValidId):
(WebCore::IDBIndexBackendImpl::name):
(WebCore::IDBIndexBackendImpl::keyPath):
(WebCore::IDBIndexBackendImpl::unique):
(WebCore::IDBIndexBackendImpl::multiEntry):
(IDBIndexBackendImpl):

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::getObjectStores):
(WebCore::IDBLevelDBBackingStore::getIndexes):

  • Modules/indexeddb/IDBLevelDBBackingStore.h:

(IDBLevelDBBackingStore):

  • Modules/indexeddb/IDBMetadata.h:

(WebCore::IDBObjectStoreMetadata::IDBObjectStoreMetadata):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl):
(WebCore::IDBObjectStoreBackendImpl::metadata):
(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::loadIndexes):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(WebCore::IDBObjectStoreBackendImpl::create):
(WebCore::IDBObjectStoreBackendImpl::id):
(WebCore::IDBObjectStoreBackendImpl::setId):
(WebCore::IDBObjectStoreBackendImpl::name):
(WebCore::IDBObjectStoreBackendImpl::keyPath):
(WebCore::IDBObjectStoreBackendImpl::autoIncrement):
(IDBObjectStoreBackendImpl):

Source/WebKit/chromium:

Update tests to reflect refactoring.

  • tests/IDBDatabaseBackendTest.cpp:
  • tests/IDBFakeBackingStore.h:
1:17 PM Changeset in webkit [132257] by krit@webkit.org
  • 3 edits
    2 adds in trunk

BasicShapePolygon::path takes width instead of height for boundary calculation
https://bugs.webkit.org/show_bug.cgi?id=99919

Reviewed by Darin Adler.

Source/WebCore:

The 'y' parameters of polygon were calculated by the with of the bounding box of the object.
This caused problems on percentage values for point positions.
Changed it to the height of the bounding box.

Test: css3/masking/clip-path-polygon-percentage.html

  • rendering/style/BasicShapes.cpp:

(WebCore::BasicShapePolygon::path):

LayoutTests:

Test that the correct relation is used for calculating point position of an polygon.

  • css3/masking/clip-path-polygon-percentage-expected.html: Added.
  • css3/masking/clip-path-polygon-percentage.html: Added.
12:44 PM Changeset in webkit [132256] by commit-queue@webkit.org
  • 2 edits in trunk/Source/Platform

[Chromium] Add CHROMIUM_texture_from_image extension support.
https://bugs.webkit.org/show_bug.cgi?id=99894

Patch by David Reveman <reveman@chromium.org> on 2012-10-23
Reviewed by James Robinson.

Add bindTexImage2DCHROMIUM and releaseTexImage2DCHROMIUM prototypes to
WebGraphicsContext3D.h.

  • chromium/public/WebGraphicsContext3D.h:

(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::bindTexImage2DCHROMIUM):
(WebKit::WebGraphicsContext3D::releaseTexImage2DCHROMIUM):

12:40 PM Changeset in webkit [132255] by Lucas Forschler
  • 2 edits in tags/Safari-537.15.2/Source/WebKit2

Hand merge fix for:
<rdar://problem/12530687>


  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess):

12:14 PM Changeset in webkit [132254] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Roll chromium DEPS r163297:163557
https://bugs.webkit.org/show_bug.cgi?id=100146

Reviewed by Adrienne Walker.

12:12 PM Changeset in webkit [132253] by dpranke@chromium.org
  • 1 edit
    33 deletes in trunk/LayoutTests

Remove remaining fast/innerHTML pixel test baselines after r131960.

Unreviewed, expectations change.

  • platform/chromium-linux/fast/innerHTML/002-expected.png: Removed.
  • platform/chromium-linux/fast/innerHTML/003-expected.png: Removed.
  • platform/chromium-linux/fast/innerHTML/006-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/innerHTML/001-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/innerHTML/002-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/innerHTML/003-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/innerHTML/006-expected.png: Removed.
  • platform/chromium-mac/fast/innerHTML/001-expected.png: Removed.
  • platform/chromium-mac/fast/innerHTML/002-expected.png: Removed.
  • platform/chromium-mac/fast/innerHTML/003-expected.png: Removed.
  • platform/chromium-mac/fast/innerHTML/006-expected.png: Removed.
  • platform/chromium-win/fast/innerHTML/001-expected.png: Removed.
  • platform/chromium-win/fast/innerHTML/001-expected.txt: Removed.
  • platform/chromium-win/fast/innerHTML/002-expected.txt: Removed.
  • platform/chromium-win/fast/innerHTML/003-expected.txt: Removed.
  • platform/chromium-win/fast/innerHTML/006-expected.txt: Removed.
  • platform/efl/fast/innerHTML/001-expected.txt: Removed.
  • platform/efl/fast/innerHTML/002-expected.txt: Removed.
  • platform/efl/fast/innerHTML/003-expected.txt: Removed.
  • platform/efl/fast/innerHTML/006-expected.txt: Removed.
  • platform/gtk/fast/innerHTML/001-expected.txt: Removed.
  • platform/gtk/fast/innerHTML/002-expected.txt: Removed.
  • platform/gtk/fast/innerHTML/003-expected.txt: Removed.
  • platform/gtk/fast/innerHTML/006-expected.txt: Removed.
  • platform/gtk/fast/innerHTML/innerHTML-iframe-expected.txt: Removed.
  • platform/mac/fast/innerHTML/001-expected.txt: Removed.
  • platform/mac/fast/innerHTML/002-expected.txt: Removed.
  • platform/mac/fast/innerHTML/003-expected.txt: Removed.
  • platform/mac/fast/innerHTML/006-expected.txt: Removed.
  • platform/qt/fast/innerHTML/001-expected.txt: Removed.
  • platform/qt/fast/innerHTML/002-expected.txt: Removed.
  • platform/qt/fast/innerHTML/003-expected.txt: Removed.
  • platform/qt/fast/innerHTML/006-expected.txt: Removed.
11:49 AM Changeset in webkit [132252] by dominik.rottsches@intel.com
  • 13 edits
    25 adds in trunk

Add timeout support to XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=74802

Reviewed by Nate Chapin.

Source/WebCore:

An implementation of XHR2 timeouts by using ResourceRequest's setTimeoutInterval.
This made several changes necessary in CachedResource and SubresourceLoader in order
to distinguish and forward the timeout case from there.

The case of late updates to the timeout property, changing the timeout value after send()
is not supported yet and handled separately in bug 98156.

XHR2 timeout tests were initially written by Mozilla's Alex Vincent's. He granted
permission to reuse them under PD/BSD license
in https://bugzilla.mozilla.org/show_bug.cgi?id=525816#c86 - big thanks!
I adapted them for W3C testharness.js and split them into groups with shorter test running time
so that they can be used as WebKit layout tests.

Tests: http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-aborted.html

http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-abortedonmain.html
http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overridesexpires.html
http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-simple.html
http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-synconmain.html
http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-twice.html
http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-aborted.html
http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-overridesexpires.html
http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-simple.html
http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-synconworker.html
http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-twice.html

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::notifyFinished): Forward information about timeout case.

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didFail): Distinguish timeout case when informing client.

  • loader/cache/CachedResource.h: Distinguishing timeout case for errors.

(WebCore::CachedResource::errorOccurred):
(WebCore::CachedResource::loadFailedOrCanceled):
(WebCore::CachedResource::timedOut):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::XMLHttpRequest): Initializing m_timeout value to zero.
(WebCore::XMLHttpRequest::setTimeout): Setter function, possibly raising JS exception.
(WebCore):
(WebCore::XMLHttpRequest::open): Open call may raise exception for synchronous requests when timeout value is set.
(WebCore::XMLHttpRequest::createRequest): Assigning timeout value to ResourceRequest.
(WebCore::XMLHttpRequest::didFail): Handling timeout case separately.
(WebCore::XMLHttpRequest::didTimeout): Timeout case state transisition and event firing as spec'ed.

  • xml/XMLHttpRequest.h: New event listener, member and callback for handling timeout.

(WebCore::XMLHttpRequest::timeout):
(XMLHttpRequest):

  • xml/XMLHttpRequest.idl: New event listener and property added.
  • xml/XMLHttpRequestException.cpp:
  • xml/XMLHttpRequestException.h: Added an exception value for the timeout case.

LayoutTests:

XHR2 timeout tests were initially written by Mozilla's Alex Vincent's. He granted
permission to reuse them under PD/BSD license
in https://bugzilla.mozilla.org/show_bug.cgi?id=525816#c86 - big thanks!
I adapted them for W3C testharness.js and split them into groups with shorter test running time
so that they can be used as WebKit layout tests. Each individual test should
complete in less than 20 seconds.

The case of late updates to the timeout property, changing the timeout value after send()
is not supported yet and handled separately in bug 98156. Tests that are testing this feature
are commented out until this bug is tackled.

The suffix of the html test filename matches the groups in xmlhttprequest-timeout.js which contains
all tests that are run. The result of assertions is reported back to testharness.js.

For example, the "overrides" group is currently not run yet since all tests in that group are cases
of late updates, see above. Once late updates are supported we can add a file
xmlhttprequest-timeout-overrides.html to run them.

  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-aborted-expected.txt: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-aborted.html: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-abortedonmain-expected.txt: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-abortedonmain.html: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overridesexpires-expected.txt: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overridesexpires.html: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-runner.js: Added. Distinguishes which group of tests to run based on filename suffix.

(testResultCallbackHandler.return):
(groupFromLocation):

  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-simple-expected.txt: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-simple.html: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-synconmain-expected.txt: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-synconmain.html: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-twice-expected.txt: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-twice.html: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-aborted-expected.txt: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-aborted.html: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-overridesexpires-expected.txt: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-overridesexpires.html: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-simple-expected.txt: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-simple.html: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-synconworker-expected.txt: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-synconworker.html: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-twice-expected.txt: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-twice.html: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout.js: Added. Contains test cases for all individual test html files.

(message): Wrapper for postMessage in worker and document context case.
(is),
(ok): Assertion functions.
(RequestTracker): Class for variations of the regular timeout case.
(RequestTracker.prototype.startXHR.handleEvent):
(RequestTracker.prototype.startXHR):
(RequestTracker.prototype.getMessage):
(RequestTracker.prototype.handleEvent):
(AbortedRequest): Class for testing timeout event vs. abort events.
(AbortedRequest.prototype.startXHR.handleEvent):
(AbortedRequest.prototype.startXHR.abortReq):
(AbortedRequest.prototype.startXHR.else):
(AbortedRequest.prototype.startXHR):
(AbortedRequest.prototype.noEventsFired):
(AbortedRequest.prototype.getMessage):
(AbortedRequest.prototype.handleEvent):
(SyncRequestSettingTimeoutAfterOpen.startXHR),
(SyncRequestSettingTimeoutBeforeOpen.startXHR): Test classes for synchronous XHR cases.
(TestCounter.testComplete),
(TestCounter.next): Used for cycling through tests.

  • platform/chromium/TestExpectations: Skipping XHR timeout cases since setTimeoutInterval is not supported in Chromium's HTTP stack.
  • platform/gtk/TestExpectations: Marking XHR timeout cases as slow in order to run them with a longer test timeout threshold.
  • platform/qt/TestExpectations: Skipping XHR timeout cases since setTimeoutInterval is not supported in Chromium's HTTP stack.
11:45 AM Changeset in webkit [132251] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. css3/filters/blur-filter-page-scroll-self.html is crashing
now as well as generating incorrect image results :(

  • platform/chromium/TestExpectations:
11:42 AM Changeset in webkit [132250] by Lucas Forschler
  • 5 edits in tags/Safari-537.15.2/Source/JavaScriptCore

Merged r131791.

11:29 AM Changeset in webkit [132249] by Lucas Forschler
  • 4 edits in tags/Safari-537.15.2/Source

Versioning.

11:29 AM Changeset in webkit [132248] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[WIN7] Skip fast/media/mq-resolution.html.
https://bugs.webkit.org/show_bug.cgi?id=100143.

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-10-23
Reviewed by Kenneth Rohde Christiansen.

The feature is not yet implemented.

  • platform/win/TestExpectations:
11:26 AM Changeset in webkit [132247] by Lucas Forschler
  • 1 copy in tags/Safari-537.15.2

New Tag.

11:22 AM Changeset in webkit [132246] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Possible assertion hit in WebCore::HTMLSelectElement::updateListBoxSelection()
https://bugs.webkit.org/show_bug.cgi?id=99967

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-23
Reviewed by Tony Chang.

Source/WebCore:

Fix assertion hit in WebCore::HTMLSelectElement::updateListBoxSelection() when
pressing the left mouse button outside a multiselect and then moving the cursor
over the multiselect element while holding the button down.

The issue is that the HTMLSelectElement handler for the mouse move event does
not check if there is a selection before trying to extend the selection.

Test: fast/dom/HTMLSelectElement/select-selectedIndex-noAnchorIndex-crash.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):

LayoutTests:

Added layout test to reproduce an assertion hit in
WebCore::HTMLSelectElement::updateListBoxSelection() when pressing the left
button outside a multiselect and then moving the mouse over the multiselect
element while holding the button down.

  • fast/dom/HTMLSelectElement/select-selectedIndex-noAnchorIndex-crash-expected.txt: Added.
  • fast/dom/HTMLSelectElement/select-selectedIndex-noAnchorIndex-crash.html: Added.
11:14 AM Changeset in webkit [132245] by abarth@webkit.org
  • 6 edits in trunk/Source/WebCore

[V8] ScriptWrappable should hold the wrapper handle directly (Dromaeo/dom-modify and dom-traverse get ~2.5% faster)
https://bugs.webkit.org/show_bug.cgi?id=97974

Reviewed by Eric Seidel.

Previously, we stored a pointer to a handle to a wrapper in Node. That
is an extra layer of indirection that slows down finding the wrapper
for the node. A handle is just a pointer, so we might as we just store
the handle in the Node directly. That speeds up dom-modify and
dom-traverse by about 2.5%.

This change also lets us get rid of the ChunkedTable we were using to
store all the wrappers because they're now stored in the Nodes
directly.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

  • bindings/v8/IntrusiveDOMWrapperMap.h:

(WebCore::IntrusiveDOMWrapperMap::IntrusiveDOMWrapperMap):
(WebCore::IntrusiveDOMWrapperMap::get):
(WebCore::IntrusiveDOMWrapperMap::set):
(WebCore::IntrusiveDOMWrapperMap::contains):
(WebCore::IntrusiveDOMWrapperMap::visit):
(WebCore::IntrusiveDOMWrapperMap::removeIfPresent):
(WebCore::IntrusiveDOMWrapperMap::clear):

  • bindings/v8/ScriptWrappable.h:

(WebCore::ScriptWrappable::ScriptWrappable):
(WebCore::ScriptWrappable::wrapper):
(WebCore::ScriptWrappable::setWrapper):
(WebCore::ScriptWrappable::disposeWrapper):
(WebCore::ScriptWrappable::reportMemoryUsage):
(ScriptWrappable):

  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getCachedWrapper):

10:58 AM Changeset in webkit [132244] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Regression(r132143): Assertion hit in JSC::Interpreter::StackPolicy::StackPolicy(JSC::Interpreter&, const WTF::StackBounds&)
https://bugs.webkit.org/show_bug.cgi?id=100109

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-23
Reviewed by Oliver Hunt.

Fix possible integer overflow in StackPolicy constructor by
using size_t type instead of int for stack sizes. The value
returned by StackBounds::size() is of type size_t but was
assigned to an int, which may overflow.

  • interpreter/Interpreter.cpp:

(JSC):
(JSC::Interpreter::StackPolicy::StackPolicy):

10:57 AM Changeset in webkit [132243] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[V8] Replace SetGlobalGCPrologueCallback() with AddGCPrologueCallback()
https://bugs.webkit.org/show_bug.cgi?id=100140

Reviewed by Adam Barth.

SetGlobalGCPrologueCallback() and SetGlobalGCEpilogueCallback()
are deprecated (See http://code.google.com/codesearch#OAMlx_jo-ck/src/v8/include/v8.h&exact_package=chromium&q=v8.h&type=cs&l=3149)
Instead we should use AddGCPrologueCallback()
and AddGCEpilogueCallback().

No tests. No change in behavior.

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::initializeV8IfNeeded):

  • bindings/v8/V8GCController.cpp:

(WebCore::V8GCController::gcPrologue):
(WebCore):
(WebCore::V8GCController::minorGCPrologue):
(WebCore::V8GCController::majorGCPrologue):
(WebCore::V8GCController::gcEpilogue):
(WebCore::V8GCController::minorGCEpilogue):
(WebCore::V8GCController::majorGCEpilogue):

  • bindings/v8/V8GCController.h:

(V8GCController):

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::initIsolate):

10:34 AM Changeset in webkit [132242] by abarth@webkit.org
  • 13 edits in trunk/Source/WebCore

[V8] Enumerate Nodes via the V8 heap rather than via a list in WebCore
https://bugs.webkit.org/show_bug.cgi?id=100033

Reviewed by Eric Seidel.

This patch changes how we enumerate nodes during garbage collection.
After this patch, we use V8's list of open handles to enumerate node
wrappers rather than using a separate list that we maintain in WebCore
for this purpose. A future patch will remove the list in WebCore for a
DOM performance gain.

  • bindings/js/ScriptProfiler.h:

(WebCore):
(WebCore::ScriptProfiler::visitNodeWrappers):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateToV8Converters):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::wrapSlow):

  • bindings/v8/IntrusiveDOMWrapperMap.h:

(WebCore::IntrusiveDOMWrapperMap::set):

  • bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::visitNodeWrappers):

  • bindings/v8/ScriptProfiler.h:

(WebCore):
(ScriptProfiler):

  • bindings/v8/V8DOMMap.cpp:

(WebCore::NodeWrapperVisitor::~NodeWrapperVisitor):
(WebCore):
(WebCore::visitAllDOMNodes):

  • bindings/v8/V8DOMMap.h:

(WebCore):
(NodeWrapperVisitor):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::setJSWrapperForDOMNode):
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMNode):

  • bindings/v8/V8GCController.cpp:

(WebCore::NodeVisitor::visitNodeWrapper):
(WebCore::V8GCController::gcPrologue):
(WebCore::V8GCController::gcEpilogue):

  • inspector/BindingVisitors.h:

(WebCore::WrappedNodeVisitor::~WrappedNodeVisitor):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore):

10:25 AM Changeset in webkit [132241] by jochen@chromium.org
  • 6 edits in trunk/Tools

[chromium] remove the const qualifier from WebTestDelegate::printMessage
https://bugs.webkit.org/show_bug.cgi?id=100082

Reviewed by Adam Barth.

There's no reason the method should be const, and indeed for
content_shell we want to send an IPC which is a non-const operation.

  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebTestDelegate):

  • DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:

(TestDelegate):

  • DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestInterfaces::Internal):
(WebTestRunner::WebTestInterfaces::Internal::printMessage):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::printMessage):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

10:12 AM Changeset in webkit [132240] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Make selection in search input box not overlap cancel button
https://bugs.webkit.org/show_bug.cgi?id=100130

Reviewed by Antonio Gomes.

This ensures that even when selection is active, the user can still press 'cancel'.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::boundingBoxForInputField):

10:06 AM Changeset in webkit [132239] by caseq@chromium.org
  • 11 edits in trunk/Source/WebCore

Web Inspector: paint rectangles are incorrectly shown in case subframes are present
https://bugs.webkit.org/show_bug.cgi?id=99849

Reviewed by Pavel Feldman.

Move GraphicsContext and paint rectangle from willPaint() to didPaint(), so we don't have
to store them as a state of InspectorPageAgent

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::willPaintImpl):
(WebCore::InspectorInstrumentation::didPaintImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willPaint):
(WebCore::InspectorInstrumentation::didPaint):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::didPaint):

  • inspector/InspectorPageAgent.h:
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::willPaint):
(WebCore::InspectorTimelineAgent::didPaint):

  • inspector/InspectorTimelineAgent.h:

(InspectorTimelineAgent):

  • inspector/TimelineRecordFactory.cpp:
  • inspector/TimelineRecordFactory.h:

(TimelineRecordFactory):

  • page/FrameView.cpp:

(WebCore::FrameView::paintContents):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintContents):

10:04 AM Changeset in webkit [132238] by pfeldman@chromium.org
  • 5 edits in trunk

Web Inspector: array grouping does not work for arrays with exactly 10000 elements.
https://bugs.webkit.org/show_bug.cgi?id=100131

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Using ceil() - 1 instead of floor() in bucket size calculation.

  • inspector/front-end/ObjectPropertiesSection.js:

LayoutTests:

  • inspector/console/console-big-array-expected.txt:
  • inspector/console/console-big-array.html:
9:39 AM Changeset in webkit [132237] by shinyak@chromium.org
  • 8 edits
    2 adds in trunk

The order of resolving distribution in tree composition is wrong.
https://bugs.webkit.org/show_bug.cgi?id=99552

Reviewed by Dimitri Glazkov.

Source/WebCore:

According to the current ShadowDOM spec, we have to resolve <content> first, then resolve <shadow>.
However, the order of resolution is now the mixed tree order of <content> and <shadow>.

Test: fast/dom/shadow/content-reprojection-order.html

  • html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistributor::distribute): We should resolve <content> before <shadow>.
Only the first active shadow insertion point can select the rest of contents.

  • html/shadow/HTMLContentElement.h:

(HTMLContentElement):

  • html/shadow/HTMLShadowElement.cpp:
  • html/shadow/HTMLShadowElement.h:

(WebCore::isHTMLShadowElement):
(WebCore):
(WebCore::toHTMLShadowElement):

  • html/shadow/InsertionPoint.h:

(InsertionPoint): We don't need doesSelectFromHostChildren() anymore.

LayoutTests:

We also fix the existing wrong test.

  • fast/dom/shadow/content-reprojection-order-expected.html: Added.
  • fast/dom/shadow/content-reprojection-order.html: Added.
  • fast/dom/shadow/shadow-element-rendering-single.html:
9:33 AM Changeset in webkit [132236] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding failure expectation for fast/media/mq-resolution.html, it relies
on the Resolution Media Query feature being enabled.
Adding a proper bug modifier for fast/files/workers/worker-apply-blob-url-to-xhr.html.

  • platform/gtk/TestExpectations:
9:32 AM Changeset in webkit [132235] by allan.jensen@digia.com
  • 4 edits in trunk/Source/WebKit2

[Qt][WK2] Add preference for enabling scroll animators
https://bugs.webkit.org/show_bug.cgi?id=100124

Reviewed by Jocelyn Turcotte.

Expose the ScollAnimatorEnabled setting in QWebPreferences.

  • UIProcess/API/qt/qwebpreferences.cpp:

(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferences::scrollAnimatorEnabled):
(QWebPreferences::setScrollAnimatorEnabled):

  • UIProcess/API/qt/qwebpreferences_p.h:
  • UIProcess/API/qt/qwebpreferences_p_p.h:
9:25 AM Changeset in webkit [132234] by vsevik@chromium.org
  • 11 edits in trunk

Web Inspector: Move UISourceCode creation out of mappings to workspace.
https://bugs.webkit.org/show_bug.cgi?id=100092

Reviewed by Pavel Feldman.

Source/WebCore:

Moved uiSourceCode constructor calls out of mappings to workspace.

  • inspector/front-end/CompilerScriptMapping.js:
  • inspector/front-end/NetworkUISourceCodeProvider.js:

(WebInspector.NetworkUISourceCodeProvider.prototype._parsedScriptSource):
(WebInspector.NetworkUISourceCodeProvider.prototype._addUISourceCode):

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype._deleteOriginalUISourceCodeForScripts):
(WebInspector.ResourceScriptMapping.prototype._deleteTemporaryUISourceCodeForScripts):
(WebInspector.ResourceScriptMapping.prototype._bindUISourceCodeToScripts):
(WebInspector.ResourceScriptMapping.prototype._createUISourceCode):
(WebInspector.ResourceScriptMapping.prototype._getOrCreateTemporaryUISourceCode):
(WebInspector.ResourceScriptMapping.prototype._getOrCreateOriginalUISourceCode):

  • inspector/front-end/SASSSourceMapping.js:

(_bindUISourceCode):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):

  • inspector/front-end/Workspace.js:

(WebInspector.Project.prototype.addUISourceCode):
(WebInspector.Project.prototype.removeUISourceCode):
(WebInspector.Workspace.prototype.addTemporaryUISourceCode):
(WebInspector.Workspace.prototype.removeTemporaryUISourceCode):

LayoutTests:

  • http/tests/inspector/workspace-test.js:

(initialize_WorkspaceTest.InspectorTest.addMockUISourceCodeToWorkspace):

  • inspector/debugger/resource-script-mapping-expected.txt:
  • inspector/debugger/scripts-panel.html:
9:22 AM Changeset in webkit [132233] by eae@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove unnecessary m_layoutDelta[XY]Saturated initialization
https://bugs.webkit.org/show_bug.cgi?id=100018

Reviewed by Julien Chaffraix.

Remove unnecessary initialization from LayoutState constructor
added in r132105.

No new tests, no change in functionality.

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):

9:18 AM Changeset in webkit [132232] by zeno.albisser@digia.com
  • 4 edits in trunk/Source/WebCore

[Texmap] Fix drawTextureRectangleARB after r131485.
https://bugs.webkit.org/show_bug.cgi?id=100133

Consistently rename u_textureSize to u_samplerSize.

Reviewed by Noam Rosenthal.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::drawTextureRectangleARB):

  • platform/graphics/texmap/TextureMapperShaderManager.cpp:

(WebCore::getShaderSpec):

  • platform/graphics/texmap/TextureMapperShaderManager.h:

(TextureMapperShaderProgram):

9:09 AM Changeset in webkit [132231] by mkwst@chromium.org
  • 4 edits
    2 adds in trunk

Source/WebCore: Web Inspector: 'data:' URLs should be properly trimmed for readability.
https://bugs.webkit.org/show_bug.cgi?id=100083

Reviewed by Pavel Feldman.

We recently landed a patch to trim the middle out of long URLs in
console messages in order to improve readability. That patch didn't
effect 'data:' URLs, as they didn't match the regex in the linkifier.
This patch ensures that 'data:' URLs are properly trimmed down to
size.

This problem came to light while resolving a different, smaller issue:
'image/jpg' wasn't whitelisted as an image MIME type. That trivial fix
is included in this patch.

Test: http/tests/inspector/network/image-as-text-loading-data-url.html

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkManager):

Adds 'image/jpg' as a valid image type.

  • inspector/front-end/ResourceUtils.js:

(WebInspector.linkifyStringAsFragmentWithCustomLinkifier):

Supports 'data:' URLs in the linkifier's regex.

LayoutTests: Web Inspector: MIME type errors should truncate long URLs.
https://bugs.webkit.org/show_bug.cgi?id=100083

Reviewed by Pavel Feldman.

  • http/tests/inspector/network/image-as-text-loading-data-url-expected.txt: Added.
  • http/tests/inspector/network/image-as-text-loading-data-url.html: Added.
9:07 AM Changeset in webkit [132230] by mkwst@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Floated anchor element sometimes overlaps following content.
https://bugs.webkit.org/show_bug.cgi?id=100105

Reviewed by Pavel Feldman.

This patch ensures that each console message clears the
potentially-overlapping floated anchor element.

  • inspector/front-end/inspector.css:

(#console-prompt):
(.console-message, .console-user-command):

Clear the float, and flip the border from the bottom of the
message to the top. Do the same for the prompt.

(.console-message:first-child):

Ensure that the first message doesn't have a top border.

8:57 AM Changeset in webkit [132229] by apavlov@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: Crash when adding a keyframes rule in the Styles pane
https://bugs.webkit.org/show_bug.cgi?id=99826

Reviewed by Pavel Feldman.

Source/WebCore:

The client-supplied selector text is first parsed to make sure it results in a valid style rule selector.

Test: inspector/styles/add-new-rule-invalid-selector.html

  • inspector/InspectorStyleSheet.cpp:

(WebCore::createCSSParser):
(WebCore):
(WebCore::InspectorStyle::setPropertyText):
(WebCore::checkStyleRuleSelector):
(WebCore::InspectorStyleSheet::addRule):
(WebCore::InspectorStyleSheet::ensureSourceData):
(WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):

LayoutTests:

  • inspector/styles/add-new-rule-invalid-selector-expected.txt: Added.
  • inspector/styles/add-new-rule-invalid-selector.html: Added.
8:44 AM Changeset in webkit [132228] by commit-queue@webkit.org
  • 19 edits in trunk/Source/WebKit2

[EFL][WK2] Use the port independent PageViewportController
https://bugs.webkit.org/show_bug.cgi?id=99850

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-10-23
Reviewed by Kenneth Rohde Christiansen.

Take PageViewportController into use, and rely on it to calculate
scroll position and zoom level.
With this patch, we can do intra page navigation and use the scrollwheel
to scroll, when WTF_USE_TILED_BACKING_STORE and all related flags are enabled.

  • CMakeLists.txt:
  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::didChangeViewportProperties):
(WebKit::PageClientImpl::pageDidRequestScroll):
(WebKit::PageClientImpl::didChangeContentsSize):
(WebKit):
(WebKit::PageClientImpl::didRenderFrame):
(WebKit::PageClientImpl::pageTransitionViewportReady):

  • UIProcess/API/efl/PageClientImpl.h:

(WebKit):
(PageClientImpl):
(WebKit::PageClientImpl::setPageViewportController):

  • UIProcess/API/efl/PageViewportControllerClientEfl.cpp:

(WebKit::PageViewportControllerClientEfl::PageViewportControllerClientEfl):
(WebKit::PageViewportControllerClientEfl::display):
(WebKit::PageViewportControllerClientEfl::updateViewportSize):
(WebKit::PageViewportControllerClientEfl::setVisibleContentsRect):
(WebKit::PageViewportControllerClientEfl::didChangeContentsSize):
(WebKit::PageViewportControllerClientEfl::setViewportPosition):
(WebKit::PageViewportControllerClientEfl::setContentsScale):
(WebKit::PageViewportControllerClientEfl::didResumeContent):
(WebKit::PageViewportControllerClientEfl::didChangeVisibleContents):
(WebKit::PageViewportControllerClientEfl::setController):

  • UIProcess/API/efl/PageViewportControllerClientEfl.h:

(WebKit::PageViewportControllerClientEfl::scaleFactor):
(WebKit::PageViewportControllerClientEfl::scrollPosition):
(PageViewportControllerClientEfl):

  • UIProcess/API/efl/ewk_view.cpp:

(Ewk_View_Private_Data):
(mapToWebContent):
(_ewk_view_smart_mouse_wheel):
(_ewk_view_smart_mouse_down):
(_ewk_view_smart_mouse_up):
(_ewk_view_smart_mouse_move):
(_ewk_view_initialize):
(ewk_view_load_committed):
(ewk_view_feed_touch_event):

  • UIProcess/API/efl/ewk_view_private.h:
  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:

(WebKit::LayerTreeCoordinatorProxy::didRenderFrame):

  • UIProcess/PageClient.h:

(PageClient):

  • UIProcess/PageViewportController.cpp:
  • UIProcess/PageViewportController.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit):
(WebKit::WebPageProxy::pageTransitionViewportReady):
(WebKit::WebPageProxy::didRenderFrame):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/efl/PageLoadClientEfl.cpp:

(WebKit):
(WebKit::PageLoadClientEfl::didCommitLoadForFrame):
(WebKit::PageLoadClientEfl::PageLoadClientEfl):

  • UIProcess/efl/PageLoadClientEfl.h:

(PageLoadClientEfl):

  • UIProcess/qt/WebPageProxyQt.cpp:

(WebKit):
(WebKit::WebPageProxy::setUserScripts):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didCompletePageTransition):

8:15 AM Changeset in webkit [132227] by kenneth@webkit.org
  • 33 edits
    2 adds in trunk

Add support for resolution media query
https://bugs.webkit.org/show_bug.cgi?id=99077

Reviewed by Antti Koivisto.

.:

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Add support for the RESOLUTION_MEDIA_QUERY feature flag.

  • Source/autotools/symbols.filter:

Export the WebCore::Settings setting.

Source/WebCore:

Add support for 'resolution' media query feature.

Background info:
http://www.w3.org/blog/CSS/2012/06/14/unprefix-webkit-device-pixel-ratio

Related spec links:
http://www.w3.org/TR/css3-mediaqueries/#resolution (recommendation)
http://www.w3.org/TR/css3-values/#resolution (candidate recommentation)

Add infrastructure to make it testable.

Test: fast/media/mq-resolution.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::validUnit):
(WebCore::CSSParser::createPrimitiveNumericValue):
(WebCore::CSSParser::parseValidPrimitive):
(WebCore::CSSParser::detectNumberToken):

  • css/CSSParser.h:
  • css/CSSPrimitiveValue.cpp:

(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::unitCategory):
(WebCore::CSSPrimitiveValue::canonicalUnitTypeForCategory):
(WebCore::CSSPrimitiveValue::customCssText):
(WebCore::CSSPrimitiveValue::cloneForCSSOM):

  • css/CSSPrimitiveValue.h:

Enable dpi, dpcm and dppx units when RESOLUTION_MEDIA_QUERY
is enabled.

  • WebCore.exp.in:

Export the WebCore::Settings setting.

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::isDotsPerInch):
(WebCore::CSSPrimitiveValue::isDotsPerPixel):
(WebCore::CSSPrimitiveValue::isDotsPerCentimeter):
(CSSPrimitiveValue):

Add function for checking the recently added density types.

  • css/MediaFeatureNames.h:

(MediaFeatureNames):

Add support for resolution, min-resolution and max-resolution.

  • css/MediaQueryEvaluator.cpp:

(WebCore::compareResolution): Add methods for comparing resolutions.
(WebCore):
(WebCore::resolutionMediaFeatureEval):
(WebCore::min_resolutionMediaFeatureEval):
(WebCore::max_resolutionMediaFeatureEval):

Implement the resolution method evaluation.

  • css/MediaQueryExp.cpp:

(WebCore::featureWithValidPositiveDensity):
(WebCore):
(WebCore::featureWithoutValue):
(WebCore::MediaQueryExp::MediaQueryExp):

Hook up resolution with the right pre-checks.

  • page/Screen.cpp:

(WebCore::Screen::horizontalDPI):
(WebCore::Screen::verticalDPI):

Check whether an override exists, and if so, uses it.
If not calculate the value given the device scale factor.

  • page/Settings.cpp:

(WebCore::Settings::setResolutionOverride):
(WebCore):

  • page/Settings.h:

(Settings):
(WebCore::Settings::resolutionOverride):

Add a resolution override to settings.

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setResolutionOverride):
(WebCore):

  • testing/InternalSettings.h:

(Backup):
(InternalSettings):

  • testing/InternalSettings.idl:

Add a new setResolutionOverride method to internals.settings.

Source/WebKit/chromium:

Add support for the RESOLUTION_MEDIA_QUERY feature flag.

  • features.gypi:

Source/WebKit/mac:

Add support for the RESOLUTION_MEDIA_QUERY feature flag.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • win/WebKit2.def:

Add exports for the WebCore::Settings setting.

  • Configurations/FeatureDefines.xcconfig:

Add support for the RESOLUTION_MEDIA_QUERY feature flag.

Tools:

Add support for the RESOLUTION_MEDIA_QUERY feature flag.

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:

LayoutTests:

Test (resolution: x) media query to ensure compliance
with spec plus proposed dppx values.

  • fast/media/mq-resolution-expected.txt: Added.
  • fast/media/mq-resolution.html: Added.
  • LayoutTests/platform/mac/TestExpectations:
  • LayoutTests/platform/chromium/TestExpectations:

Skip the test as the ports do not enable CSS Image Resolution.

8:11 AM Changeset in webkit [132226] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening.

  • platform/qt-5.0-wk2/http/tests/navigation/forward-and-cancel-expected.txt:
8:09 AM Changeset in webkit [132225] by Bruno de Oliveira Abinader
  • 2 edits in trunk/Tools

Adding myself to commiters.py
https://bugs.webkit.org/show_bug.cgi?id=100122

Unreviewed update to commiters.py.

  • Scripts/webkitpy/common/config/committers.py:
7:52 AM Changeset in webkit [132224] by anilsson@rim.com
  • 7 edits
    1 delete in trunk/Source/WebKit/blackberry

[BlackBerry] Let WebKit manage the SelectionOverlay
https://bugs.webkit.org/show_bug.cgi?id=99585

Reviewed by Rob Buis.

The SelectionOverlay was exposed to clients of the BlackBerry::WebKit
API. However, all the information and notifications necessary to manage
the SelectionOverlay are available within WebKit, so the client does
not have to shoulder this responsibility.

Remove WebSelection and all the related plumbing. Now that nobody is
using the class from the user interface thread, remove the message
related code in SelectionOverlay.

Add two calls to SelectionOverlay::hide() that are necessary now that
the client is no longer responsible for hiding it.

RIM PR: 225789

Reviewed internally by Mike Fenton.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):

  • Api/WebPage.h:

(WebKit):

  • Api/WebPage_p.h:

(WebPagePrivate):

  • Api/WebSelectionOverlay.h: Removed.
  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::cancelSelection): Hide the overlay here, because state is reset and selection mode is no longer active
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged): Also hide overlay here, to go with the call to cancelSelectionVisuals

  • WebKitSupport/SelectionOverlay.cpp:

(BlackBerry::WebKit::SelectionOverlay::SelectionOverlay):

  • WebKitSupport/SelectionOverlay.h:

(BlackBerry::WebKit::SelectionOverlay::create):
(SelectionOverlay):

7:51 AM WebKit Team edited by Bruno de Oliveira Abinader
Adding myself to commiters list. (diff)
7:51 AM Changeset in webkit [132223] by danakj@chromium.org
  • 3 edits in trunk/Source

[chromium] Expose setAutomaticallyComputeRasterScale on the WebLayer API
https://bugs.webkit.org/show_bug.cgi?id=100013

Reviewed by James Robinson.

This allows web content to opt-in to having their contentsScale
determined from their CSS transforms, without having this behaviour
unconditionally enabled globally.

Supports http://crbug.com/149943

  • chromium/public/WebLayer.h:

(WebLayer):

7:49 AM Changeset in webkit [132222] by allan.jensen@digia.com
  • 3 edits in trunk/Source/WebKit2

[Qt] Port QWebPreferences to C++
https://bugs.webkit.org/show_bug.cgi?id=100121

Reviewed by Kenneth Rohde Christiansen.

Port all the WebPreference calls to using the direct API instead of going through
the auto-generated C API.

  • UIProcess/API/qt/qwebpreferences.cpp:

(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferencesPrivate::setFontFamily):
(QWebPreferencesPrivate::fontFamily):
(QWebPreferencesPrivate::setFontSize):
(QWebPreferencesPrivate::fontSize):
(QWebPreferencesPrivate::preferences):

  • UIProcess/API/qt/qwebpreferences_p_p.h:
7:41 AM Changeset in webkit [132221] by timothy@apple.com
  • 2 edits in trunk/Tools

Unreviewed watchlist change to monitor Inspector IDLs.

  • Scripts/webkitpy/common/config/watchlist:
7:32 AM Changeset in webkit [132220] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Convert WebEvent's timestamp from millisecond to second.
https://bugs.webkit.org/show_bug.cgi?id=100101

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2012-10-23
Reviewed by Kenneth Rohde Christiansen.

Convert timestamp to second to create WebEvent from Evas event because
the unit of timestamp from Evas Event is millisecond, but the unit of
timestamp for WebEvent is second.

  • Shared/efl/WebEventFactory.cpp:

(WebKit::convertMillisecondToSecond):
(WebKit):
(WebKit::WebEventFactory::createWebMouseEvent):
(WebKit::WebEventFactory::createWebWheelEvent):
(WebKit::WebEventFactory::createWebKeyboardEvent):

7:29 AM Changeset in webkit [132219] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[BlackBerry] Improve the use of stencil buffer during compositing
https://bugs.webkit.org/show_bug.cgi?id=100020

We always want to scissor so remove the define.
Only turn stenciling on if needed.

Patch by Filip Spacek <fspacek@rim.com> on 2012-10-23
Reviewed by Rob Buis.

Reviewed internally by Arvid Nilsson.

  • platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::setViewport):
(WebCore::LayerRenderer::compositeLayers):
(WebCore::LayerRenderer::drawLayersOnSurfaces):
(WebCore::LayerRenderer::compositeLayersRecursive):
(WebCore::LayerRenderer::updateScissorIfNeeded):

7:10 AM Changeset in webkit [132218] by Csaba Osztrogonác
  • 2 edits
    4 adds in trunk/LayoutTests

[Qt] Unreviewed holiday gardening to paint the bots green.

  • platform/qt-5.0-wk2/http/tests/navigation/forward-and-cancel-expected.txt: Added after r132041.
  • platform/qt-5.0-wk2/http/tests/navigation/postredirect-frames-expected.txt: Added after r132041.
  • platform/qt-5.0-wk2/http/tests/navigation/postredirect-goback2-expected.txt: Added after r132041.
  • platform/qt/TestExpectations: Skip new failing tests.
6:52 AM Changeset in webkit [132217] by commit-queue@webkit.org
  • 4 edits
    2 moves in trunk/Source/WebKit2

[EFL][WK2] Make request manager client a C++ class
https://bugs.webkit.org/show_bug.cgi?id=100093

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-23
Reviewed by Kenneth Rohde Christiansen.

Make EFL's request manager client a C++ class and
move URL scheme handling code to it. The new
RequestManagerClientEfl is now in UIProcess/efl
instead of UIProcess/API/efl since it is not
part of the public API.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/ewk_context.cpp:

(Ewk_Context::Ewk_Context):
(Ewk_Context::requestManager):
(ewk_context_url_scheme_register):

  • UIProcess/API/efl/ewk_context_private.h:

(WebKit):
(Ewk_Context):

  • UIProcess/efl/RequestManagerClientEfl.cpp: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_context_request_manager_client.cpp.

(WebKit):
(Ewk_Url_Scheme_Handler):
(WebKit::Ewk_Url_Scheme_Handler::Ewk_Url_Scheme_Handler):
(WebKit::toRequestManagerClientEfl):
(WebKit::RequestManagerClientEfl::didReceiveURIRequest):
(WebKit::RequestManagerClientEfl::RequestManagerClientEfl):
(WebKit::RequestManagerClientEfl::~RequestManagerClientEfl):
(WebKit::RequestManagerClientEfl::registerURLSchemeHandler):

  • UIProcess/efl/RequestManagerClientEfl.h: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_context_request_manager_client_private.h.

(WebKit):
(RequestManagerClientEfl):
(WebKit::RequestManagerClientEfl::create):

6:50 AM Changeset in webkit [132216] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-1.11.1

Tagging the WebKitGTK+ 1.11.1 release

6:43 AM Changeset in webkit [132215] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Not reviewed: kick out non-chromium files from WebCore.gypi.

  • WebCore.gypi:
6:40 AM Changeset in webkit [132214] by Carlos Garcia Campos
  • 4 edits in trunk

Unreviewed. Update NEWS and configure.ac for 1.11.1 release

.:

  • configure.ac: Bump version numbers.

Source/WebKit/gtk:

  • NEWS: Added release notes for 1.11.1.
6:37 AM Changeset in webkit [132213] by Carlos Garcia Campos
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Fix make distcheck.

  • GNUmakefile.list.am: Add missing header file.
6:20 AM Changeset in webkit [132212] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[EFL][WK2] ecore_x should be initialised in WebProcess to avoid re-initialization by PlatformScreenEfl utilities and systemBeep() function
https://bugs.webkit.org/show_bug.cgi?id=100110

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-10-23
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Removed initialization of ecore_x, since it is initialized when process starts.

test: fast/media/*

  • platform/efl/PlatformScreenEfl.cpp:

(WebCore::screenDepth):
(WebCore::screenRect):

  • platform/efl/SoundEfl.cpp:

(WebCore::systemBeep):

Source/WebKit2:

PlatformScreenEfl functions and systemBeep() depend on ecore_x functionality, therefore,
ecore_x should be initialized when web process starts to avoid re-initialization.

  • WebProcess/efl/WebProcessMainEfl.cpp:

(WebKit::WebProcessMainEfl): Initialized ecore_x module.

6:06 AM Changeset in webkit [132211] by adamk@chromium.org
  • 5 edits in trunk

Always parse pasted fragments as HTML even on XHTML pages
https://bugs.webkit.org/show_bug.cgi?id=99880

Reviewed by Ojan Vafai.

Source/WebCore:

When pasting HTML into a page, using the XML parser is unlikely
to work correctly, as the contents of the clipboard are unlikely
to be properly-formed XHTML. Thus, for the pasting case, it's always
better to use HTML parsing, which will properly parse either HTML
(which is what's usually in the clipboard) or XHTML (which is
sometimes there as well).

The Mac port previously worked around this problem by falling back to plain text
when parsing failed, but switching to HTML seems like a clear improvement.

This also fixes a crash in Chromium (see http://webkit.org/b/99607
and http://crbug.com/136218); it erroneously assumed that createFragmentFromMarkup()
would never return null. This patch makes that true.

  • editing/markup.cpp:

(WebCore::createFragmentFromMarkup): Don't delegate to createContextualFragment:
we already know our context element is safe (i.e., it's <body>),
and we want to force HTML (not XML) parsing.

LayoutTests:

Updated existing tests to match new expected behavior.

  • editing/pasteboard/paste-noscript-xhtml-expected.txt: The HTML

parser leaves <script> tags in the DOM when pasting, but removes their
attributes and children, so this is just as safe as the previous
behavior.

  • platform/mac/editing/pasteboard/paste-xml-expected.txt: Now that we

use the HTML parser, parsing the paste succeeds and so we insert DOM
instead of plain text. Similar rebaselines may be needed on other
platforms.

5:34 AM Changeset in webkit [132210] by ryuan.choi@samsung.com
  • 20 edits in trunk

[EFL][WK2] Add support for IMF composition
https://bugs.webkit.org/show_bug.cgi?id=89552

Reviewed by Gyuyoung Kim.

.:

  • Source/cmake/FindEcore.cmake: Checked Ecore_IMF.

Source/WebKit2:

Implemented basic IMF support.

  • PlatformEfl.cmake:
  • Shared/NativeWebKeyboardEvent.h:

(NativeWebKeyboardEvent):
(WebKit::NativeWebKeyboardEvent::isFiltered):
Added to determine whether current keyboard event is compositing.

  • Shared/efl/NativeWebKeyboardEventEfl.cpp:

(WebKit::NativeWebKeyboardEvent::NativeWebKeyboardEvent):

  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::updateTextInputState):
Added to change input state.

  • UIProcess/API/efl/PageClientImpl.h:

(PageClientImpl):

  • UIProcess/API/efl/ewk_main.cpp:

(ewk_init): Called ecore_imf_init.
(ewk_shutdown): Called ecore_imf_shutdown.

  • UIProcess/API/efl/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::~_Ewk_View_Private_Data):
(_ewk_view_smart_key_down): Modified to send keyboard event to IMF.
(_ewk_view_smart_mouse_up): Modified to reset input method context.
(_ewk_view_preedit_changed): Added to send composition string.
(_ewk_view_commit): Added to send a message that composition is finished.
(_ewk_view_imf_context_create): Added to create Ecore_IMF_Context.
(_ewk_view_imf_context_destroy): Added to destroy Ecore_IMF_Context.
(ewk_view_text_input_state_update): Added to update input state.

  • UIProcess/API/efl/ewk_view_private.h:
  • UIProcess/PageClient.h: Moved updateTextInputState() to share with EFL port.

(PageClient):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::editorStateChanged):
Added PLATFORM(EFL) to call updateTextInputState()

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:

Added HandleInputMethodKeydown message to determine whether keydown is handled.

  • UIProcess/efl/WebPageProxyEfl.cpp:

(WebKit::WebPageProxy::handleInputMethodKeydown):
Added to check whether input method handled keydown.
(WebKit::WebPageProxy::confirmComposition): Added to support composition.
(WebKit::WebPageProxy::setComposition): Ditto.
(WebKit::WebPageProxy::cancelComposition): Ditto.

  • WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp:

(WebKit::WebEditorClient::handleInputMethodKeydown):
Added to check whether input method handled keydown.

  • WebProcess/WebPage/WebPage.h:

(WebPage):

  • WebProcess/WebPage/WebPage.messages.in: Added messages to support composition.
  • WebProcess/WebPage/efl/WebPageEfl.cpp:

(WebKit::targetFrameForEditing): Referenced from QT port to get focused frame.
(WebKit::WebPage::confirmComposition): Added to support composition.
(WebKit::WebPage::setComposition): Ditto.
(WebKit::WebPage::cancelComposition): Ditto.

5:33 AM Changeset in webkit [132209] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL] Make plugin process debugging easier (PLUGIN_PROCESS_COMMAND_PREFIX)
https://bugs.webkit.org/show_bug.cgi?id=99297

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-10-23
Reviewed by Kenneth Rohde Christiansen.

Add support for PLUGIN_PROCESS_COMMAND_PREFIX environment variable, to allow easier
plugin debugging with e.g.:
$ PLUGIN_PROCESS_COMMAND_PREFIX="xterm gdb --args" MiniBrowser

  • UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:

(WebKit::PluginProcessProxy::platformInitializeLaunchOptions):
(WebKit):

5:31 AM Changeset in webkit [132208] by commit-queue@webkit.org
  • 3 edits
    2 moves in trunk/Source/WebKit2

[EFL][WK2] Make Policy client a C++ class
https://bugs.webkit.org/show_bug.cgi?id=100089

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-23
Reviewed by Kenneth Rohde Christiansen.

Make page policy client a C++ class and remove it from API folder.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/ewk_view.cpp:

(Ewk_View_Private_Data):
(_ewk_view_initialize):

  • UIProcess/efl/PagePolicyClientEfl.cpp: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_view_policy_client.cpp.

(WebKit):
(WebKit::toPagePolicyClientEfl):
(WebKit::PagePolicyClientEfl::decidePolicyForNavigationAction):
(WebKit::PagePolicyClientEfl::decidePolicyForNewWindowAction):
(WebKit::PagePolicyClientEfl::decidePolicyForResponseCallback):
(WebKit::PagePolicyClientEfl::PagePolicyClientEfl):

  • UIProcess/efl/PagePolicyClientEfl.h: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_view_policy_client_private.h.

(WebKit):
(PagePolicyClientEfl):
(WebKit::PagePolicyClientEfl::create):
(WebKit::PagePolicyClientEfl::view):

5:30 AM Changeset in webkit [132207] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Fixing failure expectation for fast/sub-pixel/file-upload-control-at-fractional-offset.html,
the test is a reftest so the expectation should be ImageOnlyFailure.

  • platform/gtk/TestExpectations:
5:12 AM Changeset in webkit [132206] by commit-queue@webkit.org
  • 11 edits in trunk

[WK2] [WTR] WebKitTestRunner needs testRunner.queueForwardNavigation
https://bugs.webkit.org/show_bug.cgi?id=99700

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-23
Reviewed by Kenneth Rohde Christiansen.

Tools:

Implemented testRunner.queueForwardNavigation, made little refactoring in Work Queue
to obviate code duplication.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::queueBackNavigation):
(WTR):
(WTR::InjectedBundle::queueForwardNavigation):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::queueForwardNavigation):
(WTR):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

  • WebKitTestRunner/WorkQueueManager.cpp:

(NavigationItem):
(WTR::NavigationItem::NavigationItem):
(WTR::NavigationItem::invoke):
(WTR):
(WTR::WorkQueueManager::queueBackNavigation):
(WTR::WorkQueueManager::queueForwardNavigation):

  • WebKitTestRunner/WorkQueueManager.h:

(WorkQueueManager):

LayoutTests:

Unskipped http/tests/cache/subresource-failover-to-network.html for WK2 ports.

  • platform/wk2/TestExpectations:
5:10 AM Changeset in webkit [132205] by allan.jensen@digia.com
  • 4 edits in trunk

[Qt] REGRESSION (r130851): fast/text/word-space-with-kerning.html fails
https://bugs.webkit.org/show_bug.cgi?id=98876

Reviewed by Simon Hausmann.

Source/WebCore:

Do not add word-spacing for leading space. This matches what simple path font-width does.

Tested by existing tests.

  • platform/graphics/qt/FontQt.cpp:

(WebCore::Font::floatWidthForComplexText):

LayoutTests:

Unskip passing word-width tests.

  • platform/qt/TestExpectations:
5:08 AM Changeset in webkit [132204] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

viewport-128-expected.txt has been removed unexpectedly.
https://bugs.webkit.org/show_bug.cgi?id=100108

Patch by Dongwoo Joshua Im <dw.im@samsung.com> on 2012-10-23
Reviewed by Gyuyoung Kim.

viewport-128-expected.txt has been removed by http://trac.webkit.org/changeset/132186 unexpectedly.

  • fast/viewport/viewport-128-expected.txt: Added.
4:41 AM Changeset in webkit [132203] by commit-queue@webkit.org
  • 3 edits
    2 adds
    2 deletes in trunk/Source/WebKit2

[EFL][WK2] Make UI client a C++ class
https://bugs.webkit.org/show_bug.cgi?id=100099

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-23
Reviewed by Gyuyoung Kim.

Made page UI client a C++ class and removed it from API directory.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/ewk_view.cpp:

(Ewk_View_Private_Data):
(_ewk_view_initialize):

  • UIProcess/API/efl/ewk_view_ui_client.cpp: Removed.
  • UIProcess/API/efl/ewk_view_ui_client_private.h: Removed.
  • UIProcess/efl/PageUIClientEfl.cpp: Added.

(WebKit):
(WebKit::toPageUIClientEfl):
(WebKit::PageUIClientEfl::closePage):
(WebKit::PageUIClientEfl::createNewPage):
(WebKit::PageUIClientEfl::runJavaScriptAlert):
(WebKit::PageUIClientEfl::runJavaScriptConfirm):
(WebKit::PageUIClientEfl::runJavaScriptPrompt):
(WebKit::PageUIClientEfl::showColorPicker):
(WebKit::PageUIClientEfl::hideColorPicker):
(WebKit::PageUIClientEfl::exceededDatabaseQuota):
(WebKit::PageUIClientEfl::focus):
(WebKit::PageUIClientEfl::unfocus):
(WebKit::PageUIClientEfl::takeFocus):
(WebKit::PageUIClientEfl::getWindowFrame):
(WebKit::PageUIClientEfl::setWindowFrame):
(WebKit::PageUIClientEfl::PageUIClientEfl):

  • UIProcess/efl/PageUIClientEfl.h: Added.

(WebKit):
(PageUIClientEfl):
(WebKit::PageUIClientEfl::create):

4:36 AM Changeset in webkit [132202] by apavlov@chromium.org
  • 5 edits in trunk

Web Inspector: Incorrect resolution of relative URLs containing a scheme in query parameters
https://bugs.webkit.org/show_bug.cgi?id=100084

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Use the RFC 3986 grammar for the URL scheme.

  • inspector/front-end/ParsedURL.js:

(WebInspector.ParsedURL):

LayoutTests:

  • inspector/styles/styles-url-linkify-expected.txt:
  • inspector/styles/styles-url-linkify.html:
4:27 AM Changeset in webkit [132201] by kling@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] REGRESSION(r132169): It broke all plugin related test.
<http://webkit.org/b/100094>

Unreviewed test fix, make the CoreIPC encode/decode functions for CString match again.

  • Platform/CoreIPC/ArgumentCoders.cpp:

(CoreIPC::::encode):

3:53 AM Changeset in webkit [132200] by commit-queue@webkit.org
  • 6 edits
    1 move
    1 add
    1 delete in trunk/Source/WebKit2

[EFL][WK2] Make a download client a C++ class
https://bugs.webkit.org/show_bug.cgi?id=100005

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-23
Reviewed by Kenneth Rohde Christiansen.

Make EFL's Download client a C++ class and move
the id <-> download mapping from Ewk_Context to
DownloadManagerEfl.

The Download client was also moved to
UIProcess/efl/ instead of UIProcess/API/efl/
since it is not part of the public API.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::handleDownloadRequest):

  • UIProcess/API/efl/ewk_context.cpp:

(Ewk_Context::Ewk_Context):
(Ewk_Context::downloadManager):

  • UIProcess/API/efl/ewk_context_download_client_private.h: Removed.
  • UIProcess/API/efl/ewk_context_private.h:

(Ewk_Context):

  • UIProcess/API/efl/ewk_download_job_private.h:
  • UIProcess/efl/DownloadManagerEfl.cpp: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_context_download_client.cpp.

(WebKit):
(WebKit::toDownloadManagerEfl):
(WebKit::DownloadManagerEfl::decideDestinationWithSuggestedFilename):
(WebKit::DownloadManagerEfl::didReceiveResponse):
(WebKit::DownloadManagerEfl::didCreateDestination):
(WebKit::DownloadManagerEfl::didReceiveData):
(WebKit::DownloadManagerEfl::didFail):
(WebKit::DownloadManagerEfl::didCancel):
(WebKit::DownloadManagerEfl::didFinish):
(WebKit::DownloadManagerEfl::DownloadManagerEfl):
(WebKit::DownloadManagerEfl::registerDownload):
(WebKit::DownloadManagerEfl::downloadJob):
(WebKit::DownloadManagerEfl::unregisterDownloadJob):

  • UIProcess/efl/DownloadManagerEfl.h: Added.

(WebKit):
(DownloadManagerEfl):
(WebKit::DownloadManagerEfl::create):

3:45 AM Changeset in webkit [132199] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: Elaborate source panel sidebar context menus.
https://bugs.webkit.org/show_bug.cgi?id=99980

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-10-23
Reviewed by Vsevolod Vlasov.

  • Watches: add "Add watch expression" item to items and empty element
  • Watches: hide "Remove watch expression" from editing prompt context menu
  • Watches: add titles to header buttons
  • XHR Breakpoints: add "Add Breakpoint" item to items and empty element
  • XHR Breakpoints: add "Remove all breakpoints" item to items (when >1)
  • XHR Breakpoints: add title to header button
  • JS Breakpoints: hide "Remove/(De)Activate breakpoints" when only 1 item present
  • JS Breakpoints: add "(De)Activate breakpoints" to empty element context menu
  • English.lproj/localizedStrings.js: Added corresponding strings.
  • inspector/front-end/BreakpointsSidebarPane.js: Adjusted context menu.

(WebInspector.XHRBreakpointsSidebarPane): Ditto.

  • inspector/front-end/ObjectPropertiesSection.js: Added "isEditing()"
  • inspector/front-end/WatchExpressionsSidebarPane.js: Adjusted context menu.
3:14 AM Changeset in webkit [132198] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Update binding test results for r132194
https://bugs.webkit.org/show_bug.cgi?id=100097

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::installPerContextProperties):

3:05 AM Changeset in webkit [132197] by apavlov@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: Sass can only resolve same folder paths
https://bugs.webkit.org/show_bug.cgi?id=99259

Reviewed by Vsevolod Vlasov.

The actual reason is that the rule source location linkifier tries to linkify a resource (*.scss), which does not exist,
and falls back to just stripping the main page URL prefix from the rule location URL. This change introduces LiveLocations
for CSSRule locations and makes sure they are linkified using uiSourceCode's parsedURL.displayName.

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel): Introduced LiveLocation management for CSSRules.
(WebInspector.CSSStyleModel.prototype.setSourceMapping):
(WebInspector.CSSStyleModel.prototype._updateLocations):
(WebInspector.CSSStyleModel.prototype.createLiveLocation):
(WebInspector.CSSStyleModel.prototype.updateLocations):
(WebInspector.CSSStyleModel.LiveLocation): A LiveLocation for the CSS domain.
(WebInspector.CSSStyleModel.LiveLocation.prototype.uiLocation):
(WebInspector.CSSStyleModel.LiveLocation.prototype.dispose):

  • inspector/front-end/Linkifier.js:

(WebInspector.Linkifier.prototype.linkifyCSSRuleLocation): CSSRule LiveLocation-based link builder.
(WebInspector.Linkifier.DefaultFormatter.prototype.formatLiveAnchor): Add a title for anchors.
(WebInspector.Linkifier.DefaultCSSFormatter): Formatter for CSS location links.
(WebInspector.Linkifier.DefaultCSSFormatter.prototype.formatLiveAnchor):

  • inspector/front-end/ResourceUtils.js:

(WebInspector.displayNameForURL): Use parsedURL.displayName if uiSourceCode is present for the specified URL.

  • inspector/front-end/SASSSourceMapping.js:
  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane):
(WebInspector.StylesSidebarPane.prototype._innerRebuildUpdate):

  • inspector/front-end/inspector.html:
2:58 AM Changeset in webkit [132196] by commit-queue@webkit.org
  • 7 edits
    2 deletes in trunk

Unreviewed, rolling out r132149.
http://trac.webkit.org/changeset/132149
https://bugs.webkit.org/show_bug.cgi?id=100098

Breaks inspector profiler tests in debug mode. (Requested by
pfeldman1 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-23

Source/WebCore:

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::recalcColumn):

  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::calcWidthArray):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):

  • rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::styleDidChange):
(WebCore::RenderTableCol::updateFromElement):
(WebCore::RenderTableCol::computePreferredLogicalWidths):

  • rendering/RenderTableCol.h:

(RenderTableCol):

LayoutTests:

  • fast/table/col-span-change-relayout-expected.txt: Removed.
  • fast/table/col-span-change-relayout.html: Removed.
2:49 AM Changeset in webkit [132195] by Simon Hausmann
  • 4 edits in trunk

Unreviewed trivial Qt build fix: Fix build without USE_3D_GRAPHICS

Source/WebCore:

Move the #if USE(GRAPHICS_SURFACE) up to protect the inclusion of
GraphicsContext3D.h to be done only if we use the surface.

  • platform/graphics/surfaces/GraphicsSurface.h:

Tools:

Disable USE_GRAPHICS_SURFACE if we don't have USE_3D_GRAPHICS because
GraphicsSurface.h needs GraphicsContext3D.

  • qmake/mkspecs/features/features.prf:
2:47 AM Changeset in webkit [132194] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r132033.
http://trac.webkit.org/changeset/132033
https://bugs.webkit.org/show_bug.cgi?id=100097

Broke calendar picker (Requested by tkent on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-23

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateImplementation):

2:15 AM Changeset in webkit [132193] by abecsi@webkit.org
  • 21 edits in trunk

Remove devicePixelRatio from ViewportAttributes
https://bugs.webkit.org/show_bug.cgi?id=99845

Reviewed by Adam Barth.

.:

  • Source/autotools/symbols.filter: Update symbol.

Source/WebCore:

Since r121555 the devicePixelRatio is not calculated any more
and the scale factor is stored in Page::m_deviceScaleFactor,
thus it can be removed from ViewportAttributes to reduce
redundancy and unnecessary client code.
Use a new parameter in viewport calculation functions using
the visible viewport size (instead of passing the adjusted
viewport size) so that after this change clients do not end
up using the unadjusted viewport size for calculations.

No behavioural change, no new tests needed.

  • WebCore.exp.in:
  • dom/ViewportArguments.cpp:

(WebCore::computeViewportAttributes):
(WebCore::computeMinimumScaleFactorForContentContained):
Add the devicePixelRatio as a parameter.
(WebCore::restrictMinimumScaleFactorToViewportSize): Ditto.

  • dom/ViewportArguments.h:

(ViewportAttributes):
(WebCore):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::configurationForViewport):

Source/WebKit/efl:

  • ewk/ewk_view.cpp:

(_ewk_view_viewport_attributes_compute):
Pass the device pixel ratio as a function argument.

Source/WebKit/gtk:

  • webkit/webkitviewportattributes.cpp:

(webkitViewportAttributesRecompute):
Pass the device pixel ratio as a function argument.

Source/WebKit/qt:

Pass the device pixel ratio as a function argument to
match the new API.

  • Api/qwebpage.cpp:

(QWebPage::viewportAttributesForSize):

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::viewportAsText):

Source/WebKit2:

Update PageViewportController and co. to pass the device pixel ratio
as an argument to functions that need to adjust the visible viewport size.

  • UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::PageViewportController):
(WebKit::PageViewportController::updateMinimumScaleToFit):

  • UIProcess/qt/PageViewportControllerClientQt.cpp:

(WebKit::PageViewportControllerClientQt::didChangeViewportAttributes):

1:40 AM Changeset in webkit [132192] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebKit2

[EFL][WK2] Refactor Ewk_Context
https://bugs.webkit.org/show_bug.cgi?id=99594

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-23
Reviewed by Kenneth Rohde Christiansen.

Ewk_Context is now encapsulated to a C++ class inherited from WTF::RefCounted.
Also the same instance of Ewk_Context is returned for the same instance of
WKContext, so memory leak in ewk_view is also fixed.

  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::handleDownloadRequest):

  • UIProcess/API/efl/ewk_context.cpp:

(contextMap):
(Ewk_Context::Ewk_Context):
(Ewk_Context::~Ewk_Context):
(Ewk_Context::create):
(Ewk_Context::defaultContext):
(Ewk_Context::cookieManager):
(Ewk_Context::faviconDatabase):
(Ewk_Context::registerURLScheme):
(Ewk_Context::vibrationProvider):
(Ewk_Context::addVisitedLink):
(Ewk_Context::setCacheModel):
(Ewk_Context::cacheModel):
(ewk_context_ref):
(ewk_context_unref):
(ewk_context_cookie_manager_get):
(ewk_context_favicon_database_get):
(Ewk_Context::wkContext):
(Ewk_Context::addDownloadJob):
(Ewk_Context::downloadJob):
(Ewk_Context::removeDownloadJob):
(Ewk_Context::requestManager):
(Ewk_Context::urlSchemeRequestReceived):
(ewk_context_default_get):
(ewk_context_new):
(ewk_context_new_with_injected_bundle_path):
(ewk_context_url_scheme_register):
(ewk_context_vibration_client_callbacks_set):
(ewk_context_history_callbacks_set):
(ewk_context_visited_link_add):
(ewk_context_cache_model_set):
(ewk_context_cache_model_get):

  • UIProcess/API/efl/ewk_context_download_client.cpp:

(decideDestinationWithSuggestedFilename):
(didReceiveResponse):
(didCreateDestination):
(didReceiveData):
(didFail):
(didCancel):
(didFinish):
(ewk_context_download_client_attach):

  • UIProcess/API/efl/ewk_context_history_client.cpp:

(getEwkHistoryClient):
(didNavigateWithNavigationData):
(didPerformClientRedirect):
(didPerformServerRedirect):
(didUpdateHistoryTitle):
(populateVisitedLinks):
(ewk_context_history_client_attach):

  • UIProcess/API/efl/ewk_context_private.h:

(Ewk_Context):
(Ewk_Context::historyClient):

  • UIProcess/API/efl/ewk_context_request_manager_client.cpp:

(didReceiveURIRequest):
(ewk_context_request_manager_client_attach):

  • UIProcess/API/efl/ewk_view.cpp:

(Ewk_View_Private_Data):
(Ewk_View_Private_Data::Ewk_View_Private_Data):
(Ewk_View_Private_Data::~Ewk_View_Private_Data):
(_ewk_view_priv_del):
(_ewk_view_initialize):
(ewk_view_base_add):
(ewk_view_add_with_context):
(ewk_view_context_get):
(ewk_view_update_icon):

1:25 AM Changeset in webkit [132191] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit/qt

Unreviewed build fix with newer Qt 5.

QPlastiqueStyle has been removed, but as pointed out by Jens it's also not
maintained anymore and hence safe to remove. We can do tweaks with the new
fusion style if required.

  • WebCoreSupport/QStyleFacadeImp.cpp:

(WebKit::QStyleFacadeImp::paintInnerSpinButton):

1:25 AM Changeset in webkit [132190] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed holiday gardening.

  • platform/qt/TestExpectations: Skip new tests (and sort) because ENABLE(SHADOW_DOM) is disabled.
1:11 AM Changeset in webkit [132189] by commit-queue@webkit.org
  • 3 edits
    1 move
    1 add
    1 delete in trunk/Source/WebKit2

[EFL][WK2] Make page load client a C++ class
https://bugs.webkit.org/show_bug.cgi?id=100081

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-23
Reviewed by Kenneth Rohde Christiansen.

Make page load client a C++ class and move it
up to UIProcess/efl since it is not really part
of the public API.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/ewk_view.cpp:

(Ewk_View_Private_Data):
(_ewk_view_initialize):

  • UIProcess/API/efl/ewk_view_loader_client_private.h: Removed.
  • UIProcess/efl/PageLoadClientEfl.cpp: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_view_loader_client.cpp.

(WebKit):
(WebKit::toPageLoadClientEfl):
(WebKit::PageLoadClientEfl::didReceiveTitleForFrame):
(WebKit::PageLoadClientEfl::didReceiveIntentForFrame):
(WebKit::PageLoadClientEfl::registerIntentServiceForFrame):
(WebKit::PageLoadClientEfl::didChangeProgress):
(WebKit::PageLoadClientEfl::didFinishLoadForFrame):
(WebKit::PageLoadClientEfl::didFailLoadWithErrorForFrame):
(WebKit::PageLoadClientEfl::didStartProvisionalLoadForFrame):
(WebKit::PageLoadClientEfl::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::PageLoadClientEfl::didFailProvisionalLoadWithErrorForFrame):
(WebKit::PageLoadClientEfl::didChangeBackForwardList):
(WebKit::PageLoadClientEfl::didSameDocumentNavigationForFrame):
(WebKit::PageLoadClientEfl::PageLoadClientEfl):

  • UIProcess/efl/PageLoadClientEfl.h: Added.

(WebKit):
(PageLoadClientEfl):
(WebKit::PageLoadClientEfl::create):
(WebKit::PageLoadClientEfl::view):

1:09 AM Changeset in webkit [132188] by Simon Pena
  • 2 edits in trunk/Tools

Unreviewed. Adding myself as committer.

  • Scripts/webkitpy/common/config/committers.py:
1:01 AM Changeset in webkit [132187] by tkent@chromium.org
  • 10 edits in trunk

Support full month names in DateTimeEditElement, and use them in input[type=month] by default
https://bugs.webkit.org/show_bug.cgi?id=100060

Reviewed by Kentaro Hara.

Source/WebCore:

According to https://plus.google.com/104770450049736549185/posts/4zsoeHoa7SM
no one wants to show abbreviated month names for input[type=month].
This change add support for full month names in DateTimeEditELement, and
LocaleICU and LocaleMac retun month formats with full month names. Note
that LocaleWin::monthFormat returns formats for full month names.

No new tests. Covered by fast/forms/month-multiple-fields/month-multiple-fields-appearance-*.html

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditBuilder::visitField):
If count is 4, use Localizer::monthLabels or standAloneMonthLabels.

  • platform/text/LocaleICU.cpp:

(WebCore::LocaleICU::monthFormat):
Returns a format for full month names.

  • platform/text/mac/LocaleMac.mm:

(WebCore::LocaleMac::monthFormat): Ditto.

Source/WebKit/chromium:

  • tests/LocaleMacTest.cpp:

(TEST_F): Follow LocaleMac::monthFormat change.

  • tests/LocalizedDateICUTest.cpp:

(TEST_F): Follow LocaleICU::monthFormat change.

LayoutTests:

Note: Other affected tests are already marked in TestExpectations.

  • fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n.html: Add max attributes to show appearance in typical usage.
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png:

Updated.

12:58 AM Changeset in webkit [132186] by mkwst@chromium.org
  • 10 edits
    1 delete in trunk

Viewport errors should be slightly friendlier with regard to ';'.
https://bugs.webkit.org/show_bug.cgi?id=100003

Reviewed by Adam Barth.

Source/WebCore:

This patch scans viewport values that cause errors for ';'. If found,
a quick message is appended to the error, noting that semicolons are
not valid separators in viewport contents, and that commas would be
the proper substitute.

No functional changes, just a better error message.

  • dom/ViewportArguments.cpp:

(WebCore::reportViewportWarning):

LayoutTests:

  • fast/viewport/viewport-128-expected.txt:
  • fast/viewport/viewport-133-expected.txt:
  • fast/viewport/viewport-134-expected.txt:
  • fast/viewport/viewport-54-expected.txt:
  • fast/viewport/viewport-65-expected.txt:
  • fast/viewport/viewport-67-expected.txt:
  • fast/viewport/viewport-77-expected.txt:
  • fast/viewport/viewport-warnings-5-expected.txt:

Updating tests with new expectations.

12:53 AM Changeset in webkit [132185] by timothy@apple.com
  • 2 edits in trunk/Source/WebCore

Docking/undocking the Web Inspector does not work correctly in Safari.

The "docked" and "bottom" strings need quoted instead of being passed as identifiers.

https://bugs.webkit.org/show_bug.cgi?id=100080

Reviewed by Yury Semikhatsky.

  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::setAttachedWindow): Put quotes around the %s.

12:26 AM Changeset in webkit [132184] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL][WK2] Compilation warning in GraphicsContext3DPrivate.cpp when AC is enabled
https://bugs.webkit.org/show_bug.cgi?id=99723

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-23
Reviewed by Kenneth Rohde Christiansen.

Fix compilation warning in GraphicsContext3DPrivate.cpp when AC is
enabled.

No new tests, no change in behavior.

  • platform/graphics/efl/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::createSurface):

12:24 AM Changeset in webkit [132183] by commit-queue@webkit.org
  • 19 edits in trunk

When blocking localStorage, Firefox throws a security exception on access, and maybe so should we
https://bugs.webkit.org/show_bug.cgi?id=63257

Patch by Dan Carney <dcarney@google.com> on 2012-10-23
Reviewed by Jochen Eisinger.

Source/WebCore:

Throw security exception when local storage is accessed
under certain circumstances to match firefox.

No new tests. Existing tests modified.

  • bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::canGetItemsForName):
(WebCore::JSStorage::nameGetter):
(WebCore::JSStorage::deleteProperty):
(WebCore::JSStorage::getOwnPropertyNames):

  • bindings/v8/custom/V8StorageCustom.cpp:

(WebCore):
(WebCore::setDOMException):
(WebCore::V8Storage::namedPropertyEnumerator):
(WebCore::storageGetter):
(WebCore::V8Storage::namedPropertyQuery):
(WebCore::storageDeleter):

  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::sessionStorage):
(WebCore::DOMWindow::localStorage):

  • storage/Storage.cpp:
  • storage/Storage.h:

(WebCore):
(WebCore::Storage::length):
(WebCore::Storage::key):
(WebCore::Storage::getItem):
(WebCore::Storage::setItem):
(WebCore::Storage::removeItem):
(WebCore::Storage::clear):
(WebCore::Storage::contains):

  • storage/Storage.idl:
  • storage/StorageArea.h:

(StorageArea):

  • storage/StorageAreaImpl.cpp:

(WebCore::StorageAreaImpl::canAccessStorage): Checks whether access to storage is a security violation.
(WebCore):
(WebCore::StorageAreaImpl::disabledByPrivateBrowsingInFrame):
(WebCore::StorageAreaImpl::length):
(WebCore::StorageAreaImpl::key):
(WebCore::StorageAreaImpl::getItem):
(WebCore::StorageAreaImpl::setItem):
(WebCore::StorageAreaImpl::removeItem):
(WebCore::StorageAreaImpl::clear):
(WebCore::StorageAreaImpl::contains):

  • storage/StorageAreaImpl.h:

(StorageAreaImpl):

Source/WebKit/chromium:

Add security check and security check cache.

  • src/StorageAreaProxy.cpp:

(WebCore::StorageAreaProxy::StorageAreaProxy):
(WebCore::StorageAreaProxy::length):
(WebCore::StorageAreaProxy::key):
(WebCore::StorageAreaProxy::getItem):
(WebCore::StorageAreaProxy::setItem):
(WebCore::StorageAreaProxy::removeItem):
(WebCore::StorageAreaProxy::clear):
(WebCore::StorageAreaProxy::contains):
(WebCore::StorageAreaProxy::canAccessStorage):

  • src/StorageAreaProxy.h:

(StorageAreaProxy):
(WebCore::StorageAreaProxy::canAccessStorage):

LayoutTests:

Adjust tests to handle new exceptions.

  • fast/storage/storage-detached-iframe-expected.txt:
  • fast/storage/storage-detached-iframe.html:
  • platform/chromium/permissionclient/storage-permission-expected.txt:
  • platform/chromium/permissionclient/storage-permission.html:
12:12 AM Changeset in webkit [132182] by mark.lam@apple.com
  • 16 edits
    1 add in trunk

Make topCallFrame reliable.
https://bugs.webkit.org/show_bug.cgi?id=98928.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • VM entry points and the GC now uses topCallFrame.
  • The callerFrame value in CallFrames are now always the previous frame on the stack, except for the first frame which has a callerFrame of 0 (not counting the HostCallFrameFlag). Hence, we can now traverse every frame on the stack all the way back to the first frame.
  • GlobalExec's will no longer be used as the callerFrame values in call frames.
  • Added fences and traps for debugging the JSStack in debug builds.
  • bytecode/SamplingTool.h:

(SamplingTool):
(JSC::SamplingTool::CallRecord::CallRecord):

  • dfg/DFGOperations.cpp:
  • Fixed 2 DFG helper functions to flush topCallFrame as expected.
  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::prepareForExternalCall):

  • interpreter/CallFrame.h:

(JSC::ExecState::callerFrameNoFlags):
(ExecState):
(JSC::ExecState::argIndexForRegister):
(JSC::ExecState::getArgumentUnsafe):

  • interpreter/CallFrameClosure.h:

(CallFrameClosure):

  • interpreter/Interpreter.cpp:

(JSC):
(JSC::eval):
(JSC::Interpreter::Interpreter):
(JSC::Interpreter::throwException):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::endRepeatCall):

  • interpreter/Interpreter.h:

(JSC):
(Interpreter):

  • interpreter/JSStack.cpp:

(JSC::JSStack::JSStack):
(JSC::JSStack::gatherConservativeRoots):
(JSC::JSStack::disableErrorStackReserve):

  • interpreter/JSStack.h:

(JSC):
(JSStack):
(JSC::JSStack::installFence):
(JSC::JSStack::validateFence):
(JSC::JSStack::installTrapsAfterFrame):

  • interpreter/JSStackInlines.h: Added.

(JSC):
(JSC::JSStack::getTopOfFrame):
(JSC::JSStack::getTopOfStack):
(JSC::JSStack::getStartOfFrame):
(JSC::JSStack::pushFrame):
(JSC::JSStack::popFrame):
(JSC::JSStack::generateFenceValue):
(JSC::JSStack::installFence):
(JSC::JSStack::validateFence):
(JSC::JSStack::installTrapsAfterFrame):

  • jit/JITStubs.cpp:

(JSC::jitCompileFor):
(JSC::lazyLinkFor):

  • Set frame->codeBlock to 0 for both the above because they are called with partially intitialized frames (cb uninitialized), but may trigger a GC.

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

LayoutTests:

  • Re-baseline some tests to match the new stack dump results.
  • http/tests/inspector/console-resource-errors-expected.txt:
  • http/tests/inspector/stacktraces/csp-injected-content-warning-contains-stacktrace-expected.txt:
  • http/tests/inspector/stacktraces/csp-inline-warning-contains-stacktrace-expected.txt:

Oct 22, 2012:

10:56 PM Changeset in webkit [132181] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Removing failure for an accessibility test that's already passing.
Updating and adding expectations for subpixel tests to reflect
the current situation.

  • platform/gtk/TestExpectations:
10:51 PM Changeset in webkit [132180] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Skip fast/events/tabindex-focus-blur-all.html case.
https://bugs.webkit.org/show_bug.cgi?id=100067

Unreviewed, EFL gardening.

fast/events/tabindex-focus-blur-all.html case has been crashed due to ASSERT in hashtable.
Please refer to BUG 100065 for crash details.

Patch by Kangil Han <kangil.han@samsung.com> on 2012-10-22

  • platform/efl-wk1/TestExpectations:
10:21 PM Changeset in webkit [132179] by jsbell@chromium.org
  • 8 edits
    1 delete in trunk/Source/WebCore

IndexedDB: Remove custom binding code for IDBCursor.value
https://bugs.webkit.org/show_bug.cgi?id=100034

Reviewed by Kentaro Hara.

Now that we're using ScriptValue instead of SerializedScriptValue we can just expose
IDBCursor.value as an |any| (IDL) or |ScriptValue| (C++) to maintain the specified
semantics that the object identity is retained across accesses.

Test: storage/indexeddb/cursor-value.html

  • Modules/indexeddb/IDBCursor.cpp: Remove "dirty" tracking.

(WebCore::IDBCursor::IDBCursor):
(WebCore::IDBCursor::value):
(WebCore::IDBCursor::setValueReady):

  • Modules/indexeddb/IDBCursor.h: IDBAny -> ScriptValue

(IDBCursor):

  • Modules/indexeddb/IDBCursorWithValue.idl: IDBAny -> any
  • Modules/indexeddb/IDBObjectStore.cpp: No need to route through IDBAny to get ScriptValue.

(WebCore):

  • UseV8.cmake: Remove references to IDBCustomBindings.cpp
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • bindings/v8/IDBCustomBindings.cpp: Removed.
10:11 PM Changeset in webkit [132178] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Font’s fast code path is used for partial runs with kerning and ligatures, but shouldn’t be
https://bugs.webkit.org/show_bug.cgi?id=100068

Reviewed by Sam Weinig.

As described in <http://webkit.org/b/100050>, the fast code path doesn’t handle partial runs
correctly when kerning or ligatures are enabled. Since the partial-run case is uncommon,
for now just use the complex code path in this case.

  • platform/graphics/Font.cpp:

(WebCore::Font::drawText): Changed to use the complex path for partial runs if there are any
typesetting features.
(WebCore::Font::drawEmphasisMarks): Ditto.
(WebCore::Font::selectionRectForText): Ditto.
(WebCore::Font::offsetForPosition): Changed to use the complex path if there are any
typesetting features.

9:33 PM Changeset in webkit [132177] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Missing some cookies in HTTP response header when set several cookies in one "Set-Cookie" header.
https://bugs.webkit.org/show_bug.cgi?id=99950

Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-10-22
Reviewed by George Staikos.

In "NetworkJob::handleNotifyHeaderReceived", if there are several "Set-Cookie" headers,
we should combine the following ones with the first.

No new test case.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::handleNotifyHeaderReceived):

9:20 PM Changeset in webkit [132176] by morrita@google.com
  • 4 edits
    2 adds in trunk

Assertion failed at WebCore::toInsertionPoint / WebCore::ContentDistributor::distribute
https://bugs.webkit.org/show_bug.cgi?id=100038

Reviewed by Kent Tamura.

Source/WebCore:

isHTMLContentElement() assumes that the content element always has
a tag name "content" but it doesn't when Shadow DOM feature is
disabled. This fix let the function see the correct tag name.

Test: fast/dom/shadow/insertion-points-with-shadow-disabled.html

  • html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::contentTagName):

  • html/shadow/HTMLContentElement.h:

(HTMLContentElement):
(WebCore::isHTMLContentElement):

LayoutTests:

  • fast/dom/shadow/insertion-points-with-shadow-disabled-expected.txt: Added.
  • fast/dom/shadow/insertion-points-with-shadow-disabled.html: Added.
8:43 PM Changeset in webkit [132175] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Include path in the repaint-text-decoration-style.html should be changed.
https://bugs.webkit.org/show_bug.cgi?id=100063

Unreviewed gardening.

The include path is differentiated by http://trac.webkit.org/changeset/132043

Patch by Dongwoo Joshua Im <dw.im@samsung.com> on 2012-10-22

  • fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-style.html:
8:08 PM Changeset in webkit [132174] by shinyak@chromium.org
  • 6 edits
    4 adds in trunk

[Shadow] Fallback content should also be reprojection.
https://bugs.webkit.org/show_bug.cgi?id=99750

Reviewed by Dimitri Glazkov.

Source/WebCore:

Fallback content of InsertionPoint should be reprojected. The existing assumption that
only the direct child of host element can be distributed to InsertionPoint does not hold anymore.
So, if the parent of an element is InsertionPoint which should show fallback element, we have to
check the grand parent of the element instead of the element.

Tests: fast/dom/shadow/content-reprojection-fallback-reprojection.html

fast/dom/shadow/content-reprojection-fallback.html

  • css/StyleResolver.cpp:

(WebCore::shouldResetStyleInheritance): Checks the grandparent of the element if the parent is
an InsertionPoint which uses fallback content.

  • dom/ComposedShadowTreeWalker.cpp:

(WebCore::shadowOfParentForDistribution):
(WebCore):
(WebCore::resolveReprojection):
(WebCore::ComposedShadowTreeWalker::traverseParent):

  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::shouldUseFallbackElements): True if the InsertionPoint should use fallback content.
(WebCore):

  • html/shadow/InsertionPoint.h:

(WebCore::parentElementForDistribution): Returns the grandparent element if the parent is InsertionPoint which uses
fallback content. Returns parent element otherwise.
(WebCore):

LayoutTests:

  • fast/dom/shadow/content-reprojection-fallback-expected.html: Added.
  • fast/dom/shadow/content-reprojection-fallback-reprojection-expected.html: Added.
  • fast/dom/shadow/content-reprojection-fallback-reprojection.html: Added.
  • fast/dom/shadow/content-reprojection-fallback.html: Added.
7:58 PM Changeset in webkit [132173] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Suppress compositor invalidations during FrameView recreation in force-compositing-mode
https://bugs.webkit.org/show_bug.cgi?id=99882

Patch by James Robinson <jamesr@chromium.org> on 2012-10-22
Reviewed by Adrienne Walker.

In force compositing mode, page navigation temporarily takes us in and out of compositing mode because the
root GraphicsLayer is owned by the FrameView which is destroyed and recreated. These changes generate
invalidations on the WebViewClient that trigger frames but aren't actually terribly useful. WebCore suppresses
repaints too early during page load to avoid flashing white or mostly white and to avoid impacting page load time.

This suppresses compositor invalidations during FrameView recreation.

Covered by chromium's page cycler performance tests.

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::commitDocumentData):
(WebKit::WebFrameImpl::createFrameView):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::suppressInvalidations):
(WebKit):
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::scheduleComposite):

  • src/WebViewImpl.h:

(WebViewImpl):

7:14 PM Changeset in webkit [132172] by keishi@webkit.org
  • 3 edits in trunk/Source/WebCore

Label position is wrong in the suggestion picker when all the suggestions have labels
https://bugs.webkit.org/show_bug.cgi?id=99965

Reviewed by Kent Tamura.

Somehow the scrollbar was appearing and so the label element was being wrapped to the next line.

No new tests. Can't reproduce in layout test.

  • Resources/pagepopups/suggestionPicker.css:

(.suggestion-list):

  • Resources/pagepopups/suggestionPicker.js:

(SuggestionPicker.prototype._fixWindowSize): Explicitly show the scroll bar.

7:05 PM Changeset in webkit [132171] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

[Chromium] Needs to track ShadowRoot usage
https://bugs.webkit.org/show_bug.cgi?id=99955

Reviewed by Dimitri Glazkov.

Added an UMA instrumentation.

  • dom/ShadowRoot.cpp:

(WebCore::determineUsageType):
(WebCore):
(WebCore::ShadowRoot::create):

6:22 PM Changeset in webkit [132170] by tkent@chromium.org
  • 12 edits in trunk/Source

Introduce Localizer::standAloneMonthLabels
https://bugs.webkit.org/show_bug.cgi?id=99963

Reviewed by Kentaro Hara.

Source/WebCore:

We realized full month names and full stand-alone month names were
necessary for input[type=month] UI. We change the compile-flag for
Localizer::monthLabels from "ENABLE(CALENDAR_PICKER)" to

"ENABLE(CALENDAR_PICKER)
ENABLE(INPUT_MULTIPLE_FIELDS_UI)," and

introduce Localizer::standAloneMonthLabels.

Tests: Add some test cases to Source/WebKit/chromium/LocaleMacTest.cpp
and LocalizedDateICUTest.cpp.

  • platform/text/Localizer.h:

(Localizer):

  • Add pure virtual standAloneMonthLabels.
  • Change the condition for monthLabels.
  • platform/text/LocaleNone.cpp:

(LocaleNone): Declare monthLabels, standAloneMonthLabels, and m_monthLabels.
(WebCore::LocaleNone::monthLabels):
Added. It always returns English month names.
(WebCore::LocaleNone::standAloneMonthLabels):
Added. Just calls monthLabels.

  • platform/text/LocaleWin.h:

(LocaleWin):
Declare standAloneMonthLabels, and change the condition for monthLabels.

  • platform/text/LocaleWin.cpp:

(WebCore): Change the condition for monthLabels.
(WebCore::LocaleWin::standAloneMonthLabels):
Added. Just calls monthLabels.

  • platform/text/mac/LocaleMac.h:

(LocaleMac):

  • Add standAloneMonthLabels and m_standAloneMonthLabels
  • Change the condition for monthLabels and m_monthLabels.
  • platform/text/mac/LocaleMac.mm:

(WebCore): Change the condition for monthLabels.
(WebCore::LocaleMac::standAloneMonthLabels):
Added. Get the information with NSDateFormatter::standaloneMonthSymbols.

  • platform/text/LocaleICU.h:

(LocaleICU):

  • Add standAloneMonthLabels and m_standAloneMonthLabels
  • Change the condition for monthLabels and m_monthLabels.
  • platform/text/LocaleICU.cpp:

(WebCore::LocaleICU::initializeCalendar):
Remove m_monthLabels initialization in order to avoid dependecy from monthLabels.
(WebCore):
(WebCore::createFallbackMonthLabels): Change the compile condition.
(WebCore::LocaleICU::monthLabels):

  • Change the compile condition.
  • Don't depend on initializeCalendar to make the code for

ENABLE(INPUT_MULTIPLE_FIELDS_UI) && !ENABLE(CALENDAR_PICKER) minimal.
(WebCore::LocaleICU::standAloneMonthLabels):
Added. The code is similar to shortStandAloneMonthLabels.

Source/WebKit/chromium:

Note that we don't add tests to LocaleWinTest because new function
LocaleWin::standAloneMonthLabels is equivalent to monthLabels.

  • tests/LocaleMacTest.cpp:

(LocaleMacTest::standAloneMonthLabel): Added a helper function.
(TEST_F): Add some tests. We don't test ru_ru locale because it has
different data on OSX versions.

  • tests/LocalizedDateICUTest.cpp:

(LocalizedDateICUTest::standAloneMonthLabel): Added a helper function.
(TEST_F): Add some tests.

5:58 PM Changeset in webkit [132169] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Handle ArgumentCoder template specializations that take the ArgumentEncoder as a reference
https://bugs.webkit.org/show_bug.cgi?id=100056

Reviewed by Andreas Kling.

Use template magic to make it possible to have ArgumentCoder specializations where the encode
function takes the ArgumentEncoder object as a reference instead of as a pointer. Also, add an
operator<< to ArgumentEncoder and change the string related ArgumentCoder specializations over to taking
the encoder as a reference and using stream operators.

  • Platform/CoreIPC/ArgumentCoders.cpp:

(CoreIPC::::encode):

  • Platform/CoreIPC/ArgumentCoders.h:
  • Platform/CoreIPC/ArgumentEncoder.h:

(ArgumentEncoder):
(UsesDeprecatedEncodeFunction):
(NoType):
(CoreIPC::ArgumentEncoder::encode):
(CoreIPC::ArgumentEncoder::operator<<):

5:55 PM Changeset in webkit [132168] by shinyak@chromium.org
  • 4 edits in trunk/Source/WebCore

Refactoring around ContainerNode::attachChildren
https://bugs.webkit.org/show_bug.cgi?id=99968

Reviewed by Hajime Morita.

Since ContainerNode::attach() is now equivalent to ContainerNode::attachChildren() + Node::attach(), we should call
ContainerNode::attach() instead of calling them.

No new tests, no change in behavior.

  • dom/ContainerNode.h:

(ContainerNode):

  • dom/Element.cpp:

(WebCore::Element::attach):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::attach):

5:45 PM Changeset in webkit [132167] by dpranke@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, more Chromium ML expectation updating.

  • platform/chromium-mac-mountainlion/TestExpectations:
  • platform/chromium/TestExpectations:
5:42 PM Changeset in webkit [132166] by jochen@chromium.org
  • 7 edits in trunk/Tools

[chromium] Move the call to RegisterIsolatedFileSystem to the WebTestDelegate interface
https://bugs.webkit.org/show_bug.cgi?id=100048

Reviewed by Adam Barth.

The call needs to be done outside of the sandbox.

  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebTestDelegate):

  • DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):
(WebTestRunner::EventSender::beginDragWithFiles):

  • DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:

(TestDelegate):

  • DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestInterfaces::Internal):
(WebTestRunner::WebTestInterfaces::Internal::registerIsolatedFileSystem):
(WebTestRunner):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::registerIsolatedFileSystem):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

5:39 PM Changeset in webkit [132165] by msaboff@apple.com
  • 6 edits in trunk/Source/WebCore

HTML Parser should produce 8 bit strings for doctype, comment and tagName tokens
https://bugs.webkit.org/show_bug.cgi?id=99889

Reviewed by Geoffrey Garen.

Added 8 bit check for accumulating all token data in MarkupTokenBase. Added code to convert
"name" token data directly to a string (8 or 16 as appropriate). Changed to accumulate
m_bufferedEndTagName as LChar's.

No new tests, covered by existing tests.

  • html/parser/HTMLToken.h:

(HTMLToken):

  • html/parser/HTMLTokenizer.cpp:

(WebCore::HTMLTokenizer::nextToken):
(WebCore::HTMLTokenizer::addToPossibleEndTag):
(WebCore::HTMLTokenizer::isAppropriateEndTag):

  • html/parser/HTMLTokenizer.h:

(HTMLTokenizer):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeLeading):

  • xml/parser/MarkupTokenBase.h:

(WebCore::MarkupTokenBase::beginStartTag):
(WebCore::MarkupTokenBase::beginEndTag):
(MarkupTokenBase):
(WebCore::MarkupTokenBase::beginDOCTYPE):
(WebCore::MarkupTokenBase::appendToComment):
(WebCore::MarkupTokenBase::appendToName):
(WebCore::MarkupTokenBase::nameString):
(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):

5:36 PM Writing Reftests edited by danakj@chromium.org
(diff)
5:03 PM Changeset in webkit [132164] by tony@chromium.org
  • 4 edits
    2 adds in trunk

margin-top/bottom has no effect for child nodes of flex items
https://bugs.webkit.org/show_bug.cgi?id=99923

Reviewed by Ojan Vafai.

Source/WebCore:

Flexitems, like table cells, shouldn't collapse margins.

Test: css3/flexbox/flexitem-no-margin-collapsing.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::MarginInfo::MarginInfo): Check to see if the parent is a flexible box.
We should always have a parent if we make it this far in the check.

LayoutTests:

Add a test to make sure we don't collapse margins in flex items.

  • css3/flexbox/flexitem-no-margin-collapsing-expected.txt: Added.
  • css3/flexbox/flexitem-no-margin-collapsing.html: Added.
  • css3/flexbox/repaint.html:
5:00 PM Changeset in webkit [132163] by eae@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed chromium win rebaselines.

  • platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.txt:
4:52 PM Changeset in webkit [132162] by fpizlo@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

DFG::Array::Undecided should be called DFG::Array::SelectUsingPredictions
https://bugs.webkit.org/show_bug.cgi?id=100052

Reviewed by Oliver Hunt.

No functional change, just renaming. It's a clearer name that more accurately
reflects the meaning, and it eliminates the namespace confusion that will happen
with the Undecided indexing type in https://bugs.webkit.org/show_bug.cgi?id=98606

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGArrayMode.cpp:

(JSC::DFG::fromObserved):
(JSC::DFG::refineArrayMode):
(JSC::DFG::modeAlreadyChecked):
(JSC::DFG::modeToString):

  • dfg/DFGArrayMode.h:

(JSC::DFG::canCSEStorage):
(JSC::DFG::modeIsSpecific):
(JSC::DFG::modeSupportsLength):
(JSC::DFG::benefitsFromStructureCheck):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::blessArrayOperation):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::arrayify):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

4:51 PM Changeset in webkit [132161] by andersca@apple.com
  • 22 edits in trunk/Source/WebKit2

More Argument coder cleanup
https://bugs.webkit.org/show_bug.cgi?id=100022

Reviewed by Andreas Kling.

Remove the ArgumentDecoder::decode overload that takes a const reference - if the call to decode ends up creating a temporary
we'll encode into it and then destroy it. Since this decode overload was mostly used with the CoreIPC::Out functions, remove them
(and CoreIPC::In) as well. Clean up a couple of ArgumentCoders as well.

  • Platform/CoreIPC/ArgumentCoders.h:
  • Platform/CoreIPC/ArgumentDecoder.h:
  • Platform/CoreIPC/Arguments.h:
  • Platform/CoreIPC/Connection.h:

(Connection):

  • Platform/mac/SharedMemoryMac.cpp:

(WebKit::SharedMemory::Handle::decode):

  • Shared/PrintInfo.cpp:

(WebKit::PrintInfo::encode):
(WebKit::PrintInfo::decode):

  • Shared/WebContextMenuItemData.cpp:

(WebKit::WebContextMenuItemData::encode):
(WebKit::WebContextMenuItemData::decode):

  • Shared/WebEvent.cpp:

(WebKit::WebEvent::encode):
(WebKit::WebEvent::decode):

  • Shared/WebGeolocationPosition.cpp:

(WebKit::WebGeolocationPosition::Data::encode):
(WebKit::WebGeolocationPosition::Data::decode):

  • Shared/WebMouseEvent.cpp:

(WebKit::WebMouseEvent::encode):
(WebKit::WebMouseEvent::decode):

  • Shared/WebPopupItem.cpp:

(WebKit::WebPopupItem::encode):
(WebKit::WebPopupItem::decode):

  • UIProcess/WebConnectionToWebProcess.cpp:

(WebKit::WebConnectionToWebProcess::decodeMessageBody):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::didReceiveMessage):
(WebKit::WebContext::didReceiveSyncMessage):

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::postMessage):
(WebKit::InjectedBundle::postSynchronousMessage):

  • WebProcess/WebConnectionToUIProcess.cpp:

(WebKit::WebConnectionToUIProcess::decodeMessageBody):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::postInjectedBundleMessage):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::postInjectedBundleMessage):

4:42 PM Changeset in webkit [132160] by dpranke@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, more Chromium ML expectation updating.

  • platform/chromium-mac-mountainlion/TestExpectations:
  • platform/chromium/TestExpectations:
4:37 PM Changeset in webkit [132159] by msaboff@apple.com
  • 3 edits
    2 adds in trunk

Regression(r131655): Crash in StringImpl::findIgnoringCase
https://bugs.webkit.org/show_bug.cgi?id=99753

Reviewed by Geoffrey Garen.

Source/WTF:

Fixed to use the searchLength to take into account the start index.

Added LayoutTests/fast/js/find-ignoring-case-regress-99753.html

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::findIgnoringCase):

LayoutTests:

New regression test.

  • fast/js/find-ignoring-case-regress-99753-expected.txt: Added.
  • fast/js/find-ignoring-case-regress-99753.html: Added.
4:36 PM Changeset in webkit [132158] by dpranke@chromium.org
  • 2 edits in trunk/Tools

webkitpy: remove unneeded debug messages from find_files()
https://bugs.webkit.org/show_bug.cgi?id=100041

Reviewed by Adam Barth.

This routine gets called all the time when loading the virtual
suites, and the debug messages were spamming me.

  • Scripts/webkitpy/common/find_files.py:

(_normalized_find):

4:35 PM Changeset in webkit [132157] by commit-queue@webkit.org
  • 27 edits
    2 adds in trunk/Source/WebCore

Refactor CachedResourceLoader: add CachedResourceRequest
https://bugs.webkit.org/show_bug.cgi?id=99736

Patch by Marja Hölttä <marja@chromium.org> on 2012-10-22
Reviewed by Adam Barth.

For fixing bugs 84883 and 92761,
CachedResourceLoader::requestResource should take as parameter
information about who initiated the request. But the parameter
list was already long. This gathers all the parameters into a
separate class, CachedResourceRequest. The next step is to add
information about who initiated the request into
CachedResourceRequest.

No new tests because no changes in functionality, just moving code
around.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSFontFaceSrcValue.cpp:

(WebCore::CSSFontFaceSrcValue::cachedFont):

  • css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::cachedImageSet):

  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::cachedImage):

  • css/StyleRuleImport.cpp:

(WebCore::StyleRuleImport::requestStyleSheet):

  • css/WebKitCSSSVGDocumentValue.cpp:

(WebCore::WebKitCSSSVGDocumentValue::load):

  • css/WebKitCSSShaderValue.cpp:

(WebCore::WebKitCSSShaderValue::cachedShader):

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::checkStyleSheet):

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::requestScript):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::loadRequest):

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement):

  • loader/LinkLoader.cpp:

(WebCore::LinkLoader::loadLink):

  • loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::load):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::requestFont):
(WebCore::CachedResourceLoader::requestTextTrack):
(WebCore::CachedResourceLoader::requestShader):
(WebCore::CachedResourceLoader::requestCSSStyleSheet):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestScript):
(WebCore::CachedResourceLoader::requestXSLStyleSheet):
(WebCore::CachedResourceLoader::requestSVGDocument):
(WebCore::CachedResourceLoader::requestLinkResource):
(WebCore::CachedResourceLoader::requestRawResource):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::requestPreload):
(WebCore::CachedResourceLoader::defaultCachedResourceOptions):
(WebCore):

  • loader/cache/CachedResourceLoader.h:

(WebCore):
(CachedResourceLoader):

  • loader/cache/CachedResourceRequest.cpp: Added.

(WebCore):
(WebCore::CachedResourceRequest::CachedResourceRequest):

  • loader/cache/CachedResourceRequest.h: Added.

(WebCore):
(CachedResourceRequest):
(WebCore::CachedResourceRequest::mutableResourceRequest):
(WebCore::CachedResourceRequest::resourceRequest):
(WebCore::CachedResourceRequest::charset):
(WebCore::CachedResourceRequest::setCharset):
(WebCore::CachedResourceRequest::options):
(WebCore::CachedResourceRequest::priority):
(WebCore::CachedResourceRequest::forPreload):
(WebCore::CachedResourceRequest::setForPreload):
(WebCore::CachedResourceRequest::defer):
(WebCore::CachedResourceRequest::setDefer):

  • loader/icon/IconLoader.cpp:

(WebCore::IconLoader::startLoading):

  • svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::requestImageResource):

  • svg/SVGFontFaceUriElement.cpp:

(WebCore::SVGFontFaceUriElement::loadFont):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::svgAttributeChanged):

  • xml/XSLImportRule.cpp:

(WebCore::XSLImportRule::loadSheet):

4:32 PM Changeset in webkit [132156] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

[V8] ASSERT that removeAllDOMObjects() is called only on worker threads
https://bugs.webkit.org/show_bug.cgi?id=100046

Reviewed by Eric Seidel.

This function is called only on worker threads. We should ASSERT that
fact and remove the dead code that tries to handle the main thread
case.

  • bindings/v8/V8DOMMap.cpp:

(WebCore::removeAllDOMObjects):

4:32 PM Changeset in webkit [132155] by tony@chromium.org
  • 4 edits
    4 adds in trunk/LayoutTests

Unreviewed, land render tree results for css3/flexbox pixel test that
landed earlier this morning. The results were pulled from the bots.

  • platform/gtk/TestExpectations:
  • platform/gtk/css3/flexbox/flexbox-baseline-margins-expected.txt: Added.
  • platform/mac/TestExpectations:
  • platform/mac/css3/flexbox/flexbox-baseline-margins-expected.txt: Added.
  • platform/qt/TestExpectations:
  • platform/qt/css3/flexbox/flexbox-baseline-margins-expected.txt: Added.
4:03 PM Changeset in webkit [132154] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Rebaseline another test after r131941 and r131991.

  • platform/efl/fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-line-expected.png:
3:57 PM Changeset in webkit [132153] by rakuco@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[EFL] Add some missing SVG expectations.

  • platform/efl/svg/transforms/svg-css-transforms-clip-path-expected.txt: Added.
  • platform/efl/svg/transforms/svg-css-transforms-expected.txt: Added.
3:53 PM Changeset in webkit [132152] by rakuco@webkit.org
  • 56 edits
    1 add in trunk/LayoutTests

[EFL] Rebaseline pixel expectations after r131941 and r131991, part 11.

Finally finish rebaselining the SVG tests!

  • platform/efl/svg/filters/animate-fill-expected.png:
  • platform/efl/svg/filters/feImage-animated-transform-on-target-rect-expected.png:
  • platform/efl/svg/filters/feImage-change-target-id-expected.png:
  • platform/efl/svg/filters/feImage-multiple-targets-id-change-expected.png:
  • platform/efl/svg/filters/feImage-reference-invalidation-expected.png:
  • platform/efl/svg/filters/feImage-remove-target-expected.png:
  • platform/efl/svg/filters/feImage-target-add-to-document-expected.png:
  • platform/efl/svg/filters/feImage-target-attribute-change-expected.png:
  • platform/efl/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png:
  • platform/efl/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png:
  • platform/efl/svg/filters/feImage-target-changes-id-expected.png:
  • platform/efl/svg/filters/feImage-target-id-change-expected.png:
  • platform/efl/svg/filters/feImage-target-inline-style-change-expected.png:
  • platform/efl/svg/filters/feImage-target-property-change-expected.png:
  • platform/efl/svg/filters/feImage-target-reappend-to-document-expected.png:
  • platform/efl/svg/filters/feImage-target-remove-from-document-expected.png:
  • platform/efl/svg/filters/feImage-target-style-change-expected.png:
  • platform/efl/svg/filters/filter-refresh-expected.png:
  • platform/efl/svg/filters/filter-width-update-expected.png: Added.
  • platform/efl/svg/filters/invalidate-on-child-layout-expected.png:
  • platform/efl/svg/hixie/perf/001-expected.png:
  • platform/efl/svg/hixie/perf/002-expected.png:
  • platform/efl/svg/hixie/perf/003-expected.png:
  • platform/efl/svg/hixie/perf/004-expected.png:
  • platform/efl/svg/hixie/perf/005-expected.png:
  • platform/efl/svg/hixie/perf/006-expected.png:
  • platform/efl/svg/hixie/perf/007-expected.png:
  • platform/efl/svg/repaint/filter-child-repaint-expected.png:
  • platform/efl/svg/repaint/image-href-change-expected.png:
  • platform/efl/svg/repaint/image-with-clip-path-expected.png:
  • platform/efl/svg/repaint/inner-svg-change-viewBox-contract-expected.png:
  • platform/efl/svg/repaint/inner-svg-change-viewBox-expected.png:
  • platform/efl/svg/repaint/inner-svg-change-viewPort-relative-expected.png:
  • platform/efl/svg/repaint/mask-clip-target-transform-expected.png:
  • platform/efl/svg/repaint/repainting-after-animation-element-removal-expected.png:
  • platform/efl/svg/repaint/text-mask-update-expected.png:
  • platform/efl/svg/text/append-text-node-to-tspan-expected.png:
  • platform/efl/svg/text/ems-display-none-expected.png:
  • platform/efl/svg/text/exs-display-none-expected.png:
  • platform/efl/svg/text/modify-text-node-in-tspan-expected.png:
  • platform/efl/svg/text/remove-text-node-from-tspan-expected.png:
  • platform/efl/svg/text/remove-tspan-from-text-expected.png:
  • platform/efl/svg/text/text-rescale-expected.png:
  • platform/efl/svg/text/text-text-05-t-expected.png:
  • platform/efl/svg/text/text-viewbox-rescale-expected.png:
  • platform/efl/svg/text/tspan-dynamic-positioning-expected.png:
  • platform/efl/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/efl/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/efl/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.png:
  • platform/efl/svg/zoom/page/relative-sized-document-scrollbars-expected.png:
  • platform/efl/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/efl/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.png:
  • platform/efl/svg/zoom/text/absolute-sized-document-scrollbars-expected.png:
  • platform/efl/svg/zoom/text/relative-sized-document-scrollbars-expected.png:
  • platform/efl/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
  • platform/efl/svg/zoom/text/zoom-foreignObject-expected.png:
3:50 PM Changeset in webkit [132151] by abarth@webkit.org
  • 7 edits in trunk/Source/WebCore

[V8] We should call the faster v8::Integer::New APIs
https://bugs.webkit.org/show_bug.cgi?id=100016

Reviewed by Eric Seidel.

In working to remove the integer cache, I added some faster APIs for
creating v8::Integers. These APIs are faster than the old APIs, but not
quite fast enough to replace the integer cache. We should still use
them when we miss the integer cache.

I've also included a small refactoring to V8PerIsolateData to make it
clearer when we're calling v8::Isolate::GetCurrent().

  • bindings/v8/DOMData.cpp:

(WebCore::DOMData::getCurrentStore):

  • bindings/v8/V8Binding.h:

(WebCore::v8ExternalString):
(WebCore::v8Integer):
(WebCore::v8UnsignedInteger):

  • bindings/v8/V8PerIsolateData.h:

(WebCore::V8PerIsolateData::current):
(WebCore::V8PerIsolateData::from):

  • bindings/v8/V8ValueCache.cpp:

(WebCore::StringCache::v8ExternalStringSlow):
(WebCore::IntegerCache::createSmallIntegers):

  • bindings/v8/V8ValueCache.h:

(WebCore::IntegerCache::v8Integer):
(WebCore::IntegerCache::v8UnsignedInteger):
(IntegerCache):

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::getContextCallback):

3:46 PM Changeset in webkit [132150] by rakuco@webkit.org
  • 67 edits in trunk/LayoutTests

[EFL] Rebaseline pixel expectations after r131941 and r131991, part 10.

  • platform/efl/svg/dynamic-updates/SVGPatternElement-dom-patternUnits-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGPatternElement-dom-width-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGPatternElement-dom-x-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGPatternElement-dom-y-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGPatternElement-svgdom-height-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGPatternElement-svgdom-patternContentUnits-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGPatternElement-svgdom-patternUnits-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGPatternElement-svgdom-width-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRectElement-dom-height-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRectElement-dom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRectElement-dom-width-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRectElement-dom-x-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRectElement-dom-y-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRectElement-svgdom-height-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRectElement-svgdom-width-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRectElement-svgdom-x-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRectElement-svgdom-y-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGTRefElement-dom-href-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGTextElement-dom-dx-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGTextElement-dom-dy-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGTextElement-dom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGTextElement-dom-transform-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGTextElement-dom-x-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGTextElement-dom-y-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGTextElement-svgdom-rotate-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGTextElement-svgdom-transform-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGTextElement-svgdom-x-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGTextElement-svgdom-y-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png:
3:40 PM Changeset in webkit [132149] by jchaffraix@webkit.org
  • 7 edits
    2 adds in trunk

RenderTableCol::computePreferredLogicalWidths and RenderTableCol::layout should never be called
https://bugs.webkit.org/show_bug.cgi?id=99861

Reviewed by Ojan Vafai.

Source/WebCore:

RenderTableCol's computePreferredLogicalWidths and layout's only purpose were to clear the preferred logical
widths dirty / layout flag so that we would properly propagate the information to our containing table. This
led to clunky code where the table layout code had to forcefully call RenderTableCol::computePreferredLogicalWidths
or else we would ignore the next layout hint on the <col> or <colgroup>.

Test: fast/table/col-span-change-relayout.html

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::recalcColumn):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):
Simplified the code now that we only need to iterate over the sections.

  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::calcWidthArray):
Removed call to computePreferredLogicalWidths.

  • rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::styleDidChange):
(WebCore::RenderTableCol::updateFromElement):
Forward a layout hint to the table so that we properly recompute the cell's logical withs.

(WebCore::RenderTableCol::computePreferredLogicalWidths):
(WebCore::RenderTableCol::layout):
Change our implementations of those 2 methods to be no-ops, while enforcing that they are
never called.

(WebCore::RenderTableCol::propagateLayoutCueToTable):
New helper function that forward any layout cue to the containing table, this works around
us not clearing the flags which confuses RenderObject markContainingBlocksForLayout and
invalidateContainerPreferredLogicalWidths.

  • rendering/RenderTableCol.h:

Made the function that we are not expected to be called private.

LayoutTests:

Added this test as the code in RenderTableCol::updateFromElement wasn't properly covered.

  • fast/table/col-span-change-relayout-expected.txt: Added.
  • fast/table/col-span-change-relayout.html: Added.
3:37 PM Changeset in webkit [132148] by rakuco@webkit.org
  • 56 edits in trunk/LayoutTests

[EFL] Rebaseline pixel expectations after r131941 and r131991, part 9.

  • platform/efl/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLineElement-dom-x1-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLineElement-dom-x2-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLineElement-dom-y1-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLineElement-dom-y2-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLineElement-svgdom-x1-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLineElement-svgdom-x2-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLineElement-svgdom-y1-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLineElement-svgdom-y2-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-dom-markerUnits-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-dom-markerWidth-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-dom-orient-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-dom-refX-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-dom-refY-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-svgdom-markerHeight-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-svgdom-markerUnits-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-svgdom-markerWidth-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-svgdom-orientAngle-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-svgdom-orientType-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-svgdom-refX-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-svgdom-refY-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAuto-call-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMaskElement-dom-height-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMaskElement-dom-width-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMaskElement-dom-x-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMaskElement-dom-y-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMaskElement-svgdom-height-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMaskElement-svgdom-width-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMaskElement-svgdom-x-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMaskElement-svgdom-y-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGPathElement-dom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGPatternElement-dom-height-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-expected.png:
3:36 PM Changeset in webkit [132147] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

[User Timing]Integrate with Perforamnce Timeline.
https://bugs.webkit.org/show_bug.cgi?id=91072.

Patch by Pan Deng <pan.deng@intel.com> on 2012-10-22
Reviewed by Tony Gentilcore.

This patch expose user timing entries via performance timeline interface. JavaScriptCore custom binding will be another patch

No new tests, user timing test cases have been landed.

  • page/Performance.cpp:

(WebCore::Performance::Performance):
(WebCore::Performance::webkitGetEntries):
(WebCore::Performance::webkitGetEntriesByType):
(WebCore::Performance::webkitGetEntriesByName):

  • page/PerformanceEntry.h:

(WebCore::PerformanceEntry::startTimeCompareLessThan):
(PerformanceEntry):

  • page/PerformanceEntryList.cpp:

(WebCore::PerformanceEntryList::sort):
(WebCore):

  • page/PerformanceEntryList.h:

(PerformanceEntryList):

  • page/PerformanceUserTiming.cpp:

(WebCore::convertToEntrySequence):
(WebCore):
(WebCore::getEntrySequenceByName):
(WebCore::UserTiming::getMarks):
(WebCore::UserTiming::getMeasures):

  • page/PerformanceUserTiming.h:

(UserTiming):

3:34 PM Changeset in webkit [132146] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Modify obsolete code in User Timing
https://bugs.webkit.org/show_bug.cgi?id=99851

Patch by Pan Deng <pan.deng@intel.com> on 2012-10-22
Reviewed by Tony Gentilcore.

Modify user timing implementation as PlatformString.h, prefix of webkitNow is removed, etc.

No new tests.

  • page/PerformanceUserTiming.cpp:

(WebCore::insertPerformanceEntry):
(WebCore::UserTiming::mark):
(WebCore::UserTiming::measure):

  • page/PerformanceUserTiming.h:
3:28 PM Changeset in webkit [132145] by rakuco@webkit.org
  • 56 edits in trunk/LayoutTests

[EFL] Rebaseline pixel expectations after r131941 and r131991, part 8.

  • platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterElement-dom-height-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterElement-dom-width-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterElement-dom-x-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterElement-dom-y-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterElement-svgdom-height-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterElement-svgdom-width-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterElement-svgdom-x-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterElement-svgdom-y-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGForeignObjectElement-dom-height-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGForeignObjectElement-dom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGForeignObjectElement-dom-width-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGForeignObjectElement-dom-x-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGForeignObjectElement-dom-y-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGForeignObjectElement-svgdom-height-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGForeignObjectElement-svgdom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGForeignObjectElement-svgdom-width-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGForeignObjectElement-svgdom-x-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGForeignObjectElement-svgdom-y-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGGElement-dom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGGElement-svgdom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGImageElement-dom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
3:20 PM Changeset in webkit [132144] by dpranke@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, update more Chromium ML expectations.

  • platform/chromium-mac-mountainlion/TestExpectations:
  • platform/chromium/TestExpectations:
3:09 PM Changeset in webkit [132143] by mark.lam@apple.com
  • 23 edits in trunk

Change stack recursion checks to be based on stack availability.
https://bugs.webkit.org/show_bug.cgi?id=99872.

Reviewed by Filip Pizlo and Geoffrey Garen.

Source/JavaScriptCore:

  • Remove m_reentryDepth, ThreadStackType which are now obsolete.
  • Replaced the reentryDepth checks with a StackBounds check.
  • Added the Interpreter::StackPolicy class to compute a reasonable stack capacity requirement given the native stack that the interpreter is executing on at that time.
  • Reserved an amount of JSStack space for the use of error handling and enable its use (using Interpreter::ErrorHandlingMode) when we're about to throw or report an exception.
  • Interpreter::StackPolicy also allows more native stack space to be used when in ErrorHandlingMode. This is needed in the case of native stack overflows.
  • Fixed the parser so that it throws a StackOverflowError instead of a SyntaxError when it encounters a stack overflow.
  • API/JSContextRef.cpp:

(JSContextGroupCreate):
(JSGlobalContextCreateInGroup):

(JSC::Interpreter::ErrorHandlingMode::ErrorHandlingMode):
(JSC):
(JSC::Interpreter::ErrorHandlingMode::~ErrorHandlingMode):
(JSC::Interpreter::StackPolicy::StackPolicy):
(JSC::Interpreter::Interpreter):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):

  • interpreter/Interpreter.h:

(JSC):
(Interpreter):
(ErrorHandlingMode):
(StackPolicy):
(JSC::Interpreter::StackPolicy::requiredCapacity):

  • interpreter/JSStack.cpp:

(JSC):
(JSC::JSStack::JSStack):
(JSC::JSStack::growSlowCase):
(JSC::JSStack::enableErrorStackReserve):
(JSC::JSStack::disableErrorStackReserve):

  • interpreter/JSStack.h:

(JSStack):
(JSC::JSStack::reservationEnd):
(JSC):

  • jsc.cpp:

(jscmain):

  • parser/Parser.cpp:

(JSC::::Parser):

  • parser/Parser.h:

(Parser):
(JSC::::parse):

  • runtime/ExceptionHelpers.cpp:

(JSC::throwStackOverflowError):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::createContextGroup):
(JSC::JSGlobalData::create):
(JSC::JSGlobalData::createLeaked):
(JSC::JSGlobalData::sharedInstance):

  • runtime/JSGlobalData.h:

(JSC):
(JSGlobalData):

  • runtime/StringRecursionChecker.h:

(JSC::StringRecursionChecker::performCheck):

  • testRegExp.cpp:

(realMain):

Source/WebCore:

Removed the use of ThreadStackType. Enabled the reserved JSStack space
for error processing before doing work in reportException().

  • bindings/js/JSDOMBinding.cpp:

(WebCore::reportException):

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::commonJSGlobalData):

  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::WorkerScriptController):

LayoutTests:

Updated test baseline.

  • fast/js/global-recursion-on-full-stack-expected.txt:
  • fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt:
3:09 PM Changeset in webkit [132142] by andersca@apple.com
  • 25 edits in trunk/Source/WebKit2

Remove MessageReceiverMap::deprecatedAddMessageReceiver
https://bugs.webkit.org/show_bug.cgi?id=100012

Reviewed by Andreas Kling.

Get rid of MessageReceiverMap::deprecatedAddMessageReceiver and make callers use addMessageReceiver instead.
Also, remove the message receiver map inside Connection and add a message receiver map to WebProcess instead.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::dispatchMessage):

  • Platform/CoreIPC/Connection.h:

(Connection):

  • Platform/CoreIPC/MessageReceiverMap.cpp:

(CoreIPC::MessageReceiverMap::invalidate):
(CoreIPC::MessageReceiverMap::dispatchMessage):
(CoreIPC::MessageReceiverMap::dispatchSyncMessage):

  • Platform/CoreIPC/MessageReceiverMap.h:

(MessageReceiverMap):

  • UIProcess/Notifications/WebNotificationManagerProxy.cpp:

(WebKit::WebNotificationManagerProxy::WebNotificationManagerProxy):

  • UIProcess/WebApplicationCacheManagerProxy.cpp:

(WebKit::WebApplicationCacheManagerProxy::WebApplicationCacheManagerProxy):

  • UIProcess/WebContext.cpp:
  • UIProcess/WebContext.h:

(WebContext):

  • UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::WebCookieManagerProxy):

  • UIProcess/WebDatabaseManagerProxy.cpp:

(WebKit::WebDatabaseManagerProxy::WebDatabaseManagerProxy):

  • UIProcess/WebGeolocationManagerProxy.cpp:

(WebKit::WebGeolocationManagerProxy::WebGeolocationManagerProxy):

  • UIProcess/WebIconDatabase.cpp:

(WebKit::WebIconDatabase::WebIconDatabase):

  • UIProcess/WebKeyValueStorageManagerProxy.cpp:

(WebKit::WebKeyValueStorageManagerProxy::WebKeyValueStorageManagerProxy):

  • UIProcess/WebMediaCacheManagerProxy.cpp:

(WebKit::WebMediaCacheManagerProxy::WebMediaCacheManagerProxy):

  • UIProcess/WebResourceCacheManagerProxy.cpp:

(WebKit::WebResourceCacheManagerProxy::WebResourceCacheManagerProxy):

  • WebProcess/Authentication/AuthenticationManager.cpp:

(WebKit::AuthenticationManager::AuthenticationManager):

  • WebProcess/Geolocation/WebGeolocationManager.cpp:

(WebKit::WebGeolocationManager::WebGeolocationManager):
(WebKit::WebGeolocationManager::registerWebPage):

  • WebProcess/Geolocation/WebGeolocationManager.h:

(WebGeolocationManager):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::addMessageReceiver):
(WebKit):
(WebKit::WebProcess::didReceiveSyncMessage):
(WebKit::WebProcess::didReceiveMessage):

  • WebProcess/WebProcess.h:

(WebProcess):

3:05 PM Changeset in webkit [132141] by kling@webkit.org
  • 11 edits
    2 adds in trunk

REGRESSION(r131104): Heap-use-after-free in WebCore::Element::attributeChanged
<http://webkit.org/b/99937>

Reviewed by Anders Carlsson.

Source/WebCore:

Setting the "type" attribute on an HTMLInputElement that has no "value" attribute set will cause the
input type changing mechanism to write a value attribute onto the element. This happens in
HTMLInputElement::updateType(), below parseAttribute().

It's done via Element::setAttribute(), so we end up re-entering Element::setAttributeInternal()
where the 'existingAttribute' pointer may now be invalid if adding the "value" attribute caused
a reallocation in the ElementAttributeData's underlying Vector<Attribute>.

To make it harder to introduce this kind of bug in the future, I changed almost all functions that take
a "const Attribute&" to take a QualifiedName/AtomicString couple instead (the idea being that the
fewer references into the attribute store we have, the better.)

Test: fast/html/input-type-change-crash.html

  • dom/Attr.cpp:

(WebCore::Attr::setValue):
(WebCore::Attr::childrenChanged):

  • dom/Element.cpp:

(WebCore::Element::setAttributeInternal):
(WebCore::Element::attributeChanged):
(WebCore::Element::parserSetAttributes):
(WebCore::Element::addAttributeInternal):
(WebCore::Element::didAddAttribute):
(WebCore::Element::didModifyAttribute):
(WebCore::Element::didRemoveAttribute):

  • dom/Element.h:

(Element):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::cloneDataFrom):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::attributeChanged):

  • dom/StyledElement.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateType):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::attributeChanged):

  • svg/SVGElement.h:

(SVGElement):

LayoutTests:

  • fast/html/input-type-change-crash-expected.txt: Added.
  • fast/html/input-type-change-crash.html: Added.
2:53 PM Changeset in webkit [132140] by jsbell@chromium.org
  • 7 edits in trunk

IndexedDB: Bounds check for IDBCursor.advance() incorrect
https://bugs.webkit.org/show_bug.cgi?id=100014

Reviewed by Tony Chang.

Source/WebCore:

Fix introduced by trac.webkit.org/changeset/131658 restricted cursor.advance()'s argument
as [EnforceRange] unsigned long long, but it's typed as [EnforceRange] unsigned long; the
useless comparison was caught by a clang check.

In lieu of webkit.org/b/96798 make it long long and correct the range check.

Test: storage/indexeddb/cursor-advance.html

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::advance):

  • Modules/indexeddb/IDBCursor.h:

(IDBCursor):

  • Modules/indexeddb/IDBCursor.idl:

LayoutTests:

Assert that advance(232) throws and advance(232-1) does not, per WebIDL.

  • storage/indexeddb/cursor-advance-expected.txt:
  • storage/indexeddb/resources/cursor-advance.js:

(testBadAdvance.advanceBadly):
(testBadAdvance):
(testEdges.request.onsuccess):
(testEdges):

2:49 PM Changeset in webkit [132139] by tony@chromium.org
  • 2 edits in trunk/Tools

[chromium] Add Mac 10.7 Debug bot since it's on the waterfall
https://bugs.webkit.org/show_bug.cgi?id=100028

Reviewed by Eric Seidel.

garden-o-matic can't baseline without this entry.

  • Scripts/webkitpy/layout_tests/port/builders.py:
2:38 PM Changeset in webkit [132138] by jochen@chromium.org
  • 25 edits
    2 copies
    2 moves in trunk/Tools

[chromium] introduce WebTask to the TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=99964

Reviewed by Adam Barth.

I'm also removing the dependency on webkit_support, and instead go
through the WebTestDelegate interface.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
  • DumpRenderTree/chromium/DRTDevToolsAgent.h:

(DRTDevToolsAgent::taskList):

  • DumpRenderTree/chromium/DRTDevToolsClient.cpp:
  • DumpRenderTree/chromium/DRTDevToolsClient.h:

(DRTDevToolsClient::taskList):

  • DumpRenderTree/chromium/DRTTestRunner.cpp:

(InvokeCallbackTask::InvokeCallbackTask):

  • DumpRenderTree/chromium/DRTTestRunner.h:

(DRTTestRunner::taskList):
(DRTTestRunner::WorkQueue::taskList):

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
(RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
(RTCStatsRequestSucceededTask::RTCStatsRequestSucceededTask):
(RTCVoidRequestTask::RTCVoidRequestTask):
(StringDataTask::StringDataTask):
(CharPtrDataTask::CharPtrDataTask):
(DataChannelReadyStateTask::DataChannelReadyStateTask):
(RTCPeerConnectionReadyStateTask::RTCPeerConnectionReadyStateTask):

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:

(MockWebRTCPeerConnectionHandler):
(MockWebRTCPeerConnectionHandler::taskList):

  • DumpRenderTree/chromium/MockWebSpeechInputController.cpp:

(MockWebSpeechInputController::SpeechTask::SpeechTask):

  • DumpRenderTree/chromium/MockWebSpeechInputController.h:

(MockWebSpeechInputController::taskList):
(MockWebSpeechInputController):

  • DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
  • DumpRenderTree/chromium/MockWebSpeechRecognizer.h:

(MockWebSpeechRecognizer::taskList):
(MockWebSpeechRecognizer):
(MockWebSpeechRecognizer::StepTask::StepTask):

  • DumpRenderTree/chromium/Task.cpp: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/Task.cpp.

(WebTestRunner):
(WebTestRunner::invokeTask):
(TaskWrapper):
(WebTestRunner::TaskWrapper::TaskWrapper):
(WebTestRunner::TaskWrapper::~TaskWrapper):
(WebTestRunner::TaskWrapper::Run):
(postTask):
(postDelayedTask):

  • DumpRenderTree/chromium/Task.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h.

(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/public/WebTask.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/Task.h.

(WebTestRunner):
(WebTask):
(WebTaskList):
(WebMethodTask):
(WebTestRunner::WebMethodTask::WebMethodTask):
(WebTestRunner::WebMethodTask::~WebMethodTask):
(WebTestRunner::WebMethodTask::run):
(WebTestRunner::WebMethodTask::cancel):

  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebTestRunner):
(WebTestDelegate):

  • DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):
(WebTestRunner::EventSender::scheduleAsynchronousClick):
(WebTestRunner::KeyDownTask::KeyDownTask):
(WebTestRunner::EventSender::scheduleAsynchronousKeyDown):

  • DumpRenderTree/chromium/TestRunner/src/EventSender.h:

(WebTestRunner::EventSender::taskList):
(EventSender):

  • DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:

(WebTestRunner):
(TestDelegate):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
  • DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/Task.cpp.

(WebTestRunner):
(WebTestRunner::WebTask::WebTask):
(WebTestRunner::WebTask::~WebTask):
(WebTestRunner::WebTaskList::WebTaskList):
(WebTestRunner::WebTaskList::~WebTaskList):
(WebTestRunner::WebTaskList::registerTask):
(WebTestRunner::WebTaskList::unregisterTask):
(WebTestRunner::WebTaskList::revokeAll):

  • DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestInterfaces::Internal):
(WebTestRunner::WebTestInterfaces::Internal::postTask):
(WebTestRunner):
(WebTestRunner::WebTestInterfaces::Internal::postDelayedTask):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::initialize):

  • DumpRenderTree/chromium/WebUserMediaClientMock.cpp:

(UserMediaRequestTask::UserMediaRequestTask):

  • DumpRenderTree/chromium/WebUserMediaClientMock.h:

(WebUserMediaClientMock::taskList):
(WebUserMediaClientMock):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::postTask):
(WebViewHost::postDelayedTask):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):
(WebViewHost::taskList):
(WebViewHost::HostMethodTask::HostMethodTask):

2:38 PM Changeset in webkit [132137] by rakuco@webkit.org
  • 76 edits in trunk/LayoutTests

[EFL] Rebaseline pixel expectations after r131941 and r131991, part 7.

  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEOffsetElement-dom-dx-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEOffsetElement-dom-dy-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEOffsetElement-dom-in-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dx-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dy-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEOffsetElement-svgdom-in-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-dom-limitingConeAngle-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtZ-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-dom-specularExponent-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-svgdom-limitingConeAngle-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtZ-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-svgdom-specularExponent-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-svgdom-z-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png:
2:32 PM Changeset in webkit [132136] by tony@chromium.org
  • 14 edits in trunk

WebKit does not support 'flex-wrap: nowrap'
https://bugs.webkit.org/show_bug.cgi?id=99924

Reviewed by Ojan Vafai.

Source/WebCore:

The spec changed back from using none to nowrap for the single-line
flexbox case.
http://dev.w3.org/csswg/css3-flexbox/#flex-wrap-property

No new tests, covered by css3/flexbox/css-properties.html and others.

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFlexWrap):

  • css/CSSValueKeywords.in:
  • rendering/RenderBox.cpp:

(WebCore::isStretchingColumnFlexItem):
(WebCore::RenderBox::sizesLogicalWidthToFitContent):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::isMultiline):

  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:

LayoutTests:

Update expectations (find and replace none with nowrap).

  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/css-properties.html:
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
2:15 PM Changeset in webkit [132135] by eae@chromium.org
  • 200 edits
    30 adds
    103 deletes in trunk/LayoutTests

Unreviewed chromium windows gardening.

  • platform/chromium-linux/compositing/shadows/shadow-drawing-expected.txt: Removed.
  • platform/chromium-linux/css1/text_properties/vertical_align-expected.txt: Removed.
  • platform/chromium-linux/css2.1/t0804-c5509-padn-l-03-f-g-expected.txt: Removed.
  • platform/chromium-linux/css3/flexbox/flexbox-baseline-expected.txt: Removed.
  • platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
  • platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Removed.
  • platform/chromium-linux/fast/css/acid2-expected.txt: Removed.
  • platform/chromium-linux/fast/css/acid2-pixel-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/007-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/placeholder-position-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/search-vertical-alignment-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-child-1-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-child-2-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-details-child-1-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-details-child-2-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-1-and-click-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-1-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-10-and-click-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-10-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-2-and-click-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-2-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-3-and-click-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-3-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-4-and-click-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-4-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-5-and-click-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-5-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-6-and-click-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-6-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-7-and-click-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-7-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-8-and-click-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-8-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-9-and-click-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-9-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-child-1-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-child-2-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-marker-style-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-nested-1-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-nested-2-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-no-summary1-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-no-summary2-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-no-summary3-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-no-summary4-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-open-javascript-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-open1-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-open2-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-open3-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-open4-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-open5-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-open6-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-position-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-remove-child-1-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-remove-child-2-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-remove-summary-1-and-click-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-remove-summary-1-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-remove-summary-2-and-click-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-remove-summary-2-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-remove-summary-3-and-click-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-remove-summary-3-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-remove-summary-4-and-click-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-remove-summary-4-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-remove-summary-5-and-click-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-remove-summary-5-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-remove-summary-6-and-click-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-remove-summary-6-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-remove-summary-child-1-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-remove-summary-child-2-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-writing-mode-expected.txt: Removed.
  • platform/chromium-linux/fast/images/imagemap-focus-ring-zoom-expected.txt: Removed.
  • platform/chromium-linux/fast/inline/002-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/table-vertical-align-expected.txt: Removed.
  • platform/chromium-linux/fast/writing-mode/fieldsets-expected.txt: Removed.
  • platform/chromium-linux/http/tests/misc/acid2-expected.txt: Removed.
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zoom-expected.txt: Removed.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/shadows: Removed.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.txt: Removed.
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-2-expected.txt: Removed.
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.txt: Removed.
  • platform/chromium-linux/svg/transforms/svg-css-transforms-clip-path-expected.txt: Removed.
  • platform/chromium-linux/svg/transforms/svg-css-transforms-expected.txt: Removed.
  • platform/chromium-linux/svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Removed.
  • platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Removed.
  • platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Removed.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Removed.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Removed.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug30692-expected.txt: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug43854-2-expected.txt: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug4427-expected.txt: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug6404-expected.txt: Removed.
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt: Removed.
  • platform/chromium-linux/transforms/svg-vs-css-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/css/acid2-expected.png: Added.
  • platform/chromium-mac-lion/fast/css/acid2-pixel-expected.png: Added.
  • platform/chromium-mac-lion/fast/inline/002-expected.png: Added.
  • platform/chromium-mac-lion/fast/multicol: Added.
  • platform/chromium-mac-lion/fast/multicol/table-vertical-align-expected.png: Added.
  • platform/chromium-mac-lion/fast/repaint/repaint-across-writing-mode-boundary-expected.png: Added.
  • platform/chromium-mac-lion/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Added.
  • platform/chromium-mac-lion/http/tests/misc: Added.
  • platform/chromium-mac-lion/http/tests/misc/acid2-expected.png: Added.
  • platform/chromium-mac-lion/http/tests/misc/acid2-pixel-expected.png: Added.
  • platform/chromium-mac-lion/svg/transforms/svg-css-transforms-clip-path-expected.png: Added.
  • platform/chromium-mac-lion/svg/transforms/svg-css-transforms-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug14323-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug43854-2-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug4427-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug6404-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug1647-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug56024-expected.png: Added.
  • platform/chromium-mac-lion/transforms: Added.
  • platform/chromium-mac-lion/transforms/svg-vs-css-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/acid2-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/css/acid2-pixel-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/repaint-across-writing-mode-boundary-expected.png: Removed.
  • platform/chromium-mac-snowleopard/http/tests/misc/acid2-expected.png: Removed.
  • platform/chromium-mac-snowleopard/http/tests/misc/acid2-pixel-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/transforms/svg-css-transforms-clip-path-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/transforms/svg-css-transforms-expected.png: Removed.
  • platform/chromium-mac-snowleopard/transforms/svg-vs-css-expected.png: Removed.
  • platform/chromium-win-xp/fast/inline: Added.
  • platform/chromium-win-xp/fast/inline-block/contenteditable-baseline-expected.txt:
  • platform/chromium-win-xp/fast/inline/vertical-align-text-bottom-expected.txt: Added.
  • platform/chromium-win-xp/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/chromium-win-xp/http/tests/misc/acid2-pixel-expected.txt: Added.
  • platform/chromium-win-xp/svg/transforms: Removed.
  • platform/chromium-win-xp/svg/zoom/page/zoom-hixie-mixed-009-expected.png: Removed.
  • platform/chromium-win-xp/tables/mozilla/bugs/bug14323-expected.txt: Added.
  • platform/chromium-win-xp/tables/mozilla_expected_failures/bugs: Added.
  • platform/chromium-win-xp/tables/mozilla_expected_failures/bugs/bug1647-expected.txt: Added.
  • platform/chromium-win-xp/tables/mozilla_expected_failures/bugs/bug56024-expected.txt: Added.
  • platform/chromium-win/compositing/shadows/shadow-drawing-expected.txt:
  • platform/chromium-win/css1/text_properties/vertical_align-expected.png:
  • platform/chromium-win/css1/text_properties/vertical_align-expected.txt:
  • platform/chromium-win/css2.1/t0804-c5509-padn-l-03-f-g-expected.txt:
  • platform/chromium-win/css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • platform/chromium-win/css3/flexbox/flexbox-baseline-expected.png:
  • platform/chromium-win/css3/flexbox/flexbox-baseline-expected.txt:
  • platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Removed.
  • platform/chromium-win/fast/css/acid2-expected.txt:
  • platform/chromium-win/fast/css/acid2-pixel-expected.txt:
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.png:
  • platform/chromium-win/fast/forms/007-expected.png:
  • platform/chromium-win/fast/forms/007-expected.txt:
  • platform/chromium-win/fast/forms/basic-buttons-expected.png:
  • platform/chromium-win/fast/forms/basic-buttons-expected.txt:
  • platform/chromium-win/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
  • platform/chromium-win/fast/forms/placeholder-position-expected.txt:
  • platform/chromium-win/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-win/fast/forms/search-vertical-alignment-expected.txt:
  • platform/chromium-win/fast/forms/searchfield-heights-expected.png:
  • platform/chromium-win/fast/forms/searchfield-heights-expected.txt:
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium-win/fast/html/details-add-child-1-expected.png:
  • platform/chromium-win/fast/html/details-add-child-1-expected.txt:
  • platform/chromium-win/fast/html/details-add-child-2-expected.png:
  • platform/chromium-win/fast/html/details-add-child-2-expected.txt:
  • platform/chromium-win/fast/html/details-add-details-child-1-expected.png:
  • platform/chromium-win/fast/html/details-add-details-child-1-expected.txt:
  • platform/chromium-win/fast/html/details-add-details-child-2-expected.png:
  • platform/chromium-win/fast/html/details-add-details-child-2-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-1-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-1-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-10-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-10-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-2-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-2-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-3-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-3-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-4-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-4-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-5-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-5-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-6-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-6-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-7-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-7-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-8-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-8-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-9-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-9-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-child-1-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-child-1-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-child-2-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-child-2-expected.txt:
  • platform/chromium-win/fast/html/details-marker-style-expected.png:
  • platform/chromium-win/fast/html/details-marker-style-expected.txt:
  • platform/chromium-win/fast/html/details-nested-1-expected.png:
  • platform/chromium-win/fast/html/details-nested-1-expected.txt:
  • platform/chromium-win/fast/html/details-nested-2-expected.png:
  • platform/chromium-win/fast/html/details-nested-2-expected.txt:
  • platform/chromium-win/fast/html/details-no-summary1-expected.png:
  • platform/chromium-win/fast/html/details-no-summary1-expected.txt:
  • platform/chromium-win/fast/html/details-no-summary2-expected.png:
  • platform/chromium-win/fast/html/details-no-summary2-expected.txt:
  • platform/chromium-win/fast/html/details-no-summary3-expected.png:
  • platform/chromium-win/fast/html/details-no-summary3-expected.txt:
  • platform/chromium-win/fast/html/details-no-summary4-expected.png:
  • platform/chromium-win/fast/html/details-no-summary4-expected.txt:
  • platform/chromium-win/fast/html/details-open-javascript-expected.png:
  • platform/chromium-win/fast/html/details-open-javascript-expected.txt:
  • platform/chromium-win/fast/html/details-open1-expected.png:
  • platform/chromium-win/fast/html/details-open1-expected.txt:
  • platform/chromium-win/fast/html/details-open2-expected.png:
  • platform/chromium-win/fast/html/details-open2-expected.txt:
  • platform/chromium-win/fast/html/details-open3-expected.png:
  • platform/chromium-win/fast/html/details-open3-expected.txt:
  • platform/chromium-win/fast/html/details-open4-expected.png:
  • platform/chromium-win/fast/html/details-open4-expected.txt:
  • platform/chromium-win/fast/html/details-open5-expected.png:
  • platform/chromium-win/fast/html/details-open5-expected.txt:
  • platform/chromium-win/fast/html/details-open6-expected.png:
  • platform/chromium-win/fast/html/details-open6-expected.txt:
  • platform/chromium-win/fast/html/details-position-expected.png:
  • platform/chromium-win/fast/html/details-position-expected.txt:
  • platform/chromium-win/fast/html/details-remove-child-1-expected.png:
  • platform/chromium-win/fast/html/details-remove-child-1-expected.txt:
  • platform/chromium-win/fast/html/details-remove-child-2-expected.png:
  • platform/chromium-win/fast/html/details-remove-child-2-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-1-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-1-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-2-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-2-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-3-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-3-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-4-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-4-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-5-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-5-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-6-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-6-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-child-1-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-child-1-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-child-2-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-child-2-expected.txt:
  • platform/chromium-win/fast/html/details-replace-summary-child-expected.png:
  • platform/chromium-win/fast/html/details-replace-summary-child-expected.txt:
  • platform/chromium-win/fast/html/details-replace-text-expected.png:
  • platform/chromium-win/fast/html/details-replace-text-expected.txt:
  • platform/chromium-win/fast/html/details-writing-mode-expected.png:
  • platform/chromium-win/fast/html/details-writing-mode-expected.txt:
  • platform/chromium-win/fast/images/imagemap-focus-ring-zoom-expected.png:
  • platform/chromium-win/fast/images/imagemap-focus-ring-zoom-expected.txt:
  • platform/chromium-win/fast/inline-block/contenteditable-baseline-expected.txt:
  • platform/chromium-win/fast/inline/002-expected.txt:
  • platform/chromium-win/fast/inline/vertical-align-text-bottom-expected.png:
  • platform/chromium-win/fast/inline/vertical-align-text-bottom-expected.txt:
  • platform/chromium-win/fast/multicol/table-vertical-align-expected.txt:
  • platform/chromium-win/fast/repaint/4774354-expected.png:
  • platform/chromium-win/fast/repaint/4776765-expected.png:
  • platform/chromium-win/fast/repaint/caret-outside-block-expected.png:
  • platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/chromium-win/fast/repaint/selection-rl-expected.png:
  • platform/chromium-win/fast/writing-mode/fieldsets-expected.png:
  • platform/chromium-win/fast/writing-mode/fieldsets-expected.txt:
  • platform/chromium-win/http/tests/misc/acid2-expected.txt:
  • platform/chromium-win/http/tests/misc/acid2-pixel-expected.txt:
  • platform/chromium-win/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zoom-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zoom-expected.txt: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.txt:
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-2-expected.png:
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-2-expected.txt:
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.txt:
  • platform/chromium-win/svg/transforms/svg-css-transforms-clip-path-expected.txt:
  • platform/chromium-win/svg/transforms/svg-css-transforms-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-hixie-mixed-009-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug14323-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug14323-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug30692-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug43854-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug43854-2-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4427-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug6404-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug6404-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1647-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1647-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug56024-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug56024-expected.txt:
  • platform/chromium-win/transforms/svg-vs-css-expected.txt:
2:10 PM Changeset in webkit [132134] by tony@chromium.org
  • 2 edits
    1 move
    5 adds in trunk/LayoutTests

[chromium] Unreviewed, Win and Mac baselines for css3/flexbox/flexbox-baseline-margins.html.

  • platform/chromium-mac-lion/css3/flexbox/flexbox-baseline-margins-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/flexbox/flexbox-baseline-margins-expected.png: Added.
  • platform/chromium-mac/css3/flexbox/flexbox-baseline-margins-expected.png: Added.
  • platform/chromium-mac/css3/flexbox/flexbox-baseline-margins-expected.txt: Added.
  • platform/chromium-win/css3/flexbox/flexbox-baseline-margins-expected.png: Added.
  • platform/chromium-win/css3/flexbox/flexbox-baseline-margins-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css3/flexbox/flexbox-baseline-margins-expected.txt.
  • platform/chromium/TestExpectations:
2:00 PM Changeset in webkit [132133] by rakuco@webkit.org
  • 52 edits in trunk/LayoutTests

[EFL] Rebaseline pixel expectations after r131941 and r131991, part 6.

  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDistantLightElement-dom-azimuth-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDistantLightElement-dom-elevation-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDistantLightElement-svgdom-azimuth-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDistantLightElement-svgdom-elevation-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.png:
1:53 PM Changeset in webkit [132132] by rakuco@webkit.org
  • 41 edits in trunk/LayoutTests

[EFL] Rebaseline pixel expectations after r131941 and r131991, part 5.

  • platform/efl/svg/dynamic-updates/SVGEllipseElement-dom-rx-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGEllipseElement-dom-ry-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGEllipseElement-svgdom-cx-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGEllipseElement-svgdom-cy-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGEllipseElement-svgdom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGEllipseElement-svgdom-rx-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGEllipseElement-svgdom-ry-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
1:45 PM Changeset in webkit [132131] by eae@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations update.

  • platform/chromium/TestExpectations:
1:30 PM Changeset in webkit [132130] by mkwst@chromium.org
  • 2 edits in trunk/Source/WebCore

'image/pjpeg' should be treated as an image by Web Inspector.
https://bugs.webkit.org/show_bug.cgi?id=100001

Reviewed by Pavel Feldman.

It's not exactly a "real" MIME type, but it's in use.

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkManager):

Adding 'image/pjpeg' as an image MIME type.

1:22 PM Changeset in webkit [132129] by commit-queue@webkit.org
  • 6 edits
    2 deletes in trunk

Unreviewed, rolling out r132119.
http://trac.webkit.org/changeset/132119
https://bugs.webkit.org/show_bug.cgi?id=100019

Fails its own test on Mac platforms. (Requested by leviw on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-22

Source/WebCore:

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::sendContextMenuEventForGesture):

  • page/EventHandler.h:

(EventHandler):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):

LayoutTests:

  • fast/events/touch/gesture/right-click-gestures-set-cursor-at-correct-position.html: Removed.
  • platform/chromium/fast/events/touch/gesture/right-click-gestures-set-cursor-at-correct-position-expected.txt: Removed.
1:20 PM Changeset in webkit [132128] by eae@chromium.org
  • 130 edits
    9 adds
    59 deletes in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium-mac-lion/editing/selection/3690703-2-expected.txt: Removed.
  • platform/chromium-mac-lion/editing/selection/3690703-expected.txt: Removed.
  • platform/chromium-mac-lion/editing/selection/3690719-expected.txt: Removed.
  • platform/chromium-mac-lion/editing/selection/4397952-expected.txt: Removed.
  • platform/chromium-mac-lion/editing/selection/5240265-expected.txt: Removed.
  • platform/chromium-mac-lion/editing/selection/selection-button-text-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/block/float/032-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/block/float/float-avoidance-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/css/continuationCrash-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/css/margin-top-bottom-dynamic-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/css/rtl-ordering-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/forms/001-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/forms/blankbuttons-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/forms/box-shadow-override-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/forms/button-sizes-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/forms/button-style-color-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/forms/button-text-transform-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/forms/control-restrict-line-height-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/forms/file/file-input-direction-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/forms/file/file-input-disabled-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/forms/file/input-file-re-render-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/forms/form-element-geometry-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/forms/formmove3-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/forms/input-appearance-height-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/input-button-sizes-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/forms/input-value-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/forms/menulist-clip-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/forms/targeted-frame-submission-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/forms/validation-message-appearance-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/overflow/scrollRevealButton-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/replaced/replaced-breaking-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/replaced/width100percent-button-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/text/textIteratorNilRenderer-expected.txt: Removed.
  • platform/chromium-mac-lion/http/tests/navigation/javascriptlink-frames-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug1188-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug1318-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug138725-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug18359-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug2479-2-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug2479-3-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug2479-4-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug26178-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug28928-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug33855-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug39209-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug4429-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug46368-1-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug46368-2-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug51037-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug51727-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug60749-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug7342-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/collapsing_borders/bug41262-4-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/dom/tableDom-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/other/move_row-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug1725-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/css/acid2-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/acid2-pixel-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/repaint-across-writing-mode-boundary-expected.png: Added.
  • platform/chromium-mac-snowleopard/http/tests/misc/acid2-expected.png: Added.
  • platform/chromium-mac-snowleopard/http/tests/misc/acid2-pixel-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/transforms/svg-css-transforms-clip-path-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/transforms/svg-css-transforms-expected.png: Added.
  • platform/chromium-mac-snowleopard/transforms/svg-vs-css-expected.png: Added.
  • platform/chromium-mac/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac/editing/selection/3690703-2-expected.txt:
  • platform/chromium-mac/editing/selection/3690703-expected.png:
  • platform/chromium-mac/editing/selection/3690703-expected.txt:
  • platform/chromium-mac/editing/selection/3690719-expected.png:
  • platform/chromium-mac/editing/selection/3690719-expected.txt:
  • platform/chromium-mac/editing/selection/4397952-expected.png:
  • platform/chromium-mac/editing/selection/4397952-expected.txt:
  • platform/chromium-mac/editing/selection/5240265-expected.png:
  • platform/chromium-mac/editing/selection/5240265-expected.txt:
  • platform/chromium-mac/editing/selection/selection-button-text-expected.png:
  • platform/chromium-mac/editing/selection/selection-button-text-expected.txt:
  • platform/chromium-mac/fast/block/float/032-expected.txt:
  • platform/chromium-mac/fast/block/float/float-avoidance-expected.png:
  • platform/chromium-mac/fast/block/float/float-avoidance-expected.txt:
  • platform/chromium-mac/fast/css/continuationCrash-expected.png:
  • platform/chromium-mac/fast/css/continuationCrash-expected.txt:
  • platform/chromium-mac/fast/css/margin-top-bottom-dynamic-expected.png:
  • platform/chromium-mac/fast/css/margin-top-bottom-dynamic-expected.txt:
  • platform/chromium-mac/fast/css/rtl-ordering-expected.png:
  • platform/chromium-mac/fast/css/rtl-ordering-expected.txt:
  • platform/chromium-mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
  • platform/chromium-mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
  • platform/chromium-mac/fast/forms/001-expected.png:
  • platform/chromium-mac/fast/forms/001-expected.txt:
  • platform/chromium-mac/fast/forms/blankbuttons-expected.png:
  • platform/chromium-mac/fast/forms/blankbuttons-expected.txt:
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-mac/fast/forms/button-sizes-expected.png:
  • platform/chromium-mac/fast/forms/button-sizes-expected.txt:
  • platform/chromium-mac/fast/forms/button-style-color-expected.png:
  • platform/chromium-mac/fast/forms/button-style-color-expected.txt:
  • platform/chromium-mac/fast/forms/button-table-styles-expected.png:
  • platform/chromium-mac/fast/forms/button-table-styles-expected.txt:
  • platform/chromium-mac/fast/forms/button-text-transform-expected.png:
  • platform/chromium-mac/fast/forms/button-text-transform-expected.txt:
  • platform/chromium-mac/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-mac/fast/forms/control-restrict-line-height-expected.txt:
  • platform/chromium-mac/fast/forms/file/file-input-direction-expected.png:
  • platform/chromium-mac/fast/forms/file/file-input-direction-expected.txt:
  • platform/chromium-mac/fast/forms/file/file-input-disabled-expected.png:
  • platform/chromium-mac/fast/forms/file/file-input-disabled-expected.txt:
  • platform/chromium-mac/fast/forms/file/file-input-pressed-state-expected.png:
  • platform/chromium-mac/fast/forms/file/input-file-re-render-expected.png:
  • platform/chromium-mac/fast/forms/file/input-file-re-render-expected.txt:
  • platform/chromium-mac/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-mac/fast/forms/form-element-geometry-expected.txt:
  • platform/chromium-mac/fast/forms/formmove3-expected.png:
  • platform/chromium-mac/fast/forms/formmove3-expected.txt:
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-mac/fast/forms/input-button-sizes-expected.png:
  • platform/chromium-mac/fast/forms/input-button-sizes-expected.txt:
  • platform/chromium-mac/fast/forms/input-value-expected.png:
  • platform/chromium-mac/fast/forms/input-value-expected.txt:
  • platform/chromium-mac/fast/forms/menulist-clip-expected.png:
  • platform/chromium-mac/fast/forms/menulist-clip-expected.txt:
  • platform/chromium-mac/fast/forms/targeted-frame-submission-expected.png:
  • platform/chromium-mac/fast/forms/targeted-frame-submission-expected.txt:
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
  • platform/chromium-mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
  • platform/chromium-mac/fast/overflow/scrollRevealButton-expected.png:
  • platform/chromium-mac/fast/overflow/scrollRevealButton-expected.txt:
  • platform/chromium-mac/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-mac/fast/replaced/replaced-breaking-expected.txt:
  • platform/chromium-mac/fast/replaced/width100percent-button-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-button-expected.txt:
  • platform/chromium-mac/fast/text/international/vertical-text-glyph-test-expected.png:
  • platform/chromium-mac/fast/text/international/vertical-text-glyph-test-expected.txt:
  • platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/chromium-mac/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-mac/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug138725-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug138725-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug26178-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug26178-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug33855-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug39209-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug39209-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug4429-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4429-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug51727-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug51727-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug60749-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug60749-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
  • platform/chromium-mac/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-mac/tables/mozilla/dom/tableDom-expected.txt:
  • platform/chromium-mac/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-mac/tables/mozilla/other/move_row-expected.txt:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
1:14 PM Changeset in webkit [132127] by commit-queue@webkit.org
  • 10 edits
    2 adds in trunk

[CSS Exclusions] Points on the bottom and right edges of an exclusion shape should be classified as "outside"
https://bugs.webkit.org/show_bug.cgi?id=98967

Patch by Hans Muller <hmuller@adobe.com> on 2012-10-22
Reviewed by Dirk Schulze.

Source/WebCore:

Changed the way lines are represented in the ExclusionShapeInsideInfo and ExclusionShape classes
so that they're consistent with the rendering code that depends on them. Lines are now defined
by logicalTop, logicalHeight, instead of logicalTop,logicalBottom. This a clean-up, not a change
in functionality. It's already covered by the existing fast/exclusions LayoutTests.

Test: fast/exclusions/shape-inside/shape-inside-bottom-edge.html

  • rendering/ExclusionPolygon.cpp:

(WebCore::ExclusionPolygon::getExcludedIntervals):
(WebCore::ExclusionPolygon::getIncludedIntervals):

  • rendering/ExclusionPolygon.h:
  • rendering/ExclusionRectangle.cpp:

(WebCore::ExclusionRectangle::getExcludedIntervals):
(WebCore::ExclusionRectangle::getIncludedIntervals):

  • rendering/ExclusionRectangle.h:
  • rendering/ExclusionShape.h:

(LineSegment): Moved the struct fields below the constructor per webkit style.
(ExclusionShape):
(WebCore::ExclusionShape::minYForLogicalLine):
(WebCore::ExclusionShape::maxYForLogicalLine):

  • rendering/ExclusionShapeInsideInfo.cpp:

(WebCore::ExclusionShapeInsideInfo::computeSegmentsForLine):

  • rendering/ExclusionShapeInsideInfo.h:

(ExclusionShapeInsideInfo):
(WebCore::ExclusionShapeInsideInfo::lineOverlapsShapeBounds): Changed the test to not include

lines whose logicalTop is equal to the shape's top+height.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutRunsAndFloatsInRange):

LayoutTests:

Verify that a exclusion shape-inside overlaps lines whose top is less than the
shape bounds' top+height but not equal to the shape bounds' top+height.

  • fast/exclusions/shape-inside/shape-inside-bottom-edge-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-bottom-edge.html: Added.
1:11 PM Changeset in webkit [132126] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] ewk_view_color_picker_color_set() is leaking
https://bugs.webkit.org/show_bug.cgi?id=100007

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-22
Reviewed by Kenneth Rohde Christiansen.

Fix a leak in ewk_view_color_picker_color_set() by adopting WKStringRef
returned by WKStringCreateWithUTF8CString().

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_color_picker_color_set):

1:11 PM Changeset in webkit [132125] by crogers@google.com
  • 12 edits in trunk

Update some AudioContext create() method names to latest Web Audio spec
https://bugs.webkit.org/show_bug.cgi?id=99888

Reviewed by Adam Barth.

Source/WebCore:

The following AudioContext method names are being changed, with legacy support for the old names:
createGainNode -> createGain
createDelayNode -> createDelay
createJavaScriptNode -> createScriptProcessor

For details:
https://www.w3.org/Bugs/Public/show_bug.cgi?id=18332

Tests changed: webaudio/delaynode.html, webaudio/gain.html, webaudio/javascriptaudionode.html
to test coverage of the new names.

  • Modules/webaudio/AudioBufferSourceNode.idl:
  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::createScriptProcessor):
(WebCore::AudioContext::createGain):
(WebCore::AudioContext::createDelay):

  • Modules/webaudio/AudioContext.h:

(AudioContext):

  • Modules/webaudio/AudioContext.idl:
  • page/FeatureObserver.h:

LayoutTests:

  • webaudio/delaynode-expected.txt:
  • webaudio/delaynode.html:
  • webaudio/gain.html:
  • webaudio/javascriptaudionode-expected.txt:
  • webaudio/javascriptaudionode.html:
1:01 PM Changeset in webkit [132124] by leviw@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed gardening. Baselines following r132112.

  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
12:56 PM Changeset in webkit [132123] by rakuco@webkit.org
  • 41 edits in trunk/LayoutTests

[EFL] Rebaseline pixel expectations after r131941 and r131991, part 4.

  • platform/efl/svg/as-background-image/svg-background-partial-redraw-expected.png:
  • platform/efl/svg/as-image/animated-svg-as-image-expected.png:
  • platform/efl/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png:
  • platform/efl/svg/as-image/animated-svg-as-image-same-image-expected.png:
  • platform/efl/svg/as-image/svg-image-change-content-size-expected.png:
  • platform/efl/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png:
  • platform/efl/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png:
  • platform/efl/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png:
  • platform/efl/svg/as-object/embedded-svg-size-changes-expected.png:
  • platform/efl/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.png:
  • platform/efl/svg/as-object/nested-embedded-svg-size-changes-expected.png:
  • platform/efl/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png:
  • platform/efl/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png:
  • platform/efl/svg/carto.net/tabgroup-expected.png:
  • platform/efl/svg/carto.net/window-expected.png:
  • platform/efl/svg/css/shadow-changes-expected.png:
  • platform/efl/svg/dom/SVGPathSegList-segment-modification-expected.png:
  • platform/efl/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png:
  • platform/efl/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png:
  • platform/efl/svg/dom/SVGRectElement/rect-modify-rx-expected.png:
  • platform/efl/svg/dynamic-updates/SVGCircleElement-dom-cx-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGCircleElement-dom-cy-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGCircleElement-dom-r-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGCircleElement-dom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGCircleElement-svgdom-cx-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGCircleElement-svgdom-cy-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGCircleElement-svgdom-r-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png:
  • platform/efl/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png:
  • platform/efl/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGClipPathElement-svgdom-clipPathUnits-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png:
  • platform/efl/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGEllipseElement-dom-cx-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGEllipseElement-dom-cy-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGEllipseElement-dom-requiredFeatures-expected.png:
12:53 PM Changeset in webkit [132122] by commit-queue@webkit.org
  • 4 edits
    2 adds
    2 deletes in trunk/Source/WebKit2

[EFL][WK2] Make the resource load client a C++ class
https://bugs.webkit.org/show_bug.cgi?id=99982

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-22
Reviewed by Kenneth Rohde Christiansen.

Create a C++ class for the resource load client and
move the id <-> resource mapping from the Ewk_View
to ResourceLoadClientEfl for better a cleaner
separation.

The resource load client code was also moved out of
UIProcess/API/efl to UIProcess/efl since this is not
part of the WK2 EFL API.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/ewk_view.cpp:

(Ewk_View_Private_Data):
(_ewk_view_initialize):
(ewk_view_wkpage_get):
(ewk_view_resource_load_initiated):
(ewk_view_resource_load_response):
(ewk_view_resource_load_failed):
(ewk_view_resource_load_finished):
(ewk_view_resource_request_sent):
(ewk_view_load_provisional_started):

  • UIProcess/API/efl/ewk_view_private.h:
  • UIProcess/API/efl/ewk_view_resource_load_client.cpp: Removed.
  • UIProcess/API/efl/ewk_view_resource_load_client_private.h: Removed.
  • UIProcess/efl/ResourceLoadClientEfl.cpp: Added.

(WebKit):
(WebKit::toResourceLoadClientEfl):
(WebKit::ResourceLoadClientEfl::didInitiateLoadForResource):
(WebKit::ResourceLoadClientEfl::didSendRequestForResource):
(WebKit::ResourceLoadClientEfl::didReceiveResponseForResource):
(WebKit::ResourceLoadClientEfl::didFinishLoadForResource):
(WebKit::ResourceLoadClientEfl::didFailLoadForResource):
(WebKit::ResourceLoadClientEfl::onViewProvisionalLoadStarted):
(WebKit::ResourceLoadClientEfl::ResourceLoadClientEfl):
(WebKit::ResourceLoadClientEfl::~ResourceLoadClientEfl):

  • UIProcess/efl/ResourceLoadClientEfl.h: Added.

(WebKit):
(ResourceLoadClientEfl):
(WebKit::ResourceLoadClientEfl::create):

12:46 PM Changeset in webkit [132121] by eae@chromium.org
  • 452 edits
    132 adds
    25 deletes in trunk/LayoutTests

Unreviewed gardening.

  • css1/text_properties/vertical_align-expected.txt: Added.
  • fast/multicol/table-vertical-align-expected.png: Added.
  • fast/multicol/table-vertical-align-expected.txt: Added.
  • fast/repaint/caret-outside-block-expected.png: Added.
  • http/tests/misc/acid2-expected.png: Added.
  • platform/chromium-linux-x86/fast/inline: Added.
  • platform/chromium-linux-x86/fast/inline-block/contenteditable-baseline-expected.txt:
  • platform/chromium-linux-x86/fast/inline/vertical-align-text-bottom-expected.txt: Added.
  • platform/chromium-linux-x86/fast/multicol/table-vertical-align-expected.txt: Removed.
  • platform/chromium-linux-x86/http/tests/misc/acid2-pixel-expected.txt: Added.
  • platform/chromium-linux-x86/svg/transforms: Removed.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug14323-expected.txt: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/bugs/bug1647-expected.txt: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/bugs/bug56024-expected.txt: Added.
  • platform/chromium-linux/compositing/shadows/shadow-drawing-expected.txt: Added.
  • platform/chromium-linux/css1/text_properties/vertical_align-expected.png:
  • platform/chromium-linux/css1/text_properties/vertical_align-expected.txt: Added.
  • platform/chromium-linux/css2.1/t0804-c5509-padn-l-03-f-g-expected.txt: Added.
  • platform/chromium-linux/css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • platform/chromium-linux/css3/flexbox/flexbox-baseline-expected.png:
  • platform/chromium-linux/css3/flexbox/flexbox-baseline-expected.txt: Added.
  • platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
  • platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Added.
  • platform/chromium-linux/fast/css/acid2-expected.txt: Added.
  • platform/chromium-linux/fast/css/acid2-pixel-expected.txt: Added.
  • platform/chromium-linux/fast/dom/HTMLProgressElement/progress-element-expected.png:
  • platform/chromium-linux/fast/forms/007-expected.png:
  • platform/chromium-linux/fast/forms/007-expected.txt: Added.
  • platform/chromium-linux/fast/forms/basic-buttons-expected.png:
  • platform/chromium-linux/fast/forms/basic-buttons-expected.txt:
  • platform/chromium-linux/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
  • platform/chromium-linux/fast/forms/input-baseline-expected.txt:
  • platform/chromium-linux/fast/forms/input-placeholder-paint-order-expected.png:
  • platform/chromium-linux/fast/forms/placeholder-position-expected.txt: Added.
  • platform/chromium-linux/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-linux/fast/forms/search-vertical-alignment-expected.txt: Added.
  • platform/chromium-linux/fast/forms/searchfield-heights-expected.png:
  • platform/chromium-linux/fast/forms/searchfield-heights-expected.txt:
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium-linux/fast/html/details-add-child-1-expected.png:
  • platform/chromium-linux/fast/html/details-add-child-1-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-child-2-expected.png:
  • platform/chromium-linux/fast/html/details-add-child-2-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-details-child-1-expected.png:
  • platform/chromium-linux/fast/html/details-add-details-child-1-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-details-child-2-expected.png:
  • platform/chromium-linux/fast/html/details-add-details-child-2-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-1-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-1-and-click-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-1-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-1-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-10-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-10-and-click-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-10-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-10-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-2-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-2-and-click-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-2-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-2-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-3-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-3-and-click-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-3-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-3-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-4-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-4-and-click-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-4-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-4-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-5-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-5-and-click-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-5-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-5-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-6-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-6-and-click-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-6-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-6-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-7-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-7-and-click-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-7-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-7-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-8-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-8-and-click-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-8-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-8-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-9-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-9-and-click-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-9-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-9-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-child-1-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-child-1-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-child-2-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-child-2-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-marker-style-expected.png:
  • platform/chromium-linux/fast/html/details-marker-style-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-nested-1-expected.png:
  • platform/chromium-linux/fast/html/details-nested-1-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-nested-2-expected.png:
  • platform/chromium-linux/fast/html/details-nested-2-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-no-summary1-expected.png:
  • platform/chromium-linux/fast/html/details-no-summary1-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-no-summary2-expected.png:
  • platform/chromium-linux/fast/html/details-no-summary2-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-no-summary3-expected.png:
  • platform/chromium-linux/fast/html/details-no-summary3-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-no-summary4-expected.png:
  • platform/chromium-linux/fast/html/details-no-summary4-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-open-javascript-expected.png:
  • platform/chromium-linux/fast/html/details-open-javascript-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-open1-expected.png:
  • platform/chromium-linux/fast/html/details-open1-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-open2-expected.png:
  • platform/chromium-linux/fast/html/details-open2-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-open3-expected.png:
  • platform/chromium-linux/fast/html/details-open3-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-open4-expected.png:
  • platform/chromium-linux/fast/html/details-open4-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-open5-expected.png:
  • platform/chromium-linux/fast/html/details-open5-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-open6-expected.png:
  • platform/chromium-linux/fast/html/details-open6-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-position-expected.png:
  • platform/chromium-linux/fast/html/details-position-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-remove-child-1-expected.png:
  • platform/chromium-linux/fast/html/details-remove-child-1-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-remove-child-2-expected.png:
  • platform/chromium-linux/fast/html/details-remove-child-2-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-1-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-1-and-click-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-1-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-1-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-2-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-2-and-click-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-2-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-2-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-3-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-3-and-click-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-3-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-3-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-4-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-4-and-click-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-4-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-4-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-5-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-5-and-click-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-5-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-5-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-6-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-6-and-click-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-6-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-6-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-child-1-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-child-1-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-child-2-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-child-2-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-replace-summary-child-expected.png:
  • platform/chromium-linux/fast/html/details-replace-summary-child-expected.txt:
  • platform/chromium-linux/fast/html/details-replace-text-expected.png:
  • platform/chromium-linux/fast/html/details-replace-text-expected.txt:
  • platform/chromium-linux/fast/html/details-writing-mode-expected.png:
  • platform/chromium-linux/fast/html/details-writing-mode-expected.txt: Added.
  • platform/chromium-linux/fast/images/imagemap-focus-ring-zoom-expected.png:
  • platform/chromium-linux/fast/images/imagemap-focus-ring-zoom-expected.txt: Added.
  • platform/chromium-linux/fast/inline-block/contenteditable-baseline-expected.txt:
  • platform/chromium-linux/fast/inline/002-expected.txt: Added.
  • platform/chromium-linux/fast/inline/vertical-align-text-bottom-expected.png:
  • platform/chromium-linux/fast/inline/vertical-align-text-bottom-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/table-vertical-align-expected.txt:
  • platform/chromium-linux/fast/repaint/4774354-expected.png:
  • platform/chromium-linux/fast/repaint/4776765-expected.png:
  • platform/chromium-linux/fast/repaint/caret-outside-block-expected.png:
  • platform/chromium-linux/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/chromium-linux/fast/repaint/selection-rl-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-linux/fast/writing-mode/fieldsets-expected.png:
  • platform/chromium-linux/fast/writing-mode/fieldsets-expected.txt: Added.
  • platform/chromium-linux/http/tests/misc/acid2-expected.txt: Added.
  • platform/chromium-linux/http/tests/misc/acid2-pixel-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zoom-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zoom-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/shadows: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.txt: Added.
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-2-expected.png:
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-2-expected.txt: Added.
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.txt: Added.
  • platform/chromium-linux/svg/transforms/svg-css-transforms-clip-path-expected.txt: Added.
  • platform/chromium-linux/svg/transforms/svg-css-transforms-expected.txt: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-hixie-mixed-009-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug14323-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug14323-expected.txt: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug30692-expected.txt: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug43854-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug43854-2-expected.txt: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4427-expected.txt: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug6404-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug6404-expected.txt: Added.
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt: Added.
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1647-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1647-expected.txt: Added.
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug56024-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug56024-expected.txt: Added.
  • platform/chromium-linux/transforms/svg-vs-css-expected.txt: Added.
  • platform/chromium-mac-lion/css3/flexbox/flexbox-baseline-expected.png:
  • platform/chromium-mac-lion/fast/forms/007-expected.png:
  • platform/chromium-mac-lion/fast/forms/basic-buttons-expected.png:
  • platform/chromium-mac-lion/fast/forms/datalist: Added.
  • platform/chromium-mac-lion/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-mac-lion/fast/forms/searchfield-heights-expected.png:
  • platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-child-1-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-child-2-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-details-child-1-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-details-child-2-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-1-and-click-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-1-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-10-and-click-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-10-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-2-and-click-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-2-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-3-and-click-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-3-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-4-and-click-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-4-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-5-and-click-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-5-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-6-and-click-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-6-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-7-and-click-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-7-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-8-and-click-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-8-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-9-and-click-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-9-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-child-1-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-child-2-expected.png:
  • platform/chromium-mac-lion/fast/html/details-marker-style-expected.png:
  • platform/chromium-mac-lion/fast/html/details-nested-1-expected.png:
  • platform/chromium-mac-lion/fast/html/details-nested-2-expected.png:
  • platform/chromium-mac-lion/fast/html/details-no-summary1-expected.png:
  • platform/chromium-mac-lion/fast/html/details-no-summary2-expected.png:
  • platform/chromium-mac-lion/fast/html/details-no-summary3-expected.png:
  • platform/chromium-mac-lion/fast/html/details-no-summary4-expected.png:
  • platform/chromium-mac-lion/fast/html/details-open-javascript-expected.png:
  • platform/chromium-mac-lion/fast/html/details-open1-expected.png:
  • platform/chromium-mac-lion/fast/html/details-open2-expected.png:
  • platform/chromium-mac-lion/fast/html/details-open3-expected.png:
  • platform/chromium-mac-lion/fast/html/details-open4-expected.png:
  • platform/chromium-mac-lion/fast/html/details-open5-expected.png:
  • platform/chromium-mac-lion/fast/html/details-open6-expected.png:
  • platform/chromium-mac-lion/fast/html/details-position-expected.png:
  • platform/chromium-mac-lion/fast/html/details-remove-child-1-expected.png:
  • platform/chromium-mac-lion/fast/html/details-remove-child-2-expected.png:
  • platform/chromium-mac-lion/fast/html/details-remove-summary-1-and-click-expected.png:
  • platform/chromium-mac-lion/fast/html/details-remove-summary-1-expected.png:
  • platform/chromium-mac-lion/fast/html/details-remove-summary-2-and-click-expected.png:
  • platform/chromium-mac-lion/fast/html/details-remove-summary-2-expected.png:
  • platform/chromium-mac-lion/fast/html/details-remove-summary-3-and-click-expected.png:
  • platform/chromium-mac-lion/fast/html/details-remove-summary-3-expected.png:
  • platform/chromium-mac-lion/fast/html/details-remove-summary-4-and-click-expected.png:
  • platform/chromium-mac-lion/fast/html/details-remove-summary-4-expected.png:
  • platform/chromium-mac-lion/fast/html/details-remove-summary-5-and-click-expected.png:
  • platform/chromium-mac-lion/fast/html/details-remove-summary-5-expected.png:
  • platform/chromium-mac-lion/fast/html/details-remove-summary-6-and-click-expected.png:
  • platform/chromium-mac-lion/fast/html/details-remove-summary-6-expected.png:
  • platform/chromium-mac-lion/fast/html/details-remove-summary-child-1-expected.png:
  • platform/chromium-mac-lion/fast/html/details-remove-summary-child-2-expected.png:
  • platform/chromium-mac-lion/fast/html/details-replace-summary-child-expected.png:
  • platform/chromium-mac-lion/fast/html/details-replace-text-expected.png:
  • platform/chromium-mac-lion/fast/html/details-writing-mode-expected.png:
  • platform/chromium-mac-lion/fast/images/imagemap-focus-ring-zoom-expected.png:
  • platform/chromium-mac-lion/fast/inline: Added.
  • platform/chromium-mac-lion/fast/inline/vertical-align-text-bottom-expected.png: Added.
  • platform/chromium-mac-lion/fast/inline/vertical-align-text-bottom-expected.txt: Added.
  • platform/chromium-mac-lion/fast/repaint: Added.
  • platform/chromium-mac-lion/fast/repaint/4774354-expected.png: Added.
  • platform/chromium-mac-lion/fast/repaint/4776765-expected.png: Added.
  • platform/chromium-mac-lion/fast/repaint/caret-outside-block-expected.png: Added.
  • platform/chromium-mac-lion/fast/repaint/selection-rl-expected.png: Added.
  • platform/chromium-mac-lion/fast/speech/input-appearance-searchandspeech-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/writing-mode/fieldsets-expected.png:
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zoom-expected.png: Added.
  • platform/chromium-mac-lion/svg/as-border-image/svg-as-border-image-2-expected.png:
  • platform/chromium-mac-lion/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-mac-lion/svg/zoom/page/zoom-hixie-mixed-009-expected.png:
  • platform/chromium-mac-lion/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
  • platform/chromium-mac-lion/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac-lion/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-mac-lion/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-mac-lion/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png:
  • platform/chromium-mac-lion/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium-mac-lion/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac-snowleopard/css3/flexbox/flexbox-baseline-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/007-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/basic-buttons-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-child-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-child-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-details-child-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-details-child-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-1-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-10-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-10-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-2-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-3-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-3-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-4-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-4-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-5-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-5-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-6-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-6-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-7-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-7-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-8-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-8-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-9-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-9-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-child-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-child-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-nested-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-nested-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-no-summary1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-no-summary2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-no-summary3-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-no-summary4-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open-javascript-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open3-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open4-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open5-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open6-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-position-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-child-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-child-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-1-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-2-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-3-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-3-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-4-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-4-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-5-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-5-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-6-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-6-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-child-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-child-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-replace-summary-child-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-replace-text-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-writing-mode-expected.png:
  • platform/chromium-mac-snowleopard/fast/inline/vertical-align-text-bottom-expected.png:
  • platform/chromium-mac-snowleopard/fast/inline/vertical-align-text-bottom-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/table-vertical-align-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/4774354-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/4776765-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/caret-outside-block-expected.png:
  • platform/chromium-mac-snowleopard/fast/writing-mode/fieldsets-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac/compositing/shadows/shadow-drawing-expected.txt:
  • platform/chromium-mac/css2.1/t0804-c5509-padn-l-03-f-g-expected.txt:
  • platform/chromium-mac/css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • platform/chromium-mac/css3/flexbox/flexbox-baseline-expected.png:
  • platform/chromium-mac/css3/flexbox/flexbox-baseline-expected.txt:
  • platform/chromium-mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/chromium-mac/fast/css/acid2-expected.png: Added.
  • platform/chromium-mac/fast/css/acid2-pixel-expected.png:
  • platform/chromium-mac/fast/dom/HTMLProgressElement/progress-element-expected.png: Added.
  • platform/chromium-mac/fast/dom/HTMLProgressElement/progress-element-expected.txt: Added.
  • platform/chromium-mac/fast/forms/007-expected.png:
  • platform/chromium-mac/fast/forms/007-expected.txt:
  • platform/chromium-mac/fast/forms/basic-buttons-expected.png:
  • platform/chromium-mac/fast/forms/basic-buttons-expected.txt:
  • platform/chromium-mac/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
  • platform/chromium-mac/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-mac/fast/forms/search-vertical-alignment-expected.txt:
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac/fast/html/details-add-child-1-expected.png:
  • platform/chromium-mac/fast/html/details-add-child-1-expected.txt:
  • platform/chromium-mac/fast/html/details-add-child-2-expected.png:
  • platform/chromium-mac/fast/html/details-add-child-2-expected.txt:
  • platform/chromium-mac/fast/html/details-add-details-child-1-expected.png:
  • platform/chromium-mac/fast/html/details-add-details-child-1-expected.txt:
  • platform/chromium-mac/fast/html/details-add-details-child-2-expected.png:
  • platform/chromium-mac/fast/html/details-add-details-child-2-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-1-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-1-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-10-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-10-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-2-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-2-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-3-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-3-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-4-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-4-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-5-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-5-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-6-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-6-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-7-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-7-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-8-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-8-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-9-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-9-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-child-1-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-child-1-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-child-2-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-child-2-expected.txt:
  • platform/chromium-mac/fast/html/details-marker-style-expected.png:
  • platform/chromium-mac/fast/html/details-marker-style-expected.txt:
  • platform/chromium-mac/fast/html/details-nested-1-expected.png:
  • platform/chromium-mac/fast/html/details-nested-1-expected.txt:
  • platform/chromium-mac/fast/html/details-nested-2-expected.png:
  • platform/chromium-mac/fast/html/details-nested-2-expected.txt:
  • platform/chromium-mac/fast/html/details-no-summary1-expected.png:
  • platform/chromium-mac/fast/html/details-no-summary1-expected.txt:
  • platform/chromium-mac/fast/html/details-no-summary2-expected.png:
  • platform/chromium-mac/fast/html/details-no-summary2-expected.txt:
  • platform/chromium-mac/fast/html/details-no-summary3-expected.png:
  • platform/chromium-mac/fast/html/details-no-summary3-expected.txt:
  • platform/chromium-mac/fast/html/details-no-summary4-expected.png:
  • platform/chromium-mac/fast/html/details-no-summary4-expected.txt:
  • platform/chromium-mac/fast/html/details-open-javascript-expected.png:
  • platform/chromium-mac/fast/html/details-open-javascript-expected.txt:
  • platform/chromium-mac/fast/html/details-open1-expected.png:
  • platform/chromium-mac/fast/html/details-open1-expected.txt:
  • platform/chromium-mac/fast/html/details-open2-expected.png:
  • platform/chromium-mac/fast/html/details-open2-expected.txt:
  • platform/chromium-mac/fast/html/details-open3-expected.png:
  • platform/chromium-mac/fast/html/details-open3-expected.txt:
  • platform/chromium-mac/fast/html/details-open4-expected.png:
  • platform/chromium-mac/fast/html/details-open4-expected.txt:
  • platform/chromium-mac/fast/html/details-open5-expected.png:
  • platform/chromium-mac/fast/html/details-open5-expected.txt:
  • platform/chromium-mac/fast/html/details-open6-expected.png:
  • platform/chromium-mac/fast/html/details-open6-expected.txt:
  • platform/chromium-mac/fast/html/details-position-expected.png:
  • platform/chromium-mac/fast/html/details-position-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-child-1-expected.png:
  • platform/chromium-mac/fast/html/details-remove-child-1-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-child-2-expected.png:
  • platform/chromium-mac/fast/html/details-remove-child-2-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-1-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-1-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-2-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-2-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-3-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-3-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-4-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-4-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-5-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-5-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-6-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-6-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-child-1-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-child-1-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-child-2-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-child-2-expected.txt:
  • platform/chromium-mac/fast/html/details-replace-summary-child-expected.png:
  • platform/chromium-mac/fast/html/details-replace-summary-child-expected.txt:
  • platform/chromium-mac/fast/html/details-replace-text-expected.png:
  • platform/chromium-mac/fast/html/details-replace-text-expected.txt:
  • platform/chromium-mac/fast/html/details-writing-mode-expected.png:
  • platform/chromium-mac/fast/html/details-writing-mode-expected.txt:
  • platform/chromium-mac/fast/images/imagemap-focus-ring-zoom-expected.png:
  • platform/chromium-mac/fast/images/imagemap-focus-ring-zoom-expected.txt:
  • platform/chromium-mac/fast/inline/002-expected.png:
  • platform/chromium-mac/fast/inline/vertical-align-text-bottom-expected.png:
  • platform/chromium-mac/fast/inline/vertical-align-text-bottom-expected.txt:
  • platform/chromium-mac/fast/multicol/table-vertical-align-expected.png:
  • platform/chromium-mac/fast/multicol/table-vertical-align-expected.txt:
  • platform/chromium-mac/fast/repaint/4774354-expected.png:
  • platform/chromium-mac/fast/repaint/4776765-expected.png:
  • platform/chromium-mac/fast/repaint/caret-outside-block-expected.png:
  • platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
  • platform/chromium-mac/fast/repaint/selection-rl-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-mac/fast/writing-mode/fieldsets-expected.png:
  • platform/chromium-mac/fast/writing-mode/fieldsets-expected.txt:
  • platform/chromium-mac/http/tests/misc/acid2-expected.png: Added.
  • platform/chromium-mac/http/tests/misc/acid2-pixel-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zoom-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zoom-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.txt:
  • platform/chromium-mac/svg/as-border-image/svg-as-border-image-2-expected.png:
  • platform/chromium-mac/svg/as-border-image/svg-as-border-image-2-expected.txt:
  • platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.txt:
  • platform/chromium-mac/svg/transforms/svg-css-transforms-clip-path-expected.png:
  • platform/chromium-mac/svg/transforms/svg-css-transforms-clip-path-expected.txt:
  • platform/chromium-mac/svg/transforms/svg-css-transforms-expected.png:
  • platform/chromium-mac/svg/transforms/svg-css-transforms-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-hixie-mixed-009-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug14323-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug30692-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug43854-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug6404-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug1647-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug56024-expected.png:
  • platform/chromium-mac/transforms/svg-vs-css-expected.png:
  • platform/chromium-mac/transforms/svg-vs-css-expected.txt:
  • platform/chromium-win-xp/fast/multicol/table-vertical-align-expected.txt: Removed.
  • platform/chromium-win-xp/svg/zoom/page/zoom-hixie-mixed-009-expected.png: Added.
  • platform/chromium-win-xp/tables/mozilla/bugs/bug43854-2-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Added.
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Replaced.
  • platform/chromium/fast/css/acid2-expected.png: Removed.
  • platform/chromium/http/tests/misc/acid2-expected.png: Removed.
  • platform/efl/css1/text_properties/vertical_align-expected.txt: Removed.
  • platform/efl/fast/multicol/table-vertical-align-expected.png: Removed.
  • platform/efl/fast/multicol/table-vertical-align-expected.txt: Removed.
  • platform/efl/fast/repaint/caret-outside-block-expected.png: Removed.
  • platform/efl/http/tests/misc/acid2-expected.png: Removed.
  • platform/efl/svg/transforms/svg-css-transforms-clip-path-expected.txt: Removed.
  • platform/efl/svg/transforms/svg-css-transforms-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug43854-2-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug4427-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug6404-expected.txt: Removed.
  • platform/gtk/css1/text_properties/vertical_align-expected.txt: Removed.
  • platform/gtk/fast/multicol/table-vertical-align-expected.png: Removed.
  • platform/gtk/fast/multicol/table-vertical-align-expected.txt: Removed.
  • platform/gtk/fast/repaint/caret-outside-block-expected.png: Removed.
  • platform/gtk/http/tests/misc/acid2-expected.png: Removed.
  • platform/gtk/svg/transforms/svg-css-transforms-clip-path-expected.txt: Removed.
  • platform/gtk/svg/transforms/svg-css-transforms-expected.txt: Removed.
12:23 PM Changeset in webkit [132120] by andersca@apple.com
  • 4 edits in trunk

[WK2] Regression(r131990): plugins/npruntime/remove-property.html started failing
https://bugs.webkit.org/show_bug.cgi?id=99977

Reviewed by Alexey Proskuryakov.

Source/WebKit2:

Remove int32_t casts - the ArgumentDecoder::decode overload that takes a const int would cause
a temporary to be created which the number was then decoded into.

  • Shared/Plugins/NPIdentifierData.cpp:

(WebKit::NPIdentifierData::encode):
(WebKit::NPIdentifierData::decode):

LayoutTests:

Remove now passing test.

  • platform/efl-wk2/TestExpectations:
12:21 PM Changeset in webkit [132119] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Context menu generated from touch gestures on textareas has
context of the cursor position instead of the position where the event occurs.
https://bugs.webkit.org/show_bug.cgi?id=99520

Patch by Varun Jain <varunjain@chromium.org> on 2012-10-22
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Send a synthetic mouse down event for context menu-summoning-gesture events so
that textareas can correctly set cursors before receiving the context menu event.

Test: fast/events/touch/gesture/right-click-gestures-set-cursor-at-correct-position.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleGestureTwoFingerTap):
(WebCore):
(WebCore::EventHandler::sendContextMenuEventForGesture):

  • page/EventHandler.h:

(EventHandler):

Source/WebKit/chromium:

Send a synthetic mouse down event for context menu-summoning-gesture events so
that textareas can correctly set cursors before receiving the context menu event.
Also in this change, WebInputEvent::GestureTwoFingerTap now follows the same
code path as WebInputEvent::GestureLongPress, hence fixing this bug for both gestures.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):

LayoutTests:

Send a synthetic mouse down event for context menu-summoning-gesture events so that
textareas can correctly set cursors before receiving the context menu event.

  • fast/events/touch/gesture/right-click-gestures-set-cursor-at-correct-position.html: Added.
  • platform/chromium/fast/events/touch/gesture/right-click-gestures-set-cursor-at-correct-position-expected.txt: Added.
12:17 PM Changeset in webkit [132118] by zeno.albisser@digia.com
  • 2 edits in trunk/Source/WebCore

TextureMapperSurfaceBackingStore should check if GraphicsSurface is valid.
https://bugs.webkit.org/show_bug.cgi?id=100002

Reviewed by Kenneth Rohde Christiansen.

  • platform/graphics/texmap/TextureMapperBackingStore.cpp:

(WebCore::TextureMapperSurfaceBackingStore::setGraphicsSurface):

Check if a surface has been created before accessing the pointer.

(WebCore::TextureMapperSurfaceBackingStore::paintToTextureMapper):

Check if m_graphicsSurface is a valid pointer before dereferencing it.

12:11 PM Changeset in webkit [132117] by eae@chromium.org
  • 133 edits
    80 adds
    1 delete in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium-mac-lion/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/3690703-2-expected.txt: Added.
  • platform/chromium-mac-lion/editing/selection/3690703-expected.png:
  • platform/chromium-mac-lion/editing/selection/3690703-expected.txt: Added.
  • platform/chromium-mac-lion/editing/selection/3690719-expected.png:
  • platform/chromium-mac-lion/editing/selection/3690719-expected.txt: Added.
  • platform/chromium-mac-lion/editing/selection/4397952-expected.png:
  • platform/chromium-mac-lion/editing/selection/4397952-expected.txt: Added.
  • platform/chromium-mac-lion/editing/selection/5240265-expected.png:
  • platform/chromium-mac-lion/editing/selection/5240265-expected.txt: Added.
  • platform/chromium-mac-lion/editing/selection/selection-button-text-expected.png:
  • platform/chromium-mac-lion/editing/selection/selection-button-text-expected.txt: Added.
  • platform/chromium-mac-lion/fast/block/float/032-expected.txt: Added.
  • platform/chromium-mac-lion/fast/block/float/float-avoidance-expected.png:
  • platform/chromium-mac-lion/fast/block/float/float-avoidance-expected.txt: Added.
  • platform/chromium-mac-lion/fast/css/continuationCrash-expected.png:
  • platform/chromium-mac-lion/fast/css/continuationCrash-expected.txt: Added.
  • platform/chromium-mac-lion/fast/css/margin-top-bottom-dynamic-expected.png:
  • platform/chromium-mac-lion/fast/css/margin-top-bottom-dynamic-expected.txt: Added.
  • platform/chromium-mac-lion/fast/css/rtl-ordering-expected.png:
  • platform/chromium-mac-lion/fast/css/rtl-ordering-expected.txt: Added.
  • platform/chromium-mac-lion/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
  • platform/chromium-mac-lion/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/001-expected.png:
  • platform/chromium-mac-lion/fast/forms/001-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/blankbuttons-expected.png:
  • platform/chromium-mac-lion/fast/forms/blankbuttons-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/box-shadow-override-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/box-shadow-override-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/button-sizes-expected.png:
  • platform/chromium-mac-lion/fast/forms/button-sizes-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/button-style-color-expected.png:
  • platform/chromium-mac-lion/fast/forms/button-style-color-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/button-table-styles-expected.png:
  • platform/chromium-mac-lion/fast/forms/button-text-transform-expected.png:
  • platform/chromium-mac-lion/fast/forms/button-text-transform-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-mac-lion/fast/forms/control-restrict-line-height-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/date-multiple-fields: Added.
  • platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/file/file-input-direction-expected.png:
  • platform/chromium-mac-lion/fast/forms/file/file-input-direction-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/file/file-input-disabled-expected.png:
  • platform/chromium-mac-lion/fast/forms/file/file-input-disabled-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/file/file-input-pressed-state-expected.png:
  • platform/chromium-mac-lion/fast/forms/file/input-file-re-render-expected.png:
  • platform/chromium-mac-lion/fast/forms/file/input-file-re-render-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-mac-lion/fast/forms/form-element-geometry-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/formmove3-expected.png:
  • platform/chromium-mac-lion/fast/forms/formmove3-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/input-button-sizes-expected.png:
  • platform/chromium-mac-lion/fast/forms/input-button-sizes-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/input-value-expected.png:
  • platform/chromium-mac-lion/fast/forms/input-value-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/menulist-clip-expected.png:
  • platform/chromium-mac-lion/fast/forms/menulist-clip-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/targeted-frame-submission-expected.png:
  • platform/chromium-mac-lion/fast/forms/targeted-frame-submission-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/time-multiple-fields: Added.
  • platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-lion/fast/forms/validation-message-appearance-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/week-multiple-fields: Added.
  • platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png: Added.
  • platform/chromium-mac-lion/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
  • platform/chromium-mac-lion/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt: Added.
  • platform/chromium-mac-lion/fast/overflow/scrollRevealButton-expected.png:
  • platform/chromium-mac-lion/fast/overflow/scrollRevealButton-expected.txt: Added.
  • platform/chromium-mac-lion/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-mac-lion/fast/replaced/replaced-breaking-expected.txt: Added.
  • platform/chromium-mac-lion/fast/replaced/width100percent-button-expected.png:
  • platform/chromium-mac-lion/fast/replaced/width100percent-button-expected.txt: Added.
  • platform/chromium-mac-lion/fast/speech/input-appearance-searchandspeech-expected.png: Added.
  • platform/chromium-mac-lion/fast/speech/input-appearance-searchandspeech-expected.txt: Added.
  • platform/chromium-mac-lion/fast/text/international/text-spliced-font-expected.png: Added.
  • platform/chromium-mac-lion/fast/text/international/text-spliced-font-expected.txt: Added.
  • platform/chromium-mac-lion/fast/text/international/vertical-text-glyph-test-expected.png:
  • platform/chromium-mac-lion/fast/text/international/vertical-text-glyph-test-expected.txt:
  • platform/chromium-mac-lion/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-mac-lion/fast/text/textIteratorNilRenderer-expected.txt: Added.
  • platform/chromium-mac-lion/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-mac-lion/http/tests/navigation/javascriptlink-frames-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug1188-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug1318-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug138725-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug138725-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug18359-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug2479-2-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug2479-3-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug2479-4-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug26178-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug26178-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug28928-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug33855-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug33855-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug39209-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug39209-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug4429-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug4429-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug46368-1-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug46368-2-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug51037-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug51727-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug51727-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug60749-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug60749-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug7342-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/collapsing_borders/bug41262-4-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/dom/tableDom-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/other/move_row-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug1725-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt: Added.
  • platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4397952-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5240265-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/selection-button-text-expected.png:
  • platform/chromium-mac-snowleopard/fast/block/float/float-avoidance-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/continuationCrash-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/margin-top-bottom-dynamic-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/rtl-ordering-expected.png:
  • platform/chromium-mac-snowleopard/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/001-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/blankbuttons-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-sizes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-style-color-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-table-styles-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-text-transform-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/file/file-input-direction-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/file/file-input-disabled-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/file/file-input-pressed-state-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/file/input-file-re-render-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/formmove3-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-button-sizes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-value-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/menulist-clip-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/targeted-frame-submission-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
  • platform/chromium-mac-snowleopard/fast/overflow/scrollRevealButton-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-button-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/text-spliced-font-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/text-spliced-font-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/vertical-text-glyph-test-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/vertical-text-glyph-test-expected.txt:
  • platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-mac-snowleopard/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug138725-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug26178-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug33855-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug39209-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4429-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51727-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug60749-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
  • platform/chromium-win-xp/fast/text/international/text-spliced-font-expected.png: Removed.
11:58 AM Changeset in webkit [132116] by msaboff@apple.com
  • 2 edits in trunk/Source/WebCore

r131955 is has improper function call in LinkHashChromium.cpp
https://bugs.webkit.org/show_bug.cgi?id=100008

Reviewed by Alexey Proskuryakov.

Followup fix to r131955 for chromium platform. Added call to
(const UChar*, unsigned) version of visitedLinkHash from String& version.

  • platform/chromium/LinkHashChromium.cpp:

(WebCore::visitedLinkHash):

11:52 AM Changeset in webkit [132115] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

webkitsourceopen event doesn't always fire
https://bugs.webkit.org/show_bug.cgi?id=99868

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-10-22
Reviewed by Adam Barth.

Source/WebCore:

Changed MediaSource to derive from ActiveDOMObject so that event listeners
will still fire even if all references to the object go out of scope.

Test: http/tests/media/media-source/video-media-source-garbage-collection-before-sourceopen.html

  • Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::create):
(WebCore::MediaSource::MediaSource):
(WebCore::MediaSource::scriptExecutionContext):
(WebCore):
(WebCore::MediaSource::hasPendingActivity):
(WebCore::MediaSource::stop): Clears m_player & m_asyncEventQueue so they don't indicate pending activity anymore.

  • Modules/mediasource/MediaSource.h:

(MediaSource):

  • Modules/mediasource/MediaSource.idl:
  • Modules/mediasource/MediaSourceRegistry.cpp:

(WebCore::MediaSourceRegistry::registerMediaSourceURL): Added setPendingActivity() call so the MediaSource object stays active while in the registry.
(WebCore::MediaSourceRegistry::unregisterMediaSourceURL): Added unsetPendingActivity() call so the MediaSource object can become inactive after being removed from the registry.

LayoutTests:

Added a test that verifies the webkitsourceopen event still fires
even if the MediaSource variable goes out of scope and garbage
collection occurs.

  • http/tests/media/media-source/video-media-source-garbage-collection-before-sourceopen-expected.txt: Added.
  • http/tests/media/media-source/video-media-source-garbage-collection-before-sourceopen.html: Added.
11:50 AM Changeset in webkit [132114] by abarth@webkit.org
  • 3 edits
    3 adds in trunk

[V8] Vastly simplify V8GCController's NodeVisitor
https://bugs.webkit.org/show_bug.cgi?id=99884

Reviewed by Kentaro Hara.

PerformanceTests:

Adds some performance tests for the garbage collector.

  • Bindings/gc-forest.html: Added.
  • Bindings/gc-mini-tree.html: Added.
  • Bindings/gc-tree.html: Added.

Source/WebCore:

NodeVisitor was vastly more complicated than necessary.

This patch improve performance on these new gc benchmarks:

gc-forest: 1.14% better
gc-mini-tree: 5.09% better
gc-tree: 4.60% better

  • bindings/v8/V8GCController.cpp:

(WebCore::ObjectVisitor::visitDOMWrapper):
(WebCore::addImplicitReferencesForNodeWithEventListeners):
(WebCore::rootForGC):
(WebCore::NodeVisitor::visitDOMWrapper):
(WebCore::NodeVisitor::applyGrouping):
(NodeVisitor):

11:40 AM Changeset in webkit [132113] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Roll Chromium DEPS to get new version of V8
https://bugs.webkit.org/show_bug.cgi?id=100015

Unreviewed.

  • DEPS:
    • Bigger is better.
11:38 AM Changeset in webkit [132112] by eae@chromium.org
  • 51 edits
    2 adds in trunk

Source/WebCore: Change baselinePosition and maxAscent/maxDescent to int
https://bugs.webkit.org/show_bug.cgi?id=99767

Reviewed by Levi Weintraub.

Currently baselinePostion, maxAscent and maxDescent are
LayoutUnits while ascent, descent and m_lineHeight are ints.
This can lead to subtle alignment and rounding problems.

Change baselinePosition and maxAscent/maxDescent to int to avoid
these issues.

Test: fast/sub-pixel/replaced-element-baseline.html

  • editing/FrameSelection.cpp:

(WebCore::repaintRectForCaret):
Inflate Y dimension just like we do for X to ensure that the
repaint rect fully contains the caret.

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::baselinePosition):

  • rendering/InlineBox.h:

(InlineBox):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::adjustMaxAscentAndDescent):
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
Change maxAscent/maxDescent to int to match ascent/descent.

  • rendering/InlineFlowBox.h:

(InlineFlowBox):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::baselinePosition):

  • rendering/InlineTextBox.h:

(InlineTextBox):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::baselinePosition):
(WebCore::RenderBlock::firstLineBoxBaseline):
(WebCore::RenderBlock::lastLineBoxBaseline):

  • rendering/RenderBlock.h:

(RenderBlock):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::baselinePosition):

  • rendering/RenderBox.h:

(WebCore::RenderBox::firstLineBoxBaseline):
(WebCore::RenderBox::lastLineBoxBaseline):
(RenderBox):

  • rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::baselinePosition):
(WebCore::RenderFlexibleBox::firstLineBoxBaseline):

  • rendering/RenderFlexibleBox.h:
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::baselinePosition):

  • rendering/RenderInline.h:

(RenderInline):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::baselinePosition):

  • rendering/RenderListBox.h:

(RenderListBox):

  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::baselinePosition):

  • rendering/RenderListMarker.h:

(RenderListMarker):

  • rendering/RenderSlider.cpp:

(WebCore::RenderSlider::baselinePosition):

  • rendering/RenderSlider.h:

(RenderSlider):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::baselinePosition):
(WebCore::RenderTable::lastLineBoxBaseline):
(WebCore::RenderTable::firstLineBoxBaseline):

  • rendering/RenderTable.h:

(RenderTable):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::firstLineBoxBaseline):

  • rendering/RenderTableSection.h:

(RenderTableSection):

  • rendering/RenderTextControlMultiLine.cpp:

(WebCore::RenderTextControlMultiLine::baselinePosition):

  • rendering/RenderTextControlMultiLine.h:

(RenderTextControlMultiLine):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::baselinePosition):

  • rendering/RenderTheme.h:

(RenderTheme):

  • rendering/RenderThemeSafari.cpp:

(WebCore::RenderThemeSafari::baselinePosition):

  • rendering/RenderThemeSafari.h:

(RenderThemeSafari):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::baselinePosition):
(WebCore::RootInlineBox::alignBoxesInBlockDirection):

  • rendering/RootInlineBox.h:

(RootInlineBox):

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::baselinePosition):
(WebCore::RenderMathMLTable::firstLineBoxBaseline):

  • rendering/mathml/RenderMathMLBlock.h:

(RenderMathMLBlock):
(RenderMathMLTable):

  • rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::firstLineBoxBaseline):

  • rendering/mathml/RenderMathMLFraction.h:

(RenderMathMLFraction):

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::firstLineBoxBaseline):

  • rendering/mathml/RenderMathMLOperator.h:
  • rendering/mathml/RenderMathMLUnderOver.cpp:

(WebCore::RenderMathMLUnderOver::firstLineBoxBaseline):

  • rendering/mathml/RenderMathMLUnderOver.h:

(RenderMathMLUnderOver):

LayoutTests: Unreviewed, further Apple Mac baselines for shadow DOM changes to RenderSlider.

Patch by Jer Noble <jer.noble@apple.com> on 2012-10-22

  • platform/mac/fast/forms/input-appearance-height-expected.txt:
  • platform/mac/media/controls-without-preload-expected.txt:
11:16 AM Changeset in webkit [132111] by jer.noble@apple.com
  • 3 edits in trunk/LayoutTests

Unreviewed, further Apple Mac baselines for shadow DOM changes to RenderSlider.

  • platform/mac/fast/forms/input-appearance-height-expected.txt:
  • platform/mac/media/controls-without-preload-expected.txt:
11:09 AM Changeset in webkit [132110] by inferno@chromium.org
  • 5 edits
    5 copies in branches/chromium/1271

Merge 130777 - Prevent animation when CSS attributeType is invalid.
BUG=143648

11:07 AM Changeset in webkit [132109] by inferno@chromium.org
  • 6 edits in branches/chromium/1271/Source/WebCore/svg

Merge 129670 - Refactor SMILTimeContainer to maintain animation information instead of recalculating it every frame
BUG=143648
Review URL: https://codereview.chromium.org/11229037

11:06 AM Changeset in webkit [132108] by ojan@chromium.org
  • 3 edits in trunk/Tools

Update flakiness dashboard to match the state of the builders.

  • TestResultServer/static-dashboards/builders.js:

(isChromiumDepsGTestRunner):
Broaden the filter since Chromium naming scheme is not consistent.
(loadBuildersList):
The main Chromium master now only runs builders, no tests.

  • TestResultServer/static-dashboards/dashboard_base.js:

Remove test suites that no longer run on any of these masters.

11:03 AM Changeset in webkit [132107] by Martin Robinson
  • 1 copy in releases/WebKitGTK/webkit-1.10.1

Tag the WebKitGTK+ 1.10.1 release

10:48 AM Changeset in webkit [132106] by eae@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, marking fast/sub-pixel/file-upload-control-at-fractional-offset.html as failing on LION for now.

  • platform/chromium/TestExpectations:
10:46 AM Changeset in webkit [132105] by eae@chromium.org
  • 6 edits in trunk/Source/WebCore

Modify LayoutState ASSERTS to support SATURATED_LAYOUT_ARITHMETIC
https://bugs.webkit.org/show_bug.cgi?id=98692

Reviewed by Dan Bernstein.

We currently overflow/wrap when computing the delta in
RenderBlock::setLogicalTopForChild in cases where we have an
element with a width or height exceeding maxLayoutUnit. When
the delta is later added back in RenderBlock::layoutBlockChild
the number wraps again getting us back to the correct value.

With SATURATED_LAYOUT_ARITHMETIC enabled the values no longer
wraps, which seems like the correct thing to do however this
causes the compare to fail for obvious reasons. By accounting
for this we can keep the asserts (which have proven very
helpful) even when SATURATED_LAYOUT_ARITHMETIC is turned on.

No new tests, covered by existing tests.

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):

  • rendering/LayoutState.h:

(WebCore::LayoutState::LayoutState):
(LayoutState):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlockChild):

  • rendering/RenderView.cpp:

(WebCore::RenderView::layout):

  • rendering/RenderView.h:

(WebCore::RenderView::addLayoutDelta):
(RenderView):
(WebCore::RenderView::layoutDeltaMatches):

10:45 AM Changeset in webkit [132104] by tony@chromium.org
  • 16 edits
    3 adds in trunk

Fix some baseline flexbox alignment
https://bugs.webkit.org/show_bug.cgi?id=99879

Reviewed by Ojan Vafai.

Source/WebCore:

Fix a bug where we weren't handling margin properly on inline-flexbox.
Fix a bug where we weren't getting the edge of the content box properly when synthesizing
a baseline.

Test: css3/flexbox/flexbox-baseline-margins.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::baselinePosition):
(WebCore::RenderBlock::inlineBlockBaseline): Add a new method that is used when calculating an inline-block's
baseline. Previously we would use lastLineBoxBaseline.
(WebCore::RenderBlock::lastLineBoxBaseline): Pass in direction and when searching children, use inlineBlockBaseline.

  • rendering/RenderBlock.h:

(RenderBlock): Make lastLineBoxBaseline non-virtual.

  • rendering/RenderBox.h:

(WebCore::RenderBox::inlineBlockBaseline): Replace lastLineBoxBaseline with inlineBlockBaseline.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::synthesizedBaselineFromContentBox): Helper method for getting the baseline from the content box.
(WebCore::RenderFlexibleBox::baselinePosition): Always include the margin. This fixes the inline-flexbox case.
(WebCore::RenderFlexibleBox::firstLineBoxBaseline): Fix a case where we didn't synthesize a baseline. Returning -1 means there is no baseline, but we can
synthesize a baseline if we have a flexitem without text.
(WebCore::RenderFlexibleBox::inlineBlockBaseline):

  • rendering/RenderFlexibleBox.h:
  • rendering/RenderTable.cpp: Replace lastLineBoxBaseline with inlineBlockBaseline.

(WebCore::RenderTable::inlineBlockBaseline): Try to make comment more direct.

  • rendering/RenderTable.h:

(RenderTable): Replace lastLineBoxBaseline with inlineBlockBaseline.

LayoutTests:

Additional test cases for baseline aligning flexbox.

  • css3/flexbox/flexbox-baseline-margins.html: Added.
  • css3/flexbox/resources/flexbox.css:

(.flex-one): New cross browser value.

  • platform/chromium-linux/css3/flexbox/flexbox-baseline-margins-expected.png: Added.
  • platform/chromium-linux/css3/flexbox/flexbox-baseline-margins-expected.txt: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
10:43 AM Changeset in webkit [132103] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, updating skipped tests that moved.

  • platform/win/TestExpectations:
10:42 AM Changeset in webkit [132102] by leviw@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed Chromium build fix following r132074.

  • WebCore.gypi:
10:39 AM Changeset in webkit [132101] by Martin Robinson
  • 4 edits in releases/WebKitGTK/webkit-1.10

Update configure.ac and the NEWS in preparation for the 1.10.1 release.

.:

  • configure.ac: Update the version.

Source/WebKit/gtk:

  • NEWS: Update the NEWS file.
10:39 AM Changeset in webkit [132100] by Martin Robinson
  • 4 edits in releases/WebKitGTK/webkit-1.10/LayoutTests/platform/gtk

Update baselines to the point where all tests are passing

10:39 AM Changeset in webkit [132099] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.10/Source/WebCore

Merge 131076 - accelerated compositing does not work with ati driver
https://bugs.webkit.org/show_bug.cgi?id=97472

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-10-11
Reviewed by Martin Robinson.

Create m_parentWindow at positive position. Otherwise, parts of it are
not displayed on ati drivers.

Covered by existing tests.

  • platform/gtk/RedirectedXCompositeWindow.cpp:

(WebCore::RedirectedXCompositeWindow::RedirectedXCompositeWindow):

10:39 AM Changeset in webkit [132098] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.10/Source/WebKit/gtk

Merge 130838 - [GTK] Plugins don't display
https://bugs.webkit.org/show_bug.cgi?id=98789

Patch by Daniel Drake <dsd@laptop.org> on 2012-10-09
Reviewed by Martin Robinson.

Fix a recent regression where plugin content was not being displayed.
Bringing webkit_web_view_size_allocate in line with the WebKit2
equivalent solves the issue.

  • webkit/webkitwebview.cpp:

(resizeWebViewFromAllocation): pass allocation request to children
even when the allocation size does not change.
(webkit_web_view_size_allocate): don't bail too early if the
allocation size does not change.

10:39 AM Changeset in webkit [132097] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.10/Source/WebKit/gtk

Merge 130108 - [Gtk] crash when accelerated composition is turned off
https://bugs.webkit.org/show_bug.cgi?id=98099

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-10-01
Reviewed by Martin Robinson.

frame->view()->updateLayoutAndStyleIfNeededRecursive() may reset root
compositing layer in flushAndRenderLayers. So, we check if compositing
is enabled afterwards, and return if it is not.

This bug is handled by LayoutTests/compositing/toggle-compositing.html

  • WebCoreSupport/AcceleratedCompositingContextGL.cpp:

(WebKit::AcceleratedCompositingContext::flushAndRenderLayers):

10:39 AM Changeset in webkit [132096] by Martin Robinson
  • 19 edits in releases/WebKitGTK/webkit-1.10

Merge 129651 - [GTK] Use XDamage to simplify RedirectedXCompositeWindow
https://bugs.webkit.org/show_bug.cgi?id=97267

Reviewed by Alejandro G. Castro.

Use XDamage to queue redraws of the widget when redirecting accelerated compositing
to an offscreen window. This allows removing a finicky timer-based approach, improves
performance, and allows simplifying things greatly.

.:

  • configure.ac: Add support for finding XDamage via pkg-config.

Source/WebCore:

No new tests. This is covered by existing tests.

  • GNUmakefile.am: Add the XDamage CFLAGS in the appropriate place.
  • platform/gtk/RedirectedXCompositeWindow.cpp:

(WebCore::getWindowHashMap): Added.
(WebCore::filterXDamageEvent): Added.
(WebCore::supportsXDamageAndXComposite): Added.
(WebCore::RedirectedXCompositeWindow::create): Fail to create the window if
the XServer doesn't support XDamage and XComposite.
(WebCore::RedirectedXCompositeWindow::RedirectedXCompositeWindow): Add XDamage support and
remove the m_usable size distinction. Add the window the window HashMap now.
(WebCore::RedirectedXCompositeWindow::~RedirectedXCompositeWindow): Remove the window
from the window HashMap.
(WebCore::RedirectedXCompositeWindow::resize): Now just immediately update the size.
(WebCore::RedirectedXCompositeWindow::callDamageNotifyCallback): Added.

  • platform/gtk/RedirectedXCompositeWindow.h:

(WebCore::RedirectedXCompositeWindow::setDamageNotifyCallback): Added.

Source/WebKit/gtk:

  • GNUmakefile.am: Add the XDamage CFLAGS and LIBS.
  • WebCoreSupport/AcceleratedCompositingContext.h:

(AcceleratedCompositingContext): Change the signature of compositeLayersToContext
to accept an enum that explains the composite purpose.

  • WebCoreSupport/AcceleratedCompositingContextGL.cpp:

(WebKit::redirectedWindowDamagedCallback): Added.
(WebKit::AcceleratedCompositingContext::initialize): Handle the situation where
the RedirectedXCompositeWindow returns a null pointer.
(WebKit::AcceleratedCompositingContext::enabled): Ditto.
(WebKit::AcceleratedCompositingContext::renderLayersToWindow): Remove the code handling
the usable size of the RedirectedXCompositeWindow. The usable size is now always equal
to the size.
(WebKit::AcceleratedCompositingContext::compositeLayersToContext): When drawing for a
resize, first clear the entire context. Remove the double swap-buffer, as it's no
longer necessary.
(WebKit::AcceleratedCompositingContext::setRootCompositingLayer): Handle the case that
the redirected window is null.
(WebKit::AcceleratedCompositingContext::resizeRootLayer): Instead of doing another
immediate layer flush, just recomposite the current layer state and schedule a new
flush. This should make resizing faster.
(WebKit::AcceleratedCompositingContext::flushAndRenderLayers): We no longer need to
queue a redraw, unless we want to force one.

Source/WebKit2:

  • GNUmakefile.am: Add the XDamage CFLAGS and LIBS to the appropriate places.
  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(_WebKitWebViewBasePrivate): Remove readyToRenderAcceleratedCompositingResults as
it's no longer necessary.
(webkit_web_view_base_init): Handle the situation where the RedirectedXCompositeWindow
is null.
(webkitWebViewRenderAcceleratedCompositingResults): Ditto.
(resizeWebKitWebViewBaseFromAllocation): Ditto.
(webkitWebViewBaseCreateWebPage): Ditto.
(redirectedWindowDamagedCallback): Added.

  • UIProcess/WebPageProxy.h: Remove InvalidateWidget message.
  • UIProcess/WebPageProxy.messages.in: Ditto.
  • UIProcess/gtk/WebPageProxyGtk.cpp: Ditto.
  • WebProcess/WebPage/WebPage.h: Ditto.
  • WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::compositeLayersToContext): No longer need to
trigger the invalidateWindow message.

  • WebProcess/WebPage/gtk/WebPageGtk.cpp: Ditto.
10:38 AM Changeset in webkit [132095] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.10/Source/WTF

Merge 130076 - Another SIGILL in JavaScriptCore on a Geode processor
https://bugs.webkit.org/show_bug.cgi?id=96286

Patch by Daniel Drake <dsd@laptop.org> on 2012-10-01
Reviewed by Filip Pizlo.

Disable LLint for the GTK build where the build target does not
support SSE2 instructions. Restores support for non-SSE2 processors
such as the AMD Geode.

  • wtf/Platform.h:
10:38 AM Changeset in webkit [132094] by Martin Robinson
  • 3 edits in releases/WebKitGTK/webkit-1.10/Source/WebKit/gtk

Merge 129537 - [GTK] Webkit 1.8.2 fails to build with MinGW with spellchecking enabled
https://bugs.webkit.org/show_bug.cgi?id=93255

Patch by Paweł Forysiuk <tuxator@o2.pl> on 2012-09-25
Reviewed by Martin Robinson.

Build dies because of invalid cast. Additionaly word "interface" is in use with MinGW compiler.

  • WebCoreSupport/TextCheckerClientGtk.cpp:

(WebKit::TextCheckerClientGtk::checkSpellingOfString): Use String to avoid unneded casting

  • webkit/webkitspellcheckerenchant.cpp:

(webkit_spell_checker_enchant_spell_checker_interface_init): rename interface -> checkerInterface

10:38 AM Changeset in webkit [132093] by Martin Robinson
  • 6 edits
    1 add in releases/WebKitGTK/webkit-1.10

Merge 129247 - REGRESSION (r127882): accessibility/spinbutton-value.html failing on GTK
https://bugs.webkit.org/show_bug.cgi?id=96196

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-21
Reviewed by Martin Robinson.

The "regression" is that a new test was added but the support was missing
in the Gtk port for spin buttons.

Source/WebCore:

No new tests. Instead the new test which had been skipped was unskipped
as part of this fix.

  • accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:

(atkRole): Map SpinButtonRole to ATK_ROLE_SPIN_BUTTON
(getInterfaceMaskFromObject): Add SpinButtonRole to the roles implementing
the AtkValue interface.

Tools:

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::valueDescription): Updated the FIXME comment to
indicate that this cannot be implemented until it is implemented in ATK.
URL of the newly-filed ATK bug included for reference.

LayoutTests:

  • platform/gtk/TestExpectations: Unskip the new test.
  • platform/gtk/accessibility/spinbutton-value-expected.txt: Added.
10:38 AM Changeset in webkit [132092] by Martin Robinson
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.10

Merge 129246 - [GTK] [Stable] Infinite recursion in WebCore::AXObjectCache::getOrCreate
https://bugs.webkit.org/show_bug.cgi?id=96932

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-21
Reviewed by Martin Robinson.

Source/WebCore:

Make the decision based on RenderObjects rather than AccessibilityObjects
to avoid the infinite recursion which occurs when remapAriaRoleDueToParent
gets called.

Test: platform/gtk/accessibility/remapped-aria-crash.html

  • accessibility/gtk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

LayoutTests:

Added a new test which replicates the recursion and crash.

  • platform/gtk/accessibility/remapped-aria-crash-expected.txt: Added.
  • platform/gtk/accessibility/remapped-aria-crash.html: Added.
10:32 AM Changeset in webkit [132091] by mario@webkit.org
  • 8 edits in trunk

[GTK] Don't use deprecated AccessibilityObject methods after r99502
https://bugs.webkit.org/show_bug.cgi?id=99985

Reviewed by Chris Fleizach.

Source/WebCore:

Update callers for AccessibilityObject's title() and
accessibilityDescription() so they now use AccessibilityText.

  • accessibility/gtk/WebKitAccessibleUtil.cpp:

(titleTagShouldBeUsedInDescriptionField): Internal helper function.
(accessibilityTitle): New helper function, returns an String with
the title for a AccessibilityObject, using AccessibleText.
(accessibilityDescription): New helper function, returns an String with
the description for a AccessibilityObject, using AccessibleText.

  • accessibility/gtk/WebKitAccessibleUtil.h: Added public

declarations for accessibilityTitle and accessibilityDescription.

  • accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetName): Use new helpers for retrieving the title.
(webkitAccessibleGetDescription): Use new helpers for retrieving
the title and description.

  • accessibility/gtk/WebKitAccessibleInterfaceImage.cpp:

(webkitAccessibleImageGetImageDescription): Use new helpers for
retrieving the title.

LayoutTests:

Update test and expectations to reflect the changes in the
accessible title (now it's the localized one) being returned.

  • platform/gtk/accessibility/media-controls-panel-title-expected.txt: Updated.
  • platform/gtk/accessibility/media-controls-panel-title.html: Updated.
10:24 AM Changeset in webkit [132090] by jochen@chromium.org
  • 11 edits in trunk/Tools

[chromium] add a method for printing message to the WebTestDelegate
https://bugs.webkit.org/show_bug.cgi?id=99960

Reviewed by Adam Barth.

When using the TestRunner library from the content_shell, we can't print
message directly but need to send them to the browser process.

  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebTestDelegate):

  • DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp:

(WebTestRunner::AccessibilityController::fallbackCallback):

  • DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h:

(WebTestRunner::AccessibilityController::setDelegate):
(AccessibilityController):

  • DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):
(WebTestRunner::EventSender::dumpFilenameBeingDragged):

  • DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp:

(GamepadController::connect):
(GamepadController::disconnect):
(GamepadController::setId):
(GamepadController::setButtonCount):
(GamepadController::setButtonData):
(GamepadController::setAxisCount):
(GamepadController::setAxisData):
(GamepadController::fallbackCallback):

  • DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:

(TestDelegate):

  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:

(TestInterfaces::~TestInterfaces):
(TestInterfaces::setDelegate):

  • DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestInterfaces::Internal):
(WebTestRunner::WebTestInterfaces::Internal::printMessage):
(WebTestRunner):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::didBeginEditing):
(WebViewHost::lastContextMenuData):
(WebViewHost::clearContextMenuData):
(WebViewHost::setEditCommand):
(WebViewHost::clearEditCommand):
(WebViewHost::fillSpellingSuggestionList):
(WebViewHost::setGamepadData):
(WebViewHost::printMessage):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

10:19 AM Changeset in webkit [132089] by eae@chromium.org
  • 1 edit
    1 add
    9 deletes in trunk/LayoutTests

Convert fast/sub-pixel/file-upload-control-at-fractional-offset-expected.html to ref test
https://bugs.webkit.org/show_bug.cgi?id=99869

Reviewed by Eric Seidel.

fast/sub-pixel/file-upload-control-at-fractional-offset-expected.html is currently a pixel test, convert it to a ref test instead.

  • fast/sub-pixel/file-upload-control-at-fractional-offset-expected.html: Added.
  • platform/chromium-linux/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png: Removed.
  • platform/chromium-linux/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png: Removed.
  • platform/chromium-mac/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png: Removed.
  • platform/chromium-mac/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.txt: Removed.
  • platform/chromium-win/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png: Removed.
  • platform/chromium-win/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.txt: Removed.
  • platform/gtk/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png: Removed.
  • platform/gtk/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.txt: Removed.
10:16 AM Changeset in webkit [132088] by caseq@chromium.org
  • 11 edits in trunk

Web Inspector: add timeline instrumentation for scrolling of a layer
https://bugs.webkit.org/show_bug.cgi?id=99461

Reviewed by Pavel Feldman.

Source/WebCore:

  • added timeline instrumentation for scrolling of a layer;
  • added TRACE_EVENT for ScrollableArea::scrollPositionChanged()
  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::willScrollLayerImpl):
(WebCore::InspectorInstrumentation::didScrollLayerImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willScrollLayer):
(WebCore):
(WebCore::InspectorInstrumentation::didScrollLayer):

  • inspector/InspectorTimelineAgent.cpp:

(TimelineRecordType):
(WebCore::InspectorTimelineAgent::willScroll):
(WebCore):
(WebCore::InspectorTimelineAgent::didScroll):

  • inspector/InspectorTimelineAgent.h:

(InspectorTimelineAgent):

  • inspector/front-end/TimelineModel.js:
  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel._initRecordStyles):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollTo):

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::scrollPositionChanged):

LayoutTests:

  • added Scroll record type;
  • inspector/timeline/timeline-enum-stability-expected.txt:
10:05 AM Changeset in webkit [132087] by commit-queue@webkit.org
  • 4 edits
    1 move in trunk/Source/WebCore

Moved cmdevtools.js to folder cm/

Web Inspector: Move file cmdevtools.css to cm/
https://bugs.webkit.org/show_bug.cgi?id=99956

Patch by Jan Keromnes <janx@linux.com> on 2012-10-22
Reviewed by Pavel Feldman.

The file cmdevtools.js belongs to the CodeMirror editor experiment in cm/.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/cm/cmdevtools.css: Renamed from Source/WebCore/inspector/front-end/cmdevtools.css.

(.CodeMirror):
(.CodeMirror-scroll):
(.cm-highlight):
(@-webkit-keyframes fadeout):
(to):
(.cm-breakpoint):
(.cm-breakpoint-disabled):
(.cm-breakpoint-conditional):
(.cm-execution-line):
(.cm-s-web-inspector-js span.cm-keyword):
(.cm-s-web-inspector-js span.cm-number):
(.cm-s-web-inspector-js span.cm-comment):
(.cm-s-web-inspector-js span.cm-string):
(.cm-s-web-inspector-js span.cm-string-2):
(.cm-s-web-inspector-css span.cm-keyword):
(.cm-s-web-inspector-css span.cm-number):
(.cm-s-web-inspector-css span.cm-comment):
(.cm-s-web-inspector-css span.cm-string):
(.cm-s-web-inspector-css span.cm-string-2):
(.cm-s-web-inspector-css span.cm-link):
(.cm-s-web-inspector-css span.cm-variable):
(.cm-s-web-inspector-html span.cm-meta):
(.cm-s-web-inspector-html span.cm-comment):
(.cm-s-web-inspector-html span.cm-string):
(.cm-s-web-inspector-html span.cm-tag):
(.cm-s-web-inspector-html span.cm-attribute):
(.cm-s-web-inspector-html span.cm-link):
(.webkit-html-message-bubble):
(.webkit-html-warning-message):
(.webkit-html-error-message):
(.webkit-html-message-line):
(.webkit-html-message-line-hover):

9:56 AM Changeset in webkit [132086] by vsevik@chromium.org
  • 6 edits in trunk

Web Inspector: Prepare mappings to moving uiSourceCodes creation out of them to workspace.
https://bugs.webkit.org/show_bug.cgi?id=99997

Reviewed by Pavel Feldman.

Source/WebCore:

Source mappings could now store a link to temporary uiSourceCodes only.
Otherwise it should retrieve uiSourceCodes from workspace by URL.
Original uiSourceCodes are now temporary in CompilerScriptMapping.

  • inspector/front-end/CompilerScriptMapping.js:

(WebInspector.CompilerScriptMapping):
(WebInspector.CompilerScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.CompilerScriptMapping.prototype.loadSourceMapForScript):
(WebInspector.CompilerScriptMapping.prototype._reset):

  • inspector/front-end/NetworkUISourceCodeProvider.js:

(WebInspector.NetworkUISourceCodeProvider):
(WebInspector.NetworkUISourceCodeProvider.prototype._parsedScriptSource):
(WebInspector.NetworkUISourceCodeProvider.prototype._resourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._addUISourceCode):
(WebInspector.NetworkUISourceCodeProvider.prototype._projectWillReset):

  • inspector/front-end/SASSSourceMapping.js:

(WebInspector.SASSSourceMapping):
(_bindUISourceCode):
(_reset):

LayoutTests:

  • http/tests/inspector/compiler-script-mapping.html:
9:55 AM Changeset in webkit [132085] by andersca@apple.com
  • 21 edits
    1 copy
    1 add in trunk/Source/WebKit2

Don't use CStrings for message receiver names and message names
https://bugs.webkit.org/show_bug.cgi?id=99853

Reviewed by Andreas Kling.

Re-land this with a fix to MessageReceiverMap::dispatchSyncMessage to look in the new global message receivers map.

Introduce StringReference which is similar to DataReference except it holds a pointer to + length of a char *
and can be created from a string literal. Use this in place of CString in MessageEncoder/MessageDecoder and
make MessageReceiverMap use a HashMap from StringReferences to MessageReceivers for global message receivers.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::createSyncMessageEncoder):
(CoreIPC::Connection::dispatchSyncMessage):

  • Platform/CoreIPC/Connection.h:

(Connection):
(CoreIPC::Connection::deprecatedSendSync):
(CoreIPC::Connection::deprecatedSend):

  • Platform/CoreIPC/MessageDecoder.cpp:

(CoreIPC::MessageDecoder::MessageDecoder):

  • Platform/CoreIPC/MessageDecoder.h:

(CoreIPC::MessageDecoder::messageReceiverName):
(CoreIPC::MessageDecoder::messageName):
(MessageDecoder):

  • Platform/CoreIPC/MessageEncoder.cpp:

(CoreIPC::MessageEncoder::create):
(CoreIPC::MessageEncoder::MessageEncoder):

  • Platform/CoreIPC/MessageEncoder.h:

(CoreIPC):
(MessageEncoder):

  • Platform/CoreIPC/MessageReceiverMap.cpp:

(CoreIPC::MessageReceiverMap::addMessageReceiver):
(CoreIPC):
(CoreIPC::MessageReceiverMap::dispatchMessage):

  • Platform/CoreIPC/MessageReceiverMap.h:

(MessageReceiverMap):

  • Platform/CoreIPC/StringReference.cpp: Added.

(CoreIPC):
(CoreIPC::StringReference::encode):
(CoreIPC::StringReference::decode):
(CoreIPC::StringReference::Hash::hash):

  • Platform/CoreIPC/StringReference.h: Added.

(CoreIPC):
(StringReference):
(CoreIPC::StringReference::StringReference):
(CoreIPC::StringReference::isEmpty):
(CoreIPC::StringReference::size):
(CoreIPC::StringReference::data):
(CoreIPC::StringReference::operator==):
(Hash):
(CoreIPC::StringReference::Hash::equal):
(WTF):

  • Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::open):

  • Scripts/webkit2/messages.py:

(message_to_struct_declaration):
(forward_declarations_and_headers):
(generate_messages_header):

  • Scripts/webkit2/messages_unittest.py:
  • Shared/CoreIPCSupport/WebContextMessageKinds.h:
  • Target.pri:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::addMessageReceiver):
(WebKit):

  • UIProcess/WebContext.h:

(WebContext):

  • UIProcess/WebProcessProxy.h:

(WebKit::WebProcessProxy::deprecatedSend):
(WebKit::WebProcessProxy::send):

  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
9:53 AM Changeset in webkit [132084] by rakuco@webkit.org
  • 8 edits in trunk/Source/WebKit2

Unreviewed, rolling out r132072.
http://trac.webkit.org/changeset/132072
https://bugs.webkit.org/show_bug.cgi?id=100011

Made most of the tests crash on the WK2 bot. (Requested by
rakuco on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-22

  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::handleDownloadRequest):

  • UIProcess/API/efl/ewk_context.cpp:

(Ewk_Context):
(Ewk_Context::Ewk_Context):
(ewk_context_ref):
(ewk_context_unref):
(ewk_context_cookie_manager_get):
(ewk_context_favicon_database_get):
(ewk_context_WKContext_get):
(ewk_context_new_from_WKContext):
(ewk_context_download_job_add):
(ewk_context_download_job_get):
(ewk_context_download_job_remove):
(ewk_context_request_manager_get):
(ewk_context_url_scheme_request_received):
(ewk_context_default_get):
(ewk_context_new):
(ewk_context_new_with_injected_bundle_path):
(ewk_context_url_scheme_register):
(ewk_context_vibration_client_callbacks_set):
(ewk_context_history_callbacks_set):
(ewk_context_history_client_get):
(ewk_context_visited_link_add):
(ewk_context_cache_model_set):
(ewk_context_cache_model_get):

  • UIProcess/API/efl/ewk_context_download_client.cpp:

(decideDestinationWithSuggestedFilename):
(didReceiveResponse):
(didCreateDestination):
(didReceiveData):
(didFail):
(didCancel):
(didFinish):
(ewk_context_download_client_attach):

  • UIProcess/API/efl/ewk_context_history_client.cpp:

(getEwkHistoryDelegate):
(didNavigateWithNavigationData):
(didPerformClientRedirect):
(didPerformServerRedirect):
(didUpdateHistoryTitle):
(populateVisitedLinks):
(ewk_context_history_client_attach):

  • UIProcess/API/efl/ewk_context_private.h:
  • UIProcess/API/efl/ewk_context_request_manager_client.cpp:

(didReceiveURIRequest):
(ewk_context_request_manager_client_attach):

  • UIProcess/API/efl/ewk_view.cpp:

(Ewk_View_Private_Data):
(Ewk_View_Private_Data::Ewk_View_Private_Data):
(Ewk_View_Private_Data::~Ewk_View_Private_Data):
(_ewk_view_priv_del):
(_ewk_view_initialize):
(ewk_view_base_add):
(ewk_view_add_with_context):
(ewk_view_context_get):
(ewk_view_update_icon):

9:49 AM Changeset in webkit [132083] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove specialized handling for isIndex fields.
https://bugs.webkit.org/show_bug.cgi?id=100004

Reviewed by Rob Buis.

PR 214342.

Remove special handling for isIndex field as the tag
is rewritten.

Reviewed Internally by Yongxin Dai and Nima Ghanavatian.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::inputStyle):
(BlackBerry::WebKit::InputHandler::elementType):

9:48 AM Changeset in webkit [132082] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Fixing expectations for fast/dom/gc-acid3.html to pass the linting.

  • platform/gtk/TestExpectations:
9:44 AM Changeset in webkit [132081] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Gstreamer 1.0 not working
https://bugs.webkit.org/show_bug.cgi?id=99852

Patch by Nicolas Dufresne <nicolas.dufresne@collabora.com> on 2012-10-22
Reviewed by Philippe Normand.

There was a series of trivial issue, g_object_is_floating() was called
on type GstCaps (which is not a GObject), webkitGstGetPadCaps() was
returning non-fixed caps and GST_MESSAGE_DURATION has been renamed
to GST_MESSAGE_DURATION_CHANGED.

Most failing test passes now.

  • platform/graphics/gstreamer/GRefPtrGStreamer.cpp:

(WTF::adoptGRef):

  • platform/graphics/gstreamer/GStreamerVersioning.cpp:

(webkitGstGetPadCaps):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::handleMessage):

9:30 AM Changeset in webkit [132080] by Darin Adler
  • 2 edits in trunk/Source/WebKit2
  • UIProcess/API/mac/WKView.mm:

(-[WKView view:stringForToolTip:point:userData:]): Fix build. Forgot to save file
before committing.

9:28 AM Changeset in webkit [132079] by Darin Adler
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r131686): Crash in NSToolTipManager mouseEnteredToolTip
<rdar://problem/12527528> and https://bugs.webkit.org/show_bug.cgi?id=99792

Roll out the tool tip part of r131686 since it still seems to be causing trouble.

  • UIProcess/API/mac/WKView.mm:

(-[WKView view:stringForToolTip:point:userData:]): Added this method back.
(-[WKView _wk_toolTipChangedFrom:to:]): Use self as owner again, eliminating the
separate WKToolTipDelegate object.

9:26 AM Changeset in webkit [132078] by vsevik@chromium.org
  • 13 edits in trunk

Web Inspector: Treat dynamic anonymous scripts as other anonymous and fix anonymous script editing and breakpoints.
https://bugs.webkit.org/show_bug.cgi?id=99989

Reviewed by Pavel Feldman.

Source/WebCore:

Dynamic anonymous scripts are now mapped to anonymous temporary uiSourceCodes.
ResourceScriptMapping now supports two types of temporary uiSourceCodes:

  • original uiSourceCodes represent scripts while main uiSourceCodes are diverged;
  • temporary uiSourceCodes represent scripts for which resources are not yet loaded.
  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.breakpointStorageId):
(WebInspector.BreakpointManager.Storage.prototype._updateBreakpoint):

  • inspector/front-end/NetworkUISourceCodeProvider.js:

(WebInspector.NetworkUISourceCodeProvider.prototype._parsedScriptSource):

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype._hasMergedToVM):
(WebInspector.ResourceScriptMapping.prototype.addScript):
(WebInspector.ResourceScriptMapping.prototype._deleteOriginalUISourceCodeForScripts):
(WebInspector.ResourceScriptMapping.prototype._deleteTemporaryUISourceCodeForScripts):
(WebInspector.ResourceScriptMapping.prototype._bindUISourceCodeToScripts):
(WebInspector.ResourceScriptMapping.prototype._createUISourceCode):
(WebInspector.ResourceScriptMapping.prototype._getOrCreateTemporaryUISourceCode):
(WebInspector.ResourceScriptMapping.prototype._getOrCreateOriginalUISourceCode):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAddedToWorkspace):
(WebInspector.ResourceScriptMapping.prototype._scriptsForUISourceCode.get if):
(WebInspector.ResourceScriptMapping.prototype._reset):

LayoutTests:

  • http/tests/inspector-enabled/dynamic-scripts-expected.txt:
  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • inspector/debugger/dynamic-script-tag-expected.txt:
  • inspector/debugger/dynamic-scripts-expected.txt:
  • inspector/debugger/live-edit-breakpoints-expected.txt:
  • inspector/debugger/live-edit-breakpoints.html:
  • inspector/debugger/resource-script-mapping-expected.txt:
  • inspector/debugger/resource-script-mapping.html:
9:07 AM Changeset in webkit [132077] by eae@chromium.org
  • 3 edits
    5 deletes in trunk/LayoutTests

Convert fast/sub-pixel/float-containing-block-with-margin.html to text test
https://bugs.webkit.org/show_bug.cgi?id=99866

Reviewed by Eric Seidel.

fast/sub-pixel/float-containing-block-with-margin.html doesn't
need to be a pixel test, convert it to a text one.

  • fast/sub-pixel/float-containing-block-with-margin-expected.txt:
  • fast/sub-pixel/float-containing-block-with-margin.html:
  • platform/chromium-linux/fast/sub-pixel/float-containing-block-with-margin-expected.png: Removed.
  • platform/chromium-mac-lion/fast/sub-pixel: Removed.
  • platform/chromium-mac-snowleopard/fast/sub-pixel/float-containing-block-with-margin-expected.png: Removed.
  • platform/chromium-mac/fast/sub-pixel/float-containing-block-with-margin-expected.png: Removed.
  • platform/chromium-win/fast/sub-pixel/float-containing-block-with-margin-expected.png: Removed.
8:52 AM Changeset in webkit [132076] by commit-queue@webkit.org
  • 13 edits
    4 adds in trunk

[css3-text] Add rendering support for -webkit-text-decoration-style
https://bugs.webkit.org/show_bug.cgi?id=94094

Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2012-10-22
Reviewed by Julien Chaffraix.

Source/WebCore:

This patch implements the "text-decoration-style" property rendering as
specified in CSS3 working draft, with "-webkit-" prefix. The specification can
be found here: http://dev.w3.org/csswg/css3-text/#text-decoration-style

Additionally, Mozilla implementation details can be found here:
https://developer.mozilla.org/en/CSS/text-decoration-style

Tests: fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-style.html

fast/css3-text/css3-text-decoration/text-decoration-style.html

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::setPlatformStrokeStyle):

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawLine):

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::toQPenStyle):
(WebCore::GraphicsContext::drawLine):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::setupPaintForStroking):

  • platform/graphics/wince/GraphicsContextWinCE.cpp:

(WebCore::createPen):

  • platform/graphics/wx/GraphicsContextWx.cpp:

(WebCore::strokeStyleToWxPenStyle):
Added 'DoubleStroke' and 'WavyStroke' to StrokeStyle enum and updated
platform-specific stroke handling. Some styles requires
platform-specific implementation (handled in bug 92868).

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint):
(WebCore::textDecorationStyleToStrokeStyle): Added static function that
translates text decoration to stroke styles.
(WebCore::InlineTextBox::paintDecoration): Text decoration style does
not specify a property for line thickness (like border-width does for
border style), so we statically set it to 1 for now. The 'double' style
implementation simply adds a parallel line (depending if it is
underline, overline or line-through) and the space between lines follows
the approach used by border's 'double' style.

  • rendering/InlineTextBox.h:

(InlineTextBox):

  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:

Added text decoration style rendering support to
InlineTextBox::paintDecoration().

LayoutTests:

Added paint and repaint layout tests for CSS3 text-decoration-style
property. Pixel results are not included due to missing platform support
for some decoration styles (handled on bug 93507). These are going
to be added when platform support is complete.

  • fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-style-expected.txt: Added.
  • fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-style.html: Added.
  • fast/css3-text/css3-text-decoration/text-decoration-style-expected.txt: Added.
  • fast/css3-text/css3-text-decoration/text-decoration-style.html: Added.
8:36 AM Changeset in webkit [132075] by allan.jensen@digia.com
  • 2 edits in trunk/Tools

I now only watch Selectors instead of all of CSS.

Unreviewed update of watchlist.

  • Scripts/webkitpy/common/config/watchlist:
8:33 AM Changeset in webkit [132074] by allan.jensen@digia.com
  • 2 edits
    1 add
    2 deletes in trunk/Source/WebCore

[Qt] Use the DNS resolve queue
https://bugs.webkit.org/show_bug.cgi?id=99994

Reviewed by Simon Hausmann.

Use the DNS resolve queue, to ensure we can prefetch more than just the first 10 hostname encountered
during parsing. It also ensure each hostname is only appears once in the queue.

  • Target.pri:
  • platform/network/qt/DNSQt.cpp: Added.

(DnsPrefetchHelper):
(WebCore::DnsPrefetchHelper::DnsPrefetchHelper):
(WebCore::DnsPrefetchHelper::lookup):
(WebCore::DnsPrefetchHelper::lookedUp):
(WebCore::prefetchDNS):
(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences):
(WebCore::DNSResolveQueue::platformResolve):

  • platform/network/qt/DnsPrefetchHelper.cpp: Removed.
  • platform/network/qt/DnsPrefetchHelper.h: Removed.

(DnsPrefetchHelper):

8:03 AM Changeset in webkit [132073] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Memory leak in Ewk_Form_Submission_Request::fieldValue()
https://bugs.webkit.org/show_bug.cgi?id=99993

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-22
Reviewed by Kenneth Rohde Christiansen.

Adopt the WKStringRef returned by toCopiedAPI() in
Ewk_Form_Submission_Request::fieldValue() to avoid
a memory leak.

  • UIProcess/API/efl/ewk_form_submission_request.cpp:

(Ewk_Form_Submission_Request::fieldValue):

7:47 AM Changeset in webkit [132072] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebKit2

[EFL][WK2] Refactor Ewk_Context
https://bugs.webkit.org/show_bug.cgi?id=99594

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-22
Reviewed by Kenneth Rohde Christiansen.

Ewk_Context is now encapsulated to a C++ class inherited from WTF::RefCounted.

  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::handleDownloadRequest):

  • UIProcess/API/efl/ewk_context.cpp:

(Ewk_Context::Ewk_Context):
(Ewk_Context::~Ewk_Context):
(Ewk_Context::create):
(Ewk_Context::defaultContext):
(Ewk_Context::cookieManager):
(Ewk_Context::faviconDatabase):
(Ewk_Context::registerURLScheme):
(Ewk_Context::vibrationProvider):
(Ewk_Context::addVisitedLink):
(Ewk_Context::setCacheModel):
(Ewk_Context::cacheModel):
(ewk_context_ref):
(ewk_context_unref):
(ewk_context_cookie_manager_get):
(ewk_context_favicon_database_get):
(Ewk_Context::wkContext):
(Ewk_Context::addDownloadJob):
(Ewk_Context::downloadJob):
(Ewk_Context::removeDownloadJob):
(Ewk_Context::requestManager):
(Ewk_Context::urlSchemeRequestReceived):
(ewk_context_default_get):
(ewk_context_new):
(ewk_context_new_with_injected_bundle_path):
(ewk_context_url_scheme_register):
(ewk_context_vibration_client_callbacks_set):
(ewk_context_history_callbacks_set):
(ewk_context_visited_link_add):
(ewk_context_cache_model_set):
(ewk_context_cache_model_get):

  • UIProcess/API/efl/ewk_context_download_client.cpp:

(decideDestinationWithSuggestedFilename):
(didReceiveResponse):
(didCreateDestination):
(didReceiveData):
(didFail):
(didCancel):
(didFinish):
(ewk_context_download_client_attach):

  • UIProcess/API/efl/ewk_context_history_client.cpp:

(getEwkHistoryClient):
(didNavigateWithNavigationData):
(didPerformClientRedirect):
(didPerformServerRedirect):
(didUpdateHistoryTitle):
(populateVisitedLinks):
(ewk_context_history_client_attach):

  • UIProcess/API/efl/ewk_context_private.h:

(Ewk_Context):
(Ewk_Context::create):
(Ewk_Context::historyClient):

  • UIProcess/API/efl/ewk_context_request_manager_client.cpp:

(didReceiveURIRequest):
(ewk_context_request_manager_client_attach):

  • UIProcess/API/efl/ewk_view.cpp:

(Ewk_View_Private_Data):
(Ewk_View_Private_Data::Ewk_View_Private_Data):
(Ewk_View_Private_Data::~Ewk_View_Private_Data):
(_ewk_view_priv_del):
(_ewk_view_initialize):
(ewk_view_base_add):
(ewk_view_add_with_context):
(ewk_view_context_get):
(ewk_view_update_icon):

7:29 AM Changeset in webkit [132071] by arv@chromium.org
  • 7 edits
    4 adds in trunk

HTMLBaseElement href attribute binding returns wrong URL
https://bugs.webkit.org/show_bug.cgi?id=98184

Reviewed by Ojan Vafai.

Resolve the href attribute binding relative to the document URL instead of resolving it to the
base element itself. If there is no href attribute this should return the fallback base URL.

http://www.whatwg.org/specs/web-apps/current-work/multipage/semantics.html#the-base-element

Source/WebCore:

Tests: fast/dom/HTMLAnchorElement/set-href-attribute-rebase.html

fast/dom/HTMLBaseElement/href-attribute-resolves-with-respect-to-document.html

  • html/HTMLBaseElement.cpp:

(WebCore::HTMLBaseElement::href): Don't use completeURL. Resolve href based on document's URL instead
of the generic [Reflect, URL] binding.
(WebCore::HTMLBaseElement::setHref): Just sets the attribute.

  • html/HTMLBaseElement.h:
  • html/HTMLBaseElement.idl: We can no longer use [Reflect, URL]

LayoutTests:

  • fast/dom/HTMLAnchorElement/set-href-attribute-rebase-expected.txt: Added.
  • fast/dom/HTMLAnchorElement/set-href-attribute-rebase.html: Added.
  • fast/dom/HTMLBaseElement/href-attribute-resolves-with-respect-to-document-expected.txt: Added.
  • fast/dom/HTMLBaseElement/href-attribute-resolves-with-respect-to-document.html: Added.
  • fast/dom/element-attribute-js-null-expected.txt:
  • fast/dom/element-attribute-js-null.html:
7:14 AM Changeset in webkit [132070] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Revisions should not be restored and persisted for anonymous uiSourceCodes.
https://bugs.webkit.org/show_bug.cgi?id=99991

Reviewed by Alexander Pavlov.

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):

7:10 AM Changeset in webkit [132069] by fmalita@chromium.org
  • 3 edits
    2 adds in trunk

Incorrect embedded SVG image sizing on first load
https://bugs.webkit.org/show_bug.cgi?id=99489

Reviewed by Nikolas Zimmermann.

Source/WebCore:

RenderSVGImage::updateImageViewport() must be called after the image loader is finished,
to ensure that a SVGImageCache::SizeAndScalesMap entry is created even if layout has
already been performed.

Test: svg/custom/svg-image-initial-size.html

  • rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::imageChanged):

LayoutTests:

  • svg/custom/svg-image-initial-size-expected.html: Added.
  • svg/custom/svg-image-initial-size.html: Added.
7:04 AM Changeset in webkit [132068] by yurys@chromium.org
  • 2 edits in trunk/Tools

Make sure base and derived class pointers are different in MemoryInstrumentationTest.instrumentedWithMultipleAncestors
https://bugs.webkit.org/show_bug.cgi?id=99987

Reviewed by Alexander Pavlov.

  • TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp: changed first parent

class in the list so that it has virtual table as well as the second one. This
way we may be sure that pointer to the second ancestor class will differ from
the pointer to the derived class.

5:53 AM Changeset in webkit [132067] by Simon Hausmann
  • 2 edits in trunk/Source/WTF

Unreviewed: Re-enable LLINT on Qt/Linux after r131932.

  • wtf/Platform.h:
5:45 AM Changeset in webkit [132066] by Simon Hausmann
  • 6 edits in trunk/Source

[Qt] Fix build without QtWidgets
https://bugs.webkit.org/show_bug.cgi?id=99981

Reviewed by Tor Arne Vestbø.

Source/WebKit/qt:

Remove dependency to QtWidgets that is not needed here anymore since
the removal of the QtQuick1 code.

  • declarative/experimental/experimental.pri:
  • declarative/public.pri:

Source/WebKit2:

Make it possible to compile WebProcess without QtWidgets by instantiating a
QGuiApplication instead of a QApplication if we're built without widgets.

  • WebProcess.pro:
  • qt/MainQt.cpp:

(main):

5:15 AM Changeset in webkit [132065] by yurys@chromium.org
  • 2 edits in trunk/Tools

Unreviewed. Fix compilation after r132059.

  • TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
4:39 AM Changeset in webkit [132064] by dominik.rottsches@intel.com
  • 2 edits in trunk/LayoutTests

[EFL][WK2] Skip plugins/npruntime/remove-property.html
https://bugs.webkit.org/show_bug.cgi?id=99978

Unreviewed EFL gardening.

Skip plugins/npruntime/remove-property.html which started
failing after r131990.

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-22

  • platform/efl-wk2/TestExpectations:
4:23 AM Changeset in webkit [132063] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[EFL] pc files should use DATA_INSTALL_DIR for datadir
https://bugs.webkit.org/show_bug.cgi?id=99961

Patch by Ryuan Choi <ryuan.choi@gmail.com> on 2012-10-22
Reviewed by Gyuyoung Kim.

Source/WebKit/efl:

  • ewebkit.pc.in: Used DATA_INSTALL_DIR instead of hardcoded shared/XXX

Source/WebKit2:

  • ewebkit.pc.in: Fixed wrong datadir
4:04 AM EFLWebKitBuildBots edited by rakuco@webkit.org
tmpsantos is back, remove myself from the gardening schedule (diff)
3:56 AM Changeset in webkit [132062] by dominik.rottsches@intel.com
  • 2 edits in trunk/Tools

Adding Cairo and Harfbuzz watchlist entries

Unreviewed watchlist update.

Added myself to these new ones and SVG.

  • Scripts/webkitpy/common/config/watchlist:
3:49 AM Changeset in webkit [132061] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

Change the path of the include files in the text decoration test cases.
https://bugs.webkit.org/show_bug.cgi?id=99974

Patch by Dongwoo Joshua Im <dw.im@samsung.com> on 2012-10-22
Reviewed by Gyuyoung Kim.

The include path is differentiated by http://trac.webkit.org/changeset/132043

  • fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line.html:
  • fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style.html:
  • fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-line.html:
3:43 AM Changeset in webkit [132060] by keishi@webkit.org
  • 6 edits in trunk/Source

Remove monthFormatInLDML
https://bugs.webkit.org/show_bug.cgi?id=99971

Reviewed by Kent Tamura.

Source/Platform:

  • chromium/public/WebLocalizedString.h:

Source/WebCore:

Removing monthFormatInLDML from localized strings because Localizer class now provides the same functionality.

No new tests. Just removing unused code.

  • platform/LocalizedStrings.h:

(WebCore):

Source/WebKit/chromium:

  • src/LocalizedStrings.cpp:
3:29 AM Changeset in webkit [132059] by yurys@chromium.org
  • 4 edits in trunk

Web Inspector: do not double count memory of objects with multiple ancestors
https://bugs.webkit.org/show_bug.cgi?id=99958

Reviewed by Alexander Pavlov.

Source/WTF:

Make sure memory occupied by objects of classes with multiple inheritance is
not double counted.

  • wtf/MemoryInstrumentation.h:

(WTF::MemoryObjectInfo::MemoryObjectInfo):
(WTF::MemoryObjectInfo::reportedPointer):
(WTF::MemoryObjectInfo::reportObjectInfo): 1) Store actual pointer to the instrumented
object as it may differ from the original pointer by which it was reported. 2) Make
the method non-template and calculate object size on the caller side.
(MemoryObjectInfo):
(WTF::MemoryInstrumentation::reportObjectMemoryUsage):
(WTF::MemoryClassInfo::MemoryClassInfo):
(WTF::MemoryInstrumentation::InstrumentedPointer::process): use adjusted pointer
returned by reportMemoryUsage to check if the object has already been visited when
the pointer differs from the orinal one(it may happen if the object was reported
by a pointer to one of its base classes).

Tools:

  • TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp: Test that there

is no double counting in case of multiple inheritance.

3:18 AM Changeset in webkit [132058] by zandobersek@gmail.com
  • 6 edits in trunk

[GTK] Enable Microdata DOM API
https://bugs.webkit.org/show_bug.cgi?id=99033

Reviewed by Martin Robinson.

Source/WebCore:

Enable the Microdata DOM API, but still disable it when the unstable
features should be disabled (for instance in release builds).

No new tests - related tests are being unskipped and are expected to pass.

  • GNUmakefile.am:
  • GNUmakefile.features.am:
  • bindings/gobject/GNUmakefile.am: Add the required files so the Microdata

API GObject bindings are generated and built.

LayoutTests:

Unskip the Microdata tests, they all pass now that the feature has been enabled.

  • platform/gtk/TestExpectations:
3:14 AM Changeset in webkit [132057] by keishi@webkit.org
  • 4 edits in trunk/Source

[Chromium] Rename WeekFormatInLDML to WeekFormatTemplate
https://bugs.webkit.org/show_bug.cgi?id=99972

Reviewed by Kent Tamura.

Source/Platform:

Renaming because Chromium won't be returning a week format in LDML.

  • chromium/public/WebLocalizedString.h:

Source/WebKit/chromium:

  • src/LocalizedStrings.cpp:

(WebCore::weekFormatInLDML):

3:14 AM Changeset in webkit [132056] by zandobersek@gmail.com
  • 5 edits in trunk

[GTK] Enable CSP 1.1
https://bugs.webkit.org/show_bug.cgi?id=99064

Reviewed by Martin Robinson.

Source/WebCore:

Enable CSP 1.1 in development builds but keep it disabled when the
unstable features should not be enabled (like in stable releases).

No new tests - they already exist and will be unskipped.

  • GNUmakefile.am:
  • GNUmakefile.features.am:

LayoutTests:

Unskip the CSP 1.1 layout tests as they all pass with the feature enabled.

  • platform/gtk/TestExpectations:
3:10 AM Changeset in webkit [132055] by keishi@webkit.org
  • 2 edits in trunk/LayoutTests

Test date-suggestion-picker-reset-value-after-reload.html will timeout when running with other tests
https://bugs.webkit.org/show_bug.cgi?id=99969

Reviewed by Kent Tamura.

When running with other tests the iframe onload event seems to fire before the script tag is parsed.

  • platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-reset-value-after-reload.html:
2:58 AM Changeset in webkit [132054] by jocelyn.turcotte@digia.com
  • 20 edits in trunk/Source

[Qt] Fix "ASSERTION FAILED: !document->inPageCache()" when loading a page
https://bugs.webkit.org/show_bug.cgi?id=98514

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

The problem is that we call setFixedVisibleContentRect, which triggers
a layout, after the document has been put in the page cache and before
the load has been actually committed.

This applies the same trick as with setFixedLayoutSize by passing the rect
in Frame::createView and calling setFixedVisibleContentRect before the
new FrameView gets attached to the Frame/Document to prevent the layout.

  • WebCore.exp.in:
  • page/Frame.cpp:

(WebCore::Frame::createView): Give a default value to the fixedLayoutSize and
useFixedLayout arguments as well since they are used exceptionally.

  • page/Frame.h:

(Frame):

Source/WebKit/blackberry:

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::transitionToCommittedForNewPage):

Source/WebKit/chromium:

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::createFrameView):

Source/WebKit/efl:

  • ewk/ewk_frame.cpp:

(ewk_frame_view_create_for_view):

Source/WebKit/gtk:

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::transitionToCommittedForNewPage):

Source/WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage): Use FrameView::fixedVisibleContentRect
instead of FrameView::visibleContentRect as the source to always keep the correct state.

Source/WebKit/win:

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::transitionToCommittedForNewPage):

Source/WebKit/wx:

  • WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore::FrameLoaderClientWx::transitionToCommittedForNewPage):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage): Use FrameView::fixedVisibleContentRect
instead of WebFrame::visibleContentBounds as the source to always keep the correct state.

2:54 AM Changeset in webkit [132053] by allan.jensen@digia.com
  • 5 edits
    2 adds in trunk

[Qt] Handle GET of blob URLs.
https://bugs.webkit.org/show_bug.cgi?id=99053

Reviewed by Simon Hausmann.

Source/WebCore:

Let BlobResourceHandle handle Blob request internally.

  • platform/network/qt/ResourceHandleQt.cpp:

(WebCore::ResourceHandle::loadResourceSynchronously):

LayoutTests:

Unskip tests working after we handle GET of Blob URLs. Unfortunately they require beginDragWithFiles,
and thus only work in DRT.

  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/qt/fast/files/workers/worker-read-blob-async-actual.txt: Added.
2:48 AM Changeset in webkit [132052] by allan.jensen@digia.com
  • 11 edits
    1 add in trunk

[Qt] Basic gesture event handling
https://bugs.webkit.org/show_bug.cgi?id=66173

Reviewed by Simon Hausmann.

Source/WebKit/qt:

Implement basic handling of QGestureEvent converting and forwarding
Tap and TapAndHold gestures to WebCore.

  • Api/qwebpage.cpp:

(QWebPagePrivate::gestureEvent):
(QWebPage::event):

  • Api/qwebpage_p.h:

(QWebPagePrivate):

  • WebCoreSupport/WebEventConversion.cpp:

(WebKitPlatformGestureEvent):
(WebCore::WebKitPlatformGestureEvent::WebKitPlatformGestureEvent):
(WebCore::convertGesture):

  • WebCoreSupport/WebEventConversion.h:

Tools:

Add support for eventSender.gestureLongPress.

  • DumpRenderTree/qt/EventSenderQt.cpp:

(EventSender::EventSender):
(EventSender::gestureLongPress):

  • DumpRenderTree/qt/EventSenderQt.h:

(EventSender):

LayoutTests:

  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/qt/fast/events/touch/gesture/gesture-click-expected.txt: Added.
2:35 AM Changeset in webkit [132051] by bashi@chromium.org
  • 3 edits in trunk/Source/WebCore

HarfBuzzShaper::shape() should return false when it adds no glyph to GlyphBuffer
https://bugs.webkit.org/show_bug.cgi?id=99966

Reviewed by Kent Tamura.

If no glyph is added to GlyphBuffer, HarfBuzzShaper::shape() returns false.

No new tests. Confirmed the fix by using Address Sanitizer.

  • platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:

(WebCore::HarfBuzzShaper::shape):
(WebCore::HarfBuzzShaper::fillGlyphBuffer): Returns false when glyphBuffer.size() == 0

  • platform/graphics/harfbuzz/ng/HarfBuzzShaper.h:

(HarfBuzzShaper):

2:24 AM Changeset in webkit [132050] by rakuco@webkit.org
  • 2 edits in trunk/Tools

[WTR] Properly initialize TestRunner::m_dumpSelectionRect.
https://bugs.webkit.org/show_bug.cgi?id=99970

Reviewed by Kenneth Rohde Christiansen.

Follow-up to r131476: actually initialize m_dumpSelectionRect to
some value to avoid some flakyness in the tests.

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::TestRunner):

2:20 AM Changeset in webkit [132049] by caseq@chromium.org
  • 1 edit in branches/chromium/1271/Source/WebKit/chromium/src/WebViewImpl.cpp

Merge 129511 - [chromium] adding a page overlay causes endless update loop when accelerated compositing is used
https://bugs.webkit.org/show_bug.cgi?id=97466

Reviewed by James Robinson.

Do not update overlays in composite() -- doing so ultimately causes invalidation
of the view, hence another update and another call do composite(). Overlays should be
updated only when their content changes.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::composite):

TBR=caseq@chromium.org
Review URL: https://codereview.chromium.org/11235025

2:17 AM Changeset in webkit [132048] by caseq@chromium.org
  • 1 edit in branches/chromium/1271/Source/WebKit/chromium/src/WebViewImpl.cpp

Merge 129772 - Page overlays are not updated when WebView is resized
https://bugs.webkit.org/show_bug.cgi?id=97789

Reviewed by Vsevolod Vlasov.

Invalidate page overlays when view is resized.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::sendResizeEventAndRepaint):

TBR=caseq@chromium.org
Review URL: https://codereview.chromium.org/11235024

2:11 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
Add auth dialog bugs and update the target version (diff)
2:04 AM Changeset in webkit [132047] by shinyak@chromium.org
  • 6 edits
    2 adds in trunk

[Shadow] ASSERT triggered when we try reprojecting fallback elements.
https://bugs.webkit.org/show_bug.cgi?id=99815

Reviewed by Hajime Morita.

Source/WebCore:

When fallback elements of InsertionPoint is reprojected, they were attached twice.
We have to skip attaching them if they are attached. We also add a few ASSERT not to
allow attaching twice if not necessary.

We have confirmed that this patch does not regress the performance. The summary of the
performance test is the following:

Dromaeo/dom-modify.html [runs/s]:

median stdev min max

without this patch: 3928 184 3655 4361
with this patch : 3925 178 3652 4350

Parser/html5-full-render.html [s]:

median stdev min max

without this patch: 3821 17 3811 3850
with this patch : 3838 4.4 3833 3844

Test: fast/dom/shadow/content-reprojection-fallback-crash.html

  • dom/ContainerNode.cpp:

(WebCore):
(WebCore::childAttachedAllowedWhenAttachingChildren): If true, children of this node might
be attached in advance because of ShadowDOM attaching process.

  • dom/ContainerNode.h:

(ContainerNode):
(WebCore):
(WebCore::ContainerNode::attachChildren):

  • dom/Element.cpp:

(WebCore::Element::attach):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::attach):

LayoutTests:

  • fast/dom/shadow/content-reprojection-fallback-crash-expected.txt: Added.
  • fast/dom/shadow/content-reprojection-fallback-crash.html: Added.
2:04 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
Add user style sheet (diff)
1:59 AM Changeset in webkit [132046] by vestbo@webkit.org
  • 3 edits in trunk/Tools

[Qt] Don't build any of the tools in production_build

Reviewed by Simon Hausmann.

  • Tools.pro:
  • qmake/mkspecs/features/configure.prf:
1:52 AM Changeset in webkit [132045] by pfeldman@chromium.org
  • 20 edits in trunk

Web Inspector: merge "docked" state into the "dock side" enum.
https://bugs.webkit.org/show_bug.cgi?id=99717

Reviewed by Vsevolod Vlasov.

.:

Otherwise, it is hard to manage these inter-dependent flags.

  • Source/autotools/symbols.filter:

Source/WebCore:

Otherwise, it is hard to manage these inter-dependent flags.

  • WebCore.exp.in:
  • inspector/InspectorFrontendClient.h:

(InspectorFrontendClient):

  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::requestSetDockSide):
(WebCore::InspectorFrontendClientLocal::setAttachedWindow):

  • inspector/InspectorFrontendClientLocal.h:

(InspectorFrontendClientLocal):

  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::requestSetDockSide):

  • inspector/InspectorFrontendHost.h:

(InspectorFrontendHost):

  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/DockController.js:

(WebInspector.DockController):
(WebInspector.DockController.prototype._updateUI.get sides):
(WebInspector.DockController.prototype._updateUI):
(WebInspector.DockController.prototype._toggleDockState):

  • inspector/front-end/InspectorFrontendAPI.js:

(InspectorFrontendAPI.setAttachedWindow):
(InspectorFrontendAPI.setDockSide):

  • inspector/front-end/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.requestSetDockSide):

  • inspector/front-end/externs.js:

Source/WebKit/chromium:

Otherwise, it is hard to manage these inter-dependent flags.

  • src/InspectorFrontendClientImpl.cpp:

(WebKit::InspectorFrontendClientImpl::requestSetDockSide):

  • src/InspectorFrontendClientImpl.h:

(InspectorFrontendClientImpl):

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
1:49 AM Changeset in webkit [132044] by rakuco@webkit.org
  • 49 edits
    7 adds in trunk/LayoutTests

[EFL] Rebaseline pixel expectations after r131941 and r131991, part 3.

  • platform/efl/fast/repaint/scroll-fixed-layer-with-reflection-expected.png:
  • platform/efl/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png:
  • platform/efl/fast/repaint/scroll-fixed-reflected-layer-expected.png:
  • platform/efl/fast/repaint/scroll-in-clipped-layer-expected.png:
  • platform/efl/fast/repaint/scroll-in-fixed-layer-expected.png:
  • platform/efl/fast/repaint/scroll-in-transformed-layer-expected.png:
  • platform/efl/fast/repaint/scroll-inside-table-cell-expected.png:
  • platform/efl/fast/repaint/scroll-relative-table-inside-table-cell-expected.png:
  • platform/efl/fast/repaint/scroll-with-transformed-parent-layer-expected.png:
  • platform/efl/fast/repaint/search-field-cancel-expected.png:
  • platform/efl/fast/repaint/select-option-background-color-expected.png:
  • platform/efl/fast/repaint/selected-replaced-expected.png:
  • platform/efl/fast/repaint/selection-after-delete-expected.png:
  • platform/efl/fast/repaint/selection-after-remove-expected.png:
  • platform/efl/fast/repaint/selection-gap-overflow-scroll-2-expected.png:
  • platform/efl/fast/repaint/selection-gap-overflow-scroll-expected.png:
  • platform/efl/fast/repaint/selection-rl-expected.png:
  • platform/efl/fast/repaint/stacked-diacritics-expected.png:
  • platform/efl/fast/repaint/static-to-positioned-expected.png:
  • platform/efl/fast/repaint/subtree-layoutstate-transform-expected.png:
  • platform/efl/fast/repaint/subtree-root-clip-2-expected.png: Added.
  • platform/efl/fast/repaint/subtree-root-clip-3-expected.png: Added.
  • platform/efl/fast/repaint/subtree-root-clip-expected.png: Added.
  • platform/efl/fast/repaint/subtree-root-skipped-expected.png:
  • platform/efl/fast/repaint/table-cell-collapsed-border-expected.png:
  • platform/efl/fast/repaint/table-cell-move-expected.png:
  • platform/efl/fast/repaint/table-col-background-expected.png:
  • platform/efl/fast/repaint/table-collapsed-border-expected.png:
  • platform/efl/fast/repaint/table-extra-bottom-grow-expected.png:
  • platform/efl/fast/repaint/table-outer-border-expected.png:
  • platform/efl/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png:
  • platform/efl/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png:
  • platform/efl/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png:
  • platform/efl/fast/repaint/table-row-expected.png:
  • platform/efl/fast/repaint/table-section-overflow-expected.png:
  • platform/efl/fast/repaint/table-section-repaint-expected.png:
  • platform/efl/fast/repaint/table-two-pass-layout-overpaint-expected.png:
  • platform/efl/fast/repaint/text-append-dirty-lines-expected.png:
  • platform/efl/fast/repaint/text-selection-rect-in-overflow-2-expected.png:
  • platform/efl/fast/repaint/text-selection-rect-in-overflow-expected.png:
  • platform/efl/fast/repaint/textarea-set-disabled-expected.png:
  • platform/efl/fast/repaint/transform-absolute-child-expected.png:
  • platform/efl/fast/repaint/transform-absolute-in-positioned-container-expected.png:
  • platform/efl/fast/repaint/transform-disable-layoutstate-expected.png:
  • platform/efl/fast/repaint/transform-layout-repaint-expected.png:
  • platform/efl/fast/repaint/transform-relative-position-expected.png:
  • platform/efl/fast/repaint/transform-repaint-descendants-expected.png:
  • platform/efl/fast/repaint/transform-replaced-shadows-expected.png:
  • platform/efl/fast/repaint/transform-rotate-and-remove-expected.png:
  • platform/efl/fast/repaint/transform-translate-expected.png:
  • platform/efl/fast/table/border-collapsing/cached-69296-expected.png:
  • platform/efl/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.png: Added.
  • platform/efl/fast/table/border-collapsing/cached-change-row-border-width-expected.png: Added.
  • platform/efl/fast/table/border-collapsing/cached-change-tbody-border-width-expected.png: Added.
  • platform/efl/fast/table/border-collapsing/collapsed-border-with-col-colgroup-span-expected.png: Added.
1:45 AM Changeset in webkit [132043] by commit-queue@webkit.org
  • 6 edits
    14 moves
    11 adds in trunk/LayoutTests

Move LayoutTests/fast/css3-text-decoration directory into LayoutTests/fast/css3-text directory.
https://bugs.webkit.org/show_bug.cgi?id=99948

Patch by Dongwoo Joshua Im <dw.im@samsung.com> on 2012-10-22
Reviewed by Hajime Morita.

css3-text-decoration is one of the feature under the ENABLE_CSS3_TEXT flag,
it should be maintained in the css3-text directory with other features under the same flag.

  • fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt: Renamed from LayoutTests/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt.
  • fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line.html: Renamed from LayoutTests/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line.html.
  • fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt: Renamed from LayoutTests/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt.
  • fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style.html: Renamed from LayoutTests/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style.html.
  • fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-decoration-line.js: Renamed from LayoutTests/fast/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-decoration-line.js.

(testElementStyle):
(testComputedStyle):

  • fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-decoration-style.js: Renamed from LayoutTests/fast/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-decoration-style.js.

(testElementStyle):
(testComputedStyleValue):
(testValue):

  • fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-line-expected.png: Renamed from LayoutTests/fast/css3-text-decoration/repaint/repaint-text-decoration-line-expected.png.
  • fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-line-expected.txt: Renamed from LayoutTests/fast/css3-text-decoration/repaint/repaint-text-decoration-line-expected.txt.
  • fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-line.html: Renamed from LayoutTests/fast/css3-text-decoration/repaint/repaint-text-decoration-line.html.
  • fast/css3-text/css3-text-decoration/text-decoration-line-expected.html: Renamed from LayoutTests/fast/css3-text-decoration/text-decoration-line-expected.html.
  • fast/css3-text/css3-text-decoration/text-decoration-line.html: Renamed from LayoutTests/fast/css3-text-decoration/text-decoration-line.html.
  • platform/chromium/TestExpectations:
  • platform/efl/fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-line-expected.png: Renamed from LayoutTests/platform/efl/fast/css3-text-decoration/repaint/repaint-text-decoration-line-expected.png.
  • platform/mac/TestExpectations:
  • platform/qt-4.8/TestExpectations:
  • platform/qt-mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt: Renamed from LayoutTests/platform/win/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt.
  • platform/win/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt: Renamed from LayoutTests/platform/win/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt.
1:43 AM Changeset in webkit [132042] by vestbo@webkit.org
  • 3 edits in trunk/Tools

[Qt] Move OBJECTS_DIR and friends to default_pre.prf

The introduction of load(qt_build_config) in .qmake.conf meant
that we started loading qtmodule.pri, which in turn set both
MOC_DIR, RCC_DIR, and OBJECTS_DIR.

We were setting OBJECTS_DIR in default_post under a isEmpty() guard
so that project files could override the objects dir. Instead of
using the isEmpty() check we move it to defaul_pre, which will
override the qtmodule.pri settings, but still allow project files
to override it.

Reviewed by Ossy.

1:42 AM Changeset in webkit [132041] by commit-queue@webkit.org
  • 11 edits in trunk

WebKitTestRunner needs testRunner.queueLoadingScript and testRunner.queueNonLoadingScript
https://bugs.webkit.org/show_bug.cgi?id=42675

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-22
Reviewed by Kenneth Rohde Christiansen.

Tools:

Added implementation of testRunner.queueLoadingScript and testRunner.queueNonLoadingScript.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::queueLoadingScript):
(WTR):
(WTR::InjectedBundle::queueNonLoadingScript):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::queueLoadingScript):
(WTR):
(WTR::TestRunner::queueNonLoadingScript):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

  • WebKitTestRunner/WorkQueueManager.cpp:

(WTR):
(WTR::runJavaScriptFunction):
(ScriptItem):
(WTR::ScriptItem::ScriptItem):
(WTR::ScriptItem::invoke):
(WTR::WorkQueueManager::queueBackNavigation):
(WTR::WorkQueueManager::queueLoadingScript):
(WTR::WorkQueueManager::queueNonLoadingScript):

  • WebKitTestRunner/WorkQueueManager.h:

(WorkQueueManager):

LayoutTests:

Unskipped corresponding test cases for WK2. Put those which still fail to appropriate
groups.

  • platform/wk2/TestExpectations:
1:40 AM Changeset in webkit [132040] by rakuco@webkit.org
  • 55 edits
    1 add in trunk/LayoutTests

[EFL] Rebaseline pixel expectations after r131941 and r131991, part 2.

  • platform/efl/fast/repaint/body-background-image-expected.png:
  • platform/efl/fast/repaint/layout-state-only-positioned-expected.png:
  • platform/efl/fast/repaint/layout-state-relative-expected.png:
  • platform/efl/fast/repaint/layout-state-scrolloffset-expected.png:
  • platform/efl/fast/repaint/layout-state-scrolloffset2-expected.png:
  • platform/efl/fast/repaint/layout-state-scrolloffset3-expected.png:
  • platform/efl/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/efl/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/efl/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/efl/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/efl/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/efl/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/efl/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/efl/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/efl/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/efl/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/efl/fast/repaint/line-flow-with-floats-in-regions-expected.png:
  • platform/efl/fast/repaint/line-in-scrolled-clipped-block-expected.png:
  • platform/efl/fast/repaint/line-overflow-expected.png:
  • platform/efl/fast/repaint/lines-with-layout-delta-expected.png:
  • platform/efl/fast/repaint/list-marker-2-expected.png:
  • platform/efl/fast/repaint/make-children-non-inline-expected.png:
  • platform/efl/fast/repaint/moving-shadow-on-path-expected.png:
  • platform/efl/fast/repaint/multicol-repaint-expected.png:
  • platform/efl/fast/repaint/nested-iframe-scroll-inner-expected.png:
  • platform/efl/fast/repaint/nested-iframe-scroll-outer-expected.png:
  • platform/efl/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png:
  • platform/efl/fast/repaint/opacity-change-on-overflow-float-expected.png:
  • platform/efl/fast/repaint/outline-child-repaint-expected.png:
  • platform/efl/fast/repaint/outline-inset-expected.png:
  • platform/efl/fast/repaint/outline-repaint-glitch-expected.png:
  • platform/efl/fast/repaint/outline-shrinking-expected.png:
  • platform/efl/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png:
  • platform/efl/fast/repaint/overflow-clip-subtree-layout-expected.png: Added.
  • platform/efl/fast/repaint/overflow-delete-line-expected.png:
  • platform/efl/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png:
  • platform/efl/fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.png:
  • platform/efl/fast/repaint/overflow-hide-expected.png:
  • platform/efl/fast/repaint/overflow-into-content-expected.png:
  • platform/efl/fast/repaint/overflow-outline-repaint-expected.png:
  • platform/efl/fast/repaint/overflow-scroll-delete-expected.png:
  • platform/efl/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png:
  • platform/efl/fast/repaint/overflow-show-expected.png:
  • platform/efl/fast/repaint/reflection-redraw-expected.png:
  • platform/efl/fast/repaint/reflection-repaint-test-expected.png:
  • platform/efl/fast/repaint/region-painting-invalidation-expected.png:
  • platform/efl/fast/repaint/region-painting-via-layout-expected.png:
  • platform/efl/fast/repaint/rel-positioned-inline-with-overflow-expected.png:
  • platform/efl/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
  • platform/efl/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/efl/fast/repaint/repaint-during-scroll-expected.png:
  • platform/efl/fast/repaint/repaint-during-scroll-with-zoom-expected.png:
  • platform/efl/fast/repaint/repaint-resized-overflow-expected.png:
  • platform/efl/fast/repaint/scroll-absolute-layer-with-reflection-expected.png:
  • platform/efl/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png:
1:30 AM Changeset in webkit [132039] by rakuco@webkit.org
  • 74 edits
    2 adds
    1 delete in trunk/LayoutTests

[EFL] Rebaseline pixel expectations after r131941 and r131991, part 1.

  • platform/efl/fast/repaint/4774354-expected.png:
  • platform/efl/fast/repaint/4776765-expected.png:
  • platform/efl/fast/repaint/absolute-position-changed-expected.png:
  • platform/efl/fast/repaint/add-table-overpaint-expected.png: Removed.
  • platform/efl/fast/repaint/background-generated-expected.png:
  • platform/efl/fast/repaint/background-misaligned-expected.png:
  • platform/efl/fast/repaint/backgroundSizeRepaint-expected.png:
  • platform/efl/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
  • platform/efl/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/efl/fast/repaint/block-no-inflow-children-expected.png:
  • platform/efl/fast/repaint/block-selection-gap-in-composited-layer-expected.png:
  • platform/efl/fast/repaint/block-selection-gap-in-table-cell-expected.png:
  • platform/efl/fast/repaint/block-selection-gap-stale-cache-2-expected.png:
  • platform/efl/fast/repaint/block-selection-gap-stale-cache-expected.png:
  • platform/efl/fast/repaint/border-fit-lines-expected.png:
  • platform/efl/fast/repaint/border-radius-repaint-expected.png:
  • platform/efl/fast/repaint/border-repaint-glitch-expected.png:
  • platform/efl/fast/repaint/box-shadow-dynamic-expected.png:
  • platform/efl/fast/repaint/box-shadow-inset-repaint-expected.png:
  • platform/efl/fast/repaint/bugzilla-3509-expected.png:
  • platform/efl/fast/repaint/bugzilla-5699-expected.png:
  • platform/efl/fast/repaint/bugzilla-6278-expected.png:
  • platform/efl/fast/repaint/bugzilla-6388-expected.png:
  • platform/efl/fast/repaint/bugzilla-6473-expected.png:
  • platform/efl/fast/repaint/bugzilla-7235-expected.png:
  • platform/efl/fast/repaint/button-spurious-layout-hint-expected.png:
  • platform/efl/fast/repaint/canvas-putImageData-expected.png:
  • platform/efl/fast/repaint/caret-outside-block-expected.png:
  • platform/efl/fast/repaint/change-transform-expected.png:
  • platform/efl/fast/repaint/clip-with-layout-delta-expected.png:
  • platform/efl/fast/repaint/clipped-relative-expected.png:
  • platform/efl/fast/repaint/containing-block-position-change-expected.png:
  • platform/efl/fast/repaint/content-into-overflow-expected.png:
  • platform/efl/fast/repaint/continuation-after-outline-expected.png:
  • platform/efl/fast/repaint/control-clip-expected.png:
  • platform/efl/fast/repaint/create-layer-repaint-expected.png:
  • platform/efl/fast/repaint/delete-into-nested-block-expected.png:
  • platform/efl/fast/repaint/dynamic-table-vertical-alignment-change-expected.png:
  • platform/efl/fast/repaint/erase-overflow-expected.png:
  • platform/efl/fast/repaint/fixed-after-scroll-expected.png:
  • platform/efl/fast/repaint/fixed-and-absolute-position-scrolled-expected.png:
  • platform/efl/fast/repaint/fixed-child-move-after-scroll-expected.png:
  • platform/efl/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png:
  • platform/efl/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png:
  • platform/efl/fast/repaint/fixed-expected.png:
  • platform/efl/fast/repaint/fixed-move-after-keyboard-scroll-expected.png:
  • platform/efl/fast/repaint/fixed-move-after-scroll-expected.png:
  • platform/efl/fast/repaint/fixed-position-transparency-with-overflow-expected.png:
  • platform/efl/fast/repaint/fixed-scale-expected.png:
  • platform/efl/fast/repaint/fixed-scroll-simple-expected.png:
  • platform/efl/fast/repaint/fixed-table-cell-expected.png:
  • platform/efl/fast/repaint/fixed-table-overflow-expected.png:
  • platform/efl/fast/repaint/fixed-table-overflow-zindex-expected.png:
  • platform/efl/fast/repaint/fixed-tranformed-expected.png:
  • platform/efl/fast/repaint/float-in-new-block-with-layout-delta-expected.png:
  • platform/efl/fast/repaint/float-move-during-layout-expected.png:
  • platform/efl/fast/repaint/float-new-in-block-expected.png:
  • platform/efl/fast/repaint/float-overflow-expected.png: Added.
  • platform/efl/fast/repaint/float-overflow-right-expected.png: Added.
  • platform/efl/fast/repaint/gradients-em-stops-repaint-expected.png:
  • platform/efl/fast/repaint/iframe-scroll-repaint-expected.png:
  • platform/efl/fast/repaint/inline-block-resize-expected.png:
  • platform/efl/fast/repaint/inline-color-change-expected.png:
  • platform/efl/fast/repaint/inline-horizontal-bt-overflow-expected.png:
  • platform/efl/fast/repaint/inline-outline-repaint-expected.png:
  • platform/efl/fast/repaint/inline-vertical-lr-overflow-expected.png:
  • platform/efl/fast/repaint/inline-vertical-rl-overflow-expected.png:
  • platform/efl/fast/repaint/intermediate-layout-position-clip-expected.png:
  • platform/efl/fast/repaint/intermediate-layout-position-expected.png:
  • platform/efl/fast/repaint/invisible-objects-expected.png:
  • platform/efl/fast/repaint/japanese-rl-selection-clear-expected.png:
  • platform/efl/fast/repaint/japanese-rl-selection-repaint-expected.png:
  • platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
  • platform/efl/fast/repaint/layer-full-repaint-expected.png:
  • platform/efl/fast/repaint/layer-hide-when-needs-layout-expected.png:
  • platform/efl/fast/repaint/layer-visibility-expected.png:
1:26 AM Changeset in webkit [132038] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed follow up to update test result after r132033.

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::installPerContextProperties):

1:22 AM Changeset in webkit [132037] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding flaky crashing expectations for fast/dom/gc-acid3.html
and http/tests/misc/acid3.html.
Removing timeout expectations for tests that were fixed in r131942.
Reclassifying svg/animations/animate-css-xml-attributeType.html
as a non-flaky failure.

  • platform/gtk/TestExpectations:
1:10 AM EFLCookiesApiTutorial created by Krzysztof Kuliga
1:06 AM Changeset in webkit [132036] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed Chromium rebaselines.

  • platform/chromium/TestExpectations:
12:58 AM EFLWebKit edited by Krzysztof Kuliga
(diff)
12:47 AM Changeset in webkit [132035] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

Unreviewed, a follow-up to r132034 where I forgot to address
Ojan's review comment about the race condition in handleLocationChange.

  • TestResultServer/static-dashboards/dashboard_base.js:

(handleLocationChange):

12:44 AM Changeset in webkit [132034] by zandobersek@gmail.com
  • 10 edits
    2 adds in trunk/Tools

[TestResultServer] Move the resource loading into a dedicated class
https://bugs.webkit.org/show_bug.cgi?id=99246

Reviewed by Ojan Vafai.

A new 'loader' namespace is created, containing the request method (previously located in dashboard_base.js)
and the new Loader object, which handles the loading of all the necessary data the dashboard might require.

  • TestResultServer/static-dashboards/aggregate_results.html: Include the loader.js source file.
  • TestResultServer/static-dashboards/builders.js:

(requestBuilderList): Use the request method located in the loader namespace instead of the removed doXHR method.
(onBuilderListLoad): Now parses the response text of the passed-in XHR. When all the builder lists are loaded the
resource loader object is notified appropriately.
(onErrorLoadingBuilderList): The partial function that calls this function also adds an XHR parameter.

  • TestResultServer/static-dashboards/dashboard_base.js: Much of the resource loading-related code is moved to loader.js.

The Loader object is now used to load all the required resources.
(parseParameters): Don't push the 'builder' parameter into the current state if the unit tests are being run.
(resourceLoadingComplete): This method gets called when all the resources are loaded and the dashboard should
proceed with generating the page.
(handleLocationChange):

  • TestResultServer/static-dashboards/flakiness_dashboard.html: Include the loader.js source file.
  • TestResultServer/static-dashboards/flakiness_dashboard.js: The request method has been relocated to the loader namespace.
  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: The affected test cases are modified appropriately.

(test):

  • TestResultServer/static-dashboards/loader.js: Added.

(.): A new namespace is introduced, publicly exporting the request method that performs an XHR operation and a Loader object
which oversees resource loading. The loading is done in steps, first loading the builders list, after that the results files
the current dashboard needs, and lastly the TestExpectations files if they are required by the dashboard. When done the loader
calls the resourceLoadingComplete method located in dashboard_base.js. This signals the dashboard all resources are available
and it can proceed with generating the dashboard page.

  • TestResultServer/static-dashboards/loader_unittests.js: Added. Contains unit tests for the Loader object, covering the

incremental loading and the loading of results files and TestExpectations files. The builders list loading is currently not
tested as the unit tests page overrides related methods that possibly affect other tests' behavior.

  • TestResultServer/static-dashboards/run-unittests.html: Now includes the loader.js and loader_unittests.js source file.

Refactors the code a bit due to changes in how onBuilderListLoad behaves.

  • TestResultServer/static-dashboards/timeline_explorer.html: Now includes the loader.js source file.
  • TestResultServer/static-dashboards/treemap.html: Ditto. Also refactors the code to take into account

that all the test files are now loaded before generating the dashboard page.

Oct 21, 2012:

11:44 PM Changeset in webkit [132033] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

[V8] V8EnablePerContext shouldn't require document() accessor to the native object.
https://bugs.webkit.org/show_bug.cgi?id=99954

Reviewed by Kentaro Hara.

It now refers ScriptExecutionContext of the creation context instead of document() of
wrapped object.

No new tests. No behavior change at this time.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateImplementation):

11:37 PM Changeset in webkit [132032] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] QNX build fails when building against Qt without clipboard support
https://bugs.webkit.org/show_bug.cgi?id=98040

Patch by Milian Wolff <milian.wolff@kdab.com> on 2012-10-21
Reviewed by Simon Hausmann.

Gracefully handle QT_NO_CLIPBOARD and do not try to access qApp->clipboard()
in such cases. Instead, return false to indicate global selection is unsupported.

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::supportsGlobalSelection):

10:45 PM Changeset in webkit [132031] by tkent@chromium.org
  • 7 edits in trunk/Source

Page popup: Fix crash by events after closing
https://bugs.webkit.org/show_bug.cgi?id=99951

Reviewed by Hajime Morita.

Source/WebCore:

WebCore should provide a way to uninstall a DOMWindowPagePopup supplement.

No new tests. The bug is timing-dependent.

  • page/DOMWindowPagePopup.cpp:

(WebCore::DOMWindowPagePopup::uninstall):
Added. Calls Supplementable::removeSupplement.

  • page/DOMWindowPagePopup.h:

(DOMWindowPagePopup): Declare uninstall.

  • platform/Supplementable.h:

(WebCore::Supplementable::removeSupplement): Added.

Source/WebKit/chromium:

  • We should not handle events after closePopup call.
  • We should uninstall a DOMWindowPagePopup supplement in closePopup.
  • src/WebPagePopupImpl.cpp:

(WebKit::WebPagePopupImpl::WebPagePopupImpl):
Initialize m_closing.
(WebKit::WebPagePopupImpl::handleGestureEvent):
Don't handle events if m_closing.
(WebKit::WebPagePopupImpl::handleInputEvent): Ditto.
(WebKit::WebPagePopupImpl::handleKeyEvent): Ditto.
(WebKit::WebPagePopupImpl::closePopup):

  • Uninstall a DOMWindowPagePopup supplement.
  • Set m_closing.
  • src/WebPagePopupImpl.h:

(WebPagePopupImpl): Declare m_closing.

10:37 PM Changeset in webkit [132030] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, suppressing failure until I can figure out what's going on.

  • platform/chromium/TestExpectations:
10:13 PM Changeset in webkit [132029] by jochen@chromium.org
  • 22 edits
    6 copies
    2 adds in trunk/Tools

[chromium] introduce a public API for the TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=99904

Reviewed by Adam Barth.

The API decouples the public API from the underlying implementation, so
embedders can depend on it. I'm also changing DRT to consume the
TestRunner API through the public API, except for DRTTestRunner and all
places that require Task.h. These two will be migrated in later changes.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/DRTDevToolsAgent.h:
  • DumpRenderTree/chromium/DRTDevToolsClient.h:
  • DumpRenderTree/chromium/MockSpellCheck.cpp:

(MockSpellCheck::fillSuggestionList):

  • DumpRenderTree/chromium/MockSpellCheck.h:

(MockSpellCheck):

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
  • DumpRenderTree/chromium/MockWebSpeechInputController.h:
  • DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
  • DumpRenderTree/chromium/TestRunner/public/WebAccessibilityController.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.

(WebKit):
(WebTestRunner):
(WebAccessibilityController):

  • DumpRenderTree/chromium/TestRunner/public/WebEventSender.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.

(WebKit):
(WebTestRunner):
(WebEventSender):

  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.

(WebKit):
(WebTestRunner):
(WebTestDelegate):

  • DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h.

(WebKit):
(WebTestRunner):
(WebTestInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp:

(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h:

(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):
(WebTestRunner::makeMenuItemStringsFor):

  • DumpRenderTree/chromium/TestRunner/src/EventSender.h:

(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:

(TestDelegate):

  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:

(TestInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/WebAccessibilityController.cpp: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.

(WebTestRunner):
(WebTestRunner::WebAccessibilityController::WebAccessibilityController):
(WebTestRunner::WebAccessibilityController::setFocusedElement):
(WebTestRunner::WebAccessibilityController::notificationReceived):
(WebTestRunner::WebAccessibilityController::shouldLogAccessibilityEvents):

  • DumpRenderTree/chromium/TestRunner/src/WebEventSender.cpp: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.

(WebTestRunner):
(WebTestRunner::WebEventSender::WebEventSender):
(WebTestRunner::WebEventSender::doDragDrop):

  • DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Added.

(WebTestRunner):
(WebTestInterfaces::Internal):
(WebTestRunner::WebTestInterfaces::Internal::testInterfaces):
(WebTestRunner::WebTestInterfaces::Internal::accessibilityController):
(WebTestRunner::WebTestInterfaces::Internal::eventSender):
(WebTestRunner::WebTestInterfaces::Internal::Internal):
(WebTestRunner::WebTestInterfaces::Internal::~Internal):
(WebTestRunner::WebTestInterfaces::Internal::setDelegate):
(WebTestRunner::WebTestInterfaces::Internal::clearContextMenuData):
(WebTestRunner::WebTestInterfaces::Internal::clearEditCommand):
(WebTestRunner::WebTestInterfaces::Internal::fillSpellingSuggestionList):
(WebTestRunner::WebTestInterfaces::Internal::setEditCommand):
(WebTestRunner::WebTestInterfaces::Internal::lastContextMenuData):
(WebTestRunner::WebTestInterfaces::Internal::setGamepadData):
(WebTestRunner::WebTestInterfaces::WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::setWebView):
(WebTestRunner::WebTestInterfaces::setDelegate):
(WebTestRunner::WebTestInterfaces::bindTo):
(WebTestRunner::WebTestInterfaces::resetAll):
(WebTestRunner::WebTestInterfaces::accessibilityController):
(WebTestRunner::WebTestInterfaces::eventSender):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::initialize):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell::eventSender):
(TestShell::accessibilityController):
(TestShell):

  • DumpRenderTree/chromium/WebUserMediaClientMock.h:
  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::finishLastTextCheck):
(WebViewHost::fillSpellingSuggestionList):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

10:08 PM Changeset in webkit [132028] by keishi@webkit.org
  • 50 edits
    3 adds
    1 delete in trunk

Refactor picker tests to fix flakiness and share code
https://bugs.webkit.org/show_bug.cgi?id=99671

Reviewed by Kent Tamura.

Source/WebCore:

Disable transitions until the picker is fully ready. This should fix flakiness.

No new tests.

  • Resources/pagepopups/calendarPicker.css:

(.preparing .unavailable): Disable transitions.
(.preparing .available): Disable transitions.

  • Resources/pagepopups/calendarPicker.js:

(CalendarPicker): Set "preparing" class.
(CalendarPicker.prototype._handleWindowResize): Remove the "preparing" class when the window finishes resizing.

LayoutTests:

Refactored so picker tests share code and structure.

  • fast/forms/resources/picker-common.js: Shared by all picker tests. Requires js-test-pre.js. Sets up an asynchronous test.

(openPicker): Opens the picker for the given input and calls the callback when the picker did open.
(popupOpenCallbackWrapper):
(sendKey):

  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium/TestExpectations: Marked all tests as not flaky. Marked all pixel tests as need rebaseline.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.txt:
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.txt:
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step.html:
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance.html:
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html:
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations.html:
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-pre-100-year.html:
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-with-step-expected.txt:
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-with-step.html:
  • platform/chromium/fast/forms/calendar-picker/resources/calendar-picker-common.js:
  • platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.txt:
  • platform/chromium/fast/forms/color/color-suggestion-picker-appearance.html:
  • platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.txt:
  • platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance.html:
  • platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.txt:
  • platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance.html:
  • platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.txt:
  • platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance.html:
  • platform/chromium/fast/forms/page-popup/page-popup-adjust-rect.html:
  • platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.txt:
  • platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.txt:
  • platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl.html:
  • platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.txt:
  • platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar.html:
  • platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance.html:
  • platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-key-operations-expected.txt:
  • platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-key-operations.html:
  • platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-min-max-attribute.html:
  • platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-mouse-operations.html:
  • platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-reset-value-after-reload.html:
  • platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-step-attribute-expected.txt:
  • platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-step-attribute.html:
  • platform/chromium/fast/forms/suggestion-picker/resources/suggestion-picker-common.js: Moved to resource directory like all other js files.

(valueForEntry):
(highlightedEntry):
(entryValues):

  • platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.txt:
  • platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.txt:
  • platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl.html:
  • platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.txt:
  • platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar.html:
  • platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance.html:
  • platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-key-operations.html:
  • platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-min-max-attribute.html:
  • platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-mouse-operations.html:
  • platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-step-attribute.html:
9:59 PM EFLWebKit edited by Joone Hur
(diff)
9:52 PM Changeset in webkit [132027] by dpranke@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

Unreviewed, could've sworn this was in the previous patch ...

  • platform/chromium-win-xp/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Removed.
  • platform/chromium-win/fast/hidpi/gradient-with-scaled-ancestor-expected.png:
9:06 PM Changeset in webkit [132026] by dpranke@chromium.org
  • 1 edit
    2 moves
    2 adds
    7 deletes in trunk/LayoutTests

Unreviewed. More chromium baseline cleanup after r132022.

  • platform/chromium-mac-lion/editing/selection/iframe-expected.png: Added.
  • platform/chromium-mac-lion/editing/selection/move-by-line-001-expected.png: Added.
  • platform/chromium-mac-lion/svg/custom/pattern-scaling-expected.png: Removed.
  • platform/chromium-mac-lion/svg/custom/pattern-scaling-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/pattern-scaling-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/pattern-scaling-expected.txt: Removed.
  • platform/chromium-mac/svg/custom/pattern-scaling-expected.txt: Removed.
  • platform/chromium-win-xp/svg/custom/pattern-scaling-expected.png: Removed.
  • platform/chromium-win-xp/svg/custom/pattern-scaling-expected.txt: Removed.
  • platform/chromium-win/svg/custom/pattern-scaling-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/custom/pattern-scaling-expected.png.
  • platform/chromium/svg/custom/pattern-scaling-expected.txt: Renamed from LayoutTests/platform/chromium-linux/svg/custom/pattern-scaling-expected.txt.
8:33 PM Changeset in webkit [132025] by ostapenko.viatcheslav@nokia.com
  • 2 edits in trunk/Tools

Unreviewed. Updating my emails.

7:58 PM Changeset in webkit [132024] by shinyak@chromium.org
  • 4 edits
    2 adds in trunk

Web Inspector: Shadow DOM: Node removal doesn't reflect.
https://bugs.webkit.org/show_bug.cgi?id=99567

Reviewed by Pavel Feldman.

Source/WebCore:

We have to call InspectorInstrumentation::willRemoveDOMNode() even if a node is in a shadow tree.
Otherwise, node won't be removed from the inspector.

Test: inspector/elements/update-shadowdom.html

  • dom/ContainerNode.cpp:

(WebCore::dispatchChildRemovalEvents):

LayoutTests:

  • inspector/elements/update-shadowdom-expected.txt: Added.
  • inspector/elements/update-shadowdom.html: Added.
  • platform/mac/TestExpectations:
7:37 PM Changeset in webkit [132023] by kling@webkit.org
  • 13 edits in trunk/Source

Remove Page::javaScriptURLsAreAllowed setting.
<http://webkit.org/b/99944>

Reviewed by Anders Carlsson.

Source/WebCore:

This setting was exposed through internal WebView API in Apple's WebKit1.
There are no longer any clients of that API.

This is a step towards preventing elements from modifying their own attributes
below attributeChanged().

  • WebCore.exp.in:
  • WebCore.order:
  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::executeIfJavaScriptURL):

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::parseAttribute):

  • page/Page.cpp:

(WebCore::Page::Page):

  • page/Page.h:

(Page):

Source/WebKit/mac:

  • WebKit.order:
  • WebView/WebView.mm:
  • WebView/WebViewPrivate.h:

Source/WebKit/win:

Have WebView::setJavaScriptURLsAreAllowed() do nothing and return E_NOTIMPL
to prevent COM ABI breakage.

  • WebView.cpp:

(WebView::setJavaScriptURLsAreAllowed):

7:27 PM Changeset in webkit [132022] by dpranke@chromium.org
  • 5 edits
    1 copy
    1 add in trunk/LayoutTests

Unreviewed, more Chromium ML baselining minor cleanups.

  • platform/chromium-mac-lion/editing/pasteboard/drag-selected-image-to-contenteditable-expected.png: Copied from LayoutTests/platform/chromium-mac/editing/pasteboard/drag-selected-image-to-contenteditable-expected.png.
  • platform/chromium-mac/editing/pasteboard/drag-selected-image-to-contenteditable-expected.png:
  • platform/chromium-mac/editing/selection/iframe-expected.png:
  • platform/chromium-mac/editing/selection/move-by-line-001-expected.png:
  • platform/chromium-win-xp/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
  • platform/chromium/TestExpectations:
7:02 PM Changeset in webkit [132021] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Storing the enclosing rect dimensions of the first finger for a two finger tap
https://bugs.webkit.org/show_bug.cgi?id=99763

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-10-21
Reviewed by Adam Barth.

Add a struct |twoFingerTap| inside the union |data| of a WebGestureEvent. The fields |firstFingerWidth|
and |firstFingerHeight| will represent the dimensions of the enclosing rectangle corresponding to the
first touch point in the gesture. These will be used in a future CL to perform target fuzzing on a
two-finger tap gesture.

Note: I chose not to name the two fields |width| and |height| so that they aren't confused with the
width and height of the gesture's bounding box, which contains the enclosing rectangles of both touch
points. My future fuzzing CL will only be concerned with the location and enclosing rectangle of the
first touch point.

  • public/WebInputEvent.h:
6:39 PM Changeset in webkit [132020] by dpranke@chromium.org
  • 230 edits
    228 copies
    10 adds in trunk/LayoutTests

Unreviewed, rebaseline remaining Chromium ML editing tests.

(long list of new baselines omitted).

6:27 PM Changeset in webkit [132019] by commit-queue@webkit.org
  • 12 edits in trunk/Source

Add a separate flag for rgb swizzling whether it can be modified or not
https://bugs.webkit.org/show_bug.cgi?id=98728

BitmapTexture swizzles the source image if the OpenGL driver
doesn't support the BGRA extension.
In case of directly composited images, the source image should not
be modified.

http://www.satine.org/research/webkit/snowleopard/snowstack.html

Patch by Hyungchan Kim <hyungchan2.kim@lge.com> on 2012-10-21
Reviewed by Noam Rosenthal.

No new tests as this is only testable on specific hardware and
currently not avaiable in the bots.

Source/WebCore:

  • platform/graphics/texmap/TextureMapper.h:

(BitmapTexture):

  • platform/graphics/texmap/TextureMapperBackingStore.cpp:

(WebCore::TextureMapperTile::updateContents):
(WebCore::TextureMapperTiledBackingStore::updateContentsFromImageIfNeeded):
(WebCore::TextureMapperTiledBackingStore::updateContents):

  • platform/graphics/texmap/TextureMapperBackingStore.h:

(TextureMapperTile):
(TextureMapperTiledBackingStore):
(WebCore::TextureMapperTiledBackingStore::updateContents):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::drawRepaintCounter):
(WebCore::BitmapTextureGL::updateContents):

  • platform/graphics/texmap/TextureMapperGL.h:

(BitmapTextureGL):

  • platform/graphics/texmap/TextureMapperImageBuffer.cpp:

(WebCore::BitmapTextureImageBuffer::updateContents):

  • platform/graphics/texmap/TextureMapperImageBuffer.h:

(BitmapTextureImageBuffer):

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::updateBackingStore):

Source/WebKit2:

  • platform/graphics/texmap/TextureMapper.h:

(BitmapTexture):

  • platform/graphics/texmap/TextureMapperBackingStore.cpp:

(WebCore::TextureMapperTile::updateContents):
(WebCore::TextureMapperTiledBackingStore::updateContentsFromImageIfNeeded):
(WebCore::TextureMapperTiledBackingStore::updateContents):

  • platform/graphics/texmap/TextureMapperBackingStore.h:

(TextureMapperTile):
(TextureMapperTiledBackingStore):
(WebCore::TextureMapperTiledBackingStore::updateContents):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::drawRepaintCounter):
(WebCore::BitmapTextureGL::updateContents):

  • platform/graphics/texmap/TextureMapperGL.h:

(BitmapTextureGL):

  • platform/graphics/texmap/TextureMapperImageBuffer.cpp:

(WebCore::BitmapTextureImageBuffer::updateContents):

  • platform/graphics/texmap/TextureMapperImageBuffer.h:

(BitmapTextureImageBuffer):

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::updateBackingStore):

6:25 PM Changeset in webkit [132018] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[EFL] Fix failure to access the inspector resources
https://bugs.webkit.org/show_bug.cgi?id=99816

Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-10-21
Reviewed by Gyuyoung Kim.

access() returns -1, if path has a file protocol like "file://".
And I have removed it from the first argument of access().
If not, inspectorBaseURL() or inspectorFilesPath() always returns WEB_INSPECTOR_DIR.
Then all layout test related to inspector can fail after installing webkit package.

Source/WebKit/efl:

  • WebCoreSupport/InspectorClientEfl.cpp:

(WebCore::InspectorClientEfl::inspectorFilesPath):

Source/WebKit2:

  • UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::inspectorBaseURL):

6:13 PM Changeset in webkit [132017] by dpranke@chromium.org
  • 180 edits
    187 copies
    18 adds in trunk/LayoutTests

Unreviewed, new Chromium ML expectations for editing/inserting and editing/pasteboard.

(long list of new baselines omitted).

5:54 PM Changeset in webkit [132016] by dpranke@chromium.org
  • 160 edits
    160 copies
    40 adds
    3 deletes in trunk/LayoutTests

Unreviewed, new Chromium ML baselines for editing/deleting, editing/execCommand, and editing/selection

(long list of new baselines omitted).

5:32 PM Changeset in webkit [132015] by dpranke@chromium.org
  • 19 edits
    17 copies
    4 adds in trunk/LayoutTests

Unreviewed, new Chromium ML baselines for platform/chromium/virtual/gpu/fast/hidpi.

  • platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/canvas-bg-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-bg-expected.png.
  • platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png.
  • platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png.
  • platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/canvas-text-baseline-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-text-baseline-expected.png.
  • platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/canvas-transforms-during-path-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-transforms-during-path-expected.png.
  • platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/fillrect-gradient-zero-stops-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/fillrect-gradient-zero-stops-expected.png.
  • platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png.
  • platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png.
  • platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/image-pattern-rotate-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/image-pattern-rotate-expected.png.
  • platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/patternfill-repeat-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/patternfill-repeat-expected.png.
  • platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/quadraticCurveTo-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/quadraticCurveTo-expected.png.
  • platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/setWidthResetAfterForcedRender-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/setWidthResetAfterForcedRender-expected.png.
  • platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-4-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-4-expected.png.
  • platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-5-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-5-expected.png.
  • platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-6-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-6-expected.png.
  • platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-7-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-7-expected.png.
  • platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/hidpi/video-controls-in-hidpi-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/fast/hidpi/video-controls-in-hidpi-expected.png.
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-bg-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-text-baseline-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-transforms-during-path-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/fillrect-gradient-zero-stops-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/image-pattern-rotate-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/patternfill-repeat-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/quadraticCurveTo-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/setWidthResetAfterForcedRender-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-4-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-5-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-6-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-7-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/hidpi/video-controls-in-hidpi-expected.png:
  • platform/chromium/TestExpectations:
5:00 PM FeatureFlags edited by dw.im@samsung.com
(diff)
4:48 PM Changeset in webkit [132014] by dpranke@chromium.org
  • 19 edits
    15 copies
    1 add in trunk/LayoutTests

Unreviewed, add Chromium ML baselines for fast/hidpi.

  • platform/chromium-mac-lion/fast/hidpi/clip-text-in-hidpi-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/hidpi/clip-text-in-hidpi-expected.png.
  • platform/chromium-mac-lion/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/hidpi/gradient-with-scaled-ancestor-expected.png.
  • platform/chromium-mac-lion/fast/hidpi/image-set-as-background-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/hidpi/image-set-as-background-expected.png.
  • platform/chromium-mac-lion/fast/hidpi/image-set-background-dynamic-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/hidpi/image-set-background-dynamic-expected.png.
  • platform/chromium-mac-lion/fast/hidpi/image-set-background-repeat-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/hidpi/image-set-background-repeat-expected.png.
  • platform/chromium-mac-lion/fast/hidpi/image-set-background-repeat-without-size-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/hidpi/image-set-background-repeat-without-size-expected.png.
  • platform/chromium-mac-lion/fast/hidpi/image-set-border-image-comparison-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/hidpi/image-set-border-image-comparison-expected.png.
  • platform/chromium-mac-lion/fast/hidpi/image-set-border-image-dynamic-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/hidpi/image-set-border-image-dynamic-expected.png.
  • platform/chromium-mac-lion/fast/hidpi/image-set-border-image-simple-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/hidpi/image-set-border-image-simple-expected.png.
  • platform/chromium-mac-lion/fast/hidpi/image-set-in-content-dynamic-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/hidpi/image-set-in-content-dynamic-expected.png.
  • platform/chromium-mac-lion/fast/hidpi/image-set-out-of-order-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/hidpi/image-set-out-of-order-expected.png.
  • platform/chromium-mac-lion/fast/hidpi/image-set-simple-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/hidpi/image-set-simple-expected.png.
  • platform/chromium-mac-lion/fast/hidpi/image-set-without-specified-width-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/hidpi/image-set-without-specified-width-expected.png.
  • platform/chromium-mac-lion/fast/hidpi/resize-corner-hidpi-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/hidpi/resize-corner-hidpi-expected.png.
  • platform/chromium-mac-lion/fast/hidpi/video-controls-in-hidpi-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/hidpi/video-controls-in-hidpi-expected.png.
  • platform/chromium-mac-mountainlion/TestExpectations:
  • platform/chromium-mac/fast/hidpi/clip-text-in-hidpi-expected.png:
  • platform/chromium-mac/fast/hidpi/gradient-with-scaled-ancestor-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-as-background-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-background-dynamic-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-background-repeat-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-background-repeat-without-size-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-border-image-comparison-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-border-image-dynamic-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-border-image-simple-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-in-content-dynamic-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-out-of-order-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-simple-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-without-specified-width-expected.png:
  • platform/chromium-mac/fast/hidpi/resize-corner-hidpi-expected.png:
  • platform/chromium-mac/fast/hidpi/video-controls-in-hidpi-expected.png:
  • platform/chromium-win/fast/hidpi/gradient-with-scaled-ancestor-expected.png:
4:37 PM Changeset in webkit [132013] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, re-adjust Chromium Mac expectations.

  • platform/chromium/TestExpectations:
4:33 PM Changeset in webkit [132012] by dpranke@chromium.org
  • 35 edits
    32 copies
    7 moves
    1 add
    1 delete in trunk/LayoutTests

Unreviewed, new Chromium ML baselines for fast/canvas.

  • fast/canvas/canvas-incremental-repaint-expected.png: Renamed from LayoutTests/platform/efl/fast/canvas/canvas-incremental-repaint-expected.png.
  • fast/canvas/canvas-size-change-after-layout-expected.png: Renamed from LayoutTests/platform/mac/fast/canvas/canvas-size-change-after-layout-expected.png.
  • fast/canvas/canvasDrawingIntoSelf-expected.png: Renamed from LayoutTests/platform/mac/fast/canvas/canvasDrawingIntoSelf-expected.png.
  • fast/canvas/drawImage-expected.png: Renamed from LayoutTests/platform/mac/fast/canvas/drawImage-expected.png.
  • fast/canvas/shadow-offset-1-expected.png: Renamed from LayoutTests/platform/mac/fast/canvas/shadow-offset-1-expected.png.
  • fast/canvas/shadow-offset-2-expected.png: Renamed from LayoutTests/platform/mac/fast/canvas/shadow-offset-2-expected.png.
  • fast/canvas/shadow-offset-3-expected.png: Renamed from LayoutTests/platform/mac/fast/canvas/shadow-offset-3-expected.png.
  • platform/chromium-mac-lion/fast/canvas/arc360-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/arc360-expected.png.
  • platform/chromium-mac-lion/fast/canvas/canvas-before-css-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/canvas-before-css-expected.png.
  • platform/chromium-mac-lion/fast/canvas/canvas-bg-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/canvas-bg-expected.png.
  • platform/chromium-mac-lion/fast/canvas/canvas-composite-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/canvas-composite-expected.png.
  • platform/chromium-mac-lion/fast/canvas/canvas-incremental-repaint-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/canvas-incremental-repaint-expected.png.
  • platform/chromium-mac-lion/fast/canvas/canvas-resize-reset-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/canvas-resize-reset-expected.png.
  • platform/chromium-mac-lion/fast/canvas/canvas-size-change-after-layout-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/canvas-size-change-after-layout-expected.png.
  • platform/chromium-mac-lion/fast/canvas/canvas-text-alignment-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/canvas-text-alignment-expected.png.
  • platform/chromium-mac-lion/fast/canvas/canvas-text-baseline-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/canvas-text-baseline-expected.png.
  • platform/chromium-mac-lion/fast/canvas/canvas-transforms-during-path-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/canvas-transforms-during-path-expected.png.
  • platform/chromium-mac-lion/fast/canvas/canvas-zoom-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/canvas-zoom-expected.png.
  • platform/chromium-mac-lion/fast/canvas/canvasDrawingIntoSelf-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/canvasDrawingIntoSelf-expected.png.
  • platform/chromium-mac-lion/fast/canvas/check-stale-putImageData-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/check-stale-putImageData-expected.png.
  • platform/chromium-mac-lion/fast/canvas/drawImage-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/drawImage-expected.png.
  • platform/chromium-mac-lion/fast/canvas/drawImage-with-globalAlpha-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/drawImage-with-globalAlpha-expected.png.
  • platform/chromium-mac-lion/fast/canvas/fill-stroke-clip-reset-path-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/fill-stroke-clip-reset-path-expected.png.
  • platform/chromium-mac-lion/fast/canvas/fillrect-gradient-zero-stops-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/fillrect-gradient-zero-stops-expected.png.
  • platform/chromium-mac-lion/fast/canvas/fillrect_gradient-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/fillrect_gradient-expected.png.
  • platform/chromium-mac-lion/fast/canvas/image-object-in-canvas-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/image-object-in-canvas-expected.png.
  • platform/chromium-mac-lion/fast/canvas/image-pattern-rotate-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/image-pattern-rotate-expected.png.
  • platform/chromium-mac-lion/fast/canvas/patternfill-repeat-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/patternfill-repeat-expected.png.
  • platform/chromium-mac-lion/fast/canvas/quadraticCurveTo-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/quadraticCurveTo-expected.png.
  • platform/chromium-mac-lion/fast/canvas/setWidthResetAfterForcedRender-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/setWidthResetAfterForcedRender-expected.png.
  • platform/chromium-mac-lion/fast/canvas/shadow-offset-1-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/shadow-offset-1-expected.png.
  • platform/chromium-mac-lion/fast/canvas/shadow-offset-2-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/shadow-offset-2-expected.png.
  • platform/chromium-mac-lion/fast/canvas/shadow-offset-3-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/shadow-offset-3-expected.png.
  • platform/chromium-mac-lion/fast/canvas/shadow-offset-4-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/shadow-offset-4-expected.png.
  • platform/chromium-mac-lion/fast/canvas/shadow-offset-5-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/shadow-offset-5-expected.png.
  • platform/chromium-mac-lion/fast/canvas/shadow-offset-6-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/shadow-offset-6-expected.png.
  • platform/chromium-mac-lion/fast/canvas/shadow-offset-7-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/shadow-offset-7-expected.png.
  • platform/chromium-mac-lion/fast/canvas/toDataURL-alpha-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/toDataURL-alpha-expected.png.
  • platform/chromium-mac-lion/fast/canvas/zero-size-fill-rect-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/zero-size-fill-rect-expected.png.
  • platform/chromium-mac-mountainlion/TestExpectations:
  • platform/chromium-mac/fast/canvas/arc360-expected.png:
  • platform/chromium-mac/fast/canvas/canvas-before-css-expected.png:
  • platform/chromium-mac/fast/canvas/canvas-bg-expected.png:
  • platform/chromium-mac/fast/canvas/canvas-composite-expected.png:
  • platform/chromium-mac/fast/canvas/canvas-incremental-repaint-expected.png:
  • platform/chromium-mac/fast/canvas/canvas-resize-reset-expected.png:
  • platform/chromium-mac/fast/canvas/canvas-size-change-after-layout-expected.png:
  • platform/chromium-mac/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-mac/fast/canvas/canvas-text-baseline-expected.png:
  • platform/chromium-mac/fast/canvas/canvas-transforms-during-path-expected.png:
  • platform/chromium-mac/fast/canvas/canvas-zoom-expected.png:
  • platform/chromium-mac/fast/canvas/canvasDrawingIntoSelf-expected.png:
  • platform/chromium-mac/fast/canvas/check-stale-putImageData-expected.png:
  • platform/chromium-mac/fast/canvas/drawImage-expected.png:
  • platform/chromium-mac/fast/canvas/drawImage-with-globalAlpha-expected.png:
  • platform/chromium-mac/fast/canvas/fill-stroke-clip-reset-path-expected.png:
  • platform/chromium-mac/fast/canvas/fillrect-gradient-zero-stops-expected.png:
  • platform/chromium-mac/fast/canvas/fillrect_gradient-expected.png:
  • platform/chromium-mac/fast/canvas/image-object-in-canvas-expected.png:
  • platform/chromium-mac/fast/canvas/image-pattern-rotate-expected.png:
  • platform/chromium-mac/fast/canvas/patternfill-repeat-expected.png:
  • platform/chromium-mac/fast/canvas/quadraticCurveTo-expected.png:
  • platform/chromium-mac/fast/canvas/setWidthResetAfterForcedRender-expected.png:
  • platform/chromium-mac/fast/canvas/shadow-offset-1-expected.png:
  • platform/chromium-mac/fast/canvas/shadow-offset-2-expected.png:
  • platform/chromium-mac/fast/canvas/shadow-offset-3-expected.png:
  • platform/chromium-mac/fast/canvas/shadow-offset-4-expected.png:
  • platform/chromium-mac/fast/canvas/shadow-offset-5-expected.png:
  • platform/chromium-mac/fast/canvas/shadow-offset-6-expected.png:
  • platform/chromium-mac/fast/canvas/shadow-offset-7-expected.png:
  • platform/chromium-mac/fast/canvas/toDataURL-alpha-expected.png:
  • platform/chromium-mac/fast/canvas/zero-size-fill-rect-expected.png:
  • platform/chromium/TestExpectations:
  • platform/gtk/fast/canvas/canvas-incremental-repaint-expected.png: Removed.
3:51 PM Changeset in webkit [132011] by dpranke@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, expectations update for Chromium.

  • platform/chromium-mac-mountainlion/TestExpectations:
  • platform/chromium/TestExpectations:
3:39 PM Changeset in webkit [132010] by dpranke@chromium.org
  • 108 edits
    106 copies
    1 move
    12 adds
    23 deletes in trunk/LayoutTests

Unreviewed, update Chromium ML baselines for LayoutTests/css1 and optimize.

  • css1/formatting_model/floating_elements-expected.png: Renamed from LayoutTests/platform/efl/css1/formatting_model/floating_elements-expected.png.
  • platform/chromium-linux-x86/css1/basic/class_as_selector-expected.png: Removed.
  • platform/chromium-linux-x86/css1/basic/id_as_selector-expected.png: Removed.
  • platform/chromium-linux-x86/css1/box_properties/border_bottom-expected.png: Removed.
  • platform/chromium-linux-x86/css1/box_properties/margin_left-expected.png: Removed.
  • platform/chromium-linux-x86/css1/box_properties/padding_right-expected.png: Removed.
  • platform/chromium-linux-x86/css1/pseudo/anchor-expected.png: Removed.
  • platform/chromium-mac-lion/css1/basic/class_as_selector-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/basic/class_as_selector-expected.png.
  • platform/chromium-mac-lion/css1/basic/comments-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/basic/comments-expected.png.
  • platform/chromium-mac-lion/css1/basic/containment-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/basic/containment-expected.png.
  • platform/chromium-mac-lion/css1/basic/contextual_selectors-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/basic/contextual_selectors-expected.png.
  • platform/chromium-mac-lion/css1/basic/grouping-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/basic/grouping-expected.png.
  • platform/chromium-mac-lion/css1/basic/id_as_selector-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/basic/id_as_selector-expected.png.
  • platform/chromium-mac-lion/css1/basic/inheritance-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/basic/inheritance-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/acid_test-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/acid_test-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_bottom-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_bottom-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_bottom_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_bottom_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_bottom_width-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_bottom_width-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_bottom_width_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_bottom_width_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_color-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_color-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_color_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_color_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_left-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_left-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_left_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_left_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_left_width-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_left_width-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_left_width_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_left_width_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_right-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_right-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_right_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_right_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_right_width-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_right_width-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_right_width_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_right_width_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_style-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_style-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_style_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_style_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_top-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_top-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_top_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_top_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_top_width-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_top_width-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_top_width_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_top_width_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_width-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_width-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_width_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_width_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/clear-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/clear-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/clear_float-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/clear_float-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/float-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/float-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/float_elements_in_series-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/float_elements_in_series-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/float_margin-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/float_margin-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/float_on_text_elements-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/float_on_text_elements-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/height-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/height-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/margin-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/margin-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/margin_bottom-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/margin_bottom-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/margin_bottom_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/margin_bottom_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/margin_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/margin_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/margin_left-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/margin_left-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/margin_left_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/margin_left_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/margin_right-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/margin_right-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/margin_right_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/margin_right_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/margin_top-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/margin_top-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/margin_top_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/margin_top_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/padding-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/padding-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/padding_bottom-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/padding_bottom-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/padding_bottom_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/padding_bottom_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/padding_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/padding_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/padding_left-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/padding_left-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/padding_left_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/padding_left_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/padding_right-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/padding_right-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/padding_right_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/padding_right_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/padding_top-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/padding_top-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/padding_top_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/padding_top_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/width-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/width-expected.png.
  • platform/chromium-mac-lion/css1/cascade/cascade_order-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/cascade/cascade_order-expected.png.
  • platform/chromium-mac-lion/css1/cascade/important-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/cascade/important-expected.png.
  • platform/chromium-mac-lion/css1/classification/display-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/classification/display-expected.png.
  • platform/chromium-mac-lion/css1/classification/list_style-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/classification/list_style-expected.png.
  • platform/chromium-mac-lion/css1/classification/list_style_image-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/classification/list_style_image-expected.png.
  • platform/chromium-mac-lion/css1/classification/list_style_position-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/classification/list_style_position-expected.png.
  • platform/chromium-mac-lion/css1/classification/list_style_type-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/classification/list_style_type-expected.png.
  • platform/chromium-mac-lion/css1/classification/white_space-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/classification/white_space-expected.png.
  • platform/chromium-mac-lion/css1/color_and_background/background-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/color_and_background/background-expected.png.
  • platform/chromium-mac-lion/css1/color_and_background/background_attachment-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/color_and_background/background_attachment-expected.png.
  • platform/chromium-mac-lion/css1/color_and_background/background_color-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/color_and_background/background_color-expected.png.
  • platform/chromium-mac-lion/css1/color_and_background/background_image-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/color_and_background/background_image-expected.png.
  • platform/chromium-mac-lion/css1/color_and_background/background_position-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/color_and_background/background_position-expected.png.
  • platform/chromium-mac-lion/css1/color_and_background/background_repeat-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/color_and_background/background_repeat-expected.png.
  • platform/chromium-mac-lion/css1/color_and_background/color-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/color_and_background/color-expected.png.
  • platform/chromium-mac-lion/css1/conformance/forward_compatible_parsing-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/conformance/forward_compatible_parsing-expected.png.
  • platform/chromium-mac-lion/css1/font_properties/font-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/font_properties/font-expected.png.
  • platform/chromium-mac-lion/css1/font_properties/font_family-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/font_properties/font_family-expected.png.
  • platform/chromium-mac-lion/css1/font_properties/font_size-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/font_properties/font_size-expected.png.
  • platform/chromium-mac-lion/css1/font_properties/font_style-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/font_properties/font_style-expected.png.
  • platform/chromium-mac-lion/css1/font_properties/font_variant-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/font_properties/font_variant-expected.png.
  • platform/chromium-mac-lion/css1/font_properties/font_weight-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/font_properties/font_weight-expected.png.
  • platform/chromium-mac-lion/css1/formatting_model/canvas-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/formatting_model/canvas-expected.png.
  • platform/chromium-mac-lion/css1/formatting_model/floating_elements-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/formatting_model/floating_elements-expected.png.
  • platform/chromium-mac-lion/css1/formatting_model/height_of_lines-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/formatting_model/height_of_lines-expected.png.
  • platform/chromium-mac-lion/css1/formatting_model/horizontal_formatting-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/formatting_model/horizontal_formatting-expected.png.
  • platform/chromium-mac-lion/css1/formatting_model/inline_elements-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/formatting_model/inline_elements-expected.png.
  • platform/chromium-mac-lion/css1/formatting_model/replaced_elements-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/formatting_model/replaced_elements-expected.png.
  • platform/chromium-mac-lion/css1/formatting_model/vertical_formatting-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/formatting_model/vertical_formatting-expected.png.
  • platform/chromium-mac-lion/css1/pseudo/anchor-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/pseudo/anchor-expected.png.
  • platform/chromium-mac-lion/css1/pseudo/firstletter-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/pseudo/firstletter-expected.png.
  • platform/chromium-mac-lion/css1/pseudo/firstline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/pseudo/firstline-expected.png.
  • platform/chromium-mac-lion/css1/pseudo/multiple_pseudo_elements-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/pseudo/multiple_pseudo_elements-expected.png.
  • platform/chromium-mac-lion/css1/pseudo/pseudo_elements_in_selectors-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/pseudo/pseudo_elements_in_selectors-expected.png.
  • platform/chromium-mac-lion/css1/text_properties/letter_spacing-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/text_properties/letter_spacing-expected.png.
  • platform/chromium-mac-lion/css1/text_properties/line_height-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/text_properties/line_height-expected.png.
  • platform/chromium-mac-lion/css1/text_properties/text_align-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/text_properties/text_align-expected.png.
  • platform/chromium-mac-lion/css1/text_properties/text_decoration-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/text_properties/text_decoration-expected.png.
  • platform/chromium-mac-lion/css1/text_properties/text_indent-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/text_properties/text_indent-expected.png.
  • platform/chromium-mac-lion/css1/text_properties/text_transform-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/text_properties/text_transform-expected.png.
  • platform/chromium-mac-lion/css1/text_properties/vertical_align-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/text_properties/vertical_align-expected.png.
  • platform/chromium-mac-lion/css1/text_properties/word_spacing-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/text_properties/word_spacing-expected.png.
  • platform/chromium-mac-lion/css1/units/color_units-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/units/color_units-expected.png.
  • platform/chromium-mac-lion/css1/units/length_units-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/units/length_units-expected.png.
  • platform/chromium-mac-lion/css1/units/percentage_units-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/units/percentage_units-expected.png.
  • platform/chromium-mac-lion/css1/units/urls-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/units/urls-expected.png.
  • platform/chromium-mac-mountainlion/TestExpectations:
  • platform/chromium-mac/css1/basic/class_as_selector-expected.png:
  • platform/chromium-mac/css1/basic/comments-expected.png:
  • platform/chromium-mac/css1/basic/containment-expected.png:
  • platform/chromium-mac/css1/basic/contextual_selectors-expected.png:
  • platform/chromium-mac/css1/basic/grouping-expected.png:
  • platform/chromium-mac/css1/basic/id_as_selector-expected.png:
  • platform/chromium-mac/css1/basic/inheritance-expected.png:
  • platform/chromium-mac/css1/box_properties/acid_test-expected.png:
  • platform/chromium-mac/css1/box_properties/border-expected.png:
  • platform/chromium-mac/css1/box_properties/border_bottom-expected.png:
  • platform/chromium-mac/css1/box_properties/border_bottom_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/border_bottom_width-expected.png:
  • platform/chromium-mac/css1/box_properties/border_bottom_width_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/border_color-expected.png:
  • platform/chromium-mac/css1/box_properties/border_color_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/border_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/border_left-expected.png:
  • platform/chromium-mac/css1/box_properties/border_left_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/border_left_width-expected.png:
  • platform/chromium-mac/css1/box_properties/border_left_width_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/border_right-expected.png:
  • platform/chromium-mac/css1/box_properties/border_right_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/border_right_width-expected.png:
  • platform/chromium-mac/css1/box_properties/border_right_width_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/border_style-expected.png:
  • platform/chromium-mac/css1/box_properties/border_style_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/border_top-expected.png:
  • platform/chromium-mac/css1/box_properties/border_top_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/border_top_width-expected.png:
  • platform/chromium-mac/css1/box_properties/border_top_width_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/border_width-expected.png:
  • platform/chromium-mac/css1/box_properties/border_width_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/clear-expected.png:
  • platform/chromium-mac/css1/box_properties/clear_float-expected.png:
  • platform/chromium-mac/css1/box_properties/float-expected.png:
  • platform/chromium-mac/css1/box_properties/float_elements_in_series-expected.png:
  • platform/chromium-mac/css1/box_properties/float_margin-expected.png:
  • platform/chromium-mac/css1/box_properties/float_on_text_elements-expected.png:
  • platform/chromium-mac/css1/box_properties/height-expected.png:
  • platform/chromium-mac/css1/box_properties/margin-expected.png:
  • platform/chromium-mac/css1/box_properties/margin_bottom-expected.png:
  • platform/chromium-mac/css1/box_properties/margin_bottom_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/margin_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/margin_left-expected.png:
  • platform/chromium-mac/css1/box_properties/margin_left_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/margin_right-expected.png:
  • platform/chromium-mac/css1/box_properties/margin_right_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/margin_top-expected.png:
  • platform/chromium-mac/css1/box_properties/margin_top_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/padding-expected.png:
  • platform/chromium-mac/css1/box_properties/padding_bottom-expected.png:
  • platform/chromium-mac/css1/box_properties/padding_bottom_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/padding_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/padding_left-expected.png:
  • platform/chromium-mac/css1/box_properties/padding_left_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/padding_right-expected.png:
  • platform/chromium-mac/css1/box_properties/padding_right_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/padding_top-expected.png:
  • platform/chromium-mac/css1/box_properties/padding_top_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/width-expected.png:
  • platform/chromium-mac/css1/cascade/cascade_order-expected.png:
  • platform/chromium-mac/css1/cascade/important-expected.png:
  • platform/chromium-mac/css1/classification/display-expected.png:
  • platform/chromium-mac/css1/classification/list_style-expected.png:
  • platform/chromium-mac/css1/classification/list_style_image-expected.png:
  • platform/chromium-mac/css1/classification/list_style_position-expected.png:
  • platform/chromium-mac/css1/classification/list_style_type-expected.png:
  • platform/chromium-mac/css1/classification/white_space-expected.png:
  • platform/chromium-mac/css1/color_and_background/background-expected.png:
  • platform/chromium-mac/css1/color_and_background/background_attachment-expected.png:
  • platform/chromium-mac/css1/color_and_background/background_color-expected.png:
  • platform/chromium-mac/css1/color_and_background/background_image-expected.png:
  • platform/chromium-mac/css1/color_and_background/background_position-expected.png:
  • platform/chromium-mac/css1/color_and_background/background_repeat-expected.png:
  • platform/chromium-mac/css1/color_and_background/color-expected.png:
  • platform/chromium-mac/css1/conformance/forward_compatible_parsing-expected.png:
  • platform/chromium-mac/css1/font_properties/font-expected.png:
  • platform/chromium-mac/css1/font_properties/font_family-expected.png:
  • platform/chromium-mac/css1/font_properties/font_size-expected.png:
  • platform/chromium-mac/css1/font_properties/font_style-expected.png:
  • platform/chromium-mac/css1/font_properties/font_variant-expected.png:
  • platform/chromium-mac/css1/font_properties/font_weight-expected.png:
  • platform/chromium-mac/css1/formatting_model/canvas-expected.png:
  • platform/chromium-mac/css1/formatting_model/floating_elements-expected.png:
  • platform/chromium-mac/css1/formatting_model/height_of_lines-expected.png:
  • platform/chromium-mac/css1/formatting_model/horizontal_formatting-expected.png:
  • platform/chromium-mac/css1/formatting_model/inline_elements-expected.png:
  • platform/chromium-mac/css1/formatting_model/replaced_elements-expected.png:
  • platform/chromium-mac/css1/formatting_model/vertical_formatting-expected.png:
  • platform/chromium-mac/css1/pseudo/anchor-expected.png:
  • platform/chromium-mac/css1/pseudo/firstletter-expected.png:
  • platform/chromium-mac/css1/pseudo/firstline-expected.png:
  • platform/chromium-mac/css1/pseudo/multiple_pseudo_elements-expected.png:
  • platform/chromium-mac/css1/pseudo/pseudo_elements_in_selectors-expected.png:
  • platform/chromium-mac/css1/text_properties/letter_spacing-expected.png:
  • platform/chromium-mac/css1/text_properties/line_height-expected.png:
  • platform/chromium-mac/css1/text_properties/text_align-expected.png:
  • platform/chromium-mac/css1/text_properties/text_decoration-expected.png:
  • platform/chromium-mac/css1/text_properties/text_indent-expected.png:
  • platform/chromiu